[00:00:49] (03CR) 10Bsitu: [C: 032] Hygiene: Remove naming conflict with CheckUser [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155847 (owner: 10EBernhardson) [00:01:24] (03Merged) 10jenkins-bot: Hygiene: Remove naming conflict with CheckUser [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155847 (owner: 10EBernhardson) [00:02:39] (03PS1) 10Jdlrobson: i18n: Translate reply button [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155857 [00:09:42] (03CR) 10Bsitu: [C: 032] Hygiene: move phpunit tests to tests/phpunit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155848 (owner: 10EBernhardson) [00:09:45] (03Merged) 10jenkins-bot: Hygiene: move phpunit tests to tests/phpunit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155848 (owner: 10EBernhardson) [00:29:06] (03CR) 10Bsitu: [C: 032] Hygiene: Anchor is a model class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155853 (owner: 10EBernhardson) [00:29:41] (03Merged) 10jenkins-bot: Hygiene: Anchor is a model class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155853 (owner: 10EBernhardson) [00:35:02] 3MediaWiki-Vagrant: setup.bat ruins .settings.yaml file - 10https://bugzilla.wikimedia.org/69932 (10Yuri Astrakhan) 3NEW p:3Unprio s:3normal a:3Ori Livneh .settings.yaml initially contains this: ---\n git_user: yurik\n vagrant_ram: 2048\n Running setup.bat once removes the trailing '8\n', running it... [00:36:09] marxarelli ^^ [00:36:46] 3MediaWiki-Vagrant: setup.bat ruins .settings.yaml file - 10https://bugzilla.wikimedia.org/69932 (10Bryan Davis) p:5Unprio>3High a:5Ori Livneh>3Dan Duvall [00:37:27] (03PS2) 10Ori.livneh: Fix documentation for $wgResourceLoaderLESSVars [core] - 10https://gerrit.wikimedia.org/r/155304 (owner: 10Bartosz Dziewoński) [00:37:30] (03CR) 10Gergő Tisza: [C: 04-2] "__get/__set is scary, IMO it would be preferable to roll back the original change. Especially with all the parent:: calls, it's just hard " (034 comments) [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [00:37:47] (03CR) 10Ori.livneh: [C: 032] Fix documentation for $wgResourceLoaderLESSVars [core] - 10https://gerrit.wikimedia.org/r/155304 (owner: 10Bartosz Dziewoński) [00:38:05] (03CR) 10Gergő Tisza: [C: 04-1] "Oops, that wanted to be a -1." [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [00:40:08] (03CR) 10Ori.livneh: [C: 032] ResourceLoaderFileModule: Do not separately cache .less files [core] - 10https://gerrit.wikimedia.org/r/155311 (owner: 10Bartosz Dziewoński) [00:40:19] (03PS1) 10Bsitu: Set UnitTestsList hook run against files inside tests/phpunit [extensions/Echo] - 10https://gerrit.wikimedia.org/r/155858 [00:41:48] (03Merged) 10jenkins-bot: Fix documentation for $wgResourceLoaderLESSVars [core] - 10https://gerrit.wikimedia.org/r/155304 (owner: 10Bartosz Dziewoński) [00:43:10] (03Merged) 10jenkins-bot: ResourceLoaderFileModule: Do not separately cache .less files [core] - 10https://gerrit.wikimedia.org/r/155311 (owner: 10Bartosz Dziewoński) [00:43:46] 3MediaWiki-Vagrant: setup.bat ruins .settings.yaml file - 10https://bugzilla.wikimedia.org/69932 (10Dan Duvall) 5NEW>3ASSI [00:46:05] (03PS1) 10MaxSem: Split extension browser tests into a separate resource [vagrant] - 10https://gerrit.wikimedia.org/r/155860 [00:46:07] (03PS1) 10MaxSem: Split dev roles out of MobileFrontend and CirrusSearch [vagrant] - 10https://gerrit.wikimedia.org/r/155861 [00:48:11] (03CR) 10Gergő Tisza: "For the record, I don't think what Tim wrote is still true in PHP 5.3. This will result in a proper infinite recursion:" [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [00:54:16] 3MediaWiki / 3Page deletion: All the revision IDs of a page should be stored in log_params when that page is deleted - 10https://bugzilla.wikimedia.org/69049#c3 (10Nathan Larson) So is this a WONTFIX? The log_search option was opposed by Brian Wolff and the log_params option was described on IRC by legoktm a... [00:56:37] (03CR) 10BryanDavis: Split dev roles out of MobileFrontend and CirrusSearch (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/155861 (owner: 10MaxSem) [00:57:04] (03PS1) 10Dduvall: Fixed corruption of settings file on Windows [vagrant] - 10https://gerrit.wikimedia.org/r/155862 (https://bugzilla.wikimedia.org/69932) [00:57:58] (03CR) 10BryanDavis: "Probably should bump the plugin version to prompt folks to upgrade." [vagrant] - 10https://gerrit.wikimedia.org/r/155862 (https://bugzilla.wikimedia.org/69932) (owner: 10Dduvall) [00:59:39] (03PS2) 10Dduvall: Fixed corruption of settings file on Windows [vagrant] - 10https://gerrit.wikimedia.org/r/155862 (https://bugzilla.wikimedia.org/69932) [01:15:59] What is the risk (if any) of publicizing the user.tokens (editToken, patrolToken, watchToken)? How often are they refreshed automatically? [01:17:26] (03CR) 10Alex Monk: [C: 032] Dialogs: Reset values of file insertion dialog properly [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/154123 (https://bugzilla.wikimedia.org/67111) (owner: 10TheDJ) [01:17:31] (03Merged) 10jenkins-bot: Dialogs: Reset values of file insertion dialog properly [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/154123 (https://bugzilla.wikimedia.org/67111) (owner: 10TheDJ) [01:17:55] Could someone impersonate the user? (edit/delete pages on their behalf) [01:18:29] helderwiki: Well, it would make that easier, but not possible alone [01:18:59] (03Abandoned) 10Bartosz Dziewoński: [WIP] Add utility methods for language fallback chain handling in JavaScript [core] - 10https://gerrit.wikimedia.org/r/153002 (https://bugzilla.wikimedia.org/69285) (owner: 10Bartosz Dziewoński) [01:19:00] but you could then let them edit if they eg. visit a prepared web page of yours [01:19:57] helderwiki: they're invalidated when you log out [01:20:09] yep [01:26:27] (03CR) 10BryanDavis: [C: 032] "Before:" [vagrant] - 10https://gerrit.wikimedia.org/r/155854 (owner: 10Dduvall) [01:26:33] (03Merged) 10jenkins-bot: Tuned down default number of parsoid workers [vagrant] - 10https://gerrit.wikimedia.org/r/155854 (owner: 10Dduvall) [01:30:48] (03PS3) 10BryanDavis: Fixed corruption of settings file on Windows [vagrant] - 10https://gerrit.wikimedia.org/r/155862 (https://bugzilla.wikimedia.org/69932) (owner: 10Dduvall) [01:31:01] (03CR) 10BryanDavis: [C: 032 V: 031] Fixed corruption of settings file on Windows [vagrant] - 10https://gerrit.wikimedia.org/r/155862 (https://bugzilla.wikimedia.org/69932) (owner: 10Dduvall) [01:31:06] (03Merged) 10jenkins-bot: Fixed corruption of settings file on Windows [vagrant] - 10https://gerrit.wikimedia.org/r/155862 (https://bugzilla.wikimedia.org/69932) (owner: 10Dduvall) [02:27:57] (03CR) 10Chad: [C: 04-1] "+1 to being odd here. My first thought upon reading this was "why not do it at the apache level" and my second was "this sounds really eas" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155700 (owner: 10Withoutaname) [02:39:20] (03PS2) 10Jforrester: Set up an npm test pipeline for JS, CSS and banana i18n messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155833 [02:40:52] (03CR) 10Jforrester: "Good so far." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/155850 (owner: 10MarkTraceur) [02:57:03] (03CR) 10Jforrester: ""resource/" doesn't mean "This is a resource for clients", it means "This is something provided to clients via ResourceLoader"." [core] - 10https://gerrit.wikimedia.org/r/155771 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [03:19:56] (03PS1) 10BryanDavis: Tune nfs mount options [vagrant] - 10https://gerrit.wikimedia.org/r/155866 [03:39:39] (03PS17) 10Legoktm: Global merge tool [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) [03:52:44] (03PS18) 10Legoktm: Global merge tool [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) [03:53:34] (03CR) 10Legoktm: "PS17: Rebase. PS18: Added $wgCentralAuthEnableUserMerge (default disabled). Will start writing tests for a follow up patch." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) (owner: 10Legoktm) [04:14:54] (03PS19) 10Legoktm: Global merge tool [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) [04:15:24] (03CR) 10Legoktm: "PS19: Fixed a silly typo in a message key" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) (owner: 10Legoktm) [04:15:53] -.- [04:16:04] legoktm: Y u amend while I review? :D [04:16:10] sorry >.> [04:16:15] I started writing tests and noticed that :P [04:16:42] :D [04:16:45] Nice :) [04:18:31] interface IUserMergeLogger { [04:18:32] uh [04:18:44] meh, merged [04:19:13] I couldn't really think of a less hacky way to override logging [04:19:57] sure [04:20:03] but the name of the interface is bad [04:20:18] oh :P [04:20:28] what would you name it then? [04:20:40] not too late to change it [04:20:59] (03CR) 10Hoo man: Global merge tool (035 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) (owner: 10Legoktm) [04:21:14] (03CR) 10Hoo man: [C: 04-1] "Per PS18" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) (owner: 10Legoktm) [04:21:23] not exactly sure... but something which doesn't start with I [04:22:14] because the I-prefix usually pops up whenever something is getting really messy [04:22:23] (03PS1) 10Legoktm: [WIP] Tests for global merge tool [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/155867 [04:22:31] if you can, just us a reasonable generic name without the prefix [04:23:26] naming things is hard :< [04:23:40] should I create a GlobalUserMergeDatabaseUpdates class? [04:24:18] probably [04:30:31] (03CR) 10Hoo man: [C: 04-1] "I like how we start doing tests for things :)" (037 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/155867 (owner: 10Legoktm) [04:32:13] legoktm: BTW, yesterday I checked the new accounts stuff and we still have problems [04:32:24] ugh. [04:32:54] I haven't done much CA stuff this week, been busy with other things and globalcssjs [04:33:01] Yeah [04:33:09] I haven't had a chance to look at that yet [04:33:13] just so much stuffs :P [04:45:05] (03CR) 10Legoktm: Global merge tool (035 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) (owner: 10Legoktm) [04:45:07] (03PS20) 10Legoktm: Global merge tool [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) [05:09:22] (03PS2) 10TTO: Update article count when pages are moved [core] - 10https://gerrit.wikimedia.org/r/148585 (https://bugzilla.wikimedia.org/64333) [05:41:21] (03CR) 10Withoutaname: "Well, I didn't think of the rewrite rules at the time, but I was looking for a quick and easy config setting or hack within MediaWiki to f" [core] - 10https://gerrit.wikimedia.org/r/155700 (owner: 10Withoutaname) [05:54:49] (03CR) 10Chad: "Doing it at the apache level makes a whole lot more sense to me." [core] - 10https://gerrit.wikimedia.org/r/155700 (owner: 10Withoutaname) [06:19:02] (03PS1) 10Legoktm: Pass Config to ResourceLoader constructor in a few places [core] - 10https://gerrit.wikimedia.org/r/155869 [06:29:13] (03PS1) 10Legoktm: Add a test for ApiFormatNone [core] - 10https://gerrit.wikimedia.org/r/155870 [06:33:02] (03PS1) 10Legoktm: Mark ConfigFactory::destroyDefaultInstance() with @codeCoverageIgnore [core] - 10https://gerrit.wikimedia.org/r/155871 [06:45:09] 3MediaWiki extensions / 3Nuke: Allow nuke to revert a mass delete? - 10https://bugzilla.wikimedia.org/69933 (10deanator71) 3UNCO p:3Unprio s:3enhanc a:3None What happens if an user account that has the admin privileges, or has the nuke right set, had their account compromised? What if the hacker disc... [07:31:00] 3MediaWiki extensions / 3SemanticBundle: After moving a wiki, properties do not update, even with a newly created page - 10https://bugzilla.wikimedia.org/69894#c2 (10Jeroen De Dauw) The SMW issue tracker is here: https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues [07:40:34] (03PS1) 10Legoktm: Import.php: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/155872 [07:58:31] (03PS1) 10Legoktm: Turn MessageBlobStore into a singleton instead of static functions [core] - 10https://gerrit.wikimedia.org/r/155873 [07:58:33] (03PS1) 10Legoktm: MessageBlobStore: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/155874 [08:13:40] (03PS1) 10Legoktm: MimeMagic: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/155875 [08:14:05] (03PS1) 10Legoktm: Use MimeMagic::singleton() instead of instantiating a new class [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/155876 [08:18:11] (03PS1) 10Legoktm: Pager: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/155877 [08:18:34] (03CR) 10Hashar: "> Let's put a maximum comment period on this of 1 week. If no one responds negatively by the 31st (and no one has +2'd it by then), then " [tools/code-utils] - 10https://gerrit.wikimedia.org/r/155772 (owner: 10Rillke) [08:21:03] (03PS1) 10Umherirrender: Use config instead of globals for Preferences [core] - 10https://gerrit.wikimedia.org/r/155878 [08:31:38] (03PS1) 10Legoktm: ProtectionForm: Stop using global objects [core] - 10https://gerrit.wikimedia.org/r/155879 [08:32:31] (03CR) 10Legoktm: "Hmmm https://gerrit.wikimedia.org/r/#/c/155208/ ;)" [core] - 10https://gerrit.wikimedia.org/r/155878 (owner: 10Umherirrender) [08:53:27] (03PS1) 10Umherirrender: Use config instead of globals for OutputPage [core] - 10https://gerrit.wikimedia.org/r/155880 [08:54:45] (03CR) 10Umherirrender: "Yah, I will take a break. Is there a list of globals which should not be changed? Things like wgParser, wgLang, wgLanguageCode, wgAuth, .." [core] - 10https://gerrit.wikimedia.org/r/155878 (owner: 10Umherirrender) [08:55:12] (03Abandoned) 10Umherirrender: Use config instead of globals for Preferences [core] - 10https://gerrit.wikimedia.org/r/155878 (owner: 10Umherirrender) [09:08:00] 3MediaWiki / 3ResourceLoader: Gerrit 152122 breaks scripts on Firefox - 10https://bugzilla.wikimedia.org/69924#c1 (10Michael M.) (In reply to Fomafix from comment #0) > A possible workaround is to put this in an additional closure because > > if ( true ) { > ( function () { > foo(); > functio... [09:17:30] 3MediaWiki / 3Skin and page rendering: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c29 (10Michael M.) (In reply to Erwin Dokter from comment #27) > Commons files are no more stable; the ones without protection are vulnerable... [10:10:32] Holy dependancies batman. [10:14:08] Lcawte: Hi. [10:15:01] 3MediaWiki / 3ResourceLoader: Gerrit 152122 breaks scripts on Firefox - 10https://bugzilla.wikimedia.org/69924#c2 (10Fomafix) > This will break all scripts using var foo = 'bar'; to set global variables, > as it will turn them into local ones. Oh, yes. This would generate other problems. [10:15:04] Morning. [10:16:22] Lcawte: Do you use Vagrant? [10:16:26] Nope [10:16:38] it might help with (some) dependencies problems [10:16:44] It's not that... [10:17:03] what is then? [10:17:35] I've just started looking at a skin that's pretty much unmaintained. It extends ModernTemplate, which in turn extends MonoBookTemplate (which, presumably extends whatever core template?) [10:18:39] BaseTemplate. *sigh* [10:21:14] I wouldn't touch (or fix) skins now. They're in the process of making them "only html and css" as a GSoC project I think. [10:25:34] Doesn't look like it... [10:31:48] lol, the entire template was wrapped in wfSuppressWarnings... no wonder I couldn't find any output to tell me what wasn't working. [10:33:16] !class Linker | Lcawte [10:33:16] Lcawte: See https://doc.wikimedia.org/mediawiki-core/master/php/html/classLinker.html [10:36:32] (03CR) 10Addshore: [C: 032] Mark ConfigFactory::destroyDefaultInstance() with @codeCoverageIgnore [core] - 10https://gerrit.wikimedia.org/r/155871 (owner: 10Legoktm) [10:37:31] (03CR) 10Addshore: [C: 032] Add a test for ApiFormatNone [core] - 10https://gerrit.wikimedia.org/r/155870 (owner: 10Legoktm) [10:39:26] (03Merged) 10jenkins-bot: Mark ConfigFactory::destroyDefaultInstance() with @codeCoverageIgnore [core] - 10https://gerrit.wikimedia.org/r/155871 (owner: 10Legoktm) [10:40:43] (03Merged) 10jenkins-bot: Add a test for ApiFormatNone [core] - 10https://gerrit.wikimedia.org/r/155870 (owner: 10Legoktm) [11:02:57] (03CR) 10JanZerebecki: "Thank you for working on this!" [core] - 10https://gerrit.wikimedia.org/r/155700 (owner: 10Withoutaname) [11:16:10] (03CR) 10Addshore: "Yes, we should roll back to PS4 and merge this before the next branch for release.." [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [11:17:03] (03CR) 10Addshore: [C: 032] Add more tests for GlobalVarConfig [core] - 10https://gerrit.wikimedia.org/r/155217 (owner: 10Legoktm) [11:19:30] 3MediaWiki / 3ResourceLoader: Gerrit 152122 breaks scripts on Firefox - 10https://bugzilla.wikimedia.org/69924#c3 (10Derk-Jan Hartman) I had to fix a user's userscript yesterday due to this bug. [11:20:25] (03Merged) 10jenkins-bot: Add more tests for GlobalVarConfig [core] - 10https://gerrit.wikimedia.org/r/155217 (owner: 10Legoktm) [11:26:47] 3Wikimedia / 3Mailing lists: Please help reset moderator password for the list Wikipedia-ne@lists.wikimedia.org - 10https://bugzilla.wikimedia.org/69935 (10Saroj Kumar Dhakal) 3UNCO p:3Unprio s:3normal a:3None Hi, Could you please help reset moderator password for the list Wikipedia-ne@lists.wikimed... [11:33:49] 3Wikimedia / 3Wikidata: Accessing Wikipedia.org on (http://en.wikipedia.org/wiki/Vitamin_C) causes screen overlap. - 10https://bugzilla.wikimedia.org/69936 (10Johan Fourie) 3UNCO p:3Unprio s:3minor a:3Wikidata bugs Intention: I am trying to access the wikipedia page for Vitamin C. http://en.wikipedia... [11:46:30] 3MediaWiki / 3ResourceLoader: Gerrit 152122 breaks scripts on Firefox - 10https://bugzilla.wikimedia.org/69924 (10Helder) [11:54:32] anyone here who could mwgrep for "imagelist"? [11:55:35] ah, nevermind, not going to be much use of that anyway [12:01:50] (03PS1) 10Bartosz Dziewoński: Remove unused styles for .imagelist [core] - 10https://gerrit.wikimedia.org/r/155887 [12:14:45] 3MediaWiki / 3Maintenance scripts: deleteOldRevisions.php deletes content text from current revisions - 10https://bugzilla.wikimedia.org/66615#c11 (10sen) i running it in 1.22 version.that's so wired.. i was dump the wiki before,so here is the not yet run script 3MediaWiki / 3Maintenance scripts: deleteOldRevisions.php deletes content text from current revisions - 10https://bugzilla.wikimedia.org/66615#c12 (10sen) and this is the after: only left a comment with the byte size is right,but just blank page: 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c4 (10Helder) (In reply to Fomafix from comment #0) > ... > A possible workaround is to put this in an additional closure ... For that, see bug 63728. [12:17:32] 3MediaWiki / 3JavaScript: ResourceLoader: User scripts should not execute in global scope - 10https://bugzilla.wikimedia.org/63728 (10Helder) [12:25:30] (03PS1) 10Bartosz Dziewoński: Split includes/Pager.php [core] - 10https://gerrit.wikimedia.org/r/155888 [12:27:45] 3Wikimedia / 3Site requests: No longer allow gadgets to be turned on by default for all users on Wikimedia sites - 10https://bugzilla.wikimedia.org/58236 (10Helder) [12:28:01] 3MediaWiki extensions / 3Gadgets: Allow for gadgets to be turned on by default - 10https://bugzilla.wikimedia.org/13742 (10Helder) [12:33:16] 3MediaWiki / 3JavaScript: mediawiki.language.numbers.js can trigger an endless loop - 10https://bugzilla.wikimedia.org/69835 (10Santhosh Thottingal) 5NEW>3ASSI a:3Santhosh Thottingal [12:41:04] santhosh, hi [12:46:45] 3MediaWiki / 3Parser: Add non-breaking spaces in additional places automatically - 10https://bugzilla.wikimedia.org/13619#c29 (10Matthias Becker) It would be helpful to fix this bug at least vor numbers and SI units and perhaps some widely used non-SI units (as ft, kn/kt mph, sm/nm) [12:58:15] (03PS21) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [12:58:32] (03PS17) 10Paladox: WikiEditor: Convert .css to .less and add SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 [13:00:30] (03PS1) 10Bartosz Dziewoński: Be consistent about 'TablePager' CSS class usage [core] - 10https://gerrit.wikimedia.org/r/155891 [13:51:59] (03CR) 10Rillke: "Asked Tim in IRC; see https://www.mediawiki.org/wiki/User:Tim_Starling and http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki/20140716.txt " [tools/code-utils] - 10https://gerrit.wikimedia.org/r/155772 (owner: 10Rillke) [13:57:46] 3MediaWiki extensions / 3Translate: [TUX] Browser support matrix - 10https://bugzilla.wikimedia.org/45602#c6 (10Nemo) https://www.mediawiki.org/wiki/Compatibility was recently updated and may serve as starting point; there is no need to restate the obvious, but it's useful to highlight any deviation from com... [13:58:15] 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924 (10Andre Klapper) p:5Unprio>3High [14:12:01] 3Wikimedia / 3General/Unknown: Accessing Wikipedia.org on (http://en.wikipedia.org/wiki/Vitamin_C) causes screen overlap. - 10https://bugzilla.wikimedia.org/69936#c1 (10Andre Klapper) a:5Wikidata bugs>3None Thanks for taking the time to report this! Do you get the "classic" view, or the mobile view on t... [14:12:59] 3MediaWiki extensions / 3Translate: [TUX] Browser support matrix - 10https://bugzilla.wikimedia.org/45602#c7 (10Nemo) On (c), https://wikimedia.mingle.thoughtworks.com/projects/language_engineering/cards/4381 mentions IE, Firefox, Safari and Chrome, but no versions. [14:18:13] (03CR) 10Alex Monk: Make GadgetResourceLoaderModule a simple wrapper around Gadget (031 comment) [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154725 (owner: 10Legoktm) [14:19:44] 3MediaWiki extensions / 3UniversalLanguageSelector: Investigate noto font as potential replacement for diverse font families - 10https://bugzilla.wikimedia.org/59983#c7 (10Nemo) Found by chance today: https://wikimedia.mingle.thoughtworks.com/projects/language_engineering/cards/4421?version=2 [14:23:40] (03CR) 10Alex Monk: Make GadgetResourceLoaderModule a simple wrapper around Gadget (031 comment) [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154725 (owner: 10Legoktm) [14:23:54] (03PS2) 10Alex Monk: Make GadgetResourceLoaderModule a simple wrapper around Gadget [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154725 (owner: 10Legoktm) [14:36:01] 3MediaWiki / 3ResourceLoader: Wrapping user scripts with "if(window.mw){...}" breaks them on Firefox - 10https://bugzilla.wikimedia.org/69924#c5 (10Fomafix) $.globalEval() [1] as suggested in bug 63587 would be a possible solution. Maybe this can added as a general optional parameter for all modules. [1] h... [14:37:39] (03CR) 10Alex Monk: "more irrelevant comments" (032 comments) [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154725 (owner: 10Legoktm) [14:37:53] (03PS1) 10Bartosz Dziewoński: ArticleTable: Remove useless getBody() override [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/155897 [14:43:45] 3MediaWiki / 3ResourceLoader: ResourceLoader: Avoid making a separate request for the site module - 10https://bugzilla.wikimedia.org/63587 (10Helder) [14:43:47] 3MediaWiki / 3JavaScript: ResourceLoader: User scripts should not execute in global scope - 10https://bugzilla.wikimedia.org/63728 (10Helder) [14:46:53] (03CR) 10Manybubbles: [C: 031] Split dev roles out of MobileFrontend and CirrusSearch [vagrant] - 10https://gerrit.wikimedia.org/r/155861 (owner: 10MaxSem) [15:07:10] (03CR) 10Alex Monk: [C: 032] "This change looks fine anyway" [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154725 (owner: 10Legoktm) [15:07:16] (03Merged) 10jenkins-bot: Make GadgetResourceLoaderModule a simple wrapper around Gadget [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154725 (owner: 10Legoktm) [15:11:38] (03PS1) 10Alex Monk: Pass arrays to array_merge, instead of Titles and TitleArray iterator objects [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/155898 [15:12:58] (03PS2) 10Alex Monk: Pass arrays to array_merge, instead of Titles and TitleArray iterator objects [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/155898 [15:14:08] (03CR) 10Alex Monk: "See also Iffcbb3a6 for those comments" [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154725 (owner: 10Legoktm) [15:14:51] (03PS4) 10Alex Monk: Refactor Gadget constructor [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154750 (https://bugzilla.wikimedia.org/69368) (owner: 10Legoktm) [15:15:12] (03PS2) 10Alex Monk: Add a test for Gadget::__construct [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154751 (owner: 10Legoktm) [15:18:15] 3MediaWiki extensions / 3CentralAuth: login when already logged in gets exception from Special:CentralLogin - 10https://bugzilla.wikimedia.org/69834#c1 (10Andre Klapper) p:5Normal>3High It is pretty confusing when you go to https://en.wikipedia.org/wiki/Special:UserLogin?useNew=1 (being already logged in... [15:20:47] 3MediaWiki / 3Parser: Add non-breaking spaces in additional places automatically - 10https://bugzilla.wikimedia.org/13619#c30 (10Dan Kindsvater) Thanks Matthias. Would really be nice to see movement on this after all these years ... it would make VE so much prettier too if we didn't have to deal with some nb... [15:20:47] 3MediaWiki / 3Skin and page rendering: checkboxes don't show Agora focus highlight - 10https://bugzilla.wikimedia.org/47902#c1 (10Andre Klapper) I don't see much difference (or any real checkbox shadow) in behavior between Chrome 36 and Firefox 31 here. How is this supposed to look? [15:21:02] 3MediaWiki / 3General/Unknown: Deprecate direct access to class variables - 10https://bugzilla.wikimedia.org/69939 (10s7eph4n) 3NEW p:3Unprio s:3normal a:3None In MW 1.24 an effort was made to improve code quality by making it phpcs-strict compliant [0]. This involves explicitly declaring the visibil... [15:30:30] 3MediaWiki / 3Special pages: Have listing special pages show watched pages in bold - 10https://bugzilla.wikimedia.org/16922#c1 (10Andre Klapper) Request still valid in 1.24 for Special:DeadendPages and Special:LongPages [15:44:47] 3MediaWiki extensions / 3TranslationNotifications: Duplicate talk page translation notifications sent to some users - 10https://bugzilla.wikimedia.org/69940 (10Nemo) 3NEW p:3Unprio s:3normal a:3None I checked the last round of translation notifications and out of few hundreds edits there were 4 which... [15:45:00] 3MediaWiki / 3Database: Scripts that wait for lagged database servers should ignore those out of rotation - 10https://bugzilla.wikimedia.org/16993#c1 (10Andre Klapper) Five years later: Is this still relevant? Which file is that about (if still in MediaWiki code base at all)? core/includes/specials/Special... [15:55:48] 3MediaWiki / 3Page editing: Image mistakenly included in paragraph anchor - 10https://bugzilla.wikimedia.org/16959#c1 (10Andre Klapper) (In reply to Church of emacs from comment #0) > Now see this diff which was done by editing the section. Note the automated > part of the edit summary: > http://de.wikipedia... [15:56:45] 3MediaWiki extensions / 3TranslationNotifications: Duplicate talk page translation notifications sent to some users - 10https://bugzilla.wikimedia.org/69940#c1 (10Nemo) Note that in some of those there are slight differences between the two copies. [16:07:00] 3MediaWiki / 3Parser: Media: links mishandled - 10https://bugzilla.wikimedia.org/16933#c1 (10Andre Klapper) 5NEW>3RESO/WOR (In reply to Danny B. from comment #0) > Type Media:Glottal stop.ogg into search box on any wiki. It will take you to > the bage with URL /wiki/Media:Glottal stop.ogg, but the headli... [16:15:30] 3MediaWiki / 3Uploading: Special uploadtext for the reupload form - 10https://bugzilla.wikimedia.org/17194#c1 (10Andre Klapper) 5NEW>3UNCO Lupo: Setting a summary via a URL parameter works for me for "normal" uploads (not reuploading): https://en.wikipedia.org/wiki/Special:Upload?wpUploadDescription=foob... [16:18:09] (03PS14) 10Foxtrott: Fix for Ia9baaf0b: magic functions for previously public class members [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) [16:18:30] 3MediaWiki / 3General/Unknown: Control TOC level/depth displayed per page - 10https://bugzilla.wikimedia.org/17353#c1 (10Andre Klapper) p:5Low>3Lowest Hi David! Sorry that nobody has taken a look at this report yet and given feedback. Could you describe what you would like to achieve, and why? See https... [16:22:25] (03CR) 10Foxtrott: "@Addshore: Then we'll never get those variables protected/private." [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [16:23:26] (03PS15) 10Foxtrott: Fix for Ia9baaf0b: magic functions for previously public class members [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) [16:24:30] 3MediaWiki / 3Parser: Media: links mishandled - 10https://bugzilla.wikimedia.org/16933#c2 (10Danny B.) 5RESO/WOR>3REOP Obviously not, but yet worse. The Media:Foo.ogg/jpeg/gif/etc... link is supposed to take you directly to the media file, but not to the File page. So now the "Media" namespace behaves e... [16:26:30] (03CR) 10Foxtrott: Fix for Ia9baaf0b: magic functions for previously public class members (034 comments) [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [16:29:01] (03PS1) 10Bartosz Dziewoński: OutputPage: addParserOutput*() family doesn't need to take a reference [core] - 10https://gerrit.wikimedia.org/r/155902 [16:29:03] (03PS1) 10Bartosz Dziewoński: TablePager: Modernize style loading [core] - 10https://gerrit.wikimedia.org/r/155903 [16:33:34] ... ok, so I'm confused. 'MWException' with message 'ResourceLoaderFileModule::readStyleFile: style file not found: "/var/www/w/skins/Daddio/skins/common/shared.css"' localBasePath for my skin is set to __DIR__, the module style is skins/common.css ... I comment that line out, and trying to load styles from: [16:34:16] "screen": [ "http://lewiscawte-test.me/w/daddio/main.css" [16:34:47] skins/common/shared.css* [16:36:32] (03CR) 10jenkins-bot: [V: 04-1] TablePager: Modernize style loading [core] - 10https://gerrit.wikimedia.org/r/155903 (owner: 10Bartosz Dziewoński) [16:37:07] Lcawte: uh [16:37:14] that doesn't sounds right [16:37:17] link to the code? [16:37:46] Lcawte: you should be loading the mediawiki.legacy.shared module rather than referencing the filename directly [16:37:47] MatmaRex: I'll pastebin things, hang on (also note, that wiki isn't public, I changed my hosts file to point that to localhost) [16:43:33] 3MediaWiki extensions / 3TwitterCards: evaluate image handling/license compliance - 10https://bugzilla.wikimedia.org/69941 (10Luis Villa (WMF Legal)) 3NEW p:3Unprio s:3normal a:3None As a general matter, under US law (and the extensive precedents set by Google), text snippets and image thumbnails of... [16:43:43] MatmaRex: http://pastebin.com/XdGcbtpn ... [16:44:20] Lcawte: you don't have a removeBasePath, so it defaults to $wgScriptPath [16:44:23] remote* [16:44:49] 3Wikimedia / 3Extension setup: Run 1 month test of TwitterCard extension on all wikis - 10https://bugzilla.wikimedia.org/64930#c11 (10Luis Villa (WMF Legal)) Adding an extra blocker. It's from me, so you know what it is about :) [16:44:49] 3MediaWiki extensions / 3TwitterCards: evaluate image handling/license compliance - 10https://bugzilla.wikimedia.org/69941 (10Luis Villa (WMF Legal)) [16:45:24] Lcawte: you probably want 'remoteSkinPath' => 'daddio', (assuming you're okay with dropping support for 1.23 and older) [16:45:35] 3Wikimedia / 3General/Unknown: Sharing a Wikimedia Commons file description on Twitter should use a Twitter card - 10https://bugzilla.wikimedia.org/61487#c2 (10Luis Villa (WMF Legal)) See also bug 64930. [16:45:45] or remoteBasePath something something [16:46:14] MatmaRex: But when I uncomment the line with skins/common/shared.css in, it adds the path to skins/Daddio in before it... [16:46:29] oh, hang on... yeah, I see what you mean. [16:46:57] Lcawte: remove that line and load 'mediawiki.legacy.shared' module in addition to 'skins.daddio' module [16:49:13] there's a daddio skin? [16:50:13] ori: It's some thing that was formerly in extensions/skins/ and got split out yesterday. It's basicly a bit of CSS on top of Modern as far as I can tell. [16:50:30] ah [16:52:01] 3MediaWiki / 3User preferences: Preferences/Gadgets values are unpredictably boolean, integers or other - 10https://bugzilla.wikimedia.org/52542#c3 (10Helder) (In reply to Bartosz Dziewoński from comment #1) > ... > normalizing values of boolean prefs to true/false just before building this > list (in Resour... [16:55:17] 3MediaWiki / 3User preferences: Preferences/Gadgets values are unpredictably boolean, integers or other - 10https://bugzilla.wikimedia.org/52542 (10Helder) [16:55:52] How do I switch to RTL, just uselang= an RTL language? [16:57:51] yep [16:58:16] 3MediaWiki / 3Parser: Media: links behave like File: links and do not directly take you to the media file - 10https://bugzilla.wikimedia.org/16933 (10Andre Klapper) [17:06:09] (03CR) 10Gergő Tisza: "@Foxtrott: reentrancy behavior of __get (i.e. invoking __get from __get, or from another function which has been invoked from __get) is po" [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [17:18:03] (03PS1) 10Lewis Cawte: Some cleanup to Daddio skin. [skins/Daddio] - 10https://gerrit.wikimedia.org/r/155905 [17:18:05] (03PS1) 10Lewis Cawte: Some cleanup of Daddio skin. [skins/Daddio] - 10https://gerrit.wikimedia.org/r/155906 [17:18:07] (03PS1) 10Lewis Cawte: Fix ResourceLoader calls. [skins/Daddio] - 10https://gerrit.wikimedia.org/r/155907 [17:18:23] (Yes, I know there are three patchsets) [17:37:45] 3Wikimedia / 3General/Unknown: user_properties table bloat - 10https://bugzilla.wikimedia.org/52777#c20 (10Helder) (In reply to Nemo from comment #19) > If you're willing to merge it, that's ok. But let's see how > I1da936c786adb21e2c1802ef405bb904c9cf4918 goes. That patch was merged. [17:47:21] (03CR) 10Bartosz Dziewoński: "The functions that evolved into this family were originally added in r12337 by Tim (http://mediawiki.org/wiki/Special:Code/MediaWiki/12337" [core] - 10https://gerrit.wikimedia.org/r/155902 (owner: 10Bartosz Dziewoński) [17:48:21] anyone wants to merge some simple code cleanup? https://gerrit.wikimedia.org/r/#/c/155902/ and its three dependencies are waiting [17:50:21] (03PS2) 10Bartosz Dziewoński: TablePager: Modernize style loading [core] - 10https://gerrit.wikimedia.org/r/155903 [17:51:08] (03CR) 10Bartosz Dziewoński: "Critical reviews of the ResourceLoader-related code in TablePager.php very welcome." [core] - 10https://gerrit.wikimedia.org/r/155903 (owner: 10Bartosz Dziewoński) [17:54:00] 3MediaWiki extensions / 3Nuke: Allow nuke to revert a mass delete - 10https://bugzilla.wikimedia.org/69933 (10Étienne Beaulé) 5UNCO>3NEW p:5Unprio>3Normal [17:57:39] (03PS3) 10Bartosz Dziewoński: TablePager: Modernize style loading [core] - 10https://gerrit.wikimedia.org/r/155903 [18:23:02] 3MediaWiki / 3API: Updating user preferences via API gives inconsistent results - 10https://bugzilla.wikimedia.org/69942 (10Tisza Gergő) 3NEW p:3Unprio s:3normal a:3None We are experiencing this with the MediaViewer enabled flag. MediaViewer is set up as follows: the preference is defined as $p... [18:37:41] how come I still see this in some of the jenkins reports: https://bugzilla.wikimedia.org/show_bug.cgi?id=66092 [18:37:50] is it still awaiting deployment [18:42:17] 3MediaWiki extensions / 3Translate: [PagePreparation] Links to Special pages should not be MyLanguage'd - 10https://bugzilla.wikimedia.org/69943 (10MF-Warburg) 3NEW p:3Unprio s:3normal a:3Pratik Lahoti It makes no sense to prefix links to Special: pages with "Special:MyLanguage/". [18:42:30] 3MediaWiki extensions / 3Translate: Special page for migration of legacy translation pages (tracking) - 10https://bugzilla.wikimedia.org/65740 (10MF-Warburg) [18:44:25] (03PS1) 10Bartosz Dziewoński: TablePager: Load images via CSS backgrounds rather than HTML s [core] - 10https://gerrit.wikimedia.org/r/155910 (https://bugzilla.wikimedia.org/69277) [18:44:32] 3MediaWiki / 3Skin and page rendering: Table pager navigation arrows (used on e.g. [[Special:AllMessages]]) missing SVG versions - 10https://bugzilla.wikimedia.org/69944 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None Table pager navigation arrows (used on e.g. [[Special:AllMessages]]) are mi... [18:44:32] 3MediaWiki / 3General/Unknown: High-density display issues (tracking) xhdpi hdpi Retina high-resolution HiDPI - 10https://bugzilla.wikimedia.org/32101 (10Bartosz Dziewoński) [18:45:00] 3MediaWiki extensions / 3Translate: Special:PageMigration and Special:PagePreparation don't react to enter - 10https://bugzilla.wikimedia.org/69271#c2 (10MF-Warburg) If that is not ok (I have no idea), a text explaining that one has no click would be helpful. [18:48:01] 3MediaWiki extensions / 3Translate: Special page for migration of legacy translation pages (tracking) - 10https://bugzilla.wikimedia.org/65740 (10MF-Warburg) [18:48:04] 3MediaWiki extensions / 3Translate: [PagePreparation] Edit summary should use site language - 10https://bugzilla.wikimedia.org/69945 (10MF-Warburg) 3NEW p:3Unprio s:3normal a:3Pratik Lahoti See e.g. . The summary sh... [18:50:16] 3MediaWiki / 3User preferences: Preferences/Gadgets values are unpredictably boolean, integers or other - 10https://bugzilla.wikimedia.org/52542 (10Bartosz Dziewoński) [18:50:19] 3MediaWiki / 3API: Updating user preferences via API gives inconsistent results - 10https://bugzilla.wikimedia.org/69942#c1 (10Bartosz Dziewoński) Doesn't setting the preference to '0' / '1' via API always work as expected? The inconsistent values are tracked as bug 52542. [19:03:15] (03CR) 10Alex Monk: Add blanket support for mediawiki ui via globals (031 comment) [core] - 10https://gerrit.wikimedia.org/r/150635 (owner: 10Jdlrobson) [19:13:45] 3MediaWiki / 3API: Updating user preferences via API gives inconsistent results - 10https://bugzilla.wikimedia.org/69942#c2 (10Tisza Gergő) (In reply to Bartosz Dziewoński from comment #1) > Doesn't setting the preference to '0' / '1' via API always work as expected? Depends on your definition of "work as e... [19:21:03] (03PS1) 10Helder.wiki: Allow custom event handlers for the click event of toolbar buttons [core] - 10https://gerrit.wikimedia.org/r/155912 [19:28:41] (03CR) 10Umherirrender: "Created I6f5a677248011761c3c6b08efd7d28367ca0eeb6 for changes to user groups on wmf wikis. Changes to global groups (Global_sysop, New_wik" [core] - 10https://gerrit.wikimedia.org/r/154452 (owner: 10Umherirrender) [19:30:40] [03:31:48] lol, the entire template was wrapped in wfSuppressWarnings... no wonder I couldn't find any output to tell me what wasn't working. <-- bahahaha [19:30:54] (03CR) 10Legoktm: [C: 032] Pass arrays to array_merge, instead of Titles and TitleArray iterator objects [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/155898 (owner: 10Alex Monk) [19:31:00] (03Merged) 10jenkins-bot: Pass arrays to array_merge, instead of Titles and TitleArray iterator objects [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/155898 (owner: 10Alex Monk) [19:31:30] 3MediaWiki / 3Categories: Categories don't react well to their members moving between special-cased namespaces (Category ↔ File ↔ (other)) - 10https://bugzilla.wikimedia.org/69740 (10Andre Klapper) p:5Unprio>3Low [19:31:30] (03CR) 10John F. Lewis: [C: 04-1] "Duplicate right definitions in DefaultSettings" [core] - 10https://gerrit.wikimedia.org/r/154452 (owner: 10Umherirrender) [19:31:45] 3MediaWiki / 3Parser: Tooltip of the magnify link ("Enlarge", 'thumbnail-more') cached in wrong language - 10https://bugzilla.wikimedia.org/69695 (10Andre Klapper) p:5Unprio>3Normal [19:35:30] 3MediaWiki / 3Templates: Template transclusion done "behind the scenes" when saving a user .js page - 10https://bugzilla.wikimedia.org/8761#c4 (10Andre Klapper) (In reply to Dan Collins from comment #3) > This problem may be a duplicate of bug 8449. Yeah, sounds like. Anybody eles agreeing that this is a dup? [19:38:14] 3MediaWiki / 3History/Diffs: Add "export" links in revision history. - 10https://bugzilla.wikimedia.org/15686#c1 (10Andre Klapper) (In reply to Purodha Blissenbach from comment #0) > In the revision history pages, we could add an "export" link to each > revision line which would link to Special:Export having... [19:40:34] (03PS1) 10Bartosz Dziewoński: TablePager: Redo arrow icons from scratch as CSS backgrounds [core] - 10https://gerrit.wikimedia.org/r/155914 (https://bugzilla.wikimedia.org/69277) [19:41:05] (03CR) 10Legoktm: [C: 032] Remove unused styles for .imagelist [core] - 10https://gerrit.wikimedia.org/r/155887 (owner: 10Bartosz Dziewoński) [19:42:10] (03CR) 10Legoktm: [C: 032] Split includes/Pager.php [core] - 10https://gerrit.wikimedia.org/r/155888 (owner: 10Bartosz Dziewoński) [19:43:08] (03CR) 10Legoktm: [C: 032] Be consistent about 'TablePager' CSS class usage [core] - 10https://gerrit.wikimedia.org/r/155891 (owner: 10Bartosz Dziewoński) [19:44:00] 3MediaWiki / 3User preferences: Image and thumbsize reset to defaults in the new preferences - 10https://bugzilla.wikimedia.org/18605#c3 (10Bartosz Dziewoński) 5NEW>3RESO/WOR Whatever the issue was in 2009, I think it's pretty clear that is not going to be fixed. The preferences work today. [19:45:05] MatmaRex: https://gerrit.wikimedia.org/r/#/c/155902/1 shouldn't break anything like extensions right? [19:45:21] (03Merged) 10jenkins-bot: Remove unused styles for .imagelist [core] - 10https://gerrit.wikimedia.org/r/155887 (owner: 10Bartosz Dziewoński) [19:45:54] (03Merged) 10jenkins-bot: Split includes/Pager.php [core] - 10https://gerrit.wikimedia.org/r/155888 (owner: 10Bartosz Dziewoński) [19:46:03] legoktm: afaik yes, the pass-by-reference was useless, but i am not schooled in the dirty internals of PHP [19:46:59] (03CR) 10Legoktm: "What is duplicated?" [core] - 10https://gerrit.wikimedia.org/r/154452 (owner: 10Umherirrender) [19:47:00] 3Wikimedia / 3General/Unknown: Resource loader ignores requested caching directives / not caching properly - 10https://bugzilla.wikimedia.org/69460#c4 (10Andre Klapper) Mark: Any comments, as you worked on that change? [19:47:01] (03Merged) 10jenkins-bot: Be consistent about 'TablePager' CSS class usage [core] - 10https://gerrit.wikimedia.org/r/155891 (owner: 10Bartosz Dziewoński) [19:47:14] (03CR) 10Legoktm: [C: 032] OutputPage: addParserOutput*() family doesn't need to take a reference [core] - 10https://gerrit.wikimedia.org/r/155902 (owner: 10Bartosz Dziewoński) [19:48:10] (03PS2) 10Bartosz Dziewoński: OutputPage: addParserOutput*() family doesn't need to take a reference [core] - 10https://gerrit.wikimedia.org/r/155902 [19:48:16] (tweaked summary) [19:48:28] (03PS3) 10Bartosz Dziewoński: OutputPage: addParserOutput*() family doesn't need to take a reference [core] - 10https://gerrit.wikimedia.org/r/155902 [19:48:56] (03CR) 10John F. Lewis: "Misread actually." [core] - 10https://gerrit.wikimedia.org/r/154452 (owner: 10Umherirrender) [19:51:53] MatmaRex: soooo why does https://gerrit.wikimedia.org/r/#/c/155903/3/includes/pager/TablePager.php,cm need to re-implement makeResourceLoaderLink? [19:52:13] legoktm: it's protected [19:52:45] 3MediaWiki / 3Templates: Template transclusion done "behind the scenes" when saving a user .js page - 10https://bugzilla.wikimedia.org/8761#c5 (10Helder) I don't think so. I think that problem is fixed, because nowadays templates are not expanded in any way that would increase the size of JS and CSS pages. [19:52:47] (and rightly so, this code shouldn't have to do this) [19:52:57] well yes. why can't you just use $out->addModuleStyles? [19:54:04] hm. that's a bit ew [19:54:39] i guess technically we shouldn't assume our OutputPage is going to be the same one where the result will be appended? [19:54:50] that might actually be a good idea, though [19:55:21] I think making that assumption is a lot less worse than what you're doing right now :P [19:56:05] (03CR) 10Legoktm: OutputPage: addParserOutput*() family doesn't need to take a reference [core] - 10https://gerrit.wikimedia.org/r/155902 (owner: 10Bartosz Dziewoński) [19:56:10] (03CR) 10Legoktm: [C: 032] OutputPage: addParserOutput*() family doesn't need to take a reference [core] - 10https://gerrit.wikimedia.org/r/155902 (owner: 10Bartosz Dziewoński) [19:57:23] what i'm doing isn't that terrible, it's perfectly valid to stick a tag anywhere [19:57:43] sure. but you're re-implementing makeResourceLoaderLink [19:57:43] and it's still loaded like a proper module via ResourceLoader [19:58:08] but it loads in it's own individual request, not combined with others [19:58:17] yeah [19:58:49] (this obviously only matters when you use the old method, anyway) [19:59:52] (03Merged) 10jenkins-bot: OutputPage: addParserOutput*() family doesn't need to take a reference [core] - 10https://gerrit.wikimedia.org/r/155902 (owner: 10Bartosz Dziewoński) [20:00:18] (actually, i could probably kill the huge makeLoaderQuery() part and just use $this->getRequest() instead of the FauxRequests) [20:00:56] anyway, post a comment and i'll do your bidding later? :D [20:01:30] 3MediaWiki / 3User preferences: Updating user preferences via API gives inconsistent results - 10https://bugzilla.wikimedia.org/69942#c3 (10Brad Jorsch) Not an API bug, the API simply calls $user->setOption(). I'm not entirely sure where the bug here lies: * $wgDefaultUserOptions['multimediaviewer-enable']... [20:04:56] (03PS4) 10Anomie: API: Overhaul token handling [core] - 10https://gerrit.wikimedia.org/r/153110 [20:05:41] (03CR) 10Anomie: API: Overhaul token handling (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153110 (owner: 10Anomie) [20:09:00] (03CR) 10Alex Monk: [C: 032] Make ForeignAPI and ForeignDB GadgetRepos use different cache keys [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154726 (owner: 10Legoktm) [20:09:05] (03CR) 10Bartosz Dziewoński: "I like this. Comment inline." (031 comment) [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/155696 (owner: 10Isarra) [20:09:25] (03Merged) 10jenkins-bot: Make ForeignAPI and ForeignDB GadgetRepos use different cache keys [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154726 (owner: 10Legoktm) [20:11:08] (03CR) 10Alex Monk: [C: 031] Grant all gadgets-*** userrights to sysop group by default [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/155745 (owner: 10Legoktm) [20:13:15] (03CR) 10Legoktm: [C: 04-1] "It feels a bit weird to use ParserOutput for things that aren't actually generated by the parser at all, but I see the convenience since i" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155903 (owner: 10Bartosz Dziewoński) [20:17:32] (03CR) 10MZMcBride: "Does this changeset have an associated bug report?" [core] - 10https://gerrit.wikimedia.org/r/154452 (owner: 10Umherirrender) [20:18:26] (03CR) 10Legoktm: [C: 032] Use config instead of globals for OutputPage [core] - 10https://gerrit.wikimedia.org/r/155880 (owner: 10Umherirrender) [20:21:46] (03Merged) 10jenkins-bot: Use config instead of globals for OutputPage [core] - 10https://gerrit.wikimedia.org/r/155880 (owner: 10Umherirrender) [20:34:54] (03PS3) 10Legoktm: Maintenance.php: Allow Config to be accessed via $this->config [core] - 10https://gerrit.wikimedia.org/r/152823 [20:35:10] (03PS1) 10Umherirrender: Add missing @return to function docs [core] - 10https://gerrit.wikimedia.org/r/156003 [20:35:54] (03CR) 10jenkins-bot: [V: 04-1] Maintenance.php: Allow Config to be accessed via $this->config [core] - 10https://gerrit.wikimedia.org/r/152823 (owner: 10Legoktm) [20:41:05] (03CR) 10Umherirrender: "I have no bug report created and I have not found one. This was just an idea to allow wikis to give javascript changes in hands of some us" [core] - 10https://gerrit.wikimedia.org/r/154452 (owner: 10Umherirrender) [20:45:41] (03CR) 10Calak: "This is like Bug: 8834; but for site, not for user. It can be useful." [core] - 10https://gerrit.wikimedia.org/r/154452 (owner: 10Umherirrender) [20:52:26] (03CR) 10Alex Monk: Allow custom event handlers for the click event of toolbar buttons (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155912 (owner: 10Helder.wiki) [20:55:33] (03PS4) 10Legoktm: Maintenance: Add an easy way to access Config instances [core] - 10https://gerrit.wikimedia.org/r/152823 [21:05:21] (03CR) 10Anomie: [C: 04-1] Add missing @return to function docs (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156003 (owner: 10Umherirrender) [21:10:32] 3Wikimedia / 3Mailing lists: Create mailing list for the Wikiproject Health on Portuguese Wikipedia - 10https://bugzilla.wikimedia.org/69946 (10Teles) 3NEW p:3Unprio s:3enhanc a:3None Hello. On Portuguese Wikipedia, we are rebuilding the Wikiproject Health and, after a few months of discussions, imp... [21:12:40] (03PS1) 10Legoktm: Improve GlobalVarConfigTest [core] - 10https://gerrit.wikimedia.org/r/156005 [21:14:17] 3MediaWiki extensions / 3CentralAuth: Sanity check fails: "The user account logged into does not exist." - 10https://bugzilla.wikimedia.org/69947 (10Ori Livneh) 3NEW p:3Unprio s:3major a:3None The exception below appears in fluorine:/a/mw-log/exception.log at a rate of 100 errors an hour, give or tak... [21:15:45] i love that that's an error message [21:15:51] it means someone anticipated it [21:15:56] "The user account logged into does not exist." [21:16:28] (03PS2) 10Umherirrender: Add missing @return to function docs [core] - 10https://gerrit.wikimedia.org/r/156003 [21:16:38] Isn't that just "Invalid username"? [21:17:13] I guess CentralAuth makes it more complicated. [21:17:16] (03CR) 10Umherirrender: "Patch Set 2: Addressed inline comment" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/156003 (owner: 10Umherirrender) [21:17:42] well, i think it means login was successful [21:20:08] I guess it means the login token is valid, but the username in wsUserName is not? [21:20:26] Maybe a race condition? [21:20:46] On signup maybe? [21:21:39] no clue [21:24:30] 3Wikimedia / 3Mailing lists: Create mailing list for the Wikiproject Health on Portuguese Wikipedia - 10https://bugzilla.wikimedia.org/69946#c1 (10John F. Lewis) 5NEW>3RESO/FIX Created as wikipedia-pt-saude. Will send the list details in few moments. [21:36:34] (03PS2) 10Helder.wiki: Allow custom event handlers for the click event of toolbar buttons [core] - 10https://gerrit.wikimedia.org/r/155912 [21:40:32] 3MediaWiki extensions / 3Gadgets: 2.0: Split "gadgets-edit" user right into "gadgets-edit-css" and "gadgets-edit-js" - 10https://bugzilla.wikimedia.org/69911 (10Helder) [21:40:32] 3MediaWiki / 3Installer: Split off permission for editing user JavaScript and CSS from "editinterface" - 10https://bugzilla.wikimedia.org/8834 (10Helder) [21:42:30] 3MediaWiki / 3JavaScript: Provide JavaScript login widget - 10https://bugzilla.wikimedia.org/69596#c4 (10Matthew Flaschen) (In reply to Michael M. from comment #1) > A login widget could be easily spoofed by a malicious user script (while > Special:Login is difficult to spoof). There's actually nothing that... [21:47:51] (03CR) 10Alex Monk: Allow custom event handlers for the click event of toolbar buttons (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155912 (owner: 10Helder.wiki) [22:13:02] (03PS1) 10BryanDavis: Apply csshelpclass to vform help [core] - 10https://gerrit.wikimedia.org/r/156007 [22:13:21] (03PS2) 10Isarra: Make legend easier to read [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/155696 [22:41:00] 3Wikimedia / 3Media storage: backend-fail-internal error while deleting files - 10https://bugzilla.wikimedia.org/69760#c24 (10Fastily) 5NEW>3RESO/WOR So I've done quite a number of uploads and deletions since I lasted posted here, and have not experienced a 'backend-fail-internal' error since. I'm going... [22:43:42] (03PS6) 10Legoktm: Use Config and remove globals [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/151771 (https://bugzilla.wikimedia.org/69086) (owner: 10Florianschmidtwelzow) [22:44:04] (03CR) 10Legoktm: [C: 031] "Fixed a small typo in the commit message. Code looks good. Yay!" [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/151771 (https://bugzilla.wikimedia.org/69086) (owner: 10Florianschmidtwelzow) [22:45:19] (03CR) 10Florianschmidtwelzow: [C: 032] "Argh, the damn O :D Thanks!" [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/151771 (https://bugzilla.wikimedia.org/69086) (owner: 10Florianschmidtwelzow) [22:45:25] (03Merged) 10jenkins-bot: Use Config and remove globals [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/151771 (https://bugzilla.wikimedia.org/69086) (owner: 10Florianschmidtwelzow) [22:47:48] 3MediaWiki extensions / 3GoogleLogin: Use Config object instead of globals in GoogleLogin - 10https://bugzilla.wikimedia.org/69086 (10Florian) 5PATC>3RESO/FIX [22:59:00] (03PS1) 10Legoktm: Check that there is an unblocked user in the sysop group [extensions/AutomaticBoardWelcome] - 10https://gerrit.wikimedia.org/r/156008 [23:07:29] (03CR) 10Jack Phoenix: [C: 032 V: 032] Check that there is an unblocked user in the sysop group [extensions/AutomaticBoardWelcome] - 10https://gerrit.wikimedia.org/r/156008 (owner: 10Legoktm) [23:09:14] (03CR) 10Krinkle: "Right now in Monobook, .mw-body is on #bodyContent, not on #content, so this would change behaviour slightly." [core] - 10https://gerrit.wikimedia.org/r/151395 (https://bugzilla.wikimedia.org/38726) (owner: 10Arlolra) [23:09:22] (03PS3) 10Legoktm: Remove use of wfMsg and friends [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/151199 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [23:09:53] (03CR) 10Legoktm: [C: 032] "Rebased around the var-->public change." [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/151199 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [23:09:58] (03Merged) 10jenkins-bot: Remove use of wfMsg and friends [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/151199 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [23:11:02] (03PS1) 10Helder.wiki: Revert "Toolbar: Only show on WikiText pages" [core] - 10https://gerrit.wikimedia.org/r/156009 (https://bugzilla.wikimedia.org/69447) [23:11:54] (03PS5) 10Legoktm: Remove globals, set visibility of functions and variables [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/151207 (owner: 10Florianschmidtwelzow) [23:12:57] (03CR) 10Helder.wiki: "See also" [core] - 10https://gerrit.wikimedia.org/r/156009 (https://bugzilla.wikimedia.org/69447) (owner: 10Helder.wiki) [23:13:24] (03CR) 10Legoktm: [C: 04-1] Some cleanup to Daddio skin. (032 comments) [skins/Daddio] - 10https://gerrit.wikimedia.org/r/155905 (owner: 10Lewis Cawte) [23:14:00] 3MediaWiki extensions / 3ProofreadPage: Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar - 10https://bugzilla.wikimedia.org/69447#c5 (10Helder) Change-Id: Ifafe41f7bc91183e0db4c10d8340a8b620b380bc. [23:14:35] (03CR) 10Helder.wiki: "This may be the cause of the problem described on" [extensions/ProofreadPage] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153027 (https://bugzilla.wikimedia.org/69327) (owner: 10Tpt) [23:16:44] (03CR) 10Legoktm: [C: 032] "PS5: Rebase around the var-->public changes again." [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/151207 (owner: 10Florianschmidtwelzow) [23:16:49] (03Merged) 10jenkins-bot: Remove globals, set visibility of functions and variables [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/151207 (owner: 10Florianschmidtwelzow) [23:17:55] (03PS5) 10Legoktm: Use Linker for accesskey [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/151208 (owner: 10Florianschmidtwelzow) [23:18:08] (03CR) 10Legoktm: [C: 032] Use Linker for accesskey [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/151208 (owner: 10Florianschmidtwelzow) [23:18:12] (03Merged) 10jenkins-bot: Use Linker for accesskey [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/151208 (owner: 10Florianschmidtwelzow) [23:19:18] (03Abandoned) 10Legoktm: Remove deprecated calls to wfMsg and updated BlogPage special pages [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/150157 (owner: 10Withoutaname) [23:20:21] (03CR) 10Isarra: [C: 032] Some cleanup of Daddio skin. [skins/Daddio] - 10https://gerrit.wikimedia.org/r/155906 (owner: 10Lewis Cawte) [23:20:26] (03CR) 10Legoktm: [C: 04-1] "Most of this has been taken care of, except for the JS and position=top stuff. Rebase? Or maybe just submit another change?" [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/137170 (owner: 10Jack Phoenix) [23:22:11] (03CR) 10Legoktm: [C: 032] "Ah, my comments were already addressed in the follow ups." [skins/Daddio] - 10https://gerrit.wikimedia.org/r/155905 (owner: 10Lewis Cawte) [23:22:13] (03Merged) 10jenkins-bot: Some cleanup to Daddio skin. [skins/Daddio] - 10https://gerrit.wikimedia.org/r/155905 (owner: 10Lewis Cawte) [23:22:15] (03Merged) 10jenkins-bot: Some cleanup of Daddio skin. [skins/Daddio] - 10https://gerrit.wikimedia.org/r/155906 (owner: 10Lewis Cawte) [23:22:17] (03CR) 10Legoktm: [C: 032] Fix ResourceLoader calls. [skins/Daddio] - 10https://gerrit.wikimedia.org/r/155907 (owner: 10Lewis Cawte) [23:22:19] (03Merged) 10jenkins-bot: Fix ResourceLoader calls. [skins/Daddio] - 10https://gerrit.wikimedia.org/r/155907 (owner: 10Lewis Cawte) [23:23:44] (03CR) 10Arlolra: "Right. Please read the above discussion, particularly the proposal on Aug. 12th. It should only affect siteNotice, which is hopefully acce" [core] - 10https://gerrit.wikimedia.org/r/151395 (https://bugzilla.wikimedia.org/38726) (owner: 10Arlolra) [23:27:17] (03Abandoned) 10Cook879: Add permissions to Special:Export [core] - 10https://gerrit.wikimedia.org/r/149522 (owner: 10Cook879)