[00:07:29] 3MediaWiki-Vagrant: Ram and port forwarding broken again - 10https://bugzilla.wikimedia.org/69720#c6 (10Dan Duvall) 5NEW>3ASSI a:5Bryan Davis>3Dan Duvall Easy enough! I'll submit a patch. FWICT, foward_ports in .settings.yaml _is_ being merged correctly with the hash in vagrant.d/10-cirrussearch.yaml. [00:10:27] 3MediaWiki-Vagrant: git-update should update submodules - 10https://bugzilla.wikimedia.org/69641 (10Bryan Davis) 5PATC>3RESO/FIX [00:15:02] (03PS1) 10Legoktm: Empty repository, leave stub file explaining merged into core [extensions/SimpleAntiSpam] - 10https://gerrit.wikimedia.org/r/154974 [00:17:02] (03PS1) 10Dduvall: Use the largest of all configured vagrant_ram values [vagrant] - 10https://gerrit.wikimedia.org/r/154975 [00:18:00] (03PS2) 10Dduvall: Use the largest of all configured vagrant_ram values [vagrant] - 10https://gerrit.wikimedia.org/r/154975 (https://bugzilla.wikimedia.org/69720) [00:18:17] (03PS1) 10Legoktm: Empty repository, leave stub file explaining merged into core [extensions/AssertEdit] - 10https://gerrit.wikimedia.org/r/154977 [00:23:56] (03CR) 10Jdlrobson: [C: 032] Remove useless CSS for input.historysubmit [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/154335 (https://bugzilla.wikimedia.org/35323) (owner: 10Bartosz Dziewoński) [00:23:58] (03Merged) 10jenkins-bot: Remove useless CSS for input.historysubmit [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/154335 (https://bugzilla.wikimedia.org/35323) (owner: 10Bartosz Dziewoński) [00:33:27] 3MediaWiki / 3Special pages: Cancel button constructive on Special:ChangeEmail - 10https://bugzilla.wikimedia.org/69723#c3 (10Jon) Moving to desktop component. Probably shouldn't be there at all :) [00:34:14] 3MediaWiki skins / 3MonoBook: CSS for input.historysubmit in monobook - 10https://bugzilla.wikimedia.org/35323 (10Rainer Rillke @commons.wikimedia) 5PATC>3RESO/FIX a:3Bartosz Dziewoński [00:35:39] chrismcmahon: I'm getting some totally wacky qunit test failures here: https://gerrit.wikimedia.org/r/#/c/151793/ [00:35:50] chrismcmahon: Any idea what's going on with that? [00:37:29] "A database query error has occurred... Error: 1 no such table: updatelog" [00:37:51] Tried doing a recheck already [00:41:25] kaldari: no idea. getting some wacky Selenium test failures just now also https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce/165/testReport/junit/(root)/Basic%20site%20for%20legacy%20devices/Able_to_search_in_basic_non_JavaScript_site/ Figure I'll sort it in the morning. [01:02:58] 3Wikimedia / 3Mailing lists: Set SENDER_HEADERS = ('from',) in mm_cfg.py - 10https://bugzilla.wikimedia.org/46049 (10John F. Lewis) a:3John F. Lewis [02:26:43] 3MediaWiki extensions / 3Extensions requests: Create an extension (or a config setting in core?) to add a "Sandbox" link to the personal toolbar - 10https://bugzilla.wikimedia.org/69650#c4 (10MZMcBride) I'm not sure Bartosz was volunteering. :-) The extension's requirements and architecture are still a bit... [02:26:57] 3MediaWiki / 3Redirects: Redirect [[User:Name/skin.js]] to current skin's JS page (e.g. [[User:Name/vector.js]]) - 10https://bugzilla.wikimedia.org/69555#c5 (10MZMcBride) (In reply to Kunal Mehta (Legoktm) from comment #4) > Shouldn't we just encourage people to use their common.js/css instead of > skin spec... [02:33:13] 3MediaWiki-Vagrant: Ram and port forwarding broken again - 10https://bugzilla.wikimedia.org/69720#c8 (10Nik Everett) So I just checked .settings.yml and now it has the right stuff in it - 2GB of ram and the port forwarding. I don't know what it had before but _something_ put the right stuff in it now. And re... [02:34:57] (03CR) 10Manybubbles: [C: 032] Use the largest of all configured vagrant_ram values [vagrant] - 10https://gerrit.wikimedia.org/r/154975 (https://bugzilla.wikimedia.org/69720) (owner: 10Dduvall) [02:34:59] (03Merged) 10jenkins-bot: Use the largest of all configured vagrant_ram values [vagrant] - 10https://gerrit.wikimedia.org/r/154975 (https://bugzilla.wikimedia.org/69720) (owner: 10Dduvall) [02:39:45] 3Wikimedia / 3Wikidata: {{DISPLAYTITLE}} show a warning - 10https://bugzilla.wikimedia.org/69728 (10SNN95) 3UNCO p:3Unprio s:3major a:3Wikidata bugs Created attachment 16233 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16233&action=edit Warning showing if html code put in it This what the... [02:41:30] 3MediaWiki skins / 3Vector: [collapsibleTabs] Resizing of "View history" tab can cause endless animation loop - 10https://bugzilla.wikimedia.org/69729 (10Yair Rand) 3NEW p:3Unprio s:3normal a:3None If the "View history" tab changes size such that becomes too large where it before was not, an endless... [03:05:13] 3Wikimedia / 3Wikidata: {{DISPLAYTITLE}} show a warning - 10https://bugzilla.wikimedia.org/69728 (10SNN95) [03:07:14] 3Wikimedia / 3Wikidata: {{DISPLAYTITLE}} show a warning - 10https://bugzilla.wikimedia.org/69728 (10SNN95) [03:07:14] 3Wikimedia / 3Wikidata: {{DISPLAYTITLE}} show a warning - 10https://bugzilla.wikimedia.org/69728 (10SNN95) [03:07:57] 3MediaWiki / 3ResourceLoader: OutputPage::addModuleStyles should support module dependencies - 10https://bugzilla.wikimedia.org/61577#c5 (10Matthew Flaschen) (In reply to Isarra from comment #3) > Skins need to be able to specify module dependencies. Otherwise the only way > to make more specific skin styles... [03:13:02] (03PS1) 10Legoktm: Add parser cache support to MassMessageListContent [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154981 [03:27:50] (03PS1) 10Legoktm: Get rid of wfMsg* calls [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154983 [03:30:58] 3MediaWiki skins / 3Vector: [collapsibleTabs] Collapsible tabs start collapsing from the wrong side first in RTL - 10https://bugzilla.wikimedia.org/34587#c4 (10Yair Rand) Is this fixed? On the Hebrew Wikipedia it looks like the outermost tab is the first to be hidden. [03:32:33] (03CR) 10BryanDavis: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/119940 (owner: 10BryanDavis) [03:42:53] (03PS2) 10Mattflaschen: Use getConfig on local context to get configuration settings in Action [core] - 10https://gerrit.wikimedia.org/r/154429 (owner: 10IAlex) [03:47:38] (03CR) 10Legoktm: [C: 032] Use getConfig on local context to get configuration settings in Action [core] - 10https://gerrit.wikimedia.org/r/154429 (owner: 10IAlex) [03:49:25] (03CR) 10jenkins-bot: [V: 04-1] Use getConfig on local context to get configuration settings in Action [core] - 10https://gerrit.wikimedia.org/r/154429 (owner: 10IAlex) [03:50:11] wat [03:50:38] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/154429 (owner: 10IAlex) [03:53:08] (03CR) 10Legoktm: [V: 032] Use getConfig on local context to get configuration settings in Action [core] - 10https://gerrit.wikimedia.org/r/154429 (owner: 10IAlex) [03:56:27] 3MediaWiki / 3User login and signup: Cannot login using IE6 and/or IE8 - 10https://bugzilla.wikimedia.org/33503 (10Matthew Flaschen) [03:58:12] 3MediaWiki / 3Skin and page rendering: Add IE7-9 support to .vertical-gradient mixin - 10https://bugzilla.wikimedia.org/61010#c13 (10Matthew Flaschen) IE 6 is end of life on all desktop browsers, and this is a classic progressive enhancement case. [04:12:22] (03CR) 10CSteipp: "It's overboard, but should make even the most paranoid feel good that timing attacks can't be done." [core] - 10https://gerrit.wikimedia.org/r/148442 (https://bugzilla.wikimedia.org/28419) (owner: 10Parent5446) [04:14:42] 3MediaWiki / 3ResourceLoader: IE 6 requires a space after first-letter - 10https://bugzilla.wikimedia.org/50834#c3 (10Matthew Flaschen) 5NEW>3RESO/WON Agreed (even though I filed it). It doesn't make sense to do this for an end of life program. (Note, JS-loaded CSS will also not be loaded in IE 6, whic... [04:42:20] (03CR) 10Springle: [C: 031] Add SQL DDL for rename requests [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/150997 (https://bugzilla.wikimedia.org/68889) (owner: 10BryanDavis) [04:43:12] (03CR) 10Kunalgrover05: Backend method for Special:PageLanguage, purge on language change (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143049 (owner: 10Kunalgrover05) [04:47:42] 3MediaWiki extensions / 3Popups: When changing settings, does not default to my current setting - 10https://bugzilla.wikimedia.org/69577#c2 (10Matthew Flaschen) This may not make sense to fix in isolation. Prateek and I talked about some broader areas where the current UI may be confusing. We also talked a... [04:49:10] (03CR) 10Springle: [C: 031] Don't estimate the revision count for page deletions [core] - 10https://gerrit.wikimedia.org/r/131264 (https://bugzilla.wikimedia.org/69556) (owner: 10Hoo man) [04:49:28] 3MediaWiki extensions / 3Popups: "Monitor or Edit" option apparently disables HoverCards entirely - 10https://bugzilla.wikimedia.org/69576#c5 (10Matthew Flaschen) 5UNCO>3RESO/FIX a:3Prateek Saxena Yes, that's my understanding (from talking to Prateek and looking at the bug/fix). > the panel shows "Rea... [04:53:57] 3MediaWiki / 3Templates: REVISIONID cannot be substituted - 10https://bugzilla.wikimedia.org/6181#c12 (10Joshua Scott) Here is a patch to fix the issue seen by GregH, using his suggested fix. Note: If {{subst:REVISIONID}} is used on a newly created page, the string "Initial Revision" will be used in place o... [05:10:43] (03CR) 10Mattflaschen: "Just some thoughts. Don't have any conclusions yet." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/154125 (owner: 10Jdlrobson) [05:21:13] (03CR) 10Mattflaschen: "Thoughts on guidelines:" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/154121 (owner: 10Jdlrobson) [05:25:59] (03CR) 10Springle: [C: 031] "Seems fine. Testing a few enwiki contributions queries with the extra join shows minimal impact, just an additional ref access using rc_ti" [core] - 10https://gerrit.wikimedia.org/r/151381 (https://bugzilla.wikimedia.org/69061) (owner: 10Brian Wolff) [05:28:45] 3Wikimedia / 3lucene-search-2: Searching for || on Wikipedia causes error - 10https://bugzilla.wikimedia.org/69730 (10Michael Eshom) 3UNCO p:3Unprio s:3normal a:3None If you go to Wikipedia and search for ||, you get an error: "An error has occurred while searching: The search backend returned an err... [05:29:12] 3Wikimedia / 3lucene-search-2: Searching for || on Wikipedia causes error - 10https://bugzilla.wikimedia.org/69730 (10Michael Eshom) [05:33:57] 3Wikimedia / 3lucene-search-2: Searching for || on Wikipedia causes error - 10https://bugzilla.wikimedia.org/69730#c1 (10WikiPuppies) Happens here as well. Also occurs on Commons: https://commons.wikimedia.org/w/index.php?search=||&title=Special%3ASearch&go=Go Unable to reproduce on Wikidata, Wiktionary, Me... [05:36:32] (03CR) 10Mattflaschen: "See inline." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125387 (owner: 10Pginer) [05:50:11] (03CR) 10Foxtrott: "That was fast. Thanks!" [core] - 10https://gerrit.wikimedia.org/r/154840 (owner: 10Gerrit Patch Uploader) [05:51:13] 3MediaWiki extensions / 3Semantic MediaWiki: ask query removes results with no value for a property when sorting by it - 10https://bugzilla.wikimedia.org/22583#c6 (10user66) +1 for fixing this. The result should not depend on the sort condition. This is unexpected behavior from end-user perspective and confu... [05:58:08] (03CR) 10Foxtrott: "> Others might disagree, will be happy to lift the -2 in such a case." [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [06:05:49] (03PS2) 10Santhosh: Apertium: Use the APY API running on apertium.wmflabs.org [services/cxserver] - 10https://gerrit.wikimedia.org/r/154758 [06:06:49] (03CR) 10jenkins-bot: [V: 04-1] Apertium: Use the APY API running on apertium.wmflabs.org [services/cxserver] - 10https://gerrit.wikimedia.org/r/154758 (owner: 10Santhosh) [06:07:13] 3MediaWiki / 3Skin and page rendering: Use MediaWiki UI for JavaScript-generated checkbox - 10https://bugzilla.wikimedia.org/69722#c2 (10Matthew Flaschen) I doubt there's a short (or even mid-) term solution using OOUI. It has a whole class name system of its own, and (IIRC) the build process currently can'... [06:08:55] (03PS3) 10Santhosh: Apertium: Use the APY API running on apertium.wmflabs.org [services/cxserver] - 10https://gerrit.wikimedia.org/r/154758 [06:09:23] (03CR) 10jenkins-bot: [V: 04-1] Apertium: Use the APY API running on apertium.wmflabs.org [services/cxserver] - 10https://gerrit.wikimedia.org/r/154758 (owner: 10Santhosh) [06:12:36] (03PS4) 10Santhosh: Apertium: Use the APY API running on apertium.wmflabs.org [services/cxserver] - 10https://gerrit.wikimedia.org/r/154758 [06:16:36] (03CR) 10Mattflaschen: "I admit I haven't dug into this, but currently I actually don't understand where MWTidy sits in our parsing flow, and thus this patch." [core] - 10https://gerrit.wikimedia.org/r/154083 (https://bugzilla.wikimedia.org/66516) (owner: 10Physikerwelt) [06:25:23] (03CR) 10Mattflaschen: "IMHO, this was not urgent enough to force the patch over Jenkins. It could wait (and it's a good opportunity to get the CI bug fixed)." [core] - 10https://gerrit.wikimedia.org/r/154429 (owner: 10IAlex) [06:28:30] 3MediaWiki extensions / 3WikibaseDatabase: I want to clear the indicator for messages - 10https://bugzilla.wikimedia.org/69732 (10Gerard Meijssen) 3NEW p:3Unprio s:3normal a:3Wikidata bugs I have no way of clearing the red indicator for number of messages. As the number is too high I will not click t... [06:50:22] (03PS2) 10Wctaiwan: Add parser cache support to MassMessageListContent [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154981 (https://bugzilla.wikimedia.org/68603) (owner: 10Legoktm) [06:58:56] (03PS1) 10Wctaiwan: Add test cases for extractTarget [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154988 [07:00:24] (03CR) 10Legoktm: [C: 032] Add test cases for extractTarget [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154988 (owner: 10Wctaiwan) [07:00:50] (03Merged) 10jenkins-bot: Add test cases for extractTarget [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154988 (owner: 10Wctaiwan) [07:04:43] (03PS3) 10Wctaiwan: Add parser cache support to MassMessageListContent [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154981 (https://bugzilla.wikimedia.org/68603) (owner: 10Legoktm) [07:19:30] (03CR) 10Hashar: "> > Others might disagree, will be happy to lift the -2 in such a case." [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [07:39:44] (03CR) 10Hashar: [C: 031] Add basic REAME.md [tools/code-utils] - 10https://gerrit.wikimedia.org/r/154481 (owner: 10Addshore) [07:54:34] (03PS1) 10Legoktm: Use my real name in the credits [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/154990 [07:55:53] (03CR) 10Legoktm: [C: 032] Use my real name in the credits [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/154990 (owner: 10Legoktm) [07:56:00] (03Merged) 10jenkins-bot: Use my real name in the credits [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/154990 (owner: 10Legoktm) [08:10:58] 3MediaWiki extensions / 3WikidataRepo: False message: List of values is complete. - 10https://bugzilla.wikimedia.org/69671#c7 (10sju-w) Created attachment 16234 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16234&action=edit Screenshot of the item page with the bug Today the bug occured again. Seve... [08:23:57] 3MediaWiki extensions / 3UniversalLanguageSelector: [Compact links] Default languages shown for an Italian user can be improved - 10https://bugzilla.wikimedia.org/62346#c13 (10Nemo) All CLDR tickets other than the request for immigrants' languages have been fixed. http://unicode.org/cldr/trac/changeset/10650... [08:24:48] (03PS1) 10Pastakhov: fix class ErrorHandler for HHVM (v 3.4.3) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/154991 [08:26:13] (03CR) 10Pastakhov: [C: 032] fix class ErrorHandler for HHVM (v 3.4.3) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/154991 (owner: 10Pastakhov) [08:26:19] (03Merged) 10jenkins-bot: fix class ErrorHandler for HHVM (v 3.4.3) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/154991 (owner: 10Pastakhov) [08:52:28] 3MediaWiki extensions / 3[other]: [PhpTagsFunctions] Fatal error: Unexpected object type stdClass. in PhpTagsFunc.php on line 20 - 10https://bugzilla.wikimedia.org/69014#c3 (10Pavel (pastakhov)) p:5Unprio>3Normal For the correct operation is required to describe number and type of parameters for each fun... [08:57:31] (03PS1) 10Pastakhov: add runtime initialise to phpunit tests [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/154993 [08:57:39] (03CR) 10jenkins-bot: [V: 04-1] add runtime initialise to phpunit tests [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/154993 (owner: 10Pastakhov) [09:05:25] (03PS1) 10Pastakhov: fix function ErrorHandler::onError() (v 3.4.4) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/154994 [09:05:52] (03CR) 10Pastakhov: [C: 032] fix function ErrorHandler::onError() (v 3.4.4) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/154994 (owner: 10Pastakhov) [09:06:04] (03Merged) 10jenkins-bot: fix function ErrorHandler::onError() (v 3.4.4) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/154994 (owner: 10Pastakhov) [09:06:22] (03CR) 10Pastakhov: [C: 032] add runtime initialise to phpunit tests [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/154993 (owner: 10Pastakhov) [09:06:29] (03Merged) 10jenkins-bot: add runtime initialise to phpunit tests [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/154993 (owner: 10Pastakhov) [09:16:42] 3MediaWiki extensions / 3WikidataRepo: Notify client wikis about entity pages being turned into redirects. - 10https://bugzilla.wikimedia.org/66029 (10Lydia Pintscher) s:5enhanc>3normal [09:20:30] siebrand: For https://gerrit.wikimedia.org/r/#/c/152077/1/i18n/en.json, if I reduce the english version to "Send thanks for this edit?", what should be provided for GENDER support in other languages? [09:29:29] 3MediaWiki extensions / 3WikidataRepo: allow statements on properties - 10https://bugzilla.wikimedia.org/49554 (10Lydia Pintscher) [09:29:29] 3MediaWiki extensions / 3WikidataRepo: Allow adding references for claims on properties in the UI - 10https://bugzilla.wikimedia.org/68379 (10Lydia Pintscher) [09:38:46] 3MediaWiki extensions / 3WikidataClient: [Interlanguage links] Add links should connect with another family - 10https://bugzilla.wikimedia.org/69735 (10JAn Dudík) 3NEW p:3Unprio s:3enhanc a:3Wikidata bugs When there is new article unconnected with Wikidata, I can add interlanglinks to connect it - b... [09:49:12] 3MediaWiki extensions / 3CentralAuth: Accounts magically unattached despite being recently created - 10https://bugzilla.wikimedia.org/39996#c92 (10This, that and the other (TTO)) Lots of bugs on Bugzilla are about broken things... [09:54:58] wctaiwan: I doubt that changes anything [09:55:21] Nemo_bis: so {{GENDER:$1|Send}}? [09:55:38] Yes, for instance [09:56:52] okay, I'll do that [10:10:30] 3MediaWiki extensions / 3LabeledSectionTransclusion: Section isn't transcluded when marked inside a template call - 10https://bugzilla.wikimedia.org/69736 (10Guillaume Paumier) 3NEW p:3Unprio s:3normal a:3None When the labeled section is located inside a template call, you can't transclude it. Examp... [10:11:13] 3MediaWiki extensions / 3WikidataRepo: write script that touches every item and thereby updates database tables - 10https://bugzilla.wikimedia.org/64600#c9 (10tobias.gritschacher) p:5Highes>3High Needs more discussion. [10:12:51] (03PS2) 10Wctaiwan: Use jquery.confirmable instead of jquery.ui.dialog [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/152077 (owner: 10Legoktm) [10:13:14] 3MediaWiki extensions / 3LabeledSectionTransclusion: Transclusion from pages built by a template - 10https://bugzilla.wikimedia.org/21339#c10 (10Merlijn van Deen) *** Bug 69736 has been marked as a duplicate of this bug. *** [10:13:14] 3MediaWiki extensions / 3LabeledSectionTransclusion: Section isn't transcluded when marked inside a template call - 10https://bugzilla.wikimedia.org/69736#c1 (10Merlijn van Deen) 5NEW>3RESO/DUP Yeah, that's an annoying issue. I've made a patch 1.5 years ago, but it brought down Wikisource when it was dep... [10:13:54] (03PS3) 10Wctaiwan: Use jquery.confirmable instead of jquery.ui.dialog [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/152077 (owner: 10Legoktm) [10:14:14] 3MediaWiki extensions / 3WikidataRepo: wbgetentities API returns useless (at least useless in XML) "missing" attribute for missing entities - 10https://bugzilla.wikimedia.org/45509 (10Lydia Pintscher) 5PATC>3RESO/FIX [10:14:27] 3MediaWiki extensions / 3WikidataRepo: wbgetentities API returns useless (at least useless in XML) "missing" attribute for missing entities - 10https://bugzilla.wikimedia.org/45509 (10Lydia Pintscher) 5RESO/?>3VERI [10:14:43] 3MediaWiki extensions / 3LabeledSectionTransclusion: Transclusion from pages built by a template - 10https://bugzilla.wikimedia.org/21339#c11 (10Merlijn van Deen) Adding Guillaume Paumier's example from #69736: > When the labeled section is located inside a template call, you can't > transclude it. > > Exa... [10:17:27] 3MediaWiki extensions / 3WikidataRepo: Update the wb_terms table so it does not have a numeric entity id - 10https://bugzilla.wikimedia.org/56711 (10Lydia Pintscher) [10:17:43] 3MediaWiki extensions / 3WikidataRepo: basic support for Wikimedia Commons (MediaInfo entity type) - 10https://bugzilla.wikimedia.org/64288 (10Lydia Pintscher) [10:28:27] 3MediaWiki extensions / 3WikidataRepo: not possible to switch to Julian calendar model - 10https://bugzilla.wikimedia.org/65847#c4 (10Lydia Pintscher) 5PATC>3NEW We just tried this and none of the above patches seem to fix it. [10:30:44] 3MediaWiki / 3Skin and page rendering: {{DISPLAYTITLE}} show a warning - 10https://bugzilla.wikimedia.org/69728 (10This, that and the other (TTO)) s:5major>3normal a:5Wikidata bugs>3None [10:33:58] 3MediaWiki / 3Skin and page rendering: Patrol link is misplaced when content contains uncleared floating elements - 10https://bugzilla.wikimedia.org/64176#c5 (10Lydia Pintscher) 5PATC>3RESO/FIX This seems to be fixed now. [10:34:21] (03CR) 10Tobias Gritschacher: "It seems the bug this change refers to is resolved. We just manually tried in Chrome and Firefox and the patrol link was shown as it shoul" [core] - 10https://gerrit.wikimedia.org/r/128966 (https://bugzilla.wikimedia.org/64176) (owner: 10Gerrit Patch Uploader) [10:34:32] (03CR) 10Tobias Gritschacher: "It seems the bug this change refers to is resolved. We just manually tried in Chrome and Firefox and the patrol link was shown as it shoul" [core] - 10https://gerrit.wikimedia.org/r/127624 (https://bugzilla.wikimedia.org/64176) (owner: 10Gerrit Patch Uploader) [10:34:45] (03PS1) 10Hashar: Make beta jobs to complain on #wikimedia-qa [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/155005 (https://bugzilla.wikimedia.org/69628) [10:36:00] (03CR) 10Hashar: [C: 032] "Adding reviewers for information. I have updated the jobs :-D" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/155005 (https://bugzilla.wikimedia.org/69628) (owner: 10Hashar) [10:37:17] (03Merged) 10jenkins-bot: Make beta jobs to complain on #wikimedia-qa [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/155005 (https://bugzilla.wikimedia.org/69628) (owner: 10Hashar) [10:39:04] (03CR) 10Tobias Gritschacher: "poke" [core] - 10https://gerrit.wikimedia.org/r/129116 (https://bugzilla.wikimedia.org/53851) (owner: 10Aude) [10:40:06] (03Abandoned) 10Aude: Introduce EnhancedChangesCacheEntry hook [core] - 10https://gerrit.wikimedia.org/r/129116 (https://bugzilla.wikimedia.org/53851) (owner: 10Aude) [10:43:27] 3MediaWiki / 3Skin and page rendering: {{DISPLAYTITLE}} shows a warning when used multiple times on a page - 10https://bugzilla.wikimedia.org/69728#c1 (10Jesús Martínez Novo (Ciencia Al Poder)) It happens when there are 2 instances of {{DISPLAYTITLE}} on the page (as the provided URL) with a different argume... [10:44:13] 3MediaWiki skins / 3Vector: [collapsibleTabs] Collapsible tabs start collapsing from the wrong side first in RTL - 10https://bugzilla.wikimedia.org/34587#c5 (10Bartosz Dziewoński) No idea. I am sure that no one has worked on it and consciously fixed it since I last commented. (I watch all incoming patches in... [10:47:28] 3MediaWiki / 3Skin and page rendering: {{DISPLAYTITLE}} shows a warning when used multiple times on a page - 10https://bugzilla.wikimedia.org/69728#c2 (10Bartosz Dziewoński) It is expected behavior since af66fecb2d887e917bcb57e2377a71c3cdab987c. [10:48:04] (03Abandoned) 10Bartosz Dziewoński: Enclose parser output into a div container [core] - 10https://gerrit.wikimedia.org/r/128966 (https://bugzilla.wikimedia.org/64176) (owner: 10Gerrit Patch Uploader) [10:48:11] (03Abandoned) 10Bartosz Dziewoński: Clear floating elements from content [core] - 10https://gerrit.wikimedia.org/r/127624 (https://bugzilla.wikimedia.org/64176) (owner: 10Gerrit Patch Uploader) [10:48:43] 3MediaWiki / 3Parser: {{DISPLAYTITLE}} shows a warning when used multiple times on a page - 10https://bugzilla.wikimedia.org/69728 (10Bartosz Dziewoński) [10:49:34] (03PS5) 10Santhosh: Apertium: Use the APY API running on apertium.wmflabs.org [services/cxserver] - 10https://gerrit.wikimedia.org/r/154758 [10:50:57] 3MediaWiki extensions / 3WikidataRepo: Invalid argument supplied for foreach() in api/GetEntities.php on line 237 - 10https://bugzilla.wikimedia.org/69553#c1 (10Lydia Pintscher) 5NEW>3RESO/FIX This should be fixed. Please reopen if not. Thanks :) [10:51:06] (03CR) 10Bartosz Dziewoński: [C: 032] Empty repository, leave stub file explaining merged into core [extensions/SimpleAntiSpam] - 10https://gerrit.wikimedia.org/r/154974 (owner: 10Legoktm) [10:51:08] (03CR) 10Bartosz Dziewoński: [C: 032] Empty repository, leave stub file explaining merged into core [extensions/AssertEdit] - 10https://gerrit.wikimedia.org/r/154977 (owner: 10Legoktm) [10:51:12] (03Merged) 10jenkins-bot: Empty repository, leave stub file explaining merged into core [extensions/AssertEdit] - 10https://gerrit.wikimedia.org/r/154977 (owner: 10Legoktm) [10:51:14] (03Merged) 10jenkins-bot: Empty repository, leave stub file explaining merged into core [extensions/SimpleAntiSpam] - 10https://gerrit.wikimedia.org/r/154974 (owner: 10Legoktm) [10:57:57] 3MediaWiki / 3Parser: {{DISPLAYTITLE}} shows a warning when used multiple times on a page - 10https://bugzilla.wikimedia.org/69728#c3 (10Jesús Martínez Novo (Ciencia Al Poder)) It popped up on enwiki [1]. They decided to adjust the message to add a maintenance category. We should either WONTFIX this bug, or... [11:04:40] (03PS1) 10UltrasonicNXT: Fix typo [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/155007 [11:05:22] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Fix typo [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/155007 (owner: 10UltrasonicNXT) [11:17:30] 3MediaWiki skins / 3Chameleon: Needs hooks - 10https://bugzilla.wikimedia.org/69738 (10s7eph4n) 3NEW p:3Unprio s:3enhanc a:3s7eph4n Other skins call hooks to enable customization. Example: SkinTemplateOutputPageBeforeExec [11:32:12] 3MediaWiki / 3Special pages: Special:AllPages and various other pages uses a table based layout which does not render nicely on small screens - 10https://bugzilla.wikimedia.org/63428#c13 (10Dan Jacobson) Thanks but my wiki will wait for mobile to be fully implemented and released before using it again. [11:33:26] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This works to stop already present notifications from disappearing (and I like how it does that), but does nothing to prevent new notifica" [core] - 10https://gerrit.wikimedia.org/r/154227 (https://bugzilla.wikimedia.org/40322) (owner: 10Helder.wiki) [11:34:08] (03PS5) 10Microchip08: Use FormSpecialPage for Special:RandomInCategory [core] - 10https://gerrit.wikimedia.org/r/154374 (https://bugzilla.wikimedia.org/67581) [11:34:53] oof, I accidentally clicked [11:35:14] I was trying to scroll down :) [11:35:42] (03CR) 10Microchip08: "(Sorry, I accidentally clicked the button)" [core] - 10https://gerrit.wikimedia.org/r/154374 (https://bugzilla.wikimedia.org/67581) (owner: 10Microchip08) [11:35:58] 3MediaWiki extensions / 3LabeledSectionTransclusion: Transclusion from pages built by a template - 10https://bugzilla.wikimedia.org/21339#c12 (10Merlijn van Deen) URL is no longer functional. [11:58:16] (03PS1) 10Jack Phoenix: Some cleanup and modernization. [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/155010 [11:59:12] 3Wikimedia / 3Mailing lists: Prettify default theme/skin of mailman's listinfo pages - 10https://bugzilla.wikimedia.org/61283#c10 (10Quim Gil) (In reply to John F. Lewis from comment #8) > It needs to be translated by our community as it is Wikimedia specific. What is the recommended process for translator... [11:59:16] (03CR) 10Physikerwelt: "With well defined MathML tags I was referring to:" [core] - 10https://gerrit.wikimedia.org/r/154083 (https://bugzilla.wikimedia.org/66516) (owner: 10Physikerwelt) [12:00:42] 3Wikimedia / 3Mailing lists: Prettify default theme/skin of mailman's listinfo pages - 10https://bugzilla.wikimedia.org/61283#c11 (10Thehelpfulone) On the most up-to-date version https://mailman.wmflabs.org/mailman/listinfo/test there's a 'Translate page' link on the side bar which links to https://meta.wiki... [12:03:27] 3Wikimedia / 3Mailing lists: Prettify default theme/skin of mailman's listinfo pages - 10https://bugzilla.wikimedia.org/61283#c12 (10John F. Lewis) And are manually being shoved into Gerrit by me (I am in the process of adding about 15 which were translated over night) [12:06:17] (03PS17) 10TTO: Allow two-tier setup of transwiki import sources [core] - 10https://gerrit.wikimedia.org/r/84194 [12:12:57] 3MediaWiki extensions / 3WikidataRepo: Make Wikibase compatible with HHVM - 10https://bugzilla.wikimedia.org/64415 (10Lydia Pintscher) [12:18:27] 3MediaWiki extensions / 3WikidataClient: Under HHVM: Call to a member function getGuid() on a non-object - 10https://bugzilla.wikimedia.org/65698#c8 (10Lydia Pintscher) This needs to be checked in datamodel 0.8.2. [12:21:06] (03CR) 10TTO: "Should be good to go." [core] - 10https://gerrit.wikimedia.org/r/84194 (owner: 10TTO) [12:21:43] 3MediaWiki extensions / 3WikidataRepo: [HHVM] Tests for WikibaseDataModel on Travis are failing (due to PHPUnit version used) - 10https://bugzilla.wikimedia.org/69525#c1 (10tobias.gritschacher) per Jeroen: We are using the TravisCI default, which is PHPUnit 4.x. I recall Sebastian saying he fixed HHVM compat... [12:22:28] 3MediaWiki extensions / 3Diff: [HHVM] Tests on Travis are failing (due to PHPUnit version used) - 10https://bugzilla.wikimedia.org/69524#c1 (10tobias.gritschacher) We are using the TravisCI default, which is PHPUnit 4.x. I recall Sebastian saying he fixed HHVM compat, so I'm not sure what the issue there is.... [12:25:27] 3MediaWiki extensions / 3LabeledSectionTransclusion: Section isn't transcluded when marked inside a template call - 10https://bugzilla.wikimedia.org/69736#c2 (10Guillaume Paumier) Thanks, Merlijn. I saw that other bug report but I wasn't sure it was the same issue because in my case, I don't want to add the... [12:27:58] 3MediaWiki extensions / 3WikibaseQueryEngine: [HHVM] Tests on Travis are failing (due to HHVM's sqlsite driver) - 10https://bugzilla.wikimedia.org/69526#c2 (10tobias.gritschacher) Per Jeroen: It's not DBAL apparently, but HHVM. While DBAL master's tests fail due to this, if we switch to DBAL master, our CI p... [12:28:28] 3MediaWiki extensions / 3WikibaseDatabase: I want to clear the indicator for messages - 10https://bugzilla.wikimedia.org/69732#c1 (10Andre Klapper) 5NEW>3UNCO s:5normal>3enhanc Hi, which "red indicator for number of messages" on which website? Do you refer to [[mw:Echo]] notifications (see screensho... [12:28:57] 3MediaWiki extensions / 3WikidataRepo: HHVM: Exception about the "datatypefactory" value of the resource definition - 10https://bugzilla.wikimedia.org/63691#c2 (10Lydia Pintscher) 5NEW>3RESO/FIX Please reopen if it is still an issue. [12:31:44] 3MediaWiki extensions / 3WikidataRepo: [hhvm] Fatal error: String length exceeded 2^31-2: 2147483647 - 10https://bugzilla.wikimedia.org/68423 (10Lydia Pintscher) 5NEW>3RESO/FIX [12:39:27] 3MediaWiki extensions / 3WikidataRepo: not possible to switch to Julian calendar model - 10https://bugzilla.wikimedia.org/65847 (10Lydia Pintscher) [12:43:12] 3MediaWiki extensions / 3WikidataRepo: empty diff for supposed sitelink change - 10https://bugzilla.wikimedia.org/65806#c1 (10Lydia Pintscher) We need newer examples. I'll ask. [12:44:42] 3MediaWiki extensions / 3UniversalLanguageSelector: [Compact links] Default languages shown for an Italian user can be improved - 10https://bugzilla.wikimedia.org/62346#c14 (10Andre Klapper) (In reply to Nemo from comment #13) > All CLDR tickets other than the request for immigrants' languages have been > fi... [13:07:57] (03PS53) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [13:11:47] (03PS54) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [13:14:44] 3Wikimedia / 3Site requests: Ordering of levels in $wgRestrictionLevels causes bad ordering on protection form - 10https://bugzilla.wikimedia.org/69640#c7 (10Antoine "hashar" Musso) 5PATC>3RESO/FIX a:3Brad Jorsch I have deployed the change: $ sync-file wmf-config/InitialiseSettings.php 'Fix $wgRestric... [13:16:29] (03PS1) 10Gerrit Patch Uploader: Introduce tag; reformat code [extensions/PageTools] - 10https://gerrit.wikimedia.org/r/155024 [13:16:31] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/PageTools] - 10https://gerrit.wikimedia.org/r/155024 (owner: 10Gerrit Patch Uploader) [13:16:58] (03CR) 10Foxtrott: [C: 032 V: 032] Introduce tag; reformat code [extensions/PageTools] - 10https://gerrit.wikimedia.org/r/155024 (owner: 10Gerrit Patch Uploader) [13:18:19] (03PS55) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [13:20:42] 3Wikimedia / 3Mailing lists: Prettify default theme/skin of mailman's listinfo pages - 10https://bugzilla.wikimedia.org/61283#c13 (10Nemo) It would be useful if the patch linked mailman docs on how changing default templates works. For instance, how does it handle language fallback? If it doesn't, are you pl... [13:24:15] 55 patchsets O_O [13:24:25] WTFBBQ [13:24:29] 3MediaWiki extensions / 3WikidataRepo: Test conformance of API modules - 10https://bugzilla.wikimedia.org/67407 (10Lucie Kaffee) [13:24:32] 3MediaWiki extensions / 3WikidataRepo: Update ApiModules to conform to api conventions - 10https://bugzilla.wikimedia.org/69739 (10Lucie Kaffee) 3NEW p:3Unprio s:3normal a:3Wikidata bugs As you can see in the test, there are some points, where the Api Conventions are not matched. The test fails at t... [13:25:23] (03PS56) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [13:26:18] 3Wikimedia / 3Mailing lists: Prettify default theme/skin of mailman's listinfo pages - 10https://bugzilla.wikimedia.org/61283#c14 (10John F. Lewis) (In reply to Nemo from comment #13) > It would be useful if the patch linked mailman docs on how changing default > templates works. For instance, how does it ha... [13:28:08] (03CR) 10Helder.wiki: [C: 031] "Maybe it is worth adding a link to" [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154983 (owner: 10Legoktm) [13:31:04] (03PS57) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [13:32:41] (03PS10) 10Matthias Mullie: Subscribe to board = auto-subscribe to new topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153411 [13:33:37] (03CR) 10Matthias Mullie: "Removed own -2, tested this and works." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153411 (owner: 10Matthias Mullie) [13:34:30] 3MediaWiki / 3Categories: Categories don't react well to their members moving between special-cased namespaces (Category ↔ File ↔ (other)) - 10https://bugzilla.wikimedia.org/69740 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None Categories don't react well to their members moving between speci... [13:35:34] (03PS58) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [13:40:50] (03PS59) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [13:42:07] (03PS1) 10Pastakhov: fix bytecode cache (v 3.5.0, Runtime relize is 2) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/155029 [13:42:23] (03PS60) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [13:51:04] (03CR) 10Chad: [C: 032] Move installer files from skins/common/ to mw-config/ [core] - 10https://gerrit.wikimedia.org/r/153368 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [13:53:05] (03PS2) 10Pastakhov: fix bytecode cache (v 3.5.0, Runtime release is 2) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/155029 [13:53:57] 3MediaWiki / 3Parser: {{DISPLAYTITLE}} shows a warning when used multiple times on a page - 10https://bugzilla.wikimedia.org/69728#c4 (10Brad Jorsch) 5UNCO>3RESO/WON The warning is intended behavior, to notify users that they are using DISPLAYTITLE multiple times on the page. There are flags for DISPLAYT... [13:54:27] (03Merged) 10jenkins-bot: Move installer files from skins/common/ to mw-config/ [core] - 10https://gerrit.wikimedia.org/r/153368 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [13:54:42] (03PS61) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [13:55:03] (03CR) 10jenkins-bot: [V: 04-1] Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [13:55:27] (03PS3) 10Bartosz Dziewoński: Remove pointless dependencies from mediawiki.legacy.config [core] - 10https://gerrit.wikimedia.org/r/154476 [13:56:45] (03PS62) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [13:57:16] (03CR) 10Chad: [C: 032] Remove pointless dependencies from mediawiki.legacy.config [core] - 10https://gerrit.wikimedia.org/r/154476 (owner: 10Bartosz Dziewoński) [13:57:57] 3MediaWiki / 3Logging: Trying to read old log entries times out initially; both API and Special:Log - 10https://bugzilla.wikimedia.org/69713 (10Andre Klapper) p:5Unprio>3Normal [13:58:57] 3Wikimedia / 3lucene-search-2: Searching for || on Wikipedia causes error - 10https://bugzilla.wikimedia.org/69730#c2 (10Andre Klapper) 5UNCO>3NEW p:5Unprio>3Lowest No problem with new CirrusSearch backend: https://commons.wikimedia.org/w/index.php?search=||&title=Special%3ASearch&go=Go&srbackend=Cir... [13:59:27] 3MediaWiki / 3ResourceLoader: Using "/*@noflip*/ /*@embed*/" annotation doesn't work (although other combinations do) - 10https://bugzilla.wikimedia.org/69698 (10Andre Klapper) p:5Unprio>3Normal [13:59:42] 3MediaWiki / 3Skin and page rendering: "Enlarge" icon (magnify-clip.png) missing a SVG version - 10https://bugzilla.wikimedia.org/69705 (10Andre Klapper) p:5Unprio>3Normal [14:00:35] (03Merged) 10jenkins-bot: Remove pointless dependencies from mediawiki.legacy.config [core] - 10https://gerrit.wikimedia.org/r/154476 (owner: 10Bartosz Dziewoński) [14:01:13] (03PS2) 10Manybubbles: Skip highlighting we don't need [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/154898 [14:01:48] does Gerrit Notification Bot work for bugzilla? Why does he have not posted comments to bugzilla for https://gerrit.wikimedia.org/r/155029 and https://gerrit.wikimedia.org/r/#/c/154991 [14:03:00] pastakhov: you didn't follow conventions for linking to bugzilla, that's why your commit didn't triggered the bot [14:03:04] (03PS20) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [14:03:18] (03PS3) 10Manybubbles: Skip highlighting we don't need [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/154898 [14:03:26] (03PS3) 1001tonythomas: fix bytecode cache (v 3.5.0, Runtime release is 2) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/155029 (https://bugzilla.wikimedia.org/69657) (owner: 10Pastakhov) [14:03:34] (03PS15) 10Paladox: WikiEditor: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 [14:04:01] pastakhov: https://www.mediawiki.org/wiki/Git/Commit_message_guidelines [14:04:19] Vulpix: thanks [14:05:31] (03PS1) 10Hashar: Mention deploy dir should belong to mwdeploy [tools/scap] - 10https://gerrit.wikimedia.org/r/155038 [14:05:35] (03PS1) 10Smuggli: Added missing message [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/155039 [14:05:45] 01tonythomas: Thanks :-) [14:06:38] pastakhov: np :) [14:12:38] (03PS63) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [14:12:43] (03CR) 10jenkins-bot: [V: 04-1] Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [14:13:59] 3MediaWiki extensions / 3WikidataRepo: empty diff for supposed sitelink change - 10https://bugzilla.wikimedia.org/65806#c2 (10Thiemo Mättig) What I found: The diff is correct. There is no change. It seems the user was able to save a change without changing anything. The question is: why did the code allow th... [14:14:42] (03PS1) 10Darkaico: testing gerrit [extensions/examples] - 10https://gerrit.wikimedia.org/r/155040 [14:16:21] (03CR) 10TheDJ: "Tidy is run on content in includes/parser/Parser.php, as one of the last steps before caching of the content HTML output. TOC and edit lin" [core] - 10https://gerrit.wikimedia.org/r/154083 (https://bugzilla.wikimedia.org/66516) (owner: 10Physikerwelt) [14:17:12] (03PS64) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [14:17:52] (03CR) 10Darkaico: [C: 031] "changes looks good" [extensions/examples] - 10https://gerrit.wikimedia.org/r/155040 (owner: 10Darkaico) [14:20:44] 3MediaWiki / 3Skin and page rendering: Patrol link is misplaced when content contains uncleared floating elements - 10https://bugzilla.wikimedia.org/64176#c8 (10Fomafix) 5RESO/FIX>3REOP a:3Fomafix Created attachment 16235 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16235&action=edit Screensh... [14:21:10] (03CR) 10Bartosz Dziewoński: "And to expand on that, the placeholders for section edit links and table of contents are replaced with proper values in ParserOutput::getT" [core] - 10https://gerrit.wikimedia.org/r/154083 (https://bugzilla.wikimedia.org/66516) (owner: 10Physikerwelt) [14:24:11] (03PS65) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [14:24:24] do we have metrics on tidy ? do we actually know how much time disappears into that on Barack Obama page ? [14:25:27] 3MediaWiki extensions / 3Scribunto: LuaSandbox's profiler crashes under HHVM - 10https://bugzilla.wikimedia.org/68413 (10jeremyb) 5PATC>3NEW [14:29:13] 3MediaWiki / 3Parser: :: + {| = following lines below table get indentation too - 10https://bugzilla.wikimedia.org/69699 (10Andre Klapper) p:5Unprio>3Low [14:29:15] (03CR) 10Anomie: Add help links to API documentation page (031 comment) [core] - 10https://gerrit.wikimedia.org/r/154355 (https://bugzilla.wikimedia.org/63211) (owner: 10MarkTraceur) [14:31:11] thedj: no, no one caes :( [14:31:13] cares* [14:32:12] 3Wikimedia / 3Extension setup: FlaggedRevs for Norwegian (bokmål) Wikipedia - 10https://bugzilla.wikimedia.org/64726#c24 (10Nemo) 5RESO/WON>3RESO/INV This bug is not a WONTFIX until an actual reasoning for the WONTFIX is provided, ideally backed up by data as Erik likes arguments to be. Erik said such a... [14:33:24] (03CR) 10Smuggli: [C: 031] [WIP] Checklist assistant [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151797 (owner: 10Mglaser) [14:35:47] (03CR) 10Pastakhov: [C: 032] fix bytecode cache (v 3.5.0, Runtime release is 2) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/155029 (https://bugzilla.wikimedia.org/69657) (owner: 10Pastakhov) [14:35:55] (03Merged) 10jenkins-bot: fix bytecode cache (v 3.5.0, Runtime release is 2) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/155029 (https://bugzilla.wikimedia.org/69657) (owner: 10Pastakhov) [14:37:57] 3MediaWiki / 3Unit tests: QUnit test errors are missing in Jenkins short console log - 10https://bugzilla.wikimedia.org/61843 (10Antoine "hashar" Musso) p:5Unprio>3Normal [14:39:00] 3Wikimedia / 3IRC: Wikimania 2015 recent changes not propagated to IRC channel - 10https://bugzilla.wikimedia.org/69741 (10Danny B.) 3NEW p:3Unprio s:3normal a:3None Wikimania 2015 recent changes not propagated to IRC channel #wikimania2015.wikipedia (Note: Yes, wikiPedia, as in any other previous y... [14:41:29] (03PS2) 10Hashar: Code review by whitelisted users should triggers tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127259 (https://bugzilla.wikimedia.org/62429) [14:41:32] (03CR) 10jenkins-bot: [V: 04-1] Code review by whitelisted users should triggers tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127259 (https://bugzilla.wikimedia.org/62429) (owner: 10Hashar) [14:42:03] (03CR) 10Hashar: "Changed bug reference from bug 64015 to bug 62429" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127259 (https://bugzilla.wikimedia.org/62429) (owner: 10Hashar) [14:47:13] (03PS66) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [14:48:19] (03CR) 10Physikerwelt: "I appreciate this discussion and the information how tidy works." [core] - 10https://gerrit.wikimedia.org/r/154083 (https://bugzilla.wikimedia.org/66516) (owner: 10Physikerwelt) [14:55:36] (03PS11) 10All1: Added a hook for modifications to MathJax [extensions/Math] - 10https://gerrit.wikimedia.org/r/154300 [14:55:40] (03CR) 10jenkins-bot: [V: 04-1] Added a hook for modifications to MathJax [extensions/Math] - 10https://gerrit.wikimedia.org/r/154300 (owner: 10All1) [14:58:46] (03PS12) 10All1: Added a hook for modifications to MathJax [extensions/Math] - 10https://gerrit.wikimedia.org/r/154300 [14:59:26] (03CR) 10Aaron Schulz: [C: 032] Don't estimate the revision count for page deletions [core] - 10https://gerrit.wikimedia.org/r/131264 (https://bugzilla.wikimedia.org/69556) (owner: 10Hoo man) [15:00:13] 3MediaWiki extensions / 3WikibaseQueryEngine: [HHVM] Tests on Travis are failing (due to HHVM's sqlsite driver) - 10https://bugzilla.wikimedia.org/69526#c3 (10Bill Schaller) Even though your CI is passing, please note that it is not currently safe to use the HHVM PDO_SQLite adapter, as it doesn't handle erro... [15:01:04] (03CR) 10Anomie: [C: 032] "SWAT" [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154845 (https://bugzilla.wikimedia.org/69317) (owner: 10Bartosz Dziewoński) [15:01:43] 3MediaWiki extensions / 3Translate: Impossible to mark pages for translation without causing a PHP fatal - 10https://bugzilla.wikimedia.org/69669#c8 (10Andre Klapper) (In reply to Glaisher from comment #7) > Apparently, the first problem was due to the job queue. 2 was present > because the page was not tran... [15:03:05] (03Merged) 10jenkins-bot: Don't estimate the revision count for page deletions [core] - 10https://gerrit.wikimedia.org/r/131264 (https://bugzilla.wikimedia.org/69556) (owner: 10Hoo man) [15:03:56] (03Merged) 10jenkins-bot: Fix URL protocol detection regex for file link= parameter [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154845 (https://bugzilla.wikimedia.org/69317) (owner: 10Bartosz Dziewoński) [15:04:51] superm401: Around? [15:06:11] (03PS13) 10Physikerwelt: Added a hook for modifications to MathJax [extensions/Math] - 10https://gerrit.wikimedia.org/r/154300 (owner: 10All1) [15:07:14] (03CR) 10Anomie: [C: 032] "SWAT" [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/154844 (https://bugzilla.wikimedia.org/69317) (owner: 10Bartosz Dziewoński) [15:07:29] (03PS1) 10Prtksxna: settings: Fix margins [extensions/Popups] - 10https://gerrit.wikimedia.org/r/155050 [15:08:03] (03PS14) 10All1: Added a hook for modifications to MathJax [extensions/Math] - 10https://gerrit.wikimedia.org/r/154300 [15:08:12] 3MediaWiki extensions / 3Extensions requests: Template Auto-Completion - 10https://bugzilla.wikimedia.org/15187#c2 (10Ricordisamoa) This is not about VisualEditor, but wikitext editing, i.e. implementing something like https://it.wikipedia.org/wiki/MediaWiki:Gadget-CompletaTemplate.js as an extension. [15:08:16] (03CR) 10Physikerwelt: [C: 04-1] Added a hook for modifications to MathJax [extensions/Math] - 10https://gerrit.wikimedia.org/r/154300 (owner: 10All1) [15:09:13] (03CR) 10Physikerwelt: Added a hook for modifications to MathJax (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/154300 (owner: 10All1) [15:09:59] (03Merged) 10jenkins-bot: Fix URL protocol detection regex for file link= parameter [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/154844 (https://bugzilla.wikimedia.org/69317) (owner: 10Bartosz Dziewoński) [15:10:14] 3MediaWiki / 3Page deletion: Page with less than 5,000 revisions can't be deleted - 10https://bugzilla.wikimedia.org/69556 (10Jesús Martínez Novo (Ciencia Al Poder)) 5PATC>3RESO/FIX a:3Marius Hoch [15:10:25] (03CR) 10Physikerwelt: [C: 032] "I think this is OK now." [extensions/Math] - 10https://gerrit.wikimedia.org/r/154300 (owner: 10All1) [15:11:37] (03Merged) 10jenkins-bot: Added a hook for modifications to MathJax [extensions/Math] - 10https://gerrit.wikimedia.org/r/154300 (owner: 10All1) [15:12:12] 3MediaWiki / 3Parser: Interwiki prefixes that end in a URL protocol cannot be used as link= for file inclusions - 10https://bugzilla.wikimedia.org/69317#c10 (10Bartosz Dziewoński) 5PATC>3RESO/FIX Fixed and deployed. Thanks everyone. [15:12:53] GSoC wrap up meeting in #wikimedia-office for those interested. [15:19:27] 3Wikimedia / 3Site requests: Enable uploads on eml.wikipedia - 10https://bugzilla.wikimedia.org/69056 (10Calak) 5PATC>3RESO/FIX [15:19:57] 3Wikimedia / 3Site requests: Add two swedish URLs to wgCopyUploadsDomains for Commons - 10https://bugzilla.wikimedia.org/69439 (10John F. Lewis) 5PATC>3RESO/FIX [15:20:00] 3Wikimedia / 3Site requests: Create "Affiliate" namespace on chapcom.wikimedia.org - 10https://bugzilla.wikimedia.org/69549 (10John F. Lewis) 5PATC>3RESO/FIX [15:21:26] (03CR) 10TheDJ: "some pattern questions inline.." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/154083 (https://bugzilla.wikimedia.org/66516) (owner: 10Physikerwelt) [15:24:14] (03PS2) 10Anomie: API: generalized submodules for action=paraminfo [core] - 10https://gerrit.wikimedia.org/r/154148 [15:25:18] (03PS2) 10Anomie: API: Add a "submodule" param type [core] - 10https://gerrit.wikimedia.org/r/154147 [15:25:43] (03PS2) 10Anomie: API: Add rawcontinue parameter to action=query [core] - 10https://gerrit.wikimedia.org/r/154092 [15:26:00] 3MediaWiki extensions / 3Translate: Display error message instead of a PHP fatal in case a page not marked for translation yet is to be discarded - 10https://bugzilla.wikimedia.org/69669#c9 (10Vogone) (In reply to Andre Klapper from comment #8) > (In reply to Glaisher from comment #7) > > Apparently, the fir... [15:26:50] (03PS3) 10Anomie: API: Add "batchcomplete" to simplified continuation result [core] - 10https://gerrit.wikimedia.org/r/152359 [15:29:03] (03PS2) 10Anomie: Improve Parser::replaceUnusualEscapes [core] - 10https://gerrit.wikimedia.org/r/152889 (https://bugzilla.wikimedia.org/57909) [15:30:44] (03PS4) 10Anomie: Add HTMLAutoCompleteSelectField [core] - 10https://gerrit.wikimedia.org/r/142668 [15:34:29] (03PS1) 10Florianschmidtwelzow: Update MobileFrontend [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/155055 [15:39:21] (03CR) 10Physikerwelt: Protect MathML from Tidy (031 comment) [core] - 10https://gerrit.wikimedia.org/r/154083 (https://bugzilla.wikimedia.org/66516) (owner: 10Physikerwelt) [15:43:28] 3MediaWiki / 3Skin and page rendering: Patrol link is misplaced when content contains uncleared floating elements - 10https://bugzilla.wikimedia.org/64176#c9 (10Lydia Pintscher) Hmmm I just checked an unpratrolled edit in Firefox and Chromium and it looks fine. What browser are you using? Is a gadget maybe r... [15:51:00] 3MediaWiki extensions / 3UniversalLanguageSelector: ULS: switching to LTR causes LTR languages to temporarily appear in RTL - 10https://bugzilla.wikimedia.org/69745 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None Created attachment 16236 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16236&act... [15:51:42] 3MediaWiki extensions / 3UniversalLanguageSelector: ULS: switching to LTR causes LTR languages to temporarily appear in RTL - 10https://bugzilla.wikimedia.org/69745 (10Dan Garry) s:5normal>3trivia [15:52:29] 3MediaWiki / 3Parser: RTL/bidirectional issues (tracking) - 10https://bugzilla.wikimedia.org/745 (10Amir E. Aharoni) [15:52:29] 3MediaWiki extensions / 3UniversalLanguageSelector: ULS: switching to LTR causes LTR languages to temporarily appear in RTL - 10https://bugzilla.wikimedia.org/69745 (10Amir E. Aharoni) [15:54:30] 3MediaWiki extensions / 3Translate: tvar with underscore incomplete as insertable - 10https://bugzilla.wikimedia.org/69746 (10Siebrand Mazeland) 3NEW p:3Unprio s:3normal a:3None When tvar name contains an underscore like for example "Linking_data" in the example #Linking_data",... [15:54:50] (03PS1) 10Prtksxna: settings: Fix strings, copy and capitalization [extensions/Popups] - 10https://gerrit.wikimedia.org/r/155057 (https://bugzilla.wikimedia.org/68812) [15:59:38] (03CR) 10Siebrand: settings: Fix strings, copy and capitalization (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/155057 (https://bugzilla.wikimedia.org/68812) (owner: 10Prtksxna) [16:00:38] (03CR) 10Amire80: [C: 04-1] settings: Fix strings, copy and capitalization (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/155057 (https://bugzilla.wikimedia.org/68812) (owner: 10Prtksxna) [16:06:42] (03CR) 10Tim Starling: "I'm on vacation right now, so I don't have time to review this. I would be happy if you made a decision yourselves." [core] - 10https://gerrit.wikimedia.org/r/153619 (https://bugzilla.wikimedia.org/69380) (owner: 10Jackmcbarn) [16:14:46] (03CR) 10CSteipp: Protect MathML from Tidy (031 comment) [core] - 10https://gerrit.wikimedia.org/r/154083 (https://bugzilla.wikimedia.org/66516) (owner: 10Physikerwelt) [16:15:07] bawolff: :D I saw you used quarry :) [16:15:44] I did [16:17:15] YuviPanda: Context was https://www.mediawiki.org/wiki/Talk:Analytics#Question if your curious (Someone asked if there was an explanation on how to run certain stats for non-programmers, so I tried to explain and probably failed horribly) [16:18:55] bawolff: ah, cool. It'll get CSV output soon, and JSON output already exists (not exposed, just open your network tab in brwoser) [16:20:30] 3Wikimedia / 3Bugzilla: Accessing bug 9444 via XML RPC API crashes due to invalid byte sequence: "not well-formed (invalid token)" - 10https://bugzilla.wikimedia.org/69747 (10Andre Klapper) 3NEW p:3Unprio s:3major a:3None [...] body: ' 3Wikimedia / 3Bugzilla: Accessing bug 9444 via XML RPC API crashes due to invalid byte sequence: "not well-formed (invalid token)" - 10https://bugzilla.wikimedia.org/69747#c1 (10Andre Klapper) p:5Unprio>3High Upstreamed as https://bugzilla.mozilla.org/show_bug.cgi?id=1055629 [16:33:12] (03CR) 10Worden.lee: "Thank you! The translation and formatting improvements are very much appreciated. There are a couple of breaking changes in the code tha" (036 comments) [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/155010 (owner: 10Jack Phoenix) [16:35:28] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/153619 (https://bugzilla.wikimedia.org/69380) (owner: 10Jackmcbarn) [16:36:36] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/155057 (https://bugzilla.wikimedia.org/68812) (owner: 10Prtksxna) [16:41:30] 3MediaWiki extensions / 3WikidataRepo: edit summary for redirects has missing parameter - 10https://bugzilla.wikimedia.org/69750 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs edit summary for redirects has wrong/missing parameter: Q631‎; 16:38 . . (-94)‎ . . ‎AudeBot (Talk | contribs | block)‎... [16:46:24] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/155039 (owner: 10Smuggli) [16:47:13] 3MediaWiki / 3Skin and page rendering: Patrol link is misplaced when content contains uncleared floating elements - 10https://bugzilla.wikimedia.org/64176#c10 (10Fomafix) (In reply to Lydia Pintscher from comment #9) > What browser are you using? I generated the screenshot with Firefox. Other browsers have... [16:47:32] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/84194 (owner: 10TTO) [16:51:04] (03CR) 10EBernhardson: "I think it would be too inconvenient to get the right information passed around for different pieces to decide to use master or slave, as" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154955 (https://bugzilla.wikimedia.org/68531) (owner: 10EBernhardson) [16:52:12] 3Wikimedia / 3General/Unknown: Translation memory (solr) is failing - 10https://bugzilla.wikimedia.org/69613#c13 (10Andre Klapper) (In reply to Nik Everett from comment #11) > So I'm not sure where to go from here - this strdist is exactly what the > Elasticsearch translation memory doesn't support. Any ide... [16:53:12] 3MediaWiki / 3General/Unknown: Investigate whether taking an action on a page (delete, import, etc.) should require being able to edit it - 10https://bugzilla.wikimedia.org/69380#c25 (10Brad Jorsch) (In reply to Brad Jorsch from comment #20) > In a quick glance through the code, it looks like the only side e... [16:53:51] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (033 comments) [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/155010 (owner: 10Jack Phoenix) [16:54:04] (03PS1) 10Manybubbles: Loosen Elasticsearch's groovy sandbox slightly [vagrant] - 10https://gerrit.wikimedia.org/r/155066 [16:54:06] (03PS1) 10Prtksxna: article: Fix settings icon [extensions/Popups] - 10https://gerrit.wikimedia.org/r/155067 (https://bugzilla.wikimedia.org/69022) [16:54:16] (03CR) 10EBernhardson: [C: 032] Remove red outline from invalid inputs [core] - 10https://gerrit.wikimedia.org/r/154940 (owner: 10Jdlrobson) [16:54:39] (03CR) 10Manybubbles: "This will allow Cirrus to run with groovy in vagrant." [vagrant] - 10https://gerrit.wikimedia.org/r/155066 (owner: 10Manybubbles) [16:55:32] (03PS2) 10Aaron Schulz: Added DatabaseBase::getRowCount() method [core] - 10https://gerrit.wikimedia.org/r/154291 [16:56:00] 3MediaWiki extensions / 3WikidataRepo: write a maintenance script to fill the query store - 10https://bugzilla.wikimedia.org/63230 (10Jeroen De Dauw) 5NEW>3RESO/FIX [16:56:50] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/152077 (owner: 10Legoktm) [16:57:10] (03PS1) 10Manybubbles: Port scripts to groovy [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/155068 [16:57:35] (03CR) 10Manybubbles: [C: 04-2] "No merging until Elasticsearch 1.3 is deployed to production." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/155068 (owner: 10Manybubbles) [16:57:52] (03Merged) 10jenkins-bot: Remove red outline from invalid inputs [core] - 10https://gerrit.wikimedia.org/r/154940 (owner: 10Jdlrobson) [16:58:27] 3MediaWiki / 3Recent changes: EnhancedChangesList::arrow(), sideArrow(), downArrow(), spacerArrow() are silly methods and should be removed - 10https://bugzilla.wikimedia.org/69675#c3 (10Nemo) Aww duplication :( [17:03:06] (03CR) 10EBernhardson: [C: 032] Show username in previews [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154946 (https://bugzilla.wikimedia.org/69257) (owner: 10Jdlrobson) [17:03:35] (03CR) 10EBernhardson: [C: 032] Use default browser tooltips on block and talk actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154951 (https://bugzilla.wikimedia.org/67643) (owner: 10Jdlrobson) [17:03:45] (03Merged) 10jenkins-bot: Show username in previews [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154946 (https://bugzilla.wikimedia.org/69257) (owner: 10Jdlrobson) [17:04:08] (03Merged) 10jenkins-bot: Use default browser tooltips on block and talk actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154951 (https://bugzilla.wikimedia.org/67643) (owner: 10Jdlrobson) [17:08:30] (03PS1) 10Anomie: $wgDisableUnmergedEditing should also prevent deletion [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/155070 (https://bugzilla.wikimedia.org/69380) [17:10:05] (03CR) 10EBernhardson: [C: 04-1] "this patch creates some unreachable code" (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154954 (https://bugzilla.wikimedia.org/67646) (owner: 10Jdlrobson) [17:10:56] (03PS1) 10QChris: Remove PhpTagsCodeEditor, as it will be deleted [extensions] - 10https://gerrit.wikimedia.org/r/155071 [17:11:27] 3MediaWiki extensions / 3Translate: Display error message instead of a PHP fatal when discouraging half-marked pages - 10https://bugzilla.wikimedia.org/69669#c10 (10Nemo) I could not parse the summary without reading it several times, tweaked a bit. Usually we don't consider fatals "minor", and avoiding a fa... [17:11:40] (03CR) 10CSteipp: [C: 032] "Thanks! We're not using this on WMF wikis, so there shouldn't be a change. But good idea in case we implement this post SUL finalization." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/155070 (https://bugzilla.wikimedia.org/69380) (owner: 10Anomie) [17:12:05] (03Merged) 10jenkins-bot: $wgDisableUnmergedEditing should also prevent deletion [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/155070 (https://bugzilla.wikimedia.org/69380) (owner: 10Anomie) [17:15:37] (03PS1) 10QChris: Remove PhpTagsCodeEditor module, as the repo will be deleted [extensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/155073 [17:15:39] (03PS2) 10Jdlrobson: Reveal contributions link on hover [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154954 (https://bugzilla.wikimedia.org/67646) [17:16:10] (03CR) 10Quiddity: "For popups-settings-option-for-editors-description, instead of "Use advanced actions to monitor and edit the" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/155057 (https://bugzilla.wikimedia.org/68812) (owner: 10Prtksxna) [17:18:52] (03CR) 10Jdlrobson: [C: 032] Override requests for DB_SLAVE when submitting new content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154955 (https://bugzilla.wikimedia.org/68531) (owner: 10EBernhardson) [17:19:25] (03Merged) 10jenkins-bot: Override requests for DB_SLAVE when submitting new content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154955 (https://bugzilla.wikimedia.org/68531) (owner: 10EBernhardson) [17:19:32] (03CR) 10Anomie: [C: 032] "Ok, seems like the side effects will be taken care of: CentralAuth has I7ba167f0, Chris thinks TitleBlacklist is fine allowing delete-with" [core] - 10https://gerrit.wikimedia.org/r/153619 (https://bugzilla.wikimedia.org/69380) (owner: 10Jackmcbarn) [17:22:19] (03PS3) 10EBernhardson: Reveal contributions link on hover [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154954 (https://bugzilla.wikimedia.org/67646) (owner: 10Jdlrobson) [17:22:26] (03CR) 10EBernhardson: [C: 032] Reveal contributions link on hover [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154954 (https://bugzilla.wikimedia.org/67646) (owner: 10Jdlrobson) [17:22:58] (03PS8) 10Jdlrobson: Move jQueryFindWithParent into its own findWithParent plugin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153627 (owner: 10SG) [17:23:01] (03Merged) 10jenkins-bot: Test only against protection for deleting [core] - 10https://gerrit.wikimedia.org/r/153619 (https://bugzilla.wikimedia.org/69380) (owner: 10Jackmcbarn) [17:23:10] (03Merged) 10jenkins-bot: Reveal contributions link on hover [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154954 (https://bugzilla.wikimedia.org/67646) (owner: 10Jdlrobson) [17:23:30] (03CR) 10Jdlrobson: [C: 032] "Twas quicker to fix myself.. :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153627 (owner: 10SG) [17:23:39] (03PS4) 10Jdlrobson: Change jquery.conditionalScroll to ext.flow space in Resources, and remove Core collision check [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154833 (owner: 10SG) [17:24:18] (03Merged) 10jenkins-bot: Move jQueryFindWithParent into its own findWithParent plugin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153627 (owner: 10SG) [17:24:39] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/154127 (owner: 10Ebe123) [17:27:17] (03CR) 10EBernhardson: [C: 032] Subscribe to board = auto-subscribe to new topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153411 (owner: 10Matthias Mullie) [17:27:52] (03Merged) 10jenkins-bot: Subscribe to board = auto-subscribe to new topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153411 (owner: 10Matthias Mullie) [17:28:59] (03PS6) 10Bsitu: [4] Add revision local cache holder object [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154387 [17:29:30] (03CR) 10Siebrand: [C: 032] Get rid of wfMsg* calls [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154983 (owner: 10Legoktm) [17:29:37] (03Merged) 10jenkins-bot: Get rid of wfMsg* calls [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154983 (owner: 10Legoktm) [17:31:17] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/149522 (owner: 10Cook879) [17:31:42] 3MediaWiki extensions / 3Translate: Display error message instead of a PHP fatal when discouraging half-marked pages - 10https://bugzilla.wikimedia.org/69669#c11 (10Vogone) (In reply to Nemo from comment #10) > I could not parse the summary without reading it several times, tweaked a > bit. Sorry and thanks. [17:33:13] (03CR) 10Siebrand: [C: 031] "Please add a documentation page at https://www.mediawiki.org/wiki/Manual:$wgExportMaxTime" [core] - 10https://gerrit.wikimedia.org/r/154843 (owner: 10Legoktm) [17:36:15] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/154839 (owner: 10Physikerwelt) [17:42:29] 3MediaWiki extensions / 3SecurePoll: SecurePoll: Certain poll types give fatal exceptions when you try to vote - 10https://bugzilla.wikimedia.org/68051 (10Brad Jorsch) 5NEW>3RESO/FIX [17:43:46] (03CR) 10Bsitu: [5] Code cleanup and miscellneous fix (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154386 (owner: 10Bsitu) [17:44:01] (03PS3) 10Gergő Tisza: Add code for logging image loading times [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/151262 [17:47:12] 3MediaWiki extensions / 3SecurePoll: SecurePoll Redesign: Poll Creation should auto create GPG keys - 10https://bugzilla.wikimedia.org/68129#c1 (10Brad Jorsch) (In reply to James Alexander from comment #0) > (and private key displayed or saved, personally I think it should be saved > to server) As far as sa... [17:47:35] (03CR) 10SG: [C: 032] Change jquery.conditionalScroll to ext.flow space in Resources, and remove Core collision check [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154833 (owner: 10SG) [17:48:38] (03CR) 10Chad: [C: 032] "Same as prod, lgtm." [vagrant] - 10https://gerrit.wikimedia.org/r/155066 (owner: 10Manybubbles) [17:48:43] (03Merged) 10jenkins-bot: Loosen Elasticsearch's groovy sandbox slightly [vagrant] - 10https://gerrit.wikimedia.org/r/155066 (owner: 10Manybubbles) [17:49:17] (03CR) 10Chad: [C: 032] Skip highlighting we don't need [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/154898 (owner: 10Manybubbles) [17:49:30] (03Merged) 10jenkins-bot: Skip highlighting we don't need [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/154898 (owner: 10Manybubbles) [17:56:43] (03CR) 10Kaldari: [C: 04-1] Begin deprecation of mediawiki.ui style module (032 comments) [core] - 10https://gerrit.wikimedia.org/r/151791 (owner: 10Jdlrobson) [17:56:56] (03CR) 10EBernhardson: [C: 032] [2] Add title local cache holder objects [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154381 (owner: 10Bsitu) [17:57:05] (03CR) 10EBernhardson: [C: 032] [3] Use title local cache to cache title object [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154382 (owner: 10Bsitu) [17:57:23] (03Merged) 10jenkins-bot: [2] Add title local cache holder objects [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154381 (owner: 10Bsitu) [17:57:30] (03Merged) 10jenkins-bot: [3] Use title local cache to cache title object [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154382 (owner: 10Bsitu) [17:58:02] (03CR) 10EBernhardson: [C: 032] [4] Add revision local cache holder object [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154387 (owner: 10Bsitu) [17:58:08] (03PS5) 10EBernhardson: [5] Code cleanup and miscellneous fix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154386 (owner: 10Bsitu) [17:58:23] (03PS1) 10SG: Improvements to progressiveEnhancement, new features, and unit tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155081 [17:58:29] (03Merged) 10jenkins-bot: [4] Add revision local cache holder object [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154387 (owner: 10Bsitu) [17:58:58] (03CR) 10jenkins-bot: [V: 04-1] Improvements to progressiveEnhancement, new features, and unit tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155081 (owner: 10SG) [18:01:15] (03CR) 10Frédéric Wang: "I don't understand what was done here. mw.loader.load is asynchronous, so the init function will just continue to execute without waiting " [extensions/Math] - 10https://gerrit.wikimedia.org/r/154300 (owner: 10All1) [18:02:55] (03PS1) 10Jack Phoenix: Convert to JSON-based i18n, bump version number + copyright year [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/155085 [18:03:32] (03CR) 10Jack Phoenix: [C: 032 V: 032] Convert to JSON-based i18n, bump version number + copyright year [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/155085 (owner: 10Jack Phoenix) [18:04:38] (03CR) 10Bartosz Dziewoński: "(By the way, we might want to announce this change when it's merged, via Tech News or something probably.)" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/152077 (owner: 10Legoktm) [18:06:05] (03CR) 10Calak: [C: 031] Allow two-tier setup of transwiki import sources [core] - 10https://gerrit.wikimedia.org/r/84194 (owner: 10TTO) [18:11:08] (03CR) 10Umherirrender: "Needs resubmit" [core] - 10https://gerrit.wikimedia.org/r/154286 (owner: 10Umherirrender) [18:20:12] 3MediaWiki extensions / 3SecurePoll: SecurePoll Redesign: Poll Creation should auto create GPG keys - 10https://bugzilla.wikimedia.org/68129#c2 (10James Alexander) (In reply to Brad Jorsch from comment #1) > (In reply to James Alexander from comment #0) > > (and private key displayed or saved, personally I t... [18:20:28] 3MediaWiki extensions / 3Capiunto: security review for Capiunto - 10https://bugzilla.wikimedia.org/69541#c5 (10Nik Everett) (In reply to Chris Steipp from comment #3) > Can you point to any more information about the extension? Can anyone answer this question? [18:21:37] (03CR) 10Frédéric Wang: "Can you just please stop submitting so many commits? As TheDJ said, you should first do local testing and only submit a commit when it is " [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [18:21:57] 3MediaWiki extensions / 3Capiunto: security review for Capiunto - 10https://bugzilla.wikimedia.org/69541#c6 (10Nik Everett) This looks promising: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCapiunto/1441b9ab1c126d7047e182a41497303a4a32a9bb/docs%2Finfobox.wiki [18:23:54] (03CR) 10Frédéric Wang: "I think this commit should be backed out, unless someone can explain precisely what it is doing with respect to MathJax / MediaWiki sync A" [extensions/Math] - 10https://gerrit.wikimedia.org/r/154300 (owner: 10All1) [18:26:03] (03CR) 10Frédéric Wang: "Moritz: did you try to contact the author of http://sourceforge.net/p/tidy/patches/84/ to know the status of his patch? It would be good i" [core] - 10https://gerrit.wikimedia.org/r/154083 (https://bugzilla.wikimedia.org/66516) (owner: 10Physikerwelt) [18:31:28] (03CR) 10Bsitu: Delete invalid records from echo_target_page (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153372 (owner: 10Bsitu) [18:32:27] (03CR) 10Legoktm: [C: 032] Allow two-tier setup of transwiki import sources [core] - 10https://gerrit.wikimedia.org/r/84194 (owner: 10TTO) [18:34:20] (03PS9) 10Bsitu: Delete invalid records from echo_target_page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153372 [18:35:58] (03Merged) 10jenkins-bot: Allow two-tier setup of transwiki import sources [core] - 10https://gerrit.wikimedia.org/r/84194 (owner: 10TTO) [18:38:29] (03PS1) 10leucosticte: Add seven hooks to enable more flags to be added to changes lists, etc. [core] - 10https://gerrit.wikimedia.org/r/155093 (https://bugzilla.wikimedia.org/69677) [18:38:44] 3MediaWiki extensions / 3MaintenanceShell: MainteniceShell broken in MediaWiki 1.24 - 10https://bugzilla.wikimedia.org/69075#c8 (10Florian) 5UNCO>3RESO/WOR Just for info: I'm using wmf16 and MaintenanceShell 0.5 in my production wiki, too. Use several scripts sometimes, all without errors. Run now the u... [18:46:58] (03PS5) 10Parent5446: Replaced hash_equals with a custom function [core] - 10https://gerrit.wikimedia.org/r/148442 (https://bugzilla.wikimedia.org/28419) [18:47:19] (03PS1) 10Aude: Update Wikidata, fix fatal in ChangeNotification job [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/155094 [18:50:30] (03CR) 10Legoktm: "(added to tech news)" [core] - 10https://gerrit.wikimedia.org/r/84194 (owner: 10TTO) [18:50:57] 3MediaWiki-Vagrant: Unable to push changes to gerrit when using Vagrant - 10https://bugzilla.wikimedia.org/62844#c2 (10Eran Roz) With no Vagrant, after pip install -U git-review, I'm getting the same error. [18:51:31] (03CR) 10Bsitu: [C: 031] "Looks good to me, I will run some more tests on this. I also like to merge this after the branch cut so we could have this tested in beta" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151272 (owner: 10EBernhardson) [18:51:44] (03CR) 10Chad: [C: 032] Update Wikidata, fix fatal in ChangeNotification job [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/155094 (owner: 10Aude) [18:54:45] (03CR) 10Bsitu: [C: 032] Fix line height/size of notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154331 (owner: 10Jdlrobson) [18:54:55] (03Merged) 10jenkins-bot: Update Wikidata, fix fatal in ChangeNotification job [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/155094 (owner: 10Aude) [18:55:12] (03Merged) 10jenkins-bot: Fix line height/size of notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154331 (owner: 10Jdlrobson) [18:56:55] (03Abandoned) 10Bsitu: Show up to 100 notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154321 (owner: 10Jdlrobson) [18:58:45] (03PS6) 10EBernhardson: Reset per-user notify types for each user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151271 [19:07:13] Anybody there who has parser hooks functions experience? [19:07:32] (03CR) 10Calak: [C: 031] Update article count when pages are moved [core] - 10https://gerrit.wikimedia.org/r/148585 (https://bugzilla.wikimedia.org/64333) (owner: 10TTO) [19:08:42] 3Wikimedia / 3Site requests: Activate Flagged Revisions for modules namespace on Ukrainian Wikipedia - 10https://bugzilla.wikimedia.org/67748#c4 (10Bohdan) 5RESO/FIX>3REOP Thanks but you guys somewhat messed in there so NSs 0, 6 and 10 are let it be called "double patrollable" :) Look < https://uk.wikipe... [19:09:01] I have an expensive hook that generates an HTML table based on a large JSON file. I’d like to make sure that the parser hook is executed **EXCLUSIVELY** when the page is rendered from a browser. As a side question, is there other contexts where a parser hook can act (e.g. update script)? [19:11:15] 3Wikimedia / 3Site requests: Activate Flagged Revisions for modules namespace on Ukrainian Wikipedia - 10https://bugzilla.wikimedia.org/67748 (10Tomasz W. Kozlowski) a:5Tomasz W. Kozlowski>3None [19:11:39] (03CR) 10Calak: [C: 031] Use XML localName when importing [core] - 10https://gerrit.wikimedia.org/r/149508 (https://bugzilla.wikimedia.org/4520) (owner: 10TTO) [19:12:50] odder stopped working on bugs as well as on translations? :( [19:13:16] odd [19:13:36] (03PS1) 10Physikerwelt: Revert "Added a hook for modifications to MathJax" [extensions/Math] - 10https://gerrit.wikimedia.org/r/155099 [19:13:39] can somebody pick https://bugzilla.wikimedia.org/67748 ? It seems there a small change to be done [19:14:03] renoirb: if it's a parser hook, it may be called whenever the page gets parsed: on edit preview, and on normal page view (although it should be only once, because the parser output gets cached) [19:14:04] That's just as always that I dont know how to make damn patches [19:14:17] Cladis: use the GPU [19:14:29] easier if you're on Windows I guess [19:14:53] https://www.google.com/search?q=GPU&ie=utf-8&oe=utf-8&aq=t&rls=org.mozilla:ru:official&client=firefox-beta&channel=sb ? graphics processing unit ? [19:15:04] no, Gerrit Patch Uploader [19:15:05] renoirb: it can also be reparsed if it needs to update links/templates used on that page, when a template on that page gets edited, or a linked page created/deleted [19:15:06] Vogone: [19:15:16] 3MediaWiki extensions / 3WikidataRepo: Refactor EntityContent (tracking) - 10https://bugzilla.wikimedia.org/69752 (10Bene*) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Currently, EntityContent is much too long and has too many responsibilities. Some refactoring is needed to move most of the code out of... [19:15:50] I wonder why I would want my page to be rendered through a parser hook execution during a shell run. Is there a reason for this? Vulpix ? [19:16:40] In my case, Vulpix, its data coming from somewhere else and the content it gets generated is completely independent of mediawiki, its only using MW to set the placeholder. [19:16:46] renoirb: yes. when I said it may get reparsed because of a template change, it may be handled by a background job [19:16:48] Vogone: Allowed patch formats: [19:16:49] git format-patch -1 --stdout HEAD [19:16:49] diff -u file1 file2 [19:16:49] git diff [19:16:49] svn diff [19:16:49] where am i to get it? [19:16:51] Vulpix, note, We are using SMW [19:17:34] Cladis: install git bash maybe? [19:17:47] then you can easily generate git diffs [19:17:51] Ok Vulpix, I guess that if I set a if(/* .... wonder what here... */) { return; } when its being executed in a background job [19:17:59] renoirb: https://www.mediawiki.org/wiki/Manual:Job_queue#Job_examples [19:18:24] can someone create a tool where patches could be made as on bitbucket just in web interface in textarea or whatever it is there? [19:18:27] 3MediaWiki extensions / 3WikidataRepo: Refactor EntityContent (tracking) - 10https://bugzilla.wikimedia.org/69752 (10Bene*) [19:18:41] Cladis: dunno, butis it possible that cmd.exe can do "diff -u file1 file2"? [19:18:47] 3MediaWiki extensions / 3WikidataRepo: Remove getTitle() from EntityContent - 10https://bugzilla.wikimedia.org/65531 (10Bene*) [19:18:47] 3MediaWiki extensions / 3WikidataRepo: Remove save(), getPage() and related methods from EntityContent - 10https://bugzilla.wikimedia.org/62493 (10Bene*) [19:18:47] 3MediaWiki extensions / 3WikidataRepo: Factor diff logic out of EntityContent - 10https://bugzilla.wikimedia.org/67238 (10Bene*) [19:18:47] 3MediaWiki extensions / 3WikidataRepo: basic support for Wikimedia Commons (MediaInfo entity type) - 10https://bugzilla.wikimedia.org/64288 (10Bene*) [19:18:51] YuviPanda had a tool which copied github PRs to gerrit, but it died :/ [19:18:52] renoirb: you shouldn't do that. A parser hook should do the same even when run by the job queue [19:19:04] Vogone: and what is "easily" ? some fancy terminal thing? [19:19:11] legoktm: I should bring it back... up... at... some time. [19:19:20] My job queue gets sometimes to millions. But we have an old version of MW+SMW http://docs.webplatform.org/wiki/Special:Version [19:19:29] :o [19:19:32] renoirb: if not, you probably shouldn't use a parser hook, but some other hook not depending on the wikitext of the page [19:19:34] are you running runJobs.php...? [19:19:42] Cladis: "diff -u file1 file2" (file1 is the old file, file2 the new one) and then c&p the output to GPU I guess [19:19:50] Vogone: hm never tryied such a thing. /me hates terminal. and also creating two files isn't what i call easy :( [19:20:06] *tried [19:20:07] Yes i'm running the runJobs.php, twice per hour. [19:20:10] Cladis: if you use github's web editor, it'll create the diff file for you [19:20:34] if https://github.com/wikimedia/mediawiki-core/commit/35c336bc1d99df89dd85e31320492d542919efe8 is your commit, you just go to https://github.com/wikimedia/mediawiki-core/commit/35c336bc1d99df89dd85e31320492d542919efe8.diff [19:20:41] (add the .diff to the url) [19:21:52] renoirb: on uncyclomedia, we have a cron that starts runJobs.php every minute, but only executes a maximum of 100 jobs [19:21:56] zomg, github [19:22:02] I even had to add `timeout` on the shell script that’s called by the crontab because we were getting into infinite job creation loops and the servers were dying when too many jobs were running. At that time, it was dying with our 5 app servers with 10 runJobs.php running in parallel. Database was crashing. [19:22:18] Oh, Thanks legoktm, will do that! [19:22:37] php * * * * * php /var/www/mediawiki/core/maintenance/runJobs.php --maxjobs 100 --maxtime 55 [19:22:40] Thanks for the hint Vulpix /me reading other parser hooks [19:22:49] er, ignore the php in front >.> [19:22:55] s/parser hooks/hooks/ [19:22:59] 3MediaWiki extensions / 3WikidataRepo: Wikiquote support - 10https://bugzilla.wikimedia.org/69753 (10Bene*) 3NEW p:3Unprio s:3normal a:3Wikidata bugs This is a tracking bug for Wikibase support on Wikiquote. More information can be found on meta: https://meta.wikimedia.org/wiki/Wikidata/Development/W... [19:23:01] but yeah, that way we only have one process running at once, [19:23:21] and any backlog gets taken care of during the night when our users are asleep [19:23:31] legoktm, mine is a bit more ocmplex. [19:23:35] :P [19:24:11] Oh, speaking of Uncyclomedia, legoktm... I was told you might be in charge of the Google Analytics? [19:24:12] 3MediaWiki extensions / 3WikidataRepo: basic support for Wikimedia Commons (MediaInfo entity type) - 10https://bugzilla.wikimedia.org/64288 (10Bene*) [19:24:14] 3MediaWiki extensions / 3WikidataRepo: Wikiquote support - 10https://bugzilla.wikimedia.org/69753 (10Bene*) [19:24:18] legoktm: that sounds usefull but im now having difficulty to find the needed file in there [19:24:42] Lcawte: yeah, it's running under my account [19:24:46] Cladis: what are you trying to edit? [19:24:51] http://noc.wikimedia.org/conf/highlight.php?file=flaggedrevs.php [19:24:57] 3MediaWiki extensions / 3WikidataRepo: Wikiquote support - 10https://bugzilla.wikimedia.org/69753 (10Bene*) [19:24:58] 3MediaWiki extensions / 3WikidataRepo: Refactor EntityContent (tracking) - 10https://bugzilla.wikimedia.org/69752 (10Bene*) [19:25:04] legoktm, I also add logger to advise, then use timeout like so: [19:25:05] logger -i -p local1.notice -t cron "[notice] Host `hostname` started MediaWiki Job Runner (live wiki)" [19:25:05] timeout 3100 /usr/bin/php /srv/webplatform/wiki/current/maintenance/runJobs.php [19:25:15] Cladis: https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/flaggedrevs.php [19:25:22] (03CR) 10All1: "Hi Frédéric," [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [19:25:48] omfg, there are now web interfaces for that? :O [19:26:05] * Vogone is not up-to-date apparently [19:26:18] renoirb: oh, you're not using MW's max time thing. [19:26:24] idk which one will work better [19:27:18] legoktm, please define "idk" :/ [19:27:18] :] [19:27:18] i don't know [19:27:18] oh! [19:27:27] operations-mediawiki-config [19:27:27] not very obvious directory for a noob :) thanks [19:27:28] um, are you using the sql backed job queue or the new fancy redis one? the WMF has a new job queue runner which I haven't tried yet for redis which is supposed to be better/faster/etc [19:27:28] I have to tell, legoktm, we are running a year+ old version of MediaWiki+SemanticMediaWiki version. I might have to rebuild everything anyway. [19:27:30] legoktm: Would you be willing to grab some numbers for me (visits or page views in an average month or day) ? Looking at maybe changing host... [19:28:02] renoirb: yeah, upgrading to a stable release would probably be a good idea [19:29:53] yup. But my HTML rendering table feature still needs to be shown in the wiki pages. The HTML gets generated once, cached to memcached/redis already. I had been through the other hoops to add ESI tags around it AND the memcache/redis invalidation when the original JSON file gets a different timestamp/etag [19:30:13] (03CR) 10Frédéric Wang: "Thanks for the explanation. I expect MathJax.Ajax.config.path to be defined before we load the extensions, so I think placing the line ins" [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [19:30:40] legoktm, Vulpix ^ [19:31:42] hm [19:32:12] ... that is what I meant by, it doesnt rely really on MW, just using it to display in our doc pages. [19:32:53] Cladis: hm, you could also fork the Gerrit Patch Uploader (for proper attribution) [19:32:54] Eventually we’ll have MUCH more data in this component... all W3C compatibility test results interpretation [19:33:39] (03PS67) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [19:34:02] is there a problem if it displays on edit previews and things? [19:34:38] a parser hook / tag is the right way to go in general [19:35:07] now I'm getting messing some text in arabian instead of just wished change( [19:35:43] 3MediaWiki / 3Recent changes: Add hooks to make it possible for an extension to add more flags to changes lists, diffs, history printouts, etc. - 10https://bugzilla.wikimedia.org/69677 (10Nathan Larson) a:3Nathan Larson [19:36:33] renoirb: well, if you have its contents cached, I don't see any problem, then. Just check if the JSON file is updated to repopulate it. Why should it matter whether it's being called from a job runner or a normal page request? [19:37:17] Because it calls the JSON file that is a heavy one, and then eats up all my server memory. [19:37:19] Cladis: link? [19:37:23] Vulpix ^ [19:37:38] split the file into smaller things? [19:37:40] ... I have to say, Vulpix, that maybe the code is doing something wrong [19:37:42] right. [19:38:22] (03CR) 10All1: "Hi Frédéric," [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [19:38:32] I thought about that too. But its compiled JSON file and then cached. I thought that having the hook not run except when a user is rendering the page would do. [19:38:36] renoirb: well, you should probably check whether the file is being read entirely in memory (which would be probably wrong) or read sequentially minimizing memory usage [19:38:52] (03PS1) 10Dbrant: Final (for real) tweak of page issues styling. [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/155103 [19:39:35] Its a HUGE JSON one liner Vulpix. I was hoping to not get to make the data file in chunks now. Maybe that’s the best thing to do anyway. [19:40:05] (03CR) 10All1: "The files load in patchset 66 when I use a MathJax startup signal. Could that be a solution?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [19:42:42] I don't mean reading it line by line, but parsing it in chunks. Apparently there's no native way to do that in PHP (in contrast to XML),but you might try this http://stackoverflow.com/questions/4049428/processing-large-json-files-in-php [19:43:12] I should reread the MWHttpRequest class and use > https://github.com/webplatform/mediawiki/blob/master/extensions/CompaTables/Compatables.class.php#L243 [19:43:27] Thanks Vulpix ! [19:46:24] (03CR) 10Aaron Schulz: [C: 04-1] "I have the same concern Chris has about entropy. Can we just use hash_equals() if it exist and fallback to the HMAC method otherwise? hash" [core] - 10https://gerrit.wikimedia.org/r/148442 (https://bugzilla.wikimedia.org/28419) (owner: 10Parent5446) [19:50:17] (03CR) 10Aaron Schulz: Added DatabaseBase::getRowCount() method (031 comment) [core] - 10https://gerrit.wikimedia.org/r/154291 (owner: 10Aaron Schulz) [19:53:37] (03CR) 10Hashar: [C: 04-1] "I love how we can now discuss about making PHP CodeSniffer voting, that would complete a long and tedious code cleanup that started a whil" (031 comment) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153575 (https://bugzilla.wikimedia.org/46500) (owner: 10Addshore) [19:53:47] (03CR) 10Legoktm: "Release notes? ;)" [core] - 10https://gerrit.wikimedia.org/r/153619 (https://bugzilla.wikimedia.org/69380) (owner: 10Jackmcbarn) [19:55:44] (03PS1) 10Umherirrender: Move @codingStandardsIgnoreStart into doc comment [core] - 10https://gerrit.wikimedia.org/r/155109 [19:58:59] (03CR) 10Chad: [C: 032 V: 032] Remove PhpTagsCodeEditor module, as the repo will be deleted [extensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/155073 (owner: 10QChris) [20:00:03] (03CR) 10Chad: [C: 032 V: 032] Remove PhpTagsCodeEditor, as it will be deleted [extensions] - 10https://gerrit.wikimedia.org/r/155071 (owner: 10QChris) [20:00:10] can someone review a core maintenance script pls? really need it for vagrant [20:00:27] https://gerrit.wikimedia.org/r/#/c/154704/ [20:00:42] (03PS2) 10Yurik: Create wiki pages & images from files [core] - 10https://gerrit.wikimedia.org/r/154704 [20:01:31] bd808, want to do it? ^ btw, vagrant is down again, rebuilding :( [20:02:57] (03PS2) 10Jack Phoenix: Some cleanup and modernization. [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/155010 [20:03:14] yurikR: I can put it on my review list, but it's pretty long right now... wikimania + vacation left quite a backlog [20:04:25] its ok :) i wonder who broke vagrant though :) [20:05:38] (03PS3) 10Umherirrender: Fetch string to pass through writeTemporary() in DatabaseOracle.php [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/154461 (https://bugzilla.wikimedia.org/64970) [20:06:40] (03CR) 10Umherirrender: "Patch Set 3: Added release notes" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/154461 (https://bugzilla.wikimedia.org/64970) (owner: 10Umherirrender) [20:06:55] (03PS1) 10Legoktm: Empty repository, leave stub file explaining merged into core [extensions/AssertEdit] (REL1_23) - 10https://gerrit.wikimedia.org/r/155114 [20:07:42] (03CR) 10Legoktm: [C: 032] Empty repository, leave stub file explaining merged into core [extensions/AssertEdit] (REL1_23) - 10https://gerrit.wikimedia.org/r/155114 (owner: 10Legoktm) [20:07:47] (03Merged) 10jenkins-bot: Empty repository, leave stub file explaining merged into core [extensions/AssertEdit] (REL1_23) - 10https://gerrit.wikimedia.org/r/155114 (owner: 10Legoktm) [20:09:18] (03CR) 10Jack Phoenix: "@Lee: Thanks for the quick review! I admit -- as you probably noticed -- that I forgot this is supposed to support 1.19 and newer, not 1.2" [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/155010 (owner: 10Jack Phoenix) [20:09:24] (03PS1) 10Legoktm: Empty repository, leave stub file explaining merged into core [extensions/SimpleAntiSpam] (REL1_22) - 10https://gerrit.wikimedia.org/r/155115 [20:09:59] (03CR) 10Legoktm: [C: 032] Empty repository, leave stub file explaining merged into core [extensions/SimpleAntiSpam] (REL1_22) - 10https://gerrit.wikimedia.org/r/155115 (owner: 10Legoktm) [20:10:04] (03Merged) 10jenkins-bot: Empty repository, leave stub file explaining merged into core [extensions/SimpleAntiSpam] (REL1_22) - 10https://gerrit.wikimedia.org/r/155115 (owner: 10Legoktm) [20:10:59] (03PS1) 10Legoktm: Empty repository, leave stub file explaining merged into core [extensions/SimpleAntiSpam] (REL1_23) - 10https://gerrit.wikimedia.org/r/155116 [20:11:41] (03CR) 10Legoktm: [C: 032] Empty repository, leave stub file explaining merged into core [extensions/SimpleAntiSpam] (REL1_23) - 10https://gerrit.wikimedia.org/r/155116 (owner: 10Legoktm) [20:11:47] (03Merged) 10jenkins-bot: Empty repository, leave stub file explaining merged into core [extensions/SimpleAntiSpam] (REL1_23) - 10https://gerrit.wikimedia.org/r/155116 (owner: 10Legoktm) [20:15:07] (03CR) 10Worden.lee: [C: 031] "This works for me." [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/155010 (owner: 10Jack Phoenix) [20:15:50] (03CR) 10EBernhardson: [C: 032] Add waitForSlave() wrapper function to Echo Database wrapper [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154952 (owner: 10Bsitu) [20:16:19] (03Merged) 10jenkins-bot: Add waitForSlave() wrapper function to Echo Database wrapper [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154952 (owner: 10Bsitu) [20:17:44] (03CR) 10Hashar: [C: 04-1] "Thanks for the patch. The issue now is to have the release branches to be able to load that new PHPUnit code base." [integration/phpunit] - 10https://gerrit.wikimedia.org/r/151252 (owner: 10EBernhardson) [20:21:40] (03CR) 10Legoktm: [C: 032] Add SQL DDL for rename requests [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/150997 (https://bugzilla.wikimedia.org/68889) (owner: 10BryanDavis) [20:22:07] (03Merged) 10jenkins-bot: Add SQL DDL for rename requests [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/150997 (https://bugzilla.wikimedia.org/68889) (owner: 10BryanDavis) [20:24:38] (03CR) 10Bsitu: [C: 032] Hygiene: Mega clean up the Echo footer code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154203 (owner: 10Jdlrobson) [20:25:05] (03Merged) 10jenkins-bot: Hygiene: Mega clean up the Echo footer code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154203 (owner: 10Jdlrobson) [20:27:42] (03CR) 10Aaron Schulz: [C: 032] Move @codingStandardsIgnoreStart into doc comment [core] - 10https://gerrit.wikimedia.org/r/155109 (owner: 10Umherirrender) [20:27:51] (03CR) 10Jack Phoenix: [C: 031] SpecialGadgets: $wgScript --> wfScript() [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154738 (owner: 10Legoktm) [20:28:40] (03CR) 10Worden.lee: "This works for me." [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/155010 (owner: 10Jack Phoenix) [20:29:18] (03CR) 10Jack Phoenix: [C: 031] Declare SpecialGadgets::$par [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154731 (owner: 10Legoktm) [20:30:34] (03CR) 10Jack Phoenix: [C: 031] SpecialGadgets: wfMessage --> $this->msg [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154735 (owner: 10Legoktm) [20:31:27] (03CR) 10Jack Phoenix: [C: 031] Gadget: Add typehinting, and don't re-invent some things from core [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154727 (owner: 10Legoktm) [20:33:18] (03Merged) 10jenkins-bot: Move @codingStandardsIgnoreStart into doc comment [core] - 10https://gerrit.wikimedia.org/r/155109 (owner: 10Umherirrender) [20:37:46] 3MediaWiki / 3Parser: Category is treated as if it is in nowki despite being outside pre tag - 10https://bugzilla.wikimedia.org/69755 (10Mark A. Hershberger) 3NEW p:3Unprio s:3normal a:3None I've created a page that shows the problem: https://en.wikipedia.org/wiki/User:MarkAHershberger/preBug and htt... [20:38:01] (03CR) 10Jack Phoenix: [C: 031] Add $wgExportMaxTime to set a max timelimit on Special:Export [core] - 10https://gerrit.wikimedia.org/r/154843 (owner: 10Legoktm) [20:39:12] 3Wikimedia / 3Logstash: Find a better auth mechanism for logstash in labs - 10https://bugzilla.wikimedia.org/61754#c2 (10Daniel Zahn) https://gerrit.wikimedia.org/r/152932 it is now stored within the project, accessible for roots on the deployment-bastion instance [20:39:22] (03CR) 10MaxSem: [C: 032] "Thanks!" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/154461 (https://bugzilla.wikimedia.org/64970) (owner: 10Umherirrender) [20:42:36] (03Merged) 10jenkins-bot: Fetch string to pass through writeTemporary() in DatabaseOracle.php [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/154461 (https://bugzilla.wikimedia.org/64970) (owner: 10Umherirrender) [20:43:01] 3Wikimedia / 3General/Unknown: Schema changes for Wikimedia wikis (tracking) - 10https://bugzilla.wikimedia.org/49188 (10Bryan Davis) [20:43:01] 3MediaWiki extensions / 3CentralAuth: Store rename requests in a central table - 10https://bugzilla.wikimedia.org/68889 (10Bryan Davis) [20:43:02] 3Wikimedia / 3General/Unknown: Create renameuser_queue table in central auth database - 10https://bugzilla.wikimedia.org/69756 (10Bryan Davis) 3NEW p:3Unprio s:3normal a:3None Add SQL table and index definitions for a new `renameuser_queue` table that will be used to store new requests, back a reques... [20:43:36] (03PS3) 10Umherirrender: Correct type of @param of Linker::getRevDeleteLink [core] - 10https://gerrit.wikimedia.org/r/154091 [20:43:41] (03PS1) 10Legoktm: Empty repository, leave stub file explaining why [extensions/WikimediaShopLink] - 10https://gerrit.wikimedia.org/r/155127 [20:43:44] 3Wikimedia / 3General/Unknown: Create renameuser_queue table in central auth database - 10https://bugzilla.wikimedia.org/69756 (10Kunal Mehta (Legoktm)) a:3Sean Pringle [20:44:48] (03Abandoned) 10Hashar: changed meta viewport intial scale to 1 [skins/webplatform] - 10https://gerrit.wikimedia.org/r/57450 (owner: 10Haroldherbert) [20:45:44] 3MediaWiki extensions / 3WikibaseQueryEngine: [HHVM] Tests on Travis are failing (due to HHVM's sqlsite driver) - 10https://bugzilla.wikimedia.org/69526#c4 (10Jeroen De Dauw) I'm geussing this is also an issue for MediaWiki core? Or is core not using PDO for it's SQLSite support? [20:45:57] 3MediaWiki extensions / 3Diff: [HHVM] Tests on Travis are failing (due to PHPUnit version used) - 10https://bugzilla.wikimedia.org/69524#c2 (10Jeroen De Dauw) -- Jeroen De Dauw [20:47:27] 3MediaWiki extensions / 3WikibaseQueryEngine: [HHVM] Tests on Travis are failing (due to HHVM's sqlsite driver) - 10https://bugzilla.wikimedia.org/69526#c5 (10Max Semenik) (In reply to Jeroen De Dauw from comment #4) > I'm geussing this is also an issue for MediaWiki core? Or is core not using > PDO for it's... [20:47:44] 3MediaWiki extensions / 3WikidataRepo: diff with badges links to wrong URL - 10https://bugzilla.wikimedia.org/69758 (10Fomafix) 3NEW p:3Unprio s:3minor a:3Wikidata bugs Created attachment 16238 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16238&action=edit Screenshot of https://www.wikidata... [20:54:29] 3MediaWiki extensions / 3WikidataClient: duplicate interwiki links in the Wikidata sidebar - 10https://bugzilla.wikimedia.org/69759 (10Ricordisamoa) 3NEW p:3Unprio s:3major a:3Wikidata bugs Created attachment 16239 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16239&action=edit https://www.w... [20:55:15] 3Wikimedia / 3Media storage: backend-fail-internal error while deleting files at commons - 10https://bugzilla.wikimedia.org/69760 (10Rainer Rillke @commons.wikimedia) 3NEW p:3Unprio s:3normal a:3None error code: backend-fail-internal error info: An unknown error occurred in storage backend "local-swi... [20:55:57] 3MediaWiki extensions / 3WikidataRepo: diff with badges links to wrong URL - 10https://bugzilla.wikimedia.org/69758 (10Lydia Pintscher) p:5Unprio>3Normal [20:56:11] (03PS1) 10Aude: Update Wikidata, fix for badges css and populateSitesTable script [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/155128 [20:56:12] 3MediaWiki extensions / 3WikidataRepo: diff with badges links to wrong URL - 10https://bugzilla.wikimedia.org/69758 (10Lydia Pintscher) s:5minor>3normal [20:56:47] (03CR) 10Legoktm: [C: 04-1] Create wiki pages & images from files (032 comments) [core] - 10https://gerrit.wikimedia.org/r/154704 (owner: 10Yurik) [20:58:31] (03PS2) 10SG: Improvements to progressiveEnhancement, new features, and unit tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155081 [20:59:06] (03CR) 10Siebrand: [C: 032] Remove wrong type from @param of Language::viewPrevNext [core] - 10https://gerrit.wikimedia.org/r/154286 (owner: 10Umherirrender) [20:59:34] (03CR) 10Physikerwelt: [C: 032] Revert "Added a hook for modifications to MathJax" [extensions/Math] - 10https://gerrit.wikimedia.org/r/155099 (owner: 10Physikerwelt) [21:00:09] (03CR) 10Aude: [C: 032] Update Wikidata, fix for badges css and populateSitesTable script [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/155128 (owner: 10Aude) [21:00:45] (03Merged) 10jenkins-bot: Revert "Added a hook for modifications to MathJax" [extensions/Math] - 10https://gerrit.wikimedia.org/r/155099 (owner: 10Physikerwelt) [21:02:40] (03Merged) 10jenkins-bot: Remove wrong type from @param of Language::viewPrevNext [core] - 10https://gerrit.wikimedia.org/r/154286 (owner: 10Umherirrender) [21:03:14] (03Merged) 10jenkins-bot: Update Wikidata, fix for badges css and populateSitesTable script [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/155128 (owner: 10Aude) [21:04:37] (03CR) 10Physikerwelt: "Thanks for the notice. This hook was used only to call the MathJax.Hub.Config callback to the problem did not occur while testing." [extensions/Math] - 10https://gerrit.wikimedia.org/r/154300 (owner: 10All1) [21:07:46] 3MediaWiki extensions / 3CentralAuth: Store rename requests in a central table - 10https://bugzilla.wikimedia.org/68889#c6 (10Bryan Davis) 5PATC>3RESO/FIX p:5Unprio>3Normal a:3Bryan Davis Table created in beta via: mysql --database=centralauth --host=10.68.16.193 --password --user=mw < patch-req... [21:07:56] (03CR) 10Aaron Schulz: [C: 032] Revision: Allow for userCanBitfield to check per-page restrictions [core] - 10https://gerrit.wikimedia.org/r/154867 (owner: 10Legoktm) [21:10:08] (03CR) 10Bartosz Dziewoński: [C: 032] Empty repository, leave stub file explaining why [extensions/WikimediaShopLink] - 10https://gerrit.wikimedia.org/r/155127 (owner: 10Legoktm) [21:10:13] (03Merged) 10jenkins-bot: Empty repository, leave stub file explaining why [extensions/WikimediaShopLink] - 10https://gerrit.wikimedia.org/r/155127 (owner: 10Legoktm) [21:11:11] (03Merged) 10jenkins-bot: Revision: Allow for userCanBitfield to check per-page restrictions [core] - 10https://gerrit.wikimedia.org/r/154867 (owner: 10Legoktm) [21:12:57] 3MediaWiki-Vagrant: vagrant_ram overrides sometimes ignored/forgotten - 10https://bugzilla.wikimedia.org/69131#c1 (10Matthew Flaschen) Possibly fixed by https://gerrit.wikimedia.org/r/154975 . [21:13:39] (03PS1) 10Legoktm: Empty repository, leave stub file explaining why [extensions/ExpandTemplates] - 10https://gerrit.wikimedia.org/r/155131 [21:13:51] MatmaRex: ^ last one I think [21:14:54] (03CR) 10Physikerwelt: "@All1 thanks for your contribution. For the DRMF project I think it's OK to use the ext.math.mathjax.localization hook. So we don't need a" [extensions/Math] - 10https://gerrit.wikimedia.org/r/154300 (owner: 10All1) [21:14:59] legoktm: typo :( [21:15:14] where? [21:15:25] no space after // :D [21:15:27] oh [21:15:38] I probably did that in the others too then [21:15:52] (03PS2) 10Legoktm: Empty repository, leave stub file explaining why [extensions/ExpandTemplates] - 10https://gerrit.wikimedia.org/r/155131 [21:15:55] fixed [21:16:14] i looked at the others and didn't see that [21:16:17] (03CR) 10Bartosz Dziewoński: [C: 032] Empty repository, leave stub file explaining why [extensions/ExpandTemplates] - 10https://gerrit.wikimedia.org/r/155131 (owner: 10Legoktm) [21:16:25] (03CR) 10Bartosz Dziewoński: [C: 032] Empty repository, leave stub file explaining why [extensions/ExpandTemplates] - 10https://gerrit.wikimedia.org/r/155131 (owner: 10Legoktm) [21:16:29] (03Merged) 10jenkins-bot: Empty repository, leave stub file explaining why [extensions/ExpandTemplates] - 10https://gerrit.wikimedia.org/r/155131 (owner: 10Legoktm) [21:16:42] (03PS1) 10Aaron Schulz: Made showJobs.php show queues with just abandoned jobs too [core] - 10https://gerrit.wikimedia.org/r/155132 [21:16:43] takes +4 to kill it. [21:17:26] (03CR) 1020after4: "I think this is a good approach and I've got a bit to add to this... I will submit a patch to this shortly" [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/154850 (owner: 10Rush) [21:18:21] (03CR) 10Physikerwelt: "You can add a remote git host that you access via SSH, so you don't need to push your changes to gerrit to upload data to the server." [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [21:19:32] (03PS1) 10Legoktm: Empty repository, leave stub file explaining why [extensions/ExpandTemplates] (REL1_23) - 10https://gerrit.wikimedia.org/r/155134 [21:19:53] (03CR) 10Legoktm: [C: 032] Empty repository, leave stub file explaining why [extensions/ExpandTemplates] (REL1_23) - 10https://gerrit.wikimedia.org/r/155134 (owner: 10Legoktm) [21:19:57] (03Merged) 10jenkins-bot: Empty repository, leave stub file explaining why [extensions/ExpandTemplates] (REL1_23) - 10https://gerrit.wikimedia.org/r/155134 (owner: 10Legoktm) [21:24:43] (03PS1) 10Subramanya Sastry: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/155135 [21:25:13] 3Wikimedia / 3Deployment systems: Rename mediawiki/core/vendor to mediawiki/vendor - 10https://bugzilla.wikimedia.org/68485#c16 (10Bryan Davis) 5NEW>3RESO/FIX Updated RFC to reflect new name (03CR) 10Legoktm: [C: 04-1] Refactor Gadget constructor (031 comment) [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154750 (https://bugzilla.wikimedia.org/69368) (owner: 10Legoktm) [21:28:52] (03CR) 10Legoktm: [C: 032] Replace OAI.php symlink with require of entry file [extensions/OAI] - 10https://gerrit.wikimedia.org/r/154272 (owner: 10Addshore) [21:28:58] (03Merged) 10jenkins-bot: Replace OAI.php symlink with require of entry file [extensions/OAI] - 10https://gerrit.wikimedia.org/r/154272 (owner: 10Addshore) [21:29:28] (03CR) 10Legoktm: [C: 031] Add SpecialPageTestBase [core] - 10https://gerrit.wikimedia.org/r/153005 (owner: 10Addshore) [21:33:29] (03PS3) 10Legoktm: Refactor Gadget constructor [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154750 (https://bugzilla.wikimedia.org/69368) [21:34:00] (03CR) 10Legoktm: Refactor Gadget constructor (031 comment) [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154750 (https://bugzilla.wikimedia.org/69368) (owner: 10Legoktm) [21:34:23] (03CR) 10Subramanya Sastry: [C: 04-2] "I am going to work on a patch in parsoid to conditionally suppress empty rows, empty list items, etc. in template content. We can evaluate" [core] - 10https://gerrit.wikimedia.org/r/152775 (owner: 10Subramanya Sastry) [21:35:47] (03PS1) 10Aude: Add messages for Wikinews site links on Wikidata [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/155136 [21:37:44] 3Wikimedia / 3Deployment systems: [scap] Compile HHVM bytecode cache as deployment step - 10https://bugzilla.wikimedia.org/64272 (10Bryan Davis) a:5Bryan Davis>3None [21:37:47] (03PS2) 10Aude: Add messages for Wikinews site links on Wikidata [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/155136 [21:38:15] (03CR) 10Aude: Add messages for Wikinews site links on Wikidata (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/155136 (owner: 10Aude) [21:39:09] legoktm: want to review https://gerrit.wikimedia.org/r/#/c/155136 (since it's not wikibase, i don't like self merge) [21:39:15] or anyone [21:39:18] sure [21:39:28] * aude got the tabs and spaces correct [21:39:35] (03CR) 10Legoktm: [C: 032] Add messages for Wikinews site links on Wikidata [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/155136 (owner: 10Aude) [21:39:41] (03Merged) 10jenkins-bot: Add messages for Wikinews site links on Wikidata [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/155136 (owner: 10Aude) [21:40:20] thanks [21:40:50] (03PS1) 10Aude: Add messages for Wikinews site links on Wikidata [extensions/WikimediaMessages] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/155138 [21:41:05] (03CR) 10Aude: [C: 032] Add messages for Wikinews site links on Wikidata [extensions/WikimediaMessages] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/155138 (owner: 10Aude) [21:41:11] (03Merged) 10jenkins-bot: Add messages for Wikinews site links on Wikidata [extensions/WikimediaMessages] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/155138 (owner: 10Aude) [21:43:29] 3MediaWiki-Vagrant / 3labs-vagrant: labs-vagrant enable browsertests failure - 10https://bugzilla.wikimedia.org/63054#c3 (10Bryan Davis) 5NEW>3UNCO a:5Bryan Davis>3None Needs to be retested. [21:46:39] (03PS1) 10Yurik: Updated to master ZeroBanner [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/155141 [21:47:54] (03PS1) 10Yurik: Updated to master ZeroBanner [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/155142 [21:49:59] (03CR) 10Aude: [C: 032] Updated to master ZeroBanner [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/155141 (owner: 10Yurik) [21:50:01] (03PS1) 10Aude: Update WikimediaMessages with new Wikidata messages [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/155144 [21:50:03] * AaronSchulz sighs at http://stackoverflow.com/questions/8188729/domdocument-xpath-leaking-memory-during-long-command-line-process-any-way-to [21:50:57] 3Wikimedia / 3Deployment systems: Investigate effect of multiple release branches on HHVM's JIT system - 10https://bugzilla.wikimedia.org/67168#c5 (10Bryan Davis) When we get back to the point where we can run multiple HHVM based servers in beta I think it would be interesting to configure one to use repo au... [21:51:40] (03CR) 10Aude: [C: 032] Updated to master ZeroBanner [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/155142 (owner: 10Yurik) [21:52:12] 3Wikimedia / 3Site requests: Changing default image thumbnail size on Swedish Wikipedia - 10https://bugzilla.wikimedia.org/16739#c9 (10James Forrester) (In reply to Plrk from comment #8) > I've asked at the village pump. I'd say it's time to fall back in line with > other wikipedias though. > > https://sv.w... [21:52:57] (03Merged) 10jenkins-bot: Updated to master ZeroBanner [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/155141 (owner: 10Yurik) [21:53:29] (03CR) 10Aude: [C: 032] Update WikimediaMessages with new Wikidata messages [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/155144 (owner: 10Aude) [21:53:43] AaronSchulz: jgonera wants you [21:54:02] he's hitting same vagrant issues as i've been hitting :/ [21:54:25] AaronSchulz, max memory for my redis is 256MB, did you make it higher than that for jdlrobso_ ? [21:54:26] Which one? jobrunner problems? [21:54:31] (03Merged) 10jenkins-bot: Updated to master ZeroBanner [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/155142 (owner: 10Yurik) [21:54:44] memory complaints bd808 [21:54:53] i just got Error: Could not run command from prerun_command: Cannot allocate memory - fork(2) btw [21:54:57] moar ramz! [21:55:07] bd808, hard to say, there doesn't seem to be lot's of CPU utilization but a page I imported from beta labs takes forever to load after a few page refreshes [21:55:14] bd808, and it's not a huge page [21:55:43] We need to do some tuning of the cache setup for mwv I think [21:55:55] stuffing everything in redis seems to be not working well [21:56:01] at least for some workloads [21:56:26] bd808, it just keeps cycling between hhvm, mysql and redis [21:56:44] (03Merged) 10jenkins-bot: Update WikimediaMessages with new Wikidata messages [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/155144 (owner: 10Aude) [21:57:33] jgonera: One thing I changed in my main mwv is moving message cache to acp [21:57:33] $wgMessageCacheType = CACHE_ACCEL; [21:57:47] and $wgLocalisationCacheConf['store'] = 'accel'; [21:58:12] I have a file that does that in my settings.d dir [22:01:32] (03CR) 10Addshore: [C: 032] SpecialGadgets: $wgScript --> wfScript() [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154738 (owner: 10Legoktm) [22:02:32] (03CR) 10Addshore: [C: 032] Gadget: Add typehinting, and don't re-invent some things from core [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154727 (owner: 10Legoktm) [22:02:38] (03Merged) 10jenkins-bot: Gadget: Add typehinting, and don't re-invent some things from core [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154727 (owner: 10Legoktm) [22:03:08] (03PS1) 10Jdlrobson: Regression: Make username link to user page again [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155147 [22:03:23] ^ spagewmf [22:04:00] (03CR) 10Addshore: [C: 032] Add a test for Gadget::__construct [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154751 (owner: 10Legoktm) [22:06:58] (03Abandoned) 10Legoktm: Fix tests after Password API changes [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/150482 (owner: 10Legoktm) [22:08:06] bd808: why not use cdb? [22:08:26] but I don't think that would go in redis anyway [22:08:41] well, not wgLocalisationCacheConf [22:08:57] since there is no bagostuff cache for that [22:09:18] bd808: it would be interesting to inspect redis for non-expiring keys [22:09:24] I thought MaxSem changed the defaults to put everything in redis. It may have been reverted [22:09:28] otherwise, you'd think it would be able to allocate more space [22:09:35] (03CR) 10Legoktm: [C: 04-1] "Looks good otherwise" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/154374 (https://bugzilla.wikimedia.org/67581) (owner: 10Microchip08) [22:09:39] bd808, yup [22:09:47] bd808: wgLocalisationCacheConf is either cdb, db, or eacel [22:09:53] there is no redis option [22:10:02] because LocalisationCache is too borkey for that [22:10:17] I have heard quite a few people complaining about redis running out of space on their vms over the last few weeks [22:10:30] But it hasn't happened to me [22:10:44] but I don't work my wikis very hard [22:10:54] but but but [22:12:19] switch to Mongo that swaps stuff to disk when it runs outta memory?:P [22:14:09] (03CR) 10Legoktm: [C: 04-1] "Need to actually add the option to pass the username." [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) (owner: 10Legoktm) [22:18:13] AaronSchulz, bd808 but the weirdest thing is that I have to refresh the page many times for things to become that slow [22:18:18] the first few loads are ok [22:18:46] That's not weird, that's the sign of a memory leak of some sort [22:19:12] Something is building up in redis or somewhere else [22:19:13] bd808, I know, but I'd say it's weird we have such a memory leak [22:19:25] Is you jobrunner working? [22:19:32] bd808, how do I check? [22:19:48] (03CR) 10EBernhardson: [C: 032] [5] Code cleanup and miscellneous fix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154386 (owner: 10Bsitu) [22:19:49] tail /var/log/mediawiki/jobrunner.log in the vm [22:20:15] (03Merged) 10jenkins-bot: [5] Code cleanup and miscellneous fix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154386 (owner: 10Bsitu) [22:20:17] I think we have logging turned up so you should see regular output there [22:20:36] or `sudo service jobrunner status` to see if it is running at all [22:21:04] (03PS1) 10Vogone: Tiny i18n fix [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/155150 [22:21:54] bd808, yeah, seems to be running, I'll check when I experience slowness again, I just did vagrant reload [22:21:59] legoktm: ^ plz either +2 or abandon [22:22:42] jgonera: If it gets slow again maybe AaronSchulz can give you some tips on figuring out what is stacked up in redis [22:23:05] bd808, yeah, I let you guys know when it happens [22:24:03] (03PS1) 10Bsitu: Add support for adding deferred update within a deferred update [core] - 10https://gerrit.wikimedia.org/r/155151 [22:24:12] (03CR) 10Legoktm: [C: 032] Tiny i18n fix [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/155150 (owner: 10Vogone) [22:24:19] (03CR) 10Romaine: "There are two dates (including time in UTC), before the first date we need a banner saying it hasn't started yet, after the second date a " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153818 (https://bugzilla.wikimedia.org/64685) (owner: 10MarkTraceur) [22:24:25] Vogone: thanks [22:24:29] np [22:24:38] (03Merged) 10jenkins-bot: Tiny i18n fix [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/155150 (owner: 10Vogone) [22:25:15] AaronSchulz, are you in the office? [22:25:35] at home [22:25:38] (03PS2) 10Bsitu: Add support for adding deferred update within a deferred update [core] - 10https://gerrit.wikimedia.org/r/155151 [22:25:53] * AaronSchulz should get "lunch" too [22:25:59] AaronSchulz, it's happening again... any suggestions what I should check? [22:27:03] ok, I'll just keep doing vagrant reload every 5 page reloads because I need to work [22:27:10] let me know when you're around [22:27:34] jgonera: have you tried <> ? [22:27:42] jgonera: Restarting redis would probably be much faster [22:27:50] too late, will try next time [22:27:55] I'm not 100% sure it's redis [22:27:59] I'll try next time [22:28:07] since it has all keys-volatile it should just evict stuff to find the space [22:29:12] (03CR) 10EBernhardson: [C: 032] Delete invalid records from echo_target_page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153372 (owner: 10Bsitu) [22:29:38] (03Merged) 10jenkins-bot: Delete invalid records from echo_target_page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153372 (owner: 10Bsitu) [22:31:40] so either that doesn't work (jemalloc suffering to much fragmentation) or there are big keys with no TTL [22:32:41] (03PS1) 10Bsitu: Defer Flow notification triggering till end of request [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155152 [22:35:00] (03PS1) 10Jdlrobson: QA: Add missing browser test steps [extensions/Echo] - 10https://gerrit.wikimedia.org/r/155153 [22:35:24] (03PS1) 10Robmoen: Update default button color per design consensus [core] - 10https://gerrit.wikimedia.org/r/155154 [22:35:53] (03Abandoned) 10Robmoen: Update default and quiet button color per design consensus [core] - 10https://gerrit.wikimedia.org/r/143577 (owner: 10Robmoen) [22:38:55] (03PS16) 10Legoktm: Global merge tool [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) [22:39:21] (03CR) 10EBernhardson: [C: 031] Add support for adding deferred update within a deferred update (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155151 (owner: 10Bsitu) [22:40:09] (03PS3) 10Bsitu: Add support for adding deferred update within a deferred update [core] - 10https://gerrit.wikimedia.org/r/155151 [22:42:26] (03PS2) 10Robmoen: Update default button color per design consensus [core] - 10https://gerrit.wikimedia.org/r/155154 [22:44:02] 3MediaWiki / 3Export/Import: Special:Import's wiki selector user interface needs improvement - 10https://bugzilla.wikimedia.org/15584 (10This, that and the other (TTO)) 5PATC>3RESO/FIX [22:44:09] (03CR) 10Bsitu: Add support for adding deferred update within a deferred update (031 comment) [core] - 10https://gerrit.wikimedia.org/r/155151 (owner: 10Bsitu) [22:45:21] (03CR) 10Bartosz Dziewoński: "I think it's about not caching error pages in general, not about changing skins. For example see PHPVersionError.php or OutputPage::prepar" [core] - 10https://gerrit.wikimedia.org/r/154129 (https://bugzilla.wikimedia.org/69284) (owner: 10Bartosz Dziewoński) [22:48:56] (03PS4) 10Bsitu: Add support for adding deferred update within a deferred update [core] - 10https://gerrit.wikimedia.org/r/155151 [22:49:33] (03PS1) 10Aude: Fix badges css on Wikidata, update Wikidata [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/155158 [22:52:12] (03PS2) 10Bartosz Dziewoński: Sanitize thumbnails and captions styles [core] - 10https://gerrit.wikimedia.org/r/154802 [22:53:10] thedj: have you ended up looking at https://gerrit.wikimedia.org/r/#/c/154830/ ? [22:53:29] (03CR) 10Aude: [C: 032] Fix badges css on Wikidata, update Wikidata [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/155158 (owner: 10Aude) [22:56:44] (03Merged) 10jenkins-bot: Fix badges css on Wikidata, update Wikidata [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/155158 (owner: 10Aude) [22:56:55] (03CR) 10Legoktm: [C: 031] "Yeah, what Bartosz said :)" [core] - 10https://gerrit.wikimedia.org/r/154129 (https://bugzilla.wikimedia.org/69284) (owner: 10Bartosz Dziewoński) [22:56:57] 3MediaWiki extensions / 3WikibaseQueryEngine: [HHVM] Tests on Travis are failing (due to HHVM's sqlsite driver) - 10https://bugzilla.wikimedia.org/69526#c6 (10Jeroen De Dauw) So core is not using PDO for it's SQLSite support but it uses PDO:Sqlite? Huh? Do we have two things that are named way to similar he... [22:58:57] 3MediaWiki-Vagrant: vagrant_ram overrides sometimes ignored/forgotten - 10https://bugzilla.wikimedia.org/69131 (10Bryan Davis) [22:59:13] 3MediaWiki-Vagrant: Ram and port forwarding broken again - 10https://bugzilla.wikimedia.org/69720 (10Bryan Davis) [23:00:57] 3Wikimedia / 3Bugzilla: Accessing bug 9444 via XML RPC API crashes due to invalid byte sequence: "not well-formed (invalid token)" - 10https://bugzilla.wikimedia.org/69747#c2 (10Andre Klapper) Should drop some stupid chars like via $string =~ tr/\xea-\xef/-/; somewhere before text => $self->type('s... [23:03:12] 3MediaWiki extensions / 3WikibaseQueryEngine: [HHVM] Tests on Travis are failing (due to HHVM's sqlsite driver) - 10https://bugzilla.wikimedia.org/69526#c7 (10Max Semenik) No, it's the same thing: PDO:Sqlite is the name of a particular driver:) [23:03:57] 3MediaWiki-Vagrant: xdebug is broken on vagrant - 10https://bugzilla.wikimedia.org/67719#c6 (10Bryan Davis) 5NEW>3RESO/WON The "fix" for this is to enable the "zend" role. Someday the debugger for HHVM may support the xdebug protocol but that is an upstream issue that we don't have the resources to fix. [23:05:13] 3MediaWiki-Vagrant: Document specific USB stick install instructions for Windows - 10https://bugzilla.wikimedia.org/69208 (10Bryan Davis) [23:07:30] (03CR) 10EBernhardson: "ping" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151273 (owner: 10EBernhardson) [23:09:49] (03PS1) 10EBernhardson: Merge "Delete invalid records from echo_target_page" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/155161 [23:10:48] (03CR) 10Bartosz Dziewoński: [C: 032] Update default button color per design consensus [core] - 10https://gerrit.wikimedia.org/r/155154 (owner: 10Robmoen) [23:11:07] (03Abandoned) 10EBernhardson: Merge "Delete invalid records from echo_target_page" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/155161 (owner: 10EBernhardson) [23:12:34] (03CR) 10Catrope: [C: 032 V: 032] Update MobileFrontend [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/155055 (owner: 10Florianschmidtwelzow) [23:12:37] (03CR) 10Jforrester: [C: 031] Sanitize thumbnails and captions styles [core] - 10https://gerrit.wikimedia.org/r/154802 (owner: 10Bartosz Dziewoński) [23:13:02] (03PS3) 10Jforrester: Generate 'Enlarge' image in CSS rather than HTML (Linker) [core] - 10https://gerrit.wikimedia.org/r/154830 (https://bugzilla.wikimedia.org/69673) (owner: 10Bartosz Dziewoński) [23:14:01] (03Merged) 10jenkins-bot: Update default button color per design consensus [core] - 10https://gerrit.wikimedia.org/r/155154 (owner: 10Robmoen) [23:14:03] (03PS4) 10Bartosz Dziewoński: Generate 'Enlarge' image in CSS rather than HTML (Linker) [core] - 10https://gerrit.wikimedia.org/r/154830 (https://bugzilla.wikimedia.org/69673) [23:14:27] (03CR) 10Jforrester: [C: 04-1] "Should also implement embedding of the image in mediawiki.styling.content.parsoid. Otherwise looks good." [core] - 10https://gerrit.wikimedia.org/r/154830 (https://bugzilla.wikimedia.org/69673) (owner: 10Bartosz Dziewoński) [23:14:51] ewww [23:15:04] can someone explain to me again what mediawiki.styling.content.parsoid is? [23:15:16] (03CR) 10Jdlrobson: [C: 032] Improvements to progressiveEnhancement, new features, and unit tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155081 (owner: 10SG) [23:15:22] it seems to be primarily a pain in the ass [23:15:25] MatmaRex: Styles for Parsoid's output [23:15:41] Mainly for cases where Parsoid's output is different (saner), e.g. images [23:15:57] (03Merged) 10jenkins-bot: Improvements to progressiveEnhancement, new features, and unit tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/155081 (owner: 10SG) [23:16:27] it seems to be a weird mix of basic styles and skin-specific styles [23:16:32] (03PS6) 10EBernhardson: Hygiene: Move notification type detection to method [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151273 [23:16:42] 3MediaWiki extensions / 3WikibaseQueryEngine: [HHVM] Tests on Travis are failing (due to HHVM's sqlsite driver) - 10https://bugzilla.wikimedia.org/69526#c8 (10Jeroen De Dauw) So then this is an issue for core if it where to use HHVM? Clearly it is not when it's using regular PHP. [23:19:31] (03PS6) 10EBernhardson: Hygiene: Move master/slave code to MWEchoDbFactory [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151272 [23:19:34] (03CR) 10Bartosz Dziewoński: "James, I can't do that because Parsoid doesn't provide this link at all." [core] - 10https://gerrit.wikimedia.org/r/154830 (https://bugzilla.wikimedia.org/69673) (owner: 10Bartosz Dziewoński) [23:19:36] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move master/slave code to MWEchoDbFactory [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151272 (owner: 10EBernhardson) [23:22:00] (03CR) 10Bsitu: "We have too many stuff for Echo in this sprint. Since this is not urgent, I'd also like to merge this after the branch cut" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151273 (owner: 10EBernhardson) [23:25:13] (03CR) 10EBernhardson: Add support to retrieve unread + read notifcations for section (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153994 (owner: 10Bsitu) [23:27:12] 3MediaWiki-Vagrant: MediaWiki-Vagrant does not support symbolic links in extensions - 10https://bugzilla.wikimedia.org/64644#c1 (10Bryan Davis) (In reply to Matthew Flaschen from comment #0) > This is because core.symlinks is returning false. However, if I'm reading > 'git help config' right, that's probably... [23:29:34] (03CR) 10Bsitu: [C: 032] Reset per-user notify types for each user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151271 (owner: 10EBernhardson) [23:29:59] (03Merged) 10jenkins-bot: Reset per-user notify types for each user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151271 (owner: 10EBernhardson) [23:37:30] 3Wikimedia / 3DNS: m.wikisource.org seems to broken - 10https://bugzilla.wikimedia.org/69765 (10Florian) 3NEW p:3Unprio s:3normal a:3None The mobile version does not work for me: https://m.wikisource.org/wiki/Main_Page The desktop version of wikisource works well. There is no automatic redirect to t... [23:38:45] 3Wikimedia / 3Site requests: Mobile view fails for two-level domain names like multilingual wikisource (http://wikisource.org) - 10https://bugzilla.wikimedia.org/36002 (10Florian) [23:38:45] 3Wikimedia / 3DNS: m.wikisource.org seems to broken - 10https://bugzilla.wikimedia.org/69765 (10Florian) s:5normal>3major [23:38:45] 3Wikimedia / 3General/Unknown: Wikisource related bugs and enhancements (tracking) - 10https://bugzilla.wikimedia.org/35925 (10Florian) [23:39:12] 3MediaWiki-Vagrant: MediaWiki-Vagrant does not support symbolic links in extensions - 10https://bugzilla.wikimedia.org/64644#c2 (10Bryan Davis) I was fixated on the Parsoid service, not the extension even though Matt linked to the extension code. Back to blaming this on the host filesystem. We can (and should... [23:40:16] (03CR) 10Jforrester: "Make it?" [core] - 10https://gerrit.wikimedia.org/r/154830 (https://bugzilla.wikimedia.org/69673) (owner: 10Bartosz Dziewoński) [23:41:09] (03CR) 10Bartosz Dziewoński: "Eh? I'm not sure why Parsoid developers decided not to provide the link, but I assume it's a conscious decision." [core] - 10https://gerrit.wikimedia.org/r/154830 (https://bugzilla.wikimedia.org/69673) (owner: 10Bartosz Dziewoński) [23:41:37] MatmaRex: I think it was just an oversight. [23:41:43] James_F: compare https://en.wikipedia.org/wiki/Rubber_duck to http://parsoid.wmflabs.org/enwiki/Rubber_duck?oldid=621455956 [23:41:46] the little icon is missing [23:42:41] MatmaRex: I know. :-) [23:42:51] i can't add styles for it if i don't even know what class name / magical identifier of some sort or something it's going to have [23:42:52] (03CR) 10Parent5446: "As mentioned before, the PHP implementation of hash_equals() leaks the length of the known string. If this is fixed and backported in PHP " [core] - 10https://gerrit.wikimedia.org/r/148442 (https://bugzilla.wikimedia.org/28419) (owner: 10Parent5446) [23:42:59] If it's missing, it should be added in a separate commit [23:43:03] There isn't an identifier. [23:43:09] i canb only guess it's not going to be because that would be too easy [23:43:11] legoktm: Sure. [23:43:23] can* div* [23:43:45] MatmaRex: Well, it has to live outside the
but render inside it, right? That sounds messy. [23:44:24] sounds like a float:right; to me [23:44:45] anyway [23:44:53] also sounds not very relevant to my change [23:45:04] * James_F nods. [23:45:09] Hence I didn't re-apply my -1. [23:45:34] :) [23:46:30] Swap code for review? ;-) [23:46:36] (03CR) 10Aaron Schulz: "Where was this mentioned? I couldn't find it here or in the bug linked in the summary. Is there a link for that handy?" [core] - 10https://gerrit.wikimedia.org/r/148442 (https://bugzilla.wikimedia.org/28419) (owner: 10Parent5446) [23:47:05] (03CR) 10Jdlrobson: [C: 032] Sanitize thumbnails and captions styles [core] - 10https://gerrit.wikimedia.org/r/154802 (owner: 10Bartosz Dziewoński) [23:47:35] (03CR) 10Jforrester: [C: 032] "Fine." [core] - 10https://gerrit.wikimedia.org/r/154830 (https://bugzilla.wikimedia.org/69673) (owner: 10Bartosz Dziewoński) [23:47:44] (03PS3) 10Jforrester: Remove WMF deployment hack for 'Enlarge' image [core] - 10https://gerrit.wikimedia.org/r/154831 (https://bugzilla.wikimedia.org/69673) (owner: 10Bartosz Dziewoński) [23:47:52] :o [23:48:59] 3MediaWiki extensions / 3UniversalLanguageSelector: Re-enablement of webfonts for English Wikisource - 10https://bugzilla.wikimedia.org/69655#c2 (10billinghurst) Following conversation with WMF's Internationalization & Localization team, I am altering this request to be more holistic by "Re-enablement of web... [23:49:01] (03PS4) 10Jforrester: [DO NOT MERGE] Remove WMF deployment hack for 'Enlarge' image [core] - 10https://gerrit.wikimedia.org/r/154831 (https://bugzilla.wikimedia.org/69673) (owner: 10Bartosz Dziewoński) [23:49:27] 3MediaWiki-Vagrant: Exception from line 79 of includes/db/CloneDatabase.php: Cannot clone shared table objectcache - 10https://bugzilla.wikimedia.org/68624#c8 (10Bryan Davis) 5NEW>3RESO/FIX The centralauth role no longer creates and configured the shared table. Kunal pointed out that our redis cache elimin... [23:49:42] (03CR) 10Jdlrobson: "JForrester is +2ing code now..? o_O" [core] - 10https://gerrit.wikimedia.org/r/154830 (https://bugzilla.wikimedia.org/69673) (owner: 10Bartosz Dziewoński) [23:50:22] (03Merged) 10jenkins-bot: Sanitize thumbnails and captions styles [core] - 10https://gerrit.wikimedia.org/r/154802 (owner: 10Bartosz Dziewoński) [23:50:36] he +2's a lot of things :P [23:50:40] * James_F grins. [23:51:16] (03CR) 10CSteipp: [C: 031] "I'll let others do any final reviewing, but this looks good to me." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) (owner: 10Legoktm) [23:51:19] now gotta figure out what else is using that image… [23:51:21] (03Merged) 10jenkins-bot: Generate 'Enlarge' image in CSS rather than HTML (Linker) [core] - 10https://gerrit.wikimedia.org/r/154830 (https://bugzilla.wikimedia.org/69673) (owner: 10Bartosz Dziewoński) [23:51:39] (03CR) 10Legoktm: "https://gerrit.wikimedia.org/r/#/q/reviewer:%22Jforrester+%253Cjdforrester%2540gmail.com%253E%22+status:merged,n,z" [core] - 10https://gerrit.wikimedia.org/r/154830 (https://bugzilla.wikimedia.org/69673) (owner: 10Bartosz Dziewoński) [23:51:43] (03CR) 10Jforrester: "Not infrequently. :-)" [core] - 10https://gerrit.wikimedia.org/r/154830 (https://bugzilla.wikimedia.org/69673) (owner: 10Bartosz Dziewoński) [23:51:53] James_F: wanna remove usages from VE, and i can merge that? :> [23:52:03] usage*, rather, seems to be just one small thing [23:52:05] MatmaRex: Eh. [23:53:20] MatmaRex: If it's used in VE that's because it's not supplied by the Parsoid HTML. [23:53:30] MatmaRex: And also needs to be added manually to new image invocations. [23:53:41] MatmaRex: So… not sure how plausible it is to "fix". [23:53:53] yes, that's what happens afaics [23:54:12] 3MediaWiki-Vagrant: Update parsoid puppetization to use prod upstart and deploy repo - 10https://bugzilla.wikimedia.org/60118#c1 (10Bryan Davis) 5NEW>3RESO/FIX Fixed in https://gerrit.wikimedia.org/r/#/c/108079/ (merged 2014-01-17) [23:54:13] James_F: simple, you just remove the inside the
:) [23:55:03] (03PS6) 10Bsitu: Add support to retrieve unread + read notifcations for section [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153994 [23:55:07] MatmaRex: That's a breakage, not a fix. :-) [23:55:14] * James_F makes it MatmaRex's problem. ;-) [23:55:17] 3MediaWiki / 3Skin and page rendering: Stop using inline for thumbnail magnify icon - 10https://bugzilla.wikimedia.org/69673#c8 (10James Forrester) 5PATC>3RESO/FIX a:3Bartosz Dziewoński Deeming this merged now, as this is 'fixed' even without the clean-up from gerrit 154831 landing.