[00:08:14] <wikibugs>	 3Wikimedia / 3Site requests: Enable uploads on eml.wikipedia - 10https://bugzilla.wikimedia.org/69056 (10John F. Lewis) 5NEW>3ASSI a:3John F. Lewis
[00:12:06] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] CSS style for thumbs on special pages [core] - 10https://gerrit.wikimedia.org/r/152283 (https://bugzilla.wikimedia.org/69215) (owner: 10Gerrit Patch Uploader)
[00:13:28] <grrrit-wm>	 (03PS1) 10Legoktm: Add ResourceLoader::getAPIScript() to accompany getLoadScript() [core] - 10https://gerrit.wikimedia.org/r/154715 
[00:13:44] <wikibugs>	 3Wikimedia / 3Site requests: Add two swedish URLs to wgCopyUploadsDomains for Commons - 10https://bugzilla.wikimedia.org/69439 (10John F. Lewis) 5NEW>3ASSI a:3John F. Lewis
[00:13:57] <grrrit-wm>	 (03PS1) 10Yurik: New style zero-role testing [vagrant] - 10https://gerrit.wikimedia.org/r/154716 
[00:15:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: CSS style for thumbs on special pages [core] - 10https://gerrit.wikimedia.org/r/152283 (https://bugzilla.wikimedia.org/69215) (owner: 10Gerrit Patch Uploader)
[00:15:24] <grrrit-wm>	 (03CR) 10Legoktm: "Needed for Gadgets 2.0, which is currently directly reading $wgResourceLoaderSources :(" [core] - 10https://gerrit.wikimedia.org/r/154715 (owner: 10Legoktm)
[00:18:19] <grrrit-wm>	 (03PS1) 10Wctaiwan: Fix whitespace [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154717 
[00:18:31] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 04-1] "This doesn't seem to respect $remote. What will happen when the wikidata role is used and the user has set their gerrit username?" (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/141500 (owner: 10Yurik)
[00:19:18] <yurikR1>	 bd808, lol, that patch is risking to become the ongoing mem of the vagrant world
[00:19:27] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] "\o/" [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154717 (owner: 10Wctaiwan)
[00:19:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix whitespace [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154717 (owner: 10Wctaiwan)
[00:19:57] <bd808>	 It's not an easy problem to solve using puppet.
[00:20:54] <bd808>	 I think there may be a really slick way to do it with a bit more hiera integration
[00:21:39] <grrrit-wm>	 (03PS2) 10Legoktm: Unbreak Special:ExtensionDistributor [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/154430 (https://bugzilla.wikimedia.org/69644) 
[00:22:06] <bd808>	 The hiera approach wouldn't change existing clones, but I think that may actually be a good thing.
[00:24:08] <legoktm>	 anyone want to take a look at https://gerrit.wikimedia.org/r/154430 ? :)
[00:24:18] <legoktm>	 pretty simple
[00:26:21] <bd808>	 yurikR1: I was actually thinking of your patch when I extracted the $::git::urlformat parameter
[00:26:41] <yurikR1>	 need to look up what hiera is 
[00:27:29] <yurikR1>	 not exactly sure how a key->val dict will help here
[00:27:40] <bd808>	 It's a part of puppet3 that lets you separate data (eg parameters) from the puppet manifets
[00:28:02] <yurikR1>	 right, but here we are trying to help user maintain git repos
[00:28:16] <yurikR1>	 and *only* in case if user lets us
[00:29:20] <bd808>	 What you are doing is changing $git::urlformat from 'https://gerrit.wikimedia.org/r/p/%s.git' to 'ssh://....'
[00:29:29] <grrrit-wm>	 (03PS2) 10Yurik: New style zero-role testing [vagrant] - 10https://gerrit.wikimedia.org/r/154716 
[00:29:35] <bd808>	 That can be done in a yaml file with hiera
[00:29:54] <grrrit-wm>	 (03CR) 10Yurik: [C: 032] New style zero-role testing [vagrant] - 10https://gerrit.wikimedia.org/r/154716 (owner: 10Yurik)
[00:29:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: New style zero-role testing [vagrant] - 10https://gerrit.wikimedia.org/r/154716 (owner: 10Yurik)
[00:31:14] <bd808>	 yurikR1: As a semi-related example, labs-vagrant changes some settings from the defaults using hiera -- https://github.com/wikimedia/mediawiki-vagrant/blob/master/puppet/hieradata/environment/labs.yaml
[00:32:07] <bd808>	 And I have a start on a patch that would insert a hiera file that vagrant commands manipulate
[00:33:02] <yurikR1>	 hmm... i see your point. Will the .settings.yaml be driving hiera?
[00:33:40] <grrrit-wm>	 (03CR) 10Vogone: [C: 031] "LGTM" [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/154430 (https://bugzilla.wikimedia.org/69644) (owner: 10Legoktm)
[00:34:16] <bd808>	 It would be a different file than .settings.yaml but a similar idea
[00:34:51] <legoktm>	 ty vo
[00:34:57] <legoktm>	 ty Vogone*
[00:34:57] <legoktm>	 :P
[00:35:42] <bd808>	 yurikR1: puppet/hieradata/vagrant-managed.yaml is the file that I'm proposing in https://gerrit.wikimedia.org/r/#/c/153420/
[00:36:09] <bd808>	 It would replace the existing method of managing enabled roles
[00:36:29] <bd808>	 and could be used for other things like this default origin url as well
[00:36:34] <yurikR1>	 bd808, users don't want to dig deep into puppet files to configure their env though. So .settings.yaml needs to stay and be merged with hiera config somehow
[00:37:18] <yurikR1>	 and btw, i think that current enable-role list is hidden somewhere, whereas it should be part of settings.yaml too
[00:37:19] <bd808>	 `vagrant config` could be extended to interact with the file
[00:38:20] <yurikR1>	 this way you copy your settings.yaml + .settings.d to a new dir, and all your stuff is preserved.  Btw, that also means that we should separate user's settings from role-managed settingns
[00:38:34] <yurikR1>	 this way user knows - this is my dir, i copy it, it has just my own stuff
[00:38:47] <bd808>	 User and role managed settings are separate
[00:39:04] <bd808>	 Roles put files in vagrant.d
[00:39:13] <yurikR1>	 they are in the same dir - settings.d/ also has user settings
[00:39:24] <yurikR1>	 and a sub dir there has role-managed stuff
[00:39:30] <yurikR1>	 inconvinient for copy/pasting purposes
[00:39:42] <wikibugs>	 3Wikimedia / 3Apache configuration: xx.m.wikidata.org should redirect to www.wikidata.org - 10https://bugzilla.wikimedia.org/49262#c3 (10John F. Lewis) 5NEW>3RESO/WON Per the comment I made on the bug mentioned above.
[00:39:49] <bd808>	 Ah you mean LocalSettings.php tweaks
[00:39:55] <yurikR1>	 right
[00:40:02] <bd808>	 I was thinking of the yaml settings still
[00:40:31] <yurikR1>	 IMO it would be best to have settings/ dir for everything user can change
[00:40:44] <yurikR1>	 and settings.managed/  or whatever - for auto-managed stuff
[00:41:01] <yurikR1>	 simple and clear separation
[00:43:27] <bd808>	 If we went that direction I'd suppose that all the puppet created files should live inside the VM
[00:43:41] <bd808>	 That would make the separation very clear
[00:43:56] <yurikR1>	 perhaps... except that inspecting them would be harder i guess
[00:44:00] <bd808>	 yeah
[00:44:12] <bd808>	 it would make debugging more of a pain in some cases
[00:44:15] <yurikR1>	 keeping them semi-separated - in two root directories with clear names make it easy to inspect
[00:44:31] <yurikR1>	 and easy to discover for new users
[00:44:49] <yurikR1>	 btw, can you +2 this tiny patch pls - https://gerrit.wikimedia.org/r/#/c/154298/
[00:45:00] <yurikR1>	 dict update for IDEs
[00:45:25] <yurikR1>	 i would self-+2, but its core, always nice to have a second pair of eyes
[00:45:31] <yurikR1>	 even for this stuff :)
[00:49:26] <yurikR1>	 bd808 ^^
[00:51:00] <grrrit-wm>	 (03PS1) 10Legoktm: Wrap CentralAuthUser::attach in an explicit transaction [extensions/CentralAuth] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/154721 
[00:51:08] <grrrit-wm>	 (03PS1) 10Legoktm: Wrap CentralAuthUser::attach in an explicit transaction [extensions/CentralAuth] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154722 
[00:51:17] <grrrit-wm>	 (03PS1) 10Legoktm: Pass normalized username to GlobalRenameUserStatus [extensions/CentralAuth] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/154723 
[00:51:24] <grrrit-wm>	 (03PS1) 10Legoktm: Pass normalized username to GlobalRenameUserStatus [extensions/CentralAuth] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154724 
[00:57:06] <bd808>	 yurikR1: What's that file for? Spelling?
[00:57:20] <yurikR1>	 bd808, yep
[00:57:21] <yurikR1>	 IDEs
[00:57:31] <yurikR1>	 people use it for IDE dictionary setting
[00:57:39] <yurikR1>	 to warn on bad words in code/comments
[00:57:48] <yurikR1>	 e.g. phpstorm
[00:58:46] <bd808>	 "png'd
[00:58:55] <bd808>	 That's a thing?
[01:01:25] <grrrit-wm>	 (03PS1) 10Legoktm: Make GadgetResourceLoaderModule a simple wrapper around Gadget [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154725 
[01:02:12] <grrrit-wm>	 (03PS1) 10Legoktm: Make ForeignAPI and ForeignDB GadgetRepos use different cache keys [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154726 
[01:02:46] <grrrit-wm>	 (03PS2) 10BryanDavis: Updated dictionary [core] - 10https://gerrit.wikimedia.org/r/154298 (owner: 10Yurik)
[01:03:00] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 032] Updated dictionary [core] - 10https://gerrit.wikimedia.org/r/154298 (owner: 10Yurik)
[01:03:06] <yurikR1>	 bd808, guess so :)
[01:03:22] <yurikR1>	 need to search by code tree to see where i found that thing :)
[01:04:11] <bd808>	 Of all the things I may end up being yelled at for merging that seemed low on the list. :)
[01:04:57] <yurikR1>	 hehe
[01:05:52] <grrrit-wm>	 (03PS1) 10Legoktm: Gadget: Add typehinting, and don't re-invent some things from core [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154727 
[01:05:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Gadget: Add typehinting, and don't re-invent some things from core [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154727 (owner: 10Legoktm)
[01:06:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Updated dictionary [core] - 10https://gerrit.wikimedia.org/r/154298 (owner: 10Yurik)
[01:07:38] <grrrit-wm>	 (03PS2) 10Legoktm: Gadget: Add typehinting, and don't re-invent some things from core [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154727 
[01:13:43] <grrrit-wm>	 (03CR) 10Helder.wiki: Script to clean up manual user global.js/css pages (031 comment) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) (owner: 10Legoktm)
[01:15:27] <grrrit-wm>	 (03CR) 10Helder.wiki: "* Using non capturing groups is a little more efficient (not that it matters much in the present case)." [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) (owner: 10Legoktm)
[01:17:12] <grrrit-wm>	 (03CR) 10Helder.wiki: "Maybe add a test for (s)maxage parameters?" [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) (owner: 10Legoktm)
[01:17:21] * legoktm does
[01:20:45] <grrrit-wm>	 (03PS6) 10Legoktm: Script to clean up manual user global.js/css pages [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) 
[01:21:09] <grrrit-wm>	 (03CR) 10Legoktm: "PS6: Added test for (s)maxage, also strip whitespace-only lines." (031 comment) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) (owner: 10Legoktm)
[01:46:07] <grrrit-wm>	 (03PS1) 10Legoktm: Move isLocal from GadgetRepo to Gadget [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/154729 
[01:46:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Move isLocal from GadgetRepo to Gadget [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/154729 (owner: 10Legoktm)
[01:46:21] <grrrit-wm>	 (03Abandoned) 10Legoktm: Move isLocal from GadgetRepo to Gadget [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/154729 (owner: 10Legoktm)
[01:46:35] <grrrit-wm>	 (03PS1) 10Legoktm: Move isLocal from GadgetRepo to Gadget [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154730 
[01:51:10] <grrrit-wm>	 (03PS1) 10Legoktm: Declare SpecialGadges::$par [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/154731 
[02:10:43] <wikibugs>	 3MediaWiki extensions / 3Gadgets: Allow specifying what pages a gadget should run on in the definition - 10https://bugzilla.wikimedia.org/61007 (10Kunal Mehta (Legoktm))
[21:07:20] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Get rid of isAlwaysWatched [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153789 (owner: 10Matthias Mullie)
[21:07:27] <grrrit-wm1>	 (03PS2) 10Hashar: Ran stylize.php [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/154861 (owner: 10Jack Phoenix)
[21:07:28] <grrrit-wm1>	 (03CR) 10Hashar: [C: 032] "regating (zuul issue)" [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/154861 (owner: 10Jack Phoenix)
[21:07:31] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Move watch star for boards next to the header. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149210 (owner: 10Werdna)
[21:07:36] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Ran stylize.php [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/154861 (owner: 10Jack Phoenix)
[21:07:54] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Bind EnhancedChangesList hook to support Flow types in RC log [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154838 (owner: 10SG)
[21:09:56] <grrrit-wm1>	 (03PS4) 10Bsitu: [3] Use title local cache to cache title object [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154382 
[21:10:52] <grrrit-wm1>	 (03CR) 10Legoktm: [C: 031] Hygiene: Move master/slave code to MWEchoDbFactory [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151272 (owner: 10EBernhardson)
[21:11:14] <grrrit-wm1>	 (03PS3) 10Hashar: Hygiene: Remove unused directory [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154332 (owner: 10Jdlrobson)
[21:11:21] <grrrit-wm1>	 (03PS4) 10Hashar: Hygiene: Remove unused directory [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154332 (owner: 10Jdlrobson)
[21:11:42] <grrrit-wm1>	 (03CR) 10Hashar: [C: 032] "dummy change, regating due to zuul issue" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154332 (owner: 10Jdlrobson)
[21:12:08] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Hygiene: Remove unused directory [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154332 (owner: 10Jdlrobson)
[21:12:57] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: Redirects - Ability to create a redirect over a deleted or empty entity - 10https://bugzilla.wikimedia.org/69166#c2 (10Addshore) Many items can not be undeleted as they will have conflicting descriptions and labels or sitelinks
[21:15:41] <grrrit-wm1>	 (03PS1) 10Jdlrobson: Show username in previews [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154946 (https://bugzilla.wikimedia.org/69257) 
[21:19:51] <grrrit-wm1>	 (03CR) 10Addshore: "Well if this is going to get a -2 using the magic methods this should be changed back to just making ALL of these class members public aga" [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott)
[21:20:51] <grrrit-wm1>	 (03CR) 10Addshore: "Urgh this is probably because the patch was made on a windows machine.." [integration/phpcs] - 10https://gerrit.wikimedia.org/r/154825 (owner: 10Hashar)
[21:21:27] <grrrit-wm1>	 (03PS5) 10Bsitu: [4] Add revision local cache holder object [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154387 
[21:27:33] <grrrit-wm1>	 (03CR) 10Jsahleen: "Are there corresponding unit tests for these changes?" [core] - 10https://gerrit.wikimedia.org/r/78504 (https://bugzilla.wikimedia.org/57106) (owner: 10Liangent)
[21:27:39] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1)
[21:29:12] <wikibugs>	 3Wikimedia / 3General/Unknown: Track down popular gadgets that refer to files in skins/common/ and fix them not to - 10https://bugzilla.wikimedia.org/69678#c5 (10Bartosz Dziewoński) (In reply to Bartosz Dziewoński from comment #1) > First one for warmup: contribsrange.  Done, example edit: https://en.wikiped...
[21:30:05] <grrrit-wm1>	 (03CR) 10Bsitu: "message notification has unreadfirst=true and alert notification has unreadfirst=false. This is mainly because alerts are auto marked as " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153994 (owner: 10Bsitu)
[21:37:58] <grrrit-wm1>	 (03PS5) 10Ebe123: Create sub-statuses for invalid and rejected test-wikis [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/154127 
[21:37:59] <wikibugs>	 3MediaWiki-Vagrant: Ram and port forwarding broken again - 10https://bugzilla.wikimedia.org/69720 (10Nik Everett) 3NEW p:3Unprio s:3normal a:3Ori Livneh Ram and port forwarding broke again for me this afternoon so I decided to do a from scratch setup - clone mediawiki-vagrant and follow the instruction...
[21:40:09] <grrrit-wm1>	 (03PS3) 10Florianschmidtwelzow: Load mediawiki.action.view.redirectToFragment in mobile [core] - 10https://gerrit.wikimedia.org/r/152331 (https://bugzilla.wikimedia.org/69020) 
[21:40:14] <bd808>	 manybubbles: Are the settings that are failing coming from a role or directly in .settings.yaml?
[21:40:30] <manybubbles>	 bd808: role directly
[21:40:46] <manybubbles>	 cirrussearch.pp
[21:41:08] <bd808>	 Ok. I'll check on that. I have been using .settings.yaml changes and can verify that they are working
[21:42:27] <bd808>	 manybubbles: What does `vagrant config --get vagrant_ram` return for you? I'm guessing 1024 instead of the expected 1536
[21:43:24] <^d>	 manybubbles: Do we have es 1.3.1 in apt yet? Can start the upgrade on vagrant + labs if we do.
[21:43:34] <^d>	 *1.3.2
[21:50:01] <grrrit-wm1>	 (03PS2) 10Jdlrobson: Show username in previews [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154946 (https://bugzilla.wikimedia.org/69257) 
[21:51:07] <grrrit-wm1>	 (03PS1) 10Jdlrobson: Use default browser tooltips on block and talk actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154951 (https://bugzilla.wikimedia.org/67643) 
[21:51:47] <MatmaRex>	 ^d: bored? https://gerrit.wikimedia.org/r/#/c/153368/ "Move installer files from skins/common/ to mw-config/"
[21:59:29] <wikibugs>	 3MediaWiki-Vagrant: Ram and port forwarding broken again - 10https://bugzilla.wikimedia.org/69720#c1 (10Bryan Davis) p:5Unprio>3Normal a:5Ori Livneh>3Bryan Davis Nik clarified on irc that the settings he's not seeing take effect are the ones set by the cirrussearch role.
[22:01:13] <grrrit-wm1>	 (03PS1) 10Bsitu: Add waitForSlave() wrapper function to Echo Database wrapper [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154952 
[22:01:27] <^d>	 MatmaRex: I looked, hadn't tested.
[22:01:50] <MatmaRex>	 ^d: it's okay, i had
[22:01:59] <jgonera>	 bd808, https://gerrit.wikimedia.org/r/#/c/149872/ broke a patch I wrote a few months ago
[22:02:05] <MatmaRex>	 :>
[22:02:20] <jgonera>	 bd808, which allows me to view my vagrant instance on another devices over the network
[22:02:38] <jgonera>	 bd808, because it sets wgServer to 127.0.0.1 no matter what
[22:02:47] <bd808>	 jgonera: Ah. Try https://gerrit.wikimedia.org/r/#/c/154941/ ?
[22:03:13] <bd808>	 If that works for you I'd appreciate a +1
[22:03:24] <grrrit-wm1>	 (03PS1) 10Jdlrobson: Reveal contributions link on hover [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154954 (https://bugzilla.wikimedia.org/67646) 
[22:03:47] <bd808>	 jgonera: If it doesn't work I'd love help fixing it so it does work
[22:03:50] <jgonera>	 bd808, checking
[22:04:07] <^d>	 Nope, just 1.2.1
[22:06:30] <grrrit-wm1>	 (03CR) 10Bsitu: Delete invalid records from echo_target_page (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153372 (owner: 10Bsitu)
[22:07:14] <grrrit-wm1>	 (03CR) 10Kunalgrover05: "@Siebrand- It was the initial approach but there were a few extra features that needed to be implemented on this. We can still do that but" [core] - 10https://gerrit.wikimedia.org/r/137033 (owner: 10SPQRobin)
[22:07:42] <grrrit-wm1>	 (03PS1) 10EBernhardson: Override requests for DB_SLAVE when submitting new content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154955 
[22:08:32] <jgonera>	 bd808, how do I regenerate /LocalSettings.php?
[22:08:43] <bd808>	 vagrant provision
[22:09:15] <bd808>	 Or... `git checkout -- LocalSettings.php`
[22:09:19] <jgonera>	 bd808, I did that, maybe where is the erb template for it located?
[22:09:38] <jgonera>	 bd808, because my LocalSettings.php still contains my old fix, but it seems redundant with your patch
[22:10:34] <bd808>	 jgonera: Does git show your LocalSettings.php as dirty? The git checkout command would reset to HEAD
[22:10:49] <jgonera>	 bd808, it's in .gitignore
[22:11:27] <grrrit-wm1>	 (03CR) 10Dduvall: [C: 032] "I've run through a number of upgrades/provisions and this seems solid." [vagrant] - 10https://gerrit.wikimedia.org/r/153420 (https://bugzilla.wikimedia.org/67214) (owner: 10BryanDavis)
[22:11:30] <bd808>	 w000t!!!!!
[22:11:47] <bd808>	 hiera madness is merging
[22:11:52] <marxarel_>	 HIE-RA HIE-RA!
[22:12:04] <grrrit-wm1>	 (03CR) 10SPQRobin: "@Siebrand: this was waiting for review since 7 August. I probably should've made this clear since my last comment said I needed to fix som" [core] - 10https://gerrit.wikimedia.org/r/137033 (owner: 10SPQRobin)
[22:13:49] <bd808>	 jgonera: If `git checkout -- LocalSettings.php` won't work because of gitignore you can refresh with `wget https://raw.githubusercontent.com/wikimedia/mediawiki-vagrant/master/LocalSettings.php` or something similar
[22:14:20] <bd808>	 That LocalSettings.php file should really die in a fire
[22:16:30] <grrrit-wm1>	 (03CR) 10Chad: [C: 032] Set $wgServer from inbound request [vagrant] - 10https://gerrit.wikimedia.org/r/154941 (https://bugzilla.wikimedia.org/66399) (owner: 10BryanDavis)
[22:16:36] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Set $wgServer from inbound request [vagrant] - 10https://gerrit.wikimedia.org/r/154941 (https://bugzilla.wikimedia.org/66399) (owner: 10BryanDavis)
[22:17:23] <grrrit-wm1>	 (03PS2) 10EBernhardson: Override requests for DB_SLAVE when submitting new content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154955 (https://bugzilla.wikimedia.org/68531) 
[22:18:21] <jgonera>	 bd808, ok, I see, it's in .gitignore so that you can edit it but it's still in the repo
[22:18:31] <jgonera>	 bd808, your patch should remove my hack from it then
[22:18:34] <grrrit-wm1>	 (03PS3) 10EBernhardson: Override requests for DB_SLAVE when submitting new content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154955 (https://bugzilla.wikimedia.org/68531) 
[22:18:38] <jgonera>	 I'll make a followup patchset
[22:19:50] <bd808>	 jgonera: My patch is actually to another file that loads later in the init cycle.
[22:20:06] <bd808>	 We have a twisted web of config locations at the moment
[22:20:43] <jgonera>	 bd808, I know, but since my workaround no longer works then it should not be there at all ;)
[22:21:22] <bd808>	 mediawiki/LocalSettings.php -> vagrant/LocalSettings.php -> settings.d/wikis/CommonSettings.php -
[22:21:32] <bd808>	 and then it really gets complicated
[22:25:45] <wikibugs>	 3MediaWiki / 3Skin and page rendering: Use MediaWiki UI for JavaScript-generated checkbox - 10https://bugzilla.wikimedia.org/69722 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None When in $wgUseMediaWikiUIEverywhere is true, the JavaScript generated checkbox (from skins/common/protect.js) that s...
[22:26:38] <grrrit-wm1>	 (03CR) 10Chad: Backend method for Special:PageLanguage, purge on language change (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143049 (owner: 10Kunalgrover05)
[22:27:39] <grrrit-wm1>	 (03CR) 10Mattflaschen: "> On the protection page, there is one checkbox that is not using mw-ui-checkbox. This checkbox is built in skins/common/protect.js. This " [core] - 10https://gerrit.wikimedia.org/r/150635 (owner: 10Jdlrobson)
[22:28:02] <jgonera>	 damn, ori merged it ;)
[22:30:03] <grrrit-wm1>	 (03PS1) 10Mvolz: New export format added to zoteroRequest [services/citoid] - 10https://gerrit.wikimedia.org/r/154958 
[22:30:38] <grrrit-wm1>	 (03PS4) 10Chad: CustomField extension that adds a "MediaWiki Userpage" link on phabricator user profile pages when a phabricator account is linked to mediawiki oauth. [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/144711 (owner: 1020after4)
[22:30:58] <grrrit-wm1>	 (03CR) 10Chad: [C: 032] CustomField extension that adds a "MediaWiki Userpage" link on phabricator user profile pages when a phabricator account is linked to mediaw [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/144711 (owner: 1020after4)
[22:31:08] <grrrit-wm1>	 (03PS1) 10JGonera: Remove old workaround for accessing the instance remotely [vagrant] - 10https://gerrit.wikimedia.org/r/154959 
[22:31:21] <jgonera>	 ori, bd808 ^
[22:33:17] <grrrit-wm1>	 (03CR) 10BryanDavis: [C: 032] Remove old workaround for accessing the instance remotely [vagrant] - 10https://gerrit.wikimedia.org/r/154959 (owner: 10JGonera)
[22:33:22] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Remove old workaround for accessing the instance remotely [vagrant] - 10https://gerrit.wikimedia.org/r/154959 (owner: 10JGonera)
[22:35:57] <grrrit-wm1>	 (03PS8) 10Bsitu: Delete invalid records from echo_target_page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153372 
[22:36:17] <grrrit-wm1>	 (03CR) 10Chad: [V: 032] CustomField extension that adds a "MediaWiki Userpage" link on phabricator user profile pages when a phabricator account is linked to mediaw [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/144711 (owner: 1020after4)
[22:38:30] <grrrit-wm1>	 (03CR) 10Chad: [C: 032] Fix highlighting of results when the search result does not return termMatches [core] - 10https://gerrit.wikimedia.org/r/154840 (owner: 10Gerrit Patch Uploader)
[22:39:29] <wikibugs>	 3MediaWiki / 3Special pages: Special:AllPages and various other pages uses a table based layout which does not render nicely on small screens - 10https://bugzilla.wikimedia.org/63428#c12 (10Jon) 5PATC>3RESO/FIX This should now be fixed in mobile. Help us identify specific issues so we can make this the d...
[22:40:58] <grrrit-wm1>	 (03CR) 10EBernhardson: [C: 032] [1] Make title lazy loaded in EchoEvent [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154380 (owner: 10Bsitu)
[22:41:25] <grrrit-wm1>	 (03Merged) 10jenkins-bot: [1] Make title lazy loaded in EchoEvent [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154380 (owner: 10Bsitu)
[22:41:45] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Fix highlighting of results when the search result does not return termMatches [core] - 10https://gerrit.wikimedia.org/r/154840 (owner: 10Gerrit Patch Uploader)
[22:45:54] <grrrit-wm1>	 (03CR) 10MaxSem: [C: 04-1] "The original change could've lived without a release note, however for already released versions it's different, please add a note." [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/154461 (https://bugzilla.wikimedia.org/64970) (owner: 10Umherirrender)
[22:47:45] <grrrit-wm1>	 (03CR) 10EBernhardson: [C: 031] "imo title class is such a mess it wouldn't be worth trying to put this into core. It may be worth adding as a footnote to RFC's about fix" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154381 (owner: 10Bsitu)
[22:50:08] <grrrit-wm1>	 (03PS1) 10Mvolz: use templatemap from visualeditor data [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/154960 
[22:50:08] <grrrit-wm1>	 (03PS1) 10Mvolz: using transclusion methods now instead of manual insertion [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/154961 
[22:50:08] <grrrit-wm1>	 (03PS1) 10Mvolz: WILL NOT WORK UNTIL DEPENDENCIES ARE RESOLVED [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/154962 
[22:50:10] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] use templatemap from visualeditor data [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/154960 (owner: 10Mvolz)
[22:50:12] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] using transclusion methods now instead of manual insertion [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/154961 (owner: 10Mvolz)
[22:50:14] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] WILL NOT WORK UNTIL DEPENDENCIES ARE RESOLVED [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/154962 (owner: 10Mvolz)
[22:51:15] <wikibugs>	 3MediaWiki / 3Skin and page rendering: Mediawiki.ui: Blue input indicators showing up on mobile & not formatted for it - 10https://bugzilla.wikimedia.org/69724 (10Maryana Pinchuk) 3NEW p:3Unprio s:3normal a:3None Created attachment 16231   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16231&ac...
[22:52:45] <grrrit-wm1>	 (03PS1) 10Bsitu: Make timestamp in consistent format after loaded from database [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154963 
[22:53:33] <thedj>	 who has been most involved with the geo database ?
[22:54:02] <thedj>	 apparently there is an otrs email from Bing engineers who need better data.
[22:55:14] <wikibugs>	 3Wikimedia / 3Mailing lists: Prettify default theme/skin of mailman's listinfo pages - 10https://bugzilla.wikimedia.org/61283#c8 (10John F. Lewis) 5NEW>3ASSI a:3John F. Lewis Spent the past two hours or so working with Thehelpfulone on this. We've got something. Gerrit patch coming shortly. It needs to...
[22:55:35] <thedj>	 MaxSem: you perhaps ?
[22:56:04] <MaxSem>	 wat?
[22:57:08] <thedj>	 Bing engineers looking for coordinate data improvements...
[22:57:21] <MaxSem>	 thedj, can you forward it to msemenik@wm.o ?
[22:59:06] <thedj>	 MaxSem: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Coordinates_issue_in_infoboxes
[22:59:57] <wikibugs>	 3MediaWiki / 3Skin and page rendering: Use MediaWiki UI for JavaScript-generated checkbox - 10https://bugzilla.wikimedia.org/69722#c1 (10Jon) Adding Trevor. Sounds like a perfect opportunity to use OOUI and show how this will play with MediaWiki UI....
[23:01:16] <MaxSem>	 thedj, thanks
[23:03:37] <grrrit-wm1>	 (03CR) 10EBernhardson: [3] Use title local cache to cache title object (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154382 (owner: 10Bsitu)
[23:04:38] <grrrit-wm1>	 (03CR) 10Hashar: "> As you observed there is no sane option in PHP 5.3 to not do this. In fact I took pains to wherever possible (i.e. everywhere except in " [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott)
[23:06:57] <wikibugs>	 3MediaWiki / 3Categories: Sort options for Commons categories - 10https://bugzilla.wikimedia.org/69417#c7 (10Bawolff (Brian Wolff))  >  > Please tell me the best method to make this request then? I can send > pleading emails on mailing lists, or harass developers that I know etc., but > what is the actual of...
[23:11:20] <grrrit-wm1>	 (03CR) 10EBernhardson: [C: 031] [4] Add revision local cache holder object (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154387 (owner: 10Bsitu)
[23:17:31] <grrrit-wm1>	 (03CR) 10Bsitu: "We have new patches that adds tests based on the existing structure. I will just wait till we finish the Echo new feature wave and do anot" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152204 (owner: 10Bsitu)
[23:27:31] <grrrit-wm1>	 (03PS3) 10BearND: Next iteration of styling for PageIssues/Disambiguation. [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/153813 (owner: 10Dbrant)
[23:28:42] <wikibugs>	 3MediaWiki-Vagrant: Ram and port forwarding broken again - 10https://bugzilla.wikimedia.org/69720#c2 (10Bryan Davis) I added a bunch of logging to my mediawiki-vagrant plugin to try and debug this. Unfortunately I can't recreate the problem.  For me, settings in .settings.yaml made with `vagrant configure vagr...
[23:29:36] <grrrit-wm1>	 (03CR) 10Bsitu: [3] Use title local cache to cache title object (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154382 (owner: 10Bsitu)
[23:31:34] <grrrit-wm1>	 (03CR) 10BearND: [C: 032] Next iteration of styling for PageIssues/Disambiguation. [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/153813 (owner: 10Dbrant)
[23:31:47] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Next iteration of styling for PageIssues/Disambiguation. [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/153813 (owner: 10Dbrant)
[23:35:00] <wikibugs>	 3MediaWiki-Vagrant: Ram and port forwarding broken again - 10https://bugzilla.wikimedia.org/69720#c3 (10Bryan Davis) Created attachment 16232   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16232&action=edit Hacky debug logging patch for lib/mediawiki-vagrant/settings.rb  Apply patch and run `./setup.sh...
[23:36:04] <legoktm>	 does anyone have the etherpad link to the first MediaWiki-related session we had during the wikimania hackathon where rating extensions was discussed?
[23:36:40] <legoktm>	 or at least a link to the notes
[23:40:19] <grrrit-wm1>	 (03PS4) 10Bsitu: Add support to retrieve unread + read notifcations for section [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153994 
[23:41:05] <grrrit-wm1>	 (03PS5) 10Bsitu: Add support to retrieve unread + read notifcations for section [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153994 
[23:41:24] <grrrit-wm1>	 (03CR) 10CSteipp: "For security, this doesn't bother me. The math output should be sanitized before tidy is run." [core] - 10https://gerrit.wikimedia.org/r/154083 (https://bugzilla.wikimedia.org/66516) (owner: 10Physikerwelt)
[23:52:27] <wikibugs>	 3MediaWiki-Vagrant: Ram and port forwarding broken again - 10https://bugzilla.wikimedia.org/69720#c4 (10Dan Duvall) Looking at the coercion of vagrant_ram and the order in which settings files are loaded (vagrant.d/*.yaml then .settings.yaml), a setting in the latter will always take precedence.  We can either...
[23:52:59] <wikibugs>	 3MediaWiki-Vagrant: Support newer puppet (3.6.x) - 10https://bugzilla.wikimedia.org/67214#c8 (10Bryan Davis) 5PATC>3NEW (In reply to Mark A. Hershberger from comment #0) >  Warning: The use of 'import' is deprecated at >                /tmp/vagrant-puppet-1/manifests/site.pp:9. >                See http://...
[23:53:09] <grrrit-wm1>	 (03CR) 10Bsitu: [C: 031] "Is there a way to force master only on specific data? For example, when creating a new post, the root patch for this post should read fro" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154955 (https://bugzilla.wikimedia.org/68531) (owner: 10EBernhardson)
[23:54:57] <wikibugs>	 3MediaWiki-Vagrant: Ram and port forwarding broken again - 10https://bugzilla.wikimedia.org/69720#c5 (10Bryan Davis) (In reply to Dan Duvall from comment #4) > 2) change the coercion for vagrant_ram to take the greater of the old  > or new value—currently, it takes the greater of the new and _default_  > value...
[23:55:04] <grrrit-wm1>	 (03PS2) 10MaxSem: Make sure canonical URLs are always in UTF-8 [core] - 10https://gerrit.wikimedia.org/r/151221 (https://bugzilla.wikimedia.org/69026) 
[23:56:42] <wikibugs>	 3MediaWiki-Vagrant: Make it easier to access Vagrant from another VM - 10https://bugzilla.wikimedia.org/66399 (10Bryan Davis) 5PATC>3RESO/FIX
[23:57:58] <wikibugs>	 3MediaWiki-Vagrant: Support newer puppet (3.6.x) - 10https://bugzilla.wikimedia.org/67214#c9 (10Bryan Davis) Mark, I'd appreciate it if you could retest this now and see if we are good to close.