[00:38:58] (03PS1) 10Legoktm: [WIP] Script to clean up manual user global.js/css pages [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) [00:41:05] (03CR) 10MZMcBride: "Before looking, I had guessed that this change was for the WikimediaMaintenance repository. But I suppose this repo works as well." [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) (owner: 10Legoktm) [00:45:27] (03PS2) 10Legoktm: [WIP] Script to clean up manual user global.js/css pages [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) [01:05:12] 3MediaWiki extensions / 3Math: generate MathML (not PNG) and automatically embed hyperlinks for each symbol - 10https://bugzilla.wikimedia.org/69424#c22 (10Richard Baxter) Created attachment 16213 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16213&action=edit AEHprelim-MathMathML.patch (prelimV2) [01:06:12] 3MediaWiki extensions / 3Math: generate MathML (not PNG) and automatically embed hyperlinks for each symbol - 10https://bugzilla.wikimedia.org/69424#c23 (10Richard Baxter) Created attachment 16214 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16214&action=edit AEHprelim-MathLaTeXML.patch (prelimV2) [01:10:43] 3MediaWiki extensions / 3Math: generate MathML (not PNG) and automatically embed hyperlinks for each symbol - 10https://bugzilla.wikimedia.org/69424#c24 (10Richard Baxter) Created attachment 16215 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16215&action=edit MathMathMLautomaticallyEmbedHyperlinks.... [01:12:27] 3MediaWiki extensions / 3Math: generate MathML (not PNG) and automatically embed hyperlinks for each symbol - 10https://bugzilla.wikimedia.org/69424#c25 (10Richard Baxter) Created attachment 16216 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16216&action=edit mathMLsymbolsWikipediaLinks.txt [01:12:32] (03CR) 10Helder.wiki: [WIP] Script to clean up manual user global.js/css pages (032 comments) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) (owner: 10Legoktm) [01:14:24] legoktm: what do you think about matching also pages like this: [01:14:25] https://sv.wikibooks.org/w/index.php?diff=32014 [01:14:46] where there is only one line before the loader call, which is a comment [01:20:07] (03CR) 10Helder.wiki: [WIP] Script to clean up manual user global.js/css pages (031 comment) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) (owner: 10Legoktm) [01:21:59] 3Wikimedia / 3General/Unknown: Schema changes for Wikimedia wikis (tracking) - 10https://bugzilla.wikimedia.org/49188 (10Andrew Green) [01:22:01] 3Wikimedia / 3General/Unknown: Add columns for CentralNotice log comments. - 10https://bugzilla.wikimedia.org/69654 (10Andrew Green) 3NEW p:3Unprio s:3normal a:3None Short description: Add columns for CentralNotice log comments. These columns are only used by wikis configured in the "infrastructure"... [01:34:52] (03CR) 10Wctaiwan: [C: 04-1] "I think the error message needs to be updated." [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/154430 (https://bugzilla.wikimedia.org/69644) (owner: 10Legoktm) [01:35:42] (03CR) 10MF-Warburg: Create sub-statuses for invalid and rejected test-wikis (031 comment) [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/154127 (owner: 10Ebe123) [01:41:06] legoktm: around? [01:42:17] (03PS3) 10Ebe123: Create sub-statuses for invalid and rejected test-wikis [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/154127 [01:42:20] (03CR) 10Ebe123: Create sub-statuses for invalid and rejected test-wikis (031 comment) [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/154127 (owner: 10Ebe123) [01:45:47] never mind... [01:55:04] (03CR) 10Helder.wiki: [WIP] Script to clean up manual user global.js/css pages (034 comments) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) (owner: 10Legoktm) [03:02:29] (03PS34) 10Wctaiwan: [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 [03:07:44] 3Wikimedia / 3Site requests: Allow other domains in $wgCopyUploadsDomains to enable full support of upload_by_url - 10https://bugzilla.wikimedia.org/45735#c4 (10This, that and the other (TTO)) Not really clear what the scope of this bug is. Many other domains are now available for copy upload. It seems super... [03:18:10] (03PS4) 10Hoo man: Don't estimate the revision count for page deletions [core] - 10https://gerrit.wikimedia.org/r/131264 [03:18:40] (03CR) 10Hoo man: [C: 04-1] "Rebased, -1s still apply." [core] - 10https://gerrit.wikimedia.org/r/131264 (owner: 10Hoo man) [03:23:19] (03PS2) 10Withoutaname: Fix calls to DatabaseBase static functions [core] - 10https://gerrit.wikimedia.org/r/148939 [03:47:00] (03PS1) 10Legoktm: Wrap CentralAuthUser::attach in an explicit transaction [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/154443 [03:47:11] hoo: ^ [03:47:32] should the affectedRows be before the commit? [03:47:37] I think it probably should be. [03:48:22] (03PS2) 10Legoktm: Wrap CentralAuthUser::attach in an explicit transaction [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/154443 [03:48:54] Yeah, it should be [03:49:12] commit might alter the internal state of the Database object [03:49:16] although it shouldn't [03:49:33] because commit doesn't (server wise) return how many rows were affected [03:49:54] s/wise/side/ [03:51:13] ok, PS2 calls affectedRows before the commit [03:53:06] ok, should be good [03:53:28] We don't expect errors there, so no try catch needed [03:54:06] (03CR) 10Hoo man: [C: 032] "Let's give this a try, wont cause any regressions, at least." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/154443 (owner: 10Legoktm) [03:54:25] still not convinced it will fix this given the very strange behaviour of stuff [03:54:31] (03Merged) 10jenkins-bot: Wrap CentralAuthUser::attach in an explicit transaction [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/154443 (owner: 10Legoktm) [03:54:33] but that's certainly worth a shot [03:58:57] hmm, this is weird [03:59:10] the user Stephenpkirrane, I can't find the debug log entry of their account creation on commons [04:00:40] oh, maybe it's not in the archive/ yet [04:01:55] found it [04:02:00] hmm [04:02:03] from: /wiki/:Arirang+(USAS).ogg.ko.srt?action=raw&ctype=text/x-srt [04:02:10] but we backported the TMH fixes... [04:02:43] hoo: which user did you see an API request for? [04:03:46] legoktm: Closed the session, sorry [04:03:52] was the last unattached from commons [04:04:31] last if sorted by timestamp, so the latest :P [04:05:29] from: /w/api.php?callback=jQuery11110169248312916366_1408115642705&action=parse&page=TimedText%3AWikipedia_video_tutorial-1-Editing-en.ogv.en.srt&smaxage=3600&maxage=3600&format=json&_=1408115642706 [04:05:47] np [04:05:49] * no [04:05:57] I think it was an action=tokens request [04:06:11] and it had a private CA token in here, so don't just copy and paste :P [04:06:15] * tjere [04:07:07] hm, ok I see a bunch of those [04:07:14] what is asking for a commons edit token from enwp? [04:07:39] ohhhhh [04:07:42] this is mobile [04:07:48] origin=https%3A%2F%2Fen%2Em%2Ewikipedia%2Eorg [04:09:42] yeah, probably mobile [04:09:57] although we (Wikidata) do something similar to WD [04:10:02] so might also happen for us [04:10:58] what does happen if you autocreate while trying to use a centralauthtoken? /me looks [04:11:12] 3Wikimedia / 3Site requests: Switch Media Viewer to opt-in for default in dewp - 10https://bugzilla.wikimedia.org/69292#c8 (10Rich Farmbrough) 5RESO/WON>3RESO/FIX It has always been a community norm that one click to get to attribution is acceptable. In the cases where no attribution is available to the... [04:12:44] uh [04:12:44] mh [04:13:00] it will hit some other code path at some point in CentralAuth hooks [04:13:08] but that shouldn't matter further down the road AFAIR [04:13:14] (I checked that *very* briefly) [04:15:14] it looks like it does some weird cookie magic that I don't really follow [04:15:39] let me just test it on-wiki [04:23:39] (03PS5) 10Hoo man: Don't estimate the revision count for page deletions [core] - 10https://gerrit.wikimedia.org/r/131264 [04:24:07] (03CR) 10Hoo man: Don't estimate the revision count for page deletions (034 comments) [core] - 10https://gerrit.wikimedia.org/r/131264 (owner: 10Hoo man) [04:25:16] well, it seemed to work [04:27:10] (03CR) 10Hoo man: "Played around with this bit and improved it performance wise while still keeping the real edit count on action=delete." [core] - 10https://gerrit.wikimedia.org/r/131264 (owner: 10Hoo man) [04:27:23] mh :S [04:27:39] if it would fail *all* the time, we had much more broken accounts, I guess [04:27:49] so this can only be a very subtle breakage [04:28:01] I'd suggest to backport the commit change thingy on Monday [04:28:20] I mean the change that introduces the transaction around attach [04:31:17] (03PS6) 10Hoo man: Don't estimate the revision count for page deletions [core] - 10https://gerrit.wikimedia.org/r/131264 (https://bugzilla.wikimedia.org/69556) [04:34:11] will do [04:34:20] hoo: also want to review https://gerrit.wikimedia.org/r/#/c/154435/ ? DerHexer ran into it today [04:34:30] looking [04:34:45] ah [04:34:51] that was the thing I wanted to fix [04:35:25] I remembered we had some place where we used un-normalized user names in CA, but I thought it was Special:GlobalGroupMembership [04:35:52] (which was fine in that regard... but featured the crappy wiki select stuff) [04:36:18] (03CR) 10Hoo man: [C: 032] ":)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/154435 (owner: 10Legoktm) [04:36:29] I think there might even be more such things around global rename [04:36:36] but I'm to tired to test them all [04:36:44] (03Merged) 10jenkins-bot: Pass normalized username to GlobalRenameUserStatus [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/154435 (owner: 10Legoktm) [04:36:56] that was the only obvious one to me when I looked at it earlier today [04:37:50] Ok, I see more :P [04:44:35] (03PS1) 10Hoo man: Normalize the user name given to Special:GlobalRenameProgress [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/154444 [04:44:39] legoktm: ^ Your turn now :D [04:44:44] (untested) [04:46:13] * hoo is going to bed now [04:46:13] good night [04:46:58] (03PS3) 10Bsitu: [5] Code cleanup and miscellneous fix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154386 [04:47:53] good night :) [04:59:27] 3Wikimedia / 3Site requests: Switch Media Viewer to opt-in for default in dewp - 10https://bugzilla.wikimedia.org/69292#c9 (10Bawolff (Brian Wolff)) 5RESO/FIX>3RESO/WON > > If someone thinks I should open separate bugs for every project, they need > to find a less obviously irrational objection. Clea... [04:59:42] 3MediaWiki extensions / 3Gadgets: Convert Gadgets 2.0 namespaces to use ContentHandler - 10https://bugzilla.wikimedia.org/69318#c6 (10Kunal Mehta (Legoktm)) 5RESO/FIX>3PATC Not fixed yet, one patch left! [05:00:26] (03PS3) 10Legoktm: [WIP] Use ContentHandler for the Gadget namespace [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153535 (https://bugzilla.wikimedia.org/69318) [05:00:33] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use ContentHandler for the Gadget namespace [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153535 (https://bugzilla.wikimedia.org/69318) (owner: 10Legoktm) [05:09:13] (03PS35) 10Wctaiwan: [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 [05:25:29] 3MediaWiki / 3User preferences: Changes to user preferences should be automatically saved - 10https://bugzilla.wikimedia.org/56561 (10Jared Zimmerman (WMF)) [05:25:47] (03PS1) 1001tonythomas: Do not use VERP on group sending of Emails [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/154446 [05:56:15] ritika_coder_101: slept off yesterday. problem solved ? [06:05:21] tonythomas: Hi! Yes that problem got solved. But I should be able to browse to http://127.0.0.1:8080/ and see the main page of my MediaWiki instance. This is not happening. Even the command hhvmsh is not running after logging into the mediawiki-vagrant environment. [06:07:00] ritika_coder_101: you are able to ssh into your vagrant instance ? $ \vagrant ssh works [06:07:02] ? [06:07:19] $ vagrant ssh ok ? [06:07:40] (03PS1) 10Legoktm: Make it easier to subclass Content and ContentHandler subclasses [core] - 10https://gerrit.wikimedia.org/r/154447 [06:08:34] yes that works [06:09:11] when I typed in mysql, it said, ask your adminstrator to install one of the mentioned packages [06:09:43] (03CR) 10Legoktm: [C: 032] Do not use VERP on group sending of Emails [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/154446 (owner: 1001tonythomas) [06:09:50] How to do that? [06:10:16] (03Merged) 10jenkins-bot: Do not use VERP on group sending of Emails [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/154446 (owner: 1001tonythomas) [06:11:08] ritika_coder_101: I think you should have some roles enabled that can get all these automatically up [06:12:44] ritika_coder_101: how about exiting from the current ssh, and typing $ vagrant enable-role mediawiki [06:13:17] and then $ vagrant provision [06:13:40] yea! This sounds appropriate. lets try this [06:13:46] that should "Provision a MediaWiki instance powered by PHP, MySQL, and redis" as per https://www.mediawiki.org/wiki/MediaWiki-Vagrant/Roles [06:14:00] I need to go. bbl [06:14:17] Okay! thanks :) [06:20:10] (03CR) 10JoelKP: [C: 032] "That did it - it works." [extensions/PhpTagsSMW] - 10https://gerrit.wikimedia.org/r/152930 (owner: 10Pastakhov) [06:20:15] (03Merged) 10jenkins-bot: add object ExtSQI as a wrapper of SemanticQueryInterface extension (v 1.1.0) [extensions/PhpTagsSMW] - 10https://gerrit.wikimedia.org/r/152930 (owner: 10Pastakhov) [06:20:42] 3Wikimedia / 3Extension setup: FlaggedRevs for Norwegian (bokmål) Wikipedia - 10https://bugzilla.wikimedia.org/64726#c23 (10Nemo) (In reply to Erik Moeller from comment #18) > FlaggedRevs adds a lot > of complexity to the editing experience [...] Is this backed up by data? > In your email to me you mention... [06:20:43] 3Wikimedia / 3Site requests: Enabling subpages on FDC wiki - 10https://bugzilla.wikimedia.org/69126#c3 (10matanya) 5PATC>3RESO/FIX merged. Thank you reedy. [06:31:45] 3Wikimedia / 3Site requests: Set $wgUploadNavigationUrl on eo.wikipedia - 10https://bugzilla.wikimedia.org/69055#c1 (10This, that and the other (TTO)) 5NEW>3PATC a:3This, that and the other (TTO) Hmm, Odder seems not to be doing these anymore. A pity, as no-one else seems to have time... Should eowiki... [06:59:33] (03PS1) 10Wctaiwan: Fix MassMessage::getMessengerUser() after Password API changes [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154449 (https://bugzilla.wikimedia.org/68843) [07:01:20] (03CR) 10Legoktm: [C: 032] Fix MassMessage::getMessengerUser() after Password API changes [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154449 (https://bugzilla.wikimedia.org/68843) (owner: 10Wctaiwan) [07:01:31] (03Merged) 10jenkins-bot: Fix MassMessage::getMessengerUser() after Password API changes [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154449 (https://bugzilla.wikimedia.org/68843) (owner: 10Wctaiwan) [07:02:07] (03PS1) 10Wctaiwan: Update token handling for core API change [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154450 [07:02:55] (03CR) 10Legoktm: [C: 032] Update token handling for core API change [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154450 (owner: 10Wctaiwan) [07:03:06] (03Merged) 10jenkins-bot: Update token handling for core API change [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154450 (owner: 10Wctaiwan) [07:04:45] 3Wikimedia / 3Site requests: Run migrateAccount.php without --safe or --auto - 10https://bugzilla.wikimedia.org/69291#c3 (10Kunal Mehta (Legoktm)) Currently generating the list of usernames on terbium... [07:05:12] 3MediaWiki extensions / 3MassMessage: MassMessage::getMessengerUser() takeover broken due to Password API changes - 10https://bugzilla.wikimedia.org/68843 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX [07:43:31] (03PS1) 10Wctaiwan: Subclass JSONContent [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154451 [08:31:42] 3MediaWiki / 3Page editing: (Old) Edit toolbar not displayed on .js and .css pages - 10https://bugzilla.wikimedia.org/29908#c7 (10George Orwell III) (In reply to Bartosz Dziewoński from comment #6) > Resolved? Not resolved? Don't think so. See Bug 69447 for starters. [08:51:04] 3Wikimedia / 3Language setup: Blackletter type font absent since we lost webfonts - 10https://bugzilla.wikimedia.org/69655 (10billinghurst) 3NEW p:3Unprio s:3normal a:3None Hi Runa and team, We talked briefly at WM2014 about since the move from webfonts to the new font presentation scheme, that ther... [08:51:12] 3Wikimedia / 3Language setup: Blackletter type font absent since we lost webfonts - 10https://bugzilla.wikimedia.org/69655 (10billinghurst) [08:51:27] 3Wikimedia / 3General/Unknown: Wikisource related bugs and enhancements (tracking) - 10https://bugzilla.wikimedia.org/35925 (10billinghurst) [09:07:16] 3Wikimedia / 3Site requests: Allow other domains in $wgCopyUploadsDomains to enable full support of upload_by_url - 10https://bugzilla.wikimedia.org/45735#c5 (10Marco) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 58224 *** [09:07:16] 3Wikimedia / 3Site requests: Add domains to $wgCopyUploadsDomains (tracking) - 10https://bugzilla.wikimedia.org/58224#c1 (10Marco) *** Bug 45735 has been marked as a duplicate of this bug. *** [09:09:00] 3Wikimedia / 3Site requests: Allow upload-by-URL from upload.wikimedia.org - 10https://bugzilla.wikimedia.org/42473 (10Marco) [09:09:00] 3Wikimedia / 3Site requests: Allow other domains in $wgCopyUploadsDomains to enable full support of upload_by_url - 10https://bugzilla.wikimedia.org/45735 (10Marco) [09:09:00] 3Wikimedia / 3Site requests: Add domains to $wgCopyUploadsDomains (tracking) - 10https://bugzilla.wikimedia.org/58224 (10Marco) [09:13:13] 3MediaWiki extensions / 3ProofreadPage: ProofreadPage does not use image's full resolution when zooming in - 10https://bugzilla.wikimedia.org/41614#c1 (10dacuetu) I think this was fixed with the Proofread page refactoring, but I am not sure. Can anyone confirm? [09:15:44] (03PS1) 10Umherirrender: Add 'editsitejs' and 'editsitecss' user rights [core] - 10https://gerrit.wikimedia.org/r/154452 [09:20:57] 3Wikimedia / 3Wikidata: add epp_redirect_target column to wb_entity_per_page table - 10https://bugzilla.wikimedia.org/68290#c3 (10Sean Pringle) Online schema change is in progress. [09:28:00] (03PS1) 10Gerrit Patch Uploader: Use
instead of for action menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/154453 (https://bugzilla.wikimedia.org/42241) [09:28:12] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [skins/Vector] - 10https://gerrit.wikimedia.org/r/154453 (https://bugzilla.wikimedia.org/42241) (owner: 10Gerrit Patch Uploader) [09:28:28] (03CR) 10Fomafix: "I resubmitted this patch as https://gerrit.wikimedia.org/r/154453" [core] - 10https://gerrit.wikimedia.org/r/136711 (https://bugzilla.wikimedia.org/42241) (owner: 10Gerrit Patch Uploader) [09:29:13] 3MediaWiki skins / 3Vector: Vector's dropdown menus (Variants, More/Actions) feature weird outlines when focused/clicked in Chrome - 10https://bugzilla.wikimedia.org/66388 (10Fomafix) a:3Fomafix [09:29:27] 3MediaWiki / 3Special pages: Hyphens not parsed correctly for Special:Browse/junk(-3-) - 10https://bugzilla.wikimedia.org/47106#c4 (10Al Johnson) Why did you set it to resolved/worksforme if you think another component is responsible? Please reopen and assign to the SemanticBundle extension if you think SMW... [09:32:29] (03PS5) 10Deepali: Changed property name from publication_year to publication_date [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/124289 (https://bugzilla.wikimedia.org/58079) [09:35:42] (03PS5) 10Deepali: Hide/Show add buttons for sections along with sections list in JSON editor on clicking the sections Hide/Show button. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/132229 [09:36:42] 3MediaWiki extensions / 3SemanticForms: Catchable fatal error: Argument 1 passed to Article::__construct() must be an instance of Title, null given, called in SF_AutoeditAPI.php on line 318 - 10https://bugzilla.wikimedia.org/58022#c13 (10Al Johnson) A misspelled template would not be the only cause since tha... [09:41:38] (03PS12) 10Deepali: Improve UX in chapter dropdown menu for books with lots of chapters [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/136537 (https://bugzilla.wikimedia.org/51257) [09:47:57] 3MediaWiki / 3General/Unknown: Sandbox on en.wp link is always blue - 10https://bugzilla.wikimedia.org/69649#c10 (10Mike Peel) OK, thanks for your patience and replies. I've now posted this at: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Bug_in_.27Sandbox.27_link_colouring Given tha... [10:07:42] 3Wikimedia / 3Language setup: Blackletter type font absent since we lost webfonts - 10https://bugzilla.wikimedia.org/69655 (10Andre Klapper) p:5Unprio>3Normal [10:08:27] 3Wikimedia / 3General/Unknown: Add columns for CentralNotice log comments. - 10https://bugzilla.wikimedia.org/69654 (10Andre Klapper) p:5Unprio>3Normal [10:08:32] (03PS2) 10Gerrit Patch Uploader: Use
instead of for action menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/154453 (https://bugzilla.wikimedia.org/42241) [10:08:34] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [skins/Vector] - 10https://gerrit.wikimedia.org/r/154453 (https://bugzilla.wikimedia.org/42241) (owner: 10Gerrit Patch Uploader) [10:09:05] (03Abandoned) 10Bartosz Dziewoński: Vector: Use
instead of for action menu [core] - 10https://gerrit.wikimedia.org/r/136711 (https://bugzilla.wikimedia.org/42241) (owner: 10Gerrit Patch Uploader) [10:09:44] (03PS4) 10Deepali: Fix a minor bug with initialisation of empty chapterlist. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/140071 [10:11:57] 3MediaWiki / 3Special pages: Hyphens not parsed correctly for Special:Browse/junk(-3-) - 10https://bugzilla.wikimedia.org/47106#c5 (10Andre Klapper) SemanticMediaWiki is not hosted in this Bugzilla instance so if it's an SMW issue it needs to reported in a different place (GitHub, see link above). Semantic... [10:14:12] 3MediaWiki / 3Database: Call to a member function real_escape_string() on a non-object in DatabaseMysqli.php on line 187 - 10https://bugzilla.wikimedia.org/57463 (10Andre Klapper) 5ASSI>3NEW [10:15:42] 3MediaWiki extensions / 3Quiz: Mixing/Shuffling questions disables playing audio files: Error: vid is undefined - 10https://bugzilla.wikimedia.org/61844#c3 (10Andre Klapper) Missing replies on https://www.mediawiki.org/wiki/Extension_talk:Quiz make me wonder if this extension is unmaintained. CC'ing its aut... [10:16:27] 3MediaWiki / 3Skin and page rendering: MediaWiki needs a sane notification system (tracking) - 10https://bugzilla.wikimedia.org/32281#c12 (10Andre Klapper) (In reply to Quim Gil from comment #11) > (In reply to Ryan Kaldari from comment #10) > > if most of these bugs are ever going to be addressed, they will... [10:18:42] 3MediaWiki extensions / 3Math: Detected bug in an extension! Hook ParserAfterParse closure failed to return a value; should return true to continue hook processing or false to abort. - 10https://bugzilla.wikimedia.org/69646#c1 (10Andre Klapper) eisber: Which MediaWiki version is used (note that currently, 1.... [10:25:57] 3MediaWiki / 3History/Diffs: Slow js on history pages - 10https://bugzilla.wikimedia.org/51561#c20 (10Andre Klapper) > OK, I think performance has significantly improved with this change. I'm very tempted to close this as WORKSFORME (though missing a new runtime profile to compare). There's no real criteria... [10:28:27] 3MediaWiki extensions / 3CentralAuth: BadMethodCallException with "Call to a member function getId" in SpecialCentralLogin.php on Beta Labs - 10https://bugzilla.wikimedia.org/69565#c8 (10Andre Klapper) (In reply to Chris Steipp from comment #7) > (In reply to Chris Steipp from comment #6) > > Function: E... [10:31:23] (03PS2) 10Wctaiwan: Subclass JSONContent [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154451 [10:53:14] 3MediaWiki extensions / 3[other]: [PhpTags] exception in updateBytecodeCache() related to database serialization when using ExtSQI - 10https://bugzilla.wikimedia.org/69657 (10Joel K. Pettersson) 3UNCO p:3Unprio s:3normal a:3None After saving, and after purging, a page containing PhpTags SMW ExtSQI qu... [10:59:42] 3Wikimedia / 3Site requests: Tidy up wmf-config CommonSettings.php and InitialiseSettings.php - 10https://bugzilla.wikimedia.org/29902#c20 (10Andre Klapper) All patches mentioned in this report are either merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to... [11:01:57] 3MediaWiki extensions / 3CentralNotice: Can't dismiss banners on mobile due to $.toJSON not being defined - 10https://bugzilla.wikimedia.org/68064#c8 (10Andre Klapper) 5PATC>3RESO/FIX All patches merged - assuming this bug is FIXED. If that is not the case: Please reopen and elaborate what is left to do... [11:04:12] 3MediaWiki / 3Parser: {{#language:code1|code2}} should fail gracefully when Language::isValidCode or stricter is false for code2 - 10https://bugzilla.wikimedia.org/60629#c12 (10Andre Klapper) Backport to 1.23 in https://gerrit.wikimedia.org/r/#/c/145409/ still awaiting review, and Backport_to_stable flag set... [11:05:27] 3Wikimedia / 3Interwiki links: A general interwiki language link to oldwikisource is required - 10https://bugzilla.wikimedia.org/32189#c46 (10Andre Klapper) Status: All patches merged; except for https://gerrit.wikimedia.org/r/#/c/141099/ still awaiting merge. [11:06:14] 3MediaWiki extensions / 3SemanticForms: If a field name contains an ampersand, it then does not pick up the associated property. - 10https://bugzilla.wikimedia.org/43989#c9 (10Andre Klapper) 5PATC>3RESO/FIX No reply to comment 8 - assuming this bug is FIXED. If that is not the case: Please reopen and ela... [11:06:46] 3MediaWiki / 3DjVu: InstantCommons doesn't display DjVu on some installs - 10https://bugzilla.wikimedia.org/37764#c14 (10Andre Klapper) 5PATC>3RESO/FIX No reply to comment 13 - assuming this bug is FIXED. If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed. [11:09:27] 3Wikimedia / 3Site requests: Tidy up wmf-config CommonSettings.php and InitialiseSettings.php - 10https://bugzilla.wikimedia.org/29902#c21 (10This, that and the other (TTO)) 5PATC>3NEW There's still work to do, e.g. wgMetaNamespace(Talk)? and wgNamespacesWithSubpages, and minor indent cleanup as well. Re... [11:19:57] 3MediaWiki / 3History/Diffs: diff should provide anchors to start or related paragraphs - 10https://bugzilla.wikimedia.org/2313#c10 (10Arnold Reinhold) I reported 63707 as a feature request. I think it had a clearer explanation of the need. Here is what I wrote: "In diff displays, it is sometimes hard to fi... [11:20:44] 3MediaWiki extensions / 3CentralAuth: [Regression] CentralAuth: Fix "User::addToDatabase: hit a key conflict" - 10https://bugzilla.wikimedia.org/66185#c6 (10Andre Klapper) 5PATC>3RESO/FIX All patches mentioned in this report were merged - assuming this bug is FIXED. If that is not the case: Please reopen... [11:23:27] 3MediaWiki extensions / 3Popups: Hovercards: disable NavigationPopups (Gadget) if Hovercards Beta Feature is enabled - 10https://bugzilla.wikimedia.org/62952#c6 (10Andre Klapper) Status here: https://gerrit.wikimedia.org/r/#/c/141668/ still awaiting review [11:23:43] 3MediaWiki extensions / 3Popups: Hovercards: Fix the bracket removal code - 10https://bugzilla.wikimedia.org/65138#c8 (10Andre Klapper) All patches mentioned in this report were merged - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this... [11:25:27] 3MediaWiki / 3User login and signup: Deadlock on user account creation leaves account in bad state - 10https://bugzilla.wikimedia.org/36116#c5 (10Andre Klapper) Patches by Aaron mentioned in this report was merged - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSI... [11:26:12] 3MediaWiki-Vagrant: mediawiki-vagrant reports an error when provisioning "browsertests" role - 10https://bugzilla.wikimedia.org/61285#c11 (10Andre Klapper) 5PATC>3NEW [No patches left here - resetting bug report status] [11:26:57] 3MediaWiki / 3Maintenance scripts: [Regression] deleteArchivedFiles.php broken - 10https://bugzilla.wikimedia.org/40362#c15 (10Andre Klapper) Patch by Aaron mentioned in this report was merged - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you clo... [11:27:27] 3MediaWiki / 3Skin and page rendering: Tab index sorting doesn't make sense - 10https://bugzilla.wikimedia.org/29199#c38 (10Andre Klapper) 5PATC>3NEW [No patches left here - resetting bug report status] [11:27:42] 3MediaWiki / 3Logging: trigger_error in wfWarn prevents to disclose database error in unit tests - 10https://bugzilla.wikimedia.org/58095#c8 (10Andre Klapper) All patches mentioned in this report are either merged or abandoned - is there more work left to do here (if yes: please reset the bug report status t... [11:29:14] 3MediaWiki extensions / 3LiquidThreads: LiquidThreads: Fix "PHP Notice: Undefined variable: _SESSION in View.php on line 415" - 10https://bugzilla.wikimedia.org/28826#c11 (10Andre Klapper) 5PATC>3RESO/FIX Patch mentioned in this report was merged - assuming this bug is FIXED. If that is not the case: Pl... [11:29:14] 3MediaWiki / 3Parser: Add SelfLinkBegin hook in Linker.php - 10https://bugzilla.wikimedia.org/63592#c6 (10Andre Klapper) 5PATC>3RESO/FIX Patch mentioned in this report was merged - assuming this bug is FIXED. If that is not the case: Please reopen and elaborate what is left to do here to get this report... [11:30:12] 3MediaWiki / 3Skin and page rendering: image style from typography refresh was not implemented - 10https://bugzilla.wikimedia.org/65160#c14 (10Andre Klapper) Status: Patch in https://gerrit.wikimedia.org/r/#/c/133301/ has two -1. [11:30:43] 3MediaWiki extensions / 3UniversalLanguageSelector: Cascade order of fallback CSS properties is wrong - 10https://bugzilla.wikimedia.org/56138#c8 (10Andre Klapper) 5PATC>3RESO/FIX No reply to comment 6 and comment 7 - assuming this bug is FIXED. If that is not the case: Please reopen and elaborate what i... [11:33:14] 3Wikimedia / 3Site requests: Refining typeahead search results for subpages at English Wikisource - 10https://bugzilla.wikimedia.org/69658 (10billinghurst) 3NEW p:3Unprio s:3normal a:3None In a discussion with Nik at WM2014 we talked about an item of CirrusSearch refinement that would be useful for E... [11:33:43] 3Wikimedia / 3Site requests: Refining typeahead search results for subpages at English Wikisource - 10https://bugzilla.wikimedia.org/69658 (10billinghurst) [11:33:44] 3Wikimedia / 3General/Unknown: Wikisource related bugs and enhancements (tracking) - 10https://bugzilla.wikimedia.org/35925 (10billinghurst) [11:33:58] 3MediaWiki extensions / 3ProofreadPage: ProofreadPage does not use image's full resolution when zooming in - 10https://bugzilla.wikimedia.org/41614#c2 (10Tpt) No, it wasn't fixed. [11:36:13] 3MediaWiki / 3Language converter: Do title conversion on &action=edit if &redlink=1 exists - 10https://bugzilla.wikimedia.org/33231#c3 (10Andre Klapper) 5PATC>3RESO/FIX Patch mentioned in this report was merged - assuming this bug is FIXED. If that is not the case: Please reopen and elaborate what is lef... [11:37:27] 3MediaWiki / 3Revision deletion: diffs between revisions which are both deleted & suppressed - 10https://bugzilla.wikimedia.org/20288 (10Andre Klapper) [11:37:57] 3MediaWiki / 3Parser: Anchors to first sentence in lead paragraph of articles - 10https://bugzilla.wikimedia.org/35363#c7 (10Andre Klapper) drfree: Could you provide examples of pages where the basic rule of "Right under the title" is not accomplished? URLs welcome. [11:38:30] 3Wikimedia / 3Blog: Some images are missing - 10https://bugzilla.wikimedia.org/69659 (10Seb35) 3NEW p:3Unprio s:3normal a:3None Some images are missing on the (new) Wikimedia blog. Some could be recovered (e.g. the magnify icon on [1]), possibly some are more difficult to recover (e.g. the main image... [11:38:31] 3MediaWiki / 3Special pages: Special:Unwatchedpages only shows 5,000 articles in es.wiki - 10https://bugzilla.wikimedia.org/69660 (10David Abián) 3UNCO p:3Unprio s:3major a:3None Created attachment 16217 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16217&action=edit Screenshot of the bottom... [11:38:44] 3MediaWiki / 3General/Unknown: AutoLoader adds $IP to network share path - 10https://bugzilla.wikimedia.org/44953 (10Andre Klapper) [11:38:44] 3MediaWiki extensions / 3ProofreadPage: navigation links behaving badly on cross-source links - 10https://bugzilla.wikimedia.org/60067 (10Andre Klapper) [11:41:12] 3MediaWiki extensions / 3SemanticForms: Gallery: Call to a member function getPrefixedDBkey() on a non-object in /var/www/w/includes/cache/LinkCache.php - 10https://bugzilla.wikimedia.org/51543 (10Andre Klapper) [11:42:12] 3MediaWiki extensions / 3PostEdit: FOUC of "Your edit has been saved" message - 10https://bugzilla.wikimedia.org/64823 (10Andre Klapper) [11:42:27] 3Wikimedia / 3SSL related: wmgHTTPSBlacklistCountries changes for CN - 10https://bugzilla.wikimedia.org/53739 (10Andre Klapper) [11:44:44] 3MediaWiki extensions / 3CreditsSource: Missing/broken parameters in creditssource-source-work msg in German and Italian Wikivoyage Wikis. - 10https://bugzilla.wikimedia.org/42859 (10Andre Klapper) [11:44:44] 3MediaWiki / 3User blocking: Unable to block large IPv4 /8 ranges - 10https://bugzilla.wikimedia.org/42303 (10Andre Klapper) [11:45:43] 3MediaWiki / 3Page protection: 'Protect' user right does not allow a user to protect pages up to their editing level - 10https://bugzilla.wikimedia.org/36489#c4 (10Andre Klapper) 5UNCO>3RESO/WOR Unfortunately closing this report as no further information has been provided. Hersfold: Please feel free to... [11:47:43] 3Wikimedia / 3Interwiki links: A general interwiki language link to oldwikisource is required - 10https://bugzilla.wikimedia.org/32189#c47 (10billinghurst) Because I am good at dumb questions, I have one to ask. The mul: interwiki link doesn't work, and it doesn't show in the interwiki map. So if that is i... [11:47:58] 3MediaWiki / 3General/Unknown: Main WebRequest object an instance of FauxRequest - 10https://bugzilla.wikimedia.org/61273#c8 (10Andre Klapper) 5UNCO>3RESO/WOR Unfortunately closing this report as no further information has been provided. jimmy: Please feel free to reopen this report if you can provide t... [11:48:42] 3MediaWiki / 3General/Unknown: System hangs when installed without extensions on 1.22RC2 - 10https://bugzilla.wikimedia.org/57671#c6 (10Andre Klapper) 5UNCO>3RESO/WOR Unfortunately closing this report as no further information has been provided. MarkJurgens: Please feel free to reopen this report if you... [11:49:42] 3MediaWiki / 3Maintenance scripts: importdump.php stops with no error - 10https://bugzilla.wikimedia.org/13687#c5 (10Andre Klapper) 5UNCO>3RESO/WOR Unfortunately closing this report as no further information has been provided. Weiran: Please feel free to reopen this report if you can provide the informa... [11:49:57] 3MediaWiki / 3Search: Request topic title substring search - 10https://bugzilla.wikimedia.org/12577#c2 (10Andre Klapper) Martin: Could you please answer comment 1? [11:50:27] 3MediaWiki / 3Parser: Different rendering of a list related to transclude when preview/old rev/rendering a page - 10https://bugzilla.wikimedia.org/13787#c2 (10Andre Klapper) Michael: Could you answer comment 1, please? [11:51:13] (03PS1) 10Gerrit Patch Uploader: mediawiki.page.watch.ajax depends on mediawiki.page.startup [core] - 10https://gerrit.wikimedia.org/r/154456 [11:51:15] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/154456 (owner: 10Gerrit Patch Uploader) [11:52:27] 3Wikimedia / 3Blog: Some images are missing - 10https://bugzilla.wikimedia.org/69659 (10Andre Klapper) p:5Unprio>3Normal [12:00:42] 3Wikimedia / 3Interwiki links: A general interwiki language link to oldwikisource is required - 10https://bugzilla.wikimedia.org/32189#c48 (10This, that and the other (TTO)) (In reply to billinghurst from comment #47) > If it is in the unmerged component, who should I nag to get this review > undertaken? Tha... [12:10:44] 3Wikimedia / 3Bugzilla: Update Parsoid component descriptions in Bugzilla - 10https://bugzilla.wikimedia.org/69631#c1 (10James Forrester) 5NEW>3RESO/FIX a:3James Forrester I've fiddled with the descriptions a little, but frankly no-one outside the Parsoid team is expected to know which component is "ri... [12:19:19] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.page.watch.ajax depends on mediawiki.page.startup [core] - 10https://gerrit.wikimedia.org/r/154456 (owner: 10Gerrit Patch Uploader) [12:22:43] (03Merged) 10jenkins-bot: mediawiki.page.watch.ajax depends on mediawiki.page.startup [core] - 10https://gerrit.wikimedia.org/r/154456 (owner: 10Gerrit Patch Uploader) [12:40:57] 3MediaWiki extensions / 3[other]: [PhpTags] exception in updateBytecodeCache() related to database serialization when using ExtSQI - 10https://bugzilla.wikimedia.org/69657#c1 (10Pavel (pastakhov)) 5UNCO>3ASSI Any objects should never be cached, it is third point. It is the bug and I'll fix it. Bytecode n... [12:43:27] 3MediaWiki extensions / 3[other]: [PhpTagsFunctions] Notice: Use of undefined constant CRYPT_SHA512 - assumed 'CRYPT_SHA512' in PhpTagsFunctions.init.php on line 56 - 10https://bugzilla.wikimedia.org/69002 (10Pavel (pastakhov)) 5PATC>3RESO/FIX [12:46:13] 3MediaWiki extensions / 3[other]: [PhpTags] exception in updateBytecodeCache() related to database serialization when using ExtSQI - 10https://bugzilla.wikimedia.org/69657 (10Pavel (pastakhov)) a:3Pavel (pastakhov) [12:51:07] 3Utilities / 3WM-Bot: Encoding issues on wm-bot logs - 10https://bugzilla.wikimedia.org/69662 (10David Abián) 3UNCO p:3Unprio s:3normal a:3Peter Bena Special characters on public logs are not properly displayed (see the example). [12:52:13] 3MediaWiki extensions / 3[other]: [PhpTagsFunctions] Fatal error: Unexpected object type stdClass. in PhpTagsFunc.php on line 20 - 10https://bugzilla.wikimedia.org/69014 (10Pavel (pastakhov)) a:3Pavel (pastakhov) [12:52:27] 3MediaWiki / 3Page editing: (Old) Edit toolbar not displayed on .js and .css pages - 10https://bugzilla.wikimedia.org/29908 (10Helder) [12:52:30] 3MediaWiki / 3Skin and page rendering: Edit toolbar & Edit tools (tracking) - 10https://bugzilla.wikimedia.org/17653 (10Helder) [12:52:31] 3MediaWiki extensions / 3ProofreadPage: Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar - 10https://bugzilla.wikimedia.org/69447 (10Helder) [12:52:42] 3MediaWiki extensions / 3ProofreadPage: Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar - 10https://bugzilla.wikimedia.org/69447 (10Helder) [13:07:12] (03CR) 10Pastakhov: "Here class_exists() behaves correctly as \\SQI\\SemanticQueryInterface is not already loaded, it only added to the autoload array." [extensions/PhpTagsSMW] - 10https://gerrit.wikimedia.org/r/152930 (owner: 10Pastakhov) [13:09:40] (03PS4) 10Gerrit Patch Uploader: mediawiki.util: Deprecate mw.util.updateTooltipAccessKeys [core] - 10https://gerrit.wikimedia.org/r/148264 [13:09:42] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/148264 (owner: 10Gerrit Patch Uploader) [13:23:44] (03PS1) 10Gerrit Patch Uploader: Add dependencies to module mediawiki.util [core] - 10https://gerrit.wikimedia.org/r/154459 [13:23:46] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/154459 (owner: 10Gerrit Patch Uploader) [13:24:06] (03CR) 10TheDJ: [C: 031] Remove success box on changing any preference or switching tab [core] - 10https://gerrit.wikimedia.org/r/107837 (https://bugzilla.wikimedia.org/17496) (owner: 10Gerrit Patch Uploader) [13:27:51] (03PS1) 10Umherirrender: Check for boolean false result from database query in SqlBagOStuff [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/154460 [13:28:48] (03CR) 10Umherirrender: "Cherry-Picked: I0862493305e5b2784422e0e94b3e62e734267795" [core] - 10https://gerrit.wikimedia.org/r/141619 (owner: 10Ori.livneh) [13:29:27] 3MediaWiki / 3Unit tests: PHP unit tests don't work if not run from tests/phpunit directory - "Call to a member function numRows() on a non-object" - 10https://bugzilla.wikimedia.org/56909#c9 (10Umherirrender) Cherry-Picked to REL1_23: gerrit 154460 [13:29:37] (03PS2) 10Umherirrender: Check for boolean false result from database query in SqlBagOStuff [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/154460 [13:30:31] (03CR) 10Helder.wiki: "If we are going to add a dependency on mw.util, might as well use its rawurlencode for Uri.encode, instead of duplicating the code:" [core] - 10https://gerrit.wikimedia.org/r/154459 (owner: 10Gerrit Patch Uploader) [13:34:44] (03PS1) 10Umherirrender: Fetch string to pass through writeTemporary() in DatabaseOracle.php [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/154461 (https://bugzilla.wikimedia.org/64970) [13:36:28] (03CR) 10Ori.livneh: [C: 032] "Thanks" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/154460 (owner: 10Umherirrender) [13:37:27] aude: https://test.wikipedia.org/wiki/Special:Version appears to be working now, nice [13:39:26] hhvm :> [13:39:44] (03Merged) 10jenkins-bot: Check for boolean false result from database query in SqlBagOStuff [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/154460 (owner: 10Umherirrender) [13:42:59] 3MediaWiki / 3Unit tests: PHP unit tests don't work if not run from tests/phpunit directory - "Call to a member function numRows() on a non-object" - 10https://bugzilla.wikimedia.org/56909#c10 (10Umherirrender) successfully backported to 1.23 [13:43:01] (03PS2) 10Umherirrender: Fetch string to pass through writeTemporary() in DatabaseOracle.php [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/154461 (https://bugzilla.wikimedia.org/64970) [13:46:44] (03CR) 10Fomafix: "Is for this change a parallel definition with old and new CSS and JavaScript necessary to prevent cache problems?" [skins/Vector] - 10https://gerrit.wikimedia.org/r/154453 (https://bugzilla.wikimedia.org/42241) (owner: 10Gerrit Patch Uploader) [13:54:41] (03PS1) 10Umherirrender: Remove fallback 'de' gender namespaces [core] - 10https://gerrit.wikimedia.org/r/154462 [13:58:12] 3MediaWiki / 3Special pages: Special:Unwatchedpages only shows 5,000 articles in es.wiki - 10https://bugzilla.wikimedia.org/69660#c1 (10Umherirrender) "A maximum of 5,000 results are available in the cache." should be written in the header of the special page to explain this situation. [14:10:58] 3MediaWiki extensions / 3Gadgets: Gadget usage statistics - 10https://bugzilla.wikimedia.org/19288 (10Yusuke Matsubara) [14:14:45] 3MediaWiki / 3Database: errors using Oracle DB with oci8 - 10https://bugzilla.wikimedia.org/64970 (10Umherirrender) 5PATC>3RESO/FIX [14:18:12] 3MediaWiki / 3Special pages: Special:Unwatchedpages only shows 5,000 articles in es.wiki - 10https://bugzilla.wikimedia.org/69660#c2 (10David Abián) Right, thanks, I have deleted [[:w:es:MediaWiki:Perfcachedts]]. Anyway, would it be actually impossible to list all unwatched articles? With only 5,000, the pa... [14:36:32] (03PS4) 10Vogone: Create sub-statuses for invalid and rejected test-wikis [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/154127 (owner: 10Ebe123) [14:45:30] (03CR) 10Bartosz Dziewoński: "Yes. Page HTML is cached for up to 30 days on Wikimedia wikis, while the JS and CSS resources update almost immediately after deployment." [skins/Vector] - 10https://gerrit.wikimedia.org/r/154453 (https://bugzilla.wikimedia.org/42241) (owner: 10Gerrit Patch Uploader) [14:46:23] (03CR) 10Bartosz Dziewoński: "This looks good to me apart from that, I'm going to test and play with it a bit. Hoo, DJ, can you verify that accessibility is okay?" [skins/Vector] - 10https://gerrit.wikimedia.org/r/154453 (https://bugzilla.wikimedia.org/42241) (owner: 10Gerrit Patch Uploader) [15:05:28] 3MediaWiki / 3JavaScript: Provide JavaScript login widget - 10https://bugzilla.wikimedia.org/69596#c2 (10Rainer Rillke @commons.wikimedia) (In reply to Michael M. from comment #1) naak naak naak, again such a security nonsense; the same as in Bug 48931 -- either we trust user scripts and this is what we curr... [15:05:58] (03CR) 10Bartosz Dziewoński: "Hmm, I wonder if we could/should get rid of the (or
) entirely? I don't know what it was for, initially, but it seems that we sho" [skins/Vector] - 10https://gerrit.wikimedia.org/r/154453 (https://bugzilla.wikimedia.org/42241) (owner: 10Gerrit Patch Uploader) [15:20:25] (03CR) 10Bartosz Dziewoński: [C: 032] Remove success box on changing any preference or switching tab [core] - 10https://gerrit.wikimedia.org/r/107837 (https://bugzilla.wikimedia.org/17496) (owner: 10Gerrit Patch Uploader) [15:25:34] (03CR) 10jenkins-bot: [V: 04-1] Remove success box on changing any preference or switching tab [core] - 10https://gerrit.wikimedia.org/r/107837 (https://bugzilla.wikimedia.org/17496) (owner: 10Gerrit Patch Uploader) [15:28:35] (03CR) 10Rillke: [C: 031] "Indeed. Browsers probably know best what/how to present buttons. Still a problem under Win7." [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/154335 (https://bugzilla.wikimedia.org/35323) (owner: 10Bartosz Dziewoński) [15:31:57] 3Utilities / 3WM-Bot: Character encoding issues on wm-bot logs - 10https://bugzilla.wikimedia.org/69662#c1 (10Andre Klapper) 5UNCO>3NEW Workaround: Switch character encoding in your Firefox browser to "Western". [15:36:59] 3MediaWiki / 3Special pages: Special:Unwatchedpages only shows 5,000 articles in es.wiki - 10https://bugzilla.wikimedia.org/69660#c3 (10Andre Klapper) 5UNCO>3NEW p:5Unprio>3Low I guess this has to do with performance... Also see bug 12272 for one potential approach to fix this problem. [15:36:59] 3MediaWiki / 3Special pages: Allow "from" url parameter on Special pages that list articles/pages - 10https://bugzilla.wikimedia.org/12272 (10Andre Klapper) [15:37:12] 3MediaWiki / 3Database: errors using Oracle DB with oci8 - 10https://bugzilla.wikimedia.org/64970 (10Andre Klapper) [15:54:41] (03PS1) 10Jack Phoenix: Add white theme. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/154471 [16:00:15] 3MediaWiki-Vagrant: I get error message "No MWMultiVersion instance initialized!" when run phpunit tests - 10https://bugzilla.wikimedia.org/69520#c1 (10Bryan Davis) p:5Unprio>3High a:5Ori Livneh>3Bryan Davis I broke this with the changes I introduced in I26b3705 ("Rethink multiwiki support"). Using `mw... [16:01:52] (03CR) 10Fomafix: "This seams to be possible." [skins/Vector] - 10https://gerrit.wikimedia.org/r/154453 (https://bugzilla.wikimedia.org/42241) (owner: 10Gerrit Patch Uploader) [16:13:27] 3MediaWiki / 3Categories: Sort options for Commons categories - 10https://bugzilla.wikimedia.org/69417#c6 (10Liam Wyatt) (In reply to Andre Klapper from comment #3) > Yes I meant the latter, to clarify how things look now and to make sure that > the same thing is discussed. Examples are always welcome in Bug... [16:13:51] (03PS36) 10Wctaiwan: [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 [16:14:30] 3Wikimedia / 3Site requests: Change FlaggedRevs configuration on fa.wikipedia - 10https://bugzilla.wikimedia.org/69668 (10Calak) 3NEW p:3Unprio s:3normal a:3None Please add 'autoreviewrestore' right to rollbacker user group. Thanks. [16:14:57] 3Wikimedia / 3Site requests: Change FlaggedRevs configuration on fa.wikipedia - 10https://bugzilla.wikimedia.org/69668 (10Calak) p:5Unprio>3Normal s:5normal>3enhanc [16:19:45] (03PS1) 10BryanDavis: Bootstrap MWMultiVersion for default wiki if unset [vagrant] - 10https://gerrit.wikimedia.org/r/154472 (https://bugzilla.wikimedia.org/69520) [16:43:30] (03CR) 10Ori.livneh: [C: 04-1] Bootstrap MWMultiVersion for default wiki if unset (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/154472 (https://bugzilla.wikimedia.org/69520) (owner: 10BryanDavis) [16:51:34] Hi! [16:55:41] Hello ritika_coder_101 [16:56:18] Whenever I login into the mediawiki VM through vagrant ssh command, it says run 'hhvmsh' to interactively evaluate php and run 'mysql' for a database shell. But neither of my commands is working. For hhvmsh command, there comes an error "/user/local/bin/hhvmsh : 4 : exec : hhvm : not found" and for mysql command, there is an error of type " ERROR 1049 (42000) : Unknown database 'wiki'. Any suggestion to resolve these? [16:56:28] Hello Ebe123 [16:58:02] Neither I am able to browse http://127.0.0.1:8080/ to find my MediaWiki instance as mentioned on https://www.mediawiki.org/wiki/MediaWiki-Vagrant. It says "webpage not available" [17:02:00] (03CR) 10Isarra: [C: 032 V: 032] "Got whitespace issues, but someone can fix those later." [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/154471 (owner: 10Jack Phoenix) [17:02:02] (03Merged) 10jenkins-bot: Add white theme. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/154471 (owner: 10Jack Phoenix) [17:03:18] (03CR) 10Bartosz Dziewoński: Remove unused global declarations (031 comment) [core] - 10https://gerrit.wikimedia.org/r/147831 (owner: 10Umherirrender) [17:04:15] (03PS2) 10Bartosz Dziewoński: Move installer files from skins/common/ to mw-config/ [core] - 10https://gerrit.wikimedia.org/r/153368 (https://bugzilla.wikimedia.org/69277) [17:04:17] (03PS2) 10Bartosz Dziewoński: Move mediawiki.legacy.* modules from skins/common/ to resources/ [core] - 10https://gerrit.wikimedia.org/r/153370 (https://bugzilla.wikimedia.org/69277) [17:04:19] (03PS1) 10Bartosz Dziewoński: WebInstallerOutput: Restore mistakenly deleted 'global $wgResourceModules' [core] - 10https://gerrit.wikimedia.org/r/154475 [17:07:32] (03PS1) 10Bartosz Dziewoński: Remove useless things from 'mediawiki.installer.legacy' "module" [core] - 10https://gerrit.wikimedia.org/r/154476 [17:10:11] is bd808|BUFFER back? [17:11:29] 3MediaWiki extensions / 3Translate: Impossible to mark pages for translation without causing a PHP fatal - 10https://bugzilla.wikimedia.org/69669 (10Vogone) 3NEW p:3Unprio s:3blocke a:3None When marking a page for translation, clicking at "Translate this page" leads to a "The indicated group does not... [17:11:56] (03PS37) 10Wctaiwan: Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 [17:12:34] yurikR: Back-ish. Jet lag and grocery shopping today. I'll try to fix some of the things I broke too. [17:13:16] bd808|MOBILE, welcome !!! hope you had a good vacation :) yes, windows vagrant is top on my wish list ;) [17:13:42] 3MediaWiki extensions / 3Translate: Impossible to mark pages for translation without causing a PHP fatal - 10https://bugzilla.wikimedia.org/69669 (10Vogone) s:5blocke>3critic [17:14:14] ritika_coder_101, what's your host os? [17:16:01] yurikR: Windows 7 [17:16:20] ritika_coder_101, did you pull the latest vagrant? [17:16:32] because its broken [17:17:20] Umm I guess no. [17:17:57] 3MediaWiki extensions / 3WikidataRepo: Remove assertTag usages from tests - 10https://bugzilla.wikimedia.org/67122#c1 (10Jeroen De Dauw) For places where we need to crawl through the actual DOM, I much preffer to not invent our own solution. One of the PHPUnit people started a plugin for this purpouse, which... [17:18:07] Do I need to pull that from the host ? [17:18:13] 3MediaWiki-Vagrant: Vagrant build/provison fails on Windows - Could not set 'link' on ensure: Protocol error - 10https://bugzilla.wikimedia.org/69425 (10Yuri Astrakhan) [17:18:50] i would recommend "git pull 16f06925d9689d6" in your vagrant dir [17:19:05] sorry, git checkcout 16f06925d9689d6 [17:19:16] grr... "checkout" [17:19:31] (03CR) 10Helder.wiki: [C: 04-1] "I think this will break the usage of" [core] - 10https://gerrit.wikimedia.org/r/154476 (owner: 10Bartosz Dziewoński) [17:19:36] ritika_coder_101, how did you get the vagrant code? [17:19:53] did you clone vagrant directory? [17:19:58] *repository [17:20:06] (i clearly haven't woken up yet) [17:20:48] yurikR: yes! I used this. git clone https://gerrit.wikimedia.org/r/mediawiki/vagrant [17:21:06] (03CR) 10Bartosz Dziewoński: "I am positive nothing is using this module like that. The config.js file is explicitly loaded by the path and file name and not via RL, th" [core] - 10https://gerrit.wikimedia.org/r/154476 (owner: 10Bartosz Dziewoński) [17:21:20] cool, in that same dir do this: git pull, and later - git checkout 16f06925 [17:21:59] 3Wikimedia / 3Site requests: Change domain chapcom.wikimedia.org to affcom.wikimedia.org - 10https://bugzilla.wikimedia.org/69670 (10Tanvir Rahman) 3NEW p:3Unprio s:3normal a:3None Hello, We've been using chapcom.wikimedia.org since the Committee's name was Chapters Committee. As it has changed its... [17:22:04] yurikR: Okay! [17:22:25] ritika_coder_101, sec, double checking, maybe i gave you the broken patch number, instead of the patch right before it [17:22:33] need cofee! [17:23:09] Haha! Yes! I'll try that and you get freshen up :) Thanks [17:23:56] git checkout 3c8323c [17:23:58] that's the one [17:24:12] 3Wikimedia / 3Site requests: Change domain chapcom.wikimedia.org to affcom.wikimedia.org - 10https://bugzilla.wikimedia.org/69670 (10Tanvir Rahman) [17:24:19] the one i gave you is the one that actually caused https://bugzilla.wikimedia.org/show_bug.cgi?id=69425 [17:24:32] ritika_coder_101, [17:25:05] afterwards do vagrant provision [17:25:05] yurikR: I did that. Now will php and mysql work? [17:25:13] who knows? :) [17:25:43] at least i know that that was the last patch that works on windows [17:26:01] the "vagrant provision" should pass [17:26:11] Okay! :) [17:27:09] Also, tell me where to find this patch number for future use. [17:27:45] I am very new to this environment. [17:28:00] yeah, and now is the worst moment because its broken on windows :) [17:28:14] i use tortoiseGit and various git commands [17:29:09] (03PS1) 10Jack Phoenix: Fix EOL whitespace. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/154477 [17:29:31] (03CR) 10Jack Phoenix: [C: 032 V: 032] Fix EOL whitespace. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/154477 (owner: 10Jack Phoenix) [17:30:35] but for this specific patch i had to write a script that would iterate through all revisions backwards and try "vagrant provision" on each until it worked [17:30:49] took a very long time to figure out which patch caused the issue [17:31:34] did you vagrant provision run correctly? [17:31:38] Broken? Will that make things more difficult? [17:31:53] always ;) [17:32:26] but the patch i gave you - 3c8323c, should work ok... let me see if our mw scripts work [17:33:00] Yea I guess! But it has halted now but shows :executed successfully" at the end. [17:33:09] awesome [17:33:12] now ssh to it [17:34:30] Commands hhvmsh and mysql are still not working. [17:35:59] hm, they work for me. did you customize wiki installation in any way? [17:36:19] any additional roles? [17:36:37] does http://127.0.0.1:8080/info.php [17:36:38] work? [17:36:51] how about http://127.0.0.1:8080 ? [17:37:57] Yes I added two roles mysql and zend [17:37:58] 3Wikimedia / 3Site requests: Make maintenance reports longer on en.wiki: increase $wgQueryCacheLimit - 10https://bugzilla.wikimedia.org/44321 (10Umherirrender) [17:37:59] 3MediaWiki / 3Special pages: Special:Unwatchedpages only shows 5,000 articles in es.wiki - 10https://bugzilla.wikimedia.org/69660#c4 (10Umherirrender) Yes, it is for performance reason. For example on dewiki there are more than 100,000 unwatched pages, there is no useful way to look at all and choose some fo... [17:38:29] No these links do not work [17:39:08] in that case you have something bigger wrong with your system - first thing - you need your vagrant to function correctly [17:41:04] So, what do you think ? How can this be rectified ? [17:42:11] did you put anything important on that wiki / customizations? if not, kill it (vagrant destroy), delete that dir (btw, just in case, make sure there are no spaces in the path), follow https://www.mediawiki.org/w/index.php?title=MediaWiki-Vagrant [17:44:31] No I didnt put anything important. I am killing it now [17:44:59] make sure you have the latest virtual box and vagrant installed [17:45:06] reboting windows also helps at times :) [17:46:12] (03CR) 10Umherirrender: WebInstallerOutput: Restore mistakenly deleted 'global $wgResourceModules' (031 comment) [core] - 10https://gerrit.wikimedia.org/r/154475 (owner: 10Bartosz Dziewoński) [17:47:49] okay! I just try that now. Will 'vagrant up' mean to create a fresh instance of wikimedia VM ? [17:49:30] It took me 3 hours for its initial setup yesterday :-/ [17:50:27] 3MediaWiki-Vagrant: Vagrant build/provison fails on Windows - Could not set 'link' on ensure: Protocol error - 10https://bugzilla.wikimedia.org/69425#c5 (10Yuri Astrakhan) On MW wiki, I posted a temp workaround - git checkout 3c8323c. Please remove it once the bug is fixed. https://www.mediawiki.org/wiki/Media... [17:50:44] ritika_coder_101, sadly so :( [17:50:53] vagrant destroy kills it [17:51:00] you have a very slow connection? [17:51:22] (03CR) 10Jforrester: [C: 031] Move installer files from skins/common/ to mw-config/ [core] - 10https://gerrit.wikimedia.org/r/153368 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [17:52:02] I guess so :'( [17:53:21] problem is, i don't know what exactly failed for you, so it is better to recreate the whole environment from scratch. In theory, vagrant destroy & vagrant up without deleting work dir should be much faster because it cashes packages directory (apt-get updates), and it keeps the code (mediawiki dir) [17:53:40] ritika_coder_101, what's the full path of your vagrant dir? [17:53:51] and what are the versions of you vagrant & virtual box? [17:54:10] (03CR) 10Helder.wiki: "IF someone uses mw.loader.using like that (which is recommended) in a gadget or user script, then I think RL will load the file, and its d" [core] - 10https://gerrit.wikimedia.org/r/154476 (owner: 10Bartosz Dziewoński) [17:55:10] VirtualBox : 4.3.14 [17:55:10] Vagrant : 1.6.3 [17:56:00] ritika_coder_101, do you have spaces in the path to vagrant dir? [17:56:23] and have you rebooted after installing all that stuff? [17:56:42] 3MediaWiki / 3Skin and page rendering: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c11 (10Bartosz Dziewoński) I took Dan's logs, manually removed some clearly botched requests, removed everything older than 1.24wmf6 (the dire... [17:57:13] No spaces in the path. I just use cd vagrant to work from there [17:58:04] I guess no. I just followed the steps given in https://www.mediawiki.org/wiki/MediaWiki-Vagrant [17:59:58] (03CR) 10Bartosz Dziewoński: WebInstallerOutput: Restore mistakenly deleted 'global $wgResourceModules' (031 comment) [core] - 10https://gerrit.wikimedia.org/r/154475 (owner: 10Bartosz Dziewoński) [18:01:45] 3MediaWiki extensions / 3WikidataRepo: False message: List of values is complete. - 10https://bugzilla.wikimedia.org/69671 (10sju-w) 3UNCO p:3Unprio s:3critic a:3Wikidata bugs Since the last months, in some cases, the section "Wikimedia Commons page linked to this item" displays a message "List of va... [18:02:55] ritika_coder_101, did you do "git checkout" before running vagrant up? [18:04:02] For the first time? [18:11:57] 3MediaWiki extensions / 3WikidataRepo: False message: List of values is complete. - 10https://bugzilla.wikimedia.org/69671#c1 (10John F. Lewis) p:5Unprio>3Normal Are there any examples of this currently? I can not confirm myself. [Putting as normal until confirm-able and leaving status as unconfirmed.] [18:16:54] (03PS3) 10Bartosz Dziewoński: Move installer files from skins/common/ to mw-config/ [core] - 10https://gerrit.wikimedia.org/r/153368 (https://bugzilla.wikimedia.org/69277) [18:17:25] (03CR) 10Bartosz Dziewoński: "Verified and checked against the access logs from bug 69277, should be good to merge now." [core] - 10https://gerrit.wikimedia.org/r/153368 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [18:17:35] (03PS3) 10Bartosz Dziewoński: Move mediawiki.legacy.* modules from skins/common/ to resources/ [core] - 10https://gerrit.wikimedia.org/r/153370 (https://bugzilla.wikimedia.org/69277) [18:19:12] (03CR) 10Bartosz Dziewoński: "The code doesn't actually depend on wikibits. This module was also never intended to be loaded by anyone (and I actually just renamed it i" [core] - 10https://gerrit.wikimedia.org/r/154476 (owner: 10Bartosz Dziewoński) [18:24:44] Hi tonythomas. [18:33:13] 3MediaWiki / 3Skin and page rendering: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277 (10Bartosz Dziewoński) [18:33:15] 3MediaWiki extensions / 3ApiSandbox: Use jquery.spinner module instead of skins/common/images/spinner.gif - 10https://bugzilla.wikimedia.org/69672 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None Use jquery.spinner module instead of skins/common/images/spinner.gif. [18:35:32] (03PS1) 10Addshore: Add basic REAME.md [tools/code-utils] - 10https://gerrit.wikimedia.org/r/154481 [18:37:56] * Jasper_Deng trouts addshore [18:38:08] urgh, no time :P [18:38:55] what if it was a rainbow trout? or perhaps a smoked salmon? [18:39:23] (03CR) 10BryanDavis: Bootstrap MWMultiVersion for default wiki if unset (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/154472 (https://bugzilla.wikimedia.org/69520) (owner: 10BryanDavis) [18:43:30] quiddity: when I trout someone, I expect them to cook and eat it :P [18:44:27] (03PS11) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/92621 [18:45:30] 3MediaWiki / 3Skin and page rendering: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277 (10Bartosz Dziewoński) [18:45:30] 3MediaWiki / 3Skin and page rendering: Stop using inline for thumbnail magnify icon - 10https://bugzilla.wikimedia.org/69673 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None Let's stop using inline for thumbnail magnify icon. According to bug 69277 comment 11, there are 87619775 re... [18:47:27] 3MediaWiki / 3Skin and page rendering: Stop using inline for thumbnail magnify icon - 10https://bugzilla.wikimedia.org/69673#c1 (10Bartosz Dziewoński) A number of extensions also refer to this file directly, including VisualEditor and WikiEditor. These will need to be updated. There are probably also... [18:54:57] 3MediaWiki / 3Skin and page rendering: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c12 (10Bartosz Dziewoński) Many of the requests for images @embed-ded in CSS are probably from IE 6 and should disappear after we move the sty... [18:58:42] 3MediaWiki / 3Skin and page rendering: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c13 (10Bartosz Dziewoński) (In reply to Bartosz Dziewoński from comment #12) > > images/magnify-clip.png 87619775 > > images... [19:08:45] (03PS1) 10Bartosz Dziewoński: Use jquery.spinner module instead of skins/common/images/spinner.gif [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/154483 (https://bugzilla.wikimedia.org/69672) [19:09:20] (03CR) 10Umherirrender: WebInstallerOutput: Restore mistakenly deleted 'global $wgResourceModules' (031 comment) [core] - 10https://gerrit.wikimedia.org/r/154475 (owner: 10Bartosz Dziewoński) [19:10:24] (03CR) 10Bartosz Dziewoński: [C: 04-1] Move mediawiki.legacy.* modules from skins/common/ to resources/ [core] - 10https://gerrit.wikimedia.org/r/153370 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [19:12:04] (03CR) 10Florianschmidtwelzow: [C: 032] Fix WebInstaller-Break [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/154134 (https://bugzilla.wikimedia.org/69564) (owner: 10Florianschmidtwelzow) [19:12:10] (03Merged) 10jenkins-bot: Fix WebInstaller-Break [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/154134 (https://bugzilla.wikimedia.org/69564) (owner: 10Florianschmidtwelzow) [19:13:57] 3MediaWiki extensions / 3GoogleLogin: GoogleLogin breaks webinstaller (mw-config) - 10https://bugzilla.wikimedia.org/69564 (10Florian) 5PATC>3RESO/FIX [19:14:22] (03PS2) 10Bartosz Dziewoński: WebInstallerOutput: Restore mistakenly deleted 'global $wgResourceModules' [core] - 10https://gerrit.wikimedia.org/r/154475 [19:14:26] (03CR) 10Bartosz Dziewoński: WebInstallerOutput: Restore mistakenly deleted 'global $wgResourceModules' (031 comment) [core] - 10https://gerrit.wikimedia.org/r/154475 (owner: 10Bartosz Dziewoński) [19:16:06] (03PS2) 10BryanDavis: Bootstrap MWMultiVersion for default wiki if unset [vagrant] - 10https://gerrit.wikimedia.org/r/154472 (https://bugzilla.wikimedia.org/69520) [19:18:21] (03CR) 10Umherirrender: [C: 031] WebInstallerOutput: Restore mistakenly deleted 'global $wgResourceModules' [core] - 10https://gerrit.wikimedia.org/r/154475 (owner: 10Bartosz Dziewoński) [19:18:54] (03PS3) 10Bartosz Dziewoński: WebInstallerOutput: Restore 'global $wgResourceModules' [core] - 10https://gerrit.wikimedia.org/r/154475 [19:22:19] (03PS4) 10Bartosz Dziewoński: Move installer files from skins/common/ to mw-config/ [core] - 10https://gerrit.wikimedia.org/r/153368 (https://bugzilla.wikimedia.org/69277) [19:25:26] (03PS5) 10Bartosz Dziewoński: Move installer files from skins/common/ to mw-config/ [core] - 10https://gerrit.wikimedia.org/r/153368 (https://bugzilla.wikimedia.org/69277) [19:26:31] (03PS1) 10Addshore: Fix @returns >> @return phpdoc [core] - 10https://gerrit.wikimedia.org/r/154485 [19:27:11] (03PS2) 10Bartosz Dziewoński: Remove pointless dependencies from mediawiki.legacy.config [core] - 10https://gerrit.wikimedia.org/r/154476 [19:27:41] (03CR) 10Bartosz Dziewoński: "Rephrased to make it clear this isn't a breaking change. (I also reverted the module renaming, just in case.)" [core] - 10https://gerrit.wikimedia.org/r/154476 (owner: 10Bartosz Dziewoński) [19:27:45] 3Wikimedia / 3Site requests: Change domain chapcom.wikimedia.org to affcom.wikimedia.org - 10https://bugzilla.wikimedia.org/69670#c1 (10jeremyb) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 39482 *** [19:27:45] 3Wikimedia / 3Site requests: Rename "chapcomwiki" to "affcomwiki" - 10https://bugzilla.wikimedia.org/39482#c13 (10jeremyb) *** Bug 69670 has been marked as a duplicate of this bug. *** [19:27:47] (03CR) 10BryanDavis: "This is nice stuff, but I'm going to revert until I71caac5f77a30d1c62cc7fc004c34d519d2a3883 is merged. There are some other comments inlin" (035 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/147685 (owner: 10Dduvall) [19:27:56] (03PS1) 10BryanDavis: Revert "Provision browser tests for CentralAuth" [vagrant] - 10https://gerrit.wikimedia.org/r/154486 [19:27:57] 3Wikimedia / 3Site requests: Wikis waiting to be renamed (tracking) - 10https://bugzilla.wikimedia.org/19986 (10jeremyb) [19:28:27] 3Wikimedia / 3Site requests: Change domain chapcom.wikimedia.org to affcom.wikimedia.org - 10https://bugzilla.wikimedia.org/69670 (10jeremyb) 5RESO/?>3VERI [19:29:09] (03CR) 10Bartosz Dziewoński: [C: 032] Fix @returns >> @return phpdoc [core] - 10https://gerrit.wikimedia.org/r/154485 (owner: 10Addshore) [19:29:11] hey addshore [19:29:16] i have some boring stuff to merge [19:29:18] wanna? [19:30:10] https://gerrit.wikimedia.org/r/154335 https://gerrit.wikimedia.org/r/148768 https://gerrit.wikimedia.org/r/154475 [19:30:33] (03CR) 10BryanDavis: [C: 032] "Just a temporary measure until I71caac5f77a30d1c62cc7fc004c34d519d2a3883 is merged in CentralAuth." [vagrant] - 10https://gerrit.wikimedia.org/r/154486 (owner: 10BryanDavis) [19:30:38] (03Merged) 10jenkins-bot: Revert "Provision browser tests for CentralAuth" [vagrant] - 10https://gerrit.wikimedia.org/r/154486 (owner: 10BryanDavis) [19:32:22] (03Merged) 10jenkins-bot: Fix @returns >> @return phpdoc [core] - 10https://gerrit.wikimedia.org/r/154485 (owner: 10Addshore) [19:33:04] (03PS1) 10BryanDavis: Revert "Revert "Provision browser tests for CentralAuth"" [vagrant] - 10https://gerrit.wikimedia.org/r/154487 [19:34:14] (03CR) 10Raimond Spekking: [C: 032] Remove fallback 'de' gender namespaces [core] - 10https://gerrit.wikimedia.org/r/154462 (owner: 10Umherirrender) [19:35:58] 3Wikimedia / 3Site requests: Rename ku.wikipedia to kmr.wikipedia - 10https://bugzilla.wikimedia.org/30376#c5 (10Calak) There is no consensus on kuwiki for this change yet. [19:37:40] (03Merged) 10jenkins-bot: Remove fallback 'de' gender namespaces [core] - 10https://gerrit.wikimedia.org/r/154462 (owner: 10Umherirrender) [19:37:57] (03PS1) 10Addshore: Fix @returns >> @return phpdoc [extensions/CommunityTwitter] - 10https://gerrit.wikimedia.org/r/154491 [19:40:09] (03PS1) 10Addshore: Fix @returns >> @return phpdoc [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/154493 [19:40:20] (03CR) 10Bartosz Dziewoński: [C: 032] Add dependencies to module mediawiki.util [core] - 10https://gerrit.wikimedia.org/r/154459 (owner: 10Gerrit Patch Uploader) [19:40:56] (03PS1) 10Addshore: Fix @returns >> @return phpdoc [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/154494 [19:41:15] (03PS1) 10Addshore: Fix @returns >> @return phpdoc [extensions/PHPExcel] - 10https://gerrit.wikimedia.org/r/154495 [19:41:58] (03PS1) 10Addshore: Fix @returns >> @return phpdoc [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/154497 [19:42:24] (03PS1) 10Addshore: Fix @returns >> @return phpdoc [extensions/ReaderFeedback] - 10https://gerrit.wikimedia.org/r/154498 [19:42:37] (03CR) 10Bartosz Dziewoński: [C: 04-1] Remove success box on changing any preference or switching tab (032 comments) [core] - 10https://gerrit.wikimedia.org/r/107837 (https://bugzilla.wikimedia.org/17496) (owner: 10Gerrit Patch Uploader) [19:42:50] (03PS1) 10Addshore: Fix @returns >> @return phpdoc [extensions/SwiftCloudFiles] - 10https://gerrit.wikimedia.org/r/154499 [19:43:04] (03PS1) 10Addshore: Fix @returns >> @return phpdoc [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/154500 [19:43:22] (03PS1) 10Addshore: Fix @returns >> @return phpdoc [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/154501 [19:43:48] (03Merged) 10jenkins-bot: Add dependencies to module mediawiki.util [core] - 10https://gerrit.wikimedia.org/r/154459 (owner: 10Gerrit Patch Uploader) [19:44:38] (03PS1) 10Addshore: Fix @returns >> @return phpdoc [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/154503 [19:45:54] (03CR) 10Bartosz Dziewoński: [C: 032] Use Xml::element instead of Html::element for empty elements [core] - 10https://gerrit.wikimedia.org/r/144654 (owner: 10Gerrit Patch Uploader) [19:47:56] (03CR) 10Bartosz Dziewoński: [C: 032] "Whatever." [core] - 10https://gerrit.wikimedia.org/r/130472 (owner: 10Gerrit Patch Uploader) [19:49:30] (03PS1) 10Addshore: Fix @returns >> @return phpdoc [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/154505 [19:49:32] (03Merged) 10jenkins-bot: Use Xml::element instead of Html::element for empty elements [core] - 10https://gerrit.wikimedia.org/r/144654 (owner: 10Gerrit Patch Uploader) [19:51:15] (03Merged) 10jenkins-bot: Avoid theoretical division by zero [core] - 10https://gerrit.wikimedia.org/r/130472 (owner: 10Gerrit Patch Uploader) [19:54:57] 3Wikimedia / 3Site requests: Change FlaggedRevs configuration on fa.wikipedia - 10https://bugzilla.wikimedia.org/69668#c2 (10Calak) Also remove redundant 'unreviewedpages' right from patroller and sysop, it doesn't work: https://fa.wikipedia.org/wiki/ویژه:UnreviewedPages?uselang=en [19:55:15] (03CR) 10Tpt: [C: 032] "Thanks a lot!" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/154497 (owner: 10Addshore) [19:55:30] (03Merged) 10jenkins-bot: Fix @returns >> @return phpdoc [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/154497 (owner: 10Addshore) [20:03:13] (03CR) 10Addshore: [C: 032] WebInstallerOutput: Restore 'global $wgResourceModules' [core] - 10https://gerrit.wikimedia.org/r/154475 (owner: 10Bartosz Dziewoński) [20:06:29] (03Merged) 10jenkins-bot: WebInstallerOutput: Restore 'global $wgResourceModules' [core] - 10https://gerrit.wikimedia.org/r/154475 (owner: 10Bartosz Dziewoński) [20:06:58] (03PS16) 10BryanDavis: QA: The first Selenium test: CentralAuth log in [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/125740 (owner: 10Zfilipin) [20:07:56] (03PS1) 10Addshore: Use public instead of var in classes [core] - 10https://gerrit.wikimedia.org/r/154507 [20:08:12] 3MediaWiki extensions / 3ReplaceText: [ReplaceText] Incorrect error: You must select at least one namespace. - 10https://bugzilla.wikimedia.org/38170#c16 (10Mark A. Hershberger) 5RESO/WON>3REOP I've run into this exact problem running the latest from gerrit + a 1.19 MediaWiki. The problem is that edit_p... [20:09:09] (03PS1) 10Addshore: Use public instead of var in classes [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/154508 [20:09:11] (03CR) 10jenkins-bot: [V: 04-1] Use public instead of var in classes [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/154508 (owner: 10Addshore) [20:09:26] (03PS1) 10Addshore: Use public instead of var in classes [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/154509 [20:09:38] (03PS1) 10Addshore: Use public instead of var in classes [skins/Dusk] - 10https://gerrit.wikimedia.org/r/154510 [20:09:51] (03PS1) 10Addshore: Use public instead of var in classes [skins/Example] - 10https://gerrit.wikimedia.org/r/154511 [20:10:03] (03PS1) 10Addshore: Use public instead of var in classes [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/154512 [20:10:13] (03PS1) 10Addshore: Use public instead of var in classes [skins/Mask] - 10https://gerrit.wikimedia.org/r/154513 [20:10:27] (03PS1) 10Addshore: Use public instead of var in classes [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/154514 [20:10:37] (03PS1) 10Addshore: Use public instead of var in classes [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/154515 [20:10:42] (03PS2) 10Addshore: Use public instead of var in classes [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/154508 [20:10:53] addshore: it looks as if you were a bot running on gerrit :p [20:11:06] hehe :P [20:11:07] (03PS1) 10Addshore: Use public instead of var in classes [skins/Splash] - 10https://gerrit.wikimedia.org/r/154516 [20:11:22] (03PS1) 10Addshore: Use public instead of var in classes [skins/chameleon] - 10https://gerrit.wikimedia.org/r/154517 [20:11:35] (03PS1) 10Addshore: Use public instead of var in classes [skins/erudite] - 10https://gerrit.wikimedia.org/r/154518 [20:11:46] (03PS1) 10Addshore: Use public instead of var in classes [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/154519 [20:12:31] (03PS1) 10Addshore: Use public instead of var in classes [skins/webplatform] - 10https://gerrit.wikimedia.org/r/154520 [20:12:37] lazowik: just doing some cleanup :) [20:12:54] very interactive a bot, indeed [20:13:04] haha, no bot :> [20:13:19] could use some more grammar training [20:13:31] addshore: wait a sec, I'm gonna throw some grammar books at ya' [20:13:35] :/ [20:13:44] this bot just pulls faces :O [20:13:49] oO [20:13:50] <(^.^)> [20:13:57] !nyan | addshore [20:13:57] addshore: ~=[,,_,,]:3 [20:14:14] * lazowik actually didn't expect that to work [20:14:19] :O [20:14:24] !nyan !nyan [20:14:24] ~=[,,_,,]:3 [20:14:27] :< [20:17:18] (03PS1) 10Addshore: Use public instead of var in classes [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/154522 [20:17:25] (03PS2) 10BryanDavis: Provision browser tests for CentralAuth [vagrant] - 10https://gerrit.wikimedia.org/r/154487 [20:18:12] addshore: So what's the distinction between public vs var? [20:18:46] (03PS1) 10MarkAHershberger: Fix “Incorrect error: You must select at least one namespace.” [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/154523 (https://bugzilla.wikimedia.org/38170) [20:18:46] Isarra: var is deprecated, and in php5+ excluding php 5.3 will thrown E_STRICTs [20:19:06] Oh. [20:19:10] Weird. [20:19:20] indeed :P [20:20:00] (03PS3) 10BryanDavis: Provision browser tests for CentralAuth [vagrant] - 10https://gerrit.wikimedia.org/r/154487 [20:20:10] Is there any reason not to go ahead and merge those? [20:20:49] actually the note is really the following. [20:20:49] (03CR) 10BryanDavis: [C: 032] "Worked for me with a clean MWV build and 16bcbf3b3fe19666d47caf2b923189203068ae30 applied:" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/125740 (owner: 10Zfilipin) [20:20:50] The PHP 4 method of declaring a variable with the var keyword is still supported for compatibility reasons (as a synonym for the public keyword). In PHP 5 before 5.1.3, its usage would generate an E_STRICT warning. [20:21:14] (03Merged) 10jenkins-bot: QA: The first Selenium test: CentralAuth log in [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/125740 (owner: 10Zfilipin) [20:21:39] no reason not to merge them :) the less var the better! [20:21:46] (03CR) 10Florianschmidtwelzow: [C: 032] "Is an error of Google API client, but ok :) Thanks!" [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/154494 (owner: 10Addshore) [20:21:51] (03Merged) 10jenkins-bot: Fix @returns >> @return phpdoc [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/154494 (owner: 10Addshore) [20:22:36] Isarra: merge them all! [20:23:06] * Isarra tries to get ashley to do it. [20:23:26] (03CR) 10Legoktm: [C: 032] Fix @returns >> @return phpdoc [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/154500 (owner: 10Addshore) [20:23:53] (03Merged) 10jenkins-bot: Fix @returns >> @return phpdoc [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/154500 (owner: 10Addshore) [20:24:39] (03CR) 10Isarra: [C: 032] Use public instead of var in classes [skins/Dusk] - 10https://gerrit.wikimedia.org/r/154510 (owner: 10Addshore) [20:24:41] (03Merged) 10jenkins-bot: Use public instead of var in classes [skins/Dusk] - 10https://gerrit.wikimedia.org/r/154510 (owner: 10Addshore) [20:24:50] (03CR) 10Legoktm: [C: 032] Fix @returns >> @return phpdoc [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/154505 (owner: 10Addshore) [20:24:56] (03Merged) 10jenkins-bot: Fix @returns >> @return phpdoc [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/154505 (owner: 10Addshore) [20:24:58] (03CR) 10Legoktm: [C: 032] Fix @returns >> @return phpdoc [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/154503 (owner: 10Addshore) [20:25:00] (03CR) 10Legoktm: [C: 032] Fix @returns >> @return phpdoc [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/154501 (owner: 10Addshore) [20:25:02] (03Merged) 10jenkins-bot: Fix @returns >> @return phpdoc [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/154503 (owner: 10Addshore) [20:25:04] (03CR) 10Legoktm: [C: 032] Fix @returns >> @return phpdoc [extensions/SwiftCloudFiles] - 10https://gerrit.wikimedia.org/r/154499 (owner: 10Addshore) [20:25:06] (03CR) 10Legoktm: [C: 032] Fix @returns >> @return phpdoc [extensions/ReaderFeedback] - 10https://gerrit.wikimedia.org/r/154498 (owner: 10Addshore) [20:25:10] (03CR) 10Legoktm: [C: 032] Fix @returns >> @return phpdoc [extensions/PHPExcel] - 10https://gerrit.wikimedia.org/r/154495 (owner: 10Addshore) [20:25:12] (03CR) 10Legoktm: [C: 032] Fix @returns >> @return phpdoc [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/154493 (owner: 10Addshore) [20:25:15] (03Merged) 10jenkins-bot: Fix @returns >> @return phpdoc [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/154501 (owner: 10Addshore) [20:25:17] (03Merged) 10jenkins-bot: Fix @returns >> @return phpdoc [extensions/SwiftCloudFiles] - 10https://gerrit.wikimedia.org/r/154499 (owner: 10Addshore) [20:25:19] (03Merged) 10jenkins-bot: Fix @returns >> @return phpdoc [extensions/ReaderFeedback] - 10https://gerrit.wikimedia.org/r/154498 (owner: 10Addshore) [20:25:23] (03Merged) 10jenkins-bot: Fix @returns >> @return phpdoc [extensions/PHPExcel] - 10https://gerrit.wikimedia.org/r/154495 (owner: 10Addshore) [20:25:25] (03Merged) 10jenkins-bot: Fix @returns >> @return phpdoc [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/154493 (owner: 10Addshore) [20:25:28] (03CR) 10Isarra: [C: 032] Use public instead of var in classes [skins/Example] - 10https://gerrit.wikimedia.org/r/154511 (owner: 10Addshore) [20:25:30] (03Merged) 10jenkins-bot: Use public instead of var in classes [skins/Example] - 10https://gerrit.wikimedia.org/r/154511 (owner: 10Addshore) [20:25:32] (03CR) 10Isarra: [C: 032] Use public instead of var in classes [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/154512 (owner: 10Addshore) [20:25:34] (03Merged) 10jenkins-bot: Use public instead of var in classes [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/154512 (owner: 10Addshore) [20:25:36] (03CR) 10Isarra: [C: 032] Use public instead of var in classes [skins/Mask] - 10https://gerrit.wikimedia.org/r/154513 (owner: 10Addshore) [20:25:40] (03Merged) 10jenkins-bot: Use public instead of var in classes [skins/Mask] - 10https://gerrit.wikimedia.org/r/154513 (owner: 10Addshore) [20:25:42] (03CR) 10Legoktm: [C: 032] Fix @returns >> @return phpdoc [extensions/CommunityTwitter] - 10https://gerrit.wikimedia.org/r/154491 (owner: 10Addshore) [20:25:44] (03CR) 10Florianschmidtwelzow: "Info: https://github.com/google/google-api-php-client/pull/290" [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/154494 (owner: 10Addshore) [20:25:47] (03Merged) 10jenkins-bot: Fix @returns >> @return phpdoc [extensions/CommunityTwitter] - 10https://gerrit.wikimedia.org/r/154491 (owner: 10Addshore) [20:25:53] (03CR) 10Isarra: [C: 032] Use public instead of var in classes [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/154514 (owner: 10Addshore) [20:25:55] (03Merged) 10jenkins-bot: Use public instead of var in classes [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/154514 (owner: 10Addshore) [20:26:01] (03CR) 10Isarra: [C: 032] Use public instead of var in classes [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/154515 (owner: 10Addshore) [20:26:03] (03Merged) 10jenkins-bot: Use public instead of var in classes [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/154515 (owner: 10Addshore) [20:26:32] (03CR) 10Isarra: [C: 032] Use public instead of var in classes [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/154508 (owner: 10Addshore) [20:26:34] (03Merged) 10jenkins-bot: Use public instead of var in classes [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/154508 (owner: 10Addshore) [20:26:41] (03CR) 10Isarra: [C: 032] Use public instead of var in classes [skins/Splash] - 10https://gerrit.wikimedia.org/r/154516 (owner: 10Addshore) [20:26:43] (03Merged) 10jenkins-bot: Use public instead of var in classes [skins/Splash] - 10https://gerrit.wikimedia.org/r/154516 (owner: 10Addshore) [20:26:45] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/154522 (owner: 10Addshore) [20:26:49] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/154522 (owner: 10Addshore) [20:26:52] (03CR) 10Isarra: [C: 032] Use public instead of var in classes [skins/chameleon] - 10https://gerrit.wikimedia.org/r/154517 (owner: 10Addshore) [20:26:56] (03Merged) 10jenkins-bot: Use public instead of var in classes [skins/chameleon] - 10https://gerrit.wikimedia.org/r/154517 (owner: 10Addshore) [20:27:07] (03CR) 10Isarra: [C: 032] Use public instead of var in classes [skins/erudite] - 10https://gerrit.wikimedia.org/r/154518 (owner: 10Addshore) [20:27:09] (03Merged) 10jenkins-bot: Use public instead of var in classes [skins/erudite] - 10https://gerrit.wikimedia.org/r/154518 (owner: 10Addshore) [20:27:45] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [core] - 10https://gerrit.wikimedia.org/r/154507 (owner: 10Addshore) [20:27:49] (03CR) 10Isarra: [C: 032] Use public instead of var in classes [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/154509 (owner: 10Addshore) [20:28:03] (03Merged) 10jenkins-bot: Use public instead of var in classes [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/154509 (owner: 10Addshore) [20:28:07] (03CR) 10Isarra: [C: 032] Use public instead of var in classes [skins/webplatform] - 10https://gerrit.wikimedia.org/r/154520 (owner: 10Addshore) [20:28:09] (03Merged) 10jenkins-bot: Use public instead of var in classes [skins/webplatform] - 10https://gerrit.wikimedia.org/r/154520 (owner: 10Addshore) [20:28:10] so much merging [20:28:10] > mediawiki/skins/mediawiki-strapping [20:28:29] (03CR) 10Isarra: [C: 032] Use public instead of var in classes [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/154519 (owner: 10Addshore) [20:28:31] (03Merged) 10jenkins-bot: Use public instead of var in classes [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/154519 (owner: 10Addshore) [20:28:33] also, so much code that no longer works anyway yet addshore touched it! :> [20:28:44] XD [20:29:12] addshore: I don't merge in Donation* stuff, so that's the only one left. [20:29:19] :) [20:29:27] addshore: hmm [20:29:37] addshore: so you have all of the extensions checked out, right? [20:29:41] yup [20:29:42] thx addshore :) [20:30:22] addshore: can you check if anything uses EnhancedChangesList::arrow(), sideArrow(), downArrow(), spacerArrow()? [20:30:53] (03Merged) 10jenkins-bot: Use public instead of var in classes [core] - 10https://gerrit.wikimedia.org/r/154507 (owner: 10Addshore) [20:31:08] MatmaRex: give me a few seconds :) [20:32:14] legoktm: Ill have some more for you in a bit ;p [20:32:18] :D [20:32:32] done the extendsions, just reveiwing them now [20:32:36] *extensions [20:32:50] MatmaRex: nothing uses them as far as I can see [20:32:51] (03CR) 10Legoktm: [C: 032] Subclass JSONContent [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154451 (owner: 10Wctaiwan) [20:33:09] (03Merged) 10jenkins-bot: Subclass JSONContent [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154451 (owner: 10Wctaiwan) [20:33:13] just double checking [20:33:15] addshore: /me removes [20:33:20] should we deprecate first? [20:33:33] nooo, who cares. these are protected anyway [20:33:41] found some MatmaRex ! [20:33:47] boo [20:33:51] E:CleanChanges? [20:34:08] extensions/CleanChanges NCL::recentChangesBlockGroup [20:34:39] extensions/CleanChanges NCL::subEntries [20:34:45] those are the only uses [20:35:36] boooo [20:37:52] addshore: thanks [20:38:35] (03PS1) 10Bartosz Dziewoński: Remove some unused files from skins/common/ [core] - 10https://gerrit.wikimedia.org/r/154525 (https://bugzilla.wikimedia.org/69277) [20:38:38] addshore: can you do one more thing? grep for these files ^ :D [20:39:25] just in extensions MatmaRex ? [20:39:57] could do skins/ too, but probably no hits there [20:40:08] (or hits in some obscure old crap i'm not going to fix anyway) [20:40:30] doing now [20:41:22] addshore: +1 or +2 if there are no hits? :D [20:42:14] WikibaseQuery.i18n.php: needs merge [20:42:14] i18n/af.json: needs merge [20:42:14] i18n/ast.json: needs merge [20:42:14] lol [20:42:41] Your branch and 'origin/master' have diverged, [20:42:41] and have 31 and 111 different commits each, respectively. [20:42:42] srsly, wtf [20:42:45] (03CR) 10Legoktm: [C: 031] "Nothing found by mwgrep" [core] - 10https://gerrit.wikimedia.org/r/154525 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [20:43:43] (03CR) 10Legoktm: [C: 032] "Can be fixed in a follow-up. Yay!" (031 comment) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 (owner: 10Wctaiwan) [20:44:06] ... what? [20:44:09] (03Merged) 10jenkins-bot: Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 (owner: 10Wctaiwan) [20:44:12] only took 37 patchsets... [20:50:39] (03PS1) 10Legoktm: migrateAccount.php: CentralAuthUser::queryUnattached() throws MWException [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/154526 [20:52:49] (03CR) 10Legoktm: [C: 031] "I had been running this for a while, forgot to commit it." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/154526 (owner: 10Legoktm) [20:55:34] (03PS2) 10Bsitu: [2] Add title local cache holder objects [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154381 [20:55:58] (03CR) 10Hoo man: [C: 032] "Trivial" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/154526 (owner: 10Legoktm) [20:56:23] (03Merged) 10jenkins-bot: migrateAccount.php: CentralAuthUser::queryUnattached() throws MWException [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/154526 (owner: 10Legoktm) [20:58:29] 3MediaWiki extensions / 3WikidataRepo: Search gets disturbed by live preview - 10https://bugzilla.wikimedia.org/69674 (10Fomafix) 3NEW p:3Unprio s:3normal a:3Fomafix Steps to reproduce: * activate live preview in [1] * open [2] * click on button "Show preview" -> The preview occurs * Use the search f... [20:58:49] (03PS4) 10Ori.livneh: Provision browser tests for CentralAuth [vagrant] - 10https://gerrit.wikimedia.org/r/154487 (owner: 10BryanDavis) [20:58:53] (03CR) 10Ori.livneh: [C: 032] Provision browser tests for CentralAuth [vagrant] - 10https://gerrit.wikimedia.org/r/154487 (owner: 10BryanDavis) [20:58:58] (03Merged) 10jenkins-bot: Provision browser tests for CentralAuth [vagrant] - 10https://gerrit.wikimedia.org/r/154487 (owner: 10BryanDavis) [20:59:29] (03PS2) 10Bsitu: [3] Use title local cache to cache title object [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154382 [20:59:51] (03CR) 10Ori.livneh: [C: 032] Bootstrap MWMultiVersion for default wiki if unset [vagrant] - 10https://gerrit.wikimedia.org/r/154472 (https://bugzilla.wikimedia.org/69520) (owner: 10BryanDavis) [20:59:55] (03Merged) 10jenkins-bot: Bootstrap MWMultiVersion for default wiki if unset [vagrant] - 10https://gerrit.wikimedia.org/r/154472 (https://bugzilla.wikimedia.org/69520) (owner: 10BryanDavis) [21:00:00] ori is on the job again :) [21:00:11] bugs beware [21:00:15] 3MediaWiki extensions / 3WikidataRepo: False message: List of values is complete. - 10https://bugzilla.wikimedia.org/69671#c2 (10jklamo) I spotted same error one or two weeks ago. Unfortunately I do not remember affected item. [21:00:31] bd808: i stole your power converter and small socket connector :/ [21:00:39] is it okay if i give those back to you in sept/oct? [21:00:50] ori: Yup. No worries [21:00:58] thanks. sorry :/ [21:01:10] (03PS1) 10Addshore: Use public instead of var in classes [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/154541 [21:01:12] I had spares! [21:01:16] ori, had a good vacation? [21:01:16] (03CR) 10jenkins-bot: [V: 04-1] Use public instead of var in classes [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/154541 (owner: 10Addshore) [21:01:58] what vacation? [21:02:03] (03CR) 10Addshore: [V: 031] "This test failure is nothing to do with this change" [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/154541 (owner: 10Addshore) [21:02:12] https://gerrit.wikimedia.org/r/#/q/owner:%22Ori.livneh+%253Cori%2540wikimedia.org%253E%22,n,z [21:02:21] ori, weren't you away for a few days, taking a break? [21:02:32] (03PS1) 10Addshore: Use public instead of var in classes [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/154549 [21:02:32] yes, i manged the first bit [21:02:33] ori never takes vacations. [21:03:26] good ) [21:03:44] (03PS1) 10Addshore: Use public instead of var in classes [extensions/Blackout] - 10https://gerrit.wikimedia.org/r/154559 [21:03:50] (03PS1) 10Addshore: Use public instead of var in classes [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/154561 [21:03:57] (03PS1) 10Addshore: Use public instead of var in classes [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/154562 [21:04:03] (03PS1) 10Addshore: Use public instead of var in classes [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/154564 [21:04:08] bd808, do you have a winddows machine handy? [21:04:17] (03PS1) 10Addshore: Use public instead of var in classes [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/154567 [21:04:19] there was someone earlier today who had vagrant problems [21:04:24] (03PS1) 10Addshore: Use public instead of var in classes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/154569 [21:04:30] yurikR1: Nope. [21:04:30] (03PS1) 10Addshore: Use public instead of var in classes [extensions/Cite] - 10https://gerrit.wikimedia.org/r/154571 [21:04:37] (03PS1) 10Addshore: Use public instead of var in classes [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/154573 [21:04:44] (03PS1) 10Addshore: Use public instead of var in classes [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/154575 [21:04:51] (03PS1) 10Addshore: Use public instead of var in classes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/154576 [21:04:51] Which helps explain how I keep breakin MWV for windows users [21:04:57] (03PS1) 10Addshore: Use public instead of var in classes [extensions/Comments] - 10https://gerrit.wikimedia.org/r/154578 [21:05:04] (03PS1) 10Addshore: Use public instead of var in classes [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/154580 [21:05:07] * ori wishes https://bugzilla.wikimedia.org/show_bug.cgi?id=69505 was fixed [21:05:10] (03PS1) 10Addshore: Use public instead of var in classes [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/154582 [21:05:44] bd808: without any commitment on your part, would you object if i request office IT send you a windows laptop? [21:05:44] ori: doesnt look too hard to fix that [21:05:57] they have a bunch of dells for visitors that aren't getting much use [21:05:58] i second that! [21:06:05] ugh [21:06:25] (03PS1) 10Addshore: Use public instead of var in classes [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/154592 [21:06:32] (03PS1) 10Addshore: Use public instead of var in classes [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/154594 [21:06:34] My house has been windows free for almost 10 years [21:06:46] (03PS1) 10Addshore: Use public instead of var in classes [extensions/DoubleWiki] - 10https://gerrit.wikimedia.org/r/154598 [21:06:52] (03PS1) 10Addshore: Use public instead of var in classes [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/154600 [21:06:53] isn't Dan working on windows support? [21:06:58] (03PS1) 10Addshore: Use public instead of var in classes [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/154601 [21:06:59] you can keep it in the dog kennel outside [21:07:05] (03PS1) 10Addshore: Use public instead of var in classes [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/154603 [21:07:10] reedy want to mute the bot for a bit? :> [21:07:11] (03PS1) 10Addshore: Use public instead of var in classes [extensions/ExpandTemplates] - 10https://gerrit.wikimedia.org/r/154605 [21:07:14] addshore: probably. want to take it on? :) [21:07:18] (03PS1) 10Addshore: Use public instead of var in classes [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/154606 [21:07:19] bd808, you can always use a new doorstop [21:07:28] ori: will take a look once I have submitted this tonne of patches [21:07:28] (03PS1) 10Addshore: Use public instead of var in classes [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/154608 [21:07:35] (03PS1) 10Addshore: Use public instead of var in classes [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/154610 [21:07:41] (03PS1) 10Addshore: Use public instead of var in classes [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/154612 [21:07:48] (03PS1) 10Addshore: Use public instead of var in classes [extensions/HashTables] - 10https://gerrit.wikimedia.org/r/154613 [21:07:51] (03CR) 10Ori.livneh: [C: 032] Use public instead of var in classes [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/154603 (owner: 10Addshore) [21:07:55] (03PS1) 10Addshore: Use public instead of var in classes [extensions/ImageLink] - 10https://gerrit.wikimedia.org/r/154615 [21:07:57] gj ori [21:08:00] I should do something to test MWV changes on windows. I was going to try nested vms [21:08:03] * yurikR1 really needs https://bugzilla.wikimedia.org/show_bug.cgi?id=69425 fixed - it fully breaks windows :( [21:08:14] entirely and completely [21:08:21] yurikR1: It's on my list for today [21:08:21] (03PS1) 10Addshore: Use public instead of var in classes [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/154620 [21:08:26] run vagrant inside a linux VM! [21:08:27] (03PS1) 10Addshore: Use public instead of var in classes [extensions/Insider] - 10https://gerrit.wikimedia.org/r/154622 [21:08:27] 3Wikimedia / 3Site requests: Run migrateAccount.php without --safe or --auto - 10https://bugzilla.wikimedia.org/69291#c4 (10Kunal Mehta (Legoktm)) Now running the actual script on terbium. [21:08:29] i'm not nagging [21:08:34] (03PS1) 10Addshore: Use public instead of var in classes [extensions/Interlanguage] - 10https://gerrit.wikimedia.org/r/154623 [21:08:38] yurikR1: I really didn't mean to break that. [21:08:40] * yurikR1 wasn't even here [21:08:40] (03PS1) 10Addshore: Use public instead of var in classes [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/154625 [21:08:48] (03PS1) 10Addshore: Use public instead of var in classes [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/154627 [21:08:54] (03PS1) 10Addshore: Use public instead of var in classes [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/154629 [21:09:00] rrright... with all the windows love you just told us, i'm sure it was intentional [21:09:01] (03PS1) 10Addshore: Use public instead of var in classes [extensions/ListSignup] - 10https://gerrit.wikimedia.org/r/154630 [21:09:07] (03PS1) 10Addshore: Use public instead of var in classes [extensions/MSSQLBackCompat] - 10https://gerrit.wikimedia.org/r/154632 [21:09:13] (03PS1) 10Addshore: Use public instead of var in classes [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/154634 [21:09:21] yurikR1: I don't like it but I understand why others do. [21:09:21] (03PS1) 10Addshore: Use public instead of var in classes [extensions/Math] - 10https://gerrit.wikimedia.org/r/154635 [21:09:28] (03PS1) 10Addshore: Use public instead of var in classes [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/154637 [21:09:34] (03PS1) 10Addshore: Use public instead of var in classes [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/154639 [21:09:40] (03PS1) 10Addshore: Use public instead of var in classes [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/154640 [21:09:43] MatmaRex: that was a bit off an odd one to search for btw :) [21:09:45] yurikR1: And I spent a fair bit of time with windows users during the hackathon [21:09:47] (03PS1) 10Addshore: Use public instead of var in classes [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/154641 [21:09:53] bd808, i would love for windows to switch kernel to linux :) [21:09:56] (03PS1) 10Addshore: Use public instead of var in classes [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/154643 [21:10:02] (03PS1) 10Addshore: Use public instead of var in classes [extensions/News] - 10https://gerrit.wikimedia.org/r/154645 [21:10:09] (03PS1) 10Addshore: Use public instead of var in classes [extensions/OdbcDatabase] - 10https://gerrit.wikimedia.org/r/154647 [21:10:16] (03PS1) 10Addshore: Use public instead of var in classes [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/154648 [21:10:22] (03PS1) 10Addshore: Use public instead of var in classes [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/154650 [21:10:25] addshore: found any? i hope not [21:10:25] * bd808 imagines that would be a very cold day [21:10:29] (03PS1) 10Addshore: Use public instead of var in classes [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/154652 [21:10:32] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/154603 (owner: 10Addshore) [21:10:36] (03PS1) 10Addshore: Use public instead of var in classes [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/154654 [21:10:43] (03PS1) 10Addshore: Use public instead of var in classes [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/154655 [21:10:43] MatmaRex: take a closer look at the Colleciton extension [21:10:45] (03PS4) 10Bsitu: [4] Add revision local cache holder object [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154387 [21:10:48] ew [21:10:49] (03PS1) 10Addshore: Use public instead of var in classes [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/154657 [21:10:52] ew ew ew [21:10:55] (03PS1) 10Addshore: Use public instead of var in classes [extensions/ProtectSite] - 10https://gerrit.wikimedia.org/r/154658 [21:11:01] (03PS1) 10Addshore: Use public instead of var in classes [extensions/ReassignEdits] - 10https://gerrit.wikimedia.org/r/154660 [21:11:08] (03PS1) 10Addshore: Use public instead of var in classes [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/154662 [21:11:14] (03PS1) 10Addshore: Use public instead of var in classes [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/154663 [21:11:20] MatmaRex: actually no it looks good, thats not it [21:11:21] (03PS1) 10Addshore: Use public instead of var in classes [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/154665 [21:11:27] (03PS1) 10Addshore: Use public instead of var in classes [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/154666 [21:11:34] (03PS1) 10Addshore: Use public instead of var in classes [extensions/ScanSet] - 10https://gerrit.wikimedia.org/r/154668 [21:11:41] (03PS1) 10Addshore: Use public instead of var in classes [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/154669 [21:11:48] (03PS1) 10Addshore: Use public instead of var in classes [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/154671 [21:11:56] (03PS1) 10Addshore: Use public instead of var in classes [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/154673 [21:12:01] (03PS1) 10Addshore: Use public instead of var in classes [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/154674 [21:12:09] (03PS1) 10Addshore: Use public instead of var in classes [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/154676 [21:12:21] (03PS1) 10Addshore: Use public instead of var in classes [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/154680 [21:12:27] (03PS1) 10Addshore: Use public instead of var in classes [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/154681 [21:12:32] * Lcawte stabs grrrit-wm [21:12:35] (03PS1) 10Addshore: Use public instead of var in classes [extensions/Transliterator] - 10https://gerrit.wikimedia.org/r/154683 [21:12:40] Lcawte: :O [21:12:41] (03PS1) 10Addshore: Use public instead of var in classes [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/154685 [21:12:48] (03PS1) 10Addshore: Use public instead of var in classes [extensions/UploadLocal] - 10https://gerrit.wikimedia.org/r/154686 [21:12:49] at least its not pinging you ;p [21:12:54] (03PS1) 10Addshore: Use public instead of var in classes [extensions/Variables] - 10https://gerrit.wikimedia.org/r/154689 [21:13:01] (03PS1) 10Addshore: Use public instead of var in classes [extensions/Video] - 10https://gerrit.wikimedia.org/r/154691 [21:13:07] (03PS1) 10Addshore: Use public instead of var in classes [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/154692 [21:13:13] addshore: [21:13:13] addshore: [21:13:14] (03PS1) 10Addshore: Use public instead of var in classes [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/154694 [21:13:14] addshore: [21:13:15] addshore: [21:13:15] Should of arranged an op :P [21:13:16] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/154549 (owner: 10Addshore) [21:13:17] addshore: [21:13:19] addshore: [21:13:21] Reedy: [21:13:21] Reedy: [21:13:21] Reedy: [21:13:22] addshore: [21:13:22] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/154549 (owner: 10Addshore) [21:13:24] addshore: [21:13:26] addshore: [21:13:32] All done ;p [21:13:36] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/Blackout] - 10https://gerrit.wikimedia.org/r/154559 (owner: 10Addshore) [21:13:41] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/Blackout] - 10https://gerrit.wikimedia.org/r/154559 (owner: 10Addshore) [21:14:05] (03CR) 10Reedy: [C: 032] Use public instead of var in classes [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/154685 (owner: 10Addshore) [21:14:10] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/154685 (owner: 10Addshore) [21:14:12] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/154561 (owner: 10Addshore) [21:14:14] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/154562 (owner: 10Addshore) [21:14:16] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/154564 (owner: 10Addshore) [21:14:19] And more spam as the +2's role in. [21:14:20] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/154561 (owner: 10Addshore) [21:14:22] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/154567 (owner: 10Addshore) [21:14:24] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/154569 (owner: 10Addshore) [21:14:26] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/154562 (owner: 10Addshore) [21:14:28] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/Cite] - 10https://gerrit.wikimedia.org/r/154571 (owner: 10Addshore) [21:14:30] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/154564 (owner: 10Addshore) [21:14:32] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/154573 (owner: 10Addshore) [21:14:34] (03CR) 10Reedy: [C: 032] Use public instead of var in classes [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/154652 (owner: 10Addshore) [21:14:36] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/154573 (owner: 10Addshore) [21:14:37] i wonder how many are going to fail gate jobs [21:14:38] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/154575 (owner: 10Addshore) [21:14:40] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/154567 (owner: 10Addshore) [21:14:44] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/Cite] - 10https://gerrit.wikimedia.org/r/154571 (owner: 10Addshore) [21:14:46] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/154575 (owner: 10Addshore) [21:14:48] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/154652 (owner: 10Addshore) [21:14:50] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/154569 (owner: 10Addshore) [21:14:52] (03PS1) 10Addshore: Use public instead of var in classes [extensions/skins] - 10https://gerrit.wikimedia.org/r/154701 [21:14:54] (03CR) 10Reedy: [C: 032] Use public instead of var in classes [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/154625 (owner: 10Addshore) [21:14:55] MatmaRex: None! :P [21:14:59] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/154625 (owner: 10Addshore) [21:15:03] lol [21:15:10] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/154576 (owner: 10Addshore) [21:15:12] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/Comments] - 10https://gerrit.wikimedia.org/r/154578 (owner: 10Addshore) [21:15:14] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/154580 (owner: 10Addshore) [21:15:16] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/154582 (owner: 10Addshore) [21:15:17] no way jenkins is going to go through this many jobs without keeling over [21:15:18] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/154592 (owner: 10Addshore) [21:15:20] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/154594 (owner: 10Addshore) [21:15:22] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/Comments] - 10https://gerrit.wikimedia.org/r/154578 (owner: 10Addshore) [21:15:24] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/154580 (owner: 10Addshore) [21:15:26] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/DoubleWiki] - 10https://gerrit.wikimedia.org/r/154598 (owner: 10Addshore) [21:15:28] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/154582 (owner: 10Addshore) [21:15:30] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/154592 (owner: 10Addshore) [21:15:30] It's merging shit [21:15:30] MatmaRex: the jobs for the extensions take only a few seconds [21:15:32] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/154576 (owner: 10Addshore) [21:15:33] oh, not having agte jobs makes that simpler! [21:15:34] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/154600 (owner: 10Addshore) [21:15:36] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/154600 (owner: 10Addshore) [21:15:38] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/154601 (owner: 10Addshore) [21:15:40] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/ExpandTemplates] - 10https://gerrit.wikimedia.org/r/154605 (owner: 10Addshore) [21:15:42] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/154594 (owner: 10Addshore) [21:15:44] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/DoubleWiki] - 10https://gerrit.wikimedia.org/r/154598 (owner: 10Addshore) [21:15:46] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/ExpandTemplates] - 10https://gerrit.wikimedia.org/r/154605 (owner: 10Addshore) [21:15:48] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/154601 (owner: 10Addshore) [21:15:50] (03CR) 10Physikerwelt: [C: 032] Use public instead of var in classes [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/154637 (owner: 10Addshore) [21:15:52] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/154637 (owner: 10Addshore) [21:15:54] (03CR) 10Hashar: "Fine. Need rebase though." [core] - 10https://gerrit.wikimedia.org/r/154404 (owner: 10Addshore) [21:16:18] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/154654 (owner: 10Addshore) [21:16:20] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/154650 (owner: 10Addshore) [21:16:23] addshore: soooo. any hits for these files? [21:16:23] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/154654 (owner: 10Addshore) [21:16:25] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/OdbcDatabase] - 10https://gerrit.wikimedia.org/r/154647 (owner: 10Addshore) [21:16:27] if lets, logsplz [21:16:27] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/News] - 10https://gerrit.wikimedia.org/r/154645 (owner: 10Addshore) [21:16:29] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/154650 (owner: 10Addshore) [21:16:29] if yes* [21:16:31] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/154643 (owner: 10Addshore) [21:16:33] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/OdbcDatabase] - 10https://gerrit.wikimedia.org/r/154647 (owner: 10Addshore) [21:16:35] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/Math] - 10https://gerrit.wikimedia.org/r/154635 (owner: 10Addshore) [21:16:37] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/154641 (owner: 10Addshore) [21:16:39] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/News] - 10https://gerrit.wikimedia.org/r/154645 (owner: 10Addshore) [21:16:41] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/154640 (owner: 10Addshore) [21:16:42] addshore: if no, +2plz [21:16:42] MatmaRex: not that I could find [21:16:43] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/154639 (owner: 10Addshore) [21:16:45] Not even finished updaitng all my checked out repos [21:16:45] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/154643 (owner: 10Addshore) [21:16:47] Need to start again [21:16:47] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/154634 (owner: 10Addshore) [21:16:49] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/154641 (owner: 10Addshore) [21:16:51] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/154640 (owner: 10Addshore) [21:16:53] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/154634 (owner: 10Addshore) [21:16:55] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/154639 (owner: 10Addshore) [21:16:59] MatmaRex: link again? [21:17:03] https://gerrit.wikimedia.org/r/#/c/154525/ [21:17:10] (03PS2) 10Addshore: Fix phpcs errors in tests dir [core] - 10https://gerrit.wikimedia.org/r/154404 [21:17:37] (03CR) 10jenkins-bot: [V: 04-1] Fix phpcs errors in tests dir [core] - 10https://gerrit.wikimedia.org/r/154404 (owner: 10Addshore) [21:17:46] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/Math] - 10https://gerrit.wikimedia.org/r/154635 (owner: 10Addshore) [21:18:06] (03CR) 10Addshore: [C: 031] "Not found by me either" [core] - 10https://gerrit.wikimedia.org/r/154525 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [21:18:11] (03CR) 10Physikerwelt: "@fredw: I think this is one step towards simplifing the upgrade procedure for new MathJax vesions. Do you have any concerns?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [21:18:22] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/154648 (owner: 10Addshore) [21:18:25] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/154648 (owner: 10Addshore) [21:18:41] (03CR) 10Legoktm: "Add release notes maybe?" [core] - 10https://gerrit.wikimedia.org/r/154525 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [21:19:03] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/154666 (owner: 10Addshore) [21:19:05] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/154673 (owner: 10Addshore) [21:19:07] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/154671 (owner: 10Addshore) [21:19:09] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/154666 (owner: 10Addshore) [21:19:11] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/ScanSet] - 10https://gerrit.wikimedia.org/r/154668 (owner: 10Addshore) [21:19:13] (03PS4) 10Bsitu: [5] Code cleanup and miscellneous fix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154386 [21:19:16] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/154673 (owner: 10Addshore) [21:19:18] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/154671 (owner: 10Addshore) [21:19:20] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/ScanSet] - 10https://gerrit.wikimedia.org/r/154668 (owner: 10Addshore) [21:19:57] (03CR) 10Bartosz Dziewoński: "Legoktm, later, when it's clear what we're removing. I have too many independent patches that remove stuff from here right now." [core] - 10https://gerrit.wikimedia.org/r/154525 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [21:20:00] (03CR) 10Legoktm: "...what even is this repository?" [extensions/skins] - 10https://gerrit.wikimedia.org/r/154701 (owner: 10Addshore) [21:20:16] (03CR) 10Legoktm: [C: 032] "Okay." [core] - 10https://gerrit.wikimedia.org/r/154525 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [21:20:17] (03CR) 10Bartosz Dziewoński: "wut" [extensions/skins] - 10https://gerrit.wikimedia.org/r/154701 (owner: 10Addshore) [21:20:51] legoktm: MatmaRex ^^ some skins? ;p [21:20:53] extensions/skins is whatever was in SVN extensions/skins that isn't really maintained (because those got split into their own skins/ repos) [21:21:13] so can we just kill it? [21:21:42] 3MediaWiki / 3Skin and page rendering: Stop using inline for thumbnail magnify icon - 10https://bugzilla.wikimedia.org/69673#c2 (10James Forrester) (In reply to Bartosz Dziewoński from comment #0) > (Bug 65160 / [[mw:Thumbnail style update]] call for complete removal of the > icon, but it would only af... [21:22:11] Can you? You have +2 to extensions/ so yes... should you/are you allowed to/will anyone get mad? I have no idea... [21:22:37] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/154694 (owner: 10Addshore) [21:22:39] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/154692 (owner: 10Addshore) [21:22:41] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/Video] - 10https://gerrit.wikimedia.org/r/154691 (owner: 10Addshore) [21:22:43] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/Variables] - 10https://gerrit.wikimedia.org/r/154689 (owner: 10Addshore) [21:22:45] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/UploadLocal] - 10https://gerrit.wikimedia.org/r/154686 (owner: 10Addshore) [21:22:47] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/154692 (owner: 10Addshore) [21:22:49] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/154681 (owner: 10Addshore) [21:22:51] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/154694 (owner: 10Addshore) [21:22:53] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/154680 (owner: 10Addshore) [21:22:55] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/Video] - 10https://gerrit.wikimedia.org/r/154691 (owner: 10Addshore) [21:22:59] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/154676 (owner: 10Addshore) [21:23:01] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/Variables] - 10https://gerrit.wikimedia.org/r/154689 (owner: 10Addshore) [21:23:03] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/154674 (owner: 10Addshore) [21:23:05] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/154680 (owner: 10Addshore) [21:23:07] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/154665 (owner: 10Addshore) [21:23:09] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/154663 (owner: 10Addshore) [21:23:11] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/154662 (owner: 10Addshore) [21:23:13] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/154681 (owner: 10Addshore) [21:23:15] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/ReassignEdits] - 10https://gerrit.wikimedia.org/r/154660 (owner: 10Addshore) [21:23:17] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/UploadLocal] - 10https://gerrit.wikimedia.org/r/154686 (owner: 10Addshore) [21:23:19] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/ProtectSite] - 10https://gerrit.wikimedia.org/r/154658 (owner: 10Addshore) [21:23:23] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/154657 (owner: 10Addshore) [21:23:25] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/154676 (owner: 10Addshore) [21:23:27] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/154655 (owner: 10Addshore) [21:23:29] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/154674 (owner: 10Addshore) [21:23:31] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/MSSQLBackCompat] - 10https://gerrit.wikimedia.org/r/154632 (owner: 10Addshore) [21:23:33] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/ListSignup] - 10https://gerrit.wikimedia.org/r/154630 (owner: 10Addshore) [21:23:35] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/154629 (owner: 10Addshore) [21:23:37] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/154657 (owner: 10Addshore) [21:23:39] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/154608 (owner: 10Addshore) [21:23:41] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/ReassignEdits] - 10https://gerrit.wikimedia.org/r/154660 (owner: 10Addshore) [21:23:43] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/154662 (owner: 10Addshore) [21:23:45] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/154663 (owner: 10Addshore) [21:23:47] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/154665 (owner: 10Addshore) [21:23:49] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/154655 (owner: 10Addshore) [21:23:51] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/ProtectSite] - 10https://gerrit.wikimedia.org/r/154658 (owner: 10Addshore) [21:23:53] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/154629 (owner: 10Addshore) [21:23:55] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/ListSignup] - 10https://gerrit.wikimedia.org/r/154630 (owner: 10Addshore) [21:23:57] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/MSSQLBackCompat] - 10https://gerrit.wikimedia.org/r/154632 (owner: 10Addshore) [21:24:01] (03CR) 10Frédéric Wang: "I agree that it's best to have these files out of the MathJax/ directory. It's just that I don't know whether MathJax may have problems wi" [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [21:24:05] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/154669 (owner: 10Addshore) [21:24:44] (03Merged) 10jenkins-bot: Remove some unused files from skins/common/ [core] - 10https://gerrit.wikimedia.org/r/154525 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [21:24:57] (03CR) 10Frédéric Wang: "Perhaps to be 100% sure, ask on the MathJax mailing list if puting extension outside the MathJax/ directory is causing problems..." [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [21:25:02] (03PS3) 10BryanDavis: Move selection of nfs or native share to settings [vagrant] - 10https://gerrit.wikimedia.org/r/154153 (owner: 10EBernhardson) [21:25:04] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/154608 (owner: 10Addshore) [21:25:13] 3MediaWiki / 3Skin and page rendering: Stop using inline for thumbnail magnify icon - 10https://bugzilla.wikimedia.org/69673#c3 (10Bartosz Dziewoński) (In reply to James Forrester from comment #2) > At this point this artefact would become a Monobook-only item, right? Should > it be moved to that repo... [21:25:33] ori, bd808, what did you think of my proposal to populate vagrant MW with pages from files? Each file becomes a page. Makes it very easy to force vagrant to have needed pages/images [21:25:51] i think it should probably be done automatically [21:25:52] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/154669 (owner: 10Addshore) [21:26:12] for specialized pages (like ones for a paritcular extension) it can be done in the role class [21:26:20] there is already a resource type for it iirf [21:26:22] iirc [21:26:31] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/Transliterator] - 10https://gerrit.wikimedia.org/r/154683 (owner: 10Addshore) [21:26:33] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/154627 (owner: 10Addshore) [21:26:36] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/Interlanguage] - 10https://gerrit.wikimedia.org/r/154623 (owner: 10Addshore) [21:26:37] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/Insider] - 10https://gerrit.wikimedia.org/r/154622 (owner: 10Addshore) [21:26:40] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/154620 (owner: 10Addshore) [21:26:41] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/ImageLink] - 10https://gerrit.wikimedia.org/r/154615 (owner: 10Addshore) [21:26:43] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/HashTables] - 10https://gerrit.wikimedia.org/r/154613 (owner: 10Addshore) [21:26:45] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/154612 (owner: 10Addshore) [21:26:47] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/154610 (owner: 10Addshore) [21:26:49] (03CR) 10Legoktm: [C: 032] Use public instead of var in classes [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/154606 (owner: 10Addshore) [21:26:52] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/154620 (owner: 10Addshore) [21:26:53] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/Interlanguage] - 10https://gerrit.wikimedia.org/r/154623 (owner: 10Addshore) [21:26:55] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/154627 (owner: 10Addshore) [21:26:57] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/ImageLink] - 10https://gerrit.wikimedia.org/r/154615 (owner: 10Addshore) [21:26:58] yurikR1: What can't you do with mediawiki::import_dump? [21:26:59] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/Insider] - 10https://gerrit.wikimedia.org/r/154622 (owner: 10Addshore) [21:27:01] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/Transliterator] - 10https://gerrit.wikimedia.org/r/154683 (owner: 10Addshore) [21:27:03] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/HashTables] - 10https://gerrit.wikimedia.org/r/154613 (owner: 10Addshore) [21:27:05] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/154606 (owner: 10Addshore) [21:27:08] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/154610 (owner: 10Addshore) [21:27:10] ori, not sure what you mean about extension - my goal was to have a dir on the host that i could create tons of files/images in, and do a command like "vagrant add-files" to sync it [21:27:10] (03CR) 10Legoktm: [C: 032 V: 032] Use public instead of var in classes [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/154541 (owner: 10Addshore) [21:27:12] (03Merged) 10jenkins-bot: Use public instead of var in classes [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/154612 (owner: 10Addshore) [21:27:13] * addshore high fives legoktm [21:27:30] addshore: {{done}}! [21:27:55] bd808, you can do it with the import_dump, but import dump is much more complicated - you have to create a complex xml file or create many pages by hand in wiki and export them [21:28:01] plus it doesn't support images [21:28:19] oh ori https://bugzilla.wikimedia.org/show_bug.cgi?id=69505 is very annoying, we use that in Wikibase tests too :/ [21:28:20] my patch allowed a very simplistic approach - create files in a dir, and upload them all at once [21:29:30] but we still run PHPUnit 3.7.37 over there [21:29:50] addshore: yes, upstream is being dickish, imo [21:30:12] (03CR) 10BryanDavis: [C: 031] "I piddled with this a bit in patch set #3. I strongly endorse the idea of making this easier to disable for folks who have issues." [vagrant] - 10https://gerrit.wikimedia.org/r/154153 (owner: 10EBernhardson) [21:30:15] Lcawte: I'll request new repositories for those skins, and then empty out extensions/skins [21:30:28] bd808, https://gerrit.wikimedia.org/r/#/c/153819/ [21:30:33] addshore: i think they thought of deprecating as being a non-issue [21:30:43] 3MediaWiki extensions / 3CLDR: MWTimestamp::getHumanTimestamp() (aka timestamps in echo) not translated into Chechen - 10https://bugzilla.wikimedia.org/62607#c22 (10Umar) Thanks! [21:30:43] but i can't imagine we're the only ones that treat deprecations as errors [21:30:45] well, we could just override the deprecated implementation with the same implementation without the deprecation notice ori, and stick it in our MWTestCase, right now it doest what we want [21:30:48] legoktm: Cool, I just cloned the repo just in case. [21:30:49] *does what we want [21:30:57] YuviPanda suggested i place that script into core/maintenance [21:31:14] Now to compare cloning mediawiki/extensions with the time it took me to do so at Wikimania... [21:31:34] addshore that would be fine, or possibly turning off the option that causes the test suite to report deprecations as errors [21:31:43] i'm ok with it, but feel that it might not be very useful for non-vagrant users [21:32:06] heh ori if we turn off deprecations appearing as errors we will just have another surprise further down the line ;p [21:33:06] legoktm: Poke me when that's done, there might be a few easy commits there... :) [21:33:12] addshore: OK, but if you bundle it in MWTestCase, I'd at least add some note pointing to the GitHub issue, and make the case that we should migrate once the newer implementation is available [21:33:18] :P [21:33:37] (03CR) 10Theaitetos: [C: 032 V: 032] speed up revision-based queries (not)createdby and (not)modifiedby [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/151567 (owner: 10Theaitetos) [21:33:38] yurikR1: There must be existing maintenance scripts to load images. I know that Sam does that in prod. [21:33:50] Lcawte: https://www.mediawiki.org/w/index.php?title=Git/New_repositories/Requests/Entries&diff=prev&oldid=1109775 [21:34:33] Populating the wiki with some pages and images is a good thing, but I'm wary of making a bunch of new special code to do it [21:35:39] The mediawiki::import_dump functionality is there for managing xml dumps and we have a command to do that too [21:35:55] It sounds like images need some love [21:36:59] bad wifi :( [21:39:58] (03PS1) 10Addshore: Override phpunit assertTag method to stop errors [core] - 10https://gerrit.wikimedia.org/r/154703 (https://bugzilla.wikimedia.org/69505) [21:40:00] ori: ^^ [21:40:04] (03CR) 10BryanDavis: "It seems like the mediawiki::import_dump puppet resource and `vagrant import-dump` command handle half of this. I'm not buying the "dumps " [vagrant] - 10https://gerrit.wikimedia.org/r/153819 (owner: 10Yurik) [21:41:22] (03PS2) 10Ori.livneh: Override phpunit assertTag method to stop errors [core] - 10https://gerrit.wikimedia.org/r/154703 (https://bugzilla.wikimedia.org/69505) (owner: 10Addshore) [21:41:27] (03CR) 10Ori.livneh: [C: 032] Override phpunit assertTag method to stop errors [core] - 10https://gerrit.wikimedia.org/r/154703 (https://bugzilla.wikimedia.org/69505) (owner: 10Addshore) [21:45:07] (03CR) 10Physikerwelt: "All1 had discussed this change before with david." [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [21:45:13] (03Merged) 10jenkins-bot: Override phpunit assertTag method to stop errors [core] - 10https://gerrit.wikimedia.org/r/154703 (https://bugzilla.wikimedia.org/69505) (owner: 10Addshore) [21:45:18] :) [21:46:13] 3MediaWiki extensions / 3Math: Detected bug in an extension! Hook ParserAfterParse closure failed to return a value; should return true to continue hook processing or false to abort. - 10https://bugzilla.wikimedia.org/69646#c2 (10eisber) 5UNCO>3RESO/INV after upgrading to 1.23.1 (which I had to unmask on... [21:48:19] Yeah, so there are some commits that can be made to extensions/skins lol [21:48:42] (03CR) 10Physikerwelt: "See https://groups.google.com/forum/#!searchin/mathjax-users/amber/mathjax-users/LJMSiYw8YIY/ySgTtHGDoAAJ" [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [21:48:44] Lcawte: such as? I didnt obther looking :P [21:49:06] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2Fskins/fe268c20cf1834dccb54aac9a6f401b60f3e6ecd/Schulenburg%2FSchulenburg.php ... well, credits would be nice... RL as well by the looks of things [21:49:29] 3MediaWiki / 3Skin and page rendering: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277 (10Bartosz Dziewoński) [21:49:31] 3MediaWiki / 3Recent changes: EnhancedChangesList::arrow(), sideArrow(), downArrow(), spacerArrow() are silly methods and should be removed - 10https://bugzilla.wikimedia.org/69675 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None EnhancedChangesList::arrow(), sideArrow(), downArrow(), spacerAr... [21:50:14] 3MediaWiki / 3Recent changes: EnhancedChangesList::arrow(), sideArrow(), downArrow(), spacerArrow() are silly methods and should be removed - 10https://bugzilla.wikimedia.org/69675 (10Bartosz Dziewoński) [21:50:16] 3MediaWiki extensions / 3CleanChanges: CleanChanges should provide its own arrow images - 10https://bugzilla.wikimedia.org/69676 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None CleanChanges should provide its own arrow images. Currently it relies on EnhancedChangesList::arrow() and friends wh... [21:50:18] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2Fskins/fe268c20cf1834dccb54aac9a6f401b60f3e6ecd/Schulenburg%2FSchulenburg.class.php#L44 ... so that's not cool. Also, that skin looks like it's still a WIP lol [21:50:21] (03PS1) 10Yurik: Create wiki pages & images from files [core] - 10https://gerrit.wikimedia.org/r/154704 [21:53:21] *pulls all extensions again [21:57:05] (03CR) 10Yurik: "Copied the script to core. If approved there, will update this patch. See Change-Id: Iddd3c2301e302edfb529bac78ac91226d77876b8" [vagrant] - 10https://gerrit.wikimedia.org/r/153819 (owner: 10Yurik) [21:57:29] 3MediaWiki / 3Recent changes: Add hooks to make it possible for an extension to add more flags to changes lists, diffs, history printouts, etc. - 10https://bugzilla.wikimedia.org/69677 (10Nathan Larson) 3NEW p:3Unprio s:3normal a:3None MirrorTools needs to add flags to show which revisions originated... [21:57:37] (03PS3) 10Addshore: Fix phpcs errors in tests dir [core] - 10https://gerrit.wikimedia.org/r/154404 [21:58:58] (03PS1) 10Bartosz Dziewoński: Provide own arrow images and methods [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/154705 (https://bugzilla.wikimedia.org/69676) [21:59:27] (03CR) 10Legoktm: [C: 032] Fix phpcs errors in tests dir [core] - 10https://gerrit.wikimedia.org/r/154404 (owner: 10Addshore) [22:00:47] (03CR) 10Frédéric Wang: "OK, so perhaps a slightly cleaner way to do that would be to put the two js files in a separate mediawiki-extensions/ directory next to Ma" [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [22:02:09] (03CR) 10Bartosz Dziewoński: "(not tested)" [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/154705 (https://bugzilla.wikimedia.org/69676) (owner: 10Bartosz Dziewoński) [22:02:38] (03Merged) 10jenkins-bot: Fix phpcs errors in tests dir [core] - 10https://gerrit.wikimedia.org/r/154404 (owner: 10Addshore) [22:03:26] * ori watches https://travis-ci.org/wikimedia/mediawiki-core/builds/32804100 [22:03:34] could be our first passing test run on travis [22:05:46] (03PS6) 10Addshore: Add SpecialPageTestBase [core] - 10https://gerrit.wikimedia.org/r/153005 [22:09:24] (03PS1) 10Bartosz Dziewoński: Remove EnhancedChangesList::arrow() and friends [core] - 10https://gerrit.wikimedia.org/r/154706 (https://bugzilla.wikimedia.org/69675) [22:10:57] (03CR) 10Frédéric Wang: "and I would call the resource loader package "med"" (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [22:15:16] (03PS1) 10BryanDavis: Do not use symlink for LocalSettings.php [vagrant] - 10https://gerrit.wikimedia.org/r/154707 (https://bugzilla.wikimedia.org/69425) [22:15:28] yurikR1: ^ [22:15:54] (03PS2) 10BryanDavis: Do not use symlink for LocalSettings.php [vagrant] - 10https://gerrit.wikimedia.org/r/154707 (https://bugzilla.wikimedia.org/69425) [22:18:46] (03PS1) 10Addshore: Fix name of SpecialListFilesTest > ImageListPagerTest [core] - 10https://gerrit.wikimedia.org/r/154708 [22:20:38] (03PS1) 10Addshore: Remove unused private var and fix phpdoc [core] - 10https://gerrit.wikimedia.org/r/154709 [22:21:29] (03CR) 10Addshore: [C: 031] Remove EnhancedChangesList::arrow() and friends [core] - 10https://gerrit.wikimedia.org/r/154706 (https://bugzilla.wikimedia.org/69675) (owner: 10Bartosz Dziewoński) [22:22:07] bd808, windows has symlinks too - https://en.wikipedia.org/wiki/NTFS_symbolic_link [22:22:26] they are just not as common because fewer ppl use shell [22:22:28] 3MediaWiki / 3Skin and page rendering: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277 (10Bartosz Dziewoński) [22:22:29] 3Wikimedia / 3General/Unknown: Track down popular gadgets that refer to files in skins/common/ and fix them not to - 10https://bugzilla.wikimedia.org/69678 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None Track down popular gadgets that refer to files in skins/common/ and fix them not to. Pro... [22:23:22] bd808, but i can +2 - it passed [22:23:51] unless ori wants to review it [22:24:02] https://gerrit.wikimedia.org/r/#/c/154707 [22:24:59] i'm barely awake [22:25:00] oki, +2ing [22:25:09] just wait until tomorrow perhaps? [22:25:13] and then i'll look? [22:25:20] or does this break something that is badly fixed right now? [22:25:22] ori, no worries, its a minor fix that makes windows users much happier :) [22:25:24] yes [22:25:26] windows [22:25:28] all of it :) [22:25:41] bd808: what do you think; is it good to go? [22:25:43] vagrant has been broken on windows for the past 2 weeks [22:25:44] i don't mind [22:25:47] hehe [22:25:54] to have it merged, i mean [22:25:55] I just replaced a symlink with an exec that copies the file [22:26:11] that could be simple or not [22:26:12] If it worked for yurikR1 it should be good to go [22:26:21] ok, no objection from me then [22:26:35] go for it [22:27:27] (03CR) 10Yurik: [C: 032] Do not use symlink for LocalSettings.php [vagrant] - 10https://gerrit.wikimedia.org/r/154707 (https://bugzilla.wikimedia.org/69425) (owner: 10BryanDavis) [22:27:31] (03Merged) 10jenkins-bot: Do not use symlink for LocalSettings.php [vagrant] - 10https://gerrit.wikimedia.org/r/154707 (https://bugzilla.wikimedia.org/69425) (owner: 10BryanDavis) [22:27:49] The only other think I can think to do is to make a LocalSettings.php that just bootstraps to the /vagrant/LocalSettings.php file. [22:28:23] bd808, or you could use the mklink command [22:28:27] symlink in ntfs [22:29:07] We would have to know that the host fs is NTFS to do that [22:29:52] It would be even uglier puppet code [22:30:28] 3Wikimedia / 3General/Unknown: Track down popular gadgets that refer to files in skins/common/ and fix them not to - 10https://bugzilla.wikimedia.org/69678#c1 (10Bartosz Dziewoński) Created attachment 16223 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16223&action=edit mwgrep Arr_r, for contribsran... [22:30:50] And it wouldn't be compatible with XP. If I'm going to support windows I might as well support the most widely installed verison. :) [22:31:39] well, it appears there's some hhvm regression [22:31:41] fabulous [22:31:42] https://travis-ci.org/wikimedia/mediawiki-core/jobs/32804101 [22:32:26] (03PS6) 10Bartosz Dziewoński: Move installer files from skins/common/ to mw-config/ [core] - 10https://gerrit.wikimedia.org/r/153368 (https://bugzilla.wikimedia.org/69277) [22:32:37] (03PS4) 10Bartosz Dziewoński: Move mediawiki.legacy.* modules from skins/common/ to resources/ [core] - 10https://gerrit.wikimedia.org/r/153370 (https://bugzilla.wikimedia.org/69277) [22:33:24] ori: Are you using JIT with the hhvm test on purpose? [22:33:49] (03CR) 10Bartosz Dziewoński: [C: 04-2] "Need to give this more thought." [core] - 10https://gerrit.wikimedia.org/r/153370 (https://bugzilla.wikimedia.org/69277) (owner: 10Bartosz Dziewoński) [22:33:49] hmm any one know the media wiki api sandbox [22:33:50] i may have done so on purpose, yeah, since that is like how we'll run it in prod [22:33:55] but maybe it doesn't make sense [22:34:12] 3MediaWiki-Vagrant: Vagrant build/provison fails on Windows - Could not set 'link' on ensure: Protocol error - 10https://bugzilla.wikimedia.org/69425 (10Yuri Astrakhan) 5PATC>3RESO/FIX [22:34:16] I think i found an api bug [22:34:21] hey ori [22:34:28] hey MatmaRex [22:34:54] ori: you think i could convince you that https://bugzilla.wikimedia.org/show_bug.cgi?id=69673 is performace-related and therefore enlist your help? :P [22:35:13] OrenBochman: wouldn't be the first one ;) what in particular? [22:35:15] !ask [22:35:15] Please feel free to ask your question: if anybody who knows the answer is around, they will surely reply. Don't ask for help or for attention before actually asking your question, that's just a waste of time – both yours and everybody else's. :) [22:36:12] 3MediaWiki / 3Skin and page rendering: Stop using inline for thumbnail magnify icon - 10https://bugzilla.wikimedia.org/69673#c4 (10Ori Livneh) (In reply to Bartosz Dziewoński from comment #0) > Let's stop using inline for thumbnail magnify icon. According to bug > 69277 comment 11, there are 8761... [22:39:13] good night ori :) [22:39:15] (03CR) 10BryanDavis: Rethink multiwiki support (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/149872 (https://bugzilla.wikimedia.org/68605) (owner: 10BryanDavis) [22:42:00] good night [22:44:12] 3MediaWiki extensions / 3WikidataRepo: api wbeditentity sitelink already used doesn't tell you a siteid - 10https://bugzilla.wikimedia.org/52193 (10Ricordisamoa) [22:45:07] when creating a new section via the api - if the title param is supplied - the edit summary is discarded [22:48:55] can any1 confirm before i file a bug report [23:00:29] OrenBochman: Discarded? [23:00:41] If you make a new section, the == Title == goes into the edit summary. [23:08:01] look at https://en.wikipedia.org/w/index.php?title=Wikipedia:Sandbox&action=history [23:08:52] last edit has no summary - the param was ignored [23:09:40] no title in the summary either [23:10:23] no summary at all [23:27:57] 3MediaWiki-Vagrant: I get error message "No MWMultiVersion instance initialized!" when run phpunit tests - 10https://bugzilla.wikimedia.org/69520#c4 (10Bryan Davis) 5PATC>3RESO/FIX Both `vagrant run-tests` and direct use of `php tests/phpunit/phpunit.php` work for me now with the latest version of MediaWik... [23:29:12] 3Wikimedia / 3Site requests: Create Portal namespace for ko.wikisource - 10https://bugzilla.wikimedia.org/69522#c3 (10Vogone) Hm, google translate works pretty bad for that section. Could you possibly get another community member to confirm that consensus here? [23:29:43] (03CR) 10Legoktm: [WIP] Script to clean up manual user global.js/css pages (037 comments) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) (owner: 10Legoktm) [23:30:08] (03PS3) 10Legoktm: Script to clean up manual user global.js/css pages [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) [23:30:14] (03CR) 10jenkins-bot: [V: 04-1] Script to clean up manual user global.js/css pages [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) (owner: 10Legoktm) [23:30:59] 3Wikimedia / 3Site requests: Create "Affiliate" namespace on chapcom.wikimedia.org - 10https://bugzilla.wikimedia.org/69549 (10John F. Lewis) a:3John F. Lewis [23:31:02] (03PS4) 10Legoktm: Script to clean up manual user global.js/css pages [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) [23:41:49] (03PS5) 10Legoktm: Script to clean up manual user global.js/css pages [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/154441 (https://bugzilla.wikimedia.org/68933) [23:48:57] 3MediaWiki-Vagrant: mediawiki-vagrant reports an error when provisioning "browsertests" role - 10https://bugzilla.wikimedia.org/61285#c12 (10Bryan Davis) 5NEW>3RESO/FIX The browsertests role was removed entirely in I6a02788a42a5dcd58dc03ce845fedfe791da3bcb. If there are still issues with the various roles... [23:48:58] (03CR) 10Legoktm: [C: 04-1] "Needs https://gerrit.wikimedia.org/r/#/c/154447/ to be merged first." [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153535 (https://bugzilla.wikimedia.org/69318) (owner: 10Legoktm) [23:54:27] (03PS3) 10BryanDavis: git-update: Initialize and update submodules [vagrant] - 10https://gerrit.wikimedia.org/r/154383 (https://bugzilla.wikimedia.org/69641) (owner: 10Mattflaschen) [23:54:37] (03CR) 10BryanDavis: [C: 032] git-update: Initialize and update submodules [vagrant] - 10https://gerrit.wikimedia.org/r/154383 (https://bugzilla.wikimedia.org/69641) (owner: 10Mattflaschen) [23:54:42] (03Merged) 10jenkins-bot: git-update: Initialize and update submodules [vagrant] - 10https://gerrit.wikimedia.org/r/154383 (https://bugzilla.wikimedia.org/69641) (owner: 10Mattflaschen)