[00:00:51] (03CR) 10Jdlrobson: [C: 031] Add support to mark all as read for "sections" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153960 (owner: 10Bsitu) [00:01:12] 3MediaWiki extensions / 3CirrusSearch: Expose mwgrep functionality on-wiki - 10https://bugzilla.wikimedia.org/69489#c3 (10Kunal Mehta (Legoktm)) Is there a bug about replicating to labs? [00:03:35] (03CR) 10Helder.wiki: "Would it work if .done(...) were used instead of .then(...)?" [core] - 10https://gerrit.wikimedia.org/r/152839 (owner: 10Gerrit Patch Uploader) [00:04:05] (03PS1) 10Bsitu: Add support to retrieve unread + read notifcations for section [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153994 [00:04:36] who maintains grrrit-wm? [00:05:16] Would it be possible to change its code to get the author name instead of "Gerrit Patch Uploader"? [00:05:33] in a (CR) comment like the one above... [00:05:34] It might be [00:06:47] (03PS1) 10EBernhardson: Merge remote-tracking branch 'gerrit/master' into two_tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153995 [00:07:34] (03CR) 10Legoktm: [C: 04-1] "Need to set branch = ." [extensions] - 10https://gerrit.wikimedia.org/r/153862 (owner: 10Yurik) [00:07:46] helderwiki: YuviPanda|zzzz does [00:08:28] (03PS1) 10Jdlrobson: E2f: mark all as read behaviour [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153997 [00:08:48] (03CR) 10Bsitu: [C: 032] Merge remote-tracking branch 'gerrit/master' into two_tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153995 (owner: 10EBernhardson) [00:09:13] (03Merged) 10jenkins-bot: Merge remote-tracking branch 'gerrit/master' into two_tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153995 (owner: 10EBernhardson) [00:09:31] (03CR) 10Jdlrobson: [C: 04-1] "This is not tested and probably needs some more thinking" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153994 (owner: 10Bsitu) [00:10:24] (03PS5) 10Legoktm: Simplify Special:GlobalGroupMembership [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153743 (https://bugzilla.wikimedia.org/15651) (owner: 10Hoo man) [00:10:28] (03CR) 10Legoktm: [C: 032] Simplify Special:GlobalGroupMembership [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153743 (https://bugzilla.wikimedia.org/15651) (owner: 10Hoo man) [00:10:41] (03Merged) 10jenkins-bot: Simplify Special:GlobalGroupMembership [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153743 (https://bugzilla.wikimedia.org/15651) (owner: 10Hoo man) [00:10:47] 3MediaWiki extensions / 3CirrusSearch: Expose mwgrep functionality on-wiki - 10https://bugzilla.wikimedia.org/69489#c4 (10Helder) I don't think so. We talked about it on IRC[1] but no one created a bug, AFAIK [1] http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-dev/20140809.txt [00:10:47] 3MediaWiki / 3Parser: Internal page and file links that look like urls render as external links (e.g. [[http://]] or [[file:Example.svg]]) - 10https://bugzilla.wikimedia.org/44011 (10Alex Monk) [00:11:49] legoktm: \o/ [00:12:10] :D [00:12:27] 3MediaWiki extensions / 3CentralAuth: GlobalUserRights defaults to Meta but does not work unless changed to a different wiki - 10https://bugzilla.wikimedia.org/15651 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Marius Hoch [00:12:44] (03PS1) 10Jack Phoenix: Lots and lots of refactoring of the theme system to make the themes work properly. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153999 [00:13:08] (03CR) 10Jack Phoenix: [C: 032 V: 032] Lots and lots of refactoring of the theme system to make the themes work properly. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153999 (owner: 10Jack Phoenix) [00:15:33] (03PS3) 10Yurik: Added Graph extension. [extensions] - 10https://gerrit.wikimedia.org/r/153862 [00:16:25] (03PS3) 10Bsitu: Add support to mark all as read for "sections" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153960 [00:17:24] (03CR) 10Yurik: "I added a topic (branch is still master - this repo doesn't seem to have version branches). I don't think sorting is a good idea - that fi" [extensions] - 10https://gerrit.wikimedia.org/r/153862 (owner: 10Yurik) [00:18:10] (03CR) 10Legoktm: [C: 031] "I would feel more comfortable merging just the removal of the RecentChange methods and not the globals which are cheap to support." [core] - 10https://gerrit.wikimedia.org/r/150762 (owner: 10Withoutaname) [00:19:21] legoktm, replied ^ [00:20:47] (03PS1) 10Jack Phoenix: Add grey theme, remove broken dark theme & some old files. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/154000 [00:21:16] 3Wikimedia / 3Extension setup: Security review BounceHandler extension for deployement - 10https://bugzilla.wikimedia.org/69099 (10Chris Steipp) 5PATC>3RESO/FIX [00:21:56] (03CR) 10Jack Phoenix: [C: 032 V: 032] Add grey theme, remove broken dark theme & some old files. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/154000 (owner: 10Jack Phoenix) [00:27:41] (03PS1) 10Helder.wiki: Revert "Load ext.wikiLove.local via module dependencies" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/154002 [00:29:54] (03PS2) 10Legoktm: Revert "Load ext.wikiLove.local via module dependencies" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/154002 (https://bugzilla.wikimedia.org/69356) (owner: 10Helder.wiki) [00:30:06] (03CR) 10Legoktm: [C: 032] Revert "Load ext.wikiLove.local via module dependencies" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/154002 (https://bugzilla.wikimedia.org/69356) (owner: 10Helder.wiki) [00:30:13] (03Merged) 10jenkins-bot: Revert "Load ext.wikiLove.local via module dependencies" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/154002 (https://bugzilla.wikimedia.org/69356) (owner: 10Helder.wiki) [00:41:19] hoo: did you see https://gerrit.wikimedia.org/r/#/c/153979/ ? [00:45:44] legoktm: Yeah, but didn't yet look at the code [00:45:48] ok [00:45:51] it's bad :/ [00:46:03] (03CR) 10Ori.livneh: [C: 032] Avoid a few notices if proc_open() fails [services/jobrunner] - 10https://gerrit.wikimedia.org/r/153889 (owner: 10Aaron Schulz) [00:46:05] (03Merged) 10jenkins-bot: Avoid a few notices if proc_open() fails [services/jobrunner] - 10https://gerrit.wikimedia.org/r/153889 (owner: 10Aaron Schulz) [00:46:50] :S [00:49:38] legoktm: What is {{USERNAME:...}}? [00:50:00] a fake parserfunction that'll only work in edit summaries [00:50:13] o.O [00:50:16] fake? [00:51:05] fake in the sense that it's not a real parserfunction, it's just a regex implementation. [00:51:07] the bug has more details [00:52:42] everything about that commit sounds.... ew [00:53:19] Also does someone want to implement the gadget part of https://bugzilla.wikimedia.org/show_bug.cgi?id=69501 ? [00:58:22] I'm not 100% clear that I can do it (as a volunteer), because I dealt with that bug as part of my job, so... [01:00:22] search for a mediawik bug, Google returns matches on osdir.com with autoplaying video ads. All because bugzilla.wikimedia.org's robots.txt blocks search :( [01:06:10] legoktm: why not just make it a real parser function? [01:06:21] because edit summaries don't actually go through the parser [01:06:44] 3MediaWiki extensions / 3ApiSandbox: CirrusSearch appears twice on [[Special:ApiSandbox]] - 10https://bugzilla.wikimedia.org/69517 (10Helder) 3NEW p:3Unprio s:3normal a:3None Go to https://en.wikipedia.org/wiki/Special:ApiSandbox#action=query&list=search and click on "srbackend". There will be three... [01:06:45] d'oh. right. [01:11:56] 3MediaWiki / 3History/Diffs: "Contributions this user made around this time" links in history and diff views - 10https://bugzilla.wikimedia.org/7566#c3 (10Helder) See also https://de.wikipedia.org/wiki/MediaWiki:Gadget-revisionjumper.js for a few features which may help navigating in the history of a page. [01:14:11] 3MediaWiki extensions / 3ApiSandbox: CirrusSearch appears twice on [[Special:ApiSandbox]] - 10https://bugzilla.wikimedia.org/69517#c1 (10Max Semenik) I see only 2 options. What browser are you using? [01:14:43] (03Abandoned) 10Legoktm: API: Allow user to specify what notification types they want or don't want [extensions/Echo] - 10https://gerrit.wikimedia.org/r/137246 (https://bugzilla.wikimedia.org/57043) (owner: 10Legoktm) [01:17:23] (03CR) 10Legoktm: "Sorry, missed your comment. Yes, on this coming Thursday when wmf16 is on all WMF wikis we plan on undeploying the WikimediaShopLink exten" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/149785 (https://bugzilla.wikimedia.org/55678) (owner: 10Legoktm) [01:18:41] 3MediaWiki extensions / 3ApiSandbox: CirrusSearch appears twice on [[Special:ApiSandbox]] - 10https://bugzilla.wikimedia.org/69517#c2 (10Helder) Firefox 31.0 and Google Chrome 36.0.1985.143. [01:21:11] 3MediaWiki extensions / 3ApiSandbox: CirrusSearch appears twice on [[Special:ApiSandbox]] - 10https://bugzilla.wikimedia.org/69517#c3 (10Helder) It is caused by enabling the beta feature "New search" on https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-betafeatures (the problem also disappears... [01:23:27] helderwiki: should we get the wikilove thing backported? [01:24:22] backported to where? (I don't think it is urgent) [01:24:52] 1.24wmf16 [01:24:56] ok then [01:25:04] (03CR) 10PleaseStand: [C: 04-1] "-1 for docs (see inline)." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/153944 (owner: 10Aaron Schulz) [01:27:10] there's something about that change that really bothers me, that i really don't like, and i don't know what it is (not the fake parser function) [01:28:37] legoktm: thinkgin about it, if we backport it today it could go live to all Wikipedias tomorow, right? [01:29:21] well the next deployment window is tomorrow morning, so it'll hit all non-wikipedias then, and when Reedy does deployment it'll hit all the wikipedias [01:29:26] if it is something quick to do, maybe we should just do it instead of leaving it broken for one more week [01:29:27] (03CR) 10Legoktm: [C: 04-1] "Sorry, needs rebase after the Config changes. Will +2 afterwards." [core] - 10https://gerrit.wikimedia.org/r/84194 (owner: 10TTO) [01:32:54] (03CR) 10Legoktm: [C: 04-1] "Needs rebase" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/138745 (https://bugzilla.wikimedia.org/21206) (owner: 10Gerrit Patch Uploader) [01:35:23] (03CR) 10Alex Monk: "See I92031c90" [core] - 10https://gerrit.wikimedia.org/r/83918 (owner: 10Anomie) [01:38:14] 3Wikimedia / 3General/Unknown: adminisrators spelling error - 10https://bugzilla.wikimedia.org/69518 (10JB) 3UNCO p:3Unprio s:3trivia a:3None In the English-language Wikipedia, when a page has been blocked from creation, the following message appears: "This page is protected from creation, so only ad... [01:41:31] jackmcbarn: yes, it makes me uncomfortable too [01:46:56] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch appears twice in srbackend paraminfo - 10https://bugzilla.wikimedia.org/69517#c4 (10Max Semenik) Aha, that's what paraminfo returns: https://en.wikipedia.org/wiki/Special:ApiSandbox#action=paraminfo&format=json&querymodules=search So it's a CirrusSearch pr... [01:47:26] 3MediaWiki extensions / 3FundraisingChart: Security review for mediawiki/extensions/FundraisingChart - 10https://bugzilla.wikimedia.org/66805#c5 (10Chris Steipp) Hi Sherah, It's a little difficult to do a thorough review because I keep hitting bugs with the version in gerrit, but there are a couple of desig... [01:56:02] legoktm, about? [01:56:11] yes [01:56:20] Mind giving me var_dump( SearchEngine::getSearchTypes() ); ? [01:56:49] any specific wiki? [01:57:11] hm. enwiki should do [01:57:22] array(2) { [01:57:22] [0]=> [01:57:22] string(12) "LuceneSearch" [01:57:22] [1]=> [01:57:22] string(12) "CirrusSearch" [01:57:24] } [02:02:45] (03Abandoned) 10AndyRussG: Make DatabaseSqlite support creating temp tables [core] - 10https://gerrit.wikimedia.org/r/133950 (owner: 10AndyRussG) [02:22:31] (03CR) 10Werdna: [C: 031] "+1, I would +2 but I know you're waiting for DannySignoff." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153789 (owner: 10Matthias Mullie) [02:37:56] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch appears twice in srbackend paraminfo - 10https://bugzilla.wikimedia.org/69517#c5 (10Alex Monk) Looks like we just need to get rid of any 'CirrusSearch' entry(ies?) from $wgSearchTypeAlternatives when the BetaFeature is enabled in CirrusSearch\Hooks::initial... [02:38:26] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c18 (10MZMcBride) (In reply to Eran Roz from comment #13 and comment #14) > I just runned a simple phantomjs script on all wikipedia languages to catch >... [02:46:07] helderwiki: https://dpaste.de/abNS/raw :/ [02:46:27] 188? [02:46:28] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c19 (10MZMcBride) (In reply to Stefan2 from comment #16) > I think that the problem is that the MediaWiki namespace can be edited by > any administrator.... [02:46:36] =/ [02:46:54] legoktm: hey, could you run a few other greps? [02:47:01] sure [02:47:54] Carmela: I think once we have sane configuration, we could kill the MediaWiki namespace. [02:48:22] local message overrides could go in configuration, and we would move JS/CSS to Gadget: namespace [02:49:28] legoktm: each of these: "ws_messages", "ws_msg", "get_elements_by_classname", "get_optlist", "SetCookie", "GetCookie", "OptionText", "displayOptionText", "easy_lst" and "easy_lst_setup" [02:49:46] (I believe these are only used on Wikisources) [02:49:57] do you want one massive (foo|bah|buz) grep or individual ones? [02:50:17] I would prefer individual uses, but it is not urgent. [02:51:25] BTW: the mw-grep could be improved to output the string which matches the given regex (then (foo|bar) would suffice) [02:51:41] e.g.: frwiki MediaWiki:Common.js foo [02:51:52] e.g.: plwikisource MediaWiki:Common.js bar [02:52:16] hmm, I'll look at the code to see if it's possible [02:52:40] ah, and for the list above, could you allow both MediaWiki and User namespaces? [02:57:13] sure [02:58:10] legoktm: how would we handle things like spam-blacklist and titleblacklist and bad image list and all the other "messages" that admins regularly edit? [02:58:39] blacklists go to a custom contenthandler format, bad image list is moved to an extension and same thing [02:58:52] ok, what about abuse filter custom warnings? [02:59:29] some new namespace. There's a bug open about people who can edit AF rules but can't create new messages because they don't have 'editinterface' [03:00:59] just being devil's advocate: there are things that really are "messages" that get edited a lot, like deletereason-dropdown [03:01:32] sure, and those should really be configuration options instead of localization messages [03:01:38] and i can see wikis doing with all of their messages like we do to https://en.wikipedia.org/wiki/MediaWiki:Noarticletext in protest of this [03:01:40] FYI: the bug is https://bugzilla.wikimedia.org/show_bug.cgi?id=41838 [03:02:09] (warning: viewing that page will confuse you for a moment) [03:02:11] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c20 (10MZMcBride) (In reply to Gilles Dubuc from comment #7) > The fact that people who aren't developers and/or who don't understand what > custom JS the... [03:04:11] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c21 (10MZMcBride) (In reply to Brad Jorsch from comment #9) > (In reply to MZMcBride from comment #6) >> Code is the enemy; less code is better. Rather th... [03:04:32] legoktm: when you are looking in the code of mw-grep, check if it can sort the results by database name (to group wikis in the same language) [03:05:26] sigh, I just made a mistake [03:05:35] I used > instead of >> [03:06:35] (03PS5) 10Pastakhov: add object ExtSQI as a wrapper of SemanticQueryInterface extension (v 1.1.0) [extensions/PhpTagsSMW] - 10https://gerrit.wikimedia.org/r/152930 [03:06:58] * legoktm re-runs everything [03:07:53] legoktm: Shell redirection? [03:07:58] yes [03:08:41] (03CR) 10Pastakhov: [C: 031] "Unfortunately, I myself can not verify this, but it should work" [extensions/PhpTagsSMW] - 10https://gerrit.wikimedia.org/r/152930 (owner: 10Pastakhov) [03:08:49] Yeah, I was looking that up today. [03:08:57] I don't like the 0, 1, 2 shit. [03:08:57] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c22 (10MZMcBride) (In reply to C. Scott Ananian from comment #8) > I think that extensions and gadgets are probably the "right" way to make > sitewide cha... [03:09:02] 2&>1 blergh. [03:09:33] helderwiki: https://noc.wikimedia.org/~legoktm/helder.log should be everything [03:09:55] great! :-) [03:10:26] https://github.com/wikimedia/operations-puppet/blob/production/files/misc/scripts/mwgrep is the source code btw [03:12:57] sorting shouldn't be too hard, lets see [03:13:11] could you run three other greps? "page_ns_prefixes", "index_ns_prefixes", "pr_fix_page_headers" [03:13:25] (just to double check this removal of code: https://wikisource.org/w/index.php?title=MediaWiki:Base.js&diff=cur&oldid=390072 ) [03:15:03] helderwiki: https://dpaste.de/uCm8/raw [03:15:15] thanks [03:16:48] (03CR) 10Pastakhov: "JoelKP: well, I just do not know the level of your skills :-)" [extensions/PhpTagsSMW] - 10https://gerrit.wikimedia.org/r/153787 (owner: 10JoelKP) [03:20:08] (03CR) 10Jackmcbarn: "If we decide to do one of those first two things, we should do it first and then this." [core] - 10https://gerrit.wikimedia.org/r/153833 (owner: 10Umherirrender) [03:35:27] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c23 (10Alex Monk) (In reply to MZMcBride from comment #19) > Err, most of the MediaWiki namespace isn't JavaScript and CSS, it's > interface messages. The... [03:38:11] 3MediaWiki extensions / 3OAuth: Installation documentation should explain memcached - 10https://bugzilla.wikimedia.org/69499#c1 (10Mitar) (Taking back, SQLite works only with one consumer.) [03:42:36] (03PS1) 10Mitar: Do a full-screen dialog if querystring contains "fullscreen". [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/154007 [03:43:26] 3MediaWiki extensions / 3OAuth: Provide a way to open OAuth authorization dialog over whole page - 10https://bugzilla.wikimedia.org/69246#c3 (10Mitar) Made a pull request: https://gerrit.wikimedia.org/r/154007 [03:43:52] (03PS1) 10Wctaiwan: [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 [03:44:05] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 (owner: 10Wctaiwan) [03:46:36] (03PS8) 10Jackmcbarn: Add a Lua library to get stability settings [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/132956 [03:46:41] 3MediaWiki / 3General/Unknown: "MediaWiki:Copyright" message allows raw HTML - 10https://bugzilla.wikimedia.org/43646 (10MZMcBride) [03:50:49] (03PS2) 10Legoktm: [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 (owner: 10Wctaiwan) [03:51:01] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 (owner: 10Wctaiwan) [03:54:41] 3Wikimedia / 3Shop: shop.wikimedia.org should be HTTPS only - 10https://bugzilla.wikimedia.org/37790#c18 (10Elliott Eggleston) I fixed what pages I could, making all links https where the destination supports it, and making the one img tag I saw protocol relative. I don't see where the share/like buttons ar... [03:55:41] (03PS1) 10Pastakhov: add T_ONUMBER token for HHVM (v 3.4.1) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/154010 [03:57:06] (03CR) 10Pastakhov: [C: 032] add T_ONUMBER token for HHVM (v 3.4.1) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/154010 (owner: 10Pastakhov) [03:57:12] (03Merged) 10jenkins-bot: add T_ONUMBER token for HHVM (v 3.4.1) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/154010 (owner: 10Pastakhov) [04:18:09] (03PS3) 10Wctaiwan: [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 [04:18:17] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 (owner: 10Wctaiwan) [04:42:36] (03PS4) 10Legoktm: [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 (owner: 10Wctaiwan) [04:42:47] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 (owner: 10Wctaiwan) [05:26:58] 3MediaWiki-Vagrant: I get error message "No MWMultiVersion instance initialized!" when run phpunit tests - 10https://bugzilla.wikimedia.org/69520 (10Pavel (pastakhov)) 3NEW p:3Unprio s:3normal a:3Ori Livneh When I run command: > vagrant run-tests I get error message: No MWMultiVersion instance initiali... [06:23:16] 3MediaWiki extensions / 3Math: generate MathML (not PNG) and automatically embed hyperlinks for each symbol - 10https://bugzilla.wikimedia.org/69424#c12 (10Richard Baxter) CORRECTION: "Although Math extension REL1.23.2 was giving a blank screen.." [06:26:45] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Index not updated automatically - 10https://bugzilla.wikimedia.org/69387#c3 (10keyler) Hallo Nik, no it does not. runJobs.php just picks up CirrusSearch. I am on mw1.23.2 and on these wikis I use the CirrusSeach Extension for 1.23.x (not master). This is... [06:27:15] 3MediaWiki extensions / 3Collection: Almost any image makes the PDF rendering crash - 10https://bugzilla.wikimedia.org/68929#c10 (10Nemo) Zweiter Weltkrieg, linked above, also fails. [06:28:47] 3MediaWiki extensions / 3Collection: New PDF renderer: [[en:Integral]] fails. - 10https://bugzilla.wikimedia.org/68835#c3 (10Nemo) I note the page contains svg, gif and png images. [06:29:41] 3MediaWiki extensions / 3Collection: Special:Book unparsed HTML error message - 10https://bugzilla.wikimedia.org/68991#c3 (10Nemo) Still seen. A cached version of the document has been found, so no rendering was necessary. (03CR) 10Nikerabbit: [C: 04-1] Removed LCStoreDB class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153944 (owner: 10Aaron Schulz) [06:42:57] (03PS4) 10Nemo bis: Removed LCStoreDB class [core] - 10https://gerrit.wikimedia.org/r/153944 (owner: 10Aaron Schulz) [06:46:57] (03CR) 10Nikerabbit: "From my experience getting the file permissions set correctly for the cache folder is a real pain. Often you end up getting exceptions bec" [core] - 10https://gerrit.wikimedia.org/r/153944 (owner: 10Aaron Schulz) [06:57:28] 3MediaWiki extensions / 3OAuth: Installation documentation should explain memcached - 10https://bugzilla.wikimedia.org/69499 (10Andre Klapper) s:5normal>3enhanc [06:57:28] 3MediaWiki / 3Documentation: Documentation is out of date, incomplete (tracking) - 10https://bugzilla.wikimedia.org/1 (10Andre Klapper) [06:59:32] (03CR) 10Nemo bis: Enabled $wgUseLinkNamespaceDBFields (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153634 (owner: 10Aaron Schulz) [07:17:56] 3MediaWiki extensions / 3CirrusSearch: The search backend returned an error - 10https://bugzilla.wikimedia.org/69491#c2 (10bennylin) You mean you couldn't reproduce the bug? I don't know which beta you're referring to, or lsearchd. [07:33:57] 3MediaWiki extensions / 3Collection: Reduce density from 600 ppi/dpi - 10https://bugzilla.wikimedia.org/68576#c2 (10Nemo) Created attachment 16190 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16190&action=edit Chess oversized PDF (In reply to C. Scott Ananian from comment #1) > which cause xelatex... [07:37:41] 3MediaWiki extensions / 3Collection: Reduce density from 600 ppi/dpi - 10https://bugzilla.wikimedia.org/68576#c3 (10Nemo) Created attachment 16191 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16191&action=edit Comet Also [[Comet]] is too big, at 2 MB. Is the first image really 5.6 megapixels? [07:48:26] 3MediaWiki extensions / 3Translate: Add {{#translation}} as parser function in the Translate extension - 10https://bugzilla.wikimedia.org/68385 (10Nemo) [07:52:41] (03CR) 10Lokal Profil: [C: 031] i18n: fix "security-desc-LS" [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/153771 (owner: 10Shirayuki) [08:17:19] (03CR) 10Tim Starling: [C: 04-2] "This is the best compression code we have, I don't know why you would want to delete it. If anyone wanted to compress a wiki, this would b" [core] - 10https://gerrit.wikimedia.org/r/84770 (owner: 10Chad) [08:21:14] (03PS1) 10Snail: Send email from $wgPasswordSender instead of user's email [extensions/InviteSignup] - 10https://gerrit.wikimedia.org/r/154017 [08:21:46] (03CR) 10Tim Starling: "Is there a bug report or some other sort of description of the transaction/unit test issue?" [core] - 10https://gerrit.wikimedia.org/r/153944 (owner: 10Aaron Schulz) [08:25:32] (03CR) 10Snail: "Thanks, Lewis! I needed this change to get the extension working on my wiki, and your patch was really close to working but needed to use " [extensions/InviteSignup] - 10https://gerrit.wikimedia.org/r/154017 (owner: 10Snail) [08:29:12] 3Wikimedia / 3Site requests: Create Portal namespace for ko.wikisource - 10https://bugzilla.wikimedia.org/69522#c1 (10salamander724) Please create following namespaces for ko.wikisource 포털 (Portal) 포털토론 (Portal talk) Thank you. [08:30:43] (03PS1) 10Nuria: Bumping up version of wikimetrics module in vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/154018 [08:46:56] 3Wikimedia / 3General/Unknown: adminisrators spelling error in "This page is protected from creation, so only adminisrators can create it." on en.wp - 10https://bugzilla.wikimedia.org/69518#c1 (10Andre Klapper) p:5Unprio>3Low Thanks for taking the time to report this! Now I just need to find out where t... [08:48:48] (03CR) 10Paladox: "Ok." [extensions/InterwikiExistence] - 10https://gerrit.wikimedia.org/r/153767 (owner: 10Paladox) [08:49:12] (03Abandoned) 10Paladox: Move file to git [extensions/InterwikiExistence] - 10https://gerrit.wikimedia.org/r/153767 (owner: 10Paladox) [08:50:07] (03PS19) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [08:50:20] (03PS14) 10Paladox: WikiEditor: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 [08:50:32] (03PS14) 10Paladox: Update Moment.js from 2.7.0 to 2.8.1 [core] - 10https://gerrit.wikimedia.org/r/151630 [08:57:13] (03CR) 10Matthias Mullie: New topic notifications for watchers of a board. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [09:08:06] (03PS2) 10Nemo bis: Send email from $wgPasswordSender instead of user's email [extensions/InviteSignup] - 10https://gerrit.wikimedia.org/r/154017 (owner: 10Snail) [09:10:54] (03CR) 10Nemo bis: "Thanks Snail for the patch. Note that usually we'd amend the existing patch: https://www.mediawiki.org/wiki/Git/Tutorial#Amending_a_change" [extensions/InviteSignup] - 10https://gerrit.wikimedia.org/r/154017 (owner: 10Snail) [09:13:06] (03CR) 10Snail: "Ah - I see how that would have simplified things. Thank you for pointing that out! :)" [extensions/InviteSignup] - 10https://gerrit.wikimedia.org/r/154017 (owner: 10Snail) [09:34:46] (03PS1) 10Pastakhov: use STATIC function PhpTags\Compiler::compile() (v 3.4.2) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/154022 [09:35:13] 3MediaWiki extensions / 3Diff: [HHVM] Tests on Travis are failing - 10https://bugzilla.wikimedia.org/69524 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3None This is due to the PHPUnit version used. [09:36:28] 3MediaWiki extensions / 3WikibaseQueryEngine: [HHVM] Tests for WikibaseDataModel on Travis are failing - 10https://bugzilla.wikimedia.org/69525 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs This is due to the PHPUnit version used. [09:36:42] 3MediaWiki extensions / 3WikidataRepo: [HHVM] Tests for WikibaseDataModel on Travis are failing - 10https://bugzilla.wikimedia.org/69525 (10tobias.gritschacher) [09:37:58] 3MediaWiki extensions / 3WikibaseQueryEngine: [HHVM] Tests on Travis are failing - 10https://bugzilla.wikimedia.org/69526 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs This is due to a DBAL compatibility issue which still exists on master of DBAL. [09:43:11] 3MediaWiki extensions / 3CirrusSearch: The search backend returned an error - 10https://bugzilla.wikimedia.org/69491#c3 (10Andre Klapper) Can neither reproduce with https://en.wikipedia.org/w/index.php?title=Special%3ASearch&search=on+the+news&fulltext=Search?srbackend=CirrusSearch nor with https://en.wikipe... [09:44:11] 3Wikimedia / 3Site requests: Create Portal namespace for ko.wikisource - 10https://bugzilla.wikimedia.org/69522#c2 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc Please provide a link to community consensus. [09:45:29] 3MediaWiki extensions / 3ProofreadPage: The editing interface of Page: pages with WikiEditor is broken in 1.24wmf16 - 10https://bugzilla.wikimedia.org/69327 (10Andre Klapper) [09:45:29] 3MediaWiki / 3General/Unknown: Edit box disappeared on Polish Wikisource proofread pages - 10https://bugzilla.wikimedia.org/69446#c6 (10Andre Klapper) 5RESO/WOR>3RESO/FIX Ah, thanks! [09:46:07] (03PS2) 10Pastakhov: use STATIC function PhpTags\Compiler::compile() (v 3.4.2) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/154022 [09:50:05] (03PS3) 10Pastakhov: use STATIC function PhpTags\Compiler::compile() (v 3.4.2) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/154022 [09:52:22] (03CR) 10Pastakhov: [C: 032] use STATIC function PhpTags\Compiler::compile() (v 3.4.2) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/154022 (owner: 10Pastakhov) [09:52:28] (03Merged) 10jenkins-bot: use STATIC function PhpTags\Compiler::compile() (v 3.4.2) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/154022 (owner: 10Pastakhov) [09:56:07] (03PS1) 10Paladox: Update jquery.ui Vector theme to 1.9.2 [skins/Vector] - 10https://gerrit.wikimedia.org/r/154024 [09:56:18] (03PS2) 10Paladox: Update jquery.ui Vector theme to 1.9.2 [skins/Vector] - 10https://gerrit.wikimedia.org/r/154024 [09:56:57] (03Abandoned) 10Paladox: Update jquery.ui Vector theme to 1.9.2 [core] - 10https://gerrit.wikimedia.org/r/150545 (owner: 10Paladox) [10:00:52] (03PS37) 10Paladox: Update jquery.chosen folder and files [core] - 10https://gerrit.wikimedia.org/r/139699 (https://bugzilla.wikimedia.org/69065) [10:10:16] (03PS35) 10Paladox: Update jquery.validate from 1.8.1 to 1.9.0 [core] - 10https://gerrit.wikimedia.org/r/145311 [10:10:36] (03PS36) 10Paladox: Update jquery.validate from 1.8.1 to 1.9.0 [core] - 10https://gerrit.wikimedia.org/r/145311 [10:13:24] (03CR) 10Fomafix: "With .done() instead of .then() the returned promise belongs to mw.loader.using() instead of mw.notification.notify(). The message gets sh" [core] - 10https://gerrit.wikimedia.org/r/152839 (owner: 10Gerrit Patch Uploader) [10:17:59] (03PS70) 10Paladox: Update jquery.hoverIntent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [10:18:16] (03PS71) 10Paladox: Update jquery.hoverIntent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [10:18:32] (03PS72) 10Paladox: Update jquery.hoverIntent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [10:18:39] PS72? [10:18:42] ... [10:18:53] 3 more within 33 seconds [10:20:10] Reedy: what is the current record? [10:20:33] who can run the category re-sorting script? [10:21:54] because of new collation [10:26:40] Still needs ops input AFAIK as running it upsets mariadb [10:26:46] (03PS1) 10Paladox: Update QUnit to 1.15.0 [core] - 10https://gerrit.wikimedia.org/r/154029 [10:26:59] (03PS2) 10Paladox: Update QUnit to 1.15.0 [core] - 10https://gerrit.wikimedia.org/r/154029 [10:27:24] ... [10:27:28] legoktm: what do I have? [10:27:36] * YuviPanda waves at Danny_B [10:27:50] * Danny_B waves back [10:28:08] Reedy: was that answer to me or to any previous post, pls? [10:29:32] (03PS3) 10Paladox: Update QUnit to 1.15.0 [core] - 10https://gerrit.wikimedia.org/r/154029 [10:30:26] (03CR) 10Prtksxna: [C: 032 V: 032] Use protocol relative URLs for some links on Transparency Report pages [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153026 (owner: 10Chmarkine) [10:31:06] p858snake|l: I believe the current record is https://gerrit.wikimedia.org/r/#/c/55287/ with 73... [10:31:46] (03PS4) 10Paladox: Update QUnit to 1.15.0 [core] - 10https://gerrit.wikimedia.org/r/154029 [10:31:57] it's a tie with https://gerrit.wikimedia.org/r/#/c/135312/ [10:32:00] (03PS5) 10Paladox: Update QUnit to 1.15.0 [core] - 10https://gerrit.wikimedia.org/r/154029 [10:32:21] (03PS6) 10Paladox: Update QUnit to 1.15.0 [core] - 10https://gerrit.wikimedia.org/r/154029 [10:32:51] Some one really needs to talk to them about this [10:32:55] seriously, what is with that? 6 patch sets in as many minutes [10:32:57] that's 5 patchsets of editing RELEASE-NOTES [10:33:24] I've tried to communicate to this user, it took a very very long time to get through to them not to +1 their own patches! [10:33:44] * Danny_B thought gerrit doesn't allow that [10:33:50] Even more so when they +1 it without testing [10:34:05] and it's broken stuff [10:34:21] Have they actually made any useful contributions aside from updating JS libraries? [10:34:43] https://gerrit.wikimedia.org/r/#/q/owner:thomasmulhall410%2540yahoo.com+status:merged,n,z [10:35:15] A couple of useful commits it would seem [10:35:58] But then look at this: https://gerrit.wikimedia.org/r/#/q/owner:thomasmulhall410%2540yahoo.com+status:abandoned,n,z [10:38:26] We need a rate limiter for gerrit [10:38:44] 3MediaWiki / 3General/Unknown: DB password in the field From - 10https://bugzilla.wikimedia.org/69528 (10salclem2) 3UNCO p:3Unprio s:3minor a:3None When an user reset either own or other mediawiki web login password, in the From field of receipt mail appears the password database e.g "MyWiki (03PS1) 10Prtksxna: Use protocol relative URLs for links with https [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/154031 [10:44:56] (03CR) 10Prtksxna: [C: 04-1] "In case I've removed an https where it was required please leave an inline comment and I'll fix it." [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/154031 (owner: 10Prtksxna) [11:05:39] Hi! [11:10:26] 3MediaWiki extensions / 3CirrusSearch: The search backend returned an error - 10https://bugzilla.wikimedia.org/69491#c4 (10bennylin) Both produce the same error. As for the Beta "New search", it's not activated atm. After activating "New search", the result came up as expected. So it's probably not the prob... [11:12:02] (03PS5) 10Zfilipin: WIP Moved the first Wikidata job from WMDE Jenkins [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147093 [11:19:58] 3MediaWiki / 3API: Eliminator rights - 10https://bugzilla.wikimedia.org/69530 (10Marios Magioladitis) 3UNCO p:3Unprio s:3normal a:3None After a request in AWB's bug talk to allow "eliminator" to delete pages via AWB in Portuguese Wikipedia I tried to replace !TheSession.User.IsSysop with !TheSessi... [11:25:01] Can anybody explain me the procedure to fix a bug from bugzilla.wikimedia.org? How can I test a self-written patch of code locally and submit it for fixing the bug and also get it reviewed? I am new to this environment. Please help! [11:28:44] ritika_coder_101: hey! Welcome to wikimedia development :-) Do you have git and git-review set up? [11:29:57] ritika_coder_101: https://www.mediawiki.org/wiki/Git/Tutorial [11:41:57] (03Abandoned) 10Chad: Remove xdiff-backed HistoryBlob implementation [core] - 10https://gerrit.wikimedia.org/r/84770 (owner: 10Chad) [11:49:38] James_F: http://imgur.com/SwaoSuW is this a known bug? [11:49:45] overlapping of button/title [11:49:52] tto: Sadly, yeah. :-( [11:49:53] (03CR) 10Nikerabbit: [C: 031] Register GadgetResourceLoaderModule with an array [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153539 (owner: 10Legoktm) [11:50:02] bugzilla report? [11:50:06] tto: There's a fix coming soon. [11:50:16] okay [11:59:11] 3MediaWiki / 3API: Eliminator rights - 10https://bugzilla.wikimedia.org/69530#c1 (10Marios Magioladitis) Related links are: https://en.wikipedia.org/wiki/Wikipedia:AWB/B#.22Delete.22_button_not_enabled_for_eliminators_on_ptwiki https://bugzilla.wikimedia.org/show_bug.cgi?id=24623 [11:59:56] 3MediaWiki / 3API: Eliminator rights - 10https://bugzilla.wikimedia.org/69530#c2 (10Marios Magioladitis) Patch that should work in AWB is Index: AWB/Main.cs =================================================================== --- AWB/Main.cs (revision 10370) +++ AWB/Main.cs (working copy) @@ -4506,7 +4... [12:02:17] (03CR) 10Prtksxna: "Is there a reason why you want to keep these renderers in a separate namespace?" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/150731 (owner: 10Bene) [12:04:49] (03CR) 10Hashar: [C: 032] "deploying" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151876 (owner: 10Hashar) [12:04:52] (03Merged) 10jenkins-bot: mwconf: let us override magic extension loader [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151876 (owner: 10Hashar) [12:06:39] (03CR) 10TheDJ: "Another spot where this might integrate is" [extensions/Math] - 10https://gerrit.wikimedia.org/r/153965 (https://bugzilla.wikimedia.org/66516) (owner: 10Physikerwelt) [12:07:39] (03CR) 10Hashar: "recheck" [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/152546 (owner: 10Hashar) [12:10:29] (03CR) 10Hashar: "Zeljkof: use the Gerrit cherry-pick button to propose the patch on both wmf branches. Will need someone to review / approve / deploy the " [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/152246 (owner: 10Zfilipin) [12:10:56] (03CR) 10Manybubbles: "Since this has already been +2ed, as it been deployed? Its still in the list of patches seeking a SWAT slot on [[wikitech:Deployments]]" [extensions/MassMessage] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153042 (https://bugzilla.wikimedia.org/68843) (owner: 10Legoktm) [12:11:26] 3MediaWiki / 3Parser: Provide a parser function to create links to the wiki which don't look external - 10https://bugzilla.wikimedia.org/66746#c2 (10Nemo) If you want a "parser function for creating arbitrary links", we already have three: https://www.mediawiki.org/wiki/Help:Magic_words#URL_data Changing su... [12:11:41] 3MediaWiki / 3Parser: Provide a parser function to create links to the wiki which don't look external - 10https://bugzilla.wikimedia.org/66746 (10Nemo) [12:11:42] 3MediaWiki / 3Internationalization: Links to mediawiki.org in messages should be consistent: full https://www.mediawiki.org link instead of http:// or proto-relative //www.mediawiki.org - 10https://bugzilla.wikimedia.org/54835 (10Nemo) [12:12:51] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/152546 (owner: 10Hashar) [12:17:51] (03PS5) 10Zfilipin: WIP: Updated MEDIAWIKI_API_UPLOAD_URL for language screenshot job to production Commons [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147415 (owner: 10Vikassy) [12:21:04] (03CR) 10Ori.livneh: [C: 032] Bumping up version of wikimetrics module in vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/154018 (owner: 10Nuria) [12:21:09] (03Merged) 10jenkins-bot: Bumping up version of wikimetrics module in vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/154018 (owner: 10Nuria) [12:22:11] 3MediaWiki extensions / 3OAuth: Allow hiding OAuth edits in Recent Changes - 10https://bugzilla.wikimedia.org/64829#c19 (10Bartosz Dziewoński) Can somebody summarize the current status here? I am rather interested in the throttle being removed from Magnus's AutoList 2 (without me having to hack it in the JS... [12:30:33] (03PS1) 10Vikassy: Language screenshot job should run on english beta labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/154042 [12:31:45] (03CR) 10Hashar: [C: 04-1] "You need to define the ruby lint job in Jenkins job builder configuration (master branch). It is done in mediawiki-extensions.yaml using " [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152795 (https://bugzilla.wikimedia.org/52246) (owner: 10Zfilipin) [12:32:34] (03CR) 10Zfilipin: [C: 032] Language screenshot job should run on english beta labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/154042 (owner: 10Vikassy) [12:33:03] (03Merged) 10jenkins-bot: Language screenshot job should run on english beta labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/154042 (owner: 10Vikassy) [12:39:56] (03PS6) 10Zfilipin: Updated MEDIAWIKI_API_UPLOAD_URL for language screenshot job to production Commons [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147415 (owner: 10Vikassy) [12:40:01] (03PS7) 10Zfilipin: Updated MEDIAWIKI_API_UPLOAD_URL for language screenshot job to production Commons [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147415 (owner: 10Vikassy) [12:42:11] (03CR) 10Zfilipin: Updated MEDIAWIKI_API_UPLOAD_URL for language screenshot job to production Commons (031 comment) [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147415 (owner: 10Vikassy) [12:42:23] (03CR) 10Zfilipin: [C: 031] Updated MEDIAWIKI_API_UPLOAD_URL for language screenshot job to production Commons [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147415 (owner: 10Vikassy) [12:42:41] (03CR) 10Amire80: [C: 032] "\o/" [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147415 (owner: 10Vikassy) [12:43:07] (03Merged) 10jenkins-bot: Updated MEDIAWIKI_API_UPLOAD_URL for language screenshot job to production Commons [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147415 (owner: 10Vikassy) [12:43:47] (03CR) 10Hashar: [C: 04-1] Enable phplint job for labs-toollabs (031 comment) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153581 (https://bugzilla.wikimedia.org/63687) (owner: 10Addshore) [12:44:25] (03PS5) 10Hashar: Enable phplint job for labs-toollabs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153581 (https://bugzilla.wikimedia.org/63687) (owner: 10Addshore) [12:45:22] (03CR) 10Hashar: [C: 032] "PS5: added phplint to gate-and-submit." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153581 (https://bugzilla.wikimedia.org/63687) (owner: 10Addshore) [12:45:30] (03Merged) 10jenkins-bot: Enable phplint job for labs-toollabs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153581 (https://bugzilla.wikimedia.org/63687) (owner: 10Addshore) [12:47:19] (03CR) 10Kaldari: [C: 032] Followup I4049b666: "Removing prefix exception for HTMLCheckMatrix" [core] - 10https://gerrit.wikimedia.org/r/151972 (https://bugzilla.wikimedia.org/69146) (owner: 10Bsitu) [12:51:30] (03Merged) 10jenkins-bot: Followup I4049b666: "Removing prefix exception for HTMLCheckMatrix" [core] - 10https://gerrit.wikimedia.org/r/151972 (https://bugzilla.wikimedia.org/69146) (owner: 10Bsitu) [12:53:24] (03PS1) 10Zfilipin: Removed languages that fonts are missing [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/154049 [12:53:27] (03CR) 10Bartosz Dziewoński: "Are you sure no other extensions used this?" [core] - 10https://gerrit.wikimedia.org/r/64982 (owner: 10Kaldari) [12:56:58] 3MediaWiki extensions / 3WikidataRepo: Uncaught exception if a badge id does not exist - 10https://bugzilla.wikimedia.org/69536 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs If one of the items in my badgeItems setting does not exist (e.g. deleted or misconfigured), then I get an uncaught except... [12:57:18] (03PS2) 10Amire80: Removed languages for which fonts are missing [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/154049 (https://bugzilla.wikimedia.org/69535) (owner: 10Zfilipin) [12:58:03] (03CR) 10Amire80: [C: 032] Removed languages for which fonts are missing [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/154049 (https://bugzilla.wikimedia.org/69535) (owner: 10Zfilipin) [12:58:46] (03Merged) 10jenkins-bot: Removed languages for which fonts are missing [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/154049 (https://bugzilla.wikimedia.org/69535) (owner: 10Zfilipin) [13:03:26] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Index not updated automatically - 10https://bugzilla.wikimedia.org/69387#c4 (10Nik Everett) 5UNCO>3ASSI Those first few jobs aren't part of Cirrus - the htmlCacheUpdate job I mean. It really looks like jobs just aren't picking up and cirrus is the mos... [13:05:26] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch appears twice in srbackend paraminfo - 10https://bugzilla.wikimedia.org/69517#c6 (10Nik Everett) p:5Unprio>3Normal I can have a look at it in a day or two. If anyone is closer to having the right plugins setup and wants to do it please let me know. [13:16:27] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Index not updated automatically - 10https://bugzilla.wikimedia.org/69387#c5 (10keyler) oh ok then.... thank you Nik! I just wanted to make sure everythin g is working as is sould be and thanks to your help I saw this in the log: 2014-08-14 13:13:32 serve... [13:17:17] (03PS1) 10Pastakhov: Add role for PhpTags extension [vagrant] - 10https://gerrit.wikimedia.org/r/154051 [13:18:42] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Index not updated automatically - 10https://bugzilla.wikimedia.org/69387#c6 (10keyler) Maybe this is the problem: https://www.mediawiki.org/wiki/Extension_talk:Replace_Text#MediaWiki_1.22_and_newer_do_not_execute_jobs [13:19:02] (03PS1) 10Zfilipin: WIP Running language screenshot job using local Firefox [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/154052 [13:21:07] (03PS21) 1001tonythomas: Adding a JS Class to inputBox to grey out Submit button. [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 (https://bugzilla.wikimedia.org/61606) [13:23:58] 3MediaWiki / 3Skin and page rendering: |thumb|center fills all horizontal space - 10https://bugzilla.wikimedia.org/69538 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Created attachment 16192 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16192&action=edit Example from en.wiki Firefox 31.0 on fe... [13:27:35] (03PS2) 10Ori.livneh: Add role for PhpTags extension [vagrant] - 10https://gerrit.wikimedia.org/r/154051 (owner: 10Pastakhov) [13:27:42] (03PS3) 10Ori.livneh: Add role for PhpTags extension [vagrant] - 10https://gerrit.wikimedia.org/r/154051 (owner: 10Pastakhov) [13:27:46] (03CR) 10Ori.livneh: [C: 032] Add role for PhpTags extension [vagrant] - 10https://gerrit.wikimedia.org/r/154051 (owner: 10Pastakhov) [13:27:53] (03Merged) 10jenkins-bot: Add role for PhpTags extension [vagrant] - 10https://gerrit.wikimedia.org/r/154051 (owner: 10Pastakhov) [13:28:11] 3MediaWiki / 3API: Eliminator rights - 10https://bugzilla.wikimedia.org/69530#c3 (10Sam Reed (reedy)) 5UNCO>3RESO/INV (In reply to Marios Magioladitis from comment #0) > I suggest that eliminator rights should be defined globally and in > Wikipedias with no eliminator group, sysop get eliminator rights a... [13:28:42] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Index not updated automatically - 10https://bugzilla.wikimedia.org/69387#c7 (10keyler) OK, now I found the problem. Jobs were all having problems not just CirrusSearch. This did the magic in LocalSettings.php $wgRunJobsAsync = false; Thank you Nik for po... [13:29:56] 3MediaWiki extensions / 3WikidataRepo: Special:NewItem return error "Could not create a new page. It already exists." although it does not exist - 10https://bugzilla.wikimedia.org/46535#c9 (10Lydia Pintscher) Can someone please explain if/how the above patch relates to the issue of this bug? [13:32:31] 3MediaWiki extensions / 3CirrusSearch: No Update of elasticsearch index when changing wiki - 10https://bugzilla.wikimedia.org/65439#c5 (10keyler) This did the magic in LocalSettings.php $wgRunJobsAsync = false; [13:33:41] 3MediaWiki extensions / 3WikidataRepo: Suggester box to small - 10https://bugzilla.wikimedia.org/66435 (10Lydia Pintscher) 5PATC>3RESO/FIX [13:33:57] 3MediaWiki / 3General/Unknown: DB password in the field From - 10https://bugzilla.wikimedia.org/69528#c1 (10salclem2) Resetting of password was reported by this wiki link [[Speciale:ReimpostaPassword]] [13:35:41] 3MediaWiki extensions / 3WikidataRepo: Server side generated html of read only Entity views shouldn't include edit links - 10https://bugzilla.wikimedia.org/68325 (10Lydia Pintscher) 5PATC>3RESO/FIX [13:37:26] 3MediaWiki extensions / 3WikidataRepo: All text in suggester is underlined with the underline setting - 10https://bugzilla.wikimedia.org/66434 (10Lydia Pintscher) 5PATC>3RESO/FIX [13:37:56] 3MediaWiki extensions / 3WikidataClient: EntityIdInput.js refers to local mw.util.wikiScript( 'api' ), need to refer Wikidata API - 10https://bugzilla.wikimedia.org/69170 (10Lydia Pintscher) 5PATC>3RESO/FIX [13:38:26] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Index not updated automatically - 10https://bugzilla.wikimedia.org/69387#c8 (10Nik Everett) 5ASSI>3RESO/FIX Uhg..... I'm not a happy camper about the way jobs are run..... And we're (the foundation) moving further and further from what other folks wi... [13:41:30] (03PS27) 10Matthias Mullie: New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [13:41:33] (03PS6) 10Matthias Mullie: Subscribe to board = auto-subscribe to new topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153411 [13:42:26] 3MediaWiki / 3Skin and page rendering: |thumb|center fills all horizontal space - 10https://bugzilla.wikimedia.org/69538#c1 (10Bartosz Dziewoński) 5NEW>3UNCO I can't reproduce this on Windows 7 in any browser, including Firefox 31. Can you reproduce in a different skin, when logged out, on a different c... [13:46:25] (03PS2) 10Dbrant: Next iteration of styling for PageIssues/Disambiguation. [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/153813 [13:46:42] 3MediaWiki extensions / 3WikidataRepo: JS ReferenceErrors due to ResourceLoader changes - 10https://bugzilla.wikimedia.org/69468#c4 (10tobias.gritschacher) https://gerrit.wikimedia.org/r/#/c/154050/ https://github.com/wmde/WikibaseDataModelJavascript/pull/13 https://github.com/wmde/ValueView/pull/105 https:/... [13:48:41] (03CR) 10Matthias Mullie: "I know it's easier to review in discrete parts. However, Andrew started this patch and if I were to break it down now, I might overlook so" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149210 (owner: 10Werdna) [13:55:54] (03Draft1) 10Addshore: Update to php codesniffer 1.4.8 [integration/phpcs] - 10https://gerrit.wikimedia.org/r/154053 [14:00:01] I think it's time to branch [14:00:57] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Index not updated automatically - 10https://bugzilla.wikimedia.org/69387#c9 (10keyler) Could you put this "workaround" into the README? Am am very sure this will happen to more and more CirrusSearch users with MW1.22 and 1.23 and so on. [14:05:38] (03CR) 10Matthias Mullie: [C: 04-1] "Just posted 1 more remark." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/152935 (owner: 10Bsitu) [14:05:48] andre__, I hadn't realized the big amount of unprioritized bugs I was CCed to (or I might have even reported). :) [14:05:55] haha [14:05:58] 3MediaWiki extensions / 3Capiunto: performance review for Capiunto - 10https://bugzilla.wikimedia.org/69540 (10Lydia Pintscher) 3NEW p:3Unprio s:3normal a:3None We would like to roll out Capiunto to production. It needs a performance review. The code is at https://git.wikimedia.org/summary/mediawiki%... [14:06:00] 3MediaWiki extensions / 3Capiunto: security review for Capiunto - 10https://bugzilla.wikimedia.org/69541 (10Lydia Pintscher) 3NEW p:3Unprio s:3normal a:3None We would like to roll out Capiunto to production. It needs a security review. The code is at https://git.wikimedia.org/summary/mediawiki%2Fexte... [14:06:00] so mobile, eh? Good! [14:06:11] 3MediaWiki extensions / 3Capiunto: performance review for Capiunto - 10https://bugzilla.wikimedia.org/69540 (10Lydia Pintscher) [14:06:12] 3MediaWiki extensions / 3Capiunto: security review for Capiunto - 10https://bugzilla.wikimedia.org/69541 (10Lydia Pintscher) [14:06:56] 3MediaWiki extensions / 3Capiunto: security review for Capiunto - 10https://bugzilla.wikimedia.org/69541 (10Lydia Pintscher) [14:07:11] 3MediaWiki extensions / 3Capiunto: performance review for Capiunto - 10https://bugzilla.wikimedia.org/69540 (10Lydia Pintscher) [14:08:43] 3MediaWiki extensions / 3WikidataRepo: EntityIdValues displayed as UnDeserializableValues - 10https://bugzilla.wikimedia.org/69542 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs EntityIdValues are being displayed in the entity view as UnDeserializableValues. They appear to be UnDeserializableVal... [14:09:55] (03CR) 10Helder.wiki: "Follow-up: Ifff25534d716721ff1d2d4484dbd0f63161ecb43." [core] - 10https://gerrit.wikimedia.org/r/74407 (https://bugzilla.wikimedia.org/51338) (owner: 10Alex Monk) [14:10:41] 3MediaWiki / 3Skin and page rendering: |thumb|center fills all horizontal space - 10https://bugzilla.wikimedia.org/69538#c2 (10Nemo) Same on chromium and vector. I do have a custom css but it was recommended on some mediawiki.org page recently https://en.wikipedia.org/w/index.php?title=User%3ANemo_bis%2Fcomm... [14:11:15] how do we un confirm email of a $caUser = CentralAuthUser::getInstance( $user); using centralAuth funcitons ? [14:11:37] I only seem to get $caUser->setEmail( ' ' ) ; [14:11:41] hurray Reedy, eager to see some things deployed :) [14:12:19] tonythomas: it seems producing a token does that :P [14:12:38] tonythomas: It's quite possible it was never coded [14:12:52] that seems sad [14:13:07] so -> is there an alternative ? [14:13:13] Add it! [14:13:15] (03PS5) 10Wctaiwan: [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 [14:13:26] ha ;) I will try my best [14:13:27] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 (owner: 10Wctaiwan) [14:16:13] Reedy: simple solution by hoo : $user->setEmailAuthenticationTimestamp( ' ' ); [14:16:23] does the thing :) [14:16:35] empty string, please [14:16:44] oh yeah, didn't see that [14:16:52] Someone should mark it explicitly public [14:16:53] * Reedy coughs [14:16:56] 3MediaWiki / 3Skin and page rendering: |thumb|center fills all horizontal space - 10https://bugzilla.wikimedia.org/69538#c3 (10Bartosz Dziewoński) 5UNCO>3RESO/INV I can reproduce with this CSS added: .thumb { border: 1px solid #ccc; padding: 3px !important; background-color: #f9f9f9 !importa... [14:17:06] Reedy: CentralAuth is a hell lot of fun :) [14:17:09] ha. true that [14:17:44] 3MediaWiki / 3User preferences: Private and foreign keys for password verification - 10https://bugzilla.wikimedia.org/12126#c1 (10Andre Klapper) Hi とある白い猫! Sorry that nobody has taken a look at this report yet and given feedback. (In reply to とある白い猫 from comment #0) > I think it would increase our security... [14:17:49] I just installed it in my local wiki and still trying to find out where spoofuser in $ mysqldump -u $wgDBuser -p $wgDbName spoofuser > /tmp/spoofuser.temp come from [14:18:08] got that one from https://www.mediawiki.org/wiki/Extension:CentralAuth#Installation [14:18:11] 3MediaWiki extensions / 3WikidataRepo: Suggester box to small - 10https://bugzilla.wikimedia.org/66435#c2 (10Thiemo Mättig) 5RESO/FIX>3REOP The patch above added a min-width. If I remember correctly we agreed it would be nice to inherit the width of the parent text element. This is still to be done. [14:19:11] 3MediaWiki / 3Email: Cipher/encrypt email with GnuPG (GPG) - 10https://bugzilla.wikimedia.org/10453#c1 (10Andre Klapper) Bug 12126 is a request for password verification via a private/foreign key pair - I guess this would be less reinventing the wheel by basing this on a GPG support implementation in MediaWi... [14:19:26] 3MediaWiki / 3User preferences: Private and foreign keys for password verification - 10https://bugzilla.wikimedia.org/12126 (10Andre Klapper) [14:22:20] (03PS6) 10Wctaiwan: [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 [14:22:27] 3MediaWiki / 3User blocking: block to force reading of user talk page - 10https://bugzilla.wikimedia.org/16447 (10Andre Klapper) [14:22:30] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 (owner: 10Wctaiwan) [14:22:41] 3MediaWiki / 3Email: Enable users to set their preferences to receive watchlist notifications regardless of whether the page has been visited - 10https://bugzilla.wikimedia.org/31928 (10Andre Klapper) [14:23:37] (03PS2) 10Mitar: Allow adding custom parameters to the callback for OAuth. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153983 [14:23:41] 3MediaWiki / 3JavaScript: mw.notification Usability Improvements - 10https://bugzilla.wikimedia.org/40307#c19 (10Andre Klapper) Wondering if this ticket should be moved to the "Echo" component nowadays? [14:25:10] 'git' 'clone' '-q' 'ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector.git' 'Vector' [14:25:11] fatal: destination path 'Vector' already exists and is not an empty directory. [14:25:11] gah [14:25:24] (03CR) 10Mitar: "I added also that consumer key does not have to be specified when redirecting the user. This provides a bit more of secrecy to consumer ke" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153983 (owner: 10Mitar) [14:26:49] (03CR) 10Anomie: [C: 04-1] "More accurate would be to point out that the stubbiness of $wgAuth was removed in Icb36e47a." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153964 (owner: 10Legoktm) [14:27:26] 3MediaWiki extensions / 3Extensions requests: Template Auto-Completion - 10https://bugzilla.wikimedia.org/15187#c1 (10Andre Klapper) In a VisualEditor world, is the "automatically display available parameters for this template" part kind of covered by bug 51049, or do I entirely misunderstand (probably the l... [14:28:09] (03CR) 10Anomie: "> See I92031c90" [core] - 10https://gerrit.wikimedia.org/r/83918 (owner: 10Anomie) [14:28:32] (03PS1) 10Reedy: Remove Vector from extensions [tools/release] - 10https://gerrit.wikimedia.org/r/154057 [14:28:50] (03CR) 10Reedy: [C: 032] Remove Vector from extensions [tools/release] - 10https://gerrit.wikimedia.org/r/154057 (owner: 10Reedy) [14:28:56] (03Merged) 10jenkins-bot: Remove Vector from extensions [tools/release] - 10https://gerrit.wikimedia.org/r/154057 (owner: 10Reedy) [14:35:31] 3MediaWiki extensions / 3Capiunto: security review for Capiunto - 10https://bugzilla.wikimedia.org/69541 (10Greg Grossmeier) p:5Unprio>3Normal a:3Chris Steipp [14:41:55] (03PS1) 10Jeroen De Dauw: Do not +2 on verified based just on linting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/154058 [14:44:22] (03PS7) 10Wctaiwan: [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 [14:44:31] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 (owner: 10Wctaiwan) [14:50:47] (03PS1) 10Physikerwelt: Ignore local browsertest files [extensions/Math] - 10https://gerrit.wikimedia.org/r/154060 [14:52:26] 3Wikimedia / 3SSL related: Allow option to uncheck "Always use a secure connection when logged in" at login.wikimedia.org/wiki/Special:Preferences - 10https://bugzilla.wikimedia.org/69319#c3 (10Cometstyles) I figured login.wikimedia.org was the "global special:preference" and changing it there would affect a... [14:53:56] fatal: reference is not a tree: d79ed843e09bc7da7991c66f9f81d26ccac81083 [14:53:57] Unable to checkout 'd79ed843e09bc7da7991c66f9f81d26ccac81083' in submodule path 'vendor' [14:54:03] Change of remote I guess [14:54:05] * Reedy grumbles [14:54:43] (03CR) 10Microchip08: "Some of these links, such as eff.org, redirect HTTP traffic straight to HTTPS, so making them protocol-relative seems pointless." [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/154031 (owner: 10Prtksxna) [14:57:19] (03CR) 10Phuedx: "FWIW I prefer @Jdlrobson's initial solution, the `mw-ui-text-truncated` class." [core] - 10https://gerrit.wikimedia.org/r/151792 (owner: 10Jdlrobson) [14:58:56] 3MediaWiki extensions / 3Scribunto: Attempt to concatenate a nil value when using mw.html:css - 10https://bugzilla.wikimedia.org/69481#c6 (10Brad Jorsch) It seems clear that PHP-on-Windows is doing something screwed up there; I see no code path in engines/LuaCommon/UstringLibrary.php that should ever convert... [15:03:41] 3MediaWiki extensions / 3Scribunto: Attempt to concatenate a nil value when using mw.html:css - 10https://bugzilla.wikimedia.org/69481#c7 (10Erich Gubler) Confirmed, this was reproduced on a Windows machine. [15:03:48] (03PS2) 10Umherirrender: Add backlinks on special pages with relevant title [core] - 10https://gerrit.wikimedia.org/r/151445 [15:04:26] 3MediaWiki extensions / 3Scribunto: Attempt to concatenate a nil value when using mw.html:css - 10https://bugzilla.wikimedia.org/69481 (10Erich Gubler) [15:06:19] https://www.mediawiki.org/wiki/MediaWiki_1.24/wmf17/Changelog [15:06:21] (03CR) 10Bene: "I don't want to put the renderers into a separate javascript namespace. I want to add the ability to add specific renderers to the built i" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/150731 (owner: 10Bene) [15:06:26] 3MediaWiki / 3Email: Mail sent out by MediaWiki should have the Auto-Submitted header set to 'auto-generated' (RFC 3834) - 10https://bugzilla.wikimedia.org/16799#c1 (10Andre Klapper) Hi Patrick! Sorry that nobody has taken a look at this report yet and given feedback. This would be stuff to probably impleme... [15:09:05] (03PS1) 10Reedy: Update vendor repo on 1.24wmf16 to point to mediawiki/vendor [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/154066 [15:09:11] (03CR) 10Anomie: Fix HTTPS protocol detection (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116943 (https://bugzilla.wikimedia.org/46511) (owner: 10Yarda) [15:09:20] (03CR) 10Reedy: [C: 032 V: 032] Update vendor repo on 1.24wmf16 to point to mediawiki/vendor [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/154066 (owner: 10Reedy) [15:10:12] 3MediaWiki extensions / 3WikibaseQueryEngine: [HHVM] Tests on Travis are failing - 10https://bugzilla.wikimedia.org/69526#c1 (10Jeroen De Dauw) Talked to the DBAL people. They say HHVMs sqlsite driver is not behaving cotrrectly. https://github.com/facebook/hhvm/issues/3467 [15:11:14] (03CR) 10Addshore: "Im fairly sure this will still +2 after linting." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/154058 (owner: 10Jeroen De Dauw) [15:11:19] (03CR) 10Legoktm: "It was deployed and then reverted because I forgot it depended on a core patch that didn't get backported. I removed it from the SWAT list" [extensions/MassMessage] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153042 (https://bugzilla.wikimedia.org/68843) (owner: 10Legoktm) [15:12:29] (03PS1) 10Gerrit Patch Uploader: Remove dependencies to 'jquery', 'mediawiki' and 'jquery.json' [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/154067 [15:12:31] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/154067 (owner: 10Gerrit Patch Uploader) [15:23:01] (03PS1) 1001tonythomas: Added support to CentralAuth [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/154068 [15:23:26] 3MediaWiki / 3JavaScript: mw.notification Usability Improvements - 10https://bugzilla.wikimedia.org/40307#c20 (10Alex Monk) No, mw.notification is in core. [15:24:41] 3MediaWiki / 3General/Unknown: Deprecate the term 'sysop' throughout software, use 'admin' - 10https://bugzilla.wikimedia.org/16737#c1 (10Andre Klapper) Sounds reasonible, however not sure if the cost outweighs the gain. :-/ [15:24:53] pffft [15:25:24] seems mostly deprecated already [15:25:38] Message updates presumably? [15:26:19] messages already call it an admin in most places [15:26:39] * tonythomas always wondered what Token: field in the wikitech login page do [15:26:40] (03CR) 10Legoktm: [C: 032] Remove dependencies to 'jquery', 'mediawiki' and 'jquery.json' [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/154067 (owner: 10Gerrit Patch Uploader) [15:26:43] (03Merged) 10jenkins-bot: Remove dependencies to 'jquery', 'mediawiki' and 'jquery.json' [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/154067 (owner: 10Gerrit Patch Uploader) [15:26:47] * bawolff wonders too [15:26:50] tonythomas, two-factor authentication [15:27:20] Krenair: oh. I see. should check for the docs [15:27:27] Extension:OATHAuth [15:27:47] https://www.mediawiki.org/wiki/Extension:OATHAuth [15:27:57] Krenair: thanks. taking a look at it [15:29:22] (03CR) 10Hashar: [C: 031] "The check-only pipeline votes verified +1 / -1 . Since repositories usually requires Verified +2 for a change to be submitted by Gerrit, " [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/154058 (owner: 10Jeroen De Dauw) [15:35:42] 3MediaWiki / 3Categories: show number of leaf articles in parentheses instead of number of number of subcategories - 10https://bugzilla.wikimedia.org/16807#c1 (10Andre Klapper) Still valid in 1.24, e.g. "Articles to be expanded‎ (94 C, 3 P)" where 3P only refers to articles on the first sublevel of that cate... [15:36:12] (03PS1) 10Cmcmahon: create browser test builds for Echo extension [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/154070 [15:37:26] Is anyone around that can create projects on http://fab.wmflabs.org/ ? [15:38:24] qgil: ^ [15:39:23] hmm, infact you cant add repos without adding a project, which is what I wanted to test! :P [15:41:47] wow, those upercase identifier things are just.... odd [15:41:56] 3MediaWiki / 3General/Unknown: Make links to self-redirects being easy distinguishable - 10https://bugzilla.wikimedia.org/16562#c1 (10Andre Klapper) I'm afraid that the same code complexity applies as in bug 16561. :-/ Given example does not work anymore as article has been created in the meantime, but pret... [15:43:26] 3Wikimedia / 3Site requests: Maintenance scripts waiting to be run on Wikimedia wikis (tracking) - 10https://bugzilla.wikimedia.org/29782 (10Kunal Mehta (Legoktm)) [15:43:30] 3Wikimedia / 3General/Unknown: Remove aft type protection entries from the database - 10https://bugzilla.wikimedia.org/69548 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None They're still showing up in API requests, and no reason to keep them in the db table: 3MediaWiki / 3Skin and page rendering: Suggestion: Visual drag and drop Mediawiki editing for skins - 10https://bugzilla.wikimedia.org/16859#c1 (10Andre Klapper) p:5Low>3Lowest Tentatively moving to "Skin and page rendering", however maybe moving to "MediaWiki extensions > Extensions requests" might be m... [15:44:23] hi hoo hi addshore [15:44:49] addshore, https://www.mediawiki.org/wiki/Phabricator/Help#Requesting_a_new_project [15:46:04] addshore, there are many test projects that you can use, if all you want to do is testing [15:46:41] 3MediaWiki / 3Templates: Making unreferenced template parameters available or visible - 10https://bugzilla.wikimedia.org/16510#c1 (10Andre Klapper) 5NEW>3RESO/WOR Hi Jorge! Sorry that nobody has taken a look at this report yet and given feedback. I tried to create a page on en.wikipedia.org with the giv... [15:47:13] 3Wikimedia / 3Site requests: Create "Affiliate" namespace on chapcom.wikimedia.org - 10https://bugzilla.wikimedia.org/69549 (10Tanvir Rahman) 3NEW p:3Unprio s:3normal a:3None Hello, Please add add a 'Affiliate' namespace for chapcom.wikimedia.org. Main namespace: 'Affiliate' Discussion namespace: '... [15:51:44] (03PS1) 10Cmcmahon: committing Gemfile.lock [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154071 [15:52:46] (03PS2) 10Cmcmahon: QA: committing Gemfile.lock [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154071 [15:54:23] (03PS1) 10Reedy: Remove extra intval() calls [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/154073 [16:00:27] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Index not updated automatically - 10https://bugzilla.wikimedia.org/69387#c10 (10Nik Everett) 5RESO/FIX>3REOP p:5Normal>3Highes a:3Nik Everett Good call. Reopening and assigning to myself to do just that. [16:01:11] 3MediaWiki extensions / 3SemanticDrilldown: Namespace usage inconsistency between the 'has default form' and 'has filter' special properties. - 10https://bugzilla.wikimedia.org/21891#c5 (10Yaron Koren) 5NEW>3RESO/INV Now that the special properties have been deprecated in Semantic Drilldown v2.0 (replace... [16:05:31] (03CR) 10Hashar: [C: 04-1] "please use the sync-with-gerrit.py script at the root of the repo. It should takes care of everything :-)" [extensions] - 10https://gerrit.wikimedia.org/r/153862 (owner: 10Yurik) [16:10:13] 3MediaWiki / 3General/Unknown: Move code in MediaWiki:Common.js to MediaWiki software - 10https://bugzilla.wikimedia.org/69550 (10Jon) 3NEW p:3Unprio s:3normal a:3None There are various bits of JavaScript in Common.js to customise the enwiki experience. It is a shame there are not customisable in Loc... [16:10:26] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c24 (10Jon) (In reply to MZMcBride from comment #19) > In other words, if you all want to deprecate the use of MediaWiki:Common.js > and similar pages, yo... [16:11:59] (03PS1) 10Legoktm: Check a valid user object was created [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/154074 [16:12:16] Reedy: ^ that'll switch the fatal into a MWException [16:12:22] lol [16:13:12] (03CR) 10Reedy: [C: 032] Check a valid user object was created [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/154074 (owner: 10Legoktm) [16:13:19] (03Merged) 10jenkins-bot: Check a valid user object was created [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/154074 (owner: 10Legoktm) [16:13:21] (03PS1) 10Reedy: Check a valid user object was created [extensions/CentralAuth] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154075 [16:13:36] I think people just aren't supposed to visit that page directly [16:16:06] (03CR) 10Reedy: [C: 032] Check a valid user object was created [extensions/CentralAuth] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154075 (owner: 10Reedy) [16:16:13] (03Merged) 10jenkins-bot: Check a valid user object was created [extensions/CentralAuth] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154075 (owner: 10Reedy) [16:16:19] (03PS1) 10Reedy: Log if there are pending DB interactions in CentralAuthUser::attach [extensions/CentralAuth] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/154076 [16:18:25] (03CR) 10Reedy: [C: 032] Log if there are pending DB interactions in CentralAuthUser::attach [extensions/CentralAuth] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/154076 (owner: 10Reedy) [16:18:29] (03CR) 10Yurik: "I cannot use that script because it assumes i have a unix dev machine, which I don't. Will do it manually." [extensions] - 10https://gerrit.wikimedia.org/r/153862 (owner: 10Yurik) [16:18:33] (03Merged) 10jenkins-bot: Log if there are pending DB interactions in CentralAuthUser::attach [extensions/CentralAuth] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/154076 (owner: 10Reedy) [16:18:44] 3MediaWiki extensions / 3Capiunto: performance review for Capiunto - 10https://bugzilla.wikimedia.org/69540#c1 (10Nik Everett) a:3Ori Livneh Assigning to Ori as its a performance review. Feel free to bounce this to the appropriate queue/person. [16:18:44] 3Wikimedia / 3General/Unknown: From: address defaults to mediawiki.org domain on all non-Wikipedia wikis - 10https://bugzilla.wikimedia.org/58261 (10Nemo) [16:19:51] (03PS1) 10Reedy: Update CentralAuth to 1.24wmf16 HEAD [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/154077 [16:20:26] 3MediaWiki extensions / 3Capiunto: security review for Capiunto - 10https://bugzilla.wikimedia.org/69541#c1 (10Nik Everett) Already assigned to csteipp - does this need anything else to get it in the security review queue? [16:20:38] (03PS1) 10Reedy: Update CentralAuth to 1.24wmf17 HEAD [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154078 [16:21:01] (03CR) 10Reedy: [C: 032 V: 032] Update CentralAuth to 1.24wmf17 HEAD [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154078 (owner: 10Reedy) [16:21:08] (03CR) 10Reedy: [C: 032 V: 032] Update CentralAuth to 1.24wmf16 HEAD [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/154077 (owner: 10Reedy) [16:22:31] (03PS1) 10Jack Phoenix: Output a theme module only if there is such a module. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/154080 [16:22:56] 3MediaWiki extensions / 3Capiunto: security review for Capiunto - 10https://bugzilla.wikimedia.org/69541#c2 (10Marius Hoch) (In reply to Nik Everett from comment #1) > Already assigned to csteipp - does this need anything else to get it in the > security review queue? Don't think so... Given that this exten... [16:22:57] (03CR) 10Jack Phoenix: [C: 032 V: 032] Output a theme module only if there is such a module. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/154080 (owner: 10Jack Phoenix) [16:23:25] (03CR) 10Jdlrobson: "As discussed in IRC it is not the goal of this patch. You are talking about an epic bunch of work, that needs to be done but currently has" [core] - 10https://gerrit.wikimedia.org/r/150635 (owner: 10Jdlrobson) [16:23:26] 3MediaWiki extensions / 3Capiunto: security review for Capiunto - 10https://bugzilla.wikimedia.org/69541#c3 (10Chris Steipp) Can you point to any more information about the extension, and timelines? I'm swamped with reviews right now. Is this more or less urgent than WikibaseQuery? [16:23:47] csteipp: That review will take you less than 15 minutes :) [16:24:00] It's almost solely Lua, some CSS and a bit of wrapping PHP [16:24:16] csteipp, speaking of reviews, any updates on graph ext? [16:24:18] and the Lua is run with the same rights as the code we take from users, so shouldn't be dangerous [16:25:26] 3MediaWiki extensions / 3Capiunto: security review for Capiunto - 10https://bugzilla.wikimedia.org/69541#c4 (10Lydia Pintscher) Less urgent than WikibaseQuery. [16:27:07] yurikR: I should be done by Friday [16:28:25] csteipp, cool. In the mean time, i will push it to beta [16:28:27] thx! [16:29:00] (03CR) 10Addshore: [C: 04-1] [WIP] Unit tests (034 comments) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 (owner: 10Wctaiwan) [16:30:59] (03PS1) 10Physikerwelt: Protect MathML from Tidy [core] - 10https://gerrit.wikimedia.org/r/154083 (https://bugzilla.wikimedia.org/66516) [16:31:26] 3MediaWiki / 3API: Mitigate CVE-2014-4671 (jsonp flash) - 10https://bugzilla.wikimedia.org/68187#c12 (10Chris Steipp) This was assigned CVE-2014-5241 [16:32:11] 3MediaWiki / 3Skin and page rendering: XSS in mediawiki.page.image.pagination.js - 10https://bugzilla.wikimedia.org/66608#c22 (10Chris Steipp) This was assigned CVE-2014-5242 [16:32:26] 3MediaWiki / 3Skin and page rendering: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c6 (10Bartosz Dziewoński) 5PATC>3NEW I think it would be helpful to get aggregated access logs for everything in skins/common/ in WMF envi... [16:32:30] (03Abandoned) 10Physikerwelt: Protect MathML from Tidy [extensions/Math] - 10https://gerrit.wikimedia.org/r/153965 (https://bugzilla.wikimedia.org/66516) (owner: 10Physikerwelt) [16:36:32] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "The change makes sense to me." [core] - 10https://gerrit.wikimedia.org/r/153839 (owner: 10Krinkle) [16:39:11] (03PS1) 10Yurik: Added graph manually but in the sorted order [extensions] - 10https://gerrit.wikimedia.org/r/154084 [16:40:11] 3Wikimedia / 3General/Unknown: Move code in MediaWiki:Common.js to MediaWiki software - 10https://bugzilla.wikimedia.org/69550#c1 (10James Forrester) Common.js ships blank in MediaWiki. I imagine this is meant to be about Wikimedia. :-) [16:41:29] (03CR) 10Yurik: [C: 032 V: 032] Added graph manually but in the sorted order [extensions] - 10https://gerrit.wikimedia.org/r/154084 (owner: 10Yurik) [16:43:39] (03CR) 10Aaron Schulz: [C: 032] Remove useless $out parameter from SkinTemplate::prepareQuickTemplate() [core] - 10https://gerrit.wikimedia.org/r/153636 (owner: 10IAlex) [16:46:21] (03PS5) 10EBernhardson: Reset per-user notify types for each user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151271 [16:46:27] (03PS5) 10EBernhardson: Hygiene: Move master/slave code to MWEchoDbFactory [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151272 [16:46:39] (03PS5) 10EBernhardson: Hygiene: Move notification type detection to method [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151273 [16:47:35] (03Merged) 10jenkins-bot: Remove useless $out parameter from SkinTemplate::prepareQuickTemplate() [core] - 10https://gerrit.wikimedia.org/r/153636 (owner: 10IAlex) [16:47:53] (03Abandoned) 10Yurik: Added Graph extension. [extensions] - 10https://gerrit.wikimedia.org/r/153862 (owner: 10Yurik) [16:50:18] (03CR) 10Aaron Schulz: Enabled $wgUseLinkNamespaceDBFields (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153634 (owner: 10Aaron Schulz) [16:51:23] Nemo_bis: any idea where we can find someone from echo ? [16:53:21] (03PS1) 10Reedy: Add Skins to make-deploy-notes [tools/release] - 10https://gerrit.wikimedia.org/r/154087 [16:53:23] #wikimedia-corefeatures [16:54:37] (03CR) 10Aaron Schulz: [C: 032] Correctly handle incorrect namespace in cleanupTitles.php [core] - 10https://gerrit.wikimedia.org/r/153644 (https://bugzilla.wikimedia.org/68501) (owner: 10IAlex) [16:55:10] (03PS2) 10Reedy: Add Skins to make-deploy-notes [tools/release] - 10https://gerrit.wikimedia.org/r/154087 [16:55:11] 3Wikimedia / 3General/Unknown: Move code in MediaWiki:Common.js to MediaWiki software - 10https://bugzilla.wikimedia.org/69550#c2 (10Helder) Is this bug intended to be specific for enwiki? In the last months/days we have migrated a few of the scripts which were loaded from common.js[1] to gadgets enabled by... [16:58:27] (03Merged) 10jenkins-bot: Correctly handle incorrect namespace in cleanupTitles.php [core] - 10https://gerrit.wikimedia.org/r/153644 (https://bugzilla.wikimedia.org/68501) (owner: 10IAlex) [17:00:30] (03CR) 10EBernhardson: [C: 031] "minor quibble, ship it!" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151992 (owner: 10Bsitu) [17:07:28] hello sumanah! [17:07:33] Hi fhocutt :) [17:07:44] so, https://gist.github.com/fhocutt/0221c1a35265ce7cda33 - your Java dependency problem with Maven and classpath and so on [17:07:51] I see you got a comment on the gist itself [17:07:57] I have pull requests to try! https://github.com/fhocutt/jwbf-test/pulls [17:08:14] ooooh! [17:08:29] oh, so I did! [17:09:27] ok, I am charmed by "I globbed everything together into an "uberjar" using which will bring them all and in the jar bind them." [17:09:41] also am despite myself charmed by the pull req title "I poked the thing" [17:10:03] * fhocutt grins [17:11:20] fhocutt: so do you have some clear TODOs for today? [17:11:35] and how do you feel about the whole thing? same level of frustration? any demoralization? [17:11:43] I definitely have the larger TODO of following up on these three comments/suggestions [17:12:35] I am still frustrated and have leftover "argh, Java, why" from yesterday [17:13:06] but I at least have things to try, which is more than I had! [17:13:21] Yes!!!! [17:13:40] do you know this pnathan person? [17:13:55] yeah, he's Attic [17:14:02] nod nod [17:14:03] (03PS1) 10Jack Phoenix: Correctly show the page title. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/154090 [17:14:05] (03PS3) 10Reedy: Add Skins to make-deploy-notes [tools/release] - 10https://gerrit.wikimedia.org/r/154087 [17:14:14] * sumanah is glad that in open source you can help the world and the world can help you [17:14:23] ditto! [17:14:29] (03CR) 10Jack Phoenix: [C: 032 V: 032] Correctly show the page title. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/154090 (owner: 10Jack Phoenix) [17:14:35] OK fhocutt do you know what your next step is? [17:15:46] merge the pull requests to different branches and try to run them [17:16:01] (or whatever the easier way is to do that) [17:16:20] if they work, yay! Pick the easy/generalizable one [17:16:23] OK. That sounds totally reasonable fhocutt .... do you have to do something like separate environments or virtualenvs or something to make that happen? [17:16:31] like, to try the different branches [17:17:03] I can do separate folders and stuff, everything goes to the local maven repo anyway [17:17:14] ok! [17:17:16] it's different from Python [17:17:16] cool! [17:17:36] once they work, celebrate [17:17:37] * sumanah does not have a Python-to-Java phrasebook; thank you for the translation [17:17:38] YES [17:17:41] ok! go forth! [17:17:52] o7 [17:17:56] * fhocutt does so [17:17:57] * sumanah plays sort of a triumphant yet non-martial trumpet [17:17:59] (03CR) 10SG: "It's not that the class isn't clear, it's that the class isn't semantic. It is explicitly applying a styling change in the class name; it " [core] - 10https://gerrit.wikimedia.org/r/151792 (owner: 10Jdlrobson) [17:18:19] but don't start using forth [17:18:23] Because that way lies madness [17:18:36] (03CR) 10SG: "Should we just put a temporary version of the truncated mixin in Flow so we can just merge this?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151789 (owner: 10Jdlrobson) [17:18:41] 3Wikimedia / 3General/Unknown: Move code in enwiki MediaWiki:Common.js to MediaWiki software - 10https://bugzilla.wikimedia.org/69550 (10Jon) [17:18:53] bawolff: I am groaning at your pun. Thank you. [17:19:08] your PERL of wisdom. your gem (but not a rubygem) [17:20:04] lol [17:20:26] 3Wikimedia / 3General/Unknown: Move code in enwiki MediaWiki:Common.js to MediaWiki software - 10https://bugzilla.wikimedia.org/69550#c3 (10Jon) Yes to be clear, I think we should be going through English Wikipedias Common.js and moving code here into the software. I then envision similar bugs for other lang... [17:23:01] (03PS1) 10Umherirrender: Correct type of @param of Linker::getRevDeleteLink [core] - 10https://gerrit.wikimedia.org/r/154091 [17:24:49] (03PS1) 10Anomie: API: Add rawcontinue parameter to action=query [core] - 10https://gerrit.wikimedia.org/r/154092 [17:25:06] (03PS5) 10Aaron Schulz: Removed LCStoreDB class [core] - 10https://gerrit.wikimedia.org/r/153944 [17:25:52] (03CR) 10Aaron Schulz: "There is https://bugzilla.wikimedia.org/show_bug.cgi?id=43575 . I'm not sure if the unit test problems Chad ran into had a bug report." [core] - 10https://gerrit.wikimedia.org/r/153944 (owner: 10Aaron Schulz) [17:26:58] (03PS2) 10Aaron Schulz: Made LocalFile move/delete/restore handle network partitions better [core] - 10https://gerrit.wikimedia.org/r/153990 [17:29:43] (03PS1) 10Reedy: List Vendor repo changes too [tools/release] - 10https://gerrit.wikimedia.org/r/154093 [17:30:00] (03PS8) 10Wctaiwan: [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 [17:30:02] (03CR) 10Reedy: [C: 032] List Vendor repo changes too [tools/release] - 10https://gerrit.wikimedia.org/r/154093 (owner: 10Reedy) [17:30:12] (03CR) 10Reedy: [C: 032] Add Skins to make-deploy-notes [tools/release] - 10https://gerrit.wikimedia.org/r/154087 (owner: 10Reedy) [17:31:19] (03Merged) 10jenkins-bot: Add Skins to make-deploy-notes [tools/release] - 10https://gerrit.wikimedia.org/r/154087 (owner: 10Reedy) [17:31:21] (03Merged) 10jenkins-bot: List Vendor repo changes too [tools/release] - 10https://gerrit.wikimedia.org/r/154093 (owner: 10Reedy) [17:31:29] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 (owner: 10Wctaiwan) [17:34:18] (03PS2) 10Physikerwelt: Protect MathML from Tidy [core] - 10https://gerrit.wikimedia.org/r/154083 (https://bugzilla.wikimedia.org/66516) [17:34:28] 3MediaWiki extensions / 3WikidataRepo: Invalid argument supplied for foreach() in api/GetEntities.php on line 237 - 10https://bugzilla.wikimedia.org/69553 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Warning: Invalid argument supplied for foreach() in /usr/local/apache/common-local... [17:35:03] (03PS5) 10Aaron Schulz: [WIP] Removed selective restore checkboxes from Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/145027 [17:35:16] (03PS1) 10Isarra: css tweaks for headers [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/154094 [17:35:31] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Removed selective restore checkboxes from Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/145027 (owner: 10Aaron Schulz) [17:37:56] 3MediaWiki / 3Unit tests: Gerrit 146683 broke `php tests/parserTests.php`. - 10https://bugzilla.wikimedia.org/69082 (10Aaron Schulz) 5PATC>3RESO/FIX [17:38:17] (03PS9) 10Wctaiwan: [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 [17:38:27] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 (owner: 10Wctaiwan) [17:40:13] 3MediaWiki extensions / 3Math: MathJax Error "Bracket argument to \\ must be a dimension" in \begin{align} - 10https://bugzilla.wikimedia.org/69554 (10Stephan Kulla) 3UNCO p:3Unprio s:3minor a:3None Intention: When I use something like \\[5px] to add 5px space between lines in a formula of an align-e... [17:40:17] (03CR) 10Jack Phoenix: [C: 032 V: 032] css tweaks for headers [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/154094 (owner: 10Isarra) [17:41:02] tonythomas: as he said, but I don't think it matters that much; just file a bug and cc them [17:41:25] (03PS10) 10Wctaiwan: [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 [17:41:36] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 (owner: 10Wctaiwan) [17:43:41] 3Wikimedia / 3General/Unknown: Move code in enwiki MediaWiki:Common.js to MediaWiki software - 10https://bugzilla.wikimedia.org/69550#c4 (10Alex Monk) enwiki sounds like a good starting point (given that a ton of things just get copied directly from there), but that's not to say we shouldn't be improving JS... [17:44:11] 3MediaWiki / 3Skin and page rendering: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c7 (10Bartosz Dziewoński) Filed RT 8131: ---- Requesting aggregated access logs for bits.wikimedia.org/*/skins/common/** I am requesting ag... [17:44:28] 3MediaWiki / 3Redirects: Redirect [[User:Name/skin.js]] to current skin's JS page (e.g. [[User:Name/vector.js]]) - 10https://bugzilla.wikimedia.org/69555 (10Helder) 3NEW p:3Unprio s:3normal a:3None This is one of the features mentioned on bug 69550 which are currently implemented by means of a JavaSc... [17:45:20] MatmaRex: should this ^ be in core or in skins? [17:45:46] hmm? definitely core, if we want to do it [17:46:05] ok [17:46:11] 3Wikimedia / 3General/Unknown: Move code in enwiki MediaWiki:Common.js to MediaWiki software - 10https://bugzilla.wikimedia.org/69550#c5 (10Helder) I moved the request for a skin.js/css redirect to bug 69555. [17:47:47] (03PS1) 10Anomie: API: Add method for logging feature usage [core] - 10https://gerrit.wikimedia.org/r/154095 [17:47:58] (03PS11) 10Wctaiwan: [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 [17:48:26] 3MediaWiki extensions / 3TorBlock: Warning: Invalid argument supplied for foreach() in TorExitNodes.php on line 210 - 10https://bugzilla.wikimedia.org/69017#c1 (10Sam Reed (reedy)) What version of the extension? On master line 210 is } [17:48:39] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Unit tests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/154009 (owner: 10Wctaiwan) [17:49:03] (03CR) 10OliverKeyes: [C: 031] "Necessary change for analysis purposes. Sanitise ALL the parameters! :D" [core] - 10https://gerrit.wikimedia.org/r/154095 (owner: 10Anomie) [17:49:12] 3MediaWiki / 3Redirects: Redirect [[User:Name/skin.js]] to current skin's JS page (e.g. [[User:Name/vector.js]]) - 10https://bugzilla.wikimedia.org/69555#c1 (10Bartosz Dziewoński) I don't think we should make it impossible to create a user subpage literally named "skin.js" or "skin.css". Perhaps a better, mo... [17:49:24] (03PS1) 10Umherirrender: Remove wrong type from @param on ContentHandler::merge3 [core] - 10https://gerrit.wikimedia.org/r/154097 [17:49:57] (03CR) 10IAlex: [C: 04-1] API: Add method for logging feature usage (031 comment) [core] - 10https://gerrit.wikimedia.org/r/154095 (owner: 10Anomie) [17:50:11] 3MediaWiki-Vagrant / 3labs-vagrant: Document use of hiera settings to control expected hostnames - 10https://bugzilla.wikimedia.org/69287 (10Sam Reed (reedy)) [17:50:26] 3MediaWiki / 3Documentation: Documentation is out of date, incomplete (tracking) - 10https://bugzilla.wikimedia.org/1 (10Sam Reed (reedy)) [17:51:11] 3MediaWiki / 3Parser: Provide a parser function to create links to the wiki which don't look external - 10https://bugzilla.wikimedia.org/66746#c3 (10Jon) {{localurl:Special:Userlogin|returnto=Hello world}} ouputs /w/index.php?title=Special:Userlogin&returnto=Hello world but I want to output 3enhanc [17:54:48] 3Wikimedia / 3Site requests: Run migrateAccount.php without --safe or --auto - 10https://bugzilla.wikimedia.org/69291 (10Sam Reed (reedy)) s:5normal>3enhanc [17:54:49] 3MediaWiki-Vagrant / 3labs-vagrant: Document use of hiera settings to control expected hostnames - 10https://bugzilla.wikimedia.org/69287 (10Sam Reed (reedy)) s:5normal>3enhanc [17:54:58] 3Wikimedia / 3Site requests: Disable Media Viewer by default for logged-in users on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69363 (10Sam Reed (reedy)) s:5normal>3enhanc [17:54:58] 3Wikimedia / 3Site requests: Create "Affiliate" namespace on chapcom.wikimedia.org - 10https://bugzilla.wikimedia.org/69549 (10Sam Reed (reedy)) s:5normal>3enhanc [17:55:03] 3Wikimedia / 3Site requests: Add two swedish URLs to wgCopyUploadsDomains for Commons - 10https://bugzilla.wikimedia.org/69439 (10Sam Reed (reedy)) s:5normal>3enhanc [17:55:14] 3MediaWiki / 3Skin and page rendering: Add README to skins folder - 10https://bugzilla.wikimedia.org/69372 (10Sam Reed (reedy)) s:5normal>3enhanc [17:55:14] 3MediaWiki extensions / 3Capiunto: security review for Capiunto - 10https://bugzilla.wikimedia.org/69541 (10Sam Reed (reedy)) s:5normal>3enhanc [17:55:14] 3Wikimedia / 3Bugzilla: Create "MediaWiki" --> "Configuration" component - 10https://bugzilla.wikimedia.org/69339 (10Sam Reed (reedy)) s:5normal>3enhanc [17:55:36] 3MediaWiki extensions / 3WikidataRepo: Create jQuery.wikibase.labelview - 10https://bugzilla.wikimedia.org/69472 (10Sam Reed (reedy)) s:5normal>3enhanc [17:55:36] 3Wikimedia / 3Bugzilla: Create a component for UnicodeJS in product "Utilities" - 10https://bugzilla.wikimedia.org/69427 (10Sam Reed (reedy)) s:5normal>3enhanc [17:55:52] 3Wikimedia / 3Bugzilla: Add legoktm and Krenair as default cc's for Gadgets extension - 10https://bugzilla.wikimedia.org/69343 (10Sam Reed (reedy)) s:5normal>3enhanc [17:55:52] 3Wikimedia / 3General/Unknown: Remove aft type protection entries from the database - 10https://bugzilla.wikimedia.org/69548 (10Sam Reed (reedy)) s:5normal>3enhanc [17:55:52] 3MediaWiki extensions / 3WikidataRepo: Create jQuery.wikibase.descriptionview - 10https://bugzilla.wikimedia.org/69471 (10Sam Reed (reedy)) s:5normal>3enhanc [17:55:53] 3MediaWiki extensions / 3WikidataRepo: Create jQuery.wikibase.aliasview - 10https://bugzilla.wikimedia.org/69470 (10Sam Reed (reedy)) s:5normal>3enhanc [17:55:56] 3MediaWiki / 3Maintenance scripts: mwscript instead of php to run maintenance scripts - 10https://bugzilla.wikimedia.org/69434 (10Sam Reed (reedy)) s:5normal>3enhanc [17:56:08] 3MediaWiki / 3Skin and page rendering: Make sure fallback skin is never cached - 10https://bugzilla.wikimedia.org/69284 (10Sam Reed (reedy)) s:5normal>3enhanc [17:56:10] 3MediaWiki extensions / 3Capiunto: performance review for Capiunto - 10https://bugzilla.wikimedia.org/69540 (10Sam Reed (reedy)) s:5normal>3enhanc [17:56:14] 3Wikimedia / 3General/Unknown: Move code in enwiki MediaWiki:Common.js to MediaWiki software - 10https://bugzilla.wikimedia.org/69550 (10Sam Reed (reedy)) s:5normal>3enhanc [17:56:14] 3Wikimedia / 3Site requests: Change user groups rights on ckb.wikipedia - 10https://bugzilla.wikimedia.org/69394 (10Sam Reed (reedy)) s:5normal>3enhanc [17:56:14] 3MediaWiki extensions / 3CirrusSearch: Search should normalize Niqqud diacritics in Hebrew characters - 10https://bugzilla.wikimedia.org/69361 (10Sam Reed (reedy)) s:5normal>3enhanc [17:56:14] 3MediaWiki / 3JavaScript: update jQuery UI in core from 1.9 to 1.11 - 10https://bugzilla.wikimedia.org/69386 (10Sam Reed (reedy)) s:5normal>3enhanc [17:56:34] yw [17:56:52] (03PS2) 10Anomie: API: Add method for logging feature usage [core] - 10https://gerrit.wikimedia.org/r/154095 [17:57:03] (03PS3) 10Anomie: API: Add method for logging feature usage [core] - 10https://gerrit.wikimedia.org/r/154095 [17:57:11] 3MediaWiki / 3Redirects: Redirect [[User:Name/skin.js]] to current skin's JS page (e.g. [[User:Name/vector.js]]) - 10https://bugzilla.wikimedia.org/69555#c2 (10Jon) I think a special page for this is a huge case of over-engineering and would unnecessarily complicate this. Currently English Wikipedia seems t... [17:58:01] Reedy: got my recent pm by any chance? [17:58:42] (03CR) 10Physikerwelt: Separating MediaWiki specific files from MathJax module (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [17:58:52] (03PS1) 10Aaron Schulz: Enabled $wgUseLinkNamespaceDBFields [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/154100 [18:02:27] (03CR) 10Parent5446: [C: 032] "I agree with Legoktm, but in the end we're going to remove them eventually, and now is as good a time as ever." [core] - 10https://gerrit.wikimedia.org/r/150762 (owner: 10Withoutaname) [18:06:38] (03Merged) 10jenkins-bot: Remove various functions and globals deprecated since 1.22 from RecentChange [core] - 10https://gerrit.wikimedia.org/r/150762 (owner: 10Withoutaname) [18:07:28] (03CR) 10Nemo bis: "typosssssssssssssss" [core] - 10https://gerrit.wikimedia.org/r/152986 (owner: 10Lewis Cawte) [18:09:59] (03CR) 10Parent5446: "Note: I just updated the documentation accordingly." [core] - 10https://gerrit.wikimedia.org/r/150762 (owner: 10Withoutaname) [18:11:26] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c25 (10Jon) (In reply to Stefan2 from comment #16) > I think that the problem is that the MediaWiki namespace can be edited by > any administrator. Many a... [18:12:13] (03CR) 10Parent5446: [C: 031] "Keep in mind that while Doxygen may not support this notation, IDEs do. Having the type at the beginning is necessary for proper type infe" [core] - 10https://gerrit.wikimedia.org/r/153833 (owner: 10Umherirrender) [18:12:56] 3MediaWiki / 3Redirects: Redirect [[User:Name/skin.js]] to current skin's JS page (e.g. [[User:Name/vector.js]]) - 10https://bugzilla.wikimedia.org/69555#c3 (10Jesús Martínez Novo (Ciencia Al Poder)) p:5Unprio>3Low s:5normal>3enhanc I like Bartosz idea. I agree that we don't lose much if skin.js isn'... [18:17:18] (03PS1) 10Anomie: API: Log usage of various deprecated features [core] - 10https://gerrit.wikimedia.org/r/154101 [18:17:54] (03CR) 10Jdlrobson: [C: 032] "It does what it says it does.. :)" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/153430 (owner: 10JGonera) [18:18:13] (03Merged) 10jenkins-bot: Styling fixes to CPB [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/153430 (owner: 10JGonera) [18:20:28] (03CR) 10Hoo man: [C: 04-1] "This would force us to submit per hand... can't we stick with the current workflow unless we can switch back to WMF's jenkins?" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/154058 (owner: 10Jeroen De Dauw) [18:21:23] (03CR) 10Jdlrobson: Don't limit the height of CPB (031 comment) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/153437 (https://bugzilla.wikimedia.org/65285) (owner: 10JGonera) [18:22:02] (03CR) 10Prtksxna: [C: 032 V: 032] add compact setting for generated CSS [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153954 (owner: 10Microchip08) [18:22:39] (03CR) 10Jdlrobson: [C: 04-2] "Dependency will need to be merged first." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/153854 (owner: 10Jdlrobson) [18:22:57] (03PS4) 10Jdlrobson: Begin deprecation of mediawiki.ui style module [core] - 10https://gerrit.wikimedia.org/r/151791 [18:24:00] (03PS1) 10Umherirrender: Add missing @param to function docs [core] - 10https://gerrit.wikimedia.org/r/154102 [18:26:20] (03CR) 10Jdlrobson: "It does say this title might contain long text which I think could be bikeshedded to be semantic :) it is in fact a shortened form of a wo" [core] - 10https://gerrit.wikimedia.org/r/151792 (owner: 10Jdlrobson) [18:26:58] 3MediaWiki / 3API: Page with less than 5,000 revisions can't be deleted - 10https://bugzilla.wikimedia.org/69556 (10Marios Magioladitis) 3UNCO p:3Unprio s:3normal a:3None Trying to delete https://en.wikipedia.org/wiki/Wikipedia:AutoWikiBrowser/Sandbox gives an error https://en.wikipedia.org/w/inde... [18:27:19] (03PS1) 10EBernhardson: Revert "Merge remote-tracking branch 'gerrit/master' into two_tabs" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154103 [18:27:26] 3MediaWiki / 3Internationalization: Specify default language on a per-page basis - 10https://bugzilla.wikimedia.org/9360#c24 (10varnent) This was brought up on mailing list earlier today. I am pleased to hear that this is near completion. The Affiliations Committee has committed to helping Wikimedia movement... [18:27:29] (03PS1) 10EBernhardson: Revert "Merge remote-tracking branch 'gerrit/master' into two_tabs" [extensions/Echo] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154104 [18:27:36] (03CR) 10Jdlrobson: [C: 04-1] "(-1ing for attention please feel free to remove my -1 if you disagree and when you have replied :) - it is possibly I don't completely und" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/153437 (https://bugzilla.wikimedia.org/65285) (owner: 10JGonera) [18:28:04] (03CR) 10Jdlrobson: [C: 032] QA: committing Gemfile.lock [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154071 (owner: 10Cmcmahon) [18:28:13] (03CR) 10Aaron Schulz: [C: 032] Add missing @param to function docs [core] - 10https://gerrit.wikimedia.org/r/154102 (owner: 10Umherirrender) [18:30:08] (03Merged) 10jenkins-bot: QA: committing Gemfile.lock [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154071 (owner: 10Cmcmahon) [18:30:27] (03CR) 10Jdlrobson: [C: 032] Hygiene: Cleanup mismatched function parameters warning [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151245 (owner: 10EBernhardson) [18:30:51] (03CR) 10EBernhardson: [C: 032] Revert "Merge remote-tracking branch 'gerrit/master' into two_tabs" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154103 (owner: 10EBernhardson) [18:31:43] (03PS9) 10Jdlrobson: Make Special:UserLogin form use mw-ui-checkbox [core] - 10https://gerrit.wikimedia.org/r/149476 [18:32:39] (03Merged) 10jenkins-bot: Revert "Merge remote-tracking branch 'gerrit/master' into two_tabs" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154103 (owner: 10EBernhardson) [18:32:47] (03Merged) 10jenkins-bot: Hygiene: Cleanup mismatched function parameters warning [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151245 (owner: 10EBernhardson) [18:34:22] (03Merged) 10jenkins-bot: Add missing @param to function docs [core] - 10https://gerrit.wikimedia.org/r/154102 (owner: 10Umherirrender) [18:35:00] (03CR) 10Jdlrobson: [C: 031] "happy with TheDJ's change. works as expected" [core] - 10https://gerrit.wikimedia.org/r/149476 (owner: 10Jdlrobson) [18:36:41] 3MediaWiki / 3Page deletion: Page with less than 5,000 revisions can't be deleted - 10https://bugzilla.wikimedia.org/69556#c1 (10Brad Jorsch) Not an API bug. You're not even using the API there. The situation here is that the action=delete check is using a fast estimate for the revision count instead of act... [18:38:26] 3MediaWiki / 3Page deletion: Page with less than 5,000 revisions can't be deleted - 10https://bugzilla.wikimedia.org/69556#c2 (10Marius Hoch) I have worked on this very briefly: https://gerrit.wikimedia.org/r/131264 But it needs more love. [18:44:39] (03CR) 10TheDJ: [C: 032] "in that case, let's indeed do this." [core] - 10https://gerrit.wikimedia.org/r/149476 (owner: 10Jdlrobson) [18:45:51] (03Abandoned) 10EBernhardson: Set defaultbranch in .gitreview to two_tabs [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153640 (owner: 10Spage) [18:46:27] (03PS1) 10Bsitu: Revert "Revert "Merge remote-tracking branch 'gerrit/master' into two_tabs"" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154110 [18:46:35] (03CR) 10EBernhardson: [C: 032] Create chevron using pseudo elements [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153885 (owner: 10Jdlrobson) [18:46:57] (03CR) 10Bsitu: [C: 032] Revert "Revert "Merge remote-tracking branch 'gerrit/master' into two_tabs"" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154110 (owner: 10Bsitu) [18:47:35] (03Merged) 10jenkins-bot: Create chevron using pseudo elements [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153885 (owner: 10Jdlrobson) [18:47:40] (03CR) 10EBernhardson: [C: 032] Create notification overlay in the body [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153886 (owner: 10Jdlrobson) [18:47:43] (03Merged) 10jenkins-bot: Revert "Revert "Merge remote-tracking branch 'gerrit/master' into two_tabs"" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154110 (owner: 10Bsitu) [18:48:08] (03Merged) 10jenkins-bot: Create notification overlay in the body [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153886 (owner: 10Jdlrobson) [18:48:11] (03CR) 10EBernhardson: [C: 032] E2f: mark all as read behaviour [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153997 (owner: 10Jdlrobson) [18:48:44] (03Merged) 10jenkins-bot: E2f: mark all as read behaviour [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153997 (owner: 10Jdlrobson) [18:48:47] (03Merged) 10jenkins-bot: Make Special:UserLogin form use mw-ui-checkbox [core] - 10https://gerrit.wikimedia.org/r/149476 (owner: 10Jdlrobson) [18:49:35] (03CR) 10EBernhardson: [C: 032] Add support to mark all as read for "sections" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153960 (owner: 10Bsitu) [18:49:42] (03CR) 10Bartosz Dziewoński: "/me braces" [core] - 10https://gerrit.wikimedia.org/r/149476 (owner: 10Jdlrobson) [18:50:16] (03PS32) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [18:50:26] (03CR) 10Aaron Schulz: Don't estimate the revision count for page deletions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/131264 (owner: 10Hoo man) [18:50:33] MatmaRex: for what ? [18:50:37] (03Abandoned) 10EBernhardson: WIP: Needs API change - only mark messages as read [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153738 (owner: 10Jdlrobson) [18:50:49] thedj: for the incoming hate. duh [18:50:57] oh. yeah prolly [18:51:01] (03CR) 10All1: "fixed indentation in patch 32" (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [18:51:04] (03Merged) 10jenkins-bot: Add support to mark all as read for "sections" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153960 (owner: 10Bsitu) [18:51:41] i hope design is prepared to take it on. it's as good as it can be. [18:51:51] (03PS1) 10EBernhardson: Merge remote-tracking branch 'gerrit/two_tabs' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154113 [18:52:06] the checkboxes really look pretty silly [18:52:09] someone in the office should tell them prolly [18:52:24] i really hope jon's shock tactics are going to result in something good here [18:52:30] (03CR) 10EBernhardson: [C: 032] Merge remote-tracking branch 'gerrit/two_tabs' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154113 (owner: 10EBernhardson) [18:52:58] (03Merged) 10jenkins-bot: Merge remote-tracking branch 'gerrit/two_tabs' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154113 (owner: 10EBernhardson) [18:53:41] (03Abandoned) 10EBernhardson: Revert "Merge remote-tracking branch 'gerrit/master' into two_tabs" [extensions/Echo] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154104 (owner: 10EBernhardson) [18:55:04] (03Abandoned) 10EBernhardson: Create chevron using pseudo elements [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152826 (owner: 10Jdlrobson) [18:55:27] (03Abandoned) 10EBernhardson: Create notification overlay in the body [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152827 (owner: 10Jdlrobson) [18:55:43] (03CR) 10Hoo man: "Two comments about a way forward which I'd like to agree on." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/131264 (owner: 10Hoo man) [18:56:53] (03CR) 10Awjrichards: Fix HTTPS protocol detection (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116943 (https://bugzilla.wikimedia.org/46511) (owner: 10Yarda) [18:59:27] 3MediaWiki extensions / 3FundraisingChart: Security review for mediawiki/extensions/FundraisingChart - 10https://bugzilla.wikimedia.org/66805#c6 (10Chris Steipp) (In reply to Chris Steipp from comment #5) > I'm still working on d3. I think it should be fine, but I noticed the > included version is very old.... [18:59:41] 3Wikimedia / 3Mailing lists: list archives redirect to http-only - 10https://bugzilla.wikimedia.org/69560 (10Greg Grossmeier) p:5Unprio>3Normal [18:59:44] 3Wikimedia / 3Mailing lists: list archives redirect to http-only - 10https://bugzilla.wikimedia.org/69560 (10Greg Grossmeier) 3NEW p:3Unprio s:3normal a:3None Go to eg: https://lists.wikimedia.org/mailman/listinfo/wikitech-l (notice https) click on the archive link, which you'll notice is hardcoded... [19:00:08] (03PS1) 10Yurik: Updated Graph submodule [extensions] - 10https://gerrit.wikimedia.org/r/154114 [19:00:18] (03CR) 10Yurik: [C: 032 V: 032] Updated Graph submodule [extensions] - 10https://gerrit.wikimedia.org/r/154114 (owner: 10Yurik) [19:01:48] (03CR) 10Legoktm: "This has now happened, the extension is no longer deployed and can be removed from TWN." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/149785 (https://bugzilla.wikimedia.org/55678) (owner: 10Legoktm) [19:02:13] 3Wikimedia / 3General/Unknown: Move WikimediaShopLink's i18n messages to WikimediaMessages extension and move the Skin hook to wmf-config - 10https://bugzilla.wikimedia.org/55678 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Kunal Mehta (Legoktm) [19:02:26] 3Wikimedia / 3General/Unknown: Move code in enwiki MediaWiki:Common.js to MediaWiki software - 10https://bugzilla.wikimedia.org/69550#c7 (10Helder) What about setting $wgUseSiteJs = false on wikis where these scripts were migrated into default gadgets and recommending that as the way to customize the site? [19:05:07] (03CR) 10CSteipp: [C: 031] Changed password default to PBKDF2 [core] - 10https://gerrit.wikimedia.org/r/149658 (https://bugzilla.wikimedia.org/28419) (owner: 10Parent5446) [19:08:35] (03PS3) 10Legoktm: Changed password default to PBKDF2 [core] - 10https://gerrit.wikimedia.org/r/149658 (https://bugzilla.wikimedia.org/28419) (owner: 10Parent5446) [19:08:41] 3Wikimedia / 3Site requests: Change upload settings on fa.wikipedia - 10https://bugzilla.wikimedia.org/69171 (10Calak) 5PATC>3RESO/FIX [19:09:26] 3Wikimedia / 3Site requests: Increase $wgAutoConfirmAge and $wgAutoConfirmCount on nowiki - 10https://bugzilla.wikimedia.org/69302#c1 (10Calak) 5NEW>3RESO/FIX https://gerrit.wikimedia.org/r/#/c/153848/ [19:09:27] (03CR) 10Legoktm: [C: 032] "PS3: Rebase for RELEASE-NOTES. Yay!" [core] - 10https://gerrit.wikimedia.org/r/149658 (https://bugzilla.wikimedia.org/28419) (owner: 10Parent5446) [19:09:56] 3Wikimedia / 3Site requests: Change user groups rights on ckb.wikipedia - 10https://bugzilla.wikimedia.org/69394 (10Calak) 5PATC>3RESO/FIX [19:10:33] legoktm, what happened with https://gerrit.wikimedia.org/r/#/c/149787/ ? [19:10:45] the beta cluster deployment fail [19:10:53] er? [19:11:11] 3Wikimedia / 3OTRS: Line breaks missing after salutations and before signature lines - 10https://bugzilla.wikimedia.org/55681#c6 (10Yellowcard) +1. This bug is actually annoying. As a fix seems available, I'd really appreciate it to be deployed. [19:11:20] :o [19:11:27] 18:41:15 java.io.IOException: Failed to create a temp file on /mnt/home/jenkins-deploy/workspace/beta-mediawiki-config-update-eqiad [19:11:41] I don't see a hashar? [19:11:49] WHAT DID YOU DO. [19:12:12] hola getting loads of "Error: Working directory '/vagrant/mediawiki/extensions/CentralAuth/tests/browser' does not exist" even with the role disabled [19:12:13] you bork it [19:12:56] 3MediaWiki extensions / 3Gadgets: Gadget usage statistics - 10https://bugzilla.wikimedia.org/19288#c6 (10Yuvi Panda) Since Toollabs doesn't have gadget usage info, I guess we could instead generate this as a report on stat1003 and make it available on an ongoing basis as a CSV from there. I could work on it... [19:14:12] 3Wikimedia / 3OTRS: Line breaks missing after salutations and before signature lines - 10https://bugzilla.wikimedia.org/55681#c7 (10Patrik (pajz)) Just note the upstream fix is implemented in 3.3 (we're currently on 3.2). [19:14:13] 3MediaWiki extensions / 3MathSearch: Develop a search bar - 10https://bugzilla.wikimedia.org/69561 (10physikerwelt) 3NEW p:3Unprio s:3normal a:3None Currently MathSearch is done via the page Special:MathSearch Inspired by https://github.com/DRMF/DRMF/issues/9 we could use the default search bar to... [19:14:26] 3MediaWiki extensions / 3MathSearch: Develop a search bar - 10https://bugzilla.wikimedia.org/69561 (10physikerwelt) p:5Unprio>3Lowest s:5normal>3enhanc [19:15:00] legoktm, just wanted to make sure you noticed that :) [19:15:16] (03PS1) 10Aude: Update Wikidata branch [tools/release] - 10https://gerrit.wikimedia.org/r/154116 [19:16:26] (03Merged) 10jenkins-bot: Changed password default to PBKDF2 [core] - 10https://gerrit.wikimedia.org/r/149658 (https://bugzilla.wikimedia.org/28419) (owner: 10Parent5446) [19:21:08] (03CR) 10Frédéric Wang: Protect MathML from Tidy (032 comments) [core] - 10https://gerrit.wikimedia.org/r/154083 (https://bugzilla.wikimedia.org/66516) (owner: 10Physikerwelt) [19:22:28] 3MediaWiki / 3Page deletion: Avoid checking for large revision count on action=delete if the user doesn't have delete permission - 10https://bugzilla.wikimedia.org/69562 (10Jesús Martínez Novo (Ciencia Al Poder)) 3NEW p:3Unprio s:3trivia a:3None When doing action=delete on a page, MediaWiki is checki... [19:24:56] (03CR) 10Frédéric Wang: [C: 031] Ignore local browsertest files [extensions/Math] - 10https://gerrit.wikimedia.org/r/154060 (owner: 10Physikerwelt) [19:26:28] 3MediaWiki extensions / 3WikiEditor: document.selection no longer supported in IE11 - 10https://bugzilla.wikimedia.org/66531#c12 (10Derk-Jan Hartman) 5ASSI>3RESO/DUP Actually this was already solved in a newer version of MediaWiki core. See the information in the other ticket. *** This bug has been mark... [19:26:28] 3MediaWiki extensions / 3WikiEditor: document.selection.createRange should not be unconditionally accessed in MSIE (document.selection was removed in IE11) - 10https://bugzilla.wikimedia.org/57489#c10 (10Derk-Jan Hartman) *** Bug 66531 has been marked as a duplicate of this bug. *** [19:31:02] (03PS1) 10Aude: Update Wikidata (test.wikidata) to mw1.24-wmf17 branch [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154119 [19:31:15] (03PS4) 10Bartosz Dziewoński: WIP: Stop using DOM as an api. Start a Skin api for the watchstar [core] - 10https://gerrit.wikimedia.org/r/153855 (owner: 10Jdlrobson) [19:31:31] (03CR) 10Hashar: "This change has been reverted by https://gerrit.wikimedia.org/r/#/c/151522/" [core] - 10https://gerrit.wikimedia.org/r/146683 (owner: 10Aaron Schulz) [19:32:17] (03CR) 10Bartosz Dziewoński: "I fixed the directory layout because this just irks me too much, and the IIFE while I was at it." [core] - 10https://gerrit.wikimedia.org/r/153855 (owner: 10Jdlrobson) [19:33:36] (03CR) 10Aaron Schulz: Don't estimate the revision count for page deletions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/131264 (owner: 10Hoo man) [19:33:49] (03CR) 10Hashar: "Gerrit says that the patch https://gerrit.wikimedia.org/r/#/c/146683/ is included in branches:" [core] - 10https://gerrit.wikimedia.org/r/151522 (https://bugzilla.wikimedia.org/69082) (owner: 10Cscott) [19:35:38] (03PS1) 10Umherirrender: Add missing @param to function docs [core] - 10https://gerrit.wikimedia.org/r/154120 [19:37:00] (03CR) 10Frédéric Wang: "Does it work?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [19:37:29] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I think we really should think about this first and write code later. We already have enough shitty APIs, let's come up with a good one fo" [core] - 10https://gerrit.wikimedia.org/r/153855 (owner: 10Jdlrobson) [19:38:04] (03CR) 10jenkins-bot: [V: 04-1] WIP: Stop using DOM as an api. Start a Skin api for the watchstar [core] - 10https://gerrit.wikimedia.org/r/153855 (owner: 10Jdlrobson) [19:38:32] (03CR) 10Hoo man: "Ok, will follow up sometime (not sure how soon I can come to this)." [core] - 10https://gerrit.wikimedia.org/r/131264 (owner: 10Hoo man) [19:38:55] (03PS2) 10Umherirrender: Correct type of @param of Linker::getRevDeleteLink [core] - 10https://gerrit.wikimedia.org/r/154091 [19:38:58] (03PS2) 10Umherirrender: Add missing @param to function docs [core] - 10https://gerrit.wikimedia.org/r/154120 [19:39:04] (03PS2) 10Umherirrender: Remove wrong type from @param on ContentHandler::merge3 [core] - 10https://gerrit.wikimedia.org/r/154097 [19:39:06] (03PS2) 10MarkTraceur: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 [19:39:12] (03PS2) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [19:40:15] (03CR) 10jenkins-bot: [V: 04-1] Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 (owner: 10MarkTraceur) [19:40:18] (03CR) 10jenkins-bot: [V: 04-1] Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 (owner: 10MarkTraceur) [19:42:33] marxarelli, I'm not sure if 33 failures are caused by our changes or connectivity problems: https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/lastCompletedBuild/testReport/ [19:42:53] marxarelli, "optional 'domain' invalid (Selenium::WebDriver::Error::UnknownError)" seems to be the most common error [19:43:14] (03CR) 10Physikerwelt: "It works on most on the pages that we tested." [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [19:47:52] (03CR) 10Cscott: "@hashar: Well, parserTests aren't used in deployment, so it's probably not worth chasing it down on all the branches. I'd consider chasin" [core] - 10https://gerrit.wikimedia.org/r/151522 (https://bugzilla.wikimedia.org/69082) (owner: 10Cscott) [19:49:33] (03CR) 10Aaron Schulz: [C: 032] Add missing @param to function docs [core] - 10https://gerrit.wikimedia.org/r/154120 (owner: 10Umherirrender) [19:51:24] (03PS1) 10Jdlrobson: Fix styling of deletion page [core] - 10https://gerrit.wikimedia.org/r/154121 [19:51:39] (03PS5) 10MarkTraceur: Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 [19:51:42] (03PS3) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [19:51:45] (03PS3) 10MarkTraceur: Move setSkipTutorialPreference to Tutorial class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153413 [19:51:48] (03PS3) 10MarkTraceur: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 [19:51:51] (03PS5) 10MarkTraceur: Add controllers for each step - mostly stubs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151699 [19:51:54] (03PS3) 10Physikerwelt: Protect MathML from Tidy [core] - 10https://gerrit.wikimedia.org/r/154083 (https://bugzilla.wikimedia.org/66516) [19:51:56] (03CR) 10jenkins-bot: [V: 04-1] Fix styling of deletion page [core] - 10https://gerrit.wikimedia.org/r/154121 (owner: 10Jdlrobson) [19:51:58] (03CR) 10Physikerwelt: Protect MathML from Tidy (031 comment) [core] - 10https://gerrit.wikimedia.org/r/154083 (https://bugzilla.wikimedia.org/66516) (owner: 10Physikerwelt) [19:52:08] jgonera: that may have something to do with the "using mobile site" cookie [19:52:53] (03Merged) 10jenkins-bot: Add missing @param to function docs [core] - 10https://gerrit.wikimedia.org/r/154120 (owner: 10Umherirrender) [19:53:11] (03CR) 10jenkins-bot: [V: 04-1] Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 (owner: 10MarkTraceur) [19:53:44] (03CR) 10jenkins-bot: [V: 04-1] Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 (owner: 10MarkTraceur) [19:55:44] (03CR) 10Hashar: "@Cscott sounds good :-)" [core] - 10https://gerrit.wikimedia.org/r/151522 (https://bugzilla.wikimedia.org/69082) (owner: 10Cscott) [19:59:07] (03PS1) 10TheDJ: Dialogs: Reset values of file insertion dialog properly [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/154123 (https://bugzilla.wikimedia.org/67111) [19:59:12] (03CR) 10jenkins-bot: [V: 04-1] Dialogs: Reset values of file insertion dialog properly [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/154123 (https://bugzilla.wikimedia.org/67111) (owner: 10TheDJ) [20:00:12] (03PS2) 10TheDJ: Dialogs: Reset values of file insertion dialog properly [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/154123 (https://bugzilla.wikimedia.org/67111) [20:00:15] (03CR) 10jenkins-bot: [V: 04-1] Dialogs: Reset values of file insertion dialog properly [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/154123 (https://bugzilla.wikimedia.org/67111) (owner: 10TheDJ) [20:00:31] (03PS1) 10EBernhardson: Repair beta labs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154124 [20:00:56] (03PS2) 10EBernhardson: Repair beta labs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154124 (https://bugzilla.wikimedia.org/68531) [20:02:08] (03PS1) 10Jdlrobson: Tweak checkbox sizes to be relative depending on where used. [core] - 10https://gerrit.wikimedia.org/r/154125 [20:02:25] (03PS3) 10TheDJ: Dialogs: Reset values of file insertion dialog properly [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/154123 (https://bugzilla.wikimedia.org/67111) [20:02:35] (03CR) 10jenkins-bot: [V: 04-1] Tweak checkbox sizes to be relative depending on where used. [core] - 10https://gerrit.wikimedia.org/r/154125 (owner: 10Jdlrobson) [20:03:27] (03PS4) 10MarkTraceur: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 [20:03:28] 3MediaWiki extensions / 3GoogleLogin: GoogleLogin breaks webinstaller (mw-config) - 10https://bugzilla.wikimedia.org/69564 (10Florian) 3NEW p:3Unprio s:3normal a:3None When GoogleLoign installed, wgAuth breaks the use of the webinstaller to update database schema. [20:03:49] (03PS4) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [20:03:56] 3MediaWiki extensions / 3GoogleLogin: GoogleLogin breaks webinstaller (mw-config) - 10https://bugzilla.wikimedia.org/69564#c1 (10Florian) Comes from: https://www.mediawiki.org/wiki/Thread:Extension_talk:GoogleLogin/Breaks_mw-config [20:04:04] marktraceur: haha. "sort of" :) [20:04:16] (03CR) 10jenkins-bot: [V: 04-1] Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 (owner: 10MarkTraceur) [20:04:47] anyone around to help me find out why hhvm on vagrant keeps timing out? [20:05:20] most frequently it happens with all load.php requests [20:05:28] thedj: Best I can do... [20:05:35] sometimes after load.php hangs, index.php also hangs [20:05:44] (03PS5) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [20:05:53] thedj: This is a damned mess, trying to get this to make any sense at all [20:06:10] restarting the hhvm service usually solves it, but only for seconds/minutes [20:06:23] I'm angling for having steps and acting on uploads and having UI classes and and and...but it's all real slow [20:07:26] (03CR) 10Hashar: [C: 04-1] "Can you please add a test covering that in tests/phpunit/includes/parser/TidyTest.php ?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/154083 (https://bugzilla.wikimedia.org/66516) (owner: 10Physikerwelt) [20:10:01] marktraceur: i know... [20:11:11] 3MediaWiki / 3User login and signup: Replace MD5 password hashing with more secure hash - 10https://bugzilla.wikimedia.org/28419 (10Tyler Romeo) 5PATC>3RESO/FIX [20:11:57] * marktraceur moves newUpload into a step controller. [20:12:02] If I'm not back in two days, send help [20:13:11] (03CR) 10Jdlrobson: [C: 031] "I0ef9eeb9f9d3403f79ee9960b075fb7062150a1d got merged. This works." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151537 (owner: 10Bsitu) [20:13:11] 3Wikimedia / 3Site requests: Add "botadmin" user group on fa.wikipedia - 10https://bugzilla.wikimedia.org/69411#c1 (10Calak) 5NEW>3PATC https://gerrit.wikimedia.org/r/#/c/154126/ [20:13:22] (03PS5) 10Jdlrobson: Flow notification item new style [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151537 (https://bugzilla.wikimedia.org/69563) (owner: 10Bsitu) [20:14:41] 3MediaWiki extensions / 3Gadgets: Gadget usage statistics - 10https://bugzilla.wikimedia.org/19288#c7 (10Quiddity) (In reply to Yuvi Panda from comment #6) > Since Toollabs doesn't have gadget usage info, I guess we could instead > generate this as a report on stat1003 and make it available on an ongoing > b... [20:16:26] (03PS6) 10Jdlrobson: Flow notification item new style [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151537 (owner: 10Bsitu) [20:16:33] (03CR) 10Jdlrobson: [C: 032] Flow notification item new style [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151537 (owner: 10Bsitu) [20:16:50] (03PS1) 10Ebe123: Create sub-statuses for invalid and rejected test-wikis [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/154127 [20:17:05] (03CR) 10jenkins-bot: [V: 04-1] Create sub-statuses for invalid and rejected test-wikis [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/154127 (owner: 10Ebe123) [20:17:10] jgonera: i haven't run tests against saucelabs yet so i'll need to tinker with this a bit, but i think it can be fixed by adding a domain to the cookie [20:17:15] (03Merged) 10jenkins-bot: Flow notification item new style [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151537 (owner: 10Bsitu) [20:18:03] jgonera: it appears that the chrome driver (yet again) behaves differently in some cases with respect to cookies [20:18:06] https://groups.google.com/forum/#!msg/selenium-users/OcUPavQj8Y4/fJ-Mv9cJqbAJ [20:18:17] (03CR) 10EBernhardson: [C: 032] Add TargetPage model and mapper to notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151992 (owner: 10Bsitu) [20:18:38] (03PS1) 10TheDJ: Undefined function mw.log.error [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/154128 (https://bugzilla.wikimedia.org/68557) [20:18:45] (03Merged) 10jenkins-bot: Add TargetPage model and mapper to notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151992 (owner: 10Bsitu) [20:18:48] (03PS1) 10Bartosz Dziewoński: Never cache pages with the fallback skin [core] - 10https://gerrit.wikimedia.org/r/154129 (https://bugzilla.wikimedia.org/69284) [20:19:19] (03CR) 10EBernhardson: [C: 04-2] "needs to be updated wrt changes in https://gerrit.wikimedia.org/r/#/c/153960" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152198 (owner: 10Bsitu) [20:19:28] 3MediaWiki extensions / 3CentralAuth: BadMethodCallException with "Call to a member function getId" in SpecialCentralLogin.php on Beta Labs - 10https://bugzilla.wikimedia.org/69565 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None Upon going to Special:UserLogin on English Wikipedia on Beta Labs... [20:20:51] (03CR) 10Bartosz Dziewoński: [C: 032] Undefined function mw.log.error [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/154128 (https://bugzilla.wikimedia.org/68557) (owner: 10TheDJ) [20:21:53] (03CR) 10Bartosz Dziewoński: "Is this the right way to do this?" [core] - 10https://gerrit.wikimedia.org/r/154129 (https://bugzilla.wikimedia.org/69284) (owner: 10Bartosz Dziewoński) [20:22:24] (03CR) 10Spage: "Seems good, some suggestions on the PHP style. I think they apply to PS2 too." (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154124 (https://bugzilla.wikimedia.org/68531) (owner: 10EBernhardson) [20:22:33] (03PS1) 10Jdlrobson: Prevent horizontal scroll bars in Firefox [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154131 (https://bugzilla.wikimedia.org/69563) [20:23:19] (03Merged) 10jenkins-bot: Undefined function mw.log.error [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/154128 (https://bugzilla.wikimedia.org/68557) (owner: 10TheDJ) [20:24:14] 3MediaWiki / 3Skin and page rendering: Sporadic reports of users being served MW with no skins on 1.24wmf17 - 10https://bugzilla.wikimedia.org/69566 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3None Seems there's been at least a couple of reports of this so far... [20:25:24] (03PS1) 10Brian Wolff: Make sure processResponsiveImages checks for valid thumb object [core] - 10https://gerrit.wikimedia.org/r/154132 [20:25:30] 3MediaWiki extensions / 3Gadgets: Gadget usage statistics - 10https://bugzilla.wikimedia.org/19288#c8 (10Helder) (In reply to Quiddity from comment #7) > Ideally, it would be filterable by (wiki / user activity / user right / > account age / etc ) ...and also by default status: enabled / disabled for all use... [20:26:01] (03PS2) 10Ebe123: Create sub-statuses for invalid and rejected test-wikis [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/154127 [20:26:09] (03CR) 10Daniel Friesen: "What's the point of this? We don't use max-age. If you want to ensure that we don't return 304s when the skin is changed include the skin " [core] - 10https://gerrit.wikimedia.org/r/154129 (https://bugzilla.wikimedia.org/69284) (owner: 10Bartosz Dziewoński) [20:27:05] (03CR) 10Yurik: [C: 032 V: 032] "will kill it myself :)" [extensions/Limn] - 10https://gerrit.wikimedia.org/r/153753 (owner: 10Yurik) [20:27:33] (03CR) 10Bartosz Dziewoński: "I don't know what the point is, probably related to WMF caching setup. Legoktm said that Krinkle asked for it, and these two people usuall" [core] - 10https://gerrit.wikimedia.org/r/154129 (https://bugzilla.wikimedia.org/69284) (owner: 10Bartosz Dziewoński) [20:30:03] (03PS3) 10EBernhardson: Repair beta labs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154124 [20:30:09] (03CR) 10EBernhardson: Repair beta labs (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154124 (owner: 10EBernhardson) [20:33:44] I did what now [20:36:25] leg [20:36:30] legoktm: https://bugzilla.wikimedia.org/show_bug.cgi?id=69566 [20:36:43] 3MediaWiki / 3Skin and page rendering: Sporadic reports of users being served MW with no skins on 1.24wmf17 - 10https://bugzilla.wikimedia.org/69566#c1 (10Bartosz Dziewoński) Created attachment 16195 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16195&action=edit Screenshot by Mutante [20:36:54] oh hmmm [20:37:09] do we need to normalize the key first? [20:37:29] normalize it where? [20:37:47] in RequestContext::getSkin() [20:37:50] we probably do normalize it eveyrwhere, or at least strtolower() it [20:37:58] or somewhere in that codepath. [20:38:21] $userSkin = $this->getUser()->getOption( 'skin' ); [20:38:30] we don't validate to see if the user has a valid skin in their preferences do we? [20:38:43] (03PS1) 10Florianschmidtwelzow: Fix WebInstaller-Break [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/154134 (https://bugzilla.wikimedia.org/69564) [20:39:27] hmmmmm [20:39:37] (03PS2) 10Florianschmidtwelzow: Fix WebInstaller-Break [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/154134 (https://bugzilla.wikimedia.org/69564) [20:39:38] we should set $wgFallbackSkin = 'vector' on the cluster [20:39:42] 3MediaWiki extensions / 3Math: MathML elements are filtered out on betalabs - 10https://bugzilla.wikimedia.org/66495#c2 (10physikerwelt) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 66516 *** [20:39:43] indeed [20:39:47] no, not indeed [20:40:03] indeed we don't nornmalize the key from preferences, and we should [20:40:04] right now if you do ?useskin=akdshfsdhf it should go to fallback [20:40:17] because someone might still have 'nostalgia' set there if they didn't changes their prefs for years [20:40:25] that should result in default skin, not fallback skin [20:40:32] right. [20:41:03] well that was easy debugging! [20:41:25] setting the fallback skin to vector would be rather silly and would mask bugs like this [20:41:37] > var_dump(User::newFromName('Mutante')->getOption('skin')); [20:41:37] string(0) "" [20:41:37] wat [20:41:47] if anything, we could log invalid skin keys passed to SkinFactory::makeSkin [20:41:49] legoktm: hah [20:41:55] he must have not changes his prefs since 2005 or so, then [20:42:00] not changed* [20:42:14] Skin::normalizeKey() has that special-cased [20:42:15] [12:47:03] i dont get it from a different appserver and in a different browser [20:42:25] server gnomes [20:42:42] we should definitely normalize that anyway [20:42:48] Reedy: [20:42:58] ok, I'll submit a patch in a few [20:43:01] seoncds [20:43:22] aye [20:44:00] (03PS3) 10Florianschmidtwelzow: Fix WebInstaller-Break [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/154134 (https://bugzilla.wikimedia.org/69564) [20:46:59] * legoktm stabs gerrit [20:47:41] 3Wikimedia / 3Deployment systems: [scap] Sync fewer files from old deploy branches - 10https://bugzilla.wikimedia.org/66053 (10Greg Grossmeier) p:5Unprio>3Normal [20:47:54] (03PS1) 10Legoktm: Normalize key before creating a Skin object [core] - 10https://gerrit.wikimedia.org/r/154138 (https://bugzilla.wikimedia.org/69566) [20:47:56] 3Wikimedia / 3Deployment systems: [scap] Add a command line flag to replace DOLOGMSGNOLOG - 10https://bugzilla.wikimedia.org/66049 (10Greg Grossmeier) p:5Unprio>3Normal [20:48:01] MatmaRex: ^ [20:48:26] 3Wikimedia / 3Deployment systems: [scap] Deploy events aren't showing up in graphite/gdash - 10https://bugzilla.wikimedia.org/62667 (10Greg Grossmeier) p:5Normal>3High [20:49:05] (03CR) 10Raimond Spekking: "Thanks for the info. I have disabled the Shop extension on translatewiki.net today." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/149785 (https://bugzilla.wikimedia.org/55678) (owner: 10Legoktm) [20:49:21] (03CR) 10Bartosz Dziewoński: [C: 032] Normalize key before creating a Skin object [core] - 10https://gerrit.wikimedia.org/r/154138 (https://bugzilla.wikimedia.org/69566) (owner: 10Legoktm) [20:49:35] (03PS5) 10Bsitu: Mark notification as read upon visiting a page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152198 [20:49:41] legoktm: hmm [20:49:42] (03PS1) 10Legoktm: Normalize key before creating a Skin object [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154139 (https://bugzilla.wikimedia.org/69566) [20:49:43] 3MediaWiki extensions / 3RSS: Dynamic Parameters in Feed URLs - 10https://bugzilla.wikimedia.org/69571 (10Kaboomki) 3UNCO p:3Unprio s:3enhanc a:3None Hi, as already mentioned in the first thread on [https://www.mediawiki.org/wiki/Extension_talk:RSS#x.5BWONTFIX.3B_WORKSFORME.3B_SPECIAL_USER_ISSUE.5D_R... [20:49:46] (03CR) 10Bartosz Dziewoński: Normalize key before creating a Skin object [core] - 10https://gerrit.wikimedia.org/r/154138 (https://bugzilla.wikimedia.org/69566) (owner: 10Legoktm) [20:49:46] oh? [20:49:56] should we do the same a few lines higher up? [20:50:05] there's the same try-catch pattern [20:50:16] no, because I think the hook should be responsible for being sane [20:50:21] and it should probably also use the default skin, not fallback [20:50:22] hmm [20:50:43] what happens if the default isn't available? [20:50:49] we'd need to fallback again [20:50:55] yes [20:51:07] which we'd let Skin::normalizeKey take care of, hm [20:51:09] but that sounds reasonable to me [20:51:14] and Skin- exactly [20:51:28] so fix it above too yes? [20:51:42] i think it makes sense [20:52:00] (03PS1) 10Mattflaschen: WIP: Enable browser tests for GettingStarted [vagrant] - 10https://gerrit.wikimedia.org/r/154140 [20:52:04] the logic was blurred before because vector was both the fallback and the default skin [20:52:41] but we should definitely never show the fallback skin now if the default skin is available [20:52:47] (03CR) 10Mattflaschen: [C: 04-2] "Blocked on I79d9468e56bc7941c7c5bb27a77d1622bc7d3836" [vagrant] - 10https://gerrit.wikimedia.org/r/154140 (owner: 10Mattflaschen) [20:54:34] * legoktm pokes gerrit again [20:54:38] (03PS2) 10Legoktm: Normalize key before creating a Skin object [core] - 10https://gerrit.wikimedia.org/r/154138 (https://bugzilla.wikimedia.org/69566) [20:54:43] MatmaRex: fixed [20:55:28] 3Wikimedia / 3Deployment systems: [scap] multi datacenter aware without (major) performance hit - 10https://bugzilla.wikimedia.org/69572 (10Greg Grossmeier) p:5Unprio>3High [20:55:28] 3Wikimedia / 3Deployment systems: [scap] multi datacenter aware without (major) performance hit - 10https://bugzilla.wikimedia.org/69572 (10Greg Grossmeier) 3NEW p:3Unprio s:3normal a:3None Scap, obviously, used to deal with multidatacenters (eqiad+tampa), but the way it was implemented caused perfor... [20:57:12] right [20:57:16] (03CR) 10Bartosz Dziewoński: [C: 032] Normalize key before creating a Skin object [core] - 10https://gerrit.wikimedia.org/r/154138 (https://bugzilla.wikimedia.org/69566) (owner: 10Legoktm) [20:57:25] let's see if that fixes it [20:57:37] (03PS2) 10Legoktm: Normalize key before creating a Skin object [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154139 (https://bugzilla.wikimedia.org/69566) [20:57:47] Reedy: ^ [20:57:50] (03CR) 10Bartosz Dziewoński: [C: 04-1] Normalize key before creating a Skin object [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154139 (https://bugzilla.wikimedia.org/69566) (owner: 10Legoktm) [20:57:55] er? [20:58:00] oh heh [20:58:04] i was just =1'ing PS1 [20:58:07] lol [20:58:26] (03PS10) 10Yurik: Set proper SSH URL for all GIT repos (with username) - take 3 [vagrant] - 10https://gerrit.wikimedia.org/r/141500 [20:58:27] and gerrit doesn't mind mid-air collisions [20:58:34] (03PS1) 10Brian Wolff: Fix horribly broken way TMH was generating urls [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/154144 (https://bugzilla.wikimedia.org/69453) [20:58:46] (03CR) 10Hashar: "I proposed a change for Wikimedia cluster configuration to get rid of $wgRateLimitLog in favor of setting $wgDebugLogGroups['ratelimit']:" [core] - 10https://gerrit.wikimedia.org/r/115902 (owner: 10Hashar) [20:59:46] bd808|BUFFER, ori ^^^ fixed SSH URL, if we have it as part of setup, it would be silly not to use it :) [20:59:56] (that was a rebase, not a fix really) [21:00:42] (03CR) 10EBernhardson: Mark notification as read upon visiting a page (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152198 (owner: 10Bsitu) [21:03:28] (03PS11) 10Florianschmidtwelzow: Show Captcha after click on edit over buttons on EditPage [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/136323 (https://bugzilla.wikimedia.org/19648) [21:05:50] (03CR) 10Bartosz Dziewoński: "What is Jenkins smoking again? It voted V+2 but didn't merge…" [core] - 10https://gerrit.wikimedia.org/r/154138 (https://bugzilla.wikimedia.org/69566) (owner: 10Legoktm) [21:06:11] https://integration.wikimedia.org/zuul/ tests are still running [21:06:18] (03PS3) 10Bartosz Dziewoński: Normalize key before creating a Skin object [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154139 (https://bugzilla.wikimedia.org/69566) (owner: 10Legoktm) [21:06:20] the +2 is probably for the new patchset [21:07:05] blergh [21:07:20] (03CR) 10MarkTraceur: [C: 031] "Looks fine, but I'm not totally comfortable merging it..." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/154144 (https://bugzilla.wikimedia.org/69453) (owner: 10Brian Wolff) [21:09:03] bd808|BUFFER, ori, should I revert multiwiki patch? vagrant is broken on windows - https://bugzilla.wikimedia.org/show_bug.cgi?id=69425 [21:11:06] (03PS6) 10Bsitu: Mark notification as read upon visiting a page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152198 [21:11:22] (03PS1) 10Anomie: API: Add a "submodule" param type [core] - 10https://gerrit.wikimedia.org/r/154147 [21:11:25] yurikR: I think both of them are afk/on vacation. [21:11:32] oh bummer [21:11:37] no wonder they are not replying :) [21:11:47] (03PS1) 10Anomie: API: generalized submodules for action=paraminfo [core] - 10https://gerrit.wikimedia.org/r/154148 [21:12:06] (03CR) 10Shirayuki: "See inline." (031 comment) [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/151444 (https://bugzilla.wikimedia.org/68962) (owner: 10Florianschmidtwelzow) [21:12:24] (03CR) 10EBernhardson: [C: 032] Mark notification as read upon visiting a page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152198 (owner: 10Bsitu) [21:12:26] they should have logged off :) [21:12:29] (03PS1) 10Anomie: API: Use 'submodule' param type, when available [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154149 [21:12:44] (03CR) 10Legoktm: [C: 032] "Looks less broken" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/154144 (https://bugzilla.wikimedia.org/69453) (owner: 10Brian Wolff) [21:12:51] (03CR) 10Brian Wolff: "For reference, you could see an example of this bug at https://www.mediawiki.org/wiki/File:South_Africa_National_Anthem.ogg" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/154144 (https://bugzilla.wikimedia.org/69453) (owner: 10Brian Wolff) [21:13:57] (03Abandoned) 10Anomie: ApiParamInfo: Support any instance of ApiModuleManager [core] - 10https://gerrit.wikimedia.org/r/141110 (https://bugzilla.wikimedia.org/30936) (owner: 10Legoktm) [21:14:00] (03Merged) 10jenkins-bot: Mark notification as read upon visiting a page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152198 (owner: 10Bsitu) [21:14:32] (03Merged) 10jenkins-bot: Fix horribly broken way TMH was generating urls [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/154144 (https://bugzilla.wikimedia.org/69453) (owner: 10Brian Wolff) [21:15:30] (03CR) 10Bsitu: [C: 031] Prevent horizontal scroll bars in Firefox [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154131 (https://bugzilla.wikimedia.org/69563) (owner: 10Jdlrobson) [21:17:25] (03PS1) 10Legoktm: Fix horribly broken way TMH was generating urls [extensions/TimedMediaHandler] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/154150 (https://bugzilla.wikimedia.org/69453) [21:17:42] (03PS1) 10Legoktm: Fix horribly broken way TMH was generating urls [extensions/TimedMediaHandler] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154151 (https://bugzilla.wikimedia.org/69453) [21:18:58] (03PS1) 10Jdlrobson: Hygiene: clean up messy less file [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154152 [21:20:28] 3Wikimedia / 3General/Unknown: Next wmf deployment (tracking) - 10https://bugzilla.wikimedia.org/38865 (10Bartosz Dziewoński) [21:20:28] 3MediaWiki / 3Skin and page rendering: Sporadic reports of users being served MW with no skins on 1.24wmf17 - 10https://bugzilla.wikimedia.org/69566#c5 (10Bartosz Dziewoński) 5PATC>3NEW The above patch, when deployed, should fix the issue for logged-in users who haven't changed their preferences in a ver... [21:20:41] (03CR) 10EBernhardson: [C: 04-1] "needs a manual rebase" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152203 (owner: 10Bsitu) [21:21:06] (03CR) 10Bsitu: [C: 032] Hygiene: clean up messy less file [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154152 (owner: 10Jdlrobson) [21:21:20] https://de.wikipedia.org/wiki/Wikipedia:Umfragen/Superschutz [21:22:02] (03CR) 10SG: [C: 032] Prevent horizontal scroll bars in Firefox [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154131 (https://bugzilla.wikimedia.org/69563) (owner: 10Jdlrobson) [21:22:27] (03Merged) 10jenkins-bot: Prevent horizontal scroll bars in Firefox [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154131 (https://bugzilla.wikimedia.org/69563) (owner: 10Jdlrobson) [21:22:31] (03Merged) 10jenkins-bot: Hygiene: clean up messy less file [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154152 (owner: 10Jdlrobson) [21:23:03] where did Reedy go :( [21:23:10] wut [21:23:21] Reedy: https://gerrit.wikimedia.org/r/#/c/154139/ needs deploying [21:23:33] isn't it swat time? ;) [21:23:43] thats in 2 hours, but I guess we could wait [21:24:15] (03CR) 10Reedy: [C: 032] Normalize key before creating a Skin object [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154139 (https://bugzilla.wikimedia.org/69566) (owner: 10Legoktm) [21:24:20] legoktm, are you the one working on no-skins-by-default? [21:24:28] no, that's MatmaRex [21:24:32] i just rebuilt vagrant, and it complains :( [21:24:36] (03PS4) 10Jdlrobson: Repair beta labs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154124 (https://bugzilla.wikimedia.org/68531) (owner: 10EBernhardson) [21:24:41] he just didn't break anything so I had to help him with that [21:24:55] good intentions, me like [21:25:14] vagrant should automatically checkout the Vector skin and add the require_once line [21:25:23] not sure it does [21:25:27] yurikR: git pull mediawiki/core, then upgrade vagrant (however it is you upgrade vagrant, i don.t use it) [21:25:29] oh, maybe i had to patch something [21:25:38] https://github.com/wikimedia/mediawiki-vagrant/commit/8fe0f6d2099eb8b5327febc2d0e89299ebd8eefd#diff-d41d8cd98f00b204e9800998ecf8427e [21:25:43] i'm running on a slightly older vagrant due to a nasty bug [21:26:02] thx legoktm [21:26:03] (03CR) 10EBernhardson: "seems reasonable, one question about what its doing" (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152808 (owner: 10Bsitu) [21:26:18] there's a later patch to add the other 3 former core skins [21:26:30] but they're roles https://github.com/wikimedia/mediawiki-vagrant/commit/d9470cda77f2ec92a7217ffd7dad6a6eed0f41c6#diff-d41d8cd98f00b204e9800998ecf8427e [21:26:44] one patch is good ) [21:27:22] (03Merged) 10jenkins-bot: Normalize key before creating a Skin object [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154139 (https://bugzilla.wikimedia.org/69566) (owner: 10Legoktm) [21:28:31] ah yes, this is helpful... [21:28:43] (03Abandoned) 10Microchip08: Do not add ?uselang= on the default language [extensions/StickToThatLanguage] - 10https://gerrit.wikimedia.org/r/136624 (owner: 10Microchip08) [21:29:44] (03PS1) 10EBernhardson: Move selection of nfs or native share to settings [vagrant] - 10https://gerrit.wikimedia.org/r/154153 [21:30:02] (03PS1) 10Jdlrobson: Hygiene: Kill dead code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154154 [21:31:12] (03CR) 10Physikerwelt: "Hashar, ok I implemented a test... let's see if it works" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/154083 (https://bugzilla.wikimedia.org/66516) (owner: 10Physikerwelt) [21:31:14] 3MediaWiki / 3API: Provide all URL/path in meta=siteinfo&siprop=interwikimap - 10https://bugzilla.wikimedia.org/69575 (10Dr Brains) 3NEW p:3Unprio s:3normal a:3None For now, the module meta=siteinfo&siprop=interwikimap give this : (03PS1) 10Legoktm: API: Fix help url and remove deprecated getVersion() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154155 [21:36:13] (03PS28) 10EBernhardson: New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [21:38:46] (03PS4) 10Physikerwelt: Protect MathML from Tidy [core] - 10https://gerrit.wikimedia.org/r/154083 (https://bugzilla.wikimedia.org/66516) [21:39:09] (03PS8) 10Bsitu: Auto mark notification as read if it doesn't have target page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152203 [21:40:43] 3MediaWiki extensions / 3Popups: "Monitor or Edit" option apparently disables HoverCards entirely. - 10https://bugzilla.wikimedia.org/69576 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None When I choose "Monitor or Edit" in the settings, it seems to disable it completely. It still shows the "En... [21:41:25] bd808|BUFFER: what exactly does this line in vagrant apache conf do? [21:41:26] ProxyPass /w/extensions ! [21:41:49] I can't get the qunit tests working in vagrant, http://127.0.0.1:8080/w/tests/qunit/data/testrunner.js gives a 404 [21:42:24] (03CR) 10EBernhardson: "Theres one problem with this though, and its probably me just not understanding something, but `vagrant config --list` doesn't show the ne" [vagrant] - 10https://gerrit.wikimedia.org/r/154153 (owner: 10EBernhardson) [21:42:54] (03CR) 10jenkins-bot: [V: 04-1] Protect MathML from Tidy [core] - 10https://gerrit.wikimedia.org/r/154083 (https://bugzilla.wikimedia.org/66516) (owner: 10Physikerwelt) [21:44:13] 3MediaWiki extensions / 3Popups: When changing settings, does not default to my current setting - 10https://bugzilla.wikimedia.org/69577 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None When I go to "Enable Hovercards" to change my settings, it always defaults to "Read Quickly", even when I expl... [21:44:29] 3MediaWiki extensions / 3Popups: "Monitor or Edit" option apparently disables HoverCards entirely - 10https://bugzilla.wikimedia.org/69576#c1 (10Matthew Flaschen) Tested in Firefox/Iceweasel 30.0 [21:44:29] 3MediaWiki extensions / 3Popups: When changing settings, does not default to my current setting - 10https://bugzilla.wikimedia.org/69577 (10Matthew Flaschen) [21:44:43] (03PS2) 10EBernhardson: Move selection of nfs or native share to settings [vagrant] - 10https://gerrit.wikimedia.org/r/154153 [21:45:28] (03CR) 10EBernhardson: [C: 032] "kill it with fire!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154154 (owner: 10Jdlrobson) [21:45:52] (03Merged) 10jenkins-bot: Hygiene: Kill dead code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154154 (owner: 10Jdlrobson) [21:47:21] (03PS1) 10Yurik: Add 'graph' role to enable graph extension [vagrant] - 10https://gerrit.wikimedia.org/r/154200 [21:47:23] (03CR) 10EBernhardson: [C: 032] New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [21:47:34] (03PS5) 10Physikerwelt: Protect MathML from Tidy [core] - 10https://gerrit.wikimedia.org/r/154083 (https://bugzilla.wikimedia.org/66516) [21:47:55] (03PS5) 10Jdlrobson: Repair beta labs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154124 (https://bugzilla.wikimedia.org/68531) (owner: 10EBernhardson) [21:47:58] (03Merged) 10jenkins-bot: New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [21:48:01] (03CR) 10Alex Monk: [C: 032] API: Fix help url and remove deprecated getVersion() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154155 (owner: 10Legoktm) [21:48:11] (03PS7) 10EBernhardson: Subscribe to board = auto-subscribe to new topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153411 (owner: 10Matthias Mullie) [21:48:29] (03CR) 10Jdlrobson: [C: 04-1] "tests please...? :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154124 (https://bugzilla.wikimedia.org/68531) (owner: 10EBernhardson) [21:48:43] (03CR) 10Yurik: [C: 032] Add 'graph' role to enable graph extension [vagrant] - 10https://gerrit.wikimedia.org/r/154200 (owner: 10Yurik) [21:49:01] (03Merged) 10jenkins-bot: API: Fix help url and remove deprecated getVersion() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154155 (owner: 10Legoktm) [21:49:17] (03Merged) 10jenkins-bot: Add 'graph' role to enable graph extension [vagrant] - 10https://gerrit.wikimedia.org/r/154200 (owner: 10Yurik) [21:50:13] 3MediaWiki extensions / 3Popups: When changing settings, does not default to my current setting - 10https://bugzilla.wikimedia.org/69577#c1 (10Matthew Flaschen) This is tested on English Wikipedia on 1.24wmf16. [21:50:13] 3MediaWiki extensions / 3Popups: "Monitor or Edit" option apparently disables HoverCards entirely - 10https://bugzilla.wikimedia.org/69576#c2 (10Matthew Flaschen) This is tested on English Wikipedia on 1.24wmf16. [21:50:18] (03CR) 10Bsitu: Create TargetPage data if specified by EchoEvent (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152808 (owner: 10Bsitu) [21:54:46] (03CR) 10Physikerwelt: Protect MathML from Tidy (031 comment) [core] - 10https://gerrit.wikimedia.org/r/154083 (https://bugzilla.wikimedia.org/66516) (owner: 10Physikerwelt) [21:55:26] 3MediaWiki / 3Skin and page rendering: Sporadic reports of users being served MW with no skins on 1.24wmf17 - 10https://bugzilla.wikimedia.org/69566 (10Sam Reed (reedy)) [21:55:38] (03CR) 10Fomafix: [C: 04-1] WIP: Stop using DOM as an api. Start a Skin api for the watchstar (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153855 (owner: 10Jdlrobson) [21:56:15] (03CR) 10Hashar: [C: 031] "+MaxSem who wrote the first tests and must know about tidy/parser :-]" [core] - 10https://gerrit.wikimedia.org/r/154083 (https://bugzilla.wikimedia.org/66516) (owner: 10Physikerwelt) [21:56:23] (03PS1) 10Jdlrobson: Stop using id for footer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154202 [21:56:26] (03PS1) 10Jdlrobson: Hygiene: Mega clean up the Echo footer code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154203 [21:57:28] 3MediaWiki extensions / 3Popups: settings.open() called with incorrect parameters, causing exception - 10https://bugzilla.wikimedia.org/69579 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None The settings.open method expects an event (to call preventDefault), but https://git.wikimedia.org/blob/me... [22:00:21] (03CR) 10Fomafix: API: Log usage of various deprecated features (031 comment) [core] - 10https://gerrit.wikimedia.org/r/154101 (owner: 10Anomie) [22:02:28] (03PS10) 10EBernhardson: Create TargetPage data if specified by EchoEvent [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152808 (owner: 10Bsitu) [22:02:54] (03CR) 10jenkins-bot: [V: 04-1] Create TargetPage data if specified by EchoEvent [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152808 (owner: 10Bsitu) [22:04:49] (03CR) 10Aude: [C: 032] Update Wikidata (test.wikidata) to mw1.24-wmf17 branch [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154119 (owner: 10Aude) [22:05:03] (03PS33) 10Physikerwelt: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [22:05:54] (03CR) 10Bsitu: "I will some test per Jon's request" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152808 (owner: 10Bsitu) [22:06:17] (03CR) 10EBernhardson: Subscribe to board = auto-subscribe to new topics (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153411 (owner: 10Matthias Mullie) [22:09:07] (03Merged) 10jenkins-bot: Update Wikidata (test.wikidata) to mw1.24-wmf17 branch [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154119 (owner: 10Aude) [22:09:16] (03CR) 10Cmcmahon: [C: 031] "I'm happy merging this. If we need to update gems later to make the Math test builds run or for some other reason we can un-ignore these " [extensions/Math] - 10https://gerrit.wikimedia.org/r/154060 (owner: 10Physikerwelt) [22:09:23] (03CR) 10Physikerwelt: [C: 031 V: 031] "Ok, works for me. For some reason I don't remember I updated the coverageTest" [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [22:10:52] (03PS1) 10Jdlrobson: Fix size of 'mark all as read' button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154206 [22:11:50] (03CR) 10Mattflaschen: "I should also add that we have used this technique before (to a little controversy), and successfully unified it and removed the globals (" [core] - 10https://gerrit.wikimedia.org/r/150635 (owner: 10Jdlrobson) [22:14:23] tgr: That line goes with the one after it. /w/extensions is excluded from the proxy pass to hhvm. [22:14:28] (03CR) 10JGonera: Don't limit the height of CPB (031 comment) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/153437 (https://bugzilla.wikimedia.org/65285) (owner: 10JGonera) [22:15:10] bd808|MOBILE: yeah, I figured that much, I was just wondering if that's missing somehow for assets [22:15:32] bd808|MOBILE: anyway, adding a similar rule for tests did not help [22:19:12] 3Wikimedia / 3SSL related: https://lists.wikimedia.org/pipermail/somelist/ redirects to http://lists.wikimedia.org/pipermail/somelist/ - 10https://bugzilla.wikimedia.org/68553#c2 (10Thehelpfulone) *** Bug 69560 has been marked as a duplicate of this bug. *** [22:19:13] 3Wikimedia / 3Mailing lists: list archives redirect to http-only - 10https://bugzilla.wikimedia.org/69560#c1 (10Thehelpfulone) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 68553 *** [22:19:25] tgr: I'm not looking at the file at the moment, but it may be grabbing too many urls. Our mix of static assets and dynamic content is a bit tangled. [22:20:35] tgr: I think Ori came up with that proxy rule originally. Or at least he started the hhvm bits for MeV [22:20:51] *mwv [22:21:09] (Sorry for the random ping) [22:21:31] bd808|MOBILE: if I open http://127.0.0.1:8080/w/tests/qunit/data/testrunner.js manually, I get a not found, so I don't think its related to dynamic loading [22:21:44] (03CR) 10Aaron Schulz: [C: 032] Enabled $wgUseLinkNamespaceDBFields [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/154100 (owner: 10Aaron Schulz) [22:22:09] bd808|MOBILE: anyway, nothing urgent about this, I don't want to bother you with it while you are on the road :) [22:23:44] tgr: Heh. Phone from a hotel room. [22:24:02] (03PS1) 10Legoktm: Revert Echo to 1.24wmf16 branch [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154207 [22:24:14] (03PS3) 10Florianschmidtwelzow: Check if wgAuth is set correctly [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/151444 (https://bugzilla.wikimedia.org/68962) [22:24:38] (03Merged) 10jenkins-bot: Enabled $wgUseLinkNamespaceDBFields [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/154100 (owner: 10Aaron Schulz) [22:25:41] (03CR) 10Bsitu: [C: 031] Revert Echo to 1.24wmf16 branch [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154207 (owner: 10Legoktm) [22:26:06] does anyone know how to run unit tests from vagrant now? [22:26:26] 3MediaWiki / 3Skin and page rendering: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c8 (10Dan Andreescu) Hi Bartosz, I ran: select uri_path, count(*) from webrequest where webrequest_source='bits' and year=... [22:27:50] (03CR) 10Greg Grossmeier: [C: 031] Revert Echo to 1.24wmf16 branch [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154207 (owner: 10Legoktm) [22:28:11] 3MediaWiki / 3Skin and page rendering: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c9 (10Dan Andreescu) Created attachment 16199 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16199&action=edit hits to */skins/common... [22:34:45] * ebernhardson cant be the only person that runs unit tests ... [22:35:00] (03CR) 10Bsitu: [C: 032] Fix size of 'mark all as read' button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154206 (owner: 10Jdlrobson) [22:35:19] ebernhardson: There's this person called Jenkins, would you like me to set you two up? ;) [22:36:21] RoanKattouw: theres this thing called writing tests, perhaps you run them before you send them to jenkins :P [22:36:38] (03PS1) 10Aaron Schulz: Fixed doc comment [core] - 10https://gerrit.wikimedia.org/r/154211 [22:37:02] (03Merged) 10jenkins-bot: Fix size of 'mark all as read' button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154206 (owner: 10Jdlrobson) [22:37:31] ebernhardson: Sometimes. Other times I'm lazy and I let Jenkins do that for me [22:37:35] He is a butler, after all [22:37:46] ebernhardson: oh, I just reverted vagrant to pre-multiwiki [22:38:02] legoktm: hmm, i suppose that would work [22:38:18] aparently mediawiki-vagrant needs unit tests that run the unit tests :P [22:39:21] (03CR) 10Chad: "I disagree that the second parser test runner should trump other broken tests, but I like Aaron don't want to play with this crud anymore." [core] - 10https://gerrit.wikimedia.org/r/151522 (https://bugzilla.wikimedia.org/69082) (owner: 10Cscott) [22:44:44] 3Wikimedia / 3General/Unknown: mwgrep: Add option to hide private wikis - 10https://bugzilla.wikimedia.org/69581 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None I didn't notice that in a list of 100+ results I gave to someone had private wikis in it. It's not a big deal since it just said... [22:45:06] (03CR) 10Mattflaschen: "As I said, I see both sides of this, but at this point I prefer the mixin approach." [core] - 10https://gerrit.wikimedia.org/r/151792 (owner: 10Jdlrobson) [22:47:56] 3MediaWiki / 3Skin and page rendering: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277#c10 (10Bartosz Dziewoński) Created attachment 16200 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16200&action=edit mwgrep skins/comm... [22:48:05] (03PS1) 10Aude: Update Wikidata [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154212 [22:49:32] (03PS2) 10Jdlrobson: Stop using id for footer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/154202 [22:52:36] (03CR) 10Aude: [C: 032] Update Wikidata [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154212 (owner: 10Aude) [22:53:27] 3Wikimedia / 3Extension setup: Enable Guided Tour extension on Te wiki (te.wikipedia.org) - 10https://bugzilla.wikimedia.org/69103 (10Matthew Flaschen) 5PATC>3RESO/FIX a:3Sam Smith [22:54:54] (03CR) 10Aaron Schulz: [C: 032] Fixed doc comment [core] - 10https://gerrit.wikimedia.org/r/154211 (owner: 10Aaron Schulz) [22:55:37] (03Merged) 10jenkins-bot: Update Wikidata [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154212 (owner: 10Aude) [22:57:26] 3Wikimedia / 3General/Unknown: mwgrep: Add option to hide private wikis - 10https://bugzilla.wikimedia.org/69581 (10Kunal Mehta (Legoktm)) p:5Unprio>3Low [22:58:44] (03Merged) 10jenkins-bot: Fixed doc comment [core] - 10https://gerrit.wikimedia.org/r/154211 (owner: 10Aaron Schulz) [23:06:14] (03CR) 10CSteipp: "Slightly ugly error messages:" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) (owner: 10Legoktm) [23:10:26] 3Wikimedia / 3Site requests: Category collation for Estonian projects - 10https://bugzilla.wikimedia.org/54168#c14 (10Bartosz Dziewoński) I have uploaded the configuration patch, but collation config changes seem to be on hold for a while now and I don't know why. No idea how long this is going to take :/ [23:11:02] (03PS3) 10Jdlrobson: Hygiene: Alter how initialisation of the overlay works [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153613 [23:11:30] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Alter how initialisation of the overlay works [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153613 (owner: 10Jdlrobson) [23:15:54] (03PS1) 10Gerrit Patch Uploader: Remove duplicate code [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/154215 [23:15:56] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/154215 (owner: 10Gerrit Patch Uploader) [23:19:17] (03PS4) 10Jdlrobson: Hygiene: Alter how initialisation of the overlay works [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153613 [23:19:42] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Alter how initialisation of the overlay works [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153613 (owner: 10Jdlrobson) [23:20:02] (03CR) 10Addshore: [C: 031] "Clicking submit isnt that big a deal." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/154058 (owner: 10Jeroen De Dauw) [23:22:11] 3Wikimedia / 3SSL related: https://lists.wikimedia.org/pipermail/somelist/ redirects to http://lists.wikimedia.org/pipermail/somelist/ - 10https://bugzilla.wikimedia.org/68553#c3 (10Thehelpfulone) 5PATC>3RESO/FIX Fixed, now merged by Brandon [23:24:45] (03PS11) 10Bsitu: Create TargetPage data if specified by EchoEvent [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152808 [23:25:35] (03PS12) 10Bsitu: Create TargetPage data if specified by EchoEvent [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152808 [23:26:50] (03CR) 10Jdlrobson: [C: 032] Repair beta labs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154124 (https://bugzilla.wikimedia.org/68531) (owner: 10EBernhardson) [23:27:27] (03Merged) 10jenkins-bot: Repair beta labs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/154124 (https://bugzilla.wikimedia.org/68531) (owner: 10EBernhardson) [23:34:48] (03CR) 10Ori.livneh: [C: 032] Fix horribly broken way TMH was generating urls [extensions/TimedMediaHandler] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154151 (https://bugzilla.wikimedia.org/69453) (owner: 10Legoktm) [23:34:55] (03CR) 10Ori.livneh: [C: 032] Fix horribly broken way TMH was generating urls [extensions/TimedMediaHandler] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/154150 (https://bugzilla.wikimedia.org/69453) (owner: 10Legoktm) [23:35:03] (03Merged) 10jenkins-bot: Fix horribly broken way TMH was generating urls [extensions/TimedMediaHandler] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154151 (https://bugzilla.wikimedia.org/69453) (owner: 10Legoktm) [23:35:07] (03CR) 10Ori.livneh: [C: 032] Revert Echo to 1.24wmf16 branch [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154207 (owner: 10Legoktm) [23:35:12] (03Merged) 10jenkins-bot: Fix horribly broken way TMH was generating urls [extensions/TimedMediaHandler] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/154150 (https://bugzilla.wikimedia.org/69453) (owner: 10Legoktm) [23:35:34] marxarelli, are you there? [23:35:49] jgonera: yup yup [23:36:29] 3MediaWiki extensions / 3WikidataRepo: Unknown column 'epp_redirect_target' in 'field list - 10https://bugzilla.wikimedia.org/69585 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs we have $wgWBRepoSettings['useRedirectTargetColumn'] = false; but I can't view https://test.wikidata.org/wiki/Q22 and... [23:36:59] (03CR) 10Jdlrobson: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153613 (owner: 10Jdlrobson) [23:37:29] (03PS3) 10Bsitu: Add 'target-page' param to flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/152935 [23:37:37] (03CR) 10jenkins-bot: [V: 04-1] Add 'target-page' param to flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/152935 (owner: 10Bsitu) [23:39:06] (03PS4) 10Legoktm: API: Add method for logging feature usage [core] - 10https://gerrit.wikimedia.org/r/154095 (owner: 10Anomie) [23:39:24] (03CR) 10Legoktm: [C: 032] API: Add method for logging feature usage [core] - 10https://gerrit.wikimedia.org/r/154095 (owner: 10Anomie) [23:39:26] marxarelli, did you investigate what the fix for the chrome driver could be? if not, I can have a look now if you don't have time today [23:39:28] (03Merged) 10jenkins-bot: Revert Echo to 1.24wmf16 branch [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154207 (owner: 10Legoktm) [23:39:51] jgonera: see https://gerrit.wikimedia.org/r/#/c/154217/ [23:40:38] jgonera: i'm not sure why, but i haven't been seeing my git-review submissions in irc today [23:41:12] marxarelli, the ones to mobilefrontend go to #wikimedia-mobile [23:41:45] jgonera: holy hell we have a lot of irc channels :) [23:41:47] marxarelli, any idea why that domain argument was not needed before? [23:41:53] marxarelli, yeah ;) [23:42:15] (03PS5) 10Jdlrobson: Hygiene: Alter how initialisation of the overlay works [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153613 [23:42:50] jgonera: it may just be a bug in the version of chrome that sauce is using [23:43:03] this is all i could find on it in the wild https://groups.google.com/forum/#!msg/selenium-users/OcUPavQj8Y4/fJ-Mv9cJqbAJ [23:43:03] marxarelli, you can't reproduce locally? [23:43:10] jgonera: no, i can't [23:43:22] hm, I am getting a different error locally [23:43:29] both with and without your patch [23:43:36] BROWSER=chrome cucumber features/editor_wikitext_nosave.feature gives [23:43:43] : Failed to set the 'cookie' property on 'Document': Cookies are disabled inside 'data:' URLs. [23:43:43] (Session info: chrome=36.0.1985.125) [23:43:43] (Driver info: chromedriver=2.9.248304,platform=Linux 3.13.0-33-generic x86_64) (Selenium::WebDriver::Error::NoScriptResultError) [23:43:58] marxarelli, ^ [23:44:09] (03CR) 10Legoktm: [C: 04-1] "Should have release notes saying that these are now deprecated, and will be removed in MW 1.25 (I assume)" [core] - 10https://gerrit.wikimedia.org/r/154098 (owner: 10Anomie) [23:45:22] jgonera: still can't repro it [23:45:24] (03CR) 10Legoktm: "(Looks fine otherwise)" [core] - 10https://gerrit.wikimedia.org/r/154098 (owner: 10Anomie) [23:45:35] (03Merged) 10jenkins-bot: API: Add method for logging feature usage [core] - 10https://gerrit.wikimedia.org/r/154095 (owner: 10Anomie) [23:45:36] marxarelli, are you in the office? [23:45:37] jgonera: just to be sure, try `bundle exec cucumber` [23:45:40] ok [23:45:42] at home today [23:45:54] same thing [23:45:59] will you be in tomorrow? [23:46:04] yeah [23:46:14] ok, let's figure it out tomorrow then [23:46:19] sounds good [23:48:45] (03CR) 10Legoktm: [C: 031] "looks good except for the typo." [core] - 10https://gerrit.wikimedia.org/r/154101 (owner: 10Anomie) [23:50:26] (03PS2) 10Legoktm: API: Log usage of various deprecated features [core] - 10https://gerrit.wikimedia.org/r/154101 (owner: 10Anomie) [23:50:55] (03PS1) 10Ori.livneh: Update TMH for cherry-pick [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/154218 [23:51:12] 3Wikimedia / 3Mailing lists: Wrong cert on mail.wikipedia.org (as it redirects to lists.wikimedia.org) - 10https://bugzilla.wikimedia.org/44731 (10jeremyb) a:3jeremyb [23:51:45] (03PS3) 10Legoktm: API: Log usage of various deprecated features [core] - 10https://gerrit.wikimedia.org/r/154101 (owner: 10Anomie) [23:53:05] (03CR) 10Legoktm: [C: 032] "PS3: fixed the typo" [core] - 10https://gerrit.wikimedia.org/r/154101 (owner: 10Anomie) [23:53:58] 3Wikimedia / 3Wikidata: https://test.wikidata.org/wiki/Special:Version is unavailable - 10https://bugzilla.wikimedia.org/69586 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs I get a blank page when requesting https://test.wikidata.org/wiki/Special:Version and can't find anything in the logs about... [23:56:43] (03PS4) 10Bsitu: Add 'target-page' param to flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/152935 [23:56:46] (03PS1) 10Ori.livneh: Update TMH for cherry-pick [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154219 [23:58:08] (03CR) 10Bsitu: "@mlitn, yeah, it doesn't hurt to merge this before the Echo patch, it's just some additional data" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/152935 (owner: 10Bsitu) [23:58:37] (03PS5) 10Bsitu: Add 'target-page' param to flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/152935 [23:59:28] (03Merged) 10jenkins-bot: API: Log usage of various deprecated features [core] - 10https://gerrit.wikimedia.org/r/154101 (owner: 10Anomie) [23:59:37] (03PS2) 10Ori.livneh: Update TMH for cherry-pick [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154219 [23:59:42] (03CR) 10Ori.livneh: [C: 032] Update TMH for cherry-pick [core] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154219 (owner: 10Ori.livneh)