[00:00:05] (03CR) 10SG: [C: 032] Truncate text in Echo notifications [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153731 (owner: 10Jdlrobson) [00:00:08] (03PS2) 10Legoktm: Use Config instead of globals [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/153231 [00:00:29] (03Merged) 10jenkins-bot: Truncate text in Echo notifications [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153731 (owner: 10Jdlrobson) [00:00:32] (03PS2) 10Legoktm: Use Config instead of globals [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/153232 [00:04:15] (03Abandoned) 10Legoktm: Turn LogFormatter into a ContextSource [core] - 10https://gerrit.wikimedia.org/r/146017 (owner: 10Legoktm) [00:05:58] (03PS18) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [00:06:18] (03PS13) 10Paladox: WikiEditor: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 [00:06:36] (03PS12) 10Paladox: Update Moment.js from 2.7.0 to 2.8.1 [core] - 10https://gerrit.wikimedia.org/r/151630 [00:07:23] (03PS4) 10Paladox: Ace: Update to 08-07-2014 [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/144780 (https://bugzilla.wikimedia.org/60432) (owner: 10TheDJ) [00:08:03] (03CR) 10Paladox: [C: 031] Ace: Update to 08-07-2014 [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/144780 (https://bugzilla.wikimedia.org/60432) (owner: 10TheDJ) [00:09:23] 3MediaWiki / 3General/Unknown: Investigate whether taking an action on a page (delete, import, etc.) should require being able to edit it - 10https://bugzilla.wikimedia.org/69380#c23 (10Stefan2) (In reply to rschen7754.wiki from comment #2) > This had the effect of making it impossible for global sysops to d... [00:11:15] (03PS6) 10Bsitu: Hygiene: Add abstract model and mapper for notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151999 [00:13:10] legoktm: You wanted to look at recent CentralAuth autocreations yesterday or so :P [00:13:23] * hoo is to lazy to do it himself [00:15:25] oh yes and then I fell asleep >.> [00:15:38] oO [00:15:45] log are boring, I guess [00:16:26] as of last night there are 581 broken accounts, on Aug 1 there were 367 [00:16:54] :S [00:20:09] eh what [00:20:19] there are some on my list from august 1 that aren't on yesterdays list [00:23:59] hoo: you didn't run a script to fix broken accounts right...? [00:24:21] No, never did that [00:24:41] so then how did these accounts get fixed??? [00:24:49] oO [00:24:53] csteipp: ^ [00:25:19] legoktm@terbium:~/sul$ diff broken-no-ec5.tsv broken-no-ec6.tsv [00:25:36] all the new broken accounts are on commons [00:25:50] was-broken-now-fixed were everywhere [00:25:55] bbl for like 20 [00:25:56] Wasn't me :) [00:26:09] how's the script named that does this? [00:31:27] (03PS1) 10Bsitu: Add method for fetching unread notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153734 [00:35:00] (03CR) 10Krinkle: "Thx for the typo fixes, that was embarrassing." [core] - 10https://gerrit.wikimedia.org/r/152122 (owner: 10Krinkle) [00:36:31] (03PS1) 10Jdlrobson: E2e: Show the correct value of unread messages in the tabs. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153735 [00:38:57] (03PS4) 10Bsitu: Use array_merge_resursive when merging based on array keys [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153725 [00:39:16] (03PS1) 10Jdlrobson: E2e: Show the correct value of unread messages in the tabs. [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153736 [00:39:29] (03Abandoned) 10Jdlrobson: E2e: Show the correct value of unread messages in the tabs. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153735 (owner: 10Jdlrobson) [00:40:40] (03PS2) 10Jdlrobson: QA: Disable known-failing test on CI targets [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153719 (owner: 10Spage) [00:41:00] (03CR) 10Jdlrobson: [C: 032] QA: Disable known-failing test on CI targets [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153719 (owner: 10Spage) [00:41:32] (03Merged) 10jenkins-bot: QA: Disable known-failing test on CI targets [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153719 (owner: 10Spage) [00:42:07] (03PS5) 10Jdlrobson: Use array_merge_resursive when merging based on array keys [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153725 (owner: 10Bsitu) [00:42:12] (03CR) 10Jdlrobson: [C: 032] Use array_merge_resursive when merging based on array keys [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153725 (owner: 10Bsitu) [00:42:36] (03Merged) 10jenkins-bot: Use array_merge_resursive when merging based on array keys [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153725 (owner: 10Bsitu) [00:42:46] spagewmf: https://gerrit.wikimedia.org/r/153423 [00:43:44] hoo: it's /home/legoktm/sul/broken-accounts.py [00:44:04] it does a join against centralauth + localwiki, checks for absence of localuser row and empty user_email and user_password [00:44:28] legoktm: I wont run a random python script from your home, be sure about that [00:44:32] (unless you tell me to) [00:44:51] (03PS3) 10Krinkle: mediawiki.notify: Simplify callback by using .then() [core] - 10https://gerrit.wikimedia.org/r/152839 (owner: 10Gerrit Patch Uploader) [00:45:27] (03CR) 10Bsitu: [C: 032] E2e: Show the correct value of unread messages in the tabs. [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153736 (owner: 10Jdlrobson) [00:45:44] (03PS4) 10Krinkle: mediawiki.notify: Simplify callback by using .then() [core] - 10https://gerrit.wikimedia.org/r/152839 (owner: 10Gerrit Patch Uploader) [00:45:55] (03Merged) 10jenkins-bot: E2e: Show the correct value of unread messages in the tabs. [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153736 (owner: 10Jdlrobson) [00:46:00] (03CR) 10Spage: [C: 032] "--config .jshintrc _after_ arguments is undocumented behavior, but OK." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153423 (owner: 10Jdlrobson) [00:46:35] (03Merged) 10jenkins-bot: `make jshint` command should run on tests directory [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153423 (owner: 10Jdlrobson) [00:47:04] (03CR) 10Catrope: [C: 032] resourceloader: Wrap only=script responses in "if(window.mw)" [core] - 10https://gerrit.wikimedia.org/r/152122 (owner: 10Krinkle) [00:48:08] (03PS10) 10Jdlrobson: Add TargetPage model and mapper to notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151992 (owner: 10Bsitu) [00:49:37] (03CR) 10Jdlrobson: [C: 031] "You wrote tests so I am happy." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151992 (owner: 10Bsitu) [00:49:49] (03PS4) 10Jdlrobson: Mark notification as read upon visiting a page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152198 (owner: 10Bsitu) [00:50:13] (03Merged) 10jenkins-bot: resourceloader: Wrap only=script responses in "if(window.mw)" [core] - 10https://gerrit.wikimedia.org/r/152122 (owner: 10Krinkle) [00:50:22] (03CR) 10Jdlrobson: [C: 04-1] "icanhaztests?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152198 (owner: 10Bsitu) [00:50:29] (03PS7) 10Jdlrobson: Auto mark notification as read if it doesn't have target page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152203 (owner: 10Bsitu) [00:51:36] (03PS9) 10Jdlrobson: Create TargetPage data if specified by EchoEvent [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152808 (owner: 10Bsitu) [00:51:45] (03PS6) 10Jdlrobson: Delete invalid records from echo_target_page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153372 (owner: 10Bsitu) [00:52:16] hoo: :OOOOOOOOOOOOOOOOO I think I know. [00:52:43] The amount of O in your message is worrying [00:53:22] out of the 3 broken users I've looked at so far [00:53:28] all of them had requests like [00:53:36] x-srt stuffs [00:53:37] centralauth-bug39996.log-20140811.gz:2014-08-10 18:27:31 mw1102 commonswiki: CentralAuthHooks::attemptAddUser: creating new user (USERNAME) - from: /wiki/:South+Africa+National+Anthem.ogg.af.srt?action=raw&ctype=text/x-srt [00:53:38] ? [00:53:40] yes [00:53:42] yeah [00:53:49] saw that [00:53:54] that probably means something. [00:54:14] Not sure, I guess that's just something which is getting hit a lot from MediaViewer(?) [00:55:13] marktraceur: does mediaviewer make requests to something like /wiki/:South+Africa+National+Anthem.ogg.af.srt?action=raw&ctype=text/x-srt ? [00:55:36] or, what would make those requests [00:56:02] mh... grep the code base? [00:56:54] mothing [00:56:56] nothing* [00:57:04] * legoktm checks TMH [00:57:18] TimedMediaHandler/handlers/TextHandler/TextHandler.php [00:57:26] 280: return $basePageUrl . $sep . 'action=raw&ctype=text/x-srt'; [00:57:40] 3MediaWiki-Vagrant: latest mw-vagrant and labs-vagrant time out after a load.php request - 10https://bugzilla.wikimedia.org/69452 (10spage) 3NEW p:3Unprio s:3major a:3Ori Livneh Shahyar Ghobadpour in his local MediaWiki-vagrant, and me in the http://flow-tests.wmflabs.org instance are both experiencing... [00:58:07] (03PS1) 10Jdlrobson: WIP: Needs API change - only mark messages as read [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153738 [00:58:32] so, why would that call result in a broken account. [00:59:24] shahyar: ^ bug mentions you. As I say in the bug, when I did restart hhvm and redis and stopped and started apache, flow-tests has been somewhat stable [01:00:29] legoktm: ActionRaw directly accesses session_id [01:00:31] () [01:00:34] (the function) [01:01:39] ok, that wont be hit in public wikis [01:01:43] but we should never hit that? [01:01:45] right [01:02:34] thanks spagewmf [01:03:32] didn't work for me though [01:05:45] legoktm: Can you grep for users of the RawPageViewBeforeOutput hook? [01:06:09] started [01:06:52] https://www.mediawiki.org/wiki/Category:RawPageViewBeforeOutput_extensions shows no extensions on WMF wikis [01:07:57] which means nothing [01:08:08] (or is that kept up to date automatically) [01:08:14] it's not :/ [01:14:00] relatedly, does setting ctype = text/x-srt even work? [01:14:01] $allowedCTypes = array( 'text/x-wiki', 'text/javascript', 'text/css', 'application/x-zope-edit' ); [01:14:01] if ( $ctype == '' || !in_array( $ctype, $allowedCTypes ) ) { [01:14:01] $ctype = 'text/x-wiki'; [01:14:01] } [01:14:06] (03PS1) 10Spage: Merge branch 'origin/master' into two_tabs [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153739 [01:14:46] legoktm: Probably not [01:14:56] will be text/x-wiki then [01:15:03] not sure what the caller assume [01:15:05] s [01:15:08] or how browsers handle that [01:15:35] also, [01:15:42] it's using /wiki/ [01:15:54] oh that's fine [01:15:54] but [01:16:00] the namespace is missing [01:16:42] https://commons.wikimedia.org/wiki/:South+Africa+National+Anthem.ogg.af.srt?action=raw&ctype=text/x-srt [01:17:14] Forbidden [01:17:14] Invalid file extension found in the path info or query string. [01:17:19] I see [01:17:21] mh [01:18:39] hoo: nothing in gerrit besides CSS and XMLContentExtension [01:18:48] (using the hook) [01:18:58] ok, those sound unrelated [01:19:05] also not deployed [01:19:08] the error is coming from WebRequest::checkUrlExtension [01:19:10] * hoo => tired [01:19:25] which is some IE stuff. [01:19:33] Hi. I'm trying to figure out how to best cache mediawiki with the CDN fastly.com . While they use varnish I don't have a list of all edge nodes so I don't think I can use the normal way mediawiki does purging. Fastly offers a custom API for that so from what I can see I plan to patch SquidPurgeClient to use that. I'm wondering what interactions I should be aware there or if I missed some extension interfaces I could use instead. Thanks. [01:19:34] (03Abandoned) 10Spage: Merge branch 'origin/master' into two_tabs [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153739 (owner: 10Spage) [01:20:24] 3MediaWiki / 3General/Unknown: Investigate whether taking an action on a page (delete, import, etc.) should require being able to edit it - 10https://bugzilla.wikimedia.org/69380#c24 (10rschen7754.wiki) (In reply to Stefan2 from comment #23) > > Of course, there is no situation where English Wikipedia would... [01:21:36] checkUrlExtension directly accesses $_SERVER [01:22:00] that asks for problems [01:22:09] but not sure it's the actual cause [01:26:31] I'm gonna file a bug for the TMH stuff, and then try setting it up locally [01:26:52] +1 [01:28:02] (03CR) 10Addshore: [C: 032] Remove return from Action::checkCanExecute [core] - 10https://gerrit.wikimedia.org/r/151437 (owner: 10Umherirrender) [01:29:15] (03PS1) 10Catrope: Scope external link styling rules to #content rather than #bodyContent [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/153740 (https://bugzilla.wikimedia.org/38726) [01:29:21] (03CR) 10Addshore: "if an extension were using === to compare the result to true as documented and this change went in then the check would fail, hence the ne" [core] - 10https://gerrit.wikimedia.org/r/151437 (owner: 10Umherirrender) [01:30:36] (03CR) 10Addshore: [C: 04-1] "-1 per unintended change." (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/153399 (owner: 10Addshore) [01:31:09] (03Merged) 10jenkins-bot: Remove return from Action::checkCanExecute [core] - 10https://gerrit.wikimedia.org/r/151437 (owner: 10Umherirrender) [01:33:09] 3MediaWiki extensions / 3CentralAuth: Accounts magically unattached despite being recently created - 10https://bugzilla.wikimedia.org/39996 (10Kunal Mehta (Legoktm)) [01:33:21] [18:32:55] MediaWiki extensions / TimedMediaHandler: TimedMediaHandler making bad action=raw requests - https://bugzilla.wikimedia.org/69453 (Kunal Mehta (Legoktm)) NEW p:Unprio s:major a:None In the CentralAuth bug 39996 debug logs we're seeing requests coming through with $_SERVER['REQUEST_URI'] set... [01:34:01] legoktm: can you give me a few examples of recently broken user account + wiki? [01:34:11] to lazy to query, but want to check something [01:35:21] the ones I spot checked are Soedirmaan, JuggaloICP, Grkmada, Sagefats all at commonswiki [01:35:55] I typically just pick a random user from /home/legoktm/sul/broken-no-ec6.tsv and check it [01:37:38] 3MediaWiki extensions / 3CentralAuth: Accounts magically unattached despite being recently created - 10https://bugzilla.wikimedia.org/39996#c89 (10Kunal Mehta (Legoktm)) New debug logging is pointing to some weird TimedMediaHandler requests, which is filed as bug 69453. I also found some accounts that the s... [01:38:23] * legoktm afk, back in an hour or so [01:39:28] I'll probably be sleeping then [01:39:46] I'll try and poke some multimedia people if they're online [01:41:55] (03CR) 10Springle: [C: 031] Add TargetPage model and mapper to notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151992 (owner: 10Bsitu) [01:42:46] (03CR) 10Ori.livneh: [C: 032] Provision browser tests for CentralAuth [vagrant] - 10https://gerrit.wikimedia.org/r/147685 (owner: 10Dduvall) [01:42:54] (03Merged) 10jenkins-bot: Provision browser tests for CentralAuth [vagrant] - 10https://gerrit.wikimedia.org/r/147685 (owner: 10Dduvall) [01:55:17] (03PS1) 10Hoo man: Log if there are pending DB interactions in CentralAuthUser::attach [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153742 [02:02:52] (03PS25) 10Spage: New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [02:03:58] (03CR) 10Bsitu: "The api for this should be implemented in master so the target_page patches could make corresponding changes." [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153738 (owner: 10Jdlrobson) [02:12:09] (03PS1) 10Hoo man: Simplify Special:GlobalGroupMembership [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153743 [02:13:41] (03PS2) 10Hoo man: Simplify Special:GlobalGroupMembership [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153743 [02:15:20] bd808|BUFFER, ping [02:41:55] 3MediaWiki extensions / 3[other]: EmbedVideo extension delivers youtube videos using http instead of https causing modern browsers to block the content - 10https://bugzilla.wikimedia.org/69454 (10Roger Morton) 3UNCO p:3Unprio s:3normal a:3None If you use the EmbedVideo extension to embed a youtube vi... [02:50:24] (03CR) 10SG: Fixes cancel on reply form submitting to no-JS page, and also standardizes cancel button markup (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150998 (owner: 10SG) [02:51:35] (03PS5) 10SG: Fixes cancel on reply form, and also standardizes cancel button markup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150998 [02:53:23] 3MediaWiki extensions / 3[other]: EmbedVideo extension delivers youtube videos using http instead of https causing modern browsers to block the content - 10https://bugzilla.wikimedia.org/69454 (10Roger Morton) [02:54:08] 3MediaWiki extensions / 3[other]: EmbedVideo extension delivers youtube videos using http instead of https causing modern browsers to block the content - 10https://bugzilla.wikimedia.org/69454 (10Roger Morton) [03:18:51] (03PS1) 10Withoutaname: Collapse all functions except wfOutputHandler() in OutputHandler.php [core] - 10https://gerrit.wikimedia.org/r/153744 [03:23:08] 3MediaWiki extensions / 3[other]: EmbedVideo extension delivers youtube videos using http instead of https causing modern browsers to block the content - 10https://bugzilla.wikimedia.org/69454#c1 (10Roger Morton) A comment at https://www.mediawiki.org/wiki/Extension_talk:EmbedVideo#HTTPS_support_with_embedde... [03:28:08] 3MediaWiki extensions / 3Math: generate MathML (not PNG) and automatically embed hyperlinks for each symbol - 10https://bugzilla.wikimedia.org/69424#c8 (10Richard Baxter) Thanks for your help Physikerwelt, Although Math extension 11 August 2014 was giving a blank screen, version 13 August 2014 was giving a... [03:30:53] 3MediaWiki extensions / 3Math: generate MathML (not PNG) and automatically embed hyperlinks for each symbol - 10https://bugzilla.wikimedia.org/69424#c9 (10Richard Baxter) Created attachment 16181 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16181&action=edit mediaWikiMathExtensionMathMLinstallation... [03:32:24] 3MediaWiki extensions / 3Math: generate MathML (not PNG) and automatically embed hyperlinks for each symbol - 10https://bugzilla.wikimedia.org/69424#c10 (10Richard Baxter) Thanks also for your interest in this project (and the links). Note I had an additional idea for the postprocessor to help reduce the am... [03:54:38] 3MediaWiki extensions / 3Math: generate MathML (not PNG) and automatically embed hyperlinks for each symbol - 10https://bugzilla.wikimedia.org/69424#c11 (10physikerwelt) Hi Richard, Robert Pagel and me started with that already. (http://arxiv.org/abs/1407.0167) It's all open source. Physikerwelt [04:44:14] (03PS2) 10Umherirrender: Set relevant title on Special:RecentChangesLinked [core] - 10https://gerrit.wikimedia.org/r/151443 [04:53:23] (03PS4) 10Withoutaname: Remove deprecated $wgHTCPMulticastAddress, $wgHTCPMulticastRouting and $wgHTCPPort [core] - 10https://gerrit.wikimedia.org/r/150761 [04:54:01] ^ could I have that rechecked? [04:57:31] (03CR) 10Legoktm: [C: 032] Remove deprecated $wgHTCPMulticastAddress, $wgHTCPMulticastRouting and $wgHTCPPort [core] - 10https://gerrit.wikimedia.org/r/150761 (owner: 10Withoutaname) [04:57:52] thanks legoktm [04:58:04] :) [04:58:32] errrrr [04:58:36] https://github.com/search?q=user%3Awikimedia+$wgHTCPMulticastAddress&ref=cmdform&type=Code [04:58:41] wikimedia/operations-software – htcp.php [04:58:45] is it still being used? [04:59:39] the globals are commented out, so I don't know how they are assigned properly [04:59:40] oh, that's something separate? [04:59:50] yeah you're right [04:59:51] weird. [04:59:54] (03Merged) 10jenkins-bot: Remove deprecated $wgHTCPMulticastAddress, $wgHTCPMulticastRouting and $wgHTCPPort [core] - 10https://gerrit.wikimedia.org/r/150761 (owner: 10Withoutaname) [05:00:43] I think we should ask ops [05:00:48] or should i submit another patch [05:01:00] ops' call [05:01:59] well, I can't see how your patch would break anything and that looks totally unrelated to MW but just using the same variable names [05:02:09] legoktm: hi ! time to take another look at https://gerrit.wikimedia.org/r/#/c/153450/ ? :) [05:02:27] hey, sure [05:02:33] great :) [05:04:29] (03CR) 10Legoktm: [C: 031] "The code itself looks fine to me. Can we document what Chris said in his comment in the code itself so in the future it's clear to anyone " [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153450 (owner: 1001tonythomas) [05:06:34] legoktm: will do that :) [05:10:40] 3MediaWiki extensions / 3WikidataRepo: Use MediaViewer on commonsMedia properties on Wikibase repo - 10https://bugzilla.wikimedia.org/69456 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3enhanc a:3Wikidata bugs We currently have a default gadget that displays the image inline using jquery.ui ( (03PS3) 1001tonythomas: Improved the VERP generation by cutting down the hmac hash [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153450 [05:15:10] legoktm: this looks good ? https://gerrit.wikimedia.org/r/#/c/153450/3/includes/VerpAddressGenerator.php [05:16:21] yup [05:16:25] (03CR) 10Legoktm: [C: 032] Improved the VERP generation by cutting down the hmac hash [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153450 (owner: 1001tonythomas) [05:16:29] (03Merged) 10jenkins-bot: Improved the VERP generation by cutting down the hmac hash [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153450 (owner: 1001tonythomas) [05:16:37] legoktm: ^ yay :) thanks [05:17:20] (03CR) 10BearND: [C: 031] "Not sure if you want me to +2 commits but it looks good to me." [search/highlighter] - 10https://gerrit.wikimedia.org/r/150013 (owner: 10Manybubbles) [05:17:49] (03PS1) 10BearND: Documentation typos [search/highlighter] - 10https://gerrit.wikimedia.org/r/153746 [05:19:08] 3MediaWiki-Vagrant: Vagrant rebuild fails on Windows - Could not set 'link' on ensure: Protocol error - 10https://bugzilla.wikimedia.org/69425#c2 (10Yuri Astrakhan) Made a little script that automatically went back until it found the first working rev on master. The last working rev was c9427702b8fa6c4cdb. Th... [05:19:48] (03PS7) 10Withoutaname: Remove various functions and globals deprecated since 1.22 from RecentChange [core] - 10https://gerrit.wikimedia.org/r/150762 [05:23:38] 3MediaWiki-Vagrant: Vagrant rebuild fails on Windows - Could not set 'link' on ensure: Protocol error - 10https://bugzilla.wikimedia.org/69425#c3 (10Yuri Astrakhan) Correction - that was the merge commit - the patch is this: commit c9427702b8fa6c4cdb7c31b100286e98207821f3 Author: Rillke D... [05:35:56] (03PS1) 10BearND: Documentation typos [search/highlighter] - 10https://gerrit.wikimedia.org/r/153747 [05:39:11] (03PS1) 10Legoktm: includes/actions/: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/153748 [05:41:31] (03PS13) 10Foxtrott: Fix for Ia9baaf0b: magic functions for previously public class members [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) [05:46:35] What's an extension that only has an API module? [05:50:10] 3MediaWiki-Vagrant: Vagrant rebuild fails on Windows - Could not set 'link' on ensure: Protocol error - 10https://bugzilla.wikimedia.org/69425#c4 (10Yuri Astrakhan) a:5Ori Livneh>3Bryan Davis Never mind, bad GIT skills. This was caused by patch I26b3705726c52cd19f8a727cc2d6f3e956336b2d If I comment out t... [05:50:37] bd808|BUFFER, this one is yours :) https://bugzilla.wikimedia.org/show_bug.cgi?id=69425 [05:54:30] (03PS1) 10BearND: Replace some for loops with foreach [search/highlighter] - 10https://gerrit.wikimedia.org/r/153749 [05:55:31] (03CR) 10Yurik: "This patch caused bug 69425" (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/149872 (https://bugzilla.wikimedia.org/68605) (owner: 10BryanDavis) [06:01:18] (03PS1) 10BearND: Git-ignore IntelliJ files [search/highlighter] - 10https://gerrit.wikimedia.org/r/153752 [06:14:38] 3MediaWiki-Vagrant: Create sample pages for new MW - 10https://bugzilla.wikimedia.org/46869#c2 (10Yuri Astrakhan) A much more flexible solution: create new wiki pages based on files in the wikiPages\ directory. Use filename as the article title. The filename should be URL-decoded first, e.g. Talk%3ABlah would... [06:18:36] (03PS1) 10Yurik: Deleted all files except README. [extensions/Limn] - 10https://gerrit.wikimedia.org/r/153753 [06:20:06] (03PS1) 10Legoktm: Use Config instead of globals [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/153754 [06:22:26] yurikR: the name "Graph" is already taken....? https://www.mediawiki.org/wiki/Extension:Graph [06:23:32] legoktm, oh wow :) [06:23:44] it's not in our repo though... [06:24:39] doesn't look like it [06:24:42] legoktm, but it seems like it hasn't been changed since 2006 [06:24:44] http://search.cpan.org/~tels/mediawiki-graph/ [06:25:13] but they still got the name first :P [06:25:32] nah, they can't hold on to such powerful name, sorry :) [06:25:42] if we will be maintaining it [06:25:48] http://cpansearch.perl.org/src/TELS/mediawiki-graph-0.21/ [06:26:05] their code is completely bitrotten [06:26:59] it would still be nice if you could use a different name other than Graph. [06:27:11] legoktm, we already created a git repo [06:27:21] the code is 8 years old [06:27:45] just because somenoe out there created an unmaintained wiki page? [06:27:56] meh [06:28:00] https://wikiapiary.com/wiki/Extension:Graph no one appears to be using it [06:28:42] exactly [06:29:03] we should move it to archive, and possibly give a link at the top of the new MW page [06:29:11] seems fine then I guess [06:31:56] legoktm, are you moving it or should i? [06:32:03] I'll let you do it [06:32:07] I don't know what to replace it with [06:45:17] (03PS1) 10Yurik: Refactored Limn->Graph, simplified file structure [extensions/Graph] - 10https://gerrit.wikimedia.org/r/153756 [06:45:35] legoktm, updated page, fixed ext ^ [06:45:50] :D [06:53:59] 3MediaWiki extensions / 3SemanticFormsInputs: datepicker calendar behaves bad in IE - 10https://bugzilla.wikimedia.org/69458 (10user66) 3UNCO p:3Unprio s:3normal a:3s7eph4n Showing the calender does not really work in Internet Explorer. Once I click to the calendar icon, the page scrolls to a more or... [06:57:23] 3Wikimedia / 3Site requests: raise IP account creation cap for CIS (tewiki) event 2014-08-11 - 2014-08-14 - 10https://bugzilla.wikimedia.org/69385#c5 (10Rahmanuddin Shaik) From what I can confirm from Praveen Illa, This event has been completed. With constant error message raised on cap on user account crea... [07:19:08] 3Wikimedia / 3Deployment systems: MWMultiVersion can fatal for bad Host headers - 10https://bugzilla.wikimedia.org/69419#c4 (10Antoine "hashar" Musso) 5PATC>3NEW The test that got merge above, just assert the current behavior. We might want to throw / output something else for non-existing hostnames. [07:21:39] 3MediaWiki extensions / 3WikiEditor: document.selection no longer supported in IE11 - 10https://bugzilla.wikimedia.org/66531 (10Derk-Jan Hartman) 5UNCO>3ASSI p:5Unprio>3High a:3Derk-Jan Hartman [07:22:19] (03CR) 10Lyhana8: "I re-send my pull request to the new repo" [extensions/Limn] - 10https://gerrit.wikimedia.org/r/153753 (owner: 10Yurik) [07:22:40] 3MediaWiki extensions / 3WikiEditor: In Insert Image dialog box the Align and Format settings are not set to any values - 10https://bugzilla.wikimedia.org/67111 (10Derk-Jan Hartman) 5UNCO>3ASSI [07:22:40] 3MediaWiki extensions / 3WikiEditor: In Insert Image dialog box the Align and Format settings are not set to any values - 10https://bugzilla.wikimedia.org/67111 (10Derk-Jan Hartman) a:3Derk-Jan Hartman [07:23:23] 3MediaWiki / 3Unit tests: MediaWiki core qunit tests consistently randomly failing on jenkins - 10https://bugzilla.wikimedia.org/69448#c1 (10Antoine "hashar" Musso) I know at least of: Bug 68884 - Inconsistent "Unfinished animations" error, probably being attributed to the wrong module Bug 67481 - mw.track... [07:25:29] (03CR) 10Yurik: "Lyhana8, not sure what you mean. I don't see any patches in https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/Graph,n,z" [extensions/Limn] - 10https://gerrit.wikimedia.org/r/153753 (owner: 10Yurik) [07:27:09] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: When creating the index fail if dynamic scripting isn't set correctly or if elasticsearch isn't the minimum required version - 10https://bugzilla.wikimedia.org/68804#c4 (10keyler) It's working. Thank you Nik! [07:27:50] (03PS2) 10Zfilipin: Chrome 28 is the last version that works properly on Sauce Labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/153408 (https://bugzilla.wikimedia.org/69399) [07:27:53] (03CR) 10Lyhana8: "I meant on the github repo: https://github.com/wikimedia/mediawiki-extensions-Graph/pull/1" [extensions/Limn] - 10https://gerrit.wikimedia.org/r/153753 (owner: 10Yurik) [07:33:02] (03CR) 10Yurik: "Édouard, thx, would love to merge it, but that patch is fairly outdated - I have already done some refactorings plus more will be merged s" [extensions/Limn] - 10https://gerrit.wikimedia.org/r/153753 (owner: 10Yurik) [07:41:40] 3MediaWiki extensions / 3CirrusSearch: PHP Warning: Invalid argument - 10https://bugzilla.wikimedia.org/69459 (10keyler) 3UNCO p:3Unprio s:3minor a:3None When using CirrusSearch (Master) we get the following with mw1.23.2. I know we should use CirrusSearch 1.23 but I wanted to try the newest changes... [07:47:05] (03CR) 10Yurik: [C: 032 V: 032] "Self-publishing since this is not in prod and we have github contributor for this" [extensions/Graph] - 10https://gerrit.wikimedia.org/r/153756 (owner: 10Yurik) [07:48:14] (03PS1) 10Legoktm: Add option to include emailconfirmed accounts [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153760 (https://bugzilla.wikimedia.org/54760) [07:48:42] Nemo_bis: ^ [07:52:53] 3MediaWiki / 3Unit tests: MediaWiki core qunit tests consistently randomly failing on jenkins - 10https://bugzilla.wikimedia.org/69448#c2 (10Kunal Mehta (Legoktm)) A random selection of failure logs from my merged commits: https://integration.wikimedia.org/ci/job/mediawiki-core-qunit/25964/console https://... [07:58:48] (03CR) 10Nemo bis: "Without the token, they need to login, right? (IIRC Special:MergeAccount/$token bypassed that, but I only tried one year ago.)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153760 (https://bugzilla.wikimedia.org/54760) (owner: 10Legoktm) [08:00:55] Nemo_bis: yes, but they would have needed to login anyways to merge their account afais [08:02:03] I probably didn't try that [08:02:40] * legoktm tests [08:05:53] 3MediaWiki extensions / 3ProofreadPage: Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar - 10https://bugzilla.wikimedia.org/69447 (10Andre Klapper) p:5Unprio>3Low [08:12:06] Nemo_bis: what it looks like http://cl.ly/image/122J090Z411W [08:12:10] 3MediaWiki / 3General/Unknown: Edit box disappeared on Polish Wikisource proofread pages - 10https://bugzilla.wikimedia.org/69446#c2 (10Andre Klapper) Created attachment 16182 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16182&action=edit Screenshot from Firefox 31 (In reply to wieralee from comme... [08:13:07] (03CR) 10Zfilipin: [C: 032] Chrome 28 is the last version that works properly on Sauce Labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/153408 (https://bugzilla.wikimedia.org/69399) (owner: 10Zfilipin) [08:13:40] (03Merged) 10jenkins-bot: Chrome 28 is the last version that works properly on Sauce Labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/153408 (https://bugzilla.wikimedia.org/69399) (owner: 10Zfilipin) [08:15:32] (03CR) 10Bartosz Dziewoński: [C: 031] Scope external link styling rules to #content rather than #bodyContent [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/153740 (https://bugzilla.wikimedia.org/38726) (owner: 10Catrope) [08:19:00] (03CR) 10Yurik: "Merged the patch into master, so should be properly replicated to github. Still, would be great if you can use gerrit. thx!" [extensions/Limn] - 10https://gerrit.wikimedia.org/r/153753 (owner: 10Yurik) [08:19:53] 3MediaWiki extensions / 3[other]: EmbedVideo extension delivers youtube videos using http instead of https causing modern browsers to block the content - 10https://bugzilla.wikimedia.org/69454#c2 (10Andre Klapper) p:5Unprio>3Lowest https://www.mediawiki.org/wiki/Extension:EmbedVideo says this is not main... [08:23:08] 3Wikimedia / 3Site requests: raise IP account creation cap for CIS (tewiki) event 2014-08-11 - 2014-08-14 - 10https://bugzilla.wikimedia.org/69385#c6 (10Andre Klapper) 5UNCO>3RESO/WOR (In reply to Rahmanuddin Shaik from comment #5) > With constant error message raised on cap on > user account creation,... [08:31:41] 3MediaWiki / 3ResourceLoader: Resource loader ignores requested caching directives / not caching properly - 10https://bugzilla.wikimedia.org/69460 (10metatron) 3NEW p:3Unprio s:3normal a:3None When loading a gagdget or custom script from eg. meta/mediawiki/enwiki with -mw.loader.load('//meta.wikimed... [08:35:57] (03CR) 10Bartosz Dziewoński: "Probably related: https://gerrit.wikimedia.org/r/#/c/153740/" [core] - 10https://gerrit.wikimedia.org/r/151395 (owner: 10Arlolra) [08:36:08] (03CR) 10Bartosz Dziewoński: "Related? https://gerrit.wikimedia.org/r/#/c/151395/" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/153740 (https://bugzilla.wikimedia.org/38726) (owner: 10Catrope) [08:37:29] (03CR) 10Legoktm: "Yup, but they need to do that with the token too. See ." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153760 (https://bugzilla.wikimedia.org/54760) (owner: 10Legoktm) [08:39:32] legoktm: What do you think about https://gerrit.wikimedia.org/r/153742 ? [08:40:26] (03CR) 10Legoktm: [C: 032] Log if there are pending DB interactions in CentralAuthUser::attach [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153742 (owner: 10Hoo man) [08:40:35] (03Merged) 10jenkins-bot: Log if there are pending DB interactions in CentralAuthUser::attach [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153742 (owner: 10Hoo man) [08:40:48] I'm very very very behind on gerrit email right now [08:41:00] heh... there's more from me :P [08:41:16] Changed a global group membership yesterday and WTFed at the special page [08:42:19] (03PS3) 10SG: Move jQueryFindWithParent into its own findWithParent plugin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153627 [08:42:44] I think https://gerrit.wikimedia.org/r/#/c/153743/ fixes a bug [08:42:53] * legoktm looks [08:42:55] (03CR) 10jenkins-bot: [V: 04-1] Move jQueryFindWithParent into its own findWithParent plugin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153627 (owner: 10SG) [08:43:39] 3MediaWiki / 3General/Unknown: Edit box disappeared on Polish Wikisource proofread pages - 10https://bugzilla.wikimedia.org/69446#c3 (10wieralee) From 21:30 till today morning bug existed for anyone who used Mozilla, IE or Chrome. Only Opera was without the bug. We were talking about it on IRC. I was yeste... [08:44:19] hoo: https://bugzilla.wikimedia.org/show_bug.cgi?id=15651 probably? [08:44:54] legoktm: Ah yes [08:44:56] will add that [08:45:36] (03PS3) 10Hoo man: Simplify Special:GlobalGroupMembership [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153743 (https://bugzilla.wikimedia.org/15651) [08:46:08] 3MediaWiki extensions / 3CentralAuth: Do not require globalgrouppermissions or globalgroupmembership rights in global groups to access Special:GlobalGroupPermissions or Special:GlobalGroupMembership - 10https://bugzilla.wikimedia.org/43916#c7 (10Kunal Mehta (Legoktm)) Dupe of bug 29435? [08:46:30] hoo: ok, I'll look in the morning, I'm not awake enough to review things right now. [08:46:59] damn you, time shift :D [08:52:08] (03CR) 10Smuggli: [C: 032 V: 032] Improved js syntax [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/152898 (owner: 10Smuggli) [08:52:53] 3MediaWiki / 3ResourceLoader: Resource loader ignores requested caching directives / not caching properly - 10https://bugzilla.wikimedia.org/69460#c1 (10Michael M.) I can reproduce this on any WMF wiki (including *.beta.wmflabs.org, both logged in and logged out), but not on my private test wiki or on other... [08:54:51] (03CR) 10Matthias Mullie: "As far as I'm concerned, this looks good, feel free to merge" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145331 (owner: 10SG) [08:54:59] (03CR) 10Matthias Mullie: [C: 031] Update mw-ui.enhance to Core version, add support for select, radio, and checkboxes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145331 (owner: 10SG) [09:10:05] (03CR) 10Nemo bis: "Thanks for testing. It doesn't matter then." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153760 (https://bugzilla.wikimedia.org/54760) (owner: 10Legoktm) [09:11:08] 3Wikimedia / 3General/Unknown: Resource loader ignores requested caching directives / not caching properly - 10https://bugzilla.wikimedia.org/69460#c2 (10Michael M.) I can confirm that appending &bcache=1 to the URL will set the Cache-Control as expected, so this definitely is caused by http://git.wikimedia.... [09:12:27] (03PS2) 10Nemo bis: Add option to include emailconfirmed accounts [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153760 (https://bugzilla.wikimedia.org/54760) (owner: 10Legoktm) [09:14:08] (03PS4) 10Nemo bis: Simplify Special:GlobalGroupMembership [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153743 (https://bugzilla.wikimedia.org/15651) (owner: 10Hoo man) [09:17:12] (03CR) 10MaxSem: "Global function, really?" [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/153754 (owner: 10Legoktm) [09:23:40] 3MediaWiki extensions / 3Translate: Conflict of Special:MyLanguage: Extension and MW core use the same special page name - 10https://bugzilla.wikimedia.org/69461 (10Lokal_Profil) 3NEW p:3Unprio s:3normal a:3None Special:MyLanguage is now also defined in core. This results in a clash at e.g. Special:... [09:29:57] (03CR) 10Nemo bis: "Mentioned the log on https://wikitech.wikimedia.org/w/index.php?title=Logs&diff=123268&oldid=114910 fwiw" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153742 (owner: 10Hoo man) [09:30:09] 3MediaWiki extensions / 3Translate: Conflict of Special:MyLanguage: Extension and MW core use the same special page name - 10https://bugzilla.wikimedia.org/69461 (10Lokal_Profil) [09:36:54] 3MediaWiki extensions / 3Translate: Conflict of Special:MyLanguage: Extension and MW core use the same special page name - 10https://bugzilla.wikimedia.org/69461 (10Lokal_Profil) [09:36:56] 3MediaWiki / 3Special pages: Move "Special:MyLanguage" from Extension:Translate to MediaWiki core - 10https://bugzilla.wikimedia.org/66762 (10Lokal_Profil) [09:38:23] 3MediaWiki extensions / 3Translate: Conflict of Special:MyLanguage: Extension and MW core use the same special page name - 10https://bugzilla.wikimedia.org/69461#c1 (10Lokal_Profil) Note that this completely blocks all further l10n of names for Special pages until resolved. [09:42:53] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445 (10Nemo) p:5Unprio>3Lowest s:5normal>3enhanc [09:45:22] (03PS1) 10Yurik: Path fix [extensions/Graph] - 10https://gerrit.wikimedia.org/r/153765 [09:45:54] (03CR) 10Yurik: [C: 032 V: 032] "Accidentally forgot this fix" [extensions/Graph] - 10https://gerrit.wikimedia.org/r/153765 (owner: 10Yurik) [09:49:23] 3MediaWiki / 3Skin and page rendering: Kill the skins/common/ directory in mediawiki/core, moving the contents somewhere else - 10https://bugzilla.wikimedia.org/69277 (10Bartosz Dziewoński) [09:50:45] (03PS1) 10Paladox: Move file to git. [extensions/InterwikiExistence] - 10https://gerrit.wikimedia.org/r/153767 [09:51:05] (03PS2) 10Paladox: Move file to git [extensions/InterwikiExistence] - 10https://gerrit.wikimedia.org/r/153767 [09:58:53] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ShareThisWidget] - 10https://gerrit.wikimedia.org/r/152605 (owner: 10Hashar) [09:58:57] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ShrinkTheWeb] - 10https://gerrit.wikimedia.org/r/152608 (owner: 10Hashar) [09:59:25] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/SignupAPI] - 10https://gerrit.wikimedia.org/r/152610 (owner: 10Hashar) [10:00:00] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/SimpleSamlAuth] - 10https://gerrit.wikimedia.org/r/152613 (owner: 10Hashar) [10:01:33] (03CR) 10JanZerebecki: [C: 031] Use protocol relative URLs for some links on Transparency Report pages [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153026 (owner: 10Chmarkine) [10:01:42] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/SpecialNamespaces] - 10https://gerrit.wikimedia.org/r/152631 (owner: 10Hashar) [10:02:23] 3MediaWiki skins / 3Vector: Logo cut when smaller font size is set in browser - 10https://bugzilla.wikimedia.org/69390 (10Bartosz Dziewoński) 5UNCO>3NEW [10:02:52] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/UserPageViewTracker] - 10https://gerrit.wikimedia.org/r/152671 (owner: 10Hashar) [10:03:27] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/UserSnoop] - 10https://gerrit.wikimedia.org/r/152672 (owner: 10Hashar) [10:03:30] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VersionView] - 10https://gerrit.wikimedia.org/r/152674 (owner: 10Hashar) [10:03:34] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VideoJsPlayer] - 10https://gerrit.wikimedia.org/r/152676 (owner: 10Hashar) [10:04:09] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/WebCache] - 10https://gerrit.wikimedia.org/r/152685 (owner: 10Hashar) [10:04:13] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/WhichImageIsBetter] - 10https://gerrit.wikimedia.org/r/152687 (owner: 10Hashar) [10:06:23] 3MediaWiki / 3Skin and page rendering: MediaWiki UI: VForm only partially documented - 10https://bugzilla.wikimedia.org/69449 (10Bartosz Dziewoński) s:5normal>3major [10:06:24] 3MediaWiki / 3Documentation: Documentation is out of date, incomplete (tracking) - 10https://bugzilla.wikimedia.org/1 (10Bartosz Dziewoński) [10:28:38] 3MediaWiki extensions / 3Translate: Conflict of Special:MyLanguage: Extension and MW core use the same special page name - 10https://bugzilla.wikimedia.org/69461#c2 (10Niklas Laxström) I think there is a working but ugly workaround: 1) Copy all current translations of MyLanguage to core 2) Move all current... [10:29:10] 3MediaWiki / 3Page protection: [regression] Protection options on action=protect displayed in wrong order when custom protection levels are present - 10https://bugzilla.wikimedia.org/69464 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None Created attachment 16183 --> https://bugzilla.wikimedi... [10:31:41] (03CR) 10Thiemo Mättig (WMDE): "Which part needs what? Can you please explain what's wrong with this change?" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/148583 (https://bugzilla.wikimedia.org/68417) (owner: 10Spage) [10:33:00] (03PS1) 10Shirayuki: i18n: fix quotation of "security-desc-LS" [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/153771 [10:40:11] (03PS1) 10Tweichart: added hook [extensions/BlueSpiceExtensions] (REL1_22) - 10https://gerrit.wikimedia.org/r/153773 [10:42:25] (03PS1) 10Tweichart: added hook [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/153774 [10:49:42] (03CR) 10Smuggli: [V: 031] "For the future, it would be good if you could provide a little description why you added the hook and for what it is needed." [extensions/BlueSpiceExtensions] (REL1_22) - 10https://gerrit.wikimedia.org/r/153773 (owner: 10Tweichart) [10:52:53] (03PS1) 10Arlolra: Use .mw-body instead of div#content [skins/Vector] - 10https://gerrit.wikimedia.org/r/153775 [10:54:08] (03CR) 10Prtksxna: "> Which part needs what?" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/148583 (https://bugzilla.wikimedia.org/68417) (owner: 10Spage) [10:57:22] (03CR) 10Smuggli: [C: 031] added hook [extensions/BlueSpiceExtensions] (REL1_22) - 10https://gerrit.wikimedia.org/r/153773 (owner: 10Tweichart) [10:59:13] (03CR) 10Se4598: [C: 031] "see inline. I don't understand whats wrong with that code comment." (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/148583 (https://bugzilla.wikimedia.org/68417) (owner: 10Spage) [11:03:39] (03PS1) 10Arlolra: Use .mw-body instead of div#content [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/153777 [11:05:16] (03PS2) 10Arlolra: Use .mw-body instead of div#content [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/153777 [11:05:28] (03PS1) 10Aude: Load WikibaseRepo settings only when repo is enabled [vagrant] - 10https://gerrit.wikimedia.org/r/153778 [11:05:38] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c3 (10Gilles Dubuc) Why can't we just do this the same way as our current status quo (gerrit) or the soon-to-be status quo (phabricator)? Less systems tha... [11:05:58] (03CR) 10Prtksxna: Don't render popup on "javascript:..." links. (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/148583 (https://bugzilla.wikimedia.org/68417) (owner: 10Spage) [11:06:03] (03CR) 10Thiemo Mättig (WMDE): "I still don't see a reason for your -1. Same with the comment by Spage. Why should the code that removes popups use the same conditions as" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/148583 (https://bugzilla.wikimedia.org/68417) (owner: 10Spage) [11:08:45] (03CR) 10Prtksxna: [C: 032 V: 032] Don't render popup on "javascript:..." links. (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/148583 (https://bugzilla.wikimedia.org/68417) (owner: 10Spage) [11:08:53] 3MediaWiki extensions / 3Translate: "Translate to" dropdown doesn't work; can't select language to translate - 10https://bugzilla.wikimedia.org/69346#c3 (10Quim Gil) 5NEW>3RESO/INV The server is back, and now the dropdown actually works. Probably unrelated, but anyway. I will resolve the report as INVALI... [11:09:37] (03CR) 10Prtksxna: "> Why should the code that removes popups use the same conditions as the code that adds popups?" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/148583 (https://bugzilla.wikimedia.org/68417) (owner: 10Spage) [11:10:28] (03CR) 10Tweichart: [C: 032 V: 032] added hook [extensions/BlueSpiceExtensions] (REL1_22) - 10https://gerrit.wikimedia.org/r/153773 (owner: 10Tweichart) [11:16:02] (03CR) 10Thiemo Mättig (WMDE): "Oh... ouch. The method does not remove tooltips a.k.a. popups, it removes title attributes. Why is this a separate function? Why is this n" (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/148583 (https://bugzilla.wikimedia.org/68417) (owner: 10Spage) [11:17:37] (03PS4) 10Arlolra: Use .mw-body in skins [core] - 10https://gerrit.wikimedia.org/r/151395 [11:19:28] (03CR) 10Arlolra: "Can we do this instead?" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/153740 (https://bugzilla.wikimedia.org/38726) (owner: 10Catrope) [11:22:02] (03CR) 10Arlolra: "Changes to the skins are now in," [core] - 10https://gerrit.wikimedia.org/r/151395 (owner: 10Arlolra) [11:28:09] 3MediaWiki / 3Unit tests: MediaWiki core qunit tests consistently randomly failing on jenkins - 10https://bugzilla.wikimedia.org/69448#c3 (10Antoine "hashar" Musso) 5NEW>3RESO/DUP All failing tests show "unfinished animation". Matthew Flaschen filled a bug for it Bug 68884 - Inconsistent "Unfinished an... [11:28:09] 3MediaWiki / 3Unit tests: Inconsistent "Unfinished animations" error, probably being attributed to the wrong module - 10https://bugzilla.wikimedia.org/68884#c2 (10Antoine "hashar" Musso) *** Bug 69448 has been marked as a duplicate of this bug. *** [11:28:23] (03CR) 10Lokal Profil: "Wouldn't it be better to change it into" [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/153771 (owner: 10Shirayuki) [11:29:38] 3MediaWiki / 3Unit tests: Inconsistent "Unfinished animations" error, probably being attributed to the wrong module - 10https://bugzilla.wikimedia.org/68884#c3 (10Antoine "hashar" Musso) It is still bitting core badly. Is there a way to reliably reproduce the issue? Would be nice to bisect and revert whate... [11:32:38] (03CR) 10Bartosz Dziewoński: "I like it. Is there actually any skin that uses the new mechanism already to test this with?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153540 (owner: 10Legoktm) [11:33:40] (03CR) 10Pwirth: [C: 031 V: 031] added hook [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/153774 (owner: 10Tweichart) [11:33:51] (03PS1) 10Deepali: Allow mass indentation changes in JSON editor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/153779 (https://bugzilla.wikimedia.org/52417) [11:33:57] (03CR) 10jenkins-bot: [V: 04-1] Allow mass indentation changes in JSON editor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/153779 (https://bugzilla.wikimedia.org/52417) (owner: 10Deepali) [11:34:27] (03CR) 10Prtksxna: "Exactly." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/148583 (https://bugzilla.wikimedia.org/68417) (owner: 10Spage) [11:37:40] (03PS4) 10Bartosz Dziewoński: SkinFactory: register skins in Setup.php [core] - 10https://gerrit.wikimedia.org/r/153540 (owner: 10Legoktm) [11:37:53] (03CR) 10Bartosz Dziewoński: [C: 031] SkinFactory: register skins in Setup.php [core] - 10https://gerrit.wikimedia.org/r/153540 (owner: 10Legoktm) [11:40:01] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Let me tweak some more doc comments here." [core] - 10https://gerrit.wikimedia.org/r/153540 (owner: 10Legoktm) [11:41:12] (03CR) 10Bartosz Dziewoński: "Oh also. This changes the behavior for $wgValidSkinNames skins to require the skin class to be a subclass of Skin. This sounds reasonable," [core] - 10https://gerrit.wikimedia.org/r/153540 (owner: 10Legoktm) [11:49:53] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c4 (10Zell Faze) I think the community would likely reject attempts to use git or gerrit. Whatever this system is, it will need to be implemented within... [11:55:04] (03CR) 10Manybubbles: "If you don't +2 then I'll have to. Please do if you like it." [search/highlighter] - 10https://gerrit.wikimedia.org/r/150013 (owner: 10Manybubbles) [11:55:41] (03CR) 10Manybubbles: [C: 032] Documentation typos [search/highlighter] - 10https://gerrit.wikimedia.org/r/153747 (owner: 10BearND) [11:59:37] (03CR) 10Manybubbles: [C: 032] Replace some for loops with foreach [search/highlighter] - 10https://gerrit.wikimedia.org/r/153749 (owner: 10BearND) [12:00:55] (03PS5) 10Bartosz Dziewoński: SkinFactory: register skins in Setup.php [core] - 10https://gerrit.wikimedia.org/r/153540 (owner: 10Legoktm) [12:00:57] (03PS8) 10Bartosz Dziewoński: [DO NOT MERGE] Completely remove skin autodiscovery [core] - 10https://gerrit.wikimedia.org/r/135439 (https://bugzilla.wikimedia.org/65748) [12:00:59] (03PS1) 10Bartosz Dziewoński: SkinFactory: Improve documentation and comments [core] - 10https://gerrit.wikimedia.org/r/153781 [12:02:19] (03CR) 10Bartosz Dziewoński: [C: 031] "I submitted a separate change for documentation improvements (https://gerrit.wikimedia.org/r/#/c/153781/1) and updated the "kill autodisco" [core] - 10https://gerrit.wikimedia.org/r/153540 (owner: 10Legoktm) [12:06:38] 3Wikimedia / 3Extension setup: Security review BounceHandler extension for deployement - 10https://bugzilla.wikimedia.org/69099#c11 (10Tony Thomas) Almost every issue pointed out here is fixed in the above patch sets. [12:08:08] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c5 (10Bartosz Dziewoński) Indeed. This definitely must be implemented "inside" MediaWiki (whatever the backend we use, the UI must be displayed within reg... [12:12:34] (03PS1) 10QChris: Add .gitreview [extensions/Graph] - 10https://gerrit.wikimedia.org/r/153782 [12:15:11] 3Wikimedia / 3Site requests: Create moderator group at the Vietnamese Wikipedia - 10https://bugzilla.wikimedia.org/68612#c10 (10Minh Nguyễn) If deleterevision depends on deletedhistory and deletedtext, I'd suggest adding the required rights. I can start a new community poll if necessary, but it seems like an... [12:24:40] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445 (10Helder) [12:24:40] 3MediaWiki / 3Unit tests: Provide standard way to create/run QUnit tests for Gadgets and user scripts - 10https://bugzilla.wikimedia.org/37230 (10Helder) [12:27:24] 3Wikimedia / 3General/Unknown: Auto-generated gadget documentation with JsDuck - 10https://bugzilla.wikimedia.org/51651 (10Helder) [12:27:25] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445 (10Helder) [12:27:53] 3MediaWiki / 3Unit tests: Provide standard way to create/run QUnit tests for Gadgets and user scripts - 10https://bugzilla.wikimedia.org/37230 (10Helder) [12:28:08] 3Wikimedia / 3General/Unknown: Auto-generated gadget documentation with JsDuck - 10https://bugzilla.wikimedia.org/51651 (10Helder) [12:28:23] 3MediaWiki / 3JobRunner: Jobrunner will fail to spawn jobs on HHVM - 10https://bugzilla.wikimedia.org/69428 (10Ori Livneh) p:5Unprio>3High [12:30:26] 3MediaWiki / 3Parser: RTL/bidirectional issues (tracking) - 10https://bugzilla.wikimedia.org/745 (10Amir E. Aharoni) [12:44:57] 3MediaWiki extensions / 3Math: Enable Visual Editor for Math by default - 10https://bugzilla.wikimedia.org/69466 (10physikerwelt) 3NEW p:3Unprio s:3normal a:3None I'm using the vagrant role visual-editor for my wiki. After enabling the visual editor role I could not edit formulae... The message is av... [12:46:08] 3MediaWiki extensions / 3Math: Enable Visual Editor for Math by default - 10https://bugzilla.wikimedia.org/69466 (10physikerwelt) p:5Unprio>3Low s:5normal>3minor [12:50:38] 3MediaWiki extensions / 3Math: Enable Visual Editor for Math by default - 10https://bugzilla.wikimedia.org/69466#c1 (10physikerwelt) Created attachment 16184 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16184&action=edit Visual editor for math disabled [12:58:23] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c6 (10MZMcBride) I'm not sure this problem is being approached in the best way. I think it would be helpful to look at use-cases and work backward from th... [13:01:36] (03CR) 10Addshore: [C: 031] Fix for Ia9baaf0b: magic functions for previously public class members [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [13:08:08] 3Wikimedia / 3Git/Gerrit: Free-form tagging in gerrit - 10https://bugzilla.wikimedia.org/35534#c17 (10Quim Gil) Is it safe to assume that no further development will be put into our Gerrit instance? This request seems to be fulfilled by Phabricator + Differential features. See http://fab.wmflabs.org/tag/code... [13:25:25] 3Wikimedia / 3Site requests: raise IP account creation cap for CIS (tewiki) event 2014-08-11 - 2014-08-14 - 10https://bugzilla.wikimedia.org/69385#c7 (10jeremyb) 5RESO/?>3VERI (In reply to Andre Klapper from comment #6) > This problem could have been avoided by creating this ticket a few days > earlier,... [13:28:10] 3MediaWiki extensions / 3WikidataRepo: JS ReferenceErrors due to Resource Loader changes - 10https://bugzilla.wikimedia.org/69468 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs We're getting a whole load of ReferenceErrors most likely caused by this change in core: https://gerrit.w... [13:28:40] (03PS12) 10All1: Moved texvc.js and wiki2jax.js [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [13:29:08] 3MediaWiki extensions / 3WikidataRepo: JS ReferenceErrors due to Resource Loader changes - 10https://bugzilla.wikimedia.org/69468 (10tobias.gritschacher) p:5Unprio>3Immedi s:5normal>3blocke [13:32:49] (03PS1) 10JoelKP: Add proper i18n messages, replacing the previous placeholders. [extensions/PhpTagsSMW] - 10https://gerrit.wikimedia.org/r/153787 [13:33:25] 3MediaWiki extensions / 3WikidataRepo: Create jQuery.wikibase.aliasview - 10https://bugzilla.wikimedia.org/69470 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Implement jQuery.wikibase.aliasview to get aliases into the new UI. [13:33:54] 3MediaWiki extensions / 3WikidataRepo: Create jQuery.wikibase.aliasview - 10https://bugzilla.wikimedia.org/69470 (10tobias.gritschacher) p:5Unprio>3High [13:34:40] 3MediaWiki extensions / 3WikidataRepo: Create jQuery.wikibase.descriptionview - 10https://bugzilla.wikimedia.org/69471 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Implement jQuery.wikibase.descriptionview to get description into the new UI. [13:34:53] 3MediaWiki extensions / 3WikidataRepo: Create jQuery.wikibase.descriptionview - 10https://bugzilla.wikimedia.org/69471 (10tobias.gritschacher) p:5Unprio>3High [13:35:26] 3MediaWiki extensions / 3WikidataRepo: Create jQuery.wikibase.labelview - 10https://bugzilla.wikimedia.org/69472 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Implement jQuery.wikibase.labelview to get aliases into the new UI. [13:35:39] 3MediaWiki extensions / 3WikidataRepo: Create jQuery.wikibase.labelview - 10https://bugzilla.wikimedia.org/69472 (10tobias.gritschacher) p:5Unprio>3High [13:36:58] (03PS8) 10Phuedx: WIP Enable browser tests for the GettingStarted extension [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/150172 (https://bugzilla.wikimedia.org/52246) [13:37:10] (03CR) 10Phuedx: WIP Enable browser tests for the GettingStarted extension (032 comments) [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/150172 (https://bugzilla.wikimedia.org/52246) (owner: 10Phuedx) [13:37:54] 3MediaWiki extensions / 3CirrusSearch: Add syntax for searching for articles with a given wikilink - 10https://bugzilla.wikimedia.org/69295#c3 (10Nik Everett) I'm glad it'll work for you! I'm not sure when it'll get deployed because Chad is on vacation this week. He'll have a large backlog of code reviews... [13:42:52] (03PS26) 10Matthias Mullie: New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [13:42:55] (03PS13) 10Matthias Mullie: Move watch star for boards next to the header. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149210 (owner: 10Werdna) [13:42:58] (03PS5) 10Matthias Mullie: Subscribe to board = auto-subscribe to new topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153411 [13:43:01] (03PS1) 10Matthias Mullie: Get rid of isAlwaysWatched [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153789 [13:44:57] (03CR) 10Matthias Mullie: [C: 031] "LGTM but I've made some changes myself. Someone else please merge this." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149210 (owner: 10Werdna) [13:45:18] (03CR) 10Matthias Mullie: [C: 031] "LGTM but I've made some changes myself. Someone else please merge this." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [13:45:37] (03CR) 10JoelKP: add object ExtArrays (v 1.0.0) (031 comment) [extensions/PhpTagsSMW] - 10https://gerrit.wikimedia.org/r/152721 (owner: 10Pastakhov) [13:46:23] 3Wikimedia / 3Site requests: raise IP account creation cap for CIS (tewiki) event 2014-08-11 - 2014-08-14 - 10https://bugzilla.wikimedia.org/69385#c8 (10jeremyb) and I guess comment 5 and the talk page I linked are the same person? (different spellings) Anyway, tell us /early/ and don't make us peel teeth o... [13:46:35] (03CR) 10Zfilipin: QA: Mark known-failing test so CI goes green (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153547 (owner: 10Spage) [13:50:01] (03PS13) 10All1: Moved texvc.js and wiki2jax.js [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [13:53:57] 3MediaWiki extensions / 3WikidataRepo: Create SiteLink widget for SiteLink UI - 10https://bugzilla.wikimedia.org/68906 (10tobias.gritschacher) [13:53:57] 3MediaWiki extensions / 3WikidataRepo: Create page-selector widget for SiteLink UI - 10https://bugzilla.wikimedia.org/68905 (10tobias.gritschacher) [13:53:57] 3MediaWiki extensions / 3WikidataRepo: Factor interaction logic out of MergeItems API module, for re-use in SpecialMergeItems - 10https://bugzilla.wikimedia.org/68730 (10tobias.gritschacher) [13:53:57] 3MediaWiki extensions / 3WikidataRepo: Create SiteLinks widget for SiteLink UI - 10https://bugzilla.wikimedia.org/68907 (10tobias.gritschacher) [13:54:10] 3MediaWiki extensions / 3WikidataRepo: Test conformance of API modules - 10https://bugzilla.wikimedia.org/67407 (10tobias.gritschacher) [13:54:11] 3MediaWiki extensions / 3WikidataRepo: [Monolingual] Exact language code match should be first - 10https://bugzilla.wikimedia.org/67395 (10tobias.gritschacher) [13:54:11] 3MediaWiki extensions / 3WikidataClient: the show/hide recent changes and watchlist toggle does not respect showExternalRecentChanges setting - 10https://bugzilla.wikimedia.org/68461 (10tobias.gritschacher) [13:54:24] 3MediaWiki extensions / 3WikidataRepo: Section-edit mode for SiteLinks - 10https://bugzilla.wikimedia.org/68908 (10tobias.gritschacher) [13:54:25] 3MediaWiki extensions / 3WikidataRepo: Create browser smoke test for a typical item - 10https://bugzilla.wikimedia.org/68094 (10tobias.gritschacher) [13:55:25] (03PS2) 10JoelKP: Add proper i18n messages, replacing the previous placeholders. [extensions/PhpTagsSMW] - 10https://gerrit.wikimedia.org/r/153787 [14:00:39] (03PS14) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [14:01:38] 3MediaWiki extensions / 3CirrusSearch: Add syntax for searching for articles with a given wikilink - 10https://bugzilla.wikimedia.org/69295#c4 (10Edward Betts) No rush, thanks. [14:03:06] (03PS15) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [14:10:22] (03PS16) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [14:14:11] (03CR) 10Matthias Mullie: "bsitu: Seems to be because AbstractRevision::getUserInternal forgets to return anonymous user objects" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150141 (owner: 10EBernhardson) [14:16:08] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c7 (10Gilles Dubuc) The fact that people who aren't developers and/or who don't understand what custom JS they're deploying to millions of users is the pr... [14:16:12] (03PS11) 10Matthias Mullie: Move notification creation to event listener [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150141 (owner: 10EBernhardson) [14:16:18] (03CR) 10jenkins-bot: [V: 04-1] Move notification creation to event listener [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150141 (owner: 10EBernhardson) [14:18:33] (03PS12) 10Matthias Mullie: Move notification creation to event listener [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150141 (owner: 10EBernhardson) [14:19:15] (03CR) 10Matthias Mullie: [C: 032] Move notification creation to event listener [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150141 (owner: 10EBernhardson) [14:19:36] (03PS5) 10Matthias Mullie: Revert "Revert "Utilize BufferedCache in TreeRepository"" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145749 (owner: 10EBernhardson) [14:19:49] (03Merged) 10jenkins-bot: Move notification creation to event listener [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150141 (owner: 10EBernhardson) [14:20:35] (03CR) 10Matthias Mullie: [C: 032] Revert "Revert "Utilize BufferedCache in TreeRepository"" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145749 (owner: 10EBernhardson) [14:21:09] (03Merged) 10jenkins-bot: Revert "Revert "Utilize BufferedCache in TreeRepository"" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145749 (owner: 10EBernhardson) [14:21:25] 3MediaWiki extensions / 3WikidataRepo: allow adding wikidata pages as site links - 10https://bugzilla.wikimedia.org/67531 (10tobias.gritschacher) 5ASSI>3RESO/FIX [14:21:54] 3MediaWiki extensions / 3WikidataClient: draft RfC for improving recent changes formatting - 10https://bugzilla.wikimedia.org/68028 (10tobias.gritschacher) [14:23:09] 3MediaWiki extensions / 3WikidataRepo: allow adding wikidata pages as site links - 10https://bugzilla.wikimedia.org/67531 (10tobias.gritschacher) 5RESO/FIX>3REOP [14:23:38] 3MediaWiki extensions / 3WikidataRepo: allow adding wikidata pages as site links - 10https://bugzilla.wikimedia.org/67531 (10tobias.gritschacher) [14:24:09] 3MediaWiki extensions / 3WikidataClient: allow arbitrary data access on Wikidata (parser function) - 10https://bugzilla.wikimedia.org/68029 (10tobias.gritschacher) [14:28:34] (03PS1) 1001tonythomas: Added test to check that the unsubscribe function is working correctly [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153795 [14:29:25] (03PS2) 1001tonythomas: Added test to check that the unsubscribe function is working correctly [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153795 [14:29:30] (03CR) 10jenkins-bot: [V: 04-1] Added test to check that the unsubscribe function is working correctly [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153795 (owner: 1001tonythomas) [14:30:47] (03PS8) 10Zfilipin: The first PdfHandler job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/152246 [14:32:06] (03CR) 10Matthias Mullie: [C: 032] "LGTM." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151248 (owner: 10EBernhardson) [14:32:41] (03Merged) 10jenkins-bot: Hygiene: Dont use magic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151248 (owner: 10EBernhardson) [14:36:00] (03CR) 10Zfilipin: "Anybody knows how to get [1] in wmf/1.24wmf16 (or wmf/1.24wmf17...)? That is causing the jenkins job to fail." [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/152246 (owner: 10Zfilipin) [14:36:30] (03CR) 10Matthias Mullie: Hygiene: Cleanup mismatched function parameters warning (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151245 (owner: 10EBernhardson) [14:37:24] (03PS17) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [14:38:26] (03CR) 10Matthias Mullie: "Why -2; what still needs to be done?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/152935 (owner: 10Bsitu) [14:41:01] (03Abandoned) 10Matthias Mullie: Fix notice for sectionId key not existing [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153604 (owner: 10Matthias Mullie) [14:41:21] (03CR) 10Physikerwelt: Separating MediaWiki specific files from MathJax module (035 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [14:44:38] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c8 (10C. Scott Ananian) I think that extensions and gadgets are probably the "right" way to make sitewide changes. Extensions already have a code review/... [14:45:47] (03PS2) 10Matthias Mullie: Missing sectionId in flow_anon_warning.handlebars [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153006 (owner: 10Bsitu) [14:46:24] 3MediaWiki / 3Internationalization: Make table of contents numbering scheme and style localisable - 10https://bugzilla.wikimedia.org/43494#c2 (10ve4ernik) @Nemo: I don't know about German, but it applies to Bulgarian according to the ortographic dictionary of the Bulgarian language (2002). The dots should al... [14:47:40] (03CR) 10Matthias Mullie: [C: 032] "SG: couldn't find your patch that gets rid of sectionId completely. I'll merge this now, so we no longer have the notice. We can get prope" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153006 (owner: 10Bsitu) [14:47:53] (03PS18) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [14:49:07] (03PS19) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [14:50:15] (03CR) 10Matthias Mullie: [C: 04-1] "Still waiting on https://gerrit.wikimedia.org/r/#/c/151792/ to get merged" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151537 (owner: 10Bsitu) [14:50:44] (03PS20) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [14:51:08] 3MediaWiki extensions / 3Math: Enable Visual Editor for Math by default - 10https://bugzilla.wikimedia.org/69466#c2 (10James Forrester) 5NEW>3RESO/INV Umm. This was done in gerrit I0dd1c85a four months ago… are you running very very old code, or have you got the Maths extension configured in a way that b... [14:53:47] (03PS21) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [14:53:54] (03CR) 10Matthias Mullie: Fixes cancel on reply form, and also standardizes cancel button markup (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150998 (owner: 10SG) [14:54:01] (03CR) 10Matthias Mullie: [C: 032] Fixes cancel on reply form, and also standardizes cancel button markup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150998 (owner: 10SG) [14:54:32] (03Merged) 10jenkins-bot: Fixes cancel on reply form, and also standardizes cancel button markup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150998 (owner: 10SG) [14:55:07] (03PS22) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [14:55:58] (03CR) 10Matthias Mullie: [C: 031] Move jQueryFindWithParent into its own findWithParent plugin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153627 (owner: 10SG) [14:56:13] (03PS2) 10Deepali: Adjust readability options for prev/next links on each page load and added prev/next links on fullscreen mode [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/152740 (https://bugzilla.wikimedia.org/66957) [14:56:15] (03PS5) 10Deepali: Show only subpage title in section list for sections without label [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/140694 (https://bugzilla.wikimedia.org/66788) [14:56:17] (03PS5) 10Deepali: Implement options to format text to improve readability [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/141301 (https://bugzilla.wikimedia.org/65329) [14:56:19] (03PS11) 10Deepali: Improve UX in chapter dropdown menu for books with lots of chapters [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/136537 (https://bugzilla.wikimedia.org/51257) [14:56:21] (03PS3) 10Deepali: Fix some minor bugs with fullscreen view and double column layout [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/141908 [14:56:23] (03PS4) 10Deepali: Hide/Show add buttons for sections along with sections list in JSON editor on clicking the sections Hide/Show button. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/132229 [14:56:25] (03PS8) 10Deepali: Import external metadata from Wikidata [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/149654 (https://bugzilla.wikimedia.org/51971) [14:56:27] (03PS4) 10Deepali: Fix css for dark background option [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/141912 [14:56:29] (03PS4) 10Deepali: Add category:Book:Book_name to all pages when new sections are imported. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/151397 (https://bugzilla.wikimedia.org/66775) [14:56:31] (03PS4) 10Deepali: Changed property name from publication_year to publication_date [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/124289 (https://bugzilla.wikimedia.org/58079) [14:56:33] (03PS2) 10Deepali: Allow mass indentation changes in JSON editor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/153779 (https://bugzilla.wikimedia.org/52417) [14:56:35] (03PS5) 10Deepali: Same readability options on all chapters of the book [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/142555 (https://bugzilla.wikimedia.org/66957) [14:56:37] (03PS2) 10Deepali: Fixed a minor bug with chapterlist dropdown [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/142268 [14:56:39] (03PS5) 10Deepali: Implement full screen reading mode [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/141891 (https://bugzilla.wikimedia.org/65300) [14:56:41] (03PS3) 10Deepali: Fix a minor bug with initialisation of empty chapterlist. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/140071 [14:56:43] (03PS3) 10Deepali: Add variables to enable or disable parts of the extension [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/144266 (https://bugzilla.wikimedia.org/51844) [14:56:45] (03PS4) 10Deepali: Add message documentation for newly added messages [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/144267 (https://bugzilla.wikimedia.org/66879) [14:56:47] (03PS5) 10Deepali: Fix label for publication date in json editor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/120362 (https://bugzilla.wikimedia.org/58080) [14:56:49] (03PS4) 10Deepali: Allow users to add links to the metadata [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/147725 (https://bugzilla.wikimedia.org/52816) [14:56:51] (03PS3) 10Deepali: Import external metadata [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/146054 (https://bugzilla.wikimedia.org/51971) [14:56:53] (03PS2) 10Deepali: Show short title on subpages of a book [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/144356 [14:56:55] (03PS4) 10Deepali: Lager text-area for description field in metadata instead of textbox. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/140686 (https://bugzilla.wikimedia.org/65295) [14:56:58] (03PS23) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [14:56:59] (03CR) 10jenkins-bot: [V: 04-1] Improve UX in chapter dropdown menu for books with lots of chapters [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/136537 (https://bugzilla.wikimedia.org/51257) (owner: 10Deepali) [14:57:01] (03CR) 10jenkins-bot: [V: 04-1] Fix some minor bugs with fullscreen view and double column layout [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/141908 (owner: 10Deepali) [14:57:03] (03CR) 10jenkins-bot: [V: 04-1] Hide/Show add buttons for sections along with sections list in JSON editor on clicking the sections Hide/Show button. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/132229 (owner: 10Deepali) [14:57:05] (03CR) 10jenkins-bot: [V: 04-1] Changed property name from publication_year to publication_date [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/124289 (https://bugzilla.wikimedia.org/58079) (owner: 10Deepali) [14:57:07] (03CR) 10jenkins-bot: [V: 04-1] Allow mass indentation changes in JSON editor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/153779 (https://bugzilla.wikimedia.org/52417) (owner: 10Deepali) [14:57:49] (03PS24) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [14:58:19] Whoa [14:58:24] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c9 (10Brad Jorsch) (In reply to Gilles Dubuc from comment #7) > The fact that people who aren't developers and/or who don't understand what > custom JS th... [14:58:42] (03PS25) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [14:59:24] (03PS26) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [14:59:28] (03CR) 10Pastakhov: [C: 031] Add proper i18n messages, replacing the previous placeholders. [extensions/PhpTagsSMW] - 10https://gerrit.wikimedia.org/r/153787 (owner: 10JoelKP) [15:01:16] (03PS27) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [15:01:38] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c10 (10Helder) Notice that many wikis have migrated code from Common.js to default gadgets (e.g. for modularization, to allow users to disable functionali... [15:02:11] (03PS28) 10All1: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [15:03:34] (03CR) 10All1: "Fixed all comments" (035 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [15:05:08] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c11 (10Helder) (In reply to Brad Jorsch from comment #9) > ... > they're unlikely to accept something that requires they install software > locally, sign... [15:05:16] (03PS2) 10Hashar: Set $wgUploadNavigationUrl to false on parser and unit tests [core] - 10https://gerrit.wikimedia.org/r/152958 (https://bugzilla.wikimedia.org/54576) (owner: 10Umherirrender) [15:05:23] (03CR) 10Hashar: [C: 031] Set $wgUploadNavigationUrl to false on parser and unit tests [core] - 10https://gerrit.wikimedia.org/r/152958 (https://bugzilla.wikimedia.org/54576) (owner: 10Umherirrender) [15:06:54] (03CR) 10SG: "Yeah, sorry for not following up with you on this. My card for that was pushed to next sprint. :(" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153006 (owner: 10Bsitu) [15:10:21] (03CR) 10Hashar: [C: 032] "Thank you." [core] - 10https://gerrit.wikimedia.org/r/152958 (https://bugzilla.wikimedia.org/54576) (owner: 10Umherirrender) [15:12:57] (03PS3) 10Deepali: Allow mass indentation changes in JSON editor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/153779 (https://bugzilla.wikimedia.org/52417) [15:12:59] (03Merged) 10jenkins-bot: Set $wgUploadNavigationUrl to false on parser and unit tests [core] - 10https://gerrit.wikimedia.org/r/152958 (https://bugzilla.wikimedia.org/54576) (owner: 10Umherirrender) [15:16:19] (03PS29) 10Physikerwelt: Separating MediaWiki specific files from MathJax module [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [15:21:29] (03PS4) 10Vikassy: WIP: Added language exception tag to language screenshot job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/153569 [15:21:43] (03PS4) 10Vikassy: WIP: Updated MEDIAWIKI_API_UPLOAD_URL for language screenshot job to production commons(http://commons.wikimedia.org) [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147415 [15:26:10] (03CR) 10Matthias Mullie: [C: 032] Hygiene: Add abstract model and mapper for notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151999 (owner: 10Bsitu) [15:26:33] ori: legoktm MatmaRex skins appear to be broken on beta http://wikidata.beta.wmflabs.org/wiki/Q7627 [15:26:39] missing skins/common [15:26:39] (03Merged) 10jenkins-bot: Hygiene: Add abstract model and mapper for notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151999 (owner: 10Bsitu) [15:27:31] http://en.wikipedia.beta.wmflabs.org/wiki/Special:SpecialPages also [15:28:03] aude: again? [15:28:09] again? [15:28:26] i'm not sure the correct fix [15:28:30] it was broken for an hour or so after the change was merged, then we fixed it [15:28:35] also, works for me [15:28:38] one can make mediawiki/skins a submodule [15:28:45] hmm, or maybe not [15:28:54] but then it wouldn't have skins/common which is still in core [15:29:02] aude: there's a bug for that [15:29:05] https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 [15:29:15] and might be odd to combine submodule + non submodule stuff [15:29:27] (03CR) 10Matthias Mullie: [C: 031] "LGTM. Merge at will, when schema has been updated." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151992 (owner: 10Bsitu) [15:29:50] making skins/ a submodule is not possible/practical until we get rid of skins/common/ [15:30:02] either common goes in skins [15:30:06] mediawiki/skins [15:30:07] but anyway, this breakage shouldn't be happening [15:30:10] or itself is submodule [15:30:17] like mediawiki/skins/Vector [15:30:17] aude: yeah, but that would be terrible [15:30:18] imho [15:30:33] or put elsewhere in core [15:30:36] skins/common/ is very badly named, but the contents generally have no relation to skins [15:30:43] they are core files used for various random things [15:30:47] we need to move them elsewhere [15:30:55] ok w/ me [15:31:03] but doing that might take a while unless we want to anger everyone and their dog [15:31:09] so [15:31:16] beta is clearly broken indeed [15:31:22] it used to work, no idea what broke it [15:31:27] current situation is more annoying [15:31:59] makes people do hacky things to make it work [15:32:10] "current situation" meaning? [15:32:20] skins/ not being an empty directory? [15:32:30] submodule + common directory from core [15:32:40] * aude rm -rf skins [15:32:42] then oops [15:32:50] oh. right :/ [15:33:10] aude: if you could help with https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 , it'd be awesome [15:33:20] if you don't then i'll do that sooner or later, but i can't promise how long it takes [15:33:21] aude: did you mean rm -rf / ? [15:33:31] common directory could go in resources [15:33:31] perhaps [15:33:36] it could [15:33:47] Danny_B: fortunatley not ;) [15:33:55] it's a better idea to split it off more reasonably, right now it contains unrelated things [15:34:03] i have some patches on https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 already that start the work [15:34:23] MatmaRex: sure, though resources can be interim solution [15:34:32] * aude worried about it breaking caching though [15:34:36] yes, we could just move skins/common/ to resources/common/ [15:34:57] there are two big problems with killing skins/common/ in whichever way that i can see [15:35:07] or maybe rm -rf mwiever? ;-))) [15:35:18] plus it breaks third parties, gadgets etc [15:35:20] one is that all kinds of things are referring to these files by path+filename, including extensions and on-wiki things [15:35:22] Fixed beta [15:35:24] btw [15:35:28] hoo: \o/ [15:35:30] second is indeed cache breaking [15:35:34] what evil thing did you do? [15:35:42] hoo@deployment-bastion:/a/common/php-master$ sudo -u mwdeploy git checkout skins/common/* [15:35:45] basically we need to keep it in for 30 days, or face breakage [15:36:03] hoo: ah [15:36:07] (OR we could just keep it on wmf branches, but i bet ops will agree with me that it would suck) [15:36:14] hoo: thanks. why was it gone? [15:36:23] MatmaRex: Someone deleted it... no idea [15:36:26] puppet will probably delete it [15:36:28] heh. okay [15:36:30] * aude hopes i am wrong [15:36:35] why would it? [15:36:38] why would puppet touch that? [15:36:47] beta is "like" production [15:36:54] afaik we don't deploy the mediawiki/skins submodule into there [15:36:59] just the particular skins [15:37:08] no idea the setup for this [15:37:37] aude: we've been pulling Modern and CologneBlue from separate repos for quite a while and it never broke [15:37:46] (03CR) 10Matthias Mullie: [C: 031] "LGTM" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152198 (owner: 10Bsitu) [15:37:48] away for food ;) [15:37:50] now we add MonoBook and Vector and it explodes? [15:38:12] this actually provides some useful information http://en.wikipedia.beta.wmflabs.org/wiki/Special:SpecialPages?useskin=fallback [15:38:45] there's suspiciously many skins there [15:39:36] anyway, let's file a bug if this happens again? [15:39:40] oooo, nimbus, splash? [15:39:41] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c12 (10Jon) I don't think MediaWiki should invent its own code review software. I completely agree with every Gilles Dubuc and C. Scott said above. Code... [15:40:03] (03CR) 10Yurik: [C: 032] Add .gitreview [extensions/Graph] - 10https://gerrit.wikimedia.org/r/153782 (owner: 10QChris) [15:40:06] sounds like someone made mediawiki/skins a submodule [15:40:21] or cloned all the skins [15:40:54] (03CR) 10Yurik: [V: 032] Add .gitreview [extensions/Graph] - 10https://gerrit.wikimedia.org/r/153782 (owner: 10QChris) [15:41:27] aude: https://gerrit.wikimedia.org/r/153368 and https://gerrit.wikimedia.org/r/153370 are waiting for review if you want to help killing skins/common TODAY! :) [15:42:38] these two *should* be mostly safe to merge, but somebody should probably at least grep extensions for these filenames first [15:42:45] (extensions and skins, rather) [15:43:05] might look when i get home [15:43:28] changes look generally fine at a glance [15:44:10] (03CR) 10Matthias Mullie: [C: 031] Auto mark notification as read if it doesn't have target page (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152203 (owner: 10Bsitu) [15:45:13] 3MediaWiki extensions / 3Math: Enable Visual Editor for Math by default - 10https://bugzilla.wikimedia.org/69466#c3 (10physikerwelt) I think my version is not very old... /vagrant/mediawiki/extensions/VisualEditor$ git log -1 commit f5681d490016a8c3213bbdceae859d784dbb5359 Author: Translation updater bot 3MediaWiki / 3Internationalization: Bad language name for 'rup' (Aromanian) - 10https://bugzilla.wikimedia.org/69477 (10daroemenenzullennivergaan) 3UNCO p:3Unprio s:3normal a:3None ''Armãneashce'', the current language name used by Mediawiki doesn't appear to me to have been chosen very wisely. The... [15:51:03] (03PS3) 10JoelKP: Add proper i18n messages, replacing the previous placeholders. [extensions/PhpTagsSMW] - 10https://gerrit.wikimedia.org/r/153787 [15:51:49] (03CR) 10Jdlrobson: [C: 04-1] Move jQueryFindWithParent into its own findWithParent plugin (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153627 (owner: 10SG) [15:52:21] (03PS11) 10Jdlrobson: Link to Watchlist preferences from the watchlist itself [core] - 10https://gerrit.wikimedia.org/r/139872 (https://bugzilla.wikimedia.org/31881) [15:56:41] 3MediaWiki extensions / 3OpenStackManager: Sudo Policies can't be displayed for Tools - 10https://bugzilla.wikimedia.org/68100 (10Andrew Bogott) 5NEW>3RESO/FIX [15:58:29] (03CR) 10Matthias Mullie: Move jQueryFindWithParent into its own findWithParent plugin (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153627 (owner: 10SG) [16:03:04] (03CR) 10Thiemo Mättig (WMDE): "This patch (confirmed by git bisect) broke the Wikibase extension. The console is full of "mw.config is null" TypeErrors from all kinds of" [core] - 10https://gerrit.wikimedia.org/r/152122 (owner: 10Krinkle) [16:04:02] (03CR) 10MarkTraceur: [C: 032] "For the record, Ifcde9bcd0efcf15a3ab692dd2a0a3038559e0254 is the commit in core. I'm happy with this as is. :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153040 (owner: 10Legoktm) [16:04:11] 3MediaWiki extensions / 3WikidataRepo: JS ReferenceErrors due to ResourceLoader changes - 10https://bugzilla.wikimedia.org/69468 (10Krinkle) [16:04:31] (03Merged) 10jenkins-bot: Convert Campaigns to extend JSONContent from core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153040 (owner: 10Legoktm) [16:04:52] (03CR) 10Anomie: [C: 032] Remove old cruft [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/153311 (owner: 10MaxSem) [16:04:59] (03Merged) 10jenkins-bot: Remove old cruft [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/153311 (owner: 10MaxSem) [16:06:42] (03PS6) 10BearND: Add option to skip highlighting if last matched [search/highlighter] - 10https://gerrit.wikimedia.org/r/150013 (owner: 10Manybubbles) [16:06:44] (03CR) 10Anomie: [C: 032] Remove unused class [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/153312 (owner: 10MaxSem) [16:06:46] (03CR) 10MarkTraceur: "The matches that are left just construct and match classes of the form 'mwe-upwiz-status-', where is an error, or a warni" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153717 (owner: 10MarkTraceur) [16:06:50] (03Merged) 10jenkins-bot: Remove unused class [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/153312 (owner: 10MaxSem) [16:06:53] (03CR) 10BearND: [C: 032] Add option to skip highlighting if last matched [search/highlighter] - 10https://gerrit.wikimedia.org/r/150013 (owner: 10Manybubbles) [16:07:21] BearND: Thanks! [16:09:25] (03CR) 10Pastakhov: "JoelKP: It's better :-)" [extensions/PhpTagsSMW] - 10https://gerrit.wikimedia.org/r/153787 (owner: 10JoelKP) [16:09:35] (03CR) 10Anomie: [C: 032] Remove old cruft [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/153310 (owner: 10MaxSem) [16:09:42] (03Merged) 10jenkins-bot: Remove old cruft [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/153310 (owner: 10MaxSem) [16:13:07] (03PS2) 10Manybubbles: Add cirrusdump action for helpful debugging [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/153649 (https://bugzilla.wikimedia.org/69442) [16:13:50] maybe the description for the beta feature "Compact personal bar" should provide a hint that it only works with Vector? [16:14:07] (03CR) 10Manybubbles: "Local regression tests pass. That would have been faster if I hadn't gotten distracted." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/153649 (https://bugzilla.wikimedia.org/69442) (owner: 10Manybubbles) [16:15:41] 3Wikimedia / 3Site requests: Allow "suppressredirect" and "move-subpages" within userspace - 10https://bugzilla.wikimedia.org/69162#c1 (10Mdann52) Just for fun, here's a permalink : https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28proposals%29&oldid=620064554#Allow_.22suppressredirect.22_... [16:16:56] 3MediaWiki extensions / 3WikidataRepo: JS ReferenceErrors due to ResourceLoader changes - 10https://bugzilla.wikimedia.org/69468#c1 (10Krinkle) Referenced from https://gerrit.wikimedia.org/r/#/c/152122/. Can you provide more information about this Wikidata issue? What is the error message, call stack, steps... [16:18:03] (03CR) 10Krinkle: [C: 04-1] "Should probably keep it scoped to #bodyContent and use its class name (mw-body-content) instead of targeting the parent that the visualedi" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/153740 (https://bugzilla.wikimedia.org/38726) (owner: 10Catrope) [16:19:13] * Lcawte kicks phpstorm and points at the variable declaration. [16:20:25] (03PS6) 10Jackmcbarn: Expose cascading protection directly to Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/132730 [16:20:49] anomie: can i bug you to look at ^ that? (it adds a utility function i want to use in one of my other changes) [16:21:07] (and it's pretty old) [16:21:41] 3MediaWiki / 3Language converter: Transliteration of Crimean Wiki - 10https://bugzilla.wikimedia.org/21582#c23 (10Ata) (In reply to Andre Klapper from comment #22) > It looks like the current situation is described in comment 19. Something was not working -- back in 2011. I wonder if smth has changed since... [16:24:48] Krinkle: http://wikidata.beta.wmflabs.org/wiki/Q2558?debug=true [16:24:51] for example [16:26:23] aude: Hm.. I'm not sure this is related. If this code: "if (window.mw) mw.config.set" fails on "set of mw.config is undefined" then the problem is not the if statement. The error would've been there too without the if statement. [16:26:33] I'll look into it [16:26:54] http://pastie.org/9470511 [16:32:47] aude: Yes, the problem is that mw.config is undefined, the startup module is setting mw.config = new mw.Map() though, something is causing that not to run. [16:33:28] (03CR) 10Anomie: "One style nitpick" (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/132730 (owner: 10Jackmcbarn) [16:33:32] jackmcbarn: ^ [16:34:59] (03PS7) 10Jackmcbarn: Expose cascading protection directly to Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/132730 [16:35:24] (03CR) 10Anomie: [C: 032] Expose cascading protection directly to Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/132730 (owner: 10Jackmcbarn) [16:35:49] jackmcbarn: BTW, https://gerrit.wikimedia.org/r/#/c/151645/ could use review [16:38:46] (03CR) 10Jackmcbarn: [C: 032] EditPage::newSectionSummary should return a value in all code paths [core] - 10https://gerrit.wikimedia.org/r/151645 (owner: 10Anomie) [16:39:25] thanks [16:39:29] (03Merged) 10jenkins-bot: Expose cascading protection directly to Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/132730 (owner: 10Jackmcbarn) [16:39:34] np [16:39:51] (03CR) 10Eranroz: [C: 031] EditPage::newSectionSummary should return a value in all code paths [core] - 10https://gerrit.wikimedia.org/r/151645 (owner: 10Anomie) [16:40:58] 3MediaWiki / 3Special pages: Special:Nearby doesn't work on it:voy - 10https://bugzilla.wikimedia.org/69480 (10Andyrom75) 3NEW p:3Unprio s:3normal a:3None Both on desktop (https://it.wikivoyage.org/w/index.php?title=Speciale%3ANelleVicinanze) and mobile (https://it.m.wikivoyage.org/wiki/Speciale:Nell... [16:41:52] (03Merged) 10jenkins-bot: EditPage::newSectionSummary should return a value in all code paths [core] - 10https://gerrit.wikimedia.org/r/151645 (owner: 10Anomie) [16:42:11] 3MediaWiki / 3Special pages: Special:Nearby doesn't work on it:voy - 10https://bugzilla.wikimedia.org/69480 (10Andyrom75) p:5Unprio>3High [16:43:04] (03PS1) 10Dbrant: Next iteration of styling for PageIssues/Disambiguation. [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/153813 [16:44:44] 3MediaWiki / 3Internationalization: Bad language name for 'rup' (Aromanian) - 10https://bugzilla.wikimedia.org/69477#c1 (10Siebrand Mazeland) Please provide authoritative sources when you request changing an autonym. [16:47:31] (03CR) 10Deepali: Show short title on subpages of a book (031 comment) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/144356 (owner: 10Deepali) [16:47:44] Krinkle: shall look at the js issue later when i get home [16:48:00] maybe someone will solve it before then [16:48:34] (03CR) 10Ragesoss: [C: 031 V: 031] "I've tested this locally, and it works as expected both with and without the RecentActivityFeed extension enabled." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/153421 (owner: 10Nischayn22) [16:51:56] gerrit sucks. Why do I have to receive an email whenever someone adds *another* user to review a change where I'm also a reviewer? [16:52:52] (03PS4) 10Deepali: Fix some minor bugs with fullscreen view and double column layout [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/141908 [16:53:41] 3MediaWiki / 3General/Unknown: Edit box disappeared on Polish Wikisource proofread pages - 10https://bugzilla.wikimedia.org/69446#c4 (10Andre Klapper) 5NEW>3RESO/WOR Yeah, I believe that. Just wondering what happened to create the problem and to make it go away again. :-/ In any case, I'm glad to hear i... [16:54:28] 3MediaWiki extensions / 3Scribunto: Attempt to concatenate a nil value when using mw.html:css - 10https://bugzilla.wikimedia.org/69481 (10Erich Gubler) 3UNCO p:3Unprio s:3normal a:3None Mediawiki Version 1.23.2 Scribunto Revision b4b099d Lua 5.1.4 Using mw.html.create(...) to make a mw.html object,... [16:55:43] 3MediaWiki / 3General/Unknown: Edit box disappeared on Polish Wikisource proofread pages - 10https://bugzilla.wikimedia.org/69446#c5 (10Marius Hoch) I've deployed the fix for this yesterday: https://gerrit.wikimedia.org/r/153027 [16:55:56] 3MediaWiki / 3Unit tests: Parser tests fail en masse, falsely, when $wgUploadNavigationUrl is set differently - 10https://bugzilla.wikimedia.org/54576#c4 (10Umherirrender) 5PATC>3RESO/FIX successfully merged [16:56:29] (03PS2) 10Umherirrender: Set page_latest for ChangesListTests [core] - 10https://gerrit.wikimedia.org/r/153051 [17:03:09] (03PS1) 10MarkTraceur: Add start/end and whileActive to the campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153818 (https://bugzilla.wikimedia.org/64685) [17:03:56] 3MediaWiki extensions / 3ProofreadPage: The editing interface of Page: pages with WikiEditor is broken in 1.24wmf16 - 10https://bugzilla.wikimedia.org/69327 (10Helder) [17:03:57] 3MediaWiki / 3General/Unknown: Edit box disappeared on Polish Wikisource proofread pages - 10https://bugzilla.wikimedia.org/69446 (10Helder) [17:04:47] (03PS1) 10Yurik: add-pages command to populate wiki with articles & files [vagrant] - 10https://gerrit.wikimedia.org/r/153819 [17:06:02] (03PS2) 10Yurik: add-pages command to populate wiki with articles & files [vagrant] - 10https://gerrit.wikimedia.org/r/153819 [17:07:31] bd808|BUFFER, around? [17:09:11] (03PS1) 10Jdlrobson: Fix issue with tab visibility [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153821 [17:09:14] (03CR) 10jenkins-bot: [V: 04-1] Fix issue with tab visibility [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153821 (owner: 10Jdlrobson) [17:10:41] 3MediaWiki / 3Search: Special:Search encodes colon from prefixes in navigational links - 10https://bugzilla.wikimedia.org/16418#c2 (10Andre Klapper) 5NEW>3RESO/WOR (In reply to Waldir from comment #1) > This doesn't happen anymore, but I don't know which change did fix this bug. > I'll keep it open and l... [17:11:05] (03CR) 10Helder.wiki: Show short title on subpages of a book (031 comment) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/144356 (owner: 10Deepali) [17:11:23] (03PS2) 10Jdlrobson: Fix issue with tab visibility [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153821 [17:17:29] 3MediaWiki extensions / 3Scribunto: Attempt to concatenate a nil value when using mw.html:css - 10https://bugzilla.wikimedia.org/69481#c1 (10Brad Jorsch) I cannot reproduce this locally. Can you dig into mw.html.lua and try to determine what exactly is going wrong? [17:19:14] andre__: around? [17:19:27] jackmcbarn, kind of [17:19:44] andre__: can you add me to the list of people CC'd for all Scribunto bugs? (or is that something I can do myself?) [17:20:07] jackmcbarn, you cannot yourself yet, let me do that [17:20:08] (03PS1) 10Andrew Bogott: Create a sudo-as sudoer group for new projects. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/153824 [17:20:18] jackmcbarn, done [17:20:23] andre__: thanks [17:20:25] np [17:20:32] \o/ [17:20:44] (03PS4) 10EBernhardson: Hygiene: Cleanup mismatched function parameters warning [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151245 [17:21:26] 3MediaWiki extensions / 3ProofreadPage: Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar - 10https://bugzilla.wikimedia.org/69447#c1 (10Umherirrender) Maybe related to gerrit 141293 because the content model is not wikitext for that page. [17:21:41] 3MediaWiki extensions / 3WikidataRepo: JS ReferenceErrors due to ResourceLoader changes - 10https://bugzilla.wikimedia.org/69468#c2 (10tobias.gritschacher) (In reply to Krinkle from comment #1) > Referenced from https://gerrit.wikimedia.org/r/#/c/152122/. > > Can you provide more information about this Wiki... [17:21:56] 3MediaWiki extensions / 3Translate: Splitting should be done after alignment at Special:PageMigration? - 10https://bugzilla.wikimedia.org/69310#c8 (10Nemo) You should wish for up to date docs at https://www.mediawiki.org/wiki/Extension:Translate/Mass_migration_tools/Design , not for chat logs. :-) It's fine... [17:22:06] (03PS6) 10Yurik: Cleanup - lets make IDEs more useful [core] - 10https://gerrit.wikimedia.org/r/144246 [17:22:12] (03PS1) 10Helder.wiki: Add dependency on module "user.options" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/153826 [17:22:46] (03PS7) 10Yurik: Cleanup - lets make IDEs more useful [core] - 10https://gerrit.wikimedia.org/r/144246 [17:24:54] How can I do phpunit tests in Vagran for the extensions? [17:25:40] I try "vagrant run-tests extensions/PhpTags" but get error message "No MWMultiVersion instance initialized! MWScript.php wrapper not used?" [17:25:41] 3MediaWiki extensions / 3Translate: [PageMigration] On lowercase title, page not recognised - 10https://bugzilla.wikimedia.org/69293 (10Nemo) 5PATC>3RESO/FIX [17:25:59] 3Wikimedia / 3Site requests: Allow "suppressredirect" and "move-subpages" within userspace - 10https://bugzilla.wikimedia.org/69162 (10Steinsplitter) 5UNCO>3NEW [17:30:08] (03CR) 10EBernhardson: [C: 04-1] "I'm not sure its a good idea to subscribe watchers directly from the insert listener, anything using getUsersWatchingBoard should be insi" (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153411 (owner: 10Matthias Mullie) [17:30:38] (03PS3) 10Bartosz Dziewoński: Language: s/error_log/wfDebug/ [core] - 10https://gerrit.wikimedia.org/r/148768 [17:30:55] (03CR) 10Bartosz Dziewoński: "We don't use error_log() directly anywhere in core, instead using various wf functions. Is there a better one to use? If not, can we merge" [core] - 10https://gerrit.wikimedia.org/r/148768 (owner: 10Bartosz Dziewoński) [17:32:11] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c13 (10Eran Roz) I think code review isn't the solution, as it is probable that no one will review the code for small wikis. However it would be great to... [17:33:13] 3MediaWiki extensions / 3Translate: [PageMigration] Tab should go to the next translation textarea - 10https://bugzilla.wikimedia.org/69307 (10Nemo) 5PATC>3RESO/FIX [17:34:26] qgil: are you planning to [WIP] a lot of patches? [17:34:40] Just that, they are not really WIP [17:35:06] awight, sorry, I should have asked (as I just did in a second patch) [17:35:22] qgil: thank you for looking over these for us! [17:35:41] awight, I just want to help removing DonationInterface from the pole position at http://korma.wmflabs.org/browser/gerrit_review_queue.html [17:35:47] qgil: and... sincere apologies for any virtol that may have spilled on u [17:35:53] hehehe we're winning! [17:36:12] no spilling :) [17:36:44] sounds like cheating :P [17:36:49] but nice trick [17:37:15] (03CR) 10Matthias Mullie: Subscribe to board = auto-subscribe to new topics (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153411 (owner: 10Matthias Mullie) [17:40:01] (03PS1) 10Umherirrender: Docs: compatability -> compatibility [core] - 10https://gerrit.wikimedia.org/r/153829 [17:40:11] 3MediaWiki / 3General/Unknown: messages to logged-in user gone missing - 10https://bugzilla.wikimedia.org/69475#c3 (10Chris McMahon) Possibly a by-blow of https://gerrit.wikimedia.org/r/#/c/148144/ according to Matthew Flaschen. Reassigning this bug to Mediawiki not Mobile [17:43:43] (03CR) 10IAlex: [C: 032] Docs: compatability -> compatibility [core] - 10https://gerrit.wikimedia.org/r/153829 (owner: 10Umherirrender) [17:45:10] (03CR) 10Umherirrender: Cleanup - lets make IDEs more useful (035 comments) [core] - 10https://gerrit.wikimedia.org/r/144246 (owner: 10Yurik) [17:45:12] (03CR) 10Nemo bis: "In case it's not clear, I'm not particularly interested in working on this patch. Help appreciated; I'd file a bug but the component is ab" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/77898 (owner: 10Nemo bis) [17:46:14] (03Merged) 10jenkins-bot: Docs: compatability -> compatibility [core] - 10https://gerrit.wikimedia.org/r/153829 (owner: 10Umherirrender) [17:46:20] (03PS8) 10Nemo bis: Cleanup - let's make IDEs more useful [core] - 10https://gerrit.wikimedia.org/r/144246 (owner: 10Yurik) [17:47:56] 3MediaWiki extensions / 3Scribunto: Attempt to concatenate a nil value when using mw.html:css - 10https://bugzilla.wikimedia.org/69481#c2 (10Jackmcbarn) 5UNCO>3NEW I am able to reproduce this. I'm investigating it now. [17:48:18] (03PS1) 10Bartosz Dziewoński: ApiTestCase: Avoid notices about undefined indices [core] - 10https://gerrit.wikimedia.org/r/153831 [17:50:48] (03CR) 10Hoo man: [C: 032] "Makes sense" [core] - 10https://gerrit.wikimedia.org/r/153831 (owner: 10Bartosz Dziewoński) [17:51:42] .-. [17:54:01] (03Merged) 10jenkins-bot: ApiTestCase: Avoid notices about undefined indices [core] - 10https://gerrit.wikimedia.org/r/153831 (owner: 10Bartosz Dziewoński) [17:54:56] 3MediaWiki extensions / 3Scribunto: Attempt to concatenate a nil value when using mw.html:css - 10https://bugzilla.wikimedia.org/69481#c3 (10Jackmcbarn) I tested this on Windows, since it appears that's where the reporter is, since the only place we provide 5.1.4 is Windows. Of particular note is the follow... [17:55:56] anomie: ^ [17:55:57] (03PS1) 10Umherirrender: Change @return to start with type [core] - 10https://gerrit.wikimedia.org/r/153833 [17:57:50] (03CR) 10Jackmcbarn: [C: 04-1] "We use Doxygen, not phpdoc, and Doxygen doesn't support types. Adding Tim since he's the one who originally explained this to me." [core] - 10https://gerrit.wikimedia.org/r/153833 (owner: 10Umherirrender) [17:58:09] jackmcbarn: Hmm. Would be helpful if you can figure out how Windos is screwing things up; my first guess is that it's somehow mangling the pattern when sending the string from Lua to PHP. [17:59:35] (03PS1) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/153836 [18:01:23] awight, well, after all you may lose the pole position thanks to Jenkins' -1s on old changesets. :) Sorry for messing a bit. I hope it ultimately helps, a little bit. [18:02:18] (03PS1) 10Umherirrender: Fixed some docs [core] - 10https://gerrit.wikimedia.org/r/153838 [18:02:49] If php5.4 has a class ( http://us2.php.net/CallbackFilterIterator ) which is so simple there is basically only one implementation, and i implement that based on the docs, how is it licensed? [18:03:11] i'm implementing it as a fallback in 5.3 [18:03:59] manybubbles: Just submitted the change for installing the new search on the wiki at the company I work for. Wonder how long that will take ;-) [18:06:12] (03CR) 10Umherirrender: "Tim words: https://gerrit.wikimedia.org/r/#/c/153212/1/maintenance/findHooks.php" [core] - 10https://gerrit.wikimedia.org/r/153833 (owner: 10Umherirrender) [18:06:22] (03PS1) 10Krinkle: resourceloader: Only conditional-wrap script responses with only=scripts [core] - 10https://gerrit.wikimedia.org/r/153839 [18:06:24] (03PS1) 10Yurik: Added graph extension [tools/release] - 10https://gerrit.wikimedia.org/r/153840 [18:07:10] (03PS2) 10Yurik: Added graph extension [tools/release] - 10https://gerrit.wikimedia.org/r/153840 [18:07:15] (03PS1) 10Andrew Bogott: s/getMemberUIDs/getMemberUids/ [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/153841 [18:07:17] (03PS1) 10Andrew Bogott: Allow service member selection in sudo policy. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/153842 [18:08:38] (03PS2) 10Jforrester: resourceloader: Only conditional-wrap script responses with only=scripts [core] - 10https://gerrit.wikimedia.org/r/153839 (owner: 10Krinkle) [18:10:09] (03CR) 10Yuvipanda: [C: 032] "Zerowiki stuff" [tools/release] - 10https://gerrit.wikimedia.org/r/153840 (owner: 10Yurik) [18:10:15] (03Merged) 10jenkins-bot: Added graph extension [tools/release] - 10https://gerrit.wikimedia.org/r/153840 (owner: 10Yurik) [18:11:34] (03CR) 10Umherirrender: Cleanup - let's make IDEs more useful (031 comment) [core] - 10https://gerrit.wikimedia.org/r/144246 (owner: 10Yurik) [18:11:50] (03CR) 10jenkins-bot: [V: 04-1] resourceloader: Only conditional-wrap script responses with only=scripts [core] - 10https://gerrit.wikimedia.org/r/153839 (owner: 10Krinkle) [18:13:55] (03PS3) 10Krinkle: resourceloader: Only conditional-wrap script responses with only=scripts [core] - 10https://gerrit.wikimedia.org/r/153839 [18:14:21] (03PS4) 10Krinkle: resourceloader: Only conditional-wrap script responses with only=scripts [core] - 10https://gerrit.wikimedia.org/r/153839 [18:17:26] (03CR) 10Legoktm: "Only because PHP segfaults if I use a closure. I can make it a static function on your API module?" [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/153754 (owner: 10Legoktm) [18:18:48] PHP segfaults... heh, I've seen a lot of them happening recently and growing... [18:19:48] (03CR) 10Parent5446: "@Chris - any update? I feel like I should probably file a separate bug for switching to WMF to PBKDF2, but I'm not sure." [core] - 10https://gerrit.wikimedia.org/r/149658 (https://bugzilla.wikimedia.org/28419) (owner: 10Parent5446) [18:20:01] (03CR) 10EBernhardson: Use batch queries for users-watching-title (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/150486 (owner: 10EBernhardson) [18:20:30] (03CR) 10Parent5446: "Or rather csteipp so you'll see this in IRC. :P" [core] - 10https://gerrit.wikimedia.org/r/149658 (https://bugzilla.wikimedia.org/28419) (owner: 10Parent5446) [18:20:50] (03PS20) 10EBernhardson: Use batch queries for users-watching-title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/150486 [18:20:54] (03CR) 10Legoktm: "Why don't we set the current default in the WMF config so we can merge this independent of whatever timeline the WMF has?" [core] - 10https://gerrit.wikimedia.org/r/149658 (https://bugzilla.wikimedia.org/28419) (owner: 10Parent5446) [18:21:12] 3MediaWiki / 3Internationalization: Bad language name for 'rup' (Aromanian) - 10https://bugzilla.wikimedia.org/69477#c2 (10daroemenenzullennivergaan) (In reply to Siebrand Mazeland from comment #1) > Please provide authoritative sources when you request changing an autonym. Dear Siebrand Mazeland, I am citi... [18:21:22] (03CR) 10Parent5446: "^Also a good idea. Lemme see if I remember how to make WMF config changes. :P" [core] - 10https://gerrit.wikimedia.org/r/149658 (https://bugzilla.wikimedia.org/28419) (owner: 10Parent5446) [18:22:39] parent5446|away: operations/mediawiki-config.git [18:22:57] legoktm: yeah, I just need to remember what file they like stuff in. [18:23:04] I think it's InitialiseSettings.php [18:23:06] wmf-config/CommonSettings.php [18:23:08] oh [18:23:11] that'll work too [18:23:22] mhm, I'll check both. I always forget the difference [18:23:50] (03PS21) 10EBernhardson: Use batch queries for users-watching-title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/150486 [18:24:02] (03CR) 10CSteipp: "1.24wmf16 needs to be deployed everywhere first. Let's do this early next week (Aug 18th or 19th)?" [core] - 10https://gerrit.wikimedia.org/r/149658 (https://bugzilla.wikimedia.org/28419) (owner: 10Parent5446) [18:24:09] (03PS1) 10Aaron Schulz: Lower the delay when no jobs are available [services/jobrunner] - 10https://gerrit.wikimedia.org/r/153847 [18:24:47] (03CR) 10Parent5446: "@csteipp, sounds good. Do you think I should submit the patch that legoktm mentions (setting the default in WMF so that core in unblocked)" [core] - 10https://gerrit.wikimedia.org/r/149658 (https://bugzilla.wikimedia.org/28419) (owner: 10Parent5446) [18:24:51] (03PS17) 10Jdlrobson: QA: Browser tests for Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151806 [18:27:57] 3Wikimedia / 3Site requests: Increase $wgAutoConfirmAge and $wgAutoConfirmCount on nowiki - 10https://bugzilla.wikimedia.org/69302 (10Calak) a:3Calak [18:28:07] (03CR) 10JoelKP: "I ran into a curious problem while testing this: The SQI extension is loaded, and: 1. class_exists( '\SQI\SemanticQueryInterface', false )" [extensions/PhpTagsSMW] - 10https://gerrit.wikimedia.org/r/152930 (owner: 10Pastakhov) [18:29:38] anomie: one thing i noticed so far: i was able to create https://en.wikipedia.org/wiki/User:Jackmcbarn/%F4%8F%BF%BF just fine, but i get the bad title error when i try on my Windows wiki [18:30:38] what's your db encoding? [18:30:49] would it matter? [18:31:16] huh: not sure what sqlite does, but i have the exact same setup on linux and it works there, so i doubt that's it [18:31:56] 3Wikimedia / 3Site requests: Change $wgPasswordDefault to PBKDF2 on WMF wikis - 10https://bugzilla.wikimedia.org/68766 (10Tyler Romeo) [18:31:57] 3MediaWiki / 3User login and signup: Replace MD5 password hashing with more secure hash - 10https://bugzilla.wikimedia.org/28419 (10Tyler Romeo) [18:32:37] (03CR) 10CSteipp: "Yeah, if someone wants to deploy a config change to keep the WMF at :B:, that would work too." [core] - 10https://gerrit.wikimedia.org/r/149658 (https://bugzilla.wikimedia.org/28419) (owner: 10Parent5446) [18:35:41] MatmaRex: do you know if there were changes to the variants menu recently in vector? [18:35:55] yes [18:36:00] there were [18:36:01] i made them [18:36:04] what broke? :/ [18:36:23] I'm not sure if it was you :-) [18:36:27] 3MediaWiki / 3JavaScript: Implement mw.Time module for parsing, formatting and "timeago" display of timestamps - 10https://bugzilla.wikimedia.org/45834#c4 (10PRO) Until ca. yesterday this code has worked moment.format('YYYY-M-D') but yet not anymore. [18:36:33] For context: [18:36:34] https://bugzilla.wikimedia.org/show_bug.cgi?id=69445#c13 [18:36:45] reports JS errors from [18:36:46] https://kk.wikipedia.org/wiki/%D0%9C%D0%B5%D0%B4%D0%B8%D0%B0%D0%A3%D0%B8%D0%BA%D0%B8:Common.js [18:36:54] and there is a line [18:36:54] document.getElementById('mw-vector-current-variant').innerHTML = wgULS( "Кирил","Latın","توتە"); [18:37:06] but "document.getElementById('mw-vector-current-variant')" seems to be null... [18:37:13] oh [18:37:16] I was wondering if maybe this existed but was removed recently [18:37:22] yeah, that's gone now [18:37:27] or if they just forgot to wait for $.ready [18:38:06] helderwiki: removed in https://gerrit.wikimedia.org/r/#/c/138368/ [18:38:48] (03PS1) 10Jdlrobson: Add missing star images to fixed header beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/153853 [18:38:50] (03PS1) 10Jdlrobson: Enable watch star JavaScript action [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/153854 [18:39:13] 3MediaWiki / 3Parser: Image link parameter not matching URLs correctly - 10https://bugzilla.wikimedia.org/69486 (10Zhen Lin) 3NEW p:3Unprio s:3normal a:3None The wikicode [[File:Test.jpg|link=Wikinews:Main Page]] renders as an image with the tooltip "link=Wikinews:Main Page" instead of as a image lin... [18:39:20] (03PS1) 10Jdlrobson: Stop using DOM as an api. Start a Skin api for the watchstar [core] - 10https://gerrit.wikimedia.org/r/153855 [18:39:22] (03PS22) 10EBernhardson: Use batch queries for users-watching-title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/150486 [18:39:25] (03PS1) 10Yurik: Added Graph extension [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153856 [18:39:35] YuviPanda|groggy, ^ [18:39:40] (03PS1) 10Manybubbles: Docs updates [search/highlighter] - 10https://gerrit.wikimedia.org/r/153857 [18:40:09] yurikR: can't merge, no rights [18:40:18] (03CR) 10Jdlrobson: "We've talked about this lots in the past... the watch star seems like low hanging fruit and it would be good to use this to kick this off." [core] - 10https://gerrit.wikimedia.org/r/153855 (owner: 10Jdlrobson) [18:40:32] FlorianSW: hey [18:40:37] (03PS2) 10Manybubbles: Docs updates [search/highlighter] - 10https://gerrit.wikimedia.org/r/153857 [18:40:39] i'm free what's up [18:40:53] Reedy, could you +2 pls https://gerrit.wikimedia.org/r/#/c/153856/ [18:40:57] deploying it now [18:41:05] MatmaRex: is that change live? [18:41:12] jdlrobson: wikimedia-dev or wikimedia-mobile? :) [18:41:12] I see another one on vector skin here [18:41:12] https://gerrit.wikimedia.org/r/#/q/I2817c6e9eb52ffc785a04bb9d23b0802a553fd45,n,z [18:41:19] it's mobile related ;) [18:41:33] (03PS1) 10Legoktm: Use SkinFactory tor register skin, and Config instead of globals [skins/Vector] - 10https://gerrit.wikimedia.org/r/153859 [18:42:06] YuviPanda|groggy, you don't have +2 on core? [18:42:06] Uh [18:42:09] Who's reviewed that? [18:42:12] yurikR: the extension already went through security review and stuff? [18:42:15] ^ [18:42:20] greg-g: ^ Graph Extension? [18:42:36] (03CR) 10jenkins-bot: [V: 04-1] Stop using DOM as an api. Start a Skin api for the watchstar [core] - 10https://gerrit.wikimedia.org/r/153855 (owner: 10Jdlrobson) [18:42:43] it will not be pushed into production yet - only for use behind closed doors of zerowiki [18:42:56] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c14 (10Eran Roz) Created attachment 16185 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16185&action=edit Example for errors across wikis Maybe... [18:42:57] helderwiki: yes [18:43:11] Reedy: what yurikR said. [18:43:18] (03PS2) 10Legoktm: Use SkinFactory to register skin, and Config instead of globals [skins/Vector] - 10https://gerrit.wikimedia.org/r/153859 [18:43:45] Reedy, i don't plan to enable it on any publicly accessible wikies yet [18:43:55] only the private zerowiki [18:44:14] ...all the more reason to have a security review??? [18:45:00] (03PS2) 10Jdlrobson: Stop using DOM as an api. Start a Skin api for the watchstar [core] - 10https://gerrit.wikimedia.org/r/153855 [18:45:16] Yeah.. yurikR, I didn't know what your timeline was for that. Can I have time to review it before we deploy it? [18:45:22] (03CR) 10Aaron Schulz: [C: 032] Fixed some docs [core] - 10https://gerrit.wikimedia.org/r/153838 (owner: 10Umherirrender) [18:45:30] (03CR) 10Bartosz Dziewoński: [C: 04-2] "skins/common/? Aw hell no. We're in the progress of killing that. Make this a sane module please. I think we discussed some options for na" [core] - 10https://gerrit.wikimedia.org/r/153855 (owner: 10Jdlrobson) [18:45:49] (03CR) 10Bartosz Dziewoński: "(The killing is https://bugzilla.wikimedia.org/show_bug.cgi?id=69277 )" [core] - 10https://gerrit.wikimedia.org/r/153855 (owner: 10Jdlrobson) [18:46:06] That's slightly strange. I don't even have the extension in my local checkout yet [18:46:09] legoktm, csteipp, absolutely no rush. My initial plan was to have it run on betalabs and possibly zerowiki before deploying to pub [18:46:13] 3Wikimedia / 3Site requests: Change user groups rights on ckb.wikipedia - 10https://bugzilla.wikimedia.org/69394 (10Calak) a:3Calak [18:46:34] Reedy: it was renamed yesterday, you probably have 'Limn' [18:46:40] (03CR) 10Jdlrobson: "Bartosz Dziewoński I don't care where the file lives I'm more interested in your thoughts on the approach here..." [core] - 10https://gerrit.wikimedia.org/r/153855 (owner: 10Jdlrobson) [18:47:01] yurikR: Cool. I'll do that before I do the review for wikidata [18:47:06] (03CR) 10Jdlrobson: "e.g. review the code not the filename :P" [core] - 10https://gerrit.wikimedia.org/r/153855 (owner: 10Jdlrobson) [18:47:16] csteipp, thx, let me know when i can push it out [18:47:35] (03CR) 10Legoktm: [C: 031] "https://gerrit.wikimedia.org/r/#/c/153859/ converts Vector to use SkinFactory so it can inject Vector's Config object." [core] - 10https://gerrit.wikimedia.org/r/153540 (owner: 10Legoktm) [18:48:19] (03PS3) 10Jdlrobson: WIP: Stop using DOM as an api. Start a Skin api for the watchstar [core] - 10https://gerrit.wikimedia.org/r/153855 [18:48:47] (03Merged) 10jenkins-bot: Fixed some docs [core] - 10https://gerrit.wikimedia.org/r/153838 (owner: 10Umherirrender) [18:49:13] (03CR) 10Legoktm: [C: 032] SkinFactory: Improve documentation and comments [core] - 10https://gerrit.wikimedia.org/r/153781 (owner: 10Bartosz Dziewoński) [18:49:35] (03CR) 10Bartosz Dziewoński: [C: 032] SkinFactory: register skins in Setup.php [core] - 10https://gerrit.wikimedia.org/r/153540 (owner: 10Legoktm) [18:49:50] (03PS1) 10Dduvall: Tolerate missing Gemfile for browser-test dependencies [vagrant] - 10https://gerrit.wikimedia.org/r/153861 [18:52:41] 3Wikimedia / 3Git/Gerrit: Free-form tagging in gerrit - 10https://bugzilla.wikimedia.org/35534#c18 (10Chad H.) (In reply to Quim Gil from comment #17) > Is it safe to assume that no further development will be put into our Gerrit > instance? This request seems to be fulfilled by Phabricator + Differential >... [18:53:22] (03PS1) 10Yurik: Added Graph ext [extensions] - 10https://gerrit.wikimedia.org/r/153862 [18:53:58] YuviPanda|groggy, Reedy, this should be safe, right? ^ [18:54:03] (03PS2) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/153836 [18:54:05] (03CR) 10jenkins-bot: [V: 04-1] WIP: Stop using DOM as an api. Start a Skin api for the watchstar [core] - 10https://gerrit.wikimedia.org/r/153855 (owner: 10Jdlrobson) [18:54:26] (03CR) 10Bartosz Dziewoński: [C: 04-1] "My immediate thought was that any approach that uses skins/common/ is unworkable and not worth even looking at. On second thought this loo" [core] - 10https://gerrit.wikimedia.org/r/153855 (owner: 10Jdlrobson) [18:56:56] (03Merged) 10jenkins-bot: SkinFactory: register skins in Setup.php [core] - 10https://gerrit.wikimedia.org/r/153540 (owner: 10Legoktm) [18:58:10] (03Merged) 10jenkins-bot: SkinFactory: Improve documentation and comments [core] - 10https://gerrit.wikimedia.org/r/153781 (owner: 10Bartosz Dziewoński) [18:59:23] (03CR) 10JoelKP: [C: 032] "@Pastakhov: Yes, and I know that this will conflict with the other change. But in testing that change, I encountered a problem (now descri" [extensions/PhpTagsSMW] - 10https://gerrit.wikimedia.org/r/153787 (owner: 10JoelKP) [19:00:12] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c15 (10Antoine "hashar" Musso) Eran Roz: please fill bug report for all such issues. This way they can be triaged / assigned to the proper persons and wil... [19:05:56] 3MediaWiki extensions / 3Scribunto: Attempt to concatenate a nil value when using mw.html:css - 10https://bugzilla.wikimedia.org/69481#c4 (10Jackmcbarn) After further investigation, the problem seems to lie in the patternToRegex function. A simple test: The pattern "[ [19:06:07] (03PS1) 10Manybubbles: Create endpoint to dump cirrus configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/153868 (https://bugzilla.wikimedia.org/69442) [19:06:57] 3MediaWiki extensions / 3Scribunto: Attempt to concatenate a nil value when using mw.html:css - 10https://bugzilla.wikimedia.org/69481#c5 (10Jackmcbarn) (and it seems Bugzilla doesn't like that character either. Where I say U+10FFFF below, I really mean that literal character.) After further investigation,... [19:07:52] (03Merged) 10jenkins-bot: Add proper i18n messages, replacing the previous placeholders. [extensions/PhpTagsSMW] - 10https://gerrit.wikimedia.org/r/153787 (owner: 10JoelKP) [19:08:41] (03CR) 10Manybubbles: "Not sure if this is too dangerous because it iterates over all the globals, maybe returning them to the user or if it is enough that it on" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/153868 (https://bugzilla.wikimedia.org/69442) (owner: 10Manybubbles) [19:08:44] (03PS2) 10Yurik: Added Graph extension [extensions] - 10https://gerrit.wikimedia.org/r/153862 [19:11:41] (03CR) 10Daniel Friesen: "The file should live somewhere in `resources/src/mediawiki.*`." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153855 (owner: 10Jdlrobson) [19:14:26] 3MediaWiki / 3JavaScript: Implement mw.Time module for parsing, formatting and "timeago" display of timestamps - 10https://bugzilla.wikimedia.org/45834#c5 (10PRO) Ok it works if the MultimediaViewer is loaded. Could be there a documentation how to load this library / extension explicit!? [19:15:04] (03CR) 10Daniel Friesen: "I wish I noticed this before it was merged." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153540 (owner: 10Legoktm) [19:16:04] (03CR) 10Legoktm: SkinFactory: register skins in Setup.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153540 (owner: 10Legoktm) [19:16:41] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Index not updated automatically - 10https://bugzilla.wikimedia.org/69387#c2 (10Nik Everett) Are other jobs running? Like, does runJobs.php pick up lots of other, non-cirrus stuff? [19:22:06] (03PS1) 1001tonythomas: Improved the unsubscribe user method used by BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153871 (https://bugzilla.wikimedia.org/69099) [19:22:29] 3MediaWiki extensions / 3CirrusSearch: Expose mwgrep functionality on-wiki - 10https://bugzilla.wikimedia.org/69489 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3enhanc a:3None mwgrep is a fantastic tool, but it's only available to shell users. There have been some discussions on IRC about making it av... [19:24:06] (03CR) 10Hashar: "Bah I commented about this patch earlier but apparently closed the window :-D" [core] - 10https://gerrit.wikimedia.org/r/148768 (owner: 10Bartosz Dziewoński) [19:24:45] (03CR) 10Daniel Friesen: SkinFactory: register skins in Setup.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153540 (owner: 10Legoktm) [19:26:49] (03PS1) 10Umherirrender: Use /** for doc comments [core] - 10https://gerrit.wikimedia.org/r/153872 [19:29:09] (03PS4) 10Bartosz Dziewoński: Language: s/error_log/wfWarn/ [core] - 10https://gerrit.wikimedia.org/r/148768 [19:29:20] (03CR) 10Bartosz Dziewoński: "Done." [core] - 10https://gerrit.wikimedia.org/r/148768 (owner: 10Bartosz Dziewoński) [19:31:09] (03CR) 10Parent5446: [C: 032] Use /** for doc comments [core] - 10https://gerrit.wikimedia.org/r/153872 (owner: 10Umherirrender) [19:31:15] (03PS2) 10Jackmcbarn: Use /** for doc comments [core] - 10https://gerrit.wikimedia.org/r/153872 (owner: 10Umherirrender) [19:31:29] bah, midair conflict [19:32:08] (03CR) 10Jackmcbarn: [C: 032] Use /** for doc comments [core] - 10https://gerrit.wikimedia.org/r/153872 (owner: 10Umherirrender) [19:32:53] (03PS9) 10Yurik: Cleanup - let's make IDEs more useful [core] - 10https://gerrit.wikimedia.org/r/144246 [19:34:35] (03PS10) 10Yurik: Cleanup - let's make IDEs more useful [core] - 10https://gerrit.wikimedia.org/r/144246 [19:36:42] 3MediaWiki extensions / 3CirrusSearch: Expose mwgrep functionality on-wiki - 10https://bugzilla.wikimedia.org/69489#c1 (10Nik Everett) We could try it. We'd have to make sure the pool counter is pretty tight for it like we do single wiki regexps and we might have to fiddle with timeouts. Otherwise we shoul... [19:36:44] 3MediaWiki extensions / 3VectorBeta: VectorBeta requires ext.eventLogging to run - 10https://bugzilla.wikimedia.org/69490 (10Jamison Lofthouse) 3UNCO p:3Unprio s:3major a:3None When VectorBeta's compact personal toolbar is enabled it requires EventLogging to function (hard dependency). This causes Ja... [19:36:48] (03PS1) 10Daniel Friesen: Fix documentation. [core] - 10https://gerrit.wikimedia.org/r/153874 [19:37:25] (03Merged) 10jenkins-bot: Use /** for doc comments [core] - 10https://gerrit.wikimedia.org/r/153872 (owner: 10Umherirrender) [19:37:33] (03CR) 10CSteipp: "I'd much rather see a whitelist of approved config variables that can be output, in case someone adds "wgCirrusSearchSecretKey" in the fut" (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/153868 (https://bugzilla.wikimedia.org/69442) (owner: 10Manybubbles) [19:39:23] (03CR) 10Legoktm: [C: 04-1] Added test to check that the unsubscribe function is working correctly (032 comments) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153795 (owner: 1001tonythomas) [19:40:24] (03PS2) 10Legoktm: Create endpoint to dump cirrus configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/153868 (https://bugzilla.wikimedia.org/69442) (owner: 10Manybubbles) [19:40:39] legoktm: construct a new user object ? [19:40:48] User::newFromId( $id ); [19:40:55] that way it's not using the same member variables [19:40:57] 3MediaWiki extensions / 3VectorBeta: VectorBeta requires ext.eventLogging to run - 10https://bugzilla.wikimedia.org/69490#c1 (10Jamison Lofthouse) On branch wmf/1.24wmf16 [19:41:17] legoktm: ok. let me try that out [19:41:24] (03CR) 10Manybubbles: [C: 04-1] "I agree with Csteipp. I'll switch the logic to a whitelist." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/153868 (https://bugzilla.wikimedia.org/69442) (owner: 10Manybubbles) [19:41:44] (03CR) 10Legoktm: [C: 04-1] Create endpoint to dump cirrus configuration (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/153868 (https://bugzilla.wikimedia.org/69442) (owner: 10Manybubbles) [19:42:36] (03CR) 10Parent5446: "Some questions" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/144246 (owner: 10Yurik) [19:43:38] legoktm: and this one looks good ?https://gerrit.wikimedia.org/r/#/c/153871/ [19:44:16] (03CR) 10Parent5446: [C: 031] Fix documentation. [core] - 10https://gerrit.wikimedia.org/r/153874 (owner: 10Daniel Friesen) [19:44:40] tonythomas: yes. Do you want to just add the test in the same commit? [19:44:51] I don't see any reason to have multiple patches for htis [19:45:07] legoktm: but still, the test seem not to pass for some reason [19:45:25] strange! [19:46:28] (03CR) 10Tpt: [C: 032] "Thanks a lot for this change!" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/153826 (owner: 10Helder.wiki) [19:46:38] (03CR) 10Legoktm: "The test should just call the function unSubscribeUser and check that the user is confirmed beforehand, and then not confirmed afterwards." [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153795 (owner: 1001tonythomas) [19:48:14] 3MediaWiki extensions / 3CirrusSearch: The search backend returned an error - 10https://bugzilla.wikimedia.org/69491 (10bennylin) 3NEW p:3Unprio s:3normal a:3None I did a search on string "on the news" on en.wp and it returned "An error has occurred while searching: The search backend returned an err... [19:48:56] 3MediaWiki extensions / 3ProofreadPage: Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar - 10https://bugzilla.wikimedia.org/69447#c2 (10Tpt) The root cause of the bug is that now MediaWiki core only displays the old edit toolbar in pages with CONTENT_MODEL_WI... [19:48:57] (03PS1) 10Umherirrender: Correct variable names in @param to match method declarations [core] - 10https://gerrit.wikimedia.org/r/153877 [19:48:59] (03CR) 10Jdlrobson: "Yeh i knocked this up quickly as I felt code was the best way to discuss such a move. Hence the WIP tag." [core] - 10https://gerrit.wikimedia.org/r/153855 (owner: 10Jdlrobson) [19:49:27] (03PS1) 10Manybubbles: Add parameter to search page to dump the query [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/153879 (https://bugzilla.wikimedia.org/69442) [19:49:40] (03Merged) 10jenkins-bot: Add dependency on module "user.options" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/153826 (owner: 10Helder.wiki) [19:50:28] (03PS3) 1001tonythomas: Added test to check that the unsubscribe function is working correctly [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153795 [19:50:35] (03CR) 10jenkins-bot: [V: 04-1] Added test to check that the unsubscribe function is working correctly [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153795 (owner: 1001tonythomas) [19:52:00] MatmaRex: do you know the current path for this image? [19:52:00] https://kk.wikipedia.org/w/index.php?diff=2163458 [19:52:11] 3MediaWiki extensions / 3ProofreadPage: Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar - 10https://bugzilla.wikimedia.org/69447#c3 (10Derk-Jan Hartman) eh those pages are not wikitext ? what are they then ? [19:52:39] helderwiki: what is that code for? [19:52:45] no idea [19:52:57] but it is loading an inexistent image [19:53:01] (03CR) 10Isarra: [C: 031] "Looks sensible." [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/153777 (owner: 10Arlolra) [19:53:48] if it's been broken for a long time, i would expect the users to be surprised if we suddenly "fixed" it and something changes [19:53:56] 3MediaWiki extensions / 3CirrusSearch: Automatic stopwords for the 200+ languages without their own analyzer available - 10https://bugzilla.wikimedia.org/54875 (10bennylin) [19:53:57] 3MediaWiki extensions / 3CirrusSearch: intitle search doesn't work - 10https://bugzilla.wikimedia.org/66969 (10bennylin) [19:54:12] indeed [19:54:20] was the image replaced with CSS? [19:54:29] (03PS4) 1001tonythomas: Added test to check that the unsubscribe function is working correctly [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153795 [19:54:56] i wouldn't touch that unless you know what this was for when it was added [19:54:59] (03CR) 10Yurik: "searched using IDE and replied. good catch re empty line." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/144246 (owner: 10Yurik) [19:55:10] and these guys don't seem to like commenting their code or summarizing their edits [19:55:23] (03CR) 10CSteipp: [C: 031] Improved the unsubscribe user method used by BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153871 (https://bugzilla.wikimedia.org/69099) (owner: 1001tonythomas) [19:55:43] (03PS11) 10Yurik: Cleanup - let's make IDEs more useful [core] - 10https://gerrit.wikimedia.org/r/144246 [19:55:53] =/ [19:57:11] 3MediaWiki extensions / 3CirrusSearch: Expose mwgrep functionality on-wiki - 10https://bugzilla.wikimedia.org/69489#c2 (10Chad H.) IMHO not going to happen because of the performance considerations. I'd much rather see us complete labs replication where we'd be able to expose mwgrep + any other crazy tool yo... [19:57:56] 3MediaWiki extensions / 3CirrusSearch: The search backend returned an error - 10https://bugzilla.wikimedia.org/69491#c1 (10Chad H.) Doesn't sound like a Cirrus bug. Are you using it in your beta features? If not, it's an lsearchd bug (of which there's many dupes) and is a WONTFIX. [19:58:16] (03PS1) 10Bartosz Dziewoński: Update release notes and documentation about skins [core] - 10https://gerrit.wikimedia.org/r/153881 (https://bugzilla.wikimedia.org/68402) [19:59:46] ^d: aren't you supposed to be on vacation? [20:01:13] (03CR) 10Bsitu: [C: 032] Fix issue with tab visibility [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153821 (owner: 10Jdlrobson) [20:01:41] (03Merged) 10jenkins-bot: Fix issue with tab visibility [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153821 (owner: 10Jdlrobson) [20:02:58] 3MediaWiki extensions / 3AbuseFilter: Edits which hit the condition limit should be tagged - 10https://bugzilla.wikimedia.org/69492 (10od_mishehu) 3NEW p:3Unprio s:3enhanc a:3None The Ab use Filter occasionally stops handling specific edits because it reached the condition limit. It should be possibl... [20:03:12] (03PS12) 10Yurik: Cleanup - let's make IDEs more useful [core] - 10https://gerrit.wikimedia.org/r/144246 [20:03:45] (03CR) 10Yurik: Cleanup - let's make IDEs more useful (031 comment) [core] - 10https://gerrit.wikimedia.org/r/144246 (owner: 10Yurik) [20:03:47] (03CR) 10Parent5446: [C: 032] Cleanup - let's make IDEs more useful [core] - 10https://gerrit.wikimedia.org/r/144246 (owner: 10Yurik) [20:05:43] (03CR) 10Spage: [C: 04-1] "ENV["BROWSER"] can fail, patch coming. With that fixed, only the "another user writes on my talk page" fails on ee-flow." (035 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151806 (owner: 10Jdlrobson) [20:06:11] 3MediaWiki / 3JavaScript: Implement mw.Time module for parsing, formatting and "timeago" display of timestamps - 10https://bugzilla.wikimedia.org/45834#c6 (10Helder) Have you added the module "moment" as a dependency to your script/gadget? That seems to be the ResourceLoader module associated to the files wh... [20:07:17] (03PS3) 10Manybubbles: Create endpoint to dump cirrus configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/153868 (https://bugzilla.wikimedia.org/69442) [20:07:41] 3MediaWiki extensions / 3ProofreadPage: Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar - 10https://bugzilla.wikimedia.org/69447#c4 (10Tpt) They have their own content model that is mostly the composition of 3 Wikitext areas (header, body and footer) with so... [20:08:03] (03CR) 10Helder.wiki: ":-)" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/153826 (owner: 10Helder.wiki) [20:08:39] (03CR) 10Manybubbles: "Added whitelist, removed deprecated getVersion method, removed unused config parameter, and renamed confusingly named parameter." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/153868 (https://bugzilla.wikimedia.org/69442) (owner: 10Manybubbles) [20:08:46] (03CR) 10Parent5446: [C: 032] Correct variable names in @param to match method declarations [core] - 10https://gerrit.wikimedia.org/r/153877 (owner: 10Umherirrender) [20:08:55] (03Merged) 10jenkins-bot: Cleanup - let's make IDEs more useful [core] - 10https://gerrit.wikimedia.org/r/144246 (owner: 10Yurik) [20:09:30] (03PS2) 1001tonythomas: Improved the unsubscribe user method used by BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153871 (https://bugzilla.wikimedia.org/69099) [20:09:44] (03PS18) 10Spage: QA: Browser tests for Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151806 (owner: 10Jdlrobson) [20:09:56] 3MediaWiki extensions / 3ProofreadPage: The editing interface of Page: pages with WikiEditor is broken in 1.24wmf16 - 10https://bugzilla.wikimedia.org/69327#c3 (10Tpt) 5PATC>3RESO/FIX The change have been deployed and it works again now. [20:10:48] (03PS2) 10Bsitu: Add method for fetching unread notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153734 [20:12:10] (03CR) 10Ori.livneh: [C: 032] Lower the delay when no jobs are available [services/jobrunner] - 10https://gerrit.wikimedia.org/r/153847 (owner: 10Aaron Schulz) [20:12:16] AaronS: will you deploy? [20:12:40] ori: it was mostly for labs, so probably not ;) [20:12:52] (03PS14) 10EBernhardson: Move watch star for boards next to the header. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149210 (owner: 10Werdna) [20:13:06] (03Merged) 10jenkins-bot: Lower the delay when no jobs are available [services/jobrunner] - 10https://gerrit.wikimedia.org/r/153847 (owner: 10Aaron Schulz) [20:13:08] (03CR) 10Jdlrobson: [C: 031] Use batch queries for users-watching-title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/150486 (owner: 10EBernhardson) [20:13:11] 3MediaWiki extensions / 3CirrusSearch: intitle search doesn't work - 10https://bugzilla.wikimedia.org/66969#c5 (10bennylin) Probably related * [[bugzilla:54875]] Automatic stopwords for the 200+ languages without their own analyzer available * [[bugzilla:60362]] CirrusSearch: Stopwords are not optional a... [20:13:27] 3Wikimedia / 3Extension setup: Security review BounceHandler extension for deployement - 10https://bugzilla.wikimedia.org/69099#c13 (10Chris Steipp) Once https://gerrit.wikimedia.org/r/#/c/153871 is merged, we can close this [20:13:39] (03Merged) 10jenkins-bot: Correct variable names in @param to match method declarations [core] - 10https://gerrit.wikimedia.org/r/153877 (owner: 10Umherirrender) [20:14:22] legoktm: time to take another look at https://gerrit.wikimedia.org/r/#/c/153871 ? [20:14:43] looks like last one in https://bugzilla.wikimedia.org/show_bug.cgi?id=69099 :) [20:14:58] (03PS3) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/153836 [20:17:04] (03CR) 10Jdlrobson: [C: 032] Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/153836 (owner: 10Umherirrender) [20:17:06] (03PS19) 10Spage: QA: Browser tests for Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151806 (owner: 10Jdlrobson) [20:17:52] (03CR) 10Jdlrobson: [C: 032] Update release notes and documentation about skins [core] - 10https://gerrit.wikimedia.org/r/153881 (https://bugzilla.wikimedia.org/68402) (owner: 10Bartosz Dziewoński) [20:18:31] (03CR) 10Jdlrobson: [C: 032] Fix documentation. [core] - 10https://gerrit.wikimedia.org/r/153874 (owner: 10Daniel Friesen) [20:18:57] (03CR) 10Legoktm: "Minor" (031 comment) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153871 (https://bugzilla.wikimedia.org/69099) (owner: 1001tonythomas) [20:18:59] (03CR) 10Spage: [C: 032] "PS18 fixes get_session_username() and adjusts @browser and @host annotations. Looks good on ee-flow." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151806 (owner: 10Jdlrobson) [20:19:11] 3MediaWiki / 3Skin and page rendering: Move Vector and MonoBook to separate repositories - 10https://bugzilla.wikimedia.org/68402#c5 (10Bartosz Dziewoński) [[MediaWiki 1.24#Skins no longer loaded after upgrade?]] [20:19:27] 3MediaWiki / 3Skin and page rendering: Move Vector and MonoBook to separate repositories - 10https://bugzilla.wikimedia.org/68402 (10Bartosz Dziewoński) 5PATC>3RESO/FIX [20:19:43] 3MediaWiki / 3Skin and page rendering: Add README to skins folder - 10https://bugzilla.wikimedia.org/69372 (10Bartosz Dziewoński) 5PATC>3RESO/FIX a:3Bartosz Dziewoński [20:19:56] 3MediaWiki / 3Skin and page rendering: Move Vector and MonoBook to separate repositories - 10https://bugzilla.wikimedia.org/68402#c6 (10Bartosz Dziewoński) [[mw:MediaWiki 1.24#Skins no longer loaded after upgrade?]] [20:20:20] (03PS3) 10Jdlrobson: SkinFallbackTemplate: Use SkinFactory instead of $wgValidSkinNames [core] - 10https://gerrit.wikimedia.org/r/153542 (owner: 10Legoktm) [20:20:26] (03CR) 10CSteipp: "Looks mostly good." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/153868 (https://bugzilla.wikimedia.org/69442) (owner: 10Manybubbles) [20:20:28] (03CR) 10BearND: [C: 032] Docs updates [search/highlighter] - 10https://gerrit.wikimedia.org/r/153857 (owner: 10Manybubbles) [20:20:41] (03CR) 10Jdlrobson: [C: 032] SkinFallbackTemplate: Use SkinFactory instead of $wgValidSkinNames [core] - 10https://gerrit.wikimedia.org/r/153542 (owner: 10Legoktm) [20:20:52] (03CR) 10EBernhardson: "It seems to me that the event is just being fired against the wrong title?" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [20:21:08] (03PS2) 10Jdlrobson: includes/actions/: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/153748 (owner: 10Legoktm) [20:22:17] (03PS3) 1001tonythomas: Improved the unsubscribe user method used by BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153871 (https://bugzilla.wikimedia.org/69099) [20:22:25] (03Merged) 10jenkins-bot: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/153836 (owner: 10Umherirrender) [20:24:21] (03Merged) 10jenkins-bot: Update release notes and documentation about skins [core] - 10https://gerrit.wikimedia.org/r/153881 (https://bugzilla.wikimedia.org/68402) (owner: 10Bartosz Dziewoński) [20:24:37] jdlrobson: ty :) [20:25:05] (03PS1) 10Jdlrobson: Create chevron using pseudo elements [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153885 [20:25:08] (03PS1) 10Jdlrobson: Create notification overlay in the body [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153886 [20:26:00] (03CR) 10Bartosz Dziewoński: [C: 031] Use SkinFactory to register skin, and Config instead of globals [skins/Vector] - 10https://gerrit.wikimedia.org/r/153859 (owner: 10Legoktm) [20:26:11] 3Wikimedia / 3OTRS: Line breaks missing after salutations and before signature lines - 10https://bugzilla.wikimedia.org/55681#c5 (10Ryan (Rjd0060)) Any update? Can we get the fix applied on our install? [20:27:03] (03Merged) 10jenkins-bot: Fix documentation. [core] - 10https://gerrit.wikimedia.org/r/153874 (owner: 10Daniel Friesen) [20:27:54] (03CR) 10EBernhardson: New topic notifications for watchers of a board. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [20:27:56] 3MediaWiki / 3Parser: Add a {{#link:}} parser function for creating arbitrary links in i18n messages only - 10https://bugzilla.wikimedia.org/66746 (10Bartosz Dziewoński) [20:29:14] (03CR) 1001tonythomas: "recheck" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153871 (https://bugzilla.wikimedia.org/69099) (owner: 1001tonythomas) [20:29:59] Hi, I'm facing the problem that HTML Tags are stripped from extension output (reported as Bug 66516) I have not made any progress to find out the reason for this problem in the last two month. Can someone give me some advice how to narrow down the problem? [20:30:48] (03CR) 10Jdlrobson: [C: 04-1] "Some commit message nitpicks :)" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/153748 (owner: 10Legoktm) [20:30:50] physikerwelt: maybe caused by tidy? [20:31:33] (03CR) 10Legoktm: [C: 032] Improved the unsubscribe user method used by BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153871 (https://bugzilla.wikimedia.org/69099) (owner: 1001tonythomas) [20:31:36] MatmaRex: are you referring to https://www.mediawiki.org/wiki/Manual:$wgUseTidy ? [20:31:42] (03CR) 10Jdlrobson: [C: 031] Update Moment.js from 2.7.0 to 2.8.1 [core] - 10https://gerrit.wikimedia.org/r/151630 (owner: 10Paladox) [20:31:45] yes [20:31:49] it causes all kinds of stupid shit [20:31:50] https://bugzilla.wikimedia.org/show_bug.cgi?id=2542 [20:31:56] (03CR) 10Legoktm: [C: 032] Added test to check that the unsubscribe function is working correctly [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153795 (owner: 1001tonythomas) [20:32:19] I'll check that locally thanks a lot.. [20:32:20] (03CR) 10EBernhardson: [C: 031] Get rid of isAlwaysWatched [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153789 (owner: 10Matthias Mullie) [20:32:39] jenkins seems down :\ [20:32:48] What else is new [20:32:55] (03CR) 10EBernhardson: [C: 031] "seems large and hackish for such a small change, but lets run with it and clean up later" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149210 (owner: 10Werdna) [20:33:11] tonythomas: https://integration.wikimedia.org/ci/ works for me [20:33:17] (03CR) 10Jdlrobson: [C: 04-1] "Minor indent tweak needed then I'm happy to merge." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/152839 (owner: 10Gerrit Patch Uploader) [20:34:03] tonythomas: Also, it looks like the patch you just rechecked got merged fine [20:34:21] not yet, I think. [20:34:34] (03PS3) 10Legoktm: includes/actions/: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/153748 [20:35:07] marktraceur: jenkins gave +2 though ! :) hope it gets merged in some mins [20:35:11] tonythomas: https://gerrit.wikimedia.org/r/153871 seems fine [20:35:13] (03CR) 10Jdlrobson: [C: 032] includes/actions/: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/153748 (owner: 10Legoktm) [20:35:25] It's running the gate-and-submit workflow [20:35:54] yeah :) looks good now [20:36:34] (03CR) 10Cscott: "Ping! Aaron, have you fixed this breakage yet?" [core] - 10https://gerrit.wikimedia.org/r/151522 (https://bugzilla.wikimedia.org/69082) (owner: 10Cscott) [20:36:44] hope the other one too goes fine, gtg some sleep. [20:37:02] (03PS4) 10Manybubbles: Create endpoint to dump cirrus configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/153868 (https://bugzilla.wikimedia.org/69442) [20:37:55] (03CR) 10Jdlrobson: "Break this test into 3 things" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149210 (owner: 10Werdna) [20:37:58] (03CR) 10Manybubbles: "Added another config global to be used to shut off the dump entirely. It defaults to letting the dump proceed but can be shut off if need" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/153868 (https://bugzilla.wikimedia.org/69442) (owner: 10Manybubbles) [20:38:39] (03CR) 10Jdlrobson: [C: 04-1] "Let's break this into 3 patches. It's not all this code to move a star but the stuff you've done here is all useful." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149210 (owner: 10Werdna) [20:38:42] (03PS2) 10Gerrit Patch Uploader: mediawiki.page.gallery: Support live preview [core] - 10https://gerrit.wikimedia.org/r/153384 [20:38:44] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/153384 (owner: 10Gerrit Patch Uploader) [20:38:47] MatmaRex: you spotted the problem. Now I can reproduce exactly the same behavior locally. [20:39:08] (03CR) 10Legoktm: "I'm not sure you need the kill switch config action, you can use $wgApiModules['foo'] = 'ApiDisabled';" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/153868 (https://bugzilla.wikimedia.org/69442) (owner: 10Manybubbles) [20:39:34] (03PS2) 10Jackmcbarn: Expose file page count, width, and height to Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/136274 [20:39:37] yeah. tidy is a piece of fucking junk [20:39:56] i have no idea how to suppress that behavior without disabling it, and we can't disable it after it's been enabled for years [20:40:18] (03PS3) 10Jackmcbarn: Expose file page count, width, and height to Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/136274 [20:40:42] 3MediaWiki / 3Parser: HTML Tidy issues (tracking) - 10https://bugzilla.wikimedia.org/2542 (10physikerwelt) [20:40:55] (03Abandoned) 10Jdlrobson: Add (yet another) abstract collection class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125228 (owner: 10Matthias Mullie) [20:41:05] $wgAlwaysUseTidyMaybe = true;! [20:41:07] (03PS5) 10Manybubbles: Create endpoint to dump cirrus configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/153868 (https://bugzilla.wikimedia.org/69442) [20:41:09] (03Merged) 10jenkins-bot: SkinFallbackTemplate: Use SkinFactory instead of $wgValidSkinNames [core] - 10https://gerrit.wikimedia.org/r/153542 (owner: 10Legoktm) [20:41:16] (03PS2) 10Cscott: Check for truncated image files during download. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/152084 [20:41:42] (03CR) 10Manybubbles: "Swapped kill switch with advice on how to kill the api using built in mediawiki config." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/153868 (https://bugzilla.wikimedia.org/69442) (owner: 10Manybubbles) [20:42:27] 3MediaWiki extensions / 3ProofreadPage: Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar - 10https://bugzilla.wikimedia.org/69447 (10Tpt) p:5Low>3High [20:44:05] (03CR) 10Jdlrobson: [C: 04-1] "Rebase or abandon" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126996 (owner: 10Matthias Mullie) [20:44:31] (03CR) 10Jdlrobson: [C: 04-1] "Rebase or abandon" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/134982 (owner: 10Bsitu) [20:44:37] Maybe we can make Tidy accept the MathML subset of HTML5? [20:45:25] (03PS3) 10Jdlrobson: (bug 67714) Remove "Active x hours ago" on topic title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/146431 (https://bugzilla.wikimedia.org/67714) (owner: 10Matthias Mullie) [20:45:34] (03PS5) 10Jdlrobson: WIP: QA: Thanking another users post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/146628 [20:45:42] physikerwelt: good luck with that [20:45:48] i tihnk it's been unmaintained since 2008 or so [20:45:57] (03PS1) 10Aaron Schulz: Avoid a few notices if proc_open() fails [services/jobrunner] - 10https://gerrit.wikimedia.org/r/153889 [20:45:59] (i might be wrong) [20:45:59] (03CR) 10Jdlrobson: [C: 04-1] "Why is this still a WIP. Please un-WIP this." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/134987 (owner: 10Bsitu) [20:46:02] (03PS3) 10Jdlrobson: [WIP]Update flow_revision_state [extensions/Flow] - 10https://gerrit.wikimedia.org/r/134985 (owner: 10Bsitu) [20:46:09] (03CR) 10jenkins-bot: [V: 04-1] [WIP]Update flow_revision_state [extensions/Flow] - 10https://gerrit.wikimedia.org/r/134985 (owner: 10Bsitu) [20:46:35] (03CR) 10Jdlrobson: [C: 04-1] "un-WIP this. If it's been around for this long it's probably not important" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/134985 (owner: 10Bsitu) [20:46:41] 3MediaWiki extensions / 3CirrusSearch: intitle search doesn't work - 10https://bugzilla.wikimedia.org/66969#c6 (10Nik Everett) Looks like this is the stemmer: https://svn.apache.org/repos/asf/lucene/dev/trunk/lucene/analysis/common/src/java/org/apache/lucene/analysis/id/IndonesianStemmer.java These are the s... [20:46:44] (03PS2) 10Jdlrobson: [WIP]Separate revision state related action to smaller objects [extensions/Flow] - 10https://gerrit.wikimedia.org/r/134987 (owner: 10Bsitu) [20:46:51] (03CR) 10jenkins-bot: [V: 04-1] [WIP]Separate revision state related action to smaller objects [extensions/Flow] - 10https://gerrit.wikimedia.org/r/134987 (owner: 10Bsitu) [20:47:12] (03CR) 10Cscott: [C: 032] Check for truncated image files during download. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/152084 (owner: 10Cscott) [20:47:31] (03CR) 10Jdlrobson: [C: 04-1] "This needs to be rebased. I'm happy to take a look at this if you are busy Bencmq" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123874 (https://bugzilla.wikimedia.org/61340) (owner: 10Bencmq) [20:47:34] (03Merged) 10jenkins-bot: Added test to check that the unsubscribe function is working correctly [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153795 (owner: 1001tonythomas) [20:47:52] physikerwelt: your bug might actually be the same thing as https://bugzilla.wikimedia.org/show_bug.cgi?id=27786 [20:47:58] (03CR) 10Jdlrobson: [C: 04-1] "Bernie this needs a rebase and is still a WIP and it's 154 days old man!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118238 (owner: 10EBernhardson) [20:48:01] (03PS1) 10Legoktm: Pass $name to default Skin constructor for backwards-compatability [core] - 10https://gerrit.wikimedia.org/r/153890 [20:48:06] (03PS2) 10Jdlrobson: WIP: Tests for non-existence of absolute uris [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151121 [20:48:35] (03Abandoned) 10Jdlrobson: WIP: Tests for non-existence of absolute uris [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151121 (owner: 10Jdlrobson) [20:48:51] (03Merged) 10jenkins-bot: includes/actions/: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/153748 (owner: 10Legoktm) [20:49:09] (03CR) 10Legoktm: SkinFactory: register skins in Setup.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153540 (owner: 10Legoktm) [20:49:12] (03CR) 10Bsitu: New topic notifications for watchers of a board. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [20:50:38] (03Merged) 10jenkins-bot: Check for truncated image files during download. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/152084 (owner: 10Cscott) [20:51:28] (03CR) 10Aaron Schulz: [C: 032] "Merging this will probably break some other test with trx warnings." [core] - 10https://gerrit.wikimedia.org/r/151522 (https://bugzilla.wikimedia.org/69082) (owner: 10Cscott) [20:53:16] MatmaRex: My tags disappear completely.... there is a related bug http://sourceforge.net/p/tidy/patches/84/ but you are right it seems to be not maintained... It would be interesting to figure out how svg content is treated. [20:54:24] (03PS1) 10Cscott: Updating to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/153891 [20:54:57] 3MediaWiki / 3Parser: HTML Tidy issues (tracking) - 10https://bugzilla.wikimedia.org/2542 (10physikerwelt) [20:56:02] (03PS2) 10Cscott: Updating to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/153891 [20:56:08] (03CR) 10BearND: [C: 04-1] Next iteration of styling for PageIssues/Disambiguation. (033 comments) [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/153813 (owner: 10Dbrant) [20:56:11] 3MediaWiki / 3JavaScript: Implement mw.Time module for parsing, formatting and "timeago" display of timestamps - 10https://bugzilla.wikimedia.org/45834#c7 (10PRO) (In reply to Helder from comment #6) No and thx for clarification, it work now with the module load and moment().format('YYYY-M-D') -> solved [20:56:38] (03CR) 10Cscott: [C: 032 V: 032] Updating to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/153891 (owner: 10Cscott) [20:56:50] (03CR) 10Aaron Schulz: [C: 032] "Already deployed/run" [core] - 10https://gerrit.wikimedia.org/r/151116 (owner: 10Aaron Schulz) [20:59:36] (03PS1) 10Cscott: Merge branch 'master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/153892 [21:00:36] (03CR) 10Cscott: [C: 032 V: 032] Merge branch 'master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/153892 (owner: 10Cscott) [21:01:38] (03Merged) 10jenkins-bot: Revert "Made LCStoreDB try to use a separate DB connection" [core] - 10https://gerrit.wikimedia.org/r/151522 (https://bugzilla.wikimedia.org/69082) (owner: 10Cscott) [21:01:41] 3MediaWiki / 3JobRunner: Jobrunner will fail to spawn jobs on HHVM - 10https://bugzilla.wikimedia.org/69428#c2 (10Aaron Schulz) Not seeing this with: sudo -u apache /usr/bin/php /srv/deployment/jobrunner/jobrunner/redisJobRunnerService --config-file=/etc/jobrunner/jobrunner.conf --verbose Also, running som... [21:02:58] (03Merged) 10jenkins-bot: Run some parser tests with tidy. [core] - 10https://gerrit.wikimedia.org/r/133957 (owner: 10Cscott) [21:04:29] 3MediaWiki extensions / 3CentralAuth: CentralAuth's Special:GlobalGroupMembership setup catch-22 - 10https://bugzilla.wikimedia.org/29435#c5 (10Jasper Deng) *** Bug 43916 has been marked as a duplicate of this bug. *** [21:04:29] 3MediaWiki extensions / 3CentralAuth: Do not require globalgrouppermissions or globalgroupmembership rights in global groups to access Special:GlobalGroupPermissions or Special:GlobalGroupMembership - 10https://bugzilla.wikimedia.org/43916#c8 (10Jasper Deng) 5NEW>3RESO/DUP (In reply to Kunal Mehta (Legok... [21:04:30] (03Abandoned) 10Spage: subclass core's ErrorPageError & PermissionsError [extensions/Flow] - 10https://gerrit.wikimedia.org/r/116786 (https://bugzilla.wikimedia.org/62176) (owner: 10Spage) [21:04:49] legoktm ^ [21:04:53] (you were right) [21:04:57] ty [21:06:19] (03CR) 10Bartosz Dziewoński: [C: 032] Pass $name to default Skin constructor for backwards-compatability [core] - 10https://gerrit.wikimedia.org/r/153890 (owner: 10Legoktm) [21:06:55] (03Merged) 10jenkins-bot: Added --lastUpdatedId option to backlink namespace population script [core] - 10https://gerrit.wikimedia.org/r/151116 (owner: 10Aaron Schulz) [21:07:25] (03PS2) 10Shirayuki: i18n: fix "security-desc-LS" [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/153771 [21:07:56] (03CR) 10Spage: "It's good, come on Jenkins." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151806 (owner: 10Jdlrobson) [21:08:00] 3MediaWiki / 3Documentation: Documentation is out of date, incomplete (tracking) - 10https://bugzilla.wikimedia.org/1 (10Kunal Mehta (Legoktm)) [21:08:00] 3MediaWiki extensions / 3AntiSpoof: Expose wpIgnoreAntiSpoof option on API properly - 10https://bugzilla.wikimedia.org/54899 (10Kunal Mehta (Legoktm)) [21:08:26] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c16 (10Stefan2) I think that the problem is that the MediaWiki namespace can be edited by any administrator. Many administrators do not understand what th... [21:10:56] 3MediaWiki extensions / 3CirrusSearch: Phrase matching with stemming in CirrusSearch - 10https://bugzilla.wikimedia.org/69226#c4 (10Nik Everett) 5REOP>3ASSI For the most part this is caused by the phrase slop issue I mention earlier. The temporary work around is to search for <"station box"~0~>. What u... [21:13:42] (03CR) 10Legoktm: Update release notes and documentation about skins (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153881 (https://bugzilla.wikimedia.org/68402) (owner: 10Bartosz Dziewoński) [21:14:36] (03PS1) 10Manybubbles: Switch default phrase slop to 0 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/153943 (https://bugzilla.wikimedia.org/69226) [21:15:03] (03PS1) 10Aaron Schulz: Removed LCStoreDB class [core] - 10https://gerrit.wikimedia.org/r/153944 [21:15:29] (03CR) 10jenkins-bot: [V: 04-1] Removed LCStoreDB class [core] - 10https://gerrit.wikimedia.org/r/153944 (owner: 10Aaron Schulz) [21:18:08] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I looked at the updated edit and delete forms." [core] - 10https://gerrit.wikimedia.org/r/150635 (owner: 10Jdlrobson) [21:20:00] (03PS2) 10Aaron Schulz: Removed LCStoreDB class [core] - 10https://gerrit.wikimedia.org/r/153944 [21:20:20] (03Abandoned) 10Spage: Use addCaptchaAPI to supply info to signup form [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/60350 (https://bugzilla.wikimedia.org/46759) (owner: 10Spage) [21:20:39] (03CR) 10Legoktm: "For wikis currently using localization in the DB, will it *just work* if $wgCacheDirectory is set? Or is other setup required?" [core] - 10https://gerrit.wikimedia.org/r/153944 (owner: 10Aaron Schulz) [21:21:09] (03Merged) 10jenkins-bot: Pass $name to default Skin constructor for backwards-compatability [core] - 10https://gerrit.wikimedia.org/r/153890 (owner: 10Legoktm) [21:21:14] 3MediaWiki / 3General/Unknown: "Did you mean" should search related for words - 10https://bugzilla.wikimedia.org/69493 (10Rob) 3UNCO p:3Unprio s:3normal a:3None I think a search result that didn't find anything should also search for all related words in the query. I'm not sure I can explain this enh... [21:22:15] (03CR) 10Aaron Schulz: "As long as it is set to a directory that the app server user can write to it will "just work"." [core] - 10https://gerrit.wikimedia.org/r/153944 (owner: 10Aaron Schulz) [21:22:29] Error: Could not start Service[jobrunner]: Execution of '/sbin/start jobrunner' returned 1: [21:22:58] what do i do with that ? rebuild my entire VM another time ? [21:23:26] (03CR) 10Aaron Schulz: "Assuming 'store' => 'db' is removed from config of course." [core] - 10https://gerrit.wikimedia.org/r/153944 (owner: 10Aaron Schulz) [21:23:40] (03CR) 10Bartosz Dziewoński: Update release notes and documentation about skins (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153881 (https://bugzilla.wikimedia.org/68402) (owner: 10Bartosz Dziewoński) [21:25:49] (03PS13) 10Paladox: Update Moment.js from 2.7.0 to 2.8.1 [core] - 10https://gerrit.wikimedia.org/r/151630 [21:26:41] 3MediaWiki extensions / 3CirrusSearch: "Did you mean" should search related for words - 10https://bugzilla.wikimedia.org/69493#c1 (10Nik Everett) 5UNCO>3NEW p:5Unprio>3Low s:5normal>3enhanc Moving to CirrusSearch and setting to enhancement. Its certainly worth investigating. Most righteous woul... [21:31:52] (03PS5) 10Gerrit Patch Uploader: mediawiki.notify: Simplify callback by using .then() [core] - 10https://gerrit.wikimedia.org/r/152839 [21:31:54] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/152839 (owner: 10Gerrit Patch Uploader) [21:33:11] 3MediaWiki extensions / 3Collection: New PDF renderer: Formulas are not left aligned - 10https://bugzilla.wikimedia.org/68838#c4 (10C. Scott Ananian) This should be fixed now, but the two-column mode makes it difficult to verify. [21:33:41] 3MediaWiki extensions / 3Collection: New PDF renderer: One column layout doesn't work. - 10https://bugzilla.wikimedia.org/68836 (10C. Scott Ananian) [21:33:58] (03PS2) 10Ori.livneh: Enabled $wgUseLinkNamespaceDBFields [core] - 10https://gerrit.wikimedia.org/r/153634 (owner: 10Aaron Schulz) [21:34:04] (03CR) 10Ori.livneh: [C: 032] Enabled $wgUseLinkNamespaceDBFields [core] - 10https://gerrit.wikimedia.org/r/153634 (owner: 10Aaron Schulz) [21:34:11] 3MediaWiki extensions / 3Collection: New PDF renderer: One column layout doesn't work. - 10https://bugzilla.wikimedia.org/68836#c2 (10C. Scott Ananian) Apparently the OCG extension isn't passing the 'one column' parameter into the backend. [21:36:28] 3MediaWiki extensions / 3Collection: Almost any image makes the PDF rendering crash - 10https://bugzilla.wikimedia.org/68929#c8 (10C. Scott Ananian) a:5Matt Walker>3C. Scott Ananian I think I've fixed most of these cases -- the ones involving partially downloaded images at least. But [[en:United States]... [21:37:31] (03CR) 10Spage: [C: 04-1] "Now we have 'mediawiki.ui.checkbox' in core, just add the resource and follow HTML in living style guide http://tools.wmflabs.org/stylegui" [core] - 10https://gerrit.wikimedia.org/r/76471 (owner: 10Spage) [21:38:59] 3MediaWiki extensions / 3Collection: New PDF renderer: [[United States]] fails to render - 10https://bugzilla.wikimedia.org/68854#c1 (10C. Scott Ananian) a:3C. Scott Ananian This has been fixed with today's deploy of OCG. But [[United States]] still fails to render. So I'm retitling the bug. [21:39:01] (03CR) 10TheDJ: [C: 032] Fix Help and Privacy link generation in CPB [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/153533 (https://bugzilla.wikimedia.org/64909) (owner: 10JGonera) [21:39:08] (03Merged) 10jenkins-bot: Fix Help and Privacy link generation in CPB [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/153533 (https://bugzilla.wikimedia.org/64909) (owner: 10JGonera) [21:39:31] (03Merged) 10jenkins-bot: Enabled $wgUseLinkNamespaceDBFields [core] - 10https://gerrit.wikimedia.org/r/153634 (owner: 10Aaron Schulz) [21:40:28] 3MediaWiki extensions / 3Collection: Many non-latin fonts don't cover the latin character set - 10https://bugzilla.wikimedia.org/68922#c3 (10C. Scott Ananian) a:3C. Scott Ananian The above patches partially fix the problem -- they switch to the default latin font for latin code pages. But we should really... [21:41:37] (03CR) 10TheDJ: "why the 200px ?" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/153430 (owner: 10JGonera) [21:42:42] 3MediaWiki extensions / 3Collection: Meaningless protocol-relative URL output for CC license link in PDF - 10https://bugzilla.wikimedia.org/68875 (10C. Scott Ananian) a:3C. Scott Ananian [21:43:16] (03CR) 10TheDJ: [C: 032] Add ids to Privacy and Help items in CPB [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/153545 (owner: 10JGonera) [21:43:21] (03Merged) 10jenkins-bot: Add ids to Privacy and Help items in CPB [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/153545 (owner: 10JGonera) [21:43:26] (03PS4) 10SG: Move jQueryFindWithParent into its own findWithParent plugin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153627 [21:43:55] (03PS5) 10SG: Move jQueryFindWithParent into its own findWithParent plugin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153627 [21:44:58] (03CR) 10jenkins-bot: [V: 04-1] Move jQueryFindWithParent into its own findWithParent plugin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153627 (owner: 10SG) [21:45:13] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c17 (10Helder) Gadgets 2.0 introduces new user rights specific for edit/management of gadgets: https://www.mediawiki.org/wiki/ResourceLoader/Version_2_Des... [21:45:36] (03CR) 10TheDJ: [C: 032] Add missing star images to fixed header beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/153853 (owner: 10Jdlrobson) [21:45:42] (03Merged) 10jenkins-bot: Add missing star images to fixed header beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/153853 (owner: 10Jdlrobson) [21:47:11] 3MediaWiki extensions / 3Collection: Many non-latin fonts don't cover the latin character set - 10https://bugzilla.wikimedia.org/68922#c4 (10C. Scott Ananian) Note that the default latin font doesn't cover the ~ character (!), which is used in https://en.wikipedia.org/wiki/Moon#Internal_structure in the sent... [21:51:16] 3MediaWiki extensions / 3Collection: Error message is not parsed (shows HTML syntax to the user) - 10https://bugzilla.wikimedia.org/69495 (10Helder) 3NEW p:3Unprio s:3normal a:3None When I accessed the URL above the extension showed a message like this. -----------------------------------------------... [21:51:27] 3MediaWiki extensions / 3Collection: New PDF renderer: Broken URL to the source of the PDF - 10https://bugzilla.wikimedia.org/68837#c3 (10C. Scott Ananian) https://gerrit.wikimedia.org/r/150438 was also involved in the fix here. [21:51:41] 3MediaWiki extensions / 3Collection: Meaningless protocol-relative URL output for CC license link in PDF - 10https://bugzilla.wikimedia.org/68875#c2 (10C. Scott Ananian) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 68837 *** [21:51:56] 3MediaWiki extensions / 3Collection: New PDF renderer: Broken URL to the source of the PDF - 10https://bugzilla.wikimedia.org/68837#c4 (10C. Scott Ananian) *** Bug 68875 has been marked as a duplicate of this bug. *** [21:53:28] 3MediaWiki extensions / 3Collection: New PDF renderer: [[en:Integral]] fails. - 10https://bugzilla.wikimedia.org/68835#c1 (10C. Scott Ananian) 5NEW>3RESO/DUP a:3C. Scott Ananian *** This bug has been marked as a duplicate of bug 68929 *** [21:53:28] 3MediaWiki extensions / 3Collection: Almost any image makes the PDF rendering crash - 10https://bugzilla.wikimedia.org/68929#c9 (10C. Scott Ananian) *** Bug 68835 has been marked as a duplicate of this bug. *** [21:53:57] 3MediaWiki extensions / 3Collection: New PDF renderer: [[en:Integral]] fails. - 10https://bugzilla.wikimedia.org/68835#c2 (10C. Scott Ananian) Whoops, not a duplicate. [21:53:57] 3MediaWiki extensions / 3Collection: New PDF renderer: [[en:Integral]] fails. - 10https://bugzilla.wikimedia.org/68835 (10C. Scott Ananian) 5RESO/DUP>3REOP [21:55:41] 3MediaWiki extensions / 3Collection: Error message is not parsed (shows HTML syntax to the user) - 10https://bugzilla.wikimedia.org/69495#c1 (10C. Scott Ananian) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 68991 *** [21:55:43] 3MediaWiki extensions / 3Collection: Special:Book unparsed HTML error message - 10https://bugzilla.wikimedia.org/68991#c1 (10C. Scott Ananian) *** Bug 69495 has been marked as a duplicate of this bug. *** [21:56:42] 3MediaWiki extensions / 3Collection: New PDF renderer: One column layout doesn't work. - 10https://bugzilla.wikimedia.org/68836#c3 (10Helder) For more test cases, see https://en.wikipedia.org/w/index.php?title=Special:Book&bookcmd=render_article&arttitle=List+of+integrals+of+trigonometric+functions&oldid=614... [21:56:42] 3MediaWiki extensions / 3Collection: Special:Book unparsed HTML error message - 10https://bugzilla.wikimedia.org/68991#c2 (10C. Scott Ananian) a:3C. Scott Ananian mwalker said this was already fixed in the collection extension; I probably just have to figure out how to deploy the new version. [22:01:40] (03CR) 10Legoktm: [C: 031] "Sounds good to me then. Maybe the release notes should be explicit that you need to remove 'store'=>'db' from $wgLocalisationCacheConf? I " [core] - 10https://gerrit.wikimedia.org/r/153944 (owner: 10Aaron Schulz) [22:05:07] (03PS6) 10Jdlrobson: QA: Thanking another users post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/146628 [22:05:22] (03PS1) 10Microchip08: add compact setting for generated CSS [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153954 [22:07:19] (03PS1) 10Mitar: PHP 5.4 compatibility. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153956 [22:07:24] (03PS3) 10Aaron Schulz: Removed LCStoreDB class [core] - 10https://gerrit.wikimedia.org/r/153944 [22:07:45] (03CR) 10Mattflaschen: [C: 04-1] "Can you explain the use case of the undo parameter? It also seems a little messy to me." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/151792 (owner: 10Jdlrobson) [22:07:50] (03CR) 10Jdlrobson: Move jQueryFindWithParent into its own findWithParent plugin (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153627 (owner: 10SG) [22:08:53] (03CR) 10Jdlrobson: [C: 04-1] "also jshint issues" (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153627 (owner: 10SG) [22:09:31] (03CR) 10Jdlrobson: [C: 04-1] "Not in core yet" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151789 (owner: 10Jdlrobson) [22:10:18] (03CR) 10Jdlrobson: [C: 032] Get rid of isAlwaysWatched [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153789 (owner: 10Matthias Mullie) [22:17:43] 3MediaWiki extensions / 3OAuth: Installation documentation should explain memcached - 10https://bugzilla.wikimedia.org/69499 (10Mitar) 3UNCO p:3Unprio s:3normal a:3None Installation documentation mentions memcached only under requirements, but for somebody new to MediaWiki and OAuth extension this is... [22:19:48] (03CR) 10Florianschmidtwelzow: WIP: Replace deprecated wfMsg() and friends (031 comment) [extensions/GlobalNotice] - 10https://gerrit.wikimedia.org/r/152092 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [22:20:35] (03CR) 10Aaron Schulz: [C: 032] Allow to send the memory usage with UDP profiler. [core] - 10https://gerrit.wikimedia.org/r/132643 (owner: 10IAlex) [22:24:46] (03Merged) 10jenkins-bot: Allow to send the memory usage with UDP profiler. [core] - 10https://gerrit.wikimedia.org/r/132643 (owner: 10IAlex) [22:24:50] (03PS1) 10Bsitu: Add support to mark all as read for "sections" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153960 [22:26:15] (03CR) 10Aaron Schulz: [C: 032] Don't set the session name in CLI or when sessions are deactivated [core] - 10https://gerrit.wikimedia.org/r/151722 (owner: 10IAlex) [22:29:02] (03PS2) 10Bsitu: Add support to mark all as read for "sections" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153960 [22:30:57] (03Merged) 10jenkins-bot: Don't set the session name in CLI or when sessions are deactivated [core] - 10https://gerrit.wikimedia.org/r/151722 (owner: 10IAlex) [22:31:27] 3MediaWiki / 3History/Diffs: Store user ids in rollback summaries and substitute them run time - 10https://bugzilla.wikimedia.org/18526 (10Kunal Mehta (Legoktm)) 5NEW>3ASSI a:3Kunal Mehta (Legoktm) [22:31:55] (03CR) 10Bsitu: Mark notification as read upon visiting a page (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152198 (owner: 10Bsitu) [22:39:06] (03CR) 10Aaron Schulz: [C: 032] Use camel case for variable names in Article.php [core] - 10https://gerrit.wikimedia.org/r/151288 (owner: 10IAlex) [22:40:29] (03PS1) 10Legoktm: $wgAuth is never a stub object [core] - 10https://gerrit.wikimedia.org/r/153964 [22:41:56] 3MediaWiki extensions / 3[other]: EmbedVideo extension delivers youtube videos using http instead of https causing modern browsers to block the content - 10https://bugzilla.wikimedia.org/69454#c3 (10Roger Morton) Thanks Andre. I think this issue is being covered as https://github.com/Whiteknight/mediawiki-em... [22:42:59] (03Merged) 10jenkins-bot: Use camel case for variable names in Article.php [core] - 10https://gerrit.wikimedia.org/r/151288 (owner: 10IAlex) [22:43:48] (03CR) 10Bsitu: "Nothing left to be done in this patch, I -2ed it because it can't be merged till the echo patch is merged" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/152935 (owner: 10Bsitu) [22:43:58] (03PS1) 10Physikerwelt: Protect MathML from Tidy [extensions/Math] - 10https://gerrit.wikimedia.org/r/153965 [22:45:09] (03PS2) 10Physikerwelt: Protect MathML from Tidy [extensions/Math] - 10https://gerrit.wikimedia.org/r/153965 (https://bugzilla.wikimedia.org/66516) [22:46:50] (03CR) 10Aaron Schulz: [C: 032] PHP 5.4 compatibility. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153956 (owner: 10Mitar) [22:47:19] (03Merged) 10jenkins-bot: PHP 5.4 compatibility. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153956 (owner: 10Mitar) [22:49:53] (03CR) 10Physikerwelt: "Does this have negative performance implications?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/153965 (https://bugzilla.wikimedia.org/66516) (owner: 10Physikerwelt) [22:54:14] (03CR) 10Jdlrobson: [C: 031] "bsitu raised some concerns." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153789 (owner: 10Matthias Mullie) [22:57:32] (03Restored) 10Ori.livneh: Remove xdiff-backed HistoryBlob implementation [core] - 10https://gerrit.wikimedia.org/r/84770 (owner: 10Chad) [22:58:28] (03CR) 10Krinkle: "And 5.3 as well, not to forget. our main version is 5.3 at the moment still." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153956 (owner: 10Mitar) [22:59:10] (03CR) 10Bsitu: "It's not really a concern and this code itself is fine. I recall Danny confirmed this behaviour when I was implementing the topic subscrip" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153789 (owner: 10Matthias Mullie) [22:59:42] (03CR) 10Krinkle: [C: 032] mediawiki.notify: Simplify callback by using .then() [core] - 10https://gerrit.wikimedia.org/r/152839 (owner: 10Gerrit Patch Uploader) [22:59:48] (03PS1) 10Jack Phoenix: Revert "Make header sprites theme-agnostic (b&w with transparency)" [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153966 [22:59:58] (03CR) 10Jack Phoenix: [C: 032 V: 032] Revert "Make header sprites theme-agnostic (b&w with transparency)" [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153966 (owner: 10Jack Phoenix) [23:03:24] (03PS2) 10Ori.livneh: Remove xdiff-backed HistoryBlob implementation [core] - 10https://gerrit.wikimedia.org/r/84770 (owner: 10Chad) [23:03:48] (03CR) 10Ori.livneh: "Rebased." [core] - 10https://gerrit.wikimedia.org/r/84770 (owner: 10Chad) [23:04:03] (03Merged) 10jenkins-bot: mediawiki.notify: Simplify callback by using .then() [core] - 10https://gerrit.wikimedia.org/r/152839 (owner: 10Gerrit Patch Uploader) [23:05:25] (03CR) 10Mattflaschen: "> Matt I don't really understand vform - it would be better if someone else did this work... any of your team able to? Who wrote it? See h" [core] - 10https://gerrit.wikimedia.org/r/150418 (owner: 10Jdlrobson) [23:09:28] 3MediaWiki / 3Unit tests: RCCacheEntryFactoryTest causes test errors because it uses a deprecated assert method - 10https://bugzilla.wikimedia.org/69505 (10Ori Livneh) 3NEW p:3Unprio s:3normal a:3None PHPUnit_Framework_Assert::assertTag has been deprecated in PHPUnit 4.2. Because we configure our tes... [23:10:19] (03CR) 10Mitar: "Yes, but this should not brake 5.3, only provide 5.4 compatibility. Here it is written that it is 5.3 and 5.4: https://www.mediawiki.org/w" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153956 (owner: 10Mitar) [23:15:56] 3MediaWiki / 3Skin and page rendering: MediaWiki UI: VForm only partially documented - 10https://bugzilla.wikimedia.org/69449#c1 (10Matthew Flaschen) p:5Unprio>3Normal s:5major>3normal This is something that should be cleaned up, but it is not major ("Major loss of function in an important area.", ht... [23:17:40] (03CR) 10PleaseStand: [C: 04-1] "Putting back my -1. As far as I know, at least the decompression part of the code is still needed for existing data in Wikimedia external " [core] - 10https://gerrit.wikimedia.org/r/84770 (owner: 10Chad) [23:18:16] (03PS1) 10Jack Phoenix: Revert "Revert "Make header sprites theme-agnostic (b&w with transparency)"" [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153969 [23:18:26] (03CR) 10Jack Phoenix: [C: 032 V: 032] Revert "Revert "Make header sprites theme-agnostic (b&w with transparency)"" [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153969 (owner: 10Jack Phoenix) [23:23:11] bd808|BUFFER, ori: could use a review +2 when you get a chance https://gerrit.wikimedia.org/r/#/c/153861/ [23:23:29] bd808|BUFFER, ori: and this one https://gerrit.wikimedia.org/r/#/c/152992/ [23:25:56] 3MediaWiki / 3Skin and page rendering: MediaWiki UI: VForm only partially documented - 10https://bugzilla.wikimedia.org/69449#c2 (10Jon) Not sure how it got assigned major that was not intentional :) [23:29:12] 3MediaWiki-Vagrant: Create sample pages for new MW - 10https://bugzilla.wikimedia.org/46869#c3 (10Matthew Flaschen) Note, there is now 'vagrant import-dump'. It uses a standard dump XML file. I don't think there is any functionality to automatically do an import when you first create/vagrant up the wiki (what... [23:36:00] (03PS1) 10Legoktm: [WIP] Store user id in revert messages [core] - 10https://gerrit.wikimedia.org/r/153979 (https://bugzilla.wikimedia.org/18526) [23:36:22] (03PS2) 10Legoktm: [WIP] Store user id in revert messages [core] - 10https://gerrit.wikimedia.org/r/153979 (https://bugzilla.wikimedia.org/18526) [23:37:41] 3MediaWiki-Vagrant: Create sample pages for new MW - 10https://bugzilla.wikimedia.org/46869#c4 (10Yuri Astrakhan) Implemented in Change-Id: I79cfcc515a32e25c25817d67ac302eec4d5acda6 pending review. Matthew, import-dump has a different goal - it's a complex transfer of textual data from one wiki to another. T... [23:38:04] (03CR) 10Mattflaschen: [C: 04-1] "Have you discussed this with Leucosticte (I've added him and another contributor, Kghbln)?" [extensions/InterwikiExistence] - 10https://gerrit.wikimedia.org/r/153767 (owner: 10Paladox) [23:39:30] (03CR) 10Legoktm: "Another idea I just had: store the edit summary as "msg:revertpage:$userId:$otherUserId" and then convert that to "revertpage-nouser" in L" [core] - 10https://gerrit.wikimedia.org/r/153979 (https://bugzilla.wikimedia.org/18526) (owner: 10Legoktm) [23:39:58] (03CR) 10leucosticte: "I have no plans to work on it anytime soon. It needs an overhaul. Github is probably a better place for it." [extensions/InterwikiExistence] - 10https://gerrit.wikimedia.org/r/153767 (owner: 10Paladox) [23:41:10] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Store user id in revert messages [core] - 10https://gerrit.wikimedia.org/r/153979 (https://bugzilla.wikimedia.org/18526) (owner: 10Legoktm) [23:41:17] (03PS1) 10Mitar: Allow adding custom parameters to the callback for OAuth. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153983 [23:41:56] 3MediaWiki extensions / 3OAuth: Allow adding custom parameters to the callback for OAuth - 10https://bugzilla.wikimedia.org/69250#c3 (10Mitar) I opened a pull request: https://gerrit.wikimedia.org/r/#/c/153983/ [23:43:10] (03PS3) 10Legoktm: [WIP] Store user id in revert messages [core] - 10https://gerrit.wikimedia.org/r/153979 (https://bugzilla.wikimedia.org/18526) [23:44:59] (03CR) 10Addshore: [C: 04-1] Use SkinFactory to register skin, and Config instead of globals (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/153859 (owner: 10Legoktm) [23:45:57] 3MediaWiki / 3Unit tests: Inconsistent "Unfinished animations" error, probably being attributed to the wrong module - 10https://bugzilla.wikimedia.org/68884#c4 (10Matthew Flaschen) (In reply to Antoine "hashar" Musso from comment #3) > It is still bitting core badly. Is there a way to reliably reproduce the... [23:46:29] (03PS3) 10Legoktm: Use SkinFactory to register skin, and Config instead of globals [skins/Vector] - 10https://gerrit.wikimedia.org/r/153859 [23:46:37] (03CR) 10Legoktm: Use SkinFactory to register skin, and Config instead of globals (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/153859 (owner: 10Legoktm) [23:46:42] 3MediaWiki / 3Unit tests: Inconsistent "Unfinished animations" error, probably being attributed to the wrong module - 10https://bugzilla.wikimedia.org/68884#c5 (10Matthew Flaschen) It may not be reproducible in the browser, so the link shows how to use a PhantomJS runner. [23:50:16] jgonera: it turns out the @extension- tags _will_ work for individual scenarios [23:51:03] (03PS4) 10Addshore: Enable phplint job for labs-toollabs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153581 (https://bugzilla.wikimedia.org/63687) [23:51:21] (03CR) 10Addshore: "Switched this change to just phplint for now" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153581 (https://bugzilla.wikimedia.org/63687) (owner: 10Addshore) [23:53:57] (03PS3) 10Addshore: make mw-core-phpcs-lenient-HEAD voting on master! [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153575 (https://bugzilla.wikimedia.org/46500) [23:54:39] (03PS1) 10Aaron Schulz: Made LocalFile move/delete/restore handle network partitions better [core] - 10https://gerrit.wikimedia.org/r/153990 [23:58:49] (03CR) 10Jdlrobson: [C: 032] Add method for fetching unread notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153734 (owner: 10Bsitu) [23:59:15] (03Merged) 10jenkins-bot: Add method for fetching unread notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153734 (owner: 10Bsitu)