[00:10:43] (03CR) 10CSteipp: "> If you have a good idea of what we need in the request table to support this I don't have any problem adding it to the patch." (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/150997 (https://bugzilla.wikimedia.org/68889) (owner: 10BryanDavis) [00:11:23] 3Mathoid / 3General/Unknown: Initial Mathoid deployment - 10https://bugzilla.wikimedia.org/69298 (10physikerwelt) 5PATC>3NEW [00:14:09] (03CR) 10CSteipp: [C: 032] "Thanks!" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153028 (owner: 10Mitar) [00:14:16] (03Merged) 10jenkins-bot: Really fail if OAuth request source IP is invalid. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153028 (owner: 10Mitar) [00:16:23] 3Mathoid / 3General/Unknown: Initial Mathoid deployment - 10https://bugzilla.wikimedia.org/69298#c5 (10physikerwelt) I have updated the jsdom node module to trusty. Another deploy should solve the problem described by Alexandros. [00:17:17] (03PS2) 10Jdlrobson: Hygiene: Add sub-directories to phpunit test [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153458 (owner: 10Bsitu) [00:17:50] (03PS3) 10Jdlrobson: Echo/tests/ directory structure should mimic Echo/ directory's [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152204 (owner: 10Bsitu) [00:18:41] (03PS3) 10Jdlrobson: Begin deprecation of mediawiki.ui style module [core] - 10https://gerrit.wikimedia.org/r/151791 [00:21:49] (03PS8) 10Bsitu: Create TargetPage data if specified by EchoEvent [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152808 [00:28:49] (03CR) 10Jdlrobson: [C: 04-1] Auto mark notification as read if it doesn't have target page (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152203 (owner: 10Bsitu) [00:36:53] (03CR) 10CSteipp: "Hmm.. I can't login when I use localhost:8080 (it only works using 127.0.0.1:8080). It could be my vagrant though. If it's working for Ddu" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/125740 (owner: 10Zfilipin) [00:37:57] (03CR) 10Legoktm: "This is better than what we have right now, but in the future we should lazy-initialize the module objects I think." [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153539 (owner: 10Legoktm) [00:38:29] (03CR) 10MZMcBride: "Parent5446: Err, page protection definitely covers more than just editing. :-) ?action=protect is used to prevent moving (renaming), edit" [core] - 10https://gerrit.wikimedia.org/r/153362 (https://bugzilla.wikimedia.org/69380) (owner: 10Parent5446) [00:39:14] Carmela: also upload protection. [00:41:04] Also that. [00:41:14] And creation protection, maybe. [00:41:16] Who knows. [00:42:16] note that all of those have their own fields to enable. they don't piggyback off of edit [00:43:41] (03CR) 10Jdlrobson: [C: 04-1] "Please add tests." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152808 (owner: 10Bsitu) [00:44:16] legoktm: Did you look at the CA looks since we fixed them? [00:44:22] * hoo wonders what's going on now [00:44:25] 3Wikimedia / 3Deployment systems: MWMultiVersion can fatal for bad Host headers - 10https://bugzilla.wikimedia.org/69419 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None Saw the following in the fatal logs: [2014-08-12 00:36:07] Fatal error: Invalid host name (wikipedia). at /usr/local/apache/comm... [00:44:30] no, let me do that now [00:44:30] problem seemed to persist, though [00:44:43] (before the log fix, so couldn't "debug") [00:49:40] 3MediaWiki-Vagrant: hhvmsh does not load MediaWiki's context - 10https://bugzilla.wikimedia.org/69420 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3Ori Livneh hhvm does not load all of MediaWiki's context. For example wfExpandUrl (a global function defined in GlobalFunctions.php) does not work. Th... [00:54:40] 3MediaWiki-Vagrant: Debug mode is broken - 10https://bugzilla.wikimedia.org/69421 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3Ori Livneh Core script resources (e.g. http://127.0.0.1:8080/w/resources/src/mediawiki/mediawiki.util.js) are not loading in debug mode, probably because the remote path is... [00:54:42] (03PS3) 10Legoktm: [WIP] Add MultiConfig for fallback logic [core] - 10https://gerrit.wikimedia.org/r/153541 (https://bugzilla.wikimedia.org/69418) [00:55:29] (03PS5) 10Bsitu: Delete invalid records from echo_target_page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153372 [00:56:15] (03CR) 10Legoktm: [C: 031] Revert "Travis CI: Drop 5.3 as a build target" [core] - 10https://gerrit.wikimedia.org/r/153439 (owner: 10Addshore) [00:56:17] (03CR) 10Technical 13: "I'm slightly confused by this. If the user has the 'protect' userright, can't they just change any protection level even if they couldn't" [core] - 10https://gerrit.wikimedia.org/r/153345 (owner: 10Anomie) [00:58:33] (03CR) 10Jackmcbarn: "No. You can't protect a page to a level you can't edit, and you can't change a page's protection at all if it's currently at a level you c" [core] - 10https://gerrit.wikimedia.org/r/153345 (owner: 10Anomie) [01:00:17] (03PS6) 10Legoktm: Fix phpcs issues in parser [core] - 10https://gerrit.wikimedia.org/r/153446 (owner: 10Addshore) [01:00:28] (03CR) 10Legoktm: [C: 032] Fix phpcs issues in parser [core] - 10https://gerrit.wikimedia.org/r/153446 (owner: 10Addshore) [01:01:14] (03PS2) 10Legoktm: Add @codingStandardsIgnore tags to parser classes [core] - 10https://gerrit.wikimedia.org/r/153457 (owner: 10Addshore) [01:01:25] (03CR) 10Legoktm: [C: 032] Add @codingStandardsIgnore tags to parser classes [core] - 10https://gerrit.wikimedia.org/r/153457 (owner: 10Addshore) [01:03:44] (03Merged) 10jenkins-bot: Fix phpcs issues in parser [core] - 10https://gerrit.wikimedia.org/r/153446 (owner: 10Addshore) [01:05:22] (03Merged) 10jenkins-bot: Add @codingStandardsIgnore tags to parser classes [core] - 10https://gerrit.wikimedia.org/r/153457 (owner: 10Addshore) [01:06:51] (03PS3) 10Legoktm: Fix visibility in SkinFallback and StubObject [core] - 10https://gerrit.wikimedia.org/r/153498 (owner: 10Addshore) [01:07:22] (03CR) 10Legoktm: [C: 032] "I think the other skins in mediawiki/skins will probably need this too." [core] - 10https://gerrit.wikimedia.org/r/153498 (owner: 10Addshore) [01:09:54] (03CR) 10Legoktm: [C: 031] Refactor ValidGlobalNameSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/153314 (owner: 10Addshore) [01:10:56] (03Merged) 10jenkins-bot: Fix visibility in SkinFallback and StubObject [core] - 10https://gerrit.wikimedia.org/r/153498 (owner: 10Addshore) [01:11:09] 3MediaWiki-Vagrant: Debug mode is broken - 10https://bugzilla.wikimedia.org/69421 (10Matthew Flaschen) a:5Ori Livneh>3Matthew Flaschen [01:11:31] (03CR) 10Legoktm: "Nitpicks. Would be good to have a test actually using this too." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/153005 (owner: 10Addshore) [01:14:33] (03PS1) 10Mattflaschen: Fix /resources symbolic link [vagrant] - 10https://gerrit.wikimedia.org/r/153553 (https://bugzilla.wikimedia.org/69421) [01:14:59] (03PS1) 10Spage: Remove redundant "Given I am on Flow page" steps [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153554 [01:16:31] (03PS6) 10Legoktm: Convert Gadget definition namespace to use ContentHandler [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153270 (https://bugzilla.wikimedia.org/69318) [01:17:09] (03Abandoned) 10Legoktm: Remove outdated $wgVersion contstraint [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153074 (owner: 10Legoktm) [01:20:35] (03CR) 10Legoktm: "Updated version requirement." [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153270 (https://bugzilla.wikimedia.org/69318) (owner: 10Legoktm) [01:20:43] (03PS3) 10Spage: E2c: Hover behaviour of notifications panel tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153546 (owner: 10Jdlrobson) [01:57:02] (03PS4) 10Mattflaschen: Add truncated-text utility mixin [core] - 10https://gerrit.wikimedia.org/r/151792 (owner: 10Jdlrobson) [02:02:04] (03CR) 10Mattflaschen: "Uploaded a version using a mixin, so we can compare two concrete examples. I changed the name to fit the mixin naming conventions." [core] - 10https://gerrit.wikimedia.org/r/151792 (owner: 10Jdlrobson) [02:02:10] (03CR) 10Mattflaschen: [C: 04-1] Add truncated-text utility mixin [core] - 10https://gerrit.wikimedia.org/r/151792 (owner: 10Jdlrobson) [02:16:27] (03CR) 10Parent5446: "@MZMcBride: Yes, which is why I'm asking why we don't just extend that to deletion. It seems like the more obvious next step, rather than " [core] - 10https://gerrit.wikimedia.org/r/153362 (https://bugzilla.wikimedia.org/69380) (owner: 10Parent5446) [02:36:40] 3MediaWiki / 3General/Unknown: Investigate whether taking an action on a page (delete, import, etc.) should require being able to edit it - 10https://bugzilla.wikimedia.org/69380#c17 (10rschen7754.wiki) I would think that, politics aside, the code should require superprotect to delete a superprotected page,... [02:39:13] (03CR) 10Parent5446: [C: 04-1] API: Overhaul token handling (037 comments) [core] - 10https://gerrit.wikimedia.org/r/153110 (owner: 10Anomie) [02:43:33] (03CR) 10Jdlrobson: Auto mark notification as read if it doesn't have target page (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152203 (owner: 10Bsitu) [03:07:53] (03PS19) 10Jdlrobson: Notification overlay Messages and Alerts sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152165 [03:07:56] (03PS4) 10Jdlrobson: E2c: Hover behaviour of notifications panel tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153546 [03:07:59] (03PS4) 10Jdlrobson: E2b: Reflect the count in alerts and messages tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153532 [03:08:02] (03PS1) 10Jdlrobson: Kill mark as read button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153555 [03:08:05] (03PS1) 10Jdlrobson: WIP: Add the mark as read button to messages view [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153556 [03:08:23] (03CR) 10jenkins-bot: [V: 04-1] E2c: Hover behaviour of notifications panel tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153546 (owner: 10Jdlrobson) [03:08:26] (03CR) 10jenkins-bot: [V: 04-1] E2b: Reflect the count in alerts and messages tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153532 (owner: 10Jdlrobson) [03:08:37] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add the mark as read button to messages view [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153556 (owner: 10Jdlrobson) [04:31:11] 3MediaWiki extensions / 3Math: generate MathML (not PNG) and automatically embed hyperlinks for each symbol - 10https://bugzilla.wikimedia.org/69424 (10Richard Baxter) 3UNCO p:3Unprio s:3enhanc a:3None I propose that mediawiki is upgraded to generate MathML and automatically embed hyperlinks for each... [04:38:38] 3MediaWiki extensions / 3Math: generate MathML (not PNG) and automatically embed hyperlinks for each symbol - 10https://bugzilla.wikimedia.org/69424#c1 (10Richard Baxter) Created attachment 16171 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16171&action=edit mediaWikiMathExtension MathMLinstallatio... [04:42:08] 3MediaWiki extensions / 3Math: generate MathML (not PNG) and automatically embed hyperlinks for each symbol - 10https://bugzilla.wikimedia.org/69424#c2 (10Richard Baxter) Created attachment 16172 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16172&action=edit mathMLtestQuadraticEquation.html [05:30:08] 3MediaWiki extensions / 3Translate: Client side translation suggestions - 10https://bugzilla.wikimedia.org/36592#c1 (10Ricordisamoa) ...but users should be anyway warned when using such features. [05:52:05] ori, ori-l__ it broke :( [05:52:34] someone broke vagrant https://bugzilla.wikimedia.org/show_bug.cgi?id=69425 :( [05:52:52] * yurikR should go sleep and not fix silly things at 2am [06:13:53] 3MediaWiki extensions / 3Math: generate MathML (not PNG) and automatically embed hyperlinks for each symbol - 10https://bugzilla.wikimedia.org/69424#c3 (10Richard Baxter) Created attachment 16173 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16173&action=edit mediaWikiMathExtensionMathMLinstallation... [06:14:38] 3MediaWiki extensions / 3SemanticForms: Tooltips doesn't work in sub instances of templates - 10https://bugzilla.wikimedia.org/27701#c3 (10user66) It would really be great and very helpful if this problem is fixed someday ;-). Tooltips are very helpful and common to describe the meaning of each form field. T... [07:07:06] (03PS1) 10Jjanes: PostgreSQL: Fix text search on moved pages [core] - 10https://gerrit.wikimedia.org/r/153565 (https://bugzilla.wikimedia.org/66650) [07:35:01] (03CR) 10Zfilipin: QA: Mark known-failing test so CI goes green (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153547 (owner: 10Spage) [08:08:16] (03CR) 10Nikerabbit: [C: 04-1] Register GadgetResourceLoaderModule with an array (031 comment) [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153539 (owner: 10Legoktm) [08:14:10] 3MediaWiki / 3Page protection: Automatically (?semi-)protect high edit-rate pages (based on some general threshold?) - 10https://bugzilla.wikimedia.org/69426 (10James Forrester) 3NEW p:3Unprio s:3enhanc a:3None Suggestion from user Hydrargyrum on the English Wikipedia: | […] It suggests a possible e... [08:14:39] 3MediaWiki / 3Page protection: Automatically (?semi-)protect high edit-rate pages (based on some general threshold?) - 10https://bugzilla.wikimedia.org/69426 (10James Forrester) p:5Unprio>3Normal [08:21:41] (03PS3) 10SG: Fixes cancel on reply form submitting to no-JS page, and also standardizes cancel button markup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150998 [08:21:47] (03CR) 10jenkins-bot: [V: 04-1] Fixes cancel on reply form submitting to no-JS page, and also standardizes cancel button markup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150998 (owner: 10SG) [08:22:23] 3MediaWiki extensions / 3Translate: Special:MyLanguage should support sections - 10https://bugzilla.wikimedia.org/60545#c2 (10Nemo) (In reply to Ricordisamoa from comment #1) > Maybe the Translate extension should also be able to guess the translated > section title from the original one Recommended usage:... [08:27:21] (03PS4) 10SG: Fixes cancel on reply form submitting to no-JS page, and also standardizes cancel button markup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150998 [08:30:23] 3MediaWiki extensions / 3Scribunto: The wrong variable name is used in require() - 10https://bugzilla.wikimedia.org/69410 (10Andre Klapper) p:5Unprio>3Normal [08:30:53] 3MediaWiki extensions / 3[other]: SwiftMedia's rewrite doesn't properly collapse multiple slashes - 10https://bugzilla.wikimedia.org/32864#c3 (10Andre Klapper) vagababov: If there is some issue somewhere, please create a new ticket and follow https://www.mediawiki.org/wiki/How_to_report_a_bug . Thanks! [08:31:23] 3MediaWiki / 3Language converter: Transliteration of Crimean Wiki - 10https://bugzilla.wikimedia.org/21582#c21 (10Ata) Can someone comment on this? [08:36:38] 3MediaWiki / 3Categories: Sort options for Commons categories - 10https://bugzilla.wikimedia.org/69417#c1 (10Andre Klapper) p:5Unprio>3Low Hi, could you please provide a link to reproduce the problem? [08:38:41] 3Wikimedia / 3Bugzilla: Create a component for UnicodeJS in product "Utilities" - 10https://bugzilla.wikimedia.org/69427 (10James Forrester) 3NEW p:3Unprio s:3normal a:3None UnicodeJS needs somewhere for bugs to go, if rare. [08:40:23] 3Wikimedia / 3Bugzilla: Create a component for UnicodeJS in product "Utilities" - 10https://bugzilla.wikimedia.org/69427#c1 (10Andre Klapper) See https://www.mediawiki.org/wiki/Bug_management/Project_Maintainers#To_add_a_project_or_component for required information [08:40:38] 3Wikimedia / 3Bugzilla: Create a component for UnicodeJS in product "Utilities" - 10https://bugzilla.wikimedia.org/69427#c2 (10James Forrester) 5NEW>3RESO/FIX (Now done.) [08:56:53] 3MediaWiki / 3Skin and page rendering: neutral mw-ui-quiet anchors should lighten on hover and have no outline - 10https://bugzilla.wikimedia.org/69212#c2 (10Shahyar Ghobadpour) 5NEW>3ASSI p:5Unprio>3Low Jon makes a valid argument for introducing mw-ui-anchor. It will make it more consistent with how... [09:01:23] 3MediaWiki / 3Language converter: Transliteration of Crimean Wiki - 10https://bugzilla.wikimedia.org/21582#c22 (10Andre Klapper) (In reply to Ata from comment #21) > Can someone comment on this? What exactly is your question (as I guess you don't want some random comment for the sake of a comment)? It look... [09:04:27] (03PS1) 10Jforrester: Tag v.0.1.1 [unicodejs] - 10https://gerrit.wikimedia.org/r/153567 [09:04:56] (03PS3) 10Dev-zero: Replace deprecated wfMsgHtml/wfMsg by wfMessage [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/153391 (https://bugzilla.wikimedia.org/68750) [09:04:58] (03PS3) 10Dev-zero: Fix modification of section edit link [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/153392 [09:05:00] (03PS3) 10Dev-zero: Replace deprecated makeKnownLinkObj by linkKnown. [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/153393 [09:09:41] (03CR) 10Dev-zero: "Thanks a lot for the helpful explanation!" [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/153391 (https://bugzilla.wikimedia.org/68750) (owner: 10Dev-zero) [09:28:18] (03PS1) 10Vikassy: Added language exception tag to language screenshot job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/153569 [09:29:38] (03CR) 10jenkins-bot: [V: 04-1] Added language exception tag to language screenshot job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/153569 (owner: 10Vikassy) [09:35:10] 3MediaWiki / 3JobRunner: Jobrunner will fail to spawn jobs on HHVM - 10https://bugzilla.wikimedia.org/69428 (10Giuseppe Lavagetto) 3NEW p:3Unprio s:3blocke a:3None Created attachment 16174 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16174&action=edit simple script that reproduces the issue... [09:36:08] 3MediaWiki / 3JobRunner: Jobrunner will fail to spawn jobs on HHVM - 10https://bugzilla.wikimedia.org/69428 (10Giuseppe Lavagetto) [09:37:08] 3MediaWiki / 3JobRunner: Jobrunner will fail to spawn jobs on HHVM - 10https://bugzilla.wikimedia.org/69428#c1 (10Giuseppe Lavagetto) This happens with our packages, of course. [09:39:05] (03PS5) 10SG: Add truncated-text utility mixin [core] - 10https://gerrit.wikimedia.org/r/151792 (owner: 10Jdlrobson) [09:40:43] (03PS2) 10SG: Use core mw-ui-text-truncated [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151789 (owner: 10Jdlrobson) [09:42:44] (03PS2) 10Vikassy: Added language exception tag to language screenshot job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/153569 [09:44:37] (03PS3) 10Vikassy: WIP: Added language exception tag to language screenshot job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/153569 [09:45:05] (03PS3) 10SG: Use core mw-ui text-truncated utility mixin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151789 (owner: 10Jdlrobson) [09:45:34] (03PS4) 10SG: Add mw-ui-text-truncated to overlay and special page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151805 (owner: 10Bsitu) [09:45:38] (03CR) 10jenkins-bot: [V: 04-1] Use core mw-ui text-truncated utility mixin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151789 (owner: 10Jdlrobson) [09:46:28] (03CR) 10jenkins-bot: [V: 04-1] Add mw-ui-text-truncated to overlay and special page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151805 (owner: 10Bsitu) [09:58:04] (03PS2) 10Addshore: Fix phpcs issues in actions and revisiondelete dirs [core] - 10https://gerrit.wikimedia.org/r/153469 [10:00:39] 3MediaWiki extensions / 3Math: generate MathML (not PNG) and automatically embed hyperlinks for each symbol - 10https://bugzilla.wikimedia.org/69424#c4 (10physikerwelt) Hi Richard, I'm extremely interested in your project. Hyperlinks in the formulae are exactly what I want to have a well defined semantics f... [10:01:11] 3MediaWiki extensions / 3Translate: Add parameterless GENDER as insertable - 10https://bugzilla.wikimedia.org/69306 (10Niklas Laxström) a:3Niklas Laxström [10:03:38] 3MediaWiki extensions / 3Translate: "Translate to" dropdown doesn't work; can't select language to translate - 10https://bugzilla.wikimedia.org/69346#c1 (10Niklas Laxström) I'm unable to open those links. Are the sites down? [10:03:49] (03CR) 10SG: "I am confused. Is this actually used anywhere? Only seems to be in MobileFrontend's implmentation of Echo." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151805 (owner: 10Bsitu) [10:05:03] (03CR) 10Nikerabbit: [C: 031] Expose language fallback chain in JavaScript (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153075 (https://bugzilla.wikimedia.org/69285) (owner: 10Bartosz Dziewoński) [10:06:30] (03CR) 10Prtksxna: [C: 04-1] "Yeah. That part needs restructuring and fixing. Let's do that as a separate commit?" (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/148583 (https://bugzilla.wikimedia.org/68417) (owner: 10Spage) [10:16:35] (03PS1) 10Tim Starling: In minifier, preserve comments that start with /*! [core] - 10https://gerrit.wikimedia.org/r/153573 (https://bugzilla.wikimedia.org/36866) [10:20:52] (03PS1) 10Addshore: make mw-core-phpcs-lenient-HEAD voting! [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153575 [10:21:54] (03CR) 10Hoo man: [C: 031] "Hope people don't overuse it, but that's a downstream issue." [core] - 10https://gerrit.wikimedia.org/r/153573 (https://bugzilla.wikimedia.org/36866) (owner: 10Tim Starling) [10:22:13] (03CR) 10Nikerabbit: Ensure override is more specific (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152948 (owner: 10Jdlrobson) [10:23:03] (03PS2) 10Addshore: make mw-core-phpcs-lenient-HEAD voting! [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153575 (https://bugzilla.wikimedia.org/46500) [10:23:38] 3MediaWiki extensions / 3Translate: [PageMigration] Text areas constant heights are not helpful - 10https://bugzilla.wikimedia.org/69308#c1 (10Niklas Laxström) Content translation uses an algorithm to fit both columns to minimum height without scrolling. [10:25:09] (03CR) 10SG: "Nevermind, I finally found it. Wasn't listed as a codependency on here." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151805 (owner: 10Bsitu) [10:28:38] 3MediaWiki extensions / 3Math: generate MathML (not PNG) and automatically embed hyperlinks for each symbol - 10https://bugzilla.wikimedia.org/69424#c5 (10physikerwelt) .. I updated the documentation about that table https://www.mediawiki.org/wiki/Extension:Math/mathlatexml_table It's save to run drop table... [10:30:53] 3Wikimedia / 3Site requests: Disable Media Viewer software feature by default on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69080#c25 (10Steinsplitter) https://commons.wikimedia.org/w/index.php?title=MediaWiki:Gadgets-definition&curid=3185782&diff=131341161&oldid=130142739 FIXED LOCALLY. [10:31:15] oh crap [10:32:14] heh [10:36:21] lol [10:41:10] 3MediaWiki extensions / 3Popups: Hovercard extract should not display an unflagged revision - 10https://bugzilla.wikimedia.org/69430 (10Inkowik) 3NEW p:3Unprio s:3major a:3None The extract of the hovercard should always show the text of the latest ''flagged'' revision instead of the latest revision.... [10:42:21] (03PS2) 10Tim Starling: In minifier, preserve comments that start with /*! [core] - 10https://gerrit.wikimedia.org/r/153573 (https://bugzilla.wikimedia.org/36866) [10:42:23] 3MediaWiki extensions / 3Popups: Hovercard extract should not display an unflagged revision - 10https://bugzilla.wikimedia.org/69430 (10Inkowik) p:5Unprio>3High s:5major>3normal [10:43:50] (03CR) 10Tim Starling: "Rebased (PS1 was accidentally based on an old master)" [core] - 10https://gerrit.wikimedia.org/r/153573 (https://bugzilla.wikimedia.org/36866) (owner: 10Tim Starling) [10:45:15] (03PS1) 10Prtksxna: Stop showing the NavigationPopups options if it isn't available [extensions/Popups] - 10https://gerrit.wikimedia.org/r/153576 [10:46:23] (03CR) 10Prtksxna: Add settings (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140086 (owner: 10Prtksxna) [10:49:15] (03CR) 10Tpt: [C: 032] Changes the mouse wheel direction to zoom [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/153304 (owner: 10Tpt) [10:49:35] (03Merged) 10jenkins-bot: Changes the mouse wheel direction to zoom [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/153304 (owner: 10Tpt) [10:50:23] (03PS1) 10Addshore: Add phplint jobs for 2 skins that were missed [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/153578 [10:51:52] (03PS1) 10Addshore: Add 2 zuul triggers for skins missing them [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153579 [10:52:48] (03PS2) 10Addshore: Add phplint jobs for 2 skins that were missed [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/153578 (https://bugzilla.wikimedia.org/66926) [10:53:01] (03PS2) 10Addshore: Add 2 zuul triggers for skins missing them [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153579 (https://bugzilla.wikimedia.org/66926) [10:53:14] (03PS3) 10Addshore: Add jobs for 2 skins that were missed [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/153578 (https://bugzilla.wikimedia.org/66926) [10:57:33] (03CR) 10Santhosh: [C: 031] Expose language fallback chain in JavaScript [core] - 10https://gerrit.wikimedia.org/r/153075 (https://bugzilla.wikimedia.org/69285) (owner: 10Bartosz Dziewoński) [10:59:16] (03PS1) 10Addshore: Add phplint and jslint to labs-toolabs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/153580 (https://bugzilla.wikimedia.org/63687) [11:02:04] (03PS1) 10Addshore: Add triggers for php and js lint for labsl-toollabs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153581 (https://bugzilla.wikimedia.org/63687) [11:05:05] (03CR) 10Ori.livneh: [C: 032] Fix /resources symbolic link [vagrant] - 10https://gerrit.wikimedia.org/r/153553 (https://bugzilla.wikimedia.org/69421) (owner: 10Mattflaschen) [11:05:11] (03Merged) 10jenkins-bot: Fix /resources symbolic link [vagrant] - 10https://gerrit.wikimedia.org/r/153553 (https://bugzilla.wikimedia.org/69421) (owner: 10Mattflaschen) [11:05:53] (03PS2) 10Ori.livneh: Revert "Travis CI: Drop 5.3 as a build target" [core] - 10https://gerrit.wikimedia.org/r/153439 (owner: 10Addshore) [11:06:06] (03CR) 10Ori.livneh: [C: 032] Revert "Travis CI: Drop 5.3 as a build target" [core] - 10https://gerrit.wikimedia.org/r/153439 (owner: 10Addshore) [11:07:53] 3Wikimedia / 3Site requests: Disable Media Viewer software feature by default on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69080#c26 (10John F. Lewis) Hacked locally. Still needs to be fixed correctly per Erik. Please use the other bug. [11:08:46] (03CR) 10Alex Monk: [C: 032] "Per I910ca144" [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153537 (owner: 10Legoktm) [11:08:52] (03Merged) 10jenkins-bot: ApiQueryGadgetPages: Remove deprecated getVersion() [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153537 (owner: 10Legoktm) [11:09:31] (03Merged) 10jenkins-bot: Revert "Travis CI: Drop 5.3 as a build target" [core] - 10https://gerrit.wikimedia.org/r/153439 (owner: 10Addshore) [11:10:23] 3MediaWiki extensions / 3EducationProgram: EducationProgram needs tests in Jenkins - 10https://bugzilla.wikimedia.org/56962#c5 (10Addshore) 5NEW>3RESO/FIX This has been done and everything is passing etc. :) https://integration.wikimedia.org/ci/job/mwext-EducationProgram-testextensions-master/ [11:10:33] (03PS4) 10Addshore: PHP Unit tests for Annotation Repository [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/81555 (owner: 10Rjain) [11:18:55] (03CR) 10Hoo man: "Some style comments, nothing important. Didn't really look at the whole thing (also I doubt I really can sign this off... not into this en" (033 comments) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153016 (https://bugzilla.wikimedia.org/69099) (owner: 1001tonythomas) [11:22:30] (03CR) 10Fomafix: [C: 031] Expose language fallback chain in JavaScript [core] - 10https://gerrit.wikimedia.org/r/153075 (https://bugzilla.wikimedia.org/69285) (owner: 10Bartosz Dziewoński) [11:22:45] I updated to the latest vagrant and mw, grabbed the latest Vector, and now my MW frequently stalls on loading vector CSS and JS [11:22:55] only solution seems to be to kill all apache instances and restart it [11:23:10] but it happens again a few minutes later [11:26:02] (03CR) 10Alex Monk: Convert Gadget definition namespace to use ContentHandler (031 comment) [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153270 (https://bugzilla.wikimedia.org/69318) (owner: 10Legoktm) [11:26:04] (03PS4) 10SG: Use core mw-ui text-truncated utility mixin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151789 (owner: 10Jdlrobson) [11:26:08] (03PS6) 10SG: Add truncated-text utility mixin [core] - 10https://gerrit.wikimedia.org/r/151792 (owner: 10Jdlrobson) [11:26:45] (03CR) 10jenkins-bot: [V: 04-1] Use core mw-ui text-truncated utility mixin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151789 (owner: 10Jdlrobson) [11:32:11] (03PS14) 1001tonythomas: Fixed various issues with the BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153016 (https://bugzilla.wikimedia.org/69099) [11:33:20] (03CR) 10Krinkle: [C: 031] In minifier, preserve comments that start with /*! [core] - 10https://gerrit.wikimedia.org/r/153573 (https://bugzilla.wikimedia.org/36866) (owner: 10Tim Starling) [11:35:43] 3MediaWiki extensions / 3[other]: [Various] Deprecated: Use of wfMsg* was deprecated in MediaWiki 1.21 - 10https://bugzilla.wikimedia.org/68750 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Some poor extensions are so neglected by their parents that still have some of the ugliest wfMsg* stuff which was d... [11:35:53] 3MediaWiki extensions / 3LiquidThreads: Cannot anonymously edit/change content of a LQT message but its title - 10https://bugzilla.wikimedia.org/65190#c13 (10paladox2015) The consul says HTML1300: Navigation occurred. File: Project:Support_desk DOM7011: The code on this page disabled back and forward cachin... [11:35:57] 3MediaWiki-Vagrant: Vagrant rebuild fails on Windows - Could not set 'link' on ensure: Protocol error - 10https://bugzilla.wikimedia.org/69425 (10Yuri Astrakhan) 3NEW p:3Unprio s:3normal a:3Ori Livneh Was working fine, did a git pull / vagrant provision. Massive failure, so did vagrant destroy - failed... [11:37:23] 3MediaWiki / 3JavaScript: ResourceLoader: HTTP requests serving minified builds of javascript files should include convey license information - 10https://bugzilla.wikimedia.org/36866 (10Krinkle) [11:37:53] 3MediaWiki / 3JavaScript: ResourceLoader: Convey license information in HTTP requests serving minified builds of javascript files - 10https://bugzilla.wikimedia.org/36866 (10Krinkle) [11:38:25] (03CR) 10Siebrand: "Pretty cool stuff." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/153399 (owner: 10Addshore) [11:42:23] 3MediaWiki / 3General/Unknown: [hhvm] class alias broken with interfaces and abstract classes - 10https://bugzilla.wikimedia.org/69196#c1 (10Aude) this appears to be fixed when running tests on travis (and on vagrant, with hhvm) [11:43:12] (03CR) 10Krinkle: [C: 04-1] "In practice these mini /*! headers are only used on minified files, not development files. Consider this minifier runs on the development " [core] - 10https://gerrit.wikimedia.org/r/153573 (https://bugzilla.wikimedia.org/36866) (owner: 10Tim Starling) [11:44:23] (03CR) 10Krinkle: "Examples:" [core] - 10https://gerrit.wikimedia.org/r/153573 (https://bugzilla.wikimedia.org/36866) (owner: 10Tim Starling) [11:44:52] (03CR) 10Krinkle: [C: 04-1] Refactor ValidGlobalNameSniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/153314 (owner: 10Addshore) [11:47:53] (03PS3) 10SG: Flow notification item new style [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151537 (owner: 10Bsitu) [11:48:10] 3MediaWiki extensions / 3WikidataRepo: [hhvm] test failures and bugs related to claim guids in Claims (ArrayObject) - 10https://bugzilla.wikimedia.org/69431 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs When using hhvm, there are various tests failures, as well as issues when editing claims on b... [11:49:47] (03PS2) 10Addshore: Make travis notifications go to #mediawiki-feed [core] - 10https://gerrit.wikimedia.org/r/131501 [11:50:53] 3MediaWiki extensions / 3WikidataRepo: [hhvm] test failures and bugs related to claim guids in Claims (ArrayObject) - 10https://bugzilla.wikimedia.org/69431#c1 (10Aude) 5NEW>3PATC https://github.com/facebook/hhvm/pull/3404 [11:52:40] (03PS2) 10Addshore: Refactor ValidGlobalNameSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/153314 [11:52:45] (03PS3) 10Addshore: Add phpcs standard to detect usage of stuff removed in mwcore [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/153399 [12:02:32] (03PS5) 10SG: Automatically truncate text with ellipsis on single lines of title, and add new mw-echo-title-heading helper class [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151805 (owner: 10Bsitu) [12:03:21] (03CR) 10SG: [C: 04-1] Automatically truncate text with ellipsis on single lines of title, and add new mw-echo-title-heading helper class [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151805 (owner: 10Bsitu) [12:08:17] (03PS2) 10Jforrester: Tag v0.1.1 [unicodejs] - 10https://gerrit.wikimedia.org/r/153567 [12:11:08] (03PS6) 10SG: Automatically truncate text with ellipsis on single lines of title, and add new mw-echo-title-heading helper class [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151805 (owner: 10Bsitu) [12:11:32] (03CR) 10jenkins-bot: [V: 04-1] Automatically truncate text with ellipsis on single lines of title, and add new mw-echo-title-heading helper class [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151805 (owner: 10Bsitu) [12:11:53] (03PS3) 10Jforrester: Tag v0.1.1 [unicodejs] - 10https://gerrit.wikimedia.org/r/153567 [12:12:28] (03PS1) 10Prtksxna: Use `mw.popups.settings.navPopEnabled` instead of repeating the condition [extensions/Popups] - 10https://gerrit.wikimedia.org/r/153588 [12:13:23] (03CR) 10Prtksxna: Add settings (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140086 (owner: 10Prtksxna) [12:15:14] (03CR) 10Krinkle: [C: 032] Make travis notifications go to #mediawiki-feed [core] - 10https://gerrit.wikimedia.org/r/131501 (owner: 10Addshore) [12:16:02] (03PS4) 10Hashar: Add jobs for 2 skins that were missing [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/153578 (https://bugzilla.wikimedia.org/66926) (owner: 10Addshore) [12:16:07] (03PS5) 10Hashar: Add jobs for 2 skins that were missing [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/153578 (https://bugzilla.wikimedia.org/66926) (owner: 10Addshore) [12:16:37] (03CR) 10Hashar: [C: 032] Add jobs for 2 skins that were missing [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/153578 (https://bugzilla.wikimedia.org/66926) (owner: 10Addshore) [12:17:21] (03CR) 10Krinkle: "Travis supports marking one or more build matrix cells as allowed failure. Having the information can still be useful. Especially consider" [core] - 10https://gerrit.wikimedia.org/r/140869 (owner: 10Ori.livneh) [12:17:52] (03Merged) 10jenkins-bot: Make travis notifications go to #mediawiki-feed [core] - 10https://gerrit.wikimedia.org/r/131501 (owner: 10Addshore) [12:17:59] (03CR) 10Krinkle: [C: 032] Stop showing the NavigationPopups options if it isn't available [extensions/Popups] - 10https://gerrit.wikimedia.org/r/153576 (owner: 10Prtksxna) [12:18:01] (03CR) 10Hashar: "Jenkins updated:" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/153578 (https://bugzilla.wikimedia.org/66926) (owner: 10Addshore) [12:18:36] (03Merged) 10jenkins-bot: Stop showing the NavigationPopups options if it isn't available [extensions/Popups] - 10https://gerrit.wikimedia.org/r/153576 (owner: 10Prtksxna) [12:18:38] (03Merged) 10jenkins-bot: Add jobs for 2 skins that were missing [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/153578 (https://bugzilla.wikimedia.org/66926) (owner: 10Addshore) [12:18:50] (03CR) 10Hashar: [C: 032] "Jenkins jobs deployed:" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153579 (https://bugzilla.wikimedia.org/66926) (owner: 10Addshore) [12:19:01] (03Merged) 10jenkins-bot: Add 2 zuul triggers for skins missing them [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153579 (https://bugzilla.wikimedia.org/66926) (owner: 10Addshore) [12:21:26] (03CR) 10Hashar: "recheck" [skins/Vector] - 10https://gerrit.wikimedia.org/r/153278 (owner: 10Bartosz Dziewoński) [12:21:54] (03CR) 10Krinkle: "FIXME: The path to extension is hardcoded in a way that will bypass bits.wikimedia.org and will actually break for non-Wikimedia wikis." (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140086 (owner: 10Prtksxna) [12:26:06] (03CR) 10Alex Monk: [C: 04-1] "Also deletion seems to be broken" [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153270 (https://bugzilla.wikimedia.org/69318) (owner: 10Legoktm) [12:37:39] (03PS2) 10Matthias Mullie: Subscribe to board = auto-subscribe to new topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153411 [12:38:18] (03CR) 10jenkins-bot: [V: 04-1] Subscribe to board = auto-subscribe to new topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153411 (owner: 10Matthias Mullie) [12:39:37] (03CR) 10Alex Monk: "That is, I found that my style (which I had just deleted the gadget definition for) was showing up while I had this commit." [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153270 (https://bugzilla.wikimedia.org/69318) (owner: 10Legoktm) [12:39:41] (03PS1) 10Prtksxna: Replace hardcoded path with `wgExtensionAssetsPath` [extensions/Popups] - 10https://gerrit.wikimedia.org/r/153590 [12:40:31] (03CR) 10Prtksxna: Add settings (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140086 (owner: 10Prtksxna) [12:42:44] (03PS2) 10Hashar: Add phplint and jslint to labs-toolabs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/153580 (https://bugzilla.wikimedia.org/63687) (owner: 10Addshore) [12:42:54] (03PS2) 10Hashar: Add triggers for php and js lint for labsl-toollabs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153581 (https://bugzilla.wikimedia.org/63687) (owner: 10Addshore) [12:43:13] (03PS4) 10Krinkle: Tag v0.1.1 [unicodejs] - 10https://gerrit.wikimedia.org/r/153567 (owner: 10Jforrester) [12:43:15] (03CR) 10Krinkle: Tag v0.1.1 (033 comments) [unicodejs] - 10https://gerrit.wikimedia.org/r/153567 (owner: 10Jforrester) [12:43:33] (03PS1) 10Vikassy: Added more languages [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/153591 [12:44:08] (03CR) 10Hashar: [C: 032] "Jobs configured:" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/153580 (https://bugzilla.wikimedia.org/63687) (owner: 10Addshore) [12:44:39] (03PS2) 10Vikassy: Added more languages to screenshot job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/153591 [12:47:07] (03PS3) 10Vikassy: Added more languages to language screenshot job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/153591 [12:48:05] (03CR) 10Hashar: [C: 04-1] "I am not entirely sure the job is needed since that repository only has third party JavaScript libraries which does not pass jshint." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153581 (https://bugzilla.wikimedia.org/63687) (owner: 10Addshore) [12:49:14] hey Nemo_bis, when you get a moment, could you verify that this bug has been fixed for you https://bugzilla.wikimedia.org/show_bug.cgi?id=68637. thanks! [12:50:24] dan-nl: I'm fairly confident that fixed it but I'll only test again in few weeks I think [12:50:37] (so I closed the bug) [12:50:43] thanks [12:51:14] (03CR) 10Brian Wolff: "Re lego: yeah thats valid." [core] - 10https://gerrit.wikimedia.org/r/153362 (https://bugzilla.wikimedia.org/69380) (owner: 10Parent5446) [12:52:45] (03Merged) 10jenkins-bot: Add phplint and jslint to labs-toolabs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/153580 (https://bugzilla.wikimedia.org/63687) (owner: 10Addshore) [12:53:12] (03Abandoned) 10Aude: Initial role for wikibase [vagrant] - 10https://gerrit.wikimedia.org/r/149534 (owner: 10Aude) [12:53:17] (03CR) 10Zfilipin: [C: 032] Added more languages to language screenshot job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/153591 (owner: 10Vikassy) [12:53:23] 3MediaWiki extensions / 3Translate: "Translate to" dropdown doesn't work; can't select language to translate - 10https://bugzilla.wikimedia.org/69346#c2 (10Nemo) Yes they are. --- prod4.orain.org ping statistics --- 51 packets transmitted, 0 received, 100% packet loss, time 50000ms [12:54:54] (03Merged) 10jenkins-bot: Added more languages to language screenshot job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/153591 (owner: 10Vikassy) [13:12:08] 3Mathoid / 3General/Unknown: Initial Mathoid deployment - 10https://bugzilla.wikimedia.org/69298#c6 (10Alexandros Kosiaris) Hello, in the interests of moving forward I did the extra deploy and now the service replies successfully to the curl command provided above. However me being a SPOF in the process obvi... [13:19:50] (03CR) 10Jforrester: [C: 031] Tag v0.1.1 [unicodejs] - 10https://gerrit.wikimedia.org/r/153567 (owner: 10Jforrester) [13:20:15] (03PS5) 10Krinkle: Tag v0.1.1 [unicodejs] - 10https://gerrit.wikimedia.org/r/153567 (owner: 10Jforrester) [13:20:48] (03CR) 10Krinkle: [C: 032] Tag v0.1.1 [unicodejs] - 10https://gerrit.wikimedia.org/r/153567 (owner: 10Jforrester) [13:22:18] (03Merged) 10jenkins-bot: Tag v0.1.1 [unicodejs] - 10https://gerrit.wikimedia.org/r/153567 (owner: 10Jforrester) [13:24:15] (03Abandoned) 10Matthias Mullie: Allow phpunit.phar to be passed as --with-phpunitdir [core] - 10https://gerrit.wikimedia.org/r/142246 (owner: 10Matthias Mullie) [13:27:53] 3Wikimedia / 3Deployment systems: MWMultiVersion can fatal for bad Host headers - 10https://bugzilla.wikimedia.org/69419#c2 (10Antoine "hashar" Musso) That is the expected behavior and has been around for a while. The patch https://gerrit.wikimedia.org/r/#/c/153593/ adds a PHPUnit test for it. [13:36:12] (03CR) 10Krinkle: [C: 032] Replace hardcoded path with `wgExtensionAssetsPath` [extensions/Popups] - 10https://gerrit.wikimedia.org/r/153590 (owner: 10Prtksxna) [13:36:37] (03Merged) 10jenkins-bot: Replace hardcoded path with `wgExtensionAssetsPath` [extensions/Popups] - 10https://gerrit.wikimedia.org/r/153590 (owner: 10Prtksxna) [13:37:15] (03PS3) 10Matthias Mullie: Subscribe to board = auto-subscribe to new topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153411 [13:37:56] (03CR) 10jenkins-bot: [V: 04-1] Subscribe to board = auto-subscribe to new topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153411 (owner: 10Matthias Mullie) [13:42:07] (03PS4) 10Matthias Mullie: Subscribe to board = auto-subscribe to new topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153411 [13:42:50] (03PS1) 10Krinkle: jquery.removeCtrl: Remove very very very dead and very wrong code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153595 [13:43:31] (03CR) 10Jforrester: [C: 032] jquery.removeCtrl: Remove very very very dead and very wrong code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153595 (owner: 10Krinkle) [13:43:58] (03Merged) 10jenkins-bot: jquery.removeCtrl: Remove very very very dead and very wrong code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153595 (owner: 10Krinkle) [13:51:42] (03CR) 10Hashar: [C: 04-1] "Change depends on rubocop being made available on the Jenkins slaves which is https://rt.wikimedia.org/Ticket/Display.html?id=8103" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152926 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [13:52:23] 3MediaWiki / 3General/Unknown: Investigate whether taking an action on a page (delete, import, etc.) should require being able to edit it - 10https://bugzilla.wikimedia.org/69380#c18 (10Tim Starling) (In reply to Tyler Romeo from comment #4) > 2) It makes certain workflows (as mentioned in gerrit) impossible... [13:56:20] (03CR) 10Hashar: [C: 04-1] "It is going to fail on non master branches. So the voting: false should be replaced with a branch selector that looks more or less like:" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153575 (https://bugzilla.wikimedia.org/46500) (owner: 10Addshore) [14:01:22] (03CR) 10Matthias Mullie: Move watch star for boards next to the header. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149210 (owner: 10Werdna) [14:04:25] 3MediaWiki / 3Maintenance scripts: mwscript instead of php to run maitenance scripts - 10https://bugzilla.wikimedia.org/69434 (10physikerwelt) 3NEW p:3Unprio s:3normal a:3None update.php contains the header #!/usr/bin/env php but now mwscript is supposed to be used https://www.mediawiki.org/w/ind... [14:05:39] 3MediaWiki / 3General/Unknown: [regression] Editability requirement made deletion of translation pages impossible - 10https://bugzilla.wikimedia.org/69398#c3 (10Nemo) To clarify, the actual moving or deleting is performed by the extension under FuzzyBot's name (using the job queue). [[mw:Special:Log/FuzzyBot]] [14:06:50] (03PS1) 10Physikerwelt: WIP: run update.php with mwscript [core] - 10https://gerrit.wikimedia.org/r/153601 (https://bugzilla.wikimedia.org/69434) [14:12:39] 3Mathoid / 3General/Unknown: Initial Mathoid deployment - 10https://bugzilla.wikimedia.org/69298 (10physikerwelt) 5NEW>3RESO/FIX [14:13:38] 3Mathoid / 3General/Unknown: Initial Mathoid deployment - 10https://bugzilla.wikimedia.org/69298#c7 (10physikerwelt) Thank you very much Alexandros, I'll file a follow up ticket. [14:15:38] (03CR) 10Hoo man: "mh" (033 comments) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153403 (https://bugzilla.wikimedia.org/69099) (owner: 1001tonythomas) [14:18:25] 3Mathoid / 3General/Unknown: obtain access to deployment-bastion.eqiad.wmflabs - 10https://bugzilla.wikimedia.org/69435 (10physikerwelt) 3NEW p:3Unprio s:3normal a:3None As described in bug 69298 akosiaris proposes that I should obtain access to deployment-bastion.eqiad.wmflabs in order to deploy mat... [14:20:08] 3Mathoid / 3General/Unknown: obtain access to deployment-bastion.eqiad.wmflabs - 10https://bugzilla.wikimedia.org/69435 (10physikerwelt) s:5normal>3minor [14:21:20] (03CR) 10Hoo man: [C: 04-1] Generate VERP address for a single/array of recipient addresses (031 comment) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153403 (https://bugzilla.wikimedia.org/69099) (owner: 1001tonythomas) [14:27:36] (03PS1) 10All1: Redirected texvc.js and wiki2jax.js to modules directory [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [14:27:41] (03CR) 10jenkins-bot: [V: 04-1] Redirected texvc.js and wiki2jax.js to modules directory [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [14:30:32] (03PS1) 10Matthias Mullie: Fix notice for sectionId key not existing [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153604 [14:31:55] (03CR) 10Tim Starling: [C: 04-1] "I don't think delete/recreate cycles are an appropriate part of a wheel war, so I don't think this can be merged before some other solutio" [core] - 10https://gerrit.wikimedia.org/r/153362 (https://bugzilla.wikimedia.org/69380) (owner: 10Parent5446) [14:34:53] 3MediaWiki extensions / 3Math: generate MathML (not PNG) and automatically embed hyperlinks for each symbol - 10https://bugzilla.wikimedia.org/69424#c6 (10Richard Baxter) Created attachment 16175 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16175&action=edit mathMLelementsWikipediaLinks.txt [14:35:39] 3MediaWiki extensions / 3Math: generate MathML (not PNG) and automatically embed hyperlinks for each symbol - 10https://bugzilla.wikimedia.org/69424#c7 (10Richard Baxter) Created attachment 16176 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16176&action=edit mathMLsymbolsWikipediaLinks.txt [14:48:45] anyone happen to know the best way to create a null edit on a template title? [14:48:58] (03CR) 10Hoo man: [C: 032] "Tables yet exist in production, so make sure we add them to new wikis." [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/135522 (https://bugzilla.wikimedia.org/65793) (owner: 10Physikerwelt) [14:49:05] (03Merged) 10jenkins-bot: Add table for new math renderer Mathoid [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/135522 (https://bugzilla.wikimedia.org/65793) (owner: 10Physikerwelt) [14:49:54] 3MediaWiki extensions / 3Math: Add separate database tables for Mathoid - 10https://bugzilla.wikimedia.org/65793 (10physikerwelt) 5PATC>3RESO/FIX [14:55:05] (03CR) 10Florianschmidtwelzow: [C: 031] Replace deprecated wfMsgHtml/wfMsg by wfMessage [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/153391 (https://bugzilla.wikimedia.org/68750) (owner: 10Dev-zero) [15:01:50] (03CR) 10Florianschmidtwelzow: [C: 04-1] Fix modification of section edit link (032 comments) [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/153392 (owner: 10Dev-zero) [15:04:14] (03CR) 10Revi: "@Tim Starling: You meant bug 69380?" [core] - 10https://gerrit.wikimedia.org/r/153362 (https://bugzilla.wikimedia.org/69380) (owner: 10Parent5446) [15:05:10] 3MediaWiki extensions / 3WikidataRepo: Fatal error: Call to undefined method Wikibase\DataModel\Entity\Item::toArray() - 10https://bugzilla.wikimedia.org/69436 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs atal error: Call to undefined method Wikibase\DataModel\Entity\Item::toArray() in /Library... [15:05:44] (03PS4) 10Dev-zero: Fix modification of section edit link [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/153392 [15:05:46] (03PS4) 10Dev-zero: Replace deprecated makeKnownLinkObj by linkKnown. [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/153393 [15:08:53] (03PS2) 10All1: Moved texvc.js and wiki2jax.js to extensions/Math/modules directory for MathJax update [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [15:08:57] (03CR) 10jenkins-bot: [V: 04-1] Moved texvc.js and wiki2jax.js to extensions/Math/modules directory for MathJax update [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [15:09:27] (03PS2) 10Jdlrobson: E2d: Add the mark as read button to messages view [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153556 [15:09:30] (03PS1) 10Jdlrobson: WIP: Restructure code so MobileFrontend can make use of it [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153613 [15:09:56] (03CR) 10jenkins-bot: [V: 04-1] WIP: Restructure code so MobileFrontend can make use of it [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153613 (owner: 10Jdlrobson) [15:11:20] (03PS5) 10Jdlrobson: E2b: Reflect the count in alerts and messages tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153532 [15:11:39] 3Wikimedia / 3General/Unknown: Add mathoid database table - 10https://bugzilla.wikimedia.org/66492 (10physikerwelt) 5PATC>3RESO/FIX [15:11:46] (03PS5) 10Jdlrobson: E2c: Hover behaviour of notifications panel tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153546 [15:12:01] (03PS3) 10Jdlrobson: E2d: Add the mark as read button to messages view [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153556 [15:12:14] (03PS2) 10Jdlrobson: WIP: Restructure code so MobileFrontend can make use of it [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153613 [15:12:39] (03CR) 10jenkins-bot: [V: 04-1] WIP: Restructure code so MobileFrontend can make use of it [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153613 (owner: 10Jdlrobson) [15:19:15] (03PS30) 10Jdlrobson: Add blanket support for mediawiki ui via globals [core] - 10https://gerrit.wikimedia.org/r/150635 [15:19:23] 3MediaWiki extensions / 3Popups: Hovercard extract should not display an unflagged revision - 10https://bugzilla.wikimedia.org/69430 (10Andre Klapper) p:5High>3Unprio [15:19:54] (03PS2) 10Prtksxna: Use `mw.popups.settings.navPopEnabled` instead of repeating the condition [extensions/Popups] - 10https://gerrit.wikimedia.org/r/153588 [15:20:27] (03PS3) 10All1: Moved texvc.js and wiki2jax.js to extensions/Math/modules directory for MathJax update [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [15:20:31] (03CR) 10jenkins-bot: [V: 04-1] Moved texvc.js and wiki2jax.js to extensions/Math/modules directory for MathJax update [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [15:22:58] (03PS31) 10Jdlrobson: Add blanket support for mediawiki ui via globals [core] - 10https://gerrit.wikimedia.org/r/150635 [15:24:20] (03PS1) 10Matthias Mullie: (bug 69416) Chrome & Safari - posting a reply loads a new broken URL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153617 (https://bugzilla.wikimedia.org/69416) [15:24:23] 3MediaWiki / 3Maintenance scripts: mwscript instead of php to run maintenance scripts - 10https://bugzilla.wikimedia.org/69434 (10Andre Klapper) p:5Unprio>3Normal [15:26:13] (03CR) 10jenkins-bot: [V: 04-1] Add blanket support for mediawiki ui via globals [core] - 10https://gerrit.wikimedia.org/r/150635 (owner: 10Jdlrobson) [15:29:08] 3MediaWiki / 3Skin and page rendering: hide redirect notice when printing articles - 10https://bugzilla.wikimedia.org/16296#c2 (10Andre Klapper) Confirming that this is still an issue in 1.24, with https://en.wikipedia.org/wiki/Michael_jackson when just going to "File > Print" in my browser. Same for "Printa... [15:34:50] (03CR) 10PleaseStand: [C: 04-1] "mwscript is a Wikimedia-specific script that is not part of MediaWiki core and would not exist in most third-party installations (excludin" [core] - 10https://gerrit.wikimedia.org/r/153601 (https://bugzilla.wikimedia.org/69434) (owner: 10Physikerwelt) [15:39:29] (03PS4) 10All1: Moved texvc.js and wiki2jax.js to extensions/Math/modules directory for MathJax update [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [15:39:32] (03CR) 10jenkins-bot: [V: 04-1] Moved texvc.js and wiki2jax.js to extensions/Math/modules directory for MathJax update [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [15:40:23] 3MediaWiki extensions / 3WikidataRepo: Fatal error: Call to undefined method Wikibase\DataModel\Entity\Item::toArray() - 10https://bugzilla.wikimedia.org/69436#c1 (10Aude) 5NEW>3RESO/WOR had data model master checked out. it is incompatible with wikibase at the moment [15:40:38] (03PS5) 10All1: Moved texvc.js and wiki2jax.js to extensions/Math/modules directory for MathJax update [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [15:40:41] (03CR) 10jenkins-bot: [V: 04-1] Moved texvc.js and wiki2jax.js to extensions/Math/modules directory for MathJax update [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [15:43:55] (03PS3) 1001tonythomas: Generate VERP address for a single/array of recipient addresses [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153403 (https://bugzilla.wikimedia.org/69099) [15:44:27] 3MediaWiki / 3Revision deletion: Split suppressrevision in two distinct permissions : the first one to oversight content, and the other one to review oversighted content - 10https://bugzilla.wikimedia.org/20476#c19 (10Trijnstel) One thing was forgotten, I think. The stewards are still able to oversight abuse... [15:44:41] (03CR) 1001tonythomas: "Fixed.! Thanks Hoo. Looks good now ?" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153403 (https://bugzilla.wikimedia.org/69099) (owner: 1001tonythomas) [15:48:54] (03PS1) 10Jackmcbarn: Test only against protection for deleting [core] - 10https://gerrit.wikimedia.org/r/153619 (https://bugzilla.wikimedia.org/69380) [15:54:54] (03Abandoned) 10Physikerwelt: WIP: run update.php with mwscript [core] - 10https://gerrit.wikimedia.org/r/153601 (https://bugzilla.wikimedia.org/69434) (owner: 10Physikerwelt) [15:55:53] 3MediaWiki / 3Maintenance scripts: mwscript instead of php to run maintenance scripts - 10https://bugzilla.wikimedia.org/69434#c3 (10physikerwelt) 5PATC>3RESO/WON Applies to vagrant only [16:05:23] 3MediaWiki / 3Page protection: Using $wgRevokePermissions doesn't revoke protection permissions when the 'editprotected' permission is assigned - 10https://bugzilla.wikimedia.org/27152 (10Brad Jorsch) 5NEW>3RESO/FIX [16:17:04] (03CR) 10Physikerwelt: [C: 04-1] Moved texvc.js and wiki2jax.js to extensions/Math/modules directory for MathJax update (036 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [16:18:57] (03PS3) 10Umherirrender: Remove return from Action::checkCanExecute [core] - 10https://gerrit.wikimedia.org/r/151437 [16:19:58] (03CR) 10Umherirrender: "Patch Set 3: release notes" [core] - 10https://gerrit.wikimedia.org/r/151437 (owner: 10Umherirrender) [16:21:39] 3MediaWiki extensions / 3Math: generate MathML (not PNG) and automatically embed hyperlinks for each symbol - 10https://bugzilla.wikimedia.org/69424 (10physikerwelt) a:3physikerwelt [16:23:53] 3Mathoid / 3General/Unknown: Mathoid: package node jsdom module - 10https://bugzilla.wikimedia.org/68099 (10physikerwelt) [16:24:23] 3Mathoid / 3General/Unknown: Mathoid: package node jsdom module - 10https://bugzilla.wikimedia.org/68099 (10physikerwelt) 5PATC>3NEW [16:26:24] 3Wikimedia / 3Site requests: Add domains to $wgCopyUploadsDomains (tracking) - 10https://bugzilla.wikimedia.org/58224 (10Lokal_Profil) [16:26:25] 3Wikimedia / 3Site requests: Add two swedish to wgCopyUploadsDomains for Commons - 10https://bugzilla.wikimedia.org/69439 (10Lokal_Profil) 3NEW p:3Unprio s:3normal a:3None Please add the following domain(s) to the wgCopyUploadsDomains whitelist: https://data.kb.se/datasets/* http://kmb.raa.se/cocoon... [16:31:08] 3MediaWiki-Vagrant: Debug mode is broken - 10https://bugzilla.wikimedia.org/69421 (10Matthew Flaschen) 5PATC>3RESO/FIX [16:37:44] (03PS3) 10Jdlrobson: X on notification item to mark as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153529 (owner: 10Bsitu) [16:37:49] (03CR) 10Tim Starling: "Yes, sorry." [core] - 10https://gerrit.wikimedia.org/r/153362 (https://bugzilla.wikimedia.org/69380) (owner: 10Parent5446) [16:40:35] (03PS4) 10Jdlrobson: WIP: X on notification item to mark as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153529 (owner: 10Bsitu) [16:42:09] (03PS4) 10Jdlrobson: E2d: Add the mark as read button to messages view [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153556 [16:42:41] (03CR) 10Anomie: [C: 04-1] "We should probably wait for an actual decision instead of just jumping on one of the three options Tim proposed there." [core] - 10https://gerrit.wikimedia.org/r/153619 (https://bugzilla.wikimedia.org/69380) (owner: 10Jackmcbarn) [16:44:03] (03PS20) 10Jdlrobson: Notification overlay Messages and Alerts sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152165 [16:46:45] (03PS2) 10Jdlrobson: Show count in Notification overlay tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153531 [16:47:03] (03Abandoned) 10Jdlrobson: Show count in Notification overlay tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153531 (owner: 10Jdlrobson) [16:47:07] (03PS6) 10Jdlrobson: E2b: Reflect the count in alerts and messages tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153532 [16:48:59] (03CR) 10Se4598: Add phpcs standard to detect usage of stuff removed in mwcore (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/153399 (owner: 10Addshore) [16:57:01] (03CR) 10Florianschmidtwelzow: [C: 04-1] Fix modification of section edit link (031 comment) [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/153392 (owner: 10Dev-zero) [16:57:03] (03PS6) 10Jdlrobson: E2c: Hover behaviour of notifications panel tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153546 [16:57:08] (03PS5) 10Jdlrobson: E2d: Add the mark as read button to messages view [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153556 [16:57:41] 3MediaWiki extensions / 3CodeEditor: CodeEditor deletes the wrong character when the user presses backspace - 10https://bugzilla.wikimedia.org/69440 (10Helder) 3NEW p:3Unprio s:3normal a:3None Created attachment 16178 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16178&action=edit Screencast... [17:03:46] TimStarling: when you said a careful implementation would allow switching from 3 to 2, what specifically would that entail? [17:04:20] (03CR) 10Anomie: "Code-wise it looks like it functions well, although it doesn't provide the "A careful implementation of this option would allow future mig" [core] - 10https://gerrit.wikimedia.org/r/153619 (https://bugzilla.wikimedia.org/69380) (owner: 10Jackmcbarn) [17:05:16] anomie: (what timing...) do you know what ^ that would entail? [17:05:38] 3MediaWiki / 3General/Unknown: Investigate whether taking an action on a page (delete, import, etc.) should require being able to edit it - 10https://bugzilla.wikimedia.org/69380#c20 (10Brad Jorsch) (In reply to Tim Starling from comment #18) > Option 3 has a convenient UI and a > good migration path, but th... [17:06:23] 3Wikimedia / 3Site requests: Add two swedish URLs to wgCopyUploadsDomains for Commons - 10https://bugzilla.wikimedia.org/69439 (10Andre Klapper) p:5Unprio>3Normal [17:07:05] (03PS5) 10tosfos: major code rewrite [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/144631 [17:07:29] jackmcbarn: Presumably the "careful implementation" would have to somehow or other change the UI to add delete=X for every edit=X, rather than just checking for edit=X on deletion. Otherwise there's no difference between a migration from the current option 1 to option 2 and from option 3 to option 2. [17:07:29] (03CR) 10tosfos: [C: 032 V: 032] major code rewrite [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/144631 (owner: 10tosfos) [17:08:26] it was mostly just intuition, I didn't have a fully formed idea about it [17:08:58] but I thought that if you design both features then you will know if one precludes the other [17:09:02] that seems like it's supposed to be a grandfather clause, but it wouldn't apply to things in the past, only things between the time we went from 3 to 2 [17:09:07] ori around? vagrant seems to be badly broken on windows [17:09:08] (and i'm not sure how useful that would be) [17:09:46] (03CR) 10Umherirrender: "Now ignored by phpcs commands in I16d19de3d2b2461a68030afd3a79aa59c9e948d4" [core] - 10https://gerrit.wikimedia.org/r/149382 (owner: 10Umherirrender) [17:09:59] (03CR) 10Umherirrender: "Now ignored by phpcs commands in I16d19de3d2b2461a68030afd3a79aa59c9e948d4" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/151593 (owner: 10Umherirrender) [17:10:35] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Thanks for work on this :)" (039 comments) [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/153393 (owner: 10Dev-zero) [17:12:54] (03CR) 10Cmcmahon: [C: 032] Chrome 28 is the last version that works properly on Sauce Labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/153408 (https://bugzilla.wikimedia.org/69399) (owner: 10Zfilipin) [17:13:08] (03PS4) 10SG: Flow notification item new style [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151537 (owner: 10Bsitu) [17:18:10] 3MediaWiki extensions / 3Scribunto: Feature request: add detection for disambiguation pages to Scribunto - 10https://bugzilla.wikimedia.org/69441 (10Mr. Stradivarius) 3NEW p:3Unprio s:3enhanc a:3None It would be useful for things like [[Module:WikiProjectBanner]] if Scribunto could detect whether a g... [17:20:08] jackmcbarn, anomie: is this ^ feature request likely to be difficult? If not, I was thinking I could have a go at it myself as a first foray into PHP coding, but I don't really know what I'm getting myself into at this point. [17:20:29] (03PS5) 10Umherirrender: Parser: Clean up handling of editsections by using local variables [core] - 10https://gerrit.wikimedia.org/r/144182 [17:21:21] (03CR) 10Umherirrender: "Patch Set 5: Rebased" [core] - 10https://gerrit.wikimedia.org/r/144182 (owner: 10Umherirrender) [17:22:01] MrStradivarius: shouldn't be difficult. if you do decide to do it, note that you'd want to do it in the disambiguator extension, not scribunto [17:22:42] i'm not sure if including post-parse things where scribunto can see them would be a good idea or not, though [17:22:43] (03PS1) 10SG: Move jQueryFindWithParent into its own findWithParent plugin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153627 [17:22:54] (03PS4) 10Withoutaname: Move SubmitAction class to separate page [core] - 10https://gerrit.wikimedia.org/r/151557 [17:23:16] (03CR) 10jenkins-bot: [V: 04-1] Move jQueryFindWithParent into its own findWithParent plugin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153627 (owner: 10SG) [17:23:16] you could do {{#if:{{#invoke:IsThisADabPage|main|{{FULLPAGENAME}}}}||__DISAMBIG__}} or something and cause a paradox [17:23:33] (03PS2) 10Withoutaname: Change "ENGINE=HEAP" to "ENGINE=MEMORY" [core] - 10https://gerrit.wikimedia.org/r/151643 [17:24:15] Good point - that wouldn't end well [17:27:43] (03PS2) 10SG: Move jQueryFindWithParent into its own findWithParent plugin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153627 [17:28:09] 3Wikimedia / 3General/Unknown: Special:BrokenRedirects on trwiki lists valid links - 10https://bugzilla.wikimedia.org/68211#c5 (10superyetkin) Anyone out there to respond, please? [17:28:15] (03CR) 10jenkins-bot: [V: 04-1] Move jQueryFindWithParent into its own findWithParent plugin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153627 (owner: 10SG) [17:28:40] (03PS6) 10Jdlrobson: E2d: Add the mark as read button to messages view [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153556 [17:28:43] (03PS1) 10Jdlrobson: F11: Show mark as read buttons in notification list items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153629 [17:29:08] (03CR) 10jenkins-bot: [V: 04-1] F11: Show mark as read buttons in notification list items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153629 (owner: 10Jdlrobson) [17:29:10] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Create debug and information endpoints - 10https://bugzilla.wikimedia.org/69442 (10Nik Everett) 3NEW p:3Unprio s:3normal a:3None We should create some endpoints for things like: 1. The Elasticsearch document for a page. 2. The field and namespace... [17:29:47] (03PS2) 10Jdlrobson: F11: Show mark as read buttons in notification list items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153629 [17:30:23] (03CR) 10MarkTraceur: [C: 04-1] "Seems there's an operation on the details object(s) from the upload step if there are multiple files selected; move that to the detail ste" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 (owner: 10MarkTraceur) [17:34:08] 3MediaWiki extensions / 3Scribunto: Feature request: add detection for disambiguation pages to Scribunto - 10https://bugzilla.wikimedia.org/69441#c1 (10Mr. Stradivarius) 5NEW>3RESO/WON Jackmcbarn pointed out on IRC that we can't do this because disambiguation status is determined post-parse: > you could... [17:34:53] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Create debug and information endpoints - 10https://bugzilla.wikimedia.org/69442#c1 (10Nik Everett) 3. Some option on the search page to just spit out the query we send to Elasticsearch instead of the results. [17:35:05] fatal: Could not read from remote repository. [17:35:08] Woohoo [17:35:15] I'm banking on it being my connection. [17:36:51] jackmcbarn, MrStradivarius: We could probably get away with it as long as we return nil (rather than true or false) for the page currently being parsed. [17:37:24] anomie: that seems rather hacky, and you could still create a paradox by looping a few pages together [17:38:29] jackmcbarn: You could create a paradox with looped pages already by scanning the content. [17:38:47] hmm [17:39:22] anomie: how? wouldn't you infinite-loop and hit the template expansion depth limit? [17:39:44] (03PS1) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [17:39:45] (or the loop checker)? [17:39:48] (03CR) 10jenkins-bot: [V: 04-1] Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 (owner: 10MarkTraceur) [17:40:50] jackmcbarn: If you're parsing Foo and Foo loads the content of Bar to search for __DISAMBIG__, there's no difference between that and Foo checking Bar's isDisambig() property [17:41:40] anomie: it would have to parse the content of Bar to see if the __DISAMBIG__ actually happened, but for it to be a paradox, bar would have to do the same thing back to foo, and then you'd get a template loop [17:41:41] (right?) [17:44:24] jackmcbarn: So Foo parses Bar and scans the content, while Bar tries to do the same to Foo? Sure, that'd hit the loop check. But that's no different than Bar containing {{:Foo}} and Foo containing {{:Bar}}. [17:44:44] anomie: right. my point is that it would cause a template loop rather than a paradox that way [17:45:22] but isn't it stored along with the post-parse output whether it found __DISAMBIG__, so this new feature could just look for that instead of parsing, not loop, but cause a paradox [17:47:12] (03Abandoned) 10Matthias Mullie: (bug 69416) Chrome & Safari - posting a reply loads a new broken URL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153617 (https://bugzilla.wikimedia.org/69416) (owner: 10Matthias Mullie) [17:49:42] (03CR) 10Matthias Mullie: Fixes cancel on reply form submitting to no-JS page, and also standardizes cancel button markup (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150998 (owner: 10SG) [17:51:07] jackmcbarn: I'm still not seeing any paradox that you can't already do with getContent(). [17:51:43] i guess i'm not explaining it well.... i'll set up a demonstration on my test wiki [17:53:00] quick question: is the "deleted only" checkbox on en-wp known to not work? [17:53:39] 3MediaWiki extensions / 3Translate: Splitting should be done after alignment at Special:PageMigration? - 10https://bugzilla.wikimedia.org/69310#c6 (10Nemo) What would happen then if the old version of the translation page had no double newlines between the h2? Does alignment still work? [17:53:42] (03CR) 10Jdlrobson: Add truncated-text utility mixin (033 comments) [core] - 10https://gerrit.wikimedia.org/r/151792 (owner: 10Jdlrobson) [17:53:50] destrier: its name is misleading. it means revdel'd [17:54:01] ah thanks [17:54:17] if you're an admin there, you can see "regular" deleted contributions at a different special page [17:54:34] which one is that? [17:54:39] (03CR) 10Jdlrobson: Use core mw-ui text-truncated utility mixin (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151789 (owner: 10Jdlrobson) [17:55:03] Special:DeletedContributions? [17:55:12] thanks [17:55:26] (03PS1) 10Aaron Schulz: Enabled $wgUseLinkNamespaceDBFields [core] - 10https://gerrit.wikimedia.org/r/153634 [17:55:54] yes, that produces results, thanks [17:55:55] destrier: there's a link to that page in Special:Contributions [17:56:41] (03CR) 10Bsitu: Auto mark notification as read if it doesn't have target page (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152203 (owner: 10Bsitu) [17:57:57] destrier: also, if you are an admin, you can view revdelled diffs by adding &unhide=1 to the diff url [17:58:19] (03PS1) 10Umherirrender: Remove spaces of html in NoLocalSettings.php [core] - 10https://gerrit.wikimedia.org/r/153635 [17:58:50] thanks MrStradivarius I'll keep a note of that [18:00:27] (03CR) 10Yaron Koren: [C: 032] add Contributors class [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/153344 (owner: 10tosfos) [18:00:32] (03Merged) 10jenkins-bot: add Contributors class [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/153344 (owner: 10tosfos) [18:03:12] (03CR) 10Yaron Koren: [C: 032] fix bug - was mishandling $wgContributorsLimit when using non-default sort [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/153348 (owner: 10tosfos) [18:03:19] (03Merged) 10jenkins-bot: fix bug - was mishandling $wgContributorsLimit when using non-default sort [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/153348 (owner: 10tosfos) [18:05:28] (03PS1) 10IAlex: Remove useless $out parameter from SkinTemplate::prepareQuickTemplate() [core] - 10https://gerrit.wikimedia.org/r/153636 [18:11:28] anomie: http://jackmcbarn.insomnia247.nl/wiki/Special:DisambiguationPages [18:11:39] null edits to Paradox1 and Paradox2 make them flip whether they're listed there [18:12:20] (03CR) 10Yaron Koren: [C: 032] improve Contributors class [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/153366 (owner: 10tosfos) [18:12:25] (03Merged) 10jenkins-bot: improve Contributors class [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/153366 (owner: 10tosfos) [18:12:56] (03PS3) 10Jdlrobson: F11: Show mark as read buttons in notification list items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153629 [18:13:58] (03PS5) 10Jdlrobson: Make new topic content required [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151005 (owner: 10Werdna) [18:19:34] (03PS1) 10Bsitu: Add abstract model and mapper for notification [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153637 [18:21:01] (03PS1) 10IAlex: Fix undefined variable notice in ResourceLoaderFileModule::getSkipFunction() [core] - 10https://gerrit.wikimedia.org/r/153638 (https://bugzilla.wikimedia.org/69214) [18:21:08] (03CR) 10Ori.livneh: [C: 032] Configuration rewrite, part 2 [services/jobrunner] - 10https://gerrit.wikimedia.org/r/151209 (owner: 10Aaron Schulz) [18:21:27] (03Merged) 10jenkins-bot: Configuration rewrite, part 2 [services/jobrunner] - 10https://gerrit.wikimedia.org/r/151209 (owner: 10Aaron Schulz) [18:22:10] (03Abandoned) 10Bsitu: Add abstract model and mapper for notification [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153637 (owner: 10Bsitu) [18:26:23] (03CR) 10Aaron Schulz: "Also broke flaggedrevs:" [core] - 10https://gerrit.wikimedia.org/r/143032 (owner: 10Thiemo Mättig (WMDE)) [18:28:47] (03PS1) 10Spage: Set defaultbranch in .gitreview to two_tabs [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153640 [18:31:50] anyone around to help me with my unstable vagrant? http requests keep timing out after apache has been up for a minute or so [18:33:15] it always starts by timing out "load.php?debug=false&lang=en&modules=startup&only=scripts&skin=vector&*" [18:33:27] the next step is to time out all requests entirely, until I kill apache [18:33:43] what happens if you visit that page in your browser? are you using the latest version of mw-vagrant? [18:33:51] I've been having similar problem as shahyar with a labs-vagrant instance [18:34:15] legoktm: I just destroyed my vagrant instance and it rebuilt itself, so it should be the latest [18:34:36] did you git pull inside your vagrant checkout? [18:34:51] legoktm: si [18:35:49] (03PS1) 10Aaron Schulz: Fixed query error since 08fee4ce in core [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/153642 [18:36:10] Reedy: ^ [18:37:10] Ah, I see [18:37:15] I wonder if that breaks other stuff :/ [18:37:23] (that, being the source change) [18:41:16] shahyar: do you see unusual cpu/mem usage when apache gets stuck? [18:41:47] Vulpix: nope [18:41:59] (03PS6) 10All1: Moved texvc.js and wiki2jax.js (they are mediawiki files, not included in MathJax folder) to extensions/Math/modules directory for a complete MathJax update [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [18:42:01] (03Abandoned) 10Aaron Schulz: Fixed query error since 08fee4ce in core [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/153642 (owner: 10Aaron Schulz) [18:42:04] (03CR) 10jenkins-bot: [V: 04-1] Moved texvc.js and wiki2jax.js (they are mediawiki files, not included in MathJax folder) to extensions/Math/modules directory for a complete MathJax update [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [18:42:21] (03CR) 10Parent5446: "@Tim - Agreed. The issue this patch fixed was indeed urgent, and the issue fixed by reverting it is not. I'm keeping this patch open merel" [core] - 10https://gerrit.wikimedia.org/r/153362 (https://bugzilla.wikimedia.org/69380) (owner: 10Parent5446) [18:42:31] I have a sneaking suspicion that this has something to do with caching [18:42:58] (03PS1) 10Jdlrobson: Kill mark as read button [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153643 [18:44:53] 3MediaWiki extensions / 3Translate: Splitting should be done after alignment at Special:PageMigration? - 10https://bugzilla.wikimedia.org/69310#c7 (10Pratik Lahoti) We had discussed this on IRC (wish I had the logs). You had clearly told me that there would be double newlines atleast between two h2's and suc... [18:46:55] (03PS7) 10All1: Moved texvc.js and wiki2jax.js (they are mediawiki files, not included in MathJax folder) to extensions/Math/modules directory and reconfigured them into MathJax for a complete MathJax update [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [18:46:58] (03CR) 10jenkins-bot: [V: 04-1] Moved texvc.js and wiki2jax.js (they are mediawiki files, not included in MathJax folder) to extensions/Math/modules directory and reconfigured them into MathJax for a complete MathJax update [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [18:47:06] (03PS1) 10IAlex: Correctly handle incorrect namespace in cleanupTitles.php [core] - 10https://gerrit.wikimedia.org/r/153644 (https://bugzilla.wikimedia.org/68501) [18:49:44] (03PS1) 10Reedy: Remove duplicate override in SpecialRecentchangeslinked.php [core] - 10https://gerrit.wikimedia.org/r/153646 [18:53:08] (03CR) 10Spage: [C: 04-1] "Unlike the Flow frontend-rewrite where we needed lots of new patches to go on the branch, we only want to target some existing patches for" [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153640 (owner: 10Spage) [18:54:34] (03CR) 10Anomie: API: Overhaul token handling (032 comments) [core] - 10https://gerrit.wikimedia.org/r/153110 (owner: 10Anomie) [18:54:40] (03PS2) 10Anomie: API: Overhaul token handling [core] - 10https://gerrit.wikimedia.org/r/153110 [18:55:08] (03CR) 10jenkins-bot: [V: 04-1] API: Overhaul token handling [core] - 10https://gerrit.wikimedia.org/r/153110 (owner: 10Anomie) [18:57:35] (03CR) 10Anomie: [C: 032] "Yeah, no need to call the hook twice." [core] - 10https://gerrit.wikimedia.org/r/153646 (owner: 10Reedy) [18:57:59] (03PS1) 10Reedy: Remove duplicate override in SpecialRecentchangeslinked.php [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153647 [18:58:09] (03CR) 10Reedy: [C: 032] Remove duplicate override in SpecialRecentchangeslinked.php [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153647 (owner: 10Reedy) [18:59:32] (03PS15) 10Legoktm: Fixed various issues with the BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153016 (https://bugzilla.wikimedia.org/69099) (owner: 1001tonythomas) [18:59:39] (03PS4) 10Jdlrobson: F11: Show mark as read buttons in notification list items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153629 [18:59:44] (03CR) 10Legoktm: [C: 032] Fixed various issues with the BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153016 (https://bugzilla.wikimedia.org/69099) (owner: 1001tonythomas) [19:01:09] (03Merged) 10jenkins-bot: Remove duplicate override in SpecialRecentchangeslinked.php [core] - 10https://gerrit.wikimedia.org/r/153646 (owner: 10Reedy) [19:01:30] (03Merged) 10jenkins-bot: Remove duplicate override in SpecialRecentchangeslinked.php [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153647 (owner: 10Reedy) [19:01:46] (03CR) 10Anomie: "I don't see the point of you keeping this open for that purpose, since this itself won't be merged and whatever reversion may be necessary" [core] - 10https://gerrit.wikimedia.org/r/153362 (https://bugzilla.wikimedia.org/69380) (owner: 10Parent5446) [19:02:31] (03CR) 10Legoktm: [C: 032] Fixed various issues with the BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153016 (https://bugzilla.wikimedia.org/69099) (owner: 1001tonythomas) [19:02:36] (03Merged) 10jenkins-bot: Fixed various issues with the BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153016 (https://bugzilla.wikimedia.org/69099) (owner: 1001tonythomas) [19:02:55] (03CR) 10Jdlrobson: [C: 032] Remove redundant "Given I am on Flow page" steps [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153554 (owner: 10Spage) [19:03:27] (03Merged) 10jenkins-bot: Remove redundant "Given I am on Flow page" steps [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153554 (owner: 10Spage) [19:04:46] (03CR) 10Hoo man: [C: 04-1] Generate VERP address for a single/array of recipient addresses (032 comments) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153403 (https://bugzilla.wikimedia.org/69099) (owner: 1001tonythomas) [19:05:12] (03PS8) 10All1: Moved texvc.js and wiki2jax.js (they are mediawiki files, not included in MathJax folder) to extensions/Math/modules directory and reconfigured them into MathJax for a complete MathJax update [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [19:05:15] (03CR) 10jenkins-bot: [V: 04-1] Moved texvc.js and wiki2jax.js (they are mediawiki files, not included in MathJax folder) to extensions/Math/modules directory and reconfigured them into MathJax for a complete MathJax update [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [19:08:26] (03PS1) 10Manybubbles: Add cirrusdump action for helpful debugging [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/153649 (https://bugzilla.wikimedia.org/69442) [19:08:53] (03PS9) 10All1: Moved texvc.js and wiki2jax.js (they are mediawiki files, not included in MathJax folder) to extensions/Math/modules directory and reconfigured them into MathJax for a complete MathJax update [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [19:08:57] (03CR) 10jenkins-bot: [V: 04-1] Moved texvc.js and wiki2jax.js (they are mediawiki files, not included in MathJax folder) to extensions/Math/modules directory and reconfigured them into MathJax for a complete MathJax update [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [19:09:25] (03CR) 10Manybubbles: [C: 04-1] "-1 until I'm sure the integration tests still pass." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/153649 (https://bugzilla.wikimedia.org/69442) (owner: 10Manybubbles) [19:10:09] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Create debug and information endpoints - 10https://bugzilla.wikimedia.org/69442 (10Nik Everett) 5PATC>3ASSI [19:10:27] (03PS10) 10All1: Moved texvc.js and wiki2jax.js (they are mediawiki files, not included in MathJax folder) to extensions/Math/modules directory and reconfigured them into MathJax for a complete MathJax update [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [19:10:31] (03CR) 10jenkins-bot: [V: 04-1] Moved texvc.js and wiki2jax.js (they are mediawiki files, not included in MathJax folder) to extensions/Math/modules directory and reconfigured them into MathJax for a complete MathJax update [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 (owner: 10All1) [19:11:14] (03PS11) 10All1: Moved texvc.js and wiki2jax.js (they are mediawiki files, not included in MathJax folder) to extensions/Math/modules directory and reconfigured them into MathJax for a complete MathJax update [extensions/Math] - 10https://gerrit.wikimedia.org/r/153603 [19:12:47] (03CR) 10Daniel Friesen: "@Arlolra, sure the site notice is parsed wiki content so it can have parser outputted link styles." [core] - 10https://gerrit.wikimedia.org/r/151395 (owner: 10Arlolra) [19:13:29] (03PS1) 10Bsitu: Add abstract model and mapper for notification [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153650 [19:14:49] (03PS1) 10Bsitu: Add TargetPage model and mapper to notifications [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153651 [19:18:24] 3MediaWiki / 3Revision deletion: Split suppressrevision in two distinct permissions : the first one to oversight content, and the other one to review oversighted content - 10https://bugzilla.wikimedia.org/20476#c20 (10Vogone) This is most likely due to stewards having "abusefilter-hide-log" assigned globally... [19:18:40] (03Abandoned) 10Bsitu: Add abstract model and mapper for notification [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153650 (owner: 10Bsitu) [19:18:59] (03Abandoned) 10Bsitu: Add TargetPage model and mapper to notifications [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153651 (owner: 10Bsitu) [19:20:37] (03PS4) 1001tonythomas: Generate VERP address for a single/array of recipient addresses [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153403 (https://bugzilla.wikimedia.org/69099) [19:22:08] 3MediaWiki / 3Parser: Template:!, = (( and )) as built-in variables - 10https://bugzilla.wikimedia.org/32746#c5 (10Kunal Mehta (Legoktm)) {{!}} is now a native parser function. Unsure if we want to do the same for the other ones in the bug title. [19:22:39] (03CR) 10Bsitu: [C: 032] Kill mark as read button [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153643 (owner: 10Jdlrobson) [19:23:04] (03Merged) 10jenkins-bot: Kill mark as read button [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153643 (owner: 10Jdlrobson) [19:23:06] (03PS1) 10Jdlrobson: Notification overlay Messages and Alerts sections [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153652 [19:23:08] 3MediaWiki / 3Revision deletion: Split suppressrevision in two distinct permissions : the first one to oversight content, and the other one to review oversighted content - 10https://bugzilla.wikimedia.org/20476#c21 (10DerHexer) (In reply to Vogone from comment #20) > This is most likely due to stewards havin... [19:23:40] (03Abandoned) 10Jdlrobson: Notification overlay Messages and Alerts sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152165 (owner: 10Jdlrobson) [19:23:49] (03Abandoned) 10Jdlrobson: Kill mark as read button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153555 (owner: 10Jdlrobson) [19:23:52] (03PS5) 1001tonythomas: Generate VERP address for a single/array of recipient addresses [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153403 (https://bugzilla.wikimedia.org/69099) [19:24:08] 3MediaWiki-Vagrant: Vagrant rebuild fails on Windows - Could not set 'link' on ensure: Protocol error - 10https://bugzilla.wikimedia.org/69425#c1 (10Yuri Astrakhan) Created attachment 16180 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16180&action=edit Cleaned-up log and re-ran on 1.6.3 Stderr from... [19:24:53] 3MediaWiki skins / 3Vector: Vector: The version of the Vector extension bundled with MediaWiki 1.21 is incompatible - 10https://bugzilla.wikimedia.org/49228#c28 (10Kunal Mehta (Legoktm)) 5NEW>3RESO/WON MW 1.21 is no longer supported, and this was only an issue with the tarball AFAIS. [19:25:38] 3MediaWiki-Vagrant: Debug mode is broken - 10https://bugzilla.wikimedia.org/69421#c3 (10Yuri Astrakhan) I am not sure this bug is fixed - see the ATTACHED (not the first comment) log in bug 69425 [19:30:26] (03CR) 10Hoo man: [C: 04-1] Generate VERP address for a single/array of recipient addresses (032 comments) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153403 (https://bugzilla.wikimedia.org/69099) (owner: 1001tonythomas) [19:31:25] (03PS1) 10Jdlrobson: Notification overlay Messages and Alerts sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153653 [19:32:13] superm401, around? [19:32:19] (03Abandoned) 10Jdlrobson: Notification overlay Messages and Alerts sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153653 (owner: 10Jdlrobson) [19:32:32] yurikR, yeah, what's up? [19:32:46] superm401, saw a patch to vagrant, but it seems like its not working [19:33:31] could you take a look (posted log in the https://bugzilla.wikimedia.org/show_bug.cgi?id=69425#attach_16180 [19:33:48] superm401, ^ [19:33:52] yurikR, looks like two separate bugs. [19:33:58] (03PS2) 10Jdlrobson: Notification overlay Messages and Alerts sections [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153652 [19:34:09] (03PS6) 1001tonythomas: Generate VERP address for a single/array of recipient addresses [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153403 (https://bugzilla.wikimedia.org/69099) [19:34:12] My patch was to fix a link with an incorrect destination, causing HTTP requests for resources to point to the wrong place. [19:34:28] (03CR) 10Arlolra: "That's unfortunate but can we live with it to get some uniformity?" [core] - 10https://gerrit.wikimedia.org/r/151395 (owner: 10Arlolra) [19:34:30] Yours looks like Windows might not support symbolic links at all in the shared directories. [19:34:44] oh, probably got confused by the "link" on ensure [19:36:31] (03CR) 10Spage: [C: 04-1] "wikifont.css needs sample usage and guidelines in KSS comments, then we can add it to the living style guide (`cd docs/kss ; make kss`)." [core] - 10https://gerrit.wikimedia.org/r/137888 (https://bugzilla.wikimedia.org/66138) (owner: 10Prtksxna) [19:37:55] (03PS1) 10Jdlrobson: E2b: Reflect the count in alerts and messages tabs [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153675 [19:38:38] 3MediaWiki-Vagrant: Debug mode is broken - 10https://bugzilla.wikimedia.org/69421#c4 (10Matthew Flaschen) Bug 69425 looks like a separate (but important) issue (symbolic links on Windows). In that bug, both source and destination for the link appear to be in the shared directory. This bug was that one partic... [19:38:42] yurikR, no problem. You can confirm it's a different bug if you check /var/www when ssh-ed in. [19:41:20] (03PS1) 10Jdlrobson: E2c: Hover behaviour of notifications panel tabs [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153693 [19:41:40] (03Abandoned) 10Jdlrobson: E2b: Reflect the count in alerts and messages tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153532 (owner: 10Jdlrobson) [19:41:44] (03Abandoned) 10Jdlrobson: E2c: Hover behaviour of notifications panel tabs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153546 (owner: 10Jdlrobson) [19:43:22] (03CR) 10Bsitu: [C: 032] Notification overlay Messages and Alerts sections [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153652 (owner: 10Jdlrobson) [19:43:48] (03Merged) 10jenkins-bot: Notification overlay Messages and Alerts sections [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153652 (owner: 10Jdlrobson) [19:45:12] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None MediaWiki: CSS/JS pages on any non-large wiki are usually a mess. Occasionally, we'll d... [19:45:35] (03CR) 10Bsitu: [C: 04-1] E2b: Reflect the count in alerts and messages tabs (031 comment) [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153675 (owner: 10Jdlrobson) [19:47:02] (03PS7) 10Jdlrobson: E2d: Add the mark as read button to messages view [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153556 [19:47:05] (03PS5) 10Jdlrobson: F11: Show mark as read buttons in notification list items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153629 [19:52:54] 3MediaWiki extensions / 3[other]: SwiftMedia's rewrite doesn't properly collapse multiple slashes - 10https://bugzilla.wikimedia.org/32864#c4 (10vagababov) I've updated the other bug as well, which is filed as a consequence: https://bugzilla.wikimedia.org/show_bug.cgi?id=49467 Currently it seems wikimedia s... [19:55:09] (03CR) 10Hoo man: [C: 032] "Looks like we got this right, now. There should be tests for this." [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153403 (https://bugzilla.wikimedia.org/69099) (owner: 1001tonythomas) [19:55:15] (03Merged) 10jenkins-bot: Generate VERP address for a single/array of recipient addresses [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153403 (https://bugzilla.wikimedia.org/69099) (owner: 1001tonythomas) [19:56:08] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c1 (10Marius Hoch) This would need to be done differently from how FlaggedRevisions currently is implemented (as in FR you still submit a new version whic... [20:01:03] (03CR) 10SG: Use core mw-ui text-truncated utility mixin (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151789 (owner: 10Jdlrobson) [20:05:01] (03PS2) 1001tonythomas: Improved the VERP generation by cutting down the hmac hash [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153450 [20:07:00] (03CR) 1001tonythomas: "Rebased! Looks good to go ??" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153450 (owner: 1001tonythomas) [20:24:23] (03CR) 10Parent5446: "@Anomie, I was not aware of this patch, and intended on putting whatever solution we decided on on top of this patch." [core] - 10https://gerrit.wikimedia.org/r/153362 (https://bugzilla.wikimedia.org/69380) (owner: 10Parent5446) [20:24:42] (03Abandoned) 10Parent5446: Revert "Do not allow a user to delete a page they can't edit" [core] - 10https://gerrit.wikimedia.org/r/153362 (https://bugzilla.wikimedia.org/69380) (owner: 10Parent5446) [20:26:38] 3MediaWiki / 3JavaScript: ResourceLoader: Convey license information in HTTP requests serving minified builds of javascript files - 10https://bugzilla.wikimedia.org/36866#c16 (10Benjamin Mako Hill) Fantastic! Thanks Tim! Looks like support for (2) in Comment 14 is now handled. As Tim says in his commit log,... [20:33:47] hi :) [20:34:52] after today's change we haven't the edition box on polish wikisource [20:35:14] on Mozilla, IE & Chrome [20:35:20] only Opera is ok [20:36:53] 3MediaWiki / 3General/Unknown: Investigate whether taking an action on a page (delete, import, etc.) should require being able to edit it - 10https://bugzilla.wikimedia.org/69380#c22 (10Tyler Romeo) (In reply to Tim Starling from comment #18) > (In reply to Tyler Romeo from comment #4) > > 2) It makes certai... [20:39:48] (03CR) 10Mattflaschen: [C: 04-1] "Same issue, plus an undefined variable." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/150635 (owner: 10Jdlrobson) [20:40:30] (03PS1) 10Bsitu: Move 'notification count refresh' logic out of mapper [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153702 [20:46:07] (03PS32) 10Jdlrobson: Add blanket support for mediawiki ui via globals [core] - 10https://gerrit.wikimedia.org/r/150635 [20:46:08] 3Wikimedia / 3General/Unknown: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - 10https://bugzilla.wikimedia.org/69445#c2 (10Antoine "hashar" Musso) Would it make sense to use git / phabricator ? We will have to convince the community that a pre commit review workflow is... [20:54:12] 3MediaWiki / 3General/Unknown: Edit box disappeared on Polish Wikisource proofread pages - 10https://bugzilla.wikimedia.org/69446 (10wieralee) 3UNCO p:3Unprio s:3normal a:3None http://zapodaj.net/9ce0719ce726f.png.html That's all we can see. It's impossible to write, to see scan and to see the conta... [21:00:59] (03PS2) 10Jdlrobson: E2b: Reflect the count in alerts and messages tabs [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153675 [21:05:26] Krenair: hey [21:06:02] (03CR) 10Bsitu: [C: 032] E2b: Reflect the count in alerts and messages tabs [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153675 (owner: 10Jdlrobson) [21:06:06] So I tried the Gadget ContentHandler stuff earlier [21:06:14] (03PS2) 10Bsitu: E2c: Hover behaviour of notifications panel tabs [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153693 (owner: 10Jdlrobson) [21:06:18] yeah [21:06:23] I found that a gadget I had deleted (with that change active) was still being run [21:06:27] is there anything in your job queue? [21:06:29] (03Merged) 10jenkins-bot: E2b: Reflect the count in alerts and messages tabs [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153675 (owner: 10Jdlrobson) [21:06:36] but not when I changed back to the non-ContentHandler version [21:08:59] (03CR) 10Bsitu: [C: 032] E2c: Hover behaviour of notifications panel tabs [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153693 (owner: 10Jdlrobson) [21:09:23] (03Merged) 10jenkins-bot: E2c: Hover behaviour of notifications panel tabs [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153693 (owner: 10Jdlrobson) [21:09:26] legoktm, what type of job am I looking for? [21:09:34] also I don't see the old css from earlier now [21:10:01] (03PS1) 10Jdlrobson: E2d: Add the mark as read button to messages view [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153707 [21:10:17] (03Abandoned) 10Jdlrobson: E2d: Add the mark as read button to messages view [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153556 (owner: 10Jdlrobson) [21:10:50] actually [21:10:53] 3MediaWiki / 3General/Unknown: Edit box disappeared on Polish Wikisource proofread pages - 10https://bugzilla.wikimedia.org/69446#c1 (10Helder) 5UNCO>3NEW Here is what I see in the console of Firefox 31 in the above URL: "Exception thrown by user callback" load.php:10896 "[Exception... "Node cannot be i... [21:10:53] it should run right away. [21:10:55] (03PS1) 10Jdlrobson: F11: Show mark as read buttons in notification list items [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153708 [21:11:01] (03Abandoned) 10Jdlrobson: F11: Show mark as read buttons in notification list items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153629 (owner: 10Jdlrobson) [21:11:06] in the web request itself [21:11:44] it's called from WikiPage::doDeleteUpdates [21:11:51] * legoktm tests [21:11:54] (03CR) 10Hashar: "That is a good one! Siebrand told me about that magic comment a while back but my brain apparently completely forgot about it. Nice fix!" [core] - 10https://gerrit.wikimedia.org/r/153457 (owner: 10Addshore) [21:12:23] 3MediaWiki / 3General/Unknown: Edit box disappeared on Polish Wikisource proofread pages - 10https://bugzilla.wikimedia.org/69446 (10Helder) [21:12:45] legoktm, actually I just realised I wasn't logged in [21:12:51] I logged in and the CSS came back [21:12:57] (03CR) 10Hashar: "Yeah @codingStandardsIgnoreStart and @codingStandardsIgnoreEnd is a nice workaround. Sorry I should have thought about it but I completely" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/151593 (owner: 10Umherirrender) [21:12:58] even though the gadget definition for it had been deleted [21:13:16] hmmm [21:13:55] mw.loader.load(["mediawiki.page.patrol.ajax","mediawiki.action.view.postEdit","mediawiki.user","mediawiki.hidpi","mediawiki.page.ready","mediawiki.searchSuggest","mediawiki.page.watch.ajax","ext.gadget.Foo"],null,true); [21:14:16] why is it still in that array? [21:14:24] marktraceur: around= [21:14:25] *? [21:14:44] hoo: Yup! [21:14:57] Want to chat HideMediaViewer? [21:15:15] marktraceur: I just had a very quick idea: Would it be hard to use the MediaViewer on top of Wikibase to view images embed there? [21:15:23] (Don't have time to code that now, just curios) [21:15:30] I can have a quick look [21:15:31] Oh,hm [21:15:48] those images are on commons all the time [21:15:49] hoo: You mean if there are images linked to an entity in Wikibase? [21:16:02] no, in an entity there can be images linked [21:16:05] Presumably there's an "image" data type and everything [21:16:06] let me find one [21:16:09] Oh, sure. [21:16:12] commonsmedia [21:16:14] :) [21:16:15] Krenair: I blame some caching because I didn't do anything and it went away now. [21:16:17] guess that would be nice [21:17:01] * legoktm tests more [21:17:19] marktraceur: https://www.wikidata.org/wiki/Q64 [21:17:28] (search for image on that page or so) [21:17:31] (03PS2) 10Jdlrobson: E2d: Add the mark as read button to messages view [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153707 [21:17:51] would be awesome to preview them in place [21:18:15] s/preview/view/ [21:18:25] I see it [21:18:32] * marktraceur tries the API view [21:20:52] Krenair: I think this is unrelated to my patch. Let me see if the same thing happens on current RL2. [21:21:21] hoo: Yeah, that doesn't look too painful [21:22:12] marktraceur: Nice... will be on holiday for the rest of the month, but that looks like something interesting :) [21:22:18] * hoo notes it down [21:22:43] hoo: I'd sort of like it if the data type were in the DOM somehow [21:22:53] That seems like it's the only thing stopping you from doing it without an API call [21:23:36] (03PS3) 10Jdlrobson: E2d: Add the mark as read button to messages view [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153707 [21:23:41] marktraceur: All that data should be in the global wbEntity [21:23:46] Aha. [21:23:57] I weep for the DOM, but I rejoice for media viewer. [21:23:58] :) [21:24:00] (03CR) 10jenkins-bot: [V: 04-1] E2d: Add the mark as read button to messages view [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153707 (owner: 10Jdlrobson) [21:24:20] Also, that page was real slow to load already [21:24:26] oh yes :( [21:24:40] we worked a lot on that late last year, but still kind of a problem [21:24:41] hoo: Do you load the JS for editing on demand? [21:24:45] nope [21:24:52] That may be the/a problem. :) [21:25:24] that might be part of it... also expensive DOM changes [21:25:38] although we cut down on them quite a lot [21:25:39] Yeahhh [21:25:55] at times loading such an entity could make a browser hang fpr up to 45s on my system :P [21:26:44] Ok... do you still need CR for something for commons? [21:26:52] (03PS4) 10Jdlrobson: E2d: Add the mark as read button to messages view [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153707 [21:26:55] (03PS2) 10Jdlrobson: F11: Show mark as read buttons in notification list items [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153708 [21:27:19] (03CR) 10jenkins-bot: [V: 04-1] E2d: Add the mark as read button to messages view [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153707 (owner: 10Jdlrobson) [21:27:22] (03CR) 10jenkins-bot: [V: 04-1] F11: Show mark as read buttons in notification list items [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153708 (owner: 10Jdlrobson) [21:32:16] (03PS5) 10Jdlrobson: E2d: Add the mark as read button to messages view [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153707 [21:32:39] (03CR) 10jenkins-bot: [V: 04-1] E2d: Add the mark as read button to messages view [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153707 (owner: 10Jdlrobson) [21:35:18] Krenair: yup, I can easily reproduce this without my patch. [21:37:34] (03PS6) 10Jdlrobson: E2d: Add the mark as read button to messages view [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153707 [21:38:00] (03CR) 10jenkins-bot: [V: 04-1] E2d: Add the mark as read button to messages view [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153707 (owner: 10Jdlrobson) [21:43:17] (03PS7) 10Jdlrobson: E2d: Add the mark as read button to messages view [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153707 [21:43:20] jgonera: see my latest comment on https://gerrit.wikimedia.org/r/#/c/147115/ [21:43:41] (03CR) 10jenkins-bot: [V: 04-1] E2d: Add the mark as read button to messages view [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153707 (owner: 10Jdlrobson) [21:44:05] (03CR) 10Legoktm: "The deletion update runs fine, the styles are cached (in browser or maybe memcached?), which is reproducible without this patch." [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153270 (https://bugzilla.wikimedia.org/69318) (owner: 10Legoktm) [21:44:13] jgonera: i've been tagging features with @vagrant as i get them to pass in the mwv environment. the rest i'd like to pair on sometime this week if you're available [21:44:35] marxarelli, I'll be in the office tomorrow [21:44:55] I'll try to have a closer look at those scenarios marked with @vagrant that failed for me [21:44:59] jgonera: great, i'll send a calendar invite your way [21:45:49] (03Abandoned) 10JGonera: Set visualeditor-enable to 0 by default [vagrant] - 10https://gerrit.wikimedia.org/r/141860 (owner: 10JGonera) [21:48:48] (03CR) 10Legoktm: Convert Gadget definition namespace to use ContentHandler (031 comment) [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153270 (https://bugzilla.wikimedia.org/69318) (owner: 10Legoktm) [21:49:26] (03PS8) 10Jdlrobson: E2d: Add the mark as read button to messages view [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153707 [21:51:37] legoktm, "prevents unneeded cache invalidations" sounds like something we should be keeping [21:51:53] (03PS3) 10Legoktm: Register GadgetResourceLoaderModule with an array [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153539 [21:52:35] (03CR) 10Bsitu: [C: 032] E2d: Add the mark as read button to messages view [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153707 (owner: 10Jdlrobson) [21:52:50] Krenair: in the long term yes, but right now it's not worth keeping it around since I'm going to refactor all the timestamp logic anyways [21:53:01] (03Merged) 10jenkins-bot: E2d: Add the mark as read button to messages view [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153707 (owner: 10Jdlrobson) [21:54:19] (03CR) 10Legoktm: Register GadgetResourceLoaderModule with an array (031 comment) [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153539 (owner: 10Legoktm) [21:56:35] (03Abandoned) 10Legoktm: Use SkinFactory [skins/Modern] - 10https://gerrit.wikimedia.org/r/153233 (owner: 10Legoktm) [21:56:38] (03Abandoned) 10Legoktm: Use SkinFactory [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/153230 (owner: 10Legoktm) [21:57:08] 3MediaWiki extensions / 3EducationProgram: EducationProgram needs tests in Jenkins - 10https://bugzilla.wikimedia.org/56962#c6 (10Jeroen De Dauw) Yay, thnx addshore! [21:57:20] (03CR) 10Tim Landscheidt: "@hashar: .jshintrc & Co. is fine with me; the idea is to have some automatic linting at all. But I would also be okay with just enabling " [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153581 (https://bugzilla.wikimedia.org/63687) (owner: 10Addshore) [21:57:49] (03PS3) 10Jdlrobson: F11: Show mark as read buttons in notification list items [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153708 [22:02:12] (03PS4) 10Jdlrobson: F11: Show mark as read buttons in notification list items [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153708 [22:03:59] (03PS2) 10Legoktm: SkinFactory: register skins in Setup.php [core] - 10https://gerrit.wikimedia.org/r/153540 [22:05:25] (03CR) 10Hoo man: [C: 032] Avoid dependance on a WikiEditor class that have been recently removed [extensions/ProofreadPage] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153027 (https://bugzilla.wikimedia.org/69327) (owner: 10Tpt) [22:05:43] (03Merged) 10jenkins-bot: Avoid dependance on a WikiEditor class that have been recently removed [extensions/ProofreadPage] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153027 (https://bugzilla.wikimedia.org/69327) (owner: 10Tpt) [22:06:09] (03PS1) 10MarkTraceur: Remove more unused code in mw.UploadWizard.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153717 [22:06:37] (03CR) 10jenkins-bot: [V: 04-1] Remove more unused code in mw.UploadWizard.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153717 (owner: 10MarkTraceur) [22:07:17] (03CR) 10jenkins-bot: [V: 04-1] SkinFactory: register skins in Setup.php [core] - 10https://gerrit.wikimedia.org/r/153540 (owner: 10Legoktm) [22:07:26] (03PS2) 10MarkTraceur: Remove more unused code in mw.UploadWizard.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153717 [22:07:34] (03PS1) 10Hoo man: Update ProofreadPage [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153718 [22:07:42] (03CR) 10Krinkle: [C: 04-1] "There's also -mask stuff in uploadWizard.css ." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153717 (owner: 10MarkTraceur) [22:08:57] (03CR) 10Aaron Schulz: [C: 032] Change "ENGINE=HEAP" to "ENGINE=MEMORY" [core] - 10https://gerrit.wikimedia.org/r/151643 (owner: 10Withoutaname) [22:09:14] (03PS3) 10MarkTraceur: Remove more unused code in mw.UploadWizard.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153717 [22:09:49] (03PS3) 10Krinkle: Enable phplint and jslint jobs for labs-toollabs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153581 (https://bugzilla.wikimedia.org/63687) (owner: 10Addshore) [22:10:35] (03PS3) 10Legoktm: SkinFactory: register skins in Setup.php [core] - 10https://gerrit.wikimedia.org/r/153540 [22:10:57] (03CR) 10Hoo man: [C: 032] Update ProofreadPage [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153718 (owner: 10Hoo man) [22:12:04] (03CR) 10Krinkle: [C: 04-1] "Indeed, the jslint job should not be non-voting. Only if it is currently not passing for some reason. Which, as Hashar said, is the case r" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153581 (https://bugzilla.wikimedia.org/63687) (owner: 10Addshore) [22:12:22] (03Merged) 10jenkins-bot: Change "ENGINE=HEAP" to "ENGINE=MEMORY" [core] - 10https://gerrit.wikimedia.org/r/151643 (owner: 10Withoutaname) [22:13:51] (03CR) 10jenkins-bot: [V: 04-1] Update ProofreadPage [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153718 (owner: 10Hoo man) [22:15:21] (03CR) 10Hoo man: "recheck" [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153718 (owner: 10Hoo man) [22:15:33] meh [22:15:41] Unrelated Qunit failures :S [22:15:58] damn... [22:16:54] (03CR) 10Hoo man: Update ProofreadPage [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153718 (owner: 10Hoo man) [22:17:03] (03CR) 10Hoo man: [C: 032] Update ProofreadPage [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153718 (owner: 10Hoo man) [22:17:13] hope it passes now [22:17:27] finger crossed [22:18:04] better :) [22:18:26] should, hoo [22:18:51] jackmcbarn: now that you have +2, there are probably a few things you should add yourself to on https://www.mediawiki.org/wiki/Developers/Maintainers [22:19:08] * jackmcbarn looks [22:19:37] (03Merged) 10jenkins-bot: Update ProofreadPage [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153718 (owner: 10Hoo man) [22:22:40] (03CR) 10Krinkle: [C: 04-1] "One more match." (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153717 (owner: 10MarkTraceur) [22:25:21] (03PS2) 10Krinkle: resourceloader: Fix undefined variable in ResourceLoaderFileModule::getSkipFunction [core] - 10https://gerrit.wikimedia.org/r/153638 (https://bugzilla.wikimedia.org/69214) (owner: 10IAlex) [22:25:39] (03CR) 10Krinkle: [C: 032] "Copy paste mistake. Thx." [core] - 10https://gerrit.wikimedia.org/r/153638 (https://bugzilla.wikimedia.org/69214) (owner: 10IAlex) [22:26:05] (03CR) 10Krinkle: [C: 04-1] "file, not page." [core] - 10https://gerrit.wikimedia.org/r/151557 (owner: 10Withoutaname) [22:26:53] (03PS1) 10Spage: disable known-failing test on CI targets [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153719 [22:26:56] (03PS5) 10Krinkle: actions: Move SubmitAction class out of EditAction.php [core] - 10https://gerrit.wikimedia.org/r/151557 (owner: 10Withoutaname) [22:28:05] (03CR) 10Spage: "A better fix is in change Ice6fb4a7c2fc0." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153547 (owner: 10Spage) [22:29:09] (03Merged) 10jenkins-bot: resourceloader: Fix undefined variable in ResourceLoaderFileModule::getSkipFunction [core] - 10https://gerrit.wikimedia.org/r/153638 (https://bugzilla.wikimedia.org/69214) (owner: 10IAlex) [22:29:44] (03CR) 10Krinkle: [C: 032] actions: Move SubmitAction class out of EditAction.php [core] - 10https://gerrit.wikimedia.org/r/151557 (owner: 10Withoutaname) [22:30:01] (03PS3) 10Bartosz Dziewoński: Expose language fallback chain in JavaScript [core] - 10https://gerrit.wikimedia.org/r/153075 (https://bugzilla.wikimedia.org/69285) [22:30:09] (03CR) 10Bartosz Dziewoński: Expose language fallback chain in JavaScript (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153075 (https://bugzilla.wikimedia.org/69285) (owner: 10Bartosz Dziewoński) [22:30:36] MatmaRex_mobile: https://gerrit.wikimedia.org/r/153540 [22:31:17] (and I'll revert my changes to the docs after that) [22:31:37] legoktm: ugh [22:31:42] do i need to look at it now? [22:32:37] probably not [22:32:50] also, are you sure that will work? we've had some segfaults related to toplevel closures in the past, or so i've been told [22:33:20] (03Merged) 10jenkins-bot: actions: Move SubmitAction class out of EditAction.php [core] - 10https://gerrit.wikimedia.org/r/151557 (owner: 10Withoutaname) [22:33:30] yes because those segfaults are due to storing the closure in a variable, not if we execute it right away [22:34:03] okay [22:34:16] that looks sane to me [22:34:35] but it's also late and i haven't slept enough last night [22:34:51] get some sleep then :) [22:35:10] (03PS1) 10Hoo man: Update WikimediaMessages to wmf16 HEAD [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153721 [22:35:20] (03CR) 10Catrope: [C: 032] Update WikimediaMessages to wmf16 HEAD [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153721 (owner: 10Hoo man) [22:35:29] (03PS2) 10Legoktm: SkinFallbackTemplate: Use SkinFactory instead of $wgValidSkinNames [core] - 10https://gerrit.wikimedia.org/r/153542 [22:36:07] i need to document my skins breakage inrelease notes, eh [22:36:36] and i was supposed to do that a while ago [22:37:10] * Skins were broken [22:38:22] * You're doomed [22:39:08] ah, that can wait till tomorrow i guess [22:39:13] (03Merged) 10jenkins-bot: Update WikimediaMessages to wmf16 HEAD [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153721 (owner: 10Hoo man) [22:39:31] silly users andt their silly expectations about docs [22:39:44] (03PS4) 10Krinkle: mediawiki.language: Expose language fallback chain [core] - 10https://gerrit.wikimedia.org/r/153075 (https://bugzilla.wikimedia.org/69285) (owner: 10Bartosz Dziewoński) [22:40:19] (03CR) 10Krinkle: [C: 031] mediawiki.language: Expose language fallback chain [core] - 10https://gerrit.wikimedia.org/r/153075 (https://bugzilla.wikimedia.org/69285) (owner: 10Bartosz Dziewoński) [22:44:16] (03CR) 10Aaron Schulz: [C: 032] Remove deprecated $wgHTCPMulticastAddress, $wgHTCPMulticastRouting and $wgHTCPPort [core] - 10https://gerrit.wikimedia.org/r/150761 (owner: 10Withoutaname) [22:44:34] (03CR) 10jenkins-bot: [V: 04-1] Remove deprecated $wgHTCPMulticastAddress, $wgHTCPMulticastRouting and $wgHTCPPort [core] - 10https://gerrit.wikimedia.org/r/150761 (owner: 10Withoutaname) [22:44:37] (03PS1) 10Andrew Bogott: Replace support for 'ALL' in the 'Allow running as' sudo column. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/153723 [22:52:55] 3MediaWiki extensions / 3ProofreadPage: Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar - 10https://bugzilla.wikimedia.org/69447 (10Philippe Elie) 3NEW p:3Unprio s:3normal a:3None With preferences --> Edit --> deselect "Enable enhanced editing toolba... [22:53:16] (03PS3) 10Legoktm: Fix phpcs issues in actions and revisiondelete dirs [core] - 10https://gerrit.wikimedia.org/r/153469 (owner: 10Addshore) [22:53:23] (03CR) 10Legoktm: [C: 032] Fix phpcs issues in actions and revisiondelete dirs [core] - 10https://gerrit.wikimedia.org/r/153469 (owner: 10Addshore) [22:53:57] (03CR) 10Krinkle: [C: 04-1] "This no longer rebases cleanly and Monobook and Vector are now in separate repositories. We'll need to come up with a clean way of doing t" [core] - 10https://gerrit.wikimedia.org/r/151395 (owner: 10Arlolra) [22:54:08] 3MediaWiki extensions / 3ProofreadPage: Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar - 10https://bugzilla.wikimedia.org/69447 (10Philippe Elie) [22:54:46] (03PS3) 10Legoktm: Hygiene: Add sub-directories to phpunit test [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153458 (owner: 10Bsitu) [22:55:51] (03CR) 10Legoktm: [C: 032] Hygiene: Add sub-directories to phpunit test [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153458 (owner: 10Bsitu) [22:56:17] (03Merged) 10jenkins-bot: Hygiene: Add sub-directories to phpunit test [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153458 (owner: 10Bsitu) [22:56:40] (03CR) 10jenkins-bot: [V: 04-1] Fix phpcs issues in actions and revisiondelete dirs [core] - 10https://gerrit.wikimedia.org/r/153469 (owner: 10Addshore) [22:59:35] (03PS1) 10Bsitu: use array_merge_resursive when merging based on array keys [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153725 [22:59:43] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/153469 (owner: 10Addshore) [23:02:26] (03PS4) 10Catrope: ResourceLoader: Wrap only=script responses in "if(window.mw)" [core] - 10https://gerrit.wikimedia.org/r/152122 (owner: 10Krinkle) [23:04:03] (03CR) 10Catrope: [C: 032] Vector: Fix missing tab images on Special:Preferences [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/151425 (owner: 10Paladox) [23:06:42] (03CR) 10Legoktm: "jenkins wat" [core] - 10https://gerrit.wikimedia.org/r/153469 (owner: 10Addshore) [23:07:04] (03Merged) 10jenkins-bot: Vector: Fix missing tab images on Special:Preferences [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/151425 (owner: 10Paladox) [23:15:38] 3MediaWiki / 3ResourceLoader: ResourceLoader::getSkipFunction(): undefined variable $fileName - 10https://bugzilla.wikimedia.org/69214 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX [23:19:47] (03PS6) 10Jdlrobson: Make new topic content required [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151005 (owner: 10Werdna) [23:20:36] RoanKattouw: lower case component name is on purpose actually. [23:20:37] (03CR) 10SG: [C: 032] Make new topic content required [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151005 (owner: 10Werdna) [23:20:44] Oh? [23:20:45] (03PS5) 10Krinkle: resourceloader: Wrap only=script responses in "if(window.mw)" [core] - 10https://gerrit.wikimedia.org/r/152122 [23:21:08] (03Merged) 10jenkins-bot: Make new topic content required [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151005 (owner: 10Werdna) [23:21:25] (03CR) 10Bsitu: [C: 032] "We still have uncertainty on some of the notification behaviours. Merging for now since this is not in master branch. markasread behaviou" [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153708 (owner: 10Jdlrobson) [23:22:05] (03CR) 10jenkins-bot: [V: 04-1] F11: Show mark as read buttons in notification list items [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153708 (owner: 10Jdlrobson) [23:23:27] (03CR) 10Jdlrobson: [C: 032] "recheck" [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153708 (owner: 10Jdlrobson) [23:23:52] (03Merged) 10jenkins-bot: F11: Show mark as read buttons in notification list items [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153708 (owner: 10Jdlrobson) [23:28:42] (03PS5) 10Jdlrobson: Add documentation/cleanup markup for VForm labels [core] - 10https://gerrit.wikimedia.org/r/150418 [23:29:05] (03CR) 10Bsitu: [C: 04-1] "Need some test coverage" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153725 (owner: 10Bsitu) [23:30:07] What's the right channel to complain about superprotect? [23:30:27] not here [23:37:55] 3MediaWiki / 3Skin and page rendering: MediaWiki UI: VForm only partially documented - 10https://bugzilla.wikimedia.org/69449 (10Jon) 3NEW p:3Unprio s:3normal a:3None MediaWiki UI has a concept of a mw-ui-vform but it is badly documented and it is not clear when, where and how to use it. In the logi... [23:38:13] (03Abandoned) 10Jdlrobson: Add documentation/cleanup markup for VForm labels [core] - 10https://gerrit.wikimedia.org/r/150418 (owner: 10Jdlrobson) [23:45:54] (03PS7) 10Jdlrobson: Truncate text in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151805 (owner: 10Bsitu) [23:51:39] (03PS16) 10Jdlrobson: QA: Browser tests for Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151806 [23:52:01] (03PS2) 10Tim Landscheidt: Replace support for 'ALL' in the 'Allow running as' sudo column. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/153723 (https://bugzilla.wikimedia.org/68834) (owner: 10Andrew Bogott) [23:52:55] (03Abandoned) 10Jdlrobson: WIP: X on notification item to mark as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153529 (owner: 10Bsitu) [23:53:52] (03PS1) 10Jdlrobson: Truncate text in Echo notifications [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153731 [23:54:05] (03Abandoned) 10Jdlrobson: Truncate text in Echo notifications [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153731 (owner: 10Jdlrobson) [23:54:37] (03PS2) 10Bsitu: use array_merge_resursive when merging based on array keys [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153725 [23:55:39] (03Restored) 10Jdlrobson: Truncate text in Echo notifications [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153731 (owner: 10Jdlrobson) [23:55:48] (03Abandoned) 10Jdlrobson: Truncate text in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151805 (owner: 10Bsitu) [23:55:51] (03PS3) 10Bsitu: use array_merge_resursive when merging based on array keys [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153725 [23:57:36] (03CR) 10Jdlrobson: [C: 031] Truncate text in Echo notifications [extensions/Echo] (two_tabs) - 10https://gerrit.wikimedia.org/r/153731 (owner: 10Jdlrobson)