[00:08:19] legoktm: urgh [00:08:29] :O [00:08:38] Where are you? [00:08:57] in my room [00:09:04] Lame! :) [00:38:06] (03PS1) 10Legoktm: Convert Gadget definition namespace to use ContentHandler [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153270 [00:38:47] (03CR) 10Legoktm: "Because this is hacky and ugh." [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153074 (owner: 10Legoktm) [00:39:46] (03PS2) 10Legoktm: Convert Gadget definition namespace to use ContentHandler [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153270 [00:40:12] (03PS3) 10Legoktm: Convert Gadget definition namespace to use ContentHandler [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153270 (https://bugzilla.wikimedia.org/69318) [01:03:43] (03PS1) 10Legoktm: Add CodeEditorGetPageLanguage hook for Gadget definition namespace [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153271 [01:03:45] (03PS1) 10Legoktm: Standardize hook names and general clean up [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153272 [01:12:57] (03PS1) 10Bartosz Dziewoński: Remove some unnecessary IE 6 hacks [core] - 10https://gerrit.wikimedia.org/r/153273 [01:13:50] legoktm: you said you were going to bed :-P [01:14:08] I'm in bed.... [01:14:22] ;) [01:15:58] LOL [01:16:02] Fine :-P [01:16:12] hah [01:16:18] legoktm: wanna merge some patches? [01:16:26] sure [01:16:29] i pushed some boring ones out this evening [01:16:38] https://gerrit.wikimedia.org/r/#/q/owner:%22Bartosz+Dziewo%25C5%2584ski%22+status:open,n,z [01:17:07] (03PS2) 10Legoktm: Move Vector's hooks documentation to mediawiki/skins/Vector [core] - 10https://gerrit.wikimedia.org/r/153080 (owner: 10Bartosz Dziewoński) [01:17:11] (03CR) 10Legoktm: [C: 032] Move Vector's hooks documentation to mediawiki/skins/Vector [core] - 10https://gerrit.wikimedia.org/r/153080 (owner: 10Bartosz Dziewoński) [01:17:21] (03CR) 10Legoktm: [C: 032 V: 032] Move hooks.txt docs from mediawiki/core [skins/Vector] - 10https://gerrit.wikimedia.org/r/153082 (owner: 10Bartosz Dziewoński) [01:18:19] (03PS2) 10Jackmcbarn: Fix deceptively-simple pattern in pure-Lua ustring [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145413 (owner: 10Anomie) [01:19:51] (03PS2) 10Legoktm: Never display empty sections on Special:Version [core] - 10https://gerrit.wikimedia.org/r/152991 (owner: 10Bartosz Dziewoński) [01:19:56] (03CR) 10Legoktm: [C: 032] Never display empty sections on Special:Version [core] - 10https://gerrit.wikimedia.org/r/152991 (owner: 10Bartosz Dziewoński) [01:20:30] (03CR) 10Jackmcbarn: [C: 032] Fix deceptively-simple pattern in pure-Lua ustring [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145413 (owner: 10Anomie) [01:20:40] (03Merged) 10jenkins-bot: Move Vector's hooks documentation to mediawiki/skins/Vector [core] - 10https://gerrit.wikimedia.org/r/153080 (owner: 10Bartosz Dziewoński) [01:20:48] whoo [01:22:20] (03Merged) 10jenkins-bot: Fix deceptively-simple pattern in pure-Lua ustring [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145413 (owner: 10Anomie) [01:23:15] (03CR) 10Legoktm: "If this is still needed, should be resubmitted to skins/Vector." [core] - 10https://gerrit.wikimedia.org/r/138369 (owner: 10Bartosz Dziewoński) [01:23:32] it is [01:23:34] and it will be [01:23:41] hmmmm legoktm [01:23:53] i think Skin::newFromKey() doesn't need the fallback checking [01:23:59] normalizeKey() should already handle this [01:24:01] (03Merged) 10jenkins-bot: Never display empty sections on Special:Version [core] - 10https://gerrit.wikimedia.org/r/152991 (owner: 10Bartosz Dziewoński) [01:25:29] (03PS1) 10Bartosz Dziewoński: Skin: Don't double-check for non-existing skin in newFromKey() [core] - 10https://gerrit.wikimedia.org/r/153274 [01:25:54] (03CR) 10Bartosz Dziewoński: "Note that I have merely proven this code correct and did not test it." [core] - 10https://gerrit.wikimedia.org/r/153274 (owner: 10Bartosz Dziewoński) [01:31:06] (03PS1) 10Isarra: MAIMING THE CSS [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153275 [01:31:37] (03PS7) 10Bartosz Dziewoński: [DO NOT MERGE] Completely remove skin autodiscovery [core] - 10https://gerrit.wikimedia.org/r/135439 (https://bugzilla.wikimedia.org/65748) [01:33:05] (03CR) 10Legoktm: [C: 04-1] Skin: Don't double-check for non-existing skin in newFromKey() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153274 (owner: 10Bartosz Dziewoński) [01:33:37] (03CR) 10Bartosz Dziewoński: "Oh fucking stupid PHP." [core] - 10https://gerrit.wikimedia.org/r/153274 (owner: 10Bartosz Dziewoński) [01:34:36] (03PS2) 10Bartosz Dziewoński: Skin: Don't double-check for non-existing skin in newFromKey() [core] - 10https://gerrit.wikimedia.org/r/153274 [01:35:04] (03PS1) 10Jackmcbarn: Add 2 tests to unitTestsList [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/153276 [01:35:16] (03CR) 10jenkins-bot: [V: 04-1] Skin: Don't double-check for non-existing skin in newFromKey() [core] - 10https://gerrit.wikimedia.org/r/153274 (owner: 10Bartosz Dziewoński) [01:35:52] ; [01:36:05] (03PS3) 10Bartosz Dziewoński: Skin: Don't double-check for non-existing skin in newFromKey() [core] - 10https://gerrit.wikimedia.org/r/153274 [01:36:16] * MatmaRex stabs PHP [01:36:21] (03CR) 10Legoktm: [C: 032] Skin: Don't double-check for non-existing skin in newFromKey() [core] - 10https://gerrit.wikimedia.org/r/153274 (owner: 10Bartosz Dziewoński) [01:36:24] :o [01:36:27] are you sure this will work? [01:36:40] I tested it [01:36:43] i am pretty sure, but also it is almost 3 am [01:36:44] oh [01:36:45] okay [01:37:15] we should start killing skins/common/. [01:37:51] +1 bajillion [01:37:57] where can we put the various image files that are being referred to directly from HTML, and not from CSS? [01:38:03] resources/assets/? [01:38:06] resources/images/? [01:38:20] there is also some installer crap that isn't passed thru ResourceLoader [01:38:41] this stuff needs to be in a web-accessible directory [01:38:51] but using resources/ feels almost as bad as using skins/ [01:39:03] BUT i don't want a third directory to keep images in [01:39:12] well, fourth [01:39:31] hmmmmmmmm. [01:39:36] maybe it could go in mw-config/? [01:39:44] that sounds reasonable [01:39:45] (03Merged) 10jenkins-bot: Skin: Don't double-check for non-existing skin in newFromKey() [core] - 10https://gerrit.wikimedia.org/r/153274 (owner: 10Bartosz Dziewoński) [01:39:54] thank you for being my rubber duckie, #wikimedia-dev [01:39:55] putting images in resources sounds pretty reasonable to me... [01:40:14] "resources" means "ResourceLoader resources" for me [01:40:36] things like skins/common/images/icons/ are not RL resources [01:40:46] they get put in on file pages [01:41:36] also, i bet we're going to have TONS of fun when the files are moved and cached HTML is still referring to old locations [01:41:59] only installer stuff should go in mw-config [01:42:03] yes [01:42:09] but there's a lot of that too [01:42:14] like ten different icons [01:42:15] well, only copy the files for now and remove common after 30 days? [01:42:18] ugh [01:42:34] and three-ish other files [01:43:00] most of the .js stuff could go into resources/mediawiki.legacy/, until someone finally kills it for good [01:43:09] (03PS1) 10Kunalgrover05: Using ULS in Special:PageLanguage Implemented LanguageSelector hook [core] - 10https://gerrit.wikimedia.org/r/153277 [01:43:25] common*.css is also going to be a MASSIVE pain in the ass [01:43:37] since we've just deprecated referring to these files directly in 1.23 [01:43:40] lets move the easy ones first? [01:43:53] so we're going to break some skins if we remove them [01:44:13] or rather, force them to be compatible with either MW<=1.23 or MW>=1.23, not both [01:44:36] yeah, we should start with that [01:44:54] i am just saying how much this all sucks [01:45:16] added the new stuff in 1.23, deprecate the old in 1.24, and remove in 1.25? [01:46:02] blergh [01:46:07] that might be a good option [01:46:24] i'm just wondering which is going to be least annoying for everyone [01:46:34] going to sleep now, goodnight! [01:46:39] night FlorianSW [01:46:50] having skins/common is the most annoying so :P [01:46:52] would be great if skins/common/ was gone with 1.24, so everyone could sanely use the skins/ directory like extensions/ [01:46:57] but eh [01:47:03] i dunno [01:47:09] legoktm: thanks :P [01:47:15] sleep well ~ [01:47:26] we're fucked no matter how we do this [01:47:38] 3Wikimedia / 3Interwiki links: Make interwiki links work on new testwiki HHVM server - 10https://bugzilla.wikimedia.org/69332#c4 (10This, that and the other (TTO)) Corrected bug summary for posterity's sake. [01:47:39] (03PS2) 10Kunalgrover05: Using ULS in Special:PageLanguage [core] - 10https://gerrit.wikimedia.org/r/153277 [01:47:41] right [01:48:13] MatmaRex: Thanks too :D [01:48:15] right, let's try doing the easy stuff first, and then we'll be able to see exactly how deep in crap we are [01:48:40] ("easy stuff" seems to be installer and mw.legacy right now) [01:48:56] (and also all of the images that aren't actually used anywhere) [01:48:58] (03CR) 10Kunalgrover05: "Depends on I30459d32633c3d61129ce1759c0d87717d0fa8d9" [core] - 10https://gerrit.wikimedia.org/r/153277 (owner: 10Kunalgrover05) [01:52:05] (03CR) 10Legoktm: [C: 04-1] Convert Gadget definition namespace to use ContentHandler [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153270 (https://bugzilla.wikimedia.org/69318) (owner: 10Legoktm) [02:06:01] (03CR) 10Helder.wiki: Standardize hook names and general clean up (031 comment) [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153272 (owner: 10Legoktm) [02:08:06] (03PS1) 10Bartosz Dziewoński: Vector: Remove compatibility for old variant menu HTML [skins/Vector] - 10https://gerrit.wikimedia.org/r/153278 [02:08:43] (03CR) 10Bartosz Dziewoński: "It is, and it should. Resubmitted as https://gerrit.wikimedia.org/r/153278 (same Change-Id)." [core] - 10https://gerrit.wikimedia.org/r/138369 (owner: 10Bartosz Dziewoński) [02:08:56] (03Abandoned) 10Bartosz Dziewoński: Vector: Remove compatibility for old variant menu HTML [core] - 10https://gerrit.wikimedia.org/r/138369 (owner: 10Bartosz Dziewoński) [02:14:07] (03CR) 10Legoktm: "Can be merged on/around August 22nd." [skins/Vector] - 10https://gerrit.wikimedia.org/r/153278 (owner: 10Bartosz Dziewoński) [02:18:57] (03CR) 10Werdna: [C: 04-1] "Added one -1 – I do feel like we need to make sure that these isWatched / isAlwaysWatched bits are checked correctly." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149210 (owner: 10Werdna) [02:24:02] (03PS1) 10Mattflaschen: Fix documentation for Html::closeElement [core] - 10https://gerrit.wikimedia.org/r/153279 [02:24:58] (03CR) 10Bartosz Dziewoński: [C: 032] Fix documentation for Html::closeElement [core] - 10https://gerrit.wikimedia.org/r/153279 (owner: 10Mattflaschen) [02:26:42] (03CR) 10Mattflaschen: "Thanks, my mistake. I fixed the docs in https://gerrit.wikimedia.org/r/#/c/153279/" [core] - 10https://gerrit.wikimedia.org/r/152778 (https://bugzilla.wikimedia.org/52210) (owner: 10Mattflaschen) [02:27:37] (03PS1) 10Legoktm: [WIP] Convert Gadget definition namespace to use ContentHandler [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/153280 (https://bugzilla.wikimedia.org/69318) [02:27:39] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Convert Gadget definition namespace to use ContentHandler [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/153280 (https://bugzilla.wikimedia.org/69318) (owner: 10Legoktm) [02:27:44] (03Merged) 10jenkins-bot: Fix documentation for Html::closeElement [core] - 10https://gerrit.wikimedia.org/r/153279 (owner: 10Mattflaschen) [02:27:54] (03Abandoned) 10Legoktm: [WIP] Convert Gadget definition namespace to use ContentHandler [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/153280 (https://bugzilla.wikimedia.org/69318) (owner: 10Legoktm) [02:28:00] I need to stop doing that. [02:28:58] (03PS4) 10Legoktm: [WIP] Convert Gadget definition namespace to use ContentHandler [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153270 (https://bugzilla.wikimedia.org/69318) [02:29:26] that what? [02:42:24] helderwiki: writing good code / legoktm [02:52:17] Sweet, Firefox's responsive design mode has a screenshot tool, which also means you can screenshot a window (excluding the Firefox UI elements), which is normally annoying to do in Firefox. [02:54:47] window or entire page? [02:55:07] oh, window [02:56:36] if you're using windows, I've found mapping snipping tool to a keyboard shortcut invaluable (it basically mimics the cmd+shift+4 behaviour on OS X) [03:17:10] (03CR) 10Mattflaschen: [C: 032] "Tested with Firefox's responsive design mode." [core] - 10https://gerrit.wikimedia.org/r/152153 (owner: 10Jdlrobson) [03:20:16] (03Merged) 10jenkins-bot: Make styleguide mobile first [core] - 10https://gerrit.wikimedia.org/r/152153 (owner: 10Jdlrobson) [03:35:08] 3MediaWiki extensions / 3Spam Blacklist: Log full URLs that hit the blacklist as well on Special:Log/spamblacklist - 10https://bugzilla.wikimedia.org/55356#c6 (10Dirk Beetstra) Can we please have a fix for this. In addition, a way to find links that were attempted to be spammed would be a nice addition as w... [04:12:23] 3MediaWiki / 3Skin and page rendering: Implement checkbox spec in mediawiki.ui - 10https://bugzilla.wikimedia.org/69200#c14 (10Matthew Flaschen) (In reply to Jared Zimmerman (WMF) from comment #13) > I added a black, grey, and green version of the check to the trello board. Could someone please change the s... [04:48:10] 3MediaWiki extensions / 3WikiEditor: Toolbar missing on custom skin - 10https://bugzilla.wikimedia.org/69357 (10sr) 3UNCO p:3Unprio s:3normal a:3None I am running a 1.23 version of the MediaWiki. Recently, I made my first custom skin. The toolbar shows up on other default skins provided by MediaWiki... [06:00:42] (03PS6) 10Bsitu: [WIP]Add TargetPage model and mapper to notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151992 [06:02:47] (03CR) 10Bsitu: [C: 04-1] [WIP]Create TargetPage data if specified by EchoEvent (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152808 (owner: 10Bsitu) [06:03:50] (03CR) 10Bsitu: Auto mark notification as read if it doesn't have target page (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152203 (owner: 10Bsitu) [06:04:03] (03PS3) 10Umherirrender: Fix doc of PPFrame_Hash::cachedExpand [core] - 10https://gerrit.wikimedia.org/r/151610 [06:19:36] (03CR) 10Bsitu: "I probably shouldn't change the directory structure till we merge all the remaining Echo patches that add unit tests." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152204 (owner: 10Bsitu) [07:14:06] (03CR) 10Hashar: [C: 032] "Job config refreshed http://integration.wikimedia.org/ci/job/mwext-TranslateSvg-testextensions-master/" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/153130 (owner: 10Jarry1250) [07:15:17] (03Merged) 10jenkins-bot: Add separate entry for TranslateSVG to note dependency [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/153130 (owner: 10Jarry1250) [08:10:20] (03PS8) 10Chmarkine: Use protocol relative URLs for some links on Transparency Report pages [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153026 [08:14:42] (03CR) 10Chmarkine: "https://www.law.berkeley.edu/bclt.htm contains mixed content (js and css loaded over http), so I think we'd better not change it to protoc" [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153026 (owner: 10Chmarkine) [08:41:26] (03PS11) 10Addshore: Fix for Ia9baaf0b: magic functions for previously public class members [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [08:46:10] (03CR) 10Alex Monk: "do we need license headers on the new files?" [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153270 (https://bugzilla.wikimedia.org/69318) (owner: 10Legoktm) [08:50:08] 3MediaWiki / 3Page editing: Translatable pages (pages using Translate extension syntax) create unusable section edit (editsection) links - 10https://bugzilla.wikimedia.org/42239#c11 (10Liangent) BTW editing such section on mobile shows a loading icon forever. [08:54:05] (03CR) 10Anomie: [C: 032] Add 2 tests to unitTestsList [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/153276 (owner: 10Jackmcbarn) [08:56:00] (03Merged) 10jenkins-bot: Add 2 tests to unitTestsList [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/153276 (owner: 10Jackmcbarn) [09:05:13] (03PS12) 10Foxtrott: Fix for Ia9baaf0b: magic functions for previously public class members [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) [09:07:37] (03PS2) 10Alex Monk: Add CodeEditorGetPageLanguage hook for Gadget definition namespace [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153271 (owner: 10Legoktm) [09:09:20] (03CR) 10Alex Monk: [C: 032] Add CodeEditorGetPageLanguage hook for Gadget definition namespace [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153271 (owner: 10Legoktm) [09:09:27] (03PS2) 10Mitar: Really fail if OAuth request source IP is invalid. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153028 [09:10:30] (03PS3) 10Mitar: Really fail if OAuth request source IP is invalid. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153028 [09:17:23] 3MediaWiki extensions / 3CentralAuth: Accounts magically unattached despite being recently created - 10https://bugzilla.wikimedia.org/39996#c88 (10Marius Hoch) (In reply to Marius Hoch from comment #87) > As another update: I've just deployed a fix for a race condition which > *might* be the cause of this bu... [09:17:39] (03PS2) 10Alex Monk: Standardize hook names and general clean up [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153272 (owner: 10Legoktm) [09:19:31] (03PS3) 10Alex Monk: Standardize hook names and general clean up [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153272 (owner: 10Legoktm) [09:19:48] (03CR) 10Alex Monk: [C: 032] "Fixed a typo in docs" [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153272 (owner: 10Legoktm) [09:26:19] (03PS2) 10Jforrester: build: Make into a built library, importing test infrastructure from previous repo [unicodejs] - 10https://gerrit.wikimedia.org/r/153078 [09:27:38] I am trying to run Vagrant and I am getting - An error occurred while installing nokogiri (1.6.3.1), and Bundler cannot continue. [09:27:38] - Make sure that `gem install nokogiri -v '1.6.3.1'` succeeds before bundling. [09:27:38] Failed to execute command `vagrant plugin install vagrant-vbguest` (pid 51283 exit 1) [09:27:54] I thought that it will be easy to use Vagrant ;-) [09:30:50] Mitar: That nokogiri error has been a pain on and off for the last month. Sorry [09:31:39] how does one make ruby install locally and not globally? I set GEM_HOME to some subdirectory of my home directory? [09:32:13] It should be installing the gem via a bundler instance that is local to the Vagrant install [09:33:06] oh [09:33:10] so what can i do? [09:33:13] We have had reports of people hitting the error who have "fixed" by using sudo. When it happened to me, it eventually worked by just retrying several times [09:33:14] is there a verbose flag? [09:33:24] i am not using sudo :-) [09:33:47] aha [09:33:48] nokogiri requires Ruby version >= 1.9.2. [09:34:02] there is no mention of requirements? [09:35:55] 3MediaWiki / 3Database: missing 'patch-add_interwiki.sql' for the includes/installer/PostgresqlUpdater.php - 10https://bugzilla.wikimedia.org/69360 (10Anton Kochkov) 3NEW p:3Unprio s:3normal a:3None See the last functions in the file 'includes/installer/PostgresqlUpdater.php': protected function add... [09:36:05] Mitar: You might read through https://bugzilla.wikimedia.org/show_bug.cgi?id=68453 and https://bugzilla.wikimedia.org/show_bug.cgi?id=69052 to see if there are any tips buried in those bugs [09:36:54] * bd808 is re-reading himself to remember what happened [09:38:45] Mitar: There is an upstream bug report as well -- https://github.com/mitchellh/vagrant/issues/3769 [09:42:03] i am also reading that there will be nfs issues on mac os x? [09:42:17] should i just give up on vagrant and just try to use it directly? [09:42:35] i would just like to test one patch for an oauth extension [09:42:49] is there some labs tool where i could get an instance of mediawiki running? [09:42:55] 3MediaWiki extensions / 3CirrusSearch: Problem with the search in Hebrew - 10https://bugzilla.wikimedia.org/69361 (10eitan96) 3UNCO p:3Unprio s:3normal a:3None In Hebrew there is special characters used for vowels called "nikud". When there is word with this characters on wiki the search find this wo... [09:42:59] Mitar: I use osx and nfs with vagrant with no issues. [09:44:21] Mitar: IN labs proper (dedicated vm) you van use role::labs::vagrant to setup wikis using the puppet config from MediaWiki-Vagrant -- https://wikitech.wikimedia.org/wiki/Labs-vagrant [09:44:23] i am a bit lost so what is a fix? [09:45:34] Mitar: You are on OSX? You could try `/Applications/Vagrant/embedded/bin/gem install nokogiri -- --use-system-libraries=true --with-xml2-include=/usr/include/libxml2` to see if that fixes or gives better error feedback [09:46:08] That uses the ruby that ships with Vagrant to install the latest nokogiri gem [09:47:15] You could also try the config change given in to pin nokogiri to a reported working version [09:47:24] You don't have write permissions for the /Applications/Vagrant/embedded/lib/ruby/gems/2.0.0 directory. [09:47:29] legoktm: ping [09:47:46] i will chown that dir to me [09:49:41] You don't have write permissions for the /Applications/Vagrant/embedded/bin directory. [09:50:27] Mitar: If you want to work without sudo you should probably chown all of /Applications/Vagrant [09:50:37] :-( [09:51:36] bd808, what's the best way to permanently increase the memory size for the vagrant vm? [09:52:53] (03PS1) 10Hoo man: Fix the race condition detection in CentralAuthUser::attach [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153285 [09:52:57] legoktm: ^ [09:53:09] Eloquence: vagrant config vagrant_ram $RAM_IN_MB [09:53:10] might be backport-worthy (tomorrow) [09:53:20] ? [09:53:54] Eloquence: That will add a value in .settings.yaml that Vagrantfile will pick up. Then `vagrant reload` to resize your VM [09:54:47] perfect, thanks :) [09:56:47] now /Applications/Vagrant/embedded/bin/gem install nokogiri -- --use-system-libraries=true --with-xml2-include=/usr/include/libxml2 works [09:57:23] 3MediaWiki-Vagrant: Unprivileged user can't install nokogiri gem so setup.sh fails - 10https://bugzilla.wikimedia.org/69052#c14 (10Bryan Davis) There is an upstream bug report at https://github.com/mitchellh/vagrant/issues/3769 . It seems that this may be an artifact of a particular broken version of the nokog... [09:57:33] but it still fails [09:57:52] Mitar: New error message or same old problem? [09:58:36] same old message, but probably different reason [09:58:39] there is no verbose flag? [09:59:21] Mitar: Via an env var `VAGRANT_LOG=debug vagrant up` [10:00:04] but for now ./setup fails [10:00:09] 3MediaWiki-Vagrant: Unprivileged user can't install nokogiri gem so setup.sh fails - 10https://bugzilla.wikimedia.org/69052#c15 (10Mitar) I have the same problem, but with clean installation. [10:01:35] Ah. Try the same trick `VAGRANT_LOG=debug ./setup.sh` I'm not sure if that works or not [10:03:15] Mitar: `VAGRANT_LOG=debug vagrant plugin install vagrant-vbguest` may be useful if setup won't log more verbosely [10:03:35] Once the plugin is installed it won't try to update it or install it again [10:04:02] hm, is anyone here at wikimania and maybe we could look at this in person? [10:04:24] setup.{sh,bat} is a wrapper to run that plugin install command and then compile and install our custom Vagrant plugin [10:05:05] The real logic is in lib/mediawiki-vagrant/setup.rb [10:05:48] no help [10:05:54] more verbose logging does not tell anything new [10:06:05] because it does not run underling gem installation verbose [10:12:36] Mitar: Sorry you are having so many problems. [10:18:29] bd808: it's your fault [10:18:53] bd808: fix everything plz [10:18:58] ori: I know it totally is :( I haven't rewritten vagrant in python yet! [10:19:07] the day is young [10:19:27] ori: True. Wife gets here today though and vacation starts [10:21:02] nit: i hate that it's "vagrant_ram" [10:21:07] it should just be "ram" [10:29:53] (03CR) 10BryanDavis: [C: 031] "LGTM" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153285 (owner: 10Hoo man) [10:36:26] (03CR) 10Alex Monk: [C: 04-1] "probably" [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153270 (https://bugzilla.wikimedia.org/69318) (owner: 10Legoktm) [10:37:32] (03PS1) 10Legoktm: Require a ResourceLoader instance is passed to ResourceLoaderContext [core] - 10https://gerrit.wikimedia.org/r/153291 [10:38:59] (03CR) 10Legoktm: "Fix proposed in Ie1e5453b47349fc00664325827f88a1e7a6de43f, thanks!" [core] - 10https://gerrit.wikimedia.org/r/152243 (owner: 10Legoktm) [10:40:13] (03CR) 10Legoktm: [C: 032] Fix the race condition detection in CentralAuthUser::attach [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153285 (owner: 10Hoo man) [10:40:21] (03Merged) 10jenkins-bot: Fix the race condition detection in CentralAuthUser::attach [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153285 (owner: 10Hoo man) [10:43:26] 3Wikimedia / 3Media storage: Files disappear and give 404's for the full resolution - 10https://bugzilla.wikimedia.org/69362 (10Marco) 3NEW p:3Unprio s:3normal a:3None Examples: https://commons.wikimedia.org/wiki/File:Brother%27s_Keeper_Operation_in_Judea_%26_Samaria_%2814248086727%29.jpg https://co... [10:45:25] 3Wikimedia / 3Media storage: 404 error for all revisions of some files - 10https://bugzilla.wikimedia.org/39615 (10Marco) [10:45:25] 3Wikimedia / 3Media storage: Files disappear and give 404's for the full resolution - 10https://bugzilla.wikimedia.org/69362 (10Marco) [10:45:25] RoanKattouw: https://gerrit.wikimedia.org/r/153291 [10:52:25] 3Wikimedia / 3Site requests: Disable Media Viewer by default for logged-in users on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69363 (10Tisza Gergő) 3NEW p:3Unprio s:3normal a:3None Per the WMF response to the Media Viewer RfC on Commons: https://commons.wikimedia.org/wiki/Commons_talk:Req... [10:54:54] 3Wikimedia / 3Site requests: Disable Media Viewer by default for logged-in users on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69363 (10Tisza Gergő) [10:54:54] 3Wikimedia / 3Site requests: Disable Media Viewer software feature by default on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69080#c24 (10Tisza Gergő) Filed bug 69363 about disabling for logged-in users. [11:12:38] 3MediaWiki-Vagrant: role::hadoop will not provision on Ubuntu 14.04 (MediaWiki-Vagrant default) - 10https://bugzilla.wikimedia.org/68302 (10Bryan Davis) p:5Unprio>3Normal s:5normal>3major [11:14:56] (03PS1) 10Filippo Giunchedi: README.md: add submodules instructions [vagrant] - 10https://gerrit.wikimedia.org/r/153294 [11:19:53] 3Wikimedia / 3Media storage: Files disappear and give 404's for the full resolution - 10https://bugzilla.wikimedia.org/69362#c1 (10Gilles Dubuc) Did you encounter these randomly or do you have a method to compile that list automatically? [11:21:39] (03CR) 10BryanDavis: [C: 032] README.md: add submodules instructions [vagrant] - 10https://gerrit.wikimedia.org/r/153294 (owner: 10Filippo Giunchedi) [11:21:44] (03Merged) 10jenkins-bot: README.md: add submodules instructions [vagrant] - 10https://gerrit.wikimedia.org/r/153294 (owner: 10Filippo Giunchedi) [11:27:12] I'm gonna get Vagrant set up today. [11:27:50] Then I won't have to hit enwp with a load of API calls because I'll have a local wiki, right? [11:28:34] issyl0: Up in the garden room on 3 there should be someone with a USB stick to make it easier. I'll be there after lunch. [11:29:24] 3MediaWiki / 3Documentation: CORS docs for MediaWiki Web API? - 10https://bugzilla.wikimedia.org/55928 (10Kunal Mehta (Legoktm)) 5NEW>3RESO/FIX [11:30:40] Issyl0: just remember your local wiki wont have wikipedia's data (unless you import a dump, which is really hard) [11:33:11] (03CR) 10Mwjames: [C: 031] "This allows for our tests to pass on MW master again." [core] - 10https://gerrit.wikimedia.org/r/153291 (owner: 10Legoktm) [11:34:59] bawolff: Hmm, good point. [11:36:05] (03CR) 10Addshore: [C: 032] Require a ResourceLoader instance is passed to ResourceLoaderContext [core] - 10https://gerrit.wikimedia.org/r/153291 (owner: 10Legoktm) [11:38:47] (03Merged) 10jenkins-bot: Require a ResourceLoader instance is passed to ResourceLoaderContext [core] - 10https://gerrit.wikimedia.org/r/153291 (owner: 10Legoktm) [11:41:05] hey bawolff, just wanted to check-in and make sure we don't overlap work on the species.net mp3 files … are you planning to convert those species.net mp3 files? i've got a script i'm writing that i am planning to use to do it so you wouldn't need to … just need to sort out the best ffmpeg settings if you happen to know them? [11:41:57] Issyl0: depending on your usecase maybe tool labs sql access be well suited [11:42:12] dan-nl: i havent done anything [11:42:33] bawolff: cool, i use the script i'm writing to take care of it then [11:42:51] do you happen to know about settings for ffmpeg that would be best for the conversion? [11:42:52] dan-nl: more or less its just ffmpeg -i file.mp3 file.ogg [11:43:01] k, thanks [11:43:16] you can specify extra stuff, but defaults usually good enough [11:43:52] Just check that ffmpeg doesnt convert to flac [11:44:23] 3Wikimedia / 3Site requests: Disable Media Viewer by default for logged-in users on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69363 (10Andre Klapper) p:5Unprio>3Normal [11:46:03] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153028 (owner: 10Mitar) [11:46:04] Sorry, i kind of wish i went to the gwtoolset session [11:46:24] ive heard all this multimedia stuff before [11:47:46] Dan-nl if ffmpeg does try to go ogg/flac you just need -acodec vorbis or something [11:48:20] bawolff: thanks [11:48:59] also ideally you can specify -metadata options to add ogg comments ideally [11:49:41] since metadata is awesome [11:50:53] 3MediaWiki extensions / 3CirrusSearch: Problem with the search in Hebrew - 10https://bugzilla.wikimedia.org/69361#c1 (10Andre Klapper) Thanks for taking the time to report this! Could you please provide one exact example here with exact steps to reproduce, so anybody else could follow these steps? Thanks in... [11:56:25] 3Wikimedia / 3Media storage: Files disappear and give 404's for the full resolution - 10https://bugzilla.wikimedia.org/69362#c2 (10Bawolff (Brian Wolff)) Aaron is working on a script to find these. [11:56:31] (03CR) 10Siebrand: [C: 04-1] "I've added this and the dependency on translatewiki.net production. It doesn't work for me (tested on https://translatewiki.net/wiki/Speci" [core] - 10https://gerrit.wikimedia.org/r/153277 (owner: 10Kunalgrover05) [11:57:40] 3MediaWiki / 3Export/Import: Importing does not work with HHVM - 10https://bugzilla.wikimedia.org/66023#c5 (10MWJames) (In reply to Brett Simmers from comment #4) > I'm debugging an issue with it right now. I'm hoping to have it cleaned up > and committed by Monday, so it should be in the next nightly after... [11:59:53] bawolff: nice, i'll need to look into that [12:01:28] (03PS3) 10Legoktm: Fix userrights-interwiki when the 'user' table is shared [core] - 10https://gerrit.wikimedia.org/r/111532 (owner: 10UltrasonicNXT) [12:01:31] (03CR) 10Legoktm: [C: 032] Fix userrights-interwiki when the 'user' table is shared [core] - 10https://gerrit.wikimedia.org/r/111532 (owner: 10UltrasonicNXT) [12:04:44] (03CR) 10Hoo man: [C: 032] "No-op now and makes sense with the linked patch. Please revert if the patch is not going to make it (in the way it is on gerrit now)." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/153084 (owner: 10Anomie) [12:04:52] (03Merged) 10jenkins-bot: Update token handling for core API change [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/153084 (owner: 10Anomie) [12:05:04] (03Merged) 10jenkins-bot: Fix userrights-interwiki when the 'user' table is shared [core] - 10https://gerrit.wikimedia.org/r/111532 (owner: 10UltrasonicNXT) [12:15:57] (03PS2) 10BryanDavis: replace packages.pp w/require_package() function [vagrant] - 10https://gerrit.wikimedia.org/r/152816 (owner: 10Ori.livneh) [12:26:54] (03PS1) 10Ebe123: Remove duplicate translations [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/153301 [12:26:54] bd808: Thanks. [12:27:59] bd808: I don't think I'll need a data dump - I just need one or two users and some pages that I can make myself, and editing, and rollback permissions. [12:28:20] (03PS2) 10Ebe123: Remove duplicate translations [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/153301 [12:28:26] Dammit. I forgot my charger *again*. [12:28:35] I've got four hours left apparently. :-) [12:31:07] (03CR) 10Legoktm: "Did you want to backport this?" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153285 (owner: 10Hoo man) [12:35:58] Do I need Gerrit? I'm not working directly on MediaWiki code. [12:36:02] I've said no for now. [12:36:50] (03CR) 10Legoktm: "I've thought the dash was weird too. What about just having the hash with no parentheses, since that is technically the version of the ext" [core] - 10https://gerrit.wikimedia.org/r/137968 (owner: 10UltrasonicNXT) [12:37:48] (03PS3) 10BryanDavis: replace packages.pp w/require_package() function [vagrant] - 10https://gerrit.wikimedia.org/r/152816 (owner: 10Ori.livneh) [12:38:31] (03CR) 10Legoktm: [C: 04-1] "Needs rebase" [core] - 10https://gerrit.wikimedia.org/r/138300 (owner: 10Brian Wolff) [12:41:53] 3MediaWiki extensions / 3WikiEditor: Toolbar missing on custom skin - 10https://bugzilla.wikimedia.org/69357#c1 (10Andre Klapper) Error console of my browser (Firefox 31) says: "Exception thrown by ext.wikiEditor.publish" load.php:145 "TypeError: copyWarnHTML is undefined" TypeError: copyWarnHTML is unde... [12:42:22] (03CR) 10Legoktm: "I'd like to see this move forward, Nemo's suggestion sounds like a good one." [core] - 10https://gerrit.wikimedia.org/r/139654 (owner: 10Brian Wolff) [12:45:31] (03Abandoned) 10Lewis Cawte: Push latest copy from ShoutWiki SVN with various updates and changes. [extensions/ShoutWikiAds] - 10https://gerrit.wikimedia.org/r/152044 (owner: 10Lewis Cawte) [12:54:40] (03CR) 10Legoktm: [C: 032] Update token handling for core API change [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/153086 (owner: 10Anomie) [12:54:47] (03Merged) 10jenkins-bot: Update token handling for core API change [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/153086 (owner: 10Anomie) [12:55:13] (03CR) 10Legoktm: [C: 032] Update token handling for core API change [extensions/MarkAsHelpful] - 10https://gerrit.wikimedia.org/r/153098 (owner: 10Anomie) [12:55:18] (03Merged) 10jenkins-bot: Update token handling for core API change [extensions/MarkAsHelpful] - 10https://gerrit.wikimedia.org/r/153098 (owner: 10Anomie) [12:57:17] (03CR) 10Legoktm: [C: 032] Update token handling for core API change [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/153096 (owner: 10Anomie) [12:57:26] (03Merged) 10jenkins-bot: Update token handling for core API change [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/153096 (owner: 10Anomie) [12:57:35] (03CR) 10Legoktm: [C: 032] Update token handling for core API change [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/153100 (owner: 10Anomie) [12:57:42] (03Merged) 10jenkins-bot: Update token handling for core API change [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/153100 (owner: 10Anomie) [12:59:11] (03PS1) 10Tpt: Changes the mouse wheel direction to zoom [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/153304 [12:59:40] (03CR) 10Legoktm: [C: 032] Update token handling for core API change [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/153094 (owner: 10Anomie) [13:00:26] (03CR) 10Legoktm: [C: 031] Update token handling for core API change [extensions/Survey] - 10https://gerrit.wikimedia.org/r/153104 (owner: 10Anomie) [13:01:35] (03Merged) 10jenkins-bot: Update token handling for core API change [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/153094 (owner: 10Anomie) [13:05:22] (03CR) 10Legoktm: [C: 032] "Do we even care about this extension anymore?" [extensions/CongressLookup] - 10https://gerrit.wikimedia.org/r/153088 (owner: 10Anomie) [13:05:27] (03Merged) 10jenkins-bot: Update token handling for core API change [extensions/CongressLookup] - 10https://gerrit.wikimedia.org/r/153088 (owner: 10Anomie) [13:06:26] (03CR) 10Legoktm: [C: 031] Update token handling for core API change [extensions/Contest] - 10https://gerrit.wikimedia.org/r/153090 (owner: 10Anomie) [13:09:24] (03CR) 10Legoktm: [C: 031] Update token handling for core API change [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/153101 (owner: 10Anomie) [13:09:43] (03CR) 10Anomie: "> Do we even care about this extension anymore?" [extensions/CongressLookup] - 10https://gerrit.wikimedia.org/r/153088 (owner: 10Anomie) [13:09:45] (03CR) 10Legoktm: [C: 032] Update token handling for core API change [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/153097 (owner: 10Anomie) [13:09:50] (03Merged) 10jenkins-bot: Update token handling for core API change [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/153097 (owner: 10Anomie) [13:10:45] (03CR) 10Legoktm: [C: 032] Update token handling for core API change [extensions/Ratings] - 10https://gerrit.wikimedia.org/r/153103 (owner: 10Anomie) [13:10:49] (03Merged) 10jenkins-bot: Update token handling for core API change [extensions/Ratings] - 10https://gerrit.wikimedia.org/r/153103 (owner: 10Anomie) [13:15:06] (03PS4) 10BryanDavis: replace packages.pp w/require_package() function [vagrant] - 10https://gerrit.wikimedia.org/r/152816 (owner: 10Ori.livneh) [13:15:22] (03CR) 10Legoktm: [C: 032] Update token handling for core API change [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/153106 (owner: 10Anomie) [13:15:33] (03Merged) 10jenkins-bot: Update token handling for core API change [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/153106 (owner: 10Anomie) [13:15:57] (03CR) 10Legoktm: [C: 032] Update token handling for core API change [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/153093 (owner: 10Anomie) [13:16:09] (03Merged) 10jenkins-bot: Update token handling for core API change [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/153093 (owner: 10Anomie) [13:20:21] (03CR) 10Legoktm: [C: 031] "Would also like Chris to look." [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153016 (https://bugzilla.wikimedia.org/69099) (owner: 1001tonythomas) [13:22:33] (03CR) 10Legoktm: Add link to Special:PrefixIndex to Delete dialog (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151061 (https://bugzilla.wikimedia.org/30666) (owner: 10Ebe123) [13:25:44] (03PS1) 10Manybubbles: Add linksto: syntax to detect outoing links [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/153305 (https://bugzilla.wikimedia.org/69295) [13:28:08] (03CR) 10Ebe123: Add link to Special:PrefixIndex to Delete dialog (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151061 (https://bugzilla.wikimedia.org/30666) (owner: 10Ebe123) [13:31:08] 3Wikimedia / 3Media storage: Files disappear and give 404's for the full resolution - 10https://bugzilla.wikimedia.org/69362#c3 (10Gilles Dubuc) I'm curious about how Marco found these specifically, because they don't all have move entries in their history. So they might not all be caused by the known outage... [13:32:34] (03CR) 10Legoktm: [C: 031] Update token handling for core API change [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153085 (owner: 10Anomie) [13:35:38] 3Wikimedia / 3Media storage: Files disappear and give 404's for the full resolution - 10https://bugzilla.wikimedia.org/69362#c4 (10Marco) Dispenser does a scan for erroneous thumbnails regularly. "File not found" is one reason for a missing thumb. [13:39:33] (03CR) 10Legoktm: [C: 031] "I really really want to +2 this. Should we aim to get this in 1.24wmf17 (two weeks from now?) and send the announcement now?" [core] - 10https://gerrit.wikimedia.org/r/152760 (owner: 10Anomie) [13:43:36] (03CR) 10Hoo man: "Given that this screws all of our logging related to our "favorite" bug, yes." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153285 (owner: 10Hoo man) [13:44:15] (03CR) 10Anomie: "I suppose I should send the announcement, shouldn't I?" [core] - 10https://gerrit.wikimedia.org/r/152760 (owner: 10Anomie) [13:44:48] (03CR) 10Legoktm: "Greg said "sure..."" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153285 (owner: 10Hoo man) [13:44:57] (03PS1) 10Legoktm: Fix the race condition detection in CentralAuthUser::attach [extensions/CentralAuth] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/153307 [13:45:06] (03CR) 10jenkins-bot: [V: 04-1] Fix the race condition detection in CentralAuthUser::attach [extensions/CentralAuth] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/153307 (owner: 10Legoktm) [13:45:08] (03PS1) 10Legoktm: Fix the race condition detection in CentralAuthUser::attach [extensions/CentralAuth] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153308 [13:45:48] (03CR) 10Siebrand: Add link to Special:PrefixIndex to Delete dialog (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151061 (https://bugzilla.wikimedia.org/30666) (owner: 10Ebe123) [13:46:01] (03CR) 10Legoktm: [C: 031] "We can ignore the test failures unless we want to cherry-pick another patch...." [extensions/CentralAuth] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/153307 (owner: 10Legoktm) [13:46:56] (03CR) 10Siebrand: "I can live with legoktm's proposal." [core] - 10https://gerrit.wikimedia.org/r/137968 (owner: 10UltrasonicNXT) [13:47:21] (03CR) 10Siebrand: [C: 032] Remove duplicate translations [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/153301 (owner: 10Ebe123) [13:47:28] (03Merged) 10jenkins-bot: Remove duplicate translations [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/153301 (owner: 10Ebe123) [13:47:48] Reedy, thanks. [13:51:23] 3Wikimedia / 3Mailing lists: new mailing list: citations - 10https://bugzilla.wikimedia.org/69294#c1 (10Kunal Mehta (Legoktm)) Um, can you just use wikidata-l or wikitech-l? [13:53:53] (03CR) 10BryanDavis: [C: 032] "Let's try this out for a while and see if we like it. I think it will be easier to deal with than the ::packages classes but if it turns o" [vagrant] - 10https://gerrit.wikimedia.org/r/152816 (owner: 10Ori.livneh) [13:53:58] (03Merged) 10jenkins-bot: replace packages.pp w/require_package() function [vagrant] - 10https://gerrit.wikimedia.org/r/152816 (owner: 10Ori.livneh) [13:54:12] (03CR) 10AndyRussG: "Woo! \o/ Thanks guys!" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/153093 (owner: 10Anomie) [13:54:13] ori: ^ :) [13:56:38] 3Wikimedia / 3Mailing lists: new mailing list: citations - 10https://bugzilla.wikimedia.org/69294#c2 (10Thehelpfulone) 5UNCO>3RESO/WON A list for this already exists: "Discussion about the use reference sources by Wikimedians". It has... [13:57:48] wow lists... [14:05:45] (03CR) 10MaxSem: [C: 032] "My only concern with this is that aggressive addition of wfDeprecated() might break extension tests, however my grepping didn't seem to ac" [core] - 10https://gerrit.wikimedia.org/r/152760 (owner: 10Anomie) [14:06:03] * MaxSem gives anomie teh props [14:07:53] MaxSem: I grepped through and didn't see any code paths that would hit the wfDeprecated calls; every path goes through the core functions that are no longer called. [14:07:59] ^d: Hm.. forgot a .gitreview file in unicodejs.git? [14:08:23] yep, that's why I merged;) [14:08:55] (03Merged) 10jenkins-bot: API: Remove action=paraminfo 'props' and 'errors' result properties [core] - 10https://gerrit.wikimedia.org/r/152760 (owner: 10Anomie) [14:12:04] anomie, probbly should've emailed wikitech too [14:17:35] (03PS1) 10Reedy: Add right-superprotect [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153309 [14:17:43] (03CR) 10jenkins-bot: [V: 04-1] Add right-superprotect [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153309 (owner: 10Reedy) [14:18:58] (03PS2) 10Reedy: Add right-superprotect [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153309 [14:20:05] I'm really not sure about that [14:20:24] 3MediaWiki extensions / 3Translate: Make it more obvious where the + adds a unit - 10https://bugzilla.wikimedia.org/65902#c3 (10Nemo) 5NEW>3RESO/FIX Yeah, let's see if this is enough or someone asks more. [14:24:24] (03CR) 10Nemo bis: Add right-superprotect (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153309 (owner: 10Reedy) [14:24:44] (03CR) 10Nemo bis: [C: 04-1] Add right-superprotect [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153309 (owner: 10Reedy) [14:24:48] bawolff_: or quarry.wmflabs.org [14:25:10] (03CR) 10Reedy: "Needs protect-level-superprotect too" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153309 (owner: 10Reedy) [14:25:28] Reedy: Also protect-level-superprotect and restriction-level-superprotect, I believe [14:25:58] Yuvipanda: ? [14:26:09] (03PS3) 10Reedy: Add right-superprotect [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153309 [14:26:23] bawolff_: oh, just saw labs sql and was confused. nevermind :) [14:27:08] (03PS1) 10MaxSem: Remove old cruft [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/153310 [14:27:19] (03PS4) 10Reedy: Add superprotect related messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153309 [14:27:24] Nemo_bis: Fill in the blanks :P [14:30:37] (03PS1) 10MaxSem: Remove old cruft [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/153311 [14:31:23] 3MediaWiki extensions / 3Translate: [PageMigration] On lowercase title, TypeError: baseHref is undefined - 10https://bugzilla.wikimedia.org/69293#c2 (10Nemo) (In reply to Pratik Lahoti from comment #1) > But, there is no message group called 'languages' on this wiki. Uh? Pages are not message groups and 'la... [14:31:38] 3MediaWiki extensions / 3Translate: [PageMigration] On lowercase title, page not recognised - 10https://bugzilla.wikimedia.org/69293 (10Nemo) [14:32:48] Reedy: /me raises moral objection flag [14:33:25] * conscientious objector [14:33:48] (03PS5) 10Reedy: Add superprotect related messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153309 [14:34:33] (03CR) 10Odder: [C: 04-1] "As a matter of principle." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153309 (owner: 10Reedy) [14:34:51] (03PS1) 10MaxSem: Remove unused class [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/153312 [14:35:54] (03CR) 10Addshore: [C: 031] Add superprotect related messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153309 (owner: 10Reedy) [14:37:12] (03CR) 10MaxSem: [C: 031] "I don't see how not merging this would help anything: the corresponding config change is already deployed, not merging this one would just" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153309 (owner: 10Reedy) [14:37:46] (03CR) 10Steinsplitter: [C: 04-1] "As a matter of principle." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153309 (owner: 10Reedy) [14:37:53] (03CR) 10Alex Monk: [C: 04-1] Add superprotect related messages (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153309 (owner: 10Reedy) [14:39:15] (03CR) 10Bartosz Dziewoński: "That's some silly principles you guys have. You should comment on the other change." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153309 (owner: 10Reedy) [14:39:49] (03CR) 10Reedy: Add superprotect related messages (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153309 (owner: 10Reedy) [14:41:22] Nikerabbit, ^^ [14:41:35] Where is siebrand? [14:41:53] (03CR) 10Alex Monk: [C: 032] "Okay then. I guess qqq can be edited on translatewiki anyway" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153309 (owner: 10Reedy) [14:41:55] (03PS1) 10Addshore: Refactor ValidGlobalNameSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/153314 [14:41:59] (03Merged) 10jenkins-bot: Add superprotect related messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153309 (owner: 10Reedy) [14:42:14] (03CR) 10Hoo man: [C: 032] Fix the race condition detection in CentralAuthUser::attach [extensions/CentralAuth] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153308 (owner: 10Legoktm) [14:42:20] (03CR) 10Hoo man: [C: 032 V: 032] Fix the race condition detection in CentralAuthUser::attach [extensions/CentralAuth] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/153307 (owner: 10Legoktm) [14:42:22] (03Merged) 10jenkins-bot: Fix the race condition detection in CentralAuthUser::attach [extensions/CentralAuth] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153308 (owner: 10Legoktm) [14:42:44] hoo, are you going to do an emergency deployment? [14:43:02] EMERGENCY [14:43:53] 3MediaWiki extensions / 3CirrusSearch: Problem with the search in Hebrew - 10https://bugzilla.wikimedia.org/69361#c2 (10eitan96) For exmpale: if you search the word "הגבר" in this book: https://he.wikisource.org/wiki/%D7%90%D7%95%D7%93%D7%99%D7%A1%D7%99%D7%90%D7%94_%D7%A9%D7%9C_%D7%94%D7%95%D7%9E%D7%A8%D7%95... [14:44:23] weeew weeeew [14:44:24] MaxSem: Greg approved [14:44:32] ah, ok:) [14:44:59] Reedy: creating an emergency for the liason team ;) [14:45:53] 3MediaWiki extensions / 3Translate: [PageMigration] On lowercase title, page not recognised - 10https://bugzilla.wikimedia.org/69293#c3 (10Pratik Lahoti) (In reply to Nemo from comment #2) > Certainly there is a a standard way to normalise titles somewhere, perhaps > https://www.mediawiki.org/wiki/RL/DM#med... [14:45:53] (03PS1) 10Hoo man: Update CentralAuth [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/153315 [14:46:43] (03PS1) 10Hoo man: Update CentralAuth [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/153316 [14:47:10] doh [14:47:16] happens to me like every time :P [14:47:31] (03Abandoned) 10Hoo man: Update CentralAuth [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/153316 (owner: 10Hoo man) [14:47:48] :P [14:48:12] (03PS1) 10Hoo man: Update CentralAuth [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153317 [14:48:20] ok, that's why I double check every step [14:48:41] hoo: Fancy doing the gemran translations for https://gerrit.wikimedia.org/r/#/c/153309/5/i18n/wikimedia/en.json,unified please? [14:49:52] I guess I can do that [14:50:00] via twn or shall I be evil and push it directly? [14:50:06] (after my deploy) [14:50:19] gogogogog:P [14:50:25] Do it directly [14:50:35] Otherwise we've gotta wait for the twn export [14:50:39] Be nice to get them live soon [14:50:45] yeah [14:50:46] (03CR) 10Legoktm: "Was announced as ." [core] - 10https://gerrit.wikimedia.org/r/152760 (owner: 10Anomie) [14:50:49] * hoo kicks jenkins [14:53:28] (03CR) 10Hoo man: [C: 032] Update CentralAuth [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/153315 (owner: 10Hoo man) [14:53:34] (03CR) 10Hoo man: [C: 032] Update CentralAuth [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153317 (owner: 10Hoo man) [14:56:10] (03Merged) 10jenkins-bot: Update CentralAuth [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/153315 (owner: 10Hoo man) [14:56:25] (03Merged) 10jenkins-bot: Update CentralAuth [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153317 (owner: 10Hoo man) [15:02:23] 3Wikimedia / 3Site requests: Increase $wgAutoConfirmAge and $wgAutoConfirmCount on nowiki - 10https://bugzilla.wikimedia.org/69302 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [15:08:08] 3Wikimedia / 3General/Unknown: Math related warnings in l10nupdate on 1.24wmf9 - 10https://bugzilla.wikimedia.org/66586#c6 (10Andre Klapper) 5NEW>3RESO/WOR No feedback by Reedy; closing as WORKSFORME. [15:09:34] (03CR) 10Jack Phoenix: [C: 032 V: 032] Replace deprecated wfMsg* functions. [extensions/AutomaticBoardWelcome] - 10https://gerrit.wikimedia.org/r/150457 (https://bugzilla.wikimedia.org/68750) (owner: 10Wmat) [15:11:08] 3Wikimedia / 3Extension setup: FlaggedRevs for Norwegian (bokmål) Wikipedia - 10https://bugzilla.wikimedia.org/64726#c21 (10nsaa) «Consensus: https://no.wikipedia.org/wiki/Wikipedia:Tinget#Patruljering_og_pending_changes (we have also discussed it in other threads)» has been archived at https://no.wikipedia.... [15:11:38] 3MediaWiki extensions / 3CirrusSearch: Search should normalize Niqqud diacritics in Hebrew characters - 10https://bugzilla.wikimedia.org/69361#c3 (10Andre Klapper) For the records: https://en.wikipedia.org/wiki/Niqqud [15:12:38] (03CR) 10Jack Phoenix: [C: 032 V: 032] "\o/" [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153275 (owner: 10Isarra) [15:15:13] (03CR) 10Kunalgrover05: "I don't have admin rights on translatewiki." [core] - 10https://gerrit.wikimedia.org/r/153277 (owner: 10Kunalgrover05) [15:33:06] (03CR) 10Jack Phoenix: [C: 04-1] "Hi and thank you for the contribution!" (032 comments) [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/150157 (owner: 10Withoutaname) [15:33:08] (03PS1) 10Dzahn: German translations for super protect messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153322 [15:33:18] (03CR) 10jenkins-bot: [V: 04-1] German translations for super protect messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153322 (owner: 10Dzahn) [15:33:38] (03CR) 10Siebrand: "You do now." [core] - 10https://gerrit.wikimedia.org/r/153277 (owner: 10Kunalgrover05) [15:34:13] (03CR) 10JanZerebecki: [C: 04-1] "Thx. Nearly done, see inline comments. Then someone still needs to update the build result." (036 comments) [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153026 (owner: 10Chmarkine) [15:35:26] (03CR) 10Legoktm: German translations for super protect messages (032 comments) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153322 (owner: 10Dzahn) [15:35:49] (03PS2) 10Dzahn: German translations for super protect messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153322 [15:36:37] (03CR) 10Jforrester: [C: 031] German translations for super protect messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153322 (owner: 10Dzahn) [15:37:12] legoktm: ^^^ Happy to +2 instead if it's needed ASAP? [15:37:27] I don't know german [15:37:48] (03CR) 10Legoktm: [C: 032] German translations for super protect messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153322 (owner: 10Dzahn) [15:37:53] (03Merged) 10jenkins-bot: German translations for super protect messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/153322 (owner: 10Dzahn) [15:42:35] I can deploy that change if nobody's on it yet [15:43:38] MaxSem: reedy is [15:44:46] (03PS1) 10Reedy: Add superprotect related messages [extensions/WikimediaMessages] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/153324 [15:44:54] (03PS1) 10Reedy: Add superprotect related messages [extensions/WikimediaMessages] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153325 [15:45:23] (03CR) 10Reedy: [C: 032] Add superprotect related messages [extensions/WikimediaMessages] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/153324 (owner: 10Reedy) [15:45:24] Reedy: Do we have German now? [15:45:26] 3MediaWiki extensions / 3AbuseFilter: article_recent_contributors leaks revdeleted user names - 10https://bugzilla.wikimedia.org/69367 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Spotted during code review for gerrit 145014. [15:45:28] (03CR) 10Reedy: [C: 032] Add superprotect related messages [extensions/WikimediaMessages] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153325 (owner: 10Reedy) [15:45:30] (03Merged) 10jenkins-bot: Add superprotect related messages [extensions/WikimediaMessages] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/153324 (owner: 10Reedy) [15:45:35] (03Merged) 10jenkins-bot: Add superprotect related messages [extensions/WikimediaMessages] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153325 (owner: 10Reedy) [15:45:39] or shall I add it [15:45:50] hoo: mutante wrote some :) [15:45:57] \o/ [15:45:57] (03CR) 10Liangent: Add new variable article_first_contributor (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/145014 (https://bugzilla.wikimedia.org/67793) (owner: 10Liangent) [15:46:29] German ones won't backport :( [15:47:03] do it per hand (and burn in hell) [15:47:14] :P [15:47:24] Or how does localization update work? [15:47:28] better not screw it [15:48:09] 3Wikimedia / 3General/Unknown: invalid creates MWException on Wikipedia but not on Wikibooks - 10https://bugzilla.wikimedia.org/69348#c2 (10Andre Klapper) p:5Unprio>3Normal Liangent: So this is about literally writing invalid as wikite... [15:48:09] 3MediaWiki / 3General/Unknown: UNIQ issues (tracking) - 10https://bugzilla.wikimedia.org/26213 (10Andre Klapper) [15:48:10] yup [15:48:12] (03PS1) 10Reedy: German translations for super protect messages [extensions/WikimediaMessages] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/153326 [15:48:51] (03CR) 10jenkins-bot: [V: 04-1] German translations for super protect messages [extensions/WikimediaMessages] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/153326 (owner: 10Reedy) [15:48:54] 3Wikimedia / 3Media storage: Thumbnail/imagescaler (tracking) - 10https://bugzilla.wikimedia.org/41371 (10Andre Klapper) [15:48:54] 3Wikimedia / 3Media storage: VIPS scaled thumbnails don't have a comment with a link to the file description page - 10https://bugzilla.wikimedia.org/69336 (10Andre Klapper) p:5Unprio>3Normal [15:49:29] (03PS2) 10Reedy: German translations for super protect messages [extensions/WikimediaMessages] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/153326 [15:49:38] 3Wikimedia / 3Media storage: Swift outage caused a bunch of moved files to be "inconsistent" and "missing" - 10https://bugzilla.wikimedia.org/69311 (10Andre Klapper) p:5Unprio>3High s:5normal>3major [15:49:54] 3MediaWiki / 3JavaScript: Wikilove uses jquery.ui, which uses .andSelf(), which is deprecated - 10https://bugzilla.wikimedia.org/69350 (10Andre Klapper) p:5Unprio>3Normal [15:50:02] (03PS3) 10Reedy: German translations for super protect messages [extensions/WikimediaMessages] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/153326 [15:50:08] (03CR) 10Reedy: [C: 032] German translations for super protect messages [extensions/WikimediaMessages] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/153326 (owner: 10Reedy) [15:52:08] 3Wikimedia / 3Bugzilla: Create "MediaWiki" --> "Configuration" component - 10https://bugzilla.wikimedia.org/69339#c4 (10Andre Klapper) Thanks; summary changed to "Issues related to configuration options and the Config interface (under /includes/config/ in Core)" [15:52:12] (03CR) 10Microchip08: [C: 04-1] "This commit introduces a byte order mark (U+FEFF) next to
in source/localizable/content.html/erb: pease strip it o" [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153026 (owner: 10Chmarkine) [15:52:38] 3Wikimedia / 3Media storage: Files disappear and give 404's for the full resolution - 10https://bugzilla.wikimedia.org/69362 (10Andre Klapper) p:5Unprio>3High [15:53:21] (03PS1) 10Reedy: German translations for super protect messages [extensions/WikimediaMessages] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153327 [15:53:23] 3Wikimedia / 3Media storage: VIPS scaled thumbnails don't have a comment with a link to the file description page - 10https://bugzilla.wikimedia.org/69336#c1 (10Bawolff (Brian Wolff)) Hmm. Is exiv2 on the servers? I think the option depends on that. [15:54:01] (03CR) 10Reedy: [C: 032] German translations for super protect messages [extensions/WikimediaMessages] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153327 (owner: 10Reedy) [15:54:07] (03Merged) 10jenkins-bot: German translations for super protect messages [extensions/WikimediaMessages] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153327 (owner: 10Reedy) [15:55:36] (03PS1) 10Reedy: Update WikimediaMessages to 1.24wmf15 HEAD [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/153328 [15:57:07] (03PS1) 10Reedy: Update WikimediaMessages to 1.24wmf16 HEAD [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153329 [15:57:52] (03CR) 10Reedy: [C: 032 V: 032] Update WikimediaMessages to 1.24wmf15 HEAD [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/153328 (owner: 10Reedy) [15:58:08] 3Wikimedia / 3General/Unknown: invalid creates MWException on Wikipedia but not on Wikibooks - 10https://bugzilla.wikimedia.org/69348#c3 (10Liangent) (In reply to Andre Klapper from comment #2) > Liangent: So this is about literally writing > invalid (03CR) 10Reedy: [C: 032 V: 032] Update WikimediaMessages to 1.24wmf16 HEAD [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153329 (owner: 10Reedy) [16:02:38] (03CR) 10Legoktm: [C: 04-1] "Please document new hooks in docs/hooks.txt (and then create a page on mediawiki.org for it)" [core] - 10https://gerrit.wikimedia.org/r/153277 (owner: 10Kunalgrover05) [16:03:37] (03PS1) 10Jforrester: Add the new unicodejs library to the testing system [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/153330 [16:03:56] (03CR) 10Legoktm: "Also, why can't this just be a BeforePageDisplay hook in ULS with" [core] - 10https://gerrit.wikimedia.org/r/153277 (owner: 10Kunalgrover05) [16:10:57] (03PS3) 10Krinkle: build: Make into a built library, set up test infrastructure [unicodejs] - 10https://gerrit.wikimedia.org/r/153078 (owner: 10Jforrester) [16:11:08] Hmmm. [16:11:09] (03CR) 10Krinkle: [C: 04-1] "Needs jsduck set up as well." (034 comments) [unicodejs] - 10https://gerrit.wikimedia.org/r/153078 (owner: 10Jforrester) [16:13:38] http://www.mediawiki.org/wiki/MediaWiki-Vagrant#Quick_start suggests that if I set everything up and then do `vagrant up` and http://127.0.0.1:8080/ should work, but I get "Safari can't open the page because the server unexpectedly dropped the connection." [16:13:42] Help? :-) [16:15:43] Lots of people watching wikimanialondon.org/live.html [16:15:50] (The VM is running.) [16:15:57] Yeah, I'm in the room. :-P [16:15:58] so they may be busy currently [16:17:19] (03CR) 10Legoktm: Add link to Special:PrefixIndex to Delete dialog (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151061 (https://bugzilla.wikimedia.org/30666) (owner: 10Ebe123) [16:20:46] (03PS5) 10Legoktm: Convert Gadget definition namespace to use ContentHandler [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153270 (https://bugzilla.wikimedia.org/69318) [16:23:59] (03CR) 10Legoktm: "Added the license headers. This should be good for now, we can probably convert more hooks to ContentHandler stuff in another patch." [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153270 (https://bugzilla.wikimedia.org/69318) (owner: 10Legoktm) [16:29:23] (03CR) 10Siebrand: Add link to Special:PrefixIndex to Delete dialog (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151061 (https://bugzilla.wikimedia.org/30666) (owner: 10Ebe123) [16:31:55] 3MediaWiki extensions / 3Gadgets: 2.0: Remove timestamp from Gadget constructor - 10https://bugzilla.wikimedia.org/69368 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Yeah...ugh. There's a TODO in the code, and timestamp does not make sense for the constructor. [16:32:08] 3MediaWiki extensions / 3Gadgets: Implement Gadgets 2.0 (tracking) - 10https://bugzilla.wikimedia.org/29272 (10Kunal Mehta (Legoktm)) [16:33:54] (03PS4) 10Jforrester: build: Make into a built library, set up test infrastructure [unicodejs] - 10https://gerrit.wikimedia.org/r/153078 [16:37:39] 3MediaWiki / 3Database: PostgreSQL/pgsql support (tracking) - 10https://bugzilla.wikimedia.org/384 (10Andre Klapper) [16:37:39] 3MediaWiki / 3Database: missing 'patch-add_interwiki.sql' for the includes/installer/PostgresqlUpdater.php - 10https://bugzilla.wikimedia.org/69360#c1 (10Andre Klapper) p:5Unprio>3Normal Thanks for taking the time to report this! In case you (or anybody) feel like cooking up a patch, you are welcome to... [16:41:48] (03CR) 10Florianschmidtwelzow: "I think for this extension it's escalated quickly, e.g. my patchsets should only (in first thoughts) fix wfMsg, no there are 3 changes to " [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/150157 (owner: 10Withoutaname) [16:46:22] I'm also getting a lot of `default: Warning: Connection timeout. Retrying...` when I `vagrant up`. [16:47:33] FYI, it must have been something to do with provisioning. I reran `vagrant up` from scratch after destroying the VM and it's working now. :-) [16:50:12] Hmm. I can only get to http://127.0.0.1:8080/info.php though - I can't find any trace of MediaWiki on 127.0.0.1:8080. [17:12:04] (03PS1) 10Isarra: Rearranged colours a little for more flexibility [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153333 [17:13:02] (03CR) 10Isarra: [C: 032 V: 032] "Now maybe I can throw a pile of colours at Jack Phoenix and he can make the themes actually happen. Possibly." [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153333 (owner: 10Isarra) [17:22:01] (03PS1) 10Isarra: Make header sprites theme-agnostic (b&w with transparency) [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153334 [17:22:45] (03CR) 10Isarra: [C: 032 V: 032] Make header sprites theme-agnostic (b&w with transparency) [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153334 (owner: 10Isarra) [17:22:47] (03Merged) 10jenkins-bot: Make header sprites theme-agnostic (b&w with transparency) [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153334 (owner: 10Isarra) [17:39:07] (03CR) 10Smuggli: [C: 032 V: 032] Fixed hook handler naming [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/153029 (owner: 10Robert Vogel) [17:39:59] (03CR) 10Smuggli: [C: 032 V: 032] Removed caching of page templates [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/152911 (owner: 10Smuggli) [17:41:36] (03PS1) 10Kghbln: Several changes for version 1.3.1 [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/153335 [17:43:03] (03PS1) 10Isarra: More colour shuffling [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153336 [17:43:30] (03CR) 10Isarra: [C: 032 V: 032] "I think I'm done now. *shifty eyes*" [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153336 (owner: 10Isarra) [17:43:32] (03Merged) 10jenkins-bot: More colour shuffling [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153336 (owner: 10Isarra) [17:47:02] (03CR) 10Kunalgrover05: "It was done that way before, but Nikerabbit suggested to make a generic hook that can be used to replace all language selectors." [core] - 10https://gerrit.wikimedia.org/r/153277 (owner: 10Kunalgrover05) [18:00:01] (03CR) 10Kunalgrover05: "@siebrand- It was a bug that I identified later. Please merge the latest patchset and check" [core] - 10https://gerrit.wikimedia.org/r/153277 (owner: 10Kunalgrover05) [18:14:18] (03PS1) 10Isarra: Separate out button colour to fix contrast [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153339 [18:15:07] (03CR) 10Isarra: [C: 032 V: 032] Separate out button colour to fix contrast [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153339 (owner: 10Isarra) [18:15:09] (03Merged) 10jenkins-bot: Separate out button colour to fix contrast [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153339 (owner: 10Isarra) [18:29:41] 3MediaWiki / 3Skin and page rendering: Add README to skins folder - 10https://bugzilla.wikimedia.org/69372 (10db) 3NEW p:3Unprio s:3normal a:3None The extension folder has a README, which gives hint to add extensions. Please add a README to skin folder for the same purpose. Thanks. [19:06:05] (03Abandoned) 10Florianschmidtwelzow: WIP: Special:Block: Use config object instead of globals [core] - 10https://gerrit.wikimedia.org/r/153266 (https://bugzilla.wikimedia.org/69087) (owner: 10Florianschmidtwelzow) [19:16:53] 3MediaWiki / 3Skin and page rendering: Add README to skins folder - 10https://bugzilla.wikimedia.org/69372 (10Kunal Mehta (Legoktm)) [19:17:08] 3MediaWiki / 3Documentation: Documentation is out of date, incomplete (tracking) - 10https://bugzilla.wikimedia.org/1 (10Kunal Mehta (Legoktm)) [19:38:24] 3MediaWiki / 3API: Make sure all possible errors of action=upload are logged in getPossibleErrors - 10https://bugzilla.wikimedia.org/40937#c1 (10db) 5NEW>3RESO/INV possible errors were removed with gerrit 152760 [19:39:53] 3MediaWiki extensions / 3WikidataRepo: API self-documentation should not be localized. - 10https://bugzilla.wikimedia.org/67732#c3 (10db) possible errors were removed with gerrit 152760 from core [19:44:39] 3MediaWiki extensions / 3Translate: [twn] Support gerrit repos in mediawiki/skins - 10https://bugzilla.wikimedia.org/65040#c12 (10db) This bug is fixed, but yesterday there were no export of mediawiki/skins/* repos under owner:L10n-bot At least modern or cologneblue needs a init export. [19:50:38] 3MediaWiki extensions / 3Translate: [twn] Support gerrit repos in mediawiki/skins - 10https://bugzilla.wikimedia.org/65040#c13 (10Siebrand Mazeland) Exports still have to get integrated in Raimond's workflow. Will happen somewhere in the next few weeks [20:08:07] (03PS5) 10Bsitu: Add abstract model and mapper for notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151999 [20:12:43] (03PS7) 10Bsitu: Add TargetPage model and mapper to notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151992 [20:14:08] (03PS1) 10tosfos: add Contributors class [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/153344 [20:16:55] 3Wikimedia / 3General/Unknown: UploadWizard Freezes at Uploading Stage - 10https://bugzilla.wikimedia.org/69374 (10Jacklee) 3NEW p:3Unprio s:3critic a:3None Over the past few days I have been unable to upload using Special:UploadWizard. For example, I tried uploading four files. It has been more than... [20:19:37] (03PS2) 10tosfos: add Contributors class [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/153344 [20:22:55] (03PS3) 10tosfos: add Contributors class [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/153344 [20:24:11] (03CR) 10tosfos: [C: 031] add Contributors class [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/153344 (owner: 10tosfos) [20:24:15] (03CR) 10Parent5446: [C: 04-1] "Still needs patches for other databases." [core] - 10https://gerrit.wikimedia.org/r/150699 (owner: 10Chad) [20:25:17] (03PS1) 10Anomie: Do not allow a user to delete a page they can't edit [core] - 10https://gerrit.wikimedia.org/r/153345 [20:25:38] 3Wikimedia / 3General/Unknown: UploadWizard Freezes at Uploading Stage - 10https://bugzilla.wikimedia.org/69374#c1 (10Mark Holmquist) Hi Jacklee. Can you tell us what browser you're using, and what operating system? Also, if you know how, I'd love it if you looked at the web browser's console and checked f... [20:30:22] (03PS8) 10Bsitu: Add TargetPage model and mapper to notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151992 [20:30:38] 3Wikimedia / 3General/Unknown: UploadWizard Freezes at Uploading Stage - 10https://bugzilla.wikimedia.org/69374#c2 (10Andre Klapper) (In reply to Jacklee from comment #0) > Over the past few days I have been unable to upload using > Special:UploadWizard. Where exactly? https://commons.wikimedia.org/wiki/Spe... [20:32:29] (03CR) 10Parent5446: "Is this necessarily intuitive? What if a user is actually only given the permission to delete pages but not edit them?" [core] - 10https://gerrit.wikimedia.org/r/153345 (owner: 10Anomie) [20:38:38] 3Wikimedia / 3General/Unknown: UploadWizard Freezes at Uploading Stage - 10https://bugzilla.wikimedia.org/69374#c3 (10Jacklee) I was uploading at https://commons.wikimedia.org/wiki/Special:UploadWizard, using Mozilla Firefox 31.0. The web console says: "TypeError: file is undefined" and "load.php:8". [20:41:53] 3Wikimedia / 3General/Unknown: UploadWizard Freezes at Uploading Stage - 10https://bugzilla.wikimedia.org/69374#c4 (10Jacklee) I was just trying to upload some standard JPEG photographs taken with my iPhone 5. I haven't had problems uploading them before. [20:53:46] (03PS1) 10tosfos: fix bug - was mishandling $wgContributorsLimit when using non-default sort [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/153348 [20:57:26] 3MediaWiki extensions / 3AdvancedSearch: Vitamin A wrong formula - 10https://bugzilla.wikimedia.org/69375 (10dgmuret) 3UNCO p:3Unprio s:3normal a:3Roan Kattouw Created attachment 16162 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16162&action=edit Print screen HI! I'm not a chemist but I... [20:58:39] 3MediaWiki extensions / 3AdvancedSearch: Vitamin A wrong formula - 10https://bugzilla.wikimedia.org/69375#c1 (10dgmuret) Created attachment 16163 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16163&action=edit Print screen [21:00:24] 3MediaWiki extensions / 3CentralAuth: Accounts aren't getting listed using migratePass0.php - 10https://bugzilla.wikimedia.org/15800#c1 (10Andre Klapper) (In reply to Huji from comment #0) > I created a wiki family using the following test settings: > http://rafb.net/p/JICuAZ14.html Not sure how relevant it... [21:00:39] 3MediaWiki extensions / 3AdvancedSearch: Vitamin A wrong formula - 10https://bugzilla.wikimedia.org/69375#c2 (10Alex Monk) Hi. This looks like a content issue with the wiki you are reading. This bug tracker is for our software and doesn't handle issues like this one. You could try emailing info-en@wikipedia... [21:00:53] 3MediaWiki extensions / 3AdvancedSearch: Vitamin A wrong formula - 10https://bugzilla.wikimedia.org/69375 (10Alex Monk) 5UNCO>3RESO/INV [21:07:38] 3MediaWiki / 3Special pages: Provide Special:ExternalLinksFromHe re which displays in-line links from Wikipedia, Wikibooks, commons, meta, etc. - 10https://bugzilla.wikimedia.org/12833#c1 (10Andre Klapper) p:5Low>3Lowest How is this request different from bug 1886? [21:08:38] 3MediaWiki / 3Special pages: Replace LonelyPages, WithoutInterwiki with PagesWithLeast... - 10https://bugzilla.wikimedia.org/15860#c1 (10Andre Klapper) Hi naught101! Sorry that nobody has taken a look at this report yet and given feedback. What would be the usecases for this, and how common are they? Could... [21:08:50] (03CR) 10Anomie: "@Parent5446: That seems like a silly permission setup, and liable to lead to a Maslow's hammer situation." [core] - 10https://gerrit.wikimedia.org/r/153345 (owner: 10Anomie) [21:10:35] (03CR) 10Jackmcbarn: [C: 04-1] Do not allow a user to delete a page they can't edit (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153345 (owner: 10Anomie) [21:10:53] 3MediaWiki / 3Skin and page rendering: Add README to skins folder - 10https://bugzilla.wikimedia.org/69372 (10Andre Klapper) p:5Unprio>3Normal [21:11:08] 3MediaWiki / 3Special pages: Special:Block: Use Config instead of globals - 10https://bugzilla.wikimedia.org/69087 (10Andre Klapper) 5PATC>3NEW [21:11:23] 3MediaWiki extensions / 3Gadgets: 2.0: Remove timestamp from Gadget constructor - 10https://bugzilla.wikimedia.org/69368 (10Andre Klapper) p:5Unprio>3Normal [21:11:37] (03CR) 10Anomie: Do not allow a user to delete a page they can't edit (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153345 (owner: 10Anomie) [21:11:56] (03PS2) 10Anomie: Do not allow a user to delete a page they can't edit [core] - 10https://gerrit.wikimedia.org/r/153345 [21:13:08] 3Wikimedia / 3General/Unknown: UploadWizard Freezes at Uploading Stage - 10https://bugzilla.wikimedia.org/69374#c5 (10Andre Klapper) Sorry, but could you try again with https://commons.wikimedia.org/wiki/Special:UploadWizard?debug=true to get filenames in the output instead of a generic "load.php"? [21:15:09] (03PS9) 10Bsitu: Add TargetPage model and mapper to notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151992 [21:26:56] (03CR) 10Jackmcbarn: [C: 04-1] "There's also a lot of type names added to @return's which shouldn't be there." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/148991 (owner: 10Umherirrender) [21:39:36] (03CR) 10Siebrand: "I tend to agree with Tyler's assessment that workflows are thinkable, and may have been configured where certain users can delete but not " [core] - 10https://gerrit.wikimedia.org/r/153345 (owner: 10Anomie) [21:40:05] (03CR) 10Siebrand: "Ugh. That should be "$wgDeleteWhenNoEditRights, default true)." [core] - 10https://gerrit.wikimedia.org/r/153345 (owner: 10Anomie) [21:44:24] (03CR) 10CSteipp: [C: 032] "In general I agree with Tyler in that permissions shouldn't rely on each other. But in this case, Delete+Create = Edit, and I'd rather hav" [core] - 10https://gerrit.wikimedia.org/r/153345 (owner: 10Anomie) [21:45:26] (03PS3) 10Bsitu: Mark notification as read upon visiting a page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152198 [21:47:25] (03Merged) 10jenkins-bot: Do not allow a user to delete a page they can't edit [core] - 10https://gerrit.wikimedia.org/r/153345 (owner: 10Anomie) [21:48:09] (03CR) 10Helder.wiki: [C: 031] Standardize hook names and general clean up [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153272 (owner: 10Legoktm) [21:49:04] (03CR) 10Siebrand: "Merge which latest patch set? I've cherry picked both patch sets, and they're live on twn." [core] - 10https://gerrit.wikimedia.org/r/153277 (owner: 10Kunalgrover05) [21:52:42] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/152988 (https://bugzilla.wikimedia.org/68727) (owner: 10Florianschmidtwelzow) [21:54:41] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/153265 (owner: 10MaxSem) [21:55:12] (03CR) 10Siebrand: "Merged hastily in my opinion." [core] - 10https://gerrit.wikimedia.org/r/153345 (owner: 10Anomie) [21:57:36] (03PS1) 10CSteipp: Make reliance on edit to delete configurable [core] - 10https://gerrit.wikimedia.org/r/153349 [21:59:08] (03PS1) 10CSteipp: Do not allow a user to delete a page they can't edit [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/153350 [21:59:37] (03PS1) 10CSteipp: Do not allow a user to delete a page they can't edit [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153351 [21:59:50] (03CR) 10Jackmcbarn: [C: 04-1] "It opens a textbox with a list, presumably for the user to copy and paste." [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/153265 (owner: 10MaxSem) [22:04:53] (03CR) 10Siebrand: [C: 031] "Thanks, Chris." [core] - 10https://gerrit.wikimedia.org/r/153349 (owner: 10CSteipp) [22:06:42] (03CR) 10Siebrand: [C: 031] Do not allow a user to delete a page they can't edit [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/153350 (owner: 10CSteipp) [22:06:48] (03CR) 10Siebrand: [C: 031] Do not allow a user to delete a page they can't edit [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153351 (owner: 10CSteipp) [22:10:55] (03CR) 10Florianschmidtwelzow: [C: 032] Add info about GoogleLogin to Special:Preferences [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/152988 (https://bugzilla.wikimedia.org/68727) (owner: 10Florianschmidtwelzow) [22:11:01] (03Merged) 10jenkins-bot: Add info about GoogleLogin to Special:Preferences [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/152988 (https://bugzilla.wikimedia.org/68727) (owner: 10Florianschmidtwelzow) [22:11:04] (03CR) 10CSteipp: [C: 032] Do not allow a user to delete a page they can't edit [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153351 (owner: 10CSteipp) [22:16:38] (03Merged) 10jenkins-bot: Do not allow a user to delete a page they can't edit [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153351 (owner: 10CSteipp) [22:18:56] (03PS1) 10Florianschmidtwelzow: Change to camelCase function name in GoogleloginDB [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/153352 [22:19:09] (03CR) 10CSteipp: "Erik asked that I deploy this, so I like that it does the minimum needed. I created a followup I2a3684a6aee9a7586305b07fb7439969271f93ac i" [core] - 10https://gerrit.wikimedia.org/r/153345 (owner: 10Anomie) [22:19:17] (03PS5) 10Bsitu: Auto mark notification as read if it doesn't have target page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152203 [22:19:28] (03CR) 10Florianschmidtwelzow: [C: 032] Change to camelCase function name in GoogleloginDB [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/153352 (owner: 10Florianschmidtwelzow) [22:19:32] (03Merged) 10jenkins-bot: Change to camelCase function name in GoogleloginDB [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/153352 (owner: 10Florianschmidtwelzow) [22:19:43] (03CR) 10jenkins-bot: [V: 04-1] Auto mark notification as read if it doesn't have target page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152203 (owner: 10Bsitu) [22:20:15] (03CR) 10Bartosz Dziewoński: "It's amusing how this doesn't even have a bug or release notes." [core] - 10https://gerrit.wikimedia.org/r/153345 (owner: 10Anomie) [22:20:45] (03CR) 10Helder.wiki: "What about the list of errors (and warnings) on mediawiki.api.js?" [core] - 10https://gerrit.wikimedia.org/r/152760 (owner: 10Anomie) [22:23:23] 3MediaWiki extensions / 3GoogleLogin: Move GoogleLogin Info page from Special:GoogleLogin to Special:Preferences - 10https://bugzilla.wikimedia.org/68727 (10Florian) 5PATC>3RESO/FIX [22:25:20] (03CR) 10Anomie: [C: 04-1] Make reliance on edit to delete configurable (032 comments) [core] - 10https://gerrit.wikimedia.org/r/153349 (owner: 10CSteipp) [22:26:50] (03CR) 10CSteipp: [C: 032] Do not allow a user to delete a page they can't edit [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/153350 (owner: 10CSteipp) [22:27:02] (03PS6) 10Bsitu: Auto mark notification as read if it doesn't have target page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152203 [22:29:15] (03Merged) 10jenkins-bot: Do not allow a user to delete a page they can't edit [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/153350 (owner: 10CSteipp) [22:31:29] (03CR) 10Anomie: "@Helder.wiki: That appears to be UploadWizard code that is misplaced into core. The list of errors there appears to be only those that cou" [core] - 10https://gerrit.wikimedia.org/r/152760 (owner: 10Anomie) [22:36:58] (03CR) 10Odder: "Luckily you managed to deploy this without any community oversight." [core] - 10https://gerrit.wikimedia.org/r/153345 (owner: 10Anomie) [22:37:43] (03PS1) 10Jackmcbarn: Always set a title on images when provided [core] - 10https://gerrit.wikimedia.org/r/153353 (https://bugzilla.wikimedia.org/21454) [22:41:57] (03PS2) 10SG: Correct usage of cancel type on buttons, and fix reply form cancel error [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150998 [22:42:58] (03CR) 10Bartosz Dziewoński: "(To be clear, I'm not blaming you, since this is clearly being pushed; I just don't like that it is being pushed fast enough to compromise" [core] - 10https://gerrit.wikimedia.org/r/153345 (owner: 10Anomie) [22:43:35] csteipp, hm. I wonder what others way there are around this [22:44:44] i'm sure we can trust the germans to do pentiesting for us [22:44:48] pentesting* [22:44:55] :> [22:45:00] Krenair: Depending on your "this", I'm sure there are ways... [22:45:03] :P [22:46:10] (03PS2) 10SG: Clean up flow-menu code, and redo flow-menu trigger in board-navigation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/152804 [22:47:01] (03PS1) 10SG: Add flow-menu and board-navigation back to no-js mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153354 [22:47:53] csteipp, well I know for a fact there are ways around anything you might try to do against sysops [22:48:32] csteipp, but I was thinking nuke (looks like it would be fine), moving existing pages around in weird ways, merge history... [22:49:23] 3Wikimedia / 3Media storage: Swift outage caused a bunch of moved files to be "inconsistent" and "missing" - 10https://bugzilla.wikimedia.org/69311#c4 (10Andre Klapper) Bug 69377 is likely one outcome of this? [22:49:39] 3Wikimedia / 3Media storage: Thumbnail/imagescaler (tracking) - 10https://bugzilla.wikimedia.org/41371 (10Andre Klapper) [22:50:09] (03CR) 10SG: "@jdlrobson What's the purpose of hiding these from non-JS users? I feel you are contradicting yourself by saying we need to support low-ba" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153354 (owner: 10SG) [22:53:09] 3MediaWiki / 3General/Unknown: Warning: Recursion detected in RequestContext::getLanguage in /includes/context/RequestContext.php on line 284 - 10https://bugzilla.wikimedia.org/54193 (10Florian) [22:53:11] 3MediaWiki extensions / 3[other]: [WYSIWYG] Call to undefined method Parser::strip - 10https://bugzilla.wikimedia.org/69378 (10Florian) 3NEW p:3Unprio s:3normal a:3None +++ This bug was initially created as a clone of Bug #69023 +++ 1544 \nFatal error: Call to undefined method Parser::strip from... [22:53:19] (03CR) 10Nemo bis: "There was certainly nothing urgent in this bug and an associated bug report would've been standard. If I'm not mistaken, requiring edit ri" [core] - 10https://gerrit.wikimedia.org/r/153345 (owner: 10Anomie) [22:53:21] (03CR) 10Legoktm: "This is silly. Delete means delete. Shouldn't have been merged without release-notes. If there was any urgency about this, a hook could ha" [core] - 10https://gerrit.wikimedia.org/r/153345 (owner: 10Anomie) [22:53:23] 3MediaWiki extensions / 3[other]: [WYSIWYG] Recursion detected in RequestContext::getLanguage - 10https://bugzilla.wikimedia.org/69023 (10Florian) [22:53:39] 3MediaWiki extensions / 3[other]: [WYSIWYG] Call to undefined method Parser::strip - 10https://bugzilla.wikimedia.org/69378 (10Florian) [22:53:39] 3MediaWiki / 3General/Unknown: Warning: Recursion detected in RequestContext::getLanguage in /includes/context/RequestContext.php on line 284 - 10https://bugzilla.wikimedia.org/54193 (10Florian) [22:53:59] (03PS6) 10Bsitu: [WIP]Create TargetPage data if specified by EchoEvent [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152808 [22:55:56] (03CR) 10SG: "So, perhaps the solution here is:" [core] - 10https://gerrit.wikimedia.org/r/151792 (owner: 10Jdlrobson) [22:56:09] Eh, [22:57:06] Krenair: import too [22:57:15] yeah [22:57:17] de.wiki has lots of importupload users [22:57:31] this whole thing is so silly [22:57:34] Oh, importupload? lol [22:57:37] and of course there are hundreds ns8 pages [22:57:39] imo, the right way to handle this would have been to desysop the wheel-warrers [22:57:43] jackmcbarn++ [22:58:01] jackmcbarn, perhaps - desysopping is a pretty drastic action too. [22:58:05] there's really no win there. [22:58:12] what they're doing now is trying to lock down the wrong side of the airtight hatchway [22:58:13] it's a crappy situation either way. [22:58:17] much less drastic than superprotect which can be used on any page...? [22:58:27] nor did it actually solve the problem since it's easy to bypass [22:58:36] if you want to stop someone from adding JS, remove their rights [22:58:51] legoktm, each approach has its tradeoffs. [22:58:58] (03PS1) 10Florianschmidtwelzow: Use Parser::replaceVariables instead of Parser::strip [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/153355 (https://bugzilla.wikimedia.org/69378) [22:59:06] but we can play hide and seek [22:59:06] introducing a joyful element in the matter [22:59:08] sure [23:00:11] 3MediaWiki extensions / 3[other]: [WYSIWYG] Call to undefined method Parser::strip - 10https://bugzilla.wikimedia.org/69378 (10Florian) [23:00:11] 3MediaWiki extensions / 3[other]: [WYSIWYG] Recursion detected in RequestContext::getLanguage - 10https://bugzilla.wikimedia.org/69023 (10Florian) [23:00:17] desysop is useless unless you also decrat everyone [23:00:44] (03PS7) 10Bsitu: Create TargetPage data if specified by EchoEvent [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152808 [23:00:50] you can't even uninstall makesysop now ;) [23:00:54] $wgReadOnly = true; [23:00:57] RESOLVED FIXED [23:01:23] 3MediaWiki extensions / 3[other]: [WYSIWYG] Call to undefined methods - 10https://bugzilla.wikimedia.org/69378#c2 (10Florian) Call to undefined method MediaWiki::getVal() ... CKeditor.body.php on line 174 [23:01:23] legoktm: 28 http://meatballwiki.org/wiki/WikiLifeCycle [23:01:34] night everyone [23:01:38] :D [23:01:40] night Nemo_bis [23:01:44] bye nemo. [23:02:42] (03CR) 10Helder.wiki: "FYI: The list was added by Neilk on" [core] - 10https://gerrit.wikimedia.org/r/152760 (owner: 10Anomie) [23:03:42] (03PS1) 10Legoktm: Add release notes for Ibe28a69c9fbab00b81c53b1643df722a3f1fbf19 [core] - 10https://gerrit.wikimedia.org/r/153357 [23:03:51] (03CR) 10Legoktm: [C: 032] Add release notes for Ibe28a69c9fbab00b81c53b1643df722a3f1fbf19 [core] - 10https://gerrit.wikimedia.org/r/153357 (owner: 10Legoktm) [23:04:07] legoktm: Tsk, self-+2. :-P [23:04:11] (03CR) 10Legoktm: "Release notes in I0a2b2feafcf2561369145bec80ec14c7929beff9" [core] - 10https://gerrit.wikimedia.org/r/153345 (owner: 10Anomie) [23:04:23] * James_F 'd have merged. [23:04:26] James_F: you have about two minutes to +2 it to make it a +4 :) [23:04:47] * James_F laughs. [23:04:58] (03CR) 10Jforrester: [C: 032] Add release notes for Ibe28a69c9fbab00b81c53b1643df722a3f1fbf19 [core] - 10https://gerrit.wikimedia.org/r/153357 (owner: 10Legoktm) [23:06:22] Also, [23:06:30] I'm going to be on the plane during the SWAT window [23:06:53] could someone take care of https://gerrit.wikimedia.org/r/#/c/153042/ ? [23:07:03] Or are we not doing SWATs tomorrow? [23:07:18] (03Merged) 10jenkins-bot: Add release notes for Ibe28a69c9fbab00b81c53b1643df722a3f1fbf19 [core] - 10https://gerrit.wikimedia.org/r/153357 (owner: 10Legoktm) [23:08:09] 3MediaWiki extensions / 3[other]: [WYSIWYG] Call to undefined methods - 10https://bugzilla.wikimedia.org/69378 (10Florian) [23:08:10] 3MediaWiki extensions / 3[other]: [WYSIWYG] Fatal error - 10https://bugzilla.wikimedia.org/69379 (10Florian) 3NEW p:3Unprio s:3normal a:3None +++ This bug was initially created as a clone of Bug #69378 +++ +++ This bug was initially created as a clone of Bug #69023 +++ Fatal error: Cannot access pr... [23:08:22] legoktm: I'd ask greg-g but hopefully he's asleep. [23:08:28] * greg-g yawns [23:08:31] Well, he's on my flight so :P [23:08:35] Ha. [23:08:52] oh right, "monday" [23:09:00] no, no swat, too many on vacation/in a plane [23:09:02] greg-g: I'd kill it if I were you. [23:09:05] Yeah. [23:09:07] * greg-g makes last minute decision on that [23:09:07] +1. ;-) [23:09:15] * greg-g edits wiki [23:09:18] greg-g: You've got 24 hours to make a last minute decision. [23:09:29] just deploy it now [23:09:30] fine with me, that patch just needs to go out before the that hits any non-phase0 wikis [23:09:50] i'm not kidding; legoktm's here; i'm here; chris is here; you're here [23:09:58] and it fixes a timebomb [23:10:22] to clarify: by "just deploy it now" i mean "join me in trying to persuade greg-g that we should just deploy it now" [23:10:38] greg-g: Thoughts? [23:10:51] oh, right that [23:10:56] sorry, I didn't even look at context [23:11:01] I was almost closing laptop lid [23:11:07] heh, sounds good to me. I'll be up for a little bit more to make sure nothing blows up [23:11:10] legoktm: is this what you showed me earlier today? [23:11:16] no, we already deployed that [23:11:43] this is a fix for MassMessage that just needs to go out before wmf16 hits non-phase0 wikis [23:12:06] legoktm: "sure..." [23:12:08] ;) [23:12:32] (03CR) 10Greg Grossmeier: [C: 031] "suuure" [extensions/MassMessage] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153042 (https://bugzilla.wikimedia.org/68843) (owner: 10Legoktm) [23:13:30] (03CR) 10Microchip08: "The bug this commit fixes (bug 40937) has been marked invalid via Ie11a401d60c834059fbf1b5625ca8ea093b3337c." [core] - 10https://gerrit.wikimedia.org/r/144589 (owner: 10Devanw) [23:16:03] James_F: wiki page updated for clarity [23:16:30] greg-g: Thanks. I'll keep an eye out on IRC in case things break whilst you're in the air. [23:16:38] ty [23:16:43] Always. :-) [23:18:01] (03PS15) 10Paladox: Vector: Fix missing tab images on Special:Preferences [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/151425 [23:18:25] (03PS10) 10Paladox: Update Moment.js from 2.7.0 to 2.8.1 [core] - 10https://gerrit.wikimedia.org/r/151630 [23:18:43] ori: er, are you going to deploy it? [23:18:54] 3MediaWiki extensions / 3[other]: [WYSIWYG] Call to undefined methods - 10https://bugzilla.wikimedia.org/69378#c3 (10Florian) *** Bug 69379 has been marked as a duplicate of this bug. *** [23:18:54] 3MediaWiki extensions / 3[other]: [WYSIWYG] Fatal error - 10https://bugzilla.wikimedia.org/69379#c1 (10Florian) 5NEW>3RESO/DUP Please see the duplicate bug *** This bug has been marked as a duplicate of bug 69378 *** [23:21:41] 3MediaWiki / 3General/Unknown: Investigate whether taking an action on a page (delete, import, etc.) should require being able to edit it - 10https://bugzilla.wikimedia.org/69380 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3major a:3None Background: "superprotect" launched on de.wp which prevented adm... [23:21:42] legoktm: i could if you like [23:21:50] yes please :) [23:21:53] 3MediaWiki / 3General/Unknown: Investigate whether taking an action on a page (delete, import, etc.) should require being able to edit it - 10https://bugzilla.wikimedia.org/69380 (10Kunal Mehta (Legoktm)) p:5Unprio>3High [23:22:23] (03CR) 10Legoktm: "I filed bug 69380 to discuss whether this was a good idea." [core] - 10https://gerrit.wikimedia.org/r/153345 (owner: 10Anomie) [23:23:09] 3Wikimedia / 3Git/Gerrit: [WYSIWYG] Call to undefined methods - 10https://bugzilla.wikimedia.org/69378#c4 (10Florian) 5PATC>3NEW This extension looks like a...no words for that. This needs a lot of work to get this extension back to work. The Extension page https://www.mediawiki.org/wiki/Extension:WYSIWY... [23:24:31] (03CR) 10Ori.livneh: [C: 032] Fix MassMessage::getMessengerUser() after Password API changes [extensions/MassMessage] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153042 (https://bugzilla.wikimedia.org/68843) (owner: 10Legoktm) [23:24:42] (03Merged) 10jenkins-bot: Fix MassMessage::getMessengerUser() after Password API changes [extensions/MassMessage] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153042 (https://bugzilla.wikimedia.org/68843) (owner: 10Legoktm) [23:27:48] (03PS1) 10Ori.livneh: Update MassMessage for I840c98dca [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153358 [23:28:06] (03CR) 10Ori.livneh: [C: 032] Update MassMessage for I840c98dca [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153358 (owner: 10Ori.livneh) [23:30:46] (03CR) 10Legoktm: [C: 04-1] "Figure out bug 69380 first. New config options should be added sparingly, and this doesn't seem like a good idea. We should either enforce" [core] - 10https://gerrit.wikimedia.org/r/153349 (owner: 10CSteipp) [23:31:23] (03CR) 10jenkins-bot: [V: 04-1] Update MassMessage for I840c98dca [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153358 (owner: 10Ori.livneh) [23:31:25] (03Merged) 10jenkins-bot: Update MassMessage for I840c98dca [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153358 (owner: 10Ori.livneh) [23:31:42] huh? [23:31:56] oh lovely [23:32:04] transient qunit failure [23:32:41] bug #1: jenkins still continues executing the test suite twice (once for the initial commit, once for the gate-and-commit) [23:32:55] bug #2: transient qunit failures are still happening [23:33:34] bug #3: it doesn't acknowledge the discrepancy or regard its own -1 in that case [23:38:57] legoktm: here's my trout-worthy idea of the day: add a config option to add other actions (like delete) to the protection screen [23:39:31] I think that's totally reasonable. [23:39:58] Adding the ability to protect for any action besides edit/move/upload/create makes sense to me. [23:40:07] I just don't think we should use "edit" to also imply "delete". [23:40:53] 3MediaWiki extensions / 3GoogleLogin: Login not possible and nor error message it username is deleted/merged by UserMerge extension - 10https://bugzilla.wikimedia.org/68317#c4 (10Florian) 5ASSI>3RESO/FIX @Mike: I will set this as fixed, if you have still problems, feel free to reopen. [23:41:08] 3MediaWiki extensions / 3MassMessage: MassMessage::getMessengerUser() takeover broken due to Password API changes - 10https://bugzilla.wikimedia.org/68843#c12 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX Deployed by Ori, thanks! [23:42:27] legoktm: see also https://gerrit.wikimedia.org/r/#/c/105103/ [23:42:39] (and its associated bug) [23:42:48] Ha. [23:42:53] I said the exact opposite there. [23:43:36] I probably need to think about this a bit more. [23:44:24] 3MediaWiki / 3Page protection: Edit protection should still allow users to move the page - 10https://bugzilla.wikimedia.org/38365 (10Kunal Mehta (Legoktm)) [23:44:24] 3MediaWiki / 3General/Unknown: Investigate whether taking an action on a page (delete, import, etc.) should require being able to edit it - 10https://bugzilla.wikimedia.org/69380 (10Kunal Mehta (Legoktm)) [23:48:37] (03PS1) 10Ori.livneh: Revert "Update MassMessage for I840c98dca" [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153360 [23:48:51] (03CR) 10Ori.livneh: [C: 032 V: 032] Revert "Update MassMessage for I840c98dca" [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153360 (owner: 10Ori.livneh) [23:49:39] 3MediaWiki / 3Page editing: The createpage right should allow creating pages even without the edit right - 10https://bugzilla.wikimedia.org/35238 (10Jackmcbarn) [23:49:39] 3MediaWiki / 3General/Unknown: Investigate whether taking an action on a page (delete, import, etc.) should require being able to edit it - 10https://bugzilla.wikimedia.org/69380 (10Jackmcbarn) [23:54:11] 3MediaWiki extensions / 3MassMessage: UserGetRights hook causes MassMessage::getMessengerUser() to be called on every pageview - 10https://bugzilla.wikimedia.org/69381 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None This really shouldn't be happening. We can probably move the hook into the... [23:57:23] 3MediaWiki / 3Page editing: The createpage right should allow creating pages even without the edit right - 10https://bugzilla.wikimedia.org/35238#c9 (10James Forrester) 5NEW>3RESO/WON Sorry, but I don't see a valid use case for a write-once-read-many medium using MediaWiki.