[00:00:23] (03CR) 10Jdlrobson: "@SG @Matmarex. Can you please provide an alternative patch? This is blocking some work that Flow needs and since you are in the other camp" [core] - 10https://gerrit.wikimedia.org/r/151792 (owner: 10Jdlrobson) [00:03:38] 3MediaWiki extensions / 3Translate: Recover gracefully from session expiration - 10https://bugzilla.wikimedia.org/69314#c2 (10Nemo) This is a duplicate though. [00:05:11] 3MediaWiki extensions / 3Translate: You are not warned when log in is lost or expired - 10https://bugzilla.wikimedia.org/48775#c5 (10Nemo) 5REOP>3RESO/DUP *** This bug has been marked as a duplicate of bug 69314 *** [00:05:11] 3MediaWiki extensions / 3Translate: Recover gracefully from session expiration - 10https://bugzilla.wikimedia.org/69314#c3 (10Nemo) *** Bug 48775 has been marked as a duplicate of this bug. *** [00:05:24] 3MediaWiki extensions / 3Translate: Recover gracefully from session expiration - 10https://bugzilla.wikimedia.org/69314#c4 (10Nemo) *** Bug 48773 has been marked as a duplicate of this bug. *** [00:05:24] 3MediaWiki extensions / 3Translate: When saving failed user has no way to retry and even if many failed YOU ARE NOT NOTIFIED - 10https://bugzilla.wikimedia.org/48773#c10 (10Nemo) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 69314 *** [00:05:39] (03PS1) 10Jdlrobson: Stop breaking MobileFrontend QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152999 (https://bugzilla.wikimedia.org/69316) [00:05:40] 3MediaWiki / 3Page editing: Warn user that they're now logged out when they originally weren't - 10https://bugzilla.wikimedia.org/48657#c2 (10Nemo) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 69314 *** [00:05:40] 3MediaWiki extensions / 3Translate: Recover gracefully from session expiration - 10https://bugzilla.wikimedia.org/69314#c5 (10Nemo) *** Bug 48657 has been marked as a duplicate of this bug. *** [00:05:54] 3MediaWiki extensions / 3Translate: Recover gracefully from session expiration - 10https://bugzilla.wikimedia.org/69314#c6 (10Nemo) *** Bug 47184 has been marked as a duplicate of this bug. *** [00:05:54] 3MediaWiki extensions / 3Translate: [TUX] Special:Translate should give warning on exit when changes have not been applied yet - 10https://bugzilla.wikimedia.org/47184#c5 (10Nemo) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 69314 *** [00:06:32] (03PS2) 10Reedy: Let subclasses specify their associated content class for JSONContentHandler [core] - 10https://gerrit.wikimedia.org/r/152998 (owner: 10Legoktm) [00:06:34] (03PS2) 10Jdlrobson: Stop breaking MobileFrontend QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152999 (https://bugzilla.wikimedia.org/69316) [00:06:37] (03CR) 10Reedy: [C: 032] Let subclasses specify their associated content class for JSONContentHandler [core] - 10https://gerrit.wikimedia.org/r/152998 (owner: 10Legoktm) [00:06:57] 3MediaWiki extensions / 3Translate: Recover gracefully from session expiration - 10https://bugzilla.wikimedia.org/69314#c7 (10Nemo) Comment 0 appears to span all cases covered by the 4 previous bug reports now merged into this. [00:06:57] 3MediaWiki / 3JavaScript: Cannot recover from invalid token error - 10https://bugzilla.wikimedia.org/41466 (10Nemo) [00:07:15] (03PS1) 10Florianschmidtwelzow: Remove qunit tests from mobile [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153000 (https://bugzilla.wikimedia.org/69316) [00:07:41] (03CR) 10Florianschmidtwelzow: "damn" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152999 (https://bugzilla.wikimedia.org/69316) (owner: 10Jdlrobson) [00:08:27] (03CR) 10Jdlrobson: [C: 032] "i prefer your way.. :) ideally tests should copy their parent module" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153000 (https://bugzilla.wikimedia.org/69316) (owner: 10Florianschmidtwelzow) [00:08:51] (03Merged) 10jenkins-bot: Remove qunit tests from mobile [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153000 (https://bugzilla.wikimedia.org/69316) (owner: 10Florianschmidtwelzow) [00:08:57] (03Abandoned) 10Jdlrobson: Stop breaking MobileFrontend QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152999 (https://bugzilla.wikimedia.org/69316) (owner: 10Jdlrobson) [00:10:03] (03CR) 10Florianschmidtwelzow: "And the id is better 153000 (my), 152999 (yours) :P Thanks for merge!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153000 (https://bugzilla.wikimedia.org/69316) (owner: 10Florianschmidtwelzow) [00:10:12] (03Merged) 10jenkins-bot: Let subclasses specify their associated content class for JSONContentHandler [core] - 10https://gerrit.wikimedia.org/r/152998 (owner: 10Legoktm) [00:10:30] (03PS2) 10Reedy: SpecialImport: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151535 (owner: 10Legoktm) [00:10:36] (03CR) 10Reedy: [C: 032] SpecialImport: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151535 (owner: 10Legoktm) [00:11:09] 3MediaWiki extensions / 3Translate: TranslateSandboxEmailJob failing - 10https://bugzilla.wikimedia.org/69251 (10Nemo) [00:14:10] (03Merged) 10jenkins-bot: SpecialImport: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151535 (owner: 10Legoktm) [00:17:09] (03PS1) 10Addshore: Move MediaWikiPasswordTestCase to password dir [core] - 10https://gerrit.wikimedia.org/r/153001 [00:18:33] (03CR) 10jenkins-bot: [V: 04-1] Move MediaWikiPasswordTestCase to password dir [core] - 10https://gerrit.wikimedia.org/r/153001 (owner: 10Addshore) [00:19:53] 3Wikimedia / 3Stream: stream.wikimedia.org throws websocket.WebSocketException: Handshake Status 502 Bad Gateway - 10https://bugzilla.wikimedia.org/66989#c4 (10Ori Livneh) Merlijn van Deen offered to look into this with me and we were able to identify the problem: the WebSocket handshake requires two round-t... [00:19:57] (03PS2) 10Addshore: Move MediaWikiPasswordTestCase to password dir [core] - 10https://gerrit.wikimedia.org/r/153001 [00:27:30] (03PS1) 10Bartosz Dziewoński: [WIP] Expose language fallback chain in JavaScript [core] - 10https://gerrit.wikimedia.org/r/153002 (https://bugzilla.wikimedia.org/69285) [00:28:08] 3MediaWiki extensions / 3Translate: Recover gracefully from session expiration - 10https://bugzilla.wikimedia.org/69314#c8 (10MZMcBride) (In reply to Nemo from comment #7) > Comment 0 appears to span all cases covered by the 4 previous bug reports > now merged into this. I'm not sure one large bug makes mor... [00:28:42] (03PS4) 10Ori.livneh: Add molhandler and svg role [vagrant] - 10https://gerrit.wikimedia.org/r/152737 (owner: 10Rillke) [00:29:44] (03PS1) 10Legoktm: Revert "Pass a real IContextSource to ProtectedTitlesPager" [core] - 10https://gerrit.wikimedia.org/r/153003 [00:30:07] (03PS2) 10Reedy: Revert "Pass a real IContextSource to ProtectedTitlesPager" [core] - 10https://gerrit.wikimedia.org/r/153003 (owner: 10Legoktm) [00:30:12] (03CR) 10Reedy: [C: 032] "[01:28:22] [rakkaus] [09-Aug-2014 00:28:12 UTC] PHP Fatal error: Call to undefined method RequestContext::getContext() in /www/translatew" [core] - 10https://gerrit.wikimedia.org/r/153003 (owner: 10Legoktm) [00:30:30] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Expose language fallback chain in JavaScript [core] - 10https://gerrit.wikimedia.org/r/153002 (https://bugzilla.wikimedia.org/69285) (owner: 10Bartosz Dziewoński) [00:30:45] (03CR) 10Addshore: [C: 032] Revert "Pass a real IContextSource to ProtectedTitlesPager" [core] - 10https://gerrit.wikimedia.org/r/153003 (owner: 10Legoktm) [00:30:53] 3MediaWiki / 3JavaScript: Expose language fallback chain for user language in JS - 10https://bugzilla.wikimedia.org/69285#c2 (10Bartosz Dziewoński) I wrote that patch for now because this seemed interesting :), but I probably won't have time to finish it soon (see commit message for the issues). If anyone wa... [00:30:53] (03CR) 10Bartosz Dziewoński: "I wrote this for now because this seemed interesting :), but I probably won't have time to finish it soon (see commit message for the issu" [core] - 10https://gerrit.wikimedia.org/r/153002 (https://bugzilla.wikimedia.org/69285) (owner: 10Bartosz Dziewoński) [00:33:43] (03Merged) 10jenkins-bot: Revert "Pass a real IContextSource to ProtectedTitlesPager" [core] - 10https://gerrit.wikimedia.org/r/153003 (owner: 10Legoktm) [00:38:42] (03CR) 10Bartosz Dziewoński: [C: 04-1] "The margin is defined in two other files, but not this one. This should replace the other rules, not add on top of them." [core] - 10https://gerrit.wikimedia.org/r/152785 (owner: 10Gerrit Patch Uploader) [00:39:05] (03PS1) 10Addshore: Add SpecialPageTestBase [core] - 10https://gerrit.wikimedia.org/r/153005 [00:40:08] (03PS3) 10Legoktm: Move MediaWikiPasswordTestCase to password dir [core] - 10https://gerrit.wikimedia.org/r/153001 (owner: 10Addshore) [00:40:13] (03CR) 10Legoktm: [C: 032] Move MediaWikiPasswordTestCase to password dir [core] - 10https://gerrit.wikimedia.org/r/153001 (owner: 10Addshore) [00:43:33] (03CR) 10Bsitu: [C: 032] Hygiene: Break out _buildNotificationList [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152163 (owner: 10Jdlrobson) [00:43:49] (03Merged) 10jenkins-bot: Move MediaWikiPasswordTestCase to password dir [core] - 10https://gerrit.wikimedia.org/r/153001 (owner: 10Addshore) [00:43:59] (03Merged) 10jenkins-bot: Hygiene: Break out _buildNotificationList [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152163 (owner: 10Jdlrobson) [00:46:30] (03PS2) 10Addshore: Add SpecialPageTestBase [core] - 10https://gerrit.wikimedia.org/r/153005 [00:46:52] (03PS13) 10Jdlrobson: Notification overlay Messages and Alerts sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152165 [00:46:56] (03CR) 10jenkins-bot: [V: 04-1] Notification overlay Messages and Alerts sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152165 (owner: 10Jdlrobson) [00:49:23] (03CR) 10Ori.livneh: [C: 032] "very cool, thanks!" [vagrant] - 10https://gerrit.wikimedia.org/r/152737 (owner: 10Rillke) [00:49:28] (03Merged) 10jenkins-bot: Add molhandler and svg role [vagrant] - 10https://gerrit.wikimedia.org/r/152737 (owner: 10Rillke) [00:51:26] (03PS3) 10Addshore: Add SpecialPageTestBase [core] - 10https://gerrit.wikimedia.org/r/153005 [01:01:02] (03PS1) 10Bsitu: Missing sectionId in flow_anon_warning.handlebars [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153006 [01:04:11] 3Wikimedia / 3General/Unknown: link to wikinews does not work for file: command - 10https://bugzilla.wikimedia.org/69317 (10FRacco) 3UNCO p:3Unprio s:3minor a:3None Intention: In Italian projects links to "wikinews:" do not work for images, "n:en:" is ok. Links [[wikinews:]] or [[n:en:]] are always o... [01:12:28] (03PS2) 10Legoktm: Remove @todo in SpecialPage for making it into ContextSource [core] - 10https://gerrit.wikimedia.org/r/148996 (owner: 10Aude) [01:12:41] (03CR) 10Legoktm: [C: 032] Remove @todo in SpecialPage for making it into ContextSource [core] - 10https://gerrit.wikimedia.org/r/148996 (owner: 10Aude) [01:16:05] (03Merged) 10jenkins-bot: Remove @todo in SpecialPage for making it into ContextSource [core] - 10https://gerrit.wikimedia.org/r/148996 (owner: 10Aude) [01:29:25] (03CR) 10Mattflaschen: [C: 04-2] "The only image Brion posted to that bug is a screenshot showing the problem, so I don't think you're attributing the right person." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [01:35:38] 3MediaWiki / 3Skin and page rendering: closeElement causes UI breakage when $wgWellFormedXml = false;, does not conform to spec - 10https://bugzilla.wikimedia.org/52210 (10Matthew Flaschen) 5PATC>3RESO/FIX [01:48:47] (03CR) 10Paladox: "Ok well the user notice the image after the patch was uploaded and so I am uploading the updated image that fixes the problem. And I have " [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [01:59:08] 3MediaWiki / 3Skin and page rendering: Implement checkbox spec in mediawiki.ui - 10https://bugzilla.wikimedia.org/69200#c10 (10Matthew Flaschen) (In reply to Jared Zimmerman (WMF) from comment #8) > Can we use wikifont characters for this rather than svgs? I don't know, but the initial implementation is alr... [02:19:23] 3Wikimedia / 3Site requests: Move oldwikisource on www.wikisource.org to mul.wikisource.org - 10https://bugzilla.wikimedia.org/62717#c6 (10George Orwell III) The "harm" is that memory hole ruins it for the rest of the wikisource domains. Type "wikipedia.org" and "wikisource.org" into your browser's url addr... [02:19:27] 3MediaWiki extensions / 3Gadgets: Implement Gadgets 2.0 (tracking) - 10https://bugzilla.wikimedia.org/29272 (10Kunal Mehta (Legoktm)) [02:19:29] 3MediaWiki extensions / 3Gadgets: Convert Gadgets 2.0 namespaces to use ContentHandler - 10https://bugzilla.wikimedia.org/69318 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None We now have a JSONContentHandler in core which can be used for Gadget definition, and the Gadget namespace should... [02:25:38] Carmela: https://bugzilla.wikimedia.org/show_bug.cgi?id=68599#c2 if you haven't seen it [02:26:47] transclusion wasn't in the original list so I forgot to mention it, but lego thinks we should wait for https://gerrit.wikimedia.org/r/#/c/132710/ for that [02:27:53] (03CR) 10Mattflaschen: [C: 04-1] "There are some questions and details that need to be worked out." (035 comments) [core] - 10https://gerrit.wikimedia.org/r/150418 (owner: 10Jdlrobson) [02:30:47] (ping me if you need anything) [02:33:55] 3Wikimedia / 3General/Unknown: Allow option to uncheck "Always use a secure connection when logged in" at login.wikimedia.org/wiki/Special:Preferences - 10https://bugzilla.wikimedia.org/69319 (10Cometstyles) 3NEW p:3Unprio s:3normal a:3None I generally use wikimedia wikis on the non-secured http for... [02:35:08] 3Wikimedia / 3General/Unknown: Allow option to uncheck "Always use a secure connection when logged in" at login.wikimedia.org/wiki/Special:Preferences - 10https://bugzilla.wikimedia.org/69319 (10Cometstyles) [02:35:38] 3Wikimedia / 3General/Unknown: Allow option to uncheck "Always use a secure connection when logged in" at login.wikimedia.org/wiki/Special:Preferences - 10https://bugzilla.wikimedia.org/69319 (10Cometstyles) [02:57:03] (03CR) 10Legoktm: [C: 032] Implement warning for blank edit summaries [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/152861 (owner: 10Wctaiwan) [02:57:14] (03Merged) 10jenkins-bot: Implement warning for blank edit summaries [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/152861 (owner: 10Wctaiwan) [03:01:09] (03CR) 10Mattflaschen: [C: 04-1] Add blanket support for mediawiki ui via globals (031 comment) [core] - 10https://gerrit.wikimedia.org/r/150635 (owner: 10Jdlrobson) [03:03:53] 3MediaWiki / 3Installer: change in default schema for MSSQL complicates installation with PostgreSQL - 10https://bugzilla.wikimedia.org/64043#c11 (10Ryan Schmidt) Patch set 3 was a rework because it broke sqlite, thus breaking every unit test. The fix is incredibly simple; change Database::factory to Databa... [03:04:54] 3MediaWiki / 3Installer: Missing defaults in GUI installer - 10https://bugzilla.wikimedia.org/69281#c2 (10Ryan Schmidt) 5NEW>3ASSI a:3Ryan Schmidt Assigning to self, don't have time to work on this right now but I should within the next few days. If I don't have something uploaded to gerrit by next wee... [03:14:59] wctaiwan: Cool, thanks. [03:15:36] wctaiwan: My comments were mostly nitpicks, overall the extension looks/work great. [03:15:42] I'm excited to see it in production. [03:15:46] thanks :) [03:33:36] (03CR) 10Mattflaschen: ""@SG @Matmarex. Can you please provide an alternative patch? This is blocking some work that Flow needs and since you are in the other cam" [core] - 10https://gerrit.wikimedia.org/r/151792 (owner: 10Jdlrobson) [03:42:18] (03CR) 10Mattflaschen: "Like I said, Brion Vibber did not create those images, unless you got them from somewhere separate from the bug." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [03:50:06] (03PS1) 10Microchip08: correct typographical errors in privacy.html [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153012 [04:04:42] (03PS1) 10Mattflaschen: Add MonoBook, Modern, and CologneBlue [vagrant] - 10https://gerrit.wikimedia.org/r/153013 (https://bugzilla.wikimedia.org/69259) [04:05:53] 3MediaWiki-Vagrant: Fix wiki by loading skins from their new repositories - 10https://bugzilla.wikimedia.org/69259 (10Matthew Flaschen) p:5High>3Normal s:5critic>3normal [04:17:26] superm401: it's late [04:17:43] or early [04:17:59] ori, yeah, it's like midnight here, so take your pick. Obviously, I don't expect you to review that tonight. [04:18:04] Heck, I didn't even add you as a reviewer. ;) [04:18:09] And I'm finishing up. [04:18:40] it looks good to me; have you tested it? [04:19:17] ori, yep (BTW, I was just joking about the reviewer thing). [04:19:38] 3MediaWiki extensions / 3Gadgets: Convert Gadgets 2.0 namespaces to use ContentHandler - 10https://bugzilla.wikimedia.org/69318#c1 (10Ori Livneh) \o/ [04:19:53] (03CR) 10Ori.livneh: [C: 032] Add MonoBook, Modern, and CologneBlue [vagrant] - 10https://gerrit.wikimedia.org/r/153013 (https://bugzilla.wikimedia.org/69259) (owner: 10Mattflaschen) [04:19:58] (03Merged) 10jenkins-bot: Add MonoBook, Modern, and CologneBlue [vagrant] - 10https://gerrit.wikimedia.org/r/153013 (https://bugzilla.wikimedia.org/69259) (owner: 10Mattflaschen) [04:20:09] were there ever other Colognes? [04:20:22] CologneGreen? CologneMagenta? [04:21:22] ori, it makes you wonder, right? I have a vague feeling it's named after the city, but I honestly don't know. [04:21:30] (03PS2) 10Microchip08: correct typographical errors in privacy.html [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153012 [04:21:56] ^ Happy to see that patch; there are a lot of typos. [04:23:10] ori, are you at Wikimania? [04:23:27] yep [04:24:29] Alright, have a good night/morning. I may be on over the weekend. [04:26:56] good night [04:27:00] thanks for the fix [04:27:02] superm401: https://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/SkinCologneBlue.php?revision=1284&view=markup&pathrev=5000 [04:27:16] not very informative [04:28:14] I think that's the first commit of phase 3. :) [04:47:44] (03PS2) 10Bsitu: Add 'target-page' param to flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/152935 [04:49:00] (03PS5) 10Bsitu: [WIP]Create TargetPage data if specified by EchoEvent [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152808 [04:49:02] I assumed it was named after the perfume (the packaging of which is blue, as far as I can tell) [04:49:04] (03CR) 10jenkins-bot: [V: 04-1] [WIP]Create TargetPage data if specified by EchoEvent [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152808 (owner: 10Bsitu) [04:54:13] (03PS4) 10Bsitu: Auto mark notification as read if it doesn't have target page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152203 [04:54:16] (03CR) 10jenkins-bot: [V: 04-1] Auto mark notification as read if it doesn't have target page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/152203 (owner: 10Bsitu) [05:01:50] (03CR) 1001tonythomas: [C: 031] "looks good to merge, I think." [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/152934 (https://bugzilla.wikimedia.org/69099) (owner: 1001tonythomas) [05:03:23] 3Wikimedia / 3Site requests: Switch Media Viewer to opt-in for default in dewp - 10https://bugzilla.wikimedia.org/69292 (10MZMcBride) [05:19:51] (03PS3) 10Vikassy: WIP: Updated MEDIAWIKI_API_UPLOAD_URL for language screenshot job to production commons(http://commons.wikimedia.org) [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147415 [05:51:54] (03PS3) 10Umherirrender: Split RevisionDeleteAbstracts.php to separate files [core] - 10https://gerrit.wikimedia.org/r/152912 [06:00:36] (03CR) 10Spage: [C: 04-1] "On ee-flow I got one failure in" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151806 (owner: 10Jdlrobson) [06:12:55] 3MediaWiki / 3Patrolling: Ability to mark a page as unpatrolled - 10https://bugzilla.wikimedia.org/69323 (10Dalba) 3UNCO p:3Unprio s:3enhanc a:3None Sometimes users mark a page as patrolled by mistake or maybe they notice something later that makes them think the page should not be marked as patrolle... [06:19:41] (03CR) 10Spage: ""SeleniumEchoUser" + @random_string can get exceed the username limit on some wikis, which explains one beta labs test failure I had." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151806 (owner: 10Jdlrobson) [06:38:40] 3MediaWiki / 3Special pages: Moving a page won't change its namespace parameter under special:newpages - 10https://bugzilla.wikimedia.org/69324 (10Dalba) 3UNCO p:3Unprio s:3normal a:3None Imagine the following scenario: * User:A creates a userpage at user:A/sandbox. The page will be listed at /w/ind... [06:39:23] 3MediaWiki extensions / 3Translate: Make PageTranslation and PageMigration fields bigger/more usable - 10https://bugzilla.wikimedia.org/69273#c2 (10Pratik Lahoti) Fine, no problem in doing that. [06:53:49] (03PS1) 1001tonythomas: Fixed various issues with the BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153016 (https://bugzilla.wikimedia.org/69099) [06:55:39] (03PS2) 1001tonythomas: Fixed various issues with the BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153016 (https://bugzilla.wikimedia.org/69099) [07:14:38] 3MediaWiki extensions / 3Translate: Special:PageMigration after saving offers "save" and "import" without explanation - 10https://bugzilla.wikimedia.org/69290#c1 (10Pratik Lahoti) I think it is better to go with option a), since that is something which we are also doing at Special:PagePreparation. [07:21:09] 3MediaWiki extensions / 3Translate: Special page for migration of legacy translation pages (tracking) - 10https://bugzilla.wikimedia.org/65740 (10Nemo) [07:21:10] 3MediaWiki extensions / 3Translate: [PageMigration, PagePreparation] Go for one naming format - 10https://bugzilla.wikimedia.org/69325 (10Nemo) 3NEW p:3Unprio s:3trivia a:3Pratik Lahoti ext.translate.pagepreparation.js ext.translate.special.pagemigration.js They're both special pages now, should bot... [07:31:08] 3MediaWiki extensions / 3Translate: [PageMigration] Tab should go to the next translation textarea - 10https://bugzilla.wikimedia.org/69307 (10Nemo) p:5Unprio>3Normal [07:34:56] (03PS10) 10Nemo bis: Remove hitcounters and associated code [core] - 10https://gerrit.wikimedia.org/r/150699 (owner: 10Chad) [07:35:29] (03CR) 10Nemo bis: "Removed mention of https://www.mediawiki.org/w/index.php?title=Requests_for_comment/Removing_hit_counters_from_MediaWiki_core which made i" [core] - 10https://gerrit.wikimedia.org/r/150699 (owner: 10Chad) [07:37:03] (03PS2) 10Hashar: Remove 'normal' from list of extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152938 (owner: 10Addshore) [07:37:08] (03PS3) 10Hashar: Remove 'normal' from list of extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152938 (owner: 10Addshore) [07:37:34] (03PS2) 10Hashar: Remove triggers for 'normal' [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152937 (owner: 10Addshore) [07:37:59] (03CR) 10Hashar: [C: 032] Remove triggers for 'normal' [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152937 (owner: 10Addshore) [07:38:05] (03CR) 10Hashar: [C: 032] Remove 'normal' from list of extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152938 (owner: 10Addshore) [07:38:13] (03Merged) 10jenkins-bot: Remove triggers for 'normal' [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152937 (owner: 10Addshore) [07:39:59] (03Merged) 10jenkins-bot: Remove 'normal' from list of extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152938 (owner: 10Addshore) [08:02:12] (03PS2) 10Hashar: Make 4 more extensions jobs voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152972 (owner: 10Addshore) [08:02:38] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Comments] - 10https://gerrit.wikimedia.org/r/152350 [08:02:54] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/152458 [08:03:09] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Moodle] - 10https://gerrit.wikimedia.org/r/152485 [08:03:25] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/OpenStreetMapSlippyMap] - 10https://gerrit.wikimedia.org/r/152517 [08:04:13] (03CR) 10Hashar: [C: 032] "Confirmed they all pass tests." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152972 (owner: 10Addshore) [08:04:21] (03Merged) 10jenkins-bot: Make 4 more extensions jobs voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152972 (owner: 10Addshore) [08:04:26] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Comments] - 10https://gerrit.wikimedia.org/r/152350 (owner: 10Hashar) [08:04:30] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/152458 (owner: 10Hashar) [08:04:34] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Moodle] - 10https://gerrit.wikimedia.org/r/152485 (owner: 10Hashar) [08:04:38] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/OpenStreetMapSlippyMap] - 10https://gerrit.wikimedia.org/r/152517 (owner: 10Hashar) [08:08:23] 3MediaWiki / 3Skin and page rendering: Implement checkbox spec in mediawiki.ui - 10https://bugzilla.wikimedia.org/69200#c11 (10Jared Zimmerman (WMF)) If all the other mediawiki.ui controls will be using wikifont I'd prefer we go ahead and do this correctly vs quickly. It'll just come back to bite us if we do... [08:10:51] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/NoUnwrap] - 10https://gerrit.wikimedia.org/r/152504 (owner: 10Hashar) [08:17:31] (03PS5) 10Zfilipin: WIP Run rubocop, Ruby linter, for all repositories that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152926 (https://bugzilla.wikimedia.org/69245) [08:21:38] 3MediaWiki / 3Installer: Missing defaults in GUI installer - 10https://bugzilla.wikimedia.org/69281 (10Kunal Mehta (Legoktm)) [08:24:08] 3MediaWiki extensions / 3Translate: Recover gracefully from session expiration - 10https://bugzilla.wikimedia.org/69314 (10Nemo) [08:40:14] (03CR) 10Chad: "Well if this gets merged it basically is accepted. Please put it back." [core] - 10https://gerrit.wikimedia.org/r/150699 (owner: 10Chad) [08:41:18] (03PS3) 1001tonythomas: Fixed various issues with the BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153016 (https://bugzilla.wikimedia.org/69099) [08:48:54] (03PS4) 1001tonythomas: Fixed various issues with the BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153016 (https://bugzilla.wikimedia.org/69099) [08:49:38] 3MediaWiki extensions / 3Translate: [PageMigration, PagePreparation] Go for one naming format - 10https://bugzilla.wikimedia.org/69325#c1 (10Pratik Lahoti) Yes, I have noticed that way back. Thought of renaming after everything else is done. [08:51:38] (03PS5) 1001tonythomas: Fixed various issues with the BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153016 (https://bugzilla.wikimedia.org/69099) [08:52:45] (03CR) 10Fomafix: "The definition in the other files are necessary for thumbs on special pages where there is no mw-content-ltr or mw-content-rtl. See bug 69" [core] - 10https://gerrit.wikimedia.org/r/152785 (owner: 10Gerrit Patch Uploader) [08:54:12] (03PS6) 1001tonythomas: Fixed various issues with the BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153016 (https://bugzilla.wikimedia.org/69099) [08:56:05] (03PS1) 10Chmarkine: Use protocol relative URLs for some links on Transparency Report pages [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153026 [09:02:40] (03PS2) 10Chmarkine: Use protocol relative URLs for some links on Transparency Report pages [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153026 [09:03:18] (03PS3) 10Chmarkine: Use protocol relative URLs for some links on Transparency Report pages [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153026 [09:03:25] (03CR) 10Anomie: [C: 032] Updated to the new way of adding no-size-check results [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/152957 (owner: 10Yurik) [09:03:31] (03Merged) 10jenkins-bot: Updated to the new way of adding no-size-check results [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/152957 (owner: 10Yurik) [09:11:55] 3MediaWiki extensions / 3ProofreadPage: The editing interface of Page: pages with WikiEditor is broken in 1.24wmf16 - 10https://bugzilla.wikimedia.org/69327 (10Tpt) 3NEW p:3Unprio s:3critic a:3None The editing interface of Page: pages is currently broken with 1.24wmf16 when WikiEditor is activated be... [09:12:51] (03PS1) 10Tpt: Avoid dependance on a WikiEditor class that have been recently removed [extensions/ProofreadPage] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153027 (https://bugzilla.wikimedia.org/69327) [09:20:23] 3MediaWiki extensions / 3CirrusSearch: Add syntax for searching for articles with a given wikilink - 10https://bugzilla.wikimedia.org/69295 (10Chad H.) p:5Unprio>3Normal [09:21:43] (03PS1) 10Mitar: Really fail if OAuth request source IP is invalid. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153028 [09:22:56] (03PS3) 10Robert Vogel: [WIP] BS223: ContextMenu [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151625 (owner: 10Tweichart) [09:25:05] (03PS1) 10Robert Vogel: Fixed hook handler naming [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/153029 [09:38:38] 3MediaWiki / 3JavaScript: jquery.highlightText.js needs to be able to highlight more than one word, numbers, spaces, and punctuation - 10https://bugzilla.wikimedia.org/67784#c2 (10Dan Kindsvater) A (possibly older) version of highlightText is at https://git.wikimedia.org/blob/mediawiki%2Fcore/596a2584b0ea7ca... [09:46:33] (03PS4) 10JanZerebecki: Use protocol relative URLs for some links on Transparency Report pages [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153026 (owner: 10Chmarkine) [09:47:01] (03PS5) 10JanZerebecki: Use protocol relative URLs for some links on Transparency Report pages [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153026 (owner: 10Chmarkine) [09:47:34] (03CR) 10JanZerebecki: [C: 031] "Yes, please, thank you." [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153026 (owner: 10Chmarkine) [10:01:13] (03CR) 10Nikerabbit: "How about limiting this patch to just providing the fallback list?" [core] - 10https://gerrit.wikimedia.org/r/153002 (https://bugzilla.wikimedia.org/69285) (owner: 10Bartosz Dziewoński) [10:13:23] 3MediaWiki / 3JavaScript: Expose language fallback chain for user language in JS - 10https://bugzilla.wikimedia.org/69285#c3 (10Nemo) (In reply to Bartosz Dziewoński from comment #2) > I wrote that patch for now because this seemed interesting :) It is! Thanks. [10:18:32] (03PS4) 10Addshore: Add SpecialPageTestBase [core] - 10https://gerrit.wikimedia.org/r/153005 [10:19:34] ori: Lcawte has offered to write CologneMagenta [10:20:00] I am not the Lcawte you are looking for... [10:20:36] legoktm: stop volunteering Lcawte before you even ask them [10:20:45] he offered! [10:20:47] (03CR) 10Foxtrott: Add composer.json (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/152927 (owner: 10Mwjames) [10:21:30] (03PS3) 10BryanDavis: Add role::php5vhost [vagrant] - 10https://gerrit.wikimedia.org/r/149243 (https://bugzilla.wikimedia.org/67517) [10:21:48] (03PS4) 10BryanDavis: Add role::php5vhost [vagrant] - 10https://gerrit.wikimedia.org/r/149243 (https://bugzilla.wikimedia.org/67517) [10:22:32] legoktm: we could just make it as a extension then have a special page and pick th colours you want! *runs* [10:23:01] CologneBlackAndFluroGreen >.> [10:23:20] * Lcawte wonders if there is a bugzilla component for the Theme extension [10:27:35] (03PS1) 10BryanDavis: Fix apache for zend role [vagrant] - 10https://gerrit.wikimedia.org/r/153035 [10:27:37] (03PS1) 10BryanDavis: Fix undefined values for wikidata config [vagrant] - 10https://gerrit.wikimedia.org/r/153036 [10:27:47] (03CR) 10Nikerabbit: Add composer.json (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/152927 (owner: 10Mwjames) [10:29:05] (03PS1) 10Legoktm: Extend JSONContent from core [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/153037 [10:30:09] (03CR) 10BryanDavis: [C: 032] "Sorry to all the zend users for the breakage this fixes." [vagrant] - 10https://gerrit.wikimedia.org/r/153035 (owner: 10BryanDavis) [10:30:14] (03Merged) 10jenkins-bot: Fix apache for zend role [vagrant] - 10https://gerrit.wikimedia.org/r/153035 (owner: 10BryanDavis) [10:30:16] (03PS7) 1001tonythomas: Fixed various issues with the BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153016 (https://bugzilla.wikimedia.org/69099) [10:30:43] (03CR) 10jenkins-bot: [V: 04-1] Extend JSONContent from core [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/153037 (owner: 10Legoktm) [10:32:48] (03PS2) 10Legoktm: Extend JSONContent from core [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/153037 [10:32:50] (03CR) 10Nemo bis: Add composer.json (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/152927 (owner: 10Mwjames) [10:34:17] (03CR) 10jenkins-bot: [V: 04-1] Extend JSONContent from core [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/153037 (owner: 10Legoktm) [10:35:34] (03PS3) 10Legoktm: Extend JSONContent from core [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/153037 [10:40:54] (03PS6) 10Legoktm: An additional base64_encode( hash_hmac( prefix, true ) ) was added [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/152934 (https://bugzilla.wikimedia.org/69099) (owner: 1001tonythomas) [10:41:07] (03CR) 10Legoktm: [C: 032] An additional base64_encode( hash_hmac( prefix, true ) ) was added [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/152934 (https://bugzilla.wikimedia.org/69099) (owner: 1001tonythomas) [10:41:12] (03Merged) 10jenkins-bot: An additional base64_encode( hash_hmac( prefix, true ) ) was added [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/152934 (https://bugzilla.wikimedia.org/69099) (owner: 1001tonythomas) [10:41:58] (03PS4) 10Legoktm: Extend JSONContent from core [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/153037 [10:43:55] (03CR) 10Dzahn: "afaik these html pages are generated by something offline, it might be necessary to change things there to avoid re-introducing the http l" [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153026 (owner: 10Chmarkine) [10:44:16] (03PS8) 1001tonythomas: Fixed various issues with the BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153016 (https://bugzilla.wikimedia.org/69099) [10:45:07] anyone here who is involved in the transparency report? [10:45:22] mutante: prtksxna is [10:45:40] and moiz(sp?) but I don't see him on IRC [10:46:23] legoktm: thanks [10:46:58] mutante: moizsyed can sometimes be found in #wikimedia-design [10:47:09] prtksxna: we have a pending gerrit change to make the links in there protocol relative, but since i heard you are generating that HTML offline, i think it might need changes elsewhere to avoid reintroducing the protocol every time [10:47:14] ok, thanks [10:47:55] mutante: I'll take a look. [10:47:59] prtksxna: i'll try, fyi, here is the change https://gerrit.wikimedia.org/r/#/c/153026/5 [10:48:26] that is about avoiding mixed content warnings [10:50:14] mutante: Got it. I'll try to take a look today. [10:50:54] cool, thank you [10:51:55] (03PS1) 10Legoktm: JSONContent: Add HTML escaping test from EventLogging [core] - 10https://gerrit.wikimedia.org/r/153038 [10:55:04] (03CR) 10jenkins-bot: [V: 04-1] JSONContent: Add HTML escaping test from EventLogging [core] - 10https://gerrit.wikimedia.org/r/153038 (owner: 10Legoktm) [10:55:10] (03PS2) 10Legoktm: JSONContent: Add HTML escaping test from EventLogging [core] - 10https://gerrit.wikimedia.org/r/153038 [10:57:41] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/152988 (https://bugzilla.wikimedia.org/68727) (owner: 10Florianschmidtwelzow) [10:59:24] (03CR) 10Addshore: [C: 032] JSONContent: Add HTML escaping test from EventLogging [core] - 10https://gerrit.wikimedia.org/r/153038 (owner: 10Legoktm) [11:01:14] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153028 (owner: 10Mitar) [11:01:50] (03Merged) 10jenkins-bot: JSONContent: Add HTML escaping test from EventLogging [core] - 10https://gerrit.wikimedia.org/r/153038 (owner: 10Legoktm) [11:03:02] (03PS1) 10Legoktm: JSONContent: Use self() instead of explicit class name to support subclasses [core] - 10https://gerrit.wikimedia.org/r/153039 [11:03:35] (03CR) 10Yuvipanda: [C: 032] JSONContent: Use self() instead of explicit class name to support subclasses [core] - 10https://gerrit.wikimedia.org/r/153039 (owner: 10Legoktm) [11:06:16] (03PS1) 10Legoktm: Convert Campaigns to extend JSONContent from core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153040 [11:07:00] (03Merged) 10jenkins-bot: JSONContent: Use self() instead of explicit class name to support subclasses [core] - 10https://gerrit.wikimedia.org/r/153039 (owner: 10Legoktm) [11:08:55] 3Wikimedia / 3Media storage: Swift outage caused a bunch of moved files to be "inconsistent" and "missing" - 10https://bugzilla.wikimedia.org/69311#c2 (10Steinsplitter) Maybe helpful for techs: Loosing of files is a long term problem because swift is causing a lot of problems on commons. (I can't find the bu... [11:13:36] (03PS1) 1001tonythomas: Fix regex fucntions after change I0f9b098982adf023347e3f1343f1e16ccec91df1 [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153041 [11:15:19] (03CR) 10Legoktm: [C: 032] Fix regex fucntions after change I0f9b098982adf023347e3f1343f1e16ccec91df1 [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153041 (owner: 1001tonythomas) [11:15:24] (03Merged) 10jenkins-bot: Fix regex fucntions after change I0f9b098982adf023347e3f1343f1e16ccec91df1 [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153041 (owner: 1001tonythomas) [11:15:31] aww typo [11:17:37] (03CR) 10Jforrester: [C: 031] Extend JSONContent from core [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/153037 (owner: 10Legoktm) [11:17:57] (03PS9) 1001tonythomas: Fixed various issues with the BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153016 (https://bugzilla.wikimedia.org/69099) [11:17:59] (03CR) 10jenkins-bot: [V: 04-1] Fixed various issues with the BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153016 (https://bugzilla.wikimedia.org/69099) (owner: 1001tonythomas) [11:18:26] (03CR) 10Krinkle: Redirect on all template calls (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152817 (https://bugzilla.wikimedia.org/69217) (owner: 10MarkTraceur) [11:20:19] (03PS10) 1001tonythomas: Fixed various issues with the BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153016 (https://bugzilla.wikimedia.org/69099) [11:20:21] (03CR) 10jenkins-bot: [V: 04-1] Fixed various issues with the BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153016 (https://bugzilla.wikimedia.org/69099) (owner: 1001tonythomas) [11:22:43] (03CR) 10Jforrester: [C: 032] Fix MassMessage::getMessengerUser() after Password API changes [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/151570 (https://bugzilla.wikimedia.org/68843) (owner: 10Legoktm) [11:22:51] (03PS11) 1001tonythomas: Fixed various issues with the BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153016 (https://bugzilla.wikimedia.org/69099) [11:22:53] (03CR) 10jenkins-bot: [V: 04-1] Fixed various issues with the BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153016 (https://bugzilla.wikimedia.org/69099) (owner: 1001tonythomas) [11:22:55] (03Merged) 10jenkins-bot: Fix MassMessage::getMessengerUser() after Password API changes [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/151570 (https://bugzilla.wikimedia.org/68843) (owner: 10Legoktm) [11:23:25] (03CR) 10Jforrester: [C: 04-1] "Don't merge 'til other branch is pulled in, per Lego." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/98469 (owner: 10Legoktm) [11:25:17] (03PS12) 1001tonythomas: Fixed various issues with the BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153016 (https://bugzilla.wikimedia.org/69099) [11:25:21] (03CR) 10Jforrester: [C: 031] "Seems sane but someone from Mobile Apps should merge." [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/152838 (owner: 10Legoktm) [11:26:01] (03CR) 10Jforrester: [C: 032] Add $query parameter to OutputPage::addBacklinkSubtitle [core] - 10https://gerrit.wikimedia.org/r/152223 (owner: 10Legoktm) [11:27:45] (03CR) 10Jforrester: [C: 04-1] JobRunner: Use Config instead of globals (031 comment) [core] - 10https://gerrit.wikimedia.org/r/152821 (owner: 10Legoktm) [11:28:35] (03CR) 10Jforrester: [C: 031] "Looks sane, but UW team should test and confirm they're happy." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153040 (owner: 10Legoktm) [11:29:10] (03Merged) 10jenkins-bot: Add $query parameter to OutputPage::addBacklinkSubtitle [core] - 10https://gerrit.wikimedia.org/r/152223 (owner: 10Legoktm) [11:30:04] Is UW team a thing? [11:30:55] (03PS1) 10Legoktm: Fix MassMessage::getMessengerUser() after Password API changes [extensions/MassMessage] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/153042 (https://bugzilla.wikimedia.org/68843) [11:31:52] Nemo_bis: UW == UploadWizard? If so it "belongs" to the multimedia team. [11:32:21] Nemo_bis: Yeah, not all of Multimedia work on UW and vice versa. [11:37:08] 3MediaWiki extensions / 3CodeEditor: Add Lua and JS code completion for MediaWiki libraries - 10https://bugzilla.wikimedia.org/63256 (10Ricordisamoa) [11:39:10] (03CR) 10Ori.livneh: [C: 032] "Wow, fantastic. Thanks so much." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/153037 (owner: 10Legoktm) [11:40:23] (03CR) 10TTO: "Ping! The bug is marked critical, as it seems to be causing copyright issues re fair use." [core] - 10https://gerrit.wikimedia.org/r/150511 (https://bugzilla.wikimedia.org/68802) (owner: 10TTO) [11:40:46] (03Merged) 10jenkins-bot: Extend JSONContent from core [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/153037 (owner: 10Legoktm) [11:41:31] (03CR) 10Ori.livneh: "Looks good, but per discussion let's provision this by default unless there is a concrete reason not to" [vagrant] - 10https://gerrit.wikimedia.org/r/149243 (https://bugzilla.wikimedia.org/67517) (owner: 10BryanDavis) [11:42:17] (03CR) 10Ori.livneh: [C: 032] Fix undefined values for wikidata config [vagrant] - 10https://gerrit.wikimedia.org/r/153036 (owner: 10BryanDavis) [11:42:22] (03Merged) 10jenkins-bot: Fix undefined values for wikidata config [vagrant] - 10https://gerrit.wikimedia.org/r/153036 (owner: 10BryanDavis) [11:42:28] (03PS4) 10Robert Vogel: BS223: ContextMenu [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151625 (owner: 10Tweichart) [11:43:36] (03CR) 10Ori.livneh: [C: 032 V: 032] correct typographical errors in privacy.html [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153012 (owner: 10Microchip08) [11:44:56] 3Wikimedia / 3Interwiki links: Copy across/symlink interwiki.cdb to new testwiki HHVM server - 10https://bugzilla.wikimedia.org/69332 (10This, that and the other (TTO)) 3NEW p:3Unprio s:3normal a:3Ori Livneh Interwiki links aren't working on testwiki. My guess is that interwiki.cdb is missing. [11:45:22] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MetaDescriptionTag] - 10https://gerrit.wikimedia.org/r/152480 (owner: 10Hashar) [11:45:46] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MobileSections] - 10https://gerrit.wikimedia.org/r/152483 (owner: 10Hashar) [11:45:55] (03CR) 10Paladox: "Hi the images came from https://bugzilla.wikimedia.org/attachment.cgi?id=15497 this and https://bugzilla.wikimedia.org/attachment.cgi?id=1" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [11:46:23] 3MediaWiki extensions / 3CodeEditor: Match a newline in the code is not possible - 10https://bugzilla.wikimedia.org/68360 (10Ricordisamoa) 5UNCO>3NEW [11:46:39] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MultiAudioVideo] - 10https://gerrit.wikimedia.org/r/152490 (owner: 10Hashar) [11:47:42] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Poll] - 10https://gerrit.wikimedia.org/r/152545 (owner: 10Hashar) [11:48:03] (03CR) 10Anomie: [C: 032] "Not after Wikimania yet. ;) Tuesday, maybe Wednesday." [core] - 10https://gerrit.wikimedia.org/r/150511 (https://bugzilla.wikimedia.org/68802) (owner: 10TTO) [11:48:05] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/152546 [11:48:43] (03PS5) 10Robert Vogel: ContextMenu (NEW) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151625 (owner: 10Tweichart) [11:49:01] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Polyglot] - 10https://gerrit.wikimedia.org/r/152547 (owner: 10Hashar) [11:49:19] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PopupPages] - 10https://gerrit.wikimedia.org/r/152548 (owner: 10Hashar) [11:49:38] 3MediaWiki / 3JavaScript: JavaScript included with Mediawiki is served without license information - 10https://bugzilla.wikimedia.org/36866#c14 (10Benjamin Mako Hill) I'm going to raise this issue again after a talk by Luis Villa and others at Wikimania about problems with missing license information on Medi... [11:49:45] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/RandomInCategory] - 10https://gerrit.wikimedia.org/r/152574 (owner: 10Hashar) [11:50:05] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/RandomUsersWithAvatars] - 10https://gerrit.wikimedia.org/r/152575 (owner: 10Hashar) [11:50:19] (03CR) 10PleaseStand: "This won't work as you expected it to: the created instance will always be a JSONContent and not a subclass. new static() (yes, the featur" [core] - 10https://gerrit.wikimedia.org/r/153039 (owner: 10Legoktm) [11:50:26] (03CR) 10Aklapper: "So if you manage to read the "Attachments" table in that bug report, you might found out who created them, and properly attribute them." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [11:51:09] (03Merged) 10jenkins-bot: Don't include images/categories when behind a local interwiki prefix [core] - 10https://gerrit.wikimedia.org/r/150511 (https://bugzilla.wikimedia.org/68802) (owner: 10TTO) [11:53:53] (03PS11) 10Chad: Remove hitcounters and associated code [core] - 10https://gerrit.wikimedia.org/r/150699 [11:54:14] (03CR) 10Chad: "PS11 adds release notes and the RFC link back to the commit summary." [core] - 10https://gerrit.wikimedia.org/r/150699 (owner: 10Chad) [11:54:47] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VisualWiki] - 10https://gerrit.wikimedia.org/r/152681 (owner: 10Hashar) [11:54:55] 3Wikimedia / 3General/Unknown: Undeploy Tor on the cluster - 10https://bugzilla.wikimedia.org/69333 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3enhanc a:3None We're currently by default blocking Tor (bar users with exemption). This generally goes against our openness [11:55:21] (03PS1) 10Umherirrender: Set page_latest for ChangesListTests [core] - 10https://gerrit.wikimedia.org/r/153051 [11:58:28] (03PS8) 10BryanDavis: Allow Flickr uploads in uploadwizard role [vagrant] - 10https://gerrit.wikimedia.org/r/148505 (owner: 10Neilk) [11:58:38] (03CR) 10PleaseStand: Html::closeElement: Don't omit closing tags. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/152778 (https://bugzilla.wikimedia.org/52210) (owner: 10Mattflaschen) [11:59:23] (03PS9) 10BryanDavis: Allow Flickr uploads in uploadwizard role [vagrant] - 10https://gerrit.wikimedia.org/r/148505 (owner: 10Neilk) [11:59:38] (03CR) 10BryanDavis: [C: 032] Allow Flickr uploads in uploadwizard role [vagrant] - 10https://gerrit.wikimedia.org/r/148505 (owner: 10Neilk) [11:59:43] (03Merged) 10jenkins-bot: Allow Flickr uploads in uploadwizard role [vagrant] - 10https://gerrit.wikimedia.org/r/148505 (owner: 10Neilk) [12:00:08] (03CR) 10TTO: "Oh, I actually didn't read "Ping me after Wikimania if this is still pending"! Sorry for poking you needlessly." [core] - 10https://gerrit.wikimedia.org/r/150511 (https://bugzilla.wikimedia.org/68802) (owner: 10TTO) [12:01:20] (03CR) 10PleaseStand: Html::closeElement: Don't omit closing tags. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/152778 (https://bugzilla.wikimedia.org/52210) (owner: 10Mattflaschen) [12:04:53] 3Wikimedia / 3General/Unknown: Undeploy TorBlock extension from the cluster - 10https://bugzilla.wikimedia.org/69333 (10Kunal Mehta (Legoktm)) [12:09:00] (03CR) 10Umherirrender: "It is failing on my machine, that's why have found this patch set. But can also depend on other things, so maybe this is not the root caus" [core] - 10https://gerrit.wikimedia.org/r/148846 (owner: 10Legoktm) [12:15:50] (03CR) 10Umherirrender: [C: 031] Never display empty sections on Special:Version [core] - 10https://gerrit.wikimedia.org/r/152991 (owner: 10Bartosz Dziewoński) [12:15:53] 3Wikimedia / 3General/Unknown: Undeploy TorBlock extension from the cluster - 10https://bugzilla.wikimedia.org/69333#c1 (10James Forrester) I'm reasonably sure this is a WONTFIX unless there's significant demonstrable countermeasures… [12:16:38] (03PS1) 10Tarrow: Split SkinFallback and SkinfallbackTemplate [core] - 10https://gerrit.wikimedia.org/r/153055 [12:17:09] (03PS2) 10Addshore: Split SkinFallback and SkinfallbackTemplate [core] - 10https://gerrit.wikimedia.org/r/153055 (owner: 10Tarrow) [12:18:23] 3Wikimedia / 3General/Unknown: Undeploy TorBlock extension from the cluster - 10https://bugzilla.wikimedia.org/69333#c2 (10Erik Moeller) Yeah, we need a better method/protocol to exempt users, but undeploying the current solution to prevent abuse from Tor users is unlikely to be the answer. [12:21:23] (03CR) 10Addshore: [C: 032] Split SkinFallback and SkinfallbackTemplate [core] - 10https://gerrit.wikimedia.org/r/153055 (owner: 10Tarrow) [12:23:48] (03PS1) 10Tarrow: Remove unreachable return in ChangesList.php [core] - 10https://gerrit.wikimedia.org/r/153057 [12:23:56] (03Merged) 10jenkins-bot: Split SkinFallback and SkinfallbackTemplate [core] - 10https://gerrit.wikimedia.org/r/153055 (owner: 10Tarrow) [12:25:35] (03PS2) 10Addshore: Remove unreachable return in ChangesList.php [core] - 10https://gerrit.wikimedia.org/r/153057 (owner: 10Tarrow) [12:32:19] bd808: test my packages patch damnit :P [12:32:42] ori: we should get a sandwich and then I will [12:32:48] One to share? [12:33:07] Yes Reedy and you can have the cookie [12:33:10] (03PS2) 10Ori.livneh: hiera: Rename "realm" to "environment" [vagrant] - 10https://gerrit.wikimedia.org/r/152857 (owner: 10BryanDavis) [12:33:16] Wait I want the cookie [12:33:32] * bd808 licks the cookie [12:33:39] (03CR) 10Ori.livneh: [C: 032] hiera: Rename "realm" to "environment" [vagrant] - 10https://gerrit.wikimedia.org/r/152857 (owner: 10BryanDavis) [12:33:44] (03Merged) 10jenkins-bot: hiera: Rename "realm" to "environment" [vagrant] - 10https://gerrit.wikimedia.org/r/152857 (owner: 10BryanDavis) [12:33:53] i want the cookie [12:34:04] (03PS1) 10Tarrow: Correct variable types in phpdoc [core] - 10https://gerrit.wikimedia.org/r/153059 [12:34:27] (03CR) 10Addshore: [C: 032] Remove unreachable return in ChangesList.php [core] - 10https://gerrit.wikimedia.org/r/153057 (owner: 10Tarrow) [12:34:49] (03CR) 10Addshore: [C: 032] Correct variable types in phpdoc [core] - 10https://gerrit.wikimedia.org/r/153059 (owner: 10Tarrow) [12:36:55] (03Merged) 10jenkins-bot: Remove unreachable return in ChangesList.php [core] - 10https://gerrit.wikimedia.org/r/153057 (owner: 10Tarrow) [12:37:52] (03Merged) 10jenkins-bot: Correct variable types in phpdoc [core] - 10https://gerrit.wikimedia.org/r/153059 (owner: 10Tarrow) [12:40:08] 3MediaWiki extensions / 3Translate: Splitting should be done after alignment at Special:PageMigration? - 10https://bugzilla.wikimedia.org/69310#c2 (10Pratik Lahoti) To reproduce: 1. Go to Special:PageMigration 2. Enter Manual:LocalSetting.php in title field and ru in language code field. 3. Press the Import... [12:40:33] (03PS2) 10Umherirrender: Fix backlink for RevertAction [core] - 10https://gerrit.wikimedia.org/r/151448 [12:45:46] (03CR) 10Umherirrender: "Patch Set 2: Rebased" [core] - 10https://gerrit.wikimedia.org/r/151448 (owner: 10Umherirrender) [12:53:53] 3MediaWiki extensions / 3UniversalLanguageSelector: browsertest: failures as of 2014-02-11 (tracking) - 10https://bugzilla.wikimedia.org/61216 (10Željko Filipin) [12:54:24] 3MediaWiki extensions / 3UniversalLanguageSelector: Discarding live preview of content font broken - 10https://bugzilla.wikimedia.org/56081 (10Željko Filipin) [12:54:39] 3MediaWiki-Vagrant: Enabling visualeditor does not result in usable visualeditor - 10https://bugzilla.wikimedia.org/60905 (10Željko Filipin) [12:54:39] 3MediaWiki extensions / 3UniversalLanguageSelector: browser tests must normalize font-family - 10https://bugzilla.wikimedia.org/57101 (10Željko Filipin) [12:54:46] (03CR) 10Ori.livneh: "looks good but needs a rebase" [vagrant] - 10https://gerrit.wikimedia.org/r/147685 (owner: 10Dduvall) [12:58:23] 3MediaWiki / 3General/Unknown: Code quality issues (tracking) - 10https://bugzilla.wikimedia.org/700 (10Kunal Mehta (Legoktm)) [12:59:13] (03CR) 10Reedy: [C: 04-1] Cleaned up workflow for fetching nodes to use Status. (031 comment) [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/62026 (owner: 10Parent5446) [12:59:23] 3MediaWiki extensions / 3Translate: Recover gracefully from session expiration - 10https://bugzilla.wikimedia.org/69314#c9 (10Niklas Laxström) It helps me to have a concise plan and a goal. It's really just a one bug with multiple non-overlapping solutions to address it. [12:59:53] 3Wikimedia / 3Media storage: Swift outage caused a bunch of moved files to be "inconsistent" and "missing" - 10https://bugzilla.wikimedia.org/69311#c3 (10Pratyya Ghosh) The link Bawolff gave is for en.wikipedia.org. The exact link is https://commons.wikimedia.org/wiki/User:Pratyya_Ghosh/What_Happened_to_These [13:03:08] 3Wikimedia / 3Site requests: Change upload settings on fa.wikipedia - 10https://bugzilla.wikimedia.org/69171 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [13:04:38] 3Wikimedia / 3General/Unknown: allow users to edit via Tor wile still being able to fight abuse - 10https://bugzilla.wikimedia.org/69333#c3 (10Jan Zerebecki) A start in the right direction would be allowing existing account holders to edit via Tor while being authenticated (i.e. removing the need for the blo... [13:05:24] 3Wikimedia / 3Site requests: Change upload settings on fa.wikipedia - 10https://bugzilla.wikimedia.org/69171 (10Calak) a:3Calak [13:07:21] !class ManualLogEntry [13:07:21] See https://doc.wikimedia.org/mediawiki-core/master/php/html/classManualLogEntry.html [13:08:38] 3Wikimedia / 3Site requests: Run migrateAccount.php without --safe or --auto - 10https://bugzilla.wikimedia.org/69291#c2 (10Nemo) (In reply to Stefan2 from comment #1) > Will bug 68069 be unnecessary if the "--auto" flag is used? Probably. Which is why it's out of scope for this report. [13:11:28] (03CR) 10Vogone: [C: 04-1] "I have to agree with MF-Warburg here. Unless there is a pressing need for such a change, it would be unnecessary to implement." [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/112022 (owner: 10Ebe123) [13:16:06] (03PS16) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [13:16:23] 3Wikimedia / 3General/Unknown: allow users to edit via Tor wile still being able to fight abuse - 10https://bugzilla.wikimedia.org/69333 (10Andre Klapper) p:5Unprio>3Lowest [13:16:38] (03CR) 10Paladox: "Oh just found out who created the image it was created by user PRO." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [13:16:53] 3Wikimedia / 3General/Unknown: allow users to edit via Tor wile still being able to fight abuse - 10https://bugzilla.wikimedia.org/69333 (10Kunal Mehta (Legoktm)) p:5Lowest>3High [13:16:55] (03PS17) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [13:17:38] (03PS1) 10Legoktm: Use new static instead of new self [core] - 10https://gerrit.wikimedia.org/r/153065 [13:18:07] (03PS2) 10Reedy: Use new static instead of new self [core] - 10https://gerrit.wikimedia.org/r/153065 (owner: 10Legoktm) [13:18:12] (03CR) 10Reedy: [C: 032] Use new static instead of new self [core] - 10https://gerrit.wikimedia.org/r/153065 (owner: 10Legoktm) [13:18:31] (03CR) 10Microchip08: "You should change the data in locales/en.html and not the build directory." [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153026 (owner: 10Chmarkine) [13:18:40] (03CR) 10Legoktm: "Ah, didn't know that. Thanks, fixed in I79e4a987636509515df044da7a6951d3e4b4f824" [core] - 10https://gerrit.wikimedia.org/r/153039 (owner: 10Legoktm) [13:18:52] legoktm: Krenair: http://pastebin.com/feynufvz look about right? (well, ignore the language value) [13:18:54] (03PS12) 10Paladox: WikiEditor: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 [13:19:09] (03PS9) 10Paladox: Update Moment.js from 2.7.0 to 2.8.1 [core] - 10https://gerrit.wikimedia.org/r/151630 [13:19:13] yeah looks reasonable [13:19:25] 3Wikimedia / 3General/Unknown: VIPS scaled thumbnails don't have a comment with a link to the file description page - 10https://bugzilla.wikimedia.org/69336 (10Derk-Jan Hartman) 3NEW p:3Unprio s:3normal a:3None As part of bug 28135 we added the option to set the comment of a thumbnail with the file d... [13:21:26] (03CR) 10jenkins-bot: [V: 04-1] Use new static instead of new self [core] - 10https://gerrit.wikimedia.org/r/153065 (owner: 10Legoktm) [13:21:29] (03Abandoned) 10Ebe123: Show warning when moving a page to a different test wiki [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/112022 (owner: 10Ebe123) [13:21:54] 3Wikimedia / 3Extension setup: Review and deploy VipsScaler extension - 10https://bugzilla.wikimedia.org/28135#c40 (10Derk-Jan Hartman) Bug 69336 It seems we never added the 'set comment' option for the configuration ? [13:22:08] 3MediaWiki extensions / 3Translate: Recover gracefully from session expiration - 10https://bugzilla.wikimedia.org/69314#c10 (10James Forrester) Umm. Bug 48657 is about MediaWiki core's editing ability, and has nothing to do with the Translate extension. I'm restoring it as a blocker to this. [13:22:14] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/153065 (owner: 10Legoktm) [13:22:23] 3MediaWiki / 3Page editing: Warn user that they're now logged out when they originally weren't - 10https://bugzilla.wikimedia.org/48657#c3 (10James Forrester) 5RESO/DUP>3REOP Not remotely a duplicate of a bug in an extension. [13:22:39] 3MediaWiki / 3Page editing: Warn user that they're now logged out when they originally weren't - 10https://bugzilla.wikimedia.org/48657 (10James Forrester) 5REOP>3NEW [13:22:39] 3MediaWiki extensions / 3Translate: Recover gracefully from session expiration - 10https://bugzilla.wikimedia.org/69314 (10James Forrester) [13:24:10] 3MediaWiki-Vagrant: Add a vipsscaler role to vagrant - 10https://bugzilla.wikimedia.org/69337 (10Derk-Jan Hartman) 3NEW p:3Unprio s:3normal a:3Ori Livneh Because that's the scaling tech we use for a lot the thumbnails. [13:27:47] So if I have a string which is a sub(sub)domain ... (minus the .foo.com) would I have to do a regex to split the lang.foo.bar.com bit up (ie, get the lang) [13:29:54] Lcawte: explode( '.', $domain ) ? [13:35:37] (03PS35) 10Paladox: Update jquery.chosen folder and files [core] - 10https://gerrit.wikimedia.org/r/139699 (https://bugzilla.wikimedia.org/69065) [13:35:53] legoktm: Ok, so I'll pull the php.net page on that, and if I don't get it, I'll pester you when the state of the wiki talk is over :P [13:36:01] :P [13:37:23] 3MediaWiki / 3General/Unknown: Package basic skins with the MediaWiki tarball 1.24 and later - 10https://bugzilla.wikimedia.org/69248#c1 (10Mark A. Hershberger) Tools are here: https://git.wikimedia.org/tree/mediawiki%2Ftools%2Frelease/HEAD/make-release Ideally, we should move the the extensions so they are... [13:40:45] 3MediaWiki extensions / 3Translate: Add parameterless GENDER as insertable - 10https://bugzilla.wikimedia.org/69306 (10Sam Reed (reedy)) s:5normal>3enhanc [13:40:45] 3Mathoid / 3General/Unknown: Initial Mathoid deployment - 10https://bugzilla.wikimedia.org/69298 (10Sam Reed (reedy)) s:5normal>3enhanc [13:40:46] 3MediaWiki-Vagrant: Add a vipsscaler role to vagrant - 10https://bugzilla.wikimedia.org/69337 (10Sam Reed (reedy)) s:5normal>3enhanc [13:40:47] 3MediaWiki extensions / 3Gadgets: Convert Gadgets 2.0 namespaces to use ContentHandler - 10https://bugzilla.wikimedia.org/69318 (10Sam Reed (reedy)) s:5normal>3enhanc [13:40:53] 3Wikimedia / 3Interwiki links: Copy across/symlink interwiki.cdb to new testwiki HHVM server - 10https://bugzilla.wikimedia.org/69332 (10Sam Reed (reedy)) s:5normal>3enhanc [13:43:01] ori: do you know what are the pre-requisites to get access to executing mw-grep on WMF wikis? [13:43:30] you need shell access [13:43:33] which requires an nda [13:43:43] I now have global editinterface permission but sometimes it is useful to know where/how certaing codes are being used [13:44:58] is nda docomented somewhere? [13:45:07] not really [13:45:22] shell access isn't given out easily [13:45:31] Someone should write a web clone of mw-grep on tools [13:45:45] yeah that would be great [13:46:04] maybe make it use OAUTH as http://quarry.wmflabs.org/ does? [13:46:24] 3MediaWiki / 3General/Unknown: Convert things to use Config classes instead of globals (tracking) - 10https://bugzilla.wikimedia.org/69084 (10Kunal Mehta (Legoktm)) [13:46:25] 3MediaWiki / 3General/Unknown: Migrate Setup.php to use Config instead of globals - 10https://bugzilla.wikimedia.org/69338 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3enhanc a:3None At the architecture summit, Ori had asked us not to change any of the initialization code until after the hhvm migratio... [13:46:31] I'm not sure it needs OAUTH [13:46:38] 3MediaWiki / 3General/Unknown: Migrate Setup.php to use Config instead of globals - 10https://bugzilla.wikimedia.org/69338 (10Kunal Mehta (Legoktm)) p:5Unprio>3Lowest [13:46:39] but it could [13:47:02] helderwiki: the eventual plan is to replicate CirrusSearch to labs and that's what mwgrep uses [13:47:07] but for now you can just poke me [13:47:14] or Reedy :P [13:47:49] legoktm: so... can I provide you a list of strings which I think are being used as global JS variables on Wikisources? [13:47:53] 3MediaWiki extensions / 3CentralAuth: GlobalUserRights defaults to Meta but does not work unless changed to a different wiki - 10https://bugzilla.wikimedia.org/15651#c1 (10Andre Klapper) Meh, getting "Your account does not have permission to assign user rights." with my limited rights. I assume this is sti... [13:48:08] than I can make sure they are/are not globals after checking the usage [13:48:37] helderwiki: we should build a web interface for it that is open to all users ideally [13:48:46] it shouldn't be hard; it uses the same backend as the search feature [13:49:16] ori: RESOLVED DUPE [13:49:16] [14:47:03] helderwiki: the eventual plan is to replicate CirrusSearch to labs and that's what mwgrep uses [13:49:20] fail [13:49:22] can you file a bug and CC nik everett (manybubbles) and chad horohoe? [13:49:27] [14:45:31] Someone should write a web clone of mw-grep on tools [13:49:41] ori: there already is a bug I think. [13:49:42] it doesn't need to be labs/tools based at all [13:49:49] sure [13:50:11] * ori tackles Reedy [13:50:31] https://bugzilla.wikimedia.org/show_bug.cgi?id=43652 [13:50:38] but that's marked as fixed... [13:50:54] yeah that is the bug I remember about this [13:51:38] 3MediaWiki extensions / 3CirrusSearch: Implement ability to search wikitext of current Wikimedia wiki pages with regular expressions (regex) - 10https://bugzilla.wikimedia.org/43652 (10Kunal Mehta (Legoktm)) [13:54:55] 3Wikimedia / 3Bugzilla: Create "MediaWiki" --> "Configuration" component - 10https://bugzilla.wikimedia.org/69339 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Description: Issues related to configuration options and the Config interface. Default CC can be me for now. I've also cc'd a f... [13:57:53] 3MediaWiki / 3Parser: File links with local project prefix cause images to be transcluded - 10https://bugzilla.wikimedia.org/68802#c8 (10Bartosz Dziewoński) 5PATC>3RESO/FIX Should be fixed. Please verify on beta labs. [13:58:38] 3Wikimedia / 3Bugzilla: Create "MediaWiki" --> "Configuration" component - 10https://bugzilla.wikimedia.org/69339#c1 (10Chad H.) 5NEW>3RESO/FIX Done. [13:58:50] * helderwiki wonders why Lucene always says "An error has occurred while searching: HTTP request timed out." when I search on js pages... =/ [13:59:19] <^d> because lsearchd is dying :( [13:59:26] <^d> It doesn't like punctuation, among other things. [13:59:40] but Cirrus doesn't works well with JS pages either :( [13:59:46] It doesn't like working [14:00:00] <^d> helderwiki: That's a different bug :\ [14:00:06] <^d> Unrelated, completely. [14:00:07] I overheard something about ElasticSearch replicas on labs but nothing clear [14:00:18] <^d> Nemo_bis: Yes, on the roadmap of eventually :) [14:00:52] legoktm: language codes aren't standard lengths, and I /think/ there are one or two wikis that have subsubdomains that aren't language codes. [14:01:21] Jack informs me we store the language codes in the DB so I'm going to grab that I think. [14:01:50] https://bugzilla.wikimedia.org/show_bug.cgi?id=68920 [14:01:50] https://bugzilla.wikimedia.org/show_bug.cgi?id=63861 [14:02:26] (03PS1) 10Wctaiwan: Use addBacklinkSubtitle [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/153068 [14:03:34] (03CR) 10Bartosz Dziewoński: "I know, but that's not relevant to my point. The rules are needed, but let's keep them in one place (or not 3 places at least). This als" [core] - 10https://gerrit.wikimedia.org/r/152785 (owner: 10Gerrit Patch Uploader) [14:05:02] Actually, probably not a great idea if there's a easy-ish way to do it from the subdomain, since the language /might/ change over time. And it's not hugely relevant in the older wikis iirc, since most don't have the parameter... I'll qqx it or something. [14:08:38] (03CR) 10Legoktm: [C: 032] Use addBacklinkSubtitle [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/153068 (owner: 10Wctaiwan) [14:08:46] (03Merged) 10jenkins-bot: Use addBacklinkSubtitle [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/153068 (owner: 10Wctaiwan) [14:09:38] 3MediaWiki / 3Configuration: Convert things to use Config classes instead of globals (tracking) - 10https://bugzilla.wikimedia.org/69084 (10Kunal Mehta (Legoktm)) [14:12:07] (03PS6) 10Chmarkine: Use protocol relative URLs for some links on Transparency Report pages [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153026 [14:12:17] legoktm: Would I do the explode without a limit and a delimiter of '.' ... then does it return false if the delimiter isn't found? [14:12:22] Or soemthing like that. [14:12:26] I don't know [14:13:05] try it? :) [14:14:17] I bet it returns the entire string unmodified [14:14:58] yeah, see example 2 on http://php.net/manual/en/function.explode.php [14:16:44] It appears to return an array on echo, array[0] is the first part, which I guess I could run against the list of language codes? [14:17:52] Speaking of which, is there a isValidLanguage or something function I could use for this? [14:18:20] (03Draft3) 10Legoktm: Introduce SkinFactory [core] - 10https://gerrit.wikimedia.org/r/153060 [14:18:35] Language::isValidCode() [14:19:25] Thank you Reedy :) [14:21:36] (03CR) 10Bartosz Dziewoński: "Yeah, that's probably a good idea." [core] - 10https://gerrit.wikimedia.org/r/153002 (https://bugzilla.wikimedia.org/69285) (owner: 10Bartosz Dziewoński) [14:21:52] (03CR) 10Prtksxna: [C: 04-1] Use protocol relative URLs for some links on Transparency Report pages (032 comments) [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153026 (owner: 10Chmarkine) [14:22:25] bawolff_: ping [14:23:37] (03PS1) 10Legoktm: More getLang() --> getLanguage() [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153073 [14:24:27] (03PS2) 10Legoktm: More getLang() --> getLanguage() [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153073 [14:24:35] <^d> Heh, "This is a famous monkey. To see an automatically generated list of other famous monkeys click here." [14:24:42] <^d> Old BZ quip, but surprisingly relevant :p [14:24:55] (03PS1) 10Legoktm: Remove outdated $wgVersion contstraint [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153074 [14:26:53] 3MediaWiki extensions / 3GoogleLogin: Use Config object instead of globals in GoogleLogin - 10https://bugzilla.wikimedia.org/69086 (10Kunal Mehta (Legoktm)) [14:27:08] 3MediaWiki / 3Configuration: Migrate Setup.php to use Config instead of globals - 10https://bugzilla.wikimedia.org/69338 (10Kunal Mehta (Legoktm)) [14:27:08] (03CR) 10Alex Monk: [C: 032] More getLang() --> getLanguage() [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153073 (owner: 10Legoktm) [14:27:13] (03Merged) 10jenkins-bot: More getLang() --> getLanguage() [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153073 (owner: 10Legoktm) [14:29:13] elseif or else if *hides* [14:29:15] (03PS2) 10Bartosz Dziewoński: [WIP] Add utility methods for language fallback chain handling in JavaScript [core] - 10https://gerrit.wikimedia.org/r/153002 (https://bugzilla.wikimedia.org/69285) [14:29:17] (03PS1) 10Bartosz Dziewoński: Expose language fallback chain in JavaScript [core] - 10https://gerrit.wikimedia.org/r/153075 (https://bugzilla.wikimedia.org/69285) [14:29:26] 3Wikimedia / 3Bugzilla: Add legoktm and Krenair as default cc's for Gadgets extension - 10https://bugzilla.wikimedia.org/69343 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None plz thx [14:29:28] ^d: [14:29:29] ^ [14:29:31] (03CR) 10Bartosz Dziewoński: "Split off the trivial part to https://gerrit.wikimedia.org/r/153075" [core] - 10https://gerrit.wikimedia.org/r/153002 (https://bugzilla.wikimedia.org/69285) (owner: 10Bartosz Dziewoński) [14:29:54] (03PS7) 10Prtksxna: Use protocol relative URLs for some links on Transparency Report pages [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153026 (owner: 10Chmarkine) [14:30:16] * Lcawte assumes elseif [14:31:24] 3Wikimedia / 3Bugzilla: Add legoktm and Krenair as default cc's for Gadgets extension - 10https://bugzilla.wikimedia.org/69343#c1 (10Chad H.) 5NEW>3RESO/FIX Done. [14:31:24] 3MediaWiki extensions / 3Gadgets: Implement Gadgets 2.0 (tracking) - 10https://bugzilla.wikimedia.org/29272 (10Kunal Mehta (Legoktm)) [14:31:58] Please tell me that you can upload files in a phpunit test and have it work on Jenkins, and I just don't know ho [14:32:00] w [14:32:34] probably [14:32:41] aren;t there are test that do it? [14:32:43] This code looks somewhat sane :O [14:32:45] Because I'm becoming concerned that isn't actually possible [14:32:47] aren;t there any* [14:32:53] 3Wikimedia / 3Bugzilla: chase's test bug - 10https://bugzilla.wikimedia.org/68403#c2 (10Chad H.) 5NEW>3RESO/WOR Testing works for me! [14:32:53] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add utility methods for language fallback chain handling in JavaScript [core] - 10https://gerrit.wikimedia.org/r/153002 (https://bugzilla.wikimedia.org/69285) (owner: 10Bartosz Dziewoński) [14:33:06] (03CR) 10jenkins-bot: [V: 04-1] Expose language fallback chain in JavaScript [core] - 10https://gerrit.wikimedia.org/r/153075 (https://bugzilla.wikimedia.org/69285) (owner: 10Bartosz Dziewoński) [14:33:42] MatmaRex: no instances of an upload() method being called [14:35:27] (03PS1) 10Bartosz Dziewoński: Test commit [core] - 10https://gerrit.wikimedia.org/r/153076 [14:36:08] 3Wikimedia / 3Bugzilla: Bugzilla's default skin needs typography refresh - 10https://bugzilla.wikimedia.org/63776 (10Chad H.) [14:38:25] 3MediaWiki extensions / 3Translate: "Translate to" dropdown doesn't work; can't select language to translate - 10https://bugzilla.wikimedia.org/69346 (10Quim Gil) 3NEW p:3Unprio s:3major a:3None http://orain.org wiki farm has the Translate version installed, and it used to work as usual. But now, all... [14:41:15] legoktm: Can I have my select $vars stored as seperate variables without having to do two selects? [14:41:40] eg, have log_id as $logId and params $logParams [14:42:01] (03PS1) 10Legoktm: Add empty .jshintrc [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153077 [14:42:06] (03CR) 10jenkins-bot: [V: 04-1] Add empty .jshintrc [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153077 (owner: 10Legoktm) [14:43:21] (03PS2) 10Legoktm: Add empty .jshintrc [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153077 [14:43:26] (03CR) 10jenkins-bot: [V: 04-1] Add empty .jshintrc [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153077 (owner: 10Legoktm) [14:45:43] (03CR) 10Helder.wiki: "Is this because 1.19 is legacy LTS? Or something else?" [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153074 (owner: 10Legoktm) [14:46:14] (03PS3) 10Legoktm: Add core's .jshintrc [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153077 [14:46:19] (03CR) 10jenkins-bot: [V: 04-1] Add core's .jshintrc [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153077 (owner: 10Legoktm) [14:46:35] Lcawte: umm, $logid = $row->log_id ? [14:47:36] (03CR) 10Legoktm: "We won't be supporting anything other than 1.24 because we're going to start using the JSONContent, which was just added in." [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153074 (owner: 10Legoktm) [14:47:54] (03PS2) 10Bartosz Dziewoński: Test commit [core] - 10https://gerrit.wikimedia.org/r/153076 [14:47:57] legoktm: $row being the variable with the select in it or is it "magic" [14:48:07] er [14:48:26] $res = $dbr->select( ... ); foreach ( $res as $row ) { ... } [14:49:14] Ah [14:49:46] Jarry_1250: at idea lab [14:50:27] Jarry1250: --^ [14:50:50] (03CR) 10Alex Monk: [C: 032 V: 032] Add core's .jshintrc [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153077 (owner: 10Legoktm) [14:51:04] (03CR) 10jenkins-bot: [V: 04-1] Test commit [core] - 10https://gerrit.wikimedia.org/r/153076 (owner: 10Bartosz Dziewoński) [14:51:24] (03PS3) 10Bartosz Dziewoński: Make mediawiki.content.json.css not trigger JSDuck [core] - 10https://gerrit.wikimedia.org/r/153076 [14:53:24] (03CR) 10Helder.wiki: "Ok. Thanks for clarifying! :-)" [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153074 (owner: 10Legoktm) [14:53:52] how to debug an issue that can be reproduced on wikipedia but not wikibooks? [14:54:18] (03PS4) 10Bartosz Dziewoński: Make mediawiki.content.json.css not trigger JSDuck [core] - 10https://gerrit.wikimedia.org/r/153076 [14:54:24] (03CR) 10Alex Monk: "Why are we not just checking against 1.24 instead then?" [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153074 (owner: 10Legoktm) [14:54:49] (03CR) 10Bartosz Dziewoński: "Follow-up: https://gerrit.wikimedia.org/r/#/c/153076/ – you uncovered a CI bug: bug 69347." [core] - 10https://gerrit.wikimedia.org/r/152933 (owner: 10Legoktm) [14:54:59] (03PS1) 10Jforrester: Make into a built library, importing test infrastructure from previous repo [unicodejs] - 10https://gerrit.wikimedia.org/r/153078 [14:56:22] (03PS5) 10Bartosz Dziewoński: Make mediawiki.content.json.css not trigger JSDuck [core] - 10https://gerrit.wikimedia.org/r/153076 [14:56:31] !class DatabaseBase [14:56:31] See https://doc.wikimedia.org/mediawiki-core/master/php/html/classDatabaseBase.html [14:58:43] (03CR) 10Chmarkine: [C: 031] Use protocol relative URLs for some links on Transparency Report pages [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153026 (owner: 10Chmarkine) [14:59:10] 3Wikimedia / 3General/Unknown: invalid creates MWException on Wikipedia but not on Wikibooks - 10https://bugzilla.wikimedia.org/69348 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Both on production site and beta.wmflabs.org. Exception from line 77 of /srv/common-loc... [14:59:22] (03PS1) 10Bartosz Dziewoński: mediawiki.content.json.css: Don't use funny fonts [core] - 10https://gerrit.wikimedia.org/r/153079 [14:59:23] 3Wikimedia / 3Interwiki links: Copy across/symlink interwiki.cdb to new testwiki HHVM server - 10https://bugzilla.wikimedia.org/69332#c1 (10Ori Livneh) (In reply to This, that and the other (TTO) from comment #0) > Interwiki links aren't working on testwiki. My guess is that interwiki.cdb > is missing. Nope... [15:01:10] (03CR) 10Legoktm: [C: 032] Make mediawiki.content.json.css not trigger JSDuck [core] - 10https://gerrit.wikimedia.org/r/153076 (owner: 10Bartosz Dziewoński) [15:01:38] 3MediaWiki / 3General/Unknown: Provide all URL parameters for all RSS/Atom feeds consistently - 10https://bugzilla.wikimedia.org/13951#c2 (10Andre Klapper) For all three pages mentioned above on en.wp, passing the URL parameter ?namespace=1 set the dropdown correctly for me (Firefox 31). There are several d... [15:02:23] 3Wikimedia / 3General/Unknown: invalid creates MWException on Wikipedia but not on Wikibooks - 10https://bugzilla.wikimedia.org/69348#c1 (10Liangent) It's also observed that disabling tracking category 'broken-file-category' (setting it to '-' or an invalid title) workarounds... [15:02:40] (03PS2) 10Bartosz Dziewoński: mediawiki.content.json.css: Don't use funny fonts [core] - 10https://gerrit.wikimedia.org/r/153079 [15:03:11] (03CR) 10Legoktm: [C: 032] mediawiki.content.json.css: Don't use funny fonts [core] - 10https://gerrit.wikimedia.org/r/153079 (owner: 10Bartosz Dziewoński) [15:03:44] (03Merged) 10jenkins-bot: Make mediawiki.content.json.css not trigger JSDuck [core] - 10https://gerrit.wikimedia.org/r/153076 (owner: 10Bartosz Dziewoński) [15:06:24] (03Merged) 10jenkins-bot: mediawiki.content.json.css: Don't use funny fonts [core] - 10https://gerrit.wikimedia.org/r/153079 (owner: 10Bartosz Dziewoński) [15:06:45] (03PS1) 10Bartosz Dziewoński: Move Vector's hooks documentation to mediawiki/skins/Vector [core] - 10https://gerrit.wikimedia.org/r/153080 [15:08:00] (03CR) 10Dzahn: [C: 031] "+1 for the general idea, yandex.ru mailed us about this issue" [core] - 10https://gerrit.wikimedia.org/r/151221 (https://bugzilla.wikimedia.org/69026) (owner: 10MaxSem) [15:09:24] (03PS1) 10Bartosz Dziewoński: Move hooks.txt docs from mediawiki/core [skins/Vector] - 10https://gerrit.wikimedia.org/r/153082 [15:13:06] (03PS1) 10Legoktm: Add .jshintignore [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153083 [15:13:14] (03CR) 10jenkins-bot: [V: 04-1] Add .jshintignore [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153083 (owner: 10Legoktm) [15:13:35] (03PS4) 10Legoktm: Add core's .jshintrc [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153077 [15:13:40] (03CR) 10jenkins-bot: [V: 04-1] Add core's .jshintrc [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153077 (owner: 10Legoktm) [15:13:53] (03CR) 10Legoktm: [C: 032 V: 032] Add core's .jshintrc [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153077 (owner: 10Legoktm) [15:14:03] (03PS2) 10Legoktm: Add .jshintignore [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153083 [15:14:35] (03CR) 10Alex Monk: [C: 032] Add .jshintignore [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153083 (owner: 10Legoktm) [15:15:01] (03CR) 10Alex Monk: [V: 032] Add .jshintignore [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153083 (owner: 10Legoktm) [15:16:23] 3MediaWiki extensions / 3Gadgets: Gadgets 2.0 doesn't pass jshint - 10https://bugzilla.wikimedia.org/69344#c1 (10Kunal Mehta (Legoktm)) See [15:20:40] (03CR) 10Chad: "I can't even get the ancient shared upload stuff removed. Why this?" [core] - 10https://gerrit.wikimedia.org/r/150761 (owner: 10Withoutaname) [15:22:42] (03CR) 10Chad: "Unused probably isn't the right choice of words. They are used (since you're removing their usage :))" [core] - 10https://gerrit.wikimedia.org/r/151536 (owner: 10Withoutaname) [15:24:23] 3Wikimedia / 3Interwiki links: Copy across/symlink interwiki.cdb to new testwiki HHVM server - 10https://bugzilla.wikimedia.org/69332 (10Ori Livneh) 5PATC>3RESO/FIX [15:26:23] (03PS2) 10Bartosz Dziewoński: Expose language fallback chain in JavaScript [core] - 10https://gerrit.wikimedia.org/r/153075 (https://bugzilla.wikimedia.org/69285) [15:31:38] (03PS1) 10Anomie: Update token handling for core API change [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/153084 [15:31:42] (03CR) 10Chad: "Inline comments need clarification." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/151962 (owner: 10PleaseStand) [15:31:44] (03PS1) 10Anomie: Update token handling for core API change [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/153085 [15:31:47] (03PS1) 10Anomie: Update token handling for core API change [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/153086 [15:31:51] (03PS1) 10Anomie: Update token handling for core API change [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/153087 [15:31:55] (03PS1) 10Anomie: Update token handling for core API change [extensions/CongressLookup] - 10https://gerrit.wikimedia.org/r/153088 [15:32:01] (03PS1) 10Anomie: Update token handling for core API change [extensions/Contest] - 10https://gerrit.wikimedia.org/r/153090 [15:32:04] (03PS1) 10Anomie: Update token handling for core API change [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/153091 [15:32:13] (03PS1) 10Anomie: Update token handling for core API change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153092 [15:32:17] (03PS1) 10Anomie: Update token handling for core API change [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/153093 [15:32:21] (03PS1) 10Anomie: Update token handling for core API change [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/153094 [15:32:26] (03PS1) 10Anomie: Update token handling for core API change [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153095 [15:32:30] (03PS1) 10Anomie: Update token handling for core API change [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/153096 [15:32:34] (03PS1) 10Anomie: Update token handling for core API change [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/153097 [15:32:37] (03PS1) 10Anomie: Update token handling for core API change [extensions/MarkAsHelpful] - 10https://gerrit.wikimedia.org/r/153098 [15:32:41] (03PS1) 10Anomie: Update token handling for core API change [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/153099 [15:32:45] (03PS1) 10Anomie: Update token handling for core API change [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/153100 [15:32:49] (03PS1) 10Anomie: Update token handling for core API change [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/153101 [15:32:51] (03PS1) 10Anomie: Update token handling for core API change [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/153102 [15:32:55] (03PS1) 10Anomie: Update token handling for core API change [extensions/Ratings] - 10https://gerrit.wikimedia.org/r/153103 [15:32:58] (03PS1) 10Anomie: Update token handling for core API change [extensions/Survey] - 10https://gerrit.wikimedia.org/r/153104 [15:33:02] (03PS1) 10Anomie: Update token handling for core API change [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/153105 [15:33:07] (03PS1) 10Anomie: Update token handling for core API change [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/153106 [15:33:27] (03PS1) 10Anomie: API: Overhaul token handling [core] - 10https://gerrit.wikimedia.org/r/153110 [15:34:05] (03CR) 10Anomie: [C: 04-2] "-2 until depended changes are merged" [core] - 10https://gerrit.wikimedia.org/r/153110 (owner: 10Anomie) [15:47:16] (03CR) 10Addshore: [C: 04-1] Introduce SkinFactory (037 comments) [core] - 10https://gerrit.wikimedia.org/r/153060 (owner: 10Legoktm) [15:47:20] legoktm: ^^ [15:55:09] 3MediaWiki extensions / 3Translate: Special:AdvancedTranslate gets internal error - 10https://bugzilla.wikimedia.org/69094 (10Niklas Laxström) 5PATC>3RESO/FIX [15:58:51] (03PS1) 10Siebrand: Change right "vote" to "voteny" to prevent key conflicts in L10n [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/153114 [15:59:32] (03CR) 10Siebrand: [C: 032] Change right "vote" to "voteny" to prevent key conflicts in L10n [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/153114 (owner: 10Siebrand) [15:59:38] (03Merged) 10jenkins-bot: Change right "vote" to "voteny" to prevent key conflicts in L10n [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/153114 (owner: 10Siebrand) [16:06:46] (03CR) 10Mwjames: "This break ours tests with on MW master." [core] - 10https://gerrit.wikimedia.org/r/152243 (owner: 10Legoktm) [16:07:37] Debugging :( [16:09:49] <^d> ROANKATTOUW: WHY DID YOU DO THIS?!? [16:09:54] <^d> YOUR COMMIT SUMMARY WAS LESS THAN IDEAL [16:11:29] (03CR) 10JanZerebecki: [C: 04-1] "Those still have http: in it:" [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153026 (owner: 10Chmarkine) [16:11:34] lol [16:12:35] jzerebecki: At least they're being transparent [16:13:56] <^d> Do we even serve it over http? [16:14:00] <^d> Shouldn't they all be https? [16:14:23] You'll upset cometstyles [16:14:24] ^d: is https transparent towards the NSA? [16:14:24] 3Wikimedia / 3IRC: #central channel is down - 10https://bugzilla.wikimedia.org/66062#c2 (10Melos) 5RESO/FIX>3REOP The rc-bot does not show any feed. [16:15:11] (03CR) 10Siebrand: [C: 032] Localisation updates from https://translatewiki.net/. [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/153115 (owner: 10L10n-bot) [16:15:14] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net/. [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/153115 (owner: 10L10n-bot) [16:19:58] (03PS4) 10Legoktm: Introduce SkinFactory [core] - 10https://gerrit.wikimedia.org/r/153060 [16:20:25] (03CR) 10Legoktm: Introduce SkinFactory (037 comments) [core] - 10https://gerrit.wikimedia.org/r/153060 (owner: 10Legoktm) [16:20:41] :) [16:22:22] (03CR) 10Siebrand: [C: 032] Support GENDER in MediaWiki:Blockip and Special:Block [core] - 10https://gerrit.wikimedia.org/r/135436 (https://bugzilla.wikimedia.org/50572) (owner: 10Matěj Grabovský) [16:25:36] (03Merged) 10jenkins-bot: Support GENDER in MediaWiki:Blockip and Special:Block [core] - 10https://gerrit.wikimedia.org/r/135436 (https://bugzilla.wikimedia.org/50572) (owner: 10Matěj Grabovský) [16:25:56] <^d> Reedy: Why? [16:26:50] ^d: since https is slow and uncached, and wikipedia is not a bank. [16:27:16] <^d> i have a feeling the transparency site is not all that slow/ [16:27:21] <^d> Compared to MW :p [16:27:24] intercepted transparency report [16:27:45] way too transparent report [16:28:03] we need some translucent tuppperware [16:31:12] ^d: can i bug you to look at [[mw:Gerrit:Project ownership]]? [16:31:23] 3MediaWiki / 3Skin and page rendering: Implement checkbox spec in mediawiki.ui - 10https://bugzilla.wikimedia.org/69200#c12 (10Jon) Whilst WikiFont is not in core we cannot rely on it Jared. We are a long way off from that point as I understand it. WikiFont to my knowledge is only being used by Flow. [16:31:23] err, [[mw:Gerrit/Project ownership]] [16:32:15] <^d> Looking is easy! [16:32:19] <^d> Doing something isn't ;-) [16:32:26] ?action=delete is [16:33:31] yuvipanda: What via HTTPS isn't cached? [16:33:46] Lcawte: no idea, that's what they say :) [16:33:53] <^d> [citation needed] [16:34:04] Lcawte: but IIRC, intermediate ISP level caches can't do HTTP caching? I also don't think that's a bad thing [16:36:52] (03PS1) 10Chad: Followup 248ac9e: set $wgAutoloadClasses to an array after declaring [core] - 10https://gerrit.wikimedia.org/r/153119 [16:37:19] (03CR) 10Chad: Allow classes to be registered properly from installer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143779 (https://bugzilla.wikimedia.org/67440) (owner: 10Chad) [16:37:32] <^d> legoktm: ^^^ [16:37:49] (03CR) 10Legoktm: [C: 032] Followup 248ac9e: set $wgAutoloadClasses to an array after declaring [core] - 10https://gerrit.wikimedia.org/r/153119 (owner: 10Chad) [16:38:10] (03PS1) 10Addshore: Also run JsDuck on *.css files [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153120 (https://bugzilla.wikimedia.org/69347) [16:38:38] 3MediaWiki / 3History/Diffs: Minor edit class inconsistent - 10https://bugzilla.wikimedia.org/64040#c7 (10Nemo) Patch has -1. So, should class="minoredit" become class="minoredit mw-minor-edit" or what? If there's no BC way to amend the patch, please close this bug as WONTFIX for clarity. [16:38:41] MatmaRex: ^^ [16:38:51] (03PS3) 10Nemo bis: ignoresubpages parameter [extensions/intersection] - 10https://gerrit.wikimedia.org/r/149628 (https://bugzilla.wikimedia.org/68674) (owner: 10Rudloff) [16:39:04] addshore: thanks [16:39:32] <^d> jackmcbarn: Welcome to the mediawiki club. [16:39:36] (03PS5) 10Legoktm: Introduce SkinFactory [core] - 10https://gerrit.wikimedia.org/r/153060 [16:39:39] legoktm: You forgot to tell me to add the $maintClass to the bottom of the maintenance file :P [16:39:47] Lcawte: oh oops :P [16:40:01] jackmcbarn: congrats! [16:40:01] (03CR) 10jenkins-bot: [V: 04-1] Introduce SkinFactory [core] - 10https://gerrit.wikimedia.org/r/153060 (owner: 10Legoktm) [16:40:15] ^d: thanks! [16:40:25] <^d> yw [16:40:46] (03Merged) 10jenkins-bot: Followup 248ac9e: set $wgAutoloadClasses to an array after declaring [core] - 10https://gerrit.wikimedia.org/r/153119 (owner: 10Chad) [16:41:53] 3MediaWiki / 3Special pages: Moving a page won't change its namespace parameter under special:newpages - 10https://bugzilla.wikimedia.org/69324#c1 (10Bawolff (Brian Wolff)) 5UNCO>3RESO/DUP *** This bug has been marked as a duplicate of bug 12363 *** [16:42:08] 3MediaWiki / 3Recent changes: Page moves into mainspace should appear on Special:Newpages for patrol - 10https://bugzilla.wikimedia.org/12363#c41 (10Bawolff (Brian Wolff)) *** Bug 69324 has been marked as a duplicate of this bug. *** [16:42:16] (03PS6) 10Legoktm: Introduce SkinFactory [core] - 10https://gerrit.wikimedia.org/r/153060 [16:45:49] (03CR) 10Rudloff: [C: 031] ignoresubpages parameter [extensions/intersection] - 10https://gerrit.wikimedia.org/r/149628 (https://bugzilla.wikimedia.org/68674) (owner: 10Rudloff) [16:45:51] (03CR) 10jenkins-bot: [V: 04-1] Introduce SkinFactory [core] - 10https://gerrit.wikimedia.org/r/153060 (owner: 10Legoktm) [16:50:33] (03PS7) 10Legoktm: Introduce SkinFactory [core] - 10https://gerrit.wikimedia.org/r/153060 [16:53:30] (03CR) 10Brian Wolff: "I'm not interested in really reviewing things for this extension (sorry I'm lazy, too much to do), but if you want I can rubber stamp this" [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/151567 (owner: 10Theaitetos) [16:53:53] 3MediaWiki / 3Documentation: Implement MediaWiki Help Repository (fetching Help: pages from MediaWiki.org or Meta, similar to file description pages from Commons) - 10https://bugzilla.wikimedia.org/12306#c10 (10Kunal Mehta (Legoktm)) I wrote [[mw:Extension:HelpPages]] for this. [16:56:10] (03PS2) 10Matěj Grabovský: Use custom message for block link in ConfirmAccounts [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/135438 [16:56:23] 3MediaWiki / 3Configuration: Phase out right-related globals - 10https://bugzilla.wikimedia.org/18807#c6 (10Kunal Mehta (Legoktm)) (In reply to Chad H. from comment #0) > Things like $wgSysopUserBans, $wgSysopRangeBans, $wgSysopEmailBans (and any Only one remaining is $wgSysopEmailBans. [16:56:54] (03CR) 10Nemo bis: "Always nice to see DPL work. :)" (031 comment) [extensions/intersection] - 10https://gerrit.wikimedia.org/r/149628 (https://bugzilla.wikimedia.org/68674) (owner: 10Rudloff) [16:58:08] 3MediaWiki / 3Configuration: Implement configuration database aka configuration management aka no shell excuse (tracking) - 10https://bugzilla.wikimedia.org/26992 (10Kunal Mehta (Legoktm)) [16:58:23] 3MediaWiki / 3Configuration: Implement configuration database aka configuration management aka no shell excuse (tracking) - 10https://bugzilla.wikimedia.org/26992 (10Kunal Mehta (Legoktm)) [16:58:24] 3MediaWiki / 3Configuration: Convert things to use Config classes instead of globals (tracking) - 10https://bugzilla.wikimedia.org/69084 (10Kunal Mehta (Legoktm)) [16:59:37] (03CR) 10Bartosz Dziewoński: "Assuming you want to do this soon, can you work out how this interacts with the removal of skin autodiscovery in https://gerrit.wikimedia." [core] - 10https://gerrit.wikimedia.org/r/153060 (owner: 10Legoktm) [17:01:23] (03PS3) 10Matěj Grabovský: Use custom message for block link in ConfirmAccounts [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/135438 [17:07:05] addshore: are you interested in patches which make tests pass for all extensions? http://lists.wikimedia.org/pipermail/wikitech-l/2014-August/078047.html [17:07:21] Nemo_bis: yes :p [17:07:25] Because I already reported a few dozens bugs and submitted a dozen patches to that purpose last week (but they're mostly being ignored) [17:07:35] add me too them! [17:07:49] already added you to some [17:07:52] I added entry files for a bunch of extensions over the past few days, got a little spreadsheet on the go! [17:08:25] addshore: https://gerrit.wikimedia.org/r/#/c/149841/ [17:09:20] And https://gerrit.wikimedia.org/r/#/c/149838/ https://gerrit.wikimedia.org/r/#/c/149835/ https://gerrit.wikimedia.org/r/#/c/149832/ https://gerrit.wikimedia.org/r/#/c/149830/ https://gerrit.wikimedia.org/r/#/c/149807/ [17:09:31] And do you really want me to add you to all those bugs? [17:10:37] just the commits :) [17:10:45] *changes [17:10:47] ok [17:11:07] (03CR) 10Addshore: "recheck" [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/149841 (owner: 10Nemo bis) [17:14:24] 3Wikimedia / 3IRC: #central channel is down - 10https://bugzilla.wikimedia.org/66062#c3 (10Sam Reed (reedy)) 5REOP>3RESO/WOR [17:14:55] --> Reedy (~quassel@anonymous.user) has joined #central [17:14:55] *** Mode #central +tn by irc.wikimedia.org [17:14:55] * Channel #central created on 2014-06-03 01:32:0... [17:17:06] Nemo_bis: https://gerrit.wikimedia.org/r/#/c/149841 confuses me [17:18:35] (03PS2) 10Addshore: Ensure $rights is defined [extensions/AccessControl] - 10https://gerrit.wikimedia.org/r/149832 (owner: 10Nemo bis) [17:18:52] (03CR) 10Addshore: "Any update GBT248?" [extensions/AccessControl] - 10https://gerrit.wikimedia.org/r/149832 (owner: 10Nemo bis) [17:19:13] (03CR) 10Addshore: "recheck" [extensions/FormatNum] - 10https://gerrit.wikimedia.org/r/149838 (owner: 10Nemo bis) [17:19:25] (03CR) 10Addshore: "recheck" [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/149807 (owner: 10Nemo bis) [17:19:34] addshore: and I linked the bugs from http://lists.wikimedia.org/pipermail/wikitech-l/2014-August/078069.html [17:20:45] addshore: what's confuses? that code tries to evaluate POST parameters which may not be set [17:21:30] Except 2/5 cases which use isset which AFAIK we're not fond of :) [17:22:03] (03CR) 10Siebrand: [C: 032] Use custom message for block link in ConfirmAccounts [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/135438 (owner: 10Matěj Grabovský) [17:22:09] (03Merged) 10jenkins-bot: Use custom message for block link in ConfirmAccounts [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/135438 (owner: 10Matěj Grabovský) [17:22:48] There's also 12 bugs I filed in core https://bugzilla.wikimedia.org/buglist.cgi?chfieldfrom=2014-07-26&chfieldto=2014-08-02&email1=federicoleva&emailreporter1=1&emailtype1=substring&list_id=335612&product=MediaWiki&query_format=advanced&resolution=--- [17:23:28] and some were even fixed, for those who prefer happy news :P https://bugzilla.wikimedia.org/buglist.cgi?bug_status=RESOLVED&bug_status=VERIFIED&bug_status=CLOSED&chfieldfrom=2014-07-26&chfieldto=2014-08-02&email1=federicoleva&emailreporter1=1&emailtype1=substring&list_id=335613&product=MediaWiki&product=MediaWiki%20extensions&query_format=advanced [17:23:53] 3MediaWiki / 3Skin and page rendering: Implement checkbox spec in mediawiki.ui - 10https://bugzilla.wikimedia.org/69200#c13 (10Jared Zimmerman (WMF)) I added a black, grey, and green version of the check to the trello board. [17:24:26] Nemo_bis: the isset would work and not through a message though..? [17:25:09] also your change means that if I pass wpFollow=bla it would evaluate to false? [17:25:23] 3Wikimedia / 3Deployment systems: Installed skins on Special:Version should show a version in Wikimedia envionment (from git) - 10https://bugzilla.wikimedia.org/68424 (10Bartosz Dziewoński) [17:27:14] ahem, I reversed the negation? [17:29:15] (03PS1) 10Bartosz Dziewoński: Precompute data for GitInfo for skins, too [tools/scap] - 10https://gerrit.wikimedia.org/r/153127 (https://bugzilla.wikimedia.org/68424) [17:29:35] (03PS13) 1001tonythomas: Fixed various issues with the BounceHandler extension [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/153016 (https://bugzilla.wikimedia.org/69099) [17:30:13] (03CR) 10Bartosz Dziewoński: "I have not ran this code. I have no idea if it will work." [tools/scap] - 10https://gerrit.wikimedia.org/r/153127 (https://bugzilla.wikimedia.org/68424) (owner: 10Bartosz Dziewoński) [17:30:22] Nemo_bis: if wpFollow=bla then isset( $_POST['wpFollow'] ) evals to true but $_POST['wpIndex'] === "" evals to false [17:30:56] sure [17:31:22] speaking of which, are we even supposed to use $_POST at all [17:32:08] (03CR) 10Microchip08: "The typos have already been fixed in I140e50aac5b9a82002c640e17b265849d44d2525 and so do not need to be fixed again in this commit." [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153026 (owner: 10Chmarkine) [17:32:15] (03PS1) 10Microchip08: remove path comments from .css files [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153129 [17:33:12] (03PS4) 10Nemo bis: Don't use undefined $_POST stuff, avoid isset [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/149841 [17:33:33] Nemo_bis: not meant to use $_POST ;p [17:33:52] (03PS2) 10Microchip08: remove path comments from .css files [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/153129 [17:34:39] 3MediaWiki / 3Patrolling: Ability to mark a page as unpatrolled - 10https://bugzilla.wikimedia.org/69323#c1 (10Andre Klapper) 5UNCO>3RESO/DUP p:5Unprio>3Low Hi Dalba. Thanks for taking the time to report this! This particular problem has already been reported into our bug tracking system, but please... [17:34:39] 3MediaWiki / 3Page editing: action=markpatrolled cannot be undone - 10https://bugzilla.wikimedia.org/20399#c1 (10Andre Klapper) *** Bug 69323 has been marked as a duplicate of this bug. *** [17:35:26] ;) [17:36:11] (03PS1) 10Jarry1250: Add separate entry for TranslateSVG to note dependency [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/153130 [17:37:48] (03CR) 10Addshore: [C: 031] Add separate entry for TranslateSVG to note dependency [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/153130 (owner: 10Jarry1250) [17:39:04] (03CR) 10Legoktm: API: Overhaul token handling (032 comments) [core] - 10https://gerrit.wikimedia.org/r/153110 (owner: 10Anomie) [17:39:07] (03CR) 10Ori.livneh: Precompute data for GitInfo for skins, too (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/153127 (https://bugzilla.wikimedia.org/68424) (owner: 10Bartosz Dziewoński) [17:39:37] Nemo_bis: that also doesnt work :) whats if I pass wpIndex='' which you can do in code api modules etc! [17:40:40] (03CR) 10Bartosz Dziewoński: Precompute data for GitInfo for skins, too (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/153127 (https://bugzilla.wikimedia.org/68424) (owner: 10Bartosz Dziewoński) [17:40:53] 3Wikimedia / 3SSL related: Allow option to uncheck "Always use a secure connection when logged in" at login.wikimedia.org/wiki/Special:Preferences - 10https://bugzilla.wikimedia.org/69319#c1 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc So the request is that the by-default-enabled setting "Alwa... [17:41:50] addshore: hard to tell what's the intended meaning [17:42:11] can just check for null if preferred, I only want the fatal fixed [17:42:25] array_key_exists ? [17:42:41] sounds ugly [17:43:26] but that is the current issue if the currently implementation doesnt cause Undefined index [17:43:32] (03CR) 10Ori.livneh: Precompute data for GitInfo for skins, too (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/153127 (https://bugzilla.wikimedia.org/68424) (owner: 10Bartosz Dziewoński) [17:43:45] (03CR) 10Legoktm: [C: 032] Update token handling for core API change [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/153105 (owner: 10Anomie) [17:44:01] (03CR) 10Legoktm: [C: 032] Update token handling for core API change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153092 (owner: 10Anomie) [17:44:04] (03Merged) 10jenkins-bot: Update token handling for core API change [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/153105 (owner: 10Anomie) [17:44:24] (03CR) 10Legoktm: [C: 032] Update token handling for core API change [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153095 (owner: 10Anomie) [17:44:27] (03Merged) 10jenkins-bot: Update token handling for core API change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/153092 (owner: 10Anomie) [17:44:30] (03CR) 10Legoktm: [C: 032] Update token handling for core API change [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/153099 (owner: 10Anomie) [17:44:39] (03Merged) 10jenkins-bot: Update token handling for core API change [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/153099 (owner: 10Anomie) [17:44:59] (03Merged) 10jenkins-bot: Update token handling for core API change [extensions/Flow] - 10https://gerrit.wikimedia.org/r/153095 (owner: 10Anomie) [17:45:05] (03PS5) 10Nemo bis: Don't use undefined $_POST stuff, avoid isset [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/149841 [17:45:08] 3MediaWiki / 3Skin and page rendering: Deprecate and remove skin autodiscovery (autoloading) mechanism - 10https://bugzilla.wikimedia.org/65748 (10Andre Klapper) [17:45:38] 3MediaWiki / 3Parser: Inconsistent parser behavior with space-pre nested in HTML lists - 10https://bugzilla.wikimedia.org/69313 (10Andre Klapper) p:5Unprio>3Normal [17:45:46] (03CR) 10Legoktm: [C: 032] Update token handling for core API change [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/153102 (owner: 10Anomie) [17:45:49] (03CR) 10Legoktm: [C: 032] Update token handling for core API change [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/153091 (owner: 10Anomie) [17:45:51] (03CR) 10Legoktm: [C: 032] Update token handling for core API change [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/153087 (owner: 10Anomie) [17:45:54] (03Merged) 10jenkins-bot: Update token handling for core API change [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/153091 (owner: 10Anomie) [17:45:56] (03Merged) 10jenkins-bot: Update token handling for core API change [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/153102 (owner: 10Anomie) [17:45:59] (03Merged) 10jenkins-bot: Update token handling for core API change [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/153087 (owner: 10Anomie) [17:46:11] Nemo_bis: https://gerrit.wikimedia.org/r/#/c/149841/5/AdvancedMeta.php but now you have undefined index?!!? [17:47:08] 3Wikimedia / 3Interwiki links: link to wikinews does not work for file: command - 10https://bugzilla.wikimedia.org/69317 (10Andre Klapper) [17:47:53] undefined? [17:48:31] legoktm: Ouch. [17:48:45] James_F: ? [17:48:49] $_POST['wpIndex'] === null if wpIndex is not posted then youll get undefined index! [17:49:12] use isset() [17:49:41] legoktm: Wide-spread fixes FTW. :-) [17:49:46] oh :D [17:50:37] (03CR) 10Addshore: [C: 04-1] Make efFormatNumParserFunction_Setup static (031 comment) [extensions/FormatNum] - 10https://gerrit.wikimedia.org/r/149838 (owner: 10Nemo bis) [17:50:49] (03CR) 10Anomie: API: Overhaul token handling (032 comments) [core] - 10https://gerrit.wikimedia.org/r/153110 (owner: 10Anomie) [17:50:51] legoktm: about this: [17:50:51] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FHelpPages/7d2a9c33f69106b89d2f90081690329626a80b60/HelpPages.body.php#L95 [17:51:08] will it parse (interwiki) links as in mediawiki.org or as in the local wiki? [17:51:31] e.g. [[:pt:TEST]] will point to https://pt.wikipedia.org/wiki/TEST or to https://pt.wikisource.org/wiki/TEST if the code is on wikisource? [17:53:05] helderwiki: it'll parse them as mw.o did them [17:53:28] helderwiki: also, I re-wrote that extension as E:GlobalUserPage, and haven't merged the changes back into it [17:53:49] (03PS6) 10Withoutaname: Remove various functions and globals deprecated since 1.22 from RecentChange [core] - 10https://gerrit.wikimedia.org/r/150762 [17:53:58] ok [17:57:24] (03CR) 10Nemo bis: "Hmpf, I hate $_POST" [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/149841 (owner: 10Nemo bis) [18:00:05] (03PS2) 10Nemo bis: Make efFormatNumParserFunction_Setup static [extensions/FormatNum] - 10https://gerrit.wikimedia.org/r/149838 [18:10:15] (03CR) 10Withoutaname: "It's not used in a lot of extensions (e.g. https://github.com/search?q=user%3Awikimedia+$wgHTCPMulticastAddress&ref=cmdform&type=Code ) so" [core] - 10https://gerrit.wikimedia.org/r/150761 (owner: 10Withoutaname) [18:10:38] 3Wikimedia / 3Bugzilla: Create "MediaWiki" --> "Configuration" component - 10https://bugzilla.wikimedia.org/69339#c2 (10Andre Klapper) Description says "Issues related to configuration options and the Config interface". What is "the Config interface" here, and how to reach that? [18:17:10] anybody seen coren? [18:23:53] 3Wikimedia / 3Site requests: Switch Media Viewer to opt-in for default in dewp - 10https://bugzilla.wikimedia.org/69292#c1 (10Fabrice Florin) 5NEW>3RESO/WON Thanks for filing this bug. On behalf of the Wikimedia Foundation, I have posted a response to the German Wikipedia poll about Media Viewer, on thi... [18:24:39] 3Wikimedia / 3General/Unknown: Don't use deprecated features removed in jQuery 1.9 (tracking) - 10https://bugzilla.wikimedia.org/65399 (10Helder) [18:25:10] 3Wikimedia / 3General/Unknown: Don't use deprecated features removed in jQuery 1.9 (tracking) - 10https://bugzilla.wikimedia.org/65399 (10Helder) [18:25:10] 3MediaWiki / 3JavaScript: Wikilove uses jquery.ui, which uses .andSelf(), which is deprecated - 10https://bugzilla.wikimedia.org/69350 (10Helder) 3NEW p:3Unprio s:3normal a:3None When I click on Wikilove icon I get "JQMIGRATE: jQuery.fn.andSelf() replaced by jQuery.fn.addBack()" in the console. This... [18:25:47] (03PS6) 10Nemo bis: Don't use undefined $_POST stuff, avoid isset [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/149841 [18:34:54] (03CR) 10Jarry1250: "Why are we avoiding isset()? In the case of a superglobal like $_POST, there's not practical distinction between isset() and array_key_exi" [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/149841 (owner: 10Nemo bis) [18:41:25] (03CR) 10Nemo bis: "Feel free to amend as you want, this is way beyond the level of nitpicking I'm interested in for such an obscure extension. :-) Whatever f" [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/149841 (owner: 10Nemo bis) [18:41:40] (03CR) 10Nemo bis: "* of the notice, that is" [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/149841 (owner: 10Nemo bis) [19:00:43] legoktm or Reedy? [19:01:13] could you search for "/WikiLove/modules/ext.wikiLove/images" on using mw-grep? [19:01:19] Hmm, I wonder where legoktm is... [19:02:06] that would help us determine if bug 69352 affects other wikis [19:02:46] (03CR) 10Helder.wiki: "Caused bug 69352, fixed locally by" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111741 (owner: 10Yuvipanda) [19:03:46] (03CR) 10Bartosz Dziewoński: [C: 032] "Oh well, let's do this. Danny made me do it at Wikimania :D" [core] - 10https://gerrit.wikimedia.org/r/145761 (owner: 10Danny B.) [19:06:12] I see Reedy but I'd imagine he's probably busy doing things since he hasn't replied yet. [19:06:58] maybe ori can help? [19:07:00] (03Merged) 10jenkins-bot: Special:Allpages replace table with unordered list [core] - 10https://gerrit.wikimedia.org/r/145761 (owner: 10Danny B.) [19:08:48] (03CR) 10Hashar: [C: 032] "Lets do it!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153120 (https://bugzilla.wikimedia.org/69347) (owner: 10Addshore) [19:09:07] (03Merged) 10jenkins-bot: Also run JsDuck on *.css files [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153120 (https://bugzilla.wikimedia.org/69347) (owner: 10Addshore) [19:15:51] The thing where your laptop dies after a good three hoursof working on a thing, and then you read more about ehat to do next in the project and get sad because you can't implement it yet. :-P [19:22:19] (03CR) 10Helder.wiki: "What about doing the same for Special:PrefixIndex?" [core] - 10https://gerrit.wikimedia.org/r/145761 (owner: 10Danny B.) [19:26:54] (03PS1) 10Umherirrender: Cleanup some docs (maintenance) [core] - 10https://gerrit.wikimedia.org/r/153212 [19:34:27] (03CR) 10BryanDavis: "This can be tested this in beta via cherry-picking to /srv/deployment/scap/scap on tin, running trebuchet and then running /usr/local/bin/" (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/153127 (https://bugzilla.wikimedia.org/68424) (owner: 10Bartosz Dziewoński) [19:36:57] (03CR) 10Jackmcbarn: [C: 04-1] Cleanup some docs (maintenance) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153212 (owner: 10Umherirrender) [19:37:06] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/InteractiveBlockMessage] - 10https://gerrit.wikimedia.org/r/152437 (owner: 10Hashar) [19:37:28] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GroupsSidebar] - 10https://gerrit.wikimedia.org/r/152417 (owner: 10Hashar) [19:38:09] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GooglePlusOne] - 10https://gerrit.wikimedia.org/r/152415 (owner: 10Hashar) [19:38:13] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/152414 (owner: 10Hashar) [19:38:17] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GoogleDocTag] - 10https://gerrit.wikimedia.org/r/152413 (owner: 10Hashar) [19:38:20] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GoogleDocs4MW] - 10https://gerrit.wikimedia.org/r/152412 (owner: 10Hashar) [19:38:24] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/googleAnalytics] - 10https://gerrit.wikimedia.org/r/152411 (owner: 10Hashar) [19:38:27] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GlobalUserrights] - 10https://gerrit.wikimedia.org/r/152410 (owner: 10Hashar) [19:38:32] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GlobalUserGroups] - 10https://gerrit.wikimedia.org/r/152409 (owner: 10Hashar) [19:38:36] (03CR) 10Danny B.: "It's on the roadmap... There were some reasons which we discussed at Zurich to do it in two steps which I can't remember off-head now..." [core] - 10https://gerrit.wikimedia.org/r/145761 (owner: 10Danny B.) [19:39:27] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GlobalNotice] - 10https://gerrit.wikimedia.org/r/152408 (owner: 10Hashar) [19:39:31] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Genderize] - 10https://gerrit.wikimedia.org/r/152407 (owner: 10Hashar) [19:39:37] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/152406 (owner: 10Hashar) [19:39:41] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/152405 (owner: 10Hashar) [19:39:56] 3MediaWiki / 3Internationalization: MediaWiki:Blockip should support gender - 10https://bugzilla.wikimedia.org/50572#c8 (10Tomasz W. Kozlowski) 5PATC>3RESO/FIX a:3Matěj Grabovský This has now been merged in core, as comment 7 proves. [19:40:32] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/DownloadCounter] - 10https://gerrit.wikimedia.org/r/152378 (owner: 10Hashar) [19:40:36] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/152379 (owner: 10Hashar) [19:40:39] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/152380 (owner: 10Hashar) [19:40:44] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/152381 (owner: 10Hashar) [19:40:48] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/EditSubpages] - 10https://gerrit.wikimedia.org/r/152382 (owner: 10Hashar) [19:40:58] (03PS9) 10Umherirrender: Cleanup some docs (tests) [core] - 10https://gerrit.wikimedia.org/r/148991 [19:42:07] (03CR) 10Hashar: "recheck" [extensions/Persona] - 10https://gerrit.wikimedia.org/r/152535 (owner: 10Hashar) [19:42:20] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Persona] - 10https://gerrit.wikimedia.org/r/152535 (owner: 10Hashar) [19:42:22] (03CR) 10Umherirrender: "Patch Set 9: Rebased and removed changes from languages and maintenance folder" [core] - 10https://gerrit.wikimedia.org/r/148991 (owner: 10Umherirrender) [19:42:53] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PhpHighlight] - 10https://gerrit.wikimedia.org/r/152538 (owner: 10Hashar) [19:42:57] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/152537 (owner: 10Hashar) [19:43:00] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/152536 (owner: 10Hashar) [19:44:58] (03CR) 10Hashar: "recheck" [extensions/Theme] - 10https://gerrit.wikimedia.org/r/152650 (owner: 10Hashar) [19:45:21] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Theme] - 10https://gerrit.wikimedia.org/r/152650 (owner: 10Hashar) [19:45:52] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ThemeDesigner] - 10https://gerrit.wikimedia.org/r/152651 (owner: 10Hashar) [19:55:20] (03CR) 10Umherirrender: Cleanup some docs (maintenance) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153212 (owner: 10Umherirrender) [19:56:55] (03PS1) 10Umherirrender: Cleanup some docs (languages) [core] - 10https://gerrit.wikimedia.org/r/153218 [20:00:30] (03PS1) 10Alex Monk: jshint and code style stuff [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153220 [20:00:36] (03CR) 10jenkins-bot: [V: 04-1] jshint and code style stuff [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153220 (owner: 10Alex Monk) [20:00:38] (03CR) 10Jackmcbarn: Cleanup some docs (maintenance) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153212 (owner: 10Umherirrender) [20:08:01] (03CR) 10Alex Monk: "todo:" [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153220 (owner: 10Alex Monk) [20:08:36] (03CR) 10Alex Monk: "also this is bug 69344" [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153220 (owner: 10Alex Monk) [20:09:18] (03PS2) 10Umherirrender: Cleanup some docs (maintenance) [core] - 10https://gerrit.wikimedia.org/r/153212 [20:09:23] 3MediaWiki extensions / 3Gadgets: Gadgets 2.0 doesn't pass jshint - 10https://bugzilla.wikimedia.org/69344#c2 (10Alex Monk) 5NEW>3PATC Gerrit change 153220 [20:09:35] (03CR) 10Umherirrender: "Patch Set 2: Addressed inline comment" [core] - 10https://gerrit.wikimedia.org/r/153212 (owner: 10Umherirrender) [20:09:54] 3MediaWiki extensions / 3Gadgets: Gadgets 2.0 doesn't pass jshint - 10https://bugzilla.wikimedia.org/69344 (10Alex Monk) a:3Alex Monk [20:15:53] 3MediaWiki extensions / 3AbuseFilter: Sysops receive Abusefilter-edit-restricted with filters that revoke auto-promoted groups - 10https://bugzilla.wikimedia.org/49227#c4 (10Calak) Yes, after add 'abusefilter-modify-restricted' right to sysops. [20:20:46] (03PS2) 10Umherirrender: Cleanup some docs (languages) [core] - 10https://gerrit.wikimedia.org/r/153218 [20:21:41] (03CR) 10Umherirrender: "Patch Set 2: Removed changes to @return lines, see https://gerrit.wikimedia.org/r/#/c/153212/1/maintenance/findHooks.php" [core] - 10https://gerrit.wikimedia.org/r/153218 (owner: 10Umherirrender) [20:33:19] !bug 62856 [20:33:19] https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=62856 [20:33:23] 3Wikimedia / 3Bugzilla: Create "MediaWiki" --> "Configuration" component - 10https://bugzilla.wikimedia.org/69339#c3 (10Chad H.) (In reply to Andre Klapper from comment #2) > What is "the Config interface" here, and how to reach that? The Config class. Not a UI. [20:38:19] (03PS8) 10Legoktm: Introduce SkinFactory [core] - 10https://gerrit.wikimedia.org/r/153060 [20:41:40] (03PS9) 10Legoktm: Introduce SkinFactory [core] - 10https://gerrit.wikimedia.org/r/153060 [20:46:25] (03CR) 10Reedy: [C: 031] Introduce SkinFactory [core] - 10https://gerrit.wikimedia.org/r/153060 (owner: 10Legoktm) [20:46:44] (03CR) 10Addshore: [C: 032] Introduce SkinFactory [core] - 10https://gerrit.wikimedia.org/r/153060 (owner: 10Legoktm) [20:49:43] (03Merged) 10jenkins-bot: Introduce SkinFactory [core] - 10https://gerrit.wikimedia.org/r/153060 (owner: 10Legoktm) [20:50:14] (03CR) 10Addshore: [C: 032] Make efFormatNumParserFunction_Setup static [extensions/FormatNum] - 10https://gerrit.wikimedia.org/r/149838 (owner: 10Nemo bis) [20:50:19] (03Merged) 10jenkins-bot: Make efFormatNumParserFunction_Setup static [extensions/FormatNum] - 10https://gerrit.wikimedia.org/r/149838 (owner: 10Nemo bis) [20:51:31] (03PS3) 10BryanDavis: Merge globalusage role into commons role [vagrant] - 10https://gerrit.wikimedia.org/r/152832 (owner: 10Gergő Tisza) [20:52:51] (03CR) 10Addshore: [C: 04-1] Don't use undefined $_POST stuff, avoid isset [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/149841 (owner: 10Nemo bis) [20:53:29] (03CR) 10Addshore: "Other than this comment it looks good!" (031 comment) [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/149841 (owner: 10Nemo bis) [20:57:08] 3MediaWiki-Vagrant: Fix wiki by loading skins from their new repositories - 10https://bugzilla.wikimedia.org/69259 (10Bryan Davis) 5PATC>3RESO/FIX [20:59:24] 3MediaWiki-Vagrant: vagrant_ram overrides sometimes ignored/forgotten - 10https://bugzilla.wikimedia.org/69131 (10Bryan Davis) p:5Unprio>3Normal a:5Ori Livneh>3Dan Duvall [21:02:34] (03CR) 10Jackmcbarn: [C: 032] Cleanup some docs (maintenance) [core] - 10https://gerrit.wikimedia.org/r/153212 (owner: 10Umherirrender) [21:05:41] (03Merged) 10jenkins-bot: Cleanup some docs (maintenance) [core] - 10https://gerrit.wikimedia.org/r/153212 (owner: 10Umherirrender) [21:07:06] (03PS1) 10Legoktm: MonoBook: Use SkinFactory [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/153229 [21:09:01] (03CR) 10Addshore: [C: 032] MonoBook: Use SkinFactory [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/153229 (owner: 10Legoktm) [21:09:03] (03Merged) 10jenkins-bot: MonoBook: Use SkinFactory [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/153229 (owner: 10Legoktm) [21:10:28] (03CR) 10Legoktm: [C: 032 V: 032] jshint and code style stuff [extensions/Gadgets] (RL2) - 10https://gerrit.wikimedia.org/r/153220 (owner: 10Alex Monk) [21:11:53] 3MediaWiki extensions / 3Gadgets: Gadgets 2.0 doesn't pass jshint - 10https://bugzilla.wikimedia.org/69344#c3 (10Alex Monk) So we just need to fix this now: modules/ext.gadgets.gadgetmanager.js: line 369, col 25, '$el' is not defined. [21:13:57] (03PS1) 10Legoktm: Use SkinFactory [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/153230 [21:13:59] (03PS1) 10Legoktm: Use Config instead of globals [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/153231 [21:16:23] 3MediaWiki-Vagrant: Archives directory /vagrant/apt-cache/partial is missing. - 10https://bugzilla.wikimedia.org/67976#c12 (10Bryan Davis) 5PATC>3RESO/FIX I have seen this happen for some other user during the London hackathon (I don't remember who). The fix was to make the old git cache happy by `mkdir -p... [21:16:33] (03PS1) 10Legoktm: Use Config instead of globals [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/153232 [21:20:42] (03PS1) 10Legoktm: Use SkinFactory [skins/Modern] - 10https://gerrit.wikimedia.org/r/153233 [21:23:45] hey legoktm [21:23:52] hey MatmaRex_mobile [21:24:03] you're going to have fun updating the snikking msnual, right? [21:24:12] skinning* :D [21:24:17] oh yes [21:24:18] link? [21:24:23] poo [21:24:31] addshore said that [21:24:37] !mw manual:skinning [21:24:37] https://www.mediawiki.org/wiki/manual:skinning [21:26:59] (03CR) 10BryanDavis: [C: 032] Merge globalusage role into commons role [vagrant] - 10https://gerrit.wikimedia.org/r/152832 (owner: 10Gergő Tisza) [21:27:04] ok [21:27:05] (03Merged) 10jenkins-bot: Merge globalusage role into commons role [vagrant] - 10https://gerrit.wikimedia.org/r/152832 (owner: 10Gergő Tisza) [21:27:31] MatmaRex_mobile: what do you call the "vector" name, and "Vector"? [21:27:54] hmm? [21:28:20] like, how do I explain the difference? [21:28:31] let me just save it and you can correct me if it's wrong... [21:32:51] ah [21:33:10] MatmaRex_mobile: https://www.mediawiki.org/wiki/Manual:Skinning#Boilerplate_and_definitions [21:33:12] there's a section on that page that explains this [21:33:30] https://www.mediawiki.org/w/index.php?title=Manual:Skinning&diff=prev&oldid=1098035 [21:34:37] (03CR) 10BryanDavis: "Can this be abandoned now that Ifd9c7693204da8a6841f4a2512aae9dde45591c0 has been merged?" [vagrant] - 10https://gerrit.wikimedia.org/r/149534 (owner: 10Aude) [21:35:01] legoktm: the manual should probsb-y be kept compatible with 1.23 at least [21:35:08] hm :/ [21:35:09] 1.19refer [21:35:12] so then [21:35:20] preferably* [21:35:22] bah [21:35:52] ok [21:36:00] i think i described all festures since then as requiring MW version whatever [21:36:56] (03PS2) 10BryanDavis: Update MathSearch role [vagrant] - 10https://gerrit.wikimedia.org/r/152720 (owner: 10Physikerwelt) [21:37:04] (03CR) 10BryanDavis: [C: 032] Update MathSearch role [vagrant] - 10https://gerrit.wikimedia.org/r/152720 (owner: 10Physikerwelt) [21:37:09] (03Merged) 10jenkins-bot: Update MathSearch role [vagrant] - 10https://gerrit.wikimedia.org/r/152720 (owner: 10Physikerwelt) [21:37:49] (03PS1) 10Jack Phoenix: For Isarra with love. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153262 [21:40:22] MatmaRex_mobile: ok, updated [21:43:17] this is much better. i hate touch keyboards. [21:43:29] legoktm: that should probably be "new SkinMySkin", no? [21:43:42] (03CR) 10Isarra: "You know, that's actually a really horrible commit message. You should fix that. And then merge this." [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153262 (owner: 10Jack Phoenix) [21:45:34] (03PS2) 10Isarra: CSS CHANGES AND STUFF [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153262 (owner: 10Jack Phoenix) [21:45:50] MatmaRex: yeaaaaaaaaah [21:48:07] (03CR) 10Isarra: [C: 031 V: 032] "You should still make the commit message less stupid." [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153262 (owner: 10Jack Phoenix) [21:50:06] (fixed) [21:53:19] (03CR) 10Jack Phoenix: [C: 032 V: 032] "It's accurate, though (well, a LESS file was also changed, but it's...close enough). Besides, commit messages are so overrated these days." [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153262 (owner: 10Jack Phoenix) [21:54:26] Yeah, deflation days [21:54:54] addshore: well done! [21:56:05] legoktm: also, i guess it is possible to use both ways of skin registration at the same time, right? [21:56:18] legoktm: would be totally cook if you updated mw/skins/Example to do that :D [21:56:42] cool, even [21:56:49] yes! you can use both at the same itme [21:56:51] time* [21:58:24] hmm, or i guess the example skin could keep using the old way for now, since it's simpler and the skin is meant to be simple [21:58:26] i dunno [21:58:46] why not just have it do both? [21:58:55] oh no [21:59:00] if we want to support the old way [21:59:10] it should be wrapped in a class_exists('SkinFactory') [22:00:08] should we try to support both? [22:02:26] support both where? [22:02:29] in skins? probably [22:02:41] i would imagine most skin authors would want to support 1.23, since it's a LTS [22:02:54] basically [22:03:05] right now the simplest way to support 1.23 and 1.24+ is to use the old way [22:03:21] if you have interest in getting people to use the new way, you should make it easy to do :D [22:03:38] 3MediaWiki / 3Configuration: Migrate Setup.php to use Config instead of globals - 10https://bugzilla.wikimedia.org/69338#c1 (10Kunal Mehta (Legoktm)) p:5Lowest>3Normal Ori said that hhvm shouldn't be blocking this anymore. So let's do it! [22:03:38] (03PS1) 10Jack Phoenix: Revert "CSS CHANGES AND STUFF" [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153263 [22:03:41] (if you don't care, then let's just recommend using the old way unless one needs the new functionality) [22:03:53] (and probably everyone will be happiest this way) [22:03:58] (03CR) 10Jack Phoenix: [C: 032 V: 032] Revert "CSS CHANGES AND STUFF" [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/153263 (owner: 10Jack Phoenix) [22:04:05] well, [22:04:50] we should encourage people to use SkinFactory. [22:05:24] b/c config db! [22:06:24] 3MediaWiki extensions / 3Gadgets: Convert Gadgets 2.0 namespaces to use ContentHandler - 10https://bugzilla.wikimedia.org/69318 (10Kunal Mehta (Legoktm)) 5NEW>3ASSI a:3Kunal Mehta (Legoktm) [22:14:15] legoktm: hmmm [22:14:23] so i'm actually looking at the thing now [22:14:25] public function register( $name, $displayName, $callback ) { [22:14:47] hold on [22:14:50] what exactly is $name and $displayName? $name is probably the internal name, this is saved as user pref. value and so on [22:14:51] I'm coming to the hotel now [22:14:55] but what is $displayName? [22:14:55] yes [22:14:58] okay [22:15:00] 'vector', 'Vector' [22:15:06] i know [22:15:08] but what does it do [22:15:13] it's not part of the class name anymore [22:15:18] then what is it? [22:15:35] just for back-compat with things that abused this value? [22:15:43] (the part-of-class-name value, that is) [22:26:09] (03CR) 10Fomafix: "Yes, both margins get applied." [core] - 10https://gerrit.wikimedia.org/r/152785 (owner: 10Gerrit Patch Uploader) [22:27:26] Since mw code is under GPL, does that mean any user script using mw.loader must also be licensed as GPL? [22:27:30] (context: https://en.wikipedia.org/w/index.php?diff=620559132 ) [22:27:52] whaaa? no [22:27:57] disclaimer: i am not a lawyer [22:28:09] * helderwiki neither [22:28:47] but i don't see how MW being licensed under GPL would force the on-wiki scripts to also be [22:29:13] it's not distributed together with them or anything [22:31:08] Doesn't using these libraries makes the code "linked" to MW somehow? [22:32:38] iirc this has been discussed hundreds of time on the ML [22:32:42] and the answer is no [22:35:08] (03PS1) 10MaxSem: Add a button to save a list of pages [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/153265 [22:35:15] (03CR) 10jenkins-bot: [V: 04-1] Add a button to save a list of pages [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/153265 (owner: 10MaxSem) [22:35:29] fuck you jerkins [22:36:03] huh [22:36:13] has someone changed the default configuration again? [22:36:26] ah no, it's your fault. :D [22:37:56] (03PS2) 10MaxSem: Add a button to save a list of pages [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/153265 [22:38:35] MatmaRex, if its configuration is fucked up that much, fuck it [22:39:28] MaxSem: most of the jslint rules are rather silly [22:39:42] eggzactly [22:39:57] there probably are some obscure cases when putting '&&' on the beginning of next line rather than end of the previous can ruin your day [22:40:02] never had it happen to me… [22:40:53] 3MediaWiki / 3Configuration: Migrate Setup.php to use Config instead of globals - 10https://bugzilla.wikimedia.org/69338#c2 (10Florian) Hmm, i must ask this, maybe i'm a little bit lazy, because it's late™: Do you mean to set configuration variables (like $wgLogo) directly in the config object (Config::set()... [22:42:05] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Setting a -1 just that i know, that this needs a rework (just a notification for me) :)" [core] - 10https://gerrit.wikimedia.org/r/152134 (https://bugzilla.wikimedia.org/69188) (owner: 10Florianschmidtwelzow) [22:43:15] (03CR) 10Helder.wiki: "Local customizations are not working on ptwiki anymore. I assume this change may be related." [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/100338 (owner: 10Legoktm) [22:43:46] legoktm: ^ [22:46:11] MatmaRex: MatmaRex_mobile : legoktm says you should come down to the bar [22:46:34] uhm [22:46:36] can do [22:46:48] should i bring my laptop? [22:46:51] probably not [22:47:43] give me a few minutes [22:53:04] (03CR) 10Helder.wiki: "To be more specific, it seems the custom list:" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/100338 (owner: 10Legoktm) [22:59:06] (03CR) 10Siebrand: [C: 032] Cleanup some docs (languages) [core] - 10https://gerrit.wikimedia.org/r/153218 (owner: 10Umherirrender) [22:59:21] valhallasw`mania: you there? [22:59:36] MatmaRex_mobile: yes [22:59:43] where? [23:00:09] In the bar bar [23:00:15] Lego is coming [23:00:18] Legoktm it's walking to the lobby bar now [23:00:20] (03CR) 10Helder.wiki: "Reported as bug 69356." [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/100338 (owner: 10Legoktm) [23:00:27] valhallasw`mania: is slow :) [23:00:39] No :) [23:00:41] addshore: stop stealingmy lines [23:01:01] Hhh [23:01:01] addshore: ffffffujuuuuuuuuui [23:02:03] (03Merged) 10jenkins-bot: Cleanup some docs (languages) [core] - 10https://gerrit.wikimedia.org/r/153218 (owner: 10Umherirrender) [23:09:15] (03PS1) 10Florianschmidtwelzow: WIP: Special:Block: Use config object instead of globals [core] - 10https://gerrit.wikimedia.org/r/153266 (https://bugzilla.wikimedia.org/69087) [23:10:21] (03CR) 10Florianschmidtwelzow: WIP: Special:Block: Use config object instead of globals (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153266 (https://bugzilla.wikimedia.org/69087) (owner: 10Florianschmidtwelzow) [23:11:49] (03CR) 10Florianschmidtwelzow: Add info about GoogleLogin to Special:Preferences (031 comment) [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/152988 (https://bugzilla.wikimedia.org/68727) (owner: 10Florianschmidtwelzow) [23:12:14] (03PS2) 10Florianschmidtwelzow: Add info about GoogleLogin to Special:Preferences [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/152988 (https://bugzilla.wikimedia.org/68727) [23:41:21] (03PS10) 10Foxtrott: Fix for Ia9baaf0b: magic functions for previously public class members [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) [23:41:37] helderwiki: ughhhh [23:42:50] (03CR) 10Legoktm: [C: 04-1] WIP: Special:Block: Use config object instead of globals (031 comment) [core] - 10https://gerrit.wikimedia.org/r/153266 (https://bugzilla.wikimedia.org/69087) (owner: 10Florianschmidtwelzow) [23:47:09] 3MediaWiki / 3General/Unknown: Package basic skins with the MediaWiki tarball 1.24 and later - 10https://bugzilla.wikimedia.org/69248#c2 (10Bartosz Dziewoński) a:3Mark A. Hershberger The README there says it's a "Handy-dandy tool to pull a tagged release out of SVN". That can't possibly be up-to-date. Any...