[00:00:19] yes, you can use the api client to create a new account [00:00:25] marxarelli: \o/ [00:00:31] how do i do that? [00:00:55] i recently submitted a patch that will give direct access to the api client, but it hasn't been merged yet [00:01:01] until then, you can use APIPage [00:01:29] (which i hope we eventually deprecate, because it's a little awkward) :) [00:01:41] marxarelli: any examples you can point me at? [00:02:57] hmm... not sure where they might be [00:03:27] jdlrobson: but it would essentially be on(APIPage).client.create_account("username", "password") [00:03:57] jdlrobson: does your test depend on the presence of an additional account? [00:03:58] thanks marxarelli taking a look... [00:04:13] marxarelli: one requires a brand new user [00:04:18] other requires two users interacting [00:04:25] got it [00:06:10] marxarelli: how would i log in as the new user? [00:06:12] jdlrobson: hmm.. just thought of something. it's possible that your test will fail due to the selenium user not having permissions [00:06:24] marxarelli: the user i'm using should have sufficient permissions [00:07:49] in your environment, it may work. but we need to ensure that tests can run against any target wiki, given the right environment variables [00:08:09] marxarelli: it works in beta labs too... which is all i'm caring about right now [00:09:11] alrighty. it's likely that we'll need to refactor after QA comes up with a better system for ensuring new users and testing inter-user functionality. but for now, go for it! [00:11:12] jdlrobson: also, let us know what you come up! [00:11:19] + with [00:12:09] marxarelli: mm.. on(APIPage).client.create_account(@username, ENV["MEDIAWIKI_PASSWORD"]) doesn't seem to be working for me so far. [00:12:14] is there anyway to debug it? [00:12:45] i've been using pry to debug. it's an interactive repl for ruby [00:13:19] add this to your Gemfile: gem "pry-byebug" [00:13:38] this to features/support/env.rb: require "pry-byebug" [00:14:11] and call binding.pry where you want to stop execution (works as a breakpoint) [00:15:35] one big problem with the ruby api client atm is that it fails silently [00:16:07] i've submitted a patch to fix that. it'll go into the next realease [00:16:21] s/real/rel/ [00:16:29] (need more coffee...) [00:16:36] (03PS1) 10Bsitu: Hygiene: Update method documentation & add exception to a file [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151803 [00:17:34] marxarelli: wait i got it working without the debugger [00:17:36] was just something silly [00:17:56] jdlrobson: oh, good [00:18:56] (03CR) 10Awight: [C: 032] ConnectionType, getOrCreateCampaignEnsureUrlKey() (031 comment) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/143009 (owner: 10AndyRussG) [00:19:09] (03Merged) 10jenkins-bot: ConnectionType, getOrCreateCampaignEnsureUrlKey() [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/143009 (owner: 10AndyRussG) [00:21:51] (03PS1) 10Jdlrobson: QA: Add browser test for sign up notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151804 [00:21:52] marxarelli: yeeehhahaaa ^ [00:22:25] (03CR) 10Awight: [C: 032] Participation on create account via campaign url (031 comment) [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/119258 (owner: 10AndyRussG) [00:22:38] (03Merged) 10jenkins-bot: Participation on create account via campaign url [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/119258 (owner: 10AndyRussG) [00:22:47] jdlrobson: https://www.youtube.com/watch?v=gazIa2IibZA [00:25:56] (03CR) 10Awight: [C: 032] "You make it look easy!" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/117380 (owner: 10AndyRussG) [00:26:07] (03Merged) 10jenkins-bot: Query API modules for campaigns and participants [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/117380 (owner: 10AndyRussG) [00:26:32] (03CR) 10Awight: "Is this still a WIP? I see lots of things depend on this patchset." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 (owner: 10AndyRussG) [00:27:35] (03PS2) 10Jdlrobson: Begin deprecation of mediawiki.ui style module [core] - 10https://gerrit.wikimedia.org/r/151791 [00:27:37] (03PS2) 10Jdlrobson: Add mw-ui-text-truncated utility class [core] - 10https://gerrit.wikimedia.org/r/151792 [00:30:10] (03CR) 10Jdlrobson: "recheck" [core] - 10https://gerrit.wikimedia.org/r/150635 (owner: 10Jdlrobson) [00:30:20] (03PS15) 10Jdlrobson: Add blanket support for mediawiki ui via globals [core] - 10https://gerrit.wikimedia.org/r/150635 [00:30:22] (03CR) 10Awight: [C: 031] "I'll run locally and stuff once this is not a WIP." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 (owner: 10AndyRussG) [00:30:56] jdlrobson: you shouldn't need the explicit api-client authentication. if you're using the newest mediawiki_selenium, on(APIPage).client should perform that exact call to `log_in` before it returns [00:31:07] oh reallyyyy? [00:31:34] marxarelli: does it also die silently if the user already exists? [00:32:29] jdlrobson: not sure. it depends on what the response looks like from the api [00:32:58] (03PS1) 10Bsitu: Add mw-ui-text-truncated to overlay and special page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151805 [00:33:37] (03PS2) 10Bsitu: Add mw-ui-text-truncated to overlay and special page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151805 [00:34:03] jdlrobson: if the errant response is one where a mediawiki-api-error header is included and the body is like ..., then yes, it will fail silently [00:35:04] (03PS2) 10Jdlrobson: QA: Add browser test for sign up notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151804 [00:35:05] i'm not familiar enough with the api yet to say for certain [00:35:13] (03PS2) 10Bsitu: Flow notification item new style [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151537 [00:40:43] marxarelli: doesn't seem too :-/ [00:41:23] hmm... what does `bundle list mediawiki_selenium` say about your version? [00:41:48] (03PS1) 10Jdlrobson: WIP: Write browser test for talk page notificaitons [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151806 [00:45:03] (03PS2) 10Bsitu: Hygiene: Update method documentation & split exception to a file [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151803 [01:11:52] 3MediaWiki / 3API: prop=info&inprop=protection sometimes shows protection multiple times - 10https://bugzilla.wikimedia.org/28751 (10Robert Morley) [01:15:38] 3MediaWiki / 3ResourceLoader: CSSMin url() value remapping not working in certain obscure cases (braces in comments inside declarations: background: /*{test}*/ url(image.png) ) - 10https://bugzilla.wikimedia.org/60077#c18 (10Bawolff (Brian Wolff)) Quasar` on irc just now is experiancing this bug on 1.23.2, w... [02:05:17] (03CR) 10AndyRussG: "Thanks much!! I think it just needs some tweaking from design." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 (owner: 10AndyRussG) [02:16:22] 3MediaWiki / 3User preferences: One-click system for setting user preferences - 10https://bugzilla.wikimedia.org/67846#c6 (10jeremyb) (In reply to WhatamIdoing from comment #5) > I think I can: > > Tell me the exact wikitext I need to type to tell an editor at the English > Wikipedia's Help Desk these thing... [02:46:24] 3Wikimedia / 3Extension setup: HotCat is not working when adding a toolbar component to common.js - Wikisource - 10https://bugzilla.wikimedia.org/69137 (10ineuw) 3NEW p:3Unprio s:3normal a:3None HotCat gets disabled when I enable an "mw.toolbar.addButton" code. When I disable this code, HotCat again... [02:46:42] (03PS1) 10Pastakhov: add PhpTags::$bytecodeCache (v 3.0.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/151810 [02:47:52] 3Wikimedia / 3Extension setup: HotCat is not working when adding a toolbar component to common.js - Wikisource - 10https://bugzilla.wikimedia.org/69137 (10ineuw) [03:07:24] 3MediaWiki / 3Page editing: {{subst:REVISIONID}} does not work, but {{subst:REVISIONDAY}}, {{subst:REVISIONDAY2}}, {{subst:REVISIONMONTH}}, {{subst:REVISIONYEAR}}, {{subst:REVISIONTIMESTAMP}} and {{subst:REVISIONUSER}} all work fine. This is inconsistent. - 10https://bugzilla.wikimedia.org/69138 (10Lanthanide... [03:07:48] (03PS2) 10Pastakhov: add PhpTags::$bytecodeCache (v 3.0.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/151810 [03:32:08] hi Carmela [03:33:08] 3MediaWiki / 3ResourceLoader: mw.loader.store should not occupy all of localStorage - 10https://bugzilla.wikimedia.org/64721 (10Matthew Flaschen) [03:34:04] legoktm: https://gerrit.wikimedia.org/r/92315 [03:34:12] legoktm: Thoughts? [03:35:09] Well, it looks fine to me, but I'm not that strong of a JS reviewer [03:40:57] Who is? [03:41:35] Literally the entire reviewer list [03:41:52] You're too kind. [03:44:35] Since it's not actually being used anywhere yet, it should be a bit simpler to get merged... [03:47:35] did anyone see aaron today [03:49:16] legoktm: Right. [04:12:31] (03CR) 10MZMcBride: "I looked over this patch and it's in much better shape than well over 99% of patches we receive. The functionality introduced here won't e" [core] - 10https://gerrit.wikimedia.org/r/92315 (owner: 10Bartosz Dziewoński) [04:13:11] legoktm: Okay, I threw down the gauntlet. [04:13:31] A very stern "soon." [04:13:37] legoktm: Did you see my notes on mm-ch? [04:13:46] https://bugzilla.wikimedia.org/show_bug.cgi?id=68599#c1 [04:14:34] I did. [04:14:53] Oh, hi. [04:14:57] Nice. :-) [04:15:22] I didn't have much to add, just minor nitpicks. [04:15:46] re. edit notices and protection notices--I might just have to steal the code from EditPage. [04:16:14] I'm not sure those are important. [04:16:19] Well, the edit notices. [04:16:33] The protection notice might be more important. [04:17:02] I'm not sure. What I don't want to end up doing is reimplementing the entire showHeaders() (?) from EditPage [04:17:14] wctaiwan: we should just probably add a $title->userCan('edit') and display those errors? [04:17:15] which also handles cascading protection, warnings about the page being too long, and some other things. [04:17:18] You can't simply call it on your special page? [04:17:25] call it --> call the core function? [04:17:34] EditPage is terrible and very hard to extend [04:17:50] Well, [04:17:51] I can't. It uses an internal $mTitle for context [04:18:01] Lame. [04:18:18] We could expose the notices via the API. [04:18:22] <_< [04:18:33] legoktm: I already use userCan('edit'); it just doesn't _say_ what the reason you can't edit is [04:18:37] ah [04:18:41] do that then? :) [04:18:51] yeah, basically nick code from editPage. [04:19:12] If you're not duplicating code, you're doing it wrong, I always say. [04:19:31] let me check how edit notices are done.. [04:19:53] oh, it's just one line [04:20:06] so that's probably doable. [04:20:08] There are namespace edit notices. [04:20:13] And per-page edit notices. [04:20:21] Though maybe not per-page in core... [04:20:47] it's $wgOut->addHTML( implode( "\n", $this->mTitle->getEditNotices( $this->oldid ) ) ); [04:21:02] I assume Title::getEditNotices does the rest. [04:22:36] protection is http://pastebin.com/cS9vHass [04:23:14] but the chance that a delivery list would be transcluded in a high traffic page is remote enough that I think we can just ditch the second half. [04:25:35] legoktm: for the tracking category, do I just do it in fillParserOutput? [04:26:04] that seems like a good place [04:26:28] okay, just making sure it's not supposed to be a one-time thing. [04:37:47] legoktm, Carmela: what about the add pages header? [04:38:01] (I checked out the branch with it removed again at http://wiki.wctaiwan.com/wiki/Test, if you'd like to play with it) [04:39:07] lgtm [04:39:17] I don't like it :( [04:39:24] heh [04:40:25] I think a [add pages] button that expanded into that might be more obvious, but maybe that's just because Wikidata does that [04:40:55] uh, yeah, that seems kind of pointless [04:41:12] it's useful for wikidata because otherwise the whole page would look like it's being edited all the time [04:41:31] so you actually think this is better than what we had? [04:41:42] if so I guess I'll live with it. I'm not going to be dogfooding anyway >.> [04:43:25] I don't really have an opinion [04:44:25] Carmela: ? [04:45:31] (03CR) 10Robert Vogel: [C: 031 V: 031] Added a couple of missing keys for preferences [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/151632 (owner: 10Smuggli) [04:46:22] (03PS1) 10Prtksxna: Content Page: Add strings for scorecards [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151813 [04:59:23] wctaiwan: Looking. [04:59:35] (03PS3) 10Pastakhov: add bytecode cache (v 3.0.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/151810 [05:00:56] wctaiwan: It's definitely awkward with multiple lists. [05:01:13] it being the new implementation or the old one? [05:01:28] The lack of header is awkward with multiple lists. [05:01:52] With a single list, and as a part of the
    , I think it'd be less awkward. [05:02:07] Though I wonder if at the bottom of the list makes sense. [05:02:46] Does this thing support rate-limiting? [05:02:51] when I did it I saw the view as primarily a reading UI, not an editing one. [05:03:04] it goes through the edit API, which probably does throttling? [05:03:08] http://wiki.wctaiwan.com/wiki/Test [05:03:26] uh, is ratelimiting on by default? [05:03:28] I think mass message lists are inherently not reading exercises. [05:03:34] legoktm: ^^^ [05:03:40] I mean, who reads a list of subscribers? [05:03:45] If anything, you'd invert that, I think. [05:03:47] Similar to mailman. [05:03:55] Where you have only a sign up form and no long list. [05:04:26] so keep the separate section but put it at the top? [05:04:37] Maybe, yeah. [05:04:45] Or I wonder about decoupling. [05:04:49] But that seems like a treacherous path. [05:05:30] Carmela: yes it supports rate limiting. internally it goes through the action=edit API, so if that supports it, this will too [05:05:53] legoktm: I was asking what you thought about the placement of text inputs. [05:07:01] hm, forcing people to scroll all the way down for very long lists isn't super nice [05:07:15] http://wiki.wctaiwan.com/wiki/Test is longer now. [05:07:42] I'll just try putting it at the top? [05:08:01] Maybe? [05:08:07] I have to go pack, bbl [05:08:21] http://wiki.wctaiwan.com/wiki/Wikipedia_Signpost [05:08:41] yeah, seems like top would make sense [05:08:52] using anchors at the bottom of the description would be silly [05:09:19] Well, I'm also wondering about how you could de-couple the list from the form. [05:09:29] But I don't see any easy solution there. [05:10:18] my original thinking was to keep the view as a view and do all editing in the special page ( http://wctaiwan.com/mmprototype/ ) [05:10:52] but I don't think throwing out all this is a good idea at this point (and it has grown on me, somewhat) [05:10:54] I like the quick-add. [05:11:01] And I like the bulk-add. [05:11:18] I just wonder if you'd want to be able to add the quick-add form to a place without adding the list. [05:11:23] Like... transcluding, I guess. [05:11:30] Transcluding only the form. [05:12:03] http://wiki.wctaiwan.com/wiki/Talk:Wikipedia_Signpost eh. [05:12:38] uh [05:12:59] http://wiki.wctaiwan.com/w/index.php?title=Wikipedia_Signpost&action=edit will be exposed in various parts of the UI. [05:13:06] Such as "templates used on this page" and such. [05:13:16] I wonder if it should just redirect... [05:13:31] Is there ever a reason to directly edit the JSON? [05:14:00] probably not [05:14:30] why would it appear on templates used on this page? [05:15:19] If someone transcludes it. [05:15:29] I just mean that there are (edit) links around the site. [05:15:34] So ?action=edit will get hit. [05:15:42] One way or another. [05:16:52] I'm not sure we can / should redirect it. Unless you go looking for it, the main path for editing a page already redirects, and if you're looking for it, I don't think we should stop you. [05:17:14] the only problem is when people happen upon it inadvertently and get confused, but I don't think that'd happen all that frequently [05:19:13] channel chatty morning [05:22:04] Carmela: I'll take a look at transclusion; I wonder if it might be an inherent limitation of ContentHandler [05:24:02] for just transcluding the form, I suppose we could get around it by registering a tag which turns into a form for adding pages. [05:25:38] oh hm, I think I might just have to override https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/includes%2Fcontent%2FContent.php#L60 [05:32:28] (03PS1) 10Prtksxna: Use margins instead of
    s for the scorecards [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151814 [05:33:01] Carmela: what do you think should happen on transclusion? Just transclude everything? [05:33:54] I'm thinking the description and the current target list, but no editing (otherwise we'd have to load the JS on every wiki page, because you never know which page might transclude a delivery list...) [05:36:27] I'll look into making some mechanism for transcluding an add page form. [05:45:01] (03PS1) 10Prtksxna: Content Page: Add strings for the new graphs [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151815 [05:54:38] 3MediaWiki / 3Parser: RTL/bidirectional issues (tracking) - 10https://bugzilla.wikimedia.org/745 (10Amir E. Aharoni) [06:10:47] (03CR) 10Robert Vogel: [C: 04-1] BS 223: Facelift (031 comment) [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/151655 (owner: 10Tweichart) [06:16:22] 3MediaWiki extensions / 3UniversalLanguageSelector: Automated data collection for ULS input methods being activated by users - 10https://bugzilla.wikimedia.org/51349#c5 (10Mahitgar) 5RESO/FIX>3REOP Hi, Seasons Greetings End of this july at mr-wikipedia we made certain changes to support ULS users with... [06:18:28] (03CR) 10Robert Vogel: [C: 031 V: 031] Added GENDER support [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151636 (owner: 10Smuggli) [06:19:02] (03CR) 10Robert Vogel: [C: 031 V: 031] Added missing missing key for user sidebar section [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151634 (owner: 10Smuggli) [06:25:01] (03CR) 10Robert Vogel: [C: 04-1] "I know this is work in progress. I hope my comments are still usefull." (033 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151079 (owner: 10Pwirth) [06:25:22] (03CR) 10Robert Vogel: [C: 04-1] "I know this is work in progress. I hope my comments are still usefull." (038 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151797 (owner: 10Mglaser) [06:38:07] (03CR) 10Tweichart: BS 223: Facelift (031 comment) [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/151655 (owner: 10Tweichart) [06:39:21] (03CR) 10Pwirth: [WIP] UserSidebar Editing GUI (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151079 (owner: 10Pwirth) [06:45:40] 3MediaWiki extensions / 3AbuseFilter: Word boundary parameter \b not working with Unicode devanagari words - 10https://bugzilla.wikimedia.org/46773#c16 (10Mahitgar) Any good news for us on this bug, Please. [06:51:29] (03PS4) 10Pastakhov: add bytecode cache (v 3.0.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/151810 [06:55:52] (03CR) 10Santhosh: [C: 032] Moved testApertium.js to better place [services/cxserver] - 10https://gerrit.wikimedia.org/r/151603 (owner: 10KartikMistry) [06:57:07] 3MediaWiki extensions / 3BookManagerv2: Autocomplete menu for chapter list should show non-existent link in red color - 10https://bugzilla.wikimedia.org/66131#c1 (10Deepali Jain) 5NEW>3RESO/INV Marked invalid as now [[category:Book_Name]] is added on all links while creating book, so there are no non-exi... [06:57:27] (03Merged) 10jenkins-bot: Moved testApertium.js to better place [services/cxserver] - 10https://gerrit.wikimedia.org/r/151603 (owner: 10KartikMistry) [06:58:07] 3MediaWiki extensions / 3BookManagerv2: Enabling chapter list in navbar for big books causes even pages outside navigation namespaces to load slowly - 10https://bugzilla.wikimedia.org/65745 (10Deepali Jain) 5NEW>3RESO/FIX [06:58:22] 3MediaWiki extensions / 3BookManagerv2: Autocomplete menu for chapter list always shows loading gif - 10https://bugzilla.wikimedia.org/66129 (10Deepali Jain) 5NEW>3RESO/FIX [06:58:37] 3MediaWiki extensions / 3BookManagerv2: Slow formatting of chapter list in big books - 10https://bugzilla.wikimedia.org/65746 (10Deepali Jain) 5NEW>3RESO/FIX [07:03:18] (03PS1) 10Tweichart: Shoutbox Trigger + Counter [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151818 [07:16:12] (03PS3) 10Umherirrender: Migrate merge log to new log system [core] - 10https://gerrit.wikimedia.org/r/151683 [07:17:18] (03CR) 10Umherirrender: "Patch Set 3: Hide action link, when log action is deleted" [core] - 10https://gerrit.wikimedia.org/r/151683 (owner: 10Umherirrender) [07:38:32] (03PS5) 10Pastakhov: add bytecode cache (v 3.0.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/151810 [07:40:23] (03CR) 10SPQRobin: [C: 032] "Makes a lot of sense now that we have localizations in one (json) file per language." [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/150463 (owner: 10Ebe123) [07:40:31] (03Merged) 10jenkins-bot: Merge infopage and incubator i18n [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/150463 (owner: 10Ebe123) [07:48:22] 3Wikimedia / 3Site requests: Disable Media Viewer software feature by default on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69080#c13 (10anonbackupaccnt) Under the present system the WMF Board is essentially elected by the editors, not some vague group of readers. Therefore the editors ultimately... [07:58:55] (03PS2) 10Tweichart: Shoutbox Trigger + Counter [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151818 [08:01:53] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151537 (owner: 10Bsitu) [08:02:06] (03PS6) 10Pastakhov: add bytecode cache (v 3.0.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/151810 [08:03:09] (03CR) 10Siebrand: "@robin: The twn work that's to be done is basically removing the now obsolete group from the configuration in mediawiki-extensions.txt." [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/150463 (owner: 10Ebe123) [08:07:49] (03CR) 10Siebrand: [C: 031] "L10n reviewed." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/151683 (owner: 10Umherirrender) [08:09:38] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151636 (owner: 10Smuggli) [08:11:29] (03CR) 10Siebrand: [C: 031] Added a couple of missing keys for preferences (031 comment) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/151632 (owner: 10Smuggli) [08:14:38] (03PS30) 10Hashar: (WIP) Experiment zuul-cloner with extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141846 [08:14:59] (03CR) 10Hashar: "rebased" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141846 (owner: 10Hashar) [08:15:23] (03PS31) 10Hashar: (WIP) Experiment zuul-cloner with extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141846 [08:15:33] (03CR) 10Hashar: "removed mediawiki/core/vendor/swiftmailer" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141846 (owner: 10Hashar) [08:16:38] (03PS7) 10Pastakhov: add bytecode cache (v 3.0.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/151810 [08:18:37] (03PS10) 10Paladox: Vector: Fix missing tab images on Special:Preferences [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/151425 [08:18:47] (03PS9) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/92621 [08:18:49] (03CR) 10Pastakhov: [C: 032] add bytecode cache (v 3.0.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/151810 (owner: 10Pastakhov) [08:19:29] (03Merged) 10jenkins-bot: add bytecode cache (v 3.0.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/151810 (owner: 10Pastakhov) [08:20:24] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/92621 (owner: 10Hashar) [08:20:31] (03CR) 10Hashar: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/92621 (owner: 10Hashar) [08:21:51] (03CR) 10Smuggli: [C: 032 V: 032] Added GENDER support [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151636 (owner: 10Smuggli) [08:29:21] (03PS2) 10Smuggli: Added a couple of missing keys for preferences [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/151632 [08:33:58] (03CR) 10Smuggli: [C: 032 V: 032] Adding BlueSpice installer overrides for MW installer [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/150842 (owner: 10Smuggli) [08:38:05] (03CR) 10Smuggli: [C: 031 V: 031] Shoutbox Trigger + Counter [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151818 (owner: 10Tweichart) [08:43:55] (03PS1) 10Hashar: zuul: show ETA/queued time on status page [integration/docroot] - 10https://gerrit.wikimedia.org/r/151825 [08:44:21] (03CR) 10Hashar: [C: 032] zuul: show ETA/queued time on status page [integration/docroot] - 10https://gerrit.wikimedia.org/r/151825 (owner: 10Hashar) [08:44:24] (03Merged) 10jenkins-bot: zuul: show ETA/queued time on status page [integration/docroot] - 10https://gerrit.wikimedia.org/r/151825 (owner: 10Hashar) [08:48:04] (03Abandoned) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 (owner: 10Hashar) [08:48:22] (03CR) 10Hashar: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/92621 (owner: 10Hashar) [08:54:42] (03PS3) 10Tweichart: Shoutbox Trigger + Counter [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151818 [09:04:15] (03CR) 10Smuggli: [C: 04-1] Shoutbox Trigger + Counter (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151818 (owner: 10Tweichart) [09:04:40] (03PS1) 10Tweichart: Fixed line break [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151826 [09:05:53] (03CR) 10Smuggli: [C: 032 V: 032] Fixed line break [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151826 (owner: 10Tweichart) [09:09:14] (03CR) 10Tweichart: [C: 032 V: 032] BS 223: Facelift [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/151655 (owner: 10Tweichart) [09:09:31] (03PS4) 10Tweichart: Shoutbox Trigger + Counter [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151818 [09:10:10] (03CR) 10Smuggli: [C: 031 V: 031] Shoutbox Trigger + Counter [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151818 (owner: 10Tweichart) [09:10:51] (03CR) 10Tweichart: [C: 032 V: 032] Shoutbox Trigger + Counter [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151818 (owner: 10Tweichart) [09:15:08] (03PS1) 10Tweichart: BS223 Facelift: minor changes [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/151827 [09:25:39] 3MediaWiki extensions / 3[other]: NO Popup - 10https://bugzilla.wikimedia.org/69143 (10Dounia MIKOU) 3UNCO p:3Unprio s:3normal a:3None Hello, I am added a CKeditor to my wiki. But the popup does just not appear. It keeps loading and nothing results. [09:29:09] (03CR) 10Hashar: "Na it just mean I am fine with the change but not comfortable actually merging it myself :-}" [core] - 10https://gerrit.wikimedia.org/r/149005 (owner: 10Rillke) [09:31:24] (03CR) 10Smuggli: [C: 031 V: 031] BS223 Facelift: minor changes [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/151827 (owner: 10Tweichart) [09:31:42] (03PS2) 10Hashar: Make FR pass jslint [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/144479 (https://bugzilla.wikimedia.org/63117) (owner: 10Alex Monk) [09:34:52] (03CR) 10Hashar: [C: 032] Make FR pass jslint [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/144479 (https://bugzilla.wikimedia.org/63117) (owner: 10Alex Monk) [09:35:32] (03PS1) 10Hashar: mwext-FlaggedRevs-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151828 (https://bugzilla.wikimedia.org/63117) [09:35:49] (03CR) 10Hashar: [C: 032] mwext-FlaggedRevs-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151828 (https://bugzilla.wikimedia.org/63117) (owner: 10Hashar) [09:35:56] (03Merged) 10jenkins-bot: mwext-FlaggedRevs-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151828 (https://bugzilla.wikimedia.org/63117) (owner: 10Hashar) [09:36:02] (03CR) 10Tweichart: [C: 032 V: 032] BS223 Facelift: minor changes [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/151827 (owner: 10Tweichart) [09:36:04] (03Merged) 10jenkins-bot: BS223 Facelift: minor changes [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/151827 (owner: 10Tweichart) [09:36:38] 3MediaWiki extensions / 3FlaggedRevs: FlaggedRevs should pass jshint - 10https://bugzilla.wikimedia.org/63117#c6 (10Antoine "hashar" Musso) 5PATC>3RESO/FIX Thank you! [09:39:21] 3MediaWiki / 3Skin and page rendering: "view source" on Main_Page should be an edit to the sandbox - 10https://bugzilla.wikimedia.org/40240#c9 (10Antoine "hashar" Musso) 5NEW>3RESO/WON Lets close this bug entirely. I have filled it back in 2012 following a talk by someone at a Wikimedia conference. [09:41:08] (03Merged) 10jenkins-bot: Make FR pass jslint [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/144479 (https://bugzilla.wikimedia.org/63117) (owner: 10Alex Monk) [09:44:18] (03PS1) 10Hashar: Pass jshint [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/151829 (https://bugzilla.wikimedia.org/61593) [09:47:02] (03PS1) 10Smuggli: Fixed caching issue [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151830 [09:47:07] 3MediaWiki extensions / 3ZeroPortal: ZeroPortal should pass jshint - 10https://bugzilla.wikimedia.org/65818 (10Antoine "hashar" Musso) [09:47:22] 3MediaWiki extensions / 3ZeroBanner: ZeroBanner should pass jshint - 10https://bugzilla.wikimedia.org/65817 (10Antoine "hashar" Musso) [09:48:07] 3Wikimedia / 3Git/Gerrit: new extensions should be added to mediawiki/extensions.git automatically - 10https://bugzilla.wikimedia.org/46462 (10Antoine "hashar" Musso) s:5normal>3enhanc [09:48:52] 3MediaWiki extensions / 3Transliterator: Transliterator parser tests do not pass - 10https://bugzilla.wikimedia.org/49882 (10Antoine "hashar" Musso) [09:53:46] (03CR) 10Hashar: [C: 031] More jshint fixes, also add .jshintrc [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/148299 (https://bugzilla.wikimedia.org/68335) (owner: 10Legoktm) [09:56:22] 3Wikimedia / 3Bugzilla: Bugzilla component for mediawiki/services/jobrunner with appropriate default CC - 10https://bugzilla.wikimedia.org/68318#c2 (10Antoine "hashar" Musso) I would go with: MediaWiki > Jobrunner Description: Service processing MediaWiki job queue (mediawiki/services/jobrunner.git). CC: A... [09:58:07] (03PS2) 10Prtksxna: Content Page: Add strings for the new graphs [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151815 [09:58:37] 3Wikimedia / 3Bugzilla: Move MobileApp component under MediaWiki extension product - 10https://bugzilla.wikimedia.org/65964#c3 (10Antoine "hashar" Musso) That is being discussed on bug 64621, devs have the final voice. [10:01:08] 3Wikimedia / 3Fundraising: wikimedia/fundraising/dash.git should pass jshint - 10https://bugzilla.wikimedia.org/65053 (10Antoine "hashar" Musso) 5PATC>3NEW [10:03:38] 3MediaWiki / 3JavaScript: Tablesorter places sort arrows to wrong row - 10https://bugzilla.wikimedia.org/53527#c6 (10Niklas Laxström) 5RESO/FIX>3REOP Not fixed. It seems worse now. The arrows are not visible and all the input elements on the second header row cannot be interacted with. [10:05:07] 3MediaWiki extensions / 3MaintenanceShell: MainteniceShell broken in MediaWiki 1.24 - 10https://bugzilla.wikimedia.org/69075#c6 (10paladox2015) Well I went to mainteniceshell in my wiki and when I got there the list that you click to show full list already shows it fully and when trying to run update.php it... [10:05:23] 3MediaWiki extensions / 3ZeroPortal: ZeroRatedMobileAccess should pass jshint - 10https://bugzilla.wikimedia.org/61647#c2 (10Antoine "hashar" Musso) 5NEW>3RESO/WON Split to two new repositories which have their own bug reports: Bug 65817 - ZeroBanner should pass jshint Bug 65818 - ZeroPortal should pas... [10:09:23] 3MediaWiki extensions / 3Collection: Collection npm tests leak test files - 10https://bugzilla.wikimedia.org/58216#c1 (10Antoine "hashar" Musso) It would probably self fix with Bug 68563 - Jenkins: point TMP/TEMP to workspace and delete it after build completion. Added it as a dependency. [10:10:37] 3MediaWiki extensions / 3OpenStackManager: Ajax reboot link should ask for confirmation - 10https://bugzilla.wikimedia.org/50923#c4 (10Antoine "hashar" Musso) Still no popup. [10:15:00] (03PS1) 10Hashar: Support regex to match parser tests output [core] - 10https://gerrit.wikimedia.org/r/151833 [10:21:09] 3MediaWiki / 3Unit tests: phpunit failure: ParserTests::testParserTest for gallery and files with UploadWizard and data-file-* - 10https://bugzilla.wikimedia.org/68649#c4 (10Antoine "hashar" Musso) 5NEW>3RESO/DUP The issue is MultimediaViewer using a hook to inject data which I reported as bug 67302. Ma... [10:23:02] (03PS2) 10Hashar: Support regex to match parser tests output [core] - 10https://gerrit.wikimedia.org/r/151833 (https://bugzilla.wikimedia.org/67302) [10:25:34] (03PS1) 10Prtksxna: Add data for Ukranian Wikipedia in DMCA Targeted Takedowns graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151834 [10:26:53] (03CR) 10Hashar: "Another way would be to introduce a parser test option that would let one disable a specific hook such as thumbnailBeforeProduceHTML which" [core] - 10https://gerrit.wikimedia.org/r/151833 (https://bugzilla.wikimedia.org/67302) (owner: 10Hashar) [10:40:38] (03PS1) 10Hashar: Builder macro for Zuul cloner [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/151835 [10:41:36] (03PS12) 10Hashar: Use Zuul cloner to test mediawiki/core + vendor [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141819 [10:50:08] (03PS1) 10Hashar: wikimedia-fundraising-civicrm [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/151836 [10:58:54] (03PS5) 10Paladox: Update Moment.js from 2.7.0 to 2.8.1 [core] - 10https://gerrit.wikimedia.org/r/151630 [10:59:18] (03PS8) 10Paladox: WikiEditor: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 [10:59:35] (03PS7) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [11:00:52] 3Wikimedia / 3Extension setup: HotCat is not working when adding a toolbar component to common.js - Wikisource - 10https://bugzilla.wikimedia.org/69137#c1 (10Andre Klapper) 5NEW>3RESO/INV HotCat is not an extension hence this is unfortunately out of scope for Bugzilla. [11:02:38] 3MediaWiki / 3Templates: REVISIONID cannot be substituted - 10https://bugzilla.wikimedia.org/6181#c7 (10Andre Klapper) *** Bug 69138 has been marked as a duplicate of this bug. *** [11:02:38] 3MediaWiki / 3Page editing: {{subst:REVISIONID}} does not work, but {{subst:REVISIONDAY}}, {{subst:REVISIONDAY2}}, {{subst:REVISIONMONTH}}, {{subst:REVISIONYEAR}}, {{subst:REVISIONTIMESTAMP}} and {{subst:REVISIONUSER}} all work fine. This is inconsistent. - 10https://bugzilla.wikimedia.org/69138#c1 (10Andre... [11:05:07] 3MediaWiki extensions / 3UniversalLanguageSelector: Automated data collection for ULS input methods being activated by users - 10https://bugzilla.wikimedia.org/51349#c6 (10Andre Klapper) 5REOP>3RESO/FIX EventLogging is still implemented, hence closing again as FIXED. (It's possible to comment on a repo... [11:06:07] 3Wikimedia / 3Extension setup: HotCat is not working when adding a toolbar component to common.js - Wikisource - 10https://bugzilla.wikimedia.org/69137#c2 (10ineuw) Some direction on where to go to resolve this would be much appreciated. [11:11:04] (03PS1) 10Prtksxna: Correct data for bubble graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151838 [11:12:37] 3MediaWiki extensions / 3[other]: NO Popup - 10https://bugzilla.wikimedia.org/69143#c1 (10Andre Klapper) 5UNCO>3RESO/WON Hi Dounia, thanks for taking the time to report this! CKeditor has been archived and is not maintained anymore (see its homepage at [[mw:Extension:FCKeditor_%28Official%29]]. It is r... [11:13:22] 3MediaWiki extensions / 3[other]: NO Popup in CKEditor - 10https://bugzilla.wikimedia.org/69143 (10Andre Klapper) [11:15:07] 3MediaWiki extensions / 3MaintenanceShell: MainteniceShell broken in MediaWiki 1.24 - 10https://bugzilla.wikimedia.org/69075#c7 (10Andre Klapper) Last call to provide the actual full output instead of paraphrasing it... [11:18:30] (03PS4) 10Umherirrender: Migrate merge log to new log system [core] - 10https://gerrit.wikimedia.org/r/151683 [11:19:01] (03CR) 10Umherirrender: "Patch Set 4: Broke long lines" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/151683 (owner: 10Umherirrender) [11:31:26] (03PS1) 10Hashar: experiment wikimedia-fundraising-civicrm [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151839 [11:31:56] (03CR) 10Hashar: [C: 032] experiment wikimedia-fundraising-civicrm [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151839 (owner: 10Hashar) [11:32:03] (03Merged) 10jenkins-bot: experiment wikimedia-fundraising-civicrm [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151839 (owner: 10Hashar) [11:37:36] (03CR) 10Hashar: [C: 032] "it is all good :]" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/151835 (owner: 10Hashar) [11:38:52] (03Merged) 10jenkins-bot: Builder macro for Zuul cloner [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/151835 (owner: 10Hashar) [11:41:54] (03PS1) 10Hashar: Shell script for civicrm MySQL setup [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151841 [11:42:31] (03CR) 10Hashar: [C: 032] "deploying on CI production slaves with git-deploy" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151841 (owner: 10Hashar) [11:42:34] (03Merged) 10jenkins-bot: Shell script for civicrm MySQL setup [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151841 (owner: 10Hashar) [11:48:38] (03PS2) 10Hashar: wikimedia-fundraising-civicrm [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/151836 [11:59:59] (03PS1) 10Hashar: civicrm script must not use dashes for mysql DB [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151842 [12:00:08] (03CR) 10Hashar: [C: 032] civicrm script must not use dashes for mysql DB [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151842 (owner: 10Hashar) [12:00:11] (03Merged) 10jenkins-bot: civicrm script must not use dashes for mysql DB [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151842 (owner: 10Hashar) [12:09:46] (03PS1) 10Hashar: civicrm: consitent JOBID variable name [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151843 [12:09:49] (03PS1) 10Hashar: civicrm: normalize JOBID to JOB_ID [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151844 [12:10:00] (03CR) 10Hashar: [C: 032] civicrm: normalize JOBID to JOB_ID [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151844 (owner: 10Hashar) [12:10:07] (03CR) 10Hashar: [C: 032] civicrm: consitent JOBID variable name [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151843 (owner: 10Hashar) [12:10:10] (03Merged) 10jenkins-bot: civicrm: consitent JOBID variable name [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151843 (owner: 10Hashar) [12:10:13] (03Merged) 10jenkins-bot: civicrm: normalize JOBID to JOB_ID [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151844 (owner: 10Hashar) [12:21:31] (03PS1) 10Hashar: civicrm: share settings between create/drop scripts [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151846 [12:21:34] (03PS1) 10Hashar: civicrm: revoke prileges [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151847 [12:21:45] (03CR) 10Hashar: [C: 032] civicrm: share settings between create/drop scripts [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151846 (owner: 10Hashar) [12:21:48] (03Merged) 10jenkins-bot: civicrm: share settings between create/drop scripts [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151846 (owner: 10Hashar) [12:21:52] (03CR) 10Hashar: [C: 032] civicrm: revoke prileges [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151847 (owner: 10Hashar) [12:21:55] (03Merged) 10jenkins-bot: civicrm: revoke prileges [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151847 (owner: 10Hashar) [12:23:43] (03PS1) 10Hashar: civicrm: shorter mysql username [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151848 [12:23:51] (03CR) 10Hashar: [C: 032] civicrm: shorter mysql username [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151848 (owner: 10Hashar) [12:23:54] (03Merged) 10jenkins-bot: civicrm: shorter mysql username [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151848 (owner: 10Hashar) [12:28:12] (03PS1) 10Hashar: civicrm: actually drop the user [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151849 [12:28:21] (03CR) 10Hashar: [C: 032] civicrm: actually drop the user [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151849 (owner: 10Hashar) [12:28:24] (03Merged) 10jenkins-bot: civicrm: actually drop the user [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151849 (owner: 10Hashar) [12:31:56] * tonythomas wonders who is free around here to help him write his first PHP unit tests [12:40:16] any js dev around willing to help with some wikimania stuff? [12:51:38] Danny_B: o/ [12:51:56] Danny_B: What JS stuff? [12:55:26] (03PS1) 10Tweichart: BS223: Facelift [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/151851 [13:01:41] (03PS1) 10Prtksxna: Add tooltips for countries with an extra comment [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151852 [13:03:33] prtksxna: javascript ;-) [13:04:46] Danny_B: He's asking what help you need. [13:07:39] (03CR) 10Smuggli: [C: 031 V: 031] BS223: Facelift [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/151851 (owner: 10Tweichart) [13:09:38] (03CR) 10Tweichart: [C: 032 V: 032] BS223: Facelift [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/151851 (owner: 10Tweichart) [13:12:43] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 (owner: 10Bsitu) [13:12:52] (03PS2) 10Taueres: Add test cases for wfAppendQuery [core] - 10https://gerrit.wikimedia.org/r/149082 [13:13:22] 3Wikimedia / 3Extension setup: HotCat is not working when adding a toolbar component to common.js - Wikisource - 10https://bugzilla.wikimedia.org/69137#c3 (10Andre Klapper) https://en.wikisource.org/wiki/Help:Gadget-HotCat is my first guess [13:16:39] (03PS3) 10Taueres: Add test cases for wfAppendQuery [core] - 10https://gerrit.wikimedia.org/r/149082 [13:17:52] 3Wikimedia / 3Site requests: Enabling subpages on FDC wiki - 10https://bugzilla.wikimedia.org/69126 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [13:20:00] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/151683 (owner: 10Umherirrender) [13:20:01] ah, i didn't understand properly, sorry, big rush here [13:21:40] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/151632 (owner: 10Smuggli) [13:24:38] 3Wikimedia / 3Site requests: Enabling subpages on FDC wiki - 10https://bugzilla.wikimedia.org/69126#c1 (10matanya) pushed a patch: https://gerrit.wikimedia.org/r/#/c/151781/ /me wonders why the bot didn't mark this [13:26:16] (03CR) 10Smuggli: [C: 032 V: 032] Added a couple of missing keys for preferences [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/151632 (owner: 10Smuggli) [13:30:37] 3Wikimedia / 3Site requests: Change AbuseFilter settings on fa.wikipedia - 10https://bugzilla.wikimedia.org/69073#c3 (10reza1615) @John F. Lewis: Consensus is Done and finished [13:32:52] 3Wikimedia / 3Bugzilla: Add pywikibot component(s) for other scripts - 10https://bugzilla.wikimedia.org/68542#c3 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc Has bug 68514 superseded this? if not, has this been discussed with the other maintainers? +1 welcome. For general info what's needed: h... [13:35:34] (03PS3) 10Siebrand: Migrate import log to new log system [core] - 10https://gerrit.wikimedia.org/r/151701 (owner: 10Umherirrender) [13:36:37] 3Wikimedia / 3Site requests: Enabling subpages on FDC wiki - 10https://bugzilla.wikimedia.org/69126#c2 (10Andre Klapper) 5NEW>3PATC (In reply to matanya from comment #1) > /me wonders why the bot didn't mark this See https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines#Auto-linking_and_cross-... [13:43:04] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/151701 (owner: 10Umherirrender) [13:47:38] (03PS3) 10Pwirth: [WIP] UserSidebar Editing GUI [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151079 [13:49:03] (03CR) 10Addshore: "public function __get($var) {" [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [13:50:53] (03CR) 10Siebrand: "@addshore: It would clean up the scope of the variables, but not reduce the refactoring issues, which is why I think it would be a bad mov" [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [13:52:48] (03CR) 10Addshore: "In 2 versions time (or how ever long things are meant to be marked as deprecated before being removed) refactoring would be a lot easier a" [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [13:54:07] 3MediaWiki extensions / 3ZeroPortal: ZeroRatedMobileAccess should pass jshint - 10https://bugzilla.wikimedia.org/61647#c3 (10James Forrester) 5RESO/WON>3RESO/INV More like "INVALID". [13:56:51] (03CR) 10Umherirrender: "I have marked the messages as ignored, because messages like '1moved2' are also only used for irc and ignored. But I am not sure, how IRC " [core] - 10https://gerrit.wikimedia.org/r/151701 (owner: 10Umherirrender) [13:58:22] 3MediaWiki / 3Templates: REVISIONID cannot be substituted - 10https://bugzilla.wikimedia.org/6181#c8 (10James Forrester) Possibly for consistency we could disable subst:'ing of the rest of the revision-time information magic words – REVISIONDAY, REVISIONDAY2, REVISIONMONTH, REVISIONYEAR, REVISIONMTIMESTAMP,... [14:03:36] (03CR) 10Siebrand: [C: 04-1] "RELEASE-NOTES entry needs to be for 1.24." [core] - 10https://gerrit.wikimedia.org/r/110342 (https://bugzilla.wikimedia.org/60604) (owner: 10Nikerabbit) [14:24:24] (03CR) 10Siebrand: "@addshore Maybe I don't understand what your code piece does. If I reference a deprecated class property using object->property, and that " [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [14:29:09] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151665 (owner: 10Wctaiwan) [14:33:27] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/151061 (https://bugzilla.wikimedia.org/30666) (owner: 10Ebe123) [14:34:23] (03CR) 10Mwjames: "@ Reedy" [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [14:35:09] (03CR) 10Siebrand: Descriptive error on special page (031 comment) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151380 (owner: 10Wctaiwan) [14:36:48] (03CR) 10Wctaiwan: Escape invalid target strings in message (031 comment) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151665 (owner: 10Wctaiwan) [14:44:14] (03CR) 10Siebrand: [C: 032] Update links for software homepages [core] - 10https://gerrit.wikimedia.org/r/151663 (owner: 10Gerrit Patch Uploader) [14:49:09] (03Merged) 10jenkins-bot: Update links for software homepages [core] - 10https://gerrit.wikimedia.org/r/151663 (owner: 10Gerrit Patch Uploader) [14:49:11] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (031 comment) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151665 (owner: 10Wctaiwan) [15:06:48] (03CR) 10Siebrand: [C: 032] Add gender for upload log entries [core] - 10https://gerrit.wikimedia.org/r/151653 (owner: 10Umherirrender) [15:09:53] (03Merged) 10jenkins-bot: Add gender for upload log entries [core] - 10https://gerrit.wikimedia.org/r/151653 (owner: 10Umherirrender) [15:10:51] (03CR) 10Foxtrott: "@Siebrand: The first is exactly what happens: __get() is utilized for reading data from inaccessible properties." [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [15:12:03] (03PS1) 10Jack Phoenix: Fix for {{SITENAME}} being cut off in the header after scrolling down + minor color fix [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/151862 [15:12:32] (03CR) 10Jack Phoenix: [C: 032 V: 032] Fix for {{SITENAME}} being cut off in the header after scrolling down + minor color fix [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/151862 (owner: 10Jack Phoenix) [15:16:10] (03CR) 10Addshore: "@Siebrand - The former is the case. If 'foo' is the the array of deprecated vars and I call $obj->foo then a MWDebug::deprecated() warning" [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [15:20:28] (03CR) 10Foxtrott: "@Addshore: Why use parent::__get(), though? Why not just return $this->$var?" [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [15:22:32] (03CR) 10Addshore: "The correct way would be to call the parent. :) Thus I call it!" [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [15:27:49] (03CR) 10Foxtrott: "Ok. But why would that be the correct way?" [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [15:31:02] (03PS5) 10Umherirrender: Migrate merge log to new log system [core] - 10https://gerrit.wikimedia.org/r/151683 [15:31:08] (03PS1) 10Jack Phoenix: Capitalize {{SITENAME}} in the fixed header for consistency. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/151865 [15:31:16] (03CR) 10Umherirrender: "Patch Set 5: Rebased" [core] - 10https://gerrit.wikimedia.org/r/151683 (owner: 10Umherirrender) [15:31:35] (03CR) 10Jack Phoenix: [C: 032 V: 032] Capitalize {{SITENAME}} in the fixed header for consistency. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/151865 (owner: 10Jack Phoenix) [15:36:17] (03PS4) 10Umherirrender: Migrate import log to new log system [core] - 10https://gerrit.wikimedia.org/r/151701 [15:36:23] (03PS1) 10Jack Phoenix: Absolute positioning doesn't make sense here, so removing it. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/151866 [15:36:34] (03CR) 10Addshore: "In the case that the parent class also does something else in the __get method." [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [15:36:36] (03CR) 10Umherirrender: "Patch Set 4: Rebased" [core] - 10https://gerrit.wikimedia.org/r/151701 (owner: 10Umherirrender) [15:36:40] (03CR) 10Jack Phoenix: [C: 032 V: 032] Absolute positioning doesn't make sense here, so removing it. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/151866 (owner: 10Jack Phoenix) [15:40:37] (03CR) 10Foxtrott: "__get is not called for public properties." [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [15:50:09] (03CR) 10Foxtrott: "I think the solution would be to make all these properties private or protected and have __get() to access them. This would just look like" [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [15:58:29] (03PS1) 1001tonythomas: Added PHPunit tests for BounceHandler extesnsion [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151867 [16:03:34] aharoni: do you have shell access? [16:04:06] (03CR) 10MSyed: [C: 032 V: 032] dmcaRequests: Minor fixes [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151608 (owner: 10Prtksxna) [16:05:26] (03CR) 10MSyed: [C: 032 V: 032] User Data Graph: Fix yScale issues [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151609 (owner: 10Prtksxna) [16:05:59] (03CR) 10MSyed: [C: 032 V: 032] Remove emacs back up file [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151618 (owner: 10Prtksxna) [16:06:34] (03CR) 10MSyed: [C: 032 V: 032] whereFrom: Add tooltips for the labels and flags [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151619 (owner: 10Prtksxna) [16:07:04] (03CR) 10MSyed: [C: 032 V: 032] dmcaRequests: Add tooltips for labels and flags [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151620 (owner: 10Prtksxna) [16:07:21] (03CR) 10MSyed: [C: 032 V: 032] User Data Graph: Add tooltips for flags and labels [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151667 (owner: 10Prtksxna) [16:08:53] (03PS1) 10Prtksxna: Add the new FAQ for the bubble graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151868 [16:16:18] (03CR) 10Addshore: [C: 04-1] "Need to register the test using the hook." [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151867 (owner: 1001tonythomas) [16:17:24] (03PS8) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [16:17:39] (03PS9) 10Paladox: WikiEditor: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 [16:18:21] (03CR) 10MSyed: [C: 032 V: 032] Add new flags and fix country names [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151668 (owner: 10Prtksxna) [16:18:35] (03CR) 10MSyed: [C: 032 V: 032] whereFrom: Put the unknown bar at the bottom [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151669 (owner: 10Prtksxna) [16:18:37] (03PS1) 10Prtksxna: User Data Graph: Use the same xScale across filters [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151870 [16:18:52] (03CR) 10MSyed: [C: 032 V: 032] Stop showing broken image link if flag isn't available [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151670 (owner: 10Prtksxna) [16:19:04] (03CR) 10MSyed: [C: 032 V: 032] Add viewBox in flags' SVGs so that it shows up properly in Firefox [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151671 (owner: 10Prtksxna) [16:19:16] (03CR) 10MSyed: [C: 032 V: 032] Content Page: Add strings for scorecards [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151813 (owner: 10Prtksxna) [16:19:29] (03CR) 10MSyed: [C: 032 V: 032] Use margins instead of
    s for the scorecards [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151814 (owner: 10Prtksxna) [16:19:41] (03CR) 10MSyed: [C: 032 V: 032] Content Page: Add strings for the new graphs [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151815 (owner: 10Prtksxna) [16:19:53] (03CR) 10MSyed: [C: 032 V: 032] Add data for Ukranian Wikipedia in DMCA Targeted Takedowns graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151834 (owner: 10Prtksxna) [16:20:05] (03CR) 10MSyed: [C: 032 V: 032] Correct data for bubble graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151838 (owner: 10Prtksxna) [16:20:18] (03CR) 10MSyed: [C: 032 V: 032] Add tooltips for countries with an extra comment [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151852 (owner: 10Prtksxna) [16:20:29] (03CR) 10MSyed: [C: 032 V: 032] Add the new FAQ for the bubble graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151868 (owner: 10Prtksxna) [16:20:40] (03CR) 10MSyed: [C: 032 V: 032] User Data Graph: Use the same xScale across filters [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151870 (owner: 10Prtksxna) [16:23:35] (03PS2) 1001tonythomas: Added PHPunit tests for BounceHandler extesnsion [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151867 [16:23:40] (03CR) 10jenkins-bot: [V: 04-1] Added PHPunit tests for BounceHandler extesnsion [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151867 (owner: 1001tonythomas) [16:24:39] (03PS1) 10Jack Phoenix: Removed an unnecessary and potentially problematic property definition. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/151872 [16:24:58] (03CR) 10Jack Phoenix: [C: 032 V: 032] Removed an unnecessary and potentially problematic property definition. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/151872 (owner: 10Jack Phoenix) [16:25:08] (03CR) 1001tonythomas: "Looks like that was the error I too was getting. Any idea why that happens ?" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151867 (owner: 1001tonythomas) [16:26:38] (03PS2) 10BryanDavis: Add support for adding packages to composer.json [vagrant] - 10https://gerrit.wikimedia.org/r/151298 [16:27:22] (03CR) 10BryanDavis: Add support for adding packages to composer.json (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/151298 (owner: 10BryanDavis) [16:27:47] (03PS3) 1001tonythomas: Added PHPunit tests for BounceHandler extesnsion [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151867 [16:27:49] (03PS12) 10BryanDavis: Rethink multiwiki support [vagrant] - 10https://gerrit.wikimedia.org/r/149872 (https://bugzilla.wikimedia.org/68605) [16:27:54] (03CR) 10jenkins-bot: [V: 04-1] Added PHPunit tests for BounceHandler extesnsion [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151867 (owner: 1001tonythomas) [16:29:00] (03CR) 10PleaseStand: "I suspect you had HTTPS Everywhere installed and enabled when you checked the links and thus got incorrect results in some cases. However," (032 comments) [core] - 10https://gerrit.wikimedia.org/r/151663 (owner: 10Gerrit Patch Uploader) [16:29:10] (03PS1) 10MSyed: make asterisk a little smaller [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151874 [16:29:43] (03CR) 1001tonythomas: "Looks like that was some comment issues.Fixed it, but now ReflectionException: Class invalid-ip does not exist" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151867 (owner: 1001tonythomas) [16:31:54] 3MediaWiki extensions / 3OpenID: errors in log file and not working as a provider - 10https://bugzilla.wikimedia.org/69148 (10daniel) 3UNCO p:3Unprio s:3critic a:3T. Gries when tring to use this plugin as a provider it auths correctly but then just sits at the page (Special:OpenIDServer) on the wiki... [16:33:31] (03CR) 10Prtksxna: [C: 032 V: 032] make asterisk a little smaller [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151874 (owner: 10MSyed) [16:33:53] (03PS1) 10Hashar: tests: make phpunit strict [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151875 [16:33:56] (03PS1) 10Hashar: mwconf: let us override magic extension loader [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151876 [16:34:14] (03CR) 10Hashar: [C: 032] "easy / straightforward :D" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151875 (owner: 10Hashar) [16:34:17] (03Merged) 10jenkins-bot: tests: make phpunit strict [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151875 (owner: 10Hashar) [16:34:38] (03CR) 10Hashar: "This change has some test coverage but will need to be carefully checked when deployed." [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151876 (owner: 10Hashar) [16:41:40] (03PS6) 10Paladox: Update Moment.js from 2.7.0 to 2.8.1 [core] - 10https://gerrit.wikimedia.org/r/151630 [16:42:31] (03PS1) 10MSyed: Updated readme with build instructions [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151877 [16:46:47] (03PS4) 1001tonythomas: Added PHPunit tests for BounceHandler extesnsion [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151867 [16:46:53] (03CR) 10jenkins-bot: [V: 04-1] Added PHPunit tests for BounceHandler extesnsion [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151867 (owner: 1001tonythomas) [16:54:22] (03CR) 10CSteipp: "It seems odd that it can create a directory, but not a symlink... Ah, quick search looks like there have been odd permission issues with n" [core] - 10https://gerrit.wikimedia.org/r/145232 (owner: 10Aaron Schulz) [16:58:58] marxarelli: hey you there? i need some ruby foo [16:59:11] jdlrobson: sure thing [16:59:26] marxarelli: yey! so i'm in need of 2 things... [16:59:36] (03PS1) 10MSyed: Another take on build instructions [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151878 [16:59:38] thing 1) I need to write a step saying 'the user "Username" exists' [17:00:02] thing 2) I need to run on(APIPage).client.create_page('foo', 'Hello Selenium! ~~~~') as a user other than MEDIAWIKI_USER. I tried logging in first but i'm not convinced that is working [17:00:34] (03CR) 10Prtksxna: [C: 032 V: 032] Another take on build instructions [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151878 (owner: 10MSyed) [17:00:42] re 1) the step is in the Given clause? [17:00:48] marxarelli: correct [17:00:56] i have on(APIPage).client.create_account(@username, ENV["MEDIAWIKI_PASSWORD"]) [17:01:03] not that it strictly matters, but the general rule is: it's ok to use the api in the Given [17:01:12] but that throws undefined method `[]' for nil:NilClass (NoMethodError) when the user already exists [17:01:15] since it only deals with context [17:01:15] and account creation thus fails [17:01:23] 3Wikimedia / 3Extension setup: HotCat is not working when adding a toolbar component to common.js - Wikisource - 10https://bugzilla.wikimedia.org/69137#c4 (10ineuw) Thanks, Andre [17:01:39] oh, interesting [17:01:55] probably a bug in the response parsing of Client#log_in [17:03:44] i mean i can rescue NoMethodError [17:03:51] but i guess it should be something clearer marxarelli? [17:03:52] so, once my commit for action=query support (https://gerrit.wikimedia.org/r/#/c/150977/) is merged, you can just do api.meta("userinfo", uiuser: "username") [17:04:23] jdlrobson: yeah, i wouldn't depend on rescuing NoMethodError [17:04:38] marxarelli: :) [17:04:38] it will break once the bug is fixed [17:05:08] marxarelli: how can i use that patch in a repository pre-merge? [17:05:30] jdlrobson: i'm expecting it to be merged tomorrow [17:06:00] marxarelli: other thing i notice.. i can only create pages in the main namespace [17:06:00] it would have happened today, but Zeljko is out on Croatian holiday today [17:06:10] @client.create_page('User talk:foo', 'Hello Selenium! ~~~~') doesn't seem to work [17:06:19] (03PS5) 1001tonythomas: Added PHPunit tests for BounceHandler extesnsion [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151867 [17:06:26] (03CR) 10jenkins-bot: [V: 04-1] Added PHPunit tests for BounceHandler extesnsion [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151867 (owner: 1001tonythomas) [17:07:00] but @client.create_page('Talk:foo', 'Hello Selenium! ~~~~') works.. :-S [17:07:15] ohhh wait this is me being stupid.. FLow might be interfering.. [17:07:48] jdlrobson: it may be that you're being bitten by a silent failure [17:09:43] (03PS1) 10MSyed: Fixed table layout on mobile [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151879 [17:10:21] (03CR) 10Prtksxna: [C: 032 V: 032] Fixed table layout on mobile [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151879 (owner: 10MSyed) [17:11:57] (03CR) 10Prtksxna: [C: 032 V: 032] Updated readme with build instructions [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151877 (owner: 10MSyed) [17:14:27] jdlrobson: to address 2), i'm going to modify https://gerrit.wikimedia.org/r/#/c/151801/ (before it gets merged) to allow for alternative authentication [17:14:45] marxarelli: \o/ that would be awesome. Although it seems i can do this: [17:15:15] (03PS1) 10MSyed: Better styling for quotes on mobile [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151880 [17:15:27] @client = on(APIPage).client @client.log_in(@username, ENV["MEDIAWIKI_PASSWORD"]) @client.create_page('User talk:foo', 'Hello Selenium! ~~~~') [17:16:39] (03CR) 10Prtksxna: [C: 032 V: 032] Better styling for quotes on mobile [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151880 (owner: 10MSyed) [17:16:56] (03PS1) 10Prtksxna: User Data: Fix tooltip position [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151881 [17:16:58] (03PS1) 10Prtksxna: Content: Fix tooltip position [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151882 [17:17:02] jdlrobson: that will work for now [17:17:18] i'm trying to replace APIPage with something more efficient and direct [17:17:27] marxarelli: is it also possible to add 'append' support [17:17:36] we have page creation but i want to append content to an existing article [17:17:43] using on(APIPage) results in redundant auth in every step [17:17:53] (03CR) 10Odder: "Please make sure to add Bug: 12345 to the last line of your commit message so as to ensure the patch is linked from the bug & people can s" [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/151357 (owner: 10Cscott) [17:18:51] jdlrobson: yeah, we can do that. how do i create a new bugzilla project, btw? there doesn't seem to be one for the ruby api client [17:18:56] (03PS2) 10Prtksxna: User Data: Fix tooltip position [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151881 [17:18:58] (03PS2) 10Prtksxna: Content: Fix tooltip position [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151882 [17:22:17] twentyafterfour: how's the phabricator stuff coming? i'm in need of bug tracking for our ruby api client and was wondering if i should give it a go [17:23:07] marxarelli: talk to andre__ [17:23:16] i assume that's andre klapper [17:23:24] although might be another andre__ (Sorry if so :)) [17:23:26] got it [17:23:48] (03CR) 10MSyed: [C: 032 V: 032] User Data: Fix tooltip position [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151881 (owner: 10Prtksxna) [17:23:50] usually i file them against Wikimedia / Continuous Integration but a dedicated ruby product would be good [17:24:01] (03CR) 10MSyed: [C: 032 V: 032] Content: Fix tooltip position [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151882 (owner: 10Prtksxna) [17:25:22] (03CR) 10CSteipp: Add new variable article_first_contributor (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/145014 (https://bugzilla.wikimedia.org/67793) (owner: 10Liangent) [17:25:55] marxarelli: file a bug under WikiMedia/Bugzilla https://www.mediawiki.org/wiki/Bug_management/Project_Maintainers#To_add_a_project_or_component [17:29:36] Vulpix: cool, thanks [17:33:15] (03PS1) 10MSyed: Fix quotes for mobile, part 2 [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151884 [17:48:26] (03PS1) 10MSyed: Menu and top header fixes for mobile [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151886 [17:49:20] (03CR) 10Prtksxna: [C: 032 V: 032] Menu and top header fixes for mobile [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151886 (owner: 10MSyed) [17:49:24] (03CR) 10Prtksxna: [C: 032 V: 032] Fix quotes for mobile, part 2 [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151884 (owner: 10MSyed) [17:53:11] (03PS1) 10Prtksxna: Fix graphs on mobile [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151887 [17:54:01] (03PS2) 10Prtksxna: Fix graphs on mobile [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151887 [17:54:53] (03CR) 10MSyed: [C: 032 V: 032] Fix graphs on mobile [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151887 (owner: 10Prtksxna) [17:55:52] marxarelli: slowly but steady. See https://www.mediawiki.org/wiki/Phabricator/Help#Projects for hosting [17:55:53] (03PS1) 10MSyed: Fixed footer styling on mobile [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151888 [17:56:38] (03CR) 10Prtksxna: [C: 032 V: 032] Fixed footer styling on mobile [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151888 (owner: 10MSyed) [17:58:36] andre__: oh, fantastic [17:59:24] (03PS1) 10Prtksxna: Fix bubble graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151889 [17:59:59] (03CR) 10MSyed: [C: 032 V: 032] Fix bubble graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151889 (owner: 10Prtksxna) [18:02:17] (03PS1) 10MSyed: Removed unnessessary br tags [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151890 [18:02:52] (03CR) 10Prtksxna: [C: 032 V: 032] Removed unnessessary br tags [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151890 (owner: 10MSyed) [18:02:52] 3Wikimedia / 3Site requests: Add alias on ruwiki: ОУ: for Обсуждение участника - 10https://bugzilla.wikimedia.org/67844#c7 (10Tomasz W. Kozlowski) 5PATC>3RESO/FIX This has been merged and deployed ages ago. [18:03:49] ages ago? o_O [18:06:37] 3Wikimedia / 3Extension setup: Rename "Open Directory" to "DMOZ" in en.voy - 10https://bugzilla.wikimedia.org/64027#c6 (10Tomasz W. Kozlowski) 5PATC>3RESO/FIX This appears to have been fixed: DMOZ links in the sidebar are now titled "DMOZ" (with the whole page name appearing on hover). [18:08:02] (03CR) 10CSteipp: "Minor stuff inline." (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/150997 (https://bugzilla.wikimedia.org/68889) (owner: 10BryanDavis) [18:13:22] Is anyone around to check this out? it's only tiny https://gerrit.wikimedia.org/r/144273 [18:14:43] (03CR) 10Hoo man: [C: 04-1] "that's what breaks this (probably)" (033 comments) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151867 (owner: 1001tonythomas) [18:34:15] (03PS2) 10Jdlrobson: WIP: Browser tests for Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151806 [18:37:13] (03CR) 10Jdlrobson: [C: 032] Hygiene: Update method documentation & split exception to a file [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151803 (owner: 10Bsitu) [18:37:21] (03Merged) 10jenkins-bot: Hygiene: Update method documentation & split exception to a file [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151803 (owner: 10Bsitu) [18:37:51] (03PS2) 10Jdlrobson: Hygiene: More LESS cleanup in ext.echo.overlays.less [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151784 [18:37:54] (03PS1) 10MSyed: Added more spacing around elements on mobile [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151892 [18:39:01] (03CR) 10Prtksxna: [C: 032 V: 032] Added more spacing around elements on mobile [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151892 (owner: 10MSyed) [18:40:04] (03CR) 10Bsitu: [C: 032] Hygiene: More LESS cleanup in ext.echo.overlays.less [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151784 (owner: 10Jdlrobson) [18:40:12] (03Merged) 10jenkins-bot: Hygiene: More LESS cleanup in ext.echo.overlays.less [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151784 (owner: 10Jdlrobson) [18:43:19] (03PS1) 10Jdlrobson: Reduce specifity of Echo css [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151893 [18:43:37] 3Wikimedia / 3General/Unknown: Bengali Wiki projects (tracking) - 10https://bugzilla.wikimedia.org/40760 (10Jayanta Nath) [18:43:38] 3Wikimedia / 3Extension setup: Enable Extension:ShortUrl on Bengali Wikimedia Project - 10https://bugzilla.wikimedia.org/60956 (10Jayanta Nath) [18:44:48] (03CR) 10Jdlrobson: [C: 04-1] "rebase plzzz" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 (owner: 10Bsitu) [18:45:06] (03PS2) 10Jdlrobson: Reset per-user notify types for each user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151271 (owner: 10EBernhardson) [18:45:09] (03CR) 10jenkins-bot: [V: 04-1] Reset per-user notify types for each user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151271 (owner: 10EBernhardson) [18:45:18] (03CR) 10Jdlrobson: [C: 04-1] "needs rebasing" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/150486 (owner: 10EBernhardson) [18:45:21] (03CR) 10Bsitu: [C: 032] Add ability to run QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151238 (owner: 10Jdlrobson) [18:45:30] (03Merged) 10jenkins-bot: Add ability to run QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151238 (owner: 10Jdlrobson) [18:45:35] (03PS3) 10Jdlrobson: Hygiene: Move master/slave code to MWEchoDbFactory [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151272 (owner: 10EBernhardson) [18:45:38] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move master/slave code to MWEchoDbFactory [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151272 (owner: 10EBernhardson) [18:46:12] (03PS3) 10Jdlrobson: Add mw-ui-text-truncated utility class [core] - 10https://gerrit.wikimedia.org/r/151792 [18:46:14] (03PS6) 1001tonythomas: Added PHPunit tests for BounceHandler extesnsion [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151867 [18:47:02] (03CR) 1001tonythomas: "Yay! Thanks Hoo!" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151867 (owner: 1001tonythomas) [18:47:07] (03PS3) 10Jdlrobson: Add mw-ui-text-truncated to overlay and special page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151805 (owner: 10Bsitu) [18:47:17] hoo: ! yay. it passed :) https://gerrit.wikimedia.org/r/#/c/151867/ [18:47:21] (03CR) 10Jdlrobson: [C: 04-1] "-1ing until dependency is available." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151805 (owner: 10Bsitu) [18:47:51] tonythomas: Nice :) [18:49:03] (03CR) 10Fomafix: "Oh, you're right. Sorry. My fault." [core] - 10https://gerrit.wikimedia.org/r/151663 (owner: 10Gerrit Patch Uploader) [18:50:03] (03CR) 10Martineznovo: [C: 04-1] "As a suggestion, add the class name to the link instead" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/144273 (https://bugzilla.wikimedia.org/44242) (owner: 10Devanw) [18:50:32] (03PS27) 10Bsitu: Break notifications into alert and message sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 [18:50:38] (03CR) 10Hoo man: Added PHPunit tests for BounceHandler extesnsion (034 comments) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151867 (owner: 1001tonythomas) [18:52:52] 3MediaWiki extensions / 3Collection: PDF generation does not support Complex Script Wikis (e.g. Indic languages) and needs to be re-written - 10https://bugzilla.wikimedia.org/28206#c54 (10Jayanta Nath) Created attachment 16140 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16140&action=edit Bengali W... [18:55:05] (03PS1) 10MSyed: Tooltip padding fix [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151896 [18:55:48] (03CR) 10Prtksxna: [C: 032 V: 032] Tooltip padding fix [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151896 (owner: 10MSyed) [18:57:00] (03PS3) 10Jdlrobson: QA: Add browser test for sign up notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151804 [18:57:05] (03PS3) 10Jdlrobson: WIP: Browser tests for Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151806 [18:58:15] (03PS7) 1001tonythomas: Added PHPunit tests for BounceHandler extesnsion [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151867 [18:59:10] hoo: ^ looks good now ? [19:00:12] (03CR) 10Hoo man: Added PHPunit tests for BounceHandler extesnsion (031 comment) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151867 (owner: 1001tonythomas) [19:00:15] had a look [19:00:19] (03PS1) 10Prtksxna: Fix labels [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151898 [19:00:21] (03CR) 10SG: [C: 04-1] "I'm not in agreement with Jon on this. I don't think a class like this should exist to be used in markup, but rather it should be a mixin " [core] - 10https://gerrit.wikimedia.org/r/151792 (owner: 10Jdlrobson) [19:00:51] (03CR) 10MSyed: [C: 032 V: 032] Fix labels [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151898 (owner: 10Prtksxna) [19:01:14] hoo: so we just remvoe that $this->setExpectedException( 'UsageException' ); right ? [19:01:22] yeah [19:01:33] or the docs [19:01:45] I don't care which one, but one is enough [19:02:10] (03PS8) 1001tonythomas: Added PHPunit tests for BounceHandler extesnsion [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151867 [19:02:35] hoo: done :) [19:03:30] (03CR) 10Hoo man: [C: 032] "Niece one :)" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151867 (owner: 1001tonythomas) [19:03:35] (03Merged) 10jenkins-bot: Added PHPunit tests for BounceHandler extesnsion [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151867 (owner: 1001tonythomas) [19:03:54] tonythomas: Good job :) [19:04:00] hoo: ^ yay! thanks. ( my first php unit test ) [19:04:08] (03CR) 10Jdlrobson: "... and i believe any mixin without parameters is an anti-pattern as it encourages usage across various projects and leads to css bloat an" [core] - 10https://gerrit.wikimedia.org/r/151792 (owner: 10Jdlrobson) [19:05:34] (03CR) 10MaxSem: [C: 032] Pass jshint [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/151829 (https://bugzilla.wikimedia.org/61593) (owner: 10Hashar) [19:05:42] (03Merged) 10jenkins-bot: Pass jshint [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/151829 (https://bugzilla.wikimedia.org/61593) (owner: 10Hashar) [19:14:34] (03PS3) 10Bsitu: Hygiene: Cleanup mismatched function parameters warning [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151245 (owner: 10EBernhardson) [19:19:36] (03CR) 10Bsitu: [C: 04-1] Hygiene: Cleanup mismatched function parameters warning (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151245 (owner: 10EBernhardson) [19:22:24] (03PS2) 10Gerrit Patch Uploader: mediawiki.util: Deprecate mw.util.updateTooltipAccessKeys [core] - 10https://gerrit.wikimedia.org/r/148264 [19:22:26] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/148264 (owner: 10Gerrit Patch Uploader) [19:27:07] 3Wikimedia / 3Git/Gerrit: Remove repo mediawiki/extensions/ThumbParser - 10https://bugzilla.wikimedia.org/63377#c3 (10Tomasz W. Kozlowski) 5PATC>3RESO/FIX This was done ages ago. [19:30:26] (03PS6) 10leucosticte: Make log_params contain null revision rev_id and moved page ID [core] - 10https://gerrit.wikimedia.org/r/150969 (https://bugzilla.wikimedia.org/68930) [19:32:39] (03CR) 10leucosticte: Make log_params contain null revision rev_id and moved page ID (031 comment) [core] - 10https://gerrit.wikimedia.org/r/150969 (https://bugzilla.wikimedia.org/68930) (owner: 10leucosticte) [19:35:42] 3Wikimedia / 3Extension setup: Deploy Mantle extension to WMF servers - 10https://bugzilla.wikimedia.org/66094#c8 (10Tomasz W. Kozlowski) 5PATC>3RESO/FIX This was done ages ago; https://en.wikipedia.org/wiki/Special:Version reports Mantle as deployed. [19:40:54] (03CR) 10Nikerabbit: Fix quotes for mobile, part 2 (031 comment) [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151884 (owner: 10MSyed) [19:41:37] 3Wikimedia / 3Site requests: Links with language variants can't automatically jump to mobile sites - 10https://bugzilla.wikimedia.org/51753#c9 (10Tomasz W. Kozlowski) 5PATC>3RESO/FIX The link in comment 0 looks fine to me now, assuming this was fixed by the above patch. Please do feel free to reopen if t... [19:44:37] 3Wikimedia / 3Git/Gerrit: Gerrit: Auto-linking for urls should not include trailing full stop (breaking urls, 404 Error) - 10https://bugzilla.wikimedia.org/67866#c5 (10Tomasz W. Kozlowski) 5PATC>3NEW p:5Unprio>3Normal Resetting status to "NEW", as both links mentioned in comment 2 are still broken. [19:50:30] (03PS6) 10MarkTraceur: Make a Thanks UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151225 [19:54:50] (03PS6) 10MarkTraceur: Make UWU and UWUI event emitters [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150258 [19:55:59] Is anyone having problems with their extensions updating to latest master on Beta Labs? [19:56:06] GettingStarted has not updated in a while. [19:56:20] (03PS1) 10Kunalgrover05: Added Hook for ChangePageLanguage [core] - 10https://gerrit.wikimedia.org/r/151920 [19:56:47] (03CR) 10jenkins-bot: [V: 04-1] Added Hook for ChangePageLanguage [core] - 10https://gerrit.wikimedia.org/r/151920 (owner: 10Kunalgrover05) [19:58:02] (03PS1) 10Prtksxna: Add separate label for countries with * [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151933 [19:58:07] 3MediaWiki / 3General/Unknown: Convert things to use Config classes instead of globals (tracking) - 10https://bugzilla.wikimedia.org/69084 (10Andre Klapper) p:5Unprio>3Normal [19:59:03] (03PS1) 10Ori.livneh: Add build/ [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151941 [19:59:51] 3MediaWiki / 3Skin and page rendering: Minor fixes for Typography refresh: list lineheight, H1 margin, H3 fontsize, diff display - 10https://bugzilla.wikimedia.org/64653#c8 (10Tomasz W. Kozlowski) 5PATC>3NEW Patch was merged, so resetting bug status to NEW. [19:59:53] prtksxna: ping [20:00:00] ori: o/ [20:00:47] i didn't realize you were online; chasemp and i were just looking at getting TransparencyReport set up. we're not going to want to run middleman + deps in production; instead you should build locally and commit [20:01:05] the patchset above commits build/ to MASTER; it'd be cleaner to have a separate branch but i wasn't sure if that would trip you up [20:01:42] do you have a preference? (that is: build/ in master, or build/ in a 'build' branch?) [20:02:34] it's probably safer to keep it in master, because git-review is a little funky in the way it handles remote branches [20:02:46] ori: I am alright with having either. Though I think moiz would prefer it being in master [20:02:54] ok, let's go with that then [20:02:57] ori: Yeah, don't want any gerrit funk getting in our way [20:03:07] prtksxna: want to +2 https://gerrit.wikimedia.org/r/#/c/151941/ then? [20:03:10] ori: made one comment for ya fyi [20:03:22] chasemp: replied and amended :) [20:03:29] (03CR) 10Parent5446: [C: 04-1] "Needs doc/hooks.txt entry." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151920 (owner: 10Kunalgrover05) [20:03:38] ori: We might want to rebuild it after https://gerrit.wikimedia.org/r/151933 [20:03:49] ori: I'll see if moizsyed is around to +2 it [20:03:52] prtksxna: that's fine; you can rebuild and commit as often as you like [20:04:03] ori: true [20:04:33] ori: Wasn't build/ in gitignore? [20:04:56] prtksxna: i git-added with '-f' to override [20:04:57] (03CR) 10Prtksxna: [C: 032 V: 032] Add build/ [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151941 (owner: 10Ori.livneh) [20:05:09] ori: I'll just remove it the next time we build. [20:05:21] (03PS7) 10Umherirrender: Add better error message for files which exceeds $wgMaxImageArea [core] - 10https://gerrit.wikimedia.org/r/142046 [20:06:41] spagewmf, prtksxna, wanted to let you know I'm troubleshooting the styleguide generation cronjob on Tool Labs. [20:06:46] Do you know if it ever worked? [20:06:58] Is it possible it was previously running directly on tools-login rather than using jsub? [20:07:09] (03CR) 10Umherirrender: "Patch Set 7: Addressed inline comments" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/142046 (owner: 10Umherirrender) [20:07:15] superm401: I got emails telling me it was failing, but I didn't get any time to look at it because of the TransparencyReport. [20:07:44] prtksxna, no problem, I'm just wondering what caused it to break, or if it's never been running yet. [20:07:44] superm401: I've never logged into the tool labs instance… [20:07:44] superm401: thanks. I might have tried setting it up and forgotten 8-) [20:08:07] the LSG on tools hasn't auto-updated for a long time [20:08:17] (03CR) 10MSyed: [C: 032 V: 032] Add separate label for countries with * [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151933 (owner: 10Prtksxna) [20:08:31] (03PS2) 10Ebe123: (bug 47703) MIDI generation fails on Windows [extensions/Score] - 10https://gerrit.wikimedia.org/r/147015 (owner: 10Gnosygnu) [20:08:41] prtksxna: is it an issue if the site is accessible before tomorrow morning? [20:09:15] ori: hey [20:09:16] ori: I am unsure, I've called moizsyed to -dev [20:09:28] prtksxna: whats up [20:09:28] spagewmf, yeah, that's what I'm working on. Before it was cd-ing to a file (not a directory). [20:09:29] thanks [20:09:32] Now, the problem is a little more subtle. [20:09:35] moizsyed: is it an issue if the site is accessible before tomorrow morning? [20:09:49] moizsyed: you owe me a shawarma for this btw [20:09:53] ori: wait let me check [20:10:27] ori: Come here, I'll take you to Delhi to have some really nice shawarmas :) [20:10:56] prtksxna: HAHAHAHA, did ori tell you something about shawarmas [20:11:07] 3MediaWiki extensions / 3Translate: Fatal error: Call to a member function getLanguage() on a non-object WikiPageMessageGroup.php on line 138 - 10https://bugzilla.wikimedia.org/68523#c5 (10Tomasz W. Kozlowski) 5PATC>3RESO/FIX Both patches have been merged, assuming bug is fixed. Please re-open if that's... [20:11:13] moizsyed: Nope… [20:12:31] ori: hey ori, so it is a problem if the site is accessible before tomorrow morning [20:12:54] ori: can we have it up between 9:30am and 10:00am London time tomorrow morning? [20:13:07] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Regex knock on issues - 10https://bugzilla.wikimedia.org/67418#c6 (10Tomasz W. Kozlowski) 5PATC>3RESO/FIX Both patches have been merged, assuming bug is fixed. Please re-open if that's not the case. [20:14:00] ori: you there? [20:15:38] moizsyed: yes, just a sec [20:15:40] (03CR) 10Nikerabbit: [C: 031] Make sure canonical URLs are always in UTF-8 [core] - 10https://gerrit.wikimedia.org/r/151221 (https://bugzilla.wikimedia.org/69026) (owner: 10MaxSem) [20:15:43] ori: thanks! [20:19:05] moizsyed: when exactly? 9:30 or 10? [20:19:24] ori: if it can be 10 on the dot, then that'll be awesome [20:19:39] ori: 10am london time (GMT +1) [20:21:32] (03PS1) 10MSyed: Added links in the footer for Wiki Version of the report [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151960 [20:21:37] 3MediaWiki / 3Templates: REVISIONID cannot be substituted - 10https://bugzilla.wikimedia.org/6181#c9 (10GregH) Or, instead of potentially breaking who-knows how many templates and wikis that may be using subst: on those other magic words, you could leave them alone and get consistency in behaviour by fixing... [20:22:15] (03CR) 10Prtksxna: [C: 032 V: 032] Added links in the footer for Wiki Version of the report [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151960 (owner: 10MSyed) [20:23:07] (03PS12) 10CSteipp: WIP The first Selenium test: CentralAuth log in [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/125740 (owner: 10Zfilipin) [20:23:23] 3MediaWiki extensions / 3VectorBeta: CPB: user name is incorrectly aligned in RTL wikis in Firefox - 10https://bugzilla.wikimedia.org/65476#c5 (10Tomasz W. Kozlowski) 5PATC>3RESO/FIX Patch was merged, so assuming bug is fixed. Please re-open if that's not the case. [20:23:45] (03PS1) 10MSyed: updated /build [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151961 [20:24:26] (03CR) 10Prtksxna: [C: 032 V: 032] updated /build [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151961 (owner: 10MSyed) [20:24:37] 3MediaWiki extensions / 3Collection: Fatal error: Unsupported operand types in Collection.body.php on line 525 - 10https://bugzilla.wikimedia.org/60538#c6 (10Tomasz W. Kozlowski) 5PATC>3RESO/FIX Both patches have been merged, so assuming bug is fixed. Please re-open if that's not the case. [20:25:13] (03CR) 10CSteipp: "Fixed environment_variables to work with a default vagrant with centralauth role" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/125740 (owner: 10Zfilipin) [20:25:26] ori: hey is 10am GMT+1 ok? [20:25:44] moizsyed: could yo uwait a couple? [20:25:49] i'm just making sure i can set that up [20:26:01] ori: sure, thanks... i really appreciate it [20:26:09] marxarelli: ^ Those centralauth tests should work on vagrant now (whenever you feel like giving them another run, no rush) [20:26:22] 3MediaWiki extensions / 3OpenID: errors in log file and not working as a provider - 10https://bugzilla.wikimedia.org/69148#c1 (10T. Gries) thanks for reporting. Cannot help at the moment, perhaps later. Was E:OpenID working for you previously ? [20:27:37] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: When creating the index fail if dynamic scripting isn't set correctly or if elasticsearch isn't the minimum required version - 10https://bugzilla.wikimedia.org/68804#c3 (10Tomasz W. Kozlowski) 5PATC>3RESO/FIX Patch was merged, so assuming bug is fixed.... [20:31:29] (03PS1) 10PleaseStand: Indicate the actual version of HHVM in use [core] - 10https://gerrit.wikimedia.org/r/151962 [20:33:20] (03PS2) 10PleaseStand: Indicate the actual version of HHVM in use [core] - 10https://gerrit.wikimedia.org/r/151962 [20:34:07] 3MediaWiki / 3Page editing: Side-By-Side Editing needed - 10https://bugzilla.wikimedia.org/31448#c5 (10Quim Gil) (In reply to Andre Klapper from comment #4) > or you'd wait for VisualEditor which will provide this. VisualEditor has been around for some time now. [20:36:28] Nikerabbit, only +1? :P [20:36:50] MaxSem: it's scary [20:36:54] (03PS3) 10PleaseStand: Indicate the actual version of HHVM in use [core] - 10https://gerrit.wikimedia.org/r/151962 [20:36:56] lawl [20:37:14] you don't like breaking things [20:37:15] ? [20:38:32] MaxSem: no [20:40:10] in autoloader.php "This array is a global instead of a static member of AutoLoader to work around a bug in APC" anyone know what the bug was [20:40:37] doubtful by now [20:40:38] ori: how is it looking? [20:40:47] moizsyed: good, give me 5 mins to confirm [20:41:04] awesome! [20:42:42] MaxSem: do you think getHeadLinksArray is the best place to have it? [20:43:27] move it to WebRequest? [20:45:07] hmm, makes sense... [20:48:59] (03PS4) 10Jdlrobson: WIP: Browser tests for Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151806 [20:49:52] 3MediaWiki / 3Skin and page rendering: "view source" on Main_Page should be an edit to the sandbox - 10https://bugzilla.wikimedia.org/40240#c10 (10Benjamin Mako Hill) What do you mean by "filled it"? The bug as described certainly still exists. [21:00:52] 3MediaWiki / 3Skin and page rendering: "view source" on Main_Page should be an edit to the sandbox - 10https://bugzilla.wikimedia.org/40240#c11 (10Quim Gil) Hi Mako! There were many opinions and ideas shared in this report. Any thoughts to make this discussion productive, and maybe make this request implemen... [21:01:00] ori: i see nothing [21:01:22] yeah, it didn't work [21:01:22] 3MediaWiki / 3Templates: REVISIONID cannot be substituted - 10https://bugzilla.wikimedia.org/6181#c10 (10James Forrester) (In reply to GregH from comment #9) > Or, instead of potentially breaking who-knows how many templates and wikis > that may be using subst: on those other magic words, People using bad p... [21:02:03] moizsyed: it worked, just slight delay [21:02:10] YES! [21:02:11] awesome [21:02:46] oh ori [21:02:52] i need to make one slight change [21:03:05] ori: can i make an additional commit [21:03:09] moizsyed: yes [21:03:10] ori: there is a typo i need to fix [21:03:16] ori: ok cool phew! [21:03:22] moizsyed: canadian spelling, right? [21:03:39] "leftenant"! [21:04:50] (03PS1) 10MSyed: Fixed a typo [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151966 [21:05:32] (03CR) 10Prtksxna: [C: 032 V: 032] Fixed a typo [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151966 (owner: 10MSyed) [21:06:31] (03PS1) 10MSyed: updated /build [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151967 [21:07:10] (03CR) 10Prtksxna: [C: 032 V: 032] updated /build [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151967 (owner: 10MSyed) [21:07:31] ori: haha yep [21:07:39] ori: ok theres a new build folder now [21:07:46] moizsyed: already updated [21:08:54] (03CR) 10Kunalgrover05: Added Hook for ChangePageLanguage (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151920 (owner: 10Kunalgrover05) [21:09:06] ori: thanks ori, i owe you a beer! [21:09:11] ori: are you in london? [21:09:14] Thanks ori! [21:09:21] moizsyed: i will be tomorrow. but -- can you confirm 9:30 is ok? [21:11:13] (03PS2) 10Devanw: add mw-diff-* classes to view diff page header links [core] - 10https://gerrit.wikimedia.org/r/144273 (https://bugzilla.wikimedia.org/44242) [21:13:42] (03PS5) 10Jdlrobson: WIP: Browser tests for Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151806 [21:13:53] 3Wikimedia / 3Git/Gerrit: Gerrit: Auto-linking for urls should not include trailing full stop (breaking urls, 404 Error) - 10https://bugzilla.wikimedia.org/67866#c6 (10christian) (In reply to Tomasz W. Kozlowski from comment #5) > both links mentioned in comment 2 are still > broken. Yes, that's expected, a... [21:19:53] (03PS5) 10Foxtrott: Fix for Ia9baaf0b: __get() and __set() magic functions for previously public class members [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) [21:21:04] (03CR) 10Helder.wiki: add mw-diff-* classes to view diff page header links (031 comment) [core] - 10https://gerrit.wikimedia.org/r/144273 (https://bugzilla.wikimedia.org/44242) (owner: 10Devanw) [21:26:40] (03CR) 10Foxtrott: "Ok, it's a bit more complicated as previously expected, but I think I have it now." [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [21:30:27] (03PS6) 10Foxtrott: Fix for Ia9baaf0b: __get() and __set() magic functions for previously public class members [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) [21:32:22] 3MediaWiki / 3Templates: REVISIONID cannot be substituted - 10https://bugzilla.wikimedia.org/6181#c11 (10GregH) I'm not suggesting we put in the revision ID for the current edit in-progress, I understand that is difficult and not going to be fixed. So, do the next best thing: put in the revision ID for the... [21:32:29] (03CR) 10MarkTraceur: "Sorry I was a bit slow coming back to this - I don't see how the file page not existing will affect the special page. I can see that the f" [core] - 10https://gerrit.wikimedia.org/r/11063 (https://bugzilla.wikimedia.org/31313) (owner: 10MarkTraceur) [21:32:51] (03PS1) 10Bsitu: $checkmatrixOptions has an extra '-' in the key [core] - 10https://gerrit.wikimedia.org/r/151972 (https://bugzilla.wikimedia.org/69146) [21:33:30] (03CR) 10MarkTraceur: "Oh, I see what you mean - the file page already exists, then an upload happens...K, fixing." [core] - 10https://gerrit.wikimedia.org/r/11063 (https://bugzilla.wikimedia.org/31313) (owner: 10MarkTraceur) [21:38:11] (03PS3) 10Devanw: add mw-diff-* classes to view diff page header links [core] - 10https://gerrit.wikimedia.org/r/144273 (https://bugzilla.wikimedia.org/44242) [21:39:02] marxarelli: Phabricator is getting reasonably close to going into production. You're welcome to check out the test instance at fab.wmflabs.org in the meantime, it'll be a few more weeks before bugzilla gets migrated though. [21:39:51] twentyafterfour: \o/, btw [21:39:59] very excited to see this come together :) [21:40:01] twentyafterfour: got it. thanks! [21:41:15] (03CR) 10Hashar: "Bah I forgot a default .jshintrc :(" [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/151829 (https://bugzilla.wikimedia.org/61593) (owner: 10Hashar) [21:42:04] (03CR) 10Gilles: [C: 032] Make a Thanks UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151225 (owner: 10MarkTraceur) [21:42:32] (03Merged) 10jenkins-bot: Make a Thanks UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151225 (owner: 10MarkTraceur) [21:43:23] (03PS2) 10Gilles: Add controllers for each step - mostly stubs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151699 (owner: 10MarkTraceur) [21:43:50] (03CR) 10jenkins-bot: [V: 04-1] Add controllers for each step - mostly stubs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151699 (owner: 10MarkTraceur) [21:44:37] 3MediaWiki / 3Skin and page rendering: "view source" on Main_Page should be an edit to the sandbox - 10https://bugzilla.wikimedia.org/40240#c12 (10Antoine "hashar" Musso) Benjamin proposed the idea originally :-) Maybe Editor Engagement can be pointed at this idea and figure out a feature that could be A/B... [21:45:45] (03PS2) 10Gilles: Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 (owner: 10MarkTraceur) [21:46:13] (03CR) 10jenkins-bot: [V: 04-1] Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 (owner: 10MarkTraceur) [21:54:26] (03PS1) 10Bsitu: Add support for splitting notifications into alert & message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151974 [21:54:54] (03PS28) 10Bsitu: Split the overlay into alert and message sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 [21:54:57] (03PS2) 10Bsitu: Add support for splitting notifications into alert & message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151974 [21:56:53] (03CR) 10Gilles: [C: 032] Make UWU and UWUI event emitters [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150258 (owner: 10MarkTraceur) [21:57:21] (03Merged) 10jenkins-bot: Make UWU and UWUI event emitters [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150258 (owner: 10MarkTraceur) [22:03:08] 3Wikimedia / 3Media storage: Thumbnail/imagescaler (tracking) - 10https://bugzilla.wikimedia.org/41371 (10Andre Klapper) [22:07:18] (03PS1) 10Mattflaschen: LSG: Allow the style guide to build without npm present at runtime [core] - 10https://gerrit.wikimedia.org/r/151975 [22:09:18] (03CR) 10Mattflaschen: "This is a first step that should lead to fixing the Tool Labs cronjob." [core] - 10https://gerrit.wikimedia.org/r/151975 (owner: 10Mattflaschen) [22:13:58] (03PS8) 10MarkTraceur: Add preference for watching uploaded files [core] - 10https://gerrit.wikimedia.org/r/11063 (https://bugzilla.wikimedia.org/31313) [22:18:57] (03PS1) 10Jdlrobson: The first ever Echo QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151976 [22:19:06] (03CR) 10jenkins-bot: [V: 04-1] The first ever Echo QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151976 (owner: 10Jdlrobson) [22:19:07] 3MediaWiki / 3Export/Import: Special:Import needs to update site statistics - 10https://bugzilla.wikimedia.org/5703 (10Andre Klapper) [22:19:52] 3Wikimedia / 3Shop: shop.wikimedia.org should be HTTPS only - 10https://bugzilla.wikimedia.org/37790#c14 (10Andre Klapper) (In reply to Elliott Eggleston from comment #13) > Unless we want to find a new vendor or take on the responsibility of hosting > our own ecommerce site, this is a WONTFIX. Who could/wo... [22:20:07] 3MediaWiki extensions / 3CentralNotice: Internal error in ApiFormatXml exception in centralnoticequerycampaign - 10https://bugzilla.wikimedia.org/68430 (10Andre Klapper) p:5Unprio>3Normal [22:22:52] 3Wikimedia / 3General/Unknown: Special:BrokenRedirects on trwiki lists valid links - 10https://bugzilla.wikimedia.org/68211#c3 (10Andre Klapper) p:5Unprio>3Normal Greg: Do you know who could look into this or explaining what's expected or not here (plus no default CCs defined for "Redirects" or "Special... [22:23:06] 3MediaWiki extensions / 3WikiEditor: Editing too quickly causes EditWarning not to work - 10https://bugzilla.wikimedia.org/24509#c4 (10Andre Klapper) Liangent: Can this problem still be seen anywhere, or can this be closed as obsolete? [22:24:07] (03CR) 10Jdlrobson: [C: 032] Add support for splitting notifications into alert & message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151974 (owner: 10Bsitu) [22:24:16] (03Merged) 10jenkins-bot: Add support for splitting notifications into alert & message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151974 (owner: 10Bsitu) [22:24:37] 3MediaWiki / 3Installer: change in default schema for MSSQL complicates installation with PostgreSQL - 10https://bugzilla.wikimedia.org/64043#c10 (10Andre Klapper) Skizzerz: Could you shed some light on this and reply to comment 9, please? [22:25:37] 3Wikimedia / 3Site requests: Attach all broken autocreated local accounts to their global account - 10https://bugzilla.wikimedia.org/61876#c13 (10Andre Klapper) (In reply to Kunal Mehta (Legoktm) from comment #12) > Aargh. I ran migrateAccount.php --attachbroken using a list I generated 2 > days ago. I re-ge... [22:27:52] 3MediaWiki extensions / 3Math: Math: fatal errors - 10https://bugzilla.wikimedia.org/66587#c9 (10Andre Klapper) So I assume that getting https://gerrit.wikimedia.org/r/#/c/139421/ ("Re-enable all Math modes" by Reedy, which has a -1 by physikerwelt) merged is left to do here before declaring this fixed? Or... [22:30:29] (03CR) 10MarkTraceur: "Rebased." [core] - 10https://gerrit.wikimedia.org/r/11063 (https://bugzilla.wikimedia.org/31313) (owner: 10MarkTraceur) [22:30:46] (03PS1) 10MSyed: Fixed a data mistake [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151979 [22:33:21] (03PS9) 10MarkTraceur: Add preference for watching uploaded files [core] - 10https://gerrit.wikimedia.org/r/11063 (https://bugzilla.wikimedia.org/31313) [22:33:33] (03CR) 10MarkTraceur: "Fixed issue with PS7." [core] - 10https://gerrit.wikimedia.org/r/11063 (https://bugzilla.wikimedia.org/31313) (owner: 10MarkTraceur) [22:33:39] (03CR) 10MSyed: [C: 032 V: 032] Fixed a data mistake [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151979 (owner: 10MSyed) [22:34:44] (03CR) 10BryanDavis: "> I'm wondering if we should include a delete/suppress bitmap though." (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/150997 (https://bugzilla.wikimedia.org/68889) (owner: 10BryanDavis) [22:35:22] 3MediaWiki / 3Page editing: Edit conflict not detected, middle edit reverted - 10https://bugzilla.wikimedia.org/11922#c8 (10Andre Klapper) (In reply to Spinningspark from comment #7) > Do you need more examples of the error? What else can people do from the > user side to help? Adam (CC'ed): You worked on... [22:35:48] (03CR) 10MarkTraceur: "This is probably immaterial...I'll leave it open until the massive refactor patch goes in, though." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/22273 (owner: 10MarkTraceur) [22:36:07] 3MediaWiki / 3Page editing: Edit conflict detection suffers a race condition - 10https://bugzilla.wikimedia.org/56849#c17 (10Andre Klapper) (In reply to Andre Klapper from comment #16) > For the records, all patches merged or abandoned. > Not sure about the patch in comment 1 which didn't pass Jenkins. Ada... [22:38:41] (03CR) 10MarkTraceur: "This seems like it will probably have to wait until the code is a little cleaner in its structure...we'll make uploads a little more indep" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [22:40:09] (03Abandoned) 10MarkTraceur: Add mediawiki.api.query and getAndContinue [core] - 10https://gerrit.wikimedia.org/r/72844 (owner: 10MarkTraceur) [22:40:28] (03Abandoned) 10MarkTraceur: Work with the newer versions of BetaFeatures [extensions/CategorySlideShow] - 10https://gerrit.wikimedia.org/r/73917 (owner: 10MarkTraceur) [22:40:52] 3MediaWiki extensions / 3Math: Math: fatal errors - 10https://bugzilla.wikimedia.org/66587#c10 (10physikerwelt) It's blocked by https://rt.wikimedia.org/SelfService/Display.html?id=6077 [22:41:11] (03Abandoned) 10MarkTraceur: Implement agora-style checkboxes experimentally [core] - 10https://gerrit.wikimedia.org/r/74662 (owner: 10MarkTraceur) [22:42:44] (03CR) 10MarkTraceur: "I'm skeptical that this will ever be all that useful to core...I mean, it's a cool thing to have around, but most extensions won't have an" [core] - 10https://gerrit.wikimedia.org/r/75143 (owner: 10MarkTraceur) [22:48:10] (03Abandoned) 10MarkTraceur: Adding module for fetching media templates, and tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/132361 (owner: 10MarkTraceur) [22:48:24] ori, is this cirrus search? [22:48:25] (03Abandoned) 10MarkTraceur: Add method for building a template call out of a TemplateData definition [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/132397 (owner: 10MarkTraceur) [22:48:26] 1129 elastic+ 20 0 1623836 195716 0 S 3.6 19.2 0:16.94 java [22:48:30] (03CR) 10Mattflaschen: mw-ui-button: Revamp the LESS to be simpler, and improve cross-browser support (031 comment) [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [22:48:40] (03Abandoned) 10MarkTraceur: Add method for auto-building forms from TemplateData [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/132785 (owner: 10MarkTraceur) [22:48:49] (03Abandoned) 10MarkTraceur: Add config message for allowed templates [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/132792 (owner: 10MarkTraceur) [22:52:22] 3Wikimedia / 3General/Unknown: Upright of images does not work on several browsers - 10https://bugzilla.wikimedia.org/65889#c16 (10Andre Klapper) As I am still too stupid to understand the exact behavior though Juan has been patiently explaining it to me here, I am CCing C. Scott here who's been working on b... [22:52:29] jgonera: is what cirrus search? [22:52:43] that java process two lines lower [22:52:48] 1129 elastic+ 20 0 1623836 195716 0 S 3.6 19.2 0:16.94 java [22:52:51] user elastic+ [22:53:11] yes [22:53:16] I'm trying to figure out why I have to do vagrant reload every 15 minutes [22:53:31] strange, because I don't have cirrussearch enabled or any role that would depend on it [22:55:36] jgonera: do you have a file in vagrant.d called RELOAD? [22:55:37] 3MediaWiki / 3Parser: Missing whitespaces between words in article's last line on hy.wp - 10https://bugzilla.wikimedia.org/63918#c3 (10Andre Klapper) Gabriel, James: As this seems to be Parser territory, any idea who could investigate here? See summary and testcase in comment 2. [22:56:15] ori, no [22:56:37] jgonera: do you have role::gettingstarted enabled? [22:56:44] ori, no [22:57:09] when you say "I have to do vagrant reload every 15 minutes", what *exactly* do you mean? what prompts you to run reload? [22:58:30] jgonera: ^ [22:58:32] ori, every page load is 30 seconds or longer, some of them are error 503 [22:58:55] jgonera: it sounds like a bug in the cirrussearch role; it most likely doesn't clean up after itself [22:59:14] Almost no role cleans up after itself [22:59:24] actually, no role does to my knowledge [22:59:31] ori, bd808 might be, I think I activated it once [22:59:42] bd808: that may not be an issue for other roles [22:59:52] 3MediaWiki / 3Database: Allow comments longer than 255 bytes - 10https://bugzilla.wikimedia.org/4715#c65 (10Andre Klapper) Based on comment 63 and comment 64 (thanks for the analysis!) some performance input would probably be welcome here, plus having somebody driving this, in order to allow unlucky scripts... [22:59:52] bd808: but cirrus should because of the heavy resource utilization [23:00:15] ori, bd808 I'll try to dig into this a little bit more later [23:00:26] jgonera: wait [23:00:27] I just killed the process for now, I have to fix a couple of VE bugs now [23:00:30] mhm? [23:00:42] so we'd need an insure=>absent anti-role for cirrus? [23:00:44] jgonera: run 'sudo service elasticsearch stop && sudo rm -f /etc/init/elasticsearch.conf' [23:01:00] *ensure [23:01:19] ori, done [23:01:30] * Stopping Elasticsearch Server [ OK ] [23:01:38] (even though I already killed the java process) [23:01:44] bd808: no one would ever run that; we'd need some other mechanism for cleaning up that is conceptually akin to recursively-managed directories (in the way that they clean up whatever is not declared) [23:02:26] Like `vagrant destroy -f; vagrant up`, but I get your point [23:02:39] yeah, i am not inclined to come up with something fancy [23:02:42] maybe some hack for cirrus [23:03:02] * gwicke throws in a apt-get remove --purge [23:03:40] There are actually related problems with extension git checkouts not being cleaned up that a destroy doesn't handle either [23:03:55] gwicke: the issue is that role removal doesn't register as an explicit action as far as puppet is concerned; removing a role simply removes the declaration, meaning puppet no longer manages the relevant software components at all [23:04:06] ori: I know [23:04:24] it's one of the things I dislike about using puppet as a packaging mechanism [23:04:29] (03CR) 10BryanDavis: [C: 031] "I like the idea of this a lot. I only tested Special:Verison and ." [core] - 10https://gerrit.wikimedia.org/r/151962 (owner: 10PleaseStand) [23:05:05] gwicke: nod [23:05:49] Puppet isn't packaging, it's configuration management [23:08:08] ori, bd808 should I file a bug about this particular case for reference? [23:08:18] jgonera: Yes please [23:08:42] It is worth trying to find a reasonable solution for [23:12:14] bd808: giuseppe's puppet compiler can output a diff of a host's catalog pre/post application of some patch [23:12:32] if that's not expensive to generate, maybe the removal of role classes could be acted on somehow [23:13:01] though i dunno, maybe we should just add an exec that kills elastic if the cirrussearch isn't loaded and call it a day [23:13:02] bd808, https://bugzilla.wikimedia.org/show_bug.cgi?id=69158 [23:13:09] 3MediaWiki-Vagrant: cirrussearch role doesn't clean up after itself - 10https://bugzilla.wikimedia.org/69158 (10Juliusz Gonera) 3NEW p:3Unprio s:3normal a:3Ori Livneh If you enable cirrussearch role, you're stuck with elastic search server hogging your resources forever, even after cirrussearch role is... [23:13:17] jgonera: thanks [23:14:04] (03PS1) 10Jdlrobson: Split buildOverlay into smaller functions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151981 [23:14:07] (03PS1) 10Jdlrobson: Refactor out mark as read button code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151982 [23:14:10] (03PS1) 10Jdlrobson: Hygiene: Add _getFooterElement method [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151983 [23:14:14] (03CR) 10jenkins-bot: [V: 04-1] Split buildOverlay into smaller functions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151981 (owner: 10Jdlrobson) [23:14:21] (03CR) 10jenkins-bot: [V: 04-1] Refactor out mark as read button code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151982 (owner: 10Jdlrobson) [23:14:27] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Add _getFooterElement method [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151983 (owner: 10Jdlrobson) [23:15:10] I prefer Geppetto's puppet :) [23:15:12] bd808: care to change your -1 of https://gerrit.wikimedia.org/r/#/c/147321/ ? [23:15:21] * bd808 looks [23:15:30] spagewmf: http://cloudsmith.github.io/geppetto/ [23:17:23] ori: modules/beta/files/wmf-beta-scap still has /usr/local/bin/scap [23:19:40] I'm also not sure that deployment-bastion and deployment-rsync apply mediawiki::sync which sets the new search path. [23:22:04] ori: Apparently deployment-bastion and deployment-rsync do apply mediawiki::sync. So just the wmf-beta-scap fix is needed [23:22:18] * bd808 needs to sleep now or tomorrow will be hellish [23:23:22] 3MediaWiki-Vagrant: cirrussearch role doesn't clean up after itself - 10https://bugzilla.wikimedia.org/69158#c1 (10Bryan Davis) [00:12] < ori> bd808: giuseppe's puppet compiler can output a diff of a host's catalog pre/post application of some patch [00:12] < ori> if that's not expensive to... [23:24:18] ori, bd808 it seems like I'm still running out of memory in the virtual machine. I got "-bash: fork: Cannot allocate memory" when trying to run a command in vagrant ssh [23:24:27] are you guys running with the default of 1GB? [23:25:29] jgonera: I think I have cirrus installed on most of my vms so I get the memory bump it gives [23:25:48] and it bumps it to 1.5GB? [23:26:42] jgonera: 2G [23:26:48] (03CR) 10Bartosz Dziewoński: [C: 032] More jshint fixes, also add .jshintrc [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/148299 (https://bugzilla.wikimedia.org/68335) (owner: 10Legoktm) [23:26:50] (03Merged) 10jenkins-bot: More jshint fixes, also add .jshintrc [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/148299 (https://bugzilla.wikimedia.org/68335) (owner: 10Legoktm) [23:27:13] bd808, ok, I'll try to bump it to 1.5GB without cirrus and see if things work better [23:27:43] when IE10 and 11 make API GET requests for Flow, mw.org and beta labs often respond with 304 Not Modified. So IE displays stale content. The same API GET requests in Firefox don't get a 304 response. Any ideas? [23:30:44] (03CR) 10Bartosz Dziewoński: [C: 031] Fix spelling and make category desc consistent [core] - 10https://gerrit.wikimedia.org/r/151612 (owner: 10Siebrand) [23:34:37] 3MediaWiki / 3Special pages: Special:BlockList displays 500 items instead of default 50 - 10https://bugzilla.wikimedia.org/69132#c1 (10Florian) 5NEW>3UNCO Hmm, can't reproduce in local test environment with 1.24 master and not on mediawiki.org: https://www.mediawiki.org/wiki/Special:BlockList Have you a... [23:34:52] (03PS1) 10Jdlrobson: Hygiene: Move code for header into _getTitleElement [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151984 [23:35:03] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move code for header into _getTitleElement [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151984 (owner: 10Jdlrobson) [23:37:50] (03PS2) 10Jdlrobson: The first ever Echo QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151976 [23:39:04] (03PS2) 10Jdlrobson: Hygiene: Split buildOverlay into smaller functions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151981 [23:39:07] (03PS3) 10Jdlrobson: Hygiene: Split buildOverlay into smaller functions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151981 [23:39:19] (03PS2) 10Jdlrobson: Hygiene: Refactor out mark as read button code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151982 [23:39:22] (03PS3) 10Jdlrobson: Hygiene: Refactor out mark as read button code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151982 [23:39:27] (03PS2) 10Jdlrobson: Hygiene: Add _getFooterElement method [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151983 [23:39:31] (03PS2) 10Jdlrobson: Hygiene: Move code for header into _getTitleElement [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151984