[00:00:07] GoogleLogin::externalLoginAttempt [00:00:17] > @todo: kill if better solution as AuthPlugin is found [00:00:36] AuthPlugin is even less flexible than SpecialPages >.> [00:01:26] legoktm: If you have a good solution to go into login process in an early point? I have not way found :( (maybe i don't give it enough time) [00:01:51] the main problem is to check if the user clicked Login with Google or "normal" Login button [00:02:01] no, AuthPlugin is just terrible [00:02:15] i know :D [00:02:19] there's an RfC to fix it (https://www.mediawiki.org/wiki/Requests_for_comment/AuthStack), but stalled due to lack of time by interested people [00:02:58] (03PS1) 10Legoktm: SpecialMovepage: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151553 [00:03:11] but for now the best "easy" solution is wgOut and AuthPlugin (unhappily) [00:04:09] yeah :( [00:04:26] but back to the main question :D [00:04:44] so, probably not [00:05:15] you're going to london right? [00:05:21] yeah [00:05:35] But there are configuration options for this Extension, for which i can use Config object, or not? [00:05:43] withoutaname: unhappily not :( [00:06:05] FlorianSW: yeah, probably [00:06:45] oh maybe [00:07:44] FlorianSW: yeah you could do it [00:07:51] might be a bit awkward though [00:08:12] legoktm: in which context? [00:08:40] you'll end up with a lot of ConfigFactory::getDefaultInstance()->makeConfig( 'googlelogin' ) where your functions are static [00:10:40] it's probably doable, and would be a good experiment [00:10:55] if you can't, probably means something in your ext or core needs to be refactored ;) [00:11:33] (03PS1) 10Legoktm: SpecialMyLanguage: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151555 [00:11:40] :D Yeah, maybe time to rethink the direct implementation of Hooks to the GoogleLogin class context. This would solve this problem. [00:12:36] 3MediaWiki / 3Templates: Templates should show parameters when not expanded due to preprocessor node count limit - 10https://bugzilla.wikimedia.org/7043 (10Andre Klapper) [00:13:07] 3Wikimedia / 3General/Unknown: Provide non-manual HTML/CSS minimizing for Www.wikipedia.org_template on Meta - 10https://bugzilla.wikimedia.org/65276#c5 (10Andre Klapper) Yishen: Have you asked on https://meta.wikimedia.org/wiki/Talk:Www.wikipedia.org_template ? [00:13:36] legoktm: thanks for your talk :) I go sleep now :P [00:13:37] 3Wikimedia / 3Deployment systems: Manage mediawiki-config/php symlink automatically - 10https://bugzilla.wikimedia.org/64748#c8 (10Andre Klapper) Bryan, Reedy: So can this ticket be closed as FIXED, or what's left? All patches merged... [00:13:42] :) [00:13:51] (03PS6) 10BryanDavis: Switch jobrunner to JSON config [vagrant] - 10https://gerrit.wikimedia.org/r/150243 (https://bugzilla.wikimedia.org/68785) (owner: 10MaxSem) [00:13:53] 3MediaWiki / 3General/Unknown: case sensitivity issues (tracking) - 10https://bugzilla.wikimedia.org/3950 (10Andre Klapper) 5NEW>3RESO/WOR [00:14:01] FlorianSW: add me as a reviewer if you choose to do it [00:14:07] 3MediaWiki / 3General/Unknown: Missing Indexes, Inefficient queries and alike (tracking) - 10https://bugzilla.wikimedia.org/26394#c2 (10Andre Klapper) Reedy: Is anybody actually "tracking" this, seeing four tickets before #30000 as dependencies? Missing indexes sounds like "MediaWiki > Database" with "schem... [00:14:42] (03CR) 10BryanDavis: Switch jobrunner to JSON config (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/150243 (https://bugzilla.wikimedia.org/68785) (owner: 10MaxSem) [00:14:48] legoktm: ok, will do a bug for tracking, too and add you to cc list if i forgot to add you in gerrit, feel free to do it by yourself (hope that i don't forget ist :P) :) [00:14:49] (03PS1) 10Legoktm: SpecialNewImages: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151556 [00:15:02] ist -> it [00:15:12] have it block https://bugzilla.wikimedia.org/show_bug.cgi?id=69084 [00:15:22] 3Wikimedia / 3General/Unknown: Math related warnings in l10nupdate on 1.24wmf9 - 10https://bugzilla.wikimedia.org/66586#c4 (10Andre Klapper) Anybody knows if we still face this issue and see those warnings? Reedy? [00:15:37] 3MediaWiki / 3Database: ApiQueryExtLinksUsage::run query has crazy limit - 10https://bugzilla.wikimedia.org/57176#c11 (10Andre Klapper) Sean: How does anomie's proposal in comment 7 sound? [00:15:46] (03PS1) 10Withoutaname: Move SubmitAction class to separate page [core] - 10https://gerrit.wikimedia.org/r/151557 [00:16:33] legoktm: ah, great :) [00:20:39] 3MediaWiki extensions / 3ContributionScores: Database error: Uncommited DB writes (with SQLite backend) - 10https://bugzilla.wikimedia.org/67842#c3 (10Andre Klapper) > since I cannot use the Extension in this case Can you explain why and how you cannot use it? Asking as it's not an "error" technically, but... [00:20:40] 3MediaWiki / 3General/Unknown: Missing Indexes, Inefficient queries and alike (tracking) - 10https://bugzilla.wikimedia.org/26394#c3 (10Bawolff (Brian Wolff)) (In reply to Andre Klapper from comment #2) > Reedy: Is anybody actually "tracking" this, seeing four tickets before > #30000 as dependencies? Not a... [00:20:42] 3MediaWiki extensions / 3GoogleLogin: Use Config object instead of globals - 10https://bugzilla.wikimedia.org/69086 (10Florian) 3NEW p:3Unprio s:3normal a:3None With MW 1.23 a new Configuration class was implemented to access configuration variables/options instead of using "global $wg...": https://w... [00:20:49] (03PS1) 10Legoktm: SpecialNewPages: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151558 [00:20:52] 3MediaWiki / 3Page deletion: Develop countermeasures to the merge page histories attack - 10https://bugzilla.wikimedia.org/69047#c5 (10Nathan Larson) Proof of concept for (one possible way of) reversing these attacks is [[Extension:MoveRevisions]]. [00:21:07] 3MediaWiki / 3General/Unknown: Add GetActionLinks hook to DeleteLogFormatter::getActionLinks() - 10https://bugzilla.wikimedia.org/69085 (10Andre Klapper) p:5Unprio>3Normal [00:21:13] (03PS2) 10Withoutaname: Move SubmitAction class to separate page [core] - 10https://gerrit.wikimedia.org/r/151557 [00:21:22] 3MediaWiki / 3Page deletion: Develop countermeasures to the merge page histories attack - 10https://bugzilla.wikimedia.org/69047#c6 (10Nathan Larson) Er, [[mw:Extension:MoveRevisions]], rather. [00:22:23] 3MediaWiki / 3General/Unknown: Convert things to use Config classes instead of globals (tracking) - 10https://bugzilla.wikimedia.org/69084 (10Florian) [00:22:23] 3MediaWiki extensions / 3GoogleLogin: Use Config object instead of globals - 10https://bugzilla.wikimedia.org/69086#c1 (10Florian) Phabricator (copy): http://fab.wmflabs.org/T518 [00:22:38] (03PS1) 10Legoktm: SpecialPageLanguage: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151559 [00:23:52] what is ZhConversion.php [00:24:14] Its related to variant conversion for chinese [00:24:28] e.g. between traditional and simplified chinese [00:24:31] why isn't it in the variants folder then [00:25:04] probably someone didn't move it [00:25:17] People are constantly changing around the file layout in mediawiki, and then missing things [00:27:27] (03PS1) 10Legoktm: SpecialPasswordReset: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151560 [00:28:50] (03PS1) 10Legoktm: SpecialProtectedPages: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151561 [00:29:23] 3Wikimedia / 3Deployment systems: Manage mediawiki-config/php symlink automatically - 10https://bugzilla.wikimedia.org/64748#c9 (10Bryan Davis) 5PATC>3RESO/FIX Looks like the Tuesday train deploy is changing this link now: https://github.com/wikimedia/operations-mediawiki-config/commit/d2386817a8b8ce961b... [00:29:41] (03PS1) 10Legoktm: Pass a real IContextSource to ProtectedTitlesPager [core] - 10https://gerrit.wikimedia.org/r/151562 [00:30:40] Special:FewestRevisions excludes pages with 1 revision. that sounds odd [00:30:58] (03PS1) 10Legoktm: SpecialProtectedTitles: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151563 [00:31:45] (03PS1) 10Legoktm: SpecialRandomInCategory: Use wfScript() instead of global [core] - 10https://gerrit.wikimedia.org/r/151564 [00:32:54] 3MediaWiki / 3Special pages: Special:Fewestrevisions has a very expensive query that filesorts and uses a temporary table - 10https://bugzilla.wikimedia.org/27938#c4 (10Bawolff (Brian Wolff)) 5NEW>3RESO/WON (In reply to db from comment #3) > (In reply to comment #2) > > That's why it's marked as expensiv... [00:34:04] (03Abandoned) 10BryanDavis: UGLYHACKK: Make labs-vagrant work again (temp) [vagrant] - 10https://gerrit.wikimedia.org/r/139069 (owner: 10Yuvipanda) [00:34:06] wait [00:34:12] how is wgTitle initialized [00:34:23] setup.php sets it to null, so there must be something else providing a title object [00:34:30] probably somewhere in MediaWiki.php [00:34:55] ok wow [00:35:37] withoutaname: Its dark magic [00:36:01] 2spooky [00:36:12] (03PS1) 10Legoktm: SpecialRecentChanges: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151565 [00:37:53] (03PS1) 10Legoktm: SpecialResetTokens: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151566 [00:39:08] ok, I think I'm done for today. [00:41:24] https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/core+topic:conf,n,z [00:43:07] 3MediaWiki / 3General/Unknown: Convert things to use Config classes instead of globals (tracking) - 10https://bugzilla.wikimedia.org/69084 (10Kunal Mehta (Legoktm)) [00:43:53] 3MediaWiki / 3General/Unknown: Convert things to use Config classes instead of globals (tracking) - 10https://bugzilla.wikimedia.org/69084 (10Kunal Mehta (Legoktm)) [00:43:55] 3MediaWiki / 3Special pages: Special:Block: Use Config instead of globals - 10https://bugzilla.wikimedia.org/69087 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None There are a lot of static funcitons in SpecialBlock so that the API can also re-use the same code which makes this difficult. M... [00:44:07] 3Wikimedia / 3Deployment systems: Either undo php->php-1.xx symlink messiness, or automate archiving of old MediaWiki versions - 10https://bugzilla.wikimedia.org/36363#c5 (10Andre Klapper) 5NEW>3RESO/FIX (In reply to Bryan Davis from comment #4) > I think this can be closed once bug 64748 has been verifi... [00:44:52] 3MediaWiki / 3Unit tests: Gerrit 146683 broke `php tests/parserTests.php`. - 10https://bugzilla.wikimedia.org/69082 (10Andre Klapper) p:5Unprio>3High [00:47:22] 3MediaWiki extensions / 3AbuseFilter: AbuseFilter: PHP Catchable fatal error: Argument 1 passed to RequestContext::setTitle() must be an instance of Title, null given, called in AbuseFilter.class.php on - 10https://bugzilla.wikimedia.org/55435#c15 (10Andre Klapper) Reedy or anybody: Does this still happen o... [00:51:22] 3MediaWiki extensions / 3PackageForce: Extension:Packageforce does not create its additional tables. - 10https://bugzilla.wikimedia.org/25565#c7 (10Andre Klapper) p:5Normal>3Low Svip: So is this extension still maintained, or should the category https://www.mediawiki.org/wiki/Category:Obsolete_extensions... [00:54:22] 3Wikimedia / 3General/Unknown: Commons connectivity issue in Hong-Kong - 10https://bugzilla.wikimedia.org/60283#c30 (10Andre Klapper) (In reply to Faidon Liambotis from comment #29) > it'd be interesting to hear if Deryck still has issues (if ever). Deryck: ping? [00:58:17] (03PS1) 10Theaitetos: speed up revision-based queries (not)createdby and (not)modifiedby [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/151567 [01:12:01] importsources should be an object [01:12:07] not a config [01:13:41] legoktm: how many RFCs are there? what is required to start one [01:44:09] 3MediaWiki extensions / 3CentralNotice: CentralNotice filter produces useless URLs - 10https://bugzilla.wikimedia.org/53753 (10Andrew Green) a:3Andrew Green [01:45:00] (03PS1) 10Legoktm: Add getPassword/getTemporaryPassword accessors to User [core] - 10https://gerrit.wikimedia.org/r/151569 [01:45:54] (03CR) 10Legoktm: "See discussion on bug 68843." [core] - 10https://gerrit.wikimedia.org/r/151569 (owner: 10Legoktm) [01:48:52] 3MediaWiki extensions / 3MassMessage: MassMessage::getMessengerUser() takeover broken due to Password API changes - 10https://bugzilla.wikimedia.org/68843#c7 (10Kunal Mehta (Legoktm)) 5NEW>3PATC (In reply to Tyler Romeo from comment #6) > (In reply to Kunal Mehta (Legoktm) from comment #5) > > * Make loa... [02:17:41] (03CR) 10BryanDavis: [C: 04-1] "I figured out what I did to break role::commons. I messed up the settings directory naming convention by using wiki name (eg commons) in p" [vagrant] - 10https://gerrit.wikimedia.org/r/149872 (https://bugzilla.wikimedia.org/68605) (owner: 10BryanDavis) [02:18:40] (03CR) 10BryanDavis: [C: 031] "I think this is good to go now, but it needs the git::install patch that I made and rebased it on." [vagrant] - 10https://gerrit.wikimedia.org/r/150243 (https://bugzilla.wikimedia.org/68785) (owner: 10MaxSem) [02:49:08] Anyone know about this git-review error: http://p.defau.lt/?rEn7HPTLICKksFz682TJ2w ? [02:49:14] I'm running OS X 10.8. [02:50:43] Carmela: https://bugs.launchpad.net/git-review/+bug/1337701 ? [02:52:22] Carmela: See also http://www.gossamer-threads.com/lists/wiki/wikitech/481791 [02:52:49] Ah, beautiful. [02:52:50] I'll try that out. [02:53:39] Seems better now. Thanks! [02:54:05] I had looked at a few sites last week and they were recommending upgrading Xcode and such. [02:54:51] Yuck. That should always be a last resort option. [02:55:14] ikr [02:55:23] It was an enjoyable 2GB+ download. [03:08:08] (03CR) 10Parent5446: [C: 032] Add getPassword/getTemporaryPassword accessors to User [core] - 10https://gerrit.wikimedia.org/r/151569 (owner: 10Legoktm) [03:09:59] (03CR) 10Legoktm: [C: 032] Improve edit summaries [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151390 (owner: 10Wctaiwan) [03:10:11] (03Merged) 10jenkins-bot: Improve edit summaries [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151390 (owner: 10Wctaiwan) [03:10:37] (03Merged) 10jenkins-bot: Add getPassword/getTemporaryPassword accessors to User [core] - 10https://gerrit.wikimedia.org/r/151569 (owner: 10Legoktm) [03:14:51] 3MediaWiki extensions / 3MassMessage: Use ContentHandler based spamlist for MassMessage instead of parserfunction - 10https://bugzilla.wikimedia.org/61255#c4 (10Kunal Mehta (Legoktm)) The other way around I think. [03:15:06] 3MediaWiki extensions / 3MassMessage: MassMessage: Bugs related to contenthandler branch (tracking) - 10https://bugzilla.wikimedia.org/68599 (10Kunal Mehta (Legoktm)) [03:18:47] (03PS1) 10Legoktm: Fix MassMessage::getMessengerUser() after Password API changes [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/151570 (https://bugzilla.wikimedia.org/68843) [03:20:10] (03CR) 10Legoktm: [C: 032 V: 032] Don't require PHP 5.4+ [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/150789 (https://bugzilla.wikimedia.org/68855) (owner: 10Jack Phoenix) [03:23:57] (03PS1) 10Gnosygnu: v1.8.1.1 [xowa] - 10https://gerrit.wikimedia.org/r/151571 [03:23:59] (03CR) 10Wctaiwan: [C: 031] "Looks good to me." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/151570 (https://bugzilla.wikimedia.org/68843) (owner: 10Legoktm) [03:29:31] (03PS1) 10Jack Phoenix: Pass in the login token so that logging in actually works. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/151572 [03:33:17] (03CR) 10Gnosygnu: [C: 032 V: 032] "changes for v1.8.1 build" [xowa] - 10https://gerrit.wikimedia.org/r/151571 (owner: 10Gnosygnu) [03:33:53] 3MediaWiki extensions / 3MediaWikiAuth: PHP Parse error: syntax error, unexpected '[' in extensions/MediaWikiAuth/MediaWikiAuth.php on line 283 - 10https://bugzilla.wikimedia.org/68855 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Jack Phoenix [03:42:04] (03CR) 10Jack Phoenix: [C: 032 V: 032] Pass in the login token so that logging in actually works. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/151572 (owner: 10Jack Phoenix) [04:01:57] (03PS8) 10BryanDavis: Rethink multiwiki support [vagrant] - 10https://gerrit.wikimedia.org/r/149872 (https://bugzilla.wikimedia.org/68605) [04:08:18] (03PS3) 10Withoutaname: LayeredParameterizedPassword: Move code from partialCrypt() to crypt() [core] - 10https://gerrit.wikimedia.org/r/150839 [04:08:55] (03CR) 10BryanDavis: "I fixed the problem with settings.d, but the non-commons wikis are still not picking up File resources from commons via the $wgForeignFile" [vagrant] - 10https://gerrit.wikimedia.org/r/149872 (https://bugzilla.wikimedia.org/68605) (owner: 10BryanDavis) [04:10:07] 3MediaWiki extensions / 3SemanticForms: "Create pages with form" and sfEditFormPreloadText - 10https://bugzilla.wikimedia.org/56569#c17 (10cariaso) I spent some time looking at this, and am confident that the function which is hooked to 'sfEditFormPreloadText' is being called for existing pages is _not_ be... [04:35:08] (03PS1) 10Pastakhov: fix Hooks::callSetStaticProperty() (v 2.8.4) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/151575 [04:36:10] (03CR) 10Pastakhov: [C: 032] fix Hooks::callSetStaticProperty() (v 2.8.4) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/151575 (owner: 10Pastakhov) [04:36:16] (03Merged) 10jenkins-bot: fix Hooks::callSetStaticProperty() (v 2.8.4) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/151575 (owner: 10Pastakhov) [04:37:51] 3MediaWiki extensions / 3SemanticForms: "Create pages with form" and sfEditFormPreloadText - 10https://bugzilla.wikimedia.org/56569#c18 (10cariaso) The problem originates near SF_FormEditAction.php Line 157 static function displayForm( $action, $article ) { // @todo: This looks like bad code. I... [04:51:31] (03PS4) 10Withoutaname: LayeredParameterizedPassword: Move code from partialCrypt() to crypt() [core] - 10https://gerrit.wikimedia.org/r/150839 [04:54:37] 3MediaWiki extensions / 3MassMessage: MassMessage: Bugs related to contenthandler branch (tracking) - 10https://bugzilla.wikimedia.org/68599 (10MZMcBride) [04:57:43] wctaiwan: Yo. [04:58:04] legoktm: http://mm-ch.wmflabs.org/wiki/File:List_title.jpg [04:58:45] legoktm: Titleblacklist isn't installed there, but I'd like to know if it bypasses that as well. [04:58:49] heh. [04:58:54] Well, [04:58:54] No, it won't bypass titleblacklist. [04:58:58] if it's admin-only, I guess it doesn't matter. [04:58:59] Let me install it [04:59:10] it's not admin only [04:59:36] Input validation seems weak. [04:59:42] for being the wiki anyone can edit, you sure got a lot of extensions prohibiting it [04:59:45] For the text inputs at http://mm-ch.wmflabs.org/wiki/Special:CreateMassMessageList [05:00:19] what should it validate? [05:00:19] withoutaname: It turns out that "anyone" includes a lot of shitty people. [05:00:21] mm-ch? [05:00:27] MassMessage ContentHandler [05:00:35] of course. [05:00:37] (03PS1) 10Pastakhov: fix exception of access to undefined static property (v 2.8.5) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/151577 [05:00:41] https://bugzilla.wikimedia.org/show_bug.cgi?id=61255 [05:00:43] Of course. [05:01:02] (03PS9) 10BryanDavis: Rethink multiwiki support [vagrant] - 10https://gerrit.wikimedia.org/r/149872 (https://bugzilla.wikimedia.org/68605) [05:01:08] (03CR) 10Pastakhov: [C: 032] fix exception of access to undefined static property (v 2.8.5) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/151577 (owner: 10Pastakhov) [05:01:14] (03Merged) 10jenkins-bot: fix exception of access to undefined static property (v 2.8.5) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/151577 (owner: 10Pastakhov) [05:01:40] wctaiwan: I don't think pages such as http://mm-ch.wmflabs.org/wiki/File:List_title.jpg should be able to be created. [05:01:44] That seems a bit goofy. [05:01:54] installed TitleBlacklist [05:02:01] Thx. [05:03:19] contenthandler doesn't restrict content models to specific namespaces, maybe we should? [05:03:51] Carmela: all edits ultimately go through edit API, so the things that are checked are probably exactly what the edit API validates [05:04:04] (03PS10) 10BryanDavis: Rethink multiwiki support [vagrant] - 10https://gerrit.wikimedia.org/r/149872 (https://bugzilla.wikimedia.org/68605) [05:04:16] legoktm: I don't think so; delivery lists might be subpages (signpost), etc. [05:04:33] Subpages aren't the same as File or Category pages. [05:04:35] Hmm. [05:04:59] http://mm-ch.wmflabs.org/wiki/MediaWiki:File:List_title.jpg [05:05:02] ;-) [05:05:08] Oh, I'm an admin. [05:05:11] That's not as fun. [05:05:20] I should probably test with a non-admin account. [05:05:34] "You do not have permission to create a list at this title." [05:05:47] for someone not logged in, in MediaWiki: [05:06:03] OTOH, file namespace works... I should fix that. [05:06:13] (03CR) 10BryanDavis: [C: 031] "\o/ I fixed commons. The problem was that commonswiki was loading the wgForeignFileRepos configuration from the shared settings directory." [vagrant] - 10https://gerrit.wikimedia.org/r/149872 (https://bugzilla.wikimedia.org/68605) (owner: 10BryanDavis) [05:06:19] Oh, I think I made my test account an admin as well... [05:08:08] hmm, it looks like EditPage doesn't blcok people from creating regular pages in the File namespace either... [05:08:54] Wikipedia uses an edit notice to tell people not to do it. [05:09:09] And probably blacklists. [05:11:26] Is there a way to auto-categorize MM lists? [05:11:41] Or like list pages by content handler type? [05:12:36] select * from page where page_content_model = 'MassMessageListContent', but there's no UI for it...and I don't think that query is indexed [05:12:41] (03PS7) 10Pastakhov: add static property WPage::$DEFAULT_SORT_KEY (v 1.4.0 needs 2.8.4) [extensions/PhpTagsWiki] - 10https://gerrit.wikimedia.org/r/150477 [05:12:50] Yeah. [05:12:55] So I'd like to think about that for a bit. [05:13:03] > The following pages are invalid: [05:13:08] * [[foo]] [05:13:11] I could make a hack that adds a hidden field in the JSON object that just contains $wgMMDeliveryListCategory and have it parsed by the parser [05:13:11] Gets rendered as a link. [05:13:26] A global configuration variable would be ugly. [05:13:36] Maybe some kind of MediaWiki message page that's blank by default. [05:13:39] (03CR) 10Robert Vogel: [C: 031 V: 031] Remove anchor tags in editor [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151418 (owner: 10Mglaser) [05:13:54] MassMessage-list-footer or something? I dunno. [05:14:06] (03CR) 10Robert Vogel: [C: 031 V: 031] Harden handling of BR tags [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151415 (owner: 10Mglaser) [05:14:16] that'd work, yeah. and use the content language by default. [05:14:18] wctaiwan: I think $parser->addTrackingCategory would work. [05:14:25] oh, good. [05:14:47] or maybe that's in ParserOutput, I forget. [05:14:55] (03CR) 10Robert Vogel: [C: 031 V: 031] Fixed handling of wikicode in image labels in visual editor [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151414 (owner: 10Mglaser) [05:15:24] hmm [05:15:29] I broke the creation edit summary [05:15:35] (03CR) 10Robert Vogel: [C: 032 V: 032] Standard line height and maring in all content HTML texts. [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/151413 (owner: 10Mglaser) [05:15:44] so categorise all delivery lists, fix creation edit summary [05:16:00] I have a few additional notes. [05:16:15] http://mm-ch.wmflabs.org/wiki/Special:EditMassMessageList/Foo_b needs a breadcrumb of some kind. [05:16:18] The intro text is awkward. [05:16:52] ", if cross-wiki delivery is enabled." in the message text indicates some larger switch detection is needed. [05:16:56] breadcrumb as in link back to the list? [05:17:04] Yeah. [05:17:07] okay. [05:17:28] Like you shouldn't explain foo@domain if the wiki doesn't support that. [05:17:34] yeah, I can probably just have two messages for that easily enough. [05:17:37] Mentioning it at all will just create confusion outside of Meta-Wiki. [05:17:41] Cool. [05:17:47] At http://mm-ch.wmflabs.org/wiki/Foo_b [05:17:54] (03PS8) 10Pastakhov: add static property WPage::$DEFAULT_SORT_KEY (v 1.4.0 needs 2.8.4) [extensions/PhpTagsWiki] - 10https://gerrit.wikimedia.org/r/150477 [05:17:59] The == Add pages == header should be killed. [05:18:11] Just have that text input next to the bullet below the current list. [05:18:21] This will also fix some awkward interaction between the two lists. [05:18:30] Where you refresh the page currently and the two lists combine and sort. [05:18:42] Now it'll just sort on refresh, but be a unified list. [05:18:44] I guess. [05:18:53] Hopefully that makes some sense. [05:19:01] How do people know what the field does? [05:19:08] (03CR) 10Pastakhov: [C: 032] add static property WPage::$DEFAULT_SORT_KEY (v 1.4.0 needs 2.8.4) [extensions/PhpTagsWiki] - 10https://gerrit.wikimedia.org/r/150477 (owner: 10Pastakhov) [05:19:10] oh, I guess they can see from the button [05:19:16] (03Merged) 10jenkins-bot: add static property WPage::$DEFAULT_SORT_KEY (v 1.4.0 needs 2.8.4) [extensions/PhpTagsWiki] - 10https://gerrit.wikimedia.org/r/150477 (owner: 10Pastakhov) [05:19:20] Yeah, it's kind of obvious if it's at the bottom, I think. [05:19:23] Below the other entries. [05:19:28] Plus the button. [05:19:38] The text input should probably re-gain focus after "add page" is submitted. [05:19:54] it does for me? [05:20:13] oh, not if you actually click the button... [05:20:35] If I actually click or if I use the keyboard return key, neither causes the text input to re-gain focus. [05:20:38] In my browser, anyway. [05:20:42] Not a big deal, but might be nice. [05:20:48] what happens if you use the return key? [05:20:55] The button is highlighted. [05:20:59] After submit. [05:21:30] I think it'd be jarring if the input field takes focus after you explicitly click the button [05:21:37] Maybe. [05:21:46] in Firefox the field retains the focus if you just use the return key. [05:21:54] (well, enter; I'm on windows) [05:21:56] Oh, I was tabbing to the button. [05:22:00] And then hitting the return key. [05:22:03] That makes more sense. [05:22:25] Okay, that's probably fine for now then. [05:22:33] yeah, I think messing with focus is a bad idea. [05:23:13] So killing "Add pages" and "Title:", maybe. [05:24:00] http://mm-ch.wmflabs.org/wiki/Special:EditMassMessageList/Foo_b should maybe have a convenience link for changing the title. [05:24:05] Just greying it out isn't very helpful. [05:24:27] I guess it'd be a link to Special:MovePage/foo or something. [05:25:14] what if I just turn it into the breadcrumb link? [05:25:37] You mean like http://mm-ch.wmflabs.org/w/index.php?title=Foo_b&action=history [05:25:45] Where "View logs for this page" is? [05:26:02] I guess that might work. I think AbuseFilter does that. [05:26:04] No, I mean instead of a greyed out field, I just have a link back to the list [05:26:11] Oh. [05:26:18] assuming HTMLForm lets me :/ [05:26:19] Remove the title field altogether? [05:26:24] Yeah, maybe. [05:26:49] well, I'd need to show the title somewhere, I think. Perhaps I should just try and see if I can override the output page title (the h1) [05:26:57] The instructions aren't clear, exactly. [05:27:36] > List one title per line, and use title@domain (e.g. User talk:Example@en.wikipedia.org) to specify a page on a different wiki, if cross-wiki delivery is enabled. [05:27:43] change the h1 to "Editing $1"? [05:27:58] And then there's a single-line "Title" text input. [05:28:10] It isn't clear that the instructions really only apply to the "Content" section. [05:28:15] Carmela: yeah, I'll fix that. It wasn't meant to be so... permanent [05:28:51] the idea was that I'd get rid of the special page eventually; this was only a quick and dirty page to make editing possible before I did the proper UI. [05:28:54] The more I see MediaWiki fieldsets, the more I dislike them. [05:29:21] I don't think vforms work well with textareas, unfortunately.. [05:29:21] I wonder if http://mm-ch.wmflabs.org/wiki/Special:EditMassMessageList/Foo_b needs that stupid disclaimer text. [05:30:12] ...it very possibly might, technically. Given you could paste crap into the description. [05:30:15] Lego and I also talked about making "(remove)" less instant. [05:30:30] yes, please merge MatmaRex's jquery.confirmable patch [05:30:32] then I can use it. [05:30:38] Which change? [05:30:47] https://gerrit.wikimedia.org/r/#/c/92315/ [05:31:39] That change has an insane number of reviewers already. [05:32:08] (03CR) 10MZMcBride: "What's still needed to get this merged?" [core] - 10https://gerrit.wikimedia.org/r/92315 (owner: 10Bartosz Dziewoński) [05:39:57] Carmela: anything else? [05:41:01] (assuming it's possible, I might do that and put the breadcrumb in the View all logs location; this would probably be easier overall than wrestling with HTMLForm) [05:43:11] http://mm-ch.wmflabs.org/wiki/Special:EditMassMessageList/Foo_b doesn't mention page protection. [05:45:30] I'll look into fixing that. [05:46:24] http://mm-ch.wmflabs.org/wiki/Foo_b [05:46:28] Interwiki links are accepted? [05:46:37] "wikipedia:foo", eh. [05:47:05] I think the delivery code handles interwikis? [05:47:41] it doesn't really [05:48:08] #target probably accepts interwikis, which would be a bug [05:48:26] We shouldn't accept input that doesn't work. [05:48:36] yeah. [05:48:41] what does newFromText do when you give it an interwiki link? [05:48:47] (Title::) [05:48:56] or rather, how do I know something is an interwiki link? [05:49:06] $title->isExternal() I think [05:49:29] "Special:BrokenRedirects" also is accepted. [05:51:19] okay, I should fix that. [05:52:23] "[[foo]]" is considered invalid. [05:52:28] But it's crazy difficult to figure out why. [05:52:43] Because "[[foo]]" is not a valid title :P [05:52:45] Especially as the invalid item is parsed as wikitext. [05:52:47] Right. [05:52:57] wait, the invalid item should _not_ be linked [05:52:58] But try putting "[[foo]]" in a list and submitting. [05:53:11] All wikitext is being parsed. [05:53:18] oh [05:53:21] ergh. [05:53:31] "[[file:foo.jpg]]" as well. [05:53:39] I said this in here a few minutes ago. [05:53:42] is there a way to escape wikitext in parsing? [05:53:51] wfEscapeWikitext? [05:53:58] yeah, but I didn't understand what you meant; I thought you meant all invalid targets are being linked. [05:54:06] Ah. [05:54:51] (03Abandoned) 10IAlex: Deglobalise some special pages [core] - 10https://gerrit.wikimedia.org/r/151085 (owner: 10IAlex) [05:56:44] http://pastebin.com/wSX1M0rv what I have from our discussion so far [05:57:06] did I miss anything? [05:57:20] (03PS1) 10Ori.livneh: Improve PHPUnit detection code [core] - 10https://gerrit.wikimedia.org/r/151578 [05:57:46] Looks good to me. [05:58:04] There will almost certainly be more minor tweaks, but overall this looks good. [05:58:14] alright, thanks. [05:58:59] (03CR) 10jenkins-bot: [V: 04-1] Improve PHPUnit detection code [core] - 10https://gerrit.wikimedia.org/r/151578 (owner: 10Ori.livneh) [06:01:52] 3Wikimedia / 3Site requests: Disable Media Viewer software feature by default on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69080#c3 (10Fabrice Florin) p:5Normal>3Unprio Thanks for filing this bug. We would like to hold off on any actions related this RfC until the WMF has had a chance to dis... [06:04:08] 3Wikimedia / 3Site requests: Disable Media Viewer by default on the English Wikipedia - 10https://bugzilla.wikimedia.org/67826 (10MZMcBride) [06:04:08] 3Wikimedia / 3Site requests: Disable Media Viewer software feature by default on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69080 (10MZMcBride) [06:04:55] (03PS2) 10Ori.livneh: Improve PHPUnit detection code [core] - 10https://gerrit.wikimedia.org/r/151578 [06:18:50] (03PS1) 10Prtksxna: Remove hover state if no project is defined in targeted graphs [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151579 [06:22:16] (03PS1) 10Prtksxna: Align "Information Produced?" with the tabs on the DMCA Requests graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151580 [06:25:50] (03CR) 10MSyed: [C: 032 V: 032] Remove hover state if no project is defined in targeted graphs [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151579 (owner: 10Prtksxna) [06:26:06] (03CR) 10MSyed: [C: 032 V: 032] Align "Information Produced?" with the tabs on the DMCA Requests graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151580 (owner: 10Prtksxna) [06:26:52] 3MediaWiki extensions / 3ContributionScores: Database error: Uncommited DB writes (with SQLite backend) - 10https://bugzilla.wikimedia.org/67842#c4 (10Marco) The extension will create a list of scores for each user. This list is shown on a SpecialPage. When I try to open this SpecialPage the error occurs and... [06:31:50] (03PS1) 10Prtksxna: Fix selector in FAQ [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151581 [06:41:05] (03PS1) 10Prtksxna: Fix tooltips for bubble graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151582 [06:44:13] (03PS1) 10Prtksxna: Fix links in the "All" tab for the Targeted graphs [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151583 [06:46:16] (03CR) 10Tim Starling: "Why? There is a reason for using underscores, and no reason presented here as to why they should be avoided. Surely the phpcs configuratio" [core] - 10https://gerrit.wikimedia.org/r/149382 (owner: 10Umherirrender) [06:47:36] (03PS2) 10Tweichart: BS223: compatibility to vector skin [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151292 [06:59:06] (03PS1) 10Prtksxna: Fix names of "Request Types" for the Privacy bar graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151584 [07:09:30] (03PS1) 10Prtksxna: targetedGraph: Put "No Project Named" at the end of the list after sorting [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151585 [07:10:17] (03CR) 10MSyed: [C: 032 V: 032] Fix selector in FAQ [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151581 (owner: 10Prtksxna) [07:11:01] (03CR) 10MSyed: [C: 032 V: 032] Fix tooltips for bubble graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151582 (owner: 10Prtksxna) [07:13:01] (03CR) 10MSyed: [C: 032 V: 032] Fix links in the "All" tab for the Targeted graphs [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151583 (owner: 10Prtksxna) [07:14:00] (03CR) 10MSyed: [C: 032 V: 032] Fix names of "Request Types" for the Privacy bar graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151584 (owner: 10Prtksxna) [07:14:23] (03CR) 10MSyed: [C: 032 V: 032] targetedGraph: Put "No Project Named" at the end of the list after sorting [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151585 (owner: 10Prtksxna) [07:15:52] (03PS1) 10MSyed: Added links and fixed typos [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151586 [07:16:47] (03CR) 10Prtksxna: [C: 032 V: 032] Added links and fixed typos [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151586 (owner: 10MSyed) [07:35:18] (03PS1) 10MSyed: Links and other minor text changes [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151587 [07:36:27] (03CR) 10Prtksxna: [C: 032 V: 032] Links and other minor text changes [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151587 (owner: 10MSyed) [07:52:35] (03CR) 10Addshore: [C: 032] Improve PHPUnit detection code [core] - 10https://gerrit.wikimedia.org/r/151578 (owner: 10Ori.livneh) [07:55:38] (03Merged) 10jenkins-bot: Improve PHPUnit detection code [core] - 10https://gerrit.wikimedia.org/r/151578 (owner: 10Ori.livneh) [08:03:08] (03CR) 10Umherirrender: "Yes, this patch set is phpcs motivated, because these are the last class names which gets reported by Sniff Squiz.Classes.ValidClassName. " [core] - 10https://gerrit.wikimedia.org/r/149382 (owner: 10Umherirrender) [08:06:51] (03PS1) 10Shirayuki: i18n: fix typo in "right-workflowedit" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151588 [08:11:23] (03CR) 10Bartosz Dziewoński: "Will and code review." [core] - 10https://gerrit.wikimedia.org/r/92315 (owner: 10Bartosz Dziewoński) [08:20:21] (03CR) 10Smuggli: [C: 032 V: 032] i18n: fix typo in "right-workflowedit" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151588 (owner: 10Shirayuki) [08:22:26] (03CR) 10Smuggli: [C: 032 V: 032] Fixed handling of wikicode in image labels in visual editor [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151414 (owner: 10Mglaser) [08:23:03] (03CR) 10Smuggli: [C: 032 V: 032] Harden handling of BR tags [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151415 (owner: 10Mglaser) [08:23:30] (03CR) 10Smuggli: [C: 032 V: 032] Remove anchor tags in editor [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151418 (owner: 10Mglaser) [08:24:24] 3MediaWiki extensions / 3Translate: Special:AdvancedTranslate gets internal error - 10https://bugzilla.wikimedia.org/69094 (10Lokal_Profil) 3NEW p:3Unprio s:3normal a:3None SpecialAdvancedTranslate (on translatewiki) fails to load as it cannot process the language code. For e.g. https://translatewi... [08:27:13] (03CR) 10Tweichart: BS223: compatibility to vector skin (034 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151292 (owner: 10Tweichart) [08:29:02] (03CR) 10Smuggli: BS223 Facelist: Preferences (031 comment) [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/151270 (owner: 10Tweichart) [08:33:08] (03CR) 10Umherirrender: SpecialExport: Use Config instead of globals (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151529 (owner: 10Legoktm) [08:39:02] (03CR) 10Siebrand: "i18n/L10n reviewed." (031 comment) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151390 (owner: 10Wctaiwan) [08:41:29] (03PS1) 10MSyed: Content changes, and other fixes [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151590 [08:42:04] (03CR) 10Umherirrender: Allow classes to be registered properly from installer (032 comments) [core] - 10https://gerrit.wikimedia.org/r/143779 (https://bugzilla.wikimedia.org/67440) (owner: 10Chad) [08:44:09] 3MediaWiki extensions / 3Spam Blacklist: Circumvention through link semi-templating - 10https://bugzilla.wikimedia.org/69095 (10Dirk Beetstra) 3NEW p:3Unprio s:3critic a:3None If one creates a 'template' with the contents 'www.encyclopediadramatica.com' (which is blacklisted), and then transcludes th... [08:45:38] (03PS1) 10Addshore: Remove unused globals [core] - 10https://gerrit.wikimedia.org/r/151592 [08:46:53] 3MediaWiki extensions / 3Translate: Special:AdvancedTranslate gets internal error - 10https://bugzilla.wikimedia.org/69094#c1 (10Niklas Laxström) a:3Niklas Laxström I already made patch for this: https://gerrit.wikimedia.org/r/#/c/151275/ It's waiting for review. [08:47:50] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (036 comments) [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/151199 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [08:50:51] (03PS2) 10Umherirrender: Remove unused globals [core] - 10https://gerrit.wikimedia.org/r/151592 (owner: 10Addshore) [08:51:02] (03CR) 10Umherirrender: [C: 031] Remove unused globals [core] - 10https://gerrit.wikimedia.org/r/151592 (owner: 10Addshore) [08:55:00] (03CR) 10TheDJ: [C: 04-2] "This change does refactoring and fixing a bug in one step. Please split the patch out into multiple patches." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [08:55:55] (03PS1) 10Umherirrender: Ignore Squiz.Classes.ValidClassName for Preprocessors [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/151593 [08:57:15] (03PS1) 10AndyRussG: Add QUnit tests and refactor JS as needed [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/151594 [08:57:29] (03CR) 10jenkins-bot: [V: 04-1] Add QUnit tests and refactor JS as needed [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/151594 (owner: 10AndyRussG) [08:59:13] (03CR) 10Siebrand: [C: 031] Remove globals, set visibility of functions and variables (032 comments) [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/151207 (owner: 10Florianschmidtwelzow) [08:59:34] (03CR) 10Siebrand: [C: 031] Use Linker for accesskey [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/151208 (owner: 10Florianschmidtwelzow) [09:01:01] (03PS1) 10Wctaiwan: Fix creation edit summary [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151595 [09:02:54] (03CR) 10Wctaiwan: Improve edit summaries (031 comment) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151390 (owner: 10Wctaiwan) [09:04:14] (03CR) 10Umherirrender: "See I9b407858b77420b1af2587c3213ad084d76199fe for a possible change of phpcs conifg" [core] - 10https://gerrit.wikimedia.org/r/149382 (owner: 10Umherirrender) [09:05:57] (03CR) 10Gilles: [C: 031] Making missing old files not try to render a thumbnail [core] - 10https://gerrit.wikimedia.org/r/151378 (https://bugzilla.wikimedia.org/22847) (owner: 10Brian Wolff) [09:06:25] (03CR) 10Siebrand: "Not a fan. See inline." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151537 (owner: 10Bsitu) [09:07:50] (03CR) 10Siebrand: [C: 032] Fix creation edit summary [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151595 (owner: 10Wctaiwan) [09:07:58] (03Merged) 10jenkins-bot: Fix creation edit summary [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151595 (owner: 10Wctaiwan) [09:11:15] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/151444 (https://bugzilla.wikimedia.org/68962) (owner: 10Florianschmidtwelzow) [09:12:30] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 (owner: 10Bsitu) [09:14:04] wow, online for the first time in 3 days... [09:14:06] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/151397 (https://bugzilla.wikimedia.org/66775) (owner: 10Deepali) [09:14:43] the bliss of vaction :) [09:15:28] (03CR) 10Umherirrender: Improve PHPUnit detection code (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151578 (owner: 10Ori.livneh) [09:15:30] (03CR) 10Prtksxna: [C: 032 V: 032] Content changes, and other fixes [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151590 (owner: 10MSyed) [09:15:46] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/150497 (owner: 10Tweichart) [09:16:49] (03CR) 10Siebrand: "i18n/L10n reviewed." (031 comment) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151380 (owner: 10Wctaiwan) [09:17:07] 3Wikimedia / 3Site requests: Disable Media Viewer software feature by default on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69080#c4 (10Steinsplitter) What need to be discussed? Please respect the community wishes. The WMF only exists because of the community. Commons was builded by the Community a... [09:20:34] (03CR) 10Siebrand: "The consequence of this patch set is that refactoring is going to keep being as painful as it was when class properties were defined witho" [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [09:23:12] Carmela: http://wiki.wctaiwan.com/wiki/Test I think it looks worse this way :/ [09:23:23] (getting rid of the h2) [09:23:32] (03CR) 10Smuggli: [C: 032 V: 032] BS223: compatibility to vector skin [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151292 (owner: 10Tweichart) [09:24:29] (03CR) 10Smuggli: [C: 032 V: 032] BS223: styling + fixes [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151276 (owner: 10Tweichart) [09:24:50] (03CR) 10Smuggli: "Needs rebase" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151276 (owner: 10Tweichart) [09:25:43] (03CR) 10Tim Starling: "Oh, well you could just change those other names back. I think it's more important to have names that people can understand than to have p" [core] - 10https://gerrit.wikimedia.org/r/149382 (owner: 10Umherirrender) [09:26:58] (03CR) 10TheDJ: [C: 04-1] "You sure ? I tested this, and with the patch applied, I get the original behavior back, where a large block is green..." [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/150622 (https://bugzilla.wikimedia.org/52509) (owner: 10Reedy) [09:27:37] 3MediaWiki extensions / 3Translate: [TUX] Definition diff not shown if message is not fuzzy - 10https://bugzilla.wikimedia.org/47608 (10Siebrand Mazeland) 5PATC>3RESO/FIX [09:27:39] (03CR) 10Addshore: Improve PHPUnit detection code (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151578 (owner: 10Ori.livneh) [09:29:47] (03CR) 10Siebrand: "We love your whip, Chad! As observed, we've eagerly provided ways to improve its effectiveness ;)." [core] - 10https://gerrit.wikimedia.org/r/150699 (owner: 10Chad) [09:31:22] (03PS2) 10AndyRussG: Add QUnit tests and refactor JS as needed [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/151594 [09:31:36] Carmela: http://i.imgur.com/2l0TeQ9.png screenshot for your reference (I'm going to stash that and work on other things first) [09:32:25] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/151262 (owner: 10Gergő Tisza) [09:34:51] (03CR) 10Addshore: "I definitely feel this should be pulled back a bit (ie. only make public those that you do indeed use." [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [09:35:20] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151061 (https://bugzilla.wikimedia.org/30666) (owner: 10Ebe123) [09:36:01] (03CR) 10Addshore: [C: 032] SpecialProtectedPages: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151561 (owner: 10Legoktm) [09:37:37] (03CR) 10Addshore: [C: 04-1] SpecialRecentChanges: Use Config instead of globals (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151565 (owner: 10Legoktm) [09:38:00] (03CR) 10Addshore: [C: 032] SpecialProtectedTitles: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151563 (owner: 10Legoktm) [09:39:11] (03Merged) 10jenkins-bot: SpecialProtectedPages: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151561 (owner: 10Legoktm) [09:41:40] (03CR) 10Addshore: [C: 032] SpecialResetTokens: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151566 (owner: 10Legoktm) [09:41:42] (03CR) 10Addshore: [C: 032] SpecialPasswordReset: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151560 (owner: 10Legoktm) [09:41:44] (03CR) 10Addshore: [C: 032] SpecialPageLanguage: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151559 (owner: 10Legoktm) [09:41:46] (03CR) 10Addshore: [C: 032] SpecialNewPages: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151558 (owner: 10Legoktm) [09:41:48] (03CR) 10Addshore: [C: 032] SpecialNewImages: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151556 (owner: 10Legoktm) [09:41:50] (03CR) 10Addshore: [C: 032] SpecialMyLanguage: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151555 (owner: 10Legoktm) [09:41:52] (03CR) 10Addshore: [C: 032] SpecialMovepage: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151553 (owner: 10Legoktm) [09:42:37] (03PS3) 10Smuggli: Adding BlueSpice installer overrides for MW installer [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/150842 [09:44:07] 3MediaWiki / 3Special pages: Special:UnwatchedPages should list unwatched pages in the content namespace(s) - 10https://bugzilla.wikimedia.org/16433#c7 (10Scott Martin (http://enwp.org/user:scott)) (In reply to Aaron Schulz from comment #6) > Closing Why? [09:44:44] (03PS1) 10Nikerabbit: Fix bad reference in method doc [core] - 10https://gerrit.wikimedia.org/r/151599 [09:45:35] (03CR) 10jenkins-bot: [V: 04-1] SpecialResetTokens: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151566 (owner: 10Legoktm) [09:47:30] (03Merged) 10jenkins-bot: SpecialPasswordReset: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151560 (owner: 10Legoktm) [09:47:32] (03CR) 10jenkins-bot: [V: 04-1] SpecialPageLanguage: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151559 (owner: 10Legoktm) [09:48:23] (03CR) 10Siebrand: "> Is there any reason we couldn't bulk deprecate most / all of the public vars now so that in time we could remove / tidy them all without" [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [09:49:06] (03CR) 10Siebrand: [C: 032] Fix bad reference in method doc [core] - 10https://gerrit.wikimedia.org/r/151599 (owner: 10Nikerabbit) [09:49:57] (03Merged) 10jenkins-bot: SpecialNewPages: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151558 (owner: 10Legoktm) [09:49:59] (03CR) 10jenkins-bot: [V: 04-1] SpecialNewImages: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151556 (owner: 10Legoktm) [09:50:32] (03CR) 10jenkins-bot: [V: 04-1] SpecialMyLanguage: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151555 (owner: 10Legoktm) [09:51:52] 3MediaWiki / 3General/Unknown: bin/ulimit5.sh isn't UNIX compliant - 10https://bugzilla.wikimedia.org/44568#c12 (10Alasdair Macdonald) I encountered this problem in the context of an imagemagick command for creation of thumbnails on a Synology NAS. The NAS has /bin/ash by default, linked to busybox. But it... [09:52:39] (03Abandoned) 10Nemo bis: Add fallback from 'non' (Old Norse) to 'is' [core] - 10https://gerrit.wikimedia.org/r/146041 (owner: 10Nemo bis) [09:53:10] (03PS1) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/151600 [09:53:12] (03PS11) 10Nikerabbit: Always escape 'word-separator' and 'parentheses' messages [core] - 10https://gerrit.wikimedia.org/r/136161 (owner: 10Umherirrender) [09:53:50] (03CR) 10Gilles: [C: 04-1] "The thumbnail itself in the thanks area is no longer clickable (unlike master). Only the title below it." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151225 (owner: 10MarkTraceur) [09:55:28] (03Merged) 10jenkins-bot: SpecialMovepage: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151553 (owner: 10Legoktm) [09:55:34] (03Merged) 10jenkins-bot: Fix bad reference in method doc [core] - 10https://gerrit.wikimedia.org/r/151599 (owner: 10Nikerabbit) [09:55:36] (03CR) 10Addshore: "recheck" [core] - 10https://gerrit.wikimedia.org/r/151566 (owner: 10Legoktm) [09:56:04] (03CR) 10Foxtrott: "I definitely agree that most (all, in fact) of these should be protected or private!" [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [09:57:37] 3MediaWiki / 3Special pages: Special:Block: Use Config instead of globals - 10https://bugzilla.wikimedia.org/69087#c1 (10Umherirrender) Static function SpecialBlock::processForm has a context source as param, which can provide a config object, but all the other functions needs another way to do. [09:58:55] (03CR) 10Krinkle: [C: 04-1] "This is not equivalent. In Monobook #bodyContent has mw-body and #content has mw-primary-body. And mw-body-content actually doesn't even e" [core] - 10https://gerrit.wikimedia.org/r/151395 (owner: 10Arlolra) [09:59:22] 3MediaWiki / 3Skin and page rendering: The magic word "notitle" causes some errors in the main MediaWiki page as of wmf10 - 10https://bugzilla.wikimedia.org/66927#c4 (10Andre Klapper) Last call: How do you come to the conclusion that this is related to "notitle"? [10:00:22] 3MediaWiki extensions / 3PageImages: Notice: undefined index: 2 - 10https://bugzilla.wikimedia.org/67046#c6 (10Andre Klapper) 5PATC>3RESO/FIX Pacth merged; assuming this bug is FIXED. If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed. [10:00:58] (03PS1) 10Umherirrender: Fixed docs [core] - 10https://gerrit.wikimedia.org/r/151602 [10:01:00] (03CR) 10Krinkle: "Ah, it does update MonobookTemplate. Missed that. Looks interesting. The selector should still be simplified further though. No point in b" [core] - 10https://gerrit.wikimedia.org/r/151395 (owner: 10Arlolra) [10:01:07] 3MediaWiki / 3Parser: let me size inline images to max-height, with variable image-sets including client-side reduction, fix the forced "quirk-mode" of mobile view - 10https://bugzilla.wikimedia.org/66896#c2 (10Andre Klapper) 5NEW>3UNCO p:5Low>3Lowest Please answer comment 1. [10:01:38] 3MediaWiki / 3Page editing: Warn on edit summaries containing redlinks - 10https://bugzilla.wikimedia.org/13108 (10Andre Klapper) [10:01:38] 3MediaWiki / 3Page editing: Fix fragment identifiers in links to sections - 10https://bugzilla.wikimedia.org/5019 (10Andre Klapper) [10:02:08] (03CR) 10Nikerabbit: [C: 04-1] Always escape 'word-separator' and 'parentheses' messages (032 comments) [core] - 10https://gerrit.wikimedia.org/r/136161 (owner: 10Umherirrender) [10:02:37] 3MediaWiki / 3Skin and page rendering: The magic word "notitle" causes some errors in the main MediaWiki page as of wmf10 - 10https://bugzilla.wikimedia.org/66927#c5 (10deanator71) It could be styling errors, I suggest. I do not come to the conclusion that it is related to notitle. In fact it has been somewh... [10:03:25] (03CR) 10Krinkle: Use .mw-body,.mw-body-content in skins (032 comments) [core] - 10https://gerrit.wikimedia.org/r/151395 (owner: 10Arlolra) [10:04:07] 3Wikimedia / 3General/Unknown: Wikimedia wikis are displaying the incorrect license information - 10https://bugzilla.wikimedia.org/60023#c6 (10Andre Klapper) Reedy: What's left here? [10:05:21] (03CR) 10Krinkle: "@Arlolra: Yep, I agree. Let's keep changing that behaviour for a separate commit and limit the scope of this commit to merely the implemen" [core] - 10https://gerrit.wikimedia.org/r/151395 (owner: 10Arlolra) [10:06:28] (03CR) 10Krinkle: "fixme: This should have caused an error in phpunit test for structure/resources." [core] - 10https://gerrit.wikimedia.org/r/151441 (owner: 10Bartosz Dziewoński) [10:11:09] (03CR) 10Daniel Friesen: "Part of .mw-body's original purpose was for external link styles. When I broke common parts of MonoBook and Vector out into a set of commo" [core] - 10https://gerrit.wikimedia.org/r/151395 (owner: 10Arlolra) [10:12:13] (03PS1) 10KartikMistry: Moved testApertium.js to better place [services/cxserver] - 10https://gerrit.wikimedia.org/r/151603 [10:17:09] (03CR) 10Addshore: "recheck" [core] - 10https://gerrit.wikimedia.org/r/151559 (owner: 10Legoktm) [10:17:14] (03CR) 10Addshore: "recheck" [core] - 10https://gerrit.wikimedia.org/r/151556 (owner: 10Legoktm) [10:17:18] (03CR) 10Addshore: "recheck" [core] - 10https://gerrit.wikimedia.org/r/151555 (owner: 10Legoktm) [10:21:18] (03CR) 10Paladox: "Do you mean for example have one patch that fixes the images and another that converts .css to .less." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [10:25:23] 3MediaWiki extensions / 3MaintenanceShell: MainteniceShell broken in MediaWiki 1.24 - 10https://bugzilla.wikimedia.org/69075#c2 (10paladox2015) Oh well the version I have is 0.5.0 and MediaWiki version 1.24 Wmf 16 and to click update.php there should be a long list with update.php and then in the command you... [10:35:07] 3MediaWiki / 3Skin and page rendering: The magic word "notitle" causes some errors in the main MediaWiki page as of wmf10 - 10https://bugzilla.wikimedia.org/66927#c6 (10Andre Klapper) I assume you have tried both appending ?action=purge to the URL, and reloading the page while bypassing your browser cache [[... [10:37:22] 3MediaWiki / 3Special pages: Special:UnwatchedPages should list unwatched pages in the content namespace(s) - 10https://bugzilla.wikimedia.org/16433#c8 (10Andre Klapper) See comment 5 for the reasons that were given five years ago. [10:37:52] 3MediaWiki / 3Special pages: Special:Block: Use Config instead of globals - 10https://bugzilla.wikimedia.org/69087 (10Andre Klapper) p:5Unprio>3Low [10:40:02] (03CR) 10Smuggli: [C: 032 V: 032] BS223 Facelift: further improvements [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/151294 (owner: 10Tweichart) [10:41:22] 3MediaWiki / 3Special pages: Special:UnwatchedPages should list unwatched pages in the content namespace(s) - 10https://bugzilla.wikimedia.org/16433#c9 (10Scott Martin (http://enwp.org/user:scott)) Comment 5 reopened this bug, not closed it. [10:41:25] (03PS12) 10Umherirrender: Always escape 'word-separator' and 'parentheses' messages [core] - 10https://gerrit.wikimedia.org/r/136161 [10:42:01] (03CR) 10Umherirrender: "Patch Set 12: Addressed inline comment" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/136161 (owner: 10Umherirrender) [10:52:46] (03PS1) 10Smuggli: Change event listener [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151607 [10:53:23] (03PS2) 10Smuggli: Changed event listener [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151607 [10:53:37] 3MediaWiki / 3Internationalization: Can't override optional message in all languages with local customisation - 10https://bugzilla.wikimedia.org/48956#c12 (10Andre Klapper) p:5High>3Normal For the records, patch was -1'ed and needs improvement. [10:55:22] 3MediaWiki extensions / 3TranslationNotifications: Use new log system for better i18n - 10https://bugzilla.wikimedia.org/54239#c3 (10Andre Klapper) 5PATC>3RESO/FIX Patch in comment 2 was merged long ago; assuming this bug is FIXED. If that is not the case: Please reopen and elaborate what is left to do h... [10:55:54] (03PS1) 10Prtksxna: dmcaRequests: Minor fixes [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151608 [11:02:41] (03PS1) 10Prtksxna: User Data Graph: Fix yScale issues [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151609 [11:04:29] (03PS1) 10Umherirrender: Fix doc of PPFrame_Hash::cachedExpand [core] - 10https://gerrit.wikimedia.org/r/151610 [11:05:37] 3MediaWiki extensions / 3UniversalLanguageSelector: Monobook: ULS form (opened by keyboard icon) out of screen if content language = LTR and UI language = RTL - 10https://bugzilla.wikimedia.org/52154#c10 (10Andre Klapper) (In reply to Amir E. Aharoni from comment #8) > This works if the content language and... [11:08:37] (03CR) 10Siebrand: [C: 032] Fixed docs [core] - 10https://gerrit.wikimedia.org/r/151602 (owner: 10Umherirrender) [11:10:35] (03CR) 10Siebrand: [C: 032] Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/151600 (owner: 10Umherirrender) [11:11:18] (03PS1) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [11:11:26] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/150842 (owner: 10Smuggli) [11:11:30] (03PS2) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [11:11:43] (03Merged) 10jenkins-bot: Fixed docs [core] - 10https://gerrit.wikimedia.org/r/151602 (owner: 10Umherirrender) [11:13:23] (03Merged) 10jenkins-bot: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/151600 (owner: 10Umherirrender) [11:15:30] (03PS2) 10Florianschmidtwelzow: Remove use of wfMsg and friends [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/151199 (https://bugzilla.wikimedia.org/68750) [11:15:42] (03CR) 10Florianschmidtwelzow: Remove use of wfMsg and friends (036 comments) [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/151199 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [11:15:50] (03PS3) 10Florianschmidtwelzow: Remove globals, set visibility of functions and variables [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/151207 [11:15:58] (03PS3) 10Florianschmidtwelzow: Use Linker for accesskey [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/151208 [11:16:51] (03CR) 10Paladox: "Hi please see Ic0c261f66ee882efeb07ab77ee2a3a5533093c4f for the fix for svg images." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [11:19:04] (03PS1) 10Siebrand: Fix spelling and make category desc consistent [core] - 10https://gerrit.wikimedia.org/r/151612 [11:19:14] (03CR) 10Siebrand: "Done as https://gerrit.wikimedia.org/r/151612" [core] - 10https://gerrit.wikimedia.org/r/132221 (https://bugzilla.wikimedia.org/63795) (owner: 10Ossi96) [11:21:08] (03CR) 10Siebrand: "i18n/L10n reviewed." [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/151208 (owner: 10Florianschmidtwelzow) [11:21:53] (03PS4) 10Florianschmidtwelzow: Remove globals, set visibility of functions and variables [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/151207 [11:22:13] (03CR) 10Florianschmidtwelzow: Remove globals, set visibility of functions and variables (031 comment) [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/151207 (owner: 10Florianschmidtwelzow) [11:22:21] (03PS4) 10Florianschmidtwelzow: Use Linker for accesskey [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/151208 [11:22:23] (03CR) 10Aklapper: "What is "an issue" exactly? It's unclear to me which specific problem the patch fixes. The problem should be explained in the commit summa" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [11:22:24] 3MediaWiki / 3History/Diffs: Matching paragraphs are not side by side in the side-by-side display of diff. - 10https://bugzilla.wikimedia.org/69097 (10Jos Visser) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16133 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16133&action=edit Screen... [11:22:54] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/151199 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [11:24:22] 3MediaWiki / 3Special pages: Special:UnwatchedPages should list unwatched pages in the content namespace(s) - 10https://bugzilla.wikimedia.org/16433#c10 (10Andre Klapper) Comment 5 gives a reason why it's not useful to fix this. [11:24:48] (03CR) 10Gilles: [C: 04-1] "Just errors after I pick a file to upload in Firefox, with:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150258 (owner: 10MarkTraceur) [11:26:05] (03PS2) 10Florianschmidtwelzow: Check if wgAuth is set correctly [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/151444 (https://bugzilla.wikimedia.org/68962) [11:26:07] 3MediaWiki extensions / 3MaintenanceShell: MainteniceShell broken in MediaWiki 1.24 - 10https://bugzilla.wikimedia.org/69075#c3 (10Andre Klapper) p:5Unprio>3Lowest You ignored half of the questions in comment 1. For example, "This report is entirely missing error output, and "it's broken" is not a helpfu... [11:28:43] (03PS2) 10Umherirrender: Fix doc of PPFrame_Hash::cachedExpand [core] - 10https://gerrit.wikimedia.org/r/151610 [11:31:30] (03PS2) 10Siebrand: Fix spelling and make category desc consistent [core] - 10https://gerrit.wikimedia.org/r/151612 [11:31:33] (03CR) 10Gilles: [C: 04-1] Move confirmCloseWindow to core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151128 (owner: 10MarkTraceur) [11:35:58] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/151207 (owner: 10Florianschmidtwelzow) [11:37:15] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (031 comment) [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/151444 (https://bugzilla.wikimedia.org/68962) (owner: 10Florianschmidtwelzow) [11:38:45] (03CR) 10Paladox: "Well the B and I in wikiedit show really weird and this fixes the images." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [11:39:55] (03PS1) 10Paladox: WikiEditor: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 [11:40:03] (03PS2) 10Paladox: WikiEditor: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 [11:41:54] (03PS3) 10Paladox: WikiEditor: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 [11:42:03] (03PS4) 10Paladox: WikiEditor: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 [11:43:12] (03CR) 10Paladox: "And also see I2a223e202aa488f0e83e663e490ee009da686687 for converting .css to .less." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [11:44:22] (03PS3) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [11:46:14] (03PS1) 10Prtksxna: Remove emacs back up file [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151618 [11:46:16] (03PS1) 10Prtksxna: whereFrom: Add tooltips for the labels and flags [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151619 [11:46:18] (03PS1) 10Prtksxna: dmcaRequests: Add tooltips for labels and flags [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151620 [11:50:07] (03PS24) 10Paladox: Update jquery.form.js [core] - 10https://gerrit.wikimedia.org/r/139688 [11:50:22] (03PS34) 10Paladox: Update jquery.chosen folder and files [core] - 10https://gerrit.wikimedia.org/r/139699 (https://bugzilla.wikimedia.org/69065) [11:51:54] (03PS26) 10Paladox: Update jquery.mockjax.js to v1.5.3 [core] - 10https://gerrit.wikimedia.org/r/139693 [12:02:23] 3MediaWiki / 3Skin and page rendering: The magic word "notitle" causes some errors in the main MediaWiki page as of wmf10 - 10https://bugzilla.wikimedia.org/66927#c7 (10deanator71) I did not purge the main page to any extent. So it must be a browser cache error or improper rendering that causes errors on Saf... [12:06:40] (03CR) 10Hashar: [C: 032] "Well done thank you!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151205 (https://bugzilla.wikimedia.org/69024) (owner: 10Dbrant) [12:06:49] (03Merged) 10jenkins-bot: Set apps-android-wikipedia-maven-checkstyle to Voting. [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151205 (https://bugzilla.wikimedia.org/69024) (owner: 10Dbrant) [12:13:11] (03PS2) 10Tweichart: BS223: styling + fixes [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151276 [12:14:51] (03CR) 10Tweichart: BS223: styling + fixes (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151276 (owner: 10Tweichart) [12:15:25] (03PS2) 10Hashar: Use the verbose re flag to unminify the email_filter [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151249 (owner: 10Awight) [12:15:37] (03CR) 10Hashar: "PS2: use space for indentations." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151249 (owner: 10Awight) [12:15:45] (03CR) 10Tweichart: [C: 032 V: 032] BS223: styling + fixes [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151276 (owner: 10Tweichart) [12:18:33] (03PS2) 10Hashar: Sort the email_filter literal [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151250 (owner: 10Awight) [12:19:07] (03CR) 10Hashar: "rebased, parent had tabulations for indentation, we use spaces." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151250 (owner: 10Awight) [12:19:28] (03PS2) 10Hashar: zuul config for pywikibot-bots-CommonsDelinker-tox-flake8 job (nonvoting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151366 (owner: 10Legoktm) [12:20:35] (03CR) 10Hashar: [C: 032] "Deployed pywikibot-bots-CommonsDelinker-tox-flake8" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/151365 (owner: 10Legoktm) [12:21:00] (03CR) 10Hashar: [C: 032] "deploying :)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151366 (owner: 10Legoktm) [12:21:07] (03Merged) 10jenkins-bot: zuul config for pywikibot-bots-CommonsDelinker-tox-flake8 job (nonvoting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151366 (owner: 10Legoktm) [12:21:10] (03Merged) 10jenkins-bot: Add tox (flake8) job for pywikibot/bots/CommonsDelinker [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/151365 (owner: 10Legoktm) [12:22:22] 3MediaWiki extensions / 3MaintenanceShell: MainteniceShell broken in MediaWiki 1.24 - 10https://bugzilla.wikimedia.org/69075#c4 (10paladox2015) Oh I doint know how to find the error output or if it is broken. [12:26:39] 3Wikimedia / 3Extension setup: Product review BounceHandler extension for deployement - 10https://bugzilla.wikimedia.org/69098 (10Tony Thomas) 3NEW p:3Unprio s:3normal a:3None Sub part of Bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=69019 Extension Wikipage: https://www.mediawiki.org/wiki/Ext... [12:27:23] 3Wikimedia / 3Extension setup: Product review BounceHandler extension for deployement - 10https://bugzilla.wikimedia.org/69098 (10Tony Thomas) [12:27:23] 3Wikimedia / 3Extension setup: Review and deploy BounceHandler extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/69019 (10Tony Thomas) [12:29:09] 3Wikimedia / 3Extension setup: Security review BounceHandler extension for deployement - 10https://bugzilla.wikimedia.org/69099 (10Tony Thomas) 3NEW p:3Unprio s:3normal a:3None Sub part of Bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=69019 Quoting: https://bugzilla.wikimedia.org/show_bug.cgi... [12:29:36] (03PS2) 10Tweichart: BS223 Facelist: Preferences [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/151270 [12:29:38] 3Wikimedia / 3Extension setup: Review and deploy BounceHandler extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/69019 (10Tony Thomas) [12:29:38] 3Wikimedia / 3Extension setup: Security review BounceHandler extension for deployement - 10https://bugzilla.wikimedia.org/69099 (10Tony Thomas) [12:31:38] 3Wikimedia / 3Extension setup: Review and deploy BounceHandler extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/69019 (10Tony Thomas) [12:31:39] 3Wikimedia / 3Extension setup: Performance review BounceHandler extension for Deployement - 10https://bugzilla.wikimedia.org/69100 (10Tony Thomas) [12:31:40] 3Wikimedia / 3Extension setup: Performance review BounceHandler extension for Deployement - 10https://bugzilla.wikimedia.org/69100 (10Tony Thomas) 3NEW p:3Unprio s:3normal a:3None Sub part of Bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=69019 Quoting: https://bugzilla.wikimedia.org/show_bug.... [12:39:22] 3MediaWiki extensions / 3MaintenanceShell: MainteniceShell broken in MediaWiki 1.24 - 10https://bugzilla.wikimedia.org/69075#c5 (10Andre Klapper) Then describe what exactly "is broken" please, because so far you have not described any bug at all in this report. [12:40:50] (03PS1) 10Tweichart: [WIP] BS223: ContextMenu [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151625 [12:42:09] 3Wikimedia / 3Extension setup: Architecture review for BounceHandler extension - 10https://bugzilla.wikimedia.org/69101 (10Tony Thomas) 3NEW p:3Unprio s:3normal a:3None Sub part of Bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=69019 Extension Wikipage: https://www.mediawiki.org/wiki/Extension:... [12:43:38] 3Wikimedia / 3Extension setup: Review and deploy BounceHandler extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/69019 (10Tony Thomas) [12:43:39] 3Wikimedia / 3Extension setup: Architecture review for BounceHandler extension - 10https://bugzilla.wikimedia.org/69101 (10Tony Thomas) [12:43:56] (03CR) 10Deepali: Add category:Book:Book_name to all pages when new sections are imported. (031 comment) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/151397 (https://bugzilla.wikimedia.org/66775) (owner: 10Deepali) [12:44:03] (03CR) 10Hashar: Change mediawiki/core/vendor to mediawiki/vendor (031 comment) [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151227 (https://bugzilla.wikimedia.org/68485) (owner: 10BryanDavis) [12:44:37] (03PS1) 10Lokal Profil: Make
warning not trigger [extensions/Popups] - 10https://gerrit.wikimedia.org/r/151626 [12:44:41] (03PS2) 10Hashar: Change mediawiki/core/vendor to mediawiki/vendor [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151227 (https://bugzilla.wikimedia.org/68485) (owner: 10BryanDavis) [12:44:44] (03CR) 10Smuggli: [C: 031 V: 031] BS223 Facelist: Preferences [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/151270 (owner: 10Tweichart) [12:45:07] 3Wikimedia / 3Extension setup: Review and deploy BounceHandler extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/69019#c3 (10Tony Thomas) Requested separate bugs for Architecture, Performance, Security and Product reviews. Please check See Also link for the links. [12:45:07] (03PS3) 10Deepali: Add category:Book:Book_name to all pages when new sections are imported. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/151397 (https://bugzilla.wikimedia.org/66775) [12:45:12] (03CR) 10Hashar: [C: 032] "Good catch. I would probably never have though about editing that file :]" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151227 (https://bugzilla.wikimedia.org/68485) (owner: 10BryanDavis) [12:45:23] (03Merged) 10jenkins-bot: Change mediawiki/core/vendor to mediawiki/vendor [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151227 (https://bugzilla.wikimedia.org/68485) (owner: 10BryanDavis) [12:47:34] (03CR) 10Hashar: "Thanks for the clean up. I generated the mediawiki-vendor-integration job." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141819 (owner: 10Hashar) [12:47:39] (03PS2) 10Hashar: Switch from mediawiki/core/vendor to mediawiki/vendor [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151132 (https://bugzilla.wikimedia.org/68485) (owner: 10BryanDavis) [12:48:17] (03CR) 10Hashar: [C: 032] "Thanks! I have deployed the Jenkins job rename" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151132 (https://bugzilla.wikimedia.org/68485) (owner: 10BryanDavis) [12:48:28] (03Merged) 10jenkins-bot: Switch from mediawiki/core/vendor to mediawiki/vendor [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151132 (https://bugzilla.wikimedia.org/68485) (owner: 10BryanDavis) [12:48:59] (03PS1) 10Tweichart: BS223: Resized profile img [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/151628 [12:49:38] (03CR) 10Hashar: "Note: i deployed it by renaming the old job then updating the conf." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141819 (owner: 10Hashar) [12:50:57] (03Abandoned) 10Hashar: Refactor UploadWizard-API job to use a single template [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129661 (owner: 10Hashar) [12:54:06] (03CR) 10Smuggli: "Please add en and qqq" (032 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151625 (owner: 10Tweichart) [12:54:35] (03CR) 10Smuggli: [C: 032 V: 032] BS223: Resized profile img [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/151628 (owner: 10Tweichart) [12:55:07] 3MediaWiki / 3Skin and page rendering: The magic word "notitle" causes some errors in the main MediaWiki page as of wmf10 - 10https://bugzilla.wikimedia.org/66927 (10Andre Klapper) p:5Normal>3Lowest [12:56:25] 3Wikimedia / 3Extension setup: Security review BounceHandler extension for deployement - 10https://bugzilla.wikimedia.org/69099 (10Andre Klapper) p:5Unprio>3Normal a:3Chris Steipp [12:56:25] 3Wikimedia / 3Extension setup: Review and deploy BounceHandler extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/69019 (10Andre Klapper) [12:56:25] 3Wikimedia / 3Extension setup: Product review BounceHandler extension for deployement - 10https://bugzilla.wikimedia.org/69098 (10Andre Klapper) [12:56:26] 3Wikimedia / 3Extension setup: Review and deploy BounceHandler extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/69019 (10Andre Klapper) [12:56:39] 3Wikimedia / 3Extension setup: Performance review BounceHandler extension for Deployment - 10https://bugzilla.wikimedia.org/69100 (10Andre Klapper) p:5Unprio>3Normal [12:56:39] 3Wikimedia / 3Extension setup: Architecture review for BounceHandler extension - 10https://bugzilla.wikimedia.org/69101 (10Andre Klapper) [13:01:31] (03PS1) 10Hashar: tox/flake8 job for jouncebot [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/151629 [13:02:05] (03CR) 10Hashar: [C: 032] tox/flake8 job for jouncebot [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/151629 (owner: 10Hashar) [13:02:30] andre__: :) Thanks ! [13:02:46] tonythomas, heh, sure :) [13:03:21] (03Merged) 10jenkins-bot: tox/flake8 job for jouncebot [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/151629 (owner: 10Hashar) [13:04:02] (03CR) 10leucosticte: "Would it be practical to put the data in log_params instead? Or would a serialized array with hundreds of thousands of keys (e.g. "rev1", " [core] - 10https://gerrit.wikimedia.org/r/151309 (https://bugzilla.wikimedia.org/69049) (owner: 10leucosticte) [13:04:48] (03PS2) 10Hashar: Switch jouncebot to use tox [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150058 (owner: 10Yuvipanda) [13:05:18] (03CR) 10Hashar: [C: 032] "rebased. I kept the yamllint job around." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150058 (owner: 10Yuvipanda) [13:05:26] (03Merged) 10jenkins-bot: Switch jouncebot to use tox [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150058 (owner: 10Yuvipanda) [13:06:38] 3MediaWiki / 3Skin and page rendering: The magic word "notitle" causes some errors in the main MediaWiki page as of wmf10 - 10https://bugzilla.wikimedia.org/66927#c8 (10deanator71) I do not think that this is a bug with the MediaWiki software. It works for me now, for some reason. It is now displaying correc... [13:06:52] 3MediaWiki / 3Skin and page rendering: The magic word "notitle" causes some errors in the main MediaWiki page as of wmf10 - 10https://bugzilla.wikimedia.org/66927 (10deanator71) [13:07:19] (03PS1) 10Paladox: Update Moment.js from 2.7.0 to 2.8.1 [core] - 10https://gerrit.wikimedia.org/r/151630 [13:07:37] (03PS2) 10Paladox: Update Moment.js from 2.7.0 to 2.8.1 [core] - 10https://gerrit.wikimedia.org/r/151630 [13:13:07] 3MediaWiki / 3Skin and page rendering: The magic word "notitle" causes some errors in the main MediaWiki page as of wmf10 - 10https://bugzilla.wikimedia.org/66927#c9 (10deanator71) I think my browser just went crazy about rendering the page and decided to render it incorrectly so it will fool me into thinkin... [13:14:07] 3MediaWiki / 3User login and signup: Give users a hint that they can use [[Special:PasswordReset]] to recover user name by email address - 10https://bugzilla.wikimedia.org/51807#c1 (10Nemo) Hint where? I now see on http://en.wikipedia.beta.wmflabs.org/wiki/Special:PasswordReset : Reset password Fill in one... [13:16:26] (03CR) 10Hashar: "recheck" [core] - 10https://gerrit.wikimedia.org/r/151630 (owner: 10Paladox) [13:17:07] (03CR) 10Hashar: "recheck" [core] - 10https://gerrit.wikimedia.org/r/151630 (owner: 10Paladox) [13:18:20] (03PS1) 10Tweichart: BS223: Loggedout display [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/151631 [13:18:22] 3MediaWiki / 3Parser: generalize function switchPrefTab() (previously tabbedprefs()) - 10https://bugzilla.wikimedia.org/12610 (10Andre Klapper) [13:19:35] (03CR) 10Paladox: "Hi recheck what." [core] - 10https://gerrit.wikimedia.org/r/151630 (owner: 10Paladox) [13:19:43] (03PS8) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/92621 [13:19:51] (03CR) 10Hashar: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/92621 (owner: 10Hashar) [13:20:09] 3MediaWiki / 3User login and signup: Special:PasswordReset locks out of account: "Incorrect password entered" - 10https://bugzilla.wikimedia.org/69102 (10Nemo) 3NEW p:3Unprio s:3critic a:3None Spotted by Elitre and confirmed by me on translatewiki.net, verified by me on http://en.wikipedia.beta.wmfla... [13:20:37] 3MediaWiki / 3User login and signup: Special:PasswordReset locks out of account: "Incorrect password entered" - 10https://bugzilla.wikimedia.org/69102 (10Nemo) p:5Unprio>3Highes [13:20:50] (03PS3) 10Paladox: Update Moment.js from 2.7.0 to 2.8.1 [core] - 10https://gerrit.wikimedia.org/r/151630 [13:21:53] 3MediaWiki / 3User login and signup: Special:PasswordReset locks out of account: "Incorrect password entered" - 10https://bugzilla.wikimedia.org/69102 (10Andre Klapper) [13:21:53] 3MediaWiki / 3Database: Oracle DB support (tracking) - 10https://bugzilla.wikimedia.org/38916 (10Andre Klapper) [13:22:09] 3Wikimedia / 3General/Unknown: Next wmf deployment (tracking) - 10https://bugzilla.wikimedia.org/38865 (10Andre Klapper) [13:22:09] 3MediaWiki / 3User login and signup: Special:PasswordReset locks out of account: "Incorrect password entered" - 10https://bugzilla.wikimedia.org/69102 (10Andre Klapper) [13:22:09] 3MediaWiki / 3Database: Oracle DB support (tracking) - 10https://bugzilla.wikimedia.org/38916 (10Andre Klapper) [13:23:52] 3MediaWiki / 3Internationalization: unserialize() error in LocalisationCache.php on MySQL - 10https://bugzilla.wikimedia.org/64602#c6 (10Andre Klapper) Jamie: I assume this is still a problem in 1.23.2? [13:26:22] 3MediaWiki extensions / 3FlaggedRevs: Setting "Revision displayed on default page view" does not work; blanking $wgFlaggedRevsExceptions helps - 10https://bugzilla.wikimedia.org/65574 (10Andre Klapper) [13:27:10] (03PS4) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [13:27:21] 3MediaWiki / 3User login and signup: Give users a hint that they can use [[Special:PasswordReset]] to recover user name by email address - 10https://bugzilla.wikimedia.org/51807#c2 (10Liangent) (In reply to Nemo from comment #1) > Hint where? I now see on > http://en.wikipedia.beta.wmflabs.org/wiki/Special:P... [13:27:33] (03PS5) 10Paladox: WikiEditor: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 [13:27:48] (03PS6) 10Paladox: WikiEditor: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 [13:28:08] (03PS5) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [13:31:40] (03CR) 10Hashar: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/92621 (owner: 10Hashar) [13:36:07] 3MediaWiki / 3User login and signup: On Special:UserLogin, hint that Special:PasswordReset can also tell username - 10https://bugzilla.wikimedia.org/51807#c3 (10Nemo) s:5enhanc>3normal Ok, updating summary. This is a regression caused by the (mostly) undocumented 1.22 changes to login: https://www.mediaw... [13:37:51] (03PS2) 10Tweichart: BS223: Loggedout display [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/151631 [13:38:42] (03PS1) 10Smuggli: Added a couple of missing keys for preferences [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/151632 [13:42:00] (03CR) 10Smuggli: [C: 031 V: 031] BS223: Loggedout display [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/151631 (owner: 10Tweichart) [13:44:16] (03PS1) 10Smuggli: Added missing missing key for user sidebar section [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151634 [14:00:31] (03PS1) 1001tonythomas: Moved the header extraction functions to separate class [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151635 [14:01:00] (03PS3) 10Smuggli: Change event listener [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151607 [14:01:02] (03PS1) 10Smuggli: Added GENDER support [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151636 [14:01:29] (03CR) 10Smuggli: [C: 032 V: 032] Change event listener [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151607 (owner: 10Smuggli) [14:03:31] (03PS2) 10Smuggli: Added GENDER support [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151636 [14:04:31] (03PS1) 10Hashar: pywikibot-core-tox-nose job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/151637 [14:05:42] (03PS2) 1001tonythomas: Moved the header extraction functions to separate class [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151635 [14:05:46] (03PS1) 10Hashar: Experimental pywikibot-core-tox-nose [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151638 [14:05:52] (03CR) 10Hashar: [C: 032] pywikibot-core-tox-nose job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/151637 (owner: 10Hashar) [14:06:07] (03CR) 10Hashar: [C: 032] Experimental pywikibot-core-tox-nose [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151638 (owner: 10Hashar) [14:06:25] (03Merged) 10jenkins-bot: Experimental pywikibot-core-tox-nose [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151638 (owner: 10Hashar) [14:07:17] (03Merged) 10jenkins-bot: pywikibot-core-tox-nose job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/151637 (owner: 10Hashar) [14:09:19] (03PS1) 10Paladox: Update auth link [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/151640 [14:09:29] (03PS2) 10Paladox: Update auth link [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/151640 [14:09:43] (03PS3) 10Paladox: TwitterLogin: Update auth link [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/151640 [14:13:22] 3Wikimedia / 3Deployment systems: Rename mediawiki/core/vendor to mediawiki/vendor - 10https://bugzilla.wikimedia.org/68485#c13 (10Antoine "hashar" Musso) 5PATC>3NEW Continuous integration related patches have all been merged/deployed including the experimental jobs based on Zuul cloner. Thanks Bryan! [14:16:31] (03PS4) 10Paladox: TwitterLogin: Update auth link [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/151640 [14:17:46] (03CR) 10Anomie: [C: 04-1] "Class naming could use work, too: The classes could easily be named to more clearly indicate the relationship, such as renaming the subcla" (033 comments) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151635 (owner: 1001tonythomas) [14:19:09] 3MediaWiki extensions / 3WikidataRepo: Rewrite SpecialMergeItems based on ItemMergeInteractor - 10https://bugzilla.wikimedia.org/69106 (10Daniel Kinzler) 3NEW p:3Unprio s:3normal a:3Wikidata bugs SpecialMergeItems shoudl be rewritten to use ItemMergeInteractor. Also, logic currently inherited from Sp... [14:19:23] 3MediaWiki extensions / 3WikidataRepo: Rewrite SpecialMergeItems based on ItemMergeInteractor - 10https://bugzilla.wikimedia.org/69106 (10Daniel Kinzler) [14:19:23] 3MediaWiki extensions / 3WikidataRepo: Factor interaction logic out of MergeItems API module, for re-use in SpecialMergeItems - 10https://bugzilla.wikimedia.org/68730 (10Daniel Kinzler) [14:22:37] 3MediaWiki extensions / 3WikidataRepo: Factor interaction logic out of MergeItems API module, for re-use in SpecialMergeItems - 10https://bugzilla.wikimedia.org/68730#c2 (10Daniel Kinzler) 5ASSI>3PATC Relevant patch https://gerrit.wikimedia.org/r/#/c/151145/ Should be sufficient, I made a new ticket for... [14:25:54] 3MediaWiki / 3Special pages: Add a logid parameter to Special:Log - 10https://bugzilla.wikimedia.org/69107 (10Nathan Larson) 3NEW p:3Unprio s:3normal a:3None Add a logid parameter to Special:Log so that there can be a link to a specific log event. E.g., http://foowiki.org/w/index.php/Special:Log?logi... [14:26:07] 3MediaWiki / 3Special pages: Add a logid parameter to Special:Log - 10https://bugzilla.wikimedia.org/69107 (10Nathan Larson) p:5Unprio>3Lowest s:5normal>3enhanc [14:26:53] (03PS1) 10Tweichart: BS223: Facelift [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/151641 [14:28:46] (03CR) 10Hashar: [C: 031] Switch from mw/core/vendor to mw/vendor [tools/release] - 10https://gerrit.wikimedia.org/r/151125 (https://bugzilla.wikimedia.org/68485) (owner: 10BryanDavis) [14:29:44] (03CR) 10Hashar: "recheck" [core] - 10https://gerrit.wikimedia.org/r/151630 (owner: 10Paladox) [14:29:49] (03CR) 10Anomie: SpecialEmailUser: Use Config instead of globals (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151525 (owner: 10Legoktm) [14:29:55] (03CR) 10Hashar: "'recheck' is used to retrigger Jenkins jobs :-)" [core] - 10https://gerrit.wikimedia.org/r/151630 (owner: 10Paladox) [14:29:57] (03CR) 10Reedy: [C: 032] Switch from mw/core/vendor to mw/vendor [tools/release] - 10https://gerrit.wikimedia.org/r/151125 (https://bugzilla.wikimedia.org/68485) (owner: 10BryanDavis) [14:30:10] (03PS1) 10Tweichart: BS223: Facelift [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151642 [14:30:19] (03Merged) 10jenkins-bot: Switch from mw/core/vendor to mw/vendor [tools/release] - 10https://gerrit.wikimedia.org/r/151125 (https://bugzilla.wikimedia.org/68485) (owner: 10BryanDavis) [14:31:06] (03CR) 10Hashar: [C: 031] Unify the spelling of MIME in documentation [core] - 10https://gerrit.wikimedia.org/r/149005 (owner: 10Rillke) [14:32:03] (03CR) 10Anomie: SpecialActiveusers: Use Config objects instead of globals (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151518 (owner: 10Legoktm) [14:32:37] 3MediaWiki extensions / 3WikidataRepo: Rewrite SpecialMergeItems based on ItemMergeInteractor - 10https://bugzilla.wikimedia.org/69106 (10tobias.gritschacher) p:5Unprio>3High s:5normal>3major [14:33:37] 3MediaWiki extensions / 3OpenStackManager: Add access to nova's admin api - 10https://bugzilla.wikimedia.org/47515#c1 (10Andre Klapper) (In reply to Ryan Lane from comment #0) > For a number of actions we need to use nova's admin API. We should add the > ability to access it. Any chance to elaborate what th... [14:33:43] (03PS3) 10Smuggli: Added GENDER support [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151636 [14:34:17] (03CR) 10Smuggli: [C: 032 V: 032] BS223: Facelift [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/151641 (owner: 10Tweichart) [14:34:38] (03CR) 10Smuggli: [C: 032 V: 032] BS223: Facelift [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151642 (owner: 10Tweichart) [14:35:18] (03CR) 10Hashar: "Can you move the code to tests/phpunit/includes/GlobalFunctions/wfAppendQueryTest.php instead please?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/149082 (owner: 10Taueres) [14:35:34] (03CR) 10Hashar: [C: 04-1] Add test cases for wfAppendQuery [core] - 10https://gerrit.wikimedia.org/r/149082 (owner: 10Taueres) [14:36:37] 3MediaWiki extensions / 3Semantic MediaWiki: Compatibility with MW 1.19 && PHP <5.3.6 broken due to NS usage - 10https://bugzilla.wikimedia.org/44892 (10Andre Klapper) s:5blocke>3major [14:36:55] (03CR) 10Anomie: [C: 04-1] Make log_params contain null revision rev_id and moved page ID (032 comments) [core] - 10https://gerrit.wikimedia.org/r/150969 (https://bugzilla.wikimedia.org/68930) (owner: 10leucosticte) [14:38:40] (03CR) 10Paladox: "Oh ok." [core] - 10https://gerrit.wikimedia.org/r/151630 (owner: 10Paladox) [14:39:10] (03CR) 10Paladox: "How would you do recheck for jenkins" [core] - 10https://gerrit.wikimedia.org/r/151630 (owner: 10Paladox) [14:39:34] (03PS1) 10Withoutaname: Change "ENGINE=HEAP" to "ENGINE=MEMORY" [core] - 10https://gerrit.wikimedia.org/r/151643 [14:40:24] (03PS5) 10Paladox: TwitterLogin: Update auth link [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/151640 [14:40:38] (03PS6) 10Paladox: TwitterLogin: Update auth link [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/151640 [14:41:22] 3Datasets / 3General/Unknown: mwxml2sql fails for `mediawiki' versions above 1.21; patch posted for review - 10https://bugzilla.wikimedia.org/66663#c5 (10Andre Klapper) Ariel: Any chance to review the 20 lines patch in Gerrit? [14:41:32] (03CR) 10Anomie: [C: 031] "I still think that if TitleValue isn't supposed to support interwiki prefixes, it shouldn't support any. But I won't insist. Ping me after" [core] - 10https://gerrit.wikimedia.org/r/150511 (https://bugzilla.wikimedia.org/68802) (owner: 10TTO) [14:41:37] 3MediaWiki extensions / 3Semantic MediaWiki: Compatibility with MW 1.19 && PHP <5.3.6 broken due to NS usage - 10https://bugzilla.wikimedia.org/44892 (10MWJames) 5NEW>3RESO/WOR [14:41:48] (03CR) 10Rillke: "Does this mean you +2 it if I rebase?" [core] - 10https://gerrit.wikimedia.org/r/149005 (owner: 10Rillke) [14:42:53] (03PS2) 10Pwirth: [WIP] UserSidebar Editing GUI [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151079 [14:44:52] 3Datasets / 3General/Unknown: Enable IPv6 on dumps.wikimedia.org - 10https://bugzilla.wikimedia.org/66996 (10Andre Klapper) s:5blocke>3major [14:49:06] (03PS1) 10Anomie: EditPage::newSectionSummary should return a value in all code paths [core] - 10https://gerrit.wikimedia.org/r/151645 [14:49:16] (03CR) 10Anomie: "Confirmed. Followup in Id63c3f3d2c180d193c37091dfe5f1c56e3edb45f." [core] - 10https://gerrit.wikimedia.org/r/144603 (https://bugzilla.wikimedia.org/67634) (owner: 10Anomie) [14:49:39] 3MediaWiki extensions / 3UniversalLanguageSelector: livePreview make 'Language settings' icon disappear - 10https://bugzilla.wikimedia.org/51029 (10Helder) [14:49:39] 3MediaWiki / 3JavaScript: Live preview (requires JavaScript) feature bugs (tracking) - 10https://bugzilla.wikimedia.org/39272 (10Helder) [14:49:40] 3MediaWiki / 3JavaScript: LivePreview doesn't allow interaction with page content outside of #wikiPreview (it is not passed to mw.hook) - 10https://bugzilla.wikimedia.org/69108 (10Helder) 3NEW p:3Unprio s:3normal a:3None Currently, LivePreview only passes the $wikiPreview to the hook https://github.c... [14:49:53] 3MediaWiki / 3JavaScript: Add mw.hook event for wikipage content ready - 10https://bugzilla.wikimedia.org/30713 (10Helder) [14:50:53] (03CR) 10Mglaser: [C: 032 V: 032] "Looks good" [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/151270 (owner: 10Tweichart) [14:50:58] (03PS3) 10Withoutaname: Move MediaWiki::parseTitle() to Title::newFromRequest() [core] - 10https://gerrit.wikimedia.org/r/146985 [14:52:20] (03CR) 10Anomie: [C: 031] "Seems sane. Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/148585 (https://bugzilla.wikimedia.org/64333) (owner: 10TTO) [14:52:28] (03CR) 10Mglaser: [C: 032 V: 032] "Looks good" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/151631 (owner: 10Tweichart) [14:53:07] (03PS7) 10Paladox: TwitterLogin: Update auth link [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/151640 [14:53:31] (03CR) 10Parent5446: [C: 04-1] "Static function can't use $this..." [core] - 10https://gerrit.wikimedia.org/r/150839 (owner: 10Withoutaname) [14:58:22] (03PS1) 10Florianschmidtwelzow: Don't override a new password in loadFromRow() [core] - 10https://gerrit.wikimedia.org/r/151647 (https://bugzilla.wikimedia.org/69102) [15:05:22] 3MediaWiki / 3User login and signup: Special:PasswordReset locks out of account: "Incorrect password entered" - 10https://bugzilla.wikimedia.org/69102#c2 (10Tyler Romeo) I think I know the cause of this issue, but I cannot get email working on my vagrant instance, so if somebody else could test the patch onc... [15:06:38] 3MediaWiki / 3User login and signup: Special:PasswordReset locks out of account: "Incorrect password entered" - 10https://bugzilla.wikimedia.org/69102#c3 (10Florian) @Tyler: I can test, but maybe it's the same approach as my patch? :) [15:11:20] (03PS1) 10Parent5446: Add loadPasswords() calls to User password mutators [core] - 10https://gerrit.wikimedia.org/r/151649 (https://bugzilla.wikimedia.org/69102) [15:12:47] (03PS5) 10Ori.livneh: HTMLForm: Avoid usage of non-standard 'flags' parameter of String#replace [core] - 10https://gerrit.wikimedia.org/r/146931 (https://bugzilla.wikimedia.org/68050) (owner: 10Anomie) [15:12:52] (03CR) 10Ori.livneh: [C: 032] HTMLForm: Avoid usage of non-standard 'flags' parameter of String#replace [core] - 10https://gerrit.wikimedia.org/r/146931 (https://bugzilla.wikimedia.org/68050) (owner: 10Anomie) [15:16:20] (03CR) 10jenkins-bot: [V: 04-1] HTMLForm: Avoid usage of non-standard 'flags' parameter of String#replace [core] - 10https://gerrit.wikimedia.org/r/146931 (https://bugzilla.wikimedia.org/68050) (owner: 10Anomie) [15:19:37] (03PS1) 10Withoutaname: Remove User::newFatalPermissionDeniedStatus() [core] - 10https://gerrit.wikimedia.org/r/151651 [15:23:08] (03CR) 10Anomie: [C: 032] "Try again, Jenkins. The qunit failure looks bogus." [core] - 10https://gerrit.wikimedia.org/r/146931 (https://bugzilla.wikimedia.org/68050) (owner: 10Anomie) [15:24:51] (03CR) 10Withoutaname: "I still see uses of $wgProfileToDatabase left in core, such as MysqlUpdater and SqliteUpdater. Should those instances all be removed?" [core] - 10https://gerrit.wikimedia.org/r/125059 (owner: 10Aaron Schulz) [15:25:43] (03Merged) 10jenkins-bot: HTMLForm: Avoid usage of non-standard 'flags' parameter of String#replace [core] - 10https://gerrit.wikimedia.org/r/146931 (https://bugzilla.wikimedia.org/68050) (owner: 10Anomie) [15:26:03] (03PS1) 10Umherirrender: Add gender for upload log entries [core] - 10https://gerrit.wikimedia.org/r/151653 [15:27:31] (03PS1) 10Tweichart: BS223 Facelift: changed back icon [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/151654 [15:28:41] (03CR) 10Smuggli: [C: 04-1] [WIP] UserSidebar Editing GUI (032 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151079 (owner: 10Pwirth) [15:29:52] 3Wikimedia / 3Extension setup: Enable Guided Tour extension on Te wiki (te.wikipedia.org) - 10https://bugzilla.wikimedia.org/69103#c2 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc Thanks for the interest in deploying this! Is there a community consensus to point to? [15:30:01] (03PS1) 10Tweichart: BS 223: Facelift [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/151655 [15:31:07] 3MediaWiki / 3Skin and page rendering: The magic word "notitle" causes some errors in the main MediaWiki page as of wmf10 - 10https://bugzilla.wikimedia.org/66927#c10 (10Andre Klapper) 5UNCO>3RESO/WOR Alright then. :) [15:31:53] 3MediaWiki extensions / 3SecurePoll: SecurePoll: "Approval vote" ignores everything except the first and last options - 10https://bugzilla.wikimedia.org/68050#c8 (10Brad Jorsch) 5PATC>3RESO/FIX Now it's merged. [15:35:26] (03PS4) 10MarkTraceur: Make a Thanks UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151225 [15:35:40] (03CR) 10MarkTraceur: "Fixed, Gilles. Thanks." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151225 (owner: 10MarkTraceur) [15:35:44] (03PS5) 10MarkTraceur: Make a Thanks UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151225 [15:35:54] (03CR) 10jenkins-bot: [V: 04-1] Make a Thanks UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151225 (owner: 10MarkTraceur) [15:36:27] (03CR) 10MarkTraceur: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151225 (owner: 10MarkTraceur) [15:40:18] (03CR) 10Smuggli: [C: 031 V: 031] BS 223: Facelift [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/151655 (owner: 10Tweichart) [15:40:47] (03CR) 10Smuggli: [C: 032 V: 032] BS223 Facelift: changed back icon [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/151654 (owner: 10Tweichart) [15:41:52] 3Wikimedia / 3Extension setup: Enable Guided Tour extension on Te wiki (te.wikipedia.org) - 10https://bugzilla.wikimedia.org/69103#c3 (10Rahmanuddin Shaik) I have initiated discussion here : https://te.wikipedia.org/wiki/%E0%B0%B5%E0%B0%BF%E0%B0%95%E0%B1%80%E0%B0%AA%E0%B1%80%E0%B0%A1%E0%B0%BF%E0%B0%AF%E0%B0%... [15:45:22] 3Wikimedia / 3Deployment systems: [OPS] Jenkins: Package php5-parsekit missing in Trusty - 10https://bugzilla.wikimedia.org/68255#c6 (10Alexandros Kosiaris) Having looked at this too I see that php5-parsekit may very well be non compilable on trusty. I just tried and got pages upon pages of errors. The first... [15:46:56] (03PS1) 10Withoutaname: Remove User::passwordChangeInputAttribs() [core] - 10https://gerrit.wikimedia.org/r/151662 [15:50:32] (03CR) 10Florianschmidtwelzow: "tested, works for me. But don't know, if it's the solution, so no rating." [core] - 10https://gerrit.wikimedia.org/r/151649 (https://bugzilla.wikimedia.org/69102) (owner: 10Parent5446) [15:50:37] 3MediaWiki extensions / 3SemanticForms: "The specified target page _ is invalid" after completing captcha with SemanticForms - 10https://bugzilla.wikimedia.org/61794#c5 (10Andre Klapper) s:5blocke>3major Al Johnson: Does this problem still happen in a supported MediaWiki version (1.19, 1.22, 1.23 current... [15:51:23] 3MediaWiki extensions / 3SemanticForms: Prevent double save on double click on "Save page" button - 10https://bugzilla.wikimedia.org/67409#c5 (10Yaron Koren) No. [15:51:23] 3Utilities / 3mwdumper: mwdumper crashes with mysql syntax error - 10https://bugzilla.wikimedia.org/24559 (10Andre Klapper) s:5blocke>3critic [15:52:07] 3MediaWiki extensions / 3SemanticForms: Catchable fatal error: Argument 1 passed to Article::__construct() must be an instance of Title, null given, called in SF_AutoeditAPI.php on line 318 - 10https://bugzilla.wikimedia.org/58022#c10 (10Andre Klapper) Al Johnson: Does this problem still happen in a supporte... [15:53:23] 3Wikimedia / 3Site requests: Disable Media Viewer software feature by default on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69080#c5 (10Bawolff (Brian Wolff)) The rfc has been pending for more than a month now. Surely waiting a couple days (probably 1-2 days at the most. Wikimania starts on wed) so... [15:54:00] (03PS1) 10Gerrit Patch Uploader: Update links for software homepages [core] - 10https://gerrit.wikimedia.org/r/151663 [15:54:02] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/151663 (owner: 10Gerrit Patch Uploader) [15:57:05] (03PS3) 1001tonythomas: Moved the header extraction functions to separate class [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151635 [16:00:18] (03PS8) 10Anomie: Tests for API action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/92168 (owner: 10Legoktm) [16:00:31] (03PS3) 10BryanDavis: Add git::install resource and fix git::clone [vagrant] - 10https://gerrit.wikimedia.org/r/151384 [16:03:11] (03PS1) 10Yaron Koren: Version 1.8 [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/151664 [16:03:49] (03PS1) 10Wctaiwan: Escape invalid target strings in message [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151665 [16:04:35] (03CR) 10Aklapper: "If you have split up the patch into patches only fixing one thing at a time, please mark this patchset as "abandoned" yourself. Thanks." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [16:05:05] (03CR) 10Wctaiwan: Descriptive error on special page (031 comment) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151380 (owner: 10Wctaiwan) [16:06:15] (03CR) 10Yaron Koren: [C: 032] Version 1.8 [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/151664 (owner: 10Yaron Koren) [16:06:33] (03CR) 10Yaron Koren: [V: 032] Version 1.8 [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/151664 (owner: 10Yaron Koren) [16:07:15] (03CR) 10Anomie: [C: 032] Tests for API action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/92168 (owner: 10Legoktm) [16:08:30] (03CR) 10Ori.livneh: [C: 032] "Nice work. As indicated on IRC I think "git stash" would be better than "git clean", but this is good for now." [vagrant] - 10https://gerrit.wikimedia.org/r/151384 (owner: 10BryanDavis) [16:08:35] (03Merged) 10jenkins-bot: Add git::install resource and fix git::clone [vagrant] - 10https://gerrit.wikimedia.org/r/151384 (owner: 10BryanDavis) [16:08:51] (03PS7) 10Ori.livneh: Switch jobrunner to JSON config [vagrant] - 10https://gerrit.wikimedia.org/r/150243 (https://bugzilla.wikimedia.org/68785) (owner: 10MaxSem) [16:09:45] (03Merged) 10jenkins-bot: Tests for API action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/92168 (owner: 10Legoktm) [16:11:49] (03PS1) 10Wctaiwan: Don't allow interwikis or special pages as targets [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151666 [16:11:53] (03Abandoned) 10Paladox: Update WikiEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [16:12:45] (03PS1) 10Prtksxna: User Data Graph: Add tooltips for flags and labels [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151667 [16:12:47] (03PS1) 10Prtksxna: Add new flags and fix country names [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151668 [16:12:49] (03PS1) 10Prtksxna: whereFrom: Put the unknown bar at the bottom [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151669 [16:16:06] (03CR) 10Ori.livneh: [C: 032] Switch jobrunner to JSON config [vagrant] - 10https://gerrit.wikimedia.org/r/150243 (https://bugzilla.wikimedia.org/68785) (owner: 10MaxSem) [16:16:11] (03Merged) 10jenkins-bot: Switch jobrunner to JSON config [vagrant] - 10https://gerrit.wikimedia.org/r/150243 (https://bugzilla.wikimedia.org/68785) (owner: 10MaxSem) [16:16:21] (03PS4) 1001tonythomas: Moved the header extraction functions to separate class [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151635 [16:16:50] (03PS5) 1001tonythomas: Moved the header extraction functions to separate class [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151635 [16:20:16] (03PS1) 10Prtksxna: Stop showing broken image link if flag isn't available [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151670 [16:20:54] (03CR) 10Helder.wiki: "Just in case anyone is still looking for a working version of the linkFA script, I'm keeping this one on English Wikipedia:" [core] - 10https://gerrit.wikimedia.org/r/94899 (https://bugzilla.wikimedia.org/56819) (owner: 10Amire80) [16:22:00] thanks helderwiki [16:22:06] :-) [16:23:12] (03CR) 10MarkTraceur: Move confirmCloseWindow to core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151128 (owner: 10MarkTraceur) [16:23:41] BTW Nemo_bis I'll be importing it from enwiki for now, but if someone really want it to be on MetaWiki we can change the link (it will be easier than the current task of checking the current code to see if it can be replaced by the link) [16:24:03] I'm also adding a note to the meta page about the badges, indicating which wikis are importing the English version [16:24:53] (03CR) 10Vogone: [C: 031] "Tedious manual work is done when I've plenty of other things to do." [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/150463 (owner: 10Ebe123) [16:25:25] 3MediaWiki extensions / 3WikidataRepo: [Monolingual] Valid language codes are not saved when typed manually - 10https://bugzilla.wikimedia.org/67396#c2 (10Thiemo Mättig) 5ASSI>3PATC https://github.com/wmde/ValueView/pull/102 [16:26:21] (03PS3) 10Legoktm: Remove unused globals [core] - 10https://gerrit.wikimedia.org/r/151592 (owner: 10Addshore) [16:26:26] (03CR) 10Legoktm: [C: 032] Remove unused globals [core] - 10https://gerrit.wikimedia.org/r/151592 (owner: 10Addshore) [16:28:00] (03CR) 10Legoktm: SpecialEmailUser: Use Config instead of globals (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151525 (owner: 10Legoktm) [16:28:32] (03CR) 10Legoktm: SpecialActiveusers: Use Config objects instead of globals (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151518 (owner: 10Legoktm) [16:29:28] (03PS3) 10Giuseppe Lavagetto: Make hhvm-luasandbox depend on hhvm-build and not on the package [php/luasandbox] - 10https://gerrit.wikimedia.org/r/150215 [16:29:36] (03CR) 10Ebe123: Add link to Special:PrefixIndex to Delete dialog (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151061 (https://bugzilla.wikimedia.org/30666) (owner: 10Ebe123) [16:29:56] (03Merged) 10jenkins-bot: Remove unused globals [core] - 10https://gerrit.wikimedia.org/r/151592 (owner: 10Addshore) [16:30:08] (03PS4) 10Ebe123: Add link to Special:PrefixIndex to Delete dialog [core] - 10https://gerrit.wikimedia.org/r/151061 (https://bugzilla.wikimedia.org/30666) [16:30:18] (03PS4) 10Giuseppe Lavagetto: Make hhvm-wikidiff2 depend on hhvm-api and not on the package [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/150217 [16:31:48] (03PS6) 1001tonythomas: Moved the header extraction functions to separate class [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151635 [16:32:18] (03PS4) 10Giuseppe Lavagetto: Make hhvm-fss depend on hhvm-api and not on the package [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/150216 [16:34:24] (03PS1) 10Prtksxna: Add viewBox in flags' SVGs so that it shows up properly in Firefox [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151671 [16:34:30] (03CR) 10Legoktm: [C: 032] Don't allow interwikis or special pages as targets [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151666 (owner: 10Wctaiwan) [16:34:54] (03PS1) 10leucosticte: Add logid parameter to Special:Log [core] - 10https://gerrit.wikimedia.org/r/151672 (https://bugzilla.wikimedia.org/69107) [16:37:35] (03CR) 10Legoktm: [C: 031] "Escaping looks good, will let Siebrand review the message changes." [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151665 (owner: 10Wctaiwan) [16:38:07] 3MediaWiki / 3Special pages: Add a logid parameter to Special:Log - 10https://bugzilla.wikimedia.org/69107#c2 (10Nathan Larson) 5PATC>3RESO/WON The usefulness of this is questionable, unless/until some functionality is developed to make it possible to cross-link from one log event to another in Special:L... [16:38:13] (03Abandoned) 10leucosticte: Add logid parameter to Special:Log [core] - 10https://gerrit.wikimedia.org/r/151672 (https://bugzilla.wikimedia.org/69107) (owner: 10leucosticte) [16:43:15] (03CR) 10Legoktm: [C: 04-1] Moved the header extraction functions to separate class (031 comment) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151635 (owner: 1001tonythomas) [16:45:10] (03PS1) 10Pastakhov: fix bug 69002 (v. 3.2.1) [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/151674 [16:46:57] (03CR) 10Pastakhov: [C: 032] fix bug 69002 (v. 3.2.1) [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/151674 (owner: 10Pastakhov) [16:47:05] (03Merged) 10jenkins-bot: fix bug 69002 (v. 3.2.1) [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/151674 (owner: 10Pastakhov) [16:50:55] (03PS7) 1001tonythomas: Moved the header extraction functions to separate class [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151635 [16:51:07] 3MediaWiki-Vagrant: Jobrunner configuration incompatible with current jobrunner php code - 10https://bugzilla.wikimedia.org/68785 (10Bryan Davis) 5PATC>3RESO/FIX [16:53:56] (03PS8) 1001tonythomas: Moved the header extraction functions to separate class [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151635 [16:56:26] (03CR) 10Legoktm: [C: 032] Moved the header extraction functions to separate class [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151635 (owner: 1001tonythomas) [16:56:32] (03Merged) 10jenkins-bot: Moved the header extraction functions to separate class [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151635 (owner: 1001tonythomas) [16:57:36] (03CR) 10Giuseppe Lavagetto: [C: 032 V: 032] Make hhvm-luasandbox depend on hhvm-build and not on the package [php/luasandbox] - 10https://gerrit.wikimedia.org/r/150215 (owner: 10Giuseppe Lavagetto) [16:58:19] (03CR) 10Giuseppe Lavagetto: [C: 032 V: 032] Make hhvm-fss depend on hhvm-api and not on the package [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/150216 (owner: 10Giuseppe Lavagetto) [16:58:34] (03CR) 10Giuseppe Lavagetto: [C: 032 V: 032] Make hhvm-wikidiff2 depend on hhvm-api and not on the package [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/150217 (owner: 10Giuseppe Lavagetto) [17:11:01] (03PS1) 10Giuseppe Lavagetto: fixup for debian/rules [php/luasandbox] - 10https://gerrit.wikimedia.org/r/151679 [17:11:25] (03CR) 10Giuseppe Lavagetto: [C: 032 V: 032] fixup for debian/rules [php/luasandbox] - 10https://gerrit.wikimedia.org/r/151679 (owner: 10Giuseppe Lavagetto) [17:13:37] 3Wikimedia / 3Site requests: Disable Media Viewer software feature by default on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69080#c6 (10Ryan (Rjd0060)) (In reply to Steinsplitter from comment #4) > What need to be discussed? Please respect the community wishes. The WMF only > exists because of the... [17:15:26] 3Wikimedia / 3Site requests: Disable Media Viewer software feature by default on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69080#c7 (10Ryan (Rjd0060)) (In reply to Ryan (Rjd0060) from comment #6) > (In reply to Steinsplitter from comment #4) > > What need to be discussed? Please respect the commun... [17:15:44] (03PS1) 10Giuseppe Lavagetto: fixup for debian/rules [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/151680 [17:19:52] 3Wikimedia / 3Site requests: Disable Media Viewer software feature by default on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69080 (10Nemo) [17:20:31] (03PS1) 10Giuseppe Lavagetto: fixup for debian/rules [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/151681 [17:20:36] (03CR) 10Giuseppe Lavagetto: [C: 032 V: 032] fixup for debian/rules [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/151680 (owner: 10Giuseppe Lavagetto) [17:21:00] (03CR) 10Giuseppe Lavagetto: [C: 032 V: 032] fixup for debian/rules [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/151681 (owner: 10Giuseppe Lavagetto) [17:29:05] (03PS1) 10Umherirrender: Migrate merge log to new log system [core] - 10https://gerrit.wikimedia.org/r/151683 [17:31:45] Hi all, can Jenkins do phpunit tests under hhvm/hiphop for the MW extensions? [17:39:21] 3Wikimedia / 3Site requests: Disable Media Viewer software feature by default on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69080#c8 (10Bawolff (Brian Wolff)) (In reply to Ryan (Rjd0060) from comment #) > (In reply to Ryan (Rjd0060) from comment #6) > > (In reply to Steinsplitter from comment #4) >... [17:49:51] (03PS1) 10Umherirrender: Remove 'move' from LogPage::getTitleLink [core] - 10https://gerrit.wikimedia.org/r/151684 [17:53:54] 3MediaWiki extensions / 3[other]: [MoveRevisions] Fix how revision move log entries appear in Special:Logs - 10https://bugzilla.wikimedia.org/69113 (10Nathan Larson) 3NEW p:3Unprio s:3normal a:3None Right now it just says "12:34, 1 August 2014 FooUser (Talk | contribs | block) moved revisions to FooT... [17:54:07] 3MediaWiki extensions / 3[other]: [MoveRevisions] Fix how revision move log entries appear in Special:Logs - 10https://bugzilla.wikimedia.org/69113 (10Nathan Larson) p:5Unprio>3Normal [17:56:50] (03CR) 10Jdlrobson: [C: 032] Hygiene: Cleanup undefined class warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151244 (owner: 10EBernhardson) [17:57:32] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Cleanup mismatched function parameters warning (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151245 (owner: 10EBernhardson) [17:57:50] (03PS2) 10Jdlrobson: Hygiene: Cleanup unused local variable warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151241 (owner: 10EBernhardson) [17:58:50] (03CR) 10Jdlrobson: [C: 032] Hygiene: Cleanup missing @return in docblock warning [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151246 (owner: 10EBernhardson) [17:59:09] (03PS2) 10Jdlrobson: Hygiene: Cleanup unused class aliases [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151242 (owner: 10EBernhardson) [17:59:44] (03PS3) 10Jdlrobson: Hygiene: Cleanup unused class aliases [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151242 (owner: 10EBernhardson) [18:04:24] 3MediaWiki extensions / 3[other]: [MoveRevisions] Clean up any page entries of pages from which revisions are moved - 10https://bugzilla.wikimedia.org/69115 (10Nathan Larson) 3NEW p:3Unprio s:3normal a:3None It's possible that page_latest of pages from which revisions are moved could end up pointing... [18:04:37] 3MediaWiki extensions / 3[other]: [MoveRevisions] Clean up any page entries of pages from which revisions are moved - 10https://bugzilla.wikimedia.org/69115 (10Nathan Larson) p:5Unprio>3Normal [18:15:07] 3Wikimedia / 3Site requests: Disable Media Viewer software feature by default on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69080#c9 (10Steinsplitter) Commons is a special place. It is not a encyclopedie like wikipedia. Commons is a bit unusable with this tools. We have Community consensus and i as... [18:16:37] (03PS8) 10Bsitu: Convert existing notifications to use user-locators [extensions/Echo] - 10https://gerrit.wikimedia.org/r/150763 (owner: 10EBernhardson) [18:18:07] 3Wikimedia / 3Site requests: Disable Media Viewer software feature by default on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69080#c10 (10Steinsplitter) * And i am not here to troll or PUSH my POV. I am here to help the Commons community. It is important that somone looks at this thinks and take car... [18:19:49] (03PS11) 10BryanDavis: Rethink multiwiki support [vagrant] - 10https://gerrit.wikimedia.org/r/149872 (https://bugzilla.wikimedia.org/68605) [18:23:28] (03CR) 10CSteipp: [C: 032] "Fixes the bug, and I think this is closer to how we typically handle the User cache. How we typically handle the cache is ugly and should " [core] - 10https://gerrit.wikimedia.org/r/151649 (https://bugzilla.wikimedia.org/69102) (owner: 10Parent5446) [18:24:56] anyone here able to help me with vagrant? I upgraded and i can't get it working at all [18:25:07] 3MediaWiki / 3General/Unknown: bin/ulimit5.sh isn't UNIX compliant - 10https://bugzilla.wikimedia.org/44568#c13 (10Bawolff (Brian Wolff)) Re comment 12: starting in 1.24 we will use bourne shell if bash is unavailable. [18:25:11] seems to be puppet related [18:25:18] jdlrobson: I'm about to get on a plane but I can help for a bit. [18:25:42] First question, did you `vagrant destroy` so that you would build a new VM? [18:25:56] We switched to Ubuntu 14.04 a month or so ago. [18:26:11] Puppet 3 and Ubuntu 14.04 are now expected [18:26:23] bd808: yeh that's what got me into this mess :( [18:26:41] http://pastebin.com/TJrr7btb < bd808 [18:26:46] that's what i get when i run vagrant provision [18:26:52] i'm on a mac [18:26:52] (03Merged) 10jenkins-bot: Add loadPasswords() calls to User password mutators [core] - 10https://gerrit.wikimedia.org/r/151649 (https://bugzilla.wikimedia.org/69102) (owner: 10Parent5446) [18:27:23] There was a fix for jobrunner that was just merged about 2 hours ago [18:27:34] i'm running latest master of vagrant [18:27:42] and i literally just ran vagrant destroy and then vagrant up [18:28:24] Jobrunner may be writing errors to /var/log/mediawiki/jobrunner.log inside the vm [18:28:25] jdlrobson: i'm here as well, if bd808 needs to... jet [18:28:36] (03CR) 10Bsitu: Convert existing notifications to use user-locators (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/150763 (owner: 10EBernhardson) [18:28:36] marxarelli: I see what you did there :) [18:28:54] :D [18:29:11] nothing there bd808 :-/ [18:29:14] thanks marxarelli [18:29:35] jdlrobson: Ok, next place to check is /var/log/upstart/jobrunner.* [18:30:06] bd808: nope :/ [18:30:28] If jobrunner is all that failed, you should mostly have a functional wiki (just no jobs) [18:30:45] nope it says service unavailable [18:30:52] I'm trying to build a new vm right now.... maybe we'll beat the boarding call [18:31:13] Oh. so hhvm is failing across the board? [18:31:43] Hmm... There was a new hhvm package added to the apt repo an hour ago [18:32:21] jdlrobson: Can you ssh to the vm and run `hhvm` manually to see if there are obvious error messages? [18:32:58] Uncaught exception: Could not open extension /usr/lib/hphp/extensions/20140702/luasandbox.so: /usr/lib/hphp/extensions/20140702/luasandbox.so: cannot open shared object file: No such file or directory [18:33:07] gah [18:33:18] abi version changed again [18:33:44] (03CR) 10Bsitu: [C: 032] Convert existing notifications to use user-locators [extensions/Echo] - 10https://gerrit.wikimedia.org/r/150763 (owner: 10EBernhardson) [18:33:53] (03Merged) 10jenkins-bot: Convert existing notifications to use user-locators [extensions/Echo] - 10https://gerrit.wikimedia.org/r/150763 (owner: 10EBernhardson) [18:34:27] jdlrobson, marxarelli: sounds like we may need another patch like https://gerrit.wikimedia.org/r/#/c/148835/3/puppet/modules/hhvm/templates/php.ini.erb,unified [18:34:52] Check /usr/lib/hphp/extensions and see what the new abi version is [18:35:30] * bd808 can't get his test vm to attach for unrelated reasons [18:35:59] is this somethign that will be quick to fix or am i better off reverting to an older checkout [18:36:52] It's an easy patch. Chane puppet/modules/hhvm/templates/php.ini.erb to use extension path /usr/lib/hphp/extensions/20140727 [18:36:52] jdlrobson: if it's an issue with the hhvm package, you'll likely run into the same issue with earlier revisions [18:36:56] That's the new abi version [18:37:02] doh [18:37:14] * jdlrobson needs a mediawiki instance to do any sort of work right now :-( [18:37:37] (03Abandoned) 10Florianschmidtwelzow: Don't override a new password in loadFromRow() [core] - 10https://gerrit.wikimedia.org/r/151647 (https://bugzilla.wikimedia.org/69102) (owner: 10Florianschmidtwelzow) [18:37:55] hhvm is going to keep biting us on this for a bit. I think _joe_ or ori made something in ops/puppet to set a /usr/lib/hphp/extensions/current symlink. [18:38:02] We need to do the same in mwv [18:38:08] 3MediaWiki / 3User login and signup: Special:PasswordReset locks out of account: "Incorrect password entered" - 10https://bugzilla.wikimedia.org/69102 (10Florian) 5PATC>3RESO/FIX [18:38:41] jdlrobson, marxarelli: can one of you make the patch and merge or poke ori to merge please? [18:39:05] My internet access is about to disappear for ~12 hours [18:39:06] bd808, jdlrobson: i can look into porting the current symlink from ops [18:39:32] marxarelli: That would be swell. A quick patch for the new abi would be a stop gap worth having as well. [18:39:51] (03PS1) 10Florianschmidtwelzow: Add loadPasswords() calls to User password mutators [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/151691 (https://bugzilla.wikimedia.org/69102) [18:39:58] bd808: wilco [18:40:09] (03PS5) 10Withoutaname: LayeredParameterizedPassword: Move code from partialCrypt() to crypt() [core] - 10https://gerrit.wikimedia.org/r/150839 [18:40:24] (03PS18) 10Bsitu: Use batch queries for users-watching-title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/150486 (owner: 10EBernhardson) [18:40:57] bd808: marxarelli i am happy to test but i'm not much use apart from that :/ [18:41:30] jdlrobson: testing is useful enough :) [18:43:08] 3MediaWiki / 3User login and signup: Special:PasswordReset locks out of account: "Incorrect password entered" - 10https://bugzilla.wikimedia.org/69102 (10Tyler Romeo) a:3Tyler Romeo [18:43:52] (03PS1) 10Jdlrobson: Hygiene: Port all Echo css to less. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151692 [18:46:06] (03CR) 10Jdlrobson: [C: 031] "Can't test as vagrant instance busted otherwise i'd +2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151242 (owner: 10EBernhardson) [18:46:11] (03PS2) 10Jdlrobson: Hygiene: Cleanup potentially undefined variable warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151243 (owner: 10EBernhardson) [18:46:15] (03CR) 10Jdlrobson: "Can't test as vagrant instance busted otherwise i'd +2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151243 (owner: 10EBernhardson) [18:46:19] (03CR) 10Jdlrobson: [C: 031] "Can't test as vagrant instance busted otherwise i'd +2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151243 (owner: 10EBernhardson) [18:46:24] (03PS2) 10Jdlrobson: Hygiene: Cleanup undefined class warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151244 (owner: 10EBernhardson) [18:46:31] (03PS2) 10Jdlrobson: Hygiene: Cleanup mismatched function parameters warning [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151245 (owner: 10EBernhardson) [18:46:36] (03PS2) 10Jdlrobson: Hygiene: Cleanup missing @return in docblock warning [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151246 (owner: 10EBernhardson) [18:46:37] 3MediaWiki / 3User login and signup: Special:PasswordReset locks out of account: "Incorrect password entered" - 10https://bugzilla.wikimedia.org/69102#c8 (10Florian) To the "?" at the flag (i don't know, if someone look onto it), but this actually breaks the password reset completly and wmf16 is still create... [18:46:38] 3MediaWiki extensions / 3[other]: [MoveRevisions] Clean up any page entries of pages from which revisions are moved - 10https://bugzilla.wikimedia.org/69115#c1 (10Nathan Larson) I think I've fixed the page_latest issue, but page entries of pages with no revisions are still not removed from the page table. I'... [18:47:52] 3MediaWiki / 3User login and signup: Special:PasswordReset locks out of account: "Incorrect password entered" - 10https://bugzilla.wikimedia.org/69102#c9 (10Tyler Romeo) Yeah definitely. I don't have the permissions to set the WMF backport flag, so the best I can do is request it and wait for somebody to app... [18:48:19] (03CR) 10Jdlrobson: [C: 031] Preferences: Disable the 'skin' preference if there are no skins [core] - 10https://gerrit.wikimedia.org/r/149779 (owner: 10Bartosz Dziewoński) [18:49:36] 3MediaWiki / 3User login and signup: Special:PasswordReset locks out of account: "Incorrect password entered" - 10https://bugzilla.wikimedia.org/69102#c10 (10Florian) Right, ok, just to clarify, that we havethe same opinion :) [18:49:55] greg-g: MaxSem would like https://gerrit.wikimedia.org/r/#/c/151691/ deployed soonish. Is there a good time today to do that? [18:50:37] 3Wikimedia / 3Extension setup: Enable Guided Tour extension on Te wiki (te.wikipedia.org) - 10https://bugzilla.wikimedia.org/69103 (10Andre Klapper) [18:51:23] 3MediaWiki extensions / 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - 10https://bugzilla.wikimedia.org/35342 (10Andre Klapper) 5PATC>3NEW [18:51:56] (03CR) 10Jdlrobson: [C: 04-2] "@Mattflaschen basically browsers that do not support SVG and/or background-size" [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [18:53:41] (03CR) 10Bsitu: [C: 032] Hygiene: Cleanup unused local variable warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151241 (owner: 10EBernhardson) [18:54:15] (03Merged) 10jenkins-bot: Hygiene: Cleanup unused local variable warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151241 (owner: 10EBernhardson) [18:55:02] marxarelli: any sign of a patch? :) [18:56:35] jdlrobson: sorry, wfh-ing today and my connection is a bit slow. i should have a new vm up soon so i can test out the fix [18:56:56] thanks i guess this means i should take an early lunch :) [18:57:16] not a bad idea [18:58:09] (03CR) 10CSteipp: [C: 031] Add loadPasswords() calls to User password mutators [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/151691 (https://bugzilla.wikimedia.org/69102) (owner: 10Florianschmidtwelzow) [18:58:38] (03CR) 10MaxSem: [C: 032] Add loadPasswords() calls to User password mutators [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/151691 (https://bugzilla.wikimedia.org/69102) (owner: 10Florianschmidtwelzow) [19:01:06] (03Merged) 10jenkins-bot: Add loadPasswords() calls to User password mutators [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/151691 (https://bugzilla.wikimedia.org/69102) (owner: 10Florianschmidtwelzow) [19:12:38] 3MediaWiki / 3User login and signup: Special:PasswordReset locks out of account: "Incorrect password entered" - 10https://bugzilla.wikimedia.org/69102 (10Florian) 5PATC>3RESO/FIX [19:14:09] (03PS1) 10Dduvall: hhvm: Update to dynamic extension path [vagrant] - 10https://gerrit.wikimedia.org/r/151697 [19:15:47] ori: ^ [19:28:11] (03PS2) 10IAlex: Use HTMLForm to generate the form on Special:ListFiles [core] - 10https://gerrit.wikimedia.org/r/142876 [19:28:42] (03CR) 10IAlex: "Fixes merge conflict" [core] - 10https://gerrit.wikimedia.org/r/142876 (owner: 10IAlex) [19:31:17] (03PS5) 10IAlex: Update Special:ChangeEmail to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/142878 [19:34:02] (03CR) 10IAlex: "Fixes merge conflict." [core] - 10https://gerrit.wikimedia.org/r/142878 (owner: 10IAlex) [19:34:28] (03CR) 10Ori.livneh: [C: 032] "Thanks!" [vagrant] - 10https://gerrit.wikimedia.org/r/151697 (owner: 10Dduvall) [19:34:33] (03Merged) 10jenkins-bot: hhvm: Update to dynamic extension path [vagrant] - 10https://gerrit.wikimedia.org/r/151697 (owner: 10Dduvall) [19:34:54] (03PS6) 10IAlex: Update Special:ChangeEmail to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/142878 [19:35:40] (03CR) 10IAlex: Update Special:ChangeEmail to use HTMLForm (031 comment) [core] - 10https://gerrit.wikimedia.org/r/142878 (owner: 10IAlex) [19:36:08] (03CR) 10Jdlrobson: [C: 04-1] "flow-topic-title has css for truncated text." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151537 (owner: 10Bsitu) [19:37:35] marxarelli|lunch: my vagrant works again!! thanks :D [19:39:52] (03PS1) 10MarkTraceur: Add controllers for each step - mostly stubs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151699 [19:40:22] (03CR) 10jenkins-bot: [V: 04-1] Add controllers for each step - mostly stubs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151699 (owner: 10MarkTraceur) [19:41:40] (03CR) 10Jdlrobson: [C: 032] Hygiene: Cleanup unused class aliases [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151242 (owner: 10EBernhardson) [19:41:53] 3MediaWiki-Vagrant: Make role::eventlogging run eventlogging-devserver on port 8100 - 10https://bugzilla.wikimedia.org/54042 (10Matthew Flaschen) a:5Ori Livneh>3None [19:42:06] (03PS1) 10Florianschmidtwelzow: Version jump [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/151700 [19:42:15] (03Merged) 10jenkins-bot: Hygiene: Cleanup unused class aliases [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151242 (owner: 10EBernhardson) [19:42:23] (03CR) 10Jdlrobson: [C: 032] Hygiene: Cleanup potentially undefined variable warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151243 (owner: 10EBernhardson) [19:42:57] (03Merged) 10jenkins-bot: Hygiene: Cleanup potentially undefined variable warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151243 (owner: 10EBernhardson) [19:43:00] (03Merged) 10jenkins-bot: Hygiene: Cleanup undefined class warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151244 (owner: 10EBernhardson) [19:43:06] (03CR) 10Florianschmidtwelzow: [C: 032] Version jump [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/151700 (owner: 10Florianschmidtwelzow) [19:43:12] (03Merged) 10jenkins-bot: Version jump [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/151700 (owner: 10Florianschmidtwelzow) [19:44:31] (03PS1) 10Umherirrender: Migrate import log to new log system [core] - 10https://gerrit.wikimedia.org/r/151701 [19:45:56] (03PS1) 10Florianschmidtwelzow: Version jump [extensions/GoogleLogin] (v0_1_2) - 10https://gerrit.wikimedia.org/r/151702 [19:46:21] (03CR) 10Florianschmidtwelzow: [C: 032] Version jump [extensions/GoogleLogin] (v0_1_2) - 10https://gerrit.wikimedia.org/r/151702 (owner: 10Florianschmidtwelzow) [19:46:27] (03Merged) 10jenkins-bot: Version jump [extensions/GoogleLogin] (v0_1_2) - 10https://gerrit.wikimedia.org/r/151702 (owner: 10Florianschmidtwelzow) [19:46:34] (03CR) 10Parent5446: Update Special:ChangeEmail to use HTMLForm (031 comment) [core] - 10https://gerrit.wikimedia.org/r/142878 (owner: 10IAlex) [19:51:25] (03PS1) 10Jdlrobson: QA: Distinguish between watch and unwatch star better [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151703 [19:52:30] (03PS3) 10Jdlrobson: Hygiene: Cleanup missing @return in docblock warning [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151246 (owner: 10EBernhardson) [19:52:35] (03CR) 10Jdlrobson: [C: 032] Hygiene: Cleanup missing @return in docblock warning [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151246 (owner: 10EBernhardson) [19:52:46] (03PS2) 10Jdlrobson: Hygiene: Dont use magic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151248 (owner: 10EBernhardson) [19:53:08] (03Merged) 10jenkins-bot: Hygiene: Cleanup missing @return in docblock warning [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151246 (owner: 10EBernhardson) [19:53:21] (03PS13) 10Jdlrobson: Add blanket support for mediawiki ui via globals [core] - 10https://gerrit.wikimedia.org/r/150635 [19:54:07] (03PS1) 10IAlex: Don't set the session name in CLI or when sessions are deactivated [core] - 10https://gerrit.wikimedia.org/r/151722 [19:54:44] (03PS14) 10Jdlrobson: Add blanket support for mediawiki ui via globals [core] - 10https://gerrit.wikimedia.org/r/150635 [19:54:52] 3MediaWiki extensions / 3GeoData: Special:Nearby on mobile version does not work on several wikipedias - 10https://bugzilla.wikimedia.org/68437#c3 (10Papuass) I updated the template for Latvian WP, it is working now. Nearby link is very prominent in mobile version. Is it ok, that it is up to users of wiki t... [19:55:12] (03PS3) 10IAlex: Add method XmlSelect::addAttributes() and use it in HTMLSelectField [core] - 10https://gerrit.wikimedia.org/r/144671 [19:57:49] (03CR) 10jenkins-bot: [V: 04-1] Add blanket support for mediawiki ui via globals [core] - 10https://gerrit.wikimedia.org/r/150635 (owner: 10Jdlrobson) [20:01:09] (03CR) 10Jdlrobson: [C: 032] "Tested against https://gerrit.wikimedia.org/r/#/c/148508/3" [core] - 10https://gerrit.wikimedia.org/r/149779 (owner: 10Bartosz Dziewoński) [20:02:40] 3MediaWiki extensions / 3Extensions requests: Amazon S3 file storage - 10https://bugzilla.wikimedia.org/69121 (10afreshmelon) 3UNCO p:3Unprio s:3normal a:3None It would appear there is no Amazon S3 integration for MediaWiki available that actually works. It would be great to have this for many people... [20:03:45] (03PS1) 10IAlex: Group E-mail settings stuff in Setup.php [core] - 10https://gerrit.wikimedia.org/r/151768 [20:04:11] (03Merged) 10jenkins-bot: Preferences: Disable the 'skin' preference if there are no skins [core] - 10https://gerrit.wikimedia.org/r/149779 (owner: 10Bartosz Dziewoński) [20:06:33] (03CR) 10Parent5446: [C: 031] Don't set the session name in CLI or when sessions are deactivated [core] - 10https://gerrit.wikimedia.org/r/151722 (owner: 10IAlex) [20:08:17] (03CR) 10Jdlrobson: "After lots of thinking, I think you should kill outputPortlet and its usage. It really is too much code." [core] - 10https://gerrit.wikimedia.org/r/148508 (https://bugzilla.wikimedia.org/68332) (owner: 10Bartosz Dziewoński) [20:08:33] (03PS7) 10IAlex: Update Special:ChangeEmail to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/142878 [20:09:46] jdlrobson: no problem! [20:09:57] (03PS6) 10Paladox: WikiEditor: Fix issue with SVG [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151611 (https://bugzilla.wikimedia.org/35342) [20:10:04] (03PS7) 10Paladox: WikiEditor: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151616 [20:10:51] (03PS8) 10IAlex: Update Special:ChangeEmail to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/142878 [20:11:55] (03CR) 10IAlex: Update Special:ChangeEmail to use HTMLForm (031 comment) [core] - 10https://gerrit.wikimedia.org/r/142878 (owner: 10IAlex) [20:15:58] (03CR) 10Mattflaschen: [C: 04-1] "It seems like the dependency is no longer necessary, plus the parent patch has been abandoned." [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/144711 (owner: 1020after4) [20:16:12] (03PS1) 10IAlex: Move debug log related settings up in Setup.php [core] - 10https://gerrit.wikimedia.org/r/151769 [20:16:20] (03Abandoned) 10Jdlrobson: Tools: Fix suite file for phpunit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151240 (owner: 10Jdlrobson) [20:17:06] 3MediaWiki extensions / 3Extensions requests: Amazon S3 file storage - 10https://bugzilla.wikimedia.org/69121#c1 (10Andre Klapper) Which extensions did you try, what were issues, and what is specifically needed to "integrate" MediaWiki with Amazon S3? [20:19:07] 3MediaWiki extensions / 3Extensions requests: Amazon S3 file storage - 10https://bugzilla.wikimedia.org/69121#c2 (10Tyler Romeo) https://www.mediawiki.org/wiki/Extension:AWS Unfortunately, I stopped actively developing this extension because it was taking up too much of my time, so I don't know exactly how... [20:21:08] 3MediaWiki extensions / 3Extensions requests: Amazon S3 file storage - 10https://bugzilla.wikimedia.org/69121#c3 (10afreshmelon) (In reply to Tyler Romeo from comment #2) > https://www.mediawiki.org/wiki/Extension:AWS > > Unfortunately, I stopped actively developing this extension because it was > taking up... [20:22:31] (03CR) 10Jdlrobson: [C: 04-1] "I want to review this (since it is 345 days old) but it's not clear whether it is relevant, or what the use case is and it has no tests." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80710 (owner: 10Legoktm) [20:22:37] 3MediaWiki extensions / 3Extensions requests: Amazon S3 file storage - 10https://bugzilla.wikimedia.org/69121#c4 (10Tyler Romeo) (In reply to afreshmelon from comment #3) > That's unfortunate since there is no alternative really. Sorry. If you try out the extension, it *might* actually work. And if not, you... [20:23:55] (03CR) 10Jdlrobson: [C: 04-1] "needs a rebase" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/88683 (https://bugzilla.wikimedia.org/51541) (owner: 10Legoktm) [20:23:58] (03PS2) 10Paladox: Vector: Remove dead @import in screen.less [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/151446 [20:24:09] (03PS9) 10Paladox: Vector: Fix missing tab images on Special:Preferences [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/151425 [20:24:49] (03PS1) 10Spage: Fix browser test "not watching my new Flow topic" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151770 [20:24:58] (03CR) 10Jdlrobson: [C: 04-1] "needs rebase :(" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/137271 (owner: 10Legoktm) [20:25:07] 3MediaWiki extensions / 3Extensions requests: Amazon S3 file storage - 10https://bugzilla.wikimedia.org/69121#c5 (10afreshmelon) (In reply to Tyler Romeo from comment #4) > (In reply to afreshmelon from comment #3) > > That's unfortunate since there is no alternative really. > > Sorry. If you try out the ex... [20:25:35] (03CR) 10Jdlrobson: [C: 04-1] "This patch needs some more testing + unittest case + a rebase" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/114524 (owner: 10Bsitu) [20:25:59] (03CR) 10Jdlrobson: [C: 04-1] "needs rebase :(" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/137246 (https://bugzilla.wikimedia.org/57043) (owner: 10Legoktm) [20:26:27] (03CR) 10Jdlrobson: [C: 04-1] "needs rebase" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/40095 (owner: 10Dereckson) [20:35:30] (03PS1) 10Florianschmidtwelzow: Use Config and remove globals [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/151771 (https://bugzilla.wikimedia.org/69086) [20:35:32] (03CR) 10jenkins-bot: [V: 04-1] Use Config and remove globals [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/151771 (https://bugzilla.wikimedia.org/69086) (owner: 10Florianschmidtwelzow) [20:35:38] (03PS2) 10Umherirrender: Migrate import log to new log system [core] - 10https://gerrit.wikimedia.org/r/151701 [20:35:52] (03CR) 10Bsitu: "This will get quite messy. Notification is currently generated from i18n messages, I don't like adding html/css to i18n messages. Probabl" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151537 (owner: 10Bsitu) [20:36:47] (03PS2) 10Umherirrender: Migrate merge log to new log system [core] - 10https://gerrit.wikimedia.org/r/151683 [20:37:13] (03CR) 10Umherirrender: "Patch Set 2: Adjust a comment" [core] - 10https://gerrit.wikimedia.org/r/151683 (owner: 10Umherirrender) [20:38:27] (03PS2) 10Florianschmidtwelzow: Use Config and remove globals [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/151771 (https://bugzilla.wikimedia.org/69086) [20:38:55] (03PS8) 10Paladox: TwitterLogin: Update auth link [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/151640 [20:39:30] (03PS4) 10Paladox: Update Moment.js from 2.7.0 to 2.8.1 [core] - 10https://gerrit.wikimedia.org/r/151630 [20:41:23] (03PS3) 10Florianschmidtwelzow: Use Config and remove globals [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/151771 (https://bugzilla.wikimedia.org/69086) [20:43:08] (03PS4) 10Florianschmidtwelzow: Use Config and remove globals [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/151771 (https://bugzilla.wikimedia.org/69086) [20:48:37] (03CR) 10Florianschmidtwelzow: "There are other things don't match the MW coding conventions, too (whitespaces in brackets):" (035 comments) [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/151640 (owner: 10Paladox) [20:49:28] (03CR) 10Bsitu: [C: 032] Hygiene: Port all Echo css to less. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151692 (owner: 10Jdlrobson) [20:49:39] (03Merged) 10jenkins-bot: Hygiene: Port all Echo css to less. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151692 (owner: 10Jdlrobson) [20:53:29] (03CR) 10Spage: [C: 04-1] "I think my 151770 is better. Looking for white space in the class string is way more fragile than saying the unwatch star doesn't have .m" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151703 (owner: 10Jdlrobson) [20:56:52] (03PS1) 10Jdlrobson: Introduce flow-ui-text-truncated [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151773 [21:01:22] 3Wikimedia / 3Site requests: Disable Media Viewer software feature by default on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69080#c11 (10Erik Moeller) Thanks for the request and the note, Steinsplitter. As per Fabrice's earlier comment, please give us a couple of days to get back to you. Please r... [21:07:37] 3MediaWiki / 3JavaScript: Add mw.hook event for wikipage content ready - 10https://bugzilla.wikimedia.org/30713#c20 (10Matthew Flaschen) This doesn't depend on bug 69108. I think you meant that depends on this. [21:07:52] 3MediaWiki / 3JavaScript: LivePreview doesn't allow interaction with page content outside of #wikiPreview (it is not passed to mw.hook) - 10https://bugzilla.wikimedia.org/69108 (10Matthew Flaschen) [21:10:52] 3MediaWiki / 3Unit tests: Inconsistent "Unfinished animations" error, probably being attributed to the wrong module - 10https://bugzilla.wikimedia.org/68884#c1 (10Matthew Flaschen) s:5normal>3major This is happening on core changes too (https://integration.wikimedia.org/ci/job/mediawiki-core-qunit/26048/... [21:11:16] (03CR) 10leucosticte: Make log_params contain null revision rev_id and moved page ID (031 comment) [core] - 10https://gerrit.wikimedia.org/r/150969 (https://bugzilla.wikimedia.org/68930) (owner: 10leucosticte) [21:11:33] (03CR) 10Mattflaschen: "The Jenkins/QUnit error is bug 68884; it seems related to unfinished animations somewhere, but not necessarily where the error claims it i" [core] - 10https://gerrit.wikimedia.org/r/146931 (https://bugzilla.wikimedia.org/68050) (owner: 10Anomie) [21:24:50] (03PS2) 10Jdlrobson: QA: Fix browser test "not watching my new Flow topic" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151770 (owner: 10Spage) [21:25:07] (03CR) 10Jdlrobson: [C: 032] QA: Fix browser test "not watching my new Flow topic" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151770 (owner: 10Spage) [21:25:40] (03Merged) 10jenkins-bot: QA: Fix browser test "not watching my new Flow topic" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151770 (owner: 10Spage) [21:26:12] (03PS1) 10Hashar: PHPUnit tests for 50_mw_ext_loaderTests.php [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151778 [21:26:39] 3MediaWiki / 3JavaScript: Tablesorter places sort arrows to wrong row - 10https://bugzilla.wikimedia.org/53527#c5 (10Andre Klapper) 5NEW>3RESO/FIX No reply - I assume this was fixed by https://gerrit.wikimedia.org/r/#/c/98250/2/resources/jquery/jquery.tablesorter.js which was merged in March. If not, pl... [21:26:39] 3MediaWiki / 3JavaScript: Tablesorter places sort arrows to wrong row - 10https://bugzilla.wikimedia.org/53527 (10Andre Klapper) [21:29:15] (03PS1) 10Hashar: PHPUnit for integration/jenkins.git [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/151780 [21:30:54] 3Wikimedia / 3Site requests: Enabling subpages on FDC wiki - 10https://bugzilla.wikimedia.org/69126 (10matanya) 3NEW p:3Unprio s:3normal a:3None Hello, Please enable subpages on FDC wiki main namespace. Thanks [21:32:42] (03CR) 10Mattflaschen: [C: 04-1] "Per Jon's request, so the question is more visible." [core] - 10https://gerrit.wikimedia.org/r/150724 (owner: 10SG) [21:32:46] (03PS1) 10Hashar: Trigger integration-jenkins-phpunit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151782 [21:33:15] (03CR) 10Hashar: [C: 032] "deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/151780 (owner: 10Hashar) [21:33:25] (03CR) 10Hashar: [C: 032] Trigger integration-jenkins-phpunit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151782 (owner: 10Hashar) [21:33:27] Is anyone around to take a look at this? https://gerrit.wikimedia.org/r/144273 [21:38:31] (03CR) 10Hashar: [C: 032] Trigger integration-jenkins-phpunit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151782 (owner: 10Hashar) [21:38:41] (03CR) 10Hashar: [C: 032] PHPUnit for integration/jenkins.git [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/151780 (owner: 10Hashar) [21:38:44] (03Merged) 10jenkins-bot: Trigger integration-jenkins-phpunit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/151782 (owner: 10Hashar) [21:38:52] (03CR) 10Spage: [C: 04-1] "Works for me with Flow. Comment comments and two code suggestions." (036 comments) [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/149360 (owner: 10Jdlrobson) [21:39:28] (03CR) 10Hashar: "recheck" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151778 (owner: 10Hashar) [21:40:02] (03Merged) 10jenkins-bot: PHPUnit for integration/jenkins.git [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/151780 (owner: 10Hashar) [21:40:20] (03CR) 10Hashar: [C: 032] "Added Jenkins job and Zuul trigger with I2ab566505cb75045a6081385fa0044b633759df0" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151778 (owner: 10Hashar) [21:40:23] (03Merged) 10jenkins-bot: PHPUnit tests for 50_mw_ext_loaderTests.php [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151778 (owner: 10Hashar) [21:46:32] (03PS1) 10Jdlrobson: Hygiene: More LESS cleanup in ext.echo.overlays.less [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151784 [21:47:31] (03PS1) 10MarkTraceur: Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 [21:48:01] (03CR) 10jenkins-bot: [V: 04-1] Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 (owner: 10MarkTraceur) [21:48:52] (03CR) 10Fomafix: "This increases the test coverage." [core] - 10https://gerrit.wikimedia.org/r/139773 (owner: 10Gerrit Patch Uploader) [21:54:33] (03Abandoned) 10Jdlrobson: QA: Distinguish between watch and unwatch star better [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151703 (owner: 10Jdlrobson) [21:55:34] (03PS2) 10Jdlrobson: Introduce flow-ui-text-truncated [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151773 [22:01:09] 3MediaWiki / 3Page deletion: Create option to delete a page by deleting all revisions in the page - 10https://bugzilla.wikimedia.org/69129 (10Nathan Larson) 3NEW p:3Unprio s:3normal a:3None This is basically a hybrid of revision deletion and the "new field" page deletion alternative; see [[mw:Request... [22:02:51] (03PS3) 10Jdlrobson: Introduce flow-ui-text-truncated [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151773 [22:02:52] 3MediaWiki / 3Page deletion: Create option to delete a page by deleting all revisions in the page - 10https://bugzilla.wikimedia.org/69129 (10Nathan Larson) p:5Unprio>3Low s:5normal>3enhanc [22:03:14] (03CR) 10Bsitu: [C: 032] Introduce flow-ui-text-truncated [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151773 (owner: 10Jdlrobson) [22:03:47] (03Merged) 10jenkins-bot: Introduce flow-ui-text-truncated [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151773 (owner: 10Jdlrobson) [22:06:15] (03CR) 10Gilles: [C: 04-1] "On master on the thanks step I get a _blank link to the file page instead of the preview popup, which I believe is meant to be used before" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151225 (owner: 10MarkTraceur) [22:10:44] (03CR) 10MarkTraceur: "Oh, hm. I wonder how that got added beforehand...I'll fix it." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151225 (owner: 10MarkTraceur) [22:16:52] 3MediaWiki / 3Page deletion: Create option to delete a page by deleting all revisions in the page - 10https://bugzilla.wikimedia.org/69129#c1 (10Nathan Larson) This should be secure by default, right, compared to the "new field" option without revision deletion? [22:17:52] (03CR) 10Gilles: Move confirmCloseWindow to core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151128 (owner: 10MarkTraceur) [22:23:35] (03PS1) 10Jdlrobson: Use core mw-ui-text-truncated [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151789 [22:24:20] (03PS1) 10Jdlrobson: Begin deprecation of mediawiki.ui style module [core] - 10https://gerrit.wikimedia.org/r/151791 [22:24:22] (03PS1) 10Jdlrobson: Add mw-ui-text-truncated utility class [core] - 10https://gerrit.wikimedia.org/r/151792 [22:26:12] (03CR) 10Mattflaschen: "> @Mattflaschen basically browsers that do not support SVG and/or background-size" [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [22:26:39] (03CR) 10MaxSem: Add support for adding packages to composer.json (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/151298 (owner: 10BryanDavis) [22:28:35] (03CR) 10jenkins-bot: [V: 04-1] Begin deprecation of mediawiki.ui style module [core] - 10https://gerrit.wikimedia.org/r/151791 (owner: 10Jdlrobson) [22:28:37] (03CR) 10jenkins-bot: [V: 04-1] Add mw-ui-text-truncated utility class [core] - 10https://gerrit.wikimedia.org/r/151792 (owner: 10Jdlrobson) [22:34:52] (03CR) 10Addshore: "The usecase I remember is so that bot owners can get notifications of their bot accounts without having to log into the bot account!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80710 (owner: 10Legoktm) [22:39:16] (03CR) 10Jdlrobson: [C: 04-1] "rebase needed" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 (owner: 10Bsitu) [22:51:09] (03CR) 10Gilles: Move confirmCloseWindow to core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151128 (owner: 10MarkTraceur) [22:51:46] (03PS4) 10MarkTraceur: Move confirmCloseWindow to core [core] - 10https://gerrit.wikimedia.org/r/151128 [22:53:14] (03PS5) 10MarkTraceur: Move confirmCloseWindow to core [core] - 10https://gerrit.wikimedia.org/r/151128 [22:58:09] (03CR) 10Gilles: [C: 031] Move confirmCloseWindow to core [core] - 10https://gerrit.wikimedia.org/r/151128 (owner: 10MarkTraceur) [23:05:08] 3Wikimedia / 3Blog: allow some padding between paragraphs on front page - 10https://bugzilla.wikimedia.org/68984#c4 (10Tilman Bayer) 5NEW>3RESO/FIX Fixed by Exygy. [23:08:14] (03PS1) 10Jdlrobson: QA: Add some basic browser tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151796 [23:12:26] (03CR) 10Bartosz Dziewoński: [C: 032] "Meh." [core] - 10https://gerrit.wikimedia.org/r/139773 (owner: 10Gerrit Patch Uploader) [23:13:53] (03PS2) 10Jdlrobson: QA: Add some basic browser tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151796 [23:14:07] 3Wikimedia / 3Site requests: Disable Media Viewer software feature by default on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69080#c12 (10MZMcBride) (In reply to Erik Moeller from comment #11) > In addition, as with any configuration change request, WMF reserves the right > to apply its own judgment... [23:14:45] (03PS1) 10Mglaser: [WIP] Checklist assistant [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151797 [23:15:27] (03Merged) 10jenkins-bot: mediawiki.jqueryMsg.test.js: Additional test cases for external link [core] - 10https://gerrit.wikimedia.org/r/139773 (owner: 10Gerrit Patch Uploader) [23:22:14] (03PS3) 10Jdlrobson: QA: Add some basic browser tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151796 [23:26:07] 3MediaWiki / 3Skin and page rendering: Implement semi-deletion - 10https://bugzilla.wikimedia.org/3843#c27 (10Nathan Larson) I guess another reason to use semi-deletion is that it eliminates the potential for, e.g., issues such as those described in bug 69047. A combination of semi-deletion and revision dele... [23:26:11] (03CR) 10Bsitu: [C: 032] QA: Add some basic browser tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151796 (owner: 10Jdlrobson) [23:26:30] (03Merged) 10jenkins-bot: QA: Add some basic browser tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/151796 (owner: 10Jdlrobson) [23:28:24] 3MediaWiki-Vagrant: vagrant_ram overrides sometimes ignored/forgotten - 10https://bugzilla.wikimedia.org/69131 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3Ori Livneh I have two overrides for vagrant_ram: * CirrusSearch has a puppet-managed override setting it to 1536 * I have a .settings.yaml wit... [23:32:09] 3MediaWiki / 3Special pages: Special:BlockList displays 500 items instead of default 50 - 10https://bugzilla.wikimedia.org/69132 (10Robert Morley) 3NEW p:3Unprio s:3normal a:3None The default number of items per page on Special:BlockList is 50, but when first opened, it will display 500. [23:32:16] (03PS26) 10Bsitu: Break notifications into alert and message sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 [23:32:36] 3MediaWiki / 3Special pages: Special:BlockList displays 500 items instead of default 50 - 10https://bugzilla.wikimedia.org/69132 (10Robert Morley) p:5Unprio>3Normal s:5normal>3minor [23:54:23] (03CR) 10Mattflaschen: "I won't be reviewing any changes in the TwitterLogin extension." [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/151640 (owner: 10Paladox) [23:55:03] Hi legoktm. [23:57:22] 3MediaWiki extensions / 3MassMessage: MassMessage: Bugs related to contenthandler branch (tracking) - 10https://bugzilla.wikimedia.org/68599#c1 (10MZMcBride) Just dumping notes here 'cause I'm lazy and don't want to lose them. --- * Fix creation edit summary * Categorise all delivery lists (addTrackingCateg... [23:57:46] (03Abandoned) 10Mattflaschen: Vector: Remove dead @import in screen.less [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/151446 (owner: 10Paladox) [23:58:19] any selenium geniuses around? marxarelli maybe/ [23:58:56] jdlrobson: don't know if i'd use the g-word, but I can certainly try to help [23:59:13] haha [23:59:34] do we have a standard way of creating a new account in browser tests? I know mobile used to do this but i'm not sure where the code for that went.. :-/