[00:05:07] 3MediaWiki extensions / 3SemanticForms: Saving pages broken in MW 1.24 - "Fatal error: Cannot access protected property EditPage::$mTokenOk" - 10https://bugzilla.wikimedia.org/67522#c2 (10s7eph4n) 5ASSI>3PATC Patch: https://gerrit.wikimedia.org/r/#/c/151370/ [00:05:23] 3MediaWiki / 3General/Unknown: EditPage member variable visibility changes broke compatibility for extensions - 10https://bugzilla.wikimedia.org/67984#c5 (10s7eph4n) 5NEW>3PATC Patch: https://gerrit.wikimedia.org/r/#/c/151370/ [00:06:15] (03PS3) 10Legoktm: Fix for Ia9baaf0b: Make previously public variables public again [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [00:09:09] (03CR) 10Legoktm: "Do you actually need all of these member variables to be public? Or just a few (which the bug seems to be about...)?" [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [00:23:31] (03CR) 10Foxtrott: "I don't need all the variables." [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [00:33:31] (03CR) 10Reedy: [C: 04-1] Fix for Ia9baaf0b: Make previously public variables public again (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [00:40:00] (03CR) 10Reedy: "I'm somewhat tempted to -2 this." [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [00:41:43] (03CR) 10Reedy: Fix for Ia9baaf0b: Make previously public variables public again (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [00:45:27] 3MediaWiki / 3Special pages: Year field of Special:Contributions contains comma - 10https://bugzilla.wikimedia.org/69059 (10xeriphas1994) 3UNCO p:3Unprio s:3trivia a:3None Thousands and hundreds digits of the year are separated by a comma, here and nowhere else in the industrialized world. Seems to... [00:46:33] (03CR) 10Foxtrott: "This is not about fixing the visibility of mTokenOk." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) (owner: 10Foxtrott) [00:49:26] (03PS1) 10MSyed: Add retina and non retina images for stories [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151373 [01:03:49] (03PS4) 10Foxtrott: Fix for Ia9baaf0b: Make previously public variables public again [core] - 10https://gerrit.wikimedia.org/r/151370 (https://bugzilla.wikimedia.org/67522) [01:24:00] (03CR) 10Renoirb: "True, Composer has a mechanism for allowing non PSR-0 to be used AND it supports anything. Maybe we could have a puppet function that gen" [vagrant] - 10https://gerrit.wikimedia.org/r/151298 (owner: 10BryanDavis) [01:46:26] (03CR) 10Brian Wolff: "Why can't one just look at the ar_page_id field in the archive table to figure out what page the deleted revision went with?" [core] - 10https://gerrit.wikimedia.org/r/151309 (https://bugzilla.wikimedia.org/69049) (owner: 10leucosticte) [01:54:07] 3MediaWiki / 3Patrolling: No possibility to patrol from Special:Contributions/user - 10https://bugzilla.wikimedia.org/14352#c8 (10Bawolff (Brian Wolff)) Is this still an issue? (No red !'s on Special:Contributions, but you should be able to follow a link from contribs to a page and press patrol I believe, wh... [01:54:19] (03CR) 10leucosticte: "When the page is undeleted, it won't be possible to look at the ar_page_id because those archive rows will have been moved back to the rev" [core] - 10https://gerrit.wikimedia.org/r/151309 (https://bugzilla.wikimedia.org/69049) (owner: 10leucosticte) [01:58:13] oh I had totally forgotten about https://www.mediawiki.org/wiki/User:MZMcBride/Attacks [02:13:52] 3MediaWiki / 3Page deletion: Develop countermeasures to the merge page histories attack - 10https://bugzilla.wikimedia.org/69047#c1 (10Bawolff (Brian Wolff)) Wasn't there some plan once Special:MergeHistory was better developed to disable history-merging-via-undelete? Maybe I'm misremembering. [02:15:40] (03CR) 10Brian Wolff: "I'm not really a fan of adding an extra log_search entry for each revision id since many pages are in the thousands (with worst case being" [core] - 10https://gerrit.wikimedia.org/r/151309 (https://bugzilla.wikimedia.org/69049) (owner: 10leucosticte) [02:32:39] (03PS1) 10MSyed: Top nav, and footer style improvements [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151377 [03:21:07] 3MediaWiki / 3Patrolling: No possibility to patrol from Special:Contributions/user - 10https://bugzilla.wikimedia.org/14352#c9 (10Helder) I have the impression that comment 0 asks for patrol links on Special:Contributions. As for the missing "!" marks, I'm using this small (and incomplete) script as a worka... [03:25:25] 3MediaWiki / 3Patrolling: No red "!" for patrolling on Special:Contributions/user - 10https://bugzilla.wikimedia.org/69061 (10Bawolff (Brian Wolff)) 3NEW p:3Unprio s:3enhanc a:3None +++ This bug was initially created as a clone of Bug #14352 +++ Splitting from bug 14352. "...those red !s are not sh... [03:25:37] 3MediaWiki / 3Patrolling: No possibility to patrol from Special:Contributions/user - 10https://bugzilla.wikimedia.org/14352#c10 (10Bawolff (Brian Wolff)) 5NEW>3RESO/FIX Ok. Splitting that to bug 69061 and marking this fixed. [03:30:52] (03CR) 10Tim Landscheidt: "(IIRC my idea was to define a separate rule for labs/toollabs to test different artifact extractors only for that repo. But abandoning is" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/106295 (owner: 10Tim Landscheidt) [03:31:07] 3MediaWiki / 3Patrolling: No possibility to patrol from Special:Contributions/user - 10https://bugzilla.wikimedia.org/14352#c11 (10Ran Ari-Gur (User:Ruakh on WMF projects)) > No red !'s on Special:Contributions, but you should be able to follow a link from contribs to a page and press patrol I believe, [...]... [04:19:29] (03PS1) 10Brian Wolff: Making missing old files not try to render a thumbnail [core] - 10https://gerrit.wikimedia.org/r/151378 (https://bugzilla.wikimedia.org/22847) [04:28:26] (03CR) 10Prtksxna: [C: 04-1] "Why don't you replace the older image? Do we need it for some other page?" [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151368 (owner: 10MSyed) [04:29:27] (03CR) 10Prtksxna: [C: 04-1] "Is 'content' defined in the YAML file? If so could you please check it in." [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151369 (owner: 10MSyed) [04:30:42] (03CR) 10Prtksxna: [C: 031] Add retina and non retina images for stories [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151373 (owner: 10MSyed) [04:31:00] (03CR) 10Prtksxna: [C: 031] Top nav, and footer style improvements [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151377 (owner: 10MSyed) [04:35:12] (03CR) 10Prtksxna: [C: 032 V: 032] Change Content page icon on index [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151368 (owner: 10MSyed) [04:35:24] (03CR) 10Prtksxna: [C: 032 V: 032] Fix big button links on index. [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151369 (owner: 10MSyed) [04:35:46] (03CR) 10Prtksxna: [C: 032 V: 032] Top nav, and footer style improvements [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151377 (owner: 10MSyed) [04:35:54] (03CR) 10Prtksxna: [C: 032 V: 032] Add retina and non retina images for stories [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151373 (owner: 10MSyed) [04:55:23] (03PS1) 10MSyed: Change breakpoints [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151379 [05:00:37] (03PS1) 10Wctaiwan: Descriptive error on special page [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151380 [05:01:44] (03PS2) 10Wctaiwan: Descriptive error on special page [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151380 [05:02:25] (03CR) 10Legoktm: [C: 032] Descriptive error on special page [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151380 (owner: 10Wctaiwan) [05:02:34] (03Merged) 10jenkins-bot: Descriptive error on special page [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151380 (owner: 10Wctaiwan) [05:02:38] (03PS22) 10Bsitu: Break notifications into alert and message sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 [05:02:41] (03CR) 10jenkins-bot: [V: 04-1] Break notifications into alert and message sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 (owner: 10Bsitu) [05:12:10] (03PS1) 10Brian Wolff: Show patrol marks on Special:Contributions [core] - 10https://gerrit.wikimedia.org/r/151381 (https://bugzilla.wikimedia.org/69061) [05:12:35] (03PS1) 10Prtksxna: Add strings for privacy page [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151382 [05:12:44] (03CR) 10Prtksxna: [C: 032 V: 032] Change breakpoints [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151379 (owner: 10MSyed) [05:13:25] (03PS2) 10Prtksxna: Add strings for privacy page [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151382 [05:15:19] (03PS1) 10MSyed: Ignoring /build folder [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151383 [05:24:54] (03PS4) 10BryanDavis: Switch jobrunner to JSON config [vagrant] - 10https://gerrit.wikimedia.org/r/150243 (https://bugzilla.wikimedia.org/68785) (owner: 10MaxSem) [05:24:56] (03PS1) 10BryanDavis: Add git::install resource and fix git::clone [vagrant] - 10https://gerrit.wikimedia.org/r/151384 [05:28:41] (03PS3) 10Prtksxna: Add strings for privacy page [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151382 [05:28:43] (03PS1) 10Prtksxna: Add string for FAQ [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151385 [05:56:18] (03PS1) 10MSyed: improvements with mobile view [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151386 [05:56:59] (03CR) 10MSyed: [C: 032 V: 032] Add strings for privacy page [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151382 (owner: 10Prtksxna) [05:59:43] (03CR) 10Prtksxna: [C: 032 V: 032] Ignoring /build folder [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151383 (owner: 10MSyed) [05:59:52] (03CR) 10Prtksxna: [C: 032 V: 032] improvements with mobile view [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151386 (owner: 10MSyed) [06:06:01] (03PS2) 10Prtksxna: improvements with mobile view [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151386 (owner: 10MSyed) [06:06:16] (03CR) 10Prtksxna: [V: 032] improvements with mobile view [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151386 (owner: 10MSyed) [06:07:08] (03PS2) 10Prtksxna: Add string for FAQ [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151385 [06:15:17] (03CR) 10MSyed: [C: 032 V: 032] Add string for FAQ [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151385 (owner: 10Prtksxna) [06:22:25] (03PS1) 10MSyed: chevron image [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151387 [06:23:17] (03CR) 10Prtksxna: [C: 032 V: 032] chevron image [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151387 (owner: 10MSyed) [06:45:14] (03PS1) 10Prtksxna: Fix styling for FAQ page [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151388 [06:51:37] 3MediaWiki / 3Internationalization: misspellings in English AllMessages - 10https://bugzilla.wikimedia.org/69021#c3 (10Autymn D. C.) (In reply to Nemo from comment #2) > No such strings are contained in MediaWiki core or extensions: > > nemobis@tools-login:/shared/mediawiki$ find -type f -name en.json -exec... [06:55:22] 3MediaWiki / 3Internationalization: misspellings in English AllMessages - 10https://bugzilla.wikimedia.org/69021#c4 (10Autymn D. C.) 5RESO/?>3VERI Can't edit comments :(. http://community.wikia.com/wiki/MediaWiki:Unsubscribe-badtime http://community.wikia.com/wiki/MediaWiki:Wikistats_trend_ordered [06:59:56] (03PS2) 10Prtksxna: Fix styling for FAQ page [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151388 [07:04:10] (03PS1) 10MSyed: Partial en localization of content page [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151389 [07:07:37] 3MediaWiki extensions / 3WikiEditor: Do not load WikiEditor for MediaWiki:Common.js etc - 10https://bugzilla.wikimedia.org/24041#c7 (10George Orwell III) Does the above merge mean the patch is now applied on https://test2.wikipedia.org ? If so, then I'm guessing the fact the Page: namespace having a conten... [07:07:47] (03CR) 10Prtksxna: [C: 032 V: 032] Partial en localization of content page [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151389 (owner: 10MSyed) [07:07:53] (03CR) 10MSyed: [C: 032 V: 032] Fix styling for FAQ page [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151388 (owner: 10Prtksxna) [07:08:39] 3MediaWiki / 3General/Unknown: AJAX search suggestion shows non-existent page - 10https://bugzilla.wikimedia.org/69063 (10Killiondude) 3NEW p:3Unprio s:3minor a:3None To reproduce: 1) Go to meta.wikimedia.org 2) Type in "Meta:Speedy" into the search bar 3) Note that "Meta:Speedy Deletions" is suggest... [07:12:22] 3MediaWiki / 3Search: AJAX search suggestion shows non-existent page - 10https://bugzilla.wikimedia.org/69063 (10Kunal Mehta (Legoktm)) [07:13:39] can anyone help me with https://bugzilla.wikimedia.org/show_bug.cgi?id=38910 [07:15:37] 3MediaWiki / 3Search: AJAX search suggestion shows non-existent page - 10https://bugzilla.wikimedia.org/69063#c1 (10Kunal Mehta (Legoktm)) https://meta.wikimedia.org/w/api.php?action=opensearch&search=Speedy&namespace=4 has: ["Speedy",["Meta:Speedy deletion"]] [07:18:52] 3MediaWiki extensions / 3WikiEditor: Do not load WikiEditor for MediaWiki:Common.js etc - 10https://bugzilla.wikimedia.org/24041#c8 (10George Orwell III) Scratch Comment 7 - it seems the test2 testbed is not completely configured for the ProofReading extension as a default and the issue lies there. Sorry. [07:23:12] (03PS5) 10Umherirrender: Use Database::makeWhereFrom2d in LinkHolderArray::replaceInternal [core] - 10https://gerrit.wikimedia.org/r/143713 [07:27:11] (03PS1) 10Wctaiwan: Improve edit summaries [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151390 [07:27:23] (03CR) 10jenkins-bot: [V: 04-1] Improve edit summaries [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151390 (owner: 10Wctaiwan) [07:28:58] (03PS2) 10Wctaiwan: Improve edit summaries [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151390 [07:31:10] (03PS3) 10Wctaiwan: Improve edit summaries [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151390 [07:37:07] (03CR) 10Legoktm: [C: 04-1] Improve edit summaries (034 comments) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151390 (owner: 10Wctaiwan) [07:44:03] (03PS1) 10Prtksxna: Add strings for content page [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151391 [07:45:55] 3MediaWiki extensions / 3Translate: Special:AggregateGroups opening could be made faster - 10https://bugzilla.wikimedia.org/69065 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Created attachment 16131 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16131&action=edit Mentioned profile Odder report... [07:51:22] 3MediaWiki extensions / 3Translate: Special:AggregateGroups opening could be made faster - 10https://bugzilla.wikimedia.org/69065#c1 (10Niklas Laxström) See also https://gerrit.wikimedia.org/r/#/c/139699/ [07:57:03] (03PS4) 10Umherirrender: Parser: Clean up handling of editsections by using local variables [core] - 10https://gerrit.wikimedia.org/r/144182 [07:57:23] (03PS4) 10Wctaiwan: Improve edit summaries [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151390 [08:00:58] (03CR) 10Nemo bis: "If someone approves I can test the effects on Meta. https://bugzilla.wikimedia.org/show_bug.cgi?id=69065" [core] - 10https://gerrit.wikimedia.org/r/139699 (owner: 10Paladox) [08:01:58] (03CR) 10Wctaiwan: Improve edit summaries (034 comments) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151390 (owner: 10Wctaiwan) [08:23:30] (03PS5) 10Wctaiwan: Improve edit summaries [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151390 [08:28:11] (03CR) 10Robert Vogel: [C: 031 V: 031] BS223 Facelist: Preferences (031 comment) [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/151270 (owner: 10Tweichart) [08:33:59] (03PS6) 10Wctaiwan: Improve edit summaries [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151390 [08:36:39] (03CR) 10Wctaiwan: Improve edit summaries (032 comments) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/151390 (owner: 10Wctaiwan) [08:38:39] (03CR) 10Cscott: [C: 032] Allow page breaks between empty sections. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/151357 (owner: 10Cscott) [08:39:41] (03CR) 10Cscott: [C: 032] Ensure latin font is used for list item bullets. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/151358 (owner: 10Cscott) [08:40:20] (03CR) 10Cscott: [C: 032] Add Lohit fonts for Indic languages. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/151359 (owner: 10Cscott) [08:40:35] (03CR) 10Cscott: [C: 032] Use Lohit fonts when possible. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/151360 (https://bugzilla.wikimedia.org/28206) (owner: 10Cscott) [08:41:00] (03Merged) 10jenkins-bot: Allow page breaks between empty sections. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/151357 (owner: 10Cscott) [08:43:15] (03Merged) 10jenkins-bot: Ensure latin font is used for list item bullets. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/151358 (owner: 10Cscott) [08:43:17] (03Merged) 10jenkins-bot: Add Lohit fonts for Indic languages. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/151359 (owner: 10Cscott) [08:43:39] (03CR) 10Robert Vogel: [C: 04-1] [WIP] UserSidebar Editing GUI (034 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151079 (owner: 10Pwirth) [08:44:05] (03Merged) 10jenkins-bot: Use Lohit fonts when possible. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/151360 (https://bugzilla.wikimedia.org/28206) (owner: 10Cscott) [08:48:31] (03CR) 10Robert Vogel: [C: 04-1] fixed review displays and error messages (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/150497 (owner: 10Tweichart) [08:56:46] (03CR) 10Robert Vogel: [C: 032 V: 032] BS223 Facelift: changed icon to bell [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151274 (owner: 10Tweichart) [08:57:22] 3MediaWiki extensions / 3Translate: Set up automatic sync for Huggle with translatewiki.net - 10https://bugzilla.wikimedia.org/68853#c13 (10Peter Bena) but this has nothing to do with mediawiki extension, it's about translatewiki infrastructure, there are shell scrips used on translatewiki servers, that are... [08:58:08] (03CR) 10Robert Vogel: [C: 032 V: 032] BS223: Flexiskin + UniversalExport [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151296 (owner: 10Tweichart) [08:59:07] 3MediaWiki extensions / 3Translate: Set up automatic sync for Huggle with translatewiki.net - 10https://bugzilla.wikimedia.org/68853 (10Peter Bena) [09:02:51] (03CR) 10Robert Vogel: [C: 032 V: 032] minor change, added mm toString + comment (031 comment) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/151293 (owner: 10Tweichart) [09:05:18] (03PS1) 10JanZerebecki: phpunit.php: Allow direct use of a PHPUnit PHAR file. [core] - 10https://gerrit.wikimedia.org/r/151394 (https://bugzilla.wikimedia.org/58881) [09:05:36] (03CR) 10Robert Vogel: [C: 031 V: 031] BS223 Facelift: further improvements (031 comment) [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/151294 (owner: 10Tweichart) [09:09:27] (03CR) 10Robert Vogel: [C: 031 V: 031] BS223: styling + fixes (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151276 (owner: 10Tweichart) [09:18:32] (03PS1) 10Arlolra: Apply external link icons on .mw-body-content [core] - 10https://gerrit.wikimedia.org/r/151395 [09:20:19] (03CR) 10Robert Vogel: [C: 04-1] BS223: compatibility to vector skin (034 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151292 (owner: 10Tweichart) [09:21:55] (03PS2) 10JanZerebecki: phpunit.php: Allow direct use of a PHPUnit PHAR file. [core] - 10https://gerrit.wikimedia.org/r/151394 (https://bugzilla.wikimedia.org/58881) [09:39:39] (03PS1) 10Deepali: Add category:Book:Book_name to all pages when new sections are imported. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/151397 (https://bugzilla.wikimedia.org/66775) [09:39:53] (03CR) 10jenkins-bot: [V: 04-1] Add category:Book:Book_name to all pages when new sections are imported. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/151397 (https://bugzilla.wikimedia.org/66775) (owner: 10Deepali) [09:42:24] (03PS2) 10Umherirrender: Remove WikiPage::estimateRevisionCount (deprecated since 1.19) [core] - 10https://gerrit.wikimedia.org/r/146435 [09:42:41] (03CR) 10Umherirrender: "Patch Set 2: Rebased" [core] - 10https://gerrit.wikimedia.org/r/146435 (owner: 10Umherirrender) [09:44:09] (03Abandoned) 10Umherirrender: Simplify SpecialRevisiondelete::showForm a bit [core] - 10https://gerrit.wikimedia.org/r/149653 (owner: 10Umherirrender) [09:45:17] (03PS2) 10Umherirrender: Remove Xml::namespaceSelector() (deprecated since 1.19) [core] - 10https://gerrit.wikimedia.org/r/149836 [09:45:34] (03CR) 10Umherirrender: "Patch Set 2: Rebased" [core] - 10https://gerrit.wikimedia.org/r/149836 (owner: 10Umherirrender) [09:45:57] (03PS14) 10Umherirrender: Add dynamic maxlength to Special:RevisionDelete [core] - 10https://gerrit.wikimedia.org/r/135197 (https://bugzilla.wikimedia.org/34467) [09:47:07] (03Abandoned) 10Umherirrender: Remove mixed void/non-void returns in MysqlUpdater [core] - 10https://gerrit.wikimedia.org/r/148034 (owner: 10Umherirrender) [09:47:14] (03PS8) 10Umherirrender: Cleanup some docs (languages, maintenance, tests) [core] - 10https://gerrit.wikimedia.org/r/148991 [09:47:24] (03PS5) 10Umherirrender: Rename Preprocessor_DOM/Preprocessor_Hash [core] - 10https://gerrit.wikimedia.org/r/149382 [09:47:36] (03PS2) 10Umherirrender: Allow maxlength attribute on HTMLSelectAndOtherField [core] - 10https://gerrit.wikimedia.org/r/149590 [09:48:14] (03PS3) 10Umherirrender: Add parser tests about building table with {{!}} [core] - 10https://gerrit.wikimedia.org/r/146732 [09:53:58] (03PS2) 10Umherirrender: Add parser tests for tables with pipes and wikilinks [core] - 10https://gerrit.wikimedia.org/r/146733 [09:54:45] (03PS3) 10JanZerebecki: phpunit.php: Allow direct use of a PHPUnit PHAR file. [core] - 10https://gerrit.wikimedia.org/r/151394 (https://bugzilla.wikimedia.org/58881) [09:58:18] (03PS8) 10Cscott: Run some parser tests with tidy. [core] - 10https://gerrit.wikimedia.org/r/133957 [09:58:33] (03CR) 10JanZerebecki: "This broke hhvm because it seems not to find Phar::isValidPharFilename(). I currently don't have access to hhvm (no 32bit build) to test t" [core] - 10https://gerrit.wikimedia.org/r/118997 (https://bugzilla.wikimedia.org/58881) (owner: 10Aude) [10:13:55] Judith [10:44:09] (03CR) 10Hoo man: "Ok... but whoever approves this needs to be *very* careful while reviewing." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/145156 (https://bugzilla.wikimedia.org/25377) (owner: 10Legoktm) [11:07:52] (03PS1) 10Cscott: Don't use `process.exit` on a normal successful exit. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/151403 [11:07:54] (03PS1) 10Cscott: Sync output directories before bundling. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/151404 [11:32:08] 3MediaWiki / 3General/Unknown: Tracking bug (tracking) - 10https://bugzilla.wikimedia.org/2007 (10John Mark Vandenberg) [11:52:43] (03CR) 10Bartosz Dziewoński: [C: 031] "Looks sane, is there a detailed rationale? l am vaguely aware of some discussion about this." [core] - 10https://gerrit.wikimedia.org/r/151395 (owner: 10Arlolra) [12:10:31] (03PS32) 10Paladox: Update jquery.chosen folder and files [core] - 10https://gerrit.wikimedia.org/r/139699 [12:11:10] (03PS33) 10Paladox: Update jquery.chosen folder and files [core] - 10https://gerrit.wikimedia.org/r/139699 (https://bugzilla.wikimedia.org/69065) [12:18:28] (03PS1) 10Prtksxna: Fix tooltip position and content [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151405 [12:23:37] 3QRpedia: QRpedia should point to Wikidata entity - 10https://bugzilla.wikimedia.org/63463#c3 (10Kelson [Emmanuel Engelhart]) I support the idea, but this is not a small change (in particular because we need to keep the backward compatibilty). [12:37:46] (03CR) 10Cscott: [C: 032] Don't use `process.exit` on a normal successful exit. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/151403 (owner: 10Cscott) [12:38:05] (03CR) 10Cscott: [C: 032] Sync output directories before bundling. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/151404 (owner: 10Cscott) [12:39:23] (03Merged) 10jenkins-bot: Don't use `process.exit` on a normal successful exit. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/151403 (owner: 10Cscott) [12:40:05] (03Merged) 10jenkins-bot: Sync output directories before bundling. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/151404 (owner: 10Cscott) [12:40:23] 3MediaWiki / 3Patrolling: No possibility to patrol from Special:Contributions/user - 10https://bugzilla.wikimedia.org/14352 (10Helder) [12:40:23] 3MediaWiki / 3Patrolling: No red "!" for patrolling on Special:Contributions/user - 10https://bugzilla.wikimedia.org/69061 (10Helder) [12:48:29] (03CR) 10Cscott: [C: 04-1] "Looks pretty good." (034 comments) [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/151215 (owner: 10Mwalker) [12:51:55] (03CR) 10Cscott: [C: 04-1] "looks pretty good." (035 comments) [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/151222 (owner: 10Mwalker) [12:53:06] (03CR) 10Cscott: Use new log and status reporting framework (032 comments) [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/151215 (owner: 10Mwalker) [12:55:30] (03CR) 10Cscott: Use new log and status reporting framework (031 comment) [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/151215 (owner: 10Mwalker) [13:02:28] (03CR) 10Cscott: [C: 04-1] "Make message.message always a plain string." (032 comments) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/151224 (owner: 10Mwalker) [13:05:22] 3MediaWiki / 3ResourceLoader: mw.loader.store should not occupy all of localStorage - 10https://bugzilla.wikimedia.org/64721 (10Krinkle) [13:05:38] 3MediaWiki extensions / 3WikiEditor: Do not load WikiEditor for MediaWiki:Common.js etc - 10https://bugzilla.wikimedia.org/24041#c9 (10Helder) (In reply to George Orwell III from comment #7) Copying from https://gerrit.wikimedia.org/r/#/c/141296/ : I was worried that WikiEditor customizations like [ https:/... [13:14:37] 3MediaWiki extensions / 3Translate: Set up automatic sync for Huggle with translatewiki.net - 10https://bugzilla.wikimedia.org/68853 (10Helder) [13:19:07] 3MediaWiki / 3Page deletion: Develop countermeasures to the merge page histories attack - 10https://bugzilla.wikimedia.org/69047#c2 (10Abd ulRahman Lomax) The difficult-to-undo damage occurs when the deleted revisions are restored and thus merged, though the same effect arises when revisions are deleted (tha... [13:25:37] 3MediaWiki extensions / 3Translate: Special:AggregateGroups opening could be made faster - 10https://bugzilla.wikimedia.org/69065 (10Andre Klapper) [13:33:36] (03PS10) 10Paladox: Update WikiEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [13:35:07] 3MediaWiki / 3Page deletion: Develop countermeasures to the merge page histories attack - 10https://bugzilla.wikimedia.org/69047#c3 (10Nathan Larson) (In reply to Abd ulRahman Lomax from comment #2) > The difficult-to-undo damage occurs when the deleted revisions are restored > and thus merged, though the sa... [13:37:22] 3MediaWiki / 3Page deletion: Develop countermeasures to the merge page histories attack - 10https://bugzilla.wikimedia.org/69047#c4 (10Nathan Larson) (In reply to Bawolff (Brian Wolff) from comment #1) > Wasn't there some plan once Special:MergeHistory was better developed to > disable history-merging-via-un... [13:52:52] 3MediaWiki / 3Special pages: Year field of Special:Contributions contains comma - 10https://bugzilla.wikimedia.org/69059#c1 (10xeriphas1994) Seen in Safari 5.1.10. Firefox 28 and Opera 23.0 do not have the comma. [14:13:17] (03PS1) 10Prtksxna: Add the where from graph on the content page [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151411 [14:13:19] (03PS1) 10Prtksxna: Remove emacs backup file [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151412 [14:21:23] (03PS1) 10Mglaser: Standard line height and maring in all content HTML texts. [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/151413 [14:30:33] (03PS2) 10Deepali: Add category:Book:Book_name to all pages when new sections are imported. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/151397 (https://bugzilla.wikimedia.org/66775) [15:07:02] (03PS1) 10Mglaser: Fixed handling of wikicode in image labels in visual editor [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151414 [15:08:58] (03PS1) 10Mglaser: Harden handling of BR tags [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151415 [15:13:00] (03CR) 10Theopolisme: "Glad to see this being updated, but this will break some of AFCH on enwiki (https://en.wikipedia.org/wiki/Wikipedia:AFCHRW), since I rely " [core] - 10https://gerrit.wikimedia.org/r/139699 (https://bugzilla.wikimedia.org/69065) (owner: 10Paladox) [15:16:38] 3MediaWiki / 3Special pages: Year field of Special:Contributions contains comma - 10https://bugzilla.wikimedia.org/69059#c2 (10xeriphas1994) After some more research I find this: https://bugs.webkit.org/show_bug.cgi?id=62939 (and the several other entries linked from it). The issue is listed as fixed ther... [15:37:49] (03PS2) 10Arlolra: Use .mw-body,.mw-body-content in skins [core] - 10https://gerrit.wikimedia.org/r/151395 [15:39:57] (03PS1) 10Mglaser: Remove anchor tags in editor [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/151418 [15:53:43] (03CR) 10MSyed: [C: 032 V: 032] Add strings for content page [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151391 (owner: 10Prtksxna) [15:59:39] 3Wikimedia / 3Site requests: Change AbuseFilter settings on fa.wikipedia - 10https://bugzilla.wikimedia.org/69073 (10Calak) 3NEW p:3Unprio s:3normal a:3None Hello. Please apply the following changes to the AbuseFilter settings on fa.wikipedia: https://fa.wikipedia.org/wiki/%D8%A8%D8%AD%D8%AB_%D9%88%... [15:59:52] 3Wikimedia / 3Site requests: Change AbuseFilter settings on fa.wikipedia - 10https://bugzilla.wikimedia.org/69073 (10Calak) [16:00:06] (03CR) 10MSyed: [C: 032 V: 032] Fix tooltip position and content [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151405 (owner: 10Prtksxna) [16:01:53] 3Wikimedia / 3Site requests: Change AbuseFilter settings on fa.wikipedia - 10https://bugzilla.wikimedia.org/69073#c1 (10John F. Lewis) 5NEW>3ASSI p:5Unprio>3Normal a:3John F. Lewis Consensus exists. Will do. [16:03:21] 3MediaWiki / 3Watchlist: Watch rollbacks - 10https://bugzilla.wikimedia.org/4488#c18 (10Nemo) Thanks for fixing this, it would have fit well in https://www.mediawiki.org/wiki/MediaWiki_1.23#Notifications :-) This also makes it easier for sysadmins to enable "watchdefault" by default if they wish. [16:03:49] (03CR) 10MSyed: [C: 032 V: 032] Add the where from graph on the content page [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151411 (owner: 10Prtksxna) [16:04:08] (03PS1) 10Prtksxna: Add tooltips for bubble graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151423 [16:05:42] (03CR) 10MSyed: [C: 032 V: 032] Remove emacs backup file [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151412 (owner: 10Prtksxna) [16:05:57] (03CR) 10MSyed: [C: 032 V: 032] Add tooltips for bubble graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151423 (owner: 10Prtksxna) [16:09:39] (03PS1) 10Paladox: Fix issue with Vector skin preference [core] - 10https://gerrit.wikimedia.org/r/151424 [16:09:54] (03PS2) 10Paladox: Fix issue with Vector skin preference [core] - 10https://gerrit.wikimedia.org/r/151424 [16:10:53] (03PS3) 10Paladox: Fix issue with Vector skin preference [core] - 10https://gerrit.wikimedia.org/r/151424 [16:11:23] (03PS4) 10Paladox: Fix issue with Vector skin preference [core] - 10https://gerrit.wikimedia.org/r/151424 [16:13:29] (03PS1) 10Paladox: Fix issue with Vector skin preference [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/151425 [16:13:38] 3Wikimedia / 3Site requests: Change AbuseFilter settings on fa.wikipedia - 10https://bugzilla.wikimedia.org/69073 (10John F. Lewis) a:5John F. Lewis>3Calak [16:18:39] 3MediaWiki extensions / 3MaintenanceShell: MainteniceShell broken in MediaWiki 1.24 - 10https://bugzilla.wikimedia.org/69075 (10paladox2015) 3UNCO p:3Unprio s:3normal a:3None Hi MainteniceShell does not work well in Mediawiki 1.24. it comes up with error when running update.php but before the update... [16:43:54] (03PS1) 10Prtksxna: Fix tooltip position for bubble graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151427 [16:44:20] (03PS1) 1001tonythomas: Shifted from PEAR mimeParse to Plancake mailparse [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151428 [16:44:23] (03CR) 10Daniel Werner: [C: 032 V: 032] Fix for maximum number of loops applied even if set to unlimited [extensions/Loops] - 10https://gerrit.wikimedia.org/r/147410 (owner: 10Gerrit Patch Uploader) [16:45:24] (03CR) 10MSyed: [C: 032 V: 032] Fix tooltip position for bubble graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151427 (owner: 10Prtksxna) [16:46:33] (03PS2) 1001tonythomas: Shifted from PEAR mimeParse to Plancake mailparse [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151428 [16:47:38] (03PS2) 10Paladox: Fix issue with Vector skin preference [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/151425 [16:48:41] (03PS3) 1001tonythomas: Shifted from PEAR mimeParse to Plancake mailparse [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151428 [16:49:13] (03PS1) 10Prtksxna: Fix tooltip for privacy bar graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151429 [16:50:05] (03CR) 10MSyed: [C: 032 V: 032] Fix tooltip for privacy bar graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151429 (owner: 10Prtksxna) [16:52:47] (03CR) 10Daniel Werner: [C: 04-2] "Please correct me if my thinking is flawed, but I beliefe there is a use-case where this change set would break the extension's purpose." [extensions/StickToThatLanguage] - 10https://gerrit.wikimedia.org/r/136624 (owner: 10Microchip08) [17:03:33] (03PS23) 10Bsitu: Break notifications into alert and message sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 [17:03:37] (03CR) 10jenkins-bot: [V: 04-1] Break notifications into alert and message sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 (owner: 10Bsitu) [17:07:55] (03PS24) 10Bsitu: Break notifications into alert and message sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 [17:12:00] (03PS25) 10Bsitu: Break notifications into alert and message sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 [17:17:16] (03PS7) 10BryanDavis: Rethink multiwiki support [vagrant] - 10https://gerrit.wikimedia.org/r/149872 (https://bugzilla.wikimedia.org/68605) [17:18:20] (03CR) 10BryanDavis: Rethink multiwiki support (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/149872 (https://bugzilla.wikimedia.org/68605) (owner: 10BryanDavis) [17:28:56] (03PS1) 10Prtksxna: Dynamic height based on number of data points [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151431 [17:29:14] (03CR) 10MSyed: [C: 032 V: 032] Dynamic height based on number of data points [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151431 (owner: 10Prtksxna) [17:33:53] (03PS1) 10Prtksxna: Fix margins for where_from graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151432 [17:37:39] (03PS2) 10Prtksxna: Fix margins for where_from graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151432 [17:44:54] (03CR) 10Daniel Friesen: [C: 04-1] "One of the original purposes o .mw-body was for things like this. In fact commonElements is already using .mw-body when doing things like " [core] - 10https://gerrit.wikimedia.org/r/151395 (owner: 10Arlolra) [17:48:22] (03CR) 10Arlolra: "> One of the original purposes o .mw-body was for things like this. In fact commonElements is already using .mw-body when doing things lik" [core] - 10https://gerrit.wikimedia.org/r/151395 (owner: 10Arlolra) [17:58:36] (03PS1) 10Prtksxna: Fix where_from graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151434 [17:59:00] (03CR) 10MSyed: [C: 032 V: 032] Fix margins for where_from graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151432 (owner: 10Prtksxna) [17:59:15] (03CR) 10MSyed: [C: 032 V: 032] Fix where_from graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151434 (owner: 10Prtksxna) [18:02:22] 3MediaWiki / 3Internationalization: Changing fall-back language and language name (زَوُن) for aeb (Tunisian Language) - 10https://bugzilla.wikimedia.org/68207#c4 (10Emad Adel) Hope this is fixed soon. it took so long time.. [18:02:31] (03PS1) 10Prtksxna: Fix transition for where from graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151435 [18:03:45] (03CR) 10Brian Wolff: "Hmm, I wonder if the join condition should include AND rev_timestamp > $earliestYouCanPatrol as an optimization for things older than rcMa" [core] - 10https://gerrit.wikimedia.org/r/151381 (https://bugzilla.wikimedia.org/69061) (owner: 10Brian Wolff) [18:10:17] ugh. Why can't I view a text/plain bugzilla attachment online [18:11:07] because IE6 probably [18:11:14] (03CR) 10MSyed: [C: 032 V: 032] Fix transition for where from graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151435 (owner: 10Prtksxna) [18:11:15] :( [18:12:10] ugh. IE6 users deserve what they get [18:12:42] hmm, what's that thing that tells oldIE users to go away? [18:12:46] * YuviPanda should add that to quarry [18:13:57] https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 and https://bugzilla.wikimedia.org/show_bug.cgi?id=51839 [18:15:47] IE7 and below apparently. [18:16:07] 3MediaWiki / 3Skin and page rendering: Display error when user tries to create a circular redirect (self-redirect) - 10https://bugzilla.wikimedia.org/27683#c11 (10Inkowik) We just had a discussion on dewiki about this: http://de.wikipedia.org/w/index.php?oldid=132749388#Weiterleitungsseiten_die_auf_sich_sel... [18:16:38] and of course https://bugzilla.wikimedia.org/show_bug.cgi?id=51839 is restricted [18:19:00] well, searching for IE7 PNG vulnerability already gives all the info [18:19:52] here is one that apparently affects IE from 6 to 11 :S http://scgnews.com/new-internet-explorer-vulnerability-allows-hackers-to-take-over-computers [18:21:02] sweet [18:21:07] let's just stop people using IE [18:22:29] (03CR) 10Legoktm: Shifted from PEAR mimeParse to Plancake mailparse (031 comment) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151428 (owner: 1001tonythomas) [18:23:43] (03CR) 10Daniel Friesen: ">> One of the original purposes o .mw-body was for things like this. In fact commonElements is already using .mw-body when doing things li" [core] - 10https://gerrit.wikimedia.org/r/151395 (owner: 10Arlolra) [18:27:07] 3MediaWiki extensions / 3MaintenanceShell: MainteniceShell broken in MediaWiki 1.24 - 10https://bugzilla.wikimedia.org/69075#c1 (10Andre Klapper) Please read https://www.mediawiki.org/wiki/How_to_report_a_bug and for future reference, use https://bugzilla.wikimedia.org/enter_bug.cgi?format=guided to report b... [18:29:12] (03PS4) 1001tonythomas: Shifted from PEAR mimeParse to Plancake mailparse [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151428 [18:42:37] huh, using MaintenanceShell to run update.php? [18:43:40] *shudder* [18:45:38] (03PS1) 10Umherirrender: Remove return from Action::checkCanExecute [core] - 10https://gerrit.wikimedia.org/r/151437 [18:47:05] (03PS5) 10Paladox: Fix issue with Vector skin preference [core] - 10https://gerrit.wikimedia.org/r/151424 [18:47:24] (03PS6) 10Paladox: Fix issue with Vector skin preference [core] - 10https://gerrit.wikimedia.org/r/151424 [18:48:39] (03PS7) 10Paladox: Fix issue with Vector skin preference [core] - 10https://gerrit.wikimedia.org/r/151424 [18:48:53] (03PS8) 10Paladox: Fix issue with Vector skin preference [core] - 10https://gerrit.wikimedia.org/r/151424 [18:49:27] (03PS9) 10Paladox: Fix issue with Vector skin preference [core] - 10https://gerrit.wikimedia.org/r/151424 [18:49:31] what the... [18:49:51] (03PS3) 10Paladox: Fix issue with Vector skin preference [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/151425 [18:50:02] * YuviPanda pats bawolff [18:52:35] (03PS10) 10Paladox: Fix issue with Vector skin preference [core] - 10https://gerrit.wikimedia.org/r/151424 [18:53:05] (03Abandoned) 10Paladox: Fix issue with Vector skin preference [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/151425 (owner: 10Paladox) [18:53:10] (03PS2) 10BryanDavis: Add git::install resource and fix git::clone [vagrant] - 10https://gerrit.wikimedia.org/r/151384 [18:53:17] Did he literally just do 5 commits to change the capitalization of the commit author back and forth? [18:53:26] (03Restored) 10Paladox: Fix issue with Vector skin preference [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/151425 (owner: 10Paladox) [18:53:29] (03PS6) 10Paladox: Fix issue with Vector skin preference [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/151425 [18:53:54] poor reviewers [18:54:02] spaaaaam [18:56:42] (03PS11) 10Paladox: Fix issue with Vector skin preference [core] - 10https://gerrit.wikimedia.org/r/151424 [18:57:58] (03PS7) 10Paladox: Fix issue with Vector skin preference [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/151425 [18:59:38] as if commit mails aren't enough, they also get jenkin's ones :P [18:59:44] (03PS5) 1001tonythomas: Shifted from PEAR mimeParse to Plancake mailparse [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151428 [19:00:48] (03PS6) 1001tonythomas: Shifted from PEAR mimeParse to Plancake mailparse [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151428 [19:02:05] (03CR) 10Legoktm: [C: 032] Shifted from PEAR mimeParse to Plancake mailparse [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151428 (owner: 1001tonythomas) [19:02:10] (03Merged) 10jenkins-bot: Shifted from PEAR mimeParse to Plancake mailparse [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151428 (owner: 1001tonythomas) [19:03:05] ugh [19:03:12] let's merge that vector thing already [19:03:18] before he makes ten more patchsets [19:04:49] MatmaRex: he's made them against wmf16 [19:04:57] YuviPanda: master too [19:04:58] oh [19:04:59] as well [19:05:14] hmph, i was sure i looked at that and did this right [19:05:15] oh well [19:05:27] i wonder if we could write a test to avoid incorrect paths [19:08:07] (03CR) 10BryanDavis: "So close, but so far." (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/150243 (https://bugzilla.wikimedia.org/68785) (owner: 10MaxSem) [19:08:43] (03PS5) 10BryanDavis: Switch jobrunner to JSON config [vagrant] - 10https://gerrit.wikimedia.org/r/150243 (https://bugzilla.wikimedia.org/68785) (owner: 10MaxSem) [19:09:32] (03PS12) 10Bartosz Dziewoński: Vector: Fix missing tab images on Special:Preferences [core] - 10https://gerrit.wikimedia.org/r/151424 (owner: 10Paladox) [19:09:47] (03CR) 10Bartosz Dziewoński: [C: 032] "My mistake, sorry!" [core] - 10https://gerrit.wikimedia.org/r/151424 (owner: 10Paladox) [19:10:13] (03CR) 10Bartosz Dziewoński: [C: 04-2] "wait" [core] - 10https://gerrit.wikimedia.org/r/151424 (owner: 10Paladox) [19:10:28] ouch [19:10:56] stupid less [19:11:05] the change in skins/Vector/screen.less is wrong [19:11:09] but the current version is also wrong [19:11:19] dude, why is that shit not throwing exceptions [19:11:23] bleh [19:11:33] heh [19:11:54] (03CR) 10Bartosz Dziewoński: "The change in screen.less is wrong, but the current version is also wrong in a different way. Let me fix that." [core] - 10https://gerrit.wikimedia.org/r/151424 (owner: 10Paladox) [19:15:04] (03PS1) 10Prtksxna: Add data for user data graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151439 [19:16:55] (03Abandoned) 1001tonythomas: Moved extension classes to includes/ [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151290 (owner: 1001tonythomas) [19:17:43] (03PS13) 10Bartosz Dziewoński: Vector: Fix missing tab images on Special:Preferences [core] - 10https://gerrit.wikimedia.org/r/151424 (owner: 10Paladox) [19:17:45] (03PS1) 10Bartosz Dziewoński: Vector: Remove dead @import in screen.less [core] - 10https://gerrit.wikimedia.org/r/151441 [19:17:52] (03PS1) 1001tonythomas: Moved extension classes to inlcudes/ [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151442 [19:17:59] (03CR) 10Bartosz Dziewoński: [C: 032] "Fixed that part in https://gerrit.wikimedia.org/r/151441" [core] - 10https://gerrit.wikimedia.org/r/151424 (owner: 10Paladox) [19:19:03] YuviPanda: wanna merge? [19:20:17] (03CR) 10Yuvipanda: [C: 032] Vector: Remove dead @import in screen.less [core] - 10https://gerrit.wikimedia.org/r/151441 (owner: 10Bartosz Dziewoński) [19:21:18] (03CR) 10jenkins-bot: [V: 04-1] Vector: Fix missing tab images on Special:Preferences [core] - 10https://gerrit.wikimedia.org/r/151424 (owner: 10Paladox) [19:21:45] (03CR) 10jenkins-bot: [V: 04-1] Vector: Remove dead @import in screen.less [core] - 10https://gerrit.wikimedia.org/r/151441 (owner: 10Bartosz Dziewoński) [19:22:00] (03CR) 10Bartosz Dziewoński: [C: 032] Vector: Fix missing tab images on Special:Preferences [core] - 10https://gerrit.wikimedia.org/r/151424 (owner: 10Paladox) [19:22:10] (03Merged) 10jenkins-bot: Vector: Fix missing tab images on Special:Preferences [core] - 10https://gerrit.wikimedia.org/r/151424 (owner: 10Paladox) [19:22:43] (03Merged) 10jenkins-bot: Vector: Remove dead @import in screen.less [core] - 10https://gerrit.wikimedia.org/r/151441 (owner: 10Bartosz Dziewoński) [19:22:47] what has just happened there [19:23:02] i CR+2 [19:23:05] jenkins Verified-1 Main test build failed [19:23:11] i remove jenkins, remove myself, +2 again [19:23:16] jenkins merges with no qualms [19:23:24] jenkins be jenkins [19:23:40] (03PS8) 10Bartosz Dziewoński: Vector: Fix missing tab images on Special:Preferences [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/151425 (owner: 10Paladox) [19:23:50] jerkins :P [19:23:52] Your +2 triggered a second test run, which was positive I think [19:24:07] there were no test results reported [19:24:14] and our tests don't take thirty seconds [19:24:15] no wait [19:24:27] * bawolff was looking at https://gerrit.wikimedia.org/r/#/c/151441/ [19:24:34] (03CR) 10Bartosz Dziewoński: [C: 031] Vector: Fix missing tab images on Special:Preferences [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/151425 (owner: 10Paladox) [19:24:52] 441 is even funnier [19:25:00] i did nothing after it voted V-1 [19:25:03] yet it was merged anyway [19:25:50] hmph, there are no deployments this week, eh? [19:25:55] MatmaRex: ya [19:26:07] guess i'll have to ask reedy to deploy https://gerrit.wikimedia.org/r/#/c/151425/ myself :P [19:26:15] it's a tiny but silly issue [19:28:30] (03CR) 10Legoktm: [C: 032] Moved extension classes to inlcudes/ [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151442 (owner: 1001tonythomas) [19:28:36] (03Merged) 10jenkins-bot: Moved extension classes to inlcudes/ [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/151442 (owner: 1001tonythomas) [19:31:18] (03PS1) 10Umherirrender: Set relevant title on Special:RecentChangesLinked [core] - 10https://gerrit.wikimedia.org/r/151443 [19:39:23] (03PS1) 10Florianschmidtwelzow: Check if wgAuth is set correctly [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/151444 (https://bugzilla.wikimedia.org/68962) [19:40:07] 3MediaWiki extensions / 3[other]: [Auth_remoteuser] PHP Fatal error: Call to undefined method GoogleLoginAuth::setupExtensionForRequest() in Auth_remoteuser.php on line 129 - 10https://bugzilla.wikimedia.org/68962 (10Florian) [19:43:20] (03PS1) 10Umherirrender: Add backlinks on special pages with relevant title [core] - 10https://gerrit.wikimedia.org/r/151445 [19:43:52] (03CR) 10Arlolra: "> a.external is being applied to .mw-body-content in this patch, when .mw-body already serves that purpose." [core] - 10https://gerrit.wikimedia.org/r/151395 (owner: 10Arlolra) [19:45:51] (03CR) 10Nemo bis: [C: 031] "With informative message even, thanks. :)" [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/151444 (https://bugzilla.wikimedia.org/68962) (owner: 10Florianschmidtwelzow) [19:49:45] (03PS1) 10Paladox: Vector: Remove dead @import in screen.less [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/151446 [19:52:07] 3MediaWiki extensions / 3MassMessage: MassMessage::getMessengerUser() takeover broken due to Password API changes - 10https://bugzilla.wikimedia.org/68843#c5 (10Kunal Mehta (Legoktm)) Ideas on how to fix... * Have User::load() call loadPasswords() - fixes all back-compat issues * Make loadPasswords() public... [19:56:45] (03CR) 10Bartosz Dziewoński: "No needs to backport this IMO, it doesn't cause any visible problems." [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/151446 (owner: 10Paladox) [20:02:09] 3Wikimedia / 3Site requests: Disable Media Viewer software feature on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69080 (10Steinsplitter) 3NEW p:3Unprio s:3enhanc a:3None The community wishes that the Media Viewer will be disabled for the Non-logged-in users and the logged-in users. The RFA... [20:04:54] 3Wikimedia / 3Site requests: Disable Media Viewer software feature on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69080#c1 (10Bawolff (Brian Wolff)) a:3Fabrice Florin Taking the liberty of assigning to fabrice for response. [20:05:39] (03PS2) 10Prtksxna: Add data for user data graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151439 [20:05:43] (03PS1) 10Umherirrender: Fix backlink for RevertAction [core] - 10https://gerrit.wikimedia.org/r/151448 [20:09:36] 3Wikimedia / 3Site requests: Disable Media Viewer software feature on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69080 (10Steinsplitter) p:5Unprio>3Normal [20:11:07] 3MediaWiki / 3Patrolling: No red "!" for patrolling on Special:Contributions/user - 10https://bugzilla.wikimedia.org/69061 (10Andre Klapper) p:5Unprio>3Normal [20:12:52] 3MediaWiki extensions / 3CirrusSearch: cl_sortkey for search enhancement - 10https://bugzilla.wikimedia.org/68452#c3 (10Eran Roz) PrefixSearchStartsWithAnyWord seems to be better option, is there already existing configuration for wgCirrusSearchPrefixSearchStartsWithAnyWord? [20:14:07] 3MediaWiki / 3Special pages: Year field of Special:Contributions contains comma - 10https://bugzilla.wikimedia.org/69059#c3 (10Andre Klapper) 5UNCO>3RESO/INV Cannot reproduce the problem with Firefox 31 or Google Chrome 36 on Linux. I'm not aware of any specific year rendering code depending on platform... [20:15:22] 3MediaWiki / 3Search: AJAX search suggestion shows non-existent page "Meta:Speedy Deletions" on meta.wikimedia.org - 10https://bugzilla.wikimedia.org/69063 (10Andre Klapper) p:5Unprio>3Low [20:16:07] 3Wikimedia / 3Site requests: Enable uploads on eml.wikipedia - 10https://bugzilla.wikimedia.org/69056 (10Andre Klapper) p:5Unprio>3Normal [20:16:52] 3Wikimedia / 3Site requests: Set $wgUploadNavigationUrl on eo.wikipedia - 10https://bugzilla.wikimedia.org/69055 (10Andre Klapper) p:5Unprio>3Normal [20:18:33] (03PS1) 10MSyed: Style changes [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151504 [20:19:16] (03CR) 10MSyed: [C: 032 V: 032] Add data for user data graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151439 (owner: 10Prtksxna) [20:25:13] (03PS2) 10Prtksxna: Style changes [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151504 (owner: 10MSyed) [20:25:34] (03CR) 10Prtksxna: [C: 032 V: 032] Style changes [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151504 (owner: 10MSyed) [20:28:07] 3MediaWiki extensions / 3CirrusSearch: Bold sidebar and search results when searching on is.wikipedia.org - 10https://bugzilla.wikimedia.org/61348#c10 (10Andre Klapper) I can reproduce the problem with Firefox 31 on Fedora 20 (Linux) on is.wp. For example, https://is.wikipedia.org/w/index.php?title=Kerfiss%... [20:28:22] 3MediaWiki / 3Skin and page rendering: Agora .mw-ui-input focus indicator uses a different blue from colorProgressive - 10https://bugzilla.wikimedia.org/69040 (10Andre Klapper) p:5Unprio>3Normal [20:28:38] 3MediaWiki / 3Skin and page rendering: Canonical links may be in fallback encoding - 10https://bugzilla.wikimedia.org/69026 (10Andre Klapper) p:5Unprio>3Normal [20:29:09] 3MediaWiki / 3Database: Separate logging.log_params into a new table - 10https://bugzilla.wikimedia.org/10512 (10Andre Klapper) 5NEW>3RESO/WOR [20:33:53] 3MediaWiki extensions / 3WikiEditor: Custom bold and italic icons for Russian & Ukrainian language - 10https://bugzilla.wikimedia.org/23914#c5 (10Andre Klapper) a:5Trevor Parscal>3None I can confirm that buttons Ж (жирный / bold) and К (курсивный / cursive) are available when editing wiki text on ru.wiki... [20:35:22] 3Wikimedia / 3Extension setup: Review and deploy BounceHandler extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/69019#c1 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc For clarification, have security review and performance review of the code base happened already, or are there... [20:36:52] 3MediaWiki extensions / 3CirrusSearch: Cirrus finds no results but Lucene finds 630 (when search in all namespaces enabled) - 10https://bugzilla.wikimedia.org/68920 (10Andre Klapper) p:5Unprio>3Normal s:5major>3normal [20:37:07] 3MediaWiki / 3Database: update.php does not tell it's executing PopulateBacklinkNamespace - 10https://bugzilla.wikimedia.org/69010 (10Andre Klapper) p:5Unprio>3Normal [20:37:52] (03PS1) 10Prtksxna: Fixes to the user data page [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151505 [20:38:07] 3MediaWiki / 3General/Unknown: The page http://myMediawiki.dgfip/wt/index.php/Special:Pages_speciales crashes - 10https://bugzilla.wikimedia.org/68212 (10Andre Klapper) p:5Unprio>3Lowest [20:38:12] (03CR) 10MSyed: [C: 032 V: 032] Fixes to the user data page [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151505 (owner: 10Prtksxna) [20:40:07] 3Wikimedia / 3Site requests: Please add the deleted domain *.eur.nl again to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/68803#c2 (10Andre Klapper) Don't know the exact details why this was reverted. CC'ing the GWToolset maintainers / default CCs, maybe somebody knows. [20:48:50] (03PS1) 10MSyed: FAQ content change [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151508 [20:51:38] (03CR) 10Prtksxna: [C: 032 V: 032] FAQ content change [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151508 (owner: 10MSyed) [20:51:59] (03PS1) 10Prtksxna: Fix tooltip position in user data bar graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151509 [20:52:40] (03PS1) 10MSyed: Content change in privacy doc [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151510 [20:52:51] (03PS2) 10Prtksxna: Fix tooltip position in user data bar graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151509 [20:53:04] (03CR) 10Prtksxna: [C: 032 V: 032] Content change in privacy doc [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151510 (owner: 10MSyed) [20:53:42] (03PS3) 10Prtksxna: Fix tooltip position in user data bar graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151509 [20:54:11] (03CR) 10MSyed: [C: 032 V: 032] Fix tooltip position in user data bar graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151509 (owner: 10Prtksxna) [20:55:07] 3Wikimedia / 3SSL related: Add Forward Secrecy - 10https://bugzilla.wikimedia.org/53259 (10Andre Klapper) [20:55:12] (03CR) 10Paladox: "Oh ok." [core] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/151446 (owner: 10Paladox) [21:03:40] Css looks broken on beta: http://deployment.wikimedia.beta.wmflabs.org/wiki/Main_Page [21:06:07] (03PS1) 10Legoktm: Add tests for ConfigFactory::getDefaultInstance [core] - 10https://gerrit.wikimedia.org/r/151513 [21:06:37] 3Wikimedia / 3Site requests: Please add the deleted domain *.eur.nl again to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/68803#c3 (10Bawolff (Brian Wolff)) (In reply to Andre Klapper from comment #2) > Don't know the exact details why this was reverted. > CC'ing the GWToolset maint... [21:07:44] and http://deployment.wikimedia.beta.wmflabs.org/wiki/Special:ListUsers/gwtoolset is just broken... [21:09:14] (03PS1) 10MSyed: Bignav on index page fix [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151514 [21:09:47] (03CR) 10jenkins-bot: [V: 04-1] Add tests for ConfigFactory::getDefaultInstance [core] - 10https://gerrit.wikimedia.org/r/151513 (owner: 10Legoktm) [21:10:10] (03PS1) 10Prtksxna: Minor fixes on user data chart [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151515 [21:10:49] (03CR) 10Prtksxna: [C: 032 V: 032] Bignav on index page fix [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151514 (owner: 10MSyed) [21:10:52] 3Wikimedia / 3Extension setup: Review and deploy BounceHandler extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/69019#c2 (10Greg Grossmeier) For completeness' sake, see the checklist and please create bugs for parts still needing to be done: https://www.mediawiki.org/wiki/Review_queue#Checklist [21:11:25] (03CR) 10MSyed: [C: 032 V: 032] Minor fixes on user data chart [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151515 (owner: 10Prtksxna) [21:13:22] (03PS4) 1020after4: Patch to make phabricator file attachment policies more sane. [phabricator/phabricator] - 10https://gerrit.wikimedia.org/r/148360 [21:16:03] (03CR) 1020after4: [C: 032] Patch to make phabricator file attachment policies more sane. [phabricator/phabricator] - 10https://gerrit.wikimedia.org/r/148360 (owner: 1020after4) [21:17:52] 3Wikimedia / 3Site requests: Disable Media Viewer software feature by default on Wikimedia Commons - 10https://bugzilla.wikimedia.org/69080#c2 (10Bawolff (Brian Wolff)) To be clear, per the closing comment on the rfc: "...Of course individual users can still enable the tool in their preferences if they wish... [21:20:16] (03PS1) 10Legoktm: SpecialActiveusers: Use Config objects instead of globals [core] - 10https://gerrit.wikimedia.org/r/151518 [21:22:40] 3MediaWiki / 3Email: Account creation by email often winds up marked as spam - 10https://bugzilla.wikimedia.org/62704#c7 (10Nemo) Probably whatever valid issue involved here also affects bug 56414. [21:22:40] 3Wikimedia / 3General/Unknown: Get mail relay out of Yahoo! blacklist: apply to Yahoo for whitelisting bulk mail - 10https://bugzilla.wikimedia.org/56414 (10Nemo) [21:24:33] (03PS5) 1020after4: Patch to make phabricator file attachment policies more sane. [phabricator/phabricator] - 10https://gerrit.wikimedia.org/r/148360 [21:26:10] (03PS1) 10Legoktm: SpecialBookSources: Use wfScript() instead of global [core] - 10https://gerrit.wikimedia.org/r/151519 [21:27:41] (03PS2) 10Legoktm: Use wfScript() instead of global in a few places [core] - 10https://gerrit.wikimedia.org/r/151519 [21:28:07] 3MediaWiki extensions / 3CirrusSearch: Cirrus finds no results but Lucene finds 500+ (when searching outside main namespace) - 10https://bugzilla.wikimedia.org/68920 (10Helder) [21:28:30] (03CR) 10Cscott: "`git bisect` is telling me that this commit broke `php tests/parserTests.php`." [core] - 10https://gerrit.wikimedia.org/r/146683 (owner: 10Aaron Schulz) [21:30:40] (03PS1) 10Legoktm: SpecialChangeEmail: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151520 [21:32:45] (03PS1) 10Legoktm: SpecialChangePassword: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151521 [21:32:56] (03PS4) 1020after4: Project Policy Enforcer action for herald. This refactors the maniphest event listener into a custom herald action [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/147356 [21:38:54] 3MediaWiki / 3Unit tests: Gerrit 146683 broke `php tests/parserTests.php`. - 10https://bugzilla.wikimedia.org/69082 (10C. Scott Ananian) 3NEW p:3Unprio s:3normal a:3None `git bisect` shows that gerrit patch https://gerrit.wikimedia.org/r/146683 broke `php tests/parserTests.php`. $ php tests/parserTe... [21:40:50] (03PS3) 1020after4: CustomField extension that adds a "MediaWiki Userpage" link on phabricator user profile pages when a phabricator account is linked to mediawiki oauth. [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/144711 [21:41:23] 3MediaWiki / 3Unit tests: Gerrit 146683 broke `php tests/parserTests.php`. - 10https://bugzilla.wikimedia.org/69082 (10C. Scott Ananian) a:3Aaron Schulz [21:42:02] (03PS1) 10Cscott: Revert "Made LCStoreDB try to use a separate DB connection" [core] - 10https://gerrit.wikimedia.org/r/151522 (https://bugzilla.wikimedia.org/69082) [21:42:29] (03CR) 1020after4: "@chad: re-review?" (031 comment) [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/144711 (owner: 1020after4) [21:44:02] (03PS3) 10Legoktm: Use wfScript() instead of global in a few places [core] - 10https://gerrit.wikimedia.org/r/151519 [21:46:06] (03PS1) 10Legoktm: DeletedContributionsPage: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151524 [21:46:33] (03PS9) 10Cscott: Run some parser tests with tidy. [core] - 10https://gerrit.wikimedia.org/r/133957 [21:52:22] (03PS1) 10Legoktm: SpecialEmailUser: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151525 [21:53:37] 3Wikimedia / 3Site requests: Please add the deleted domain *.eur.nl again to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/68803#c4 (10dan) the situation is as bawolff mentioned above. hans, please use the commons beta server to test any uploads. [21:55:34] (03PS1) 10Legoktm: SpecialExpandTemplates: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151527 [22:04:22] 3Wikimedia / 3Site requests: Please add the deleted domain *.eur.nl again to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/68803 (10Bawolff (Brian Wolff)) 5UNCO>3RESO/WOR [22:09:10] (03PS1) 10MSyed: Added few more FAQ questions [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151528 [22:10:41] (03PS1) 10Legoktm: SpecialExport: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151529 [22:13:17] (03CR) 10Umherirrender: "Gives "Warning: symlink(): Cannot create symlink, error code(1314) in \includes\media\SVG.php on line 204" when running parser tests on a " [core] - 10https://gerrit.wikimedia.org/r/145232 (owner: 10Aaron Schulz) [22:13:28] (03CR) 10Cscott: "Subbu: this version is ready for (re)review." [core] - 10https://gerrit.wikimedia.org/r/133957 (owner: 10Cscott) [22:13:45] (03CR) 10Prtksxna: [C: 032 V: 032] Added few more FAQ questions [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151528 (owner: 10MSyed) [22:14:30] prtksxna: such merging :) [22:14:30] (03PS1) 10Prtksxna: Add targeted takedown graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151530 [22:14:32] (03PS1) 10Prtksxna: Add tageted DMCA graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151531 [22:16:14] (03PS1) 10MSyed: Added link for "download data" in footer Also added the file in data folder [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151532 [22:16:56] (03CR) 10Prtksxna: [C: 032 V: 032] Added link for "download data" in footer Also added the file in data folder [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151532 (owner: 10MSyed) [22:17:09] (03CR) 10MSyed: [C: 032 V: 032] Add targeted takedown graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151530 (owner: 10Prtksxna) [22:17:26] (03CR) 10MSyed: [C: 032 V: 032] Add tageted DMCA graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151531 (owner: 10Prtksxna) [22:18:33] (03PS2) 10Legoktm: Add tests for ConfigFactory::getDefaultInstance [core] - 10https://gerrit.wikimedia.org/r/151513 [22:19:00] (03CR) 10Aklapper: "(For the records, I have no idea how to hand out +2 permissions in Gerrit projects and the interface at https://gerrit.wikimedia.org/r/#/a" [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/144711 (owner: 1020after4) [22:21:53] (03CR) 10jenkins-bot: [V: 04-1] Add tests for ConfigFactory::getDefaultInstance [core] - 10https://gerrit.wikimedia.org/r/151513 (owner: 10Legoktm) [22:22:25] 3MediaWiki / 3Special pages: SpecialPagesWithProp uses implicit join - 10https://bugzilla.wikimedia.org/69083 (10Robert Morley) 3NEW p:3Unprio s:3normal a:3None In the getQueryInfo() of SpecialPagesWithProp.php, the 'page_id = pp_page' represents an implicit join, which are generally frowned upon and... [22:23:33] (03PS4) 10Legoktm: Use wfScript() instead of global in a few places [core] - 10https://gerrit.wikimedia.org/r/151519 [22:24:37] 3MediaWiki / 3Special pages: SpecialPagesWithProp uses implicit join - 10https://bugzilla.wikimedia.org/69083 (10Robert Morley) p:5Unprio>3High s:5normal>3minor [22:34:34] (03PS1) 10MSyed: Privacy.js minor style fix for bottomline [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151534 [22:34:45] (03PS1) 10Legoktm: SpecialImport: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151535 [22:34:57] (03CR) 10Prtksxna: [C: 032 V: 032] Privacy.js minor style fix for bottomline [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151534 (owner: 10MSyed) [22:35:25] (03CR) 10Addshore: [C: 032] Use wfScript() instead of global in a few places [core] - 10https://gerrit.wikimedia.org/r/151519 (owner: 10Legoktm) [22:36:01] (03PS3) 10Legoktm: Add tests for ConfigFactory::getDefaultInstance [core] - 10https://gerrit.wikimedia.org/r/151513 [22:38:10] (03Merged) 10jenkins-bot: Use wfScript() instead of global in a few places [core] - 10https://gerrit.wikimedia.org/r/151519 (owner: 10Legoktm) [22:42:02] (03CR) 10Addshore: [C: 032] SpecialExport: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151529 (owner: 10Legoktm) [22:42:29] (03CR) 10Addshore: [C: 032] SpecialExpandTemplates: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151527 (owner: 10Legoktm) [22:42:56] 3MediaWiki / 3General/Unknown: Convert things to use Config classes instead of globals (tracking) - 10https://bugzilla.wikimedia.org/69084 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3enhanc a:3None Tracking bugs to convert core/extensions/etc to use Config classes/interface instead of accessing globa... [22:42:56] 3MediaWiki / 3General/Unknown: Tracking bug (tracking) - 10https://bugzilla.wikimedia.org/2007 (10Kunal Mehta (Legoktm)) [22:43:07] 3MediaWiki / 3General/Unknown: Reduce use of global and public variables (tracking) - 10https://bugzilla.wikimedia.org/9968 (10Kunal Mehta (Legoktm)) [22:44:06] (03CR) 10Addshore: [C: 032] DeletedContributionsPage: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151524 (owner: 10Legoktm) [22:45:02] (03CR) 10Addshore: [C: 032] SpecialChangeEmail: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151520 (owner: 10Legoktm) [22:45:04] (03PS1) 10Withoutaname: Remove unused system messages "loginstart", "loginend" and "loginend-https" [core] - 10https://gerrit.wikimedia.org/r/151536 [22:45:17] (03CR) 10jenkins-bot: [V: 04-1] SpecialExport: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151529 (owner: 10Legoktm) [22:45:42] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/151529 (owner: 10Legoktm) [22:45:47] (03CR) 10Addshore: [C: 032] SpecialChangePassword: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151521 (owner: 10Legoktm) [22:46:42] (03Merged) 10jenkins-bot: SpecialExpandTemplates: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151527 (owner: 10Legoktm) [22:47:17] (03Merged) 10jenkins-bot: DeletedContributionsPage: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151524 (owner: 10Legoktm) [22:47:46] are the qunit tests randomly failing? [22:48:06] could this one be checked https://gerrit.wikimedia.org/r/151536 [22:48:20] (03CR) 10jenkins-bot: [V: 04-1] SpecialChangeEmail: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151520 (owner: 10Legoktm) [22:48:39] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/151520 (owner: 10Legoktm) [22:49:16] legoktm: if you merge too fast would there ever be a merge conflict with itself [22:49:27] no [22:49:35] the qunit tests are just randomly failing [22:49:46] silly randomness [22:49:48] (03Merged) 10jenkins-bot: SpecialChangePassword: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151521 (owner: 10Legoktm) [22:51:16] where would you store the configs [22:51:31] if you wanted a way to persist data without the use of globals [22:51:44] in the database! [22:52:11] (03PS1) 10Bsitu: Flow notification item new style [extensions/Flow] - 10https://gerrit.wikimedia.org/r/151537 [22:54:19] (03PS1) 10Legoktm: SpecialJavaScriptTest: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151538 [22:54:21] legoktm: so should I use $this->getConfig instead of global $x; if ( $x ) ... [22:54:34] I want to rewrite userlogin [22:55:40] yes [22:55:42] umm [22:55:47] a lot of people do :P [22:55:59] https://www.mediawiki.org/wiki/Requests_for_comment/AuthStack is the RfC for overhauling the entire thing [22:56:19] oh I didnt mean the authentication mechanism [22:56:22] just the gui [22:56:40] actually we could just take out all the annoying consts [22:56:58] the conts aren't the problem...? [22:58:43] well, at least Tyler rewrote the password part [22:58:45] (03PS1) 10MSyed: Added links to quotes And Minor style changes [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151539 [23:01:11] (03CR) 10Addshore: [C: 032] SpecialJavaScriptTest: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151538 (owner: 10Legoktm) [23:01:24] (03PS1) 10Legoktm: SpecialLinkSearch: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151540 [23:01:53] 3MediaWiki / 3General/Unknown: Code quality issues (tracking) - 10https://bugzilla.wikimedia.org/700 (10Andre Klapper) [23:01:53] 3MediaWiki / 3Special pages: SpecialPagesWithProp uses implicit join - 10https://bugzilla.wikimedia.org/69083 (10Andre Klapper) [23:01:54] (03PS1) 10Legoktm: SpecialListFiles: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151541 [23:02:40] (03CR) 10Addshore: [C: 032] SpecialLinkSearch: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151540 (owner: 10Legoktm) [23:03:20] (03CR) 10Subramanya Sastry: [C: 032] Run some parser tests with tidy. [core] - 10https://gerrit.wikimedia.org/r/133957 (owner: 10Cscott) [23:03:26] (03CR) 10Addshore: [C: 032] SpecialListFiles: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151541 (owner: 10Legoktm) [23:05:28] (03CR) 10jenkins-bot: [V: 04-1] SpecialJavaScriptTest: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151538 (owner: 10Legoktm) [23:06:03] wtf jenkins??? [23:06:19] qunit has been fucked for about a week now, again [23:06:23] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/151538 (owner: 10Legoktm) [23:06:29] is there a bug for this? [23:06:32] dunno [23:06:41] it's snafu for most people… [23:06:50] (03CR) 10jenkins-bot: [V: 04-1] SpecialLinkSearch: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151540 (owner: 10Legoktm) [23:07:43] we need an auto "recheck" bot [23:08:10] Or unit tests that don't suck [23:08:16] (03Merged) 10jenkins-bot: SpecialLinkSearch: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151540 (owner: 10Legoktm) [23:08:26] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/151540 (owner: 10Legoktm) [23:08:27] xP [23:08:37] oh wait [23:08:38] hah, it did it again [23:08:39] V-1 [23:08:41] then merge [23:08:43] wonderful [23:08:44] that one already got merged >.> [23:08:53] sigh. [23:09:17] (03Merged) 10jenkins-bot: SpecialListFiles: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151541 (owner: 10Legoktm) [23:09:38] (03CR) 10Prtksxna: [C: 032 V: 032] Added links to quotes And Minor style changes [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151539 (owner: 10MSyed) [23:09:57] legoktm: http://phpunit.de/manual/4.1/en/appendixes.annotations.html#appendixes.annotations.backupStaticAttributes [23:10:20] rekon you could use that instead of making the destryDefaultInstance method in https://gerrit.wikimedia.org/r/#/c/151513/3/includes/config/ConfigFactory.php [23:10:25] (03PS1) 10Prtksxna: Add dmca requests graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151543 [23:10:31] never personally used it but it is documented and should work [23:11:05] (03CR) 10MSyed: [C: 032 V: 032] Add dmca requests graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/151543 (owner: 10Prtksxna) [23:14:03] addshore: ok, looking [23:14:12] (03PS1) 10Legoktm: SpecialListgrouprights: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151544 [23:14:22] I almost feel like I would test it before trusting it :P [23:14:33] but only as I have never used it :P [23:14:36] could you maybe do https://gerrit.wikimedia.org/r/#/c/146985 then? it helps get rid of wgtitle [23:14:38] * bawolff looks forward to rebasing fun after all those patches land [23:14:51] the config patches? [23:15:18] yeah [23:15:18] (03CR) 10Addshore: "+ maybe see http://phpunit.de/manual/4.1/en/appendixes.annotations.html#appendixes.annotations.backupStaticAttributes" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151513 (owner: 10Legoktm) [23:15:50] addshore: ^ [23:17:30] (03PS4) 10Legoktm: Add tests for ConfigFactory::getDefaultInstance [core] - 10https://gerrit.wikimedia.org/r/151513 [23:17:54] addshore: lets see what jenkins thinks... [23:18:00] bawolff: the API rebases weren't that bad I think. [23:18:40] legoktm: indeed, I guess it would have broken other things without the ConfigFactory::destroyDefaultInstance(); [23:19:11] ahh, your testing it with the backup disabled first? :) [23:19:20] I mean its a small change that will probably cause merge conflicts everywhere [23:19:50] addshore: wait, was I supposed to do @backupStaticAttributes enabled? [23:19:58] it failed https://integration.wikimedia.org/ci/job/mediawiki-core-phpunit-databaseless/30825/console [23:20:03] legoktm: I think the annotation is just meant to be there [23:20:07] so now removed the disabled :P [23:20:19] and it should pass and that also means the annotation works! [23:20:43] (03CR) 10jenkins-bot: [V: 04-1] Add tests for ConfigFactory::getDefaultInstance [core] - 10https://gerrit.wikimedia.org/r/151513 (owner: 10Legoktm) [23:20:48] (03PS5) 10Legoktm: Add tests for ConfigFactory::getDefaultInstance [core] - 10https://gerrit.wikimedia.org/r/151513 [23:22:01] addshore: nope, errored again. [23:22:41] I wonder if 'enabled' works [23:22:53] > 23:21:40 PHPUnit 3.7.28 by Sebastian Bergmann. [23:22:56] does this exist in 3.7? [23:23:10] it does http://phpunit.de/manual/3.7/en/appendixes.annotations.html#appendixes.annotations.backupStaticAttributes [23:23:10] (03PS6) 10Legoktm: Add tests for ConfigFactory::getDefaultInstance [core] - 10https://gerrit.wikimedia.org/r/151513 [23:24:23] addshore: 'enabled' didn't work either. [23:24:35] hmm, you had it in the tear down as well before, maybe you need to add the annoation to the while class? (I havnt looked at the other tests) Or it might just not work :P [23:25:05] I think adding a destroyMainInstance is easier than PHPUnit magic :P [23:25:15] RequestContext has the same thing too [23:25:19] but but but, magic :P *agrees* :P [23:26:09] (03CR) 10jenkins-bot: [V: 04-1] Add tests for ConfigFactory::getDefaultInstance [core] - 10https://gerrit.wikimedia.org/r/151513 (owner: 10Legoktm) [23:26:12] * legoktm restores PS3 [23:26:18] :D [23:26:54] 3MediaWiki / 3General/Unknown: Add GetActionLinks hook to DeleteLogFormatter::getActionLinks() - 10https://bugzilla.wikimedia.org/69085 (10Nathan Larson) 3NEW p:3Unprio s:3normal a:3None Add GetActionLinks hook to DeleteLogFormatter::getActionLinks() so that [[mw:Extension:MoveRevisions]] will work. [23:27:06] (03PS7) 10Legoktm: Add tests for ConfigFactory::getDefaultInstance [core] - 10https://gerrit.wikimedia.org/r/151513 [23:27:14] if a patch is abandoned can I take it? https://gerrit.wikimedia.org/r/#/c/27022/ was on the RFC you mentioned legoktm [23:27:18] (03CR) 10Legoktm: "PS7 is PS3 with the typo fixed" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151513 (owner: 10Legoktm) [23:27:47] withoutaname: yes, but I don't think you should [23:27:50] > The rest of the login system needs to be fixed before the UI part. [23:28:07] I only did the GUI :S [23:28:18] I guess I'll work on the auth system then [23:28:19] (03CR) 10Addshore: [C: 032] Add tests for ConfigFactory::getDefaultInstance [core] - 10https://gerrit.wikimedia.org/r/151513 (owner: 10Legoktm) [23:28:33] withoutaname: whatever you choose, you should coordinate with Tyler. [23:29:02] withoutaname: I don't think it's a good task for you though, it's going to be very very difficult to do [23:29:04] is email my only contact? [23:29:20] yeah I just stick mainly to trivial stuff :S [23:29:24] he doesn't come on IRC very often [23:30:06] addshore: I was thinking it would be nice if we could have https://integration.wikimedia.org/cover/mediawiki-core/master/php/index.html for extensions [23:30:25] yep :P [23:30:39] could probably do it at wikimania [23:31:04] glad to see my phpunit phar patches got merged (even with 1 little bug) shame I never got a chance to follow it up :/ [23:31:21] (03Merged) 10jenkins-bot: Add tests for ConfigFactory::getDefaultInstance [core] - 10https://gerrit.wikimedia.org/r/151513 (owner: 10Legoktm) [23:32:27] (03PS1) 10Legoktm: SpecialListUsers: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151546 [23:32:42] addshore: :D [23:33:13] (03CR) 10Addshore: [C: 032] SpecialListUsers: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151546 (owner: 10Legoktm) [23:33:38] addshore: the HHVM regression test is failing with something about a phar though... [23:33:51] ahh yes, there is a patch up for that [23:33:59] link? [23:34:02] https://gerrit.wikimedia.org/r/#/c/151394/ [23:34:09] I reviewed a bit of it earlier [23:34:37] 3MediaWiki extensions / 3SemanticForms: Prevent double save on double click on "Save page" button - 10https://bugzilla.wikimedia.org/67409#c4 (10Florian) Is there any news? [23:34:43] not sure I quite like it currently [23:35:45] eh, most of that looks over my head :/ [23:35:54] feel like it should maybe be another option, rather than passing a file path into something called with-phpunitdir [23:36:11] (03Merged) 10jenkins-bot: SpecialListUsers: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151546 (owner: 10Legoktm) [23:36:13] (03PS1) 10Legoktm: SpecialLockdb: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151547 [23:36:25] why is Special:LockDB even in core still... [23:36:32] :P [23:36:58] (03CR) 10Addshore: [C: 032] SpecialLockdb: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151547 (owner: 10Legoktm) [23:38:09] (03CR) 10Addshore: [C: 04-1] phpunit.php: Allow direct use of a PHPUnit PHAR file. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/151394 (https://bugzilla.wikimedia.org/58881) (owner: 10JanZerebecki) [23:38:45] anyone think of using phabricator instead? [23:39:56] (03Merged) 10jenkins-bot: SpecialLockdb: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151547 (owner: 10Legoktm) [23:40:04] (03PS1) 10Legoktm: SpecialLog: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151548 [23:42:11] (03PS1) 10Legoktm: SpecialMergeHistory: Use wfScript() instead of globals [core] - 10https://gerrit.wikimedia.org/r/151549 [23:42:39] wait don't merge that one yet [23:43:06] (03PS2) 10Legoktm: Use wfScript() instead of globals in a few places [core] - 10https://gerrit.wikimedia.org/r/151549 [23:44:49] (03CR) 10Addshore: [C: 04-1] "Needs a manual rebase :(" [core] - 10https://gerrit.wikimedia.org/r/142635 (owner: 10MaxSem) [23:45:26] 3MediaWiki extensions / 3MassMessage: MassMessage::getMessengerUser() takeover broken due to Password API changes - 10https://bugzilla.wikimedia.org/68843#c6 (10Tyler Romeo) (In reply to Kunal Mehta (Legoktm) from comment #5) > Ideas on how to fix... > > * Have User::load() call loadPasswords() - fixes all... [23:45:27] legoktm: which? :P [23:45:40] oh, I already updated https://gerrit.wikimedia.org/r/151549 [23:45:44] :P [23:46:52] (03CR) 10Addshore: [C: 032] SpecialLog: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151548 (owner: 10Legoktm) [23:47:12] @legoktm just read your last changes to "Use Config instead of globals", now i have a "silly" question: Is there a "when use globals and when use Config" matrix or simply "Use Config::get instead of globals everytime it's possible"? :) [23:47:13] (03CR) 10Addshore: [C: 032] Use wfScript() instead of globals in a few places [core] - 10https://gerrit.wikimedia.org/r/151549 (owner: 10Legoktm) [23:47:34] time for sleep, tata! [23:47:39] gnite addshore [23:47:42] and thanks :D [23:48:08] FlorianSW: Config should only be used for configuration options, and not global objects like $wgUser [23:48:52] Yeah, sure :) I mean e.g. a configuration for an Extension [23:49:04] oh yeah [23:49:15] some extensions have globals prefixed with eg [23:49:43] FlorianSW: so for extensions, you want to create your own configuration instance. let me find the docs [23:49:45] yeah, people fight about that in the coding conventions [23:50:02] (03CR) 10jenkins-bot: [V: 04-1] SpecialLog: Use Config instead of globals [core] - 10https://gerrit.wikimedia.org/r/151548 (owner: 10Legoktm) [23:50:13] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/151548 (owner: 10Legoktm) [23:50:30] (03Merged) 10jenkins-bot: Use wfScript() instead of globals in a few places [core] - 10https://gerrit.wikimedia.org/r/151549 (owner: 10Legoktm) [23:51:13] (03PS1) 10leucosticte: Add GetActionLinks hook to DeleteLogFormatter [core] - 10https://gerrit.wikimedia.org/r/151550 (https://bugzilla.wikimedia.org/69085) [23:51:26] hm, these docs are old. /me updates [23:52:05] withoutaname: Just to clarify, you mean config options prefixed with "eg" instead of "wg"? Ok... [23:52:21] legoktm: have you a link? :) [23:53:08] FlorianSW: https://www.mediawiki.org/wiki/Manual:Configuration_for_developers [23:54:18] legoktm: is it alright if I use a switch statement for wfScript [23:54:29] it's still a little difficult in extensions because of some ways core is structured, but there's work to make it easier [23:54:41] like DanielK's API factory patch [23:55:11] withoutaname: I don't see why you would... [23:55:38] I guess I read it better? [23:56:42] legoktm hmm, so for now, be patient and wait for an easier solution? [23:57:07] FlorianSW: what extension are you thinking of? [23:57:55] https://www.mediawiki.org/wiki/Extension:GoogleLogin and maybe (but there it's not my decision, just if it is ready for discussion at all) https://www.mediawiki.org/wiki/Extension:MobileFrontend [23:59:35] eek, $wgOut :( [23:59:57] where? :O