[00:02:50] (03CR) 10CSteipp: "I think we're ok doing this" [core] - 10https://gerrit.wikimedia.org/r/150048 (https://bugzilla.wikimedia.org/67044) (owner: 10Brian Wolff) [00:05:09] 3MediaWiki / 3Special pages: Merge ViewFiles extension to the core - 10https://bugzilla.wikimedia.org/68776 (10Nathan Larson) 3NEW p:3Unprio s:3enhanc a:3None [[mw:Extension:ViewFiles]] implements the Special:ViewFiles page, important for allowing users to view LocalSettings.php. [00:08:39] (03PS5) 10Jdlrobson: Highlight unread message from notifications link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148310 (owner: 10EBernhardson) [00:09:10] (03CR) 10Jdlrobson: "I made some tweaks to the css." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148310 (owner: 10EBernhardson) [00:09:28] (03CR) 10Jdlrobson: [C: 04-1] "Once that's fixed happy to merge. (heading home soon so can't fix myself right now)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148310 (owner: 10EBernhardson) [00:09:37] 3MediaWiki extensions / 3WikidataRepo: Badges on Special:SetSiteLink should be listed with label not only id - 10https://bugzilla.wikimedia.org/67923 (10Marius Hoch) 5PATC>3RESO/FIX [00:14:45] (03PS3) 10Aaron Schulz: Merged --dispatcher and --wrapper params [services/jobrunner] - 10https://gerrit.wikimedia.org/r/149923 [00:15:14] (03PS2) 10Aaron Schulz: Refactored duplicated code into JobRunner.php [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150031 [00:16:07] 3MediaWiki / 3Special pages: Merge ViewFiles extension to the core - 10https://bugzilla.wikimedia.org/68776#c1 (10MZMcBride) 5NEW>3UNCO (In reply to Nathan Larson from comment #0) > [[mw:Extension:ViewFiles]] implements the Special:ViewFiles page, important > for allowing users to view LocalSettings.php.... [00:18:36] 3Wikimedia / 3Bugzilla: add component for jouncebot - 10https://bugzilla.wikimedia.org/68549#c6 (10Tyler Romeo) 5ASSI>3RESO/FIX I went ahead and made dzahn@wikimedia.org, mwalker@khaosdev.com the default CC. Let me know if this is incorrect. [00:20:36] 3MediaWiki / 3Special pages: Merge ViewFiles extension to the core - 10https://bugzilla.wikimedia.org/68776#c2 (10Nathan Larson) I think UNCONFIRMED would be for if we weren't certain whether it's unmerged. In other words, a question of fact rather than an opinion as to the likelihood that it should be WONTF... [00:20:52] (03CR) 10Aaron Schulz: [C: 032] Refactored duplicated code into JobRunner.php [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150031 (owner: 10Aaron Schulz) [00:21:06] 3MediaWiki skins / 3Vector: If "More" menu contains only one item (usually "Move"), display the item instead of "More" - 10https://bugzilla.wikimedia.org/68774#c2 (10James Forrester) This seems good in English; for other languages, I'm not sure it works very well as "move" and "more" are not generally transl... [00:23:32] (03Merged) 10jenkins-bot: Refactored duplicated code into JobRunner.php [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150031 (owner: 10Aaron Schulz) [00:24:19] (03CR) 10Jforrester: [C: 032] "Have +2'ed I30c8ce13 too." [core] - 10https://gerrit.wikimedia.org/r/148305 (owner: 10Bartosz Dziewoński) [00:24:36] 3MediaWiki / 3Special pages: Merge ViewFiles extension to the core - 10https://bugzilla.wikimedia.org/68776#c3 (10Nathan Larson) Perhaps ViewFiles could be made smart enough to tell whether sensitive configuration settings, e.g. $wgDBpassword, are exposed in the config file. It could look for, e.g., the stri... [00:25:06] 3Wikimedia / 3Deployment systems: [OPS] Jenkins: Package php5-parsekit missing in Trusty - 10https://bugzilla.wikimedia.org/68255#c5 (10Andrew Bogott) I duplicated the php5-parsekit version in our repo on Trusty. There are a million other deps that won't fall so easily though. [00:25:23] 3MediaWiki / 3Documentation: Documentation is out of date, incomplete (tracking) - 10https://bugzilla.wikimedia.org/1 (10Kunal Mehta (Legoktm)) [00:27:29] (03Merged) 10jenkins-bot: Resources.php: Remove/deprecate 'skinStyles' references to 'minerva' skin [core] - 10https://gerrit.wikimedia.org/r/148305 (owner: 10Bartosz Dziewoński) [00:27:51] (03PS1) 10Mwalker: Use HKEYS instead of HSCAN [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/150097 [00:28:28] (03CR) 10Mwalker: [C: 032] Use HKEYS instead of HSCAN [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/150097 (owner: 10Mwalker) [00:28:30] (03PS1) 10Aaron Schulz: Added support for result=json parameter to runJobs.php [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150098 [00:28:48] (03Merged) 10jenkins-bot: Use HKEYS instead of HSCAN [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/150097 (owner: 10Mwalker) [00:28:58] MaxSem, if you're still around; mind merging https://gerrit.wikimedia.org/r/#/c/149265/ ? [00:30:07] 3MediaWiki extensions / 3UrlShortener: Exception: .agora-field-styling is undefined: failed at `.agora-field-styling();` - 10https://bugzilla.wikimedia.org/68634#c9 (10Kunal Mehta (Legoktm)) Thanks :) [00:31:24] 3MediaWiki / 3Database: Installer should add a comment to LocalSettings.php urging that database settings be moved out of webroot - 10https://bugzilla.wikimedia.org/68777 (10Nathan Larson) 3NEW p:3Unprio s:3enhanc a:3None Currently, the installer just adds, e.g. ## Database settings $wgDBtype = "mys... [00:31:51] 3MediaWiki / 3Installer: Installer should add a comment to LocalSettings.php urging that database settings be moved out of webroot - 10https://bugzilla.wikimedia.org/68777 (10Nathan Larson) p:5Unprio>3Lowest [00:32:35] (03PS1) 10Mwalker: Updating to masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/150100 [00:33:30] (03Abandoned) 10Legoktm: Maintenance script to salt existing unsalted passwords [core] - 10https://gerrit.wikimedia.org/r/104487 (https://bugzilla.wikimedia.org/59114) (owner: 10Legoktm) [00:34:15] (03CR) 10Mwalker: [C: 032 V: 032] Updating to masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/150100 (owner: 10Mwalker) [00:34:49] (03PS1) 10Mwalker: Updating to masters [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/150102 [00:34:56] (03CR) 10Mwalker: [C: 032 V: 032] Updating to masters [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/150102 (owner: 10Mwalker) [00:35:33] (03CR) 10Prtksxna: [C: 032 V: 032] Content and Style changes [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/149199 (owner: 10MSyed) [00:39:17] (03PS1) 10Aaron Schulz: Set "has value" flag correctly for result parameter [core] - 10https://gerrit.wikimedia.org/r/150106 [00:39:55] (03CR) 10Aaron Schulz: [C: 032] Added support for result=json parameter to runJobs.php [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150098 (owner: 10Aaron Schulz) [00:40:31] (03CR) 10MaxSem: [C: 032] Fix is cached template and rerender handling [extensions/Collection] - 10https://gerrit.wikimedia.org/r/149265 (owner: 10Mwalker) [00:40:47] (03Merged) 10jenkins-bot: Fix is cached template and rerender handling [extensions/Collection] - 10https://gerrit.wikimedia.org/r/149265 (owner: 10Mwalker) [00:41:28] thanks max! [00:42:35] (03Merged) 10jenkins-bot: Added support for result=json parameter to runJobs.php [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150098 (owner: 10Aaron Schulz) [00:43:08] (03CR) 10Spage: [C: 031] "Works and the watchlist star is constructive green." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148724 (https://bugzilla.wikimedia.org/68456) (owner: 10Jdlrobson) [00:43:36] (03PS13) 10Ebe123: Create preference to watchlist pages after rollbacking [core] - 10https://gerrit.wikimedia.org/r/146440 (https://bugzilla.wikimedia.org/4488) [00:44:53] yay, test wikis :) [00:47:02] (03CR) 10EBernhardson: "I reverted this previously, for the reasons bsitu stated above. Basically we want this refactor but it caused a bug which we didn't know " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145749 (owner: 10EBernhardson) [00:47:52] (03PS2) 10Prtksxna: Changed tooltip to show tooltip on hover of entire bar [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/150029 (owner: 10MSyed) [00:48:29] (03CR) 10EBernhardson: "early CR :S Anyways this patch would solve the issue we had a week ago on beta, where a commit failed but one key was still written to me" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145749 (owner: 10EBernhardson) [00:48:36] (03CR) 10Prtksxna: [C: 032 V: 032] Changed tooltip to show tooltip on hover of entire bar [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/150029 (owner: 10MSyed) [00:51:22] (03PS2) 10Prtksxna: Content and style changes [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/150030 (owner: 10MSyed) [00:52:25] (03CR) 10Prtksxna: [C: 032 V: 032] Content and style changes [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/150030 (owner: 10MSyed) [00:54:04] (03PS1) 10Aaron Schulz: Log errors when several callbacks give exceptions in onTransaction* methods [core] - 10https://gerrit.wikimedia.org/r/150110 [00:55:48] (03CR) 10Reedy: "Not really sure where I should bring this up..." [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/150030 (owner: 10MSyed) [00:56:00] hi, I'm trying to start up a mediawiki-vagrant which has worked before, and it's giving me a giant error message, something about "could not start Service[jobrunner]". [00:56:35] any suggestions? [01:01:37] (03CR) 10EBernhardson: [C: 031] "makes sense, appears to work" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148726 (owner: 10Jdlrobson) [01:02:51] (03PS5) 10EBernhardson: Hygiene: Add suitable default styles for ul elements in Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148530 (owner: 10Jdlrobson) [01:04:40] (03CR) 10Werdna: Move watch star for boards next to the header. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149210 (owner: 10Werdna) [01:05:33] response to "vagrant up" included: "Error: Could not start Service[jobrunner]: Execution of '/sbin/start jobrunner' returned 1: Error: /Stage[main]/Mediawiki::Jobrunner/Service[jobrunner]/ensure: change from stopped to running failed: Could not start Service[jobrunner]: Execution of '/sb in/start jobrunner' returned 1:" [01:06:58] (03CR) 10EBernhardson: [C: 032] "deduplication++" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148530 (owner: 10Jdlrobson) [01:07:31] (03Merged) 10jenkins-bot: Hygiene: Add suitable default styles for ul elements in Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148530 (owner: 10Jdlrobson) [01:07:38] (03PS1) 10Spage: Load ext.flow.mediawiki.ui.buttons module [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150112 (https://bugzilla.wikimedia.org/68706) [01:09:21] (03PS5) 10EBernhardson: QA: Add browser test which ensures anonymous users do not see deleted posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145162 (owner: 10Jdlrobson) [01:13:36] (03PS1) 10Gergő Tisza: Enable CORS for commons role [vagrant] - 10https://gerrit.wikimedia.org/r/150114 [01:15:48] (03CR) 10Gergő Tisza: "CORS headers added in I7b4eec4e28925760ed3e8e448fb4b99bb63f13e3" [vagrant] - 10https://gerrit.wikimedia.org/r/147151 (owner: 10Gilles) [01:18:47] (03CR) 10EBernhardson: [C: 04-1] "The 'And I am anonymous' stage doesn't log me out" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145162 (owner: 10Jdlrobson) [01:19:32] (03PS1) 10MSyed: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/TransparencyReport [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/150115 [01:19:42] (03PS1) 10Aaron Schulz: Unbreak Special:WhatLinksHere for $wgUseLinkNamespaceDBFields=false [core] - 10https://gerrit.wikimedia.org/r/150116 [01:20:26] (03PS1) 10Aaron Schulz: Unbreak Special:WhatLinksHere for $wgUseLinkNamespaceDBFields=false [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150117 [01:20:28] (03PS2) 10Gergő Tisza: Enable CORS for commons role [vagrant] - 10https://gerrit.wikimedia.org/r/150114 [01:24:39] (03CR) 10EBernhardson: [C: 04-1] "generally looks correct, but now the error-box where javascript inserts load more errors is inside the fallback div, so it will never be s" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145470 (owner: 10Jdlrobson) [01:25:25] (03CR) 10Neilk: "Is there a way to break out some of these changes into smaller changes? Removing UploadWizardUtil or moving its functionality around is a " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [01:26:54] (03PS3) 10EBernhardson: QA: Update browser tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150073 (owner: 10Jdlrobson) [01:27:17] Reedy: Hey [01:27:41] Hey [01:28:25] Reedy: Hey Sam [01:28:59] Reedy: just saw your comment on Transparency Report [01:29:35] Reedy: The legal team has sent the content for translation [01:29:40] Reedy: we're planning to do the translations, they will also be pushed soon [01:29:46] Reedy: Once the content is frozen we [01:29:47] aha, great :) [01:29:55] Reedy: We'll move everything to a strings file and use that [01:30:03] Just wanted to make sure it was on your radar [01:30:11] I could see it going live and there being a lot of unhappy community [01:30:21] you can send it to translatewiki [01:30:40] I guess it'll be that or via Translate on meta...? [01:30:51] +1, i'd also expect them to ask for that right away [01:30:53] The first would probably be btter [01:31:38] (03PS1) 10Prtksxna: Minor style changes [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/150118 [01:31:40] (03Abandoned) 10Prtksxna: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/TransparencyReport [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/150115 (owner: 10MSyed) [01:32:40] (03CR) 10MSyed: [C: 032 V: 032] Minor style changes [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/150118 (owner: 10Prtksxna) [01:32:55] mutante: It'll be on translate wiki too. But for the languages on the microsite the legal team needs professional translations [01:33:33] mutante: There'll be an on-wiki version that'll be up for translations into several languages whereas the micro site will have only 2-3 [01:33:42] Reedy: ^ [01:34:04] (03PS3) 10Gergő Tisza: Enable CORS for commons role [vagrant] - 10https://gerrit.wikimedia.org/r/150114 [01:34:42] legoktm: if you have time do you think you could test something on your wiki for me [01:35:58] (03PS1) 10Prtksxna: Typo fix [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/150119 [01:36:18] (03CR) 10MSyed: [C: 032 V: 032] Typo fix [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/150119 (owner: 10Prtksxna) [01:36:48] prtksxna: gotcha [01:41:51] 3Wikimedia / 3Extension setup: Activate File Upload Wizard in ta.wikipedia - 10https://bugzilla.wikimedia.org/68723#c5 (10Anton) Can we have [[:en:Wikipedia:File Upload Wizard]]? It has nice wizard than Commons. [01:56:55] (03CR) 10Jdlrobson: [C: 04-2] "No.. we're deprecating this. This was the whole point of moving to mediawiki.ui.buttons" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150112 (https://bugzilla.wikimedia.org/68706) (owner: 10Spage) [01:57:13] withoutaname: maybe? [02:01:14] (03PS37) 10Neilk: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [02:01:19] (03PS1) 10Mwalker: Do not crash on empty chapter metabook [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/150121 [02:01:45] (03CR) 10jenkins-bot: [V: 04-1] Do not crash on empty chapter metabook [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/150121 (owner: 10Mwalker) [02:01:48] (03CR) 10Mwalker: [C: 032] Do not crash on empty chapter metabook [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/150121 (owner: 10Mwalker) [02:02:04] (03CR) 10jenkins-bot: [V: 04-1] Do not crash on empty chapter metabook [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/150121 (owner: 10Mwalker) [02:02:59] (03PS2) 10Mwalker: Do not crash on empty chapter metabook [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/150121 [02:03:09] (03CR) 10Mwalker: [C: 032] Do not crash on empty chapter metabook [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/150121 (owner: 10Mwalker) [02:03:25] (03Merged) 10jenkins-bot: Do not crash on empty chapter metabook [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/150121 (owner: 10Mwalker) [02:06:20] (03CR) 10Neilk: "There are a couple of things wrong here. If you add exactly one Flickr upload, there are *three* uploads in UploadWizardUploadList." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [02:08:34] legoktm: oh thanks, can I send you a paste of the code [02:12:30] (03PS1) 10MSyed: Increased gutter size [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/150122 [02:13:41] (03PS1) 10MSyed: Container to 0 [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/150123 [02:15:04] (03CR) 10Prtksxna: [C: 032 V: 032] Container to 0 [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/150123 (owner: 10MSyed) [02:28:27] (03CR) 10Ori.livneh: [C: 032] Unbreak Special:WhatLinksHere for $wgUseLinkNamespaceDBFields=false [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150117 (owner: 10Aaron Schulz) [02:32:00] (03Merged) 10jenkins-bot: Unbreak Special:WhatLinksHere for $wgUseLinkNamespaceDBFields=false [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150117 (owner: 10Aaron Schulz) [02:37:21] (03CR) 10Legoktm: [C: 04-1] "Yeah, ugh. I can't think of a good way to do this without using JavaScript." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/133419 (https://bugzilla.wikimedia.org/65315) (owner: 10Legoktm) [02:44:05] (03CR) 10EBernhardson: [C: 032] QA: Update browser tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150073 (owner: 10Jdlrobson) [02:44:40] (03Merged) 10jenkins-bot: QA: Update browser tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150073 (owner: 10Jdlrobson) [02:48:57] (03PS1) 10Mattflaschen: Clarify comment in UploadBase [core] - 10https://gerrit.wikimedia.org/r/150125 [02:50:23] 3MediaWiki / 3Maintenance scripts: Maintenance script to convert from unsalted (:A:) to salted passwords (:B:) - 10https://bugzilla.wikimedia.org/59114 (10Tyler Romeo) 5PATC>3RESO/FIX [02:50:36] (03PS5) 10BryanDavis: Rethink multiwiki support [vagrant] - 10https://gerrit.wikimedia.org/r/149872 (https://bugzilla.wikimedia.org/68605) [02:50:55] (03CR) 10Mattflaschen: "Per Rillke's feedback at https://github.com/wikimedia/mediawiki-core/commit/42333412833ab7f7515e193b83a909921c34887d#commitcomment-7133547" [core] - 10https://gerrit.wikimedia.org/r/150125 (owner: 10Mattflaschen) [02:52:00] (03PS38) 10Neilk: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [02:53:31] (03CR) 10Jforrester: "JS isn't the end of the world; a JS-only feature that falls back to the top of the page is enough of a fix for this bug." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/133419 (https://bugzilla.wikimedia.org/65315) (owner: 10Legoktm) [02:54:43] (03CR) 10Neilk: "The details step was failing because the title from Flickr was never tested for validity. I'm not sure why it worked this way -- it could " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [02:56:18] (03CR) 10Legoktm: "Few more places where 1.23 was used." (035 comments) [core] - 10https://gerrit.wikimedia.org/r/77645 (https://bugzilla.wikimedia.org/54948) (owner: 10Parent5446) [03:10:43] (03CR) 10Legoktm: Add support for enabling and displaying global interwikis (032 comments) [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147755 (https://bugzilla.wikimedia.org/68241) (owner: 10Isarra) [03:14:55] 3Wikimedia / 3Deployment systems: [scap] UnicodeDecodeError: 'ascii' codec can't decode byte - 10https://bugzilla.wikimedia.org/68780 (10Bryan Davis) 3NEW p:3Unprio s:3normal a:3None Reported by Araron when running `sync-file php-1.24wmf15/includes/specials/SpecialWhatlinkshere.php` [0] : 02:38:33 F... [03:18:39] 3Wikimedia / 3Deployment systems: [scap] "UnicodeDecodeError: 'ascii' codec can't decode byte" when announcing sync result to irc - 10https://bugzilla.wikimedia.org/68780 (10Bryan Davis) p:5Unprio>3Normal [03:19:30] (03PS2) 10EBernhardson: Fix collapsing via topics collapsing button [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150089 (https://bugzilla.wikimedia.org/68773) (owner: 10Jdlrobson) [03:22:25] 3Wikimedia / 3General/Unknown: Incorrect use of Russian translation on a Ukranian when there is a Ukranian translation available - 10https://bugzilla.wikimedia.org/68781 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None This is an apparent separate bug discovered in the course of bug 67805. Nikl... [03:22:54] 3Wikimedia / 3General/Unknown: Incorrect use of Russian translation on a Ukranian when there is a Ukranian translation available - 10https://bugzilla.wikimedia.org/68781 (10Matthew Flaschen) [03:22:54] 3Wikimedia / 3General/Unknown: Local versions of system messages are ignored - 10https://bugzilla.wikimedia.org/67805 (10Matthew Flaschen) [03:23:21] 3Wikimedia / 3General/Unknown: Local versions of system messages are ignored - 10https://bugzilla.wikimedia.org/67805#c37 (10Matthew Flaschen) (In reply to Andre Klapper from comment #36) > (In reply to Andre Klapper from comment #35) > > NickK: Is this still a problem on Ukrainian Wikimedia sites? > > And... [03:24:06] 3Wikimedia / 3General/Unknown: Incorrect use of Russian translation on a Ukranian wiki when there is a Ukranian translation available - 10https://bugzilla.wikimedia.org/68781 (10Matthew Flaschen) [03:24:49] (03CR) 10EBernhardson: [C: 031] "the rest of the file puts the dots at the begining of a line, rather than the end" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150089 (https://bugzilla.wikimedia.org/68773) (owner: 10Jdlrobson) [03:24:51] 3Wikimedia / 3Deployment systems: [scap] "UnicodeDecodeError: 'ascii' codec can't decode byte" when announcing sync result to irc - 10https://bugzilla.wikimedia.org/68780#c1 (10Bryan Davis) Aaron clarified that the command he ran was literally `sync-file php-1.24wmf15/includes/specials/SpecialWhatlinkshere.p... [03:27:38] 3MediaWiki extensions / 3CirrusSearch: Almost no results for searchs in JS pages - 10https://bugzilla.wikimedia.org/68782 (10Helder) 3NEW p:3Unprio s:3normal a:3None LuceneSearch: Results 1 - 20 of 91 for api intitle:js https://pt.wikipedia.org/w/index.php?title=Especial%3APesquisar&profile=advanced&... [03:38:45] (03CR) 10Mattflaschen: "I haven't reviewed this, and I don't know if there are benefits such that we should consider upgrading." [core] - 10https://gerrit.wikimedia.org/r/139699 (owner: 10Paladox) [03:45:55] 3MediaWiki / 3Search: Results 21 - 20 of 1 for - 10https://bugzilla.wikimedia.org/68783 (10Helder) 3NEW p:3Unprio s:3normal a:3None This is very wrong: "Results 21 - 20 of 1 for api intitle:js" https://pt.wikipedia.org/w/index.php?title=Especial:Pesquisar&limit=20&offset=20&ns2=1&search... [03:49:23] 3MediaWiki / 3Search: last search results page contains next page link if result count is multiple of limit - 10https://bugzilla.wikimedia.org/19938 (10Helder) [03:49:23] 3MediaWiki / 3Search: Results 21 - 20 of 1 for - 10https://bugzilla.wikimedia.org/68783 (10Helder) [03:49:52] 3MediaWiki / 3Search: Wrong number of search results - 10https://bugzilla.wikimedia.org/67731 (10Helder) [03:49:52] 3MediaWiki / 3Search: Results 21 - 20 of 1 for - 10https://bugzilla.wikimedia.org/68783 (10Helder) [03:54:02] (03PS6) 10BryanDavis: Rethink multiwiki support [vagrant] - 10https://gerrit.wikimedia.org/r/149872 (https://bugzilla.wikimedia.org/68605) [04:06:37] (03CR) 10TTO: [C: 031] Throw exception in importDump instead of dumping a random backtrace and erroring [core] - 10https://gerrit.wikimedia.org/r/148915 (owner: 10Chad) [04:08:18] (03CR) 10TTO: "Can someone abandon this? I haven't got a clue what it is." [core] - 10https://gerrit.wikimedia.org/r/111289 (owner: 10Adi.iiita) [04:10:56] (03PS1) 10Legoktm: Refactor backend logic out of special page [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/150128 [04:15:04] (03CR) 10Dzahn: "https://bugzilla.wikimedia.org/show_bug.cgi?id=11269" [core] - 10https://gerrit.wikimedia.org/r/111289 (owner: 10Adi.iiita) [04:20:33] (03PS1) 10Brian Wolff: Add Special:MediaStatistics page for file type stats [core] - 10https://gerrit.wikimedia.org/r/150131 [04:20:45] (03CR) 10BryanDavis: "Tested by building a fresh vm:" [vagrant] - 10https://gerrit.wikimedia.org/r/149872 (https://bugzilla.wikimedia.org/68605) (owner: 10BryanDavis) [04:22:37] 3Wikimedia / 3Extension setup: Activate File Upload Wizard in ta.wikipedia - 10https://bugzilla.wikimedia.org/68723#c6 (10Bawolff (Brian Wolff)) (In reply to Anton from comment #5) > Can we have [[:en:Wikipedia:File Upload Wizard]]? It has nice wizard than > Commons. You can have it, this is just the wrong... [04:25:04] (03PS3) 10Brian Wolff: Relax filter attribute filtering to allow self-referential urls [core] - 10https://gerrit.wikimedia.org/r/150048 (https://bugzilla.wikimedia.org/67044) [04:25:20] (03CR) 10Brian Wolff: "Ok, removing the "DO NOT MERGE" on that basis." [core] - 10https://gerrit.wikimedia.org/r/150048 (https://bugzilla.wikimedia.org/67044) (owner: 10Brian Wolff) [04:26:56] (03PS12) 10Legoktm: Global merge tool [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) [04:26:59] (03CR) 10jenkins-bot: [V: 04-1] Global merge tool [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) (owner: 10Legoktm) [04:27:11] (03PS4) 10EBernhardson: Pass metadata array for ObjectManager listeners [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150064 [04:27:19] (03PS2) 10EBernhardson: Newly created topics display as unwatched [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150083 [04:27:51] (03CR) 10Legoktm: "PS12: No longer add local log entries, requires I2bfcecad9994abaf8c58ec1ba0e02bc33309cf72 in UserMerge." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) (owner: 10Legoktm) [04:28:20] (03PS3) 10EBernhardson: Fix newly created topics display as unwatched [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150083 [04:31:36] 3Wikimedia / 3Extension setup: Activate File Upload Wizard in ta.wikipedia - 10https://bugzilla.wikimedia.org/68723#c7 (10Anton) Yes, I have copied all related scripts. Would you guide me where I can request? Or, I can follow if you can ask in right place for us. Thanks. [04:38:07] 3Wikimedia / 3Extension setup: Activate File Upload Wizard in ta.wikipedia - 10https://bugzilla.wikimedia.org/68723#c8 (10Bawolff (Brian Wolff)) There's no person to request it from. This is something that enwikipedia admins just did by themselves. Any admin on ta.wikipedia can create the needed pages in the... [04:41:07] 3MediaWiki-Vagrant: Add VARNISH role - 10https://bugzilla.wikimedia.org/52302#c5 (10Bryan Davis) 5PATC>3NEW p:5Unprio>3Normal s:5normal>3enhanc Patch was abandoned. [04:41:51] 3MediaWiki-Vagrant: browsertests: Error: Working directory '/srv/browsertests/tests/browser' does not exist (and others) - 10https://bugzilla.wikimedia.org/68625 (10Bryan Davis) 5PATC>3RESO/FIX [04:46:06] (03PS13) 10Legoktm: Global merge tool [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) [04:46:16] (03CR) 10jenkins-bot: [V: 04-1] Global merge tool [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) (owner: 10Legoktm) [04:46:27] wat [04:47:13] (03CR) 10Legoktm: "Test failures are unrelated (Use of User::crypt was deprecated in MediaWiki 1.23)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) (owner: 10Legoktm) [04:49:37] 3MediaWiki extensions / 3CentralAuth: CentralAuth tests are failing - 10https://bugzilla.wikimedia.org/68784 (10Kunal Mehta (Legoktm)) p:5Unprio>3High [04:49:39] 3MediaWiki extensions / 3CentralAuth: CentralAuth tests are failing - 10https://bugzilla.wikimedia.org/68784 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None https://integration.wikimedia.org/ci/job/mwext-CentralAuth-testextensions-master/191/console 04:46:15 1) CentralAuthHooksUsingDataba... [04:50:09] 3MediaWiki-Vagrant: Jobrunner configuration incompatible with current jobrunner php code - 10https://bugzilla.wikimedia.org/68785 (10Bryan Davis) 3NEW p:3Unprio s:3critic a:3Ori Livneh Jobrunner service fails to start with: Fatal error: Uncaught exception 'Exception' with message 'Could not parse JSON... [04:50:36] 3MediaWiki-Vagrant: Jobrunner configuration incompatible with current jobrunner php code - 10https://bugzilla.wikimedia.org/68785 (10Bryan Davis) p:5Unprio>3High [04:51:19] bd808: thanks, but -- "critical"? really? [04:51:39] "normal" or "major" not cutting it for you? ;) [04:56:35] no scrypt? [05:00:17] (03PS1) 10Legoktm: Stop using deprecated User::comparePasswords/User::crypt [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/150138 (https://bugzilla.wikimedia.org/68784) [05:00:26] (03CR) 10jenkins-bot: [V: 04-1] Stop using deprecated User::comparePasswords/User::crypt [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/150138 (https://bugzilla.wikimedia.org/68784) (owner: 10Legoktm) [05:01:12] 3MediaWiki / 3Database: DatabaseUpdater::modifyField() does insertUpdateRow() before applyPatch() - 10https://bugzilla.wikimedia.org/68786 (10Nathan Larson) 3NEW p:3Unprio s:3normal a:3None DatabaseUpdater::modifyField() does insertUpdateRow() before applyPatch(). As a result, if there's a database e... [05:03:19] (03PS2) 10Legoktm: Stop using deprecated User::comparePasswords/User::crypt [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/150138 (https://bugzilla.wikimedia.org/68784) [05:04:25] (03CR) 10Legoktm: "I have no clue what I'm doing here, I just need the tests to stop failing." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/150138 (https://bugzilla.wikimedia.org/68784) (owner: 10Legoktm) [05:04:43] (03PS4) 10Werdna: Move watch star for boards next to the header. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149210 [05:05:06] 3MediaWiki extensions / 3CentralAuth: CentralAuth tests are failing - 10https://bugzilla.wikimedia.org/68784#c2 (10Kunal Mehta (Legoktm)) Other option is to remove the wfDeprecated calls from those two functions until CentralAuth is updated accordingly. [05:07:11] (03PS1) 10EBernhardson: Hygine: rename title-post to topic-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150140 [05:07:14] (03PS1) 10EBernhardson: [WIP] Move notification creation to event listener [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150141 [05:07:37] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Move notification creation to event listener [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150141 (owner: 10EBernhardson) [05:09:16] (03CR) 10Werdna: "Mmm, well, I guess technically, we could actually use Echo's as-yet-unused echo_subscription table to subscribe to these events." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [05:09:51] 3MediaWiki / 3Page editing: Hide signature button from edit toolbar in main namespace - 10https://bugzilla.wikimedia.org/5645#c20 (10George Orwell III) I'd propose there is a 4th option; it being the setting of the existing filter. Just add 'filters': [ 'body.ns-talk' ], ... to the 'signature' but... [05:10:55] (03CR) 10Legoktm: "This is needed for the global user merge tool." [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/150128 (owner: 10Legoktm) [05:17:12] (03PS1) 10MSyed: An image for story, retina and non retina [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/150142 [05:17:17] (03PS1) 10Legoktm: Documentation updates for Password API-related changes [core] - 10https://gerrit.wikimedia.org/r/150143 [05:17:22] (03CR) 10EBernhardson: "Rather i think jon means we want the ability of a function called by EchoGetDefaultNotifiedUsers to also(instead of?) be able to specify a" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [05:17:28] (03PS2) 10Legoktm: Documentation fixes for Password API-related changes [core] - 10https://gerrit.wikimedia.org/r/150143 [05:21:21] 3MediaWiki extensions / 3TwoFactorAuthentication: PHP Notice: Did not find alias for special page 'TwoFactorAuth' - 10https://bugzilla.wikimedia.org/68698#c1 (10Nemo) Thanks Alex for https://gerrit.wikimedia.org/r/#/c/149848/ / 62f53803b7c8c2ed4f677a2d039ab507db705390 [05:21:38] 3MediaWiki extensions / 3[other]: [TimezoneSelector] Notice: Did not find alias for special page 'TimezoneSelector'. Perhaps no aliases are defined for it? - 10https://bugzilla.wikimedia.org/68787 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Notice: Did not find alias for special page 'TimezoneSelector'... [05:40:51] 3MediaWiki / 3Page editing: Hide signature button from edit toolbar in main namespace - 10https://bugzilla.wikimedia.org/5645#c21 (10Nemo) George Orwell III, that's TTO's second option. [05:41:08] I replied at https://www.mediawiki.org/wiki/Talk:Data_%26_Developer_Hub#General_comments [05:43:47] (03CR) 10Mattflaschen: "This is also what was done (by Krinkle) for E3Experiments (I realize that extension is unlikely to have much/any third-party use) (https:/" [extensions/OggHandler] - 10https://gerrit.wikimedia.org/r/149465 (owner: 10Mattflaschen) [05:43:58] (03PS1) 10Ori.livneh: Optimize images [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/150146 [05:44:22] (03CR) 10Nemo bis: "Bug 68750 for the removal from extensions." [core] - 10https://gerrit.wikimedia.org/r/141906 (owner: 10Withoutaname) [05:45:28] (03CR) 10Ori.livneh: [C: 032] Enable CORS for commons role [vagrant] - 10https://gerrit.wikimedia.org/r/150114 (owner: 10Gergő Tisza) [05:45:34] (03Merged) 10jenkins-bot: Enable CORS for commons role [vagrant] - 10https://gerrit.wikimedia.org/r/150114 (owner: 10Gergő Tisza) [05:49:39] (03PS2) 10EBernhardson: [WIP] Move notification creation to event listener [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150141 [05:49:54] 3MediaWiki / 3User login and signup: Create account button overlaps with CAPTCHA container - 10https://bugzilla.wikimedia.org/68788 (10Steven Walling) 3NEW p:3Unprio s:3normal a:3None Created attachment 16076 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16076&action=edit English The CAPTCH... [05:50:04] ori: its safe to delete https://github.com/wikimedia/mediawiki-core-vendor-swiftmailer/tree/5.2.0-patch as we have shifted our repo to the original swiftmailer/swiftmailer for the new extension. [05:50:07] 3MediaWiki / 3User login and signup: Create account button overlaps with CAPTCHA container - 10https://bugzilla.wikimedia.org/68788#c1 (10Steven Walling) Created attachment 16077 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16077&action=edit Deutsch [05:50:17] ori: should I request it somewhere ? [05:50:37] 3MediaWiki / 3User login and signup: Create account button overlaps with CAPTCHA container - 10https://bugzilla.wikimedia.org/68788#c2 (10Steven Walling) Created attachment 16078 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16078&action=edit Français [05:51:42] 3MediaWiki / 3User login and signup: Create account button overlaps with CAPTCHA container - 10https://bugzilla.wikimedia.org/68788 (10Steven Walling) p:5Unprio>3Low [05:51:42] 3MediaWiki / 3User login and signup: Create account button overlaps with CAPTCHA container - 10https://bugzilla.wikimedia.org/68788 (10Steven Walling) [05:51:42] 3MediaWiki / 3User login and signup: Create account button overlaps with CAPTCHA container - 10https://bugzilla.wikimedia.org/68788 (10Steven Walling) s:5normal>3minor [05:54:30] tonythomas: i'm not sure, to be honest [05:54:38] there's probably something on mediawiki.org about it [05:57:45] ori: ok. I will check that out. I think bd808 was telling to remove the repo last day in #mediawiki-core. [06:00:07] (03CR) 10Robert Vogel: [C: 031 V: 031] [WIP] Refactoring of some parts of ExtendedSearch (034 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148972 (owner: 10Smuggli) [06:02:00] (03CR) 10Mattflaschen: [C: 04-2] "> Yes, it makes sense to check-in the SVG file so that others > can edit in the software they like." [core] - 10https://gerrit.wikimedia.org/r/137888 (https://bugzilla.wikimedia.org/66138) (owner: 10Prtksxna) [06:04:22] 3MediaWiki / 3Page editing: Hide signature button from edit toolbar in main namespace - 10https://bugzilla.wikimedia.org/5645#c22 (10George Orwell III) Really? The 'filter' setting is built in; it just needs to be added then set in the mentioned .js file. How is that the same as the proposed "current patch... [06:07:56] (03PS1) 10Withoutaname: Remove deprecated calls to wfMsg and updated SecurePoll special pages [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/150149 [06:08:46] (03PS4) 10Nemo bis: Bring PageNotice extension into the modern era [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105141 (owner: 10TTO) [06:12:06] (03CR) 10Nemo bis: Remove deprecated wfMsg calls (031 comment) [extensions/Quantcast] - 10https://gerrit.wikimedia.org/r/150019 (https://bugzilla.wikimedia.org/68750) (owner: 10Withoutaname) [06:13:22] 3MediaWiki / 3Page editing: Hide signature button from edit toolbar in main namespace - 10https://bugzilla.wikimedia.org/5645#c23 (10George Orwell III) amending Comment #22, the 2nd paragraph should have read.... How is that the same as the proposed "current patch implementation" (the '2nd option' or rough... [06:14:59] (03CR) 10Withoutaname: Remove deprecated wfMsg calls (031 comment) [extensions/Quantcast] - 10https://gerrit.wikimedia.org/r/150019 (https://bugzilla.wikimedia.org/68750) (owner: 10Withoutaname) [06:15:03] (03CR) 10Deepali: Import external metadata from wikidata (032 comments) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/149654 (https://bugzilla.wikimedia.org/51971) (owner: 10Deepali) [06:16:36] 3MediaWiki / 3Unit tests: phpunit failure: ParserTests::testParserTest for gallery and files with UploadWizard and data-file-* - 10https://bugzilla.wikimedia.org/68649#c3 (10Nemo) Of course there is even more if one enables non-Wikimedia extensions, for instance data-bs-title attribute like (03PS4) 10Nemo bis: Update for code issues and usability [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/120476 (owner: 10MarkAHershberger) [06:20:53] (03PS4) 10Deepali: Import external metadata from Wikidata [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/149654 (https://bugzilla.wikimedia.org/51971) [06:21:07] (03CR) 10jenkins-bot: [V: 04-1] Import external metadata from Wikidata [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/149654 (https://bugzilla.wikimedia.org/51971) (owner: 10Deepali) [06:25:54] (03PS1) 10Robert Vogel: [RFC] User init & user rights overrides in BSF [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/150150 [06:28:13] (03CR) 10Mattflaschen: "recheck" [core] - 10https://gerrit.wikimedia.org/r/141293 (https://bugzilla.wikimedia.org/29908) (owner: 10TheDJ) [06:28:45] @seen dantman [06:28:45] liangent: Last time I saw dantman they were quitting the network with reason: Quit: Linkinus - http://linkinus.com N/A at 6/25/2014 9:16:14 PM (33d9h12m30s ago) [06:28:57] @seen Dantman [06:28:57] liangent: Last time I saw Dantman they were quitting the network with reason: Quit: Linkinus - http://linkinus.com N/A at 6/25/2014 9:16:14 PM (33d9h12m42s ago) [06:29:15] @seen DanielFriesen [06:29:15] liangent: Last time I saw DanielFriesen they were changing the nickname to , but is no longer in channel #wikimedia-office at 6/18/2014 10:04:25 PM (40d8h24m50s ago) [06:30:46] (03PS1) 10Robert Vogel: BSF: New API base class for use with ExtJS stores [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/150151 [06:33:08] (03CR) 10Robert Vogel: "Please have a look at https://gerrit.wikimedia.org/r/#/c/150151/." (032 comments) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/149845 (owner: 10Pwirth) [06:35:47] (03CR) 10Robert Vogel: [RFC] User init & user rights overrides in BSF (031 comment) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/150150 (owner: 10Robert Vogel) [06:36:24] (03PS14) 10Florianschmidtwelzow: Create preference to watchlist pages after rollbacking [core] - 10https://gerrit.wikimedia.org/r/146440 (https://bugzilla.wikimedia.org/4488) (owner: 10Ebe123) [06:43:25] (03CR) 10Florianschmidtwelzow: [C: 031] Remove deprecated wfMsg calls [extensions/Quantcast] - 10https://gerrit.wikimedia.org/r/150019 (https://bugzilla.wikimedia.org/68750) (owner: 10Withoutaname) [06:44:57] (03PS1) 10Florianschmidtwelzow: Fix some wfMsg* [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/150152 (https://bugzilla.wikimedia.org/68750) [06:44:59] (03CR) 10jenkins-bot: [V: 04-1] Fix some wfMsg* [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/150152 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [06:45:46] (03PS1) 10Florianschmidtwelzow: Fix some wfMsg* [extensions/JSBreadCrumbs] - 10https://gerrit.wikimedia.org/r/150153 (https://bugzilla.wikimedia.org/68750) [06:46:48] (03PS1) 10Florianschmidtwelzow: Fix some wfMsg* [extensions/OnlineStatus] - 10https://gerrit.wikimedia.org/r/150154 (https://bugzilla.wikimedia.org/68750) [06:47:34] (03PS1) 10Florianschmidtwelzow: Fix some wfMsg* [extensions/WhitelistPages] - 10https://gerrit.wikimedia.org/r/150155 (https://bugzilla.wikimedia.org/68750) [06:48:50] (03CR) 10Mattflaschen: Add mw-ui-input to mediawiki ui (031 comment) [core] - 10https://gerrit.wikimedia.org/r/149173 (owner: 10Jdlrobson) [06:49:21] (03PS2) 10Florianschmidtwelzow: Fix some wfMsg* [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/150152 (https://bugzilla.wikimedia.org/68750) [06:56:42] (03CR) 10Mattflaschen: [C: 032] Add mw-ui-input to mediawiki ui [core] - 10https://gerrit.wikimedia.org/r/149173 (owner: 10Jdlrobson) [06:59:34] (03Merged) 10jenkins-bot: Add mw-ui-input to mediawiki ui [core] - 10https://gerrit.wikimedia.org/r/149173 (owner: 10Jdlrobson) [07:01:53] 3MediaWiki / 3User login and signup: Create account button overlaps with CAPTCHA container - 10https://bugzilla.wikimedia.org/68788#c3 (10Matthew Flaschen) To me, it looks like they're touching, but not overlapping. Is that correct? [07:07:41] (03CR) 10Nemo bis: [C: 031] Fix some wfMsg* (031 comment) [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/150152 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [07:09:59] (03CR) 10Nemo bis: [C: 031] Fix some wfMsg* (031 comment) [extensions/JSBreadCrumbs] - 10https://gerrit.wikimedia.org/r/150153 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [07:10:23] 3MediaWiki / 3User login and signup: Create account button overlaps with CAPTCHA container - 10https://bugzilla.wikimedia.org/68788#c4 (10Steven Walling) (In reply to Matthew Flaschen from comment #3) > To me, it looks like they're touching, but not overlapping. Is that correct? Sure. [07:15:31] (03CR) 10Nemo bis: [C: 04-1] Fix some wfMsg* (031 comment) [extensions/WhitelistPages] - 10https://gerrit.wikimedia.org/r/150155 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [07:20:47] (03CR) 10Florianschmidtwelzow: Fix some wfMsg* (031 comment) [extensions/WhitelistPages] - 10https://gerrit.wikimedia.org/r/150155 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [07:22:32] (03CR) 10Florianschmidtwelzow: Fix some wfMsg* (031 comment) [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/150152 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [07:23:08] (03CR) 10Florianschmidtwelzow: Fix some wfMsg* (031 comment) [extensions/JSBreadCrumbs] - 10https://gerrit.wikimedia.org/r/150153 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [07:25:56] (03PS2) 10Florianschmidtwelzow: Fix some wfMsg* [extensions/WhitelistPages] - 10https://gerrit.wikimedia.org/r/150155 (https://bugzilla.wikimedia.org/68750) [07:27:53] (03PS1) 10Withoutaname: Remove deprecated calls to wfMsg and updated BlogPage special pages [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/150157 [07:27:55] (03CR) 10jenkins-bot: [V: 04-1] Remove deprecated calls to wfMsg and updated BlogPage special pages [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/150157 (owner: 10Withoutaname) [07:36:39] (03PS2) 10Withoutaname: Remove deprecated calls to wfMsg and updated BlogPage special pages [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/150157 [07:39:21] (03PS3) 10Withoutaname: Remove deprecated calls to wfMsg and updated BlogPage special pages [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/150157 [07:41:22] 3MediaWiki / 3Page editing: Hide signature button from edit toolbar in main namespace - 10https://bugzilla.wikimedia.org/5645#c24 (10This, that and the other (TTO)) (In reply to George Orwell III from comment #22) > I agree, however, that both approaches might seek to achieve the same > results at the end of... [07:41:39] (03CR) 10Withoutaname: "https://gerrit.wikimedia.org/r/#/c/150157/" [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/150152 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [07:45:11] LOL competition ;) [07:45:49] I *just* saw his patch [07:46:36] :) Maybe decide that one goes from the bottom and the other from the top of the alphabetical order [07:47:13] tbh his will probably be approved, because my patch tends to be large [07:47:54] 3MediaWiki extensions / 3WikiEditor: Unable to remove individual booklet-pages from loading to the toolbar - 10https://bugzilla.wikimedia.org/68791 (10George Orwell III) 3UNCO p:3Unprio s:3major a:3None In an attempt to whittle down the number of language-specific character-sets listed under the 'Spe... [07:52:08] (03PS1) 10Raimond Spekking: Remove dupe message. It belongs to BlueSpiceExtensins/ResponsibleEditors [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/150161 [07:55:48] (03PS5) 10EBernhardson: Pass metadata array for ObjectManager listeners [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150064 [07:55:51] (03PS4) 10EBernhardson: Fix newly created topics display as unwatched [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150083 [07:55:54] (03PS3) 10EBernhardson: [WIP] Move notification creation to event listener [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150141 [07:55:57] (03PS2) 10EBernhardson: Hygine: rename title-post to topic-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150140 [07:56:48] (03CR) 10Florianschmidtwelzow: "Oops :P But i think, yours looks much better (no just the things Nemo posted in the bug), so are you ok, when we use yours? ;)" [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/150152 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [08:02:04] (03CR) 10Withoutaname: "you may, but to be honest I think yours might get approved faster, simply because of the size of my patch and the amount of time it might " [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/150152 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [08:04:07] 3Datasets / 3General/Unknown: Set up generation of JSON dumps for wikidata.org - 10https://bugzilla.wikimedia.org/54369#c22 (10Nemo) 5NEW>3RESO/FIX This is fixed, followups to be filed as https://bugzilla.wikimedia.org/enter_bug.cgi?cc=wikidata-bugs%40lists.wikimedia.org&component=General%2FUnknown&produ... [08:05:08] 3Datasets / 3General/Unknown: Set up generation of JSON dumps for wikidata.org - 10https://bugzilla.wikimedia.org/54369 (10Nemo) [08:05:09] 3Datasets / 3General/Unknown: Wikidata JSON dump: filename prefix - 10https://bugzilla.wikimedia.org/68792 (10Nemo) 3NEW p:3Unprio s:3enhanc a:3Ariel T. Glenn 20140728.json.gz is not very explicative, all the other dumps have some sort of prefix. Something like wikidatawiki-, or even wikidatawiki-ext... [08:09:28] (03PS5) 10EBernhardson: Fix newly created topics display as unwatched [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150083 [08:09:31] (03PS4) 10EBernhardson: [WIP] Move notification creation to event listener [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150141 [08:09:34] (03PS3) 10EBernhardson: Hygine: rename title-post to topic-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150140 [08:10:37] 3Datasets / 3General/Unknown: Set up generation of JSON dumps for wikidata.org - 10https://bugzilla.wikimedia.org/54369 (10Nemo) [08:10:40] 3Datasets / 3General/Unknown: Wikidata JSON dump: better compression than gzip - 10https://bugzilla.wikimedia.org/68793 (10Nemo) 3NEW p:3Unprio s:3normal a:3Ariel T. Glenn I converted 20140721.json.gz to 20140721.json.xz and 20140721.json.bz2; gz is 2.9 GB, the other two were 2.0 GB. Saved space seem... [08:11:06] 3Datasets / 3General/Unknown: Wikidata JSON dump: filename prefix - 10https://bugzilla.wikimedia.org/68792 (10Nemo) p:5Unprio>3Normal [08:11:52] (03CR) 10Robert Vogel: [C: 031 V: 031] Remove dupe message. It belongs to BlueSpiceExtensins/ResponsibleEditors [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/150161 (owner: 10Raimond Spekking) [08:16:45] (03CR) 10Springle: [C: 031] Allow filtering log entries by namespace (Special) [core] - 10https://gerrit.wikimedia.org/r/135284 (owner: 10Jackmcbarn) [08:18:31] (03CR) 10Springle: [C: 031] Add "chemical" major MIME type to the image tables [core] - 10https://gerrit.wikimedia.org/r/135756 (https://bugzilla.wikimedia.org/66412) (owner: 10Rillke) [08:22:08] (03CR) 10Smuggli: [C: 032 V: 032] Remove dupe message. It belongs to BlueSpiceExtensins/ResponsibleEditors [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/150161 (owner: 10Raimond Spekking) [08:25:29] (03CR) 10Florianschmidtwelzow: "Just a view inline comments, but looks great!" (035 comments) [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/150157 (owner: 10Withoutaname) [08:25:56] (03CR) 10Florianschmidtwelzow: "Yeah, i let this patchset here and we see, which get merged :)" [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/150152 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [08:26:23] 3MediaWiki extensions / 3Scribunto: We need a common repository for Scribunto modules and templates - 10https://bugzilla.wikimedia.org/50329#c21 (10Rob Kam) Moved from MediaWiki.org to https://meta.wikimedia.org/wiki/Requests_for_comment/Global_bits_and_pieces and proposed at https://meta.wikimedia.org/wiki/... [08:33:29] (03CR) 10Withoutaname: Remove deprecated calls to wfMsg and updated BlogPage special pages (032 comments) [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/150157 (owner: 10Withoutaname) [08:38:09] (03CR) 10Florianschmidtwelzow: Remove deprecated calls to wfMsg and updated BlogPage special pages (032 comments) [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/150157 (owner: 10Withoutaname) [08:40:08] (03PS27) 10Paladox: Update jquery.chosen folder and files [core] - 10https://gerrit.wikimedia.org/r/139699 [08:42:08] 3MediaWiki / 3Page editing: Hide signature button from edit toolbar in main namespace - 10https://bugzilla.wikimedia.org/5645#c25 (10George Orwell III) (In reply to This, that and the other (TTO) from comment #24) > It may seem that simple to you, but it needs to be possible > for this type of configuration... [08:44:04] (03CR) 10Swidmann: [C: 032 V: 032] [WIP] Refactoring of some parts of ExtendedSearch (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148972 (owner: 10Smuggli) [08:58:05] (03CR) 10Zfilipin: The first job for Math extension (032 comments) [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149323 (https://bugzilla.wikimedia.org/67221) (owner: 10Cmcmahon) [08:58:11] (03PS4) 10Zfilipin: The first job for Math extension [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149323 (https://bugzilla.wikimedia.org/67221) (owner: 10Cmcmahon) [08:58:14] (03PS5) 10Zfilipin: The first job for Math extension [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149323 (https://bugzilla.wikimedia.org/67221) (owner: 10Cmcmahon) [08:58:31] (03PS1) 10Withoutaname: Documentation: Update $wgPasswordDefault and BcryptPassword [core] - 10https://gerrit.wikimedia.org/r/150166 [09:00:19] (03PS1) 10Smuggli: Improved file indexing [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/150167 [09:01:06] 3MediaWiki extensions / 3WikibaseQuery: security review of WikibaseQuery - 10https://bugzilla.wikimedia.org/67533#c2 (10Jeroen De Dauw) As far as I can tell, the offset parameter is limited to 50, and can thus not cause full index scans. Is that wrong? If we would want to allow further pagination, using a c... [09:02:38] (03PS2) 10Smuggli: Improved file indexing [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/150167 [09:06:09] 3MediaWiki extensions / 3WikibaseQuery: security review of WikibaseQuery - 10https://bugzilla.wikimedia.org/67533#c3 (10Sergey Vladimirov) Sorry, i didn't notice the limit in API declaration. In this case... well, it's just unusable from my point of view. But it is not a security concern, of course :-) I ho... [09:08:29] (03PS1) 10Withoutaname: Move PasswordError under includes/password/ file [core] - 10https://gerrit.wikimedia.org/r/150168 [09:13:11] (03CR) 10Swidmann: [C: 031 V: 031] [WIP] BS api base prototype (035 comments) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/149845 (owner: 10Pwirth) [09:23:22] 3MediaWiki / 3Skin and page rendering: Edit toolbar & Edit tools (tracking) - 10https://bugzilla.wikimedia.org/17653 (10George Orwell III) [09:23:24] 3MediaWiki extensions / 3WikiEditor: Unable to remove individual booklet-pages from loading to the toolbar - 10https://bugzilla.wikimedia.org/68791 (10George Orwell III) [09:24:06] 3MediaWiki extensions / 3WikiEditor: Unable to remove individual booklet-pages from loading to the toolbar - 10https://bugzilla.wikimedia.org/68791 (10George Orwell III) [09:24:11] (03CR) 10Swidmann: [WIP] BS api base prototype (031 comment) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/149845 (owner: 10Pwirth) [09:24:22] 3MediaWiki / 3Skin and page rendering: Edit toolbar & Edit tools (tracking) - 10https://bugzilla.wikimedia.org/17653 (10George Orwell III) [09:26:53] if ( $wgDBprefix ) { [09:26:53] return "$wgDBname-$wgDBprefix"; [09:27:05] we invented a prefix that it is a suffix! [09:27:31] because we can, ftw [09:27:38] :-D [09:29:19] (03CR) 10Pwirth: [WIP] BS api base prototype (031 comment) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/149845 (owner: 10Pwirth) [09:32:41] 3MediaWiki / 3Unit tests: wfWikiID() returns different values from test and data provider - 10https://bugzilla.wikimedia.org/68231#c3 (10Antoine "hashar" Musso) Thanks for filling this bug. I have noticed that when running the PHPUnit test suite with the wmf deployed extensions (bug 67216). An example run... [09:36:36] (03Abandoned) 10Phuedx: Add browser tests for the GettingStarted and GuidedTour extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/144456 (owner: 10Phuedx) [09:40:42] (03CR) 10Daniel Kinzler: [C: 032] Add at least one RTL language to the TestSites mock collection [core] - 10https://gerrit.wikimedia.org/r/135569 (owner: 10Thiemo Mättig (WMDE)) [09:44:06] (03Merged) 10jenkins-bot: Add at least one RTL language to the TestSites mock collection [core] - 10https://gerrit.wikimedia.org/r/135569 (owner: 10Thiemo Mättig (WMDE)) [09:44:35] (03PS1) 10Hashar: test: coverage for wfWikiID() [core] - 10https://gerrit.wikimedia.org/r/150169 (https://bugzilla.wikimedia.org/68231) [09:48:08] (03PS1) 10Withoutaname: Remove/deprecate various error functions in OutputPage [core] - 10https://gerrit.wikimedia.org/r/150171 [09:49:25] (03CR) 10Swidmann: [C: 031 V: 031] BSF: New API base class for use with ExtJS stores (033 comments) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/150151 (owner: 10Robert Vogel) [09:49:53] (03CR) 10Swidmann: [WIP] BS api base prototype (031 comment) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/149845 (owner: 10Pwirth) [09:50:23] 3MediaWiki / 3Unit tests: wfWikiID() returns different values from test and data provider - 10https://bugzilla.wikimedia.org/68231#c5 (10Antoine "hashar" Musso) 5PATC>3NEW About the stacktrace: PHPUnit providers are static functions which are evaluated before the test run. So you can not rely on the obj... [09:56:08] (03PS1) 10Phuedx: Enable browser tests for the GettingStarted extension [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/150172 [09:56:58] (03CR) 10Phuedx: [C: 04-2] "This change is blocked on I79d9468e56bc7941c7c5bb27a77d1622bc7d3836." [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/150172 (owner: 10Phuedx) [10:05:56] (03CR) 10Daniel Kinzler: [C: 04-1] "Thought about this some more. Removing this script from Wikibase means 3rd parties cannot use Wikibase with sitelinks, because they have *" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/145764 (https://bugzilla.wikimedia.org/42207) (owner: 10Hoo man) [10:18:12] (03PS1) 10Zfilipin: Deleting all qa/browsertests jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/150174 [10:28:01] (03CR) 10Rillke: [C: 031] "Aha, that way I have to read it. Much better than I9dfc36d2bf55d72d93." [core] - 10https://gerrit.wikimedia.org/r/150125 (owner: 10Mattflaschen) [10:32:31] (03PS1) 10Zfilipin: Running Ruby linter for ArticleFeedbackv5 [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 [10:38:00] (03CR) 10Reedy: [C: 032] "LGTM. Shouldn't break git blame too much either ;)" [tools/release] - 10https://gerrit.wikimedia.org/r/150020 (owner: 10Hashar) [10:38:13] (03Merged) 10jenkins-bot: make-wmf-branch: move class to its own file [tools/release] - 10https://gerrit.wikimedia.org/r/150020 (owner: 10Hashar) [10:41:29] (03PS1) 10Pastakhov: fix object's static properties and constants (v 2.8.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/150178 [10:58:17] (03PS1) 10Zfilipin: Deleted duplicated lines with extension names [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/150179 [11:00:55] (03CR) 10Hashar: [C: 032] "Good cleanup, thanks!" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/150179 (owner: 10Zfilipin) [11:02:08] (03Merged) 10jenkins-bot: Deleted duplicated lines with extension names [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/150179 (owner: 10Zfilipin) [11:11:52] (03PS2) 10Zfilipin: Deleting all qa/browsertests jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/150174 [11:12:27] (03PS3) 10Zfilipin: Deleting all qa/browsertests jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/150174 (https://bugzilla.wikimedia.org/63469) [11:12:56] (03PS2) 10Zfilipin: Running Ruby linter for ArticleFeedbackv5 [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) [11:24:40] 3MediaWiki extensions / 3ProofreadPage: Special:IndexPages returns pages in the main namespace - 10https://bugzilla.wikimedia.org/58648#c1 (10George Orwell III) CONFIRMED Observed the same on fr.wikisource. Don't see anything like that happening on en.wikisource however. [11:27:08] 3Wikimedia / 3General/Unknown: Incorrect use of Russian translation on a Ukranian wiki when there is a Ukranian translation available - 10https://bugzilla.wikimedia.org/68781#c1 (10Brad Jorsch) Further detail from bug 67805: "I tracked that one as far as observing that the json file for uk that the cdb file... [11:28:19] 3MediaWiki extensions / 3[other]: [TimezoneSelector] Notice: Did not find alias for special page 'TimezoneSelector'. Perhaps no aliases are defined for it? - 10https://bugzilla.wikimedia.org/68787 (10Alex Ivanov) 5NEW>3ASSI a:3Alex Ivanov [11:31:07] (03PS1) 10Zfilipin: Created Ruby lint job for ArticleFeedbackv5 [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/150189 (https://bugzilla.wikimedia.org/63469) [11:31:40] (03PS3) 10Zfilipin: Running Ruby linter for ArticleFeedbackv5 [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) [11:33:38] 3MediaWiki extensions / 3ProofreadPage: Special:IndexPages returns pages in the main namespace - 10https://bugzilla.wikimedia.org/58648#c2 (10Sam Reed (reedy)) This might actually be a search bug... [11:33:39] (03PS1) 10MegaAlex: Add aliases file for Special:TimezoneSelector [extensions/TimezoneSelector] - 10https://gerrit.wikimedia.org/r/150190 (https://bugzilla.wikimedia.org/68787) [11:34:54] 3MediaWiki / 3JavaScript: Invalid accesskey tooltip on Chrome - 10https://bugzilla.wikimedia.org/68798 (10Mateusz Maćkowski) 3UNCO p:3Unprio s:3minor a:3None Have a look at resources/src/jquery/jquery.accessKeyLabel.js: } else if ( profile.name === 'chrome' ) { accessKeyPrefix = ( profil... [11:36:21] 3MediaWiki / 3JavaScript: Invalid accesskey tooltip on Chrome - 10https://bugzilla.wikimedia.org/68798#c1 (10Mateusz Maćkowski) Created attachment 16081 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16081&action=edit Chrome menu showing Report an issue item [11:38:55] 3MediaWiki / 3JavaScript: Invalid accesskey tooltip on Chrome - 10https://bugzilla.wikimedia.org/68798 (10Mateusz Maćkowski) [11:40:47] damn Title cache [11:42:24] 3MediaWiki / 3JavaScript: Invalid accesskey tooltip on Chrome - 10https://bugzilla.wikimedia.org/68798 (10Mateusz Maćkowski) [11:46:54] Reedy: i found a nice Title cache unexpected behavior :-] [11:47:09] Title::newFromText( 'Main_Page' ); is cached [11:47:28] some tests set a fragment and that ends up being cached [11:47:34] producing some unwilling effect huhu [11:52:37] (03CR) 10Gilles: [C: 032] Move hide.*Buttons functions to UWI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150033 (owner: 10MarkTraceur) [11:53:07] (03Merged) 10jenkins-bot: Move hide.*Buttons functions to UWI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150033 (owner: 10MarkTraceur) [11:57:51] 3Datasets / 3General/Unknown: Wikidata JSON dump: better compression than gzip - 10https://bugzilla.wikimedia.org/68793#c1 (10Nemo) (In reply to Nemo from comment #0) > in recent > versions, xz is parallel Source: http://sourceforge.net/p/lzmautils/discussion/708858/thread/d37155d1/#d8af (currently Ubuntu h... [11:58:35] (03PS1) 10Hashar: Clear up cached Main_page title in test [extensions/Echo] - 10https://gerrit.wikimedia.org/r/150191 (https://bugzilla.wikimedia.org/68646) [11:59:01] (03CR) 10Hashar: "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/150191 (https://bugzilla.wikimedia.org/68646) (owner: 10Hashar) [12:00:34] (03CR) 10Gilles: [C: 032] Degrade Special:OrphanedTimedText gracefully if !$wgEnableLocalTimedText [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/149788 (owner: 10Brian Wolff) [12:00:46] (03Merged) 10jenkins-bot: Degrade Special:OrphanedTimedText gracefully if !$wgEnableLocalTimedText [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/149788 (owner: 10Brian Wolff) [12:04:24] 3MediaWiki / 3ContentHandler: [Regression] Link tables (categories, file links, templates) are being purged for js/css pages - 10https://bugzilla.wikimedia.org/68757#c3 (10Brad Jorsch) I note that something like api.php?format=jsonfm&action=parse&title=MediaWiki:Common.js&text=[[Category:Foo]] can be used to... [12:05:44] (03CR) 10Hashar: "retriggered the experimental job at https://integration.wikimedia.org/ci/job/mediawiki-core-extensions-integration/78/console" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/150191 (https://bugzilla.wikimedia.org/68646) (owner: 10Hashar) [12:05:49] (03CR) 10Gilles: [C: 032] "Classic" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150039 (owner: 10MarkTraceur) [12:06:20] (03Merged) 10jenkins-bot: Remove $.notify [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150039 (owner: 10MarkTraceur) [12:11:06] (03CR) 10Gilles: "Is there precedence to re-purposing this table like that? Why not create a new table?" [core] - 10https://gerrit.wikimedia.org/r/150131 (owner: 10Brian Wolff) [12:16:40] 3MediaWiki extensions / 3WikidataClient: allow arbitrary data access on Wikidata (LUA) - 10https://bugzilla.wikimedia.org/67538 (10Marius Hoch) 5PATC>3RESO/FIX [12:17:00] (03CR) 10Daniel Kinzler: "> It requires the use of a valid DBkey. In this case we don't really know or care whether our title is a valid DBkey." [core] - 10https://gerrit.wikimedia.org/r/149293 (https://bugzilla.wikimedia.org/30723) (owner: 10TTO) [12:17:24] 3MediaWiki extensions / 3Gadgets: Gadget usage statistics - 10https://bugzilla.wikimedia.org/19288#c5 (10Helder) This feature is also requested for https://meta.wikimedia.org/wiki/Global-Wiki#Plan_for_scripts [12:18:07] (03CR) 10Nemo bis: [C: 031] Add aliases file for Special:TimezoneSelector [extensions/TimezoneSelector] - 10https://gerrit.wikimedia.org/r/150190 (https://bugzilla.wikimedia.org/68787) (owner: 10MegaAlex) [12:21:50] (03CR) 10Helder.wiki: "See bug 68757 comment 3." [core] - 10https://gerrit.wikimedia.org/r/67983 (owner: 10Daniel Kinzler) [12:21:57] (03CR) 10Helder.wiki: "See bug 68757 comment 3." [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/131447 (https://bugzilla.wikimedia.org/64859) (owner: 10Bartosz Dziewoński) [12:22:20] (03CR) 10Raimond Spekking: [C: 032 V: 032] Add aliases file for Special:TimezoneSelector [extensions/TimezoneSelector] - 10https://gerrit.wikimedia.org/r/150190 (https://bugzilla.wikimedia.org/68787) (owner: 10MegaAlex) [12:24:21] 3MediaWiki extensions / 3[other]: [TimezoneSelector] Notice: Did not find alias for special page 'TimezoneSelector'. Perhaps no aliases are defined for it? - 10https://bugzilla.wikimedia.org/68787 (10Alex Ivanov) 5PATC>3RESO/FIX [12:32:54] 3Wikimedia / 3Deployment systems: Specific component for l10nupdate - 10https://bugzilla.wikimedia.org/68799 (10Nemo) 3NEW p:3Unprio s:3enhanc a:3None It happens semi-regularly that LocalisationUpdate bugs for Wikimedia projects end up in the wrong queue. For sure they're rather scattered: https://bu... [12:34:06] (03CR) 10Florianschmidtwelzow: Remove deprecated calls to wfMsg and updated SecurePoll special pages (032 comments) [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/150149 (owner: 10Withoutaname) [12:36:07] 3Wikimedia / 3Site requests: Add "abusefilter-log-detail" for rollbackers and patrollers on es.wikipedia - 10https://bugzilla.wikimedia.org/68319#c3 (10mr.ajedrez) Thanks, Vogone. It works properly. Regards. [12:36:51] 3MediaWiki / 3Search: Wrong number of search results - 10https://bugzilla.wikimedia.org/67731#c5 (10Nik Everett) 5NEW>3RESO/FIX Both of these look right to me now. I'm not sure of the sequence of events that lead this problem and its fix though. [12:38:08] 3MediaWiki / 3Search: Results 21 - 20 of 1 for - 10https://bugzilla.wikimedia.org/68783#c1 (10Nik Everett) p:5Unprio>3High a:3Nik Everett Confirmed. Pretty broken. [12:42:21] (03PS1) 10Rohan013: Fix Special:Listusers i18n issues [core] - 10https://gerrit.wikimedia.org/r/150201 (https://bugzilla.wikimedia.org/39845) [12:42:49] (03CR) 10Gilles: "Neil, you need to configure your editor to use tabs for JS files, as per http://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScrip" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [12:45:21] 3MediaWiki extensions / 3LiquidThreads: Cannot anonymously edit/change content of a LQT message but its title - 10https://bugzilla.wikimedia.org/65190#c8 (10paladox2015) What I mean is when trying to edit a thread it lets click edit but when trying to save it. It won't save. But if you do it as a user it does. [12:49:33] (03PS39) 10Gilles: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [12:49:35] (03CR) 10jenkins-bot: [V: 04-1] Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [12:56:52] (03CR) 10Gilles: [C: 04-1] "Removing an ongoing flickr upload makes a mess:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [12:56:55] (03PS1) 10Rillke: Load messages for licensing option of UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150203 [12:58:08] (03CR) 10Gilles: [C: 032] Load messages for licensing option of UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150203 (owner: 10Rillke) [12:58:36] (03Merged) 10jenkins-bot: Load messages for licensing option of UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150203 (owner: 10Rillke) [12:59:40] (03CR) 10Rillke: "Loading the message is done in I7f55c50c6562fb1." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/145420 (owner: 10Rillke) [13:03:52] 3MediaWiki extensions / 3LiquidThreads: Cannot anonymously edit/change content of a LQT message but its title - 10https://bugzilla.wikimedia.org/65190#c9 (10Helder) Not every user experience this problem. See e.g. the edits: https://www.mediawiki.org/w/index.php?diff=1081129&oldid=1081128 https://www.mediawi... [13:09:24] 3MediaWiki extensions / 3WikidataRepo: make it possible to make the default for monolingual text no language - 10https://bugzilla.wikimedia.org/67072 (10tobias.gritschacher) 5PATC>3RESO/FIX [13:10:51] 3MediaWiki extensions / 3CirrusSearch: Almost no results for intitle: searches in JS pages - 10https://bugzilla.wikimedia.org/68782 (10Andre Klapper) [13:12:07] 3Wikimedia / 3Extension setup: Activate File Upload Wizard in ta.wikipedia - 10https://bugzilla.wikimedia.org/68723#c9 (10Andre Klapper) 5UNCO>3RESO/INV As this request is about local on-wiki javascript, it's out of scope for Bugzilla as no server configuration code changes are needed. Closing this tick... [13:19:06] 3MediaWiki extensions / 3LiquidThreads: Cannot anonymously edit/change content of a LQT message but its title - 10https://bugzilla.wikimedia.org/65190#c10 (10Andre Klapper) See all questions in comment 6. Answering helps to bring things forward. [13:21:15] (03PS1) 10Manybubbles: WIP: Highlight in chains [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/150207 [13:21:43] (03CR) 10Manybubbles: [C: 04-1] "needs tests and our highlighter plugin released" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/150207 (owner: 10Manybubbles) [13:22:52] 3MediaWiki / 3Search: Results 21 - 20 of 1 for - 10https://bugzilla.wikimedia.org/68783#c2 (10Nik Everett) I'm able to reproduce this by searching for something rare and then manually adding offset=### where ### is greater than the maximum number of results. If that's the only way to reproduce... [13:36:06] 3MediaWiki extensions / 3CentralAuth: CentralAuth tests are failing - 10https://bugzilla.wikimedia.org/68784#c3 (10Chris Steipp) I actually already had gerrit 141482 ready, which would also fix this, and checks for password upgrades. We should be fine doing either one right now. [13:39:21] 3MediaWiki extensions / 3WikidataRepo: SnakUnserializer must not fail on mismatching hashes - 10https://bugzilla.wikimedia.org/68565 (10tobias.gritschacher) 5PATC>3RESO/FIX [13:40:21] 3MediaWiki extensions / 3WikidataRepo: Right mouse click selects but shouldn't - 10https://bugzilla.wikimedia.org/66431#c2 (10Thiemo Mättig) 5NEW>3RESO/FIX https://github.com/wmde/ValueView/pull/82 [13:41:53] 3MediaWiki extensions / 3LiquidThreads: Cannot anonymously edit/change content of a LQT message but its title - 10https://bugzilla.wikimedia.org/65190#c11 (10paladox2015) Hi I doint have the extension installed on my wikis but when trying to use it on mediawiki it doesent work for me. the current mediawiki w... [13:42:36] 3MediaWiki extensions / 3WikidataRepo: Badges shown by SiteLinksView should have the label as title not only the id - 10https://bugzilla.wikimedia.org/68183 (10Marius Hoch) 5PATC>3RESO/FIX [13:45:12] (03PS1) 10Rohan013: Special:Newpages feed now shows first revision instead of latest revision [core] - 10https://gerrit.wikimedia.org/r/150210 (https://bugzilla.wikimedia.org/67026) [13:46:13] (03CR) 10Bartosz Dziewoński: [C: 032] Move PasswordError under includes/password/ file [core] - 10https://gerrit.wikimedia.org/r/150168 (owner: 10Withoutaname) [13:47:19] (03CR) 10Hashar: "And that fix a bunch of Scribunto tests. The Jenkins test report page shows a lot of entry with 'Fixed' at https://integration.wikimedia." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/150191 (https://bugzilla.wikimedia.org/68646) (owner: 10Hashar) [13:49:53] (03Merged) 10jenkins-bot: Move PasswordError under includes/password/ file [core] - 10https://gerrit.wikimedia.org/r/150168 (owner: 10Withoutaname) [13:50:57] (03PS5) 10Deepali: Import external metadata from Wikidata [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/149654 (https://bugzilla.wikimedia.org/51971) [13:54:20] <^d> MatmaRex: More easy changes to User.php: https://gerrit.wikimedia.org/r/#/c/148905/ :) :) [13:54:24] 3MediaWiki / 3Parser: File links with local project prefix cause images to be transcluded - 10https://bugzilla.wikimedia.org/68802 (10Erwin Dokter) 3NEW p:3Unprio s:3critic a:3None Reported on [[WP:VPT]]. Marking as critical. When local file links are prefixed with a project code, ie. [[w:File:Examp... [13:54:33] (03CR) 10Nemo bis: "Thanks. Using FeedUtils::formatDiffRow looks sensible" [core] - 10https://gerrit.wikimedia.org/r/143904 (https://bugzilla.wikimedia.org/41085) (owner: 10Rohan013) [13:56:09] (03PS4) 10Zfilipin: Running Ruby linter for all repos that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) [13:56:15] ^d: aww, back-compat breaks :( [13:56:19] ^d: if it's easy changes time, I have several which unbreak unit tests for me https://gerrit.wikimedia.org/r/#/q/owner:federicoleva,n,z [13:56:32] Funniest is https://gerrit.wikimedia.org/r/149795 [13:56:52] facepalm'est is https://gerrit.wikimedia.org/r/149793 [13:57:18] <^d> MatmaRex: Back compat breaks? Nothing uses them. [13:57:44] ^d: i bet some obscure part of SMW does :P [13:57:51] 3MediaWiki / 3Parser: Local interwiki prefix + lang code (e.g. [[w:de:Foo]] on enwiki) should not give interlanguage link - 10https://bugzilla.wikimedia.org/68085 (10Bartosz Dziewoński) [13:57:53] 3MediaWiki / 3Parser: File links with local project prefix cause images to be transcluded - 10https://bugzilla.wikimedia.org/68802#c1 (10Bartosz Dziewoński) This might be the same issue as bug 68085, which has been already fixed (but not yet deployed). [13:58:18] <^d> MatmaRex: Wanna bet? I grepped. [13:58:53] ^d: no, but i'll just let somebody who is already hated by SMW people merge it :P [13:59:12] <^d> Blargh. [13:59:23] <^d> Nothing uses these. Or used. I checked svn. [14:00:53] 3Wikimedia / 3Deployment systems: Specific component for l10nupdate - 10https://bugzilla.wikimedia.org/68799#c1 (10Antoine "hashar" Musso) That is part of the Deployment systems. I don't think it justify a dedicated component under Wikimedia. [14:00:59] <^d> USER_TOKEN_LENGTH was never used outside of core afaict. MW_USER_VERSION has one usage in an old svn extension that wasn't moved to git. [14:01:51] (03PS2) 10Zfilipin: Running Ruby linter for all repos that have Ruby code [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/150189 (https://bugzilla.wikimedia.org/63469) [14:03:04] (03PS3) 10Zfilipin: WIP Running Ruby linter for all repos that have Ruby code [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/150189 (https://bugzilla.wikimedia.org/63469) [14:03:11] (03PS5) 10Zfilipin: WIP Running Ruby linter for all repos that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) [14:04:37] (03CR) 10Gilles: "recheck" [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/141241 (owner: 10Rillke) [14:06:53] (03CR) 10Rillke: "Hey, thanks for setting up another CI test." [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/141241 (owner: 10Rillke) [14:07:23] (03CR) 10Gilles: "FYI, Rainer, if you want the PHPunit test to be run by Jenkins upon commit, you can just commit with your @wikipedia.de email address, as " [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/141241 (owner: 10Rillke) [14:07:26] (03CR) 10Krinkle: [C: 032] "Indeed. If they want to use the old version, they should use a stable version from the release branches. The master version is no longer m" [extensions/OggHandler] - 10https://gerrit.wikimedia.org/r/149465 (owner: 10Mattflaschen) [14:07:32] (03Merged) 10jenkins-bot: Close out extension and note TimedMediaHandler as replacement [extensions/OggHandler] - 10https://gerrit.wikimedia.org/r/149465 (owner: 10Mattflaschen) [14:08:06] (03CR) 10Gilles: [C: 032] Attaching Hooks to tweak MIME type detection [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/141241 (owner: 10Rillke) [14:08:11] (03Merged) 10jenkins-bot: Attaching Hooks to tweak MIME type detection [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/141241 (owner: 10Rillke) [14:12:55] (03CR) 10Hashar: [C: 031] "Or we come up with a common job shared by all repositories. This way we will just have to adjust the Zuul config :-)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/150189 (https://bugzilla.wikimedia.org/63469) (owner: 10Zfilipin) [14:18:36] (03PS1) 10Giuseppe Lavagetto: Make hhvm-luasandbox depend on hhvm-build and not on the package [php/luasandbox] - 10https://gerrit.wikimedia.org/r/150215 [14:24:28] (03PS1) 10Giuseppe Lavagetto: Make hhvm-fss depend on hhvm-build and not on the package [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/150216 [14:26:23] 3MediaWiki extensions / 3LiquidThreads: Cannot anonymously edit/change content of a LQT message but its title - 10https://bugzilla.wikimedia.org/65190#c12 (10Andre Klapper) Let me ask for a 4th time for error console output when this problem happens. See: * Firefox ≥24: https://developer.mozilla.org/en-US/do... [14:28:40] 3Wikimedia / 3Site requests: Please add the deleted domain *.eur.nl again to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/68803 (10johanmmuller) 3UNCO p:3Unprio s:3enhanc a:3None Please add again the following deleted domain to the wgCopyUploadsDomains whitelist: *.eur.nl f... [14:29:23] (03PS1) 10Giuseppe Lavagetto: Make hhvm-wikidiff2 depend on hhvm-build and not on the package [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/150217 [14:36:35] (03PS28) 10Hashar: (WIP) Experiment zuul-cloner with extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141846 [14:37:05] (03CR) 10Hashar: "- intersection : parser tests are broken" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141846 (owner: 10Hashar) [14:43:27] (03PS1) 10Hashar: Prefix parser tests files with 'proofreadpage_' [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/150219 [14:44:59] (03PS6) 10Zfilipin: WIP Running Ruby linter for all repos that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) [14:47:54] 3MediaWiki extensions / 3WikidataRepo: Test conformance of API modules - 10https://bugzilla.wikimedia.org/67407 (10tobias.gritschacher) [14:48:08] 3MediaWiki extensions / 3WikidataClient: allow arbitrary data access on Wikidata (parser function) - 10https://bugzilla.wikimedia.org/68029 (10tobias.gritschacher) [14:48:25] 3MediaWiki extensions / 3WikidataRepo: allow adding wikidata pages as site links - 10https://bugzilla.wikimedia.org/67531 (10tobias.gritschacher) [14:48:40] 3MediaWiki extensions / 3WikidataClient: draft RfC for improving recent changes formatting - 10https://bugzilla.wikimedia.org/68028 (10tobias.gritschacher) [14:48:53] 3MediaWiki extensions / 3WikidataRepo: Create browser smoke test for a typical item - 10https://bugzilla.wikimedia.org/68094 (10tobias.gritschacher) [14:49:39] 3MediaWiki extensions / 3WikidataRepo: Move JS WikibaseAPI code into its own component - 10https://bugzilla.wikimedia.org/66419 (10tobias.gritschacher) [14:49:54] 3MediaWiki extensions / 3WikidataRepo: Create tests comparing the output of the old and new serializer implementation - 10https://bugzilla.wikimedia.org/66839 (10tobias.gritschacher) [14:50:08] 3MediaWiki extensions / 3WikidataClient: the show/hide recent changes and watchlist toggle does not respect showExternalRecentChanges setting - 10https://bugzilla.wikimedia.org/68461 (10tobias.gritschacher) [14:50:27] (03PS4) 10Zfilipin: WIP Running Ruby linter for all repos that have Ruby code [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/150189 (https://bugzilla.wikimedia.org/63469) [14:53:17] (03PS7) 10Zfilipin: WIP Running Ruby linter for all repos that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) [14:54:54] (03PS2) 10Legoktm: Update CentralAuth for Password API [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/141482 (owner: 10CSteipp) [14:55:09] (03CR) 10jenkins-bot: [V: 04-1] Update CentralAuth for Password API [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/141482 (owner: 10CSteipp) [14:55:16] (03PS5) 10Zfilipin: WIP Running Ruby linter for all repos that have Ruby code [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/150189 (https://bugzilla.wikimedia.org/63469) [14:59:49] (03CR) 10Legoktm: [C: 04-1] "Still one usage of User::crypt in the tests:" (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/141482 (owner: 10CSteipp) [15:00:22] (03Abandoned) 10Legoktm: Stop using deprecated User::comparePasswords/User::crypt [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/150138 (https://bugzilla.wikimedia.org/68784) (owner: 10Legoktm) [15:00:39] (03PS3) 10Legoktm: Update CentralAuth for Password API [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/141482 (https://bugzilla.wikimedia.org/68784) (owner: 10CSteipp) [15:00:47] (03CR) 10jenkins-bot: [V: 04-1] Update CentralAuth for Password API [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/141482 (https://bugzilla.wikimedia.org/68784) (owner: 10CSteipp) [15:03:24] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: When creating the index fail if dynamic scripting isn't set correctly or if elasticsearch isn't the minimum required version - 10https://bugzilla.wikimedia.org/68804 (10Nik Everett) 3NEW p:3Unprio s:3normal a:3None CirrusSearch: When creating the i... [15:03:54] (03CR) 10Legoktm: "The proper solution is to just whitelist Rillke's email in integration/zuul-config, which is trivial to do." [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/141241 (owner: 10Rillke) [15:04:36] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: When creating the index fail if dynamic scripting isn't set correctly or if elasticsearch isn't the minimum required version - 10https://bugzilla.wikimedia.org/68804 (10Nik Everett) p:5Unprio>3High [15:05:54] (03CR) 10Parent5446: [C: 032] Documentation: Update $wgPasswordDefault and BcryptPassword [core] - 10https://gerrit.wikimedia.org/r/150166 (owner: 10Withoutaname) [15:07:27] (03CR) 10Legoktm: [C: 032] test: coverage for wfWikiID() [core] - 10https://gerrit.wikimedia.org/r/150169 (https://bugzilla.wikimedia.org/68231) (owner: 10Hashar) [15:09:09] (03PS1) 10Hashar: Always set prquality even if $wgTitle does not exist [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/150226 [15:09:28] (03PS2) 10Hashar: Always set prquality even if $wgTitle does not exist [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/150226 (https://bugzilla.wikimedia.org/68644) [15:09:48] (03CR) 10jenkins-bot: [V: 04-1] Always set prquality even if $wgTitle does not exist [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/150226 (https://bugzilla.wikimedia.org/68644) (owner: 10Hashar) [15:10:01] (03CR) 10Hashar: "check experimental" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/150226 (https://bugzilla.wikimedia.org/68644) (owner: 10Hashar) [15:11:06] (03Merged) 10jenkins-bot: Documentation: Update $wgPasswordDefault and BcryptPassword [core] - 10https://gerrit.wikimedia.org/r/150166 (owner: 10Withoutaname) [15:11:08] (03PS1) 10Tweichart: inserting a document now results in an insertion at the cursor, inserted at the start of the document before (ie11) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/150227 [15:11:10] (03Merged) 10jenkins-bot: test: coverage for wfWikiID() [core] - 10https://gerrit.wikimedia.org/r/150169 (https://bugzilla.wikimedia.org/68231) (owner: 10Hashar) [15:11:27] legoktm: thanks :)) [15:14:47] (03CR) 10Hashar: "check experimental" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/150226 (https://bugzilla.wikimedia.org/68644) (owner: 10Hashar) [15:15:48] :) [15:17:12] (03CR) 10Legoktm: [C: 04-1] Use WebRequest::getIP() instead of wfGetIP, deprecated in 1.19 (031 comment) [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/150066 (owner: 10Nemo bis) [15:18:40] (03CR) 10Legoktm: [C: 032 V: 032] "lol" [extensions/OpenStreetMapSlippyMap] - 10https://gerrit.wikimedia.org/r/149795 (owner: 10Nemo bis) [15:22:07] (03CR) 10Parent5446: [C: 032] "Thanks. I thought I had gotten all the @since, and not sure how I missed that indentation. O.o" [core] - 10https://gerrit.wikimedia.org/r/150143 (owner: 10Legoktm) [15:22:12] (03PS2) 10Legoktm: Add missing $wgResourceModules global statement [extensions/SkelJS] - 10https://gerrit.wikimedia.org/r/149881 (owner: 10Nemo bis) [15:22:28] (03CR) 10Legoktm: [C: 032 V: 032] "PS2: Fixed spacing" [extensions/SkelJS] - 10https://gerrit.wikimedia.org/r/149881 (owner: 10Nemo bis) [15:22:54] (03PS2) 10Nemo bis: Use getIP() instead of wfGetIP, deprecated in 1.19 [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/150066 [15:23:41] (03CR) 10Hashar: "Pff I don't know what I am doing :-/" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/150226 (https://bugzilla.wikimedia.org/68644) (owner: 10Hashar) [15:24:09] (03CR) 10Legoktm: [C: 032] Use getIP() instead of wfGetIP, deprecated in 1.19 [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/150066 (owner: 10Nemo bis) [15:24:15] (03Merged) 10jenkins-bot: Use getIP() instead of wfGetIP, deprecated in 1.19 [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/150066 (owner: 10Nemo bis) [15:25:14] (03Merged) 10jenkins-bot: Documentation fixes for Password API-related changes [core] - 10https://gerrit.wikimedia.org/r/150143 (owner: 10Legoktm) [15:33:53] (03CR) 10Hashar: "Bah the regression job does not pass https://integration.wikimedia.org/ci/job/mediawiki-core-regression-master/6739/console and fails on t" [core] - 10https://gerrit.wikimedia.org/r/150169 (https://bugzilla.wikimedia.org/68231) (owner: 10Hashar) [15:43:01] (03PS1) 10MegaAlex: Add GENDER support to flow-sorting-tooltip [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150233 (https://bugzilla.wikimedia.org/67191) [15:44:28] (03PS2) 10Physikerwelt: Use id for math anchor if possible [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/150074 [15:44:51] 3MediaWiki / 3Unit tests: wfWikiID() returns different values from test and data provider - 10https://bugzilla.wikimedia.org/68231#c7 (10Bryan Davis) I have a work around for the particular test where I encountered this problem originally: https://gerrit.wikimedia.org/r/#/c/147020/9/tests/CentralAuthPluginUs... [15:46:31] (03PS3) 10Physikerwelt: Use id for math anchor if possible [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/150074 [15:47:11] (03CR) 10Physikerwelt: [C: 032] Use id for math anchor if possible [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/150074 (owner: 10Physikerwelt) [15:47:19] (03Merged) 10jenkins-bot: Use id for math anchor if possible [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/150074 (owner: 10Physikerwelt) [15:48:27] (03PS1) 10Rillke: Configurable memory limit [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/150235 [15:49:41] (03CR) 10Physikerwelt: "Ok. I'd like to see this merged." [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149323 (https://bugzilla.wikimedia.org/67221) (owner: 10Cmcmahon) [15:50:20] (03PS4) 10Legoktm: Update CentralAuth for Password API [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/141482 (https://bugzilla.wikimedia.org/68784) (owner: 10CSteipp) [15:50:52] 3Wikimedia / 3Site requests: Please add the deleted domain *.eur.nl again to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/68803#c1 (10johanmmuller) I now find out that fortunately i CAN upload on the GWToolSet production site https://commons.wikimedia.org/wiki/Special:GWToolset wher... [15:52:04] (03Abandoned) 10Physikerwelt: correct typo [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/150090 (owner: 10Physikerwelt) [15:52:16] (03PS1) 10Hoo man: Update Wikidata [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150238 [15:53:24] (03CR) 10Legoktm: [C: 031] "PS4: Stopped using Status objects, just using a boolean now. Fixed a few undefined variables, and removed the remaining User::crypt call i" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/141482 (https://bugzilla.wikimedia.org/68784) (owner: 10CSteipp) [15:54:10] (03PS2) 10Rillke: Configurable memory limit [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/150235 [15:54:46] (03CR) 10Parent5446: [C: 031] Update CentralAuth for Password API [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/141482 (https://bugzilla.wikimedia.org/68784) (owner: 10CSteipp) [15:54:58] (03PS1) 10Hoo man: Update Wikidata [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150239 [15:55:35] (03CR) 10CSteipp: [C: 031] "Legoktm's changes all look good." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/141482 (https://bugzilla.wikimedia.org/68784) (owner: 10CSteipp) [15:56:33] (03CR) 10Rillke: "Now using the @wikipedia.de address and still it's not +2ing." [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/150235 (owner: 10Rillke) [15:56:35] (03PS1) 10Parent5446: Added explicit type-cast to hash_pbkdf2 [core] - 10https://gerrit.wikimedia.org/r/150240 [15:57:05] rillke: Only the wikimedia.de addresses will make jenkins bot do the extra stuffs [15:57:48] (03PS2) 10Parent5446: Added explicit type-cast to hash_pbkdf2 [core] - 10https://gerrit.wikimedia.org/r/150240 [15:57:56] rillke: let me just whitelist your email [15:57:58] rillke: just get yourself added to the whitelist [15:58:11] too slow :( [15:58:56] but there is "- .*?@wikimedia\.de$" in layout.yaml [15:59:07] ha, @wikimedia [15:59:14] rillke: what email should I whitelist? [15:59:31] pm [15:59:51] it's public anyway :P [16:01:07] 3MediaWiki extensions / 3SemanticForms: SF Incorrect page name "Some very long page name that will hopefully never get created ABCDEF123" appearing - 10https://bugzilla.wikimedia.org/51479#c19 (10Neill Mitchell) I'm also seeing this occasionally when creating pages with the one step process. There does not... [16:01:21] (03PS1) 10Legoktm: Whitelist rillke (GSoC student) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150242 [16:01:32] hashar: ^ :D [16:01:51] well, it has some obfuscation for the escaped dot that must not appear in the channel logs [16:01:53] ah yeah gilles talked about it to me earlier [16:01:57] hey rillke [16:02:13] though wikipedia.de should be whitelisted already [16:02:25] hey hashar, can I break something if the tests are now run automatically? [16:02:25] wikipedia != wikimedia :P [16:02:35] - .*?@wikimedia\.de$ [16:02:36] oh [16:03:25] (03CR) 10Hashar: [C: 032] "wikipedia.de != wikimedia.de" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150242 (owner: 10Legoktm) [16:03:32] (03Merged) 10jenkins-bot: Whitelist rillke (GSoC student) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150242 (owner: 10Legoktm) [16:03:45] (03CR) 10Rillke: "Thank you!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150242 (owner: 10Legoktm) [16:04:13] rillke: change deployed, that should work. You can verify by sending a new patch [16:04:16] that should now run tests [16:04:55] (03PS1) 10MaxSem: Switch jobrunner to JSON config [vagrant] - 10https://gerrit.wikimedia.org/r/150243 (https://bugzilla.wikimedia.org/68785) [16:05:48] (03CR) 10Rillke: "recheck" [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/150235 (owner: 10Rillke) [16:07:22] 3MediaWiki extensions / 3SemanticForms: SF Incorrect page name "Some very long page name that will hopefully never get created ABCDEF123" appearing - 10https://bugzilla.wikimedia.org/51479#c20 (10s7eph4n) p:5Unprio>3High Raised priority. Creating pages from red links will crash MW 1.24+. Not once, but al... [16:07:51] (03Abandoned) 10Legoktm: Update larger tables via the job queue [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/145543 (owner: 10Legoktm) [16:09:29] rillke: congratulations :-] [16:13:21] (03CR) 10Hoo man: [C: 032] Update Wikidata [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150238 (owner: 10Hoo man) [16:13:25] (03CR) 10Hoo man: [C: 032] Update Wikidata [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150239 (owner: 10Hoo man) [16:13:53] (03CR) 10CSteipp: [C: 032] Clarify comment in UploadBase [core] - 10https://gerrit.wikimedia.org/r/150125 (owner: 10Mattflaschen) [16:14:16] (03CR) 10Legoktm: [C: 04-1] "Notice: GlobalRenameUserDatabaseUpdates::merge: Transaction already in progress (from GlobalRenameUserStatus::setStatuses), performing im" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) (owner: 10Legoktm) [16:16:06] (03Merged) 10jenkins-bot: Update Wikidata [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150238 (owner: 10Hoo man) [16:16:23] (03Merged) 10jenkins-bot: Update Wikidata [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150239 (owner: 10Hoo man) [16:16:56] (03Merged) 10jenkins-bot: Clarify comment in UploadBase [core] - 10https://gerrit.wikimedia.org/r/150125 (owner: 10Mattflaschen) [16:17:09] (03CR) 10Reedy: "Is this still needed now?" [core] - 10https://gerrit.wikimedia.org/r/56079 (owner: 10Pgehres) [16:17:22] (03CR) 10AndyRussG: [C: 032] "I don't see any serious blockers, and you seem pretty sure that this is how you want it to work. I'll send some more general comments in a" (035 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140086 (owner: 10Prtksxna) [16:17:49] (03Merged) 10jenkins-bot: Add settings [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140086 (owner: 10Prtksxna) [16:21:04] (03PS1) 10Smuggli: Readded escaping of highlight snippets [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/150245 [16:21:34] (03Abandoned) 10CSteipp: Adding functions to User.php to upgrade password storage on login. [core] - 10https://gerrit.wikimedia.org/r/56079 (owner: 10Pgehres) [16:31:26] (03CR) 1020after4: "https://gerrit.wikimedia.org/r/#/c/149364/ should be good now" [tools/scap] - 10https://gerrit.wikimedia.org/r/148112 (owner: 10BryanDavis) [16:36:48] (03PS6) 10Deepali: Import external metadata from Wikidata [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/149654 (https://bugzilla.wikimedia.org/51971) [16:37:01] (03CR) 10jenkins-bot: [V: 04-1] Import external metadata from Wikidata [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/149654 (https://bugzilla.wikimedia.org/51971) (owner: 10Deepali) [16:39:09] (03PS7) 10Deepali: Import external metadata from Wikidata [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/149654 (https://bugzilla.wikimedia.org/51971) [16:40:15] (03CR) 10Ori.livneh: [C: 032] Set "has value" flag correctly for result parameter [core] - 10https://gerrit.wikimedia.org/r/150106 (owner: 10Aaron Schulz) [16:42:12] ori: funny since it still works using result=json [16:43:15] (03Merged) 10jenkins-bot: Set "has value" flag correctly for result parameter [core] - 10https://gerrit.wikimedia.org/r/150106 (owner: 10Aaron Schulz) [16:45:36] 3MediaWiki / 3Parser: File links with local project prefix cause images to be transcluded - 10https://bugzilla.wikimedia.org/68802#c2 (10Erwin Dokter) I can't tell if that will fix it. I will know as soon as it is deployed to enwiki. [16:46:39] (03CR) 10CSteipp: [C: 032] Have SvgHandler create a directory for its RSVG input files [core] - 10https://gerrit.wikimedia.org/r/145232 (owner: 10Aaron Schulz) [16:47:16] (03CR) 10BryanDavis: [C: 04-1] "We may need to add ensure=>latest support for our git::clone resource too. Right now jobrunner will work if you have a checkout from befor" (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/150243 (https://bugzilla.wikimedia.org/68785) (owner: 10MaxSem) [16:47:28] (03CR) 10Jdlrobson: [C: 04-1] "Actually this is not as big a deal as I thought. I'm doing some tweaks to make this all clearer..." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150112 (https://bugzilla.wikimedia.org/68706) (owner: 10Spage) [16:48:20] (03PS1) 10Dbrant: Fix syntax error in generated .css file. [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/150248 [16:49:47] (03Merged) 10jenkins-bot: Have SvgHandler create a directory for its RSVG input files [core] - 10https://gerrit.wikimedia.org/r/145232 (owner: 10Aaron Schulz) [16:50:33] (03CR) 10Cmcmahon: [C: 032] "This is already running in production (and it's green) https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-Math-en.wik" [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149323 (https://bugzilla.wikimedia.org/67221) (owner: 10Cmcmahon) [16:51:52] (03Merged) 10jenkins-bot: The first job for Math extension [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149323 (https://bugzilla.wikimedia.org/67221) (owner: 10Cmcmahon) [16:52:07] (03CR) 10Krinkle: [C: 032] Add WikimediaShopLink messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/149785 (https://bugzilla.wikimedia.org/55678) (owner: 10Legoktm) [16:52:16] (03Merged) 10jenkins-bot: Add WikimediaShopLink messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/149785 (https://bugzilla.wikimedia.org/55678) (owner: 10Legoktm) [16:54:18] (03PS3) 10Mwalker: Allow customizing post_zip destination [extensions/Collection] - 10https://gerrit.wikimedia.org/r/106847 (owner: 10MaxSem) [16:57:30] (03PS1) 10Manybubbles: Clean up search results if scrolled of the end [core] - 10https://gerrit.wikimedia.org/r/150251 (https://bugzilla.wikimedia.org/68783) [16:59:01] (03PS6) 10Jdlrobson: Watchstar should use mediawiki ui styles not flow ui for buttons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148724 (https://bugzilla.wikimedia.org/68456) [16:59:04] (03PS1) 10Jdlrobson: Hygiene: Cleanup use of buttons.less so it's clear it is there for caching purposes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150252 [17:02:17] (03CR) 10Dbrant: "Looks good, but just one minor issue: the flag icon looks a bit "blurry" when displayed on the page (noticeably more blurry than the flag " [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/148866 (owner: 10BearND) [17:02:47] (03PS1) 10Umherirrender: Restore the number of rows shown on Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/150254 (https://bugzilla.wikimedia.org/62017) [17:03:37] (03PS1) 10Aaron Schulz: Have SvgHandler create a directory for its RSVG input files [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/150255 [17:04:07] (03CR) 10Jdlrobson: [C: 04-1] "I'm thinking mw-ui-constructive-active and mw-ui-constructive-quiet would be more appropriate here." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148724 (https://bugzilla.wikimedia.org/68456) (owner: 10Jdlrobson) [17:08:25] (03PS7) 10Krinkle: On redirects update the URL to that of the target page with JavaScript [core] - 10https://gerrit.wikimedia.org/r/143852 (https://bugzilla.wikimedia.org/35045) (owner: 10Bartosz Dziewoński) [17:08:48] (03CR) 10jenkins-bot: [V: 04-1] On redirects update the URL to that of the target page with JavaScript [core] - 10https://gerrit.wikimedia.org/r/143852 (https://bugzilla.wikimedia.org/35045) (owner: 10Bartosz Dziewoński) [17:09:28] (03PS8) 10Krinkle: On redirects update the URL to that of the target page with JavaScript [core] - 10https://gerrit.wikimedia.org/r/143852 (https://bugzilla.wikimedia.org/35045) (owner: 10Bartosz Dziewoński) [17:10:16] (03CR) 10Cmcmahon: [C: 032] Deleting all qa/browsertests jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/150174 (https://bugzilla.wikimedia.org/63469) (owner: 10Zfilipin) [17:10:44] (03Merged) 10jenkins-bot: Deleting all qa/browsertests jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/150174 (https://bugzilla.wikimedia.org/63469) (owner: 10Zfilipin) [17:11:28] (03PS1) 10EBernhardson: Hygine: Cleanup recent change listeners [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150256 [17:12:54] (03PS7) 10Jdlrobson: Constructive colour watchstar [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148724 (https://bugzilla.wikimedia.org/68456) [17:13:32] (03PS8) 10Jdlrobson: Constructive colour watchstar [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148724 (https://bugzilla.wikimedia.org/68456) [17:18:03] mooeypoo: If you +1 my revision I'll +2 (the json/jsonp change) [17:18:40] (03PS1) 10MarkTraceur: Make UWU and UWUI event emitters [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150258 [17:18:43] (03CR) 10jenkins-bot: [V: 04-1] Make UWU and UWUI event emitters [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150258 (owner: 10MarkTraceur) [17:19:21] 3Wikimedia / 3Deployment systems: Specific component for l10nupdate - 10https://bugzilla.wikimedia.org/68799#c2 (10Greg Grossmeier) 5NEW>3UNCO (In reply to Nemo from comment #0) > The recently created > "Deployment systems" component sounds about right given name+description > ("Tools to deploy code on W... [17:20:43] (03PS1) 10BryanDavis: Enable mod_headers [vagrant] - 10https://gerrit.wikimedia.org/r/150259 [17:21:51] 3Wikimedia / 3Site requests: Deploy TemplateData's GUI editing tool to all wikis - 10https://bugzilla.wikimedia.org/60158 (10James Forrester) [17:22:10] (03PS2) 10MarkTraceur: Make UWU and UWUI event emitters [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150258 [17:22:21] 3Wikimedia / 3Site requests: Enable the TemplateData GUI editor on Dutch Wikipedia - 10https://bugzilla.wikimedia.org/68795 (10James Forrester) [17:22:38] (03CR) 10jenkins-bot: [V: 04-1] Make UWU and UWUI event emitters [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150258 (owner: 10MarkTraceur) [17:23:25] (03PS3) 10MarkTraceur: Make UWU and UWUI event emitters [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150258 [17:23:29] (03PS9) 10Jdlrobson: Constructive colour watchstar [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148724 (https://bugzilla.wikimedia.org/68456) [17:23:52] (03CR) 10jenkins-bot: [V: 04-1] Make UWU and UWUI event emitters [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150258 (owner: 10MarkTraceur) [17:24:43] (03PS4) 10MarkTraceur: Make UWU and UWUI event emitters [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/150258 [17:25:27] (03PS10) 10BearND: Add blue flag icon for article/page issues links [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/148866 [17:26:20] (03PS2) 10EBernhardson: Fix insert order issue with recent change listeners [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150256 [17:26:48] (03PS10) 10Jdlrobson: Constructive colour watchstar [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148724 (https://bugzilla.wikimedia.org/68456) [17:33:07] 3Wikimedia / 3Deployment systems: Specific component for l10nupdate - 10https://bugzilla.wikimedia.org/68799#c3 (10Nemo) (In reply to Greg Grossmeier from comment #2) > > but it would need new CCs > > Suggestions welcome :) Those in CC here for instance. It would also help if the component was documented a... [17:35:00] (03CR) 10Aaron Schulz: [C: 032] Update CentralAuth for Password API [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/141482 (https://bugzilla.wikimedia.org/68784) (owner: 10CSteipp) [17:35:11] (03Merged) 10jenkins-bot: Update CentralAuth for Password API [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/141482 (https://bugzilla.wikimedia.org/68784) (owner: 10CSteipp) [17:40:08] (03CR) 10Aaron Schulz: [C: 032] Have SvgHandler create a directory for its RSVG input files [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/150255 (owner: 10Aaron Schulz) [17:40:59] (03PS1) 10Aaron Schulz: Have SvgHandler create a directory for its RSVG input files [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150268 [17:42:36] (03Merged) 10jenkins-bot: Have SvgHandler create a directory for its RSVG input files [core] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/150255 (owner: 10Aaron Schulz) [17:42:50] Nemo_bis: hmm, know a quick/easy way to see who all has default cc on a given component? [17:43:33] greg-g: I use https://bugzilla.wikimedia.org/enter_bug.cgi?product=Wikimedia [17:44:51] Nemo_bis: of course :/ thanks [17:47:32] (03PS1) 10Aaron Schulz: Have SvgHandler create a directory for its RSVG input files [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150269 [17:47:36] 3Wikimedia / 3Bugzilla: Add new default CCs to Wikimedia -> Deployment Tooling and modify description - 10https://bugzilla.wikimedia.org/68799#c4 (10Greg Grossmeier) 5UNCO>3NEW p:5Unprio>3Normal (In reply to Nemo from comment #3) > (In reply to Greg Grossmeier from comment #2) > > > but it would need... [17:47:48] (03CR) 10Aaron Schulz: [C: 032] Have SvgHandler create a directory for its RSVG input files [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150269 (owner: 10Aaron Schulz) [17:49:27] (03CR) 10Dbrant: [C: 032] Add blue flag icon for article/page issues links [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/148866 (owner: 10BearND) [17:49:45] (03CR) 10Gergő Tisza: "Is this really needed? The CORS patch seemed to work fine for me." [vagrant] - 10https://gerrit.wikimedia.org/r/150259 (owner: 10BryanDavis) [17:51:07] (03Merged) 10jenkins-bot: Have SvgHandler create a directory for its RSVG input files [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150269 (owner: 10Aaron Schulz) [17:51:09] (03CR) 10EBernhardson: [C: 032] QA: Add browser test which ensures anonymous users do not see deleted posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145162 (owner: 10Jdlrobson) [17:51:46] (03Merged) 10jenkins-bot: QA: Add browser test which ensures anonymous users do not see deleted posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145162 (owner: 10Jdlrobson) [17:52:36] 3Wikimedia / 3Bugzilla: Add new default CCs to Wikimedia -> Deployment Tooling and modify description - 10https://bugzilla.wikimedia.org/68799#c5 (10Amir E. Aharoni) (In reply to Greg Grossmeier from comment #4) > (In reply to Nemo from comment #3) > > (In reply to Greg Grossmeier from comment #2) > > > > bu... [17:52:41] (03CR) 10BryanDavis: "Without this apache would not start for me:" [vagrant] - 10https://gerrit.wikimedia.org/r/150259 (owner: 10BryanDavis) [17:53:00] (03PS4) 10Jdlrobson: Hygiene: rename title-post to topic-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150140 (owner: 10EBernhardson) [17:55:00] (03PS1) 10Rohan013: Include diffs in Watchlist feed [core] - 10https://gerrit.wikimedia.org/r/150271 (https://bugzilla.wikimedia.org/10268) [17:55:18] (03CR) 10Jdlrobson: [C: 04-1] "Newly created topics still appear as unwatched to me.." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150083 (owner: 10EBernhardson) [17:55:30] (03CR) 10Jdlrobson: [C: 032] Pass metadata array for ObjectManager listeners [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150064 (owner: 10EBernhardson) [17:56:05] (03Merged) 10jenkins-bot: Pass metadata array for ObjectManager listeners [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150064 (owner: 10EBernhardson) [17:56:06] 3Wikimedia / 3Bugzilla: Add new default CCs to Wikimedia -> Deployment Tooling and modify description - 10https://bugzilla.wikimedia.org/68799#c6 (10Greg Grossmeier) (In reply to Amir E. Aharoni from comment #5) > I don't know if I should be on CC for all deployment tooling, but getting > any updates about L... [17:57:20] (03PS1) 10Mwalker: Add Matt Walker's new email address [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150272 [17:57:48] (03Abandoned) 10Mwalker: Add Matt Walker's new email address [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150272 (owner: 10Mwalker) [17:59:56] (03PS1) 10Mwalker: Add mwalker's new email address [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150275 [18:00:00] (03CR) 10Jdlrobson: [C: 032] Add GENDER support to flow-sorting-tooltip [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150233 (https://bugzilla.wikimedia.org/67191) (owner: 10MegaAlex) [18:00:18] (03CR) 10Ori.livneh: [C: 032] Enable mod_headers [vagrant] - 10https://gerrit.wikimedia.org/r/150259 (owner: 10BryanDavis) [18:00:35] (03Merged) 10jenkins-bot: Add GENDER support to flow-sorting-tooltip [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150233 (https://bugzilla.wikimedia.org/67191) (owner: 10MegaAlex) [18:00:52] (03Merged) 10jenkins-bot: Enable mod_headers [vagrant] - 10https://gerrit.wikimedia.org/r/150259 (owner: 10BryanDavis) [18:03:18] (03PS1) 10MegaAlex: Add GENDER support for the current user to notification-* [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/150277 [18:05:01] (03PS1) 10Aaron Schulz: Protect stream_get_contents() from hanging for sanity. [services/jobrunner] - 10https://gerrit.wikimedia.org/r/150279 [18:06:52] 3MediaWiki / 3Skin and page rendering: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - 10https://bugzilla.wikimedia.org/38638 (10Amir E. Aharoni) [18:06:54] 3MediaWiki extensions / 3Popups: Hovercards "monitor" options are unclear and hard to translate - 10https://bugzilla.wikimedia.org/68812 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Hovercards (Popups) has two messages that are hard to translate: * Popups-settings-option-monitor-or-edit * Pop... [18:07:37] (03CR) 10Siebrand: Add GENDER support to flow-sorting-tooltip (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150233 (https://bugzilla.wikimedia.org/67191) (owner: 10MegaAlex) [18:08:46] (03PS6) 10EBernhardson: Fix newly created topics display as unwatched [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150083 [18:08:49] (03PS1) 10BearND: Add gitignore [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/150280 [18:09:30] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/150277 (owner: 10MegaAlex) [18:09:33] (03PS5) 10Jdlrobson: Hygiene: rename title-post to topic-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150140 (owner: 10EBernhardson) [18:09:37] (03CR) 10Jdlrobson: [C: 032] Hygiene: rename title-post to topic-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150140 (owner: 10EBernhardson) [18:09:58] (03PS1) 10Brian Wolff: Revert "Make play button have higher z-index so its clickable." [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/150281 [18:10:51] (03CR) 10Jdlrobson: [C: 032] Fix newly created topics display as unwatched [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150083 (owner: 10EBernhardson) [18:10:58] (03CR) 10Siebrand: [C: 04-1] "Score -1 to indicate there are open questions by Nikerabbit." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/103119 (owner: 10MegaAlex) [18:11:25] (03Merged) 10jenkins-bot: Fix newly created topics display as unwatched [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150083 (owner: 10EBernhardson) [18:11:28] (03Merged) 10jenkins-bot: Hygiene: rename title-post to topic-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150140 (owner: 10EBernhardson) [18:11:49] (03CR) 10Dbrant: [C: 032] Add gitignore [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/150280 (owner: 10BearND) [18:12:12] (03PS2) 10Brian Wolff: Revert "Make play button have higher z-index so its clickable." [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/150281 (https://bugzilla.wikimedia.org/68479) [18:13:36] (03PS40) 10Neilk: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [18:13:39] (03CR) 10jenkins-bot: [V: 04-1] Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [18:13:43] Agh. [18:17:45] (03PS1) 10Florianschmidtwelzow: Insert a difference between exist and non exist page in Special:Search [core] - 10https://gerrit.wikimedia.org/r/150282 [18:19:47] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed. Yay!" [core] - 10https://gerrit.wikimedia.org/r/150254 (https://bugzilla.wikimedia.org/62017) (owner: 10Umherirrender) [18:22:54] (03PS2) 10Florianschmidtwelzow: Insert a difference between exist and non exist page in Special:Search [core] - 10https://gerrit.wikimedia.org/r/150282 [18:23:24] (03CR) 10Siebrand: "i18n/L10n reviewed." (036 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140086 (owner: 10Prtksxna) [18:23:57] (03CR) 10Bartosz Dziewoński: [C: 032] Restore the number of rows shown on Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/150254 (https://bugzilla.wikimedia.org/62017) (owner: 10Umherirrender) [18:23:59] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/149654 (https://bugzilla.wikimedia.org/51971) (owner: 10Deepali) [18:25:14] (03PS3) 10Krinkle: Special:Search: Insert a difference between exist and non exist page [core] - 10https://gerrit.wikimedia.org/r/150282 (owner: 10Florianschmidtwelzow) [18:25:37] (03CR) 10Krinkle: [C: 032] Special:Search: Insert a difference between exist and non exist page [core] - 10https://gerrit.wikimedia.org/r/150282 (owner: 10Florianschmidtwelzow) [18:25:53] (03PS1) 10Brian Wolff: Do not specify any z-index for the play button [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/150285 (https://bugzilla.wikimedia.org/68479) [18:26:07] 3MediaWiki / 3Watchlist: Restore count of rows on watchlist - 10https://bugzilla.wikimedia.org/62017#c4 (10Bartosz Dziewoński) 5PATC>3RESO/FIX Thank you. Let's backport to 1.23 too, shall we? It makes no sense to have just one version without this functionality, and probably complicates the i18n updates. [18:26:26] (03Abandoned) 10Brian Wolff: Revert "Make play button have higher z-index so its clickable." [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/150281 (https://bugzilla.wikimedia.org/68479) (owner: 10Brian Wolff) [18:26:54] (03CR) 10Bartosz Dziewoński: "Let's backport to 1.23 too. This will probably make updating the messages simpler, Siebrand?" [core] - 10https://gerrit.wikimedia.org/r/150254 (https://bugzilla.wikimedia.org/62017) (owner: 10Umherirrender) [18:27:40] (03CR) 10Siebrand: "On 1.23 messages updates: We don't have any L10n backporting in the JSON era yet." [core] - 10https://gerrit.wikimedia.org/r/150254 (https://bugzilla.wikimedia.org/62017) (owner: 10Umherirrender) [18:27:54] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch fatal whilst importing - 10https://bugzilla.wikimedia.org/68814 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3None [2014-07-29 18:20:16] Catchable fatal error: Argument 1 passed to WikiPage::factory() must be an instance of Title, null given, cal... [18:28:19] (03Merged) 10jenkins-bot: Restore the number of rows shown on Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/150254 (https://bugzilla.wikimedia.org/62017) (owner: 10Umherirrender) [18:29:10] (03CR) 10Withoutaname: "@Chad," [core] - 10https://gerrit.wikimedia.org/r/147881 (owner: 10Withoutaname) [18:29:31] (03Merged) 10jenkins-bot: Special:Search: Insert a difference between exist and non exist page [core] - 10https://gerrit.wikimedia.org/r/150282 (owner: 10Florianschmidtwelzow) [18:30:11] (03CR) 10Bartosz Dziewoński: "Hmm. So this is actually impossible to backport without breaking localisation? (Or manually fixing all messages...)" [core] - 10https://gerrit.wikimedia.org/r/150254 (https://bugzilla.wikimedia.org/62017) (owner: 10Umherirrender) [18:30:27] (03CR) 10Bsitu: [C: 04-1] Fix insert order issue with recent change listeners (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150256 (owner: 10EBernhardson) [18:30:52] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch fatal whilst importing - 10https://bugzilla.wikimedia.org/68814#c1 (10Nik Everett) The relevant code is: public static function onAfterImportPage( $title ) { ... array( WikiPage::factory( $title ) ), ... So we're getting onAfterImportP... [18:34:08] 3Wikimedia / 3Bugzilla: Add new default CCs to Wikimedia -> Deployment Tooling and modify description - 10https://bugzilla.wikimedia.org/68799#c7 (10Bryan Davis) (In reply to Greg Grossmeier from comment #4) > > Amir, Brad, Bryan, Roan, and Reedy: Mind being added to the default CC of > Deployment Tooling b... [18:37:19] (03CR) 10Siebrand: Add aliases file for Special:TimezoneSelector (031 comment) [extensions/TimezoneSelector] - 10https://gerrit.wikimedia.org/r/150190 (https://bugzilla.wikimedia.org/68787) (owner: 10MegaAlex) [18:38:45] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/150131 (owner: 10Brian Wolff) [18:39:00] (03PS1) 10Manybubbles: Catch null titles in import hook [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/150289 (https://bugzilla.wikimedia.org/68814) [18:39:02] (03PS2) 10Aaron Schulz: Protect stream_get_contents() from hanging for sanity [services/jobrunner] - 10https://gerrit.wikimedia.org/r/150279 [18:39:46] (03PS1) 10Cscott: MathCoverageTest: encode test file using JSON instead of PHP serialize. [extensions/Math] - 10https://gerrit.wikimedia.org/r/150290 [18:40:08] (03CR) 10Mwalker: [C: 032] Allow customizing post_zip destination [extensions/Collection] - 10https://gerrit.wikimedia.org/r/106847 (owner: 10MaxSem) [18:40:17] (03Merged) 10jenkins-bot: Allow customizing post_zip destination [extensions/Collection] - 10https://gerrit.wikimedia.org/r/106847 (owner: 10MaxSem) [18:41:05] (03CR) 10jenkins-bot: [V: 04-1] MathCoverageTest: encode test file using JSON instead of PHP serialize. [extensions/Math] - 10https://gerrit.wikimedia.org/r/150290 (owner: 10Cscott) [18:42:32] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. Okay. See other comments inline." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/146440 (https://bugzilla.wikimedia.org/4488) (owner: 10Ebe123) [18:43:45] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149210 (owner: 10Werdna) [18:44:06] (03PS15) 10Florianschmidtwelzow: Create preference to watchlist pages after rollbacking [core] - 10https://gerrit.wikimedia.org/r/146440 (https://bugzilla.wikimedia.org/4488) (owner: 10Ebe123) [18:47:30] (03CR) 10Gergő Tisza: "This seems to be based on misconceptions of how z-index works. A child element will never be positioned below the parent just because it h" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/150285 (https://bugzilla.wikimedia.org/68479) (owner: 10Brian Wolff) [18:48:05] ori: can you please come up to the 6th floor? :) [18:48:06] (03CR) 10Brian Wolff: "Well be that as it may, When z-index was set to 1, the button was unclickable" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/150285 (https://bugzilla.wikimedia.org/68479) (owner: 10Brian Wolff) [18:48:29] (03CR) 10Siebrand: [C: 04-1] Remove/deprecate various error functions in OutputPage (032 comments) [core] - 10https://gerrit.wikimedia.org/r/150171 (owner: 10Withoutaname) [18:48:31] rfarrand: yep [18:49:01] tgr: Its not exactly positioned under, it just not longer responds to hover or click events [18:51:13] (03CR) 10Helder.wiki: Import external metadata from Wikidata (031 comment) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/149654 (https://bugzilla.wikimedia.org/51971) (owner: 10Deepali) [18:52:30] (03PS2) 10Withoutaname: Remove functions deprecated since 1.19 from EditPage.php [core] - 10https://gerrit.wikimedia.org/r/148276 [18:53:12] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (034 comments) [extensions/OnlineStatus] - 10https://gerrit.wikimedia.org/r/150154 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [18:56:17] (03CR) 10Brian Wolff: Add Special:MediaStatistics page for file type stats (031 comment) [core] - 10https://gerrit.wikimedia.org/r/150131 (owner: 10Brian Wolff) [18:56:51] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/150152 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [18:58:16] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Quantcast] - 10https://gerrit.wikimedia.org/r/150019 (https://bugzilla.wikimedia.org/68750) (owner: 10Withoutaname) [18:58:37] (03PS1) 10Jforrester: Update VisualEditor to Ibf16d63 [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150293 [18:59:19] (03CR) 10PleaseStand: "> Then does that mean we should remove the function_exists check for version_compare?" [core] - 10https://gerrit.wikimedia.org/r/147881 (owner: 10Withoutaname) [18:59:39] 3Wikimedia / 3General/Unknown: Wikivoyage displays "Fatal exception of type MWException" - 10https://bugzilla.wikimedia.org/68815 (10atsirlin) 3UNCO p:3Unprio s:3critic a:3None All Wikivoyage wiki's display "Fatal exception of type MWException" when I try to log in. Anonymous browsing is OK, though.... [18:59:55] Hey all, I'm running AV for the HHVM talk today. Please ping me with any comments, including "it's working fine" comments. :-) [19:00:09] AaronSchulz: I guess 68815 is what you saw... [19:00:29] cndiv: hasn't started yet, right? [19:00:37] greg-g: no, about 3 minutes. [19:00:43] kk [19:00:52] greg-g: plus the google-delay, if you're watching the stream, of course. [19:01:08] of course [19:01:29] (03PS2) 10Florianschmidtwelzow: Fix some wfMsg* [extensions/OnlineStatus] - 10https://gerrit.wikimedia.org/r/150154 (https://bugzilla.wikimedia.org/68750) [19:01:38] (03CR) 10Physikerwelt: "reading the json file is much easier. My only fear is that people start to modify the file manually, without to look at the output." [extensions/Math] - 10https://gerrit.wikimedia.org/r/150290 (owner: 10Cscott) [19:01:57] ori, I can't see the streaming. :-( [19:01:58] 3Wikimedia / 3General/Unknown: Wikivoyage displays "Fatal exception of type MWException" - 10https://bugzilla.wikimedia.org/68815#c1 (10Sam Reed (reedy)) 2014-07-29 19:01:10 mw1166 enwikivoyage: [2e0d46e3] /wiki/Special:CentralLogin/complete?token=d33043fa0c5a728c83cec79764df8521 Exception from line 4186 o... [19:02:36] qchris, are you in HHVM? [19:02:57] leila: Nope. Still plain php. [19:03:06] (03CR) 10Siebrand: "@Nemo_bis: Excellent that this bug report was made. A while ago I did a lot of work on that for WMF and twn deployed extensions. It's a lo" [core] - 10https://gerrit.wikimedia.org/r/141906 (owner: 10Withoutaname) [19:03:06] ;p [19:03:24] AaronSchulz: ULS? [19:03:37] any plans to join them, qchris? [19:03:45] (03CR) 10Cscott: "We've been using a json file of parsertest results (exceptions, really) in parsoid for a while, and haven't had an issue with manual edits" [extensions/Math] - 10https://gerrit.wikimedia.org/r/150290 (owner: 10Cscott) [19:03:51] For some reason the streaming link doesn't work for me. [19:03:58] leila: Join them ... mhmm ... sounds like I am missing a meeting :-) [19:04:23] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/150128 (owner: 10Legoktm) [19:04:28] (03PS1) 10Jforrester: Update VisualEditor to I90ab7de [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150294 [19:05:05] robla: remember that you can't connect a hangout on air to a calendar event [19:05:08] qchris, this one: https://plus.google.com/events/cp5mjf6jrihevtdje8lmu5hvm1k [19:05:18] robla: so the one that's there is automatic, and is incorrect [19:05:25] if you are following the HHVM (by Brett from Facebook) talk you can ask questions here (please direct them to me) and I will ask Brett [19:05:29] the right one is in the annoucement email [19:05:32] rfarrand: Thanks! [19:05:41] thanks, rfarrand! [19:06:00] (03PS1) 10MegaAlex: Small cleanup [extensions/TimezoneSelector] - 10https://gerrit.wikimedia.org/r/150295 [19:06:12] rfarrand: 22 viewers now, looks like they found it. [19:06:27] any issues with sound or video please direct them to cndiv [19:06:29] leila: works for me. [19:06:37] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/OnlineStatus] - 10https://gerrit.wikimedia.org/r/150154 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [19:06:42] yup, right now works for me, too, thanks qchris. [19:06:49] I'd also just like to know the sound is fine. [19:07:00] cndiv: sound is great! [19:07:05] leila: thanks! [19:07:06] (03PS2) 10Brian Wolff: Add Special:MediaStatistics page for file type stats [core] - 10https://gerrit.wikimedia.org/r/150131 [19:07:48] (03CR) 10Nemo bis: "Siebrand, yes, indeed! It's thanks to your example that I know it's possible. By distributing the work a bit more, we should manage." [core] - 10https://gerrit.wikimedia.org/r/141906 (owner: 10Withoutaname) [19:07:57] (03CR) 10Siebrand: Add Special:MediaStatistics page for file type stats (031 comment) [core] - 10https://gerrit.wikimedia.org/r/150131 (owner: 10Brian Wolff) [19:08:08] (03CR) 10Withoutaname: "Just curious Siebrand, do you have a pointer to the deprecation policy? Because AFAIK, mw.org says it's done ad-hoc. https://www.mediawiki" [core] - 10https://gerrit.wikimedia.org/r/150171 (owner: 10Withoutaname) [19:08:27] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/150131 (owner: 10Brian Wolff) [19:10:27] (03CR) 10Siebrand: "Sorry you're right about slapping on wfDeprecated. I missed the second parameter." [core] - 10https://gerrit.wikimedia.org/r/150171 (owner: 10Withoutaname) [19:11:06] (03CR) 10Siebrand: Remove/deprecate various error functions in OutputPage (031 comment) [core] - 10https://gerrit.wikimedia.org/r/150171 (owner: 10Withoutaname) [19:11:19] (03CR) 10Florianschmidtwelzow: Fix some wfMsg* (031 comment) [extensions/OnlineStatus] - 10https://gerrit.wikimedia.org/r/150154 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [19:11:24] (03CR) 10Brian Wolff: Add Special:MediaStatistics page for file type stats (031 comment) [core] - 10https://gerrit.wikimedia.org/r/150131 (owner: 10Brian Wolff) [19:11:28] (03PS3) 10Florianschmidtwelzow: Fix some wfMsg* [extensions/OnlineStatus] - 10https://gerrit.wikimedia.org/r/150154 (https://bugzilla.wikimedia.org/68750) [19:12:15] (03CR) 10Siebrand: [C: 032 V: 032] "Thanks" [extensions/TimezoneSelector] - 10https://gerrit.wikimedia.org/r/150295 (owner: 10MegaAlex) [19:13:20] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/OnlineStatus] - 10https://gerrit.wikimedia.org/r/150154 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [19:13:29] (03PS1) 10Jforrester: Add new extension repo: CiteThisPage [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/150298 [19:13:33] (03CR) 10Florianschmidtwelzow: Fix some wfMsg* (031 comment) [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/150152 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [19:13:51] (03CR) 10Siebrand: Add Special:MediaStatistics page for file type stats (031 comment) [core] - 10https://gerrit.wikimedia.org/r/150131 (owner: 10Brian Wolff) [19:15:28] (03PS9) 10Jforrester: Create a demos-publish task for OOjs UI [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125543 [19:17:05] (03PS4) 10Jforrester: [WIP] Generic banana linter job template [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/129826 (https://bugzilla.wikimedia.org/64045) [19:17:14] (03CR) 10Florianschmidtwelzow: "> You may want to request Jenkins jobs to be set up for this repository." [extensions/OnlineStatus] - 10https://gerrit.wikimedia.org/r/150154 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [19:17:43] (03PS3) 10Florianschmidtwelzow: Fix some wfMsg* [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/150152 (https://bugzilla.wikimedia.org/68750) [19:17:55] 3Wikimedia / 3General/Unknown: Wikivoyage displays "Fatal exception of type MWException" - 10https://bugzilla.wikimedia.org/68815#c2 (10Sam Reed (reedy)) So it's wmgExtraLanguageNames entries for Wikivoyage. If you remove WikiPedia, it then fails for Radreise-Wiki... [19:18:21] (03PS3) 10Jdlrobson: Fix collapsing via topics collapsing button [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150089 (https://bugzilla.wikimedia.org/68773) [19:18:26] (03PS2) 10Withoutaname: Remove/deprecate various error functions in OutputPage [core] - 10https://gerrit.wikimedia.org/r/150171 [19:18:31] (03CR) 10Jdlrobson: Fix collapsing via topics collapsing button (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150089 (https://bugzilla.wikimedia.org/68773) (owner: 10Jdlrobson) [19:19:48] (03CR) 10Siebrand: [C: 032] Make upload_source_file and upload_source_url more specific [core] - 10https://gerrit.wikimedia.org/r/150065 (owner: 10Brian Wolff) [19:19:59] (03CR) 10Brian Wolff: "PS2 (And soon PS3): i18n fixes" [core] - 10https://gerrit.wikimedia.org/r/150131 (owner: 10Brian Wolff) [19:21:09] (03CR) 10Siebrand: "Ah. No. This should be fine, then." [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/149805 (owner: 10Shirayuki) [19:21:26] (03CR) 10Siebrand: [C: 032] i18n: plural support for securepoll-create-layout-election_dates [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/149805 (owner: 10Shirayuki) [19:21:35] (03Merged) 10jenkins-bot: i18n: plural support for securepoll-create-layout-election_dates [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/149805 (owner: 10Shirayuki) [19:22:04] brion: no, we don't run in athoritative mode yet [19:22:11] darn [19:22:11] (03PS3) 10Brian Wolff: Add Special:MediaStatistics page for file type stats [core] - 10https://gerrit.wikimedia.org/r/150131 [19:22:14] kill the eval()s! [19:22:40] brion: needs some big changes to how we deploy code, at a basic level [19:22:46] ahh :( [19:22:48] (03Merged) 10jenkins-bot: Make upload_source_file and upload_source_url more specific [core] - 10https://gerrit.wikimedia.org/r/150065 (owner: 10Brian Wolff) [19:23:18] (03PS1) 10MegaAlex: Simplify GENDER handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150300 [19:24:07] 3Wikimedia / 3General/Unknown: Wikivoyage displays "Fatal exception of type MWException" - 10https://bugzilla.wikimedia.org/68815#c3 (10atsirlin) I am not sure if is related or not, but an important feature of today's MediaWiki update is the possibility to put inter-project links into the sidebar. However, W... [19:24:52] any worry about memory leaks in job runner in server mode? doesn't the parser leak? [19:24:55] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/150131 (owner: 10Brian Wolff) [19:25:14] manybubbles: do you want me to ask that when he stops for questions? [19:25:14] (03PS7) 10Jdlrobson: Hide load more button with JavaScript when infinite scroll supports [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145470 [19:25:23] rfarrand: oh sure! [19:26:00] (03CR) 10Siebrand: Add Special:MediaStatistics page for file type stats (031 comment) [core] - 10https://gerrit.wikimedia.org/r/150131 (owner: 10Brian Wolff) [19:26:36] manybubbles: np [19:26:39] manybubbles: we don't have a GC, so if you have cycles it'll leak ; otherwise, we're pretty good. I've got a few scripts that deal with a *lot* of data that have been running isnce april [19:26:43] (03PS1) 10Aaron Schulz: Only define $handlerFunc when needed [services/jobrunner] - 10https://gerrit.wikimedia.org/r/150302 [19:26:45] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/150171 (owner: 10Withoutaname) [19:27:18] fred: thanks. I'm pretty sure we'll hit problems where we assumed stuff was short lived [19:27:23] 3Wikimedia / 3General/Unknown: Wikivoyage displays "Fatal exception of type MWException" - 10https://bugzilla.wikimedia.org/68815#c5 (10Daniel Zahn) 5PATC>3UNCO did you already disable it? because i don't see the error after logging in.. [19:27:34] manybubbles: does that answer your question or would you still like me to ask? [19:27:45] (03PS2) 10Jdlrobson: Simplify GENDER handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150300 (owner: 10MegaAlex) [19:27:57] probably should still ask because I'm pretty sure the parser _does_ have cycles [19:28:03] manybubbles: sure thing [19:28:04] not 100% sure though [19:28:05] thanks [19:28:08] Remote stream viewers, please ping rfarrand with your questions. [19:28:10] (03CR) 10Siebrand: "See bug 64990 as an example." [extensions/OnlineStatus] - 10https://gerrit.wikimedia.org/r/150154 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [19:28:12] (03CR) 10Jdlrobson: "Please explain what/why you are changing things in the commit message. Thanks!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150300 (owner: 10MegaAlex) [19:28:53] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/150152 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [19:29:14] (03CR) 10Krinkle: [C: 032] "Compiled and created in Jenkins (not yet activated in Zuul) mwext-CiteThisPage-jslint, mwext-CiteThisPage-lint, mwext-CiteThisPage-phpcs-" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/150298 (owner: 10Jforrester) [19:29:17] (03CR) 10Brian Wolff: Add Special:MediaStatistics page for file type stats (031 comment) [core] - 10https://gerrit.wikimedia.org/r/150131 (owner: 10Brian Wolff) [19:29:22] rfarrand: when HHVM gets 'really slow' for dynamic features, does that mean slower than default PHP would run, or just slower than HHVM could run? [19:30:18] ottomata: will ask :) [19:30:30] danke! [19:30:35] (03Merged) 10jenkins-bot: Add new extension repo: CiteThisPage [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/150298 (owner: 10Jforrester) [19:30:58] (03PS2) 10Umherirrender: Add parser tests about building table with {{!}} [core] - 10https://gerrit.wikimedia.org/r/146732 [19:30:58] rfarrand: answers my question [19:31:00] rfarrand: re current quesiton: there is an option in the ini file that emulates repo authorotative mode's restricitons [19:31:04] (03PS4) 10Jdlrobson: Fix collapsing via topics collapsing button [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150089 (https://bugzilla.wikimedia.org/68773) [19:31:12] so, turns off the dynamic stuff [19:31:22] (03PS1) 10Krinkle: Enable CiteThisPage jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150303 [19:31:26] <_joe_> fred: good one [19:31:29] (03CR) 10Krinkle: "Enabled in I7f80ee0b85d29791b7." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/150298 (owner: 10Jforrester) [19:32:01] (03CR) 10Umherirrender: "Removed the second part of the tests, so only the build of table with {{!}} is tested. This is not tested in any other parser test." [core] - 10https://gerrit.wikimedia.org/r/146732 (owner: 10Umherirrender) [19:32:30] (03PS2) 10Krinkle: Enable CiteThisPage jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150303 [19:32:37] 3Wikimedia / 3General/Unknown: Wikivoyage displays "Fatal exception of type MWException" - 10https://bugzilla.wikimedia.org/68815#c6 (10Sam Reed (reedy)) (In reply to atsirlin from comment #3) > I am not sure if is related or not, but an important feature of today's > MediaWiki update is the possibility to p... [19:32:49] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150300 (owner: 10MegaAlex) [19:32:51] 3QRpedia: QRpedia should point to Wikidata entity - 10https://bugzilla.wikimedia.org/63463#c2 (10Dmytro Dziuma) I would add that in such a case the generated QR code would be much smaller especially comparing to long non-Latin article names. [19:33:07] (03CR) 10Jdlrobson: Hide load more button with JavaScript when infinite scroll supports (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145470 (owner: 10Jdlrobson) [19:34:15] _joe_: rfarrand: if you could pass this on to whoever asked about warniungs for dynamic stuff: set hhvm.authoritative_mode=true in your ini file. This is badly named - it's not the same as hhvm.repo.authoritative :p [19:34:59] spagewmf: ^^^ [19:35:20] any more qs? [19:35:22] thanks rachel :) [19:35:41] ottomata: np [19:36:39] last chance! [19:37:05] MatmaRex: last chance to review https://gerrit.wikimedia.org/r/#/c/148144/ - i'm gonna merge that soon [19:38:15] ugh [19:38:17] let's look [19:38:53] MatmaRex: :) [19:39:08] 3Wikimedia / 3General/Unknown: Wikivoyage displays "Fatal exception of type MWException" - 10https://bugzilla.wikimedia.org/68815#c7 (10Sam Reed (reedy)) (In reply to Daniel Zahn from comment #5) > did you already disable it? because i don't see the error after logging in.. Yeah, wikivoyages were reverted t... [19:39:10] MatmaRex: i still need to rebase the commit notes [19:39:18] why is dan laughing so much [19:39:22] 3MediaWiki-Vagrant: xdebug is broken on vagrant - 10https://bugzilla.wikimedia.org/67719#c5 (10Bryan Davis) In the HHVM talk that Brett gave today he said that Facebook has an intern working on xdebug protocol support. "If it goes well you should see it in a few months." [19:39:41] shahyar: ENHANCE on the screen [19:39:51] jdlrobson2: are you using https://github.com/MatmaRex/mediawikireleasenotes-driver already? :) [19:40:01] MatmaRex: I’m trying to reticulate the splines on his screen [19:40:38] MatmaRex: nope.. i try to avoid RELEASE NOTES [19:40:41] haha [19:40:49] i think they could be done a lot better though.. [19:41:04] jdlrobson2: heh, start using it then :) [19:41:18] Gerrit shouldn't be hitting merge conflicts on something like release notes [19:41:37] Question about HHVM: Do you have a favorite HHVM-exclusive feature? [19:41:48] <_joe_> rfarrand: I have a question: did they estimated how many servers less they needed thanks to using HHVM as opposed to standard Zend PHP? [19:41:54] jdlrobson2: it should be possible to implement this in gerrit, we just have to ask our resident gerrit/java people to do it [19:41:59] OH WAIT there's no one like that [19:42:26] joe [19:42:42] _joe_: will ask [19:42:49] <_joe_> thanks :) [19:42:53] rfarrand: Seen my question? [19:43:01] and i am not quite determined enough to downloads gigabytes of ides and libraries and deal with multiple upstreams and comb through megabytes of crappy java code to do it myself [19:43:04] MatmaRex: I mean, ^d. But he's busy. [19:43:08] 3MediaWiki / 3Maintenance scripts: deleteOldRevisions.php deletes content text from current revisions - 10https://bugzilla.wikimedia.org/66615#c8 (10Jesús Martínez Novo (Ciencia Al Poder)) p:5Lowest>3High s:5normal>3major I'm still pending to have time to test this, but if it can delete content from... [19:43:23] Thiemo_WMDE: will ask [19:43:30] thanks. [19:43:39] <^d> marktraceur: Upstream gerrit? Blech. [19:43:49] Exactly. [19:44:08] <^d> I got 99 problems but dealing with their shenanigans ain't one. [19:44:30] be phabulous [19:45:07] 3Wikimedia / 3General/Unknown: Wikivoyage displays "Fatal exception of type MWException" - 10https://bugzilla.wikimedia.org/68815#c8 (10atsirlin) I meant this one: https://www.mediawiki.org/wiki/Beta_Features/Other_projects_sidebar but well, I am not sure if it was included in the current release because I... [19:47:40] https://github.com/facebook/xhp < works in HHVM, also available as an extension for PHP5 [19:48:32] fred: nifty! [19:48:55] * ori stars. [19:49:39] 3Wikimedia / 3Site requests: Investigate the creation of a wiki for the dev community that is organizing around Labs - 10https://bugzilla.wikimedia.org/68818 (10Marc A. Pelletier) 3NEW p:3Unprio s:3normal a:3None A repeated request I have had from Labs users (especially Tool Labs) is to have a wiki d... [19:49:42] MatmaRex: where do you put the driver? I think I put it in core once and a rebase overwrote it [19:50:36] withoutaname: download the mediawikireleasenotes-driver-installer.sh file and run it once, it installs itself in the .git directory [19:50:58] withoutaname: all future rebases will use it automatically [19:51:15] questions about hack? [19:52:53] (03CR) 10Florianschmidtwelzow: "perfect, thanks :)" [extensions/OnlineStatus] - 10https://gerrit.wikimedia.org/r/150154 (https://bugzilla.wikimedia.org/68750) (owner: 10Florianschmidtwelzow) [19:52:54] (03CR) 10Krinkle: [C: 032] Enable CiteThisPage jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150303 (owner: 10Krinkle) [19:52:57] (03PS6) 10Jdlrobson: Make UserNotLoggedIn redirect to login page [core] - 10https://gerrit.wikimedia.org/r/148144 (https://bugzilla.wikimedia.org/15484) (owner: 10Parent5446) [19:52:59] (03Merged) 10jenkins-bot: Enable CiteThisPage jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150303 (owner: 10Krinkle) [19:53:04] (03CR) 10jenkins-bot: [V: 04-1] Make UserNotLoggedIn redirect to login page [core] - 10https://gerrit.wikimedia.org/r/148144 (https://bugzilla.wikimedia.org/15484) (owner: 10Parent5446) [19:53:06] (03PS7) 10Parent5446: Make UserNotLoggedIn redirect to login page [core] - 10https://gerrit.wikimedia.org/r/148144 (https://bugzilla.wikimedia.org/15484) [19:53:11] (03CR) 10Parent5446: "PS7: Rebase" [core] - 10https://gerrit.wikimedia.org/r/148144 (https://bugzilla.wikimedia.org/15484) (owner: 10Parent5446) [19:53:13] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/134789 (owner: 10Parent5446) [19:53:16] (03PS4) 10Parent5446: Added Html::radio, Html::check, and Html::label. [core] - 10https://gerrit.wikimedia.org/r/52645 [19:53:23] (03CR) 10Jdlrobson: [C: 031] "Giving Matmarex a little more time before I +2." [core] - 10https://gerrit.wikimedia.org/r/148144 (https://bugzilla.wikimedia.org/15484) (owner: 10Parent5446) [19:53:27] (03CR) 10Parent5446: [C: 032] Unsetting the email address for a user when the email address is invalidated. [core] - 10https://gerrit.wikimedia.org/r/61907 (owner: 10Pgehres) [19:53:32] (03PS2) 10Jforrester: Rename to "CiteThisPage" and make Special:CiteThisPage the primary location [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/149592 [19:53:34] (03CR) 10jenkins-bot: [V: 04-1] Rename to "CiteThisPage" and make Special:CiteThisPage the primary location [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/149592 (owner: 10Jforrester) [19:53:36] (03CR) 10Nikerabbit: [C: 031] "Tested quickly on Translate, seems still to work and if it really is faster, that will be nice for https://www.mediawiki.org/wiki/Special:" [core] - 10https://gerrit.wikimedia.org/r/139699 (owner: 10Paladox) [19:53:37] (03PS2) 10Parent5446: Adding a smaller version of existing close icon [core] - 10https://gerrit.wikimedia.org/r/62237 (https://bugzilla.wikimedia.org/48067) (owner: 10Kaldari) [19:53:40] (03PS15) 10Jdlrobson: Add mw-ui-checkbox [core] - 10https://gerrit.wikimedia.org/r/149121 [19:53:41] thanks for organizing this, y'all! [19:53:46] (03Merged) 10jenkins-bot: Unsetting the email address for a user when the email address is invalidated. [core] - 10https://gerrit.wikimedia.org/r/61907 (owner: 10Pgehres) [19:53:47] (03PS16) 10Jdlrobson: Add mw-ui-checkbox [core] - 10https://gerrit.wikimedia.org/r/149121 [19:53:49] heh, grrrit-wm didn't lose messages again. yay [19:53:50] leila np :) [19:54:00] see you around. [19:54:09] busy review time [19:54:21] its like java's generics [19:54:22] Vulpix: nah, grrrit-wm just died, I restarted it, and it's catching up [19:54:31] darn! :P [19:55:21] I missed parts of the presentation so this might been already addressed... I am wondering whether the hhvm startup will get faster, or are we going to see it worked around by calling hhvm via fastcgi instead of command line scripts? [19:55:39] rfarrand: ask him how it's been being at the WMF for some time, compared to how different it is to FB? :) [19:55:51] rfarrand: unless I'm lagged and the thing is done... [19:56:23] just finished :D [19:56:29] brion: ah, fine :) [19:56:34] YuviPanda: sorry Yuvi, all done :) [19:56:44] he is here at WMF for two more weeks you should email him [19:56:45] Nikerabbit: working around [19:56:52] rfarrand: 'tis ok. thanks for doing the IRC relay [19:57:08] Nikerabbit: for job runner we've moved it to a server that we hit with requests to make it pop jobs [19:57:38] manybubbles: yes I've seen that... I haven't yet had time to look whether I could use it translatewiki.net or is it WMF specific [19:57:58] cndiv: rfarrand: thanks! [19:57:59] Nikerabbit: I'm not sure either - I believe its set up in vagrant for what that is worth [19:58:23] 3MediaWiki / 3General/Unknown: The page http://myMediawiki.dgfip/wt/index.php/Special:Pages_speciales crashes - 10https://bugzilla.wikimedia.org/68212#c3 (10макс) its my problem too - fatal error: Possible integer overflow in memory allocation (2147483648 * 4 + 0) in mydomain/http/includes/User.php on line 2... [19:58:30] robla: no prob [19:58:32] (03CR) 10Parent5446: "@Asher, your query does not include the page_namespace condition, which is very important:" [core] - 10https://gerrit.wikimedia.org/r/66003 (https://bugzilla.wikimedia.org/48745) (owner: 10Parent5446) [19:58:45] Nikerabbit: turning off the jit saves a lot of the startup time. We've been discusisng a few options (eg jit off for the first 5 seconds or something), but haven't came to a decision yet. Lots of different uses to take into account [19:58:53] (03PS17) 10Jdlrobson: Add mw-ui-checkbox [core] - 10https://gerrit.wikimedia.org/r/149121 [19:58:55] (03PS4) 10Jdlrobson: Make Special:UserLogin form use mw-ui-checkbox [core] - 10https://gerrit.wikimedia.org/r/149476 [19:59:38] fred: with -vEval.Jit=0? [20:00:00] yep, or hhvm.jit=0 in your ini [20:02:20] (03CR) 10jenkins-bot: [V: 04-1] Add mw-ui-checkbox [core] - 10https://gerrit.wikimedia.org/r/149121 (owner: 10Jdlrobson) [20:02:23] (03Abandoned) 10Parent5446: Fixed EZConnect string regex in OracleInstaller class. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/66324 (owner: 10Freakolowsky) [20:02:46] (03PS2) 10Jdlrobson: Use mw-ui-input core module for inputs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149174 [20:03:39] 3Wikimedia / 3Site requests: Investigate the creation of a wiki for the dev community that is organizing around Labs - 10https://bugzilla.wikimedia.org/68818#c1 (10Chad H.) (In reply to Marc A. Pelletier from comment #0) > * Search is difficult to make meaningful, as it generally cannot sort > between the tw... [20:04:20] (03CR) 10Parent5446: [C: 032] Disallow top level domains in Cookie::validateCookieDomain(). [core] - 10https://gerrit.wikimedia.org/r/24636 (owner: 10Tim Landscheidt) [20:04:39] rfarrand, cndiv: thanks so much for your help with the brown bag! [20:04:51] ori: no problem, thanks for your help too [20:05:03] ori: No problem! Good turnout, too. There were 30+ watching the stream, in addition to the people in the room. [20:05:33] woot!:) [20:05:37] 3Wikimedia / 3General/Unknown: Wikivoyage displays "Fatal exception of type MWException" - 10https://bugzilla.wikimedia.org/68815#c9 (10Sam Reed (reedy)) s:5critic>3major (In reply to atsirlin from comment #8) > I meant this one: > https://www.mediawiki.org/wiki/Beta_Features/Other_projects_sidebar > >... [20:05:53] greg-g: https://bugzilla.wikimedia.org/show_bug.cgi?id=68815 if you haven't seen it already [20:06:56] (03CR) 10Parent5446: [C: 032] Move code to load User data from cache out of loadFromId [core] - 10https://gerrit.wikimedia.org/r/100371 (owner: 10Matthias Mullie) [20:07:04] (03CR) 10Parent5446: "Needs rebase" [core] - 10https://gerrit.wikimedia.org/r/100371 (owner: 10Matthias Mullie) [20:07:59] (03Merged) 10jenkins-bot: Disallow top level domains in Cookie::validateCookieDomain(). [core] - 10https://gerrit.wikimedia.org/r/24636 (owner: 10Tim Landscheidt) [20:08:01] (03CR) 10jenkins-bot: [V: 04-1] Move code to load User data from cache out of loadFromId [core] - 10https://gerrit.wikimedia.org/r/100371 (owner: 10Matthias Mullie) [20:11:10] 3Wikimedia / 3Logstash: Automatically log fatals/exceptions into BZ with stack traces - 10https://bugzilla.wikimedia.org/68820 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3enhanc a:3None It'd be great if fatals and exceptions were automagically logged into BZ with stack traces. Obviously just logging ever... [20:11:52] 3Wikimedia / 3Logstash: Automatically log fatals/exceptions into BZ with stack traces - 10https://bugzilla.wikimedia.org/68820#c1 (10Sam Reed (reedy)) p:5Unprio>3Low Dropping priority. It'd be nice to have, but it really isn't urgent [20:12:10] (03PS1) 10Kaldari: Update MobileFrontend [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150373 [20:13:25] (03PS2) 10Parent5446: Added NUMBEROFSUBPAGES core parser function [core] - 10https://gerrit.wikimedia.org/r/66003 (https://bugzilla.wikimedia.org/48745) [20:13:36] 3Wikimedia / 3Logstash: Automatically log fatals/exceptions into BZ with stack traces - 10https://bugzilla.wikimedia.org/68820#c2 (10Sam Reed (reedy)) Suggested tool is https://sentry.readthedocs.org/en/latest/ [20:13:55] (03CR) 10Parent5446: "PS2: Rebase" [core] - 10https://gerrit.wikimedia.org/r/66003 (https://bugzilla.wikimedia.org/48745) (owner: 10Parent5446) [20:17:13] (03CR) 10Chad: [C: 032] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/150240 (owner: 10Parent5446) [20:18:37] 3MediaWiki extensions / 3ProofreadPage: Blank entry in Special:IndexPages - 10https://bugzilla.wikimedia.org/32590#c9 (10George Orwell III) (In reply to Bawolff (Brian Wolff) from comment #8) > Is this still an issue. I don't see blank lines in the links given above. Yup. I can consistently replicate the bl... [20:19:33] (03CR) 10Bartosz Dziewoński: "Looks good (code and behavior :) ), but two things:" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/148144 (https://bugzilla.wikimedia.org/15484) (owner: 10Parent5446) [20:19:49] (03PS1) 10EBernhardson: Hygine: Class comments for Flow\\Data\\* [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150375 [20:20:21] (03Merged) 10jenkins-bot: Added explicit type-cast to hash_pbkdf2 [core] - 10https://gerrit.wikimedia.org/r/150240 (owner: 10Parent5446) [20:21:57] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(-1 just in case, I'll +1 if you fix this or acknowledge that you thought about it and decided not to :) )" [core] - 10https://gerrit.wikimedia.org/r/148144 (https://bugzilla.wikimedia.org/15484) (owner: 10Parent5446) [20:22:12] https://gerrit.wikimedia.org/r/#/c/148276/ can this be merged too? [20:23:17] (03PS1) 10Brian Wolff: checkTemporaryPassword should call loadPasswords() first [core] - 10https://gerrit.wikimedia.org/r/150379 [20:25:31] (03CR) 10SG: [C: 031] Hide Vector watch star on flow boards [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147344 (owner: 10Jdlrobson) [20:26:44] (03CR) 10Withoutaname: Added password hashing API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/77645 (https://bugzilla.wikimedia.org/54948) (owner: 10Parent5446) [20:29:03] (03CR) 10Bartosz Dziewoński: "Another issue: when you try to view, say, Watchlist when logged out; then log in in another tab; you have no way to proceed to watchlist f" [core] - 10https://gerrit.wikimedia.org/r/148144 (https://bugzilla.wikimedia.org/15484) (owner: 10Parent5446) [20:29:12] (03PS3) 10Aaron Schulz: Clean up user version constants [core] - 10https://gerrit.wikimedia.org/r/148905 (owner: 10Chad) [20:30:22] jdlrobson: sorry it took me this long to review that, commented now [20:30:34] MatmaRex: np i appreciate your thoughtful feedback [20:30:37] 3Wikimedia / 3General/Unknown: Wikivoyage displays "Fatal exception of type MWException" - 10https://bugzilla.wikimedia.org/68815 (10Greg Grossmeier) 5UNCO>3NEW p:5Unprio>3High [20:30:42] (03PS8) 10Bsitu: Replace EchoBackend with mappers and gateway [extensions/Echo] - 10https://gerrit.wikimedia.org/r/147369 [20:30:58] (03PS1) 10Dbrant: Add styles for disambiguation button. [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/150380 [20:31:12] (03CR) 10Chad: [C: 032] Clean up search results if scrolled of the end [core] - 10https://gerrit.wikimedia.org/r/150251 (https://bugzilla.wikimedia.org/68783) (owner: 10Manybubbles) [20:31:19] MatmaRex: did you see my comment on https://gerrit.wikimedia.org/r/#/c/148508/ [20:31:23] did you have any thoughts around that? [20:31:36] Reedy: thanks [20:31:36] 3Wikimedia / 3General/Unknown: Wikivoyage displays "Fatal exception of type MWException" - 10https://bugzilla.wikimedia.org/68815#c10 (10Greg Grossmeier) So, to clarify, the "In Other Projects Sidebar" is already in use on Wikivoyage, the target for later this month is for all wikis. Katie/Marius: thoughts... [20:31:41] (03CR) 10Chad: [C: 032] Catch null titles in import hook [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/150289 (https://bugzilla.wikimedia.org/68814) (owner: 10Manybubbles) [20:31:54] (03Merged) 10jenkins-bot: Catch null titles in import hook [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/150289 (https://bugzilla.wikimedia.org/68814) (owner: 10Manybubbles) [20:32:42] jdlrobson: was meaning to reply later today, but basically this is the minimal code necessary for a "fully-featured" skin [20:33:00] jdlrobson: most of it is to generate the navigation menu :/ [20:33:04] MatmaRex: surely not.. i was expecting a minimal skin would just have a heading and content (no navigation) [20:33:25] MatmaRex: the purpose of the fallback skin is purely to tell a user to install a skin yes? [20:33:37] in which case i would argue a navigation menu is unnecessary. [20:33:57] anyway we can have that conversation on irc / gerrit / email whatever you prefer realise you might not be in that headspace now :) [20:34:16] (03Merged) 10jenkins-bot: Clean up search results if scrolled of the end [core] - 10https://gerrit.wikimedia.org/r/150251 (https://bugzilla.wikimedia.org/68783) (owner: 10Manybubbles) [20:34:35] jdlrobson: yeah i guess. still seems like a good idea to include the basic functionality for some poor hapless developer wanting to very quickly try out a patch without installing skins, or some poor hapless site admin who wants to figure out the MW version of their newly-broken wiki or something [20:35:16] (03PS1) 10Gergő Tisza: Update MultimediaViewer extension [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150381 [20:35:17] MatmaRex: i don't think we should optimise for that use case. Seems like over engineering. We want someone to install a skin pronto. [20:35:20] (03CR) 10Aaron Schulz: [C: 032] Clean up user version constants [core] - 10https://gerrit.wikimedia.org/r/148905 (owner: 10Chad) [20:35:21] jdlrobson: meh, i'm not doing anything right now (and i have things i should be doing), might as well let you pull me into doing something useful ;) [20:35:23] (03PS6) 10Cscott: Render attribution page [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148611 (owner: 10Mwalker) [20:35:25] (03PS2) 10Cscott: Update test cases with attribution information in the bundle. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/149252 [20:35:27] (03PS1) 10Cscott: Always use bidi, even if the wiki is "in theory" only LTR. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/150382 [20:35:28] we don't want to see mediawiki instances where they lazily didn't install one :) [20:35:47] it might become the new monobook! lol :) [20:35:48] jdlrobson: the warning message is literally a fullscreen yellow-orange box [20:35:57] (and you can't turn it off right now) [20:35:59] is defaultsettings/localsettings necessary for mediawiki [20:36:02] that should convince everyone :P [20:36:15] (03PS1) 10EBernhardson: Cleanup failure case for moderated topic view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150383 (https://bugzilla.wikimedia.org/67595) [20:36:31] the basic skinning i'm including is for the yellow warning styles, mostly, and having sans-serif fonts and so on [20:37:00] jdlrobson: http://i.imgur.com/A6rOOFZ.png [20:37:42] withoutaname: depends on what you mean by 'necessary' and 'mediawiki', but generally yes [20:38:07] withoutaname: if there's no LocalSettings, it should redirect you to the installer (which works without LocalSettings obviously) [20:38:12] MatmaRex: if I'm reading this correctly, you could potentially define MW_CONFIG_FILE to be something different [20:38:16] a custom localsettings as it were [20:38:24] oh, probably [20:38:51] I have no idea why you would though :S [20:38:57] (03PS14) 10Bsitu: Break notifications into alert and message sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 [20:39:06] might be useful for some wiki farms? [20:39:14] (03CR) 10jenkins-bot: [V: 04-1] Clean up user version constants [core] - 10https://gerrit.wikimedia.org/r/148905 (owner: 10Chad) [20:39:17] or weird dev environments [20:39:24] (03CR) 10SG: Simplify GENDER handling (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150300 (owner: 10MegaAlex) [20:39:27] but using anything else than the wg prefixes as settings will break [20:39:34] (03PS6) 10EBernhardson: Highlight unread message from notifications link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148310 [20:40:02] MatmaRex: yeh sure.. but why the navigation menu :) [20:40:13] if anything just show that banner on every page and nothing else :) [20:40:23] 3MediaWiki extensions / 3ProofreadPage: Blank entry in Special:IndexPages - 10https://bugzilla.wikimedia.org/32590#c10 (10George Orwell III) What complicates the matter is the use of tables in each list-item - causing a slight offset between a bullet number it's content - giving rise to the possibility that... [20:40:39] i mean technically with an edit to Common.css i can turn that into a bad skin :) [20:41:17] MatmaRex: so i would say the purpose of this skin is either 1) Tell the user they've done it wrong and make them correct it 2) Give a very basic skin implementation without styles or javascript [20:41:36] 3MediaWiki extensions / 3ProofreadPage: Blank entry in Special:IndexPages - 10https://bugzilla.wikimedia.org/32590#c11 (10Bawolff (Brian Wolff))
    • So there's a very blank title. Which I guess makes sense because the query does array( 'LEFT JOIN', 'page_id=pr_page_id' ) to fig... [20:43:12] (03CR) 10Umherirrender: "The daily export from translatewiki today (Id59d00bd9402da7fd03a34bd6d0ceb9bd2d00024) missed some wlnote messages, because there are many " [core] - 10https://gerrit.wikimedia.org/r/150254 (https://bugzilla.wikimedia.org/62017) (owner: 10Umherirrender) [20:45:23] 3MediaWiki / 3Watchlist: Restore count of rows on watchlist - 10https://bugzilla.wikimedia.org/62017#c6 (10Bartosz Dziewoński) (Or not, see discussion on the changeset.) [20:45:37] 3MediaWiki / 3Watchlist: Restore count of rows on watchlist - 10https://bugzilla.wikimedia.org/62017 (10Bartosz Dziewoński) a:3Umherirrender [20:45:44] jdlrobson: eh, i dunno [20:46:19] i see no reason to prevent people from trying to "debug" such a broken wiki [20:47:18] (03CR) 10Aaron Schulz: [C: 032] Have SvgHandler create a directory for its RSVG input files [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150268 (owner: 10Aaron Schulz) [20:47:41] (03Abandoned) 10SG: Make mw-ui-input CSS in Flow more specific, so as to override Core properties [extensions/Flow] - 10https://gerrit.wikimedia.org/r/146819 (owner: 10SG) [20:48:46] (03CR) 10Cscott: [C: 032] "Worked around issue with multiwiki.zip for now." [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/149252 (owner: 10Cscott) [20:49:19] (03CR) 10Cscott: [C: 032] "Fixes RTL attributions error." [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/150382 (owner: 10Cscott) [20:49:36] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch fatal whilst importing - 10https://bugzilla.wikimedia.org/68814 (10Nik Everett) 5PATC>3RESO/FIX [20:49:48] (03CR) 10Cscott: [C: 032] "Rebased on a patch which fixes the RTL attributions error." [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148611 (owner: 10Mwalker) [20:49:50] (03Merged) 10jenkins-bot: Have SvgHandler create a directory for its RSVG input files [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150268 (owner: 10Aaron Schulz) [20:49:51] 3MediaWiki / 3Search: Results 21 - 20 of 1 for - 10https://bugzilla.wikimedia.org/68783 (10Nik Everett) 5PATC>3RESO/FIX [20:50:08] (03PS1) 10Brian Wolff: Make Special:IndexPages not show invalid page ids [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/150386 (https://bugzilla.wikimedia.org/32590) [20:51:09] (03Merged) 10jenkins-bot: Update test cases with attribution information in the bundle. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/149252 (owner: 10Cscott) [20:51:39] (03Merged) 10jenkins-bot: Always use bidi, even if the wiki is "in theory" only LTR. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/150382 (owner: 10Cscott) [20:52:00] (03PS16) 10Ebe123: Create preference to watchlist pages after rollbacking [core] - 10https://gerrit.wikimedia.org/r/146440 (https://bugzilla.wikimedia.org/4488) [20:52:24] (03PS1) 10Manybubbles: Warn user if dynamic scripting is disabled [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/150389 (https://bugzilla.wikimedia.org/68804) [20:52:26] (03CR) 10Jjanes: [C: 04-1] "This patch seems to depend on Change-Id: Ife5f1bae4ad65b66c5e20017cc43c0576b4aba19, which is not yet merged. So I am testing that entire " (031 comment) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/135618 (https://bugzilla.wikimedia.org/65658) (owner: 10Parent5446) [20:52:42] (03Merged) 10jenkins-bot: Render attribution page [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148611 (owner: 10Mwalker) [20:53:19] (03CR) 10Ori.livneh: [C: 032] Only define $handlerFunc when needed [services/jobrunner] - 10https://gerrit.wikimedia.org/r/150302 (owner: 10Aaron Schulz) [20:53:23] (03CR) 10Ebe123: Create preference to watchlist pages after rollbacking (032 comments) [core] - 10https://gerrit.wikimedia.org/r/146440 (https://bugzilla.wikimedia.org/4488) (owner: 10Ebe123) [20:53:25] (03Merged) 10jenkins-bot: Only define $handlerFunc when needed [services/jobrunner] - 10https://gerrit.wikimedia.org/r/150302 (owner: 10Aaron Schulz) [20:54:44] (03PS1) 10Umherirrender: Restore the number of rows shown on Special:Watchlist [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/150390 (https://bugzilla.wikimedia.org/62017) [20:55:26] (03PS4) 10Aaron Schulz: Clean up user version constants [core] - 10https://gerrit.wikimedia.org/r/148905 (owner: 10Chad) [20:57:47] (03PS1) 10Alex Monk: Add JS hook to allow extensions to prevent double click from changing to action=edit [core] - 10https://gerrit.wikimedia.org/r/150391 (https://bugzilla.wikimedia.org/53058) [20:59:02] (03CR) 10Chad: "Even nicer would be removing this braindead preference." [core] - 10https://gerrit.wikimedia.org/r/150391 (https://bugzilla.wikimedia.org/53058) (owner: 10Alex Monk) [20:59:15] (03CR) 10jenkins-bot: [V: 04-1] Clean up user version constants [core] - 10https://gerrit.wikimedia.org/r/148905 (owner: 10Chad) [20:59:36] 3MediaWiki / 3Watchlist: Restore count of rows on watchlist - 10https://bugzilla.wikimedia.org/62017 (10Umherirrender) 5PATC>3RESO/FIX [21:00:14] (03CR) 10Bartosz Dziewoński: [C: 04-1] "mw.hook().fire is asynchronous." [core] - 10https://gerrit.wikimedia.org/r/150391 (https://bugzilla.wikimedia.org/53058) (owner: 10Alex Monk) [21:01:50] (03PS1) 10Cscott: Update `npm` for node 0.8 compatibility in travis. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/150392 [21:01:51] 3Wikimedia / 3Logstash: Automatically log fatals/exceptions into BZ with stack traces - 10https://bugzilla.wikimedia.org/68820#c3 (10Greg Grossmeier) Obligatory "make sure we don't expose sensitive data" comment. [21:02:04] (03PS7) 10EBernhardson: Highlight unread message from notifications link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148310 [21:05:09] (03PS3) 10EBernhardson: Port Flow Makefile to Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/149394 [21:09:10] MatmaRex, urgh, yes it is... [21:09:20] (03CR) 10EBernhardson: "we only want this patch once werdna's patch goes through ... since its only two lines can we just roll this into that one? to It seems li" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147344 (owner: 10Jdlrobson) [21:09:42] Krenair: i could have just as well written 'useless' instead of 'asynchronous', eh? :D [21:09:53] 3MediaWiki / 3General/Unknown: Provide an easy-to-run suite of performance regression tests - 10https://bugzilla.wikimedia.org/68821 (10Ori Livneh) 3NEW p:3Unprio s:3normal a:3Ori Livneh There should be an easy way to set up a basic, SQLite-backed MediaWiki instance, import a few representative artic... [21:10:05] MatmaRex, and I need to e.preventDefault() depending on what the hook says [21:10:09] MatmaRex, yep [21:10:52] yeah, you can't until you invent an API to do that :/ [21:11:15] mw.hook is very limited, intentionally i guess, but that doesn't make anybody any happier [21:11:51] 3Wikimedia / 3Bugzilla: Bugzilla: I can haz a Thank You link? - 10https://bugzilla.wikimedia.org/54940#c3 (10Anna Koval) Just chiming in, fwiw. I'd love to have this feature, too. :) [21:12:07] MatmaRex, could make dbClickEdit recheck the pref [21:12:39] Then VE can just falsify that while it's open, then restore on close :p [21:13:34] heh. at this point you might as well make it check some global [21:13:44] yep :( [21:13:48] (03PS3) 10EBernhardson: Fix insert order issue with recent change listeners [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150256 [21:14:37] (03CR) 10SG: "Please discuss this with Bernie and see what he says about applying a blanket patch like this. People do all kinds of scary stuff in MW, a" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148529 (owner: 10Jdlrobson) [21:15:01] (03CR) 10Jdlrobson: [C: 04-1] "After talking to Shahyar, we decided we would go with the modifier approach" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148724 (https://bugzilla.wikimedia.org/68456) (owner: 10Jdlrobson) [21:15:58] awight: is there any reason to keep the syslog() call in FundraisingChart? [21:16:16] (03CR) 10EBernhardson: "i barely know what border-box does(without googling) :P I could go either way." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148529 (owner: 10Jdlrobson) [21:17:20] AaronSchulz: probably not; can you send a link? [21:17:48] AaronSchulz: ah, I see it. definitely debug cruft. [21:17:52] (03CR) 10EBernhardson: "if the worst" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148529 (owner: 10Jdlrobson) [21:18:04] (03CR) 10EBernhardson: "if the worst is really just a horizontal scrollbar ... run with it" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148529 (owner: 10Jdlrobson) [21:19:50] (03PS1) 10Aaron Schulz: Removed syslog() debugging code [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/150395 [21:19:57] awight: ^ [21:20:16] AaronSchulz: thanks! [21:20:26] (03CR) 10Awight: [C: 032] Removed syslog() debugging code [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/150395 (owner: 10Aaron Schulz) [21:20:31] (03Merged) 10jenkins-bot: Removed syslog() debugging code [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/150395 (owner: 10Aaron Schulz) [21:21:26] (03CR) 10EBernhardson: [C: 032] Fix collapsing via topics collapsing button [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150089 (https://bugzilla.wikimedia.org/68773) (owner: 10Jdlrobson) [21:22:00] (03Merged) 10jenkins-bot: Fix collapsing via topics collapsing button [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150089 (https://bugzilla.wikimedia.org/68773) (owner: 10Jdlrobson) [21:22:48] (03PS3) 10Jforrester: Rename to "CiteThisPage", make Special:CiteThisPage the primary location [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/149592 [21:22:53] (03CR) 10SG: [C: 04-1] "Minimal solution: Scrap text-align and width on A, put text-align: left to UL." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148726 (owner: 10Jdlrobson) [21:23:03] (03PS1) 10Chad: Revert "test: coverage for wfWikiID()" [core] - 10https://gerrit.wikimedia.org/r/150398 [21:23:18] (03CR) 10Chad: [C: 032 V: 032] Revert "test: coverage for wfWikiID()" [core] - 10https://gerrit.wikimedia.org/r/150398 (owner: 10Chad) [21:23:35] superm401: awesome about the philly local hackathon :) I'll be helping with any labs / toollabs related stuff at the one in London, so do feel free to poke me for any such help before / after the hackathon [21:23:57] (03PS4) 10Jdlrobson: UI regression: menu buttons should be full width [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148726 [21:24:15] YuviPanda, thanks. Do you know of/have any kind of "Getting started for someone who knows nothing about Labs or Labs2" guide? [21:24:16] (03CR) 10jenkins-bot: [V: 04-1] UI regression: menu buttons should be full width [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148726 (owner: 10Jdlrobson) [21:24:53] superm401: halfak has some, I don't remember the URLs, sadly [21:25:00] superm401: and quarry should be in usable state at that point as well [21:25:57] (03CR) 10Chad: "recheck" [core] - 10https://gerrit.wikimedia.org/r/148905 (owner: 10Chad) [21:26:03] (03PS3) 10Jdlrobson: Use mw-ui-input core module for inputs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149174 [21:26:27] superm401, https://meta.wikimedia.org/wiki/Research:Labs2/Getting_started_with_Tool_Labs [21:27:36] 3MediaWiki / 3Maintenance scripts: deleteOldRevisions.php deletes content text from current revisions - 10https://bugzilla.wikimedia.org/66615 (10Andre Klapper) p:5High>3Normal [21:27:48] (03PS2) 10Alex Monk: Make mediawiki.action.view.dblClickEdit recheck preference [core] - 10https://gerrit.wikimedia.org/r/150391 (https://bugzilla.wikimedia.org/53058) [21:28:32] ^d: uh git review -s seems broken? [21:28:36] 3MediaWiki / 3General/Unknown: The page http://myMediawiki.dgfip/wt/index.php/Special:Pages_speciales crashes - 10https://bugzilla.wikimedia.org/68212#c4 (10Andre Klapper) макс: Please see the links in comment 1 and provide more information. Thanks! [21:28:55] is this known issue? [21:29:05] <^d> No clue, I haven't used git-review in like 2 years. [21:29:06] git_review.cmd.CannotInstallHook: Problems encountered installing commit-msg hook [21:29:13] "GET https://gerrit.wikimedia.org/tools/hooks/commit-msg" [21:30:54] (03CR) 10SG: [C: 032] Use mw-ui-input core module for inputs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149174 (owner: 10Jdlrobson) [21:31:00] <^d> gitdir=$(git rev-parse --git-dir); scp -p -P 29418 gerrit.wikimedia.org:hooks/commit-msg ${gitdir}/hooks/ [21:31:25] (03Merged) 10jenkins-bot: Use mw-ui-input core module for inputs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149174 (owner: 10Jdlrobson) [21:32:16] ^d: curiously enough this happens for SemanticForms extension... was it moved out of gerrit or something? [21:32:22] 3MediaWiki extensions / 3FundraisingChart: Performance review for mediawiki/extensions/FundraisingChart - 10https://bugzilla.wikimedia.org/66806 (10Aaron Schulz) a:5fr-tech>3Aaron Schulz [21:32:48] <^d> No. [21:32:57] <^d> scp -p -P 29418 gerrit.wikimedia.org:hooks/commit-msg fetches it [21:33:07] (03PS5) 10Jdlrobson: UI regression: menu buttons should be left aligned. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148726 [21:33:12] (03CR) 10jenkins-bot: [V: 04-1] UI regression: menu buttons should be left aligned. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148726 (owner: 10Jdlrobson) [21:33:27] (03CR) 10SG: [C: 032] UI regression: menu buttons should be left aligned. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148726 (owner: 10Jdlrobson) [21:33:29] (03CR) 10jenkins-bot: [V: 04-1] UI regression: menu buttons should be left aligned. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148726 (owner: 10Jdlrobson) [21:33:31] Thanks, halfak [21:33:33] <^d> chad@notsexy /a/vag/mediawiki/tests/phpunit (master)$ scp -p -P 29418 gerrit.wikimedia.org:hooks/commit-msg commit-msg [21:33:33] <^d> commit-msg 100% 4376 4.3KB/s 00:00 [21:33:51] 3Wikimedia / 3General/Unknown: Wikivoyage displays "Fatal exception of type MWException" for 1.24wmf15 (due to RelatedSites extension?) - 10https://bugzilla.wikimedia.org/68815 (10Andre Klapper) [21:34:17] (03CR) 10SG: [C: 032] Hygiene: Make box-sizing: border-box the default in the Flow world [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148529 (owner: 10Jdlrobson) [21:34:18] csteipp: is FundraisingChart relying on some CORS headers? [21:34:21] 3Wikimedia / 3Logstash: Automatically log fatals/exceptions into Bugzilla with stack traces - 10https://bugzilla.wikimedia.org/68820 (10Andre Klapper) [21:34:22] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make box-sizing: border-box the default in the Flow world [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148529 (owner: 10Jdlrobson) [21:34:39] AaronSchulz: I haven't even looked at that yet [21:34:46] (03PS6) 10Jdlrobson: UI regression: menu buttons should be left aligned. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148726 [21:35:01] csteipp: it would cause ajax requests to frdata.wikimedia.org from meta/collab [21:35:53] (03CR) 10SG: [C: 032] UI regression: menu buttons should be left aligned. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148726 (owner: 10Jdlrobson) [21:36:12] Allowing meta/collab on frdata wouldn't be too bad. The other way around would be a non-starter. [21:36:26] (03Merged) 10jenkins-bot: UI regression: menu buttons should be left aligned. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148726 (owner: 10Jdlrobson) [21:36:51] 3Wikimedia / 3General/Unknown: Wikivoyage displays "Fatal exception of type MWException" for 1.24wmf15 - 10https://bugzilla.wikimedia.org/68815 (10atsirlin) [21:37:11] (03CR) 10SG: [C: 032] Hygiene: Cleanup use of buttons.less so it's clear it is there for caching purposes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150252 (owner: 10Jdlrobson) [21:37:50] (03Merged) 10jenkins-bot: Hygiene: Cleanup use of buttons.less so it's clear it is there for caching purposes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150252 (owner: 10Jdlrobson) [21:37:51] 3Wikimedia / 3General/Unknown: Wikivoyage displays "Fatal exception of type MWException" for 1.24wmf15 - 10https://bugzilla.wikimedia.org/68815#c11 (10atsirlin) I am sorry for the confusion about the RelatedSites extension. There is no reason to blame it for the current problem. [21:38:58] (03PS1) 10Cscott: Updating to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/150399 [21:39:11] (03Abandoned) 10Jdlrobson: Load ext.flow.mediawiki.ui.buttons module [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150112 (https://bugzilla.wikimedia.org/68706) (owner: 10Spage) [21:39:28] (03PS4) 10Jdlrobson: Hygiene: Make box-sizing: border-box the default in the Flow world [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148529 [21:40:03] (03CR) 10Jdlrobson: [C: 032] "Rebased" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148529 (owner: 10Jdlrobson) [21:40:36] (03Merged) 10jenkins-bot: Hygiene: Make box-sizing: border-box the default in the Flow world [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148529 (owner: 10Jdlrobson) [21:41:29] (03PS4) 10Nemo bis: i18n: Add PLURAL/GENDER support to revreview-reject-summary-* [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/103119 (owner: 10MegaAlex) [21:41:44] (03PS5) 10Nemo bis: i18n: Add PLURAL/GENDER support to revreview-reject-summary-* [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/103119 (owner: 10MegaAlex) [21:42:25] 3MediaWiki extensions / 3FundraisingChart: Performance review for mediawiki/extensions/FundraisingChart - 10https://bugzilla.wikimedia.org/66806#c3 (10Aaron Schulz) 5NEW>3RESO/FIX This is fairly simple and I don't see any problem with this. It doesn't seem like this will be on any high traffic page. Also... [21:42:25] 3MediaWiki extensions / 3BetaFeatures: Unit tests do not specify dependency on $wgWellFormedXml - 10https://bugzilla.wikimedia.org/68823 (10Niklas Laxström) 3NEW p:3Unprio s:3normal a:3None Example: 375) HTMLFeatureFieldTest::testCreatingFieldGivesExpectedStrings Table row with class name not found.... [21:43:50] (03CR) 10Mwalker: [C: 032] Updating to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/150399 (owner: 10Cscott) [21:44:18] (03PS6) 10Nemo bis: i18n: Add PLURAL/GENDER support to revreview-reject-summary-* [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/103119 (owner: 10MegaAlex) [21:45:34] (03CR) 10Nemo bis: [C: 04-1] "Rebased and converted spaces to tabs on that file. Still -1 per above" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/103119 (owner: 10MegaAlex) [21:45:49] (03CR) 10Neilk: "I can't figure out this rebase. According to Gerrit docs I'm supposed to rebase from master, but I think some recent changes are incompati" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [21:46:00] (03PS7) 10Nemo bis: i18n: Add PLURAL/GENDER support to revreview-reject-summary-* [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/103119 (owner: 10MegaAlex) [21:46:40] (03CR) 10Bsitu: [C: 04-1] "Needs to add 'topic-title' key to metadata in topic & summary blocks. Something weird happened after I added the key, upon replying to a " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150256 (owner: 10EBernhardson) [21:46:51] 3Wikimedia / 3General/Unknown: Wikivoyage displays "Fatal exception of type MWException" for 1.24wmf15 - 10https://bugzilla.wikimedia.org/68815#c12 (10Sam Reed (reedy)) (In reply to Greg Grossmeier from comment #10) > So, to clarify, the "In Other Projects Sidebar" is already in use on > Wikivoyage, the targ... [21:47:57] (03CR) 10MarkTraceur: "Hi Paladox." [core] - 10https://gerrit.wikimedia.org/r/145049 (owner: 10Paladox) [21:49:06] 3Wikimedia / 3Logstash: Automatically log fatals/exceptions into Phabricator with stack traces - 10https://bugzilla.wikimedia.org/68820#c4 (10Greg Grossmeier) Related: https://github.com/thurloat/sentry-jira It lets you create JIRA issues from Sentry items/whatever they're called. No Bugzilla plugin yet.... [21:51:45] (03PS1) 10Cscott: Merge branch 'master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/150401 [21:51:47] (03PS1) 10Cscott: Rebuilding dependencies [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/150402 [21:52:03] (03CR) 10EBernhardson: "doh, looks like the topic-title moved into the next patch. I'll pull it down to this one." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150256 (owner: 10EBernhardson) [21:53:59] (03PS2) 10Cscott: Rebuilding dependencies [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/150402 [21:54:11] (03CR) 10Mwalker: [V: 032] Updating to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/150399 (owner: 10Cscott) [21:55:00] (03PS1) 10MarkTraceur: Revert "Update jquery.ui Vector theme to 1.9.2" [core] - 10https://gerrit.wikimedia.org/r/150403 [21:55:23] (03CR) 10jenkins-bot: [V: 04-1] Revert "Update jquery.ui Vector theme to 1.9.2" [core] - 10https://gerrit.wikimedia.org/r/150403 (owner: 10MarkTraceur) [21:56:46] (03PS2) 10MarkTraceur: Revert "Update jquery.ui Vector theme to 1.9.2" [core] - 10https://gerrit.wikimedia.org/r/150403 [21:57:03] MatmaRex: Pay me back? ^ [21:57:52] 3MediaWiki extensions / 3CentralAuth: CentralAuth tests are failing - 10https://bugzilla.wikimedia.org/68784 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX [21:57:57] marktraceur: huh, revert [21:58:47] (03CR) 10Mwalker: [C: 032 V: 032] Merge branch 'master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/150401 (owner: 10Cscott) [21:58:52] marktraceur: i don't think that revert has fully worked, has it? [21:59:06] MatmaRex: How do you mean? [21:59:15] Oh, the paths changed [21:59:26] (03CR) 10Cscott: [C: 04-2] "Rebuild on x86. looks like far too many things changed." [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/150402 (owner: 10Cscott) [21:59:35] Er wait, no. [22:00:01] marktraceur: i'm trying to figure out wtf happened [22:00:07] i moved this stuff around in https://gerrit.wikimedia.org/r/#/c/148304/ [22:00:10] UW is working at least. [22:00:10] or so i thought [22:00:25] but i apparently forgot to git add -A or something? [22:00:26] MatmaRex: The revert puts them in the right place [22:00:29] I think. [22:00:36] D resources/src/jquery.ui-themes/vector/jquery.ui.tooltip.css [22:00:41] this file shouldn't even be there [22:00:42] oh well [22:00:42] Oh, all of them. [22:00:44] Got it. [22:01:32] i'm trying to figure out what this is still doing in Resources.php, too… https://gerrit.wikimedia.org/r/#/c/150403/2/resources/Resources.php [22:01:46] looks like someone messed things up [22:01:50] and like that someone was me [22:02:06] (03PS1) 10Mwalker: Rebuilding dependencies [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/150405 [22:02:48] * marktraceur pats MatmaRex [22:03:22] (03Abandoned) 10Mwalker: Rebuilding dependencies [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/150402 (owner: 10Cscott) [22:03:23] ugh, why are things never simple [22:03:52] (03CR) 10Mwalker: [C: 032 V: 032] Rebuilding dependencies [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/150405 (owner: 10Mwalker) [22:03:57] It would be super cool if I could fix prod today...as a thought [22:04:29] yes [22:04:41] marktraceur: revert commons? [22:04:47] fascinating [22:04:51] PS6 of https://gerrit.wikimedia.org/r/#/c/148304/ was corrent [22:04:54] correct* [22:04:56] greg-g: Once MatmaRex merges the bloody patch, it should be OK [22:04:58] then i broke my thing [22:05:00] anyway [22:05:13] (03CR) 10Bartosz Dziewoński: [C: 032] Revert "Update jquery.ui Vector theme to 1.9.2" [core] - 10https://gerrit.wikimedia.org/r/150403 (owner: 10MarkTraceur) [22:05:14] Silly MatmaRex, trix are for kids. [22:05:20] can't possibly get more broken, can it? [22:05:30] * marktraceur knocks on wood. [22:05:49] I'ma gonna g'head and schedule it for SWAT. [22:06:56] (03CR) 10Bartosz Dziewoński: "Ugh, the merged version of this is broken (it doesn't move some files added in recent jQuery UI update) – it was correct on PS6, but I som" [core] - 10https://gerrit.wikimedia.org/r/148304 (owner: 10Bartosz Dziewoński) [22:07:46] (03Merged) 10jenkins-bot: Revert "Update jquery.ui Vector theme to 1.9.2" [core] - 10https://gerrit.wikimedia.org/r/150403 (owner: 10MarkTraceur) [22:09:19] Christ, need to manually cherry-pick it. [22:09:21] * marktraceur weeps [22:09:58] marktraceur: you might want to just revert my vector change, too [22:10:19] (03PS2) 10Gergő Tisza: Do not specify any z-index for the play button [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/150285 (https://bugzilla.wikimedia.org/68479) (owner: 10Brian Wolff) [22:10:22] might be simpler to do [22:10:30] (03PS3) 10Gergő Tisza: Do not specify any z-index for the play button [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/150285 (https://bugzilla.wikimedia.org/68479) (owner: 10Brian Wolff) [22:10:50] (03PS5) 10EBernhardson: [WIP] Move notification creation to event listener [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150141 [22:10:53] (03PS4) 10EBernhardson: Fix insert order issue with recent change listeners [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150256 [22:10:58] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Move notification creation to event listener [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150141 (owner: 10EBernhardson) [22:11:20] MatmaRex: I don't think it will be, but we'll see [22:16:36] (03PS1) 10Mwalker: Revert "Allow customizing post_zip destination" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/150410 [22:16:43] (03CR) 10Mwalker: [C: 032] Revert "Allow customizing post_zip destination" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/150410 (owner: 10Mwalker) [22:16:50] (03Merged) 10jenkins-bot: Revert "Allow customizing post_zip destination" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/150410 (owner: 10Mwalker) [22:17:52] MatmaRex: Ugh, it's telling me that all of the files are deleted. Christ, I guess this isn't so straightforward. [22:18:17] Oh, wait, no, I tried to cherry-pick it twice. NVM. [22:18:37] (03PS1) 10MarkTraceur: Revert "Update jquery.ui Vector theme to 1.9.2" [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150411 [22:18:46] we should just run all the wikis from master, things would be so much simpler! [22:19:13] Obvs. [22:21:42] (03PS6) 10EBernhardson: [WIP] Move notification creation to event listener [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150141 [22:21:45] (03PS5) 10EBernhardson: Fix insert order issue with recent change listeners [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150256 [22:24:36] (03CR) 10EBernhardson: "also the problem after a failure where it reported 'cant find post xxxx' is the BufferedCache problem iiuc, with these tweaks moving stor" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150256 (owner: 10EBernhardson) [22:27:57] (03CR) 10Paladox: "Hi I pulled the update from the link inside jquery.ui.theme.css." [core] - 10https://gerrit.wikimedia.org/r/145049 (owner: 10Paladox) [22:31:15] RoanKattouw: do you have some time to talk about ResourceLoader and the 'user' group? [22:31:23] (03CR) 10Paladox: "Hi do you have the link for where you can see the problem so that I can test it please." [core] - 10https://gerrit.wikimedia.org/r/145049 (owner: 10Paladox) [22:31:50] RoanKattouw: if not, when is a good time? [22:32:20] legoktm: Not when I just broke wikitechwiki [22:32:29] :P [22:32:44] (03PS1) 10Aaron Schulz: Fixed MediaWiki dual getter/setters from fataling [core] - 10https://gerrit.wikimedia.org/r/150415 [22:34:53] 3Wikimedia / 3Site requests: Investigate the creation of a wiki for the dev community that is organizing around Labs - 10https://bugzilla.wikimedia.org/68818#c2 (10Steinsplitter) I like to +1 what Chad has said above. And two wikitech-wikis are confusing. [22:35:18] (03CR) 10Gergő Tisza: "Currently the class containing the z-index is not even loaded until the user first clicks the button, the styles in TimedMediaHandler/reso" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/150285 (https://bugzilla.wikimedia.org/68479) (owner: 10Brian Wolff) [22:37:56] (03CR) 10Gergő Tisza: [C: 032] "Anyway, seems like a harmless change (compared to z-index:1). If it isn't, we will now find out :) Folks should comment their CSS." [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/150285 (https://bugzilla.wikimedia.org/68479) (owner: 10Brian Wolff) [22:38:01] (03Merged) 10jenkins-bot: Do not specify any z-index for the play button [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/150285 (https://bugzilla.wikimedia.org/68479) (owner: 10Brian Wolff) [22:39:19] (03PS1) 10Jdlrobson: Remove utilities from styleguide [core] - 10https://gerrit.wikimedia.org/r/150417 [22:39:21] (03PS1) 10Jdlrobson: Add documentation/cleanup markup for VForm labels [core] - 10https://gerrit.wikimedia.org/r/150418 [22:44:21] 3MediaWiki / 3Parser: File links with local project prefix cause images to be transcluded - 10https://bugzilla.wikimedia.org/68802#c3 (10This, that and the other (TTO)) No, unfortunately that won't fix it. I don't think I'd be exaggerating too much if I said this behaviour has been present in MediaWiki for... [22:49:36] (03CR) 10Legoktm: Add hack for missing enwiki specific styles (031 comment) [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/137318 (owner: 10Yuvipanda) [22:55:06] (03CR) 10Kaldari: [C: 04-1] Hygiene: Documentation updates (032 comments) [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/142281 (owner: 10Jdlrobson) [22:58:41] (03CR) 10Kaldari: Hygiene: Documentation updates (032 comments) [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/142281 (owner: 10Jdlrobson) [23:00:08] (03CR) 10Rillke: "You are pushing to master:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [23:01:28] (03CR) 10Neilk: "Thanks Rillke. They also straightened me out on IRC." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [23:01:41] (03CR) 10Jdlrobson: Hygiene: Documentation updates (032 comments) [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/142281 (owner: 10Jdlrobson) [23:01:43] (03PS2) 10Jdlrobson: Hygiene: Documentation updates [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/142281 [23:02:31] (03PS1) 10Aaron Schulz: Just log exceptions instead of spamming them in JobRunner [core] - 10https://gerrit.wikimedia.org/r/150423 [23:03:48] (03CR) 10Kaldari: [C: 032] Hygiene: Documentation updates [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/142281 (owner: 10Jdlrobson) [23:04:14] (03Merged) 10jenkins-bot: Hygiene: Documentation updates [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/142281 (owner: 10Jdlrobson) [23:10:58] (03PS1) 10Dduvall: Install xvfb for use in headless browser testing [vagrant] - 10https://gerrit.wikimedia.org/r/150424 [23:15:53] (03CR) 10Catrope: [C: 032] Update MobileFrontend [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150373 (owner: 10Kaldari) [23:15:59] (03CR) 10Catrope: [C: 032] Update VisualEditor to Ibf16d63 [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150293 (owner: 10Jforrester) [23:16:09] 3Wikimedia / 3Site requests: Enable the TemplateData GUI editor on Dutch Wikipedia - 10https://bugzilla.wikimedia.org/68795#c3 (10James Forrester) 5PATC>3RESO/FIX This is now done. Happy editing! [23:16:45] (03CR) 10MarkTraceur: "https://commons.wikimedia.org/wiki/Special:UploadWizard?debug=true" [core] - 10https://gerrit.wikimedia.org/r/145049 (owner: 10Paladox) [23:17:04] (03PS1) 10Catrope: Update ZeroBanner extension to wmf15 [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150428 [23:17:23] 3MediaWiki extensions / 3BookManagerv2: Implement keyboard navigation - 10https://bugzilla.wikimedia.org/50679#c10 (10Jared Flores) Hi! I tried to work on BookManagerv2 again, but the testing environment on my local machine doesn't seem to be loading the extension properly. As much as I would love to continu... [23:19:02] (03CR) 10Catrope: [C: 032] Update MultimediaViewer extension [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150381 (owner: 10Gergő Tisza) [23:19:24] (03Merged) 10jenkins-bot: Update MobileFrontend [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150373 (owner: 10Kaldari) [23:19:26] (03CR) 10jenkins-bot: [V: 04-1] Update VisualEditor to Ibf16d63 [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150293 (owner: 10Jforrester) [23:19:50] (03CR) 10Catrope: [C: 032] Revert "Update jquery.ui Vector theme to 1.9.2" [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150411 (owner: 10MarkTraceur) [23:19:54] (03CR) 10Catrope: [C: 032] Update VisualEditor to I90ab7de [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150294 (owner: 10Jforrester) [23:20:53] (03CR) 10Bsitu: [C: 032] Fix insert order issue with recent change listeners [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150256 (owner: 10EBernhardson) [23:21:15] (03CR) 10Catrope: [C: 032] Update VisualEditor to Ibf16d63 [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150293 (owner: 10Jforrester) [23:21:37] 3Wikimedia / 3Extension setup: Review and deploy Hovercards extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/61167 (10Greg Grossmeier) [23:21:51] (03CR) 10Ori.livneh: [C: 032] Protect stream_get_contents() from hanging for sanity [services/jobrunner] - 10https://gerrit.wikimedia.org/r/150279 (owner: 10Aaron Schulz) [23:21:53] (03Merged) 10jenkins-bot: Fix insert order issue with recent change listeners [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150256 (owner: 10EBernhardson) [23:21:56] (03Merged) 10jenkins-bot: Update MultimediaViewer extension [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150381 (owner: 10Gergő Tisza) [23:22:04] (03Merged) 10jenkins-bot: Protect stream_get_contents() from hanging for sanity [services/jobrunner] - 10https://gerrit.wikimedia.org/r/150279 (owner: 10Aaron Schulz) [23:23:03] (03Merged) 10jenkins-bot: Revert "Update jquery.ui Vector theme to 1.9.2" [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150411 (owner: 10MarkTraceur) [23:23:25] (03Merged) 10jenkins-bot: Update VisualEditor to I90ab7de [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150294 (owner: 10Jforrester) [23:24:59] (03Merged) 10jenkins-bot: Update VisualEditor to Ibf16d63 [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150293 (owner: 10Jforrester) [23:25:38] 3MediaWiki / 3Unit tests: DjVu test spams standard output - 10https://bugzilla.wikimedia.org/68826 (10Rainer Rillke @commons.wikimedia) 3NEW p:3Unprio s:3normal a:3None Original bug title: DjVu test spams standard output How to reproduce: Upload a patch set to core or run the unit tests locally. Ev... [23:26:06] 3MediaWiki / 3Unit tests: DjVu test spams standard output - 10https://bugzilla.wikimedia.org/68826 (10Rainer Rillke @commons.wikimedia) p:5Unprio>3Normal s:5normal>3enhanc [23:38:42] RoanKattouw: so uh, when would be a good time for you to talk? [23:38:54] Now is fine [23:38:59] I just finished SWAT [23:39:34] ok, so the bug is https://bugzilla.wikimedia.org/68712, have you had a chance to read it? [23:40:03] Krinkle|detached was going to talk to you about it I think, not sure if that happened [23:43:19] Hmm [23:43:24] I'm not sure I entirely understand the problem here [23:43:32] Why was that hook necessary in the first place? [23:43:32] (03CR) 10Bartosz Dziewoński: [C: 032] Remove utilities from styleguide [core] - 10https://gerrit.wikimedia.org/r/150417 (owner: 10Jdlrobson) [23:44:02] (03PS9) 10Jdlrobson: Use mw-ui-checkbox from core [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/149122 [23:44:21] to bypass the module version being cached in the startup module [23:45:17] RoanKattouw: Krinkle explains it well in https://bugzilla.wikimedia.org/show_bug.cgi?id=62602#c16 [23:46:36] (03Merged) 10jenkins-bot: Remove utilities from styleguide [core] - 10https://gerrit.wikimedia.org/r/150417 (owner: 10Jdlrobson) [23:46:53] 3MediaWiki / 3Search: nsToken URL parameter in search URLs is kinda ugly - 10https://bugzilla.wikimedia.org/68827 (10MZMcBride) 3NEW p:3Unprio s:3normal a:3None https://en.wikipedia.org/w/index.php?title=Special%3ASearch&profile=advanced&search=search+box+focus&fulltext=Search&ns4=1&profile=advanced&... [23:48:08] legoktm: Ooooh [23:48:10] OK [23:48:18] It's user-variable so you can't have a startup module timestamp [23:48:20] That makes sense [23:48:21] 3MediaWiki / 3Search: nsToken URL parameter in search URLs is kinda ugly - 10https://bugzilla.wikimedia.org/68827#c1 (10Bartosz Dziewoński) This has a pending patch: https://gerrit.wikimedia.org/r/#/c/144180/ [23:48:29] Makes me wonder how we avoid this for core user modules though [23:48:38] we split them into a separate request [23:48:50] Oh by knowing about them and ... yeah. I see [23:48:56] which is why the hook was added, so the globalcssjs modules could go in a separate request [23:49:03] (03PS3) 10Nemo bis: Special:Search: Remove token from URL when saving settings [core] - 10https://gerrit.wikimedia.org/r/144180 (https://bugzilla.wikimedia.org/68827) (owner: 10PleaseStand) [23:49:08] OK so I would argue that the "correct" solution is to apply this to all modules with group=user [23:49:42] (03CR) 10Bartosz Dziewoński: [C: 031] "This is clever." [core] - 10https://gerrit.wikimedia.org/r/144180 (https://bugzilla.wikimedia.org/68827) (owner: 10PleaseStand) [23:50:03] legoktm: Anyway your immediate problem is that you want to add somewhere there that's TYPE_STYLES? [23:50:33] yeah, basically [23:50:47] right now the hook uses TYPE_COMBINED which won't work for non-js users [23:50:52] Also, hold on [23:50:58] (03CR) 10MZMcBride: "Thanks for working on this, PleaseStand!" [core] - 10https://gerrit.wikimedia.org/r/144180 (https://bugzilla.wikimedia.org/68827) (owner: 10PleaseStand) [23:51:01] (03PS1) 10Helder.wiki: Expose variables to JavaScript on Special:AbuseFilter/examine [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/150433 [23:51:06] I swear there is code that segments out modules in the user group *somewhere* [23:51:45] https://github.com/wikimedia/mediawiki-core/blob/master/includes/OutputPage.php#L2798 ? [23:52:06] (03PS1) 10EBernhardson: Fix renamed variable missed in rebase [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150434 [23:52:10] legoktm: Yeah exactly [23:52:16] So why do we need the hook then [23:52:31] (03PS1) 10Cscott: Use siteinfo API query to get content license for each wiki. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/150435 [23:52:40] 3Wikimedia / 3Apache configuration: remove static.wikipedia.org ?! - 10https://bugzilla.wikimedia.org/55809#c3 (10Daniel Zahn) 5NEW>3RESO/FIX somebody has removed it from DNS meanwhile: Host static.wikipedia.org not found: 3(NXDOMAIN) and apache configs are in an entirely different place meanwhile we... [23:52:47] because that function isn't called if I use $out->addModules? [23:54:05] (03PS1) 10Wmat: Replacing deprecated function. [extensions/JSBreadCrumbs] - 10https://gerrit.wikimedia.org/r/150436 [23:54:32] It looks like it should be? [23:54:42] Hmm [23:54:47] https://github.com/wikimedia/mediawiki-core/blob/master/includes/OutputPage.php#L2970 [23:54:49] legoktm: What if you do addModuleStyles() ? [23:54:59] and also addModuleScripts [23:55:04] oh hm, /me tries [23:55:26] 3Wikimedia / 3Bugzilla: replace bz reporter db scraping with API queries - 10https://bugzilla.wikimedia.org/61294#c2 (10Daniel Zahn) by now it makes probably more sense to look at a replacement for bz reporter that runs on phabricator new ticket for that and close here? [23:55:28] Ah yes, you're right, normal addModules() just ends up in a JSON array sent to the client, of course [23:56:17] (03PS2) 10Jdlrobson: Fix renamed variable missed in rebase [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150434 (owner: 10EBernhardson) [23:56:20] (03PS1) 10EBernhardson: Generalize a couple implementations of EchoGetDefaultNotifiedUsers [extensions/Echo] - 10https://gerrit.wikimedia.org/r/150437 [23:56:23] 3Wikimedia / 3Bugzilla: remove component "prototype server" - 10https://bugzilla.wikimedia.org/54969 (10Daniel Zahn) 5NEW>3RESO/WON [23:56:23] 3MediaWiki / 3Parser: File links with local project prefix cause images to be transcluded - 10https://bugzilla.wikimedia.org/68802#c4 (10This, that and the other (TTO)) I don't have access to Git right now, but the correct fix would be to move the substr_compare test, currently on line 2107 of Parser.php, up... [23:56:24] (03CR) 10Jdlrobson: [C: 032] "WFM" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150434 (owner: 10EBernhardson) [23:56:49] legoktm: Perhaps addModules() should be smarter about that, and modules in the 'user' group should be routed into what the hook currently does [23:56:56] RoanKattouw: that...works. [23:56:56] (03CR) 10EBernhardson: [C: 04-1] "seems to work in some circumstances, but needs testing and review" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/150437 (owner: 10EBernhardson) [23:56:59] Then I'm hoping we can kill the hook [23:56:59] (03Merged) 10jenkins-bot: Fix renamed variable missed in rebase [extensions/Flow] - 10https://gerrit.wikimedia.org/r/150434 (owner: 10EBernhardson) [23:57:01] Arghhhh [23:57:08] I spent so much time fighting with this >.> [23:57:14] legoktm: It probably works with two separate requests, though? One for scripts and one for styles? [23:57:18] yes [23:57:21] Oh but you need the styles for noscript? [23:57:25] [23:57:34] [23:57:34] [23:57:59] Huh, why are those two separate? [23:58:21] 3MediaWiki / 3Parser: File links with local project prefix cause images to be transcluded - 10https://bugzilla.wikimedia.org/68802#c5 (10This, that and the other (TTO)) Actually don't know if that would work 100%... in any case it probably needs to be || rather than && and !== instead of ===... I'll come bac... [23:58:22] .site is in the 'site' group [23:58:24] .user is in the 'user' group [23:58:40] (03PS15) 10EBernhardson: New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [23:58:41] Of course they are [23:59:15] (03CR) 10jenkins-bot: [V: 04-1] New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [23:59:18] legoktm: But AFAICT they don't actually need to be, in this case? [23:59:27] (03PS1) 10Cscott: Handle protocol-relative URLs in attribution information. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/150438 [23:59:29] I mean ideally we'd be combining them with the real user and site modules [23:59:39] right [23:59:44] let me create a common.js to see [23:59:52] (03PS2) 10EBernhardson: Generalize a couple implementations of EchoGetDefaultNotifiedUsers [extensions/Echo] - 10https://gerrit.wikimedia.org/r/150437 [23:59:57] Oh yes [23:59:58] greg-g: Hey! I think there is some confusion. The Hovercards/Popups extension is already deployed on wikipedia.