[00:00:06] 3MediaWiki-Vagrant: phpunit: PHP extension 'xdiff' is not loaded, skipping. - 10https://bugzilla.wikimedia.org/68642 (10Nemo) 3NEW p:3Unprio s:3enhanc a:3Ori Livneh Can we include xdiff in the puppet roles? 1) DiffHistoryBlobTest::testXdiffAdler32 with data set #0 ('', 'Empty string') PHP extension 'x... [00:00:18] 3MediaWiki-Vagrant: phpunit: PHP extension 'xdiff' is not loaded, skipping. - 10https://bugzilla.wikimedia.org/68642 (10Nemo) [00:02:05] 3MediaWiki-Vagrant: scribunto: phpunit tests skipped: Download the Unicode Normalization Test Suite - 10https://bugzilla.wikimedia.org/68643 (10Nemo) 3NEW p:3Unprio s:3enhanc a:3Ori Livneh Should it be included in the scribunto role? 17) LuaSandbox: Scribunto_LuaUstringLibraryTests::testUstringLibrary... [00:07:03] 3MediaWiki extensions / 3ProofreadPage: phpunit failure: Pages::testParserTest: Failed asserting that two strings are equal. - 10https://bugzilla.wikimedia.org/68644 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Apparently they all have some unexpected "pagequality" class, at least when run with other ex... [00:09:02] (03CR) 10Bartosz Dziewoński: "It can wait. My Gerrit dashboard acts as my to-do list :)" [core] - 10https://gerrit.wikimedia.org/r/138110 (owner: 10Bartosz Dziewoński) [00:09:07] (03PS2) 10Bartosz Dziewoński: Allow skins to provide a screenshot for Special:Version [core] - 10https://gerrit.wikimedia.org/r/138110 [00:10:37] (03CR) 10Bartosz Dziewoński: "Aren't these serialized in parser cache?" [core] - 10https://gerrit.wikimedia.org/r/149382 (owner: 10Umherirrender) [00:11:35] 3MediaWiki extensions / 3Scribunto: phpunit failure: LuaStandalone: TitleLibraryTests: Failed asserting that two strings are identical - 10https://bugzilla.wikimedia.org/68646 (10Nemo) 3NEW p:3Unprio s:3normal a:3None When runnning with a bunch other extensions (under php5), http://paste.debian.net/1... [00:13:32] 3MediaWiki-Vagrant: phpunit failure: MediaWiki\Extensions\OAuth\OAuthUtilTest::testGetHeade rs Failed asserting that two arrays are equal - 10https://bugzilla.wikimedia.org/68647 (10Nemo) 3NEW p:3Unprio s:3normal a:3Ori Livneh Is this for the recent gzip changes in MediaWiki-Vagrant? 120) MediaWiki\Ex... [00:16:08] (03CR) 10Bartosz Dziewoński: [C: 032] Remove unused XMLReader2 class [core] - 10https://gerrit.wikimedia.org/r/148958 (owner: 10TTO) [00:17:08] 3MediaWiki / 3Database: Math tests dies when run with the Echo extensions - 10https://bugzilla.wikimedia.org/67148#c12 (10physikerwelt) This Bug is not related to the math extension. My experience is the following At first I could reproduce a similar error as reported in the bug report. But the error indicat... [00:17:08] 3MediaWiki / 3Unit tests: IPTCTest::testIPTCParseForcedUTFButInvalid() failing in vagrant - 10https://bugzilla.wikimedia.org/67908#c2 (10Nemo) How does this differ from bug 37665? Slightly different output here with php5: 14) IPTCTest::testIPTCParseForcedUTFButInvalid Failed asserting that two arrays are eq... [00:19:04] (03CR) 10Bartosz Dziewoński: [C: 032] OutputPageTest: Don't assume Vector is the default skin [core] - 10https://gerrit.wikimedia.org/r/148846 (owner: 10Legoktm) [00:19:09] (03Merged) 10jenkins-bot: Remove unused XMLReader2 class [core] - 10https://gerrit.wikimedia.org/r/148958 (owner: 10TTO) [00:19:40] (03Abandoned) 10Bartosz Dziewoński: OutputPageTest: Don't hardcode 'vector' as default skin [core] - 10https://gerrit.wikimedia.org/r/148766 (owner: 10Bartosz Dziewoński) [00:21:51] 3MediaWiki / 3Unit tests: phpunit failure: ParserTests::testParserTest for gallery with UploadWizard and data-file-* - 10https://bugzilla.wikimedia.org/68649 (10Nemo) 3NEW p:3Unprio s:3normal a:3None These gallery tests don't like Special:Upload being replaced by Special:UploadWizard and data-file-*... [00:22:02] (03Merged) 10jenkins-bot: OutputPageTest: Don't assume Vector is the default skin [core] - 10https://gerrit.wikimedia.org/r/148846 (owner: 10Legoktm) [00:27:16] 3MediaWiki / 3Unit tests: phpunit failure: ParserTests::testParserTest for gallery with UploadWizard and data-file-* - 10https://bugzilla.wikimedia.org/68649#c1 (10Nemo) Created attachment 16046 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16046&action=edit A bunch more similar failures The discus... [00:27:47] 3MediaWiki / 3Unit tests: phpunit failure: ParserTests::testParserTest for gallery and files with UploadWizard and data-file-* - 10https://bugzilla.wikimedia.org/68649 (10Nemo) [00:29:06] 3MediaWiki / 3Unit tests: phpunit failure: Unexpected 'wikiId' => 'wiki-unittest_' - 10https://bugzilla.wikimedia.org/68650 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Very silly one: 121) ProofreadPage\FileProviderTest::testGetForIndexPage with data set #0 (ProofreadIndexPage, UnregisteredLocalFile)... [00:31:16] 3MediaWiki / 3Unit tests: phpunit failure: ParserTests::testParserTest for gallery and files with UploadWizard and data-file-* - 10https://bugzilla.wikimedia.org/68649#c2 (10Nemo) Also affects a Cite test: 135) CiteParserTests::testParserTest with data set #7 (' after (bug 6164)', ' (03CR) 10Jalexander: [C: 032 V: 032] Add license details and give credit to more authors (based on git shortlog) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/145038 (owner: 10Jforrester) [00:40:17] 3MediaWiki / 3Unit tests: phpunit failure: UserTest::testAllRightsWithMessage with some additional rights - 10https://bugzilla.wikimedia.org/68651 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Some "unexpected" rights: + 59 => 'flow-close' + 60 => 'flow-delete' + 61 => 'flow-edit-post' + 62... [00:41:46] 3MediaWiki / 3Unit tests: phpunit failure: Magic Word: {{NUMBEROFFILES}} Failed asserting that two strings are equal. - 10https://bugzilla.wikimedia.org/68652 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Hard to tell what extension has interfered exactly: 18) ParserTests::testParserTest with data set #... [00:43:34] 3MediaWiki / 3Unit tests: TextPassDumperTest::testCheckpointGzip expected more than 1 checkpoint to have been created - 10https://bugzilla.wikimedia.org/68653 (10Nemo) 3NEW p:3Unprio s:3normal a:3None The computer in question was definitely not too fast, what's actually going on? 118) TextPassDumper... [00:43:34] 3MediaWiki / 3Page editing: Please add full stop and space after "undo" default edit summary - 10https://bugzilla.wikimedia.org/67114#c2 (10James Forrester) 5NEW>3RESO/WON (In reply to Ricordisamoa from comment #1) > Many users won't add any "explanatory note"s, and we would end up with > thousands of ed... [00:44:46] 3MediaWiki / 3API: phpunit failure: ApiOptionsTest::testReset User::saveSettings() was not expected to be called more than once - 10https://bugzilla.wikimedia.org/68654 (10Nemo) 3NEW p:3Unprio s:3normal a:3None From where could this come from (see http://paste.debian.net/111811/ for the enabled exten... [00:49:40] (03CR) 10Lt2818: "The messages contributed by Benojan use traditional characters(wuu-hant), and others use simplified characters(wuu-hans)." [core] - 10https://gerrit.wikimedia.org/r/149531 (https://bugzilla.wikimedia.org/57138) (owner: 10Gerrit Patch Uploader) [00:53:14] 3MediaWiki / 3General/Unknown: slow query: INSERT /* JobQueueDB::doBatchPush 127.0.0.1 */ INTO `unittest_job` etc. - 10https://bugzilla.wikimedia.org/68620 (10Nemo) 5NEW>3UNCO [00:54:45] 3MediaWiki / 3Unit tests: phpunit failure: ParserTests::testParserTest for gallery and files with UploadWizard and data-file-* - 10https://bugzilla.wikimedia.org/68649 (10Nemo) [01:14:14] 3Wikimedia / 3Site requests: Create moderator group at the Vietnamese Wikipedia - 10https://bugzilla.wikimedia.org/68612#c1 (10Dereckson) 5NEW>3UNCO Hello, I have a bad feeling about this request. 28 people have participated to the consultation, 18 supports the motion. So, 18 people are going to intro... [01:29:16] 3Wikimedia / 3Site requests: Create moderator group at the Vietnamese Wikipedia - 10https://bugzilla.wikimedia.org/68612#c2 (10Vogone) Funnily there are examples for both concerns you mentioned. The Dutch language Wikipedia calls its sysops "moderators"[1] and the Portguese language Wikipedia has so-called "... [01:33:43] 3MediaWiki / 3Revision deletion: Rev-suppressed-text-view not shown on suppressed pages - 10https://bugzilla.wikimedia.org/56380#c4 (10Vogone) 5PATC>3RESO/FIX Fixed in core, should take until 7th August until it takes effect on Wikipedias. [01:50:35] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (2d917ddec2) [core] - 10https://gerrit.wikimedia.org/r/149605 [02:28:56] (03PS1) 10Withoutaname: Documentation: Remove paragraph about not creating a 2nd WebRequest [core] - 10https://gerrit.wikimedia.org/r/149607 [03:19:14] (03CR) 10Daniel Friesen: [C: 04-1] "You're correct that WebRequest "can" now be created without breaking things and use of $wgReqest is incorrect. But the comment is still co" [core] - 10https://gerrit.wikimedia.org/r/149607 (owner: 10Withoutaname) [03:27:42] (03CR) 10Withoutaname: "For the former, we can move that to the description for the FauxRequest class." [core] - 10https://gerrit.wikimedia.org/r/149607 (owner: 10Withoutaname) [03:34:46] 3Wikimedia / 3General/Unknown: Wikivoyage: interwiki links require a cleanup/automatic replacement - 10https://bugzilla.wikimedia.org/41986#c18 (10This, that and the other (TTO)) 5UNCO>3RESO/FIX Marking fixed. Apparently not needed anymore. [04:25:38] (03CR) 10Parent5446: Automatically copy the LocalSettings.php file to the desired location (032 comments) [core] - 10https://gerrit.wikimedia.org/r/114966 (https://bugzilla.wikimedia.org/60534) (owner: 10Mjnovice) [04:47:00] 3MediaWiki / 3Page editing: Please add full stop and space after "undo" default edit summary - 10https://bugzilla.wikimedia.org/67114#c3 (10jonesey95) I believe that Comment 1 is not relevant to this request. There is already an edit summary, since this change would apply only to "undo" edits. I provided an... [05:12:14] 3Wikimedia / 3Site requests: Create moderator group at the Vietnamese Wikipedia - 10https://bugzilla.wikimedia.org/68612#c3 (10Minh Nguyễn) (In reply to Dereckson from comment #1) > 28 people have participated to the consultation, 18 supports the motion. If I'm counting correctly, [[vi:Wikipedia:Biểu quyết/... [05:13:59] 3MediaWiki / 3Page editing: Please add full stop and space after "undo" default edit summary - 10https://bugzilla.wikimedia.org/67114#c4 (10TeleComNasSprVen) What's wrong with simply editing [[MediaWiki:Undo-summary]]? [05:15:59] 3Wikimedia / 3Site requests: Create moderator group at the Vietnamese Wikipedia - 10https://bugzilla.wikimedia.org/68612#c4 (10Minh Nguyễn) I think it'd also be fine if we reuse "eliminator" as the internal name but keep "điều phối viên" (coordinator) as the translation, just as the Vietnamese wikis translat... [05:20:30] 3Wikimedia / 3Site requests: Create moderator group at the Vietnamese Wikipedia - 10https://bugzilla.wikimedia.org/68612#c5 (10TeleComNasSprVen) 5UNCO>3NEW (In reply to Minh Nguyễn from comment #3) > I was of the same opinion, but the general consensus was that the > administrators need help with these t... [05:36:55] (03PS12) 10Bsitu: Break notifications into alert and message sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 [07:12:58] 3Wikimedia / 3Site requests: Create moderator group at the Vietnamese Wikipedia - 10https://bugzilla.wikimedia.org/68612#c6 (10Minh Nguyễn) (In reply to TeleComNasSprVen from comment #5) > (In reply to Minh Nguyễn from comment #3) > > I was of the same opinion, but the general consensus was that the > > admi... [07:39:20] (03PS2) 10Wctaiwan: Enable editing of old revisions [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/149525 [07:48:26] (03PS3) 10Wctaiwan: Enable editing of old revisions [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/149525 [08:01:43] (03PS4) 10Wctaiwan: Enable editing of old revisions [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/149525 [08:47:13] (03CR) 10Umherirrender: "parser cache used ParserOutput objects, but I have no parser cached installed to test this." [core] - 10https://gerrit.wikimedia.org/r/149382 (owner: 10Umherirrender) [08:53:43] 3MediaWiki extensions / 3Translate: Skipped PageTranslationParserTest::testParsing: Extended validation not yet implemented - 10https://bugzilla.wikimedia.org/68641#c1 (10Niklas Laxström) Nemo: "not yet implemented" means the code to be tested is not yet implemented. [09:07:08] (03CR) 10Nikerabbit: Add mw-ui-checkbox (031 comment) [core] - 10https://gerrit.wikimedia.org/r/149121 (owner: 10Jdlrobson) [09:32:34] (03CR) 10Nemo bis: [C: 04-1] "Rationale in commit message would be helpful. https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines" [core] - 10https://gerrit.wikimedia.org/r/149522 (owner: 10Cook879) [09:34:42] 3MediaWiki extensions / 3Translate: Skipped PageTranslationParserTest::testParsing: Extended validation not yet implemented - 10https://bugzilla.wikimedia.org/68641 (10Nemo) 5NEW>3UNCO [09:37:09] (03CR) 10Nikerabbit: "Siebrand: not my area of expertise. Probably needs someone to check for security implications and perhaps also to device a generic solutio" [core] - 10https://gerrit.wikimedia.org/r/149507 (https://bugzilla.wikimedia.org/56439) (owner: 10TTO) [09:47:27] 3MediaWiki / 3Internationalization: "Show"/"Hide" links in recent changes / watchlist options box should be localizable per item - 10https://bugzilla.wikimedia.org/58449#c40 (10Umar) We have forgotten so these. https://translatewiki.net/w/i.php?title=MediaWiki:Whatlinkshere-hideredirs/ce&action=edit https... [09:49:02] (03PS1) 10Umherirrender: Allow message params on HTMLForm::setWrapperLegendMsg/setSubmitTextMsg [core] - 10https://gerrit.wikimedia.org/r/149618 [09:52:07] (03PS2) 10Umherirrender: Allow message params on HTMLForm::setWrapperLegendMsg/setSubmitTextMsg [core] - 10https://gerrit.wikimedia.org/r/149618 [09:52:27] (03CR) 10Umherirrender: "Patch Set 2: Added missing /*, ... */" [core] - 10https://gerrit.wikimedia.org/r/149618 (owner: 10Umherirrender) [09:52:59] 3MediaWiki / 3Export/Import: Special:Import: "XML import parse failure" and wrong number of imported revisions - 10https://bugzilla.wikimedia.org/9911#c12 (10This, that and the other (TTO)) Note that this bug was filed when Import was using the expat-based "XML Parser" PHP framework. Currently, Import uses... [09:54:46] (03PS20) 10Brion VIBBER: Work in progress: early testing of integration with ogv.js media player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) [10:00:15] (03CR) 10Brion VIBBER: "PS20 adds MobileFrontend overlay integration similar to the image view overlay. This overlay also applies on MobileFrontend in browsers th" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [10:03:30] 3MediaWiki / 3Export/Import: XML import does not update the redirect table - 10https://bugzilla.wikimedia.org/12507 (10This, that and the other (TTO)) 5NEW>3ASSI a:5Ariel T. Glenn>3This, that and the other (TTO) [10:11:40] (03PS1) 10Nikerabbit: Remove text output while running tests [core] - 10https://gerrit.wikimedia.org/r/149620 [10:25:34] (03PS34) 10Paladox: Update jquery.validate from 1.8.1 to 1.9.0 [core] - 10https://gerrit.wikimedia.org/r/145311 [10:26:27] (03CR) 10Nikerabbit: [C: 04-1] "I see no reason we couldn't implement this in a way recommended by the documentation: accept a Message object in addition to the string." [core] - 10https://gerrit.wikimedia.org/r/149618 (owner: 10Umherirrender) [10:36:13] (03CR) 10Nikerabbit: "Needs followup." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [10:42:57] 3MediaWiki / 3Export/Import: XML import does not update the redirect table - 10https://bugzilla.wikimedia.org/12507#c5 (10This, that and the other (TTO)) 5ASSI>3RESO/WOR Import/export redirect handling has been overhauled since 2008, and since I can't reproduce this bug locally, we can safely assume it h... [10:44:16] 3MediaWiki extensions / 3Scribunto: hhvm: assertions in LuaSandbox: UstringLibraryTests - 10https://bugzilla.wikimedia.org/68668 (10Nemo) 3NEW p:3Unprio s:3normal a:3None $ php --version HipHop VM 3.3.0-dev (rel) Compiler: heads/wikimedia-0-g8b842db4e2db664a9b4d543047ae154a6dd59de6 Repo schema: ce469... [10:45:13] 3MediaWiki extensions / 3Scribunto: hhvm: assertions in LuaSandbox: UstringLibraryTests and testArgumentParsingTime - 10https://bugzilla.wikimedia.org/68668 (10Nemo) [10:47:00] (03CR) 10Nikerabbit: [C: 04-1] "Thanks for this patch. It confirms my suspicion that clicking the text no longer toggles the checkbox. Having the checkbox itself be bigge" [core] - 10https://gerrit.wikimedia.org/r/149476 (owner: 10Jdlrobson) [10:49:56] interesting one Nikerabbit [10:56:14] 3MediaWiki / 3General/Unknown: HPHP::JIT::Type::bitsFromDataType(HPHP::DataType, HPHP::DataType): assertion `false && "Unsupported DataType"' failed. - 10https://bugzilla.wikimedia.org/68621#c3 (10Nemo) Most suites can be run to the end, but this can't: $ php phpunit.php suites/ExtensionsParserTestSuite.php... [11:06:57] (03PS1) 10TTO: Preserve log comment text field value across import attempts [core] - 10https://gerrit.wikimedia.org/r/149621 (https://bugzilla.wikimedia.org/16793) [11:35:17] 3MediaWiki / 3Skin and page rendering: action links fall apart upon stong zoom - 10https://bugzilla.wikimedia.org/68670 (10Dan Jacobson) 3NEW p:3Unprio s:3minor a:3None Created attachment 16047 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16047&action=edit "Read" etc. jump down Do e.g., $... [11:38:13] 3MediaWiki / 3Export/Import: Plus sign in Template causes "Got bogus revision with null title!" - 10https://bugzilla.wikimedia.org/5814#c5 (10This, that and the other (TTO)) 5NEW>3RESO/WOR (In reply to Rob Church from comment #4) > If a bogus title is encountered, a more intuitive error message m... [11:40:42] <wikibugs> 3MediaWiki / 3Skin and page rendering: action links fall apart upon stong zoom - 10https://bugzilla.wikimedia.org/68670#c1 (10Dan Jacobson) Indeed, while hitting CTRL++ we notice that "Search" moves down to a second line, leaving a "Page" at top with plenty of room next to it that could be used... [11:41:27] <wikibugs> 3MediaWiki / 3Skin and page rendering: action links fall apart upon strong zoom - 10https://bugzilla.wikimedia.org/68670 (10Dan Jacobson) [11:43:59] <grrrit-wm> (03CR) 10Florianschmidtwelzow: "Will create a follow up." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [12:10:56] <grrrit-wm> (03PS3) 1001tonythomas: Changed the SwiftMailer repo location from Wiki-repo to defualt [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/149516 [12:18:14] <grrrit-wm> (03CR) 10Yurik: [C: 032] Remove text output while running tests [core] - 10https://gerrit.wikimedia.org/r/149620 (owner: 10Nikerabbit) [12:20:43] <grrrit-wm> (03PS1) 10Florianschmidtwelzow: Fix getAutosummary for create blank page [core] - 10https://gerrit.wikimedia.org/r/149623 (https://bugzilla.wikimedia.org/57238) [12:21:16] <grrrit-wm> (03Merged) 10jenkins-bot: Remove text output while running tests [core] - 10https://gerrit.wikimedia.org/r/149620 (owner: 10Nikerabbit) [12:21:57] <grrrit-wm> (03PS2) 10Florianschmidtwelzow: Fix getAutosummary for create blank page [core] - 10https://gerrit.wikimedia.org/r/149623 (https://bugzilla.wikimedia.org/57238) [12:22:09] <grrrit-wm> (03PS3) 10Florianschmidtwelzow: Fix getAutosummary for create blank page [core] - 10https://gerrit.wikimedia.org/r/149623 (https://bugzilla.wikimedia.org/57238) [12:22:45] <grrrit-wm> (03CR) 10Nikerabbit: "The language selector does not work at all with this patch. I tested both with and without JavaScript." [core] - 10https://gerrit.wikimedia.org/r/147904 (owner: 10Kunalgrover05) [12:22:56] <grrrit-wm> (03CR) 10Florianschmidtwelzow: "-> I3457c36a909d1dbfaeed04a1f0568c69e0ef3386" [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [12:23:18] <grrrit-wm> (03PS1) 10Nikerabbit: Revert "Make a hidden form field to keep the language code" [core] - 10https://gerrit.wikimedia.org/r/149624 [12:25:47] <wikibugs> 3MediaWiki extensions / 3CirrusSearch: hhvm: SolrTTMServerTest::testSearchableTTMServer BadMethodCallException: Call to a member function getMessage() on a non-object (NULL) - 10https://bugzilla.wikimedia.org/68672 (10Nemo) 3NEW p:3Unprio s:3normal a:3None This doesn't happen to me with php5 but does... [12:26:58] <wikibugs> 3MediaWiki extensions / 3CirrusSearch: hhvm: SolrTTMServerTest::testSearchableTTMServer BadMethodCallException: Call to a member function getMessage() on a non-object (NULL) - 10https://bugzilla.wikimedia.org/68672 (10Nemo) [12:26:58] <wikibugs> 3MediaWiki extensions / 3Translate: Fatal error: Call to a member function getMessage() on a non-object in /mediawiki/extensions/Translate/tag/TranslatablePage.php on line 253 - 10https://bugzilla.wikimedia.org/67295#c6 (10Nemo) Bug 68672 may be a duplicate. [12:31:29] <wikibugs> 3MediaWiki extensions / 3DynamicPageList: Add a README - 10https://bugzilla.wikimedia.org/68673 (10Pierre Rudloff) 3UNCO p:3Unprio s:3trivia a:3None It would be nice to add README file explaining how to use the extension and how to contribute. [12:40:08] <grrrit-wm> (03CR) 10Nikerabbit: [C: 031] Fix getAutosummary for create blank page [core] - 10https://gerrit.wikimedia.org/r/149623 (https://bugzilla.wikimedia.org/57238) (owner: 10Florianschmidtwelzow) [12:41:17] <grrrit-wm> (03CR) 10Kunalgrover05: "Sorry, I didn't test it without the ULS patch, expected it to be merged with that." [core] - 10https://gerrit.wikimedia.org/r/147904 (owner: 10Kunalgrover05) [12:48:44] <wikibugs> 3MediaWiki / 3Export/Import: Special:Import: "XML import parse failure" and wrong number of imported revisions - 10https://bugzilla.wikimedia.org/9911 (10Andre Klapper) [12:52:13] <wikibugs> 3MediaWiki / 3Unit tests: slow query: INSERT /* JobQueueDB::doBatchPush 127.0.0.1 */ INTO `unittest_job` etc. - 10https://bugzilla.wikimedia.org/68620 (10Andre Klapper) p:5Unprio>3Low [12:53:27] <wikibugs> 3MediaWiki extensions / 3DynamicPageList: Add a README - 10https://bugzilla.wikimedia.org/68673#c1 (10Andre Klapper) p:5Unprio>3Immedi s:5trivia>3enhanc I'd expect this to be pretty much covered by https://www.mediawiki.org/wiki/Extension:DynamicPageList_%28Wikimedia%29 [12:53:59] <wikibugs> 3MediaWiki extensions / 3DynamicPageList: Ignore subpages - 10https://bugzilla.wikimedia.org/68674 (10Pierre Rudloff) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16048 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16048&action=edit Patch For our wiki, we needed a way to list all pa... [12:54:13] <wikibugs> 3MediaWiki / 3Skin and page rendering: action links fall apart upon strong zoom - 10https://bugzilla.wikimedia.org/68670#c2 (10Bartosz Dziewoński) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 54919 *** [12:54:13] <wikibugs> 3MediaWiki / 3Skin and page rendering: [collapsibleTabs] Tabs (Read / View Source / Search) wrap to next line and cover content if screen width < ~700px - 10https://bugzilla.wikimedia.org/54919#c16 (10Bartosz Dziewoński) *** Bug 68670 has been marked as a duplicate of this bug. *** [12:54:44] <wikibugs> 3MediaWiki extensions / 3Translate: hhvm: phpunit assertion failure: in progress after first translation - 10https://bugzilla.wikimedia.org/68675 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Only happens with hhvm: 18) MessageGroupStatesUpdaterJobTest::testHooks in progress after first translation Fail... [12:55:27] <wikibugs> 3MediaWiki / 3API: phpunit failure: ApiOptionsTest::testReset User::saveSettings() was not expected to be called more than once - 10https://bugzilla.wikimedia.org/68654 (10Andre Klapper) p:5Unprio>3Normal [12:55:43] <wikibugs> 3MediaWiki extensions / 3DynamicPageList: Add a README - 10https://bugzilla.wikimedia.org/68673#c2 (10Pierre Rudloff) Maybe just a README file with a link to this page, then ? [12:55:57] <wikibugs> 3MediaWiki extensions / 3ProofreadPage: phpunit: SKIPPED: djvu binaries do not exist or are not executable - 10https://bugzilla.wikimedia.org/68638 (10Andre Klapper) p:5Unprio>3Low [12:56:29] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 032] Fix getAutosummary for create blank page [core] - 10https://gerrit.wikimedia.org/r/149623 (https://bugzilla.wikimedia.org/57238) (owner: 10Florianschmidtwelzow) [12:59:00] <grrrit-wm> (03Merged) 10jenkins-bot: Fix getAutosummary for create blank page [core] - 10https://gerrit.wikimedia.org/r/149623 (https://bugzilla.wikimedia.org/57238) (owner: 10Florianschmidtwelzow) [12:59:14] <wikibugs> 3MediaWiki extensions / 3Translate: Show [edit]-link if needed - 10https://bugzilla.wikimedia.org/68578#c1 (10Nemo) 5NEW>3RESO/WON I already told you, this is not going to happen. Edit section links were disabled on translation pages on purpose. 19.02 < Nemo_bis> You should do the opposite IMHO 19.03 <... [12:59:28] <wikibugs> 3MediaWiki / 3Page editing: MediaWiki should not prevent creation of empty pages - 10https://bugzilla.wikimedia.org/57238 (10Florian) 5PATC>3RESO/FIX [13:06:18] <grrrit-wm> (03PS3) 1001tonythomas: Changed static function modules in the API class to another class [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/149324 [13:06:59] <wikibugs> 3MediaWiki extensions / 3WikidataClient: After selecting non-English language on wikidata.org, must enter month name of a date property in English - 10https://bugzilla.wikimedia.org/68622#c2 (10Andre Klapper) a:3Wikidata bugs Thanks for taking the time to report this! On https://www.wikidata.org/ without... [13:09:59] <wikibugs> 3MediaWiki extensions / 3WikidataClient: After selecting non-English language on wikidata.org, must enter month name of a date property in English - 10https://bugzilla.wikimedia.org/68622#c3 (10Lydia Pintscher) 5UNCO>3RESO/DUP *** This bug has been marked as a duplicate of bug 48962 *** [13:10:03] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: localize display of time values - 10https://bugzilla.wikimedia.org/48962#c10 (10Lydia Pintscher) *** Bug 68622 has been marked as a duplicate of this bug. *** [13:14:13] <grrrit-wm> (03CR) 10Hoo man: "Just one thing about naming: If something starts with an uppercase layer, if can be used to construct an object (like new Title(); new PDO" (031 comment) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/149324 (owner: 1001tonythomas) [13:14:59] <wikibugs> 3MediaWiki extensions / 3FundraisingChart: Unused code in FundraisingChart - 10https://bugzilla.wikimedia.org/68510 (10Andre Klapper) [13:14:59] <wikibugs> 3MediaWiki / 3General/Unknown: Code quality issues (tracking) - 10https://bugzilla.wikimedia.org/700 (10Andre Klapper) [13:15:27] <wikibugs> 3Wikimedia / 3IRC: stream.wikimedia.org - redirect http(s) to docs - 10https://bugzilla.wikimedia.org/68528 (10Andre Klapper) p:5Unprio>3Normal [13:15:57] <wikibugs> 3Wikimedia / 3General/Unknown: Get dbpedia off OAI - 10https://bugzilla.wikimedia.org/68538 (10Andre Klapper) p:5Unprio>3Normal [13:16:44] <wikibugs> 3Wikimedia / 3SSL related: https://lists.wikimedia.org/pipermail/somelist/ redirects to http://lists.wikimedia.org/pipermail/somelist/ - 10https://bugzilla.wikimedia.org/68553 (10Andre Klapper) p:5Unprio>3Normal [13:18:27] <grrrit-wm> (03PS4) 1001tonythomas: Changed static function modules in the API class to another class [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/149324 [13:19:00] <wikibugs> 3Wikimedia / 3SSL related: https://planet.wikimedia.org redirects to http://meta.wikimedia.org/wiki/Planet_Wikimedia - 10https://bugzilla.wikimedia.org/68554#c2 (10Andre Klapper) p:5Unprio>3Normal (For the records, this was already mentioned in bug 39678 comment 4) [13:19:15] <wikibugs> 3MediaWiki / 3Special pages: Make "Special:UnusedFiles" appear like "Special:ListFiles" - 10https://bugzilla.wikimedia.org/68575 (10Andre Klapper) p:5Unprio>3Low [13:19:28] <wikibugs> 3MediaWiki extensions / 3ExtensionDistributor: ExtensionDistributor: Fetch branch information from Gerrit - 10https://bugzilla.wikimedia.org/68608 (10Andre Klapper) p:5Unprio>3Normal [13:22:00] <grrrit-wm> (03CR) 10Hoo man: [C: 032] ":)" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/149324 (owner: 1001tonythomas) [13:22:02] <grrrit-wm> (03CR) 10Nikerabbit: "It has to work without ULS. It also has to work without any JavaScript at all. This is MediaWiki core policy." [core] - 10https://gerrit.wikimedia.org/r/147904 (owner: 10Kunalgrover05) [13:22:04] <grrrit-wm> (03Merged) 10jenkins-bot: Changed static function modules in the API class to another class [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/149324 (owner: 1001tonythomas) [13:23:30] <wikibugs> 3MediaWiki extensions / 3Spam Blacklist: Warning: file_get_contents(): Peer certificate CN=`*.wikipedia.org' did not match expected CN=`meta.wikimedia.org' in .../extensions/SpamBlacklist/BaseBlacklist.php on line 273 - 10https://bugzilla.wikimedia.org/68581 (10Andre Klapper) p:5Unprio>3Normal [13:29:13] <wikibugs> 3MediaWiki / 3General/Unknown: HPHP::JIT::Type::bitsFromDataType(HPHP::DataType, HPHP::DataType): assertion `false && "Unsupported DataType"' failed. - 10https://bugzilla.wikimedia.org/68621#c4 (10Nemo) $ hhvm --version HipHop VM 3.3.0-dev (rel) Compiler: heads/wikimedia-0-g8b842db4e2db664a9b4d543047ae154a6d... [13:31:46] <wikibugs> 3MediaWiki extensions / 3DynamicPageList: Add a README - 10https://bugzilla.wikimedia.org/68673#c3 (10Andre Klapper) p:5Immedi>3Low If you feel like cooking up a patch to speed up things, you are welcome to use Developer access https://www.mediawiki.org/wiki/Developer_access to submit this as a Git bra... [13:33:30] <wikibugs> 3MediaWiki extensions / 3DynamicPageList: Ignore subpages - 10https://bugzilla.wikimedia.org/68674#c1 (10Andre Klapper) Hi! Thanks for your patch! You are welcome to use Developer access https://www.mediawiki.org/wiki/Developer_access to submit this as a Git branch directly into Gerrit: https://www.medi... [14:06:18] <grrrit-wm> (03PS1) 10Rudloff: ignoresubpages parameter [extensions/intersection] - 10https://gerrit.wikimedia.org/r/149628 [14:06:38] <grrrit-wm> (03CR) 10KartikMistry: [C: 031] Fix socket errors: buffer apertium stdout [services/cxserver] - 10https://gerrit.wikimedia.org/r/148968 (owner: 10Divec) [14:17:59] <wikibugs> 3MediaWiki extensions / 3DynamicPageList: Ignore subpages - 10https://bugzilla.wikimedia.org/68674#c2 (10Pierre Rudloff) Here is the change in Gerrit: https://gerrit.wikimedia.org/r/149628 [14:22:31] <grrrit-wm> (03PS1) 10Rudloff: Create README.md [extensions/intersection] - 10https://gerrit.wikimedia.org/r/149631 [14:25:32] <wikibugs> 3MediaWiki extensions / 3DynamicPageList: Add a README - 10https://bugzilla.wikimedia.org/68673#c4 (10Pierre Rudloff) Here is a basic README: https://gerrit.wikimedia.org/r/149631 [14:31:27] <grrrit-wm> (03PS3) 10IAlex: Remove some duplicate newlines in call to wfDebug() [core] - 10https://gerrit.wikimedia.org/r/149288 (owner: 10Hashar) [14:31:40] <grrrit-wm> (03CR) 10IAlex: [C: 032] Remove some duplicate newlines in call to wfDebug() [core] - 10https://gerrit.wikimedia.org/r/149288 (owner: 10Hashar) [14:34:53] <grrrit-wm> (03Merged) 10jenkins-bot: Remove some duplicate newlines in call to wfDebug() [core] - 10https://gerrit.wikimedia.org/r/149288 (owner: 10Hashar) [14:36:05] <AndyRussG> Hi, anyone out there have some experience with qunit? [14:38:14] <wikibugs> 3MediaWiki extensions / 3WikidataClient: After selecting non-English language on wikidata.org, must enter month name of a date property in English - 10https://bugzilla.wikimedia.org/68622#c4 (10Olivier Delaune) (In reply to Andre Klapper from comment #2) > Thanks for taking the time to report this! > > On h... [14:39:01] <Reedy> AndyRussG: I suspect it's a question of who's around that does [14:40:15] <wikibugs> 3MediaWiki extensions / 3CodeEditor: [Regression] Disabled CodeEditor prevents toolbar functions to work - 10https://bugzilla.wikimedia.org/68556#c4 (10Bartosz Dziewoński) Was https://gerrit.wikimedia.org/r/#/c/149529/ a fix for this bug? [14:41:34] <AndyRussG> Reedy: Hmmm... have you done qunit tests? I'm just trying to figure out the best way to refactor a very small bit of code to make it testable [14:42:12] <AndyRussG> Or if not whom do you think I should ping? [14:42:19] <MatmaRex> !ask [14:42:19] <wm-bot> Please feel free to ask your question: if anybody who knows the answer is around, they will surely reply. Don't ask for help or for attention before actually asking your question, that's just a waste of time – both yours and everybody else's. :) [14:42:44] <MatmaRex> i might be able to help, but i have no idea before i hear the question [14:43:12] <AndyRussG> MatmaRex: OK here goes, and thanks for the tip, you're right (or wm-bot is right) of course [14:43:12] <wm-bot> Hey AndyRussG, you are welcome! [14:43:55] <AndyRussG> The main question I have is separating out function declaration from execution on load [14:44:09] <AndyRussG> One sec let me get a link to the code to test [14:45:55] <AndyRussG> Blurggg a wee mess of unmerged patches here... [14:46:30] <AndyRussG> https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCampaigns/657748ee056a632b0ec867708909f42db7fdd99f/modules%2Fext.campaigns.js [14:47:27] <AndyRussG> So it's really a small bit of code. Normally I wouldn't separate it out into components for such a small and specific bit of JS [14:48:16] <AndyRussG> But as far as I understand from what I've seen of qunit, you can only test functions that are globally accessible somehow (is that so?) [14:48:31] <AndyRussG> So I think I have to make two modules [14:49:02] <AndyRussG> One that declares the functions that I want to test and attaches them to something like mw.campaigns.someFunctionName [14:49:39] <AndyRussG> And another much smaller one, that will have the first one as a dependency and will call the functions needed when it's loaded [14:50:25] <AndyRussG> And so the actual page will add the second module which will bring in the first as a dependency, and the test will only load the first [14:50:31] <AndyRussG> Does that make sense? [14:51:05] <AndyRussG> MatmaRex, Reedy: ^ And thanks in advance!! ;) [14:52:07] <MatmaRex> AndyRussG: makes perfect sense to me :) [14:53:27] <grrrit-wm> (03CR) 10Parent5446: [C: 032] Revert "Make a hidden form field to keep the language code" [core] - 10https://gerrit.wikimedia.org/r/149624 (owner: 10Nikerabbit) [14:53:33] <AndyRussG> MatmaRex: OK, thanks, that's nice to hear! [14:54:16] <AndyRussG> As in, if I don't separate it out into two modules, the tests might be contaminated by the execution of code on load, no? [14:54:55] <AndyRussG> Here in the qunit tutorial example http://qunitjs.com/intro/ [14:54:58] <MatmaRex> yeah [14:55:03] <AndyRussG> (scroll down to the bottom for the final version) [14:55:07] <github> [13cssjanus] 15ocean90 opened pull request #20: border-radius with !important produces wrong output (06master...06master) 02http://git.io/NuK0oA [14:55:28] <AndyRussG> they embed the initial call to run code into the html [14:56:00] <AndyRussG> and so the JS file to test is basically declarative [14:56:31] <grrrit-wm> (03Merged) 10jenkins-bot: Revert "Make a hidden form field to keep the language code" [core] - 10https://gerrit.wikimedia.org/r/149624 (owner: 10Nikerabbit) [14:57:30] <AndyRussG> (the file with the code they're testing is the third-to-last code block, prettydate2.js) [14:59:26] <MatmaRex> AndyRussG: yeah. we usually just create another RL module depending on the "declarative" one, like you described earlier [15:00:08] <AndyRussG> OK, good to hear I wasn't completely off-base... :) thanks so much [15:00:14] <AndyRussG> I guess if that's how it works my second question is also answered. I was just a bit hesitante to make all the methods I want to test publicly and globally available [15:00:32] <MatmaRex> AndyRussG: yeah, that's just a JavaScript limitation :/ [15:00:44] <MatmaRex> AndyRussG: you can just document them as @private [15:01:13] <AndyRussG> Ah OK! That sounds decent [15:02:55] <AndyRussG> I guess it might seem like a bit of a contradiction to someone reading the code, as in: "here's a method that I'm making globally available--oh, but it's @private, BTW." But if that's what you do, then that's also what everyone'll be used to reading I guess [15:04:43] * AndyRussG greps about looking for @private annotations to check out [15:05:30] <Reedy> @private in MediaWiki PHP seems to often be a lie :) [15:05:31] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: SnakUnserializer must not fail on mismatching hashes - 10https://bugzilla.wikimedia.org/68565 (10Jeroen De Dauw) 5PATC>3RESO/FIX [15:06:29] <AndyRussG> what, programmers lying in code documentation? ohhhhh.... [15:09:53] <MatmaRex> haha, yeah, if something is marked as @private in PHP, then that's a wish, not a fact [15:10:06] <MatmaRex> we're a bit better with this in JS ;) [15:10:54] <AndyRussG> Hmmm in PHP I just declare 'em private or protected, no annotations involved 8p [15:12:32] <Reedy> It's either lying [15:12:40] <Reedy> Or people doing stupid shit with things [15:17:14] <grrrit-wm> (03CR) 10Helder.wiki: "This is related to" [core] - 10https://gerrit.wikimedia.org/r/149529 (owner: 10TheDJ) [15:17:32] <grrrit-wm> (03PS3) 10Umherirrender: Allow message object on HTMLForm::setWrapperLegendMsg/setSubmitTextMsg [core] - 10https://gerrit.wikimedia.org/r/149618 [15:17:55] <grrrit-wm> (03CR) 10Umherirrender: "Patch Set 3: Addressed comment" [core] - 10https://gerrit.wikimedia.org/r/149618 (owner: 10Umherirrender) [15:18:02] <wikibugs> 3MediaWiki / 3Page editing: Please add full stop and space after "undo" default edit summary - 10https://bugzilla.wikimedia.org/67114#c5 (10jonesey95) Re Comment 4: That is what is needed. Thank you for identifying the solution. Can someone please add a full stop, followed by a space, to this default edit s... [15:21:29] <grrrit-wm> (03PS1) 10Umherirrender: Fix param of OutputPage::setHTMLTitle [core] - 10https://gerrit.wikimedia.org/r/149634 [15:22:04] <grrrit-wm> (03PS2) 10Umherirrender: Fix param doc of OutputPage::setHTMLTitle [core] - 10https://gerrit.wikimedia.org/r/149634 [15:30:11] <grrrit-wm> (03PS2) 10tosfos: i18n/en fixes [extensions/SimpleChanges] - 10https://gerrit.wikimedia.org/r/148884 [15:30:36] <grrrit-wm> (03CR) 10IAlex: [C: 032] Fix param doc of OutputPage::setHTMLTitle [core] - 10https://gerrit.wikimedia.org/r/149634 (owner: 10Umherirrender) [15:31:30] <grrrit-wm> (03CR) 10tosfos: [C: 031 V: 032] i18n/en fixes [extensions/SimpleChanges] - 10https://gerrit.wikimedia.org/r/148884 (owner: 10tosfos) [15:33:05] <grrrit-wm> (03Merged) 10jenkins-bot: Fix param doc of OutputPage::setHTMLTitle [core] - 10https://gerrit.wikimedia.org/r/149634 (owner: 10Umherirrender) [15:38:08] <AndyRussG> Hmmm lots of @private declarations here: [15:38:08] <AndyRussG> https://git.wikimedia.org/blob/mediawiki%2Fcore/8012165a229180a16490ee6e4992b8f8817e8137/includes%2FSkinTemplate.php [15:39:24] <wikibugs> 3MediaWiki extensions / 3DynamicPageList: Ignore subpages - 10https://bugzilla.wikimedia.org/68674#c3 (10Andre Klapper) 5UNCO>3PATC Thanks! (For future reference, following http://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines creates an automatic notification in this bug report so it might be w... [15:39:38] <wikibugs> 3MediaWiki extensions / 3DynamicPageList: Add a README - 10https://bugzilla.wikimedia.org/68673#c5 (10Andre Klapper) 5UNCO>3PATC Thanks! (For future reference, following http://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines creates an automatic notification in this bug report so it might be wort... [15:41:30] <grrrit-wm> (03PS2) 10Rudloff: Create README.md [extensions/intersection] - 10https://gerrit.wikimedia.org/r/149631 (https://bugzilla.wikimedia.org/68673) [15:44:07] <MatmaRex> AndyRussG: lolskintemplate [15:44:08] <grrrit-wm> (03PS2) 10Rudloff: ignoresubpages parameter [extensions/intersection] - 10https://gerrit.wikimedia.org/r/149628 (https://bugzilla.wikimedia.org/68674) [15:44:17] <MatmaRex> AndyRussG: don't look at that code if you value your sanity [15:44:23] <AndyRussG> heheheheh [15:45:00] <AndyRussG> https://www.mediawiki.org/wiki/Requests_for_comment/Redo_skin_framework [15:48:21] <grrrit-wm> (03PS2) 10IAlex: Remove return value from QueryPage::execute [core] - 10https://gerrit.wikimedia.org/r/147989 (owner: 10Umherirrender) [15:48:28] <grrrit-wm> (03CR) 10IAlex: [C: 032] Remove return value from QueryPage::execute [core] - 10https://gerrit.wikimedia.org/r/147989 (owner: 10Umherirrender) [15:51:55] <grrrit-wm> (03Merged) 10jenkins-bot: Remove return value from QueryPage::execute [core] - 10https://gerrit.wikimedia.org/r/147989 (owner: 10Umherirrender) [16:07:47] <wikibugs> 3Wikimedia / 3SSL related: https://lists.wikimedia.org/pipermail/somelist/ redirects to http://lists.wikimedia.org/pipermail/somelist/ - 10https://bugzilla.wikimedia.org/68553#c1 (10chmarkine) Related patch: https://gerrit.wikimedia.org/r/#/c/145616/ [16:14:27] <wikibugs> 3Wikimedia / 3Mailing lists: Listadmins for commons-l - 10https://bugzilla.wikimedia.org/68680 (10Steinsplitter) 3NEW p:3Unprio s:3enhanc a:3None The listadmin is atm Avatar [Commons-l list run by wikipedia-listadmin at computerkultur.org]. He is inactive (desysopped because inactivity time ago - htt... [16:19:20] <grrrit-wm> (03CR) 10Withoutaname: "Have you considered using the /sites/ table to populate wgImportSources instead?" [core] - 10https://gerrit.wikimedia.org/r/84194 (owner: 10TTO) [16:41:09] <wikibugs> 3Wikimedia / 3Mailing lists: Listadmins for commons-l - 10https://bugzilla.wikimedia.org/68680 (10Tomasz W. Kozlowski) p:5Unprio>3Normal [16:51:46] <grrrit-wm> (03CR) 10Yaron Koren: "Hi," [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/147991 (owner: 10Scott-linder) [16:57:38] <wikibugs> 3MediaWiki extensions / 3Translate: Show [edit]-link if needed - 10https://bugzilla.wikimedia.org/68578#c2 (10Steinsplitter) 5RESO/WON>3REOP No. This breaks too much. This was requested multiple times onwiki. [16:58:49] <grrrit-wm> (03CR) 10Florianschmidtwelzow: [C: 032] Don't redirect to Google auth if user hit enter [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/149540 (https://bugzilla.wikimedia.org/68143) (owner: 10Florianschmidtwelzow) [16:58:55] <grrrit-wm> (03Merged) 10jenkins-bot: Don't redirect to Google auth if user hit enter [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/149540 (https://bugzilla.wikimedia.org/68143) (owner: 10Florianschmidtwelzow) [17:07:23] <wikibugs> 3MediaWiki-Vagrant: globalcssjs: Exception from line 79 of includes/db/CloneDatabase.php: Cannot clone shared table objectcache - 10https://bugzilla.wikimedia.org/68624#c1 (10Kunal Mehta (Legoktm)) What happens if you use the CentralAuth role instead of just including the extension? [17:09:00] <grrrit-wm> (03CR) 10Legoktm: [C: 032 V: 032] Changed the SwiftMailer repo location from Wiki-repo to defualt [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/149516 (owner: 1001tonythomas) [17:13:40] <grrrit-wm> (03CR) 10Legoktm: [C: 04-1] Enable editing of old revisions (032 comments) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/149525 (owner: 10Wctaiwan) [17:13:58] <grrrit-wm> (03CR) 10Siebrand: [C: 032] "Nice." [core] - 10https://gerrit.wikimedia.org/r/149618 (owner: 10Umherirrender) [17:14:11] <grrrit-wm> (03CR) 10Legoktm: [C: 04-1] "Needs a rebase" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/148456 (owner: 1001tonythomas) [17:15:15] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/SimpleChanges] - 10https://gerrit.wikimedia.org/r/148884 (owner: 10tosfos) [17:15:51] <wikibugs> 3MediaWiki extensions / 3Translate: Show [edit]-link if needed - 10https://bugzilla.wikimedia.org/68578#c3 (10Nemo) (In reply to Steinsplitter from comment #2) > No. This breaks too much. This was requested multiple times onwiki. Links? [17:16:24] <wikibugs> 3Wikimedia / 3Mailing lists: Listadmins for commons-l - 10https://bugzilla.wikimedia.org/68680#c1 (10James Alexander) (In reply to Steinsplitter from comment #0) > The listadmin is atm Avatar [Commons-l list run by wikipedia-listadmin at > computerkultur.org]. He is inactive (desysopped because inactivity ti... [17:17:38] <grrrit-wm> (03Merged) 10jenkins-bot: Allow message object on HTMLForm::setWrapperLegendMsg/setSubmitTextMsg [core] - 10https://gerrit.wikimedia.org/r/149618 (owner: 10Umherirrender) [17:19:40] <wikibugs> 3MediaWiki-Vagrant: globalcssjs: Exception from line 79 of includes/db/CloneDatabase.php: Cannot clone shared table objectcache - 10https://bugzilla.wikimedia.org/68624#c2 (10Nemo) (In reply to Kunal Mehta (Legoktm) from comment #1) > What happens if you use the CentralAuth role instead of just including the >... [17:21:29] <grrrit-wm> (03CR) 10Siebrand: "Sry." [core] - 10https://gerrit.wikimedia.org/r/149624 (owner: 10Nikerabbit) [17:21:54] <wikibugs> 3Datasets / 3General/Unknown: Add dbname (e.g. "enwiki", "ptwiki") to XML database dump "siteinfo" - 10https://bugzilla.wikimedia.org/68686 (10Aaron Halfaker) 3NEW p:3Unprio s:3enhanc a:3Ariel T. Glenn It would be useful to be able to check the header information on an XML database dump file to confi... [17:23:08] <wikibugs> 3MediaWiki / 3Export/Import: Add dbname (e.g. "enwiki", "ptwiki") to XML database dump "siteinfo" - 10https://bugzilla.wikimedia.org/68686 (10Sam Reed (reedy)) p:5Unprio>3Normal a:5Ariel T. Glenn>3None [17:23:38] <wikibugs> 3MediaWiki / 3Export/Import: Add dbname (e.g. "enwiki", "ptwiki") to XML database dump "siteinfo" - 10https://bugzilla.wikimedia.org/68686#c1 (10Sam Reed (reedy)) Should be r [17:24:51] <wikibugs> 3MediaWiki extensions / 3GoogleLogin: Enter should submit user login form instead of GoogleLogin - 10https://bugzilla.wikimedia.org/68143 (10Florian) 5PATC>3RESO/FIX [17:25:08] <wikibugs> 3MediaWiki / 3Export/Import: Add dbname (e.g. "enwiki", "ptwiki") to XML database dump "siteinfo" - 10https://bugzilla.wikimedia.org/68686 (10Sam Reed (reedy)) a:3Sam Reed (reedy) [17:26:15] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [17:28:06] <grrrit-wm> (03CR) 10Wctaiwan: Enable editing of old revisions (031 comment) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/149525 (owner: 10Wctaiwan) [17:30:29] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/149593 (owner: 10Jforrester) [17:31:47] <wikibugs> 3MediaWiki / 3JavaScript: jquery.makeCollapsible should allow setting standard toggles for remote handles - 10https://bugzilla.wikimedia.org/66991#c2 (10Dmitrij D. Czarkoff) My specific need is to be able to collapse a field in infobox from another field of the same infobox on Wikipedia. To follow the rule o... [17:31:51] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/149592 (owner: 10Jforrester) [17:33:54] <wikibugs> 3Wikimedia / 3Site requests: Add "abusefilter-log-detail" for rollbackers and patrollers on es.wikipedia - 10https://bugzilla.wikimedia.org/68319 (10Vogone) [17:34:11] <grrrit-wm> (03PS1) 10Brian Wolff: Fix typo in qqq.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/149641 (https://bugzilla.wikimedia.org/68635) [17:35:42] <grrrit-wm> (03PS1) 10Reedy: Add dbname to XML database dump "siteinfo" [core] - 10https://gerrit.wikimedia.org/r/149642 (https://bugzilla.wikimedia.org/68686) [17:35:55] <grrrit-wm> (03CR) 10Siebrand: Fix typo in qqq.json (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/149641 (https://bugzilla.wikimedia.org/68635) (owner: 10Brian Wolff) [17:36:38] <grrrit-wm> (03CR) 10Siebrand: [C: 032] Fix typo in qqq.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/149641 (https://bugzilla.wikimedia.org/68635) (owner: 10Brian Wolff) [17:36:45] <grrrit-wm> (03Merged) 10jenkins-bot: Fix typo in qqq.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/149641 (https://bugzilla.wikimedia.org/68635) (owner: 10Brian Wolff) [17:38:50] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 (owner: 10Bsitu) [17:39:50] <grrrit-wm> (03CR) 10Nemo bis: "Cf. bug 58279." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/147754 (owner: 10Brian Wolff) [17:45:24] <grrrit-wm> (03CR) 10Reedy: [C: 04-1] "Sigh, didn't commit the latest version" [core] - 10https://gerrit.wikimedia.org/r/149642 (https://bugzilla.wikimedia.org/68686) (owner: 10Reedy) [17:47:34] <grrrit-wm> (03CR) 10Brian Wolff: "Thanks for this. I was constantly changing the constant locally in the file." [core] - 10https://gerrit.wikimedia.org/r/143046 (owner: 10Anomie) [17:47:56] <grrrit-wm> (03PS2) 10Reedy: Add dbname to XML database dump "siteinfo" [core] - 10https://gerrit.wikimedia.org/r/149642 (https://bugzilla.wikimedia.org/68686) [17:51:23] <wikibugs> 3Wikimedia / 3Mailing lists: Hotmail/MSN/Live email systems blocking WMF IP addresses, mailing list messages being blocked - 10https://bugzilla.wikimedia.org/62838#c23 (10Andre Klapper) (In reply to billinghurst from comment #19) > RootsWeb/Ancestry went through a similar issue a week or two ago, and > Roots... [17:52:26] <grrrit-wm> (03CR) 10Siebrand: Improve MathML error handling (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135817 (owner: 10Physikerwelt) [17:52:43] <grrrit-wm> (03PS1) 10Reedy: Add comment about how to deploy new xml schema XSD files [core] - 10https://gerrit.wikimedia.org/r/149647 [17:53:51] <grrrit-wm> (03CR) 10Siebrand: [C: 032] Add comment about how to deploy new xml schema XSD files [core] - 10https://gerrit.wikimedia.org/r/149647 (owner: 10Reedy) [17:53:59] <grrrit-wm> (03CR) 10Brian Wolff: [C: 04-1] "This still has some of the same problems as PS1. Although the query is not quite as scary, its still filesorting and using an index that's" [core] - 10https://gerrit.wikimedia.org/r/148322 (https://bugzilla.wikimedia.org/12363) (owner: 10Rohan013) [17:56:46] <grrrit-wm> (03Merged) 10jenkins-bot: Add comment about how to deploy new xml schema XSD files [core] - 10https://gerrit.wikimedia.org/r/149647 (owner: 10Reedy) [17:57:16] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/135284 (owner: 10Jackmcbarn) [18:01:09] <grrrit-wm> (03CR) 10Martineznovo: "needs release notes?" [core] - 10https://gerrit.wikimedia.org/r/143046 (owner: 10Anomie) [18:02:43] <grrrit-wm> (03CR) 10Reedy: "Probably wants adding to RELEASE-NOTES too" [core] - 10https://gerrit.wikimedia.org/r/149642 (https://bugzilla.wikimedia.org/68686) (owner: 10Reedy) [18:03:11] <grrrit-wm> (03PS1) 1001tonythomas: BounceActions was made a separate class, since used in two classes [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/149648 [18:04:19] <grrrit-wm> (03PS2) 1001tonythomas: BounceActions was made a separate class, since used in two classes [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/149648 [18:07:06] <wikibugs> 3Wikimedia / 3SSL related: https://lists.wikimedia.org/pipermail/somelist/ redirects to http://lists.wikimedia.org/pipermail/somelist/ - 10https://bugzilla.wikimedia.org/68553 (10Andre Klapper) 5NEW>3PATC [18:07:50] <grrrit-wm> (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/ReorderParserPhases] - 10https://gerrit.wikimedia.org/r/135403 (owner: 10Orbartal) [18:15:55] <grrrit-wm> (03PS6) 10Umherirrender: Cleanup some docs (languages, maintenance, tests) [core] - 10https://gerrit.wikimedia.org/r/148991 [18:16:52] <grrrit-wm> (03CR) 10Siebrand: [C: 031] Add at least one RTL language to the TestSites mock collection [core] - 10https://gerrit.wikimedia.org/r/135569 (owner: 10Thiemo Mättig (WMDE)) [18:18:04] <grrrit-wm> (03CR) 10Hoo man: "good start... If you'd make use of dependency injection here, it would be awesome." (032 comments) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/149648 (owner: 1001tonythomas) [18:18:53] <grrrit-wm> (03PS1) 10Physikerwelt: Add missing period [extensions/Math] - 10https://gerrit.wikimedia.org/r/149651 [18:19:17] <grrrit-wm> (03CR) 10Siebrand: [C: 032] "i18n/L10n reviewed. Thanks." [extensions/Math] - 10https://gerrit.wikimedia.org/r/149651 (owner: 10Physikerwelt) [18:21:24] <grrrit-wm> (03Merged) 10jenkins-bot: Add missing period [extensions/Math] - 10https://gerrit.wikimedia.org/r/149651 (owner: 10Physikerwelt) [18:31:07] <wikibugs> 3MediaWiki extensions / 3Translate: Show [edit]-link if needed - 10https://bugzilla.wikimedia.org/68578#c4 (10Steinsplitter) https://commons.wikimedia.org/wiki/Commons:Forum/Archiv/2014/May#"Übersetzungswerkzeug" deaktivieren und Seite normal bearbeiten?! [18:31:15] <grrrit-wm> (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135165 (https://bugzilla.wikimedia.org/35067) (owner: 10devunt) [18:33:07] <grrrit-wm> (03CR) 10Siebrand: "I think these messages may be used in other contexts that also have to be updated. Have to check for that before I can merge this." [core] - 10https://gerrit.wikimedia.org/r/135436 (https://bugzilla.wikimedia.org/50572) (owner: 10Matěj Grabovský) [18:33:39] <wikibugs> 3Wikimedia / 3Mailing lists: Listadmins for commons-l - 10https://bugzilla.wikimedia.org/68680#c2 (10Steinsplitter) I don't like to start a RFC because of a list. Not sure if it make sense to have someone as listadmin who has edited 2012 the last time and who is no longer a commons sysop. [18:36:52] <wikibugs> 3MediaWiki / 3Recent changes: Page moves into mainspace should appear on Special:Newpages for patrol - 10https://bugzilla.wikimedia.org/12363#c40 (10Bawolff (Brian Wolff)) So to flesh out comment 38, here's what I would suggest: *In Title::moveToInternal, if this->getNamespace() !== $nt->getNamespace(), the... [18:37:51] <wikibugs> 3MediaWiki extensions / 3Translate: Allow in-page translation for typo fixes etc. - 10https://bugzilla.wikimedia.org/65723 (10Nemo) [18:39:36] <wikibugs> 3Wikimedia / 3Mailing lists: Listadmins for commons-l - 10https://bugzilla.wikimedia.org/68680#c3 (10Jesús Martínez Novo (Ciencia Al Poder)) (In reply to Steinsplitter from comment #2) > I don't like to start a RFC because of a list. Not sure if it make sense to > have someone as listadmin who has edited 201... [18:40:12] <grrrit-wm> (03CR) 10Matěj Grabovský: "They aren't in core, I checked before pushing." [core] - 10https://gerrit.wikimedia.org/r/135436 (https://bugzilla.wikimedia.org/50572) (owner: 10Matěj Grabovský) [18:41:20] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/135597 (https://bugzilla.wikimedia.org/53195) (owner: 10Parent5446) [18:41:38] <wikibugs> 3MediaWiki extensions / 3Translate: Show [edit]-link if needed - 10https://bugzilla.wikimedia.org/68578#c5 (10Nemo) 5REOP>3RESO/WON I don't see anyone there who complains about not being able to edit the transcluded page: of course I only used machine translation, but Rillke's summary is at bug 65723 and... [18:41:58] <grrrit-wm> (03CR) 10Brian Wolff: "Follow-up bb3234d37faa984464" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/147754 (owner: 10Brian Wolff) [18:42:07] <grrrit-wm> (03CR) 1001tonythomas: [C: 04-1] "@Lego: will rebase once Icb56728a93ae5a288de036b77521457a6b71e259 gets merged." [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/148456 (owner: 1001tonythomas) [18:45:40] <grrrit-wm> (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/135438 (owner: 10Matěj Grabovský) [18:47:07] <grrrit-wm> (03CR) 10Brian Wolff: Fix typo in qqq.json (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/149641 (https://bugzilla.wikimedia.org/68635) (owner: 10Brian Wolff) [18:50:37] <wikibugs> 3Wikimedia / 3Mailing lists: Listadmins for commons-l - 10https://bugzilla.wikimedia.org/68680#c4 (10Steinsplitter) Sorry? Please note i am not native speaker and i was never claimed up. I did not think that it requires so much bureaucracy. O_o [18:51:14] <grrrit-wm> (03CR) 10Siebrand: Fix typo in qqq.json (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/149641 (https://bugzilla.wikimedia.org/68635) (owner: 10Brian Wolff) [18:51:57] <kunalg> Can someone add my account to Wikimedia Tool labs? Thanks. [18:51:57] <Vulpix> > I did not think that it requires so much bureaucracy [18:52:08] <Vulpix> says someone with a @wikipedia.de email o_O [18:52:24] <wikibugs> 3MediaWiki extensions / 3Translate: Show [edit]-link if needed - 10https://bugzilla.wikimedia.org/68578#c6 (10Steinsplitter) 5RESO/WON>3REOP We can't chaneg policy pages because of this. Ples stop editwarring here, it is contra productive. [18:52:51] <Reedy> kunalg: what's your username? [18:53:20] <kunalg> Reedy: oops. its Kunalgrover05 [18:55:22] <Reedy> kunalg: done [18:55:23] <wikibugs> 3MediaWiki extensions / 3Translate: Show [edit]-link if needed - 10https://bugzilla.wikimedia.org/68578#c7 (10Siebrand Mazeland) 5REOP>3RESO/WON Thank you for re-iterating your point of view, Steinsplitter, but this feature request will not be implemented. This feature request has been denied. Please do... [18:55:29] <kunalg> Reedy: Thanks [18:56:51] <ExcitedPanda> Reedy: hmm, if a process is executing a mysql query, and the process is killed, does the query also get killed? or should it be explicitly killed with a KILL QUERY? [18:56:59] * ExcitedPanda is just hunting around for people with mysql knowledge [18:57:01] <Vulpix> > calls for stop editwarring > keeps reopening the bug ¯＼(o_o)/¯ [18:58:06] <Vulpix> ExcitedPanda: if you kill a client process, chances are that the query is still being run on the server [18:58:12] <Reedy> indeed [18:58:12] <ExcitedPanda> Vulpix: hmm, right. [18:58:22] <Reedy> killing isn't graceful [18:58:33] <ExcitedPanda> hmm, if I close the connection instead? [18:58:36] <Vulpix> please don't kill a server process or you may have data corruption! [18:58:52] <wikibugs> 3MediaWiki extensions / 3Translate: Show [edit]-link if needed - 10https://bugzilla.wikimedia.org/68578#c8 (10Steinsplitter) Mabye it is a misunderstanding. The communety has requested to make such a *feature* - it is _NOT_ my POV. Not sure why it schould be possible to make [edit] link for transclusions. M... [18:58:52] <ExcitedPanda> heh, KILL QUERY shouldn't leave any data corrupted [18:59:06] <Vulpix> kill query should be fine [18:59:22] <Vulpix> kill -9 a mysqld process not :) [18:59:39] <ExcitedPanda> right, but since the original connection would be in a blocked state at that moment (mysql has not many async connectors), I'll have to open a new connection and do this [18:59:39] <ExcitedPanda> hmm [18:59:52] <grrrit-wm> (03CR) 10Scott-linder: "Works for me, seems like a good compromise." [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/147991 (owner: 10Scott-linder) [19:00:29] <Vulpix> yes, you'll need a new connection to do the KILL QUERY [19:00:35] <ExcitedPanda> alright [19:00:40] * ExcitedPanda adds to todo list [19:01:01] <ExcitedPanda> ty Vulpix, Reedy [19:01:54] <grrrit-wm> (03PS1) 10Umherirrender: Simplify SpecialRevisiondelete::showForm a bit [core] - 10https://gerrit.wikimedia.org/r/149653 [19:02:22] <grrrit-wm> (03PS1) 10Deepali: Import external metadata from wikidata [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/149654 (https://bugzilla.wikimedia.org/51971) [19:02:36] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Import external metadata from wikidata [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/149654 (https://bugzilla.wikimedia.org/51971) (owner: 10Deepali) [19:02:38] <Vulpix> also, I learned the hard way that sometimes killing a long running query that's doing updates, just because "it stays so long" may be counter-productive, since the server needs to undo all the changes, and it would take a lot more time :S [19:02:38] <Lcawte> Where is the creation/populating of core tables tables done in the (web) installer? [19:04:08] <Reedy> Lcawte: createTables() in DatabaseInstaller [19:04:27] <Reedy> $error = $this->db->sourceFile( $this->db->getSchemaPath() ); [19:04:42] <Lcawte> That'd make sense... I looked for createDatabase and things like that. Thanks :) [19:06:46] <grrrit-wm> (03PS2) 10Deepali: Import external metadata from wikidata [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/149654 (https://bugzilla.wikimedia.org/51971) [19:06:57] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Import external metadata from wikidata [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/149654 (https://bugzilla.wikimedia.org/51971) (owner: 10Deepali) [19:09:03] <grrrit-wm> (03PS3) 10Deepali: Import external metadata from wikidata [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/149654 (https://bugzilla.wikimedia.org/51971) [19:10:03] <withoutaname> Reedy: what do you think of requestcontext [19:17:23] <wikibugs> 3Wikimedia / 3Mailing lists: Listadmins for commons-l - 10https://bugzilla.wikimedia.org/68680#c5 (10Andre Klapper) It's not "much bureaucracy" (plus bureaucracy traditionally is not a bad word). It's about creating public consensus who should be list admin *instead*. [19:19:06] <wikibugs> 3MediaWiki extensions / 3Translate: Show [edit]-link if needed - 10https://bugzilla.wikimedia.org/68578#c9 (10Andre Klapper) [Plus for the records and for future reference, Bugzilla allows adding comments without the need to change a bug report's status.] [19:27:08] <ExcitedPanda> Vulpix: Reedy hmm, interesting. I setup a query killer, but it seems that the query always gets killed as soon as the connectionc loses. [19:27:09] <ExcitedPanda> *closes [19:27:18] <ExcitedPanda> and I get a 'no such thread to kill' [19:27:25] <ExcitedPanda> I did verify my thread ID was accurate [19:28:18] <Reedy> luck? :) [19:28:25] <Vulpix> looks like mysql is smarter than MS SQL Server then :P [19:29:04] <ExcitedPanda> Reedy: Vulpix ah, no. so, if the server had finished reading the data but was still writing it to the socket because there was a lot of data, and then the connection closes, the query *does* get killed [19:29:23] <ExcitedPanda> but if I have a query that produces smaller amount of data but does a fuckton of actual computing, then the query killer just works [19:29:42] <Vulpix> yes, that's what I expect also [19:29:45] <ExcitedPanda> I first tried with select * from page LIMIT 10000; but there I guess the biggest time consumer is writing the data, so query is killed when connection dies [19:30:01] <ExcitedPanda> then I tried select count(*) from page WHERE page_title like 'the%'; [19:30:08] <ExcitedPanda> and of course, that's going to spend a lot of time computing [19:30:11] <ExcitedPanda> and my query killer worked [19:30:12] <ExcitedPanda> so yay [19:30:45] <Vulpix> aboose :P [19:43:27] <legoktm> Nemo_bis: hi [19:43:37] <Nemo_bis> hi [19:43:55] <Nemo_bis> ExcitedPanda: what turns you on? [19:44:14] <legoktm> regarding https://bugzilla.wikimedia.org/show_bug.cgi?id=68624, did you do the full setup process for CentralAuth? like setting up a separate db, adding to $wgConf, etc.? [19:44:17] <grrrit-wm> (03CR) 10Jaredzimmerman: [C: 04-1] "based on the screenshot on trello I'm going to have to veto this. They icon just does not fit stylistically. It doesn't match the new icon" [core] - 10https://gerrit.wikimedia.org/r/146979 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [19:44:20] <legoktm> http://paste.debian.net/111811/ just shows the include_once [19:44:38] <ExcitedPanda> Nemo_bis: are you asking about the nick? [19:44:59] <ExcitedPanda> legoktm: error: pathspec 'origin/REL1_19' did not match any file(s) known to git. is still happening [19:45:04] <ExcitedPanda> Nemo_bis: i did a git pull as well [19:45:17] <legoktm> ExcitedPanda: full traceback? [19:45:55] <ExcitedPanda> legoktm: I don't have full traceback, it only gave me that. but let mepaste the entire thing [19:46:03] <ExcitedPanda> legoktm: https://dpaste.de/sDCb [19:46:44] <withoutaname> did you get my message [19:47:19] <legoktm> ExcitedPanda: oh, all of those are "expected" errors. Run the script with --all? [19:47:31] <grrrit-wm> (03CR) 10Parent5446: Added password hashing API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/77645 (https://bugzilla.wikimedia.org/54948) (owner: 10Parent5446) [19:47:39] <ExcitedPanda> legoktm: ohlol [19:47:44] <ExcitedPanda> legoktm: seems to be progressing [19:47:47] <legoktm> :D [19:47:52] <grrrit-wm> (03PS38) 10Parent5446: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (https://bugzilla.wikimedia.org/54948) [19:47:54] <ExcitedPanda> legoktm: what path would nginx have to serve? [19:48:12] <legoktm> /srv/dist or whatever that is configured to [19:48:15] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (https://bugzilla.wikimedia.org/54948) (owner: 10Parent5446) [19:49:13] <grrrit-wm> (03PS1) 10Parent5446: Changed password default to PBKDF2 [core] - 10https://gerrit.wikimedia.org/r/149658 (https://bugzilla.wikimedia.org/28419) [19:49:21] <ExcitedPanda> legoktm: is /srv/dist configurable in config.py? [19:49:26] <legoktm> yes [19:49:30] <legoktm> conf.DIST_PATH [19:49:36] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Changed password default to PBKDF2 [core] - 10https://gerrit.wikimedia.org/r/149658 (https://bugzilla.wikimedia.org/28419) (owner: 10Parent5446) [19:49:51] <ExcitedPanda> legoktm: ok, couple of things. 1. you should use yaml or json there, since puppet can generate those easily, so we can put that conf in puppet as well [19:50:00] <ExcitedPanda> legoktm: and make the log file patch configurable in the same way as well [19:50:05] <ExcitedPanda> so I can make it log to /var/log [19:51:30] <grrrit-wm> (03PS39) 10Parent5446: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (https://bugzilla.wikimedia.org/54948) [19:52:54] <grrrit-wm> (03PS2) 10Parent5446: Changed password default to PBKDF2 [core] - 10https://gerrit.wikimedia.org/r/149658 (https://bugzilla.wikimedia.org/28419) [19:54:41] <wikibugs> 3MediaWiki / 3User preferences: User Preference's default options/values should be automatically marked in the special page itself - 10https://bugzilla.wikimedia.org/68689 (10Quiddity) 3NEW p:3Unprio s:3enhanc a:3None Created attachment 16049 --> https://bugzilla.wikimedia.org/attachment.cgi?id=160... [19:56:43] <ExcitedPanda> Reedy: legoktm Vulpix can you think of a query that should take more than 10m of time on labsdb? :) [19:56:46] <ExcitedPanda> just testing the killer [19:57:09] <multichill> ExcitedPanda: Plenty [19:57:16] <ExcitedPanda> multichill: can you give me one? [19:57:38] <multichill> Go to ~multichill/queries/wikidata [19:57:52] <ExcitedPanda> multichill: moment [19:58:03] <multichill> The noclaims_enwiki.sql probably takes more than 10 minutes [19:58:14] <ExcitedPanda> multichill: ok, testing [19:58:14] <multichill> The nlwp one already takes 4m48.649s [19:58:38] <multichill> It produces around 800.000 results so pipe it somewhere ExcitedPanda! [19:58:41] <ExcitedPanda> multichill: should this be run on wikidatawiki? [19:58:57] <multichill> There is a connect statement in there [19:59:51] <multichill> ExcitedPanda: Don't forget we use the toolserver/toollabs databases to run complicated queries every once in a while [20:00:11] <ExcitedPanda> multichill: :) I remember Coren killing some runaway queries that were running for like 30h [20:00:14] <multichill> For example I'm cleaning out items without claims on wikidata. Already did about 25.000 of them [20:00:24] <multichill> 30h is insane [20:00:27] <ExcitedPanda> yeah [20:00:35] <ExcitedPanda> multichill: oh wait, you meant 800,000. heh, didn't realize [20:01:04] <ExcitedPanda> multichill: PM? [20:01:21] <multichill> Sure, or in #wikimedia-labs , either way works [20:03:56] <wikibugs_> 3MediaWiki / 3Special pages: Examine/restore default settings - 10https://bugzilla.wikimedia.org/17188 (10Quiddity) [20:03:56] <wikibugs_> 3MediaWiki / 3User preferences: User Preference's default options/values should be automatically marked in the special page itself - 10https://bugzilla.wikimedia.org/68689 (10Quiddity) [20:04:10] <wikibugs_> 3MediaWiki / 3User preferences: User "Default Skin" preference - 10https://bugzilla.wikimedia.org/20553 (10Quiddity) [20:04:10] <wikibugs_> 3MediaWiki / 3User preferences: "Restore all default settings" should be a button - 10https://bugzilla.wikimedia.org/18961 (10Quiddity) [20:04:10] <wikibugs_> 3MediaWiki / 3Special pages: Unclear scope of "Restore all default settings" button (resets settings in *all* tabs) - 10https://bugzilla.wikimedia.org/33327 (10Quiddity) [20:05:39] <grrrit-wm> (03PS4) 10Scott-linder: Add #get_file_data for local files. [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/147991 [20:08:46] <ExcitedPanda> legoktm: I don't think I can get to the puppetization today. will do tomorrow :( [20:09:01] <legoktm> sure [20:09:13] <ExcitedPanda> legoktm: can you do CR? :D [20:09:18] <legoktm> links? [20:09:45] <ExcitedPanda> https://gerrit.wikimedia.org/r/#/c/149617/21 [20:10:01] <ExcitedPanda> legoktm: https://gerrit.wikimedia.org/r/#/c/149652/ [20:10:06] <ExcitedPanda> legoktm: all three: https://gerrit.wikimedia.org/r/#/c/149657/ [20:11:24] <grrrit-wm> (03CR) 10Bartosz Dziewoński: On redirect, actually update URL to the target page with JavaScript (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143852 (https://bugzilla.wikimedia.org/35045) (owner: 10Bartosz Dziewoński) [20:11:35] <grrrit-wm> (03PS5) 10Bartosz Dziewoński: On redirect, actually update URL to the target page with JavaScript [core] - 10https://gerrit.wikimedia.org/r/143852 (https://bugzilla.wikimedia.org/35045) [20:11:59] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] On redirect, actually update URL to the target page with JavaScript [core] - 10https://gerrit.wikimedia.org/r/143852 (https://bugzilla.wikimedia.org/35045) (owner: 10Bartosz Dziewoński) [20:12:37] <wikibugs> 3MediaWiki extensions / 3Translate: Show [edit]-link if needed - 10https://bugzilla.wikimedia.org/68578#c11 (10Nemo) (In reply to Rainer Rillke @commons.wikimedia from comment #10) > Nemo_bis: You say impossible. I don't know how the parser works but wouldn't > it be possible to just remove those edit links... [20:13:07] <rillke> stupid mw... [20:14:09] <MatmaRex> hmm, maybe "impossible" is a bit of a too strong wording… but it's definitely currently impossible at least [20:14:24] <grrrit-wm> (03PS6) 10Bartosz Dziewoński: On redirect, actually update URL to the target page with JavaScript [core] - 10https://gerrit.wikimedia.org/r/143852 (https://bugzilla.wikimedia.org/35045) [20:14:28] <MatmaRex> given enough time and resources, nothing is impossible ;) [20:14:36] <grrrit-wm> (03CR) 10Scott-linder: "Alright, new change set should cover everything we discussed." [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/147991 (owner: 10Scott-linder) [20:14:43] <grrrit-wm> (03CR) 10Bartosz Dziewoński: "Rebased." [core] - 10https://gerrit.wikimedia.org/r/143852 (https://bugzilla.wikimedia.org/35045) (owner: 10Bartosz Dziewoński) [20:15:07] <wikibugs> 3MediaWiki extensions / 3Scribunto: phpunit failure: LuaStandalone: TitleLibraryTests: Failed asserting that two strings are identical - 10https://bugzilla.wikimedia.org/68646#c2 (10Nemo) (In reply to Brad Jorsch from comment #1) > If some other extension is screwing > around with the value of the main page,... [20:15:21] <grrrit-wm> (03CR) 10Bartosz Dziewoński: "I think this version solves all of the issues raised?" [core] - 10https://gerrit.wikimedia.org/r/143852 (https://bugzilla.wikimedia.org/35045) (owner: 10Bartosz Dziewoński) [20:16:31] <grrrit-wm> (03CR) 10Scott-linder: "Small correction:" [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/147991 (owner: 10Scott-linder) [20:18:24] <legoktm> ExcitedPanda: reviewed all [20:19:14] <ExcitedPanda> legoktm: sweeet. can you just +2? I'll fix the comments in followup [20:19:42] <grrrit-wm> (03CR) 10Brian Wolff: Fix typo in qqq.json (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/149641 (https://bugzilla.wikimedia.org/68635) (owner: 10Brian Wolff) [20:23:08] <wikibugs> 3MediaWiki / 3Unit tests: slow query: INSERT /* JobQueueDB::doBatchPush 127.0.0.1 */ INTO `unittest_job` etc. - 10https://bugzilla.wikimedia.org/68620#c1 (10Bawolff (Brian Wolff)) Wonder if its something specific to the labs-vagrant setup (e.g. Maybe a network file system causes really slow writes, so writi... [20:23:22] <wikibugs> 3MediaWiki extensions / 3Translate: Show [edit]-link if needed - 10https://bugzilla.wikimedia.org/68578#c12 (10Andre Klapper) Public service announcement: Folks, I'd appreciate if it was avoided to add comments which could be interpreted as sarcasm. Also see [[mw:Bug_management/Bugzilla_Etiquette]] for some... [20:24:04] <ExcitedPanda> legoktm: https://gerrit.wikimedia.org/r/149738 [20:24:11] <ExcitedPanda> legoktm: https://gerrit.wikimedia.org/r/149739 [20:24:30] <ExcitedPanda> legoktm: trivial fixes, the only actionable ones I could find, other than the JS fix, which I'll have to do later in a proper js arch [20:25:22] <Nemo_bis> sigh 379) LuaStandalone: UstringLibraryTests[103]: find: (%1) proc_open(): fork failed - Cannot allocate memory [20:25:57] <ExcitedPanda> Nemo_bis: re: your earlier question, assuming it's about my nick, I've been making great progress on https://meta.wikimedia.org/wiki/Research:Ideas/Public_query_interface_for_Labs and should be able to announce it in a few days [20:26:27] <Nemo_bis> ExcitedPanda: ah, nice :) [20:26:36] * Nemo_bis already has it in watchlist [20:26:53] <ExcitedPanda> Nemo_bis: should be ready for reasonable public use by wikimania. I can PM you a link to a nicely working demo if you'd like [20:27:24] <Nemo_bis> ugh no please, enough shiny distractions P:P [20:27:55] <ExcitedPanda> Nemo_bis: too late :P [20:28:00] <Nemo_bis> aww [20:29:17] <ExcitedPanda> Nemo_bis: still needs UI polish, but do try it out and leave comments on the talk page :) [20:29:20] <bawolff> ExcitedPanda: Didn't dispenser already try that, and got shutdown by tool labs folks [20:29:55] <ExcitedPanda> bawolff: 1. this has strong query killing capabilities, 2. will require that you login via Wikitech (from tomorrow, when Wikitech gets OAuth) so you agree to Labs ToS 3. It isn't PHPMyAdmin [20:30:14] <ExcitedPanda> bawolff: the lack of ToS is also why I'm not publicly giving anyone the link :) [20:30:23] <bawolff> Ah [20:31:11] <bawolff> The lack of ToS agreement sounds BS to me. I never agreed to tool labs terms of service, and I have an account [20:31:47] <ExcitedPanda> bawolff: https://wikitech.wikimedia.org/w/index.php?title=Special:UserLogin&returnto=Main+Page&type=signup has a notice on top [20:32:01] <ExcitedPanda> bawolff: also, if it's tied to wikitech, people can be kicked out of the tool by being banned [20:32:04] <bawolff> Well I never created an account [20:32:10] <Reedy> Registration time: 22:15, 7 September 2011 [20:32:12] <bawolff> yes, there's always that [20:32:13] * Reedy whistles [20:32:16] <ExcitedPanda> heh [20:32:26] <bawolff> Well sumanah created an account on my behalf [20:32:34] <bawolff> before wikitech had open registeration [20:32:36] <ExcitedPanda> I guess they got to you some other way [20:33:02] <ExcitedPanda> bawolff: this tool is also not phpmyadmin, which I think is an important bit :) [20:33:07] <bawolff> probably [20:33:38] <bawolff> I wonder what the terms of service actually say [20:33:47] <bawolff> Suppose I should read it, so I don't violate it [20:34:31] <p858snake|l> and for a period of that time, that message wasn't displayed on the signup page [20:34:42] <p858snake|l> because the wmf ui folks didn't like it [20:34:47] <bawolff> rofl [20:35:15] <ExcitedPanda> heh [20:35:20] <ExcitedPanda> I could add a ToS screen to the app :P [20:35:53] <wikibugs> 3MediaWiki / 3API: api generator query does not preserve search result order - 10https://bugzilla.wikimedia.org/68515#c1 (10Brad Jorsch) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 14859 *** [20:35:54] <wikibugs> 3MediaWiki / 3API: add an index field to show original order of queried titles - 10https://bugzilla.wikimedia.org/14859#c3 (10Brad Jorsch) *** Bug 68515 has been marked as a duplicate of this bug. *** [20:37:51] <bawolff> ExcitedPanda: That is nice though. Even in terms of when I want to link to someone query results but want something nicer than a link to a pastebin of the output of mysql cli [20:38:03] <ExcitedPanda> bawolff: yeah. [20:38:16] <ExcitedPanda> bawolff: and they can modify and run it later easily if they want (I'll add a gist like 'fork' button soon) [20:38:57] <grrrit-wm> (03CR) 10Bartosz Dziewoński: Use a special fallback skin when selected skin is unavailable (033 comments) [core] - 10https://gerrit.wikimedia.org/r/148508 (https://bugzilla.wikimedia.org/68332) (owner: 10Bartosz Dziewoński) [20:39:01] <grrrit-wm> (03PS2) 10Bartosz Dziewoński: Use a special fallback skin when selected skin is unavailable [core] - 10https://gerrit.wikimedia.org/r/148508 (https://bugzilla.wikimedia.org/68332) [20:39:12] <bawolff> One thing that might be nice, is to have a select box saying which db, instead of people doing things like use commonswiki_p; [20:39:18] <ExcitedPanda> bawolff: yeah, in the works [20:39:31] <grrrit-wm> (03CR) 10Bartosz Dziewoński: "SkinFallback should be in skins/, it's not a proper skin. (If anything, it should be in includes/skins/, but we don't have that directory " [core] - 10https://gerrit.wikimedia.org/r/148508 (https://bugzilla.wikimedia.org/68332) (owner: 10Bartosz Dziewoński) [20:39:31] <ExcitedPanda> bawolff: this is like, 3 days of work so far :) [20:39:46] * bawolff suitably impressed [20:40:06] <ExcitedPanda> bawolff: the UI needs work, and the JS state is pretty terrible [20:40:16] <ExcitedPanda> it's less than 200 lines of JS, but still... [20:40:23] <grrrit-wm> (03PS4) 10Bartosz Dziewoński: Define fallback skin using $wgFallbackSkin instead of hardcoding Vector [core] - 10https://gerrit.wikimedia.org/r/148424 (https://bugzilla.wikimedia.org/68332) [20:41:10] <grrrit-wm> (03CR) 10Yaron Koren: "Alright, great - I'm glad we could agree on a setup, and everything in the current code looks logical, which is great. One question: does " [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/147991 (owner: 10Scott-linder) [20:41:21] <ExcitedPanda> bawolff: you can edit the title by clicking on it [20:41:50] <ExcitedPanda> bawolff: I was also considering adding a markdown 'content' that you can add. The queries are already versioned but no history is shown yet, so I'll probably expose that as well. [20:42:14] <ExcitedPanda> bawolff: a 'crazier' idea is to allow templates in the 'content', and feed it data from the query results. that way, people can construct whatever reports they want with that data [20:42:38] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Use a special fallback skin when selected skin is unavailable [core] - 10https://gerrit.wikimedia.org/r/148508 (https://bugzilla.wikimedia.org/68332) (owner: 10Bartosz Dziewoński) [20:45:38] <wikibugs> 3MediaWiki / 3Unit tests: slow query: INSERT /* JobQueueDB::doBatchPush 127.0.0.1 */ INTO `unittest_job` etc. - 10https://bugzilla.wikimedia.org/68620#c2 (10Nemo) (In reply to Bawolff (Brian Wolff) from comment #1) > Wonder if its something specific to the labs-vagrant setup (e.g. Maybe a > network file sys... [20:47:45] * bawolff wonders what the timeout on it is [20:48:58] * bawolff submitted a slow query and will see soon [20:50:27] <legoktm> 10m I think [20:51:06] <grrrit-wm> (03CR) 10Scott-linder: "Woops, I had completely forgotten about that. I'm not sure how to test that (do you happen to have an example of an XML file which uses xp" [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/147991 (owner: 10Scott-linder) [20:51:09] <bawolff> Hmm. My query is probably not slow enough then [20:51:38] <ExcitedPanda> bawolff: 10m, yeah. very tunable, I am unsure what an appropriate value will be [20:53:42] <legoktm> what database is used by default? enwp? [20:53:57] <ExcitedPanda> legoktm: yeah. it's on s5, so you can 'use <dbname>' for anything tho [20:55:24] <ExcitedPanda> legoktm: restarting to do a deploy, current tasks will be lost. you can click 'run' again, tho. previous data, etc will remain [20:55:49] <ExcitedPanda> legoktm: restarted [20:56:14] <ExcitedPanda> bawolff: legoktm do play with it, but don't publicize the link :) I'm off to sleep now [20:56:52] <bawolff> ExcitedPanda: underscores seem to be converted to spaces when entering a query? [20:57:04] <ExcitedPanda> bawolff: hmm? shouldn't be... [20:57:17] <ExcitedPanda> bawolff: I just tried, seems to work... [20:57:22] <bawolff> Hmm [20:57:34] <ExcitedPanda> bawolff: oh, hmm. I haven't prepared a proper fontstack yet, so you might be getting a terrible one on Linux? [20:57:45] <bawolff> hmm, now it works for me too [20:57:57] <bawolff> but not on the first line [20:57:59] <ExcitedPanda> well, non Ubuntu Linux should probably be terrible: Monaco, Consolas, "Ubuntu Mono" [20:58:19] <ExcitedPanda> bawolff: hmm, weird. I've entered 'use wikidatawiki_p'; and it's fine... [20:58:30] <bawolff> and only when editing an existing query [20:59:07] <ExcitedPanda> wow :| [20:59:14] <grrrit-wm> (03CR) 10Yaron Koren: "You can see a demo of "use xpath" with #get_web_data, here:" [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/147991 (owner: 10Scott-linder) [20:59:23] <ExcitedPanda> bawolff: legoktm I've reduced the query timeout to 1minute now. again, previous runs would've been lost [20:59:27] * ExcitedPanda should figure a way out around this [20:59:47] <ExcitedPanda> ah, hmm, I think playing with when a message is ack'd by workers sounds like the thing to do... [21:00:13] <wikibugs> 3MediaWiki / 3API: api generator query does not preserve search result order - 10https://bugzilla.wikimedia.org/68515#c2 (10Jörn Hees) sorry for dup, but it's rather on 67131 than 14859... *** This bug has been marked as a duplicate of bug 67131 *** [21:00:13] <wikibugs> 3MediaWiki / 3API: Results order when using generator=search - 10https://bugzilla.wikimedia.org/67131#c2 (10Jörn Hees) *** Bug 68515 has been marked as a duplicate of this bug. *** [21:00:14] <ExcitedPanda> then tasks will survive worker restarts [21:04:50] * ExcitedPanda waves off to sleep [21:06:24] <wikibugs> 3MediaWiki / 3User preferences: Save special page preferences from the special page itself - 10https://bugzilla.wikimedia.org/31881#c6 (10Quiddity) Tangential discussion from June at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29/Archive_127#Watchlists (TheDJ points them towards this bu... [21:07:23] <wikibugs> 3MediaWiki-Vagrant: globalcssjs: Exception from line 79 of includes/db/CloneDatabase.php: Cannot clone shared table objectcache - 10https://bugzilla.wikimedia.org/68624#c3 (10Nemo) (In reply to Nemo from comment #2) > "Just including the extension" is not something I did. Correction: as legoktm noted, by mis... [21:11:06] <legoktm> Nemo_bis: the globalcssjs role should auto-include the centralauth role. But anyways, you've encouraged me to write tests for the extension so :) [21:11:30] <grrrit-wm> (03CR) 10Scott-linder: "Thank you for the link (I see now this is mentioned on the extensions wiki page...)" [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/147991 (owner: 10Scott-linder) [21:12:40] <Nemo_bis> heh :) [21:13:38] <grrrit-wm> (03PS2) 10Bartosz Dziewoński: Stop always loading MonoBook and Vector [core] - 10https://gerrit.wikimedia.org/r/148509 (https://bugzilla.wikimedia.org/68402) [21:13:40] <grrrit-wm> (03PS3) 10Bartosz Dziewoński: Use a special fallback skin when selected skin is unavailable [core] - 10https://gerrit.wikimedia.org/r/148508 (https://bugzilla.wikimedia.org/68332) [21:13:42] <grrrit-wm> (03PS5) 10Bartosz Dziewoński: Define fallback skin using $wgFallbackSkin instead of hardcoding Vector [core] - 10https://gerrit.wikimedia.org/r/148424 (https://bugzilla.wikimedia.org/68332) [21:13:44] <grrrit-wm> (03PS3) 10Bartosz Dziewoński: Move Vector's $wg configuration options to Vector.php [core] - 10https://gerrit.wikimedia.org/r/148433 [21:13:46] <grrrit-wm> (03PS1) 10Bartosz Dziewoński: Preferences: Disable the 'skin' preference if there are no skins [core] - 10https://gerrit.wikimedia.org/r/149779 [21:14:09] <grrrit-wm> (03CR) 10Bartosz Dziewoński: "Fixed by rebasing on top of https://gerrit.wikimedia.org/r/#/c/148509/2" [core] - 10https://gerrit.wikimedia.org/r/148433 (owner: 10Bartosz Dziewoński) [21:16:00] <grrrit-wm> (03CR) 10Bartosz Dziewoński: "Soooo?" [core] - 10https://gerrit.wikimedia.org/r/130024 (https://bugzilla.wikimedia.org/64513) (owner: 10Bartosz Dziewoński) [21:16:12] <wikibugs> 3MediaWiki / 3API: rvdiffto doesn't return diff to a given revid - 10https://bugzilla.wikimedia.org/68690 (10Peter Bena) 3NEW p:3Unprio s:3normal a:3None http://en.wikipedia.org/w/api.php?action=query&prop=revisions&rvprop=ids|user|timestamp|comment&rvlimit=1&rvtoken=rollback&rvstartid=7560&rvdiffto=... [21:16:44] <legoktm> MatmaRex: I'm tempted not to merge that just to wait for "Sooooooooooooooo?" ;) [21:17:02] <MatmaRex> heh [21:18:21] <grrrit-wm> (03CR) 10Legoktm: [C: 032] ResourceLoader: Test that all module dependencies are satisfiable [core] - 10https://gerrit.wikimedia.org/r/130024 (https://bugzilla.wikimedia.org/64513) (owner: 10Bartosz Dziewoński) [21:18:22] <wikibugs> 3MediaWiki / 3API: rvdiffto doesn't return diff to a given revid - 10https://bugzilla.wikimedia.org/68690 (10Peter Bena) [21:19:37] <grrrit-wm> (03PS7) 10Bartosz Dziewoński: Vector: Make better use of $wgResourceModuleSkinStyles [core] - 10https://gerrit.wikimedia.org/r/148304 [21:19:39] <grrrit-wm> (03PS17) 10Bartosz Dziewoński: resourceloader: Allow skins to provide additional styles for any module [core] - 10https://gerrit.wikimedia.org/r/141259 [21:21:44] <grrrit-wm> (03Merged) 10jenkins-bot: ResourceLoader: Test that all module dependencies are satisfiable [core] - 10https://gerrit.wikimedia.org/r/130024 (https://bugzilla.wikimedia.org/64513) (owner: 10Bartosz Dziewoński) [21:22:55] <grrrit-wm> (03CR) 10Brian Wolff: "I don't overly see the point. What if someone other than us wanted to use it? Why not just disable it in translatewiki, and have a file na" [extensions/OggHandler] - 10https://gerrit.wikimedia.org/r/149465 (owner: 10Mattflaschen) [21:26:13] <grrrit-wm> (03CR) 10Legoktm: "There's no standarized way to "delete" an extension. This is what was done for the Vector extension. Oversight just had an OBSOLETE file s" [extensions/OggHandler] - 10https://gerrit.wikimedia.org/r/149465 (owner: 10Mattflaschen) [21:28:04] <grrrit-wm> (03PS3) 10Bartosz Dziewoński: Resources.php: Remove/deprecate 'skinStyles' references to 'minerva' skin [core] - 10https://gerrit.wikimedia.org/r/148305 [21:28:42] <grrrit-wm> (03CR) 10Bartosz Dziewoński: "James, I got rid of the problematic part. The -2 doesn't apply anymore, does it?" [core] - 10https://gerrit.wikimedia.org/r/148305 (owner: 10Bartosz Dziewoński) [21:30:08] <wikibugs> 3MediaWiki / 3API: Results order when using generator=search - 10https://bugzilla.wikimedia.org/67131#c3 (10Jörn Hees) I actually disagree that this is simply a duplicate of bug 14859: in bug 14859 the op already knows the order of titles he's querying for. Here search internally returns the order to the gen... [21:31:33] <grrrit-wm> (03PS1) 10Jack Phoenix: Support for a custom logo ([[File:BlueSky-logo.png]]). [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/149781 [21:32:13] <grrrit-wm> (03CR) 10Jack Phoenix: [C: 032 V: 032] Support for a custom logo ([[File:BlueSky-logo.png]]). [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/149781 (owner: 10Jack Phoenix) [21:32:15] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 04-1] "I'm afraid that abusing labels like this is unacceptable from the accessibility standpoint :/" [core] - 10https://gerrit.wikimedia.org/r/149121 (owner: 10Jdlrobson) [21:37:24] <grrrit-wm> (03PS1) 10Jack Phoenix: Fix black-on-black text in the header when no custom logo exists. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/149782 [21:37:45] <grrrit-wm> (03CR) 10Jack Phoenix: [C: 032 V: 032] Fix black-on-black text in the header when no custom logo exists. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/149782 (owner: 10Jack Phoenix) [21:37:59] <grrrit-wm> (03CR) 10Brian Wolff: [C: 04-2] "We're not going to make futher updates to this extension unless someone out there is actually using it, and would benefit." [extensions/OggHandler] - 10https://gerrit.wikimedia.org/r/145562 (owner: 10Paladox) [21:42:09] <wikibugs> 3MediaWiki / 3Revision deletion: Fatal error: Call to a member function getBits() on a non-object in SpecialRevisiondelete.php on line 166 - 10https://bugzilla.wikimedia.org/68566#c8 (10Kunal Mehta (Legoktm)) Was this backported? I just ran into it on testwiki. [21:44:28] <grrrit-wm> (03PS1) 10Legoktm: Move adjustment of revision delete target in SpecialRevisiondelete to fix fatal [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/149783 (https://bugzilla.wikimedia.org/68566) [21:45:07] <grrrit-wm> (03PS2) 10Reedy: Move adjustment of revision delete target in SpecialRevisiondelete to fix fatal [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/149783 (https://bugzilla.wikimedia.org/68566) (owner: 10Legoktm) [21:45:08] <eieren_like_Eier> legoktm: it's on SWAT [21:45:17] <Reedy> hahah [21:45:18] <legoktm> eieren_like_Eier: yeah, just saw it [21:45:39] <grrrit-wm> (03CR) 10Legoktm: "This is scheduled for tomorrow morning's SWAT by hoo." [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/149783 (https://bugzilla.wikimedia.org/68566) (owner: 10Legoktm) [21:47:53] <wikibugs> 3MediaWiki / 3Revision deletion: Fatal error: Call to a member function getBits() on a non-object in SpecialRevisiondelete.php on line 166 - 10https://bugzilla.wikimedia.org/68566#c10 (10Kunal Mehta (Legoktm)) 5VERI>3REOP (In reply to Kunal Mehta (Legoktm) from comment #8) > Was this backported? I just r... [21:49:57] <eieren_like_Eier> legoktm: why reopened? it's apparently fixed … and the bug is not WMF-specific [21:50:09] <legoktm> eieren_like_Eier: so it'll show up in bugzilla searches [21:50:52] <legoktm> oh, hi Vogone :) [21:55:45] <eieren_like_Eier> yes, hi :) [21:56:01] <legoktm> Reedy: wanna review https://gerrit.wikimedia.org/r/#/c/149474/ ? :) [22:14:06] <grrrit-wm> (03CR) 10Rillke: Add mw-ui-checkbox (032 comments) [core] - 10https://gerrit.wikimedia.org/r/149121 (owner: 10Jdlrobson) [22:17:10] <grrrit-wm> (03CR) 10tosfos: [C: 032] i18n/en fixes [extensions/SimpleChanges] - 10https://gerrit.wikimedia.org/r/148884 (owner: 10tosfos) [22:20:12] <wikibugs> 3MediaWiki / 3Special pages: "What links here" should show only the template linking, not all pages containing the template. Same for "pages that use this image". - 10https://bugzilla.wikimedia.org/1392 (10WhatamIdoing) [22:20:12] <wikibugs> 3MediaWiki / 3Special pages: "what links here" should list the template, not the pages that use it - 10https://bugzilla.wikimedia.org/12396 (10WhatamIdoing) [22:20:42] <wikibugs> 3MediaWiki / 3Special pages: "what links here" should list the template, not the pages that use it - 10https://bugzilla.wikimedia.org/12396 (10WhatamIdoing) [22:20:42] <wikibugs> 3MediaWiki / 3Special pages: Transclusion should produce tree-like results in "What links here" - 10https://bugzilla.wikimedia.org/3241 (10WhatamIdoing) [22:26:09] <kunalg> How do I set up an extension with core on my tools.wmflabs account? Have been struggling to set it up for the past 4 hours [22:27:22] <wikibugs> 3MediaWiki / 3API: phpunit failure: ApiOptionsTest::testReset User::saveSettings() was not expected to be called more than once - 10https://bugzilla.wikimedia.org/68654#c2 (10Nemo) (In reply to Brad Jorsch from comment #1) > Presumably some extension hooking 'UserResetAllOptions' and calling > saveSettings.... [22:29:23] <Reedy> Struggling with what part? [22:29:23] <wikibugs> 3MediaWiki / 3API: phpunit failure: ApiOptionsTest::testReset User::saveSettings() was not expected to be called more than once - 10https://bugzilla.wikimedia.org/68654#c3 (10Nemo) Created attachment 16050 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16050&action=edit nemobis@tools-login:/shared/me... [22:31:48] <kunalg> Reedy: I wasn't able to set up core. I cloned using git and changed my .lighttpd.conf file [22:32:24] <Reedy> I'm not sure whether tool labs is supposed to be used to run mediawiki [22:32:59] <kunalg> Reedy: So, where should I test mediawiki installations? [22:33:18] <grrrit-wm> (03PS1) 10Legoktm: MobileApp depends upon MobileFrontend [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/149784 (https://bugzilla.wikimedia.org/65954) [22:36:00] <Reedy> Technically that's what vagrant is for [22:42:46] <kunalg> Reedy: I don't have access to any other server [22:43:11] <kunalg> Reedy: Does tools.wmflabs support vagrant? [22:44:22] <Reedy> You can run vagrant on your local pc [22:45:25] <kunalg> Reedy: I want to develop a UI change in translate extension, and host it. My internet isn't too good for hosting a server here. [22:47:35] <Reedy> When people do that they usually create a project with a vm for testing in [22:49:38] <rillke> but if you are using vagrant, make sure you have a fast connection before the first "vagrant up" [22:49:59] <rillke> and a fast processor .... [22:50:25] <grrrit-wm> (03PS1) 10Legoktm: Add WikimediaShopLink messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/149785 (https://bugzilla.wikimedia.org/55678) [22:50:35] <kunalg> Reedy: The testing part from my side is done, but need to get the design approved while the patch is in progress. Need to host it somewhere, don't know how? [22:50:57] <kunalg> rillke: Got a fast processor but not such a good connection [22:51:02] <Reedy> You don't necesserily *have* to host it [22:51:07] <Reedy> People can test it locally [22:51:24] <rillke> Yes, or you can even run MediaWiki on tool labs [22:51:38] <rillke> not with vagrant, though but for a style change ... [22:52:03] <grrrit-wm> (03CR) 10Nemo bis: [C: 031] "Ouch. Looks sane, provided that we're not adding any additional risk to read content which happens to be named like our XMLs but is not on" [core] - 10https://gerrit.wikimedia.org/r/149508 (https://bugzilla.wikimedia.org/4520) (owner: 10TTO) [22:52:07] <rillke> http://tools.wmflabs.org/rillke/mol/ as a proof of concept [22:55:24] <legoktm> or just get a labs instance and use labs-vagrant [22:58:19] <grrrit-wm> (03CR) 10Brian Wolff: [C: 032] Create README.md [extensions/intersection] - 10https://gerrit.wikimedia.org/r/149631 (https://bugzilla.wikimedia.org/68673) (owner: 10Rudloff) [22:58:28] <grrrit-wm> (03Merged) 10jenkins-bot: Create README.md [extensions/intersection] - 10https://gerrit.wikimedia.org/r/149631 (https://bugzilla.wikimedia.org/68673) (owner: 10Rudloff) [22:58:47] <kunalg> rillke: Umm, I cloned core and modified my .lighttpd.conf. But can't get it to work [22:59:38] <grrrit-wm> (03CR) 10Legoktm: "wmf-config change is I2eef13fde9b0d567c92205c4d78d22ea1fa762f1." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/149785 (https://bugzilla.wikimedia.org/55678) (owner: 10Legoktm) [22:59:52] <wikibugs> 3MediaWiki extensions / 3DynamicPageList: Add a README - 10https://bugzilla.wikimedia.org/68673#c8 (10Bawolff (Brian Wolff)) 5PATC>3RESO/FIX thanks. [23:01:48] <rillke> kunalg, the languagebar-ui tool? [23:04:00] <kunalg> rillke: Yes [23:06:00] <rillke1> there is no webservice, kunalg? [23:06:58] <rillke1> $ webservice start [23:07:39] <kunalg> rillke1: Got it, the changing configuration didn't work [23:07:44] <kunalg> rillke1: Don' [23:08:26] <kunalg> rillke1: Don't know why, I ran the server with the core moved to public_html and it worked [23:08:30] <kunalg> rillke1: Thanks [23:10:12] <rillke1> take care of the read-rights for all users if you store your db password in localsettings.php [23:12:29] <kunalg> rillke1: Hmm, yeah :) [23:14:59] <grrrit-wm> (03PS1) 10Brian Wolff: Degrade Special:OrphanedTimedText gracefully if !$wgEnableLocalTimedText [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/149788 [23:21:51] <grrrit-wm> (03PS1) 10Jack Phoenix: A not-so-awesome way of adding class="section" to #mw-content-text for proper styling. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/149789 [23:22:07] <grrrit-wm> (03CR) 10Bartosz Dziewoński: "Did https://gerrit.wikimedia.org/r/148846 instead." [core] - 10https://gerrit.wikimedia.org/r/148766 (owner: 10Bartosz Dziewoński) [23:22:12] <grrrit-wm> (03CR) 10Jack Phoenix: [C: 032 V: 032] A not-so-awesome way of adding class="section" to #mw-content-text for proper styling. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/149789 (owner: 10Jack Phoenix) [23:22:52] <wikibugs> 3MediaWiki-Vagrant: globalcssjs: Exception from line 79 of includes/db/CloneDatabase.php: Cannot clone shared table objectcache - 10https://bugzilla.wikimedia.org/68624#c4 (10Nemo) Created attachment 16052 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16052&action=edit Installed stuff Nope, I get the... [23:23:09] <wikibugs> 3MediaWiki / 3API: rvdiffto doesn't return diff to a given revid - 10https://bugzilla.wikimedia.org/68690#c1 (10Brad Jorsch) 5NEW>3RESO/INV [[Michael Swann]] does not have any revisions before 35623836, so rvstartid=7560 with the default rvdir=older is causing prop=revisions to return no revisions. That'... [23:25:09] <grrrit-wm> (03CR) 10Bartosz Dziewoński: "shouldn't*" [core] - 10https://gerrit.wikimedia.org/r/148508 (https://bugzilla.wikimedia.org/68332) (owner: 10Bartosz Dziewoński) [23:25:11] <grrrit-wm> (03PS1) 10Legoktm: Add tests for GlobalCssJsHooks::loadForUser [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/149790 [23:27:03] <grrrit-wm> (03PS2) 10Brian Wolff: Split BitmapHandler into two classes. [core] - 10https://gerrit.wikimedia.org/r/147718 [23:27:05] <grrrit-wm> (03PS1) 10Brian Wolff: Make GetLocalFileCopy pool counter call from tiff be generic [core] - 10https://gerrit.wikimedia.org/r/149791 [23:30:06] <apexkid1> Hi I have a small confusion regarding Edit API.... if i have parsed the whole content and made changes.. how should i pass the entire content in my query... should i pass it using the parameter "recreate" ? [23:30:39] <wikibugs> 3MediaWiki / 3Unit tests: Exception from line 182 of /srv/vagrant/mediawiki/includes/Hooks.php: Invalid callback in hooks for UnitTestsList - 10https://bugzilla.wikimedia.org/68696 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Some of the extensions in attachment 16052 (where I added all those having Uni... [23:30:51] <wikibugs> 3MediaWiki / 3Unit tests: Exception from line 182 of /srv/vagrant/mediawiki/includes/Hooks.php: Invalid callback in hooks for UnitTestsList - 10https://bugzilla.wikimedia.org/68696 (10Nemo) 5NEW>3UNCO [23:31:08] <apexkid1> legoktm: Hi, if you free please help me [23:31:28] <Reedy> apexkid1: No [23:31:49] <Reedy> Just pass it as the text parameter [23:32:11] <apexkid1> Reedy: So will it override the previous content and create a new revision? [23:32:17] <Reedy> Yes [23:32:23] <apexkid1> Oh cool. ty :) [23:32:25] <Reedy> You can't edit previous revisions [23:32:37] <wikibugs> 3MediaWiki-Vagrant: globalcssjs: Exception from line 79 of includes/db/CloneDatabase.php: Cannot clone shared table objectcache - 10https://bugzilla.wikimedia.org/68624#c5 (10Kunal Mehta (Legoktm)) Ok, I believe this is due to the CentralAuth role adding an objectcache table, which can't be cloned when running... [23:32:39] <Reedy> So any subsequent modifications will result in a new revision [23:34:17] <apexkid1> Got it ! [23:34:26] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: PHP Fatal error: Call to a member function getContentModel() on a non-object in /srv/vagrant/mediawiki/extensions/Wikibase/repo/Wikiba se.hooks.php on line 1005 - 10https://bugzilla.wikimedia.org/68697 (10Nemo) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Doing wh... [23:35:05] <grrrit-wm> (03PS1) 10Jack Phoenix: CSS fixes for section edit links + <h2> headers. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/149792 [23:35:26] <grrrit-wm> (03CR) 10Jack Phoenix: [C: 032 V: 032] CSS fixes for section edit links + <h2> headers. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/149792 (owner: 10Jack Phoenix) [23:38:38] <wikibugs> 3MediaWiki extensions / 3UrlShortener: Exception: .agora-field-styling is undefined: failed at `.agora-field-styling();` - 10https://bugzilla.wikimedia.org/68634#c2 (10Jon) Yeh. it's also styling this on 2 ids :-S This is a good example of why mixins without parameter names are bad - this causes 3 sets of d... [23:40:15] <Nemo_bis> legoktm: can't test https://bugzilla.wikimedia.org/show_bug.cgi?id=68624 right now, tests running (also, I should sleep) [23:40:51] <legoktm> that's fine, no rush I think [23:42:43] <grrrit-wm> (03CR) 10Jdlrobson: Add mw-ui-checkbox (031 comment) [core] - 10https://gerrit.wikimedia.org/r/149121 (owner: 10Jdlrobson) [23:43:21] <wikibugs> 3MediaWiki extensions / 3CentralAuth: globalcssjs: Exception from line 79 of includes/db/CloneDatabase.php: Cannot clone shared table objectcache - 10https://bugzilla.wikimedia.org/68624 (10Nemo) [23:43:51] <wikibugs> 3MediaWiki extensions / 3CentralAuth: Exception from line 79 of includes/db/CloneDatabase.p hp: Cannot clone shared table objectcache - 10https://bugzilla.wikimedia.org/68624#c6 (10Nemo) Tentatively moved here. [23:44:11] <grrrit-wm> (03CR) 10Legoktm: "Re your comment on IRC: If I'm an admin, and I try editing a revision that I can view and has been rev-deleted, the edit tab is still show" (031 comment) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/149525 (owner: 10Wctaiwan) [23:45:27] <wikibugs> 3MediaWiki extensions / 3CentralAuth: Exception from line 79 of includes/db/CloneDatabase.php: Cannot clone shared table objectcache - 10https://bugzilla.wikimedia.org/68624 (10Kunal Mehta (Legoktm)) a:5Kunal Mehta (Legoktm)>3None [23:45:49] <grrrit-wm> (03CR) 10Bartosz Dziewoński: "(Sorry, I haven't had the time to properly review this yet. It's probably okay. :) )" [core] - 10https://gerrit.wikimedia.org/r/148144 (https://bugzilla.wikimedia.org/15484) (owner: 10Parent5446) [23:47:09] <wikibugs> 3MediaWiki extensions / 3TwoFactorAuthentication: PHP Notice: Did not find alias for special page 'TwoFactorAuth' - 10https://bugzilla.wikimedia.org/68698 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Ugh notice spam, what do you have against aliases? :) https://www.mediawiki.org/wiki/Manual:Special_pag...