[00:00:12] ori: ah that would be the bsimmers who I see on top [00:00:22] ori: should I tell it to use a few less cores? [00:00:24] jdlrobson: werdna: that's been visible as part of action=info for some time [00:00:24] i know i was just urging you to use that host a little while ago, but if it's churning away it might be good to grant him the fast lane [00:00:29] (or recompile later?) [00:00:34] yeah, if you wouldn't mind [00:00:35] re: later [00:00:36] sorry :/ [00:00:38] It's moving some code around, taking some basic SQL query and moving it to a new function [00:00:43] ori: nw [00:00:47] Hardly just giving out the page watcher count to anyone [00:00:55] MatmaRex: ahh I thought it was still considered private [00:00:55] jdlrobson: werdna: although it only shows accurate data when there are more than 30 watchers [00:00:55] MatmaRex: good point though, how does info get used [00:00:56] ori: nw, can do this next week [00:00:57] https://en.wikipedia.org/w/index.php?title=Remote_Oceania&action=info [00:00:58] that might be some more code i can consume [00:01:03] so half-private [00:01:09] Yeah... [00:01:14] (otherwise it's "Fewer than 30 watchers") [00:01:19] I think you can see that data from labs, right MatmaRex? [00:01:46] Krenair: probably, afaik labs users are supposed to be responsible and not expose the raw numbers further [00:01:50] Yeah. [00:02:13] Krenair: mzmcbride used to have a tool to show the number before it got on action=info, and it also limited the results shown in the same way [00:02:37] yeah, and was considered acceptable [00:02:43] jdlrobson: hmm, you put it on SpecialWatchlist? ew [00:02:51] It's considered semi-"private" because we don't want people to abuse it to target unwatched pages [00:03:17] (03CR) 10MaxSem: [C: 04-1] Expose the count of users watching a given page (031 comment) [core] - 10https://gerrit.wikimedia.org/r/149478 (owner: 10Jdlrobson) [00:03:28] (on the other hand, i don't really have a better idea… it would fir well in Title :D) [00:03:31] fit* [00:03:32] MatmaRex: it was already there :) [00:03:56] jdlrobson: well, but it was dead code [00:03:59] MatmaRex: i'll do another pass Monday and find how info does it and put it in a more generic place [00:04:15] i'm positive these lines were not run by anybody in the last few years ;) [00:04:29] 3MediaWiki / 3Page editing: Please add full stop and space after "undo" default edit summary - 10https://bugzilla.wikimedia.org/67114#c1 (10Ricordisamoa) Many users won't add any "explanatory note"s, and we would end up with thousands of edit summaries ending with full stops. An alternative solution would be... [00:04:30] MatmaRex: in which case we should kill the code altogether (even better ;-)) [00:04:53] jdlrobson, also, ops will probably kill you if you try to use this function in prod;) [00:05:00] i wonder how action=info does it [00:05:41] hm, also a COUNT(*) [00:05:44] but cached [00:05:49] MaxSem: ^ [00:07:01] MatmaRex MaxSem seems like an opportunity to refactor though.. if not expose as a public function [00:07:13] HI, i am using mwparserfromhell and getting a very wierd error on parsing response from mw page. "UnicodeEncodeError: 'ascii' codec can't encode character u'\xab' in position 6049: ordinal not in range(128)" Nothing on google about this too :( [00:07:54] apexkid1, you running it with python 3? [00:08:06] jdlrobson: i added aude and hoo as reviewers, they're the experts on refactoring and exposing :P and did some watchlistey things in the past [00:08:07] Krenair: no 2.7 [00:08:35] (03CR) 10Jdlrobson: [C: 04-1] "I also want to see where this is done elsewhere. Bartosz points out this is done in page=info as well. There may be other occurrences." [core] - 10https://gerrit.wikimedia.org/r/149478 (owner: 10Jdlrobson) [00:08:45] MatmaRex: thanks [00:09:21] (03CR) 10Jdlrobson: New topic notifications for watchers of a board. (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [00:09:23] jdlrobson: i saw your ping earlier today, i'll respond to things on weekend [00:10:28] Krenair: do i need to run it on py 3? [00:10:59] apexkid1, not sure, sorry [00:10:59] vps [00:11:07] whoops [00:11:20] (03CR) 10Mattflaschen: [C: 04-1] "Looks good overall. Thanks for removing the old one, so we only have one to maintain." (038 comments) [core] - 10https://gerrit.wikimedia.org/r/149173 (owner: 10Jdlrobson) [00:11:24] apexkid1: judging by that error, yes [00:11:27] Krenair: It works fine when i do it from another wiki, but on the page of mw its giving me error [00:11:40] (probably) [00:11:48] MatmaRex: Ok let me try [00:12:07] hmm, https://github.com/earwig/mwparserfromhell says " It supports Python 2 and Python 3." [00:12:29] apexkid1: where did you install mwph from? [00:12:39] anyway, gotta go. good night [00:12:57] apexkid1: also, can you post a full traceback and the page you're trying to parse? [00:12:57] legoktm: pip packages i guess [00:13:52] legoktm: Traceback https://fpaste.org/120957/14063336/ [00:14:51] (03CR) 10Jdlrobson: [C: 04-1] "minor first pass" (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149210 (owner: 10Werdna) [00:15:03] apexkid1: what if you try print unicode(parse(page, wiki)) [00:16:44] (03CR) 10Jdlrobson: Add mw-ui-checkbox (031 comment) [core] - 10https://gerrit.wikimedia.org/r/149121 (owner: 10Jdlrobson) [00:18:13] legoktm: Works! :) [00:18:39] so, it's actually a mismatch between your terminal settings or something. tl;dr: use python3 ;) [00:18:51] (03CR) 10Mattflaschen: "Might want to note that this number should not be exposed in the UI to unprivileged users (at least not when it's a low number)." [core] - 10https://gerrit.wikimedia.org/r/149478 (owner: 10Jdlrobson) [00:19:09] legoktm: Ohh.. sad... thanks a lot i would have been stuck on it for ages am sure :D [00:20:19] (03PS3) 10Werdna: Move watch star for boards next to the header. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149210 [00:27:07] (03CR) 10Physikerwelt: "Ok. Feel free to submit once you are confident with the code." [extensions/Math] - 10https://gerrit.wikimedia.org/r/144939 (https://bugzilla.wikimedia.org/20202) (owner: 10Physikerwelt) [00:29:05] legoktm: Can you link me to some source on how to edit a mw page using mwparser. I can use some refrence... the documentation on mwparser is not much detailed. :) [00:29:19] Code snippet will help too [00:29:42] uh, mwparser is just a parser [00:29:46] it doesn't edit pages [00:29:57] (03CR) 10Mattflaschen: [C: 04-1] "It's possible I'm testing wrong (I can't just do uselang=ar or uselang=he, etc.) currently since it's only testable on a MW UI styleguide " [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [00:30:06] https://www.mediawiki.org/wiki/API:Client_code#Python is probably what you're looking for [00:30:11] I know that, still how to construct the complete query to modify the template and other stuff [00:31:52] ok thanks :) [00:36:24] (03CR) 10Mattflaschen: "Never mind, it works AFAICT when it's plugged through CSSJanus (I tested by adding lang=ar to the LOAD_URL request at docs/kss/Makefile)" [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [00:47:04] (03CR) 10Aude: "see comments" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/149478 (owner: 10Jdlrobson) [00:49:40] (03CR) 10Gergő Tisza: "http://commons.wiki.local.wmftest.net:8080/w/api.php?action=query&meta=filerepoinfo returns scriptDirUrl="". As far as I can see, that sho" [vagrant] - 10https://gerrit.wikimedia.org/r/147151 (owner: 10Gilles) [00:53:26] (03CR) 10Gergő Tisza: "Never mind. It is strange that the URL is wrong, but the reasonable way to get the value is via http://127.0.0.1:8080/w/api.php?action=que" [vagrant] - 10https://gerrit.wikimedia.org/r/147151 (owner: 10Gilles) [00:58:17] (03CR) 10Gergő Tisza: "Apparently both are correct: local scripts will use ...wmftest.net/api.php, scripts on the other wiki will use ...wmftest.net/w/api.php, a" [vagrant] - 10https://gerrit.wikimedia.org/r/147151 (owner: 10Gilles) [01:00:21] (03CR) 10Mattflaschen: "Migrating to Phabricator for code review is not part of Day 1 of the Phabricator migration." [gerrit] - 10https://gerrit.wikimedia.org/r/147990 (owner: 10Paladox) [01:01:24] (03CR) 10Legoktm: [C: 04-1] "-1 for why? How is one supposed to use the makefile? The stuff in scripts/ should really be in maintenance/ or something, but I don't real" (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/149394 (owner: 10EBernhardson) [01:03:57] (03PS1) 10Legoktm: Revert "New hooks for external integration to notification intiialization" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/149487 [01:04:39] (03CR) 10Legoktm: "Reverted in If735b46996fab3def835a54223412ef6d3105395" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148265 (owner: 10EBernhardson) [01:05:36] (03PS2) 10Legoktm: Revert "New hooks for external integration to notification intiialization" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/149487 [01:08:59] (03CR) 10EBernhardson: "These are all tools to help with development, I was bummed testing a patch i couldn't run `make phpunit` like I can in MF and Flow. The " (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/149394 (owner: 10EBernhardson) [01:14:05] (03CR) 10TTO: "My concerns with TitleValue are:" [core] - 10https://gerrit.wikimedia.org/r/149293 (https://bugzilla.wikimedia.org/30723) (owner: 10TTO) [01:20:51] (03CR) 10TTO: Proper namespace handling for WikiImporter (031 comment) [core] - 10https://gerrit.wikimedia.org/r/149293 (https://bugzilla.wikimedia.org/30723) (owner: 10TTO) [01:27:07] (03PS6) 10Bsitu: Replace EchoBackend with mappers and gateway [extensions/Echo] - 10https://gerrit.wikimedia.org/r/147369 [01:27:10] (03CR) 10jenkins-bot: [V: 04-1] Replace EchoBackend with mappers and gateway [extensions/Echo] - 10https://gerrit.wikimedia.org/r/147369 (owner: 10Bsitu) [01:27:33] (03CR) 10Legoktm: Break notifications into alert and message sections (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 (owner: 10Bsitu) [01:30:18] (03PS7) 10Bsitu: Replace EchoBackend with mappers and gateway [extensions/Echo] - 10https://gerrit.wikimedia.org/r/147369 [01:36:29] 3MediaWiki / 3ResourceLoader: LESS compiler should preserve the position of CSSMin / CSSJanus annotations - 10https://bugzilla.wikimedia.org/54673#c11 (10Matthew Flaschen) Blocks was correct. It blocks bug 67368 because (if we do that), this has to be done first (we have custom functions for working around... [01:36:43] 3MediaWiki / 3ResourceLoader: ResourceLoader: Remove custom LESS functions - 10https://bugzilla.wikimedia.org/67368 (10Matthew Flaschen) [01:37:58] 3Wikimedia / 3Site requests: 300GB of files on a hard disk in need of a URI or WMF direct upload - 10https://bugzilla.wikimedia.org/67477#c19 (10Kunal Mehta (Legoktm)) I can help out with uploading them once the disk is hooked up. [01:40:45] 3MediaWiki / 3ResourceLoader: ResourceLoaderLESSFunctions::embed does not support CSSJanus flipping for RTL - 10https://bugzilla.wikimedia.org/66091#c4 (10Matthew Flaschen) This could be fixed with or without removing custom LESS, so it's not a blocker (although it might be easier one way than the other). [01:40:45] 3MediaWiki / 3ResourceLoader: ResourceLoader: Remove custom LESS functions - 10https://bugzilla.wikimedia.org/67368 (10Matthew Flaschen) [01:43:02] (03CR) 10Mooeypoo: [C: 031] "Looks good." [core] - 10https://gerrit.wikimedia.org/r/149081 (owner: 10Catrope) [01:49:58] (03CR) 10EBernhardson: "as for what they all do, i am firmly a believer in TIAS :) there are linters for less, php and javascript. It includes a script that loo" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/149394 (owner: 10EBernhardson) [01:52:39] (03CR) 10EBernhardson: "oops one more part :) I don't think these scripts belong in maintenance because they don't have anything to do with running mediawiki, ma" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/149394 (owner: 10EBernhardson) [01:56:59] (03PS1) 10TTO: Improving some import-related error messages [core] - 10https://gerrit.wikimedia.org/r/149491 [01:57:14] (03PS2) 10TTO: Proper namespace handling for WikiImporter [core] - 10https://gerrit.wikimedia.org/r/149293 (https://bugzilla.wikimedia.org/30723) [01:57:16] (03PS3) 10TTO: Remove unused XMLReader2 class [core] - 10https://gerrit.wikimedia.org/r/148958 [02:01:46] (03CR) 10jenkins-bot: [V: 04-1] Proper namespace handling for WikiImporter [core] - 10https://gerrit.wikimedia.org/r/149293 (https://bugzilla.wikimedia.org/30723) (owner: 10TTO) [02:08:30] (03PS1) 10Jforrester: Track behaviour as well as performance data for VisualEditor [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/149492 [02:11:06] (03PS3) 10TTO: Proper namespace handling for WikiImporter [core] - 10https://gerrit.wikimedia.org/r/149293 (https://bugzilla.wikimedia.org/30723) [02:12:02] 3Wikimedia / 3Git/Gerrit: Email subject line should distinguish between "has posted comments on this change" and " I'd like you to reexamine a change." - 10https://bugzilla.wikimedia.org/68598 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None When you're going through an email backlog, you genera... [02:12:15] 3Wikimedia / 3Git/Gerrit: Gerrit email subject line should distinguish between "has posted comments on this change" and " I'd like you to reexamine a change." - 10https://bugzilla.wikimedia.org/68598 (10Matthew Flaschen) [02:13:15] 3Wikimedia / 3Git/Gerrit: Gerrit email subject line should distinguish between "has posted comments on this change" and " I'd like you to reexamine a change." - 10https://bugzilla.wikimedia.org/68598#c1 (10Matthew Flaschen) (In reply to Matthew Flaschen from comment #0) > Having a separate subject line for "... [02:13:57] (03CR) 10TTO: "Thanks! This change only consists of localisation changes, so what would be needed for a +2 on this patchset?" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148313 (https://bugzilla.wikimedia.org/68359) (owner: 10TTO) [02:18:13] (03CR) 10Jforrester: [C: 032] Apply bidi styles to references in Parsoid styles [core] - 10https://gerrit.wikimedia.org/r/149081 (owner: 10Catrope) [02:18:50] (03CR) 10Mattflaschen: Do not run `navigator.getUserMedia()` when not supported (031 comment) [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/148067 (owner: 10Rillke) [02:21:13] (03Merged) 10jenkins-bot: Apply bidi styles to references in Parsoid styles [core] - 10https://gerrit.wikimedia.org/r/149081 (owner: 10Catrope) [02:30:40] (03CR) 10Mattflaschen: "This is no longer required after https://gerrit.wikimedia.org/r/#/c/70328/, but you're right it still should have been here for code consi" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148510 (owner: 10Reedy) [02:32:30] (03CR) 10Mattflaschen: "The return true is no longer required after https://gerrit.wikimedia.org/r/#/c/70328/ though it does make the code more consistent." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/137528 (https://bugzilla.wikimedia.org/65514) (owner: 10Mattflaschen) [02:42:24] (03CR) 10Bsitu: Break notifications into alert and message sections (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 (owner: 10Bsitu) [03:17:31] 3MediaWiki extensions / 3MassMessage: MassMessage: Bugs related to contenthandler branch (tracking) - 10https://bugzilla.wikimedia.org/68599 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Tracking bug for bug 61255, and things in the "contenthandler" branch. [03:22:30] 3MediaWiki extensions / 3MassMessage: MassMessage: Bugs related to contenthandler branch (tracking) - 10https://bugzilla.wikimedia.org/68599 (10Kunal Mehta (Legoktm)) [03:22:30] 3MediaWiki extensions / 3MassMessage: mm-ch: Implement sane diffs - 10https://bugzilla.wikimedia.org/68600 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Not clean diffs are http://mm-ch.wmflabs.org/w/index.php?title=Test!&curid=6&diff=17&oldid=16 http://mm-ch.wmflabs.org/w/index.php?titl... [03:26:05] 3MediaWiki extensions / 3MassMessage: MassMessage: Bugs related to contenthandler branch (tracking) - 10https://bugzilla.wikimedia.org/68599 (10Kunal Mehta (Legoktm)) [03:26:31] (03PS21) 10Ebe123: Enable the creation of empty pages [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) [03:26:58] (03CR) 10Ebe123: "Rebase." [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [03:28:00] 3MediaWiki extensions / 3MassMessage: MassMessage: Bugs related to contenthandler branch (tracking) - 10https://bugzilla.wikimedia.org/68599 (10Kunal Mehta (Legoktm)) [03:28:00] 3MediaWiki extensions / 3MassMessage: mm-ch: Allow for editing of old revisions - 10https://bugzilla.wikimedia.org/68602 (10Kunal Mehta (Legoktm)) 3ASSI p:3Unprio s:3normal a:3wctaiwan In Special:EditMassMessageList [03:31:58] (03CR) 10Ebe123: "@Parent5446: Review please?" [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [03:32:03] 3MediaWiki extensions / 3MassMessage: MassMessage: Bugs related to contenthandler branch (tracking) - 10https://bugzilla.wikimedia.org/68599 (10Kunal Mehta (Legoktm)) [03:32:03] 3MediaWiki extensions / 3MassMessage: mm-ch: MassMessageContent should support using the parser cache - 10https://bugzilla.wikimedia.org/68603 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3enhanc a:3None For performance. [03:33:28] 3MediaWiki extensions / 3MassMessage: mm-ch: MassMessageContent should support using the parser cache - 10https://bugzilla.wikimedia.org/68603 (10Kunal Mehta (Legoktm)) p:5Unprio>3Low [03:35:15] (03PS1) 10Wctaiwan: Normalize JSON in preSaveTransform [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/149499 [03:39:44] (03CR) 10Legoktm: [C: 032] Normalize JSON in preSaveTransform [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/149499 (owner: 10Wctaiwan) [03:39:52] (03Merged) 10jenkins-bot: Normalize JSON in preSaveTransform [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/149499 (owner: 10Wctaiwan) [03:46:36] (03CR) 10Parent5446: [C: 032] Enable the creation of empty pages [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [03:49:41] (03Merged) 10jenkins-bot: Enable the creation of empty pages [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [03:50:37] 3MediaWiki / 3Page editing: MediaWiki should not prevent creation of empty pages - 10https://bugzilla.wikimedia.org/57238 (10Tyler Romeo) 5PATC>3RESO/FIX [03:50:59] 3MediaWiki / 3Page editing: Unable to create blank user page - 10https://bugzilla.wikimedia.org/65206 (10Tyler Romeo) 5PATC>3RESO/FIX [04:03:34] (03CR) 10Legoktm: [C: 04-1] SpecialVersion: Handle Closures in $wgHooks nicer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/148922 (owner: 10Legoktm) [04:07:53] (03PS1) 10Cscott: Create CHANGELOG. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/149503 [04:07:55] (03PS1) 10Cscott: Release 1.0.0. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/149504 [04:07:57] (03PS1) 10Cscott: Bump version after release. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/149505 [04:08:02] 3MediaWiki-Vagrant: Support newer puppet (3.6.x) - 10https://bugzilla.wikimedia.org/67214#c2 (10Tyler Romeo) FYI: http://docs.puppetlabs.com/puppet/latest/reference/lang_import.html The import statement will be removed in Puppet 4. [04:08:36] (03CR) 10Cscott: [C: 032] Create CHANGELOG. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/149503 (owner: 10Cscott) [04:08:50] (03CR) 10Cscott: [C: 032] Release 1.0.0. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/149504 (owner: 10Cscott) [04:09:01] (03CR) 10Cscott: [C: 032] Bump version after release. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/149505 (owner: 10Cscott) [04:11:54] (03Merged) 10jenkins-bot: Create CHANGELOG. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/149503 (owner: 10Cscott) [04:11:56] (03Merged) 10jenkins-bot: Release 1.0.0. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/149504 (owner: 10Cscott) [04:12:01] (03Merged) 10jenkins-bot: Bump version after release. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/149505 (owner: 10Cscott) [04:15:45] 3MediaWiki-Vagrant: Support newer puppet (3.6.x) - 10https://bugzilla.wikimedia.org/67214#c3 (10Bryan Davis) (In reply to Tyler Romeo from comment #2) > FYI: http://docs.puppetlabs.com/puppet/latest/reference/lang_import.html > > The import statement will be removed in Puppet 4. Acknowledged. The Ubuntu 14.0... [04:17:45] 3MediaWiki-Vagrant: Support newer puppet (3.6.x) - 10https://bugzilla.wikimedia.org/67214#c4 (10Tyler Romeo) Indeed, but there should probably be some sort of migration plan, considering that the plugin currently relies on the import statement in order to add roles. [04:21:01] 3MediaWiki extensions / 3WikidataRepo: SnakUnserializer must not fail on mismatching hashes - 10https://bugzilla.wikimedia.org/68565#c2 (10Jeroen De Dauw) The hash is not part of the value, this should never have been done by the deserializer. Killed by https://github.com/wmde/WikibaseDataModelSerialization... [04:21:46] 3MediaWiki extensions / 3WikidataRepo: SnakUnserializer must not fail on mismatching hashes - 10https://bugzilla.wikimedia.org/68565#c3 (10Jeroen De Dauw) Wow, this has 8 points? Nice. That means I can now take a day off I guess :) [04:44:34] (03PS11) 10Bsitu: Break notifications into alert and message sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 [04:52:14] 3MediaWiki-Vagrant: Support newer puppet (3.6.x) - 10https://bugzilla.wikimedia.org/67214#c5 (10Bryan Davis) (In reply to Tyler Romeo from comment #4) > Indeed, but there should probably be some sort of migration plan, > considering that the plugin currently relies on the import statement in > order to add rol... [04:52:46] 3MediaWiki-Vagrant: Change multiwiki wikis to use the configuration of the primary wiki by default - 10https://bugzilla.wikimedia.org/68605 (10Bryan Davis) 3NEW p:3Unprio s:3normal a:3Ori Livneh When I first wrote the multiwiki functionality during the Zürich hackathon, I made a fundamental assumption... [04:53:16] 3MediaWiki-Vagrant: Change multiwiki wikis to use the configuration of the primary wiki by default - 10https://bugzilla.wikimedia.org/68605 (10Bryan Davis) p:5Unprio>3Normal a:5Ori Livneh>3Bryan Davis [04:53:16] 3MediaWiki-Vagrant: Merge multiwiki and mediawiki puppet modules (always a wiki farm) - 10https://bugzilla.wikimedia.org/68168 (10Bryan Davis) [05:37:47] (03PS6) 10Rohan013: Cleaner Special:Watchlist options form [core] - 10https://gerrit.wikimedia.org/r/149268 (https://bugzilla.wikimedia.org/48615) [05:40:04] 3MediaWiki extensions / 3WikidataRepo: SnakUnserializer must not fail on mismatching hashes - 10https://bugzilla.wikimedia.org/68565#c4 (10Jeroen De Dauw) While this fixes the issue at hand, the way the snak hash is implemented sucks. Created a ticket https://github.com/wmde/WikibaseDataModel/issues/130 [05:40:04] 3MediaWiki extensions / 3WikidataRepo: SnakUnserializer must not fail on mismatching hashes - 10https://bugzilla.wikimedia.org/68565 (10Jeroen De Dauw) 5ASSI>3PATC [06:41:47] (03CR) 10Legoktm: [C: 032 V: 032] "It would be nice if the extension had tests. I applied this diff and made sure the output looked similar to the 1.20 patch. Only line numb" [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/148409 (https://bugzilla.wikimedia.org/55640) (owner: 10Jack Phoenix) [06:44:05] 3MediaWiki extensions / 3MediaWikiAuth: Stop requiring core patches for MediaWikiAuth to function - 10https://bugzilla.wikimedia.org/68607 (10Kunal Mehta (Legoktm)) p:5Unprio>3High [06:44:07] 3MediaWiki extensions / 3MediaWikiAuth: Stop requiring core patches for MediaWikiAuth to function - 10https://bugzilla.wikimedia.org/68607 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3major a:3None Maybe this needs a hook in core or something, but hacking core is terrible and we need to stop doing it. [06:45:15] 3MediaWiki extensions / 3MediaWikiAuth: Add patches for SpecialUserlogin.php for mw1.21, 1.23 - 10https://bugzilla.wikimedia.org/55640#c6 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX I filed bug 68607 to stop needing patches. 1.19 is going to be EOL soon, so I guess we don't need that. Uncyclomedia skipped... [06:54:52] (03PS2) 10Legoktm: Use master DB to check for page existence during import [core] - 10https://gerrit.wikimedia.org/r/148309 (https://bugzilla.wikimedia.org/40009) (owner: 10TTO) [06:55:14] (03CR) 10Legoktm: [C: 032] Use master DB to check for page existence during import [core] - 10https://gerrit.wikimedia.org/r/148309 (https://bugzilla.wikimedia.org/40009) (owner: 10TTO) [06:57:29] 3Wikimedia / 3Site requests: Run script to recalculate Wikivoyage statistics - 10https://bugzilla.wikimedia.org/64370#c13 (10Kunal Mehta (Legoktm)) It doesn't have any scheduled runs AFAIK. MediaWiki should ideally keep everything in sync. [06:58:32] (03Merged) 10jenkins-bot: Use master DB to check for page existence during import [core] - 10https://gerrit.wikimedia.org/r/148309 (https://bugzilla.wikimedia.org/40009) (owner: 10TTO) [07:15:35] (03Abandoned) 10Isarra: Add normalize.css as an available resource [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [07:24:45] (03CR) 10Frédéric Wang: [C: 04-1] Add width and height to SVG image (032 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/144939 (https://bugzilla.wikimedia.org/20202) (owner: 10Physikerwelt) [07:27:45] 3MediaWiki / 3Export/Import: Special:Import increases NUMBEROFARTICLES for each Revision instead of each Article - 10https://bugzilla.wikimedia.org/40009#c23 (10This, that and the other) 5PATC>3RESO/FIX Tentatively marking fixed. If this issue still shows up on Wikimedia wikis after 7 August, we can reop... [07:28:18] 3MediaWiki / 3Export/Import: Special:Import increases NUMBEROFARTICLES for each Revision instead of each Article - 10https://bugzilla.wikimedia.org/40009 (10This, that and the other) a:3This, that and the other [07:30:32] 3Wikimedia / 3General/Unknown: url-downloader.wikimedia.org proxy cannot access *.wmflabs.org - 10https://bugzilla.wikimedia.org/68264#c2 (10Kunal Mehta (Legoktm)) 5NEW>3RESO/WON Chad and I have worked out a way so that we won't need prod to talk to labs. [07:35:31] 3Wikimedia / 3General/Unknown: Use new labs project (extdist.wmflabs.org) for ExtensionDistributor - 10https://bugzilla.wikimedia.org/68122#c1 (10Kunal Mehta (Legoktm)) New plan after talking with Chad: have ExtensionDistributor get a list of branches from Gerrit's API (I5c4ca2ee13f256260a7fe9b703af5fbdb902d... [07:39:48] 3Wikimedia / 3General/Unknown: Use new labs project (extdist.wmflabs.org) for ExtensionDistributor - 10https://bugzilla.wikimedia.org/68122 (10Kunal Mehta (Legoktm)) [07:39:50] 3MediaWiki extensions / 3ExtensionDistributor: ExtensionDistributor: Fetch branch information from Gerrit - 10https://bugzilla.wikimedia.org/68608 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None So it no longer depends upon github. [07:40:32] 3MediaWiki / 3Page editing: MediaWiki should not prevent creation of empty pages - 10https://bugzilla.wikimedia.org/57238#c9 (10Nemo) a:3Florian Thanks! This was really a pain, let's hope we're back to business. https://translatewiki.net/w/i.php?title=FAQ&diff=5669175&oldid=5599206 [07:40:46] 3MediaWiki / 3Export/Import: Import of Commons partial export fails with error about plurals-mediawiki.xml - 10https://bugzilla.wikimedia.org/56439#c9 (10This, that and the other) 5NEW>3PATC a:3This, that and the other Apparently caused by the fact that libxml_disable_entity_loader is not thread-safe.... [07:41:32] (03PS1) 10TTO: Use file_get_contents to load plurals XML data [core] - 10https://gerrit.wikimedia.org/r/149507 (https://bugzilla.wikimedia.org/56439) [07:41:38] 3Wikimedia / 3General/Unknown: Use new labs project (extdist.wmflabs.org) for ExtensionDistributor - 10https://bugzilla.wikimedia.org/68122 (10Kunal Mehta (Legoktm)) [07:42:50] 3MediaWiki / 3Export/Import: The stream wrapper should test whether the resource 'uploadsource' is already registered. - 10https://bugzilla.wikimedia.org/65530#c3 (10This, that and the other) 5PATC>3RESO/FIX Patch was merged some time ago. [07:43:07] (03PS2) 10Legoktm: Add support for fetching branch lists from Gerrit [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/149474 (https://bugzilla.wikimedia.org/68608) [07:43:46] 3MediaWiki / 3Export/Import: Import of Commons partial export fails with error about plurals-mediawiki.xml - 10https://bugzilla.wikimedia.org/56439#c11 (10This, that and the other) *** Bug 65116 has been marked as a duplicate of this bug. *** [07:43:46] 3MediaWiki / 3Export/Import: Errors during import of dump file - 10https://bugzilla.wikimedia.org/65116#c3 (10This, that and the other) 5UNCO>3RESO/DUP *** This bug has been marked as a duplicate of bug 56439 *** [07:49:47] 3MediaWiki / 3Export/Import: Import of Commons partial export fails with error about plurals-mediawiki.xml - 10https://bugzilla.wikimedia.org/56439 (10Nemo) [07:52:43] 3MediaWiki extensions / 3CodeEditor: [Regression] Disabled CodeEditor prevents toolbar functions to work - 10https://bugzilla.wikimedia.org/68556#c2 (10Michael M.) (In reply to Derk-Jan Hartman from comment #1) > Are we sure that that is a regression ? Because if a take a peek at > textSelection, it seems li... [08:56:28] (03PS1) 10TTO: Use XML localName when importing [core] - 10https://gerrit.wikimedia.org/r/149508 (https://bugzilla.wikimedia.org/4520) [08:57:42] 3MediaWiki / 3Database: Fix "Uncommitted DB writes (transaction from DatabaseBase::query)" - 10https://bugzilla.wikimedia.org/56269 (10This, that and the other) 5PATC>3NEW [08:58:29] (03CR) 10Aude: [C: 031] ":)" [wikimedia/bots/jouncebot] - 10https://gerrit.wikimedia.org/r/149202 (owner: 10Dzahn) [09:21:57] 3Wikimedia / 3Bugzilla: Add "contenthandler" version to MassMessage component - 10https://bugzilla.wikimedia.org/68555#c3 (10Andre Klapper) (In reply to Tyler Romeo from comment #1) > I'm afraid Bugzilla does not allow us to change versions by component. Correct, versions are on a product level... [09:27:14] 3MediaWiki / 3Special pages: HHVM: Special:Version with $wgSpecialVersionShowHooks = true appends a hash after Closures - 10https://bugzilla.wikimedia.org/68592 (10Andre Klapper) p:5Unprio>3Normal [09:29:12] 3Wikimedia / 3Git/Gerrit: Gerrit email subject line should distinguish between "has posted comments on this change" and " I'd like you to reexamine a change." - 10https://bugzilla.wikimedia.org/68598 (10Andre Klapper) s:5normal>3enhanc [09:45:45] (03CR) 10Smuggli: [C: 032 V: 032] Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/146428 (owner: 10Smuggli) [09:46:50] (03CR) 10Smuggli: [C: 032 V: 032] Added new message [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/148979 (owner: 10Smuggli) [09:47:25] (03CR) 10Smuggli: [C: 032 V: 032] Implemented changes for translatewiki [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/149027 (owner: 10Smuggli) [09:48:04] (03CR) 10Smuggli: [C: 032 V: 032] Added new sections to credits [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/149290 (owner: 10Smuggli) [10:16:31] 3MediaWiki extensions / 3CirrusSearch: Search for Module: results in a bold sidebar. - 10https://bugzilla.wikimedia.org/61348#c6 (10snaevar) I did some further investigating with the following findings: * I can repreduce this issue in firefox (newest version) on several windows xp sp3 machines.... [10:19:55] (03PS1) 1001tonythomas: Changed the SwiftMailer repo location from Wiki-repo to defualt [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/149516 [10:23:21] (03PS13) 10Umherirrender: Add dynamic maxlength to Special:RevisionDelete [core] - 10https://gerrit.wikimedia.org/r/135197 (https://bugzilla.wikimedia.org/34467) [10:28:44] 3MediaWiki extensions / 3CirrusSearch: Bold sidebar and search results when searching in Windows xp sp3 - 10https://bugzilla.wikimedia.org/61348 (10snaevar) [11:00:59] is there a way to encapsulate an array in an i18n message? e.g. have something like "List of results:\n* r1\n* r2...\n...* rN" where r1, r2, ... are in an array [11:03:18] 3Wikimedia / 3Site requests: Create moderator group at the Vietnamese Wikipedia - 10https://bugzilla.wikimedia.org/68612 (10Minh Nguyễn) 3NEW p:3Unprio s:3normal a:3None The Vietnamese Wikipedia community has voted to establish a new "moderator" user group, called "điều phối viên" in Vietnamese. Memb... [11:04:00] 3Wikimedia / 3Site requests: Create moderator group at the Vietnamese Wikipedia - 10https://bugzilla.wikimedia.org/68612 (10Minh Nguyễn) [11:06:14] 3Wikimedia / 3Site requests: Create moderator group at the Vietnamese Wikipedia - 10https://bugzilla.wikimedia.org/68612 (10Vogone) p:5Unprio>3Normal s:5normal>3enhanc [11:17:12] 3Wikimedia / 3Site requests: Run script to recalculate Wikivoyage statistics - 10https://bugzilla.wikimedia.org/64370#c14 (10Andyrom75) Kunal, unfortunately the sync doesn't happen, in fact since the last syncronization, some language version (en:voy, fr:voy, it:voy, ...) already has some misalignement, due... [11:20:01] 3MediaWiki / 3Export/Import: Special:Import increases NUMBEROFARTICLES for each Revision instead of each Article - 10https://bugzilla.wikimedia.org/40009#c24 (10Andyrom75) This, that and the other, your patch is already running? In the affirmative case we can test it, importing a page. If the article counter... [11:26:13] 3Wikimedia / 3Extension setup: FlaggedRevs for Norwegian (bokmål) Wikipedia - 10https://bugzilla.wikimedia.org/64726#c11 (10Nemo) p:5Normal>3Low Realistically, this is low priority, as in having little chance of being picked up by someone other than the proposers. I've added some tips based on observatio... [11:26:58] 3MediaWiki / 3Export/Import: Special:Import increases NUMBEROFARTICLES for each Revision instead of each Article - 10https://bugzilla.wikimedia.org/40009#c25 (10This, that and the other) (In reply to Andyrom75 from comment #24) > This, that and the other, your patch is already running? Not yet; you'll have... [12:15:04] wctaiwan: yes, but for lists you should instead use generic functions or messages [12:15:36] Nemo_bis: what do you mean? [12:15:54] (the use case is that I need to return an error message in an HTMLForm containing a list of invalid data) [12:16:08] (but HTMLForm encapsulates errors in Status objects, so I get very little freedom) [12:16:42] wrapWikiMsg can do what you said https://www.mediawiki.org/wiki/Manual:Messages_API#Additional_methods_of_printing_messages [12:17:26] thanks; I'll look into it [12:17:32] But we also have e.g. a function to make a comma-separated (i18n'ed) list [12:18:00] It's always preferable to not hardcode a format in your code [12:19:37] Check Language.php [12:20:00] alright, thanks. [12:20:33] (03PS1) 10Cook879: Adding a user right for Special:Export to allow it to be restricted to certain user groups. [core] - 10https://gerrit.wikimedia.org/r/149522 [12:21:34] (03CR) 10Cook879: Add i18n file (031 comment) [extensions/Vine] - 10https://gerrit.wikimedia.org/r/146134 (owner: 10Raimond Spekking) [12:38:03] "This image rendered as PNG in other widths" is not translatable? https://commons.wikimedia.org/wiki/File:Santa_Engracia_del_Jubera_-_La_Rioja_(Spain)_-_Municipality_Map.svg?uselang=qqx [12:42:59] (03PS1) 10Wctaiwan: Enable editing of old revisions [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/149525 [12:45:53] (03CR) 10Paladox: "Well if we carnt upgrade to 2.9 could we upgrade to the latest 2.8.x release until it is ready to move from gerrit." [gerrit] - 10https://gerrit.wikimedia.org/r/147990 (owner: 10Paladox) [12:53:54] nvm [13:23:45] 3MediaWiki extensions / 3CodeEditor: [Regression] Disabled CodeEditor prevents toolbar functions to work - 10https://bugzilla.wikimedia.org/68556#c3 (10Derk-Jan Hartman) a:3Derk-Jan Hartman Bingo got it. Now to find a better way to fix this.... and more importantly.. document it... [13:24:09] (03PS12) 10Physikerwelt: Add width and height to SVG image [extensions/Math] - 10https://gerrit.wikimedia.org/r/144939 (https://bugzilla.wikimedia.org/20202) [13:27:59] (03PS13) 10Physikerwelt: Add width and height to SVG image [extensions/Math] - 10https://gerrit.wikimedia.org/r/144939 (https://bugzilla.wikimedia.org/20202) [13:28:42] 3MediaWiki extensions / 3Scribunto: We need a common repository for Scribunto modules and templates - 10https://bugzilla.wikimedia.org/50329#c20 (10Rob Kam) Posted as a draft RFC https://www.mediawiki.org/wiki/Requests_for_comment/A_central_repository_for_templates [13:31:22] (03PS14) 10Physikerwelt: Add width and height to SVG image [extensions/Math] - 10https://gerrit.wikimedia.org/r/144939 (https://bugzilla.wikimedia.org/20202) [13:38:05] (03CR) 10Physikerwelt: Add width and height to SVG image (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/144939 (https://bugzilla.wikimedia.org/20202) (owner: 10Physikerwelt) [13:46:52] (03PS1) 10Physikerwelt: Remove unused empty production for `litsq_zq` in texvc [extensions/Math] (texvc-fixes) - 10https://gerrit.wikimedia.org/r/149526 [13:49:21] (03Abandoned) 10Physikerwelt: Remove unused empty production for `litsq_zq` in texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/149089 (owner: 10Cscott) [13:49:43] 3MediaWiki extensions / 3WikidataRepo: Some localized dates can't be encoded in date property fields. - 10https://bugzilla.wikimedia.org/68236#c2 (10Lydia Pintscher) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 48962 *** [13:49:57] 3MediaWiki extensions / 3WikidataRepo: localize display of time values - 10https://bugzilla.wikimedia.org/48962#c9 (10Lydia Pintscher) *** Bug 68236 has been marked as a duplicate of this bug. *** [13:49:59] (03PS1) 10Physikerwelt: Switch to text mode before emitting \AA or \textvisiblespace. [extensions/Math] (texvc-fixes) - 10https://gerrit.wikimedia.org/r/149527 [13:50:28] 3MediaWiki extensions / 3WikidataRepo: WikidataRepo: message “summary” escaped twice in undo form - 10https://bugzilla.wikimedia.org/68221 (10Lydia Pintscher) [13:50:56] (03PS1) 10Physikerwelt: Some commands should require arguments in `texvc` and `texvccheck` [extensions/Math] (texvc-fixes) - 10https://gerrit.wikimedia.org/r/149528 [13:52:56] (03CR) 10Physikerwelt: "automatic cherry picking of this change does not work" [extensions/Math] - 10https://gerrit.wikimedia.org/r/148677 (owner: 10Cscott) [13:53:45] (03CR) 10Physikerwelt: [C: 032] Remove unused empty production for `litsq_zq` in texvc [extensions/Math] (texvc-fixes) - 10https://gerrit.wikimedia.org/r/149526 (owner: 10Physikerwelt) [13:54:39] (03Merged) 10jenkins-bot: Remove unused empty production for `litsq_zq` in texvc [extensions/Math] (texvc-fixes) - 10https://gerrit.wikimedia.org/r/149526 (owner: 10Physikerwelt) [14:10:18] (03PS1) 10TheDJ: jquery.textSelection: Add setContents function [core] - 10https://gerrit.wikimedia.org/r/149529 [14:15:02] (03CR) 10Legoktm: [C: 04-1] Enable editing of old revisions (032 comments) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/149525 (owner: 10Wctaiwan) [14:19:16] 3Wikimedia / 3Site requests: Add import sources for bhwiki - 10https://bugzilla.wikimedia.org/68616 (10Marius Hoch) 3NEW p:3Unprio s:3normal a:3Marius Hoch Per https://bh.wikipedia.org/w/index.php?title=%E0%A4%B5%E0%A4%BF%E0%A4%95%E0%A4%BF%E0%A4%AA%E0%A5%80%E0%A4%A1%E0%A4%BF%E0%A4%AF%E0%A4%BE:%E0%A4%... [14:26:58] 3Wikimedia / 3Mailing lists: Wrong cert on mail.wikipedia.org (as it redirects to lists.wikimedia.org) - 10https://bugzilla.wikimedia.org/44731#c14 (10Zell Faze) I would recommend not turning off HTTPS on the domain if that is the direction the discussion is heading. I like the idea of even just the simple... [14:38:08] (03CR) 10Frédéric Wang: [C: 032] "OK, looks good to me." [extensions/Math] - 10https://gerrit.wikimedia.org/r/144939 (https://bugzilla.wikimedia.org/20202) (owner: 10Physikerwelt) [14:39:12] 3MediaWiki extensions / 3Math: Web performance: texvc math images do not specify width and height attributes - 10https://bugzilla.wikimedia.org/20202#c10 (10Frédéric Wang) (In reply to Gerrit Notification Bot from comment #9) > Change 144939 merged by Frédéric Wang: > Add width and height to SVG image > > h... [14:49:43] 3MediaWiki extensions / 3WikidataClient: preferences do not respect showExternalRecentChanges setting - 10https://bugzilla.wikimedia.org/68463 (10Aude) 5PATC>3RESO/FIX [14:50:29] 3MediaWiki extensions / 3WikidataClient: "Other projects sidebar" beta feature - 10https://bugzilla.wikimedia.org/66718 (10Aude) 5PATC>3RESO/FIX [14:52:43] 3MediaWiki extensions / 3WikidataRepo: Server side generated html of read only Entity views shouldn't include edit links - 10https://bugzilla.wikimedia.org/68325 (10John F. Lewis) p:5Unprio>3Normal [14:53:27] 3MediaWiki extensions / 3WikidataRepo: Alias for Special:MergeItems - 10https://bugzilla.wikimedia.org/68434 (10John F. Lewis) p:5Unprio>3Low [14:53:57] 3MediaWiki extensions / 3WikidataRepo: Make EntityView UI aware of redirects - 10https://bugzilla.wikimedia.org/68567 (10John F. Lewis) p:5Unprio>3Normal [14:55:19] (03PS1) 10Gerrit Patch Uploader: Implement LanguageConverter for Wuu. [core] - 10https://gerrit.wikimedia.org/r/149531 [14:55:21] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/149531 (owner: 10Gerrit Patch Uploader) [14:56:29] 3MediaWiki extensions / 3WikidataRepo: Introduce item-redirect permission - 10https://bugzilla.wikimedia.org/68454 (10John F. Lewis) p:5Unprio>3Normal [14:57:28] 3MediaWiki extensions / 3WikidataRepo: Special:MergeHistory does not work for Wikidata items - 10https://bugzilla.wikimedia.org/68533 (10John F. Lewis) p:5Unprio>3Lowest [14:57:58] 3MediaWiki extensions / 3WikidataRepo: add script for stitching json dump shards - 10https://bugzilla.wikimedia.org/68366 (10John F. Lewis) p:5Unprio>3Normal [14:59:13] 3MediaWiki extensions / 3WikidataRepo: TimeValue-datatype doesn't wait on conversion, making wrong edits - 10https://bugzilla.wikimedia.org/68443 (10John F. Lewis) p:5Unprio>3Normal [15:00:30] 3MediaWiki extensions / 3WikidataClient: the show/hide recent changes and watchlist toggle does not respect showExternalRecentChanges setting - 10https://bugzilla.wikimedia.org/68461 (10John F. Lewis) p:5Unprio>3Normal [15:00:57] 3Wikimedia / 3Wikidata: add epp_redirect_target column to wb_entity_per_page table - 10https://bugzilla.wikimedia.org/68290 (10John F. Lewis) p:5Unprio>3Normal [15:10:30] 3Wikimedia / 3Site requests: Change "abusefilter-log-detail" user group rights on es.wikipedia - 10https://bugzilla.wikimedia.org/68319 (10Vogone) 5UNCO>3ASSI a:3Vogone [15:41:44] 3MediaWiki extensions / 3CirrusSearch: Bold sidebar and search results when searching in Windows xp sp3 - 10https://bugzilla.wikimedia.org/61348#c7 (10Andre Klapper) What is "firefox (newest version)" exactly? "Newest" highly depends on your update channels. Plus did you manage to reproduce with any other b... [15:48:31] 3MediaWiki / 3General/Unknown: slow query: INSERT /* JobQueueDB::doBatchPush 127.0.0.1 */ INTO `unittest_job` etc. - 10https://bugzilla.wikimedia.org/68620 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Ubuntu 14.04, HipHop VM 3.3.0-dev, labs-vagrant with simple_performant role enabled. this is a bit ugl... [15:52:24] (03PS1) 10Aude: Initial role for wikibase [vagrant] - 10https://gerrit.wikimedia.org/r/149534 [15:53:32] (03Abandoned) 10Aude: Initial puppet role for Wikibase [WIP] [vagrant] - 10https://gerrit.wikimedia.org/r/132628 (owner: 10Aude) [15:56:09] (03PS2) 1001tonythomas: Changed the SwiftMailer repo location from own-repo to default [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/149516 [15:56:34] 3MediaWiki / 3General/Unknown: HPHP::JIT::Type::bitsFromDataType(HPHP::DataType, HPHP::DataType): assertion `false && "Unsupported DataType"' failed. - 10https://bugzilla.wikimedia.org/68621 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Ubuntu 14.04, HipHop VM 3.3.0-dev, labs-vagrant with simple_performa... [16:03:01] 3MediaWiki / 3General/Unknown: Locale is not fully working if we are not logged in Wikidata - 10https://bugzilla.wikimedia.org/68622 (10Olivier Delaune) 3UNCO p:3Unprio s:3normal a:3None Hello, first of all, I apologize if I do not fill the bug report correctly (component, version, ...) and if I crea... [16:03:29] 3MediaWiki / 3General/Unknown: Locale is not fully working if we are not logged in Wikidata - 10https://bugzilla.wikimedia.org/68622#c1 (10Olivier Delaune) I am using Firefox 25.7.0 on Linux Mageia 4.1 [16:12:43] 3MediaWiki / 3General/Unknown: HPHP::JIT::Type::bitsFromDataType(HPHP::DataType, HPHP::DataType): assertion `false && "Unsupported DataType"' failed. - 10https://bugzilla.wikimedia.org/68621#c1 (10Nemo) Nope, disabling fss didn't help [16:16:00] 3MediaWiki extensions / 3WikidataRepo: Special:MergeHistory does not work for Wikidata items - 10https://bugzilla.wikimedia.org/68533#c4 (10Vogone) p:5Lowest>3Normal I don't believe fatal exceptions deserve "Lowest" priority. [16:32:44] 3MediaWiki / 3Unit tests: PHP unit tests don't work if not run from tests/phpunit directory - "Call to a member function numRows() on a non-object" - 10https://bugzilla.wikimedia.org/56909#c6 (10Mark A. Hershberger) This isn't trivial to cherry pick. Was the problem in 1.23? [16:33:33] (03CR) 10Hcohl: [C: 031] The first job for Math extension [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149323 (https://bugzilla.wikimedia.org/67221) (owner: 10Cmcmahon) [16:45:26] (03PS1) 10Aude: add role for installing phpunit with hhvm [vagrant] - 10https://gerrit.wikimedia.org/r/149535 [16:45:29] 3MediaWiki extensions / 3Spam Blacklist: regex expressions starting with caret (^) not functioning as per instructions say - 10https://bugzilla.wikimedia.org/64541#c4 (10Glaisher) Yepp, it works. It didn't last time probably because the list was not updated when it was tested. The documentation at mww is wro... [16:46:06] (03CR) 10Aude: [C: 04-2] "just want feedback first regarding best approach, and have this patch as something that works for me/now. :)" [vagrant] - 10https://gerrit.wikimedia.org/r/149535 (owner: 10Aude) [16:48:22] (03PS2) 10Aude: add role for installing phpunit with hhvm [vagrant] - 10https://gerrit.wikimedia.org/r/149535 [17:00:45] 3MediaWiki / 3Unit tests: PHP unit tests don't work if not run from tests/phpunit directory - "Call to a member function numRows() on a non-object" - 10https://bugzilla.wikimedia.org/56909#c7 (10Mark A. Hershberger) Sorry didn't mean to mark this "denied". [17:11:49] (03PS2) 10Siebrand: Implement LanguageConverter for Wuu. [core] - 10https://gerrit.wikimedia.org/r/149531 (https://bugzilla.wikimedia.org/57138) (owner: 10Gerrit Patch Uploader) [17:14:21] (03CR) 10Siebrand: "Please don't merge this without coordination with translatewiki.net. We need to move existing translations in all supported extensions and" [core] - 10https://gerrit.wikimedia.org/r/149531 (https://bugzilla.wikimedia.org/57138) (owner: 10Gerrit Patch Uploader) [17:16:07] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/149522 (owner: 10Cook879) [17:17:13] 3MediaWiki / 3General/Unknown: HPHP::JIT::Type::bitsFromDataType(HPHP::DataType, HPHP::DataType): assertion `false && "Unsupported DataType"' failed. - 10https://bugzilla.wikimedia.org/68621#c2 (10Nemo) Same when I did: 18.34 < aude> hhvm -v Server.IncludeSearchPaths.share='/srv/vagrant/mediawiki/vendor/php... [17:18:07] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/149268 (https://bugzilla.wikimedia.org/48615) (owner: 10Rohan013) [17:19:53] (03PS18) 10Brion VIBBER: Work in progress: early testing of integration with ogv.js media player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) [17:20:06] (03CR) 10Siebrand: Break notifications into alert and message sections (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 (owner: 10Bsitu) [17:21:46] (03CR) 10BryanDavis: "aude: We could install phpunit globally if that is desirable. Currently phpunit is installed via composer as /vagrant/mediawiki/vendor/bin" (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/149535 (owner: 10Aude) [17:22:40] (03CR) 10BryanDavis: "Maybe we should just add /vagrant/mediawiki/vendor/bin to the default search path?" [vagrant] - 10https://gerrit.wikimedia.org/r/149535 (owner: 10Aude) [17:24:19] (03CR) 10Siebrand: [C: 032] "Hit the wrong radio button, apparently." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148313 (https://bugzilla.wikimedia.org/68359) (owner: 10TTO) [17:24:21] (03CR) 10jenkins-bot: [V: 04-1] Add strings for localisation of Wikivoyage RelatedSites links [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148313 (https://bugzilla.wikimedia.org/68359) (owner: 10TTO) [17:25:01] (03CR) 10Siebrand: [C: 032] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/149491 (owner: 10TTO) [17:25:04] (03CR) 10Aude: "either option is good with me" (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/149535 (owner: 10Aude) [17:27:06] (03CR) 10Siebrand: "i18n/L10n reviewed." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [17:27:31] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149210 (owner: 10Werdna) [17:28:05] (03Merged) 10jenkins-bot: Improving some import-related error messages [core] - 10https://gerrit.wikimedia.org/r/149491 (owner: 10TTO) [17:29:23] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/149467 (https://bugzilla.wikimedia.org/56380) (owner: 10Vogone) [17:29:51] (03CR) 10BryanDavis: Changed the SwiftMailer repo location from own-repo to default (031 comment) [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/149516 (owner: 1001tonythomas) [17:30:10] (03CR) 10Siebrand: [C: 031] Close out extension and note TimedMediaHandler as replacement [extensions/OggHandler] - 10https://gerrit.wikimedia.org/r/149465 (owner: 10Mattflaschen) [17:32:53] (03CR) 10Aude: Initial role for wikibase (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/149534 (owner: 10Aude) [17:36:12] (03CR) 10Vogone: Fix appearance of suppress messages at Special:Undelete (031 comment) [core] - 10https://gerrit.wikimedia.org/r/149467 (https://bugzilla.wikimedia.org/56380) (owner: 10Vogone) [17:36:14] 3MediaWiki / 3Unit tests: PHP unit tests don't work if not run from tests/phpunit directory - "Call to a member function numRows() on a non-object" - 10https://bugzilla.wikimedia.org/56909#c8 (10Umherirrender) The merge conflict is with gerrit 146674, which was also the conflict on the first Code-Review+2. A... [17:36:32] (03PS4) 10Siebrand: Rename Preprocessor_DOM/Preprocessor_Hash [core] - 10https://gerrit.wikimedia.org/r/149382 (owner: 10Umherirrender) [17:37:24] (03CR) 10Siebrand: Fix appearance of suppress messages at Special:Undelete (031 comment) [core] - 10https://gerrit.wikimedia.org/r/149467 (https://bugzilla.wikimedia.org/56380) (owner: 10Vogone) [17:39:09] (03CR) 10Siebrand: [C: 032] Make a hidden form field to keep the language code [core] - 10https://gerrit.wikimedia.org/r/147904 (owner: 10Kunalgrover05) [17:42:15] (03Merged) 10jenkins-bot: Make a hidden form field to keep the language code [core] - 10https://gerrit.wikimedia.org/r/147904 (owner: 10Kunalgrover05) [17:46:05] (03CR) 10Siebrand: [C: 032] Show change language log on Special:PageLanguage [core] - 10https://gerrit.wikimedia.org/r/147896 (owner: 10Kunalgrover05) [17:49:08] (03Merged) 10jenkins-bot: Show change language log on Special:PageLanguage [core] - 10https://gerrit.wikimedia.org/r/147896 (owner: 10Kunalgrover05) [17:51:47] (03CR) 10Siebrand: "It looks like this won't be getting much love in its current state. May I propose:" [core] - 10https://gerrit.wikimedia.org/r/138555 (owner: 10devunt) [17:55:41] (03CR) 10Siebrand: "@Nemo_bis: status?" [core] - 10https://gerrit.wikimedia.org/r/135595 (https://bugzilla.wikimedia.org/65245) (owner: 10Nemo bis) [17:57:45] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/138745 (https://bugzilla.wikimedia.org/21206) (owner: 10Gerrit Patch Uploader) [17:58:16] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/118101 (https://bugzilla.wikimedia.org/56325) (owner: 10Jlloyd) [17:59:57] (03CR) 10Nemo bis: "Siebrand, https://bugzilla.wikimedia.org/show_bug.cgi?id=65245#c13" [core] - 10https://gerrit.wikimedia.org/r/135595 (https://bugzilla.wikimedia.org/65245) (owner: 10Nemo bis) [18:00:58] (03PS2) 10Raimond Spekking: Add i18n file [extensions/Vine] - 10https://gerrit.wikimedia.org/r/146134 [18:01:34] (03CR) 10Siebrand: "Thanks. As you can see I'm clearing out my backlog, too :)." [core] - 10https://gerrit.wikimedia.org/r/135595 (https://bugzilla.wikimedia.org/65245) (owner: 10Nemo bis) [18:06:43] (03CR) 10Siebrand: [C: 032 V: 032] Add i18n file [extensions/Vine] - 10https://gerrit.wikimedia.org/r/146134 (owner: 10Raimond Spekking) [18:13:56] (03PS1) 10Florianschmidtwelzow: Don't redirect to Google auth if user hit enter [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/149540 (https://bugzilla.wikimedia.org/68143) [18:13:58] (03CR) 10jenkins-bot: [V: 04-1] Don't redirect to Google auth if user hit enter [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/149540 (https://bugzilla.wikimedia.org/68143) (owner: 10Florianschmidtwelzow) [18:17:47] (03PS2) 10Florianschmidtwelzow: Don't redirect to Google auth if user hit enter [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/149540 (https://bugzilla.wikimedia.org/68143) [18:24:34] (03Abandoned) 10Florianschmidtwelzow: Add Special Page ExpirePassword [core] - 10https://gerrit.wikimedia.org/r/145238 (https://bugzilla.wikimedia.org/67792) (owner: 10Florianschmidtwelzow) [18:25:15] 3MediaWiki / 3Special pages: Allow to manually expire a user's password - 10https://bugzilla.wikimedia.org/67792 (10Florian) 5PATC>3NEW [18:25:16] 3MediaWiki-Vagrant: globalcssjs: Exception from line 79 of includes/db/CloneDatabase.php: Cannot clone shared table objectcache - 10https://bugzilla.wikimedia.org/68624 (10Nemo) 3NEW p:3Unprio s:3normal a:3Kunal Mehta (Legoktm) I did http://paste.debian.net/111811/ and got the following, fixed by labs-... [18:27:17] 3MediaWiki-Vagrant: browsertests: Error: Working directory '/srv/browsertests/tests/browser' does not exist (and others) - 10https://bugzilla.wikimedia.org/68625 (10Nemo) 3NEW p:3Unprio s:3normal a:3Ori Livneh Something wrong with the browsertests role, got after http://paste.debian.net/111811/ Notice... [18:32:22] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/114966 (https://bugzilla.wikimedia.org/60534) (owner: 10Mjnovice) [18:32:54] (03CR) 10Siebrand: "Abandon?" [core] - 10https://gerrit.wikimedia.org/r/138110 (owner: 10Bartosz Dziewoński) [18:34:37] (03CR) 10Siebrand: [C: 04-1] "Per open discussions on this patch set." [core] - 10https://gerrit.wikimedia.org/r/137982 (owner: 10Parent5446) [18:35:58] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/WebPlatformAuth] - 10https://gerrit.wikimedia.org/r/136152 (owner: 10Renoirb) [18:39:15] 3MediaWiki extensions / 3BetaFeatures: Fatal error: Call to a member function getOption() on a non-object in extensions/BetaFeatures/BetaFeaturesHooks.php on line 115 - 10https://bugzilla.wikimedia.org/68626 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Just by installing the extension and not enabling a... [18:41:42] 3MediaWiki extensions / 3BetaFeatures: Fatal error: Call to a member function getOption() on a non-object in extensions/BetaFeatures/BetaFeaturesHooks.php on line 115 - 10https://bugzilla.wikimedia.org/68626#c1 (10Bartosz Dziewoński) Oh, I ran into that and investigated a bit before getting bored. It's beca... [18:43:26] (03PS1) 10Ori.livneh: Strip tailing whitespace from debian/changelog [php/luasandbox] - 10https://gerrit.wikimedia.org/r/149544 [18:43:55] (03CR) 10Ori.livneh: [C: 032] Strip tailing whitespace from debian/changelog [php/luasandbox] - 10https://gerrit.wikimedia.org/r/149544 (owner: 10Ori.livneh) [18:44:07] (03Merged) 10jenkins-bot: Strip tailing whitespace from debian/changelog [php/luasandbox] - 10https://gerrit.wikimedia.org/r/149544 (owner: 10Ori.livneh) [18:44:32] (03CR) 10Siebrand: [C: 04-1] "This needs to be updated to match the JSON based i18n we currently have, and also has to be updated for the refactored watchlist classes. " [core] - 10https://gerrit.wikimedia.org/r/38743 (owner: 10Luis Felipe Schenone) [18:46:11] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 (owner: 10Bsitu) [18:47:51] (03CR) 10Siebrand: "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/144829 (owner: 10TK-999) [18:48:29] 3MediaWiki extensions / 3BetaFeatures: Fatal error: Call to a member function getOption() on a non-object in extensions/BetaFeatures/BetaFeaturesHooks.php on line 115 - 10https://bugzilla.wikimedia.org/68626#c2 (10Nemo) Thanks MatmaRex. [18:50:05] (03CR) 10Siebrand: [C: 04-1] ""i18n/en.json~" is not a file I'd expect." [extensions/VisualChat] - 10https://gerrit.wikimedia.org/r/135049 (owner: 10Miguel2706) [19:00:29] 3MediaWiki extensions / 3WikiEditor: Search & replace button is hard to find - 10https://bugzilla.wikimedia.org/23824#c3 (10Deepak Sharma) (In reply to Platonides from comment #0) > Created attachment 7433 [details] > Problem screenshot > > 1. Disabling "Enable dialogs for inserting links, tables and more"... [19:01:15] 3MediaWiki-Vagrant: browsertests: Error: Working directory '/srv/browsertests/tests/browser' does not exist (and others) - 10https://bugzilla.wikimedia.org/68625#c1 (10Nemo) At the next puppet run only the first is left: Notice: /Stage[main]/Apt/Exec[update_package_index]/returns: executed successfully Error:... [19:08:50] (03CR) 10Bartosz Dziewoński: [C: 032] "Huh." [core] - 10https://gerrit.wikimedia.org/r/149529 (owner: 10TheDJ) [19:10:34] (03CR) 10Bartosz Dziewoński: [C: 031] "Does anybody actually know what this is for? I don't want to step on anybody's toes…" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/149487 (owner: 10Legoktm) [19:12:14] (03Merged) 10jenkins-bot: jquery.textSelection: Add setContents function [core] - 10https://gerrit.wikimedia.org/r/149529 (owner: 10TheDJ) [19:15:45] 3MediaWiki extensions / 3CodeEditor: [Regression] Disabled CodeEditor prevents toolbar functions to work - 10https://bugzilla.wikimedia.org/68556 (10Helder) p:5Unprio>3High [19:17:01] (03CR) 10Bartosz Dziewoński: "James, it probably still is needed. Why was it removed?" [core] - 10https://gerrit.wikimedia.org/r/149121 (owner: 10Jdlrobson) [19:20:22] (03PS19) 10Brion VIBBER: Work in progress: early testing of integration with ogv.js media player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) [19:38:41] (03PS1) 10Aaron Schulz: Removed use of cache in JobQueueFederated pop() method [core] - 10https://gerrit.wikimedia.org/r/149547 [19:41:50] ori: ^ [19:45:43] (03PS3) 10Vogone: Fix appearance of suppress messages at Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/149467 (https://bugzilla.wikimedia.org/56380) [19:54:30] 3MediaWiki / 3Unit tests: LanguageTest test for uppercase input fails - 10https://bugzilla.wikimedia.org/67918 (10Nemo) [19:54:37] (03CR) 10Scott-linder: "I don't have the exact figure on me, but a few dozen which are used often and quite a few more that are potentially unused but included." [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/147991 (owner: 10Scott-linder) [19:56:15] 3MediaWiki extensions / 3Math: Function: MediaWikiTestCase::resetDB Error: 1146 Table 'wiki.unittest_math' doesn't exist () - 10https://bugzilla.wikimedia.org/68628 (10Nemo) 3NEW p:3Unprio s:3normal a:3None With http://paste.debian.net/111811/ : vagrant@nemobis:/srv/vagrant/mediawiki/tests/phpunit$... [19:57:08] (03PS4) 10Vogone: Fix appearance of suppress messages at Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/149467 (https://bugzilla.wikimedia.org/56380) [20:02:22] (03PS2) 10Aaron Schulz: Factored out JobRunnerPipeline and added curl dispatcher support [services/jobrunner] - 10https://gerrit.wikimedia.org/r/149216 [20:03:51] (03PS1) 10Aaron Schulz: Removed use of cache in JobQueueFederated pop() method [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/149583 [20:04:54] (03CR) 10Scott-linder: "Again, I respect your security concerns (I'm glad to see the maintainer of the extension we're using is dedicated to security!), but I bel" [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/147991 (owner: 10Scott-linder) [20:10:01] (03CR) 10Bartosz Dziewoński: "I submitted a WMF config change: https://gerrit.wikimedia.org/r/149584" [core] - 10https://gerrit.wikimedia.org/r/87649 (https://bugzilla.wikimedia.org/5645) (owner: 10TTO) [20:15:26] (03CR) 10Nemo bis: "I'm confused. The commit message here says the signature button is only removed on content namespaces (that is, only ns0 on most wikis); h" [core] - 10https://gerrit.wikimedia.org/r/87649 (https://bugzilla.wikimedia.org/5645) (owner: 10TTO) [20:17:22] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I think that's a leftover from a previous version of this patch, which indeed used the logic for content namespaces." [core] - 10https://gerrit.wikimedia.org/r/87649 (https://bugzilla.wikimedia.org/5645) (owner: 10TTO) [20:18:22] (03CR) 10Bartosz Dziewoński: "I suppose someone should email the ambassadors list now and try to get this finished (I could be that someone, if necessary, but maybe the" [core] - 10https://gerrit.wikimedia.org/r/87649 (https://bugzilla.wikimedia.org/5645) (owner: 10TTO) [20:19:44] (03CR) 10Umherirrender: "Just an idea: Each page with a NEWSECTIONLINK needs also a signature, because that means in the most cases that a discussion can be starte" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/87649 (https://bugzilla.wikimedia.org/5645) (owner: 10TTO) [20:20:06] (03Abandoned) 10Florianschmidtwelzow: Add simple unit tests [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/143623 (owner: 10Florianschmidtwelzow) [20:20:33] (03CR) 10Nemo bis: [C: 04-1] "I think doing content namespaces only makes more sense." [core] - 10https://gerrit.wikimedia.org/r/87649 (https://bugzilla.wikimedia.org/5645) (owner: 10TTO) [20:25:42] Nemo_bis: i don't think merging these two ideas into one makes sense [20:25:55] Nemo_bis: being a non-content namespace doesn't imply requiring (or even allowing) signatures, e.g. in Help: namespace [20:26:24] being a content namespace doesn't imply not allowing them, e.g. for the "classic" wikis mentioned in the patch, or Meta like you said yourself [20:33:41] (03CR) 10Nemo bis: "I agree that where a __NEWSECTIONLINK__ is found the page is probably a discussion: but this can happen in any namespace. We can't really " [core] - 10https://gerrit.wikimedia.org/r/87649 (https://bugzilla.wikimedia.org/5645) (owner: 10TTO) [20:35:00] (03CR) 10Nemo bis: "Hm, it's better if we discuss this on bug 5645; here the commit message and the code need to be reconciled." [core] - 10https://gerrit.wikimedia.org/r/87649 (https://bugzilla.wikimedia.org/5645) (owner: 10TTO) [20:38:00] 3MediaWiki / 3Page editing: Hide signature button from edit toolbar in main namespace - 10https://bugzilla.wikimedia.org/5645#c18 (10Nemo) (In reply to Derk-Jan Hartman from comment #17) > Would it not be better to have the visibility of the signature button depend > on something that reflects: isTalkPage()... [20:44:02] Nemo_bis: eh, why are you making my life more difficult :( [20:58:01] 3MediaWiki-Vagrant: browsertests: Error: Working directory '/srv/browsertests/tests/browser' does not exist (and others) - 10https://bugzilla.wikimedia.org/68625#c2 (10Bryan Davis) p:5Unprio>3Normal a:5Ori Livneh>3Dan Duvall The qa/browsertests repository has been emptied of content -- https://github.c... [21:03:22] MatmaRex: how so, I'm making it easier by highlighting pain points which would bite ;) [21:04:04] I was convinced by the commit message that we were doing something entirely different [21:04:31] "The only property that tells us something meaningful here is whether a namespace is considered a content namespace" it tells us something, i guess, but not a whole lot [21:04:41] having a dedicated setting would tell us more [21:05:10] i've envisioned using the same setting for all wikitext editors, and just depending on content namespaces doesn't really cut it in that case [21:05:26] (in particular in the case of VisualEditor, which currently doesn't support signatures, but i'd like it to) [21:05:51] (03PS5) 10Vogone: Fix appearance of suppress messages at Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/149467 (https://bugzilla.wikimedia.org/56380) [21:05:53] 3MediaWiki extensions / 3Math: Function: MediaWikiTestCase::resetDB Error: 1146 Table 'wiki.unittest_math' doesn't exist () - 10https://bugzilla.wikimedia.org/68628#c1 (10Antoine "hashar" Musso) 5NEW>3RESO/DUP This is a duplicate of bug 67148 (which has a terrible subject :D ). *** This bug has been mar... [21:05:53] 3MediaWiki extensions / 3Math: Math tests dies when run with the Echo extensions - 10https://bugzilla.wikimedia.org/67148#c11 (10Antoine "hashar" Musso) *** Bug 68628 has been marked as a duplicate of this bug. *** [21:05:54] (see the dependent bugs) [21:06:42] If you think not even content namespace tells something, we can as well not do anything :) [21:07:30] (by default, that is) [21:08:45] (03PS6) 10Vogone: Fix appearance of suppress messages at Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/149467 (https://bugzilla.wikimedia.org/56380) [21:09:56] Nemo_bis: that's what the patch does, by default? the signature button is only in talk namespaces [21:29:13] 3MediaWiki extensions / 3Translate: Fatal error: Call to a member function getMessage() on a non-object in /mediawiki/extensions/Translate/tag/TranslatablePage.php on line 253 - 10https://bugzilla.wikimedia.org/67295#c4 (10Nemo) Created attachment 16041 --> https://bugzilla.wikimedia.org/attachment.cgi?id=... [21:29:38] MatmaRex: CONTENT [21:29:41] not subject [21:30:21] …i am lost [21:30:26] or perhaps you are [21:30:30] but at least one of us is [21:30:35] because i don't understand [21:31:02] Subject namespace doesn't tell us anything. You say content doesn't, either. Then we never know anything and we should never disable signature by default. :) [21:31:49] IMHO content namespace is likely enough not to need signatures. But we could as well just disable it via configuration on Wikimedia projects and be done with it [21:35:25] (03CR) 10Helder.wiki: "There is a discussion about this on" [core] - 10https://gerrit.wikimedia.org/r/144870 (https://bugzilla.wikimedia.org/50449) (owner: 10Jackmcbarn) [21:42:50] 3Wikimedia / 3Bugzilla: EventLogging is a MediaWiki extension - 10https://bugzilla.wikimedia.org/68630 (10Nemo) 3NEW p:3Unprio s:3normal a:3None EventLogging is no more in the MediaWiki extensions product, but it's still a MediaWiki extension. The current description "Framework for logging events fro... [21:48:15] 3Wikimedia / 3Bugzilla: EventLogging is a MediaWiki extension - 10https://bugzilla.wikimedia.org/68630#c1 (10Ori Livneh) 5NEW>3RESO/FIX Sure, if you think that helps discovery. [21:50:44] Nemo_bis: man, you brought up the example of a wiki that needs signatures in content namespace :/ [21:52:01] So? [21:52:13] so you're contradicting yourself a bit? [21:52:18] anyway [21:52:26] I don't see how [21:52:51] this conversation is going nowhere, let's restart [21:53:13] The contradiction is rather saying that a broad set of namespaces are ok to mess up with, while a subset of those are not [21:53:45] restarttttttt [21:53:49] Nemo_bis: i'm doing this because someone asked for a VE plugin that implements signatures, i made one, and now james and i want to put the functionality in VE itself - however, having a sane way to *whitelist* *namespaces* that need signatures is a prerequisite for this (VE is not supposed to offer signatures *by default*) [21:54:24] implementing such a way in VE itself would be silly, so i want one in core, and this patch as written happens to fit very well and sounds like a good idea in general, fixing an old bug [21:54:30] I understood that. I never said anything about the whitelist [21:54:39] your idea, as i understand it, doesn't fit this at all [21:54:43] Why [21:54:45] if it does, enlighten me [21:55:04] "My idea" is what the commit message still states the patch does [21:55:18] enabling signatures everywhere but content namespaces is blacklisting, therefore it's out [21:55:39] therefore it's not useful for my particular use-case, to be precise [21:56:10] We're not enabling anything, signatures are already enabled everywhere [21:57:05] So if I understand correctly you want to purposefully disable signatures on a namespace where you know they're needed, so that people are forced to whitelist them in config for core, so that VisualEditor can recycle that information? [21:58:32] apart from the part where you assume that i have evil intentions, yes; i'm not aware of any such namespaces other than NS_PROJECT, and main on some "planning" wikis like meta and wikimaniawikis [21:59:18] (that fact that we're putting discussions in non-discussion namespaces is a sad mistake on that past that we can't fix now) [21:59:43] (for some definitions of 'we' and 'can', at least) [22:00:05] (03PS1) 10Umherirrender: Allow maxlength attribute on HTMLSelectAndOtherField [core] - 10https://gerrit.wikimedia.org/r/149590 [22:02:33] (03CR) 10Umherirrender: "I added this javascript also to HTMLSelectAndOther with I5c164b41ab047e7ecf9d92db6eddcc980e2db048, but that is only used by block. The oth" [core] - 10https://gerrit.wikimedia.org/r/135197 (https://bugzilla.wikimedia.org/34467) (owner: 10Umherirrender) [22:02:38] It's not a sad mistake of the past, it's just how most wikis work. Strict namespace separation is something phase3 introducted [22:03:31] Anyway, I still don't understand what's the problem. You can ignore the new whitelist config on non-content namespaces, and still use it for VisualEditor [22:03:52] Nemo_bis: in other words, it seems to me that the functionality i require is a superset of the functionality you require (or what the bug asks for). it also seems reasonable that we should just implement this superset, instead of having two implementations for the two overlapping subsets [22:04:20] So: disable signature button in content namespaces; allow to override that by config; set the config even in some non-content namespaces for Wikimedia wikis; use that in VisualEditor [22:04:38] Two implementations? O_o [22:05:31] eh, fallback chains like this only serve to make it harder to figure out where the config is coming from; i also see no sane way of combining the blacklist and whitelist approaches (it probably *can* be done, just not in a sane way) [22:05:43] Sigh. If only you hadn't convinced me that what the commit stated it was doing was right... I didn't even want to look at this discussion [22:05:53] two implementations indeed, one in core for the core editor, one in VE for the VE editor [22:06:07] I'm proposing no blacklist [22:06:17] yes you are! D: [22:06:22] It's not out fault if the VE's editor default is the opposite of core's [22:06:28] "disable signature button in content namespaces" [22:06:33] this is the very definition of a blacklist [22:06:38] arrrrrrgh, please stop with the pings :| [22:06:40] *all* namespaces, *but* content namespaces [22:07:09] you don't need signatures in the Help: namespace, for chrissakes [22:07:29] How so, we have discussions in Help namespace on it.wiki [22:08:05] (With a huge banner that warns people not to use VisualEditor there) [22:08:07] are you going to tell me you also have discussion in the File: namespace? i wouldn't be very surprised at this point, heh [22:08:40] Not in any wiki I know, but there are tens of thousands I don't know [22:08:53] MatmaRex: you need the ~~~~ for deletion tags there [22:09:07] Vogone: that's retarded [22:09:08] True that [22:09:12] dunno+ [22:09:17] literally brain-damaged [22:09:54] what other namespaces do we have… [22:10:01] well, you're just going to tell me you need deletion tags in them [22:10:01] -1 and -2! [22:10:05] why am i making the effort [22:10:15] SURE WE NEED SIGNATURES IN MEDIAWIKI:! [22:10:40] We have a helpdesk in the Help-namespace. [22:10:46] sjoerddebruin: many do [22:11:09] You're approaching this matter from the wrong side IMHO. You need a reason to disable signatures, not to leave them enabled as they always were [22:11:38] (03CR) 10Bartosz Dziewoński: "I have become disillusioned. Of course this is never going to be pushed through. Sorry if I made you think otherwise." [core] - 10https://gerrit.wikimedia.org/r/87649 (https://bugzilla.wikimedia.org/5645) (owner: 10TTO) [22:12:01] There is always something like a abuse filter to avoid signatures in some namespaces. [22:12:11] If you make a terminological problem out of it, we can rephrase [22:12:43] (03CR) 10Swalling: [C: 031] Make profile icon gender neutral and remove from login link in Vector [core] - 10https://gerrit.wikimedia.org/r/146979 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [22:12:54] We can "blacklist" content namespaces from signature button by default, and add a configuration to remove a namespace from the blacklist if present. [22:13:01] Bah. Misclick on submit. Why do we even show this bs. [22:13:20] 3MediaWiki / 3Page editing: Hide signature button from edit toolbar in main namespace - 10https://bugzilla.wikimedia.org/5645 (10Bartosz Dziewoński) [22:13:49] meh [22:13:54] Then for safety Wikimedia wikis will remove NS_PROJECT, NS_HELP and whatever from the blacklist, even if by default they're not in it. And VisualEditor can use this override [22:13:56] i just stopped caring [22:14:11] discuss this with somebody more determined than me [22:14:59] :/ this is just what you had stated you were doing [22:16:28] (03CR) 10Nemo bis: "Not really, it just needs to do what the commit message says it does" [core] - 10https://gerrit.wikimedia.org/r/87649 (https://bugzilla.wikimedia.org/5645) (owner: 10TTO) [22:31:12] why would sigs be mandatory? that's a wmf-specific thing [22:31:34] you can just tell who posted what looking at action=history [22:35:46] withoutaname: define mandatory? [22:38:02] if you insist on not using sigs when you post on a discussion forum, you can get banned from wikipedia [22:38:25] based on the commit msg from https://gerrit.wikimedia.org/r/#/c/87649/ it sounds like you're enforcing this [22:42:19] 3MediaWiki-Vagrant: luasandbox.so: undefined symbol: zend_objects_destroy_object - 10https://bugzilla.wikimedia.org/67831#c7 (10Ori Livneh) 5NEW>3RESO/FIX a:5Ori Livneh>3Bryan Davis Fixed by Bryan in I986205e0c [22:44:27] Yes, "require" is not a good word [22:48:20] (03PS15) 10Nemo bis: Hide edit toolbar Signature button in content namespaces by default [core] - 10https://gerrit.wikimedia.org/r/87649 (https://bugzilla.wikimedia.org/5645) (owner: 10TTO) [22:49:00] (03CR) 10Nemo bis: "Rephrased to clarify core is not going to "require" signatures anywhere, per Withoutaname." [core] - 10https://gerrit.wikimedia.org/r/87649 (https://bugzilla.wikimedia.org/5645) (owner: 10TTO) [22:49:47] (03PS1) 10Jforrester: Rename to "CiteThisPage" and make Special:CiteThisPage the primary location [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/149592 [22:49:48] hm, thanks [22:50:03] so this only controls when the sig button appears [22:52:21] well, maybe in a few years time people will want page-specific controls on the sig button, like what happened with the robot policy settings [22:52:45] so you would end up with a mix of namespace-specific and page-specific control settings [22:55:00] duh: you know the patch you submitted about requestcontext [23:04:46] (03CR) 10TTO: "This looks like it ought to be a very easy bug to fix, but it's ended up being quite frustrating. I never thought it would take >15 patch " [core] - 10https://gerrit.wikimedia.org/r/87649 (https://bugzilla.wikimedia.org/5645) (owner: 10TTO) [23:05:48] 3MediaWiki / 3General/Unknown: slow query: INSERT /* JobQueueDB::doBatchPush 127.0.0.1 */ INTO `unittest_job` etc. - 10https://bugzilla.wikimedia.org/68620 (10Nemo) [23:10:01] 3MediaWiki / 3Page editing: Hide signature button from edit toolbar in main namespace - 10https://bugzilla.wikimedia.org/5645#c19 (10This, that and the other (TTO)) I think we have three options here so far: * Show signature button in all pages in non-content namespaces (as defined by $wgContentNamespac... [23:11:15] 3MediaWiki extensions / 3Translate: Fatal error: Call to a member function getMessage() on a non-object in /mediawiki/extensions/Translate/tag/TranslatablePage.php on line 253 - 10https://bugzilla.wikimedia.org/67295#c5 (10Nemo) I confirm it disappeared after disabling the cirrussearch role. [23:14:05] (03PS1) 10Jforrester: Remove Special:Cite, now moved to its own repository [extensions/Cite] - 10https://gerrit.wikimedia.org/r/149593 [23:17:03] (03PS1) 10BryanDavis: Set 'path' in $wgExtensionCredits [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/149594 [23:18:00] (03PS2) 10Jforrester: Remove Special:Cite, now moved to its own repository [extensions/Cite] - 10https://gerrit.wikimedia.org/r/149593 [23:18:02] (03PS3) 10Jforrester: Add license details and give credit to more authors (based on git shortlog) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/145038 [23:18:04] (03CR) 10jenkins-bot: [V: 04-1] Remove Special:Cite, now moved to its own repository [extensions/Cite] - 10https://gerrit.wikimedia.org/r/149593 (owner: 10Jforrester) [23:18:24] (03PS16) 10TTO: Hide edit toolbar Signature button in non-discussion namespaces [core] - 10https://gerrit.wikimedia.org/r/87649 (https://bugzilla.wikimedia.org/5645) [23:20:40] (03PS3) 10Jforrester: Remove Special:Cite, now moved to its own repository [extensions/Cite] - 10https://gerrit.wikimedia.org/r/149593 [23:25:37] 3MediaWiki extensions / 3UrlShortener: Exception: .agora-field-styling is undefined: failed at `.agora-field-styling();` - 10https://bugzilla.wikimedia.org/68634 (10Nemo) 3NEW p:3Unprio s:3normal a:3None 6) /srv/vagrant/mediawiki/extensions/UrlShortener/less/ext.urlShortener.special.less in the "ext.... [23:29:47] 3MediaWiki extensions / 3Translate: No enabled connection [Called from CirrusSearch\ElasticsearchIntermediary::failure in /srv/vagrant/mediawiki/extensions/CirrusSearch/include s/ElasticsearchIntermediary.php at line 97] - 10https://bugzilla.wikimedia.org/68636 (10Nemo) 3NEW p:3Unprio s:3normal a:3Non... [23:32:31] 3MediaWiki extensions / 3UrlShortener: Exception: .agora-field-styling is undefined: failed at `.agora-field-styling();` - 10https://bugzilla.wikimedia.org/68634#c1 (10Bartosz Dziewoński) Hmph, somebody used that? It was undocumented and not intended for public consumption, Jon and I removed it a few weeks a... [23:34:30] (03CR) 10SPQRobin: [C: 032] Fix appearance of suppress messages at Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/149467 (https://bugzilla.wikimedia.org/56380) (owner: 10Vogone) [23:34:46] 3MediaWiki extensions / 3CLDR: CLDR breaks core timestamp tests - 10https://bugzilla.wikimedia.org/55886#c5 (10Nemo) Just got this as well. 1) MWTimestampTest::testHumanTimestamp with data set #0 ('20111231170000', '20120101000000', 'Offset|0', 'mdy', 'Yesterday at 17:00', '"Yesterday" across years') "Yeste... [23:37:00] (03Merged) 10jenkins-bot: Fix appearance of suppress messages at Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/149467 (https://bugzilla.wikimedia.org/56380) (owner: 10Vogone) [23:38:25] (03CR) 10Bartosz Dziewoński: [C: 032] Set 'path' in $wgExtensionCredits [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/149594 (owner: 10BryanDavis) [23:38:30] (03Merged) 10jenkins-bot: Set 'path' in $wgExtensionCredits [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/149594 (owner: 10BryanDavis) [23:39:07] (03PS1) 10Jforrester: Update VisualEditor to I31a9a359e [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/149595 [23:39:46] 3MediaWiki / 3Unit tests: Something in unit tests is doing something funky with the session - 10https://bugzilla.wikimedia.org/67656#c5 (10Nemo) Same here. Can it be related to running way too many tests at once (bug 67216 comment 8)? :-) PHP Warning: Unknown: The session id is too long or contains illegal... [23:40:58] (03PS1) 10Jforrester: Update VisualEditor to I31a9a359e [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/149596 [23:43:51] 3MediaWiki extensions / 3ProofreadPage: phpunit: SKIPPED: djvu binaries do not exist or are not executable - 10https://bugzilla.wikimedia.org/68638 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Unit tests on a labs-vagrant instance with http://paste.debian.net/111811/ are skipped with this error, even th... [23:51:20] 3MediaWiki-Vagrant: Flow: phpunit SKIPPED: Parsoid not enabled - 10https://bugzilla.wikimedia.org/68640 (10Nemo) 3NEW p:3Unprio s:3enhanc a:3Ori Livneh 20) Flow\Tests\LinksTableTest::testGetReferencesFromRevisionContent with data set #0 ('[[Foo]]', array(array('wiki', 'link', 'Foo'))) Parsoid not e... [23:53:34] 3MediaWiki extensions / 3Translate: Skipped PageTranslationParserTest::testParsing: Extended validation not yet implemented - 10https://bugzilla.wikimedia.org/68641 (10Nemo) 3NEW p:3Unprio s:3enhanc a:3None Enhancement to unit tests worth doing? 19) PageTranslationParserTest::testParsing with data s... [23:57:15] 3MediaWiki extensions / 3ProofreadPage: phpunit: SKIPPED: djvu binaries do not exist or are not executable - 10https://bugzilla.wikimedia.org/68638#c1 (10Nemo) $ ddjvu --help DDJVU --- DjVuLibre-3.5.25 DjVu decompression utility $ djvudump DJVUDUMP --- DjVuLibre-3.5.25 Describes DjVu and IFF85 files $ djvuto...