[00:01:28] (03PS1) 10Ori.livneh: Specify unit in doc-block for $wgHTTPTimeout and $wgAsyncHTTPTimeout [core] - 10https://gerrit.wikimedia.org/r/148895 [00:01:39] (03CR) 10Nemo bis: [C: 04-1] "The qqq becomes nevertheless insufficiently clear after this change. Special:MyLanguage is useless for the "en" locale, hence it can only " [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148881 (owner: 10Kaldari) [00:02:03] (03CR) 10EBernhardson: [C: 04-1] "one unused variable jenkins would have picked up" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148679 (owner: 10Matthias Mullie) [00:02:56] (03PS6) 10EBernhardson: Refactor querymap-related stuff [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148679 (owner: 10Matthias Mullie) [00:03:34] (03CR) 10Chad: [C: 032] Specify unit in doc-block for $wgHTTPTimeout and $wgAsyncHTTPTimeout [core] - 10https://gerrit.wikimedia.org/r/148895 (owner: 10Ori.livneh) [00:04:44] (03CR) 10EBernhardson: [C: 032] Refactor querymap-related stuff [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148679 (owner: 10Matthias Mullie) [00:05:40] (03Merged) 10jenkins-bot: Refactor querymap-related stuff [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148679 (owner: 10Matthias Mullie) [00:06:10] ori, MaxSem now I'm getting this: [00:06:11] $ tail /var/log/hhvm/error.log [00:06:11] \nWarning: failed to connect to 127.0.0.1 [111]: Connection refused [00:06:11] \nWarning: Failed connecting to redis server at 127.0.0.1: Connection refused [00:06:11] \nWarning: failed to connect to 127.0.0.1 [111]: Connection refused [00:06:11] \nWarning: Failed connecting to redis server at 127.0.0.1: Connection refused [00:06:13] \nWarning: failed to connect to 127.0.0.1 [111]: Connection refused [00:06:15] \nWarning: Failed connecting to redis server at 127.0.0.1: Connection refused [00:06:17] \nWarning: failed to connect to 127.0.0.1 [111]: Connection refused [00:06:19] \nWarning: Failed connecting to redis server at 127.0.0.1: Connection refused [00:06:21] \nWarning: failed to connect to 127.0.0.1 [111]: Connection refused [00:06:23] \nWarning: Failed connecting to redis server at 127.0.0.1: Connection refused [00:06:34] are you guys using default memory settings for your VM? [00:06:37] i'm glad you included all ten lines [00:06:53] (03Merged) 10jenkins-bot: Specify unit in doc-block for $wgHTTPTimeout and $wgAsyncHTTPTimeout [core] - 10https://gerrit.wikimedia.org/r/148895 (owner: 10Ori.livneh) [00:07:13] jgonera: what is the output of 'service redis-server status' and 'redis-cli' ? [00:07:31] (03PS4) 10EBernhardson: Convert textareas into editor objects [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148682 (owner: 10Matthias Mullie) [00:07:35] yeah, you can see how persistent that thing is [00:07:53] $ service redis-server status [00:07:53] redis-server is not running [00:07:55] (03CR) 10EBernhardson: [C: 032] "rebase on finalized parent and reapply john +2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148682 (owner: 10Matthias Mullie) [00:08:05] 3MediaWiki extensions / 3Scribunto: HHVM crash loading San Francisco page - 10https://bugzilla.wikimedia.org/68196#c13 (10Tim Starling) Created attachment 16028 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16028&action=edit Reduced test case I used a recursive table "a = {a,0}" to force Lua to do... [00:08:08] jgonera: so start it? 'sudo start redis-server'? [00:08:08] $ redis-cli [00:08:09] 127.0.0.1:6379> [00:08:40] the question is why isn't it running after vagrant reload [00:08:51] or is it running, because redis-cli connected to something? [00:09:20] (03Merged) 10jenkins-bot: Convert textareas into editor objects [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148682 (owner: 10Matthias Mullie) [00:09:21] anything interesting in 'sudo tail /var/log/upstart/redis-server.log'? [00:09:40] $ sudo tail /var/log/upstart/redis-server.log [00:09:40] tail: cannot open ‘/var/log/upstart/redis-server.log’ for reading: No such file or directory [00:09:49] ok, I gotta go, I'll fight with this more tomorrow [00:12:01] (03PS3) 10BryanDavis: Enable hhvm.debug.server_error_message debug option [vagrant] - 10https://gerrit.wikimedia.org/r/148745 (owner: 10EBernhardson) [00:12:08] (03CR) 10BryanDavis: [C: 032] Enable hhvm.debug.server_error_message debug option [vagrant] - 10https://gerrit.wikimedia.org/r/148745 (owner: 10EBernhardson) [00:12:14] (03Merged) 10jenkins-bot: Enable hhvm.debug.server_error_message debug option [vagrant] - 10https://gerrit.wikimedia.org/r/148745 (owner: 10EBernhardson) [00:12:27] (03PS1) 10MaxSem: @group Math where it's missing [extensions/Math] - 10https://gerrit.wikimedia.org/r/148899 [00:13:26] (03CR) 10Neilk: "To be clearer: the issue with Flickr uploads only happens when we are only uploading from Flickr. Amazingly if you mix it with a non-Flick" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [00:16:53] 3MediaWiki / 3Internationalization: Consider using content language for "html lang", rather than interface language - 10https://bugzilla.wikimedia.org/68490 (10Nemo) 3NEW p:3Unprio s:3enhanc a:3None 0) Open Chromium and, in one tab, chrome://translate-internals/#detection-logs 1) Visit https://fi.wik... [00:17:24] (03CR) 10Legoktm: [C: 04-1] "Mainly code quality stuff, I haven't actually tested it yet." (0315 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 (owner: 10Bsitu) [00:18:53] (03PS2) 10BryanDavis: hhvm: Update dynamic extension path and keep up with new releases [vagrant] - 10https://gerrit.wikimedia.org/r/148835 [00:20:08] (03PS1) 10Aaron Schulz: Reject cache with future MW_USER_VERSION versions [core] - 10https://gerrit.wikimedia.org/r/148901 [00:20:12] ^d: [00:20:25] (03CR) 10Kaldari: "Nemo_bis: Do you have an example of the kind of instructions that would be useful for this? I tried to find an existing one, but the other" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148881 (owner: 10Kaldari) [00:20:43] <^d> AaronSchulz: makes sense. [00:21:11] * AaronSchulz was testing the password hash thingy [00:24:05] (03PS1) 10Withoutaname: Remove unused License/Licenses class [core] - 10https://gerrit.wikimedia.org/r/148902 [00:27:50] (03PS1) 10Chad: Clean up user version constants [core] - 10https://gerrit.wikimedia.org/r/148905 [00:28:02] (03CR) 10Chad: [C: 032] Reject cache with future MW_USER_VERSION versions [core] - 10https://gerrit.wikimedia.org/r/148901 (owner: 10Aaron Schulz) [00:28:10] (03CR) 10Nemo bis: "No need to explain how Special:MyLanguage works, just what you want the translators to do. For instance the en locale could have a link wi" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148881 (owner: 10Kaldari) [00:28:12] <^d> AaronSchulz: See my child ^ [00:30:29] (03Abandoned) 10Jforrester: Syncronize VisualEditor: 2c390f4..1be1c46 [extensions] - 10https://gerrit.wikimedia.org/r/146964 (owner: 10Jenkins-mwext-sync) [00:33:27] (03Merged) 10jenkins-bot: Reject cache with future MW_USER_VERSION versions [core] - 10https://gerrit.wikimedia.org/r/148901 (owner: 10Aaron Schulz) [00:34:30] (03PS1) 10Shirayuki: i18n: translation tweaks [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148909 [00:41:59] (03PS7) 10Bsitu: Break notifications into alert and message sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 [00:42:28] (03CR) 10Bsitu: [C: 04-1] "Haven't addressed the feedback yet" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 (owner: 10Bsitu) [00:43:10] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (a7ce4d48d9) [core] - 10https://gerrit.wikimedia.org/r/148912 [00:44:20] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (a7ce4d48d9) [core] - 10https://gerrit.wikimedia.org/r/148912 (owner: 10Jforrester) [00:47:40] (03PS1) 10Chad: Throw exception in importDump instead of dumping a random backtrace and erroring [core] - 10https://gerrit.wikimedia.org/r/148915 [00:48:41] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (a7ce4d48d9) [core] - 10https://gerrit.wikimedia.org/r/148912 (owner: 10Jforrester) [00:50:05] 3MediaWiki extensions / 3Cite: Cite: Add namespace detection for automatically generated reference list - 10https://bugzilla.wikimedia.org/68324#c2 (10Gadget850) Added namespace detection to 'MediaWiki:Cite error refs without references category' on the test wiki and enwiki. The automatic reference list on u... [00:55:08] (03PS1) 10Chad: Further User define cleanups [core] - 10https://gerrit.wikimedia.org/r/148916 [00:59:23] 3MediaWiki-Vagrant: HHVM Failed Assertion: assertion `false && "Unsupported DataType"' failed. - 10https://bugzilla.wikimedia.org/68491 (10Bryan Davis) 3NEW p:3Unprio s:3normal a:3Ori Livneh Created attachment 16029 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16029&action=edit Full stacktrac... [01:01:37] (03CR) 10Jamesmontalvo3: "Override is specified for categories (and pages) so the two categories won't affect each other. Specifying an override for a namespace has" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [01:02:10] (03PS1) 10BryanDavis: Add retry=0 to ProxyPass directives [vagrant] - 10https://gerrit.wikimedia.org/r/148919 [01:03:10] (03CR) 10Yurik: [C: 032] Fix deprecated of ApiQuery::setGeneratorContinue [core] - 10https://gerrit.wikimedia.org/r/148841 (owner: 10Umherirrender) [01:03:45] bd808|BUFFER: question about multiwiki+vagrant, will all extensions added via mediawiki::extension{ 'Foo' } automatically be loaded on all wikis? [01:06:19] looks like not... [01:06:53] (03Merged) 10jenkins-bot: Fix deprecated of ApiQuery::setGeneratorContinue [core] - 10https://gerrit.wikimedia.org/r/148841 (owner: 10Umherirrender) [01:11:45] (03PS1) 10Legoktm: Add GlobalCssJs role [vagrant] - 10https://gerrit.wikimedia.org/r/148920 [01:15:40] 3MediaWiki / 3General/Unknown: WebRequest: remove magic_quotes cruft - 10https://bugzilla.wikimedia.org/11558 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Chad H. [01:21:45] (03PS1) 10Legoktm: SpecialVersion: Handle Closures in $wgHooks nicer [core] - 10https://gerrit.wikimedia.org/r/148922 [01:50:51] 3MediaWiki extensions / 3WikibaseQueryEngine: performance review of WikibaseQueryEngine - 10https://bugzilla.wikimedia.org/67535#c3 (10Jeroen De Dauw) Re update script: we are aware of this. The CLI can already dump the schema creation code for exactly that purpouse [01:52:21] <^demon|away> legoktm: 11558 fixed :D [01:52:45] :DDD [01:53:37] 3MediaWiki extensions / 3WikibaseQueryEngine: performance review of WikibaseQueryEngine - 10https://bugzilla.wikimedia.org/67535#c4 (10Jeroen De Dauw) Note there is a test in the performance group that is excluded by default. I used this to get a quick idea of how quick inserts are, at least when there is li... [02:01:39] 3MediaWiki / 3Skin and page rendering: Images with border parameter should display captions - 10https://bugzilla.wikimedia.org/68468#c9 (10Bawolff (Brian Wolff)) (In reply to Quiddity from comment #8) > What are the options here, technically? > > 1) Create a new parameter for "|thumb" images, that adds a bo... [02:02:54] (03CR) 10Legoktm: "I'm not sure how to access the other wiki, going to http://globalcssjstest.wiki.wmftest.net/ doesn't work for me." [vagrant] - 10https://gerrit.wikimedia.org/r/148920 (owner: 10Legoktm) [02:04:48] (03CR) 10Legoktm: "The extension works fine on the main wiki though." [vagrant] - 10https://gerrit.wikimedia.org/r/148920 (owner: 10Legoktm) [02:07:35] (03CR) 10Brian Wolff: [C: 032] "Thanks for the patch" [core] - 10https://gerrit.wikimedia.org/r/146067 (https://bugzilla.wikimedia.org/36964) (owner: 10Rohan013) [02:11:36] 3MediaWiki extensions / 3Cite: Cite: Use of #tag:references with a group causes a footnote numbering issue - 10https://bugzilla.wikimedia.org/46140#c5 (10Gadget850) The problem occurs because the list defined references are missing the group: 12 3MediaWiki / 3Skin and page rendering: Images with border parameter should display captions - 10https://bugzilla.wikimedia.org/68468#c10 (10James Forrester) (In reply to Bawolff (Brian Wolff) from comment #9) > (In reply to Quiddity from comment #8) > > What are the options here, technically? > > > > 1) Cre... [02:12:26] (03CR) 10Legoktm: "Minor code quality thing. Looks fine otherwise." (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/147020 (https://bugzilla.wikimedia.org/67995) (owner: 10BryanDavis) [02:12:32] (03Merged) 10jenkins-bot: Fix off-by-one error in the "previous 200" link in category listings with until=param [core] - 10https://gerrit.wikimedia.org/r/146067 (https://bugzilla.wikimedia.org/36964) (owner: 10Rohan013) [02:14:30] (03PS2) 10Legoktm: Make Special:FilePath redirect to Special:Redirect/file [core] - 10https://gerrit.wikimedia.org/r/142144 (https://bugzilla.wikimedia.org/66980) (owner: 10Brian Wolff) [02:14:38] (03CR) 10Legoktm: [C: 032] Make Special:FilePath redirect to Special:Redirect/file [core] - 10https://gerrit.wikimedia.org/r/142144 (https://bugzilla.wikimedia.org/66980) (owner: 10Brian Wolff) [02:15:22] (03CR) 10Legoktm: "Why? :(" [core] - 10https://gerrit.wikimedia.org/r/140975 (owner: 10Brian Wolff) [02:19:37] (03Merged) 10jenkins-bot: Make Special:FilePath redirect to Special:Redirect/file [core] - 10https://gerrit.wikimedia.org/r/142144 (https://bugzilla.wikimedia.org/66980) (owner: 10Brian Wolff) [02:21:38] 3MediaWiki / 3Special pages: [Regression] Accessing plain Special:FilePath should result in an error - 10https://bugzilla.wikimedia.org/66980 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Bawolff (Brian Wolff) [02:22:36] 3MediaWiki extensions / 3Cite: Cite: Add namespace detection for automatically generated reference list - 10https://bugzilla.wikimedia.org/68324#c3 (10Gadget850) (In reply to Gadget850 from comment #2) > Added namespace detection to 'MediaWiki:Cite error refs without references > category' on the test wiki a... [02:26:23] (03PS2) 10Legoktm: Allow specifying a random page only in main namespace [core] - 10https://gerrit.wikimedia.org/r/140916 (https://bugzilla.wikimedia.org/46420) (owner: 10Brian Wolff) [02:26:31] (03CR) 10Legoktm: [C: 032] Allow specifying a random page only in main namespace [core] - 10https://gerrit.wikimedia.org/r/140916 (https://bugzilla.wikimedia.org/46420) (owner: 10Brian Wolff) [02:31:16] (03Merged) 10jenkins-bot: Allow specifying a random page only in main namespace [core] - 10https://gerrit.wikimedia.org/r/140916 (https://bugzilla.wikimedia.org/46420) (owner: 10Brian Wolff) [02:32:44] (03PS1) 10Withoutaname: Fix calls to DatabaseBase static functions [core] - 10https://gerrit.wikimedia.org/r/148939 [02:46:53] (03CR) 10Legoktm: [C: 04-1] "Needs rebase." (032 comments) [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/62026 (owner: 10Parent5446) [02:50:02] (03CR) 10Legoktm: [C: 04-1] "Looks fine, minor comment. Needs rebase though." (031 comment) [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/62027 (owner: 10Parent5446) [02:50:48] (03CR) 10Legoktm: Cleaned up workflow for fetching nodes to use Status. (031 comment) [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/62026 (owner: 10Parent5446) [03:03:38] (03CR) 10BryanDavis: Allow login with pre-rename username and password (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/147020 (https://bugzilla.wikimedia.org/67995) (owner: 10BryanDavis) [03:07:35] (03CR) 10Legoktm: Allow login with pre-rename username and password (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/147020 (https://bugzilla.wikimedia.org/67995) (owner: 10BryanDavis) [03:18:03] (03CR) 10Legoktm: [C: 04-1] "Should use LinkBatch for a performance boost." [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/148702 (owner: 10Wctaiwan) [03:22:06] 3MediaWiki / 3Special pages: Filter Meta userrights log by wiki and user - 10https://bugzilla.wikimedia.org/10545#c10 (10Alex Monk) 5PATC>3RESO/FIX Should be done now. [03:22:09] (03PS1) 10Cicalese: made compatible with SemanticTitle [extensions/TitleIcon] - 10https://gerrit.wikimedia.org/r/148943 [03:22:23] (03CR) 10Krinkle: [C: 031] commonElements: Import styling for from mediawiki.org [core] - 10https://gerrit.wikimedia.org/r/148397 (owner: 10Bartosz Dziewoński) [03:23:16] (03PS2) 10Cicalese: made compatible with SemanticTitle [extensions/TitleIcon] - 10https://gerrit.wikimedia.org/r/148943 [03:25:21] 3MediaWiki extensions / 3Scribunto: HHVM crash loading San Francisco page - 10https://bugzilla.wikimedia.org/68196#c14 (10Tim Starling) On hhvm.256.io, I have installed a LuaSandbox statically linked against Lua compiled as C++. With this build, the reduced test case exits cleanly with "Fatal error: unknown... [03:25:47] (03CR) 10Brian Wolff: [C: 04-1] "There's two main problems with the change. First of all, This query isn't very efficient:" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/148322 (https://bugzilla.wikimedia.org/12363) (owner: 10Rohan013) [03:26:47] (03CR) 10Krinkle: "Yep. I'm hereby waiving all my rights to the CSS code for the redesign I submitted to mediawiki.org at https://www.mediawiki.org/w/" [core] - 10https://gerrit.wikimedia.org/r/148397 (owner: 10Bartosz Dziewoński) [03:27:14] legoktm: I've permitted the entire known and unknown universe and every living creature in it to copy and distribute verbatim or modified copies of said work. [03:27:17] Is that enough :) [03:27:35] what about dead creatures??? [03:28:37] legoktm: Feel free to test it in court haha [03:30:17] :P [03:30:28] (03CR) 10Legoktm: [C: 032] commonElements: Import styling for from mediawiki.org [core] - 10https://gerrit.wikimedia.org/r/148397 (owner: 10Bartosz Dziewoński) [03:32:02] legoktm/Krinkle: What about the atoms in the work? [03:32:19] what does it mean for them to do that? :P [03:34:13] could someone please help me understand why requesting a site configuration change is better than modification of a site's mediawiki:common.js? [03:34:29] Risker: with just that info, probably for performance [03:34:33] what issue specifically? [03:34:39] (03Merged) 10jenkins-bot: commonElements: Import styling for from mediawiki.org [core] - 10https://gerrit.wikimedia.org/r/148397 (owner: 10Bartosz Dziewoński) [03:34:49] also Common.js doesn't run for users with JS disabled... [03:35:14] if it is a $wg config option, any JS is probably a hack [03:35:14] ahhh good point. I was looking for general principles and differences between the two. [03:35:56] Risker: It is discouraged to do that by principle. $wg are server configurations. They control whether code is executed and whether modules are loaded in the web browsers. [03:36:40] Risker: common.js executes inside your browser. if you disable a feauture there you basically first wait for the server to compute the feature, and for the web browser to load it all (and maybe even make part of it appear visually) only to then distroy it soon as it loads. [03:38:01] Plus, the server configuration can also influence things you can't control in javascript. E.g. destroying LiquidThreads via common.js on a wiki where that is enabled would leave you with an en empty page and no way to edit the talk page because it's controlled server side. [03:38:04] [03:38:17] this is extremely helpful. May I quote you on that, Krinkle? It is written in a way that even a non-developer will understand. [03:38:30] yes please [03:38:39] :) [03:38:45] I assume this might relate to enwiki "destroying" multi-media viewer recently? [03:38:59] (instead of asking for it to be disabled) [03:39:17] yes it is, but I knew there were some underlying reasons why enwiki was really messing up by doing it this way. [03:39:43] Risker: also, because they didn't just disable it by default. they prevented users who wanted it from re-enabling it for themselves [03:40:01] well, there is that issue too. It wasn't even a good hack. [03:40:35] in fairness, the person who closed the RFC misunderstood what "disable by default" meant and just closed it as "disable Media Viewer" [03:40:42] yeah. While this is not an official position (don't quote me on this/next), I would assume that if the community requested it, it would either have been disabled as requested (but with the understanding to further talk and figure out why it is bad and how it can be improved), or the foundation might decide for some reason it is best for users that it stay enabled. At which point bypassing that and doin [03:40:42] g it in javascript is silly, because the foundation obviously controls that too. [03:41:53] Hey, there is now a bot following anonymous edits from WMF IPs. It certainly would be unprofessional if say, someone were to start editing ludicrous articles from WMF IPs... [03:42:02] I always learn something when I ask a question here :) thanks very much folks! [03:42:08] https://twitter.com/valleyedits [03:42:24] oh for heaven's sake, neilk. [03:42:35] The entire server configuration is open source and editable in a wiki-page like fashion (see https://github.com/wikimedia/operations-mediawiki-config/tree/master/wmf-config). The only difference is that (a bit like FlaggedRevs) we obviously do review changes before they go live. [03:43:33] so the community could even write the so-called "patch" themselves and propose the edit via [[mw:Gerrit]] (like {{editprotected}} :D) [03:43:37] that is also a big advantage, Krinkle [03:43:49] improved quality of code [03:44:08] yeah, and avoids someone hacking the server! [03:44:27] (only mildly important by comparison, naturally :P) [03:44:42] the other big difference from PC/protection is that nobody's changes are automatically accepted, and nobody's supposed to manually accept anything of their own [03:48:33] (03PS3) 10BryanDavis: hhvm: Update dynamic extension path and keep up with new releases [vagrant] - 10https://gerrit.wikimedia.org/r/148835 [03:50:00] (03CR) 10BryanDavis: [C: 032] "Ori can revert the 'latest' bit if he wants but new vms are pretty broken without the ABI bump and old vms will be broken without it. :(" [vagrant] - 10https://gerrit.wikimedia.org/r/148835 (owner: 10BryanDavis) [03:50:05] (03Merged) 10jenkins-bot: hhvm: Update dynamic extension path and keep up with new releases [vagrant] - 10https://gerrit.wikimedia.org/r/148835 (owner: 10BryanDavis) [03:52:52] (03PS2) 10Wctaiwan: Handle redlinks and change placeholder [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/148702 [03:55:59] (03PS3) 10Wctaiwan: Handle redlinks and change placeholder [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/148702 [03:57:38] Risker: To be honest, I don't see what the "disable" vs "disable by default" dispute was about. I have trouble imagining the response would have been any different if the js that got added also added a checkbox to Special:Preferences [03:58:40] bawolff, you could be right, but that's not the situation we have [03:59:07] Like sure, if WMF didn't respond as it did I could see that being a big deal. But it seems like not really what the current controversy is about [03:59:20] what I want to present, though, is that as a general principle, making hacks to the common.js is deprecated and can cause significant harm [03:59:38] Risker: +1 [03:59:46] (Hi, by the way.) [03:59:51] hi ori! [03:59:58] will I see you in London? [04:00:30] yep! Glad to hear you're going too. [04:02:00] Well, developers add hacks occasionally if needed, but that's usually because it's not worth doing about it the "proper" way [04:02:43] when do we do that? [04:02:52] https://en.wikipedia.org/w/index.php?title=MediaWiki%3ACommon.js&diff=598186617&oldid=597587658 the "proper" way would have been to have the extension to do it, but that's not worth the amount of time it would take [04:03:17] yes, for temporary things [04:03:19] https://en.wikipedia.org/w/index.php?title=MediaWiki:Mobile.js&action=history has a bunch of examples [04:03:26] right, nothing permanent [04:03:48] legoktm: Devs. Adding hacks! For shame! [04:03:58] ahem abusefilterbypass ahem [04:04:09] * legoktm hides [04:04:24] jackmcbarn: did you see my $wgHooks hack? [04:04:40] the one where you ripped AbuseFilter's AbortMove hook out if the move failed? yes [04:04:45] i'd actually prefer that to the status quo [04:04:49] >.> [04:05:11] it will be a moot point soon, assuming hoo likes my proper fix [04:05:26] oh he was fine with it [04:05:34] * legoktm finds logs [04:05:49] my idea, yes, but he said if the implementation gets too complicated he'll -2 it [04:06:13] http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-dev/20140723.txt start with "hi hoo" [04:06:48] does the antecedent of your "it" refer to a different noun than my "it"? [04:07:54] uhhh, it might? :P [04:09:55] * jackmcbarn is still procrastinating writing his article to hopefully submit as a DYK [04:10:04] (03Abandoned) 10Chad: WIP: Remove less-than-useful API output formats [core] - 10https://gerrit.wikimedia.org/r/136490 (owner: 10Chad) [04:10:12] (03CR) 10BryanDavis: [C: 04-1] "Not introduced in this patch, but:" [vagrant] - 10https://gerrit.wikimedia.org/r/148874 (owner: 10EBernhardson) [04:11:26] (03PS1) 10Withoutaname: Make SearchDatabase abstract [core] - 10https://gerrit.wikimedia.org/r/148945 [04:17:57] (03CR) 10Legoktm: [C: 032] Handle redlinks and change placeholder [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/148702 (owner: 10Wctaiwan) [04:18:05] (03Merged) 10jenkins-bot: Handle redlinks and change placeholder [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/148702 (owner: 10Wctaiwan) [04:21:49] (03CR) 10Daniel Friesen: [C: 04-1] "Sorry, but this is in fact a usability improvement that improves legibility, not some designer's whim." [core] - 10https://gerrit.wikimedia.org/r/148548 (https://bugzilla.wikimedia.org/66021) (owner: 10Isarra) [04:24:35] 3MediaWiki skins / 3Vector: Grey content text in Vector impairs legibility - 10https://bugzilla.wikimedia.org/66021#c3 (10Daniel Friesen) Black on white is not "clearly legible", it causes eye strain in normal people and for dyslexic people causes bluring of text that makes reading difficult. [04:30:35] 3MediaWiki / 3Recent changes: Page moves into mainspace should appear on Special:Newpages for patrol - 10https://bugzilla.wikimedia.org/12363#c38 (10Bawolff (Brian Wolff)) Rohan's patch just gave me a (hacky) idea. *Add an index on (rc_source, rc_log_type, rc_timestamp) *Do the normal newpages query, taking... [04:32:14] (03PS3) 10AndyRussG: WIP Add HooksTest [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/146033 [04:36:17] (03CR) 10BryanDavis: [C: 031] "Some comments inline about nice to have future additions. The role worked great for my though so I'm going to rebase and merge it." (033 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/147151 (owner: 10Gilles) [04:40:09] (03Abandoned) 10Tim Starling: Revert "Add Composer managed libraries" [core] - 10https://gerrit.wikimedia.org/r/138531 (owner: 10Tim Starling) [04:40:42] (03PS2) 10Tim Starling: Disable the emergency CPU limit on HHVM [php/luasandbox] - 10https://gerrit.wikimedia.org/r/145159 [04:40:52] (03PS7) 10BryanDavis: Create Commons role to provide a ForeignDBViaLBRepo wiki [vagrant] - 10https://gerrit.wikimedia.org/r/147151 (owner: 10Gilles) [04:40:59] (03CR) 10Tim Starling: [C: 032] Disable the emergency CPU limit on HHVM [php/luasandbox] - 10https://gerrit.wikimedia.org/r/145159 (owner: 10Tim Starling) [04:41:22] (03PS2) 10Tim Starling: Latest net-changes-mini mail [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/107995 [04:41:27] (03CR) 10Tim Starling: [C: 032] Latest net-changes-mini mail [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/107995 (owner: 10Tim Starling) [04:41:32] (03Merged) 10jenkins-bot: Disable the emergency CPU limit on HHVM [php/luasandbox] - 10https://gerrit.wikimedia.org/r/145159 (owner: 10Tim Starling) [04:41:34] (03Merged) 10jenkins-bot: Latest net-changes-mini mail [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/107995 (owner: 10Tim Starling) [04:42:08] (03CR) 10BryanDavis: [C: 032] "Thanks Gilles!" [vagrant] - 10https://gerrit.wikimedia.org/r/147151 (owner: 10Gilles) [04:42:13] (03Merged) 10jenkins-bot: Create Commons role to provide a ForeignDBViaLBRepo wiki [vagrant] - 10https://gerrit.wikimedia.org/r/147151 (owner: 10Gilles) [04:43:20] 3MediaWiki / 3Categories: Incorrect links to "previous 200" page in category listing - 10https://bugzilla.wikimedia.org/36964 (10Bawolff (Brian Wolff)) 5PATC>3RESO/FIX [04:45:08] (03CR) 10Brian Wolff: "Because Reasons!" [core] - 10https://gerrit.wikimedia.org/r/140975 (owner: 10Brian Wolff) [04:45:31] legoktm: Sometimes I make silly patches ;) [04:46:56] legoktm: Thanks for the code review, btw [04:47:05] 3MediaWiki extensions / 3RandomRootPage: [[Special:RandomRootPage/]] returns also from other namespace than main only - 10https://bugzilla.wikimedia.org/46420#c12 (10Bawolff (Brian Wolff)) 5PATC>3RESO/FIX Should start working on July 29 [04:48:43] np :) [04:49:35] bawolff: for portal-esq pages, wouldn't "Special:RandomInCategory/Foo" be more useful? [04:49:47] (03CR) 10Tim Starling: [C: 04-2] "This doesn't really make sense to me. Caching will only give a performance benefit if the cache is faster than the backend. It doesn't mak" [core] - 10https://gerrit.wikimedia.org/r/117091 (owner: 10MaxSem) [04:50:03] I can see that being used on enwp, where they currently use pseudo-random through NUMBEROFEDITS or something [04:50:12] duh: yeah probably [04:50:36] That commit was kind of a spur-of-the moment. Hey wouldn't it be cool thing [04:51:35] I always thought special page transclusion was silly. [04:52:26] * bawolff may try to do a version of that commit for Special:RandomInCategory at some point [04:54:19] (03CR) 10Legoktm: Make transcluded special pages not disable cache in miser mode. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/140945 (https://bugzilla.wikimedia.org/60561) (owner: 10Brian Wolff) [04:57:08] (03CR) 10Brian Wolff: [C: 04-1] "-1 to remind myself that there are things for me to do on this patch" [core] - 10https://gerrit.wikimedia.org/r/140945 (https://bugzilla.wikimedia.org/60561) (owner: 10Brian Wolff) [04:59:04] (03PS1) 10Withoutaname: Throw exceptions directly within EditPage::internalAttemptSave() [core] - 10https://gerrit.wikimedia.org/r/148947 [05:00:45] (03PS5) 10Tim Starling: Allow wfShellExec() to use an array as a command prompt [core] - 10https://gerrit.wikimedia.org/r/144762 (owner: 10Yurik) [05:02:24] 3MediaWiki skins / 3Vector: Grey content text in Vector impairs legibility - 10https://bugzilla.wikimedia.org/66021#c4 (10Isarra) (In reply to Daniel Friesen from comment #3) > Black on white is not "clearly legible", it causes eye strain in normal > people and for dyslexic people causes bluring of text that... [05:02:35] (03CR) 10Legoktm: [C: 04-1] "Needs rebase." (031 comment) [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/53918 (owner: 10Parent5446) [05:02:46] (03CR) 10Tim Starling: [C: 032] "I like this version. The original was much too clever, I like simple things." [core] - 10https://gerrit.wikimedia.org/r/144762 (owner: 10Yurik) [05:03:32] (03CR) 10Isarra: "I replied on the bug. Long story short, you're preaching a fallacy." [core] - 10https://gerrit.wikimedia.org/r/148548 (https://bugzilla.wikimedia.org/66021) (owner: 10Isarra) [05:04:02] (03CR) 10BryanDavis: "http://globalcssjstest.wiki.local.wmftest.net:8080/ worked for me after provisioning. It did crash on my first request, but that seemed to" (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/148920 (owner: 10Legoktm) [05:05:17] bd808: ohhh, I was missing the ".local" part [05:05:32] ah [05:05:47] My eye skipped right over that [05:06:19] (03Merged) 10jenkins-bot: Allow wfShellExec() to use an array as a command prompt [core] - 10https://gerrit.wikimedia.org/r/144762 (owner: 10Yurik) [05:06:48] bd808: can I use ${foo} stuff inside 'single quotes' or does it have to be "double" like PHP? [05:07:16] duh: I have a bookmark for http://foo.wiki.local.wmftest.net:8080/ so I can see all the wikis I have running from the 404 page [05:07:33] duh: It needs to be double quoted to interpolate [05:07:45] oh that is awesome [05:07:52] ok [05:08:15] * bd808 revealed an easter egg [05:10:07] (03PS2) 10Legoktm: Add GlobalCssJs role [vagrant] - 10https://gerrit.wikimedia.org/r/148920 [05:10:10] (03CR) 10Legoktm: Add GlobalCssJs role (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/148920 (owner: 10Legoktm) [05:10:35] (03PS3) 10Legoktm: Add GlobalCssJs role [vagrant] - 10https://gerrit.wikimedia.org/r/148920 [05:13:38] bd808: should be good now ^ [05:13:48] thanks again folks for the information. [05:20:05] ohai wikiphabot [05:20:48] wikiphabot, can you tell me about the task T95? [05:20:48] T95: Restricting the access levels of all tasks under a specific project - http://fab.wmflabs.org/T95 [05:20:56] woot [05:21:29] wikiphabot, what should I have for a late night snack? [05:21:52] (03CR) 10Legoktm: "Is this still needed given the linked bug is marked as fixed?" [extensions/RSS] - 10https://gerrit.wikimedia.org/r/130837 (https://bugzilla.wikimedia.org/43737) (owner: 10Aude) [05:21:58] wikiphabot, T1 [05:21:58] T1: Be able to create and edit definition lists visually - http://fab.wmflabs.org/T1 [05:22:17] wikiphabot: make me a sandwich [05:22:27] damn [05:22:31] twentyafterfour: you forgot sudo [05:22:41] wikiphabot: sudo make me a sandwich? [05:22:54] (03CR) 10Legoktm: [C: 032] Pass jshint [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/148059 (https://bugzilla.wikimedia.org/61617) (owner: 10Hashar) [05:23:01] (03Merged) 10jenkins-bot: Pass jshint [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/148059 (https://bugzilla.wikimedia.org/61617) (owner: 10Hashar) [05:23:16] That's always supposed to work [05:23:29] and also why the license plate on my jeep says SUDO [05:23:54] 3MediaWiki extensions / 3OATHAuth: OATHAuth should pass jshint - 10https://bugzilla.wikimedia.org/61617 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:5Ryan Lane>3Antoine "hashar" Musso [05:25:01] bd808: your jeep makes you a sandwich? [05:25:38] Yes. smashed squirrel and mud. Yum [05:26:46] duh: My eyes are tired and I'm not seeing the cause, but I get "syntax error, unexpected '='" as the output from all pages on my main wiki after turning your new role on now. [05:27:42] * bd808 will look again in the morning after sleeeeps [05:28:01] (03CR) 10Tim Starling: "Given the target audience, I think a fairly technical procedure documented on https://en.wikipedia.org/wiki/WP:TOR and https://www.mediawi" (031 comment) [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/53918 (owner: 10Parent5446) [05:28:16] (03PS1) 10Withoutaname: Collapse two private functions back to their callers [core] - 10https://gerrit.wikimedia.org/r/148949 [05:30:07] 3MediaWiki skins / 3Vector: Grey content text in Vector impairs legibility - 10https://bugzilla.wikimedia.org/66021#c5 (10Bawolff (Brian Wolff)) Created attachment 16032 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16032&action=edit Screenshot with a gamma adjustment of 3.0 to simulate what a crapp... [05:30:41] bd808|BUFFER: good night, and I didn't test it...let me do that. [05:32:26] bawolff: 54 new messages! [05:33:40] duh: Took me a while to figure out how you knew how many messages I had [05:33:47] * bawolff was really creeped out there for a moment [05:43:12] (03CR) 10Wikinaut: "@Legoktm: thanks for asking ("Is this still needed given the linked bug is marked as fixed?")." [extensions/RSS] - 10https://gerrit.wikimedia.org/r/130837 (https://bugzilla.wikimedia.org/43737) (owner: 10Aude) [05:44:24] (03PS1) 10Wctaiwan: Differentiate invalid title and invalid site [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/148950 [05:45:03] TimStarling: I'm don't think we should make it that hard for people to claim their tor node :P [05:45:48] how many tor exit nodes are there? [05:46:01] I have no idea. [05:46:16] * legoktm finds the list [05:47:48] https://onionoo.torproject.org/details?type=relay&running=true&flag=Exit doesn't have a number... [05:48:20] did you read about that guy in Austria who was convicted of distributing child sex abuse material because he was running a Tor exit node? [05:48:50] I did not. [05:49:03] I wonder how many exit nodes there will be if it's generally found to be illegal in the EU [05:49:19] I'm not super familiar with tor, I'm just reviewing the patches because someone asked on wikitech. [05:49:51] 3MediaWiki-Vagrant: vagrant plugin install fails - 10https://bugzilla.wikimedia.org/68453#c3 (10Bernd Sitzmann) Thanks. That did the trick. I had to use sudo for some weird reason. I think I need to straighten out my permissions. Did a sudo chown -R `whoami`:staff on the vagrant repo folder, which made 'vagran... [05:51:37] (03CR) 10Robert Vogel: [C: 031 V: 031] "Thanks for your contribution" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148909 (owner: 10Shirayuki) [05:58:51] 3MediaWiki-Vagrant: vagrant plugin install fails - 10https://bugzilla.wikimedia.org/68453#c4 (10Bernd Sitzmann) Forgot to update the pastebin with the reload and the provision output: http://pastebin.com/5aHEpMuH Also did the vagrant shh at the end, which worked. Again, I think it's getting really close but w... [06:00:14] (03CR) 10Legoktm: [C: 04-1] " duh: My eyes are tired and I'm not seeing the cause, but I get "syntax error, unexpected '='" as the output from all pages on my " [vagrant] - 10https://gerrit.wikimedia.org/r/148920 (owner: 10Legoktm) [06:04:45] (03PS4) 10Legoktm: Add GlobalCssJs role [vagrant] - 10https://gerrit.wikimedia.org/r/148920 [06:05:21] (03CR) 10Legoktm: Add GlobalCssJs role (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/148920 (owner: 10Legoktm) [06:07:40] (03CR) 10MaxSem: "These links must be protocol-relative on mobile because we must keep Zero users on HTTP to keep thenmzero-rated." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148881 (owner: 10Kaldari) [06:19:19] (03CR) 10PleaseStand: [C: 04-1] "The Licenses class is still in use. From SpecialUpload::getDescriptionSection():" [core] - 10https://gerrit.wikimedia.org/r/148902 (owner: 10Withoutaname) [06:23:14] (03CR) 10Withoutaname: "How about we move it under HTMLForm then? It seems like a special use-case." [core] - 10https://gerrit.wikimedia.org/r/148902 (owner: 10Withoutaname) [06:25:52] 3MediaWiki / 3General/Unknown: wfShellExec() cuts off stdout at multiples of 8192 bytes - 10https://bugzilla.wikimedia.org/67870 (10Max Semenik) 5PATC>3RESO/FIX [06:25:59] (03PS1) 10Robert Vogel: ExtendedSearch: CSS more skin agnostic #2 [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148954 [06:29:34] (03PS2) 10Wctaiwan: Differentiate invalid title and invalid site [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/148950 [06:32:16] (03PS1) 10Robert Vogel: BlueSpiceSkin/ExtendedSearch: Added some CSS [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/148955 [06:42:39] (03CR) 10Tim Starling: [C: 032] Added support for HTTPS [extensions/AddThis] - 10https://gerrit.wikimedia.org/r/141266 (owner: 10DavisNT) [06:43:44] (03CR) 10Tim Starling: Use MWLogger logging for legacy logging methods [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [06:57:06] (03PS3) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/148062 [06:58:02] (03CR) 10Tim Starling: "The commit message does not match the code change. The temporary hacks are enabled everywhere, not removed." [core] - 10https://gerrit.wikimedia.org/r/144155 (owner: 10Withoutaname) [07:14:19] (03PS4) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/148062 [07:14:50] (03CR) 10Umherirrender: "Patch Set 4: Fixed 4 files from the last days" [core] - 10https://gerrit.wikimedia.org/r/148062 (owner: 10Umherirrender) [07:31:01] (03PS1) 10Robert Vogel: [WIP] Moving upload panel/dialog to BSF [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/148956 [07:33:55] (03PS1) 10Robert Vogel: [WIP] Moving upload panel/dialog to BSF (Part 2) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148957 [07:41:49] (03PS1) 10TTO: Remove unused XMLReader2 class [core] - 10https://gerrit.wikimedia.org/r/148958 [07:44:11] (03CR) 10Swidmann: [C: 04-1] "just always do what robert says :)" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148638 (owner: 10Pwirth) [07:59:53] 3MediaWiki skins / 3Vector: Grey content text in Vector impairs legibility - 10https://bugzilla.wikimedia.org/66021#c6 (10Daniel Friesen) (In reply to Isarra from comment #4) > (In reply to Daniel Friesen from comment #3) > > Black on white is not "clearly legible", it causes eye strain in normal > > people... [08:08:48] (03PS1) 10Umherirrender: Each line in a doc block should start with * [core] - 10https://gerrit.wikimedia.org/r/148961 [08:14:46] (03CR) 10Florianschmidtwelzow: "Is there any progress? :)" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/143320 (owner: 10Paladox) [08:19:44] (03PS1) 10Hashar: Make OATHAuth jslint job voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148963 (https://bugzilla.wikimedia.org/61617) [08:20:04] (03CR) 10Hashar: [C: 032] Make OATHAuth jslint job voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148963 (https://bugzilla.wikimedia.org/61617) (owner: 10Hashar) [08:20:09] (03Merged) 10jenkins-bot: Make OATHAuth jslint job voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148963 (https://bugzilla.wikimedia.org/61617) (owner: 10Hashar) [08:21:21] 3MediaWiki extensions / 3OATHAuth: OATHAuth should pass jshint - 10https://bugzilla.wikimedia.org/61617#c7 (10Antoine "hashar" Musso) 5PATC>3RESO/FIX Jenkins job is now voting. \O/ [08:24:22] 3MediaWiki / 3Skin and page rendering: Images with border parameter should display captions - 10https://bugzilla.wikimedia.org/68468#c11 (10Erwin Dokter) (In reply to James Forrester from comment #10) > Border only applies to "none"/basic and "frameless" images, not "framed" or > "thumb". Yes, but since "fr... [08:27:17] (03PS1) 10Liangent: Send 404 in various special pages when there're no results [core] - 10https://gerrit.wikimedia.org/r/148965 (https://bugzilla.wikimedia.org/67182) [08:29:54] (03CR) 10Smuggli: [C: 032 V: 032] i18n: translation tweaks [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148909 (owner: 10Shirayuki) [08:30:36] (03CR) 10Smuggli: [C: 032 V: 032] ExtendedSearch: CSS more skin agnostic #2 [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148954 (owner: 10Robert Vogel) [08:34:56] (03CR) 10MaxSem: [C: 04-1] "I'd rather concentrate not on release notes but on our release principles, according to which we aren't supposed to backport stuff other t" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/143320 (owner: 10Paladox) [08:36:27] (03PS1) 10Divec: Fix socket errors: buffer apertium stdout [services/cxserver] - 10https://gerrit.wikimedia.org/r/148968 [08:41:13] hashar added a comment to T274: The code review process in Differential/Audit needs to be adapted to our needs. http://fab.wmflabs.org/T274 [08:44:49] (03PS1) 10Mwalker: Allow unzipped bundle [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148970 [08:45:06] (03PS5) 10Prtksxna: Add styling for the styleguide [core] - 10https://gerrit.wikimedia.org/r/148626 [08:46:25] (03CR) 10jenkins-bot: [V: 04-1] Allow unzipped bundle [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148970 (owner: 10Mwalker) [08:46:28] hello wikiphabot [08:47:00] (03PS2) 10Mwalker: Allow unzipped bundle [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148970 [08:48:36] (03CR) 10jenkins-bot: [V: 04-1] Allow unzipped bundle [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148970 (owner: 10Mwalker) [08:50:40] 3MediaWiki / 3General/Unknown: PHP Fatal error: Call to a member function exists() on a non-object in / - 10https://bugzilla.wikimedia.org/68501 (10Dick) 3UNCO p:3Unprio s:3normal a:3None I'm getting the following when I try to solve SpecialPages:BadTitle-problem: root@mediawiki mediawiki/maintenan... [08:52:11] (03PS2) 10Pwirth: TopMenuBarCustomizer: Refactoring [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148638 [08:55:10] (03PS3) 10Mwalker: Allow unzipped bundle [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148970 [08:56:14] (03CR) 10Prtksxna: "1) I've removed the styleguide switcher and the search. So we don't need icons for it either." [core] - 10https://gerrit.wikimedia.org/r/148626 (owner: 10Prtksxna) [08:56:19] (03PS4) 10Mwalker: Allow unzipped bundle [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148970 [08:57:05] 3MediaWiki extensions / 3WikidataClient: allow linking when property parser function has multiple results - 10https://bugzilla.wikimedia.org/46788 (10Lydia Pintscher) [08:57:07] 3MediaWiki extensions / 3WikidataClient: allow linking when property parser function has multiple results - 10https://bugzilla.wikimedia.org/46788#c4 (10Lydia Pintscher) We just discussed this. Conclusion: We want to have it as a parameter. The returned string should be wikitext with the individual labels li... [08:58:57] (03PS6) 10Prtksxna: Add styling for the styleguide [core] - 10https://gerrit.wikimedia.org/r/148626 [09:03:09] mmodell updated subscribers of T274: The code review process in Differential/Audit needs to be adapted to our needs. http://fab.wmflabs.org/T274 [09:08:49] (03PS1) 10Reza: Add Simple English translation to Persian [extensions/cldr] - 10https://gerrit.wikimedia.org/r/148971 [09:11:33] (03CR) 10Reza: "Originally added on https://gerrit.wikimedia.org/r/#/c/102921/ but Simple English translation which is needed on Persian Wikipedia Main Pa" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/148971 (owner: 10Reza) [09:13:29] (03PS1) 10Smuggli: [WIP] Refactoring of some parts of ExtendedSearch [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148972 [09:16:30] Gerrit Code Review committed rOPSPUPPET8a347bd64d16: Merge "beta: Fix signal sent by beta-apaches script" into production (authored by akosiaris). [09:30:56] (03PS1) 10Umherirrender: Remove colon after @deprecated/@param/@todo/@note [core] - 10https://gerrit.wikimedia.org/r/148973 [09:31:05] Gerrit Code Review committed rOPSPUPPET28f4e426de32: Merge "Specify owner/group/mode for apache::conf" into production (authored by akosiaris). [09:33:51] 3MediaWiki / 3Sites: At trying to add interwikis to the Slovene Wikipedia, the software incorrectly searches the 'sk' database instead of the 'sl' one - 10https://bugzilla.wikimedia.org/67566#c3 (10Dejan Papež) That's it - the link at the bottom of the sidebar. [09:41:24] (03PS1) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148975 [09:41:26] (03PS1) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148976 [09:44:54] (03CR) 10Smuggli: [C: 04-2 V: 04-1] "Duplicate review." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148975 (owner: 10Smuggli) [09:45:24] (03Abandoned) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148975 (owner: 10Smuggli) [09:53:38] (03PS5) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/148062 [09:54:03] (03CR) 10Umherirrender: "Patch Set 5: Included space after casts" [core] - 10https://gerrit.wikimedia.org/r/148062 (owner: 10Umherirrender) [10:04:14] (03CR) 10Smuggli: Implemented changes for translatewiki (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/146428 (owner: 10Smuggli) [10:04:57] (03CR) 10Nikerabbit: API continue param to streamline iteration of complex queries (032 comments) [core] - 10https://gerrit.wikimedia.org/r/50930 (owner: 10Yurik) [10:06:44] (03PS1) 10Smuggli: Added new message [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/148979 [10:07:26] (03PS2) 10Smuggli: Added new message [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/148979 [10:07:37] hashar committed rOPSPUPPET5e4f185cfde6: contint: install Zuul on all CI slaves (authored by hashar). [10:13:26] 3MediaWiki-Vagrant: HHVM Failed Assertion: assertion `false && "Unsupported DataType"' failed. - 10https://bugzilla.wikimedia.org/68491 (10Niklas Laxström) [10:13:26] 3MediaWiki extensions / 3Translate: Fatal error: Call to a member function getMessage() on a non-object in /mediawiki/extensions/Translate/tag/TranslatablePage.php on line 253 - 10https://bugzilla.wikimedia.org/67295#c3 (10Niklas Laxström) I'm currently unable to run Translate tests under hhvm due to bug 684... [10:14:54] (03PS8) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/146428 [10:15:40] (03CR) 10Smuggli: "New message is added in a separate commit https://gerrit.wikimedia.org/r/#/c/148979/" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/146428 (owner: 10Smuggli) [10:17:38] (03PS7) 10Paladox: mediawiki.searchSuggest: Enable for iPhone and iPod touch [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/143320 [10:20:01] (03CR) 10Daniel Kinzler: [C: 032] Remove colon after @deprecated/@param/@todo/@note [core] - 10https://gerrit.wikimedia.org/r/148973 (owner: 10Umherirrender) [10:20:17] (03CR) 10Daniel Kinzler: [C: 032] Removed @since in MediaWikiPHPUnitTestListener [core] - 10https://gerrit.wikimedia.org/r/148749 (owner: 10Umherirrender) [10:21:05] aklapper added a comment to T135: Set "Self Actions" for default user to "Do not send me an email when I take an action".. http://fab.wmflabs.org/T135 [10:21:19] aklapper removed a project from T135: Set "Self Actions" for default user to "Do not send me an email when I take an action".: Wikimedia Phabricator Day 1 http://fab.wmflabs.org/T135 [10:21:37] aklapper updated tasks of T135: Set "Self Actions" for default user to "Do not send me an email when I take an action".. http://fab.wmflabs.org/T135 [10:21:38] aklapper updated tasks of T39: Plan to migrate Bugzilla to Phabricator. http://fab.wmflabs.org/T39 [10:23:28] (03Merged) 10jenkins-bot: Remove colon after @deprecated/@param/@todo/@note [core] - 10https://gerrit.wikimedia.org/r/148973 (owner: 10Umherirrender) [10:24:05] qgil renamed T336: Import non-test projects from fab.wmflabs.org to the official Wikimedia Phabricator from "Import non-spam projects from fab.wmflabs.org to the official Wikimedia Phabricator" to "Import non-test projects from fab.wmflabs.org to the official Wikimedia Phabricator". http://fab.wmflabs.org/T336 [10:24:11] (03Merged) 10jenkins-bot: Removed @since in MediaWikiPHPUnitTestListener [core] - 10https://gerrit.wikimedia.org/r/148749 (owner: 10Umherirrender) [10:24:21] cool! [10:24:38] wikiphabot, what a good surprise [10:36:50] qgil added a comment to T359: Decide which task statuses we want to have in Maniphest. http://fab.wmflabs.org/T359 [10:36:58] morebots! [10:37:09] qgil: nice! and we didn't have to write any custom code! [10:37:14] yay! (and boo? :)) [10:37:27] T359 [10:37:28] T359: Decide which task statuses we want to have in Maniphest - http://fab.wmflabs.org/T359 [10:37:34] qgil: ^ it does this as well, nice [10:38:48] (03CR) 10Robert Vogel: [C: 031 V: 031] Added new message [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/148979 (owner: 10Smuggli) [10:39:02] Gerrit Code Review committed rOPSPUPPETbd895f86c701: Merge "redis: qualify vars" into production (authored by akosiaris). [10:39:16] oh god, ^ is going to be annoying [10:41:42] YuviPanda, wow [10:42:55] YuviPanda, you should update T221 [10:42:55] T221: Replace the IRC bots by Phab's chatbot and related handlers - http://fab.wmflabs.org/T221 [10:43:01] it works! :) [10:50:07] qgil: :) am trying to login, keep getting 'your session is invalid' [10:50:10] * YuviPanda tries another browser [10:50:40] chasemp, ^^^^^^ [10:50:51] chasemp, (whenever you wake up, that is) [10:51:10] > ' Your login session is invalid. Try reloading the page and logging in again. If that does not work, clear your browser cookies.' more specifically [10:51:42] YuviPanda, I will file a bug [10:51:57] YuviPanda, have you logged in with Wikimedia SUL before? [10:51:57] qgil: unrelated, but thought you might be interested in https://meta.wikimedia.org/wiki/Research:Ideas/Public_query_interface_for_Labs. Something me + a couple of researchers are building to make it easier for volunteers + new researchers to get started on labsdb [10:52:03] qgil: oh, no, I haven't [10:52:33] qgil: worked on another browser, tho [10:52:46] now you can create the task :) [10:53:33] (03PS2) 10Reza: Add Simple English translation to Persian [extensions/cldr] - 10https://gerrit.wikimedia.org/r/148971 [10:53:41] yuvipanda added a comment to T221: Replace the IRC bots by Phab's chatbot and related handlers. http://fab.wmflabs.org/T221 [10:53:45] qgil: ^ [10:54:09] YuviPanda, ref sql & labs. Very interesting. Spot on. [10:54:37] qgil: my current goal is to get a fully functional prototype before the research hackday at wikimania [10:54:53] YuviPanda, something tells me that you passed your exams... [10:54:57] and of course, I'm building this as a volunteer :) [10:55:02] qgil: :D [10:55:49] qgil: applying my Software Engineering textbook, I should create a committee of ~5 people and not merge any patches until those people +1 it individually :) [10:56:08] right [10:58:19] qgil added a comment to T500: Allow tracking bugs. http://fab.wmflabs.org/T500 [10:58:48] qgil: ^ very Terminator :D [10:58:52] * YuviPanda wonders who will claim T1000 [10:58:52] T1000: A mimetic poly-alloy assassin controlled by Skynet [10:58:57] hahhahahaha [10:58:58] nice [11:00:34] T007 [11:00:34] T7: Upgrade logstash to 1.3.2 - http://fab.wmflabs.org/T7 [11:00:40] smart [11:00:47] T5555555555555555 [11:00:54] very smart [11:00:59] hehe [11:01:33] T999 [11:01:46] ok, that was an easter egg [11:01:57] indeed [11:05:07] qgil: do you know how far off is the prod phabricator? [11:06:27] YuviPanda, what for? [11:07:11] YuviPanda, https://www.mediawiki.org/wiki/Requests_for_comment/Phabricator/Plan#Migration_plan [11:07:37] YuviPanda, Day 1 should be during this quarter, but depending on how you need the answer could be "already now" [11:07:50] Devending on WHAT you need [11:07:59] d e p e n d i n g [11:08:04] ah [11:08:05] :D [11:08:07] hehe [11:08:59] YuviPanda, if you have a little project in mind, fab.wmflabs is good enough already [11:09:14] qgil: is it set up for codereview and stuff? [11:09:48] YuviPanda, no, but code review is out of scope for Day 1, that will come later [11:09:55] qgil: right [11:10:15] that's the thing I'm most interested in, though, so I'll probably wait a bit [11:11:03] I guess code review will be enabled in fab.wmflabs as soon as the Day 1 dust starts to settle in the production server [11:11:16] but that's just my very improvised guess [11:11:28] right [11:11:56] hi andre__ ! have you met wikiphabot already? [11:11:58] aklapper added a comment to T359: Decide which task statuses we want to have in Maniphest. http://fab.wmflabs.org/T359 [11:12:06] there you go [11:12:11] oh. [11:12:17] hi wikiphabot! [11:12:19] nice. [11:12:30] I miss a "error: hi is not a valid comment". Hmpf. [11:12:41] qgil: shweet shweet! [11:12:47] (03PS1) 10Umherirrender: Doc: Reformat @params declaration [core] - 10https://gerrit.wikimedia.org/r/148982 [11:12:54] YuviPanda has the merit (and maybe someone else, dunno) [11:13:13] lovely [11:13:37] * andre__ checks http://fab.wmflabs.org/T221 about IRC bots [11:13:49] ah, Yuvi already commented [11:15:12] I dunno who set it up :D [11:16:07] 3MediaWiki extensions / 3WikidataClient: allow linking when property parser function has multiple results - 10https://bugzilla.wikimedia.org/46788#c5 (10Aude) what is the parameter? [11:17:38] qgil added a comment to T359: Decide which task statuses we want to have in Maniphest. http://fab.wmflabs.org/T359 [11:21:23] 3MediaWiki extensions / 3WikidataClient: allow linking when property parser function has multiple results - 10https://bugzilla.wikimedia.org/46788#c6 (10Marius Hoch) (In reply to Aude from comment #5) > what is the parameter? I guess {{#property:P123|linked}} is the syntax we want. [11:22:56] qgil edited the description of T359: Decide which task statuses we want to have in Maniphest. http://fab.wmflabs.org/T359 [11:33:00] qgil added a comment to T359: Decide which task statuses we want to have in Maniphest. http://fab.wmflabs.org/T359 [11:34:23] 3Wikimedia / 3Git/Gerrit: Gerrit search: enable secondary index to allow latest operators - 10https://bugzilla.wikimedia.org/61463#c3 (10christian) (In reply to Nemo from comment #0) > Is this the infamous Lucene search? Yes. Gerrit's current search back-end gerrit uses is not great. Agreed. But Gerrit's... [11:34:31] andre__, sorry for not being able to attend yesterday [11:34:56] andre__, did you discuss #2 in the migration plan (production with only SUL enabled) [11:35:17] qgil, no problem, it was short (<30min), you didn't miss much, and you see the outcome in tickets :) [11:35:25] yep [11:36:00] qgil, not directly, more like what we still must sort out on that way (file permissions, mail/exim setup). [11:36:03] plus migration script testing [11:36:20] but none of this are required in production + SUL only [11:37:07] see YuviPanda's comments above, 12:50, he also found problems logging in [11:37:39] ah wait [11:38:07] qgil: :) am trying to login, keep getting 'your session is invalid' [11:38:07] * YuviPanda tries another browser [11:38:07] chasemp, ^^^^^^ [11:38:07] chasemp, (whenever you wake up, that is) [11:38:07] > ' Your login session is invalid. Try reloading the page and logging in again. If that does not work, clear your browser cookies.' more specifically [11:38:08] YuviPanda, I will file a bug [11:38:10] YuviPanda, have you logged in with Wikimedia SUL before? [11:38:12] qgil: unrelated, but thought you might be interested in https://meta.wikimedia.org/wiki/Research:Ideas/Public_query_interface_for_Labs. Something me + a couple of researchers are building to make it easier for volunteers + new researchers to get started on labsdb [11:38:16] qgil: oh, no, I haven't [11:38:20] qgil: worked on another browser, tho [11:38:22] now you can create the task :) [11:38:24] andre__, ^^^^^ [11:39:15] !paste [11:39:15] To avoid overflowing the channel with inane amounts of text, use https://dpaste.org/ or other awesome pastebin sites to share code, errors, and other large texts. [11:39:16] :D [11:39:29] ok, sorry [11:40:13] YuviPanda: please file bugs if you have problems logging in. [11:40:21] well. [11:40:23] andre__: I don't anymore, fwiw. [11:40:26] that requires logging in. :P [11:40:37] andre__: I think the problem was that I was logged in from a long long time ago, and some session cookie messup happened. [11:40:39] YuviPanda, but if you can log in, http://fab.wmflabs.org/maniphest/task/create/ please [11:40:42] andre__: I am able to login on another browser [11:41:13] if you can still reproduce with the first browser, exact error welcome in a bug report :) [11:41:25] mmodell added a comment to T497: Add API call in Conduit to create projects in Phabricator. http://fab.wmflabs.org/T497 [11:41:33] I'll try in a moment and file one, andre__ :) [11:41:51] YuviPanda, thank you! [11:44:31] (03Abandoned) 10SG: Add doOnce helper and flow-menu-split class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/146817 (owner: 10SG) [11:45:15] (03PS3) 10SG: Make mw-ui-input CSS in Flow more specific, so as to override Core properties [extensions/Flow] - 10https://gerrit.wikimedia.org/r/146819 [11:50:58] (03PS3) 10SG: Improve collapse functionality, and improve various collapsed states' styles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147524 [11:51:07] (03PS4) 10SG: Update mw-ui.enhance to Core version, add support for select, radio, and checkboxes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145331 [11:51:16] (03PS1) 10SG: Add onbeforeunload handler when navigating away from unsubmitted changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148983 [11:51:26] (03PS7) 10SG: Adjust collapser capabilities and allow its use on post elements [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145200 (owner: 10Jdlrobson) [11:52:07] (03CR) 10jenkins-bot: [V: 04-1] Adjust collapser capabilities and allow its use on post elements [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145200 (owner: 10Jdlrobson) [11:52:32] (03CR) 10SG: "There's some "todos" in this code to make the collapser more generic. It's ALMOST there, it would just need some slight fixing in the futu" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145200 (owner: 10Jdlrobson) [11:53:34] (03CR) 10Parent5446: "I will do *literally* anything for a +2 at this point. Once I get to work I'll change $wgPasswordDefault." [core] - 10https://gerrit.wikimedia.org/r/77645 (https://bugzilla.wikimedia.org/54948) (owner: 10Parent5446) [11:54:24] (03CR) 10SG: [C: 04-1] "Per discussion yesterday we are no longer doing this patch. Is that correct?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147344 (owner: 10Jdlrobson) [11:55:37] (03CR) 10SG: [C: 04-2] "I don't think this patch is necessary anymore with my other collapser patch. Please verify. If I'm mistaken, I will remove the -2 on this." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145172 (owner: 10Jdlrobson) [11:57:23] 3Wikimedia / 3Git/Gerrit: Gerrit search: enable secondary index to allow latest operators - 10https://bugzilla.wikimedia.org/61463#c4 (10Nemo) Thanks for commenting. (In reply to christian from comment #3) > I have no say here, but since we're heading Phabricator anyways, I do not > think switching the sear... [11:57:53] 3Wikimedia / 3Git/Gerrit: Gerrit search: enable secondary index to allow latest operators - 10https://bugzilla.wikimedia.org/61463 (10Nemo) s:5normal>3enhanc [12:02:38] 3MediaWiki / 3Internationalization: Consider using content language for "html lang", rather than interface language - 10https://bugzilla.wikimedia.org/68490#c1 (10Niklas Laxström) (In reply to Nemo from comment #0) > The interface is correctly tagged as "it" and the content as "fi", but > they're both wrappe... [12:02:38] 3MediaWiki-Vagrant: When using hhvm, CurlHttpRequest::execute times out - 10https://bugzilla.wikimedia.org/68489 (10Andre Klapper) [12:07:44] (03CR) 10SG: "On one hand, I want to +2 this patch. On the other, Bartosz does have some valid arguments. Perhaps this warrants further discussion befor" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148529 (owner: 10Jdlrobson) [12:11:05] 3MediaWiki / 3Maintenance scripts: PHP Fatal error: Call to a member function exists() on a non-object in maintenance/cleanupTitles.p hp - 10https://bugzilla.wikimedia.org/68501 (10Andre Klapper) p:5Unprio>3Normal [12:12:00] (03CR) 10SG: [C: 04-1] "Based on my testing, this is still loading up more topics instantly, instead of after scrolling to a reasonable threshold." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145470 (owner: 10Jdlrobson) [12:13:36] 3MediaWiki skins / 3Vector: Provide a workaround to IE's bug that causes the generic "serif" rendered broken - 10https://bugzilla.wikimedia.org/63817#c3 (10Yusuke Matsubara) On Japanese Wikipedia, users are testing this hack: https://ja.wikipedia.org/wiki/MediaWiki:Gadget-SwitchFont.js https://ja.wikipedia.... [12:14:01] Hm, I wonder why titles like "Talk:interwiki:Foo" are disallowed? [12:14:08] Seems a bit random to me! [12:14:20] (03CR) 10KartikMistry: "Documentation about how this can be useful (and how to test this) will be good!" [services/cxserver] - 10https://gerrit.wikimedia.org/r/148968 (owner: 10Divec) [12:14:21] e.g. [[Talk:wikt:foo]] [12:14:23] (03PS2) 10SG: Add hover effects to thanks and reply buttons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148717 (owner: 10Jdlrobson) [12:14:27] (03CR) 10SG: [C: 032] Add hover effects to thanks and reply buttons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148717 (owner: 10Jdlrobson) [12:15:03] (03Merged) 10jenkins-bot: Add hover effects to thanks and reply buttons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148717 (owner: 10Jdlrobson) [12:16:01] SG committed rFLOW07449ef78222: Add hover effects to thanks and reply buttons (authored by jdlrobson ). [12:17:51] (03CR) 10SG: [C: 04-1] "I don't think 100% width is the solution for this, it's a bit heavy-handed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148726 (owner: 10Jdlrobson) [12:18:22] (03CR) 10Swidmann: [C: 04-1 V: 04-1] TopMenuBarCustomizer: Refactoring (039 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148638 (owner: 10Pwirth) [12:19:37] (03CR) 10SG: [C: 032] More robust API error reporting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148870 (https://bugzilla.wikimedia.org/68474) (owner: 10Spage) [12:20:09] (03Merged) 10jenkins-bot: More robust API error reporting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148870 (https://bugzilla.wikimedia.org/68474) (owner: 10Spage) [12:27:02] qgil: Security setup (and hence file permissions) is stuff to fix before enabling any production instance for anything, IMO. [12:28:02] andre__, your call. My (too?) basic analysis is: logged in users that can't do anything don't need the Maniphest security bits [12:28:38] andre__, BUT this is just me willing to go over #2 just because. No worries. :) [12:28:56] qgil: basically I agree. But I'm not sure if we could already screw up something with permissions just by enabling login. *Probably* not. [12:29:02] yeah, let me try to find out. thanks. [12:29:31] aklapper edited the description of T359: Decide which task statuses we want to have in Maniphest. http://fab.wmflabs.org/T359 [12:29:46] aklapper edited the description of T359: Decide which task statuses we want to have in Maniphest. http://fab.wmflabs.org/T359 [12:31:03] aklapper added a comment to T359: Decide which task statuses we want to have in Maniphest. http://fab.wmflabs.org/T359 [12:34:45] aklapper updated subscribers of T500: Allow tracking bugs. http://fab.wmflabs.org/T500 [12:37:12] (03CR) 10Rillke: "Springle, Umherirrender, could I address your concerns with the last patch sets?" [core] - 10https://gerrit.wikimedia.org/r/135756 (https://bugzilla.wikimedia.org/66412) (owner: 10Rillke) [12:40:56] (03PS1) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148987 [12:43:08] (03CR) 10Krinkle: [C: 04-1] "Sorry, but last I checked we are not enforcing "(cast) $var" vs. "(cast)$var". Both are tolerated at this time and neither is required or " [core] - 10https://gerrit.wikimedia.org/r/148062 (owner: 10Umherirrender) [12:44:53] (03CR) 10Krinkle: [C: 032] "Let's avoid it in the future. There's enough more important phpcs violations to get fixed. Merging though, it's part of a larger change." [core] - 10https://gerrit.wikimedia.org/r/148062 (owner: 10Umherirrender) [12:45:38] 3MediaWiki / 3Internationalization: Consider using content language for "html lang", rather than interface language - 10https://bugzilla.wikimedia.org/68490#c2 (10Nemo) (In reply to Niklas Laxström from comment #1) > The attribute closest to the > content wins. That's how HTML works. Thanks, I found a sourc... [12:45:42] (03CR) 10Krinkle: [C: 032] Doc: Reformat @params declaration [core] - 10https://gerrit.wikimedia.org/r/148982 (owner: 10Umherirrender) [12:45:58] (03PS1) 10Zfilipin: No longer running Ruby linter for Wikibase [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148988 [12:46:10] (03CR) 10Krinkle: [C: 032] Each line in a doc block should start with * [core] - 10https://gerrit.wikimedia.org/r/148961 (owner: 10Umherirrender) [12:47:41] (03PS1) 10Zfilipin: No longer running any jobs for qa/browsertests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148989 [12:48:01] (03PS2) 10Krinkle: Fix @deprecated of ImageGalleryBase [core] - 10https://gerrit.wikimedia.org/r/148849 (owner: 10Umherirrender) [12:48:10] (03CR) 10Krinkle: [C: 032] Fix @deprecated of ImageGalleryBase [core] - 10https://gerrit.wikimedia.org/r/148849 (owner: 10Umherirrender) [12:48:29] (03CR) 10Krinkle: "Should be "@deprecated since" , not "@deprecated in". Fixed in 1051c349a0e." [core] - 10https://gerrit.wikimedia.org/r/132667 (owner: 10MarkAHershberger) [12:49:08] (03CR) 10Robert Vogel: [C: 032 V: 032] BlueSpiceSkin/ExtendedSearch: Added some CSS [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/148955 (owner: 10Robert Vogel) [12:49:19] (03Merged) 10jenkins-bot: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/148062 (owner: 10Umherirrender) [12:49:22] (03Merged) 10jenkins-bot: Doc: Reformat @params declaration [core] - 10https://gerrit.wikimedia.org/r/148982 (owner: 10Umherirrender) [12:50:00] (03Merged) 10jenkins-bot: Each line in a doc block should start with * [core] - 10https://gerrit.wikimedia.org/r/148961 (owner: 10Umherirrender) [12:51:36] (replied tto by email) [12:52:43] (03Merged) 10jenkins-bot: Fix @deprecated of ImageGalleryBase [core] - 10https://gerrit.wikimedia.org/r/148849 (owner: 10Umherirrender) [12:52:58] (03PS1) 10Manybubbles: Move more escaping logic to Escaper [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148990 [12:54:00] (03CR) 10Manybubbles: "It'd be nice to not merge this before the branch today..... I'm pretty sure its fine but we may as well be careful and give it a week in " [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148990 (owner: 10Manybubbles) [12:54:24] (03CR) 10Manybubbles: "I'm getting some integration failures with this but its probably because of the new jobrunner in vagrant." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148990 (owner: 10Manybubbles) [12:58:58] (03CR) 10Umherirrender: "I have read it on [[mw:Manual:Coding conventions/PHP#Spaces]]:" [core] - 10https://gerrit.wikimedia.org/r/148062 (owner: 10Umherirrender) [13:08:38] (03PS1) 10Umherirrender: Cleanup some docs (languages, maintenance, tests) [core] - 10https://gerrit.wikimedia.org/r/148991 [13:13:41] 3MediaWiki extensions / 3Petition: Performance review of Petition extension before WMF deployment - 10https://bugzilla.wikimedia.org/65851 (10Peter Coombe) 5PATC>3RESO/FIX [13:13:55] 3Wikimedia / 3Extension setup: Review and deploy Petition extension to wikimediafoundation.org - 10https://bugzilla.wikimedia.org/65849 (10Peter Coombe) 5NEW>3RESO/FIX [13:27:36] 3MediaWiki extensions / 3WikidataClient: decouple watchlist and recent changes integration - 10https://bugzilla.wikimedia.org/67537 (10Lydia Pintscher) 5ASSI>3RESO/WON [13:28:24] 3MediaWiki extensions / 3WikidataClient: preferences do not respect showExternalRecentChanges setting - 10https://bugzilla.wikimedia.org/68463 (10Lydia Pintscher) [13:28:51] 3MediaWiki extensions / 3WikidataClient: the show/hide recent changes and watchlist toggle does not respect showExternalRecentChanges setting - 10https://bugzilla.wikimedia.org/68461 (10Lydia Pintscher) [13:29:41] (03CR) 10Cicalese: [C: 032 V: 032] made compatible with SemanticTitle [extensions/TitleIcon] - 10https://gerrit.wikimedia.org/r/148943 (owner: 10Cicalese) [13:36:28] otto committed rOPSPUPPET1b744e5e40fc: statistics: Add packages for rgdal (authored by yuvipanda). [13:48:08] (03CR) 10Reedy: "Presumably this is still wanted... Added Coren and Andrew to reviewers." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/68126 (owner: 10Ryan Lane) [13:50:38] (03PS1) 10Dbrant: Fix appearance of math formulae in Night mode. [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/148995 [13:50:39] 3MediaWiki extensions / 3VectorBeta: Local IME script selector conflicts with Compact personal bar - 10https://bugzilla.wikimedia.org/67613#c8 (10Siddhartha Ghai) As far as I know, the script seen here is basically an early form of the Narayam extension. I see that this script is being loaded by default for... [13:51:52] (03PS1) 10Aude: Remove @todo in SpecialPage for making it into ContextSource [core] - 10https://gerrit.wikimedia.org/r/148996 [13:52:38] (03CR) 10Qgil: "Could this old changeset be resolved in some way? MatmaRex had comments for improvement but he marked it as +1 (by mistake? or was Diederi" [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/90555 (owner: 10Diederik) [13:59:58] (03PS2) 10Umherirrender: Cleanup some docs (languages, maintenance, tests) [core] - 10https://gerrit.wikimedia.org/r/148991 [14:00:20] (03CR) 10Umherirrender: "Patch Set 2: Found another missing space" [core] - 10https://gerrit.wikimedia.org/r/148991 (owner: 10Umherirrender) [14:01:55] (03PS2) 10Dbrant: Fix appearance of math formulae in Night mode. [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/148995 [14:15:00] (03PS1) 10Giuseppe Lavagetto: Link the c++ lua library if building for HHVM [php/luasandbox] - 10https://gerrit.wikimedia.org/r/149001 [14:16:39] ori: are you doing more HHVM on beta labs? http://en.wikipedia.beta.wmflabs.org/w/api.php stopped responding recently [14:20:12] (03CR) 10Andrew Bogott: "I've tried to resize on the commandline a few times, and I've never seen it work -- often the instance is left unusable afterwards. I'll " [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/68126 (owner: 10Ryan Lane) [14:22:43] (03PS1) 10Rillke: Unify MIME in documentation and equip note with sense [core] - 10https://gerrit.wikimedia.org/r/149005 [14:23:10] (03CR) 10jenkins-bot: [V: 04-1] Unify MIME in documentation and equip note with sense [core] - 10https://gerrit.wikimedia.org/r/149005 (owner: 10Rillke) [14:24:22] (03CR) 10Alexandros Kosiaris: Link the c++ lua library if building for HHVM (031 comment) [php/luasandbox] - 10https://gerrit.wikimedia.org/r/149001 (owner: 10Giuseppe Lavagetto) [14:26:54] (03CR) 10Filippo Giunchedi: [C: 04-1] Link the c++ lua library if building for HHVM (032 comments) [php/luasandbox] - 10https://gerrit.wikimedia.org/r/149001 (owner: 10Giuseppe Lavagetto) [14:27:34] (03CR) 10Rillke: "Is there something wrong with jenkins-bot?" [core] - 10https://gerrit.wikimedia.org/r/149005 (owner: 10Rillke) [14:27:41] (03CR) 10Nikerabbit: Cleanup some docs (languages, maintenance, tests) (033 comments) [core] - 10https://gerrit.wikimedia.org/r/148991 (owner: 10Umherirrender) [14:30:06] 3MediaWiki-Vagrant: vagrant plugin install fails - 10https://bugzilla.wikimedia.org/68453#c5 (10Bryan Davis) (In reply to Bernd Sitzmann from comment #3) > I also see this a couple of time in there: > >> Installing Virtualbox Guest Additions 4.3.12 - guest version is 4.3.10 > Note that I have VirtualBox 4.3.12... [14:30:30] (03CR) 10Giuseppe Lavagetto: Link the c++ lua library if building for HHVM (033 comments) [php/luasandbox] - 10https://gerrit.wikimedia.org/r/149001 (owner: 10Giuseppe Lavagetto) [14:31:05] 3MediaWiki-Vagrant: vagrant vagrant-vbguest plugin install fails on Mac OS X - 10https://bugzilla.wikimedia.org/68453 (10Bryan Davis) [14:31:25] (03PS5) 10BryanDavis: Add GlobalCssJs role [vagrant] - 10https://gerrit.wikimedia.org/r/148920 (owner: 10Legoktm) [14:32:23] (03PS2) 10Giuseppe Lavagetto: Link the c++ lua library if building for HHVM [php/luasandbox] - 10https://gerrit.wikimedia.org/r/149001 [14:33:36] (03CR) 10BryanDavis: [C: 032] "Works for me now. Thanks Kunal." [vagrant] - 10https://gerrit.wikimedia.org/r/148920 (owner: 10Legoktm) [14:33:41] (03Merged) 10jenkins-bot: Add GlobalCssJs role [vagrant] - 10https://gerrit.wikimedia.org/r/148920 (owner: 10Legoktm) [14:34:32] (03PS1) 10Yurik: Updated to latest ZeroBanner [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/149008 [14:34:47] (03CR) 10jenkins-bot: [V: 04-1] Updated to latest ZeroBanner [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/149008 (owner: 10Yurik) [14:35:51] I cannot rebase a patchset: http://pastebin.de/128708 [14:36:13] (03PS1) 10Yurik: Updated to latest ZeroBanner [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/149009 [14:36:33] (03CR) 10jenkins-bot: [V: 04-1] Updated to latest ZeroBanner [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/149009 (owner: 10Yurik) [14:37:03] joe committed rOPSPUPPETf7d738dd0d57: Bump apc.shm_size to 360M (authored by reedy). [14:38:02] (03PS1) 10Yurik: Updated to latest ZeroBanner [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/149010 [14:39:12] (03CR) 10BryanDavis: [C: 04-1] "This needs a manual rebase now that I9ad7b25 has landed to give role::uploadwizard multiwiki support." (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/148505 (owner: 10Neilk) [14:40:23] (03PS1) 10Vikassy: Run language screenshot job manually [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149012 [14:41:58] (03CR) 10Rillke: "recheck" [core] - 10https://gerrit.wikimedia.org/r/149005 (owner: 10Rillke) [14:42:04] (03CR) 10Parent5446: Cleanup some docs (languages, maintenance, tests) (032 comments) [core] - 10https://gerrit.wikimedia.org/r/148991 (owner: 10Umherirrender) [14:42:24] (03CR) 10Giuseppe Lavagetto: [C: 032] Link the c++ lua library if building for HHVM [php/luasandbox] - 10https://gerrit.wikimedia.org/r/149001 (owner: 10Giuseppe Lavagetto) [14:42:27] (03PS1) 10Yurik: Updated to latest ZeroBanner [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/149013 [14:42:40] (03CR) 10jenkins-bot: [V: 04-1] Updated to latest ZeroBanner [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/149013 (owner: 10Yurik) [14:42:43] (03CR) 10BryanDavis: centralauth: Use hiera to allow variable customization (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/148317 (https://bugzilla.wikimedia.org/67331) (owner: 10BryanDavis) [14:43:00] (03CR) 10Yurik: [C: 032] Updated to latest ZeroBanner [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/149010 (owner: 10Yurik) [14:43:02] (03CR) 10jenkins-bot: [V: 04-1] Updated to latest ZeroBanner [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/149010 (owner: 10Yurik) [14:44:45] (03PS2) 10Vikassy: Run language screenshot job manually [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149012 [14:54:49] qgil created T502: Possibility to pair API documentation with user comments. http://fab.wmflabs.org/T502 [14:54:52] qgil updated tasks of T502: Possibility to pair API documentation with user comments. http://fab.wmflabs.org/T502 [14:54:52] qgil updated tasks of T489: Requirements for the Developer Hub infrastructure. http://fab.wmflabs.org/T489 [14:56:38] (03CR) 10Hashar: "recheck" [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/149008 (owner: 10Yurik) [14:56:58] (03PS1) 10Giuseppe Lavagetto: Version bump in the changelog [php/luasandbox] - 10https://gerrit.wikimedia.org/r/149016 [14:57:18] (03CR) 10Hashar: "recheck" [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/149008 (owner: 10Yurik) [14:57:42] (03CR) 10Giuseppe Lavagetto: [C: 032 V: 032] Version bump in the changelog [php/luasandbox] - 10https://gerrit.wikimedia.org/r/149016 (owner: 10Giuseppe Lavagetto) [14:59:24] 3MediaWiki extensions / 3GlobalCssJs: Global JS module version not updating properly - 10https://bugzilla.wikimedia.org/62602 (10Helder) 5RESO/?>3VERI [15:00:21] qgil added a comment to T489: Requirements for the Developer Hub infrastructure. http://fab.wmflabs.org/T489 [15:01:19] (03CR) 10Yurik: [V: 032] Updated to latest ZeroBanner [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/149010 (owner: 10Yurik) [15:05:00] (03CR) 10Reedy: [C: 032 V: 032] Updated to latest ZeroBanner [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/149013 (owner: 10Yurik) [15:07:34] (03CR) 10Hashar: [C: 04-1] "While at it, you might as well uppercase all occurrences of 'mime' in our code :)" [core] - 10https://gerrit.wikimedia.org/r/149005 (owner: 10Rillke) [15:08:21] 3Wikimedia / 3Site requests: 300GB of files on a hard disk in need of a URI or WMF direct upload - 10https://bugzilla.wikimedia.org/67477#c17 (10Fæ) Following up with Jeremy by email, but confirming here: Yes, I will take a copy of the files and keep them in the UK, as well as posting in the USB pocket disk... [15:09:38] (03CR) 10Alex Monk: SECURITY: Do checks on all upload types (031 comment) [core] - 10https://gerrit.wikimedia.org/r/64848 (owner: 10CSteipp) [15:13:16] (03CR) 10Rillke: "With "all occurrences" you mean "in all comments in all files"? Changing error messages may cause more trouble than good, I suspect." [core] - 10https://gerrit.wikimedia.org/r/149005 (owner: 10Rillke) [15:13:39] 3MediaWiki extensions / 3FundraisingChart: Security review for mediawiki/extensions/FundraisingChart - 10https://bugzilla.wikimedia.org/66805#c2 (10Greg Grossmeier) a:5fr-tech>3Chris Steipp For some reason this was assigned to fr-tech and not Chris. That's probably a cause for delay :) [15:13:40] (03PS1) 10BryanDavis: Revert "Make $wgScribuntoDefaultEngine default to 'luastandalone'" [vagrant] - 10https://gerrit.wikimedia.org/r/149025 [15:13:48] (03PS2) 10BryanDavis: Revert "Make $wgScribuntoDefaultEngine default to 'luastandalone'" [vagrant] - 10https://gerrit.wikimedia.org/r/149025 [15:14:05] 3MediaWiki extensions / 3FundraisingChart: Performance review for mediawiki/extensions/FundraisingChart - 10https://bugzilla.wikimedia.org/66806#c2 (10Greg Grossmeier) Since fr-tech isn't a person, and isn't a person who will be doing the review, resetting the assignee. [15:14:35] (03CR) 10BryanDavis: [C: 04-1] "Don't submit yet, but I'm testing a new hhvm-luasandbox build. /me knocks wood" [vagrant] - 10https://gerrit.wikimedia.org/r/149025 (owner: 10BryanDavis) [15:15:06] qgil updated subscribers of T488: Name for the 'developer hub'. http://fab.wmflabs.org/T488 [15:15:22] qgil updated subscribers of T488: Name for the 'developer hub'. http://fab.wmflabs.org/T488 [15:15:54] (03CR) 10Alex Monk: "Then you should probably make a new patch to use protocol-relative URLs here." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148881 (owner: 10Kaldari) [15:17:45] (03CR) 10Rillke: SECURITY: Do checks on all upload types (031 comment) [core] - 10https://gerrit.wikimedia.org/r/64848 (owner: 10CSteipp) [15:20:04] Gerrit Code Review committed rOPSPUPPET09c57b00a208: Merge "Tools: Install user-requested packages" into production (authored by andrewbogott). [15:20:53] 3MediaWiki extensions / 3[other]: FundraisingChart should pass jshint - 10https://bugzilla.wikimedia.org/66192#c11 (10Sam Reed (reedy)) 5PATC>3RESO/FIX Is this all done now? [15:20:58] (03PS5) 10Rillke: Attaching Hooks to tweak MIME type detection [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/141241 [15:21:00] (03CR) 10jenkins-bot: [V: 04-1] Attaching Hooks to tweak MIME type detection [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/141241 (owner: 10Rillke) [15:22:08] 3MediaWiki extensions / 3FundraisingChart: Localisation in FundraisingChart - 10https://bugzilla.wikimedia.org/68509 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3fr-tech The extension doesn't look very i18n friendly. I'm not sure how much of an issue this actually is, but presumably it should be... [15:23:37] 3MediaWiki extensions / 3Scribunto: HHVM crash loading San Francisco page - 10https://bugzilla.wikimedia.org/68196#c15 (10Giuseppe Lavagetto) 5UNCO>3PATC (In reply to Tim Starling from comment #14) > On hhvm.256.io, I have installed a LuaSandbox statically linked against Lua > compiled as C++. With this... [15:23:47] (03CR) 10Hashar: "In all comments indeed. If you suspect changing the case in error message is going to cause a trouble, just create a second patch :]" [core] - 10https://gerrit.wikimedia.org/r/149005 (owner: 10Rillke) [15:25:06] 3Wikimedia / 3Extension setup: Review & deploy mediawiki/extensions/FundraisingChart - 10https://bugzilla.wikimedia.org/65834 (10Sam Reed (reedy)) [15:25:08] 3MediaWiki extensions / 3FundraisingChart: Unused code in FundraisingChart - 10https://bugzilla.wikimedia.org/68510 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3fr-tech Can you delete any unused code in the extension? Now it's in git, the code can be rescued from history at a later date if still... [15:25:24] 3MediaWiki extensions / 3FundraisingChart: Unused code in FundraisingChart - 10https://bugzilla.wikimedia.org/68510 (10Sam Reed (reedy)) [15:25:24] 3MediaWiki extensions / 3FundraisingChart: frChartDataSetFetch is unused - 10https://bugzilla.wikimedia.org/66836 (10Sam Reed (reedy)) [15:27:11] greg created T503: Make phabot use colors!. http://fab.wmflabs.org/T503 [15:31:18] (03PS6) 10Rillke: Attaching Hooks to tweak MIME type detection [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/141241 [15:31:52] (03CR) 10Rillke: Attaching Hooks to tweak MIME type detection (031 comment) [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/141241 (owner: 10Rillke) [15:32:17] (03PS1) 10Smuggli: Implemented changes for translatewiki [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/149027 [15:34:04] (03PS1) 10Umherirrender: Avoid function calls in a FOR loop test part [core] - 10https://gerrit.wikimedia.org/r/149028 [15:39:17] (03CR) 10Helder.wiki: Support global group change notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/88683 (https://bugzilla.wikimedia.org/51541) (owner: 10Legoktm) [15:40:15] gwicke added a comment to T502: Possibility to pair API documentation with user comments. http://fab.wmflabs.org/T502 [15:42:58] (03PS1) 10Cmcmahon: WIP: duplicate of existing patch [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149030 [15:47:05] (03Abandoned) 10Cmcmahon: WIP: duplicate of existing patch [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149030 (owner: 10Cmcmahon) [16:03:06] 3MediaWiki extensions / 3Scribunto: HHVM crash loading San Francisco page - 10https://bugzilla.wikimedia.org/68196#c16 (10Bryan Davis) Cross post from https://bugzilla.wikimedia.org/show_bug.cgi?id=68413#c8 : Updated beta servers to hhvm-luasandbox 2.0-3 build, changed config back to luasandbox and restarte... [16:04:21] 3MediaWiki / 3Skin and page rendering: Images with border parameter should display captions - 10https://bugzilla.wikimedia.org/68468#c12 (10James Forrester) (In reply to Erwin Dokter from comment #11) > (In reply to James Forrester from comment #10) > > Border only applies to "none"/basic and "frameless" ima... [16:15:26] 3MediaWiki extensions / 3MassMessage: MassMessage: Please include an easy way to mark the language (and language direction: LTR vs RTL) for a message - 10https://bugzilla.wikimedia.org/68512 (10WhatamIdoing) 3NEW p:3Unprio s:3enhanc a:3None I request the addition of an easy method for marking an ent... [16:20:08] 3MediaWiki extensions / 3MassMessage: MassMessage: Please include an easy way to add a timestamp at the end of the message - 10https://bugzilla.wikimedia.org/68513 (10WhatamIdoing) 3NEW p:3Unprio s:3enhanc a:3None I request the addition of an easy method for adding a timestamp to the very end of a m... [16:24:32] (03Abandoned) 10Bartosz Dziewoński: Merge commit '3a8081b030fb29dc9bf70b7b13de7d8519db02bd' into test [core] - 10https://gerrit.wikimedia.org/r/148774 (owner: 10Bartosz Dziewoński) [16:24:51] (03PS3) 10Dbrant: Fix appearance of images in Night mode. [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/148995 [16:28:56] 3Wikimedia / 3Bugzilla: new components for Pywikibot - 10https://bugzilla.wikimedia.org/68514 (10Ricordisamoa) 3NEW p:3Unprio s:3normal a:3None * xmlreader * textlib Maybe also: * tests [16:31:07] (03PS3) 10Hashar: Add jobs for analytics/quarry/web [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/148361 (owner: 10Legoktm) [16:31:51] reedy committed rFLOWb989d5c140e6: Creating new wmf/1.24wmf15 branch (authored by reedy). [16:32:06] wikiphabot: Whoa [16:32:39] 3MediaWiki / 3API: api generator query does not preserve search result order - 10https://bugzilla.wikimedia.org/68515 (10Jörn Hees) 3NEW p:3Unprio s:3normal a:3None If i search Wikipedia for something like "cain abel" the results are ordered: https://en.wikipedia.org/w/index.php?title=Special%3ASearc... [16:32:40] (03CR) 10Hashar: [C: 032] "Jobs deployed :-]" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/148361 (owner: 10Legoktm) [16:33:07] (03PS2) 10Hashar: Add zuul config for analytics/quarry/web [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148362 (owner: 10Legoktm) [16:35:37] 3Wikimedia / 3Bugzilla: new components for Pywikibot - 10https://bugzilla.wikimedia.org/68514#c1 (10Amir Ladsgroup) I'm in favor of tests too [16:36:23] 3MediaWiki-Vagrant: vagrant vagrant-vbguest plugin install fails on Mac OS X - 10https://bugzilla.wikimedia.org/68453#c6 (10Bernd Sitzmann) Thanks! I've updated both VirtualBox to the latest 4.3.14 and did the vagrant git-update. Still getting similar errors: http://pastebin.com/66fHgip8 Again "Uncaught exce... [16:36:39] 3Wikimedia / 3Bugzilla: new components for Pywikibot - 10https://bugzilla.wikimedia.org/68514#c2 (10Thehelpfulone) 5NEW>3ASSI a:3Thehelpfulone Thanks, created the first two - should the tests one just be tests or tests.py? [16:37:50] (03Merged) 10jenkins-bot: Add jobs for analytics/quarry/web [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/148361 (owner: 10Legoktm) [16:41:56] Reedy: can you approve my OAuth request thing? [16:42:46] I don't think I've got the rights to... [16:42:59] Reedy: oh. sigh. [16:43:04] Let me check [16:45:11] reedy committed rGUIDEDTOUR340c1aeeabe3: Creating new wmf/1.24wmf15 branch (authored by reedy). [16:45:28] (03CR) 10Hashar: [C: 032] "deploying" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148362 (owner: 10Legoktm) [16:45:32] YuviPanda: there's a user group on mw.org that has the rights [16:45:33] (03Merged) 10jenkins-bot: Add zuul config for analytics/quarry/web [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148362 (owner: 10Legoktm) [16:46:08] https://www.mediawiki.org/w/index.php?title=Special%3AListUsers&username=&group=oauthadmin&limit=50 [16:46:13] YuviPanda: these people can ^ [16:46:34] MatmaRex: ah, cool [16:47:51] 3Wikimedia / 3Bugzilla: new components for Pywikibot - 10https://bugzilla.wikimedia.org/68514#c3 (10Ricordisamoa) We don't have any tests.py in our repository ;-) "tests" will cover, e.g., bug 60214. Thank you! [16:48:23] bd808:one question for centralauth in vagrant [16:48:23] YuviPanda: Ah, it seems I do [16:48:32] Reedy: yeah, I think anyone with staff does? [16:48:36] "now" [16:48:39] 0.2 or 0.3? [16:48:40] Or boht? [16:48:52] Reedy: 0.3 [16:49:19] Does 0.2 want rejecting? [16:49:23] 3Wikimedia / 3Bugzilla: new components for Pywikibot - 10https://bugzilla.wikimedia.org/68514#c4 (10Thehelpfulone) 5ASSI>3RESO/FIX Heh, a quick Google did find test.py though! Done. [16:50:58] (03PS2) 10Mwalker: Allow file copies across file systems [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/148744 [16:51:04] (03PS2) 10EBernhardson: Update xhprof module [vagrant] - 10https://gerrit.wikimedia.org/r/148874 [16:51:32] Reedy: yeah [16:52:59] (03CR) 10Mwalker: [C: 032] Allow file copies across file systems [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/148744 (owner: 10Mwalker) [16:53:15] (03Merged) 10jenkins-bot: Allow file copies across file systems [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/148744 (owner: 10Mwalker) [17:03:46] (03PS1) 10Umherirrender: Break some long lines in maintenance, skins, tests [core] - 10https://gerrit.wikimedia.org/r/149044 [17:05:02] (03PS1) 10Vikassy: WIP: Language screenshot runs only for language screenshot job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149045 (https://bugzilla.wikimedia.org/68467) [17:11:21] hey guys, just a quick question, am I supposed to follow https://www.mediawiki.org/wiki/Gerrit/Tutorial#How_to_submit_a_patch when my code has been reviewed, and I need to make a few slight modifications? [17:11:54] TheDJ updated subscribers of T359: Decide which task statuses we want to have in Maniphest. http://fab.wmflabs.org/T359 [17:12:18] (03CR) 10Jdlrobson: [C: 032] Add styling for the styleguide [core] - 10https://gerrit.wikimedia.org/r/148626 (owner: 10Prtksxna) [17:12:44] (03PS1) 10Ori.livneh: Fix use of undefined const NS_TIMEDTEXT [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/149046 [17:12:53] gi11es, marktraceur, tgr ^ [17:15:20] (03Merged) 10jenkins-bot: Add styling for the styleguide [core] - 10https://gerrit.wikimedia.org/r/148626 (owner: 10Prtksxna) [17:18:52] (03PS3) 10Umherirrender: Cleanup some docs (languages, maintenance, tests) [core] - 10https://gerrit.wikimedia.org/r/148991 [17:19:32] (03CR) 10Umherirrender: "Patch Set 3: Addressed inline comments" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/148991 (owner: 10Umherirrender) [17:20:33] ori committed rOPSPUPPET5e3f369cb93d: apache::monitoring: add diamond support; ensure mod_status is enabled (authored by ori). [17:22:26] (03PS2) 10Aaron Schulz: Set serializer to NONE and bumped the aggregation keys [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148134 [17:23:55] (03PS1) 10Aaron Schulz: Fixed JobQueueAggregatorRedis to handle empty collections [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/149054 [17:24:20] (03CR) 10Cscott: "@Florianschmidtwelzow could you review the latest version?" [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [17:25:07] (03CR) 10jenkins-bot: [V: 04-1] Cleanup some docs (languages, maintenance, tests) [core] - 10https://gerrit.wikimedia.org/r/148991 (owner: 10Umherirrender) [17:26:48] msyed updated subscribers of T488: Name for the 'developer hub'. http://fab.wmflabs.org/T488 [17:33:52] (03PS4) 10Umherirrender: Cleanup some docs (languages, maintenance, tests) [core] - 10https://gerrit.wikimedia.org/r/148991 [17:35:33] Mwalker committed rOPSPUPPETf71fa0d4fc88: Add OCG servers to the PDF ganglia cluster (authored by Mwalker). [17:36:15] oh no... now I'm going to get pinged twice for every patch [17:37:03] (03PS2) 10Rillke: Unify MIME in documentation and equip note with sense [core] - 10https://gerrit.wikimedia.org/r/149005 [17:39:22] (03CR) 10Rillke: "At your service, hashar." [core] - 10https://gerrit.wikimedia.org/r/149005 (owner: 10Rillke) [17:40:07] (03PS3) 10Rillke: Unify the spelling of MIME in documentation [core] - 10https://gerrit.wikimedia.org/r/149005 [17:40:39] 3MediaWiki extensions / 3WikidataRepo: Exception from line 245 in EntityHandler.php: EntityContent does not support plain title based redirects - 10https://bugzilla.wikimedia.org/68517 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs /w/index.php?title=Special:MergeHistory&action=submit Exception... [17:40:50] (03CR) 10Brion VIBBER: [C: 031] "looks good, lemme test..." [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/148995 (owner: 10Dbrant) [17:41:37] 3MediaWiki-Vagrant: HHVM Failed Assertion: assertion `false && "Unsupported DataType"' failed. - 10https://bugzilla.wikimedia.org/68491 (10Brett Simmers) 5NEW>3ASSI a:5Ori Livneh>3Brett Simmers [17:41:52] 3MediaWiki / 3Special pages: (Special:AllMessages) Find a better query for searching translations in translatewiki.net - 10https://bugzilla.wikimedia.org/68518 (10Sorawee Porncharoenwase) 3NEW p:3Unprio s:3normal a:3None Note: I'm not sure if this bug should belong to translatewiki or MediaWiki. If y... [17:41:58] (03PS3) 10BryanDavis: Update xhprof module [vagrant] - 10https://gerrit.wikimedia.org/r/148874 (owner: 10EBernhardson) [17:41:59] (03CR) 10Rillke: [C: 04-1] "Needs unit tests." [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/141241 (owner: 10Rillke) [17:42:06] (03CR) 10BryanDavis: [C: 032] Update xhprof module [vagrant] - 10https://gerrit.wikimedia.org/r/148874 (owner: 10EBernhardson) [17:42:14] (03Merged) 10jenkins-bot: Update xhprof module [vagrant] - 10https://gerrit.wikimedia.org/r/148874 (owner: 10EBernhardson) [17:45:40] (03PS1) 10Umherirrender: Cleanup some docs (includes/*.php) [core] - 10https://gerrit.wikimedia.org/r/149061 [17:45:42] (03PS1) 10Umherirrender: Cleanup some docs (includes/[a-d]) [core] - 10https://gerrit.wikimedia.org/r/149062 [17:45:44] (03PS1) 10Umherirrender: Cleanup some docs (includes/[e-l]) [core] - 10https://gerrit.wikimedia.org/r/149063 [17:45:46] (03PS1) 10Umherirrender: Cleanup some docs (includes/[m-r]) [core] - 10https://gerrit.wikimedia.org/r/149064 [17:45:48] (03PS1) 10Umherirrender: Cleanup some docs (includes/[s-z]) [core] - 10https://gerrit.wikimedia.org/r/149065 [17:46:06] (03CR) 10Florianschmidtwelzow: [C: 04-1] "> could you review the latest version?" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [17:47:09] (03CR) 10Ori.livneh: [C: 032] Set serializer to NONE and bumped the aggregation keys [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148134 (owner: 10Aaron Schulz) [17:47:43] (03CR) 10Brion VIBBER: [C: 032] Fix appearance of images in Night mode. [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/148995 (owner: 10Dbrant) [17:48:54] Gerrit Code Review committed rOPSPUPPET630a52f44ec6: Merge "admin: fix my bash aliases" into production (authored by ori). [17:49:38] (03Merged) 10jenkins-bot: Set serializer to NONE and bumped the aggregation keys [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148134 (owner: 10Aaron Schulz) [17:49:52] (03Abandoned) 10Werdna: Fix "page is fully loaded" condition again [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148851 (owner: 10Werdna) [17:50:24] In Gerrit comments, is there a special way to do line-by-line comments? I got an emailed comment from Gerrit where "Line:" comments were included, but they aren't on Gerrit itself. [17:50:33] (03PS5) 10Umherirrender: Cleanup some docs (languages, maintenance, tests) [core] - 10https://gerrit.wikimedia.org/r/148991 [17:51:22] (03PS9) 10Ebe123: Create preferences to watchlist pages after rollbacking and undoing [core] - 10https://gerrit.wikimedia.org/r/146440 (https://bugzilla.wikimedia.org/4488) [17:51:31] (03CR) 10Umherirrender: "Patch Set 5: Also adjust function doc for findVariantLink in LanguageConverter and Language*.php classes." [core] - 10https://gerrit.wikimedia.org/r/148991 (owner: 10Umherirrender) [17:52:24] (03PS2) 10Werdna: WIP, QA: Lots of browser test fixes. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148854 [17:52:27] (03CR) 10Nemo bis: "As you filed bug 68518 and you say this is no longer your proposed solution, can you click the "abandon" button here please?" [core] - 10https://gerrit.wikimedia.org/r/141728 (owner: 10Nullzero) [17:52:39] Oh, never mind, I figured it out. Those are in the side-by-side diff view. [17:52:50] neilk_ Can you give the gerrit link? (Just for interest :)) [17:53:04] FlorianSW: I figured it out -- https://gerrit.wikimedia.org/r/#/c/148505/3/puppet/manifests/roles/uploadwizard.pp [17:53:35] neilk_ Yes, that's an inline comment :) You can add it with a double click on a line, you know? :) [17:53:40] FlorianSW: I do now [17:53:55] neilk_ Great :D Happy reviewing! :) [17:54:15] FlorianSW: I am surprised about another thing though, it got batched in somehow with a regular comment on the whole thing [17:54:49] FlorianSW: that is, I got an email with a comment about the whole change & then the Line comment. I would have assumed those would be two emails since it's two actions on Gerrit (?) [17:55:13] neilk_ No, it's "one" action :) [17:55:24] neilk_: line comments are saved as draft and published when you make a real comment [17:55:28] neilk_ You first create drafts for all your inline comments [17:55:42] and then you save them in one review / add comment process @neilk_ [17:55:47] damn tgr was faster :D [17:55:50] FlorianSW, tgr: oh. That's actually pretty nice. [17:55:57] neilk_ Yeah :D [17:56:15] FlorianSW, tgr: it's almost like we're using email to help people rather than spam them with a zillion notifications [17:56:18] neilk_ So you have the chance to edit your comments for the time you save them ;) after save no chance :) [17:57:04] Nemo_bis: Is there a way to mark an i18n message as fuzzy without changing the en version? [17:57:14] I thought Gerrit was kind of ridiculous before (amending seems to destroy history in a way) but it is much more like how humans want to work [17:57:18] for new qqq instructions [17:57:33] or does that happen automatically? [17:57:39] (03Abandoned) 10Nullzero: Link to corresponding message in translatewiki directly [core] - 10https://gerrit.wikimedia.org/r/141728 (owner: 10Nullzero) [17:58:55] kaldari: fuzzying is done on a case by case basis by Raimond, you can simply prepend !!FUZZY!! if needed [17:59:44] neilk_ "amending seems to destroy history in a way" you mean? If you amend a change you create a new patchset, the patchsets in a change is the history of the change. If the change get aprooved the last ps will be merged into git. I don't understand what history you mean :D [17:59:46] I assume you're talking of special:mylanguage links; you can add him to reviewers to be sure he remembers, or ask me if he forgets [18:00:50] 3MediaWiki / 3API: incomplete page title in ApiParse->getSectionContent() error message - 10https://bugzilla.wikimedia.org/68416#c3 (10Umherirrender) 5PATC>3RESO/FIX was successfully merged [18:01:12] Nemo_bis: So I prepend !!FUZZY!! to the qqq message or the en message? [18:01:32] FlorianSW: well, maybe I do not understand git at a deep enough level, but let's say I were to do an ordinary git clone of the mediawiki repo, would I be able to know the history of patches? [18:01:46] FlorianSW: since they are amended they lose that history [18:01:54] FlorianSW: as far as I know [18:03:13] neilk_ why would you not see the list of commits? Just use git log or see the history of commits on git.wikimedia.org [18:03:56] i don't know, what you mean with amending here, --amend is a parameter to commit a change as a new version of another commit :) [18:03:59] @neilk_ [18:04:07] (03PS14) 10Ebe123: Enable the creation of empty pages [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) [18:04:41] (03CR) 10Ebe123: Enable the creation of empty pages (032 comments) [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [18:04:44] Gerrit Code Review committed rOPSPUPPETe39638624217: Merge "protoproxy: don't include apache::monitoring" into production (authored by ori). [18:04:44] ori committed rOPSPUPPETc267bc9b5d52: protoproxy: don't include apache::monitoring (authored by ori). [18:05:50] kaldari: to the messages to be fuzzied, on the wiki [18:06:01] oh [18:07:05] 3MediaWiki-Vagrant: vagrant vagrant-vbguest plugin install fails on Mac OS X - 10https://bugzilla.wikimedia.org/68453#c7 (10Bryan Davis) (In reply to Bernd Sitzmann from comment #6) > Thanks! I've updated both VirtualBox to the latest 4.3.14 and did the > vagrant git-update. > > Still getting similar errors:... [18:07:56] (03PS4) 10Jdlrobson: Improve collapse functionality, and improve various collapsed states' styles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147524 (owner: 10SG) [18:07:58] (03PS8) 10Jdlrobson: Adjust collapser capabilities and allow its use on post elements [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145200 [18:10:04] FlorianSW: I am not sure if we're talking about the same things. Take https://gerrit.wikimedia.org/r/#/c/68835/, which has been in development for over a year with >33 patches from multiple people. If I switch to the equivalent branch in git, it still looks like one commit. [18:10:21] (03CR) 10Jdlrobson: [C: 032] Improve collapse functionality, and improve various collapsed states' styles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147524 (owner: 10SG) [18:10:36] neilk_ no, i think we talk about the same thing :) And yes, that's the right behavior ;) [18:10:53] (03Merged) 10jenkins-bot: Improve collapse functionality, and improve various collapsed states' styles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147524 (owner: 10SG) [18:10:59] Because only the last patchset is the one which get approved to merge into git repository [18:11:06] 3MediaWiki extensions / 3Translate: Add support for ElasticSearch backend for ttmserver - 10https://bugzilla.wikimedia.org/52993#c1 (10Nemo) 5NEW>3ASSI a:3Niklas Laxström Merged: f0d28a74dcb8ca3bc6b79e92e668bc1b9d2eac03 fe22ddf52c9693c46e354f451c93d8612d9f72af See also: http://laxstrom.name/blag/2014/... [18:11:23] (03CR) 10Jdlrobson: [C: 031] "Looks fine to me.." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145200 (owner: 10Jdlrobson) [18:11:27] The other s have some erros or other faults, so they never go into the repository (why it's maybe crap :P). [18:11:36] jdlrobson committed rFLOW201bea9b6ccc: Improve collapse functionality, and improve various collapsed states' styles (authored by SG). [18:11:38] That's part of the reviewing proces, neilk_ [18:12:05] neilk_ only approved code comes into git repository available for Wikimedia and third party wikis (only this code get deployed) [18:12:18] FlorianSW: I understand the process - you didn't understand what I said about it. [18:12:26] neilk_ ok, maybe :D [18:12:29] neilk_: You're right that that information is essentially lost [18:12:38] You can't retrieve it from a vanilla checkout of MW [18:12:45] RoanKattouw: thanks. Yes. :) [18:12:57] However, it is available on our Gerrit server and it does allow you to fetch arbitrary patchsets [18:13:04] (03PS7) 10Robmoen: Make profile icon gender neutral and remove from login link [core] - 10https://gerrit.wikimedia.org/r/146979 (https://bugzilla.wikimedia.org/41484) [18:13:07] It just doesn't do so by default (partly for bloat reasons [18:13:15] (03PS1) 10EBernhardson: Reset preview when submitting new topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149070 (https://bugzilla.wikimedia.org/68131) [18:13:39] 3MediaWiki / 3Special pages: (Special:AllMessages) Find a better query for searching translations in translatewiki.net - 10https://bugzilla.wikimedia.org/68518#c1 (10Nemo) translatewiki.net is no longer using Solr since https://gerrit.wikimedia.org/r/#/c/145437/ (cf. bug 52993 - Add support for ElasticSearch... [18:14:16] RoanKattouw: does Gerrit manage all the patches in a git repo somehow, or does it use something else? [18:14:28] Yes it does store them in git [18:14:45] RoanKattouw: well it can't be reading patches out from the amended commit, they're gone...? [18:16:03] They're not gone gone [18:16:10] It's just that... [18:16:11] OK [18:16:21] So in git, you can have commits floating essentially in a void [18:16:23] (03CR) 10Florianschmidtwelzow: "Again one little thing :)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [18:16:31] A commit needs to have a parent (the commit it's based on) [18:16:37] But it may or may not have commits based on it [18:17:04] The only thing that's special about "the" commit that gets "merged" is that we update the "master" pointer to point to it, and then when later things get merged they are based on it [18:17:18] who is running wikiphabot? it's duplicating random stuff that shouldn't be in this channel [18:17:25] So there's a "master" pointer which points to the most recent "canonical" commit, and from there it's a chain of commits back down to the beginning of time [18:17:45] The only thing that makes a commit "part of history" is that it's somewhere along that chain from "now" back to "creation" [18:18:17] But you can totally have commits that aren't along that chain [18:18:30] (03PS5) 10Kaldari: Making use of Special:MyLanguage for Terms of Use and Privacy links [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148881 [18:18:47] Branches are a case of that too. You can have multiple "now"s with different names, and each one will have its own history chain, which usually converges with "master" at some point [18:18:53] neilk_: Am I making sense? [18:19:07] <^d> lol git, why did we ever? [18:19:27] RoanKattouw: ok so if I understand correctly, git keeps commits (trees of blobs) around no matter what. An amended commit detaches it from history. But Gerrit keeps that history alive in other ways. And presumably doesn't allow you to clean the repo. :) [18:20:34] Yes [18:20:52] Keeping something alive is as easy as retaining a pointer to it, or to something that depends on it [18:21:08] So Gerrit keeps around a bunch of refs called refs/changes/45/12345/2 (for PS2 of change 12345) [18:21:15] RoanKattouw: ahhh [18:21:28] (I'm sorry if I just re-explained a bunch of git stuff you already knew) [18:21:31] why do mediawiki's svg thumbnails suck so bad?: [18:21:44] (03CR) 10Bsitu: Break notifications into alert and message sections (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 (owner: 10Bsitu) [18:21:50] RoanKattouw: no, I understand git a bit better than most but not that well [18:22:00] RoanKattouw: thanks! [18:22:06] neilk_: And in fact, you can run git fetch origin refs/changes/45/12345/1 && git checkout FETCH_HEAD and in fact that is precisely the implementation of git review -d 12345 [18:22:24] (except that git review -d would first make an API call to find the latest patchset number) [18:23:18] (03CR) 10Aaron Schulz: [C: 04-1] Configuration rewrite, part 1 [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148280 (owner: 10MaxSem) [18:23:22] There is some command where you can do something like 'git fetch refs/changes/*' or whatever (I forget the exact syntax, it's not that) and that'll fetch absolutely all of them [18:23:28] RoanKattouw: wow. That's awesomely simple [18:23:32] (03CR) 10Aaron Schulz: Configuration rewrite, part 1 (031 comment) [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148280 (owner: 10MaxSem) [18:23:43] (03CR) 10Florianschmidtwelzow: "> Again one little thing :)" [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [18:23:52] Which is a massive amount of data and there's a good reason that only like two people are known to have ever done that [18:24:35] (03CR) 10Aaron Schulz: "Where is the accompanying puppet change btw?" [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148280 (owner: 10MaxSem) [18:25:17] @RoanKattouw: Why someone want to do that :D [18:25:50] (03CR) 10Aaron Schulz: [C: 032] Fixed JobQueueAggregatorRedis to handle empty collections [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/149054 (owner: 10Aaron Schulz) [18:26:39] FlorianSW: Backups before we had real backups; and analytics [18:27:00] RoanKattouw: Wow :) thx for info. [18:27:07] RoanKattouw: heh, that'll also be nice to do analytics on :D [18:27:08] 3MediaWiki extensions / 3GlobalCssJs: Global CSS and JS should not be loaded on [[Special:Preferences]] and [[Special:UserLogin]] - 10https://bugzilla.wikimedia.org/68521 (10Helder) 3NEW p:3Unprio s:3major a:3None My global JS is being loaded at http://meta.wikimedia.beta.wmflabs.org/wiki/Special:Pre... [18:27:16] RoanKattouw: assuming it doesn't kill gerrit [18:27:20] And when I say I know about people doing it, I mean like two years ago [18:27:24] When there was much much less data [18:27:37] (03PS2) 10Legoktm: Add zuul config for a bunch of extensions I maintain [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148352 [18:27:40] (03PS1) 10Mattflaschen: Have GettingStarted depend on CirrusSearch [vagrant] - 10https://gerrit.wikimedia.org/r/149075 [18:28:20] (03Merged) 10jenkins-bot: Fixed JobQueueAggregatorRedis to handle empty collections [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/149054 (owner: 10Aaron Schulz) [18:35:42] (03CR) 10Ori.livneh: [C: 032] Have GettingStarted depend on CirrusSearch [vagrant] - 10https://gerrit.wikimedia.org/r/149075 (owner: 10Mattflaschen) [18:35:44] (03CR) 10Jdlrobson: [C: 031] "ideological difference. Respond. Let's resolve. Then i'll merge." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148983 (owner: 10SG) [18:35:47] (03Merged) 10jenkins-bot: Have GettingStarted depend on CirrusSearch [vagrant] - 10https://gerrit.wikimedia.org/r/149075 (owner: 10Mattflaschen) [18:36:37] <^d> RoanKattouw: Should be `git fetch origin refs/changes/*:refs/changes/*` [18:36:41] <^d> Or something like that. [18:39:38] 3MediaWiki extensions / 3Gadgets: Special:Userlogin loads mw gadget scripts - potential security vulnerability - 10https://bugzilla.wikimedia.org/22929 (10Helder) [18:39:38] 3MediaWiki extensions / 3GlobalCssJs: Global CSS and JS should not be loaded on [[Special:Preferences]] and [[Special:UserLogin]] - 10https://bugzilla.wikimedia.org/68521#c1 (10Helder) The fix would probably be similar to https://www.mediawiki.org/wiki/Special:Code/MediaWiki/64670 [18:40:24] legoktm: ^ [18:40:42] yeah, I'm looking into it :) [18:40:52] great! :-) [18:40:56] 3MediaWiki extensions / 3GlobalCssJs: Global CSS and JS should not be loaded on [[Special:Preferences]] and [[Special:UserLogin]] - 10https://bugzilla.wikimedia.org/68521#c2 (10Kunal Mehta (Legoktm)) OutputPage::makeResourceLoaderLink should handle this properly, I'm looking into why it isn't. [18:41:28] jdlrobson: https://gerrit.wikimedia.org/r/149077 [18:41:31] wrong room :P [18:42:20] 3MediaWiki / 3ResourceLoader: Load user javascript on Special:Preferences - 10https://bugzilla.wikimedia.org/48931 (10Helder) [18:42:21] 3MediaWiki extensions / 3GlobalCssJs: Global CSS and JS should not be loaded on [[Special:Preferences]] and [[Special:UserLogin]] - 10https://bugzilla.wikimedia.org/68521 (10Helder) [18:42:37] 3MediaWiki extensions / 3Translate: Fatal error: Call to a member function getLanguage() on a non-object WikiPageMessageGroup.php on line 138 - 10https://bugzilla.wikimedia.org/68523 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3None [2014-07-24 18:41:09] Fatal error: Call to a member function get... [18:42:42] (03CR) 10Mattflaschen: "This is probably going to keep getting un-mergable. So can we first figure out if it's safe to merge before we have browser tests?" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/144456 (owner: 10Phuedx) [18:46:15] (03CR) 10Jdlrobson: [C: 032] Adjust collapser capabilities and allow its use on post elements [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145200 (owner: 10Jdlrobson) [18:46:53] (03Merged) 10jenkins-bot: Adjust collapser capabilities and allow its use on post elements [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145200 (owner: 10Jdlrobson) [18:47:10] jdlrobson committed rFLOW943252b4fc5a: Adjust collapser capabilities and allow its use on post elements (authored by SG). [18:48:52] hmmmm [18:49:05] Krinkle: is there a reason https://github.com/wikimedia/mediawiki-core/blob/master/includes/OutputPage.php#L2726 doesn't handle TYPE_COMBINED? I think that's causing https://bugzilla.wikimedia.org/68521 [18:49:17] does wikiphabot strike anybody else as not very useful when it's just repeating what grrrit-wm says? [18:49:32] i mean it's cool that we have a bot to do this already, that's awesome [18:49:41] but one would suffice :) [18:49:58] (03PS1) 10Catrope: Apply bidi styles to references in Parsoid styles [core] - 10https://gerrit.wikimedia.org/r/149081 [18:50:08] legoktm: Hm.. [18:50:18] legoktm: I don't think this method is supposed to be used for combined though. [18:50:27] Wouldn't one use mw.loader.load in that case :-) [18:50:32] (03CR) 10Aaron Schulz: [C: 032] Cleanup some docs (includes/[s-z]) [core] - 10https://gerrit.wikimedia.org/r/149065 (owner: 10Umherirrender) [18:50:34] (I know, we've been there before) [18:50:58] :P [18:51:29] (03CR) 10Aaron Schulz: [C: 032] Cleanup some docs (includes/*.php) [core] - 10https://gerrit.wikimedia.org/r/149061 (owner: 10Umherirrender) [18:51:56] (03CR) 10Aaron Schulz: [C: 032] Cleanup some docs (includes/[a-d]) [core] - 10https://gerrit.wikimedia.org/r/149062 (owner: 10Umherirrender) [18:52:17] (03PS1) 10Taueres: Add test cases for wfAppendQuery [core] - 10https://gerrit.wikimedia.org/r/149082 [18:53:06] Krinkle: so what would you recommend doing? should I just add TYPE_COMBINED into that check? [18:53:27] legoktm: I'm not sure. Need to give it some thought. [18:53:42] legoktm: that global css/js code isn't in production yet, right? [18:53:59] uhh, it's on test and test2 [18:54:04] we should probably disable it [18:54:17] legoktm: And we're not enabling sitejscss right, only user? [18:54:17] it would have gotten deployed today [18:54:21] only user [18:54:30] Is it disabled by default? [18:54:35] (extension, or wmf-config?) [18:54:46] (03Merged) 10jenkins-bot: Cleanup some docs (includes/*.php) [core] - 10https://gerrit.wikimedia.org/r/149061 (owner: 10Umherirrender) [18:54:47] the site part [18:54:55] Gerrit Code Review committed rOPSPUPPETc3149ce759dd: Merge "ircecho: qualify var" into production (authored by dzahn). [18:55:02] (03Merged) 10jenkins-bot: Cleanup some docs (includes/[a-d]) [core] - 10https://gerrit.wikimedia.org/r/149062 (owner: 10Umherirrender) [18:55:13] (03Abandoned) 10Jdlrobson: Do not show hidden posts by default [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145172 (owner: 10Jdlrobson) [18:55:37] 3MediaWiki / 3Recent changes: Page moves into mainspace should appear on Special:Newpages for patrol - 10https://bugzilla.wikimedia.org/12363#c39 (10Bawolff (Brian Wolff)) (In reply to Bawolff (Brian Wolff) from comment #38) > Rohan's patch just gave me a (hacky) idea. > > *Add an index on (rc_source, rc_lo... [18:56:06] disabled in wmf-config [18:56:57] legoktm: k [18:58:08] Given the sensitivity, I'd feel more comfortable if it's disabled by default inside the extension. On wiki farms that's a major exploit/danger factor. [18:58:26] It's not a blocker though [18:59:09] (03PS15) 10Florianschmidtwelzow: Enable the creation of empty pages [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [18:59:13] in mediawiki-core user scripts are disabled by default. But installing this extension of course addresses a slim subset of mediawiki sites. [18:59:19] those likely do wanting user scripts. [19:00:20] (03CR) 10SG: Add onbeforeunload handler when navigating away from unsubmitted changes (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148983 (owner: 10SG) [19:01:40] (03CR) 10Florianschmidtwelzow: [C: 031] "Looks good for me. Adding API maintainers (mw.org/Developers/Maintainers) to review the API change :)" [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [19:01:58] (03CR) 10Jdlrobson: [C: 032] Reset preview when submitting new topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149070 (https://bugzilla.wikimedia.org/68131) (owner: 10EBernhardson) [19:02:33] (03Merged) 10jenkins-bot: Reset preview when submitting new topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149070 (https://bugzilla.wikimedia.org/68131) (owner: 10EBernhardson) [19:03:05] (03CR) 10Jdlrobson: "Incorrect. Werdna's patch will be based off this." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147344 (owner: 10Jdlrobson) [19:03:27] 3Wikimedia / 3General/Unknown: Local versions of system messages are ignored - 10https://bugzilla.wikimedia.org/67805#c36 (10Andre Klapper) p:5Highes>3High (In reply to Andre Klapper from comment #35) > NickK: Is this still a problem on Ukrainian Wikimedia sites? And is "II) Localisation cache returns r... [19:04:30] 3MediaWiki-Vagrant: Standalone jobrunner does not start - 10https://bugzilla.wikimedia.org/68525 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3Ori Livneh The standalone job runner does not start, either through puppet or manually. Puppet reports: --- Error: Could not start Service[jobrunner]: Exec... [19:04:49] legoktm: So the main reason for hard rl links is scope [19:04:55] legoktm: global js execution scope [19:05:03] in other words, user/site modules. [19:05:09] right [19:05:26] with combined loading, that isn't the case. [19:05:45] Its' kind of weird to use a hard rl link with combined loading, for that is essentially the kind of call mw.loader.load would make. [19:06:02] But we're not using that because the version number we put in the registry isn't user specific. [19:06:32] would it make sense to have a separate styles and scripts link? [19:07:03] actually, I kind of like that these new links will not support legacy globals [19:07:13] it'll be loaded like a proper module, a clean slate. [19:07:29] so let's not split them into separate requests [19:07:52] hmm, does global.css work for users with js disabled right now? I'm thinking it might not [19:10:13] (03CR) 10Parent5446: "Inline comment. Also, this should probably have unit tests (both for API and for EditPage)." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [19:14:36] it doesn't :/ [19:14:50] Krinkle: so I think we need to split it into two separate requests [19:15:19] (03PS4) 10Cscott: Regularize spacing in `texvc` and `texvccheck` [extensions/Math] - 10https://gerrit.wikimedia.org/r/148677 [19:15:21] (03PS1) 10Cscott: Remove unused empty production for `litsq_zq` in texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/149089 [19:15:23] (03PS1) 10Cscott: Switch to text mode before emitting \AA or \textvisiblespace. [extensions/Math] - 10https://gerrit.wikimedia.org/r/149090 [19:16:39] (03CR) 10jenkins-bot: [V: 04-1] Regularize spacing in `texvc` and `texvccheck` [extensions/Math] - 10https://gerrit.wikimedia.org/r/148677 (owner: 10Cscott) [19:19:20] (03PS16) 10Florianschmidtwelzow: Enable the creation of empty pages [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [19:19:45] (03CR) 10Florianschmidtwelzow: Enable the creation of empty pages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [19:21:30] 3MediaWiki / 3Skin and page rendering: Images with border parameter should display captions - 10https://bugzilla.wikimedia.org/68468#c13 (10Erwin Dokter) "framed" also uses the thumbinner class. We need a solution to display a captioned image *with* border if need be. Else this whole restyling business beco... [19:23:46] 3MediaWiki extensions / 3CirrusSearch: Differences in search results for JS variables/strings - 10https://bugzilla.wikimedia.org/68527 (10Helder) 3NEW p:3Unprio s:3normal a:3None https://en.wikipedia.org/w/api.php?action=query&list=search&format=xml&srsearch=wgtitle%20intitle%3Ajs&srnamespace=8&srpro... [19:23:58] 3MediaWiki / 3Skin and page rendering: Images with border parameter should display captions - 10https://bugzilla.wikimedia.org/68468#c14 (10Steven Walling) (In reply to Erwin Dokter from comment #13) > "framed" also uses the thumbinner class. > > We need a solution to display a captioned image *with* border... [19:24:37] (03PS1) 10Jforrester: Revert "Provide way for users to find articles with the automatic " [extensions/Cite] - 10https://gerrit.wikimedia.org/r/149091 [19:24:39] (03CR) 10jenkins-bot: [V: 04-1] Revert "Provide way for users to find articles with the automatic " [extensions/Cite] - 10https://gerrit.wikimedia.org/r/149091 (owner: 10Jforrester) [19:24:45] (03CR) 10Jforrester: [C: 032] Revert "Provide way for users to find articles with the automatic " [extensions/Cite] - 10https://gerrit.wikimedia.org/r/149091 (owner: 10Jforrester) [19:24:47] (03CR) 10jenkins-bot: [V: 04-1] Revert "Provide way for users to find articles with the automatic " [extensions/Cite] - 10https://gerrit.wikimedia.org/r/149091 (owner: 10Jforrester) [19:26:17] legoktm: Hold on [19:26:22] legoktm: rewind [19:26:29] legoktm: "Right now" what do you mean? [19:27:09] legoktm: I use @import m/global.js from [[all the wikis:User:Krinkle/common.css]] and importScriptURI from common.js [19:27:12] that works with js disabled. [19:27:13] (03PS2) 10Jforrester: Revert "Provide way for users to find articles with the automatic " [extensions/Cite] - 10https://gerrit.wikimedia.org/r/149091 [19:27:22] (03CR) 10Jforrester: [C: 032] Revert "Provide way for users to find articles with the automatic " [extensions/Cite] - 10https://gerrit.wikimedia.org/r/149091 (owner: 10Jforrester) [19:27:27] m/global.css* [19:27:30] (03Merged) 10jenkins-bot: Revert "Provide way for users to find articles with the automatic " [extensions/Cite] - 10https://gerrit.wikimedia.org/r/149091 (owner: 10Jforrester) [19:27:50] (03PS1) 10Jforrester: Revert "Provide way for users to find articles with the automatic " [extensions/Cite] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/149093 [19:28:16] (03PS1) 10Hashar: Switch analytics-quarry-web to tox [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/149094 [19:29:30] 3MediaWiki extensions / 3Cite: Cite: Provide a way for users to find articles which have the reference list inserted automatically - 10https://bugzilla.wikimedia.org/67700#c14 (10Krinkle) 5RESO/FIX>3REOP This patchset was reverted in change: I923ed39f405d926b70a5098cbde6eee0538eee51 [19:30:10] (03CR) 10Yuvipanda: [C: 032] Switch analytics-quarry-web to tox [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/149094 (owner: 10Hashar) [19:30:28] 3MediaWiki / 3Skin and page rendering: Images with border parameter should display captions - 10https://bugzilla.wikimedia.org/68468#c15 (10Erik Moeller) What's the issue with the following: "50px|border|Some text" behaves as before "50px|Some text" behaves as before "200px|thumb|Some text" has new styling... [19:31:30] (03Merged) 10jenkins-bot: Switch analytics-quarry-web to tox [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/149094 (owner: 10Hashar) [19:31:47] (03CR) 10Parent5446: "Are you planning on putting tests in? I'm fine with merging this without unit tests, but it would be better if there were some. ;)" [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [19:32:22] (03CR) 10Ebe123: "I am putting tests in." [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [19:32:32] hashar committed rJJBCONF30c5a93dcbc3: Switch analytics-quarry-web to tox (authored by hashar). [19:32:38] (03PS1) 10Hashar: Switch analytics-quarry-web to tox [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/149095 [19:32:52] (03PS1) 10Catrope: Revert "Provide way for users to find articles with the automatic " [extensions/Cite] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/149096 [19:33:13] (03CR) 10Hashar: [C: 032] "deploying" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/149095 (owner: 10Hashar) [19:33:22] (03Merged) 10jenkins-bot: Switch analytics-quarry-web to tox [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/149095 (owner: 10Hashar) [19:35:53] (03CR) 10Parent5446: [C: 032] Break some long lines in maintenance, skins, tests [core] - 10https://gerrit.wikimedia.org/r/149044 (owner: 10Umherirrender) [19:36:39] (03CR) 10Parent5446: [C: 032] Send 404 in various special pages when there're no results [core] - 10https://gerrit.wikimedia.org/r/148965 (https://bugzilla.wikimedia.org/67182) (owner: 10Liangent) [19:38:30] 3Wikimedia / 3IRC: stream.wikimedia.org - redirect http(s) to docs - 10https://bugzilla.wikimedia.org/68528 (10Daniel Zahn) 3NEW p:3Unprio s:3normal a:3None http://stream.wikimedia.org - currently 404 https://stream.wikimedia.org - currently cert error for good measure redirect them to the docs at... [19:38:36] (03CR) 10Alex Monk: "Details?" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/149091 (owner: 10Jforrester) [19:39:17] (03PS5) 10Cscott: Regularize spacing in `texvc` and `texvccheck` [extensions/Math] - 10https://gerrit.wikimedia.org/r/148677 [19:39:19] (03PS1) 10Cscott: Some commands should require arguments in `texvc` and `texvccheck` [extensions/Math] - 10https://gerrit.wikimedia.org/r/149097 [19:39:35] (03Merged) 10jenkins-bot: Break some long lines in maintenance, skins, tests [core] - 10https://gerrit.wikimedia.org/r/149044 (owner: 10Umherirrender) [19:39:43] (03Merged) 10jenkins-bot: Send 404 in various special pages when there're no results [core] - 10https://gerrit.wikimedia.org/r/148965 (https://bugzilla.wikimedia.org/67182) (owner: 10Liangent) [19:40:13] (03CR) 10jenkins-bot: [V: 04-1] Regularize spacing in `texvc` and `texvccheck` [extensions/Math] - 10https://gerrit.wikimedia.org/r/148677 (owner: 10Cscott) [19:40:16] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Tested rollback -> works" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/146440 (https://bugzilla.wikimedia.org/4488) (owner: 10Ebe123) [19:41:06] (03CR) 10jenkins-bot: [V: 04-1] Some commands should require arguments in `texvc` and `texvccheck` [extensions/Math] - 10https://gerrit.wikimedia.org/r/149097 (owner: 10Cscott) [19:44:38] legoktm: ping [19:45:54] (03PS2) 10Krinkle: Avoid function calls in the loop condition of a for statement [core] - 10https://gerrit.wikimedia.org/r/149028 (owner: 10Umherirrender) [19:48:23] (03CR) 10Krinkle: [C: 032] "No FOR but simply for. This is PHP, not ALGOL 60." [core] - 10https://gerrit.wikimedia.org/r/149028 (owner: 10Umherirrender) [19:48:48] (Yes James_F, I know ALGOL) [19:49:36] (03CR) 10Reedy: [C: 032] Revert "Provide way for users to find articles with the automatic " [extensions/Cite] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/149096 (owner: 10Catrope) [19:49:42] (03CR) 10Reedy: [C: 032] Revert "Provide way for users to find articles with the automatic " [extensions/Cite] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/149093 (owner: 10Jforrester) [19:49:44] (03Merged) 10jenkins-bot: Revert "Provide way for users to find articles with the automatic " [extensions/Cite] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/149096 (owner: 10Catrope) [19:49:50] (03Merged) 10jenkins-bot: Revert "Provide way for users to find articles with the automatic " [extensions/Cite] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/149093 (owner: 10Jforrester) [19:50:59] (03PS1) 10Reedy: Update Cite to 1.24wmf14 HEAD [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/149098 [19:51:18] (03Merged) 10jenkins-bot: Avoid function calls in the loop condition of a for statement [core] - 10https://gerrit.wikimedia.org/r/149028 (owner: 10Umherirrender) [19:52:38] (03PS1) 10Reedy: Update Cite to 1.24wmf15 HEAD [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/149099 [19:52:55] (03CR) 10Reedy: [C: 032 V: 032] Update Cite to 1.24wmf14 HEAD [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/149098 (owner: 10Reedy) [19:53:00] (03CR) 10Reedy: [C: 032 V: 032] Update Cite to 1.24wmf15 HEAD [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/149099 (owner: 10Reedy) [19:55:04] MatmaRex, there's an IRC for the hack day at #mediawiki-ui if you're interested. [19:55:56] Krinkle: sorry was afk. right now as in testwiki and test2wiki have the extension deployed [19:56:02] test2wiki is the "global wiki" [19:56:24] oh [19:56:30] right now as in with the extension [19:56:39] * legoktm reads again [19:57:01] superm401: thanks, i probably won't habe time to participate :/ [19:57:03] [12:27:09] legoktm: I use @import m/global.js from [[all the wikis:User:Krinkle/common.css]] and importScriptURI from common.js <-- I meant using the extension [19:57:14] (but i joined the channel and i'm lurking, poke me if you need me :) ) [19:57:15] Krinkle: You surprise me every day. :-) [19:57:34] MatmaRex, me neither today, really. [19:58:29] 3MediaWiki extensions / 3Cite: Cite: Provide a way for users to find articles which have the reference list inserted automatically - 10https://bugzilla.wikimedia.org/67700 (10Alex Monk) a:5Alex Monk>3None [19:59:35] (03PS1) 10Spage: Add white-space to get pre to wrap in Firefox [core] - 10https://gerrit.wikimedia.org/r/149104 [19:59:51] (03PS4) 10AndyRussG: WIP Add HooksTest [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/146033 [20:00:14] 3MediaWiki extensions / 3GlobalCssJs: Global CSS and JS should not be loaded on [[Special:Preferences]] and [[Special:UserLogin]] - 10https://bugzilla.wikimedia.org/68521#c3 (10Kunal Mehta (Legoktm)) https://github.com/wikimedia/mediawiki-core/blob/master/includes/OutputPage.php#L2726 isn't checking TYPE_COM... [20:04:32] (03Abandoned) 10Yurik: Updated to latest ZeroBanner [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/149008 (owner: 10Yurik) [20:04:59] (03Abandoned) 10Yurik: Updated to latest ZeroBanner [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/149009 (owner: 10Yurik) [20:05:01] 3MediaWiki extensions / 3Translate: Many INSERT queries on some web requests - 10https://bugzilla.wikimedia.org/68530 (10Aaron Schulz) 3NEW p:3Unprio s:3normal a:3None Still seeing things like this occasionally: 2014-07-24 18:01:35 mw1191 outreachwiki: Sub-optimal transaction on DB(s) [10.64.16.27 (... [20:06:45] (03PS17) 10Ebe123: Enable the creation of empty pages [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) [20:07:17] (03PS1) 10Reedy: Update Translate to 1.24wmf15 HEAD [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/149110 [20:07:50] (03CR) 10Reedy: [C: 032 V: 032] Update Translate to 1.24wmf15 HEAD [core] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/149110 (owner: 10Reedy) [20:07:53] (03PS1) 10Aaron Schulz: Made Special:RunJobs work for private wikis [core] - 10https://gerrit.wikimedia.org/r/149111 [20:10:43] (03CR) 10Florianschmidtwelzow: [C: 031] "NOT reviewed: API Test" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [20:13:44] 3MediaWiki / 3Parser: Message handling in parser - 10https://bugzilla.wikimedia.org/17329#c11 (10wikimedia-gaijin42) This bug appears to still be happening quite regularly on en.wikipedia https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#some_sort_of_mediawiki_error_is_happening [20:14:28] 3MediaWiki-Vagrant: vagrant vagrant-vbguest plugin install fails on Mac OS X - 10https://bugzilla.wikimedia.org/68453#c8 (10Bernd Sitzmann) I think `vagrant destroy; vagrant up` helped. When I checked the existance of the hphp directory I mistakenly checked on my host box. The file /usr/lib/hphp/extensions/201... [20:17:29] 3MediaWiki extensions / 3Translate: Many INSERT queries on some web requests - 10https://bugzilla.wikimedia.org/68530 (10Nemo) p:5Unprio>3Normal [20:18:17] (03CR) 10Ebe123: Enable the creation of empty pages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [20:18:49] (03PS18) 10Ebe123: Enable the creation of empty pages [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) [20:19:30] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/137608 (owner: 10Hashar) [20:19:33] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/137608 [20:20:46] 3MediaWiki extensions / 3[other]: FundraisingChart should pass jshint - 10https://bugzilla.wikimedia.org/66192#c12 (10Antoine "hashar" Musso) 5RESO/FIX>3REOP Still failing I have a test change at https://gerrit.wikimedia.org/r/#/c/137608/ Yields a failing job https://integration.wikimedia.org/ci/job/mwe... [20:21:19] 3MediaWiki / 3Parser: Message handling in parser - 10https://bugzilla.wikimedia.org/17329#c12 (10James Forrester) (In reply to wikimedia-gaijin42 from comment #11) > This bug appears to still be happening quite regularly on en.wikipedia > > https://en.wikipedia.org/wiki/Wikipedia: > Village_pump_(technical)... [20:22:30] 3MediaWiki-Vagrant: vagrant vagrant-vbguest plugin install fails on Mac OS X - 10https://bugzilla.wikimedia.org/68453#c9 (10Bryan Davis) (In reply to Bernd Sitzmann from comment #8) > I think the problem is that I have > /usr/lib/hphp/extensions/20140702/luasandbox.so > but hhvmsh is looking for /usr/lib/hphp... [20:26:54] (03CR) 10Parent5446: Enable the creation of empty pages (032 comments) [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [20:30:16] (03CR) 10Nikerabbit: Cleanup some docs (languages, maintenance, tests) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/148991 (owner: 10Umherirrender) [20:30:37] (03PS6) 10BryanDavis: Allow login with pre-rename username and password [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/147020 (https://bugzilla.wikimedia.org/67995) [20:31:54] * ebernhardson cant freakin wait for closures to have access to $this [20:37:39] ebernhardson: count me in [20:37:45] 3MediaWiki extensions / 3Translate: Add support for ElasticSearch backend for ttmserver - 10https://bugzilla.wikimedia.org/52993#c2 (10Niklas Laxström) p:5Normal>3High SearchTranslations does support ES, what makes you think it doesn't? The main remaining issue is translation memory query performance. P... [20:39:29] (03CR) 10BryanDavis: Allow login with pre-rename username and password (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/147020 (https://bugzilla.wikimedia.org/67995) (owner: 10BryanDavis) [20:50:08] (03PS10) 10Ebe123: Create preferences to watchlist pages after rollbacking and undoing [core] - 10https://gerrit.wikimedia.org/r/146440 (https://bugzilla.wikimedia.org/4488) [20:50:50] (03Merged) 10jenkins-bot: Add white-space to get pre to wrap in Firefox [core] - 10https://gerrit.wikimedia.org/r/149104 (owner: 10Spage) [20:50:52] otto committed rOPSPUPPET73972ae688b8: Update wikimetrics module, run with higher concurrency in prod (authored by otto). [20:51:31] 3MediaWiki-Vagrant: vagrant vagrant-vbguest plugin install fails on Mac OS X - 10https://bugzilla.wikimedia.org/68453#c10 (10Bernd Sitzmann) Looks like `vagrant git-update` still relies on the old extension: besiair:vagrant besi$ vagrant git-update ==> Updating /vagrant/mediawiki ... Already up-to-date. ==>... [20:53:52] 3MediaWiki-Vagrant: vagrant vagrant-vbguest plugin install fails on Mac OS X - 10https://bugzilla.wikimedia.org/68453#c11 (10Bryan Davis) (In reply to Bernd Sitzmann from comment #10) > Looks like `vagrant git-update` still relies on the old extension: > > besiair:vagrant besi$ vagrant git-update > ==> Updati... [20:55:56] (03PS8) 10Bsitu: Break notifications into alert and message sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 [20:56:47] (03CR) 10Jorm: [V: 032] Add some sanity to the font sizing. Still not perfect. [winter/snowflakes] - 10https://gerrit.wikimedia.org/r/146589 (owner: 10Jorm) [20:57:06] (03CR) 10Daniel Kinzler: [C: 031] "I agree with Aude that inheritance is not a godd way to share code, but I don't know whether this is consensus." [core] - 10https://gerrit.wikimedia.org/r/148996 (owner: 10Aude) [20:58:13] 3MediaWiki extensions / 3Translate: Special:SearchTranslations: allowlanguage, messageid etc. with ElasticSearch - 10https://bugzilla.wikimedia.org/68518 (10Nemo) p:5Unprio>3Normal [20:58:27] 3Wikimedia / 3Site requests: FeaturedFeeds extension: Set feed limit for monthly featured articles on la.wikipedia - 10https://bugzilla.wikimedia.org/33978#c12 (10Tomasz W. Kozlowski) 5PATC>3RESO/FIX This has now been merged and deployed to the production cluster by Reedy (thank you!). Many thanks to TT... [20:58:58] 3MediaWiki extensions / 3Translate: Special:SearchTranslations: allow language, messageid etc. with ElasticSearch - 10https://bugzilla.wikimedia.org/68518 (10Nemo) [21:06:48] bd808: any ideas on how to fix https://bugzilla.wikimedia.org/show_bug.cgi?id=68453? [21:07:42] bd808: vagrant provision has the same error, plus more [21:08:21] * bd808 looks at the paste [21:08:53] bd808: it starts with "Error: composer install" but not sure my musical skills apply ;) [21:10:38] chicken and egg problem? bah [21:10:45] 3MediaWiki extensions / 3WikidataRepo: Special:MergeHistory does not work for Wikidata items - 10https://bugzilla.wikimedia.org/68533 (10Vogone) 3NEW p:3Unprio s:3normal a:3Wikidata bugs I don't know how relevant this is and whether it possibly is a WONTFIX, but when trying to merge the page historie... [21:11:08] bearND: On your host computer, cd to the vagrant checkout directory and run `grep hhvm.dynamic_extension_path puppet/modules/hhvm/templates/php.ini.erb` [21:11:16] What does that say? [21:11:28] 3MediaWiki extensions / 3Translate: Special:SearchTranslations: allow messageid with ElasticSearch - 10https://bugzilla.wikimedia.org/68518 (10Niklas Laxström) [21:11:32] * bd808 hopes for hhvm.dynamic_extension_path = /usr/lib/hphp/extensions/20140702 [21:11:49] bd808: hhvm.dynamic_extension_path = /usr/lib/hphp/extensions/20131007 [21:12:14] Ok. you still have an old MWV checkout! [21:12:29] git fetch; git rebase origin/master [21:12:35] Then do the grep again [21:12:51] bd808: I though that was included in the vagrant git-update [21:13:00] It should be.... [21:13:35] bd808: ok, ran the git fetch, now the file has the correct ext path [21:13:51] cool. vagrant provision one more time [21:14:15] There still may be some race here but it should be resolvable now [21:15:28] bd808: provisioned without errors :) [21:15:34] Is the git status of your vagrant directory dirty by chance? I think git-update doesn't mess with things if there are uncommited changes [21:15:41] bearND: w00t [21:15:57] bd808: and got the main page to show up. yesssss! :) [21:16:24] (03PS19) 10Ebe123: Enable the creation of empty pages [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) [21:16:46] bd808: the git repo has two untracked files from the times when i tried to install libiconv [21:17:29] I'm looking at the script Ori wrote (installed as /usr/local/bin/run-git-update). I'm not sure what it's doing exactly [21:17:45] but it obviously did not update your mwv checkout [21:18:18] (03PS2) 10Cscott: Some commands should require arguments in `texvc` and `texvccheck` [extensions/Math] - 10https://gerrit.wikimedia.org/r/149097 [21:18:20] (03PS6) 10Cscott: Regularize spacing in `texvc` and `texvccheck` [extensions/Math] - 10https://gerrit.wikimedia.org/r/148677 [21:18:22] bd808: moved those untracked file + directory away just in case [21:18:24] (03PS1) 10Jdlrobson: Add mw-ui-checkbox [core] - 10https://gerrit.wikimedia.org/r/149121 [21:18:37] (03CR) 10jenkins-bot: [V: 04-1] Some commands should require arguments in `texvc` and `texvccheck` [extensions/Math] - 10https://gerrit.wikimedia.org/r/149097 (owner: 10Cscott) [21:18:47] (03CR) 10jenkins-bot: [V: 04-1] Regularize spacing in `texvc` and `texvccheck` [extensions/Math] - 10https://gerrit.wikimedia.org/r/148677 (owner: 10Cscott) [21:18:49] (03PS1) 10Jdlrobson: Upstream checkboxes to core [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/149122 [21:18:53] (03CR) 10jenkins-bot: [V: 04-1] Upstream checkboxes to core [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/149122 (owner: 10Jdlrobson) [21:18:55] (03CR) 10Physikerwelt: "can we seperate the texvccheck changes from the texvc changes? I think we should not change texvc. It's just waiting to be retired." [extensions/Math] - 10https://gerrit.wikimedia.org/r/149090 (owner: 10Cscott) [21:19:20] I wouldn't expect untracked files to cause a problem, but maybe tracked files with uncommitted changes? This bash + git loop is confusing [21:19:39] (03PS5) 10AndyRussG: Add HooksTest [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/146033 [21:20:13] It looks like it just jumps though some hoops and then runs `git pull` [21:20:39] Which according to the bug told you "Already up-to-date." [21:20:43] But it wasn't [21:21:00] so go home git, you're drunk. [21:21:56] (03CR) 10Physikerwelt: ""This has no effect on the generated parser, but clarifies the grammar." Why should we change it? The png image does not care about the gr" [extensions/Math] - 10https://gerrit.wikimedia.org/r/149089 (owner: 10Cscott) [21:21:58] 3MediaWiki-Vagrant: vagrant vagrant-vbguest plugin install fails on Mac OS X - 10https://bugzilla.wikimedia.org/68453#c12 (10Bernd Sitzmann) Got it fixed on IRC. Just updating here for documentation purposes: $ grep hhvm.dynamic_extension_path puppet/modules/hhvm/templates/php.ini.erb hhvm.dynamic_extension_p... [21:22:01] (03CR) 10Cscott: "texvccheck is a fork of texvc, I would like to keep them in sync." [extensions/Math] - 10https://gerrit.wikimedia.org/r/149090 (owner: 10Cscott) [21:22:23] bd808: just updated the bug to document what just happenend ^ [21:22:32] (03CR) 10Cscott: "Because I'm trying to keep texvc and texvccheck in sync." [extensions/Math] - 10https://gerrit.wikimedia.org/r/149089 (owner: 10Cscott) [21:22:32] bearND: Thanks [21:22:52] (03PS2) 10Jdlrobson: Upstream checkboxes to core [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/149122 [21:22:58] (03CR) 10jenkins-bot: [V: 04-1] Upstream checkboxes to core [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/149122 (owner: 10Jdlrobson) [21:23:03] (03CR) 10Hoo man: [C: 031] "Inheritance is not the right thing here." [core] - 10https://gerrit.wikimedia.org/r/148996 (owner: 10Aude) [21:23:12] Should we close that now? Or is there still a horrible problem installing the vagrant-vbguest plugin? [21:23:13] bd808: Thank you for your help. Much appreciated :) [21:23:43] 3MediaWiki / 3Installer: Add support for enabling skins in the installer, the way we handle extensions - 10https://bugzilla.wikimedia.org/66440#c5 (10Tomasz W. Kozlowski) Thank you for fixing this bug, Bartosz — really appreciate your work on this. [21:24:14] (03PS2) 10Jdlrobson: Add mw-ui-checkbox [core] - 10https://gerrit.wikimedia.org/r/149121 [21:24:16] bd808: Not sure if that was only on my environment. It's up to you if you want to close it. [21:24:39] (03CR) 10Jdlrobson: [C: 04-1] "Shoot.. something went wrong in rebase." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/149122 (owner: 10Jdlrobson) [21:24:44] ensure changed purged to latest [21:25:45] 3MediaWiki-Vagrant: vagrant vagrant-vbguest plugin install fails on Mac OS X - 10https://bugzilla.wikimedia.org/68453#c13 (10Bryan Davis) (In reply to Bryan Davis from comment #11) > (In reply to Bernd Sitzmann from comment #10) > > Looks like `vagrant git-update` still relies on the old extension: > > > > be... [21:25:52] (03CR) 10Physikerwelt: "why does that change the layout than." [extensions/Math] - 10https://gerrit.wikimedia.org/r/149097 (owner: 10Cscott) [21:26:11] (03CR) 10Cscott: [C: 032] Use `texvcjs` package to validate/translate math markup. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148591 (owner: 10Cscott) [21:26:28] (03PS3) 10Jdlrobson: Upstream checkboxes to core [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/149122 [21:26:36] (03CR) 10jenkins-bot: [V: 04-1] Upstream checkboxes to core [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/149122 (owner: 10Jdlrobson) [21:28:31] (03Merged) 10jenkins-bot: Use `texvcjs` package to validate/translate math markup. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148591 (owner: 10Cscott) [21:29:13] 3MediaWiki-Vagrant: vagrant vagrant-vbguest plugin install fails on Mac OS X - 10https://bugzilla.wikimedia.org/68453#c14 (10Bryan Davis) 5NEW>3RESO/WOR Thanks for not giving up Bernd. Eventually everything worked out. There are probably legitimate bugs to be fixed buried in here, but we wandered all over... [21:30:57] (03PS3) 10Cscott: Some commands should require arguments in `texvc` and `texvccheck` [extensions/Math] - 10https://gerrit.wikimedia.org/r/149097 [21:30:59] (03PS7) 10Cscott: Regularize spacing in `texvc` and `texvccheck` [extensions/Math] - 10https://gerrit.wikimedia.org/r/148677 [21:31:15] (03CR) 10jenkins-bot: [V: 04-1] Some commands should require arguments in `texvc` and `texvccheck` [extensions/Math] - 10https://gerrit.wikimedia.org/r/149097 (owner: 10Cscott) [21:31:28] (03CR) 10jenkins-bot: [V: 04-1] Regularize spacing in `texvc` and `texvccheck` [extensions/Math] - 10https://gerrit.wikimedia.org/r/148677 (owner: 10Cscott) [21:31:57] (03PS3) 10Jdlrobson: Add mw-ui-checkbox [core] - 10https://gerrit.wikimedia.org/r/149121 [21:32:16] (03PS1) 10Mwalker: Add clear queue maintenance script [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149128 [21:34:01] (03CR) 10Mwalker: [C: 032] Add clear queue maintenance script [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149128 (owner: 10Mwalker) [21:34:20] (03Merged) 10jenkins-bot: Add clear queue maintenance script [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149128 (owner: 10Mwalker) [21:35:40] (03PS4) 10Jdlrobson: Add mw-ui-checkbox [core] - 10https://gerrit.wikimedia.org/r/149121 [21:38:23] andrewbogott committed rOPSPUPPET860a85c31a5a: Revert "tools: remove libvips from exec_environ" (authored by scfc). [21:40:13] (03CR) 10Physikerwelt: "yes I forked the parts of texvc that should survive and should be ported to a different language which is easier to maintain. That's the i" [extensions/Math] - 10https://gerrit.wikimedia.org/r/149090 (owner: 10Cscott) [21:41:32] (03PS20) 10Ebe123: Enable the creation of empty pages [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) [21:42:14] (03CR) 10Physikerwelt: Switch to text mode before emitting \AA or \textvisiblespace. (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/149090 (owner: 10Cscott) [21:43:08] ori committed rOPSPUPPETf619c7bc65e2: admin: add deployment helper script to my env (authored by ori). [21:43:10] Gerrit Code Review committed rOPSPUPPET1b4142249ab1: Merge "admin: add deployment helper script to my env" into production (authored by ori). [21:48:33] (03PS2) 10Withoutaname: Enable temporary hacks for language codes "ar" and "ml" everywhere [core] - 10https://gerrit.wikimedia.org/r/144155 [21:51:22] (03PS2) 10Ori.livneh: Add retry=0 to ProxyPass directives [vagrant] - 10https://gerrit.wikimedia.org/r/148919 (owner: 10BryanDavis) [21:51:26] (03CR) 10Ori.livneh: [C: 032] Add retry=0 to ProxyPass directives [vagrant] - 10https://gerrit.wikimedia.org/r/148919 (owner: 10BryanDavis) [21:51:57] (03Merged) 10jenkins-bot: Add retry=0 to ProxyPass directives [vagrant] - 10https://gerrit.wikimedia.org/r/148919 (owner: 10BryanDavis) [21:52:02] Gerrit Code Review committed rOPSPUPPET27098696a1c8: Merge "lucene: qualify var" into production (authored by dzahn). [21:52:41] (03CR) 10Jforrester: "@Bartosz – is the Opera-12-specific hack about background-svg not working with border-radius not needed any more?" [core] - 10https://gerrit.wikimedia.org/r/149121 (owner: 10Jdlrobson) [21:53:44] scfc added a comment to T42: Plan to migrate code review from Gerrit to Phabricator. http://fab.wmflabs.org/T42 [21:54:38] (03PS16) 10Mwalker: Create attribution page [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/145187 [21:55:13] Hm.. can anyone else reproduce this: https://code.google.com/p/chromium/issues/detail?id=397281 ? [21:55:14] (03PS4) 10Cscott: Some commands should require arguments in `texvc` and `texvccheck` [extensions/Math] - 10https://gerrit.wikimedia.org/r/149097 [21:55:16] (03PS2) 10Cscott: Remove unused empty production for `litsq_zq` in texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/149089 [21:55:18] (03PS2) 10Cscott: Switch to text mode before emitting \AA or \textvisiblespace. [extensions/Math] - 10https://gerrit.wikimedia.org/r/149090 [21:55:20] (03PS1) 10Cscott: Sanitize filesystem paths before emitting ParserTests.data. [extensions/Math] - 10https://gerrit.wikimedia.org/r/149171 [21:55:22] (03CR) 10MarkTraceur: [C: 04-1] "One small thing, I'll fix it." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/149121 (owner: 10Jdlrobson) [21:56:48] (03PS5) 10MarkTraceur: Add mw-ui-checkbox [core] - 10https://gerrit.wikimedia.org/r/149121 (owner: 10Jdlrobson) [21:58:19] (03CR) 10Physikerwelt: [C: 032] Sanitize filesystem paths before emitting ParserTests.data. [extensions/Math] - 10https://gerrit.wikimedia.org/r/149171 (owner: 10Cscott) [21:58:36] Krinkle, I cant reproduce it in my version of chrome [21:58:41] http://jsfiddle.net/9r56k/ [22:00:20] (03PS1) 10Jdlrobson: Add mw-ui-input to mediawiki ui [core] - 10https://gerrit.wikimedia.org/r/149173 [22:01:00] (03PS1) 10Jdlrobson: WIP: Use mw-ui- core module [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149174 [22:01:52] (03CR) 10Krinkle: "Indeed. Maybe we should have those security features use CACHE_ANYTHING instead of $wgMemc / main cache?" [core] - 10https://gerrit.wikimedia.org/r/117091 (owner: 10MaxSem) [22:02:07] Krinkle, unless I'm missing what you're trying to reproduce (failure to redraw parts of the box as it expands/collapses thus leaving artifacts) -- it's not in Chromium 34.0.1847.116 or Chrome 35.0.1916.114 on my machine [22:02:10] (03CR) 10Krinkle: "We do the same in various places in ResourceLoader already." [core] - 10https://gerrit.wikimedia.org/r/117091 (owner: 10MaxSem) [22:02:33] Krinkle, I also use native intel graphics drivers though; so that might play into this [22:03:06] Gerrit Code Review committed rOPSPUPPETe282bee935bb: Merge "planet -- update cipher suite list to support PFS" into production (authored by dzahn). [22:03:41] (03PS17) 10Mwalker: Create attribution page [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/145187 [22:03:42] what is wikiphabot [22:03:44] 3MediaWiki / 3General/Unknown: Move all four core skins to separate repositories and include them in the tarball - 10https://bugzilla.wikimedia.org/68333 (10Greg Grossmeier) [22:03:59] Is that supposed to be public? [22:04:01] Krinkle: bot for the fab.wmflabs.org instance [22:04:02] it's the phabricator equivalent to grrrit-wm [22:04:03] yes [22:04:12] the future of wikibugs :) [22:04:13] Krinkle: can't reproduce with "Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/36.0.1985.125 Safari/537.36 OPR/23.0.1522.58 (Edition Next)" [22:04:25] greg-g: Looked for a second like private ops repo [22:04:36] (03PS1) 10Aaron Schulz: Refactored duplicated code into JobRunner.php [core] - 10https://gerrit.wikimedia.org/r/149175 [22:04:42] Krinkle: please report any feature requests/bugs to the fab.wmflabs.org instance (cc me so it's not lost) [22:05:05] Krinkle: yeah, nothing private, only announcing repos that people explicitly imported to phab for testing and all task updates [22:05:08] greg-g: request #1: use the same rules for channels as grrrit-wm :) [22:05:12] greg-g: Right now the bug is 1) ops stuff in -dev, 2) duplicate (we;re not using it right now, nobody is intersested in this I think, maybe in a sandbox channel ?) [22:05:15] ori: lots of tech debt to clean up [22:05:33] MatmaRex: good point [22:06:01] Krinkle: I am, actually, so is anyone interested in following the phabricator migration :) [22:06:02] 3) to make it useful anyways, it needs a link [22:06:10] mostly for the tasks updates, not necessarily the code ones [22:06:28] 3) yeah, already ping twentyafterfour about that one [22:06:32] pinged [22:06:33] greg-g: It's not following migration. It's just spawning out noise with the same information as grrrit-wm, except without a useful link and it also includes merge commits apparently. [22:06:38] lemme file boogz, I mean tasks [22:06:43] (03CR) 10Legoktm: [C: 031] "LGTM, but I'd like Chris to also look at it." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/147020 (https://bugzilla.wikimedia.org/67995) (owner: 10BryanDavis) [22:06:49] (03CR) 10jenkins-bot: [V: 04-1] Create attribution page [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/145187 (owner: 10Mwalker) [22:07:06] (03PS3) 10Physikerwelt: Fix: id-attribute [extensions/Math] - 10https://gerrit.wikimedia.org/r/148535 [22:07:08] Krinkle: re the diffs, yes sure, re the tasks, no, wrong, also, some teams are actively using Maniphest (tasks) so it's reasonable [22:07:25] twentyafterfour: mind muting the diff announces in here for now? [22:07:29] * greg-g files bugs [22:07:30] Gerrit Code Review committed rOPSPUPPET80966a7570ea: Merge "tendril -- update cipher suite list to support PFS" into production (authored by dzahn). [22:07:31] er tasks [22:07:43] greg-g: sure [22:07:46] thanks [22:08:06] look at that service! [22:08:09] :) [22:08:41] (03PS10) 10Physikerwelt: Add width and height to SVG image [extensions/Math] - 10https://gerrit.wikimedia.org/r/144939 (https://bugzilla.wikimedia.org/20202) [22:09:14] (03PS18) 10Mwalker: Create attribution page [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/145187 [22:09:36] 3Wikimedia / 3General/Unknown: Get dbpedia off OAI - 10https://bugzilla.wikimedia.org/68538 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3enhanc a:3None cf an email from Sebastian Hellman in February 2013 "We built *a lot* of infrastructure which depends on the updates. So if the OAI-PMH stream would sudde... [22:09:37] OK. No worries. Just saying, if those duplicate merge commit messages don't go away, it'll probably mean the bot gets kicked/quieted here until it is fixed. I think majority productivity would suffer otherwise. We'll get it right. [22:10:54] (03CR) 10SG: [C: 04-1] "As the author of this CSS, I can't +2 it. I will +1 when ready." [core] - 10https://gerrit.wikimedia.org/r/149173 (owner: 10Jdlrobson) [22:11:46] 3Wikimedia / 3General/Unknown: Get dbpedia off OAI - 10https://bugzilla.wikimedia.org/68538#c1 (10Brion Vibber) Note that old search used OAI for internal updates at least on some wikis, but this should be gone soon with full CirrusSearch deployment. What's the situation with the new rcstream etc things --... [22:11:49] (03PS5) 10Bsitu: Replace EchoBackend with mappers and gateway [extensions/Echo] - 10https://gerrit.wikimedia.org/r/147369 [22:13:38] (03PS4) 10Jdlrobson: Upstream checkboxes to core [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/149122 [22:13:44] (03CR) 10jenkins-bot: [V: 04-1] Upstream checkboxes to core [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/149122 (owner: 10Jdlrobson) [22:14:01] 3MediaWiki-Vagrant: When using hhvm, CurlHttpRequest::execute times out - 10https://bugzilla.wikimedia.org/68489#c1 (10Max Semenik) I couldn't reproduce it (tried provisioning with latest vagrant revision). If it still fails for you, could you check which request exactly is failing and narrow it down to a shor... [22:14:17] (03CR) 10Krinkle: [C: 04-1] Add mw-ui-checkbox (033 comments) [core] - 10https://gerrit.wikimedia.org/r/149121 (owner: 10Jdlrobson) [22:15:52] (03CR) 10Jforrester: Add mw-ui-checkbox (031 comment) [core] - 10https://gerrit.wikimedia.org/r/149121 (owner: 10Jdlrobson) [22:16:35] awjr: Aw, no SoS week after next? Sadness. [22:16:40] * marktraceur could monologue [22:17:00] marktraceur :) i think most of the folks will be at wikimania [22:18:38] (03PS5) 10Jdlrobson: Upstream checkboxes to core [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/149122 [22:18:44] (03CR) 10jenkins-bot: [V: 04-1] Upstream checkboxes to core [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/149122 (owner: 10Jdlrobson) [22:23:40] (03CR) 10Ori.livneh: [C: 031] Refactored duplicated code into JobRunner.php [core] - 10https://gerrit.wikimedia.org/r/149175 (owner: 10Aaron Schulz) [22:35:15] (03PS2) 10Aaron Schulz: Refactored duplicated code into JobRunner.php [core] - 10https://gerrit.wikimedia.org/r/149175 [22:39:57] Krinkle: So, I'm thinking right now the OutputPageScriptsForBottomQueue hook needs some kind of differentation between styles/scripts like addModuleStyles/addModuleScripts that can be loaded separately [22:40:18] wfRunHooks( 'OutputPageScriptsForBottomQueue', array( $this, &$combined, &$stylesonly, &$scriptsonly ) ); [22:40:21] legoktm: Forget what I said earlier about them separate. [22:40:33] legoktm: Is there a reason we would actually want them to be separate? [22:40:36] (other than the if condition bug) [22:40:46] a benefit, user experience, end result. [22:40:47] So that global.css will work if JS is disabled [22:40:55] Right, there we go. [22:40:57] OK. [22:41:08] (03CR) 10Ori.livneh: [C: 04-1] centralauth: Use hiera to allow variable customization (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/148317 (https://bugzilla.wikimedia.org/67331) (owner: 10BryanDavis) [22:41:20] You did say that now that I think back, but I misread it. [22:41:46] legoktm: Well, I'm actually thinking of getting rid of it alltogether. [22:41:57] I'd much rather only have addModules() (and *Styles, *Scripts) [22:42:12] getting rid of the hook? [22:42:13] and have it output mw.loader.load or /