[00:06:17] (03PS1) 10Jdlrobson: Refactor Watchlist code so mobile can be more consistent [core] - 10https://gerrit.wikimedia.org/r/148556 [00:14:26] (03PS2) 10BryanDavis: [WIP] centralauth: Use hiera to allow variable customization [vagrant] - 10https://gerrit.wikimedia.org/r/148317 (https://bugzilla.wikimedia.org/67331) [00:15:29] (03CR) 10Jdlrobson: [C: 032] "Good for me then :D" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148532 (owner: 10Werdna) [00:16:02] (03Merged) 10jenkins-bot: QA: Configurable timeouts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148532 (owner: 10Werdna) [00:26:06] (03PS1) 10Bsitu: [WIP]Break notifications into alert and message sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 [00:26:24] (03CR) 10jenkins-bot: [V: 04-1] [WIP]Break notifications into alert and message sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 (owner: 10Bsitu) [00:28:24] 3MediaWiki extensions / 3ReplaceText: PHP Notice: Undefined variable: num_matches in /extensions/ReplaceText/ReplaceTextJob.php on line 89 - 10https://bugzilla.wikimedia.org/68363 (10Yaron Koren) a:3Yaron Koren [00:31:14] (03PS1) 10Yaron Koren: Added initialization of variable - fix for bug 68363 [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/148566 [00:31:54] (03CR) 10Bartosz Dziewoński: "James, do you have any estimates for the 'eventually' that could be put in a helpful code comment?" [core] - 10https://gerrit.wikimedia.org/r/148305 (owner: 10Bartosz Dziewoński) [00:32:31] (03CR) 10Yaron Koren: [C: 032 V: 031] Added initialization of variable - fix for bug 68363 [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/148566 (owner: 10Yaron Koren) [00:33:21] 3MediaWiki extensions / 3ReplaceText: PHP Notice: Undefined variable: num_matches in /extensions/ReplaceText/ReplaceTextJob.php on line 89 - 10https://bugzilla.wikimedia.org/68363#c3 (10Yaron Koren) 5PATC>3RESO/FIX That bug was in place for a long time! Somehow I never noticed it. [00:37:29] (03PS10) 10Legoktm: Global merge tool [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) [00:38:12] how does jenkins +2 if gerrit says cannot merge? -.- [00:38:40] (03PS11) 10Legoktm: Global merge tool [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) [00:39:05] (03CR) 10Legoktm: "PS11 is a rebase." (033 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) (owner: 10Legoktm) [00:46:20] gwicke, when you have time, can you have a look at my question in https://gerrit.wikimedia.org/r/#/c/133301/8/resources/src/mediawiki.skinning/content.parsoid.less ? [00:47:24] jgonera: looking.. [00:48:47] legoktm: gerrit uses jgit. jenkins uses git. git is smarter than jgit when it comes to merging [00:49:00] (03CR) 10GWicke: [Reapply] Simplify thumbnail styling to have consistency with mobile (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133301 (https://bugzilla.wikimedia.org/65160) (owner: 10Jforrester) [00:49:07] oh [00:53:41] (03PS1) 10Withoutaname: Remove deprecated $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/148570 [00:55:01] (03PS2) 10Bsitu: [WIP]Break notifications into alert and message sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 [00:56:25] (03PS2) 10Withoutaname: Remove deprecated $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/148570 [00:56:48] oh forgot REL notes again [00:57:38] jgonera: am happy to remove the commented-out line if you prefer [00:58:10] gwicke, yeah, I think that's better. just wanted your opinion, I can do it when I change the color for image captions [00:58:34] jgonera: okay, thanks! [00:58:41] np, thank you [00:59:52] (03PS1) 10Bsitu: Add Flow notification to 'message' notification section [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148571 [01:00:48] (03PS2) 10Bsitu: Add Flow notification to 'message' notification section [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148571 [01:06:59] (03PS2) 10Catrope: Update messages list for oojs-ui [core] - 10https://gerrit.wikimedia.org/r/148550 (https://bugzilla.wikimedia.org/68327) [01:12:41] (03CR) 10Jforrester: [C: 032] Update messages list for oojs-ui [core] - 10https://gerrit.wikimedia.org/r/148550 (https://bugzilla.wikimedia.org/68327) (owner: 10Catrope) [01:12:53] (03PS1) 10Jforrester: Update messages list for oojs-ui [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148573 (https://bugzilla.wikimedia.org/68327) [01:16:14] (03Merged) 10jenkins-bot: Update messages list for oojs-ui [core] - 10https://gerrit.wikimedia.org/r/148550 (https://bugzilla.wikimedia.org/68327) (owner: 10Catrope) [01:24:07] 3Wikimedia / 3Deployment systems: [OPS] Jenkins: Package php5-parsekit missing in Trusty - 10https://bugzilla.wikimedia.org/68255 (10jeremyb) [01:25:38] 3MediaWiki / 3API: incomplete page title in ApiParse->getSectionContent() error message - 10https://bugzilla.wikimedia.org/68416 (10spage) 3NEW p:3Unprio s:3minor a:3None The Hovercards Beta Feature (extension Popups) reports an API error when you hover over a link to a Flow board such as Talk:Flow_Q... [01:28:44] (03CR) 10Kaldari: [C: 031] "Looks good to me. I think it's fine to merge without the redlink functionality for now. Would like to get a final OK from Nikerabbit thoug" [core] - 10https://gerrit.wikimedia.org/r/140765 (https://bugzilla.wikimedia.org/66762) (owner: 10MaxSem) [01:31:46] (03PS1) 10Spage: Provide namespace to ApiParse->getSectionContent [core] - 10https://gerrit.wikimedia.org/r/148575 (https://bugzilla.wikimedia.org/68416) [01:53:12] (03CR) 10Brian Wolff: [C: 032] Call to a member function getText() on a non-object [core] - 10https://gerrit.wikimedia.org/r/148439 (https://bugzilla.wikimedia.org/68394) (owner: 10Reedy) [01:57:06] (03Merged) 10jenkins-bot: Call to a member function getText() on a non-object [core] - 10https://gerrit.wikimedia.org/r/148439 (https://bugzilla.wikimedia.org/68394) (owner: 10Reedy) [02:11:23] 3MediaWiki extensions / 3Popups: Hovercards removes tooltip and wastes API call on link with href="javascript:void(0);" - 10https://bugzilla.wikimedia.org/68417 (10spage) 3NEW p:3Unprio s:3minor a:3None * Open your browser's developer console to the Net tab. * visit a Flow board like http://en.wikipe... [02:16:51] (03PS1) 10tosfos: fix documentation, rename file [extensions/QuizTabulate] - 10https://gerrit.wikimedia.org/r/148582 [02:18:02] (03CR) 10tosfos: [C: 032 V: 032] fix documentation, rename file [extensions/QuizTabulate] - 10https://gerrit.wikimedia.org/r/148582 (owner: 10tosfos) [02:19:42] (03PS1) 10Spage: Don't render popup on "javascript:..." links. [extensions/Popups] - 10https://gerrit.wikimedia.org/r/148583 (https://bugzilla.wikimedia.org/68417) [02:19:49] (03PS2) 10Brian Wolff: Add a maintinance report about TimedText pages that don't have a file [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/147749 [02:20:07] (03CR) 10jenkins-bot: [V: 04-1] Don't render popup on "javascript:..." links. [extensions/Popups] - 10https://gerrit.wikimedia.org/r/148583 (https://bugzilla.wikimedia.org/68417) (owner: 10Spage) [02:21:19] (03CR) 10Brian Wolff: "PS2: added code comment explaining what the query does (strips off last 2 "extensions", then looks up result in image.img_name)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/147749 (owner: 10Brian Wolff) [02:22:50] (03PS21) 10TTO: Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 (https://bugzilla.wikimedia.org/52061) [02:25:27] (03PS1) 10TTO: Update article count when pages are moved [core] - 10https://gerrit.wikimedia.org/r/148585 (https://bugzilla.wikimedia.org/64333) [02:26:21] (03PS3) 10Brian Wolff: Add a maintinance report about TimedText pages that don't have a file [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/147749 [02:26:22] 3MediaWiki / 3General/Unknown: Updating Page count doesn't work reliably when a page is moved - 10https://bugzilla.wikimedia.org/64333#c7 (10This, that and the other) a:3This, that and the other I'm onto it... [02:35:06] (03PS2) 10TTO: Allow localisation of site link text [extensions/RelatedSites] - 10https://gerrit.wikimedia.org/r/148312 (https://bugzilla.wikimedia.org/68359) [02:35:26] (03CR) 10TTO: "PS2 was a whitespace fix" [extensions/RelatedSites] - 10https://gerrit.wikimedia.org/r/148312 (https://bugzilla.wikimedia.org/68359) (owner: 10TTO) [02:38:10] (03PS3) 10Withoutaname: Remove deprecated $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/148570 [02:42:04] (03PS1) 10Withoutaname: Change addCategoryLinks() to use array_fill_keys [core] - 10https://gerrit.wikimedia.org/r/148589 [02:49:44] (03PS1) 10Withoutaname: Enforce array type hinting in OutputPage.php [core] - 10https://gerrit.wikimedia.org/r/148590 [02:53:50] (03PS9) 10Withoutaname: Subclass the Action class under ContextSource [core] - 10https://gerrit.wikimedia.org/r/143211 [02:54:18] (03PS3) 10Brian Wolff: Include ICU version in cache key for collation first letters [core] - 10https://gerrit.wikimedia.org/r/148251 (https://bugzilla.wikimedia.org/68344) [02:55:13] (03CR) 10jenkins-bot: [V: 04-1] Subclass the Action class under ContextSource [core] - 10https://gerrit.wikimedia.org/r/143211 (owner: 10Withoutaname) [02:58:47] (03PS1) 10Cscott: Use `texvcjs` package to validate/translate math markup. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148591 [03:45:31] (03CR) 10Legoktm: [C: 032] Change API to allow partially invalid requests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/148416 (owner: 10Wctaiwan) [03:45:42] (03Merged) 10jenkins-bot: Change API to allow partially invalid requests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/148416 (owner: 10Wctaiwan) [03:49:19] (03PS10) 10Withoutaname: Subclass the Action class under ContextSource [core] - 10https://gerrit.wikimedia.org/r/143211 [03:51:21] does jenkins check for deprecation warnings [03:52:56] (03PS2) 10Withoutaname: Remove $wgTitle from LanguageConverter subclasses [core] - 10https://gerrit.wikimedia.org/r/141104 (https://bugzilla.wikimedia.org/57562) [03:57:32] withoutaname: nope [03:57:38] at least I don't think it does [03:57:53] If you hit a deprecation warning in a unit test, it might cause the unit test to fail though [03:58:04] Because extra stuff will be outputted [03:59:14] well then how are we supposed to find and remove calls to deprecated functions [04:00:09] $wgDeveloperWarnings = true; [04:00:25] And then watch out for warnings as you browse your local install [04:00:38] Or grep I guess [04:01:18] I imagine that if there was an options for jenkins to look for deprecated function calls, it would be a good thing to enable [04:01:57] at least with PHP, that'll probably entail static analysis of some sort [04:03:51] 3MediaWiki-Vagrant: Archives directory /vagrant/apt-cache/partial is missing. - 10https://bugzilla.wikimedia.org/67976#c7 (10Bryan Davis) (In reply to Tisza Gergő from comment #6) > This might be only because this box is already in a messed-up state; I can > try upgrading another box if you think it will work... [04:14:01] (03PS1) 10Withoutaname: Shorten ternary expressions in RawAction.php [core] - 10https://gerrit.wikimedia.org/r/148597 [05:05:09] 3MediaWiki / 3General/Unknown: Merge Poem extension into MediaWiki core - 10https://bugzilla.wikimedia.org/52061#c51 (10MZMcBride) (In reply to comment #42) > (In reply to comment #38) >> A Global Message Delivery to all Wikisource Scriptoriums/Village pump is >> higly recommended > > MZMcBride, could you a... [05:07:57] (03PS1) 10Withoutaname: Remove deprecated class StubContLang [core] - 10https://gerrit.wikimedia.org/r/148598 [05:11:36] amusing how those usages are just commented out [05:15:22] (03PS1) 10Legoktm: Remove mleb dependency for MassMessage role [vagrant] - 10https://gerrit.wikimedia.org/r/148600 [05:30:43] what usages [05:30:51] 3MediaWiki extensions / 3Scribunto: HHVM crash loading San Francisco page - 10https://bugzilla.wikimedia.org/68196#c9 (10Brett Simmers) After some fun times with gdb, I'm almost certain this is luasandbox related, though I'm not yet sure what the root cause is. I was seeing what looked like some C++ frames d... [05:32:10] (03CR) 10Legoktm: [C: 032] Remove deprecated class StubContLang [core] - 10https://gerrit.wikimedia.org/r/148598 (owner: 10Withoutaname) [05:32:23] withoutaname: those ^ [05:36:26] (03Merged) 10jenkins-bot: Remove deprecated class StubContLang [core] - 10https://gerrit.wikimedia.org/r/148598 (owner: 10Withoutaname) [05:37:22] 3MediaWiki extensions / 3MassMessage: "MediaWiki message delivery" autocreation does not integrate with CentralAuth - 10https://bugzilla.wikimedia.org/60385#c3 (10Kunal Mehta (Legoktm)) I manually merged the account on the WMF cluster, so the page looks fine now. But the original issue still stands. [05:40:35] 3MediaWiki extensions / 3Scribunto: HHVM crash loading San Francisco page - 10https://bugzilla.wikimedia.org/68196#c10 (10Brett Simmers) I don't know anything about the internals of the Zend engine. Is it possible that this is happening with PHP5 as well but everything happens to work out anyway? I'll try it... [06:04:16] (03PS1) 10Legoktm: Add "abusefilter-bypass" userright as a hack for GlobalRename for page moves [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/148602 [06:04:47] (03PS2) 10Legoktm: Add "abusefilter-bypass" userright as a hack for GlobalRename page moves [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/148602 [06:04:51] (03PS2) 10Ori.livneh: Remove mleb dependency for MassMessage role [vagrant] - 10https://gerrit.wikimedia.org/r/148600 (owner: 10Legoktm) [06:05:10] (03CR) 10Ori.livneh: [C: 032] Remove mleb dependency for MassMessage role [vagrant] - 10https://gerrit.wikimedia.org/r/148600 (owner: 10Legoktm) [06:05:15] (03Merged) 10jenkins-bot: Remove mleb dependency for MassMessage role [vagrant] - 10https://gerrit.wikimedia.org/r/148600 (owner: 10Legoktm) [06:05:22] ori: thanks [06:06:19] np! [06:07:05] 3MediaWiki extensions / 3Scribunto: HHVM crash loading San Francisco page - 10https://bugzilla.wikimedia.org/68196#c11 (10Tim Starling) Nice work. A Lua error in an unprotected function like lua_pushcclosure() could indeed cause a longjmp to unwind HHVM's stack. If Lua was not in the stack when this happene... [06:07:29] (03CR) 10Brian Wolff: Add a maintinance report about TimedText pages that don't have a file (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/147749 (owner: 10Brian Wolff) [06:07:35] 3MediaWiki / 3User login and signup: Replace MD5 password hashing with more secure hash - 10https://bugzilla.wikimedia.org/28419#c103 (10Liangent) (In reply to scott from comment #102) > (In reply to Liangent from comment #99) > > Bug 68389 is still a security bug. Does duping it to a public one mean it's >... [06:14:33] (03CR) 10Ori.livneh: [C: 032] Improved Redis error logging [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148452 (owner: 10Aaron Schulz) [06:14:37] (03Merged) 10jenkins-bot: Improved Redis error logging [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148452 (owner: 10Aaron Schulz) [06:25:30] (03PS1) 10Brian Wolff: [WIP] Show appropriately sized video sources first. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/148603 [06:35:43] bawolff: lead with the appropriate, follow with the inappropriate! [06:36:42] * ori was amused by the commit message subject [06:38:08] Seriously though, we are currently suggesting that 160p is the best version to use (for non-js clients) [06:39:40] (03PS2) 10Nemo bis: [WIP] Show appropriately sized video sources first. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/148603 (owner: 10Brian Wolff) [06:40:43] (03CR) 10Aude: [C: 04-1] "binding Action to Context via inheritance seems like the wrong approach, and merging with special page seems even worse." [core] - 10https://gerrit.wikimedia.org/r/143211 (owner: 10Withoutaname) [06:43:10] (03CR) 10Aude: Subclass the Action class under ContextSource (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143211 (owner: 10Withoutaname) [06:47:10] yeah, 160p is for TI calculators [06:47:36] (03CR) 10Aude: Shorten if/else to ternary expressions in WebStart.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/148503 (owner: 10Withoutaname) [06:50:47] Also, I discovered today, due to various quality settings, on some videos (one's with long periods of still frames) the 720p webm transcodes are smaller in size than the 360p [06:54:18] (03CR) 10Aude: [C: 032] Shorten if/else to ternary expressions in WebStart.php [core] - 10https://gerrit.wikimedia.org/r/148503 (owner: 10Withoutaname) [06:54:54] how is that possible? does 360p contain more streams at different bitrates? [06:55:04] i don't know anything about how webm works [06:59:33] (03Merged) 10jenkins-bot: Shorten if/else to ternary expressions in WebStart.php [core] - 10https://gerrit.wikimedia.org/r/148503 (owner: 10Withoutaname) [07:06:21] 3MediaWiki extensions / 3Scribunto: HHVM crash loading San Francisco page - 10https://bugzilla.wikimedia.org/68196#c12 (10Tim Starling) Also, because Lua is in the stack, the in_lua flag is set, so "slop" is zero. That is to say, the hack intended to fix bug 59130 is disabled. The Lua userspace takes the usa... [07:15:11] aude: wait, I'm a little confused [07:15:51] aude: you said "binding Action to Context via inheritance seems like the wrong approach" and yet also "anywhere that needs these things can get the context from action" [07:15:58] (03CR) 10Swidmann: Cache support (036 comments) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/148354 (owner: 10Swidmann) [07:16:09] (03CR) 10SG: "This patch makes the UI look hideous. If May finds out she might stab us." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148462 (owner: 10Jdlrobson) [07:16:10] withoutaname: we do not need the helper methods [07:16:21] though they are used nwo so can't delete them yet [07:16:33] i would be in favor of deprecating them [07:16:46] (03PS2) 10Swidmann: Cache support [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/148354 [07:16:59] if it's not inheritance though, how do we get the context from action [07:17:17] are you perhaps saying $this->context->getRequest() ? [07:17:44] getContext() ? [07:17:46] (03CR) 10Tweichart: [C: 031 V: 031] Cache support [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/148354 (owner: 10Swidmann) [07:18:06] fine that context is a member of Action, imho [07:18:21] wouldn't that still be the same as inheriting from contextsource [07:18:38] no [07:18:38] (03PS1) 10SG: Revert "Make Flow use mw-ui-constructive etc rather than flow-ui-" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148604 [07:18:47] * legoktm distracts aude with https://gerrit.wikimedia.org/r/#/c/148028/ [07:19:55] heh [07:20:29] (03Abandoned) 10SG: Revert "Make Flow use mw-ui-constructive etc rather than flow-ui-" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148604 (owner: 10SG) [07:23:56] (03CR) 10Aude: [C: 031] "seems good, at least in theory and think this good, but wouldn't mind a second opinion if someone else wants to review" [core] - 10https://gerrit.wikimedia.org/r/148028 (owner: 10Legoktm) [07:23:58] legoktm: there [07:24:07] :) [07:24:16] ty! [07:24:26] have to see how this would work with our code, with type hinting and all [07:24:50] probably would be useful in wikibase [07:46:10] (03PS16) 10TTO: Allow two-tier setup of transwiki import sources [core] - 10https://gerrit.wikimedia.org/r/84194 [07:48:38] 3MediaWiki / 3General/Unknown: FastStringSearch on HHVM: Assertion `!"Invalid Cell type"' failed. - 10https://bugzilla.wikimedia.org/68422 (10Ori Livneh) 3NEW p:3Unprio s:3normal a:3None osmium's HHVM is hhvm/master@f4b9fe9 plus cherry-picks b03beff from swtaarrs/hhvm and ca5a0db from tstarling/hipho... [07:52:46] (03PS12) 10Mwalker: Create attribution page [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/145187 [07:52:48] ori: https://bugzilla.wikimedia.org/show_bug.cgi?id=68423 if you have any clue why [07:52:53] 3MediaWiki extensions / 3WikidataRepo: [hhvm] Fatal error: String length exceeded 2^31-2: 2147483647 - 10https://bugzilla.wikimedia.org/68423 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs I am trying to get Wikibase tests to pass on HHVM and got to the point where the tests actually run. the te... [07:54:22] 3MediaWiki extensions / 3WikidataRepo: [hhvm] Fatal error: String length exceeded 2^31-2: 2147483647 - 10https://bugzilla.wikimedia.org/68423 (10Ori Livneh) [07:55:12] (03CR) 10Smuggli: [C: 032 V: 032] Implementes changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148055 (owner: 10Smuggli) [07:55:14] (03CR) 10jenkins-bot: [V: 04-1] Create attribution page [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/145187 (owner: 10Mwalker) [07:56:58] (03PS1) 10Pastakhov: add possibility to set property value (v 2.7.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/148610 [07:57:30] (03PS13) 10Mwalker: Create attribution page [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/145187 [07:59:41] (03CR) 10Pastakhov: [C: 032] add possibility to set property value (v 2.7.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/148610 (owner: 10Pastakhov) [07:59:48] (03Merged) 10jenkins-bot: add possibility to set property value (v 2.7.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/148610 (owner: 10Pastakhov) [08:00:35] (03CR) 10jenkins-bot: [V: 04-1] Create attribution page [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/145187 (owner: 10Mwalker) [08:03:19] (03PS14) 10Mwalker: Create attribution page [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/145187 [08:04:13] (03PS1) 10Mwalker: Render attribution page [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148611 [08:06:05] (03CR) 10jenkins-bot: [V: 04-1] Create attribution page [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/145187 (owner: 10Mwalker) [08:08:57] (03PS1) 10Spage: Use CanonicalNamespaces hook for NS_TOPIC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148612 (https://bugzilla.wikimedia.org/68419) [08:09:48] (03PS2) 1001tonythomas: Notify administrators on API failing to parse bounce emails [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/148456 [08:14:08] (03PS3) 1001tonythomas: Notify administrators on API failing to parse bounce emails [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/148456 [08:14:16] (03CR) 10Smuggli: [C: 031 V: 031] Cache support [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/148354 (owner: 10Swidmann) [08:16:05] 3MediaWiki / 3General/Unknown: Fatal error: Call to a member function getText() on a non-object in php-1.24wmf14/includes/OutputPage.php on line 1296 - 10https://bugzilla.wikimedia.org/68394#c5 (10db) 5PATC>3RESO/FIX Status Merged [08:16:39] 3MediaWiki extensions / 3WikidataRepo: black text on blue background when i keydown on suggestions menu - 10https://bugzilla.wikimedia.org/68386 (10Thiemo Mättig) 5NEW>3RESO/FIX [08:17:24] 3MediaWiki / 3Revision deletion: Add user right to see logs which are deleted by deletelogentry - 10https://bugzilla.wikimedia.org/40411#c3 (10db) 5RESO/WON>3REOP p:5Low>3Lowest s:5normal>3enhanc Making an enhancement, which can stay open. [08:17:49] (03PS2) 10Mwalker: Render attribution page [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148611 [08:18:56] (03CR) 10Legoktm: [C: 032] Use CanonicalNamespaces hook for NS_TOPIC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148612 (https://bugzilla.wikimedia.org/68419) (owner: 10Spage) [08:19:36] 3MediaWiki / 3Special pages: Disable TOC for credits and license page - 10https://bugzilla.wikimedia.org/68128#c3 (10db) A credit page is http://en.wikipedia.org/wiki/Special:Version/Credits/EventLogging but I have not found one with more than 3 headers. [08:20:15] (03Merged) 10jenkins-bot: Use CanonicalNamespaces hook for NS_TOPIC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148612 (https://bugzilla.wikimedia.org/68419) (owner: 10Spage) [08:21:29] (03PS1) 10Mwalker: Latexer should not die on a bad image [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148614 [08:21:44] (03PS2) 10Mwalker: Latexer should not die on a bad image [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148614 [08:23:45] (03CR) 10jenkins-bot: [V: 04-1] Latexer should not die on a bad image [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148614 (owner: 10Mwalker) [08:23:53] 3MediaWiki / 3Skin and page rendering: Installed skins on Special:Version does not show a version (from git) - 10https://bugzilla.wikimedia.org/68424 (10db) 3NEW p:3Unprio s:3normal a:3None Special:Version shows the git hash and timestamp for all the extensions, but the installed skins does not have... [08:25:30] (03PS3) 10Mwalker: Latexer should not die on a bad image [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148614 [08:27:07] 3MediaWiki / 3Special pages: Add plainlinks for headers on Special:Version - 10https://bugzilla.wikimedia.org/68426 (10db) 3NEW p:3Unprio s:3normal a:3None The headers "Parser extension tags" and "Parser function hooks" on Special:Version are links to mw.org and should have a class="plainlinks" to su... [08:29:02] hi hoo [08:29:19] I uploaded https://gerrit.wikimedia.org/r/148602 [08:29:22] hi legoktm :) [08:30:13] legoktm: Yikes, that's insane also :S [08:30:23] just a little less though! [08:30:49] what do you think of https://bugzilla.wikimedia.org/show_bug.cgi?id=67936 in general? [08:31:26] 3MediaWiki / 3Parser: Parser interpretes as if XY begins with non-ascii character when $wgUseTidy=true - 10https://bugzilla.wikimedia.org/17663#c13 (10db) *** Bug 68127 has been marked as a duplicate of this bug. *** [08:31:26] 3MediaWiki / 3Special pages: email address on Credits page strikes following text - 10https://bugzilla.wikimedia.org/68127#c3 (10db) 5NEW>3RESO/DUP When normal wikitext parsing is used here, than this is a duplicate of bug 40670/bug 17663 *** This bug has been marked as a duplicate of bug 17663 *** [08:31:31] (03CR) 10Hoo man: [C: 032] "Let's just hope we can remove that user right fast, because this is *ugly*" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/148602 (owner: 10Legoktm) [08:31:39] (03Merged) 10jenkins-bot: Add "abusefilter-bypass" userright as a hack for GlobalRename page moves [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/148602 (owner: 10Legoktm) [08:33:03] legoktm: Well, there are a few approaches we could take... but just disabling anything that influences the actual action (as disallowing it or blocking the user) is ok with me [08:33:29] but I fear that the implementation will get a big mess :/ [08:34:01] so you still want to run it through the filters, but just not apply the action? [08:35:22] I didn't say that, I said it's ok with me [08:35:35] both approaches actually are... and both have their pros and cons [08:36:54] hmm ok [08:37:11] 3MediaWiki / 3API: API: Allow enumerate through all categorylinks - 10https://bugzilla.wikimedia.org/68427 (10db) 3NEW p:3Unprio s:3normal a:3None With module alllinks, alltransclusion and allfileusage it is possible to enumerate through the pagelinks, templatelinks and imagelinks table, but there is... [08:38:45] legoktm: The full skip solution is easier to implement and has a better performance footprint, though [08:39:09] yeah [08:39:28] If I were to implement this I'd chose that solution... and if only to avoid adding more un-understandable code to AbuseFilter [08:40:40] 3MediaWiki / 3API: API: Allow page_id sort order for list=allpages - 10https://bugzilla.wikimedia.org/68428 (10db) 3NEW p:3Unprio s:3normal a:3None list=allpages gives pages in order of titles to the given namespace. It should also be possible to get the pages in page_id order. This allows getting n... [08:41:19] (03PS5) 10Legoktm: Hack: Prevent AbortMove hook from interfering with GlobalRename page moves [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145870 (https://bugzilla.wikimedia.org/67875) [08:41:28] hoo: ^ updated to use the userright [08:43:22] er wait [08:43:33] * legoktm sees bug [08:43:48] (03CR) 10Hoo man: [C: 04-1] "this might run us into an indefinite loop" (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145870 (https://bugzilla.wikimedia.org/67875) (owner: 10Legoktm) [08:43:57] that one? [08:44:24] no... [08:44:28] how is that an indefinite loop? [08:44:54] if another hook aborts, you will retry until timeout [08:44:59] * an other [08:45:09] no, it just retries once [08:45:38] oh, I thought it was calling movePaes again [08:45:38] meh [08:46:01] * hoo just arrived in the office and still isn't really awake it seems :P [08:46:05] :P [08:46:29] (03PS6) 10Legoktm: Hack: Prevent AbortMove hook from interfering with GlobalRename page moves [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145870 (https://bugzilla.wikimedia.org/67875) [08:46:56] (03CR) 10Legoktm: Hack: Prevent AbortMove hook from interfering with GlobalRename page moves (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145870 (https://bugzilla.wikimedia.org/67875) (owner: 10Legoktm) [08:47:50] should be good now [08:48:19] did you test it [08:48:20] ? [08:49:13] I tested one of the earlier patchsets [08:49:31] do you want me to retest it? [08:50:49] If you do so and it works, I can +2 [08:51:49] ok give me a few minutes [08:51:54] * legoktm waits for vagrant to start [09:00:16] (03PS1) 10Mwjames: 1.2.0 release [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/148615 [09:01:37] (03CR) 10Mwjames: "Not sure the 1.2.0 tag came as well!" [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/148615 (owner: 10Mwjames) [09:09:30] hoo: ok, tested and confirmed it works [09:12:16] legoktm: Yay :) [09:13:11] (03CR) 10Hoo man: "Code looks reasonably sane (especially given the commit summary starts with "Hack:")" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145870 (https://bugzilla.wikimedia.org/67875) (owner: 10Legoktm) [09:13:16] (03CR) 10Hoo man: [C: 032] Hack: Prevent AbortMove hook from interfering with GlobalRename page moves [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145870 (https://bugzilla.wikimedia.org/67875) (owner: 10Legoktm) [09:13:24] (03Merged) 10jenkins-bot: Hack: Prevent AbortMove hook from interfering with GlobalRename page moves [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145870 (https://bugzilla.wikimedia.org/67875) (owner: 10Legoktm) [09:13:26] first one was meant to be +2 :P [09:14:21] 3MediaWiki / 3API: incomplete page title in ApiParse->getSectionContent() error message - 10https://bugzilla.wikimedia.org/68416 (10Andre Klapper) p:5Unprio>3Normal [09:16:37] 3MediaWiki extensions / 3CentralAuth: GlobalRename: Page moves are being blocked by local abusefilters - 10https://bugzilla.wikimedia.org/67875#c8 (10Kunal Mehta (Legoktm)) 5PATC>3NEW Hack is merged, but we still need a proper solution. Setting bug 67936 as a blocker, since I think that is the best way t... [09:16:39] 3MediaWiki extensions / 3AbuseFilter: Provide a sane way to bypass abuse filters - 10https://bugzilla.wikimedia.org/67936 (10Kunal Mehta (Legoktm)) [09:17:02] (03CR) 10Nikerabbit: "This code will break if https://gerrit.wikimedia.org/r/#/c/147229/2/includes/Title.php is merged." [core] - 10https://gerrit.wikimedia.org/r/147229 (owner: 10Parent5446) [09:24:54] 3MediaWiki extensions / 3CentralNotice: Internal error in ApiFormatXml exception in centralnoticequerycampaign - 10https://bugzilla.wikimedia.org/68430 (10Aude) 3NEW p:3Unprio s:3normal a:3None /w/api.php?action=centralnoticequerycampaign&format=json&campaign=Plea_US Exception from line 201... [09:30:23] 3MediaWiki extensions / 3WikidataRepo: JS error when viewing old revision of item - 10https://bugzilla.wikimedia.org/68322 (10Lydia Pintscher) 5PATC>3RESO/FIX [09:30:53] 3MediaWiki extensions / 3Spam Blacklist: Site was blocked but IP was still able to add links later (due to link already present on the page?) - 10https://bugzilla.wikimedia.org/65447 (10Andre Klapper) p:5High>3Normal [09:31:25] (03PS2) 10Robert Vogel: ExtendedSearch: CSS more skin agnostic [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148339 [09:31:33] tto: I had closed https://gerrit.wikimedia.org/r/#/c/106861/ because there was no activity from you for 2 months. There is a restore option that you can use as soon as you're on it again. I didn't delete it or anything. Just keeps it out of the backlog. [09:31:38] I'm glad it's worked on now. [09:32:38] 3MediaWiki / 3API: API: Allow page_id sort order for list=allpages - 10https://bugzilla.wikimedia.org/68428 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [09:32:40] 3MediaWiki / 3API: API: Allow enumerate through all categorylinks - 10https://bugzilla.wikimedia.org/68427 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [09:33:07] 3MediaWiki / 3Special pages: Add plainlinks for headers on Special:Version - 10https://bugzilla.wikimedia.org/68426 (10Andre Klapper) p:5Unprio>3Low s:5normal>3minor [09:36:10] 3MediaWiki extensions / 3WikidataRepo: Don't treat referenced entities that are redirects as deleted in the UI - 10https://bugzilla.wikimedia.org/66971#c1 (10tobias.gritschacher) 5ASSI>3PATC https://gerrit.wikimedia.org/r/#/c/145522/ [09:36:25] 3MediaWiki extensions / 3WikidataRepo: Don't treat referenced entities that are redirects as deleted in the UI - 10https://bugzilla.wikimedia.org/66971 (10tobias.gritschacher) [09:39:35] (03CR) 10Cook879: [C: 032 V: 032] Remove trailing whitespace [extensions/Vine] - 10https://gerrit.wikimedia.org/r/141279 (owner: 10Legoktm) [09:41:06] 3MediaWiki / 3Skin and page rendering: Installed skins on Special:Version should show a version (from git) - 10https://bugzilla.wikimedia.org/68424 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [09:41:22] (03CR) 10Phuedx: "Removing the -2 per Swalling and MSyed's +1." [core] - 10https://gerrit.wikimedia.org/r/146979 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [09:41:36] 3MediaWiki / 3Skin and page rendering: Move Vector and MonoBook to separate repositories - 10https://bugzilla.wikimedia.org/68402 (10Andre Klapper) p:5Unprio>3Normal [09:42:11] (03PS1) 10Robert Vogel: BlueSpiceSkin: Added stylings for ExtendedSearch [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/148623 [09:42:46] (03CR) 10Smuggli: [C: 032 V: 032] ExtendedSearch: CSS more skin agnostic [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148339 (owner: 10Robert Vogel) [09:50:36] 3MediaWiki extensions / 3General/Unknown: User links keyboard shortcuts do not work. - 10https://bugzilla.wikimedia.org/67824#c4 (10Andre Klapper) I still do not know what are steps to reproduce the problem (as a list, step by step). Comment 0 does not provide any. [09:55:57] (03CR) 10Smuggli: [C: 032 V: 032] BlueSpiceSkin: Added stylings for ExtendedSearch [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/148623 (owner: 10Robert Vogel) [09:58:10] Krinkle: Thanks, but it wasn't left unattended because I wasn't working on it. It was stalled because no-one was coming forward to review/answer questions/decide on it! [09:58:43] If a patch is abandoned there is even less chance anyone is going to review it [10:00:04] (03CR) 10Robert Vogel: "Some hints inline" (034 comments) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/148354 (owner: 10Swidmann) [10:07:52] 3MediaWiki extensions / 3WikidataRepo: Create tests comparing the output of the old and new serializer implementation - 10https://bugzilla.wikimedia.org/66839#c2 (10Thiemo Mättig) Testing qualifiers, references and ranks is still missing. Also test UnDeserializableValue? [10:09:40] (03PS1) 10Prtksxna: Add styling for the styleguide [core] - 10https://gerrit.wikimedia.org/r/148626 [10:10:36] 3MediaWiki / 3Page editing: User links keyboard shortcuts do not work. - 10https://bugzilla.wikimedia.org/67824#c5 (10Andre Klapper) s:5minor>3normal Ah. Looks like I hover over a link in the personal top bar with my mouse, see a keyboard communication in the popup, and try to use that one. :) [10:15:41] (03CR) 10Phuedx: [C: 04-1] "This looks good in Chrome (36.0.1985.125), Safari (7.0.5), and IE8/9. In fact, it looks very good in IE8/9! However, it looks as if the ic" [core] - 10https://gerrit.wikimedia.org/r/146979 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [10:20:40] YuviPanda|zzz: ping [10:22:11] 3MediaWiki extensions / 3UniversalLanguageSelector: ULS: attrName property no longer exposed on jQuery.Event objects in jQuery 1.9 - 10https://bugzilla.wikimedia.org/66064#c4 (10Santhosh Thottingal) 5ASSI>3RESO/FIX https://gerrit.wikimedia.org/r/#/c/148608/ added the fix to MW ULS. Closing [10:27:50] (03PS1) 10Pastakhov: update Leaflet to 0.7.3 (v 0.7.1) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/148629 [10:28:11] (03CR) 10jenkins-bot: [V: 04-1] update Leaflet to 0.7.3 (v 0.7.1) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/148629 (owner: 10Pastakhov) [10:29:10] (03PS1) 10Raimond Spekking: Fix message key names [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148630 [10:29:40] (03CR) 10Raimond Spekking: [C: 032 V: 032] Fix message key names [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148630 (owner: 10Raimond Spekking) [10:30:37] 3MediaWiki extensions / 3WikidataRepo: [hhvm] Fatal error: String length exceeded 2^31-2: 2147483647 - 10https://bugzilla.wikimedia.org/68423 (10Lydia Pintscher) p:5Unprio>3Normal [10:30:48] (03CR) 10Raimond Spekking: "spo" (032 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/146786 (owner: 10Smuggli) [10:39:03] (03CR) 10Phuedx: "See https://trello-attachments.s3.amazonaws.com/5032806a85f7309c527929de/53c6c456c3f9da2967f98269/89x29/68086616eba21812ee968a2d7c41240a/S" [core] - 10https://gerrit.wikimedia.org/r/146979 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [10:39:51] 3MediaWiki extensions / 3Semantic MediaWiki: SMWSparqlStore datatype error - 10https://bugzilla.wikimedia.org/62218#c4 (10MWJames) 5PATC>3RESO/FIX Solved with [0]. [0] https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/338 [10:40:06] (03CR) 10Phuedx: "Alright, see my latest attachment to https://trello.com/c/NbPpjduW/565-update-user-icon-in-vector." [core] - 10https://gerrit.wikimedia.org/r/146979 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [10:40:47] (03PS1) 10Jack Phoenix: AJAX page watching support + small cleanup for overall readability and whatnot. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/148635 [10:42:29] (03CR) 10Jack Phoenix: [C: 032 V: 032] AJAX page watching support + small cleanup for overall readability and whatnot. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/148635 (owner: 10Jack Phoenix) [10:45:59] (03PS2) 10Pastakhov: update Leaflet to 0.7.3 (v 0.7.1) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/148629 [10:59:54] prtksxna: pong [11:00:54] YuviPanda|zzz: Where is this? http://tools.wmflabs.org/styleguide/ [11:01:12] prtksxna: at tools.wmflabs.org [11:01:14] go for more info [11:01:23] err, see there for more info [11:01:25] it's toollabs [11:02:31] YuviPanda: I think I'll create a new one to put up the new style (for testing) [11:02:41] prtksxna: ok! [11:06:50] (03PS1) 10Pwirth: BaseTemplate: TopMenuBarCustomizer [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/148636 [11:10:06] (03PS1) 10Pwirth: TopMenuBarCustomizer: Refactoring [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148638 [11:15:51] (03PS2) 10Anomie: Add $wgDebugDumpSqlLength [core] - 10https://gerrit.wikimedia.org/r/143046 [11:19:35] 3MediaWiki / 3API: API: Allow page_id sort order for list=allpages - 10https://bugzilla.wikimedia.org/68428#c1 (10Brad Jorsch) While this looks easy, anyone attempting this should be sure they are familiar with MySQL query optimization. The query is currently along the lines of "SELECT ... FROM page WHERE pa... [11:20:58] (03CR) 10Physikerwelt: "ok is there anything else we need to do?" [vagrant] - 10https://gerrit.wikimedia.org/r/147874 (https://bugzilla.wikimedia.org/66807) (owner: 10BryanDavis) [11:28:47] (03CR) 10Robert Vogel: Added cache support for extensions (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148355 (owner: 10Swidmann) [11:32:05] (03CR) 10Anomie: [C: 032] Provide namespace to ApiParse->getSectionContent [core] - 10https://gerrit.wikimedia.org/r/148575 (https://bugzilla.wikimedia.org/68416) (owner: 10Spage) [11:35:49] (03Merged) 10jenkins-bot: Provide namespace to ApiParse->getSectionContent [core] - 10https://gerrit.wikimedia.org/r/148575 (https://bugzilla.wikimedia.org/68416) (owner: 10Spage) [11:46:56] (03CR) 10Daniel Kinzler: "@hoo not really. MediaWiki comes with the wikimedia sites pre-configured for interwiki links. That's useful for 3rd party installations as" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/145764 (https://bugzilla.wikimedia.org/42207) (owner: 10Hoo man) [11:49:40] (03PS2) 10Tweichart: resourceloader + js error fix [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148366 [11:50:28] (03CR) 10Anomie: "You can also reproduce with ?action=thisdoesnotexist (look beneath the help text) or with ?action=edit&assert=thisdoesnotexist, for exampl" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/148372 (owner: 10Taueres) [11:52:13] (03CR) 10Robert Vogel: [C: 031 V: 032] BaseTemplate: TopMenuBarCustomizer [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/148636 (owner: 10Pwirth) [11:58:05] (03CR) 10Anomie: [C: 032] api.php: Use $wgRequest to retrieve User-agent string [core] - 10https://gerrit.wikimedia.org/r/147903 (owner: 10Taueres) [12:01:48] (03Merged) 10jenkins-bot: api.php: Use $wgRequest to retrieve User-agent string [core] - 10https://gerrit.wikimedia.org/r/147903 (owner: 10Taueres) [12:05:09] (03CR) 10Robert Vogel: [C: 04-1] "Please see inline comments" (039 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148638 (owner: 10Pwirth) [12:07:23] 3MediaWiki extensions / 3WikidataRepo: Alias for Special:MergeItems - 10https://bugzilla.wikimedia.org/68434 (10Vogone) 3NEW p:3Unprio s:3enhanc a:3Wikidata bugs Would it be feasible to implement the alias "Special:MergeItem" for "Special:MergeItems"? The page's already been around for a while and I... [12:33:17] (03CR) 10Robert Vogel: [C: 031 V: 031] resourceloader + js error fix [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148366 (owner: 10Tweichart) [12:43:07] 3Wikimedia / 3General/Unknown: Special:Nearby on mobile version does not work on several wikipedias - 10https://bugzilla.wikimedia.org/68437 (10Papuass) 3NEW p:3Unprio s:3normal a:3None On English wikipedia it works and is pretty fast: https://en.m.wikipedia.org/wiki/Special:Nearby On Latvian it giv... [12:46:47] (03CR) 10Calak: [C: 031] Allow two-tier setup of transwiki import sources [core] - 10https://gerrit.wikimedia.org/r/84194 (owner: 10TTO) [12:48:11] (03CR) 10Hashar: "The job need to be manually refreshed though." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/148543 (owner: 10EBernhardson) [12:56:21] 3MediaWiki / 3Skin and page rendering: Installed skins on Special:Version should show a version (from git) - 10https://bugzilla.wikimedia.org/68424#c1 (10Bartosz Dziewoński) Works for me locally. Must be a WMF misconfiguration or something. [13:01:06] 3MediaWiki / 3Skin and page rendering: Installed skins on Special:Version should show a version (from git) - 10https://bugzilla.wikimedia.org/68424#c2 (10Bartosz Dziewoński) Perhaps this has something to do with the precomputing of this information in WMF environment? https://gerrit.wikimedia.org/r/#/c/13049... [13:04:51] 3Wikimedia / 3Deployment systems: Installed skins on Special:Version should show a version (from git) - 10https://bugzilla.wikimedia.org/68424#c3 (10Bartosz Dziewoński) Nevermind, found it, and it indeed only handles the extensions/ directory and not skins/. https://gerrit.wikimedia.org/r/#/c/130560/ [13:06:50] 3MediaWiki extensions / 3CirrusSearch: beta labs: fatal error - 10https://bugzilla.wikimedia.org/68222#c1 (10Nik Everett) 5NEW>3RESO/FIX Not sure which patch resolved this but it is a-o-all-better-now. [13:07:51] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: We should dig into CirrusSearch-failures.log - 10https://bugzilla.wikimedia.org/62358#c9 (10Nik Everett) 5PATC>3NEW Shifting back to new - we'll have to reevaluate in two weeks or so once these changes hit production and we've churned through the queue. [13:09:06] 3MediaWiki extensions / 3Spam Blacklist: regex expressions starting with caret (^) not functioning as per instructions say - 10https://bugzilla.wikimedia.org/64541#c2 (10billinghurst) The regex suggested while functional for a regex is unsuccessful in preventing addition of the link. [Tested by two people on... [13:10:37] (03PS1) 10Hashar: Test gembuild for mw ruby gems [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148651 [13:13:04] (03CR) 10Hashar: [C: 032] Test gembuild for mw ruby gems [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148651 (owner: 10Hashar) [13:13:09] (03Merged) 10jenkins-bot: Test gembuild for mw ruby gems [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148651 (owner: 10Hashar) [13:22:50] (03CR) 10Parent5446: [C: 04-1] Shorten ternary expressions in RawAction.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/148597 (owner: 10Withoutaname) [13:36:25] (03CR) 10Gilles: [C: 032] Fix valid category check during preview form. [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/148533 (https://bugzilla.wikimedia.org/68394) (owner: 10Brian Wolff) [13:36:32] (03Merged) 10jenkins-bot: Fix valid category check during preview form. [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/148533 (https://bugzilla.wikimedia.org/68394) (owner: 10Brian Wolff) [13:39:25] (03CR) 10Gilles: Add a maintinance report about TimedText pages that don't have a file (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/147749 (owner: 10Brian Wolff) [13:43:42] (03PS3) 10BryanDavis: centralauth: Use hiera to allow variable customization [vagrant] - 10https://gerrit.wikimedia.org/r/148317 (https://bugzilla.wikimedia.org/67331) [13:49:08] 3Wikimedia / 3Mailing lists: Mailing list for Grant Advisory Committee - 10https://bugzilla.wikimedia.org/68179#c1 (10Tomasz W. Kozlowski) 5NEW>3ASSI a:3Tomasz W. Kozlowski Hi, Alex! I need to clear up one thing before I create the list for you. Can you confirm that, given that the list is supposed to... [13:52:35] 3Wikimedia / 3Mailing lists: Mailing list for Grant Advisory Committee - 10https://bugzilla.wikimedia.org/68179#c2 (10Alexandra Wang) (In reply to Tomasz W. Kozlowski from comment #1) > Hi, Alex! > I need to clear up one thing before I create the list for you. > > Can you confirm that, given that the list i... [14:06:40] (03PS2) 10Prtksxna: Add styling for the styleguide [core] - 10https://gerrit.wikimedia.org/r/148626 [14:12:05] 3MediaWiki extensions / 3WikidataRepo: Use ApiErrorReporter for all API errors. - 10https://bugzilla.wikimedia.org/64874 (10Marius Hoch) 5PATC>3RESO/FIX [14:16:52] (03PS3) 10Prtksxna: Add styling for the styleguide [core] - 10https://gerrit.wikimedia.org/r/148626 [14:17:21] (03PS3) 10Parent5446: Replaced hash_equals with a custom function [core] - 10https://gerrit.wikimedia.org/r/148442 (https://bugzilla.wikimedia.org/28419) [14:17:38] 3MediaWiki extensions / 3Semantic MediaWiki: SMWSparqlStore datatype error - 10https://bugzilla.wikimedia.org/62218#c5 (10MWJames) *** Bug 54714 has been marked as a duplicate of this bug. *** [14:17:38] 3MediaWiki extensions / 3Semantic MediaWiki: Virtuoso TripleStore / Special:Import / SMW_Exp_Element exception 'InvalidArgumentException' with message '$datatype' - 10https://bugzilla.wikimedia.org/54714#c7 (10MWJames) 5UNCO>3RESO/DUP *** This bug has been marked as a duplicate of bug 62218 *** [14:19:36] 3MediaWiki extensions / 3Semantic MediaWiki: Virtuoso TripleStore / Special:Import / SMW_Exp_Element exception 'InvalidArgumentException' with message '$datatype' - 10https://bugzilla.wikimedia.org/54714#c8 (10MWJames) SMW 2.0 now runs integration tests (as well as XML imports) for Virtuoso-opensource 6.1 an... [14:21:56] (03CR) 10Gilles: [C: 032] Add a maintinance report about TimedText pages that don't have a file [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/147749 (owner: 10Brian Wolff) [14:22:06] (03Merged) 10jenkins-bot: Add a maintinance report about TimedText pages that don't have a file [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/147749 (owner: 10Brian Wolff) [14:22:09] (03CR) 10Prtksxna: [C: 04-1] "a) Don't use PNG" [core] - 10https://gerrit.wikimedia.org/r/148626 (owner: 10Prtksxna) [14:23:06] 3MediaWiki extensions / 3SemanticForms: Saving pages broken in MW 1.24 - "Fatal error: Cannot access protected property EditPage::$mTokenOk" - 10https://bugzilla.wikimedia.org/67522#c1 (10heimlersimon) Can confirm this! [14:29:52] (03PS1) 10Bartosz Dziewoński: Consistently use tabs for indentation (but spaces in code comments) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/148661 [14:35:08] (03PS1) 10Withoutaname: Substituted and removed loadModes() from ImageGalleryBase.php [core] - 10https://gerrit.wikimedia.org/r/148663 [14:37:05] (03CR) 10Foxtrott: "By changing the visibility of member variables (many of which are not otherwise exposed, e.g. by a method) this patch introduces a major A" [core] - 10https://gerrit.wikimedia.org/r/133484 (owner: 10Siebrand) [14:39:23] 3MediaWiki extensions / 3SemanticForms: Saving pages broken in MW 1.24 - "Fatal error: Cannot access protected property EditPage::$mTokenOk" - 10https://bugzilla.wikimedia.org/67522 (10s7eph4n) 5UNCO>3ASSI a:5s7eph4n>3Siebrand Mazeland [14:43:49] (03PS1) 10Bartosz Dziewoński: Turn $wgExtensionFunctions[] closure into a function [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/148665 [14:50:04] ori: about 720p being smaller than 360p.. that's not too unlikely for many similar frames, if we use single pass encoding (which wouldn't be too unsuprising, since single pass encoding spends less resources than 2-pass of course). [14:51:05] 3MediaWiki / 3General/Unknown: Updating Page count doesn't work reliably when a page is moved - 10https://bugzilla.wikimedia.org/64333#c8 (10Andyrom75) Thanks :-) [14:55:06] (03PS1) 10Bartosz Dziewoński: Remove lies [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/148667 [14:56:46] thedj: is that transcodes with a filesize larger than the original, or 360p transcode larger than the 720p transcode? [14:57:12] the former is totally likely while the latter seems like it shouldn’t happen :D [15:01:38] 3Wikimedia / 3Mailing lists: Mailing list for Grant Advisory Committee - 10https://bugzilla.wikimedia.org/68179#c3 (10Tomasz W. Kozlowski) 5ASSI>3RESO/FIX The list has now been created, and I configured it to have private archives, with new members added upon administrator approval. You can configure th... [15:02:36] 3MediaWiki extensions / 3WikidataRepo: When entityIds that do not exist are in a jsondumper list file an exception is thrown - 10https://bugzilla.wikimedia.org/54277#c2 (10Marius Hoch) 5NEW>3RESO/FIX According to Daniel this is no longer a problem. [15:04:35] 3MediaWiki extensions / 3WikidataRepo: black text on blue background when i keydown on suggestions menu - 10https://bugzilla.wikimedia.org/68386 (10Marius Hoch) 5PATC>3RESO/FIX [15:09:57] (03CR) 10Bartosz Dziewoński: [C: 031] Use new OutputPageScriptsForBottomQueue hook [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/141284 (https://bugzilla.wikimedia.org/62602) (owner: 10Legoktm) [15:10:41] (03PS1) 10Aude: Update Wikidata to fix css issue in suggester [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148670 (https://bugzilla.wikimedia.org/68386) [15:10:49] andre__, hi, I will skip today's Phab meeting. Therefore, it will probably be more productive for you. :) [15:14:51] 3MediaWiki / 3Page editing: User links keyboard shortcuts do not work. - 10https://bugzilla.wikimedia.org/67824#c6 (10Derk-Jan Hartman) :“” and “Watchlist” displayed do not work in Chrome 35.0.1916.153 They work for me on Chrome 36 for the Mac at least. :In FF 30.0 the “Watchlist” shortcut is no... [15:15:11] (03CR) 10Reedy: [C: 032] Update messages list for oojs-ui [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148573 (https://bugzilla.wikimedia.org/68327) (owner: 10Jforrester) [15:16:14] brion: if i understood bawolff's comments from 8:00AM CEST this morning, he meant the latter. [15:17:52] qgil: you think so? ;) No, understandable. Thanks for the notice :) [15:17:57] brion, but if you have enough still frames, and no 2 pass, that might actually be possible I think. also, it might have to do with the chosen profile. 720p might be more efficient profile, while 360p uses 'older' version to make it more suited for the older mpeg4 hardware decoders [15:18:20] heh [15:18:33] (03Merged) 10jenkins-bot: Update messages list for oojs-ui [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148573 (https://bugzilla.wikimedia.org/68327) (owner: 10Jforrester) [15:19:35] 3MediaWiki extensions / 3WikidataRepo: black text on blue background when i keydown on suggestions menu - 10https://bugzilla.wikimedia.org/68386 (10Marius Hoch) 5PATC>3RESO/FIX [15:19:37] 3MediaWiki extensions / 3GeoData: Special:Nearby on mobile version does not work on several wikipedias - 10https://bugzilla.wikimedia.org/68437#c1 (10Andre Klapper) s:5normal>3major I can confirm the problem. [15:20:59] (03CR) 10Smuggli: [C: 032 V: 032] resourceloader + js error fix [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148366 (owner: 10Tweichart) [15:20:59] which would be pointless for our webm versions, but would make total sense for mp4 situations of course, that we likely b [15:21:12] ased our profiles off from. [15:21:46] o hi thedj [15:21:50] a 160p iphone 3GS compatible encode might be bigger than a 360p iphone 5S compatible version. [15:22:08] he bartosz [15:22:16] thedj: wanna recheck https://gerrit.wikimedia.org/r/87649 ? i want to merge that, but i'm looking for one more person to sanity-check [15:22:50] (03PS2) 10Cscott: Use `texvcjs` package to validate/translate math markup. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148591 [15:24:00] reminds me i gotta try building libvpx to JS with emscripten some time :D [15:24:22] webm+vp8 will be slower to decode than ogg+theora though [15:24:32] MatmaRex: i'm good, but do we have a ops change ready to make sure the wiki's have all namespaces whitelisted that we already know use signatures ? [15:24:32] at least, that’s the assumption so far [15:25:00] yup, should be [15:25:22] more compression almost always means more processor time to decode. [15:25:49] except with our XML history dumps :P [15:26:17] thedj: to have *all* of them, we'd have to enable this in all namespaces but ns0 :P i suggested just adding NS_PROJECT [15:26:56] thedj: i know that wm2014wiki would like this in ns0, too [15:27:25] i'm not sure if we can really do much more than that [15:27:34] yeah, we would need to figure out a bit how we are going to handle the deploy cycle for this, without too much work and without being too liberal... [15:27:36] o hi Nemo_bis, you're probably a good person to ask [15:28:15] Nemo_bis: we'll be hiding the signature button in non-talk namespaces, how to make wiki communities not hate us? https://gerrit.wikimedia.org/r/87649 [15:30:12] IIRC I already commented on that somewhere [15:30:48] https://bugzilla.wikimedia.org/show_bug.cgi?id=5645#c16 [15:31:06] gtg [15:31:10] I don't know if I agree with myself but I don't have the force to argue with myself in this moment [15:32:06] (03PS2) 10Reedy: Update Wikidata to fix css issue in suggester [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148670 (https://bugzilla.wikimedia.org/68386) (owner: 10Aude) [15:32:08] (03PS1) 10Cscott: Fix comment in texvccheck.ml [extensions/Math] - 10https://gerrit.wikimedia.org/r/148674 [15:32:10] (03PS1) 10Cscott: Remove unused empty production for `litsq_zq` in texvccheck [extensions/Math] - 10https://gerrit.wikimedia.org/r/148675 [15:32:12] (03PS1) 10Cscott: Bug fix for `\varcoppa` in texvccheck [extensions/Math] - 10https://gerrit.wikimedia.org/r/148676 [15:32:14] (03PS1) 10Cscott: Regularize spacing in `texvccheck` [extensions/Math] - 10https://gerrit.wikimedia.org/r/148677 [15:32:16] (03CR) 10Reedy: [C: 032 V: 032] Update Wikidata to fix css issue in suggester [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148670 (https://bugzilla.wikimedia.org/68386) (owner: 10Aude) [15:33:59] (03PS1) 10Matthias Mullie: Refactor querymap-related stuff [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148679 [15:34:02] (03PS1) 10Matthias Mullie: Restore editor files [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148680 [15:34:05] (03PS1) 10Matthias Mullie: Some minor cleanup/fixes in restored editor files [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148681 [15:34:08] (03PS1) 10Matthias Mullie: Convert textareas into editor objects [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148682 [15:38:17] (03CR) 10jenkins-bot: [V: 04-1] Regularize spacing in `texvccheck` [extensions/Math] - 10https://gerrit.wikimedia.org/r/148677 (owner: 10Cscott) [15:39:23] 3MediaWiki extensions / 3WikidataRepo: TimeValue-datatype doesn't wait on conversion, making wrong edits - 10https://bugzilla.wikimedia.org/68443 (10Sjoerd de Bruin) 3UNCO p:3Unprio s:3major a:3Wikidata bugs A edit says more than thousand words. In the last few days, I make mistakes like https://www.... [15:41:51] 3MediaWiki extensions / 3WikidataRepo: TimeValue-datatype doesn't wait on conversion, making wrong edits - 10https://bugzilla.wikimedia.org/68443#c1 (10Marius Hoch) Problem here is that data gets entered, the user saves it, but an older version gets saved because something is not quite down computing the lat... [15:44:05] (03CR) 10Physikerwelt: [C: 032] Remove unused empty production for `litsq_zq` in texvccheck [extensions/Math] - 10https://gerrit.wikimedia.org/r/148675 (owner: 10Cscott) [15:46:13] (03PS2) 10Cscott: Regularize spacing in `texvccheck` [extensions/Math] - 10https://gerrit.wikimedia.org/r/148677 [15:46:36] (03CR) 10Physikerwelt: [C: 032] "sorry. I must have deleted it without intention" [extensions/Math] - 10https://gerrit.wikimedia.org/r/148676 (owner: 10Cscott) [15:48:23] 3MediaWiki extensions / 3WikibaseQueryEngine: performance review of WikibaseQueryEngine - 10https://bugzilla.wikimedia.org/67535#c1 (10Nik Everett) Important dependency to also check out: "doctrine/dbal": "~2.4" [15:48:27] (03CR) 10Cscott: "FWIW, https://www.npmjs.org/package/texvcjs contains a number of other small tweaks to make texvc fully idempotent -- plus a much more com" [extensions/Math] - 10https://gerrit.wikimedia.org/r/148677 (owner: 10Cscott) [15:50:03] (03CR) 10Physikerwelt: [C: 04-1] "We need to define a merge strategy for this commit." [extensions/Math] - 10https://gerrit.wikimedia.org/r/148677 (owner: 10Cscott) [15:51:53] (03CR) 10Physikerwelt: "hopefully jenkins will merge it later on" [extensions/Math] - 10https://gerrit.wikimedia.org/r/148675 (owner: 10Cscott) [15:53:39] 3MediaWiki extensions / 3WikibaseQueryEngine: performance review of WikibaseQueryEngine - 10https://bugzilla.wikimedia.org/67535#c2 (10Nik Everett) I'm a bit worried about the update script - it looks like it wants to directly modify the schema. It'd make more sense in our environment to spit out the SQL th... [15:53:46] (03CR) 10Physikerwelt: "by the way I think this is a very good idea." [extensions/Math] - 10https://gerrit.wikimedia.org/r/148677 (owner: 10Cscott) [15:55:32] (03PS2) 10Physikerwelt: Fix comment in texvccheck.ml [extensions/Math] - 10https://gerrit.wikimedia.org/r/148674 (owner: 10Cscott) [15:55:45] (03CR) 10Physikerwelt: [C: 032] Fix comment in texvccheck.ml [extensions/Math] - 10https://gerrit.wikimedia.org/r/148674 (owner: 10Cscott) [15:57:36] (03Merged) 10jenkins-bot: Fix comment in texvccheck.ml [extensions/Math] - 10https://gerrit.wikimedia.org/r/148674 (owner: 10Cscott) [16:05:22] 3MediaWiki / 3Page editing: User links keyboard shortcuts do not work. - 10https://bugzilla.wikimedia.org/67824#c7 (10Ritu Swain) (In reply to Derk-Jan Hartman from comment #6) > They work for me on Chrome 36 for the Mac at least. Tested in Chrome 36, “” and “Watchlist” displayed do not work.... [16:06:15] (03PS2) 10Physikerwelt: Remove unused empty production for `litsq_zq` in texvccheck [extensions/Math] - 10https://gerrit.wikimedia.org/r/148675 (owner: 10Cscott) [16:06:23] thedj: +2 on https://gerrit.wikimedia.org/r/148363 maybe? :) [16:06:43] Thanks for noticing... cause I didn't :P [16:06:49] (03PS2) 10Physikerwelt: Bug fix for `\varcoppa` in texvccheck [extensions/Math] - 10https://gerrit.wikimedia.org/r/148676 (owner: 10Cscott) [16:07:01] (03PS3) 10Physikerwelt: Regularize spacing in `texvccheck` [extensions/Math] - 10https://gerrit.wikimedia.org/r/148677 (owner: 10Cscott) [16:07:59] who has access to security component bugs? [16:08:12] jackmcbarn: I do. What's up? [16:08:16] (03PS1) 10Taueres: Testing GlobalFunctions: Add test case for wfRandomString [core] - 10https://gerrit.wikimedia.org/r/148687 [16:08:37] csteipp: was there a bug opened recently about the thing at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Need_directions_with_MediaWiki:Spam-blacklist ? [16:09:07] (03PS2) 10Physikerwelt: Fix: id-attribute [extensions/Math] - 10https://gerrit.wikimedia.org/r/148535 [16:09:23] (03PS4) 10Physikerwelt: Add new MathHook [extensions/Math] - 10https://gerrit.wikimedia.org/r/147867 [16:09:41] jackmcbarn: if that is what i think it is, then there are a few public bugs about that already [16:09:41] jackmcbarn: Yes, already opened [16:09:50] Thanks for checking though [16:09:51] ;) [16:10:10] yeah, i know exactly how that works and i don't think it's really a security bug [16:11:35] i had a discussion about this before. it's possible to do far more nefarious things, like rig a template so that if a certain user tries to edit a page with it in it, they can't [16:11:57] (03PS1) 10Mvolz: Uses LocalSettings.php and Citoid.php config vars [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/148688 [16:12:00] (03CR) 10jenkins-bot: [V: 04-1] Uses LocalSettings.php and Citoid.php config vars [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/148688 (owner: 10Mvolz) [16:12:02] and as long as the blacklist works by blocking edits depending on the parsed content, it can't be fixed, since it would be harder than the halting problem [16:15:40] jackmcbarn: i'd go further and say that it just can't be feasibly fixed at all [16:15:43] (03CR) 10Mvolz: [C: 032 V: 032] Now uses action instead of button to insert [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/148044 (owner: 10Mvolz) [16:16:22] (03Abandoned) 10Mvolz: Uses LocalSettings.php and Citoid.php config vars [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/148688 (owner: 10Mvolz) [16:19:37] 3MediaWiki / 3Watchlist: Options form at the top of Special:Watchlist needs cleanup - 10https://bugzilla.wikimedia.org/48615 (10Rohan Rawat) 5NEW>3ASSI a:3Rohan Rawat [16:20:04] (03PS1) 10EBernhardson: Check error property exists before access [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148691 [16:20:42] (03CR) 10Hoo man: [C: 032] "Trivial" (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/147867 (owner: 10Physikerwelt) [16:20:50] (03PS1) 10Mvolz: Uses LocalSettings.php and Citoid.php config vars [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/148692 [16:21:10] (03CR) 10Mvolz: [C: 032 V: 032] Uses LocalSettings.php and Citoid.php config vars [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/148692 (owner: 10Mvolz) [16:21:30] MatmaRex: how so? [16:21:39] (03Merged) 10jenkins-bot: Add new MathHook [extensions/Math] - 10https://gerrit.wikimedia.org/r/147867 (owner: 10Physikerwelt) [16:21:59] if instead of blocking edits, it just made the links not show up during parse, it would work. the only problem with that is it's heavy on memcached to load the blacklist every parse [16:23:41] (03PS2) 10BryanDavis: Enforce order of Apt changing files without comparison [vagrant] - 10https://gerrit.wikimedia.org/r/148015 [16:25:21] 3MediaWiki extensions / 3SemanticForms: Error when using Special:RunQuery - "Parser state cleared while parsing" - 10https://bugzilla.wikimedia.org/66202#c1 (10Chris Koerner) I've discovered the cause of this error. Using Special:RunQuery inside of the Template used to format the results of said query/form w... [16:27:53] (03CR) 10Physikerwelt: Add new MathHook (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/147867 (owner: 10Physikerwelt) [16:27:59] (03PS3) 10BryanDavis: Enforce order of Apt changing files without comparison [vagrant] - 10https://gerrit.wikimedia.org/r/148015 [16:28:12] (03CR) 10BryanDavis: [C: 032] Enforce order of Apt changing files without comparison [vagrant] - 10https://gerrit.wikimedia.org/r/148015 (owner: 10BryanDavis) [16:28:16] (03Merged) 10jenkins-bot: Enforce order of Apt changing files without comparison [vagrant] - 10https://gerrit.wikimedia.org/r/148015 (owner: 10BryanDavis) [16:28:36] (03PS5) 10BryanDavis: Remove Package[mediawiki-math] from role::math [vagrant] - 10https://gerrit.wikimedia.org/r/147874 (https://bugzilla.wikimedia.org/66807) [16:29:05] (03CR) 10BryanDavis: [C: 032] Remove Package[mediawiki-math] from role::math [vagrant] - 10https://gerrit.wikimedia.org/r/147874 (https://bugzilla.wikimedia.org/66807) (owner: 10BryanDavis) [16:29:10] (03Merged) 10jenkins-bot: Remove Package[mediawiki-math] from role::math [vagrant] - 10https://gerrit.wikimedia.org/r/147874 (https://bugzilla.wikimedia.org/66807) (owner: 10BryanDavis) [16:30:21] 3MediaWiki-Vagrant: Provisioning the math role results in an "unmet dependencies" dpkg error - 10https://bugzilla.wikimedia.org/66807 (10Bryan Davis) 5PATC>3RESO/FIX [16:30:35] (03PS3) 10BryanDavis: labs_vagrant: Use hiera.yaml and set realm [vagrant] - 10https://gerrit.wikimedia.org/r/148315 [16:31:55] Hello!!! is anyone mainataining the centralauth role in vagrant? [16:32:08] (03CR) 10Hoo man: Add new MathHook (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/147867 (owner: 10Physikerwelt) [16:32:12] nuria: I am! [16:32:57] nuria: Do you have a specific problem with it? I'm actively running it in several vms. [16:33:04] (03CR) 10EBernhardson: [C: 032] Hygiene: Fix foo.diff check in failure. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148536 (owner: 10Jdlrobson) [16:33:34] hello, bd808 I will try again but i was getting errors on vagrant like [16:33:35] (03Merged) 10jenkins-bot: Hygiene: Fix foo.diff check in failure. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148536 (owner: 10Jdlrobson) [16:33:57] bd808: warning: /Stage[main]/Role::Centralauth/Role::Centralauth::Setup_multiwiki[centralauthtest]/Multiwiki::Settings[centralauthtest:CentralAuthPermissions]/Mediawiki::Settings[centralauthtest:CentralAuthPermissions]/File[/vagrant/settings.d/multiwiki/centralauthtestwiki/settings.d/puppet-managed/10-centralauthtest-CentralAuthPermissions.php]: Skipping because of failed dependencies [16:34:16] (03CR) 10BryanDavis: [C: 032] "YuviPanda should look into a clean way to add something similar to his new puppetception role in operations/puppet." [vagrant] - 10https://gerrit.wikimedia.org/r/148315 (owner: 10BryanDavis) [16:34:21] (03Merged) 10jenkins-bot: labs_vagrant: Use hiera.yaml and set realm [vagrant] - 10https://gerrit.wikimedia.org/r/148315 (owner: 10BryanDavis) [16:34:37] 3MediaWiki extensions / 3GeoData: Special:Nearby on mobile version does not work on several wikipedias - 10https://bugzilla.wikimedia.org/68437#c2 (10Max Semenik) 5NEW>3RESO/INV Coordinates don't appear in our database magically, you need to embed the harvesting parser function into your templates, e.g.... [16:34:42] bd808: maybe they sprang through this one: err: /Stage[main]/Multiwiki/File[/vagrant/settings.d/multiwiki]/owner: change from 502 to vagrant failed: Failed to set owner to '1001': Operation not permitted - /vagrant/settings.d/multiwiki [16:35:09] nuria: Yuck. That's a vagrant file permissions problem with the shares exported to the guest. [16:35:51] ya bd808, it only happens with centrauth role enabled [16:35:51] nuria: Is your host computer Windows based or some flavor of unix/linux/osx? [16:36:01] os [16:36:09] 3MediaWiki / 3Parser: The newline added to a template, magic word, variable, or parser function that returns line-start wikicode formatting (*#:; {|) causes unexpected parsing - 10https://bugzilla.wikimedia.org/12974 (10Helder) [16:36:09] 3MediaWiki extensions / 3SyntaxHighlight (GeSHi): enclose="none" clashes with the Wiki markup for lists - 10https://bugzilla.wikimedia.org/23674#c2 (10Helder) I added a simpler test case to https://en.wikibooks.org/w/index.php?title=Wikibooks:Sandbox&oldid=2684029 In that page the greg-g: I have an update to the FundraisingTranslateWorkflow extension on meta I'd like to push out. 10-11? 1400-1500? [16:40:00] nuria: It should have been fixed in 739a494 which was merged about a month ago. [16:40:26] ok bd808, BIG THANKS! will check and report back [16:42:26] 3MediaWiki / 3Special pages: Disable TOC for credits and license page - 10https://bugzilla.wikimedia.org/68128#c4 (10Bawolff (Brian Wolff)) The one in comment 1 has > 3 headers. [16:42:54] 3Wikimedia / 3Site requests: 300GB of files on a hard disk in need of a URI or WMF direct upload - 10https://bugzilla.wikimedia.org/67477#c13 (10jeremyb) (In reply to Fæ from comment #12) > whether the image page texts need to be included, or whether my proposal to > load the files and have the GWToolset the... [16:47:51] Nikerabbit: ? [16:48:22] (03CR) 10EBernhardson: [C: 04-1] "seems reasonable, small iteration issue" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148679 (owner: 10Matthias Mullie) [16:48:39] (03PS4) 10BryanDavis: centralauth: Use hiera to allow variable customization [vagrant] - 10https://gerrit.wikimedia.org/r/148317 (https://bugzilla.wikimedia.org/67331) [16:49:24] Isn't the variable "$re" unused? https://github.com/wikimedia/mediawiki-extensions-Translate/blob/0fe8fc62637c48a63e1441ca39d3d242beb4dc59/messagegroups/WikiPageMessageGroup.php#L64 [16:49:34] Or is this a global variable? [16:50:54] (03CR) 10BryanDavis: "Cherry-picked to sul-test.eqiad.wmflabs and used to create http://sulfinalization.wmflabs.org/ and http://login-sulfinalization.wmflabs.or" [vagrant] - 10https://gerrit.wikimedia.org/r/148317 (https://bugzilla.wikimedia.org/67331) (owner: 10BryanDavis) [16:51:03] there's no global $re; [16:52:23] so that line could be removed, right? [16:53:32] (03PS2) 10EBernhardson: Refactor querymap-related stuff [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148679 (owner: 10Matthias Mullie) [16:54:24] (03CR) 10EBernhardson: [C: 031] "PS2: Switch array iteration to appropriate for syntax" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148679 (owner: 10Matthias Mullie) [16:55:27] Reedy: ^ [16:55:54] 3MediaWiki-Vagrant / 3labs-vagrant: labs-vagrant: centralauth role doesn't work, tries to load from wmftest.net - 10https://bugzilla.wikimedia.org/67331#c5 (10Bryan Davis) The pending patch has been used to setup http://sulfinalization.wmflabs.org/ and http://login-sulfinalization.wmflabs.org/ on sul-test.eq... [16:56:08] 3MediaWiki-Vagrant / 3labs-vagrant: labs-vagrant: centralauth role doesn't work, tries to load from wmftest.net - 10https://bugzilla.wikimedia.org/67331 (10Bryan Davis) p:5Low>3Normal s:5normal>3enhanc a:3Bryan Davis [16:56:23] (03PS1) 10Wctaiwan: Handle redlinks and change placeholder [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/148702 [16:56:27] (03CR) 10EBernhardson: [C: 031] Restore editor files [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148680 (owner: 10Matthias Mullie) [16:57:25] (03PS2) 10BryanDavis: Make mobilefrontend role depend on mantle role [vagrant] - 10https://gerrit.wikimedia.org/r/148551 (owner: 10JGonera) [16:57:33] (03CR) 10BryanDavis: [C: 032] Make mobilefrontend role depend on mantle role [vagrant] - 10https://gerrit.wikimedia.org/r/148551 (owner: 10JGonera) [16:57:38] (03Merged) 10jenkins-bot: Make mobilefrontend role depend on mantle role [vagrant] - 10https://gerrit.wikimedia.org/r/148551 (owner: 10JGonera) [17:00:03] (03PS15) 10Mwalker: Create attribution page [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/145187 [17:01:13] helderwiki: ? [17:01:16] hi [17:02:33] bearND: heya! [17:02:33] Nikerabbit: I was looking at the code of the function getDefinitions() and noticed a variable "$re" which seems to be unused [17:02:49] bd808: ori bearND is trying to setup MWV, and is running into http://pastebin.com/tvwNMcx9 [17:02:53] (link a few lines above) [17:03:13] (03CR) 10jenkins-bot: [V: 04-1] Create attribution page [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/145187 (owner: 10Mwalker) [17:03:44] bearND: What version of Vagrant do you have installed? [17:04:25] bd808: hi. I've got vagrant 1.6.3 [17:04:38] 3MediaWiki extensions / 3Translate: Translation: should accept multi-line content - 10https://bugzilla.wikimedia.org/68451 (10Helder) 3NEW p:3Unprio s:3normal a:3None Currently, the extension uses this regex: $re = '~]+)>(.*?)~u'; when parsing the content of "tvar"[1], but th... [17:04:45] helderwiki: yes that is probably rendered unused in the last refactoring [17:04:57] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/148702 (owner: 10Wctaiwan) [17:05:12] helderwiki: https://github.com/wikimedia/mediawiki-extensions-Translate/commit/864782554b31636f81434bd05fd05fa1967c6303 [17:05:17] bearND: Hmm... well that kills my first suggestion (to upgrade to 1.6.3) :) [17:05:23] (03PS1) 10Awight: update FundraisingTranslateWorkflow submodule [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148703 [17:05:54] (03CR) 10Awight: [C: 032] update FundraisingTranslateWorkflow submodule [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148703 (owner: 10Awight) [17:06:34] Nikerabbit: I just reported bug 68451, which is also related to that variable. If it is as easy to fix as I think, maybe this variable should also be removed in the same commit? [17:06:57] bearND: What result do you get for the command `/Applications/Vagrant/embedded/bin/ruby --version` ? [17:08:44] bd808: ruby 2.0.0p353 (2013-11-22 revision 43784) [universal.x86_64-darwin12.5.0] [17:10:23] (03Merged) 10jenkins-bot: update FundraisingTranslateWorkflow submodule [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148703 (owner: 10Awight) [17:11:18] bearND: Ok. That's what I'd expect. Hmmm... [17:12:28] helderwiki: okay [17:12:30] bearND: How about the output of `ls -l $(which vagrant)`? Just wondering if your `vagrant` is where setup.sh expects it to be. [17:12:51] 3Wikimedia / 3Site requests: 300GB of files on a hard disk in need of a URI or WMF direct upload - 10https://bugzilla.wikimedia.org/67477#c14 (10Bawolff (Brian Wolff)) (In reply to jeremyb from comment #13) > you need to either find a developer to work with you on figuring out > gwtoolset+local HDD (good lu... [17:12:58] (03CR) 10EBernhardson: [C: 031] "seems pretty reasonable" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148681 (owner: 10Matthias Mullie) [17:14:27] (03CR) 10Siebrand: [C: 032] Consistently use tabs for indentation (but spaces in code comments) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/148661 (owner: 10Bartosz Dziewoński) [17:14:47] (03Merged) 10jenkins-bot: Consistently use tabs for indentation (but spaces in code comments) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/148661 (owner: 10Bartosz Dziewoński) [17:15:00] (03CR) 10Siebrand: [C: 032] Remove lies [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/148667 (owner: 10Bartosz Dziewoński) [17:15:01] bd808: /usr/bin/vagrant -> /Applications/Vagrant/bin/vagrant [17:16:07] bearND: Darn. We have exhausted my ideas. marxirelli is the guy we need to debug further and he's out on vacation this week. :( [17:16:56] bd808: Here's an updated pastebin: http://pastebin.com/3eBw5Zyy. Look for "Part 2" [17:17:06] (03CR) 10Siebrand: "Hmm, IIRC this is a pattern that's observed more often in WMF deployed code. Should a tracking bug be opened?" [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/148665 (owner: 10Bartosz Dziewoński) [17:17:08] 3MediaWiki extensions / 3WikidataRepo: put a link to the entity's canonical URI into the toolbox - 10https://bugzilla.wikimedia.org/54275 (10Marius Hoch) 5PATC>3RESO/FIX [17:17:09] 3MediaWiki extensions / 3WikidataRepo: put a link to the entity's concept URI into the toolbox - 10https://bugzilla.wikimedia.org/54275 (10Marius Hoch) [17:17:31] bearND: Ok, one more thing to try. See what happens when you install the plugin directly from the command line: `vagrant plugin install vagrant-vbguest` [17:17:46] I'm trying that now myself and seeing some output about Nokogiri [17:20:27] aude, yt? how do I repro https://bugzilla.wikimedia.org/show_bug.cgi?id=68423 [17:21:13] bd808: same message: Make sure that `gem install nokogiri -v '1.6.3.1'` succeeds before bundling. [17:21:28] (03CR) 10Bartosz Dziewoński: "If it's not actually causing issues, then probably it's not worth worrying about, especially since I've heard we're upgrading PHP soon. I " [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/148665 (owner: 10Bartosz Dziewoński) [17:21:56] bearND: Mine hasn't even got that far yet :( Something's up with the latest upstream plugin. [17:22:23] 3MediaWiki extensions / 3CirrusSearch: cl_sortkey for search enhancement - 10https://bugzilla.wikimedia.org/68452 (10Eran Roz) 3NEW p:3Unprio s:3enhanc a:3None [Not sure it more relevant for CirrcusSearch or for Opensearch API action but it may be useful enhancement for both] A good idea for search... [17:23:08] (03CR) 10Siebrand: "http://etherpad.wikimedia.org/p/j4Obl63I8y has the results of a quick grep in PhpStorm." [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/148665 (owner: 10Bartosz Dziewoński) [17:24:07] (03CR) 10Bartosz Dziewoński: "This might just be cargo-cult programming on my part ;)" [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/148665 (owner: 10Bartosz Dziewoński) [17:24:17] (03PS2) 10Bartosz Dziewoński: Remove lies [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/148667 [17:24:24] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/84194 (owner: 10TTO) [17:25:15] bearND: Confirmed that this is not just your problem. Installing the plugin is broken at least on OSX. [17:25:28] This is not the first time this plugin has caused problems for us. [17:25:46] (03PS2) 10EBernhardson: Restore editor files [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148680 (owner: 10Matthias Mullie) [17:25:53] 3MediaWiki extensions / 3CirrusSearch: cl_sortkey for search enhancement - 10https://bugzilla.wikimedia.org/68452#c1 (10Chad H.) p:5Unprio>3Normal Very interesting and makes sense to me. Storing the defaultsort should be pretty cheap. [17:25:53] (03CR) 10EBernhardson: [C: 032] Restore editor files [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148680 (owner: 10Matthias Mullie) [17:25:57] bd808: Thanks for checking. [17:26:11] (03PS2) 10EBernhardson: Some minor cleanup/fixes in restored editor files [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148681 (owner: 10Matthias Mullie) [17:26:23] spagewmf: i forget.. what happens to stand up on day of scrum of scrums? [17:26:25] bearND: You can hack around it by editing lib/mediawiki-vagrant/setup.rb and making the PLUGINS array be empty. [17:26:30] (03Merged) 10jenkins-bot: Restore editor files [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148680 (owner: 10Matthias Mullie) [17:26:49] bearND: That will stop making setup.sh try to install the plugin [17:27:24] bearND: Would you mind opening a bug for this in bugzilla? [17:28:15] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/148456 (owner: 1001tonythomas) [17:28:29] (03CR) 10Nikerabbit: "This code will break if https://gerrit.wikimedia.org/r/#/c/147229/2/includes/Title.php is merged." [core] - 10https://gerrit.wikimedia.org/r/140765 (https://bugzilla.wikimedia.org/66762) (owner: 10MaxSem) [17:28:39] MaxSem: on travis, using my fork of wikibase [17:28:46] (03CR) 10Nikerabbit: "Above comment was meant to be in https://gerrit.wikimedia.org/r/#/c/140765/" [core] - 10https://gerrit.wikimedia.org/r/147229 (owner: 10Parent5446) [17:29:20] my fork also has an issue in non-hhvm mode, where i missed changing a class alias some place [17:29:37] hhvm doesn't care about that [17:29:53] aude, will just cloning from gerrit and running tests work? [17:29:57] no [17:30:35] i https://github.com/filbertkm/mediawiki-extensions-Wikibase/commit/71ea67c4d7d4efdf09bb70bebe54de1652c330c2 [17:31:09] 3MediaWiki-Vagrant: vagrant plugin install fails - 10https://bugzilla.wikimedia.org/68453 (10Bernd Sitzmann) 3NEW p:3Unprio s:3normal a:3Ori Livneh on OS X 10.9.4 $ vagrant plugin install vagrant-vbguest Installing the 'vagrant-vbguest' plugin. This can take a few minutes... Bundler, the underlying sy... [17:31:20] aude, I don't need to run this in travis [17:31:21] bd808: ^ [17:31:22] i got it to where the tests run on hhvm, but need to figure out why tests don't pass in non-hhvm before submitting to master [17:31:26] MaxSem: sure :) [17:31:31] I need to repro locally [17:31:35] bd808: Should I add more info to the bug? [17:31:37] might be harder [17:31:54] greg-g joining us for sos today? [17:32:07] or run the setup that travis does or jenkins [17:32:16] bearND: Thank you. I think that's a good start. I'll add some bits [17:32:29] awjr: greg-g is out of office today at a training [17:32:36] https://github.com/filbertkm/mediawiki-extensions-Wikibase/tree/master/build/travis [17:33:02] thanks bd808 - know if anyone from platform will be coming? [17:33:27] awjr: I can jump on if you need someone to complain to :) [17:33:57] (03CR) 10Parent5446: "@Nikerabbit: It seems my patch is the actual problem. Is my patch separate from the reason Special:MyLanguages is being loaded? Because if" [core] - 10https://gerrit.wikimedia.org/r/140765 (https://bugzilla.wikimedia.org/66762) (owner: 10MaxSem) [17:34:29] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/148508 (https://bugzilla.wikimedia.org/68332) (owner: 10Bartosz Dziewoński) [17:36:07] (03CR) 10Pastakhov: [C: 032] update Leaflet to 0.7.3 (v 0.7.1) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/148629 (owner: 10Pastakhov) [17:36:13] (03CR) 10Nikerabbit: "Your patch, if/when merged, will change the behavior of getSubpage() used in this patch." [core] - 10https://gerrit.wikimedia.org/r/140765 (https://bugzilla.wikimedia.org/66762) (owner: 10MaxSem) [17:36:19] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/146440 (https://bugzilla.wikimedia.org/4488) (owner: 10Ebe123) [17:36:21] 3MediaWiki extensions / 3CirrusSearch: cl_sortkey for search enhancement - 10https://bugzilla.wikimedia.org/68452#c2 (10Chad H.) Actually, now that I think about it it could be kind of confusing for people searching if the defaultsort is set to something other than just a rearranging of words in the title.... [17:36:32] (03Merged) 10jenkins-bot: update Leaflet to 0.7.3 (v 0.7.1) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/148629 (owner: 10Pastakhov) [17:37:58] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [17:38:23] 3MediaWiki extensions / 3WikidataRepo: Introduce item-redirect permission - 10https://bugzilla.wikimedia.org/68454 (10Daniel Kinzler) 3NEW p:3Unprio s:3normal a:3Wikidata bugs We want to be able to restrict the creation of redirects to experienced users, or perhaps even to admins, since turning an it... [17:39:49] (03CR) 10Siebrand: [WIP] Interstitial notification page for renamed users (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/148420 (https://bugzilla.wikimedia.org/67995) (owner: 10BryanDavis) [17:42:21] 3MediaWiki extensions / 3Translate: Translation: should accept multi-line content - 10https://bugzilla.wikimedia.org/68451#c1 (10Niklas Laxström) PCRE_DOTALL is the suffix 's'. http://fi2.php.net/manual/en/reference.pcre.pattern.modifiers.php Please add a test case if submitting a patch. [17:42:55] (03PS4) 1001tonythomas: Notify administrators on API failing to parse bounce emails [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/148456 [17:42:57] (03CR) 10Jdlrobson: [C: 04-1] "This looks awesome!" [core] - 10https://gerrit.wikimedia.org/r/148626 (owner: 10Prtksxna) [17:45:55] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/148456 (owner: 1001tonythomas) [17:46:31] (03PS3) 10Siebrand: [WIP]Break notifications into alert and message sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 (owner: 10Bsitu) [17:47:26] (03PS1) 10Werdna: Fix undefined var issue in tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148711 [17:47:36] 3Wikimedia / 3Site requests: 300GB of files on a hard disk in need of a URI or WMF direct upload - 10https://bugzilla.wikimedia.org/67477#c15 (10Lane Rasberry) Option a is "send disk and arrange for upload with pregenerated txt files" To whom can such disks be sent? For reference and comparison, a non-tech... [17:48:35] (03PS2) 10Jdlrobson: QA: Fix undefined var issue in tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148711 (owner: 10Werdna) [17:48:51] (03CR) 10Jdlrobson: [C: 032] QA: Fix undefined var issue in tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148711 (owner: 10Werdna) [17:49:27] (03Merged) 10jenkins-bot: QA: Fix undefined var issue in tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148711 (owner: 10Werdna) [17:50:37] Nikerabbit, re https://gerrit.wikimedia.org/r/#/c/140765/ - what hook callback? [17:50:44] (03CR) 10Legoktm: [C: 032] Turn $wgExtensionFunctions[] closure into a function [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/148665 (owner: 10Bartosz Dziewoński) [17:50:49] (03Merged) 10jenkins-bot: Turn $wgExtensionFunctions[] closure into a function [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/148665 (owner: 10Bartosz Dziewoński) [17:50:58] MaxSem: LinkFix [17:51:06] $GLOBALS['wgHooks']['LinkBegin'][] = 'SpecialMyLanguage::linkfix'; [17:51:09] in Translate [17:51:09] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 (owner: 10Bsitu) [17:51:22] arrgh [17:51:27] (03CR) 10Legoktm: [C: 032] Remove lies [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/148667 (owner: 10Bartosz Dziewoński) [17:51:32] (03Merged) 10jenkins-bot: Remove lies [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/148667 (owner: 10Bartosz Dziewoński) [17:51:34] (03CR) 10Siebrand: "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148294 (owner: 10Werdna) [17:51:38] then I can commit a quick fix for Translate [17:51:55] hook handlers don't belong in special pages anyway:) [17:58:46] bd808: with latest vagrant repo I get Could not parse options: invalid option: --hiera_config=/tmp/vagrant-puppet-1/hiera.yaml [17:58:58] MaxSem: If the fix is to move it to TranslateHooks, sure [17:58:58] which i guess is not related to centralauth at all [18:00:46] nuria: Has your virtual machine been updated to Ubuntu 14.04? [18:01:38] Nikerabbit, https://gerrit.wikimedia.org/r/148712 [18:02:01] (03CR) 10MaxSem: "The hook handler issue is addressed in https://gerrit.wikimedia.org/r/148712" [core] - 10https://gerrit.wikimedia.org/r/140765 (https://bugzilla.wikimedia.org/66762) (owner: 10MaxSem) [18:02:21] bd808: no, it's 12 [18:02:47] (03PS3) 10Werdna: Rebuild topic title bars on post actions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147346 [18:03:24] MaxSem: whitespace! [18:03:41] IS IRRELEVANT [18:03:56] COMPILERS IGNORE IT SO SHOULD YOU [18:03:58] :P [18:04:04] lol [18:04:12] nuria: Ah ha. everything in the latest mediawiki-vagrant will be broken for you on 12.04. You will need to `vagrant destroy; vagrant up` to build a new guest if you want the latest greatest stuf. [18:04:22] *stuff [18:04:37] hmm [18:05:07] bd808: nothing less than latest & greatest for me [18:06:22] (03PS1) 10Jdlrobson: Correct button font-size [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148713 [18:07:30] (03CR) 10SG: [C: 04-1] "Should be applied to .mw-ui-button, not button." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148713 (owner: 10Jdlrobson) [18:07:38] 3MediaWiki-Vagrant: `vagrant provision` should warn and abort if guest OS is not 14.04 - 10https://bugzilla.wikimedia.org/68458 (10Bryan Davis) 3NEW p:3Unprio s:3normal a:3Ori Livneh We are expecting a 14.04 guest now and Puppet runs will fail with "Could not parse options: invalid option: --hiera_conf... [18:08:00] nuria: I opened https://bugzilla.wikimedia.org/show_bug.cgi?id=68458 to remind us to give a better warning for folk who need to update their guest vm. [18:08:18] thank youu [18:08:21] destroying the VM will kill the database though right? [18:08:31] or is that stored outside and i didn’t notice... [18:09:00] brion: i imagine it kills the db but shouldn't matter right, it's just a db env [18:09:09] sorry, testing env [18:09:18] depends how much stuff you’ve put into your testing environment ;) [18:09:21] but yeah usually that’s fine [18:10:17] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [18:10:37] (03CR) 10EBernhardson: [C: 032] Some minor cleanup/fixes in restored editor files [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148681 (owner: 10Matthias Mullie) [18:11:11] (03Merged) 10jenkins-bot: Some minor cleanup/fixes in restored editor files [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148681 (owner: 10Matthias Mullie) [18:11:14] (03PS1) 10Jdlrobson: Make sure buttons font-size is relative to its container [core] - 10https://gerrit.wikimedia.org/r/148715 [18:12:02] (03PS1) 10Ebe123: Show whether a page is watched though a message while editing [core] - 10https://gerrit.wikimedia.org/r/148716 (https://bugzilla.wikimedia.org/14224) [18:13:20] (03CR) 10Siebrand: [C: 032] Fixed some @params documentation (includes/utils) [core] - 10https://gerrit.wikimedia.org/r/148132 (owner: 10Umherirrender) [18:13:40] (03CR) 10Siebrand: [C: 032] Docs: {function} -> callable [core] - 10https://gerrit.wikimedia.org/r/148177 (owner: 10Umherirrender) [18:13:50] (03CR) 10Chad: [C: 032] "But if you install master OAI with core prior to your change you'd end up with a duplicate function, right?" [extensions/OAI] - 10https://gerrit.wikimedia.org/r/147337 (owner: 10Withoutaname) [18:13:58] (03PS1) 10Jdlrobson: Add hover effects to thanks and reply buttons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148717 [18:14:05] (03CR) 10Siebrand: [C: 032] Add since to @deprecated in includes/site [core] - 10https://gerrit.wikimedia.org/r/148156 (owner: 10Umherirrender) [18:14:21] (03PS1) 10Yurik: Updated to latest JsonConfig/ZeroBanner/ZeroPortal [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/148718 [18:14:39] (03PS2) 10Jdlrobson: Make sure buttons font-size is relative to its container [core] - 10https://gerrit.wikimedia.org/r/148715 [18:16:05] (03Merged) 10jenkins-bot: Move function xmlsafe from Export.php to OAI extension [extensions/OAI] - 10https://gerrit.wikimedia.org/r/147337 (owner: 10Withoutaname) [18:16:07] (03PS3) 10EBernhardson: Refactor querymap-related stuff [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148679 (owner: 10Matthias Mullie) [18:16:25] (03CR) 10SG: [C: 032] Make sure buttons font-size is relative to its container [core] - 10https://gerrit.wikimedia.org/r/148715 (owner: 10Jdlrobson) [18:16:59] (03CR) 10Siebrand: Implemented changes for translatewiki (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/146428 (owner: 10Smuggli) [18:17:19] (03PS1) 10Yurik: Updated to latest JsonConfig/ZeroBanner/ZeroPortal [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148720 [18:17:22] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/147403 (owner: 10Smuggli) [18:18:48] (03CR) 10Yurik: [C: 032] Updated to latest JsonConfig/ZeroBanner/ZeroPortal [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/148718 (owner: 10Yurik) [18:19:15] (03CR) 10Yurik: [C: 032] Updated to latest JsonConfig/ZeroBanner/ZeroPortal [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148720 (owner: 10Yurik) [18:19:21] (03CR) 10jenkins-bot: [V: 04-1] Make sure buttons font-size is relative to its container [core] - 10https://gerrit.wikimedia.org/r/148715 (owner: 10Jdlrobson) [18:19:25] (03CR) 10jenkins-bot: [V: 04-1] Refactor querymap-related stuff [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148679 (owner: 10Matthias Mullie) [18:19:28] (03CR) 10jenkins-bot: [V: 04-1] Updated to latest JsonConfig/ZeroBanner/ZeroPortal [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148720 (owner: 10Yurik) [18:20:21] (03PS3) 10Jdlrobson: Make sure buttons font-size is relative to its container [core] - 10https://gerrit.wikimedia.org/r/148715 [18:21:45] (03CR) 10Siebrand: [C: 04-1] "I don't think we should further decorate the Christmas tree that an edit page already is. Multiple queues for the same thing on an edit pa" [core] - 10https://gerrit.wikimedia.org/r/148716 (https://bugzilla.wikimedia.org/14224) (owner: 10Ebe123) [18:21:54] (03PS1) 10Yurik: Updated to latest JsonConfig/ZeroBanner/ZeroPortal [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148721 [18:22:10] (03CR) 10Yurik: [C: 032] Updated to latest JsonConfig/ZeroBanner/ZeroPortal [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148721 (owner: 10Yurik) [18:22:26] (03CR) 10EBernhardson: "retest" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148679 (owner: 10Matthias Mullie) [18:22:45] (03CR) 10EBernhardson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148679 (owner: 10Matthias Mullie) [18:22:48] (03Abandoned) 10Jdlrobson: Correct button font-size [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148713 (owner: 10Jdlrobson) [18:22:54] (03CR) 10Siebrand: "I added two designers and two product managers of WMF as reviewers that may have opinions on this feature request and the implementation." [core] - 10https://gerrit.wikimedia.org/r/148716 (https://bugzilla.wikimedia.org/14224) (owner: 10Ebe123) [18:23:33] (03CR) 10MaxSem: [C: 032] Added two more incrStats() calls [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148450 (owner: 10Aaron Schulz) [18:24:35] 3MediaWiki / 3Page editing: Show watched status near "Watch this page" checkbox as well as on top - 10https://bugzilla.wikimedia.org/14224#c11 (10James Forrester) 5PATC>3RESO/WON I think this adds unnecessary complexity, confusing and inclarity for an edge case without enough of a justification. WONTFIXi... [18:24:54] (03Abandoned) 10Jforrester: Show whether a page is watched though a message while editing [core] - 10https://gerrit.wikimedia.org/r/148716 (https://bugzilla.wikimedia.org/14224) (owner: 10Ebe123) [18:24:58] (03CR) 10SG: [C: 031] Make sure buttons font-size is relative to its container [core] - 10https://gerrit.wikimedia.org/r/148715 (owner: 10Jdlrobson) [18:25:02] (03CR) 10SG: [C: 032] Make sure buttons font-size is relative to its container [core] - 10https://gerrit.wikimedia.org/r/148715 (owner: 10Jdlrobson) [18:26:05] (03PS1) 10Jdlrobson: Watchstar should use mediawiki ui styles not flow ui for buttons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148724 (https://bugzilla.wikimedia.org/68456) [18:26:50] 3MediaWiki-Vagrant: vagrant plugin install fails - 10https://bugzilla.wikimedia.org/68453#c1 (10Bryan Davis) p:5Unprio>3High s:5normal>3major Version 0.10.0 of the vagrant-vbguest plugin *used* to install for me on OS X 10.8.5, but it now fails similarly to the report in comment #1. This plugin has be... [18:28:12] (03CR) 10BryanDavis: [C: 04-1] "Actually the more I think about this the less I like it. There is something pretty powerful about not needing to ssh into the VM to do mos" [vagrant] - 10https://gerrit.wikimedia.org/r/145788 (owner: 10Ori.livneh) [18:28:59] (03Abandoned) 10Ori.livneh: stop using shared fs for log files [vagrant] - 10https://gerrit.wikimedia.org/r/145788 (owner: 10Ori.livneh) [18:29:20] (03CR) 10SG: [C: 04-1] "Color still missing when the element is actively subscribed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148724 (https://bugzilla.wikimedia.org/68456) (owner: 10Jdlrobson) [18:29:31] (03Abandoned) 10Yurik: Updated to latest JsonConfig/ZeroBanner/ZeroPortal [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148720 (owner: 10Yurik) [18:30:41] (03PS1) 10Jdlrobson: UI regression: menu buttons should be full width [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148726 [18:32:27] (03CR) 10Yurik: [V: 032] Updated to latest JsonConfig/ZeroBanner/ZeroPortal [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/148718 (owner: 10Yurik) [18:33:28] (03Merged) 10jenkins-bot: Fixed some @params documentation (includes/utils) [core] - 10https://gerrit.wikimedia.org/r/148132 (owner: 10Umherirrender) [18:33:31] (03Merged) 10jenkins-bot: Docs: {function} -> callable [core] - 10https://gerrit.wikimedia.org/r/148177 (owner: 10Umherirrender) [18:33:35] (03Merged) 10jenkins-bot: Add since to @deprecated in includes/site [core] - 10https://gerrit.wikimedia.org/r/148156 (owner: 10Umherirrender) [18:34:21] 3MediaWiki / 3General/Unknown: Update branches in mediawiki/extensions/* for REL1_23 - 10https://bugzilla.wikimedia.org/64157#c27 (10Tisza Gergő) Not sure, if this is a bug in the one-off update process, or something that is generally not handled when creating new versions of extensions, but the .gitreview f... [18:34:45] (03CR) 10EBernhardson: [C: 04-1] "instead of wiring up these "global" pre handlers individually, it should be another object to iterate." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148679 (owner: 10Matthias Mullie) [18:34:54] (03CR) 10Hashar: "recheck" [core] - 10https://gerrit.wikimedia.org/r/148715 (owner: 10Jdlrobson) [18:34:56] (03CR) 10Siebrand: "Please add message documentation when adding messages. See https://www.mediawiki.org/wiki/I18n#Message_documentation for details." [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/142518 (owner: 10Jack Phoenix) [18:36:24] (03CR) 10Yurik: [V: 032] Updated to latest JsonConfig/ZeroBanner/ZeroPortal [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148721 (owner: 10Yurik) [18:38:23] (03PS4) 10Chad: Remove support for magic_quotes_gpc [core] - 10https://gerrit.wikimedia.org/r/144996 (https://bugzilla.wikimedia.org/11558) [18:38:29] (03PS4) 10EBernhardson: Refactor querymap-related stuff [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148679 (owner: 10Matthias Mullie) [18:44:48] (03CR) 10Aaron Schulz: [C: 04-1] Configuration rewrite, part 1 (035 comments) [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148280 (owner: 10MaxSem) [18:44:52] (03CR) 10Siebrand: "i18n/L10n reviewed." (033 comments) [extensions/SimpleChanges] - 10https://gerrit.wikimedia.org/r/134292 (owner: 10tosfos) [18:45:21] (03PS2) 10Jdlrobson: Watchstar should use mediawiki ui styles not flow ui for buttons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148724 (https://bugzilla.wikimedia.org/68456) [18:45:39] (03CR) 10Aaron Schulz: [V: 032] Added two more incrStats() calls [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148450 (owner: 10Aaron Schulz) [18:47:25] (03CR) 10MaxSem: Configuration rewrite, part 1 (031 comment) [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148280 (owner: 10MaxSem) [18:47:28] (03CR) 10EBernhardson: [C: 031] Refactor querymap-related stuff [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148679 (owner: 10Matthias Mullie) [18:47:53] 3MediaWiki extensions / 3WikidataClient: the show/hide recent changes and watchlist toggle does not respect showExternalRecentChanges setting - 10https://bugzilla.wikimedia.org/68461 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs the show/hide recent changes and watchlist toggle does not respect... [18:49:34] (03PS9) 10Aaron Schulz: Added BloomCache classes [core] - 10https://gerrit.wikimedia.org/r/143802 [18:49:35] 3Wikimedia / 3Site requests: 300GB of files on a hard disk in need of a URI or WMF direct upload - 10https://bugzilla.wikimedia.org/67477#c16 (10jeremyb) (In reply to Lane Rasberry from comment #15) > Option a is "send disk and arrange for upload with pregenerated txt files" > > To whom can such disks be se... [18:49:48] (03CR) 10Aaron Schulz: "Rebased" [core] - 10https://gerrit.wikimedia.org/r/143802 (owner: 10Aaron Schulz) [18:50:58] (03PS1) 10Gergő Tisza: Update MediaViewer submodule [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148733 [18:51:15] (03CR) 10Yaron Koren: "I realize now, looking again through the code, that I don't really understand the concept of "override". The namespace, category etc. perm" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [18:51:47] (03CR) 10Bartosz Dziewoński: [C: 04-1] "See inline. Looks sane." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/145761 (owner: 10Danny B.) [18:51:56] (03CR) 10Jdlrobson: [C: 04-1] "needs rebase" (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148682 (owner: 10Matthias Mullie) [18:55:06] 3MediaWiki / 3Skin and page rendering: Change style of "Your edit was saved." message - 10https://bugzilla.wikimedia.org/56313#c5 (10Andre Klapper) Myeongjin: Can you answer comment 3, please? [18:58:20] 3Wikimedia / 3Media storage: File and description are uploaded to different pages - 10https://bugzilla.wikimedia.org/56631 (10Andre Klapper) p:5Low>3Lowest [19:00:08] 3MediaWiki extensions / 3CheckUser: Outdated checkuser-toollinks (spam, pay services, ad domains) - 10https://bugzilla.wikimedia.org/38195#c2 (10MF-Warburg) The link to http://toolserver.org/~overlordq/scripts/checktor.fcgi is now broken as well (TS account expired). I don't know if a replacement on Labs exi... [19:01:07] 3MediaWiki extensions / 3CentralAuth: wpReasonList shouldn't be in ContentLanguage - 10https://bugzilla.wikimedia.org/41191#c2 (10Andre Klapper) (In reply to Kunal Mehta (Legoktm) from comment #1) > Isn't that intentional? So local additions/overrides to the reason list show > up for all users? Reedy: Do yo... [19:01:08] 3MediaWiki extensions / 3WikidataClient: preferences do not respect showExternalRecentChanges setting - 10https://bugzilla.wikimedia.org/68463 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs the show wikibase edits by default (in watchlist and recent changes) preference is still displayed even whe... [19:01:09] (03PS2) 10Taueres: Api request log: improve module retrieval [core] - 10https://gerrit.wikimedia.org/r/148372 [19:01:56] (03PS2) 10EBernhardson: Convert textareas into editor objects [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148682 (owner: 10Matthias Mullie) [19:02:15] (03CR) 10Danny B.: "Replied inline." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/145761 (owner: 10Danny B.) [19:02:41] (03PS2) 10Nemo bis: Make Special:Unblock link to contributions page for IP blockees [core] - 10https://gerrit.wikimedia.org/r/144829 (owner: 10TK-999) [19:03:04] (03CR) 10Nemo bis: "Looks sane, didn't test, no corrresponding bug report quickly found" [core] - 10https://gerrit.wikimedia.org/r/144829 (owner: 10TK-999) [19:03:09] (03PS2) 10Withoutaname: Shorten ternary expressions in RawAction.php [core] - 10https://gerrit.wikimedia.org/r/148597 [19:05:51] marktraceur: have you seen the mail regarding openmeetings? [19:08:56] (03CR) 10Bartosz Dziewoński: Special:Allpages replace table with unordered list (031 comment) [core] - 10https://gerrit.wikimedia.org/r/145761 (owner: 10Danny B.) [19:09:24] matanya: Yeah, I saw it [19:09:28] ok [19:09:35] I can't really do much about it except for help test [19:10:27] marktraceur: want to schedule a open source committee meeting ? [19:10:32] *an [19:10:32] (03PS1) 10Awight: update CentralNotice submodule [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/148737 [19:11:01] (03CR) 10Awight: [C: 032] update CentralNotice submodule [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/148737 (owner: 10Awight) [19:11:05] (03PS1) 10Mwalker: Add path and size information to health check [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/148738 [19:11:09] matanya: It's been a while, and there's a lot going on [19:11:21] (03CR) 10jenkins-bot: [V: 04-1] Remove support for magic_quotes_gpc [core] - 10https://gerrit.wikimedia.org/r/144996 (https://bugzilla.wikimedia.org/11558) (owner: 10Chad) [19:11:43] (03PS1) 10Awight: update CentralNotice submodule [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148739 [19:11:50] (03CR) 10Awight: [C: 032] update CentralNotice submodule [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148739 (owner: 10Awight) [19:12:05] marktraceur: ok then, it is there and anyone that wants to use can. I'm leaving it by this :) [19:12:55] (03CR) 10jenkins-bot: [V: 04-1] Add path and size information to health check [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/148738 (owner: 10Mwalker) [19:13:14] Sure [19:13:30] matanya: I think the general "try to use it for small meetings" is enough for now [19:13:33] (03PS2) 10Mwalker: Add path and size information to health check [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/148738 [19:14:58] (03CR) 10Mwalker: [C: 032] Add path and size information to health check [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/148738 (owner: 10Mwalker) [19:15:20] (03Merged) 10jenkins-bot: Add path and size information to health check [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/148738 (owner: 10Mwalker) [19:18:02] (03PS1) 10Mwalker: Updating service with new health checks [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/148740 [19:18:16] (03CR) 10Mwalker: [C: 032 V: 032] Updating service with new health checks [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/148740 (owner: 10Mwalker) [19:22:08] Nemo_bis: Thanks for your review! Should I create a bugzilla ticket then? [19:24:06] 3MediaWiki / 3Page editing: Show watched status near "Watch this page" checkbox as well as on top - 10https://bugzilla.wikimedia.org/14224#c13 (10Danny B.) 5RESO/WON>3REOP (In reply to James Forrester from comment #11) > I think this adds unnecessary complexity, confusing and inclarity for an > edge case... [19:27:07] KillerWalrus: not necessary :) [19:27:27] AaronSchulz: So the redis bloom server [19:27:30] thats internal IP right? [19:27:32] (03CR) 10Danny B.: Special:Allpages replace table with unordered list (031 comment) [core] - 10https://gerrit.wikimedia.org/r/145761 (owner: 10Danny B.) [19:27:34] * RobH is allocating one now [19:27:58] yes [19:28:18] oh, i forgot to ask [19:29:03] precise or trusty ? (precise is default for most stuff still) [19:29:13] or 'whatever the other redis servers have' ? ;] [19:29:16] whichever is easier [19:29:56] Nemo_bis: thanks :) [19:29:57] oh, should i have called this rdb? [19:30:01] (03CR) 10Gergő Tisza: "DNS lookup works now, still no idea why it didn't." [vagrant] - 10https://gerrit.wikimedia.org/r/147151 (owner: 10Gilles) [19:30:06] its not quite the same as the other rdb servers. [19:30:11] (i gave it element name) [19:30:24] this seemed to be different role [19:30:43] yeah, a different prefix name is ok [19:30:44] RoanKattouw: Trying to debug a ResourceLoader issue (it takes 10 seconds to do its startup for some reason)... I can't even get it to log profiling info. Regular api calls and other pages are profiled. As far as I know wgDebugLogGroups is set correctly [19:31:07] AaronSchulz: So yea, if we won't plan to have this across multiple servers, I'll give it an element name [19:31:15] neilk_: I don't know, man, MW profiling is dark magic to me [19:31:15] if we think we will, then we should give it some kinda cluster name. [19:31:41] RoanKattouw: ok maybe this is a profiling issue more than a RL issue. [19:32:08] RoanKattouw: off the top of your head any reason why it would take 10 seconds to do its thing every time? I assume caching is somehow failing or weird. (This is on mediawiki-vagrant). [19:32:18] (03PS5) 10Chad: Remove support for magic_quotes_gpc [core] - 10https://gerrit.wikimedia.org/r/144996 (https://bugzilla.wikimedia.org/11558) [19:32:21] 3MediaWiki / 3Page editing: Show watched status near "Watch this page" checkbox as well as on top - 10https://bugzilla.wikimedia.org/14224#c14 (10James Forrester) 5REOP>3RESO/WON (In reply to Danny B. from comment #13) > (In reply to James Forrester from comment #11) > > I think this adds unnecessary com... [19:32:25] Well the fact that it takes 10s is probably an RL-related issue :) but the fact that you can't get profiling data out is a profiling/logging issue [19:32:25] Ahm, not offhand no [19:32:32] This is for the startup module? [19:32:37] RoanKattouw: yes [19:32:37] (03PS3) 10EBernhardson: Highlight unread message from notifications link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148310 [19:32:56] Weird [19:32:59] RoanKattouw: possibly relevant: this is on hhvm [19:33:00] <^d> gerrit 144996 is happy fun times! [19:33:06] Any particular modules that if you deregister them, the problem goes away? [19:33:18] RoanKattouw: ...how could I possibly test that [19:33:34] RoanKattouw: I didn't add anything recently [19:33:37] neilk_: Well are you like developing an extension or something? Or just running pretty normal things? [19:33:39] Oh right [19:33:45] Hmm -- does using real PHP "fix" it? [19:34:34] ejegg: I don't see the CentralNotice cookies being reset... [19:34:49] the server side ones aren't yet [19:34:52] lemme read the code to see what it's testing for [19:35:00] <^d> RoanKattouw: Real php, lol. [19:35:02] RoanKattouw: I don't really know how to switch, but I'll try [19:35:02] ejegg: ah I mean the GeoIP cookie fixes [19:35:07] oh [19:35:19] ejegg: https://bugzilla.wikimedia.org/show_bug.cgi?id=66478 [19:35:41] looks like this is qchris_away 's baby [19:36:03] neilk_: Sorry if I'm being brief or anything; Wednesdays are busy days for me (for deployment scheduling reasons) [19:36:12] RoanKattouw: no worries [19:38:21] 3MediaWiki / 3Page editing: Show watched status near "Watch this page" checkbox as well as on top - 10https://bugzilla.wikimedia.org/14224#c15 (10Danny B.) Already overloaded checkbox? By what? (Not even speaking about how a checkbox - thus binary signalization - can be [already] overloaded at all...) Then... [19:41:52] 3MediaWiki / 3Page editing: Show watched status near "Watch this page" checkbox as well as on top - 10https://bugzilla.wikimedia.org/14224#c16 (10Danny B.) Thinking about it, it doesn't have to have anything in common with the checkbox - it can be just another message next to it. But if you prefer not to hav... [19:42:34] (03CR) 10Gergő Tisza: "pl_from_namespace is a recent change ( https://gerrit.wikimedia.org/r/#/c/117373/ ) and I updated the core repo code recently. I guess the" [vagrant] - 10https://gerrit.wikimedia.org/r/147151 (owner: 10Gilles) [19:42:59] (03PS1) 10Mwalker: Allow file copies across file systems [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/148744 [19:45:13] (03Abandoned) 10Hashar: Make sure buttons font-size is relative to its container [core] - 10https://gerrit.wikimedia.org/r/148715 (owner: 10Jdlrobson) [19:46:13] (03Restored) 10Hashar: Make sure buttons font-size is relative to its container [core] - 10https://gerrit.wikimedia.org/r/148715 (owner: 10Jdlrobson) [19:47:13] Ok, anyone else know why, if profiling is on for the rest of MediaWiki, it would be off for ResourceLoader? [19:48:23] (03CR) 10Hashar: "recheck" [core] - 10https://gerrit.wikimedia.org/r/148715 (owner: 10Jdlrobson) [19:48:47] (03PS1) 10EBernhardson: Enable Debug.ServerErrorMessage [vagrant] - 10https://gerrit.wikimedia.org/r/148745 [19:49:06] (03PS1) 10Withoutaname: Declare several ImageGalleryBase class members as protected [core] - 10https://gerrit.wikimedia.org/r/148746 [19:49:09] (03CR) 10Gergő Tisza: "Brian Davis pointed out that the correct syntax is" [vagrant] - 10https://gerrit.wikimedia.org/r/147151 (owner: 10Gilles) [19:49:34] (03PS2) 10Withoutaname: Declare several ImageGalleryBase class members as protected [core] - 10https://gerrit.wikimedia.org/r/148746 [19:49:46] (03CR) 10Hashar: [C: 032] Make sure buttons font-size is relative to its container [core] - 10https://gerrit.wikimedia.org/r/148715 (owner: 10Jdlrobson) [19:50:34] (03PS10) 10Aaron Schulz: Added BloomCache classes [core] - 10https://gerrit.wikimedia.org/r/143802 [19:50:46] (03PS1) 10Umherirrender: Change @since to normal text in MediaWikiPHPUnitTestListener [core] - 10https://gerrit.wikimedia.org/r/148749 [19:53:16] ejegg: qchris_away: great, the GeoIP cookie reset patch is working correctly. [19:53:33] awight: nice! [19:55:55] (03PS1) 10Umherirrender: Fix typo: MWExcepion -> MWException [core] - 10https://gerrit.wikimedia.org/r/148752 [19:56:45] (03CR) 10BryanDavis: [C: 04-1] "Good idea, wrong config file. We are trying to use /etc/hhvm/php.ini for all settings we can as the hdf config is being phased out upstrea" (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/148745 (owner: 10EBernhardson) [19:57:57] (03PS34) 10MarkTraceur: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) [19:58:35] (03PS1) 10Jforrester: resources: Switch oojs to the version optimised for environments with jQuery [core] - 10https://gerrit.wikimedia.org/r/148753 [19:59:09] (03CR) 10MarkTraceur: "I've fixed the issues, I think." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [19:59:51] (03CR) 10Ebe123: "Don't apologize, no feelings lost. This wasn't something dear to my heart and was more for coding practice (I'm not good at PHP). It could" [core] - 10https://gerrit.wikimedia.org/r/148716 (https://bugzilla.wikimedia.org/14224) (owner: 10Ebe123) [20:00:04] (03CR) 10Chad: "Aren't there use cases for partial undeletion other than merging?" [core] - 10https://gerrit.wikimedia.org/r/145027 (owner: 10Aaron Schulz) [20:01:31] (03CR) 10Chad: [C: 032] Remove RequestContext from edit.php and fixDoubleRedirects.php [core] - 10https://gerrit.wikimedia.org/r/148245 (owner: 10Withoutaname) [20:02:17] (03CR) 10MaxSem: [C: 032] Fix typo: MWExcepion -> MWException [core] - 10https://gerrit.wikimedia.org/r/148752 (owner: 10Umherirrender) [20:03:42] (03CR) 10Jdlrobson: [C: 032] Check error property exists before access [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148691 (owner: 10EBernhardson) [20:03:49] (03CR) 10jenkins-bot: [V: 04-1] Enable Debug.ServerErrorMessage [vagrant] - 10https://gerrit.wikimedia.org/r/148745 (owner: 10EBernhardson) [20:04:01] (03CR) 10jenkins-bot: [V: 04-1] Allow file copies across file systems [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/148744 (owner: 10Mwalker) [20:04:26] (03PS4) 10Hashar: Make sure buttons font-size is relative to its container [core] - 10https://gerrit.wikimedia.org/r/148715 (owner: 10Jdlrobson) [20:04:47] (03CR) 10Chad: [C: 032] Fix documentation of HistoryPager::lastLink() and make code more readable [core] - 10https://gerrit.wikimedia.org/r/142899 (owner: 10IAlex) [20:07:37] 3MediaWiki extensions / 3OAuth: Allow hiding OAuth edits in Recent Changes - 10https://bugzilla.wikimedia.org/64829#c18 (10Magnus Manske) It's been editing as bot for some time; maybe I didn't commit it? Look for 'bot' => 1 on https://bitbucket.org/magnusmanske/magnustools/src/f829ccc00ca2c4ebff1ccd004b33... [20:08:13] (03PS2) 10Hashar: UI regression: menu buttons should be full width [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148726 (owner: 10Jdlrobson) [20:11:16] ba [20:11:17] bah [20:11:25] why do our tests save user options for 127.0.0.1 [20:11:49] lol [20:12:04] indeed, why not ::1?! [20:12:23] 3MediaWiki / 3Skin and page rendering: Images with border parameter should display captions - 10https://bugzilla.wikimedia.org/68468 (10Steven Walling) 3NEW p:3Unprio s:3normal a:3None With [[mw:Thumbnail style update]] landing in the next few weeks, there is a need to support manually adding borders... [20:12:39] MatmaRex: remember, science isn't about “why”. It's about “why not”! [20:12:58] (03CR) 10Catrope: [C: 032] resources: Switch oojs to the version optimised for environments with jQuery [core] - 10https://gerrit.wikimedia.org/r/148753 (owner: 10Jforrester) [20:13:02] whuuuut [20:13:05] 3MediaWiki / 3Skin and page rendering: Images with border parameter should display captions - 10https://bugzilla.wikimedia.org/68468 (10Steven Walling) p:5Unprio>3Normal s:5normal>3enhanc [20:13:06] and it has user id of 13 [20:13:51] (03CR) 10Jdlrobson: [C: 04-1] Refactor querymap-related stuff (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148679 (owner: 10Matthias Mullie) [20:15:41] lol [20:16:08] $oldUser = User::newFromName( $user->getName() ); [20:16:15] see, you would expect this code to always work [20:16:27] but not if the $user has an invalid name! haha, got ya [20:16:51] (03CR) 10jenkins-bot: [V: 04-1] Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [20:16:54] (03PS5) 10Jdlrobson: Refactor querymap-related stuff [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148679 (owner: 10Matthias Mullie) [20:17:11] why are the tests so slow D: [20:17:20] (03CR) 10Jdlrobson: [C: 031] "@ebernhardson give it a test and merge if happy." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148679 (owner: 10Matthias Mullie) [20:17:27] (03PS3) 10Jdlrobson: Convert textareas into editor objects [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148682 (owner: 10Matthias Mullie) [20:17:36] 3MediaWiki / 3Skin and page rendering: Images with border parameter should display captions - 10https://bugzilla.wikimedia.org/68468#c1 (10Bawolff (Brian Wolff)) That doesn't really make sense. border and "thumb" or orthogonal options. If you want to be able to set a caption with border, then it would make s... [20:18:09] (03CR) 10MaxSem: [C: 032] Include ICU version in cache key for collation first letters [core] - 10https://gerrit.wikimedia.org/r/148251 (https://bugzilla.wikimedia.org/68344) (owner: 10Brian Wolff) [20:19:56] ugh [20:20:04] why does Language.php have raw error_log() calls [20:20:09] (03Merged) 10jenkins-bot: Check error property exists before access [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148691 (owner: 10EBernhardson) [20:20:17] (and shits all over my unit test output) [20:20:22] MatmaRex: Is it in the "crap the language system is broken" code path? [20:20:29] <^d> MatmaRex: s/calls/call/ [20:20:30] <^d> I see one. [20:20:35] yes [20:20:36] error_log( "\"$rawEntry\" is not a valid magic word for \"$mw->mId\"" ); [20:20:40] Cause I do remember there being some sort of issue where you can't localize the error that's trying to tell you that you can't localize anything [20:20:50] Oh, hah, no that one sounds like it shouldn't be a raw error_log() call [20:20:53] ^d: it produces billions of lines of output in failing unit tests [20:21:01] so i don't care how many there are [20:21:02] <^d> billions? [20:21:03] too many :P [20:21:19] ^d: enough that i can't scroll back up to where they start [20:21:25] might as well be billions [20:21:26] <^d> So like... > 100 [20:21:26] <^d> lol [20:22:19] can i swap it for wfDebugLog()? [20:22:27] (03CR) 10Jdlrobson: [C: 032] Convert textareas into editor objects [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148682 (owner: 10Matthias Mullie) [20:22:30] or should it be wfDebug()… [20:23:32] Probably wfWarn() would be cloaser to original intent [20:23:45] (03CR) 10jenkins-bot: [V: 04-1] Make sure buttons font-size is relative to its container [core] - 10https://gerrit.wikimedia.org/r/148715 (owner: 10Jdlrobson) [20:24:19] php docs say error_log's output can go anywhere [20:25:29] (03CR) 10Aaron Schulz: "That aren't covered by revision deletion? I can't think of any...unless you wanted to remove even stub revisions from history (e.g. Oversi" [core] - 10https://gerrit.wikimedia.org/r/145027 (owner: 10Aaron Schulz) [20:25:42] (03PS4) 10Jdlrobson: Replying to a topic visually updates watch star on topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147346 (owner: 10Werdna) [20:25:57] (03CR) 10Jdlrobson: [C: 031] "Browser tests pass. Anyone care to comment before I +2?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147346 (owner: 10Werdna) [20:26:56] (03PS2) 10Jdlrobson: Formatter Fix for related Echo change [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148011 (owner: 10Bsitu) [20:27:03] <^d> MatmaRex: Including your console with a billion lines it would seem! [20:27:48] (03CR) 10Chad: "My thought was that you want to delete most of the article's history and only restore a little bit but meh." [core] - 10https://gerrit.wikimedia.org/r/145027 (owner: 10Aaron Schulz) [20:27:58] (03PS1) 10Umherirrender: Standardize @todo [core] - 10https://gerrit.wikimedia.org/r/148760 [20:28:24] (03CR) 10Jamesmontalvo3: "If NS_MAIN is approvable by people in the group "Employees" and Category:Important is explicitly approvable by the group "Senior Employees" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [20:28:53] (03CR) 10Legoktm: [C: 04-1] "This is still occasionally used if an admin wants to delete like 100 edits from an LTA, but doesn't want to clutter up the page history." [core] - 10https://gerrit.wikimedia.org/r/145027 (owner: 10Aaron Schulz) [20:29:08] 3MediaWiki / 3Skin and page rendering: Images with border parameter should display captions - 10https://bugzilla.wikimedia.org/68468#c2 (10Steven Walling) (In reply to Bawolff (Brian Wolff) from comment #1) > If you want to be able to set a caption with border, then it would make sense > to be able to set a... [20:30:08] StevenW: Because our image parameter syntax is insane [20:30:10] (03PS2) 10Hashar: Remove RequestContext from edit.php and fixDoubleRedirects.php [core] - 10https://gerrit.wikimedia.org/r/148245 (owner: 10Withoutaname) [20:30:15] (03CR) 10Hashar: [C: 032] Remove RequestContext from edit.php and fixDoubleRedirects.php [core] - 10https://gerrit.wikimedia.org/r/148245 (owner: 10Withoutaname) [20:30:27] StevenW: I don't understand why you can't set a width if you have the frame option [20:30:38] +1 [20:30:53] Also, I'm wondering if frameless is redundant, now that thumbs have no frames? [20:30:54] (03CR) 10Jdlrobson: [C: 04-1] "To be merged when related change is merged. Please feel free to remove me as reviewer and re-add me when that happens to remove my -1 :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148011 (owner: 10Bsitu) [20:30:56] 3MediaWiki / 3Skin and page rendering: Images with border parameter should display captions - 10https://bugzilla.wikimedia.org/68468#c3 (10Bartosz Dziewoński) No, they shouldn't. That's not border is intended for. (It's used e.g. for the flag icons on Wikipedias.) [20:30:59] (03PS3) 10Jdlrobson: Add Flow notification to 'message' notification section [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148571 (owner: 10Bsitu) [20:31:10] The fact that [[File:Foo.jpg]] can embed a file at a width of 20000 pixels is also crazy [20:31:16] (03PS4) 10Jdlrobson: Add Flow notification to 'message' notification section [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148571 (owner: 10Bsitu) [20:31:19] Nobody in their right mind wants that. ever [20:31:27] (03CR) 10Jdlrobson: [C: 04-1] "Blocking code review until dependency is merged." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148571 (owner: 10Bsitu) [20:31:35] * bawolff didn't even know we had a frameless option [20:31:41] also upright is just plain stupid [20:32:05] 3MediaWiki / 3Skin and page rendering: Images with border parameter should display captions - 10https://bugzilla.wikimedia.org/68468#c4 (10Bartosz Dziewoński) Or to rephrase: if we fulfill this request, pages everywhere will horribly break. You're asking for another option in the image syntax, and it already... [20:32:15] "frameless, like thumbnail, respect user preferences for image width, but without border and no right float" [20:32:38] Hmm. I vote we make that the default behaviour [20:32:43] (03CR) 10Jdlrobson: [C: 04-1] "Added @kaldari to sanity check." (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 (owner: 10Bsitu) [20:32:55] (03CR) 10jenkins-bot: [V: 04-1] Remove RequestContext from edit.php and fixDoubleRedirects.php [core] - 10https://gerrit.wikimedia.org/r/148245 (owner: 10Withoutaname) [20:33:12] (03CR) 10Aaron Schulz: [C: 032] Standardize @todo [core] - 10https://gerrit.wikimedia.org/r/148760 (owner: 10Umherirrender) [20:34:14] Seriously, imagine if someone put [[File:Saint_Petersburg_Florida_Panorama.jpeg]] on a page [20:34:21] that is not a sane default behaviour [20:35:14] (03CR) 10Hashar: [C: 032] "Zuul got broken" [core] - 10https://gerrit.wikimedia.org/r/142899 (owner: 10IAlex) [20:35:23] (03Merged) 10jenkins-bot: Remove RequestContext from edit.php and fixDoubleRedirects.php [core] - 10https://gerrit.wikimedia.org/r/148245 (owner: 10Withoutaname) [20:36:54] (03Merged) 10jenkins-bot: Standardize @todo [core] - 10https://gerrit.wikimedia.org/r/148760 (owner: 10Umherirrender) [20:38:33] (03PS6) 10Legoktm: Remove support for magic_quotes_gpc [core] - 10https://gerrit.wikimedia.org/r/144996 (https://bugzilla.wikimedia.org/11558) (owner: 10Chad) [20:38:36] (03Merged) 10jenkins-bot: Fix documentation of HistoryPager::lastLink() and make code more readable [core] - 10https://gerrit.wikimedia.org/r/142899 (owner: 10IAlex) [20:39:36] (03CR) 10Hashar: [C: 032] "zuul got broken" [core] - 10https://gerrit.wikimedia.org/r/148251 (https://bugzilla.wikimedia.org/68344) (owner: 10Brian Wolff) [20:39:54] huh. Don't even remember that change [20:39:59] ugh. [20:40:04] how do i run unit tests for core only? [20:40:21] without actually disabling all extensions, i'm lazy [20:40:28] (03CR) 10Hashar: [C: 032] "Zuul got broken" [core] - 10https://gerrit.wikimedia.org/r/148752 (owner: 10Umherirrender) [20:40:35] MatmaRex: I usually just run tests individually by file [20:40:52] because they take soo long otherwise [20:40:55] bawolff: i'm breaking things and i need to run the entire suite [20:40:59] (03CR) 10Hashar: [C: 032] "Zuul was broken" [core] - 10https://gerrit.wikimedia.org/r/148753 (owner: 10Jforrester) [20:41:09] oh well, i'll just push to jenkins [20:41:17] oh wait, it's probably broken [20:41:38] scribunto is running like a millions tests right now [20:41:43] they're very slow and every single one is failing [20:42:51] ah, i'll just disable it [20:42:52] :( [20:42:56] Try with --exclude-group Broken,ParserFuzz,Destructive,Stub,Parser,Extensions [20:42:58] maybe [20:43:21] bawolff: what i am doing is changing the default skin [20:43:31] that breaks tests, naturally [20:43:37] I could imagine [20:43:42] i think i fixed some and i want to check :P [20:44:26] (03CR) 10Legoktm: [C: 032] Remove support for magic_quotes_gpc [core] - 10https://gerrit.wikimedia.org/r/144996 (https://bugzilla.wikimedia.org/11558) (owner: 10Chad) [20:44:54] (03CR) 10Gergő Tisza: "The thumbnail error is just" [vagrant] - 10https://gerrit.wikimedia.org/r/147151 (owner: 10Gilles) [20:45:50] 3MediaWiki / 3Skin and page rendering: Images with border parameter should display captions - 10https://bugzilla.wikimedia.org/68468#c5 (10James Forrester) I'm very tempted to WONTFIX this. The image options in MW are beyond terrible, mostly as a result of piecemeal decisions just like this. [20:47:08] James_F: Maybe we should all get together, decide how we want image syntax to be. And change it all in one clean break [20:47:20] ha-ha [20:47:22] Everyone agrees it's horrible [20:47:26] :> [20:47:33] And don't tell the wikipedians so they can't stop us [20:47:45] (03PS1) 10Bartosz Dziewoński: User: Normalize skin key from $wgDefaultSkin for default options [core] - 10https://gerrit.wikimedia.org/r/148765 [20:47:47] (03PS1) 10Bartosz Dziewoński: OutputPageTest: Don't hardcode 'vector' as default skin [core] - 10https://gerrit.wikimedia.org/r/148766 [20:47:49] (03PS1) 10Bartosz Dziewoński: ResourceLoaderModuleTest: Ensure 'vector' is a valid skin [core] - 10https://gerrit.wikimedia.org/r/148767 [20:47:50] ^ testing with jenkins after all, meh [20:47:51] (03PS1) 10Bartosz Dziewoński: Language: s/error_log/wfDebug/ [core] - 10https://gerrit.wikimedia.org/r/148768 [20:47:53] (03PS1) 10Umherirrender: Standardize regex delimiter in doc of $wgWhitelistReadRegexp [core] - 10https://gerrit.wikimedia.org/r/148769 [20:48:36] 3MediaWiki / 3Skin and page rendering: Images with border parameter should display captions - 10https://bugzilla.wikimedia.org/68468#c6 (10Steven Walling) (In reply to James Forrester from comment #5) > I'm very tempted to WONTFIX this. > > The image options in MW are beyond terrible, mostly as a result of... [20:49:06] bawolff: Yeah, definitely. TrevorParscal, cscott, gwicke, RoanKattouw, MatmaRex, mooeypoo and a few others have some thoughts, let alone the Multimedia Team. :-) [20:49:10] (03PS1) 10Bartosz Dziewoński: Merge commit '3a8081b030fb29dc9bf70b7b13de7d8519db02bd' into test [core] - 10https://gerrit.wikimedia.org/r/148774 [20:49:29] (03CR) 10Bartosz Dziewoński: [C: 04-2] "Don't mind me, just testing." [core] - 10https://gerrit.wikimedia.org/r/148774 (owner: 10Bartosz Dziewoński) [20:49:48] i have way too many pending changeset right now [20:49:52] (03PS5) 10Jdlrobson: Make UserNotLoggedIn redirect to login page [core] - 10https://gerrit.wikimedia.org/r/148144 (https://bugzilla.wikimedia.org/15484) (owner: 10Parent5446) [20:49:53] i think i'm pushing 40 [20:50:01] anybody wanna merge some? many are very simple [20:50:21] But imagine the sympathy you'll garner if you break 100 [20:50:49] bawolff: awight has 101. :> https://www.mediawiki.org/wiki/Gerrit/Reports/Open_changesets_by_owner [20:50:57] i actually barely have about thirty. [20:51:09] * awight does a dirty dance of disgrace [20:51:30] ohnoes 40 [20:51:40] * cscott i have 26 [20:51:54] Hmm, I have 40. How'd I let that get so high [20:51:54] no, but really [20:52:04] (03CR) 10Jdlrobson: [C: 031] "Looks great to me." [core] - 10https://gerrit.wikimedia.org/r/148144 (https://bugzilla.wikimedia.org/15484) (owner: 10Parent5446) [20:52:22] https://gerrit.wikimedia.org/r/148302 https://gerrit.wikimedia.org/r/148303 https://gerrit.wikimedia.org/r/148397 https://gerrit.wikimedia.org/r/148433 https://gerrit.wikimedia.org/r/148425 [20:52:27] these are all trivial ^ [20:52:45] (03Merged) 10jenkins-bot: Include ICU version in cache key for collation first letters [core] - 10https://gerrit.wikimedia.org/r/148251 (https://bugzilla.wikimedia.org/68344) (owner: 10Brian Wolff) [20:52:51] (03Merged) 10jenkins-bot: Fix typo: MWExcepion -> MWException [core] - 10https://gerrit.wikimedia.org/r/148752 (owner: 10Umherirrender) [20:52:55] (03Merged) 10jenkins-bot: resources: Switch oojs to the version optimised for environments with jQuery [core] - 10https://gerrit.wikimedia.org/r/148753 (owner: 10Jforrester) [20:52:57] (03Merged) 10jenkins-bot: Remove support for magic_quotes_gpc [core] - 10https://gerrit.wikimedia.org/r/144996 (https://bugzilla.wikimedia.org/11558) (owner: 10Chad) [20:53:17] * legoktm clicks [20:53:25] (03CR) 10Legoktm: [C: 032] Remove styles for .os-suggest and related classes [core] - 10https://gerrit.wikimedia.org/r/148302 (owner: 10Bartosz Dziewoński) [20:53:31] * bawolff proudly proclaims I have the second highest number of open patchsets in mediawiki/core not counting gerrit uploader [20:54:48] (03PS1) 10Jforrester: Update OOjs to v1.0.11 [core] - 10https://gerrit.wikimedia.org/r/148831 [20:54:49] bawolff: people must really not like your patches ;) [20:54:51] 3MediaWiki / 3Categories: IcuCollation's 'first-letters' cache key should include the version of ICU and possibly PHP that was used to build the data - 10https://bugzilla.wikimedia.org/68344 (10Max Semenik) 5PATC>3RESO/FIX [20:55:04] (03CR) 10Legoktm: [C: 032] "mwgrep didn't find any usages either." [core] - 10https://gerrit.wikimedia.org/r/148303 (owner: 10Bartosz Dziewoński) [20:55:17] cscott: Heck, there's probably a couple in there that even I don't like [20:55:58] (03CR) 10Catrope: [C: 032] Update OOjs to v1.0.11 [core] - 10https://gerrit.wikimedia.org/r/148831 (owner: 10Jforrester) [20:56:42] (03CR) 10Legoktm: "I hate to be that guy but...code on wiki is CC-BY-SA and this is making it GPLv2+." [core] - 10https://gerrit.wikimedia.org/r/148397 (owner: 10Bartosz Dziewoński) [20:56:57] (03CR) 10Cscott: [C: 032] DefaultSettings: Update documentation for skin-related variables [core] - 10https://gerrit.wikimedia.org/r/148425 (owner: 10Bartosz Dziewoński) [20:57:08] (03CR) 10Bartosz Dziewoński: "Hah, true. Krinkle, is it okay with you?" [core] - 10https://gerrit.wikimedia.org/r/148397 (owner: 10Bartosz Dziewoński) [20:59:33] (03CR) 10Legoktm: [C: 04-1] "Minor" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/148424 (https://bugzilla.wikimedia.org/68332) (owner: 10Bartosz Dziewoński) [21:01:06] 3MediaWiki / 3Skin and page rendering: Images with border parameter should display captions - 10https://bugzilla.wikimedia.org/68468#c7 (10James Forrester) (In reply to Steven Walling from comment #6) > (In reply to James Forrester from comment #5) > > I'm very tempted to WONTFIX this. > > > > The image opt... [21:01:13] (03CR) 10Legoktm: [C: 04-1] "I don't think this will work? Vector.php is loaded in Setup.php, which is after LocalSettings.php is included." [core] - 10https://gerrit.wikimedia.org/r/148433 (owner: 10Bartosz Dziewoński) [21:01:24] (03CR) 10Bartosz Dziewoński: [C: 032] "Silly jenkins, try again?" [core] - 10https://gerrit.wikimedia.org/r/148715 (owner: 10Jdlrobson) [21:02:04] (03CR) 10jenkins-bot: [V: 04-1] Standardize regex delimiter in doc of $wgWhitelistReadRegexp [core] - 10https://gerrit.wikimedia.org/r/148769 (owner: 10Umherirrender) [21:02:28] legoktm: awww. who cares? [21:02:39] also, it probably should work, why wouldn't it? [21:02:46] (i didn't test of course) [21:02:49] cares about what? [21:03:09] the $wg won't work...if you set it in your LocalSettings.php, then Setup.php requires Vector.php, the defaults will override [21:04:48] (03PS4) 10Bsitu: Break notifications into alert and message sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 [21:05:37] 3MediaWiki-Vagrant: luasandbox.so: undefined symbol: zend_objects_destroy_object - 10https://bugzilla.wikimedia.org/67831#c5 (10Nik Everett) I'm getting this after nuking and reprovisioning: Uncaught exception: Could not open extension /usr/lib/hphp/extensions/20131007/luasandbox.so: /usr/lib/hphp/extensions/... [21:05:44] (03CR) 10jenkins-bot: [V: 04-1] Merge commit '3a8081b030fb29dc9bf70b7b13de7d8519db02bd' into test [core] - 10https://gerrit.wikimedia.org/r/148774 (owner: 10Bartosz Dziewoński) [21:05:52] meh [21:05:56] right [21:06:16] (03CR) 10Legoktm: [C: 04-1] "Should SkinFallback be in skins/?" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/148508 (https://bugzilla.wikimedia.org/68332) (owner: 10Bartosz Dziewoński) [21:06:37] MatmaRex: also I feel weird about moving config options still in core outside of DefaultSettings.php [21:07:01] yeah, let's just do that after i stop requiring Vector in Setup.php [21:07:10] (i have a pending patch for that :D) [21:07:20] 3MediaWiki-Vagrant: luasandbox.so: undefined symbol: zend_objects_destroy_object - 10https://bugzilla.wikimedia.org/67831#c6 (10Nik Everett) Apache wasn't working either.... [21:07:38] i really need to write a beefy wikitech email about this [21:07:38] (03PS5) 10Bsitu: Break notifications into alert and message sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 [21:09:02] (03Merged) 10jenkins-bot: Remove styles for .os-suggest and related classes [core] - 10https://gerrit.wikimedia.org/r/148302 (owner: 10Bartosz Dziewoński) [21:09:19] (03PS1) 10BryanDavis: hhvm: Update dynamic extension path [vagrant] - 10https://gerrit.wikimedia.org/r/148835 [21:10:03] manybubbles: ^ [21:13:47] (03CR) 10Legoktm: [C: 032] User: Normalize skin key from $wgDefaultSkin for default options [core] - 10https://gerrit.wikimedia.org/r/148765 (owner: 10Bartosz Dziewoński) [21:15:12] (03CR) 10Legoktm: [C: 04-1] "Instead of this, in the main test function below, just set 'wgDefaultSkin' => 'vector'. RL doesn't actually check the skin exists (IIRC), " [core] - 10https://gerrit.wikimedia.org/r/148766 (owner: 10Bartosz Dziewoński) [21:18:22] (03PS2) 10Legoktm: ResourceLoaderModuleTest: Ensure 'vector' is a valid skin [core] - 10https://gerrit.wikimedia.org/r/148767 (owner: 10Bartosz Dziewoński) [21:18:48] (03CR) 10Legoktm: [C: 032] ResourceLoaderModuleTest: Ensure 'vector' is a valid skin [core] - 10https://gerrit.wikimedia.org/r/148767 (owner: 10Bartosz Dziewoński) [21:19:51] (03Abandoned) 10Umherirrender: Standardize regex delimiter in doc of $wgWhitelistReadRegexp [core] - 10https://gerrit.wikimedia.org/r/148769 (owner: 10Umherirrender) [21:22:19] (03CR) 10Brian Wolff: "This appears to cause problems with audio files. Since the play button has a higher z-index than the control bar, it now is over top the c" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/108637 (owner: 10Brian Wolff) [21:25:15] (03CR) 10Bartosz Dziewoński: "That won't work with https://gerrit.wikimedia.org/r/#/c/148508/1 merged. It seems that it checks if the provided key is valid (probably wi" [core] - 10https://gerrit.wikimedia.org/r/148766 (owner: 10Bartosz Dziewoński) [21:27:57] (03PS4) 10Withoutaname: Remove deprecated $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/148570 (https://bugzilla.wikimedia.org/60459) [21:28:49] (03PS1) 10Umherirrender: Fix typo: expectedExceptionMesage -> expectedExceptionMessage [core] - 10https://gerrit.wikimedia.org/r/148840 [21:31:03] (03CR) 10Smuggli: [C: 032 V: 032] Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/147403 (owner: 10Smuggli) [21:36:38] (03PS1) 10Umherirrender: Fix deprecated of ApiQuery::setGeneratorContinue [core] - 10https://gerrit.wikimedia.org/r/148841 [21:36:51] MatmaRex: arg. [21:38:44] (03CR) 10Physikerwelt: "see" [services/mathoid] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/147870 (owner: 10Physikerwelt) [21:39:20] (03CR) 10Hashar: "We definitely require PHPUnit 3.7 and any older version will never run with it :-) I would just remove the comments entirely." [core] - 10https://gerrit.wikimedia.org/r/148749 (owner: 10Umherirrender) [21:39:42] Hi I need a little api help for mediawiki.. I want to create a edit query to edit a parametre in template suppose "author" in https://www.mediawiki.org/wiki/Extension:ConfirmEdit, I am not able to construct that query... please help... [21:40:27] I think parameters in a template can be edited directly... i have heard about it.. but not sure how to do it [21:40:46] (03CR) 10Nikerabbit: [C: 032] Fix typo: expectedExceptionMesage -> expectedExceptionMessage [core] - 10https://gerrit.wikimedia.org/r/148840 (owner: 10Umherirrender) [21:41:13] (03Merged) 10jenkins-bot: Remove backwards-compatibility module alias 'mediawiki.action.watch.ajax' [core] - 10https://gerrit.wikimedia.org/r/148303 (owner: 10Bartosz Dziewoński) [21:41:14] apexkid1: If you could link me to the account you heard of direct template parameter editing, I'd be intrigued. [21:41:16] (03Merged) 10jenkins-bot: Update OOjs to v1.0.11 [core] - 10https://gerrit.wikimedia.org/r/148831 (owner: 10Jforrester) [21:41:19] (03Merged) 10jenkins-bot: DefaultSettings: Update documentation for skin-related variables [core] - 10https://gerrit.wikimedia.org/r/148425 (owner: 10Bartosz Dziewoński) [21:41:21] (03Merged) 10jenkins-bot: Make sure buttons font-size is relative to its container [core] - 10https://gerrit.wikimedia.org/r/148715 (owner: 10Jdlrobson) [21:41:29] I think you're going to have to parse the template call on your end to accomplish this, but I could be wrong. [21:41:41] At the very least, let something parse it so it makes sense. [21:41:50] marktraceur: someone sorta kinda made parsoid almost do it, i think [21:42:04] MatmaRex: I don't like the idea of making the test output vary like that. Adding "$ctx->setSkin( Skin::newFromKey( 'vector' ) );" gets rid of the assumption that Vector is the default. [21:42:09] marktraceur: Sorry i may have understood it wrong. Hence i am looking for the way to do it. [21:42:26] It's OK apexkid1 [21:42:33] It sounds like Parsoid *might* be able to help [21:42:37] But not with all templates [21:42:53] marktraceur: https://en.wikipedia.org/wiki/User:Jackmcbarn/editProtectedHelper.js [21:42:59] marktraceur: I have to do for extensions template, what do you think about it? https://www.mediawiki.org/wiki/Extension:ConfirmEdit [21:43:40] apexkid1: if you want to use the script MatmaRex mentioned, look in the history a few revs back to get a generic version [21:43:51] legoktm: if you can make that work with vector no longer being loaded, sure [21:43:57] legoktm: but i don't think it will work [21:44:02] it wont :| [21:44:10] (03Merged) 10jenkins-bot: User: Normalize skin key from $wgDefaultSkin for default options [core] - 10https://gerrit.wikimedia.org/r/148765 (owner: 10Bartosz Dziewoński) [21:44:13] (03Merged) 10jenkins-bot: ResourceLoaderModuleTest: Ensure 'vector' is a valid skin [core] - 10https://gerrit.wikimedia.org/r/148767 (owner: 10Bartosz Dziewoński) [21:44:21] the problem is that OutputPage::makeResourceLoaderLink is dependent upon the current skin [21:44:32] legoktm: you could also just hardcode 'fallback' there, but it will in turn only work with no skins installed [21:45:19] jackmcbarn: I need a python code :| [21:45:19] I don't think Skin::newFromKey checks $wgSkipSkins [21:45:23] (03PS2) 10Bartosz Dziewoński: Language: s/error_log/wfDebug/ [core] - 10https://gerrit.wikimedia.org/r/148768 [21:45:30] apexkid1: you can use https://github.com/earwig/mwparserfromhell [21:45:44] cool :) [21:45:55] (03CR) 10Kaldari: [C: 032] "OK, looks like the hook handler is fixed by change Id28c7659e (which has been merged) and the other issue is unrelated to this patch. Goin" [core] - 10https://gerrit.wikimedia.org/r/140765 (https://bugzilla.wikimedia.org/66762) (owner: 10MaxSem) [21:46:18] legoktm: no haste, i still need to fix other problems [21:46:26] well, one problem, actually [21:46:31] https://gerrit.wikimedia.org/r/#/c/148774/1 [21:46:50] (03Merged) 10jenkins-bot: Fix typo: expectedExceptionMesage -> expectedExceptionMessage [core] - 10https://gerrit.wikimedia.org/r/148840 (owner: 10Umherirrender) [21:46:54] (03PS11) 10Aaron Schulz: Added BloomCache classes [core] - 10https://gerrit.wikimedia.org/r/143802 [21:47:01] it turns out Preferences.php is not happy when a 'select'-type option has no valid values [21:48:23] (03PS2) 10Umherirrender: Removed @since in MediaWikiPHPUnitTestListener [core] - 10https://gerrit.wikimedia.org/r/148749 [21:48:50] 3MediaWiki / 3Special pages: Move "Special:MyLanguage" from Extension:Translate to MediaWiki core - 10https://bugzilla.wikimedia.org/66762 (10Ryan Kaldari) 5PATC>3RESO/FIX [21:49:00] (03CR) 10Umherirrender: "Patch Set 2: Removed @since" [core] - 10https://gerrit.wikimedia.org/r/148749 (owner: 10Umherirrender) [21:50:18] (03PS1) 10Legoktm: OutputPageTest: Don't assume Vector is the default skin [core] - 10https://gerrit.wikimedia.org/r/148846 [21:50:28] MatmaRex: ^ [21:50:38] better solution for now IMO [21:51:11] (03CR) 10Nikerabbit: "I'm not in favor of masking problems. This can be a temporary measure but that means there should at minimum be a bug open with enough det" [core] - 10https://gerrit.wikimedia.org/r/148768 (owner: 10Bartosz Dziewoński) [21:51:16] (03PS2) 10Legoktm: OutputPageTest: Don't assume Vector is the default skin [core] - 10https://gerrit.wikimedia.org/r/148846 [21:51:20] 3MediaWiki-Vagrant: vagrant plugin install fails - 10https://bugzilla.wikimedia.org/68453#c2 (10Bryan Davis) I eventually got the plugin to install, but it took a long time and gave some ominous looking warnings along the way: $ vagrant plugin install vagrant-vbguest Installing the 'vagrant-vbguest' plugin. T... [21:51:42] (03PS1) 10Umherirrender: Fix @deprecated of ImageGalleryBase [core] - 10https://gerrit.wikimedia.org/r/148849 [21:51:44] (03CR) 10Hashar: [C: 031] "Thanks for the cleanup :-)" [core] - 10https://gerrit.wikimedia.org/r/148749 (owner: 10Umherirrender) [21:55:22] talking about https://www.mediawiki.org/wiki/Requests_for_comment/Composer_managed_libraries_for_use_on_WMF_cluster in #wikimedia-office in 5 min [21:57:41] (03PS3) 10Legoktm: OutputPageTest: Don't assume Vector is the default skin [core] - 10https://gerrit.wikimedia.org/r/148846 [21:58:00] (03CR) 10BryanDavis: "Just running `vagrant provision` didn't update my hhvm and extension builds to need this. I had to run `sudo apt-get install hhvm hhvm-dev" [vagrant] - 10https://gerrit.wikimedia.org/r/148835 (owner: 10BryanDavis) [21:58:05] 3Wikimedia / 3Site requests: Turn on Extension:Translate on foundationwiki (for use with board resolutions and project overviews) - 10https://bugzilla.wikimedia.org/44871#c33 (10Ryan Kaldari) 5REOP>3RESO/WON Bug 66762 has been fixed, so this bug is no longer needed (by me at least). Reclosing. [21:58:15] (03PS1) 10Werdna: Fix "page is fully loaded" condition again [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148851 [21:58:39] (03CR) 10Jdlrobson: [C: 04-1] "smaller patch needed!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148851 (owner: 10Werdna) [21:59:33] (03PS1) 10Werdna: Fix "page is fully loaded" condition again [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148853 [22:00:46] (03PS1) 10Werdna: WIP, QA: Lots of browser test fixes. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148854 [22:03:39] talking about https://www.mediawiki.org/wiki/Requests_for_comment/Composer_managed_libraries_for_use_on_WMF_cluster in #wikimedia-office now - DanielK_WMDE you may be interested in this, JeroenDeDauw too [22:08:27] (03PS2) 10Jdlrobson: QA: Fix "page is fully loaded" condition again [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148853 (owner: 10Werdna) [22:09:00] (03CR) 10Jdlrobson: [C: 032] QA: Fix "page is fully loaded" condition again [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148853 (owner: 10Werdna) [22:09:04] (03PS1) 10Aude: Add autoloader-suffix config to composer.json [core/vendor] - 10https://gerrit.wikimedia.org/r/148859 [22:11:48] (03CR) 10Aaron Schulz: [C: 032] Add $wgDebugDumpSqlLength [core] - 10https://gerrit.wikimedia.org/r/143046 (owner: 10Anomie) [22:17:01] (03PS6) 10Bsitu: Break notifications into alert and message sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 [22:17:35] (03CR) 10Yaron Koren: "What if you have both an "Important" and "Unimportant" category in the same namespace?" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [22:20:33] (03CR) 10Aaron Schulz: Added password hashing API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/77645 (https://bugzilla.wikimedia.org/54948) (owner: 10Parent5446) [22:20:49] (03Merged) 10jenkins-bot: QA: Fix "page is fully loaded" condition again [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148853 (owner: 10Werdna) [22:22:01] (03PS37) 10Aaron Schulz: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (https://bugzilla.wikimedia.org/54948) (owner: 10Parent5446) [22:22:38] (03CR) 10Bartosz Dziewoński: "I can let you ssh into my VM where running PHPUnit tests triggers this if you feel like debugging. I definitely don't. :)" [core] - 10https://gerrit.wikimedia.org/r/148768 (owner: 10Bartosz Dziewoński) [22:23:58] (03Merged) 10jenkins-bot: Integrate Special:MyLanguage from the Translate extension [core] - 10https://gerrit.wikimedia.org/r/140765 (https://bugzilla.wikimedia.org/66762) (owner: 10MaxSem) [22:30:57] (03PS1) 10BearND: [WIP] Add flag icon for article/page issues links [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/148866 [22:30:59] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add flag icon for article/page issues links [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/148866 (owner: 10BearND) [22:32:08] (03Merged) 10jenkins-bot: Add $wgDebugDumpSqlLength [core] - 10https://gerrit.wikimedia.org/r/143046 (owner: 10Anomie) [22:34:14] (03PS2) 10BearND: [WIP] Add flag icon for article/page issues links [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/148866 [22:35:11] (03PS3) 10MaxSem: Configuration rewrite, part 1 [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148280 [22:37:21] (03PS1) 10Spage: More robust API error reporting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148870 (https://bugzilla.wikimedia.org/68474) [22:44:01] Ok, bd808, YuviPanda, and superm401, a little bird told me you might be able to help with some vexing mediawiki-vagrant issues. [22:44:27] neilk_, maybe, what are the symptoms? [22:44:34] The unifying issue might be that it's unable to open new filehandles. Curls always fail and it can't even write to debug or profiling logs. [22:44:55] have you, uh, tried turning it off and on? [22:45:00] This might be an hhvm issue, but I get profiling logs fine from other pages. [22:45:11] sudo turningitonandoffagain [22:45:14] yup [22:45:24] * YuviPanda is actually pretty useless since most of MWV has changed a bit since he last worked on it [22:45:57] neilk_, anywhere, or only certain directories? [22:46:36] superm401: well a curl is a filehandle to the network [22:47:05] neilk_, I meant for files. [22:47:14] neilk_, are you using PHP's curl library, or curl directly? [22:47:21] (03Abandoned) 10Werdna: Add hook to AJAX watch success. [core] - 10https://gerrit.wikimedia.org/r/148291 (owner: 10Werdna) [22:47:26] superm401: whatever HTTP:Post is using [22:47:31] s/:/::/ [22:47:46] (03PS1) 10EBernhardson: Update xhprof module [vagrant] - 10https://gerrit.wikimedia.org/r/148874 [22:48:04] neilk_, can you write to regular files, e.g. in /home? [22:48:13] superm401: define "you [22:48:14] " [22:48:39] neilk_, well, first try on the command line. If that works, you can try a PHP script. [22:48:57] superm401: if you mean me as a user yes, and mediawiki itself it seems yes because it is writing to logs some of the time. [22:49:32] the main symptom is that anything involving a web request times out [22:50:00] (03CR) 10Bartosz Dziewoński: [C: 032] Use new OutputPageScriptsForBottomQueue hook [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/141284 (https://bugzilla.wikimedia.org/62602) (owner: 10Legoktm) [22:50:03] and the other symptom is that, for some things like load.php, I can't even get it to write debugging info, although i can for api.php. I don't understand what the difference could be. [22:50:10] neilk_, I'm asking you to test. There are some mountpoints, (/vagrant, /vagrant/logs), so if you think there's a problem with regular file writes I need to know if it's different behavior outside those mountpoints. [22:50:21] (03Merged) 10jenkins-bot: Use new OutputPageScriptsForBottomQueue hook [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/141284 (https://bugzilla.wikimedia.org/62602) (owner: 10Legoktm) [22:50:38] neilk_, as for network requests, I haven't hit that issue, but I think the only net requests my instance has made are to InstantCommons, IIRC. [22:50:42] superm401: it writes fine to /var and within /vagrant and /vagrant/logs [22:50:49] superm401: at least... some of the time [22:51:07] superm401: my suggestion that it's about filehandles is just a guess. [22:51:09] neilk_, hmm, not sure then. [22:51:58] (03PS1) 10MaxSem: MobileFrontend: pick https://gerrit.wikimedia.org/r/#/c/148560/ [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148877 [22:52:05] superm401: yes, I had the problem with instantCommons. Any upload would fail because it would try to determine if the same file existed on commons, and then it would time out. Note that I can curl the API url from the command line on vagrant no problem, so it's not like the network isn't there. [22:52:31] it's specifically Curl::Httprequest timing out [22:52:46] (03PS1) 10Jdlrobson: QA: Ensure that a post exists that is not hidden [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148878 [22:52:52] sorry: CurlHttpRequest::execute [22:53:04] neilk_, you could try testing with zend, to see if it's a hhvm issue. [22:53:09] vagrant enable-role zend [22:53:37] superm401: do I need to shut things down first? [22:54:08] neilk_, no, just provision after [22:54:08] (03PS1) 10MaxSem: MobileFrontend: pick https://gerrit.wikimedia.org/r/#/c/148560/ [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/148879 [22:54:17] (03CR) 10Werdna: [C: 032] QA: Ensure that a post exists that is not hidden [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148878 (owner: 10Jdlrobson) [22:54:38] superm401: thanks. Sorry I'm in a frustrated mood right now [22:56:18] (03Merged) 10jenkins-bot: QA: Ensure that a post exists that is not hidden [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148878 (owner: 10Jdlrobson) [22:57:22] 3Wikimedia / 3Deployment systems: Rename mediawiki/core/vendor to mediawiki/vendor - 10https://bugzilla.wikimedia.org/68485 (10Bryan Davis) 3NEW p:3Unprio s:3normal a:3None This will make checking out the gerrit hierarchy easier. [22:58:22] 3MediaWiki extensions / 3GlobalCssJs: Global JS module version not updating properly - 10https://bugzilla.wikimedia.org/62602#c24 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX Fixed now, thanks to everyone who helped with this! Can be tested on beta labs (in a few minutes probably) or http://legoktm.wmflabs.... [22:58:24] 3Wikimedia / 3Deployment systems: Rename mediawiki/core/vendor to mediawiki/vendor - 10https://bugzilla.wikimedia.org/68485 (10Bryan Davis) p:5Unprio>3Normal a:3Bryan Davis [22:59:35] 3Wikimedia / 3Deployment systems: Rename mediawiki/core/vendor to mediawiki/vendor - 10https://bugzilla.wikimedia.org/68485#c1 (10Bryan Davis) Make sure to fix Beta update scripts and make-branch to match rename. [23:01:37] 3MediaWiki extensions / 3CirrusSearch: "oclo crazia" doesn't match "oclocrazia" - 10https://bugzilla.wikimedia.org/68487 (10Nemo) 3NEW p:3Unprio s:3normal a:3None 1) [[it:Special:Search/oclo crazia]] I. Observed: no results, "Forse cercavi: ochoa croazia" II. Expected: oclocrazia. 2) Lucene: https:/... [23:01:43] (03CR) 10MaxSem: [C: 032 V: 032] MobileFrontend: pick https://gerrit.wikimedia.org/r/#/c/148560/ [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148877 (owner: 10MaxSem) [23:01:59] (03CR) 10MaxSem: [C: 032 V: 032] MobileFrontend: pick https://gerrit.wikimedia.org/r/#/c/148560/ [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/148879 (owner: 10MaxSem) [23:02:40] (03CR) 10MaxSem: [C: 032 V: 032] Update MediaViewer submodule [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148733 (owner: 10Gergő Tisza) [23:03:55] (03PS1) 10Kaldari: Making use of Special:MyLanguage for Terms of Use and Privacy links [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148881 [23:05:39] (03PS1) 10Legoktm: Increment minor version number [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/148882 [23:06:21] (03CR) 10Bartosz Dziewoński: [C: 032] Increment minor version number [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/148882 (owner: 10Legoktm) [23:07:14] (03PS2) 10Kaldari: Making use of Special:MyLanguage for Terms of Use and Privacy links [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148881 [23:10:05] (03Merged) 10jenkins-bot: Increment minor version number [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/148882 (owner: 10Legoktm) [23:10:53] (03PS1) 10Alex Monk: Wrap redirectpagesub in a
[core] - 10https://gerrit.wikimedia.org/r/148883 [23:12:29] superm401: yes, going to zend fixed it [23:12:34] superm401: thank you! [23:13:00] neilk_, cool, please file that as a bug, though. HHVM is good at fixing bugs promptly, but we need to ID them. [23:13:14] neilk_, you can file at Wikimedia's bugtracker, and people will take care of upstreaming it. [23:13:21] (03PS2) 10Alex Monk: Wrap redirectpagesub in a [core] - 10https://gerrit.wikimedia.org/r/148883 [23:13:28] superm401: sure thing [23:13:31] neilk_, there is a hiphop keyword I believe. [23:16:53] (03PS1) 10tosfos: i18n/en fixes [extensions/SimpleChanges] - 10https://gerrit.wikimedia.org/r/148884 [23:16:55] (03PS1) 10Jdlrobson: Move heading into prebodyhtml template variable [core] - 10https://gerrit.wikimedia.org/r/148885 [23:19:08] 3MediaWiki / 3ResourceLoader: ResourceLoaderWikiModule::isKnownEmpty does not check whether the page is empty - 10https://bugzilla.wikimedia.org/68488 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None I noticed that even if I blank my common.js, a