[00:03:20] (03PS1) 10Withoutaname: Remove functions deprecated since 1.19 from EditPage.php [core] - 10https://gerrit.wikimedia.org/r/148276 [00:04:16] marktraceur, you may not be the correct person to ask about this; but are you aware of any breaking changes to the commons metadata extension [00:04:37] (03PS1) 10MSyed: Fix image size issues [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148277 [00:04:38] mwalker: try bawolff ;) [00:05:04] * bawolff has not touched that extension in probably about 9 months [00:06:08] (03CR) 10MSyed: [C: 032 V: 032] Add icons on the homepage [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148275 (owner: 10Prtksxna) [00:06:18] (03CR) 10Prtksxna: [C: 032 V: 032] Fix image size issues [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148277 (owner: 10MSyed) [00:06:58] TimStarling: Hey Tim, just wondering if you saw my ping from earlier. [00:07:04] (03PS1) 10Prtksxna: Add viewBox attribute to flags' SVG [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148279 [00:08:13] kaldari: no [00:08:33] I only get 100 or so lines of backscroll unless I ask for them [00:08:34] bawolff, tgr; would either of you know why the following query isn't giving me the image metadata? http://en.wikipedia.org/w/api.php?action=query&prop=imageinfo&titles=File:Hilda_Rix_Nicholas_painting_%22Men_in_the_Market_Place%22.jpg&iiprop=url|size|mediatype|mime|sha1|extmetadata I cant prove it; but I'm pretty sure it was last week [00:09:07] Which specific metadata are you missing? [00:09:17] license, author, and source [00:09:24] TimStarling: Just wondering if you were interested in wading in on https://gerrit.wikimedia.org/r/#/c/140765/. tl;dl version: Tyler is unilaterally blocking unless you say otherwise. [00:09:26] so all the metadata given by commonsmetadata [00:09:37] er tl;dr :) [00:10:38] (03PS1) 10MaxSem: Configuration rewrite, part 1 [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148280 [00:10:46] kaldari: jenkins doesn't seem too impressed either ;) [00:10:49] ori, ^^ [00:11:26] Reedy: well, that's a pretty minor issue in comparison :) [00:11:30] fun [00:11:39] mwalker: I don't think the nonfree template provides those [00:11:51] in a machine-readable way I mean [00:13:04] ok; that makes some amount of sense -- I should {{justfixit}} then [00:13:04] would be easy to fix, though, just add a bunch of licensetpl_something ids [00:13:36] (03CR) 10MSyed: [C: 032 V: 032] Add viewBox attribute to flags' SVG [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148279 (owner: 10Prtksxna) [00:13:53] (03PS1) 10Legoktm: LocalRenameUserJob: Set 'failed' status for any exception thrown [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/148281 [00:14:30] (03PS1) 10Withoutaname: Remove functions deprecated since 1.21 from EditPage.php [core] - 10https://gerrit.wikimedia.org/r/148282 [00:14:52] (03PS1) 10Prtksxna: Align icons on homepage to the center [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148283 [00:17:20] "We might as well have "Special:MyLanguage/This" redirect to hash_hmac( "sha1", "This", "de" ), because in the end, if a namespace does not have sub-pages, every page is equally unrelated to other pages." [00:17:30] the mind boggles [00:17:31] (03PS1) 10Prtksxna: Add a blackout class for the lead text [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148284 [00:19:14] how did the subpage system come about anyway [00:19:46] well, slashes were often used in the usemod days in a subpage-like way [00:20:20] (03CR) 10Alex Monk: [C: 032] Fixing Terms of Use URLs [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148255 (owner: 10Kaldari) [00:20:27] but currently the only difference between a subpage and a regular page is a backlink right? [00:20:43] and link syntax [[/subpage]] [00:20:43] (03Merged) 10jenkins-bot: Fixing Terms of Use URLs [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148255 (owner: 10Kaldari) [00:21:27] that was the original phase3 feature, just those two things [00:21:29] those two ought to be easy to fix [00:21:44] it's mentioned on that gerrit change that there are a few other features now [00:21:53] 3Wikimedia / 3General/Unknown: Add basic monitoring for GlobalRename - 10https://bugzilla.wikimedia.org/68357 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Basically we should be able to notice if a global rename takes longer than say 10 minutes (maybe an hour for a large edit count) wit... [00:22:07] 3Wikimedia / 3General/Unknown: Add basic monitoring for GlobalRename - 10https://bugzilla.wikimedia.org/68357 (10Kunal Mehta (Legoktm)) p:5Unprio>3High [00:22:25] (03PS1) 10Prtksxna: Add retina.js [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148286 [00:25:41] (03CR) 10MSyed: [C: 032 V: 032] Align icons on homepage to the center [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148283 (owner: 10Prtksxna) [00:25:51] 3MediaWiki / 3Special pages: Move "Special:MyLanguage" from Extension:Translate to MediaWiki core - 10https://bugzilla.wikimedia.org/66762#c5 (10Ryan Kaldari) Since it isn't mentioned anywhere else... The immediate impetus for this bug is so that we can set the 'Mobile-frontend-terms-url' message to '//m.wik... [00:25:51] 3Wikimedia / 3Site requests: Turn on Extension:Translate on foundationwiki (for use with board resolutions and project overviews) - 10https://bugzilla.wikimedia.org/44871 (10Ryan Kaldari) [00:26:44] (03CR) 10MSyed: [C: 032 V: 032] Add a blackout class for the lead text [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148284 (owner: 10Prtksxna) [00:26:59] (03CR) 10MSyed: [C: 032 V: 032] Add retina.js [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148286 (owner: 10Prtksxna) [00:28:27] (03CR) 10Parent5446: [C: 04-1] "Release notes" [core] - 10https://gerrit.wikimedia.org/r/148229 (https://bugzilla.wikimedia.org/68298) (owner: 10leucosticte) [00:28:50] 3Wikimedia / 3Site requests: Turn on Extension:Translate on foundationwiki (for use with board resolutions and project overviews) - 10https://bugzilla.wikimedia.org/44871#c32 (10Kunal Mehta (Legoktm)) (In reply to Nemo from comment #31) > If I remember correctly, Kaldari said they intend to use a specific fe... [00:29:16] (03CR) 10Jdlrobson: [C: 04-1] "Looks like this may not be needed..." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148258 (owner: 10Jdlrobson) [00:30:21] 3MediaWiki / 3General/Unknown: Create new user group on Portuguese Wikipedia of good faith new users - 10https://bugzilla.wikimedia.org/68338 (10Helder) [00:35:12] (03PS15) 10SPQRobin: Improve page language functions [core] - 10https://gerrit.wikimedia.org/r/137033 [00:35:52] (03CR) 10Krinkle: Replace deprecated global function wfGetIP() with WebRequest::getIP() (031 comment) [extensions/UserFunctions] - 10https://gerrit.wikimedia.org/r/147678 (owner: 10Withoutaname) [00:36:58] (03CR) 10Krinkle: Replace deprecated global function wfGetIP() with WebRequest::getIP() (031 comment) [extensions/UserFunctions] - 10https://gerrit.wikimedia.org/r/147678 (owner: 10Withoutaname) [00:38:18] (03PS1) 10Werdna: Add hook to AJAX watch success. [core] - 10https://gerrit.wikimedia.org/r/148291 [00:38:52] (03PS16) 10SPQRobin: Improve page language functions [core] - 10https://gerrit.wikimedia.org/r/137033 [00:39:13] (03CR) 10Parent5446: [C: 032] Make if checks in RequestContext.php more concise [core] - 10https://gerrit.wikimedia.org/r/145423 (owner: 10Withoutaname) [00:40:32] (03PS1) 10MSyed: Content changes [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148292 [00:42:26] (03CR) 10Hashar: [C: 031] "I am not a huge fan of disabling ssh hist key check. At the same time I can find a harmful scenario for disabling it." [tools/scap] - 10https://gerrit.wikimedia.org/r/148112 (owner: 10BryanDavis) [00:42:31] (03CR) 10jenkins-bot: [V: 04-1] Add hook to AJAX watch success. [core] - 10https://gerrit.wikimedia.org/r/148291 (owner: 10Werdna) [00:43:26] (03PS5) 10Werdna: New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 [00:43:29] (03PS1) 10Werdna: Add tooltip for watching boards. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148294 [00:43:30] Krinkle: wait how would that help? User::getRequest() just returns $wgRequest [00:43:41] Potentially, yes. [00:43:53] But that's in mediawiki core [00:44:05] (03CR) 10jenkins-bot: [V: 04-1] New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [00:44:17] (03CR) 10jenkins-bot: [V: 04-1] Add tooltip for watching boards. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148294 (owner: 10Werdna) [00:44:30] (03Merged) 10jenkins-bot: Make if checks in RequestContext.php more concise [core] - 10https://gerrit.wikimedia.org/r/145423 (owner: 10Withoutaname) [00:44:32] assuming the UserFucntions extension will eventually use context for User object, the rest would work automatically I guess [00:44:50] RequestContext getUser; $this->user = User::newFromSession( $this->getRequest() ); [00:44:51] I see [00:44:56] Krinkle: could you look at my change 148291 when you get a chance? I realise there is apparently a jshint error or something, but I'd like some validation on the general approach [00:44:57] gotta run [00:45:41] (03CR) 10SPQRobin: "Patch set 15: new approach using a PageLanguage class" [core] - 10https://gerrit.wikimedia.org/r/137033 (owner: 10SPQRobin) [00:45:53] (03PS1) 10Brian Wolff: Reduce batch size of populateBacklinkNamespace from 200 to 20 [core] - 10https://gerrit.wikimedia.org/r/148296 (https://bugzilla.wikimedia.org/68349) [00:47:08] (03PS2) 10Withoutaname: Replace deprecated global function wfGetIP() with WebRequest::getIP() [extensions/UserFunctions] - 10https://gerrit.wikimedia.org/r/147678 [00:49:02] (03PS1) 10Prtksxna: Add content to privacy [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148297 [00:50:49] (03PS2) 10MaxSem: Configuration rewrite, part 1 [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148280 [00:51:18] (03PS1) 10Withoutaname: Remove two unused constants from EditPage.php [core] - 10https://gerrit.wikimedia.org/r/148298 [00:53:17] (03CR) 10MSyed: [C: 032 V: 032] Add content to privacy [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148297 (owner: 10Prtksxna) [00:53:34] (03CR) 10Legoktm: [C: 032] Make jshint happy. [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/148216 (https://bugzilla.wikimedia.org/68335) (owner: 10Jack Phoenix) [00:53:36] (03Merged) 10jenkins-bot: Make jshint happy. [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/148216 (https://bugzilla.wikimedia.org/68335) (owner: 10Jack Phoenix) [00:53:49] (03PS2) 10Prtksxna: Content changes [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148292 (owner: 10MSyed) [00:56:55] (03CR) 10Krinkle: [C: 04-1] "See inline comment." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/148291 (owner: 10Werdna) [00:57:23] (03CR) 10Krinkle: "The npm failure, as indicated on the linked Jenkins job page, is due to a coding style violation (missing space)." [core] - 10https://gerrit.wikimedia.org/r/148291 (owner: 10Werdna) [00:57:29] werdna: ^ ^ [00:58:39] (03CR) 10Prtksxna: [C: 032 V: 032] Content changes [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148292 (owner: 10MSyed) [01:00:07] (03CR) 10Krinkle: "If you ended up here because it (mw.page.watch) hijacked the Flow link, that's a problem we can solve. I see that this module currently bi" [core] - 10https://gerrit.wikimedia.org/r/148291 (owner: 10Werdna) [01:00:36] (03PS1) 10Legoktm: More jshint fixes, also add .jshintrc [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/148299 (https://bugzilla.wikimedia.org/68335) [01:01:17] (03CR) 10Legoktm: "Haven't tested." [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/148299 (https://bugzilla.wikimedia.org/68335) (owner: 10Legoktm) [01:04:52] (03PS10) 10Mwalker: Create attribution page [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/145187 [01:09:17] (03CR) 10Spage: [C: 032] "`make qunit` passes for me without this, but it's a genuine dependency, so OK!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148220 (https://bugzilla.wikimedia.org/68188) (owner: 10Jdlrobson) [01:09:50] (03Merged) 10jenkins-bot: Get QUnit tests passing in Jenkins [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148220 (https://bugzilla.wikimedia.org/68188) (owner: 10Jdlrobson) [01:11:21] (03PS1) 10leucosticte: Let anons see what was patrolled Bug: 60958 [core] - 10https://gerrit.wikimedia.org/r/148300 (https://bugzilla.wikimedia.org/60958) [01:11:35] 3MediaWiki / 3History/Diffs: HTML page title should say we are looking at a diff - 10https://bugzilla.wikimedia.org/33928#c9 (10Helder) This fix was improved on change I4803be2265b1209929ae5ba6d08c2371b0f7d759 but that improvement was reverted on change Iad2c25fbbb673ad95781b29630193bc9de97b1be. [01:13:23] (03PS1) 10Prtksxna: Add FAQ page [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148301 [01:13:37] 3MediaWiki / 3Patrolling: Let anons see what was patrolled - 10https://bugzilla.wikimedia.org/60958 (10Nathan Larson) a:3Nathan Larson [01:13:45] (03CR) 10MSyed: [C: 032 V: 032] Add FAQ page [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148301 (owner: 10Prtksxna) [01:15:06] 3MediaWiki / 3Patrolling: Let anons see what was patrolled - 10https://bugzilla.wikimedia.org/60958 (10Nathan Larson) [01:15:36] (03PS3) 10Physikerwelt: Add new MathHook [extensions/Math] - 10https://gerrit.wikimedia.org/r/147867 [01:15:39] (03PS1) 10Bartosz Dziewoński: Remove styles for .os-suggest and related classes [core] - 10https://gerrit.wikimedia.org/r/148302 [01:15:41] (03PS1) 10Bartosz Dziewoński: Remove backwards-compatibility module alias 'mediawiki.action.watch.ajax' [core] - 10https://gerrit.wikimedia.org/r/148303 [01:16:37] (03PS1) 10Bartosz Dziewoński: Vector: Make better use of $wgResourceModuleSkinStyles [core] - 10https://gerrit.wikimedia.org/r/148304 [01:16:39] (03PS1) 10Bartosz Dziewoński: Resources.php: Remove 'skinStyles' references to 'minerva' skin [core] - 10https://gerrit.wikimedia.org/r/148305 [01:17:51] (03CR) 10Physikerwelt: "@Frédéric, did you have a chance to test the important issue?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/145453 (owner: 10Physikerwelt) [01:19:29] (03CR) 10leucosticte: "It was brought up at wikitech-l, but people seemed pretty neutral/apathetic about it, aside from maxsem's statement, which as Matthew Flas" [core] - 10https://gerrit.wikimedia.org/r/109056 (https://bugzilla.wikimedia.org/60168) (owner: 10leucosticte) [01:21:01] (03CR) 10jenkins-bot: [V: 04-1] Vector: Make better use of $wgResourceModuleSkinStyles [core] - 10https://gerrit.wikimedia.org/r/148304 (owner: 10Bartosz Dziewoński) [01:22:28] (03CR) 10jenkins-bot: [V: 04-1] Resources.php: Remove 'skinStyles' references to 'minerva' skin [core] - 10https://gerrit.wikimedia.org/r/148305 (owner: 10Bartosz Dziewoński) [01:22:53] (03CR) 10Krinkle: [C: 04-1] "They should not apply too widely either (e.g. links inside the wikipage) because that is counter-intuitive to the user, and intrusive whic" [core] - 10https://gerrit.wikimedia.org/r/148139 (owner: 10Bartosz Dziewoński) [01:23:02] (03CR) 10Bartosz Dziewoński: "I submitted some more changes based on this, which hopefully help showcase the usefulness: https://gerrit.wikimedia.org/r/148304 https://g" [core] - 10https://gerrit.wikimedia.org/r/141259 (owner: 10Bartosz Dziewoński) [01:23:38] (03CR) 10Physikerwelt: "I think we should go for this solution now. Think about which fields we really need. I mean the native size information is stored in the S" [extensions/Math] - 10https://gerrit.wikimedia.org/r/144939 (https://bugzilla.wikimedia.org/20202) (owner: 10Physikerwelt) [01:23:48] (03PS2) 10Bartosz Dziewoński: Vector: Make better use of $wgResourceModuleSkinStyles [core] - 10https://gerrit.wikimedia.org/r/148304 [01:24:34] (03CR) 10Hashar: [C: 032] "Congratulations!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148244 (https://bugzilla.wikimedia.org/67734) (owner: 10Jdlrobson) [01:25:27] (03Merged) 10jenkins-bot: Make Flow QUnit tests voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148244 (https://bugzilla.wikimedia.org/67734) (owner: 10Jdlrobson) [01:26:20] (03CR) 10Bartosz Dziewoński: "I don't think this restriction makes sense. There is no reason for anyone to use any of these ids in page content (no possibility of unint" [core] - 10https://gerrit.wikimedia.org/r/148139 (owner: 10Bartosz Dziewoński) [01:26:23] (03CR) 10jenkins-bot: [V: 04-1] Vector: Make better use of $wgResourceModuleSkinStyles [core] - 10https://gerrit.wikimedia.org/r/148304 (owner: 10Bartosz Dziewoński) [01:28:09] (03CR) 10Helder.wiki: "Fortunately this reversion was "reverted" locally on English Wikipedia, which now uses "$1: Revision history":" [core] - 10https://gerrit.wikimedia.org/r/9009 (owner: 10Krinkle) [01:28:45] (03PS1) 10Prtksxna: Hover state for bar graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148306 [01:31:57] (03CR) 10Bartosz Dziewoński: [C: 031] More jshint fixes, also add .jshintrc [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/148299 (https://bugzilla.wikimedia.org/68335) (owner: 10Legoktm) [01:37:20] 3MediaWiki skins / 3Vector: [Regression] CSS selector for vector menu label is not generic enough - 10https://bugzilla.wikimedia.org/43406#c6 (10Bartosz Dziewoński) 5PATC>3RESO/FIX All fixed! [01:38:07] 3MediaWiki skins / 3Vector: [Regression] CSS selector for vector menu label is not generic enough - 10https://bugzilla.wikimedia.org/43406#c7 (10Bartosz Dziewoński) (Note that you'll need to wait for HTML cache to expire before you stop seeing the old structure in pages, up to 30 days after the change is dep... [01:38:25] (03PS11) 10Bartosz Dziewoński: [DO NOT MERGE] Vector: Remove compatibility for old variant menu HTML [core] - 10https://gerrit.wikimedia.org/r/138369 [01:38:46] (03PS1) 10MaxSem: Remove WebVideoJobRunner.php [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/148307 [01:38:58] (03PS12) 10Bartosz Dziewoński: Vector: Remove compatibility for old variant menu HTML [core] - 10https://gerrit.wikimedia.org/r/138369 [01:39:18] (03CR) 10Bartosz Dziewoński: "Dependency merged, this can be merged in around 30 days from now." [core] - 10https://gerrit.wikimedia.org/r/138369 (owner: 10Bartosz Dziewoński) [01:39:29] (03CR) 10Tim Starling: [C: 04-1] "I think it is fine to give a special meaning to "/" in article titles that are not in $wgNamespacesWithSubpages, if that is explicitly req" [core] - 10https://gerrit.wikimedia.org/r/140765 (https://bugzilla.wikimedia.org/66762) (owner: 10MaxSem) [01:40:27] (03PS11) 10Mwalker: Create attribution page [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/145187 [01:40:59] done [01:41:21] only took 1.5 hours [01:41:28] :P [01:41:35] 3MediaWiki / 3Skin and page rendering: Ability of to change HTML of 'Search result page' by skin - 10https://bugzilla.wikimedia.org/67090#c4 (10Bartosz Dziewoński) 5NEW>3RESO/WON Yeah, changing page HTML is not really possible, nor feasible to implement. Sorry :( [01:42:04] 3MediaWiki extensions / 3WikidataRepo: Wikidata: CTRL+click and middle click on search suggestions doesn't open the page in a new tab - 10https://bugzilla.wikimedia.org/57709#c10 (10Helder) It works fine on core[1] and just fails on Wikidata. But yes, the behavior should be consistent. [1] I just tested it... [01:44:04] 3MediaWiki / 3Skin and page rendering: Ability of to change HTML of 'Search result page' by skin - 10https://bugzilla.wikimedia.org/67090#c5 (10Max Semenik) Well, it is possible, that's what MobileFrontend does. It still gives me the creeps though, so pretty please don't :P [01:45:43] (03CR) 10Isarra: "Sorry. >.<" [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/145871 (owner: 10Bartosz Dziewoński) [01:57:37] (03CR) 10Tim Starling: "For the record, the file existence check in Title::isAlwaysKnown() could be batched using RepoGroup::findFiles(). At present, this will un" [core] - 10https://gerrit.wikimedia.org/r/140765 (https://bugzilla.wikimedia.org/66762) (owner: 10MaxSem) [01:58:58] (03CR) 10Parent5446: Integrate Special:MyLanguage from the Translate extension [core] - 10https://gerrit.wikimedia.org/r/140765 (https://bugzilla.wikimedia.org/66762) (owner: 10MaxSem) [01:59:14] (03PS1) 10Legoktm: Pass uselang parameter to action=parse [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/148308 [02:04:59] (03PS1) 10TTO: Use master DB to check for page existence during import [core] - 10https://gerrit.wikimedia.org/r/148309 (https://bugzilla.wikimedia.org/40009) [02:18:50] 3MediaWiki / 3Categories: IcuCollation's 'first-letters' cache key should include the version of ICU and possibly PHP that was used to build the data - 10https://bugzilla.wikimedia.org/68344#c3 (10Kunal Mehta (Legoktm)) (In reply to Bawolff (Brian Wolff) from comment #2) > I'm not sure how hiphop implements... [02:20:42] (03PS6) 10Jdlrobson: New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [02:20:47] (03PS2) 10Jdlrobson: Add tooltip for watching boards. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148294 (owner: 10Werdna) [02:21:17] (03CR) 10jenkins-bot: [V: 04-1] New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [02:21:24] (03CR) 10jenkins-bot: [V: 04-1] Add tooltip for watching boards. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148294 (owner: 10Werdna) [02:21:43] (03PS4) 10Jdlrobson: QA: Add step to wait for JavaScript to load on new topic form [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147692 (owner: 10Werdna) [02:28:22] TimStarling, thank you for dealing with that. [02:29:07] np [02:31:24] 3Wikimedia / 3Site requests: Allow "Related sites" site names to be localised on Wikivoyage editions - 10https://bugzilla.wikimedia.org/68359 (10This, that and the other) 3NEW p:3Unprio s:3normal a:3None Currently, the site names for the "Related sites" sidebar entries are hard-coded in InitialiseSet... [02:31:36] 3Wikimedia / 3Site requests: $wgExtraLanguageNames is used for sites instead of languages in WikiVoyage - 10https://bugzilla.wikimedia.org/41209 (10This, that and the other) [02:48:28] is there a limit on how large of an object (array technically) you can store in memcache? [02:48:52] 3MediaWiki extensions / 3CodeEditor: Match a newline in the code is not possible - 10https://bugzilla.wikimedia.org/68360 (10automatik68) 3UNCO p:3Unprio s:3normal a:3None When I use CTRL+F then I search '\n' with "RegExp Search" activated, no newline is matched in the code. [02:50:06] (03PS1) 10EBernhardson: Highlight unread message from notifications link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148310 [03:06:03] (03CR) 10Deskana: [C: 031] "I share Siebrand's wariness, but this seems like a pretty sensible alias to have." [core] - 10https://gerrit.wikimedia.org/r/146798 (owner: 10Jackmcbarn) [03:10:05] 3MediaWiki extensions / 3Cite: Use of a list-defined reference in a template produces "unused reference" error - 10https://bugzilla.wikimedia.org/50880#c2 (10Gadget850) 5NEW>3RESO/INV The error message is correct. The reference is defined in the list, but never invoked because it is included in an invali... [03:23:07] (03PS1) 10TTO: Allow localisation of site link text [extensions/RelatedSites] - 10https://gerrit.wikimedia.org/r/148312 (https://bugzilla.wikimedia.org/68359) [03:23:25] (03PS1) 10TTO: Add strings for localisation of Wikivoyage RelatedSites links [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148313 (https://bugzilla.wikimedia.org/68359) [03:26:49] (03CR) 10PleaseStand: [C: 04-1] Fix race condition in wfShellExec() (033 comments) [core] - 10https://gerrit.wikimedia.org/r/147635 (https://bugzilla.wikimedia.org/67870) (owner: 10MaxSem) [03:30:46] (03PS2) 10TTO: Add strings for localisation of Wikivoyage RelatedSites links [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148313 (https://bugzilla.wikimedia.org/68359) [03:31:59] (03CR) 10PleaseStand: Fix race condition in wfShellExec() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/147635 (https://bugzilla.wikimedia.org/67870) (owner: 10MaxSem) [03:36:51] 3MediaWiki extensions / 3UniversalLanguageSelector: In addition to "…", "X more languages"/ext-uls-compact-link-count/#more-lang-label should also open the language selector - 10https://bugzilla.wikimedia.org/68076#c1 (10Niharika) I can work on this. Not able to assign it to myself. Ping Nemo. There is a... [03:46:53] (03PS1) 10BryanDavis: labs_vagrant: Use hiera.yaml [vagrant] - 10https://gerrit.wikimedia.org/r/148315 [04:10:20] 3Wikimedia / 3SSL related: Enable HSTS on Wikimedia wikis - 10https://bugzilla.wikimedia.org/38516#c35 (10chmarkine) Bugzilla: https://gerrit.wikimedia.org/r/#/c/148285/ OTRS: https://gerrit.wikimedia.org/r/#/c/148289/ Wikitech: https://gerrit.wikimedia.org/r/#/c/148290/ [04:13:04] 3MediaWiki extensions / 3UniversalLanguageSelector: [Interlanguage links] When common languages are not enough, "fillers" should come after - 10https://bugzilla.wikimedia.org/63271#c3 (10Niharika) Have we decided what course to take on this? [04:16:17] where does hhvm in vagrant put its error log? I'm getting blank pages... [04:17:37] 3MediaWiki / 3General/Unknown: Section edit containing "/*" is mis-parsed - 10https://bugzilla.wikimedia.org/68361 (10MZMcBride) 3NEW p:3Unprio s:3normal a:3None From : --- (/* PleaseStand for... [04:21:34] hmm, found it [04:21:40] (the error, not the log) [04:37:23] (03PS5) 10Ori.livneh: Fix race condition in wfShellExec() [core] - 10https://gerrit.wikimedia.org/r/147635 (https://bugzilla.wikimedia.org/67870) (owner: 10MaxSem) [04:38:49] 3Wikimedia / 3Extension setup: Install "HTML-Tags" on de.wikiversity - 10https://bugzilla.wikimedia.org/47566#c9 (10MZMcBride) For the span attributes, is there a reason we can't modify MediaWiki core to allow itemprop, itemscope, and itemtype HTML attributes? Currently "Blend-O-Matic<... [04:40:01] Hmm. [04:40:03] !defaultsettings [04:40:03] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=includes/DefaultSettings.php;hb=HEAD [04:41:19] * Carmela keeps digging. [04:42:17] (03PS2) 10Legoktm: Default $wgMainCacheType to CACHE_ANYTHING [core] - 10https://gerrit.wikimedia.org/r/117091 (owner: 10MaxSem) [04:42:33] (03CR) 10Frédéric Wang: "No, will probably only be able to do that on Friday." [extensions/Math] - 10https://gerrit.wikimedia.org/r/145453 (owner: 10Physikerwelt) [04:43:25] (03CR) 10Legoktm: [C: 031] "Moved release notes to 1.24 file." [core] - 10https://gerrit.wikimedia.org/r/117091 (owner: 10MaxSem) [04:45:35] 3Wikimedia / 3Extension setup: Install "HTML-Tags" on de.wikiversity - 10https://bugzilla.wikimedia.org/47566#c10 (10MZMcBride) (In reply to MZMcBride from comment #9) > For the span attributes, is there a reason we can't modify MediaWiki core to > allow itemprop, itemscope, and itemtype HTML attributes? Ri... [04:51:04] (03PS6) 10Ori.livneh: Fix race condition in wfShellExec() [core] - 10https://gerrit.wikimedia.org/r/147635 (https://bugzilla.wikimedia.org/67870) (owner: 10MaxSem) [04:52:05] 3Wikimedia / 3Extension setup: Install "HTML-Tags" on de.wikiversity - 10https://bugzilla.wikimedia.org/47566#c11 (10MZMcBride) http://lists.wikimedia.org/pipermail/wikitech-l/2010-January/046367.html is the referenced mailing list discussion. [04:56:28] (03PS2) 10leucosticte: Give sysops the deleterevision right by default [core] - 10https://gerrit.wikimedia.org/r/148229 (https://bugzilla.wikimedia.org/68298) [05:04:20] 3MediaWiki extensions / 3Scribunto: HHVM crash loading San Francisco page - 10https://bugzilla.wikimedia.org/68196#c8 (10Tim Starling) ...that being $iteratorNode. The TypedValue* for $iteratorNode was consistent enough for me to set a watch on it, which showed it being overwritten with garbage by translator... [05:08:19] "[19:48] legoktm is there a limit on how large of an object (array technically) you can store in memcache?" You're talking about the 1MB limit right? [05:08:51] I didn't know if there was one, but that sounds reasonable. [05:12:48] legoktm: would this change need release notes? https://gerrit.wikimedia.org/r/#/c/146985/ [05:13:28] you're removing a private function, so probably not [05:16:44] (03CR) 10Ori.livneh: "@PleaseStand: thanks for the comments; amended." [core] - 10https://gerrit.wikimedia.org/r/147635 (https://bugzilla.wikimedia.org/67870) (owner: 10MaxSem) [05:17:35] 3Wikimedia / 3Extension setup: Install "HTML-Tags" on de.wikiversity - 10https://bugzilla.wikimedia.org/47566#c12 (10Juergen Fenn) I've just seen in my mail that you are still active on this bug. So, I'd like to point out that HTML tags integration in German Wikiversity (which initially aimed at integrating... [05:32:50] (03PS3) 10Deepali: Allow users to add links to the metadata [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/147725 (https://bugzilla.wikimedia.org/52816) [05:43:21] (03PS1) 10BryanDavis: [WIP] centralauth: Use hiera to allow variable customization [vagrant] - 10https://gerrit.wikimedia.org/r/148317 (https://bugzilla.wikimedia.org/67331) [05:59:30] (03PS1) 10Withoutaname: Remove global function wfUsePHP() [core] - 10https://gerrit.wikimedia.org/r/148320 [05:59:49] 3MediaWiki / 3General/Unknown: Updating Page count doesn't work reliably when a page is moved - 10https://bugzilla.wikimedia.org/64333#c5 (10Andyrom75) Hi This, that and the other, few days ago I've tried to create the destination page with an almost empty contente (just "."), before move the page from the U... [06:08:28] (03CR) 10Florianschmidtwelzow: [C: 032] Fixed fatal undefined SpecialGoogleLogin::getHost [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/148051 (https://bugzilla.wikimedia.org/68316) (owner: 10Florianschmidtwelzow) [06:08:37] (03Merged) 10jenkins-bot: Fixed fatal undefined SpecialGoogleLogin::getHost [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/148051 (https://bugzilla.wikimedia.org/68316) (owner: 10Florianschmidtwelzow) [06:09:19] 3MediaWiki extensions / 3GoogleLogin: Fatal: Call to undefined method SpecialGoogleLogin::getHost after pressing Login with Google button - 10https://bugzilla.wikimedia.org/68316 (10Florian) 5PATC>3RESO/FIX [06:16:21] (03PS2) 10Florianschmidtwelzow: Extended Login-workflow [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/148108 (https://bugzilla.wikimedia.org/68317) [06:22:42] (03PS7) 10MaxSem: Fix race condition in wfShellExec() [core] - 10https://gerrit.wikimedia.org/r/147635 (https://bugzilla.wikimedia.org/67870) [06:23:25] (03CR) 10MaxSem: "Made it test on Windows." [core] - 10https://gerrit.wikimedia.org/r/147635 (https://bugzilla.wikimedia.org/67870) (owner: 10MaxSem) [06:27:16] (03CR) 10Florianschmidtwelzow: [C: 032] Extended Login-workflow [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/148108 (https://bugzilla.wikimedia.org/68317) (owner: 10Florianschmidtwelzow) [06:27:22] (03Merged) 10jenkins-bot: Extended Login-workflow [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/148108 (https://bugzilla.wikimedia.org/68317) (owner: 10Florianschmidtwelzow) [06:29:50] 3MediaWiki extensions / 3GoogleLogin: Login not possible and nor error message it username is deleted/merged by UserMerge extension - 10https://bugzilla.wikimedia.org/68317#c3 (10Florian) 5PATC>3ASSI a:3Florian @Mike: Can you please verify, that this helps in your problem? :) Just load the extension ne... [06:33:42] (03PS1) 10Rohan013: Show Page moves on Special:Newpages [core] - 10https://gerrit.wikimedia.org/r/148322 (https://bugzilla.wikimedia.org/12363) [06:37:38] (03PS2) 10Florianschmidtwelzow: Add Loginreplacement and disable create account [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/147559 [06:41:20] 3MediaWiki extensions / 3UniversalLanguageSelector: In addition to "…", "X more languages"/ext-uls-compact-link-count/#more-lang-label should also open the language selector - 10https://bugzilla.wikimedia.org/68076#c2 (10Nemo) (In reply to Niharika from comment #1) > I can work on this. Not able to assign it... [06:45:08] 3MediaWiki extensions / 3ReplaceText: PHP Notice: Undefined variable: num_matches in /extensions/ReplaceText/ReplaceTextJob.php on line 89 - 10https://bugzilla.wikimedia.org/68363 (10Raimond Spekking) 3NEW p:3Unprio s:3normal a:3None Spotted on translatewiki.net: PHP Notice: Undefined variable: num_... [06:51:07] 3MediaWiki extensions / 3UniversalLanguageSelector: In addition to "…", "X more languages"/ext-uls-compact-link-count/#more-lang-label should also open the language selector - 10https://bugzilla.wikimedia.org/68076 (10Niharika) a:3Niharika [06:56:21] 3MediaWiki extensions / 3UniversalLanguageSelector: [Interlanguage links] When common languages are not enough, "fillers" should come after - 10https://bugzilla.wikimedia.org/63271#c4 (10Nemo) (In reply to Niharika from comment #3) > Have we decided what course to take on this? I think it depends on whether... [07:02:35] (03CR) 10Werdna: "We are using the MediaWiki watchlist for Flow, and I want to hijack the skin's watch link notification." [core] - 10https://gerrit.wikimedia.org/r/148291 (owner: 10Werdna) [07:14:05] 3Wikimedia / 3Extension setup: Install "HTML-Tags" on de.wikiversity - 10https://bugzilla.wikimedia.org/47566#c13 (10Nemo) "Another potential usage of HTML Tags is to embed microdata (especially the kind that can't be embedded already using $wgAllowMicrodataAttributes)." Would be useful to document such kind... [07:18:00] (03CR) 10Robert Vogel: [C: 032 V: 032] Added @embed statement for resourceloader [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148060 (owner: 10Smuggli) [07:19:39] (03CR) 10Robert Vogel: [C: 032 V: 032] "This is sad. But according to Matma Rex this hook is not good at all." [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/148023 (owner: 10Swidmann) [07:29:16] (03PS3) 10Hashar: add jzerebecki to trusted users in zuul [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148238 (owner: 10Dzahn) [07:29:44] (03CR) 10Hashar: [C: 032] "Jan: you will have tests triggered now :-)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148238 (owner: 10Dzahn) [07:29:49] (03Merged) 10jenkins-bot: add jzerebecki to trusted users in zuul [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148238 (owner: 10Dzahn) [07:39:38] Does anyone know someone who knows about/cares about the import stack? I have had great difficulty finding anyone who is game enough to review import-related patches [07:42:20] tto: link? [07:43:14] https://gerrit.wikimedia.org/r/84194 (my oldest patch still open) https://gerrit.wikimedia.org/r/148309 and https://gerrit.wikimedia.org/r/84197 (this is broken and needs more work) [07:46:19] that first one sounds scary. [07:46:35] (03CR) 10Legoktm: [C: 031] Use master DB to check for page existence during import [core] - 10https://gerrit.wikimedia.org/r/148309 (https://bugzilla.wikimedia.org/40009) (owner: 10TTO) [07:47:38] legoktm: admittedly the first one is a feature I more or less just thought of one day, so I understand why people aren't rushing to +1/+2 it, but... how is it scary? [07:47:51] "The intention is to alter the WMF configuration to automatically populate $wgImportSources with all public cluster wikis" [07:48:13] that's a dropdown with 700+ options [07:48:39] This change splits it into two dropdowns, one for site and one for language code, hence making it more manageable [07:48:57] (see also bug 15583, the commit message should probably mention that bug) [07:49:52] Ah, it was bug 15584! Found it [07:50:22] (03PS15) 10TTO: Allow two-tier setup of transwiki import sources [core] - 10https://gerrit.wikimedia.org/r/84194 (https://bugzilla.wikimedia.org/15584) [07:55:15] (03CR) 10Legoktm: Allow two-tier setup of transwiki import sources (032 comments) [core] - 10https://gerrit.wikimedia.org/r/84194 (https://bugzilla.wikimedia.org/15584) (owner: 10TTO) [07:55:54] looks fine other than that. [07:58:30] how would you allow two wikis to communicate with each other [07:59:38] context? [08:00:41] tto: I've always thought it weird that Special:Import used interwiki prefixes instead of database names. [08:00:56] well, I mean when you're setting up import it seems natural you'd have to allow both wikis to agree to the import [08:01:11] and that's only effective if they're on the same farm [08:01:25] so how would you be able to tell if two wikis were on the same farm [08:01:35] From a MediaWiki standpoint it makes sense to use interwiki prefixes; the interwiki table is the only knowledge MW has of external installations [08:01:56] On a farm perhaps db name makes more sense, but it has the same issue of there being too many to find the one you want [08:02:39] well, if you're using non-upload import, you know they're on a farm together [08:02:52] I have an interwiki link to google, I don't think that would count as a legitimate wiki import source [08:03:03] not necessarily! From my local wiki I can import from wikipedia, wikia, and other places [08:03:14] wait really? o.o [08:03:16] (03CR) 10Smuggli: Implemented changes for translatewiki (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/146428 (owner: 10Smuggli) [08:03:28] So long as Special:Export is available on the target wiki, import by interwiki prefix is possibly [08:03:29] *possible [08:03:47] damn. [08:03:54] I was thinking of a handshake system... [08:04:02] Essentially Special:Import just makes an HTTP request for http://en.wikipedia.org/wiki/Special:Export/foo?history=1 [08:04:49] Perhaps that explains why import is so flaky, and it almost certainly explains why import bugs stay open for years... the system is so inflexible [08:06:09] :/ [08:06:30] https://gerrit.wikimedia.org/r/#/c/106861/ :(((((( [08:06:37] that must be a terrible import system [08:06:45] Now you see what I meant the other day when I said someone needs to sit down and rewrite the whole import system! [08:06:45] (03PS3) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/147403 [08:07:19] legoktm: Yeah, don't know why Krinkle abandoned that for me... [08:09:56] (03Restored) 10Legoktm: Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 (https://bugzilla.wikimedia.org/52061) (owner: 10TTO) [08:11:18] so wait, would I really be able to try and import google as a source [08:12:26] withoutaname: I don't think it'll work...? [08:12:30] see what happens? [08:12:39] tto|away: btw, are you going to be in London? [08:12:59] withoutaname: same question :P [08:13:22] (03PS2) 10Smuggli: Implementes changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148055 [08:13:24] for wikimania? probably no [08:13:43] as much as I'd like to [08:13:59] (03CR) 10Legoktm: Merge Poem extension into core (032 comments) [core] - 10https://gerrit.wikimedia.org/r/106861 (https://bugzilla.wikimedia.org/52061) (owner: 10TTO) [08:15:09] legoktm: besides you probably wouldn't recognize me :P [08:17:53] hmm, this rebase is going to be annoying. [08:18:40] (03CR) 10Florianschmidtwelzow: [C: 032] Add Loginreplacement and disable create account [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/147559 (owner: 10Florianschmidtwelzow) [08:18:46] (03Merged) 10jenkins-bot: Add Loginreplacement and disable create account [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/147559 (owner: 10Florianschmidtwelzow) [08:23:45] (03PS18) 10Legoktm: Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 (https://bugzilla.wikimedia.org/52061) (owner: 10TTO) [08:25:27] (03CR) 10Legoktm: [C: 04-1] "PS18 is a manual rebase. I removed the changes to skins/{modern,cologneblue}/* since those files have been moved to different repositories" [core] - 10https://gerrit.wikimedia.org/r/106861 (https://bugzilla.wikimedia.org/52061) (owner: 10TTO) [08:26:51] 3MediaWiki / 3General/Unknown: Merge Poem extension into MediaWiki core - 10https://bugzilla.wikimedia.org/52061#c48 (10Kunal Mehta (Legoktm)) (In reply to Tpt from comment #45) > Yes, you have right with "mw-lines". > > I understand your concern with differing functionality that would require > two buttons... [08:27:25] tto|away: bumped a few things. What do you think of my comments in ps17? [08:28:10] (03CR) 10jenkins-bot: [V: 04-1] Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 (https://bugzilla.wikimedia.org/52061) (owner: 10TTO) [08:30:19] legoktm: well, it said it couldn't find an import file when I tried google [08:30:43] interestingly I tried to import Module:Bananas and it said I didn't have scribunto... [08:30:59] because of the content type I think [08:32:48] legoktm: maybe, but I don't have CONTENT_MODEL_LUA installed [08:33:05] dunno :P [08:33:07] magic! [08:35:05] 3MediaWiki extensions / 3WikidataRepo: {{PLURAL}} is not parsed in error messages - 10https://bugzilla.wikimedia.org/66963#c2 (10Lydia Pintscher) Fixed in master indeed. Should be live soon. [08:35:23] 3MediaWiki extensions / 3WikidataRepo: {{PLURAL}} is not parsed in error messages - 10https://bugzilla.wikimedia.org/66963 (10Lydia Pintscher) 5NEW>3RESO/FIX [08:35:36] 3MediaWiki extensions / 3WikidataRepo: {{PLURAL}} is not parsed in error messages - 10https://bugzilla.wikimedia.org/66963 (10Lydia Pintscher) 5RESO/?>3VERI [08:41:41] legoktm: Thanks for all that, I'll have a closer look later on [08:41:58] As you can see from my e-mail address, I'm from Australia, so London is a long way away! [08:42:24] WM is also right in the middle of the uni semester, and I'm a poor uni student, etc etc [08:42:32] So, in short, no [08:42:35] :( [08:43:36] legoktm: btw, for Action.php remember when you said "replace getTitle() calls in EducationProgram with getPageTitle()" [08:44:02] yes I think [08:44:04] I tried blowing up the original one here: https://gerrit.wikimedia.org/r/#/c/146713/1/includes/actions/Action.php [08:44:30] after that maybe we can use getpagetitle as an alias [08:51:05] 3Wikimedia / 3General/Unknown: Add basic monitoring for GlobalRename - 10https://bugzilla.wikimedia.org/68357#c1 (10Marius Hoch) While I totally agree that we need something like this, I still think that 10 minutes or even an hour aren't enough time... during high load or if a global account has a lot of loc... [09:02:23] (03CR) 10Withoutaname: Add deprecation messages to object methods in Article.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143230 (owner: 10Withoutaname) [09:13:20] (03CR) 10Hoo man: [C: 04-1] LocalRenameUserJob: Set 'failed' status for any exception thrown (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/148281 (owner: 10Legoktm) [09:15:03] (03PS1) 10Awight: (FR #1817) Fix automatic state changes [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/148335 [09:15:15] (03CR) 10Legoktm: LocalRenameUserJob: Set 'failed' status for any exception thrown (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/148281 (owner: 10Legoktm) [09:15:22] (03PS2) 10Legoktm: LocalRenameUserJob: Set 'failed' status for any exception thrown [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/148281 [09:15:53] legoktm: that was fast [09:16:23] :P [09:16:28] (03CR) 10Hoo man: [C: 032] LocalRenameUserJob: Set 'failed' status for any exception thrown [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/148281 (owner: 10Legoktm) [09:16:35] (03Merged) 10jenkins-bot: LocalRenameUserJob: Set 'failed' status for any exception thrown [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/148281 (owner: 10Legoktm) [09:18:35] 3Wikimedia / 3Site requests: Create new user group on Portuguese Wikipedia of good faith new users - 10https://bugzilla.wikimedia.org/68338#c1 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [Moving to "Wikimedia" product as this request is about settings / configuration of the website, not about... [09:20:26] 3Wikimedia / 3Site requests: Create new user group on Portuguese Wikipedia of good faith new users - 10https://bugzilla.wikimedia.org/68338#c2 (10Andre Klapper) Personally I wonder how adding this group solves any problems, instead of creating the same level of problems by discussing how to somehow identify... [09:25:06] 3MediaWiki extensions / 3Cite: Inconsistently numbered references - 10https://bugzilla.wikimedia.org/46140#c2 (10Andre Klapper) I still see this issue on link in comment 0 with Firefox 30.0: "References" section ends with 25, last reference in text above is 33 though. [09:26:35] 3Wikimedia / 3Extension setup: Enable DynamicPageList on sr.wiktionary - 10https://bugzilla.wikimedia.org/68346#c1 (10Andre Klapper) s:5normal>3enhanc See bug 29596 comment 10 [09:26:37] 3Wikimedia / 3Extension setup: Install DynamicPageList on en.wikivoyage - 10https://bugzilla.wikimedia.org/60204#c10 (10Andre Klapper) See bug 29596 comment 10 [09:27:06] (03PS1) 10Legoktm: Rewrite caching logic (again) [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/148336 [09:29:27] (03PS2) 10Legoktm: Rewrite caching logic (again) [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/148336 [09:30:06] (03CR) 10Hoo man: [C: 04-1] "Looks good, but needs manual rebase" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/147043 (owner: 10Thiemo Mättig (WMDE)) [09:31:24] 3MediaWiki / 3Installer: Make it possible to render the installer with any skin, or preview skins in the installer - 10https://bugzilla.wikimedia.org/68331 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [09:31:24] 3MediaWiki / 3General/Unknown: Move all four core skins to separate repositories and include them in the tarball - 10https://bugzilla.wikimedia.org/68333 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [09:31:36] 3MediaWiki / 3Skin and page rendering: Create a tiny fallback skin to use when no proper skins are present - 10https://bugzilla.wikimedia.org/68332 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [09:54:53] 3MediaWiki extensions / 3WikidataRepo: add script for stitching json dump shards - 10https://bugzilla.wikimedia.org/68366 (10Daniel Kinzler) 3NEW p:3Unprio s:3normal a:3Wikidata bugs we should have a (bash?) script for stitching multiple shards of a json dump into a single dump (and probably compress... [09:54:53] (03PS1) 10Legoktm: Load some modules from the parsed output [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/148338 [09:55:07] 3MediaWiki / 3Language converter: Document LanguageConverter - 10https://bugzilla.wikimedia.org/19044#c4 (10Aude) more documentation of the LanguageConverter and variants would be super helpful. :) right now I need to look at the code, ask certain people or make a guess as to why things are done the way the... [09:55:23] (03PS1) 10Robert Vogel: ExtendedSearch: CSS more skin agnostic [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148339 [09:57:05] 3Wikimedia / 3General/Unknown: nds.wiktionary.org Scripterror by moduls timerunout - 10https://bugzilla.wikimedia.org/68304#c11 (10Andre Klapper) (In reply to Joachim Mos from comment #6) > What's in your head Please assume that people mean well. Also see https://www.mediawiki.org/wiki/Bug_management/Bugzil... [10:03:08] 3MediaWiki extensions / 3ReplaceText: PHP Notice: Undefined variable: num_matches in /extensions/ReplaceText/ReplaceTextJob.php on line 89 - 10https://bugzilla.wikimedia.org/68363 (10Nemo) [10:03:08] 3MediaWiki / 3General/Unknown: Bugs affecting translatewiki.net (errors from MediaWiki master) (tracking) - 10https://bugzilla.wikimedia.org/39480 (10Nemo) [10:07:39] (03CR) 10Legoktm: [C: 032 V: 032] Pass uselang parameter to action=parse [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/148308 (owner: 10Legoktm) [10:08:06] 3MediaWiki extensions / 3CodeEditor: Match a newline in the code is not possible - 10https://bugzilla.wikimedia.org/68360 (10Andre Klapper) p:5Unprio>3Low s:5normal>3minor [10:08:36] 3MediaWiki / 3Parser: Section edit containing "/*" is mis-parsed - 10https://bugzilla.wikimedia.org/68361 (10Andre Klapper) p:5Unprio>3Low [10:10:35] (03PS1) 10Pigpen: PHP 5.3 compatibility [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148341 [10:12:51] 3MediaWiki / 3ResourceLoader: External link icon is not flipped in RTL - 10https://bugzilla.wikimedia.org/68326 (10Andre Klapper) [10:13:07] 3MediaWiki / 3Parser: RTL/bidirectional issues (tracking) - 10https://bugzilla.wikimedia.org/745 (10Andre Klapper) [10:13:20] 3MediaWiki / 3ResourceLoader: External link icon is not flipped in RTL - 10https://bugzilla.wikimedia.org/68326 (10Andre Klapper) p:5Unprio>3Low s:5normal>3minor [10:13:31] (03PS1) 10Wctaiwan: Handle titles containing @ in JS [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/148342 [10:17:04] (03PS2) 10Wctaiwan: Handle titles containing @ in JS [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/148342 [10:22:37] (03PS3) 10Wctaiwan: Handle titles containing @ in JS [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/148342 [10:24:22] 3Wikimedia / 3Site requests: 300GB of files on a hard disk in need of a URI or WMF direct upload - 10https://bugzilla.wikimedia.org/67477#c12 (10Fæ) I have received the disk from the Wellcome Trust. It's a pocked sized USB drive. There are just over 50,000 of medical history high resolution image files (I'm... [10:25:26] (03PS4) 10Wctaiwan: Handle titles containing @ in JS [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/148342 [10:26:54] 3Wikimedia / 3Stream: stream.wikimedia.org throws websocket.WebSocketException: Handshake Status 502 Bad Gateway - 10https://bugzilla.wikimedia.org/66989 (10Antoine "hashar" Musso) [10:32:21] (03PS3) 10Thiemo Mättig (WMDE): Add tests for NULL to ActionTest [core] - 10https://gerrit.wikimedia.org/r/147054 [10:32:23] (03PS5) 10Thiemo Mättig (WMDE): Make an empty "?action=" parameter default to "view" [core] - 10https://gerrit.wikimedia.org/r/147058 [10:32:25] (03PS3) 10Thiemo Mättig (WMDE): Add more test cases to ActionTest [core] - 10https://gerrit.wikimedia.org/r/147043 [10:32:27] (03PS3) 10Thiemo Mättig (WMDE): Add tests for IE workarounds to ActionTest [core] - 10https://gerrit.wikimedia.org/r/147056 [10:32:29] (03PS3) 10Thiemo Mättig (WMDE): Add tests for disabled actions in ActionTest [core] - 10https://gerrit.wikimedia.org/r/147045 [10:33:21] (03PS19) 10TTO: Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 (https://bugzilla.wikimedia.org/52061) [10:33:38] (03PS20) 10TTO: Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 (https://bugzilla.wikimedia.org/52061) [10:37:20] (03PS4) 10Thiemo Mättig (WMDE): Add more test cases to ActionTest [core] - 10https://gerrit.wikimedia.org/r/147043 [10:37:56] (03PS5) 10Wctaiwan: Handle titles containing @ in JS [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/148342 [10:40:06] (03CR) 10Hoo man: [C: 032] "Much better :)" [core] - 10https://gerrit.wikimedia.org/r/147043 (owner: 10Thiemo Mättig (WMDE)) [10:40:10] (03CR) 10Legoktm: [C: 032] Handle titles containing @ in JS [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/148342 (owner: 10Wctaiwan) [10:43:12] (03CR) 10jenkins-bot: [V: 04-1] Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 (https://bugzilla.wikimedia.org/52061) (owner: 10TTO) [10:43:24] (03Merged) 10jenkins-bot: Handle titles containing @ in JS [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/148342 (owner: 10Wctaiwan) [10:43:53] (03PS1) 10Robert Vogel: UEModulePDF: Encoding issue in link [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148350 [10:45:06] 3MediaWiki extensions / 3WikidataRepo: put a link to the entity's canonical URI into the toolbox - 10https://bugzilla.wikimedia.org/54275#c5 (10Daniel Kinzler) No. The mediawiki namespace is not part of the canonical URI, so please use $title->getDBKey() instead of $title->getPrefixedText(). That should work... [10:45:35] (03Merged) 10jenkins-bot: Add more test cases to ActionTest [core] - 10https://gerrit.wikimedia.org/r/147043 (owner: 10Thiemo Mättig (WMDE)) [10:48:48] (03CR) 10Hoo man: [C: 032] Add tests for disabled actions in ActionTest [core] - 10https://gerrit.wikimedia.org/r/147045 (owner: 10Thiemo Mättig (WMDE)) [10:49:47] (03CR) 10jenkins-bot: [V: 04-1] Add tests for disabled actions in ActionTest [core] - 10https://gerrit.wikimedia.org/r/147045 (owner: 10Thiemo Mättig (WMDE)) [10:52:58] (03CR) 10Nikerabbit: [C: 031] Remove functions deprecated since 1.19 from EditPage.php [core] - 10https://gerrit.wikimedia.org/r/148276 (owner: 10Withoutaname) [10:56:36] 3MediaWiki extensions / 3WikidataRepo: Server side generated html of read only Entity views shouldn't include edit links - 10https://bugzilla.wikimedia.org/68325#c1 (10Thiemo Mättig) 5NEW>3PATC https://gerrit.wikimedia.org/r/#/c/140007/ [10:56:41] (03CR) 10Nikerabbit: [C: 031] Remove functions deprecated since 1.21 from EditPage.php [core] - 10https://gerrit.wikimedia.org/r/148282 (owner: 10Withoutaname) [10:57:23] (03PS1) 10Legoktm: Add zuul config for a bunch of extensions I maintain [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148352 [10:58:20] (03PS2) 10Nikerabbit: Include ICU version in cache key for collation first letters [core] - 10https://gerrit.wikimedia.org/r/148251 (https://bugzilla.wikimedia.org/68344) (owner: 10Brian Wolff) [10:59:05] (03CR) 10Legoktm: "These already have entries in jenkins-job-builder-config AFAIS." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148352 (owner: 10Legoktm) [10:59:22] (03CR) 10Nikerabbit: [C: 04-1] Include ICU version in cache key for collation first letters (032 comments) [core] - 10https://gerrit.wikimedia.org/r/148251 (https://bugzilla.wikimedia.org/68344) (owner: 10Brian Wolff) [10:59:51] 3MediaWiki extensions / 3Cite: Inconsistently numbered references - 10https://bugzilla.wikimedia.org/46140#c3 (10Gadget850) * I see this now. I stripped this down to a simpler exemplar: 12 {{reflist|group="u"|refs= (03PS1) 10Swidmann: Cache support [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/148354 [11:03:36] (03PS1) 10Swidmann: Added cache support for extensions [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148355 [11:04:34] (03CR) 10Swidmann: "depends on: https://gerrit.wikimedia.org/r/#/c/148354/" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148355 (owner: 10Swidmann) [11:06:11] https://github.com/wikimedia/integration-jenkins-job-builder-config/blob/master/mediawiki-extensions.yaml#L387 o.O [11:11:28] (03CR) 10SG: [C: 04-1] WIP: Hide load more button with JavaScript when infinite scroll supports (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145470 (owner: 10Jdlrobson) [11:12:08] (03CR) 10SG: [C: 031] "This SEEMS like the right way to go about it..." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147344 (owner: 10Jdlrobson) [11:16:05] (03CR) 10Nikerabbit: [C: 04-1] "Multiple code quality issues. I'm not quite sure whether the approach is solid, would like Daniel and others to comment on that." (0322 comments) [core] - 10https://gerrit.wikimedia.org/r/137033 (owner: 10SPQRobin) [11:20:32] (03CR) 10SG: [C: 031] "Very minor concerns. Feel free to +2 once adjusted." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/146785 (https://bugzilla.wikimedia.org/68021) (owner: 10Matthias Mullie) [11:33:02] (03CR) 10Tweichart: [C: 031 V: 031] Cache support (035 comments) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/148354 (owner: 10Swidmann) [11:35:19] (03PS2) 10Lekshmi: Added title text for Beta in personal tools [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/148092 (https://bugzilla.wikimedia.org/68126) [11:40:45] (03CR) 10Legoktm: "Code works fine, minor thing in the qqq." (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/148092 (https://bugzilla.wikimedia.org/68126) (owner: 10Lekshmi) [11:47:46] (03PS1) 1020after4: Patch to make phabricator file attachment policies more sane. [phabricator/phabricator] - 10https://gerrit.wikimedia.org/r/148360 [11:48:07] 3Wikimedia / 3Bugzilla: Create a "MediaWiki skins" product, with a component for each of the core skins - 10https://bugzilla.wikimedia.org/66441#c11 (10Andre Klapper) 5NEW>3RESO/FIX What was requested in the summary has been created, hence closing as fixed [11:48:36] 3Wikimedia / 3Bugzilla: Hard to type in email box on Bugzilla's new user page on Android - 10https://bugzilla.wikimedia.org/66175 (10Andre Klapper) [11:49:05] 3Wikimedia / 3Bugzilla: Bugzilla's default skin needs typography refresh - 10https://bugzilla.wikimedia.org/63776 (10Andre Klapper) s:5normal>3enhanc [11:50:21] 3Wikimedia / 3Bugzilla: "(take)" (and perhaps "(edit)") should put the previous assignee in the CC List - 10https://bugzilla.wikimedia.org/62892#c2 (10Andre Klapper) 5NEW>3RESO/WON I disagree because we'd add the default assignee to CC always and spam them. [11:50:22] (03CR) 10Robert Vogel: [C: 032 V: 032] PHP 5.3 compatibility [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148341 (owner: 10Pigpen) [11:53:29] (03PS1) 10Legoktm: Add jobs for analytics/quarry/web [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/148361 [11:54:41] (03CR) 10jenkins-bot: [V: 04-1] Add jobs for analytics/quarry/web [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/148361 (owner: 10Legoktm) [11:56:06] (03PS4) 10Thiemo Mättig (WMDE): Add tests for NULL to ActionTest [core] - 10https://gerrit.wikimedia.org/r/147054 [11:56:08] (03PS6) 10Thiemo Mättig (WMDE): Make an empty "?action=" parameter default to "view" [core] - 10https://gerrit.wikimedia.org/r/147058 [11:56:10] (03PS4) 10Thiemo Mättig (WMDE): Add tests for IE workarounds to ActionTest [core] - 10https://gerrit.wikimedia.org/r/147056 [11:56:12] (03PS4) 10Thiemo Mättig (WMDE): Add tests for disabled actions in ActionTest [core] - 10https://gerrit.wikimedia.org/r/147045 [11:56:14] (03PS1) 10Legoktm: Add zuul config for analytics/quarry/web [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148362 [11:57:18] (03PS2) 10Legoktm: Add jobs for analytics/quarry/web [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/148361 [11:58:37] 3Wikimedia / 3Bugzilla: Bugzilla "Assigned To: Nobody" field confusing: Clicking it does not provide action like "take" - 10https://bugzilla.wikimedia.org/61985 (10Andre Klapper) p:5Normal>3Low [12:00:07] 3MediaWiki / 3Parser: RTL/bidirectional issues (tracking) - 10https://bugzilla.wikimedia.org/745 (10Amir E. Aharoni) [12:00:11] 3MediaWiki / 3ResourceLoader: ResourceLoaderLESSFunctions::embed does not support CSSJanus flipping for RTL - 10https://bugzilla.wikimedia.org/66091 (10Amir E. Aharoni) [12:00:11] 3MediaWiki / 3ResourceLoader: External link icon is not flipped in RTL - 10https://bugzilla.wikimedia.org/68326 (10Amir E. Aharoni) [12:01:37] 3MediaWiki / 3Skin and page rendering: Arrow with mw-icon-arrow-collapsed points the wrong way in RTL wikis - 10https://bugzilla.wikimedia.org/66773 (10Amir E. Aharoni) [12:01:37] 3MediaWiki / 3ResourceLoader: ResourceLoaderLESSFunctions::embed does not support CSSJanus flipping for RTL - 10https://bugzilla.wikimedia.org/66091 (10Amir E. Aharoni) [12:02:50] 3MediaWiki / 3ResourceLoader: ResourceLoaderLESSFunctions::embed does not support CSSJanus flipping for RTL - 10https://bugzilla.wikimedia.org/66091 (10Amir E. Aharoni) [12:04:20] 3MediaWiki / 3ResourceLoader: ResourceLoader: Remove custom LESS functions - 10https://bugzilla.wikimedia.org/67368 (10Amir E. Aharoni) [12:04:22] 3MediaWiki / 3ResourceLoader: LESS compiler should preserve the position of CSSMin / CSSJanus annotations - 10https://bugzilla.wikimedia.org/54673 (10Amir E. Aharoni) [12:10:06] 3Wikimedia / 3Bugzilla: Overthrow Bugzilla - 10https://bugzilla.wikimedia.org/60124#c19 (10Andre Klapper) 5UNCO>3RESO/WOR Being worked on; not tracked here but in http://fab.wmflabs.org/T39 [12:12:39] 3Wikimedia / 3Bugzilla: Add Skin:Chameleon - 10https://bugzilla.wikimedia.org/50191#c11 (10Andre Klapper) 5REOP>3RESO/FIX Was fixed by bug 66441 [12:13:53] 3MediaWiki / 3ResourceLoader: ResourceLoader: Remove custom LESS functions - 10https://bugzilla.wikimedia.org/67368 (10Amir E. Aharoni) [12:14:41] 3MediaWiki / 3ResourceLoader: ResourceLoader: Remove custom LESS functions - 10https://bugzilla.wikimedia.org/67368 (10Amir E. Aharoni) [12:14:41] 3MediaWiki / 3ResourceLoader: ResourceLoaderLESSFunctions::embed does not support CSSJanus flipping for RTL - 10https://bugzilla.wikimedia.org/66091 (10Amir E. Aharoni) [12:16:10] 3MediaWiki / 3ResourceLoader: ResourceLoaderLESSFunctions::embed does not support CSSJanus flipping for RTL - 10https://bugzilla.wikimedia.org/66091 (10Amir E. Aharoni) [12:16:24] 3MediaWiki / 3ResourceLoader: ResourceLoaderLESSFunctions::embed does not support CSSJanus flipping for RTL - 10https://bugzilla.wikimedia.org/66091 (10Amir E. Aharoni) [12:20:16] andre__, chasemp I want to create a fab project for https://www.mediawiki.org/wiki/Data_%26_Developer_Hub -- can JFDI or do you want me to request/accept following that process we just created? :) [12:20:50] can I just do it, i mean [12:22:05] qgil, I think you can JFDI (we could always rename the project afterwards following some naming scheme?) [12:22:21] andre__, ok, thanks [12:22:55] (03CR) 10Smuggli: [C: 04-1] Cache support (031 comment) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/148354 (owner: 10Swidmann) [12:26:10] 3MediaWiki / 3Redirects: English page references wrong Russian page - 10https://bugzilla.wikimedia.org/68374 (10mlarisa) 3UNCO p:3Unprio s:3normal a:3None The page "Dissernet" https://en.wikipedia.org/wiki/Dissernet references a wrong Russian page, while the correst Russian page https://ru.wikipedia.... [12:27:16] (03CR) 10Hcohl: [C: 031] Add new MathHook [extensions/Math] - 10https://gerrit.wikimedia.org/r/147867 (owner: 10Physikerwelt) [12:28:50] (03PS1) 10Thiemo Mättig (WMDE): Add test for canUseWikiPage special case to ActionTest [core] - 10https://gerrit.wikimedia.org/r/148365 [12:28:58] (03CR) 10Smuggli: [C: 031 V: 031] Added cache support for extensions [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148355 (owner: 10Swidmann) [12:29:40] (03CR) 10Smuggli: [C: 032 V: 032] UEModulePDF: Encoding issue in link [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148350 (owner: 10Robert Vogel) [12:34:13] Hi is anyone familar with svg rendering [12:34:44] is there a way to construct a SVGReader from a string that represents the SVG content [12:37:21] 3MediaWiki / 3Redirects: English page references wrong Russian page - 10https://bugzilla.wikimedia.org/68374#c1 (10Andre Klapper) > references a wrong Russian page What does that exactly and specifically mean? [12:39:50] 3MediaWiki extensions / 3WikidataRepo: Update the wb_terms table so it does not have a numeric entity id - 10https://bugzilla.wikimedia.org/56711 (10Lydia Pintscher) [12:40:22] 3MediaWiki extensions / 3WikidataRepo: Update entity_per_page table so it does not have a numeric entity id - 10https://bugzilla.wikimedia.org/56712 (10Lydia Pintscher) [12:45:06] 3Wikimedia / 3Interwiki links: English page references wrong Russian page - 10https://bugzilla.wikimedia.org/68374#c2 (10Jesús Martínez Novo (Ciencia Al Poder)) That's because an interlanguage link on the English page is present, pointing to the wrong page of the Russian one. Looking at the source code, I d... [12:49:12] (03PS1) 10Tweichart: resourceloader + js error fix [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148366 [12:51:22] 3Wikimedia / 3Interwiki links: English page references wrong Russian page - 10https://bugzilla.wikimedia.org/68374#c3 (10mlarisa) Please do so! The intended behaviour is to reference a single correct Russian page as an interlangugae link - and it worked initially correctly, I might have created some abundant... [12:56:06] (03CR) 10Smuggli: [C: 04-1 V: 04-1] resourceloader + js error fix (032 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148366 (owner: 10Tweichart) [12:56:52] 3MediaWiki / 3Parser: Local interwiki prefix + lang code (e.g. [[w:de:Foo]] on enwiki) should not give interlanguage link - 10https://bugzilla.wikimedia.org/68085#c2 (10Bartosz Dziewoński) *** Bug 68374 has been marked as a duplicate of this bug. *** [12:56:52] 3Wikimedia / 3Interwiki links: English page references wrong Russian page - 10https://bugzilla.wikimedia.org/68374#c4 (10Bartosz Dziewoński) 5UNCO>3RESO/DUP *** This bug has been marked as a duplicate of bug 68085 *** [12:59:28] (03PS9) 10Jamesmontalvo3: Add file approval and fine-tuned permissions; bump to v1.0 [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 [12:59:48] (03CR) 10Jamesmontalvo3: "The the methods you mentioned have been reduced into one. I stand by getPermissions() being required to setup defaults. Otherwise you have" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [13:00:04] (03CR) 10Jamesmontalvo3: [C: 031] Add file approval and fine-tuned permissions; bump to v1.0 [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [13:01:28] (03PS5) 10Bartosz Dziewoński: No interlanguage links after local interwiki prefixes [core] - 10https://gerrit.wikimedia.org/r/146708 (https://bugzilla.wikimedia.org/68085) (owner: 10TTO) [13:02:01] (03CR) 10Bartosz Dziewoński: "Rebased release notes." [core] - 10https://gerrit.wikimedia.org/r/146708 (https://bugzilla.wikimedia.org/68085) (owner: 10TTO) [13:02:09] (03CR) 10Bartosz Dziewoński: [C: 032] No interlanguage links after local interwiki prefixes [core] - 10https://gerrit.wikimedia.org/r/146708 (https://bugzilla.wikimedia.org/68085) (owner: 10TTO) [13:06:22] (03Merged) 10jenkins-bot: No interlanguage links after local interwiki prefixes [core] - 10https://gerrit.wikimedia.org/r/146708 (https://bugzilla.wikimedia.org/68085) (owner: 10TTO) [13:08:07] 3MediaWiki / 3Parser: Local interwiki prefix + lang code (e.g. [[w:de:Foo]] on enwiki) should not give interlanguage link - 10https://bugzilla.wikimedia.org/68085 (10Jesús Martínez Novo (Ciencia Al Poder)) 5PATC>3RESO/FIX a:3This, that and the other [13:08:40] (03PS3) 10Lekshmi: Added title text for Beta in personal tools [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/148092 (https://bugzilla.wikimedia.org/68126) [13:11:21] 3MediaWiki / 3General/Unknown: Tracking bug (tracking) - 10https://bugzilla.wikimedia.org/2007 (10Florian) [13:40:55] (03PS1) 10Taueres: Api request log: check for NULL before invoking methods [core] - 10https://gerrit.wikimedia.org/r/148372 [13:49:02] (03CR) 10Gilles: Don't check description validity on keyup (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/148222 (https://bugzilla.wikimedia.org/33607) (owner: 10MarkTraceur) [13:49:52] (03CR) 10Gilles: [C: 031] Remove WebVideoJobRunner.php [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/148307 (owner: 10MaxSem) [13:51:01] (03CR) 10Taueres: "To reproduce the bug which has been fixed with this patch, follow these steps:" [core] - 10https://gerrit.wikimedia.org/r/148372 (owner: 10Taueres) [13:55:05] 3MediaWiki / 3Patrolling: Let anons see what was patrolled - 10https://bugzilla.wikimedia.org/60958#c2 (10Nathan Larson) Gerrit change 148300 . Does this need to be documented in the release notes as a configuration change? [13:56:20] 3MediaWiki / 3Patrolling: Let anons see what was patrolled - 10https://bugzilla.wikimedia.org/60958 (10Nathan Larson) 5NEW>3PATC [13:58:04] (03PS1) 10Manybubbles: Eat bad forward slashes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148375 [14:02:47] (03CR) 10Parent5446: [C: 04-1] "Release notes" [core] - 10https://gerrit.wikimedia.org/r/148300 (https://bugzilla.wikimedia.org/60958) (owner: 10leucosticte) [14:02:51] 3MediaWiki / 3Patrolling: Let anons see what was patrolled - 10https://bugzilla.wikimedia.org/60958#c3 (10Tyler Romeo) (In reply to Nathan Larson from comment #2) > Gerrit change #148300 . Does this need to be documented in the release notes > as a configuration change? Yes. [14:05:12] (03CR) 10Gilles: [C: 04-1] "Small regression: if you add N files at once, only the first one will have the spinner, until one of the file completes (and suddenly all " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [14:05:23] (03CR) 10Bartosz Dziewoński: Let anons see what was patrolled Bug: 60958 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/148300 (https://bugzilla.wikimedia.org/60958) (owner: 10leucosticte) [14:06:48] (03CR) 10Chad: [C: 032] Eat bad forward slashes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148375 (owner: 10Manybubbles) [14:06:56] 3MediaWiki extensions / 3WikidataRepo: Write migration script for schema changes to entity_per_page table - 10https://bugzilla.wikimedia.org/68377 (10tobias.gritschacher) p:5Unprio>3High s:5normal>3major [14:06:56] 3MediaWiki extensions / 3WikidataRepo: Update entity_per_page table so it does not have a numeric entity id - 10https://bugzilla.wikimedia.org/56712 (10tobias.gritschacher) [14:06:59] (03Merged) 10jenkins-bot: Eat bad forward slashes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148375 (owner: 10Manybubbles) [14:07:53] (03CR) 10Gilles: "I think it might simply be because $.grep has counter-intuitive expectations about the function signature (element first, index second):" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146140 (owner: 10MarkTraceur) [14:08:07] 3MediaWiki extensions / 3WikidataRepo: Write migration script for schema changes to wb_terms table - 10https://bugzilla.wikimedia.org/68378 (10tobias.gritschacher) p:5Unprio>3High s:5normal>3major [14:08:08] 3MediaWiki extensions / 3WikidataRepo: Update the wb_terms table so it does not have a numeric entity id - 10https://bugzilla.wikimedia.org/56711 (10tobias.gritschacher) [14:09:05] andre__: qgil let's shake out the process if we can from here on out for project creation? if we have time, may as well [14:10:05] chasemp, andre__ https://www.mediawiki.org/wiki/Phabricator/Help works for me already [14:10:42] chasemp, andre__ some day I want to document a checklist for project creators [14:15:33] (03PS1) 10Vikassy: Language screenshot jobs run in serial now [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/148378 [14:16:12] (03PS2) 10Parent5446: Make UserNotLoggedIn redirect to login page [core] - 10https://gerrit.wikimedia.org/r/148144 (https://bugzilla.wikimedia.org/15484) [14:17:09] 3MediaWiki extensions / 3WikidataRepo: Allow adding references for claims on properties in the UI - 10https://bugzilla.wikimedia.org/68379 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Since we decided to allow that via the API, the UI should also support it. [14:17:21] 3MediaWiki extensions / 3WikidataRepo: Allow adding references for claims on properties in the UI - 10https://bugzilla.wikimedia.org/68379 (10tobias.gritschacher) p:5Unprio>3High s:5normal>3major [14:17:36] (03CR) 10jenkins-bot: [V: 04-1] Make UserNotLoggedIn redirect to login page [core] - 10https://gerrit.wikimedia.org/r/148144 (https://bugzilla.wikimedia.org/15484) (owner: 10Parent5446) [14:21:36] 3MediaWiki extensions / 3WikidataRepo: Disallow references on properties - 10https://bugzilla.wikimedia.org/67421#c1 (10tobias.gritschacher) 5NEW>3RESO/WON Per discussion in story time on 2014-07-22, we will allow references for claims on properties. See also https://bugzilla.wikimedia.org/show_bug.cgi?i... [14:22:05] 3MediaWiki extensions / 3WikidataRepo: Allow adding references for claims on properties in the UI - 10https://bugzilla.wikimedia.org/68379 (10tobias.gritschacher) [14:22:18] (03CR) 10Hoo man: [C: 032] Add tests for NULL to ActionTest [core] - 10https://gerrit.wikimedia.org/r/147054 (owner: 10Thiemo Mättig (WMDE)) [14:25:28] (03PS2) 10Zfilipin: Language screenshot jobs run in serial now [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/148378 (owner: 10Vikassy) [14:26:52] (03Merged) 10jenkins-bot: Add tests for NULL to ActionTest [core] - 10https://gerrit.wikimedia.org/r/147054 (owner: 10Thiemo Mättig (WMDE)) [14:27:21] 3MediaWiki extensions / 3WikidataRepo: Factor dispatch logic out of maintenance script - 10https://bugzilla.wikimedia.org/68380 (10tobias.gritschacher) p:5Unprio>3High s:5normal>3major [14:27:22] 3MediaWiki extensions / 3WikidataRepo: Dispatching via delayed jobs - 10https://bugzilla.wikimedia.org/46643 (10tobias.gritschacher) [14:27:33] (03PS1) 10Chad: Merge branch 'master' into wmf/1.24wmf14 [extensions/CirrusSearch] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148381 [14:28:39] 3MediaWiki extensions / 3WikidataRepo: [Dispatch via delayed job] Factor dispatch logic out of maintenance script - 10https://bugzilla.wikimedia.org/68380 (10tobias.gritschacher) [14:29:22] 3MediaWiki extensions / 3WikidataRepo: [Dispatch via delayed job] Implement the trigger job - 10https://bugzilla.wikimedia.org/68381 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Use delayed jobs when Redis is available, dispatch immediately otherwise. [14:29:37] 3Wikimedia / 3Bugzilla: "(take)" (and perhaps "(edit)") should put the previous assignee in the CC List - 10https://bugzilla.wikimedia.org/62892#c3 (10Tim Landscheidt) (In reply to Andre Klapper from comment #2) > I disagree because we'd add the default assignee to CC always and spam them. I wrote in commen... [14:29:37] 3MediaWiki extensions / 3WikidataRepo: Dispatching via delayed jobs - 10https://bugzilla.wikimedia.org/46643 (10tobias.gritschacher) [14:29:38] 3MediaWiki extensions / 3WikidataRepo: [Dispatch via delayed job] Implement the trigger job - 10https://bugzilla.wikimedia.org/68381 (10tobias.gritschacher) p:5Unprio>3High s:5normal>3major [14:30:06] (03CR) 10Manybubbles: [C: 031] Merge branch 'master' into wmf/1.24wmf14 [extensions/CirrusSearch] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148381 (owner: 10Chad) [14:30:12] (03CR) 10Manybubbles: [C: 032] Merge branch 'master' into wmf/1.24wmf14 [extensions/CirrusSearch] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148381 (owner: 10Chad) [14:30:21] (03Merged) 10jenkins-bot: Merge branch 'master' into wmf/1.24wmf14 [extensions/CirrusSearch] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148381 (owner: 10Chad) [14:31:21] 3MediaWiki extensions / 3WikidataRepo: [Dispatch via delayed job] schedule trigger jobs on each change - 10https://bugzilla.wikimedia.org/68382 (10tobias.gritschacher) p:5Unprio>3High s:5normal>3major [14:31:22] 3MediaWiki extensions / 3WikidataRepo: Dispatching via delayed jobs - 10https://bugzilla.wikimedia.org/46643 (10tobias.gritschacher) [14:31:58] (03CR) 10Zfilipin: [C: 032] Language screenshot jobs run in serial now [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/148378 (owner: 10Vikassy) [14:33:13] (03Merged) 10jenkins-bot: Language screenshot jobs run in serial now [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/148378 (owner: 10Vikassy) [14:35:24] (03PS3) 10Parent5446: Make UserNotLoggedIn redirect to login page [core] - 10https://gerrit.wikimedia.org/r/148144 (https://bugzilla.wikimedia.org/15484) [14:39:37] (03CR) 10jenkins-bot: [V: 04-1] Make UserNotLoggedIn redirect to login page [core] - 10https://gerrit.wikimedia.org/r/148144 (https://bugzilla.wikimedia.org/15484) (owner: 10Parent5446) [14:40:18] (03PS3) 10Bartosz Dziewoński: Vector: Make better use of $wgResourceModuleSkinStyles [core] - 10https://gerrit.wikimedia.org/r/148304 [14:40:20] (03PS15) 10Bartosz Dziewoński: resourceloader: Allow skins to provide additional styles for any module [core] - 10https://gerrit.wikimedia.org/r/141259 [14:42:38] (03PS1) 10Chad: Updating Cirrus to master [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148384 [14:42:47] (03CR) 10jenkins-bot: [V: 04-1] Vector: Make better use of $wgResourceModuleSkinStyles [core] - 10https://gerrit.wikimedia.org/r/148304 (owner: 10Bartosz Dziewoński) [14:46:34] (03Draft2) 10Bartosz Dziewoński: LessFileCompilationTest: Check $file during the test, not in constructor [core] - 10https://gerrit.wikimedia.org/r/148383 [14:46:53] (03PS3) 10Bartosz Dziewoński: LessFileCompilationTest: Check $file during the test, not in constructor [core] - 10https://gerrit.wikimedia.org/r/148383 [14:51:09] (03CR) 10Hoo man: [C: 032] Add tests for IE workarounds to ActionTest [core] - 10https://gerrit.wikimedia.org/r/147056 (owner: 10Thiemo Mättig (WMDE)) [14:53:05] (03PS1) 10Jack Phoenix: Fix a bunch of "undefined property" E_NOTICEs. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/148387 [14:53:33] (03PS2) 10Rush: Patch to make phabricator file attachment policies more sane. [phabricator/phabricator] - 10https://gerrit.wikimedia.org/r/148360 (owner: 1020after4) [14:53:44] (03CR) 10Jack Phoenix: [C: 032 V: 032] Fix a bunch of "undefined property" E_NOTICEs. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/148387 (owner: 10Jack Phoenix) [14:54:26] (03PS4) 10Bartosz Dziewoński: Vector: Make better use of $wgResourceModuleSkinStyles [core] - 10https://gerrit.wikimedia.org/r/148304 [14:54:54] (03Merged) 10jenkins-bot: Add tests for IE workarounds to ActionTest [core] - 10https://gerrit.wikimedia.org/r/147056 (owner: 10Thiemo Mättig (WMDE)) [14:56:05] (03PS1) 10Aude: Add Wikidata / test wikidata site link section messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148389 [14:57:40] (03CR) 10Hoo man: [C: 031] "Makes sense to me and code looks good, but didn't manually test (which really is needed here). If you need this soonish or so poke me so t" [core] - 10https://gerrit.wikimedia.org/r/147058 (owner: 10Thiemo Mättig (WMDE)) [14:59:55] (03PS2) 10Bartosz Dziewoński: Resources.php: Remove 'skinStyles' references to 'minerva' skin [core] - 10https://gerrit.wikimedia.org/r/148305 [15:00:42] (03CR) 10Manybubbles: [C: 032] Updating Cirrus to master [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148384 (owner: 10Chad) [15:00:58] (03CR) 10Phuedx: [C: 032] "This LGTM. Not only does it neaten up the test failure, it makes it actionable!" [core] - 10https://gerrit.wikimedia.org/r/148383 (owner: 10Bartosz Dziewoński) [15:04:53] (03Merged) 10jenkins-bot: Updating Cirrus to master [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148384 (owner: 10Chad) [15:06:18] (03Merged) 10jenkins-bot: LessFileCompilationTest: Check $file during the test, not in constructor [core] - 10https://gerrit.wikimedia.org/r/148383 (owner: 10Bartosz Dziewoński) [15:08:21] 3Wikimedia / 3Site requests: Category collation for Estonian projects - 10https://bugzilla.wikimedia.org/54168#c11 (10Pikne) (In reply to Bartosz Dziewoński from comment #10) > The next step is to hold a quick discussion/vote on each wiki that would > want this enabled, just to make sure nothing happen behin... [15:12:04] (03PS5) 10Ori.livneh: Fixed JobQueueAggregatorRedis to handle empty collections [core] - 10https://gerrit.wikimedia.org/r/146597 (owner: 10Aaron Schulz) [15:12:11] (03CR) 10Ori.livneh: [C: 032] Fixed JobQueueAggregatorRedis to handle empty collections [core] - 10https://gerrit.wikimedia.org/r/146597 (owner: 10Aaron Schulz) [15:13:45] (03PS2) 10Aude: Add Wikidata / test wikidata site link section messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148389 [15:14:16] (03Draft15) 10Bartosz Dziewoński: resourceloader: Allow skins to provide additional styles for any module [core] - 10https://gerrit.wikimedia.org/r/141259 [15:14:19] (03PS2) 10leucosticte: Let anons see what was patrolled [core] - 10https://gerrit.wikimedia.org/r/148300 (https://bugzilla.wikimedia.org/60958) [15:16:52] (03Merged) 10jenkins-bot: Fixed JobQueueAggregatorRedis to handle empty collections [core] - 10https://gerrit.wikimedia.org/r/146597 (owner: 10Aaron Schulz) [15:18:28] (03CR) 10Smuggli: resourceloader + js error fix (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148366 (owner: 10Tweichart) [15:21:42] (03CR) 10Tweichart: resourceloader + js error fix (032 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148366 (owner: 10Tweichart) [15:22:36] 3Wikimedia / 3Interwiki links: English page references wrong Russian page - 10https://bugzilla.wikimedia.org/68374#c5 (10mlarisa) The duplicate bug 68085 us reported as RESOLVED FIXED - but my problem remained unfixed. [15:23:13] (03PS3) 10Nemo bis: Special:Statistics default links to stats.wikimedia.org [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/147505 (https://bugzilla.wikimedia.org/65993) [15:28:06] 3Wikimedia / 3Interwiki links: English page references wrong Russian page - 10https://bugzilla.wikimedia.org/68374#c6 (10Jesús Martínez Novo (Ciencia Al Poder)) (In reply to mlarisa from comment #5) > The duplicate bug 68085 us reported as RESOLVED FIXED - but my problem > remained unfixed. It has been fixe... [15:31:50] (03CR) 10Jforrester: [C: 04-2] "This would completely break mobile VE." [core] - 10https://gerrit.wikimedia.org/r/148305 (owner: 10Bartosz Dziewoński) [15:34:02] (03PS5) 10Bartosz Dziewoński: Vector: Make better use of $wgResourceModuleSkinStyles [core] - 10https://gerrit.wikimedia.org/r/148304 [15:36:39] (03PS1) 10Bartosz Dziewoński: Preferences: Remove 'size' => 20 from 'stubthreshold' [core] - 10https://gerrit.wikimedia.org/r/148390 [15:37:18] (03PS2) 10Bartosz Dziewoński: Preferences: Remove 'size' => 20 from 'stubthreshold' [core] - 10https://gerrit.wikimedia.org/r/148390 [15:37:48] (03PS3) 10Bartosz Dziewoński: Preferences: Remove 'size' => 20 from 'stubthreshold' [core] - 10https://gerrit.wikimedia.org/r/148390 [15:38:17] (03CR) 10Bartosz Dziewoński: "I know. We need to restore this file in MobileFrontend." [core] - 10https://gerrit.wikimedia.org/r/148305 (owner: 10Bartosz Dziewoński) [15:38:50] 3Wikimedia / 3Git/Gerrit: Provide reviewer counts per Gerrit changeset in batch form - 10https://bugzilla.wikimedia.org/52329#c32 (10Nemo) $ curl https://gerrit.wikimedia.org/reviewer-counts.json | json_pp -json_opt pretty | grep -c '"reviewer_count" : "0"' 973 But most are abandoned patches. :( [15:41:49] (03CR) 10Bartosz Dziewoński: Display MediaWiki:Loginprompt on the login page (031 comment) [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/146022 (https://bugzilla.wikimedia.org/66574) (owner: 10Legoktm) [15:42:43] (03CR) 10Bartosz Dziewoński: "I have fought about the problems with the new login screen in the past, but I have stopped caring now." [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/146022 (https://bugzilla.wikimedia.org/66574) (owner: 10Legoktm) [15:44:11] (03CR) 10Bartosz Dziewoński: "Follow-up: https://gerrit.wikimedia.org/r/#/c/148390/" [core] - 10https://gerrit.wikimedia.org/r/144371 (owner: 10IAlex) [15:44:45] (03PS4) 10Bartosz Dziewoński: Preferences: Remove 'size' => 20 from 'stubthreshold' [core] - 10https://gerrit.wikimedia.org/r/148390 [15:45:08] (03CR) 10Nemo bis: "There is https://gerrit.wikimedia.org/r/#/c/148022/" [core] - 10https://gerrit.wikimedia.org/r/148390 (owner: 10Bartosz Dziewoński) [15:46:31] (03CR) 10Smuggli: [C: 04-1] "I don't like the new styling in a couple of points. The inner padding of the list must be removed that the highlighted item does not have " [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148339 (owner: 10Robert Vogel) [15:47:13] (03CR) 10Phuedx: [C: 04-2] "-2 per the following from the Trello card that tracks this change[0]:" [core] - 10https://gerrit.wikimedia.org/r/146979 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [15:50:26] (03PS3) 10Bartosz Dziewoński: Preferences: Turn stubthreshold back into a combo box [core] - 10https://gerrit.wikimedia.org/r/148022 (https://bugzilla.wikimedia.org/68313) (owner: 10TTO) [15:50:31] (03CR) 10Bartosz Dziewoński: [C: 032] Preferences: Turn stubthreshold back into a combo box [core] - 10https://gerrit.wikimedia.org/r/148022 (https://bugzilla.wikimedia.org/68313) (owner: 10TTO) [15:50:40] (03Abandoned) 10Bartosz Dziewoński: Preferences: Remove 'size' => 20 from 'stubthreshold' [core] - 10https://gerrit.wikimedia.org/r/148390 (owner: 10Bartosz Dziewoński) [15:51:06] 3MediaWiki / 3User preferences: stubthreshold insanely invasive on Special:Preferences#mw-prefsection-rendering - 10https://bugzilla.wikimedia.org/68313 (10Bartosz Dziewoński) 5PATC>3RESO/FIX [15:51:35] Nemo_bis: needs backporting? [15:52:00] (03CR) 10Bartosz Dziewoński: "Follow-up: https://gerrit.wikimedia.org/r/#/c/148022/" [core] - 10https://gerrit.wikimedia.org/r/103742 (owner: 10Chad) [15:53:36] 3Wikimedia / 3Extension setup: Enable DynamicPageList on sr.wiktionary - 10https://bugzilla.wikimedia.org/68346#c2 (10Bawolff (Brian Wolff)) (In reply to Andre Klapper from comment #1) > See bug 29596 comment 10 Srwikt (~20k pages) is quite a bit smaller than frwikt. Its probably ok (imho. Someone would nee... [15:54:06] 3Wikimedia / 3Site requests: Soft-disable uploads at mr.wikipedia - 10https://bugzilla.wikimedia.org/68292 (10Vogone) 5PATC>3RESO/FIX [15:55:41] (03Merged) 10jenkins-bot: Preferences: Turn stubthreshold back into a combo box [core] - 10https://gerrit.wikimedia.org/r/148022 (https://bugzilla.wikimedia.org/68313) (owner: 10TTO) [16:05:38] (03CR) 1020after4: "@csteipp you should follow the upstream activity... https://secure.phabricator.com/D9202" [phabricator/libphutil] - 10https://gerrit.wikimedia.org/r/147686 (owner: 10CSteipp) [16:06:53] 3MediaWiki extensions / 3WikidataRepo: Direct link to download the raw JSON data of each Entity - 10https://bugzilla.wikimedia.org/64515 (10Thiemo Mättig) [16:06:53] 3MediaWiki extensions / 3WikidataRepo: put a link to the entity's canonical URI into the toolbox - 10https://bugzilla.wikimedia.org/54275 (10Thiemo Mättig) [16:07:25] MatmaRex: ugh, it's so old as to be in 1.23; yes [16:07:39] (03PS1) 10Nemo bis: Preferences: Turn stubthreshold back into a combo box [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/148392 (https://bugzilla.wikimedia.org/68313) [16:07:55] Nemo_bis: no, i meant wmf sites [16:08:03] it's not that urgent [16:08:04] the issue is probably not visible in 1.23 [16:08:11] ah [16:08:21] because the support for 'size' was actually added later [16:08:28] ok, feel free to abandon [16:08:39] backporting won't hurt [16:10:06] 3MediaWiki / 3User preferences: stubthreshold insanely invasive on Special:Preferences#mw-prefsection-rendering - 10https://bugzilla.wikimedia.org/68313#c4 (10Nemo) 5PATC>3RESO/FIX beta.wmflabs.org is down or read only so I can't verify, but this looks fixed. [16:10:10] Deskana: btw, do you have the right to grant OAuth applications access on mw.org? [16:11:09] YuviPanda: Yeah. [16:11:19] YuviPanda: Anyone with staff rights should, iirc. [16:11:22] Deskana: oh [16:11:31] Deskana: hmm, I don't have staff rights, tho, but 'tis ok. [16:11:33] * YuviPanda goes to make request [16:11:40] Might be time to request them! [16:11:55] Deskana: yeah, I already made a request, but you should probably turn it down [16:13:02] Deskana: requested! SQL Quarry [16:13:12] Deskana: from me and halfak and other researchers! [16:14:02] half a k (thousand) other researchers. [16:14:09] heh [16:15:12] (03PS34) 10Paladox: Update jquery.ui Vector theme to 1.9.2 [core] - 10https://gerrit.wikimedia.org/r/145049 [16:15:20] (03PS1) 10Bartosz Dziewoński: commonElements: Import styling for from mediawiki.org [core] - 10https://gerrit.wikimedia.org/r/148397 [16:15:37] 3Wikimedia / 3Bugzilla: Bugzilla component for mediawiki/services/jobrunner with appropriate default CC - 10https://bugzilla.wikimedia.org/68318#c1 (10Andre Klapper) What would be a description for this component? Especially so that people have a better chance to get the difference to the existing JobQueue c... [16:17:27] (03CR) 10Jforrester: "> I know. We need to restore this file in MobileFrontend." [core] - 10https://gerrit.wikimedia.org/r/148305 (owner: 10Bartosz Dziewoński) [16:19:10] 3Wikimedia / 3Bugzilla: Bugzilla component for Mathoid - 10https://bugzilla.wikimedia.org/68144#c3 (10Andre Klapper) 5NEW>3RESO/FIX a:3Andre Klapper Created: https://bugzilla.wikimedia.org/describecomponents.cgi?product=Mathoid [16:20:16] (03CR) 10Bartosz Dziewoński: "Adding 'skinStyles' in core is also completely wrong, and adding 'skinStyles' in core for a skin that isn't even in core is doubly complet" [core] - 10https://gerrit.wikimedia.org/r/148305 (owner: 10Bartosz Dziewoński) [16:21:24] hmm 200 % wrongness [16:21:24] https://www.mediawiki.org/wiki/Special:Log/DGarry_(WMF) [16:21:26] (03CR) 10Jforrester: "> Adding 'skinStyles' in core is also completely wrong" [core] - 10https://gerrit.wikimedia.org/r/148305 (owner: 10Bartosz Dziewoński) [16:21:56] (03PS14) 10Bartosz Dziewoński: Hide edit toolbar Signature button in content namespaces by default [core] - 10https://gerrit.wikimedia.org/r/87649 (https://bugzilla.wikimedia.org/5645) (owner: 10TTO) [16:22:01] (03PS2) 10MarkTraceur: Don't check description validity on keyup [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/148222 (https://bugzilla.wikimedia.org/33607) [16:22:08] (03CR) 10Bartosz Dziewoński: "Yes, I meant bug 51154. Copy-paste fail, sorry." [core] - 10https://gerrit.wikimedia.org/r/87649 (https://bugzilla.wikimedia.org/5645) (owner: 10TTO) [16:22:10] wrong and wrong is right, no? [16:22:35] Two wrongs don't make a right, but three lefts do. [16:22:44] (03CR) 10MarkTraceur: Don't check description validity on keyup (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/148222 (https://bugzilla.wikimedia.org/33607) (owner: 10MarkTraceur) [16:32:17] (03PS1) 10Aude: Update Wikidata, js bug fixes and for json dumps [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148399 [16:36:57] (03CR) 10Bartosz Dziewoński: [C: 032] Wrapped the brackets of the collapse buttons with spans [core] - 10https://gerrit.wikimedia.org/r/148013 (owner: 10Luis Felipe Schenone) [16:40:43] (03Merged) 10jenkins-bot: Wrapped the brackets of the collapse buttons with spans [core] - 10https://gerrit.wikimedia.org/r/148013 (owner: 10Luis Felipe Schenone) [16:42:34] (03CR) 10Aude: [C: 032] Update Wikidata, js bug fixes and for json dumps [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148399 (owner: 10Aude) [16:43:21] (03PS1) 10Mwalker: Adding Petition extension as a WMF extension [tools/release] - 10https://gerrit.wikimedia.org/r/148401 [16:44:21] 3Wikimedia / 3Bugzilla: "(take)" (and perhaps "(edit)") should put the previous assignee in the CC List - 10https://bugzilla.wikimedia.org/62892#c4 (10Andre Klapper) You did write that, but I disagree on the assumption that we talk about "few cases". [16:45:56] (03Merged) 10jenkins-bot: Update Wikidata, js bug fixes and for json dumps [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148399 (owner: 10Aude) [16:46:21] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: We should dig into CirrusSearch-failures.log - 10https://bugzilla.wikimedia.org/62358#c3 (10Nik Everett) I just checked and saw two things: 1. If we try to send 50 updates all at once we might bump against an Elasticsearch queue limit. I'm chunking it to... [16:46:28] (03CR) 10Bartosz Dziewoński: [C: 032] Update jquery.ui Vector theme to 1.9.2 [core] - 10https://gerrit.wikimedia.org/r/145049 (owner: 10Paladox) [16:46:46] (03PS1) 10Mwalker: Adding petition extension [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/148403 [16:48:06] (03PS1) 10Mwalker: Adding petition extension [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148404 [16:48:32] (03PS1) 10Manybubbles: Chunk updates at 10 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148405 (https://bugzilla.wikimedia.org/62358) [16:48:48] (03Abandoned) 10Mwalker: Adding petition extension [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148404 (owner: 10Mwalker) [16:48:58] (03CR) 10Manybubbles: "This comes up pretty rarely but it is a simple fix." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148405 (https://bugzilla.wikimedia.org/62358) (owner: 10Manybubbles) [16:49:21] (03PS1) 10Mwalker: Adding petition extension [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148406 [16:49:35] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: We should dig into CirrusSearch-failures.log - 10https://bugzilla.wikimedia.org/62358 (10Nik Everett) 5PATC>3NEW [16:50:16] (03PS1) 10EBernhardson: Prevent total failure of WhatLinksHere hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148407 [16:50:19] (03PS1) 10EBernhardson: Clarify ReferenceClarifier API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148408 [16:50:22] (03CR) 10Mwalker: [C: 031] Adding petition extension [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148406 (owner: 10Mwalker) [16:50:31] (03CR) 10Mwalker: [C: 031] Adding petition extension [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/148403 (owner: 10Mwalker) [16:50:48] (03CR) 10Mwalker: [C: 031] Adding Petition extension as a WMF extension [tools/release] - 10https://gerrit.wikimedia.org/r/148401 (owner: 10Mwalker) [16:51:00] (03CR) 10Gilles: [C: 032] Don't check description validity on keyup [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/148222 (https://bugzilla.wikimedia.org/33607) (owner: 10MarkTraceur) [16:51:07] (03Merged) 10jenkins-bot: Update jquery.ui Vector theme to 1.9.2 [core] - 10https://gerrit.wikimedia.org/r/145049 (owner: 10Paladox) [16:51:17] (03CR) 10Ori.livneh: [C: 032] Fix race condition in wfShellExec() [core] - 10https://gerrit.wikimedia.org/r/147635 (https://bugzilla.wikimedia.org/67870) (owner: 10MaxSem) [16:53:04] (03CR) 10jenkins-bot: [V: 04-1] Clarify ReferenceClarifier API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148408 (owner: 10EBernhardson) [16:53:35] (03Merged) 10jenkins-bot: Don't check description validity on keyup [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/148222 (https://bugzilla.wikimedia.org/33607) (owner: 10MarkTraceur) [16:54:05] (03PS1) 10Jack Phoenix: Core patch for 1.23. [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/148409 (https://bugzilla.wikimedia.org/55640) [16:55:00] (03CR) 10Reedy: [C: 032] Adding Petition extension as a WMF extension [tools/release] - 10https://gerrit.wikimedia.org/r/148401 (owner: 10Mwalker) [16:55:14] (03Merged) 10jenkins-bot: Adding Petition extension as a WMF extension [tools/release] - 10https://gerrit.wikimedia.org/r/148401 (owner: 10Mwalker) [16:56:16] (03PS1) 10Gilles: Fix length shown in description validation message [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/148410 [16:56:47] (03CR) 10Reedy: [C: 031] Adding petition extension [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148406 (owner: 10Mwalker) [16:57:01] (03PS6) 10Bartosz Dziewoński: Vector: Make better use of $wgResourceModuleSkinStyles [core] - 10https://gerrit.wikimedia.org/r/148304 [16:57:03] (03PS16) 10Bartosz Dziewoński: resourceloader: Allow skins to provide additional styles for any module [core] - 10https://gerrit.wikimedia.org/r/141259 [16:57:09] (03CR) 10Reedy: [C: 031] Adding petition extension [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/148403 (owner: 10Mwalker) [16:58:09] (03Merged) 10jenkins-bot: Fix race condition in wfShellExec() [core] - 10https://gerrit.wikimedia.org/r/147635 (https://bugzilla.wikimedia.org/67870) (owner: 10MaxSem) [16:59:01] (03CR) 10Mwalker: [C: 032] Adding petition extension [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/148403 (owner: 10Mwalker) [16:59:10] (03CR) 10Mwalker: [C: 032] Adding petition extension [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148406 (owner: 10Mwalker) [16:59:58] (03PS2) 10EBernhardson: Clarify ReferenceClarifier API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148408 [17:00:01] (03PS2) 10EBernhardson: Prevent total failure of WhatLinksHere hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148407 [17:04:04] (03Merged) 10jenkins-bot: Adding petition extension [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/148403 (owner: 10Mwalker) [17:05:15] (03Merged) 10jenkins-bot: Adding petition extension [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148406 (owner: 10Mwalker) [17:06:58] (03CR) 10EBernhardson: [C: 04-1] "i just cant see this going out without the followup at the same time. With this patch applied i can nolonger see what content has been hi" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145172 (owner: 10Jdlrobson) [17:07:52] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: We should dig into CirrusSearch-failures.log - 10https://bugzilla.wikimedia.org/62358#c5 (10Nik Everett) Finishing up skipping the second update in point #2 from comment 3. [17:10:04] (03CR) 10EBernhardson: "at a minimum this needs to be updated to output the full topic" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147346 (owner: 10Werdna) [17:10:37] 3MediaWiki extensions / 3Translate: Special page for migration of legacy translation pages (tracking) - 10https://bugzilla.wikimedia.org/65740 (10Pratik Lahoti) [17:10:38] 3MediaWiki extensions / 3Translate: Add {{translate}} as magic word in the Translate Extension - 10https://bugzilla.wikimedia.org/68385 (10Pratik Lahoti) 3NEW p:3Unprio s:3normal a:3Pratik Lahoti {{translate}} needs to be added as a magic word for it to be used by Special:PagePreparation, a tool for... [17:11:05] (03CR) 10EBernhardson: [C: 032] Add tests for concat handlebars helper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147548 (owner: 10Jdlrobson) [17:11:38] (03Merged) 10jenkins-bot: Add tests for concat handlebars helper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147548 (owner: 10Jdlrobson) [17:12:01] (03CR) 10EBernhardson: "ping?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147649 (owner: 10EBernhardson) [17:12:27] 3MediaWiki extensions / 3Translate: Add {{translation}} as magic word in the Translate extension - 10https://bugzilla.wikimedia.org/68385 (10Nemo) [17:12:27] 3MediaWiki extensions / 3Translate: [PagePreparation] Categories should be a part of page template and tagged with {{translation}} - 10https://bugzilla.wikimedia.org/66880 (10Nemo) [17:14:15] (03PS1) 10Jack Phoenix: External link icons support. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/148412 [17:14:54] (03CR) 10Jack Phoenix: [C: 032 V: 032] External link icons support. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/148412 (owner: 10Jack Phoenix) [17:19:08] 3MediaWiki extensions / 3WikidataRepo: black text on blue background when i keydown on suggestions menu - 10https://bugzilla.wikimedia.org/68386 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs when i keydown (down arrow) on suggestions menu when entering properties, the suggestions are black text... [17:20:26] (03PS1) 10Gilles: Change the default for wgThumbnailMinimumBucketDistance [core] - 10https://gerrit.wikimedia.org/r/148414 [17:21:48] (03CR) 10Jdlrobson: [C: 032] Prevent total failure of WhatLinksHere hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148407 (owner: 10EBernhardson) [17:22:13] (03PS3) 10Jdlrobson: Documentation: Clarify ReferenceClarifier API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148408 (owner: 10EBernhardson) [17:22:18] (03CR) 10Jdlrobson: [C: 032] Documentation: Clarify ReferenceClarifier API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148408 (owner: 10EBernhardson) [17:22:24] (03Merged) 10jenkins-bot: Prevent total failure of WhatLinksHere hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148407 (owner: 10EBernhardson) [17:22:53] (03Merged) 10jenkins-bot: Documentation: Clarify ReferenceClarifier API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148408 (owner: 10EBernhardson) [17:26:06] (03Abandoned) 10Jdlrobson: QA: Fix browser tests on cached anonymous pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148258 (owner: 10Jdlrobson) [17:28:18] (03CR) 10MarkTraceur: [C: 032] "Thanks, good catch." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/148410 (owner: 10Gilles) [17:28:44] (03Merged) 10jenkins-bot: Fix length shown in description validation message [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/148410 (owner: 10Gilles) [17:30:18] (03CR) 10Gilles: [C: 04-1] Do not run `navigator.getUserMedia()` when not supported (031 comment) [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/148067 (owner: 10Rillke) [17:34:03] (03PS1) 10Wctaiwan: Change API to allow partially invalid requests [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/148416 [17:35:51] (03PS6) 10MarkTraceur: Remove UploadWizardUtil, replace with other things [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146140 [17:36:20] (03CR) 10MarkTraceur: "Oh, duh, that would certainly explain it." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146140 (owner: 10MarkTraceur) [17:37:31] (03PS7) 10MarkTraceur: Remove UploadWizardUtil, replace with other things [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146140 [17:42:43] (03Restored) 10Jdlrobson: QA: Fix browser tests on cached anonymous pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148258 (owner: 10Jdlrobson) [17:42:52] (03CR) 10Jdlrobson: "Please merge." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148258 (owner: 10Jdlrobson) [17:43:16] (03CR) 10Jdlrobson: [C: 032] QA: Add step to wait for JavaScript to load on new topic form [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147692 (owner: 10Werdna) [17:43:20] jdlrobson: around? i'm losing my sanity here [17:43:42] jdlrobson: what magic is used to ensure Minerva doesn't appear in the list of available skins, but is available for 'useskin'? [17:43:54] MatmaRex: let me check 1s [17:44:02] jdlrobson: i though it used wgSkipSkins, but i can't find the entry anywhere [17:44:15] (03Merged) 10jenkins-bot: QA: Add step to wait for JavaScript to load on new topic form [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147692 (owner: 10Werdna) [17:44:23] (03PS1) 10Manybubbles: On article move only use one job [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148417 (https://bugzilla.wikimedia.org/62358) [17:44:35] (03CR) 10jenkins-bot: [V: 04-1] On article move only use one job [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148417 (https://bugzilla.wikimedia.org/62358) (owner: 10Manybubbles) [17:44:45] MatmaRex: we use onGetPreferences hook [17:44:51] (03CR) 10Gilles: Remove UploadWizardUtil, replace with other things (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146140 (owner: 10MarkTraceur) [17:44:54] maybe incorrectly :) [17:45:01] we just unset minerva [17:45:24] huh [17:45:26] hm, interesting [17:46:05] thanks [17:47:36] 3MediaWiki / 3General/Unknown: wfShellExec() cuts off stdout at multiples of 8192 bytes - 10https://bugzilla.wikimedia.org/67870 (10Max Semenik) 5PATC>3RESO/FIX [17:47:42] MatmaRex: np. [17:47:55] MatmaRex: poke me later if no one else has looked at your skinStyles replacement [17:48:04] (03CR) 10Aude: [C: 04-2] "need to adjust this" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148389 (owner: 10Aude) [17:49:37] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/148092 (https://bugzilla.wikimedia.org/68126) (owner: 10Lekshmi) [17:49:52] 3Wikimedia / 3Interwiki links: English page references wrong Russian page - 10https://bugzilla.wikimedia.org/68374#c7 (10mlarisa) (In reply to Jesús Martínez Novo (Ciencia Al Poder) from comment #6) > (In reply to mlarisa from comment #5) > > The duplicate bug 68085 us reported as RESOLVED FIXED - but my pro... [17:50:08] 3MediaWiki extensions / 3WikidataRepo: Support claims on properties in WikibaseDataModelSerialization - 10https://bugzilla.wikimedia.org/66425#c2 (10Jeroen De Dauw) This is blocked by properly supporting claims on properties in Wikibase DataModel itself. And that is blocked by us moving to version 1.0, which... [17:50:24] (03CR) 10Jforrester: [C: 032] "Thanks!" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/148092 (https://bugzilla.wikimedia.org/68126) (owner: 10Lekshmi) [17:50:31] (03Merged) 10jenkins-bot: Added title text for Beta in personal tools [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/148092 (https://bugzilla.wikimedia.org/68126) (owner: 10Lekshmi) [17:50:41] 3MediaWiki extensions / 3Translate: Add {{translation}} as magic word in the Translate extension - 10https://bugzilla.wikimedia.org/68385#c1 (10Nemo) Cc the creator of [[mw:Template:Translation]], Happy-melon, and some others, in case they want to specify some requirements for such a magic word. [17:51:01] jdlrobson: aye [17:51:21] 3MediaWiki extensions / 3BetaFeatures: Add title text for Beta in personal tools - 10https://bugzilla.wikimedia.org/68126 (10James Forrester) 5PATC>3RESO/FIX [17:51:26] jdlrobson: also, the Minerva beta feature doesn't enable Minerva, but only allows the user to enable Minerva? heh [17:51:42] (03PS2) 10Gergő Tisza: Change the default for wgThumbnailMinimumBucketDistance [core] - 10https://gerrit.wikimedia.org/r/148414 (owner: 10Gilles) [17:51:52] jdlrobson: seems like this could use wgSkipSkins, i'll submit a patch [17:52:04] MatmaRex: thanks :) [17:52:12] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148313 (https://bugzilla.wikimedia.org/68359) (owner: 10TTO) [17:52:24] MatmaRex: yeh the beta feature (which never got enabled :() simply makes it selectable [17:52:29] (03CR) 10Gergő Tisza: [C: 032] Change the default for wgThumbnailMinimumBucketDistance [core] - 10https://gerrit.wikimedia.org/r/148414 (owner: 10Gilles) [17:53:24] 3MediaWiki extensions / 3BetaFeatures: Add title text for Beta in personal tools - 10https://bugzilla.wikimedia.org/68126 (10Kunal Mehta (Legoktm)) a:3andnlnbn18 [17:55:12] (03PS1) 10MaxSem: Fix race condition in wfShellExec() [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/148419 (https://bugzilla.wikimedia.org/67870) [17:56:55] (03Merged) 10jenkins-bot: Change the default for wgThumbnailMinimumBucketDistance [core] - 10https://gerrit.wikimedia.org/r/148414 (owner: 10Gilles) [17:58:55] (03PS1) 10BryanDavis: [WIP] Interstitial notification page for renamed users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/148420 (https://bugzilla.wikimedia.org/67995) [17:59:09] (03PS1) 10MaxSem: Release notes for I050292dbb76821f66a15f937bf3aaf4defe67687 [core] - 10https://gerrit.wikimedia.org/r/148421 [17:59:54] (03CR) 10Siebrand: "i18n/L10n reviewed." (031 comment) [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [18:00:10] (03CR) 10Siebrand: [C: 04-1] Add file approval and fine-tuned permissions; bump to v1.0 [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [18:01:24] jdlrobson: https://gerrit.wikimedia.org/r/148423 untested [18:02:36] (03CR) 10MarkTraceur: Remove UploadWizardUtil, replace with other things (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146140 (owner: 10MarkTraceur) [18:03:12] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/148420 (https://bugzilla.wikimedia.org/67995) (owner: 10BryanDavis) [18:03:33] (03PS1) 10Bartosz Dziewoński: Define fallback skin using $wgFallbackSkin instead of hardcoding Vector [core] - 10https://gerrit.wikimedia.org/r/148424 (https://bugzilla.wikimedia.org/68332) [18:03:38] (03PS1) 10Bartosz Dziewoński: Update documentation for $wgSkipSkins [core] - 10https://gerrit.wikimedia.org/r/148425 [18:04:07] 3MediaWiki extensions / 3CentralNotice: Installation (update.php): Duplicate entry '1' for key 'PRIMARY' - 10https://bugzilla.wikimedia.org/68388 (10Florian) 3NEW p:3Unprio s:3normal a:3None The update-process (update.php) fails with the following message while installation of CentralNotice: Duplicat... [18:04:19] (03CR) 10Gilles: Add a maintinance report about TimedText pages that don't have a file (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/147749 (owner: 10Brian Wolff) [18:04:54] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed. Reluctantly ;)." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148055 (owner: 10Smuggli) [18:05:10] thanks MatmaRex i'm mostly working in FLow's codebase at the moment, so will take a look when ican [18:05:10] (03CR) 10Siebrand: "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/84194 (https://bugzilla.wikimedia.org/15584) (owner: 10TTO) [18:05:46] sure [18:07:55] (03CR) 10Siebrand: [C: 032] Make Special:Email an alias for Special:EmailUser [core] - 10https://gerrit.wikimedia.org/r/146798 (owner: 10Jackmcbarn) [18:08:38] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148294 (owner: 10Werdna) [18:08:41] (03CR) 10Jdlrobson: [C: 032] New hooks for external integration to notification intiialization (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148265 (owner: 10EBernhardson) [18:09:05] (03Merged) 10jenkins-bot: New hooks for external integration to notification intiialization [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148265 (owner: 10EBernhardson) [18:09:28] (03PS1) 10Manybubbles: Fix import [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148428 [18:09:33] (03CR) 10jenkins-bot: [V: 04-1] Fix import [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148428 (owner: 10Manybubbles) [18:10:44] (03PS2) 10Manybubbles: Fix import [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148428 [18:11:10] (03CR) 10Legoktm: "So what's the planned usecase? These hooks aren't documented at all..." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148265 (owner: 10EBernhardson) [18:11:43] (03Merged) 10jenkins-bot: Make Special:Email an alias for Special:EmailUser [core] - 10https://gerrit.wikimedia.org/r/146798 (owner: 10Jackmcbarn) [18:12:52] (03CR) 10Bartosz Dziewoński: "This probably doesn't do what you want. mw.hook calls are asynchronous and memorized." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148265 (owner: 10EBernhardson) [18:16:39] (03PS2) 10Manybubbles: On article move only use one job [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148417 (https://bugzilla.wikimedia.org/62358) [18:19:47] (03PS3) 10Rohan013: FeedContributions now shows diffs instead of whole articles. [core] - 10https://gerrit.wikimedia.org/r/143904 (https://bugzilla.wikimedia.org/41085) [18:21:21] (03CR) 10Rohan013: "Fixed whitespaces" [core] - 10https://gerrit.wikimedia.org/r/143904 (https://bugzilla.wikimedia.org/41085) (owner: 10Rohan013) [18:22:07] (03PS8) 10MarkTraceur: Remove UploadWizardUtil, replace with other things [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146140 [18:22:22] (03PS4) 10Parent5446: Make UserNotLoggedIn redirect to login page [core] - 10https://gerrit.wikimedia.org/r/148144 (https://bugzilla.wikimedia.org/15484) [18:22:38] (03CR) 10jenkins-bot: [V: 04-1] Remove UploadWizardUtil, replace with other things [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146140 (owner: 10MarkTraceur) [18:23:15] (03PS9) 10MarkTraceur: Remove UploadWizardUtil, replace with other things [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146140 [18:24:45] (03CR) 10Jdlrobson: [C: 04-1] Highlight unread message from notifications link (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148310 (owner: 10EBernhardson) [18:25:06] 3MediaWiki extensions / 3CentralNotice: Installation (update.php): Duplicate entry '1' for key 'PRIMARY' - 10https://bugzilla.wikimedia.org/68388 (10Florian) 5PATC>3RESO/FIX [18:25:32] (03PS1) 10Chad: Missing use statement for InterwikiSearcher [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148431 [18:26:49] (03Abandoned) 10Chad: Missing use statement for InterwikiSearcher [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148431 (owner: 10Chad) [18:27:09] (03CR) 10Ori.livneh: [C: 032] Release notes for I050292dbb76821f66a15f937bf3aaf4defe67687 [core] - 10https://gerrit.wikimedia.org/r/148421 (owner: 10MaxSem) [18:27:40] (03CR) 10Reedy: [C: 032] "LGTM" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148428 (owner: 10Manybubbles) [18:28:01] (03PS1) 10Reedy: Fix import [extensions/CirrusSearch] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148432 [18:28:14] <^d> Commit messages involving gerrit change-ids are going to look really retarded once we ditch gerrit. [18:28:16] (03Merged) 10jenkins-bot: Fix import [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148428 (owner: 10Manybubbles) [18:29:00] (03CR) 10Reedy: [C: 032] Fix import [extensions/CirrusSearch] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148432 (owner: 10Reedy) [18:29:09] (03Merged) 10jenkins-bot: Fix import [extensions/CirrusSearch] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148432 (owner: 10Reedy) [18:29:51] (03PS2) 10Bartosz Dziewoński: DefaultSettings: Update documentation for skin-related variables [core] - 10https://gerrit.wikimedia.org/r/148425 [18:29:53] (03PS2) 10Bartosz Dziewoński: Define fallback skin using $wgFallbackSkin instead of hardcoding Vector [core] - 10https://gerrit.wikimedia.org/r/148424 (https://bugzilla.wikimedia.org/68332) [18:29:55] (03PS1) 10Bartosz Dziewoński: Move Vector's $wg configuration options to Vector.php [core] - 10https://gerrit.wikimedia.org/r/148433 [18:31:00] (03Merged) 10jenkins-bot: Release notes for I050292dbb76821f66a15f937bf3aaf4defe67687 [core] - 10https://gerrit.wikimedia.org/r/148421 (owner: 10MaxSem) [18:37:03] (03PS14) 10MaxSem: Integrate Special:MyLanguage from the Translate extension [core] - 10https://gerrit.wikimedia.org/r/140765 (https://bugzilla.wikimedia.org/66762) [18:37:49] (03PS1) 10Reedy: Update CirrusSearch to head of wmf/1.24wmf14 branch [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148435 [18:41:15] (03PS7) 10Jdlrobson: New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [18:41:55] (03CR) 10jenkins-bot: [V: 04-1] New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [18:42:22] 3MediaWiki extensions / 3WikidataRepo: black text on blue background when i keydown on suggestions menu - 10https://bugzilla.wikimedia.org/68386#c1 (10Aude) on test.wikidata, seems to work correctly in debug mode so indicates possibly a problem with resource loader definitions or caching (?) on my local dev... [18:42:23] (03CR) 10Reedy: [C: 032 V: 032] Update CirrusSearch to head of wmf/1.24wmf14 branch [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148435 (owner: 10Reedy) [18:45:25] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/147496 (https://bugzilla.wikimedia.org/59736) (owner: 10Rohan013) [18:54:05] 3MediaWiki / 3User login and signup: Replace MD5 password hashing with more secure hash - 10https://bugzilla.wikimedia.org/28419#c95 (10Chris Steipp) *** Bug 68389 has been marked as a duplicate of this bug. *** [18:59:28] heh. bug 68389 should probably be made non-private, then? [18:59:33] andre__: ^ [19:00:09] shrug - ask in the ticket? :) [19:02:06] meh [19:02:13] *shrug*, too. [19:02:15] :P [19:02:37] 3MediaWiki / 3User login and signup: Replace MD5 password hashing with more secure hash - 10https://bugzilla.wikimedia.org/28419#c96 (10scott) > return md5( $salt.'-'.md5( $password ) ) == $realHash; > return self::crypt( $password, $salt ) == $hash; > return self::reallyOldCrypt( $password, $userId ) === $h... [19:03:50] 3Wikimedia / 3Bugzilla: "(take)" (and perhaps "(edit)") should put the previous assignee in the CC List - 10https://bugzilla.wikimedia.org/62892#c5 (10Tim Landscheidt) (In reply to Andre Klapper from comment #4) > You did write that, but I disagree on the assumption that we talk about "few > cases". I just... [19:04:37] 3MediaWiki / 3User login and signup: Replace MD5 password hashing with more secure hash - 10https://bugzilla.wikimedia.org/28419#c97 (10scott) Further references on the Double HMAC mitigation: https://www.isecpartners.com/blog/2011/february/double-hmac-verification.aspx https://github.com/defuse/php-encrypt... [19:06:35] 3MediaWiki / 3User login and signup: Replace MD5 password hashing with more secure hash - 10https://bugzilla.wikimedia.org/28419#c98 (10Bartosz Dziewoński) This bug already has a pending patch: https://gerrit.wikimedia.org/r/#/c/77645 [19:06:52] 3MediaWiki / 3User login and signup: Replace MD5 password hashing with more secure hash - 10https://bugzilla.wikimedia.org/28419 (10Bartosz Dziewoński) a:5Daniel Friesen>3Tyler Romeo [19:08:07] 3MediaWiki / 3User login and signup: Replace MD5 password hashing with more secure hash - 10https://bugzilla.wikimedia.org/28419#c99 (10Liangent) Bug 68389 is still a security bug. Does duping it to a public one mean it's actually not something sensitive? [19:10:24] 3MediaWiki / 3User login and signup: MD5 is obsolete - 10https://bugzilla.wikimedia.org/68389 (10Chris Steipp) a:5security>3None [19:14:30] (03CR) 10Neilk: "Logic looks good. Verified it's fine with minDescriptionLength of 0, too." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/148410 (owner: 10Gilles) [19:18:05] 3MediaWiki / 3General/Unknown: Fatal error: Call to a member function getText() on a non-object in php-1.24wmf14/includes/OutputPage.php on line 1296 - 10https://bugzilla.wikimedia.org/68394 (10Sam Reed (reedy)) [19:18:50] (03PS1) 10Reedy: Call to a member function getText() on a non-object [core] - 10https://gerrit.wikimedia.org/r/148439 (https://bugzilla.wikimedia.org/68394) [19:19:55] (03PS1) 10Reedy: Collapse nested if statements [core] - 10https://gerrit.wikimedia.org/r/148441 [19:24:59] (03PS1) 10Parent5446: Replaced hash_equals with a custom function [core] - 10https://gerrit.wikimedia.org/r/148442 (https://bugzilla.wikimedia.org/28419) [19:26:05] 3MediaWiki / 3User login and signup: Replace MD5 password hashing with more secure hash - 10https://bugzilla.wikimedia.org/28419#c101 (10Tyler Romeo) ^Might as well be paranoid. [19:26:25] (03CR) 10jenkins-bot: [V: 04-1] Replaced hash_equals with a custom function [core] - 10https://gerrit.wikimedia.org/r/148442 (https://bugzilla.wikimedia.org/28419) (owner: 10Parent5446) [19:28:52] 3MediaWiki extensions / 3WikidataRepo: black text on blue background when i keydown on suggestions menu - 10https://bugzilla.wikimedia.org/68386#c2 (10Aude) possible solutions include to remove 'color: black' in jquery.ui.suggester.css https://github.com/wmde/ValueView/blob/master/lib/jquery.ui/jquery.ui.su... [19:29:34] (03PS36) 10Parent5446: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (https://bugzilla.wikimedia.org/54948) [19:30:24] (03PS2) 10Reedy: Add UserMergeAccountFields subscriber [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/146035 (https://bugzilla.wikimedia.org/67776) (owner: 10Legoktm) [19:30:39] (03CR) 10Reedy: [C: 032] Add UserMergeAccountFields subscriber [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/146035 (https://bugzilla.wikimedia.org/67776) (owner: 10Legoktm) [19:31:09] (03Merged) 10jenkins-bot: Add UserMergeAccountFields subscriber [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/146035 (https://bugzilla.wikimedia.org/67776) (owner: 10Legoktm) [19:31:34] (03PS2) 10Parent5446: Replaced hash_equals with a custom function [core] - 10https://gerrit.wikimedia.org/r/148442 (https://bugzilla.wikimedia.org/28419) [19:32:19] (03CR) 10Reedy: [C: 032] Add UserMergeAccountFields subscriber [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/146029 (https://bugzilla.wikimedia.org/67775) (owner: 10Legoktm) [19:33:12] (03PS2) 10Reedy: Add UserMergeAccountFields subscriber [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/146026 (https://bugzilla.wikimedia.org/67773) (owner: 10Legoktm) [19:33:22] 3MediaWiki / 3User login and signup: Replace MD5 password hashing with more secure hash - 10https://bugzilla.wikimedia.org/28419#c102 (10scott) (In reply to Liangent from comment #99) > Bug 68389 is still a security bug. Does duping it to a public one mean it's > actually not something sensitive? It's not s... [19:33:23] (03CR) 10Reedy: [C: 032] Add UserMergeAccountFields subscriber [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/146026 (https://bugzilla.wikimedia.org/67773) (owner: 10Legoktm) [19:33:28] (03Merged) 10jenkins-bot: Add UserMergeAccountFields subscriber [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/146026 (https://bugzilla.wikimedia.org/67773) (owner: 10Legoktm) [19:34:58] (03PS2) 10Reedy: Add UserMergeAccountFields subscriber [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/146027 (https://bugzilla.wikimedia.org/67771) (owner: 10Legoktm) [19:35:02] (03CR) 10Reedy: [C: 032] Add UserMergeAccountFields subscriber [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/146027 (https://bugzilla.wikimedia.org/67771) (owner: 10Legoktm) [19:35:09] (03Merged) 10jenkins-bot: Add UserMergeAccountFields subscriber [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/146027 (https://bugzilla.wikimedia.org/67771) (owner: 10Legoktm) [19:35:37] (03CR) 10Reedy: [V: 032] Add UserMergeAccountFields subscriber [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/146029 (https://bugzilla.wikimedia.org/67775) (owner: 10Legoktm) [19:36:37] 3MediaWiki extensions / 3General/Unknown: User links keyboard shortcuts do not work. - 10https://bugzilla.wikimedia.org/67824#c2 (10Ritu Swain) (In reply to Andre Klapper from comment #1) > (In reply to Ritu Swain from comment #0) > > When shortcuts for “Talk”, “Contributions” > > are used, the respective l... [19:37:09] (03PS2) 10Reedy: Add UserMergeAccountFields subscriber [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/146032 (https://bugzilla.wikimedia.org/67762) (owner: 10Legoktm) [19:37:12] (03CR) 10Reedy: [C: 032] Add UserMergeAccountFields subscriber [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/146032 (https://bugzilla.wikimedia.org/67762) (owner: 10Legoktm) [19:37:26] (03Merged) 10jenkins-bot: Add UserMergeAccountFields subscriber [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/146032 (https://bugzilla.wikimedia.org/67762) (owner: 10Legoktm) [19:37:39] 3MediaWiki extensions / 3General/Unknown: User links keyboard shortcuts do not work. - 10https://bugzilla.wikimedia.org/67824#c3 (10Ritu Swain) Created attachment 16002 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16002&action=edit Screenshot [19:37:57] 3MediaWiki extensions / 3MoodBar: Add UserMerge support to MoodBar - 10https://bugzilla.wikimedia.org/67773 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Kunal Mehta (Legoktm) [19:38:13] 3MediaWiki extensions / 3GlobalBlocking: Add UserMerge support to GlobalBlocking - 10https://bugzilla.wikimedia.org/67771 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Kunal Mehta (Legoktm) [19:38:34] 3MediaWiki extensions / 3Oversight: Add UserMerge support to Oversight - 10https://bugzilla.wikimedia.org/67775 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Kunal Mehta (Legoktm) [19:38:39] 3MediaWiki extensions / 3CheckUser: Add UserMerge support to CheckUser - 10https://bugzilla.wikimedia.org/67762 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Kunal Mehta (Legoktm) [19:40:07] 3MediaWiki / 3Revision deletion: Give sysops deleterevision rights by default - 10https://bugzilla.wikimedia.org/68298#c2 (10Vogone) If that was done, wouldn't it make sense to add "deletelogentry" as a default right as well? It's a closely related permission which could be added under the same rationale, as... [19:43:05] 3MediaWiki / 3History/Diffs: History page excessively cluttered, esp. with suppressrevision - 10https://bugzilla.wikimedia.org/18674 (10Vogone) [19:43:06] 3MediaWiki / 3Revision deletion: Give sysops deleterevision rights by default - 10https://bugzilla.wikimedia.org/68298 (10Vogone) [19:46:23] 3MediaWiki / 3Revision deletion: Give sysops deleterevision rights by default - 10https://bugzilla.wikimedia.org/68298 (10Vogone) [19:46:23] 3MediaWiki / 3Revision deletion: RevDelete/HideUser (tracking) - 10https://bugzilla.wikimedia.org/18840 (10Vogone) [19:51:35] 3MediaWiki extensions / 3WikidataRepo: black text on blue background when i keydown on suggestions menu - 10https://bugzilla.wikimedia.org/68386#c3 (10Aude) https://github.com/wmde/ValueView/pull/89 is what I propose for ValueView, although sure there are other ways to fix also. https://www.wikidata.org/wik... [19:55:28] bawolff: Ha, writing comments past each other. :-) [19:55:54] * James_F throws away his edit-conflict. [19:55:55] James_F: Second time I think :) [19:56:07] bawolff: Clearly we should liaise more. :-) [20:01:01] (03CR) 10Legoktm: [C: 04-1] [WIP] Interstitial notification page for renamed users (034 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/148420 (https://bugzilla.wikimedia.org/67995) (owner: 10BryanDavis) [20:03:50] "Try the URL, you will find that what Bugzilla also shows does NOT show like shit from the Commons URL; it has a special c.." [20:03:54] clearest bug comment ever [20:04:58] <^demon|lunch> lolwut? [20:05:47] bawolff: Where? [20:06:49] (03PS2) 10EBernhardson: Highlight unread message from notifications link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148310 [20:07:21] bug 68372 [20:08:13] (03CR) 10EBernhardson: Highlight unread message from notifications link (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148310 (owner: 10EBernhardson) [20:08:44] Wow. [20:09:25] <^demon|lunch> !b 68372 [20:09:25] https://bugzilla.wikimedia.org/68372 [20:09:50] 3MediaWiki extensions / 3Cite: cite error wrongly shows up (multiple tags in templates) - 10https://bugzilla.wikimedia.org/19631#c4 (10Gadget850) 5REOP>3RESO/FIX Resolved with Bug 31834 - Add an option to disable template caching [20:10:09] <^demon|lunch> heh good times. [20:11:01] <^demon|lunch> bawolff: I see the bug. [20:11:06] <^demon|lunch> But BZ is chomping his input I think, [20:11:21] 3MediaWiki extensions / 3Cite: Tag cite error revisions - 10https://bugzilla.wikimedia.org/22323#c1 (10Gadget850) With current error checking, this should be less of an issue. [20:11:26] <^demon|lunch> [[File:MilutinDostanić.jpg]] vs. [[File:MilutinDostani%C4%87.jpg]] [20:11:46] ć isn't an astral character, so bugzilla should be fine [20:12:00] <^demon|lunch> Anyway, you end up with a url like [[Milutin_Dostanić#mediaviewer/File:MilutinDostani%C4%87.jpg]] on enwiki [20:12:15] (03CR) 10Withoutaname: "After testing a bit, I think we can remove getTitle without affecting anything provided $context is set, and we've ensured that in Action:" [core] - 10https://gerrit.wikimedia.org/r/143211 (owner: 10Withoutaname) [20:12:17] (03PS1) 10Aaron Schulz: Added two more incrStats() calls [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148450 [20:12:20] <^demon|lunch> I see what he's saying. [20:12:56] So its a case of firefox turning percent encodings into actual letters in the path part of the url but not the fragment? [20:13:33] err, I get a url looking like Milutin_Dostanić#mediaviewer/File:MilutinDostanić.jpg . But my firefox is a bit old [20:13:59] <^demon|lunch> Chrome too? I get the same here. [20:14:25] <^demon|lunch> Don't think it's browser specific if I'm hitting it in Chrome too. [20:15:25] ori: ^ [20:15:29] bawolff: do you still have objections to https://gerrit.wikimedia.org/r/#/c/117091/ ? [20:16:13] legoktm: My objections weren't very strong. I'd preferablly like someone to try benchmarking it to see what the difference is, but I don't care that much [20:16:34] <^demon|lunch> Biggest gain will be in resource loader I bet. [20:16:47] <^demon|lunch> Right now default is cache_none since it uses normal $wgMemc and not its own cache. [20:17:28] RL already uses CACHE_ANYTHING [20:17:54] Maybe we should split $wgMainCacheType into $wgMainCacheType and $wgMainCacheForThingsThatAreSlowAndReallyNeedToBeCached [20:18:04] bawolff: what kind of benchmarks specifically? just a normal page load? [20:18:17] <^demon|lunch> legoktm: It does? [20:18:32] <^demon|lunch> What global controls it? [20:18:37] nothing :p [20:18:38] I guess so, just something to make sure it doesn't do the opposite of what we thing it does [20:18:38] * legoktm finds [20:19:04] ^demon|lunch: https://github.com/wikimedia/mediawiki-core/blob/master/includes/resourceloader/ResourceLoader.php#L165 [20:19:20] (03PS1) 10EBernhardson: Wrong messages used in moderation dialogs [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148451 (https://bugzilla.wikimedia.org/67226) [20:19:28] and a bunch more uses in https://github.com/wikimedia/mediawiki-core/blob/master/includes/resourceloader/ResourceLoaderModule.php [20:19:28] <^demon|lunch> legoktm: what do you know. [20:19:38] <^demon|lunch> it does :p [20:19:53] (03CR) 10jenkins-bot: [V: 04-1] Wrong messages used in moderation dialogs [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148451 (https://bugzilla.wikimedia.org/67226) (owner: 10EBernhardson) [20:20:15] (03CR) 10Chad: [C: 032] Remove two unused constants from EditPage.php [core] - 10https://gerrit.wikimedia.org/r/148298 (owner: 10Withoutaname) [20:20:54] (03CR) 10EBernhardson: [C: 032 V: 032] "+2V overrides failing qunit tests, those were previously non-voting and the failure is outside flow" [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148451 (https://bugzilla.wikimedia.org/67226) (owner: 10EBernhardson) [20:21:05] (03CR) 10Chad: [C: 032] Chunk updates at 10 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148405 (https://bugzilla.wikimedia.org/62358) (owner: 10Manybubbles) [20:21:09] ^demon|lunch: oh thanks [20:21:24] do you know how wgTitle is set in RequestContext [20:21:28] (03PS1) 10Aaron Schulz: Improved Redis error logging [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148452 [20:21:36] (03Merged) 10jenkins-bot: Chunk updates at 10 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148405 (https://bugzilla.wikimedia.org/62358) (owner: 10Manybubbles) [20:21:51] (03CR) 10jenkins-bot: [V: 04-1] Wrong messages used in moderation dialogs [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148451 (https://bugzilla.wikimedia.org/67226) (owner: 10EBernhardson) [20:22:03] setup.php sets it to null but it doesnt look like it is [20:23:22] (03CR) 10EBernhardson: Wrong messages used in moderation dialogs [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148451 (https://bugzilla.wikimedia.org/67226) (owner: 10EBernhardson) [20:24:24] (03CR) 10EBernhardson: [C: 032 V: 032] Wrong messages used in moderation dialogs [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148451 (https://bugzilla.wikimedia.org/67226) (owner: 10EBernhardson) [20:24:56] (03CR) 10jenkins-bot: [V: 04-1] Wrong messages used in moderation dialogs [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148451 (https://bugzilla.wikimedia.org/67226) (owner: 10EBernhardson) [20:25:05] (03Merged) 10jenkins-bot: Remove two unused constants from EditPage.php [core] - 10https://gerrit.wikimedia.org/r/148298 (owner: 10Withoutaname) [20:26:05] (03CR) 10Chad: [C: 032] On article move only use one job [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148417 (https://bugzilla.wikimedia.org/62358) (owner: 10Manybubbles) [20:26:25] (03Merged) 10jenkins-bot: On article move only use one job [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148417 (https://bugzilla.wikimedia.org/62358) (owner: 10Manybubbles) [20:26:38] 3MediaWiki / 3General/Unknown: Merge Poem extension into MediaWiki core - 10https://bugzilla.wikimedia.org/52061#c49 (10James Forrester) (In reply to Kunal Mehta (Legoktm) from comment #48) > (In reply to Tpt from comment #45) > > Yes, you have right with "mw-lines". > > > > I understand your concern with d... [20:28:39] (03PS1) 10Jdlrobson: Remove mediawiki ui buttons on new pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148453 [20:37:08] (03PS1) 10EBernhardson: Get QUnit tests passing in Jenkins [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148454 (https://bugzilla.wikimedia.org/68188) [20:37:15] (03PS1) 10Legoktm: Fix documentation for UserMailer::send() [core] - 10https://gerrit.wikimedia.org/r/148455 [20:37:20] (03CR) 10EBernhardson: [C: 032] Get QUnit tests passing in Jenkins [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148454 (https://bugzilla.wikimedia.org/68188) (owner: 10EBernhardson) [20:38:36] 3MediaWiki / 3General/Unknown: Merge Poem extension into MediaWiki core - 10https://bugzilla.wikimedia.org/52061#c50 (10Nathan Larson) (In reply to James Forrester from comment #49) > I don't particularly mind it being merged into core from an "editing" POV, > but it is "yet another feature" in MediaWiki cor... [20:39:11] (03Merged) 10jenkins-bot: Get QUnit tests passing in Jenkins [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148454 (https://bugzilla.wikimedia.org/68188) (owner: 10EBernhardson) [20:39:19] (03PS2) 10EBernhardson: Wrong messages used in moderation dialogs [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148451 (https://bugzilla.wikimedia.org/67226) [20:39:47] (03PS2) 10Jdlrobson: QA: Fix browser tests on cached anonymous pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148258 [20:40:20] (03CR) 10Gilles: [C: 032] Remove UploadWizardUtil, replace with other things [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146140 (owner: 10MarkTraceur) [20:40:29] (03CR) 10Parent5446: [C: 032] Fix documentation for UserMailer::send() [core] - 10https://gerrit.wikimedia.org/r/148455 (owner: 10Legoktm) [20:40:52] (03Merged) 10jenkins-bot: Remove UploadWizardUtil, replace with other things [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146140 (owner: 10MarkTraceur) [20:42:16] (03PS1) 1001tonythomas: Notify administrators on API failing to parse bounce emails [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/148456 [20:42:21] 3MediaWiki / 3Revision deletion: Give sysops deleterevision rights by default - 10https://bugzilla.wikimedia.org/68298#c3 (10Nathan Larson) (In reply to Vogone from comment #2) > If that was done, wouldn't it make sense to add "deletelogentry" as a > default right as well? It's a closely related permission w... [20:42:50] ^demon|lunch: would it be possible to run a maintenance script from the browser [20:43:35] 3Wikimedia / 3Bugzilla: "(take)" (and perhaps "(edit)") should put the previous assignee in the CC List - 10https://bugzilla.wikimedia.org/62892#c6 (10Andre Klapper) I'm afraid Bugzilla does not allow querying "Assignee was X; then X was added to CC field?" against the same X value. :( (Another small issue... [20:43:42] (03Merged) 10jenkins-bot: Fix documentation for UserMailer::send() [core] - 10https://gerrit.wikimedia.org/r/148455 (owner: 10Legoktm) [20:43:49] (03CR) 1001tonythomas: "Gets this error when processUnHandledBounces() is called on a successful bounce ( for testing ):" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/148456 (owner: 1001tonythomas) [20:45:49] (03PS1) 10EBernhardson: Update Flow extension in wmf/1.24wmf14 [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148458 [20:45:54] (03CR) 10Legoktm: [C: 04-1] "The bug is in BounceHandlerHooks::onVERPAddressGenerate. User::newFromName( $recip[0]->name ); can return false, which needs to be checked" (034 comments) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/148456 (owner: 1001tonythomas) [20:46:57] (03CR) 10BryanDavis: [WIP] Interstitial notification page for renamed users (034 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/148420 (https://bugzilla.wikimedia.org/67995) (owner: 10BryanDavis) [20:49:47] withoutaname: in theory, it could be possible, but currently the maintenance loader explicitly forbids non-cli (see Maintenance::shouldExecute) [20:50:22] There was an extension that used to do that (MaintenanceShell or something) [20:50:38] Maintenance, which implemented SpecialMaintenance [20:51:03] there are two extensions, both are super hacky [20:51:07] im thinking more of config var + extra permission that could do it [20:51:08] 3MediaWiki / 3Templates: Provide a way to transclude a specific revision of a template - 10https://bugzilla.wikimedia.org/68399 (10Helder) 3NEW p:3Unprio s:3enhanc a:3None Copying from https://en.wikipedia.org/w/index.php?diff=617710878&oldid=617699864 which reminded me to request this feature (which... [20:53:05] ebernhardson: actually I tried to run it and it printed an error saying "This script must be run from the command line" [20:53:27] that's probably in Maintenance::setup [20:54:08] (03PS1) 10Jdlrobson: Make Flow use mw-ui-constructive etc rather than flow-ui- [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148462 [20:54:11] (03PS1) 10Jdlrobson: Enable anon tooltips on mobile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148463 [20:54:12] withoutaname: i suppose there are a couple checks, the one in shouldExecute plays around with a backtrace to ensure no functions have been called, only include/require/ [20:54:14] (03PS1) 10Jdlrobson: Enable JavaScript on mobile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148464 [20:54:17] (03PS1) 10Jdlrobson: Remove buttons now cache has cleared. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148465 [20:54:58] (03PS1) 10Spage: List all dependencies of ext.flow.new [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148466 [20:55:14] (03CR) 10jenkins-bot: [V: 04-1] Remove buttons now cache has cleared. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148465 (owner: 10Jdlrobson) [20:55:43] (03CR) 10Jdlrobson: [C: 04-1] "Cache not clear yet" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148465 (owner: 10Jdlrobson) [20:55:46] (03CR) 10Spage: "Nothing's breaking but it seems the right thing to do." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148466 (owner: 10Spage) [20:55:49] (03PS2) 10BryanDavis: labs_vagrant: Use hiera.yaml and set realm [vagrant] - 10https://gerrit.wikimedia.org/r/148315 [20:57:26] (03CR) 10Jdlrobson: [C: 032] List all dependencies of ext.flow.new [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148466 (owner: 10Spage) [20:57:57] (03Merged) 10jenkins-bot: List all dependencies of ext.flow.new [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148466 (owner: 10Spage) [20:57:58] ebernhardson: in Maintenance::setup, the check is done with isset( $_SERVER ) && isset( $_SERVER['REQUEST_METHOD'] ) [20:58:09] would it make more sense to check with PHP_SAPI !== 'cli' [20:59:08] (03PS6) 10Jdlrobson: Repair warning on boards with no header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147649 (owner: 10EBernhardson) [20:59:12] (03CR) 10Jdlrobson: [C: 032] Repair warning on boards with no header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147649 (owner: 10EBernhardson) [20:59:45] (03Merged) 10jenkins-bot: Repair warning on boards with no header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147649 (owner: 10EBernhardson) [21:00:02] (03PS5) 10EBernhardson: Fix error handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/146785 (https://bugzilla.wikimedia.org/68021) (owner: 10Matthias Mullie) [21:00:08] (03CR) 10jenkins-bot: [V: 04-1] Fix error handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/146785 (https://bugzilla.wikimedia.org/68021) (owner: 10Matthias Mullie) [21:00:37] (03CR) 10Jdlrobson: [C: 031] "I don't really understand what this function is used for and where the input comes from so I can't tell if you are doing it right or not, " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148246 (owner: 10EBernhardson) [21:00:46] (03CR) 10EBernhardson: "PS5: Address comments on PS4" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/146785 (https://bugzilla.wikimedia.org/68021) (owner: 10Matthias Mullie) [21:00:51] (03PS3) 10Jdlrobson: QA: Fix browser tests on cached anonymous pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148258 [21:03:37] (03PS8) 10Spage: QA: Browser test for Thank feature in Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117882 (https://bugzilla.wikimedia.org/61930) (owner: 10Bencmq) [21:04:04] (03CR) 10EBernhardson: "The function creates relative titles, as returned from parsoid." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148246 (owner: 10EBernhardson) [21:04:49] (03PS6) 10EBernhardson: Fix error handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/146785 (https://bugzilla.wikimedia.org/68021) (owner: 10Matthias Mullie) [21:04:55] (03PS13) 10Ebe123: Enable the creation of empty pages [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) [21:05:09] (03CR) 10EBernhardson: [C: 032] "PS6: Manual rebase for conflicts in handlebars/compiled/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/146785 (https://bugzilla.wikimedia.org/68021) (owner: 10Matthias Mullie) [21:05:15] (03CR) 10Spage: [C: 032] "PS8 just changed capitalization of "Feature: Thank author of a [f->F]low post". Passes for me, nice!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117882 (https://bugzilla.wikimedia.org/61930) (owner: 10Bencmq) [21:06:16] (03PS4) 10Spage: WIP: QA: Thanking another users post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/146628 (owner: 10Jdlrobson) [21:07:47] (03PS1) 10Withoutaname: Shorten if/else to ternary expressions in WebStart.php [core] - 10https://gerrit.wikimedia.org/r/148503 [21:08:16] (03CR) 10Gilles: Split BitmapHandler into two classes. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/147718 (owner: 10Brian Wolff) [21:09:27] (03CR) 10Gilles: Split BitmapHandler into two classes. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/147718 (owner: 10Brian Wolff) [21:09:54] (03PS8) 10Ebe123: Create preferences to watchlist pages after rollbacking and undoing [core] - 10https://gerrit.wikimedia.org/r/146440 (https://bugzilla.wikimedia.org/4488) [21:10:28] (03CR) 10Brian Wolff: Split BitmapHandler into two classes. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/147718 (owner: 10Brian Wolff) [21:13:02] (03Merged) 10jenkins-bot: Fix error handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/146785 (https://bugzilla.wikimedia.org/68021) (owner: 10Matthias Mullie) [21:13:07] (03Merged) 10jenkins-bot: QA: Browser test for Thank feature in Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/117882 (https://bugzilla.wikimedia.org/61930) (owner: 10Bencmq) [21:13:20] (03CR) 10Parent5446: [C: 031] Shorten if/else to ternary expressions in WebStart.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/148503 (owner: 10Withoutaname) [21:14:24] (03PS1) 10Neilk: Allow Flickr uploads in uploadwizard role [vagrant] - 10https://gerrit.wikimedia.org/r/148505 [21:15:12] (03CR) 10jenkins-bot: [V: 04-1] Allow Flickr uploads in uploadwizard role [vagrant] - 10https://gerrit.wikimedia.org/r/148505 (owner: 10Neilk) [21:24:48] (03PS2) 10Neilk: Allow Flickr uploads in uploadwizard role [vagrant] - 10https://gerrit.wikimedia.org/r/148505 [21:32:35] 3Wikimedia / 3Site requests: Create new user group on Portuguese Wikipedia of good faith new users - 10https://bugzilla.wikimedia.org/68338#c3 (10Teles) I wasn't clear when I said "somehow", but that can't be a problem as it is already discussed. The criteria is subjective most of the times. A new user tha... [21:32:51] 3MediaWiki / 3General/Unknown: Move all four core skins to separate repositories and include them in the tarball - 10https://bugzilla.wikimedia.org/68333 (10Bartosz Dziewoński) [21:32:53] 3MediaWiki / 3Skin and page rendering: Move Vector and MonoBook to separate repositories - 10https://bugzilla.wikimedia.org/68402 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None As per my GSoC project ([[mw:Separating skins from core MediaWiki]]), let's move Vector and MonoBook to separate re... [21:34:01] (03CR) 10Reedy: Fix Wikimedia overrides of core messages (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/137528 (https://bugzilla.wikimedia.org/65514) (owner: 10Mattflaschen) [21:34:27] (03PS3) 10Bartosz Dziewoński: Define fallback skin using $wgFallbackSkin instead of hardcoding Vector [core] - 10https://gerrit.wikimedia.org/r/148424 (https://bugzilla.wikimedia.org/68332) [21:34:29] (03PS2) 10Bartosz Dziewoński: Move Vector's $wg configuration options to Vector.php [core] - 10https://gerrit.wikimedia.org/r/148433 [21:34:31] (03PS1) 10Bartosz Dziewoński: Use a special fallback skin when selected skin is unavailable [core] - 10https://gerrit.wikimedia.org/r/148508 (https://bugzilla.wikimedia.org/68332) [21:34:33] (03PS1) 10Bartosz Dziewoński: Stop always loading MonoBook and Vector [core] - 10https://gerrit.wikimedia.org/r/148509 (https://bugzilla.wikimedia.org/68402) [21:34:48] (03PS1) 10Reedy: Add missing return true from Ica73423cc8342f6d9290f287ddeb35ff59d04d8b [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148510 [21:36:05] 3Wikimedia / 3Site requests: Create new user group on Portuguese Wikipedia of good faith new users - 10https://bugzilla.wikimedia.org/68338#c4 (10Bartosz Dziewoński) Wouldn't it be simpler to identify such users by checking whether they are blocked? ;) [21:36:15] (03CR) 10Bartosz Dziewoński: [C: 04-2] "This will need a healthy dose of announcing widely." [core] - 10https://gerrit.wikimedia.org/r/148509 (https://bugzilla.wikimedia.org/68402) (owner: 10Bartosz Dziewoński) [21:36:17] (03CR) 10Reedy: "Also, this causes the following command to segfault (used in database dumps)" (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/137528 (https://bugzilla.wikimedia.org/65514) (owner: 10Mattflaschen) [21:38:49] (03PS2) 10Reedy: Add missing return true from Ica73423cc8342f6d9290f287ddeb35ff59d04d8b [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148510 [21:38:55] (03CR) 10Reedy: [C: 032] Add missing return true from Ica73423cc8342f6d9290f287ddeb35ff59d04d8b [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148510 (owner: 10Reedy) [21:39:47] Reedy: hooks don't need a return true anymore [21:39:51] since like 1.22 I think [21:40:02] (03Merged) 10jenkins-bot: Add missing return true from Ica73423cc8342f6d9290f287ddeb35ff59d04d8b [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148510 (owner: 10Reedy) [21:40:23] Really? [21:40:24] Meh [21:42:42] (03CR) 10jenkins-bot: [V: 04-1] Stop always loading MonoBook and Vector [core] - 10https://gerrit.wikimedia.org/r/148509 (https://bugzilla.wikimedia.org/68402) (owner: 10Bartosz Dziewoński) [21:43:20] ooooh [21:43:24] 3Unofficial Apps / 3other: chase's test bug - 10https://bugzilla.wikimedia.org/68403 (10Chase) 3NEW p:3Unprio s:3normal a:3Brion Vibber happy holidays! [21:43:26] build failures when you remove vector [21:43:28] how lovely [21:43:37] (03PS1) 10Yuvipanda: Added MobileApp role [vagrant] - 10https://gerrit.wikimedia.org/r/148513 [21:43:50] (by which i mean, who the hell wrote these crappy test) [21:43:54] bd808: ^ merge? trivial [21:44:15] (03PS1) 10Reedy: Swap MessageCache::get closure to global function to fix segfault [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148514 [21:44:39] public function testBug41337() { [21:44:42] @todo give this test a real name explaining what is being tested here [21:45:00] helpful [21:45:36] Reedy: put a wf in front of the function? [21:45:38] (03PS2) 10Reedy: Swap MessageCache::get closure to global function to fix segfault [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148514 [21:45:57] Yeah.. probably should [21:46:38] (03PS3) 10Reedy: Swap MessageCache::get closure to global function to fix segfault [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148514 [21:46:59] legoktm: Want to +2 that? (else I will ;)) [21:47:23] (03CR) 10Legoktm: [C: 032] Swap MessageCache::get closure to global function to fix segfault [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148514 (owner: 10Reedy) [21:47:37] (03Merged) 10jenkins-bot: Swap MessageCache::get closure to global function to fix segfault [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148514 (owner: 10Reedy) [21:47:41] (03CR) 10PleaseStand: "At least this fixes the divide-by-zero bug." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/148442 (https://bugzilla.wikimedia.org/28419) (owner: 10Parent5446) [21:47:49] (03PS1) 10Reedy: Swap MessageCache::get closure to global function to fix segfault [extensions/WikimediaMessages] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/148515 [21:47:58] I wouldn't be surprised if there are more extensions with global closures... [21:47:58] (03PS1) 10Reedy: Swap MessageCache::get closure to global function to fix segfault [extensions/WikimediaMessages] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148516 [21:48:03] There are [21:48:09] But they don't seem to cause a segfault [21:48:29] WikimediaMessages has a handful ;) [21:48:46] (03CR) 10Reedy: [C: 032] Swap MessageCache::get closure to global function to fix segfault [extensions/WikimediaMessages] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/148515 (owner: 10Reedy) [21:48:52] (03Merged) 10jenkins-bot: Swap MessageCache::get closure to global function to fix segfault [extensions/WikimediaMessages] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/148515 (owner: 10Reedy) [21:50:51] (03PS1) 10Reedy: Update WikimediaMessages to 1.24wmf13 HEAD [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/148517 [21:51:08] (03CR) 10Reedy: [C: 032 V: 032] Update WikimediaMessages to 1.24wmf13 HEAD [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/148517 (owner: 10Reedy) [21:52:25] (03CR) 10Legoktm: [Reapply] Simplify thumbnail styling to have consistency with mobile (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133301 (https://bugzilla.wikimedia.org/65160) (owner: 10Jforrester) [21:53:22] (03PS1) 10Physikerwelt: Adjustments to renaming in Math [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/148519 [21:54:14] (03CR) 10Physikerwelt: [C: 032] Adjustments to renaming in Math [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/148519 (owner: 10Physikerwelt) [21:54:37] (03Merged) 10jenkins-bot: Adjustments to renaming in Math [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/148519 (owner: 10Physikerwelt) [21:54:41] (03CR) 10Reedy: [C: 032] Swap MessageCache::get closure to global function to fix segfault [extensions/WikimediaMessages] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148516 (owner: 10Reedy) [21:54:47] (03Merged) 10jenkins-bot: Swap MessageCache::get closure to global function to fix segfault [extensions/WikimediaMessages] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148516 (owner: 10Reedy) [21:55:31] (03PS1) 10Reedy: Update WikimediaMessages to 1.24wmf14 HEAD [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148520 [21:56:01] (03CR) 10Reedy: [C: 032 V: 032] Update WikimediaMessages to 1.24wmf14 HEAD [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148520 (owner: 10Reedy) [21:59:11] global closures? [21:59:48] (03PS1) 10MaxSem: Fixes per CR on github [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/148523 [22:00:33] (03PS1) 10Withoutaname: Remove old maintenance script eval.php [core] - 10https://gerrit.wikimedia.org/r/148524 [22:01:12] (03CR) 10Brian Wolff: [C: 04-1] "I use this literally almost every day" [core] - 10https://gerrit.wikimedia.org/r/148524 (owner: 10Withoutaname) [22:01:44] (03CR) 10EBernhardson: [C: 04-1] "This needs documentation about how to boot mediawiki inside the php native interactive shell. Just starting a shell without fully booting" [core] - 10https://gerrit.wikimedia.org/r/148524 (owner: 10Withoutaname) [22:01:54] (03PS1) 10Catrope: Revert "maintenance: Update comment in the OOjs UI pull through script" [core] - 10https://gerrit.wikimedia.org/r/148525 [22:01:58] (03CR) 10jenkins-bot: [V: 04-1] Remove old maintenance script eval.php [core] - 10https://gerrit.wikimedia.org/r/148524 (owner: 10Withoutaname) [22:02:49] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (9cd400e3d5) [core] - 10https://gerrit.wikimedia.org/r/148526 [22:02:54] (03PS1) 10Yuvipanda: Change infobox background in nightmode per design [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/148527 [22:02:56] legoktm: merge ^? [22:02:57] (03CR) 10Legoktm: [C: 04-2] "Uhh, no. This is extremely useful." [core] - 10https://gerrit.wikimedia.org/r/148524 (owner: 10Withoutaname) [22:03:07] (03CR) 10Reedy: [C: 04-2] "It's widely used on the cluster too" [core] - 10https://gerrit.wikimedia.org/r/148524 (owner: 10Withoutaname) [22:03:24] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.1.0-pre (9cd400e3d5) [core] - 10https://gerrit.wikimedia.org/r/148526 (owner: 10Catrope) [22:03:27] YuviPanda: "/* Same specificity as in less/content/hacks.less */" is that still true? [22:03:34] legoktm: yes [22:03:34] (03CR) 10Jforrester: [C: 032] Revert "maintenance: Update comment in the OOjs UI pull through script" [core] - 10https://gerrit.wikimedia.org/r/148525 (owner: 10Catrope) [22:03:36] (03Abandoned) 10Withoutaname: Remove old maintenance script eval.php [core] - 10https://gerrit.wikimedia.org/r/148524 (owner: 10Withoutaname) [22:03:45] legoktm: I meant specificity in the rule ordering [22:03:51] ah ok [22:03:55] (03CR) 10Legoktm: [C: 032 V: 032] Change infobox background in nightmode per design [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/148527 (owner: 10Yuvipanda) [22:04:03] why doesn't that have jenkins yet...? [22:04:14] lazy [22:04:32] ugh [22:04:58] legoktm: wanna merge https://gerrit.wikimedia.org/r/#/c/148513/? [22:05:00] wait what https://bugzilla.wikimedia.org/show_bug.cgi?id=65841 [22:05:12] maybe jenkins is just lagging? [22:05:17] oops [22:05:43] legoktm: oh wait, maybe it does have them? [22:05:44] (03CR) 10Legoktm: "Typo" (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/148513 (owner: 10Yuvipanda) [22:05:50] it does [22:05:56] jenkins was just behind [22:06:13] oh well [22:06:35] (03PS2) 10Yuvipanda: Added MobileApp role [vagrant] - 10https://gerrit.wikimedia.org/r/148513 [22:06:35] legoktm: :D updated [22:07:07] (03CR) 10Legoktm: [C: 032] Added MobileApp role [vagrant] - 10https://gerrit.wikimedia.org/r/148513 (owner: 10Yuvipanda) [22:07:56] (03Merged) 10jenkins-bot: Added MobileApp role [vagrant] - 10https://gerrit.wikimedia.org/r/148513 (owner: 10Yuvipanda) [22:08:39] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (9cd400e3d5) [core] - 10https://gerrit.wikimedia.org/r/148526 (owner: 10Catrope) [22:08:53] (03CR) 10Nikerabbit: Swap MessageCache::get closure to global function to fix segfault (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148514 (owner: 10Reedy) [22:09:07] Reedy: ^^ [22:09:13] blame legoktm :) [22:09:41] (03Merged) 10jenkins-bot: Revert "maintenance: Update comment in the OOjs UI pull through script" [core] - 10https://gerrit.wikimedia.org/r/148525 (owner: 10Catrope) [22:09:42] Nikerabbit: I think that's reported in [22:09:46] It might not be? [22:10:03] Nikerabbit: I found it referenced in https://gerrit.wikimedia.org/r/#/c/86154/ [22:10:14] Someone says it's there in 5.3.5 with APC [22:10:21] APC being the real issue [22:10:34] "We're experiencing the same problem here at Netlog. Also on production servers when we have some load. Unable to isolate this issue yet. We're running php 5.3.5 and apc 3.1.9. If we disable APC the problem goes away." [22:10:35] 3Wikimedia / 3Site requests: Create new user group on Portuguese Wikipedia of good faith new users - 10https://bugzilla.wikimedia.org/68338#c5 (10Dereckson) 5NEW>3UNCO Furthermore, please remember the proposal is on pt.wikipedia, a major wiki. The proposal has received so far very few participation: - 3... [22:10:51] (03PS1) 10Jdlrobson: Make box-sizing: border-box the default in the Flow world [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148529 [22:10:54] (03PS1) 10Jdlrobson: Add suitable default styles for ul elements in Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148530 [22:11:03] (03PS2) 10Jdlrobson: Hygiene: Make box-sizing: border-box the default in the Flow world [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148529 [22:11:08] Reedy: hmm let me see [22:11:09] (03PS3) 10Jdlrobson: Hygiene: Make box-sizing: border-box the default in the Flow world [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148529 [22:11:11] (03CR) 10EBernhardson: Wrong messages used in moderation dialogs [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148451 (https://bugzilla.wikimedia.org/67226) (owner: 10EBernhardson) [22:11:15] (03PS2) 10Jdlrobson: Hygiene: Add suitable default styles for ul elements in Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148530 [22:11:18] (03CR) 10EBernhardson: [C: 032] Wrong messages used in moderation dialogs [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148451 (https://bugzilla.wikimedia.org/67226) (owner: 10EBernhardson) [22:11:21] (03PS3) 10Jdlrobson: Hygiene: Add suitable default styles for ul elements in Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148530 [22:11:24] 5.3.10 was released Released: 02 February 2012 [22:11:41] and that fix was made after that, bummer I was wrong [22:12:03] (Why is WMF running 2+ year old code is another thing ;) [22:12:14] Ubuntu 12.04! [22:13:33] and that fix has not been mentioned at all in http://php.net/ChangeLog-5.php#5.3.20 [22:13:40] err, ignore the hash [22:15:15] (03CR) 10Nikerabbit: Swap MessageCache::get closure to global function to fix segfault (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148514 (owner: 10Reedy) [22:15:36] (03Merged) 10jenkins-bot: Wrong messages used in moderation dialogs [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148451 (https://bugzilla.wikimedia.org/67226) (owner: 10EBernhardson) [22:16:50] (03PS2) 10EBernhardson: Update Flow extension in wmf/1.24wmf14 [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148458 [22:17:24] (03CR) 10Spage: [C: 032] "Seems legit, beta labs giving 503 right now but I'll try on test2.wikipedia.org." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148258 (owner: 10Jdlrobson) [22:17:54] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This is probably not a good idea. .flow-component can (probably) contain various elements that are *not* styled by Flow (like, say, paragr" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148529 (owner: 10Jdlrobson) [22:18:50] (03Merged) 10jenkins-bot: QA: Fix browser tests on cached anonymous pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148258 (owner: 10Jdlrobson) [22:18:54] (03CR) 10Bartosz Dziewoński: "(This is already a problem on a smaller scale with the blanket overflow-x: hidden; applied to everything, see bug 67833.)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148529 (owner: 10Jdlrobson) [22:19:10] (03CR) 10Jdlrobson: "We use this as default on mobile for some time and haven't hit any issues and we touch a hell of a lot more content than Flow will ever do" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148529 (owner: 10Jdlrobson) [22:20:38] (03CR) 10Jdlrobson: "Also see http://www.paulirish.com/2012/box-sizing-border-box-ftw/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148529 (owner: 10Jdlrobson) [22:20:51] 3MediaWiki / 3General/Unknown: Fatal error: Call to a member function getText() on a non-object in php-1.24wmf14/includes/OutputPage.php on line 1296 - 10https://bugzilla.wikimedia.org/68394#c2 (10Bawolff (Brian Wolff)) For reference, according to http://lists.wikimedia.org/pipermail/glamtools/2014-July/000... [22:22:26] (03CR) 10Bartosz Dziewoński: "Because mobile does not load random styles from everywhere else, and logged-in technical Wikimedians (the people who report bugs for us) g" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148529 (owner: 10Jdlrobson) [22:23:18] (03CR) 10Bartosz Dziewoński: "(I would, however, also oppose that mobile changes if I saw it happen. Another problem is that it makes upstreaming things to MediaWiki co" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148529 (owner: 10Jdlrobson) [22:23:38] (03CR) 10Bsimmers: [C: 04-1] "Looks like you missed the StringBuffer comment here: https://github.com/wikimedia/mediawiki-php-FastStringSearch/commit/9c561e996c60793796" [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/148523 (owner: 10MaxSem) [22:24:33] (03CR) 10Bartosz Dziewoński: "Paul Irish's posts also clearly talk about a case where you control *all* content and *all* styles. You do not when you're a MediaWiki ext" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148529 (owner: 10Jdlrobson) [22:25:11] (03CR) 10EBernhardson: [C: 032] Remove mediawiki ui buttons on new pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148453 (owner: 10Jdlrobson) [22:25:45] (03Merged) 10jenkins-bot: Remove mediawiki ui buttons on new pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148453 (owner: 10Jdlrobson) [22:26:48] (03CR) 10EBernhardson: [C: 04-1] "Changes made to helpers in TempalteHelper.php also need to be applied to flow-handlebars.js (specifically the changes to tooltip helper)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148462 (owner: 10Jdlrobson) [22:28:11] (03CR) 10Jdlrobson: "You're worrying about a non-issue." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148529 (owner: 10Jdlrobson) [22:29:37] (03CR) 10EBernhardson: "additionally, this updates a template without recompiling the templates" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148462 (owner: 10Jdlrobson) [22:30:31] (03CR) 10EBernhardson: [C: 031] Enable anon tooltips on mobile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148463 (owner: 10Jdlrobson) [22:31:37] (03PS2) 10Jdlrobson: Make Flow use mw-ui-constructive etc rather than flow-ui- [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148462 [22:31:46] (03PS1) 10Werdna: Configurable timeouts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148532 [22:32:38] (03PS2) 10Werdna: Rebuild topic title bars on post actions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147346 [22:33:37] 3Wikimedia / 3Bugzilla: chase's test bug - 10https://bugzilla.wikimedia.org/68403 (10Andre Klapper) a:5Brion Vibber>3None [22:34:35] (03PS1) 10Brian Wolff: Fix valid category check during preview form. [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/148533 (https://bugzilla.wikimedia.org/68394) [22:39:18] (03PS2) 10MaxSem: Fixes per CR on github [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/148523 [22:39:20] (03PS1) 10MaxSem: Revert "Derive FastStringSearchResource from ResourceData, not SweepableResourceData" [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/148534 [22:41:35] (03CR) 10EBernhardson: [C: 032] "It appears the template isn't recompiling because a48fc2a82b05e9c6c5bef116d16d4df8d95aa37a has the compiled template mw-ui-progressive, wh" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148462 (owner: 10Jdlrobson) [22:42:29] (03Merged) 10jenkins-bot: Make Flow use mw-ui-constructive etc rather than flow-ui- [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148462 (owner: 10Jdlrobson) [22:43:01] (03PS1) 10Physikerwelt: Fix: id-attribute [extensions/Math] - 10https://gerrit.wikimedia.org/r/148535 [22:45:01] (03PS3) 10Jdlrobson: Hide load more button with JavaScript when infinite scroll supports [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145470 [22:45:07] (03CR) 10jenkins-bot: [V: 04-1] Hide load more button with JavaScript when infinite scroll supports [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145470 (owner: 10Jdlrobson) [22:46:11] (03CR) 10EBernhardson: [C: 04-1] "I thought returning the full topic api was so we can do a full topic re-render? This still just renders the post and updates the titlebar" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147346 (owner: 10Werdna) [22:47:03] (03PS4) 10Jdlrobson: Hide load more button with JavaScript when infinite scroll supports [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145470 [22:47:32] (03PS1) 10Jdlrobson: Hygiene: Fix foo.diff check in failure. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148536 [22:49:05] (03PS8) 10Jdlrobson: WIP: New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [22:49:31] (03PS3) 10Jdlrobson: Add tooltip for watching boards. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148294 (owner: 10Werdna) [22:49:37] (03CR) 10jenkins-bot: [V: 04-1] WIP: New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [22:50:05] (03CR) 10jenkins-bot: [V: 04-1] Add tooltip for watching boards. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148294 (owner: 10Werdna) [22:51:44] (03CR) 10Jdlrobson: [C: 04-1] "weak -1 - we probably need to have a longer chat about the right way to do this." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148294 (owner: 10Werdna) [22:52:11] (03CR) 10Jdlrobson: "Commit message seems to suggest this is a WIP? Is that true?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [22:53:55] (03CR) 10Jdlrobson: "I think the watch code needs a rewrite personally, this just adds even more complexity to it." [core] - 10https://gerrit.wikimedia.org/r/148291 (owner: 10Werdna) [22:54:21] (03PS2) 10EBernhardson: Enable anon tooltips on mobile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148463 (owner: 10Jdlrobson) [22:54:34] (03CR) 10EBernhardson: [C: 032] Enable anon tooltips on mobile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148463 (owner: 10Jdlrobson) [22:55:08] (03Merged) 10jenkins-bot: Enable anon tooltips on mobile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148463 (owner: 10Jdlrobson) [22:55:59] (03CR) 10Isarra: "The agora theme isn't compatible with most skins, with Minerva being the only one I know of where it DOES fit. Having it be the thing for " [core] - 10https://gerrit.wikimedia.org/r/148305 (owner: 10Bartosz Dziewoński) [22:58:35] (03CR) 10Bsimmers: Fixes per CR on github (031 comment) [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/148523 (owner: 10MaxSem) [22:58:42] (03CR) 10Isarra: "How DO you test these? I've been trying to figure this out for awhile now." [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/148409 (https://bugzilla.wikimedia.org/55640) (owner: 10Jack Phoenix) [23:02:03] (03PS3) 10MaxSem: Fixes per CR on github [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/148523 [23:02:35] (03CR) 10Jdlrobson: "I'd check with @cmcmahon first before merging - there might already be an existing variable.." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148532 (owner: 10Werdna) [23:02:44] (03PS2) 10Jdlrobson: QA: Configurable timeouts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148532 (owner: 10Werdna) [23:03:39] (03PS4) 10MaxSem: Fixes per CR on github [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/148523 [23:04:48] (03PS2) 10EBernhardson: Enable JavaScript on mobile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148464 (owner: 10Jdlrobson) [23:05:52] (03CR) 10Ejegg: [C: 032] "Oh what a tangled web we weave..." [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/148335 (owner: 10Awight) [23:08:04] (03CR) 10EBernhardson: [C: 032] Update Flow extension in wmf/1.24wmf14 [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148458 (owner: 10EBernhardson) [23:12:56] (03CR) 10Cmcmahon: "I don't mind doing this locally, but I'd be concerned that setting these values high points to a real performance problem being neglected" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148532 (owner: 10Werdna) [23:13:12] (03Merged) 10jenkins-bot: Update Flow extension in wmf/1.24wmf14 [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148458 (owner: 10EBernhardson) [23:18:16] (03PS6) 10Robmoen: Make profile icon gender neutral and remove from login link [core] - 10https://gerrit.wikimedia.org/r/146979 (https://bugzilla.wikimedia.org/41484) [23:20:05] 3Wikimedia / 3General/Unknown: url-downloader.wikimedia.org proxy cannot access *.wmflabs.org - 10https://bugzilla.wikimedia.org/68264 (10jeremyb) [23:20:42] (03PS9) 10Werdna: WIP: New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 [23:21:38] (03CR) 10jenkins-bot: [V: 04-1] WIP: New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [23:23:10] (03CR) 10Werdna: "I'm virtualising on a 2011 MacBook Air, doing lots of things in the background, and I can't run unit tests consistently because it takes l" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148532 (owner: 10Werdna) [23:24:35] (03CR) 10EBernhardson: [C: 032] Enable JavaScript on mobile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148464 (owner: 10Jdlrobson) [23:25:07] (03Merged) 10jenkins-bot: Enable JavaScript on mobile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148464 (owner: 10Jdlrobson) [23:27:38] Krinkle|detached: has this been fixed yet? https://bugzilla.wikimedia.org/show_bug.cgi?id=40362 [23:28:09] (03CR) 10Cmcmahon: [C: 031] "Thanks Werdna that makes sense. +1 from me." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148532 (owner: 10Werdna) [23:31:53] (03PS1) 10EBernhardson: Add Echo dependency to Flow phpunit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/148543 [23:32:12] (03CR) 10Swalling: [C: 031] "Reviewed with MSyed locally." [core] - 10https://gerrit.wikimedia.org/r/146979 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [23:33:26] 3MediaWiki / 3Maintenance scripts: Remove Wikimedia specific stuff from Maintenance/doMaintenance - 10https://bugzilla.wikimedia.org/26140#c1 (10TeleComNasSprVen) 5NEW>3RESO/FIX I think this was fixed recently. [23:34:07] (03PS10) 10Jamesmontalvo3: Add file approval and fine-tuned permissions; bump to v1.0 [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 [23:34:53] (03CR) 10Jamesmontalvo3: "i18n updated as requested." [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [23:35:36] 3Wikimedia / 3Site requests: Create new user group on Portuguese Wikipedia of good faith new users - 10https://bugzilla.wikimedia.org/68338#c6 (10Teles) (In reply to Bartosz Dziewoński from comment #4) > Wouldn't it be simpler to identify such users by checking whether they are > blocked? ;) I am sorry for... [23:36:18] (03PS10) 10EBernhardson: WIP: New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [23:36:57] (03CR) 10Werdna: [C: 032] Add Echo dependency to Flow phpunit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/148543 (owner: 10EBernhardson) [23:37:24] (03Merged) 10jenkins-bot: Add Echo dependency to Flow phpunit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/148543 (owner: 10EBernhardson) [23:37:34] (03CR) 10jenkins-bot: [V: 04-1] WIP: New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [23:38:05] (03PS11) 10Werdna: WIP: New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 [23:38:20] 3MediaWiki extensions / 3Cite: Cite: Use of #tag:references with a group causes a footnote numbering issue - 10https://bugzilla.wikimedia.org/46140#c4 (10Gadget850) As I suspected, #tag:references is involved. This example triggers the issue: 12 (03CR) 10jenkins-bot: [V: 04-1] WIP: New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [23:40:35] (03CR) 10Aaron Schulz: [C: 032] Cleanup: normalize annotations, rm unused var [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148225 (owner: 10MaxSem) [23:40:38] (03Merged) 10jenkins-bot: Cleanup: normalize annotations, rm unused var [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148225 (owner: 10MaxSem) [23:47:20] (03PS12) 10Werdna: WIP: New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 [23:49:37] (03CR) 10Werdna: "\o/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [23:49:41] (03PS1) 10Isarra: Restore content text contrast [core] - 10https://gerrit.wikimedia.org/r/148548 (https://bugzilla.wikimedia.org/66021) [23:50:56] (03PS1) 10Catrope: Update messages list for oojs-ui [core] - 10https://gerrit.wikimedia.org/r/148550 (https://bugzilla.wikimedia.org/68327) [23:51:30] (03PS1) 10JGonera: Make mobilefrontend role depend on mantle role [vagrant] - 10https://gerrit.wikimedia.org/r/148551 [23:55:09] (03CR) 10Werdna: Add tooltip for watching boards. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148294 (owner: 10Werdna)