[00:02:35] (03PS12) 10Jack Phoenix: New class for parsing MediaWiki:Sidebar-like messages into modern, nested navigation menus. [core] - 10https://gerrit.wikimedia.org/r/108045 [00:07:03] (03CR) 10jenkins-bot: [V: 04-1] New class for parsing MediaWiki:Sidebar-like messages into modern, nested navigation menus. [core] - 10https://gerrit.wikimedia.org/r/108045 (owner: 10Jack Phoenix) [00:11:37] (03CR) 10BryanDavis: "I tested this using this script to rebuild a VM multiple times with a majority of extensions that install packages enabled:" [vagrant] - 10https://gerrit.wikimedia.org/r/147883 (owner: 10BryanDavis) [00:15:53] (03CR) 10Chad: "Why do we care about PHP4? 1.24 is already shaping up to be a very breaking release...let's remove this PHP4 compat once and for all." [core] - 10https://gerrit.wikimedia.org/r/147881 (owner: 10Withoutaname) [00:19:28] (03CR) 10Ori.livneh: Configure apt to ignore recommended packages (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/147883 (owner: 10BryanDavis) [00:30:20] 3MediaWiki extensions / 3CentralAuth: Logging out on a different device logs me out everywhere else - 10https://bugzilla.wikimedia.org/49890#c19 (10MZMcBride) (In reply to Tim Starling from comment #18) > I am fine with the idea of making logout local again, but I think a nice > additional feature would be t... [00:51:52] (03PS3) 10BryanDavis: Configure apt to ignore recommended packages [vagrant] - 10https://gerrit.wikimedia.org/r/147883 [00:55:26] (03CR) 10Tim Starling: "My main concern is that by not forcibly closing the pipes when the process terminates, we will be changing the semantics with respect to s" [core] - 10https://gerrit.wikimedia.org/r/147635 (https://bugzilla.wikimedia.org/67870) (owner: 10MaxSem) [00:59:07] (03CR) 10Ori.livneh: [C: 032] "awesome" [vagrant] - 10https://gerrit.wikimedia.org/r/147883 (owner: 10BryanDavis) [00:59:12] (03Merged) 10jenkins-bot: Configure apt to ignore recommended packages [vagrant] - 10https://gerrit.wikimedia.org/r/147883 (owner: 10BryanDavis) [01:00:46] (03PS2) 10Ori.livneh: cirrussearch: Require update_database for build_search_index [vagrant] - 10https://gerrit.wikimedia.org/r/147999 (owner: 10BryanDavis) [01:13:08] (03CR) 10TTO: "I was really waiting for some more advice from cscott on how to proceed with this. There's also an open question from February to the VE t" [core] - 10https://gerrit.wikimedia.org/r/106861 (https://bugzilla.wikimedia.org/52061) (owner: 10TTO) [01:14:30] (03PS3) 10BryanDavis: Remove Package[mediawiki-math] from role::math [vagrant] - 10https://gerrit.wikimedia.org/r/147874 (https://bugzilla.wikimedia.org/66807) [01:14:49] (03CR) 10TTO: "Yep, just need to push my changes for review." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102076 (https://bugzilla.wikimedia.org/57727) (owner: 10TTO) [01:18:57] (03PS7) 10TTO: Replace hidesig module with a more robust implementation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102076 (https://bugzilla.wikimedia.org/57727) [01:20:34] 3MediaWiki-Vagrant: Provisioning the math role results in an "unmet dependencies" dpkg error - 10https://bugzilla.wikimedia.org/66807#c8 (10Bryan Davis) (In reply to physikerwelt from comment #7) > I think that should be synchronized with the math packages that should be > used in production (for the PNG rende... [01:29:46] (03CR) 10TTO: "I think discussion in project space is more of a WMF thing, but I'm open to being proved wrong. For now I'm leaving ExtraDiscussionNamespa" [core] - 10https://gerrit.wikimedia.org/r/87649 (https://bugzilla.wikimedia.org/5645) (owner: 10TTO) [01:33:05] 3Wikimedia / 3OTRS: Provide/enable a web service API for OTRS - 10https://bugzilla.wikimedia.org/28976#c17 (10Ryan (Rjd0060)) I see this may be possible with an add-on released by OTRS. Information available at http://www.otrs.com/feature-add-on/otrs-generic-interface-rest/ [01:36:33] (03PS13) 10TTO: Hide edit toolbar Signature button in content namespaces by default [core] - 10https://gerrit.wikimedia.org/r/87649 (https://bugzilla.wikimedia.org/5645) [01:37:05] 3Wikimedia / 3General/Unknown: Malayalam Wiki Projects [Tracking] - 10https://bugzilla.wikimedia.org/56295 (10praveenp) [01:43:39] (03CR) 10Physikerwelt: "I think I don't really understand how package works. So feel free to ignore my comments if you think they are stupid" (033 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/147874 (https://bugzilla.wikimedia.org/66807) (owner: 10BryanDavis) [01:45:38] physikerwelt: Is the compile only dependent on the code in the Math extension? [01:48:38] (03CR) 10TTO: "Hang on a minute, bug 68301 seems unrelated. Did you mean something else?" [core] - 10https://gerrit.wikimedia.org/r/87649 (https://bugzilla.wikimedia.org/5645) (owner: 10TTO) [01:51:02] (03CR) 10BryanDavis: Remove Package[mediawiki-math] from role::math (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/147874 (https://bugzilla.wikimedia.org/66807) (owner: 10BryanDavis) [01:54:47] (03CR) 10Yaron Koren: "That seems doubtful to me - especially since the non-global variable would just be copied from the global one. Can't you just use the orig" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [02:06:27] (03CR) 10Physikerwelt: Remove Package[mediawiki-math] from role::math (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/147874 (https://bugzilla.wikimedia.org/66807) (owner: 10BryanDavis) [02:22:19] 3MediaWiki / 3Export/Import: Export specified revisions of a page - 10https://bugzilla.wikimedia.org/4837#c24 (10Étienne Beaulé) (In reply to Andre Klapper from comment #23) > Does this depend on bug 38669 (API export action does not support exporting > specific revisions) or is that unrelated? It seems to... [02:37:40] (03PS4) 10TTO: No interlanguage links after local interwiki prefixes [core] - 10https://gerrit.wikimedia.org/r/146708 (https://bugzilla.wikimedia.org/68085) [02:42:49] 3MediaWiki / 3Parser: Interwikis gets doubled decoded - 10https://bugzilla.wikimedia.org/32926#c5 (10This, that and the other) In SkinTemplate#getLanguages, Title::newFromText is called on a string that is the result of calling Title#getFullText on a Title object that was itself created using Title::newFromT... [02:51:04] 3MediaWiki extensions / 3GlobalCssJs: Global JS module version not updating properly - 10https://bugzilla.wikimedia.org/62602#c22 (10MZMcBride) (In reply to Gerrit Notification Bot from comment #18) > Change 141284 had a related patch set uploaded by Legoktm: > Use new OutputPageScriptsForBottomQueue hook >... [03:01:11] (03CR) 10SG: "I will, when it's ready to be there. The solution for fixing a bug introduced by another patch is not to put it in Core." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/146819 (owner: 10SG) [03:02:39] (03CR) 10SG: "^^" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145331 (owner: 10SG) [03:12:39] (03CR) 10Jamesmontalvo3: [C: 031] "You may be right. Either way, that's speculation for the future, and getPermissions() is still useful for filling in the defaults." [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [03:14:20] (03PS13) 10Jack Phoenix: New class for parsing MediaWiki:Sidebar-like messages into modern, nested navigation menus. [core] - 10https://gerrit.wikimedia.org/r/108045 [03:18:34] (03CR) 10jenkins-bot: [V: 04-1] New class for parsing MediaWiki:Sidebar-like messages into modern, nested navigation menus. [core] - 10https://gerrit.wikimedia.org/r/108045 (owner: 10Jack Phoenix) [03:24:49] (03CR) 10PleaseStand: "> Why do we care about PHP4? 1.24 is already shaping up to be a very breaking release...let's remove this PHP4 compat once and for all." [core] - 10https://gerrit.wikimedia.org/r/147881 (owner: 10Withoutaname) [03:27:04] 3Wikimedia / 3General/Unknown: nds.wiktionary.org Scripterror by moduls timerunout - 10https://bugzilla.wikimedia.org/68304#c2 (10Joachim Mos) 5RESO/WON>3VERI @Marius Hoch: We are a Wiktionary, no Wikipedia, translation is important, what shall we do, write a Head-line for the translationtable: Sorry... [03:33:48] (03PS1) 10Gnosygnu: v1.7.3.1 [xowa] - 10https://gerrit.wikimedia.org/r/148008 [03:37:28] (03CR) 10Gnosygnu: [C: 032 V: 032] "changes for v1.7.3.1" [xowa] - 10https://gerrit.wikimedia.org/r/148008 (owner: 10Gnosygnu) [03:41:33] (03PS2) 10Ori.livneh: Fix roles::proofreadpage to use roles::cite [vagrant] - 10https://gerrit.wikimedia.org/r/147998 (owner: 10BryanDavis) [03:41:49] (03CR) 10Ori.livneh: [C: 032] Fix roles::proofreadpage to use roles::cite [vagrant] - 10https://gerrit.wikimedia.org/r/147998 (owner: 10BryanDavis) [03:41:54] (03Merged) 10jenkins-bot: Fix roles::proofreadpage to use roles::cite [vagrant] - 10https://gerrit.wikimedia.org/r/147998 (owner: 10BryanDavis) [03:43:37] (03PS2) 1020after4: Show the wiki account uri on legalpad signature list view. [phabricator/phabricator] - 10https://gerrit.wikimedia.org/r/147723 [03:46:59] (03CR) 1020after4: "Now we have a better implementation:" [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/144620 (owner: 1020after4) [03:47:34] (03Abandoned) 1020after4: This enforces the security policy on maniphest tasks when they are added to a "special" project, which is currently hard-coded. [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/144620 (owner: 1020after4) [03:57:08] (03PS4) 10Bsitu: [WIP]Replace EchoBackend with mappers and gateway [extensions/Echo] - 10https://gerrit.wikimedia.org/r/147369 [03:59:10] (03PS4) 10BryanDavis: Remove Package[mediawiki-math] from role::math [vagrant] - 10https://gerrit.wikimedia.org/r/147874 (https://bugzilla.wikimedia.org/66807) [04:00:21] (03PS1) 10Bsitu: Formatter Fix for related Echo change [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148011 [04:09:35] (03CR) 10MZMcBride: Fix race condition in wfShellExec() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/147635 (https://bugzilla.wikimedia.org/67870) (owner: 10MaxSem) [04:21:08] (03PS2) 10Deepali: Allow users to add links to the metadata [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/147725 (https://bugzilla.wikimedia.org/52816) [04:26:51] 3Wikimedia / 3Site requests: Category collation for Estonian projects - 10https://bugzilla.wikimedia.org/54168#c8 (10Tim Starling) I see there is an upstream report for this: It was opened on the same day as this bug, with a very similar description, I assume by t... [04:28:13] (03CR) 10Krinkle: [C: 032] Remove deprecated Title::userCanRead() [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/147844 (owner: 10Withoutaname) [04:28:21] (03CR) 10Krinkle: [C: 032] Remove deprecated Title::userCanRead() [extensions/SlimboxThumbs] - 10https://gerrit.wikimedia.org/r/147846 (owner: 10Withoutaname) [04:28:33] (03CR) 10Krinkle: [C: 032] Remove deprecated Title::userCanRead() [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/147848 (owner: 10Withoutaname) [04:31:30] thanks Krinkle [04:31:38] do some of them also need verification [04:31:45] I know they dont have jenkins, just giving it a few minutes [04:31:55] So I know afterwards which do and which don't [04:32:05] and got enough other stuff to do meanwhile :) [04:32:32] (03CR) 10Krinkle: [C: 031] Remove check for wikimedia-mode file, which no longer exists [core] - 10https://gerrit.wikimedia.org/r/147879 (owner: 10Withoutaname) [04:32:50] (03CR) 10Krinkle: [V: 032] Remove deprecated Title::userCanRead() [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/147848 (owner: 10Withoutaname) [04:32:53] (03CR) 10Krinkle: [V: 032] Remove deprecated Title::userCanRead() [extensions/SlimboxThumbs] - 10https://gerrit.wikimedia.org/r/147846 (owner: 10Withoutaname) [04:32:57] (03CR) 10Krinkle: [V: 032] Remove deprecated Title::userCanRead() [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/147844 (owner: 10Withoutaname) [04:35:51] (03PS2) 10Tim Starling: Make SELECT queries against slaves in updateCollation.php [core] - 10https://gerrit.wikimedia.org/r/106162 (https://bugzilla.wikimedia.org/56041) (owner: 10Reedy) [04:38:15] (03CR) 10Greg Grossmeier: "Obvious question: are the two new tables *required* by this code, or is the code able to deal with them not being there?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/129974 (https://bugzilla.wikimedia.org/20202) (owner: 10TheDJ) [04:42:18] (03CR) 10Greg Grossmeier: "Only replying to:" [extensions/Math] - 10https://gerrit.wikimedia.org/r/144939 (https://bugzilla.wikimedia.org/20202) (owner: 10Physikerwelt) [04:46:03] (03PS3) 10Ori.livneh: Fix race condition in wfShellExec() [core] - 10https://gerrit.wikimedia.org/r/147635 (https://bugzilla.wikimedia.org/67870) (owner: 10MaxSem) [04:46:39] (03PS1) 10PleaseStand: Remove Fallback::iconv() [core] - 10https://gerrit.wikimedia.org/r/148012 [04:47:59] withoutaname: There's one more use, and a comment [04:47:59] https://github.com/search?q=userCanRead%28%29+%40wikimedia&type=Code [04:48:07] SemanticForms / BlueSpiceFoundation [04:48:20] Wanna do those too? [04:48:44] Krinkle: https://gerrit.wikimedia.org/r/#/c/146722/ [04:49:17] I looked at your dashboard but didn't see it [04:49:19] ah, on the next page [04:49:39] (03PS17) 10Brion VIBBER: Work in progress: early testing of integration with ogv.js media player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) [04:51:12] (03CR) 10Brion VIBBER: "PS17 updates ogv.js/ogv.swf to d48abb08e1 which fixes Flash initialization detection so it doesn't time out aggressively and fail if the ." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [04:53:09] (03CR) 10Krinkle: [C: 032] Remove deprecated HistoryPage class [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/147855 (owner: 10Withoutaname) [04:53:11] (03Merged) 10jenkins-bot: Remove deprecated HistoryPage class [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/147855 (owner: 10Withoutaname) [04:54:42] (03PS5) 10Krinkle: Remove deprecated HistoryPage class [core] - 10https://gerrit.wikimedia.org/r/147053 (owner: 10Withoutaname) [04:54:46] (03CR) 10Krinkle: [C: 032] Remove deprecated HistoryPage class [core] - 10https://gerrit.wikimedia.org/r/147053 (owner: 10Withoutaname) [04:55:42] (03PS1) 10Luis Felipe Schenone: Wrapped the brackets of the collapse buttons with spans [core] - 10https://gerrit.wikimedia.org/r/148013 [04:59:32] (03Merged) 10jenkins-bot: Remove deprecated HistoryPage class [core] - 10https://gerrit.wikimedia.org/r/147053 (owner: 10Withoutaname) [05:02:09] (03CR) 10Tim Starling: [C: 032] Collation: Workaround for incorrect collation of Estonian [core] - 10https://gerrit.wikimedia.org/r/147980 (https://bugzilla.wikimedia.org/54168) (owner: 10Bartosz Dziewoński) [05:03:45] (03PS1) 10BryanDavis: Enforce order of Apt changing files without comparison [vagrant] - 10https://gerrit.wikimedia.org/r/148015 [05:05:52] (03Merged) 10jenkins-bot: Collation: Workaround for incorrect collation of Estonian [core] - 10https://gerrit.wikimedia.org/r/147980 (https://bugzilla.wikimedia.org/54168) (owner: 10Bartosz Dziewoński) [05:06:12] (03CR) 10BryanDavis: Enforce order of Apt changing files without comparison (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/148015 (owner: 10BryanDavis) [05:12:52] Krinkle: For RawPage do you want me to also modify extensions/CSS? [05:14:00] withoutaname: sure, why not :) [05:14:20] (03CR) 10Brian Wolff: "If its still possible to compile php without iconv, and the maintinance burden of the fallback is minimal, im not sure it makes sense to r" [core] - 10https://gerrit.wikimedia.org/r/148012 (owner: 10PleaseStand) [05:14:46] withoutaname: guess you could update the variable name as well, to match hooks.txt's signature [05:14:52] https://www.mediawiki.org/wiki/Manual:Hooks/RawPageViewBeforeOutput [05:14:58] Wow, that's an old extension [05:27:49] 3MediaWiki / 3Skin and page rendering: Consolidate personal portlet links into collapsed control or dropdown - 10https://bugzilla.wikimedia.org/44448 (10John Mark Vandenberg) [05:31:10] (03CR) 10Yaron Koren: "I added in a few inline comments. Also, please do consider running stylize.php." (037 comments) [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [05:36:52] 3MediaWiki extensions / 3VectorBeta: Display bug in CPB on Firefox 5.0 - 10https://bugzilla.wikimedia.org/68310 (10John Mark Vandenberg) 3NEW p:3Unprio s:3normal a:3None Created attachment 15989 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15989&action=edit Screenshot I see the attached wa... [05:37:49] 3MediaWiki extensions / 3VectorBeta: Display bug in CPB on Firefox 5.0 - 10https://bugzilla.wikimedia.org/68310 (10John Mark Vandenberg) [05:38:04] 3MediaWiki / 3Skin and page rendering: Consolidate personal portlet links into collapsed control or dropdown - 10https://bugzilla.wikimedia.org/44448 (10John Mark Vandenberg) [05:44:20] 3MediaWiki extensions / 3MirrorTools: [MirrorTools] Implement capability for mirroring all revisions that occur on the remote wiki by accepting revisions pushed from a bot - 10https://bugzilla.wikimedia.org/60093 (10Nathan Larson) 5NEW>3RESO/FIX [05:51:22] 3MediaWiki extensions / 3MirrorTools: Add mirrormove module to MirrorTools - 10https://bugzilla.wikimedia.org/68311 (10Nathan Larson) 3NEW p:3Unprio s:3normal a:3None Add mirrormove module to MirrorTools. [05:51:36] 3MediaWiki extensions / 3MirrorTools: Add mirrormove module to MirrorTools - 10https://bugzilla.wikimedia.org/68311 (10Nathan Larson) p:5Unprio>3Normal a:3Nathan Larson [05:52:35] 3MediaWiki extensions / 3[other]: [MirrorTools] Should mirror all revisions and log actions that occur on the remote wiki - 10https://bugzilla.wikimedia.org/59618 (10Nathan Larson) [05:52:35] 3MediaWiki extensions / 3MirrorTools: Add mirrormove module to MirrorTools - 10https://bugzilla.wikimedia.org/68311 (10Nathan Larson) [05:55:42] (03CR) 10Raimond Spekking: [C: 032 V: 032] i18n: "Wiki" should be lower case [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148000 (owner: 10Shirayuki) [05:59:11] (03PS6) 10Withoutaname: Remove deprecated RawPage class [core] - 10https://gerrit.wikimedia.org/r/147052 [06:00:21] (03PS4) 10Withoutaname: Remove deprecated Title::userCanRead() [core] - 10https://gerrit.wikimedia.org/r/146725 [06:07:11] (03PS1) 10Withoutaname: Correct reference to userCan hook [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/148019 [06:07:37] Krinkle: did the BlueSpiceFoundation one :) [06:13:17] (03CR) 10Robert Vogel: [C: 031 V: 031] Correct reference to userCan hook [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/148019 (owner: 10Withoutaname) [06:13:42] (03PS1) 10Withoutaname: Remove references to deprecated RawPage class and move to RawAction [extensions/CSS] - 10https://gerrit.wikimedia.org/r/148020 [06:38:07] 3MediaWiki extensions / 3OAuth: OAuth: Grant "High-volume editing" is confusing (does not provide "edit" right) - 10https://bugzilla.wikimedia.org/68312 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None When an app asked for an authentication via Wikipedia for "High-volume editing" the first response is s... [06:38:20] 3MediaWiki extensions / 3OAuth: OAuth: Grant "High-volume editing" is confusing (does not provide "edit" right) - 10https://bugzilla.wikimedia.org/68312 (10Krinkle) p:5Unprio>3High [06:49:34] 3MediaWiki extensions / 3Scribunto: HHVM crash loading San Francisco page - 10https://bugzilla.wikimedia.org/68196#c7 (10Tim Starling) It is asserting while checking local number 7 of PPFrame_Hash::expand(). [07:06:51] (03PS6) 10Gerrit Patch Uploader: Enable uploading of spreadsheet files [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/147513 [07:06:53] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/147513 (owner: 10Gerrit Patch Uploader) [07:09:20] 3MediaWiki / 3General/Unknown: U+200B ZERO WIDTH SPACE allowed in page titles - 10https://bugzilla.wikimedia.org/27446 (10John Mark Vandenberg) [07:10:13] (03CR) 10Foxtrott: "Reworked the casing of some messages. The file type is now consistently 'spreadsheet' (lc)." [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/147513 (owner: 10Gerrit Patch Uploader) [07:24:16] (03PS5) 10Prtksxna: renderer: Use NavigationPopups settings where available [extensions/Popups] - 10https://gerrit.wikimedia.org/r/137897 (https://bugzilla.wikimedia.org/64234) [07:26:22] (03CR) 10Prtksxna: "> a comment would be nice that these two variables are not meant as an "official" way to change the timings." (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/137897 (https://bugzilla.wikimedia.org/64234) (owner: 10Prtksxna) [07:38:56] (03PS1) 10TTO: Turn stubthreshold back into a combo box [core] - 10https://gerrit.wikimedia.org/r/148022 [07:43:19] (03PS7) 10Wctaiwan: Add ability to add pages to spamlist view [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/146705 [07:50:07] 3MediaWiki / 3User preferences: stubthreshold insanely invasive on Special:Preferences#mw-prefsection-rendering - 10https://bugzilla.wikimedia.org/68313 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Created attachment 15990 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15990&action=edit Meta-Wik... [07:51:22] (03CR) 10Legoktm: [C: 04-1] Add ability to add pages to spamlist view (031 comment) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/146705 (owner: 10Wctaiwan) [07:52:43] (03PS2) 10Nemo bis: Turn stubthreshold back into a combo box [core] - 10https://gerrit.wikimedia.org/r/148022 (https://bugzilla.wikimedia.org/68313) (owner: 10TTO) [07:58:40] (03CR) 10Nemo bis: [C: 031] "Thanks; I attached a screenshot on bugzilla for reference in case someone doesn't believe to that "insane"." [core] - 10https://gerrit.wikimedia.org/r/148022 (https://bugzilla.wikimedia.org/68313) (owner: 10TTO) [08:00:37] (03PS1) 10Swidmann: Restored compatiblity to mw 1.22 [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/148023 [08:06:49] (03PS8) 10Wctaiwan: Add ability to add pages to spamlist view [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/146705 [08:09:02] (03CR) 10Smuggli: [C: 032 V: 032] Correct reference to userCan hook [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/148019 (owner: 10Withoutaname) [08:12:02] legoktm: could you perhaps do https://gerrit.wikimedia.org/r/#/c/146725/ [08:16:13] (03CR) 10Legoktm: [C: 032] Add ability to add pages to spamlist view [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/146705 (owner: 10Wctaiwan) [08:16:21] (03Merged) 10jenkins-bot: Add ability to add pages to spamlist view [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/146705 (owner: 10Wctaiwan) [08:16:25] withoutaname: looking [08:17:42] (03PS1) 10Withoutaname: Rename rawActionViewBeforeOutput hook to rawPageViewBeforeOutput [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/148025 [08:17:43] thanks, we just recently did a clear of all of the uses from extensions, hopefully [08:25:46] (03CR) 10Legoktm: [C: 032] Remove deprecated Title::userCanRead() [core] - 10https://gerrit.wikimedia.org/r/146725 (owner: 10Withoutaname) [08:29:02] (03Merged) 10jenkins-bot: Remove deprecated Title::userCanRead() [core] - 10https://gerrit.wikimedia.org/r/146725 (owner: 10Withoutaname) [08:29:09] (03CR) 10Legoktm: Enforce type hinting for setTitle() in IContextSource subclasses (031 comment) [core] - 10https://gerrit.wikimedia.org/r/144647 (owner: 10Withoutaname) [08:29:19] withoutaname: ^ weird bug [08:29:30] (03CR) 10Nikerabbit: [C: 04-1] Bidi-isolate extension version on Special:Version (031 comment) [core] - 10https://gerrit.wikimedia.org/r/147733 (owner: 10Amire80) [08:29:49] (03CR) 10Legoktm: "Yeah, I think reverting this probably makes sense." [core] - 10https://gerrit.wikimedia.org/r/144130 (owner: 10Withoutaname) [08:30:46] legoktm: fix AbuseFilter I guess? [08:30:54] I can take a look at AF [08:30:54] yeah, hoo has a patch. [08:31:01] I just need to find it in my open tabs [08:31:10] (03PS1) 10Legoktm: Revert "Generalize Installer::showStatusMessage()" [core] - 10https://gerrit.wikimedia.org/r/148026 [08:32:48] (03CR) 10Legoktm: [C: 032] "Caused by Iecd8535b04072823a6f4efe33697148f4d20118e probably." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/147986 (owner: 10Hoo man) [08:32:56] (03Merged) 10jenkins-bot: Don't try to pass non Title objects into RequestContext::setTitle [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/147986 (owner: 10Hoo man) [08:34:08] (03PS1) 10Legoktm: Don't try to pass non Title objects into RequestContext::setTitle [extensions/AbuseFilter] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148027 [08:34:51] withoutaname: ^ is the fixing patch btw [08:35:31] legoktm: for production? [08:35:36] yeah [08:37:50] 3MediaWiki / 3Export/Import: Importing does not work with HHVM - 10https://bugzilla.wikimedia.org/66023 (10Tomasz W. Kozlowski) p:5Unprio>3High s:5normal>3major [08:38:22] (03CR) 10Amire80: Bidi-isolate extension version on Special:Version (031 comment) [core] - 10https://gerrit.wikimedia.org/r/147733 (owner: 10Amire80) [08:39:50] (03PS2) 10Amire80: Bidi-isolate extension version on Special:Version [core] - 10https://gerrit.wikimedia.org/r/147733 [08:39:51] 3Wikimedia / 3Site requests: Activate Flagged Revisions for modules namespace on Ukrainian Wikipedia - 10https://bugzilla.wikimedia.org/67748 (10Tomasz W. Kozlowski) 5NEW>3ASSI a:3Tomasz W. Kozlowski [08:40:05] 3Wikimedia / 3Site requests: Change the "Prześlij plik" (Upload file) link in plwikisource sidebar - 10https://bugzilla.wikimedia.org/68191 (10Tomasz W. Kozlowski) 5NEW>3ASSI a:3Tomasz W. Kozlowski [08:40:21] 3Wikimedia / 3Site requests: No Chinese variant translation displayed for zh.voy's sitename + no sitesubtitle shown in - 10https://bugzilla.wikimedia.org/64816 (10Tomasz W. Kozlowski) 5REOP>3ASSI a:3Tomasz W. Kozlowski [08:46:37] <grrrit-wm> (03PS2) 10Withoutaname: Remove references to deprecated RawPage class and move to RawAction [extensions/CSS] - 10https://gerrit.wikimedia.org/r/148020 [08:55:19] <grrrit-wm> (03PS2) 10Withoutaname: Remove references to deprecated RawPage class and move to RawAction [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/148025 [08:58:57] <withoutaname> legoktm: about the AF bug, would it make sense to have RequestContext accept a null title, or would that be a DerivativeContext? [08:59:16] <legoktm> I don't think it should [08:59:49] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Wikidata: CTRL+click and middle click on search suggestions doesn't open the page in a new tab - 10https://bugzilla.wikimedia.org/57709#c9 (10Thiemo Mättig) (In reply to Helder from comment #8) > Still not working [...] in the "Containing [...] That's consistent to Med... [09:00:26] <legoktm> except for purely backwards compatability that should raise a warning [09:00:55] <legoktm> but if AF is the only thing broken, I'm not convinced we need it [09:01:26] <grrrit-wm> (03CR) 10Withoutaname: "https://gerrit.wikimedia.org/r/#/c/147044/" [core] - 10https://gerrit.wikimedia.org/r/147052 (owner: 10Withoutaname) [09:03:39] <grrrit-wm> (03CR) 10Withoutaname: "https://gerrit.wikimedia.org/r/#/c/146406/" [core] - 10https://gerrit.wikimedia.org/r/146727 (owner: 10Withoutaname) [09:10:50] <grrrit-wm> (03CR) 10Thiemo Mättig (WMDE): [C: 031] "You said it, setting mw.popups.render.POPUP_DELAY looks like the "official" way to me." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/137897 (https://bugzilla.wikimedia.org/64234) (owner: 10Prtksxna) [09:14:09] <grrrit-wm> (03PS1) 10Legoktm: Add base interface for setters in RequestContext and DerivativeContext [core] - 10https://gerrit.wikimedia.org/r/148028 [09:15:38] <wikibugs> 3MediaWiki extensions / 3VectorBeta: Display bug in CPB on Firefox 5.0 - 10https://bugzilla.wikimedia.org/68310 (10Andre Klapper) [09:16:34] <wikibugs> 3Wikimedia / 3General/Unknown: nds.wiktionary.org Scripterror by moduls timerunout - 10https://bugzilla.wikimedia.org/68304#c3 (10Andre Klapper) 5VERI>3RESO/WON [This is neither verified nor fixed. Resetting bug status. See https://www.mediawiki.org/wiki/Bug_management/Bug_report_life_cycle ] [09:16:49] <wikibugs> 3MediaWiki / 3User preferences: stubthreshold insanely invasive on Special:Preferences#mw-prefsection-rendering - 10https://bugzilla.wikimedia.org/68313 (10Andre Klapper) p:5Unprio>3Normal [09:22:26] <grrrit-wm> (03CR) 10Withoutaname: Add base interface for setters in RequestContext and DerivativeContext (031 comment) [core] - 10https://gerrit.wikimedia.org/r/148028 (owner: 10Legoktm) [09:23:04] <wikibugs> 3MediaWiki extensions / 3Cite: Cite: If there's no <references /> block on the page, show one automatically below the content rather than showing an error - 10https://bugzilla.wikimedia.org/66860#c21 (10Matthias Becker) Reiterating the proposal to keep maintenance category because normally the references tag... [09:26:05] <grrrit-wm> (03PS2) 10Legoktm: Add base interface for setters in RequestContext and DerivativeContext [core] - 10https://gerrit.wikimedia.org/r/148028 [09:26:08] <grrrit-wm> (03CR) 10Legoktm: Add base interface for setters in RequestContext and DerivativeContext (031 comment) [core] - 10https://gerrit.wikimedia.org/r/148028 (owner: 10Legoktm) [09:28:05] <wikibugs> 3Wikimedia / 3General/Unknown: nds.wiktionary.org Scripterror by moduls timerunout - 10https://bugzilla.wikimedia.org/68304#c4 (10TeleComNasSprVen) I'm sorry, but changing modules onwiki is not within the scope of this ticket. Perhaps you can ask nds.wikipedia.org or en.wiktionary.org to help you write the m... [09:28:49] <wikibugs> 3MediaWiki extensions / 3Cite: Cite: If there's no <references /> block on the page, show one automatically below the content rather than showing an error - 10https://bugzilla.wikimedia.org/66860#c22 (10Thiemo Mättig) (In reply to Matthias Becker from comment #21) > Reiterating the proposal to keep maintenan... [09:33:29] <grrrit-wm> (03PS1) 10Umherirrender: Always return bool in BackupReader::handleUpload [core] - 10https://gerrit.wikimedia.org/r/148031 [09:47:10] <grrrit-wm> (03PS1) 10Umherirrender: Remove mixed void/non-void returns in MysqlUpdater [core] - 10https://gerrit.wikimedia.org/r/148034 [09:53:19] <grrrit-wm> (03PS1) 10Umherirrender: Remove return from MaintenanceFixup::outputChanneled [core] - 10https://gerrit.wikimedia.org/r/148037 [10:00:52] <wikibugs> 3MediaWiki extensions / 3GoogleLogin: Blank Website - 10https://bugzilla.wikimedia.org/68316 (10Mike) 3UNCO p:3Unprio s:3normal a:3None If... $wgGLAllowedDomains = array ('domain.tld'); $wgGLAllowedDomainsStrict = false; ...is enabled a blank webpage is shown after pressing Login with Google button a... [10:05:04] <wikibugs> 3MediaWiki extensions / 3GoogleLogin: Fatal: Call to undefined method SpecialGoogleLogin::getHost after pressing Login with Google button - 10https://bugzilla.wikimedia.org/68316 (10Jesús Martínez Novo (Ciencia Al Poder)) 5UNCO>3NEW p:5Unprio>3Highes s:5normal>3blocke [10:17:05] <grrrit-wm> (03CR) 10saper: "I'd like to continue working on this (as I was the original bug reporter) during my next slot dedicated for Wikimedia coding. Unfortunatel" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/87293 (https://bugzilla.wikimedia.org/37868) (owner: 10Bpetty) [10:17:09] <grrrit-wm> (03CR) 10saper: "I'd like to continue working on this (as I was the original bug reporter) during my next slot dedicated for Wikimedia coding. Unfortunatel" [core] - 10https://gerrit.wikimedia.org/r/87482 (https://bugzilla.wikimedia.org/54950) (owner: 10saper) [10:17:20] <wikibugs> 3MediaWiki / 3API: API export action does not support exporting specific revisions - 10https://bugzilla.wikimedia.org/38669 (10Andre Klapper) [10:17:20] <wikibugs> 3MediaWiki / 3Export/Import: Export specified revisions of a page - 10https://bugzilla.wikimedia.org/4837 (10Andre Klapper) [10:30:49] <wikibugs> 3MediaWiki / 3ResourceLoader: ResourceLoader: Skip files should be valid javascript files - 10https://bugzilla.wikimedia.org/68280#c3 (10Umherirrender) 5NEW>3RESO/WON eclipse validates the .js files with a global context and than the return makes a problem. I should try to install jshint as eclipse plug... [10:32:35] <wikibugs> 3MediaWiki / 3API: API: Add mergehistory action - 10https://bugzilla.wikimedia.org/67742 (10Andre Klapper) p:5Unprio>3Low [10:33:05] <wikibugs> 3MediaWiki / 3Language converter: Remaining "disable"s in variantname-* - 10https://bugzilla.wikimedia.org/64534 (10Andre Klapper) p:5Unprio>3Low [10:33:05] <wikibugs> 3MediaWiki / 3General/Unknown: Code quality issues (tracking) - 10https://bugzilla.wikimedia.org/700 (10Andre Klapper) [10:36:35] <wikibugs> 3MediaWiki / 3Language converter: LanguageIu.php has some non-standard configurations - 10https://bugzilla.wikimedia.org/64533 (10Andre Klapper) p:5Unprio>3Low [10:37:49] <wikibugs> 3MediaWiki / 3General/Unknown: Allow move without a new revision - 10https://bugzilla.wikimedia.org/66197 (10Andre Klapper) p:5Unprio>3Lowest [10:38:34] <wikibugs> 3MediaWiki / 3General/Unknown: problem over the display box containing links to reference pages(i.e. of the form '[' a number ']' links like [6], [7]).. - 10https://bugzilla.wikimedia.org/67097#c2 (10Andre Klapper) 5UNCO>3RESO/INV Unfortunately closing this report as no further information has been provi... [10:38:43] <grrrit-wm> (03CR) 10Mvolz: [C: 032 V: 032] Uses multiple templates, fixed inheritance [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/147912 (owner: 10Mvolz) [10:39:05] <wikibugs> 3MediaWiki / 3General/Unknown: Integrate Wikifont into Core/Extension - 10https://bugzilla.wikimedia.org/66138 (10Andre Klapper) p:5Unprio>3Normal [10:39:49] <wikibugs> 3MediaWiki / 3General/Unknown: wfShellExec() cuts off stdout at multiples of 8192 bytes - 10https://bugzilla.wikimedia.org/67870 (10Andre Klapper) p:5Unprio>3Normal [10:42:08] <grrrit-wm> (03PS1) 10Mvolz: Now uses action instead of button to insert [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/148044 [10:42:19] <wikibugs> 3MediaWiki / 3General/Unknown: MediaWiki:Dot-separator default message missing - 10https://bugzilla.wikimedia.org/67795 (10Andre Klapper) 5NEW>3UNCO p:5Unprio>3Low [10:44:36] <wikibugs> 3MediaWiki / 3Installer: Updater applies patches after fresh install of MW where tables.sql already has been patched - 10https://bugzilla.wikimedia.org/66412 (10Andre Klapper) p:5Unprio>3Normal [10:44:50] <wikibugs> 3MediaWiki / 3Installer: Installer spews notice message from LocalSettingsGenerator - 10https://bugzilla.wikimedia.org/66625 (10Andre Klapper) p:5Unprio>3Lowest [10:46:21] <wikibugs> 3MediaWiki / 3Special pages: Postgresql: non-integer constant in ORDER BY - 10https://bugzilla.wikimedia.org/67594#c5 (10Andre Klapper) 5PATC>3RESO/FIX Fixed by https://gerrit.wikimedia.org/r/#/c/144765/ ; closing as FIXED. Should there be a request to backport to 1.23.x tarballs? If so, feel free to se... [10:46:35] <wikibugs> 3MediaWiki / 3User preferences: Preferences saved notification should use overlay style toaster notification rather than altering the page - 10https://bugzilla.wikimedia.org/65984 (10Andre Klapper) p:5Unprio>3Normal [10:46:52] <wikibugs> 3MediaWiki / 3User preferences: Support easy opt-in/out after deployment - 10https://bugzilla.wikimedia.org/67883 (10Andre Klapper) p:5Unprio>3Low [10:47:04] <wikibugs> 3MediaWiki / 3User login and signup: Allow concurrent "remember me" logins - 10https://bugzilla.wikimedia.org/67512 (10Andre Klapper) p:5Unprio>3Low [10:47:49] <wikibugs> 3MediaWiki / 3Special pages: [[Special:AllMessages]] should default to the user language instead of content language - 10https://bugzilla.wikimedia.org/65582 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [10:48:49] <wikibugs> 3Wikimedia / 3Bugzilla: Reorganize "Wikipedia Apps" product - 10https://bugzilla.wikimedia.org/64621#c22 (10Andre Klapper) Yuvi, Bernd, Dan: ping [10:51:04] <wikibugs> 3MediaWiki / 3Skin and page rendering: Too small width of TOC in Firefox on Android - 10https://bugzilla.wikimedia.org/66314 (10Andre Klapper) p:5Unprio>3Low [10:51:35] <wikibugs> 3MediaWiki / 3User login and signup: MediaWiki:Loginprompt is no longer displayed on login page - 10https://bugzilla.wikimedia.org/66574 (10Andre Klapper) [10:51:35] <wikibugs> 3MediaWiki / 3User login and signup: MediaWiki:Loginprompt is no longer displayed on login page - 10https://bugzilla.wikimedia.org/66574 (10Andre Klapper) p:5Unprio>3High [10:52:20] <wikibugs> 3MediaWiki extensions / 3CodeEditor: Allow searching using URL hash - 10https://bugzilla.wikimedia.org/68270 (10Andre Klapper) p:5Unprio>3Low [10:52:20] <wikibugs> 3MediaWiki extensions / 3CodeEditor: Add support for mobile - 10https://bugzilla.wikimedia.org/67328 (10Andre Klapper) p:5Unprio>3Low [10:52:34] <wikibugs> 3MediaWiki extensions / 3CodeEditor: Cursor sometimes in wrong place when editing js pages with code editor - 10https://bugzilla.wikimedia.org/66397 (10Andre Klapper) p:5Unprio>3Normal [10:53:04] <wikibugs> 3MediaWiki extensions / 3CodeEditor: Make hidden "usecodeeditor" preference visible, and do serve the CodeEditor on the relevant pages if switched on - 10https://bugzilla.wikimedia.org/65575 (10Andre Klapper) p:5Unprio>3Low [10:53:19] <wikibugs> 3MediaWiki extensions / 3FlaggedRevs: Add UserMerge support to FlaggedRevs - 10https://bugzilla.wikimedia.org/67769 (10Andre Klapper) p:5Unprio>3Normal [10:53:49] <wikibugs> 3MediaWiki extensions / 3MoodBar: Add UserMerge support to MoodBar - 10https://bugzilla.wikimedia.org/67773 (10Andre Klapper) p:5Unprio>3Normal [10:54:04] <wikibugs> 3MediaWiki extensions / 3MoodBar: Untranslatable timestamps in moodbar-feedback-response-helpful-summary, moodbar-feedback-response-summary - 10https://bugzilla.wikimedia.org/67965 (10Andre Klapper) p:5Unprio>3Low [10:54:19] <wikibugs> 3MediaWiki extensions / 3GlobalBlocking: Add UserMerge support to GlobalBlocking - 10https://bugzilla.wikimedia.org/67771 (10Andre Klapper) p:5Unprio>3Normal [10:54:36] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: wbparsevalue API calls are missing the lang option - 10https://bugzilla.wikimedia.org/63059 (10tobias.gritschacher) [10:54:49] <wikibugs> 3MediaWiki extensions / 3GlobalBlocking: Global blocking race condition - 10https://bugzilla.wikimedia.org/67815#c5 (10Andre Klapper) legoktm: Patches mentioned in this report has been merged - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you clos... [10:55:37] <wikibugs> 3MediaWiki extensions / 3Oversight: Add UserMerge support to Oversight - 10https://bugzilla.wikimedia.org/67775 (10Andre Klapper) p:5Unprio>3Normal [10:55:37] <wikibugs> 3MediaWiki extensions / 3ParserFunctions: Unwanted line breaks in if statements - 10https://bugzilla.wikimedia.org/66027 (10Andre Klapper) p:5Unprio>3Low [10:55:38] <wikibugs> 3MediaWiki extensions / 3GlobalBlocking: Global blocking race condition - 10https://bugzilla.wikimedia.org/67815#c6 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Kunal Mehta (Legoktm) This should be fixed now :) [10:57:36] <wikibugs> 3MediaWiki extensions / 3FundraisingChart: Performance review for mediawiki/extensions/FundraisingChart - 10https://bugzilla.wikimedia.org/66806 (10Andre Klapper) a:3fr-tech [10:57:49] <wikibugs> 3MediaWiki extensions / 3FundraisingChart: Performance review for mediawiki/extensions/FundraisingChart - 10https://bugzilla.wikimedia.org/66806 (10Andre Klapper) p:5Unprio>3Normal [10:58:06] <wikibugs> 3MediaWiki extensions / 3FundraisingChart: Security review for mediawiki/extensions/FundraisingChart - 10https://bugzilla.wikimedia.org/66805 (10Andre Klapper) p:5Unprio>3Normal a:3fr-tech [11:05:06] <wikibugs> 3MediaWiki / 3Special pages: Postgresql: non-integer constant in ORDER BY - 10https://bugzilla.wikimedia.org/67594#c6 (10Jesús Martínez Novo (Ciencia Al Poder)) a:3Jeff Janes Gerrit change 144824 is the backport to REL1_23, so I'm setting the appropriate flag [11:11:34] <wikibugs> 3MediaWiki / 3Parser: Extraneous HTML produced by msg->parse() - 10https://bugzilla.wikimedia.org/65863 (10Andre Klapper) p:5Unprio>3Low [11:17:06] <wikibugs> 3MediaWiki extensions / 3GoogleLogin: Login not possible and nor error message it username is deleted/merged by UserMerge extension - 10https://bugzilla.wikimedia.org/68317 (10Mike) 3UNCO p:3Unprio s:3normal a:3None A new Wiki user is created and linked to a Google account. If this user is now delete... [11:17:19] <wikibugs> 3MediaWiki / 3Sites: At trying to add interwikis to the Slovene Wikipedia, the software incorrectly searches the 'sk' database instead of the 'sl' one - 10https://bugzilla.wikimedia.org/67566#c2 (10Andre Klapper) 5NEW>3UNCO Hi Dejan, thanks for taking the time to report this! What are exact steps, click... [11:17:34] <wikibugs> 3MediaWiki / 3Special pages: Special:NewPages feed shows newest revision (inconsistent with special page) - 10https://bugzilla.wikimedia.org/67026 (10Andre Klapper) p:5Unprio>3Normal [11:18:05] <wikibugs> 3Wikimedia / 3Site requests: 300GB of files on a hard disk in need of a URI or WMF direct upload - 10https://bugzilla.wikimedia.org/67477 (10Andre Klapper) p:5Unprio>3Normal [11:18:20] <wikibugs> 3Wikimedia / 3Deployment systems: [OPS] Jenkins: Package php5-parsekit missing in Trusty - 10https://bugzilla.wikimedia.org/68255#c4 (10Antoine "hashar" Musso) (In reply to Bryan Davis from comment #2) > We should really find a better way to lint than using a PECL package that > hasn't had a release since 20... [11:18:34] <wikibugs> 3Wikimedia / 3Site requests: Enable 'Comments' namespace at Test.Wikipedia.org - 10https://bugzilla.wikimedia.org/67573#c3 (10Andre Klapper) TTO: Do you know? ^ [11:22:06] <wikibugs> 3Wikimedia / 3Mailing lists: Mailing list for Grant Advisory Committee - 10https://bugzilla.wikimedia.org/68179 (10Andre Klapper) p:5Unprio>3Normal [11:22:06] <wikibugs> 3Wikimedia / 3Media storage: Spam restriction on thumbnailing restrictive enough I hit it on normal browsing activity - 10https://bugzilla.wikimedia.org/66109 (10Andre Klapper) p:5Unprio>3Normal [11:22:06] <wikibugs> 3Wikimedia / 3Media storage: Thumbnail/imagescaler (tracking) - 10https://bugzilla.wikimedia.org/41371 (10Andre Klapper) [11:22:20] <wikibugs> 3MediaWiki / 3Export/Import: Special:Import increases NUMBEROFARTICLES for each Revision instead of each Article - 10https://bugzilla.wikimedia.org/40009#c20 (10This, that and the other) I observe that this bug does *not* occur when importing additional revisions to an existing page (see [[testwiki:Kennebunk... [11:22:34] <wikibugs> 3Wikimedia / 3lucene-search-2: Valid Page name resulting in backend search error - 10https://bugzilla.wikimedia.org/66259 (10Andre Klapper) p:5Unprio>3Low [11:24:34] <wikibugs> 3Wikimedia / 3General/Unknown: New VisualEditor translations not appearing in production as quickly as for other features(?) - 10https://bugzilla.wikimedia.org/61368 (10Andre Klapper) p:5Unprio>3Low [11:24:50] <wikibugs> 3Wikimedia / 3General/Unknown: JQMIGRATE: jQuery.fn.andSelf() replaced by jQuery.fn.addBack() - 10https://bugzilla.wikimedia.org/66520 (10Andre Klapper) p:5Unprio>3Normal [11:24:50] <wikibugs> 3MediaWiki / 3Export/Import: Special:Import needs to update site statistics - 10https://bugzilla.wikimedia.org/5703#c24 (10This, that and the other) 5REOP>3UNCO Setting to unconfirmed. No reports of this issue since 2010. Is this issue still being seen? Note that this bug is about site stats not being u... [11:25:34] <wikibugs> 3MediaWiki / 3Categories: Category listings should be devided as close to equal as possible - 10https://bugzilla.wikimedia.org/66837 (10Andre Klapper) p:5Unprio>3Low s:5normal>3minor [11:26:20] <wikibugs> 3MediaWiki / 3Documentation: Documentation is out of date, incomplete (tracking) - 10https://bugzilla.wikimedia.org/1 (10Andre Klapper) [11:26:20] <wikibugs> 3MediaWiki / 3Documentation: Clear documentation should be provided about the *my* permissions - 10https://bugzilla.wikimedia.org/67167 (10Andre Klapper) p:5Unprio>3Low [11:28:04] <wikibugs> 3MediaWiki / 3Internationalization: Changing fall-back language and language name (زَوُن) for aeb (Tunisian Language) - 10https://bugzilla.wikimedia.org/68207 (10Andre Klapper) p:5Unprio>3Normal [11:31:08] <wikibugs> 3Wikimedia / 3Site requests: Enable 'Comments' namespace at Test.Wikipedia.org - 10https://bugzilla.wikimedia.org/67573#c4 (10This, that and the other) Gryllida, what are you planning to do? If you just want a namespace for random testing, there are two on testwiki and several others on test2wiki. As far as... [11:32:06] <wikibugs> 3MediaWiki / 3Skin and page rendering: Ability of to change layout of 'Search result page' by skin - 10https://bugzilla.wikimedia.org/67090#c3 (10Andre Klapper) p:5Unprio>3Lowest s:5normal>3enhanc I'm not sure which problem you'd like to solve here, and if that's actually an enhancement request which... [11:35:09] <grrrit-wm> (03CR) 10Fomafix: "updateTooltipAccessKeys removes the suffix " [key]" and adds a new suffix based on the accesskey property. The update of the tooltip was a" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/138890 (owner: 10Gerrit Patch Uploader) [11:37:24] <grrrit-wm> (03CR) 10Florianschmidtwelzow: [C: 032] Compatibility for custom articlepath [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/147680 (owner: 10Florianschmidtwelzow) [11:37:30] <grrrit-wm> (03Merged) 10jenkins-bot: Compatibility for custom articlepath [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/147680 (owner: 10Florianschmidtwelzow) [11:38:19] <wikibugs> 3MediaWiki / 3JavaScript: jquery.client shouldn't be fooled by "Request desktop site" option in mobile browsers - 10https://bugzilla.wikimedia.org/65255 (10Andre Klapper) p:5Unprio>3Low [11:39:20] <wikibugs> 3MediaWiki / 3Maintenance scripts: deleteOldRevisions.php delete content date - 10https://bugzilla.wikimedia.org/66615#c5 (10Andre Klapper) p:5Unprio>3Lowest I'd be interested to know where rm2d_ki101 comes from. [11:39:52] <wikibugs> 3MediaWiki / 3JavaScript: es5-shim module doesn't include Object.create implementation, needed for OOjs - 10https://bugzilla.wikimedia.org/67590 (10Andre Klapper) p:5Unprio>3Normal [11:39:52] <wikibugs> 3MediaWiki / 3JavaScript: Profile section of debug toolbar is truncated in Firefox 30.0 - 10https://bugzilla.wikimedia.org/67838 (10Andre Klapper) p:5Unprio>3Normal [11:39:52] <wikibugs> 3MediaWiki / 3JavaScript: jquery.tipsy (tracking) - 10https://bugzilla.wikimedia.org/67500 (10Andre Klapper) p:5Unprio>3Normal [11:43:36] <wikibugs> 3MediaWiki extensions / 3GoogleLogin: Fatal: Call to undefined method SpecialGoogleLogin::getHost after pressing Login with Google button - 10https://bugzilla.wikimedia.org/68316 (10Florian) s:5blocke>3critic a:3Florian [11:44:04] <wikibugs> 3MediaWiki / 3Maintenance scripts: deleteOldRevisions.php delete content date - 10https://bugzilla.wikimedia.org/66615#c6 (10Jesús Martínez Novo (Ciencia Al Poder)) JavaScript error console has nothing to do here IMHO When you move a page, it creates a new revision, but it doesn't create a new row in the te... [11:48:07] <wikibugs> 3Wikimedia / 3Bugzilla: Bugzilla component for mediawiki/services/jobrunner with appropriate default CC - 10https://bugzilla.wikimedia.org/68318 (10Antoine "hashar" Musso) 3NEW p:3Unprio s:3normal a:3None Aaron Schulz and Ori Livneh (CCed) ported the job runner from shell to PHP. It is no living at m... [11:48:49] <wikibugs> 3Wikimedia / 3General/Unknown: Rewrite jobs-loop.sh in a proper programming language - 10https://bugzilla.wikimedia.org/46770#c6 (10Antoine "hashar" Musso) I have filled Bug 68318 - Bugzilla component for mediawiki/services/jobrunner with appropriate default CC Note the repository is missing tests :/ [11:53:04] <grrrit-wm> (03PS1) 10Florianschmidtwelzow: Fixed fatal undefined SpecialGoogleLogin::getHost [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/148051 (https://bugzilla.wikimedia.org/68316) [11:55:12] <grrrit-wm> (03PS2) 10Florianschmidtwelzow: Fixed fatal undefined SpecialGoogleLogin::getHost [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/148051 (https://bugzilla.wikimedia.org/68316) [11:56:59] <grrrit-wm> (03CR) 10Gilles: [C: 032] Added COPYING file to clearly state GPL2 for the extension. [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/95779 (owner: 10Mdale) [11:57:06] <grrrit-wm> (03Merged) 10jenkins-bot: Added COPYING file to clearly state GPL2 for the extension. [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/95779 (owner: 10Mdale) [12:00:38] <grrrit-wm> (03PS1) 10Hashar: Split CLI and class to their own file [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148053 [12:02:22] <grrrit-wm> (03CR) 10Hashar: "Note that previously php -l was not run against redisJobRunnerService. The reason is that the Jenkins job looks for file ending with .(php" [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148053 (owner: 10Hashar) [12:02:24] <grrrit-wm> (03PS1) 10Florianschmidtwelzow: Updated README [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/148054 [12:20:12] <grrrit-wm> (03PS1) 10Smuggli: Implementes changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148055 [12:21:26] <grrrit-wm> (03CR) 10Gilles: "Gergo: did you remember to run "vagrant provision" after applying the patch and enabling the role? The changeset still works for me after " [vagrant] - 10https://gerrit.wikimedia.org/r/147151 (owner: 10Gilles) [12:21:53] <grrrit-wm> (03CR) 10Gilles: Create Commons role to provide a ForeignDBViaLBRepo wiki (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/147151 (owner: 10Gilles) [12:25:37] <grrrit-wm> (03CR) 10Gilles: [C: 032] For xcf files, compose layers before scaling [core] - 10https://gerrit.wikimedia.org/r/147909 (https://bugzilla.wikimedia.org/35622) (owner: 10Brian Wolff) [12:29:51] <grrrit-wm> (03CR) 10Scott-linder: "Thank you for taking the time to review this; it was great to find an extension that fits our needs perfectly." [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/147991 (owner: 10Scott-linder) [12:30:02] <grrrit-wm> (03Merged) 10jenkins-bot: For xcf files, compose layers before scaling [core] - 10https://gerrit.wikimedia.org/r/147909 (https://bugzilla.wikimedia.org/35622) (owner: 10Brian Wolff) [12:31:35] <wikibugs> 3MediaWiki extensions / 3OATHAuth: OATHAuth should pass jshint - 10https://bugzilla.wikimedia.org/61617#c2 (10Antoine "hashar" Musso) Apparently modules/qrcode.js is a third party file so it could be added to .jshintignore modules/jquery.qrcode.js seems to have been written by Ryan Lane. [12:34:01] <grrrit-wm> (03PS1) 10Hashar: Pass jshint [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/148059 (https://bugzilla.wikimedia.org/61617) [12:34:54] <grrrit-wm> (03CR) 10Hashar: [C: 031] "^^^ jslint job is passing :-}" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/148059 (https://bugzilla.wikimedia.org/61617) (owner: 10Hashar) [12:35:28] <grrrit-wm> (03PS2) 10Scott-linder: Add #get_file_data for local files. [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/147991 [12:35:49] <grrrit-wm> (03CR) 10Hashar: [C: 031] Make FR pass jslint [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/144479 (https://bugzilla.wikimedia.org/63117) (owner: 10Alex Monk) [12:36:16] <grrrit-wm> (03PS3) 10Scott-linder: Add #get_file_data for local files. [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/147991 [12:40:48] <grrrit-wm> (03CR) 10Scott-linder: "I made the changes I described and rebased them on master. If you're happy with them, feel free to merge them. If you still have concerns " [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/147991 (owner: 10Scott-linder) [12:41:37] <wikibugs> 3Wikimedia / 3Language setup: Change user group rights on es.wikipedia - 10https://bugzilla.wikimedia.org/68319 (10mr.ajedrez) 3UNCO p:3Unprio s:3major a:3None I enter this bug to ask for changing user group rights on es.wikipedia, as decided on the local village pump (https://es.wikipedia.org/wiki/W... [12:46:18] <grrrit-wm> (03PS1) 10Smuggli: Added @embed statement for resourceloader [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148060 [12:50:08] <grrrit-wm> (03PS1) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/148062 [12:52:34] <wikibugs> 3MediaWiki / 3JavaScript: take over jquery.tipsy plugin - 10https://bugzilla.wikimedia.org/35241#c10 (10Antoine "hashar" Musso) (In reply to Tisza Gergő from comment #9) > Did any work happen in the fork? From the github network graph it seems it > is still identical to the original tipsy plugin; there is a... [12:53:00] <athiralekshmicv> Can you help me with https://bugzilla.wikimedia.org/show_bug.cgi?id=68126 [12:55:20] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: old version of item shows current label as page title - 10https://bugzilla.wikimedia.org/61954#c1 (10tobias.gritschacher) 5NEW>3RESO/FIX Seems that has been fixed along with #63309. [12:55:50] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: old version of item shows current label as page title - 10https://bugzilla.wikimedia.org/61954#c2 (10tobias.gritschacher) https://bugzilla.wikimedia.org/show_bug.cgi?id=63309 [12:57:40] <sumanah> hi athiralekshmicv - what help specifically do you need? [13:02:32] <grrrit-wm> (03CR) 10Umherirrender: [C: 031] "Some tests would be nice, but not blocking in my opinion." [core] - 10https://gerrit.wikimedia.org/r/147743 (https://bugzilla.wikimedia.org/67925) (owner: 10Rohan013) [13:02:34] <wikibugs> 3Wikimedia / 3Site requests: Change user group rights on es.wikipedia - 10https://bugzilla.wikimedia.org/68319 (10Sam Reed (reedy)) p:5Unprio>3Normal s:5major>3enhanc [13:04:35] <wikibugs> 3MediaWiki / 3Special pages: Postgresql: non-integer constant in ORDER BY - 10https://bugzilla.wikimedia.org/67594 (10Andre Klapper) [13:08:34] <wikibugs> 3Wikimedia / 3Site requests: Change "abusefilter-log-detail" user group rights on es.wikipedia - 10https://bugzilla.wikimedia.org/68319 (10Andre Klapper) [13:08:35] <grrrit-wm> (03CR) 10Umherirrender: "Tests would be nice for old and new style" [core] - 10https://gerrit.wikimedia.org/r/144762 (owner: 10Yurik) [13:11:49] <wikibugs> 3Wikimedia / 3General/Unknown: New VisualEditor translations not appearing in production as quickly as for other features(?) - 10https://bugzilla.wikimedia.org/61368#c9 (10Elitre) We'd need to check if the fix for bug 67805 fixed this as well. [13:14:34] <grrrit-wm> (03PS2) 10Umherirrender: Check for boolean false result from database query in SqlBagOStuff [core] - 10https://gerrit.wikimedia.org/r/141619 (owner: 10Ori.livneh) [13:15:03] <grrrit-wm> (03CR) 10Umherirrender: "Patch Set 2: Rebased" [core] - 10https://gerrit.wikimedia.org/r/141619 (owner: 10Ori.livneh) [13:17:50] <wikibugs> 3MediaWiki extensions / 3GoogleLogin: Fatal: Call to undefined method SpecialGoogleLogin::getHost after pressing Login with Google button - 10https://bugzilla.wikimedia.org/68316#c2 (10Mike) 5PATC>3RESO/FIX After applying the patches I can confirm that they fix the error. [13:24:05] <wikibugs> 3Wikimedia / 3Mailing lists: Create multimedia-internal mailing list - 10https://bugzilla.wikimedia.org/61731#c19 (10Mark Holmquist) Oh, -team then. I thought I saw an -internal one, but that works. [13:25:54] <wikibugs> 3MediaWiki extensions / 3GoogleLogin: Fatal: Call to undefined method SpecialGoogleLogin::getHost after pressing Login with Google button - 10https://bugzilla.wikimedia.org/68316#c3 (10Florian) 5RESO/FIX>3PATC Thanks for testing Mike :) Set back to Patch to review, because the patch is not merged into g... [13:28:36] <sumanah> hi athiralekshmicv - what help specifically do you need? [13:30:49] <athiralekshmicv> I thought of adding "tooltip-pt-betafeatures:Beta Features" in en.json and then describing it in qqq.json [13:31:03] <marktraceur> Oh, welcome back athiralekshmicv [13:32:04] <athiralekshmicv> But adding the decription seems confusing [13:32:12] <athiralekshmicv> *description [13:32:35] <marktraceur> athiralekshmicv: One, it's "tooltip-pt-betafeatures": "Beta Features", [13:32:46] <marktraceur> athiralekshmicv: But what is confusing you? [13:34:52] <tonythomas> athiralekshmicv: sometimes https://www.mediawiki.org/wiki/Manual:Developing_extensions#Define_messages might help ? [13:37:33] <athiralekshmicv> I guess the description "tooltip-pt-betafeatures": "Tooltip shown when hovering over the {{msg-mw|Beta}} link in your personal toolbox (upper right side). will do? [13:38:34] <marktraceur> athiralekshmicv: Sure. [13:44:10] <grrrit-wm> (03CR) 10Gilles: Create Commons role to provide a ForeignDBViaLBRepo wiki (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/147151 (owner: 10Gilles) [13:58:12] <grrrit-wm> (03PS1) 10Rillke: Do not run `navigator.getUserMedia()` when not supported [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/148067 [14:04:30] <grrrit-wm> (03CR) 10CSteipp: "Ah, cool. Didn't realize we got that working. Can we get his patch backported to our instance?" [phabricator/libphutil] - 10https://gerrit.wikimedia.org/r/147686 (owner: 10CSteipp) [14:12:42] <grrrit-wm> (03PS6) 10Gilles: Create Commons role to provide a ForeignDBViaLBRepo wiki [vagrant] - 10https://gerrit.wikimedia.org/r/147151 [14:13:50] <grrrit-wm> (03CR) 10Scott-linder: "Also, concerning using an ID scheme as with the database access, I think it might be overkill; it makes sense for database access as it ma" [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/147991 (owner: 10Scott-linder) [14:34:36] <wikibugs> 3MediaWiki extensions / 3CLDR: MWTimestamp::getHumanTimestamp() (aka timestamps in echo) not translated into Chechen - 10https://bugzilla.wikimedia.org/62607#c19 (10Umar) Sorry. I'm waiting for the file to translate it.Who can give it to me? [14:42:50] <wikibugs> 3Wikimedia / 3Mailing lists: Create multimedia-team mailing list - 10https://bugzilla.wikimedia.org/61731#c20 (10Thehelpfulone) 5REOP>3RESO/FIX List created, with an email sent to all of you as the list admins. I've also subscribed you all to the list, with private archives and confirm and approve subscr... [14:42:52] <grrrit-wm> (03CR) 10Parent5446: [C: 032] Remove check for wikimedia-mode file, which no longer exists [core] - 10https://gerrit.wikimedia.org/r/147879 (owner: 10Withoutaname) [14:44:22] <grrrit-wm> (03CR) 10Parent5446: [C: 032] Leave table names with numbers untouched in DatabaseBase::generalizeSQL [core] - 10https://gerrit.wikimedia.org/r/147743 (https://bugzilla.wikimedia.org/67925) (owner: 10Rohan013) [14:45:40] <grrrit-wm> (03CR) 10Parent5446: [C: 032] Always return bool in BackupReader::handleUpload [core] - 10https://gerrit.wikimedia.org/r/148031 (owner: 10Umherirrender) [14:47:08] <grrrit-wm> (03Merged) 10jenkins-bot: Remove check for wikimedia-mode file, which no longer exists [core] - 10https://gerrit.wikimedia.org/r/147879 (owner: 10Withoutaname) [14:47:38] <grrrit-wm> (03Merged) 10jenkins-bot: Leave table names with numbers untouched in DatabaseBase::generalizeSQL [core] - 10https://gerrit.wikimedia.org/r/147743 (https://bugzilla.wikimedia.org/67925) (owner: 10Rohan013) [14:48:50] <grrrit-wm> (03Merged) 10jenkins-bot: Always return bool in BackupReader::handleUpload [core] - 10https://gerrit.wikimedia.org/r/148031 (owner: 10Umherirrender) [14:52:05] <wikibugs> 3MediaWiki extensions / 3Cite: Error generation of unbalanced <ref><references/>: No error is shown if missing </ref>-tag is the last ref tag - 10https://bugzilla.wikimedia.org/15712#c3 (10Gadget850) Duplicate of Bug 21798 [14:52:16] <grrrit-wm> (03CR) 10Parent5446: [C: 031] Add base interface for setters in RequestContext and DerivativeContext [core] - 10https://gerrit.wikimedia.org/r/148028 (owner: 10Legoktm) [14:53:35] <wikibugs> 3MediaWiki extensions / 3Cite: No error message for omitted </ref> tag - 10https://bugzilla.wikimedia.org/21798#c11 (10Gadget850) With the resolution of Bug 66860, a missing reference list is now automatically added. Before this was deployed, a page with a missing </ref> tag near the end of a page would eat... [14:56:40] <grrrit-wm> (03CR) 10Parent5446: "I don't know if this is too big a task to ask for, but would it be possible to *also* remove the Article class delete code and make it use" [core] - 10https://gerrit.wikimedia.org/r/142618 (owner: 10Withoutaname) [14:57:01] <grrrit-wm> (03CR) 10Chad: "I thought we had a patch for this before. Tim gave a rather long explanation of why we couldn't remove it (and why the whole thing is most" [core] - 10https://gerrit.wikimedia.org/r/147879 (owner: 10Withoutaname) [14:57:37] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: JS error when viewing old revision of item - 10https://bugzilla.wikimedia.org/68322 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs There is a JS error when I try looking at an old revision of an item: Uncaught TypeError: Cannot read property '... [14:58:21] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: JS error when viewing old revision of item - 10https://bugzilla.wikimedia.org/68322 (10tobias.gritschacher) p:5Unprio>3Highes s:5normal>3major [14:58:21] <wikibugs> 3MediaWiki extensions / 3Cite: No error message for omitted </ref> tag - 10https://bugzilla.wikimedia.org/21798#c12 (10Gadget850) Duplicate of Bug 15712 [15:01:21] <wikibugs> 3MediaWiki / 3Database: DatabaseBase::generalizeSQL mangles table names with a number - 10https://bugzilla.wikimedia.org/67925#c4 (10Umherirrender) 5PATC>3RESO/FIX successfully merged [15:04:36] <grrrit-wm> (03PS1) 10Chad: Merge branch 'master' into wmf/1.24wmf14 [extensions/CirrusSearch] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148088 [15:04:52] <wikibugs> 3MediaWiki extensions / 3Cite: Cite: Add namespace detection for automatically generated reference list - 10https://bugzilla.wikimedia.org/68324 (10Gadget850) 3NEW p:3Unprio s:3normal a:3None When error checking was first added to cite.php, the message for missing reference list markup was showing up... [15:05:21] <wikibugs> 3MediaWiki extensions / 3Cite: Cite: If there's no <references /> block on the page, show one automatically below the content rather than showing an error - 10https://bugzilla.wikimedia.org/66860#c23 (10Gadget850) Bug 68324 - Cite: Add namespace detection for automatically generated reference list [15:05:49] <grrrit-wm> (03CR) 10Chad: [C: 032] Merge branch 'master' into wmf/1.24wmf14 [extensions/CirrusSearch] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148088 (owner: 10Chad) [15:05:59] <grrrit-wm> (03Merged) 10jenkins-bot: Merge branch 'master' into wmf/1.24wmf14 [extensions/CirrusSearch] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148088 (owner: 10Chad) [15:06:11] <grrrit-wm> (03CR) 10Parent5446: [C: 04-1] Move deletion-specific code to DeleteAction.php (038 comments) [core] - 10https://gerrit.wikimedia.org/r/142618 (owner: 10Withoutaname) [15:06:58] <grrrit-wm> (03CR) 10Parent5446: "Well if the file doesn't exist in production, then the code is not used anywhere anymore." [core] - 10https://gerrit.wikimedia.org/r/147879 (owner: 10Withoutaname) [15:07:06] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: label for sitelink target input box on Special:SetSitelink - 10https://bugzilla.wikimedia.org/63485 (10Thiemo Mättig) 5PATC>3RESO/FIX [15:07:38] <grrrit-wm> (03PS1) 10Chad: Updating CirrusSearch to master [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148089 [15:08:57] <grrrit-wm> (03CR) 10Parent5446: ":/ We really need to enable the file indexing on Gerrit so we can search for patches by file path." [core] - 10https://gerrit.wikimedia.org/r/147879 (owner: 10Withoutaname) [15:10:14] <grrrit-wm> (03CR) 10Parent5446: "@Jeroen - Probably true, but the reason I see this as a success is because the Action class is now a lot more like the SpecialPage class, " [core] - 10https://gerrit.wikimedia.org/r/143211 (owner: 10Withoutaname) [15:11:32] <grrrit-wm> (03CR) 10Parent5446: [C: 031] Subclass the Action class under ContextSource (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143211 (owner: 10Withoutaname) [15:13:19] <grrrit-wm> (03PS1) 10Brian Wolff: partial revert 676df858e984. Add back 3 messages that were really used. [extensions/TimedMediaHandler] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148091 [15:13:52] <grrrit-wm> (03CR) 10Parent5446: Action: Merge getClass() into factory() and kill $wgActions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/145247 (owner: 10Withoutaname) [15:13:54] <grrrit-wm> (03CR) 10Yaron Koren: "A" [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/147991 (owner: 10Scott-linder) [15:18:38] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Server side generated html of read only Entity views shouldn't include edit links - 10https://bugzilla.wikimedia.org/68325 (10Marius Hoch) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Removing the edit links with JavaScript is a bad idea... especially when viewing... [15:19:24] <wikibugs> 3Wikimedia / 3Site requests: Deploy TemplateData's GUI editing tool to Finnish Wikipedia - 10https://bugzilla.wikimedia.org/68184#c6 (10James Forrester) 5PATC>3RESO/FIX This is now done. Please shout if there are any issues. [15:19:50] <grrrit-wm> (03CR) 10Chad: [C: 032] Updating CirrusSearch to master [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148089 (owner: 10Chad) [15:20:39] <grrrit-wm> (03CR) 10MarkAHershberger: [C: 032] PostgreSQL: Fix ORDER BY NULL [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/144824 (https://bugzilla.wikimedia.org/67594) (owner: 10Jjanes) [15:23:48] <grrrit-wm> (03Merged) 10jenkins-bot: Updating CirrusSearch to master [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148089 (owner: 10Chad) [15:24:03] <grrrit-wm> (03Merged) 10jenkins-bot: PostgreSQL: Fix ORDER BY NULL [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/144824 (https://bugzilla.wikimedia.org/67594) (owner: 10Jjanes) [15:27:36] <wikibugs> 3Wikimedia / 3Site requests: No Chinese variant translation displayed for zh.voy's sitename + no sitesubtitle shown in <title> - 10https://bugzilla.wikimedia.org/64816#c12 (10James Forrester) 5PATC>3RESO/FIX This should now be done. Thanks, Odder! [15:27:50] <wikibugs> 3Wikimedia / 3Site requests: Change the "Prześlij plik" (Upload file) link in plwikisource sidebar - 10https://bugzilla.wikimedia.org/68191#c3 (10James Forrester) 5PATC>3RESO/FIX This should now be done. Thanks, Odder! [15:32:56] <grrrit-wm> (03PS1) 10Lekshmi: Added title text for beta in personal tools [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/148092 (https://bugzilla.wikimedia.org/68126) [15:34:50] <wikibugs> 3MediaWiki extensions / 3Cite: Cite: Add namespace detection for automatically generated reference list - 10https://bugzilla.wikimedia.org/68324#c1 (10James Forrester) 5NEW>3RESO/WON I don't see a valid use case here. If people are foolishly copying bits of an article to a talk page, they should be good... [15:36:19] <grrrit-wm> (03CR) 10Daniel Kinzler: [C: 04-1] "@Parent: perhaps it would be better to have a cleanly designed interface for something that could replace SpecialPage and Action, instead " [core] - 10https://gerrit.wikimedia.org/r/143211 (owner: 10Withoutaname) [15:38:21] <wikibugs> 3Wikimedia / 3Site requests: Activate Flagged Revisions for modules namespace on Ukrainian Wikipedia - 10https://bugzilla.wikimedia.org/67748#c3 (10Tomasz W. Kozlowski) 5PATC>3RESO/FIX This has now been merged and deployed to the production cluster by Chad (thank you!). [15:38:43] <grrrit-wm> (03CR) 10Jforrester: [C: 04-1] Added title text for beta in personal tools (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/148092 (https://bugzilla.wikimedia.org/68126) (owner: 10Lekshmi) [15:43:22] <grrrit-wm> (03CR) 10Parent5446: "Lol good point. TBH IContextSource is not that bad, it was just executed poorly despite its good intentions. This is something that will n" [core] - 10https://gerrit.wikimedia.org/r/143211 (owner: 10Withoutaname) [15:43:38] <wikibugs> 3MediaWiki extensions / 3Cite: No error message for omitted </ref> tag - 10https://bugzilla.wikimedia.org/21798#c13 (10James Forrester) 5NEW>3RESO/DUP (In reply to Gadget850 from comment #12) > Duplicate of Bug 15712 Agreed. *** This bug has been marked as a duplicate of bug 15712 *** [15:43:38] <wikibugs> 3MediaWiki extensions / 3Cite: Error generation of unbalanced <ref><references/>: No error is shown if missing </ref>-tag is the last ref tag - 10https://bugzilla.wikimedia.org/15712#c4 (10James Forrester) *** Bug 21798 has been marked as a duplicate of this bug. *** [15:48:38] <wikibugs> 3MediaWiki / 3ResourceLoader: External link icon is not flipped in RTL - 10https://bugzilla.wikimedia.org/68326 (10Yair Rand) 3NEW p:3Unprio s:3normal a:3None (Sorry if ResourceLoader isn't the right component for this.) In RTL wikis, the icon displayed next to external links (with the class .extern... [15:58:44] <grrrit-wm> (03CR) 10Yaron Koren: "Oops! Accidentally hit "Publish" before." [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/147991 (owner: 10Scott-linder) [16:00:10] <grrrit-wm> (03CR) 10Jforrester: "Sorry about this! :-)" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/147887 (owner: 10Mvolz) [16:04:30] <grrrit-wm> (03CR) 10Daniel Kinzler: [C: 031] "The changes I see all make sense. I can't tell if there is more needed to make this consistent." [core] - 10https://gerrit.wikimedia.org/r/147058 (owner: 10Thiemo Mättig (WMDE)) [16:05:06] <wikibugs> 3Wikimedia / 3General/Unknown: nds.wiktionary.org Scripterror by moduls timerunout - 10https://bugzilla.wikimedia.org/68304#c5 (10Joachim Mos) @TeleComNasSprVen There is no problem with the module! The Modul:language utilities is called in every line more than 2 times. We have our translations in template... [16:07:25] <grrrit-wm> (03CR) 10Daniel Kinzler: "This is not specific to wikibase. It should go into core, or a separate extension." [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/145764 (https://bugzilla.wikimedia.org/42207) (owner: 10Hoo man) [16:09:04] <grrrit-wm> (03CR) 10Hoo man: "but specific to Wikimedia (see the mails we've exchanged about this on the internal list)" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/145764 (https://bugzilla.wikimedia.org/42207) (owner: 10Hoo man) [16:09:52] <grrrit-wm> (03CR) 10Daniel Kinzler: [C: 031] "This change looks sensible, but the way Title interacts with the database makes my skin crawl..." [core] - 10https://gerrit.wikimedia.org/r/137915 (owner: 10Kunalgrover05) [16:17:05] <wikibugs> 3Wikimedia / 3General/Unknown: nds.wiktionary.org Scripterror by moduls timerunout - 10https://bugzilla.wikimedia.org/68304#c6 (10Joachim Mos) @TeleComNasSprVen What's in your head, that you make changes in our Modul:link Now, after that, every of our Translations look so: Afrikaansch: Skriptfehler Albaan... [16:19:14] <multichill|work> qgil: What's the hangout url? [16:21:51] <wikibugs> 3Wikimedia / 3General/Unknown: nds.wiktionary.org Scripterror by moduls timerunout - 10https://bugzilla.wikimedia.org/68304#c7 (10Marius Hoch) Please calm down ... he only wanted to help you resolve your Lua issues, that's not a reason to block him. Assume good faith, please. [16:21:54] <qgil> multichill|work, creating it right now [16:22:50] <qgil> multichill|work, does https://plus.google.com/hangouts/_/hoaevent/AP36tYc_6ptC4S696IhcxcUmWkYjmazQ2S70LidHSP-tZW1tgKCatQ?authuser=0&eid=103470172168784626509&hl=en work for you? [16:24:28] <qgil> multichill|work, should work. sent to participants via email [16:32:20] <wikibugs> 3Wikimedia / 3Bugzilla: Reorganize "Wikipedia Apps" product - 10https://bugzilla.wikimedia.org/64621#c23 (10Dan Garry) (In reply to Andre Klapper from comment #22) > Yuvi, Bernd, Dan: ping I'd prefer one of the engineers to answer this with what they prefer, since Bugzilla is primarily for them. [16:38:17] <grrrit-wm> (03CR) 10Alex Monk: "Am I missing something here or is this not actually deprecated...? You might be thinking of tooltipAccessKeyPrefix and tooltipAccessKeyReg" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/138890 (owner: 10Gerrit Patch Uploader) [16:40:50] <wikibugs> 3Wikimedia / 3General/Unknown: nds.wiktionary.org Scripterror by moduls timerunout - 10https://bugzilla.wikimedia.org/68304#c8 (10Joachim Mos) I know, that he want to help, so only two weeks, if I would think, it would boycott us or somethink else like this, I would block him forever. But it is not possibl... [16:49:08] <grrrit-wm> (03CR) 10Jforrester: [C: 032] "Quite the rebase!" [core] - 10https://gerrit.wikimedia.org/r/127423 (owner: 10KartikMistry) [16:53:45] <grrrit-wm> (03Merged) 10jenkins-bot: oojs update scripts: Use quotes to prevent globbing and word splitting [core] - 10https://gerrit.wikimedia.org/r/127423 (owner: 10KartikMistry) [16:56:08] <grrrit-wm> (03PS2) 10Jforrester: maintenance: Update comment in the OOjs UI pull through script [core] - 10https://gerrit.wikimedia.org/r/145860 [16:56:24] <grrrit-wm> (03CR) 10Jforrester: "PS2 is a rebase." [core] - 10https://gerrit.wikimedia.org/r/145860 (owner: 10Jforrester) [16:56:51] <wikibugs> 3MediaWiki extensions / 3Cite: Add warning message when <references> is not closed correctly - 10https://bugzilla.wikimedia.org/26145 (10Jesús Martínez Novo (Ciencia Al Poder)) [16:56:51] <wikibugs> 3MediaWiki extensions / 3Cite: Error generation of unbalanced <ref><references/>: No error is shown if missing </ref>-tag is the last ref tag - 10https://bugzilla.wikimedia.org/15712#c5 (10Jesús Martínez Novo (Ciencia Al Poder)) (In reply to Duncan Harris from comment #2) > the sequence "<ref><references/>"... [16:59:38] <grrrit-wm> (03PS14) 10Jack Phoenix: New class for parsing MediaWiki:Sidebar-like messages into modern, nested navigation menus. [core] - 10https://gerrit.wikimedia.org/r/108045 [17:01:54] <grrrit-wm> (03CR) 10Alex Monk: [C: 032] maintenance: Update comment in the OOjs UI pull through script [core] - 10https://gerrit.wikimedia.org/r/145860 (owner: 10Jforrester) [17:02:09] <grrrit-wm> (03PS2) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/148062 [17:03:59] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] New class for parsing MediaWiki:Sidebar-like messages into modern, nested navigation menus. [core] - 10https://gerrit.wikimedia.org/r/108045 (owner: 10Jack Phoenix) [17:04:50] <grrrit-wm> (03CR) 10EBernhardson: [C: 032] Redirect old-style permalinks to new ones. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147554 (https://bugzilla.wikimedia.org/68224) (owner: 10Werdna) [17:05:14] <grrrit-wm> (03Merged) 10jenkins-bot: maintenance: Update comment in the OOjs UI pull through script [core] - 10https://gerrit.wikimedia.org/r/145860 (owner: 10Jforrester) [17:05:43] <grrrit-wm> (03Merged) 10jenkins-bot: Redirect old-style permalinks to new ones. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147554 (https://bugzilla.wikimedia.org/68224) (owner: 10Werdna) [17:06:20] <wikibugs> 3MediaWiki / 3Special pages: Postgresql: non-integer constant in ORDER BY - 10https://bugzilla.wikimedia.org/67594 (10Jesús Martínez Novo (Ciencia Al Poder)) [17:07:21] <grrrit-wm> (03PS1) 10EBernhardson: Redirect old-style permalinks to new ones. [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148105 (https://bugzilla.wikimedia.org/68224) [17:08:02] <grrrit-wm> (03PS1) 10EBernhardson: Fix re-open topic [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148106 [17:11:03] <grrrit-wm> (03PS1) 10Florianschmidtwelzow: WIP: Extended Login-workflow [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/148108 (https://bugzilla.wikimedia.org/68317) [17:12:20] <grrrit-wm> (03PS1) 10EBernhardson: Repair reopen topic action [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148109 (https://bugzilla.wikimedia.org/68172) [17:13:46] <grrrit-wm> (03PS1) 10EBernhardson: Restore previous behavior of Reference::makeTitle [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148110 (https://bugzilla.wikimedia.org/68225) [17:14:34] <grrrit-wm> (03PS1) 10Jack Phoenix: Initial support for displaying subpages (and the like) in the UI. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/148111 [17:14:55] <grrrit-wm> (03CR) 10Jack Phoenix: [C: 032 V: 032] Initial support for displaying subpages (and the like) in the UI. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/148111 (owner: 10Jack Phoenix) [17:19:30] <grrrit-wm> (03PS1) 10BryanDavis: Disable ssh host key checking for command and control [tools/scap] - 10https://gerrit.wikimedia.org/r/148112 [17:19:44] <grrrit-wm> (03CR) 10Jdlrobson: [C: 032] Support for enabling skins in the installer [core] - 10https://gerrit.wikimedia.org/r/138652 (https://bugzilla.wikimedia.org/66440) (owner: 10Bartosz Dziewoński) [17:20:47] <grrrit-wm> (03CR) 10BryanDavis: "Applied via cherry-pick on deployment-bastion" [tools/scap] - 10https://gerrit.wikimedia.org/r/148112 (owner: 10BryanDavis) [17:22:01] <grrrit-wm> (03CR) 10BryanDavis: [C: 032] "Tested via cherry-pick on deployment-prep. Scap continued to work as expected." [tools/scap] - 10https://gerrit.wikimedia.org/r/147317 (owner: 10Ori.livneh) [17:22:28] <grrrit-wm> (03Merged) 10jenkins-bot: Don't hard-code path to scap scripts; rely on $PATH instead [tools/scap] - 10https://gerrit.wikimedia.org/r/147317 (owner: 10Ori.livneh) [17:23:27] <grrrit-wm> (03Merged) 10jenkins-bot: Support for enabling skins in the installer [core] - 10https://gerrit.wikimedia.org/r/138652 (https://bugzilla.wikimedia.org/66440) (owner: 10Bartosz Dziewoński) [17:26:00] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/148108 (https://bugzilla.wikimedia.org/68317) (owner: 10Florianschmidtwelzow) [17:28:45] <grrrit-wm> (03PS3) 10tosfos: rework code, gcs script version 2, show on SpecialSearch [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/145213 [17:31:50] <wikibugs> 3Wikimedia / 3General/Unknown: nds.wiktionary.org Scripterror by moduls timerunout - 10https://bugzilla.wikimedia.org/68304#c9 (10Joachim Mos) I wait one day, if you than want not to help us, I look, who is willing helping us, what here is written, what can be do, to have no errors, in nothing, what is helpf... [17:32:54] <grrrit-wm> (03CR) 10tosfos: [C: 031 V: 032] rework code, gcs script version 2, show on SpecialSearch [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/145213 (owner: 10tosfos) [17:34:50] <grrrit-wm> (03CR) 10Florianschmidtwelzow: [C: 032] Updated README [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/148054 (owner: 10Florianschmidtwelzow) [17:34:55] <grrrit-wm> (03Merged) 10jenkins-bot: Updated README [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/148054 (owner: 10Florianschmidtwelzow) [17:35:14] <grrrit-wm> (03CR) 10MaxSem: Fix race condition in wfShellExec() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/147635 (https://bugzilla.wikimedia.org/67870) (owner: 10MaxSem) [17:36:20] <grrrit-wm> (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/148092 (https://bugzilla.wikimedia.org/68126) (owner: 10Lekshmi) [17:36:29] <grrrit-wm> (03Abandoned) 10BryanDavis: Add redisjobqueue role [vagrant] - 10https://gerrit.wikimedia.org/r/88006 (owner: 10Legoktm) [17:38:08] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Link badge icons to Special:SetSiteLink from the sitelink UI - 10https://bugzilla.wikimedia.org/68152 (10Marius Hoch) 5PATC>3RESO/FIX [17:38:20] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: remove badges when changing the sitelink on the repo - 10https://bugzilla.wikimedia.org/68155 (10Marius Hoch) [17:38:31] <MaxSem> Nikerabbit, can you guys please take a look at https://bugzilla.wikimedia.org/show_bug.cgi?id=67295 ? we really need to be ready for HHVM and I'm lost in what this stuff does so couldn't fix it myself [17:39:52] <grrrit-wm> (03CR) 10BryanDavis: "tonythomas: can this patch be abandoned?" [core/vendor] - 10https://gerrit.wikimedia.org/r/137538 (owner: 1001tonythomas) [17:41:09] <grrrit-wm> (03CR) 10BryanDavis: "tonythomas: Can this patch be abandoned?" [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [17:43:02] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TimedMediaHandler] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148091 (owner: 10Brian Wolff) [17:43:40] <grrrit-wm> (03CR) 10EBernhardson: [C: 032] Restore previous behavior of Reference::makeTitle [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148110 (https://bugzilla.wikimedia.org/68225) (owner: 10EBernhardson) [17:43:53] <grrrit-wm> (03CR) 10EBernhardson: [C: 032] Repair reopen topic action [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148109 (https://bugzilla.wikimedia.org/68172) (owner: 10EBernhardson) [17:44:03] <grrrit-wm> (03CR) 10EBernhardson: [C: 032] Fix re-open topic [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148106 (owner: 10EBernhardson) [17:44:06] <grrrit-wm> (03PS1) 10Jack Phoenix: LESS implementations of various PHP-side hacks. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/148119 [17:44:13] <grrrit-wm> (03Merged) 10jenkins-bot: Restore previous behavior of Reference::makeTitle [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148110 (https://bugzilla.wikimedia.org/68225) (owner: 10EBernhardson) [17:44:17] <grrrit-wm> (03CR) 10EBernhardson: [C: 032] Redirect old-style permalinks to new ones. [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148105 (https://bugzilla.wikimedia.org/68224) (owner: 10EBernhardson) [17:44:25] <grrrit-wm> (03Merged) 10jenkins-bot: Repair reopen topic action [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148109 (https://bugzilla.wikimedia.org/68172) (owner: 10EBernhardson) [17:44:45] <grrrit-wm> (03Merged) 10jenkins-bot: Fix re-open topic [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148106 (owner: 10EBernhardson) [17:44:56] <grrrit-wm> (03Merged) 10jenkins-bot: Redirect old-style permalinks to new ones. [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148105 (https://bugzilla.wikimedia.org/68224) (owner: 10EBernhardson) [17:45:47] <grrrit-wm> (03CR) 10Jack Phoenix: [C: 032 V: 032] LESS implementations of various PHP-side hacks. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/148119 (owner: 10Jack Phoenix) [17:46:32] <Nikerabbit> MaxSem: is there are an easy way to reproduce it [17:46:43] <grrrit-wm> (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148055 (owner: 10Smuggli) [17:47:11] <Nikerabbit> if I can figure it out in couple of hours I can try, but if it takes longer I will defer to our PM as I'm on vacation [17:47:14] <MaxSem> Nikerabbit, yes - just install Translate with CirrusSearch and php phpunit.php --testsuite extensions [17:47:57] <Nikerabbit> MaxSem: ok I'll try [17:48:02] <MaxSem> thanks [17:48:35] <grrrit-wm> (03PS2) 10Chad: Remove old maintenance script importTextFile.php [core] - 10https://gerrit.wikimedia.org/r/147877 (owner: 10Withoutaname) [17:48:59] <grrrit-wm> (03CR) 10Esanders: [C: 032] Update OOjs UI to v0.1.0-pre (5ab041a801) [core] - 10https://gerrit.wikimedia.org/r/147852 (owner: 10Jforrester) [17:51:20] <Nikerabbit> MaxSem: does it happen in vagrant? I'm afraid my dev wiki has too many extensions to be able to run tests at all ;) [17:51:23] <grrrit-wm> (03CR) 10Jamesmontalvo3: "I ran stylize.php and made changes per your comments. My responses below. Unfortunately I cannot amend the patch from my current location." [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [17:51:40] <MaxSem> Nikerabbit, yes - that''s what I'm usng [17:51:47] <Nikerabbit> MaxSem: ok cool [17:53:45] <grrrit-wm> (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (5ab041a801) [core] - 10https://gerrit.wikimedia.org/r/147852 (owner: 10Jforrester) [17:55:51] <wikibugs> 3Wikimedia / 3General/Unknown: nds.wiktionary.org Scripterror by moduls timerunout - 10https://bugzilla.wikimedia.org/68304#c10 (10TeleComNasSprVen) (In reply to Joachim Mos from comment #9) > I wait one day, if you than want not to help us, I look, who is willing > helping us, what here is written, what can... [17:56:26] <grrrit-wm> (03CR) 10Jdlrobson: [C: 031] "Will allow others more time to look at it." [core] - 10https://gerrit.wikimedia.org/r/141259 (owner: 10Bartosz Dziewoński) [17:57:24] <grrrit-wm> (03PS14) 10Bartosz Dziewoński: resourceloader: Allow skins to provide additional styles for any module [core] - 10https://gerrit.wikimedia.org/r/141259 [17:57:41] <grrrit-wm> (03CR) 10Bartosz Dziewoński: "(Rebased.)" [core] - 10https://gerrit.wikimedia.org/r/141259 (owner: 10Bartosz Dziewoński) [17:57:55] <grrrit-wm> (03CR) 10Ebe123: [C: 031] "Looks good." [extensions/Score] - 10https://gerrit.wikimedia.org/r/62243 (https://bugzilla.wikimedia.org/47578) (owner: 10Brion VIBBER) [17:59:37] <wikibugs> 3MediaWiki / 3Skin and page rendering: Core skins should initialise and include like other skins/extensions do - 10https://bugzilla.wikimedia.org/60453#c2 (10Bartosz Dziewoński) 5NEW>3RESO/FIX a:3Bartosz Dziewoński I'm going to mark this as FIXED for now. There is more work that can be done to make the... [17:59:46] <grrrit-wm> (03CR) 10Withoutaname: Action: Merge getClass() into factory() and kill $wgActions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/145247 (owner: 10Withoutaname) [18:02:06] <wikibugs> 3MediaWiki / 3Installer: Add support for enabling skins in the installer, the way we handle extensions - 10https://bugzilla.wikimedia.org/66440#c4 (10Bartosz Dziewoński) 5PATC>3RESO/FIX Yay! [18:05:43] <grrrit-wm> (03Abandoned) 10Bartosz Dziewoński: Added mediawiki.notification styles [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/145871 (owner: 10Bartosz Dziewoński) [18:06:13] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/147513 (owner: 10Gerrit Patch Uploader) [18:07:19] <grrrit-wm> (03CR) 10Parent5446: Action: Merge getClass() into factory() and kill $wgActions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/145247 (owner: 10Withoutaname) [18:07:31] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/148012 (owner: 10PleaseStand) [18:07:35] <wikibugs> 3MediaWiki / 3Skin and page rendering: Deprecate and remove skin autodiscovery (autoloading) mechanism - 10https://bugzilla.wikimedia.org/65748#c12 (10Bartosz Dziewoński) All done other than actually removing skin autodiscovery, which is waiting for 1.24 to be branched (https://gerrit.wikimedia.org/r/135439). [18:08:02] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [18:08:21] <MatmaRex> jdlrobson: thanks! [18:09:24] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102076 (https://bugzilla.wikimedia.org/57727) (owner: 10TTO) [18:10:06] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/146440 (https://bugzilla.wikimedia.org/4488) (owner: 10Ebe123) [18:10:27] <grrrit-wm> (03CR) 10Yaron Koren: [C: 032 V: 032] "Looks good!" [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/147513 (owner: 10Gerrit Patch Uploader) [18:10:34] <grrrit-wm> (03CR) 10Siebrand: "Thanks, Shirayuki." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/147894 (owner: 10Shirayuki) [18:11:41] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/146053 (owner: 10Umherirrender) [18:13:51] <grrrit-wm> (03CR) 10Siebrand: [C: 032] Reformat function chains in FileTest.php [core] - 10https://gerrit.wikimedia.org/r/147674 (owner: 10Umherirrender) [18:14:45] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [skins/Example] - 10https://gerrit.wikimedia.org/r/147690 (owner: 10Bartosz Dziewoński) [18:16:59] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 032] "OK, let's do this already. Further tweaks welcome, especially if they're accompanied by updates to the Manual:Skinning page :)" [skins/Example] - 10https://gerrit.wikimedia.org/r/147690 (owner: 10Bartosz Dziewoński) [18:17:26] <grrrit-wm> (03CR) 10Chad: [C: 032] Remove old maintenance script importTextFile.php [core] - 10https://gerrit.wikimedia.org/r/147877 (owner: 10Withoutaname) [18:17:28] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [V: 032] Example skin [skins/Example] - 10https://gerrit.wikimedia.org/r/147690 (owner: 10Bartosz Dziewoński) [18:17:44] <grrrit-wm> (03Merged) 10jenkins-bot: Reformat function chains in FileTest.php [core] - 10https://gerrit.wikimedia.org/r/147674 (owner: 10Umherirrender) [18:18:34] <grrrit-wm> (03CR) 10Chad: [C: 032] Remove Fallback::iconv() [core] - 10https://gerrit.wikimedia.org/r/148012 (owner: 10PleaseStand) [18:19:07] <grrrit-wm> (03PS7) 10Ebe123: Create preferences to watchlist pages after rollbacking and undoing [core] - 10https://gerrit.wikimedia.org/r/146440 (https://bugzilla.wikimedia.org/4488) [18:19:07] <grrrit-wm> (03CR) 10Chad: [C: 032] WebInstaller::setVarsFromRequest() do not trim passwords [core] - 10https://gerrit.wikimedia.org/r/145859 (https://bugzilla.wikimedia.org/30524) (owner: 10Taueres) [18:19:55] <grrrit-wm> (03CR) 10Chad: "Shouldn't we wrap this in something like function_exists()?" [extensions/OAI] - 10https://gerrit.wikimedia.org/r/147337 (owner: 10Withoutaname) [18:20:51] <grrrit-wm> (03Merged) 10jenkins-bot: Remove old maintenance script importTextFile.php [core] - 10https://gerrit.wikimedia.org/r/147877 (owner: 10Withoutaname) [18:21:42] <grrrit-wm> (03CR) 10Kaldari: [C: 032] Disable ArticleMetadataTest [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/147545 (https://bugzilla.wikimedia.org/67615) (owner: 10MaxSem) [18:22:25] <grrrit-wm> (03Merged) 10jenkins-bot: Remove Fallback::iconv() [core] - 10https://gerrit.wikimedia.org/r/148012 (owner: 10PleaseStand) [18:22:44] <grrrit-wm> (03PS9) 10Jdlrobson: Stop using a suboptimal structure for Vector's variants menu [core] - 10https://gerrit.wikimedia.org/r/138368 (https://bugzilla.wikimedia.org/43406) (owner: 10Bartosz Dziewoński) [18:22:50] <grrrit-wm> (03CR) 10Jdlrobson: Stop using a suboptimal structure for Vector's variants menu (031 comment) [core] - 10https://gerrit.wikimedia.org/r/138368 (https://bugzilla.wikimedia.org/43406) (owner: 10Bartosz Dziewoński) [18:22:55] <grrrit-wm> (03CR) 10Jdlrobson: [C: 032] Stop using a suboptimal structure for Vector's variants menu [core] - 10https://gerrit.wikimedia.org/r/138368 (https://bugzilla.wikimedia.org/43406) (owner: 10Bartosz Dziewoński) [18:23:12] <grrrit-wm> (03Merged) 10jenkins-bot: Disable ArticleMetadataTest [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/147545 (https://bugzilla.wikimedia.org/67615) (owner: 10MaxSem) [18:24:27] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/146440 (https://bugzilla.wikimedia.org/4488) (owner: 10Ebe123) [18:24:38] <grrrit-wm> (03Merged) 10jenkins-bot: WebInstaller::setVarsFromRequest() do not trim passwords [core] - 10https://gerrit.wikimedia.org/r/145859 (https://bugzilla.wikimedia.org/30524) (owner: 10Taueres) [18:25:00] <grrrit-wm> (03CR) 10Siebrand: "I see this repo doesn't have jenkins set up yet. Create an issue for that?" [skins/Example] - 10https://gerrit.wikimedia.org/r/147690 (owner: 10Bartosz Dziewoński) [18:26:22] <grrrit-wm> (03CR) 10Kaldari: [C: 04-1] Add UserMergeAccountFields hook subscriber (031 comment) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/145217 (https://bugzilla.wikimedia.org/67782) (owner: 10Legoktm) [18:26:31] <grrrit-wm> (03CR) 10Siebrand: Add support for enabling and displaying global interwikis (032 comments) [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147755 (https://bugzilla.wikimedia.org/68241) (owner: 10Isarra) [18:26:58] <grrrit-wm> (03CR) 10Siebrand: "You should add attribution if you copied the translations." [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/147736 (owner: 10Paladox) [18:27:05] <grrrit-wm> (03CR) 10Siebrand: [C: 04-1] Localisation updates. [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/147736 (owner: 10Paladox) [18:27:28] <grrrit-wm> (03PS1) 10MaxSem: MobileFrontend: pick https://gerrit.wikimedia.org/r/#/c/147756/ [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148128 [18:27:50] <grrrit-wm> (03CR) 10Withoutaname: "I can do if !function_exists( 'xmlsafe' ) function xmlsafe() {} but I don't know if there are any preexisting functions called xmlsafe." [extensions/OAI] - 10https://gerrit.wikimedia.org/r/147337 (owner: 10Withoutaname) [18:28:51] <grrrit-wm> (03CR) 10Aaron Schulz: [C: 032] Allow wildcard searching in wiki IDs for interwiki user rights logs [core] - 10https://gerrit.wikimedia.org/r/48661 (https://bugzilla.wikimedia.org/10545) (owner: 10Alex Monk) [18:30:11] <grrrit-wm> (03Merged) 10jenkins-bot: Stop using a suboptimal structure for Vector's variants menu [core] - 10https://gerrit.wikimedia.org/r/138368 (https://bugzilla.wikimedia.org/43406) (owner: 10Bartosz Dziewoński) [18:30:53] <grrrit-wm> (03CR) 10Bartosz Dziewoński: "That's bug 66926." [skins/Example] - 10https://gerrit.wikimedia.org/r/147690 (owner: 10Bartosz Dziewoński) [18:33:08] <grrrit-wm> (03CR) 10Jdlrobson: "Hey Tyler, are you able to pick this up and give it a 2nd shot?" [core] - 10https://gerrit.wikimedia.org/r/146643 (https://bugzilla.wikimedia.org/15484) (owner: 10Bartosz Dziewoński) [18:36:26] <grrrit-wm> (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/147496 (https://bugzilla.wikimedia.org/59736) (owner: 10Rohan013) [18:37:49] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/146786 (owner: 10Smuggli) [18:38:19] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [18:38:58] <grrrit-wm> (03CR) 10Siebrand: "Excellent :)." [skins/Example] - 10https://gerrit.wikimedia.org/r/147690 (owner: 10Bartosz Dziewoński) [18:39:27] <grrrit-wm> (03Merged) 10jenkins-bot: Allow wildcard searching in wiki IDs for interwiki user rights logs [core] - 10https://gerrit.wikimedia.org/r/48661 (https://bugzilla.wikimedia.org/10545) (owner: 10Alex Monk) [18:41:20] <grrrit-wm> (03PS1) 10Hashar: php lint jobs for MediaWiki skins [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/148130 (https://bugzilla.wikimedia.org/66926) [18:43:25] <grrrit-wm> (03CR) 10Aaron Schulz: [C: 032] Remove deprecated RawPage class [core] - 10https://gerrit.wikimedia.org/r/147052 (owner: 10Withoutaname) [18:43:59] <grrrit-wm> (03Abandoned) 1001tonythomas: Shifted from PEAR/PHP mailer to Swift Mailer [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [18:44:11] <grrrit-wm> (03PS32) 10MarkTraceur: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) [18:44:33] <grrrit-wm> (03PS33) 10MarkTraceur: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) [18:46:34] <grrrit-wm> (03CR) 1001tonythomas: "Abandoning in favor of I7de5a4228a34b2d56d5ed8f0d9e48a6066012e41. The class is added via composer, and the Wikimedia fork of SwiftMailer i" [core/vendor] - 10https://gerrit.wikimedia.org/r/137538 (owner: 1001tonythomas) [18:47:00] <grrrit-wm> (03Abandoned) 1001tonythomas: Added swiftmailer 5.2.0 from Wikimedia Fork [core/vendor] - 10https://gerrit.wikimedia.org/r/137538 (owner: 1001tonythomas) [18:47:18] <grrrit-wm> (03Merged) 10jenkins-bot: Remove deprecated RawPage class [core] - 10https://gerrit.wikimedia.org/r/147052 (owner: 10Withoutaname) [18:47:22] <grrrit-wm> (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/146428 (owner: 10Smuggli) [18:48:09] <grrrit-wm> (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/147403 (owner: 10Smuggli) [18:49:02] <grrrit-wm> (03CR) 10Siebrand: "Leaving this to the parser function gurus... Not sure if we want this on every page." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/147505 (https://bugzilla.wikimedia.org/65993) (owner: 10Nemo bis) [18:50:14] <grrrit-wm> (03CR) 10Ori.livneh: Fix race condition in wfShellExec() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/147635 (https://bugzilla.wikimedia.org/67870) (owner: 10MaxSem) [18:50:20] <grrrit-wm> (03PS2) 10Hashar: php lint jobs for MediaWiki skins [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/148130 (https://bugzilla.wikimedia.org/66926) [18:50:46] <grrrit-wm> (03CR) 10Hashar: "Keeps camelcasing" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/148130 (https://bugzilla.wikimedia.org/66926) (owner: 10Hashar) [18:50:51] <wikibugs> 3MediaWiki / 3Installer: Add support for enabling skins in the installer, the way we handle extensions - 10https://bugzilla.wikimedia.org/66440 (10Bartosz Dziewoński) [18:50:53] <wikibugs> 3MediaWiki / 3Installer: Make it possible to render the installer with any skin, or preview skins in the installer - 10https://bugzilla.wikimedia.org/68331 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None :o We should make it possible to render the installer with any skin, or preview skins in... [18:52:18] <grrrit-wm> (03CR) 10MaxSem: Fix race condition in wfShellExec() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/147635 (https://bugzilla.wikimedia.org/67870) (owner: 10MaxSem) [18:54:44] <grrrit-wm> (03CR) 10Ori.livneh: Fix race condition in wfShellExec() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/147635 (https://bugzilla.wikimedia.org/67870) (owner: 10MaxSem) [18:55:30] <grrrit-wm> (03PS4) 10Aaron Schulz: Fixed JobQueueAggregatorRedis to handle empty collections [core] - 10https://gerrit.wikimedia.org/r/146597 [18:56:00] <grrrit-wm> (03CR) 10MaxSem: Fix race condition in wfShellExec() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/147635 (https://bugzilla.wikimedia.org/67870) (owner: 10MaxSem) [18:57:07] <grrrit-wm> (03PS2) 1001tonythomas: Removed Count column from Special:Statistics Table [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/116094 (https://bugzilla.wikimedia.org/56878) [18:58:48] <grrrit-wm> (03PS1) 10Umherirrender: Fixed some @params documentation (includes/utils) [core] - 10https://gerrit.wikimedia.org/r/148132 [19:00:46] <grrrit-wm> (03PS1) 10Aaron Schulz: Set serializer to NONE and bumped the aggregation keys [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148134 [19:02:38] <wikibugs> 3MediaWiki / 3Skin and page rendering: Create a tiny fallback skin to use when no proper skins are present - 10https://bugzilla.wikimedia.org/68332 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None Create a tiny fallback skin to use when no proper skins are present. The skin should show a big... [19:02:51] <wikibugs> 3MediaWiki / 3Installer: Cannot install mediawiki when database admin user password ends with spaces - 10https://bugzilla.wikimedia.org/30524 (10Sergio Santoro) 5PATC>3RESO/FIX [19:02:52] <wikibugs> 3MediaWiki / 3General/Unknown: Move all four core skins to separate repositories and include them in the tarball - 10https://bugzilla.wikimedia.org/68333 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None As per my GSoC project ([[mw:Separating skins from core MediaWiki]]), let's move all four c... [19:03:07] <wikibugs> 3MediaWiki extensions / 3Translate: [twn] Support gerrit repos in mediawiki/skins - 10https://bugzilla.wikimedia.org/65040 (10Bartosz Dziewoński) [19:03:07] <wikibugs> 3MediaWiki / 3Skin and page rendering: Core skins should initialise and include like other skins/extensions do - 10https://bugzilla.wikimedia.org/60453 (10Bartosz Dziewoński) [19:03:07] <wikibugs> 3MediaWiki / 3Skin and page rendering: Create a tiny fallback skin to use when no proper skins are present - 10https://bugzilla.wikimedia.org/68332 (10Bartosz Dziewoński) [19:03:32] <MatmaRex> greg-g: hey, is there anyone i could ask about https://bugzilla.wikimedia.org/show_bug.cgi?id=68333 while we (still) don't have release managers? [19:03:48] <grrrit-wm> (03PS13) 10Ori.livneh: Redo WhatLinksHere query and add a *_from_namespace field to link tables [core] - 10https://gerrit.wikimedia.org/r/117373 (https://bugzilla.wikimedia.org/60618) (owner: 10Aaron Schulz) [19:04:51] <grrrit-wm> (03PS1) 10MaxSem: Make PageTriage tests voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148135 (https://bugzilla.wikimedia.org/68205) [19:05:02] <grrrit-wm> (03PS1) 10Hashar: phplint jobs for MediaWiki skins [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148136 (https://bugzilla.wikimedia.org/66926) [19:05:07] <grrrit-wm> (03PS14) 10Ori.livneh: Redo WhatLinksHere query and add a *_from_namespace field to link tables [core] - 10https://gerrit.wikimedia.org/r/117373 (https://bugzilla.wikimedia.org/60618) (owner: 10Aaron Schulz) [19:05:24] <grrrit-wm> (03CR) 10Ori.livneh: [C: 032] Redo WhatLinksHere query and add a *_from_namespace field to link tables [core] - 10https://gerrit.wikimedia.org/r/117373 (https://bugzilla.wikimedia.org/60618) (owner: 10Aaron Schulz) [19:07:52] <grrrit-wm> (03CR) 10Hashar: [C: 032] phplint jobs for MediaWiki skins [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148136 (https://bugzilla.wikimedia.org/66926) (owner: 10Hashar) [19:08:03] <grrrit-wm> (03Merged) 10jenkins-bot: phplint jobs for MediaWiki skins [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148136 (https://bugzilla.wikimedia.org/66926) (owner: 10Hashar) [19:08:10] <grrrit-wm> (03PS3) 10Hashar: phplint jobs for MediaWiki skins [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/148130 (https://bugzilla.wikimedia.org/66926) [19:10:24] <grrrit-wm> (03Merged) 10jenkins-bot: Redo WhatLinksHere query and add a *_from_namespace field to link tables [core] - 10https://gerrit.wikimedia.org/r/117373 (https://bugzilla.wikimedia.org/60618) (owner: 10Aaron Schulz) [19:11:06] <grrrit-wm> (03PS1) 10Bartosz Dziewoński: mediawiki.page.watch.ajax: Remove #bodyContent, #content restriction on the link [core] - 10https://gerrit.wikimedia.org/r/148139 [19:15:22] <wikibugs> 3Wikimedia / 3Git/Gerrit: Upgrade gerrit to 2.8.5 or 2.9 - 10https://bugzilla.wikimedia.org/63847#c2 (10christian) Upgrade to gerrit 2.9 got WONTFIXed at bug 68271. So, I doubt that 2.9 will happen soon for us. gerrit 2.8.x would be easier, but if we upgrade, we should rather use >= 2.8.6 since it had the S... [19:15:37] <grrrit-wm> (03PS1) 10Hashar: .gitreview file [skins/Mask] - 10https://gerrit.wikimedia.org/r/148141 [19:15:39] <grrrit-wm> (03PS1) 10Hashar: Drop executable mode from php/css files [skins/Mask] - 10https://gerrit.wikimedia.org/r/148142 [19:15:54] <grrrit-wm> (03CR) 10Hashar: [C: 032] .gitreview file [skins/Mask] - 10https://gerrit.wikimedia.org/r/148141 (owner: 10Hashar) [19:15:56] <grrrit-wm> (03Merged) 10jenkins-bot: .gitreview file [skins/Mask] - 10https://gerrit.wikimedia.org/r/148141 (owner: 10Hashar) [19:16:02] <grrrit-wm> (03CR) 10Hashar: [C: 032] Drop executable mode from php/css files [skins/Mask] - 10https://gerrit.wikimedia.org/r/148142 (owner: 10Hashar) [19:16:04] <grrrit-wm> (03Merged) 10jenkins-bot: Drop executable mode from php/css files [skins/Mask] - 10https://gerrit.wikimedia.org/r/148142 (owner: 10Hashar) [19:16:11] <grrrit-wm> (03PS1) 10Parent5446: Make UserNotLoggedIn redirect to login page [core] - 10https://gerrit.wikimedia.org/r/148144 (https://bugzilla.wikimedia.org/15484) [19:16:32] <grrrit-wm> (03CR) 10Parent5446: "Take Two: https://gerrit.wikimedia.org/r/148144" [core] - 10https://gerrit.wikimedia.org/r/146643 (https://bugzilla.wikimedia.org/15484) (owner: 10Bartosz Dziewoński) [19:16:53] * hashar spams [19:16:58] <grrrit-wm> (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/148146 [19:17:01] <grrrit-wm> (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/148147 [19:17:05] <grrrit-wm> (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/148148 [19:17:07] <grrrit-wm> (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/Example] - 10https://gerrit.wikimedia.org/r/148149 [19:17:10] <grrrit-wm> (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/148150 [19:17:13] <grrrit-wm> (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins] - 10https://gerrit.wikimedia.org/r/148151 [19:17:17] <grrrit-wm> (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/Mask] - 10https://gerrit.wikimedia.org/r/148152 [19:17:20] <grrrit-wm> (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/Modern] - 10https://gerrit.wikimedia.org/r/148153 [19:17:23] <grrrit-wm> (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/148154 [19:17:26] <grrrit-wm> (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/148155 [19:18:10] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/148154 (owner: 10Hashar) [19:18:22] <grrrit-wm> (03CR) 10Parent5446: [C: 04-1] "* Usability regression: the user is not informed *why* they were" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/148144 (https://bugzilla.wikimedia.org/15484) (owner: 10Parent5446) [19:18:55] <grrrit-wm> (03CR) 10Hashar: "recheck" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/148154 (owner: 10Hashar) [19:19:59] <grrrit-wm> (03CR) 10Hashar: "recheck" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/148154 (owner: 10Hashar) [19:20:22] <grrrit-wm> (03PS1) 10Umherirrender: Add since to @deprecated in includes/site [core] - 10https://gerrit.wikimedia.org/r/148156 [19:21:07] <grrrit-wm> (03PS4) 10Hashar: php lint jobs for MediaWiki skins [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/148130 (https://bugzilla.wikimedia.org/66926) [19:21:51] <MatmaRex> anyone wanna merge a very trivial change? https://gerrit.wikimedia.org/r/#/c/147901/ [19:21:56] <grrrit-wm> (03CR) 10Hashar: "recheck" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/148154 (owner: 10Hashar) [19:21:58] <MatmaRex> it was merged before and i accidentally reverted it :P [19:22:27] <grrrit-wm> (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/148154 (owner: 10Hashar) [19:22:55] <grrrit-wm> (03PS1) 10Chad: Include tidy for more unit testiness [vagrant] - 10https://gerrit.wikimedia.org/r/148157 [19:23:15] <grrrit-wm> (03CR) 10Chad: "This gets 6 more tests passing for me under HHVM that were being skipped." [vagrant] - 10https://gerrit.wikimedia.org/r/148157 (owner: 10Chad) [19:23:19] <grrrit-wm> (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins] - 10https://gerrit.wikimedia.org/r/148151 (owner: 10Hashar) [19:23:20] <wikibugs> 3Wikimedia / 3Git/Gerrit: Upgrade gerrit to 2.8.5+ - 10https://bugzilla.wikimedia.org/63847#c3 (10Nemo) (In reply to christian from comment #2) > Upgrade to gerrit 2.9 got WONTFIXed at bug 68271. > So, I doubt that 2.9 will happen soon for us. Ah ok, reducing scope of this bug again. [19:23:22] <grrrit-wm> (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/148146 (owner: 10Hashar) [19:23:26] <grrrit-wm> (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/148147 (owner: 10Hashar) [19:23:29] <grrrit-wm> (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/148148 (owner: 10Hashar) [19:23:33] <grrrit-wm> (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/Example] - 10https://gerrit.wikimedia.org/r/148149 (owner: 10Hashar) [19:23:36] <grrrit-wm> (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/148150 (owner: 10Hashar) [19:23:39] <grrrit-wm> (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/Mask] - 10https://gerrit.wikimedia.org/r/148152 (owner: 10Hashar) [19:23:43] <grrrit-wm> (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/Modern] - 10https://gerrit.wikimedia.org/r/148153 (owner: 10Hashar) [19:23:52] <grrrit-wm> (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/148155 (owner: 10Hashar) [19:24:10] <grrrit-wm> (03PS5) 10Hashar: phplint jobs for MediaWiki skins [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/148130 (https://bugzilla.wikimedia.org/66926) [19:24:26] <grrrit-wm> (03CR) 10Hashar: [C: 032] phplint jobs for MediaWiki skins [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/148130 (https://bugzilla.wikimedia.org/66926) (owner: 10Hashar) [19:24:32] <grrrit-wm> (03CR) 10BryanDavis: [C: 032] Include tidy for more unit testiness [vagrant] - 10https://gerrit.wikimedia.org/r/148157 (owner: 10Chad) [19:24:39] <grrrit-wm> (03Merged) 10jenkins-bot: Include tidy for more unit testiness [vagrant] - 10https://gerrit.wikimedia.org/r/148157 (owner: 10Chad) [19:24:57] <grrrit-wm> (03Merged) 10jenkins-bot: phplint jobs for MediaWiki skins [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/148130 (https://bugzilla.wikimedia.org/66926) (owner: 10Hashar) [19:27:11] <grrrit-wm> (03PS4) 10Rohan013: Add "cancel this" link to password reset emails [core] - 10https://gerrit.wikimedia.org/r/147496 (https://bugzilla.wikimedia.org/59736) [19:27:30] <grrrit-wm> (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/Splash] - 10https://gerrit.wikimedia.org/r/148161 [19:30:48] <grrrit-wm> (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Nostalgia] - 10https://gerrit.wikimedia.org/r/148163 [19:31:26] <grrrit-wm> (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/Splash] - 10https://gerrit.wikimedia.org/r/148161 (owner: 10Hashar) [19:31:34] <grrrit-wm> (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Nostalgia] - 10https://gerrit.wikimedia.org/r/148163 (owner: 10Hashar) [19:31:42] <grrrit-wm> (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/Truglass] - 10https://gerrit.wikimedia.org/r/148165 [19:31:45] <grrrit-wm> (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/chameleon] - 10https://gerrit.wikimedia.org/r/148166 [19:31:48] <grrrit-wm> (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/erudite] - 10https://gerrit.wikimedia.org/r/148167 [19:31:51] <grrrit-wm> (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/148168 [19:31:57] <grrrit-wm> (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/webplatform] - 10https://gerrit.wikimedia.org/r/148169 [19:32:09] <grrrit-wm> (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/webplatform] - 10https://gerrit.wikimedia.org/r/148169 (owner: 10Hashar) [19:32:14] <grrrit-wm> (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/148168 (owner: 10Hashar) [19:32:20] <grrrit-wm> (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/erudite] - 10https://gerrit.wikimedia.org/r/148167 (owner: 10Hashar) [19:32:25] <grrrit-wm> (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/Truglass] - 10https://gerrit.wikimedia.org/r/148165 (owner: 10Hashar) [19:32:32] <grrrit-wm> (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/chameleon] - 10https://gerrit.wikimedia.org/r/148166 (owner: 10Hashar) [19:38:23] <wikibugs> 3MediaWiki skins / 3Nimbus: mediawiki/skins/Nimbus should pass jshint - 10https://bugzilla.wikimedia.org/68335 (10Antoine "hashar" Musso) 3NEW p:3Unprio s:3normal a:3None mediawiki/skins/Nimbus does not pass jshint. It should provides a default .jshintrc file (probably just containing: {}. And the... [19:39:30] <grrrit-wm> (03PS1) 10Umherirrender: Docs: {function} -> callable [core] - 10https://gerrit.wikimedia.org/r/148177 [19:39:54] <grrrit-wm> (03PS1) 10Hashar: Pass jshint [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/148180 [19:40:02] <grrrit-wm> (03CR) 10Hashar: [C: 032] Pass jshint [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/148180 (owner: 10Hashar) [19:40:57] <grrrit-wm> (03Merged) 10jenkins-bot: Pass jshint [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/148180 (owner: 10Hashar) [19:41:35] <grrrit-wm> (03PS2) 10Withoutaname: Move function xmlsafe from Export.php to OAI extension [extensions/OAI] - 10https://gerrit.wikimedia.org/r/147337 [19:41:35] <MatmaRex> hashar: thanks. probably related to what you said on the bug: https://gerrit.wikimedia.org/r/#/c/130024/ [19:41:49] <MatmaRex> (yep, we actually have no tests verifying that our RL modules work…) [19:42:15] <MatmaRex> module dependencies work* [19:43:06] <grrrit-wm> (03PS1) 10Hashar: Drop executable bits from regular files [skins/webplatform] - 10https://gerrit.wikimedia.org/r/148208 [19:43:24] <grrrit-wm> (03CR) 10Hashar: [C: 032] Drop executable bits from regular files [skins/webplatform] - 10https://gerrit.wikimedia.org/r/148208 (owner: 10Hashar) [19:43:27] <grrrit-wm> (03Merged) 10jenkins-bot: Drop executable bits from regular files [skins/webplatform] - 10https://gerrit.wikimedia.org/r/148208 (owner: 10Hashar) [19:44:57] <grrrit-wm> (03CR) 1020after4: [C: 031] Disable ssh host key checking for command and control [tools/scap] - 10https://gerrit.wikimedia.org/r/148112 (owner: 10BryanDavis) [19:46:46] <grrrit-wm> (03PS1) 10Hashar: Basic jshint fixes [skins/webplatform] - 10https://gerrit.wikimedia.org/r/148210 [19:47:35] <grrrit-wm> (03CR) 10Ori.livneh: "It may not be enough to perform just one last read after the process has terminated, because the output waiting to be read may be longer t" [core] - 10https://gerrit.wikimedia.org/r/147635 (https://bugzilla.wikimedia.org/67870) (owner: 10MaxSem) [19:48:31] <grrrit-wm> (03CR) 1020after4: "I need to fixit up a bit more but yes I'll get it approved upstream then we can just pull it." [phabricator/libphutil] - 10https://gerrit.wikimedia.org/r/147686 (owner: 10CSteipp) [19:48:33] <grrrit-wm> (03CR) 10Legoktm: [C: 032] Remove <div id="mw-js-message"> (again) [core] - 10https://gerrit.wikimedia.org/r/147901 (owner: 10Bartosz Dziewoński) [19:48:43] <grrrit-wm> (03PS13) 10Withoutaname: Action: Merge getClass() into factory() and kill $wgActions [core] - 10https://gerrit.wikimedia.org/r/145247 [19:51:06] <grrrit-wm> (03CR) 10Smuggli: [C: 032 V: 032] Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/146786 (owner: 10Smuggli) [19:51:56] <grrrit-wm> (03PS1) 10Hashar: jshint: add semicolons [skins/webplatform] - 10https://gerrit.wikimedia.org/r/148212 [19:51:58] <grrrit-wm> (03PS1) 10Hashar: jshint: 'i' is already defined. [skins/webplatform] - 10https://gerrit.wikimedia.org/r/148213 [19:52:23] <MatmaRex> hashar: you there? [19:52:23] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Remove <div id="mw-js-message"> (again) [core] - 10https://gerrit.wikimedia.org/r/147901 (owner: 10Bartosz Dziewoński) [19:52:40] <MatmaRex> hashar: more of the old skins in that repo are generally broken [19:52:53] <hashar> MatmaRex: I can imagine :-) [19:53:00] <grrrit-wm> (03PS14) 10Withoutaname: Action: Merge getClass() into factory() and kill $wgActions [core] - 10https://gerrit.wikimedia.org/r/145247 [19:53:15] <MatmaRex> hashar: so i wouldn't spend much time on them if i were you [19:53:24] <MatmaRex> i'm pretty sure the 'webplatform' stuff doesn't even run now, for example [19:53:31] <withoutaname> I think we should split the sidebar into a separate class [19:53:31] <hashar> MatmaRex: yeah was merely adding phplint jenkins jobs :-) [19:53:35] <withoutaname> and somehow make it floatable [19:53:58] <grrrit-wm> (03CR) 10Bartosz Dziewoński: "Huh, jenkins?" [core] - 10https://gerrit.wikimedia.org/r/147901 (owner: 10Bartosz Dziewoński) [19:54:02] <grrrit-wm> (03PS2) 10Bartosz Dziewoński: Remove <div id="mw-js-message"> (again) [core] - 10https://gerrit.wikimedia.org/r/147901 [19:54:49] <withoutaname> you're working on the skin class right? [19:55:15] <withoutaname> do you think we could split off sidebar into a navmenu class (part of skintemplate) and let others customize it [19:55:25] <withoutaname> it has this huge ugly whitespace on the left hand side [19:57:52] <MatmaRex> withoutaname: ugh, i don't think the current system works that way [19:58:01] <MatmaRex> withoutaname: each skin implements styling for sidebar separately [19:58:39] <grrrit-wm> (03PS1) 10Andrew Bogott: Don't try to add an instance to the proxy pulldown if it lacks a host record. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/148215 [19:58:45] <withoutaname> MatmaRex: are the skins able to change the position of the sidebar? [19:59:01] <withoutaname> can it float on top? lie on the bottom? or move to the right-hand side [19:59:16] <MatmaRex> withoutaname: they can do literally anything to the sidebar [19:59:24] <MatmaRex> withoutaname: https://www.mediawiki.org/wiki/Requests_for_comment/Redo_skin_framework might be of interest to you [19:59:26] <grrrit-wm> (03CR) 10Andrew Bogott: [C: 032] Don't try to add an instance to the proxy pulldown if it lacks a host record. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/148215 (owner: 10Andrew Bogott) [19:59:28] <grrrit-wm> (03Merged) 10jenkins-bot: Don't try to add an instance to the proxy pulldown if it lacks a host record. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/148215 (owner: 10Andrew Bogott) [20:00:00] <grrrit-wm> (03PS2) 10Jdlrobson: QA: Some fixes for browser tests. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147692 (owner: 10Werdna) [20:01:27] <grrrit-wm> (03PS4) 10Ori.livneh: Fix race condition in wfShellExec() [core] - 10https://gerrit.wikimedia.org/r/147635 (https://bugzilla.wikimedia.org/67870) (owner: 10MaxSem) [20:01:47] <grrrit-wm> (03CR) 10Spage: "I always see the wikiglyph-flag icon on the "This topic closed/deleted by <USER>" line. This doesn't match the moderation icon from the th" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147524 (owner: 10SG) [20:05:25] <grrrit-wm> (03CR) 10Jdlrobson: [C: 04-1] "This isn't what's going on. The problem is with cached HTML :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147692 (owner: 10Werdna) [20:09:31] <grrrit-wm> (03CR) 10Nikerabbit: [C: 031] "PS4 fixes my test case." [core] - 10https://gerrit.wikimedia.org/r/147635 (https://bugzilla.wikimedia.org/67870) (owner: 10MaxSem) [20:10:06] <grrrit-wm> (03PS1) 10Jack Phoenix: Make jshint happy. [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/148216 (https://bugzilla.wikimedia.org/68335) [20:10:44] <grrrit-wm> (03CR) 10Krinkle: Fix rendering in Internet Explorer: * Missing doctype * Lots of values missing 'px' in css * IE doesn't have a console to log unless cons (031 comment) [winter] - 10https://gerrit.wikimedia.org/r/146590 (owner: 10Jorm) [20:10:49] <grrrit-wm> (03PS8) 10Jamesmontalvo3: Add file approval and fine-tuned permissions; bump to v1.0 [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 [20:11:03] <grrrit-wm> (03CR) 10Jdlrobson: "ping pong.. let's get this wrapped up and merged." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147524 (owner: 10SG) [20:11:07] <wikibugs> 3MediaWiki / 3General/Unknown: Create new user group on Portuguese Wikipedia of good faith new users - 10https://bugzilla.wikimedia.org/68338 (10Teles) 3NEW p:3Unprio s:3normal a:3None It was proposed creation of a new group on Portuguese Wikipedia [1] to temporarily list new users that are somehow i... [20:11:35] <wikibugs> 3MediaWiki / 3General/Unknown: Create new user group on Portuguese Wikipedia of good faith new users - 10https://bugzilla.wikimedia.org/68338 (10Teles) [20:12:56] <grrrit-wm> (03CR) 10Jdlrobson: [C: 032] Preload workflows for url generator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147582 (https://bugzilla.wikimedia.org/68225) (owner: 10EBernhardson) [20:13:08] <grrrit-wm> (03CR) 10Tbleher: [C: 032 V: 032] Remove deprecated RawPage class and replace with RawAction [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/147044 (owner: 10Withoutaname) [20:13:30] <grrrit-wm> (03Merged) 10jenkins-bot: Preload workflows for url generator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147582 (https://bugzilla.wikimedia.org/68225) (owner: 10EBernhardson) [20:14:14] <grrrit-wm> (03PS2) 10Hashar: Make PageTriage tests voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148135 (https://bugzilla.wikimedia.org/68205) (owner: 10MaxSem) [20:14:49] <grrrit-wm> (03CR) 10Hashar: [C: 04-1] Make PageTriage tests voting (031 comment) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148135 (https://bugzilla.wikimedia.org/68205) (owner: 10MaxSem) [20:17:06] <grrrit-wm> (03CR) 10Krinkle: Fix rendering in Internet Explorer: * Missing doctype * Lots of values missing 'px' in css * IE doesn't have a console to log unless cons (032 comments) [winter] - 10https://gerrit.wikimedia.org/r/146590 (owner: 10Jorm) [20:17:54] <grrrit-wm> (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/92621 (owner: 10Hashar) [20:17:59] <grrrit-wm> (03PS6) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/92621 [20:18:07] <grrrit-wm> (03CR) 10Werdna: "This fixes issues for me. No idea if they are the same as your issues, but I still think this should be merged to fix mine." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147692 (owner: 10Werdna) [20:18:10] <grrrit-wm> (03CR) 10Hashar: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/92621 (owner: 10Hashar) [20:21:00] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/92621 (owner: 10Hashar) [20:21:08] <grrrit-wm> (03CR) 10Jdlrobson: "Tyler, thanks for moving this forward :)" [core] - 10https://gerrit.wikimedia.org/r/148144 (https://bugzilla.wikimedia.org/15484) (owner: 10Parent5446) [20:21:58] <Krinkle> ori: https://developer.mozilla.org/en-US/docs/Web/API/navigator.sendBeacon [20:22:04] <Krinkle> Have you seen that yet? [20:22:08] <Krinkle> Looks promising [20:22:20] <ori> Krinkle: yep [20:22:30] <grrrit-wm> (03PS3) 10MaxSem: Make PageTriage tests voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148135 (https://bugzilla.wikimedia.org/68205) [20:23:07] <ori> Krinkle: https://bugzilla.wikimedia.org/show_bug.cgi?id=42815#c7 [20:26:26] <Krinkle> ori: cool [20:27:57] <grrrit-wm> (03PS1) 10Jdlrobson: Get QUnit tests passing in Jenkins [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148220 [20:28:03] <grrrit-wm> (03CR) 10tosfos: [C: 032 V: 032] Add tests for coding standards [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/145516 (owner: 10Florianschmidtwelzow) [20:28:20] <grrrit-wm> (03PS2) 10Jdlrobson: Get QUnit tests passing in Jenkins [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148220 (https://bugzilla.wikimedia.org/68188) [20:30:54] <grrrit-wm> (03PS1) 10MarkTraceur: Don't check description validity on keyup [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/148222 (https://bugzilla.wikimedia.org/33607) [20:35:58] <greg-g> can I safely kill a vangrant reload that seems to be stuck? [20:36:21] <grrrit-wm> (03PS1) 10Chad: Fix mistaken class registration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148224 [20:36:33] <greg-g> been running for 15 minutes, hung at "Notice: /Stage[main]/Git/Package[git]/ensure: ensure changed 'purged' to 'latest'" for at least 5 [20:36:56] <grrrit-wm> (03CR) 10Chad: [C: 032] Fix mistaken class registration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148224 (owner: 10Chad) [20:37:06] <grrrit-wm> (03Merged) 10jenkins-bot: Fix mistaken class registration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148224 (owner: 10Chad) [20:37:07] <greg-g> hmm, cpu usage spiked again [20:37:42] <ori> greg-g: is it cloning mediawiki/ perhaps? [20:37:58] <grrrit-wm> (03CR) 10Withoutaname: Move deletion-specific code to DeleteAction.php (032 comments) [core] - 10https://gerrit.wikimedia.org/r/142618 (owner: 10Withoutaname) [20:38:26] <ori> greg-g: in another terminal window, cd to the vagrant dir, run vagrant ssh, and then run 'top' to see what it's doing [20:39:21] <wikibugs> 3MediaWiki / 3Revision deletion: Give sysops deleterevision rights by default - 10https://bugzilla.wikimedia.org/68298 (10Nathan Larson) a:3Nathan Larson [20:39:31] <greg-g> ori: php something or other [20:39:48] <greg-g> ah, there we go, it budged [20:40:03] <greg-g> must have been cloning mediawiki [20:40:11] <greg-g> sorry for the noise ori, thanks :) [20:41:20] <grrrit-wm> (03PS1) 10MaxSem: Cleanup: normalize annotations, rm unused var [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148225 [20:43:03] <grrrit-wm> (03PS1) 10Hoo man: Make sure $doUserRightsLogLike is set all the times [core] - 10https://gerrit.wikimedia.org/r/148226 [20:43:37] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 031] Make jshint happy. [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/148216 (https://bugzilla.wikimedia.org/68335) (owner: 10Jack Phoenix) [20:44:01] <hoo> SPQRobin: ^ [20:44:12] <hoo> follow-up to a broken change you merged [20:44:24] <hoo> this is actually breaking our unit tests, so please merge someone [20:45:02] <grrrit-wm> (03CR) 10Legoktm: [C: 032] Make sure $doUserRightsLogLike is set all the times [core] - 10https://gerrit.wikimedia.org/r/148226 (owner: 10Hoo man) [20:45:05] <MaxSem> brion, is https://bugzilla.wikimedia.org/show_bug.cgi?id=67973 resolved for you? [20:45:23] <hoo> thanks, legoktm :) [20:45:30] <legoktm> :) [20:46:53] <grrrit-wm> (03PS2) 10Legoktm: Add UserMergeAccountFields hook subscriber [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/145217 (https://bugzilla.wikimedia.org/67782) [20:47:10] <grrrit-wm> (03CR) 10Legoktm: Add UserMergeAccountFields hook subscriber (031 comment) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/145217 (https://bugzilla.wikimedia.org/67782) (owner: 10Legoktm) [20:47:28] <legoktm> kaldari: ^ thanks for the review! [20:48:21] <grrrit-wm> (03Merged) 10jenkins-bot: Make sure $doUserRightsLogLike is set all the times [core] - 10https://gerrit.wikimedia.org/r/148226 (owner: 10Hoo man) [20:49:08] <grrrit-wm> (03CR) 10Kaldari: [C: 032] Add UserMergeAccountFields hook subscriber [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/145217 (https://bugzilla.wikimedia.org/67782) (owner: 10Legoktm) [20:49:25] <grrrit-wm> (03Merged) 10jenkins-bot: Add UserMergeAccountFields hook subscriber [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/145217 (https://bugzilla.wikimedia.org/67782) (owner: 10Legoktm) [20:49:29] <legoktm> ty :) [20:50:23] <grrrit-wm> (03PS1) 10leucosticte: Give sysops the deleterevision right by default [core] - 10https://gerrit.wikimedia.org/r/148229 (https://bugzilla.wikimedia.org/68298) [20:56:55] <brion> MaxSem: good enough, i closed it out as wontfix :D [20:57:14] <MaxSem> thanks, brion :) [20:59:09] <SPQRobin> hoo: hmm, do you know which change? [20:59:56] <hoo> SPQRobin: Yeah, but already resolved [20:59:58] <hoo> wait [21:00:28] <SPQRobin> yeah, I'm just wondering since I don't often merge changes [21:01:12] <grrrit-wm> (03PS1) 10Andrew Bogott: Enable shared storage for new projects. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/148232 [21:01:44] <grrrit-wm> (03CR) 10Andrew Bogott: [C: 032] Enable shared storage for new projects. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/148232 (owner: 10Andrew Bogott) [21:01:46] <grrrit-wm> (03Merged) 10jenkins-bot: Enable shared storage for new projects. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/148232 (owner: 10Andrew Bogott) [21:04:52] <grrrit-wm> (03CR) 10Legoktm: [C: 031] "Minor nitpick. Looks good otherwise." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/147916 (owner: 10Vogone) [21:05:07] <wikibugs> 3MediaWiki extensions / 3Popups: EventLogging dependency isn't so optional - 10https://bugzilla.wikimedia.org/68341 (10Mark Holmquist) 3NEW p:3Unprio s:3normal a:3None Looking through the code briefly, it looks like Popups conditionally loads the schema module that EL uses, but loads the ext.popups.e... [21:05:15] <thedj> rfarrand: you need to open up the Google document for outside the org. [21:05:24] <marktraceur> YuviPanda: ty for the referral [21:05:34] <YuviPanda> marktraceur: ye [21:05:35] <YuviPanda> err [21:05:35] <YuviPanda> yw [21:05:41] <marktraceur> zz_prtksxna: What on earth are you doing over there anyway :P [21:08:17] <rfarrand> thedj: Thank you! SHould be fixed! [21:08:34] <thedj> rfarrand: yup :) [21:08:47] <hoo> SPQRobin: Doh, I was looking at the wrong change, btw [21:08:53] <hoo> problem was caused by this one: https://gerrit.wikimedia.org/r/48661 [21:09:53] <SPQRobin> ah, I thought so since I didn't recognise the code :p [21:10:37] <wikibugs> 3MediaWiki-Vagrant: setup.sh fails on fresh clone - 10https://bugzilla.wikimedia.org/68342 (10Yuvi Panda) 3NEW p:3Unprio s:3normal a:3Ori Livneh I get: ± |master ✓| → ./setup.sh Vagrant failed to initialize at a very early stage: There was an error loading a Vagrantfile. The file being loaded and th... [21:12:13] <rfarrand> thedj: I did not realize that was an auto setting. Now I do.. :) [21:12:20] <wikibugs> 3MediaWiki-Vagrant: setup.sh fails on fresh clone - 10https://bugzilla.wikimedia.org/68342#c1 (10Bryan Davis) Yuvi, What version of Vagrant are you using? [21:12:25] <rfarrand> thedj: Thanks! [21:13:33] <thedj> rfarrand: np. figured you'd want to know as soon as possible. those things can get quite confusing for ppl if it lingers a bit. [21:13:37] <Reedy> rfarrand: [21:13:37] <Reedy> I plan to attend the Hackathon on January 6th only [21:13:37] <Reedy> I plan to attend the Hackathon on January 7th only [21:13:57] <marktraceur> Reedy: Hey man, some people don't have August free [21:14:14] <marktraceur> Flights to London are hella expensive [21:14:20] <wikibugs> 3MediaWiki extensions / 3Cite: Error generation of unbalanced <ref><references/>: No error is shown if missing </ref>-tag is the last ref tag - 10https://bugzilla.wikimedia.org/15712#c6 (10Gadget850) If the last </ref> was missing, then the reference list markup would get eaten and it would trigger 'MediaWik... [21:14:24] <thedj> Reedy: lol, i guess i didn't even read it when filling it in... [21:14:41] <Reedy> thedj: Well if you selected "both" and then continue; [21:15:38] * thedj passes rfarrand an espresso. [21:16:10] <grrrit-wm> (03PS5) 10Withoutaname: Move deletion-specific code to DeleteAction.php [core] - 10https://gerrit.wikimedia.org/r/142618 [21:17:35] <wikibugs> 3MediaWiki-Vagrant: setup.sh fails on fresh clone - 10https://bugzilla.wikimedia.org/68342#c2 (10Yuvi Panda) 5NEW>3RESO/INV Problem magically resolved once vagrant was updated. yay :) Now if only setup.sh printed out useful status info as it went along... :D [21:17:59] <rfarrand> Reedy: Yikes, thanks for that too. Fixed it. I had a few people double check the form before I sent it also. I do need espresso… [21:18:13] * Reedy hugs rfarrand [21:18:54] <thedj> perhaps it's a stroopwafel deficiency.... [21:18:54] <rfarrand> :) [21:18:59] <rfarrand> hehe [21:19:02] <rfarrand> maybe so [21:19:19] <wikibugs> 3MediaWiki-Vagrant: setup.sh fails on fresh clone - 10https://bugzilla.wikimedia.org/68342 (10Yuvi Panda) 5RESO/INV>3RESO/WOR [21:20:47] <YuviPanda> bd808: finally giving in and moving to trusty [21:21:58] <grrrit-wm> (03CR) 10Withoutaname: "I think I can ask someone to put up deprecation notices for Article::delete() and FileDeleteForm and company. We would still need to check" [core] - 10https://gerrit.wikimedia.org/r/142618 (owner: 10Withoutaname) [21:24:17] <jgonera> gwicke, any reason for using comments in https://gerrit.wikimedia.org/r/#/c/133301/8/resources/src/mediawiki.skinning/content.parsoid.less instead of just replacing the values? [21:26:08] <grrrit-wm> (03CR) 10JGonera: [C: 04-1] "A question regarding parsoid's CSS inline." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133301 (https://bugzilla.wikimedia.org/65160) (owner: 10Jforrester) [21:26:31] <grrrit-wm> (03PS3) 10Vogone: Adjusted show/hide links [core] - 10https://gerrit.wikimedia.org/r/147916 [21:27:04] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: remove badges when changing the sitelink on the repo - 10https://bugzilla.wikimedia.org/68155 (10Marius Hoch) 5PATC>3RESO/FIX [21:29:09] <grrrit-wm> (03CR) 10MarkTraceur: [C: 032] "Gah, the worst bawolff. Get your head in the game man." [extensions/TimedMediaHandler] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148091 (owner: 10Brian Wolff) [21:29:23] <grrrit-wm> (03Merged) 10jenkins-bot: partial revert 676df858e984. Add back 3 messages that were really used. [extensions/TimedMediaHandler] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148091 (owner: 10Brian Wolff) [21:31:25] <withoutaname> ^d: hey [21:31:36] <withoutaname> do you know how rebuildFileCache is supposed to work [21:32:59] <^d> Never used it. It's supposed to iterate over the pages and cache the html to disk. [21:33:08] <^d> No clue if it works. Script looks kinda jankey. [21:37:07] <wikibugs> 3MediaWiki / 3Categories: IcuCollation's 'first-letters' cache key should include the version of ICU and possibly PHP that was used to build the data - 10https://bugzilla.wikimedia.org/68344 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3major a:3None IcuCollation's 'first-letters' cache key should include... [21:37:13] <grrrit-wm> (03PS1) 10PleaseStand: maintenance/README: Remove importTextFile.php [core] - 10https://gerrit.wikimedia.org/r/148236 [21:37:17] <grrrit-wm> (03PS1) 10EBernhardson: Preload workflows for url generator [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148237 (https://bugzilla.wikimedia.org/68225) [21:37:20] <wikibugs> 3MediaWiki / 3Categories: IcuCollation's 'first-letters' cache key should include the version of ICU and possibly PHP that was used to build the data - 10https://bugzilla.wikimedia.org/68344 (10Bartosz Dziewoński) p:5Unprio>3High [21:37:35] <grrrit-wm> (03CR) 10Vogone: Adjusted show/hide links (031 comment) [core] - 10https://gerrit.wikimedia.org/r/147916 (owner: 10Vogone) [21:37:50] <grrrit-wm> (03CR) 10Chad: [C: 032] Made ViewCountUpdate do the page table updates in auto-commit mode [core] - 10https://gerrit.wikimedia.org/r/146730 (owner: 10Aaron Schulz) [21:38:49] <wikibugs> 3Wikimedia / 3Site requests: Category collation for Estonian projects - 10https://bugzilla.wikimedia.org/54168#c10 (10Bartosz Dziewoński) 5PATC>3NEW Hooray :D The next step is to hold a quick discussion/vote on each wiki that would want this enabled, just to make sure nothing happen behind someone's bac... [21:39:04] <wikibugs> 3MediaWiki / 3Page editing: Hundreds of PostEditRevision cookies accumulated, one per edit - 10https://bugzilla.wikimedia.org/67790#c3 (10Nemo) (In reply to Andre Klapper from comment #2) > Wondering which settings are different. Maybe you don't hide the postedit banner in your personal CSS? [21:39:19] <wikibugs> 3MediaWiki / 3Categories: IcuCollation's 'first-letters' cache key should include the version of ICU and possibly PHP that was used to build the data - 10https://bugzilla.wikimedia.org/68344 (10Kunal Mehta (Legoktm)) [21:41:04] <wikibugs> 3MediaWiki / 3User login and signup: Password reset doesn't work - 10https://bugzilla.wikimedia.org/52126#c7 (10Juliusz Gonera) 5UNCO>3RESO/WOR It seems to be working for me now. [21:41:13] <grrrit-wm> (03PS1) 10Dzahn: add jzerebecki to trusted users in zuul [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148238 [21:41:29] <grrrit-wm> (03CR) 10Withoutaname: [C: 031] maintenance/README: Remove importTextFile.php [core] - 10https://gerrit.wikimedia.org/r/148236 (owner: 10PleaseStand) [21:42:51] <grrrit-wm> (03Merged) 10jenkins-bot: Made ViewCountUpdate do the page table updates in auto-commit mode [core] - 10https://gerrit.wikimedia.org/r/146730 (owner: 10Aaron Schulz) [21:42:53] <grrrit-wm> (03CR) 10Legoktm: [C: 032] maintenance/README: Remove importTextFile.php [core] - 10https://gerrit.wikimedia.org/r/148236 (owner: 10PleaseStand) [21:42:59] <grrrit-wm> (03CR) 10Matanya: [C: 031] "Yes! trusted." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148238 (owner: 10Dzahn) [21:43:29] <matanya> hmm, /me pokes hashar again ^ [21:46:10] <grrrit-wm> (03CR) 10Chad: [C: 032] cirrussearch: Require update_database for build_search_index [vagrant] - 10https://gerrit.wikimedia.org/r/147999 (owner: 10BryanDavis) [21:46:53] <grrrit-wm> (03Merged) 10jenkins-bot: maintenance/README: Remove importTextFile.php [core] - 10https://gerrit.wikimedia.org/r/148236 (owner: 10PleaseStand) [21:47:18] <grrrit-wm> (03Merged) 10jenkins-bot: cirrussearch: Require update_database for build_search_index [vagrant] - 10https://gerrit.wikimedia.org/r/147999 (owner: 10BryanDavis) [21:49:00] <grrrit-wm> (03PS2) 10Werdna: New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 [21:50:33] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [21:51:45] <grrrit-wm> (03PS1) 10Brian Wolff: Updating TimedMediaHandler to 3e70e8c7014fc5e [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148241 [21:52:08] <grrrit-wm> (03PS4) 10Vogone: Adjusted show/hide links [core] - 10https://gerrit.wikimedia.org/r/147916 [21:52:10] <grrrit-wm> (03PS1) 10Vogone: Added me to credits [core] - 10https://gerrit.wikimedia.org/r/148242 [21:54:00] <grrrit-wm> (03CR) 10Legoktm: [C: 032] Adjusted show/hide links [core] - 10https://gerrit.wikimedia.org/r/147916 (owner: 10Vogone) [21:54:18] <grrrit-wm> (03CR) 10Legoktm: [C: 032] "\o/" [core] - 10https://gerrit.wikimedia.org/r/148242 (owner: 10Vogone) [21:55:03] <withoutaname> Reedy: have you ever used rebuildFileCache in production [21:55:20] <Reedy> No.. [21:55:42] <bawolff> Wikimedia doesn't use file cache at all [21:55:47] <Reedy> Well, we do [21:55:51] <Reedy> But not that [21:56:05] <bawolff> We do? [21:56:25] <Reedy> Site config ends up in a file cache ;) [21:56:29] <withoutaname> what about pruneFileCache [21:56:39] <bawolff> Well yeah, we cache things in files ;) [21:57:13] <Reedy> No.. [21:57:27] <Reedy> if we don't have anything to rebuild, why would we have anything to purge? [21:57:28] <Reedy> ;) [21:58:05] <withoutaname> I don't know why they're two separate files either [21:58:11] <withoutaname> but I'm thinking of chucking them [21:58:16] <bawolff> withoutaname: The FileCache system is essentially a really crappy version of varnish for people who don't have varnish. Wikimedia has varnish so it doesn't use it [21:58:33] <grrrit-wm> (03CR) 10Hashar: [C: 04-1] "email need to be added at two places :-D" (031 comment) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148238 (owner: 10Dzahn) [21:59:42] <grrrit-wm> (03Merged) 10jenkins-bot: Adjusted show/hide links [core] - 10https://gerrit.wikimedia.org/r/147916 (owner: 10Vogone) [21:59:57] <grrrit-wm> (03Merged) 10jenkins-bot: Added me to credits [core] - 10https://gerrit.wikimedia.org/r/148242 (owner: 10Vogone) [22:00:16] <hashar> matanya: too tired to do anything now. will do tomorrow unless someone fix the change and deploy it overnight :-] [22:00:29] <matanya> :) [22:01:03] <bawolff> withoutaname: The two scripts do kind of different things. Someone who actually used file cache would likely run rebuildFileCache not very often, but might run pruneFileCache quite regularly [22:01:52] <withoutaname> rebuildFileCache uses wgOut, any way to get rid of that? [22:02:56] <bawolff> Its for compatibility with old code that might still rely on $wgOut [22:04:05] <bawolff> If it really concerns you, line 135 could be replaced with $context->getOutput()->output(); [22:04:31] <bawolff> but the assignment on line 118 should probably stay the same [22:04:42] <grrrit-wm> (03PS3) 10Jdlrobson: Get QUnit tests passing in Jenkins [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148220 (https://bugzilla.wikimedia.org/68188) [22:06:03] <grrrit-wm> (03CR) 10Ori.livneh: [C: 031] "+1 for the approach and my initial read-through. I'm reserving +2 so that we can test this a bit more, but overall I think it's the right " [core] - 10https://gerrit.wikimedia.org/r/143802 (owner: 10Aaron Schulz) [22:06:38] <grrrit-wm> (03PS1) 10Jdlrobson: Make Flow QUnit tests voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148244 (https://bugzilla.wikimedia.org/67734) [22:06:56] <withoutaname> bawolff: ok um, for maint scripts what would normally be the point of entry [22:07:06] <withoutaname> like in the browser, it would be index.php [22:07:27] <bawolff> Each maintinance script is its own entry point [22:07:42] <jdlrobson> is beta labs down? greg-g ? [22:07:55] <ebernhardson> jdlrobson: yes, its down [22:08:07] <withoutaname> oh I see, that's why there's a require_once at the top and the bottom of the script, to setup and end it [22:08:08] <jdlrobson> ebernhardson: okay thanks for clarifying. Any idea when the databse locked errors will go away? [22:08:17] <greg-g> https://integration.wikimedia.org/ci/view/Beta/job/beta-update-databases-eqiad/ [22:08:33] <grrrit-wm> (03CR) 10Physikerwelt: [C: 031] "I tested (Verified) it and it works as expected." (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/147874 (https://bugzilla.wikimedia.org/66807) (owner: 10BryanDavis) [22:09:02] <bawolff> withoutaname: most of the setup code is in maintinance/doMaintenance.php [22:09:35] <withoutaname> yeah, there's a lot of duplicate code between that and WebStart.php [22:10:15] <bawolff> Well its basically WebStart.php for the command line [22:10:38] <kaldari> TimStarling: Hey Tim, do you have interest in weighing it at https://gerrit.wikimedia.org/r/#/c/140765/ ? [22:10:59] <grrrit-wm> (03PS1) 10Withoutaname: Remove RequestContext from edit.php and fixDoubleRedirects.php [core] - 10https://gerrit.wikimedia.org/r/148245 [22:11:07] <wikibugs> 3Wikimedia / 3Extension setup: Enable DynamicPageList on sr.wiktionary - 10https://bugzilla.wikimedia.org/68346 (10Filip Maljkovic [Dungodung]) 3NEW p:3Unprio s:3normal a:3None Please enable DynamicPageList extension for Serbian language Wiktionary (srwikt), as per vote here: https://sr.wiktionary.or... [22:11:34] <withoutaname> so we probably need a way to separate the usual starter code from CLI specific starter code [22:11:36] <wikibugs> 3MediaWiki extensions / 3BookManagerv2: Implement keyboard navigation - 10https://bugzilla.wikimedia.org/50679#c9 (10Jared Flores) (In reply to Andre Klapper from comment #8) > Jared: Do you plan to fix https://gerrit.wikimedia.org/r/#/c/100195/7 at > some point, or should this bug report be reassigned to th... [22:11:47] <withoutaname> and then combine the two [22:11:50] <wikibugs> 3Wikimedia / 3Extension setup: Enable DynamicPageList on sr.wiktionary - 10https://bugzilla.wikimedia.org/68346 (10Bawolff (Brian Wolff)) [22:13:42] <grrrit-wm> (03PS1) 10EBernhardson: Fragments are also relative links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148246 [22:13:46] <withoutaname> bawolff: it seems that the starter code in maintenance only runs if wgCommandLineMode is true [22:14:29] <withoutaname> Could we check for PHP_SAPI == 'cli' rather than wgCommandLineMode? [22:15:17] <grrrit-wm> (03CR) 10BryanDavis: "physikerwelt: Re slowness, the new package list you wanted me to add pulls down a lot of data from apt. This is compounded if the patch I " [vagrant] - 10https://gerrit.wikimedia.org/r/147874 (https://bugzilla.wikimedia.org/66807) (owner: 10BryanDavis) [22:15:40] <withoutaname> although I'm not sure, I heard PHP_SAPI might return different values for different command line types so that might break [22:18:43] <bawolff> what's wrong with what it currently does? [22:21:15] <grrrit-wm> (03CR) 10EBernhardson: [C: 032] Preload workflows for url generator [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148237 (https://bugzilla.wikimedia.org/68225) (owner: 10EBernhardson) [22:21:46] <grrrit-wm> (03Merged) 10jenkins-bot: Preload workflows for url generator [extensions/Flow] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148237 (https://bugzilla.wikimedia.org/68225) (owner: 10EBernhardson) [22:21:48] <withoutaname> it's only set in Maintenance.php yet it controls wgRequest in Setup [22:21:56] <withoutaname> ideally we would never have to use FauxRequest [22:22:25] <bawolff> Well you're not going to have a WebRequest from the command line [22:23:04] <werdna> why not? [22:23:06] <grrrit-wm> (03PS1) 10EBernhardson: Update Flow extension in wmf/1.24wmf14 [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148249 [22:23:14] <werdna> (to both bawolff and withoutaname) [22:23:17] <^d> $wgCommandLineMode is ugly and hacky. Just check the sapi == 'cli' [22:23:28] <^d> Also, $wgRequest can go away soon. [22:25:19] <grrrit-wm> (03PS2) 10Dzahn: add jzerebecki to trusted users in zuul [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148238 [22:26:58] <grrrit-wm> (03PS1) 10Brian Wolff: Include ICU version in cache key for collation first letters [core] - 10https://gerrit.wikimedia.org/r/148251 (https://bugzilla.wikimedia.org/68344) [22:27:55] <grrrit-wm> (03CR) 10Gergő Tisza: "> Gergo: did you remember to run "vagrant provision" after applying the patch and enabling the role? The changeset still works for me afte" [vagrant] - 10https://gerrit.wikimedia.org/r/147151 (owner: 10Gilles) [22:29:05] <wikibugs> 3MediaWiki / 3Categories: IcuCollation's 'first-letters' cache key should include the version of ICU and possibly PHP that was used to build the data - 10https://bugzilla.wikimedia.org/68344#c2 (10Bawolff (Brian Wolff)) I can't believe we don't already do this. I'm not sure how hiphop implements intl though... [22:31:19] <grrrit-wm> (03PS3) 10Werdna: QA: Some fixes for browser tests. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147692 [22:34:31] <bd808> legoktm: Any good example you can think of for a special page that shows a lot of text? [22:34:54] <legoktm> er, context? [22:34:58] <grrrit-wm> (03PS1) 10Kaldari: Fixing Terms of Use URLs [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148255 [22:35:39] <greg-g> James_F: geez louise, the db upgrade on beta eswiki took 2:23 [22:35:42] <bd808> legoktm: I'm making a new special page in central auth that that will be shown to users who have logged in with their old username. [22:36:01] <greg-g> jdlrobson: https://integration.wikimedia.org/ci/view/Beta/job/beta-update-databases-eqiad/2741/console we have some movement, but it's slow going :( [22:36:12] <bd808> legoktm: So it's basically going to be a list of links and text telling them what to do next. [22:36:15] <jdlrobson> thanks greg-g [22:36:17] <legoktm> hmm [22:36:18] <greg-g> jdlrobson: by 2:23 I mean 2 hours 23 minutes [22:36:22] <greg-g> er James_F ^ [22:36:56] <greg-g> I'm scared for what enwiki will take [22:37:18] <bd808> legoktm: I can use addHtml() but was wondering if there was something sexier [22:37:29] <legoktm> bd808: we just define the text in a super long message, and $out->addHTML( $this->msg( 'foo' )->parse() ); [22:37:34] <James_F> greg-g: Lovely. [22:37:46] <greg-g> James_F: I read it wrong, but still bad. 1 hour 20 minutes [22:37:57] <grrrit-wm> (03PS3) 10Werdna: New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 [22:38:01] <kaldari> greg-g: Does that mean the en.wiki database is going to be locked for half a day? [22:38:01] <greg-g> gah, 1 hour 2 minutes [22:38:14] <greg-g> kaldari: potentially [22:38:16] <greg-g> :( [22:38:21] <MatmaRex> wat? [22:38:23] <greg-g> something needs to be different here [22:38:28] <legoktm> MatmaRex: on betalabs [22:38:32] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [22:38:39] <greg-g> this isn't ok [22:38:39] <MatmaRex> okay. [22:38:46] <James_F> MatmaRex: Aaron made a DB schema change. [22:38:52] <bd808> legoktm: Yeah. That will probably be the way to go. One message per paragraph for whatever content we come up with. [22:38:53] <MatmaRex> i know [22:39:04] <MatmaRex> James_F: i gave you a link to the changeset earlier today :> [22:39:05] <James_F> MatmaRex: Beta Labs runs update.php every 30 minutes. [22:39:44] <James_F> MatmaRex: These two don't sit well together. [22:40:00] <James_F> kaldari: How large is BL enwiki compared to BL eswiki? [22:40:05] <legoktm> there's a reason we don't run update.php in prod, and if beta is supposed to emulate prod... [22:40:13] <James_F> kaldari: It's roughly O(n) on size of DB. [22:40:17] <MatmaRex> update.php also spat a lot of transaction warnings to me earlier today [22:40:26] <James_F> legoktm: Except BL is also the canary for things breaking. [22:40:35] <kaldari> :( [22:40:43] <grrrit-wm> (03PS1) 10Jdlrobson: QA: Fix browser tests on cached anonymous pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148258 [22:40:53] <James_F> legoktm: Prod needs manually-crafted exceptionally-careful DB schema changes to be gently applied over time. [22:41:03] <James_F> legoktm: But if we're going to revert it we need to know within the day. [22:42:17] <grrrit-wm> (03PS4) 10Werdna: New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 [22:42:20] <greg-g> https://bugzilla.wikimedia.org/show_bug.cgi?id=68349 for your "omg this is taking too long" tracking bug [22:42:50] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 (owner: 10Werdna) [22:42:53] <wikibugs> 3MediaWiki extensions / 3Cite: Cite: 'Cite error references missing key' not properly invoked - 10https://bugzilla.wikimedia.org/24600 (10Gadget850) [22:44:23] <wikibugs> 3MediaWiki extensions / 3Cite: Cite: Suppress backlink for a huge number of named references - 10https://bugzilla.wikimedia.org/23455 (10Gadget850) [22:45:35] <wikibugs> 3MediaWiki extensions / 3Cite: Reference doesn't show up for "<ref=Foo/>" markup only - 10https://bugzilla.wikimedia.org/65080#c2 (10Gadget850) 5NEW>3RESO/INV Not a bug; this is due to implementation on enwiki. [22:46:24] <wikibugs> 3MediaWiki extensions / 3Cite: Cite: Using capitalized <ref> inside reference list creates extra backlink - 10https://bugzilla.wikimedia.org/62335 (10Gadget850) [22:46:29] <grrrit-wm> (03PS4) 10Yurik: Allow wfShellExec() to use an array as a command prompt [core] - 10https://gerrit.wikimedia.org/r/144762 [22:46:38] <James_F> greg-g: Thanks. [22:53:53] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Wikibase API lookup on sites and titles doesnt report missing title on site - 10https://bugzilla.wikimedia.org/68251 (10Kunal Mehta (Legoktm)) [22:54:07] <wikibugs> 3MediaWiki extensions / 3WikidataRepo: Wikidata repo MW API (tracking) - 10https://bugzilla.wikimedia.org/39174 (10Kunal Mehta (Legoktm)) [22:54:15] <thedj> top [22:54:47] <ori> Processes: 269 total, 2 running, 2 stuck, 265 sleeping, 1138 threads 15:54:45 [22:55:08] <YuviPanda> bad top, doesn't autoupdate [22:55:24] <wikibugs> 3MediaWiki / 3API: Non Core API issues (tracking) - 10https://bugzilla.wikimedia.org/23855 (10Kunal Mehta (Legoktm)) [22:56:14] <grrrit-wm> (03CR) 10Jforrester: ""Caused" (ish) bug 68349 in Beta Labs." [core] - 10https://gerrit.wikimedia.org/r/117373 (https://bugzilla.wikimedia.org/60618) (owner: 10Aaron Schulz) [22:56:34] <werdna> sudo rm -rf / [22:56:58] <YuviPanda> werdna: I AM AN IDIOT [22:57:00] <YuviPanda> I ACTUALLY RAN THAT [22:57:07] <YuviPanda> EXPECTING --no-preserve-root to save me [22:57:10] <YuviPanda> BUT OS X DOES NOT CARE [22:57:11] <YuviPanda> OH GOD [22:57:20] <werdna> wait, what? [22:57:21] <werdna> really? [22:57:24] <YuviPanda> apparently [22:57:33] <YuviPanda> it didn't immediately give me a warning [22:57:36] <YuviPanda> so I ctrl-c'd [22:57:38] <YuviPanda> immediately [22:57:48] <werdna> did it delete anything? [22:57:50] <werdna> I am crying [22:57:56] <YuviPanda> nothing seems to be gone [22:57:58] <Reedy> of laughther? [22:58:13] <werdna> indeed [22:58:17] <Reedy> spelt correctly, ofc [22:58:26] <werdna> does YuviPanda have root on anything? [22:58:42] <Reedy> it's amusing how quickly rm -rf / can delete stuff [22:58:50] <wikibugs> 3MediaWiki extensions / 3Cite: Cite: Error message for an empty reference should be more appropriate and helpful - 10https://bugzilla.wikimedia.org/57619#c5 (10Gadget850) The test page in question includes '<ref />' which is invalid. This triggers 'MediaWiki:Cite error ref no key'. The default error message... [22:59:27] <werdna> I was going to type "sql enwiki 'drop all tables;'" and say "oops, meant to run that on the cluster", but I thought better of it. [22:59:28] <YuviPanda> werdna: yeah, man rm on OS X tells me there's no --no-preserve-root [23:00:01] <YuviPanda> I'm going to restart, to check [23:00:02] <YuviPanda> let's see [23:03:03] <YuviPanda> werdna: everything is fine :) [23:03:11] <YuviPanda> except I'm less stupid than before [23:04:01] <jdlrobson> awjr_away: okay so i worked out why selello keeps creating cards for you [23:04:05] <wikibugs> 3MediaWiki extensions / 3Cite: Inconsistently numbered references - 10https://bugzilla.wikimedia.org/46140#c1 (10Gadget850) I do not see this issue; Firefox 31. [23:04:27] <YuviPanda> werdna: Reedy infact, I seem to have lost nothing. df -h reports identical numbers [23:04:28] <jdlrobson> awjr_away: when a test has been failing for too long, the entire RSS feed is full of failures, and it can't distinguish between never passed and hasn't failed in a long time [23:04:41] <jdlrobson> awjr_away: i would say this is a feature - it serves as a reminder that tests have been broken for way too long [23:04:42] <Reedy> I'm not sure if that's more scary [23:04:44] <jdlrobson> cc jgonera ^ [23:04:56] <werdna> awjr_away: are you in SF? [23:05:03] <werdna> I seem to remember hearing you would be in SF [23:05:05] <wikibugs> 3MediaWiki extensions / 3Cite: Cite: 'Cite error ref too many keys' not generated if name chunk contains other than A–Z, a–z, 0–9 - 10https://bugzilla.wikimedia.org/42040 (10Gadget850) [23:05:08] <bawolff> greg-g: In regards to the long running update script bug, what was the exact issue? Was the read only mode mediawiki's $wgReadOnly / $wgReadOnlyFile, or was it something from the db on beta labs [23:05:47] <greg-g> bawolff: the db is locked due to the schema upgrade [23:06:27] <grrrit-wm> (03CR) 10MaxSem: [C: 032 V: 032] Updating TimedMediaHandler to 3e70e8c7014fc5e [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148241 (owner: 10Brian Wolff) [23:06:53] <legoktm> bawolff: it's slave lag [23:07:01] <legoktm> http://en.wikipedia.beta.wmflabs.org/w/index.php?title=0.3559023023770196_Moved&action=edit&uselang=qqx [23:07:03] <grrrit-wm> (03CR) 10MaxSem: [C: 032] Update Flow extension in wmf/1.24wmf14 [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148249 (owner: 10EBernhardson) [23:07:13] <grrrit-wm> (03CR) 10MaxSem: [V: 032] Update Flow extension in wmf/1.24wmf14 [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148249 (owner: 10EBernhardson) [23:07:16] <legoktm> unless, someone set $wgReadOnly to that... [23:07:35] <grrrit-wm> (03CR) 10MaxSem: [C: 032] Update OOjs UI to v0.1.0-pre (5ab041a801) [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/147854 (owner: 10Jforrester) [23:07:54] <legoktm> > echo $wgReadOnlyFile; [23:07:54] <legoktm> /data/project/upload7/wikipedia/en/lock_yBgMBwiR [23:08:01] <grrrit-wm> (03PS1) 10Gerrit Patch Uploader: mediawiki.util: Deprecate mw.util.updateTooltipAccessKeys [core] - 10https://gerrit.wikimedia.org/r/148264 [23:08:03] <grrrit-wm> (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/148264 (owner: 10Gerrit Patch Uploader) [23:08:26] <grrrit-wm> (03CR) 10MaxSem: [C: 032] Don't try to pass non Title objects into RequestContext::setTitle [extensions/AbuseFilter] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148027 (owner: 10Legoktm) [23:08:27] <legoktm> hmmmm [23:08:28] <bawolff> There's a wfWaitForSlaves() call in the update script [23:08:36] <grrrit-wm> (03CR) 10Fomafix: "Oh, mw.util.updateTooltipAccessKeys is not deprecated yet. I deprecate it by https://gerrit.wikimedia.org/r/148264" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/138890 (owner: 10Gerrit Patch Uploader) [23:08:43] <bawolff> Waiting for 10.68.17.94: 5009 seconds lagged [23:08:49] <bawolff> definitely slave lag [23:08:49] <grrrit-wm> (03CR) 10MaxSem: [C: 032 V: 032] MobileFrontend: pick https://gerrit.wikimedia.org/r/#/c/147756/ [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148128 (owner: 10MaxSem) [23:09:37] <legoktm> so wfWaitForSlaves is broken on beta? [23:09:37] <grrrit-wm> (03PS15) 10Jack Phoenix: New class for parsing MediaWiki:Sidebar-like messages into modern, nested navigation menus. [core] - 10https://gerrit.wikimedia.org/r/108045 [23:09:42] <werdna> no, it's because somebody made update.php rebuild all link tables [23:09:45] <werdna> ask James_F about it [23:09:51] <wikibugs> 3MediaWiki extensions / 3Cite: Cite: Support multi-column and alternative list-style for <references /> tag (like enwiki {{reflist}}) - 10https://bugzilla.wikimedia.org/51260#c31 (10Gadget850) Bug 22265 - Allow references to be listed with letters [23:09:59] <grrrit-wm> (03PS1) 10EBernhardson: New hooks for external integration to notification intiialization [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148265 [23:10:32] <legoktm> werdna: umm, did you read the full conversation? [23:10:33] <James_F> legoktm: No, slaves are actually waiting. [23:10:47] <legoktm> why? [23:11:01] <James_F> legoktm: For update.php to finish. [23:11:09] <bawolff> what? [23:11:23] <legoktm> why would they do that? [23:11:25] <bawolff> update.php waits for the slaves to catch up before continuing (or its supposed to) [23:12:07] <grrrit-wm> (03CR) 10MarkTraceur: "So, the more I look at this, the more I'm confused. For some reason, the removeItem implementation works, but the $.grep one doesn't. Equa" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146140 (owner: 10MarkTraceur) [23:12:10] <grrrit-wm> (03Merged) 10jenkins-bot: Don't try to pass non Title objects into RequestContext::setTitle [extensions/AbuseFilter] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148027 (owner: 10Legoktm) [23:12:13] <legoktm> > $t=microtime(true);wfWaitForSlaves();echo microtime(true)-$t; [23:12:13] <legoktm> 10.026141881943 [23:12:40] <bawolff> from the jenkins output, "...doing page_id from 200 to 399" takes 2 minutes, so if its not waiting for slaves, then its doing some really expensive queries [23:14:03] <bawolff> legoktm: out of curiosity, what does var_dump( wfGetLB()->getMaxLag() ); give? [23:14:21] <werdna> bawolff: I bet it's because there are two update.php jobs [23:14:26] <werdna> and one is causing lag, so the other one won't start [23:14:29] <legoktm> array(3) { [23:14:29] <legoktm> [0]=> [23:14:30] <legoktm> string(11) "10.68.17.94" [23:14:30] <legoktm> [1]=> [23:14:30] <legoktm> int(5168) [23:14:31] <legoktm> [2]=> [23:14:32] <legoktm> int(1) [23:14:33] <legoktm> } [23:14:41] <werdna> well, at this point it's probably more than two update.php jobs [23:14:46] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] New class for parsing MediaWiki:Sidebar-like messages into modern, nested navigation menus. [core] - 10https://gerrit.wikimedia.org/r/108045 (owner: 10Jack Phoenix) [23:15:32] <Reedy> https://integration.wikimedia.org/ci/view/Beta/job/beta-update-databases-eqiad/2741/console [23:15:43] <Reedy> there's 24 [23:15:50] <Reedy> or 31 started [23:15:53] <Reedy> 7 reported success [23:15:58] <werdna> yeah, that's probably your issue [23:16:27] <bawolff> That's probably not helping things, but still doesn't entirely make sense [23:17:35] <grrrit-wm> (03CR) 10Legoktm: "What's the planned usecase for these hooks?" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148265 (owner: 10EBernhardson) [23:17:54] <grrrit-wm> (03CR) 10Alex Monk: "You should probably mention that in the commit message" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/138890 (owner: 10Gerrit Patch Uploader) [23:19:38] <bawolff> Oh I get it, there's a $this->mWaitTimeout set to ten seconds, so that's why things aren't fully waiting [23:20:17] <grrrit-wm> (03PS1) 10MaxSem: AbuseFilter: grab https://gerrit.wikimedia.org/r/#/c/148027/ [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148267 [23:20:38] <grrrit-wm> (03CR) 10MaxSem: [C: 032 V: 032] AbuseFilter: grab https://gerrit.wikimedia.org/r/#/c/148027/ [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148267 (owner: 10MaxSem) [23:21:41] <MaxSem> bawolff, does https://gerrit.wikimedia.org/r/#/c/148241/ require a scap? [23:22:16] <bawolff> MaxSem: It adds messages, which would presumably require the i18n cache to be updated [23:22:21] * bawolff didn't even think of that [23:22:23] <grrrit-wm> (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (5ab041a801) [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/147854 (owner: 10Jforrester) [23:22:42] <bawolff> I'm not familiar enough with i18n cache to know if it specificly requires scap [23:22:42] <MaxSem> so the bug was live for some time? [23:22:44] <MaxSem> bleh [23:22:50] <bawolff> MaxSem: only on testwiki [23:23:02] <MaxSem> o rly? there's mw.org ;) [23:23:09] <bawolff> meh, who uses that ;) [23:23:34] <MaxSem> okay, let's just rely on LU [23:23:38] <bawolff> So far nobody has actually complained about the issue, I discovered it myself when testing something else [23:23:48] <bawolff> So I doubt its breaking anyone's workflow [23:23:56] <bd808> bawolff: i18n changes always need scap; sync-* won't update the message cache [23:24:08] <James_F> MaxSem: Thanks! [23:24:14] <bawolff> I mostly want to make sure that commons doesn't break come tuesday [23:24:26] <bawolff> Almost nobody outside of commons uses closed captioning anyhow [23:24:52] <withoutaname> legoktm: for https://gerrit.wikimedia.org/r/#/c/148026/1 do you want to add a warning [23:25:27] <legoktm> warning for what? [23:26:24] <grrrit-wm> (03PS16) 10Jack Phoenix: New class for parsing MediaWiki:Sidebar-like messages into modern, nested navigation menus. [core] - 10https://gerrit.wikimedia.org/r/108045 [23:27:23] <withoutaname> so a future me won't try to patch it again ^^ [23:27:59] <withoutaname> maybe a brief comment in the code [23:30:15] <legoktm> ah [23:30:30] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] New class for parsing MediaWiki:Sidebar-like messages into modern, nested navigation menus. [core] - 10https://gerrit.wikimedia.org/r/108045 (owner: 10Jack Phoenix) [23:36:21] <grrrit-wm> (03PS1) 10Prtksxna: Make the cards on the homepage clickable [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148269 [23:37:50] <grrrit-wm> (03PS1) 10MaxSem: Revert "Update Flow extension in wmf/1.24wmf14" [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148270 [23:37:59] <grrrit-wm> (03CR) 10MaxSem: [C: 032 V: 032] Revert "Update Flow extension in wmf/1.24wmf14" [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148270 (owner: 10MaxSem) [23:40:28] <grrrit-wm> (03CR) 10MaxSem: "Reverted because author wasn't present for deployment and his team was unaware what's going on." [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148249 (owner: 10EBernhardson) [23:42:04] <grrrit-wm> (03CR) 10PleaseStand: Redo WhatLinksHere query and add a *_from_namespace field to link tables (031 comment) [core] - 10https://gerrit.wikimedia.org/r/117373 (https://bugzilla.wikimedia.org/60618) (owner: 10Aaron Schulz) [23:42:28] <grrrit-wm> (03PS1) 10MSyed: Icons for homepage [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148271 [23:43:31] <grrrit-wm> (03CR) 10MSyed: [C: 032 V: 032] Make the cards on the homepage clickable [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148269 (owner: 10Prtksxna) [23:43:41] <grrrit-wm> (03CR) 10Prtksxna: [C: 032 V: 032] Icons for homepage [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148271 (owner: 10MSyed) [23:45:18] <grrrit-wm> (03PS1) 10Aaron Schulz: Fixed column name typo [core] - 10https://gerrit.wikimedia.org/r/148273 [23:46:18] <werdna> hmm, I want an extension to do something when somebody successfully watches a page using the ca-watch link (which uses AJAX). Is my only option to add a hook? [23:46:26] <werdna> If so, what secret rules are there for adding JS hooks to MW core? [23:47:53] <grrrit-wm> (03CR) 10Ori.livneh: [C: 032 V: 032] Fixed column name typo [core] - 10https://gerrit.wikimedia.org/r/148273 (owner: 10Aaron Schulz) [23:50:25] <grrrit-wm> (03PS3) 10Withoutaname: Make if checks in RequestContext.php more concise [core] - 10https://gerrit.wikimedia.org/r/145423 [23:51:56] <grrrit-wm> (03CR) 10Yaron Koren: "Great! stylize.php did accomplish a lot - among other things, it got rid of all the excess spaces and tabs that were at the end of lines b" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [23:52:32] <grrrit-wm> (03PS1) 10MSyed: Fix for image sizing issues [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148274 [23:53:26] <grrrit-wm> (03CR) 10Prtksxna: [C: 032 V: 032] Fix for image sizing issues [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148274 (owner: 10MSyed) [23:56:18] <grrrit-wm> (03PS1) 10Prtksxna: Add icons on the homepage [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/148275