[00:00:21] (03PS1) 10MSyed: Added content to homepage [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/147688 [00:00:48] (03CR) 10Mattflaschen: [C: 04-2] "Breaks mediawiki.cookie, which uses the old method of deleting cookies, as well as other code in core (look for code using $.cookie or jQu" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/139686 (owner: 10Paladox) [00:01:30] (03PS1) 10Prtksxna: Add menu on mobile [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/147689 [00:02:00] (03CR) 10Dduvall: [C: 04-1] "Generally, this looks really good—your approach to writing the tests is spot on. I've just tidied up some dependencies and put in an asser" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/125740 (owner: 10Zfilipin) [00:05:47] (03PS1) 10Bartosz Dziewoński: Example skin [skins/Example] - 10https://gerrit.wikimedia.org/r/147690 [00:07:05] 3MediaWiki / 3Categories: PAGESINCATEGORY inaccurate for large categories - 10https://bugzilla.wikimedia.org/16036#c22 (10Bawolff (Brian Wolff)) *** Bug 68240 has been marked as a duplicate of this bug. *** [00:07:05] 3MediaWiki / 3Categories: Negative membership counts in category table - 10https://bugzilla.wikimedia.org/68240#c1 (10Bawolff (Brian Wolff)) 5NEW>3RESO/DUP Consider the category table to be only a very rough measure. If the category has < 200 members, the category table entry will get updated on next vi... [00:07:52] (03CR) 10Dduvall: [C: 032] Browser test support for multiwiki [vagrant] - 10https://gerrit.wikimedia.org/r/147683 (owner: 10Dduvall) [00:07:57] (03Merged) 10jenkins-bot: Browser test support for multiwiki [vagrant] - 10https://gerrit.wikimedia.org/r/147683 (owner: 10Dduvall) [00:08:46] (03CR) 10Brian Wolff: [C: 031] "If people are getting confused, I don't see any harm in this." [core] - 10https://gerrit.wikimedia.org/r/146798 (owner: 10Jackmcbarn) [00:10:46] (03PS2) 10CSteipp: Encrypt cookie which has OAuth secret [phabricator/libphutil] - 10https://gerrit.wikimedia.org/r/147686 [00:11:11] (03CR) 10Bartosz Dziewoński: [C: 031] Make Special:Email an alias for Special:EmailUser [core] - 10https://gerrit.wikimedia.org/r/146798 (owner: 10Jackmcbarn) [00:12:40] (03PS2) 10Prtksxna: More color changes [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/147347 (owner: 10MSyed) [00:15:47] (03PS2) 10Bartosz Dziewoński: Example skin [skins/Example] - 10https://gerrit.wikimedia.org/r/147690 [00:17:07] (03CR) 10MSyed: [C: 032 V: 032] Add graphs with random data [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/145006 (owner: 10Prtksxna) [00:17:32] (03PS1) 10Werdna: Some fixes for browser tests. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147692 [00:17:39] (03CR) 10MSyed: [C: 032 V: 032] Add bubble graphs with random data [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/145525 (owner: 10Prtksxna) [00:19:10] (03CR) 10MSyed: [C: 032 V: 032] Add labels to bar chart [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/146047 (owner: 10Prtksxna) [00:19:28] (03CR) 10MSyed: [C: 032 V: 032] Switch to a 960px grid from the existing 1140px [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/146767 (owner: 10Prtksxna) [00:19:51] (03CR) 10MSyed: [C: 032 V: 032] Add styles for blockquote [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/146768 (owner: 10Prtksxna) [00:20:09] (03CR) 10MSyed: [C: 032 V: 032] Add styles for scorecard [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/146769 (owner: 10Prtksxna) [00:20:28] (03CR) 10MSyed: [C: 032 V: 032] Stop attaching d3 events multiple times [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/146770 (owner: 10Prtksxna) [00:20:48] (03CR) 10MSyed: [C: 032 V: 032] Add tooltip [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/146771 (owner: 10Prtksxna) [00:21:07] (03CR) 10MSyed: [C: 032 V: 032] Remove bars for 'Yes & No' keeping them as legends [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/146772 (owner: 10Prtksxna) [00:21:34] (03CR) 10MSyed: [C: 032 V: 032] Add stacked bars for horizontal graph [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/146773 (owner: 10Prtksxna) [00:21:54] (03CR) 10MSyed: [C: 032 V: 032] Move the elements around in the grid [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/147036 (owner: 10Prtksxna) [00:22:19] (03CR) 10MSyed: [C: 032 V: 032] Switch to SVG flags [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/147037 (owner: 10Prtksxna) [00:22:44] (03CR) 10MSyed: [C: 032 V: 032] Use data format as suggested by the legal team [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/147099 (owner: 10Prtksxna) [00:23:07] (03CR) 10MSyed: [C: 032 V: 032] Add menu on mobile [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/147689 (owner: 10Prtksxna) [00:23:24] (03CR) 10Prtksxna: [C: 032 V: 032] More color changes [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/147347 (owner: 10MSyed) [00:29:19] 3MediaWiki / 3History/Diffs: Show more user-friendly timestamps (relative like "7 hours ago" instead of absolute) - 10https://bugzilla.wikimedia.org/30857#c26 (10Matthew Flaschen) (In reply to Yuvi Panda from comment #13) > 2. Have JS (top loaded?) look for any element with the class added in (1), > and then... [00:30:03] (03PS2) 10Prtksxna: Added content to homepage [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/147688 (owner: 10MSyed) [00:30:21] (03CR) 10Prtksxna: [C: 032 V: 032] Added content to homepage [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/147688 (owner: 10MSyed) [00:34:06] (03PS2) 10Werdna: Redirect old-style permalinks to new ones. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147554 [00:37:59] (03PS1) 10MSyed: Added CSS and layout changes with new logo image file. [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/147694 [00:39:21] (03PS3) 10Bartosz Dziewoński: Example skin [skins/Example] - 10https://gerrit.wikimedia.org/r/147690 [00:39:52] (03PS2) 10EBernhardson: Repair warning on non-existant header a On a brand new flow board with no header ever created the attempt to access revision.content.content will issue a warning from lightncandy. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147649 [00:40:02] (03PS3) 10EBernhardson: Repair warning on non-existant header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147649 [00:40:40] (03PS4) 10Werdna: Fix PHP Warning on boards with no header. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147649 (owner: 10EBernhardson) [00:41:00] (03CR) 10Werdna: "Updated commit message." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147649 (owner: 10EBernhardson) [00:42:02] (03CR) 10Parent5446: "Talked with Krenair. I think this would set a bad precedent in core. Should we decide to add more language-subpage-related features into c" [core] - 10https://gerrit.wikimedia.org/r/140765 (https://bugzilla.wikimedia.org/66762) (owner: 10MaxSem) [00:42:33] (03PS5) 10Werdna: Repair warning on boards with no header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147649 (owner: 10EBernhardson) [00:42:44] (03PS2) 10MSyed: Added CSS and layout changes with new logo image file. [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/147694 [00:43:00] (03CR) 10Werdna: "PS5: Undid PS4 – didn't realise that I'd accidentally clobbered PS2,3." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147649 (owner: 10EBernhardson) [00:43:29] (03CR) 10Prtksxna: [C: 032 V: 032] "lgtm" [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/147694 (owner: 10MSyed) [00:43:35] superm401, jdlrobson : it seems there's no cron job to update tools.wmflabs.org/styleguide , I'm going to run ./generate.sh [00:44:30] (03PS2) 10EBernhardson: Preload workflows for url generator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147582 (https://bugzilla.wikimedia.org/68225) [00:45:07] (03PS5) 10Phuedx: Test .mw-ui-icon classes and mixins [core] - 10https://gerrit.wikimedia.org/r/144141 (https://bugzilla.wikimedia.org/55535) [00:45:09] (03PS12) 10Phuedx: Add icon support to mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) [00:46:11] (03CR) 10Phuedx: "PS12 changes -left and -right to -before and -after respectively." [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [00:53:55] (03PS1) 10Awight: Missed some functions only available in WikiPageMessageGroup [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/147695 [00:55:43] mwalker: have time for a very quick review? ^^ [00:56:26] (03CR) 10Mwalker: [C: 032] Missed some functions only available in WikiPageMessageGroup [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/147695 (owner: 10Awight) [00:56:31] (03Merged) 10jenkins-bot: Missed some functions only available in WikiPageMessageGroup [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/147695 (owner: 10Awight) [00:56:33] mwalker: thx! [00:56:39] I dont like anything about that hack [00:56:46] but np [00:57:08] mwalker: tell me about it. Flips OO inheritance on its head in the worst way. [00:57:30] mwalker: but, yeah patching Extension:Translate is not in scope yet. [00:57:44] heh [00:59:30] (03PS1) 10Awight: update FundraisingTranslateWorkflow submodule [core] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/147697 [00:59:58] (03PS1) 10Awight: update FundraisingTranslateWorkflow submodule [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/147698 [01:00:04] (03CR) 10Awight: [C: 032] update FundraisingTranslateWorkflow submodule [core] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/147697 (owner: 10Awight) [01:00:31] (03CR) 10Awight: [C: 032] update FundraisingTranslateWorkflow submodule [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/147698 (owner: 10Awight) [01:00:33] (03PS1) 10Awight: update FundraisingTranslateWorkflow submodule [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/147699 [01:00:39] werdna: Gee Gee Baby , 123 million views could be wrong. https://www.youtube.com/watch?v=U7mPqycQ0tQ [01:00:42] (03CR) 10Awight: [C: 032] update FundraisingTranslateWorkflow submodule [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/147699 (owner: 10Awight) [01:05:36] (03Merged) 10jenkins-bot: update FundraisingTranslateWorkflow submodule [core] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/147697 (owner: 10Awight) [01:06:41] (03Merged) 10jenkins-bot: update FundraisingTranslateWorkflow submodule [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/147698 (owner: 10Awight) [01:07:52] (03PS1) 10Prtksxna: Add data & flags. Fix tooltips. [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/147700 [01:09:10] (03Merged) 10jenkins-bot: update FundraisingTranslateWorkflow submodule [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/147699 (owner: 10Awight) [01:11:44] (03PS1) 10MSyed: Add data to csv file and fix navigation css [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/147701 [01:12:12] (03CR) 10Prtksxna: [C: 032 V: 032] Add data to csv file and fix navigation css [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/147701 (owner: 10MSyed) [01:12:47] (03CR) 10MSyed: [C: 032 V: 032] Add data & flags. Fix tooltips. [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/147700 (owner: 10Prtksxna) [01:21:19] 3Wikimedia / 3Site requests: Turn on Extension:Translate on foundationwiki (for use with board resolutions and project overviews) - 10https://bugzilla.wikimedia.org/44871#c30 (10Kunal Mehta (Legoktm)) How will Special:MyLanguage work for anonymous users (nearly everyone who visits foundationwiki)? AFAIS it w... [01:22:51] 3MediaWiki extensions / 3[other]: Add UserMerge support to CommunityVoice - 10https://bugzilla.wikimedia.org/67763 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Kunal Mehta (Legoktm) [01:30:07] 3MediaWiki extensions / 3WikidataRepo: Wikibase API lookup on sites and titles - 10https://bugzilla.wikimedia.org/68251 (10John Mark Vandenberg) 3NEW p:3Unprio s:3normal a:3Wikidata bugs When doing an API call using sites & titles, the result doesnt distinguish between a) missing title on the site, a... [01:30:49] 3MediaWiki extensions / 3WikidataRepo: Wikibase API lookup on sites and titles doesnt report missing title on site - 10https://bugzilla.wikimedia.org/68251 (10John Mark Vandenberg) s:5normal>3minor [01:39:30] (03CR) 10TTO: "Thanks for the very helpful and comprehensive reviews! Very much appreciated." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/146708 (https://bugzilla.wikimedia.org/68085) (owner: 10TTO) [01:40:22] 3Wikimedia / 3General/Unknown: activating External link icon in Arabic Wikipedia - 10https://bugzilla.wikimedia.org/68253 (10SyrianEng) 3UNCO p:3Unprio s:3enhanc a:3None in Arabic Wikipedia there is no icon differentiate between interwiki links and external web link (as hyperlinks) as in other Wikip... [01:40:30] (03CR) 10Legoktm: [C: 031] Remove hardcoded lime colour and reimplement colour-coding with class [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147660 (owner: 10Isarra) [02:13:06] 3Wikimedia / 3General/Unknown: [OPS] php5-parsekit package missing in Precise - 10https://bugzilla.wikimedia.org/40414 (10Krinkle) [02:14:06] 3Wikimedia / 3General/Unknown: Upgrade servers to Ubuntu 14.04 - 10https://bugzilla.wikimedia.org/63899 (10Krinkle) [02:16:05] 3Wikimedia / 3General/Unknown: Upgrade servers to Ubuntu 14.04 - 10https://bugzilla.wikimedia.org/63899 (10Krinkle) [02:31:26] (03CR) 10Legoktm: [C: 04-1] Global merge tool (034 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 (https://bugzilla.wikimedia.org/47918) (owner: 10Legoktm) [02:37:49] 3MediaWiki extensions / 3CentralAuth: Identify extensions that need updates to work with user merging - 10https://bugzilla.wikimedia.org/67758#c3 (10Kunal Mehta (Legoktm)) Patches awaiting review: [02:45:52] 3MediaWiki extensions / 3CreditsSource: Add UserMerge support to CreditsSource - 10https://bugzilla.wikimedia.org/67764 (10Kunal Mehta (Legoktm)) 5UNCO>3RESO/INV [03:09:42] (03CR) 10Parent5446: [C: 032] Block: $row is a stdClass, not a ResultWrapper [core] - 10https://gerrit.wikimedia.org/r/145876 (owner: 10Legoktm) [03:14:06] (03Merged) 10jenkins-bot: Block: $row is a stdClass, not a ResultWrapper [core] - 10https://gerrit.wikimedia.org/r/145876 (owner: 10Legoktm) [03:20:34] (03PS1) 10PleaseStand: Remove usage of deprecated Xml::encodeJsVar [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/147712 [03:22:15] (03PS2) 10PleaseStand: Remove usage of deprecated Xml::escapeJsString [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/147712 [03:29:49] 3MediaWiki / 3Export/Import: Travis-CI / HHVM-nightly / Import.php fails on XMLReader::open - 10https://bugzilla.wikimedia.org/68261 (10Bawolff (Brian Wolff)) [03:38:49] 3Wikimedia / 3General/Unknown: activating External link icon in Arabic Wikipedia - 10https://bugzilla.wikimedia.org/68253#c1 (10Bawolff (Brian Wolff)) 5UNCO>3RESO/INV Its caused by the following line in [[ar:MediaWiki:Common.css]] /*External link color transition **http://ar.wikipedia.org/w/index.php?d... [04:17:20] 3MediaWiki / 3Export/Import: Travis-CI / HHVM-nightly / Import.php fails on XMLReader::open - 10https://bugzilla.wikimedia.org/68261#c1 (10Max Semenik) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 66023 *** [04:17:20] 3MediaWiki / 3Export/Import: Importing does not work with HHVM - 10https://bugzilla.wikimedia.org/66023#c1 (10Max Semenik) *** Bug 68261 has been marked as a duplicate of this bug. *** [04:20:27] (03PS3) 1020after4: This refactors the maniphest event listener into a custom herald action [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/147356 [04:22:50] (03CR) 1020after4: "This isn't necessary since Evan added upstream support for storing the secret server side.." [phabricator/libphutil] - 10https://gerrit.wikimedia.org/r/147686 (owner: 10CSteipp) [04:23:18] (03CR) 1020after4: [C: 032 V: 032] Minor code cleanup [phabricator/libphutil] - 10https://gerrit.wikimedia.org/r/147670 (owner: 10CSteipp) [04:37:15] (03PS2) 10Withoutaname: Move function xmlsafe() from Export.php to OAI extension [core] - 10https://gerrit.wikimedia.org/r/147336 [05:15:56] (03PS1) 10Legoktm: Whitelist jayvdb [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/147717 [05:16:45] (03PS1) 10Brian Wolff: Split BitmapHandler into two classes. [core] - 10https://gerrit.wikimedia.org/r/147718 [05:17:25] (03PS7) 10Brian Wolff: Make PagedTiffHandler extend TransformationalImageHandler [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/86413 (https://bugzilla.wikimedia.org/52045) [05:17:27] (03PS2) 10Brian Wolff: Make tiff thumbnail in 2 steps. [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) [05:18:13] (03CR) 10jenkins-bot: [V: 04-1] Make PagedTiffHandler extend TransformationalImageHandler [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/86413 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [05:18:15] (03CR) 10jenkins-bot: [V: 04-1] Make tiff thumbnail in 2 steps. [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [05:19:28] (03CR) 10Brian Wolff: "Unit tests will fail until https://gerrit.wikimedia.org/r/147718 is merged." [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/86413 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [05:20:06] (03CR) 10Brian Wolff: "Unit tests are going to fail until https://gerrit.wikimedia.org/r/147718 is merged into core." [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135289 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [05:29:37] 3Wikimedia / 3General/Unknown: Use new labs project (extdist.wmflabs.org) for ExtensionDistributor - 10https://bugzilla.wikimedia.org/68122 (10Kunal Mehta (Legoktm)) [05:29:39] 3Wikimedia / 3General/Unknown: url-downloader.wikimedia.org proxy cannot access *.wmflabs.org - 10https://bugzilla.wikimedia.org/68264 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Needed for bug 68122. legoktm@terbium:~$ curl --proxy url-downloader.wikimedia.org:8080 -i http://extdist.... [05:41:49] 3Wikimedia / 3General/Unknown: url-downloader.wikimedia.org proxy cannot access *.wmflabs.org - 10https://bugzilla.wikimedia.org/68264#c1 (10Kunal Mehta (Legoktm)) RT #7929 [05:52:35] (03PS3) 10Spage: Redirect old-style permalinks to new ones. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147554 (https://bugzilla.wikimedia.org/68224) (owner: 10Werdna) [06:17:47] (03CR) 10Mvolz: [C: 032 V: 032] Inherits from MWCitation Dialog [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/146921 (owner: 10Mvolz) [06:22:34] 3Wikimedia / 3Mailing lists: Hotmail/MSN/Live email systems blocking WMF IP addresses, mailing list messages being blocked - 10https://bugzilla.wikimedia.org/62838#c21 (10Tony Thomas) > Hello? Can someone fix this please asap? It's pretty annoying to miss > everything without knowing when it will be fixed, a... [06:30:47] (03PS1) 1020after4: Show the wiki account uri on legalpad signature list view. [phabricator/phabricator] - 10https://gerrit.wikimedia.org/r/147723 [07:06:04] 3Wikimedia / 3Mailing lists: Hotmail/MSN/Live email systems blocking WMF IP addresses, mailing list messages being blocked - 10https://bugzilla.wikimedia.org/62838#c22 (10Tony Thomas) The above handling is only for Mediawiki, and not the Mailman. Thanks to Richard for notifying me. [07:09:02] (03CR) 10Krinkle: [C: 032] Check for boolean false result from database query in SqlBagOStuff [core] - 10https://gerrit.wikimedia.org/r/141619 (owner: 10Ori.livneh) [07:09:05] 3MediaWiki extensions / 3WikidataRepo: Implement complete RDF mapping for entities (tracking) - 10https://bugzilla.wikimedia.org/48143 (10Lydia Pintscher) [07:09:19] 3MediaWiki extensions / 3WikidataRepo: Implement RDF mapping for Claims/Statements - 10https://bugzilla.wikimedia.org/48141 (10Lydia Pintscher) [07:09:50] 3MediaWiki extensions / 3WikidataRepo: Implement RDF mapping for Data Types - 10https://bugzilla.wikimedia.org/51795 (10Lydia Pintscher) [07:10:01] (03CR) 10jenkins-bot: [V: 04-1] Check for boolean false result from database query in SqlBagOStuff [core] - 10https://gerrit.wikimedia.org/r/141619 (owner: 10Ori.livneh) [07:10:20] 3MediaWiki extensions / 3WikidataRepo: Script for creating RDF dumps of all entities - 10https://bugzilla.wikimedia.org/44580 (10Lydia Pintscher) [07:10:49] 3MediaWiki extensions / 3WikidataRepo: Partial RDF dumps - 10https://bugzilla.wikimedia.org/44581 (10Lydia Pintscher) [07:11:20] 3MediaWiki extensions / 3WikidataRepo: Provide a plain linked data interface for accessing entities (story) - 10https://bugzilla.wikimedia.org/42063 (10Lydia Pintscher) [07:12:04] 3MediaWiki extensions / 3WikidataRepo: Support output of data type descriptions via Special:EntityData - 10https://bugzilla.wikimedia.org/50661 (10Lydia Pintscher) [07:14:05] (03CR) 10Krinkle: [C: 04-1] async with upstream Kaltura player MwEmbedSupport module 2.14 (031 comment) [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/144143 (owner: 10Paladox) [07:14:46] (03CR) 10Krinkle: async with upstream Kaltura player MwEmbedSupport module 2.14 (031 comment) [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/144143 (owner: 10Paladox) [07:14:49] 3Wikimedia / 3Site requests: Turn on Extension:Translate on foundationwiki (for use with board resolutions and project overviews) - 10https://bugzilla.wikimedia.org/44871#c31 (10Nemo) If I remember correctly, Kaldari said they intend to use a specific feature of MyLanguage, that is the ability to redirect fr... [07:15:29] (03PS1) 10Deepali: Allow users to add links to the metadata [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/147725 (https://bugzilla.wikimedia.org/52816) [07:15:46] (03CR) 10Krinkle: [C: 031] Whitelist jayvdb [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/147717 (owner: 10Legoktm) [07:23:20] (03PS30) 10Krinkle: Update jquery.ui Vector theme to 1.9.2 [core] - 10https://gerrit.wikimedia.org/r/145049 (owner: 10Paladox) [07:24:17] (03CR) 10Krinkle: [C: 031] "I support this change. Our theme is out of date with the version of jQuery UI we're using. I should've re-generated the Vector theme usin" [core] - 10https://gerrit.wikimedia.org/r/145049 (owner: 10Paladox) [07:29:15] (03CR) 10Mwjames: "https://bugzilla.wikimedia.org/show_bug.cgi?id=56661 / https://s3.amazonaws.com/archive.travis-ci.org/jobs/13455252/log.txt" [core] - 10https://gerrit.wikimedia.org/r/141619 (owner: 10Ori.livneh) [07:32:44] (03PS2) 10Krinkle: Remove dead mime_content_type() code paths [core] - 10https://gerrit.wikimedia.org/r/147382 (owner: 10PleaseStand) [07:37:49] (03CR) 10Mwjames: "Can't say if this is related but as of this morning our tests fail on Travis against master (not sure what has changed) again involving Sq" [core] - 10https://gerrit.wikimedia.org/r/141619 (owner: 10Ori.livneh) [07:37:57] (03PS3) 10Krinkle: Remove dead mime_content_type() code paths [core] - 10https://gerrit.wikimedia.org/r/147382 (owner: 10PleaseStand) [07:38:42] (03CR) 10Krinkle: [C: 031] Remove dead mime_content_type() code paths [core] - 10https://gerrit.wikimedia.org/r/147382 (owner: 10PleaseStand) [07:39:08] (03PS12) 10Brion VIBBER: Work in progress: early testing of integration with ogv.js media player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) [08:08:36] 3MediaWiki / 3Database: DatabaseBase::generalizeSQL mangles table names with a number - 10https://bugzilla.wikimedia.org/67925 (10Rohan Rawat) 5NEW>3ASSI a:3Rohan Rawat [08:09:12] (03CR) 10Umherirrender: "Maybe fixed bug 56661 and bug 56909" [core] - 10https://gerrit.wikimedia.org/r/141619 (owner: 10Ori.livneh) [08:09:35] 3MediaWiki / 3Unit tests: PHP unit tests don't work if not run from tests/phpunit directory - "Call to a member function numRows() on a non-object" - 10https://bugzilla.wikimedia.org/56909#c3 (10Umherirrender) Maybe fixed by gerrit 141619 [08:09:35] 3MediaWiki / 3General/Unknown: SqlBagOStuff.php on line 232 / Invalid argument supplied for foreach() - 10https://bugzilla.wikimedia.org/56661#c2 (10Umherirrender) Maybe fixed by gerrit 141619 [08:22:33] (03CR) 10Brion VIBBER: "fixing in next patch set..." (033 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145990 (https://bugzilla.wikimedia.org/67953) (owner: 10Brion VIBBER) [08:31:26] (03PS3) 10Brion VIBBER: Optionally use avconv/ffmpeg for .ogv transcodes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145990 (https://bugzilla.wikimedia.org/67953) [08:32:24] (03CR) 10Brion VIBBER: "Latest patch set addresses comment issues and also fixes the frame rate forcing to 15fps for 160p ogg video output." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145990 (https://bugzilla.wikimedia.org/67953) (owner: 10Brion VIBBER) [08:32:36] (03PS13) 10Brion VIBBER: Work in progress: early testing of integration with ogv.js media player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) [08:36:51] 3MediaWiki / 3General/Unknown: Enable subpages by default (reverse $wgNamespacesWithSubpages) - 10https://bugzilla.wikimedia.org/68266 (10Nemo) 3NEW p:3Unprio s:3enhanc a:3None Enabling subpages with $wgNamespacesWithSubpages means two things: a) a navigational subtitle appears on pages titled A/B wh... [08:50:21] 3MediaWiki / 3Skin and page rendering: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - 10https://bugzilla.wikimedia.org/38638 (10Amir E. Aharoni) [08:50:34] 3MediaWiki / 3Skin and page rendering: Messages needing PLURAL support (tracking) - 10https://bugzilla.wikimedia.org/38781 (10Amir E. Aharoni) [08:51:20] 3MediaWiki / 3Skin and page rendering: Messages needing PLURAL support (tracking) - 10https://bugzilla.wikimedia.org/38781 (10Amir E. Aharoni) [08:51:22] 3MediaWiki extensions / 3SecurePoll: Securepoll-htmlform-daterange-relative-layout needs PLURAL support - 10https://bugzilla.wikimedia.org/68267 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Securepoll-htmlform-daterange-relative-layout needs PLURAL support for days. Even if the number is nev... [10:07:05] 3MediaWiki / 3ContentHandler: Title::getTitleValue() fails because ContentHandlerDefaultModelFor() is called for interwiki page. - 10https://bugzilla.wikimedia.org/66555#c7 (10This, that and the other) Moving to ContentHandler, as that appears to be where the bug lies. If I'm wrong, please don't hesitate to... [10:11:38] (03PS19) 10Paladox: Update jQuery Cookie to v1.3.1 [core] - 10https://gerrit.wikimedia.org/r/145884 [10:14:39] (03PS31) 10Paladox: Update jquery.ui Vector theme to 1.9.2 [core] - 10https://gerrit.wikimedia.org/r/145049 [10:19:44] (03PS1) 10Aaron Schulz: Back off of empty queues better to avoid wasting time [services/jobrunner] - 10https://gerrit.wikimedia.org/r/147732 [11:11:57] (03PS1) 10Amire80: Bidi-isolate extension version on Special:Version [core] - 10https://gerrit.wikimedia.org/r/147733 [11:13:20] 3MediaWiki extensions / 3WikidataRepo: make it possible to make the default for monolingual text no language - 10https://bugzilla.wikimedia.org/67072 (10John F. Lewis) p:5Unprio>3Low [11:14:19] 3MediaWiki extensions / 3WikidataRepo: Wikibase API lookup on sites and titles doesnt report missing title on site - 10https://bugzilla.wikimedia.org/68251 (10John F. Lewis) p:5Unprio>3Low [11:17:35] 3MediaWiki extensions / 3WikidataRepo: Can't encode MM/YYYY values for February, Augustus and December - 10https://bugzilla.wikimedia.org/68233#c5 (10John F. Lewis) 5NEW>3RESO/DUP Marking this as a duplicate of 68236 as it includes the exact issue as opposed to this bug. It should be the other way around... [11:17:36] 3MediaWiki extensions / 3WikidataRepo: Some localized dates can't be encoded in date property fields. - 10https://bugzilla.wikimedia.org/68236#c1 (10John F. Lewis) *** Bug 68233 has been marked as a duplicate of this bug. *** [11:18:04] 3MediaWiki extensions / 3WikidataRepo: Some localized dates can't be encoded in date property fields. - 10https://bugzilla.wikimedia.org/68236 (10John F. Lewis) p:5Unprio>3Low [11:23:20] 3MediaWiki extensions / 3WikidataRepo: Restore does not work - 10https://bugzilla.wikimedia.org/68218#c1 (10John F. Lewis) p:5Unprio>3Low I seem to get an edit conflict message instead. Adding testme to see if any one else can reproduce this. [11:24:06] (03PS1) 10Amire80: Automatic direction for the license in Special:Version [core] - 10https://gerrit.wikimedia.org/r/147734 [11:24:49] 3MediaWiki extensions / 3WikidataRepo: WikidataRepo: message “summary” escaped twice in undo form - 10https://bugzilla.wikimedia.org/68221 (10John F. Lewis) p:5Unprio>3Low [11:26:20] 3MediaWiki / 3ContentHandler: Title::getTitleValue() fails because ContentHandlerDefaultModelFor() is called for interwiki page. - 10https://bugzilla.wikimedia.org/66555 (10John F. Lewis) p:5Unprio>3Normal [12:42:07] (03PS1) 10Paladox: Localisation updates. [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/147736 [12:42:16] (03PS2) 10Paladox: Localisation updates. [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/147736 [12:45:13] (03CR) 10Paladox: [C: 031] Localisation updates. [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/147736 (owner: 10Paladox) [13:02:20] (03CR) 10Parent5446: [C: 032] ContextSource::getContext() can return any IContextSource [core] - 10https://gerrit.wikimedia.org/r/145877 (owner: 10Legoktm) [13:06:05] (03Merged) 10jenkins-bot: ContextSource::getContext() can return any IContextSource [core] - 10https://gerrit.wikimedia.org/r/145877 (owner: 10Legoktm) [13:06:52] 3MediaWiki extensions / 3CodeEditor: Allow searching using URL hash - 10https://bugzilla.wikimedia.org/68270 (10CodeCat) 3NEW p:3Unprio s:3enhanc a:3None Currently it's possible to link to scripts and have the editor jump to a specific line automatically. Scribunto errors use this to link to the code... [13:15:02] (03PS4) 10Thiemo Mättig (WMDE): Make an empty "?action=" parameter default to "view" [core] - 10https://gerrit.wikimedia.org/r/147058 [13:24:18] (03CR) 10Bartosz Dziewoński: [C: 032] Some misc cleanup to ProtectionForm [core] - 10https://gerrit.wikimedia.org/r/144372 (owner: 10IAlex) [13:27:56] (03Merged) 10jenkins-bot: Some misc cleanup to ProtectionForm [core] - 10https://gerrit.wikimedia.org/r/144372 (owner: 10IAlex) [13:33:36] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.user: Simplify callback [core] - 10https://gerrit.wikimedia.org/r/140906 (owner: 10Gerrit Patch Uploader) [13:33:41] (03CR) 10Parent5446: Convert SpecialRemoveGlobalBlock to use FormSpecialPage (032 comments) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/145505 (owner: 10Legoktm) [13:37:19] (03Merged) 10jenkins-bot: mediawiki.user: Simplify callback [core] - 10https://gerrit.wikimedia.org/r/140906 (owner: 10Gerrit Patch Uploader) [13:54:07] 3Wikimedia / 3Git/Gerrit: Upgrade gerrit to 2.9 - 10https://bugzilla.wikimedia.org/68271 (10paladox2015) 3UNCO p:3Unprio s:3normal a:3None Hi please upgrade gerrit to 2.9. Reason because it includes a new design by default also fixes issue and also includes a new side by side diff please see full cha... [14:29:17] (03CR) 10Alex Monk: [C: 032] Reduce dependence upon global objects [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/145504 (owner: 10Legoktm) [14:29:24] (03Merged) 10jenkins-bot: Reduce dependence upon global objects [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/145504 (owner: 10Legoktm) [14:41:41] (03Abandoned) 10Alex Monk: Support setting column-width and list-style in tag [extensions/Cite] - 10https://gerrit.wikimedia.org/r/120962 (https://bugzilla.wikimedia.org/51260) (owner: 10Alex Monk) [14:42:21] 3MediaWiki extensions / 3Cite: Cite: Support multi-column and alternative list-style for tag (like enwiki {{reflist}}) - 10https://bugzilla.wikimedia.org/51260 (10Alex Monk) 5PATC>3UNCO a:5Alex Monk>3None [14:43:44] (03Abandoned) 10Alex Monk: Insert link dialog: Insert simplest form of wikilinks possible [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/69896 (https://bugzilla.wikimedia.org/49940) (owner: 10Alex Monk) [14:43:52] 3MediaWiki extensions / 3WikiEditor: Insert Link Dialog should insert links in the shortest form - 10https://bugzilla.wikimedia.org/49940 (10Alex Monk) 5PATC>3RESO/WON a:5Alex Monk>3None [14:45:53] Krenair: is there a reason to wontfix bug 49940? [14:46:34] se4598, yes [14:47:36] go and look at the patch [14:50:32] (03PS15) 10Alex Monk: Fix interwiki userrights form tool links [core] - 10https://gerrit.wikimedia.org/r/48749 [14:51:44] Krenair: I don't see in the current ps comments or general comments of the changeset a reason for the bug to wontfix. [14:51:59] (03CR) 10jenkins-bot: [V: 04-1] Fix interwiki userrights form tool links [core] - 10https://gerrit.wikimedia.org/r/48749 (owner: 10Alex Monk) [14:51:59] se4598, no, it's not in the comments. read the actual patch itself [14:53:28] (03CR) 10Alex Monk: "Aaron, this has been waiting for you for 3 months now." [core] - 10https://gerrit.wikimedia.org/r/48661 (https://bugzilla.wikimedia.org/10545) (owner: 10Alex Monk) [14:55:01] Krenair, I don't get it :( . All I see are only problems in the current implementation attempt. [14:57:06] I understand the patch abandonment, but not the bug resolution [14:57:58] se4598, because you're going to have to take a PHP linkTrail regex, send it to the client somehow, then somehow put it in a format that JS's regex class can read [14:58:17] gl doing that in a non-hacky way that pleases everyone [14:59:10] (03CR) 10Jforrester: [C: 032] Clean up jslint errors [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/144473 (https://bugzilla.wikimedia.org/61589) (owner: 10Alex Monk) [14:59:18] (03Merged) 10jenkins-bot: Clean up jslint errors [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/144473 (https://bugzilla.wikimedia.org/61589) (owner: 10Alex Monk) [15:00:04] James_F, meh, in between me uploading that and you merging it, the rules changed [15:00:12] So it didn't fix the errors after all [15:01:54] Or at least it looks like they did, based purely on the mwext-CheckUser-jslint results [15:02:19] 3MediaWiki extensions / 3CheckUser: CheckUser should pass jshint - 10https://bugzilla.wikimedia.org/61589#c3 (10Alex Monk) 5PATC>3ASSI Wtf? Somehow, when that patch was uploaded, we got: https://integration.wikimedia.org/ci/job/mwext-CheckUser-jslint/56/console : SUCCESS in 8s (non-voting) But then when... [15:04:35] (03CR) 10Mdale: "this is pretty safe change. mwEmbedSupport will be merged into TMH, since its the only consumer now days:" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/95779 (owner: 10Mdale) [15:06:19] 3Wikimedia / 3Git/Gerrit: Upgrade gerrit to 2.9 - 10https://bugzilla.wikimedia.org/68271#c1 (10Andre Klapper) p:5Unprio>3Lowest s:5normal>3enhanc I don't consider "please upgrade some software to some latest version" very useful if there are not 1) very good reasons to do this 2) urgently. Your list... [15:07:09] hey, do you think https://gerrit.wikimedia.org/r/#/c/144829/ needs any further amendments? thanks :) [15:08:24] Krenair: I'm going to reopen the bug, stating the problem with the linkTrail. From my POV this is a code only problem (which may require a change in core). sometime in the future thing may have changed... or VisualEditor has finally taken over [15:11:20] se4598, if you want, reopen the bug [15:11:30] but the patch will stay abandoned and it will not be assigned to me [15:12:07] sure! [15:12:54] link trail rules are super stupid [15:13:03] (03PS1) 10Brian Wolff: Allow WantedQueryPage subclasses to override the existence check [core] - 10https://gerrit.wikimedia.org/r/147741 [15:13:05] (03PS1) 10Brian Wolff: Better false positive detection for Special:Wantedfiles [core] - 10https://gerrit.wikimedia.org/r/147742 [15:13:21] we should have just one sane one for all languages [15:13:57] Isn't it performance thingy? Something about arabic rules being super slow and we don't want the other langs to suck that much? [15:14:17] * bawolff not sure if it was arabic [15:14:50] I'm thinking about wontfixing a bunch more bugs [15:14:51] wasnt that about link prefixes? [15:14:58] Like https://bugzilla.wikimedia.org/show_bug.cgi?id=12518 and https://bugzilla.wikimedia.org/show_bug.cgi?id=10545 [15:15:08] prefixes are a lot weirder [15:15:25] Despite the user votes and requests, there is no interest from other developers in fixing these [15:15:38] 3MediaWiki extensions / 3WikiEditor: Insert Link Dialog should insert links in the shortest form - 10https://bugzilla.wikimedia.org/49940#c3 (10se4598) 5RESO/WON>3REOP the problem with the previous patch was to take the linkTrail php-regex and convert it to a js-regex in a non-hacky way which could be us... [15:16:01] (03PS1) 10Rohan013: Leave table names with numbers untouched in DatabaseBase::generalizeSQL [core] - 10https://gerrit.wikimedia.org/r/147743 (https://bugzilla.wikimedia.org/67925) [15:16:54] se4598, also another issue that Krinkle pointed out is that we probably shouldn't just dump this in the globals. I'm not sure what his alternative ideas were [15:17:32] yes, I saw that. [15:19:51] 3MediaWiki extensions / 3CheckUser: CheckUser should pass jshint - 10https://bugzilla.wikimedia.org/61589 (10Alex Monk) a:5Alex Monk>3Antoine "hashar" Musso [15:23:33] bawolff: did you ever see my reply on https://gerrit.wikimedia.org/r/#/c/104999/ ? [15:25:15] I saw the gerrit email a long time ago and kind of never got around to looking at it [15:25:44] To be honest, I kind of agree with Tim, seems kind of like the sort of thing that would have been better to only expose via lua [15:26:36] maybe, though the patch that exposes to lua is also collecting dust in gerrit [15:43:52] (03PS1) 10Alex Monk: Reformat modules/ext.checkuser.cidr.js, fix some jshint errors [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/147744 (https://bugzilla.wikimedia.org/61589) [15:49:04] (03PS2) 10Alex Monk: Reformat modules/ext.checkuser.cidr.js, fix some jshint errors [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/147744 (https://bugzilla.wikimedia.org/61589) [15:55:19] (03CR) 10Jforrester: [C: 031] "Looks good but haven't tested." [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/147744 (https://bugzilla.wikimedia.org/61589) (owner: 10Alex Monk) [16:02:54] hoo, legoktm: Hey [16:04:22] (03CR) 10Hoo man: [C: 032] Reformat modules/ext.checkuser.cidr.js, fix some jshint errors [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/147744 (https://bugzilla.wikimedia.org/61589) (owner: 10Alex Monk) [16:04:26] hi Krenair :) [16:04:27] (03Merged) 10jenkins-bot: Reformat modules/ext.checkuser.cidr.js, fix some jshint errors [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/147744 (https://bugzilla.wikimedia.org/61589) (owner: 10Alex Monk) [16:04:46] hoo, I've been trying to get things like https://gerrit.wikimedia.org/r/#/c/36330/ merged for a long time now [16:05:06] 3MediaWiki extensions / 3CheckUser: CheckUser should pass jshint - 10https://bugzilla.wikimedia.org/61589 (10Marius Hoch) 5PATC>3RESO/FIX [16:06:26] Krenair: I know, but I don't really have enough time to review non-trivial stuff like this [16:06:43] especially as there's so much stuff in CentralAuth which I want/ need to review as a volunteer [16:06:55] (03CR) 10SPQRobin: [C: 04-1] "The relevant code could use some more restructuring/documentation, but as far as adding the viewsuppressed right goes, this patch is okay " [core] - 10https://gerrit.wikimedia.org/r/139277 (https://bugzilla.wikimedia.org/20476) (owner: 10Vogone) [16:07:23] Krenair: wow, since 2012. Long time is an understatement [16:07:36] SPQRobin: Great that you tested it [16:07:47] it's usually ok to amend release notes yourself [16:07:50] 3Wikimedia / 3SSL related: Enable HSTS on Wikimedia wikis - 10https://bugzilla.wikimedia.org/38516#c33 (10chmarkine) Could we now raise the max-age to 1 year or longer? [16:08:00] if you do that now, I can give a +1 on the release notes and you can merge then [16:08:23] ok [16:08:35] Vogone: will you add release notes, or shall I? [16:08:42] I really want to get that in :) [16:08:47] :) [16:08:58] SPQRobin: you can do it if you want [16:09:20] bawolff, I've also tried to help maintain things like https://gerrit.wikimedia.org/r/#/c/3808/ and https://gerrit.wikimedia.org/r/#/c/5130/ before [16:11:55] (03PS19) 10SPQRobin: Split "suppressrevision" into two user rights [core] - 10https://gerrit.wikimedia.org/r/139277 (https://bugzilla.wikimedia.org/20476) (owner: 10Vogone) [16:14:44] SPQRobin: :P Don't rebase + amend in the same patch set [16:15:00] hmm [16:15:01] +50470, -33016 [16:15:12] the diff between the PSs is rather large now :P [16:16:17] hoo: is it possible to view the diff between the entire patchsets without loading each file? [16:16:31] (in a separate tab) [16:16:46] you mean all changed files on a single page? [16:16:54] yes [16:17:00] no [16:17:02] :S [16:17:27] (03CR) 10Hoo man: [C: 031] "Release notes look good, +1 as per the previous patch set" [core] - 10https://gerrit.wikimedia.org/r/139277 (https://bugzilla.wikimedia.org/20476) (owner: 10Vogone) [16:17:37] so how do you easily get the +50470, -33016? :p [16:18:43] SPQRobin: Select "Reference version" on the main change set view [16:19:00] SPQRobin, hoo: use the gitblit link and choose there commitdiff [16:19:01] Couldn't you just do that from the git client? [16:19:13] download the change, git diff ? [16:19:37] se4598: Krenair: No inline comment support there :P [16:20:27] hoo: ah, thanks, should've tried that option before :p [16:21:56] (03CR) 10SPQRobin: [C: 032] "Merging per my comment above." [core] - 10https://gerrit.wikimedia.org/r/139277 (https://bugzilla.wikimedia.org/20476) (owner: 10Vogone) [16:22:20] :| [16:34:21] 3MediaWiki extensions / 3Cite: Cite: Support multi-column and alternative list-style for tag (like enwiki {{reflist}}) - 10https://bugzilla.wikimedia.org/51260#c30 (10James Forrester) 5UNCO>3ASSI a:3Gabriel Wicke No. We /are/ going to do this. Gabriel is on the hook for suggesting how to... [16:35:04] 3Wikimedia / 3Site requests: Change namespace settings in Thai Wikipedia - 10https://bugzilla.wikimedia.org/68108#c7 (10Sorawee Porncharoenwase) 5ASSI>3RESO/FIX I found that I can use API to delete those pages. [16:39:06] 3MediaWiki extensions / 3CheckUser: CheckUser should pass jshint - 10https://bugzilla.wikimedia.org/61589 (10Alex Monk) a:5Antoine "hashar" Musso>3Alex Monk [16:41:14] hoo: do you know why the patch isn't marked as verified? https://gerrit.wikimedia.org/r/#/q/status:merged,n,z [16:41:51] because you merged it yourself and didn't wait for jenkins [16:42:01] Usually you should just [16:42:07] +2 and then wait for jenkins [16:42:21] hmm [16:42:56] so +2 and Publish Comments instead of Publish and Submit? [16:43:02] yep [16:43:31] :-S [16:45:21] (03CR) 10Ori.livneh: [C: 032] "I'll deploy" [services/jobrunner] - 10https://gerrit.wikimedia.org/r/147732 (owner: 10Aaron Schulz) [16:45:30] (03Merged) 10jenkins-bot: Back off of empty queues better to avoid wasting time [services/jobrunner] - 10https://gerrit.wikimedia.org/r/147732 (owner: 10Aaron Schulz) [16:51:19] 3Wikimedia / 3Git/Gerrit: Upgrade gerrit to 2.9 - 10https://bugzilla.wikimedia.org/68271#c2 (10Chad H.) Gerrit 2.9 includes the new change screen which is worse. That's a reason not to upgrade. Plus we're planning a Phabricator migration soon-ish. What's to gain? [16:55:01] (03CR) 10Bartosz Dziewoński: [C: 032] Remove hardcoded lime colour and reimplement colour-coding with class [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147660 (owner: 10Isarra) [16:55:05] (03Merged) 10jenkins-bot: Remove hardcoded lime colour and reimplement colour-coding with class [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147660 (owner: 10Isarra) [16:58:49] 3MediaWiki / 3Revision deletion: Split suppressrevision in two distinct permissions : the first one to oversight content, and the other one to review oversighted content - 10https://bugzilla.wikimedia.org/20476 (10Robin Pepermans (SPQRobin)) 5PATC>3RESO/FIX [16:59:07] 3MediaWiki extensions / 3BetaFeatures: Add title text for Beta in personal tools - 10https://bugzilla.wikimedia.org/68126#c1 (10Mark Holmquist) This can be accomplished without any fuss whatsoever. Add a message called "tooltip-pt-betafeatures" in en.json and describe it in qqq.json. It will get called auto... [17:22:18] (03PS1) 10Ori.livneh: Formalize conventions for Exec resources [vagrant] - 10https://gerrit.wikimedia.org/r/147748 [17:24:13] who wants to check a simple patch https://gerrit.wikimedia.org/r/#/c/144762/ [17:25:43] (03CR) 10Yurik: [C: 032] "self-+2ing, as it is for devs only" [core] - 10https://gerrit.wikimedia.org/r/144247 (owner: 10Yurik) [17:28:07] (03PS1) 10Brian Wolff: Add a maintinance report about TimedText pages that don't have a file [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/147749 [17:28:58] (03CR) 10Ori.livneh: "Not quite a -1, but an expression of minor displeasure. The fact that associative arrays in PHP are ordered is contrary to the common-sens" [core] - 10https://gerrit.wikimedia.org/r/144762 (owner: 10Yurik) [17:29:31] (03Merged) 10jenkins-bot: Updated spelling dictionary [core] - 10https://gerrit.wikimedia.org/r/144247 (owner: 10Yurik) [17:30:07] (03CR) 10Ori.livneh: [C: 032] Formalize conventions for Exec resources [vagrant] - 10https://gerrit.wikimedia.org/r/147748 (owner: 10Ori.livneh) [17:30:23] (03PS1) 10Ori.livneh: Only run mediawiki_reload provisioner if trigger exists [vagrant] - 10https://gerrit.wikimedia.org/r/147750 [17:30:43] (03Merged) 10jenkins-bot: Formalize conventions for Exec resources [vagrant] - 10https://gerrit.wikimedia.org/r/147748 (owner: 10Ori.livneh) [17:30:47] (03CR) 10Ori.livneh: [C: 032] Only run mediawiki_reload provisioner if trigger exists [vagrant] - 10https://gerrit.wikimedia.org/r/147750 (owner: 10Ori.livneh) [17:30:52] (03Merged) 10jenkins-bot: Only run mediawiki_reload provisioner if trigger exists [vagrant] - 10https://gerrit.wikimedia.org/r/147750 (owner: 10Ori.livneh) [17:33:44] (03PS7) 10Jamesmontalvo3: Add file approval and fine-tuned permissions; bump to v1.0 [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 [17:35:04] 3Wikimedia / 3Git/Gerrit: Upgrade gerrit to 2.9 - 10https://bugzilla.wikimedia.org/68271#c3 (10paladox2015) Well the new design that is an option in the current version of gerrit on wikimedia is a part of the new design but they also redesigned it complete in 2.9. It also includes a new side by side diff and... [17:36:04] 3Wikimedia / 3Git/Gerrit: Upgrade gerrit to 2.9 - 10https://bugzilla.wikimedia.org/68271#c4 (10paladox2015) It also has a new plugin for bugzilla. [17:38:35] (03CR) 10Jamesmontalvo3: "Permissions moved into $egApprovedRevsPermissions. I've tested it fairly extensively on MW 1.23 and SMW 1.9 with the following permissions" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [17:40:42] (03PS1) 10BryanDavis: File['/etc/php5/mods-available'] requires Package['php5'] [vagrant] - 10https://gerrit.wikimedia.org/r/147752 [17:41:44] (03PS2) 10BryanDavis: File['/etc/php5/mods-available'] requires Package['php5'] [vagrant] - 10https://gerrit.wikimedia.org/r/147752 [17:42:16] (03CR) 10BryanDavis: [C: 032] File['/etc/php5/mods-available'] requires Package['php5'] [vagrant] - 10https://gerrit.wikimedia.org/r/147752 (owner: 10BryanDavis) [17:42:22] (03Merged) 10jenkins-bot: File['/etc/php5/mods-available'] requires Package['php5'] [vagrant] - 10https://gerrit.wikimedia.org/r/147752 (owner: 10BryanDavis) [17:44:41] (03PS1) 10Brian Wolff: partial revert 676df858e984. Add back 3 messages that were really used. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/147754 [17:46:37] (03CR) 10Brian Wolff: "This needs to be backported to current wmf branch before tuesday." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/147754 (owner: 10Brian Wolff) [17:51:34] (03PS1) 10Isarra: Add support for enabling and displaying global interwikis [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147755 (https://bugzilla.wikimedia.org/68241) [17:51:38] (03CR) 10jenkins-bot: [V: 04-1] Add support for enabling and displaying global interwikis [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147755 (https://bugzilla.wikimedia.org/68241) (owner: 10Isarra) [17:56:48] YuviPanda, Hi there. My lab instance is not working all of a sudden! I get 404 [17:57:33] BPositive: you need to follow http://lists.wikimedia.org/pipermail/labs-l/2014-July/002752.html [17:57:36] there was an issue [17:58:46] (03PS2) 10Isarra: Add support for enabling and displaying global interwikis [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147755 (https://bugzilla.wikimedia.org/68241) [17:59:09] YuviPanda, thanks for the link. Will follow those steps [17:59:15] :) [18:19:57] (03CR) 10Isarra: "I've deployed this on uncyclomedia because if nothing else, it seems to be less broken than what we had. So you can see a live example her" [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147755 (https://bugzilla.wikimedia.org/68241) (owner: 10Isarra) [18:46:28] (03PS3) 10Isarra: Add support for enabling and displaying global interwikis [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147755 (https://bugzilla.wikimedia.org/68241) [18:56:20] 3MediaWiki-Vagrant: Update nodejs to 0.10 - 10https://bugzilla.wikimedia.org/59792#c4 (10Bryan Davis) 5PATC>3RESO/FIX Ubuntu 14.04 includes nodejs v0.10.25 as the default version. [19:00:18] (03CR) 10Legoktm: "Maybe add a comment to resources/screen.css explaining what normally goes into it?" [skins/Example] - 10https://gerrit.wikimedia.org/r/147690 (owner: 10Bartosz Dziewoński) [19:09:57] (03PS1) 10BryanDavis: Set NODE_PATH correctly for parsoid [vagrant] - 10https://gerrit.wikimedia.org/r/147757 [19:12:59] (03CR) 10BryanDavis: [C: 032] Set NODE_PATH correctly for parsoid [vagrant] - 10https://gerrit.wikimedia.org/r/147757 (owner: 10BryanDavis) [19:13:03] (03Merged) 10jenkins-bot: Set NODE_PATH correctly for parsoid [vagrant] - 10https://gerrit.wikimedia.org/r/147757 (owner: 10BryanDavis) [19:13:30] Krenair: I'll look tonight (~8-9 hours from now) [19:16:50] 3Wikimedia / 3Git/Gerrit: Upgrade gerrit to 2.9 - 10https://bugzilla.wikimedia.org/68271#c5 (10Andre Klapper) 5UNCO>3RESO/WON So if it's just some new random features with questionable gain in our usecase, I will close this as WILL NOT FIX. [19:19:16] legoktm, cool, thanks! [19:19:46] legoktm, it's not that urgent, just been sitting there since 2012 which is kind of annoying [19:29:45] (03CR) 10Aaron Schulz: "As have lots of pages I'm tagged for...so many :/" [core] - 10https://gerrit.wikimedia.org/r/48661 (https://bugzilla.wikimedia.org/10545) (owner: 10Alex Monk) [19:32:10] (03PS4) 10Isarra: Add support for enabling and displaying global interwikis [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147755 (https://bugzilla.wikimedia.org/68241) [19:37:04] 3MediaWiki-Vagrant: Script for packaging MWV and dependencies into OS X DMG - 10https://bugzilla.wikimedia.org/60982#c2 (10Bryan Davis) p:5Unprio>3Low s:5normal>3enhanc With the advent of the cross platform ISO image, I don't think this is actually worth investing energy into. One problem that would be... [19:37:50] 3Wikimedia / 3Deployment systems: [OPS] Jenkins: Package php5-parsekit missing in Trusty - 10https://bugzilla.wikimedia.org/68255#c1 (10Antoine "hashar" Musso) I am moving this to deployment component. php5-parsekit is an indirect dependency of scap which lints PHP files: scap/tasks.py: cmd = '/usr/bin/p... [19:44:19] 3Wikimedia / 3Deployment systems: [OPS] Jenkins: Package php5-parsekit missing in Trusty - 10https://bugzilla.wikimedia.org/68255#c2 (10Bryan Davis) We should really find a better way to lint than using a PECL package that hasn't had a release since 2009-10-17. The version we have installed on 12.04 hosts co... [19:44:37] 3MediaWiki extensions / 3WikidataRepo: Wikidata: CTRL+click and middle click on search suggestions doesn't open the page in a new tab - 10https://bugzilla.wikimedia.org/57709#c8 (10Helder) 5VERI>3REOP Still not working when I go to https://www.wikidata.org and type "WP:Test" in the search box and then in... [20:06:08] (03CR) 10Amire80: [C: 032] Rework mediawiki.feedback.js [core] - 10https://gerrit.wikimedia.org/r/105457 (owner: 10Gerrit Patch Uploader) [20:10:15] (03Merged) 10jenkins-bot: Rework mediawiki.feedback.js [core] - 10https://gerrit.wikimedia.org/r/105457 (owner: 10Gerrit Patch Uploader) [20:11:22] 3MediaWiki / 3JavaScript: Make skip files valid javascript files - 10https://bugzilla.wikimedia.org/68280 (10Umherirrender) 3NEW p:3Unprio s:3normal a:3None For the three skip files my IDE gives "Cannot return from outside a function or method" It is possible to make the skip files valid javascript... [20:12:48] (03CR) 10Krinkle: [C: 04-1] "It's also listed in the mediawiki.dic, maybe remove it from there as well (please use ack, grep or some cloud service to search when remov" [core] - 10https://gerrit.wikimedia.org/r/147336 (owner: 10Withoutaname) [20:17:36] (03PS1) 10Amire80: Add namespace translations to Hebrew and Russian [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147829 [20:29:45] (03PS5) 10Isarra: Add support for enabling and displaying global interwikis [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/147755 (https://bugzilla.wikimedia.org/68241) [20:36:50] 3MediaWiki / 3JavaScript: Make skip files valid javascript files - 10https://bugzilla.wikimedia.org/68280#c1 (10Bartosz Dziewoński) Krinkle has previously said that this is indeed valid (I never tried to find out, personally). See https://gerrit.wikimedia.org/r/#/c/139308/1//COMMIT_MSG and some other comment... [20:37:34] 3Wikimedia / 3Deployment systems: [OPS] Jenkins: Package php5-parsekit missing in Trusty - 10https://bugzilla.wikimedia.org/68255#c3 (10Krinkle) https://rt.wikimedia.org/Ticket/Display.html?id=7935 [20:41:34] 3MediaWiki extensions / 3WikidataRepo: {{PLURAL}} is not parsed in error messages - 10https://bugzilla.wikimedia.org/66963#c1 (10Alex Monk) Is this still valid? I just set up Wikibase as a repository and tried to add this text as a property description - I got "Must be no more than 250 characters long". [20:45:16] (03PS1) 10Umherirrender: Remove unused global declarations [core] - 10https://gerrit.wikimedia.org/r/147831 [20:57:49] 3MediaWiki / 3ResourceLoader: ResourceLoader: Skip files should be valid javascript files - 10https://bugzilla.wikimedia.org/68280#c2 (10Krinkle) p:5Unprio>3Lowest s:5normal>3enhanc Also note that this is the result of various different attempts and compromises. The dozens of other approaches all in... [21:00:33] (03CR) 10Krinkle: [C: 032] Remove unused global declarations [core] - 10https://gerrit.wikimedia.org/r/147831 (owner: 10Umherirrender) [21:04:13] (03Merged) 10jenkins-bot: Remove unused global declarations [core] - 10https://gerrit.wikimedia.org/r/147831 (owner: 10Umherirrender) [21:05:54] (03PS2) 10Reedy: mw.loader: Optimise away duplicate else branches in getMarker() [core] - 10https://gerrit.wikimedia.org/r/146679 (owner: 10Krinkle) [21:05:59] (03CR) 10Reedy: [C: 032] mw.loader: Optimise away duplicate else branches in getMarker() [core] - 10https://gerrit.wikimedia.org/r/146679 (owner: 10Krinkle) [21:07:20] (03CR) 10Krinkle: "Hm.. why was the [key] removed? Or was it already redundant?" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/138890 (owner: 10Gerrit Patch Uploader) [21:09:19] 3MediaWiki / 3JavaScript: accessKeyLabel not available in Firefox for addPortletLink - 10https://bugzilla.wikimedia.org/67946#c2 (10Krinkle) Upstream bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=1037990 [21:11:19] (03Merged) 10jenkins-bot: mw.loader: Optimise away duplicate else branches in getMarker() [core] - 10https://gerrit.wikimedia.org/r/146679 (owner: 10Krinkle) [21:11:43] (03CR) 10Bartosz Dziewoński: [C: 032] mw.loader: Don't create addScript() callback if we don't need one [core] - 10https://gerrit.wikimedia.org/r/146680 (owner: 10Krinkle) [21:12:35] (03PS1) 10Physikerwelt: Fix broken unit tests [extensions/Math] - 10https://gerrit.wikimedia.org/r/147834 [21:12:37] (03PS1) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/147835 [21:14:03] (03CR) 10Physikerwelt: Render MathJax on load (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/130828 (owner: 10Esanders) [21:16:54] (03PS3) 10Withoutaname: Move function xmlsafe() from Export.php to OAI extension [core] - 10https://gerrit.wikimedia.org/r/147336 [21:16:59] Krinkle: ^ [21:17:16] also I thought the dictionary update from https://gerrit.wikimedia.org/r/#/c/144247/ would help solve that problem but oh well [21:17:25] withoutaname: And a release note maybe? Then I'll merge it right away. [21:18:09] (03PS4) 10Withoutaname: Move function xmlsafe() from Export.php to OAI extension [core] - 10https://gerrit.wikimedia.org/r/147336 [21:20:03] (03CR) 10Krinkle: [C: 032] Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/147835 (owner: 10Umherirrender) [21:20:27] (03CR) 10Physikerwelt: Render MathJax on load (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/130828 (owner: 10Esanders) [21:21:18] (03PS2) 10Physikerwelt: Fix broken unit tests [extensions/Math] - 10https://gerrit.wikimedia.org/r/147834 [21:23:47] (03Merged) 10jenkins-bot: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/147835 (owner: 10Umherirrender) [21:24:29] (03PS5) 10Withoutaname: Move function xmlsafe() from Export.php to OAI extension [core] - 10https://gerrit.wikimedia.org/r/147336 [21:25:00] (03PS1) 10Ori.livneh: git::clone: set cwd to always be '/' [vagrant] - 10https://gerrit.wikimedia.org/r/147838 [21:25:16] (03PS1) 10Yuvipanda: Don't pass --quiet to composer when installing [vagrant] - 10https://gerrit.wikimedia.org/r/147839 [21:25:20] ori: ^ [21:25:34] Krinkle: done, and thanks for takin a look at it [21:26:05] (03PS2) 10Ori.livneh: Don't pass --quiet to composer when installing [vagrant] - 10https://gerrit.wikimedia.org/r/147839 (owner: 10Yuvipanda) [21:26:11] (03CR) 10Ori.livneh: [C: 032] Don't pass --quiet to composer when installing [vagrant] - 10https://gerrit.wikimedia.org/r/147839 (owner: 10Yuvipanda) [21:26:54] (03PS6) 10Krinkle: Move function xmlsafe() from Export.php to OAI extension [core] - 10https://gerrit.wikimedia.org/r/147336 (owner: 10Withoutaname) [21:27:02] (03Merged) 10jenkins-bot: Don't pass --quiet to composer when installing [vagrant] - 10https://gerrit.wikimedia.org/r/147839 (owner: 10Yuvipanda) [21:27:10] (03CR) 10Ori.livneh: [C: 032] git::clone: set cwd to always be '/' [vagrant] - 10https://gerrit.wikimedia.org/r/147838 (owner: 10Ori.livneh) [21:27:47] (03CR) 10Krinkle: [C: 032] "Rephrased slightly to emphasise it being removed. Thanks!" [core] - 10https://gerrit.wikimedia.org/r/147336 (owner: 10Withoutaname) [21:28:23] (03Merged) 10jenkins-bot: git::clone: set cwd to always be '/' [vagrant] - 10https://gerrit.wikimedia.org/r/147838 (owner: 10Ori.livneh) [21:32:06] (03Merged) 10jenkins-bot: Move function xmlsafe() from Export.php to OAI extension [core] - 10https://gerrit.wikimedia.org/r/147336 (owner: 10Withoutaname) [21:33:23] (03CR) 10Physikerwelt: "Hi Frédéric," [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/143323 (owner: 10Hcohl) [21:38:03] (03PS3) 10Physikerwelt: Displaystyle in Mathoid 0.2.5 [extensions/Math] - 10https://gerrit.wikimedia.org/r/145754 [21:38:59] (03CR) 10jenkins-bot: [V: 04-1] Displaystyle in Mathoid 0.2.5 [extensions/Math] - 10https://gerrit.wikimedia.org/r/145754 (owner: 10Physikerwelt) [21:50:42] (03CR) 10Physikerwelt: Displaystyle in Mathoid 0.2.5 (033 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/145754 (owner: 10Physikerwelt) [21:52:04] (03PS4) 10Physikerwelt: Displaystyle in Mathoid 0.2.5 [extensions/Math] - 10https://gerrit.wikimedia.org/r/145754 [21:56:23] (03CR) 10Physikerwelt: "Frédéric," (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/145453 (owner: 10Physikerwelt) [21:59:07] (03PS1) 10Yuvipanda: Increase socket timeouts for Composer under HHVM [vagrant] - 10https://gerrit.wikimedia.org/r/147842 [21:59:09] bd808: ^ [21:59:09] (03CR) 10jenkins-bot: [V: 04-1] Increase socket timeouts for Composer under HHVM [vagrant] - 10https://gerrit.wikimedia.org/r/147842 (owner: 10Yuvipanda) [21:59:12] bah [21:59:54] (03PS2) 10Yuvipanda: Increase socket timeouts for Composer under HHVM [vagrant] - 10https://gerrit.wikimedia.org/r/147842 [22:01:03] bd808: ^ [22:01:31] (03CR) 10BryanDavis: "Tiny quibble." (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/147842 (owner: 10Yuvipanda) [22:02:45] (03CR) 10Frédéric Wang: Displaystyle in Mathoid 0.2.5 (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/145754 (owner: 10Physikerwelt) [22:04:34] (03CR) 10Frédéric Wang: Add default display options (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/145453 (owner: 10Physikerwelt) [22:05:15] (03PS1) 10Withoutaname: Remove deprecated Title::userCanRead() [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/147844 [22:05:24] (03PS3) 10Yuvipanda: Increase socket timeouts for Composer under HHVM [vagrant] - 10https://gerrit.wikimedia.org/r/147842 [22:05:25] bd808: ^ updated. [22:05:52] (03CR) 10BryanDavis: [C: 032] Increase socket timeouts for Composer under HHVM [vagrant] - 10https://gerrit.wikimedia.org/r/147842 (owner: 10Yuvipanda) [22:05:57] (03Merged) 10jenkins-bot: Increase socket timeouts for Composer under HHVM [vagrant] - 10https://gerrit.wikimedia.org/r/147842 (owner: 10Yuvipanda) [22:07:59] (03PS1) 10Withoutaname: Remove deprecated Title::userCanRead() [extensions/SlimboxThumbs] - 10https://gerrit.wikimedia.org/r/147846 [22:08:45] (03PS1) 10BryanDavis: Do not set cwd for all Exec in ::mediawiki [vagrant] - 10https://gerrit.wikimedia.org/r/147847 [22:10:23] (03PS2) 10BryanDavis: Do not set cwd for all Exec in ::mediawiki [vagrant] - 10https://gerrit.wikimedia.org/r/147847 [22:10:23] (03PS1) 10Withoutaname: Remove deprecated Title::userCanRead() [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/147848 [22:11:57] (03CR) 10Brion VIBBER: [C: 04-1] "Hmm, that does remind me -- sometimes you have to use the same parameter multiple times on a command line, say this one I grabbed from ffm" [core] - 10https://gerrit.wikimedia.org/r/144762 (owner: 10Yurik) [22:13:17] (03CR) 10Withoutaname: "https://gerrit.wikimedia.org/r/#/c/147843/" [core] - 10https://gerrit.wikimedia.org/r/146725 (owner: 10Withoutaname) [22:16:21] (03CR) 10MZMcBride: "Good to go?" [core] - 10https://gerrit.wikimedia.org/r/141282 (https://bugzilla.wikimedia.org/62602) (owner: 10Legoktm) [22:16:41] Carmela: it has a dependency upon the other patchset [22:17:03] (03PS3) 10Withoutaname: Remove deprecated Title::userCanRead() [core] - 10https://gerrit.wikimedia.org/r/146725 [22:17:48] (03CR) 10MZMcBride: "Ah, never mind, I see the unresolved dependency." [core] - 10https://gerrit.wikimedia.org/r/141282 (https://bugzilla.wikimedia.org/62602) (owner: 10Legoktm) [22:17:53] legoktm: So it does. [22:20:05] 3MediaWiki extensions / 3CentralAuth: Local contribution lists of globally hidden accounts no longer visible to stewards - 10https://bugzilla.wikimedia.org/20954#c12 (10Vogone) 5REOP>3RESO/FIX Should be RESOLVED FIXED together with bug 20476 and after code is deployed to production. Feel free to reopen i... [22:22:04] (03PS1) 10Aaron Schulz: Avoid useless delay and master connections in wfWaitForSlaves() in runJobs.php [core] - 10https://gerrit.wikimedia.org/r/147849 [22:22:57] (03CR) 10Physikerwelt: Add default display options (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/145453 (owner: 10Physikerwelt) [22:29:24] (03CR) 10Jdlrobson: [C: 032] "Needs a rebase but looks good to me." [core] - 10https://gerrit.wikimedia.org/r/138652 (https://bugzilla.wikimedia.org/66440) (owner: 10Bartosz Dziewoński) [22:29:44] (03PS6) 10Physikerwelt: Add default display options [extensions/Math] - 10https://gerrit.wikimedia.org/r/145453 [22:30:20] 3MediaWiki / 3Revision deletion: Local contribution lists of globally hidden accounts no longer visible to stewards - 10https://bugzilla.wikimedia.org/20954 (10Vogone) [22:30:24] (03CR) 10jenkins-bot: [V: 04-1] Support for enabling skins in the installer [core] - 10https://gerrit.wikimedia.org/r/138652 (https://bugzilla.wikimedia.org/66440) (owner: 10Bartosz Dziewoński) [22:31:21] (03CR) 10jenkins-bot: [V: 04-1] Add default display options [extensions/Math] - 10https://gerrit.wikimedia.org/r/145453 (owner: 10Physikerwelt) [22:32:04] (03PS1) 10Jack Phoenix: Fix invalid special page name. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/147851 [22:32:09] (03PS7) 10Physikerwelt: Add default display options [extensions/Math] - 10https://gerrit.wikimedia.org/r/145453 [22:32:46] (03CR) 10Jack Phoenix: [C: 032 V: 032] Fix invalid special page name. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/147851 (owner: 10Jack Phoenix) [22:33:43] (03PS5) 10Physikerwelt: Displaystyle in Mathoid 0.2.5 [extensions/Math] - 10https://gerrit.wikimedia.org/r/145754 [22:33:59] (03CR) 10Jforrester: [C: 032] Fix broken unit tests [extensions/Math] - 10https://gerrit.wikimedia.org/r/147834 (owner: 10Physikerwelt) [22:34:38] (03CR) 10Physikerwelt: Displaystyle in Mathoid 0.2.5 (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/145754 (owner: 10Physikerwelt) [22:34:49] 3MediaWiki-Vagrant: Archives directory /vagrant/apt-cache/partial is missing. - 10https://bugzilla.wikimedia.org/67976#c1 (10Bryan Davis) I can't recreate this in a clean checkout of MediaWiki-Vagrant. The cache/apt/partial directory exists in the git repository. Your problem may have been a bug in the cache m... [22:35:33] (03Merged) 10jenkins-bot: Fix broken unit tests [extensions/Math] - 10https://gerrit.wikimedia.org/r/147834 (owner: 10Physikerwelt) [22:35:42] (03PS3) 10Jforrester: Add Moritz Schubotz and Derk-Jan Hartman as authors [extensions/Math] - 10https://gerrit.wikimedia.org/r/146094 (owner: 10Amire80) [22:36:17] (03PS5) 10Jforrester: Specify dialog size in VisualEditor [extensions/Math] - 10https://gerrit.wikimedia.org/r/145059 (owner: 10Trevor Parscal) [22:36:55] (03CR) 10Jforrester: [C: 032] Add Moritz Schubotz and Derk-Jan Hartman as authors [extensions/Math] - 10https://gerrit.wikimedia.org/r/146094 (owner: 10Amire80) [22:38:40] (03CR) 10Jforrester: [C: 032] Specify dialog size in VisualEditor [extensions/Math] - 10https://gerrit.wikimedia.org/r/145059 (owner: 10Trevor Parscal) [22:38:52] (03Merged) 10jenkins-bot: Add Moritz Schubotz and Derk-Jan Hartman as authors [extensions/Math] - 10https://gerrit.wikimedia.org/r/146094 (owner: 10Amire80) [22:40:03] (03Merged) 10jenkins-bot: Specify dialog size in VisualEditor [extensions/Math] - 10https://gerrit.wikimedia.org/r/145059 (owner: 10Trevor Parscal) [22:46:03] (03CR) 10BryanDavis: Do not set cwd for all Exec in ::mediawiki (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/147847 (owner: 10BryanDavis) [22:46:10] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (5ab041a801) [core] - 10https://gerrit.wikimedia.org/r/147852 [22:46:38] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (5ab041a801) [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/147854 [22:47:05] 3MediaWiki extensions / 3CirrusSearch: Suggest results which differ in diacritics (missing ascii normalized lookup) - 10https://bugzilla.wikimedia.org/67521#c3 (10Andre Klapper) *** Bug 68239 has been marked as a duplicate of this bug. *** [22:47:05] 3MediaWiki extensions / 3CirrusSearch: Cirrus Search not offer suggestions for missed diacritic letters - 10https://bugzilla.wikimedia.org/68239#c2 (10Andre Klapper) 5UNCO>3RESO/DUP Hi Dan. Thanks for taking the time to report this! This particular problem has already been reported into our bug tracking... [22:49:07] 3MediaWiki extensions / 3WikidataRepo: Unable to edit statements - 10https://bugzilla.wikimedia.org/68284 (10mj94wiki) 3UNCO p:3Unprio s:3normal a:3Wikidata bugs Created attachment 15983 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15983&action=edit video demonstration of bug I am unable t... [22:51:49] 3MediaWiki extensions / 3WikidataRepo: Unable to edit statements - 10https://bugzilla.wikimedia.org/68284#c1 (10John F. Lewis) 5UNCO>3NEW p:5Unprio>3Normal Unable to reproduce myself but evidenced it is an issue. Tagged as testme. [23:02:26] (03CR) 10Ori.livneh: [C: 032] Avoid useless delay and master connections in wfWaitForSlaves() in runJobs.php [core] - 10https://gerrit.wikimedia.org/r/147849 (owner: 10Aaron Schulz) [23:06:09] (03Merged) 10jenkins-bot: Avoid useless delay and master connections in wfWaitForSlaves() in runJobs.php [core] - 10https://gerrit.wikimedia.org/r/147849 (owner: 10Aaron Schulz) [23:07:06] (03PS1) 10Withoutaname: Remove deprecated HistoryPage class [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/147855 [23:07:59] (03PS1) 10Aaron Schulz: Avoid useless delay and master connections in wfWaitForSlaves() in runJobs.php [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/147856 [23:08:08] (03CR) 10Aaron Schulz: [C: 032] Avoid useless delay and master connections in wfWaitForSlaves() in runJobs.php [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/147856 (owner: 10Aaron Schulz) [23:09:07] (03PS4) 10Withoutaname: Remove deprecated HistoryPage class [core] - 10https://gerrit.wikimedia.org/r/147053 [23:09:49] (03CR) 10Withoutaname: "https://gerrit.wikimedia.org/r/#/c/147855/" [core] - 10https://gerrit.wikimedia.org/r/147053 (owner: 10Withoutaname) [23:10:17] (03CR) 10Isarra: "I'll try making a skin from this and see what happens. Not that this is a particularly good test case since I'm probably one of the most f" [skins/Example] - 10https://gerrit.wikimedia.org/r/147690 (owner: 10Bartosz Dziewoński) [23:11:39] (03CR) 10Ori.livneh: [C: 032] Do not set cwd for all Exec in ::mediawiki [vagrant] - 10https://gerrit.wikimedia.org/r/147847 (owner: 10BryanDavis) [23:13:07] (03Merged) 10jenkins-bot: Avoid useless delay and master connections in wfWaitForSlaves() in runJobs.php [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/147856 (owner: 10Aaron Schulz) [23:13:45] (03Merged) 10jenkins-bot: Do not set cwd for all Exec in ::mediawiki [vagrant] - 10https://gerrit.wikimedia.org/r/147847 (owner: 10BryanDavis) [23:14:05] 3MediaWiki extensions / 3WikidataRepo: label for sitelink target input box on Special:SetSitelink - 10https://bugzilla.wikimedia.org/63485#c4 (10Alex Monk) So I think it's when we have 'id', 'site' and 'page' all set in the URL. [23:14:48] (03PS4) 10Withoutaname: Remove deprecated RawPage class [core] - 10https://gerrit.wikimedia.org/r/147052 [23:14:55] (03PS2) 10Ori.livneh: mw.loader: Don't create addScript() callback if we don't need one [core] - 10https://gerrit.wikimedia.org/r/146680 (owner: 10Krinkle) [23:15:03] (03CR) 10Ori.livneh: [C: 032] mw.loader: Don't create addScript() callback if we don't need one [core] - 10https://gerrit.wikimedia.org/r/146680 (owner: 10Krinkle) [23:16:34] 3MediaWiki extensions / 3WikidataRepo: label for sitelink target input box on Special:SetSitelink - 10https://bugzilla.wikimedia.org/63485#c5 (10Alex Monk) Actually just 'id' and 'site'. In this case, the form gives you just an input for 'page' (defaulting to 'page' from the URL, if it was set). [23:17:17] (03CR) 10Withoutaname: "https://gerrit.wikimedia.org/r/#/c/147044/" [core] - 10https://gerrit.wikimedia.org/r/147052 (owner: 10Withoutaname) [23:20:26] (03PS1) 10Aaron Schulz: Added a hasMasterConnection() method to LoadBalancer [core] - 10https://gerrit.wikimedia.org/r/147861 [23:20:50] (03PS2) 10Ori.livneh: mw.loader: Create 'skipped' property in registry for debugging [core] - 10https://gerrit.wikimedia.org/r/146681 (owner: 10Krinkle) [23:20:54] (03Merged) 10jenkins-bot: mw.loader: Don't create addScript() callback if we don't need one [core] - 10https://gerrit.wikimedia.org/r/146680 (owner: 10Krinkle) [23:21:15] ori: https://gerrit.wikimedia.org/r/#/c/147861/1 [23:21:59] oh. sloppy! [23:22:01] * AaronSchulz just noticed that while backporting [23:22:11] (03PS1) 10Kunalgrover05: Use ULS if available on Special:PageLanguage [core] - 10https://gerrit.wikimedia.org/r/147862 [23:22:19] I though about changing isOpen()...but decided against [23:22:36] (03CR) 10Ori.livneh: [C: 032] Added a hasMasterConnection() method to LoadBalancer [core] - 10https://gerrit.wikimedia.org/r/147861 (owner: 10Aaron Schulz) [23:22:42] * ori agrees [23:22:44] translating DB_MASTER to 0 is fairly DWIM [23:23:22] but then people might expect DB_SLAVE to work...which I guess could maybe translate to mReadIndex...not sure [23:23:49] (03PS1) 10Aaron Schulz: Added a hasMasterConnection() method to LoadBalancer [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/147864 [23:24:15] (03CR) 10Aaron Schulz: [C: 032] Added a hasMasterConnection() method to LoadBalancer [core] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/147864 (owner: 10Aaron Schulz) [23:24:51] 3MediaWiki-Vagrant: Archives directory /vagrant/apt-cache/partial is missing. - 10https://bugzilla.wikimedia.org/67976#c2 (10Tisza Gergő) Yes, this doesn't happen in a new vagrant installation, but breaks an upgrade attempt of an old one in a really ugly way (in the end I had to migrate everything manually to... [23:29:39] (03Merged) 10jenkins-bot: Added a hasMasterConnection() method to LoadBalancer [core] - 10https://gerrit.wikimedia.org/r/147861 (owner: 10Aaron Schulz) [23:35:34] 3MediaWiki extensions / 3WikidataClient: make maintenance script to update user recent changes preferences - 10https://bugzilla.wikimedia.org/62054#c1 (10Alex Monk) update user_properties set up_property = 'rcshowwikibase' where up_property = 'rcshowwikidata'; I'm not sure why we would want a maintenance sc... [23:44:02] (03PS14) 10Krinkle: OutputPage: Support foreign module sources in makeResourceLoaderLink [core] - 10https://gerrit.wikimedia.org/r/142766 (owner: 10Legoktm) [23:47:28] (03CR) 10Bartosz Dziewoński: "So?" [core] - 10https://gerrit.wikimedia.org/r/130024 (https://bugzilla.wikimedia.org/64513) (owner: 10Bartosz Dziewoński) [23:47:43] ori: wanna? ^ [23:49:30] (03PS7) 10Krinkle: Add OutputPageScriptsForBottomQueue hook [core] - 10https://gerrit.wikimedia.org/r/141282 (https://bugzilla.wikimedia.org/62602) (owner: 10Legoktm) [23:57:07] (03CR) 10Krinkle: [C: 032] OutputPage: Support foreign module sources in makeResourceLoaderLink [core] - 10https://gerrit.wikimedia.org/r/142766 (owner: 10Legoktm)