[00:00:10] (03CR) 10Chad: [C: 032] Avoid wfWaitForSlaves() call when in a transaction in ActiveUsers [core] - 10https://gerrit.wikimedia.org/r/145053 (owner: 10Aaron Schulz) [00:02:08] (03PS1) 10Bsitu: Update wikifont icon in 'More option' menu [extensions/Flow] - 10https://gerrit.wikimedia.org/r/146352 [00:04:44] (03Merged) 10jenkins-bot: Avoid wfWaitForSlaves() call when in a transaction in ActiveUsers [core] - 10https://gerrit.wikimedia.org/r/145053 (owner: 10Aaron Schulz) [00:11:00] ^d: wait, so where would the code go, if not into action? [00:11:28] for example Article.php recommends "@todo Move and rewrite code to an Action class" [00:12:17] ^demon|onthemove: ^ [00:16:09] (03PS1) 10Bsitu: Update TOC line height & font size [extensions/Flow] - 10https://gerrit.wikimedia.org/r/146357 [00:27:30] (03PS1) 10Withoutaname: Remove deprecated Linker::makeKnownLinkObj() [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/146360 [00:28:23] * Jasper_Deng congratulates Krenair on getting global editinterface [00:28:52] (03CR) 10Legoktm: [C: 032] "Yay!" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143401 (owner: 10CSteipp) [00:29:03] (03Merged) 10jenkins-bot: Some initial tests for CentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143401 (owner: 10CSteipp) [00:29:11] um, thanks Jasper_Deng [00:29:24] (03PS2) 10Ori.livneh: Added more error message calls [services/jobrunner] - 10https://gerrit.wikimedia.org/r/145456 (owner: 10Aaron Schulz) [00:30:06] (03CR) 10Ori.livneh: [C: 032 V: 032] Added more error message calls [services/jobrunner] - 10https://gerrit.wikimedia.org/r/145456 (owner: 10Aaron Schulz) [00:31:35] (03PS2) 10Withoutaname: Remove deprecated methods from Linker.php [core] - 10https://gerrit.wikimedia.org/r/145744 [00:36:06] (03CR) 10Ori.livneh: [C: 032] "I'll follow up with a patch to make this fetch changes from upstream periodically" [vagrant] - 10https://gerrit.wikimedia.org/r/146295 (owner: 10Ori.livneh) [00:36:59] (03Merged) 10jenkins-bot: Use jobrunner service in vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/146295 (owner: 10Ori.livneh) [00:37:17] (03CR) 10Helder.wiki: [C: 031] Add Moritz Schubotz and Derk-Jan Hartman as authors [extensions/Math] - 10https://gerrit.wikimedia.org/r/146094 (owner: 10Amire80) [00:38:30] (03PS2) 10Helder.wiki: Fix use of mw.util.tooltipAccessKeyRegexp [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/146351 (https://bugzilla.wikimedia.org/65438) (owner: 10Alex Monk) [00:40:15] (03PS3) 10Alex Monk: Fix use of mw.util.tooltipAccessKeyRegexp [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/146351 (https://bugzilla.wikimedia.org/65438) [00:43:08] (03PS1) 10PleaseStand: Database: Remove use of strencode() in replaceVars() [core] - 10https://gerrit.wikimedia.org/r/146363 [00:44:01] (03PS3) 10Legoktm: Prevent creation of unattached accounts (behind config flag) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145732 (https://bugzilla.wikimedia.org/67901) [00:44:21] (03CR) 10Legoktm: Prevent creation of unattached accounts (behind config flag) (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145732 (https://bugzilla.wikimedia.org/67901) (owner: 10Legoktm) [00:44:40] finally [00:44:59] (03CR) 10Hoo man: "Several style comments that should be addressed" (0312 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143401 (owner: 10CSteipp) [00:45:33] (03CR) 10jenkins-bot: [V: 04-1] Database: Remove use of strencode() in replaceVars() [core] - 10https://gerrit.wikimedia.org/r/146363 (owner: 10PleaseStand) [00:46:47] (03CR) 10Hoo man: [C: 04-1] "Needs rebase, comments from https://gerrit.wikimedia.org/r/143401 should be addressed first (and please not in here, make that a separate " [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145190 (owner: 10CSteipp) [00:51:20] (03PS1) 10Ori.livneh: HHVM: set JitAFrozenSize to 100mb [vagrant] - 10https://gerrit.wikimedia.org/r/146365 [00:51:40] (03CR) 10Ori.livneh: [C: 032] HHVM: set JitAFrozenSize to 100mb [vagrant] - 10https://gerrit.wikimedia.org/r/146365 (owner: 10Ori.livneh) [00:51:45] (03Merged) 10jenkins-bot: HHVM: set JitAFrozenSize to 100mb [vagrant] - 10https://gerrit.wikimedia.org/r/146365 (owner: 10Ori.livneh) [00:53:06] (03PS2) 10PleaseStand: Database: Remove use of strencode() in replaceVars() [core] - 10https://gerrit.wikimedia.org/r/146363 [00:54:55] (03CR) 10jenkins-bot: [V: 04-1] Database: Remove use of strencode() in replaceVars() [core] - 10https://gerrit.wikimedia.org/r/146363 (owner: 10PleaseStand) [00:55:25] (03PS3) 10PleaseStand: Database: Remove use of strencode() in replaceVars() [core] - 10https://gerrit.wikimedia.org/r/146363 [01:10:56] (03PS9) 10Legoktm: Show Captcha after click on edit over buttons on EditPage [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/136323 (https://bugzilla.wikimedia.org/19648) (owner: 10Florianschmidtwelzow) [01:17:40] (03PS1) 10Mwalker: Detailed Health Check [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/146368 [01:18:00] (03CR) 10jenkins-bot: [V: 04-1] Detailed Health Check [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/146368 (owner: 10Mwalker) [01:33:09] (03PS2) 10Mwalker: Detailed Health Check [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/146368 [01:33:25] (03PS1) 10Legoktm: Replace usage of deprecated Skin::getUsableSkins [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/146369 [01:33:41] marktraceur: ^ [01:34:10] (03CR) 10Jforrester: [C: 032] Replace usage of deprecated Skin::getUsableSkins [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/146369 (owner: 10Legoktm) [01:34:15] (03Merged) 10jenkins-bot: Replace usage of deprecated Skin::getUsableSkins [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/146369 (owner: 10Legoktm) [01:34:26] James_F: thanks! [01:35:06] legoktm: Easy +2s always welcome. Thank *you*! [01:38:38] (03PS4) 10PleaseStand: Database: Remove use of strencode() in replaceVars() [core] - 10https://gerrit.wikimedia.org/r/146363 [01:39:18] inb4 James_F crashes the cluster [01:39:39] marktraceur: ? [01:40:57] James_F: Your merge there [01:41:10] marktraceur: Yes? [01:42:09] (03PS1) 10Legoktm: Add CSS class for "Use this preference on all wikis" checkboxes [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/146370 [01:42:21] quiddity: ^ [01:42:34] (03CR) 10Legoktm: [C: 032] Add CSS class for "Use this preference on all wikis" checkboxes [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/146370 (owner: 10Legoktm) [01:42:38] (03Merged) 10jenkins-bot: Add CSS class for "Use this preference on all wikis" checkboxes [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/146370 (owner: 10Legoktm) [01:42:57] legoktm: Tsk self-merge. :-) [01:43:24] James_F: Just saying it would be funny if it broke something. [01:43:43] James_F: I don't think ShoutWiki will care much that I self-merged. [01:43:45] marktraceur: Oh, right. MW documentation swore otherwise, and legoktm is normally sane. :-) [01:44:02] legoktm: I know, but best practice is best for a reason. :-) [01:44:22] James_F: Which legoktm are we talking about now [01:44:34] * quiddity whaps marktraceur ;p [01:45:54] marktraceur: "If you can't say something nice, don't say nothing at all". [01:46:20] I hear objections but not arguments. :P [01:46:30] quiddity: so what kind of styling were you thinking of? I suck at CSS [01:46:47] ! [01:47:42] >.< [01:47:50] legoktm, umm, just put the font-size:17px and see how that works? something simple, that we can easily override [01:48:45] i don't even know what kind of styling could hypothetically be put on the checkbox itself (if any). And I direly need food, so will not investigate at this moment! [01:50:38] quiddity: looks...weird: http://cl.ly/image/2J2U0J1O3J1S [01:50:48] quiddity: I don't think you can style checkboxes... [01:51:30] not easily, no [01:51:34] welcome to a world of pain [01:51:42] when trying to style
controls [01:51:52] oh it needs the margin, too. [01:51:58] YuviPanda: suggestions? :D for https://bugzilla.wikimedia.org/show_bug.cgi?id=66869 [01:52:15] the margin is the crucial part! [01:52:17] legoktm: prtksxna knows way more about this than I do [01:52:23] orders of magnitude more :) [01:52:34] quiddity: what's the margin CSS? [01:54:00] prtksxna: Hi. Hovercards (Popups extension) uses the title attribute of a link in its API query for extracts and pageimages. Parsoid HTML doesn't have a title attribute, and Flow doesn't include the namespace in User: links. Part of why there are no hovercards on Flow boards. [01:54:02] err, padding-left:20x maybe? [01:54:06] px [01:54:49] legoktm: For the global preference, they are slightly indented. 20px should do [01:55:23] I guess putting the wikified page title in title attr is the behavior of Linker or Parser [01:55:36] spagewmf: Yup, I was discussing with thedj somewhere that we should be looking at the link instead of the title. It'll help up pick the correct renderer too [01:56:27] legoktm: Almost form elements but text ones are impossible to style :( [01:56:59] quiddity: I disagree with the size stuff. I thought we already had this discussion? [01:57:08] prtksxna: well, I'll file bugs against Flow and Parsoid because they're inconsistent with The Way It's Been Done [01:57:44] spagewmf: Sure. I'll be moving to parsing links too, not very soon maybe [01:58:48] * prtksxna looks for logs [01:59:11] quiddity, prtksxna: padding-left isn't changing anything... [01:59:31] * legoktm uploads screenshot [01:59:53] quiddity, prtksxna: http://cl.ly/image/1Z053S2c1Z0t [01:59:58] prtksxna, I just don't want anyone to misunderstand how the GlobalPreferences page works (ie, that it's non-functional unless we check the "Use at all wikis" checkbox). But I'm just throwing random ideas on the table, so please do give legoktm more specific CSS direction. :) [02:00:47] * quiddity heads out for coffee, bbl. [02:01:10] quiddity legoktm http://pastie.org/pastes/9391094/text?key=lmeiivqxytdd7uyvplrc5w [02:01:46] right. that feels like a long time ago. [02:01:58] I never talked to ashley :< [02:02:18] prtksxna: how much do you suggest making it smaller by? [02:04:37] legoktm: 1-2px [02:04:55] 13 and 11 should be fine I think [02:10:24] (03PS3) 10Victor Vasiliev: Introduce a seperate message for stabilization reasons [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/146347 (https://bugzilla.wikimedia.org/59635) [02:15:52] legoktm: http://cl.ly/WZir [02:17:56] (03CR) 10Victor Vasiliev: Introduce a seperate message for stabilization reasons (032 comments) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/146347 (https://bugzilla.wikimedia.org/59635) (owner: 10Victor Vasiliev) [02:23:20] (03PS1) 10Wmat: Replacing deprecated getLang function. [extensions/GoogleSiteSearch] - 10https://gerrit.wikimedia.org/r/146371 [02:34:21] prtksxna: ok, let me see how to do that in HTMLForm... [02:41:46] (03CR) 10Ebe123: [C: 031] Split "suppressrevision" into two user rights [core] - 10https://gerrit.wikimedia.org/r/139277 (https://bugzilla.wikimedia.org/20476) (owner: 10Vogone) [02:42:12] prtksxna: do we have to set the font-size on