[00:03:34] (03PS1) 10BryanDavis: Run maintenance/install.php with PHP5 for multiversion [vagrant] - 10https://gerrit.wikimedia.org/r/145868 [00:03:53] (03CR) 10BryanDavis: [C: 032] Run maintenance/install.php with PHP5 for multiversion [vagrant] - 10https://gerrit.wikimedia.org/r/145868 (owner: 10BryanDavis) [00:03:58] (03Merged) 10jenkins-bot: Run maintenance/install.php with PHP5 for multiversion [vagrant] - 10https://gerrit.wikimedia.org/r/145868 (owner: 10BryanDavis) [00:14:08] (03PS1) 10Legoktm: Hack: Prevent AbuseFilter from interfering with GlobalRename page moves [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145870 (https://bugzilla.wikimedia.org/67875) [00:16:28] (03CR) 10Withoutaname: "Well, I tried to submit a few follow-up patches to update the code, but it doesn't look like they're going to get reviewed any time soon." [core] - 10https://gerrit.wikimedia.org/r/145738 (owner: 10Withoutaname) [00:18:46] 3MediaWiki extensions / 3CentralAuth: GlobalRename: Page moves are being blocked by local abusefilters - 10https://bugzilla.wikimedia.org/67875#c6 (10Kunal Mehta (Legoktm)) (In reply to Marius Hoch from comment #4) > On a scale of one to evil that's super evil... if this is a major problem > I'm ok with doi... [00:19:52] (03PS1) 10Bartosz Dziewoński: Added mediawiki.notification styles [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/145871 [00:20:21] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This looks ugly :(" [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/145871 (owner: 10Bartosz Dziewoński) [00:21:50] withoutaname: wow, you totally didn't need to fix SemanticSignup. [00:22:10] Umm, wow legoktm [00:22:28] Krenair: the hack? it's terrible :(((((( [00:22:43] (03PS1) 10BryanDavis: Run maintenance scripts with php5 [vagrant] - 10https://gerrit.wikimedia.org/r/145872 [00:22:45] Do you actually intend to get this merged...? [00:22:51] yes? [00:23:14] If you have a better idea, please propose it, I really hate this one [00:23:26] legoktm: lol yeah, but it felt like it was really broken [00:23:28] i just quipped hoo's comment [00:23:37] wonder if anyone still uses it [00:23:39] it truly is super evil [00:23:54] i'm thinking of building a *proper* abuse filter bypass [00:23:56] legoktm, you could add some global which AF can pick up [00:23:59] it's bad [00:24:02] But not *this* bad [00:24:04] ew [00:24:05] lol [00:24:35] jackmcbarn: I'm not a huge fan of that idea. But what we really need is to move the page move logic out of the Title class [00:24:53] the user right to skip filters sounded like a reasonable idea, but that sounds like some work too [00:25:00] Krenair: I'd rather only add a hack to CA, not AF too [00:25:11] I feel like I should -2 this [00:25:14] MatmaRex: my big thing about it is that it has to be something you do explicitly, not something that happens all the time with the right [00:25:50] just saying [00:25:59] legoktm's hack might lead to some angry local communities [00:26:05] but... that doesn't really matter [00:26:08] does it? [00:26:12] legoktm: yes to the second idea (i've gotten whined at about that during the cat move debacle), but why don't you like the idea [00:26:20] well you could help me move the Action class [00:26:29] JD|cloud: in what case specifically could that upset a community? [00:26:43] Krenair: did you look at the bug? I want to log for now, and then re-evaluate if it's actually necessary. if so, I'll implement a proper solution [00:26:56] e.g. a community filters for some usernames or page names etc. [00:27:01] maybe I'm just too pessimistic [00:27:10] no-one has complained about globalrename yet, afterall [00:27:14] JD|cloud: now that usernames are (going to be) global, if a wiki doesn't like a user's new name, they can block the account [00:27:19] but not interfere with the rename [00:27:25] legoktm, this is not just logging though [00:27:57] jackmcbarn: Because we should encourage filters to check !"foo" in user_rights rather than just have a bypass everything. [00:28:14] Krenair: hmm, yeah. let me split this into two patches. One for logging, and another for the override. [00:28:32] How does this deal with TB? [00:28:38] It catches all hookaborted errors [00:28:38] titleblacklist? [00:28:41] yeah [00:28:49] JD|cloud: i can bet you ten bucks no one will ever notice if you don't tell them [00:28:59] :D [00:29:01] Krenair: ugh. [00:29:05] won't users doing this (stewards) have tboverride everywhere? [00:29:25] And then only kills the AF hook [00:29:31] and retries [00:29:47] MatmaRex: do you know where the id for each wiki is stored? [00:30:00] withoutaname: as in $wgDBName? [00:30:04] is there a database of wikis, or database of databases? [00:30:05] shouldn't that be in commonsettings.php? [00:30:11] dunno [00:30:30] withoutaname, list of all wikimedia wikis? [00:30:30] AFAIK the only way we really id wikis is by dbname [00:30:35] and db prefix [00:31:27] (03CR) 10Alex Monk: "Yeah, let's not do this. Log only (for TB or AF), with the possibility of some hack in future to get around it (e.g. by setting some globa" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145870 (https://bugzilla.wikimedia.org/67875) (owner: 10Legoktm) [00:31:43] wfGetLB asks for a wiki id so I was just asking [00:32:36] Krenair: ^ [00:32:47] (03PS2) 10Legoktm: Hack: Prevent AbuseFilter from interfering with GlobalRename page moves [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145870 (https://bugzilla.wikimedia.org/67875) [00:32:49] (03PS1) 10Legoktm: GlobalRename: log failed page moves [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145873 [00:32:49] well, what information do you have about the wiki? [00:33:36] wait, that's not right. [00:33:37] gr [00:33:42] just the name [00:33:56] what if I wanted to do a foreach with the wikis [00:34:45] (03CR) 10Alex Monk: [C: 04-1] Hack: Prevent AbuseFilter from interfering with GlobalRename page moves (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145870 (https://bugzilla.wikimedia.org/67875) (owner: 10Legoktm) [00:34:58] withoutaname, the... name? [00:35:06] withoutaname: $wgLocalDatabases [00:35:13] That's awfully ambiguous [00:35:15] (03PS3) 10Legoktm: Hack: Prevent AbuseFilter from interfering with GlobalRename page moves [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145870 (https://bugzilla.wikimedia.org/67875) [00:35:19] for($name in $wgLocalDatabases){ ... } [00:35:37] : instead of in I think in PHP [00:35:49] ok yeah [00:35:53] I guess that would work [00:35:59] (03CR) 10Alex Monk: [C: 04-1] Hack: Prevent AbuseFilter from interfering with GlobalRename page moves (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145870 (https://bugzilla.wikimedia.org/67875) (owner: 10Legoktm) [00:36:12] Krenair: I'm still responding :P [00:36:48] (03CR) 10Alex Monk: GlobalRename: log failed page moves (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145873 (owner: 10Legoktm) [00:36:54] (03CR) 10Legoktm: Hack: Prevent AbuseFilter from interfering with GlobalRename page moves (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145870 (https://bugzilla.wikimedia.org/67875) (owner: 10Legoktm) [00:37:22] (03PS4) 10Bartosz Dziewoński: Vector: Use .mediawiki instead of .skin-vector in notification styles [core] - 10https://gerrit.wikimedia.org/r/133040 (owner: 10Daniel Friesen) [00:39:08] (03CR) 10Legoktm: GlobalRename: log failed page moves (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145873 (owner: 10Legoktm) [00:39:10] (03PS5) 10Bartosz Dziewoński: Vector: Use .mediawiki instead of .skin-vector in notification styles [core] - 10https://gerrit.wikimedia.org/r/133040 (owner: 10Daniel Friesen) [00:39:23] (03CR) 10Bartosz Dziewoński: [C: 032] "Rebased and added the comment." [core] - 10https://gerrit.wikimedia.org/r/133040 (owner: 10Daniel Friesen) [00:39:36] cant we just give stewards AF-exemption [00:39:59] withoutaname: there's no such thing [00:40:09] though i'm thinking of making one, and how it would work [00:40:13] then that's AF's fault [00:40:23] abusefilter isn't a living thing [00:40:28] legoktm: what if a bypass only bypassed the disallow, rather than bypassing the filter? [00:40:28] it can't be at fault [00:40:51] that would be interesting [00:41:00] jackmcbarn: what about other things like block autopromote and block? [00:41:03] JD|cloud: have you never blamed a problem on PHP, or on Windows, or on ? [00:41:13] jackmcbarn: I blame problems on their makers :P [00:41:16] JD|cloud: bypass them too [00:41:17] jackmcbarn: but, in this case moves are being stopped by 'warn' filters too [00:41:23] ^ [00:41:33] bypass all the things [00:41:38] legoktm: maybe bypass warn only if a warning can't be shown [00:41:39] except logging, I'd suppose [00:41:44] and not tag [00:41:47] jackmcbarn: how would you figure that out? [00:42:03] assuming that i find a way to [00:42:27] jackmcbarn: if we keep this as a "secret userright" in the sense that it can only be used by maint. scripts and internal things, I think I would be happy with it [00:42:42] i don't see the benefit of that [00:42:56] so we don't need hacks like this! [00:43:01] i don't think it will lead to poorly-written filters as long as they're still an inconvenience [00:43:09] i don't see the benefit of that over making it non-secret [00:43:20] I guess. [00:43:48] (03Merged) 10jenkins-bot: Vector: Use .mediawiki instead of .skin-vector in notification styles [core] - 10https://gerrit.wikimedia.org/r/133040 (owner: 10Daniel Friesen) [00:43:58] and in addition to what i've already said, except for cases like this one, you should have to check a box (or something) for every action that you want to bypass filters for [00:44:13] I like that [00:44:16] like when a tboverride user is creating blacklisted accounts [00:44:27] i think i will try to code that up [00:44:36] as soon as it's done using a PHP script, restrictions don't matter [00:44:44] jackmcbarn: i think in this case you don't know if you will need to tick that checkbox [00:45:05] this will just lead to people always checking them, at which point… what is the point? [00:45:07] MatmaRex: right, for renames it wouldn't be there, and would always pass [00:45:13] but for things like editing it would [00:45:58] you generally don't know if an edit will trip a filter until it does and it blows up in your face [00:46:13] right. if that happens, then you re-save with the box checked [00:46:26] so the checkbox wouldn't be very useful for non-blocking filters [00:46:33] and would just always be used for blocking filters [00:46:52] we could just implement that behavior instead and save ourselves a ton of headache [00:47:06] when you say block, do you really mean block, or do you mean disallow? [00:47:12] (just sayin', i'm not touching that code anyway :P) [00:47:17] disallow* [00:47:40] (03PS7) 10Withoutaname: Subclass the Action class under ContextSource [core] - 10https://gerrit.wikimedia.org/r/143211 [00:49:32] (03PS4) 10Legoktm: Hack: Prevent AbuseFilter from interfering with GlobalRename page moves [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145870 (https://bugzilla.wikimedia.org/67875) [00:50:59] the internal moveTo function looks really bad [00:51:28] (03PS3) 10Legoktm: Remove $wgEnableSorbs and $wgSorbsUrl [core] - 10https://gerrit.wikimedia.org/r/145738 (owner: 10Withoutaname) [00:51:38] (03CR) 10Legoktm: [C: 032] Remove $wgEnableSorbs and $wgSorbsUrl [core] - 10https://gerrit.wikimedia.org/r/145738 (owner: 10Withoutaname) [00:51:55] withoutaname: yeah, it needs to be moved out of the Title class [00:53:06] withoutaname: abandon https://gerrit.wikimedia.org/r/#/c/143234/ ? [00:54:16] legoktm: I'm thinking about adding a check for IP.php first, to see if that's correct [00:54:25] *test, in PHPUnit [00:56:00] (03Merged) 10jenkins-bot: Remove $wgEnableSorbs and $wgSorbsUrl [core] - 10https://gerrit.wikimedia.org/r/145738 (owner: 10Withoutaname) [00:56:19] 3MediaWiki extensions / 3AbuseFilter: Provide a sane way to bypass abuse filters - 10https://bugzilla.wikimedia.org/67936 (10Jackmcbarn) 3NEW p:3Unprio s:3enhanc a:3None Users have wanted a way to let certain users bypass AbuseFilter's restrictions for a long time. Wikia has already written a hack to... [00:56:47] legoktm, MatmaRex, JD|cloud: ^ if you're interested (and if i missed anything, let me know) [00:56:50] " the internal moveTo function looks really bad" i wonder what the next thing you decide to refactor will be… ;) [00:57:01] (03CR) 10Legoktm: [C: 04-1] Add deprecation messages to object methods in Article.php (032 comments) [core] - 10https://gerrit.wikimedia.org/r/143230 (owner: 10Withoutaname) [00:57:25] jackmcbarn: AbuseFilter is black magic [00:57:50] jackmcbarn: your proposal seems reasonable [00:57:54] MatmaRex: yes... [00:58:28] I just put "refactor" in front of something because my git requires a branch name [01:00:12] well keep in mind [01:00:27] regular renameuser will warn in some cases [01:00:30] not including abuse filter though [01:01:41] JD|cloud: by the time it hit the abusefilter, the user rename is already nearly done [01:01:52] hey legoktm, how come the wikis have to use cleanDeleteReasons.js to get around generateReason(), but that doesn't happen with the auto-edit-summaries? [01:02:12] another time when it would bypass warn is if you're moving a page with subpages, if the root page moves fine but a subpage hits a warn filter, it would bypass thta [01:02:12] I have no clue? [01:02:27] (03CR) 10Legoktm: "Last time I checked (I think MatmaRex had a patch for it), there were still a lot of extensions passing not-context objects to the constru" [core] - 10https://gerrit.wikimedia.org/r/144648 (owner: 10Withoutaname) [01:02:45] so by "not practical", i really meant "some changes are already done" [01:03:29] (03CR) 10Legoktm: "https://gerrit.wikimedia.org/r/#/c/86304/ and https://gerrit.wikimedia.org/r/#/c/86305/" [core] - 10https://gerrit.wikimedia.org/r/144648 (owner: 10Withoutaname) [01:03:47] withoutaname: what doesn't happen with automatic edit summaries? [01:04:40] I believe there's a pref option for turning off auto edit-summaries, but the wikis have to use a hack to bypass auto delete-summaries [01:05:16] withoutaname: i see no such preference [01:05:41] (03PS5) 10Legoktm: Enforce type hinting for setTitle() in IContextSource subclasses [core] - 10https://gerrit.wikimedia.org/r/144647 (owner: 10Withoutaname) [01:05:56] (03CR) 10Legoktm: [C: 032] Enforce type hinting for setTitle() in IContextSource subclasses [core] - 10https://gerrit.wikimedia.org/r/144647 (owner: 10Withoutaname) [01:06:23] (03PS2) 10Legoktm: Move ProtectionForm to ProtectAction [core] - 10https://gerrit.wikimedia.org/r/144928 (owner: 10Withoutaname) [01:07:12] wait, that one might be missing a few modules [01:07:28] idk why but it looks different when I ported it [01:08:17] legoktm: I think you should test it first against the old protectioform [01:08:33] I'm looking at right now [01:08:40] I just rebased it so jenkins would run the +2 tests [01:09:16] legoktm: you can comment "recheck" and it'll do that [01:09:28] I thought recheck just ran the +1 tests? [01:09:42] must have changed. worked for me at https://gerrit.wikimedia.org/r/#/c/145547/ [01:10:01] oh cool. I'll do that then :D [01:10:18] (03Merged) 10jenkins-bot: Enforce type hinting for setTitle() in IContextSource subclasses [core] - 10https://gerrit.wikimedia.org/r/144647 (owner: 10Withoutaname) [01:10:45] withoutaname: this is just moving code around right? no actual code changes? [01:10:45] oh I see why now [01:11:31] legoktm: I tried not to change too much, but FormAction uses HTMLForm while ProtectionForm used plain HTML [01:11:56] Oh I see. [01:13:31] (03CR) 10Legoktm: Move ProtectionForm to ProtectAction (031 comment) [core] - 10https://gerrit.wikimedia.org/r/144928 (owner: 10Withoutaname) [01:13:39] still going through it [01:15:46] public function unprotect() { [01:15:46] $this->protect(); [01:15:46] } [01:15:50] * legoktm facepalms [01:18:14] actually I was thinking of making the classes final, so we wouldn't have to rely on $wgActions [01:18:45] instead, Action will just detect if a class is final and instantiate it [01:19:56] (03CR) 10Legoktm: [C: 04-1] "I think you should remove Article::protect/unprotect and delete ProtectionForm since they're no longer used." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/144928 (owner: 10Withoutaname) [01:20:20] withoutaname: err, final? [01:22:29] "Legoktm 6:13 PM This seems silly. What about: class UnprotectAction extends ProtectAction " <- ProtectAction would be final [01:22:54] so you wouldn't be able to extend from it [01:22:55] so then what is UnprotectAction? [01:23:05] I don't see why'd you want to limit people from extending it [01:23:42] Action::factory() requires an action be defined in wgActions before it can be used [01:24:01] here you could create a final class and extend it from Action, without using wgActions to define it [01:24:13] (03PS1) 10Bartosz Dziewoński: Skin: Make normalizeKey() accept non-canonical case variants of keys [core] - 10https://gerrit.wikimedia.org/r/145874 [01:24:19] actually forget making it final, I found another workaround for it [01:28:39] (03CR) 10Legoktm: [C: 04-1] "What is the point of doing this?" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/145166 (owner: 10Withoutaname) [01:30:09] (03CR) 10Legoktm: [C: 04-1] "This needs RELEASE-NOTES regardless." [core] - 10https://gerrit.wikimedia.org/r/144155 (owner: 10Withoutaname) [01:35:43] (03CR) 10Ori.livneh: [C: 032] "Yep. Thanks for that." [vagrant] - 10https://gerrit.wikimedia.org/r/145872 (owner: 10BryanDavis) [01:36:12] (03Merged) 10jenkins-bot: Run maintenance scripts with php5 [vagrant] - 10https://gerrit.wikimedia.org/r/145872 (owner: 10BryanDavis) [01:39:17] 3MediaWiki-Vagrant: Vagrant+TimedMediaHandler: missing PEAR.php causes ogg file upload to fail - 10https://bugzilla.wikimedia.org/67929#c4 (10Brion Vibber) 5PATC>3RESO/FIX Confirmed this fixes Ogg file upload under hhvm. Yay! [01:39:30] (03CR) 10Legoktm: [C: 04-1] "You've changed the order of some of the checks: if I had set $wgActions['customoverride'] = false; it would no longer be honored." [core] - 10https://gerrit.wikimedia.org/r/145247 (owner: 10Withoutaname) [01:46:42] legoktm: are you talking about the overrides? [01:46:50] yes [01:47:41] So $wgActions['customoverride'] = false would disable it even if $overrides['customoverride'] = 'foo...' [01:50:29] (03CR) 10Legoktm: [C: 04-1] "If $wgMemoryLimit is deprecated, what are people supposed to do instead if they need to raise the memory limit?" [core] - 10https://gerrit.wikimedia.org/r/144137 (owner: 10Withoutaname) [01:52:50] (03PS3) 10Legoktm: Generalize Installer::showStatusMessage() [core] - 10https://gerrit.wikimedia.org/r/144130 (owner: 10Withoutaname) [01:52:58] (03CR) 10Legoktm: [C: 032] Generalize Installer::showStatusMessage() [core] - 10https://gerrit.wikimedia.org/r/144130 (owner: 10Withoutaname) [01:53:19] 3MediaWiki extensions / 3AbuseFilter: Provide a sane way to bypass abuse filters - 10https://bugzilla.wikimedia.org/67936 (10Jackmcbarn) [01:53:19] 3MediaWiki extensions / 3CentralAuth: GlobalRename: Page moves are being blocked by local abusefilters - 10https://bugzilla.wikimedia.org/67875 (10Jackmcbarn) [01:57:11] (03Merged) 10jenkins-bot: Generalize Installer::showStatusMessage() [core] - 10https://gerrit.wikimedia.org/r/144130 (owner: 10Withoutaname) [01:58:10] (03CR) 10Legoktm: [C: 04-1] "I think the stuff is bad, but we shouldn't break things like this without warning." [core] - 10https://gerrit.wikimedia.org/r/144646 (owner: 10Withoutaname) [01:58:40] (03PS1) 10Brion VIBBER: Fix for TMH "Error missing media source" under HHVM [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145875 (https://bugzilla.wikimedia.org/67937) [02:00:48] (03CR) 10Legoktm: [C: 04-1] "I don't like this in general. !$foo is not the same as $foo === null. Using === null is a conscious and intentional decision. Being explic" [core] - 10https://gerrit.wikimedia.org/r/145423 (owner: 10Withoutaname) [02:04:33] (03PS3) 10Brion VIBBER: Work in progress: early testing of integration with ogv.js media player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) [02:04:55] (03CR) 10Legoktm: [C: 04-1] "Needs release notes." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/145744 (owner: 10Withoutaname) [02:05:10] (03CR) 10Brion VIBBER: "Rebased on top of HHVM fix so I can test it in MediaWiki-Vagrant." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [02:10:08] (03CR) 10Legoktm: [C: 04-1] Move action=render from Article subclasses to RenderAction (032 comments) [core] - 10https://gerrit.wikimedia.org/r/141359 (owner: 10Withoutaname) [02:14:48] 3Wikimedia / 3General/Unknown: Audit centralauth database for inconsistencies - 10https://bugzilla.wikimedia.org/67350#c9 (10Kunal Mehta (Legoktm)) (In reply to Kunal Mehta (Legoktm) from comment #8) > Or not! I'll start migratePass0 now. Done. Now that we know localnames is consistent, we just need to ch... [02:17:00] (03PS5) 10Legoktm: Fold RevertFileAction class into RevertAction [core] - 10https://gerrit.wikimedia.org/r/145198 (owner: 10Withoutaname) [02:17:08] (03CR) 10Legoktm: [C: 032] Fold RevertFileAction class into RevertAction [core] - 10https://gerrit.wikimedia.org/r/145198 (owner: 10Withoutaname) [02:17:49] "Nothing makes me happier than seeing these classes smaller. Maybe one day they'll be small enough that we can delete them." LOL [02:21:34] (03Merged) 10jenkins-bot: Fold RevertFileAction class into RevertAction [core] - 10https://gerrit.wikimedia.org/r/145198 (owner: 10Withoutaname) [02:24:27] (03CR) 10Legoktm: [C: 04-1] Subclass the Action class under ContextSource (032 comments) [core] - 10https://gerrit.wikimedia.org/r/143211 (owner: 10Withoutaname) [02:24:52] https://gerrit.wikimedia.org/r/#/q/owner:drevitchi%2540gmail.com+status:open,n,z looks bad now :< [02:26:17] oh dw I'll get them fixed [02:26:31] you tried to turn SpecialPage into a ContextSource? https://gerrit.wikimedia.org/r/#/c/139882/ [02:27:56] (03CR) 10Legoktm: [C: 04-1] "I don't really see the point of this script, but since it exists we might as well fix it (and the patch is already written :))." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/131431 (https://bugzilla.wikimedia.org/52887) (owner: 10Withoutaname) [02:29:02] withoutaname: yup, https://gerrit.wikimedia.org/r/#/c/103347/ [02:29:23] only 5 months left! [02:30:32] ok I guess I'll point my commit to yours [02:30:54] withoutaname: I'm done reviewing for tonight, I'll probably have time to review them again next weekend [02:31:25] legoktm: thanks for the sprint [02:31:48] (03CR) 10Legoktm: "How does this work with parser caching and invalidation when blocks expire or are lifted?" [core] - 10https://gerrit.wikimedia.org/r/133661 (https://bugzilla.wikimedia.org/32819) (owner: 10Withoutaname) [02:31:54] ok, now I'm done :) [02:31:55] np [02:32:35] (03Abandoned) 10Withoutaname: Convert SpecialPage into a ContextSource subclass [core] - 10https://gerrit.wikimedia.org/r/139882 (owner: 10Withoutaname) [02:36:59] (03CR) 10Jackmcbarn: "@Legoktm: It calls updateCacheExpiry to make the cache expire the same time the block does. Manual unblocks aren't handled, but I don't se" [core] - 10https://gerrit.wikimedia.org/r/133661 (https://bugzilla.wikimedia.org/32819) (owner: 10Withoutaname) [03:06:44] jackmcbarn: so it wouldn't invalidate properly if someone is blocked for 2 weeks, then page saved, then re-blocked for only a week? [03:07:31] legoktm: right. i don't consider that a big issue since block changes are generally accompanied by talk page messages in practice [03:07:56] yeah [03:08:17] If we wanted to do it right, we'd need a new database table to track usage [03:09:09] i don't see that as being worth it. there's tons of things that don't update right, like {{NUMBEROFADMINS}} [03:12:40] ugh. [03:14:33] jackmcbarn: yeah, you're right. I'm just wary of introducing something like this that won't work "properly". [03:14:58] people are used to being told to purge whenever something doesn't look right by now [03:17:24] which is a hack :( [03:35:02] 3MediaWiki-Vagrant: Installation of composer managed libraries fails on initial provision - 10https://bugzilla.wikimedia.org/67839 (10Bryan Davis) 5NEW>3RESO/FIX [03:38:05] (03CR) 10Legoktm: [C: 04-1] Add new ParserFunction "BLOCKEXPIRY" (036 comments) [core] - 10https://gerrit.wikimedia.org/r/133661 (https://bugzilla.wikimedia.org/32819) (owner: 10Withoutaname) [03:38:17] legoktm: for https://gerrit.wikimedia.org/r/#/c/145247/ what doesn't seem to be enforced and what do we require of core stuff? The cached array was just my attempt to move stuff out of wgActions [03:39:15] withoutaname: currently, if an extension adds a custom override, it also had to set $wgActions['whatever'] = true. That is no longer checked anymore [03:39:29] withoutaname: and yay, you moved it out of $wgActions...but you didn't remove it from there :P [03:39:38] (which you should do) [03:39:58] actually, wmf has wgActions['credits'] = false, curiously enough [03:40:07] yes, because it's disabled [03:40:16] setting false should still work [03:40:22] but setting true shouldn't be required [03:40:38] actually what the API does is you do $wgAPIModules['edit'] = 'ApiDisabled'; [03:40:39] ok, that makes more sense [03:40:55] maybe have a 'DisabledAction' or something? [03:41:05] and have false point to that [03:41:31] another system message for disabled actions? [03:41:37] (03CR) 10Jackmcbarn: Add new ParserFunction "BLOCKEXPIRY" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133661 (https://bugzilla.wikimedia.org/32819) (owner: 10Withoutaname) [03:44:13] (03CR) 10Legoktm: Add new ParserFunction "BLOCKEXPIRY" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133661 (https://bugzilla.wikimedia.org/32819) (owner: 10Withoutaname) [03:44:42] (03CR) 10Jackmcbarn: Add new ParserFunction "BLOCKEXPIRY" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133661 (https://bugzilla.wikimedia.org/32819) (owner: 10Withoutaname) [03:45:13] oh that's confusing. [03:45:51] hm well originally I wanted that parserfunc to output true or false, if you look at some of the linked bugs [03:46:09] legoktm: the documentation for Block::newFromTarget is dangerously wrong, then [03:46:17] it specifically says it won't do what you showed that it does [03:47:12] jackmcbarn: er, it says "and also get any relevant autoblocks" [03:47:27] legoktm: that's on the second param [03:47:30] withoutaname: I think outputting expiry is fine [03:47:36] the first one says it won't [03:47:52] oh lol [03:47:57] (03PS3) 10Wctaiwan: [WIP] Add UI to remove targets in list view [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/145755 [03:48:04] well that's wrong [03:48:14] i'm not sure whether the doc is wrong or the function is buggy, though [03:52:25] I think the function has been that way for a while [03:53:31] * jackmcbarn kicks wikibugs [03:53:34] 3MediaWiki / 3User blocking: Block::newFromTarget gets autoblocks when its documentation says it doesn't - 10https://bugzilla.wikimedia.org/67938 (10Jackmcbarn) 3NEW p:3Unprio s:3major a:3None Block::newFromTarget returns autoblocks when its second parameter is null, even though its doc comment speci... [03:54:30] * legoktm adds blocker [03:54:32] 3MediaWiki / 3User blocking: Block::newFromTarget gets autoblocks when its documentation says it doesn't - 10https://bugzilla.wikimedia.org/67938 (10Kunal Mehta (Legoktm)) [03:54:33] 3MediaWiki / 3Documentation: Documentation is out of date, incomplete (tracking) - 10https://bugzilla.wikimedia.org/1 (10Kunal Mehta (Legoktm)) [03:56:19] (03PS1) 10Legoktm: Block: $row is a stdClass, not a ResultWrapper [core] - 10https://gerrit.wikimedia.org/r/145876 [03:56:48] is this why people hate PHP? [03:56:57] you can't be sure of what datatype $var is [03:57:12] just from its declaration [03:58:03] well, you could if a type hint was added [03:58:10] but I didn't feel like doing that [04:00:42] never saw one [04:00:49] or at least [04:00:57] those are completely optional [04:03:42] yeah, optional [04:03:54] function something( ClassName $foo ) { ... } [04:07:52] legoktm: should I still return false or throw an exception? [04:08:06] for $wgActions['actionname'] = false [04:08:23] match the current behavior? [04:08:43] ok [04:09:07] programming is fun, debugging isn't [04:09:18] or so Google's internal Testing on the Toilet column says [04:10:35] (03CR) 10Jackmcbarn: [C: 04-1] "Per the finding about leaking autoblocks" [core] - 10https://gerrit.wikimedia.org/r/133661 (https://bugzilla.wikimedia.org/32819) (owner: 10Withoutaname) [04:11:00] sometimes it isn't [04:11:18] but when you're debugging you get to learn more about someone's past coding style than you ever want to know [04:13:08] haha [04:37:55] (03CR) 10Daniel Friesen: [C: 04-1] Subclass the Action class under ContextSource (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143211 (owner: 10Withoutaname) [04:38:04] (03PS3) 10Withoutaname: (Action) Merge getClass() into factory() and kill $wgActions [core] - 10https://gerrit.wikimedia.org/r/145247 [04:42:14] (03PS1) 10Legoktm: ContextSource::getContext() can return any IContextSource [core] - 10https://gerrit.wikimedia.org/r/145877 [04:42:26] (03PS4) 10Brion VIBBER: Work in progress: early testing of integration with ogv.js media player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) [04:42:34] (03PS4) 10Withoutaname: (Action) Merge getClass() into factory() and kill $wgActions [core] - 10https://gerrit.wikimedia.org/r/145247 [04:43:00] (03CR) 10Brion VIBBER: "Added Flash audio shim for Internet Explorer 10/11" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [04:47:47] (03CR) 10Legoktm: "I'm wondering if this will just expose us to race conditions where something tries to get a user's name and finds out that the user id it " [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/145543 (owner: 10Legoktm) [05:00:04] 3MediaWiki extensions / 3Annotator: Show which revisions of page have annotations - 10https://bugzilla.wikimedia.org/67939 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None On the history page, show which revisions have associated annotations. Suggested by Daniel Robbins at bug 67576. [05:02:45] (03PS5) 10Withoutaname: (Action) Merge getClass() into factory() and kill $wgActions [core] - 10https://gerrit.wikimedia.org/r/145247 [05:21:51] (03PS4) 10Wctaiwan: [WIP] Add UI to remove targets in list view [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/145755 [05:22:03] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add UI to remove targets in list view [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/145755 (owner: 10Wctaiwan) [05:22:13] (03PS2) 10Withoutaname: Enforce some type hinting in Linker class [core] - 10https://gerrit.wikimedia.org/r/144646 [05:23:34] (03CR) 10jenkins-bot: [V: 04-1] Enforce some type hinting in Linker class [core] - 10https://gerrit.wikimedia.org/r/144646 (owner: 10Withoutaname) [05:25:37] (03PS3) 10Withoutaname: Enforce some type hinting in Linker class [core] - 10https://gerrit.wikimedia.org/r/144646 [05:39:17] (03CR) 10Withoutaname: "My question is why is there a memory raise in both the installer and in Setup.php?" [core] - 10https://gerrit.wikimedia.org/r/144137 (owner: 10Withoutaname) [05:44:05] 3MediaWiki extensions / 3CentralAuth: Warn before taking actions on self - 10https://bugzilla.wikimedia.org/67940 (10Jasper Deng) 3NEW p:3Unprio s:3normal a:3None Just like Special:Block warns before blocking yourself, CentralAuth should warn before locking or otherwise actioning one's own global acc... [05:44:12] legoktm: ^ well, might as well [05:44:32] 3MediaWiki extensions / 3CentralAuth: Warn before taking actions on self - 10https://bugzilla.wikimedia.org/67940 (10Jasper Deng) s:5normal>3enhanc [05:50:41] (03PS11) 10TTO: Allow two-tier setup of transwiki import sources [core] - 10https://gerrit.wikimedia.org/r/84194 [05:52:01] ty :D [05:52:02] (03CR) 10jenkins-bot: [V: 04-1] Allow two-tier setup of transwiki import sources [core] - 10https://gerrit.wikimedia.org/r/84194 (owner: 10TTO) [06:00:55] (03PS12) 10TTO: Allow two-tier setup of transwiki import sources [core] - 10https://gerrit.wikimedia.org/r/84194 [06:03:47] 3MediaWiki extensions / 3Annotator: Annotations are not preserved between edits - 10https://bugzilla.wikimedia.org/67576#c1 (10Matthew Flaschen) 5UNCO>3NEW p:5Unprio>3Normal s:5major>3normal This is a valid report. However, as you say it is technically challenging, and we did not intend the init... [06:05:30] (03CR) 10jenkins-bot: [V: 04-1] Allow two-tier setup of transwiki import sources [core] - 10https://gerrit.wikimedia.org/r/84194 (owner: 10TTO) [06:11:50] (03PS13) 10TTO: Allow two-tier setup of transwiki import sources [core] - 10https://gerrit.wikimedia.org/r/84194 [06:15:46] (03CR) 10jenkins-bot: [V: 04-1] Allow two-tier setup of transwiki import sources [core] - 10https://gerrit.wikimedia.org/r/84194 (owner: 10TTO) [06:42:09] (03PS2) 10Withoutaname: Make if checks in RequestContext.php more concise [core] - 10https://gerrit.wikimedia.org/r/145423 [06:55:26] (03PS14) 10TTO: Allow two-tier setup of transwiki import sources [core] - 10https://gerrit.wikimedia.org/r/84194 [07:05:18] 3Wikimedia / 3General/Unknown: Audit centralauth database for inconsistencies - 10https://bugzilla.wikimedia.org/67350#c10 (10Nemo) Curious that wikidata and nsowiki had so many: $ grep -E "[0-9]{2,} invalid" attachment.cgi\?id\=15925 enwiki: 2014-07-12 12:08:07 found 50 invalid localuser, 50 (100.0%) dele... [07:16:12] (03PS1) 10Withoutaname: Documentation: put FormAction and FormlessAction into "Actions" group [core] - 10https://gerrit.wikimedia.org/r/145878 [07:20:10] (03PS1) 10Withoutaname: Remove getFormFields(), onSubmit() and onSuccess() from FormlessAction [core] - 10https://gerrit.wikimedia.org/r/145879 [07:29:21] (03CR) 10Umherirrender: "Works locally (php 5.3.8) and on translatewiki.net (php 5.5.9-1ubuntu4.3), but not on wmf wikis ..." [core] - 10https://gerrit.wikimedia.org/r/143477 (owner: 10Umherirrender) [07:34:20] (03CR) 10Calak: [C: 031] Allow two-tier setup of transwiki import sources [core] - 10https://gerrit.wikimedia.org/r/84194 (owner: 10TTO) [07:41:00] (03PS1) 1001tonythomas: Added BounceHandlerSubmit Job to queue bounce emails for processing [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/145881 [07:42:45] (03PS2) 1001tonythomas: Added BounceHandlerSubmit Job to queue bounce emails to process [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/145881 [07:46:16] (03PS1) 10Withoutaname: Add two properties to Action.php [core] - 10https://gerrit.wikimedia.org/r/145882 [07:57:15] (03PS3) 1001tonythomas: Added BounceHandlerSubmit Job to queue bounce emails to process. [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/145881 [08:10:49] 3MediaWiki extensions / 3TitleBlacklist: Admins should be notified if creating a balcklisted title - 10https://bugzilla.wikimedia.org/67941 (10od_mishehu) 3NEW p:3Unprio s:3normal a:3None While some users (mainly admins) are allowed to override the TitleBlacklist, they should know that the title they... [08:12:32] 3MediaWiki extensions / 3TitleBlacklist: Admins should be notified if creating a balcklisted title - 10https://bugzilla.wikimedia.org/67941 (10od_mishehu) s:5normal>3enhanc [08:19:31] 3MediaWiki extensions / 3TitleBlacklist: Admins should be notified if creating a balcklisted title - 10https://bugzilla.wikimedia.org/67941#c1 (10Kunal Mehta (Legoktm)) 5NEW>3RESO/WOR This was actually just fixed in I0e3c08d026e415c31c792dffbb6bb300c7f1fd9c, and should be deployed to WMF sites with 1.24w... [08:19:47] 3MediaWiki extensions / 3TitleBlacklist: Admins don't see when page creations match against the blacklist - 10https://bugzilla.wikimedia.org/13780#c16 (10Kunal Mehta (Legoktm)) *** Bug 67941 has been marked as a duplicate of this bug. *** [08:19:47] 3MediaWiki extensions / 3TitleBlacklist: Admins should be notified if creating a balcklisted title - 10https://bugzilla.wikimedia.org/67941#c2 (10Kunal Mehta (Legoktm)) 5RESO/WOR>3RESO/DUP *** This bug has been marked as a duplicate of bug 13780 *** [08:23:00] (03PS1) 10Withoutaname: Rename Wiki.php to MediaWiki.php [core] - 10https://gerrit.wikimedia.org/r/145883 [08:25:02] 3MediaWiki extensions / 3WikimediaMessages: Missing messages on account creation - 10https://bugzilla.wikimedia.org/65514 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX [08:57:57] (03CR) 10TTO: "Sorry for the churn... Jenkins is fussy!" [core] - 10https://gerrit.wikimedia.org/r/84194 (owner: 10TTO) [09:05:03] 3MediaWiki / 3Skin and page rendering: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - 10https://bugzilla.wikimedia.org/38638 (10Nemo) [09:12:46] 3MediaWiki extensions / 3Translate: Allow translation of (non-core) namespaces through AdvancedTranslate - 10https://bugzilla.wikimedia.org/62375#c1 (10Nemo) For context, current process: https://translatewiki.net/wiki/Translating:MediaWiki#Translating_namespace_names Example of manual translation request: h... [09:13:12] (03PS22) 10Paladox: Update jquery.validate from 1.8.1 to 1.9.0 [core] - 10https://gerrit.wikimedia.org/r/145311 [09:13:20] (03PS23) 10Paladox: Update jquery.validate from 1.8.1 to 1.9.0 [core] - 10https://gerrit.wikimedia.org/r/145311 [09:13:36] (03PS24) 10Paladox: Update jquery.validate from 1.8.1 to 1.9.0 [core] - 10https://gerrit.wikimedia.org/r/145311 [09:14:17] (03PS25) 10Paladox: Update jquery.validate from 1.8.1 to 1.9.0 [core] - 10https://gerrit.wikimedia.org/r/145311 [09:21:25] (03PS20) 10Paladox: Update jQuery Cookie to v1.4.1 [core] - 10https://gerrit.wikimedia.org/r/139686 [09:21:36] (03PS21) 10Paladox: Update jQuery Cookie to v1.4.1 [core] - 10https://gerrit.wikimedia.org/r/139686 [09:21:52] (03PS22) 10Paladox: Update jQuery Cookie to v1.4.1 [core] - 10https://gerrit.wikimedia.org/r/139686 [09:23:17] (03CR) 10Paladox: "Ok I am going to upgrade slowly to 1.4.1 by every month or so upgrade to each version 1.3.1 is not a mjour upgrade and does not deprecate " [core] - 10https://gerrit.wikimedia.org/r/139686 (owner: 10Paladox) [09:29:46] 3MediaWiki / 3Export/Import: Import Module error created Revision 0, now page cannot be edited - 10https://bugzilla.wikimedia.org/65775#c2 (10Nemo) have you tried re-doing the import? It won't import duplicate revisions and should complete was was left behind. If the error is permanent then we can look into... [09:31:37] (03PS1) 10Paladox: Update jQuery Cookie to v1.3.1 [core] - 10https://gerrit.wikimedia.org/r/145884 [09:31:46] (03PS2) 10Paladox: Update jQuery Cookie to v1.3.1 [core] - 10https://gerrit.wikimedia.org/r/145884 [09:32:21] (03CR) 10Paladox: "This release does not remove anything. it adds new functions and fixes bugs." [core] - 10https://gerrit.wikimedia.org/r/145884 (owner: 10Paladox) [09:32:50] (03PS3) 10Paladox: Update jQuery Cookie to v1.3.1 [core] - 10https://gerrit.wikimedia.org/r/145884 [09:32:59] (03PS4) 10Paladox: Update jQuery Cookie to v1.3.1 [core] - 10https://gerrit.wikimedia.org/r/145884 [09:33:03] 3MediaWiki / 3Skin and page rendering: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - 10https://bugzilla.wikimedia.org/38638 (10Nemo) [09:35:21] (03PS61) 10Paladox: Update jquery.hoverIntent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [09:40:54] (03PS62) 10Paladox: Update jquery.hoverIntent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [09:41:31] (03PS63) 10Paladox: Update jquery.hoverIntent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [09:41:41] (03PS64) 10Paladox: Update jquery.hoverIntent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [09:41:50] (03PS65) 10Paladox: Update jquery.hoverIntent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [09:42:20] (03PS21) 10Paladox: Update jquery.form.js [core] - 10https://gerrit.wikimedia.org/r/139688 [09:42:33] (03PS22) 10Paladox: Update jquery.mockjax.js to v1.5.3 [core] - 10https://gerrit.wikimedia.org/r/139693 [09:43:04] (03PS24) 10Paladox: Update jquery.chosen folder and files [core] - 10https://gerrit.wikimedia.org/r/139699 [09:45:02] whyyy https://gerrit.wikimedia.org/r/#/c/139687/63..64//COMMIT_MSG,cm [09:46:25] (03PS3) 10Paladox: Update getid3 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145575 [09:48:21] (03CR) 10Paladox: "This fixes the error 500 but I need help because the players are different in different browsers and it does not look like the player on k" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/144143 (owner: 10Paladox) [11:05:17] 3Wikimedia / 3Site requests: Create "suppressredirect" user group on ckb.wikipedia - 10https://bugzilla.wikimedia.org/67278#c5 (10Nemo) Still missing l10n in WikimediaMessages, we're told: https://translatewiki.net/wiki/Thread:Support/Internationalization_of_%22suppressredirect%22_user_group [11:26:32] (03PS9) 10Bartosz Dziewoński: Allow skins to define skinStyles for arbitrary modules [core] - 10https://gerrit.wikimedia.org/r/141259 [11:44:34] Nikerabbit: http://www.shodanhq.com/search?q=elasticsearch [11:51:37] or rather http://www.shodanhq.com/search?q=%22200+OK%22+%22You+Know%2C+for+Search%22+port%3A9200 [12:00:50] (03PS1) 10Shirayuki: i18n: use int: for consistency [core] - 10https://gerrit.wikimedia.org/r/145888 [12:07:19] 3MediaWiki / 3JavaScript: Localized access key label for addPortletLink - 10https://bugzilla.wikimedia.org/67946 (10Fomafix) 3NEW p:3Unprio s:3minor a:3None Firefox supports localized access key labels but only when the element is appended to the DOM tree: $('').attr('accesskey', 'g').appendTo... [12:10:32] 3Wikimedia / 3Git/Gerrit: Gerrit: Auto-linking for urls should not include trailing full stop (breaking urls, 404 Error) - 10https://bugzilla.wikimedia.org/67866#c2 (10This, that and the other) (In reply to Andre Klapper from comment #1) > I have no idea where exactly the given example links expose the probl... [12:10:55] (03PS10) 10Bartosz Dziewoński: Allow skins to define skinStyles for arbitrary modules [core] - 10https://gerrit.wikimedia.org/r/141259 [12:11:48] (03CR) 10Bartosz Dziewoński: "Final touches, detailed commit message, release notes." [core] - 10https://gerrit.wikimedia.org/r/141259 (owner: 10Bartosz Dziewoński) [12:13:54] (03PS1) 10Gerrit Patch Uploader: Get localized access key tooltip mw.util.addPortletLink() [core] - 10https://gerrit.wikimedia.org/r/145889 (https://bugzilla.wikimedia.org/67946) [12:13:59] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/145889 (https://bugzilla.wikimedia.org/67946) (owner: 10Gerrit Patch Uploader) [12:15:30] (03CR) 10jenkins-bot: [V: 04-1] Get localized access key tooltip mw.util.addPortletLink() [core] - 10https://gerrit.wikimedia.org/r/145889 (https://bugzilla.wikimedia.org/67946) (owner: 10Gerrit Patch Uploader) [12:17:06] (03PS1) 10Shirayuki: i18n: remove namespace-dependent part from "echo-pref-tooltip-mention" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/145890 [12:25:46] (03PS2) 10Gerrit Patch Uploader: Get localized access key label in tooltip by mw.util.addPortletLink() [core] - 10https://gerrit.wikimedia.org/r/145889 (https://bugzilla.wikimedia.org/67946) [12:25:48] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/145889 (https://bugzilla.wikimedia.org/67946) (owner: 10Gerrit Patch Uploader) [12:28:32] (03PS1) 10Amire80: Cleanup whtespace and comments in mediawiki.api.edit.js [core] - 10https://gerrit.wikimedia.org/r/145891 [12:28:34] (03PS1) 10Amire80: Whitespace cleanup in mediawiki.feedback.js [core] - 10https://gerrit.wikimedia.org/r/145892 [12:44:01] 3Wikimedia / 3Site requests: Run script to recalculate Wikivoyage statistics - 10https://bugzilla.wikimedia.org/64370#c6 (10Andyrom75) Now that bug 65214 has been solved, could the voy stats be recalculated? [12:45:03] 3Wikimedia / 3Bugzilla: Add some more skins components - 10https://bugzilla.wikimedia.org/67935#c1 (10Andre Klapper) See https://www.mediawiki.org/wiki/Bug_management/Project_Maintainers#To_add_a_project_or_component for needed data (well, in this case likely only "who should be on default CC") [13:28:16] interesting; Parallels won’t run at the same time as VirtualBox, but VMWare Fusion will [13:28:36] time to migrate my windows VMs … [13:45:22] are there any list of junior jobs for mediawiki ? [13:47:33] mayankmadan: if you mean at the Wikimedia Foundation, then i'm afraid not, you can see a list of open positions at https://wikimediafoundation.org/wiki/Jobs#Wikimedia_Careers [13:47:51] i dont mean jobs [13:47:54] mayankmadan: yiu should try taking part in Google Summer of Code next year :) https://www.mediawiki.org/wiki/Summer_of_Code [13:48:02] i mean some simple bugs to get started :) [13:48:10] ah. haha [13:48:11] and i will surely try gsoc next year [13:48:20] you should probably still consider gsoc [13:48:21] yeah [13:48:25] it's fun :) [13:49:07] try looking at this page? https://www.mediawiki.org/wiki/Annoying_little_bugs [13:49:28] bah, MatmaRex beat me to it :) [13:50:07] hehe [13:53:15] mayankmadan, my first two commits: https://gerrit.wikimedia.org/r/#/c/3674/ https://gerrit.wikimedia.org/r/#/c/4095/ :) [13:55:13] Krenair, Those are from 2012 :) i wish i could get as good as you in 2 years [13:55:55] yes, the first just a couple of days after we migrated to git [13:58:55] My first contribution to MW was a security bug (that Reedy filed for me) - the API block module wasn't actually requiring a token - https://bugzilla.wikimedia.org/show_bug.cgi?id=34212 [14:05:48] (03CR) 10Gadget850: "https://bugzilla.wikimedia.org/show_bug.cgi?id=65114" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/145041 (owner: 10Jforrester) [14:17:15] hello mayankmadan, glad to see you again [14:17:47] Nemo_bis, I was not able to get online as i was buried under school work :) [14:18:25] well done [14:18:43] well done? [14:25:30] mayankmadan: you might also want to try searching for bugs with the keyword "easy" on bugzilla. [14:25:55] thanks [14:36:44] (03PS1) 10Mvolz: Bug fix; wrapped html parser in try block [services/citoid] - 10https://gerrit.wikimedia.org/r/145897 [14:36:58] (03CR) 10Yaron Koren: "Great, the variable names look a lot better now. Much as it sounds trivial or even hypocritical, though, I think it would have been better" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [14:40:01] jackmcbarn, hey. around? [14:56:43] (03PS4) 10Umherirrender: Sanitizer::escapeId: Decode chars before replace spaces [core] - 10https://gerrit.wikimedia.org/r/143477 [14:58:34] (03PS11) 10Vogone: Split "suppressrevision" into two user rights [core] - 10https://gerrit.wikimedia.org/r/139277 (https://bugzilla.wikimedia.org/20476) [14:59:15] (03PS3) 10Gerrit Patch Uploader: Get localized access key label in tooltip by mw.util.addPortletLink() [core] - 10https://gerrit.wikimedia.org/r/145889 (https://bugzilla.wikimedia.org/67946) [14:59:17] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/145889 (https://bugzilla.wikimedia.org/67946) (owner: 10Gerrit Patch Uploader) [15:00:44] (03PS5) 10Wctaiwan: Add UI to remove targets in list view [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/145755 [15:01:33] (03CR) 10jenkins-bot: [V: 04-1] Add UI to remove targets in list view [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/145755 (owner: 10Wctaiwan) [15:03:11] (03CR) 10Umherirrender: "Patch Set 4: Found the problem and fixed it" [core] - 10https://gerrit.wikimedia.org/r/143477 (owner: 10Umherirrender) [15:03:56] ok, while vmware fusion and virtualbox will run at the same time, it seems to be a bad idea and sends CPU usage skyrocketing :) [15:04:05] lemme just load these windows VMs into virtualbox and keep my life simpler [15:07:17] (03PS3) 10Gerrit Patch Uploader: Replace deprecated mw.util.updateTooltipAccessKeys [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/138890 [15:07:19] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/138890 (owner: 10Gerrit Patch Uploader) [15:08:17] That reminds me, was there any report/update about the google code-in event? [15:10:22] (03CR) 10Umherirrender: [C: 031] "Works for non-english installations. In such situation you can also use MediaWikiLangTestCase as parent class." [core] - 10https://gerrit.wikimedia.org/r/145571 (owner: 10Thiemo Mättig (WMDE)) [15:10:25] is there a better way to check if the current outputpage is the latest revision other than calling getRevisionId() and comparing it against getTitle()->getRevision()? [15:13:21] Krenair: for about 5 minutes [15:13:37] (03PS12) 10Vogone: Split "suppressrevision" into two user rights [core] - 10https://gerrit.wikimedia.org/r/139277 (https://bugzilla.wikimedia.org/20476) [15:13:52] jackmcbarn, I was just dealing with some Template:! stuff on mediawikiwiki when I realised it wasn't 100% gone - there is still something using it: https://www.mediawiki.org/w/index.php?title=Special:WhatLinksHere/Template:!&hidelinks=1&hideredirs=1 [15:14:17] Is this some crazy parser hax that isn't caught as a magic word? [15:14:30] (Given it's from Extension:ExpandTemplates I wouldn't be surprised) [15:14:30] Krenair: that page is demonstrating how ExpandTemplates does weird stuff [15:14:37] it includes the awful construct {{!{{!}}}} [15:15:27] once all the pages that link to it in their documentation get cleaned up, i'll take care of writing a replacement example for that [15:15:32] (03CR) 10jenkins-bot: [V: 04-1] Split "suppressrevision" into two user rights [core] - 10https://gerrit.wikimedia.org/r/139277 (https://bugzilla.wikimedia.org/20476) (owner: 10Vogone) [15:15:34] ok [15:15:35] ("it" being Template:!) [15:15:46] I marked Template:! as historical and unprotected it anyway [15:22:29] (03PS2) 10Mr. Stradivarius: Improve error messages in mw.html [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145547 [15:23:36] (03PS13) 10Vogone: Split "suppressrevision" into two user rights [core] - 10https://gerrit.wikimedia.org/r/139277 (https://bugzilla.wikimedia.org/20476) [15:24:38] (03PS4) 10tosfos: major code rewrite [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/144631 [15:25:31] (03CR) 10jenkins-bot: [V: 04-1] Split "suppressrevision" into two user rights [core] - 10https://gerrit.wikimedia.org/r/139277 (https://bugzilla.wikimedia.org/20476) (owner: 10Vogone) [15:27:23] (03PS6) 10Wctaiwan: Add UI to remove targets in list view [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/145755 [15:27:34] (03CR) 10jenkins-bot: [V: 04-1] Add UI to remove targets in list view [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/145755 (owner: 10Wctaiwan) [15:27:36] (03CR) 10Jackmcbarn: "recheck" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145547 (owner: 10Mr. Stradivarius) [15:27:49] (03CR) 10Mvolz: [C: 032 V: 032] Bug fix; wrapped html parser in try block [services/citoid] - 10https://gerrit.wikimedia.org/r/145897 (owner: 10Mvolz) [15:27:54] (03CR) 10tosfos: [C: 031 V: 032] major code rewrite [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/144631 (owner: 10tosfos) [15:32:48] (03CR) 10Jackmcbarn: [C: 04-1] "You need to add an entry to common/Hooks.php so that your new tests get ran." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145547 (owner: 10Mr. Stradivarius) [15:33:19] (03PS14) 10Vogone: Split "suppressrevision" into two user rights [core] - 10https://gerrit.wikimedia.org/r/139277 (https://bugzilla.wikimedia.org/20476) [15:37:49] 3MediaWiki / 3JavaScript: Localized access key label for addPortletLink - 10https://bugzilla.wikimedia.org/67946 (10Fomafix) a:3Fomafix [15:57:48] 3MediaWiki extensions / 3Translate: Better icon images for Special:PageMigration - 10https://bugzilla.wikimedia.org/65764#c2 (10Nemo) Created attachment 15927 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15927&action=edit Screenshot of proposed version Attaching screenshot originally provided by B... [16:01:09] (03PS1) 10Ebe123: Enable the creation of empty pages [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/65206) [16:07:20] (03PS3) 10Mr. Stradivarius: Improve error messages in mw.html [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145547 [16:12:52] 3MediaWiki extensions / 3ApiSandbox: Localize API documentation shown at [[Special:ApiSandbox]] - 10https://bugzilla.wikimedia.org/67950 (10Helder) 3NEW p:3Unprio s:3normal a:3None If I got to e.g. https://pt.wikipedia.org/wiki/Especial:ApiSandbox?uselang=pt#action=query&meta=siteinfo&format=json I s... [16:13:18] 3MediaWiki / 3Internationalization: Make API error messages translatable - 10https://bugzilla.wikimedia.org/35074 (10Helder) [16:13:18] 3MediaWiki extensions / 3WikidataRepo: API self-documentation should not be localized. - 10https://bugzilla.wikimedia.org/67732 (10Helder) [16:13:18] 3MediaWiki extensions / 3ApiSandbox: Localize API documentation shown at [[Special:ApiSandbox]] - 10https://bugzilla.wikimedia.org/67950 (10Helder) [16:20:33] 3MediaWiki-Vagrant: Support Ubuntu 14.04 (trusty) host image - 10https://bugzilla.wikimedia.org/64553#c3 (10Brion Vibber) 5NEW>3RESO/FIX Trusty is the default now, so I think we can mark this resolved. [16:45:49] 3MediaWiki-Vagrant: Vagrant+TMH: webm transcodes don't play in Firefox (upstream Ubuntu/avconv issue) - 10https://bugzilla.wikimedia.org/67951 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3Ori Livneh TimedMediaHandler uses avconv to transcode videos to various resolutions of .webm; however the version a... [16:47:01] 3Wikimedia / 3Bugzilla: Add some more skins components - 10https://bugzilla.wikimedia.org/67935#c2 (10Isarra) (In reply to Andre Klapper from comment #1) > See > https://www.mediawiki.org/wiki/Bug_management/ > Project_Maintainers#To_add_a_project_or_component for needed data (well, in > this case likely onl... [16:47:22] (03CR) 10Krinkle: [C: 032] "What I meant it is, the tests don't assert anything based on language (there's no need to test multiple languages). The result depends on " [core] - 10https://gerrit.wikimedia.org/r/145571 (owner: 10Thiemo Mättig (WMDE)) [16:48:25] (03CR) 10Krinkle: "So your change (fixing it to 'en' instead of substituting {lang}) is exactly what I intended. I'm glad that's obvious now." [core] - 10https://gerrit.wikimedia.org/r/145571 (owner: 10Thiemo Mättig (WMDE)) [16:51:11] (03Merged) 10jenkins-bot: Make OutputPageTest more independent from global state [core] - 10https://gerrit.wikimedia.org/r/145571 (owner: 10Thiemo Mättig (WMDE)) [16:59:38] (03CR) 10Krinkle: Make if checks in RequestContext.php more concise (031 comment) [core] - 10https://gerrit.wikimedia.org/r/145423 (owner: 10Withoutaname) [17:00:24] (03CR) 10Krinkle: [C: 031] Make if checks in RequestContext.php more concise [core] - 10https://gerrit.wikimedia.org/r/145423 (owner: 10Withoutaname) [17:01:43] (03PS2) 10Krinkle: Whitelist Skizzerz [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/144862 (owner: 10Legoktm) [17:01:48] (03CR) 10Krinkle: [C: 031] Whitelist Skizzerz [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/144862 (owner: 10Legoktm) [17:05:44] (03CR) 10Krinkle: (bug 64365) Gracefully fail when getting the default schema if we get a non-standard db type. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/134562 (owner: 10Skizzerz) [17:08:13] (03PS4) 10Krinkle: database: Gracefully fail when non-standard dbType has no default schema [core] - 10https://gerrit.wikimedia.org/r/134562 (https://bugzilla.wikimedia.org/64365) (owner: 10Skizzerz) [17:09:35] (03CR) 10jenkins-bot: [V: 04-1] database: Gracefully fail when non-standard dbType has no default schema [core] - 10https://gerrit.wikimedia.org/r/134562 (https://bugzilla.wikimedia.org/64365) (owner: 10Skizzerz) [17:10:39] (03CR) 10Krinkle: database: Gracefully fail when non-standard dbType has no default schema (031 comment) [core] - 10https://gerrit.wikimedia.org/r/134562 (https://bugzilla.wikimedia.org/64365) (owner: 10Skizzerz) [17:13:23] (03CR) 10Jackmcbarn: "recheck" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145547 (owner: 10Mr. Stradivarius) [17:17:20] (03CR) 10Jackmcbarn: Improve error messages in mw.html (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145547 (owner: 10Mr. Stradivarius) [17:17:24] (03PS6) 10Jamesmontalvo3: Add file approval and fine-tuned permissions; bump to v1.0 [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 [17:23:38] (03CR) 10Jamesmontalvo3: "> it looks like that current code will fail if the category name contains a ":", which I think it could." [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [17:33:46] (03PS1) 10Withoutaname: Add RequestContext::prepareLogEntry() [core] - 10https://gerrit.wikimedia.org/r/145902 [17:44:01] 3MediaWiki extensions / 3ApiSandbox: Localize API documentation shown at [[Special:ApiSandbox]] - 10https://bugzilla.wikimedia.org/67950#c1 (10Max Semenik) 5NEW>3RESO/WON ApiSandbox just displays what it gets from the API itself. API is not localized (cf bug 67732) and I don't think it's possible in prin... [17:51:16] 3MediaWiki extensions / 3WikidataRepo: API self-documentation should not be localized. - 10https://bugzilla.wikimedia.org/67732#c1 (10Helder) I disagree that "the API self-documentation should be english only". It should be translatable, and the translations should be shown at [[Special:ApiSandbox]] (Bug 679... [17:51:31] 3MediaWiki extensions / 3WikidataRepo: API self-documentation should not be localized. - 10https://bugzilla.wikimedia.org/67732 (10Helder) [17:51:57] (03CR) 10Krinkle: "This doesn't make sense in my opinion. For one, this is in no way relevant or specific to mw.loader.using. All of ResourceLoader revolves " [core] - 10https://gerrit.wikimedia.org/r/145673 (owner: 10Kaldari) [17:52:07] (03CR) 10Yaron Koren: "Hi," [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [17:52:54] (03CR) 10Krinkle: [C: 04-1] "What do you mean by "async with upstream" ?" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/144143 (owner: 10Paladox) [17:55:08] (03PS11) 10Krinkle: Allow skins to define skinStyles for arbitrary modules [core] - 10https://gerrit.wikimedia.org/r/141259 (owner: 10Bartosz Dziewoński) [17:55:52] (03PS1) 10Nemo bis: Add tzm (ⵜⴰⵎⴰⵣⵉⵖⵜ) (Tamazight) to Names.php [core] - 10https://gerrit.wikimedia.org/r/145904 [17:57:24] (03PS2) 10Nemo bis: Add tzm (ⵜⴰⵎⴰⵣⵉⵖⵜ) (Tamazight) to Names.php [core] - 10https://gerrit.wikimedia.org/r/145904 [17:59:15] (03CR) 10Yaron Koren: "Let me also note the script stylize.php, here:" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [18:02:37] (03CR) 10Krinkle: [C: 04-1] "Would like to explore other options. Modifying the dom again after insertion is suboptimal in terms of performance and generally feels wro" [core] - 10https://gerrit.wikimedia.org/r/145889 (https://bugzilla.wikimedia.org/67946) (owner: 10Gerrit Patch Uploader) [18:08:05] (03PS6) 10Withoutaname: (Action) Merge getClass() into factory() and kill $wgActions [core] - 10https://gerrit.wikimedia.org/r/145247 [18:08:21] (03CR) 10Umherirrender: "Would be nice to get this merged some day, with or without tracking. I have no idea, what to do for tracking and if the results can give a" [core] - 10https://gerrit.wikimedia.org/r/139672 (owner: 10Umherirrender) [18:12:56] (03PS5) 10Umherirrender: Sanitizer::escapeId: Decode entity before replacing spaces [core] - 10https://gerrit.wikimedia.org/r/143477 [18:15:43] Nemo_bis: Thanks for pointing that error in the blogpost :) [18:16:02] (03PS1) 10Nemo bis: Less jargon and more consistency in centralauth-rename-desc [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145905 [18:19:43] ;) [18:30:03] (03CR) 10Alex Monk: [C: 032] Less jargon and more consistency in centralauth-rename-desc [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145905 (owner: 10Nemo bis) [18:30:09] (03Merged) 10jenkins-bot: Less jargon and more consistency in centralauth-rename-desc [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145905 (owner: 10Nemo bis) [18:32:34] 3MediaWiki / 3Watchlist: Clearing large (39k+) watchlist @ Special:EditWatchlist/clear fails, HTTP error 503 - 10https://bugzilla.wikimedia.org/66212#c8 (10Merlijn van Deen) Note that /clear *does not clear, but just responds with /raw*! Jesús' workaround is one option; I have provided a pywikibot-based opt... [18:32:34] 3MediaWiki / 3Watchlist: Watchlist for bot too long so /raw triggers an error - 10https://bugzilla.wikimedia.org/64074 (10Merlijn van Deen) [18:34:34] 3MediaWiki / 3Watchlist: Clearing large (39k+) watchlist @ Special:EditWatchlist/clear fails, HTTP error 503 - 10https://bugzilla.wikimedia.org/66212#c9 (10Merlijn van Deen) ...or rather, that was what I remembered from when I looked at it back then. There seems to be a button now :-) [18:34:39] (03CR) 10Raimond Spekking: [C: 032] Add tzm (ⵜⴰⵎⴰⵣⵉⵖⵜ) (Tamazight) to Names.php [core] - 10https://gerrit.wikimedia.org/r/145904 (owner: 10Nemo bis) [18:36:02] 3MediaWiki / 3JavaScript: accessKeyLabel not available in Firefox for addPortletLink - 10https://bugzilla.wikimedia.org/67946 (10Krinkle) [18:37:49] (03CR) 10Krinkle: Get localized access key label in tooltip by mw.util.addPortletLink() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/145889 (https://bugzilla.wikimedia.org/67946) (owner: 10Gerrit Patch Uploader) [18:37:53] (03Merged) 10jenkins-bot: Add tzm (ⵜⴰⵎⴰⵣⵉⵖⵜ) (Tamazight) to Names.php [core] - 10https://gerrit.wikimedia.org/r/145904 (owner: 10Nemo bis) [18:39:31] (03PS4) 10Krinkle: mediawiki.util: Insert node before updating tooltip for access key [core] - 10https://gerrit.wikimedia.org/r/145889 (https://bugzilla.wikimedia.org/67946) (owner: 10Gerrit Patch Uploader) [18:42:56] (03PS1) 10Rohan013: Api now exports specified revision [core] - 10https://gerrit.wikimedia.org/r/145910 (https://bugzilla.wikimedia.org/38669) [18:44:50] ori: hi [18:44:51] ori: I can't get https://wikitech.wikimedia.org/wiki/RCStream to work [18:45:07] the python example doesn't run [18:45:19] it has some syntax error [18:48:41] petan: try using python 2 [18:48:46] 3MediaWiki-Vagrant: luasandbox.so: undefined symbol: zend_objects_destroy_object - 10https://bugzilla.wikimedia.org/67831#c1 (10Bryan Davis) Works for me: $ ls -l /usr/lib/hphp/extensions/20131007/luasandbox.so -rw-r--r-- 1 root root 108936 Jul 2 00:54 /usr/lib/hphp/extensions/20131007/luasandbox.so $ dpkg... [18:48:55] MatmaRex: is it required? [18:49:19] because some environments may support only 3+ [18:49:19] petan: no idea, but i see the code is using the 'print' statement which is no longer a thing in python 3 [18:49:23] the code should be updated… [18:49:32] there is print in python3 [18:49:37] but it requires brackets [18:49:38] but it is a function there [18:49:41] print("hi") [18:49:45] yes [18:50:04] I actually fixed this error but I can't get the required modules [18:50:11] pip tells me there are none for my OS [18:50:22] (this is pretty much the extend of my knowledge about python 2/3, so i can't help you :( ) [18:50:24] ubuntu 14.04 [18:50:27] extent* [18:50:31] meh [18:50:46] I wish websocket.IO worked "nice" in other languages than pytohn [18:50:54] what is the error? [18:51:16] Krenair: No distributions at all found for urlparse [18:51:36] ImportError: No module named 'urlparse' [18:51:48] I can't install urlparse because there is no version for my OS [18:51:50] that's not a syntax error [18:51:54] I know [18:52:00] Krenair: I already fixed the syntax error [18:52:05] this is other error I get [18:53:34] are you running in python 2 or python 3? [18:54:39] (03CR) 10Krinkle: mediawiki.util: Insert node before updating tooltip for access key (031 comment) [core] - 10https://gerrit.wikimedia.org/r/145889 (https://bugzilla.wikimedia.org/67946) (owner: 10Gerrit Patch Uploader) [19:00:23] python 3 [19:01:01] I have only embedded python 3 interpretor because I was told by "pythonists" that python 2 is dead [19:08:17] 3MediaWiki-Vagrant: vagrant up didn't git pull mediawiki - 10https://bugzilla.wikimedia.org/61235#c1 (10Bryan Davis) Was this possibly a vm build that you had aborted at some point during the initial `vagrant up`? Exec['mediawiki setup'] has required Git::Clone['mediawiki/core'] since at least Ia0518b6 (commit... [19:09:11] python 2 should have been dead a long time ago, but pythonistas continue to prop it up :/ [19:16:06] (03PS1) 10Paladox: Re adds collaspibleNav [core] - 10https://gerrit.wikimedia.org/r/145911 [19:16:32] (03PS2) 10Paladox: Re adds collaspibleNav [core] - 10https://gerrit.wikimedia.org/r/145911 [19:16:36] (03PS3) 10Paladox: Re adds collaspibleNav [core] - 10https://gerrit.wikimedia.org/r/145911 [19:16:50] (03PS4) 10Paladox: Re adds collaspibleNav [core] - 10https://gerrit.wikimedia.org/r/145911 [19:18:54] (03PS5) 10Paladox: Re adds collaspibleNav [core] - 10https://gerrit.wikimedia.org/r/145911 [19:21:50] (03CR) 10Paladox: [C: 031] Re adds collaspibleNav [core] - 10https://gerrit.wikimedia.org/r/145911 (owner: 10Paladox) [19:21:58] (03CR) 10Paladox: Re adds collaspibleNav [core] - 10https://gerrit.wikimedia.org/r/145911 (owner: 10Paladox) [19:22:03] (03PS12) 10Krinkle: resourceloader: Allow skins to provide additional styles for any module [core] - 10https://gerrit.wikimedia.org/r/141259 (owner: 10Bartosz Dziewoński) [19:26:40] (03CR) 10Krinkle: [C: 04-1] "This was removed because of performance reasons. I don't think it is in the best interest of our users to bring this back. A global variab" [core] - 10https://gerrit.wikimedia.org/r/145911 (owner: 10Paladox) [19:30:37] (03CR) 10Paladox: "Ok but users that have there own wiki can enable it without needing to find something that does it or looking through the history of media" [core] - 10https://gerrit.wikimedia.org/r/145911 (owner: 10Paladox) [19:32:47] 3MediaWiki-Vagrant: vagrant destroy && vagrant up doesn't trigger the needs_update field of mediawiki::extension - 10https://bugzilla.wikimedia.org/62550#c1 (10Bryan Davis) This happens because the Exec['update database'] puppet step only happens when the contents of the extension specific settings file change... [19:33:19] 3MediaWiki / 3Skin and page rendering: Vector: Make sidebar navigation collapsible - 10https://bugzilla.wikimedia.org/67954 (10Krinkle) 3NEW p:3Unprio s:3enhanc a:3None This was previously removed (bug 39035). The original premise is valid. For user experience and design, we do want this feature, but... [19:33:22] (03PS2) 10Krinkle: (WIP) CSS-driven collapsible nav in Vector [core] - 10https://gerrit.wikimedia.org/r/84290 (https://bugzilla.wikimedia.org/67954) (owner: 10Ori.livneh) [19:33:34] 3MediaWiki / 3Skin and page rendering: Vector: Make sidebar navigation collapsible - 10https://bugzilla.wikimedia.org/67954 (10Krinkle) p:5Unprio>3Lowest [19:33:46] (03CR) 10Krinkle: "bug 39035 is for the removal. bug 67954 is for the creation, which already has a work in progress patch since September 2013: I9dee65eb72" [core] - 10https://gerrit.wikimedia.org/r/145911 (owner: 10Paladox) [19:35:03] (03CR) 10jenkins-bot: [V: 04-1] (WIP) CSS-driven collapsible nav in Vector [core] - 10https://gerrit.wikimedia.org/r/84290 (https://bugzilla.wikimedia.org/67954) (owner: 10Ori.livneh) [19:37:04] (03CR) 10Krinkle: "If you have your own wiki and don't care about broken code or degraded user experiences / design, don't expect the software to optimise it" [core] - 10https://gerrit.wikimedia.org/r/145911 (owner: 10Paladox) [19:41:26] (03CR) 10Krinkle: "Rewrote docs a bit." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/141259 (owner: 10Bartosz Dziewoński) [19:44:17] 3Wikimedia / 3Stream: stream.wikimedia.org throws websocket.WebSocketException: Handshake Status 502 - 10https://bugzilla.wikimedia.org/66989#c1 (10Merlijn van Deen) Note that it works at some point if you're persistent enough in reconnection. [19:47:24] (03CR) 10Paladox: "just copied the title of someone else who uploaded an updated copy two years ago I think." [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/144143 (owner: 10Paladox) [19:48:34] 3Wikimedia / 3Stream: Cannot connect using basic websockets client - 10https://bugzilla.wikimedia.org/67955 (10Merlijn van Deen) 3NEW p:3Unprio s:3normal a:3None using https://github.com/dhbaird/easywsclient , with the URL adapted to ws = WebSocket::from_url("ws://stream.wikimedia.org/rc"); results... [19:50:54] (03CR) 10Paladox: "Ok." [core] - 10https://gerrit.wikimedia.org/r/145911 (owner: 10Paladox) [19:52:29] (03PS5) 10Paladox: Update jQuery Cookie to v1.3.1 [core] - 10https://gerrit.wikimedia.org/r/145884 [19:52:47] 3Wikimedia / 3Stream: stream.wikimedia.org throws websocket.WebSocketException: Handshake Status 502 - 10https://bugzilla.wikimedia.org/66989#c2 (10Krinkle) http://codepen.io/Krinkle/full/laucI/ seems to work most of the time, but about 1/20 I see the following in the network: ws://stream.wikimedia.org/sock... [19:59:17] 3MediaWiki-Vagrant: git-review should be set up so it uses a single remote - 10https://bugzilla.wikimedia.org/57680#c1 (10Bryan Davis) I don't think that MediaWiki-Vagrant should be attempting to modify anything in $HOME on the host machine. Are you wanting a git-review.conf created for the vagrant user accoun... [20:02:52] (03CR) 10TheDJ: [C: 032] Skin: Make normalizeKey() accept non-canonical case variants of keys [core] - 10https://gerrit.wikimedia.org/r/145874 (owner: 10Bartosz Dziewoński) [20:04:22] (03CR) 10TheDJ: [C: 031] mw.Title: Add new static methods `newFromFileName`, `newFromUserInput` [core] - 10https://gerrit.wikimedia.org/r/131971 (https://bugzilla.wikimedia.org/64912) (owner: 10Rillke) [20:06:33] (03Merged) 10jenkins-bot: Skin: Make normalizeKey() accept non-canonical case variants of keys [core] - 10https://gerrit.wikimedia.org/r/145874 (owner: 10Bartosz Dziewoński) [20:12:11] (03PS3) 10Paladox: (WIP) CSS-driven collapsible nav in Vector [core] - 10https://gerrit.wikimedia.org/r/84290 (https://bugzilla.wikimedia.org/67954) (owner: 10Ori.livneh) [20:12:28] (03PS4) 10Paladox: (WIP) CSS-driven collapsible nav in Vector [core] - 10https://gerrit.wikimedia.org/r/84290 (https://bugzilla.wikimedia.org/67954) (owner: 10Ori.livneh) [20:15:08] (03PS5) 10Paladox: (WIP) CSS-driven collapsible nav in Vector [core] - 10https://gerrit.wikimedia.org/r/84290 (https://bugzilla.wikimedia.org/67954) (owner: 10Ori.livneh) [20:15:36] (03PS6) 10Paladox: (WIP) CSS-driven collapsible nav in Vector [core] - 10https://gerrit.wikimedia.org/r/84290 (https://bugzilla.wikimedia.org/67954) (owner: 10Ori.livneh) [20:16:18] (03CR) 10Paladox: "I uploaded a new patch to put the changes into the correct the correct files due to changes recently to vector." [core] - 10https://gerrit.wikimedia.org/r/84290 (https://bugzilla.wikimedia.org/67954) (owner: 10Ori.livneh) [20:18:22] (03PS7) 10Paladox: (WIP) CSS-driven collapsible nav in Vector [core] - 10https://gerrit.wikimedia.org/r/84290 (https://bugzilla.wikimedia.org/67954) (owner: 10Ori.livneh) [20:18:47] (03PS8) 10Paladox: (WIP) CSS-driven collapsible nav in Vector [core] - 10https://gerrit.wikimedia.org/r/84290 (https://bugzilla.wikimedia.org/67954) (owner: 10Ori.livneh) [20:30:46] 3Wikimedia / 3Stream: stream.wikimedia.org throws websocket.WebSocketExceptio n: Handshake Status 502 Bad Gateway - 10https://bugzilla.wikimedia.org/66989 (10Krinkle) [20:31:32] 3Wikimedia / 3Stream: Stream: Client fails on ws://stream.wikimedia.org/r c: HTTP/1.1 404 Not Found - 10https://bugzilla.wikimedia.org/67955 (10Krinkle) [20:36:13] (03CR) 10Krinkle: Subclass the Action class under ContextSource (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143211 (owner: 10Withoutaname) [20:39:10] (03CR) 10Krinkle: [C: 04-2] "Do not merge before 1.24 is branched and master is 1.25 because we need to have the new non-brekaing jQuery Cookie that adds $.removeCooki" [core] - 10https://gerrit.wikimedia.org/r/139686 (owner: 10Paladox) [20:39:47] (03CR) 10Krinkle: Update jQuery Cookie to v1.4.1 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/139686 (owner: 10Paladox) [20:59:56] (03PS1) 10Krinkle: mw-run-phpunit-allexts: Remove suspicious --force flag [integration/jenkins] - 10https://gerrit.wikimedia.org/r/145977 [21:00:15] (03CR) 10Krinkle: "Removed in I7f2b476807. If this breaks something, we should be worried." [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90428 (owner: 10Hashar) [21:00:22] (03CR) 10Krinkle: [C: 032] mw-run-phpunit-allexts: Remove suspicious --force flag [integration/jenkins] - 10https://gerrit.wikimedia.org/r/145977 (owner: 10Krinkle) [21:00:25] (03Merged) 10jenkins-bot: mw-run-phpunit-allexts: Remove suspicious --force flag [integration/jenkins] - 10https://gerrit.wikimedia.org/r/145977 (owner: 10Krinkle) [21:00:51] (03CR) 10Jforrester: [C: 032] Whitespace cleanup in mediawiki.feedback.js [core] - 10https://gerrit.wikimedia.org/r/145892 (owner: 10Amire80) [21:01:16] (03CR) 10Jforrester: [C: 032] Cleanup whtespace and comments in mediawiki.api.edit.js [core] - 10https://gerrit.wikimedia.org/r/145891 (owner: 10Amire80) [21:04:03] 3Wikimedia / 3Stream: Stream: Websocket client fails on ws://stream.wikimedia.org/r c: HTTP/1.1 404 Not Found - 10https://bugzilla.wikimedia.org/67955 (10Merlijn van Deen) [21:04:51] Krinkle: i'll investigate [21:05:01] ori: Thx [21:05:15] ori: The 502 is most concerning at this point [21:05:27] I think the client might be incorrect caller or wrong version of protocol [21:05:43] (the client bug that is, not the 502 bug) [21:06:13] (03Merged) 10jenkins-bot: Cleanup whtespace and comments in mediawiki.api.edit.js [core] - 10https://gerrit.wikimedia.org/r/145891 (owner: 10Amire80) [21:06:16] (03Merged) 10jenkins-bot: Whitespace cleanup in mediawiki.feedback.js [core] - 10https://gerrit.wikimedia.org/r/145892 (owner: 10Amire80) [21:06:48] Krinkle: do you have a sample client somewhere? (codepen.io or whatever) [21:06:54] ori: Yep, in the bug. [21:07:06] thanks [21:07:08] pop open the network inspector (filter=none/all) [21:07:23] and keep refeshing until the ws request shows a red 502 in the frames list [21:07:57] you can't see the 502 until after it times out, but you'll recognise it happening by the fact that it spawns dozens of xhr-polling requests when otherwise it would stop after the ws requwest [21:08:14] so the one before that is the ws one with the 502 in its Frame [21:23:07] Krinkle: run this on tin: https://gist.github.com/atdt/bfcc9438e420fec4a800 [21:23:28] oh oops, hango n [21:23:53] https://gist.github.com/atdt/bfcc9438e420fec4a800 (rev2) [21:24:32] oh, you can't do that either, they're only listening on localhost [21:24:34] blech [21:29:34] ori: indeed [21:30:14] heh [21:30:19] i was just about to file a bug and bugzilla 500d [21:30:49] 3Wikimedia / 3Stream: uneven distribution of client connections on backends - 10https://bugzilla.wikimedia.org/67957 (10Ori Livneh) 3NEW p:3Unprio s:3normal a:3None It appears that client connections are not load-balanced properly, resulting in uneven load on the backends. rcs1002: instance rcs1002:... [21:35:24] (03PS1) 10Krinkle: [debug] Broken less [core] - 10https://gerrit.wikimedia.org/r/145984 [21:36:10] Krinkle: do you know of any clients using Twisted, the python library? [21:36:27] the status pages are getting spammed by a client with a user agent "Twisted PageGetter" [21:36:55] I don't know of any clients right now other than socket.io [21:37:10] fun, maybe someone is a bit sore about this service and DDOSing us [21:37:40] ori: so the 502 is load related? backends overloaded? [21:38:20] not sure yet, but it looks like a combination of spammy clients and nginx not load-balancing properly [21:38:29] it's supposed to load-balance based on the client ip but i suspect it's usign the lvs server's [21:38:35] ori: Ah, I see. So when the load balancer keeps sending people to the same backend, it'll eventually return 502 [21:38:41] yeah [21:38:57] the 502 is generated by nginx when it has no backends to forward to [21:39:00] ori: I guess it's mostly nginx not balancing properly, lvs over the two frontends seems fine [21:39:12] it keeps a running check of backend health [21:39:20] (03CR) 10jenkins-bot: [V: 04-1] [debug] Broken less [core] - 10https://gerrit.wikimedia.org/r/145984 (owner: 10Krinkle) [21:39:59] (03PS2) 10Krinkle: [debug] Broken less [core] - 10https://gerrit.wikimedia.org/r/145984 [21:40:02] (03Abandoned) 10Krinkle: [debug] Broken less [core] - 10https://gerrit.wikimedia.org/r/145984 (owner: 10Krinkle) [21:40:09] http://serverfault.com/questions/310729/what-ip-does-nginx-use-for-ip-hash-sticky-sessions [21:40:17] (03CR) 10Krinkle: "Confirmed as of I93dc108c725b1, this is now tested against." [core] - 10https://gerrit.wikimedia.org/r/131672 (owner: 10Gilles) [21:47:10] (03PS1) 10Brian Wolff: Remove unused messages from TimedText module. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145985 [21:47:20] (03CR) 10jenkins-bot: [V: 04-1] Remove unused messages from TimedText module. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145985 (owner: 10Brian Wolff) [21:47:36] ugh, I hate json [21:48:02] (03PS2) 10Brian Wolff: Remove unused messages from TimedText module. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145985 [21:48:40] (03CR) 10Krinkle: "(removing from dashboard again, I don't maintain this extension; excluding i18n and general updates, this extension was last developed in " [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/49478 (https://bugzilla.wikimedia.org/38345) (owner: 10Nischayn22) [21:49:19] is there a script to go through and clean out unused messages in the language files, or is that a manual thing :S [21:49:51] withoutaname: define unused [21:50:00] bawolff: Run grunt locally (ideally, as part of your IDE/editor) and you'll never get an issue. :-) [21:50:03] track any wfMsg / this->msg etc. call [21:50:19] what is grunt [21:50:23] resource loader definition, dynamic key generation ('foo-bar-baz-' .$x) [21:50:29] bawolff: gruntjs.com [21:50:38] Makefile for js [21:50:45] bawolff: Node-based … what Krinkle said. [21:50:59] bawolff: It's the standard we're using for front-end code/etc. validation. [21:51:02] Can't i just get an equivalent of php -l [21:51:14] Krinkle: yeah I figured vars in place of the message names would be a problem [21:51:26] Or I suppose I could have just run mediawiki and waited for the localization cache to barf [21:51:48] bawolff: That seems over-kill, though [21:52:19] bawolff: if you just want to lint things, 'jshint .' is like php -l in that regard (slightly more elaborate in that it also warns for bad code and scans recursively) [21:52:32] 3MediaWiki-Vagrant: Installation of composer managed libraries fails on initial provision - 10https://bugzilla.wikimedia.org/67839#c1 (10Bryan Davis) Fix was included in If9cd5c9a2d7017c340e7b5340fff7324b73d0514 [21:52:36] Well you know, its something I should be doing anyways when making changes to a mediawiki file :P [21:53:18] bawolff: would localisation cache barf though>? [21:53:26] If only it did. We just return if it's not found [21:53:32] I'd love to put a notice or log in there [21:53:35] On a syntax error in en.json, yes it does [21:53:37] James_F: There's 5 outstanding support requests for visualeditor messages at https://translatewiki.net/wiki/Category:Open_support_requests_for_MediaWiki [21:53:39] Right [21:53:40] syntax error [21:53:45] I thoguht you meant unused message [21:53:50] bawolff: jsonlint [21:54:00] Reedy: I was just responding to Nemo_bis telling me so by e-mail. [21:54:05] heh [21:54:14] Unforunately it doesn't barf on qqq.json errors [21:54:22] bawolff: You can run make test grunt test which will run differnet types of checks and tests, including lint hte json of i18n. [21:54:37] similar to a make test that might run php -l on make test [21:54:47] Courtesey of moi. ;-) [21:54:50] Or you can run json lint standalone (npm install -g jsonlint; jsonlinst path/to/file) [21:54:54] -e [21:56:17] (03CR) 10Nemo bis: [C: 031] "I've not grepped the code but I did at the time for that specific message and all these are features I never heard of (in recent versions)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145985 (owner: 10Brian Wolff) [21:57:19] 3MediaWiki / 3Logging: Block log formatting needs to be converted to the new method - 10https://bugzilla.wikimedia.org/67958 (10Jackmcbarn) 3NEW p:3Unprio s:3enhanc a:3None Formatting for block logs needs to be converted to use its own formatter, the way that delete, move, rights, etc. logs were. Cur... [21:58:33] 3MediaWiki / 3Internationalization: Log entries are difficult to localize; convert old style logs to the new code - 10https://bugzilla.wikimedia.org/24620 (10Jackmcbarn) [21:58:33] 3MediaWiki / 3Logging: Block log formatting needs to be converted to the new method - 10https://bugzilla.wikimedia.org/67958 (10Jackmcbarn) [22:04:47] 3MediaWiki / 3Logging: Block log formatting needs to be converted to the new method - 10https://bugzilla.wikimedia.org/67958#c1 (10Nemo) p:5Unprio>3Normal Yes, this needs to be done; thanks for filing. Note: the first step, adding an "invisible" parameter for the performer/subject to be used in GENDER,... [22:05:19] 3Wikimedia / 3Stream: stream.wikimedia.org throws websocket.WebSocketException: Handshake Status 502 Bad Gateway - 10https://bugzilla.wikimedia.org/66989#c3 (10John Mark Vandenberg) If we want to get this up against beta, I have a WIP for that. https://gerrit.wikimedia.org/r/#/c/138312/ Ideas/code welcome f... [22:07:01] (03CR) 10Krinkle: "ping" [core] - 10https://gerrit.wikimedia.org/r/117448 (owner: 10Addshore) [22:13:10] (03PS5) 10Legoktm: Use localized group names for user rights changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/91630 (https://bugzilla.wikimedia.org/55338) (owner: 10Gerrit Patch Uploader) [22:15:53] (03CR) 10Legoktm: [C: 032] "self-merging because it's been over 8 months and has 2 +1's." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/91630 (https://bugzilla.wikimedia.org/55338) (owner: 10Gerrit Patch Uploader) [22:16:01] (03Merged) 10jenkins-bot: Use localized group names for user rights changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/91630 (https://bugzilla.wikimedia.org/55338) (owner: 10Gerrit Patch Uploader) [22:25:56] legoktm: in https://gerrit.wikimedia.org/r/#/c/143211 you mentioned that getTitle was used in 8 other extensions, how did you find them? [22:26:07] I used PHPStorm's search feature [22:26:21] most of them were in EducationProgram and Wikibase I think. [22:26:31] kk [22:26:45] I'm thinking, could we just use setTitle in the constructor [22:27:30] we won't have to worry about which title getTitle refers to [22:29:30] umm, ContextSource doesn't implement setTitle though [22:29:48] you could do this weird DerivativeContext hack, but I think you should just fix it properly [22:31:08] (03PS1) 10BryanDavis: Remove obsolete settings [vagrant] - 10https://gerrit.wikimedia.org/r/145987 (https://bugzilla.wikimedia.org/67867) [22:31:34] (03CR) 10Fomafix: "What are other possibilities instead of adding to the document and changing again?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/145889 (https://bugzilla.wikimedia.org/67946) (owner: 10Gerrit Patch Uploader) [22:32:21] (03PS1) 10Krinkle: mediawiki.mixins: Document browser support [core] - 10https://gerrit.wikimedia.org/r/145988 [22:32:41] (03CR) 10Krinkle: "Followed-up by I49454afdf9b9" [core] - 10https://gerrit.wikimedia.org/r/77482 (owner: 10Krinkle) [22:33:28] (03PS2) 10Krinkle: mediawiki.mixins: Document browser support [core] - 10https://gerrit.wikimedia.org/r/145988 [22:34:24] (03CR) 10Krinkle: "The inline comments for browser support seem to be copied from an unrelated rule. Fixed in I49454afdf9b9465." [core] - 10https://gerrit.wikimedia.org/r/125781 (owner: 10SG) [22:34:57] (03PS1) 10Jforrester: Split out the special page message into a distinct link with a better anchor [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/145989 [22:35:08] (03CR) 10jenkins-bot: [V: 04-1] Split out the special page message into a distinct link with a better anchor [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/145989 (owner: 10Jforrester) [22:35:58] Nemo_bis: https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Centralauth-rename-desc/fi bug you linked doesn't exist? [22:36:19] ah, gerrit change [22:36:20] * legoktm fixes [22:36:59] (03CR) 10Legoktm: "It was supposed to be a joke referring to the AntiSpoof message above it, but oh well." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145905 (owner: 10Nemo bis) [22:37:23] (03PS2) 10Jforrester: Split out the special page message into a distinct link with a better anchor [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/145989 [22:39:18] Nemo_bis, how many people on the VE team did you ask about that message? :p [22:41:15] (03CR) 10Nemo bis: "I got it. :-) But outside the l10n file itself, it's hard for people to appreciated." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/145905 (owner: 10Nemo bis) [22:42:01] Dutch Japanese? [22:42:06] Sounds fun, greg-g [22:42:22] :D [22:42:33] did I forget an "and" ? [22:42:37] yeah :p [22:42:43] :) :) [22:43:08] it's a new language, quite unintelligible [22:43:34] Krenair: want to merge some of my languishing Echo patches? :| [22:44:24] Krenair: I asked separate things to each person :P [22:44:32] 3MediaWiki-Vagrant: Vagrant+TMH: webm transcodes don't play in Firefox (upstream Ubuntu/avconv issue) - 10https://bugzilla.wikimedia.org/67951#c1 (10Bawolff (Brian Wolff)) Based on error messages from production: avconv version 0.8.10-4:0.8.10-0ubuntu0.12.04.1, Copyright (c) 2000-2013 the Libav developers b... [22:44:41] (03PS3) 10Legoktm: Turn HTMLBlockedUsersItemSelect into HTMLSelectLimitField [core] - 10https://gerrit.wikimedia.org/r/105156 [22:44:50] (03CR) 10Legoktm: "Bump?" [core] - 10https://gerrit.wikimedia.org/r/105156 (owner: 10Legoktm) [22:44:56] (03PS4) 10Legoktm: API: Allow user to specify what notification types they want or don't want [extensions/Echo] - 10https://gerrit.wikimedia.org/r/137246 (https://bugzilla.wikimedia.org/57043) [22:45:07] (03CR) 10Legoktm: "Bump?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/137246 (https://bugzilla.wikimedia.org/57043) (owner: 10Legoktm) [22:45:36] (03PS5) 10Brion VIBBER: Work in progress: early testing of integration with ogv.js media player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) [22:45:39] (03PS1) 10Brion VIBBER: Optionally use avconv/ffmpeg for .ogv transcodes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145990 (https://bugzilla.wikimedia.org/67953) [22:48:21] (03CR) 10Brion VIBBER: "Warning: the .ogv output from avconv currently does *not* include an Ogg Skeleton track, so the optional may not be suitable for use in pr" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145990 (https://bugzilla.wikimedia.org/67953) (owner: 10Brion VIBBER) [22:51:21] (03CR) 10Alex Monk: "As of Ice51ae05, yep" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/145890 (owner: 10Shirayuki) [22:51:27] (03CR) 10Alex Monk: [C: 032] i18n: remove namespace-dependent part from "echo-pref-tooltip-mention" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/145890 (owner: 10Shirayuki) [22:51:36] (03Merged) 10jenkins-bot: i18n: remove namespace-dependent part from "echo-pref-tooltip-mention" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/145890 (owner: 10Shirayuki) [22:51:43] legoktm, maybe [22:52:05] (03PS3) 10Legoktm: Allow access to another user's notifications via tokens [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80710 [22:53:55] (03PS2) 10Legoktm: Remove EchoEvent::updateExtra, MWEchoBackend::updateEventExtra [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92259 [22:53:58] (03PS3) 10Legoktm: Remove EchoEvent::updateExtra, MWEchoBackend::updateEventExtra [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92259 [22:54:06] ^ should be trivial [22:55:32] 3Wikimedia / 3Stream: Stream: Websocket client fails on ws://stream.wikimedia.org/rc: HTTP/1.1 404 Not Found - 10https://bugzilla.wikimedia.org/67955#c1 (10Merlijn van Deen) Okay, this seems to be because of Socket.IO. Basically, it's not possible to connect using plain websockets, as there's some opaque (an... [23:02:12] (03CR) 10Alex Monk: [C: 032] Remove EchoEvent::updateExtra, MWEchoBackend::updateEventExtra [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92259 (owner: 10Legoktm) [23:02:21] (03Merged) 10jenkins-bot: Remove EchoEvent::updateExtra, MWEchoBackend::updateEventExtra [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92259 (owner: 10Legoktm) [23:07:41] Krenair: ty :D [23:07:51] Krenair: https://gerrit.wikimedia.org/r/80710 is also a fun one [23:08:07] sounds scary [23:10:51] a little bit [23:11:33] I'll take a look at that and https://gerrit.wikimedia.org/r/#/c/137246/ tomorrow some time [23:11:35] perhaps [23:12:05] ok, thanks [23:12:35] the last one Jared wanted for CPB, but apparently not enough to find someone to review it [23:13:46] I'm not sure how it deals with https://bugzilla.wikimedia.org/show_bug.cgi?id=57043 but okay [23:17:04] (03PS10) 10Gerrit Patch Uploader: Rework mediawiki.feedback.js [core] - 10https://gerrit.wikimedia.org/r/105457 [23:17:06] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/105457 (owner: 10Gerrit Patch Uploader) [23:19:17] 3MediaWiki-Vagrant: vagrant up didn't git pull mediawiki - 10https://bugzilla.wikimedia.org/61235#c2 (10Dan Andreescu) It's possible Bryan, I haven't had this problem since I reported the issue. [23:20:33] Krenair: that bug is basically mobile wants a way to get a user's last thank, which this does [23:27:02] 3MediaWiki / 3History/Diffs: Show more user-friendly timestamps (relative like "7 hours ago" instead of absolute) - 10https://bugzilla.wikimedia.org/30857 (10Nemo) [23:27:04] 3MediaWiki / 3General/Unknown: The "ago" mechanism is untranslatable - 10https://bugzilla.wikimedia.org/67959 (10Nemo) 3NEW p:3Unprio s:3normal a:3None [[MediaWiki:Ago]] and friends generate untranslatable strings, according to Shirayuki's assessment of MF-Warburg's requirements for German at 3MediaWiki / 3Skin and page rendering: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - 10https://bugzilla.wikimedia.org/38638 (10Nemo) [23:29:18] 3MediaWiki / 3General/Unknown: The "ago" mechanism is untranslatable - 10https://bugzilla.wikimedia.org/67959 (10Nemo) [23:30:31] 3MediaWiki / 3General/Unknown: The "ago" mechanism is untranslatable - 10https://bugzilla.wikimedia.org/67959 (10Nemo) [23:30:33] 3MediaWiki / 3Skin and page rendering: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - 10https://bugzilla.wikimedia.org/38638 (10Nemo) [23:30:35] 3MediaWiki extensions / 3Poll: Untranslatable timestamps in poll-ago, poll-time-ago - 10https://bugzilla.wikimedia.org/67961 (10Nemo) 3NEW p:3Unprio s:3normal a:3Jan Luca Per https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Moodbar-feedback-response-summary/en [23:31:03] 3MediaWiki / 3General/Unknown: The "ago" mechanism is untranslatable - 10https://bugzilla.wikimedia.org/67959 (10Nemo) [23:31:03] 3MediaWiki / 3Skin and page rendering: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - 10https://bugzilla.wikimedia.org/38638 (10Nemo) [23:31:06] 3MediaWiki extensions / 3Comments: Untranslatable timestamps in comments-time-ago - 10https://bugzilla.wikimedia.org/67962 (10Nemo) 3NEW p:3Unprio s:3normal a:3Jack Phoenix Per https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Moodbar-feedback-response-summary/en [23:31:18] 3MediaWiki / 3Skin and page rendering: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - 10https://bugzilla.wikimedia.org/38638 (10Nemo) [23:31:18] 3MediaWiki / 3General/Unknown: The "ago" mechanism is untranslatable - 10https://bugzilla.wikimedia.org/67959 (10Nemo) [23:31:20] 3MediaWiki extensions / 3EducationProgram: Untranslatable timestamps in ep-timeline-ago - 10https://bugzilla.wikimedia.org/67963 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Per https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Moodbar-feedback-response-summary/en [23:32:04] 3MediaWiki / 3General/Unknown: The "ago" mechanism is untranslatable - 10https://bugzilla.wikimedia.org/67959 (10Nemo) [23:32:04] 3MediaWiki / 3Skin and page rendering: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - 10https://bugzilla.wikimedia.org/38638 (10Nemo) [23:32:05] 3MediaWiki extensions / 3LinkFilter: Untranslatable timestamps in linkfilter-ago - 10https://bugzilla.wikimedia.org/67964 (10Nemo) 3NEW p:3Unprio s:3normal a:3Jack Phoenix Per https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Moodbar-feedback-response-summary/en [23:32:33] 3MediaWiki / 3Skin and page rendering: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - 10https://bugzilla.wikimedia.org/38638 (10Nemo) [23:32:34] 3MediaWiki / 3General/Unknown: The "ago" mechanism is untranslatable - 10https://bugzilla.wikimedia.org/67959 (10Nemo) [23:32:35] 3MediaWiki extensions / 3MoodBar: Untranslatable timestamps in moodbar-feedback-response-helpful-summary, moodbar-feedback-response-summary - 10https://bugzilla.wikimedia.org/67965 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Per https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Moodbar-feed... [23:32:48] Nemo_bis-spam [23:32:55] :) [23:36:20] much more is coming