[00:05:05] (03CR) 10Jamesmontalvo3: [C: 031] "* Removed changes to enable install via Composer" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [00:06:11] (03PS1) 10Alex Monk: Provide way for users to find articles with the automatic [extensions/Cite] - 10https://gerrit.wikimedia.org/r/145474 (https://bugzilla.wikimedia.org/67700) [00:06:20] (03CR) 10jenkins-bot: [V: 04-1] Provide way for users to find articles with the automatic [extensions/Cite] - 10https://gerrit.wikimedia.org/r/145474 (https://bugzilla.wikimedia.org/67700) (owner: 10Alex Monk) [00:07:34] (03CR) 10Legoktm: "Also add it to $wgTrackingCategories please." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/145474 (https://bugzilla.wikimedia.org/67700) (owner: 10Alex Monk) [00:08:01] (03PS2) 10Alex Monk: Provide way for users to find articles with the automatic [extensions/Cite] - 10https://gerrit.wikimedia.org/r/145474 (https://bugzilla.wikimedia.org/67700) [00:08:24] (03CR) 10Reedy: "* A message with the suffix '-desc' should be added as a description message" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/145474 (https://bugzilla.wikimedia.org/67700) (owner: 10Alex Monk) [00:09:41] (03PS1) 10Jamesmontalvo3: Add CSS to make approved rev more visible [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145475 [00:11:40] (03CR) 10Jamesmontalvo3: [C: 031] "Changes to make the approved revision for each page stand out. This is particularly necessary for file approvals (patch pending)." [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145475 (owner: 10Jamesmontalvo3) [00:13:17] 3Wikimedia / 3Site requests: Disable Media Viewer by default on the English Wikipedia - 10https://bugzilla.wikimedia.org/67826#c4 (10Erik Moeller) 5NEW>3RESO/WON Closing WONTFIX per previously provided explanation: https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Media_Viewer/June_2014_RfC&diff=... [00:14:21] Barely any drama there. Disappointed in you Wikipedia community. Disappointed. Now I'm going to have to go to an action movie or something to get my entertainment. [00:15:38] (03PS3) 10Alex Monk: Provide way for users to find articles with the automatic [extensions/Cite] - 10https://gerrit.wikimedia.org/r/145474 (https://bugzilla.wikimedia.org/67700) [00:15:45] (03CR) 10jenkins-bot: [V: 04-1] Provide way for users to find articles with the automatic [extensions/Cite] - 10https://gerrit.wikimedia.org/r/145474 (https://bugzilla.wikimedia.org/67700) (owner: 10Alex Monk) [00:15:46] 3Wikimedia / 3Site requests: Disable Media Viewer by default on the English Wikipedia - 10https://bugzilla.wikimedia.org/67826#c5 (10Tisza Gergő) (In reply to WhatamIdoing from comment #2) > It's too bad that MediaWiki doesn't have a good one-click system for > changing prefs, like a "Click here to enable X"... [00:17:27] (03PS4) 10Alex Monk: Provide way for users to find articles with the automatic [extensions/Cite] - 10https://gerrit.wikimedia.org/r/145474 (https://bugzilla.wikimedia.org/67700) [00:20:25] (03CR) 10Jack Phoenix: [C: 031] "Minor, mostly documentation-related nitpicking inline. (Note that I didn't test the extension.)" (037 comments) [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/144631 (owner: 10tosfos) [00:21:31] 3Wikimedia / 3Site requests: Disable Media Viewer by default on the English Wikipedia - 10https://bugzilla.wikimedia.org/67826#c6 (10Steinsplitter) @Erik Moeller: Why the Wikimedia Fondation as content provider overwrites community consensus? Is this only a "i don't like to follow communety consensus" WONTFI... [00:24:06] legoktm: do you know of an easy way to tell from JS the disambiguation blurb at the top of an article? [00:24:21] legoktm: not counting just hatnotes [00:24:21] legoktm: which I guess could be used for other purposes [00:24:36] err, what do you mean? [00:24:47] 3Wikimedia / 3Site requests: Disable Media Viewer by default on the English Wikipedia - 10https://bugzilla.wikimedia.org/67826#c7 (10Erik Moeller) Steinsplitter: It's longstanding WMF policy and practice to apply judgment to community RFCs and requests regarding software and configuration changes on a case-... [00:25:37] legoktm: so, see https://en.wikipedia.org/wiki/James_(name) [00:25:38] legoktm: has a hatnote on top with info about disambig [00:25:38] legoktm: and we want to style that differently in mobile apps [00:26:10] it has a class of "hatnote" [00:26:38] so just style that class? [00:26:41] legoktm: yeah, but I guess not all hatnotes are disambigs? [00:26:43] I guess that https://bugzilla.wikimedia.org/67826 should be added to https://meta.wikimedia.org/wiki/Limits_to_configuration_changes then [00:26:56] legoktm: look at https://trello.com/c/pxzofz2d/93-first-fold-styling [00:27:07] YuviPanda|zzz: note that name pages technically aren't dab pages [00:27:39] YuviPanda|zzz: if you identify the relevant templates, we can add css classes accordingly [00:27:43] <{{Technical_13}}> So far I've had to manually toggle media viewer off three times. I don't know what's going on with that, but please don't force it back on again. [00:27:55] jackmcbarn: true. [00:28:02] {{Technical_13}}: there's massive drama about it atm [00:28:10] legoktm: right, I guess {{about}} is the primary culprit? [00:28:12] {{Technical_13}}: no one is, if that's happening you should report a bug. [00:28:14] s/\?// [00:28:27] not all dab pages have a hatnote, either [00:28:29] https://en.wikipedia.org/wiki/James_%28disambiguation%29 doesn't [00:28:57] <{{Technical_13}}> I don't care if it is on or off by default, I just don't want to have to manually toggle it back off every few days. [00:29:27] jackmcbarn: I think he wants to just control it on normal articles that have a related disambig page. [00:29:32] (03CR) 10Jforrester: [C: 031] Provide way for users to find articles with the automatic [extensions/Cite] - 10https://gerrit.wikimedia.org/r/145474 (https://bugzilla.wikimedia.org/67700) (owner: 10Alex Monk) [00:29:40] jackmcbarn: yeah, what legoktm said [00:29:52] <{{Technical_13}}> I noticed it's on my appearance tab AND the Beta tab, maybe that was the issue? [00:30:08] {{Technical_13}}, hm, that's odd - it should be using a preference if you're logged in [00:30:21] YuviPanda|zzz: in that case, class=hatnote is all you have to go by [00:30:35] If you've previously enabled and disabled it as a Beta Feature, it may have come back up once it graduated from Beta to Production [00:30:54] <{{Technical_13}}> There's two checkboxes for it on different tabs still. [00:31:01] this is on enwiki? [00:31:04] 3MediaWiki-Vagrant: luasandbox.so: undefined symbol: zend_objects_destroy_object - 10https://bugzilla.wikimedia.org/67831 (10Max Semenik) 3NEW p:3Unprio s:3normal a:3Ori Livneh $ hhvm Uncaught exception: Could not open extension /usr/lib/hphp/extensions/20131007/luasandbox.so: /usr/lib/hphp/extensions/... [00:31:10] jackmcbarn: right, makes sense. at least on enwiki, https://en.wikipedia.org/wiki/Wikipedia:Hatnotes#Hatnote_templates seems comprehensive [00:31:20] <{{Technical_13}}> Or there was earlier today when I turned it off again. Yes. [00:31:34] {{Technical_13}}: I don't see it at https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-betafeatures [00:31:56] legoktm: jackmcbarn thanks! [00:32:40] * YuviPanda|zzz goes to sleep for real [00:32:40] (03PS1) 10MaxSem: Temporary fix for LocalSettings being continuously overwritten [vagrant] - 10https://gerrit.wikimedia.org/r/145476 [00:32:40] <{{Technical_13}}> Maybe I was looking at a cached copy and my change on beta did nothing. No idea, but I gotta go. Typing and walking is tough. [00:32:48] ori, ^^ [00:32:48] :) [00:32:56] thanks {{Technical_13}} , we'll keep an eye on it [00:33:00] {{Technical_13}}: Definitely shouldn't be getting cached copies of Special:Preferences [00:33:07] that would be scary [00:33:45] hmm, I guess browser cache maybe, but that would still indicate something is really broken with our caching headers [00:35:53] (03PS1) 10Chad: Add subcommand to easily import a wiki dump [vagrant] - 10https://gerrit.wikimedia.org/r/145477 [00:36:17] <{{Technical_13}}> No idea. [00:36:23] (03CR) 10Legoktm: [C: 04-1] "hardcoded date is ugh." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/145473 (https://bugzilla.wikimedia.org/47895) (owner: 10Legoktm) [00:39:17] 3MediaWiki / 3Page editing: Edit conflict not detected, middle edit reverted - 10https://bugzilla.wikimedia.org/11922 (10Helder) [00:39:17] 3MediaWiki extensions / 3Translate: Translate extension shows no "edit conflict" error when two users translate the same thing - 10https://bugzilla.wikimedia.org/67745 (10Helder) [00:40:55] <{{Technical_13}}> I just checked and it does seem to be gone from the beta tab [00:41:22] caching issue seems likely, thanks for checking. [00:41:33] out of curiosity, what browser was that? [00:42:02] <{{Technical_13}}> No problem. I use mostly Firefox both on my laptop in my mobile [00:43:16] 3Wikimedia / 3Site requests: Add a "fwotd" feed for (English) Wiktionary in FeatureFeeds settings - 10https://bugzilla.wikimedia.org/67563 (10This, that and the other) 5PATC>3RESO/FIX [00:43:20] <{{Technical_13}}> The reason I disable it is because it makes it harder for me to get to the actual /url pass for where files stored which I use for javascripts [00:44:48] Sure. There are plenty of reasons to want to disable it, and that's totally fine. [00:44:50] on a laptop, ctrl+click (open in new tab) should make it easy to bypass when needed, even when it's turned on [00:45:01] but yes, as Deskana said, to each their own [00:45:01] 3MediaWiki extensions / 3WikidataRepo: Support transitive queries - 10https://bugzilla.wikimedia.org/50911#c5 (10Emw) Lydia, I agree with Steven Rawson. This issue does not seem like a duplicate of 59680. All subproperties are transitive, but not all transitive properties are subproperties. This ticket se... [00:45:17] 3Wikimedia / 3Site requests: Add autopatrolled group to Spanish Wikisource - 10https://bugzilla.wikimedia.org/67557 (10This, that and the other) 5PATC>3RESO/FIX [00:46:17] 3Wikimedia / 3Interwiki links: Interwiki links to the current wiki behave and fail inconsistently - 10https://bugzilla.wikimedia.org/5197 (10This, that and the other) 5PATC>3RESO/FIX [00:46:32] 3Wikimedia / 3Site requests: Disable Media Viewer by default on the English Wikipedia - 10https://bugzilla.wikimedia.org/67826#c8 (10Pete F) (In reply to Erik Moeller from comment #7) Erik, the RfC is full of critiques of the methodology that led the WMF team responsible for this feature to the conclusion t... [00:47:32] 3Wikimedia / 3Interwiki links: « w:name_space: » generates a « MediaWiki:Badtitle » - 10https://bugzilla.wikimedia.org/12330#c5 (10This, that and the other) 5PATC>3RESO/FIX Fixed! Only took 7 years. [00:48:27] (03CR) 10Aaron Schulz: [C: 032] Removes depreciated $wgUseCommaCount variable [core] - 10https://gerrit.wikimedia.org/r/139842 (https://bugzilla.wikimedia.org/60454) (owner: 10Rohan013) [00:49:24] (03CR) 10jenkins-bot: [V: 04-1] Removes depreciated $wgUseCommaCount variable [core] - 10https://gerrit.wikimedia.org/r/139842 (https://bugzilla.wikimedia.org/60454) (owner: 10Rohan013) [00:51:16] 3Wikimedia / 3Extension setup: Wikimedia should become an OpenID provider - 10https://bugzilla.wikimedia.org/13631#c33 (10SJ) > I'm still interested if there is a compelling reason to get OpenID installed on > the cluster. Is there? I see good reason to get Open ID installed on the cluster. The use cases... [00:51:31] 3Wikimedia / 3Interwiki links: Interwiki links to local pages should render bold - 10https://bugzilla.wikimedia.org/4591#c3 (10This, that and the other) 5PATC>3RESO/FIX Finally fixed. It only took 8 years! [00:52:21] (03PS21) 10Bsitu: Enable Topic namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143186 (owner: 10EBernhardson) [00:52:43] (03PS1) 10Mattflaschen: Fix spurious QUnit failures related to fake timers [core] - 10https://gerrit.wikimedia.org/r/145479 (https://bugzilla.wikimedia.org/63579) [00:52:48] 3Wikimedia / 3Interwiki links: w: in en.wikipedia not really "superfluous" for self & broken links - 10https://bugzilla.wikimedia.org/954#c8 (10This, that and the other) 5PATC>3RESO/FIX Now fixed, in time for this bug's 10th birthday! [00:54:10] (03CR) 10Mattflaschen: "This is chained to the proxy change deliberately, because without that I get an error locally (PhantomJS might have different support on t" [core] - 10https://gerrit.wikimedia.org/r/145479 (https://bugzilla.wikimedia.org/63579) (owner: 10Mattflaschen) [00:54:47] 3MediaWiki / 3API: Allow triggering of user password reset email via the API - 10https://bugzilla.wikimedia.org/30788 (10Alex Monk) [00:55:46] 3MediaWiki / 3JavaScript: QUnit tests for jquery.makeCollapsible and jquery.color failing intermittently on Jenkins - 10https://bugzilla.wikimedia.org/63579#c24 (10Matthew Flaschen) You were right, I didn't need to make it async. Side note, the SinonJS docs imply that useFakeTimers() uses the current date b... [00:55:57] ^ Krinkle, I think that one's the real deal. [01:05:10] I knew useFakeTimers() created the mock at time=0 [01:05:23] That's what allows the steps and offsets to be deterministic [01:05:42] It shouldn't be influenced by current time, that's by design. Whatever time it is set at should be hardcoded. [01:05:52] e.g. useFakeTimers() and tick(100) will alwyas end up at the same time. [01:06:01] 3Wikimedia / 3Site requests: Disable Media Viewer by default on the English Wikipedia - 10https://bugzilla.wikimedia.org/67826#c9 (10Erik Moeller) Pete: Not at all. We've paid close attention to the requests by readers and editors throughout the development process. In fact, there are aspects of Media Viewer... [01:06:01] Ah, just a doc fix then [01:06:05] Is this was caused the issue? [01:07:03] superm401: I understand the patch, but I think there's also an underlying problem maybe [01:07:26] Krinkle, no, it's not just a doc fix. [01:07:28] That's secondary. [01:07:44] There is no need to make the time deterministic, as long as it doesn't actually delay the test, and the offset is deterministic. [01:07:47] I suspect the code in the Growth extension(s) is doing too much trickery in actual UI elements and letting async things happen it doesn't care about, but they do happen and they continue after the unit test returned. [01:07:53] Krinkle, no, it's not. [01:08:02] The only reason Growth is involved, is that we happen to have an animation in GuidedTour. [01:08:17] Which causes a setInterval timerId to be cached, as well as fxNow. [01:08:31] does that animation start and end within a test? [01:09:36] Yes, it starts as part of a test, the end can vary. [01:09:46] Nothing unusual, just a standard animation: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGuidedTour.git/ee1cc5abb890c000b16cd12f0cc8d2f8eaa65c25/modules%2Fmediawiki.libs.guiders%2Fmediawiki.libs.guiders.js#L995 [01:10:02] I believe that line is the trigger, but might be an animation elsewhere. [01:10:11] that should end before the test returns though [01:10:22] or the element removed (automatically if its within a fixture) [01:10:44] We're not testing the animation, but it's part of the unit test flow. [01:10:49] jQuery core has a generic unit test that throws an error if there are any pending animations or ajax requests at the end of a test [01:10:59] which indicates forgotten teardown [01:11:27] Krinkle, removing the element would not restore fxNow or the timerId. [01:11:35] i don't see how that would fix it. [01:11:59] Well, I'm ok with one step at a time, but it's imho important that you recognise that a test should not trigger UI things to happen unless you're testing the UI. That indicates lack of separation between the two things. [01:12:09] part of cleanData [01:12:22] removes jQuery expandos, event handlers and any animatinos [01:12:27] not plain detech, but remove() [01:12:41] which is what Qunit does for the fixture contents [01:12:55] (03CR) 10Aaron Schulz: [C: 032] Remove $wgFileStore [core] - 10https://gerrit.wikimedia.org/r/139187 (owner: 10Withoutaname) [01:12:57] and if not, the test should call it as part of proper teardown and atomic tests [01:13:00] Krinkle, where does it restore either timerId or fxNow? [01:13:37] It is restored insofar that either it wouldn't start in the first place, or it would wait for it, or it would skip ahead by using a fake timer if you don't care. [01:13:49] that way the tests run faster as well (that's why I did it in core with makeCollapsible) [01:13:51] (03CR) 10jenkins-bot: [V: 04-1] Remove $wgFileStore [core] - 10https://gerrit.wikimedia.org/r/139187 (owner: 10Withoutaname) [01:14:29] Krinkle, but timerId is still cached, so it would not call the fake setInterval, which is part of the problem. [01:14:32] but having random animations or ajax requests fire during a test and those continue when the next test starts, can interfer with things. [01:14:54] it would call the right one because it is run within the test, not afterwards [01:15:01] Look at the core tests, those don't fail either. [01:15:14] and there's plenty animation going on and between different modules. [01:15:22] some of which aren't using fake timers yet [01:15:39] Krinkle, that doesn't mean the isolation is correct, just because it's currently not triggering. [01:18:21] (03PS22) 10Bsitu: Enable Topic namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143186 (owner: 10EBernhardson) [01:22:44] (03CR) 10Bsitu: [C: 031] "LGTM, I made some changes as well so I wouldn't +2 this myself" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143186 (owner: 10EBernhardson) [01:25:25] (03PS1) 10Krinkle: QUnit: Throw if environment has pending effects or ajax requests [core] - 10https://gerrit.wikimedia.org/r/145483 [01:26:06] (03PS2) 10Krinkle: QUnit: Throw if environment has pending effects or ajax requests [core] - 10https://gerrit.wikimedia.org/r/145483 [01:26:38] superm401: Sure, but I'm quite positive that it does mean isolation isn't correct where the failure is happening now. [01:27:11] When an error happens the solution isn't always to silence the error, sometimes it's to fix the problem.. [01:27:20] s/the/a/ [01:59:04] Krinkle, I really don't think "silence the error" is an accurate characterization of my last patch. I identified two concrete problems with core's isolation. [01:59:08] You *may* (I have not confirmed this) be right it would have also been caught by an automatic test that there are no animations open at the end of a test. [01:59:10] But we don't have such a test either. [01:59:52] superm401: Using https://gerrit.wikimedia.org/r/#/c/145483/ and GuidedTour/GettingStarted installed, I identified at least one leaking animation on an element
[02:00:28] duration: 200 [02:00:59] swing, opacity:0 [02:01:43] Krinkle, alright, I'll patch GuidedTour to not really show the element for this test. (We'll see if that fixes it) [02:01:45] That doesn't necessarily mean we shouldn't do the other patch in addition. [02:01:45] I also used this test last year to debug table of contents animations in mw-core [02:02:03] Krinkle, I assume this time you're planning to merge this. [02:02:10] It's not a permanent solution if it's not enforced. [02:02:17] On an ongoing basis. [02:02:28] The test that throws on unfinished effects/ajax? [02:02:35] Krinkle, yes. [02:02:48] I submitted it to be reviewed/merged yes. I'd like that. [02:03:00] Im open to increasing detection and simplifying writing of tests and reducing responsibility on the test writer. [02:03:06] Krinkle, alright, just checking because of what you said about the TOC. [02:03:09] But in this case I don't think the test envirionment should stop animations. [02:03:22] Yeah, last year I didn't commit it, I just janked it out of jquery's test suite to help me debug it. [02:03:32] but it's probably useful for everyone [02:03:49] Krinkle, to be precise, fx.stop doesn't kill the queue, just stop it from progressing (though the effect is similar if the queue doesn't get restarted). [02:04:00] Right [02:04:17] superm401: btw, is it correct that it doesnt' always fail in GettingStarted? [02:04:27] Krinkle, yes, it's non-deterministic. [02:04:33] trying locally in Chrome. Got it a few times but not each. [02:04:33] OK [02:04:36] It seemed to always fail locally in non-debug mode. [02:04:46] But it was non-deterministic when remote-debugging phantom. [02:05:09] interesting [02:05:18] at least it can be reproduced in Chrome [02:05:27] the bug that report was originally for only happened in PhantomJS [02:09:03] When I say "always fail locally", I meant phantomjs in non-debug mode. [02:09:56] right [02:18:04] Krinkle, alright, https://gerrit.wikimedia.org/r/#/c/145487/ should stop GuidedTour from using animations in the unit tests. [02:18:24] It passed locally and on Jenkins, which is a good start at least. [02:19:40] k [02:38:42] (03PS1) 10Bsitu: Use i18n message in handlebar language helper function [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145490 [02:45:47] 3MediaWiki extensions / 3WikidataRepo: SubProperty mechanism - 10https://bugzilla.wikimedia.org/59680#c7 (10Emw) I think it would help to have this request reviewed by someone with detailed knowledge of the RDFS and OWL W3C specifications. Markus Krötzsch might be willing. I am concerned about Example C fr... [02:47:02] 3MediaWiki / 3JavaScript: Loading es5-shim module causes error in IE <= 8 - 10https://bugzilla.wikimedia.org/67565 (10James Forrester) 5PATC>3RESO/FIX [02:53:38] (03CR) 10Krinkle: "@Mattflaschen: (per IRC), yes, feel free to merge. This isn't only for debugging. Might as well have this helper always and to prevent reg" [core] - 10https://gerrit.wikimedia.org/r/145483 (owner: 10Krinkle) [02:55:40] (03CR) 10Krinkle: Provide way for users to find articles with the automatic (031 comment) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/145474 (https://bugzilla.wikimedia.org/67700) (owner: 10Alex Monk) [02:55:47] (03CR) 10Krinkle: [C: 04-1] Provide way for users to find articles with the automatic [extensions/Cite] - 10https://gerrit.wikimedia.org/r/145474 (https://bugzilla.wikimedia.org/67700) (owner: 10Alex Monk) [02:55:49] 3Wikimedia / 3SSL related: Enable HSTS on Wikimedia wikis - 10https://bugzilla.wikimedia.org/38516#c26 (10Daniel Zahn) Wikitech: https://gerrit.wikimedia.org/r/#/c/145491/2 OTRS: https://gerrit.wikimedia.org/r/#/c/145495/ [02:56:33] 3Wikimedia / 3SSL related: Add Forward Secrecy - 10https://bugzilla.wikimedia.org/53259#c31 (10chmarkine) (In reply to Daniel Zahn from comment #30) > chmarkine: very nice list, thanks! > > I just wanted to add that even though i have those (partly pending) patches > to enable it on gerrit,wikitech,otrs ..i... [03:12:42] (03CR) 10Krinkle: [C: 031] Set autofocus on Special:Unblock [core] - 10https://gerrit.wikimedia.org/r/129944 (owner: 10Umherirrender) [03:23:04] (03CR) 10BryanDavis: [C: 04-1] "Neat feature." (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/145477 (owner: 10Chad) [03:30:37] (03CR) 10BryanDavis: [C: 032] Temporary fix for LocalSettings being continuously overwritten (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/145476 (owner: 10MaxSem) [03:30:53] (03Merged) 10jenkins-bot: Temporary fix for LocalSettings being continuously overwritten [vagrant] - 10https://gerrit.wikimedia.org/r/145476 (owner: 10MaxSem) [03:56:36] (03PS5) 10Rohan013: Removes depreciated $wgUseCommaCount variable [core] - 10https://gerrit.wikimedia.org/r/139842 (https://bugzilla.wikimedia.org/60454) [04:07:02] 3Wikimedia / 3Site requests: Disable Media Viewer by default on the English Wikipedia - 10https://bugzilla.wikimedia.org/67826#c12 (10Tisza Gergő) (In reply to Brent Laabs from comment #10) > MV tells users that they have to attribute CC0 and PD images (they don't). This is https://wikimedia.mingle.thoughtw... [04:08:17] 3MediaWiki extensions / 3Renameuser: Merge RenameUser into core - 10https://bugzilla.wikimedia.org/25482#c12 (10Nathan Larson) I agree, it should be merged into core. Would a patch to accomplish that be accepted? [04:10:35] 3MediaWiki extensions / 3Renameuser: Add a renameuser API module - 10https://bugzilla.wikimedia.org/67836 (10Nathan Larson) 3NEW p:3Unprio s:3normal a:3None There should be an API module for renaming users. [04:11:02] 3MediaWiki extensions / 3Renameuser: Add a renameuser API module - 10https://bugzilla.wikimedia.org/67836 (10Nathan Larson) p:5Unprio>3Lowest s:5normal>3enhanc [04:11:21] (03CR) 10Mattflaschen: "It actually does support Array.prototype.map, Array.prototype.reduce, Array.prototype.filter (at least on phantomjs 1.9.7, it's quite poss" [core] - 10https://gerrit.wikimedia.org/r/144601 (owner: 10Mattflaschen) [04:12:32] (03PS2) 10BryanDavis: Update installer image for Wikimania 2014 [vagrant] - 10https://gerrit.wikimedia.org/r/144413 [04:13:06] (03CR) 10BryanDavis: Update installer image for Wikimania 2014 (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/144413 (owner: 10BryanDavis) [04:13:44] (03PS1) 10Legoktm: Avoid race condition in GlobalBlocking::insertBlock [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/145503 (https://bugzilla.wikimedia.org/67815) [04:13:49] (03PS1) 10Legoktm: Reduce dependence upon global objects [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/145504 [04:13:51] (03PS1) 10Legoktm: Convert SpecialRemoveGlobalBlock to use FormSpecialPage [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/145505 [04:14:11] (03CR) 10Krinkle: "Yep, those are supported (like I said, "it only requires some (?) very specific ES5 methods that PhantomJS happens to also support.". Supp" [core] - 10https://gerrit.wikimedia.org/r/144601 (owner: 10Mattflaschen) [04:15:35] 3MediaWiki / 3Skin and page rendering: Vector: update user icon - 10https://bugzilla.wikimedia.org/67837 (10Steven Walling) 3NEW p:3Unprio s:3normal a:3None Created attachment 15902 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15902&action=edit Current icon, when seen logged out user-icon.... [04:15:47] 3MediaWiki / 3Skin and page rendering: Vector: update user icon - 10https://bugzilla.wikimedia.org/67837#c1 (10Steven Walling) Created attachment 15903 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15903&action=edit Current icon, when logged in [04:16:17] 3MediaWiki / 3Skin and page rendering: Vector: update user icon - 10https://bugzilla.wikimedia.org/67837 (10Steven Walling) p:5Unprio>3Low [04:17:02] 3MediaWiki / 3Skin and page rendering: Vector: update user icon - 10https://bugzilla.wikimedia.org/67837#c2 (10Steven Walling) BTW, there is a placeholder icon in the BetaFeature "Compact personal bar". However, this is not final and should not be upstreamed to core. [04:17:34] 3MediaWiki / 3Skin and page rendering: Vector: update user icon - 10https://bugzilla.wikimedia.org/67837 (10Steven Walling) a:3Moiz Syed [04:17:47] 3MediaWiki skins / 3Vector: Default icon in vector for "profile" in personal tools should be gender neutral and fit with other site icons look & feel - 10https://bugzilla.wikimedia.org/41484#c50 (10Kunal Mehta (Legoktm)) *** Bug 67837 has been marked as a duplicate of this bug. *** [04:17:47] 3MediaWiki / 3Skin and page rendering: Vector: update user icon - 10https://bugzilla.wikimedia.org/67837#c3 (10Kunal Mehta (Legoktm)) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 41484 *** [04:30:34] 3MediaWiki / 3JavaScript: Profile section of debug toolbar is truncated in Firefox 30.0 - 10https://bugzilla.wikimedia.org/67838 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15904 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15904&action=edit Debug toolbar with p... [04:30:47] 3MediaWiki / 3JavaScript: Profile section of debug toolbar is truncated in Firefox 30.0 - 10https://bugzilla.wikimedia.org/67838#c1 (10Matthew Flaschen) Created attachment 15905 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15905&action=edit Debug toolbar with profiling section truncated in Firefox/... [04:31:02] 3MediaWiki / 3JavaScript: Profile section of debug toolbar is truncated in Firefox 30.0 - 10https://bugzilla.wikimedia.org/67838#c2 (10Matthew Flaschen) This is in Firefox/Iceweasel 30.0. [04:31:40] (03CR) 10Mattflaschen: "I discovered an unrelated pre-existing Firefox bug, https://bugzilla.wikimedia.org/show_bug.cgi?id=67838" [core] - 10https://gerrit.wikimedia.org/r/144601 (owner: 10Mattflaschen) [04:37:32] (03CR) 10BryanDavis: [C: 04-1] "Working on updating the README for the setup script and caching vagrant plugins" [vagrant] - 10https://gerrit.wikimedia.org/r/144413 (owner: 10BryanDavis) [04:45:18] 3MediaWiki / 3JavaScript: Profile section of debug toolbar is truncated in Firefox 30.0 - 10https://bugzilla.wikimedia.org/67838#c3 (10Matthew Flaschen) Also, there are more elements there in Firefox, but they're not rendering correctly. [04:46:33] (03PS1) 10Mattflaschen: mw.Debug.profile: Tweak support check to handle PhantomJS [core] - 10https://gerrit.wikimedia.org/r/145506 [04:47:39] (03PS2) 10Mattflaschen: mw.Debug.profile: Tweak support check to handle PhantomJS [core] - 10https://gerrit.wikimedia.org/r/145506 [04:48:49] 3MediaWiki-Vagrant: Installation of composer managed libraries fails on initial provision - 10https://bugzilla.wikimedia.org/67839 (10Bryan Davis) 3NEW p:3Unprio s:3normal a:3Ori Livneh On initial provision (`vagrant up`) of a clean virtual machine, installation of mw-core dependencies via composer fai... [04:49:33] 3MediaWiki-Vagrant: Installation of composer managed libraries fails on initial provision - 10https://bugzilla.wikimedia.org/67839 (10Bryan Davis) p:5Unprio>3High a:5Ori Livneh>3Bryan Davis [04:49:53] (03Abandoned) 10Mattflaschen: mw.Debug.profile: Tweak support check to handle PhantomJS [core] - 10https://gerrit.wikimedia.org/r/145506 (owner: 10Mattflaschen) [04:50:26] (03PS2) 10Mattflaschen: mw.Debug.profile: Tweak support check to handle PhantomJS [core] - 10https://gerrit.wikimedia.org/r/144601 [04:52:03] (03CR) 10Mattflaschen: "I would have kept using $.proxy (and just clarified some stuff) if it actually worked in PhantomJS. However, it doesn't in my testing (it" [core] - 10https://gerrit.wikimedia.org/r/144601 (owner: 10Mattflaschen) [04:54:25] (03CR) 10SG: "Yeah, this is important. Can we have a hangout on Monday to go through what options we have with regards to styling for mobile? I THINK it" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144847 (owner: 10Jdlrobson) [05:09:01] 3MediaWiki / 3JavaScript: QUnit tests for jquery.makeCollapsible and jquery.color failing intermittently on Jenkins - 10https://bugzilla.wikimedia.org/63579#c27 (10Matthew Flaschen) (In reply to Krinkle from comment #25) > Also, this really should've been a separate bug. The bug as reported was > fixed and a... [05:18:11] (03PS1) 10Ori.livneh: Tolerate server addresses w/o a port number [services/jobrunner] - 10https://gerrit.wikimedia.org/r/145508 [05:22:47] 3MediaWiki skins / 3Vector: Default icon in vector for "profile" in personal tools should be gender neutral and fit with other site icons look & feel - 10https://bugzilla.wikimedia.org/41484#c51 (10Jared Zimmerman (WMF)) Created attachment 15906 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15906&ac... [05:26:32] 3MediaWiki skins / 3Vector: Default icon in vector for "profile" in personal tools should be gender neutral and fit with other site icons look & feel - 10https://bugzilla.wikimedia.org/41484#c52 (10Steven Walling) (In reply to Jared Zimmerman (WMF) from comment #51) > Created attachment 15906 [details] > no... [05:32:31] 3MediaWiki skins / 3Vector: Default icon in vector for "profile" in personal tools should be gender neutral and fit with other site icons look & feel - 10https://bugzilla.wikimedia.org/41484#c53 (10Jared Zimmerman (WMF)) I propose we remove the post-login icon for now, and when wikifont is in core we can add... [05:41:16] 3MediaWiki skins / 3Vector: Default icon in vector for "profile" in personal tools should be gender neutral and fit with other site icons look & feel - 10https://bugzilla.wikimedia.org/41484#c54 (10Jared Zimmerman (WMF)) Created attachment 15907 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15907&ac... [05:48:14] (03CR) 10Physikerwelt: [C: 031] Breaking out disallowed CSS into a global variable [core] - 10https://gerrit.wikimedia.org/r/144249 (https://bugzilla.wikimedia.org/11106) (owner: 10Danielrenfro) [05:50:20] 3MediaWiki / 3Email: Do not require login on Special:Confirmemail to confirm the email - 10https://bugzilla.wikimedia.org/60434 (10Rohan Rawat) a:3Rohan Rawat [05:51:39] (03PS4) 10Physikerwelt: Fix rerendering in VE [extensions/Math] - 10https://gerrit.wikimedia.org/r/145444 (owner: 10Esanders) [05:52:21] (03PS1) 10Rohan013: Login check in Special:Confirmemail was removed [core] - 10https://gerrit.wikimedia.org/r/145511 (https://bugzilla.wikimedia.org/60434) [05:59:15] (03PS1) 10EBernhardson: Hygine: Remove unused method [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145512 [05:59:18] (03PS1) 10EBernhardson: Hygine: remove leftover config from previous templating [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145513 [05:59:21] (03PS1) 10EBernhardson: Hygine: RecentChangesQuery doesnt really depend on a user [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145514 [05:59:55] (03CR) 10jenkins-bot: [V: 04-1] Hygine: RecentChangesQuery doesnt really depend on a user [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145514 (owner: 10EBernhardson) [06:06:48] (03PS2) 10EBernhardson: Hygine: RecentChangesQuery doesnt really depend on a user [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145514 [06:06:51] (03PS1) 10EBernhardson: Hygine: unreachable logging statement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145515 [06:07:01] (03CR) 10jenkins-bot: [V: 04-1] Hygine: unreachable logging statement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145515 (owner: 10EBernhardson) [06:13:57] (03PS2) 10EBernhardson: Hygine: unreachable logging statement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145515 [06:17:34] 3MediaWiki / 3Special pages: Special:Version shows jumbled localized parser extension tags - 10https://bugzilla.wikimedia.org/67840 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None If you go to the list of parser extension tags on the Hebrew Wikipedia, you'll see one tag whose name appears in jum... [06:22:41] (03CR) 10Florianschmidtwelzow: rework code, gcs script version 2, show on SpecialSearch (031 comment) [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/145213 (owner: 10tosfos) [06:24:21] (03PS4) 10Jamesmontalvo3: Add file approval and fine-tuned permissions; bump to v1.0 [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 [06:26:12] (03CR) 10Jamesmontalvo3: [C: 031] "* FIXMEs and TODOs: I significantly reduced the TODOs and addressed all FIXMEs. There were a couple of TODOs that were not part of the cod" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [06:26:46] (03CR) 10Hashar: [C: 032] "This patch has been around for a month. I guess it is fine for everyone." [core/vendor] - 10https://gerrit.wikimedia.org/r/136473 (owner: 10BryanDavis) [06:26:56] (03Merged) 10jenkins-bot: Add psr/log 1.0.0 [core/vendor] - 10https://gerrit.wikimedia.org/r/136473 (owner: 10BryanDavis) [06:29:41] (03CR) 10Hashar: [C: 032] "Assuming nobody has anything to say about it." [core/vendor] - 10https://gerrit.wikimedia.org/r/136474 (owner: 10BryanDavis) [06:29:45] (03Merged) 10jenkins-bot: Add monolog/monolog 1.9.1 [core/vendor] - 10https://gerrit.wikimedia.org/r/136474 (owner: 10BryanDavis) [06:31:43] (03CR) 10Hashar: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/119940 (owner: 10BryanDavis) [06:32:23] (03CR) 10Tweichart: [C: 032 V: 032] Added $wgMessagesDirs to some extensions [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/145324 (owner: 10Smuggli) [06:32:43] (03PS1) 10Florianschmidtwelzow: Add tests for coding standards [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/145516 [06:37:46] (03CR) 10Hashar: [C: 031] QUnit: Detect unfinished jQuery effects or ajax requests in teardown [core] - 10https://gerrit.wikimedia.org/r/145483 (owner: 10Krinkle) [06:38:47] (03CR) 10Florianschmidtwelzow: "So you can run the tests for coding standards locally with make tests :) A suggestion is to do "make installhooks", so the test will be ru" [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/145516 (owner: 10Florianschmidtwelzow) [06:41:26] (03PS1) 10Rohan013: $wgUseTwoButtonForm is set to false by default [core] - 10https://gerrit.wikimedia.org/r/145517 (https://bugzilla.wikimedia.org/40622) [06:43:48] (03CR) 10Hashar: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/119940 (owner: 10BryanDavis) [06:43:50] (03CR) 10Robert Vogel: [C: 04-1 V: 04-1] Removed hardcoded alert window titles (032 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/145310 (owner: 10Smuggli) [06:57:03] (03CR) 10SG: [C: 032] Hygine: Remove unused method [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145512 (owner: 10EBernhardson) [06:57:07] (03PS6) 10Withoutaname: Removes depreciated $wgUseCommaCount variable [core] - 10https://gerrit.wikimedia.org/r/139842 (https://bugzilla.wikimedia.org/60454) (owner: 10Rohan013) [06:57:17] (03CR) 10SG: [C: 032] Hygine: remove leftover config from previous templating [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145513 (owner: 10EBernhardson) [06:57:37] (03Merged) 10jenkins-bot: Hygine: Remove unused method [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145512 (owner: 10EBernhardson) [06:58:04] (03PS1) 10Legoktm: Fix doc for GlobalBlocking::getRangeCondition() [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/145519 [06:58:54] (03Merged) 10jenkins-bot: Hygine: remove leftover config from previous templating [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145513 (owner: 10EBernhardson) [07:01:29] (03CR) 10SG: "Can we not just correct the usages of these keys to the right mw message keys?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145490 (owner: 10Bsitu) [07:03:09] (03CR) 10SG: [C: 032] Hygiene: Include missing less file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145469 (owner: 10Jdlrobson) [07:03:37] (03Merged) 10jenkins-bot: Hygiene: Include missing less file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145469 (owner: 10Jdlrobson) [07:04:38] (03CR) 10SG: [C: 032] Enable the minimum required styles on mobile. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144167 (owner: 10Jdlrobson) [07:05:06] (03Merged) 10jenkins-bot: Enable the minimum required styles on mobile. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144167 (owner: 10Jdlrobson) [07:08:49] (03CR) 10SG: "Not going to happen just yet. No one has even glanced at it. Plus, that patch depends on the mw-ui-button refactor." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145331 (owner: 10SG) [07:09:59] (03CR) 10SG: [C: 04-1] "AFAIK You also need to update the Makefile to add these templates to it as dependencies." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145171 (owner: 10Jdlrobson) [07:10:34] (03CR) 10SG: [C: 032] QUnit: Correct assertion to correct number of tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145387 (owner: 10Jdlrobson) [07:11:02] (03Merged) 10jenkins-bot: QUnit: Correct assertion to correct number of tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145387 (owner: 10Jdlrobson) [07:11:18] (03CR) 10SG: [C: 032] "Not entirely sure why this test is failing." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145031 (owner: 10Jdlrobson) [07:11:27] (03PS4) 10SG: Simplify Flow colors to use from core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145031 (owner: 10Jdlrobson) [07:11:33] (03CR) 10jenkins-bot: [V: 04-1] Simplify Flow colors to use from core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145031 (owner: 10Jdlrobson) [07:13:19] (03CR) 10SG: [C: 032] "Yeah, this is the way we've been going about updating lightncandy. It's, unfortunately, the only thing we can do until Bernie gets stuff l" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145142 (owner: 10EBernhardson) [07:13:23] (03CR) 10jenkins-bot: [V: 04-1] Don't html encode lightncandy sub-expressions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145142 (owner: 10EBernhardson) [07:13:37] (03PS1) 10Ori.livneh: add env::alternative; use it to update-alternatives php [vagrant] - 10https://gerrit.wikimedia.org/r/145520 [07:14:13] (03PS2) 10Ori.livneh: add env::alternative; use it to update-alternatives php [vagrant] - 10https://gerrit.wikimedia.org/r/145520 [07:14:58] (03CR) 10Ori.livneh: [C: 032] add env::alternative; use it to update-alternatives php [vagrant] - 10https://gerrit.wikimedia.org/r/145520 (owner: 10Ori.livneh) [07:15:03] (03Merged) 10jenkins-bot: add env::alternative; use it to update-alternatives php [vagrant] - 10https://gerrit.wikimedia.org/r/145520 (owner: 10Ori.livneh) [07:15:08] (03CR) 10SG: [C: 04-2] "Per other patch." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145030 (owner: 10Jdlrobson) [07:17:07] (03CR) 10SG: [C: 04-1] "I don't think .mw-ui-form as a parent is needed. These styles can just be applied globally." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144166 (owner: 10Jdlrobson) [07:20:04] 3MediaWiki extensions / 3TextExtracts: Hovercards: Punctuation within title should not count for terminating the extract - 10https://bugzilla.wikimedia.org/67841 (10Laurence 'GreenReaper' Parry) 3NEW p:3Unprio s:3normal a:3None If the title (and perhaps the link or redirect being used to the title) c... [07:34:05] (03PS7) 10Withoutaname: Removes deprecated $wgUseCommaCount variable [core] - 10https://gerrit.wikimedia.org/r/139842 (https://bugzilla.wikimedia.org/60454) (owner: 10Rohan013) [07:34:38] (03CR) 10Daniel Friesen: [C: 04-1] "The purpose of the ("Advanced search"?) link that shows up when only one button is used is to allow fulltext searches. This change complet" [core] - 10https://gerrit.wikimedia.org/r/145517 (https://bugzilla.wikimedia.org/40622) (owner: 10Rohan013) [07:40:49] 3MediaWiki extensions / 3ContributionScores: Database error: Uncommited DB writes - 10https://bugzilla.wikimedia.org/67842 (10Marco) 3UNCO p:3Unprio s:3blocke a:3None Version of the extension is 1.17.0 When running the extension with the sqlite database backend I end up geting the following error.... [07:41:17] 3MediaWiki extensions / 3ContributionScores: Database error: Uncommited DB writes - 10https://bugzilla.wikimedia.org/67842 (10Marco) [07:44:02] 3MediaWiki extensions / 3ContributionScores: Database error: Uncommited DB writes - 10https://bugzilla.wikimedia.org/67842 (10Marco) [07:46:42] (03CR) 10Frédéric Wang: "In the commit message:" [extensions/Math] - 10https://gerrit.wikimedia.org/r/145335 (owner: 10Physikerwelt) [07:47:50] (03PS14) 10Paladox: Update jquery.validate from 1.8.1 to 1.9.0 [core] - 10https://gerrit.wikimedia.org/r/145311 [07:53:54] (03PS11) 10Paladox: Update jQuery Cookie to v1.2.0 [core] - 10https://gerrit.wikimedia.org/r/145000 [07:54:11] (03PS12) 10Paladox: Update jQuery Cookie to v1.2.0 [core] - 10https://gerrit.wikimedia.org/r/145000 [07:54:29] (03PS13) 10Paladox: Update jQuery Cookie to v1.2.0 [core] - 10https://gerrit.wikimedia.org/r/145000 [07:56:02] (03CR) 10Paladox: [C: 031] Update jQuery Cookie to v1.2.0 [core] - 10https://gerrit.wikimedia.org/r/145000 (owner: 10Paladox) [07:56:34] (03CR) 10Paladox: Update jQuery Cookie to v1.2.0 [core] - 10https://gerrit.wikimedia.org/r/145000 (owner: 10Paladox) [07:56:59] (03PS16) 10Paladox: Update jquery.ui-themes [core] - 10https://gerrit.wikimedia.org/r/145049 [07:57:26] (03CR) 10Paladox: [C: 031] Update jquery.ui-themes [core] - 10https://gerrit.wikimedia.org/r/145049 (owner: 10Paladox) [07:57:37] (03CR) 10Paladox: Update jquery.ui-themes [core] - 10https://gerrit.wikimedia.org/r/145049 (owner: 10Paladox) [07:59:46] (03CR) 10Paladox: "Hi I have looked through all the historys of it and I have added all the customization back." [core] - 10https://gerrit.wikimedia.org/r/145049 (owner: 10Paladox) [08:01:00] (03CR) 10Withoutaname: "Actually they all have the same code file "evilMediaWikiBootstrap.php" for loading MWInit; the only other uses I see is in Platonides inte" [core] - 10https://gerrit.wikimedia.org/r/143207 (owner: 10Withoutaname) [08:07:03] (03PS3) 10Withoutaname: Rewrite checks for the memory limit [core] - 10https://gerrit.wikimedia.org/r/144137 [08:13:21] (03PS2) 10Withoutaname: Generalize Installer::showStatusMessage() [core] - 10https://gerrit.wikimedia.org/r/144130 [08:16:32] 3Wikimedia / 3General/Unknown: Error 503 trying to access watchlist on Serbo-Croatian Wikipedia - 10https://bugzilla.wikimedia.org/67123#c12 (10Marius Hoch) (In reply to Kolega2357 from comment #11) > I fortog to add not warwiki already shwiki. Sorry, I don't get this... what do you mean? [08:17:21] (03PS19) 10Paladox: Update jquery.form.js [core] - 10https://gerrit.wikimedia.org/r/139688 [08:19:30] (03PS20) 10Paladox: Update jquery.form.js [core] - 10https://gerrit.wikimedia.org/r/139688 [08:21:50] (03CR) 10Hashar: "I have been bold and merged the dependent libraries in mediawiki/core/vendor . That makes the Jenkins jobs mediawiki-core-vendor-integrati" [core] - 10https://gerrit.wikimedia.org/r/119940 (owner: 10BryanDavis) [08:22:19] (03PS21) 10Paladox: Update jquery.mockjax.js to v1.5.3 [core] - 10https://gerrit.wikimedia.org/r/139693 [08:22:28] (03CR) 10Paladox: [C: 031] Update jquery.mockjax.js to v1.5.3 [core] - 10https://gerrit.wikimedia.org/r/139693 (owner: 10Paladox) [08:22:40] (03CR) 10Paladox: Update jquery.mockjax.js to v1.5.3 [core] - 10https://gerrit.wikimedia.org/r/139693 (owner: 10Paladox) [08:23:46] (03CR) 10Withoutaname: "I'm considering using __METHOD__ in the message instead of passing "2" as the second parameter, like how the old wfWarn call worked in the" [core] - 10https://gerrit.wikimedia.org/r/143211 (owner: 10Withoutaname) [08:24:32] 3MediaWiki / 3Search: Wrong number of search results - 10https://bugzilla.wikimedia.org/67731#c4 (10Andre Klapper) (In reply to Chad H. from comment #3) > Off by one should be fixed with Gerrit change #143385 which will hit ptwiki > tomorrow. So far it isn't fixed. [08:25:49] (03PS57) 10Paladox: Update jquery.hoverintent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [08:27:19] (03CR) 10Hoo man: [C: 032] Avoid race condition in GlobalBlocking::insertBlock [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/145503 (https://bugzilla.wikimedia.org/67815) (owner: 10Legoktm) [08:27:25] (03Merged) 10jenkins-bot: Avoid race condition in GlobalBlocking::insertBlock [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/145503 (https://bugzilla.wikimedia.org/67815) (owner: 10Legoktm) [08:27:50] morning hoo [08:28:04] hi legoktm [08:28:27] https://gerrit.wikimedia.org/r/145519 is an easy one :) [08:29:04] (03CR) 10Hoo man: [C: 032] Fix doc for GlobalBlocking::getRangeCondition() [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/145519 (owner: 10Legoktm) [08:29:09] Yes :P [08:29:09] (03Merged) 10jenkins-bot: Fix doc for GlobalBlocking::getRangeCondition() [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/145519 (owner: 10Legoktm) [08:29:23] Hope I'll find time to look at your new user merge related patches next week [08:29:31] busy with other stuff atm now [08:32:16] awesome. it's still a WIP right now, I hope to have it ready for review by the end of the weekend [08:42:16] (03PS1) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/145523 [08:52:36] (03PS2) 10Smuggli: Removed hardcoded alert window titles [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/145310 [08:58:27] (03PS2) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/145523 [08:58:50] hello, I'm building a free map where people can add pictures to points of interests. For example one can look up "Saint Jacques Street" and add pictures of that street. Since all pictures will be CC-licensed, I was wondering if it's OK to upload them to commons.wikimedia.org [09:02:47] (03PS1) 10Smuggli: Fixed some message keys [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/145524 [09:05:08] (03PS1) 10Prtksxna: Add bubble graphs with random data [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/145525 [09:05:15] zPlus: ask in #wikimedia-commons ? [09:05:51] (03PS1) 10Hashar: Support setting VERSION for phantomjs browser [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/145527 [09:06:19] thanks legoktm [09:06:26] (03CR) 10Hashar: Normalize ZeroBanner job (031 comment) [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/131048 (owner: 10Hashar) [09:07:02] (03PS5) 10Hashar: Normalize ZeroBanner job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/131048 [09:08:43] (03CR) 10Hashar: [C: 031] Normalize ZeroBanner job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/131048 (owner: 10Hashar) [09:08:46] 3MediaWiki extensions / 3CheckUser: CheckUsers "Get users" output formatting is weird - 10https://bugzilla.wikimedia.org/67811 (10Andre Klapper) p:5Unprio>3Normal [09:10:01] 3MediaWiki extensions / 3[other]: Add Special:RandomNotInCategory to Extension:RandomInCategory - 10https://bugzilla.wikimedia.org/67812 (10Andre Klapper) p:5Normal>3Low [09:12:47] (03PS2) 10Prtksxna: Add bubble graphs with random data [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/145525 [09:12:49] legoktm: ^ [09:12:53] (03CR) 10Nikerabbit: "This works, but Html::element would be more readable." [core] - 10https://gerrit.wikimedia.org/r/145036 (https://bugzilla.wikimedia.org/67740) (owner: 10Florianschmidtwelzow) [09:13:03] 3MediaWiki extensions / 3WikidataClient: Create Lua "classes" / metatables for data types - 10https://bugzilla.wikimedia.org/55923#c1 (10Marius Hoch) 5NEW>3RESO/WON I doubt there's a valid use case in Lua for this (at least from a Wikibase perspective where we get data formatted from the repo). Also thi... [09:14:06] (03CR) 10Zfilipin: [C: 032] Support setting VERSION for phantomjs browser [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/145527 (owner: 10Hashar) [09:14:34] (03CR) 10Zfilipin: [C: 032] Normalize ZeroBanner job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/131048 (owner: 10Hashar) [09:15:02] 3MediaWiki extensions / 3Translate: Add UserMerge support - 10https://bugzilla.wikimedia.org/67778#c1 (10Niklas Laxström) Please explain what this bug is about. [09:15:38] (03Merged) 10jenkins-bot: Support setting VERSION for phantomjs browser [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/145527 (owner: 10Hashar) [09:15:51] (03Merged) 10jenkins-bot: Normalize ZeroBanner job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/131048 (owner: 10Hashar) [09:26:46] 3MediaWiki extensions / 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - 10https://bugzilla.wikimedia.org/35342#c26 (10Eduard Braun) Is anyone working on merging PRO's corrected button sprite into code? I'm also seeing what Krinkle reported before (positioning issues of the shadow of all... [09:28:24] (03PS1) 10Legoktm: Add basic instructions on how to run [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/145528 [09:28:32] prtksxna: ^ [09:30:32] (03PS1) 10Swidmann: Notification Update Adapted to updated Echo extension set icons in Echo hook removed unused icon css file changed msg-keys to fit new echo extension [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/145529 [09:39:16] 3MediaWiki extensions / 3ContributionScores: Database error: Uncommited DB writes - 10https://bugzilla.wikimedia.org/67842#c1 (10Andre Klapper) Hi, * Which MediaWiki version is this about? * Why do you think that ContributionScores creates the "notice" (not: error) above, as there is no mention in the ou... [09:40:30] (03CR) 10Nikerabbit: "Perhaps I was unclear: People (might) rely on not getting a fatal error." [core] - 10https://gerrit.wikimedia.org/r/144646 (owner: 10Withoutaname) [09:41:43] (03CR) 10Nikerabbit: "And the usefulness of that is that the pages will still be displayed, instead of white page/error page." [core] - 10https://gerrit.wikimedia.org/r/144646 (owner: 10Withoutaname) [09:42:17] 3MediaWiki / 3Special pages: [[Special:RandomInCategory] ] should support type (e.g. only file or only page) - 10https://bugzilla.wikimedia.org/67813 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [09:43:02] 3MediaWiki / 3Special pages: Special:Version shows jumbled localized parser extension tags on he.wp - 10https://bugzilla.wikimedia.org/67840 (10Andre Klapper) p:5Unprio>3Low [09:44:32] 3MediaWiki extensions / 3General/Unknown: User links keyboard shortcuts do not work. - 10https://bugzilla.wikimedia.org/67824#c1 (10Andre Klapper) (In reply to Ritu Swain from comment #0) > When shortcuts for “Talk”, “Contributions” > are used, the respective links should be highlighted to let the user know... [09:44:46] 3MediaWiki extensions / 3Translate: Add UserMerge support - 10https://bugzilla.wikimedia.org/67778#c2 (10Kunal Mehta (Legoktm)) Any table that stores a user's id or username needs a handler for the UserMergeAccountFields hook in the UserMerge extension. It'll be necessary for bug 47918. If Translate already... [09:46:13] (03CR) 10Nikerabbit: Make if checks in RequestContext.php more concise (032 comments) [core] - 10https://gerrit.wikimedia.org/r/145423 (owner: 10Withoutaname) [09:46:41] (03CR) 10Legoktm: [C: 04-1] "Waiting on resolution of https://gerrit.wikimedia.org/r/#/c/145156/ first." (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/145216 (https://bugzilla.wikimedia.org/67757) (owner: 10Legoktm) [09:50:01] 3MediaWiki extensions / 3WikidataRepo: Wikidata: CTRL+click and middle click on search suggestions doesn't open the page in a new tab - 10https://bugzilla.wikimedia.org/57709 (10Thiemo Mättig) 5PATC>3RESO/FIX [09:52:31] (03CR) 10Jack Phoenix: "Are there any further concerns to be addressed, or could this be merged?" [core] - 10https://gerrit.wikimedia.org/r/143173 (https://bugzilla.wikimedia.org/63521) (owner: 10Jack Phoenix) [09:55:21] (03CR) 10Florianschmidtwelzow: "Right, but i thought better to use one class (Xml), i find this more accurate? :-)" [core] - 10https://gerrit.wikimedia.org/r/145036 (https://bugzilla.wikimedia.org/67740) (owner: 10Florianschmidtwelzow) [09:56:38] (03PS2) 10Legoktm: Add basic instructions on how to run [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/145528 [09:57:19] (03CR) 10Prtksxna: [C: 032 V: 032] "Thanks!" [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/145528 (owner: 10Legoktm) [09:57:34] 3Wikimedia / 3Site requests: New alias on ruwiki - 10https://bugzilla.wikimedia.org/67844 (10MaxBioHazard) 3NEW p:3Unprio s:3normal a:3None Please, add alias ОУ: to ns 3 (Обсуждение участника) in ruwiki. Discussion on [[Википедия:Форум/Предложения#Алиасы ОУ: и У:]] (Proposed there alias У: already de... [10:00:47] 3MediaWiki extensions / 3Renameuser: Merge RenameUser into core - 10https://bugzilla.wikimedia.org/25482#c13 (10Kunal Mehta (Legoktm)) (In reply to Nathan Larson from comment #12) > I agree, it should be merged into core. Would a patch to accomplish that be > accepted? If it's just the current code in the e... [10:04:11] (03CR) 10Esanders: [C: 031] QUnit: Detect unfinished jQuery effects or ajax requests in teardown [core] - 10https://gerrit.wikimedia.org/r/145483 (owner: 10Krinkle) [10:11:41] (03PS2) 10Rohan013: $wgUseTwoButtonForm is set to false by default [core] - 10https://gerrit.wikimedia.org/r/145517 (https://bugzilla.wikimedia.org/40622) [10:24:03] (03CR) 10Nikerabbit: "In my opinion, prettiness&consistency should come second to code readability (though they are very much related)." [core] - 10https://gerrit.wikimedia.org/r/145036 (https://bugzilla.wikimedia.org/67740) (owner: 10Florianschmidtwelzow) [10:27:34] (03CR) 10Rillke: "Hey, thank you guys!" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/119082 (owner: 10Mattflaschen) [10:29:09] (03PS1) 10Raimond Spekking: Fix syntax error [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/145531 [10:29:18] (03CR) 10Raimond Spekking: [C: 032 V: 032] Fix syntax error [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/145531 (owner: 10Raimond Spekking) [10:36:32] 3MediaWiki extensions / 3Translate: Add UserMerge support - 10https://bugzilla.wikimedia.org/67778#c3 (10Niklas Laxström) *shakes head* Can someone please first make the extensions use the same hook or at least the same format for the same data. [10:42:28] (03CR) 10Hashar: [C: 032] jshint: ignore libs/jquery.qtip.js [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/144458 (https://bugzilla.wikimedia.org/61609) (owner: 10Hashar) [10:42:36] (03Merged) 10jenkins-bot: jshint: ignore libs/jquery.qtip.js [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/144458 (https://bugzilla.wikimedia.org/61609) (owner: 10Hashar) [10:42:38] (03CR) 10Hashar: [C: 032] Provide default jshintrc file [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/144459 (https://bugzilla.wikimedia.org/61609) (owner: 10Hashar) [10:42:44] (03Merged) 10jenkins-bot: Provide default jshintrc file [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/144459 (https://bugzilla.wikimedia.org/61609) (owner: 10Hashar) [10:42:49] 3MediaWiki extensions / 3Cite: Missing causes malformed rendering without showing an error - 10https://bugzilla.wikimedia.org/67845 (10Gadget850) 3NEW p:3Unprio s:3normal a:3None Withe the resolution of Bug 66860, a missing reference list is now automatically added. But Bug 21798 "Misleading e... [10:43:19] 3MediaWiki / 3User preferences: One-click system for setting user preferences - 10https://bugzilla.wikimedia.org/67846 (10Scott Martin (http://enwp.org/User:Scott)) 3NEW p:3Unprio s:3normal a:3None This was an interesting comment from WhatamIdoing on bug 67826, so I thought I'd split it out for its o... [10:43:32] 3MediaWiki extensions / 3Cite: Cite: If there's no block on the page, show one automatically below the content rather than showing an error - 10https://bugzilla.wikimedia.org/66860#c19 (10Gadget850) New problem: Bug 67845 [10:43:35] (03CR) 10Nikerabbit: [C: 031] Updating for CLDR database v.25, also fixing rebuild script [extensions/cldr] - 10https://gerrit.wikimedia.org/r/145455 (owner: 10Kaldari) [10:43:38] (03PS1) 10Hashar: Make Lingo jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/145534 (https://bugzilla.wikimedia.org/61609) [10:43:51] (03CR) 10Hashar: [C: 032] Make Lingo jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/145534 (https://bugzilla.wikimedia.org/61609) (owner: 10Hashar) [10:43:55] (03Merged) 10jenkins-bot: Make Lingo jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/145534 (https://bugzilla.wikimedia.org/61609) (owner: 10Hashar) [10:44:02] 3MediaWiki / 3User preferences: One-click system for setting user preferences - 10https://bugzilla.wikimedia.org/67846 (10Scott Martin (http://enwp.org/User:Scott)) p:5Unprio>3Low s:5normal>3enhanc [10:44:33] 3MediaWiki extensions / 3Lingo: Lingo should pass jshint - 10https://bugzilla.wikimedia.org/61609 (10Antoine "hashar" Musso) 5PATC>3RESO/FIX a:3Antoine "hashar" Musso [10:44:46] 3Wikimedia / 3Site requests: Disable Media Viewer by default on the English Wikipedia - 10https://bugzilla.wikimedia.org/67826#c13 (10Scott Martin (http://enwp.org/User:Scott)) (In reply to WhatamIdoing from comment #2) > Changing default user preferences means overriding the choices of registered > editors... [10:45:02] 3MediaWiki skins / 3Vector: Default icon in vector for "profile" in personal tools should be gender neutral and fit with other site icons look & feel - 10https://bugzilla.wikimedia.org/41484#c55 (10Nemo) What is the pre-login or post-login icon? Jared, please file a separate bug report for separate issues. T... [10:45:58] (03CR) 10Hashar: "If the job ever work, feel free to self merge this change =)" [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/144937 (https://bugzilla.wikimedia.org/62737) (owner: 10Zfilipin) [11:00:32] (03PS1) 10Hashar: Trigger Elastica jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/145535 (https://bugzilla.wikimedia.org/63231) [11:01:17] (03CR) 10Hashar: [C: 032] Trigger Elastica jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/145535 (https://bugzilla.wikimedia.org/63231) (owner: 10Hashar) [11:01:22] (03Merged) 10jenkins-bot: Trigger Elastica jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/145535 (https://bugzilla.wikimedia.org/63231) (owner: 10Hashar) [11:01:58] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/145536 (https://bugzilla.wikimedia.org/63231) [11:02:16] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/145536 (https://bugzilla.wikimedia.org/63231) (owner: 10Hashar) [11:03:31] 3MediaWiki extensions / 3Translate: Add UserMerge support - 10https://bugzilla.wikimedia.org/67778#c4 (10Kunal Mehta (Legoktm)) (In reply to Niklas Laxström from comment #3) > *shakes head* Can someone please first make the extensions use the same hook > or at least the same format for the same data. No, be... [11:05:48] 3MediaWiki extensions / 3Cite: Missing causes malformed rendering without showing an error - 10https://bugzilla.wikimedia.org/67845 (10Andre Klapper) [11:05:48] 3MediaWiki extensions / 3Cite: Cite: If there's no block on the page, show one automatically below the content rather than showing an error - 10https://bugzilla.wikimedia.org/66860 (10Andre Klapper) [11:06:17] 3Wikimedia / 3Site requests: Add alias on ruwiki: ОУ: for Обсуждение участника - 10https://bugzilla.wikimedia.org/67844 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [11:06:49] 3MediaWiki extensions / 3Cite: Cite: If there's no block on the page for grouped references, show one automatically below the content rather than showing an error - 10https://bugzilla.wikimedia.org/67847 (10Gadget850) 3NEW p:3Unprio s:3normal a:3None Bug 66860 added a missing reference... [11:21:03] (03PS1) 10Matthias Mullie: Fix WrongNumberArgumentsException [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145538 [11:21:06] (03PS1) 10Matthias Mullie: Fix diff view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145539 [11:21:09] (03PS1) 10Matthias Mullie: Log improvements. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145540 [11:22:57] (03CR) 10jenkins-bot: [V: 04-1] Log improvements. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145540 (owner: 10Matthias Mullie) [11:35:30] (03PS1) 10Legoktm: Update larger tables via the job queue [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/145543 [11:36:14] (03PS3) 10Legoktm: Add MergeAccountFromTo & DeleteAccount hook subscribers [extensions/AccountAudit] - 10https://gerrit.wikimedia.org/r/145223 (https://bugzilla.wikimedia.org/67783) [11:37:11] (03CR) 10Legoktm: "Yeah, that sounds good. Done." [extensions/AccountAudit] - 10https://gerrit.wikimedia.org/r/145223 (https://bugzilla.wikimedia.org/67783) (owner: 10Legoktm) [11:39:11] (03PS1) 10Rillke: Update Recorderjs to f814ac7b3f [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/145544 [11:41:37] (03CR) 10Rillke: "Eeek, you have no Jenkins bot here?" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/145544 (owner: 10Rillke) [11:44:21] (03PS1) 10Swidmann: Active personal link color changed css selector for active personal links removed echo dependency [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/145545 [11:45:04] 3MediaWiki / 3General/Unknown: If-Modified-Since handling is broken - 10https://bugzilla.wikimedia.org/67849 (10bianjiang) 3UNCO p:3Unprio s:3major a:3None We (crawling team in Google) found that Wikipedia's If-Modified-Since handling is broken, at least when it comes to (Wikipedia-style) redirects/s... [11:47:49] (03CR) 10Siebrand: [C: 031] [UNMERGED] Update OOjs UI to v0.1.0-pre (051816c6a7) [core] - 10https://gerrit.wikimedia.org/r/144901 (owner: 10Trevor Parscal) [11:47:55] (03CR) 10Siebrand: "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/144901 (owner: 10Trevor Parscal) [11:48:53] (03PS2) 10Matthias Mullie: Log improvements. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145540 [11:49:24] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145540 (owner: 10Matthias Mullie) [11:49:41] (03PS1) 10Mr. Stradivarius: Improve error messages in mw.html [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145547 [11:50:16] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144832 (owner: 10Bsitu) [11:51:25] (03PS1) 10Legoktm: Add UserMergeAccountFields hook subscriber [extensions/CommunityVoice] - 10https://gerrit.wikimedia.org/r/145548 (https://bugzilla.wikimedia.org/67763) [11:52:32] 3MediaWiki-Vagrant: can't run Selenium tests on Windows - 10https://bugzilla.wikimedia.org/51882#c3 (10Željko Filipin) I have added Dan to cc, he is working on mediawiki-vagrant these days, as far as I know. Dan, I have mentioned this problem on Tuesday. Let me know if you do not remember. [11:53:09] Reedy: Yay, success! It worked after I switched to ssh. Thanks to you and to wctaiwan for the tips. :) [11:53:55] (03CR) 10Legoktm: [C: 032] UserMerge support [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/145150 (https://bugzilla.wikimedia.org/67754) (owner: 10Reedy) [11:54:03] (03Merged) 10jenkins-bot: UserMerge support [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/145150 (https://bugzilla.wikimedia.org/67754) (owner: 10Reedy) [11:55:07] (03CR) 10Siebrand: "Quick i18n/L10n review." (036 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/145529 (owner: 10Swidmann) [11:55:18] (03CR) 10Siebrand: [C: 04-1] "Quick i18n/L10n review." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/145529 (owner: 10Swidmann) [11:55:19] 3MediaWiki extensions / 3LiquidThreads: Add UserMerge support - 10https://bugzilla.wikimedia.org/67754 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Sam Reed (reedy) [11:56:22] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/145523 (owner: 10Smuggli) [11:56:38] (03PS5) 10Hashar: Drop history of mw/core jobs after 15 days [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136993 (https://bugzilla.wikimedia.org/63936) [12:00:20] (03CR) 10Legoktm: [C: 032 V: 032] "LGTM" [extensions/SkinPerPage] - 10https://gerrit.wikimedia.org/r/143242 (owner: 10Isarra) [12:02:02] (03PS6) 10Hashar: Drop history of mw/core jobs after some time [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136993 (https://bugzilla.wikimedia.org/63936) [12:02:56] (03CR) 10Hashar: [C: 032] "Deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136993 (https://bugzilla.wikimedia.org/63936) (owner: 10Hashar) [12:03:29] (03Merged) 10jenkins-bot: Drop history of mw/core jobs after some time [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136993 (https://bugzilla.wikimedia.org/63936) (owner: 10Hashar) [12:03:49] has anyone seen the problem recently that text in edit box hides under the WikiEditor toolbar? [12:03:51] (03PS31) 10Legoktm: Added VERP functionality hook to core [core] - 10https://gerrit.wikimedia.org/r/138655 (https://bugzilla.wikimedia.org/46640) (owner: 1001tonythomas) [12:03:57] andre__: ^ any similar bug report? [12:05:43] liangent: none that I know of. Only recent WikiEditor toolbar related one I'm aware of is https://bugzilla.wikimedia.org/show_bug.cgi?id=67111 [12:05:47] but that's not what you describe [12:08:05] (03CR) 10Legoktm: [C: 04-1] "API module looks fine" (031 comment) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/144656 (owner: 1001tonythomas) [12:12:15] (03CR) 10Legoktm: [C: 032] Added VERP functionality hook to core [core] - 10https://gerrit.wikimedia.org/r/138655 (https://bugzilla.wikimedia.org/46640) (owner: 1001tonythomas) [12:13:22] DanielK_WMDE_: Could you spare a few mins to review https://gerrit.wikimedia.org/r/#/c/137033/ ? [12:13:27] (03CR) 10Smuggli: [C: 04-1] "qqq is missing and please migrate to json" (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/145529 (owner: 10Swidmann) [12:17:08] siebrand: i have repeatedly stared at this. the concept of page language seems to be ill defined, misunderstood and abused - i have no idea what's "right" any more. [12:17:25] DanielK_WMDE_: Could you comment then? [12:17:51] DanielK_WMDE_: The problem I currently have is that a GSoC student built on this code and will get stuck if there's not progress here. [12:17:57] siebrand: i could articulate my confusion :) and do general code style bitching [12:18:09] DanielK_WMDE_: Both will be appreciated; at least by me :) [12:21:03] 3MediaWiki extensions / 3WikiEditor: In Insert Image dialog box the Align and Format settings are not set to any values - 10https://bugzilla.wikimedia.org/67111#c1 (10Andre Klapper) p:5Unprio>3Low Confirming on test2 with Firefox 30 [12:24:31] 3MediaWiki / 3General/Unknown: If-Modified-Since handling is broken - 10https://bugzilla.wikimedia.org/67849#c1 (10Andre Klapper) p:5Unprio>3High Thanks for reporting this! Wondering who could investigate here. Greg? [12:25:30] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [12:27:06] (03CR) 10Daniel Kinzler: [C: 04-1] "Please structure the code a bit more, perhaps then I can understand and review the intended logic..." (036 comments) [core] - 10https://gerrit.wikimedia.org/r/137033 (owner: 10SPQRobin) [12:27:14] siebrand: like that? [12:27:24] i hope i wasn't too bitchy :) [12:29:07] DanielK_WMDE_: excellent. Many thanks. [12:35:02] 3MediaWiki / 3Page protection: Protecting action doesn't update page links - 10https://bugzilla.wikimedia.org/34039#c4 (10Betacommand) Anyone? [12:35:32] 3MediaWiki extensions / 3ContributionScores: Database error: Uncommited DB writes - 10https://bugzilla.wikimedia.org/67842#c2 (10Marco) * MediWiki Version 1.22.3 * It only happens, when the Extension is activated via require_once("$IP/extensions/ContributionScores/ContributionScores.php"); Further the messag... [12:35:59] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/145474 (https://bugzilla.wikimedia.org/67700) (owner: 10Alex Monk) [12:37:19] Is there somebody who can help me with mediawiki API:Upload? [12:40:34] (03PS28) 10Matthias Mullie: Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson) [12:41:34] 3MediaWiki / 3Skin and page rendering: Invisible links in dialogs - 10https://bugzilla.wikimedia.org/67851 (10Fomafix) 3NEW p:3Unprio s:3enhanc a:3None Links in dialogs are invisible because jquery.ui.theme.css[1] set the color of the links to the same color as the text around: .ui-widget-content {... [12:44:14] (03CR) 10Matthias Mullie: [C: 04-1] "I just rebased & tested this patch." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson) [12:45:46] (03CR) 10Matthias Mullie: [C: 032] Content is missing when clicking on 'Edit title' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145485 (owner: 10Bsitu) [12:46:37] (03Merged) 10jenkins-bot: Content is missing when clicking on 'Edit title' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145485 (owner: 10Bsitu) [12:49:37] (03CR) 10Matthias Mullie: [C: 032] Hygine: RecentChangesQuery doesnt really depend on a user [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145514 (owner: 10EBernhardson) [12:50:05] (03PS1) 10Krinkle: special.js: Use then() instead of manually wrapping Deferred [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/145552 [12:50:28] (03Merged) 10jenkins-bot: Hygine: RecentChangesQuery doesnt really depend on a user [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145514 (owner: 10EBernhardson) [12:50:40] (03CR) 10Krinkle: "Untested." [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/145552 (owner: 10Krinkle) [12:52:17] (03CR) 10Matthias Mullie: [C: 032] Hygine: unreachable logging statement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145515 (owner: 10EBernhardson) [12:55:58] (03CR) 10Matthias Mullie: [C: 04-1] "This change is ok, but before we merge it, we have to get rid of those problematic messages." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145490 (owner: 10Bsitu) [12:58:12] (03CR) 10Siebrand: [C: 031] "LGTM. Added two FR peeps because of the changes in the currency related stuffs. I think it's okay, but I wanted them to see it. Can be +2-" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/145455 (owner: 10Kaldari) [13:00:30] (03Merged) 10jenkins-bot: Hygine: unreachable logging statement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145515 (owner: 10EBernhardson) [13:02:55] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Collection] - 10https://gerrit.wikimedia.org/r/139201 (owner: 10Mwalker) [13:04:58] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Collection] - 10https://gerrit.wikimedia.org/r/145192 (owner: 10Mwalker) [13:05:25] (03CR) 10Matthias Mullie: [C: 04-1] "lightncandy seems to have drastically changed in master" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145142 (owner: 10EBernhardson) [13:06:32] 3Wikimedia / 3Extension setup: Wikimedia should become an OpenID provider - 10https://bugzilla.wikimedia.org/13631#c34 (10Dereckson) Pure OpenID identification on blogs, solutions like BitBucket use OpenID 2.0. OAuth doesn't accomplish the goal of universal identification (but provides authentication) solut... [13:07:31] 3Wikimedia / 3Site requests: Add alias on ruwiki: ОУ: for Обсуждение участника - 10https://bugzilla.wikimedia.org/67844#c1 (10Dereckson) 5NEW>3ASSI [Taking this bug] [13:07:45] (03CR) 10Matthias Mullie: [C: 032] Abstract the logic of getting last bundle notif into a method [extensions/Echo] - 10https://gerrit.wikimedia.org/r/145044 (owner: 10Bsitu) [13:08:14] (03Merged) 10jenkins-bot: Abstract the logic of getting last bundle notif into a method [extensions/Echo] - 10https://gerrit.wikimedia.org/r/145044 (owner: 10Bsitu) [13:09:27] liangent: you can hide/unhide the advanced toolbar, and after that it should work again [13:10:07] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (033 comments) [extensions/Petition] - 10https://gerrit.wikimedia.org/r/145435 (https://bugzilla.wikimedia.org/65850) (owner: 10Pcoombe) [13:10:52] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Petition] - 10https://gerrit.wikimedia.org/r/142737 (https://bugzilla.wikimedia.org/65850) (owner: 10Pcoombe) [13:11:20] thedj: hm yeah it works [13:11:24] so what's its cause? [13:11:30] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Petition] - 10https://gerrit.wikimedia.org/r/142561 (owner: 10Pcoombe) [13:12:02] 3MediaWiki extensions / 3Translate: Add UserMerge support - 10https://bugzilla.wikimedia.org/67778#c5 (10Niklas Laxström) (In reply to Kunal Mehta (Legoktm) from comment #4) > (In reply to Niklas Laxström from comment #3) > > *shakes head* Can someone please first make the extensions use the same hook > > or... [13:13:50] (03CR) 10TheDJ: [C: 032] Set autofocus on Special:Unblock [core] - 10https://gerrit.wikimedia.org/r/129944 (owner: 10Umherirrender) [13:14:31] MatmaRex: Thought you might like this, https://gist.github.com/Krinkle/5cfdf40900091a508185 [13:14:34] https://wikitech.wikimedia.org/wiki/Special:Log/Krinkle [13:16:16] (and thedj) [13:16:23] Krinkle: ha, neat. i didn't even realize how simple postWithToken made things like this [13:16:49] and of course async tail recursion without spawning off 500 requests at once [13:16:53] thanks to promise [13:18:19] Of course one could go a litlte further and query the brokenredirects from the api instead of screenscraping [13:18:23] but I'm too lazy for that right now. [13:22:22] (03PS1) 10Hoo man: Update Wikidata to fix a problem with the wbsearchentities API [core] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/145557 [13:23:00] (03PS1) 10Hoo man: Update Wikidata to fix a problem with the wbsearchentities API [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/145558 [13:23:16] 3Wikimedia / 3Site requests: Add alias on ruwiki: ОУ: for Обсуждение участника - 10https://bugzilla.wikimedia.org/67844#c3 (10Dereckson) The discussion considered also U: and UT: as aliases. The dual use of latin and cyrillic alias seems to already exists for NS_TEMPLATE (Ш and T). Should I add U: and UT:... [13:23:49] 3Wikimedia / 3Site requests: Add alias on ruwiki: ОУ: for Обсуждение участника - 10https://bugzilla.wikimedia.org/67844 (10Dereckson) a:3Dereckson [13:25:20] (03PS1) 10Joeytje50: Version 1.1: added Android Browser support, minor other changes [extensions/Tabs] - 10https://gerrit.wikimedia.org/r/145559 [13:25:49] 3MediaWiki extensions / 3OpenStackManager: OpenStackManager: Missing message "<novaresources>" on Special:SpecialPages - 10https://bugzilla.wikimedia.org/67852 (10Krinkle) 3NEW p:3Unprio s:3normal a:3Ryan Lane https://wikitech.wikimedia.org/wiki/Special:SpecialPages OpenStack Nova ---- <no... [13:26:03] 3MediaWiki extensions / 3OpenStackManager: OpenStackManager: Missing message "<novaresources>" on Special:SpecialPages - 10https://bugzilla.wikimedia.org/67852 (10Krinkle) p:5Unprio>3Normal [13:31:47] 3Wikimedia / 3Site requests: Add alias on ruwiki: ОУ: for Обсуждение участника - 10https://bugzilla.wikimedia.org/67844#c4 (10MaxBioHazard) Yes, add latin aliases too. [13:33:18] (03PS1) 10Paladox: Update OggHandler [extensions/OggHandler] - 10https://gerrit.wikimedia.org/r/145562 [13:34:02] 3Wikimedia / 3Site requests: Add alias on ruwiki: ОУ: for Обсуждение участника - 10https://bugzilla.wikimedia.org/67844#c5 (10Dereckson) Okay. [Adding URL] [13:34:31] guys, I need to know something [13:34:47] 3MediaWiki / 3Page protection: Protecting action doesn't update page links - 10https://bugzilla.wikimedia.org/34039#c5 (10Bartosz Dziewoński) Probably changing page protection should just call WikiPage::doEditUpdates()? [13:34:47] I just pushed a commit, but I didn't mind the trailing whitespace [13:34:58] so I wanted to fix that in another commit [13:35:10] but it now says there are 2 outstanding commits [13:35:20] (03PS2) 10Paladox: Update OggHandler [extensions/OggHandler] - 10https://gerrit.wikimedia.org/r/145562 [13:35:23] one of them is the commit I just pushed [13:35:29] so what should I do now? [13:35:29] (03PS3) 10Paladox: Update OggHandler [extensions/OggHandler] - 10https://gerrit.wikimedia.org/r/145562 [13:35:35] submit them both? [13:37:47] 3MediaWiki / 3Page protection: Protecting action doesn't update page links - 10https://bugzilla.wikimedia.org/34039#c6 (10Bartosz Dziewoński) Or WikiPage::doUpdateRestrictions() should clear some caches itself. [13:38:54] (03PS1) 10Joeytje50: Removed trailing whitespace. [extensions/Tabs] - 10https://gerrit.wikimedia.org/r/145563 [13:39:29] (03PS4) 10Paladox: Update OggHandler [extensions/OggHandler] - 10https://gerrit.wikimedia.org/r/145562 [13:39:46] (03PS5) 10Paladox: Update OggHandler [extensions/OggHandler] - 10https://gerrit.wikimedia.org/r/145562 [13:39:47] 3MediaWiki extensions / 3Cite: Misleading error message for omitted tag - 10https://bugzilla.wikimedia.org/21798#c6 (10Gadget850) With the resolution of Bug 66860, there is no longer any error generated for this issue, it just renders the rest of the page oddly. See bug 67845. [13:52:33] (03PS3) 10Matthias Mullie: Log improvements. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145540 [13:53:50] (03CR) 10jenkins-bot: [V: 04-1] Log improvements. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145540 (owner: 10Matthias Mullie) [13:53:55] (03CR) 10Yaron Koren: "Great, it's looking better. I still don't look $banned, though - it doesn't make sense to me. If anything it's the namespaces doing the "b" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [13:55:03] (03PS4) 10Matthias Mullie: Log improvements. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145540 [13:55:59] (03CR) 10jenkins-bot: [V: 04-1] Log improvements. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145540 (owner: 10Matthias Mullie) [13:56:02] (03PS1) 10Smuggli: Added Messages for ResponsibleEditors log [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/145565 [13:58:13] (03PS5) 1001tonythomas: Added API to handle incoming emails automatically [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/144656 [13:59:09] (03PS24) 10Matthias Mullie: Enable Topic namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143186 (owner: 10EBernhardson) [13:59:22] (03PS15) 10Matthias Mullie: Flow topic reply notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144832 (owner: 10Bsitu) [13:59:40] (03PS27) 10Matthias Mullie: Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 (owner: 10Bsitu) [13:59:50] (03PS5) 10Matthias Mullie: Log improvements. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145540 [14:01:19] 3MediaWiki extensions / 3WikidataRepo: SummaryFormatterTest fails when wiki language is set to Arabic - 10https://bugzilla.wikimedia.org/67853 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs 1) Wikibase\Test\SummaryFormatterTest::testOnFormat with data set #2 ('wikibase-item', 'wikibase-item', 'fo... [14:01:40] (03PS6) 10Matthias Mullie: Log improvements. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145540 [14:10:40] (03CR) 10Matthias Mullie: [C: 04-1] Enable Topic namespace (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143186 (owner: 10EBernhardson) [14:14:17] 3MediaWiki / 3General/Unknown: If-Modified-Since handling is broken - 10https://bugzilla.wikimedia.org/67849#c2 (10Brad Jorsch) 5UNCO>3NEW The cause of the problem is simple enough: when MediaWiki follows a redirect, it uses the page_touched timestamp of the target page.[1] A simple change to fix this b... [14:15:03] (03PS1) 10Anomie: Take redirect modifications into account for If-Modified-Since [core] - 10https://gerrit.wikimedia.org/r/145568 (https://bugzilla.wikimedia.org/67849) [14:18:45] (03PS2) 10Robert Vogel: [WIP] TitleCombo [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/145323 [14:24:23] (03CR) 10Parent5446: Make if checks in RequestContext.php more concise (031 comment) [core] - 10https://gerrit.wikimedia.org/r/145423 (owner: 10Withoutaname) [14:24:33] (03CR) 10Gilles: [C: 04-1] "The jumping back-and-forth is definitely gone, however the change introduces a new issue:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/145428 (owner: 10MarkTraceur) [14:24:45] (03PS1) 10Swidmann: UserPrefernces fixed bug in usersidbar little refactoring for REL2_23 [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/145569 [14:25:20] (03CR) 10Gilles: [C: 032] remove license talk from CREDITS [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/145465 (owner: 10Neilk) [14:26:30] (03Merged) 10jenkins-bot: remove license talk from CREDITS [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/145465 (owner: 10Neilk) [14:27:09] (03PS3) 10Pcoombe: Add logging for signatures, and integration with CheckUser [extensions/Petition] - 10https://gerrit.wikimedia.org/r/145435 (https://bugzilla.wikimedia.org/65850) [14:28:06] (03PS1) 10Swidmann: Config class change for preferences added method in config class to reduce code for preferences small fix in shm cache class [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/145570 [14:29:09] (03CR) 10Pcoombe: Add logging for signatures, and integration with CheckUser (033 comments) [extensions/Petition] - 10https://gerrit.wikimedia.org/r/145435 (https://bugzilla.wikimedia.org/65850) (owner: 10Pcoombe) [14:32:20] 3MediaWiki extensions / 3WikidataRepo: Cannot see Wikidata results in language of Wikipedia - 10https://bugzilla.wikimedia.org/67855 (10Rahmanuddin Shaik) 3UNCO p:3Unprio s:3normal a:3Wikidata bugs Created attachment 15908 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15908&action=edit Wikid... [14:34:16] 3MediaWiki extensions / 3WikidataRepo: Cannot see Wikidata results in language of Wikipedia - 10https://bugzilla.wikimedia.org/67855#c1 (10Marius Hoch) 5UNCO>3RESO/WON This isn't a component managed by us, but some gadget or user script. [14:35:39] (03Merged) 10jenkins-bot: Added VERP functionality hook to core [core] - 10https://gerrit.wikimedia.org/r/138655 (https://bugzilla.wikimedia.org/46640) (owner: 1001tonythomas) [14:37:52] (03PS1) 10Thiemo Mättig (WMDE): Make OutputPageTest more independent from global state [core] - 10https://gerrit.wikimedia.org/r/145571 [14:37:57] (03CR) 10Revi: [C: 031] Split "suppressrevision" into two user rights [core] - 10https://gerrit.wikimedia.org/r/139277 (https://bugzilla.wikimedia.org/20476) (owner: 10Vogone) [14:39:49] (03Merged) 10jenkins-bot: Set autofocus on Special:Unblock [core] - 10https://gerrit.wikimedia.org/r/129944 (owner: 10Umherirrender) [14:42:17] 3MediaWiki extensions / 3SemanticFormsInputs: action "formedit" fails in case not valid value is present for input type "two listboxes" - 10https://bugzilla.wikimedia.org/67739#c1 (10[[kgh]]) 5NEW>3RESO/INV I just have cross-checked with SFI 0.7.0, SF 2.7.0 and SMW 1.8.x and verified that this issue was... [14:48:02] 3MediaWiki extensions / 3SearchExtraNS: Cannot see Wikidata results in language of Wikipedia - 10https://bugzilla.wikimedia.org/67855#c2 (10Rahmanuddin Shaik) 5RESO/?>3VERI Please change the status to Unconfirmed. [14:49:31] 3MediaWiki extensions / 3SearchExtraNS: Cannot see Wikidata results in language of Wikipedia - 10https://bugzilla.wikimedia.org/67855#c3 (10Andre Klapper) Rahmanuddin: You verified the RESOLVED status and ask at the same time to set it to UNCONFIRMED without explaining why, plus changed the component without... [14:52:02] 3MediaWiki extensions / 3SearchExtraNS: Cannot see Wikidata results in language of Wikipedia - 10https://bugzilla.wikimedia.org/67855#c4 (10Andre Klapper) As I don't get any English results or Wikidata results on https://te.wikipedia.org/w/index.php?search=%E0%B0%B0%E0%B0%BE%E0%B0%A7%E0%B1%87%E0%B0%B6%E0%B1%... [14:54:38] (03CR) 10Smuggli: "Is there anything more coming? Why do you add a method and don't use it? Please seperat commits which don't belong to the same topic." [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/145570 (owner: 10Swidmann) [14:57:12] (03CR) 10Smuggli: [C: 031 V: 031] Active personal link color changed css selector for active personal links removed echo dependency [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/145545 (owner: 10Swidmann) [14:57:35] (03CR) 10Helder.wiki: [C: 031] Fix for Bug 63980 - Comparison of limits in pingLimiter is incorrect [core] - 10https://gerrit.wikimedia.org/r/138609 (owner: 10Rohan013) [15:00:32] 3MediaWiki extensions / 3General/Unknown: Cannot see Wikidata gadget search results in language of te.wikipedia - 10https://bugzilla.wikimedia.org/67855#c5 (10Andre Klapper) 5VERI>3VERI Ah, either related to https://te.wikipedia.org/wiki/ప్రత్యేక:అభిరుచులు#mw-prefsection-gadgets which has a section " (03CR) 10Hoo man: [C: 032] Update Wikidata to fix a problem with the wbsearchentities API [core] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/145557 (owner: 10Hoo man) [15:05:01] (03CR) 10Hoo man: [C: 032] Update Wikidata to fix a problem with the wbsearchentities API [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/145558 (owner: 10Hoo man) [15:06:13] (03CR) 10Krinkle: [C: 031] mw.Debug.profile: Tweak support check to handle PhantomJS [core] - 10https://gerrit.wikimedia.org/r/144601 (owner: 10Mattflaschen) [15:06:23] (03PS2) 10Krinkle: Fix spurious QUnit failures related to fake timers [core] - 10https://gerrit.wikimedia.org/r/145479 (https://bugzilla.wikimedia.org/63579) (owner: 10Mattflaschen) [15:07:03] 3MediaWiki extensions / 3Cite: Cite: If there's no block on the page, show one automatically below the content rather than showing an error - 10https://bugzilla.wikimedia.org/66860 (10Andre Klapper) [15:07:03] 3MediaWiki extensions / 3Cite: Cite: If there's no block on the page for grouped references, show one automatically below the content rather than showing an error - 10https://bugzilla.wikimedia.org/67847 (10Andre Klapper) [15:07:05] (03CR) 10Krinkle: "Would recommend I1dba146a679588 / I883ca95dbfd003a instead." [core] - 10https://gerrit.wikimedia.org/r/145479 (https://bugzilla.wikimedia.org/63579) (owner: 10Mattflaschen) [15:07:42] (03Abandoned) 10Krinkle: Use QUnit.asyncTest even for fake timers, to fix spurious failures [core] - 10https://gerrit.wikimedia.org/r/143481 (https://bugzilla.wikimedia.org/63579) (owner: 10Mattflaschen) [15:08:01] anomie: on line 561 of ustring.lua, what's "pos" supposed to be? there is no variable called pos ever set anywhere else [15:08:29] (03CR) 10Withoutaname: Make if checks in RequestContext.php more concise (031 comment) [core] - 10https://gerrit.wikimedia.org/r/145423 (owner: 10Withoutaname) [15:08:57] hi jackmcbarn - just wanted to thank you for your many contributions to MediaWiki [15:09:09] (03CR) 10Smuggli: [C: 031 V: 031] UserPrefernces fixed bug in usersidbar little refactoring for REL2_23 [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/145569 (owner: 10Swidmann) [15:09:21] sumanah: you're welcome! [15:09:33] jackmcbarn: will we see you at any upcoming events? https://www.mediawiki.org/wiki/Events#2014 [15:09:42] sumanah: i don't think so, unfortunately [15:09:56] jackmcbarn: ... Good question [15:10:06] jackmcbarn: hope that changes. :) what regions of the world you can get to easily? [15:10:27] it's not that i can't get there, it's that i like my pseudonymity [15:10:52] Ah. [15:11:32] (03Merged) 10jenkins-bot: Update Wikidata to fix a problem with the wbsearchentities API [core] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/145557 (owner: 10Hoo man) [15:11:37] I'm pretty sure we've seen people at these events who only give pseudonyms and avoid being photographed (we have photo-related policies for this reason) but of course I respect your decision jackmcbarn [15:12:15] (example: at the past few European hackathons, we've had specific lanyard colours that mean "do not photograph me") [15:14:43] (03Merged) 10jenkins-bot: Update Wikidata to fix a problem with the wbsearchentities API [core] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/145558 (owner: 10Hoo man) [15:15:12] sounds like a good policy to have at any event [15:16:20] (03CR) 10Smuggli: [C: 031 V: 031] "If another commit depends on this one, please provide the information." [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/145570 (owner: 10Swidmann) [15:17:47] 3MediaWiki / 3Email: Add proper email bounce handling to MediaWiki (with VERP) - 10https://bugzilla.wikimedia.org/46640#c25 (10Nemo) 5PATC>3NEW No more open patches associated to this bug; resetting status. It seems that most of the work has moved to the BounceHandler extension: https://gerrit.wikimedia... [15:18:02] (03CR) 10Jackmcbarn: "recheck" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145547 (owner: 10Mr. Stradivarius) [15:18:39] gi11es: indeed! I would suggest it for all Wikimedia events. [15:20:19] (03CR) 10Paladox: [C: 031] Update OggHandler [extensions/OggHandler] - 10https://gerrit.wikimedia.org/r/145562 (owner: 10Paladox) [15:20:28] (03CR) 10Paladox: Update OggHandler [extensions/OggHandler] - 10https://gerrit.wikimedia.org/r/145562 (owner: 10Paladox) [15:20:59] jackmcbarn: why don't you come disguised in costume of an appropriate fictional character [15:21:33] As for Wikimania 2014, they're selling 4k tickets, not even your mother would identify you in the crowd [15:21:36] in which channel does bugs to page curation ends up in? [15:22:04] Nemo_bis: so no 1080p tickets? [15:22:47] AzaToth: I think #wikimedia-overflow [15:22:57] Nemo_bis: only? [15:22:58] or ##trash if you have problems joining that [15:23:10] (I'm answering about PageCuration) [15:24:07] Nemo_bis: so no one will notice bug reports to page curation on the irc? [15:24:52] I'm kidding, in case it wasn't clear, but yes, nobody touches that extension [15:25:40] I see [15:26:10] Nemo_bis: I want the Deletion tag log opened up to user scripts now! [15:26:25] (03PS1) 10Anomie: Fix wrong variable in ustring.lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145574 [15:26:54] (03CR) 10Jackmcbarn: Improve error messages in mw.html (033 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145547 (owner: 10Mr. Stradivarius) [15:27:09] jackmcbarn: https://gerrit.wikimedia.org/r/145574 [15:28:11] jackmcbarn: more seriously speaking, we regularly have unregistered users and banned editors show up at meetups, you don't need to lose any (pseudo|ano)nimity; of course there are other valid reasons not to show up in person. :) [15:28:34] i know, i'd still just rather not [15:29:13] (03CR) 10Hoo man: [C: 04-1] "Not entirely sure about how to improve this... maybe use string configuration switches instead of booleans." (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145547 (owner: 10Mr. Stradivarius) [15:29:18] No prob. [15:29:26] we're glad to have you. :) [15:30:13] * sumanah is glad her community includes people with diverse interests and attitudes towards sharing themselves [15:31:15] (03CR) 10Jackmcbarn: [C: 031] "Tested, seems to work" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145574 (owner: 10Anomie) [15:33:30] (03CR) 10Anomie: Make the cssEncode pattern simpler (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145414 (owner: 10Jackmcbarn) [15:34:10] anomie: when i monkeypatch both of your ustring changes in on enwiki, if we consider string to take essentially no time, pure-lua ustring takes about 2-3 seconds, and mw.ustring takes about 6, so pure-lua does come out ahead [15:34:44] jackmcbarn: With which test cases? [15:35:09] anomie: [[Module talk:Sandbox/Jackmcbarn]] [15:35:26] my rough estimate without actually checking is that it's probably somewhere around 25,000 calls total [15:37:13] @link [15:37:13] https://www.mediawiki.org/wiki/Module_talk:Sandbox/Jackmcbarn [15:38:01] actually, it's 59236 calls [15:38:11] (i was within an order of magnitude at least) [15:41:04] (03PS2) 10Jackmcbarn: Make the cssEncode pattern simpler [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145414 [15:52:54] (03PS1) 10Paladox: Update getid3 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145575 [15:53:30] (03PS2) 10Paladox: Update getid3 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145575 [15:56:45] (03CR) 10Paladox: [C: 031] Update getid3 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145575 (owner: 10Paladox) [15:56:48] (03CR) 10Paladox: Update getid3 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145575 (owner: 10Paladox) [15:57:32] (03PS1) 10Manybubbles: Only ask for file_text in the file namespaces [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/145577 [15:58:14] (03CR) 10MarkTraceur: "1. Why?" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145575 (owner: 10Paladox) [15:59:00] (03PS14) 10Paladox: Update jQuery Cookie to v1.2.0 [core] - 10https://gerrit.wikimedia.org/r/145000 [15:59:42] (03PS15) 10Paladox: Update jquery.validate from 1.8.1 to 1.9.0 [core] - 10https://gerrit.wikimedia.org/r/145311 [16:00:01] 3MediaWiki extensions / 3Cite: Cite: Missing causes malformed rendering without showing an error - 10https://bugzilla.wikimedia.org/67845 (10James Forrester) p:5Unprio>3Normal [16:00:47] 3MediaWiki extensions / 3Cite: Cite: Error message for an empty reference should be more appropriate and helpful - 10https://bugzilla.wikimedia.org/57619 (10James Forrester) [16:00:48] 3MediaWiki extensions / 3Cite: Cite: If there's no block on the page, show one automatically below the content rather than showing an error - 10https://bugzilla.wikimedia.org/66860 (10James Forrester) [16:01:57] (03PS1) 10Alex Monk: Provide a generic getGlobalBlockingDatabase function [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/145578 [16:02:02] (03CR) 10Paladox: "Well I haven't verified if it broke anything but it is from the official source." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145575 (owner: 10Paladox) [16:03:09] (03PS17) 10Paladox: Update jquery.ui-themes [core] - 10https://gerrit.wikimedia.org/r/145049 [16:03:43] (03PS3) 10BryanDavis: Update installer image for Wikimania 2014 [vagrant] - 10https://gerrit.wikimedia.org/r/144413 [16:04:03] (03CR) 10Mormegil: "This change broke all inline coordinates on cswiki (until I fixed the template) because of a small wikitext interpretation change. Formerl" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113518 (https://bugzilla.wikimedia.org/35628) (owner: 10Brian Wolff) [16:05:47] 3MediaWiki extensions / 3Cite: Cite: If there's no block on the page for grouped references, references - 10https://bugzilla.wikimedia.org/67847#c1 (10James Forrester) Maybe grouped references should "fall through", so if you have 3 s and 4 s and a simple (... [16:06:00] (03PS25) 10EBernhardson: Enable Topic namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143186 [16:07:11] (03CR) 10MarkTraceur: "That answers...neither of my questions." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145575 (owner: 10Paladox) [16:08:12] (03Abandoned) 10EBernhardson: Don't html encode lightncandy sub-expressions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145142 (owner: 10EBernhardson) [16:09:02] 3MediaWiki / 3User preferences: One-click system for setting user preferences - 10https://bugzilla.wikimedia.org/67846#c1 (10WhatamIdoing) Thanks for filing this. I should note that what would be most functional is a system that lets me post a link (meaning a wikilink or a URL) that represents the command.... [16:09:21] (03CR) 10Paladox: "Ok." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145575 (owner: 10Paladox) [16:10:28] (03CR) 10Paladox: "For your first quest the answer is because the current one we have is from a year ago so I thought we could upgrade to a newer one. and yo" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145575 (owner: 10Paladox) [16:10:59] (03CR) 10MarkTraceur: [C: 04-1] "Committer appears to be making random changes for no reason, -1 until there is a reason" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145575 (owner: 10Paladox) [16:12:04] (03CR) 10MarkTraceur: ""because it's old" is not a good reason to make a change - if you need a feature from a later version, or there are security updates in th" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145575 (owner: 10Paladox) [16:12:46] 3MediaWiki extensions / 3Cite: Cite: If there's no block on the page for grouped references, references - 10https://bugzilla.wikimedia.org/67847 (10James Forrester) [16:13:02] 3MediaWiki extensions / 3Cite: Cite: If there's no block on the page, show one automatically below the content rather than showing an error - 10https://bugzilla.wikimedia.org/66860 (10James Forrester) [16:13:02] 3MediaWiki extensions / 3Cite: Cite: If there's no block on the page for grouped references, references - 10https://bugzilla.wikimedia.org/67847 (10James Forrester) p:5Unprio>3Normal [16:22:27] (03PS4) 10BryanDavis: Update installer image for Wikimania 2014 [vagrant] - 10https://gerrit.wikimedia.org/r/144413 [16:23:39] (03CR) 10Isarra: "Could anyone familiar with C-style programming maybe take a look at this and see if they can address YuviPanda's concern?" [core] - 10https://gerrit.wikimedia.org/r/108045 (owner: 10Jack Phoenix) [16:28:08] (03PS2) 10MarkTraceur: Fix some progress bar issues [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/145428 [16:30:01] has there been any movement on support for {{PLURAL:$1|0=xxx|1=yyy|2=zzz|abc}} from mw.msg (javascript) ? [16:30:13] i.e. was it attempted and too difficult, or never considered, or ? [16:30:30] * marktraceur looks at aharoni, Nikerabbit [16:30:53] ebernhardson: I think they're trying to write a service for i18n on the frontend, fwiw [16:31:38] marktraceur: hmm, essentially sending messages to the backend for compilation? i suppose its not a big deal how, just trying to decide if we should convince product to change messaging, or what to update the messages to [16:32:07] if something is on its way i can probably just leave them as is [16:32:33] we pretty much already did, and it *kinda* has feature parity with the PHP side, but it's not perfect [16:32:53] isn't it done already? [16:33:04] what's missing/not working? [16:33:26] hmm, is it? i'm seeing some errors related to it locally(the 0= is included in output message) but i dont update core often enough, lemme try [16:33:38] Nikerabbit: does jquerymsg or jquery.i18n support {{PLURAL:$1|0=xxx|1=yyy|2=zzz|abc}} [16:33:42] ? [16:33:52] ebernhardson: definitely not with mw.msg itself [16:34:14] aharoni: jquerymsg should, jquery.i18n perhaps not [16:34:28] if they don't, that's definitely an omission and should be on our roadmap [16:34:29] * ebernhardson didn't know there were two implementations :) [16:34:30] thats good to know [16:34:35] 3MediaWiki extensions / 3ApiSandbox: ApiSandbox: no generator params are added for non-query actions - 10https://bugzilla.wikimedia.org/67861 (10db) 3NEW p:3Unprio s:3normal a:3None Go to Special:ApiSandbox, select a action with generator like setnotificationtimestamp. Choose a generator like backlin... [16:34:40] ebernhardson: jquery.i18n is not inside core [16:34:44] ahh [16:34:50] ebernhardson: where would you expect such an information to be? [16:34:53] it's used mainly by ULS [16:34:54] but with mw.message and with the mediawiki.jqueryMsg RL module it will likely work [16:35:07] [08:21:36 AM] in which channel does bugs to page curation ends up in? <-- -corefeatures I'm guessing. [16:35:16] (i.e. where should it have been for you to know; so that I can check it's there) [16:35:29] legoktm: if yes sounds like a bug [16:35:52] Nemo_bis: about two implementations? not sure, i suppose https://www.mediawiki.org/wiki/Manual:Messages_API#Using_messages_in_JavaScript [16:36:33] Nemo_bis: it mentiones plural in javascript, but not with the 0=, 1=, etc prefixes [16:36:46] that's documented in [[translatewiki:Plural]] [16:37:03] the mw.o page documents the interface ratehr than the syntax [16:37:21] because the syntax is needed for translators too... no idea how to split correctly [16:37:46] 3MediaWiki-Vagrant: Commands list-roles, enable-role, etc do not work on Vagrant 1.6.x - 10https://bugzilla.wikimedia.org/65066#c9 (10Bryan Davis) 5PATC>3RESO/FIX Thanks to Dan's hard work we now have the plugin packaged properly, a script to automate updating it in the user's Vagrant and a guard in the Va... [16:38:40] (03PS1) 10Gilles: Load most of TMH and its dependencies on demand [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145583 [16:39:09] (03PS1) 10Gilles: Load most of TMH and its dependencies on demand [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/145584 [16:39:21] Nemo_bis: well, given that no one cares about the extension anyways... [16:39:29] (03CR) 10Gilles: "Depends on https://gerrit.wikimedia.org/r/#/c/145583/" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/145584 (owner: 10Gilles) [16:40:06] legoktm: sure, just send it to #wikimedia-overflow as I said then ;) [16:40:15] lolol [16:40:21] (03CR) 10Aude: "evil is evil (and they are broken), so we shouldn't care." [core] - 10https://gerrit.wikimedia.org/r/143207 (owner: 10Withoutaname) [16:45:02] (03PS2) 10Hoo man: Remove MWInit class file Init.php [core] - 10https://gerrit.wikimedia.org/r/143207 (owner: 10Withoutaname) [16:45:02] 3MediaWiki extensions / 3Cite: Cite: If there's no block on the page for grouped references, show one automatically below the content rather than showing an error - 10https://bugzilla.wikimedia.org/67847#c2 (10Alex Monk) (reverting summary change - looks like something got cut off there James... [16:45:27] (03CR) 10Hoo man: "Rebased (RELEASE-NOTES-1.24 conflicted)" [core] - 10https://gerrit.wikimedia.org/r/143207 (owner: 10Withoutaname) [16:46:01] (03CR) 10Hoo man: [C: 032] "No (useful) usage left" [core] - 10https://gerrit.wikimedia.org/r/143207 (owner: 10Withoutaname) [16:46:52] writing to the stdin pipe of a process opened with proc_open(), is there a way an attacker could make the process exit? [16:48:59] RoanKattouw: this just happened: (PS1) Gilles: Load most of TMH and its dependencies on demand [extensions/MwEmbedSupport] - https://gerrit.wikimedia.org/r/145584 [16:39:09] [16:49:03] * ori does a little dance [16:49:48] (03Merged) 10jenkins-bot: Remove MWInit class file Init.php [core] - 10https://gerrit.wikimedia.org/r/143207 (owner: 10Withoutaname) [16:51:32] (03CR) 10Bartosz Dziewoński: "There's probably a bug for this somewhere?" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145583 (owner: 10Gilles) [16:51:50] rillke: kill -9? [16:52:30] (03PS1) 10Anomie: Fix getProfilerFunctionReport [php/luasandbox] - 10https://gerrit.wikimedia.org/r/145586 [16:52:32] (03CR) 10Krinkle: [C: 04-1] OutputPage: Support foreign module sources in makeResourceLoaderLink (034 comments) [core] - 10https://gerrit.wikimedia.org/r/142766 (owner: 10Legoktm) [16:52:44] (03CR) 10Krinkle: [C: 031] Add OutputPageScriptsForBottomQueue hook [core] - 10https://gerrit.wikimedia.org/r/141282 (https://bugzilla.wikimedia.org/62602) (owner: 10Legoktm) [16:53:04] <^d> ori: I lowered the uncompressed CSS payload on special pages by like 2kb yay me :) [16:53:59] (03CR) 10Krinkle: [C: 04-1] Use new OutputPageScriptsForBottomQueue hook (031 comment) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/141284 (https://bugzilla.wikimedia.org/62602) (owner: 10Legoktm) [16:54:14] jackmcbarn: It looks like ustring.gsub is only being called with two patterns on that whole page. So what seems to be happening is that ustring.lua caches each parsed pattern, while the PHP implementation reparses it each of those 50000 times. If we add a similar cache to Scribunto_LuaUstringLibrary::patternToRegex(), the PHP version should be faster for your example. [16:54:23] Vulpix -- doesn't make it exit. Is there a way sending Ctrl+C somehow? [16:54:49] (as a request argument) [16:55:02] (03CR) 10tosfos: "Cool. Should make life easier." [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/145516 (owner: 10Florianschmidtwelzow) [16:55:02] 3MediaWiki extensions / 3Translate: Special page for migration of legacy translation pages (tracking) - 10https://bugzilla.wikimedia.org/65740 (10Helder) [16:55:04] 3MediaWiki extensions / 3Translate: [[Special:PageMigration]] needs some description - 10https://bugzilla.wikimedia.org/67864 (10Helder) 3NEW p:3Unprio s:3normal a:3Pratik Lahoti Currently https://www.mediawiki.org/wiki/Special:PageMigration shows only a pair of input fields and a button with no expl... [16:55:13] (03CR) 10Anomie: [C: 032] Make the cssEncode pattern simpler [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145414 (owner: 10Jackmcbarn) [16:55:25] no idea, sorry :( [16:55:36] 3MediaWiki extensions / 3TextExtracts: Better sentence handling needed - 10https://bugzilla.wikimedia.org/57669#c6 (10Max Semenik) *** Bug 67841 has been marked as a duplicate of this bug. *** [16:55:36] 3MediaWiki extensions / 3TextExtracts: Hovercards: Punctuation within title should not count for terminating the extract - 10https://bugzilla.wikimedia.org/67841#c1 (10Max Semenik) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 57669 *** [16:55:49] (03CR) 10Gilles: [C: 032] Fix some progress bar issues [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/145428 (owner: 10MarkTraceur) [16:55:52] (03CR) 10Krinkle: "(remove myself from reviewer list, I don't maintain this extension)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145575 (owner: 10Paladox) [16:56:04] (03CR) 10Krinkle: "(remove myself from reviewer list, I don't maintain this extension)" [extensions/OggHandler] - 10https://gerrit.wikimedia.org/r/145562 (owner: 10Paladox) [16:56:13] (03Merged) 10jenkins-bot: Fix some progress bar issues [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/145428 (owner: 10MarkTraceur) [16:57:06] (03CR) 10Legoktm: Use new OutputPageScriptsForBottomQueue hook (031 comment) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/141284 (https://bugzilla.wikimedia.org/62602) (owner: 10Legoktm) [16:57:20] (03Merged) 10jenkins-bot: Make the cssEncode pattern simpler [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145414 (owner: 10Jackmcbarn) [16:57:31] 3MediaWiki skins / 3Vector: Default icon in vector for "profile" in personal tools should be gender neutral and fit with other site icons look & feel - 10https://bugzilla.wikimedia.org/41484#c56 (10Jared Zimmerman (WMF)) Nemo, bugs shouldn't neccesarily express a solution, the problem here is "icon represent... [16:57:55] (03PS2) 10Chad: Add subcommand to easily import a wiki dump [vagrant] - 10https://gerrit.wikimedia.org/r/145477 [16:58:29] (03CR) 10Chad: Add subcommand to easily import a wiki dump (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/145477 (owner: 10Chad) [16:59:47] (03CR) 10Cscott: "Where the differences are (1) cosmetic and irrelevant to rendering, we should probably keep only one clause, and strengthen the normalizer" [core] - 10https://gerrit.wikimedia.org/r/133957 (owner: 10Cscott) [17:01:03] (03CR) 10Anomie: HHVM compatibility (031 comment) [php/luasandbox] - 10https://gerrit.wikimedia.org/r/129100 (owner: 10Tim Starling) [17:01:49] 3MediaWiki extensions / 3Translate: Translate extension uses misleading summary saying a page was created when it wasn't - 10https://bugzilla.wikimedia.org/67865 (10Helder) 3NEW p:3Unprio s:3normal a:3None The edit https://www.mediawiki.org/w/index.php?diff=1063082&oldid=1063080 has the summary 'Crea... [17:02:23] (03PS2) 10Gilles: Load most of TMH and its dependencies on demand [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/145584 (https://bugzilla.wikimedia.org/55550) [17:02:59] (03PS2) 10Gilles: Load most of TMH and its dependencies on demand [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145583 (https://bugzilla.wikimedia.org/55550) [17:04:19] 3Wikimedia / 3Git/Gerrit: Gerrit: Auto-linking for urls should not include trailing full stop (breaking urls, 404 Error) - 10https://bugzilla.wikimedia.org/67866 (10Krinkle) 3NEW p:3Unprio s:3major a:3None It seems Gerrit is consistently including the dot after a url in the url causing loads of links... [17:04:32] Vulpix - https://github.com/Rillke/stylize/blob/master/jsonapi.php#L82 [17:07:33] hi manybubbles [17:08:27] rillke: are you sure kill -9 doesn't kill it? At least it worked for me everytime I have to use it [17:10:17] 3MediaWiki-Vagrant: can't run Selenium tests on Windows - 10https://bugzilla.wikimedia.org/51882#c4 (10Dan Duvall) I don't think this particular case is worth reproducing, given that the use of NoWindows is no longer mentioned on the wiki as a via option for Windows users (the link provided is dead). However,... [17:10:31] Vulpix, it's for http://tools.wmflabs.org/stylize/ [17:11:07] I want to use the std-pipe to avoid creating temporary files [17:11:45] on jquery.i18n, filed https://github.com/wikimedia/jquery.i18n/issues/62 [17:11:59] In L89 https://github.com/Rillke/stylize/blob/master/jsonapi.php#L89 the request args are written into stdin [17:14:16] rillke: but why do you want to make it exit? Doesn't exit itself when you end feeding data? [17:15:31] Vulpix, I am just wonding whether someone could make it exit or do other evil stuff with it. [17:15:36] (03PS2) 10Bsitu: Fix WrongNumberArgumentsException [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145538 (owner: 10Matthias Mullie) [17:16:14] (03PS16) 10Jdlrobson: mw-ui-button: Revamp the LESS to be simpler, and improve cross-browser support [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [17:16:17] 3MediaWiki skins / 3Vector: Default icon in vector for "profile" in personal tools should be gender neutral and fit with other site icons look & feel - 10https://bugzilla.wikimedia.org/41484#c57 (10Nemo) The problem in this bug is very well defined and it has nothing to do with your proposed solution. Your p... [17:16:36] (03CR) 10Jdlrobson: mw-ui-button: Revamp the LESS to be simpler, and improve cross-browser support (033 comments) [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [17:17:05] Vulpix - I'll write to wikitech-l -- either something will explode ... or not [17:17:53] (03CR) 10Jdlrobson: mw-ui-button: Revamp the LESS to be simpler, and improve cross-browser support (031 comment) [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [17:19:13] rillke: okay. the only thing it comes to my mind is a piece of input that may cause js-beautify to explode, executing arbitrary code, if js-beautify is vulnerable to some input like this [17:19:42] thanks, Vulpix [17:20:18] (03CR) 10Bsitu: [C: 032] Fix WrongNumberArgumentsException [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145538 (owner: 10Matthias Mullie) [17:20:45] (03Merged) 10jenkins-bot: Fix WrongNumberArgumentsException [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145538 (owner: 10Matthias Mullie) [17:20:49] (03PS16) 10Paladox: Update jquery.validate from 1.8.1 to 1.9.0 [core] - 10https://gerrit.wikimedia.org/r/145311 [17:20:51] (03CR) 10MaxSem: [C: 032] Adding new format strings for OCG [extensions/Collection] - 10https://gerrit.wikimedia.org/r/139201 (owner: 10Mwalker) [17:20:55] (03CR) 10Legoktm: OutputPage: Support foreign module sources in makeResourceLoaderLink (033 comments) [core] - 10https://gerrit.wikimedia.org/r/142766 (owner: 10Legoktm) [17:20:58] (03PS13) 10Legoktm: OutputPage: Support foreign module sources in makeResourceLoaderLink [core] - 10https://gerrit.wikimedia.org/r/142766 [17:21:29] (03CR) 10Aaron Schulz: [C: 032] Tolerate server addresses w/o a port number [services/jobrunner] - 10https://gerrit.wikimedia.org/r/145508 (owner: 10Ori.livneh) [17:21:38] (03CR) 10Aaron Schulz: [V: 032] Tolerate server addresses w/o a port number [services/jobrunner] - 10https://gerrit.wikimedia.org/r/145508 (owner: 10Ori.livneh) [17:22:24] (03Merged) 10jenkins-bot: Adding new format strings for OCG [extensions/Collection] - 10https://gerrit.wikimedia.org/r/139201 (owner: 10Mwalker) [17:23:31] 3MediaWiki extensions / 3Translate: Translate extension uses misleading summary saying a page was created when it wasn't - 10https://bugzilla.wikimedia.org/67865#c1 (10Siebrand Mazeland) Pretty certain this is a dupe. It's related to a logging issue. [17:24:31] 3MediaWiki skins / 3Vector: Default icon in vector for "profile" in personal tools should be gender neutral and fit with other site icons look & feel - 10https://bugzilla.wikimedia.org/41484#c58 (10Jared Zimmerman (WMF)) I don't know what "personal toolbar personalises" means, can you explain/clarify? [17:25:14] (03CR) 10Jdlrobson: "Not when you consider MediaWiki core which is where we would plan to upstream this. This would break a lot of existing forms, and forms ar" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144166 (owner: 10Jdlrobson) [17:25:22] (03PS2) 10Bsitu: Fix diff view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145539 (owner: 10Matthias Mullie) [17:25:24] greg-g, ping -- see my email from 20 mins ago ref deployments meeting [17:26:33] 3MediaWiki skins / 3Vector: Default icon in vector for "profile" in personal tools should be gender neutral and fit with other site icons look & feel - 10https://bugzilla.wikimedia.org/41484#c59 (10Steven Walling) (In reply to Nemo from comment #57) > The problem in this bug is very well defined and it has n... [17:26:41] (03CR) 10Bsitu: [C: 032] Fix diff view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145539 (owner: 10Matthias Mullie) [17:26:46] 3MediaWiki-Vagrant: can't run Selenium tests on Windows - 10https://bugzilla.wikimedia.org/51882#c5 (10Bryan Davis) (In reply to Dan Duvall from comment #4) > The absolute easier setup I can think of would be to install xvfb and run > the tests in headless mode. Adding a properly setup xvfb to the basic Vagra... [17:27:09] (03Merged) 10jenkins-bot: Fix diff view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145539 (owner: 10Matthias Mullie) [17:29:18] Deskana, Eloquence can you please ask greg-g to invite quimgil@gmail.com to the deployments hangout, please? [17:29:39] Krinkle: I updated the core patch, and left a question for you on https://gerrit.wikimedia.org/r/#/c/141284/, I'm not sure how much you want me to change [17:29:50] Everything :P [17:30:20] lol [17:30:24] ok [17:30:54] so we should be loading the ext.globalCssJs.user module for everyone, just make the contents of it change depending on the &user= parameter? [17:31:11] (03CR) 10Aaron Schulz: [C: 032] Removes deprecated $wgUseCommaCount variable [core] - 10https://gerrit.wikimedia.org/r/139842 (https://bugzilla.wikimedia.org/60454) (owner: 10Rohan013) [17:31:41] (03CR) 10Krinkle: Use new OutputPageScriptsForBottomQueue hook (031 comment) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/141284 (https://bugzilla.wikimedia.org/62602) (owner: 10Legoktm) [17:31:49] 3MediaWiki-Vagrant: Cleanup the vagrant::settings define - 10https://bugzilla.wikimedia.org/67867 (10Bryan Davis) 3NEW p:3Unprio s:3minor a:3Ori Livneh Changes in the mediawiki-plugin have made some of the options for the vagrant::settings define obsolete (box_name, box_uri, puppet_debug). [17:32:00] * legoktm does [17:32:03] (03CR) 10Jdlrobson: "We could however make mw-ui-input global with these changes..." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144166 (owner: 10Jdlrobson) [17:32:16] 3MediaWiki-Vagrant: Cleanup the vagrant::settings define - 10https://bugzilla.wikimedia.org/67867 (10Bryan Davis) p:5Unprio>3Low [17:34:29] tfinc, can you ask greg-g to invite quimgil@gmail.com to the current deployments meeting, please? [17:34:37] meh :( [17:34:46] (03Merged) 10jenkins-bot: Removes deprecated $wgUseCommaCount variable [core] - 10https://gerrit.wikimedia.org/r/139842 (https://bugzilla.wikimedia.org/60454) (owner: 10Rohan013) [17:35:19] qgil: done [17:35:26] thanks! [17:36:49] tfinc, greg-g "You're not allowed to join this video call." , I guess it works adding me from the hangout itself. Sorry for the hassle. [17:39:34] 3MediaWiki extensions / 3CirrusSearch: "Ignoring nonexistent page" that does exist - 10https://bugzilla.wikimedia.org/67869 (10Chad H.) 3NEW p:3Unprio s:3normal a:3None svwiki has a bunch of these in the logs right now. All of the pages begin with "Gladiolus..." which is weird. Need to run this down. [17:45:11] (03PS4) 10Legoktm: Use new OutputPageScriptsForBottomQueue hook [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/141284 (https://bugzilla.wikimedia.org/62602) [17:45:40] (03CR) 10Legoktm: Use new OutputPageScriptsForBottomQueue hook (031 comment) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/141284 (https://bugzilla.wikimedia.org/62602) (owner: 10Legoktm) [17:45:52] Krinkle: updated ^ [17:48:09] (03CR) 10Aaron Schulz: [C: 032] Fix wrong variable in ustring.lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145574 (owner: 10Anomie) [17:48:45] (03CR) 10Bsitu: [C: 032] Enable Topic namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143186 (owner: 10EBernhardson) [17:49:16] (03Merged) 10jenkins-bot: Enable Topic namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143186 (owner: 10EBernhardson) [17:50:03] (03Merged) 10jenkins-bot: Fix wrong variable in ustring.lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145574 (owner: 10Anomie) [17:50:28] (03CR) 10Cscott: "Whew! This is a rather massive patch." (0317 comments) [core] - 10https://gerrit.wikimedia.org/r/133957 (owner: 10Cscott) [17:50:36] (03CR) 10Chad: [C: 032] Made getMaxLag() skip checking the master DB [core] - 10https://gerrit.wikimedia.org/r/145045 (owner: 10Aaron Schulz) [17:51:17] ecmabot-wm: source [17:51:17] Krinkle: Pop the hood, check out https://github.com/Krinkle/oftn-bot/tree/ecmabot-wm [17:51:23] >> Math.round(2.13) [17:51:24] Krinkle: (number) 2 [17:51:28] Danny_B: ^ [17:51:42] (03CR) 10Chad: [C: 032] Only ask for file_text in the file namespaces [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/145577 (owner: 10Manybubbles) [17:52:00] (03Merged) 10jenkins-bot: Only ask for file_text in the file namespaces [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/145577 (owner: 10Manybubbles) [17:52:17] >> (function fact(n) { return n ? n*fact(n-1) : 1; })(5) [17:52:17] cscott: (number) 120 [17:52:27] >> (function fact(n) { return n ? n*fact(n-1) : 1; })(55) [17:52:27] cscott: (number) 1.2696403353658276e+73 [17:52:55] Krinkle: dank vermogen [17:53:15] Danny_B: thank capacity? [17:53:32] >> [1,2,3,4,5,6,7,8,9,10].map(function fib(n) { return n>2 ? fib(n-1)+fib(n-2) : 1; }) [17:53:32] cscott: (object) [1, 1, 2, 3, 5, 8, 13, 21, 34, 55] [17:53:39] (03CR) 10BryanDavis: [C: 032] Add subcommand to easily import a wiki dump [vagrant] - 10https://gerrit.wikimedia.org/r/145477 (owner: 10Chad) [17:53:57] (function fib(n) { return n>2 ? fib(n-1)+fib(n-2) : 1; })(55) [17:54:01] (03PS16) 10Bsitu: Flow topic reply notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144832 [17:54:11] (03Merged) 10jenkins-bot: Add subcommand to easily import a wiki dump [vagrant] - 10https://gerrit.wikimedia.org/r/145477 (owner: 10Chad) [17:54:12] cscott: trying to break our tools? ;-) [17:54:13] (03CR) 10Raimond Spekking: Adding new format strings for OCG (031 comment) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/139201 (owner: 10Mwalker) [17:54:19] cscott: four seconds timeout, iirc. [17:54:26] (03Merged) 10jenkins-bot: Made getMaxLag() skip checking the master DB [core] - 10https://gerrit.wikimedia.org/r/145045 (owner: 10Aaron Schulz) [17:54:32] MatmaRex: i think it's been longer than 4 seconds [17:54:41] maybe it just doesn't reply. [17:54:41] >> 42 [17:54:42] MatmaRex: (number) 42 [17:54:42] >> "are you still there?" [17:54:43] cscott: (string) 'are you still there?' [17:54:51] i see, i'm getting the silent treatment [17:54:55] (03PS1) 10Pastakhov: fix Method Chaining (v 2.4.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/145597 [17:55:01] >> process.version [17:55:01] cscott: ReferenceError: process is not defined [17:55:10] >> navigator [17:55:11] cscott: ReferenceError: navigator is not defined [17:55:23] >> window [17:55:24] cscott: ReferenceError: window is not defined [17:55:24] cscott: plain v8 [17:55:34] >> Uint8Array(5) [17:55:34] cscott: ReferenceError: Uint8Array is not defined [17:55:39] (03CR) 10jenkins-bot: [V: 04-1] fix Method Chaining (v 2.4.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/145597 (owner: 10Pastakhov) [17:55:39] old v8 [17:55:51] aint nobody got time for that [17:56:04] :P [17:56:23] It's "safe" though. I dare you to persist state between commands or make it take up more resources than it should. [17:56:27] (please do) [17:56:31] >> 1/0 [17:56:31] Vulpix: (number) Infinity [17:56:33] 3MediaWiki extensions / 3Cite: Cite: If there's no block on the page for grouped references, maybe show them in some way - 10https://bugzilla.wikimedia.org/67847#c3 (10James Forrester) Sorry, name was meant to express the doubt about the way forward. :-) [17:56:35] you can experiment in ##krinkle privately [17:56:36] heh [17:56:42] ll [17:56:53] >> Array(10) [17:56:53] cscott: (object) [undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined] [17:56:59] >> Array(10000) [17:57:00] cscott: (object) [undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, … [17:57:11] >> Array(1<<24) [17:57:12] (03PS28) 10Bsitu: Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 [17:57:19] like a kid given new toy :> [17:57:21] it exploded [17:57:22] Krinkle: i win! [17:57:22] oooh. he broke it. [17:57:29] lolololol [17:58:22] >> (function fib(n) { return Math.round((Math.pow(1+Math.sqrt(5),n)-Math.pow(1-Math.sqrt(5),n))/(Math.pow(2,n)*Math.sqrt(5))); })(55) [17:58:25] (03CR) 10Chad: [C: 032] Made getMaxLag() use caching to reduce connection spam [core] - 10https://gerrit.wikimedia.org/r/145382 (owner: 10Aaron Schulz) [17:58:49] oh, it already broke [17:58:52] jackmcbarn: a sufficiently clever optimizer would have generated your code from mine version. ;) [17:58:53] cscott: well, this is sort of by design [17:59:06] Krinkle: you did dare me [17:59:09] cscott: It quits before it goes foo far, but comes back within a minute [17:59:21] it's been over a minute [17:59:26] cscott: Your'e right though, the sandbox should restrict it on the inside, not outside. [17:59:42] (03PS2) 10Pastakhov: fix Method Chaining (v 2.4.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/145597 [17:59:44] cscott: Does Parsoid do anything special with Extension:ParserFunctions? [17:59:49] a minute, or however long labs takes to process the the grid! [18:00:15] anomie: it has a native implementation, but it's been turned off for a while. instead it hands it to php, and lets php do the computation. [18:00:42] when i was young and naive i spent a number of days working on improving parsoid's implementation of parserfunctions [18:01:04] cscott: Ok. Gerrit 113518 changed something, and looking into another bug I found Gerrit 87643 that I'd like to merge. [18:01:04] (03PS7) 10Bsitu: Log improvements. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145540 (owner: 10Matthias Mullie) [18:01:33] (03CR) 10Pastakhov: [C: 032] fix Method Chaining (v 2.4.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/145597 (owner: 10Pastakhov) [18:01:39] (03Merged) 10jenkins-bot: fix Method Chaining (v 2.4.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/145597 (owner: 10Pastakhov) [18:02:03] anomie: parsoid should pick up the core behavior, since it delegates that stuff to core. [18:02:12] (03Merged) 10jenkins-bot: Made getMaxLag() use caching to reduce connection spam [core] - 10https://gerrit.wikimedia.org/r/145382 (owner: 10Aaron Schulz) [18:03:16] (03CR) 10MaxSem: [C: 032] Add new messages for article and image attribution [extensions/Collection] - 10https://gerrit.wikimedia.org/r/145192 (owner: 10Mwalker) [18:03:19] (03CR) 10jenkins-bot: [V: 04-1] Add new messages for article and image attribution [extensions/Collection] - 10https://gerrit.wikimedia.org/r/145192 (owner: 10Mwalker) [18:03:34] >> (function fib(n) { return Math.round(Math.pow((1+Math.sqrt(5))/2,n)/Math.sqrt(5)); })(55) [18:03:35] jackmcbarn: (number) 139583862445 [18:04:51] whaaa? we have a js interpreter in the channel?! [18:05:05] 3MediaWiki extensions / 3Translate: PythonSingleFFS fails under HHVM - 10https://bugzilla.wikimedia.org/67870 (10Niklas Laxström) 3NEW p:3Unprio s:3normal a:3None It doesn't seem to be related to any memory / time limits. The output of the script is just truncated. It works when run under php. (php b... [18:05:06] mwalker: since october 2013 [18:06:15] The day it's actually cool to execute php from irc and possible to easily sandbox it, maybe someone will build one for that too :P [18:06:22] (03PS3) 10Anomie: Fix #switch #default to match next (not last) named parameter. [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/87643 (https://bugzilla.wikimedia.org/23192) (owner: 10Lambdafu) [18:06:31] what was the need? [18:06:37] (03CR) 10Anomie: [C: 032] "Rebased." [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/87643 (https://bugzilla.wikimedia.org/23192) (owner: 10Lambdafu) [18:06:43] (03Merged) 10jenkins-bot: Fix #switch #default to match next (not last) named parameter. [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/87643 (https://bugzilla.wikimedia.org/23192) (owner: 10Lambdafu) [18:06:47] just to show people how a statement works? [18:07:21] mostly used in other channels (visualeditor, parsoid), but can be useful to explain something or try something that is intended to share with others [18:08:01] 3Wikimedia / 3Git/Gerrit: Gerrit: Auto-linking for urls should not include trailing full stop (breaking urls, 404 Error) - 10https://bugzilla.wikimedia.org/67866#c1 (10Andre Klapper) I have no idea where exactly the given example links expose the problem. [18:08:32] 3MediaWiki extensions / 3ParserFunctions: #default without value causes switch to default to last argument - 10https://bugzilla.wikimedia.org/23192#c4 (10Brad Jorsch) 5PATC>3RESO/FIX This should be deployed to WMF wikis with 1.24wmf14, see https://www.mediawiki.org/wiki/MediaWiki_1.24/Roadmap for the sch... [18:09:07] mwalker: It's normally "Look, this is why you code doesn't work – this fragment does something else than what you think it does." [18:11:22] (03CR) 10Helder.wiki: "I assume this change is supposed to allow showing the chapter list even if $wgBookManagerv2PrevNext is false. Is that correct?" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/140071 (owner: 10Deepali) [18:11:49] (03CR) 10Mattflaschen: [C: 04-1] "Although it's acceptable to change the behavior of $.cookie( 'key', undefined ) since it wasn't documented (https://github.com/carhartl/jq" [core] - 10https://gerrit.wikimedia.org/r/145000 (owner: 10Paladox) [18:13:34] 3MediaWiki extensions / 3ParserFunctions: #switch treats any case beginning with "#default" as the default case - 10https://bugzilla.wikimedia.org/67871 (10Brad Jorsch) 3NEW p:3Unprio s:3normal a:3None For example, "{{#switch:x|#defaultWTF? = This is crazy}}" returns "This is crazy". [18:15:12] (03PS1) 10Anomie: switch should not match #default as a prefix [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/145600 (https://bugzilla.wikimedia.org/67871) [18:16:12] (03PS2) 10Anomie: #switch should not match #default as a prefix [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/145600 (https://bugzilla.wikimedia.org/67871) [18:19:09] >> %MathLog(100) [18:19:09] cscott: SyntaxError: Unexpected token % [18:19:18] >> nat.MathLog(100) [18:19:18] cscott: ReferenceError: nat is not defined [18:19:29] aw, no v8 natives. Krinkle you're no fun. [18:19:49] >> Promise [18:19:50] cscott: ReferenceError: Promise is not defined [18:20:15] not even es6? bah. [18:20:25] >> require('es6-shim'); [18:20:26] mwalker: ReferenceError: require is not defined [18:20:38] :'( [18:20:59] >> Object.create(null) [18:20:59] cscott: (object) {} [18:21:05] well, at least it's es5 [18:21:32] 3Wikimedia / 3SSL related: Enable HSTS on Wikimedia wikis - 10https://bugzilla.wikimedia.org/38516#c32 (10Daniel Zahn) Just enabled it on OTRS a minute ago. 11:21 < mutante> !log OTRS - enabled STS, updated SSL cipher list, restarted Apache on iodine [18:21:48] >> var foo = "bar"; [18:21:48] mwalker: undefined [18:21:55] >> console.info(foo); [18:21:55] mwalker: ReferenceError: foo is not defined [18:21:58] >> Object.freeze({}) [18:21:58] cscott: (object) {} [18:22:17] >> Math.TAU = 2*Math.PI [18:22:18] cscott: (number) 6.283185307179586 [18:22:20] >> Math.TAU [18:22:21] cscott: undefined [18:22:36] >> JSON.stringify({a:1}); [18:22:36] Vulpix: (string) '{"a":1}' [18:22:38] "use strict"; [18:22:43] >> "use strict"; [18:22:49] cscott: (string) 'use strict' [18:23:18] >> {default: true} [18:23:18] cscott: SyntaxError: Unexpected token default [18:23:19] 3MediaWiki extensions / 3BookManagerv2: Replace .size() by .length in modules/ext.BookManagerv2.editor.js - 10https://bugzilla.wikimedia.org/67872 (10Helder) 3NEW p:3Unprio s:3enhanc a:3None It is best practice to use length instead of size(). See e.g.: https://gerrit.wikimedia.org/r/#/c/10742/1/mod... [18:23:37] >> Math.default = true; [18:23:37] cscott: (boolean) true [18:23:58] >> ({ if: 1 }) [18:23:59] cscott: (object) {if: 1} [18:24:06] >> ({ default: true }) [18:24:07] cscott: (object) {default: true} [18:24:57] >> (function() { "use strict"; return !this; })() [18:24:57] cscott: (boolean) true [18:25:03] >> this [18:25:04] cscott: (object) {} [18:25:11] >> this.foo = 1 [18:25:11] cscott: (number) 1 [18:25:14] >> this.foo [18:25:14] cscott: undefined [18:25:21] * cscott shakes fist [18:25:48] (03PS4) 10Jdlrobson: WIP: Replace flow-ui- classes with mw-ui- classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144164 [18:25:54] (03CR) 10jenkins-bot: [V: 04-1] WIP: Replace flow-ui- classes with mw-ui- classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144164 (owner: 10Jdlrobson) [18:26:32] (03PS3) 10Helder.wiki: Add message documentation for newly added messages [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/144267 (https://bugzilla.wikimedia.org/66789) (owner: 10Deepali) [18:26:46] >> Error.stackTraceLimit [18:26:46] cscott: (number) 10 [18:26:52] >> throw new Error('yo') [18:26:53] cscott: Error: yo [18:27:15] (03PS1) 10Aaron Schulz: Put more spammy messages behind debug() [services/jobrunner] - 10https://gerrit.wikimedia.org/r/145602 [18:27:53] >> e = new Error(); Error.captureStackTrace(e); e.stack; [18:27:53] cscott: (string) 'Error\n at irc:1:25\n at Sandbox.execute (/data/project/ecmabot/apps/oftn-bot/lib/sandbox/v8/shovel.js:61:13)\n at Object.exports.run (evalmachine.:320:12)\n at Sandbox.run (/data/project/ecmabot/apps/oftn-bot/lib/sandbox/v8/shovel.js:50:39)\n at Socket.Sandbox.load_input (/data/project/ecmabot/apps/oftn-bot/lib/sandbox/v8/shovel.js:30… [18:28:02] mmm, tasty [18:29:23] >> Error.foo = 4 [18:29:23] cscott: (number) 4 [18:29:25] >> Error.foo [18:29:26] cscott: undefined [18:29:45] (03CR) 10Helder.wiki: Show short title on subpages of a book (031 comment) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/144356 (owner: 10Deepali) [18:30:02] (03PS2) 10Phuedx: Test the .mw-ui-button-with-icon-bgimage mixin [core] - 10https://gerrit.wikimedia.org/r/144141 (https://bugzilla.wikimedia.org/55535) [18:30:04] (03PS8) 10Phuedx: Add icon support to .mw-ui-button [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) [18:30:06] (03PS2) 10Helder.wiki: Add variables to enable or disable parts of the extension [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/144266 (https://bugzilla.wikimedia.org/51844) (owner: 10Deepali) [18:30:52] (03PS3) 10Jdlrobson: Hygiene: Split out flow_post.handlebars [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145171 [18:31:33] (03CR) 10Jdlrobson: [C: 04-1] "Dependency should be merged first." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145031 (owner: 10Jdlrobson) [18:31:37] (03PS3) 10Helder.wiki: Same readability options on all chapters of the book [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/142555 (https://bugzilla.wikimedia.org/66957) (owner: 10Deepali) [18:31:47] (03CR) 10EBernhardson: [C: 032] "lgtm" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144832 (owner: 10Bsitu) [18:32:08] (03PS4) 10Helder.wiki: Show only subpage title in section list for sections without label [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/140694 (https://bugzilla.wikimedia.org/66788) (owner: 10Deepali) [18:32:12] (03PS3) 10Helder.wiki: Lager text-area for description field in metadata instead of textbox. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/140686 (https://bugzilla.wikimedia.org/65295) (owner: 10Deepali) [18:32:17] (03PS4) 10Helder.wiki: Implement full screen reading mode [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/141891 (https://bugzilla.wikimedia.org/65300) (owner: 10Deepali) [18:32:22] (03PS4) 10Helder.wiki: Implement options to format text to improve readability [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/141301 (https://bugzilla.wikimedia.org/65329) (owner: 10Deepali) [18:32:36] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Split out flow_post.handlebars [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145171 (owner: 10Jdlrobson) [18:33:05] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})() [18:33:06] cscott: (object) [{fun: function (function x(a,b,c){function d(e,f){d=…}, pos: 130, receiver: {}}, {fun: function () { if (typeof this.utils_global.glo…}, pos: 1423, receiver: {input_code: " (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})()", utils_file: '/data/project/ecmabot/apps/oftn-bot/ecmabot… [18:33:18] >> "WikiMedia".replace(/([A-Z][a-z]+)([A-Z][a-z]+)/, '$2$1') [18:33:18] Vulpix: (string) 'MediaWiki' [18:33:55] (03Merged) 10jenkins-bot: Flow topic reply notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144832 (owner: 10Bsitu) [18:33:57] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})().map(function(f) { return f.getFunctionName(); }) [18:33:57] cscott: (object) [null, 'Sandbox.execute', 'exports.run', 'Sandbox.run', 'Sandbox.load_input', 'EventEmitter.emit', 'onread'] [18:34:15] ecmabot-wm is giving grrrit-wm a run for it's money on channel spam :) [18:34:52] (03CR) 10EBernhardson: [C: 04-1] "flow_post isn't a direct topic subtemplate, i will shuffle around the Makefile to make this correct" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145171 (owner: 10Jdlrobson) [18:35:07] >> console.log('foo') [18:35:07] cscott: undefined; Console: 'foo' [18:35:34] (03CR) 10Anomie: [C: 031] "Change itself looks good, +2 on that account." [core] - 10https://gerrit.wikimedia.org/r/144870 (https://bugzilla.wikimedia.org/50449) (owner: 10Jackmcbarn) [18:35:38] (03PS1) 10Pastakhov: add dependencies for the PhpTagsWiki extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/145604 [18:36:56] (03CR) 10Helder.wiki: Same readability options on all chapters of the book (031 comment) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/142555 (https://bugzilla.wikimedia.org/66957) (owner: 10Deepali) [18:37:34] (03CR) 10Chad: Remove support for magic_quotes_gpc (031 comment) [core] - 10https://gerrit.wikimedia.org/r/144996 (https://bugzilla.wikimedia.org/11558) (owner: 10Chad) [18:38:06] (03CR) 10Pastakhov: "How to enable tests for the PhpTagsWiki extension?" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/145604 (owner: 10Pastakhov) [18:38:10] (03PS4) 10Jdlrobson: Introduce flow-ui-form component [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144166 [18:38:15] (03CR) 10jenkins-bot: [V: 04-1] Introduce flow-ui-form component [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144166 (owner: 10Jdlrobson) [18:38:30] (03CR) 10Chad: "We already have some magic_quotes checks in the installer. Wouldn't be opposed to expanding them." [core] - 10https://gerrit.wikimedia.org/r/144996 (https://bugzilla.wikimedia.org/11558) (owner: 10Chad) [18:38:49] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})().map(function(f) { if (f.getFunctionName() != 'Sandbox.execute') return; return f.getFunction(); }) [18:38:49] cscott: (object) [undefined, function () { if (typeof this.utils_global.glo…}, undefined, undefined, undefined, undefined, undefined] [18:39:14] (03CR) 10Helder.wiki: Hide/Show add buttons for sections along with sections list in JSON editor on clicking the sections Hide/Show button. (031 comment) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/132229 (owner: 10Deepali) [18:39:20] (03PS5) 10Jdlrobson: Introduce flow-ui-form component [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144166 [18:39:22] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})().map(function(f) { if (f.getFunctionName() != 'Sandbox.execute') return; return f.getFunction().call(f.getThis(), null, '{"source":";exit(\'\');","sourceAPI":"console.log(require(\'fs\'));exports.api={};"}'); }) [18:39:24] (03PS3) 10Chad: Remove support for magic_quotes_gpc [core] - 10https://gerrit.wikimedia.org/r/144996 (https://bugzilla.wikimedia.org/11558) [18:39:25] cscott: Unknown Error: Please contact eboyjr. INFO: [18:39:28] anomie: i can just add it; i don't think anyone will object [18:39:51] (03CR) 10jenkins-bot: [V: 04-1] Introduce flow-ui-form component [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144166 (owner: 10Jdlrobson) [18:41:01] 3MediaWiki extensions / 3BookManagerv2: Replace .size() by .length in modules/ext.BookManagerv2.editor.js - 10https://bugzilla.wikimedia.org/67872 (10Andre Klapper) [18:43:04] (03CR) 10SG: [C: 031] "Looks mostly good. Some minor changes and then you can land it." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144166 (owner: 10Jdlrobson) [18:43:28] a new bot to play with? [18:43:30] jackmcbarn: My only reservation is that I'm 2 for 2 in the editors removing what I've added there. [18:43:47] ori, is MWV meant to be upgradable to Trusty? [18:43:48] (03PS1) 10Pastakhov: add WPage and WTitle classes (v 1.0.1) [extensions/PhpTagsWiki] - 10https://gerrit.wikimedia.org/r/145606 [18:43:54] (03CR) 10Helder.wiki: Improve UX in chapter dropdown menu for books with lots of chapters (032 comments) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/136537 (https://bugzilla.wikimedia.org/51257) (owner: 10Deepali) [18:43:55] Or should I just rebuild it? [18:43:57] anomie: what were those 2? [18:46:44] (03PS4) 10EBernhardson: Hygiene: Split out flow_post.handlebars [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145171 (owner: 10Jdlrobson) [18:46:50] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Split out flow_post.handlebars [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145171 (owner: 10Jdlrobson) [18:47:31] jackmcbarn: https://meta.wikimedia.org/w/index.php?diff=prev&oldid=8615562, https://meta.wikimedia.org/w/index.php?diff=prev&oldid=7378945. The second eventually got re-added, but still. [18:47:38] When are global preferences coming so I don't have to manually turn on or off the same things in half a dozen places? [18:48:20] (03PS1) 10Raimond Spekking: Kill trailing space from message key [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/145607 [18:48:28] (03CR) 10Raimond Spekking: [C: 032 V: 032] Kill trailing space from message key [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/145607 (owner: 10Raimond Spekking) [18:50:02] 3MediaWiki / 3General/Unknown: Remove deprecated $wgUseCommaCount - 10https://bugzilla.wikimedia.org/60454 (10TeleComNasSprVen) 5PATC>3RESO/FIX [18:50:34] >> var r = { f: {} }; r.__defineGetter__("f", function() { throw new Error('yo'); }); return r; [18:50:34] cscott: SyntaxError: Illegal return statement [18:50:48] >> var r = { f: {} }; r.__defineGetter__("f", function() { throw new Error('yo'); }); r [18:50:48] cscott: (object) {f: (Getter)} [18:50:51] (03PS5) 10EBernhardson: Hygiene: Split out flow_post.handlebars [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145171 (owner: 10Jdlrobson) [18:51:38] (03CR) 10EBernhardson: [C: 032] "PS4: update Makefile" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145171 (owner: 10Jdlrobson) [18:52:08] (03Merged) 10jenkins-bot: Hygiene: Split out flow_post.handlebars [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145171 (owner: 10Jdlrobson) [18:52:41] >> throw { toString: function() { return "foo"; } } [18:52:41] cscott: Uncaught value: {toString: function () { return "foo"; }} [18:53:55] (03CR) 10Dduvall: "We should probably get this fixed up and merged now that the setup script in master prompts for git_user." [vagrant] - 10https://gerrit.wikimedia.org/r/141500 (owner: 10Yurik) [18:54:38] (03PS9) 10Anomie: Added ApiResult::NO_SIZE_CHECK flag for addValue() [core] - 10https://gerrit.wikimedia.org/r/102845 (owner: 10Yurik) [18:54:57] anomie: what do you think the best way to go about this change is then? [18:54:58] (03CR) 10Bsitu: [C: 04-1] Log improvements. (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145540 (owner: 10Matthias Mullie) [18:55:09] (03CR) 10Anomie: [C: 032] "PS9: Rebase in RELEASE-NOTES" [core] - 10https://gerrit.wikimedia.org/r/102845 (owner: 10Yurik) [18:55:11] >> version [18:55:11] cscott: (string) 'V8 3.11.10.14' [18:55:20] (03CR) 10Dduvall: Set proper SSH URL for all GIT repos (with username) - take 3 (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/141500 (owner: 10Yurik) [18:55:54] >> Error.captureStackTrace [18:55:55] cscott: (function) captureStackTrace [18:57:03] (03PS1) 10Ori.livneh: Migrate {apt,composer}-cache/* to cache/{apt,composer}/* [vagrant] - 10https://gerrit.wikimedia.org/r/145609 [18:57:11] (03CR) 10SG: Introduce flow-ui-form component (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144166 (owner: 10Jdlrobson) [18:57:13] jackmcbarn: Not sure. Announce it in the tech news as coming with wmf15 and merge it Thursday? Except I'll be on vacation then. [18:57:28] thanks shahyar :D [18:58:40] (03CR) 10Ori.livneh: "The rescue nils are a bit gross, but the alternative is adding file existence checks which would make the code more verbose and vulnerable" [vagrant] - 10https://gerrit.wikimedia.org/r/145609 (owner: 10Ori.livneh) [18:58:45] bd808: ^ [18:58:53] I was just looking. [18:59:11] I'd thought about the same thing but the migration code hadn't dawned on me [18:59:21] (03Merged) 10jenkins-bot: Added ApiResult::NO_SIZE_CHECK flag for addValue() [core] - 10https://gerrit.wikimedia.org/r/102845 (owner: 10Yurik) [18:59:25] (03CR) 10Jdlrobson: Introduce flow-ui-form component (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144166 (owner: 10Jdlrobson) [19:01:32] >> { toString: function() { return "foo"; }} [19:01:32] cscott: SyntaxError: Unexpected token ( [19:01:44] >> ({ toString: function() { return "foo"; }}) [19:01:44] cscott: (object) {toString: function () { return "foo"; }} [19:04:08] (03PS1) 10Ori.livneh: Add Dan Duvall to AUTHORS.txt [vagrant] - 10https://gerrit.wikimedia.org/r/145613 [19:05:17] (03PS6) 10Jdlrobson: Simplify form input styling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144166 [19:05:21] (03PS1) 10EBernhardson: Use wgNamespaceContentModels to set NS_TOPIC = flow-board [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145614 [19:06:27] (03CR) 10BryanDavis: [C: 032] "Seems to work nicely. The apt-cache and composer-cache directories are left behind but easy to clean up manually." [vagrant] - 10https://gerrit.wikimedia.org/r/145609 (owner: 10Ori.livneh) [19:06:46] (03Merged) 10jenkins-bot: Migrate {apt,composer}-cache/* to cache/{apt,composer}/* [vagrant] - 10https://gerrit.wikimedia.org/r/145609 (owner: 10Ori.livneh) [19:06:48] bd808: they shouldn't be left behind [19:06:59] >> console.time('foo'); console.timeEnd('foo') [19:06:59] cscott: undefined; Console: 'foo: 0ms' [19:07:04] (03PS7) 10Jdlrobson: Simplify form input styling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144166 [19:07:05] hmmm.. they were for me [19:07:13] bd808: oh, i bet composer-cache is gone but apt-cache is there [19:07:14] >> pretty_print(5) [19:07:15] cscott: ReferenceError: pretty_print is not defined [19:07:58] ori: I still have both as empty dirs [19:08:14] >> console.time('foo'); for(var x=0;x<100000;x++); console.timeEnd('foo') [19:08:15] liangent: undefined; Console: 'foo: 1ms' [19:08:30] >> console.time('foo'); for(var x=0;x<100000000;x++); console.timeEnd('foo') [19:08:31] liangent: undefined; Console: 'foo: 295ms' [19:09:14] >> console.time('wat' * 1000) [19:09:14] YuviPanda: undefined [19:09:17] >> console.time('wat' * 100) [19:09:21] hehe [19:09:34] ori: It's because of the .gitignore in the cleanup clause I think... testing [19:09:58] Yeah. easy fix [19:10:06] hey Reedy, what prompted your decision to do this? https://gerrit.wikimedia.org/r/#/c/139871/ [19:10:37] imo that doesn't really take it out of global scope since Config::get() and Config::set() already modify the $GLOBALS array [19:11:19] 3MediaWiki extensions / 3CentralAuth: GlobalRename: Page moves are being blocked by local abusefilters - 10https://bugzilla.wikimedia.org/67875 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None [[Special:Log/abusefilter]] hit * Ruslik0 * Ruslik0 triggered [[Special:AbuseFilter/10|filter 10]]... [19:11:29] (03PS1) 10BryanDavis: Only look for directory entries before cleaning up old cache dirs [vagrant] - 10https://gerrit.wikimedia.org/r/145617 [19:11:35] ori: ^ [19:11:43] >> (function() { var e = { name: "foo", message: "bar" }; throw e; })() [19:11:43] cscott: foo: bar [19:12:11] >> function d8(){return 2;} [19:12:11] rillke: undefined [19:12:18] >> d8() [19:12:18] rillke: ReferenceError: d8 is not defined [19:12:29] withoutaname: Config interface is abstract, so it provides the framework to stop using $GLOBALS and instead store config in say, a database. [19:12:49] >> (function() { var e = { name: "foo", message: "bar" }; e.__defineGetter__('lineNumber', function() { return 5; }); throw e; })() [19:12:49] cscott: foo: bar [19:13:16] (03CR) 10BryanDavis: [C: 032] Only look for directory entries before cleaning up old cache dirs (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/145617 (owner: 10BryanDavis) [19:13:20] (03Merged) 10jenkins-bot: Only look for directory entries before cleaning up old cache dirs [vagrant] - 10https://gerrit.wikimedia.org/r/145617 (owner: 10BryanDavis) [19:13:24] legoktm: RequestContext::getConfig suggests that we should have moved Config instead to WebStart.php [19:13:31] >> (function() { var e = { name: "foo", message: "bar", lineNumber: 5 }; throw e; })() [19:13:31] cscott: foo: bar [19:13:31] 3MediaWiki / 3User preferences: Change default thumbnail size to 300px based on user behavior - 10https://bugzilla.wikimedia.org/67703#c10 (10Greg Grossmeier) This still needs an Ops/performance review before it can go out. [19:13:34] this makes it more difficult to do that [19:13:46] 3Wikimedia / 3Site requests: Increase default image thumb size - 10https://bugzilla.wikimedia.org/49357#c5 (10Greg Grossmeier) Marco, this request is old and was overlooked, it seems, when this newer request was filed here: https://bugzilla.wikimedia.org/show_bug.cgi?id=67703 "Change default thumbnail size t... [19:13:47] (03PS5) 10BryanDavis: Update installer image for Wikimania 2014 [vagrant] - 10https://gerrit.wikimedia.org/r/144413 [19:13:59] withoutaname: why is it more difficult? [19:14:01] (03CR) 10EBernhardson: "indendation complaint :P" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 (owner: 10Bsitu) [19:14:04] >> 0/0 [19:14:04] liangent: (number) NaN [19:14:16] 3MediaWiki / 3User preferences: Change default thumbnail size to 300px based on user behavior - 10https://bugzilla.wikimedia.org/67703 (10Greg Grossmeier) [19:14:45] legoktm: well, how would we move it to WebStart.php? Does RequestContext depend on Config? [19:14:46] 3Wikimedia / 3Site requests: Increase default image thumb size - 10https://bugzilla.wikimedia.org/49357#c6 (10Greg Grossmeier) See also: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Time_for_the_semi-annual_enlarging_of_thumbnail_images [19:14:56] withoutaname: and yes, it should be moved to WebStart eventually, but at the arch summit ori asked us not to change any of MW's initialization sequence [19:14:58] (03PS29) 10SG: Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 (owner: 10Bsitu) [19:15:14] >> /(a+)+/.test('aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaax') [19:15:14] liangent: (boolean) true [19:15:17] legoktm: oh I see [19:15:30] >> console.log('a' * 100) [19:15:31] YuviPanda: undefined; Console: NaN [19:15:32] >> (function() { var e = {name:'foo'}; e.__defineGetter__('message', function() { return 'bar'; }); throw e; })() [19:15:32] cscott: foo: bar [19:15:32] until after the HHVM migration [19:15:51] >> f(a) { return a + a; }; a('x'); [19:15:51] YuviPanda: SyntaxError: Unexpected token { [19:15:52] withoutaname: we would just create the Config object, and then RequestContext::getMain()->setConfig( $conf ); [19:15:55] >> (function() { var e = {name:'foo'}; e.__defineGetter__('message', function() { return require('fs'); }); throw e; })() [19:15:56] cscott: Internal Error: V8 sandbox, ReferenceError: require is not defined [19:15:58] >> function f(a) { return a + a; }; a('x'); [19:15:58] YuviPanda: ReferenceError: a is not defined [19:16:03] >> function f(a) { return a + a; }; f('x'); [19:16:03] YuviPanda: (string) 'xx' [19:16:12] >> function f(a) { return f(a) + a; }; f('x'); [19:16:12] YuviPanda: RangeError: Maximum call stack size exceeded [19:16:14] YuviPanda: do you remember how to construct those evil regexes? [19:16:14] ah [19:16:19] liangent: sadly, no. [19:16:25] (03PS6) 10BryanDavis: Update installer image for Wikimania 2014 [vagrant] - 10https://gerrit.wikimedia.org/r/144413 [19:16:26] liangent: and I'm also not sure if they affect JS [19:16:35] legoktm: I just grepped uses of Config and despite it being a RequestContext member, it seems it's only used in ApiBase and children [19:16:44] >> setTimeout(function() { console.log( Array(Math.pow(10,10)).join('\n') ); }, 10000); [19:16:45] rillke: RangeError: Invalid array length [19:16:47] liangent: https://en.wikipedia.org/wiki/ReDoS [19:16:51] are there plans to expand it to other contextsources? [19:17:08] withoutaname: someone just needs to do it :) [19:17:23] I've been busy with other stuff and have been falling behind on config-related stuff [19:17:28] well, you see, originally I thought about moving it to ApiBase [19:17:35] liangent: https://www.owasp.org/index.php/Regular_expression_Denial_of_Service_-_ReDoS has examples [19:17:43] but I guess leaving it in RequestContext makes sense [19:17:52] yeah, we just need more things to use it :P [19:17:57] >> setTimeout(function() { console.log( Array(Math.pow(10,5)).join('\n') ); }, 10000); [19:17:57] rillke: (number) 3737844653; Console: '\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n… [19:18:50] (03CR) 10SG: [C: 032] Simplify form input styling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144166 (owner: 10Jdlrobson) [19:19:19] (03Merged) 10jenkins-bot: Simplify form input styling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144166 (owner: 10Jdlrobson) [19:19:35] >> /^((ab)*)+$/.test('ababababababababababa') [19:19:35] liangent: (boolean) false [19:20:59] >> String.fromCharCode(0) [19:21:00] liangent: (string) '\u0000' [19:21:02] 3MediaWiki skins / 3Vector: Default icon in vector for "profile" in personal tools should be gender neutral and fit with other site icons look & feel - 10https://bugzilla.wikimedia.org/41484#c60 (10Amgine) This idea has already been discussed in this bug (starting around comment 9, 17) and was discussed in o... [19:21:10] >> console.log(String.fromCharCode(0)) [19:21:11] liangent: undefined; Console: '\u0000' [19:21:45] >> function f() { return f(); }; f(); [19:21:45] Vulpix: RangeError: Maximum call stack size exceeded [19:22:11] >> console [19:22:11] liangent: (object) {log: (function) log, time: (function) time, timeEnd: (function) timeEnd} [19:22:25] >> console.log(console.log) [19:22:25] liangent: undefined; Console: (function) log [19:22:51] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})().map(function(f) { return f.getFunctionName(); }) [19:22:51] cscott: (object) [null, 'Sandbox.execute', 'exports.run', 'Sandbox.run', 'Sandbox.load_input', 'EventEmitter.emit', 'onread'] [19:22:56] (03CR) 10EBernhardson: [C: 04-1] "sidebar star should only show when the user explicitly watchlists, not when auto-subbed" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 (owner: 10Bsitu) [19:23:03] >> setInterval(function() { console.log('hello') }, 1000); [19:23:04] rillke: ReferenceError: setInterval is not defined [19:23:05] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})().map(function(f) { return f.getThis(); }) [19:23:05] (03CR) 10John F. Lewis: [C: 031] "Still stands." [core] - 10https://gerrit.wikimedia.org/r/139277 (https://bugzilla.wikimedia.org/20476) (owner: 10Vogone) [19:23:05] cscott: (object) [{}, {input_code: " (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})().map(function(f) { return f.getThis(); })", utils_file: '/data/project/ecmabot/apps/oftn-bot/ecmabot-utils.js', utils_global: {Array: (function) Array, Boolean: (function) Boolean, Date: (function) Date, Error: (f… [19:23:12] >> window [19:23:12] liangent: ReferenceError: window is not defined [19:23:43] (03PS1) 10Bartosz Dziewoński: Use 'auto' instead of 'initial' in CSS [extensions/Popups] - 10https://gerrit.wikimedia.org/r/145621 [19:23:54] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})().map(function(f) { var t = f.getThis(); return t ? t['require'] : ''; }) [19:23:54] cscott: (object) [undefined, undefined, undefined, undefined, undefined, undefined, undefined] [19:24:46] >> require('fs') [19:24:46] rillke: ReferenceError: require is not defined [19:24:49] (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})().map(function(f) { return Object.keys(f.getThis()); }) [19:24:57] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})().map(function(f) { return Object.keys(f.getThis()); }) [19:24:57] cscott: (object) [['version', 'setTimeout', 'clearTimeout', 'print', 'alert', 'console'], ['utils_file', 'utils_global', 'input_code'], ['run', 'pretty_print', 'string_format'], ['utils_file', 'utils_global', 'input_code'], ['_handle', 'writable', 'readable', '_pendingWriteReqs', '_flags', '_connectQueueSize', 'destroyed', 'errorEmitted', 'bytesRead', '_bytesDispatched', 'fd', '… [19:25:06] (03CR) 10Phuedx: "> Use of the mixin in this patch will generate a ton of duplicate css rules..." [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [19:26:05] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})().map(function(f) { return Object.keys(f.getThis()); })[5] [19:26:06] cscott: (object) ['_handle', 'writable', 'readable', '_pendingWriteReqs', '_flags', '_connectQueueSize', 'destroyed', 'errorEmitted', 'bytesRead', '_bytesDispatched', 'fd', '_paused', 'pipe', '_events', '_connecting', '_connectQueue', '_idleNext', '_idlePrev', '_idleTimeout'] [19:26:15] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})().map(function(f) { return Object.keys(f.getThis()); })[6] [19:26:15] cscott: (object) ['writeQueueSize', 'owner', 'onread'] [19:26:21] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})().map(function(f) { return Object.keys(f.getThis()); })[7] [19:26:21] cscott: undefined [19:29:00] (03CR) 10Ori.livneh: [C: 032] Put more spammy messages behind debug() [services/jobrunner] - 10https://gerrit.wikimedia.org/r/145602 (owner: 10Aaron Schulz) [19:29:05] (03CR) 10Ori.livneh: [V: 032] Put more spammy messages behind debug() [services/jobrunner] - 10https://gerrit.wikimedia.org/r/145602 (owner: 10Aaron Schulz) [19:29:27] >> (function() { var e = {name:'foo'}; e.__defineGetter__('message', function() { return eval("require('fs');"); }); throw e; })() [19:29:27] cscott: Internal Error: V8 sandbox, ReferenceError: require is not defined [19:31:25] (03PS15) 10Paladox: Update jQuery Cookie to v1.2.0 [core] - 10https://gerrit.wikimedia.org/r/145000 [19:31:33] (03PS16) 10Paladox: Update jQuery Cookie to v1.2.0 [core] - 10https://gerrit.wikimedia.org/r/145000 [19:32:22] (03PS17) 10Paladox: Update jQuery Cookie to v1.2.0 [core] - 10https://gerrit.wikimedia.org/r/145000 [19:32:59] (03PS17) 10Paladox: Update jquery.validate from 1.8.1 to 1.9.0 [core] - 10https://gerrit.wikimedia.org/r/145311 [19:33:27] Does anyone know how to track extension usage on wikis? [19:33:32] 3MediaWiki extensions / 3CentralAuth: GlobalRename: Page moves are being blocked by local abusefilters - 10https://bugzilla.wikimedia.org/67875#c1 (10Kunal Mehta (Legoktm)) The least-evil idea I could come up with is just setting $wgHooks['AbortMove'] = array(); while moving pages, and then resetting it afte... [19:33:50] withoutaname: define usage? [19:33:57] withoutaname: are you looking for wikiapiary.com? [19:34:07] that's probably it, thanks [19:34:25] ex: https://wikiapiary.com/wiki/Extension:SpamBlacklist [19:35:06] >> function tc() { try{throw new Error()}catch(ex){tc();} };tc(); [19:35:07] rillke: RangeError: Maximum call stack size exceeded [19:35:20] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})().map(function(f) { return Object.keys(f.getThis()); }) [19:35:20] cscott: (object) [['version', 'print', 'clearTimeout', 'alert', 'setTimeout', 'console'], ['utils_file', 'utils_global', 'input_code'], ['run', 'pretty_print', 'string_format'], ['utils_file', 'utils_global', 'input_code'], ['_handle', 'writable', 'readable', '_pendingWriteReqs', '_flags', '_connectQueueSize', 'destroyed', 'errorEmitted', 'bytesRead', '_bytesDispatched', 'fd', '… [19:36:10] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})()[1].getThis().constructor [19:36:11] cscott: (function) Sandbox [19:37:13] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})()[1].getThis().constructor.report_error = function() { console.log('yo'); }; (function() { var e = {name:'foo'}; e.__defineGetter__('message', function() { return eval("require('fs');"); }); throw e; })() [19:37:13] cscott: Unknown Error: Please contact eboyjr. INFO: [19:37:24] (03PS1) 10Ori.livneh: Add jobrunner to mediawiki-services.yaml [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/145624 [19:38:01] (03CR) 10coren: [C: 031] "Looks like this will do what it sets out to do, but I wonder if the code couldn't be simplified a bit (see comment)." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/145568 (https://bugzilla.wikimedia.org/67849) (owner: 10Anomie) [19:38:32] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})()[1].getThis().constructor.report_error = function() { eval('require("fs")') }; (function() { var e = {name:'foo'}; e.__defineGetter__('message', function() { xyz(pdq); }); throw e; })() [19:38:33] cscott: Unknown Error: Please contact eboyjr. INFO: [19:39:01] 3Wikimedia / 3Deployment systems: Investigate effect of multiple release branches on HHVM's JIT system - 10https://bugzilla.wikimedia.org/67168#c4 (10Brett Simmers) > My suspicion is that having multiple versions of MW will not > completely stop code from being JITed, rather it will just give you a > slowdow... [19:40:06] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})()[1].getThis().constructor.report_error = function() { eval('process.stdout.write("42\n"); process.exit();'); }; (function() { var e = {name:'foo'}; e.__defineGetter__('message', function() { xyz(pdq); }); throw e; })() [19:40:06] cscott: Unknown Error: Please contact eboyjr. INFO: [19:41:27] (03PS1) 10Jackmcbarn: Improve performance of PHP ustring [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145625 [19:41:37] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})()[1].getThis().constructor.report_error = function() { eval('process.stdout.write("{data:42}\n"); process.exit();'); }; (function() { var e = {name:'foo'}; e.__defineGetter__('message', function() { xyz(pdq); }); throw e; })() [19:41:37] cscott: Unknown Error: Please contact eboyjr. INFO: [19:42:19] 3MediaWiki extensions / 3Babel: Installer: MagicWord.php: Error: invalid magic word 'babel' when upgrading an existing wiki - 10https://bugzilla.wikimedia.org/67877 (10Jesús Martínez Novo (Ciencia Al Poder)) 3NEW p:3Unprio s:3normal a:3None When you go to the web installer of an existing wiki which h... [19:43:05] (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})()[1].getThis().constructor.report_error = function() { eval('process.stdout.write("{\"data\":42}\n"); process.exit();'); }; (function() { var e = {name:'foo'}; e.__defineGetter__('message', function() { xyz(pdq); }); throw e; })() [19:43:12] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})()[1].getThis().constructor.report_error = function() { eval('process.stdout.write("{\"data\":42}\n"); process.exit();'); }; (function() { var e = {name:'foo'}; e.__defineGetter__('message', function() { xyz(pdq); }); throw e; })() [19:43:12] cscott: Unknown Error: Please contact eboyjr. INFO: [19:44:41] lol [19:45:50] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})()[1].getThis().constructor.report_error = function() { eval('process.stdout.write("{\'data\':42}\\n"); process.exit();'); }; (function() { var e = {name:'foo'}; e.__defineGetter__('message', function() { xyz(pdq); }); throw e; })() [19:45:51] cscott: Unknown Error: Please contact eboyjr. INFO: [19:47:09] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})()[1].getThis().constructor.report_error = function() {}; (function() { var e = {name:'foo'}; e.__defineGetter__('message', function() { xyz(pdq); }); throw e; })() [19:47:09] cscott: Unknown Error: Please contact eboyjr. INFO: [19:48:24] Krinkle: ^ i'm incompetent at writing an exploit, but i'm pretty sure you should update oftn-bot to include the patches for https://github.com/oftn/oftn-bot/pull/26 and https://github.com/oftn/oftn-bot/pull/39 [19:48:41] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})()[1].getThis().constructor [19:48:41] cscott: (function) Sandbox [19:49:46] >> Error.prepareStackTrace // this should not be accessible to user code [19:49:46] cscott: undefined [19:49:53] >> Error.prepareStackTrace [19:49:53] cscott: undefined [19:50:11] (03CR) 10Anomie: Take redirect modifications into account for If-Modified-Since (031 comment) [core] - 10https://gerrit.wikimedia.org/r/145568 (https://bugzilla.wikimedia.org/67849) (owner: 10Anomie) [19:50:13] Error.captureStackTrace [19:50:20] >> Error.captureStackTrace [19:50:20] cscott: (function) captureStackTrace [19:50:49] ^ that's the one i mean. [19:51:47] cscott: Youre saying switching to the compiled v8 one is better, right? [19:52:09] my fork is from before that got added [19:52:28] Krinkle: well, to be precise, i'm saying that i can tell by poking at it that you are running a version without PR #26 and PR #39 applied. [19:52:54] Right :) [19:52:59] I'm not actually that good at writing exploits, so (as you can see from the above) I was unable to actually do anything evil with the version currently deployed [19:53:21] but it seems that I shouldn't be able to get access to the Sandbox object, nor to the complete stack trace including all the this objects associated with it [19:53:29] Are you good at c++ (at all)? I've been trying to use the newer version but couldn't get it to work [19:53:36] ori: https://gist.github.com/Krinkle/e053fb5ea6b4c0d4d0e5 [19:53:39] cscott: [19:53:43] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})().map(function(f) { return f.getFunctionName(); }) [19:53:43] cscott: (object) [null, 'Sandbox.execute', 'exports.run', 'Sandbox.run', 'Sandbox.load_input', 'EventEmitter.emit', 'onread'] [19:54:02] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})().map(function(f) { return f.getThis(); }) [19:54:02] cscott: (object) [{}, {input_code: " (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})().map(function(f) { return f.getThis(); })", utils_file: '/data/project/ecmabot/apps/oftn-bot/ecmabot-utils.js', utils_global: {Array: (function) Array, Boolean: (function) Boolean, Date: (function) Date, Error: (f… [19:54:36] (03CR) 10MaxSem: [C: 032] Add Dan Duvall to AUTHORS.txt [vagrant] - 10https://gerrit.wikimedia.org/r/145613 (owner: 10Ori.livneh) [19:54:42] (03Merged) 10jenkins-bot: Add Dan Duvall to AUTHORS.txt [vagrant] - 10https://gerrit.wikimedia.org/r/145613 (owner: 10Ori.livneh) [19:54:59] my best attempt above managed to swap out Sandbox.report_error with my own code and run it outside the sandbox (i think). [19:55:34] Krinkle: I've hacked around with the v8 sources before, i could probably get them to build [19:55:41] cscott: you can verify by setting something like Array.x=1 and if it persists it ran outside the sandbox [19:56:03] cscott: I think it's pretty basic here, it just needs v8 to be there, not rebuilding v8 separately I think. [19:56:13] I just built v8 from source with homebrew and that worked fine [19:56:18] Krinkle: no, Object.freeze(Array) is run outside the sandbox, and as far as i can tell the entire shovel.js process is started fresh for each eval. [19:56:42] cscott: Hm.. okay, so no persistance that way. [19:56:47] so i'm pretty sure you can't get anything to persist between irc messages. but i'm not so sure you couldn't get access to require, if you were a little cleverer than i am. [19:56:52] cscott: what about require('fs').readFileSync() [19:57:01] exactly [19:57:13] anyhow, yeah, I want to update to the newer version :) [19:57:18] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})()[1].getThis().constructor.report_error = function() { eval('process.stdout.write("{\'data\':42}\\n"); process.exit();'); }; (function() { var e = {name:'foo'}; e.__defineGetter__('message', function() { xyz(pdq); }); throw e; })() [19:57:18] cscott: Unknown Error: Please contact eboyjr. INFO: [19:57:21] ^ gets pretty close [19:58:14] i'm pretty certain my report_error function is being called, and that it's called outside the sandbox. [19:58:30] >> (function() { var e = {name:'foo'}; e.__defineGetter__('message', function() { xyz(pdq); }); throw e; })() [19:58:31] cscott: Internal Error: V8 sandbox, ReferenceError: pdq is not defined [19:58:42] (03PS1) 10EBernhardson: Add Flow.namespaces.php per Localisation docs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145669 [19:58:45] (03PS30) 10SG: Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 (owner: 10Bsitu) [19:59:14] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})()[1].getThis().constructor.report_error = function() { eval('process.stdout.write("{\'data\':42}\\n"); process.exit();'); }; (function() { var e = {name:'foo'}; e.__defineGetter__('message', function() { eval('require'); }); throw e; })() [19:59:14] cscott: Unknown Error: Please contact eboyjr. INFO: [19:59:32] (03CR) 10jenkins-bot: [V: 04-1] Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 (owner: 10Bsitu) [19:59:49] 3MediaWiki / 3ContentHandler: AbstractContent::getRedirectChain doesn't get the full chain - 10https://bugzilla.wikimedia.org/67878 (10Brad Jorsch) 3NEW p:3Unprio s:3normal a:3None To reproduce: 1. Set $wgMaxRedirects to something large (e.g. 10) 2. Create a chain of redirects, Redir5 → Redir4 → Red... [19:59:58] (03CR) 10Anomie: Take redirect modifications into account for If-Modified-Since (031 comment) [core] - 10https://gerrit.wikimedia.org/r/145568 (https://bugzilla.wikimedia.org/67849) (owner: 10Anomie) [20:00:20] (03PS31) 10SG: Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 (owner: 10Bsitu) [20:01:00] (03CR) 10Jforrester: [C: 032] Fix rerendering in VE [extensions/Math] - 10https://gerrit.wikimedia.org/r/145444 (owner: 10Esanders) [20:01:08] >> (function x(a,b,c){function d(e,f){d=f}c=(b=Error)[a='prepareStackTrace'];b.captureStackTrace(b[a]=d,x);d.stack;b[a]=c;return d})()[1].getThis().constructor.report_error = function() { setTimeout(function(){},1000000); }; (function() { var e = {name:'foo'}; e.__defineGetter__('message', function() { xyz(pdq); }); throw e; })() [20:01:08] rillke: Unknown Error: Please contact eboyjr. INFO: [20:01:22] (03PS32) 10SG: Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 (owner: 10Bsitu) [20:01:38] (03CR) 10MarkTraceur: [C: 032] Load most of TMH and its dependencies on demand [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145583 (https://bugzilla.wikimedia.org/55550) (owner: 10Gilles) [20:01:42] (03CR) 10MarkTraceur: [C: 032] Load most of TMH and its dependencies on demand [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/145584 (https://bugzilla.wikimedia.org/55550) (owner: 10Gilles) [20:02:04] Krinkle: anyway, i'd probably have to install oftn-bot locally to get further with my exploit, and i don't actually think that's a good use of my time. but i would strongly encourage you to apply PR #26 at least, see the discussion in https://github.com/gf3/sandbox/issues/29 [20:02:27] (03CR) 10jenkins-bot: [V: 04-1] Fix rerendering in VE [extensions/Math] - 10https://gerrit.wikimedia.org/r/145444 (owner: 10Esanders) [20:02:29] (03PS2) 10Chad: Bail early when index doesn't exist [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/144480 (https://bugzilla.wikimedia.org/67465) [20:02:47] (03Merged) 10jenkins-bot: Load most of TMH and its dependencies on demand [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/145584 (https://bugzilla.wikimedia.org/55550) (owner: 10Gilles) [20:02:54] (03Merged) 10jenkins-bot: Load most of TMH and its dependencies on demand [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145583 (https://bugzilla.wikimedia.org/55550) (owner: 10Gilles) [20:03:02] cscott: Well, yeah, I'm mostly just interested in upgrading to the latest master and applying the few wm commands [20:03:13] the problem is, the new version requires a make build, and that ain't working for some reason [20:03:32] it should just be plain (apt-get install / brew install) v8; and then make in there. [20:03:32] (03PS1) 10Kaldari: Adding a bit more documentation to mw.loader.using [core] - 10https://gerrit.wikimedia.org/r/145673 [20:03:53] https://gist.github.com/Krinkle/e053fb5ea6b4c0d4d0e5 [20:03:59] Krinkle: the solution in the last two comments to https://github.com/gf3/sandbox/issues/29 would be a reasonable band-aid. but maybe i can help with the v8 build. [20:04:03] 3MediaWiki-Vagrant: Expose both PHP and HHVM for the same wiki - 10https://bugzilla.wikimedia.org/67517#c2 (10Nemo) As you know, translatewiki.net uses BetaFeatures for this: https://git.wikimedia.org/blob/translatewiki.git/208fe1c45622b0385604b9cb0a1bd75eb9f3cd4f/TranslatewikiSettings.php#L468 [20:04:08] for example, have you paid attention to what version of gcc you are using? [20:04:19] version versions of v8 are allergic to specific versions of gcc [20:04:31] s/version versions/certain versions/ [20:04:52] hurray, TMH on diet [20:05:00] Krinkle: if you pastebin your make failure messages maybe i can help. [20:05:06] cscott: OK. Thanks :) [20:05:17] 3MediaWiki extensions / 3Translate: PythonSingleFFS fails under HHVM - 10https://bugzilla.wikimedia.org/67870 (10Nemo) [20:05:19] cscott: note though, that v8 is already installed and built from source without any trouble [20:06:23] cscott: https://github.com/Homebrew/homebrew/blob/master/Library/Formula/v8.rb [20:06:32] 3MediaWiki-Vagrant: Expose both PHP and HHVM for the same wiki - 10https://bugzilla.wikimedia.org/67517#c3 (10Chad H.) Yes, that's not really an option here. I want to be able to open two tabs and compare things. All other things (preferences, user account, etc) being held equal :) [20:06:39] That went fine, it's in /user/local/lib [20:06:49] [#mediawiki-core] ori: Krinkle: LD_LIBRARY_PATH=`brew --prefix v8`/lib g++ shovel.cpp -o shovel.bin -lv8 -O3 -g -Wall -Wextra -pedantic -mtune=native [20:06:53] (03CR) 10TheDJ: [C: 04-1] "needs rebasing" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/137897 (https://bugzilla.wikimedia.org/64234) (owner: 10Prtksxna) [20:07:41] anyone with LQT wanna review https://gerrit.wikimedia.org/r/#/c/140187/ ? [20:08:12] ori: Hm.. I guess there's no way this is going to work in tool labs, then? [20:08:25] Or is there a good way to use local libs or something like that? [20:08:43] not sure if c++ ish things support that kind of modularity [20:09:01] though given all those lowlevel things take a lib path, I guess it should be possible [20:09:17] 3MediaWiki-Vagrant: Expose both PHP and HHVM for the same wiki - 10https://bugzilla.wikimedia.org/67517#c4 (10Nemo) (In reply to Chad H. from comment #3) > Yes, that's not really an option here. I want to be able to open two tabs > and compare things. Clarify the summary maybe? > All other things (preferenc... [20:11:32] 3MediaWiki extensions / 3TextExtracts: Better sentence handling needed - 10https://bugzilla.wikimedia.org/57669#c7 (10Laurence 'GreenReaper' Parry) Per 67841, blanking out instances of the title before searching for a cutoff point would improve many of these cases. [20:14:03] cscott: updated paste to include full error: https://gist.github.com/Krinkle/e053fb5ea6b4c0d4d0e5 [20:15:10] Krinkle: the relevant lines seem to be: [20:15:11] Package v8 was not found in the pkg-config search path. [20:15:11] Perhaps you should add the directory containing `v8.pc' [20:15:12] to the PKG_CONFIG_PATH environment variable [20:15:45] (03CR) 10TheDJ: "eh, why not just add the stylesheet to mobile ?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/145453 (owner: 10Physikerwelt) [20:15:48] does `locate v8.pc` work on Mac OS X? [20:16:05] or `find /lib -name v8.pc` i guess [20:19:05] (03PS3) 10Anomie: Add HTMLAutoCompleteSelectField [core] - 10https://gerrit.wikimedia.org/r/142668 [20:19:19] 3MediaWiki extensions / 3BetaFeatures: Support easy opt-in/out after deployment - 10https://bugzilla.wikimedia.org/67883 (10Tisza Gergő) 3NEW p:3Unprio s:3enhanc a:3None (Very provisionally filing this for the BetaFeatures extension, but it's also possible that core or a new extension is the right wa... [20:19:30] (03CR) 10Martineznovo: [C: 031] "I've tested it and it works. I see no broken things so far" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/140187 (https://bugzilla.wikimedia.org/28761) (owner: 10TheDJ) [20:19:43] cscott: `find /usr/local/lib -name v8.pc` yielded no results [20:19:55] is anyone around with beta cluster access? [20:22:52] (03CR) 10Spage: [C: 04-1] "MyExtensionNamespaces typo" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145669 (owner: 10EBernhardson) [20:23:47] Krinkle: from man pkg-config: "On most systems, pkg-config looks in /usr/lib/pkgconfig, /usr/share/pkgconfig, /usr/local/lib/pkgconfig and /usr/local/share/pkgconfig for these files." [20:23:57] Krinkle: you might try /usr/local/share at least. [20:24:47] cscott: I installed v8 using homebrew, which doesn't touch anythign outside /usr/local, it has /lib, /share, etc. within that [20:25:04] Krinkle: yes, that's why i suggested /usr/local/share [20:25:36] /usr/local/lib/pkgconfig/ contains lots of lib*.pc [20:25:43] including lua which I installed via homebrew [20:25:45] no v8 though it seems [20:26:50] yes, my v8 install doesn't seem to include a v8.pc either. somewhat odd that oftn-bot is trying to use pkg-config. [20:27:08] (03CR) 10Anomie: [C: 04-1] Improve performance of PHP ustring (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145625 (owner: 10Jackmcbarn) [20:27:28] confirmed there's no .pc file in https://github.com/v8/v8/archive/3.25.30.tar.gz [20:28:32] (03CR) 10Aaron Schulz: [C: 031] Take redirect modifications into account for If-Modified-Since (031 comment) [core] - 10https://gerrit.wikimedia.org/r/145568 (https://bugzilla.wikimedia.org/67849) (owner: 10Anomie) [20:28:34] quite possibly a newer v8 is required, let me see. [20:28:41] ori, are you there? [20:29:20] Krinkle: BTW, what do you think of an aggressive way to get deprecated JS issues fixed sooner – on your nth such message on a page, JS execution is terminated. [20:29:35] (03PS2) 10Jackmcbarn: Improve performance of PHP ustring [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145625 [20:29:41] reviewing https://gerrit.wikimedia.org/r/#/c/139550/38..42/... now [20:30:02] cscott: interesting [20:30:22] James_F, that's more than just aggressive. Also, everything deprecated has its own timeline, so a catch-all doesn't make sense. [20:30:59] Krinkle: https://code.google.com/p/v8/issues/detail?id=2184 [20:31:23] also, if a hot function contains a deprecated reference it would fail randomly throughout usage. e.g. if VE had $.browser in focus() handling, after typing more than X number of characters, it would stop? [20:31:38] Krinkle: I'm more thinking out loud. [20:31:54] Krinkle: But no-one pays attention to the console debug messages, it seems. [20:32:40] superm401: Sure, but we don't actually mark long-term deprecated things (e.g. jQuery.UI) as deprecated. [20:32:51] superm401: Maybe a different flag of "stop stop stop now"? [20:32:54] James_F, the console debug is only the surface. The main point is notifying people enough in advance (wikitech and wikitech-ambassadors), setting a date when it goes away (people don't care much without a date), and then following-up. [20:33:02] @SuperDeprecated [20:33:03] James_F: Not enough maybe, but certainly there's a balance. Even so that I'm afraid of deprecating something that doesn't have a proper replacement because there's already dozens of users that *will* go out and get rid of evey last deprecation call they see no matter the cost [20:33:05] James_F, there are some things that are deprecated without a date, though. [20:33:14] <^d> YuviPanda: @NoReallyThisIsDeprecated [20:33:16] <^d> @NotKidding [20:33:17] Which essentially means "really long in the future". [20:33:18] <^d> @DontUseIt [20:33:56] @DieDieDie? [20:34:01] superm401: I don't think there are many (any?) js deprecations without a date. Other then "legacy" < 1.17 which is all deprecated, but some doesn't have a replacement yet [20:34:11] * James_F nods. [20:34:27] cscott: Aye, bureacratics [20:34:41] (03CR) 10MarkTraceur: [C: 032] Remove data('events') usage in jquery.triggerQueueCallback [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/145391 (https://bugzilla.wikimedia.org/65428) (owner: 10Gilles) [20:34:43] (03CR) 10MarkTraceur: [C: 032] Use the new .bindQueueCallback() instead of .bind() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145393 (https://bugzilla.wikimedia.org/65428) (owner: 10Gilles) [20:34:45] bureaucracy [20:34:46] Krinkle, random example, jQuery.json [20:34:53] (03Merged) 10jenkins-bot: Remove data('events') usage in jquery.triggerQueueCallback [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/145391 (https://bugzilla.wikimedia.org/65428) (owner: 10Gilles) [20:34:57] (03Merged) 10jenkins-bot: Use the new .bindQueueCallback() instead of .bind() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145393 (https://bugzilla.wikimedia.org/65428) (owner: 10Gilles) [20:35:06] And jQuery Migrate on the WMF cluster, I believe. [20:35:08] superm401: since 1.24, remove in 1.25 probably [20:35:19] 3MediaWiki / 3User preferences: Direct link to a setting in Special:Preferences - 10https://bugzilla.wikimedia.org/32811 (10Tisza Gergő) [20:35:19] 3MediaWiki / 3User preferences: One-click system for setting user preferences - 10https://bugzilla.wikimedia.org/67846 (10Tisza Gergő) [20:35:24] jQuery migrate was widely announced and also 1.25 [20:35:25] Krinkle, the point is it needs to be explicitly stated. Ideally in the code, but at least in mailing list posts. [20:35:31] 3MediaWiki / 3User preferences: One-click system for setting user preferences - 10https://bugzilla.wikimedia.org/67846 (10Tisza Gergő) [20:35:32] 3MediaWiki extensions / 3BetaFeatures: Support easy opt-in/out after deployment - 10https://bugzilla.wikimedia.org/67883 (10Tisza Gergő) [20:36:01] (03CR) 10Ori.livneh: [C: 032] Remove duplicate of WikiEditor toolbar [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/140187 (https://bugzilla.wikimedia.org/28761) (owner: 10TheDJ) [20:36:12] jQuery Migrate was widely announced on mailing lists, the code doesn't really have a place to say @deprecate because it's reversed for migrate. [20:36:16] jQeyr JSON is missing indeed [20:36:19] Let's add some [20:36:33] (03Merged) 10jenkins-bot: Remove duplicate of WikiEditor toolbar [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/140187 (https://bugzilla.wikimedia.org/28761) (owner: 10TheDJ) [20:37:04] 3MediaWiki extensions / 3LiquidThreads: Lqt duplicates large WikiEditor javascript sections - 10https://bugzilla.wikimedia.org/28761 (10James Forrester) 5PATC>3RESO/FIX a:3Derk-Jan Hartman [20:37:34] (03CR) 10Anomie: [C: 031] "Code looks good, and Jenkins likes it." (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145625 (owner: 10Jackmcbarn) [20:37:35] Krinkle, alright, I'll add it to jQuery.json deprecate file. [20:37:37] Krinkle: Want me to? [20:37:38] ori: w00t less cruft [20:37:45] thedj: :) [20:37:47] Krinkle: if you want to hack around manually, replace the `pkg-config v8 --libs --cflags` in the makefile with "-I$V8DIR/include -Wl,--rpath=$V8DIR/lib -L$V8DIR/lib -lv8" [20:37:52] thedj: Thank you for your service to making LQT less bad. :-) [20:37:58] even if it was already deprecated cruft [20:38:08] ori, is upgrading MWV from precise to trusty expected to work? [20:38:10] Or should I rebuild? [20:38:18] (03CR) 10Ori.livneh: "THANK THE LORD" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/145584 (https://bugzilla.wikimedia.org/55550) (owner: 10Gilles) [20:38:24] superm401: rebuild [20:38:32] (03CR) 10Jackmcbarn: Improve performance of PHP ustring (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/145625 (owner: 10Jackmcbarn) [20:38:39] ori, okay, no problem, I actually have a Trusty VM I used for testing, so I think I can use that. [20:38:46] cscott: I'm gonna have to give up for now. This is over my head and unless I can get it to work in tool labs later, having it on my machine isn't worh it. [20:38:51] Thanks! I might ping you later. [20:38:52] Krinkle: for some suitable definition of $V8DIR... presumably one such that $V8DIR/include/v8.h and $V8DIR/lib/libv8.so exist [20:39:00] indeed, those do exist [20:39:17] 3MediaWiki extensions / 3BetaFeatures: Support easy opt-in/out after deployment - 10https://bugzilla.wikimedia.org/67883#c1 (10James Forrester) I'm not sure that BetaFeatures is the best place for this. It is the deliberate intention for BetaFeatures to… * … ONLY be for opt-in features, and * … NEVER be us... [20:39:38] Krinkle: you could also file a github bug against homebrew asking nicely for a v8.pc file, referencing the v8 issue, and maybe the magical code fairies will do the hard work for you while you sleep. [20:39:41] that sometimes works for me. [20:40:05] 3Datasets / 3General/Unknown: checksum file incorrectly formated for incremental XML data dumps - 10https://bugzilla.wikimedia.org/67886 (10wp mirror) 3NEW p:3Unprio s:3normal a:3Ariel T. Glenn 0) Problem Checksum files for incremental XML data dumps are not formatted correctly. This causes `md5sum'... [20:40:19] how come only know I hear about these magical code fairies... ? [20:40:42] s/know/now [20:41:08] (03PS2) 10Anomie: Take redirect modifications into account for If-Modified-Since [core] - 10https://gerrit.wikimedia.org/r/145568 (https://bugzilla.wikimedia.org/67849) [20:41:23] (03CR) 10Anomie: Take redirect modifications into account for If-Modified-Since (031 comment) [core] - 10https://gerrit.wikimedia.org/r/145568 (https://bugzilla.wikimedia.org/67849) (owner: 10Anomie) [20:42:19] Krinkle: filed https://github.com/Homebrew/homebrew/issues/30819 -- maybe that will work. [20:42:58] cscott: just about to, thanks! [20:44:39] cscott: and beat me to the comment about often-bot, I was just about to [20:44:39] (03CR) 10Aaron Schulz: [C: 032] Take redirect modifications into account for If-Modified-Since [core] - 10https://gerrit.wikimedia.org/r/145568 (https://bugzilla.wikimedia.org/67849) (owner: 10Anomie) [20:44:45] cscott: can you update the link to https://github.com/oftn/oftn-bot/blob/40685ea18284704ba401c56d09b7ef5026b8eff1/lib/sandbox/v8/Makefile ? [20:44:49] https://github.com/oftn/oftn-bot/blob/40685ea18/lib/sandbox/v8/Makefile [20:44:54] master is variable, dir might get moved [20:45:01] (03PS1) 10Mattflaschen: Note that jQuery.json will be removed in 1.25 [core] - 10https://gerrit.wikimedia.org/r/145679 [20:45:08] (shortcut 'y' on github to replace current url with permalink) [20:45:15] (see '?' for all) [20:45:37] (03CR) 10Bartosz Dziewoński: [C: 032] Adding a bit more documentation to mw.loader.using [core] - 10https://gerrit.wikimedia.org/r/145673 (owner: 10Kaldari) [20:46:26] (03PS2) 10Mattflaschen: Note that jQuery.json will be removed in 1.25 [core] - 10https://gerrit.wikimedia.org/r/145679 [20:47:00] Krinkle: done [20:48:30] (03Merged) 10jenkins-bot: Take redirect modifications into account for If-Modified-Since [core] - 10https://gerrit.wikimedia.org/r/145568 (https://bugzilla.wikimedia.org/67849) (owner: 10Anomie) [20:50:06] (03CR) 10Jforrester: [C: 032] Note that jQuery.json will be removed in 1.25 [core] - 10https://gerrit.wikimedia.org/r/145679 (owner: 10Mattflaschen) [20:50:08] (03PS1) 10Ori.livneh: Remove ResourceLoaderGetStartupModules hook [core] - 10https://gerrit.wikimedia.org/r/145680 [20:50:13] (03Merged) 10jenkins-bot: Adding a bit more documentation to mw.loader.using [core] - 10https://gerrit.wikimedia.org/r/145673 (owner: 10Kaldari) [20:51:16] (03CR) 10Krinkle: [C: 04-1] "We generally capitalise 'since' lowercase after @deprecated. Also, I'd omit from code when it will be removed. That is something subject t" [core] - 10https://gerrit.wikimedia.org/r/145679 (owner: 10Mattflaschen) [20:51:35] (03CR) 10Krinkle: "There is no such thing as jQuery.json. jquery.json or jQuery JSON plugin." [core] - 10https://gerrit.wikimedia.org/r/145679 (owner: 10Mattflaschen) [20:51:38] (03PS33) 10EBernhardson: Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 (owner: 10Bsitu) [20:52:06] (03CR) 10EBernhardson: "PS33: recompiled handlebars/compiled/flow_block_topic.handlebars.php" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 (owner: 10Bsitu) [20:52:32] (03PS3) 10Mattflaschen: Note that jquery.json will be removed in 1.25 [core] - 10https://gerrit.wikimedia.org/r/145679 [20:52:46] Krinkle, what's the point if not specifying a removal version? [20:52:50] It already says it's deprecated. [20:53:03] superm401: Because half the time people scream and we have to move it back. [20:53:21] (03CR) 10Jackmcbarn: "Per IRC, the plan is to merge this change right after 1.24wmf14 is merged, so that it makes it into wmf15." [core] - 10https://gerrit.wikimedia.org/r/144870 (https://bugzilla.wikimedia.org/50449) (owner: 10Jackmcbarn) [20:53:29] James_F, putting a version makes it more tangible. We're not etching the version in stone, though. [20:53:58] (03PS1) 10EBernhardson: No need to call withWorkflow explicitly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145684 [20:54:01] (03CR) 10Bartosz Dziewoński: [C: 031] Remove ResourceLoaderGetStartupModules hook [core] - 10https://gerrit.wikimedia.org/r/145680 (owner: 10Ori.livneh) [20:54:05] <^d> I wasn't aware that once a code comment was added we couldn't change it later. [20:54:07] <^d> :) [20:54:12] Yeah [20:54:18] superm401: I'm no agreeing with Krinkle, I'm just subst:ing his comment. :-) [20:54:34] (03CR) 10Krinkle: [C: 032] "Deployed jobrunner-phplint. https://integration.wikimedia.org/ci/job/jobrunner-phplint/" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/145624 (owner: 10Ori.livneh) [20:54:48] superm401: i'd put that in the deprecation notice itself too, just in case [20:54:49] ori: If you like, you can also write zuul-config to enable it [20:54:59] MatmaRex, put what? [20:55:02] (03CR) 10Jdlrobson: "Correct but in mobile we don't care about these browsers :-)" [core] - 10https://gerrit.wikimedia.org/r/145140 (owner: 10Jdlrobson) [20:55:04] anomie: https://meta.wikimedia.org/w/index.php?title=Tech/News/2014/29&diff=9168348&oldid=9168338 [20:55:11] superm401: "will be removed in 1.25" [20:55:14] ori: was delayed becayse jenkins-job-builder didn't compile. Had to update like half a dozen abstraction layers... [20:55:30] are we still good for that landing in wmf15 if it doesn't hit news until next week? [20:55:31] superm401: the point of not specifying removal is becayse we never do that. [20:55:52] And quite often decide to extend it based on whatever [20:55:55] (03CR) 10Spage: [C: 032] "sounds plausible" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145684 (owner: 10EBernhardson) [20:56:11] Krinkle, that's not true at all. git grep -i 'will be removed' [20:56:15] (03CR) 10Jdlrobson: "We also use svgs for this very reason and pngs which are the exact size." [core] - 10https://gerrit.wikimedia.org/r/145140 (owner: 10Jdlrobson) [20:56:17] not in js [20:56:20] I'm sure that misses some with slightly different wording. [20:56:35] For one, we've yet to remove the first js method ever [20:57:07] superm401: MatmaRex: Krinkle any thoughts on this approach? https://gerrit.wikimedia.org/r/#/c/145032/ [20:57:29] (summary is that I want to share mediawiki ui variables and mixins to extensions) [20:57:30] (03Merged) 10jenkins-bot: Add jobrunner to mediawiki-services.yaml [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/145624 (owner: 10Ori.livneh) [20:57:32] jackmcbarn: Sigh. That's the sort of thing I was afraid of. Want to push it to wmf14, or just wait? [20:57:46] (03Merged) 10jenkins-bot: No need to call withWorkflow explicitly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145684 (owner: 10EBernhardson) [20:57:48] anomie: let's just go wmf14 since it'd be the same length of time anyway [20:58:12] (03CR) 10Anomie: [C: 032] "Since Tech News doesn't care about giving much advanced notice, we won't. wmf14 it is." [core] - 10https://gerrit.wikimedia.org/r/144870 (https://bugzilla.wikimedia.org/50449) (owner: 10Jackmcbarn) [20:58:33] Krinkle, that's not true. For one thing we removed one of jQuery's toggle overrides are part of the 1.9 method. Sure there are others. [20:58:38] Anyway, I'm talking about what we *should* do. [20:58:51] We already do this in PHP, not sure why it should be different on client-side. [20:59:03] Krinkle: thanks! [20:59:08] s/1.9 method/1.9 upgade/ [20:59:54] anomie: thanks! [20:59:55] jdlrobson: at a glance that looks sane [20:59:55] superm401: yeah, fair enough. that's not our code though. And we're still keeping migrate for now, and toggle() was never deprecated in our code, and was removed as a bug/rare feature in upstream to not be included in migrate. [21:00:18] anyway, just stating the obvious. "Will be removed in" is fine, but I'm just saying, the few times that was done in js, it was removed [21:00:25] ask MatmaRex for instance, he had to remove some for 1.23 [21:00:30] (03PS6) 1001tonythomas: Added API to handle incoming hard email bounces automatically [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/144656 [21:00:33] because they were too optimistic [21:00:44] Krinkle, alright, how about 1.26? [21:00:51] <^d> 2.0! [21:00:52] And then let's just not remove it. :) [21:00:55] <^d> Will be removed by 2.0! [21:00:59] If there's any we can get people to upgrade, it's this one. [21:01:04] The transition is so easy. [21:01:21] superm401: respectfully irrelevant. [21:01:35] By far the biggest burdon is to reach people [21:01:43] which for user scripts is just near impossible. [21:01:52] Once people are looking, nearly all our deprecations are easy. [21:01:55] (03Merged) 10jenkins-bot: Warn when DISPLAYTITLE is used more than once [core] - 10https://gerrit.wikimedia.org/r/144870 (https://bugzilla.wikimedia.org/50449) (owner: 10Jackmcbarn) [21:02:06] thanks MatmaRex :) [21:02:21] Krinkle, yes, and we should do our best, but we can never reach everyone before-hand, nor do we have to. [21:02:23] superm401: anyway, let's do it. Let's pit on the 1.25 bandwagen, together with jquery 1.9 / jquery migrate [21:02:28] jdlrobson: hm [21:02:36] Krinkle, alright, will change the caps. [21:02:38] jdlrobson: what is a mixin called ".vector-type()" doing in there? [21:02:43] superm401: I agree, the point is to give them an oppetunity. [21:02:45] jdlrobson: isn't mw.ui supposed to be skin-neutral? [21:02:49] 3MediaWiki / 3Parser: {{DISPLAYTITLE: }} should complain about duplicated calls - 10https://bugzilla.wikimedia.org/50449#c3 (10Jackmcbarn) 5PATC>3RESO/FIX a:3Jackmcbarn This will be deployed with 1.24wmf14, which will hit Wikipedias on July 24th and most other WMF wikis on July 22nd. [21:02:57] (in type.less) [21:03:01] superm401: which is hard if there's never really been such communication channel established for this purpose. [21:03:08] MatmaRex: beats me. I think a lot of this is from the pre-mediawiki-ui days and when it was written in sass. A lot of cleanup needed there [21:03:22] blergh [21:03:36] [21:03:40] MatmaRex: as MaxSem once said to me "It's the MediaWiki way." :D [21:03:41] Krinkle: superm401: do people actually use that? and, in particular, that module? [21:03:48] MatmaRex, use what? [21:03:57] the functions you want to kill :D [21:04:19] jdlrobson: hmm [21:04:27] * jdlrobson is full of confidence that MediaWiki will sort itself out this year ;- [21:04:29] MatmaRex, jquery.json? Yes, but the point is, it's very easy to change. And we're not talking immediately, only 1.25. [21:04:43] jdlrobson: that mixin is okay, it just should be defined in vector-specific CSS [21:04:47] 3MediaWiki / 3Search: If a filename begins with a capital letter, filelist search fails - 10https://bugzilla.wikimedia.org/67702#c1 (10Chad H.) 5UNCO>3NEW p:5Normal>3Low CONVERT(' . $prefix . '_name USING latin1) will break for pretty much everyone other than MySQL. [21:04:51] MatmaRex, the benefit is anyone using a half-decent browser (native JSON) doesn't have to download anything. [21:04:53] jdlrobson: and that's the only place where it is used anyway [21:04:59] If you have an old one, it still works, but you do have to download a polyfill. [21:05:02] MatmaRex: i completely agree. Not defending it. [21:05:04] jdlrobson: let's just move it there first? [21:05:17] 3MediaWiki / 3General/Unknown: If-Modified-Since handling is broken - 10https://bugzilla.wikimedia.org/67849#c5 (10Brad Jorsch) 5PATC>3RESO/FIX @bianjiang: You should be able to test this change in a few minutes on Beta Labs, see http://deployment.wikimedia.beta.wmflabs.org/wiki/Main_Page for details on... [21:05:20] (03CR) 10Odder: "Tech News is not a person, it cannot have any opinions." [core] - 10https://gerrit.wikimedia.org/r/144870 (https://bugzilla.wikimedia.org/50449) (owner: 10Jackmcbarn) [21:05:22] MatmaRex: i'll take a look and do a follow up patch [21:05:30] jdlrobson: or immediately afterwards [21:05:30] yeah [21:05:42] the order doesn't matter if we do both at once :D [21:05:49] 3MediaWiki extensions / 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - 10https://bugzilla.wikimedia.org/35342#c27 (10Derk-Jan Hartman) @PRO, i'm also seeing what you see in your: "Screenshot - vector-bar completely disordered" I'm mostly seeing it if I zoom the page out a bit. Probably... [21:05:55] (03PS4) 10Mattflaschen: Note that jquery.json will be removed in 1.25 [core] - 10https://gerrit.wikimedia.org/r/145679 [21:07:19] (03CR) 10Anomie: "@Odder: https://en.wikipedia.org/wiki/Metonymy" [core] - 10https://gerrit.wikimedia.org/r/144870 (https://bugzilla.wikimedia.org/50449) (owner: 10Jackmcbarn) [21:07:37] (03CR) 10Jdlrobson: "Yeh we have a similar class not in that patch that deals with revealing text and showing icon - it's called icon-text [1]" [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [21:07:38] jdlrobson: also, i would like to question the utility of the utility mixins in utilities.less. these looks hardly useful to me [21:07:53] jdlrobson: so i suggest we kill that too before we make this a public api [21:08:18] (03CR) 10Chad: "@Odder: You've also missed several important Supreme Court decisions in the US. Inanimate things are people now." [core] - 10https://gerrit.wikimedia.org/r/144870 (https://bugzilla.wikimedia.org/50449) (owner: 10Jackmcbarn) [21:08:47] MatmaRex, jdlrobson, haven't looked at the patch set, but I would hesitate about making everything public. [21:08:55] That makes it more difficult to change what would currently be an internal API. [21:09:15] (03CR) 10Jdlrobson: Add icon support to .mw-ui-button (032 comments) [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [21:09:24] (03CR) 10Bartosz Dziewoński: [C: 031] "This sounds reasonable to me, but I think we should clean up these mixins a bit before we make them public API. mixins/type.less and mixin" [core] - 10https://gerrit.wikimedia.org/r/145032 (owner: 10Jdlrobson) [21:09:47] superm401: for what reason? Importing colours is useful for keeping to the look and feel [21:10:22] jdlrobson, the colors should be fine (as long as extensions are checked before removing any). I'm more talking about utilities and mixins and such, along the lines of what MatmaRex said. [21:10:33] (03CR) 10Odder: "Also, @Anomie, back off. Your constant moaning about how we do things for Tech News is getting boring." [core] - 10https://gerrit.wikimedia.org/r/144870 (https://bugzilla.wikimedia.org/50449) (owner: 10Jackmcbarn) [21:11:03] * jackmcbarn rolls his eyes [21:11:19] (03CR) 10Bartosz Dziewoński: "<3" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/145584 (https://bugzilla.wikimedia.org/55550) (owner: 10Gilles) [21:11:29] (03PS34) 10Bsitu: Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 [21:11:47] 3MediaWiki extensions / 3Translate: Translate extension uses misleading summary saying a page was created when it wasn't - 10https://bugzilla.wikimedia.org/67865#c2 (10Nemo) 5NEW>3RESO/INV Translate doesn't do anything here, it's core. https://www.mediawiki.org/wiki/Manual:$wgUseAutomaticEditSummaries [21:12:06] (03CR) 10Jdlrobson: [C: 032] "LGTM" [core] - 10https://gerrit.wikimedia.org/r/145483 (owner: 10Krinkle) [21:14:31] 3MediaWiki / 3User preferences: Support easy opt-in/out after deployment - 10https://bugzilla.wikimedia.org/67883#c2 (10Tisza Gergő) IMO the obvious path for BetaFeatures is to become a feature switch framework, with options like "deploy to 1% of users", so those rules should be eventually relaxed. That said... [21:14:37] (03CR) 10Krinkle: [C: 032] Note that jquery.json will be removed in 1.25 [core] - 10https://gerrit.wikimedia.org/r/145679 (owner: 10Mattflaschen) [21:14:50] (03CR) 10Awight: [C: 032] "Thanks!" [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/144665 (owner: 10Raimond Spekking) [21:15:25] (03PS1) 10Welterkj: Add unit test hook and first unit test. [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/145689 [21:15:49] (03Merged) 10jenkins-bot: QUnit: Detect unfinished jQuery effects or ajax requests in teardown [core] - 10https://gerrit.wikimedia.org/r/145483 (owner: 10Krinkle) [21:16:10] (03CR) 10Krinkle: [C: 032] "translatewiki.net is still using it for a local hack" [core] - 10https://gerrit.wikimedia.org/r/145680 (owner: 10Ori.livneh) [21:16:32] 3MediaWiki / 3User preferences: Support easy opt-in/out after deployment - 10https://bugzilla.wikimedia.org/67883#c3 (10Tisza Gergő) > * an easy programmatic way to set enabled/disabled state, so that it works > both for logged-in users (stored in user preferences) and anons (stored in > localSettings, maybi... [21:17:47] (03Merged) 10jenkins-bot: Note that jquery.json will be removed in 1.25 [core] - 10https://gerrit.wikimedia.org/r/145679 (owner: 10Mattflaschen) [21:17:50] (03Abandoned) 10MaxSem: Boil the oceans and kill ResourceLoaderGetStartupModules [core] - 10https://gerrit.wikimedia.org/r/127177 (owner: 10MaxSem) [21:18:02] ori: Just checking, are you writing a patch for zuul-config? I can do it now [21:18:13] Krinkle, you beat me to it! :P [21:19:32] 3MediaWiki extensions / 3Translate: Translate extension uses misleading summary saying a page was created when it wasn't - 10https://bugzilla.wikimedia.org/67865#c3 (10Helder) 5RESO/INV>3REOP I don't think so. MediaWiki is certainly responsible by the edit summary of the page being *created*, but are you... [21:19:33] ori: It's not unlike eventlogging where you set up one thing, but it doesn't yet do the end result you want. The jenkins job is now created and can be run, but nothing runs it yet. [21:20:15] (03Merged) 10jenkins-bot: Remove ResourceLoaderGetStartupModules hook [core] - 10https://gerrit.wikimedia.org/r/145680 (owner: 10Ori.livneh) [21:20:16] MatmaRex: hahaah looks like that vector-type mixin has no impact whatsoever lol [21:20:45] nice, out with that mwembed mess [21:20:48] jdlrobso_: it seems to be called in some other things? or do you mean it's overriden later [21:21:00] MatmaRex: the typography refresh renders it obsolete [21:21:02] it gets overriden [21:21:09] deleting it all now :D [21:21:25] bleh [21:21:30] well, good thing we found out :P [21:22:29] superm401: but really though, we're not gonna remove jquery.json, are we :P [21:22:36] let's hope so [21:22:58] Krinkle, heh. If people complain, I'll just write a sed script to fix their entire site. ;) [21:23:02] tracking is active now http://codepen.io/Krinkle/full/zyodJ/ [21:23:13] superm401: how about you write that now and run it on wmf? [21:23:27] mwgrep | node replace.js --auth User:Krinkle [21:23:30] or whatever [21:23:50] Krinkle: btw, what is the unit on the vertical axis there... [21:23:55] (03PS1) 10Ori.livneh: add config for mediawiki/services/jobrunner [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/145692 [21:23:59] mwgrep ($|jQuery).toJSON && mwgrep ($|jQuery).toJSON --user | replace [21:24:03] Krinkle: like that ^^ ? [21:24:21] thedj: number of hits [21:24:25] thedj: hits per some unit of time. [21:24:27] no one knows what unit. [21:24:56] thedj: users are sampled 1/100 https://github.com/wikimedia/mediawiki-extensions-WikimediaEvents/blob/master/modules/ext.wikimediaEvents.deprecate.js [21:25:09] then for those users, every call to mw.deprecate is logged via EventLogging and countered here [21:25:16] then the counts are added up per second or per minute (not sure) [21:25:18] and displayed htere [21:25:27] k. [21:25:47] and then the daily numbers are either average per minute or max in on eminute [21:25:50] I'll send out an email note about it. [21:26:03] whatever summarize() does in graphite [21:26:22] YuviPanda, you there? It would be great to get the GitHub->Gerrit bridge working again? [21:26:41] superm401: hey [21:26:51] There's been some talk about it on Wikitech. [21:26:58] superm401: it's in decent condition, should probably not take me more than a few days to bring it back up... [21:27:08] superm401: I'll see if I can wrangle some time next week? [21:27:19] YuviPanda, great, thank you. :) [21:28:49] (03PS35) 10Bsitu: Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 [21:30:15] ori: Hi, when you have a minute, could you check https://bugzilla.wikimedia.org/show_bug.cgi?id=67670 ? [21:30:28] ori: AbuseFilter seemed to have a regression bug. [21:30:40] (03CR) 10Krinkle: [C: 032] add config for mediawiki/services/jobrunner [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/145692 (owner: 10Ori.livneh) [21:30:46] (03Merged) 10jenkins-bot: add config for mediawiki/services/jobrunner [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/145692 (owner: 10Ori.livneh) [21:31:15] whym: looking [21:32:36] (03PS2) 10Welterkj: Add unit test hook and first unit test. [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/145689 [21:32:38] (03CR) 10jenkins-bot: [V: 04-1] Add unit test hook and first unit test. [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/145689 (owner: 10Welterkj) [21:33:01] 3MediaWiki extensions / 3Translate: Translate extension uses misleading summary saying a page was created when it wasn't - 10https://bugzilla.wikimedia.org/67865#c4 (10Nemo) 5REOP>3RESO/INV All metadata of edits on translation pages is carried over from the corresponding edits on Translations namespace,... [21:33:47] ori: thanks :) [21:34:11] (03PS1) 10EBernhardson: Remove strip_tags warning on Special:RecentChanges [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145694 [21:38:30] (03PS1) 10Jorm: Initial commit of snowflakes. Change-Id: I1cc11944bc214a1aac0b1a63a09ad10cfbdba3df [winter/snowflakes] - 10https://gerrit.wikimedia.org/r/145695 [21:39:28] (03PS1) 10Jorm: Initial commit for the Winter prototype framework. Requires "snowflakes" depot as well. Change-Id: Iaccd065da15543214d4828d2d123526807242f5f [winter] - 10https://gerrit.wikimedia.org/r/145696 [21:41:11] jorm: you can set a global git ignore to affect all repos so you won't checkin .DS_Store files [21:41:45] (03PS3) 10Welterkj: Add unit test hook and first unit test. [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/145689 [21:42:02] also, that looks pretty cool [21:43:15] (03CR) 10Jorm: [C: 032 V: 032] Initial commit for the Winter prototype framework. Requires "snowflakes" depot as well. Change-Id: Iaccd065da15543214d4828d2d123526807242f5 [winter] - 10https://gerrit.wikimedia.org/r/145696 (owner: 10Jorm) [21:43:20] (03PS4) 10Umherirrender: SpecialEditWatchlist: Avoid empty namespace sections [core] - 10https://gerrit.wikimedia.org/r/143363 [21:43:33] 3MediaWiki extensions / 3Translate: Translate extension uses misleading summary saying a page was created when it wasn't - 10https://bugzilla.wikimedia.org/67865#c5 (10Helder) So it should use different metadata for these edits outside the Translations namespace, because this history doesn't makes sense: htt... [21:43:50] what looks pretty cool? [21:44:01] 3MediaWiki / 3Special pages: [[Special:RandomInCategory]] should support type (e.g. only file or only page) - 10https://bugzilla.wikimedia.org/67813#c1 (10Bawolff (Brian Wolff)) Current query doesn't have an index for that. [21:44:04] (03CR) 10Jorm: [C: 032 V: 032] Initial commit of snowflakes. Change-Id: I1cc11944bc214a1aac0b1a63a09ad10cfbdba3df [winter/snowflakes] - 10https://gerrit.wikimedia.org/r/145695 (owner: 10Jorm) [21:45:02] jorm: evil self commit! [21:45:05] (03PS36) 10Bsitu: Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 [21:45:07] legoktm: how do i do that? [21:45:07] s/commit/merge/ [21:45:13] * jorm evil. [21:45:30] jorm: in ~/.gitconfig: [21:45:30] [core] [21:45:31] excludesfile = /Users/km/.gitignore_global [21:45:43] the whole snowflakes system [21:45:45] (03CR) 10Welterkj: [C: 032] Add unit test hook and first unit test. [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/145689 (owner: 10Welterkj) [21:45:47] 3MediaWiki / 3JavaScript: QUnit tests for jquery.makeCollapsible and jquery.color failing intermittently on Jenkins - 10https://bugzilla.wikimedia.org/63579#c30 (10Matthew Flaschen) 5PATC>3RESO/FIX I disabled the GuidedTour GUI that was triggering this during tests (1e37db808e1f9cc8daffb61e4303ce53d701e2... [21:45:52] (03Merged) 10jenkins-bot: Add unit test hook and first unit test. [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/145689 (owner: 10Welterkj) [21:46:08] there's a lot that can be improved with how the snowflakes work. [21:46:08] obviously point that at whatever your username is :P [21:46:31] (03PS1) 10Ori.livneh: Fix double escaping in AFPData::keywordLike() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/145697 (https://bugzilla.wikimedia.org/67670) [21:46:43] whym: ^ [21:47:03] 3MediaWiki extensions / 3[other]: Add Special:RandomNotInCategory to Extension:RandomInCategory - 10https://bugzilla.wikimedia.org/67812#c1 (10Bawolff (Brian Wolff)) (In reply to Jan Ainali from comment #0) > Today there is [[Special:RandomInCategory]]. It would be useful to also have > the opposite function... [21:48:03] (03PS5) 10Alex Monk: Provide way for users to find articles with the automatic [extensions/Cite] - 10https://gerrit.wikimedia.org/r/145474 (https://bugzilla.wikimedia.org/67700) [21:48:37] (03PS1) 10Jdlrobson: Kill redundant vector stuff [core] - 10https://gerrit.wikimedia.org/r/145699 [21:48:39] (03PS1) 10Jdlrobson: Huge MediaWiki UI cleanup [core] - 10https://gerrit.wikimedia.org/r/145700 [21:48:44] (03PS18) 10Paladox: Update jQuery Cookie to v1.2.0 [core] - 10https://gerrit.wikimedia.org/r/145000 [21:49:09] (03PS18) 10Paladox: Update jquery.validate from 1.8.1 to 1.9.0 [core] - 10https://gerrit.wikimedia.org/r/145311 [21:49:15] (03CR) 10MarkTraceur: [C: 04-1] "Tests? :D" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/122086 (https://bugzilla.wikimedia.org/62897) (owner: 10Legoktm) [21:49:26] (03PS18) 10Paladox: Update jquery.ui-themes [core] - 10https://gerrit.wikimedia.org/r/145049 [21:49:31] 3MediaWiki extensions / 3PubSubHubbub: Performance review of PubSubHubbub extension - 10https://bugzilla.wikimedia.org/67117#c3 (10Aaron Schulz) * The delay could be in theory be based on the current max slave lag...but I simple approach would be to just pick a value. 10 seconds would be very safe under non-... [21:49:43] marktraceur: ohmy that's old [21:49:49] (03PS2) 10Ori.livneh: Fix double escaping in AFPData::keywordLike() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/145697 (https://bugzilla.wikimedia.org/67670) [21:50:17] 3MediaWiki extensions / 3Translate: Translate extension uses misleading summary saying a page was created when it wasn't - 10https://bugzilla.wikimedia.org/67865#c6 (10Nemo) (In reply to Helder from comment #5) > So it should use different metadata for these edits outside the Translations > namespace No it... [21:50:19] ^d: I'm wondering what magic I'm missing here: https://gerrit.wikimedia.org/r/#/c/143793/ [21:50:32] Seems like that should have made it onto a train? [21:50:36] legoktm: Not that old. I'm going from the top of my review queue down. [21:51:00] <^d> awight: That gets it branched & included in the next one, yeah. [21:51:03] (03Abandoned) 10Mattflaschen: Fix spurious QUnit failures related to fake timers [core] - 10https://gerrit.wikimedia.org/r/145479 (https://bugzilla.wikimedia.org/63579) (owner: 10Mattflaschen) [21:51:31] 3Wikimedia / 3SSL related: Enable HTTPS for dumps.wikimedia.org - 10https://bugzilla.wikimedia.org/58292#c8 (10Daniel Zahn) even though that change has been merged you won't see a difference, the templates being touched are not actually applied, see my last comment on the gerrit change [21:51:34] <^d> awight: Unless the brancher didn't git pull the latest config :p [21:52:02] 3MediaWiki extensions / 3AbuseFilter: Breaking change in AbuseFilter's "like" operator - 10https://bugzilla.wikimedia.org/67670#c4 (10Yusuke Matsubara) Sorry for not including this first, but "+" seems to need the same fix. "a+b" like "a+b" => false [21:52:31] 3MediaWiki extensions / 3Translate: PythonSingleFFS fails under HHVM - 10https://bugzilla.wikimedia.org/67870#c1 (10Ori Livneh) Thanks for the report. Could you var_dump() the value of $json after the wfShellExec() invocation and the value of $parsed after the FormatJson::decode() invocation? [21:53:32] ori: "+" seems to need the same fix. [21:53:56] (03CR) 10MarkTraceur: [C: 032] "Well, whatever, this looks fine. Thanks, Nischay!" [core] - 10https://gerrit.wikimedia.org/r/64556 (https://bugzilla.wikimedia.org/37109) (owner: 10Nischayn22) [21:54:27] ori: did you see the last https://bugzilla.wikimedia.org/show_bug.cgi?id=67670 comment? [21:55:28] AaronSchulz, whym: no, I missed that comment. I'll amend the patch. [21:55:41] sorry 'bout that. [21:56:20] 3MediaWiki extensions / 3[other]: Add Special:RandomNotInCategory to Extension:RandomInCategory - 10https://bugzilla.wikimedia.org/67812#c2 (10Chad H.) Should be able to just replicate what we did for Special:Random but with a namespace filter. Inverting that filter is trivial. [21:56:20] 3MediaWiki / 3Special pages: Special:Version shows jumbled localized parser extension tags on he.wp - 10https://bugzilla.wikimedia.org/67840#c1 (10Bawolff (Brian Wolff)) Hmm. weird, I didn't think we localized parser tags. Anyways, caused by using the htmlentities escaping function (Why would we use that f... [21:56:54] ^d: k sorry, it is indeed in today's branch release. [21:56:58] (03PS37) 10Bsitu: Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 [21:57:02] (03PS2) 10Jdlrobson: Simplify MediaWiki UI codebase [core] - 10https://gerrit.wikimedia.org/r/145699 [21:57:04] ^ MatmaRex i went a bit crazy in the end :) [21:57:04] <^d> awight: Okie dokie :) [21:57:04] (03PS1) 10Jdlrobson: One mixin file to rule them all. [core] - 10https://gerrit.wikimedia.org/r/145701 [21:57:16] (03PS3) 10Ori.livneh: Fix double escaping in AFPData::keywordLike() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/145697 (https://bugzilla.wikimedia.org/67670) [21:58:03] (03PS1) 10Dduvall: Skip already configured settings during setup [vagrant] - 10https://gerrit.wikimedia.org/r/145702 [21:58:15] ori: ^ [21:58:16] 3MediaWiki / 3JavaScript: Bugs caught by mw.loader.inspect() (tracking) - 10https://bugzilla.wikimedia.org/55683 (10Nemo) [21:58:18] marxarelli: bless your heart [21:58:38] jdlrobso_: hah. i think i like what i'm seeing :) [21:58:38] ori: grandma? [21:58:47] ;) [21:58:54] although made one mistake :) [21:59:18] jdlrobso_: i'll probably review in detail tomorrow, and i wouldn't mind if someone else commented before we merge these too [21:59:20] (03PS2) 10Physikerwelt: Displaystyle in Mathoid 0.2.5 [extensions/Math] - 10https://gerrit.wikimedia.org/r/145335 [21:59:27] (03Merged) 10jenkins-bot: jquery.arrowSteps: Center arrowheads text [core] - 10https://gerrit.wikimedia.org/r/64556 (https://bugzilla.wikimedia.org/37109) (owner: 10Nischayn22) [21:59:31] 3MediaWiki extensions / 3Translate: Translate extension uses misleading summary saying a page was created when it wasn't - 10https://bugzilla.wikimedia.org/67865#c7 (10Helder) Yep. It was me. But I don't get it. There are two edits being made, only one of which is creating a page, so only one of them should... [21:59:37] marxarelli: in fact "--grandma" mode should keep prompting you for already-configured settings [21:59:50] ori: awesome [22:00:12] (03PS2) 10Jdlrobson: Huge MediaWiki UI cleanup [core] - 10https://gerrit.wikimedia.org/r/145700 [22:00:21] (03Abandoned) 10Jdlrobson: Huge MediaWiki UI cleanup [core] - 10https://gerrit.wikimedia.org/r/145700 (owner: 10Jdlrobson) [22:00:22] Eloquence: got a sec? [22:00:38] marxarelli: any reason not to make it true by default? [22:00:51] (03PS3) 10Jdlrobson: Simplify MediaWiki UI codebase [core] - 10https://gerrit.wikimedia.org/r/145699 [22:00:59] Added h- ids to the headings on the graphite report [22:01:00] http://s.codepen.io/Krinkle/fullpage/zyodJ#h-legacy.wikibits [22:01:04] MatmaRex: Finally going down [22:01:05] (03CR) 10jenkins-bot: [V: 04-1] Displaystyle in Mathoid 0.2.5 [extensions/Math] - 10https://gerrit.wikimedia.org/r/145335 (owner: 10Physikerwelt) [22:01:18] MatmaRex: changed summary from 1d to 7d and range from 3 weeks to 3 months [22:01:27] Krinkle: wow, that's awesome [22:01:29] traffic fluctuation tends to be the same each week [22:01:29] it's like NORAD! [22:02:14] hehe, set up in a weekend a few weeks back. Been makinr small changes each week and this is what I wanted it to be [22:02:25] AaronSchulz, whym: updated [22:02:25] ori: only that i couldn't think of a name for the flag to make it false... [22:02:33] T13|mobile, what's up [22:02:39] (03CR) 10Nemo bis: "Thanks for docs! http://www.mediawiki.org/w/index.php?title=Help:Magic_words&diff=next&oldid=1059148" [core] - 10https://gerrit.wikimedia.org/r/144870 (https://bugzilla.wikimedia.org/50449) (owner: 10Jackmcbarn) [22:02:48] I just read your comment on the arbcom thing and was wondering if you might consider striking the word 'core' as it is an extension (http://www.mediawiki.org/wiki/Extension:MultimediaViewer ) before some overly technical person calls you out on it. [22:02:53] marxarelli: '--all'? [22:03:07] good point... [22:03:14] (03CR) 10Physikerwelt: "Originally the idea to have a valid default option (without css styles loaded at all beeing set) came from Gabriel and seemed like a good " [extensions/Math] - 10https://gerrit.wikimedia.org/r/145453 (owner: 10Physikerwelt) [22:03:24] should --required just skip configured settings? [22:03:27] ori: to edit / http://codepen.io/Krinkle/full/zyodJ/ / http://codepen.io/Krinkle/pen/zyodJ/ [22:03:28] T13|mobile: "core" as in "basic", I think - viewing images is a "core" part of the software Wikimedia supports [22:03:29] that seems reasonable [22:03:32] (or rather, view source/fork) [22:03:32] Up to you, but wouldn't want to see any more bad faith thrown around. [22:03:39] (03PS38) 10Bsitu: Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 [22:03:41] That's how I read it anyway [22:03:46] http://codepen.io/Krinkle/pen/zyodJ/?editors=001 [22:04:13] (03PS1) 10Brian Wolff: Use htmlspecialchars not htmlentities to escape tags on Version. [core] - 10https://gerrit.wikimedia.org/r/145704 (https://bugzilla.wikimedia.org/67840) [22:04:24] ori: though you wouldn't be able to reconfigured just required settings. i bet LOTS of people are going to want that [22:04:25] We should all go back to calling core, "phase3" [22:04:28] too much confusion [22:04:35] greg-g: Is it reasonable to deploy a configuration change to testwiki, it being Friday and all? [22:04:59] I only mention it because I dealt with similar criticism when I said parsoid/VE was a core component. [22:05:02] T13|mobile, heya -- if the issue comes up, I'll clarify: I mean "core site feature" in the sense that clicking an image to enlarge it , is a fundamental interaction, not that it's implemented in mediawiki/core. I have a full checkout of MultimediaViewer and am aware of how it's implemented, though I have yet to submit any patches against it :) [22:05:04] Also, arbcom is involved in this? I guess I put my popcorn away way to soon [22:05:06] <^d> awight: New extension on Friday? Nooooooo :( [22:05:25] <^d> bawolff: I should've called it phase4 when we moved to git. [22:05:27] ^d: yeah I do have anxiety that I'd be merging to a deployment branch [22:05:29] * marktraceur determined not to let Eloquence break more multimedia extensions [22:05:30] <^d> #lostopportunity [22:05:34] :P [22:05:35] :) [22:05:41] marktraceur, you can always -2 me ;) [22:05:57] I'll keep *that* IRC quote in my back pocket [22:06:34] (03CR) 10Whym: [C: 031] "Thanks, Ori, it works for me." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/145697 (https://bugzilla.wikimedia.org/67670) (owner: 10Ori.livneh) [22:07:25] I need some help with a gerrit SSH authentication problem [22:07:25] ^d: seems like a really sketchy process, if I am understanding it correctly. Merge to production branch in order to deploy a test change?? [22:07:27] debug1: Offering RSA public key: /home/gtisza/.keys/tgr.key [22:07:27] debug1: Server accepts key: pkalg ssh-rsa blen 149 [22:07:27] Received disconnect from 208.80.154.81: 2: Too may authentication failures [22:07:47] does this mean that gerrit would accept the key but the public and private key does not match? [22:08:03] awight: why testwiki? [22:08:07] the command was ssh -vp 29418 tgr@gerrit.wikimedia.org [22:08:48] greg-g: what's the alternative? I want to test the configuration change. I've done plenty of local testing of my extension itself. [22:08:57] beta cluster [22:09:02] greg-g: aha, ok thx [22:09:13] when you think "test" think "beta cluster" :) [22:09:26] (03PS1) 10EBernhardson: Log more information about beta issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145706 [22:09:42] greg-g: that is probably a sentence that should appear on the testwiki main page! [22:09:46] i keep reading "T13|mobile" as "T-Mobile" [22:10:10] (03PS2) 10EBernhardson: Log more information about beta issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145706 [22:10:53] (03CR) 10EBernhardson: [C: 032] "debugging broken pages in beta labs" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145706 (owner: 10EBernhardson) [22:12:15] greg-g: seems like the same trap, btw: I have to merge my operations/mediawiki-config changes to master before testing on the beta cluster? [22:12:56] but it's a no-op on prod [22:12:56] <^d> jorm: Good company. Great customer service. Here's hoping they survive a second buyout attempt. [22:12:59] (03PS4) 10Jdlrobson: Simplify MediaWiki UI codebase [core] - 10https://gerrit.wikimedia.org/r/145699 [22:13:06] (03PS2) 10Ori.livneh: apache: add site_conf; make conf more like operations/puppet [vagrant] - 10https://gerrit.wikimedia.org/r/145052 [22:13:42] greg-g: oh? are we cherry-picking config to a deployment branch on prod? [22:13:58] * awight is almost indoctrinated [22:14:00] no [22:14:06] one second, in meeting [22:14:08] why a no-op then? [22:14:08] k [22:14:23] awight: what's the change? [22:14:32] 3MediaWiki / 3Skin and page rendering: Replace "Thumbnail size" property in preferences with responsive resizing images - 10https://bugzilla.wikimedia.org/67695#c7 (10Bawolff (Brian Wolff)) > > For HiDPI devices we could serve an image which is the correct dimensions at > the right pixel density or the reg... [22:14:36] awight: there are labs-specific config settings which don't get loaded in prod [22:14:44] ori: https://gerrit.wikimedia.org/r/#/c/141607/ [22:14:46] awight: if you sequester your change in those files, nothing in prod should be affected [22:14:49] * ori looks [22:15:29] ori: okay, that makes sense. I'll rewrite the predecessor patch to only affect beta. [22:15:41] awight: yeah, make changes to InitialiseSettings-labs.php [22:16:35] ori: great, thanks [22:17:24] (03PS5) 10Jdlrobson: Kill modules/new/styles/forms.less [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144168 [22:19:13] Thanks jorm... [22:20:21] is jenkins stuck? waiting on a gate-and-submit for ~9 minutes now [22:21:01] oh, its in zull its just waiting in line... [22:21:02] (03CR) 10MarkTraceur: [C: 031] "This is looking cool - what's still WIP in it? Just implementing it somewhere?" [core] - 10https://gerrit.wikimedia.org/r/92315 (owner: 10Bartosz Dziewoński) [22:21:19] Tethro Zuul [22:22:32] zuul claims its been running a parser test against 145704 for ~15 minutes [22:22:40] greg-g: ori explained the beta config process to me, here's the patch if you're curious, https://gerrit.wikimedia.org/r/#/c/145703 [22:22:58] awight: but you're touching non-labs files, too [22:23:14] ori: ok, I'll fix. [22:23:18] if you touch non-labs files, then you have to sync them, even if they're a no-op [22:23:28] so you're back to needing a deployment [22:23:37] I don't suppose you guys keep any records/data on who tries a beta feature and then turns it back off, do you? [22:24:03] (03PS1) 10Bsitu: Update topic sorting copy text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145709 [22:24:09] T13|mobile, I think there is preference logging, don't know the latest details. [22:25:03] (03CR) 10Ori.livneh: [C: 032] Update installer image for Wikimania 2014 [vagrant] - 10https://gerrit.wikimedia.org/r/144413 (owner: 10BryanDavis) [22:25:30] I'm just wondering if such records could be used to turn the feature off for those people that have already decided they didn't like it when it goes from beta to live. [22:26:42] ori, seems to be an issue with the apt-cache to cache/apt migration. [22:26:46] May be an edge case. [22:26:47] First I get: [22:26:48] 3MediaWiki extensions / 3Scribunto: Profiling report should contain a column counting total time function was on the call stack - 10https://bugzilla.wikimedia.org/67893 (10Jackmcbarn) 3NEW p:3Unprio s:3enhanc a:3None In the profiling report, in addition to the column containing the time spent in indi... [22:26:55] "GuestAdditions versions on your host (4.1.18) and guest (4.3.10) do not match." [22:27:03] Food for thought - I need to catch a bus. [22:27:24] It looks like it might be trying to fix that, then I get "/vagrant/apt-cache/partial is missing" [22:27:58] I'm going to workaroudn it manually. [22:29:32] (03PS2) 10Dduvall: Skip already configured settings during setup [vagrant] - 10https://gerrit.wikimedia.org/r/145702 [22:29:44] Basically, though, it seemed that apt wasn't finding out about the move early enough in this flow. [22:29:45] (03CR) 10MarkTraceur: [C: 04-1] "Small issue, going to try rebasing to see if this will work based on master" (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/110238 (https://bugzilla.wikimedia.org/59955) (owner: 10Mno2) [22:30:17] (03CR) 10MarkTraceur: "As I suspected/feared - we need to rebase this. It doesn't strike me as a bad idea, though. I'll add Pau to the review." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/110238 (https://bugzilla.wikimedia.org/59955) (owner: 10Mno2) [22:32:36] (03CR) 10MarkTraceur: "Pau, here's a screenshot:" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/110238 (https://bugzilla.wikimedia.org/59955) (owner: 10Mno2) [22:32:57] (03CR) 10Bsitu: Remove strip_tags warning on Special:RecentChanges (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145694 (owner: 10EBernhardson) [22:33:06] (03CR) 10MarkTraceur: "Or if James has a more different designer he wants to loop in, I dunno." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/110238 (https://bugzilla.wikimedia.org/59955) (owner: 10Mno2) [22:34:42] (03CR) 10EBernhardson: Remove strip_tags warning on Special:RecentChanges (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145694 (owner: 10EBernhardson) [22:35:45] (03PS2) 10EBernhardson: Remove strip_tags warning on Special:RecentChanges [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145694 [22:38:02] (03CR) 10Bsitu: [C: 032] Remove strip_tags warning on Special:RecentChanges [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145694 (owner: 10EBernhardson) [22:40:02] (03PS19) 10Paladox: Update jQuery Cookie to v1.2.0 [core] - 10https://gerrit.wikimedia.org/r/145000 [22:43:17] (03PS19) 10Paladox: Update jquery.ui-themes [core] - 10https://gerrit.wikimedia.org/r/145049 [22:43:29] (03PS20) 10Paladox: Update jquery.ui-themes [core] - 10https://gerrit.wikimedia.org/r/145049 [22:43:53] (03PS19) 10Paladox: Update jquery.validate from 1.8.1 to 1.9.0 [core] - 10https://gerrit.wikimedia.org/r/145311 [22:44:01] (03PS20) 10Paladox: Update jquery.validate from 1.8.1 to 1.9.0 [core] - 10https://gerrit.wikimedia.org/r/145311 [22:44:53] (03PS1) 10Mattflaschen: QUnit testrunner: Fix comment regarding animation and AJAX check [core] - 10https://gerrit.wikimedia.org/r/145712 [22:45:29] (03PS1) 10Isarra: Contrast fixes and dt styling [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/145713 [22:45:47] (03PS23) 10Paladox: Update jquery.chosen folder and files [core] - 10https://gerrit.wikimedia.org/r/139699 [22:46:12] (03PS58) 10Paladox: Update jquery.hoverintent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [22:46:34] (03CR) 10Isarra: [C: 032 V: 032] "Bloody gerrit." [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/145713 (owner: 10Isarra) [22:46:39] (03PS8) 10Paladox: Update TimedText [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144675 [22:47:21] (03PS6) 10Paladox: mediawiki.searchSuggest: Enable for iPhone and iPod touch [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/143320 [22:50:42] (03PS1) 10Isarra: Add dt styles, remove silly footer font, fix catlinks [skins/Splash] - 10https://gerrit.wikimedia.org/r/145714 [22:51:12] (03PS2) 10Krinkle: QUnit testrunner: Fix comment regarding animation and AJAX check [core] - 10https://gerrit.wikimedia.org/r/145712 (owner: 10Mattflaschen) [22:51:18] (03CR) 10Krinkle: [C: 032] QUnit testrunner: Fix comment regarding animation and AJAX check [core] - 10https://gerrit.wikimedia.org/r/145712 (owner: 10Mattflaschen) [22:51:31] (03CR) 10Isarra: [C: 032 V: 032] "LA LA LA." [skins/Splash] - 10https://gerrit.wikimedia.org/r/145714 (owner: 10Isarra) [22:53:41] (03CR) 10Krinkle: [C: 04-1] "Hm.. these tests don't vary by language. Maybe fix the language in the test config?" [core] - 10https://gerrit.wikimedia.org/r/145571 (owner: 10Thiemo Mättig (WMDE)) [22:55:46] 3Wikimedia / 3General/Unknown: bits.wikimedia.org discourages indexing, resulting in goofy archive.org snapshots - 10https://bugzilla.wikimedia.org/65464#c6 (10Nemo) 5RESO/?>3VERI It does look better. http://web.archive.org/web/20140711225404/http://it.wikipedia.org/wiki/Pagina_principale [22:57:01] uh oh, Isarra is singing [22:57:43] (03CR) 10Krinkle: [C: 04-1] "As I've said before, backports require RELEASE-NOTES to justify the change. Usually a bug or regression only. MediaWiki 1.23 has already b" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/143320 (owner: 10Paladox) [22:58:44] (03CR) 10Krinkle: Update jquery.hoverintent to 1.8.0 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/139687 (owner: 10Paladox) [23:00:03] (03CR) 10Krinkle: [C: 04-1] "Can't find any usage in mediawiki-core which makes this a little harder to test/verify. Once someone's verified it, it should also have re" [core] - 10https://gerrit.wikimedia.org/r/139687 (owner: 10Paladox) [23:00:14] (03PS59) 10Krinkle: Update jquery.hoverIntent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 (owner: 10Paladox) [23:00:26] (03CR) 10Jforrester: "I think Brandon's the nominal Design lead for BetaFeatures, though it's been a quiet period of late." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/110238 (https://bugzilla.wikimedia.org/59955) (owner: 10Mno2) [23:00:52] https://gerrit.wikimedia.org/r/#/c/145357/ [23:00:52] (03PS1) 10Bsitu: Special:Flow is not working [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145715 [23:01:01] (03PS2) 10Krinkle: installer: Move Server/Extension/Path preparations out of envChecks [core] - 10https://gerrit.wikimedia.org/r/145356 (https://bugzilla.wikimedia.org/67810) [23:01:07] (03PS3) 10Krinkle: installer: Recompute wgStylePath etc. after setting wgScriptPath [core] - 10https://gerrit.wikimedia.org/r/145357 (https://bugzilla.wikimedia.org/67810) [23:05:50] 3MediaWiki-Vagrant: Guest Additions 4.1.18 won't install on Trusty - 10https://bugzilla.wikimedia.org/67899 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3Ori Livneh Created attachment 15916 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15916&action=edit Error log from failed build of vboxgu... [23:06:09] (03PS5) 10Jforrester: Update OOjs UI to v0.1.0-pre (3ba36b9a53) [core] - 10https://gerrit.wikimedia.org/r/144901 (owner: 10Trevor Parscal) [23:06:19] (03Abandoned) 10Isarra: (Bug 44854) Add shadows to the content in Vector [core] - 10https://gerrit.wikimedia.org/r/50594 (owner: 10Isarra) [23:07:11] (03Abandoned) 10Isarra: (bug 61010) Add IE support to vertical-gradient mixin. [core] - 10https://gerrit.wikimedia.org/r/112066 (owner: 10Isarra) [23:07:32] (03PS1) 10Bsitu: Update Flow occupation copy [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145716 [23:08:53] (03CR) 10Jforrester: maintenance: Exclude OOjs UI's new RTL built CSS files from the pull-through (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143632 (owner: 10Jforrester) [23:08:57] (03PS3) 10Jforrester: maintenance: Exclude OOjs UI's new RTL built CSS files from the pull-through [core] - 10https://gerrit.wikimedia.org/r/143632 [23:11:47] 3Wikimedia / 3Site requests: Increase default image thumb size - 10https://bugzilla.wikimedia.org/49357#c7 (10Vogone) Shouldn't this apply to all MediaWiki installations if implemented, meaning not only to Wikimedia projects? [23:11:47] This is why I love Wikipedia [23:11:48] https://en.wikipedia.org/wiki/%F0%9F%8D%A7 [23:12:01] We have redirects for rare unicode characters to their respective subjects [23:12:12] about the actual subject, not the character [23:13:04] Even better when the system renders the icon of course [23:13:07] http://i.imgur.com/4osLNWT.png] [23:13:08] (03PS1) 10Isarra: Fix up headers and stuff [skins/Mask] - 10https://gerrit.wikimedia.org/r/145718 [23:13:09] http://i.imgur.com/4osLNWT.png [23:13:20] (03CR) 10Trevor Parscal: [C: 032] maintenance: Exclude OOjs UI's new RTL built CSS files from the pull-through [core] - 10https://gerrit.wikimedia.org/r/143632 (owner: 10Jforrester) [23:13:24] (03CR) 10Jorm: "How about just "X people have enabled this." ?" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/110238 (https://bugzilla.wikimedia.org/59955) (owner: 10Mno2) [23:13:47] Krinkle: https://en.wikipedia.org/wiki/%F0%9F%92%A9 [23:14:49] legoktm: beat me to it [23:14:56] (03CR) 10MarkTraceur: "James_F, the feature thing could probably be fixed by adding an option for the users message, which is the feature one by default." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/110238 (https://bugzilla.wikimedia.org/59955) (owner: 10Mno2) [23:15:33] (03CR) 10Isarra: [C: 032 V: 032] "ARGH." [skins/Mask] - 10https://gerrit.wikimedia.org/r/145718 (owner: 10Isarra) [23:17:11] (03CR) 10EBernhardson: Log more information about beta issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145706 (owner: 10EBernhardson) [23:17:18] (03CR) 10EBernhardson: [C: 032] Log more information about beta issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145706 (owner: 10EBernhardson) [23:19:31] 3Wikimedia / 3Site requests: Increase default image thumb size - 10https://bugzilla.wikimedia.org/49357#c8 (10Greg Grossmeier) I think that is the ultimate plan, yes [23:21:25] (03CR) 10Krinkle: [C: 032] Log more information about beta issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145706 (owner: 10EBernhardson) [23:22:05] (03CR) 10EBernhardson: Log more information about beta issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145706 (owner: 10EBernhardson) [23:22:24] (03CR) 10EBernhardson: [C: 032] Log more information about beta issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145706 (owner: 10EBernhardson) [23:22:54] (03Merged) 10jenkins-bot: Log more information about beta issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145706 (owner: 10EBernhardson) [23:25:50] (03CR) 10Krinkle: [C: 032] maintenance: Exclude OOjs UI's new RTL built CSS files from the pull-through [core] - 10https://gerrit.wikimedia.org/r/143632 (owner: 10Jforrester) [23:26:01] (03CR) 10Krinkle: [C: 032] QUnit testrunner: Fix comment regarding animation and AJAX check [core] - 10https://gerrit.wikimedia.org/r/145712 (owner: 10Mattflaschen) [23:26:16] 3Wikimedia / 3Site requests: Increase default image thumb size - 10https://bugzilla.wikimedia.org/49357#c9 (10James Forrester) (In reply to Vogone from comment #7) > Shouldn't this apply to all MediaWiki installations if implemented, meaning > not only to Wikimedia projects? Bug 67703 is the bug for making... [23:26:40] (03CR) 10Krinkle: [C: 032] "(re-submit CR+2 as Jenkins was restarted)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145694 (owner: 10EBernhardson) [23:28:15] (03CR) 10Krinkle: [C: 032] "(re-submit CR+2 as Jenkins was restarted)" [vagrant] - 10https://gerrit.wikimedia.org/r/144413 (owner: 10BryanDavis) [23:28:28] <^d> James_F: If we agree to do it in core then we don't even need a WMF config change :) [23:28:36] <^d> (re: image sizes) [23:28:38] (03Merged) 10jenkins-bot: Remove strip_tags warning on Special:RecentChanges [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145694 (owner: 10EBernhardson) [23:29:07] (03Merged) 10jenkins-bot: Update installer image for Wikimania 2014 [vagrant] - 10https://gerrit.wikimedia.org/r/144413 (owner: 10BryanDavis) [23:29:46] (03CR) 10Jforrester: "> James_F, the feature thing could probably be fixed by adding an option for the users message, which is the feature one by default." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/110238 (https://bugzilla.wikimedia.org/59955) (owner: 10Mno2) [23:30:06] (03Merged) 10jenkins-bot: maintenance: Exclude OOjs UI's new RTL built CSS files from the pull-through [core] - 10https://gerrit.wikimedia.org/r/143632 (owner: 10Jforrester) [23:30:40] (03CR) 10MarkTraceur: "It would be a separate message, configurable in the constructor. :)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/110238 (https://bugzilla.wikimedia.org/59955) (owner: 10Mno2) [23:30:53] (03Merged) 10jenkins-bot: QUnit testrunner: Fix comment regarding animation and AJAX check [core] - 10https://gerrit.wikimedia.org/r/145712 (owner: 10Mattflaschen) [23:34:32] 3MediaWiki-Vagrant: Guest Additions 4.1.18 won't install on Trusty - 10https://bugzilla.wikimedia.org/67899#c1 (10Bryan Davis) VirtualBox 4.1.18 was released Jun 20th 2012, so it's not surprising that the guest additions code that goes along with it has compilation issues on an OS that was released nearly two... [23:34:55] greg-g: last thing. I'm on tin and have verified that I'm merging my config change and nothing else. Can I sync-dir wmf-config? [23:35:53] (03PS1) 10EBernhardson: Add more debug logging for beta issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145720 [23:36:06] (03CR) 10EBernhardson: [C: 032] Add more debug logging for beta issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145720 (owner: 10EBernhardson) [23:36:36] (03Merged) 10jenkins-bot: Add more debug logging for beta issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145720 (owner: 10EBernhardson) [23:37:55] (03CR) 10Chad: "Couple of nitpicky-type stuff inline, otherwise ok." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/145356 (https://bugzilla.wikimedia.org/67810) (owner: 10Krinkle) [23:38:22] (03CR) 10Bartosz Dziewoński: "Mostly. I was expecting some feedback that would prompt me to change/improve the behavior, but that didn't happen. Needs rebase though." [core] - 10https://gerrit.wikimedia.org/r/92315 (owner: 10Bartosz Dziewoński) [23:38:46] 3MediaWiki-Vagrant: Method of switching PHP versions from Vagrant CLI - 10https://bugzilla.wikimedia.org/52303#c5 (10Bryan Davis) phpenv (https://github.com/phpenv/phpenv) provides an interesting way to install and manage multiple php interpreters. I have used it in the past to setup build and test servers for... [23:39:47] 3Wikimedia / 3Site requests: Complete unification of all accounts to SUL - 10https://bugzilla.wikimedia.org/35707 (10Bryan Davis) p:5Normal>3Highes [23:40:09] (03PS5) 10Jdlrobson: WIP: Replace flow-ui- classes with mw-ui- classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144164 [23:40:12] (03PS1) 10Jdlrobson: Standardise output of preview and cancel buttons across templates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145721 [23:40:32] 3Wikimedia / 3Site requests: Increase default image thumb size - 10https://bugzilla.wikimedia.org/49357#c10 (10Jared Zimmerman (WMF)) JamesF logged that bug and it got closed as a duplicate of this one. But yes the goal is that it affect wikimedia wikis and or the default on mediaeiki as well [23:40:41] (03CR) 10jenkins-bot: [V: 04-1] WIP: Replace flow-ui- classes with mw-ui- classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144164 (owner: 10Jdlrobson) [23:41:00] greg-g still around? [23:41:18] we're wondering where to file bugs about the build failures. Wikimedia -> Quality Assurance? [23:41:47] (03PS1) 10Isarra: Set up resources directory, add normalise stuff directly to skin [skins/Mask] - 10https://gerrit.wikimedia.org/r/145723 [23:42:09] (03PS2) 10Jdlrobson: Rethink our use of media queries. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144847 [23:42:28] (03CR) 10Isarra: [C: 032 V: 032] "ALL LOOKS GOOD FROM HERE. YES, YES, THIS IS A FERTILE LAND..." [skins/Mask] - 10https://gerrit.wikimedia.org/r/145723 (owner: 10Isarra) [23:46:39] well somebody is having fun [23:47:19] (03CR) 10Krinkle: Site logo loaded using ResourceLoaderSiteModule instead of inline (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98356 (https://bugzilla.wikimedia.org/56257) (owner: 10Tholam) [23:47:32] 3Wikimedia / 3Site requests: Complete unification of all accounts to SUL - 10https://bugzilla.wikimedia.org/35707 (10Kunal Mehta (Legoktm)) [23:47:48] 3Wikimedia / 3General/Unknown: Audit centralauth database for inconsistencies - 10https://bugzilla.wikimedia.org/67350 (10Kunal Mehta (Legoktm)) [23:47:48] 3MediaWiki extensions / 3CentralAuth: Rename of global (attached) users to existing global usernames - 10https://bugzilla.wikimedia.org/47918 (10Kunal Mehta (Legoktm)) [23:47:48] 3MediaWiki extensions / 3CentralAuth: Identify extensions that need updates to work with user merging - 10https://bugzilla.wikimedia.org/67758 (10Kunal Mehta (Legoktm)) [23:48:20] (03PS1) 10Brian Wolff: Have Title::makeTitleSafe decode html entities. [core] - 10https://gerrit.wikimedia.org/r/145724 (https://bugzilla.wikimedia.org/67196) [23:49:18] (03PS3) 10Ori.livneh: apache: add site_conf; make conf more like operations/puppet [vagrant] - 10https://gerrit.wikimedia.org/r/145052 [23:49:24] (03CR) 10Ori.livneh: [C: 032] apache: add site_conf; make conf more like operations/puppet [vagrant] - 10https://gerrit.wikimedia.org/r/145052 (owner: 10Ori.livneh) [23:49:50] (03Merged) 10jenkins-bot: apache: add site_conf; make conf more like operations/puppet [vagrant] - 10https://gerrit.wikimedia.org/r/145052 (owner: 10Ori.livneh) [23:50:17] 3Wikimedia / 3Site requests: Complete unification of all accounts to SUL - 10https://bugzilla.wikimedia.org/35707 (10Kunal Mehta (Legoktm)) [23:50:20] 3MediaWiki extensions / 3CentralAuth: Add config setting to prevent creation of new unattached accounts - 10https://bugzilla.wikimedia.org/67901 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Currently if there are existing unattached accounts, and you try and create an account with that... [23:50:37] (03CR) 10Krinkle: "There are various inline comments. On the current patch set from Dec 2013 that still apply." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98356 (https://bugzilla.wikimedia.org/56257) (owner: 10Tholam) [23:51:02] 3MediaWiki extensions / 3CentralAuth: Add config setting to prevent creation of new unattached accounts - 10https://bugzilla.wikimedia.org/67901#c1 (10Kunal Mehta (Legoktm)) (In reply to Kunal Mehta (Legoktm) from comment #0) > Currently if there are existing unattached accounts, and you try and create > an... [23:54:07] (03PS1) 10Ori.livneh: Clean-up migrated cache directories [vagrant] - 10https://gerrit.wikimedia.org/r/145725 [23:54:20] (03CR) 10Ori.livneh: [C: 032] Clean-up migrated cache directories [vagrant] - 10https://gerrit.wikimedia.org/r/145725 (owner: 10Ori.livneh) [23:54:25] (03Merged) 10jenkins-bot: Clean-up migrated cache directories [vagrant] - 10https://gerrit.wikimedia.org/r/145725 (owner: 10Ori.livneh) [23:59:26] (03CR) 10Krinkle: Site logo loaded using ResourceLoaderSiteModule instead of inline (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98356 (https://bugzilla.wikimedia.org/56257) (owner: 10Tholam) [23:59:47] 3MediaWiki / 3Skin and page rendering: Replace "Thumbnail size" property in preferences with responsive resizing images - 10https://bugzilla.wikimedia.org/67695#c8 (10Jared Zimmerman (WMF)) Brian, yep that's a good point, we'll want to be smart around things like establishing minimum and maximum widths based... [23:59:51] (03PS1) 10Ori.livneh: Typo fix for I291e870c8 [vagrant] - 10https://gerrit.wikimedia.org/r/145726