[00:02:18] 3MediaWiki / 3JavaScript: Set $wgLegacyJavaScriptGlobals = false by default - 10https://bugzilla.wikimedia.org/33837#c14 (10Krinkle) A replacement table is not needed for there is no individual migration or deprecation related to this matter. The deprecation here is about all mw.config values. They are curr... [00:03:58] (03CR) 10Gergő Tisza: "Tested by setting" [core] - 10https://gerrit.wikimedia.org/r/135008 (https://bugzilla.wikimedia.org/67525) (owner: 10Gilles) [00:05:22] <^d> MatmaRex: Mind poking a change for me? I think you were doing something similar. https://gerrit.wikimedia.org/r/#/c/144622/ [00:06:46] 3MediaWiki / 3JavaScript: Set $wgLegacyJavaScriptGlobals = false by default - 10https://bugzilla.wikimedia.org/33837#c15 (10Krinkle) @Technical 13: It's good that you're starting to migrate this. However don't feel like you're rushing at the last minute. These were deprecated years ago but they're very easy... [00:07:28] ^d: i don't think i was doing things like that, but sure [00:07:39] <^d> Oh, I thought you were poking something with test leakage. [00:07:42] <^d> Maybe it was someone else :) [00:08:02] 3MediaWiki / 3ResourceLoader: ResourceLoader: Implied global function not a global function outside debug mode - 10https://bugzilla.wikimedia.org/46582 (10Krinkle) [00:08:02] 3MediaWiki / 3ResourceLoader: ResourceLoader: Debug mode should not execute scripts in the global scope - 10https://bugzilla.wikimedia.org/62605 (10Krinkle) [00:08:11] ^d: i talked to you about it, but did nothing :D [00:08:16] 3MediaWiki / 3ResourceLoader: ResourceLoader: Remove obsolete closures from files - 10https://bugzilla.wikimedia.org/48886#c3 (10Krinkle) s:5normal>3enhanc Note that this bug isn't blocked on implementing global variable mappings. This bug basically says: * Closures added by ResourceLoader are not mere... [00:09:55] (03CR) 10Bartosz Dziewoński: [C: 032] "Tests pass? SHIP IT" [core] - 10https://gerrit.wikimedia.org/r/144622 (owner: 10Chad) [00:10:22] <^d> https://gerrit.wikimedia.org/r/#/c/144611/ is pretty trivial and didn't break tests either :p [00:13:05] (03Merged) 10jenkins-bot: Limit test leakage, $wgCapitalLinks expected to be true [core] - 10https://gerrit.wikimedia.org/r/144622 (owner: 10Chad) [00:17:33] (03CR) 10Krinkle: [C: 04-1] "Add tests :)" [core] - 10https://gerrit.wikimedia.org/r/144171 (https://bugzilla.wikimedia.org/67448) (owner: 10Alex Monk) [00:17:55] (03PS1) 10Aaron Schulz: Fixed acquireForMe() bug in the redis module [core] - 10https://gerrit.wikimedia.org/r/144623 [00:18:39] (03CR) 10Krinkle: mw.Title: Add function to get title relative to an arbitrary namespace (031 comment) [core] - 10https://gerrit.wikimedia.org/r/144171 (https://bugzilla.wikimedia.org/67448) (owner: 10Alex Monk) [00:22:00] (03CR) 10Bartosz Dziewoński: On redirect, actually update URL to the target page with JavaScript (038 comments) [core] - 10https://gerrit.wikimedia.org/r/143852 (https://bugzilla.wikimedia.org/35045) (owner: 10Bartosz Dziewoński) [00:22:17] (03PS3) 10Bartosz Dziewoński: On redirect, actually update URL to the target page with JavaScript [core] - 10https://gerrit.wikimedia.org/r/143852 (https://bugzilla.wikimedia.org/35045) [00:26:21] (03CR) 10jenkins-bot: [V: 04-1] On redirect, actually update URL to the target page with JavaScript [core] - 10https://gerrit.wikimedia.org/r/143852 (https://bugzilla.wikimedia.org/35045) (owner: 10Bartosz Dziewoński) [00:32:51] (03CR) 1020after4: "I mostly submitted this here just to get it into the repo. I'll push it upstream for review but this is just an initial proof of concept a" [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/144620 (owner: 1020after4) [00:33:37] (03CR) 10Krinkle: "Confirmed by setting $wgCapitalLinks = false; in LocalSettings and running the tests before this commit. They fail. And pass with this com" [core] - 10https://gerrit.wikimedia.org/r/144622 (owner: 10Chad) [00:35:16] (03CR) 10Krinkle: [C: 04-1] "Hm.. This module isn't supposed to work in non-ES5 environments anyhow though. Look at the logic around buildRequiresES5. Perhaps add Fun" [core] - 10https://gerrit.wikimedia.org/r/144601 (owner: 10Mattflaschen) [00:41:03] 3MediaWiki / 3Unit tests: AutoloaderTest doesn't like namespaces - 10https://bugzilla.wikimedia.org/67644 (10Chad H.) 3NEW p:3Unprio s:3normal a:3None It doesn't like when you use similar named classes to core. You get this: - 'Http' => 'includes/HttpFunctions.php' + 'Http' => '/vagrant/mediaw... [00:44:02] (03CR) 10Parent5446: [C: 04-1] "See comments from PS3 and PS6." [core] - 10https://gerrit.wikimedia.org/r/140765 (https://bugzilla.wikimedia.org/66762) (owner: 10MaxSem) [00:46:16] 3MediaWiki / 3JavaScript: Set $wgLegacyJavaScriptGlobals = false by default - 10https://bugzilla.wikimedia.org/33837#c16 (10Technical 13) Thank you for the clarification Krinkle. I do believe all my scripts already use mw.config.get('wgXX'). Thank you for also assuring me there will be some time to find and... [00:46:23] (03PS1) 10Ori.livneh: HHVM: configure as default PHP [vagrant] - 10https://gerrit.wikimedia.org/r/144625 [00:47:06] (03CR) 10MaxSem: "As stated in my reposnse to your comments, this causes the very breakage you reported." [core] - 10https://gerrit.wikimedia.org/r/140765 (https://bugzilla.wikimedia.org/66762) (owner: 10MaxSem) [00:49:20] (03CR) 10Bartosz Dziewoński: On redirect, actually update URL to the target page with JavaScript (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143852 (https://bugzilla.wikimedia.org/35045) (owner: 10Bartosz Dziewoński) [00:51:46] (03CR) 10Ejegg: [C: 032] Hideous workaround to customize translate workflow permissions [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/141595 (owner: 10Awight) [00:51:55] (03Merged) 10jenkins-bot: Hideous workaround to customize translate workflow permissions [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/141595 (owner: 10Awight) [00:52:04] 3MediaWiki extensions / 3CirrusSearch: Search for "Thielt" doesn't find "Tielt" without redirect - 10https://bugzilla.wikimedia.org/67645 (10Chad H.) 3NEW p:3Unprio s:3normal a:3None https://en.wikipedia.org/w/index.php?title=Special:Search&search=Thielt&fulltext=1&srbackend=CirrusSearch and https... [00:52:58] (03PS4) 10Bartosz Dziewoński: On redirect, actually update URL to the target page with JavaScript [core] - 10https://gerrit.wikimedia.org/r/143852 (https://bugzilla.wikimedia.org/35045) [00:56:10] (03CR) 10Chad: "Error: /usr/bin/update-alternatives --set php /usr/bin/hhvm returned 2 instead of one of [0]" [vagrant] - 10https://gerrit.wikimedia.org/r/144625 (owner: 10Ori.livneh) [00:57:31] 3MediaWiki extensions / 3CirrusSearch: Search for "Thielt" doesn't find "Tielt" without redirect - 10https://bugzilla.wikimedia.org/67645#c1 (10Krinkle) Since Thielt -> Tielt was created as a redirect by me. Updated example: https://de.wikipedia.org/w/index.php?title=Special:Search&search=Thielt&fulltext=1&... [00:58:30] (03PS2) 10Ori.livneh: HHVM: configure as default PHP [vagrant] - 10https://gerrit.wikimedia.org/r/144625 [00:58:36] ^demon|food: sorry, can you try again? [00:59:06] <^demon|food> Trying [00:59:09] (03CR) 10CSteipp: "Although I appreciate what you're trying to do in this patch, it seems like this isn't quite the way to accomplish it. wgCookieExpiration " (031 comment) [core] - 10https://gerrit.wikimedia.org/r/141248 (https://bugzilla.wikimedia.org/66699) (owner: 10Phuedx) [01:00:55] (03CR) 10Chad: [C: 032] "Much better!" [vagrant] - 10https://gerrit.wikimedia.org/r/144625 (owner: 10Ori.livneh) [01:01:01] (03Merged) 10jenkins-bot: HHVM: configure as default PHP [vagrant] - 10https://gerrit.wikimedia.org/r/144625 (owner: 10Ori.livneh) [01:01:02] :) thanks [01:01:06] <^demon|food> yw [01:01:08] <^demon|food> Now, food. [01:01:09] <^demon|food> :) [01:01:17] ^demon|actually-food [01:05:41] (03CR) 10Ori.livneh: [C: 032] "thanks" [vagrant] - 10https://gerrit.wikimedia.org/r/144415 (owner: 10BryanDavis) [01:05:58] (03Merged) 10jenkins-bot: Fix 'stdin: is not a tty' [vagrant] - 10https://gerrit.wikimedia.org/r/144415 (owner: 10BryanDavis) [01:06:46] (03PS3) 10BryanDavis: Add psr/log 1.0.0 [core/vendor] - 10https://gerrit.wikimedia.org/r/136473 [01:07:00] (03PS3) 10BryanDavis: Add monolog/monolog 1.9.1 [core/vendor] - 10https://gerrit.wikimedia.org/r/136474 [01:11:19] (03PS8) 10Bartosz Dziewoński: Allow skins to define skinStyles for arbitrary modules [core] - 10https://gerrit.wikimedia.org/r/141259 [01:13:46] (03PS1) 10EBernhardson: Preview in close topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144627 (https://bugzilla.wikimedia.org/67379) [01:23:18] 3MediaWiki / 3Skin and page rendering: [[MediaWiki:Showingresultsheader]] is badly positioned depending on the window and text size - 10https://bugzilla.wikimedia.org/67649 (10Helder) 3NEW p:3Unprio s:3enhanc a:3None Created attachment 15868 --> https://bugzilla.wikimedia.org/attachment.cgi?id=1586... [01:25:01] 3MediaWiki / 3Skin and page rendering: [[MediaWiki:Showingresultsheader]] is badly positioned depending on the window and text size - 10https://bugzilla.wikimedia.org/67649#c1 (10Chad H.) Is this a dupe of bug 67184? If so it's already fixed in master. [01:29:17] (03PS3) 10Danielrenfro: Breaking out disallowed CSS into a global variable [core] - 10https://gerrit.wikimedia.org/r/144249 (https://bugzilla.wikimedia.org/11106) [01:30:17] (03CR) 10Danielrenfro: "I (partially) disagree with the comment proposed by CSteipp, who commented that preg_quote() should be used to escape any regular expressi" [core] - 10https://gerrit.wikimedia.org/r/144249 (https://bugzilla.wikimedia.org/11106) (owner: 10Danielrenfro) [01:35:47] 3MediaWiki / 3Skin and page rendering: [[MediaWiki:Showingresultsheader]] is badly positioned depending on the window and text size - 10https://bugzilla.wikimedia.org/67649#c2 (10Helder) 5NEW>3RESO/DUP Yep! *** This bug has been marked as a duplicate of bug 67184 *** [01:35:47] 3MediaWiki / 3Search: Search results number overlap the border of the grey background - 10https://bugzilla.wikimedia.org/67184#c7 (10Helder) *** Bug 67649 has been marked as a duplicate of this bug. *** [01:52:06] (03CR) 10Daniel Friesen: On redirect, actually update URL to the target page with JavaScript (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143852 (https://bugzilla.wikimedia.org/35045) (owner: 10Bartosz Dziewoński) [02:01:19] 3MediaWiki / 3Skin and page rendering: Unified approach for skin extensions - 10https://bugzilla.wikimedia.org/43658#c3 (10Bartosz Dziewoński) 5UNCO>3RESO/FIX a:3Bartosz Dziewoński I believe that we can consider this done: see the list of changes I made and documentation I created at https://www.mediaw... [02:15:46] 3MediaWiki extensions / 3Spam Blacklist: Under HHVM: Fatal error: Argument 1 passed to AbstractContent::getParserOutput() must be an instance of Title, null given - 10https://bugzilla.wikimedia.org/66930 (10Max Semenik) 5PATC>3NEW [02:25:31] 3MediaWiki / 3Parser: Multiline code tag results in strange html - 10https://bugzilla.wikimedia.org/66655#c1 (10Jackmcbarn) 5UNCO>3NEW The output in the description happens when Tidy is enabled. When it's disabled, this happens instead: 

foo() bar()

Note that i... [02:43:47] 3MediaWiki / 3Parser: Wrong keys of Title::$titleCache as result of Title::newFromText() is not canonical - 10https://bugzilla.wikimedia.org/47282#c2 (10Jackmcbarn) (In reply to Sergey Nevmerzhitsky from comment #0) > "tEST", "Test" and "TEST" direct to one canonical title key "Test". This isn't the case. "t... [02:58:04] 3MediaWiki / 3Unit tests: HHVM crash running extension tests - 10https://bugzilla.wikimedia.org/67652 (10Max Semenik) 3NEW p:3Unprio s:3normal a:3None Assertion failure: 0 data block = afrozen message: Attempted to emit 85 byte(s) into a 78 byte DataBlock with 78 bytes available. This almost certainl... [03:00:38] (03PS1) 10Pastakhov: fix usage as a function (v 2.0.2) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/144629 [03:15:55] (03PS2) 10TTO: Change name of Tahitian language [core] - 10https://gerrit.wikimedia.org/r/140312 (https://bugzilla.wikimedia.org/65985) [03:19:56] (03PS2) 10TTO: Add additional interwiki links as requested in various bugs [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/141099 (https://bugzilla.wikimedia.org/43027) [03:20:33] (03CR) 10TTO: "I got rid of CompleteList and ProjectPortal. The other additions are perfectly tame." [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/141099 (https://bugzilla.wikimedia.org/43027) (owner: 10TTO) [03:22:50] 3MediaWiki extensions / 3WikidataRepo: wikibase.domready hook not firing properly? - 10https://bugzilla.wikimedia.org/67654 (10Kunal Mehta (Legoktm)) 3UNCO p:3Unprio s:3normal a:3Wikidata bugs I'm not sure whether what I think is the bug is actually the bug. But in any case, this is related to https... [03:29:47] 3MediaWiki extensions / 3WikidataRepo: wikibase.domready hook not firing properly? - 10https://bugzilla.wikimedia.org/67654#c1 (10User:JesseW) 5UNCO>3NEW Confirmed on Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20140319 Firefox/24.0 Iceweasel/24.4.0 (Debian 3.2.54-2 x86_64). [03:31:26] (03PS1) 10Chad: Force default search backend on search test [core] - 10https://gerrit.wikimedia.org/r/144630 [03:41:48] (03CR) 10Chad: "Actually, it's not really because we differ in behavior. It's because we're completely abusing MediaWiki to write a test. We should not be" [core] - 10https://gerrit.wikimedia.org/r/144630 (owner: 10Chad) [03:43:58] ^demon|food: so...should I still merge ^ ? [03:44:13] <^demon|food> I'm kind of angry that this test even exists. [03:44:15] (03PS1) 10tosfos: major code rewrite [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/144631 [03:44:28] (03CR) 10Legoktm: [C: 032] Force default search backend on search test [core] - 10https://gerrit.wikimedia.org/r/144630 (owner: 10Chad) [03:44:51] Well I take that as you won't get even angrier if the test has 3 more lines. [03:44:58] (03Abandoned) 10Chad: Force default search backend on search test [core] - 10https://gerrit.wikimedia.org/r/144630 (owner: 10Chad) [03:45:14] :< [03:45:21] lol [03:45:53] <^demon|food> https://gerrit.wikimedia.org/r/#/c/144611/ needs a review and involves no anger :) [03:46:41] (03CR) 10Legoktm: [C: 032] Convert CleanUpTest to use data providers [core] - 10https://gerrit.wikimedia.org/r/144611 (owner: 10Chad) [03:47:24] (03PS2) 10tosfos: major code rewrite [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/144631 [03:50:07] (03PS2) 10Brian Wolff: Launch videos in VLC app on iOS if installed [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144349 (https://bugzilla.wikimedia.org/61095) [03:51:16] (03Merged) 10jenkins-bot: Convert CleanUpTest to use data providers [core] - 10https://gerrit.wikimedia.org/r/144611 (owner: 10Chad) [03:51:42] vagrant doesn't have a role for wikibase repo? :( [03:52:10] (03PS3) 10tosfos: major code rewrite [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/144631 [03:54:20] (03CR) 10tosfos: [C: 031 V: 032] major code rewrite [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/144631 (owner: 10tosfos) [03:57:21] jackmcbarn: aude started one a while back: https://gerrit.wikimedia.org/r/#/c/132628/ [03:57:59] it was missing something, but now i don't remember what [04:01:14] (03CR) 10Brian Wolff: "Brion: Thank you for testing this." (034 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144349 (https://bugzilla.wikimedia.org/61095) (owner: 10Brian Wolff) [04:04:09] (03CR) 10Ori.livneh: [C: 032] Fixed acquireForMe() bug in the redis module [core] - 10https://gerrit.wikimedia.org/r/144623 (owner: 10Aaron Schulz) [04:04:49] (03PS4) 10Ori.livneh: Lowered the default OPT_READ_TIMEOUT for Redis [core] - 10https://gerrit.wikimedia.org/r/144422 (owner: 10Aaron Schulz) [04:05:55] (03PS2) 10Ori.livneh: Provide a default password for the Fundraising Drupal admin user [vagrant] - 10https://gerrit.wikimedia.org/r/144252 (owner: 10Awight) [04:05:59] (03CR) 10Ori.livneh: [C: 032] Provide a default password for the Fundraising Drupal admin user [vagrant] - 10https://gerrit.wikimedia.org/r/144252 (owner: 10Awight) [04:07:52] (03Merged) 10jenkins-bot: Fixed acquireForMe() bug in the redis module [core] - 10https://gerrit.wikimedia.org/r/144623 (owner: 10Aaron Schulz) [04:08:57] (03Merged) 10jenkins-bot: Provide a default password for the Fundraising Drupal admin user [vagrant] - 10https://gerrit.wikimedia.org/r/144252 (owner: 10Awight) [04:09:48] (03CR) 10Ori.livneh: "I'm a bit lost. What branch does the other wiki (the non-payments one) need to be on?" [vagrant] - 10https://gerrit.wikimedia.org/r/135326 (owner: 10Awight) [04:13:33] (03PS2) 10Brian Wolff: Android native browser ending playback after 1 second [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144352 (https://bugzilla.wikimedia.org/43748) [04:23:30] (03CR) 10Brion VIBBER: "Yeah, I can live with the popup error when you don't have VLC installed. :) But the weird thing is that I keep getting the prompt to insta" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144349 (https://bugzilla.wikimedia.org/61095) (owner: 10Brian Wolff) [04:27:24] agh something didn’t update properly [04:28:32] (03PS1) 10Pastakhov: add useful functions class (v 3.1.1) [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/144632 [04:29:38] (03CR) 10Brian Wolff: "Hmm, I guess we could do something like var d = (new Date()).getTime(); then do that again in the handler, and say if its been more than a" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144349 (https://bugzilla.wikimedia.org/61095) (owner: 10Brian Wolff) [04:30:14] (03CR) 10Brion VIBBER: "Actually, something's wrong with my install and it's not giving me the updated JS. Need to poke at it and test again..." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144349 (https://bugzilla.wikimedia.org/61095) (owner: 10Brian Wolff) [04:31:14] (03CR) 10Pastakhov: [C: 032] add useful functions class (v 3.1.1) [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/144632 (owner: 10Pastakhov) [04:31:20] (03Merged) 10jenkins-bot: add useful functions class (v 3.1.1) [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/144632 (owner: 10Pastakhov) [04:33:51] 3MediaWiki / 3Unit tests: Something in unit tests is doing something funky with the session - 10https://bugzilla.wikimedia.org/67656 (10Chad H.) 3NEW p:3Unprio s:3normal a:3None I've been getting this for quite some time. First on OSX then on Vagrant. I've been hitting my head against the wall. Some... [04:33:55] <^demon|food> Weird ass freaking bug. [04:34:49] (03PS1) 10Legoktm: Load AntiSpoof for CA "extension" in a $wgExtensionFunctions [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144633 [04:37:00] <^demon|food> Narrowing it to a single test or group of tests would be nice. [04:48:22] (03PS6) 10Divec: Simple GET API to fetch translations [services/cxserver] - 10https://gerrit.wikimedia.org/r/143832 [04:49:38] (03CR) 10jenkins-bot: [V: 04-1] Simple GET API to fetch translations [services/cxserver] - 10https://gerrit.wikimedia.org/r/143832 (owner: 10Divec) [04:54:07] (03CR) 10Brion VIBBER: [C: 04-1] "Per testing & IRC convo: bump the timeout up from 600ms to 1000ms and it removes the false positive install prompts on my iPad Air. \o/ Ev" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144349 (https://bugzilla.wikimedia.org/61095) (owner: 10Brian Wolff) [04:58:22] (03PS7) 10Divec: Simple GET API to fetch translations [services/cxserver] - 10https://gerrit.wikimedia.org/r/143832 [04:59:19] (03CR) 10jenkins-bot: [V: 04-1] Simple GET API to fetch translations [services/cxserver] - 10https://gerrit.wikimedia.org/r/143832 (owner: 10Divec) [05:03:46] (03PS3) 10Brian Wolff: Launch videos in VLC app on iOS if installed [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144349 (https://bugzilla.wikimedia.org/61095) [05:04:01] (03PS8) 10Divec: Simple GET API to fetch translations [services/cxserver] - 10https://gerrit.wikimedia.org/r/143832 [05:05:20] (03CR) 10jenkins-bot: [V: 04-1] Simple GET API to fetch translations [services/cxserver] - 10https://gerrit.wikimedia.org/r/143832 (owner: 10Divec) [05:09:04] (03PS9) 10Divec: Simple GET API to fetch translations [services/cxserver] - 10https://gerrit.wikimedia.org/r/143832 [05:11:12] (03PS10) 10Divec: Simple GET API to fetch translations [services/cxserver] - 10https://gerrit.wikimedia.org/r/143832 [05:21:17] (03PS2) 10Pastakhov: fix usage as a function (v 2.0.2) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/144629 [05:22:09] (03CR) 10Brion VIBBER: [C: 032] "Woo, works for me :D +2" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144349 (https://bugzilla.wikimedia.org/61095) (owner: 10Brian Wolff) [05:29:12] (03PS1) 10BryanDavis: Fix Exec['refresh_conf_symlinks'] [vagrant] - 10https://gerrit.wikimedia.org/r/144635 [05:29:38] (03PS2) 10BryanDavis: Fix Exec['refresh_conf_symlinks'] [vagrant] - 10https://gerrit.wikimedia.org/r/144635 [05:29:47] (03CR) 10BryanDavis: [C: 032] Fix Exec['refresh_conf_symlinks'] [vagrant] - 10https://gerrit.wikimedia.org/r/144635 (owner: 10BryanDavis) [05:29:52] (03Merged) 10jenkins-bot: Fix Exec['refresh_conf_symlinks'] [vagrant] - 10https://gerrit.wikimedia.org/r/144635 (owner: 10BryanDavis) [05:41:51] 3MediaWiki extensions / 3[other]: Huggle deployment on tr-wiki - 10https://bugzilla.wikimedia.org/67658 (10superyetkin) 3UNCO p:3Unprio s:3normal a:3None Hello there, We have reached community consensus on enabling Huggle on tr-wiki. The realted discussion can be found at https://tr.wikipedia.org/w/... [05:46:45] (03PS1) 10Brian Wolff: Override CSS link colour in pop up video [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144639 [05:51:27] (03PS11) 10Divec: Simple GET API to fetch translations [services/cxserver] - 10https://gerrit.wikimedia.org/r/143832 [05:53:32] 3MediaWiki / 3JavaScript: Previously chosen sort column not kept as 'second level' comparison for next sort - 10https://bugzilla.wikimedia.org/67558#c4 (10Dave Yost) If it's useful to re-sort the table in the original order, then provide a column numbered by the original order. (This should probably be stand... [05:55:32] (03PS3) 10Brian Wolff: Make play button have higher z-index so its clickable. [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/108637 [06:17:17] 3MediaWiki extensions / 3WikidataRepo: "more" link in entity selector does not work the first time on main page - 10https://bugzilla.wikimedia.org/67600#c1 (10Henning) 5ASSI>3PATC https://gerrit.wikimedia.org/r/#/c/142510/ [06:21:17] 3MediaWiki / 3JavaScript: Previously chosen sort column not kept as 'second level' comparison for next sort - 10https://bugzilla.wikimedia.org/67558#c5 (10Dave Yost) BTW, the URL example I gave, with its red-yellow-green table cell values, is a classic example where the table is ready to go for filtering by... [06:29:02] (03CR) 10Brian Wolff: "Small follow-up gerrit change 144639 (Some css gets overriden if your viewing in the pop up in a dialog viewer)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144349 (https://bugzilla.wikimedia.org/61095) (owner: 10Brian Wolff) [06:38:57] (03PS1) 10Brian Wolff: rm $wgCountTotalSearchHits. It was broken. [core] - 10https://gerrit.wikimedia.org/r/144642 [06:40:26] (03PS2) 10Brian Wolff: rm $wgCountTotalSearchHits. It was broken. [core] - 10https://gerrit.wikimedia.org/r/144642 [06:58:32] 3Wikimedia / 3Extension setup: Review and deploy PubSubHubbubExtension - 10https://bugzilla.wikimedia.org/67623 (10Dereckson) [06:58:34] 3Wikimedia / 3Bugzilla: Add component for PubSubHubbub - 10https://bugzilla.wikimedia.org/67661 (10Dereckson) 3NEW p:3Unprio s:3trivia a:3None A review for WMF extension use consideration is currently requested for the PubSubHubbub extension. Could you create a component for it? Product: MediaWiki e... [07:02:17] 3MediaWiki / 3Unit tests: Something in unit tests is doing something funky with the session - 10https://bugzilla.wikimedia.org/67656#c1 (10Antoine "hashar" Musso) PHPUnit does catch exceptions, since you might want to write a test that assert an exception is thrown. Using either --debug or --tap shows the t... [07:02:53] (03PS12) 10Divec: Simple GET API to fetch translations [services/cxserver] - 10https://gerrit.wikimedia.org/r/143832 [07:06:37] (03PS1) 10Legoktm: [WIP] Global merge tool [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144644 [07:25:16] (03CR) 10Fomafix: "This generates a self-closing div:" [core] - 10https://gerrit.wikimedia.org/r/143548 (https://bugzilla.wikimedia.org/67184) (owner: 10Chad) [07:26:24] (03PS13) 10Divec: Simple GET API to fetch translations [services/cxserver] - 10https://gerrit.wikimedia.org/r/143832 [07:30:03] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/133997 (https://bugzilla.wikimedia.org/52674) (owner: 10Gerrit Patch Uploader) [07:37:29] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 (owner: 10Paladox) [07:40:43] (03CR) 10Rjain: "I haven't tested it but it looks good to me except that there is whitespace error." (031 comment) [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/144418 (owner: 10Drobbins) [07:42:15] (03CR) 10Siebrand: [C: 032] fix usage as a function (v 2.0.2) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/144629 (owner: 10Pastakhov) [07:42:22] (03Merged) 10jenkins-bot: fix usage as a function (v 2.0.2) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/144629 (owner: 10Pastakhov) [07:51:58] (03PS1) 10Raimond Spekking: Fux syntax error [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144645 [07:52:16] (03CR) 10Raimond Spekking: [C: 032] Fux syntax error [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144645 (owner: 10Raimond Spekking) [07:52:18] 3Wikimedia / 3Git/Gerrit: Gerrit SSH: Intermittent key_verify failed for server_host_key and 'hash mismatch' - 10https://bugzilla.wikimedia.org/53895#c30 (10christian) 5PATC>3RESO/FIX The fix has been deployed at gerrit.wikimedia.org. [07:52:22] (03Merged) 10jenkins-bot: Fux syntax error [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144645 (owner: 10Raimond Spekking) [07:53:28] (03CR) 10Siebrand: "Nice typo in commit message" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144645 (owner: 10Raimond Spekking) [07:53:56] (03CR) 10Raimond Spekking: "Syntax fix" (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144349 (https://bugzilla.wikimedia.org/61095) (owner: 10Brian Wolff) [07:54:26] (03CR) 10Siebrand: Launch videos in VLC app on iOS if installed (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144349 (https://bugzilla.wikimedia.org/61095) (owner: 10Brian Wolff) [07:58:47] (03CR) 10Siebrand: [C: 032] Change name of Tahitian language [core] - 10https://gerrit.wikimedia.org/r/140312 (https://bugzilla.wikimedia.org/65985) (owner: 10TTO) [08:02:26] (03Merged) 10jenkins-bot: Change name of Tahitian language [core] - 10https://gerrit.wikimedia.org/r/140312 (https://bugzilla.wikimedia.org/65985) (owner: 10TTO) [08:03:51] (03PS1) 10Withoutaname: Enforce some type hinting in Linker class [core] - 10https://gerrit.wikimedia.org/r/144646 [08:06:57] (03CR) 10Siebrand: [C: 04-1] API method to change page language (032 comments) [core] - 10https://gerrit.wikimedia.org/r/143025 (owner: 10Kunalgrover05) [08:09:42] (03PS1) 10Withoutaname: Enforce type hinting for RequestContext::setTitle() [core] - 10https://gerrit.wikimedia.org/r/144647 [08:11:31] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/143049 (owner: 10Kunalgrover05) [08:12:07] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/138652 (https://bugzilla.wikimedia.org/66440) (owner: 10Bartosz Dziewoński) [08:14:00] (03CR) 10Siebrand: [C: 04-1] Enforce type hinting for RequestContext::setTitle() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/144647 (owner: 10Withoutaname) [08:17:10] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/143061 (owner: 10Jackmcbarn) [08:18:43] (03CR) 10Siebrand: [C: 031] Cleanup - lets make IDEs more useful [core] - 10https://gerrit.wikimedia.org/r/144246 (owner: 10Yurik) [08:19:33] (03PS4) 10Taueres: Web installer: check for low PHP versions before executing [core] - 10https://gerrit.wikimedia.org/r/144440 [08:21:07] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/144334 (https://bugzilla.wikimedia.org/53778) (owner: 10BryanDavis) [08:23:24] (03CR) 10Paladox: "Hi I just copied the messages for EmbedPlayer I did not create them and I had a look at there qqq messages none are updated." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 (owner: 10Paladox) [08:28:09] (03PS1) 10Withoutaname: Enforce type hint for HTMLForm and use ContextSource for mTitle [core] - 10https://gerrit.wikimedia.org/r/144648 [08:29:39] (03CR) 10Withoutaname: Enforce type hinting for RequestContext::setTitle() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/144647 (owner: 10Withoutaname) [08:31:09] (03PS2) 10Withoutaname: Enforce type hinting for RequestContext::setTitle() [core] - 10https://gerrit.wikimedia.org/r/144647 [08:33:46] (03PS13) 10Kunalgrover05: Backend method for Special:PageLanguage, purge on language change [core] - 10https://gerrit.wikimedia.org/r/143049 [08:46:01] (03PS14) 10Divec: Simple GET API to fetch translations [services/cxserver] - 10https://gerrit.wikimedia.org/r/143832 [08:46:03] (03PS5) 10Divec: Markup-preserving wrapper for Apertium [services/cxserver] - 10https://gerrit.wikimedia.org/r/143257 [08:51:32] 3MediaWiki extensions / 3OAI: OAI does not pass Jenkins tests (sqlite compatibility) - 10https://bugzilla.wikimedia.org/65895#c6 (10Antoine "hashar" Musso) p:5High>3Low Not sure how to fix that one. The OAI `updates` table has a `ut_page` as a primary key and `ut_sequence` with auto_increment. Seems SQL... [08:51:46] 3Wikimedia / 3Bugzilla: Add component for PubSubHubbub - 10https://bugzilla.wikimedia.org/67661#c1 (10Sebastian Brückner) Yes, we are. [08:53:03] (03CR) 10Nikerabbit: [C: 032] Update cxserver and node_modules [services/cxserver/deploy] - 10https://gerrit.wikimedia.org/r/144145 (owner: 10KartikMistry) [08:56:44] How will I send a curl post request to an API ? suppose I have an API bouncehandler and it should recieve a $_POST[ 'mail' ] directly from the exim command line ? [08:57:10] (03PS7) 10Pginer: mediawiki.ui: Introduce grid system [core] - 10https://gerrit.wikimedia.org/r/125387 [08:57:26] I gave something like curl -d "action=bouncehandler" --data-urlencode "mail@- http://localhost/core/api.php [08:57:32] but it doesn't seem to wrok [08:59:35] (03PS8) 10Nikerabbit: mediawiki.ui: Introduce grid system [core] - 10https://gerrit.wikimedia.org/r/125387 (owner: 10Pginer) [09:00:01] (03CR) 10Nikerabbit: [C: 031] "Sprinkled some whitespace" [core] - 10https://gerrit.wikimedia.org/r/125387 (owner: 10Pginer) [09:01:22] (03CR) 10Nikerabbit: [C: 032] Update README.md with update instructions [services/cxserver/deploy] - 10https://gerrit.wikimedia.org/r/144147 (owner: 10KartikMistry) [09:14:14] (03PS14) 10Kunalgrover05: Backend method for Special:PageLanguage, purge on language change [core] - 10https://gerrit.wikimedia.org/r/143049 [09:18:02] (03CR) 10Nikerabbit: "My gut feeling is that people have started to rely on null titles being ignored silently. This could show up as fatal errors in many place" [core] - 10https://gerrit.wikimedia.org/r/144646 (owner: 10Withoutaname) [09:23:16] 3MediaWiki extensions / 3Popups: Hovercards: Use a link interpreter instead of title attribute - 10https://bugzilla.wikimedia.org/67466 (10Prateek Saxena) p:5Unprio>3High s:5normal>3enhanc [09:26:17] 3MediaWiki / 3Internationalization: Change name of Tahitian language from "Reo Mā`ohi" to "reo mā’ohi" - 10https://bugzilla.wikimedia.org/65985#c7 (10This, that and the other) 5PATC>3RESO/FIX Done. The change should make it onto Wikipedia late next week. [09:46:57] (03PS1) 10Gerrit Patch Uploader: Use Html::element instead of Xml::element for empty elements [core] - 10https://gerrit.wikimedia.org/r/144654 [09:46:59] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/144654 (owner: 10Gerrit Patch Uploader) [09:56:17] (03PS1) 1001tonythomas: Added API to handle incoming emails automatically [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/144656 [09:58:17] 3MediaWiki / 3General/Unknown: Extensions missing REL1_23 branches - 10https://bugzilla.wikimedia.org/67270#c39 (10Andre Klapper) Thanks everybody for your work on fixing this! [09:59:32] 3Wikimedia / 3Fundraising: Misc.: Amazon Payments prompts to change password - 10https://bugzilla.wikimedia.org/67603 (10Andre Klapper) p:5Unprio>3Normal [09:59:46] 3MediaWiki / 3Special pages: PHP Fatal error: Cannot use object of type stdClass as array in MobileFrontend.hooks.php on line 304 - 10https://bugzilla.wikimedia.org/67596 (10Andre Klapper) p:5Unprio>3High [10:04:01] 3MediaWiki / 3Categories: Reconsider trimming of file names in category overview - 10https://bugzilla.wikimedia.org/67599 (10Andre Klapper) p:5Unprio>3Normal [10:04:46] 3MediaWiki / 3Maintenance scripts: Can't render large page when using hhvm - 10https://bugzilla.wikimedia.org/67625 (10Andre Klapper) p:5Unprio>3High [10:05:32] 3MediaWiki / 3Page editing: Resubmission of section=new edit is not being detected - 10https://bugzilla.wikimedia.org/67634 (10Andre Klapper) p:5Unprio>3Normal [10:08:29] (03Abandoned) 10Divec: DONT MERGE: Apertium interface client module [services/cxserver] - 10https://gerrit.wikimedia.org/r/141641 (owner: 10Divec) [10:08:40] (03PS1) 10Matthias Mullie: Get rid of anon warning's negative top margin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144661 [10:08:43] (03PS1) 10Matthias Mullie: Error messages can contains HTML [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144662 [10:08:46] (03PS1) 10Matthias Mullie: Various flow_error fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144663 [10:08:49] (03PS1) 10Matthias Mullie: ConfirmEdit, captcha version [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144664 (https://bugzilla.wikimedia.org/59835) [10:09:05] (03Abandoned) 10Matthias Mullie: [WIP] ConfirmEdit, captcha version [extensions/Flow] - 10https://gerrit.wikimedia.org/r/138332 (https://bugzilla.wikimedia.org/59835) (owner: 10Matthias Mullie) [10:14:32] (03PS1) 10Raimond Spekking: Load i18n file [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/144665 [10:15:43] (03CR) 10Raimond Spekking: "See follow up Icf4408ebd4a5db2ca0469780d07b1cc9d88b985d for loading the i18n files" [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/141595 (owner: 10Awight) [10:16:19] 3Wikimedia / 3Git/Gerrit: REST API page on Gerrit loads prettify.js and .css over HTTP - 10https://bugzilla.wikimedia.org/67667 (10chmarkine) 3UNCO p:3Unprio s:3normal a:3None https://gerrit.wikimedia.org/r/Documentation/rest-api.html loads: * http://cdnjs.cloudflare.com/ajax/libs/prettify/r298/pret... [10:18:33] 3MediaWiki extensions / 3Cite: Cite: If there's no block on the page, show one automatically below the content rather than showing an error - 10https://bugzilla.wikimedia.org/66860#c14 (10Gadget850) So- reopen this bug or open a new one? [10:20:31] 3Wikimedia / 3Fundraising: Misc.: Amazon Payments prompts to change password - 10https://bugzilla.wikimedia.org/67603#c1 (10Peter Coombe) 5NEW>3RESO/WOR Thanks for letting us know about this Matt. I tried an Amazon donation this morning and didn't have to change my password, and our donor services team t... [10:20:46] 3MediaWiki extensions / 3WikidataRepo: wikibase.domready hook not firing properly? - 10https://bugzilla.wikimedia.org/67654 (10Lydia Pintscher) p:5Unprio>3High [10:21:22] (03PS1) 10Divec: Add native HTML translation method [services/cxserver] - 10https://gerrit.wikimedia.org/r/144666 [10:21:34] 3MediaWiki extensions / 3WikidataRepo: Display badges on repo - 10https://bugzilla.wikimedia.org/67668 (10Bene*) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Badges have to be displayed on the Wikidata Repo when the user does not edit them but only looks at the page. The icons of all badegs set to a sit... [10:22:02] 3MediaWiki extensions / 3WikidataRepo: Display badges on repo - 10https://bugzilla.wikimedia.org/67668 (10Bene*) [10:22:02] 3MediaWiki extensions / 3WikidataRepo: Repo UI for article badges - 10https://bugzilla.wikimedia.org/58990 (10Bene*) [10:24:33] 3MediaWiki extensions / 3WikidataRepo: Create an edit widget to edit badges - 10https://bugzilla.wikimedia.org/67669 (10Bene*) 3NEW p:3Unprio s:3normal a:3Wikidata bugs When editing a sitelink, a badge edit icon should be visible which shows a selector when clicking on it. There the user can enable o... [10:24:46] 3MediaWiki extensions / 3WikidataRepo: Create an edit widget to edit badges - 10https://bugzilla.wikimedia.org/67669 (10Bene*) [10:25:01] 3MediaWiki extensions / 3WikidataRepo: Repo UI for article badges - 10https://bugzilla.wikimedia.org/58990 (10Bene*) [10:25:47] 3MediaWiki extensions / 3WikidataRepo: Repo UI for article badges - 10https://bugzilla.wikimedia.org/58990 (10Bene*) 5PATC>3NEW [10:27:22] (03CR) 10Paladox: "And I have created pull request to add something that were reported as a bug here. like mw.GetConfig and replace with mw.config.get" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 (owner: 10Paladox) [10:29:02] (03PS8) 10Paladox: Updating EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 [10:29:05] (03CR) 10jenkins-bot: [V: 04-1] Updating EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 (owner: 10Paladox) [10:29:17] 3MediaWiki extensions / 3OAI: OAI does not pass Jenkins tests (sqlite compatibility) - 10https://bugzilla.wikimedia.org/65895#c7 (10Sam Reed (reedy)) There seems to be quite a bit of functionality in the extension we don't use. There isn't an updates table in production... mysql:wikiadmin@db1038 [oai]> show... [10:29:56] hashar: I think I'd be tempted to just comment out some lines of updateSchemaHook for OAI [10:30:16] Reedy: that is evil ! :-D [10:30:17] 3MediaWiki extensions / 3WikidataRepo: Factor out site link html code from ItemView + more tests - 10https://bugzilla.wikimedia.org/63628#c1 (10Bene*) 5NEW>3RESO/FIX Fixed in https://gerrit.wikimedia.org/r/#/c/129122/ [10:30:25] I've no idea what the other tables are [10:30:34] And/or why we don't have them in production [10:30:43] Reedy: maybe sql patches used to update the original schema over time? [10:30:48] Oh, wait.. [10:30:50] or some rough experiment that never got deployed [10:31:09] Some are in the wiki (ie updates) [10:31:15] some are in the "oai" database [10:31:20] ohhh [10:31:47] 3MediaWiki extensions / 3WikidataClient: Featured and good article badges - 10https://bugzilla.wikimedia.org/40810 (10Bene*) 5PATC>3NEW [10:31:51] still not sure the about the oaiharvest table though [10:32:43] Carolyn told me they were trying to phase out OAI [10:32:48] Yeah, we have $dbw->sourceFile( "$IP/extensions/OAI/update_table.sql" ); in addWiki [10:33:01] I believe we should just get rid of it and help third parties to migrate [10:34:10] I wonder if third parties are even using it [10:34:10] (03PS2) 10Divec: Add native HTML translation method [services/cxserver] - 10https://gerrit.wikimedia.org/r/144666 [10:34:14] (03PS9) 10Paladox: Updating EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 [10:34:17] (03CR) 10jenkins-bot: [V: 04-1] Updating EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 (owner: 10Paladox) [10:34:29] (03PS10) 10Paladox: Updating EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 [10:34:42] (03CR) 10jenkins-bot: [V: 04-1] Updating EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 (owner: 10Paladox) [10:38:38] (03PS1) 10Tweichart: Added missing comma [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/144670 [10:39:56] (03PS10) 10Kunalgrover05: Improve page language functions [core] - 10https://gerrit.wikimedia.org/r/137033 (owner: 10SPQRobin) [10:39:58] (03PS12) 10Kunalgrover05: API method to change page language [core] - 10https://gerrit.wikimedia.org/r/143025 [10:40:00] (03PS15) 10Kunalgrover05: Backend method for Special:PageLanguage, purge on language change [core] - 10https://gerrit.wikimedia.org/r/143049 [10:41:19] Reedy: are you familiar at all with mediawiki/vagrant ? [10:41:23] (03PS11) 10Paladox: Updating EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 [10:43:28] (03CR) 10jenkins-bot: [V: 04-1] Updating EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 (owner: 10Paladox) [10:43:43] (03PS3) 10Divec: Add native HTML translation method [services/cxserver] - 10https://gerrit.wikimedia.org/r/144666 [10:43:43] hashar: i don't actually use it... But I have done some bits for it... [10:44:37] Reedy: I thought we might use a vagrant role to setup mediawiki core + all the wmf deployed extensions then trigger a run of phpunit [10:44:43] might help folks fix the broken tests [10:44:48] that is a random idea [10:44:58] I should first send a mail about testing all extensions together [10:45:02] and the current blockers [10:46:36] Iwill do that later this afternoon [10:46:41] lunch + nap. will be back around 3pm CET [10:47:35] (03PS12) 10Paladox: Updating EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 [10:47:38] (03CR) 10jenkins-bot: [V: 04-1] Updating EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 (owner: 10Paladox) [10:49:12] (03PS13) 10Paladox: Updating EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 [10:49:15] (03CR) 10jenkins-bot: [V: 04-1] Updating EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 (owner: 10Paladox) [10:52:31] 3Wikimedia / 3Site requests: $wgCategoryCollation for sh.wikipedia.org - 10https://bugzilla.wikimedia.org/67287#c3 (10Kolega2357) https://sh.wikipedia.org/w/index.php?title=Wikipedia:Pijaca-%D0%9F%D0%B8%D1%98%D0%B0%D1%86%D0%B0&oldid=5481899#.24wgCategoryCollation Community consensus is a successful completed. [10:53:54] (03CR) 10Paladox: "Hi how can I rebase without losing the files because it wont let me do it or could someone else do it thanks." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 (owner: 10Paladox) [10:55:25] (03PS1) 10IAlex: Add method XmlSelect::addAttributes() and use it in HTMLSelectField [core] - 10https://gerrit.wikimedia.org/r/144671 [11:01:45] (03PS4) 10Santhosh: Add native HTML translation method [services/cxserver] - 10https://gerrit.wikimedia.org/r/144666 (owner: 10Divec) [11:03:22] (03CR) 10Santhosh: [C: 032] Markup-preserving wrapper for Apertium [services/cxserver] - 10https://gerrit.wikimedia.org/r/143257 (owner: 10Divec) [11:03:40] (03CR) 10Santhosh: [C: 032] Simple GET API to fetch translations [services/cxserver] - 10https://gerrit.wikimedia.org/r/143832 (owner: 10Divec) [11:03:56] (03CR) 10Santhosh: [C: 032] Add native HTML translation method [services/cxserver] - 10https://gerrit.wikimedia.org/r/144666 (owner: 10Divec) [11:03:59] (03Merged) 10jenkins-bot: Markup-preserving wrapper for Apertium [services/cxserver] - 10https://gerrit.wikimedia.org/r/143257 (owner: 10Divec) [11:05:37] (03Merged) 10jenkins-bot: Simple GET API to fetch translations [services/cxserver] - 10https://gerrit.wikimedia.org/r/143832 (owner: 10Divec) [11:06:01] (03Merged) 10jenkins-bot: Add native HTML translation method [services/cxserver] - 10https://gerrit.wikimedia.org/r/144666 (owner: 10Divec) [11:07:52] (03CR) 10Florianschmidtwelzow: "Is there an bug report to this? :)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/144654 (owner: 10Gerrit Patch Uploader) [11:08:13] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/143049 (owner: 10Kunalgrover05) [11:08:29] (03CR) 10Smuggli: [C: 032 V: 032] Added missing comma [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/144670 (owner: 10Tweichart) [11:12:31] (03CR) 10Fomafix: "See: http://validator.w3.org/check?uri=https%3A%2F%2Fwww.mediawiki.org%2Fwiki%2FSpecial%3ASearch%2FFoo" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/144654 (owner: 10Gerrit Patch Uploader) [11:16:09] (03CR) 10Siebrand: [C: 04-1] "Looks like comments from https://gerrit.wikimedia.org/r/#/c/143025/11/includes/api/ApiPageLanguage.php have not yet been addressed." [core] - 10https://gerrit.wikimedia.org/r/143025 (owner: 10Kunalgrover05) [11:17:25] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/144665 (owner: 10Raimond Spekking) [11:19:10] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144664 (https://bugzilla.wikimedia.org/59835) (owner: 10Matthias Mullie) [11:23:47] (03CR) 10Siebrand: "i18n/L10n reviewed." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143906 (owner: 10Matthias Mullie) [11:26:13] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143288 (owner: 10Matthias Mullie) [11:33:54] (03PS1) 10Paladox: Update TimedText [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144675 [11:34:04] (03PS2) 10Paladox: Update TimedText [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144675 [11:34:22] (03PS3) 10Florianschmidtwelzow: Move Alias back to root [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/144272 [11:35:00] (03CR) 10Paladox: "Hi please could someone review this so that I know if there are any errors in it." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144675 (owner: 10Paladox) [11:37:49] qchris, when you have a sec, could you create a new repo? thx :) [11:38:11] * qchris looks [11:38:11] * yurikR feels uneasy without the constant git backup [11:38:54] yurikR: Is 'sms-zero' the name of the initiative? [11:39:12] qchris, well, this would be analytics for it [11:39:16] zero-sms [11:39:19] i think is betetr [11:39:20] Or would something like 'wikipedia-zero-sms' or 'wp-zero-sms' also work? [11:39:32] Ok. [11:39:41] lets not limit ourselves to wp :) [11:39:50] So the wikipedia zero team calls that part "zero-sms"? [11:39:59] we don't call it anything - [11:40:04] :-D [11:40:04] we don't have any code here [11:40:17] prakelt is doing all the work [11:40:25] i'm just looking through the logs [11:40:42] Will this be a data repository, or real code? [11:40:48] code [11:40:52] python [11:40:55] K. [11:40:58] a few scripts [11:41:01] nothing massive [11:41:18] it just that it doesn't fit anywhere else [11:41:25] like zero extensions [11:41:36] Sure. [11:42:01] So since you said you'd prefer 'zero-sms' (above) over 'sms-zero' (from request page) [11:42:11] Let's use 'zero-sms' then. Ok? [11:43:48] yurikR: https://gerrit.wikimedia.org/r/#/admin/projects/analytics/zero-sms [11:44:07] qchris, thx!! [11:44:11] (03PS3) 10Paladox: Update TimedText [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144675 [11:44:16] yw [11:44:20] (03PS4) 10Paladox: Update TimedText [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144675 [11:45:29] (03PS44) 10Paladox: sync with upstream Kaltura player MwEmbedSupport module 2.12.1 [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/144143 [11:46:11] (03PS14) 10Paladox: Updating EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 [11:46:14] (03CR) 10jenkins-bot: [V: 04-1] Updating EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 (owner: 10Paladox) [11:55:10] (03PS2) 10Gerrit Patch Uploader: Use Html::element instead of Xml::element for empty elements [core] - 10https://gerrit.wikimedia.org/r/144654 [11:55:12] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/144654 (owner: 10Gerrit Patch Uploader) [11:55:47] 3Wikimedia / 3Git/Gerrit: Gerrit SSH: Intermittent key_verify failed for server_host_key and 'hash mismatch' - 10https://bugzilla.wikimedia.org/53895#c31 (10Bartosz Dziewoński) <3 [11:58:14] (03CR) 10Paladox: "Hi just looked through timedmediahandler.php and found that this function $wgVideoPlayerSkinModule = 'mw.PlayerSkinKskin'; no longer esits" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 (owner: 10Paladox) [12:02:47] 3Wikimedia / 3Git/Gerrit: Gerrit SSH: Intermittent key_verify failed for server_host_key and 'hash mismatch' - 10https://bugzilla.wikimedia.org/53895#c32 (10Ori Livneh) (In reply to christian from comment #28) > Since this bug has been around for a while and has affected quite some > people, I've been asked... [12:08:47] (03PS1) 10Robert Vogel: REL2_23 rework of skin [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/144684 [12:12:33] (03CR) 10Robert Vogel: [C: 032 V: 032] "This is the recent state of development. There where no changes from WMF GIT that had to be merged." [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/144684 (owner: 10Robert Vogel) [12:21:28] (03CR) 10Florianschmidtwelzow: "@Fomafix: This is still the same cmment from me. If yu use false as third parameter you can use Xml instead of Html, personally for me it'" [core] - 10https://gerrit.wikimedia.org/r/144654 (owner: 10Gerrit Patch Uploader) [12:25:46] 3MediaWiki / 3Page editing: Flowing Tables - 10https://bugzilla.wikimedia.org/15208#c1 (10Andre Klapper) p:5Low>3Lowest Craig: I'm not sure I understand the usecases here - there seem to be two? One of them is adding a new column to an existing table and that new column is not at the end, and the other o... [12:29:02] 3MediaWiki / 3Search: Search (or AJAX Suggestions) should try expanding/contracting ordinals (e.g. Fourteenth should find 14th) - 10https://bugzilla.wikimedia.org/15280#c1 (10Andre Klapper) Feature request still valid when using the new Search backend at https://en.wikipedia.org/wiki/?srbackend=CirrusSearch... [12:41:39] (03CR) 10Fomafix: "At the moment this file uses" [core] - 10https://gerrit.wikimedia.org/r/144654 (owner: 10Gerrit Patch Uploader) [12:43:53] (03CR) 10Florianschmidtwelzow: "There isn't a problem, i only don't know understand, why not use one class for all elemtns." [core] - 10https://gerrit.wikimedia.org/r/144654 (owner: 10Gerrit Patch Uploader) [12:48:01] (03CR) 10Fomafix: "Sorry, I can not understand your answer." [core] - 10https://gerrit.wikimedia.org/r/144654 (owner: 10Gerrit Patch Uploader) [12:49:31] 3Wikimedia / 3Site requests: $wgCategoryCollation for sh.wikipedia.org - 10https://bugzilla.wikimedia.org/67287 (10Andre Klapper) [12:50:01] 3MediaWiki / 3Page editing: After upgrading from 1.15 to 1.23 get "Error: 1267 Illegal mix of collations" - 10https://bugzilla.wikimedia.org/66277#c6 (10Andre Klapper) Andrei: Can you answer comment 5 please? [12:50:46] 3MediaWiki / 3Installer: Installation - Warning: oci_fetch_all(): ORA-01002: fetch out of sequence - 10https://bugzilla.wikimedia.org/66013#c2 (10Andre Klapper) Jens: Can you please answer comment 1? [12:50:55] (03CR) 10Florianschmidtwelzow: "Ok :)" [core] - 10https://gerrit.wikimedia.org/r/144654 (owner: 10Gerrit Patch Uploader) [12:52:01] 3Wikimedia / 3General/Unknown: Provide non-manual HTML/CSS minimizing for Www.wikipedia.org_template on Meta - 10https://bugzilla.wikimedia.org/65276#c4 (10Andre Klapper) Yishen: Have you asked on https://meta.wikimedia.org/wiki/Talk:Www.wikipedia.org_template ? [12:53:01] 3MediaWiki / 3Search: mwsuggest should support a .mw-search classname instead of hardcoded ids - 10https://bugzilla.wikimedia.org/30954 (10Andre Klapper) p:5Normal>3Lowest [12:54:16] 3Wikimedia / 3Deployment systems: Manage mediawiki-config/php symlink automatically - 10https://bugzilla.wikimedia.org/64748#c7 (10Andre Klapper) So can this ticket be closed as FIXED, or what's left? All patches merged... [13:03:40] (03PS3) 10Matthias Mullie: Use shared method for both POST & GET to output errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143288 [13:05:54] (03CR) 10Anomie: [C: 032] Improve mw.getCurrentFrame handling [extensions/Scribunto] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/144559 (https://bugzilla.wikimedia.org/67498) (owner: 10Jackmcbarn) [13:05:58] (03CR) 10Anomie: [C: 032] Improve mw.getCurrentFrame handling [extensions/Scribunto] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/144511 (https://bugzilla.wikimedia.org/67498) (owner: 10Jackmcbarn) [13:07:41] (03Merged) 10jenkins-bot: Improve mw.getCurrentFrame handling [extensions/Scribunto] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/144559 (https://bugzilla.wikimedia.org/67498) (owner: 10Jackmcbarn) [13:09:07] (03Merged) 10jenkins-bot: Improve mw.getCurrentFrame handling [extensions/Scribunto] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/144511 (https://bugzilla.wikimedia.org/67498) (owner: 10Jackmcbarn) [13:10:20] (03PS1) 10Anomie: Update Scribunto for I82dde43e [core] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/144686 [13:11:50] (03PS1) 10Anomie: Update Scribunto for I82dde43e [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/144687 [13:12:35] (03PS2) 10Anomie: Update Scribunto for I82dde43e [core] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/144686 [13:14:22] (03PS15) 10Prtksxna: Add settings [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140086 [13:15:35] (03PS1) 10Jack Phoenix: New 'UserResetAllOptions' hook from the wikiHow codebase. [core] - 10https://gerrit.wikimedia.org/r/144689 [13:18:26] (03PS1) 10Gerrit Patch Uploader: SpecialSearch.php: Remove inline style="margin:0em" [core] - 10https://gerrit.wikimedia.org/r/144690 [13:18:28] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/144690 (owner: 10Gerrit Patch Uploader) [13:18:51] (03CR) 10Bartosz Dziewoński: [C: 031] "Looks reasonable to me, but this isn't really my area (even if I messed with these particular functions in the past)." [core] - 10https://gerrit.wikimedia.org/r/144689 (owner: 10Jack Phoenix) [13:21:35] (03CR) 10Paladox: "Tested all the files linked to this and it has errors in it. does not work." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144675 (owner: 10Paladox) [13:24:36] (03CR) 10Bartosz Dziewoński: [C: 032] "Indeed." [core] - 10https://gerrit.wikimedia.org/r/144690 (owner: 10Gerrit Patch Uploader) [13:25:04] 3MediaWiki / 3Unit tests: Something in unit tests is doing something funky with the session - 10https://bugzilla.wikimedia.org/67656#c2 (10Chad H.) (In reply to Antoine "hashar" Musso from comment #1) > Have you tried disabling all extensions? Yes > With a fresh LocalSettings.php? Yes > Throwing the sess... [13:27:44] (03Merged) 10jenkins-bot: SpecialSearch.php: Remove inline style="margin:0em" [core] - 10https://gerrit.wikimedia.org/r/144690 (owner: 10Gerrit Patch Uploader) [13:29:35] <^demon|food> I'm not sure Special:Search can be any less stylish. [13:29:37] <^demon|food> ;-0 [13:32:56] (03CR) 10Anomie: [C: 031] "Looks sane to me. I'm not familiar with how these scripts work enough to test though." [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/141099 (https://bugzilla.wikimedia.org/43027) (owner: 10TTO) [13:36:04] 3MediaWiki extensions / 3AbuseFilter: Breaking change in AbuseFilter's "like" operator - 10https://bugzilla.wikimedia.org/67670 (10Yusuke Matsubara) 3NEW p:3Unprio s:3normal a:3None The "like" operator in AbuseFilter started behaving differently, after Bug 66930 was resolved in https://gerrit.wikimed... [13:40:46] 3MediaWiki extensions / 3AbuseFilter: Breaking change in AbuseFilter's "like" operator - 10https://bugzilla.wikimedia.org/67670#c1 (10Yusuke Matsubara) 66935(In reply to Yusuke Matsubara from comment #0) > The "like" operator in AbuseFilter started behaving differently, after Bug > 66930 was resolved in http... [13:42:47] 3MediaWiki extensions / 3AbuseFilter: Breaking change in AbuseFilter's "like" operator - 10https://bugzilla.wikimedia.org/67670 (10Bartosz Dziewoński) [13:57:44] (03CR) 10Parent5446: [C: 031] New 'UserResetAllOptions' hook from the wikiHow codebase. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/144689 (owner: 10Jack Phoenix) [13:58:05] 3MediaWiki extensions / 3Translate: Translate: Round percentages down (for message matching) - 10https://bugzilla.wikimedia.org/67671 (10Lokal_Profil) 3NEW p:3Unprio s:3enhanc a:3None The matching percentage shown in the "Special:Translate" interface rounds to an integer value. There is however a hug... [13:59:46] <^demon|food> Just what we need, more hooks :( [14:00:53] 3Wikimedia / 3Bugzilla: Add component for PubSubHubbub - 10https://bugzilla.wikimedia.org/67661 (10Tyler Romeo) 5NEW>3ASSI p:5Unprio>3Normal a:3Tyler Romeo [14:02:33] (03CR) 10Gilles: Android native browser ending playback after 1 second (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144352 (https://bugzilla.wikimedia.org/43748) (owner: 10Brian Wolff) [14:03:20] 3Wikimedia / 3Bugzilla: Add component for PubSubHubbub - 10https://bugzilla.wikimedia.org/67661#c2 (10Tyler Romeo) 5ASSI>3RESO/FIX Done. [14:06:25] (03PS1) 10Gilles: Update UploadWizard submodule [core] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/144697 [14:09:46] (03Abandoned) 10Gilles: Update UploadWizard submodule [core] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/144697 (owner: 10Gilles) [14:10:40] (03CR) 10Parent5446: [C: 04-1] "I agree with Anomie in this case, but would like to take it a bit further than that." [core] - 10https://gerrit.wikimedia.org/r/144246 (owner: 10Yurik) [14:13:57] (03CR) 10Parent5446: Cleanup - lets make IDEs more useful (031 comment) [core] - 10https://gerrit.wikimedia.org/r/144246 (owner: 10Yurik) [14:14:08] (03CR) 10CSteipp: "To make sure not anyone can call this, this should be restricted to either a whitelist of IP addresses, or to a user right, who exim logs " [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/144656 (owner: 1001tonythomas) [14:14:56] (03PS1) 10SG: Improve progressiveEnhancement to support inline Handlebars content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144699 [14:14:59] (03PS1) 10SG: Correct mw-ui button to inherit font from parent [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144700 [14:15:02] (03PS1) 10SG: Improvements and fixes to topic summarization [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144701 [14:15:05] (03PS1) 10SG: Ignore whitespace in compiled handlebars templates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144702 [14:15:08] (03PS1) 10Gilles: Updating the UploadWizard submodule [core] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/144703 [14:16:53] (03CR) 10Parent5446: "Yes, but I mentioned those issues for a reason. There should be no need to re-implement functionality for fetching sub-page text. If it is" [core] - 10https://gerrit.wikimedia.org/r/140765 (https://bugzilla.wikimedia.org/66762) (owner: 10MaxSem) [14:17:23] (03PS11) 10SG: [WIP]Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 (owner: 10Bsitu) [14:17:26] (03PS1) 10SG: Complete flow-ui-tooltip JS, correct tooltip styling to white bg [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144704 [14:17:44] (03CR) 10jenkins-bot: [V: 04-1] [WIP]Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 (owner: 10Bsitu) [14:17:57] (03CR) 10jenkins-bot: [V: 04-1] Complete flow-ui-tooltip JS, correct tooltip styling to white bg [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144704 (owner: 10SG) [14:18:53] (03PS1) 10Gilles: Updating the UploadWizard submodule [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/144705 [14:21:34] (03PS2) 10SG: Complete flow-ui-tooltip JS, correct tooltip styling to white bg [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144704 [14:22:05] (03PS12) 10SG: [WIP]Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 (owner: 10Bsitu) [14:24:52] (03CR) 10SG: [C: 031] [WIP]Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 (owner: 10Bsitu) [14:25:44] (03CR) 10SG: "+1 for Benny's stuff. I added some tooltip things here, but most of that code is in a separate patch. In this particular patch, I only add" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 (owner: 10Bsitu) [14:26:59] (03PS2) 1001tonythomas: Added API to handle incoming emails automatically [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/144656 [14:29:52] (03CR) 10Gilles: [C: 031] Make Special:FilePath redirect to Special:Redirect/file [core] - 10https://gerrit.wikimedia.org/r/142144 (https://bugzilla.wikimedia.org/66980) (owner: 10Brian Wolff) [14:34:26] (03CR) 10Anomie: "I don't see much point in a hook that is called for 'all' but not for explicitly passing the same values as 'all' is short for. Parent5446" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/144689 (owner: 10Jack Phoenix) [14:34:49] (03CR) 10Gilles: [C: 032] Fix double output of mimesearch-summary [core] - 10https://gerrit.wikimedia.org/r/138300 (owner: 10Brian Wolff) [14:35:45] (03CR) 10jenkins-bot: [V: 04-1] Fix double output of mimesearch-summary [core] - 10https://gerrit.wikimedia.org/r/138300 (owner: 10Brian Wolff) [14:37:07] (03PS1) 10Pastakhov: add support for dynamic constants (v 2.1.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/144707 [14:37:15] (03CR) 10Gilles: [C: 032] Fix alpha transparency in XCF images [core] - 10https://gerrit.wikimedia.org/r/144118 (https://bugzilla.wikimedia.org/35622) (owner: 10Brian Wolff) [14:38:25] (03CR) 10Gilles: [C: 032] Override CSS link colour in pop up video [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144639 (owner: 10Brian Wolff) [14:38:36] (03Merged) 10jenkins-bot: Override CSS link colour in pop up video [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144639 (owner: 10Brian Wolff) [14:39:02] (03CR) 10Gilles: [C: 032] Make play button have higher z-index so its clickable. [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/108637 (owner: 10Brian Wolff) [14:39:09] (03Merged) 10jenkins-bot: Make play button have higher z-index so its clickable. [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/108637 (owner: 10Brian Wolff) [14:40:52] (03Merged) 10jenkins-bot: Fix alpha transparency in XCF images [core] - 10https://gerrit.wikimedia.org/r/144118 (https://bugzilla.wikimedia.org/35622) (owner: 10Brian Wolff) [14:43:03] 3MediaWiki extensions / 3Cite: Edit preview doesn't let you preview cite.php footnotes. - 10https://bugzilla.wikimedia.org/5984#c24 (10Makyen) The abandonment of https://gerrit.wikimedia.org/r/129932 without explanation implies that the fix for https://bugzilla.wikimedia.org/show_bug.cgi?id=66860 solves this... [14:44:30] (03CR) 10MarkAHershberger: "Of course, some people do check out all extensions. That isn't the use case being addressed with the REL*_* branches, though." [extensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/144271 (https://bugzilla.wikimedia.org/67270) (owner: 10MarkAHershberger) [14:46:49] (03CR) 10Pastakhov: [C: 032] add support for dynamic constants (v 2.1.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/144707 (owner: 10Pastakhov) [14:46:54] (03Merged) 10jenkins-bot: add support for dynamic constants (v 2.1.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/144707 (owner: 10Pastakhov) [14:53:10] (03CR) 10Anomie: [C: 04-1] API method to change page language (033 comments) [core] - 10https://gerrit.wikimedia.org/r/143025 (owner: 10Kunalgrover05) [14:53:40] (03CR) 10Anomie: "Code looks mostly ok. Haven't tested." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143049 (owner: 10Kunalgrover05) [14:56:56] (03CR) 10Withoutaname: [C: 031] Removes deprecated $wgUseCommaCount variable [core] - 10https://gerrit.wikimedia.org/r/139842 (https://bugzilla.wikimedia.org/60454) (owner: 10Rohan013) [14:59:06] (03CR) 10Withoutaname: [C: 04-1] "Please add brief release notes." [core] - 10https://gerrit.wikimedia.org/r/139842 (https://bugzilla.wikimedia.org/60454) (owner: 10Rohan013) [15:00:24] (03CR) 10Anomie: [C: 032] "SWAT" [core] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/144703 (owner: 10Gilles) [15:03:36] (03Merged) 10jenkins-bot: Updating the UploadWizard submodule [core] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/144703 (owner: 10Gilles) [15:06:23] (03CR) 10Anomie: [C: 032] "SWAT deploy" [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/144705 (owner: 10Gilles) [15:07:30] (03PS3) 10Anomie: Update Scribunto for I82dde43e [core] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/144686 [15:09:38] (03Merged) 10jenkins-bot: Updating the UploadWizard submodule [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/144705 (owner: 10Gilles) [15:13:33] (03CR) 10Anomie: [C: 032] "SWAT deploy" [core] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/144686 (owner: 10Anomie) [15:14:32] (03PS2) 10Anomie: Update Scribunto for I82dde43e [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/144687 [15:14:44] (03CR) 10Anomie: [C: 032] "SWAT deploy" [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/144687 (owner: 10Anomie) [15:14:51] (03CR) 10Anomie: [V: 032] "SWAT deploy" [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/144687 (owner: 10Anomie) [15:18:47] 3MediaWiki extensions / 3Cite: Cite: If there's no block on the page, show one automatically below the content rather than showing an error - 10https://bugzilla.wikimedia.org/66860#c15 (10James Forrester) (In reply to Gadget850 from comment #14) > So- reopen this bug or open a new one? A new... [15:20:57] (03PS4) 10SG: Use shared method for both POST & GET to output errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143288 (owner: 10Matthias Mullie) [15:21:26] (03PS1) 10Pastakhov: add dynamic constant UUID (v 3.1.2) [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/144710 [15:21:31] guillom: BTW, question about team reporting. Should I start [[mw:Editing]] as a new status update series, in parallel with VE and other updates? [15:22:58] (03PS1) 1020after4: CustomField extension that adds a "MediaWiki Userpage" link on phabricator user profile pages when a phabricator account is linked to mediawiki oauth. [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/144711 [15:24:20] (03Abandoned) 1020after4: Custom user profile field to display a link to the mediawiki SUL account that is associated with each phabricator account. [phabricator/phabricator] - 10https://gerrit.wikimedia.org/r/143506 (owner: 1020after4) [15:24:53] (03PS8) 10SG: Error handling for view-header & edit-header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143289 (owner: 10Matthias Mullie) [15:25:03] 3MediaWiki / 3Categories: Should show newly-added hidden categories for preview version - 10https://bugzilla.wikimedia.org/13275#c3 (10Derk-Jan Hartman) *** Bug 16279 has been marked as a duplicate of this bug. *** [15:25:03] 3MediaWiki / 3General/Unknown: Hidden categories should appear below textarea when previewing - 10https://bugzilla.wikimedia.org/16279#c3 (10Derk-Jan Hartman) 5REOP>3RESO/DUP *** This bug has been marked as a duplicate of bug 13275 *** [15:25:06] (03CR) 10SG: [C: 032] Error handling for view-header & edit-header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143289 (owner: 10Matthias Mullie) [15:25:18] (03CR) 10Pastakhov: [C: 032] add dynamic constant UUID (v 3.1.2) [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/144710 (owner: 10Pastakhov) [15:25:21] (03PS2) 10Matthias Mullie: ConfirmEdit, captcha version [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144664 (https://bugzilla.wikimedia.org/59835) [15:25:24] (03Merged) 10jenkins-bot: add dynamic constant UUID (v 3.1.2) [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/144710 (owner: 10Pastakhov) [15:25:26] (03Merged) 10jenkins-bot: Error handling for view-header & edit-header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143289 (owner: 10Matthias Mullie) [15:25:35] (03CR) 10jenkins-bot: [V: 04-1] ConfirmEdit, captcha version [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144664 (https://bugzilla.wikimedia.org/59835) (owner: 10Matthias Mullie) [15:26:37] (03CR) 1020after4: "Note: this is live on our testing instance. Example: http://fab.wmflabs.org/p/mmodell/" [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/144711 (owner: 1020after4) [15:27:52] (03CR) 10Paladox: "Hi I have tested this and does not work brings up 500 error need helpt of find the error please. are there any programes for windows that " [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/144143 (owner: 10Paladox) [15:27:59] (03CR) 10Paladox: "Hi I have tested this and does not work brings up 500 error need helpt of find the error please. are there any programes for windows that " [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 (owner: 10Paladox) [15:30:04] (03PS6) 10SG: Error handling for editing a post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143290 (owner: 10Matthias Mullie) [15:30:14] (03CR) 10SG: [C: 032] Error handling for editing a post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143290 (owner: 10Matthias Mullie) [15:30:54] (03Merged) 10jenkins-bot: Error handling for editing a post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143290 (owner: 10Matthias Mullie) [15:31:17] hoo: you pinged me 2 days ago ? [15:31:54] (03PS1) 10Hoo man: En i18n json spaces to tabs [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144713 [15:32:03] thedj: yeah [15:32:14] was about and ace editor gadget [15:32:23] but legokt.m already addressed the issue [15:32:45] (03PS6) 10SG: Error handling for 'Edit title' topic action [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143291 (owner: 10Matthias Mullie) [15:32:53] (03CR) 10SG: [C: 032] Error handling for 'Edit title' topic action [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143291 (owner: 10Matthias Mullie) [15:33:13] (03PS5) 10SG: Error handling for preview [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143292 (owner: 10Matthias Mullie) [15:33:26] (03Merged) 10jenkins-bot: Error handling for 'Edit title' topic action [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143291 (owner: 10Matthias Mullie) [15:33:35] (03CR) 10SG: [C: 032] Error handling for preview [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143292 (owner: 10Matthias Mullie) [15:33:56] (03PS2) 10Anomie: Add HTMLAutoCompleteSelectField [core] - 10https://gerrit.wikimedia.org/r/142668 [15:34:27] (03Merged) 10jenkins-bot: Error handling for preview [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143292 (owner: 10Matthias Mullie) [15:37:56] (03CR) 10Chad: [C: 032] rm $wgCountTotalSearchHits. It was broken. [core] - 10https://gerrit.wikimedia.org/r/144642 (owner: 10Brian Wolff) [15:38:03] 3MediaWiki / 3Maintenance scripts: Can't render large page when using hhvm - 10https://bugzilla.wikimedia.org/67625#c1 (10Nik Everett) I tried this again this morning and it seems like hhvm gets starved for threads somehow. Other requests start failing when this happens. At least, that is the case on vagra... [15:38:36] (03CR) 10MarkTraceur: "Are you looking at the log files for your webserver? If so, the error should be at the bottom, no need to search for it..." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 (owner: 10Paladox) [15:39:02] legoktm: hey [15:40:56] (03PS2) 10SG: Improve progressiveEnhancement to support inline Handlebars content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144699 [15:40:59] (03PS2) 10SG: Correct mw-ui button to inherit font from parent [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144700 [15:41:02] (03PS2) 10SG: Improvements and fixes to topic summarization [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144701 [15:41:05] (03PS2) 10SG: Ignore whitespace in compiled handlebars templates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144702 [15:41:08] (03PS6) 10SG: Error handling for Summarise and edit summary topic actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143293 (owner: 10Matthias Mullie) [15:41:37] (03Merged) 10jenkins-bot: rm $wgCountTotalSearchHits. It was broken. [core] - 10https://gerrit.wikimedia.org/r/144642 (owner: 10Brian Wolff) [15:41:39] (03CR) 10SG: [C: 032] Error handling for Summarise and edit summary topic actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143293 (owner: 10Matthias Mullie) [15:41:56] (03CR) 10SG: [C: 032] Ignore whitespace in compiled handlebars templates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144702 (owner: 10SG) [15:42:34] (03CR) 10SG: [C: 032] Correct mw-ui button to inherit font from parent [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144700 (owner: 10SG) [15:45:18] 3MediaWiki / 3Revision deletion: Special:Blocklist is leaking RevDel'ed information - 10https://bugzilla.wikimedia.org/25763#c15 (10TeleComNasSprVen) (In reply to Tegel from comment #13) > Abusive user name is one thing, but the cases where it's really a problem is > when the user name contains non-public in... [15:46:25] (03Abandoned) 10Withoutaname: Hide suppressed usernames from Special:BlockList [core] - 10https://gerrit.wikimedia.org/r/132638 (https://bugzilla.wikimedia.org/25763) (owner: 10Withoutaname) [15:51:53] (03CR) 10Paladox: "Well it doesent come up and when I set a setting in localsettings.php to show the errors it doesent and keeps showing a 500 error" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 (owner: 10Paladox) [15:53:32] 3MediaWiki / 3Revision deletion: Special:Blocklist is leaking RevDel'ed information - 10https://bugzilla.wikimedia.org/25763#c17 (10Jackmcbarn) 5PATC>3RESO/INV (In reply to Tegel from comment #13) > Abusive user name is one thing, but the cases where it's really a problem is > when the user name contains... [15:54:41] (03CR) 10MarkTraceur: "You put in the following, I assume:" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 (owner: 10Paladox) [15:57:46] 3MediaWiki extensions / 3OAI: OAI does not pass Jenkins tests (sqlite compatibility) - 10https://bugzilla.wikimedia.org/65895#c8 (10Sam Reed (reedy)) Updates table is on each wiki, not in the oai database harvest table looks unused [15:59:00] (03CR) 10Robmoen: "Waiting to make this based on kaldari's patch until he is finished or responded to comments." [core] - 10https://gerrit.wikimedia.org/r/143577 (owner: 10Robmoen) [16:00:00] andre__, fyi, I'm trying to get to #wikimedia-office -- having connectivity problems, though [16:01:49] 3MediaWiki extensions / 3Math: [Regression] MathJax broken in 1.23wmf22 and master - 10https://bugzilla.wikimedia.org/63915#c25 (10physikerwelt) I'm quite good in posting to wikitech-l without to get any feedback... http://lists.wikimedia.org/pipermail/wikitech-l/2014-July/077422.html I have the feeling that... [16:07:15] Reedy and hasharMeeting: Review and merge of https://gerrit.wikimedia.org/r/#/c/142319/ and https://gerrit.wikimedia.org/r/#/c/142320/ would be swell so I could close out bug 53972. Please and thank you. [16:09:02] 3MediaWiki / 3Parser: HTML Tidy issues (tracking) - 10https://bugzilla.wikimedia.org/2542 (10Andre Klapper) [16:10:33] (03CR) 10Paladox: "Hi I have but nothing comes up just keep showing the 500 error screen." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 (owner: 10Paladox) [16:11:00] (03CR) 10MarkTraceur: "By "the 500 error screen", do you mean a blank white page?" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 (owner: 10Paladox) [16:13:09] (03PS21) 10Gilles: Generate thumbnails based on buckets [core] - 10https://gerrit.wikimedia.org/r/135008 (https://bugzilla.wikimedia.org/67525) [16:14:01] (03CR) 10Gilles: "The issue was coming from the fact that I was passing specific heights to normaliseParams for the buckets, which caused it to recalculate " (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135008 (https://bugzilla.wikimedia.org/67525) (owner: 10Gilles) [16:14:49] 3MediaWiki extensions / 3UniversalLanguageSelector: [WebFonts] Uncaught TypeError: Cannot read property 'replace' of undefined - 10https://bugzilla.wikimedia.org/67676 (10Niklas Laxström) 3NEW p:3Unprio s:3normal a:3None Uncaught TypeError: Cannot read property 'replace' of undefined Caused by: ove... [16:15:22] 3MediaWiki / 3Unit tests: Something in unit tests is doing something funky with the session - 10https://bugzilla.wikimedia.org/67656#c3 (10Chad H.) I tried running all the tests individually in their own process to see if I could isolate it to one misbehaving test. Surprise surprise, it didn't break then! I... [16:16:18] 3MediaWiki extensions / 3UniversalLanguageSelector: [WebFonts] Uncaught TypeError: Cannot read property 'replace' of undefined - 10https://bugzilla.wikimedia.org/67676#c1 (10Niklas Laxström) Happens for example on the translatewiki.net main page. [16:17:06] (03CR) 10jenkins-bot: [V: 04-1] Generate thumbnails based on buckets [core] - 10https://gerrit.wikimedia.org/r/135008 (https://bugzilla.wikimedia.org/67525) (owner: 10Gilles) [16:19:47] 3MediaWiki / 3General/Unknown: shared file repository (tracking) - 10https://bugzilla.wikimedia.org/4243 (10Andre Klapper) [16:20:32] 3Wikimedia / 3General/Unknown: Make MediaWiki:Sharedupload point to Commons with lang setting of that wiki - 10https://bugzilla.wikimedia.org/10827#c5 (10Andre Klapper) This has a "UniversalLanguageSelector-fixed" whiteboard entry, which makes me wonder what's specifically left to do here now that ULS is dep... [16:22:03] 3MediaWiki / 3Internationalization: Esperanto Magical conversion should be a part of Special:Preferences and deselectable at every page - 10https://bugzilla.wikimedia.org/21781 (10Andre Klapper) [16:24:17] 3MediaWiki / 3General/Unknown: case sensitivity issues (tracking) - 10https://bugzilla.wikimedia.org/3950#c5 (10Andre Klapper) No open tickets left here (plus wondering if anybody uses this tracking bug to really track such issues and work on them anyway, or if it's just categorization for the sake of catego... [16:24:22] (03PS24) 10EBernhardson: Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 [16:24:28] (03CR) 10jenkins-bot: [V: 04-1] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson) [16:24:38] (03CR) 10Paladox: "Yes. it is here my site http://wikisaur.tk/ I am currently running all the version of these extension I uploaded for vido." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 (owner: 10Paladox) [16:25:03] 3MediaWiki / 3General/Unknown: case sensitivity issues (tracking) - 10https://bugzilla.wikimedia.org/3950 (10Andre Klapper) [16:26:25] (03PS25) 10EBernhardson: Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 [16:26:40] (03CR) 10jenkins-bot: [V: 04-1] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson) [16:27:02] 3MediaWiki / 3General/Unknown: Missing Indexes, Inefficient queries and alike (tracking) - 10https://bugzilla.wikimedia.org/26394#c1 (10Andre Klapper) Reedy: Is anybody actually "tracking" this, seeing four tickets before #30000 as dependencies? Missing indexes sounds like "MediaWiki > Database" with "schem... [16:29:47] 3Wikimedia / 3Language setup: Language on Commons should default to browser language preferences - 10https://bugzilla.wikimedia.org/1135 (10Nemo) [16:29:48] 3Wikimedia / 3Extension setup: Deploy ULS/UniversalLanguageSelector to all Wikimedia wikis (tracking) - 10https://bugzilla.wikimedia.org/13097 (10Nemo) [16:31:44] (03CR) 10Siebrand: [C: 032] En i18n json spaces to tabs [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144713 (owner: 10Hoo man) [16:31:51] (03Merged) 10jenkins-bot: En i18n json spaces to tabs [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144713 (owner: 10Hoo man) [16:32:20] (03PS13) 10Kunalgrover05: API method to change page language [core] - 10https://gerrit.wikimedia.org/r/143025 [16:33:15] (03PS26) 10EBernhardson: Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 [16:33:36] (03CR) 10Kunalgrover05: Backend method for Special:PageLanguage, purge on language change (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143049 (owner: 10Kunalgrover05) [16:34:06] (03PS3) 10SG: Improve progressiveEnhancement to support inline Handlebars content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144699 [16:34:39] (03PS2) 10EBernhardson: Escape topic title HTML shown in h1 firstHeading [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143552 (https://bugzilla.wikimedia.org/67401) (owner: 10Spage) [16:35:14] (03CR) 10Brian Wolff: "Thank you for fixing this. I really need to be more careful with those qqq files. (When they were php i could just run them through php -l" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144645 (owner: 10Raimond Spekking) [16:35:32] 3Wikimedia / 3General/Unknown: Make MediaWiki:Sharedupload point to Commons with lang setting of that wiki - 10https://bugzilla.wikimedia.org/10827#c6 (10Nemo) (In reply to Andre Klapper from comment #5) > This has a "UniversalLanguageSelector-fixed" whiteboard entry, which makes > me wonder what's specifica... [16:35:33] 3MediaWiki / 3Special pages: $wgArticleRobotPolicies vs. SpecialPages hardwiring - 10https://bugzilla.wikimedia.org/8473#c8 (10Andre Klapper) p:5Low>3Lowest s:5normal>3enhanc Likely a WONTFIX as per comment 1. Lowering priority to reflect reality... [16:36:12] (03PS10) 10Reedy: Fix GitInfo cache file path computation and storage location [core] - 10https://gerrit.wikimedia.org/r/142319 (https://bugzilla.wikimedia.org/53972) (owner: 10BryanDavis) [16:36:29] (03PS3) 10EBernhardson: Escape topic title HTML shown in h1 firstHeading [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143552 (https://bugzilla.wikimedia.org/67401) (owner: 10Spage) [16:36:41] (03CR) 10EBernhardson: [C: 032] Escape topic title HTML shown in h1 firstHeading [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143552 (https://bugzilla.wikimedia.org/67401) (owner: 10Spage) [16:36:56] (03PS5) 10EBernhardson: Only allow one form of summarize or close to be open at a time [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143522 (https://bugzilla.wikimedia.org/67217) (owner: 10Jdlrobson) [16:37:35] (03PS2) 10Jack Phoenix: New 'UserResetAllOptions' hook from the wikiHow codebase. [core] - 10https://gerrit.wikimedia.org/r/144689 [16:38:01] (03Merged) 10jenkins-bot: Escape topic title HTML shown in h1 firstHeading [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143552 (https://bugzilla.wikimedia.org/67401) (owner: 10Spage) [16:38:04] 3MediaWiki / 3Skin and page rendering: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - 10https://bugzilla.wikimedia.org/38638 (10Nemo) [16:38:11] (03CR) 10Reedy: [C: 032] Fix GitInfo cache file path computation and storage location [core] - 10https://gerrit.wikimedia.org/r/142319 (https://bugzilla.wikimedia.org/53972) (owner: 10BryanDavis) [16:38:36] Reedy: \o/ ty [16:38:58] See if it works on Thursday ;) [16:40:05] The wm-config patch will need to go for that too. Maybe we can swat that today to test in beta? [16:40:23] (03PS3) 10Jack Phoenix: New 'UserResetAllOptions' hook from the wikiHow codebase. [core] - 10https://gerrit.wikimedia.org/r/144689 [16:40:48] 3MediaWiki / 3Skin and page rendering: System messages (tracking) - 10https://bugzilla.wikimedia.org/18521#c3 (10Andre Klapper) What's the exact difference of this tracking bug compared to bug 38638? Specifying in the bug summary very welcome (verbs always welcome in a bug summary) [16:41:54] cscott: Thanks for your comments in here https://gerrit.wikimedia.org/r/#/c/144656/. Can you tell me a bit on how we will implement the IP whitelisting ? Is there some inbuilt wiki functions to restrict the API calls ? [16:42:05] (03CR) 10Brian Wolff: Android native browser ending playback after 1 second (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144352 (https://bugzilla.wikimedia.org/43748) (owner: 10Brian Wolff) [16:42:09] (03Merged) 10jenkins-bot: Fix GitInfo cache file path computation and storage location [core] - 10https://gerrit.wikimedia.org/r/142319 (https://bugzilla.wikimedia.org/53972) (owner: 10BryanDavis) [16:42:14] * oops! that was for csteipp. [16:42:53] (03CR) 10Siebrand: [C: 04-1] "Re-add unaddressed comments of PS11." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/143025 (owner: 10Kunalgrover05) [16:44:27] csteipp: Hi! can you just explain a bit on how we will implement the IP whitelisting ? - like is there some inbuilt MW functions to do that ? [16:46:07] tonythomas: Hmm.. you could look at GlobalBlocking, which has a local wiki whitelist which can override the block. I wouldn't make it too complicated in your scenario-- [16:46:28] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144484 (owner: 10Paladox) [16:46:31] 3MediaWiki / 3Skin and page rendering: System messages structure (tracking) - 10https://bugzilla.wikimedia.org/18521#c4 (10Nemo) (In reply to Andre Klapper from comment #3) > What's the exact difference of this tracking bug compared to bug 38638? Per comment 0 and comment 2, this is about system messages as... [16:46:51] Probably just a global with an array of IP addresses, and make sure that the request's IP is in that array would be sufficient. [16:46:58] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144664 (https://bugzilla.wikimedia.org/59835) (owner: 10Matthias Mullie) [16:47:44] csteipp: by using if($_SERVER['REMOTE_ADDR'] == "$IP" ) ? [16:47:47] 3MediaWiki / 3Skin and page rendering: System messages structure (tracking) - 10https://bugzilla.wikimedia.org/18521#c5 (10Nemo) (Though in practice this tracking bug doesn't seem to really be used.) [16:48:09] You houldn't probably be using $_SERVER directly [16:48:14] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143288 (owner: 10Matthias Mullie) [16:48:16] And why wrap $IP in ""? [16:48:32] tonythomas: You want to use the request's getIP() (iirc?) method, which will account for the frontend proxies [16:48:51] Yeah, should be fine from WebRequest [16:49:00] tonythomas: And you probably want your whitelist to be something like, [16:49:30] $wgEximIPs=>array( "1.2.3.4" => true ); [16:49:41] Reedy: oh. that was a mistake. The API is called with a curl POST request by the MX's exim -- so we need to get the IP of the calling MX [16:49:48] 3MediaWiki / 3Skin and page rendering: System messages (tracking) - 10https://bugzilla.wikimedia.org/18521#c6 (10Happy-melon) (In reply to Andre Klapper from comment #3) > What's the exact difference of this tracking bug compared to bug 38638? > Specifying in the bug summary very welcome (verbs always welco... [16:49:59] Then do, if ( $wgEximIPs[$ip] ) { blah.. } [16:50:44] bd808: Might aswell, then it's done and in place then [16:50:53] csteipp: ok. That looks straightforward. [16:50:58] Actually, I think we have IP::inRange(), or something like that... so you could do a foreach on your global array. And then the array could contain netmasks. [16:51:11] Yeah [16:51:31] There's some wrapper stuffs [16:51:37] (03PS2) 10Umherirrender: Use Database::makeWhereFrom2d in LinkHolderArray::replaceInternal [core] - 10https://gerrit.wikimedia.org/r/143713 [16:51:53] IP::inRange() ? [16:52:10] (03PS4) 10Jack Phoenix: New 'UserResetAllOptions' hook from the wikiHow codebase. [core] - 10https://gerrit.wikimedia.org/r/144689 [16:52:26] isInRange() [16:53:00] if ( isNice() ) iLike(); [16:53:42] Reedy: so this should go inside the API file ? or in the extension.php ? [16:54:33] I'm not sure... I've not got the full context here [16:55:47] Reedy: I added https://gerrit.wikimedia.org/r/#/c/142320/ for SWAT today. A +1 from you would be nice. It will be a no-op in prod until the Thursday deploy but I can test in beta as soon as it is merged. [16:56:02] Ah [16:56:08] I could've just done it in the usual deploy window [16:56:09] Reedy: exim, on reception of the bounce email calls the API and gives it a curl POST request -- our data ( the bounce email ). [16:56:11] either way :) [16:56:24] (03CR) 10EBernhardson: [C: 04-1] "browsertests are failing" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143522 (https://bugzilla.wikimedia.org/67217) (owner: 10Jdlrobson) [16:57:47] (03PS14) 10Kunalgrover05: API method to change page language [core] - 10https://gerrit.wikimedia.org/r/143025 [16:57:57] (03PS3) 10Withoutaname: Enforce type hinting for RequestContext::setTitle() [core] - 10https://gerrit.wikimedia.org/r/144647 [16:58:15] (03CR) 10EBernhardson: [C: 032] Add tests for ifEquals helper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143943 (owner: 10Jdlrobson) [16:59:27] (03CR) 10EBernhardson: [C: 032] Add tests for Handlebars.prototype methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143944 (owner: 10Jdlrobson) [17:00:36] (03CR) 10jenkins-bot: [V: 04-1] Add tests for ifEquals helper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143943 (owner: 10Jdlrobson) [17:00:39] (03CR) 10jenkins-bot: [V: 04-1] Add tests for Handlebars.prototype methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143944 (owner: 10Jdlrobson) [17:01:19] (03PS4) 10Withoutaname: Enforce type hinting for setTitle() in IContextSource subclasses [core] - 10https://gerrit.wikimedia.org/r/144647 [17:01:50] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/141684 (owner: 10Smuggli) [17:03:35] (03PS1) 10Gerrit Patch Uploader: Move white-space: nowrap from PHP to CSS [core] - 10https://gerrit.wikimedia.org/r/144720 [17:03:37] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/144720 (owner: 10Gerrit Patch Uploader) [17:03:39] (03CR) 10Siebrand: [C: 04-1] "https://www.mediawiki.org/wiki/API:PageLanguage should be created." [core] - 10https://gerrit.wikimedia.org/r/143025 (owner: 10Kunalgrover05) [17:03:41] (03PS4) 10SG: Improve progressiveEnhancement to support inline Handlebars content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144699 [17:04:54] (03PS3) 10SG: Correct mw-ui button to inherit font from parent [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144700 [17:05:12] (03PS2) 10EBernhardson: Add tests for ifEquals helper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143943 (owner: 10Jdlrobson) [17:05:15] (03PS2) 10EBernhardson: Add tests for Handlebars.prototype.callHelper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143945 (owner: 10Jdlrobson) [17:05:22] (03PS2) 10EBernhardson: Add tests for Handlebars.prototype methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143944 (owner: 10Jdlrobson) [17:05:48] 3MediaWiki extensions / 3CentralAuth: if last local account is moved sul should be deleted by itself - 10https://bugzilla.wikimedia.org/22673#c2 (10Dan Garry) 5NEW>3RESO/WON At this stage it makes more sense for us to focus on the underlying problem, namely completing the SUL finalisation. Once that happ... [17:06:28] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/139277 (https://bugzilla.wikimedia.org/20476) (owner: 10Vogone) [17:06:59] (03PS3) 10SG: Improvements and fixes to topic summarization [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144701 [17:07:58] (03PS3) 10SG: Ignore whitespace in compiled handlebars templates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144702 [17:08:26] (03PS4) 10SG: Ignore whitespace in compiled handlebars templates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144702 [17:09:31] (03PS4) 10SG: Improvements and fixes to topic summarization [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144701 [17:10:26] (03CR) 10Rush: "error seen trying to view my profile:" [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/144711 (owner: 1020after4) [17:10:27] Reedy: Feel free to push it in your deploy window if you have a chance. Then I can test it sooner rather than later. [17:10:35] (03CR) 10Rush: "error seen trying to view my profile:" [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/144711 (owner: 1020after4) [17:11:04] (03CR) 10SG: [C: 04-1] "Functionality has changed. Please see https://gerrit.wikimedia.org/r/#/c/144701/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144701 (owner: 10SG) [17:12:04] (03CR) 10SG: [C: 04-1] "Functionality has changed. Please see https://gerrit.wikimedia.org/r/#/c/144701/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143522 (https://bugzilla.wikimedia.org/67217) (owner: 10Jdlrobson) [17:12:19] (03CR) 10SG: "Dammit, I meant to post that on https://gerrit.wikimedia.org/r/#/c/143522/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144701 (owner: 10SG) [17:15:08] (03PS1) 10EBernhardson: Add qunit scripts to make jshint [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144722 [17:15:30] (03PS4) 10Rohan013: Removes depreciated $wgUseCommaCount variable [core] - 10https://gerrit.wikimedia.org/r/139842 (https://bugzilla.wikimedia.org/60454) [17:15:48] 3MediaWiki / 3Unit tests: Something in unit tests is doing something funky with the session - 10https://bugzilla.wikimedia.org/67656#c4 (10Chad H.) Fresh VM did no good. Same results as the previous. [17:15:55] <^d> brion: Creepy bug is creepy ^ [17:16:09] (03CR) 10EBernhardson: [C: 032] Add tests for ifEquals helper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143943 (owner: 10Jdlrobson) [17:16:53] aaaaaaah session scariness sounds scary [17:17:06] (03Merged) 10jenkins-bot: Add tests for ifEquals helper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143943 (owner: 10Jdlrobson) [17:17:32] (03CR) 10EBernhardson: [C: 032] Add tests for Handlebars.prototype methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143944 (owner: 10Jdlrobson) [17:17:40] (03CR) 10EBernhardson: [C: 032] Add tests for Handlebars.prototype.callHelper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143945 (owner: 10Jdlrobson) [17:17:52] (03CR) 10EBernhardson: [C: 032] Add qunit scripts to make jshint [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144722 (owner: 10EBernhardson) [17:17:54] <^d> brion: Other than "get another cup of coffee and good luck!" don't suppose you have a direction to point me in? [17:17:55] (03Merged) 10jenkins-bot: Add tests for Handlebars.prototype methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143944 (owner: 10Jdlrobson) [17:18:07] (03Merged) 10jenkins-bot: Add tests for Handlebars.prototype.callHelper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143945 (owner: 10Jdlrobson) [17:18:20] (03Merged) 10jenkins-bot: Add qunit scripts to make jshint [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144722 (owner: 10EBernhardson) [17:18:36] ^d: well ‘session id is too long or contains illegal characters’ is a little suspicious [17:18:55] might want to check the session cookie and confirm it’s not getting ocrrupted somehow [17:19:11] <^d> Yeah, I've been poking at our wfSetup/ResetSession functions. But phpunit takes over all output making debugging a PITA. [17:20:29] (03CR) 10EBernhardson: [C: 032] OBOD should be cleared when visiting Flow-enabled talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144093 (owner: 10Bsitu) [17:20:30] well the ‘line 0’ makes me think the error’s coming in at script setup time, before our code runs [17:20:37] or is that some eval crap [17:20:49] (03Merged) 10jenkins-bot: OBOD should be cleared when visiting Flow-enabled talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144093 (owner: 10Bsitu) [17:21:07] (03PS2) 10EBernhardson: Drop unused flow_block_topic_reply.handlebars [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144162 (owner: 10Jdlrobson) [17:21:08] <^d> brion: I don't think we eval() any crud in that part of the tests anymore. [17:21:17] weird [17:21:56] <^d> I'm waiting to stumble on the one-line fix that has a 3 to 5 paragraph commit summary. [17:21:57] <^d> :p [17:23:02] (03CR) 10EBernhardson: [C: 04-2] "This template is still used for the no-js page used when the user clicks `reply`" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144162 (owner: 10Jdlrobson) [17:24:35] (03PS2) 10EBernhardson: Componentise ext.flow.new.styles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144163 (owner: 10Jdlrobson) [17:27:05] (03CR) 10EBernhardson: [C: 032] Componentise ext.flow.new.styles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144163 (owner: 10Jdlrobson) [17:27:22] (03Merged) 10jenkins-bot: Componentise ext.flow.new.styles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144163 (owner: 10Jdlrobson) [17:39:08] Reedy: when you are free https://gerrit.wikimedia.org/r/#/c/143004/ [17:40:03] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Add cache warming - 10https://bugzilla.wikimedia.org/67094#c1 (10Nik Everett) 5NEW>3RESO/FIX a:3Nik Everett Done and deployed. I'm not sure how much effect it had, but I'm hoping. [17:40:42] (03PS8) 10SG: Error handling for open/close topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143314 (owner: 10Matthias Mullie) [17:40:47] (03CR) 10jenkins-bot: [V: 04-1] Error handling for open/close topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143314 (owner: 10Matthias Mullie) [17:41:47] 3MediaWiki / 3Maintenance scripts: Can't render large page when using hhvm - 10https://bugzilla.wikimedia.org/67625#c2 (10Nik Everett) I'm also not sure now if the large page is the trouble or the starvation caused by having the large page hit the job queue as well. [17:42:18] 3MediaWiki / 3Page editing: After upgrading from 1.15 to 1.23 get "Error: 1267 Illegal mix of collations" - 10https://bugzilla.wikimedia.org/66277#c7 (10Andrei K) I had upgraded both, Mediawiki and MySQL. Anyway, I have reverted to 1.19 version. It works fine for me. So, you could close the issue. [17:42:47] 3Wikimedia / 3Deployment systems: [scap] Deployment: Repository .git is synchronised fine, but is broken for submodules because of hardcoded gitdir link - 10https://bugzilla.wikimedia.org/53972#c23 (10James Forrester) 5PATC>3RESO/FIX Yay, thanks Bryan. [17:44:19] 3Wikimedia / 3Deployment systems: [scap] Deployment: Repository .git is synchronised fine, but is broken for submodules because of hardcoded gitdir link - 10https://bugzilla.wikimedia.org/53972 (10James Forrester) [17:44:19] 3Wikimedia / 3Site requests: Difficult for users to know what exact version of each extension is running on the cluster - 10https://bugzilla.wikimedia.org/50879#c3 (10James Forrester) 5NEW>3RESO/FIX a:3Bryan Davis With bug 53972 now fixed, this is now fixed in Beta Labs (see http://en.wikipedia.beta.wm... [17:45:30] (03PS5) 10SG: Improvements and fixes to topic summarization [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144701 [17:46:15] (03PS7) 10SG: Error handling for Summarise and edit summary topic actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143293 (owner: 10Matthias Mullie) [17:46:50] 3Wikimedia / 3Language setup: Remove the combo box of scripts on search bar of side bar. - 10https://bugzilla.wikimedia.org/67680 (10Nepaboy) 3NEW p:3Unprio s:3normal a:3None Created attachment 15870 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15870&action=edit remove the combo box over th... [17:47:24] (03PS9) 10SG: Error handling for open/close topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143314 (owner: 10Matthias Mullie) [17:47:36] (03PS9) 10SG: Error handling for moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143315 (owner: 10Matthias Mullie) [17:47:48] (03PS9) 10SG: Error handling for view-topiclist actions (change sort & load more) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143342 (owner: 10Matthias Mullie) [17:48:10] (03CR) 10Krinkle: [C: 04-1] "Hm.. I think these classes would be much easier to work with if they used the number in their name instead of "whole", "half", "two-quarte" [core] - 10https://gerrit.wikimedia.org/r/125387 (owner: 10Pginer) [17:51:23] (03CR) 10Smuggli: [C: 032 V: 032] Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/141684 (owner: 10Smuggli) [17:59:16] (03PS2) 10Jdlrobson: Hygiene: Remove unused BoardHistory formatter class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144596 (owner: 10EBernhardson) [18:00:26] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove unused BoardHistory formatter class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144596 (owner: 10EBernhardson) [18:00:47] (03Merged) 10jenkins-bot: Hygiene: Remove unused BoardHistory formatter class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144596 (owner: 10EBernhardson) [18:02:17] 3MediaWiki / 3Maintenance scripts: Can't render large page when using hhvm - 10https://bugzilla.wikimedia.org/67625#c3 (10Nik Everett) I added timeouts to the end of the access logs. This look unhealthy: - - [08/Jul/2014:17:57:25 +0000] \”POST /w/index.php?title=Special%3ARunJobs&tasks=jobs&maxjobs=100&sig... [18:03:03] 3MediaWiki / 3Skin and page rendering: System messages structure (tracking) - 10https://bugzilla.wikimedia.org/18521 (10Andre Klapper) [18:04:25] (03PS2) 1020after4: CustomField extension that adds a "MediaWiki Userpage" link on phabricator user profile pages when a phabricator account is linked to mediawiki oauth. [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/144711 [18:04:51] (03CR) 1020after4: "@rush fixed" [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/144711 (owner: 1020after4) [18:04:57] (03CR) 10Jdlrobson: [C: 032] Improvements and fixes to topic summarization [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144701 (owner: 10SG) [18:05:19] (03Merged) 10jenkins-bot: Improvements and fixes to topic summarization [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144701 (owner: 10SG) [18:05:34] (03Merged) 10jenkins-bot: Error handling for Summarise and edit summary topic actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143293 (owner: 10Matthias Mullie) [18:06:18] (03CR) 10Rush: "can you update in labs? not sure where this exists" [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/144711 (owner: 1020after4) [18:07:00] (03CR) 10CSteipp: [C: 031] "I forgot to submit the draft comment I had saying yeah, don't use preg_quote. This looks like a much easier to maintain solution, thanks!" [core] - 10https://gerrit.wikimedia.org/r/144249 (https://bugzilla.wikimedia.org/11106) (owner: 10Danielrenfro) [18:08:17] 3MediaWiki / 3Maintenance scripts: Can't render large page when using hhvm - 10https://bugzilla.wikimedia.org/67625#c4 (10Nik Everett) 5NEW>3ASSI Clicking the "edit" button on my large page took 28 seconds in browser but was logged as taking 8.6 in the access log.... Posting the page timed out at the ap... [18:08:49] 3MediaWiki extensions / 3WikidataRepo: Fatal error: Call to a member function exists() on a non-object in SearchEntities.php on line 151 - 10https://bugzilla.wikimedia.org/67681 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs spotted in the logs: Fatal error: Call to a member function exists() on... [18:08:50] (03CR) 10Jjanes: [C: 031] "This address my concerns for bug 64043 when using PostgreSQL, under both the web installer and the CLI installer." [core] - 10https://gerrit.wikimedia.org/r/142472 (owner: 10Skizzerz) [18:09:22] (03CR) 10Krinkle: "Accept-Charset is not a requirement, it's a suggestion/optimisation (per the spec "sending of an unacceptable response is also allowed.")," [core] - 10https://gerrit.wikimedia.org/r/142052 (owner: 10MaxSem) [18:10:25] (03CR) 10Jdlrobson: "Are you sure? I grep for it and nothing..." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144162 (owner: 10Jdlrobson) [18:10:52] (03CR) 10Jdlrobson: "Also why 2 templates for the same thing?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144162 (owner: 10Jdlrobson) [18:12:02] 3Wikimedia / 3SSL related: Add Forward Secrecy - 10https://bugzilla.wikimedia.org/53259#c21 (10Daniel Zahn) meanwhile dumps and lists have been fixed it seems dumps.wikimedia.org Experimental: This server is not vulnerable to the OpenSSL CCS vulnerability (CVE-2014-0224). lists.wikimedia.org Experiment... [18:13:15] (03CR) 10Jdlrobson: "im confused.. is this still a WIP?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 (owner: 10Bsitu) [18:13:40] (03CR) 10Krinkle: "@Anomie: Sorry, but that's no good enough. Backwards compatibility with what/who? Enabling this here is very close to enabling it by defau" [core] - 10https://gerrit.wikimedia.org/r/142052 (owner: 10MaxSem) [18:13:54] (03CR) 10Jdlrobson: [C: 04-1] "... tests?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144704 (owner: 10SG) [18:14:31] (03CR) 10Bsitu: "Jon. yes and no, :), I need to rebase it against a couple of patches" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 (owner: 10Bsitu) [18:16:00] (03CR) 10Jdlrobson: [C: 032] Improve progressiveEnhancement to support inline Handlebars content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144699 (owner: 10SG) [18:16:16] 3MediaWiki / 3Maintenance scripts: Can't render large page when using hhvm - 10https://bugzilla.wikimedia.org/67625#c5 (10Nik Everett) Actually, its caused by instant commons, I believe. It looks like it tries to fetch everything as soon as the page is created. Tries over and over again. [18:16:23] (03Merged) 10jenkins-bot: Improve progressiveEnhancement to support inline Handlebars content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144699 (owner: 10SG) [18:17:24] (03CR) 10Legoktm: [C: 031] "Looks good to me, I can think of quite a few extensions where this hook will be useful." [core] - 10https://gerrit.wikimedia.org/r/144689 (owner: 10Jack Phoenix) [18:19:09] (03Abandoned) 10MaxSem: mediawiki.api: request unescaped UTF-8 entities in JSON format [core] - 10https://gerrit.wikimedia.org/r/142052 (owner: 10MaxSem) [18:20:46] 3Wikimedia / 3SSL related: Add Forward Secrecy - 10https://bugzilla.wikimedia.org/53259#c22 (10Nemo) It's a bit unpractical to have one comment for each domain. Jan and chmarkine, it would be IMHO more useful if you resurrected https://wikitech.wikimedia.org/wiki/Httpsless_domains to make a table of which do... [18:22:15] (03Abandoned) 10MaxSem: Make ResourceLoader minifiers extendable [core] - 10https://gerrit.wikimedia.org/r/74293 (owner: 10MaxSem) [18:22:45] (03Abandoned) 10MaxSem: Add blobs support to ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/111250 (owner: 10MaxSem) [18:23:23] Krinkle: Isn't mw.util.getUrl getting deprecated? Or is it now preferred over whatever we used to use [18:23:26] I forget [18:25:21] marktraceur: wikiGetlink -> getUrl [18:25:42] Right. [18:25:43] OK [18:25:47] Just checking [18:26:38] (03CR) 10Jdlrobson: [C: 04-1] "* No error shown to user when doing a sort. Just fails silently. I'm fine with that, but is that the desired behaviour? Please document in" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143342 (owner: 10Matthias Mullie) [18:27:47] (03CR) 10EBernhardson: "ok quick overview, all template rendering from the backend starts at flow_board.handlebars. From there it essentially uses" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144162 (owner: 10Jdlrobson) [18:28:20] 3MediaWiki extensions / 3WikidataRepo: Fatal error: Call to undefined method Wikibase\Lib\Store\WikiPageEntityRevisionLookup::getEn tity() in UpdateRepoOnMoveJob.php on line 154 - 10https://bugzilla.wikimedia.org/67682 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Fatal error: Call to undefined... [18:30:32] (03CR) 10Jdlrobson: [C: 031] "Not sure how to test..." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143315 (owner: 10Matthias Mullie) [18:31:33] (03PS3) 10Jdlrobson: Handle post edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144449 (owner: 10Matthias Mullie) [18:31:39] (03CR) 10jenkins-bot: [V: 04-1] Handle post edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144449 (owner: 10Matthias Mullie) [18:32:20] (03CR) 10Reedy: Added SwiftMailer Extension to provide an alternate for UserMailer (031 comment) [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 (owner: 1001tonythomas) [18:32:32] 3Wikimedia / 3General/Unknown: bits.wikimedia.org discourages indexing, resulting in goofy archive.org snapshots - 10https://bugzilla.wikimedia.org/65464#c5 (10Nemo) 5PATC>3RESO/FIX https://bits.wikimedia.org/robots.txt looks good but the effects can be verified only after it gets recrawled; currently e.... [18:32:54] (03CR) 10Reedy: [C: 04-1] Added SwiftMailer Extension to provide an alternate for UserMailer (031 comment) [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 (owner: 1001tonythomas) [18:33:15] (03PS2) 10Jdlrobson: Error messages can contains HTML [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144662 (owner: 10Matthias Mullie) [18:33:26] (03CR) 10Jdlrobson: [C: 032] "Sigh. ConfirmEdit API makes me sad." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144662 (owner: 10Matthias Mullie) [18:34:02] (03Merged) 10jenkins-bot: Error messages can contains HTML [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144662 (owner: 10Matthias Mullie) [18:34:20] (03CR) 10Krinkle: [C: 031] "It does make sense when they're slow queries. And this also takes care of caching ResourceLoader minification and anything else that uses " [core] - 10https://gerrit.wikimedia.org/r/117091 (owner: 10MaxSem) [18:35:05] (03PS13) 10Bsitu: [WIP]Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 [18:35:58] (03CR) 10Reedy: Added SwiftMailer Extension to provide an alternate for UserMailer (031 comment) [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 (owner: 1001tonythomas) [18:36:24] (03CR) 10Jdlrobson: [C: 04-1] "Please rebase!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144663 (owner: 10Matthias Mullie) [18:36:27] (03CR) 10Bsitu: [C: 04-1] [WIP]Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 (owner: 10Bsitu) [18:37:05] (03CR) 10Krinkle: Integrate Special:MyLanguage from E:Translate (031 comment) [core] - 10https://gerrit.wikimedia.org/r/140765 (https://bugzilla.wikimedia.org/66762) (owner: 10MaxSem) [18:42:35] (03CR) 10Jdlrobson: [C: 031] disable wikitext processing in history content snippets [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144591 (https://bugzilla.wikimedia.org/67546) (owner: 10EBernhardson) [18:42:47] 3Utilities / 3code-utils: [tools/code-utils] check-vars.php: Add optional warning to passing $this by reference - 10https://bugzilla.wikimedia.org/29300 (10Krinkle) s:5normal>3enhanc [18:42:56] (03PS22) 10Gilles: Generate thumbnails based on buckets [core] - 10https://gerrit.wikimedia.org/r/135008 (https://bugzilla.wikimedia.org/67525) [18:44:32] 3MediaWiki / 3API: Can't render large page when using hhvm - 10https://bugzilla.wikimedia.org/67625#c6 (10Nik Everett) Recreated with zend. Each http get for something like http://commons.wikimedia.org/w/api.php?titles=File%3AMohammad_adil-Muslim_conquest_of_Egypt.PNG&iiprop=timestamp%7Cuser%7Ccomment%7Curl... [18:44:56] (03CR) 10Parent5446: [C: 04-1] Added SwiftMailer Extension to provide an alternate for UserMailer (036 comments) [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 (owner: 1001tonythomas) [18:47:49] 3MediaWiki-Vagrant: Can't render large page when using hhvm - 10https://bugzilla.wikimedia.org/67625#c7 (10Nik Everett) a:3Ori Livneh Its a vagrant problem. Inside vagrant: $ time curl google.com 301 Moved<... [18:49:40] (03PS1) 10GWicke: Add unfloated thumb styling in Parsoid CSS [core] - 10https://gerrit.wikimedia.org/r/144733 [18:50:18] 3MediaWiki-Vagrant: Can't render large page when using hhvm - 10https://bugzilla.wikimedia.org/67625#c8 (10Chad H.) Connection problems? Sounds like what I was hitting yesterday / this morning. Still don't have a solution short of reloading the VM and hoping. [18:52:55] (03PS14) 10Bsitu: [WIP]Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 [18:55:54] (03CR) 10Bsitu: [C: 04-1] "Things are broken after rebasing against master, fixing" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 (owner: 10Bsitu) [18:58:19] 3MediaWiki-Vagrant: Can't render large page when using hhvm - 10https://bugzilla.wikimedia.org/67625#c9 (10Nik Everett) a:5Ori Livneh>3Nik Everett Not connection problems - its dns resolution! I have a fix but it is somewhat mysterious. [18:59:16] <^d> manybubbles: dns being wonky would totally explain my problem too. [18:59:23] * ^d awaits the mysterious fix [18:59:32] ^d: its about to be posted for review [19:02:02] 3MediaWiki-Vagrant: DNS resolution on the virtual host is painfully slow - 10https://bugzilla.wikimedia.org/67625 (10Nik Everett) [19:02:04] (03PS1) 10Manybubbles: Speed up dns resolution in some cases [vagrant] - 10https://gerrit.wikimedia.org/r/144738 (https://bugzilla.wikimedia.org/67625) [19:03:12] (03CR) 10Cscott: [C: 032] Add unfloated thumb styling in Parsoid CSS [core] - 10https://gerrit.wikimedia.org/r/144733 (owner: 10GWicke) [19:03:52] (03CR) 10Cscott: "@Brion: ping!" [core] - 10https://gerrit.wikimedia.org/r/141742 (https://bugzilla.wikimedia.org/67042) (owner: 10Cscott) [19:04:02] (03CR) 10Manybubbles: "Test it by timing curl to google.com on the virtual machine. Went from 5.5 seconds to <100ms for me. Before the fix curl to one of googl" [vagrant] - 10https://gerrit.wikimedia.org/r/144738 (https://bugzilla.wikimedia.org/67625) (owner: 10Manybubbles) [19:05:31] 3Wikimedia / 3General/Unknown: Whitelist OASIS OpenDocument file format - 10https://bugzilla.wikimedia.org/2089 (10Steinsplitter) [19:06:00] Krinkle: btw, i wanted something like this and couldn't find it, so i rolled my own: https://github.com/atdt/git-itemize [19:06:03] Krinkle: thought you might like it [19:06:19] (03Merged) 10jenkins-bot: Add unfloated thumb styling in Parsoid CSS [core] - 10https://gerrit.wikimedia.org/r/144733 (owner: 10GWicke) [19:07:06] ^d: posted mysterious fix for review [19:07:09] (03PS15) 10Bsitu: Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 [19:08:16] 3Wikimedia / 3General/Unknown: Whitelist OASIS OpenDocument file format - 10https://bugzilla.wikimedia.org/2089 (10Nemo) [19:10:54] (03CR) 10Brion VIBBER: [C: 032] "Looks good!" [core] - 10https://gerrit.wikimedia.org/r/141742 (https://bugzilla.wikimedia.org/67042) (owner: 10Cscott) [19:12:00] (03CR) 10Swalling: "I tested both the current version and one with #555 in Firefox, Chrome, Safari, and IE down to version 8. Everything seems fine, and this " [core] - 10https://gerrit.wikimedia.org/r/133301 (https://bugzilla.wikimedia.org/65160) (owner: 10Jforrester) [19:12:08] jgonera: ^ [19:13:40] jgonera: https://gerrit.wikimedia.org/r/#/c/144733/ might be relevant for mobile as well [19:14:24] (03PS1) 10SG: Correct mw-ui.enhance test usage for buttons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144740 [19:15:28] (03PS12) 10Bsitu: Enable Topic namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143186 (owner: 10EBernhardson) [19:16:20] (03CR) 10Hashar: "I can see the use case at https://gerrit.wikimedia.org/r/#/c/143401/1/tests/CentralAuthDBTest.php" [core] - 10https://gerrit.wikimedia.org/r/143397 (owner: 10CSteipp) [19:16:43] (03CR) 10Hashar: "I commented on mediawiki/core change https://gerrit.wikimedia.org/r/#/c/143397/ about it. There might be a nicer workaround :-)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143401 (owner: 10CSteipp) [19:16:49] 3MediaWiki-Vagrant: Removing the zend role doesn't revert to hhvm - 10https://bugzilla.wikimedia.org/67683 (10Nik Everett) 3NEW p:3Unprio s:3normal a:3Ori Livneh Reproduce by adding the zend role, provisioning, then removing it. The /etc/apache2/envvars still contains the ZEND define. [19:18:14] (03PS13) 1001tonythomas: Added SwiftMailer Extension to provide an alternate for UserMailer [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 [19:19:43] (03PS3) 10Bsitu: Complete flow-ui-tooltip JS, correct tooltip styling to white bg [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144704 (owner: 10SG) [19:21:25] (03PS14) 1001tonythomas: Added SwiftMailer Extension to provide an alternate for UserMailer [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 [19:23:51] (03PS4) 10SG: Complete flow-ui-tooltip JS, correct tooltip styling to white bg [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144704 [19:24:03] (03CR) 1001tonythomas: "@Reedy:- actually, composer takes up the repo from https://github.com/wikimedia/mediawiki-core-vendor-swiftmailer/tree/5.2.0-patch as we a" [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 (owner: 1001tonythomas) [19:24:18] 3MediaWiki / 3Special pages: Postgresql: non-integer constant in ORDER BY - 10https://bugzilla.wikimedia.org/67594#c1 (10Jeff Janes) Reproduced by simply going to http://localhost/wiki/index.php/Special:ActiveUsers The "ORDER BY NULL" optimization seems to be MySQL peculiarity. includes/specials/SpecialAc... [19:26:09] (03CR) 10SG: [C: 04-2] "This is wrong. flow-ui-button is a replacement for mw-ui-button, but has yet to be merged into core. Once the new version goes in, then we" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144164 (owner: 10Jdlrobson) [19:27:02] 3Wikimedia / 3SSL related: Add Forward Secrecy - 10https://bugzilla.wikimedia.org/53259#c26 (10Daniel Zahn) all services behind the misc. varnish cluster should be fixed now. they were lacking an nginx restart on cp1043/cp1044, which i did now this should have fixed all these: doc git... [19:27:21] (03PS13) 10SG: Enable Topic namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143186 (owner: 10EBernhardson) [19:27:24] (03PS5) 10SG: Complete flow-ui-tooltip JS, correct tooltip styling to white bg [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144704 [19:27:28] legoktm: around? [19:27:36] yes [19:27:42] what's up? [19:27:56] making transclusions produce pretty output doesn't look possible [19:28:11] because they need to provide wikitext to the parser, and all they have is html [19:28:42] and i can't even build an extension tag that parses the json to html, because the json might contain and there's no way to escape [19:29:02] wasn't there a wikitech discussion about this? [19:29:10] about and expandtemplates and other stuff? [19:29:31] but ugh :/ [19:31:02] 3MediaWiki-Vagrant: DNS resolution on the virtual host is painfully slow - 10https://bugzilla.wikimedia.org/67625#c11 (10Bryan Davis) Possibly related to https://www.virtualbox.org/ticket/11663 and a lot of other VirtualBox host-only netowrking problems listed as see-alsos on that bug. [19:31:24] (03CR) 10Parent5446: [C: 04-1] "More comments. Also, remember to add a LICENSE file (MediaWiki will link to it on Special:Version)." (036 comments) [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 (owner: 1001tonythomas) [19:32:47] 3MediaWiki-Vagrant: DNS resolution on the virtual host is painfully slow - 10https://bugzilla.wikimedia.org/67625#c12 (10Nik Everett) (In reply to Bryan Davis from comment #11) > Possibly related to https://www.virtualbox.org/ticket/11663 and a lot of > other VirtualBox host-only netowrking problems listed as... [19:33:13] (03PS2) 10BryanDavis: Speed up dns resolution in some cases [vagrant] - 10https://gerrit.wikimedia.org/r/144738 (https://bugzilla.wikimedia.org/67625) (owner: 10Manybubbles) [19:33:43] (03CR) 10BryanDavis: [C: 032] "Users will need to `vagrant reload` to have this take effect." [vagrant] - 10https://gerrit.wikimedia.org/r/144738 (https://bugzilla.wikimedia.org/67625) (owner: 10Manybubbles) [19:33:55] (03Merged) 10jenkins-bot: Speed up dns resolution in some cases [vagrant] - 10https://gerrit.wikimedia.org/r/144738 (https://bugzilla.wikimedia.org/67625) (owner: 10Manybubbles) [19:34:03] i think one of wikitext's biggest flaws is its lack of escaping ability (which is why {{!}} is even a thing) [19:35:19] <^d> I think wikitext's biggest flaw was allowing ParserFunctions. [19:35:25] <^d> But I guess we all have opinions :) [19:37:22] Hi. I know very little about puppet, but I'm experienced with Vagrant. Trying to install the "uploadwizard" role in mediawiki-vagrant, and I'm getting "Could not find class python::pil". Is this an error with configuration, or whatever serves wikimedia's puppet files, or? [19:37:31] 3MediaWiki / 3Special pages: Create an option to toggle gallery mode off for Special:NewFiles and Special:UnusedFiles - 10https://bugzilla.wikimedia.org/14964#c2 (10charitwo) Utility first, loading times second. These special pages are useful in maintaining wiki images (both old and new), because these pages... [19:37:52] ^d: i think that's its biggest redeeming quality [19:38:34] <^d> To each their own! [19:38:34] 3MediaWiki / 3HTMLForm: hide-if boolean combiners no longer work - 10https://bugzilla.wikimedia.org/67685 (10Brad Jorsch) 3NEW p:3Unprio s:3normal a:3None When a field has a data-hide-if such as '["OR",["===","foo","bar"],["===","foo","baz"]]', the field is not properly shown or hidden when element "... [19:39:13] (03PS16) 10Bsitu: Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 [19:41:45] (03PS1) 10Legoktm: Pass $this->suppressRC to the proper parameter [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144743 [19:42:47] 3MediaWiki-Vagrant: DNS resolution on the virtual host is painfully slow - 10https://bugzilla.wikimedia.org/67625#c14 (10Bryan Davis) 5PATC>3RESO/FIX Don't forget to restart the VirtualBox guest after applying the patch: `vagrant reload` works well. [19:43:31] 3Wikimedia / 3Mailing lists: Wrong cert on mail.wikipedia.org (as it redirects to lists.wikimedia.org) - 10https://bugzilla.wikimedia.org/44731#c7 (10Jan Zerebecki) The google result might change its URL if we add a permanent HTTP redirect from mail.wikipedia.org to lists.wikimedia.org (maybe add some of its... [19:44:46] (03PS15) 1001tonythomas: Added SwiftMailer Extension to provide an alternate for UserMailer [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 [19:46:29] (03PS1) 10Cscott: Add tag support to RELEASE-NOTES-1.24. [core] - 10https://gerrit.wikimedia.org/r/144745 (https://bugzilla.wikimedia.org/67042) [19:47:14] (03CR) 10Brion VIBBER: [C: 032] Add tag support to RELEASE-NOTES-1.24. [core] - 10https://gerrit.wikimedia.org/r/144745 (https://bugzilla.wikimedia.org/67042) (owner: 10Cscott) [19:48:47] 3Wikimedia / 3Site requests: FeaturedFeeds extension: Set feed limit for monthly featured articles on la.wikipedia - 10https://bugzilla.wikimedia.org/33978#c9 (10uv.wiki) Yes, the bug is still relevant. I would be happy to make FeaturedFeeds work for la.wikipedia featured articles once this bug is fixed (and... [19:50:58] (03Merged) 10jenkins-bot: Add tag support to RELEASE-NOTES-1.24. [core] - 10https://gerrit.wikimedia.org/r/144745 (https://bugzilla.wikimedia.org/67042) (owner: 10Cscott) [19:51:02] (03CR) 10Krinkle: [C: 04-1] "Notice: Undefined index: help in mediawiki/includes/installer/WebInstaller.php on line 988" [core] - 10https://gerrit.wikimedia.org/r/138652 (https://bugzilla.wikimedia.org/66440) (owner: 10Bartosz Dziewoński) [19:53:25] (03CR) 10Anomie: "@Krinkle: Backwards compatibility with all the various bots and tools that volunteers have written with who-knows-what JSON decoders in wh" [core] - 10https://gerrit.wikimedia.org/r/142052 (owner: 10MaxSem) [19:54:57] (03PS2) 10Jdlrobson: Summarizing a topic makes previous history invisible [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144616 (https://bugzilla.wikimedia.org/67502) (owner: 10EBernhardson) [19:55:25] (03CR) 10Jdlrobson: [C: 04-1] "Can't seem to replicate bug on latest master. Did it fix itself?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144616 (https://bugzilla.wikimedia.org/67502) (owner: 10EBernhardson) [19:55:34] 3Wikimedia / 3SSL related: Lots of servers are vulnerable to the OpenSSL CCS vulnerability (CVE-2014-0224) - 10https://bugzilla.wikimedia.org/67564#c2 (10Jan Zerebecki) 5NEW>3RESO/FIX All of those and some more are fixed now. See also https://bugzilla.wikimedia.org/show_bug.cgi?id=53259#c26 . [19:55:56] (03PS16) 1001tonythomas: Added SwiftMailer Extension to provide an alternate for UserMailer [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 [19:56:56] (03CR) 10EBernhardson: "if you can't replicate it you might just not have flow caching properly enabled?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144616 (https://bugzilla.wikimedia.org/67502) (owner: 10EBernhardson) [19:56:59] (03CR) 1001tonythomas: "@Parent5446 : done. added the licence file" [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 (owner: 1001tonythomas) [19:57:18] (03CR) 10Nemo bis: "Err, can't this just be restore and the first line of Anomie's response added to the commit message?" [core] - 10https://gerrit.wikimedia.org/r/142052 (owner: 10MaxSem) [19:57:40] StevenW, 3 weeks that Fabrice requested still haven't passed [19:57:51] (03PS1) 10BryanDavis: Use Ubuntu package for xdebug [vagrant] - 10https://gerrit.wikimedia.org/r/144747 [19:58:14] ^d: ^ [19:58:33] (03PS1) 10Manybubbles: Raise regex timeout to 120 seconds [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/144748 (https://bugzilla.wikimedia.org/67418) [19:58:37] <^d> bd808: reviewing. [19:58:41] neilk_: sounds like a legitimate bug; maybe it was included in the previous Ubuntu release or something? [19:58:57] (03PS2) 10Reedy: Pass $this->suppressRC to the proper parameter [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144743 (owner: 10Legoktm) [19:59:02] (03CR) 10Reedy: [C: 032] Pass $this->suppressRC to the proper parameter [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144743 (owner: 10Legoktm) [19:59:10] (03Merged) 10jenkins-bot: Pass $this->suppressRC to the proper parameter [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144743 (owner: 10Legoktm) [19:59:17] (03CR) 10EBernhardson: "to clarify no, this particular problem wont fix itself. This has to do with the first summarize revision overwriting the cached list rath" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144616 (https://bugzilla.wikimedia.org/67502) (owner: 10EBernhardson) [19:59:31] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Regex knock on issues - 10https://bugzilla.wikimedia.org/67418#c2 (10Nik Everett) 5PATC>3ASSI Still need another patch - this one to make sure the regex comes last. [19:59:33] (03CR) 10Krinkle: "@Anomie: I'm not sure why you'd think that I think front-end javascript part of MediaWiki would be the only consumer. I've written plenty " [core] - 10https://gerrit.wikimedia.org/r/142052 (owner: 10MaxSem) [20:02:44] (03PS1) 10IAlex: Fix the (un)watch token to include the namespace name. [core] - 10https://gerrit.wikimedia.org/r/144749 [20:03:39] (03PS1) 10Yaron Koren: Version 1.7 [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/144750 [20:04:27] (03PS1) 10MarkTraceur: Remove unnecessary dependencies [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/144751 [20:05:12] (03CR) 10Chad: "We can remove /etc/php5/cli/conf.d/20-xdebug.ini now. php5-xdebug takes care of its own ini so we're redundant and end up with "PHP Warnin" [vagrant] - 10https://gerrit.wikimedia.org/r/144747 (owner: 10BryanDavis) [20:05:27] (03PS2) 10MarkTraceur: Remove unnecessary dependencies [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/144751 [20:05:36] (03PS23) 10Gergő Tisza: Generate thumbnails based on buckets [core] - 10https://gerrit.wikimedia.org/r/135008 (https://bugzilla.wikimedia.org/67525) (owner: 10Gilles) [20:06:05] (03CR) 10Gergő Tisza: "(fixed a small typo)" [core] - 10https://gerrit.wikimedia.org/r/135008 (https://bugzilla.wikimedia.org/67525) (owner: 10Gilles) [20:06:22] superm401: ready when you are [20:06:35] <^d> bd808: Mostly ok. Just a nit and we're done. [20:06:48] ^d: On it. [20:07:48] (03PS2) 10BryanDavis: Use Ubuntu package for xdebug [vagrant] - 10https://gerrit.wikimedia.org/r/144747 [20:08:09] (03PS2) 10TK-999: Add delete link to Special:Listfiles [core] - 10https://gerrit.wikimedia.org/r/144366 [20:08:16] ^d: I pulled out the xdebug.so loader but left the config tweaks [20:08:31] <^d> looking [20:08:44] (03CR) 10Yaron Koren: [C: 032 V: 032] Version 1.7 [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/144750 (owner: 10Yaron Koren) [20:09:19] (03CR) 10Gergő Tisza: [C: 031] "All my concerns have been addressed; the code looks good, and worked fine in my tests. Feel free to merge if you are not waiting for other" [core] - 10https://gerrit.wikimedia.org/r/135008 (https://bugzilla.wikimedia.org/67525) (owner: 10Gilles) [20:10:02] (03CR) 10Chad: [C: 032] Use Ubuntu package for xdebug [vagrant] - 10https://gerrit.wikimedia.org/r/144747 (owner: 10BryanDavis) [20:10:30] (03Merged) 10jenkins-bot: Use Ubuntu package for xdebug [vagrant] - 10https://gerrit.wikimedia.org/r/144747 (owner: 10BryanDavis) [20:10:38] It's that time again. Upgrade your git-review. [20:11:08] (03PS1) 10Hashar: Apply $ZUUL_URL on deb jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/144753 (https://bugzilla.wikimedia.org/67583) [20:11:34] (03CR) 10Hashar: [C: 032] Apply $ZUUL_URL on deb jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/144753 (https://bugzilla.wikimedia.org/67583) (owner: 10Hashar) [20:12:35] (03Merged) 10jenkins-bot: Apply $ZUUL_URL on deb jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/144753 (https://bugzilla.wikimedia.org/67583) (owner: 10Hashar) [20:13:02] 3Wikimedia / 3Extension setup: "Wikimedia Shop" deployment on tr-wiki - 10https://bugzilla.wikimedia.org/66727#c5 (10James Alexander) 5UNCO>3RESO/FIX perfect! I'll close this and please let me/us know if there are any further issues. [20:13:28] (03PS5) 10Chad: Make it possible to disable link boosting [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/144502 [20:13:34] (03CR) 10jenkins-bot: [V: 04-1] Make it possible to disable link boosting [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/144502 (owner: 10Chad) [20:14:49] (03PS1) 10IAlex: Use the user from the context to format the date in Block::getPermissionsError() [core] - 10https://gerrit.wikimedia.org/r/144755 [20:20:21] superm401: Btw, I was going to approve your ProveIt oauth app, but you have http://localhost/ as your callback url. Let me know if/when you'd like me to approve a non-dev version. [20:20:47] csteipp, I've got a meeting. Can we talk after? [20:21:03] superm401: No problem. Ping me whenever. [20:22:25] (03PS6) 10Chad: Make it possible to disable link boosting [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/144502 [20:24:18] 3Wikimedia / 3Site requests: Attach all broken autocreated local accounts to their global account - 10https://bugzilla.wikimedia.org/61876#c8 (10Kunal Mehta (Legoktm)) 2014-07-08 20:21:23 processed 18347 usernames (29.3/sec), 166 (0.9%) fully migrated, 17957 (97.9%) partially migrated I'll look through the... [20:24:34] (03CR) 10Jdlrobson: [C: 04-1] "Feel free to +2 after addressing my minor concerns." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144740 (owner: 10SG) [20:24:56] (03PS10) 10Jdlrobson: Error handling for open/close topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143314 (owner: 10Matthias Mullie) [20:26:17] 3Wikimedia / 3General/Unknown: Audit centralauth database for inconsistencies - 10https://bugzilla.wikimedia.org/67350 (10Kunal Mehta (Legoktm)) [20:26:18] 3Wikimedia / 3General/Unknown: Migrate to SUL all non-clashing accounts - 10https://bugzilla.wikimedia.org/39817#c13 (10Kunal Mehta (Legoktm)) (In reply to Kunal Mehta (Legoktm) from comment #12) > Yup, you still need a list of users to migrate though. I'm planning to run > the script on Tuesday. Attached... [20:29:43] (03PS1) 10EBernhardson: Revert "Improvements and fixes to topic summarization" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144759 [20:29:49] (03CR) 10jenkins-bot: [V: 04-1] Revert "Improvements and fixes to topic summarization" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144759 (owner: 10EBernhardson) [20:29:58] Reedy: legoktm can you delete https://www.mediawiki.org/wiki/User:Yuvipanda/Android_app_release_cadence [20:29:59] ? [20:30:12] and whoever other mw.o admins there are [20:31:59] (03PS2) 10EBernhardson: Revert "Improvements and fixes to topic summarization" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144759 [20:32:20] (03CR) 10jenkins-bot: [V: 04-1] Revert "Improvements and fixes to topic summarization" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144759 (owner: 10EBernhardson) [20:32:23] hey, I was wondering if I should create a BugZilla bug as well if I submit a patch to core? [20:32:30] (03PS1) 10Jdlrobson: Revert "Improvements and fixes to topic summarization" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144760 [20:32:51] (03CR) 10jenkins-bot: [V: 04-1] Revert "Improvements and fixes to topic summarization" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144760 (owner: 10Jdlrobson) [20:33:03] KillerWalrus, probably not necessary [20:34:33] 3Wikimedia / 3Shop: shop.wikimedia.org should be HTTPS only - 10https://bugzilla.wikimedia.org/37790#c8 (10James Alexander) a:5James Alexander>3Caitlin Cogdill assigning this to Caitlin for now since I'm no longer involved in the Shop (staying in the CC list since I'm obviously still around and as have t... [20:35:34] (03CR) 10Parent5446: [C: 031] "Haven't tested." [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 (owner: 1001tonythomas) [20:36:00] (03Abandoned) 10Jdlrobson: Revert "Improvements and fixes to topic summarization" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144760 (owner: 10Jdlrobson) [20:37:50] (03PS1) 10Yurik: Allow wfShellExec() to use an array as a command prompt [core] - 10https://gerrit.wikimedia.org/r/144762 [20:39:08] Krenair: thanks =) [20:39:34] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Make reproduction steps for filing a github issue for routing around nodes that are totally busted - 10https://bugzilla.wikimedia.org/67691 (10Nik Everett) 3NEW p:3Unprio s:3normal a:3None Make reproduction steps for filing a github issue for routi... [20:39:47] KillerWalrus, unless it's something like a security bug. Then *do not* post it to gerrit, post a bug in the security area. [20:42:45] (03PS1) 10Jjanes: PostgreSQL: Fix ORDER BY NULL [core] - 10https://gerrit.wikimedia.org/r/144765 (https://bugzilla.wikimedia.org/65794) [20:44:41] Krenair: OK, cool =) [20:46:47] 3Wikimedia / 3General/Unknown: number of uploads in graphite - 10https://bugzilla.wikimedia.org/67116 (10Greg Grossmeier) p:5Unprio>3Normal [20:47:09] (03CR) 10Jdlrobson: [C: 04-1] "This removes the pointy arrow at the bottom that points to the box that is being edited. It's there for a reason! :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144661 (owner: 10Matthias Mullie) [20:47:46] (03CR) 10Aaron Schulz: [C: 032] PostgreSQL: Fix ORDER BY NULL [core] - 10https://gerrit.wikimedia.org/r/144765 (https://bugzilla.wikimedia.org/65794) (owner: 10Jjanes) [20:48:32] (03PS1) 10IAlex: Allow to set a salt for the edit token in HTMLForm [core] - 10https://gerrit.wikimedia.org/r/144766 [20:48:34] (03PS17) 10Jdlrobson: Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 (owner: 10Bsitu) [20:49:15] (03CR) 10Jdlrobson: [C: 04-1] "I see a lot of code but no tests..." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 (owner: 10Bsitu) [20:51:02] 3Wikimedia / 3Deployment systems: [scap] Report summary of file updated at end of scap/sync-* - 10https://bugzilla.wikimedia.org/67091#c1 (10Greg Grossmeier) p:5Unprio>3High Is this relatively easy with the new scap? [20:55:14] (03Merged) 10jenkins-bot: PostgreSQL: Fix ORDER BY NULL [core] - 10https://gerrit.wikimedia.org/r/144765 (https://bugzilla.wikimedia.org/65794) (owner: 10Jjanes) [20:56:10] (03CR) 10Jdlrobson: "No... the current situation is all wrong." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144164 (owner: 10Jdlrobson) [20:57:32] 3Wikimedia / 3Deployment systems: [scap] Report summary of file updated at end of scap/sync-* - 10https://bugzilla.wikimedia.org/67091#c2 (10Bryan Davis) It's possible but not easy. Something like `rsync --info=COPY,DEL ...` and then scraping the rsync output could be used to do it in theory. [20:59:33] (03Abandoned) 10EBernhardson: Revert "Improvements and fixes to topic summarization" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144759 (owner: 10EBernhardson) [20:59:54] (03PS1) 10TheDJ: Ace: Update to 08-07-2014 [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/144780 (https://bugzilla.wikimedia.org/60432) [21:01:39] (03CR) 10TheDJ: "Full ACE update including this in I5ac67a81" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/142826 (owner: 10Paladox) [21:01:53] (03PS1) 10BryanDavis: Install composer for system-wide usage [vagrant] - 10https://gerrit.wikimedia.org/r/144801 [21:01:56] Hi, I'm trying to install the uploadwizard role in mediawiki-vagrant. The problem is that it doesn't find the package "python::pil". I don't know if that package needs to be defined in mediawiki somewhere, or if it's supposed to be looked up in some central repo. ^ ori [21:02:36] This question might be simpler if I knew puppet, but I don't. [21:02:47] Why would upload wizard need the python image library!? [21:02:50] (03PS7) 10Jforrester: Better text for in core [core] - 10https://gerrit.wikimedia.org/r/83662 [21:02:56] bawolff: smoke tests generate images [21:02:56] not really needed [21:03:00] ah [21:03:14] if it does not break the install process, you can just ignore it [21:03:16] (03CR) 10Parent5446: [C: 032] "Tested and works" [core] - 10https://gerrit.wikimedia.org/r/144766 (owner: 10IAlex) [21:03:22] unless you want to run the API smoke tests [21:03:23] bawolff: yeah I figure it could be ignored, but then I need to learn how to make it install everything else without stopping there. [21:03:29] neilk_: I'll test it in my vm and see if I can spot the problem. [21:03:40] well, the whole thing that I'm doing is testing... so, probably? [21:03:45] ^ tgr [21:03:48] neilk_: Are you using a recent version of mw-vagrant? [21:03:57] bd808: latest AFAIK [21:03:59] (03PS1) 10Jjanes: PostgreSQL: Fix ORDER BY NULL [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/144824 (https://bugzilla.wikimedia.org/65794) [21:04:02] neilk_: And you're already finding issues :) [21:04:41] neilk_: Yup it's a bug. Ill see if I can fix it easily [21:04:47] bd808: thanks. [21:05:10] bd808, will you file it as well (as least if you can't fix it immediately)? [21:05:22] neilk_: you can always just install it by hand [21:05:30] (03PS8) 10Jforrester: Better text for in core [core] - 10https://gerrit.wikimedia.org/r/83662 [21:05:31] well, via pip [21:05:44] there is a requirements.txt file somewhere [21:05:54] tgr: I am unfamiliar with how puppet works. I thought of that and then hacking the puppet role but... *shrug* [21:05:59] (03PS3) 10Cscott: WIP: Run some parser tests with tidy. [core] - 10https://gerrit.wikimedia.org/r/133957 [21:06:07] (03CR) 10Jforrester: "PS7 is a rebase." [core] - 10https://gerrit.wikimedia.org/r/83662 (owner: 10Jforrester) [21:06:49] 3MediaWiki-Vagrant: Could not find class python::pil when enabling uploadwizard role - 10https://bugzilla.wikimedia.org/67692 (10Bryan Davis) 3NEW p:3Unprio s:3normal a:3Ori Livneh Error: Could not find class python::pil for mediawiki-vagrant.dev on node mediawiki-vagrant.dev [21:07:04] 3MediaWiki-Vagrant: Could not find class python::pil when enabling uploadwizard role - 10https://bugzilla.wikimedia.org/67692 (10Bryan Davis) p:5Unprio>3Normal a:5Ori Livneh>3Bryan Davis [21:07:52] Not having a python module may be part of the problem.... [21:08:07] bd808: it's defined in puppet/modules/python/manifests/pil.pp [21:08:14] (03Merged) 10jenkins-bot: Allow to set a salt for the edit token in HTMLForm [core] - 10https://gerrit.wikimedia.org/r/144766 (owner: 10IAlex) [21:08:14] some sort of autoloading problem? [21:08:35] 3MediaWiki-Vagrant: Chef is running - 10https://bugzilla.wikimedia.org/67693 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3Ori Livneh Chef (http://www.getchef.com/) is installed (both chef and chef-zero Debian packages) I'm not sure if this is just a Trusty thing (quick Googling did not indicate th... [21:09:17] bd808, I forgot, this came up before, but with ConfirmEdit (CAPTCHA). [21:09:24] tgr: I don't have modules/python in my tree (429ec77) [21:09:25] Try using Pillow. [21:09:59] (03CR) 10Parent5446: "Probably better to do /usr/local/bin, you know, just in case." [vagrant] - 10https://gerrit.wikimedia.org/r/144801 (owner: 10BryanDavis) [21:10:09] bd808, never mind, it already is. [21:10:40] bd808, ah, I see [21:10:54] Try switching include::python::pil to include packages::pil [21:11:09] The latter uses python-imaging from Ubuntu, which is Pillow [21:11:31] 3MediaWiki-Vagrant: Could not find class python::pil when enabling uploadwizard role - 10https://bugzilla.wikimedia.org/67692#c1 (10Tisza Gergő) Seems like PIL was deleted a few days ago, in I3ad17d9a14a3f2f043833d6c61b2d10dbd9a5369 [21:12:32] superm401: does Pillow have the same API as PIL? [21:12:45] tgr, yeah, from what I understand. [21:12:47] It's a fork. [21:12:58] (03CR) 10BryanDavis: "Parent5446: In case some core Ubuntu package suddenly squats on /usr/bin/composer?" [vagrant] - 10https://gerrit.wikimedia.org/r/144801 (owner: 10BryanDavis) [21:13:22] Pillow is pil only maintained and stuff [21:14:05] (03PS2) 10EBernhardson: Preview in close topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144627 (https://bugzilla.wikimedia.org/67379) [21:14:08] (03CR) 10Parent5446: [C: 031] "Yeah, now that I think about it, it shouldn't be an issue. I doubt Ubuntu would do that." [vagrant] - 10https://gerrit.wikimedia.org/r/144801 (owner: 10BryanDavis) [21:14:27] (03PS1) 10BryanDavis: Install PIL via packages::pil [vagrant] - 10https://gerrit.wikimedia.org/r/144827 (https://bugzilla.wikimedia.org/67692) [21:14:29] (03CR) 10Jdlrobson: [C: 031] "Don't merge until I98d45f053e0892e2b1f3433ce57f8ed084853103 is merged." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144495 (owner: 10EBernhardson) [21:14:53] (03CR) 10BryanDavis: [C: 032] Install PIL via packages::pil [vagrant] - 10https://gerrit.wikimedia.org/r/144827 (https://bugzilla.wikimedia.org/67692) (owner: 10BryanDavis) [21:14:58] (03Merged) 10jenkins-bot: Install PIL via packages::pil [vagrant] - 10https://gerrit.wikimedia.org/r/144827 (https://bugzilla.wikimedia.org/67692) (owner: 10BryanDavis) [21:15:30] neilk_: Fixed in master; `git pull; vagrant provision` should fix you up. [21:15:39] bd808: thanks! [21:16:00] * bd808 was hip deep in vagrant fixes already [21:16:32] 3MediaWiki-Vagrant: Could not find class python::pil when enabling uploadwizard role - 10https://bugzilla.wikimedia.org/67692 (10Bryan Davis) 5PATC>3RESO/FIX [21:19:16] (03CR) 10PleaseStand: "The bug number in the commit message is wrong (should be bug 67594)." [core] - 10https://gerrit.wikimedia.org/r/144765 (https://bugzilla.wikimedia.org/65794) (owner: 10Jjanes) [21:21:09] MatmaRex: https://en.wikipedia.org/w/index.php?title=MediaWiki%3ACommon.css&diff=616140624&oldid=613802708 [21:21:18] 3MediaWiki / 3Internationalization: Document/differentiate between use cases of formatTimePeriod() and formatDuration() - 10https://bugzilla.wikimedia.org/65794#c6 (10Kevin Israel (PleaseStand)) 5PATC>3NEW [Resetting status. Patch was for a different bug 67594.] [21:21:41] Krinkle: ugh. thanks [21:21:58] And the next edit [21:22:11] MatmaRex: Want me to dump a mwgrep for you? [21:22:31] Krinkle: i've seen some other reports about these things in a few places, but nothing major [21:22:54] (like https://bugzilla.wikimedia.org/show_bug.cgi?id=58292, last comment) [21:23:15] Krinkle: hm, i guess that's a good idea. thanks [21:23:30] (03CR) 10Jdlrobson: [C: 04-1] "Introduces styling regression - I'm seeing headings in the wrong font family now." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144627 (https://bugzilla.wikimedia.org/67379) (owner: 10EBernhardson) [21:23:47] 3MediaWiki / 3Special pages: Postgresql: non-integer constant in ORDER BY - 10https://bugzilla.wikimedia.org/67594#c2 (10Kevin Israel (PleaseStand)) Jeff, is this fixed by https://gerrit.wikimedia.org/r/#/c/144765/ ? [21:24:41] (03PS1) 10TK-999: Make Special:Unblock link to contributions page for IP blockees [core] - 10https://gerrit.wikimedia.org/r/144829 [21:25:02] 3Wikimedia / 3SSL related: Enable HTTPS for dumps.wikimedia.org - 10https://bugzilla.wikimedia.org/58292#c4 (10Bartosz Dziewoński) (In reply to chmarkine from comment #3) > https://dumps.wikimedia.org/ homepage contains mixed content: > * http://en.wikipedia.org/skins-1.5/monobook/headbg.jpg > > Please chan... [21:25:04] (03PS1) 10Jdlrobson: Revert "Error handling for Summarise and edit summary topic actions" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144830 [21:25:07] (03PS1) 10Jdlrobson: Revert "Improvements and fixes to topic summarization" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144831 [21:27:07] (03PS2) 10Jdlrobson: Revert "Error handling for Summarise and edit summary topic actions" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144830 [21:29:00] (03CR) 10Spage: [C: 04-1] "style name typo" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144627 (https://bugzilla.wikimedia.org/67379) (owner: 10EBernhardson) [21:32:22] (03PS3) 10EBernhardson: Preview in close topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144627 (https://bugzilla.wikimedia.org/67379) [21:34:30] (03CR) 10Chad: [C: 032] Install composer for system-wide usage [vagrant] - 10https://gerrit.wikimedia.org/r/144801 (owner: 10BryanDavis) [21:34:37] (03Merged) 10jenkins-bot: Install composer for system-wide usage [vagrant] - 10https://gerrit.wikimedia.org/r/144801 (owner: 10BryanDavis) [21:40:20] (03PS4) 10Yurik: Cleanup - lets make IDEs more useful [core] - 10https://gerrit.wikimedia.org/r/144246 [21:40:39] MatmaRex: https://gist.github.com/Krinkle/a688050f6fd6cd02a30b [21:40:49] https://gist.github.com/Krinkle/a688050f6fd6cd02a30b#file-skins-vector-site-out [21:41:39] Krinkle: ugh. thanks [21:41:58] I'm currently running another one for bodyContent [21:42:07] (03CR) 10Krinkle: [C: 031] "Sanity check." [core] - 10https://gerrit.wikimedia.org/r/130525 (owner: 10Jforrester) [21:42:18] i'll try going through these tomorrow-ish [21:42:19] mwgrep bodyContent [21:42:21] total: 1345, shown: 100 [21:42:24] :D [21:43:19] (03PS2) 10Jjanes: PostgreSQL: Fix ORDER BY NULL [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/144824 (https://bugzilla.wikimedia.org/67594) [21:44:19] (03CR) 10Krinkle: [C: 032] Vector: Remove backwards-compatible #bodyContent selector [core] - 10https://gerrit.wikimedia.org/r/130525 (owner: 10Jforrester) [21:45:50] (03PS1) 10Bsitu: Flow topic reply notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144832 [21:45:54] Krinkle: Ouch. [21:46:03] Krinkle: 1345?! [21:46:46] 3MediaWiki-Vagrant: Chef is running - 10https://bugzilla.wikimedia.org/67693#c1 (10Matthew Flaschen) Forgot to mention in the body, it's also running. [21:47:18] csteipp, have a sec to talk about the OAuth request? [21:47:30] superm401: Yep [21:48:08] superm401: I just noticed you put it in, and also that the callback url was to localhost, so I didn't approve it.. I'm assuming you're moving ProveIt to use OAuth? [21:48:17] Not exactly [21:48:22] (03Merged) 10jenkins-bot: Vector: Remove backwards-compatible #bodyContent selector [core] - 10https://gerrit.wikimedia.org/r/130525 (owner: 10Jforrester) [21:48:35] (03CR) 10Jjanes: "You are correct, the bug number in the commit message is wrong. I changed it for the REL1_23 branch backpatch. I don't know how to fix i" [core] - 10https://gerrit.wikimedia.org/r/144765 (https://bugzilla.wikimedia.org/65794) (owner: 10Jjanes) [21:48:36] csteipp, so basically I have a deployment script that checks out a specified version from git, then deploys ProveIt to specified pages (either production/gadget, or test pages, on a specified wiki). [21:48:57] It's purely for my convenience to deploy quickly without copy/paste. Users don't use it. [21:49:06] Currently, I'm using passwords, but I would prefer to use OAuth. [21:49:51] I really only need one token, but I didn't know if there was a way to get that without an app. [21:51:06] superm401: Ah, cool. So yeah, if that's working for you, that's a fine way to do it. [21:52:07] (03CR) 10Parent5446: [C: 031] Cleanup - lets make IDEs more useful [core] - 10https://gerrit.wikimedia.org/r/144246 (owner: 10Yurik) [21:52:46] 3MediaWiki extensions / 3WikidataRepo: Performance review of PubSubHubbub extension - 10https://bugzilla.wikimedia.org/67117#c1 (10Aaron Schulz) A few things: * This seems to be missing a ArticleRevisionVisibilitySet handler * http_post() needs to handle $wgHTTPProxy * The maximum jobs attempts for the queue... [21:53:05] csteipp, so you'll be able to approve it? [21:53:10] (03PS1) 10Jdlrobson: Add QUnit tests for escapeContent and eachPost [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144834 [21:54:48] (03CR) 10Spage: [C: 04-1] "Preview works, tests pass, But when I summarize, I don't see the summary text. It's only visible when I reload or go to the Permalink." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144627 (https://bugzilla.wikimedia.org/67379) (owner: 10EBernhardson) [21:55:05] (03CR) 10Brian Wolff: [C: 04-1] "Looking pretty good. Just a small issue. Once that's fixed, I think this can be merged" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/144366 (owner: 10TK-999) [21:55:56] (03CR) 10Yurik: "Parent5446, thx for the heads up on the new type[] and even (type1|type2)[] array (the second one is not yet supported by phpstorm it seem" [core] - 10https://gerrit.wikimedia.org/r/144246 (owner: 10Yurik) [21:57:34] 3MediaWiki / 3Skin and page rendering: Replace "Thumbnail size" property in preferences with responsive resizing images - 10https://bugzilla.wikimedia.org/67695 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None start with larger default "thumb" style images e.g. 400px and dynamically resize... [21:58:03] superm401: Yeah, I probably will. We need a status to indicate an app is a bot. Until then I'll just approve it. [21:58:16] (03CR) 10Brian Wolff: Add delete link to Special:Listfiles (031 comment) [core] - 10https://gerrit.wikimedia.org/r/144366 (owner: 10TK-999) [21:59:17] csteipp, thanks, if that status is added, feel free to update it, or ask me to. In the meantime, the name is "ProveIt deployment script", so at lease there's an indication of the purpose. [21:59:25] (03PS1) 10Bsitu: Add bundle data ordering method to formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/144835 [22:00:54] (03PS2) 10Bsitu: Add bundle data ordering method to formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/144835 [22:01:01] 3MediaWiki-Vagrant: Chef is running - 10https://bugzilla.wikimedia.org/67693#c2 (10Sam Reed (reedy)) aptitude why chef ? [22:02:33] (03PS2) 10CSteipp: Some initial tests for CentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143401 [22:02:36] (03CR) 10jenkins-bot: [V: 04-1] Some initial tests for CentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143401 (owner: 10CSteipp) [22:03:32] 3MediaWiki-Vagrant: VisualEditor fails to provision with rbenv error - 10https://bugzilla.wikimedia.org/66764#c8 (10Matthew Flaschen) VisualEditor is working now on that box (after a vagrant up --provision), except there are timeouts in the browser tests. Next (when I have a chance), I'm going to try to destr... [22:03:34] 3MediaWiki extensions / 3WikidataRepo: save/cancel buttons broken in in other languages box - 10https://bugzilla.wikimedia.org/67696 (10Lydia Pintscher) 3NEW p:3Unprio s:3major a:3Wikidata bugs There is no save/cancel link doesn't show in the in other languages box. There is only a non-working edit l... [22:03:44] (03PS2) 10Bsitu: Flow topic reply notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144832 [22:03:46] 3MediaWiki extensions / 3WikidataRepo: save/cancel buttons broken in in other languages box - 10https://bugzilla.wikimedia.org/67696 (10Lydia Pintscher) p:5Unprio>3High [22:04:53] (03PS3) 10Bsitu: Flow topic reply notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144832 [22:06:21] (03PS1) 10BryanDavis: Install mediawiki composer dependencies [vagrant] - 10https://gerrit.wikimedia.org/r/144836 [22:07:28] (03PS3) 10TK-999: Add delete link to Special:Listfiles [core] - 10https://gerrit.wikimedia.org/r/144366 [22:08:20] (03CR) 10Reedy: [C: 031] "And the composer dependency gets automagically autoloaded too, right?" [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 (owner: 1001tonythomas) [22:08:40] (03PS4) 10EBernhardson: Preview in close topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144627 (https://bugzilla.wikimedia.org/67379) [22:11:56] James_F: yeah, 1300+ titles, not matches (1 is 1 page, not 1 match) [22:12:12] James_F: And not including those not indexed by cirruss [22:13:39] (03PS3) 10CSteipp: Some initial tests for CentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143401 [22:13:47] (03CR) 10jenkins-bot: [V: 04-1] Some initial tests for CentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143401 (owner: 10CSteipp) [22:17:16] (03PS2) 10BryanDavis: Install mediawiki composer dependencies [vagrant] - 10https://gerrit.wikimedia.org/r/144836 [22:19:05] (03PS5) 10Jdlrobson: Preview in close topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144627 (https://bugzilla.wikimedia.org/67379) (owner: 10EBernhardson) [22:19:13] (03CR) 10Jdlrobson: [C: 032] Preview in close topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144627 (https://bugzilla.wikimedia.org/67379) (owner: 10EBernhardson) [22:19:30] Krinkle: *sighs* [22:19:41] (03Merged) 10jenkins-bot: Preview in close topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144627 (https://bugzilla.wikimedia.org/67379) (owner: 10EBernhardson) [22:20:53] (03Abandoned) 10Jdlrobson: Revert "Improvements and fixes to topic summarization" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144831 (owner: 10Jdlrobson) [22:20:58] (03Abandoned) 10Jdlrobson: Revert "Error handling for Summarise and edit summary topic actions" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144830 (owner: 10Jdlrobson) [22:21:12] (03PS2) 10Jdlrobson: Add QUnit tests for escapeContent and eachPost [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144834 [22:21:32] (03PS4) 10Jdlrobson: Flow topic reply notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144832 (owner: 10Bsitu) [22:21:39] (03CR) 10jenkins-bot: [V: 04-1] Flow topic reply notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144832 (owner: 10Bsitu) [22:21:45] (03CR) 10Krinkle: On redirect, actually update URL to the target page with JavaScript (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143852 (https://bugzilla.wikimedia.org/35045) (owner: 10Bartosz Dziewoński) [22:22:05] (03CR) 10BryanDavis: "A potential downside of using this method is that when we really start using the mediawiki/core/vendor repo in prod, this will track diffe" [vagrant] - 10https://gerrit.wikimedia.org/r/144836 (owner: 10BryanDavis) [22:22:07] (03CR) 10Jdlrobson: [C: 04-1] "Would be good to get some tests in while we wait for Echo patch to get merged." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144832 (owner: 10Bsitu) [22:22:50] (03PS4) 10CSteipp: Some initial tests for CentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143401 [22:22:56] (03CR) 10jenkins-bot: [V: 04-1] Some initial tests for CentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143401 (owner: 10CSteipp) [22:25:59] (03PS5) 10CSteipp: Some initial tests for CentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143401 [22:26:05] (03CR) 10jenkins-bot: [V: 04-1] Some initial tests for CentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143401 (owner: 10CSteipp) [22:26:49] (03PS2) 10Krinkle: Remove deprecated Skin::makeGlobalVariablesScript [core] - 10https://gerrit.wikimedia.org/r/144321 (owner: 10Umherirrender) [22:27:09] (03CR) 10Krinkle: [C: 032] Remove deprecated Skin::makeGlobalVariablesScript [core] - 10https://gerrit.wikimedia.org/r/144321 (owner: 10Umherirrender) [22:28:32] (03CR) 10Krinkle: "To clarify, the 'MakeGlobalVariablesScript' hook does (and should) remain." [core] - 10https://gerrit.wikimedia.org/r/144321 (owner: 10Umherirrender) [22:28:49] (03CR) 10Kunalgrover05: "Done, do I need to add anything else to it?" [core] - 10https://gerrit.wikimedia.org/r/143025 (owner: 10Kunalgrover05) [22:29:24] (03PS10) 10Jdlrobson: Error handling for moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143315 (owner: 10Matthias Mullie) [22:29:34] (03PS4) 10Cscott: WIP: Run some parser tests with tidy. [core] - 10https://gerrit.wikimedia.org/r/133957 [22:30:36] (03CR) 10Jdlrobson: [C: 032] "Rebased. boom." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143315 (owner: 10Matthias Mullie) [22:31:12] (03Merged) 10jenkins-bot: Error handling for moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143315 (owner: 10Matthias Mullie) [22:31:15] (03Merged) 10jenkins-bot: Remove deprecated Skin::makeGlobalVariablesScript [core] - 10https://gerrit.wikimedia.org/r/144321 (owner: 10Umherirrender) [22:31:51] (03CR) 10Jdlrobson: [C: 04-1] "Needs a rebase :/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144449 (owner: 10Matthias Mullie) [22:31:58] (03CR) 10Jdlrobson: [C: 04-1] "Needs a rebase :/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144471 (owner: 10Matthias Mullie) [22:32:11] ^d: So when I'm searching things, can I use -"Some term" to say, don' [22:32:19] t include results with "some term" in it? [22:32:46] (03CR) 10Legoktm: "I don't like passing around strings like this, could we use constants instead?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/144835 (owner: 10Bsitu) [22:33:48] (03CR) 10Paladox: [C: 031] Ace: Update to 08-07-2014 [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/144780 (https://bugzilla.wikimedia.org/60432) (owner: 10TheDJ) [22:34:50] (03CR) 10Jdlrobson: Generic error handler for edit conflicts (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144471 (owner: 10Matthias Mullie) [22:35:32] (03PS5) 10Bsitu: Flow topic reply notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144832 [22:35:49] (03CR) 10jenkins-bot: [V: 04-1] Flow topic reply notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144832 (owner: 10Bsitu) [22:35:58] (03CR) 10Jdlrobson: Handle post edit conflicts (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144449 (owner: 10Matthias Mullie) [22:36:18] 3Wikimedia / 3Media storage: Thumbnail/imagescaler (tracking) - 10https://bugzilla.wikimedia.org/41371 (10Tisza Gergő) [22:36:23] ebernhardson: are you sure about https://gerrit.wikimedia.org/r/144162 ? [22:36:36] (03CR) 10Krinkle: [C: 032 V: 032] "Not actively maintained, no tests." [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/144279 (owner: 10Umherirrender) [22:37:10] (03CR) 10Bsitu: "Yeah, that's a better. I will update it in a subsequent patch" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/144835 (owner: 10Bsitu) [22:40:04] (03CR) 10Krinkle: [C: 032 V: 032] "Not actively maintained, no tests. LGTM." [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/144276 (owner: 10Umherirrender) [22:41:01] (03CR) 10Krinkle: [C: 032 V: 032] Replace deprecated User::isValidEmailAddr calls [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/144261 (owner: 10Umherirrender) [22:43:09] (03CR) 10Jdlrobson: [C: 04-1] "Needs rebase" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143314 (owner: 10Matthias Mullie) [22:43:20] (03PS4) 10Krinkle: jQuery-ify legacy protect.js [core] - 10https://gerrit.wikimedia.org/r/140936 (owner: 10Umherirrender) [22:45:27] jdlrobson: yes, disable javascript and click a reply button [22:45:44] jdlrobson: if your worried about duplication, the last line of my comment was directed at removing that duplication [22:46:29] ebernhardson: "if you can't replicate it you might just not have flow caching properly enabled?" [22:46:31] how do i enable? [22:46:56] jdlrobson: hmm, perhaps `apt-get install memcached` ? not sure [22:47:05] ebernhardson: on vagrant? [22:47:11] jdlrobson: if you open up maintenance/eval.php and ehco get_class( $wgMemc ) what do you get [22:47:39] jdlrobson: yes, vagrant doesn't install memcached by default [22:48:00] (i have a variety of hacks in my vagrant ... it runs varnish too so i often forget ) [22:48:02] ebernhardson: RedisBagOStuff [22:48:34] jdlrobson: yea i havn't tested against RedisBagOStuff at all, although i suppose we could. In prod it will be a MemcachedBagOStuff [22:49:03] those things really don't line up like they should, because BagOStuff is really a thin wrapper around memcached and the others try and pretend to be memcached basically [22:51:32] 3Wikimedia / 3Media storage: Thumbnail/imagescaler (tracking) - 10https://bugzilla.wikimedia.org/41371 (10Tisza Gergő) [22:52:20] (03Abandoned) 10Jdlrobson: Drop unused flow_block_topic_reply.handlebars [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144162 (owner: 10Jdlrobson) [23:01:06] (03Abandoned) 10Jdlrobson: Only allow one form of summarize or close to be open at a time [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143522 (https://bugzilla.wikimedia.org/67217) (owner: 10Jdlrobson) [23:01:53] (03CR) 10Krinkle: [C: 04-1] "Untested. Code looks like it works, but I'd rather not promote too much bad code into jQuery as that worsens the performance and maintaina" (036 comments) [core] - 10https://gerrit.wikimedia.org/r/140936 (owner: 10Umherirrender) [23:02:06] (03CR) 10Jdlrobson: "This terrifies me." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143906 (owner: 10Matthias Mullie) [23:03:18] (03CR) 10Legoktm: [C: 04-1] Extremely hacky implementation of 'log improvements' (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143906 (owner: 10Matthias Mullie) [23:03:34] 3MediaWiki / 3API: list=deletedrevs&drprop=content sometimes returns empty dict - 10https://bugzilla.wikimedia.org/67699 (10Giftpflanze) 3NEW p:3Unprio s:3normal a:3None Example (needs sysop rights): http://de.wikipedia.org/w/api.php?format=jsonfm&action=query&list=deletedrevs&drprop=content&titles=D... [23:03:47] (03PS2) 10Legoktm: (bug 64043) Set the default database schema to "mediawiki" so as not to break the CLI installer. [core] - 10https://gerrit.wikimedia.org/r/142472 (owner: 10Skizzerz) [23:03:57] (03CR) 10Bartosz Dziewoński: "Are you saying that it supports .bind() for other functions, but not document.createElementNS? I find that hard to imagine." [core] - 10https://gerrit.wikimedia.org/r/144601 (owner: 10Mattflaschen) [23:05:30] (03CR) 10jenkins-bot: [V: 04-1] (bug 64043) Set the default database schema to "mediawiki" so as not to break the CLI installer. [core] - 10https://gerrit.wikimedia.org/r/142472 (owner: 10Skizzerz) [23:05:52] (03PS3) 10Jdlrobson: Clean up css selectors for moderated titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144169 [23:06:11] (03PS1) 10Jdlrobson: Rethink our use of media queries. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144847 [23:06:42] Hi, I'm trying to set up git-review, but it's complaining that https://gerrit.wikimedia.org/tools/hooks/commit-msg is 404ing [23:08:02] neilk_: ugh [23:08:18] MatmaRex: yeah. I don't know if that's important or not. [23:08:33] MatmaRex: perhaps i can just copy the hooks or other git config from someone else [23:08:40] (03CR) 10Jdlrobson: [C: 032] Complete flow-ui-tooltip JS, correct tooltip styling to white bg [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144704 (owner: 10SG) [23:08:50] neilk_: it generates the "Change-Id: Iabcdef" lines in commit messages that gerrit requires [23:08:54] neilk_: http://pastebin.com/XFzUNhK1 [23:09:01] MatmaRex: ok that seems important :) [23:09:19] MatmaRex: is that the only custom hook? [23:09:38] neilk_: you can generate them manually if you feel like it, too, just use some random-like identifier for the change-id [23:09:40] neilk_: yes [23:10:32] MatmaRex: now I just have to convince git-review that it's properly installed. :( [23:10:50] neilk_: just put that in .git/hooks/commit-msg and it should work [23:11:02] (03CR) 10Jdlrobson: "I don't know how to replicate nor test.." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144616 (https://bugzilla.wikimedia.org/67502) (owner: 10EBernhardson) [23:13:14] (03CR) 10Krinkle: [C: 04-1] Skip $wgMaxImageArea for InstantCommons files (031 comment) [core] - 10https://gerrit.wikimedia.org/r/142046 (https://bugzilla.wikimedia.org/32387) (owner: 10Umherirrender) [23:14:10] (03PS1) 10Brian Wolff: Enable the play button in the control bar for the VLCApp player. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144849 [23:15:04] (03CR) 10Krinkle: [C: 032] Replace deprecated Title::escapeFullURL calls [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/142578 (owner: 10Umherirrender) [23:15:07] (03PS5) 10Paladox: mediawiki.searchSuggest: Enable for iPhone and iPod touch [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/143320 [23:15:10] (03Merged) 10jenkins-bot: Replace deprecated Title::escapeFullURL calls [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/142578 (owner: 10Umherirrender) [23:15:27] (03PS4) 10Paladox: Updating code editor ace.js user agent [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/142826 [23:15:41] (03CR) 10Krinkle: [C: 032 V: 032] Replace deprecated Title::escapeFullURL call [extensions/NewUsersList] - 10https://gerrit.wikimedia.org/r/142778 (owner: 10Umherirrender) [23:16:11] (03Abandoned) 10Paladox: Updating code editor ace.js user agent [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/142826 (owner: 10Paladox) [23:16:24] (03CR) 10Brian Wolff: "Personally if we're going to update how the max file size check works, I'd prefer to move the max file size check to the file::transform m" [core] - 10https://gerrit.wikimedia.org/r/142046 (https://bugzilla.wikimedia.org/32387) (owner: 10Umherirrender) [23:16:32] (03PS26) 10Paladox: Update jQuery.appear.js [core] - 10https://gerrit.wikimedia.org/r/139470 [23:16:34] (03CR) 10Krinkle: [C: 032] Replace deprecated Title::escapeFullURL calls [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/142777 (owner: 10Umherirrender) [23:16:48] (03PS19) 10Paladox: Update jQuery Cookie to v1.4.1 [core] - 10https://gerrit.wikimedia.org/r/139686 [23:17:15] (03CR) 10Krinkle: [C: 032 V: 032] Replace deprecated Title::escapeFullURL calls [extensions/SiteMetrics] - 10https://gerrit.wikimedia.org/r/142770 (owner: 10Umherirrender) [23:17:17] (03PS49) 10Paladox: Update jquery.hoverintent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [23:17:42] (03PS15) 10Paladox: Update jquery.form.js [core] - 10https://gerrit.wikimedia.org/r/139688 [23:18:33] (03PS2) 10Krinkle: Replace deprecated Title::escapeFullURL calls [extensions/Comments] - 10https://gerrit.wikimedia.org/r/142580 (owner: 10Umherirrender) [23:19:11] (03PS11) 10Jdlrobson: Error handling for open/close topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143314 (owner: 10Matthias Mullie) [23:19:14] (03PS1) 10Jdlrobson: Make topic summary a required field [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144851 [23:19:17] (03PS17) 10Paladox: Update jquery.mockjax.js to v1.5.3 [core] - 10https://gerrit.wikimedia.org/r/139693 [23:19:34] (03PS24) 10Paladox: Update jquery.validate from 1.8.1 to 1.13.0 [core] - 10https://gerrit.wikimedia.org/r/139697 [23:20:30] (03PS19) 10Paladox: Update jquery.chosen folder and files [core] - 10https://gerrit.wikimedia.org/r/139699 [23:20:32] (03CR) 10Krinkle: [C: 04-1] Replace deprecated Title::escapeFullURL calls (031 comment) [extensions/Comments] - 10https://gerrit.wikimedia.org/r/142580 (owner: 10Umherirrender) [23:20:44] (03CR) 10Swalling: [C: 031] Better text for in core [core] - 10https://gerrit.wikimedia.org/r/83662 (owner: 10Jforrester) [23:21:21] MatmaRex: Sorry to penalize you for helping, but are you sure that script is identical to what you have installed? [23:22:12] neilk_: yes, unless i messed up copy-and-pasting [23:22:25] (03PS4) 10Brian Wolff: Add delete link to Special:Listfiles [core] - 10https://gerrit.wikimedia.org/r/144366 (owner: 10TK-999) [23:22:34] 3MediaWiki extensions / 3Cite: With the deployment of 141583 there is no way to detect that reference list markup is missing - 10https://bugzilla.wikimedia.org/67700 (10Gadget850) 3NEW p:3Unprio s:3normal a:3None https://bugzilla.wikimedia.org/show_bug.cgi?id=66860 https://gerrit.wikimedia.org/r/#/c/... [23:22:39] (03PS5) 10Paladox: Update TimedText [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/144675 [23:22:42] it might be a bit out-of-date, but it works for me [23:22:42] (03CR) 10Brian Wolff: [C: 032] "Thank you for taking the time to bring this over from github." [core] - 10https://gerrit.wikimedia.org/r/144366 (owner: 10TK-999) [23:22:47] 3MediaWiki extensions / 3Cite: Cite: If there's no block on the page, show one automatically below the content rather than showing an error - 10https://bugzilla.wikimedia.org/66860#c16 (10Gadget850) Bug 67700 [23:22:50] MatmaRex: are you on linux? [23:22:50] (03CR) 10Krinkle: [C: 04-1] "Calling htmlspecialchars() that way doesn't work. ends up like a string literal." [extensions/RandomImageByCategory] - 10https://gerrit.wikimedia.org/r/142781 (owner: 10Umherirrender) [23:23:06] neilk_: windows, but that shouldn't matter, there's just one script [23:23:07] MatmaRex: I'm using OS X right now [23:23:11] (03CR) 10Krinkle: [C: 04-1] "Calling htmlspecialchars() that way doesn't work." [extensions/RandomFeaturedUser] - 10https://gerrit.wikimedia.org/r/142780 (owner: 10Umherirrender) [23:23:15] (03PS4) 10Paladox: Add support for sqlite [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/90105 (owner: 10MarkAHershberger) [23:23:32] MatmaRex: it is complaining about a missing executable but I can't figure out what that would be. awk is there. git, grep, etc. [23:23:43] neilk_: Hey o/ [23:23:49] ahoy Krinkle [23:24:03] Krinkle: are you in the USA now too? [23:24:14] neilk_: I am not. [23:24:16] neilk_: is the script have the +x bits [23:24:25] s/is/does [23:24:32] neilk_: Living in the Netherlands, moving to the UK in a few months. Visiting SF regularly though. [23:24:48] neilk_: What about you, you in Canada? [23:27:28] bawolff, MatmaRex auuugh never mind. /bin/sh^M: bad interpreter [23:27:42] ah, that will do it :) [23:27:54] (03CR) 10Krinkle: [C: 032] Replace deprecated Title::escapeFullURL calls [extensions/RandomGameUnit] - 10https://gerrit.wikimedia.org/r/142772 (owner: 10Umherirrender) [23:28:23] hah. [23:29:47] 3Wikimedia / 3Bugzilla: Bugzilla: Add a query parameter to CSS URL to force browsers to reload cached CSS files - 10https://bugzilla.wikimedia.org/49720#c27 (10Daniel Zahn) we are now loading the required Apache modules: expires.load -> ../mods-available/expires.load headers.load -> ../mods-availabl... [23:31:39] (03PS1) 10Legoktm: No longer support installs where register_globals is enabled [core] - 10https://gerrit.wikimedia.org/r/144854 [23:31:50] (03Merged) 10jenkins-bot: Add delete link to Special:Listfiles [core] - 10https://gerrit.wikimedia.org/r/144366 (owner: 10TK-999) [23:33:14] (03PS6) 10CSteipp: Some initial tests for CentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143401 [23:34:12] (03CR) 10jenkins-bot: [V: 04-1] Some initial tests for CentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143401 (owner: 10CSteipp) [23:34:14] Krinkle: yes, Canada [23:34:41] (03CR) 10Krinkle: [V: 032] Replace deprecated Title::escapeFullURL calls [extensions/RandomGameUnit] - 10https://gerrit.wikimedia.org/r/142772 (owner: 10Umherirrender) [23:36:29] (03CR) 10Krinkle: [C: 04-1] "It seems there is a little bit of usage out there still. About 3 extensions." [core] - 10https://gerrit.wikimedia.org/r/141489 (owner: 10Umherirrender) [23:37:41] (03PS11) 10Kunalgrover05: Improve page language functions [core] - 10https://gerrit.wikimedia.org/r/137033 (owner: 10SPQRobin) [23:37:43] (03PS4) 10Kunalgrover05: Fix loading from DB multiple times [core] - 10https://gerrit.wikimedia.org/r/137915 [23:37:47] (03CR) 10Krinkle: [C: 032] Remove comment about deprecated Title::escapeFullURL [extensions/Video] - 10https://gerrit.wikimedia.org/r/142784 (owner: 10Umherirrender) [23:38:12] (03CR) 10Krinkle: [C: 032] Replace deprecated Title::getEscapedText call [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/142788 (owner: 10Umherirrender) [23:38:24] (03CR) 10Krinkle: [C: 032] Replace deprecated Title::getEscapedText call [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/142789 (owner: 10Umherirrender) [23:38:34] 3MediaWiki / 3General/Unknown: filelist search for media name - capital letters - 10https://bugzilla.wikimedia.org/67702 (10atlantonius) 3UNCO p:3Unprio s:3normal a:3None in 1.22, if a filename begins with a capital letter, searching fails if your search criteria includes the capital letter. If you... [23:38:57] (03PS3) 10Krinkle: Remove Preferences::loadOldSearchNs() (deprecated since 1.19) [core] - 10https://gerrit.wikimedia.org/r/142033 (owner: 10Umherirrender) [23:39:20] (03PS3) 10Krinkle: Remove OutputPage::getStatusMessage() (deprecated since 1.18) [core] - 10https://gerrit.wikimedia.org/r/142534 (owner: 10Umherirrender) [23:39:24] (03PS3) 10Krinkle: Remove OutputPage::isUserJsAllowed() (deprecated since 1.18) [core] - 10https://gerrit.wikimedia.org/r/142535 (owner: 10Umherirrender) [23:39:28] (03PS2) 10Krinkle: Remove Title::updateTitleProtection() (deprecated since 1.19) [core] - 10https://gerrit.wikimedia.org/r/142799 (owner: 10Umherirrender) [23:39:33] (03PS2) 10Krinkle: Remove Title::escapeCanonicalURL() (deprecated since 1.19) [core] - 10https://gerrit.wikimedia.org/r/142800 (owner: 10Umherirrender) [23:39:46] (03PS2) 10Krinkle: Remove Title::escapeLocalURL() (deprecated since 1.19) [core] - 10https://gerrit.wikimedia.org/r/142801 (owner: 10Umherirrender) [23:40:04] 3MediaWiki / 3General/Unknown: filelist search for media name - capital letters - 10https://bugzilla.wikimedia.org/67702 (10atlantonius) [23:40:25] (03Merged) 10jenkins-bot: Replace deprecated Title::getEscapedText call [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/142788 (owner: 10Umherirrender) [23:41:28] (03PS4) 10Krinkle: Remove OutputPage::isUserJsAllowed() (deprecated since 1.18) [core] - 10https://gerrit.wikimedia.org/r/142535 (owner: 10Umherirrender) [23:41:30] (03PS4) 10Krinkle: Remove OutputPage::getStatusMessage() (deprecated since 1.18) [core] - 10https://gerrit.wikimedia.org/r/142534 (owner: 10Umherirrender) [23:41:32] (03PS3) 10Krinkle: Remove Title::escapeCanonicalURL() (deprecated since 1.19) [core] - 10https://gerrit.wikimedia.org/r/142800 (owner: 10Umherirrender) [23:41:34] (03PS3) 10Krinkle: Remove Title::escapeLocalURL() (deprecated since 1.19) [core] - 10https://gerrit.wikimedia.org/r/142801 (owner: 10Umherirrender) [23:41:36] (03PS3) 10Krinkle: Remove Title::updateTitleProtection() (deprecated since 1.19) [core] - 10https://gerrit.wikimedia.org/r/142799 (owner: 10Umherirrender) [23:41:38] (03PS4) 10Krinkle: Remove MWNamespace::isMain() (deprecated since 1.19) [core] - 10https://gerrit.wikimedia.org/r/142032 (owner: 10Umherirrender) [23:41:40] (03PS4) 10Krinkle: Remove Preferences::loadOldSearchNs() (deprecated since 1.19) [core] - 10https://gerrit.wikimedia.org/r/142033 (owner: 10Umherirrender) [23:41:42] (03CR) 10Krinkle: [C: 032] Remove MWNamespace::isMain() (deprecated since 1.19) [core] - 10https://gerrit.wikimedia.org/r/142032 (owner: 10Umherirrender) [23:41:57] (03CR) 10Krinkle: [C: 032] Remove Preferences::loadOldSearchNs() (deprecated since 1.19) [core] - 10https://gerrit.wikimedia.org/r/142033 (owner: 10Umherirrender) [23:43:21] (03CR) 10Jack Phoenix: [C: 031] No longer support installs where register_globals is enabled [core] - 10https://gerrit.wikimedia.org/r/144854 (owner: 10Legoktm) [23:43:42] (03CR) 10EBernhardson: "If you can connect a runtime debugger to php, this is essentially what you are looking for:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144616 (https://bugzilla.wikimedia.org/67502) (owner: 10EBernhardson) [23:44:51] 3MediaWiki / 3User preferences: Change default thumbnail size to 300px based on user behavior - 10https://bugzilla.wikimedia.org/67703 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None Based on preference change logs (since 2013-07-13) users across all wikis overwhelmingly change thumbnail s... [23:45:32] 3MediaWiki / 3User preferences: Change default thumbnail size to 300px based on user behavior - 10https://bugzilla.wikimedia.org/67703#c1 (10Jared Zimmerman (WMF)) Created attachment 15872 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15872&action=edit database output of logged preference changes si... [23:45:44] ok, i have more dumb questions. I have a public key set with gerrit, and the test ssh into gerrit works fine. but git review -R doesn't, and it asks for a password. [23:46:02] 3MediaWiki / 3User preferences: Change default thumbnail size to 300px based on user behavior - 10https://bugzilla.wikimedia.org/67703 (10Jared Zimmerman (WMF)) [23:46:02] 3MediaWiki / 3Skin and page rendering: Replace "Thumbnail size" property in preferences with responsive resizing images - 10https://bugzilla.wikimedia.org/67695 (10Jared Zimmerman (WMF)) [23:46:31] here's what I'm getting: http://pastebin.mozilla.org/5535208 [23:47:01] neilk_: interesting, it should probably be using ssh and not https [23:47:10] (03PS5) 10Kunalgrover05: Fix loading from DB multiple times [core] - 10https://gerrit.wikimedia.org/r/137915 [23:47:22] MatmaRex: oh wait, I think I need to re-clone the repo with my username. [23:47:30] neilk_: what does `git remote` output? one remote or two? [23:47:43] MatmaRex: "origin" [23:47:49] neilk_: git-review should create a 'gerrit' remote exactly for this reason [23:47:49] 3Wikimedia / 3Site requests: Enable TemplateData editor in Russian Wikipedia - 10https://bugzilla.wikimedia.org/67704 (10James Forrester) 3ASSI p:3Unprio s:3enhanc a:3James Forrester Per community request. [23:47:52] or it used to, at least [23:48:09] a new version was apparently released just a few days ago… [23:48:13] MatmaRex: well, perhaps this is one of the things it would have done, had git review -s succeeded. [23:48:54] i've been using my own little shell script to initialize repositories for use with gerrit for some time now, git-review just sucks too much [23:54:18] 3MediaWiki extensions / 3Cite: Cite: Provide a way for users to find articles which have the reference list inserted automatically - 10https://bugzilla.wikimedia.org/67700#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3enhanc a:3Alex Monk In bug 66860 comment 13 I suggested a defa... [23:57:32] (03CR) 10Krinkle: [C: 032] "There are quite a few matches for this method name in code, but they were all false positives." [core] - 10https://gerrit.wikimedia.org/r/142534 (owner: 10Umherirrender) [23:57:47] (03CR) 10Krinkle: [C: 032] Remove OutputPage::isUserJsAllowed() (deprecated since 1.18) [core] - 10https://gerrit.wikimedia.org/r/142535 (owner: 10Umherirrender) [23:58:04] (03CR) 10Krinkle: [C: 032] Remove Title::updateTitleProtection() (deprecated since 1.19) [core] - 10https://gerrit.wikimedia.org/r/142799 (owner: 10Umherirrender) [23:58:56] (03PS3) 10Krinkle: Change some mixed @param docs in api classes [core] - 10https://gerrit.wikimedia.org/r/144032 (owner: 10Umherirrender) [23:59:13] (03Merged) 10jenkins-bot: Remove MWNamespace::isMain() (deprecated since 1.19) [core] - 10https://gerrit.wikimedia.org/r/142032 (owner: 10Umherirrender) [23:59:30] (03Merged) 10jenkins-bot: Remove Preferences::loadOldSearchNs() (deprecated since 1.19) [core] - 10https://gerrit.wikimedia.org/r/142033 (owner: 10Umherirrender)