[00:02:01] 3Wikimedia / 3Site requests: Attach all broken autocreated local accounts to their global account - 10https://bugzilla.wikimedia.org/61876#c1 (10Kunal Mehta (Legoktm)) Discussed with hoo and Nemo in #wikimedia-tech just now, if the user is unattached, has no edits, and has an empty user_password & user_email... [00:07:06] (03PS1) 10Florianschmidtwelzow: SoftwareInfo hook requires a reference [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/144245 [00:18:53] hoo: do you want to merge https://gerrit.wikimedia.org/r/#/c/144181/ ? [00:18:58] I just want it checked in somewhere for now [00:19:42] legoktm: to later for proper code review :P [00:19:49] I can merge it, though [00:19:56] if you don't find anyone else [00:20:26] psh, reviewing. I'll add a few Python people I know of though... [00:20:51] I can as well... just not at this time of the day :P [00:21:04] ok :P [00:29:12] (03PS1) 10Yurik: Cleanup - lets make IDEs more useful [core] - 10https://gerrit.wikimedia.org/r/144246 [00:33:29] (03PS1) 10Yurik: Updated spelling dictionary [core] - 10https://gerrit.wikimedia.org/r/144247 [02:20:40] 3MediaWiki / 3Special pages: Missing system messages are doubly escaped at Special:Specialpages - 10https://bugzilla.wikimedia.org/67547 (10This, that and the other) 3NEW p:3Unprio s:3minor a:3None [[foundation:Special:SpecialPages#mw-specialpagesgroup-other]] has Other special pages <mathsh... [02:23:38] 3MediaWiki extensions / 3Math: Math extension doesn't support many languages including Malayalam, Hindi, and Tamil - 10https://bugzilla.wikimedia.org/48032#c40 (10This, that and the other) 5PATC>3NEW The patches seem to have been merged or abandoned, so setting back to NEW. [03:01:52] 3MediaWiki / 3Parser: Enable customizing of CSS values filter - 10https://bugzilla.wikimedia.org/11106#c3 (10Daniel Renfro) Looks like the commit to Sanitizer.php that disallows the CSS url() function was meant to avoid running JavaScript in CSS with the url("javascript:..."); type of thing. (See the Mozilla... [03:14:22] (03CR) 10MaxSem: [C: 032] "I wonder what should all those people who still have precise do... Oh well:P" [vagrant] - 10https://gerrit.wikimedia.org/r/144243 (owner: 10BryanDavis) [03:14:47] (03Merged) 10jenkins-bot: Fix wikimania_scholarships for 14.04 [vagrant] - 10https://gerrit.wikimedia.org/r/144243 (owner: 10BryanDavis) [03:31:07] (03PS1) 10Danielrenfro: Breaking out disallowed CSS into a global variable (bug11106) [core] - 10https://gerrit.wikimedia.org/r/144249 [04:09:25] 3Wikimedia / 3Site requests: Change user groups rights on ckb.wikipedia - 10https://bugzilla.wikimedia.org/67529#c1 (10This, that and the other) (In reply to Calak from comment #0) > Since autoconfirmed user group dosen't have upload right in our wikipedia It seems that the Mobile upload button will upload... [04:34:07] 3Wikimedia / 3OTRS: Please adjust and change the "standard default otrs favicon" to the Wikimedia favicon standard - 10https://bugzilla.wikimedia.org/17271#c4 (10Keegan Peterzell) 5RESO/FIX>3REOP Since upgrading OTRS in 2013, the OTRS favicon has reverted to the OTRS stock. Can we please have the Wikimed... [04:35:53] (03PS1) 10Awight: Fix apache config for Fundraising CRM [vagrant] - 10https://gerrit.wikimedia.org/r/144250 [04:38:53] 3Wikimedia / 3OTRS: Please adjust and change the "standard default otrs favicon" to the Wikimedia favicon standard - 10https://bugzilla.wikimedia.org/17271#c5 (10Keegan Peterzell) a:5Tim Starling>3None removing Tim as assignee. [04:50:53] 3MediaWiki / 3General/Unknown: Update branches in mediawiki/extensions/* for REL1_23 - 10https://bugzilla.wikimedia.org/64157#c26 (10Mark A. Hershberger) Fixed the ones in Comment 19. Emailed a couple of q's to developers about the right revision to use, but it should be fixed now. [05:37:42] who wants to +2 minor, mostly comment cleanup? https://gerrit.wikimedia.org/r/#/c/144246/ [05:38:00] and there is a dictionary update (used by IDEs) -- https://gerrit.wikimedia.org/r/#/c/144247/ [05:43:00] (03PS1) 10Shirayuki: i18n: remove "to" from action-* messages [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/144251 [05:48:18] (03PS1) 10Awight: Provide a default password for the Fundraising Drupal admin user [vagrant] - 10https://gerrit.wikimedia.org/r/144252 [06:13:45] MaxSem, around? [06:13:55] yep [06:18:52] 3MediaWiki / 3Special pages: Missing system messages are doubly escaped at Special:Specialpages - 10https://bugzilla.wikimedia.org/67547#c1 (10Bawolff (Brian Wolff)) Humans should also never see a missing system message. (In ideal world) [06:34:22] 3MediaWiki / 3Special pages: Missing system messages are doubly escaped at Special:Specialpages - 10https://bugzilla.wikimedia.org/67547#c2 (10Bawolff (Brian Wolff)) Hmm possibly we should do something like: diff --git a/includes/Message.php b/includes/Message.php index 826d55b..e340063 100644 --- a/incl... [06:34:52] 3MediaWiki / 3Special pages: Missing system messages are doubly escaped at Special:Specialpages - 10https://bugzilla.wikimedia.org/67547 (10Bawolff (Brian Wolff)) [06:41:21] 3MediaWiki extensions / 3UniversalLanguageSelector: Urdu: add Hussaini Nastaleeq font in Nastaʿlīq/Nastalique/Nastaleeq/Nastaliq style - 10https://bugzilla.wikimedia.org/56939#c39 (10Khaled Hosny) For the record, I’m not involved with Urdu Wikipedia in anyway (so can’t do anything about the data URI font). I... [06:46:40] (03PS1) 10Brian Wolff: Degrade gracefully on missing special page description message. [core] - 10https://gerrit.wikimedia.org/r/144253 (https://bugzilla.wikimedia.org/67547) [06:52:15] (03PS2) 10Yurik: Cleanup - lets make IDEs more useful [core] - 10https://gerrit.wikimedia.org/r/144246 [07:14:08] is there a way to get a local link to the api endpoint? A php func that returns /w/api.php ? [07:16:53] yurikR: wfScript( 'api' ) I think [07:17:30] yeah, that's it [07:17:40] legoktm, thanks! [07:17:54] 3MediaWiki / 3Special pages: "Create account" appears in bold on Special:Specialpages despite not being restricted - 10https://bugzilla.wikimedia.org/67549 (10This, that and the other) 3NEW p:3Unprio s:3normal a:3None See any wiki running master branch or recent 1.24wmf branches, e.g. [[Special:Speci... [07:18:51] 3MediaWiki / 3Special pages: "Create account" appears in bold on Special:Specialpages despite not being restricted - 10https://bugzilla.wikimedia.org/67549#c1 (10This, that and the other) Was apparently caused by [1]. [1] https://gerrit.wikimedia.org/r/#/c/139392/2/includes/specials/SpecialCreateAccount.php [07:19:54] (03CR) 10TTO: Only list Create account when permissions allow it (031 comment) [core] - 10https://gerrit.wikimedia.org/r/139392 (https://bugzilla.wikimedia.org/66589) (owner: 10Talktodan) [07:38:51] (03CR) 10TTO: [C: 031] "Pretty much was I was thinking." [core] - 10https://gerrit.wikimedia.org/r/144253 (https://bugzilla.wikimedia.org/67547) (owner: 10Brian Wolff) [07:48:52] 3MediaWiki extensions / 3FlaggedRevs: AJAX review errors show HTML markup in notification - 10https://bugzilla.wikimedia.org/67023#c1 (10Michael M.) *** Bug 67484 has been marked as a duplicate of this bug. *** [07:48:52] 3MediaWiki extensions / 3FlaggedRevs: tooltip with message 'revreview-failed' contains plain html - 10https://bugzilla.wikimedia.org/67484#c1 (10Michael M.) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 67023 *** [08:06:21] 3Wikimedia / 3Site requests: Change user groups rights on ckb.wikipedia - 10https://bugzilla.wikimedia.org/67529#c2 (10Calak) It seems that the mobile upload button always uploads pictures to Commons, regardless of the user right! I don't know what is the function of the 'mf-uploadbutton' right; isn't that... [08:08:54] (03CR) 10Umherirrender: Degrade gracefully on missing special page description message. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/144253 (https://bugzilla.wikimedia.org/67547) (owner: 10Brian Wolff) [08:16:48] (03CR) 10Umherirrender: "The call of UploadFromUrl::isAllowed was added with r109562" [core] - 10https://gerrit.wikimedia.org/r/142000 (https://bugzilla.wikimedia.org/39507) (owner: 10Rohan013) [08:21:06] 3MediaWiki extensions / 3FlaggedRevs: AJAX review errors show HTML markup in notification - 10https://bugzilla.wikimedia.org/67023#c2 (10Umherirrender) Affected message key for better search result: 'revreview-failed' [08:26:08] 3MediaWiki extensions / 3UniversalLanguageSelector: Urdu: add Hussaini Nastaleeq font in Nastaʿlīq/Nastalique/Nastaleeq/Nastaliq style - 10https://bugzilla.wikimedia.org/56939#c40 (10ameen.akbar) Hello dear all. i am very sorry for late reply. I dont know the technical things which you made. But the site is... [08:27:02] (03PS1) 10Legoktm: Add maintenance script to send messages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/144256 [08:27:04] (03CR) 10jenkins-bot: [V: 04-1] Add maintenance script to send messages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/144256 (owner: 10Legoktm) [08:27:51] (03PS2) 10Legoktm: Add maintenance script to send messages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/144256 [08:28:01] (03CR) 10jenkins-bot: [V: 04-1] Add maintenance script to send messages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/144256 (owner: 10Legoktm) [08:30:52] (03PS3) 10Legoktm: Add maintenance script to send messages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/144256 [08:44:36] 3Wikimedia / 3General/Unknown: Migrate to SUL all non-clashing accounts - 10https://bugzilla.wikimedia.org/39817 (10Nemo) [08:44:37] 3Wikimedia / 3Site requests: Attach all broken autocreated local accounts to their global account - 10https://bugzilla.wikimedia.org/61876#c2 (10Nemo) p:5Normal>3High (In reply to Kunal Mehta (Legoktm) from comment #1) > if the user is > unattached, has no edits, and has an empty user_password & user_ema... [08:48:08] 3Wikimedia / 3General/Unknown: Migrate to SUL all non-clashing accounts - 10https://bugzilla.wikimedia.org/39817#c11 (10Nemo) p:5Normal>3High a:5Dan Garry>3Kunal Mehta (Legoktm) (In reply to Kunal Mehta (Legoktm) from comment #10) > I ran the query in comment 5, and came up with 10596 users across al... [08:50:25] (03CR) 10Nikerabbit: [C: 04-1] Degrade gracefully on missing special page description message. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/144253 (https://bugzilla.wikimedia.org/67547) (owner: 10Brian Wolff) [08:50:37] (03CR) 10Raimond Spekking: [C: 032 V: 032] i18n: remove "to" from action-* messages [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/144251 (owner: 10Shirayuki) [08:52:37] 3Wikimedia / 3SSL related: Add Forward Secrecy - 10https://bugzilla.wikimedia.org/53259#c18 (10chmarkine) I agree with Jan. I think disabling SSL3 and non-fs ciphers is feasible, because only IE 6-8 on XP do not support any FS ciphers, only IE 6 does not support TLS 1.0 or higher, and even IE 7 on Vista supp... [08:59:04] (03PS4) 10Legoktm: Add maintenance script to send messages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/144256 [09:16:08] (03PS1) 10Legoktm: Add --attachbroken option to migrateAccount.php [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144257 (https://bugzilla.wikimedia.org/61876) [09:17:24] (03CR) 10jenkins-bot: [V: 04-1] Add --attachbroken option to migrateAccount.php [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144257 (https://bugzilla.wikimedia.org/61876) (owner: 10Legoktm) [09:17:42] (03CR) 10Legoktm: "recheck" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144257 (https://bugzilla.wikimedia.org/61876) (owner: 10Legoktm) [09:18:07] thought so. [09:18:14] silly jenkins-bot [09:18:51] 3MediaWiki extensions / 3CLDR: Wrong language name for Arpitan - 10https://bugzilla.wikimedia.org/50378#c5 (10Nemo) 5UNCO>3RESO/INV 1) The endonym has been requested and added upstream. 2) Translations are being collected (currently vetted), e.g. http://st.unicode.org/cldr-apps/v#/fr/Languages_E_J/ "fran... [09:20:40] 3Wikimedia / 3General/Unknown: Migrate to SUL all non-clashing accounts - 10https://bugzilla.wikimedia.org/39817#c12 (10Kunal Mehta (Legoktm)) (In reply to Nemo from comment #11) > (In reply to Kunal Mehta (Legoktm) from comment #10) > > I ran the query in comment 5, and came up with 10596 users across all w... [09:23:10] 3Wikimedia / 3SSL related: Add Forward Secrecy - 10https://bugzilla.wikimedia.org/53259#c19 (10chmarkine) I just find more and more sites with no FS: * gerrit.wikimedia.org * wikitech.wikimedia.org * ticket.wikimedia.org * lists.wikimedia.org * dumps.wikimedia.org * graphite.wikimedia.org * gdash.wikimedia.... [09:36:25] (03PS43) 10Paladox: Update jquery.hoverintent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [09:52:39] 3Wikimedia / 3Site requests: Attach all broken autocreated local accounts to their global account - 10https://bugzilla.wikimedia.org/61876#c4 (10Kunal Mehta (Legoktm)) I made a fork of sul-audit.py (source: ) to detect broken accounts, it's running on ter... [09:52:54] 3MediaWiki extensions / 3CLDR: zh-min-nan has no English exonym - 10https://bugzilla.wikimedia.org/31127#c6 (10Nemo) 5NEW>3RESO/INV (In reply to Niklas Laxström from comment #5) > Anyway Robin > has proposed a fix for this bug on wikitech. http://markmail.org/thread/oiltb5urgwcxqdl5 / https://translatew... [10:03:09] 3MediaWiki / 3Internationalization: Interlanguage list should be rendered according to context language (user interface language) - 10https://bugzilla.wikimedia.org/37703#c11 (10Nemo) 5NEW>3RESO/WOR The endonym must be used and the casing was fixed long ago, nothing to do here AFAIK. [10:23:24] 3Wikimedia / 3General/Unknown: en.wikipedia.org load takes 12+ seconds in specific Source IP range, as one specific call to bits.wikimedia.org/.../load.php times out - 10https://bugzilla.wikimedia.org/42653#c18 (10Nemo) Every time I look (e.g. on webpagetest.org), I always find one or two "failing" load.php... [10:23:54] 3MediaWiki / 3Parser: Local interwiki links with no page title should point to the main page - 10https://bugzilla.wikimedia.org/64167 (10This, that and the other) 5PATC>3RESO/FIX [10:25:54] 3MediaWiki / 3Internationalization: Update plural data to CLDR version 25 - 10https://bugzilla.wikimedia.org/62861#c2 (10Nemo) (In reply to Gerrit Notification Bot from comment #1) > Change 121025 had a related patch set uploaded by Nikerabbit: > Update plurals.xml to CLDR 25 > > https://gerrit.wikimedia.or... [10:33:18] (03PS1) 10Umherirrender: Replace deprecated User::isValidEmailAddr call [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/144261 [10:33:46] (03PS2) 10Umherirrender: Replace deprecated User::isValidEmailAddr calls [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/144261 [10:33:52] (03CR) 10Umherirrender: "Untested. Simple replace of the deprecated method." [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/144261 (owner: 10Umherirrender) [10:39:13] (03PS2) 10Umherirrender: Replace deprecated Title::escapeFullURL call [extensions/Commentbox] - 10https://gerrit.wikimedia.org/r/142783 [10:39:39] 3MediaWiki extensions / 3CLDR: Fix translations of Germanic languages' names in English - 10https://bugzilla.wikimedia.org/37994#c3 (10Nemo) Most of those have been added upstream, see https://translatewiki.net/wiki/Thread:Support/Language_names_not_in_Unicode_CLDR and please continue the discussion there. [10:41:40] (03CR) 10Tbleher: [C: 032 V: 032] "So, what do I have to do to merge the change? Cherry-picking the change didn'T do anything useful. Now trying to set +2 Verified and +2 Lo" [extensions/Commentbox] - 10https://gerrit.wikimedia.org/r/142783 (owner: 10Umherirrender) [10:47:05] (03PS1) 10Umherirrender: Replace deprecated User::isValidEmailAddr calls [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/144262 [10:47:23] (03CR) 10Umherirrender: "Untested. Simple replace of the deprecated method." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/144262 (owner: 10Umherirrender) [10:50:24] 3Wikimedia / 3Site requests: Attach all broken autocreated local accounts to their global account - 10https://bugzilla.wikimedia.org/61876#c5 (10Kunal Mehta (Legoktm)) Script took ~43m: legoktm@terbium:~$ cat sul/broken-accounts.tsv | wc -l 18571 [10:53:36] (03CR) 10Legoktm: "Something is wrong with the hash for the minify-js key on the private module. jenkins is reporting 54ada2ac120643f49330e876a18bccf3, I'm s" [core] - 10https://gerrit.wikimedia.org/r/142830 (owner: 10Legoktm) [10:56:26] (03CR) 10Umherirrender: "Thanks" [extensions/Commentbox] - 10https://gerrit.wikimedia.org/r/142783 (owner: 10Umherirrender) [11:01:40] 3Wikimedia / 3Interwiki links: b: doesn't work from Wikibooks; neither n: from Wikinews nor q: from Wikiquote, etc. - 10https://bugzilla.wikimedia.org/955#c16 (10This, that and the other) Restoring old summary; I think I understand what this bug is really about now. Only took me 10 months to figure it out... [11:09:31] (03CR) 10Martineznovo: "Mark: While you CR+2, this change hasn't been merged yet. I'm wondering if you expect Jenkins to merge it automatically to the repository." [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/139409 (owner: 10Martineznovo) [11:12:38] (03PS2) 10PleaseStand: Special:Search: Remove token from URL when saving settings [core] - 10https://gerrit.wikimedia.org/r/144180 [11:19:43] (03CR) 10Legoktm: [C: 04-1] "Ah, got it. So, what happens is, the minify-css output (including cache key!) is then minified in minify-js. Because the cache key varies " [core] - 10https://gerrit.wikimedia.org/r/142830 (owner: 10Legoktm) [11:21:55] (03CR) 10Nemo bis: Special:Search: Remove token from URL when saving settings (031 comment) [core] - 10https://gerrit.wikimedia.org/r/144180 (owner: 10PleaseStand) [11:22:38] (03PS7) 10Legoktm: Add tests for OutputPage::makeResourceLoaderLink() [core] - 10https://gerrit.wikimedia.org/r/142830 [11:26:05] (03PS8) 10Legoktm: Add tests for OutputPage::makeResourceLoaderLink() [core] - 10https://gerrit.wikimedia.org/r/142830 [11:32:12] (03CR) 10Legoktm: [C: 031] "for Krinkle's changes." [core] - 10https://gerrit.wikimedia.org/r/142830 (owner: 10Legoktm) [11:32:31] (03PS12) 10Legoktm: OutputPage: Support foreign module sources in makeResourceLoaderLink [core] - 10https://gerrit.wikimedia.org/r/142766 [11:32:46] (03PS6) 10Legoktm: Add OutputPageScriptsForBottomQueue hook [core] - 10https://gerrit.wikimedia.org/r/141282 (https://bugzilla.wikimedia.org/62602) [11:41:24] 3MediaWiki extensions / 3Cite: Provide new special pages for statistics on the number of references tags per article - 10https://bugzilla.wikimedia.org/21209#c4 (10Joe ST) Created attachment 15852 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15852&action=edit adds a page-property which counts... [11:46:22] (03CR) 10PleaseStand: Special:Search: Remove token from URL when saving settings (031 comment) [core] - 10https://gerrit.wikimedia.org/r/144180 (owner: 10PleaseStand) [11:52:21] (03CR) 10Fomafix: "The response gets always delivered with" [core] - 10https://gerrit.wikimedia.org/r/142052 (owner: 10MaxSem) [11:54:55] 3MediaWiki extensions / 3CLDR: MWTimestamp::getHumanTimestamp() (aka timestamps in echo) not translated into Chechen - 10https://bugzilla.wikimedia.org/62607#c17 (10Andre Klapper) Umar: Have you filed a ticket under cldr.unicode.org for the locale? See comment 11. Please provide the full link to your request... [12:23:36] (03CR) 10Hoo man: Add --attachbroken option to migrateAccount.php (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144257 (https://bugzilla.wikimedia.org/61876) (owner: 10Legoktm) [12:44:40] 3MediaWiki / 3Special pages: Delete and move warning should be displayed for assciated talk pages - 10https://bugzilla.wikimedia.org/10814#c1 (10Andre Klapper) *** Bug 18260 has been marked as a duplicate of this bug. *** [12:44:40] 3MediaWiki / 3Page deletion: Streamline move process for talk pages - 10https://bugzilla.wikimedia.org/18260#c1 (10Andre Klapper) 5NEW>3RESO/DUP Hi Aervanath. Thanks for taking the time to report this! This particular problem has already been reported into our bug tracking system, but please feel free to... [12:44:54] 3MediaWiki / 3Special pages: Delete and move warning should be displayed for associated talk pages - 10https://bugzilla.wikimedia.org/10814#c2 (10Andre Klapper) Nowadays, when you move a normal page, you have the setting "Move associated talk page" autoticked (also see bug 17775). I wonder if that influence... [12:47:40] 3MediaWiki / 3History/Diffs: Change lists and page histories should use tables - 10https://bugzilla.wikimedia.org/10955#c1 (10Andre Klapper) Still valid in 1.24:
    [12:56:46] (03PS1) 10Hoo man: Show a link to Special:GlobalRenameProgress if a global rename is in progress [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144265 [12:56:55] 3MediaWiki / 3Parser: Different rendering of a list related to transclude when preview/old rev/rendering a page - 10https://bugzilla.wikimedia.org/13787#c1 (10Andre Klapper) 5NEW>3UNCO p:5Low>3Lowest Hi Michael! Sorry that nobody has taken a look at this report yet and given feedback. What is the ac... [12:59:25] 3MediaWiki / 3Page editing: Allow definition to be used as a link target - 10https://bugzilla.wikimedia.org/14215#c1 (10Andre Klapper) p:5Low>3Lowest Hi Jon! Sorry that nobody has taken a look at this report yet and given feedback. Jon: What is an actual usecase for this? Where can I read more about "de... [13:05:10] 3MediaWiki extensions / 3Cite: Provide new special pages for statistics on the number of references tags per article - 10https://bugzilla.wikimedia.org/21209#c5 (10Joe ST) An alternative to my previous patch would be to place the following line in the if statement instead of the first line: $this->mPa... [13:23:33] (03CR) 10Smuggli: [C: 032 V: 032] Replace deprecated User::isValidEmailAddr calls [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/144262 (owner: 10Umherirrender) [14:07:34] (03PS1) 10Deepali: Add variables to enable or disable parts of the extension [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/144266 (https://bugzilla.wikimedia.org/51844) [14:18:23] (03PS1) 10Deepali: Add message documentation for newly added messages [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/144267 (https://bugzilla.wikimedia.org/66879) [15:10:11] (03PS1) 10MarkAHershberger: update .gitreview [extensions/BlockAndNuke] (REL1_23) - 10https://gerrit.wikimedia.org/r/144268 [15:30:06] (03CR) 10MarkAHershberger: [V: 032] "I did expect it, but I'll have to look at this in a while since I'm working on Bug #64157 right now." [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/139409 (owner: 10Martineznovo) [16:57:20] (03CR) 10Brian Wolff: [C: 031] Special:Search: Remove token from URL when saving settings (031 comment) [core] - 10https://gerrit.wikimedia.org/r/144180 (owner: 10PleaseStand) [17:12:06] (03CR) 10MaxSem: "@Fomafix, this is expected because API never takes HTTP headers into account." [core] - 10https://gerrit.wikimedia.org/r/142052 (owner: 10MaxSem) [17:31:25] 3MediaWiki / 3General/Unknown: Extensions missing REL1_23 branches - 10https://bugzilla.wikimedia.org/67270#c31 (10Mark A. Hershberger) Was just checking a fresh checkout of the extensions directory and it looks like you didn't actually branch PhpTags (set branch to Ib6e62863d6ec34e7ec696fe203d9fcf99abbbbd7)... [17:41:42] (03PS2) 10Brian Wolff: Degrade gracefully on missing special page description message. [core] - 10https://gerrit.wikimedia.org/r/144253 (https://bugzilla.wikimedia.org/67547) [17:42:13] (03CR) 10Brian Wolff: Degrade gracefully on missing special page description message. (033 comments) [core] - 10https://gerrit.wikimedia.org/r/144253 (https://bugzilla.wikimedia.org/67547) (owner: 10Brian Wolff) [17:59:49] (03PS1) 10MarkAHershberger: remove IframePage, ValueView [extensions] - 10https://gerrit.wikimedia.org/r/144269 (https://bugzilla.wikimedia.org/67270) [18:02:36] (03Abandoned) 10MarkAHershberger: remove IframePage, ValueView [extensions] - 10https://gerrit.wikimedia.org/r/144269 (https://bugzilla.wikimedia.org/67270) (owner: 10MarkAHershberger) [18:06:50] (03PS1) 10MarkAHershberger: set REL1_23 branch for .gitreview. Bug: 67270 [extensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/144270 (https://bugzilla.wikimedia.org/67270) [18:07:32] (03PS2) 10Brian Wolff: Set REL1_23 branch for .gitreview. [extensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/144270 (https://bugzilla.wikimedia.org/67270) (owner: 10MarkAHershberger) [18:11:59] (03PS1) 10MarkAHershberger: set REL1_23 branch for .gitreview. Bug: 67270 [extensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/144271 (https://bugzilla.wikimedia.org/67270) [18:12:54] (03CR) 10MarkAHershberger: [C: 032] Set REL1_23 branch for .gitreview. [extensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/144270 (https://bugzilla.wikimedia.org/67270) (owner: 10MarkAHershberger) [18:13:59] hexmode: Put an extra new line between the bug number and the subject of the commit message (and no empty line between bug number and change-id) so that gerrit bugzilla bot picks up the change [18:18:10] 3MediaWiki extensions / 3BookManagerv2: Same readability options on all chapters of the book - 10https://bugzilla.wikimedia.org/66957#c1 (10Deepali Jain) 5NEW>3RESO/FIX Related patch in gerrit: https://gerrit.wikimedia.org/r/#/c/142555/ [18:18:40] (03PS1) 10Florianschmidtwelzow: Move Alias back to root [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/144272 [18:20:10] 3Wikimedia / 3OTRS: different merge methods produce different results (extra articles?) - 10https://bugzilla.wikimedia.org/67264#c6 (10Casey Brown) In the ticket history I see 7 merge ticket actions. I'm not sure exactly what the issue is here. Are there more tickets merged than should be? It could be user e... [18:20:30] (03PS3) 10Brian Wolff: Disables upload by url option for users without the necessary permissions [core] - 10https://gerrit.wikimedia.org/r/142000 (https://bugzilla.wikimedia.org/39507) (owner: 10Rohan013) [18:20:41] (03CR) 10Brian Wolff: [C: 032] "Thanks for fixing this." [core] - 10https://gerrit.wikimedia.org/r/142000 (https://bugzilla.wikimedia.org/39507) (owner: 10Rohan013) [18:20:47] (03PS2) 10MarkAHershberger: set REL1_23 branch for .gitreview. Bug: 67270 [extensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/144271 (https://bugzilla.wikimedia.org/67270) [18:21:32] (03PS3) 10MarkAHershberger: Remove IframePage and ValueView [extensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/144271 (https://bugzilla.wikimedia.org/67270) [18:21:50] (03CR) 10MarkAHershberger: [C: 032] Remove IframePage and ValueView [extensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/144271 (https://bugzilla.wikimedia.org/67270) (owner: 10MarkAHershberger) [18:22:02] (03PS2) 10Florianschmidtwelzow: Move Alias back to root [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/144272 [18:22:40] 3MediaWiki / 3Parser: Local interwiki links with no page title should point to the main page - 10https://bugzilla.wikimedia.org/64167 (10TeleComNasSprVen) [18:22:40] 3MediaWiki / 3General/Unknown: Include a "default" value in the interwiki table for an interwiki prefix with no value - 10https://bugzilla.wikimedia.org/27216 (10TeleComNasSprVen) [18:24:56] (03Merged) 10jenkins-bot: Disables upload by url option for users without the necessary permissions [core] - 10https://gerrit.wikimedia.org/r/142000 (https://bugzilla.wikimedia.org/39507) (owner: 10Rohan013) [18:28:56] (03PS5) 10Brian Wolff: Replace ExtractThumbParameters hook with parseParamString method [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/140870 [18:32:57] 3MediaWiki / 3General/Unknown: Wikidata entry creation form does not permit using Commons - 10https://bugzilla.wikimedia.org/67553 (10Pete F) 3NEW p:3Unprio s:3normal a:3None When first creating a Wikidata entry from the left hand navigation "add links" link, it's not possible to add a page from Comm... [18:40:12] 3MediaWiki / 3General/Unknown: Wikidata entry creation form does not permit using Commons - 10https://bugzilla.wikimedia.org/67553 (10John F. Lewis) p:5Unprio>3Normal s:5normal>3major a:3Wikidata bugs [18:55:31] (03PS1) 10Devanw: add mw-diff-* classes to view diff page header links [core] - 10https://gerrit.wikimedia.org/r/144273 (https://bugzilla.wikimedia.org/44242) [19:01:00] are there any server-side ttf fonts in production? I see some .ttf files in UniversalLanguageSelector and one in Flow extensions. [19:01:31] do we have a unified font store that all extensions can use, or should i just copy it into my ext? [19:01:57] not to my knowladge [19:02:16] ULS uses webfonts to display weird languages with poor client support [19:03:08] From a server side prespective, various font files are used by the svg renders. The timeline extension uses FreeSans. Those things just use the system fonts I believe (Image scalers have extra fonts installed) [19:03:34] bawolff, i need to render a GIF server-side. Debating on the best approach [19:03:46] apparently GD is disabled :( [19:03:58] I'd use image magick [19:04:29] bawolff, does it stream directly or save a file? [19:04:45] i'm guessing its a standalone... [19:04:52] image magick? It can do either I believe [19:05:05] Out of curiosity, why do you need to render gif files? [19:05:28] https://www.mediawiki.org/wiki/Requests_for_comment/Unfragmented_ZERO_design#Banner_generation [19:06:14] in case of NOSCRIPT, need to generate a banner image [19:07:11] With image magick you can do things like: [19:07:19] convert -background lightblue pango:"Some text here" [19:07:49] but doesn't it always create a file? I would rather just serve it without temps [19:07:57] and rely on varnish to cache it [19:08:35] convert -background lightblue pango:"test" png:- [19:08:39] puts it to stdout [19:09:10] there is a way to convert stdout directly into php out? [19:09:12] echo [19:10:19] Well also passthru() [19:10:58] but that doesn't use our shell wrappers, so you'd probably be better off doing $png = wfShellExec( ... ); $wgOut->disable(); echo $png; [19:11:20] oh, that sounds good :) [19:11:31] bawolff, what about complex font issue? [19:12:00] pnago should have good support for complex font thingies [19:12:02] *pango [19:12:16] oh hmm, that's new in image magick v6.7.6-3 [19:12:42] pango is a lib in magick? [19:13:14] pango is a generic text rendering library. Its used all over the place [19:14:02] bleh, we still have 6.6.9-7 [19:14:22] yeah [19:14:39] Although I think we're updating in 1-2 months possibly [19:16:29] (03PS1) 10Umherirrender: Replace deprecated User::editToken call [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/144276 [19:16:32] ok, so to sum up: to generate gifs i would use the wfShellExec('convert'), without pango: command yet, and streaming the output directly. Once pango is available, switch to that [19:17:00] if font is not supported - oh well, most likely that device won't understand it anyway [19:17:02] no, pango is a library used by image magick [19:17:27] from their page: The "pango:" text coder (fully working as of IM v6.7.6-3) [19:17:32] (03CR) 10Umherirrender: "Untested. Simple replace of the deprecated method." [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/144276 (owner: 10Umherirrender) [19:17:35] which parts don't work? [19:18:22] Well on 6.6 (the version on my computer), none of it works [19:18:25] but you can do [19:18:27] convert -background lightblue label:"test" png:- [19:18:36] which does work on older image magick [19:18:50] exactly :) [19:19:10] so i will persue the label: approach, switching it to pango later [19:20:22] Ah sorry, I got confused by what you said earlier. I thought you wanted to switch to a pango command [19:20:49] In my initial test, label: doesn't like arabic very much [19:21:19] * bawolff is btw, looking at http://www.imagemagick.org/Usage/text/ [19:21:21] (03PS1) 10Mvolz: Naive scraper for when Z translator not available [services/citoid] - 10https://gerrit.wikimedia.org/r/144277 [19:21:37] np, thx :) one more thing - any suggestions on how to keep the width down? My strings are like "Free {{SITENAME}} from " [19:21:44] yeah, i'm on that page too ;) [19:21:57] don't want it too big though - very small screen [19:22:16] so either i render a different standard text "Free Wikipedia" in multiple languages [19:22:23] (03CR) 10Mvolz: [C: 032 V: 032] Naive scraper for when Z translator not available [services/citoid] - 10https://gerrit.wikimedia.org/r/144277 (owner: 10Mvolz) [19:22:38] or need to futs with -size [19:22:47] Or I guess add a line break [19:23:05] (03PS1) 10Umherirrender: Replace deprecated User::editToken call [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/144278 [19:23:17] how do you mean? [19:23:24] (03CR) 10Umherirrender: "Untested. Simple replace of the deprecated method." [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/144278 (owner: 10Umherirrender) [19:23:31] mgk does wrapping on its own [19:23:45] but i would rather have smaller font than wrap [19:23:48] oh it does, I didn't realize that [19:24:21] -trim is good too [19:24:41] (03CR) 10Anomie: [C: 04-1] "I'd really rather not litter the code with pointless "/** @var stdClass $row */" all over the place for the benefit of some random IDE. It" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/144246 (owner: 10Yurik) [19:26:32] yurikR: Hmm, my initial issue with arabic text was having the wrong font. After changing fonts though, it works. But BiDi is broken. I think its safe to say that label: does not handle complex fonts well [19:27:31] And I think the middle vs begin vs end forms of the arabic text it rendered was wrong, but I don't read arabic so hard for me to tell for sure [19:27:40] 3MediaWiki / 3API: action=purge generator mode does not show query continue - 10https://bugzilla.wikimedia.org/60734#c3 (10Brad Jorsch) 5PATC>3RESO/FIX Should be deployed to WMF wikis with 1.24wmf13, see https://www.mediawiki.org/wiki/MediaWiki_1.24/Roadmap for the schedule. [19:28:45] (03PS1) 10Umherirrender: Replace deprecated User::editToken call [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/144279 [19:29:15] (03PS2) 10Umherirrender: Replace deprecated User::editToken calls [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/144279 [19:29:19] (03CR) 10Umherirrender: "Untested. Simple replace of the deprecated method." [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/144279 (owner: 10Umherirrender) [19:29:40] (03CR) 10Yurik: "Anomie, it benefits coders, not IDEs. Please try phpStorm or any other reasonable IDE that does type-checking on the fly, and you will see" [core] - 10https://gerrit.wikimedia.org/r/144246 (owner: 10Yurik) [19:30:49] bawolff, what font did you use? [19:31:05] FreeSeirf [19:31:43] do you know if its own the prod by default? [19:33:00] Should be. I think that's what is currently used by Timeline extension possibly [19:36:04] yurikR: Or hmm, timeline uses a font file called FreeSansWMF.ttf [19:36:30] which is a custom font file in /usr/local/apache/common/fonts apparently [19:36:31] oh, is that a magic font i can use for everything? :) [19:36:41] lovelly ) [19:37:09] at least that's what the comment in CommonSettings.php suggests [19:39:32] bawolff, apparently by default it uses FreeSans [19:40:01] I wonder if i should piggyback on the merged one [19:40:32] although 'zh' uses a different one alltogether [19:40:46] yeah, last I heard it still didn't work correctly either [19:41:36] So I tested all the text writing methods of image magick. All of them except for pango: do not handle complex scripts well at all and output arabic in the wrong order [19:41:54] well, as i said, my goal is to cover the most common phones, who might not even support some scripts [19:42:25] i thought you said :label worked with arabic? [19:42:37] for simple strings that is [19:43:20] It outputs arabic letters, just doesn't do any complex rendering (e.g. doing it RTL and changing the form of letters based on where in the word it is) (My original test just outputted ?'s because of wrong font) [19:44:33] So provided you stick to latin alphabet (Even combining letters in latin alphabet seem to work ok), then its ok [19:44:47] sigh [19:44:50] ok, thx :) [19:45:02] some other scripts may work ok to. Hebrew would probably work if you entered the text in reverse order [19:45:26] it sucks that it takes five times as much time to support obscure corner cases (older phones) than implementing for the 99% :) [19:45:44] i would much rather let the browser deal with all thi [19:45:54] uuugh [19:46:07] Hmm, good news - according to http://packages.ubuntu.com/trusty/imagemagick - unbuntu trusty uses a version of image magick that supports pango [19:46:21] oh? [19:46:30] And I think we're switching to trusty in about a month [19:46:33] so vagrant and prod support it? [19:46:36] nice! [19:47:13] thanks for all your help!!! [19:47:14] although you'd probably want to double check with ops about that, in case there's something silly like we package our own version of image magick or something [19:47:23] but that sounds unlikely [19:47:32] wouldn't put it past ops ;) [19:47:52] if there is a way to create a custom WMF package, it has already been done [19:48:25] although they objected to creating a custom package for ffmpeg :s [19:48:36] a month? that sounds optimistic [19:48:46] hi YuviPanda [19:48:50] hi yurikR :) [19:48:55] two three monhs is fine for me [19:49:03] * bawolff thought someone said 2 months like a month ago :) [19:49:07] you should check with ops on their timeline [19:49:15] i will simply output text in english only [19:49:39] using backward-slanted font [19:50:00] noone reads banners anyway [19:50:08] but that sounds unlikely ... we used to http://apt.wikimedia.org/wikimedia/pool/main/i/imagemagick/ :P [19:50:30] hahaha [19:51:05] * yurikR switches all letters to spaces [19:51:15] best strategy, yes [19:51:25] * YuviPanda tears head out at the web being stupid for inscrutable reasons [19:51:38] I've a request. I do it with curl, copy pasting the POST data from chrome inspector. works fine [19:51:48] and yet when it is made by JS in grafana it just hangs forever [19:52:34] * yurikR thinks YuviPanda speaks in tongues [19:52:44] heh [19:53:08] yurikR: been doing a lot of opsy monitoringy stuff the last week [20:00:47] (03PS4) 10Inchikutty: [WIP]Improves zoom; enables drag on map [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/144151 [20:00:57] (03CR) 10jenkins-bot: [V: 04-1] [WIP]Improves zoom; enables drag on map [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/144151 (owner: 10Inchikutty) [20:02:03] (03PS1) 10Umherirrender: Remove deprecated Skin::makeGlobalVariablesScript [core] - 10https://gerrit.wikimedia.org/r/144321 [20:11:38] (03PS5) 10Inchikutty: Improves zoom; enables drag on map [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/144151 [20:23:13] (03PS6) 10Inchikutty: Improves zoom; enables drag on map [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/144151 [20:23:32] (03CR) 10Ori.livneh: [C: 032] Make luasandbox_version.h generation work on OS X [php/luasandbox] - 10https://gerrit.wikimedia.org/r/143930 (owner: 10Ori.livneh) [20:23:57] (03Merged) 10jenkins-bot: Make luasandbox_version.h generation work on OS X [php/luasandbox] - 10https://gerrit.wikimedia.org/r/143930 (owner: 10Ori.livneh) [20:34:37] (03PS1) 10Inchikutty: [WIP] Adds OSM parameter to coordinate template [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/144324 [20:35:39] (03Abandoned) 10Inchikutty: [WIP] Adds OSM parameter to coordinate template [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/141122 (owner: 10Inchikutty) [20:37:45] Dammit hoo [20:37:49] you're slightly too fast :p [20:38:03] heh :D [20:47:10] 3Wikimedia / 3Site requests: Change user groups rights on ckb.wikipedia - 10https://bugzilla.wikimedia.org/67529 (10Dereckson) 5NEW>3UNCO [21:03:36] (03PS1) 10PleaseStand: Only list Special:CreateAccount as restricted if configured so [core] - 10https://gerrit.wikimedia.org/r/144329 (https://bugzilla.wikimedia.org/67549) [21:05:15] (03CR) 10PleaseStand: Only list Create account when permissions allow it (031 comment) [core] - 10https://gerrit.wikimedia.org/r/139392 (https://bugzilla.wikimedia.org/66589) (owner: 10Talktodan) [21:10:10] 3Wikimedia / 3Site requests: Change user groups rights on ckb.wikipedia - 10https://bugzilla.wikimedia.org/67529 (10Calak) 5UNCO>3RESO/FIX [21:19:10] 3MediaWiki / 3General/Unknown: Tracking bug (tracking) - 10https://bugzilla.wikimedia.org/2007 (10merl) [21:30:26] 3MediaWiki extensions / 3FlaggedRevs: "Advertise" does not tell others that I'm reviewing that page; clicking "de-advertise" does not change display - 10https://bugzilla.wikimedia.org/65572#c3 (10Andre Klapper) Karsten: What's your setting for $wgMainCacheType? [21:31:10] 3MediaWiki / 3General/Unknown: Add hook to prohibit HTTP -> HTTPS redirect - 10https://bugzilla.wikimedia.org/65567#c2 (10Andre Klapper) (In reply to Yuri Astrakhan from comment #1) > Two pending patches: > Core: If04c83066c5d4 > Zero: Ia8b620282bb01 Yuri: Both merged. What's left here? [21:32:24] 3Wikimedia / 3General/Unknown: 504 Gateway Time-out when modifying big articles in the Galician wikipedia - 10https://bugzilla.wikimedia.org/57677#c11 (10Andre Klapper) (In reply to elisardopr from comment #7) > I'll try to adapt that changes to gl.wiki, I'll post the result. elisardopr: Status update welco... [21:33:25] 3MediaWiki extensions / 3LiquidThreads: Database returned error "1: RIGHT and FULL OUTER JOINs are not currently supported". - 10https://bugzilla.wikimedia.org/39064#c6 (10Andre Klapper) Helder: Can you answer comment 5, please? [21:34:25] 3MediaWiki / 3Internationalization: no customized messages shown via Special:AllMessages or via the API - 10https://bugzilla.wikimedia.org/64783#c6 (10Andre Klapper) Ricordisamoa / Siebrand: Can you please provide steps to reproduce?: (In reply to Amir E. Aharoni from comment #4) > Where does this happen? C... [21:35:11] 3MediaWiki / 3Database: Database query error on English Wikisource in User::idFromName - 10https://bugzilla.wikimedia.org/64904 (10Andre Klapper) p:5High>3Normal [21:36:10] 3MediaWiki / 3Skin and page rendering: Change style of "Your edit was saved." message - 10https://bugzilla.wikimedia.org/56313#c4 (10Andre Klapper) Myeongjin: Can you answer comment 3, please? [21:42:10] 3MediaWiki extensions / 3FlaggedRevs: "Advertise" does not tell others that I'm reviewing that page; clicking "de-advertise" does not change display - 10https://bugzilla.wikimedia.org/65572#c4 (10Karsten Priegnitz) Hi, it's set to $wgMainCacheType = CACHE_NONE; [21:48:24] 3MediaWiki / 3General/Unknown: Add hook to prohibit HTTP -> HTTPS redirect - 10https://bugzilla.wikimedia.org/65567 (10Yuri Astrakhan) 5NEW>3RESO/FIX [22:06:10] 3MediaWiki extensions / 3FlaggedRevs: "Advertise" does not tell others that I'm reviewing that page; clicking "de-advertise" does not change display - 10https://bugzilla.wikimedia.org/65572#c5 (10Andre Klapper) And does the feature work when setting it to something else than CACHE_NONE, as proposed by bawolf... [22:14:55] (03CR) 10Fomafix: "@MaxSem: The API takes Accept-Encoding into account. Why not Accept-Charset?" [core] - 10https://gerrit.wikimedia.org/r/142052 (owner: 10MaxSem) [22:26:54] 3Wikimedia / 3Site requests: Add autopatrolled group to Spanish Wikisource - 10https://bugzilla.wikimedia.org/67557 (10LadyInGrey) 3NEW p:3Unprio s:3normal a:3None Following the activation of the patrolling feature, we'd like to have the autopatrolled group activated on the Spanish Wikisource as well... [22:37:53] 3Wikimedia / 3Site requests: Change user groups rights on ckb.wikipedia - 10https://bugzilla.wikimedia.org/67529 (10Dereckson) 5RESO/FIX>3RESO/WOR [22:41:56] 3MediaWiki / 3General/Unknown: table editor: sort stable - 10https://bugzilla.wikimedia.org/67558 (10Dave Yost) 3NEW p:3Unprio s:3normal a:3None If you sort a table on column A then sort on column B, the result should be a sort with B as major comparison and A as minor comparison. Instead you get a... [22:43:52] 3MediaWiki / 3General/Unknown: table editor: sort is not stable - 10https://bugzilla.wikimedia.org/67558 (10Dave Yost) [22:45:59] (03PS1) 10Mvolz: Expands shortened URLs, performs naive scrapes [services/citoid] - 10https://gerrit.wikimedia.org/r/144332 [22:50:47] (03PS44) 10Paladox: Update jquery.hoverintent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [22:53:00] (03CR) 10Legoktm: [C: 04-1] Add --attachbroken option to migrateAccount.php (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144257 (https://bugzilla.wikimedia.org/61876) (owner: 10Legoktm) [22:56:19] (03CR) 10Legoktm: [V: 032] Set REL1_23 branch for .gitreview. [extensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/144270 (https://bugzilla.wikimedia.org/67270) (owner: 10MarkAHershberger) [23:05:46] (03Abandoned) 10Legoktm: Syncronize VisualEditor: d04b3bf..840264e [extensions] - 10https://gerrit.wikimedia.org/r/141382 (owner: 10Jenkins-mwext-sync) [23:08:22] (03CR) 10Legoktm: [C: 04-1] "If you're going to do this, you should do it for all the extensions that were created after the REL1_23 branchpoint." [extensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/144271 (https://bugzilla.wikimedia.org/67270) (owner: 10MarkAHershberger) [23:08:35] (03PS4) 10Legoktm: Remove IframePage and ValueView [extensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/144271 (https://bugzilla.wikimedia.org/67270) (owner: 10MarkAHershberger) [23:10:12] (03PS2) 10Legoktm: Add --attachbroken option to migrateAccount.php [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144257 (https://bugzilla.wikimedia.org/61876) [23:10:32] (03CR) 10Legoktm: Add --attachbroken option to migrateAccount.php (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144257 (https://bugzilla.wikimedia.org/61876) (owner: 10Legoktm) [23:11:37] 3Wikimedia / 3Site requests: Attach all broken autocreated local accounts to their global account - 10https://bugzilla.wikimedia.org/61876#c6 (10Kunal Mehta (Legoktm)) (In reply to Kunal Mehta (Legoktm) from comment #5) > legoktm@terbium:~$ cat sul/broken-accounts.tsv | wc -l > 18571 For accounts with a us... [23:12:24] (03CR) 10Hoo man: [C: 032] Add --attachbroken option to migrateAccount.php [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144257 (https://bugzilla.wikimedia.org/61876) (owner: 10Legoktm) [23:12:31] (03Merged) 10jenkins-bot: Add --attachbroken option to migrateAccount.php [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144257 (https://bugzilla.wikimedia.org/61876) (owner: 10Legoktm) [23:12:33] \o/ [23:12:45] legoktm: What do you think of https://gerrit.wikimedia.org/r/144265 ? [23:12:55] Is it ok to pass either the old or new user name? [23:13:03] (see qqq) [23:13:16] both will work, but if we pass the new name it also shows the log entry [23:13:29] legoktm: mg [23:13:31] * mh [23:13:41] so should I do a lookup first? [23:13:56] cause sometimes we don't have the new name offhand [23:14:16] well in the Validator we do right? [23:15:06] oh no wait [23:15:08] I'm wrong [23:15:10] oh right, we do... we just discard the new name [23:15:15] now, you're right :P [23:15:16] so, [23:15:20] -.- [23:15:22] https://gerrit.wikimedia.org/r/144265 [23:15:25] wrong [23:15:36] $caOldUser->renameInProgress() [23:15:45] taht should return array( oldname, newname) [23:16:06] right [23:16:19] I'll amend in a moment [23:16:51] ok [23:18:59] (03PS2) 10Hoo man: Show a link to Special:GlobalRenameProgress if a global rename is in progress [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144265 [23:19:49] (03CR) 10Hoo man: "Always pass the new name to the message" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144265 (owner: 10Hoo man) [23:20:01] * legoktm tests [23:28:31] (03CR) 10Legoktm: [C: 032] Show a link to Special:GlobalRenameProgress if a global rename is in progress [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144265 (owner: 10Hoo man) [23:28:39] (03Merged) 10jenkins-bot: Show a link to Special:GlobalRenameProgress if a global rename is in progress [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/144265 (owner: 10Hoo man) [23:30:23] :) [23:40:25] 3Wikimedia / 3Site requests: Attach all broken autocreated local accounts to their global account - 10https://bugzilla.wikimedia.org/61876 (10Kunal Mehta (Legoktm)) 5PATC>3ASSI a:3Kunal Mehta (Legoktm) [23:55:23] 3MediaWiki / 3Parser: expensive-parserfunction-warning has an off-by-one error - 10https://bugzilla.wikimedia.org/67371#c1 (10Emufarmers) 5NEW>3RESO/INV Evidently it was just an issue with the way he was using template parameters: https://commons.wikimedia.org/w/index.php?title=User:Dispenser/Double_exte...