[00:04:01] awight, in any case, once you connvince everyone that it is safe (that thing does look scarry), and test it out on betalabs, the time is right for depl [00:04:56] * awight puts on most convincing look, with offer-cannot-be-refused sincerity [00:09:15] thanks yurikR and bawolff for surogate me-ness [00:09:16] :) [00:09:43] anytime [00:10:29] lol, <_< >_> /me checks for more doppelgangers [00:12:28] (03CR) 10Yurik: Hideous workaround to customize translate workflow permissions (031 comment) [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/141595 (owner: 10Awight) [00:33:06] (03CR) 10Dduvall: "Yurik, I can't repro your issue with Window 8.1 and Vagrant 1.6.3, even after following the same upgrade path from 1.5.4. I'm not sure the" [vagrant] - 10https://gerrit.wikimedia.org/r/143218 (owner: 10Dduvall) [00:37:31] (03PS5) 10Bsitu: [WIP]Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 [00:40:45] 3Wikimedia / 3General/Unknown: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - 10https://bugzilla.wikimedia.org/66699#c36 (10Kunal Mehta (Legoktm)) I was thinking about this from a different standpoint yesterday. Right now we're logging every time a user logs in with t... [00:44:06] (03CR) 10Mattflaschen: "How is this font developed?" [core] - 10https://gerrit.wikimedia.org/r/137888 (https://bugzilla.wikimedia.org/66138) (owner: 10Prtksxna) [00:44:37] superm401: May is working on using Illustrator and Glyphs [00:44:48] (03PS6) 10Bsitu: [WIP]Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 [00:45:15] superm401: I am trying to figure out a workflow wherein there are SVG files in a folder that get compiled to a TTF and then to EOFF, OTF etc to make contributions easier [00:46:00] prtksxna, okay, would you like to comment on the Gerrit, or should I? [00:46:12] Can you include what the workflow currently is as well (including source files)? [00:46:35] superm401: Sure, I will. I have a call with May in a bit so I'll get more details too. [00:46:46] superm401: I don't know why I replied here in the first place, sorry :\ [00:46:55] prtksxna, no problem. [00:50:21] (03CR) 10Mattflaschen: "Also, we need to clearly decide what the repo is going to be going forward." [core] - 10https://gerrit.wikimedia.org/r/137888 (https://bugzilla.wikimedia.org/66138) (owner: 10Prtksxna) [00:50:51] superm401: Going to be? I don't understand the question [00:51:04] prtksxna, did you look at the whole Gerrit post? [00:52:26] superm401: Oops. Hmmm [00:53:14] superm401: Why is oojs separate? [00:53:44] prtksxna, because it's intended to be used as a third party library as well (OOJS actually doesn't have any GUI code, it's just an object-oriented library) [00:53:46] superm401: So that people can use it separately… [00:54:04] superm401: I see [00:54:10] prtksxna, right, e.g. it's an NPM module: https://www.npmjs.org/package/oojs [00:54:15] Even though that's obviously not how we use it. [00:54:29] We already have a few things maintained by WMF as an "upstream" project on github like jquery.uls, so it's not a huge deal I guess. [00:54:33] Right. I think that'll apply to the icon set too [00:54:34] though gerrit would obviously be preferred [00:55:23] phab Phab PHAB! [00:56:30] 3MediaWiki / 3Parser: Local interwiki links with no page title should point to the main page - 10https://bugzilla.wikimedia.org/64167#c3 (10This, that and the other) Similar but different: * This bug relates only to local interwiki prefixes. * With this bug, local interwiki links with no title are not being... [00:57:02] 3MediaWiki-Vagrant: Custom vagrant commands don't run from subdirs - 10https://bugzilla.wikimedia.org/67445 (10Yuri Astrakhan) 3NEW p:3Unprio s:3major a:3Ori Livneh On Win 8.1 x64, vagrant 1.6.3, after running I748655162214e0 - setup.bat to get all the custom commands. Custom commands such as list-rol... [00:57:07] (03CR) 10Yurik: "This might be related to bug 67445" [vagrant] - 10https://gerrit.wikimedia.org/r/143218 (owner: 10Dduvall) [00:59:12] legoktm, yeah, I agree that's not preferrable, and also ULS is less MediaWiki-specific than WikiFont ("Free & open-source icon font for Wikimedia + Wikipedia") [00:59:49] if that's what the font is supposed to be...why is it in core? [01:01:01] legoktm, the design team sometimes does not fully distinguish between "all MediaWiki sites" and Wikimedia and/or Wikipedia [01:01:24] hm. [01:01:27] legoktm, if you look at the font (https://www.mediawiki.org/wiki/WikiFont) it's pretty clear it's not Wikipedia-specific [01:01:58] legoktm: That would be my fault. I wasn't sure where it should go. [01:02:03] But it's also clear from the name and some of the icon conventions (e.g. https://www.mediawiki.org/wiki/File:SmileSpeechbubble_icon.svg which I've never seen on a non-MediaWiki site) that it's a MediaWiki thing. [01:02:30] * legoktm notes that that page is broken in monobook [01:02:46] ok, so we need to change tag line of the font, but it looks fine for core then [01:03:57] legoktm, yeah, I am fine with putting it in core, but I mentioned the other option since they used lib. [01:05:47] ah, didn't notice that. I think using src would be better. [01:05:54] and making it really part of core [01:11:15] (03CR) 10Jforrester: [C: 032] Align image frame padding with core [core] - 10https://gerrit.wikimedia.org/r/143758 (owner: 10GWicke) [01:12:54] legoktm: OOjs is mastered in gerrit… [01:13:29] Yup, I didn't say that. I mentioned jquery.uls :) [01:13:50] Oh, yes, we should help them transfer to gerrit, I agree. [01:14:38] The only bit of OOjs that's in GitHub is the redirects at http://oojs.github.io in https://github.com/oojs/oojs.github.io [01:14:56] (03Merged) 10jenkins-bot: Align image frame padding with core [core] - 10https://gerrit.wikimedia.org/r/143758 (owner: 10GWicke) [01:19:32] (03PS2) 10Ori.livneh: Update $wgRCFeeds documentation [core] - 10https://gerrit.wikimedia.org/r/143760 (owner: 10Reedy) [01:19:36] (03CR) 10Ori.livneh: [C: 032] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/143760 (owner: 10Reedy) [01:20:45] 3MediaWiki / 3JavaScript: QUnit tests for jquery.makeCollapsible and jquery.color failing on Jenkins - 10https://bugzilla.wikimedia.org/63579#c21 (10Matthew Flaschen) Doesn't look like we have a GettingStarted example yet, so: https://integration.wikimedia.org/ci/job/mwext-GettingStarted-qunit/58/consoleFul... [01:23:15] 3MediaWiki / 3JavaScript: QUnit tests for jquery.makeCollapsible and jquery.color failing intermittently on Jenkins - 10https://bugzilla.wikimedia.org/63579 (10Matthew Flaschen) [01:23:23] superm401: Are we going to stick to using KSS for the living styleguide? [01:23:47] prtksxna, I haven't heard anyone propose anything else recently. [01:23:56] I'm fine with it for now. [01:24:00] (03Merged) 10jenkins-bot: Update $wgRCFeeds documentation [core] - 10https://gerrit.wikimedia.org/r/143760 (owner: 10Reedy) [01:24:19] superm401: Alright. There might be some design changes to it. Could you point me to where the code for it is currently living? [01:25:32] 3MediaWiki / 3General/Unknown: String "display:none" is generally blacklisted and should not be. It must be whitelisteable, at least. - 10https://bugzilla.wikimedia.org/67415#c6 (10Purodha Blissenbach) (In reply to Bartosz Dziewoński from comment #5) > By "Have you verified that this isn't caused by one of y... [01:25:39] https://git.wikimedia.org/tree/mediawiki%2Fcore.git/019682e962289a7b4d69b6b27da1fa1d3688feea/docs%2Fkss and https://git.wikimedia.org/tree/mediawiki%2Fcore.git/019682e962289a7b4d69b6b27da1fa1d3688feea/resources%2Fsrc%2Fmediawiki.ui [01:26:05] prtksxna, the first is the build process, the second is the source code for medaiwiki.ui (comments in there go into the output). [01:27:31] superm401: Thanks! [01:32:35] (03CR) 10Mattflaschen: ""The problem with having this hidden away in BetaFeatures is we are not sharing mediawiki ui components so we will continue this bad patte" [core] - 10https://gerrit.wikimedia.org/r/75143 (owner: 10MarkTraceur) [01:33:33] (03CR) 10Mattflaschen: ""on this being re-invented", I mean." [core] - 10https://gerrit.wikimedia.org/r/75143 (owner: 10MarkTraceur) [01:39:32] 3MediaWiki / 3JavaScript: mw.Title should let you format a title relative to an arbitrary namespace, not assume NS0 - 10https://bugzilla.wikimedia.org/67448 (10James Forrester) 3ASSI p:3Unprio s:3enhanc a:3Alex Monk Right now mw.Title formats namespaces assuming that you want their representation fro... [01:43:09] (03CR) 10Mattflaschen: "Not tested, but looks fine other than the name (could be clarified) one line with trailing whitespace." (032 comments) [phabricator/phabricator] - 10https://gerrit.wikimedia.org/r/143506 (owner: 1020after4) [02:05:30] 3MediaWiki / 3General/Unknown: BagOStuff should behave consistently with regards to integer values - 10https://bugzilla.wikimedia.org/60563#c11 (10Matthew Flaschen) I don't know. I've worked on and tested Redis because MediaWiki-Vagrant uses it. [02:25:21] (03CR) 10Mattflaschen: [C: 04-2] "Thank you for changing it to have a single parent." [core] - 10https://gerrit.wikimedia.org/r/139686 (owner: 10Paladox) [02:27:17] 3Wikimedia / 3Bugzilla: Create component for AccountAudit extension - 10https://bugzilla.wikimedia.org/67449 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Info: https://www.mediawiki.org/wiki/Extension:AccountAudit Default CC: myself, and probably Chris Steipp if he wants? Bug 65875 ca... [02:33:25] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (85cfc2e735) [core] - 10https://gerrit.wikimedia.org/r/143813 [02:34:01] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (85cfc2e735) [core] - 10https://gerrit.wikimedia.org/r/143813 (owner: 10Jforrester) [02:37:03] (03PS1) 10Brian Wolff: Do not include file redirects in Special:Wantedfiles [core] - 10https://gerrit.wikimedia.org/r/143814 [02:38:00] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (85cfc2e735) [core] - 10https://gerrit.wikimedia.org/r/143813 (owner: 10Jforrester) [02:38:33] (03CR) 10Mattflaschen: "Removing myself as a reviewer" [core] - 10https://gerrit.wikimedia.org/r/139470 (owner: 10Paladox) [02:41:08] (03CR) 10jenkins-bot: [V: 04-1] Do not include file redirects in Special:Wantedfiles [core] - 10https://gerrit.wikimedia.org/r/143814 (owner: 10Brian Wolff) [02:47:44] (03CR) 10Legoktm: [C: 031] "LGTM. Siebrand, are the updated i18n messages fine?" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/140746 (https://bugzilla.wikimedia.org/13780) (owner: 10Jackmcbarn) [02:48:45] 3MediaWiki / 3General/Unknown: String "display:none" is generally blacklisted and should not be. It must be whitelisteable, at least. - 10https://bugzilla.wikimedia.org/67415#c7 (10This, that and the other) 5UNCO>3RESO/INV It is almost certainly because this string is present in $wgSpamRegex in the wiki'... [02:52:30] 3MediaWiki / 3Internationalization: Fake links on default system messages shouldn't add entries to Special:WantedFiles and siblings - 10https://bugzilla.wikimedia.org/45152#c7 (10Bawolff (Brian Wolff)) Looking back on this, part of me is tempted to do something along the line of and il_to not like '$_'; in... [02:55:21] (03PS1) 10Chad: Be more explicit that dependent roles are not marked [vagrant] - 10https://gerrit.wikimedia.org/r/143816 (https://bugzilla.wikimedia.org/52263) [03:03:32] 3Analytics / 3EventLogging: database consumer could batch inserts (sometimes) - 10https://bugzilla.wikimedia.org/67450 (10Sean Pringle) 3NEW p:3Unprio s:3normal a:3None The eventlogging database consumer generates single-row inserts. From a performance perspective (master overhead and slave replicati... [03:31:24] (03PS11) 1001tonythomas: Added SwiftMailer Extension to provide an alternate for UserMailer [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 [03:47:30] 3Wikimedia / 3General/Unknown: Bits broken - 10https://bugzilla.wikimedia.org/67420#c4 (10Kunal Mehta (Legoktm)) p:5Unprio>3Normal I experienced this issue just now as well on meta. FF30, using Vector. My urls looked like https://bits.wikimedia.org/meta.wikimedia.org/load.php?debug=false&lang=en&modules... [03:47:45] 3Wikimedia / 3General/Unknown: Bits broken - 10https://bugzilla.wikimedia.org/67420 (10Kunal Mehta (Legoktm)) p:5Normal>3High [03:52:20] (03PS12) 1001tonythomas: Added SwiftMailer Extension to provide an alternate for UserMailer [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 [03:54:48] (03CR) 1001tonythomas: "@Parent5446: Done. Looks good now ?" [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 (owner: 1001tonythomas) [03:56:58] (03CR) 10Mattflaschen: "I added Adam Wight and Mark Traceur, because they work on extensions that use jquery.validate." [core] - 10https://gerrit.wikimedia.org/r/139697 (owner: 10Paladox) [03:57:50] (03CR) 10Legoktm: [C: 04-1] Added Unsubscribe user on multiple email delivery failures (031 comment) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/142786 (owner: 1001tonythomas) [03:58:52] (03PS2) 10Brian Wolff: Do not include file redirects in Special:Wantedfiles [core] - 10https://gerrit.wikimedia.org/r/143814 [04:02:01] (03PS6) 1001tonythomas: Added Unsubscribe user on multiple email delivery failures [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/142786 [04:03:42] (03CR) 10Legoktm: [C: 032] Added Unsubscribe user on multiple email delivery failures [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/142786 (owner: 1001tonythomas) [04:03:48] (03Merged) 10jenkins-bot: Added Unsubscribe user on multiple email delivery failures [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/142786 (owner: 1001tonythomas) [04:31:48] (03CR) 10Legoktm: [C: 04-1] "There's currently a major re-write of the extension going on in a branch, so I'll update this after we merge that at the end of the summer" (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/137216 (owner: 10Legoktm) [04:37:56] (03PS2) 10Brian Wolff: Add Special:MostGloballyLinkedFiles (global version Special:Mostimages) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143755 [04:38:04] (03CR) 10jenkins-bot: [V: 04-1] Add Special:MostGloballyLinkedFiles (global version Special:Mostimages) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143755 (owner: 10Brian Wolff) [04:51:40] (03PS13) 10Prtksxna: Add settings [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140086 [04:51:46] (03CR) 10jenkins-bot: [V: 04-1] Add settings [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140086 (owner: 10Prtksxna) [04:59:27] (03PS1) 10Chad: Move Special:Block-specific CSS to Special:Block CSS file [core] - 10https://gerrit.wikimedia.org/r/143820 [05:00:04] (03PS3) 10Brian Wolff: Add Special:MostGloballyLinkedFiles (global version Special:Mostimages) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143755 [05:00:46] (03CR) 10jenkins-bot: [V: 04-1] Add Special:MostGloballyLinkedFiles (global version Special:Mostimages) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143755 (owner: 10Brian Wolff) [05:03:48] (03PS14) 10Prtksxna: Add settings [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140086 [05:09:29] (03CR) 10Mattflaschen: [C: 04-1] "Can you do this on top of https://gerrit.wikimedia.org/r/#/c/117105/ ? That will give us an incentive to get that merged (it's very close" [core] - 10https://gerrit.wikimedia.org/r/143577 (owner: 10Robmoen) [05:15:43] (03PS1) 10Ori.livneh: Remove dependency on Python 3.2 [vagrant] - 10https://gerrit.wikimedia.org/r/143821 [05:15:45] (03CR) 10jenkins-bot: [V: 04-1] Remove dependency on Python 3.2 [vagrant] - 10https://gerrit.wikimedia.org/r/143821 (owner: 10Ori.livneh) [05:16:40] (03PS2) 10Ori.livneh: Remove dependency on Python 3.2 [vagrant] - 10https://gerrit.wikimedia.org/r/143821 [05:21:56] (03CR) 10Swalling: "What is the advantage of moving to a large number of numeric variations of gray, versus the previous, more descriptive names? It seems kin" [core] - 10https://gerrit.wikimedia.org/r/117105 (owner: 10Kaldari) [05:22:36] (03CR) 10Santhosh: "ping. Do we need this patch?" [services/cxserver] - 10https://gerrit.wikimedia.org/r/127598 (owner: 10Divec) [05:28:45] 3Wikimedia / 3General/Unknown: Bits broken - 10https://bugzilla.wikimedia.org/67420#c5 (10Kunal Mehta (Legoktm)) $ traceroute bits.wikimedia.org traceroute to bits-lb.eqiad.wikimedia.org (208.80.154.234), 64 hops max, 52 byte packets 1 192.168.1.1 (192.168.1.1) 0.882 ms 0.681 ms 0.664 ms 2 adsl-99-19-... [05:41:13] (03PS2) 1020after4: Custom user profile field to display a link to the mediawiki SUL account that is associated with each phabricator account. [phabricator/phabricator] - 10https://gerrit.wikimedia.org/r/143506 [05:43:42] (03PS3) 1020after4: Custom user profile field to display a link to the mediawiki SUL account that is associated with each phabricator account. [phabricator/phabricator] - 10https://gerrit.wikimedia.org/r/143506 [05:51:30] 3MediaWiki extensions / 3WikimediaMessages: Require MediaWiki:Licenses to enable uploads - 10https://bugzilla.wikimedia.org/66960 (10Nemo) [05:54:06] (03PS1) 10Ori.livneh: tidy up confirmedit role [vagrant] - 10https://gerrit.wikimedia.org/r/143824 [06:01:17] 3Wikimedia / 3Site requests: Disable local uploads where unused: some wikis without local file options - 10https://bugzilla.wikimedia.org/67453 (10Nemo) 3NEW p:3Unprio s:3enhanc a:3None Created attachment 15829 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15829&action=edit Status of local u... [06:04:00] 3MediaWiki extensions / 3WikimediaMessages: Require MediaWiki:Licenses to enable uploads - 10https://bugzilla.wikimedia.org/66960#c3 (10Nemo) This will be become live on all Wikipedias today (with 1.24wmf11). [06:12:25] (03PS1) 10Brian Wolff: Fix RepoGroup::hasForeignRepos() and RepoGroup::forEachForeignRepo() [core] - 10https://gerrit.wikimedia.org/r/143826 [06:15:17] (03PS1) 10Ori.livneh: Update MediaWiki-Vagrant for Trusty [vagrant] - 10https://gerrit.wikimedia.org/r/143827 [06:25:54] (03PS4) 10Brian Wolff: Add Special:MostGloballyLinkedFiles (global version Special:Mostimages) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143755 [06:25:54] (03PS1) 10Brian Wolff: Add Special:GloballyWantedFiles [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143828 [06:33:30] (03PS24) 10Paladox: Update jQuery.appear.js [core] - 10https://gerrit.wikimedia.org/r/139470 [06:33:43] (03PS34) 10Paladox: Update jquery.hoverintent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [06:34:26] (03PS15) 10Paladox: Update jquery.mockjax.js to v1.5.3 [core] - 10https://gerrit.wikimedia.org/r/139693 [06:34:50] (03PS11) 10Paladox: Update jquery.form.js [core] - 10https://gerrit.wikimedia.org/r/139688 [06:34:57] (03PS15) 10Paladox: Update jQuery Cookie to v1.4.1 [core] - 10https://gerrit.wikimedia.org/r/139686 [06:36:41] (03PS14) 10Paladox: Update jquery.chosen folder and files [core] - 10https://gerrit.wikimedia.org/r/139699 [06:46:45] 3Wikimedia / 3General/Unknown: Scripts run endlessly unless I stop it - 10https://bugzilla.wikimedia.org/67404#c5 (10ineuw) I am attaching three more images of the script problem, one of which is in the main namespace. When the message appears and "Continue" is clicked, the the browser hangs. If the "Stop sc... [06:47:45] 3Wikimedia / 3General/Unknown: Scripts run endlessly unless I stop it - 10https://bugzilla.wikimedia.org/67404#c6 (10ineuw) Created attachment 15830 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15830&action=edit Script triggered a message [06:48:30] 3Wikimedia / 3General/Unknown: Scripts run endlessly unless I stop it - 10https://bugzilla.wikimedia.org/67404#c7 (10ineuw) Created attachment 15831 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15831&action=edit Script triggered a message 2 [06:48:45] 3Wikimedia / 3General/Unknown: Scripts run endlessly unless I stop it - 10https://bugzilla.wikimedia.org/67404#c8 (10ineuw) Created attachment 15832 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15832&action=edit Script triggered a message 3 [06:49:00] 3Wikimedia / 3General/Unknown: Scripts run endlessly unless I stop it - 10https://bugzilla.wikimedia.org/67404#c9 (10Kunal Mehta (Legoktm)) I think this and bug 67420 are the same. [06:50:45] 3Wikimedia / 3General/Unknown: Bits broken - 10https://bugzilla.wikimedia.org/67420#c6 (10Kunal Mehta (Legoktm)) I ran into this on mediawiki.org, using the MonoBook skin. Bug 67404 says it happens on Modern. I didn't mention it earlier, but I'm using OSX. This is only occurring on non-Wikipedias, leading m... [06:52:25] (03CR) 10Tweichart: [C: 031 V: 031] Added missing method calls on some message objects [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/143615 (owner: 10Smuggli) [06:52:30] 3Wikimedia / 3General/Unknown: Bits broken - 10https://bugzilla.wikimedia.org/67420#c7 (10Jasper Deng) Also affects Wikidata: https://www.wikidata.org/w/index.php?title=Wikidata:Contact_the_development_team&curid=181&diff=142246577&oldid=142190815 [06:54:45] 3MediaWiki extensions / 3Gadgets: Gadgets: Fix failing unit test "GadgetsTest::testPreferences: isset( $options['<gadget-section-keep-section2>'] )" - 10https://bugzilla.wikimedia.org/67060#c4 (10Max Semenik) 5NEW>3RESO/WOR Not reproduceable anymore. [06:55:57] legoktm: around ? [06:56:01] hi [06:57:04] hi, regarding your request for python-mysqldb can you please add the path of the code you execute, and i'll add it to maintenance scripts ? [06:57:13] if you have the code, even better [06:57:22] (public) [06:58:00] matanya: it's https://gist.github.com/legoktm/98a4ea1b217ce9463f7d, but it'll be changing a lot. I'm going to check it into the mediawiki/extensions/AccountAudit repository in a day or two. [06:59:38] ou [06:59:48] legoktm: if i put it in puppet, can you update it there ? [07:00:03] err, I'd rather it not be in puppet [07:00:26] I thought about putting it in a cron job for you [07:00:40] oh, yeah it's not ready for that [07:01:08] ok [07:03:15] 3Wikimedia / 3General/Unknown: Users experiencing "Script not responding" errors on 1.24wmf11 wikis - 10https://bugzilla.wikimedia.org/67420 (10Kunal Mehta (Legoktm)) s:5normal>3major [07:04:30] 3Wikimedia / 3General/Unknown: Scripts run endlessly unless I stop it - 10https://bugzilla.wikimedia.org/67404#c10 (10Kunal Mehta (Legoktm)) 5UNCO>3RESO/DUP ineuw, thanks for the comprehensive report. There's already some more information on bug 67420, so I'm going to dupe this one there. *** This bug h... [07:04:30] 3Wikimedia / 3General/Unknown: Users experiencing "Script not responding" errors on 1.24wmf11 wikis - 10https://bugzilla.wikimedia.org/67420#c8 (10Kunal Mehta (Legoktm)) *** Bug 67404 has been marked as a duplicate of this bug. *** [07:12:01] 3Wikimedia / 3General/Unknown: Users experiencing "Script not responding" errors on 1.24wmf11 wikis - 10https://bugzilla.wikimedia.org/67420#c9 (10rschen7754.wiki) On OS X too, FF 30, and having the same issues. Not on any Wikipedias. [07:19:52] legoktm: does joining accountaudit_login as well make it much slower? [07:20:32] I don't think it will, but I haven't tested it in production yet [07:20:40] (03PS1) 10Divec: Simple GET API to fetch translations [services/cxserver] - 10https://gerrit.wikimedia.org/r/143832 [07:21:44] (03PS2) 10Divec: Simple GET API to fetch translations [services/cxserver] - 10https://gerrit.wikimedia.org/r/143832 [07:21:46] (03PS3) 10Divec: Markup-preserving wrapper for Apertium [services/cxserver] - 10https://gerrit.wikimedia.org/r/143257 [07:22:14] Nemo_bis: But unless it's going to make it like super extremely slow which I doubt, I'd rather use it since it will be more accurate [07:23:18] Sure, and we can always refine if it takes days and/or the numbers look fishy and we have no idea what's going on. :) [07:24:43] yup. I need to figure out what we're going to do about https://bugzilla.wikimedia.org/show_bug.cgi?id=66699#c36 [07:29:55] legoktm: isn't SUL finalisation happening pretty soon? [07:30:06] "soon" [07:30:33] assuming "soon" is "soon", everyone's log in cookie was reset after heartbleed [07:31:19] right. But if we let people login for up to a year, that makes our stats less accurate [07:31:19] so we at least know who has been active after that [07:31:52] you could just make it so that there's a database write every time the user accesses wikipedia for the first time in a given session (and use a session cookie to keep track)... [07:31:58] legoktm: what a sad bug; but it's not going to happen in the next few months, is it [07:32:00] but I'm not sure people would like that, privacy wise [07:32:17] Certainly the script should be run right before that happens to have comparable data [07:32:28] I didn't even know logins were logged, not that it matters much [07:32:45] They're not logged, a timestamp is updated [07:32:52] (03PS3) 10Divec: Simple GET API to fetch translations [services/cxserver] - 10https://gerrit.wikimedia.org/r/143832 [07:33:10] that's logging :P [07:33:21] wctaiwan: I was thinking of doing similar to that, yeah [07:33:31] it should be pretty easy [07:33:32] 3Analytics / 3General/Unknown: Route SSL traffic again into webstatscollector's filter process - 10https://bugzilla.wikimedia.org/67456 (10christian) 3NEW p:3Unprio s:3normal a:3None When emery got decomissioned, erbium around mid-April 2014 had it's udp2log instance turned from a multicast consumer... [07:33:39] If you consider logging something automatically purged to only contain last event [07:33:39] Nemo_bis: I have no clue on the timeline, just didn't want to be caught unprepared [07:33:49] Sure [07:34:32] 3Analytics / 3General/Unknown: Route SSL traffic again into webstatscollector's filter process - 10https://bugzilla.wikimedia.org/67456 (10christian) a:3christian [07:38:24] (03PS1) 10Brian Wolff: Change message on Special:Wantedfiles based on if foreign repo on. [core] - 10https://gerrit.wikimedia.org/r/143834 [07:42:30] 3Analytics / 3Wikimetrics: Story: Community has a comparison of visualization frameworks - 10https://bugzilla.wikimedia.org/67125 (10Kevin Leduc) [07:42:52] (03PS1) 10Brian Wolff: Make Special:Wantedfiles not include foreign false positives. [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143835 (https://bugzilla.wikimedia.org/6220) [07:44:45] 3Analytics / 3Visualization: Story: AnalyticsEng have stack for EEVS dashboard server - 10https://bugzilla.wikimedia.org/67172 (10Kevin Leduc) [07:55:09] Cute, bawolff may fix that bug before it turns ten. [08:01:04] (03CR) 10Nikerabbit: Hideous workaround to customize translate workflow permissions (031 comment) [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/141595 (owner: 10Awight) [08:01:43] (03CR) 10Brian Wolff: [C: 04-1] "It just occured to me that i forgot to override formatRow to make it point at special:globalusage" [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143828 (owner: 10Brian Wolff) [08:02:38] (03CR) 10Nikerabbit: Hideous workaround to customize translate workflow permissions (031 comment) [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/141595 (owner: 10Awight) [08:03:30] 3Analytics / 3Visualization: Story: AnalyticsEng have stack for EEVS dashboard server - 10https://bugzilla.wikimedia.org/67172 (10Kevin Leduc) [08:03:30] 3Wikimedia / 3General/Unknown: Users experiencing "Script not responding" errors on 1.24wmf11 wikis - 10https://bugzilla.wikimedia.org/67420#c10 (10Greg Grossmeier) Reedy: This is potentially a blocker for Wikipedias deploy today. I'll let you decide on course of action since I'll be out. [08:05:04] 3Analytics / 3Wikimetrics: Story:a WikimetricsUser runs 'Rolling Monthly Active Editors' report - 10https://bugzilla.wikimedia.org/67458 (10Kevin Leduc) 3NEW p:3Unprio s:3enhanc a:3None https://meta.wikimedia.org/wiki/Research:Rolling_active_editor [08:05:16] 3Analytics / 3Wikimetrics: Story:a WikimetricsUser runs 'Rolling Monthly Active Editors' report - 10https://bugzilla.wikimedia.org/67458 (10Kevin Leduc) [08:05:30] 3Analytics / 3Wikimetrics: Story:a WikimetricsUser runs 'Rolling Monthly Active Editors' report - 10https://bugzilla.wikimedia.org/67458 (10Kevin Leduc) p:5Unprio>3Highes [08:05:47] 3Analytics / 3Wikimetrics: Story:b WikimetricsUser runs 'Rolling New Active Editors' report - 10https://bugzilla.wikimedia.org/67459 (10Kevin Leduc) 3NEW p:3Unprio s:3enhanc a:3None https://meta.wikimedia.org/wiki/Research:Rolling_new_active_editor [08:06:00] 3Analytics / 3Wikimetrics: Story:b WikimetricsUser runs 'Rolling New Active Editors' report - 10https://bugzilla.wikimedia.org/67459 (10Kevin Leduc) p:5Unprio>3Highes [08:06:47] 3Analytics / 3Wikimetrics: Story:c WikimetricsUser runs 'Rolling Surviving New Active Editors' report - 10https://bugzilla.wikimedia.org/67460 (10Kevin Leduc) 3NEW p:3Unprio s:3enhanc a:3None https://meta.wikimedia.org/wiki/Research:Rolling_surviving_new_active_editor [08:07:15] 3Analytics / 3Wikimetrics: Story:c WikimetricsUser runs 'Rolling Surviving New Active Editors' report - 10https://bugzilla.wikimedia.org/67460 (10Kevin Leduc) p:5Unprio>3Highes [08:15:09] (03CR) 10Florianschmidtwelzow: [C: 032] Add feature to restrict E-Maildomains [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142741 (https://bugzilla.wikimedia.org/67220) (owner: 10Florianschmidtwelzow) [08:15:22] (03Merged) 10jenkins-bot: Add feature to restrict E-Maildomains [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142741 (https://bugzilla.wikimedia.org/67220) (owner: 10Florianschmidtwelzow) [08:17:45] (03CR) 10Florianschmidtwelzow: [C: 032] Add returnto redirect [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/143633 (https://bugzilla.wikimedia.org/67413) (owner: 10Florianschmidtwelzow) [08:17:52] (03Merged) 10jenkins-bot: Add returnto redirect [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/143633 (https://bugzilla.wikimedia.org/67413) (owner: 10Florianschmidtwelzow) [08:19:32] 3Analytics / 3Wikimetrics: Story: WikimetricsUser shares a cohort - 10https://bugzilla.wikimedia.org/67461 (10Kevin Leduc) 3NEW p:3Unprio s:3normal a:3None - user enters username of person to share with and clicks "share" button - user has disclaimer against sharing cohorts across countries (TBD by g... [08:20:00] 3Analytics / 3Wikimetrics: Story: WikimetricsUser shares a cohort - 10https://bugzilla.wikimedia.org/67461 (10Kevin Leduc) p:5Unprio>3Normal s:5normal>3enhanc [08:20:25] (03CR) 10Florianschmidtwelzow: [C: 032] Remove German special page aliases [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/143639 (owner: 10Nikerabbit) [08:20:30] (03Merged) 10jenkins-bot: Remove German special page aliases [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/143639 (owner: 10Nikerabbit) [08:22:03] (03CR) 10Florianschmidtwelzow: [C: 04-2] "Reconsider unit tests after main code is in own class (out of SpecialPage)" [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/143623 (owner: 10Florianschmidtwelzow) [08:25:46] 3Analytics / 3General/Unknown: page view statistics for Wikinews seem to be wrong - 10https://bugzilla.wikimedia.org/67411#c7 (10christian) While the page has some properties that would allow to explain away some effects we're seeing, it turned out that since mid-April, SSL logs were no longer fed into webst... [08:25:46] 3Analytics / 3General/Unknown: Route SSL traffic again into webstatscollector's filter process - 10https://bugzilla.wikimedia.org/67456 (10christian) [08:35:00] 3MediaWiki extensions / 3GoogleLogin: Allow to restrict access to special E-Maildomains - 10https://bugzilla.wikimedia.org/67220 (10Florian) 5PATC>3RESO/FIX [08:35:15] 3MediaWiki extensions / 3GoogleLogin: Use returnto as redirect location after Login - 10https://bugzilla.wikimedia.org/67413 (10Florian) 5PATC>3RESO/FIX [08:43:14] (03CR) 10Nikerabbit: Add returnto redirect (035 comments) [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/143633 (https://bugzilla.wikimedia.org/67413) (owner: 10Florianschmidtwelzow) [08:44:45] 3MediaWiki extensions / 3GoogleLogin: Move main logic out of SpecialPage - 10https://bugzilla.wikimedia.org/67219 (10Florian) [08:44:46] 3MediaWiki extensions / 3GoogleLogin: Use returnto as redirect location after Login - 10https://bugzilla.wikimedia.org/67413 (10Florian) [08:44:46] 3MediaWiki extensions / 3GoogleLogin: Enable "keep login" in GoogleLogin Settings - 10https://bugzilla.wikimedia.org/67136 (10Florian) [08:44:47] 3MediaWiki extensions / 3GoogleLogin: Use returnto as redirect location after Create account - 10https://bugzilla.wikimedia.org/67462 (10Florian) 3NEW p:3Unprio s:3enhanc a:3None +++ This bug was initially created as a clone of Bug #67413 +++ For now, after the creation of account the user have a su... [08:45:15] 3MediaWiki extensions / 3GoogleLogin: Use returnto as redirect location after Create account - 10https://bugzilla.wikimedia.org/67462 (10Florian) p:5Unprio>3Normal [08:47:02] 3Analytics / 3EventLogging: UniversalLanguageSelector-tofu logging too much data - 10https://bugzilla.wikimedia.org/67463 (10christian) 3NEW p:3Unprio s:3normal a:3nuria On 2014-06-25, there was throughput alarm for EventLogging [1]. Nuria starting investigating and it turned out to be caused by Uni... [08:47:16] 3Analytics / 3EventLogging: UniversalLanguageSelector-tofu logging too much data - 10https://bugzilla.wikimedia.org/67463 (10christian) [08:52:39] (03PS1) 10Robert Vogel: Added .gitreview [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/143841 [08:54:17] (03CR) 10Robert Vogel: [C: 032 V: 032] Added .gitreview [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/143841 (owner: 10Robert Vogel) [09:02:17] (03PS1) 10Robert Vogel: Fixes for new skin [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/143842 [09:02:19] (03PS1) 10Hashar: beta: create cawiki and eswiki [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/143843 [09:03:45] (03CR) 10Swidmann: [C: 031 V: 031] Added missing method calls on some message objects [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/143615 (owner: 10Smuggli) [09:03:59] (03PS1) 10Mglaser: Updated to MediaWiki 1.23.0 [packages/WPI] - 10https://gerrit.wikimedia.org/r/143844 [09:05:37] (03CR) 10Swidmann: Initial commit of AdvancedMeta version 3.0.1 removed all $_POST, removed preg replace for extending the editform, removed a few globals (033 comments) [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/142502 (owner: 10Swidmann) [09:07:17] 3MediaWiki / 3Parser: || inside links in tables are stripped unexpectedly - 10https://bugzilla.wikimedia.org/67464 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Wikitext: {| |- | [[File:Wiki.png|border||48px]] |} Actual:
3Wikimedia / 3Wikidata: Investigate if there are already claims for properties on wikidata.org - 10https://bugzilla.wikimedia.org/63072 (10Lydia Pintscher) 5RESO/FIX>3REOP [09:09:45] 3Wikimedia / 3Wikidata: Investigate if there are already claims for properties on wikidata.org - 10https://bugzilla.wikimedia.org/63072 (10Lydia Pintscher) 5REOP>3RESO/FIX [09:10:16] 3MediaWiki extensions / 3WikidataRepo: Creating items broken on beta wikidata - 10https://bugzilla.wikimedia.org/67361 (10Adrian Lang) 5PATC>3RESO/FIX [09:12:06] (03CR) 10Hashar: [C: 032] "Updated and manually triggered." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/143843 (owner: 10Hashar) [09:13:19] (03Merged) 10jenkins-bot: beta: create cawiki and eswiki [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/143843 (owner: 10Hashar) [09:16:02] 3MediaWiki extensions / 3CirrusSearch: Missing index warning not catched forceSearchIndex.php - 10https://bugzilla.wikimedia.org/67465 (10Antoine "hashar" Musso) 3NEW p:3Unprio s:3normal a:3None On beta cluster, I have added the cawiki and eswiki new wiki. I followed the instruction at https://wikite... [09:16:31] http://www.wpiw.net/ , seriously? [09:22:32] 3MediaWiki extensions / 3Popups: Hovercards: Use a link interpreter instead of title attribute - 10https://bugzilla.wikimedia.org/67466 (10Derk-Jan Hartman) 3NEW p:3Unprio s:3normal a:3None Currently Hovercards just takes the title attribute and uses that value as the article that it wants to preview... [09:25:15] (03PS1) 10Robert Vogel: Added .gitreview file [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/143847 [09:26:00] 3MediaWiki extensions / 3CirrusSearch: Missing index warning not catched forceSearchIndex.php - 10https://bugzilla.wikimedia.org/67465#c1 (10Antoine "hashar" Musso) I blow up / created the indices with: mwscript extensions/CirrusSearch/maintenance/updateOneSearchIndexConfig.php --wiki eswiki --startOver --i... [09:26:37] (03CR) 10Smuggli: [C: 032 V: 032] "Looks good to me" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/143842 (owner: 10Robert Vogel) [09:27:41] (03PS1) 10Robert Vogel: Added .gitreview file [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/143848 [09:29:00] (03CR) 10Awight: "I'm much more concerned with the extreme monkeypatching I've done than with the regex. Can we talk about enhancements to Extension:Transl" [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/141595 (owner: 10Awight) [09:30:47] (03CR) 10Hashar: [C: 032 V: 032] "I should migrate that repo somewhere else. Maybe directly to integration/docroot.git" [integration/doc] - 10https://gerrit.wikimedia.org/r/143642 (owner: 10Krinkle) [09:34:00] 3MediaWiki / 3Skin and page rendering: Auto-sign checkbox - 10https://bugzilla.wikimedia.org/19110#c7 (10PRO) I've made such JS extension, it can be installed as JS gadget (but the description is currently only German): https://de.wikipedia.org/wiki/Benutzer:Perhelion/signing [09:34:15] 3MediaWiki extensions / 3Extensions requests: New extension to automatically sign talk pages, or warn that the user has not signed - 10https://bugzilla.wikimedia.org/23037#c6 (10PRO) I've made such JS extension, it can be installed as JS gadget (but the description is currently only German): https://de.wikip... [09:42:15] 3MediaWiki extensions / 3WikidataRepo: cannot reorder snaks within a reference - 10https://bugzilla.wikimedia.org/65695 (10Aude) 5PATC>3RESO/FIX [09:43:24] (03CR) 10Santhosh: Simple GET API to fetch translations (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/143832 (owner: 10Divec) [09:49:30] 3MediaWiki / 3Search: Prune unneeded redirects from the autosuggest dropdown - 10https://bugzilla.wikimedia.org/18181 (10Bartosz Dziewoński) [09:52:45] 3MediaWiki / 3Page deletion: Add option when deleting to delete all subpages and option to delete all redirects - 10https://bugzilla.wikimedia.org/30893 (10Bartosz Dziewoński) [09:52:45] 3MediaWiki / 3Page deletion: add possibility to delete redirects when deleting a page - 10https://bugzilla.wikimedia.org/19485 (10Bartosz Dziewoński) [09:59:30] 3MediaWiki / 3Redirects: Use a HTTP 301/302 status code for redirects - 10https://bugzilla.wikimedia.org/18883 (10Bartosz Dziewoński) [10:01:16] 3MediaWiki extensions / 3WikidataRepo: Wikidata: CTRL+click and middle click on search suggestions doesn't open the page in a new tab - 10https://bugzilla.wikimedia.org/57709 (10Lydia Pintscher) [10:06:00] 3MediaWiki / 3Redirects: Use a HTTP 301/302 status code for redirects - 10https://bugzilla.wikimedia.org/18883#c21 (10Bartosz Dziewoński) (While this is a completely different solution from technical point of view, what is proposed as bug 35045 should provide most of the feature of "real" redirects without a... [10:06:00] 3MediaWiki / 3Redirects: Use history.replaceState to rewrite redirect urls - 10https://bugzilla.wikimedia.org/35045 (10Bartosz Dziewoński) [10:06:46] 3MediaWiki / 3JavaScript: redirectToFragment should try to avoid creating a double history entry on fragment redirects - 10https://bugzilla.wikimedia.org/39328 (10Bartosz Dziewoński) [10:06:47] 3MediaWiki / 3General/Unknown: allow defining a redirect page so it won't appear in search suggestions - 10https://bugzilla.wikimedia.org/30476 (10Bartosz Dziewoński) [10:06:47] 3MediaWiki / 3Redirects: When redirecting to a section, set the page name in the URL correctly - 10https://bugzilla.wikimedia.org/48028 (10Bartosz Dziewoński) [10:06:47] 3MediaWiki / 3Redirects: Use history.replaceState to rewrite redirect urls - 10https://bugzilla.wikimedia.org/35045 (10Bartosz Dziewoński) [10:07:15] 3MediaWiki / 3Redirects: Use history.replaceState to rewrite redirect urls - 10https://bugzilla.wikimedia.org/35045 (10Bartosz Dziewoński) [10:07:15] 3MediaWiki / 3JavaScript: redirectToFragment should try to avoid creating a double history entry on fragment redirects - 10https://bugzilla.wikimedia.org/39328 (10Bartosz Dziewoński) [10:08:30] 3MediaWiki / 3Redirects: Use history.replaceState to rewrite redirect urls - 10https://bugzilla.wikimedia.org/35045 (10Bartosz Dziewoński) [10:08:31] 3MediaWiki / 3JavaScript: redirectToFragment should try to avoid creating a double history entry on fragment redirects - 10https://bugzilla.wikimedia.org/39328 (10Bartosz Dziewoński) [10:08:45] 3MediaWiki / 3Redirects: Use history.replaceState to rewrite redirect urls - 10https://bugzilla.wikimedia.org/35045 (10Bartosz Dziewoński) [10:12:17] 3MediaWiki / 3Redirects: Use history.replaceState to rewrite redirect urls - 10https://bugzilla.wikimedia.org/35045#c1 (10Bartosz Dziewoński) a:3Bartosz Dziewoński Well, it's about time we did this already. [10:28:17] 3Analytics / 3EventLogging: Implement throttling strategy for events that have a too high of a throughput. - 10https://bugzilla.wikimedia.org/67470 (10nuria) 3NEW p:3Unprio s:3normal a:3None Implement throttling strategy for events that have a too high of a throughput. In the last quarter we have ha... [10:29:31] (03PS1) 10Bartosz Dziewoński: On redirect, actually rewrite page URL to the target one with JavaScript [core] - 10https://gerrit.wikimedia.org/r/143852 (https://bugzilla.wikimedia.org/35045) [10:32:26] (03CR) 10Bartosz Dziewoński: [C: 032] Move Special:Block-specific CSS to Special:Block CSS file [core] - 10https://gerrit.wikimedia.org/r/143820 (owner: 10Chad) [10:34:26] https://gerrit.wikimedia.org/r/143852 fixes four different bugs! [10:35:35] (03Merged) 10jenkins-bot: Move Special:Block-specific CSS to Special:Block CSS file [core] - 10https://gerrit.wikimedia.org/r/143820 (owner: 10Chad) [10:37:46] 3MediaWiki / 3API: User contributions feed should match index.php feed format (diff etc.) - 10https://bugzilla.wikimedia.org/41085 (10Rohan Rawat) a:3Rohan Rawat [10:39:19] (03CR) 10Smuggli: [C: 032 V: 032] Added .gitreview file [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/143848 (owner: 10Robert Vogel) [10:39:48] (03CR) 10Smuggli: [C: 032 V: 032] Added .gitreview file [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/143847 (owner: 10Robert Vogel) [10:42:47] 3Analytics / 3Wikistats: Page content metrics missing for hewiki - 10https://bugzilla.wikimedia.org/67472 (10Erik Zachte) 3NEW p:3Unprio s:3minor a:3None Asaf Bartov: why is Hebrew Wikipedia without figures in http://stats.wikimedia.org/EN/TablesArticlesBytesPerArticle.htm ? (I do know Hebrew is a tw... [10:44:15] 3Analytics / 3Wikistats: Page content metrics missing for hewiki - 10https://bugzilla.wikimedia.org/67472#c1 (10Erik Zachte) 5NEW>3RESO/FIX All hewiki metrics where page content is involved, and hence full archive dump is needed, (links, avg page size, word count) suffered the same fate. Which indicates... [10:50:16] 3MediaWiki extensions / 3ExtensionDistributor: Empty version dropdown - 10https://bugzilla.wikimedia.org/65852#c6 (10Florian) Hmm, now i have now list of versions, too, on some Extensions :/ [10:53:03] 3MediaWiki extensions / 3WikidataRepo: Argument 1 passed to Wikibase\EntityContent::getParserOutput() must be an instance of Title - 10https://bugzilla.wikimedia.org/67473 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs I get a fatal error when running tests with SpamBlacklist enabled. I think th... [10:58:18] 3MediaWiki extensions / 3WikidataRepo: PHP Fatal error: Call to a member function isRedirect() on a non-object - 10https://bugzilla.wikimedia.org/67474 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs when running tests in non-experimental mode.... PHP Fatal error: Call to a member function isRe... [11:06:47] 3Analytics / 3Refinery: Story: Admin has versioned and sync'ed files in HDFS - 10https://bugzilla.wikimedia.org/67129 (10christian) a:5christian>3None [11:09:44] (03PS1) 10Robert Vogel: Fixed autoloader issue with Common Ajax Interface [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/143856 [11:17:41] (03CR) 10Robert Vogel: [C: 032 V: 032] Fixed autoloader issue with Common Ajax Interface [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/143856 (owner: 10Robert Vogel) [11:24:31] 3MediaWiki extensions / 3WikidataRepo: Creating items broken on beta wikidata - 10https://bugzilla.wikimedia.org/67361 (10Lydia Pintscher) [11:25:00] 3MediaWiki extensions / 3WikidataRepo: Adding site links is broken - 10https://bugzilla.wikimedia.org/67244 (10Lydia Pintscher) [11:25:01] 3MediaWiki extensions / 3WikidataRepo: Adding site links is broken - 10https://bugzilla.wikimedia.org/67244 (10Aude) 5PATC>3RESO/FIX [11:25:31] 3Wikimedia / 3General/Unknown: Users experiencing "Script not responding" errors on 1.24wmf11 wikis - 10https://bugzilla.wikimedia.org/67420#c11 (10Andre Klapper) p:5High>3Highes I also experienced this exactly once now on Commons on a File: page, Firefox 30 on Fedora 20, Vector skin, being logged in. [11:25:31] 3Wikimedia / 3General/Unknown: Next wmf deployment (tracking) - 10https://bugzilla.wikimedia.org/38865 (10Andre Klapper) [11:26:00] 3MediaWiki extensions / 3WikidataRepo: Move JS serialization code into its own component - 10https://bugzilla.wikimedia.org/66420 (10Adrian Lang) 5PATC>3RESO/FIX [11:28:15] 3MediaWiki extensions / 3WikidataRepo: Snak type selection (e.g. novalue) sticks when canceling - 10https://bugzilla.wikimedia.org/67294 (10Lydia Pintscher) [11:28:30] 3MediaWiki extensions / 3WikidataRepo: Snak type selection (e.g. novalue) sticks when canceling - 10https://bugzilla.wikimedia.org/67294 (10Lydia Pintscher) 5PATC>3RESO/FIX [11:32:00] 3MediaWiki / 3General/Unknown: Deal with logging query spam on crawler 404 floods - 10https://bugzilla.wikimedia.org/67439 (10Andre Klapper) p:5Unprio>3Normal [11:33:30] 3MediaWiki / 3Installer: Running installer on existing wiki can fail when extensions are enabled - 10https://bugzilla.wikimedia.org/67440 (10Andre Klapper) p:5Unprio>3Normal [11:34:21] (03CR) 10Robert Vogel: [C: 032 V: 032] Added missing method calls on some message objects [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/143615 (owner: 10Smuggli) [11:36:56] (03CR) 10Gilles: [C: 032] Make SVG files show "In other resolutions" at all sizes [core] - 10https://gerrit.wikimedia.org/r/134855 (https://bugzilla.wikimedia.org/6834) (owner: 10Brian Wolff) [11:39:30] 3Wikimedia / 3General/Unknown: Users experiencing "Script not responding" errors on 1.24wmf11 wikis - 10https://bugzilla.wikimedia.org/67420#c12 (10Florian) Had this several times in last days on mw.org, but only on FF 17 behind a company proxy, so i thought it wasn't a problem with MediaWiki/Wikimedia. Unha... [11:39:45] 3MediaWiki / 3Parser: || inside links in tables are stripped unexpectedly - 10https://bugzilla.wikimedia.org/67464 (10Andre Klapper) p:5Unprio>3Normal [11:40:25] (03Merged) 10jenkins-bot: Make SVG files show "In other resolutions" at all sizes [core] - 10https://gerrit.wikimedia.org/r/134855 (https://bugzilla.wikimedia.org/6834) (owner: 10Brian Wolff) [11:45:31] 3MediaWiki / 3JavaScript: mw.Title should let you format a title relative to an arbitrary namespace, not assume NS0 - 10https://bugzilla.wikimedia.org/67448 (10Andre Klapper) p:5Unprio>3Normal [11:49:20] (03CR) 10Gilles: [C: 032] Have text for play link so it can be clicked by non-css browsers. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/110310 (owner: 10Brian Wolff) [11:49:30] (03Merged) 10jenkins-bot: Have text for play link so it can be clicked by non-css browsers. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/110310 (owner: 10Brian Wolff) [11:55:17] (03CR) 10Hashar: "check experimental" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/143591 (owner: 10Hashar) [11:55:29] (03CR) 10Gilles: [C: 04-1] "I know that my comments are about code that was simply moved around, but it doesn't hurt to clean it up a little bit." (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/140870 (owner: 10Brian Wolff) [12:00:06] (03CR) 10Gilles: [C: 04-1] "Feel free to +2 once the tiny doc issue has been fixed" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/141765 (https://bugzilla.wikimedia.org/66036) (owner: 10Brian Wolff) [12:09:30] 3Wikimedia / 3General/Unknown: Users experiencing "Script not responding" errors on 1.24wmf11 wikis - 10https://bugzilla.wikimedia.org/67420#c13 (10Bartosz Dziewoński) Similar issues in the past: https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=ALL%20%22Unresponsive%20script%22 [12:26:30] 3Wikimedia / 3General/Unknown: Users experiencing "Script not responding" errors on 1.24wmf11 wikis - 10https://bugzilla.wikimedia.org/67420#c14 (10Bartosz Dziewoński) With no solid evidence to back this up, I have a hunch that the immediate cause is cde08292 "Add json2.js polyfill (v2014-02-04; with module... [12:38:00] 3MediaWiki / 3Search: Request topic title substring search - 10https://bugzilla.wikimedia.org/12577#c1 (10Andre Klapper) Martin: In CirrusSearch, there is an "intitle" parameter now (which does not perfectly work yet, see bug 66969). CirrusSearch is about to replace the default Search, see http://lists.wiki... [12:42:30] 3MediaWiki / 3Parser: Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save) - 10https://bugzilla.wikimedia.org/57026#c40 (10Andre Klapper) All six patches mentioned in this bug report have been merged... [12:44:45] 3MediaWiki / 3JavaScript: gadget incompatibility: CharInsert / wikEd caused by insertTags() in mediawiki.action.edit.js - 10https://bugzilla.wikimedia.org/67412#c2 (10Cacycle) Hi Krinkle, thanks for your quick and detailed response. I am actually already overloading the "insertTags" function whenever wikEd... [12:45:21] (03PS1) 10Krinkle: travis: Disable e-mail notifications [core] - 10https://gerrit.wikimedia.org/r/143866 [12:45:35] (03CR) 10Krinkle: [C: 032] travis: Disable e-mail notifications [core] - 10https://gerrit.wikimedia.org/r/143866 (owner: 10Krinkle) [12:46:01] 3MediaWiki / 3History/Diffs: Interface support to mark bot edits in histories - 10https://bugzilla.wikimedia.org/13516#c1 (10Andre Klapper) I'm tempted to mark this as a duplicate of bug 16228, though it's not exactly the same. Or I fail to see the exact difference to bug 11181. [12:46:01] 3MediaWiki / 3History/Diffs: filter history of edits on bots (hidebots=1) - 10https://bugzilla.wikimedia.org/16228 (10Andre Klapper) [12:47:10] (03PS35) 10Paladox: Update jquery.hoverintent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [12:49:28] Krinkle|detached: you there? RL skip functions support may or may not be causing "Unresponsive script" errors. https://bugzilla.wikimedia.org/show_bug.cgi?id=67420#c14 [12:49:52] (03Merged) 10jenkins-bot: travis: Disable e-mail notifications [core] - 10https://gerrit.wikimedia.org/r/143866 (owner: 10Krinkle) [12:51:30] 3MediaWiki extensions / 3CentralNotice: Make CentralNotice banner-hiding cookie work cross-site - 10https://bugzilla.wikimedia.org/16821 (10Andre Klapper) 5PATC>3NEW [12:55:46] 3MediaWiki extensions / 3WikidataRepo: Wikidata: CTRL+click and middle click on search suggestions doesn't open the page in a new tab - 10https://bugzilla.wikimedia.org/57709#c4 (10Helder) How can this be any more difficult than fixing bug 43373 [1] or even bug 56905 [2]? This feature already works by defau... [12:58:37] (03CR) 10Nikerabbit: "getMessageGroupStates is only implemented twice. Should be easy to add hook there." [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/141595 (owner: 10Awight) [12:58:45] 3MediaWiki extensions / 3WikidataRepo: Wikidata: CTRL+click and middle click on search suggestions doesn't open the page in a new tab - 10https://bugzilla.wikimedia.org/57709#c5 (10Bartosz Dziewoński) Wikidata apparently reimplements the feature from scratch, so the fix would also have to be reimplemented fr... [13:01:02] (03CR) 10Krinkle: "This seems like a straight update. I'll run some tests soon to ensure it is compatible with existing deployed code but looks good on first" [core] - 10https://gerrit.wikimedia.org/r/139687 (owner: 10Paladox) [13:03:17] (03CR) 10Krinkle: "@Bartosz: "to hell" with it might fly if it was proven to affect master for the sake of fixing master. But it isn't. Until proven otherwis" [core] - 10https://gerrit.wikimedia.org/r/143481 (https://bugzilla.wikimedia.org/63579) (owner: 10Mattflaschen) [13:04:30] 3Wikimedia / 3Site requests: Server-side upload of large number of files to Commons - 10https://bugzilla.wikimedia.org/48205 (10Lokal_Profil) [13:08:25] (03PS36) 10Paladox: Update jquery.hoverintent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [13:09:15] 3MediaWiki / 3JavaScript: QUnit tests for jquery.makeCollapsible and jquery.color failing intermittently on Jenkins - 10https://bugzilla.wikimedia.org/63579#c22 (10Krinkle) Turning the tests from sync to async in core is the functional equivalent of removing the assertion "test framework works as expected".... [13:11:03] (03CR) 10Gilles: Fix RepoGroup::hasForeignRepos() and RepoGroup::forEachForeignRepo() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143826 (owner: 10Brian Wolff) [13:19:01] (03CR) 10Gilles: [C: 031] "Code looks sane, but I'm completely unfamiliar with those tables, so not in a good place to review the query's correctness." [core] - 10https://gerrit.wikimedia.org/r/143814 (owner: 10Brian Wolff) [13:25:16] 3MediaWiki / 3Redirects: When redirecting to a section, set the page name in the URL correctly - 10https://bugzilla.wikimedia.org/48028#c12 (10Krinkle) 5PATC>3RESO/DUP *** This bug has been marked as a duplicate of bug 35045 *** [13:25:35] 3MediaWiki / 3Redirects: Use history.replaceState to rewrite redirect urls - 10https://bugzilla.wikimedia.org/35045#c3 (10Krinkle) *** Bug 48028 has been marked as a duplicate of this bug. *** [13:25:39] (03PS2) 10Krinkle: On redirect, actually update URL to the target page with JavaScript [core] - 10https://gerrit.wikimedia.org/r/143852 (https://bugzilla.wikimedia.org/35045) (owner: 10Bartosz Dziewoński) [13:27:11] (03CR) 10Paladox: "Ok sorry." [core] - 10https://gerrit.wikimedia.org/r/139687 (owner: 10Paladox) [13:27:48] (03CR) 10Paladox: [C: 031] "Nether mind wrong comment." [core] - 10https://gerrit.wikimedia.org/r/139687 (owner: 10Paladox) [13:30:38] (03CR) 10Daniel Kinzler: [C: 032] Always return true in OutputPageParserOutput hook handler [extensions/CustomData] - 10https://gerrit.wikimedia.org/r/143628 (https://bugzilla.wikimedia.org/67417) (owner: 10Aude) [13:30:44] (03Merged) 10jenkins-bot: Always return true in OutputPageParserOutput hook handler [extensions/CustomData] - 10https://gerrit.wikimedia.org/r/143628 (https://bugzilla.wikimedia.org/67417) (owner: 10Aude) [13:33:56] (03CR) 10Krinkle: [C: 04-1] "The code is fine, but I'd like to know explicitly why we don't just enable this by default server-side. If we're enabling it here, we are " [core] - 10https://gerrit.wikimedia.org/r/142052 (owner: 10MaxSem) [13:34:46] 3Wikimedia / 3Site requests: 300GB of files on a hard disk in need of a URI or WMF direct upload - 10https://bugzilla.wikimedia.org/67477 (10jeremyb) [13:38:00] 3MediaWiki extensions / 3WikidataRepo: placemarkers in toc and "other languages" term box - 10https://bugzilla.wikimedia.org/67417 (10Aude) 5PATC>3RESO/FIX [13:40:08] (03CR) 10Krinkle: "fixme/explainme: Anomie said "Yeah, it looks like the API can't use XMLMETA_OK thanks to that brain-damaged browser's content type guessin" [core] - 10https://gerrit.wikimedia.org/r/50140 (https://bugzilla.wikimedia.org/26818) (owner: 10PleaseStand) [13:45:14] (03CR) 10Krinkle: "Nice work." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/138652 (https://bugzilla.wikimedia.org/66440) (owner: 10Bartosz Dziewoński) [13:45:51] ed [13:45:55] (03CR) 10Krinkle: [C: 04-1] "Be sure to add release notes as well." [core] - 10https://gerrit.wikimedia.org/r/138652 (https://bugzilla.wikimedia.org/66440) (owner: 10Bartosz Dziewoński) [13:45:58] grr. stupid window focus [13:58:05] (03CR) 10Krinkle: [C: 04-1] "The message links both to "morr"'s fork and "bas2k"'s fork." [core] - 10https://gerrit.wikimedia.org/r/139470 (owner: 10Paladox) [13:58:32] 3MediaWiki / 3General/Unknown: Extensions missing REL1_23 branches - 10https://bugzilla.wikimedia.org/67270#c15 (10Mark A. Hershberger) (In reply to Greg Grossmeier from comment #11) > Is there a reason we didn't make the REL1_23 branch for these > remaining extensions at the same point in time as the 1.23 r... [14:06:45] 3MediaWiki / 3Parser: Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save) - 10https://bugzilla.wikimedia.org/57026#c41 (10Brad Jorsch) 5PATC>3NEW (In reply to Andre Klapper from comment #40) > A... [14:08:52] (03Abandoned) 10Matthias Mullie: Fix 'Undefined index: topicTitle' in no-js *-topic-summary actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143619 (owner: 10Matthias Mullie) [14:11:44] (03PS5) 10Matthias Mullie: Error handling for open/close topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143314 [14:13:21] (03PS6) 10Matthias Mullie: Error handling for moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143315 [14:14:31] 3MediaWiki extensions / 3Renameuser: Suppress redirects when moving *.js and *.css pages during a user rename - 10https://bugzilla.wikimedia.org/34930 (10Helder) [14:14:45] 3MediaWiki / 3ContentHandler: "Suppress redirect" checkbox on Special:MovePage should not just disappear if ContentHandler doesn't support redirects - 10https://bugzilla.wikimedia.org/58017 (10Helder) [14:14:45] 3MediaWiki / 3ContentHandler: ContentHandler's inability to create redirects for certain content models should be reflected in the UI - 10https://bugzilla.wikimedia.org/42915 (10Helder) [14:16:16] 3MediaWiki / 3General/Unknown: Extensions missing REL1_23 branches - 10https://bugzilla.wikimedia.org/67270#c16 (10Kunal Mehta (Legoktm)) 5REOP>3ASSI a:3Kunal Mehta (Legoktm) This is ridiculous. I'm just going to fix it myself. [14:16:33] (03PS6) 10Matthias Mullie: Error handling for view-topiclist actions (change sort & load more) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143342 [14:18:47] legoktm: heh [14:19:11] MatmaRex: you are a RL wizard now right ? [14:19:30] (03CR) 10Matthias Mullie: "Should work again. Parent patch had been cherry-picked onto master, cutting this one loose from others it depended on. I assume that's why" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143342 (owner: 10Matthias Mullie) [14:19:51] um [14:20:01] hehe [14:20:02] http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCodeEditor.git/e444e66a742616a28b155e70bccdbedaab594709/CodeEditor.php [14:20:27] (03PS1) 10Robert Vogel: Fixed UTF-8 issue in BsTagFinder [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/143877 [14:20:32] i want to make it easier to load different language modes for ACE on the fly... [14:21:36] sounds scary [14:21:45] (03PS6) 10Matthias Mullie: Error handling for open/close topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143314 [14:21:48] (03PS7) 10Matthias Mullie: Error handling for moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143315 [14:21:51] (03PS4) 10Matthias Mullie: Error handling for Summarise and edit summary topic actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143293 [14:21:54] (03PS7) 10Matthias Mullie: Error handling for view-topiclist actions (change sort & load more) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143342 [14:21:56] yeah.. defined 30 seperate modules seems.. not the right way to go. [14:22:00] 3MediaWiki extensions / 3UniversalLanguageSelector: ULS language selector autocompletes Gujarati as Gujaraati - 10https://bugzilla.wikimedia.org/61438#c3 (10Nemo) 5NEW>3RESO/INV Are you sure this is a CLDR issue? There is at least one language where the name of "gu" is "Gujaraati", i.e. "so", according t... [14:22:03] ah, ace [14:22:21] they still don’t hvae good support for variable-width scripts or touch devices [14:22:53] i think it's actually partly a bug in the requireJS setup of ACE, since it is able to find some of the modules that are not defined.. [14:23:07] just not the mode-language.js ones... [14:23:12] hmmmm, interesting [14:23:15] lemme take a peek [14:24:13] which reminds me that i should unexport require from globals variables in code editor... [14:25:15] thedj: 30 separate modules is what i did for SyntaxHighlight, seems to work well [14:25:26] (except it was more like 100 modules there) [14:25:51] <^d> MatmaRex: Thanks for the other merge earlier. That was the last one I saw that could be moved into an existing file. [14:26:04] <^d> The rest will require making page-specific css we don't have yet. [14:26:06] https://github.com/wikimedia/mediawiki-extensions-SyntaxHighlight_GeSHi/blob/master/SyntaxHighlight_GeSHi.class.php#L481 [14:26:58] brion: just take out mode-javascript.js out of the main ext.codeEditor.ace module for instance. It won't find it on the fly anymore. But i'm sure it can lazyload the worker-javascript... [14:27:20] so perhaps it uses relative require mode or something there... [14:28:18] MatmaRex: well, that was my backup plan I guess.. [14:29:05] hmmmmmmm, interesting [14:29:21] it seems to find worker-javascript.js yeah. BUT HOW [14:29:30] 3MediaWiki / 3Skin and page rendering: Large number of CSS rules for external links - 10https://bugzilla.wikimedia.org/54604#c73 (10Krinkle) (In reply to Bartosz Dziewoński from comment #54) > (In reply to Gabriel Wicke from comment #52) > > Do we have actual measurements that verify that this benefits total... [14:29:42] (03CR) 10Krinkle: [C: 04-1] "See https://bugzilla.wikimedia.org/show_bug.cgi?id=54604#c73" [core] - 10https://gerrit.wikimedia.org/r/141973 (https://bugzilla.wikimedia.org/54604) (owner: 10Bartosz Dziewoński) [14:30:41] brion: it uses the basePath variable to resolve the path, but i'm unclear as to why it chooses a different resolve strategy there... [14:31:43] ok, our module is setting basePath from wgExtensionAssetsPath …. that should work… [14:31:46] lemme try the delete trick [14:31:46] ace.config.set( 'basePath', basePath + '/CodeEditor/modules/ace' ); [14:33:53] brion: hmm, worker is a dependency for mode-javascript, and passes trough define... perhaps that is why it can find it... [14:34:01] 3MediaWiki extensions / 3WikidataRepo: Silently resolve redirects in SpecialEntityData - 10https://bugzilla.wikimedia.org/67032 (10Lydia Pintscher) [14:34:58] so define() resolving vs require() resolving.. ? [14:35:32] 3MediaWiki extensions / 3WikidataRepo: Silently resolve redirects in SpecialEntityData - 10https://bugzilla.wikimedia.org/67032 (10Lydia Pintscher) [14:36:07] ugh i’m trying to work my way through this require code, the error thrown is like ten steps away from the logic :D [14:41:44] (03PS1) 10Steinsplitter: Revert json2.js - Causing major problems, See [[Bug:67420]] [core] - 10https://gerrit.wikimedia.org/r/143880 [14:42:39] (03CR) 10Hoo man: [C: 04-2] "Some extensions already rely on this... eg. Wikidata." [core] - 10https://gerrit.wikimedia.org/r/143880 (owner: 10Steinsplitter) [14:43:01] (03CR) 10jenkins-bot: [V: 04-1] Revert json2.js - Causing major problems, See [[Bug:67420]] [core] - 10https://gerrit.wikimedia.org/r/143880 (owner: 10Steinsplitter) [14:44:45] 3Wikimedia / 3Site requests: 300GB of files on a hard disk in need of a URI or WMF direct upload - 10https://bugzilla.wikimedia.org/67477#c4 (10Fæ) Created attachment 15834 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15834&action=edit Wellcome test image Test image while discussing upload options... [14:45:58] (03CR) 10Isarra: "Could you clarify how that comment applies to this patch specifically?" [core] - 10https://gerrit.wikimedia.org/r/141973 (https://bugzilla.wikimedia.org/54604) (owner: 10Bartosz Dziewoński) [14:46:25] (03CR) 10Isarra: "Wait, sorry, wrong patch. Ignore me." [core] - 10https://gerrit.wikimedia.org/r/141973 (https://bugzilla.wikimedia.org/54604) (owner: 10Bartosz Dziewoński) [14:46:42] (03CR) 10Smuggli: [C: 032 V: 032] Fixed UTF-8 issue in BsTagFinder [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/143877 (owner: 10Robert Vogel) [14:46:55] (03Abandoned) 10Steinsplitter: Revert json2.js - Causing major problems, See [[Bug:67420]] [core] - 10https://gerrit.wikimedia.org/r/143880 (owner: 10Steinsplitter) [14:50:45] 3Wikimedia / 3Site requests: 300GB of files on a hard disk in need of a URI or WMF direct upload - 10https://bugzilla.wikimedia.org/67477#c5 (10Fæ) Size and format: Added test jpeg image above. I think this is an good example small file at 3mb, I would speculate that images may be 5x to 10x larger than this... [14:51:01] (03Restored) 10Steinsplitter: Revert json2.js - Causing major problems, See [[Bug:67420]] [core] - 10https://gerrit.wikimedia.org/r/143880 (owner: 10Steinsplitter) [14:51:12] (03CR) 10Chad: [C: 031] "Tested out this chain of changes and it works for me." [vagrant] - 10https://gerrit.wikimedia.org/r/143827 (owner: 10Ori.livneh) [14:51:48] (03PS2) 10Krinkle: Revert addition of json2.js [core] - 10https://gerrit.wikimedia.org/r/143880 (https://bugzilla.wikimedia.org/67420) (owner: 10Steinsplitter) [14:53:04] (03CR) 10jenkins-bot: [V: 04-1] Revert addition of json2.js [core] - 10https://gerrit.wikimedia.org/r/143880 (https://bugzilla.wikimedia.org/67420) (owner: 10Steinsplitter) [14:53:14] thedj: so it looks like the require() code path is only looking up things that have already been preloaded/defined, i don’t see it trying to fetch anything over the network when i dive in with the debugger [14:53:41] (03CR) 10Steinsplitter: "cant't rebase this, there is some conflict... :/" [core] - 10https://gerrit.wikimedia.org/r/143880 (https://bugzilla.wikimedia.org/67420) (owner: 10Steinsplitter) [14:54:31] brion: yeah, i think it's doing implicit relative loading for the modules that it needs. [14:55:00] (03PS1) 10Amire80: Add ids to the old link and the new link at the move result [core] - 10https://gerrit.wikimedia.org/r/143881 [14:55:03] well they’re preloaded through the RL modules from our code [14:55:14] but since nothing depends on ace/mode/javascript, it doesn't have a relative require call anywhere [14:57:12] (03CR) 10Krinkle: "@Paladox: JSON isn't versioned. There is only one version (version 1, see json.org, with a specified interface in ES5.1). There is a libra" [core] - 10https://gerrit.wikimedia.org/r/140560 (owner: 10Krinkle) [14:57:14] well it’s required from jquery.codeEditor.js as: AceLangMode = require( 'ace/mode/' + lang ).Mode; [14:57:20] but that only works if the module was preloaded via RL [14:57:21] (03PS16) 10Paladox: Update jQuery Cookie to v1.4.1 [core] - 10https://gerrit.wikimedia.org/r/139686 [14:57:28] yup [14:57:43] it looks like the packaged ace.js we have doesn’t have logic to fetch additional non-packaged scripts [14:57:57] the javascript-worker.js is a special case as it’s not loaded as a regular script, i assume [14:58:31] (03PS1) 10Mvolz: Moved variables to localsettings file [services/citoid] - 10https://gerrit.wikimedia.org/r/143882 [14:59:08] (03CR) 10Mvolz: [C: 032 V: 032] Moved variables to localsettings file [services/citoid] - 10https://gerrit.wikimedia.org/r/143882 (owner: 10Mvolz) [14:59:30] 3MediaWiki / 3General/Unknown: Extensions missing REL1_23 branches - 10https://bugzilla.wikimedia.org/67270#c17 (10Mark A. Hershberger) (In reply to Kunal Mehta (Legoktm) from comment #16) > This is ridiculous. I'm just going to fix it myself. Thanks! Let me know if you need any gerrit approvals. [14:59:37] (03CR) 10BryanDavis: [C: 032] Be more explicit that dependent roles are not marked [vagrant] - 10https://gerrit.wikimedia.org/r/143816 (https://bugzilla.wikimedia.org/52263) (owner: 10Chad) [14:59:44] thedj: might be able to do the loading manually through RL … can we request loading an arbitrary JS URL and have it wait on the result? i forget [14:59:55] (rather than manually packaging every language with a module definition) [15:00:02] well we could automate/script that [15:00:05] (03Merged) 10jenkins-bot: Be more explicit that dependent roles are not marked [vagrant] - 10https://gerrit.wikimedia.org/r/143816 (https://bugzilla.wikimedia.org/52263) (owner: 10Chad) [15:00:30] brion: yeah mw.load.using( 'url' ) { } [15:00:43] spiff [15:01:15] 3Wikimedia / 3General/Unknown: Users experiencing "Script not responding" errors on 1.24wmf11 wikis - 10https://bugzilla.wikimedia.org/67420#c16 (10Krinkle) JSON2 is only loaded in old browses. And just in case the feature test wasn't passing, I confirmed just now in Chrome 35 and Firefox 29 and 30 that when... [15:01:23] (03CR) 10Krinkle: "See https://bugzilla.wikimedia.org/show_bug.cgi?id=67420#c16" [core] - 10https://gerrit.wikimedia.org/r/143880 (https://bugzilla.wikimedia.org/67420) (owner: 10Steinsplitter) [15:01:41] (03CR) 10Isarra: "In light of weird parsoid things and whatnot, I'm inclined to agree that the parser changes are too expensive with too little general gain" [core] - 10https://gerrit.wikimedia.org/r/141973 (https://bugzilla.wikimedia.org/54604) (owner: 10Bartosz Dziewoński) [15:03:10] brion: still sort of dirty, but well, if that is what it takes [15:03:16] hehe [15:03:16] 3Wikimedia / 3General/Unknown: Users experiencing "Script not responding" errors on 1.24wmf11 wikis - 10https://bugzilla.wikimedia.org/67420#c17 (10Krinkle) Also to clarify, the usage in mw.inspect also had no impact because it's the reference to $.toJSON is a direct pointer to JSON.stringify. Nothing change... [15:03:42] or i can just do the syntaxhighlight way of defining 100 RL modules of coursee. [15:03:43] thedj: alternative possibility: provide a fallback ‘require’ implementation that … um…. does that :) [15:03:53] though i’m not sure that would work if it has to be synchronous [15:04:46] 3MediaWiki / 3Skin and page rendering: Large number of CSS rules for external links - 10https://bugzilla.wikimedia.org/54604#c74 (10ssastry) Phew .. long discussion. I could have gone either way (selectors or css classes) till I hit Gabriel and Roan's comments and now Krinkle's about client burden and code d... [15:06:06] brion: https://vickev.com/#!/article/grunt-the-perfect-tool-for-require-js [15:07:12] dynamic loading.. hm [15:07:50] (03CR) 10Florianschmidtwelzow: "@Steinsplitter: just as information:" [core] - 10https://gerrit.wikimedia.org/r/143880 (https://bugzilla.wikimedia.org/67420) (owner: 10Steinsplitter) [15:11:30] (03CR) 10Zfilipin: [C: 032] QA: porting login test from /qa/browsertests [core] - 10https://gerrit.wikimedia.org/r/143199 (owner: 10Cmcmahon) [15:12:18] (03CR) 10Zfilipin: [C: 032] QA: updates to edit test ported from qa/browsertests [core] - 10https://gerrit.wikimedia.org/r/143381 (owner: 10Cmcmahon) [15:12:46] 3Datasets / 3Webstatscollector: www.f / foundationwiki (wikimediafoundation.org) pageviews low, underreporting? - 10https://bugzilla.wikimedia.org/49266#c2 (10Nemo) Upon inspection of raw files it turns out the actual views appear to me recorded ad "m.f" instead now: http://stats.grok.se/m.f/top What's www.f... [15:12:59] (03CR) 10Zfilipin: [C: 032] Porting file test from browsertests [core] - 10https://gerrit.wikimedia.org/r/143079 (owner: 10Cmcmahon) [15:14:04] (03CR) 10Bartosz Dziewoński: "If we want to revert at all, it should be sufficient to remove the (two) uses in core, and Wikidata can figure out if this causes hidden b" [core] - 10https://gerrit.wikimedia.org/r/143880 (https://bugzilla.wikimedia.org/67420) (owner: 10Steinsplitter) [15:15:28] (03Merged) 10jenkins-bot: QA: porting login test from /qa/browsertests [core] - 10https://gerrit.wikimedia.org/r/143199 (owner: 10Cmcmahon) [15:15:33] 3Wikimedia / 3General/Unknown: Users experiencing "Script not responding" errors on 1.24wmf11 wikis - 10https://bugzilla.wikimedia.org/67420#c18 (10Bartosz Dziewoński) (Re the revert patch that was already proposed, if we want to revert at all, it should be sufficient to remove the (two) uses in core to reso... [15:15:44] (03Merged) 10jenkins-bot: QA: updates to edit test ported from qa/browsertests [core] - 10https://gerrit.wikimedia.org/r/143381 (owner: 10Cmcmahon) [15:16:18] (03Merged) 10jenkins-bot: Porting file test from browsertests [core] - 10https://gerrit.wikimedia.org/r/143079 (owner: 10Cmcmahon) [15:19:04] (03CR) 10Krinkle: "FIXME: Mentions of en.wikipedia.beta.wmflabs.org and test2.wikipedia.org do not belong in this repository." [core] - 10https://gerrit.wikimedia.org/r/143199 (owner: 10Cmcmahon) [15:20:26] chrismcmahon: zeljkof: I see this isn't the first one that mentions those so I won't revert, but really they shouldn't been added. [15:21:26] (03CR) 10Chad: [C: 032] Include FundraisingTranslateWorkflow extension in WMF deployments [tools/release] - 10https://gerrit.wikimedia.org/r/143793 (owner: 10Awight) [15:21:38] Krinkle: those are tags used by Cucumber [15:21:39] (03Merged) 10jenkins-bot: Include FundraisingTranslateWorkflow extension in WMF deployments [tools/release] - 10https://gerrit.wikimedia.org/r/143793 (owner: 10Awight) [15:21:41] imho the @ browsers don't be long there either (should be provided by config when running the tests), but that might make sense to allow/disallow failures to opt-in browsers known to work [15:22:09] (03PS1) 10Anomie: HTMLForm submission callback documentation updates [core] - 10https://gerrit.wikimedia.org/r/143885 [15:22:16] individual wmf wikis simply have no place in core, I dont tink there's any defence or rationale for that. I don't want to know how Cucumber does its thing. [15:26:13] (03CR) 10Phuedx: "> I'm not super sure this is the best route to take. Given that WikiFont-Glyphs is already in use, and will be in core soon, I'm not sure " [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [15:27:00] 3MediaWiki extensions / 3WikidataRepo: Wikidata: CTRL+click and middle click on search suggestions doesn't open the page in a new tab - 10https://bugzilla.wikimedia.org/57709#c6 (10Thiemo Mättig) 5NEW>3PATC https://gerrit.wikimedia.org/r/#/c/142510/ [15:28:16] 3MediaWiki extensions / 3WikidataRepo: Wikidata: CTRL+click and middle click on search suggestions doesn't open the page in a new tab - 10https://bugzilla.wikimedia.org/57709#c7 (10Lydia Pintscher) (In reply to Bartosz Dziewoński from comment #5) > Wikidata apparently reimplements the feature from scratch, s... [15:29:00] 3MediaWiki extensions / 3WikidataRepo: Wikidata: CTRL+click and middle click on search suggestions doesn't open the page in a new tab - 10https://bugzilla.wikimedia.org/57709 (10Lydia Pintscher) [15:31:21] <^d> Krinkle|detached: The only one you could maybe justify is mw.org :) [15:31:49] ^d: Even then. [15:31:59] ^d: Test configuration and test writing are distinct. [15:32:07] <^d> I don't disagree. [15:32:28] <^d> MatmaRex: Can you review one last thing for me pretty plz? [15:32:36] <^d> It's easy I promise. [15:32:52] (03PS1) 10Florianschmidtwelzow: Add returnto to Create of account [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/143888 (https://bugzilla.wikimedia.org/67462) [15:32:54] (03PS1) 10Mvolz: Pass zoteroURL as argument to zoteroRequest [services/citoid] - 10https://gerrit.wikimedia.org/r/143889 [15:33:12] (03CR) 10Mvolz: [C: 032 V: 032] Pass zoteroURL as argument to zoteroRequest [services/citoid] - 10https://gerrit.wikimedia.org/r/143889 (owner: 10Mvolz) [15:33:23] ^d: maybe [15:33:45] <^d> https://gerrit.wikimedia.org/r/#/c/143548/ just adding a
to clear:both to prevent some overlapping. [15:34:02] ew. [15:37:02] 3MediaWiki-Vagrant: Clarify that roles included as dependencies are not starred - 10https://bugzilla.wikimedia.org/52263 (10Chad H.) 5PATC>3RESO/FIX [15:37:30] 3MediaWiki / 3Skin and page rendering: Large number of CSS rules for external links - 10https://bugzilla.wikimedia.org/54604#c75 (10Jon) The icons for audio, video etc have been gone for some time without any complaints that I am aware of. Maybe because a lot of these styles are implemented in MediaWiki:Comm... [15:38:36] (03CR) 10Bartosz Dziewoński: [C: 032] "Ewww… but there's more stuff like this in there already. I should rewrite this some day." [core] - 10https://gerrit.wikimedia.org/r/143548 (https://bugzilla.wikimedia.org/67184) (owner: 10Chad) [15:38:45] 3MediaWiki extensions / 3WikidataRepo: Support Redirects between Items (tracking) - 10https://bugzilla.wikimedia.org/66067 (10Lydia Pintscher) [15:38:45] 3MediaWiki extensions / 3WikidataRepo: PHP Fatal error: Call to a member function isRedirect() on a non-object - 10https://bugzilla.wikimedia.org/67474 (10Lydia Pintscher) p:5Unprio>3Normal [15:39:33] (03PS1) 10Zfilipin: Deleted browsertests jobs, created Flow jobs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/143890 [15:40:19] (03CR) 10Anomie: [C: 04-1] "Split with I8777fc6b looks good." (038 comments) [core] - 10https://gerrit.wikimedia.org/r/143025 (owner: 10Kunalgrover05) [15:41:16] 3MediaWiki extensions / 3WikidataRepo: Argument 1 passed to Wikibase\EntityContent::getParserOutput() must be an instance of Title - 10https://bugzilla.wikimedia.org/67473 (10Lydia Pintscher) p:5Unprio>3High [15:41:16] 3MediaWiki extensions / 3WikidataRepo: PHP Fatal error: Call to a member function isRedirect() on a non-object - 10https://bugzilla.wikimedia.org/67474#c1 (10Marius Hoch) 5NEW>3RESO/FIX Fixed: https://gerrit.wikimedia.org/r/143854 [15:41:24] <^d> MatmaRex: That file makes me so angry that a lot of days I'm tempted to just start over with a new Special:Search. [15:41:29] <^d> It needs a rewrite, badly. [15:42:13] (03Merged) 10jenkins-bot: SpecialSearch: Fix overlap between results info and search bar [core] - 10https://gerrit.wikimedia.org/r/143548 (https://bugzilla.wikimedia.org/67184) (owner: 10Chad) [15:43:14] hah [15:48:01] 3Wikimedia / 3General/Unknown: Users experiencing "Script not responding" errors on 1.24wmf11 wikis - 10https://bugzilla.wikimedia.org/67420#c19 (10Lupo) Depreceation loop? See https://commons.wikimedia.org/w/index.php?title=Commons:Forum&diff=128061457&oldid=128054357 [15:48:01] (03PS2) 10Zfilipin: Deleted browsertests jobs, created Flow jobs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/143890 (https://bugzilla.wikimedia.org/58040) [15:48:26] (03CR) 10Cmcmahon: [C: 032] Deleted browsertests jobs, created Flow jobs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/143890 (https://bugzilla.wikimedia.org/58040) (owner: 10Zfilipin) [15:48:41] (03CR) 10Anomie: [C: 04-1] Backend method for Special:PageLanguage, purge on language change (038 comments) [core] - 10https://gerrit.wikimedia.org/r/143049 (owner: 10Kunalgrover05) [15:50:15] (03Merged) 10jenkins-bot: Deleted browsertests jobs, created Flow jobs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/143890 (https://bugzilla.wikimedia.org/58040) (owner: 10Zfilipin) [15:50:31] 3MediaWiki / 3Search: Search results number overlap the border of the grey background - 10https://bugzilla.wikimedia.org/67184 (10Chad H.) 5PATC>3RESO/FIX [15:50:46] 3Wikimedia / 3Extension setup: "Wikimedia Shop" deployment on tr-wiki - 10https://bugzilla.wikimedia.org/66727#c4 (10superyetkin) Thanks buddy. Everything's sorted. [15:52:53] (03PS1) 10Giuseppe Lavagetto: twemproxy/nutcracker: add restart script to be used post-migration [tools/scap] - 10https://gerrit.wikimedia.org/r/143892 [15:56:17] Aha. [15:56:19] brion: ace.config.loadModule("ace/mode/xml", function() { [15:56:19] AceLangMode = require( 'ace/mode/xml' ).Mode; [15:56:22] }); [15:56:37] \o/ [15:56:41] that seems to do the trick... somehow... [15:56:45] heh [15:57:39] https://commons.wikimedia.org/w/index.php?title=Commons:Forum&diff=128061457&oldid=128054357 [15:59:17] Krinkle|detached, Reedy: ^^^ [15:59:33] Looks like we need to do a quick patch to EventLogging and release out in wmf11. [15:59:45] 3MediaWiki / 3Skin and page rendering: Large number of CSS rules for external links - 10https://bugzilla.wikimedia.org/54604#c76 (10Isarra) (In reply to Jon from comment #75) > The icons for audio, video etc have been gone for some time without any > complaints that I am aware of. Maybe because a lot of thes... [16:00:29] brion: ah, that has: net.loadScript(exports.moduleUrl(moduleName, moduleType), afterLoad); [16:00:38] (03PS1) 10Jforrester: Use 'json' module instead of deprecated 'jquery.json' [extensions/EventLogging] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143894 (https://bugzilla.wikimedia.org/67420) [16:02:10] (03CR) 10BryanDavis: [C: 032] "Basically a clone of restart-twemproxy" [tools/scap] - 10https://gerrit.wikimedia.org/r/143892 (owner: 10Giuseppe Lavagetto) [16:02:28] (03Merged) 10jenkins-bot: twemproxy/nutcracker: add restart script to be used post-migration [tools/scap] - 10https://gerrit.wikimedia.org/r/143892 (owner: 10Giuseppe Lavagetto) [16:02:32] 3Wikimedia / 3General/Unknown: With a sample rate of 1:100 users are sent into infinite loop - 10https://bugzilla.wikimedia.org/67478 (10Rainer Rillke @commons.wikimedia) 3NEW p:3Unprio s:3normal a:3None With a sample rate of 1:100 users are sent into infinite JavaScript loop crashing browsers etc. S... [16:02:49] (03CR) 10Hoo man: [C: 032] Use 'json' module instead of deprecated 'jquery.json' [extensions/EventLogging] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143894 (https://bugzilla.wikimedia.org/67420) (owner: 10Jforrester) [16:02:57] (03CR) 10Hoo man: Use 'json' module instead of deprecated 'jquery.json' [extensions/EventLogging] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143894 (https://bugzilla.wikimedia.org/67420) (owner: 10Jforrester) [16:03:00] 3Wikimedia / 3General/Unknown: With a sample rate of 1:100 users are sent into infinite loop - 10https://bugzilla.wikimedia.org/67478 (10Rainer Rillke @commons.wikimedia) p:5Unprio>3Highes s:5normal>3critic [16:03:10] hoo: Awesome, tahnks. [16:03:10] James_F: Didn't realize that's on a wmf branch [16:03:16] 3Wikimedia / 3General/Unknown: With a sample rate of 1:100 users are sent into infinite loop - 10https://bugzilla.wikimedia.org/67478#c1 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 67420 *** [16:03:16] 3Wikimedia / 3General/Unknown: Users experiencing "Script not responding" errors on 1.24wmf11 wikis - 10https://bugzilla.wikimedia.org/67420#c21 (10James Forrester) *** Bug 67478 has been marked as a duplicate of this bug. *** [16:03:17] hoo: Oh. Boo. [16:03:28] I can merge, but you'll ahve to deploy it [16:03:31] hoo: Yeah, it's fixed in master, but not in wmf11. [16:03:39] or I can quickly deploy if greg is fine [16:03:47] * James_F can get someone to merge it but we should sanity-check first. I think greg-g's out today. [16:04:00] Also, Metrics during the deployment. Fun. [16:04:56] James_F: No deploy atm, so I can push it... or you can go for SWAT [16:05:04] Change is trivial, though [16:05:12] (reviewed a very similar one earlier today) [16:05:14] hoo: I was going to get Reedy to slip-stream it into wmf11 before he deployed it any further. [16:05:16] 3Wikimedia / 3General/Unknown: With a sample rate of 1:100 users are sent into infinite loop - 10https://bugzilla.wikimedia.org/67478#c2 (10Rainer Rillke @commons.wikimedia) mw.trackSubscribe( 'mw.deprecate', function ( topic, deprecated ) { mw.loader.using( [ 'mediawiki.inspect', 'schema.DeprecatedUsage' ]... [16:05:25] also an option [16:05:31] if you poke him on it, I can approve [16:05:35] * James_F nods. [16:05:36] just don't forget about it :P [16:05:39] Idle 4 hours, though. [16:05:53] * James_F will bully some people into getting it fixed, worry not. :-) [16:06:07] (03CR) 10Hoo man: [C: 032] "James will take care of getting this deployed today" [extensions/EventLogging] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143894 (https://bugzilla.wikimedia.org/67420) (owner: 10Jforrester) [16:07:44] (03Merged) 10jenkins-bot: Use 'json' module instead of deprecated 'jquery.json' [extensions/EventLogging] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143894 (https://bugzilla.wikimedia.org/67420) (owner: 10Jforrester) [16:10:03] (03PS1) 10Jforrester: Update EventLogging to pull in 1e9adcfc5 [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143896 (https://bugzilla.wikimedia.org/67420) [16:11:02] 3Wikimedia / 3General/Unknown: Users experiencing "Script not responding" errors on 1.24wmf11 wikis – EventLogging triggering itself with deprecation warnings - 10https://bugzilla.wikimedia.org/67420 (10James Forrester) a:3James Forrester [16:13:26] (03CR) 10Hoo man: [C: 031] "Please consider this a +2 as soon as the branch has been cut." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (https://bugzilla.wikimedia.org/14862) (owner: 10Legoktm) [16:14:25] (03Abandoned) 10Bartosz Dziewoński: Revert addition of json2.js [core] - 10https://gerrit.wikimedia.org/r/143880 (https://bugzilla.wikimedia.org/67420) (owner: 10Steinsplitter) [16:14:48] 3MediaWiki extensions / 3WikimediaEvents: Tracker for mw.deprecate and jquery.migrate should not allow recursive tracking - 10https://bugzilla.wikimedia.org/67481 (10Brad Jorsch) 3NEW p:3Unprio s:3normal a:3Matthew Flaschen Bug 67420 was apparently caused by a deprecation warning from inside the hand... [16:16:45] 3Wikimedia / 3General/Unknown: Users experiencing "Script not responding" errors on 1.24wmf11 wikis – EventLogging triggering itself with deprecation warnings - 10https://bugzilla.wikimedia.org/67420#c25 (10Brad Jorsch) (In reply to Lupo from comment #19) > Depreceation loop? See > > https://commons.wikimed... [16:18:16] 3MediaWiki extensions / 3Cite: Cite: If there's no block on the page, show one automatically below the content rather than showing an error - 10https://bugzilla.wikimedia.org/66860#c6 (10Jared Zimmerman (WMF)) Has this been integrated? I tried to simulate it by removing an existing {{reflist}}... [16:18:45] 3MediaWiki extensions / 3WikimediaEvents: Tracker for mw.deprecate and jquery.migrate should not allow recursive tracking - 10https://bugzilla.wikimedia.org/67481#c1 (10Bartosz Dziewoński) Detecting recursive calls might be difficult, but it can just suppress all warnings. From /tests/qunit/data/testrunner.j... [16:20:16] 3Wikimedia / 3General/Unknown: Users experiencing "Script not responding" errors on 1.24wmf11 wikis – EventLogging triggering itself with deprecation warnings - 10https://bugzilla.wikimedia.org/67420#c26 (10Rainer Rillke @commons.wikimedia) (In reply to Andre Klapper from comment #1) > Can't reproduce with F... [16:22:15] 3MediaWiki extensions / 3Cite: Cite: If there's no block on the page, show one automatically below the content rather than showing an error - 10https://bugzilla.wikimedia.org/66860#c7 (10James Forrester) (In reply to Jared Zimmerman (WMF) from comment #6) > Has this been integrated? I tried to... [16:23:02] 3Wikimedia / 3General/Unknown: DomainKeys Identified Mail (DKIM) for wikipedia.org (and other projects) - 10https://bugzilla.wikimedia.org/56413#c4 (10Faidon Liambotis) 5NEW>3RESO/FIX All Wikimedia outgoing mail should be signed with DKIM now. We have no strict DMARC policy yet and it's unsure whether we... [16:27:30] 3MediaWiki extensions / 3CentralNotice: Make CentralNotice banner-hiding cookie work cross-site - 10https://bugzilla.wikimedia.org/16821#c20 (10Matt Walker) 5NEW>3RESO/FIX Heh; that's true; but then we re-enabled it here: https://gerrit.wikimedia.org/r/#/c/126998/ [16:28:18] 3MediaWiki / 3API: blockexpiry value is poorly formatted in list=users and list=allusers - 10https://bugzilla.wikimedia.org/67482 (10Brad Jorsch) 3NEW p:3Unprio s:3minor a:3None The value should be formatted using $wgContLang->formatExpiry rather than just dumping the database representation. But car... [16:28:45] 3MediaWiki extensions / 3CirrusSearch: Class 'Elastica\Exception\ElasticsearchException' not found - 10https://bugzilla.wikimedia.org/67228#c2 (10Chad H.) 5NEW>3RESO/FIX This was cherry picked to shut up the error in production. Marking fixed. [16:32:30] 3MediaWiki extensions / 3CirrusSearch: Missing index warning not catched forceSearchIndex.php - 10https://bugzilla.wikimedia.org/67465#c2 (10Chad H.) Why weren't they created? Did addWiki give some kind of error? What was its output? [16:33:03] (03CR) 10MaxSem: [C: 032] Update EventLogging to pull in 1e9adcfc5 [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143896 (https://bugzilla.wikimedia.org/67420) (owner: 10Jforrester) [16:33:16] 3Wikimedia / 3General/Unknown: Get mail relay out of Yahoo! blacklist: apply to Yahoo for whitelisting bulk mail - 10https://bugzilla.wikimedia.org/56414#c24 (10Nemo) Bug 56413 was fixed, so I'm told this is currently waiting for bug 46640 and mailman 2.1.17+ (for MediaWiki mailer's and mailman's IPs respect... [16:33:40] (03CR) 10MaxSem: [V: 032] Update EventLogging to pull in 1e9adcfc5 [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143896 (https://bugzilla.wikimedia.org/67420) (owner: 10Jforrester) [16:34:55] (03CR) 10Anomie: [C: 04-1] "ApiQueryUserInfo could use both blocktimestamp and blockexpiry. Please take care of that too." [core] - 10https://gerrit.wikimedia.org/r/143787 (https://bugzilla.wikimedia.org/63326) (owner: 10Brian Wolff) [16:35:56] (03PS1) 10Rohan013: FeedContributions now shows diffs instead of whole articles. [core] - 10https://gerrit.wikimedia.org/r/143904 (https://bugzilla.wikimedia.org/41085) [16:39:00] 3MediaWiki extensions / 3CirrusSearch: Missing index warning not catched forceSearchIndex.php - 10https://bugzilla.wikimedia.org/67465#c3 (10Antoine "hashar" Musso) When creating eswiki and cawiki on both wikis I got a permission denied opening /tmp/mw-UIDGenerator-squidhtcppurge-48 it is only writable by a... [16:39:18] 3MediaWiki extensions / 3Scribunto: Scribunto tests require an English language wiki - 10https://bugzilla.wikimedia.org/67483 (10Marius Hoch) 3NEW p:3Unprio s:3normal a:3None Scribunto's phpunit tests fail hard on non-English wikis. This is mostly caused by hard coded namespace names. [16:39:45] 3MediaWiki extensions / 3Scribunto: Scribunto tests require an English language wiki - 10https://bugzilla.wikimedia.org/67483 (10Marius Hoch) p:5Unprio>3Normal [16:41:30] 3Wikimedia / 3General/Unknown: Users experiencing "Script not responding" errors on 1.24wmf11 wikis – EventLogging triggering itself with deprecation warnings - 10https://bugzilla.wikimedia.org/67420#c28 (10James Forrester) 5PATC>3RESO/FIX This should now be fixed. Sorry for the disruption. Will recommen... [16:41:31] (03PS1) 10Matthias Mullie: Remove useless file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143905 [16:41:34] (03PS1) 10Matthias Mullie: Extremely hacky implementation of 'log improvements' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143906 [16:45:00] 3MediaWiki / 3General/Unknown: Extensions missing REL1_23 branches - 10https://bugzilla.wikimedia.org/67270#c18 (10Bawolff (Brian Wolff)) > > Unfortunately, gerrit/git won't let me delete the bad branches. The easiest > thing to do would be to drop those REL1_23 branches that don't have their > own commit... [16:48:11] (03CR) 10Chad: [C: 031] Remove dependency on Python 3.2 [vagrant] - 10https://gerrit.wikimedia.org/r/143821 (owner: 10Ori.livneh) [16:51:13] (03PS3) 10Yuvipanda: Remove dependency on Python 3.2 [vagrant] - 10https://gerrit.wikimedia.org/r/143821 (owner: 10Ori.livneh) [16:51:34] (03CR) 10Yuvipanda: [C: 031] "Hmm, should be merged after we move the base image to trusty, I presume?" [vagrant] - 10https://gerrit.wikimedia.org/r/143821 (owner: 10Ori.livneh) [16:51:53] (03CR) 10Daniel Friesen: "Before merging someone should go over History.js' list of browser bugs and test this to see if we need to blacklist any browsers for this " (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143852 (https://bugzilla.wikimedia.org/35045) (owner: 10Bartosz Dziewoński) [16:55:03] (03CR) 10Bartosz Dziewoński: "No doubt. I've tried it on some major browsers and it worked well in the test cases described in commit message, but I couldn't have teste" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143852 (https://bugzilla.wikimedia.org/35045) (owner: 10Bartosz Dziewoński) [16:58:00] 3MediaWiki extensions / 3WikidataRepo: Wikibase Repository : broken links on Special:DispatchStats - 10https://bugzilla.wikimedia.org/66959 (10Jakob Warkotsch) 5NEW>3RESO/FIX [16:59:00] 3MediaWiki extensions / 3WikidataRepo: Wikibase Repository : broken links on Special:DispatchStats - 10https://bugzilla.wikimedia.org/66959#c2 (10Marius Hoch) Done by Jakob: https://gerrit.wikimedia.org/r/143907 [17:02:38] MaxSem, MatmaRex do you think https://gerrit.wikimedia.org/r/#/c/143881 is okay? [17:03:16] 3MediaWiki extensions / 3WikidataRepo: [Monolingual] Old value is saved when keys are pressed to fast - 10https://bugzilla.wikimedia.org/67393 (10Lydia Pintscher) 5PATC>3RESO/FIX [17:04:26] Nikerabbit: looks reasonable at a glance [17:05:40] no objections from me [17:06:19] ok, thanks [17:08:27] (03CR) 10Nikerabbit: [C: 032] Add ids to the old link and the new link at the move result [core] - 10https://gerrit.wikimedia.org/r/143881 (owner: 10Amire80) [17:12:09] (03Merged) 10jenkins-bot: Add ids to the old link and the new link at the move result [core] - 10https://gerrit.wikimedia.org/r/143881 (owner: 10Amire80) [17:12:45] 3MediaWiki / 3Skin and page rendering: Large number of CSS rules for external links - 10https://bugzilla.wikimedia.org/54604#c77 (10Jon) Isarra. What was the motivation for putting them in in the first place? Putting styles in both core and common.css that do the same thing is a terrible terrible terrible t... [17:14:45] 3MediaWiki extensions / 3Cite: Cite: If there's no block on the page, show one automatically below the content rather than showing an error - 10https://bugzilla.wikimedia.org/66860#c8 (10Jared Zimmerman (WMF)) @james, thank you. [17:19:02] (03CR) 10PleaseStand: [C: 04-1] On redirect, actually update URL to the target page with JavaScript (038 comments) [core] - 10https://gerrit.wikimedia.org/r/143852 (https://bugzilla.wikimedia.org/35045) (owner: 10Bartosz Dziewoński) [17:19:26] (03PS1) 10Rohan013: $wgDefaultUserOptions['rememberpassword'] now sets the value of "keep me logged in" checkbox [core] - 10https://gerrit.wikimedia.org/r/143908 (https://bugzilla.wikimedia.org/67133) [17:20:54] Lol, deprecation loop. didn't see that one coming [17:21:01] 3MediaWiki-Vagrant: Custom vagrant commands don't run from subdirs - 10https://bugzilla.wikimedia.org/67445 (10Dan Duvall) 5NEW>3ASSI p:5Unprio>3Normal a:5Ori Livneh>3Dan Duvall [17:21:07] ori: Do you approve making mw.track consistently async instead of only inconsistently so? [17:22:09] I like the idea of event handlers not blocking the operation (e.g. access a js property, or process some other kind of action). It should just be pushing into a buffer and get on with the important business first. [17:22:10] (03PS1) 10Yaron Koren: Fixed URL for Special:Version listing [extensions/SiteSettings] - 10https://gerrit.wikimedia.org/r/143909 [17:22:42] (03CR) 10Yaron Koren: [C: 032 V: 032] Fixed URL for Special:Version listing [extensions/SiteSettings] - 10https://gerrit.wikimedia.org/r/143909 (owner: 10Yaron Koren) [17:23:16] (03CR) 10Parent5446: [C: 04-2] "The 'rememberpassword' preference does not exist anymore as of I7c957e1e1aaecf47f7c47bc063b5d3b364644afc." [core] - 10https://gerrit.wikimedia.org/r/143908 (https://bugzilla.wikimedia.org/67133) (owner: 10Rohan013) [17:23:58] (03CR) 10Rohan013: "Yes, but this is for the checkbox on the login page." [core] - 10https://gerrit.wikimedia.org/r/143908 (https://bugzilla.wikimedia.org/67133) (owner: 10Rohan013) [17:23:59] ori, how do I test https://gerrit.wikimedia.org/r/#/c/143827/ ? [17:25:04] (03PS2) 10Jdlrobson: Hygiene: Remove useless file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143905 (owner: 10Matthias Mullie) [17:25:07] (03CR) 10Parent5446: "That doesn't really change anything. The preference does not exist at all. It has been removed from $wgDefaultUserOptions." [core] - 10https://gerrit.wikimedia.org/r/143908 (https://bugzilla.wikimedia.org/67133) (owner: 10Rohan013) [17:25:16] (03CR) 10Jdlrobson: [C: 032] "haha" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143905 (owner: 10Matthias Mullie) [17:25:36] (03Merged) 10jenkins-bot: Hygiene: Remove useless file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143905 (owner: 10Matthias Mullie) [17:26:35] (03CR) 10Rohan013: "So, should i define a new global ?" [core] - 10https://gerrit.wikimedia.org/r/143908 (https://bugzilla.wikimedia.org/67133) (owner: 10Rohan013) [17:27:12] (03CR) 10Daniel Friesen: On redirect, actually update URL to the target page with JavaScript (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143852 (https://bugzilla.wikimedia.org/35045) (owner: 10Bartosz Dziewoński) [17:28:00] 3MediaWiki / 3User login and signup: $wgDefaultUserOptions['rememberpassword'] = 1 stopped working in 1.23 - 10https://bugzilla.wikimedia.org/67133#c2 (10Tyler Romeo) This is due to the user preference being removed in https://gerrit.wikimedia.org/r/94614. What does everybody think about how to handle this? [17:28:15] 3MediaWiki / 3User login and signup: $wgDefaultUserOptions['rememberpassword'] = 1 stopped working in 1.23 - 10https://bugzilla.wikimedia.org/67133 (10Tyler Romeo) [17:29:30] 3MediaWiki / 3General/Unknown: Extensions missing REL1_23 branches - 10https://bugzilla.wikimedia.org/67270#c19 (10Bawolff (Brian Wolff)) (In reply to Bawolff (Brian Wolff) from comment #18) > > > > Unfortunately, gerrit/git won't let me delete the bad branches. The easiest > > thing to do would be to drop... [17:30:09] (03PS51) 10Legoktm: Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (https://bugzilla.wikimedia.org/14862) [17:30:39] (03CR) 10Legoktm: [C: 032] "Per hoo" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (https://bugzilla.wikimedia.org/14862) (owner: 10Legoktm) [17:30:46] (03Merged) 10jenkins-bot: Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (https://bugzilla.wikimedia.org/14862) (owner: 10Legoktm) [17:33:24] (03PS4) 10Legoktm: Refactor global renaming [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143478 (owner: 10Hoo man) [17:33:35] something about lua parser tests are failing for me [17:33:51] (03CR) 10Legoktm: [C: 032] "PS4: Rebase, I don't know why gerrit didn't like it." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143478 (owner: 10Hoo man) [17:33:53] (03CR) 10jenkins-bot: [V: 04-1] Refactor global renaming [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143478 (owner: 10Hoo man) [17:33:57] wat [17:34:03] anyone have clue about it? [17:34:06] (probably not) [17:34:15] aude: ask anomie? [17:34:25] (03CR) 10Legoktm: "recheck" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143478 (owner: 10Hoo man) [17:34:41] it means tests exiting w/o details when running on the wikidata build :( [17:34:52] Krinkle: yes, good idea [17:35:16] Krinkle: also, i meant to merge the entire asset-check patch series but had to get off the computer unexpectedly [17:35:18] (03CR) 10Florianschmidtwelzow: [C: 032] Add returnto to Create of account [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/143888 (https://bugzilla.wikimedia.org/67462) (owner: 10Florianschmidtwelzow) [17:35:23] (03Merged) 10jenkins-bot: Add returnto to Create of account [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/143888 (https://bugzilla.wikimedia.org/67462) (owner: 10Florianschmidtwelzow) [17:36:44] (03CR) 10Ori.livneh: [C: 032] Remove dependency on Python 3.2 [vagrant] - 10https://gerrit.wikimedia.org/r/143821 (owner: 10Ori.livneh) [17:36:52] trying reverting scribunto [17:36:53] (03CR) 10Ori.livneh: [C: 032] tidy up confirmedit role [vagrant] - 10https://gerrit.wikimedia.org/r/143824 (owner: 10Ori.livneh) [17:37:04] (03Merged) 10jenkins-bot: Remove dependency on Python 3.2 [vagrant] - 10https://gerrit.wikimedia.org/r/143821 (owner: 10Ori.livneh) [17:37:06] (03CR) 10Ori.livneh: [C: 032] Update MediaWiki-Vagrant for Trusty [vagrant] - 10https://gerrit.wikimedia.org/r/143827 (owner: 10Ori.livneh) [17:37:08] (03CR) 10jenkins-bot: [V: 04-1] tidy up confirmedit role [vagrant] - 10https://gerrit.wikimedia.org/r/143824 (owner: 10Ori.livneh) [17:37:10] (03CR) 10jenkins-bot: [V: 04-1] Update MediaWiki-Vagrant for Trusty [vagrant] - 10https://gerrit.wikimedia.org/r/143827 (owner: 10Ori.livneh) [17:37:23] (03PS1) 10Reedy: Add missing newline [tools/release] - 10https://gerrit.wikimedia.org/r/143913 [17:37:37] (03CR) 10Ori.livneh: [C: 032 V: 032] Made memory/time limits all per job type [services/jobrunner] - 10https://gerrit.wikimedia.org/r/143673 (owner: 10Aaron Schulz) [17:37:53] (03PS2) 10Ori.livneh: tidy up confirmedit role [vagrant] - 10https://gerrit.wikimedia.org/r/143824 [17:38:05] (03PS2) 10Ori.livneh: Update MediaWiki-Vagrant for Trusty [vagrant] - 10https://gerrit.wikimedia.org/r/143827 [17:38:13] gerrit spam, sorry [17:38:17] oooooo [17:40:45] 3MediaWiki / 3Skin and page rendering: Large number of CSS rules for external links - 10https://bugzilla.wikimedia.org/54604#c78 (10Andre Klapper) (In reply to Jon from comment #77) > PS. How can I remove myself from this bug. Since I'm the creator, it doesn't > seem possible. Sorry, only available in next... [17:42:45] (03CR) 10Anomie: [C: 032] "Enough waiting, people had plenty of chance to comment." [core] - 10https://gerrit.wikimedia.org/r/127592 (https://bugzilla.wikimedia.org/64167) (owner: 10TTO) [17:44:00] (03PS1) 10Florianschmidtwelzow: Move Code from SpecialPage to GoogleLogin [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/143920 (https://bugzilla.wikimedia.org/67219) [17:44:17] (03PS1) 10Legoktm: Add extension credits for global rename [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143921 [17:44:30] 3MediaWiki extensions / 3WikimediaEvents: Tracker for mw.deprecate and jquery.migrate should not allow recursive tracking - 10https://bugzilla.wikimedia.org/67481 (10Andre Klapper) p:5Unprio>3High [17:44:45] 3MediaWiki / 3Skin and page rendering: Large number of CSS rules for external links - 10https://bugzilla.wikimedia.org/54604#c79 (10Isarra) (In reply to Jon from comment #77) > Isarra. What was the motivation for putting them in in the first place? Given that this was orginally added in 2004, I couldn't say... [17:46:35] (03PS2) 10Florianschmidtwelzow: Move Code from SpecialPage to GoogleLogin [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/143920 (https://bugzilla.wikimedia.org/67219) [17:46:45] 3MediaWiki / 3User login and signup: $wgDefaultUserOptions['rememberpassword'] = 1 stopped working in 1.23 - 10https://bugzilla.wikimedia.org/67133#c3 (10Jeremy) Patch applied and confirmed working in REL1_23. Whether this is the final solution or not I'll leave to the experts, but this will work as a workar... [17:46:52] (03Merged) 10jenkins-bot: Allow local interwiki links with an empty title part [core] - 10https://gerrit.wikimedia.org/r/127592 (https://bugzilla.wikimedia.org/64167) (owner: 10TTO) [17:49:16] Woo, 4 digit bug fixed [17:49:31] and patch for another 4 digit bug submitted yesterday [17:50:02] 3MediaWiki extensions / 3FlaggedRevs: tooltip with message 'revreview-failed' contains plain html - 10https://bugzilla.wikimedia.org/67484 (10Umherirrender) 3NEW p:3Unprio s:3normal a:3None A user on de.wp reports that a tooltip on a review page shows html markup:

Diese Version konnte nicht ma... [17:51:01] 3MediaWiki / 3General/Unknown: Division by zero in /includes/ImagePage.php - 10https://bugzilla.wikimedia.org/36911#c8 (10Bawolff (Brian Wolff)) 5PATC>3RESO/FIX I believe this is fixed now. [17:52:30] (03CR) 10Reedy: [C: 032] Add extension credits for global rename [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143921 (owner: 10Legoktm) [17:52:38] (03Merged) 10jenkins-bot: Add extension credits for global rename [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143921 (owner: 10Legoktm) [17:52:41] (03PS2) 10Reedy: Add missing newline [tools/release] - 10https://gerrit.wikimedia.org/r/143913 [17:52:46] (03CR) 10Reedy: [C: 032] Add missing newline [tools/release] - 10https://gerrit.wikimedia.org/r/143913 (owner: 10Reedy) [17:53:14] (03Merged) 10jenkins-bot: Add missing newline [tools/release] - 10https://gerrit.wikimedia.org/r/143913 (owner: 10Reedy) [17:54:00] 3MediaWiki / 3General/Unknown: Deal with logging query spam on crawler 404 floods - 10https://bugzilla.wikimedia.org/67439#c1 (10Aaron Schulz) (In reply to Aaron Schulz from comment #0) > As seen at https://tendril.wikimedia.org/report/, we have a bunch of > crawlers of various types hitting non-existent pag... [17:56:16] (03PS1) 10Chad: Don't hardcode extension path, rely on extension_dir being correct [vagrant] - 10https://gerrit.wikimedia.org/r/143925 [17:56:48] (03CR) 10Ori.livneh: [C: 032] Don't hardcode extension path, rely on extension_dir being correct [vagrant] - 10https://gerrit.wikimedia.org/r/143925 (owner: 10Chad) [17:56:54] (03Merged) 10jenkins-bot: Don't hardcode extension path, rely on extension_dir being correct [vagrant] - 10https://gerrit.wikimedia.org/r/143925 (owner: 10Chad) [17:58:01] 3Analytics / 3General/Unknown: Route SSL traffic again into webstatscollector's filter process - 10https://bugzilla.wikimedia.org/67456#c2 (10christian) As tomorrow (2014-07-04) is a holiday in the US, today (2014-07-03) is the last working day of this week, and it's bad karma to deploy on the last working d... [17:59:45] 3MediaWiki extensions / 3CentralAuth: Allow global renaming of global users - 10https://bugzilla.wikimedia.org/14862#c44 (10Kunal Mehta (Legoktm)) Code has now been merged into the repository, and has been deployed to beta labs for testing. Please test it there! I'll close this bug once it gets deployed to... [18:00:21] Anyone here that could help me get lua/Scribunto set up locally? [18:00:48] it worked about 6 months ago, not anymore. I've installed lua from homebrew (5.1.5), and configured luaPath and DefaultEngine. [18:01:04] Module's are basically executing on-wiki but getting in a trail loop [18:01:10] in function "chunk" [18:02:00] 3MediaWiki / 3General/Unknown: Extensions missing REL1_23 branches - 10https://bugzilla.wikimedia.org/67270#c20 (10Mark A. Hershberger) (In reply to Bawolff (Brian Wolff) from comment #19) > It's been pointed out to me that this is incorrect, and you can delete > branches from the gerrit interface. People wi... [18:02:10] https://gist.github.com/Krinkle/f616360ba9288052002d#file-scripterror-txt [18:05:18] Trying to use php-luasandbox instead of lua5.1 binaries doesn't seem to be working out either [18:05:25] https://gist.github.com/Krinkle/f616360ba9288052002d#file-03-make-log [18:05:36] LUASANDBOX_VERSION is undefined? [18:06:04] Krinkle: probably my change [18:06:25] I haven't used it locally since December, so just reinstalled [18:06:28] https://gerrit.wikimedia.org/r/#/c/143668/ [18:06:41] sed on osx is different, could be that [18:07:12] Tyring to fix a production breakage on Commons due some gadget, but I'm like 20 levels deep in abstraction shit. I was in javascript a minute ago. Several XMLExport/import and js imports later I find it needs a few Lua modules, so i fetch those and now that isn't wokring [18:07:57] I'll check out revision before that [18:07:58] thx [18:08:16] Krinkle: as a temp workaround just create luasandbox_version.h with content: [18:08:30] #define LUASANDBOX_VERSION "2.0-1" [18:08:37] (03PS1) 10Aaron Schulz: Removed left over bits of --memory option [services/jobrunner] - 10https://gerrit.wikimedia.org/r/143928 [18:08:38] then rerun ./configure && make [18:08:52] i'll fix it more comprehensively now, looking [18:09:22] ori: checking out the revision before yours fatals in a different way [18:09:24] /Users/krinkle/Development/mediawiki/php/luasandbox/luasandbox.c:18:10: fatal error: 'luasandbox_version.h' file not found [18:09:24] #include "luasandbox_version.h" [18:09:36] <^d> I think you need `luajit`, not just `lua` from brew. [18:09:36] Interesting, so it already needed it. How was this installed before? [18:09:37] create it as i indicated [18:09:39] <^d> if memory serves. [18:09:45] Krinkle: the debian rules file created it [18:10:05] ^d: ok, installing that one as well [18:11:12] sed: 1: "0,/^php-luasandbox/{s/p ...": bad flag in substitute command: '}' [18:11:15] stupid osx sed [18:12:06] ori: creating that as luasandbox_version.h didn't help [18:12:33] does it need to load that somehow? [18:14:05] ori: the file is cleared by ./configure I think [18:14:14] I restored it between that and make [18:14:15] worked now [18:18:30] 3MediaWiki-Vagrant: Custom vagrant commands don't run from subdirs - 10https://bugzilla.wikimedia.org/67445#c1 (10Bryan Davis) This have been my experience on OS X with the plugin based system as well. I'm pretty sure this is caused by the changes in Vagrant 1.6 that cause the plugins to be loaded before the c... [18:19:15] 3MediaWiki / 3User login and signup: $wgDefaultUserOptions['rememberpassword'] = 1 stopped working in 1.23 - 10https://bugzilla.wikimedia.org/67133#c4 (10Rohan Rawat) I understand that the user preference was removed. But why can't we repurpose this variable for the login form ? After all, it is still doing... [18:19:45] 3MediaWiki / 3General/Unknown: Extensions missing REL1_23 branches - 10https://bugzilla.wikimedia.org/67270#c21 (10Mark A. Hershberger) Note that after deleting this in gerrit you have to (at least, I had to) completely delete the git directory and check out a fresh copy for the change to show up. [18:23:10] (03CR) 10Brian Wolff: [C: 032] HTMLForm submission callback documentation updates [core] - 10https://gerrit.wikimedia.org/r/143885 (owner: 10Anomie) [18:23:15] 3MediaWiki / 3User login and signup: $wgDefaultUserOptions['rememberpassword'] = 1 stopped working in 1.23 - 10https://bugzilla.wikimedia.org/67133#c5 (10Tyler Romeo) IMO I think this is functionality that we should have, so that leaves us with a couple of options: 1) Make a new global, backport it to 1.23,... [18:26:46] (03Merged) 10jenkins-bot: HTMLForm submission callback documentation updates [core] - 10https://gerrit.wikimedia.org/r/143885 (owner: 10Anomie) [18:27:54] (03PS1) 10Ori.livneh: Make luasandbox_version.h generation work on OS X [php/luasandbox] - 10https://gerrit.wikimedia.org/r/143930 [18:28:07] ^ Krinkle, try that? [18:29:17] ori: works :) [18:29:26] (03CR) 10Krinkle: [C: 031] "no idea what this does but it works :)" [php/luasandbox] - 10https://gerrit.wikimedia.org/r/143930 (owner: 10Ori.livneh) [18:29:30] 3Wikimedia / 3Site requests: 300GB of files on a hard disk in need of a URI or WMF direct upload - 10https://bugzilla.wikimedia.org/67477#c6 (10Sam Reed (reedy)) (In reply to Gilles Dubuc from comment #1) > That's a very good question, as mailing the hard drive would probably be the > most efficient option.... [18:30:00] 3Wikimedia / 3Site requests: 300GB of files on a hard disk in need of a URI or WMF direct upload - 10https://bugzilla.wikimedia.org/67477#c7 (10Sam Reed (reedy)) Fæ, what country are you in? [18:36:54] (03CR) 10Dduvall: "Yurik, after looking into the mentioned bugs further, I don't think they're directly related to the changes in this commit. They are likel" [vagrant] - 10https://gerrit.wikimedia.org/r/143218 (owner: 10Dduvall) [18:40:48] (03CR) 10Yurik: "Sounds good to me, thanks for looking into it!" [vagrant] - 10https://gerrit.wikimedia.org/r/143218 (owner: 10Dduvall) [18:43:45] 3MediaWiki-Vagrant: Custom vagrant commands don't run from subdirs - 10https://bugzilla.wikimedia.org/67445#c2 (10Dan Duvall) It's likely symptomatic of inconsistent initialization of the $DIR global between older versions of Vagrant and 1.6—related to the inconsistent loading of the plugin, as Bryan mentioned... [18:50:18] haha who broke betalabs ? [18:51:06] Error: 1146 Table 'centralauth.renameuser_status' doesn't exist (10.68.16.193) [18:52:20] legoktm: ^^ [18:52:27] uhhhh [18:52:29] oops. [18:52:32] hmm [18:52:33] thedj: CA doesn't work with update.php [18:52:36] one sec [18:52:42] let me figure out how to login to beta labs [18:54:28] bd808: I need to do a schema update on centralauth for beta labs...where I am I supposed to login to? [18:54:58] legoktm: deployment-bastion? [18:55:38] Or just wait for the next run of https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/ [18:55:42] hm, $sql centralauth didn't work [18:55:47] bd808: nope, CA doesn't use update.php [18:55:52] ah [18:56:04] `sql` sitll doesn't work in beta [18:56:31] ok, I'll just grab the passwords from eval.php [18:56:32] PHP Notice: Undefined index: wmgExtraLanguageNames in /mnt/srv/scap-stage-dir/php-master/includes/SiteConfiguration.php on line 305 [18:56:32] btw [18:56:42] (03PS1) 10Anomie: Update GeSHi integration [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/143933 [18:57:32] > echo $wgDBserver; [18:57:32] localhost [18:57:39] I'm guessing that doesn't work with whatever loadbalancer? [18:57:47] blech. We need a better way to track changes to PrivateSettings.php [18:58:10] (03CR) 10Reedy: "Noting this causes a lot of noise on WMF wikis" [core] - 10https://gerrit.wikimedia.org/r/136617 (owner: 10Jackmcbarn) [18:58:24] deployment-db2 I think? [18:59:15] legoktm: sorry, what are you trying to figure out? [18:59:26] where the db server is, but I got it [18:59:48] cool [19:00:01] I created the table on both deployment-db1 and deployment-db2 [19:00:05] thedj: ok, should be fixed now [19:00:28] legoktm: You realise it's supposed to replicate? [19:00:37] oops. [19:00:38] maybe not so readonly [19:02:36] (03PS1) 10Reedy: Revert "Return a TTL when formatting times" [core] - 10https://gerrit.wikimedia.org/r/143935 [19:03:24] (03CR) 10Reedy: "[20:00:50] Optional out param? Yuck" [core] - 10https://gerrit.wikimedia.org/r/143935 (owner: 10Reedy) [19:03:51] (03CR) 10Reedy: "Not sure about reverting this in core, but this exists for a cherry pick for revert in 1.24wmf11 at least..." [core] - 10https://gerrit.wikimedia.org/r/143935 (owner: 10Reedy) [19:05:08] (03PS2) 10Reedy: Revert "Return a TTL when formatting times" [core] - 10https://gerrit.wikimedia.org/r/143935 [19:05:15] (03PS1) 10Reedy: Revert "Return a TTL when formatting times" [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143936 [19:06:05] (03CR) 10Anomie: "Ugh, PHP bugs 40694[1] and 62455[2] strike again." [core] - 10https://gerrit.wikimedia.org/r/136617 (owner: 10Jackmcbarn) [19:06:38] (03CR) 10Reedy: [C: 032] Revert "Return a TTL when formatting times" [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143936 (owner: 10Reedy) [19:06:56] (03PS1) 10Reedy: Revert "Return a TTL when formatting times" [core] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/143937 [19:10:28] (03PS1) 10Jdlrobson: Add tests for ifEquals helper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143943 [19:10:31] (03PS1) 10Jdlrobson: Add tests for Handlebars.prototype methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143944 [19:10:34] (03PS1) 10Jdlrobson: Add tests for Handlebars.prototype.callHelper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143945 [19:11:14] (03Merged) 10jenkins-bot: Revert "Return a TTL when formatting times" [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143936 (owner: 10Reedy) [19:16:44] (03PS1) 10Jdlrobson: Add tests for helper function ifAnonymous [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143983 [19:17:45] 3MediaWiki-Vagrant: Custom vagrant commands don't run from subdirs - 10https://bugzilla.wikimedia.org/67445#c3 (10Ori Livneh) One unfortunate consequence of the subcommands-as-gem approach is that the subcommands are present for vagrant everywhere; they are not scoped to the mediawiki-vagrant directory tree. S... [19:21:01] (03PS1) 10Umherirrender: Use some callable hints on @param docs [core] - 10https://gerrit.wikimedia.org/r/144008 [19:21:29] (03PS2) 10Florianschmidtwelzow: Use mw-ui button in RecentChanges [core] - 10https://gerrit.wikimedia.org/r/143018 (https://bugzilla.wikimedia.org/66373) [19:24:41] (03PS1) 10Umherirrender: Change mixed @param doc for PatrolLog::record [core] - 10https://gerrit.wikimedia.org/r/144027 [19:26:48] (03CR) 10Anomie: "I note that it's only calls that actually pass something for the reference parameter that are affected, so only ParserFunctions and Scribu" [core] - 10https://gerrit.wikimedia.org/r/136617 (owner: 10Jackmcbarn) [19:27:45] 3MediaWiki / 3General/Unknown: Extensions missing REL1_23 branches - 10https://bugzilla.wikimedia.org/67270#c22 (10Kunal Mehta (Legoktm)) 5ASSI>3RESO/FIX (In reply to Mark A. Hershberger from comment #20) > Hrm... the gerrit interface. That would be why this didn't work: > > $ git push origin --delete... [19:28:04] (03PS1) 10Jackmcbarn: Unstub $langObject [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/144031 [19:29:23] (03CR) 10WikidataJenkins: "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/144006 (owner: 10L10n-bot) [19:29:29] (03PS1) 10Umherirrender: Change some mixed @param docs in api classes [core] - 10https://gerrit.wikimedia.org/r/144032 [19:30:27] Nemo_bis: ping? I'm going to guess you're translateadmin on meta? :) Can you setup a translateable page for me? [19:30:36] or... is that right not necessary for such things? [19:31:11] (03PS2) 10Jackmcbarn: Unstub $langObject [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/144031 [19:32:15] 3MediaWiki / 3General/Unknown: Extensions missing REL1_23 branches - 10https://bugzilla.wikimedia.org/67270#c23 (10Kunal Mehta (Legoktm)) Only Elastica updated the -extensions metarepo. Fixing that right now... [19:33:03] YuviPanda: define such things? you can place the tags and I can press a button, yes [19:33:24] (03CR) 10PiRSquared17: [C: 04-1] "I9c7c1326 was merged, abandon this" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/129932 (https://bugzilla.wikimedia.org/5984) (owner: 10Gerrit Patch Uploader) [19:33:31] 3MediaWiki / 3Patrolling: Get rid of $wgEnableNewpagesUserFilter - 10https://bugzilla.wikimedia.org/58932 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX [19:33:44] Nemo_bis: so, 1. copy paste english, 2. add tag around it 3. poke you? [19:33:45] (03Abandoned) 10Legoktm: Add reference list to section preview if missing [extensions/Cite] - 10https://gerrit.wikimedia.org/r/129932 (https://bugzilla.wikimedia.org/5984) (owner: 10Gerrit Patch Uploader) [19:33:51] (03PS1) 10Jackmcbarn: Unstub language objects before calling sprintfDate [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/144034 [19:35:16] 3MediaWiki extensions / 3Translate: uasort() Array was modified by the user comparison function - 10https://bugzilla.wikimedia.org/47524#c3 (10Nemo) Still happening we're told (I suppose line number was truncated): 1 PHP Warning: uasort() [function.uasort]: Array was modified... [19:36:30] 3Wikimedia / 3Site requests: Set $wgLegacyJavaScriptGlobals = false on test wikis - 10https://bugzilla.wikimedia.org/65011#c8 (10Krinkle) Gadget authors have not yet been given a fair chance to migrate their scripts. Disabling this now will needlessly upset users and break actively deployed user applications... [19:37:17] (03CR) 10Jackmcbarn: "I43cdb0a8b2728d0f69a11fd778c6a3ff03487ef3 and I37933fbb44df2038bd81c7aa297e3bead2d3b522 fix the offending code, so I don't think this need" [core] - 10https://gerrit.wikimedia.org/r/143935 (owner: 10Reedy) [19:38:00] 3Wikimedia / 3Site requests: Set $wgLegacyJavaScriptGlobals = false on test wikis - 10https://bugzilla.wikimedia.org/65011#c9 (10Krinkle) Right now we have about a dozen other highly visible migrations going on in the front-end. These legacy globals is not one of them. They haven't been announced very public... [19:39:16] 3MediaWiki / 3JavaScript: Set $wgLegacyJavaScriptGlobals = false by default - 10https://bugzilla.wikimedia.org/33837#c10 (10Krinkle) Update on this front: Gadget authors have not yet been given a fair chance to migrate their scripts. Disabling this now will needlessly upset users and break actively deploye... [19:39:16] 3Wikimedia / 3Site requests: Set $wgLegacyJavaScriptGlobals = false on test wikis - 10https://bugzilla.wikimedia.org/65011#c10 (10Krinkle) Those comments were intended for bug 33837. [19:40:03] (03CR) 10Jackmcbarn: "Workarounds are at I43cdb0a8b2728d0f69a11fd778c6a3ff03487ef3 and I37933fbb44df2038bd81c7aa297e3bead2d3b522" [core] - 10https://gerrit.wikimedia.org/r/136617 (owner: 10Jackmcbarn) [19:40:38] (03PS1) 10Ori.livneh: Update HHVM Puppetization for Apache 2.4 + mod_proxy_fcgi [vagrant] - 10https://gerrit.wikimedia.org/r/144039 [19:41:27] (03PS1) 10Ori.livneh: Lint fix [vagrant] - 10https://gerrit.wikimedia.org/r/144042 [19:41:37] (03CR) 10Ori.livneh: [C: 032] Update HHVM Puppetization for Apache 2.4 + mod_proxy_fcgi [vagrant] - 10https://gerrit.wikimedia.org/r/144039 (owner: 10Ori.livneh) [19:41:44] (03CR) 10Ori.livneh: [C: 032] Lint fix [vagrant] - 10https://gerrit.wikimedia.org/r/144042 (owner: 10Ori.livneh) [19:41:45] 3Wikimedia / 3Site requests: Set $wgLegacyJavaScriptGlobals = false on test2wiki - 10https://bugzilla.wikimedia.org/65011#c11 (10Krinkle) I think disabling it anywhere is ahead of the curve right now (we should do announcements and deprecation first), and that curve has not yet started due to other prioritie... [19:41:46] (03Merged) 10jenkins-bot: Update HHVM Puppetization for Apache 2.4 + mod_proxy_fcgi [vagrant] - 10https://gerrit.wikimedia.org/r/144039 (owner: 10Ori.livneh) [19:41:52] (03Merged) 10jenkins-bot: Lint fix [vagrant] - 10https://gerrit.wikimedia.org/r/144042 (owner: 10Ori.livneh) [19:43:20] (03PS1) 10Ori.livneh: Drop explicit nodejs version requirement from parsoid.pp [vagrant] - 10https://gerrit.wikimedia.org/r/144043 [19:44:56] (03PS1) 10Brian Wolff: Modify $wgUser during the upload media file job [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/144044 [19:45:23] ori, so how do i upgrade vagrant to trusty now? [19:46:52] <^d> Easiest way is to clone the repo fresh and vagrant up. [19:47:01] did the trusty image get merged? [19:47:04] <^d> Yep. [19:47:07] (03PS1) 10IAlex: Don't use isset() to check for null [core] - 10https://gerrit.wikimedia.org/r/144047 [19:48:48] cool [19:49:26] (03CR) 10Anomie: [C: 031] Unstub $langObject (032 comments) [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/144031 (owner: 10Jackmcbarn) [19:52:03] (03CR) 10PleaseStand: "Krinkle, here are the two issues I had described, plus one more, all of which already existed prior to this patch:" [core] - 10https://gerrit.wikimedia.org/r/50140 (https://bugzilla.wikimedia.org/26818) (owner: 10PleaseStand) [19:53:01] 3Datasets / 3Webstatscollector: Visits via alias and canonical namespaces are double counted - 10https://bugzilla.wikimedia.org/67487 (10Nemo) p:5Unprio>3Low [19:53:03] 3Datasets / 3Webstatscollector: Visits via alias and canonical namespaces are double counted - 10https://bugzilla.wikimedia.org/67487 (10Nemo) 3NEW p:3Unprio s:3trivia a:3None Unlike page redirects, the alias namespaces and canonical namespaces cause HTTP redirects to the fullpagename with main/local... [19:53:04] (03CR) 10Anomie: [C: 04-1] "-1 for clarification question, not any code issue." (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/144034 (owner: 10Jackmcbarn) [19:55:00] 3Wikimedia / 3General/Unknown: Report more information about php warnings - 10https://bugzilla.wikimedia.org/43086 (10Sam Reed (reedy)) p:5Normal>3High [19:55:10] (03PS1) 10IAlex: Force array parameters in SiteConfiguration [core] - 10https://gerrit.wikimedia.org/r/144049 [19:55:39] (03PS17) 10Paladox: Update jQuery Cookie to v1.4.1 [core] - 10https://gerrit.wikimedia.org/r/139686 [19:55:51] (03PS37) 10Paladox: Update jquery.hoverintent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [19:56:02] (03CR) 10Anomie: Unstub language objects before calling sprintfDate (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/144034 (owner: 10Jackmcbarn) [19:56:31] 3Wikimedia / 3Site requests: Disable local uploads where unused: some wikis without local file options - 10https://bugzilla.wikimedia.org/67453 (10Nemo) 5RESO/?>3VERI [19:56:31] 3Wikimedia / 3Site requests: Disable local uploads where unused: some wikis without local file options - 10https://bugzilla.wikimedia.org/67453#c3 (10Nemo) 5PATC>3RESO/FIX Merged and deployed three minutes ago, verified working. [19:56:45] (03PS1) 10Ori.livneh: Puppet 3: use scope[key] rather than scope.lookupvar(key) [vagrant] - 10https://gerrit.wikimedia.org/r/144050 [19:56:47] (03PS1) 10Ori.livneh: Remove some Precise compatibility code [vagrant] - 10https://gerrit.wikimedia.org/r/144051 [19:57:15] 3Wikimedia / 3Site requests: Missing namespace ”Book” on ro.wikipedia, although extension is enabled - 10https://bugzilla.wikimedia.org/66530 (10TeleComNasSprVen) 5PATC>3RESO/FIX [20:00:00] 3Wikimedia / 3Site requests: Restore normal bureaucrat permissions where changed without consensus - 10https://bugzilla.wikimedia.org/42105 (10TeleComNasSprVen) 5PATC>3RESO/FIX [20:03:18] (03PS3) 10Jackmcbarn: Unstub $langObject [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/144031 [20:03:31] (03PS1) 10Ori.livneh: parsoid: install nodejs-legacy package for /usr/bin/node symlink [vagrant] - 10https://gerrit.wikimedia.org/r/144052 [20:03:54] (03CR) 10Ori.livneh: [C: 032] Drop explicit nodejs version requirement from parsoid.pp [vagrant] - 10https://gerrit.wikimedia.org/r/144043 (owner: 10Ori.livneh) [20:04:00] (03Merged) 10jenkins-bot: Drop explicit nodejs version requirement from parsoid.pp [vagrant] - 10https://gerrit.wikimedia.org/r/144043 (owner: 10Ori.livneh) [20:04:02] (03CR) 10Ori.livneh: [C: 032] Puppet 3: use scope[key] rather than scope.lookupvar(key) [vagrant] - 10https://gerrit.wikimedia.org/r/144050 (owner: 10Ori.livneh) [20:04:07] (03Merged) 10jenkins-bot: Puppet 3: use scope[key] rather than scope.lookupvar(key) [vagrant] - 10https://gerrit.wikimedia.org/r/144050 (owner: 10Ori.livneh) [20:04:09] (03CR) 10Ori.livneh: [C: 032] Remove some Precise compatibility code [vagrant] - 10https://gerrit.wikimedia.org/r/144051 (owner: 10Ori.livneh) [20:04:14] (03Merged) 10jenkins-bot: Remove some Precise compatibility code [vagrant] - 10https://gerrit.wikimedia.org/r/144051 (owner: 10Ori.livneh) [20:04:18] (03CR) 10Ori.livneh: [C: 032] parsoid: install nodejs-legacy package for /usr/bin/node symlink [vagrant] - 10https://gerrit.wikimedia.org/r/144052 (owner: 10Ori.livneh) [20:04:23] (03Merged) 10jenkins-bot: parsoid: install nodejs-legacy package for /usr/bin/node symlink [vagrant] - 10https://gerrit.wikimedia.org/r/144052 (owner: 10Ori.livneh) [20:08:59] Reedy: were the warnings and such caused by formatDate from job runners? (and is there any information available about them other than the one line warning?) [20:09:06] (03PS9) 10Jforrester: Support different RL sources in OutputPage::makeResourceLoaderLink() [core] - 10https://gerrit.wikimedia.org/r/142766 (owner: 10Legoktm) [20:09:11] (03PS4) 10Jforrester: Add OutputPageScriptsForBottomQueue hook [core] - 10https://gerrit.wikimedia.org/r/141282 (https://bugzilla.wikimedia.org/62602) (owner: 10Legoktm) [20:09:12] There's no more information... [20:09:17] Host maybe [20:10:39] Quick glance at the IP address list suggests it's more than just job runners [20:14:46] 3MediaWiki / 3JavaScript: Set $wgLegacyJavaScriptGlobals = false by default - 10https://bugzilla.wikimedia.org/33837#c11 (10Derk-Jan Hartman) Potentially, we could set this explicitly in Wikimedia config and then flip the DefaultSettings value. If extensions are 'reasonably' clean that is. [20:17:19] superm401: regarding json/jquery.json; Performance isn't of direct influence as both modules reference the browser's native interface directly when available. Performance will improve eventually in terms of javascript load because 'json' is a polyfil with skip load function. [20:17:48] Krinkle, that's what I mean. Modern browsers don't have to load anything. [20:18:01] Because of the skip function and supporting the JSON from ES 5. [20:18:08] (03CR) 10Jackmcbarn: Unstub language objects before calling sprintfDate (032 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/144034 (owner: 10Jackmcbarn) [20:18:28] cool :) [20:19:03] Krinkle, have you ever debugged into phantomjs? [20:19:22] It doesn't quite work for me following https://github.com/ariya/phantomjs/wiki/Troubleshooting [20:19:37] __run doesn't seem to be defined. [20:19:44] It might be a mismatched version of Chrome or something. [20:19:54] I don't debug using that. I just use console instead. Stepping through is too hard given the old webkit engine backing it [20:20:02] If only it were using Chromium or Blink [20:20:07] Maybe in a year or two. [20:20:22] It's basically Safari 3 (yes, 3) on steroids [20:20:49] latest LTS version is 5.1 (new-age Mac OS X), actual latest is 7 I think [20:21:20] It's also not running WebKit like most people think. It runs a port QtWebKit which isn't quite the same code base. [20:21:55] Anyway.. tangent. They're working in PhantomJS 2 and 3 (2 running newer WebKit, and 3 running chromium) [20:22:16] superm401: what're you debugging? async qunit/ [20:22:22] Krinkle, yep. [20:22:27] Didn't know Chromium could be used as a library. [20:22:33] Thought choices there were WebKit or Blink. [20:24:38] whee [20:24:45] 3MediaWiki-Vagrant: Custom vagrant commands don't run from subdirs - 10https://bugzilla.wikimedia.org/67445#c4 (10Yuri Astrakhan) With all the trouble with the custom commands in 1.6+, would it make sense to try to convince Vagrant team to bring back/implement per-project custom command support? [20:25:17] trusty upgrade hosed my MW: 2 minutes to load main page [20:25:47] WFM [20:26:01] Vagrant? [20:26:03] 3MediaWiki / 3Skin and page rendering: style guide Typography page wrong and out-of-date - 10https://bugzilla.wikimedia.org/67490 (10spage) 3NEW p:3Unprio s:3normal a:3None http://tools.wmflabs.org/styleguide/desktop/section-1.html * Doesn't reflect the fonts in our core CSS from which the LSG is ge... [20:26:56] MaxSem, hmm, about to test that. [20:27:01] Okay, back to my meeting. [20:28:27] (03PS1) 10Florianschmidtwelzow: Don't redirect to Special:GoogleLogin from login form [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/144054 [20:28:29] (03CR) 10jenkins-bot: [V: 04-1] Don't redirect to Special:GoogleLogin from login form [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/144054 (owner: 10Florianschmidtwelzow) [20:30:32] (03PS3) 10Florianschmidtwelzow: Move Code from SpecialPage to GoogleLogin [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/143920 (https://bugzilla.wikimedia.org/67219) [20:31:02] (03PS2) 10Florianschmidtwelzow: Don't redirect to Special:GoogleLogin from login form [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/144054 [20:32:02] (03PS1) 10Legoktm: Sync with updated REL1_23 branches in extensions [extensions] - 10https://gerrit.wikimedia.org/r/144055 (https://bugzilla.wikimedia.org/67270) [20:32:29] (03Abandoned) 10Legoktm: Sync with updated REL1_23 branches in extensions [extensions] - 10https://gerrit.wikimedia.org/r/144055 (https://bugzilla.wikimedia.org/67270) (owner: 10Legoktm) [20:32:49] 3Wikimedia / 3Site requests: Set up a clone of wiki.toolserver.org - 10https://bugzilla.wikimedia.org/60222 (10Tim Landscheidt) 5PATC>3NEW [20:33:45] ! [remote rejected] HEAD -> refs/for/REL1_23 (no new changes) [20:33:47] gerrit lies! [20:33:56] (03PS1) 10Legoktm: Sync with updated REL1_23 branches in extensions [extensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/144056 (https://bugzilla.wikimedia.org/67270) [20:34:16] superm401: Blink is much slimmer than WebKit. It doesn't have as much monolithicness in it. Blink can't be booted as a GUI, whereas Webkit was traditionally compilable "WebKit Nightly.app" [20:37:32] (03PS1) 10Jdlrobson: Kill previewButton helper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144057 [20:38:51] Krinkle, yeah, I know a little about the WebKit -> Blink fork. Didn't know that WebKit could be rn as an app, but not Blink. [20:39:19] Krinkle, what do you mean by using Chromium directly, though? Does it just embed part of the browser, or is there some library called Chromium (they already have two things called that, why not one more?) [20:39:30] (03PS2) 10Jdlrobson: Kill previewButton helper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144057 [20:39:35] WebKit still requires a lot of porting and bootstrapping to run cross-platform, but at its core (the repo, not WebKitCore) it was the Safari app stripped down of branding [20:40:02] So back when Chrome ran on WebKit they only used part of it and added lots of layers (not even talking about the UI) [20:40:49] Mm hmm. [20:42:09] (03CR) 10Legoktm: [C: 032 V: 032] Sync with updated REL1_23 branches in extensions [extensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/144056 (https://bugzilla.wikimedia.org/67270) (owner: 10Legoktm) [20:43:24] Krinkle, so will Phantomjs embed part of the Chromium browser, or just Blink, or ...? [20:43:37] Krinkle, for Phantomjs 3 I mean. [20:43:56] 3MediaWiki / 3General/Unknown: Extensions missing REL1_23 branches - 10https://bugzilla.wikimedia.org/67270#c28 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX Cool trick I learned from MatmaRex: $ git submodule foreach "git checkout REL1_23 || :" [20:44:15] 3MediaWiki extensions / 3Semantic MediaWiki: SMW_dumpRDF.php is not executable (1.7.1) - 10https://bugzilla.wikimedia.org/35679#c1 (10[[kgh]]) Addressed with pull request https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/379 [20:45:56] legoktm, yay, congrats for the global rename merge [20:46:03] :) [20:46:12] * Krenair starts renaming legoktm around :P [20:46:24] :< [20:47:01] 3Wikimedia / 3General/Unknown: Report more information about php warnings - 10https://bugzilla.wikimedia.org/43086#c3 (10Bryan Davis) Grabbing stack traces for warnings should be possible with a custom error handler and debug_backtrace() or ErrorException. It should probably be put behind a feature flag of s... [20:48:13] anyone knows off hand what the ID for NS_FILE is? [20:48:35] 6? [20:48:42] 3MediaWiki / 3General/Unknown: Deal with logging query spam on crawler 404 floods - 10https://bugzilla.wikimedia.org/67439#c2 (10Aaron Schulz) Also it might help to route non-user based logging queries to all DBs rather than just db1055 (the partitioning of that table by user is necessary for this query). [20:49:20] YuviPanda: yes 6 https://en.wikipedia.org/wiki/Wikipedia:NS [20:49:25] cool [20:54:26] (03PS7) 10Bsitu: [WIP]Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 [20:55:42] (03CR) 10Anomie: Unstub language objects before calling sprintfDate (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/144034 (owner: 10Jackmcbarn) [20:57:27] (03CR) 10SG: [C: 032] "There's no need for the preview button template at all anymore if you want to do this. Just put the button inline like all the others... t" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144057 (owner: 10Jdlrobson) [20:58:57] (03CR) 10SG: [C: 032] Add tests for helper function ifAnonymous [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143983 (owner: 10Jdlrobson) [21:00:03] (03CR) 10SG: "Strikes me as a strange test. What is this for?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143945 (owner: 10Jdlrobson) [21:01:35] 3MediaWiki / 3General/Unknown: Deal with logging query spam on crawler 404 floods - 10https://bugzilla.wikimedia.org/67439 (10Aaron Schulz) a:3Aaron Schulz [21:01:43] (03PS9) 10Withoutaname: If $wgEnableEmail is false, disable other email settings [core] - 10https://gerrit.wikimedia.org/r/132348 (https://bugzilla.wikimedia.org/63678) [21:01:45] (03CR) 10Florianschmidtwelzow: "I can also imagine to add the functionallity, to add a magnify icon instead of a wrapping link, to core?! :)" [core] - 10https://gerrit.wikimedia.org/r/137690 (https://bugzilla.wikimedia.org/48996) (owner: 10Florianschmidtwelzow) [21:04:03] 3MediaWiki extensions / 3WikidataRepo: Performance review of PubSubHubbub extension - 10https://bugzilla.wikimedia.org/67117 (10Aaron Schulz) a:5Wikidata bugs>3Aaron Schulz [21:05:01] 3MediaWiki extensions / 3WikidataRepo: Performance review of PubSubHubbub extension - 10https://bugzilla.wikimedia.org/67117 (10Sam Reed (reedy)) [21:08:18] (03PS10) 10Withoutaname: If $wgEnableEmail is false, disable other email settings [core] - 10https://gerrit.wikimedia.org/r/132348 (https://bugzilla.wikimedia.org/63678) [21:09:12] ^d, manybubbles, mlitn : hi search experts. CirrusSearch\LinksUpdateJob is asking for Flow pages, which now get a fatal trying to provide a "You are editing but are not logged in" tooltip for this anonymous user. bug 67494 [21:09:27] Do we want CirrusSearch to attempt to get stuff from Flow boards (now with content-type='flow-board')? If not, how should we disable? [21:09:40] * ^d looks [21:11:07] ^d thanks. Flow should be more robust and it's cool CirrusSearch is trying to index... I think :) [21:12:53] <^d> Since you've got your own content type now I could probably tweak the updater to at least do something a tad nicer. [21:13:35] 3MediaWiki-Vagrant: Custom vagrant commands don't run from subdirs - 10https://bugzilla.wikimedia.org/67445#c5 (10Bryan Davis) (In reply to Yuri Astrakhan from comment #4) > With all the trouble with the custom commands in 1.6+, would it make sense > to try to convince Vagrant team to bring back/implement per-... [21:13:35] 3Wikimedia / 3Site requests: Deploy TemplateData's GUI editing tool to English, French and Italian Wikipedias - 10https://bugzilla.wikimedia.org/67376 (10James Forrester) 5PATC>3RESO/FIX [21:13:47] 3MediaWiki extensions / 3WikidataClient: Syncing mechanism via Pubsubhubbub - 10https://bugzilla.wikimedia.org/38970#c6 (10Sam Reed (reedy)) This seems to be essentially re-inventing $wgRCFeeds (and related classes etc). Why? [21:15:32] (03CR) 10Jackmcbarn: Unstub language objects before calling sprintfDate (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/144034 (owner: 10Jackmcbarn) [21:17:31] ^d If it worked presumably Flow boards show up when you search for "You are not logged in. To receive attribution with your name instead of your IP address" 8-) What's the standard way these days to exclude page HTML from webcrawlers ? [21:27:46] 3Wikimedia / 3Site requests: Increase wgQueryCacheLimit from 1000 to 2000 on en.wiki - 10https://bugzilla.wikimedia.org/50979#c2 (10Yuvi Panda) *poke* Adding springle as well. [21:29:18] (03CR) 10Jackmcbarn: Unstub language objects before calling sprintfDate (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/144034 (owner: 10Jackmcbarn) [21:29:23] (03Abandoned) 10Jackmcbarn: Unstub language objects before calling sprintfDate [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/144034 (owner: 10Jackmcbarn) [21:29:27] marxarelli, thx for trying to get vagrant to bring back commands [21:29:34] can we just make a patch for them? [21:29:44] (03PS1) 10BryanDavis: Set session.save_path for php [vagrant] - 10https://gerrit.wikimedia.org/r/144065 [21:29:54] its not like they are against it [21:31:16] 3Wikimedia / 3Site requests: Set up a clone of wiki.toolserver.org - 10https://bugzilla.wikimedia.org/60222#c9 (10Andre Klapper) (In reply to Silke Meyer (WMDE) from comment #7) > What's the status here? Discussion seems to be still going on on bug 60220 [21:32:37] (03CR) 10Ori.livneh: [C: 032] Set session.save_path for php [vagrant] - 10https://gerrit.wikimedia.org/r/144065 (owner: 10BryanDavis) [21:32:42] (03Merged) 10jenkins-bot: Set session.save_path for php [vagrant] - 10https://gerrit.wikimedia.org/r/144065 (owner: 10BryanDavis) [21:33:34] (03PS1) 10Ori.livneh: Update HHVM for Wikimedia's build [vagrant] - 10https://gerrit.wikimedia.org/r/144066 [21:33:44] yurikR: yeah, no problem. i have to make myself seem useful somehow :P [21:34:34] yurikR: re a patch, i may end up doing that [21:34:53] (03CR) 10Mattflaschen: [C: 04-1] "> There may be situations in which adding a glyph to WikiFont" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [21:35:34] 3MediaWiki extensions / 3Babel: Make templates of Babel extension categorize only in user spaces - 10https://bugzilla.wikimedia.org/67334 (10Andre Klapper) [21:37:17] (03CR) 10Ori.livneh: [C: 032] Allow 0 runner loops and added some sanity checks [services/jobrunner] - 10https://gerrit.wikimedia.org/r/143516 (owner: 10Aaron Schulz) [21:37:29] (03CR) 10Ori.livneh: [V: 032] Allow 0 runner loops and added some sanity checks [services/jobrunner] - 10https://gerrit.wikimedia.org/r/143516 (owner: 10Aaron Schulz) [21:37:46] (03CR) 10Mattflaschen: "Also, I forgot to mention this above, but icons would often be moved to WikiFont, if they were e.g. a permanent feature." [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [21:38:48] 3Wikimedia / 3Site requests: Create "suppressredirect" user group on ckb.wikipedia - 10https://bugzilla.wikimedia.org/67278 (10Calak) 5PATC>3RESO/FIX [21:39:16] 3MediaWiki-Vagrant: npm install needs to be run on "vagrant provision" - 10https://bugzilla.wikimedia.org/61502#c2 (10Andre Klapper) hexmode: Can you please answer comment 1? [21:41:29] (03CR) 10Ori.livneh: [C: 032 V: 032] "woops" [services/jobrunner] - 10https://gerrit.wikimedia.org/r/143928 (owner: 10Aaron Schulz) [21:46:38] superm401: we might have to reconvene another day. i have my 1:1 with robla in 15. would tuesday work? [21:47:16] marxarelli, actually, it finally finished. [21:47:23] Do you want to try to do it now? [21:47:32] sure [21:48:19] marxarelli, can you go back to the one from the calendar? [21:48:22] It still works. [21:48:47] 3MediaWiki / 3Parser: Missing whitespaces between words in article's last line on hy.wp - 10https://bugzilla.wikimedia.org/63918#c2 (10Andre Klapper) Can still be seen on https://hy.wikipedia.org/wiki/Շառլ_Թեոդոր_Անրի_դը_Կոստեր Մահացել է 1879 թվականի մայիսի 7-ին, մենակ և կարիքավոր վիճակում։ can be seen i... [21:50:19] 3MediaWiki extensions / 3Scribunto: Frames aren't available outside of functions in modules - 10https://bugzilla.wikimedia.org/67498 (10Jackmcbarn) 3NEW p:3Unprio s:3normal a:3None Create the following as Module:Foo: local p = {} local f = mw.getCurrentFrame() function p.main(frame) return 'Th... [21:51:20] <^d> spagewmf: Ok, I think I've run this bug down a bit. It's more a problem on Cirrus' side than anything. [21:51:34] <^d> I'm calling for a page's ParserOutput before I bother figuring out what kind of page it is. [21:51:44] <^d> If it's not wikitext, we basically discard it anyway. [21:51:51] <^d> I'll try to switch this around. [21:52:05] 3MediaWiki / 3Database: Allow comments longer than 255 bytes - 10https://bugzilla.wikimedia.org/4715#c62 (10Andre Klapper) Greg: Do you have any input on comment 59 (what could be the process here)? (In reply to Bawolff (Brian Wolff) from comment #61) > People in certain scripts complain often about only be... [21:52:35] (03PS1) 10Bsitu: RequestContext->getTitle() is not always available [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144070 [21:52:57] ^d: thanks. Is the fatal screwing up CirrusSearch for other pages? Flow ought to have more bullet-proof code here, so if you want us to do a SWAT patch ^ and there it is :), let me know. [21:53:33] <^d> Probably not. And yeah, it'd be nice to figure out why you end up fatal'ing in Flow there. [21:53:39] <^d> But we can avoid it in Cirrus, which we should. [21:54:08] (03PS1) 10BryanDavis: Stub out heira for puppet [vagrant] - 10https://gerrit.wikimedia.org/r/144071 [21:55:04] <^d> spagewmf: On the upside....the cool thing is that we got this far. Content objects make things Just Work with Cirrus by and large :) [21:56:40] <^d> spagewmf: I'm curious why calling getParserOutput() on your content breaks though :( [21:56:56] ^d yay! View a Flow board gives you HTML FWIW. The fatal is context ->getTitle() doesn't have a getPrefixedUrl(), I'm not sure if CirrusSearch is supposed to have a valid context or if Flow is getting the context wrong, but bsitu's patch checks first. [21:57:41] <^d> We don't care about context all that much beyond our own hooks. [21:58:52] <^d> Ah, I might see it. [21:59:09] <^d> RequestContext::getMain()->getTitle() might not return what you expect when being called from the command line. [21:59:18] <^d> In TemplateHelper::addReturnTo() [22:01:35] <^d> spagewmf: Yep, that's it. [22:01:44] (03PS2) 10Spage: RequestContext->getTitle() is not always available [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144070 (https://bugzilla.wikimedia.org/67494) (owner: 10Bsitu) [22:01:51] (03CR) 10Ori.livneh: [C: 032] "Yep!" [vagrant] - 10https://gerrit.wikimedia.org/r/144071 (owner: 10BryanDavis) [22:01:57] (03Merged) 10jenkins-bot: Stub out heira for puppet [vagrant] - 10https://gerrit.wikimedia.org/r/144071 (owner: 10BryanDavis) [22:02:06] 3MediaWiki / 3Parser: Message handling in parser - 10https://bugzilla.wikimedia.org/17329#c10 (10Andre Klapper) Paul / Tim Starling: > What's the state of this? Has the functionality of the patch been included > in core, or is this a WONTFIX? [22:02:10] 3MediaWiki / 3Skin and page rendering: Implement client-side filtering of tables using javascript - 10https://bugzilla.wikimedia.org/10013#c5 (10Andre Klapper) p:5Normal>3Low a:5Krinkle>3None Krinkle: I am resetting the assignee of this issue to default because there has been no progress in the last... [22:02:10] 3MediaWiki extensions / 3FlaggedRevs: auto promotion not working on trwiki - 10https://bugzilla.wikimedia.org/62577#c5 (10Andre Klapper) 5UNCO>3RESO/WOR Unfortunately closing this report as no further information has been provided. superyetkin: Please feel free to reopen this report if you can provide t... [22:02:10] 3MediaWiki / 3JavaScript: mw.trackSubscribe should prevent infinite recursion - 10https://bugzilla.wikimedia.org/67481#c2 (10Krinkle) a:5Matthew Flaschen>3None The high priority bug was bug 67420 which has been fixed. [22:02:18] 3Wikimedia / 3Site requests: Increase wgQueryCacheLimit from 1000 to 2000 on en.wiki - 10https://bugzilla.wikimedia.org/50979#c3 (10Bawolff (Brian Wolff)) All those queries are generally filesorts and quite expensive. I would be very surprised if the query cache limit had much of an affect on anything perfor... [22:02:18] 3MediaWiki extensions / 3SyntaxHighlight (GeSHi): Error in SyntaxHighlight 1.0.8.11-wmf1: UNIQdbdb3ff6cb672d56-syntaxhighlight-00000001-QINU - 10https://bugzilla.wikimedia.org/60896#c13 (10Andre Klapper) 5UNCO>3RESO/WOR Unfortunately closing this report as no further information has been provided. Hadi:... [22:03:36] 3MediaWiki / 3JavaScript: take over jquery.tipsy plugin - 10https://bugzilla.wikimedia.org/35241#c9 (10Tisza Gergő) Did any work happen in the fork? From the github network graph it seems it is still identical to the original tipsy plugin; there is a semi-maintained fork under https://github.com/CloCkWeRX/ti... [22:04:04] (03CR) 10Chad: [C: 031] "lgtm, will shut up the immediate fatal. Definitely needs some more careful handling so Flow & Cirrus play nice." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144070 (https://bugzilla.wikimedia.org/67494) (owner: 10Bsitu) [22:04:33] 3MediaWiki / 3Patrolling: Moved paged cannot be verified - 10https://bugzilla.wikimedia.org/64254#c5 (10Andyrom75) 5UNCO>3NEW Let me highlight another case. An user has created the following page: https://it.wikivoyage.org/wiki/Lierna and after that he has made few changes. I've moved it to https://it.... [22:05:31] 3MediaWiki extensions / 3[other]: JsonData should pass jshint - 10https://bugzilla.wikimedia.org/61607#c2 (10Andre Klapper) p:5Unprio>3Normal Ah, found it. Looks like RobLa's been the most active committer: https://git.wikimedia.org/log/mediawiki%2Fextensions%2FJsonData.git [22:05:53] 3Utilities / 3mwdumper: error log and restart support - 10https://bugzilla.wikimedia.org/30272#c2 (10Andre Klapper) 5ASSI>3NEW a:5orenbochman>3Brion Vibber orenbochman: I am resetting the assignee of this issue to default because there has been no progress in the last months. Feel free to take it aga... [22:07:02] 3MediaWiki extensions / 3CentralAuth: Do not require globalgrouppermissions or globalgroupmembership rights in global groups to access Special:GlobalGroupPermissions or Special:GlobalGroupMembership - 10https://bugzilla.wikimedia.org/43916#c6 (10PiRSquared17) Why was this requirement even added? I don't see... [22:08:16] 3MediaWiki / 3General/Unknown: Tracking bug (tracking) - 10https://bugzilla.wikimedia.org/2007 (10Tisza Gergő) [22:08:19] 3MediaWiki / 3JavaScript: jquery.tipsy(tracking) - 10https://bugzilla.wikimedia.org/67500 (10Tisza Gergő) 3NEW p:3Unprio s:3normal a:3None Tracking bug for issues with the jquery.tipsy plugin that's part of MediaWiki core. [22:08:38] (03CR) 10Spage: "Needs a phpunit test, but so do other helpers..." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144070 (https://bugzilla.wikimedia.org/67494) (owner: 10Bsitu) [22:08:46] 3MediaWiki / 3JavaScript: jquery.tipsy(tracking) - 10https://bugzilla.wikimedia.org/67500 (10Tisza Gergő) [22:08:46] 3MediaWiki / 3JavaScript: jquery.tipsy should have better triggers for showing and hiding - 10https://bugzilla.wikimedia.org/42584 (10Tisza Gergő) [22:08:51] ^d Thanks. maybe you can comment on the gerrit patch [22:09:08] but it should fix the fatal [22:11:51] (03PS3) 10Mwalker: Adding new format strings for OCG [extensions/Collection] - 10https://gerrit.wikimedia.org/r/139201 [22:12:18] 3MediaWiki / 3JavaScript: RL module jquery.tipsy should provide an option for DOM-parent - 10https://bugzilla.wikimedia.org/41086#c1 (10Tisza Gergő) s:5enhanc>3minor Also a problem with fullscreen; the tooltip container is appended to the body, and in fullscreen mode the element on which requestFullscree... [22:12:18] 3MediaWiki / 3JavaScript: jquery.tipsy(tracking) - 10https://bugzilla.wikimedia.org/67500 (10Tisza Gergő) [22:13:04] 3MediaWiki / 3JavaScript: jquery.tipsy(tracking) - 10https://bugzilla.wikimedia.org/67500 (10Tisza Gergő) [22:13:04] 3MediaWiki / 3JavaScript: [jquery.tipsy] Feature to keep tip active when hovering to and over the tip itself - 10https://bugzilla.wikimedia.org/35212 (10Tisza Gergő) [22:13:29] <^d> spagewmf: I did, I +1'd. [22:13:49] ++ [22:14:46] 3MediaWiki / 3JavaScript: RL module jquery.tipsy should provide an option for DOM-parent - 10https://bugzilla.wikimedia.org/41086#c2 (10Tisza Gergő) There is a pull request for the position:fixed issue: https://github.com/jaz303/tipsy/pull/146 [22:16:31] 3MediaWiki / 3JavaScript: Tipsy is not accessible - 10https://bugzilla.wikimedia.org/63960 (10Tisza Gergő) [22:16:31] 3Analytics / 3Wikimetrics: Story:a WikimetricsUser runs 'Rolling Monthly Active Editors' report - 10https://bugzilla.wikimedia.org/67458 (10Kevin Leduc) [22:16:32] 3MediaWiki / 3JavaScript: jquery.tipsy(tracking) - 10https://bugzilla.wikimedia.org/67500 (10Tisza Gergő) [22:17:00] 3Analytics / 3Wikimetrics: Story:b WikimetricsUser runs 'Rolling New Active Editors' report - 10https://bugzilla.wikimedia.org/67459 (10Kevin Leduc) [22:17:17] 3MediaWiki / 3JavaScript: tipsy can't use string for the title, if original element has non-empty title - 10https://bugzilla.wikimedia.org/57146 (10Tisza Gergő) [22:17:17] 3MediaWiki / 3JavaScript: jquery.tipsy(tracking) - 10https://bugzilla.wikimedia.org/67500 (10Tisza Gergő) [22:17:17] 3Analytics / 3Wikimetrics: Story:c WikimetricsUser runs 'Rolling Surviving New Active Editors' report - 10https://bugzilla.wikimedia.org/67460 (10Kevin Leduc) [22:18:02] Krinkle, seems https://code.google.com/p/chromiumembedded/ is the way to embed. [22:18:22] https://github.com/ariya/phantomjs/issues/10448 [22:18:45] comment https://github.com/ariya/phantomjs/issues/10448#issuecomment-40683651 and the next [22:18:51] 3MediaWiki / 3JavaScript: Load tipsy on page load if any element uses it - 10https://bugzilla.wikimedia.org/54798 (10Tisza Gergő) [22:18:51] 3MediaWiki / 3JavaScript: jquery.tipsy(tracking) - 10https://bugzilla.wikimedia.org/67500 (10Tisza Gergő) [22:19:04] 3Analytics / 3Wikimetrics: Story: AnalyticsEng has Execution Pipeline to optimize/create resusable code for generating metrics - 10https://bugzilla.wikimedia.org/67501 (10Kevin Leduc) 3NEW p:3Unprio s:3enhanc a:3None * (8 points) prep & design meetings, decide how to implement. factors: ** testing d... [22:19:16] 3MediaWiki / 3JavaScript: jquery.tipsy (tracking) - 10https://bugzilla.wikimedia.org/67500 (10Krinkle) [22:19:30] 3Analytics / 3Wikimetrics: Story: AnalyticsEng has Execution Pipeline to optimize/create resusable code for generating metrics - 10https://bugzilla.wikimedia.org/67501 (10Kevin Leduc) p:5Unprio>3Low [22:19:44] legoktm: we should move analytics bugz to -analytics [22:19:48] Krinkle, okay, so PhantomJS 3 is more likely to be QWebEngine, but TBD. [22:20:21] By then our grandchildren will be rocking us in a home [22:20:26] (03PS1) 10Pcoombe: Add rate limiting [extensions/Petition] - 10https://gerrit.wikimedia.org/r/144074 (https://bugzilla.wikimedia.org/65850) [22:20:28] Who knows whether they'll go for Chromium or not [22:21:18] 3Analytics / 3Wikimetrics: Story: AnalyticsEng has Execution Pipeline to optimize/create resusable code for generating metrics - 10https://bugzilla.wikimedia.org/67501#c1 (10Kevin Leduc) This is an alternative approach to implementing stories 67458, 67459, 67460. Cost up front is higher, but then implementin... [22:21:39] "By then our grandchildren will be rocking us in a home" Ha [22:22:31] 3MediaWiki / 3Database: Allow comments longer than 255 bytes - 10https://bugzilla.wikimedia.org/4715#c63 (10Bawolff (Brian Wolff)) (Inreply to Andre Klapper from comment #62) > Greg: Do you have any input on comment 59 (what could be the process here)? > > (In reply to Bawolff (Brian Wolff) from comment #61... [22:23:30] superm401: got done early if you're ready to regroup [22:25:33] (03CR) 10Mattflaschen: "I'm fine with removing mw-ui-primary, as long as it's removed from all WMF-deployed extensions before this is merged." [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [22:25:45] marxarelli, sure, give me a second to get back in. [22:26:03] 3MediaWiki / 3JavaScript: jquery.tipsy (tracking) - 10https://bugzilla.wikimedia.org/67500 (10Tisza Gergő) [22:26:04] 3MediaWiki / 3JavaScript: jquery.tipsy tooltips never disappear on iPad - 10https://bugzilla.wikimedia.org/67503 (10Tisza Gergő) 3NEW p:3Unprio s:3normal a:3None From bug 67320: "The tooltips for the next/previous buttons show up when tapping them on iPad (in desktop view), but don't get hidden." [22:26:33] 3MediaWiki / 3JavaScript: RL module jquery.tipsy should provide an option for DOM-parent - 10https://bugzilla.wikimedia.org/41086 (10Tisza Gergő) [22:26:33] 3MediaWiki / 3Logging: 127.0.0.1, ::1, localhost, loopback, lo0 bugs (tracking) - 10https://bugzilla.wikimedia.org/58272 (10Krinkle) [22:26:33] 3Wikimedia / 3Site requests: Increase wgQueryCacheLimit from 1000 to 2000 on en.wiki - 10https://bugzilla.wikimedia.org/50979#c4 (10Ryan Kaldari) @Bawolff: Does that mean you would be OK with increasing it to 2000 or are you suggestion some other course of action (like getting rid of the limits)? [22:26:35] 3MediaWiki / 3JavaScript: jquery.tipsy tooltips never disappear on iPad - 10https://bugzilla.wikimedia.org/67503 (10Tisza Gergő) [22:26:37] 3Wikimedia / 3Media storage: Recent changes attributes certain uploads on Commons to 127.0.0.1 - 10https://bugzilla.wikimedia.org/67504 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None This seems to be happening again as of today: https://commons.wikimedia.org/wiki/Special:Contributions/127.0.0.1 And b... [22:26:45] 3Wikimedia / 3Media storage: Recent changes attributes certain uploads on Commons to 127.0.0.1 - 10https://bugzilla.wikimedia.org/67504#c1 (10Krinkle) p:5Unprio>3High s:5normal>3major Possibly a recent regression. > User 127.0.0.1 triggered filter ("Prevent massive uploads by brand new users") with... [22:27:15] 3MediaWiki / 3Logging: 127.0.0.1, ::1, localhost, loopback, lo0 bugs (tracking) - 10https://bugzilla.wikimedia.org/58272 (10Krinkle) [22:28:48] (03CR) 10Mwalker: "I fixed the spacing; but I left the names alone. I wasn't sure what you meant siebrand. Did you want to capitalize "word processor" that's" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/139201 (owner: 10Mwalker) [22:32:48] 3MediaWiki / 3JavaScript: jquery.tipsy (tracking) - 10https://bugzilla.wikimedia.org/67500 (10Tisza Gergő) [22:32:48] 3MediaWiki / 3JavaScript: jquery.tipsy tooltip hover events are not debounced - 10https://bugzilla.wikimedia.org/67505 (10Tisza Gergő) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1. set up a tipsy tooltip with delayIn/delayOut settings 2. quickly enter and exit the element's are with the mo... [22:35:46] (03CR) 10Ejegg: "I think __call is missing a 'return'" (031 comment) [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/141595 (owner: 10Awight) [22:36:07] (03CR) 10Jforrester: [C: 031] "Yup, good to go; needs rebasing." [core] - 10https://gerrit.wikimedia.org/r/130525 (owner: 10Jforrester) [22:37:27] (03PS7) 10Mwalker: Massive Rewrite: Promises and better error handling [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/140867 [22:38:15] 3MediaWiki / 3JavaScript: jquery.tipsy (tracking) - 10https://bugzilla.wikimedia.org/67500 (10Tisza Gergő) [22:38:17] 3MediaWiki / 3JavaScript: jquery.tipsy tooltips don't display correctly close to the edge of the sceen - 10https://bugzilla.wikimedia.org/67506 (10Tisza Gergő) 3NEW p:3Unprio s:3normal a:3None In LTR mode, then the tooltip is close to the edge of the screen, the tip points to the wrong place. (The to... [22:47:07] (03PS1) 10Chad: Re-enable page creation for anons by default [vagrant] - 10https://gerrit.wikimedia.org/r/144079 [22:48:21] (03CR) 10Legoktm: "Any updates?" [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/139076 (https://bugzilla.wikimedia.org/49519) (owner: 10Legoktm) [22:48:32] (03CR) 10MaxSem: [C: 032] Re-enable page creation for anons by default [vagrant] - 10https://gerrit.wikimedia.org/r/144079 (owner: 10Chad) [22:48:45] (03Merged) 10jenkins-bot: Re-enable page creation for anons by default [vagrant] - 10https://gerrit.wikimedia.org/r/144079 (owner: 10Chad) [22:50:30] 3MediaWiki extensions / 3DonationInterface: Donate via PayPal from [[wmf:Ways to Give]] says "Please correct the errors in your donation amount" - 10https://bugzilla.wikimedia.org/56657 (10Peter Coombe) 5PATC>3RESO/FIX [22:51:31] 3MediaWiki-Vagrant: Provisioning the math role results in an "unmet dependencies" dpkg error - 10https://bugzilla.wikimedia.org/66807#c4 (10Matthew Flaschen) In the meantime, it's installing texlive-latex-extra-doc, which in Trusty is 309 MB (http://packages.ubuntu.com/trusty/texlive-latex-extra-doc). I can't... [23:03:48] (03PS8) 10Bsitu: [WIP]Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 [23:04:16] 3Wikimedia / 3Media storage: Recent changes attributes certain uploads on Commons to 127.0.0.1 - 10https://bugzilla.wikimedia.org/67504#c2 (10Tisza Gergő) The related filter is https://commons.wikimedia.org/wiki/Special:AbuseFilter/110 (private). The files are uploaded via GWToolset. Presumably the filter us... [23:04:29] (03PS4) 10BryanDavis: Stop setting owner/group on files in /vagrant/settings.d [vagrant] - 10https://gerrit.wikimedia.org/r/142768 (https://bugzilla.wikimedia.org/67231) [23:08:15] (03CR) 10Tim Starling: "I was expecting to see an icon supplied, instead of just stripping all icons so that FB would display nothing." [core] - 10https://gerrit.wikimedia.org/r/108221 (https://bugzilla.wikimedia.org/30113) (owner: 10Westurner) [23:08:26] (03PS3) 10Jdlrobson: Kill previewButton helper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144057 [23:08:34] (03CR) 10Jdlrobson: [C: 032] "cherrypicked" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144057 (owner: 10Jdlrobson) [23:09:00] (03Merged) 10jenkins-bot: Kill previewButton helper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144057 (owner: 10Jdlrobson) [23:09:04] (03PS9) 10Bsitu: [WIP]Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 [23:10:06] (03PS2) 10Jdlrobson: Add tests for helper function ifAnonymous [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143983 [23:10:09] (03PS1) 10Mwalker: Updating VE [core] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/144081 [23:10:16] (03CR) 10Jdlrobson: [C: 032] "cherrypicked to master" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143983 (owner: 10Jdlrobson) [23:10:29] (03CR) 10Mwalker: [C: 032] Updating VE [core] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/144081 (owner: 10Mwalker) [23:11:09] (03CR) 10Jdlrobson: "Just to set the expectation that helpers are currently attached to mw.flow.FlowHandlebars.prototype." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143945 (owner: 10Jdlrobson) [23:11:46] (03Merged) 10jenkins-bot: Add tests for helper function ifAnonymous [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143983 (owner: 10Jdlrobson) [23:14:18] (03PS10) 10Bsitu: [WIP]Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 [23:15:06] (03Merged) 10jenkins-bot: Updating VE [core] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/144081 (owner: 10Mwalker) [23:21:24] kaldari: do you have links to the mobile dabsolver mockup? [23:23:39] (03CR) 10Kaldari: Introduce gallery mode (031 comment) [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/140257 (https://bugzilla.wikimedia.org/66510) (owner: 10MaxSem) [23:35:39] (03CR) 10Krinkle: "Looks good. Need to do some testing, but will merge soon otherwise." [core] - 10https://gerrit.wikimedia.org/r/141282 (https://bugzilla.wikimedia.org/62602) (owner: 10Legoktm) [23:35:46] (03CR) 10Krinkle: Add OutputPageScriptsForBottomQueue hook (031 comment) [core] - 10https://gerrit.wikimedia.org/r/141282 (https://bugzilla.wikimedia.org/62602) (owner: 10Legoktm) [23:36:08] (03PS5) 10Krinkle: Add tests for OutputPage::makeResourceLoaderLink() [core] - 10https://gerrit.wikimedia.org/r/142830 (owner: 10Legoktm) [23:37:57] (03PS2) 10Brian Wolff: Modify $wgUser during the upload media file job [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/144044 (https://bugzilla.wikimedia.org/67504) [23:39:15] (03PS1) 10Aaron Schulz: Fixed broken exception code [core] - 10https://gerrit.wikimedia.org/r/144090 [23:39:28] (03CR) 10Aaron Schulz: [C: 032] Use some callable hints on @param docs [core] - 10https://gerrit.wikimedia.org/r/144008 (owner: 10Umherirrender) [23:40:02] ^d: https://gerrit.wikimedia.org/r/144090 [23:41:32] (03PS2) 10Ori.livneh: Update HHVM for Wikimedia's build [vagrant] - 10https://gerrit.wikimedia.org/r/144066 [23:42:45] (03CR) 10Gergő Tisza: [C: 04-1] Modify $wgUser during the upload media file job (031 comment) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/144044 (https://bugzilla.wikimedia.org/67504) (owner: 10Brian Wolff) [23:44:10] (03Merged) 10jenkins-bot: Use some callable hints on @param docs [core] - 10https://gerrit.wikimedia.org/r/144008 (owner: 10Umherirrender) [23:51:18] (03PS1) 10Bsitu: BOD should be cleared when visiting Flow-enabled talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144093 [23:51:50] (03PS2) 10Bsitu: OBOD should be cleared when visiting Flow-enabled talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/144093 [23:53:17] (03PS5) 10BryanDavis: Stop setting owner/group on files in /vagrant/settings.d [vagrant] - 10https://gerrit.wikimedia.org/r/142768 (https://bugzilla.wikimedia.org/67231) [23:55:06] (03CR) 10BryanDavis: [C: 031] "Applies cleanly on repeated runs of `vagrant provision` and it's less code." [vagrant] - 10https://gerrit.wikimedia.org/r/142768 (https://bugzilla.wikimedia.org/67231) (owner: 10BryanDavis) [23:55:26] (03CR) 10Chad: [C: 032] Fixed broken exception code [core] - 10https://gerrit.wikimedia.org/r/144090 (owner: 10Aaron Schulz) [23:59:14] (03Merged) 10jenkins-bot: Fixed broken exception code [core] - 10https://gerrit.wikimedia.org/r/144090 (owner: 10Aaron Schulz) [23:59:55] (03CR) 10Krinkle: "* Tests are failing for me due to influence by wgWellFormedXml." [core] - 10https://gerrit.wikimedia.org/r/142830 (owner: 10Legoktm)