[00:00:28] Hmm, CirrusSearch didn't like me searching for insource:/[a-d]{5}/ on enwiki very much [00:00:39] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Enable Topic namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143186 (owner: 10EBernhardson) [00:01:24] <^demon|lunch> bawolff: Howso? [00:01:35] It timed out [00:01:58] <^demon|lunch> Aww :( [00:02:04] "An error has occurred while searching: We could not complete your search due to a temporary problem. Please try again later. [00:02:35] Which is to kind of be expected. There are very few words made up of precisely 5 letters between a-d, and enwiki is a large corpus to go through [00:02:51] <^demon|lunch> Results 1–51 of 2,884 for insource:/[a-d]{5}/ [00:02:55] <^demon|lunch> Got it to work :) [00:03:14] <^demon|lunch> Oh, content pages. Did you do all namespaces? [00:03:24] (03PS1) 10Krinkle: documentation-sync: Remove trailing slash in src parameters [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/143206 [00:03:44] Results 1–51 of 3,638 for insource:/[a-d]{5}/ [00:03:53] why is the number different D: [00:03:55] (03CR) 10Krinkle: [C: 032] "Affects oojs-core-jsduck-publish and oojs-ui-jsduck-publish." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/143206 (owner: 10Krinkle) [00:04:18] (i searched "Content pages", the default) [00:04:31] I searched article, mediawiki and mediawiki_talk [00:04:46] appearently i set that to my default once upon a time [00:05:00] <^demon|lunch> That's kind of a silly default. [00:05:10] err. article, mediawiki_talk and template_talk [00:05:21] <^demon|lunch> And it'll span content/general indexes. That doesn't surprise me it's a tad slow. [00:05:30] <^demon|lunch> MatmaRex: mt_rand()? :p [00:05:37] why would I set it to that. That's a very silly default [00:05:56] (03Merged) 10jenkins-bot: documentation-sync: Remove trailing slash in src parameters [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/143206 (owner: 10Krinkle) [00:05:59] (03PS1) 10Withoutaname: Remove MWInit class file Init.php [core] - 10https://gerrit.wikimedia.org/r/143207 [00:06:06] yep, works better on content pages [00:07:42] hmm. "insource:/\b[a-d]{5}\b/" apparently times out, though [00:07:53] which regex flavor does this use, anyway? [00:08:02] http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/query-dsl-regexp-query.html#regexp-syntax [00:08:19] (03CR) 10Worden.lee: "I did it that way because that's the way the code is already written, and this patch isn't about redesigning that aspect of the code. Act" [core] - 10https://gerrit.wikimedia.org/r/67173 (https://bugzilla.wikimedia.org/48581) (owner: 10Worden.lee) [00:08:36] (03CR) 10Hoo man: [C: 04-1] "Wikibase (and probably other extensions) use this still :/" [core] - 10https://gerrit.wikimedia.org/r/143207 (owner: 10Withoutaname) [00:09:08] okay, no \b then [00:09:15] * bawolff suspects its doing regex on per word, not the entire document (?) [00:10:40] oh, maybe not [00:11:39] I could definitely see this feature being useful. e.g. queries like insource:"" [00:12:21] 3MediaWiki / 3Skin and page rendering: Use mediawiki.ui Constructive style button for [Save] in preferences - 10https://bugzilla.wikimedia.org/65317#c2 (10Jared Zimmerman (WMF)) WhatamIdoing, the rationale for Update Preferences is that in mediawiki.ui we're trying to have more specific action buttons that a... [00:13:54] ^demon|lunch: Hmm insource:"" doesn't seem to work like I expect it to (a bunch of pages without a in them come up) [00:14:51] <^demon|lunch> Bahhh! [00:14:55] <^demon|lunch> I know what I did. [00:14:59] <^demon|lunch> I stripped <> probably. [00:15:52] 3Wikimedia / 3Extension setup: Review & deploy mediawiki/extensions/FundraisingChart - 10https://bugzilla.wikimedia.org/65834#c4 (10Sherah Smith) (In reply to Sam Reed (reedy) from comment #3) > Where is the extension destined to be deployed? Sorry, collab and meta [00:17:17] (03PS1) 10Withoutaname: Subclass the Action class under ContextSource [core] - 10https://gerrit.wikimedia.org/r/143211 [00:17:34] <^demon|lunch> Or not. [00:17:35] <^demon|lunch> Hmm. [00:19:27] (03PS13) 10Aaron Schulz: Improved DB handling in LCStoreDB [core] - 10https://gerrit.wikimedia.org/r/138740 [00:22:54] (03PS1) 10Isarra: Update to use setSkin and ignore capitalisation [extensions/SkinPerPage] (REL1_22) - 10https://gerrit.wikimedia.org/r/143213 [00:23:17] (03PS1) 10Jdlrobson: Design changes for moderated posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143214 [00:23:30] (03PS1) 10Isarra: Update to use setSkin and ignore capitalisation [extensions/SkinPerPage] (REL1_23) - 10https://gerrit.wikimedia.org/r/143215 [00:23:59] (03CR) 10Legoktm: [C: 032] Update to use setSkin and ignore capitalisation [extensions/SkinPerPage] (REL1_23) - 10https://gerrit.wikimedia.org/r/143215 (owner: 10Isarra) [00:24:02] (03CR) 10Legoktm: [C: 032] Update to use setSkin and ignore capitalisation [extensions/SkinPerPage] (REL1_22) - 10https://gerrit.wikimedia.org/r/143213 (owner: 10Isarra) [00:24:06] (03Merged) 10jenkins-bot: Update to use setSkin and ignore capitalisation [extensions/SkinPerPage] (REL1_23) - 10https://gerrit.wikimedia.org/r/143215 (owner: 10Isarra) [00:24:09] (03Merged) 10jenkins-bot: Update to use setSkin and ignore capitalisation [extensions/SkinPerPage] (REL1_22) - 10https://gerrit.wikimedia.org/r/143213 (owner: 10Isarra) [00:24:39] (03PS2) 10Withoutaname: Subclass the Action class under ContextSource [core] - 10https://gerrit.wikimedia.org/r/143211 [00:24:42] (03CR) 10Krinkle: "I was referring to the commit subject line which is still not describing what this commit changes." [core] - 10https://gerrit.wikimedia.org/r/135545 (https://bugzilla.wikimedia.org/65158) (owner: 10Scnd) [00:27:55] (03PS1) 10Legoktm: Whitelist Isarra [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/143216 [00:28:23] (03CR) 10Bartosz Dziewoński: [C: 031] Whitelist Isarra [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/143216 (owner: 10Legoktm) [00:30:03] (03CR) 10Brian Wolff: "Change itself looks fine. I agree with Krinkle that the commit message should be more descriptive." [core] - 10https://gerrit.wikimedia.org/r/135545 (https://bugzilla.wikimedia.org/65158) (owner: 10Scnd) [00:30:09] 3MediaWiki extensions / 3SemanticForms: Numeric fields with commas causing errors - 10https://bugzilla.wikimedia.org/67339 (10John McClure) 3NEW p:3Unprio s:3normal a:3Yaron Koren Testing simple numeric field entries yields these results: 1. 1234567 - no error 2. 123,456 - no error 3. 1,234,567 = "m... [00:30:36] (03PS1) 10Dduvall: Setup script for easier installation and configuration [vagrant] - 10https://gerrit.wikimedia.org/r/143218 [00:34:45] (03PS1) 10Reedy: Make replaceInternal return the colours array [core] - 10https://gerrit.wikimedia.org/r/143220 [00:37:06] 3MediaWiki / 3Database: FlaggablePageTest::testPageDataFromTitle: SqlBagOStuff::set: Flushing an explicit transaction, getting out of sync! [Called from DatabaseBase::commit in ... - 10https://bugzilla.wikimedia.org/61848 (10Aaron Schulz) [00:40:06] (03CR) 10Chad: [C: 032] Improved DB handling in LCStoreDB [core] - 10https://gerrit.wikimedia.org/r/138740 (owner: 10Aaron Schulz) [00:40:40] (03PS1) 10Reedy: Function type hints for LinkHolderArray.php [core] - 10https://gerrit.wikimedia.org/r/143221 [00:43:18] (03Merged) 10jenkins-bot: Improved DB handling in LCStoreDB [core] - 10https://gerrit.wikimedia.org/r/138740 (owner: 10Aaron Schulz) [00:44:49] (03PS1) 10Reedy: De-duplicate pages in replaceInternal [core] - 10https://gerrit.wikimedia.org/r/143222 [00:45:43] (03CR) 10Reedy: "Prevents queries like:" [core] - 10https://gerrit.wikimedia.org/r/143222 (owner: 10Reedy) [00:45:53] 3MediaWiki / 3ResourceLoader: Investigate embedding some data URLs without base 64 - 10https://bugzilla.wikimedia.org/67341 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None Bartosz suggested that we look into using data URLs without base 64. An example is http://jsfiddle.net/SJjJb/1332/ , a tex... [00:46:07] 3MediaWiki / 3ResourceLoader: Investigate embedding some data URLs without base 64 - 10https://bugzilla.wikimedia.org/67341 (10Matthew Flaschen) s:5normal>3enhanc [00:49:43] (03CR) 10Reedy: "mysql only returns one row anyway.." [core] - 10https://gerrit.wikimedia.org/r/143222 (owner: 10Reedy) [00:52:51] 3MediaWiki / 3ResourceLoader: CSSMin::encodeImageAsDataUR I() should be smarter about SVG images (tracking) - 10https://bugzilla.wikimedia.org/57777#c4 (10Matthew Flaschen) 5PATC>3NEW Splitting this into two things: * Optimizing SVGs (bug 34812) * Whether to use base 64 (bug 67341) [00:55:33] (03CR) 10Mattflaschen: "I made that bug a tracking bug, and there are now two bugs, bug 34812 (minification of SVG) and bug 67341." [core] - 10https://gerrit.wikimedia.org/r/116490 (https://bugzilla.wikimedia.org/57777) (owner: 10Deepali) [00:56:07] 3MediaWiki / 3General/Unknown: Tracking bug (tracking) - 10https://bugzilla.wikimedia.org/2007 (10Matthew Flaschen) [00:56:07] 3MediaWiki / 3ResourceLoader: CSSMin::encodeImageAsDataURI() should be smarter about SVG images (tracking) - 10https://bugzilla.wikimedia.org/57777 (10Matthew Flaschen) [00:57:53] 3MediaWiki extensions / 3Scribunto: Scribunto fetchLanguageName tests fail if CLDR is not installed - 10https://bugzilla.wikimedia.org/67343 (10Tim Starling) 3NEW p:3Unprio s:3normal a:3None 6 Scribunto PHPUnit tests fail if CLDR is not installed. These tests should be skipped instead. On the Lua s... [01:05:01] (03CR) 10Bartosz Dziewoński: "I've reviewed the code very quickly and only noticed one function in upload.js that takes a 'id' parameter." [core] - 10https://gerrit.wikimedia.org/r/67173 (https://bugzilla.wikimedia.org/48581) (owner: 10Worden.lee) [01:05:23] (03CR) 10Chad: [C: 032] Default entry point for StrategyWiki [extensions/StrategyWiki] - 10https://gerrit.wikimedia.org/r/143005 (owner: 10Hashar) [01:05:29] (03Merged) 10jenkins-bot: Default entry point for StrategyWiki [extensions/StrategyWiki] - 10https://gerrit.wikimedia.org/r/143005 (owner: 10Hashar) [01:06:34] (03CR) 10Bartosz Dziewoński: "(This patch needs a manual rebase, too.)" [core] - 10https://gerrit.wikimedia.org/r/67173 (https://bugzilla.wikimedia.org/48581) (owner: 10Worden.lee) [01:13:21] 3MediaWiki / 3Skin and page rendering: Use mediawiki.ui Constructive style button for [Save] in preferences - 10https://bugzilla.wikimedia.org/65317#c3 (10Matthew Flaschen) "Restore default preferences" seems like a perfect mw-ui-destructive. It erases *all* your preferences and (unlike most on-wiki actions... [01:13:40] (03PS1) 10Withoutaname: Add deprecation methods to object methods in Article.php [core] - 10https://gerrit.wikimedia.org/r/143230 [01:14:06] 3MediaWiki / 3Skin and page rendering: Use mediawiki.ui Constructive style button for [Save] in preferences - 10https://bugzilla.wikimedia.org/65317#c4 (10Matthew Flaschen) Also, "in all sections" is verbose, but that should be conveyed somehow if possible (otherwise, people might think it was only the curre... [01:14:30] (03CR) 10Ori.livneh: [C: 031] De-duplicate pages in replaceInternal [core] - 10https://gerrit.wikimedia.org/r/143222 (owner: 10Reedy) [01:20:55] 3Wikimedia / 3Site requests: GWToolset additional domain - 10https://bugzilla.wikimedia.org/67344 (10Ayaita) 3UNCO p:3Unprio s:3normal a:3None please add the following domain(s) to the wgCopyUploadsDomains whitelist: This is an example: https://www.dropbox.com/sh/qziqxh4fs2id69d/AACf_EBbByO6-GeoZb... [01:31:20] (03CR) 10Withoutaname: "How about "If you have PHP's register_globals option set up, you should turn it off. MediaWiki will work with it on, but your server is ex" [core] - 10https://gerrit.wikimedia.org/r/142814 (owner: 10Withoutaname) [01:32:22] 3MediaWiki extensions / 3Scribunto: Lua error, interpreter exited with status 2. - 10https://bugzilla.wikimedia.org/48877#c13 (10Mark Redekop) For me it was an executable permission issue [01:47:06] (03PS1) 10Withoutaname: Change User::isIP() to an alias calling IP::isIPAddress() [core] - 10https://gerrit.wikimedia.org/r/143234 [01:50:34] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This is obviously not correct per the comment on the method." [core] - 10https://gerrit.wikimedia.org/r/143234 (owner: 10Withoutaname) [02:01:31] (03CR) 10Withoutaname: "Doesnt' the IP class already do validation with the regexes to see if it's properly in the 0-255 range?" [core] - 10https://gerrit.wikimedia.org/r/143234 (owner: 10Withoutaname) [02:11:22] (03PS50) 10Legoktm: Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (https://bugzilla.wikimedia.org/14862) [02:15:09] hoo: ping [02:15:21] yes? [02:16:39] legoktm: ^ [02:16:46] * legoktm is typing [02:17:01] ah [02:17:25] I undid your change which checked for empty( $this->mBeingRenamed ), and tracked down why sometimes it was null, it wasn't being set for non-global users, causing it to get cached as null...but after talking with Chris, we split out the query to renameuser_status so it's no longer using a join, so it'll work if someone calls new CentralAuthUser( $oldName )->renameInProgress() [02:17:41] and it gets cached properly now as an empty string [02:17:46] Already saw that and rebased my stuff on top of PS49 [02:17:52] awesome [02:17:57] rebasing on top of PS50 now [02:18:04] PS50 was just removing stuff from $select that I forgot in PS49 [02:18:25] Yeah... but still need to go through all the hassle to make gerrit happy [02:18:31] :| [02:18:43] also, I'm setting up a small CA farm with globalrenameuser installed, so we can get people to test it and hopefully find bugs [02:18:49] (on labs) [02:18:57] +1 [02:18:58] :) [02:21:04] Is it going live on July 1? [02:21:17] no, it's been pushed back [02:21:29] RIP. [02:21:30] legoktm: Will upload my patch tomorrow... only thing that's still bugging me is the logging, guess I'll make an own class for also [02:21:41] MediaWiki sucks so hard sometimes :/ [02:21:48] logging to Special:Log? [02:22:11] Yeah :P That's the last bit I haven't managed to refactor before I found the bug we fixed today [02:23:16] 4am, going to bed now [02:23:24] See you tomorrow ;) [02:26:09] gnite [02:31:14] why do redirects to special pages not work on enwiki, but they work fine on my test installation? [02:31:55] Did you futz with DisableHardRedirects or whatever? [02:32:07] There's a setting somewhere. [02:32:38] yeah, that's it. it's off by default but on for wmf wikis, not sure why [02:33:56] * jackmcbarn git blames [02:48:58] (03PS2) 10Jamesmontalvo3: Make AdminLinks installable via Composer [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/142763 [02:51:18] (03PS3) 10Jamesmontalvo3: Make AdminLinks installable via Composer [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/142763 [02:53:02] (03CR) 10Jamesmontalvo3: "Updated name in composer.json to final "mediawiki/admin-links"" [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/142763 (owner: 10Jamesmontalvo3) [03:06:11] (03CR) 10Springle: [C: 031] Supports sqlite [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/143023 (https://bugzilla.wikimedia.org/67297) (owner: 10Hashar) [03:09:07] (03CR) 10Springle: [C: 031] Sqlite compatibility [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/143014 (https://bugzilla.wikimedia.org/65877) (owner: 10Hashar) [03:09:37] 3Wikimedia / 3Site requests: GWToolset additional domain - 10https://bugzilla.wikimedia.org/67344#c1 (10This, that and the other) What? Dropbox? We're not going to add that. What exactly do you want this for? [03:09:58] (03CR) 10Springle: [C: 031] Sqlite compatibility [extensions/CommunityVoice] - 10https://gerrit.wikimedia.org/r/143012 (https://bugzilla.wikimedia.org/65876) (owner: 10Hashar) [03:10:27] (03CR) 10Springle: [C: 031] Sqlite compatibility [extensions/AccountAudit] - 10https://gerrit.wikimedia.org/r/143011 (https://bugzilla.wikimedia.org/65875) (owner: 10Hashar) [03:18:31] (03CR) 1020after4: [C: 031] Setup script for easier installation and configuration [vagrant] - 10https://gerrit.wikimedia.org/r/143218 (owner: 10Dduvall) [03:29:21] 3Wikimedia / 3Site requests: GWToolset additional domain - 10https://bugzilla.wikimedia.org/67344#c2 (10Ayaita) Why do you want to know if you are already saying you are not adding it? I am not a super tech savvy user and don't know what you mean by "what? Dropbox?" I am trying to use the GWToolset to mas... [03:29:22] (03CR) 10Legoktm: "PS48: Chris updated the AbortLogin hook based on his earlier comment. It now adds a query to master on login, but that is rare (compared t" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (https://bugzilla.wikimedia.org/14862) (owner: 10Legoktm) [03:30:13] James_F: https://github.com/wikimedia/labs-tools-pywikibugs/pull/3 [03:30:30] greg-g: uh, that's a gerrit repo. [03:30:38] you just submitted a pr to the mirror :P [03:30:39] (03PS2) 10Welterkj: Add README.md and RELEASE-NOTES.md. [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/142704 [03:30:43] then why did he link to a github repo! [03:30:47] grrr [03:30:51] legoktm: Wait, it is? I thought you were doing them on github still? [03:31:02] * James_F put in two PRs earlier today. [03:31:05] :) [03:31:12] … [03:31:16] Except they're not there? [03:31:25] no, valhallasw moved it [03:31:33] Bah. [03:31:59] Oh, and GitHub doesn't create PRs for you despite suggesting it will? [03:32:10] I cannot explain just how much I loathe GitHub. [03:32:21] pro-tip: https://github.com/wikimedia/labs-tools-pywikibugs says at the top "Github mirror of "labs/tools/pywikibugs" - our actual code is hosted with Gerrit" [03:32:24] I cannot explain just how much I loathe gerrit. [03:32:37] legoktm: :P :P :P :P [03:32:56] legoktm: Sure, but I linked to https://github.com/wikimedia/labs-tools-pywikibugs/blob/master/channels.py which doesn't. [03:33:16] wctaiwan: My sympathies. [03:33:31] legoktm: So I struggled through using the stupid mess that is GitHub pointlessly? [03:33:32] * James_F sighs. [03:33:44] James_F: :P [03:33:51] greg-g: I did https://github.com/jdforrester/labs-tools-pywikibugs/compare/patch-1 BTW. [03:33:57] you can use gerrit-patch-uploader to easily convert them in to gerrit requests. [03:33:57] * James_F will trans-repo instead. [03:33:58] grr... php... what is a conclusive test that will say if a mixed value $x will be considered as an integer by PHP? It seems it can either be is_bool() || is_int() || (is_string() && ctype_digit()) [03:34:03] legoktm: That's ever worse. [03:34:09] To be fair, it's better now that I'm submitting patches for small bits of work rather than one giant changeset with 10 feature changes and 40 patchsets.. [03:34:10] legoktm: but then I don't get the credit, right? [03:34:10] Err. Even. [03:34:21] greg-g: you do if you type in your email properly [03:34:33] (03CR) 10Welterkj: [C: 032] Add README.md and RELEASE-NOTES.md. [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/142704 (owner: 10Welterkj) [03:34:35] owner:greg-g won't work, but git blame will [03:34:38] (03Merged) 10jenkins-bot: Add README.md and RELEASE-NOTES.md. [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/142704 (owner: 10Welterkj) [03:34:42] James_F: hah! slightly different, you followed multimedia's style [03:34:57] greg-g: I actually made half that file, so… [03:35:07] 3Wikimedia / 3Site requests: GWToolset additional domain - 10https://bugzilla.wikimedia.org/67344#c3 (10jeremyb) You'll need to find some other place to upload to. A good option may be an amazon s3 bucket. It needs a dedicated domain name that no other user can upload content to. Or else why even bother mai... [03:35:14] greg-g: I believe I followed my own style which I also implemented for Multimedia. :-) [03:35:46] yurikR2: I wonder if you can somehow cast it first and compare the cast value against the original, or something... [03:38:33] wctaiwan, (int)null is a 0 :( [03:38:56] but array( null=>'x' ) is array( ''=>'x' ) [03:39:06] :/ [03:39:07] DAMN you php! [03:39:27] dynamic typing ftl >.> [03:39:52] 3Wikimedia / 3Site requests: GWToolset additional domain - 10https://bugzilla.wikimedia.org/67344#c4 (10jeremyb) Anyway, also answer the other question. What is this for? Ate you uploading on behalf of an organization? Which one? What is the source of these images? Did you take them yourself? [03:40:04] James_F: fine :P [03:41:34] James_F: so, I can do my gerrit patch, doing it now... [03:41:44] if you haven't already (I don't see it under your name yet) [03:41:55] I'm waiting for git review to send. [03:42:21] bah [03:42:25] Done. [03:42:45] Also, I don't hang out in -labs so I don't see these. Boo. [03:45:51] 3Wikimedia / 3Site requests: GWToolset additional domain - 10https://bugzilla.wikimedia.org/67344#c5 (10Ayaita) It's an institutional project, and the pictures are from different institutions that have released them with CC-BY and CC-BY-SA. We are still working on the templates but it's more or less describe... [03:47:10] 3MediaWiki extensions / 3Babel: Babel extension categories in Spanish - 10https://bugzilla.wikimedia.org/67346 (10Metrónomo) 3UNCO p:3Unprio s:3normal a:3None Languages Babel, correct names in Spanish: * code -- actual -- correct * ace -- acehnés -- achenés ("acehnés" is wrong) * als -- Alemannisch... [03:48:21] 3Wikimedia / 3Site requests: GWToolset additional domain - 10https://bugzilla.wikimedia.org/67344#c6 (10Ayaita) Once I use the s3 bucket, do I need to fill another bug report to add the domain from s3bucket to the white list? [03:50:06] 3Wikimedia / 3Site requests: GWToolset additional domain - 10https://bugzilla.wikimedia.org/67344#c7 (10jeremyb) Just comment on this bug with the bucket's name/domain. [03:55:42] 3Wikimedia / 3Site requests: GWToolset additional domain - 10https://bugzilla.wikimedia.org/67344#c8 (10Ayaita) thanks, will do [04:02:41] (03PS1) 10Isarra: Added parserfunction, 'useskin', for consistency with other functions [extensions/SkinPerPage] - 10https://gerrit.wikimedia.org/r/143242 [04:09:51] 3Wikimedia / 3General/Unknown: Migrate to SUL all non-clashing accounts - 10https://bugzilla.wikimedia.org/39817#c5 (10Kunal Mehta (Legoktm)) Note to self, query to get users who only exist on one wiki and don't have a global account: SELECT ln_name FROM localnames LEFT JOIN globaluser ON gu_name=ln_name W... [04:25:36] 3Wikimedia / 3General/Unknown: Migrate to SUL all non-clashing accounts - 10https://bugzilla.wikimedia.org/39817#c6 (10Kunal Mehta (Legoktm)) Nemo: Is there a reason bug 54760 should be a blocker to this? Since these user's usernames won't be changing, I don't see a reason to email them? [04:33:08] (03CR) 10BryanDavis: "One trivial issue with a duplicate setting definition. Seemed to work as expected for me on OS X 10.8.5 with Vagrant 1.6.3." (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/143218 (owner: 10Dduvall) [04:46:51] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Unit tests trigger notices in MobileFrontend - 10https://bugzilla.wikimedia.org/67139#c4 (10James Forrester) s:5normal>3minor This is another false positive issue, because MobileFrontend and BetaFeatures can't run at the same time (Mobile doesn't use i... [04:51:41] (03PS1) 10Legoktm: Don't send attach entries to RC if from a maintenance script [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143243 [04:54:36] (03CR) 10BryanDavis: "Constants from base.pp are preferred over literal values for setting priority." (033 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/142832 (owner: 10Yurik) [05:01:39] (03CR) 10Yurik: "thx, didn't know we had them. Many files contain constants - e.g. settings.pp in the description of priority - we should probably update t" (033 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/142832 (owner: 10Yurik) [05:01:44] (03PS3) 10Yurik: Added jsonconfig & zero roles [vagrant] - 10https://gerrit.wikimedia.org/r/142832 [05:01:55] bd808|BUFFER, thx, ^ [05:30:18] Anyone know why this is happening? [05:30:28] Dan-Garry:android-wikipedia dgarry$ git review [05:30:29] Could not connect to gerrit. [05:30:36] 3MediaWiki / 3General/Unknown: Update branches in mediawiki/extensions/* for REL1_23 - 10https://bugzilla.wikimedia.org/64157 (10Kunal Mehta (Legoktm)) [05:30:38] 3MediaWiki / 3General/Unknown: Extensions missing REL1_23 branches - 10https://bugzilla.wikimedia.org/67270#c2 (10Kunal Mehta (Legoktm)) s:5normal>3major I wrote a simple script to query the Github API. Here's the list: mediawiki-extensions-Diagnosis is missing REL1_23! mediawiki-extensions-PageCredit i... [05:30:38] 3MediaWiki / 3General/Unknown: Extensions missing REL1_23 branches - 10https://bugzilla.wikimedia.org/67270 (10Kunal Mehta (Legoktm)) [05:30:38] 3Wikimedia / 3General/Unknown: Migrate to SUL all non-clashing accounts - 10https://bugzilla.wikimedia.org/39817#c7 (10Nemo) (In reply to Kunal Mehta (Legoktm) from comment #6) > Nemo: Is there a reason bug 54760 should be a blocker to this? Since these > user's usernames won't be changing, I don't see a rea... [05:30:45] Enter your gerrit username: deskana [05:30:46] Trying again with ssh://deskana@gerrit.wikimedia.org:29418/apps/android/wikipedia.git [05:30:46] [05:30:47] We don't know where your gerrit is. Please manually create a remote [05:30:49] named "gerrit" and try again. [05:30:55] Deskana: paste the output of $ git remote [05:30:55] ? [05:31:06] Dan-Garry:android-wikipedia dgarry$ git remote [05:31:06] origin [05:31:56] try [05:32:08] Exception: Could not connect to gerrit at ssh://deskana@gerrit.wikimedia.org:29418/apps/android/wikipedia.git [05:32:09] $ git remote add gerrit ssh://deskana@gerrit.wikimedia.org:29418/apps/android/wikipedia.git [05:32:44] legoktm: No output from that, so I guess it worked. Trying git review again. [05:33:06] er [05:33:09] now try $ git push gerrit HEAD:refs/for/master [05:33:16] (assuming you're pushing to master) [05:33:39] Dan-Garry:android-wikipedia dgarry$ git review [05:33:40] Problem running 'git remote update gerrit' [05:33:40] Fetching gerrit [05:33:41] Permission denied (publickey). [05:33:43] ssh_exchange_identification: Connection closed by remote host [05:33:45] fatal: Could not read from remote repository. [05:33:47] Hmm, well. [05:35:19] yeah, it's a public key issue. [05:35:33] try clearing your ssh-agent [05:35:54] Deskana: run $ ssh-agent -D [05:35:56] and then try again [05:36:35] ssh-agent: illegal option -- D [05:36:36] :P [05:37:13] wait, are you on OSX? [05:37:17] Yes. [05:37:38] oh [05:37:42] $ ssh-add -D [05:37:51] * legoktm read it wrong [05:37:59] Nope. [05:38:11] Dan-Garry:android-wikipedia dgarry$ git review [05:38:11] Problem running 'git remote update gerrit' [05:38:12] Fetching gerrit [05:38:14] Permission denied (publickey). [05:38:33] ls ~/.ssh [05:38:38] check your public key is still there? [05:38:57] It is, but it's one of two. I think the information that I got on how to have two public keys at once was wrong. [05:38:58] dunno after that. [05:40:22] try running $ ssh-add path/to/gerrit/key ? [05:41:12] Identity added [05:41:13] And now... [05:41:28] ----------------------- [05:41:28] Permission denied (publickey). [05:41:28] ssh_exchange_identification: Connection closed by remote host [05:41:37] * Deskana sighs. [05:41:42] wat. [05:41:51] what's in your .ssh/config? [05:42:59] (03PS2) 10Withoutaname: Reword lede in release-notes security reminder [core] - 10https://gerrit.wikimedia.org/r/142814 [05:44:10] ForwardAgent no [05:44:10] # Proxy ssh connections to wikimedia public and [05:44:10] # private networks via a bastion host. This [05:44:12] # host alias keeps the *.wikimedia.org wildcard [05:44:14] # below from matching bast1001.wikimedia.org. [05:44:16] Host bastion [05:44:18] HostName bast1001.wikimedia.org [05:44:20] Host *.wikimedia.org *eqiad.wmnet [05:44:22] ProxyCommand ssh -a -W %h:%p bastion [05:45:14] I'm so fed up at this point but I'm determined. [05:45:25] (03CR) 10Withoutaname: "A bit of that was taken from includes/installer/i18n/en.json's config-register-globals message." [core] - 10https://gerrit.wikimedia.org/r/142814 (owner: 10Withoutaname) [05:47:02] yeah, I don't know then :\ [05:47:21] 3Wikimedia / 3Site requests: GWToolset additional domain - 10https://bugzilla.wikimedia.org/67344#c9 (10This, that and the other) (In reply to Ayaita from comment #2) > Why do you want to know if you are already saying you are not adding it? I wanted to know so I would be able to suggest an alternative. I s... [05:47:27] Dan-Garry:android-wikipedia dgarry$ ssh deskana@gerrit.wikimedia.org:29418 [05:47:28] ssh: Could not resolve hostname gerrit.wikimedia.org:29418: nodename nor servname provided, or not known [05:47:36] Doesn't this mean there's some other problem going on here? [05:48:04] huh [05:48:05] yeah. [05:48:10] trying pinging it? [05:48:22] Works. [05:48:32] Dan-Garry:android-wikipedia dgarry$ ssh gerrit.wikimedia.org -l deskana -p 29418 [05:48:33] Permission denied (publickey). [05:48:33] ssh_exchange_identification: Connection closed by remote host [05:48:34] (03PS1) 10AndyRussG: Maintenance script to unenroll invalid users [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/143246 (https://bugzilla.wikimedia.org/66624) [05:48:36] I'm curious why that works. [05:48:40] But what I originally typed didn't. [05:48:50] km-mpb:~ km$ ssh legoktm@gerrit.wikimedia.org:29418 [05:48:50] ssh: Could not resolve hostname gerrit.wikimedia.org:29418: nodename nor servname provided, or not known [05:48:52] dunno [05:48:55] Oh. [05:49:06] AndyRussG: :D [05:49:22] I believe you use a space instead of :? [05:49:38] that's the syntax for both putty and Windows' telnet thingy [05:49:39] Hey legoktm :) [05:49:40] just saying [05:49:51] I don't know what I'm even doing anymore. [05:49:58] It was a fucking one line string change. [05:50:05] And I've spent 45 minutes trying to submit the patch. [05:52:17] (03CR) 10Legoktm: [C: 04-1] "It would be a good idea to add a --dryrun mode that just outputs what it would have changed without actually do anything." (033 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/143246 (https://bugzilla.wikimedia.org/66624) (owner: 10AndyRussG) [05:54:34] I moved my config to config.old and now it works. [05:54:35] Fuck. [06:01:54] legoktm: Thanks for helping. :) [06:02:02] :) [06:02:42] (03Abandoned) 10Amire80: Resolve redirects in newSection in mediawiki.api.edit [core] - 10https://gerrit.wikimedia.org/r/143163 (owner: 10Amire80) [06:02:54] (03CR) 10Amire80: [C: 031] mediawiki.feedback: Resolve redirects when posting [core] - 10https://gerrit.wikimedia.org/r/143171 (owner: 10Bartosz Dziewoński) [06:03:21] 3MediaWiki / 3Parser: HHVM segfaults when calling Parser->callParserFunction - 10https://bugzilla.wikimedia.org/65796 (10Ori Livneh) 5PATC>3RESO/FIX [06:05:05] (03CR) 10Physikerwelt: "That's what I did." [extensions/Math] - 10https://gerrit.wikimedia.org/r/142739 (https://bugzilla.wikimedia.org/67148) (owner: 10Physikerwelt) [06:09:27] (03CR) 10AndyRussG: Maintenance script to unenroll invalid users (033 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/143246 (https://bugzilla.wikimedia.org/66624) (owner: 10AndyRussG) [06:09:52] (03PS2) 10AndyRussG: Maintenance script to unenroll invalid users [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/143246 (https://bugzilla.wikimedia.org/66624) [06:10:45] (03PS4) 10Gerrit Patch Uploader: search.less: Use static width for the search button [core] - 10https://gerrit.wikimedia.org/r/127371 [06:10:47] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/127371 (owner: 10Gerrit Patch Uploader) [06:15:06] 3MediaWiki extensions / 3ContentTranslation: Infobox jumps to translation column in Firefox - 10https://bugzilla.wikimedia.org/63810#c1 (10Santhosh Thottingal) 5NEW>3RESO/INV Closing invalid, since the bug is not reproducible as per latest version. [06:15:53] 3MediaWiki extensions / 3Scribunto: HHVM: crash in luasandbox_unprotect_recursion() - 10https://bugzilla.wikimedia.org/67348 (10Ori Livneh) 3NEW p:3Unprio s:3normal a:3None Created attachment 15798 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15798&action=edit Stack trace from osmium To re... [06:16:37] 3MediaWiki extensions / 3Scribunto: HHVM: crash in luasandbox_unprotect_recursion() - 10https://bugzilla.wikimedia.org/67348#c1 (10Ori Livneh) Created attachment 15799 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15799&action=edit Additional trace from osmium [06:18:07] 3MediaWiki extensions / 3EducationProgram: User's IP is shown as ' is a student in Intellectual Freedom - LIS 493 (course talk).' on all IP editors' contributions - 10https://bugzilla.wikimedia.org/66624#c24 (10Andrew Green) The maintenance script has two modes: - To repair a course specified by ID. - To... [06:18:21] 3Wikimedia / 3Site requests: GWToolset additional domain - 10https://bugzilla.wikimedia.org/67344#c10 (10Ayaita) (In reply to This, that and the other from comment #9) > (In reply to Ayaita from comment #2) > > Why do you want to know if you are already saying you are not adding it? > > I wanted to know so... [06:21:14] AndyRussG: yay! Let me try running it right now. [06:21:54] legoktm: cool, thanks! [06:22:06] On production or on a local install? [06:23:05] prod [06:23:10] ooooh [06:23:12] K [06:23:23] (03CR) 10Legoktm: Maintenance script to unenroll invalid users (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/143246 (https://bugzilla.wikimedia.org/66624) (owner: 10AndyRussG) [06:23:29] I did test it locally [06:24:21] 3MediaWiki extensions / 3ContentTranslation: template in the beginning of Bratislava in English is not loaded correctly in Special:ContentTranslation - 10https://bugzilla.wikimedia.org/66659#c2 (10Santhosh Thottingal) Segmentation error fixed in https://gerrit.wikimedia.org/r/#/c/142061/ But the bug still ex... [06:25:40] (03CR) 10AndyRussG: Maintenance script to unenroll invalid users (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/143246 (https://bugzilla.wikimedia.org/66624) (owner: 10AndyRussG) [06:26:18] AndyRussG: is the EP extension deployed on any other WMF wikis? [06:26:53] (03PS3) 10AndyRussG: Maintenance script to unenroll invalid users [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/143246 (https://bugzilla.wikimedia.org/66624) [06:27:25] legoktm: Yeah, several [06:27:45] Like 10 or 12 or so [06:28:03] hm [06:28:08] okay. [06:28:54] I ran it. [06:28:58] I did look for the original SpecialContributions problem on others [06:29:57] Aaaaand enwiki's down! [06:30:00] Jk [06:31:13] omfg [06:31:15] don't do that [06:31:20] ? [06:31:21] 3MediaWiki / 3Skin and page rendering: Use mediawiki.ui Constructive style button for [Save] in preferences - 10https://bugzilla.wikimedia.org/65317#c5 (10Jared Zimmerman (WMF)) @Matt, Good thinking, lets use neutral.quite for "Restore defaults" and something like destructive.normal for [Reset All Preferenc... [06:31:27] joke like that :P [06:31:33] Ah OK sorry [06:31:45] I'm just a wee bit sleep deprived tonight [06:31:47] https://en.wikipedia.org/w/index.php?title=Education_Program:Simmons_College/Intellectual_Freedom_-_LIS_493_%28Summer_2014%29&action=purge [06:31:59] Seems to have worked [06:32:13] The "student count" has been corrected, which is exactly what was expected [06:32:19] I ran it in --dryrun mode on all the other wikis except for legalteamwiki and they all said "Found user id 0 associated with 0 course(s)." [06:32:34] awesome! [06:32:52] (03CR) 10Legoktm: [C: 032] "Already run in prod." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/143246 (https://bugzilla.wikimedia.org/66624) (owner: 10AndyRussG) [06:32:55] fantastic! thanks so much [06:32:59] (03Merged) 10jenkins-bot: Maintenance script to unenroll invalid users [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/143246 (https://bugzilla.wikimedia.org/66624) (owner: 10AndyRussG) [06:33:14] np, I'll let you close the bug? :) [06:33:29] sure [06:33:32] legalteamwiki has the EP extension installed? [06:33:51] apparently. but it's a private wiki, so no anon user would have been able to access it. [06:34:11] https://bugzilla.wikimedia.org/show_bug.cgi?id=62610 [06:34:16] does this perhaps have anything to do w/ global user rename? [06:34:29] it's going live in <8.5 hours [06:34:42] Jasper_Deng: nope? we delayed it btw [06:35:22] * legoktm find slink [06:35:39] again? [06:35:39] Jasper_Deng: https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=117999&oldid=117958 [06:35:42] yeah [06:35:46] and https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=next&oldid=117999 [06:35:56] so hoo will be present too. [06:41:04] legoktm: 'night [06:41:10] gnite [06:41:12] 3MediaWiki extensions / 3EducationProgram: User's IP is shown as ' is a student in Intellectual Freedom - LIS 493 (course talk).' on all IP editors' contributions - 10https://bugzilla.wikimedia.org/66624#c26 (10Andrew Green) 5PATC>3RESO/FIX Script was run successfully on production (thanks, Legoktm!)... [06:49:38] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/SkinPerPage] - 10https://gerrit.wikimedia.org/r/143242 (owner: 10Isarra) [06:51:03] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (https://bugzilla.wikimedia.org/14862) (owner: 10Legoktm) [07:10:37] 3MediaWiki / 3Page editing: Transclusion: Section edit links linked improperly on the transcluding wiki page - 10https://bugzilla.wikimedia.org/38614#c3 (10This, that and the other) 5UNCO>3RESO/WOR Closing this. The issue in comment 0 sounds fairly major (a regression, nonetheless). But since no-one els... [07:16:10] 3Wikimedia / 3Site requests: GWToolset additional domain - 10https://bugzilla.wikimedia.org/67344#c11 (10jeremyb) (In reply to Ayaita from comment #10) > See, in that whitelist > Flickr is listed, and to me, Flickr is a filesharing service usable by > anyone. AIUI, there is one shared whitelist for multiple... [07:25:37] 3Wikimedia / 3General/Unknown: Clean up centralauth db inconsistencies due to UserMerge extension - 10https://bugzilla.wikimedia.org/66535#c3 (10Kunal Mehta (Legoktm)) 5ASSI>3RESO/FIX Done! [07:27:10] (03CR) 10Krinkle: [C: 04-2] "Please read the comment describing this method. The function is unfortunately named, but it doesn't assert whether the value is a valid IP" [core] - 10https://gerrit.wikimedia.org/r/143234 (owner: 10Withoutaname) [07:43:42] (03CR) 10Hashar: "Thanks!" [extensions/StrategyWiki] - 10https://gerrit.wikimedia.org/r/143005 (owner: 10Hashar) [07:47:14] (03PS17) 10Hashar: (WIP) Experiment zuul-cloner with extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141846 [07:47:17] (03PS7) 10Hashar: (WIP) Experiment zuul cloner (replace multigit.sh) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141819 [07:47:20] (03PS5) 10Hashar: (WIP) Experiment with language bundle exts (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/142421 [07:47:23] 3Wikimedia / 3General/Unknown: Audit centralauth database for inconsistencies - 10https://bugzilla.wikimedia.org/67350 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Inspired by bug 66535. Since we have a checkLocalNames script, I started running it against small.dblist (except for login... [07:47:56] (03Abandoned) 10Hashar: (WIP) zuul-cloner always fallback to ZUUL_BRANCH (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/142433 (owner: 10Hashar) [07:49:06] (03PS18) 10Hashar: (WIP) Experiment zuul-cloner with extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141846 [07:49:42] (03CR) 10Hashar: "PS17 is a rebase" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141846 (owner: 10Hashar) [07:49:52] 3MediaWiki extensions / 3Cite: Error message for an empty reference should be more appropriate and helpful - 10https://bugzilla.wikimedia.org/57619 (10Thiemo Mättig) [07:49:52] 3MediaWiki extensions / 3Cite: Cite: If there's no block on the page, insert the wikitext for one automatically in the right place - 10https://bugzilla.wikimedia.org/30763 (10Thiemo Mättig) [07:49:52] 3MediaWiki extensions / 3Cite: Cite: If there's no block on the page, show one automatically below the content rather than showing an error - 10https://bugzilla.wikimedia.org/66860#c4 (10Thiemo Mättig) We (WMDE) had this on our radar too and came to the same conclusion. So thank you! https://... [07:50:06] 3MediaWiki extensions / 3Cite: Cite: If there's no block on the page, insert the wikitext for one automatically in the right place - 10https://bugzilla.wikimedia.org/30763 (10Thiemo Mättig) [07:50:37] (03PS3) 1001tonythomas: Added SwiftMailer Extension to provide an alternate for UserMailer [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 [07:53:03] (03PS4) 1001tonythomas: Added SwiftMailer Extension to provide an alternate for UserMailer [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 [07:57:50] (03CR) 10Legoktm: [C: 04-1] Added SwiftMailer Extension to provide an alternate for UserMailer (034 comments) [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 (owner: 1001tonythomas) [08:02:44] (03CR) 10Raimond Spekking: "key conflict" (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/140905 (owner: 10Smuggli) [08:05:37] 3Wikimedia / 3General/Unknown: Clean up centralauth db inconsistencies due to UserMerge extension - 10https://bugzilla.wikimedia.org/66535 (10Kunal Mehta (Legoktm)) [08:05:37] 3Wikimedia / 3General/Unknown: Audit centralauth database for inconsistencies - 10https://bugzilla.wikimedia.org/67350 (10Kunal Mehta (Legoktm)) [08:06:57] (03CR) 10Pginer: mw-ui-button: Revamp the LESS to be simpler, and improve cross-browser support (031 comment) [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [08:13:08] 3MediaWiki extensions / 3Cite: Cite: If there's no block on the page, show one automatically below the content rather than showing an error - 10https://bugzilla.wikimedia.org/66860#c5 (10Jared Zimmerman (WMF)) @kaity had some ideas and designs around auto formatting and grouping that might be... [08:17:33] (03CR) 10Krinkle: "Should this be done in the Database class instead?" [core] - 10https://gerrit.wikimedia.org/r/143222 (owner: 10Reedy) [08:22:53] 3MediaWiki extensions / 3GlobalBlocking: GlobalBlocking cause other extensions tests to fail (globalblocking database not found) - 10https://bugzilla.wikimedia.org/67353 (10Antoine "hashar" Musso) 3NEW p:3Unprio s:3normal a:3None GlobalBlocking is meant to use a dedicated shared database 'globalblock... [08:23:21] 3MediaWiki extensions / 3GlobalBlocking: GlobalBlocking cause other extensions tests to fail (globalblocking database not found) - 10https://bugzilla.wikimedia.org/67353#c1 (10Antoine "hashar" Musso) CCed Aude because we used $wgWikimediaJenkinsCI for the Wikibase extension. Blocks Bug 67216 - Have unit tes... [08:24:23] (03PS1) 10Hashar: Adjust GlobalBlocking database under Wikimedia Jenkins [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/143253 (https://bugzilla.wikimedia.org/67353) [08:24:46] (03CR) 10Krinkle: [C: 04-1] "Various minor concerns, but the cascading and maintenance issue pointed out inline is the reason it needs improvement." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [08:25:41] (03CR) 10Legoktm: [C: 04-1] Force mw.popups.supportsSVG to false on InternetExplorer (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/142212 (owner: 10Prtksxna) [08:26:16] (03PS1) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/143254 [08:28:36] (03PS5) 1001tonythomas: Added SwiftMailer Extension to provide an alternate for UserMailer [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 [08:29:42] (03PS1) 10Hashar: Add experimental integration tests on core and exts [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/143255 [08:30:05] (03CR) 10Raimond Spekking: [C: 032 V: 032] Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/143254 (owner: 10Smuggli) [08:30:12] (03CR) 10Hashar: [C: 032] Add experimental integration tests on core and exts [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/143255 (owner: 10Hashar) [08:30:17] (03Merged) 10jenkins-bot: Add experimental integration tests on core and exts [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/143255 (owner: 10Hashar) [08:32:26] (03CR) 10Hashar: "Reedy, Aude: that is a hack to point GlobalBlocking to the only database existing when run under Jenkins." [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/143253 (https://bugzilla.wikimedia.org/67353) (owner: 10Hashar) [08:32:44] (03CR) 10Hashar: "check experimental" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/143253 (https://bugzilla.wikimedia.org/67353) (owner: 10Hashar) [08:37:27] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (033 comments) [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 (owner: 1001tonythomas) [08:37:53] (03CR) 10Hashar: [C: 031 V: 031] "As seen in build 52, the tests are failing but PHPUnit managed to run entirely \O/" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/143253 (https://bugzilla.wikimedia.org/67353) (owner: 10Hashar) [08:39:36] 3MediaWiki / 3General/Unknown: Implement support for sharing protocols (tracking) - 10https://bugzilla.wikimedia.org/54829 (10Nemo) [08:39:36] 3MediaWiki / 3Skin and page rendering: When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo - 10https://bugzilla.wikimedia.org/30113 (10Nemo) [08:40:36] 3MediaWiki / 3General/Unknown: Implement support for sharing protocols (tracking) - 10https://bugzilla.wikimedia.org/54829 (10Nemo) [08:40:36] 3MediaWiki / 3General/Unknown: RSS, Atom, XML syndication feeds (tracking) - 10https://bugzilla.wikimedia.org/3646 (10Nemo) [08:42:38] (03PS6) 1001tonythomas: Added SwiftMailer Extension to provide an alternate for UserMailer [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 [08:44:04] (03PS7) 1001tonythomas: Added SwiftMailer Extension to provide an alternate for UserMailer [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 [08:49:52] 3Analytics / 3EventLogging: Multiple user_ids per username in account creation events from ServerSideAccountCreation log - 10https://bugzilla.wikimedia.org/66101 (10christian) [08:51:16] (03PS1) 10Divec: Markup-preserving wrapper for Apertium [services/cxserver] - 10https://gerrit.wikimedia.org/r/143257 [08:51:41] (03CR) 10jenkins-bot: [V: 04-1] Markup-preserving wrapper for Apertium [services/cxserver] - 10https://gerrit.wikimedia.org/r/143257 (owner: 10Divec) [08:53:22] 3Wikimedia / 3SSL related: Enable HSTS on Wikimedia wikis - 10https://bugzilla.wikimedia.org/38516#c22 (10fn84b) bugzilla.wikimedia.org, wikitech.wikimedia.org and lists.wikimedia.org require HTTPS connections. Could we enable HSTS on these domains first? [08:53:41] (03PS19) 10Hashar: (WIP) Experiment zuul-cloner with extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141846 [08:54:19] (03CR) 10Hashar: "Bring back Flow and add Mantle which is a dependency. Test run: https://integration.wikimedia.org/ci/job/mediawiki-core-extensions-integra" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141846 (owner: 10Hashar) [08:59:21] 3Wikimedia / 3SSL related: Enable HSTS on Wikimedia wikis - 10https://bugzilla.wikimedia.org/38516#c23 (10Jan Zerebecki) Yes, enabling those first is fine. The patch for bugzilla is at https://gerrit.wikimedia.org/r/#/c/127256/ . [08:59:52] (03PS2) 10Divec: Markup-preserving wrapper for Apertium [services/cxserver] - 10https://gerrit.wikimedia.org/r/143257 [09:01:40] (03CR) 10Aude: "only used in the evilMediaWikiBootstrap.php which really doesn't work anyway, afaik and shouldn't be using deprecated code" [core] - 10https://gerrit.wikimedia.org/r/143207 (owner: 10Withoutaname) [09:01:46] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (0312 comments) [extensions/WebCache] - 10https://gerrit.wikimedia.org/r/143185 (owner: 10Iowajason) [09:02:37] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 (owner: 1001tonythomas) [09:06:53] 3Wikimedia / 3General/Unknown: Migrate to SUL all non-clashing accounts - 10https://bugzilla.wikimedia.org/39817#c8 (10Kunal Mehta (Legoktm)) Ok, that makes sense. So the simplest case of this is users who only exist on one wiki, and are not attached (the query in comment 5). We should be able to migrating t... [09:08:01] Nemo_bis: ^ [09:09:13] (03CR) 10Siebrand: [C: 04-1] "Per Brad/Anomie." [core] - 10https://gerrit.wikimedia.org/r/143049 (owner: 10Kunalgrover05) [09:12:02] (03CR) 10Withoutaname: "We could change it to "isValidIPUser"..." [core] - 10https://gerrit.wikimedia.org/r/143234 (owner: 10Withoutaname) [09:17:34] (03CR) 10Siebrand: i18n: Rephrase the message flow-topic-participants-second-try (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142507 (owner: 10Amire80) [09:38:07] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/143061 (owner: 10Jackmcbarn) [09:39:30] (03CR) 10Siebrand: [C: 04-1] "Per 3 reviewers above. Please implement Niklas' and Brad's suggestion." [core] - 10https://gerrit.wikimedia.org/r/143026 (owner: 10Kunalgrover05) [09:39:42] 3Wikimedia / 3General/Unknown: Audit centralauth database for inconsistencies - 10https://bugzilla.wikimedia.org/67350 (10Andre Klapper) p:5Unprio>3Normal [09:39:50] (03CR) 10Siebrand: [C: 032] Drop execute bit [extensions/Petition] - 10https://gerrit.wikimedia.org/r/143058 (owner: 10Reedy) [09:39:57] (03Merged) 10jenkins-bot: Drop execute bit [extensions/Petition] - 10https://gerrit.wikimedia.org/r/143058 (owner: 10Reedy) [09:41:51] 3MediaWiki extensions / 3WikidataRepo: review backend part of entity suggester (php code) - 10https://bugzilla.wikimedia.org/63224 (10Lydia Pintscher) 5ASSI>3RESO/FIX [09:42:21] 3MediaWiki extensions / 3WikidataRepo: review backend part of entity suggester (python code) - 10https://bugzilla.wikimedia.org/63368 (10Lydia Pintscher) 5ASSI>3RESO/FIX [09:43:21] 3Wikimedia / 3General/Unknown: Migrate to SUL all non-clashing accounts - 10https://bugzilla.wikimedia.org/39817#c10 (10Kunal Mehta (Legoktm)) I ran the query in comment 5, and came up with 10596 users across all wikis. The result set is at /home/legoktm/one_account_no_sul.tsv on terbium. [09:43:36] 3MediaWiki extensions / 3WikidataRepo: not possible to change rank alone - 10https://bugzilla.wikimedia.org/66633#c3 (10Lydia Pintscher) 5ASSI>3PATC Done except for browser tests. Needs help from Tobi. [09:49:11] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Petition] - 10https://gerrit.wikimedia.org/r/142737 (https://bugzilla.wikimedia.org/65850) (owner: 10Pcoombe) [09:49:13] (03PS1) 10Amire80: Add explicit GENDER to gender-flow-topic-participants-second-try [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143260 [09:49:43] (03PS2) 10Amire80: Add explicit GENDER to gender-flow-topic-participants-second-try [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143260 [09:51:16] (03CR) 10Legoktm: Tidy preview function and comments (031 comment) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/143047 (owner: 10Wctaiwan) [09:52:16] (03CR) 10Legoktm: [C: 031] "Looks fine to me, didn't test." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/142212 (owner: 10Prtksxna) [09:53:33] (03CR) 10Siebrand: [C: 032 V: 032] i18n: fix typo [extensions/OdbcDatabase] - 10https://gerrit.wikimedia.org/r/142161 (owner: 10Shirayuki) [09:54:06] 3Wikimedia / 3SSL related: Rename wikis with multiple subdomains - 10https://bugzilla.wikimedia.org/31335#c14 (10Andre Klapper) "noboard.chapters.wikimedia.org uses an invalid security certificate." followed by "No wiki found". (In reply to Sam Reed (reedy) from comment #12) > All merged and deployed Reedy... [09:54:08] (03CR) 10Siebrand: [C: 032] i18n: consistency tweaks [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142869 (owner: 10Shirayuki) [09:54:15] (03Merged) 10jenkins-bot: i18n: consistency tweaks [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142869 (owner: 10Shirayuki) [10:06:06] 3MediaWiki extensions / 3CLDR: Fix/improve some translations of language names in Spanish - 10https://bugzilla.wikimedia.org/67346#c1 (10Andre Klapper) Hi! Thanks for your report! Language name translations come from the CLDR extensions and its file https://git.wikimedia.org/raw/mediawiki%2Fextensions%2Fcld... [10:06:21] 3MediaWiki extensions / 3Babel: Babel extension categories - 10https://bugzilla.wikimedia.org/67334#c1 (10Andre Klapper) p:5Unprio>3Low s:5minor>3enhanc Is that a question whether it is already possible to do that, or a question for enhancement to support this functionality in the future? And what's... [10:07:34] (03CR) 10Aude: [C: 031] "looks reasonable" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/143253 (https://bugzilla.wikimedia.org/67353) (owner: 10Hashar) [10:08:51] 3MediaWiki extensions / 3CLDR: Fix/improve some translations of language names in Spanish - 10https://bugzilla.wikimedia.org/67346 (10Andre Klapper) p:5Unprio>3Low s:5normal>3minor [10:09:06] 3MediaWiki extensions / 3Scribunto: HHVM: crash in luasandbox_unprotect_recursion() - 10https://bugzilla.wikimedia.org/67348 (10Andre Klapper) p:5Unprio>3High s:5normal>3major [10:11:36] 3MediaWiki extensions / 3CodeEditor: Add support for mobile - 10https://bugzilla.wikimedia.org/67328#c1 (10Andre Klapper) s:5normal>3enhanc I don't see any file called "ace.js" somewhere in https://git.wikimedia.org/tree/mediawiki%2Fextensions%2FWikiEditor.git - if it exists, please provide a full path.... [10:12:38] (03PS1) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/143262 [10:27:27] (03PS1) 10KartikMistry: Fixed typo [core] - 10https://gerrit.wikimedia.org/r/143264 [10:27:56] (03PS2) 10Wctaiwan: Tidy preview function and comments [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/143047 [10:29:11] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (032 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/143262 (owner: 10Smuggli) [10:30:52] (03CR) 10Siebrand: [C: 032] Add explicit GENDER to gender-flow-topic-participants-second-try [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143260 (owner: 10Amire80) [10:31:10] (03Merged) 10jenkins-bot: Add explicit GENDER to gender-flow-topic-participants-second-try [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143260 (owner: 10Amire80) [10:32:01] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Petition] - 10https://gerrit.wikimedia.org/r/142561 (owner: 10Pcoombe) [10:33:20] (03CR) 10Legoktm: [C: 032] Tidy preview function and comments [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/143047 (owner: 10Wctaiwan) [10:33:29] (03Merged) 10jenkins-bot: Tidy preview function and comments [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/143047 (owner: 10Wctaiwan) [10:35:43] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (033 comments) [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142741 (https://bugzilla.wikimedia.org/67220) (owner: 10Florianschmidtwelzow) [10:42:56] (03CR) 10Siebrand: [C: 04-1] Check permissions for Protected and semi protected pages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143015 (owner: 10Kunalgrover05) [10:44:34] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. Please update to commit message to match the guidelines." (031 comment) [extensions/TimezoneSelector] - 10https://gerrit.wikimedia.org/r/143008 (owner: 10Lokal Profil) [10:52:21] 3MediaWiki extensions / 3CodeEditor: Add support for mobile - 10https://bugzilla.wikimedia.org/67328#c2 (10Kunal Mehta (Legoktm)) (In reply to Andre Klapper from comment #1) > I don't see any file called "ace.js" somewhere in > https://git.wikimedia.org/tree/mediawiki%2Fextensions%2FWikiEditor.git - if > it... [10:52:36] 3MediaWiki / 3API: The protorel attribute in the siteinfo API is set to "true", not "". - 10https://bugzilla.wikimedia.org/66723#c11 (10Andre Klapper) (In reply to C. Scott Ananian from comment #9) > Or opened a new bug, but that actually > obscures the connection between the parsoid and core changes. That'... [10:52:51] 3Analytics / 3EventLogging: Removing EventLogging tables starting in 'zz_' or ending in '_1' - 10https://bugzilla.wikimedia.org/66649 (10Dan Andreescu) [10:52:53] 3Wikimedia / 3Site requests: Please add the domain *.eur.nl to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/67355 (10johanmmuller) 3UNCO p:3Unprio s:3normal a:3None Please add the following domain to the wgCopyUploadsDomains whitelist: *.eur.nl Explanation ----------- I am... [10:53:06] 3Wikimedia / 3General/Unknown: Upright of images does not work on several browsers - 10https://bugzilla.wikimedia.org/65889#c15 (10Andre Klapper) Source of https://cs.wikiversity.org/wiki/Ital%C5%A1tina/Materi%C3%A1ly/Slovesa/Lavare says:
... [10:53:22] 3MediaWiki extensions / 3WikidataRepo: automatic edit summary for link changes mentions badges even if there is no badge change - 10https://bugzilla.wikimedia.org/62546 (10Lydia Pintscher) [10:53:22] 3Wikimedia / 3General/Unknown: If one attempts a file upload in Commons, and the file name has unacceptable characters, there is an upload failure but no appropriate error message indicting why. - 10https://bugzilla.wikimedia.org/67197#c3 (10Andre Klapper) Still don't know how you uploaded. Did you test both... [10:53:22] 3MediaWiki extensions / 3SyntaxHighlight (GeSHi): LaTeX: curly bracket highlighting mismatch if parameter is a command name - 10https://bugzilla.wikimedia.org/67307 (10Andre Klapper) p:5Unprio>3Low [10:53:36] 3MediaWiki / 3ResourceLoader: Investigate embedding some data URLs without base 64 - 10https://bugzilla.wikimedia.org/67341 (10Andre Klapper) p:5Unprio>3Low [10:53:37] 3Wikimedia / 3General/Unknown: interwiki links not working at office.wikimedia.org - 10https://bugzilla.wikimedia.org/67337#c1 (10Andre Klapper) Meh, [[outreach:]] works on mediawiki.org so it's really office.wm specific. Do you know if [[outreach:]] has worked before / if this recently broke on office.wm? [10:53:52] 3MediaWiki / 3Skin and page rendering: messages from skin i18n not loaded for $wgLanguageCode != en - 10https://bugzilla.wikimedia.org/67318#c2 (10Andre Klapper) p:5Unprio>3High For the records: Gerrit change #135413 was merged on 2014-06-21 [10:53:53] 3Wikimedia / 3General/Unknown: Audit centralauth database for inconsistencies - 10https://bugzilla.wikimedia.org/67350#c1 (10Chris Steipp) Thanks! Was it the same username across those wikis that was invalid? It just seems odd that there is exactly 1 invalid name on each wiki you tried. Are you planning to... [10:53:53] 3MediaWiki / 3User preferences: Special:Preferences buttons Save/Restore all default settings (in all sections) is confusing - 10https://bugzilla.wikimedia.org/67338#c1 (10Andre Klapper) p:5Unprio>3Normal I don't see how this ticket is different from bug 18961. Dup, to me. [10:53:54] 3MediaWiki / 3Database: Fix "Uncommitted DB writes (transaction from DatabaseBase::query)" - 10https://bugzilla.wikimedia.org/56269#c59 (10adamr_carter) Frequently getting this on 1.23.0, with WikiPage::pageData. Was getting it before on 1.22.x too. [10:54:06] 3MediaWiki extensions / 3WikidataRepo: Snak type selection (e.g. novalue) sticks when canceling - 10https://bugzilla.wikimedia.org/67294#c1 (10Henning) 5NEW>3PATC https://gerrit.wikimedia.org/r/#/c/143270/ [10:54:07] 3MediaWiki extensions / 3ContentTranslation: [Data loss] Emptying a section by holding backspace navigates away - 10https://bugzilla.wikimedia.org/67288 (10Kartik Mistry) 5NEW>3ASSI a:3Kartik Mistry [10:56:51] 3Wikimedia / 3SSL related: Add Forward Secrecy - 10https://bugzilla.wikimedia.org/53259#c10 (10matanya) 5PATC>3RESO/FIX The change is now live. Thanks Giuseppe! [10:59:06] (03PS2) 10Hashar: Whitelist Isarra [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/143216 (owner: 10Legoktm) [10:59:31] (03CR) 10Hashar: [C: 032] "Thanks :)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/143216 (owner: 10Legoktm) [10:59:36] (03Merged) 10jenkins-bot: Whitelist Isarra [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/143216 (owner: 10Legoktm) [11:03:22] (03CR) 10Hashar: "This is what I have:" [extensions/Math] - 10https://gerrit.wikimedia.org/r/142739 (https://bugzilla.wikimedia.org/67148) (owner: 10Physikerwelt) [11:05:06] (03CR) 10Siebrand: [C: 04-1] Handle invalid language code gracefully in Language::fetchLanguageNames (031 comment) [core] - 10https://gerrit.wikimedia.org/r/142974 (https://bugzilla.wikimedia.org/60629) (owner: 10Brian Wolff) [11:10:24] (03CR) 10Physikerwelt: "For me only 501 tests are executed in total." [extensions/Math] - 10https://gerrit.wikimedia.org/r/142739 (https://bugzilla.wikimedia.org/67148) (owner: 10Physikerwelt) [11:12:24] (03CR) 10Siebrand: [C: 032] Don't use isset() to check for null [core] - 10https://gerrit.wikimedia.org/r/143085 (owner: 10IAlex) [11:13:08] (03CR) 10Siebrand: [C: 032] Documentation improvements in ChangeTags.php [core] - 10https://gerrit.wikimedia.org/r/138670 (owner: 10IAlex) [11:13:14] (03CR) 10CSteipp: [C: 032] Don't send attach entries to RC if from a maintenance script [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143243 (owner: 10Legoktm) [11:13:40] (03Merged) 10jenkins-bot: Don't send attach entries to RC if from a maintenance script [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143243 (owner: 10Legoktm) [11:14:36] 3Wikimedia / 3General/Unknown: If one attempts a file upload in Commons, and the file name has unacceptable characters, there is an upload failure but no appropriate error message indicting why. - 10https://bugzilla.wikimedia.org/67197#c4 (10Lane Rasberry) 1. name image file !@#$%^&*()_+=-<>?-'"_.,\|}{[]\~`.... [11:14:43] (03CR) 10Siebrand: [C: 032] Make the global objects documentation consistent in Setup.php [core] - 10https://gerrit.wikimedia.org/r/122875 (owner: 10IAlex) [11:15:21] (03PS2) 10Siebrand: Improve Database related documentation a bit [core] - 10https://gerrit.wikimedia.org/r/132625 (owner: 10IAlex) [11:15:30] (03CR) 10Siebrand: [C: 032] Improve Database related documentation a bit [core] - 10https://gerrit.wikimedia.org/r/132625 (owner: 10IAlex) [11:16:10] (03Merged) 10jenkins-bot: Don't use isset() to check for null [core] - 10https://gerrit.wikimedia.org/r/143085 (owner: 10IAlex) [11:16:25] (03Merged) 10jenkins-bot: Documentation improvements in ChangeTags.php [core] - 10https://gerrit.wikimedia.org/r/138670 (owner: 10IAlex) [11:17:20] (03PS2) 10Lokal Profil: English i18n messages clarified Changes to the following: * timezoneselector-desc * timezoneselector-show-pref * timezoneselector-show-temp Mainly "changed temporarily" -> "temporarily changed" [extensions/TimezoneSelector] - 10https://gerrit.wikimedia.org/r/143008 [11:18:08] (03Merged) 10jenkins-bot: Make the global objects documentation consistent in Setup.php [core] - 10https://gerrit.wikimedia.org/r/122875 (owner: 10IAlex) [11:18:50] (03PS2) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/143262 [11:20:11] (03Merged) 10jenkins-bot: Improve Database related documentation a bit [core] - 10https://gerrit.wikimedia.org/r/132625 (owner: 10IAlex) [11:24:36] (03PS2) 10Physikerwelt: WIP:First node only mathoid protype [services/mathoid] - 10https://gerrit.wikimedia.org/r/143043 [11:26:30] (03PS1) 10Physikerwelt: Add jsdom module [services/mathoid] - 10https://gerrit.wikimedia.org/r/143272 [11:28:20] (03CR) 10Hashar: "https://gist.github.com/hashar/b3deedc51209b2369071" [extensions/Math] - 10https://gerrit.wikimedia.org/r/142739 (https://bugzilla.wikimedia.org/67148) (owner: 10Physikerwelt) [11:30:08] (03PS4) 10Kunalgrover05: API method for setting page language [core] - 10https://gerrit.wikimedia.org/r/143025 [11:31:30] (03CR) 10jenkins-bot: [V: 04-1] API method for setting page language [core] - 10https://gerrit.wikimedia.org/r/143025 (owner: 10Kunalgrover05) [11:35:21] 3MediaWiki extensions / 3MolHandler: indigo-depict badly fails when molecules contain the "any" bond because it's query language and does not belong into a molecule - 10https://bugzilla.wikimedia.org/67075#c3 (10Gilles Dubuc) Doesn't that sort of bug belong on the GGA side of things? Or are you planning to p... [11:41:36] 3MediaWiki extensions / 3MolHandler: indigo-depict badly fails when molecules contain the "any" bond because it's query language and does not belong into a molecule - 10https://bugzilla.wikimedia.org/67075#c4 (10Rainer Rillke @commons.wikimedia) (In reply to Gilles Dubuc from comment #3) > are you planning t... [11:43:21] (03PS3) 10Pcoombe: Convert from tag to includable special page, revamp tracking [extensions/Petition] - 10https://gerrit.wikimedia.org/r/142561 [11:43:55] (03CR) 10jenkins-bot: [V: 04-1] Convert from tag to includable special page, revamp tracking [extensions/Petition] - 10https://gerrit.wikimedia.org/r/142561 (owner: 10Pcoombe) [11:44:15] (03PS1) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/143277 [11:44:24] (03CR) 10Rillke: "already done by reedy with I5d147c6baa034057f9" [core] - 10https://gerrit.wikimedia.org/r/135714 (https://bugzilla.wikimedia.org/65757) (owner: 10Rillke) [11:47:07] 3Wikimedia / 3General/Unknown: Don't use deprecated features removed in jQuery 1.9 (tracking) - 10https://bugzilla.wikimedia.org/65399 (10This, that and the other) [11:47:08] 3MediaWiki extensions / 3MarkAsHelpful: MarkAsHelpful uses deprecated jQuery functions - 10https://bugzilla.wikimedia.org/67356 (10This, that and the other) 3NEW p:3Unprio s:3normal a:3bsitu The .live() function is deprecated and needs to be replaced. Seen in [1]. There may be more JQMIGRATE issues... [11:51:37] (03CR) 10Reedy: "Not sure "instead". Maybe "aswell"" [core] - 10https://gerrit.wikimedia.org/r/143222 (owner: 10Reedy) [11:51:38] (03PS7) 10Kunalgrover05: Improve page language functions [core] - 10https://gerrit.wikimedia.org/r/137033 (owner: 10SPQRobin) [11:51:38] (03PS5) 10Kunalgrover05: API method for setting page language [core] - 10https://gerrit.wikimedia.org/r/143025 [11:51:47] (03CR) 10jenkins-bot: [V: 04-1] API method for setting page language [core] - 10https://gerrit.wikimedia.org/r/143025 (owner: 10Kunalgrover05) [11:56:42] When was userid removed from Special:Preferences? [11:57:00] Reedy: Few weeks back [11:57:07] people thought it to be confusing [11:57:11] lol [11:57:20] Slightly more confusing... [11:57:23] :D [11:57:39] userids on wikimania2015wiki start at 12 [11:57:46] for MediaWiki message delivery [11:57:48] and I get 14 [11:57:50] No 13 [11:57:52] Now I can no longer brag with my user ids this easy :P [11:57:54] Guessing it's some error related [11:58:03] andre__: around ? :D [11:58:16] hashar, yo [11:58:49] andre__: we are working on getting phpunit tests to pass with core + all extensions. I have set the tracking bug to high priority https://bugzilla.wikimedia.org/show_bug.cgi?id=67216 [11:58:51] 3Wikimedia / 3General/Unknown: If one attempts a file upload in Commons, and the file name has unacceptable characters, there is an upload failure but no appropriate error message indicting why. - 10https://bugzilla.wikimedia.org/67197#c5 (10Andre Klapper) Tested on test2 which should not have a difference t... [11:58:56] yeah, seen that [11:59:02] (03CR) 10Physikerwelt: "For me the echo tests are not triggered via" [extensions/Math] - 10https://gerrit.wikimedia.org/r/142739 (https://bugzilla.wikimedia.org/67148) (owner: 10Physikerwelt) [11:59:09] andre__: hope you don't mind. IIRC you "only" care about highest prio so it should not be too much of a problem :D [11:59:20] Reedy: good morning! [11:59:21] hashar, no, I don't mind, because you know what you are doing. :P [11:59:28] andre__: I hope so! [12:00:02] andre__: do you have any program to attract volunteers to bugs? I am not sure whether keyword +easy is still used/monitored by volunteers [12:00:25] Reedy: wanna chat about the crazy "tests all extensions" effort? [12:00:27] hashar, that's all I'm aware of, and https://www.mediawiki.org/wiki/Annoying_little_bugs also links to queries for those tickets [12:00:38] andre__: will keep +easy one so [12:00:43] +1 [12:00:49] andre__: I might well send some kind of announcement to wikitech-l this week [12:00:55] and get more folks involved [12:00:57] Reedy: may 12th. https://github.com/wikimedia/mediawiki-core/commit/f0ece08caf99376db8eb089073acbc6e4c29f9c5 [12:01:00] sounds good [12:01:28] (03PS2) 10Pcoombe: Escape equals signs in csv output [extensions/Petition] - 10https://gerrit.wikimedia.org/r/139285 (https://bugzilla.wikimedia.org/65850) [12:01:28] (03PS4) 10Pcoombe: Convert from tag to includable special page, revamp tracking [extensions/Petition] - 10https://gerrit.wikimedia.org/r/142561 [12:01:28] (03PS2) 10Pcoombe: Escape number of signatures [extensions/Petition] - 10https://gerrit.wikimedia.org/r/139286 (https://bugzilla.wikimedia.org/65850) [12:01:28] (03PS2) 10Pcoombe: When getting number of signatures, count on indexed column [extensions/Petition] - 10https://gerrit.wikimedia.org/r/139126 (https://bugzilla.wikimedia.org/65850) [12:01:28] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/143262 (owner: 10Smuggli) [12:01:28] (03PS3) 10Physikerwelt: WIP:First node only mathoid protype [services/mathoid] - 10https://gerrit.wikimedia.org/r/143043 [12:01:28] (03PS3) 10Florianschmidtwelzow: [DO NOT MERGE] Enable keep logged in [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/143053 (https://bugzilla.wikimedia.org/67136) [12:01:28] (03PS5) 10Pcoombe: Prevent blocked users from signing petitions [extensions/Petition] - 10https://gerrit.wikimedia.org/r/142737 (https://bugzilla.wikimedia.org/65850) [12:01:30] legoktm: you're the worst [12:01:39] pff [12:01:39] you're welcome! [12:01:49] why do folks sneakily removes such a feature? :/ [12:01:52] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Petition] - 10https://gerrit.wikimedia.org/r/142561 (owner: 10Pcoombe) [12:02:00] (03PS8) 10Florianschmidtwelzow: Add feature to restrict E-Maildomains [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142741 (https://bugzilla.wikimedia.org/67220) [12:02:35] I was so proud of my ID : 21 on frwiki whenever I browse Special:Preferences [12:02:54] Reedy: now you should merge https://gerrit.wikimedia.org/r/142304 :) [12:03:30] so you had reverse editcountitis? [12:04:21] Reedy: I already ran it last night (this morning... :|) fwiw [12:05:43] (03PS6) 10Pcoombe: Prevent blocked users from signing petitions [extensions/Petition] - 10https://gerrit.wikimedia.org/r/142737 (https://bugzilla.wikimedia.org/65850) [12:05:53] 3MediaWiki extensions / 3WikimediaMaintenance: addWiki should create database on extension1 - 10https://bugzilla.wikimedia.org/67357 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3enhanc a:3None Currently needs doing manually [12:06:02] (03PS3) 10Kunalgrover05: Changing language purges the page [core] - 10https://gerrit.wikimedia.org/r/143026 [12:06:21] 3Wikimedia / 3Wikidata: Investigate if there are already claims for properties on wikidata.org - 10https://bugzilla.wikimedia.org/63072 (10Lydia Pintscher) [12:07:08] 3MediaWiki extensions / 3WikimediaMaintenance: Create Echo tables using addExtensionTable.php on extension1 - 10https://bugzilla.wikimedia.org/67358 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3enhanc a:3None Currently it's setup to just create them on the local wiki db, which isn't right, needs to be exte... [12:07:42] hashar: :D I got the 1 on Wikidata... I cheated a little to get it, but I have it :D [12:08:05] hoo: the 1 ? [12:08:37] (03PS6) 10Kunalgrover05: API method for setting page language [core] - 10https://gerrit.wikimedia.org/r/143025 [12:08:37] (03CR) 10Florianschmidtwelzow: Add feature to restrict E-Maildomains (033 comments) [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142741 (https://bugzilla.wikimedia.org/67220) (owner: 10Florianschmidtwelzow) [12:08:38] (03CR) 10jenkins-bot: [V: 04-1] API method for setting page language [core] - 10https://gerrit.wikimedia.org/r/143025 (owner: 10Kunalgrover05) [12:08:49] (03PS8) 10Kunalgrover05: Check permissions for Protected and semi protected pages [core] - 10https://gerrit.wikimedia.org/r/143015 [12:08:52] 3Wikimedia / 3Site requests: Create wikimania2015wiki - 10https://bugzilla.wikimedia.org/66370#c7 (10Sam Reed (reedy)) 5PATC>3RESO/FIX a:3Sam Reed (reedy) Created [12:09:06] 3MediaWiki extensions / 3WikidataRepo: Implement wbsetredirect API module - 10https://bugzilla.wikimedia.org/65584 (10Lydia Pintscher) [12:09:28] hashar: Yes.. Reedy only got the 2, although he created the wiki [12:09:48] hoo: sorry I don't understand anything you are talking about :D [12:10:06] 3MediaWiki extensions / 3WikidataRepo: Automatically resolve redirects in the EntityLookup service. - 10https://bugzilla.wikimedia.org/66075 (10Lydia Pintscher) [12:10:23] hashar: User ids :P [12:10:32] hoo: No I didn't [12:10:33] I was so proud of my ID : 21 on frwiki whenever I browse Special:Preferences [12:10:42] Reedy: Pretty sure you did [12:10:56] [12:11:11] [12:57:20] Slightly more confusing... [12:11:11] [12:57:23] :D [12:11:11] [12:57:39] userids on wikimania2015wiki start at 12 [12:11:11] [12:57:46] for MediaWiki message delivery [12:11:11] [12:57:48] and I get 14 [12:11:11] [12:57:50] No 13 [12:11:18] Reedy: Wikidata :P [12:11:21] Ohh [12:11:28] I have quite a new no 1s [12:11:29] * Reedy grins [12:11:30] * hoo managed to confused everyone it seems [12:11:31] hoo: ah you got user id 1 on wikidata :-D [12:11:33] hoo: kudos! [12:12:04] (03PS7) 10Kunalgrover05: API method for setting page language [core] - 10https://gerrit.wikimedia.org/r/143025 [12:12:30] I hate doing one thing [12:12:36] Then finding 3 more that needed to be fixed [12:13:02] then 12 mores and it is time to get to bed [12:13:13] lol [12:13:21] yeah, hashar, it's part of the unstoppable push against nonnismo [12:14:07] * Nemo_bis hopes it's understandable in French [12:14:21] 3Wikimedia / 3General/Unknown: If one attempts a file upload in Commons, and the file name has unacceptable characters, there is an upload failure but no appropriate error message indicting why. - 10https://bugzilla.wikimedia.org/67197#c6 (10Lane Rasberry) We diverged at your step 9. You took an unprompted a... [12:14:51] 3MediaWiki extensions / 3WikidataClient: "Other projects sidebar" beta feature - 10https://bugzilla.wikimedia.org/66718 (10Lydia Pintscher) [12:14:57] (03CR) 10Rillke: "and I31dddeb4e6373f5817fdf" [core] - 10https://gerrit.wikimedia.org/r/135714 (https://bugzilla.wikimedia.org/65757) (owner: 10Rillke) [12:15:50] (03PS3) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/143262 [12:17:06] 3MediaWiki extensions / 3CodeEditor: Add support for mobile - 10https://bugzilla.wikimedia.org/67328#c3 (10Andre Klapper) Urgh. I'm stupid and need more coffee. Thanks. :( [12:19:36] 3Wikimedia / 3SSL related: Rename wikis with multiple subdomains - 10https://bugzilla.wikimedia.org/31335#c15 (10Sam Reed (reedy)) https://gerrit.wikimedia.org/r/#/c/134939/ Just noticed an issue in InitialiseSettings.php But the apache config looks broken... reedy@tin:~$ apache-fast-test ~/urls.txt pybal... [12:19:50] (03CR) 10PleaseStand: [C: 031] Reword lede in release-notes security reminder (031 comment) [core] - 10https://gerrit.wikimedia.org/r/142814 (owner: 10Withoutaname) [12:20:36] 3MediaWiki extensions / 3WikidataRepo: Do not omit empty fields from JSON - 10https://bugzilla.wikimedia.org/66791#c2 (10Lydia Pintscher) Current status: Seems to only still need to be done for claims. [12:21:21] 3MediaWiki extensions / 3WikidataRepo: Create tests comparing the output of the old and new serializer implementation - 10https://bugzilla.wikimedia.org/66839 (10Lydia Pintscher) [12:25:06] 3Wikimedia / 3SSL related: Rename wikis with multiple subdomains - 10https://bugzilla.wikimedia.org/31335#c16 (10Sam Reed (reedy)) p:5High>3Normal https://gerrit.wikimedia.org/r/143281 https://gerrit.wikimedia.org/r/#/c/134948/ Ok, so now https://noboard-chapters.wikimedia.org/ works. The redirect does... [12:25:51] 3Wikimedia / 3SSL related: Add Forward Secrecy - 10https://bugzilla.wikimedia.org/53259#c11 (10Jan Zerebecki) For the potential impact on HTTPS clients Chris Steipp told me on IRC he looked into what I assume is EventLogging data and later told me that Oliver had done some analysis work on that. I wanted to... [12:28:06] 3MediaWiki extensions / 3WikidataRepo: Track entity redirects in a database table (associated with the wb_entity_per_page table). - 10https://bugzilla.wikimedia.org/66582#c4 (10Lydia Pintscher) 5NEW>3RESO/WON We are not going to track them for now. [12:31:21] 3MediaWiki extensions / 3WikidataRepo: Track entity redirects in a database table (associated with the wb_entity_per_page table). - 10https://bugzilla.wikimedia.org/66582#c5 (10Lydia Pintscher) 5RESO/WON>3REOP Needed after all. [12:31:51] 3MediaWiki extensions / 3WikidataRepo: Don't treat referenced entities that are redirects as deleted in the UI - 10https://bugzilla.wikimedia.org/66971 (10Lydia Pintscher) [12:37:21] 3MediaWiki extensions / 3WikidataRepo: Gracefully handle entity redirects in maintenance scripts. - 10https://bugzilla.wikimedia.org/66581 (10Lydia Pintscher) [12:37:36] (03CR) 10Gilles: [C: 032] Unescape() is never the right answer. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/142185 (owner: 10Brian Wolff) [12:37:47] (03Merged) 10jenkins-bot: Unescape() is never the right answer. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/142185 (owner: 10Brian Wolff) [12:38:21] 3MediaWiki extensions / 3WikidataRepo: Track entity redirects in a database table (associated with the wb_entity_per_page table). - 10https://bugzilla.wikimedia.org/66582 (10Lydia Pintscher) [12:38:21] 3MediaWiki extensions / 3WikidataRepo: Gracefully handle entity redirects in maintenance scripts. - 10https://bugzilla.wikimedia.org/66581 (10Lydia Pintscher) [12:39:21] 3MediaWiki extensions / 3WikidataRepo: Don't treat referenced entities that are redirects as deleted in the UI - 10https://bugzilla.wikimedia.org/66971 (10Lydia Pintscher) [12:39:51] 3MediaWiki extensions / 3WikidataRepo: Track entity redirects in a database table (associated with the wb_entity_per_page table). - 10https://bugzilla.wikimedia.org/66582 (10Lydia Pintscher) [12:39:51] 3MediaWiki extensions / 3WikidataRepo: Don't treat referenced entities that are redirects as deleted in the UI - 10https://bugzilla.wikimedia.org/66971 (10Lydia Pintscher) [12:42:47] Reedy: I have got a bunch of sqlite patches for you to review :D [12:43:14] https://gerrit.wikimedia.org/r/#/q/owner:hashar+is:open+message:sqlite+project:%255Emediawiki/extensions.*,n,z :D [12:43:34] (03CR) 10SG: mw-ui-button: Revamp the LESS to be simpler, and improve cross-browser support (031 comment) [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [12:43:36] 3MediaWiki extensions / 3WikidataRepo: Gracefully handle entity redirects in maintenance scripts. - 10https://bugzilla.wikimedia.org/66581 (10Lydia Pintscher) [12:44:41] (03CR) 10SG: "@Swalling Didn't notice your comment. This patch itself, when applied, generates an overhauled living style guide." [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [12:45:06] (03PS3) 10Kunalgrover05: Use backend method in Special:PageLanguage to change language [core] - 10https://gerrit.wikimedia.org/r/143049 [12:46:50] (03PS9) 10Kunalgrover05: Check permissions for Protected and semi protected pages [core] - 10https://gerrit.wikimedia.org/r/143015 [12:48:03] (03PS4) 10Kunalgrover05: Use backend method in Special:PageLanguage to change language [core] - 10https://gerrit.wikimedia.org/r/143049 [12:48:06] 3MediaWiki extensions / 3MarkAsHelpful: MarkAsHelpful uses deprecated jQuery functions - 10https://bugzilla.wikimedia.org/67356 (10Andre Klapper) p:5Unprio>3High [12:48:21] 3MediaWiki extensions / 3WikimediaMaintenance: Create Echo tables using addExtensionTable.php on extension1 - 10https://bugzilla.wikimedia.org/67358 (10Andre Klapper) p:5Unprio>3Normal [12:48:21] 3MediaWiki extensions / 3WikimediaMaintenance: addWiki should create database on extension1 - 10https://bugzilla.wikimedia.org/67357 (10Andre Klapper) p:5Unprio>3Normal [12:49:33] (03CR) 10Gilles: [C: 032] Remove compatibility code for class FormatExif [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/141479 (owner: 10Umherirrender) [12:49:47] (03Merged) 10jenkins-bot: Remove compatibility code for class FormatExif [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/141479 (owner: 10Umherirrender) [12:55:51] 3Wikimedia / 3SSL related: Add Forward Secrecy - 10https://bugzilla.wikimedia.org/53259#c12 (10Nemo) (In reply to Jan Zerebecki from comment #11) > It would be interesting if we could publish an aggregated > and anonymized analysis of the before and after comparison. You know about: * https://gdash.wikimedi... [13:02:36] 3MediaWiki extensions / 3CodeEditor: Add support for mobile - 10https://bugzilla.wikimedia.org/67328#c4 (10paladox2015) Ace code editor does not work well on mobiles. [13:08:20] (03PS20) 10Hashar: (WIP) Experiment zuul-cloner with extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141846 [13:08:33] (03PS1) 10Matthias Mullie: Streamline API error output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143284 [13:08:36] (03PS1) 10Matthias Mullie: Add generic JS error handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143285 [13:08:39] (03PS1) 10Matthias Mullie: Error handling for new-topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143286 [13:08:42] (03PS1) 10Matthias Mullie: Error handling for reply [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143287 [13:08:45] (03PS1) 10Matthias Mullie: Use shared method for both POST & GET to output errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143288 [13:08:48] (03PS1) 10Matthias Mullie: Error handling for view-header & edit-header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143289 [13:08:51] (03PS1) 10Matthias Mullie: Error handling for view-post & edit-post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143290 [13:08:54] (03PS1) 10Matthias Mullie: Error handling for edit-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143291 [13:08:57] (03PS1) 10Matthias Mullie: Error handling for preview [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143292 [13:09:00] (03PS1) 10Matthias Mullie: Error handling for view-topic-summary & edit-topic-summary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143293 [13:09:03] (03CR) 10Hashar: "bring in intersection, default entry point created" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141846 (owner: 10Hashar) [13:09:06] (03CR) 10jenkins-bot: [V: 04-1] Error handling for view-post & edit-post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143290 (owner: 10Matthias Mullie) [13:09:34] Reedy: piiiing :D [13:10:54] (03CR) 10Matthias Mullie: Streamline API error output (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143284 (owner: 10Matthias Mullie) [13:12:23] 3Wikimedia / 3Site requests: Please upload large file to Commons - 10https://bugzilla.wikimedia.org/67360 (10Zell Faze) 3UNCO p:3Unprio s:3enhanc a:3None I have a video that I attempted to upload using Chunked uploads, but the upload seems to have not worked properly and the file got messed up. I ca... [13:12:31] (03PS8) 10Gerrit Patch Uploader: Rework mediawiki.feedback.js [core] - 10https://gerrit.wikimedia.org/r/105457 [13:12:33] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/105457 (owner: 10Gerrit Patch Uploader) [13:16:21] 3MediaWiki extensions / 3WikidataRepo: Don't break entity if secondary database updates fail - 10https://bugzilla.wikimedia.org/64604 (10Lydia Pintscher) [13:16:36] 3MediaWiki extensions / 3WikidataRepo: Don't break entity if secondary database updates fail - 10https://bugzilla.wikimedia.org/64604 (10Lydia Pintscher) [13:16:36] 3MediaWiki extensions / 3WikidataRepo: Query by one property and one value (tracking) - 10https://bugzilla.wikimedia.org/52385 (10Lydia Pintscher) [13:18:06] 3MediaWiki extensions / 3WikibaseQuery: Create script that generates schema creation SQL - 10https://bugzilla.wikimedia.org/66421 (10Lydia Pintscher) 5NEW>3RESO/FIX [13:19:22] 3Wikimedia / 3Git/Gerrit: Deprecate/close mediawiki/extensions/skins - 10https://bugzilla.wikimedia.org/60927#c3 (10christian) When just looking at just the files in mediawiki/extensions/skins, it seems that the contained * Daddio * Donate * Schulenburg * Synagonism * Tomas * p2wiki skins haven't yet had a... [13:20:07] (03CR) 10Parent5446: [C: 032] Sqlite compatibility [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/143014 (https://bugzilla.wikimedia.org/65877) (owner: 10Hashar) [13:20:09] (03PS1) 10Hashar: Sqlite compatibility [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/143294 (https://bugzilla.wikimedia.org/65896) [13:20:14] (03Merged) 10jenkins-bot: Sqlite compatibility [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/143014 (https://bugzilla.wikimedia.org/65877) (owner: 10Hashar) [13:21:05] (03CR) 10Parent5446: [C: 032] Sqlite compatibility [extensions/AccountAudit] - 10https://gerrit.wikimedia.org/r/143011 (https://bugzilla.wikimedia.org/65875) (owner: 10Hashar) [13:21:11] (03Merged) 10jenkins-bot: Sqlite compatibility [extensions/AccountAudit] - 10https://gerrit.wikimedia.org/r/143011 (https://bugzilla.wikimedia.org/65875) (owner: 10Hashar) [13:21:14] :-) [13:21:33] (03CR) 10Parent5446: [C: 032] Sqlite compatibility [extensions/CommunityVoice] - 10https://gerrit.wikimedia.org/r/143012 (https://bugzilla.wikimedia.org/65876) (owner: 10Hashar) [13:21:40] (03Merged) 10jenkins-bot: Sqlite compatibility [extensions/CommunityVoice] - 10https://gerrit.wikimedia.org/r/143012 (https://bugzilla.wikimedia.org/65876) (owner: 10Hashar) [13:22:24] (03PS1) 10Matthias Mullie: Remove unused variables [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143295 [13:22:46] (03CR) 10Parent5446: [C: 04-1] Sqlite compatibility (031 comment) [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/143294 (https://bugzilla.wikimedia.org/65896) (owner: 10Hashar) [13:23:11] (03PS1) 10Matthias Mullie: Remove unused variable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143296 [13:23:48] (03PS21) 10Hashar: (WIP) Experiment zuul-cloner with extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141846 [13:24:07] 3MediaWiki extensions / 3[other]: CommunityVoice does not pass Jenkins unit tests (sqlite compatibility) - 10https://bugzilla.wikimedia.org/65876 (10Tyler Romeo) 5PATC>3RESO/FIX [13:24:18] (03PS1) 10Manybubbles: Configure cache warmers [extensions/CirrusSearch] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143297 (https://bugzilla.wikimedia.org/67094) [13:24:20] (03CR) 10Hashar: "Adding in extensions that had sqlite fixed:" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141846 (owner: 10Hashar) [13:24:37] 3MediaWiki extensions / 3[other]: AccountAudit does not pass Jenkins unit tests - 10https://bugzilla.wikimedia.org/65875 (10Tyler Romeo) 5PATC>3RESO/FIX [13:24:52] 3MediaWiki extensions / 3CreditsSource: CreditsSource does not pass Jenkins unit tests (sqlite compatibility) - 10https://bugzilla.wikimedia.org/65877 (10Tyler Romeo) 5PATC>3RESO/FIX [13:26:36] 3MediaWiki extensions / 3WikidataRepo: write script that touches every item and thereby updates database tables - 10https://bugzilla.wikimedia.org/64600 (10Lydia Pintscher) [13:26:51] 3MediaWiki extensions / 3WikidataRepo: Query by one property and one value (tracking) - 10https://bugzilla.wikimedia.org/52385 (10Lydia Pintscher) [13:28:06] (03CR) 10Hashar: Sqlite compatibility (031 comment) [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/143294 (https://bugzilla.wikimedia.org/65896) (owner: 10Hashar) [13:28:14] (03PS2) 10Hashar: Sqlite compatibility [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/143294 (https://bugzilla.wikimedia.org/65896) [13:30:21] (03PS1) 10Hashar: Make some extensions voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/143298 (https://bugzilla.wikimedia.org/65875) [13:31:28] (03CR) 10Hashar: [C: 032] Make some extensions voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/143298 (https://bugzilla.wikimedia.org/65875) (owner: 10Hashar) [13:31:33] (03Merged) 10jenkins-bot: Make some extensions voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/143298 (https://bugzilla.wikimedia.org/65875) (owner: 10Hashar) [13:33:36] 3MediaWiki extensions / 3WikidataRepo: cannot reorder snaks within a reference - 10https://bugzilla.wikimedia.org/65695 (10Lydia Pintscher) [13:34:07] 3MediaWiki / 3API: Remove API action=parse&prop=languageshtml in 1.24 - 10https://bugzilla.wikimedia.org/67149 (10Rohan Rawat) a:3Rohan Rawat [13:35:08] 3MediaWiki extensions / 3CreditsSource: CreditsSource does not pass Jenkins unit tests (sqlite compatibility) - 10https://bugzilla.wikimedia.org/65877 (10Antoine "hashar" Musso) 5PATC>3RESO/FIX a:3Antoine "hashar" Musso [13:35:24] 3MediaWiki extensions / 3[other]: AccountAudit does not pass Jenkins unit tests - 10https://bugzilla.wikimedia.org/65875 (10Antoine "hashar" Musso) 5PATC>3RESO/FIX a:3Antoine "hashar" Musso [13:35:38] 3MediaWiki extensions / 3[other]: CommunityVoice does not pass Jenkins unit tests (sqlite compatibility) - 10https://bugzilla.wikimedia.org/65876 (10Antoine "hashar" Musso) 5PATC>3RESO/FIX a:3Antoine "hashar" Musso [13:36:30] (03PS1) 10Rohan013: Removes 'languageshtml' property in mediawiki API's 'parse' action [core] - 10https://gerrit.wikimedia.org/r/143299 (https://bugzilla.wikimedia.org/67149) [13:36:36] 3MediaWiki extensions / 3WikidataRepo: not possible to change rank alone - 10https://bugzilla.wikimedia.org/66633 (10Lydia Pintscher) [13:36:51] 3MediaWiki extensions / 3WikidataRepo: not possible to change rank alone - 10https://bugzilla.wikimedia.org/66633 (10Lydia Pintscher) [13:36:52] 3MediaWiki extensions / 3WikidataRepo: not possible to change rank alone - 10https://bugzilla.wikimedia.org/66633 (10Lydia Pintscher) 5PATC>3RESO/FIX [13:37:16] (03PS1) 10Yaron Koren: Added new parser function, #get_soap_data [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/143300 [13:37:39] (03PS1) 10Matthias Mullie: Use {{int:}} to refer to a specific message's text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143301 [13:38:11] (03PS10) 10Paladox: Update jQuery.appear.js [core] - 10https://gerrit.wikimedia.org/r/139470 [13:39:56] (03CR) 10Yaron Koren: [C: 032 V: 032] Added new parser function, #get_soap_data [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/143300 (owner: 10Yaron Koren) [13:40:04] (03PS1) 10Bartosz Dziewoński: Setup.php: Move hacky skin requires higher up [core] - 10https://gerrit.wikimedia.org/r/143302 (https://bugzilla.wikimedia.org/67318) [13:40:36] 3MediaWiki extensions / 3WikidataRepo: Don't treat referenced entities that are redirects as deleted in the UI - 10https://bugzilla.wikimedia.org/66971 (10Lydia Pintscher) [13:40:37] (03CR) 10Parent5446: [C: 04-1] Added SwiftMailer Extension to provide an alternate for UserMailer (0317 comments) [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 (owner: 1001tonythomas) [13:44:50] (03PS22) 10Hashar: (WIP) Experiment zuul-cloner with extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141846 [13:45:19] (03CR) 10Parent5446: [C: 032] Sqlite compatibility [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/143294 (https://bugzilla.wikimedia.org/65896) (owner: 10Hashar) [13:45:55] (03Merged) 10jenkins-bot: Sqlite compatibility [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/143294 (https://bugzilla.wikimedia.org/65896) (owner: 10Hashar) [13:46:18] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Needs release notes." [core] - 10https://gerrit.wikimedia.org/r/143299 (https://bugzilla.wikimedia.org/67149) (owner: 10Rohan013) [13:46:46] (03CR) 10Chad: [C: 032] Configure cache warmers [extensions/CirrusSearch] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143297 (https://bugzilla.wikimedia.org/67094) (owner: 10Manybubbles) [13:46:49] (03PS1) 10Hashar: intersection unit tests non voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/143307 [13:47:22] (03Merged) 10jenkins-bot: Configure cache warmers [extensions/CirrusSearch] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143297 (https://bugzilla.wikimedia.org/67094) (owner: 10Manybubbles) [13:47:34] (03CR) 10Hashar: [C: 032] intersection unit tests non voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/143307 (owner: 10Hashar) [13:47:36] (03CR) 10Parent5446: [C: 032] Function type hints for LinkHolderArray.php [core] - 10https://gerrit.wikimedia.org/r/143221 (owner: 10Reedy) [13:47:49] (03CR) 10Parent5446: [C: 032] Setup.php: Move hacky skin requires higher up [core] - 10https://gerrit.wikimedia.org/r/143302 (https://bugzilla.wikimedia.org/67318) (owner: 10Bartosz Dziewoński) [13:48:22] (03Merged) 10jenkins-bot: intersection unit tests non voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/143307 (owner: 10Hashar) [13:48:28] (03PS1) 10Chad: Updating CirrusSearch to pick up cache warming [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143308 [13:48:56] (03CR) 10Hashar: "recheck" [extensions/intersection] - 10https://gerrit.wikimedia.org/r/54460 (owner: 10Hashar) [13:50:29] (03CR) 10Parent5446: Subclass the Action class under ContextSource (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143211 (owner: 10Withoutaname) [13:51:48] (03CR) 10Chad: "Nothing makes me happier than seeing these classes smaller. Maybe one day they'll be small enough that we can delete them." [core] - 10https://gerrit.wikimedia.org/r/143211 (owner: 10Withoutaname) [13:51:53] (03CR) 10Parent5446: "I really don't think we have any obligation to wait for extensions to stop using things that have been deprecated for more than a release." [core] - 10https://gerrit.wikimedia.org/r/143207 (owner: 10Withoutaname) [13:52:30] Reedy: may I get like 10 - 15 minutes of your time to quick approve a bunch of patches please ? :D [13:52:39] Yeah [13:52:48] I'm currently waiting on my sister having a cigarette break ;) [13:52:51] (03CR) 10Chad: "Obligation? No. But we can at least be *kind* to extensions that do host their code in our repos." [core] - 10https://gerrit.wikimedia.org/r/143207 (owner: 10Withoutaname) [13:52:53] a default PHP entry point for 'intersection' extension https://gerrit.wikimedia.org/r/#/c/54460/ [13:52:55] hehe [13:53:10] and a sqlite compatibility for OATHAuth https://gerrit.wikimedia.org/r/#/c/143023/ [13:53:14] seems parent merged the rest [13:53:21] (03Merged) 10jenkins-bot: Function type hints for LinkHolderArray.php [core] - 10https://gerrit.wikimedia.org/r/143221 (owner: 10Reedy) [13:53:24] (03Merged) 10jenkins-bot: Setup.php: Move hacky skin requires higher up [core] - 10https://gerrit.wikimedia.org/r/143302 (https://bugzilla.wikimedia.org/67318) (owner: 10Bartosz Dziewoński) [13:54:12] (03CR) 10Rohan013: "Should i write this under Web API changes or other changes ?" [core] - 10https://gerrit.wikimedia.org/r/143299 (https://bugzilla.wikimedia.org/67149) (owner: 10Rohan013) [13:55:00] (03CR) 10Parent5446: "Define kind. If you mean giving the developers of the extension a heads up and then waiting a few days or so before merging, then that's f" [core] - 10https://gerrit.wikimedia.org/r/143207 (owner: 10Withoutaname) [13:55:50] (03CR) 10Reedy: [C: 032] provide default entry point [extensions/intersection] - 10https://gerrit.wikimedia.org/r/54460 (owner: 10Hashar) [13:55:51] 3MediaWiki extensions / 3TitleKey: TitleKey does not pass Jenkins unit tests (sqlite compatibility) - 10https://bugzilla.wikimedia.org/65896 (10Antoine "hashar" Musso) 5PATC>3RESO/FIX [13:56:05] hashar: maybe we should rename the extension properly? ;) [13:56:07] (03Merged) 10jenkins-bot: provide default entry point [extensions/intersection] - 10https://gerrit.wikimedia.org/r/54460 (owner: 10Hashar) [13:56:08] 3MediaWiki extensions / 3TitleKey: TitleKey does not pass Jenkins unit tests (sqlite compatibility) - 10https://bugzilla.wikimedia.org/65896 (10Antoine "hashar" Musso) a:3Antoine "hashar" Musso [13:56:28] (03PS2) 10Reedy: Supports sqlite [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/143023 (https://bugzilla.wikimedia.org/67297) (owner: 10Hashar) [13:56:29] Reedy: the files are DynamicProxyList or something, which is already an extension :/ [13:56:31] maybe a rewrite [13:56:34] (03CR) 10Reedy: [C: 032] Supports sqlite [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/143023 (https://bugzilla.wikimedia.org/67297) (owner: 10Hashar) [13:56:35] Oh [13:56:40] Can you say clusterfuck? [13:57:23] 3MediaWiki extensions / 3WikidataRepo: Creating items broken on beta wikidata - 10https://bugzilla.wikimedia.org/67361 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Catchable fatal error: Argument 2 passed to Wikibase\Repo\View\SiteLinksView::getHtml() must be an instance of Wikibase\DataModel\E... [13:57:29] clusterfuck [13:57:38] 3MediaWiki extensions / 3WikidataRepo: check if it is possible to add references to claims on properties - 10https://bugzilla.wikimedia.org/67362 (10Lydia Pintscher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs It should not be possible to add references to claims on properties. Please check this is act... [13:57:52] 3MediaWiki extensions / 3WikidataRepo: Creating items broken on beta wikidata - 10https://bugzilla.wikimedia.org/67361#c1 (10Aude) or broken if you have SpamBlacklist enabled [13:58:07] 3MediaWiki extensions / 3OATHAuth: unittest_oathauth_users table not created under sqlite - 10https://bugzilla.wikimedia.org/67297 (10Antoine "hashar" Musso) 5PATC>3RESO/FIX a:5Ryan Lane>3Antoine "hashar" Musso [13:58:18] (03Merged) 10jenkins-bot: Supports sqlite [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/143023 (https://bugzilla.wikimedia.org/67297) (owner: 10Hashar) [13:58:29] (03PS1) 10Manybubbles: Request parameter for term weight in highlighting [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/143311 [13:58:54] (03CR) 10Parent5446: [C: 031] Move action=render from Article subclasses to RenderAction [core] - 10https://gerrit.wikimedia.org/r/141359 (owner: 10Withoutaname) [13:58:59] (03PS2) 10Rohan013: Removes 'languageshtml' property in mediawiki API's 'parse' action [core] - 10https://gerrit.wikimedia.org/r/143299 (https://bugzilla.wikimedia.org/67149) [13:59:09] Reedy: thanks. I think that is all for now :] [13:59:22] OAI might need a sqlite patch as well [13:59:51] 3MediaWiki extensions / 3WikidataRepo: check if it is possible to add references to claims on properties - 10https://bugzilla.wikimedia.org/67362 (10Lydia Pintscher) p:5Unprio>3Normal [13:59:51] (03CR) 10Parent5446: [C: 04-1] Replaces gzopen() function with gzopen64() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/142287 (https://bugzilla.wikimedia.org/66952) (owner: 10Rohan013) [13:59:56] * hashar waits for https://integration.wikimedia.org/ci/job/mediawiki-core-extensions-integration/56/console [14:00:30] Hi [14:01:41] (03PS1) 10Manybubbles: Update CirrusSearch to pick up cache warmers [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143312 [14:01:48] Can anybody tell me what knowledge should require for contributing for Wikimedia [14:01:53] 3MediaWiki extensions / 3WikidataRepo: write browser tests for rank change - 10https://bugzilla.wikimedia.org/67363 (10Lydia Pintscher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs We need browser tests for changing the rank of a statement. [14:02:21] 3MediaWiki extensions / 3WikidataRepo: write browser tests for rank change - 10https://bugzilla.wikimedia.org/67363 (10Lydia Pintscher) p:5Unprio>3Normal [14:03:23] 3MediaWiki extensions / 3WikidataRepo: write browser tests for snak type changes - 10https://bugzilla.wikimedia.org/67364 (10Lydia Pintscher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs We need browser tests for changing the snak type of a statement. [14:03:45] (03PS28) 10Paladox: mediawiki.searchSuggest: Enable for iPhone and iPod touch [core] - 10https://gerrit.wikimedia.org/r/139809 [14:03:51] 3MediaWiki extensions / 3WikidataRepo: write browser tests for snak type changes - 10https://bugzilla.wikimedia.org/67364 (10Lydia Pintscher) p:5Unprio>3Normal [14:04:06] 3MediaWiki extensions / 3WikidataRepo: write browser tests for rank change - 10https://bugzilla.wikimedia.org/67363 (10Lydia Pintscher) [14:04:06] 3MediaWiki extensions / 3WikidataRepo: not possible to change rank alone - 10https://bugzilla.wikimedia.org/66633 (10Lydia Pintscher) [14:04:21] 3Wikimedia / 3Site requests: Please upload large file to Commons - 10https://bugzilla.wikimedia.org/67360#c1 (10Andre Klapper) Please provide a URL that can be accessed without clicking stuff in a webbrowser. $:andre\> wget https://mega.co.nz/\#\!TkokgKBb\!Xe0J2aCsjPNgWZKfsHLw_m0wNYPy6Cdy_5G_BwtHPO0 --2014-... [14:04:26] (03PS29) 10Paladox: mediawiki.searchSuggest: Enable for iPhone and iPod touch [core] - 10https://gerrit.wikimedia.org/r/139809 [14:04:38] samsruti: https://www.mediawiki.org/wiki/How_to_contribute [14:04:49] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.searchSuggest: Enable for iPhone and iPod touch [core] - 10https://gerrit.wikimedia.org/r/139809 (owner: 10Paladox) [14:04:51] (03CR) 10Paladox: [C: 031] mediawiki.searchSuggest: Enable for iPhone and iPod touch [core] - 10https://gerrit.wikimedia.org/r/139809 (owner: 10Paladox) [14:04:59] 29 patchsets? wtf dude [14:05:01] Nemo_bis Thanks [14:05:11] what happened to that patch D: [14:06:52] 3MediaWiki / 3Skin and page rendering: messages from skin i18n not loaded for $wgLanguageCode != en - 10https://bugzilla.wikimedia.org/67318 (10Bartosz Dziewoński) 5PATC>3RESO/FIX a:3Bartosz Dziewoński [14:06:53] 3MediaWiki extensions / 3WikidataRepo: investigate if there are any issues with making Wikidata.org its own client - 10https://bugzilla.wikimedia.org/67365 (10Lydia Pintscher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Investigate if Wikidata.org can be its own client currently without issues. This me... [14:07:21] 3MediaWiki extensions / 3WikidataRepo: investigate if there are any issues with making Wikidata.org its own client - 10https://bugzilla.wikimedia.org/67365 (10Lydia Pintscher) p:5Unprio>3High [14:07:39] (03CR) 10Bartosz Dziewoński: [C: 031] Removes 'languageshtml' property in mediawiki API's 'parse' action [core] - 10https://gerrit.wikimedia.org/r/143299 (https://bugzilla.wikimedia.org/67149) (owner: 10Rohan013) [14:07:51] 3MediaWiki extensions / 3WikidataRepo: cannot reorder snaks within a reference - 10https://bugzilla.wikimedia.org/65695#c3 (10Henning) 5REOP>3PATC https://gerrit.wikimedia.org/r/#/c/143313/ [14:08:06] (03CR) 10Hashar: "That is a bug in PHP: https://bugs.php.net/bug.php?id=53829" [core] - 10https://gerrit.wikimedia.org/r/142287 (https://bugzilla.wikimedia.org/66952) (owner: 10Rohan013) [14:08:15] (03CR) 10Rohan013: "I am sorry, but i don't understand what you mean." [core] - 10https://gerrit.wikimedia.org/r/142287 (https://bugzilla.wikimedia.org/66952) (owner: 10Rohan013) [14:09:06] 3MediaWiki / 3Maintenance scripts: generateSitemap.php gzopen() fatal error on Ubuntu 14.04 (replace gzopen() by gzopen64()) - 10https://bugzilla.wikimedia.org/66952#c4 (10Antoine "hashar" Musso) That is a bug in PHP: https://bugs.php.net/bug.php?id=53829 With a matching bug in Ubuntu: https://bugs.launchpa... [14:09:36] 3MediaWiki / 3Maintenance scripts: generateSitemap.php gzopen() fatal error on Ubuntu 14.04 (replace gzopen() by gzopen64()) - 10https://bugzilla.wikimedia.org/66952 (10Antoine "hashar" Musso) [14:09:48] hashar: Do we have any good examples of unit tests that load data from a database / mock database? I'm working on CentralAuth tests and trying to figure out the best way to do that.. [14:09:57] Reedy: tests are more or less running https://integration.wikimedia.org/ci/job/mediawiki-core-extensions-integration/56/consoleFull [14:10:08] csteipp: none I know of :-/ [14:10:26] csteipp: I did a few mock in core for file access. Maybe grep for Mock under /tests/phpunit [14:10:37] (03PS16) 10Paladox: Update jquery.hoverintent to r7 [core] - 10https://gerrit.wikimedia.org/r/139687 [14:10:41] (03PS1) 10Matthias Mullie: Error handling for open/close topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143314 [14:10:44] (03PS1) 10Matthias Mullie: Error handling for moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143315 [14:10:47] (03PS1) 10Matthias Mullie: Let's not assume API always responds [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143316 [14:10:50] (03PS17) 10Paladox: Update jquery.hoverintent to r7 [core] - 10https://gerrit.wikimedia.org/r/139687 [14:11:39] csteipp: the whole point is that lot of our tests are more or less integration tests exercising the whole stack :/ Mocking DB access might not be easy [14:12:06] csteipp: we could probably get some support added in core under MediaWikiTestCase this way everyone would benefit [14:12:11] (03CR) 10Matthias Mullie: Add generic JS error handling (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143285 (owner: 10Matthias Mullie) [14:12:29] (03PS18) 10Paladox: Update jquery.hoverintent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [14:13:40] hashar: Yeah, I don't mind testing multiple layers of the stack, I'm mostly trying to find a way run these without destroying the database at this point. [14:13:59] Glad to know I wasn't just missing where we already did that :) [14:14:09] (03PS19) 10Paladox: Update jquery.hoverintent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [14:14:31] (03CR) 10Bartosz Dziewoński: "That would break backwards-compatibility. The name is clear, User::isIP() checks if that "username" corresponds to an anonymous/"IP" user " [core] - 10https://gerrit.wikimedia.org/r/143234 (owner: 10Withoutaname) [14:14:56] (03CR) 10PleaseStand: [C: 04-1] Added VERP functionality hook to core (033 comments) [core] - 10https://gerrit.wikimedia.org/r/138655 (https://bugzilla.wikimedia.org/46640) (owner: 1001tonythomas) [14:15:29] (03CR) 10Chad: "I prefer giving a hand with patches if need be :)" [core] - 10https://gerrit.wikimedia.org/r/143207 (owner: 10Withoutaname) [14:15:38] (03Abandoned) 10Manybubbles: Updating CirrusSearch to pick up cache warming [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143308 (owner: 10Chad) [14:16:06] 3Wikimedia / 3Site requests: Please upload large file to Commons - 10https://bugzilla.wikimedia.org/67360#c2 (10Zell Faze) I probably should have thought about that. Sorry. Here you go. The file is 160MB and can be found here: https://www.zellfaze.org/tmp/Earthbag_Structure_Time-Lapse.ogv Description her... [14:17:13] (03PS20) 10Paladox: Update jquery.hoverintent to r7 [core] - 10https://gerrit.wikimedia.org/r/139687 [14:17:27] (03PS21) 10Paladox: Update jquery.hoverintent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [14:18:51] 3Wikimedia / 3SSL related: Rename wikis with multiple subdomains - 10https://bugzilla.wikimedia.org/31335#c17 (10Alex Monk) (In reply to Sam Reed (reedy) from comment #16) > The redirect doesn't (SSL complains) I'm pretty sure that's to be expected, isn't it? Is this bug fixed properly now? [14:19:32] (03CR) 10jenkins-bot: [V: 04-1] Error handling for open/close topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143314 (owner: 10Matthias Mullie) [14:19:37] (03Merged) 10jenkins-bot: mediawiki.searchSuggest: Enable for iPhone and iPod touch [core] - 10https://gerrit.wikimedia.org/r/139809 (owner: 10Paladox) [14:19:47] (03CR) 10jenkins-bot: [V: 04-1] Error handling for moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143315 (owner: 10Matthias Mullie) [14:20:06] 3Analytics / 3Refinery: Admin has duplicate monitoring in Icinga - 10https://bugzilla.wikimedia.org/67128#c2 (10Andrew Otto) The hive query for this is already written. The table will need to be manually created, and then this Hive query needs to be regularly scheduled by Oozie. Hive query: https://github.... [14:20:17] (03CR) 10jenkins-bot: [V: 04-1] Let's not assume API always responds [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143316 (owner: 10Matthias Mullie) [14:20:51] 3Analytics / 3Visualization: Maintainers have stack for EEVS dashboard server - 10https://bugzilla.wikimedia.org/67172 (10Dan Andreescu) [14:22:38] Reedy: and another last one for you https://gerrit.wikimedia.org/r/#/c/143253/ :D [14:22:59] Reedy: a hack for GlobalBlocking to point its shared database to the local one whenever being run under Jenkins [14:23:16] register_globals!!!!!!!!1oneoneone!11! [14:23:28] aahah [14:24:01] Can we put that in LocalSettings or something? [14:24:09] <^d> We really should stop caring about that. [14:24:15] mmm [14:24:26] I try to get all the custom setup directly in the extensions [14:24:35] much easier to hack than maintaining everything in a central repo [14:24:41] hi Chad :] [14:25:18] (03CR) 1001tonythomas: "@Parent5446: please check replies" (033 comments) [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 (owner: 1001tonythomas) [14:26:09] !log Stopping Jenkins it has some corrupted threads [14:27:26] <^d> hashar: Howdy :) [14:27:47] <^d> !log is Wrong channel [14:27:53] trying to get tests to pass with all wmf deployed extensions [14:28:09] <^d> No wm-bot here? Oh well. [14:29:06] yeah fixed [14:29:12] logged with more-bots in -ops [14:30:20] everything on tool labs is basically broken because SGE is broken [14:30:46] oh, wait, there is a morebots somewhere else? [14:31:22] valhallasw: in #wikimedia-operations , that logs to prod SAL on wikitech [14:31:36] ah. [14:31:49] btw, hashar, will you be at wikimania? [14:31:57] valhallasw: nop [14:32:11] (03PS1) 10Paladox: mediawiki.searchSuggest: Enable for iPhone and iPod touch [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/143320 [14:33:00] yeah PHPUnit completed Tests: 3122, Assertions: 5338, Failures: 49, Errors: 3, Skipped: 43. [14:33:04] not too bad [14:33:21] (03CR) 10Paladox: [C: 031] mediawiki.searchSuggest: Enable for iPhone and iPod touch [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/143320 (owner: 10Paladox) [14:33:36] 3Wikimedia / 3SSL related: Rename wikis with multiple subdomains - 10https://bugzilla.wikimedia.org/31335#c18 (10Sam Reed (reedy)) 5REOP>3RESO/FIX (In reply to Alex Monk from comment #17) > (In reply to Sam Reed (reedy) from comment #16) > > The redirect doesn't (SSL complains) > > I'm pretty sure that'... [14:33:36] 3 errors? [14:33:41] What are they? [14:34:06] (03PS2) 10Paladox: mediawiki.searchSuggest: Enable for iPhone and iPod touch [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/143320 [14:34:06] 00:09:22.137 1) DonationInterface_Adapter_GlobalCollect_GlobalCollectTestCase::testGCFormLoad [14:34:06] 00:09:22.138 DOMDocument::loadHTML(): Misplaced DOCTYPE declaration in Entity, line: 39 [14:34:07] 3Analytics / 3Refinery: Admin has duplicate monitoring in Icinga - 10https://bugzilla.wikimedia.org/67128 (10Dan Andreescu) a:3Dan Andreescu [14:34:09] 00:09:22.140 2) ArticleMetadataTest::testValidatePageId [14:34:09] 00:09:22.141 MWException: DatabaseBase::makeList: empty input for field ptrp_page_id [14:34:19] ptrp_page_id? [14:34:20] 00:09:22.144 3) DynamicPageList_tests::testParserTest with data set #19 ('mode=gallery (complex, no image)', ' .... [14:34:23] no clue :-D [14:34:28] traces available at https://integration.wikimedia.org/ci/job/mediawiki-core-extensions-integration/56/consoleFull [14:34:41] Page triage [14:35:09] File some bugs? ;) [14:35:09] (03CR) 10Paladox: [C: 031] mediawiki.searchSuggest: Enable for iPhone and iPod touch [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/143320 (owner: 10Paladox) [14:35:19] yeah :-( [14:35:25] I am tired of filling bugs [14:35:39] array ( 'ptrp_page_id' => $pageId ) can be an empty array [14:35:43] (03PS1) 10Hoo man: Remove obsolete hiphop code [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/143321 [14:36:28] Should be easily fixable [14:36:31] (03CR) 10Paladox: "Reason 6.0 or higher is http://jquery.com/browser-support/ only supports ios 6 or higher." [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/143320 (owner: 10Paladox) [14:37:22] (03PS4) 10Paladox: Enable WikiEditor toolbar on iOS [extensions/WikiEditor] (REL1_22) - 10https://gerrit.wikimedia.org/r/142872 (https://bugzilla.wikimedia.org/63277) [14:37:28] (03CR) 10jenkins-bot: [V: 04-1] Enable WikiEditor toolbar on iOS [extensions/WikiEditor] (REL1_22) - 10https://gerrit.wikimedia.org/r/142872 (https://bugzilla.wikimedia.org/63277) (owner: 10Paladox) [14:37:47] (03CR) 10Paladox: [C: 031] Enable WikiEditor toolbar on iOS [extensions/WikiEditor] (REL1_22) - 10https://gerrit.wikimedia.org/r/142872 (https://bugzilla.wikimedia.org/63277) (owner: 10Paladox) [14:38:28] (03PS14) 10Paladox: Update jquery.validate from 1.8.1 to 1.12.0 [core] - 10https://gerrit.wikimedia.org/r/139697 [14:38:51] (03PS15) 10Paladox: Update jquery.validate from 1.8.1 to 1.12.0 [core] - 10https://gerrit.wikimedia.org/r/139697 [14:39:22] (03PS11) 10Paladox: Update jQuery Cookie to v1.4.1 [core] - 10https://gerrit.wikimedia.org/r/139686 [14:39:38] 3MediaWiki extensions / 3[other]: PageTriage: test fail ArticleMetadataTest::testValidatePageId MWException: DatabaseBase::makeList: empty input for field ptrp_page_id - 10https://bugzilla.wikimedia.org/67366 (10Antoine "hashar" Musso) 3NEW p:3Unprio s:3normal a:3None 1) ArticleMetadataTest::testVali... [14:39:38] (03PS8) 10Paladox: Update jquery.form.js [core] - 10https://gerrit.wikimedia.org/r/139688 [14:39:55] (03PS12) 10Paladox: Update jquery.mockjax.js to v1.5.3 [core] - 10https://gerrit.wikimedia.org/r/139693 [14:40:03] (03CR) 10Jackmcbarn: Reword lede in release-notes security reminder (031 comment) [core] - 10https://gerrit.wikimedia.org/r/142814 (owner: 10Withoutaname) [14:40:11] (03PS10) 10Paladox: Update jquery.chosen folder and files [core] - 10https://gerrit.wikimedia.org/r/139699 [14:40:21] 3MediaWiki extensions / 3[other]: PageTriage: test fail ArticleMetadataTest::testValidatePageId MWException: DatabaseBase::makeList: empty input for field ptrp_page_id - 10https://bugzilla.wikimedia.org/67366#c1 (10Antoine "hashar" Musso) Reproduced with just the PageTriage extension and a sqlite backend: $... [14:40:21] hashar: Possible fix incoming... [14:40:34] reedy: PageTriage bug is https://bugzilla.wikimedia.org/show_bug.cgi?id=67366 [14:40:34] (03CR) 10Jackmcbarn: "Why not instead? There's no sense in doing the work twice." [core] - 10https://gerrit.wikimedia.org/r/143222 (owner: 10Reedy) [14:41:18] (03PS1) 10Hcohl: Amber first update [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/143323 [14:41:53] (03CR) 10Reedy: "What's wrong with making sure yourself?" [core] - 10https://gerrit.wikimedia.org/r/143222 (owner: 10Reedy) [14:42:02] (03PS1) 10Reedy: Check we still have pages after ArticleMetadata::validatePageId() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/143324 (https://bugzilla.wikimedia.org/67366) [14:42:22] (03CR) 10Jackmcbarn: Changing language purges the page (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143026 (owner: 10Kunalgrover05) [14:43:51] 3Wikimedia / 3Wikidata: Investigate if there are already claims for properties on wikidata.org - 10https://bugzilla.wikimedia.org/63072#c1 (10Lucie Kaffee) 5ASSI>3PATC The Script, that checks if there are already claims: https://github.com/frimelle/API-wikidata/blob/master/property-statements.py [14:44:58] (03CR) 10Parent5446: Update Special:ChangeEmail to use HTMLForm (038 comments) [core] - 10https://gerrit.wikimedia.org/r/142878 (owner: 10IAlex) [14:45:55] pff [14:46:00] ProofreadPages don't pass at all [14:46:06] Fatal error: Call to a member function getPageText() on a non-object in /Users/amusso/projects/mediawiki/extensions/ProofreadPage/includes/page/PageContentBuilder.php on line 73 [14:46:06] \O/ [14:46:10] (03CR) 10jenkins-bot: [V: 04-1] Amber first update [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/143323 (owner: 10Hcohl) [14:46:45] Tpt: ^^ Fancy fixing up ProofreadPage? [14:46:52] hashar: Tpt is fairly attentive with it usually [14:47:07] well they most probably pass when running standalone on jenkins [14:47:13] though they don't on my setup [14:47:42] Well, that one sounds like something not checking return values [14:47:46] So that's a bug nontheless [14:48:28] I am wondering why it pass on Jenkins but not on my setup bah [14:48:47] Because you're French? [14:48:52] Hmm, but isn't Tpt french? [14:48:53] * Reedy grins [14:48:59] hehe [14:49:14] (03PS1) 10Anomie: Allow for skipping Lua tests [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/143325 (https://bugzilla.wikimedia.org/67343) [14:49:30] Yes Tpt is french ;-) [14:49:48] $text = $image->getHandler()->getPageText( $image, 1 ); [14:50:26] hashar: I suspect your wiki isn't setup for the files [14:50:42] and Jenkins would ? [14:50:46] Possibly [14:51:17] It looks like an error in wiki configuration (because if the image is known as multipage it should have a valid handler) [14:51:25] hashar: djvu? [14:51:51] ahhhhh [14:54:53] Reedy: my hero [14:55:21] 3MediaWiki extensions / 3WikidataRepo: mockups for editing labels, description and aliases (page header) - 10https://bugzilla.wikimedia.org/66705 (10Lydia Pintscher) [14:55:51] 3MediaWiki extensions / 3WikidataRepo: mockups for editing statements - 10https://bugzilla.wikimedia.org/66707 (10Lydia Pintscher) [14:57:11] (03CR) 10Anomie: [C: 032] Removes 'languageshtml' property in mediawiki API's 'parse' action [core] - 10https://gerrit.wikimedia.org/r/143299 (https://bugzilla.wikimedia.org/67149) (owner: 10Rohan013) [14:58:11] (03CR) 10Paladox: [C: 031] Update jquery.hoverintent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 (owner: 10Paladox) [15:00:02] (03CR) 10Pginer: mw-ui-button: Revamp the LESS to be simpler, and improve cross-browser support (031 comment) [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [15:00:07] 3Wikimedia / 3Wikidata: Investigate if there are already claims for properties on wikidata.org - 10https://bugzilla.wikimedia.org/63072 (10Lucie Kaffee) 5PATC>3RESO/FIX [15:00:48] (03Merged) 10jenkins-bot: Removes 'languageshtml' property in mediawiki API's 'parse' action [core] - 10https://gerrit.wikimedia.org/r/143299 (https://bugzilla.wikimedia.org/67149) (owner: 10Rohan013) [15:01:00] (03CR) 10Manybubbles: [C: 032] Update CirrusSearch to pick up cache warmers [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143312 (owner: 10Manybubbles) [15:02:21] 3Analytics / 3EventLogging: EventLogging needs process nanny alarm on hafnium - 10https://bugzilla.wikimedia.org/67309#c1 (10nuria) Update: there are process alarms set up on vanadium. The only ones missing were so on hafnium. [15:02:28] (03PS4) 10BryanDavis: Added jsonconfig & zero roles [vagrant] - 10https://gerrit.wikimedia.org/r/142832 (owner: 10Yurik) [15:02:33] (03PS11) 10Paladox: Update jQuery.appear.js [core] - 10https://gerrit.wikimedia.org/r/139470 [15:02:38] (03CR) 10BryanDavis: [C: 032] Added jsonconfig & zero roles [vagrant] - 10https://gerrit.wikimedia.org/r/142832 (owner: 10Yurik) [15:03:13] (03PS12) 10Paladox: Update jQuery.appear.js [core] - 10https://gerrit.wikimedia.org/r/139470 [15:03:51] (03PS13) 10Paladox: Update jQuery.appear.js [core] - 10https://gerrit.wikimedia.org/r/139470 [15:04:06] 3MediaWiki / 3API: Remove API action=parse&prop=languageshtml in 1.24 - 10https://bugzilla.wikimedia.org/67149 (10Bartosz Dziewoński) 5PATC>3RESO/FIX [15:04:16] (03Merged) 10jenkins-bot: Added jsonconfig & zero roles [vagrant] - 10https://gerrit.wikimedia.org/r/142832 (owner: 10Yurik) [15:04:42] (03PS14) 10Paladox: Update jQuery.appear.js [core] - 10https://gerrit.wikimedia.org/r/139470 [15:04:59] (03PS15) 10Paladox: Update jQuery.appear.js [core] - 10https://gerrit.wikimedia.org/r/139470 [15:05:08] (03Merged) 10jenkins-bot: Update CirrusSearch to pick up cache warmers [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143312 (owner: 10Manybubbles) [15:06:02] (03PS16) 10Paladox: Update jQuery.appear.js [core] - 10https://gerrit.wikimedia.org/r/139470 [15:08:13] (03PS17) 10Paladox: Update jQuery.appear.js [core] - 10https://gerrit.wikimedia.org/r/139470 [15:08:21] 3MediaWiki / 3User preferences: Special:Preferences buttons Save/Restore all default settings (in all sections) is confusing - 10https://bugzilla.wikimedia.org/67338#c2 (10WhatamIdoing) I asked the complainant about that bug, and he did not agree that it was exactly the same. [15:08:25] (03CR) 10Paladox: [C: 031] Update jQuery.appear.js [core] - 10https://gerrit.wikimedia.org/r/139470 (owner: 10Paladox) [15:09:49] (03PS22) 10Paladox: Update jquery.hoverintent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [15:09:52] (03PS2) 10Hcohl: Amber first update [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/143323 [15:10:01] (03CR) 10Paladox: [C: 031] Update jquery.hoverintent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 (owner: 10Paladox) [15:10:59] (03PS6) 10Jforrester: Switch from CSS to LESS and use MediaWiki's SVG fallback LESS function [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/123348 (https://bugzilla.wikimedia.org/56502) [15:12:01] (03CR) 10Hashar: "check experimental" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/143324 (https://bugzilla.wikimedia.org/67366) (owner: 10Reedy) [15:14:23] (03PS12) 10Paladox: Update jQuery Cookie to v1.4.1 [core] - 10https://gerrit.wikimedia.org/r/139686 [15:15:18] (03CR) 10jenkins-bot: [V: 04-1] Amber first update [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/143323 (owner: 10Hcohl) [15:15:53] 3MediaWiki / 3ResourceLoader: ResourceLoader: Remove custom LESS functions - 10https://bugzilla.wikimedia.org/67368 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None I think it was a design flaw that we went ahead with implementing php-land functions at all. It was a questionable experiment, but we know b... [15:15:59] (03PS18) 10Paladox: Update jQuery.appear.js [core] - 10https://gerrit.wikimedia.org/r/139470 [15:16:21] 3MediaWiki extensions / 3WikidataRepo: Creating items broken on beta wikidata - 10https://bugzilla.wikimedia.org/67361 (10Lydia Pintscher) [15:16:41] (03PS19) 10Paladox: Update jQuery.appear.js [core] - 10https://gerrit.wikimedia.org/r/139470 [15:16:54] (03PS20) 10Paladox: Update jQuery.appear.js [core] - 10https://gerrit.wikimedia.org/r/139470 [15:17:18] (03CR) 10Paladox: [C: 031] Update jQuery.appear.js [core] - 10https://gerrit.wikimedia.org/r/139470 (owner: 10Paladox) [15:17:21] 3MediaWiki extensions / 3WikidataRepo: Creating items broken on beta wikidata - 10https://bugzilla.wikimedia.org/67361 (10Lydia Pintscher) p:5Unprio>3Highes s:5normal>3critic [15:17:37] 3MediaWiki / 3ResourceLoader: ResourceLoaderLESSFunctions::embed does not support CSSJanus flipping for RTL - 10https://bugzilla.wikimedia.org/66091#c3 (10Krinkle) I've filed bug 67368 for the removal of the 'embed()' function. See there for more details on how this bug is caused. Note that we already do th... [15:17:39] 3MediaWiki extensions / 3GeoData: ApiQueryAllPages_GeoData duplicates ApiQueryAllPagesPrefix - 10https://bugzilla.wikimedia.org/67369 (10Chad H.) 3NEW p:3Unprio s:3normal a:3None Might be by design, but it causes a failing test for me: 1) PrefixUniquenessTest::testPrefixes Module prefix 'ap' is shar... [15:18:25] (03PS23) 10Paladox: Update jquery.hoverintent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [15:18:51] 3MediaWiki extensions / 3WikidataRepo: Adding site links is broken - 10https://bugzilla.wikimedia.org/67244 (10Lydia Pintscher) [15:19:18] (03CR) 10Anomie: [C: 04-1] "I still think it would be much better to make this a generator-using module like ApiPurge." (0310 comments) [core] - 10https://gerrit.wikimedia.org/r/143025 (owner: 10Kunalgrover05) [15:19:20] (03CR) 10Anomie: "This, I8777fc6b, and the part of I74482d5c that creates the "PageLanguage" class should probably be refactored into one patch, and then th" [core] - 10https://gerrit.wikimedia.org/r/143026 (owner: 10Kunalgrover05) [15:19:22] (03CR) 10Anomie: "This, I72aaaded, and the part of I74482d5c that creates the "PageLanguage" class should probably be refactored into one patch, and then th" [core] - 10https://gerrit.wikimedia.org/r/143049 (owner: 10Kunalgrover05) [15:19:36] 3MediaWiki / 3ResourceLoader: ResourceLoader: Remove custom LESS functions - 10https://bugzilla.wikimedia.org/67368#c1 (10Krinkle) Note that OOjs UI, for example, as being a standalone project, never used the 'embed()' function because we use its compiled distribution file which is already CSS (compiled by l... [15:20:21] 3MediaWiki / 3ResourceLoader: ResourceLoaderLESSFunctions::embed does not support CSSJanus flipping for RTL - 10https://bugzilla.wikimedia.org/66091 (10Krinkle) [15:20:21] 3MediaWiki / 3ResourceLoader: ResourceLoader: Remove custom LESS functions - 10https://bugzilla.wikimedia.org/67368 (10Krinkle) [15:20:22] 3MediaWiki / 3ResourceLoader: LESS compiler should preserve the position of CSSMin / CSSJanus annotations - 10https://bugzilla.wikimedia.org/54673 (10Krinkle) [15:21:06] 3MediaWiki / 3ResourceLoader: LESS compiler should preserve the position of CSSMin / CSSJanus annotations - 10https://bugzilla.wikimedia.org/54673 (10Krinkle) [15:21:06] 3MediaWiki / 3ResourceLoader: ResourceLoader: Remove custom LESS functions - 10https://bugzilla.wikimedia.org/67368#c2 (10Krinkle) This loosely depends on bug 54673. I don't think we have to block on it (it mostly works already) but there's weird edge cases where Less messes up the comments and those are har... [15:21:46] (03PS1) 10Aude: Don't generate html when calling getParserOutput [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/143331 (https://bugzilla.wikimedia.org/67361) [15:22:44] (03PS2) 10Aude: Don't generate html when calling getParserOutput [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/143331 (https://bugzilla.wikimedia.org/67361) [15:27:40] (03CR) 10Hashar: "Ah the experimental job fails because of GlobalBlocking. Fixed by pending patch https://gerrit.wikimedia.org/r/#/c/143253/" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/143324 (https://bugzilla.wikimedia.org/67366) (owner: 10Reedy) [15:29:12] (03CR) 10Hoo man: [C: 032] "Straightforward :)" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/143331 (https://bugzilla.wikimedia.org/67361) (owner: 10Aude) [15:29:17] (03Merged) 10jenkins-bot: Don't generate html when calling getParserOutput [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/143331 (https://bugzilla.wikimedia.org/67361) (owner: 10Aude) [15:31:53] 3Wikimedia / 3Git/Gerrit: Gerrit SSH: Intermittent key_verify failed for server_host_key and 'hash mismatch' - 10https://bugzilla.wikimedia.org/53895#c23 (10christian) The description of the SSHD-330 issue explains pretty much every aspect of the bug that we experienced. From it's sporadic nature to the way... [15:32:30] (03PS5) 10Anomie: API: Fix setnotificationtimestamp with no pages given [core] - 10https://gerrit.wikimedia.org/r/62229 (https://bugzilla.wikimedia.org/48071) [15:35:01] (03PS7) 10Jforrester: Switch from CSS to LESS and use MediaWiki's SVG fallback LESS function [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/123348 (https://bugzilla.wikimedia.org/56502) [15:35:21] anomie: a bit of fridge logic from yesterday: in the api query you showed me for the namespace bug, it gave me a warning that uselang was an unrecognized parameter. but since it had an effect, it clearly was recognized [15:36:11] jackmcbarn: It wasn't recognized by the API, but underlying MediaWiki code did recognize it. I'll probably do *something* about that in August. [15:38:38] (03PS5) 10Anomie: API: Refactor continuation code and add to purge, watch, etc. [core] - 10https://gerrit.wikimedia.org/r/111954 (https://bugzilla.wikimedia.org/60734) [15:40:06] 3Analytics / 3EventLogging: EventLogging needs process nanny alarm on hafnium - 10https://bugzilla.wikimedia.org/67309#c2 (10nuria) Pertaining patchset: https://gerrit.wikimedia.org/r/#/c/143258/ [15:40:28] 3Analytics / 3EventLogging: EventLogging needs process nanny alarm on hafnium - 10https://bugzilla.wikimedia.org/67309 (10nuria) 5NEW>3PATC [15:41:27] (03CR) 10Parent5446: [C: 032] Remove obsolete hiphop code [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/143321 (owner: 10Hoo man) [15:41:34] (03Merged) 10jenkins-bot: Remove obsolete hiphop code [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/143321 (owner: 10Hoo man) [15:43:13] (03PS11) 10Paladox: Update jquery.chosen folder and files [core] - 10https://gerrit.wikimedia.org/r/139699 [15:43:19] (03CR) 10Paladox: [C: 031] Update jquery.chosen folder and files [core] - 10https://gerrit.wikimedia.org/r/139699 (owner: 10Paladox) [15:43:48] (03PS1) 10Anomie: Fix whitespace in i18n/en.json [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/143333 [15:44:49] (03PS2) 10Isarra: New ResourceLoader module for external links to facilitate the creation of third-party skins. [core] - 10https://gerrit.wikimedia.org/r/143173 (owner: 10Jack Phoenix) [15:44:56] (03CR) 10Hoo man: [C: 032] Fix whitespace in i18n/en.json [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/143333 (owner: 10Anomie) [15:47:07] 3MediaWiki / 3JavaScript: jQuery UI 1.9.2 autocomplete makes triggers content vanishing in Chrome, Opera next - 10https://bugzilla.wikimedia.org/67243#c6 (10Rainer Rillke @commons.wikimedia) (In reply to Krinkle from comment #5) > Is there an upstream jQuery bug report? Not needed. The issue is home-made: ht... [15:47:22] 3Wikimedia / 3SSL related: Enable HSTS on Wikimedia wikis - 10https://bugzilla.wikimedia.org/38516 (10Andre Klapper) [15:47:23] 3MediaWiki / 3User preferences: Special:Preferences buttons Save/Restore all default settings (in all sections) is confusing - 10https://bugzilla.wikimedia.org/67338 (10Andre Klapper) [15:47:37] 3MediaWiki / 3User preferences: Special:Preferences buttons Save/Restore all default settings (in all sections) is confusing - 10https://bugzilla.wikimedia.org/67338 (10Andre Klapper) [15:47:37] 3Analytics / 3Visualization: Story: Maintainers have stack for EEVS dashboard server - 10https://bugzilla.wikimedia.org/67172 (10Kevin Leduc) [15:47:37] 3Wikimedia / 3SSL related: Enable HSTS on Wikimedia wikis - 10https://bugzilla.wikimedia.org/38516 (10Andre Klapper) [15:47:38] 3MediaWiki / 3User preferences: "Restore all default settings" should be a button - 10https://bugzilla.wikimedia.org/18961 (10Andre Klapper) [15:48:03] (03Merged) 10jenkins-bot: Fix whitespace in i18n/en.json [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/143333 (owner: 10Anomie) [15:48:21] 3Analytics / 3Visualization: Story: Maintainers have stack for EEVS dashboard server - 10https://bugzilla.wikimedia.org/67172 (10Kevin Leduc) p:5Normal>3Highes [15:48:37] 3MediaWiki / 3ResourceLoader: ResourceLoader: Remove custom LESS functions - 10https://bugzilla.wikimedia.org/67368 (10Andre Klapper) p:5Unprio>3High [15:49:05] (03CR) 10Jforrester: [C: 04-1] New ResourceLoader module for external links to facilitate the creation of third-party skins. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143173 (owner: 10Jack Phoenix) [15:49:37] 3MediaWiki / 3JavaScript: jQuery UI 1.9.2 autocomplete makes triggers content vanishing in Chrome, Opera next - 10https://bugzilla.wikimedia.org/67243#c7 (10Krinkle) Ah, right. Yeah, that should probably be updated to match the latest value from the rule it was forked from: https://github.com/wikimedia/medi... [15:50:36] 3Analytics / 3Wikimetrics: Story: CronUser backfills NewlyRegistered User for recurring reports - 10https://bugzilla.wikimedia.org/66841 (10Kevin Leduc) [15:50:41] (03CR) 10Isarra: New ResourceLoader module for external links to facilitate the creation of third-party skins. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143173 (owner: 10Jack Phoenix) [15:50:58] (03PS3) 10Isarra: New ResourceLoader module for external links to facilitate the creation of third-party skins. [core] - 10https://gerrit.wikimedia.org/r/143173 (owner: 10Jack Phoenix) [15:51:15] (03PS4) 10Isarra: New ResourceLoader module for external links to facilitate the creation of third-party skins. [core] - 10https://gerrit.wikimedia.org/r/143173 (https://bugzilla.wikimedia.org/63521) (owner: 10Jack Phoenix) [15:51:19] (03PS5) 10Krinkle: Introduce mediawiki.skinning module for external link icons [core] - 10https://gerrit.wikimedia.org/r/143173 (https://bugzilla.wikimedia.org/63521) (owner: 10Jack Phoenix) [15:51:36] (03CR) 10Krinkle: "Awesome!" [core] - 10https://gerrit.wikimedia.org/r/143173 (https://bugzilla.wikimedia.org/63521) (owner: 10Jack Phoenix) [15:52:06] 3Analytics / 3Wikimetrics: Path to recurrent report (from dashboard) should have better semantics - 10https://bugzilla.wikimedia.org/66087 (10Kevin Leduc) [15:52:20] (03CR) 10Jforrester: Introduce mediawiki.skinning module for external link icons (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143173 (https://bugzilla.wikimedia.org/63521) (owner: 10Jack Phoenix) [15:52:21] 3Analytics / 3Refinery: Admin has duplicate monitoring in Icinga - 10https://bugzilla.wikimedia.org/67128 (10Kevin Leduc) [15:52:29] (03CR) 10Isarra: [C: 04-1] "This should probably use less for the icons." [core] - 10https://gerrit.wikimedia.org/r/143173 (https://bugzilla.wikimedia.org/63521) (owner: 10Jack Phoenix) [15:52:36] 3Analytics / 3Refinery: Story: Admin has duplicate monitoring in Icinga - 10https://bugzilla.wikimedia.org/67128 (10Kevin Leduc) [15:53:52] 3Analytics / 3Refinery: Admin has versioned and sync'ed files in HDFS - 10https://bugzilla.wikimedia.org/67129 (10Kevin Leduc) [15:54:07] 3Analytics / 3Refinery: Story: Admin has versioned and sync'ed files in HDFS - 10https://bugzilla.wikimedia.org/67129 (10Kevin Leduc) [15:54:16] (03CR) 10Krinkle: Introduce mediawiki.skinning module for external link icons (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143173 (https://bugzilla.wikimedia.org/63521) (owner: 10Jack Phoenix) [15:54:39] (03PS2) 10Anomie: Handle __pairs when marshalling Lua-to-PHP [php/luasandbox] - 10https://gerrit.wikimedia.org/r/84985 [15:54:48] (03CR) 10Isarra: Introduce mediawiki.skinning module for external link icons (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143173 (https://bugzilla.wikimedia.org/63521) (owner: 10Jack Phoenix) [15:54:50] (03PS6) 10Krinkle: Introduce mediawiki.skinning module for external link icons [core] - 10https://gerrit.wikimedia.org/r/143173 (https://bugzilla.wikimedia.org/63521) (owner: 10Jack Phoenix) [15:57:22] 3Analytics / 3Refinery: Story: Admin has versioned and sync'ed files in HDFS - 10https://bugzilla.wikimedia.org/67129 (10Kevin Leduc) [15:57:51] 3Analytics / 3Refinery: Story: Admin has duplicate monitoring in Icinga - 10https://bugzilla.wikimedia.org/67128 (10Kevin Leduc) [15:59:21] 3Analytics / 3Wikimetrics: Story: CronUser backfills NewlyRegistered User for recurring reports - 10https://bugzilla.wikimedia.org/66841 (10Kevin Leduc) [15:59:55] (03CR) 10Physikerwelt: Amber first update (032 comments) [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/143323 (owner: 10Hcohl) [16:00:08] 3Analytics / 3Wikimetrics: Story: CronUser runs EEVS metrics on all projects daily - 10https://bugzilla.wikimedia.org/65946 (10Kevin Leduc) [16:00:22] 3Analytics / 3Wikimetrics: Story: CronUser backfills NewlyRegistered User for recurring reports - 10https://bugzilla.wikimedia.org/66841 (10Kevin Leduc) [16:00:52] 3Analytics / 3EventLogging: Fix per schema counts in graphite - 10https://bugzilla.wikimedia.org/67073 (10Kevin Leduc) [16:11:10] (03PS1) 10Rillke: Update rule for vector styled .ui-helper-hidden-accessible [core] - 10https://gerrit.wikimedia.org/r/143337 (https://bugzilla.wikimedia.org/67243) [16:14:43] (03PS2) 10Rillke: Update rule for vector-styled .ui-helper-hidden-accessible [core] - 10https://gerrit.wikimedia.org/r/143337 (https://bugzilla.wikimedia.org/67243) [16:16:37] 3MediaWiki / 3Maintenance scripts: generateSitemap.php gzopen() fatal error on Ubuntu 14.04 (replace gzopen() by gzopen64()) - 10https://bugzilla.wikimedia.org/66952#c5 (10Andre Klapper) (In reply to Antoine "hashar" Musso from comment #4) > I would wont fix that bug for core since that impacts a lot of othe... [16:18:57] (03CR) 10Isarra: "Krinkle: You seem to assume that this is an unmodified version - it is not. It includes changes made to improve accessibility, something o" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [16:24:27] (03PS4) 10Florianschmidtwelzow: Enable keep logged in [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/143053 (https://bugzilla.wikimedia.org/67136) [16:24:39] 3MediaWiki / 3Parser: expensive-parserfunction-warning has an off-by-one error - 10https://bugzilla.wikimedia.org/67371 (10Emufarmers) 3NEW p:3Unprio s:3normal a:3None User:Dispenser reports that the "too many expensive parser function calls" warning has an off-by-one error and says there are 2,229 c... [16:24:54] (03CR) 10Florianschmidtwelzow: Enable keep logged in [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/143053 (https://bugzilla.wikimedia.org/67136) (owner: 10Florianschmidtwelzow) [16:26:28] (03CR) 10Krinkle: "I have no interest in what normalize does or doesn't provide or whether it is a fork or not. I oppose this change based on the implementat" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [16:27:15] (03CR) 10Nikerabbit: "Please optimize the svg files. If you use svgo, please be aware that you might need to manually add the xml header back for the files to w" [core] - 10https://gerrit.wikimedia.org/r/143173 (https://bugzilla.wikimedia.org/63521) (owner: 10Jack Phoenix) [16:29:01] (03PS5) 10Florianschmidtwelzow: Enable keep logged in [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/143053 (https://bugzilla.wikimedia.org/67136) [16:29:36] (03CR) 10Krinkle: "Making sure yourself in the call to the DB method imho doesn't make sense. However if somehow this loop can be improved to never duplicate" [core] - 10https://gerrit.wikimedia.org/r/143222 (owner: 10Reedy) [16:29:53] Which reminds me, MatmaRex, did we document anywhere how to use svgo [16:30:28] no [16:30:41] it has a couple dealbreaker bugs [16:30:48] or had, last time i used it [16:31:01] i had to fix some "optimized" files by hand [16:31:18] (03PS1) 10Krinkle: UserTest: Cover User::isIP and User::isValidUserName better [core] - 10https://gerrit.wikimedia.org/r/143340 [16:31:22] "git #15b3e9db - Tools: Add SVGO, an SVG optimizer to pre-commit hook" [16:31:35] That's why it needs to be documented. :) [16:32:13] (03PS1) 10Krinkle: ApiOptionsTest: Simplify hook restoration [core] - 10https://gerrit.wikimedia.org/r/143341 [16:32:19] (03PS1) 10Matthias Mullie: Error handling for view-topiclist actions (change sort & load more) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143342 [16:32:20] I see no manual page on assets either [16:32:56] (03CR) 10Krinkle: "Added testst in I4663c37871492c1." [core] - 10https://gerrit.wikimedia.org/r/143234 (owner: 10Withoutaname) [16:34:13] (03CR) 10jenkins-bot: [V: 04-1] Error handling for view-topiclist actions (change sort & load more) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143342 (owner: 10Matthias Mullie) [16:36:53] (03CR) 10Ori.livneh: [C: 032] Clarify license under debian/copyright [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/142582 (owner: 10Faidon Liambotis) [16:37:21] (03Merged) 10jenkins-bot: Clarify license under debian/copyright [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/142582 (owner: 10Faidon Liambotis) [16:37:39] (03CR) 10Ori.livneh: [C: 032] Various Debian packaging fixes [php/luasandbox] - 10https://gerrit.wikimedia.org/r/142585 (owner: 10Faidon Liambotis) [16:38:04] (03Merged) 10jenkins-bot: Various Debian packaging fixes [php/luasandbox] - 10https://gerrit.wikimedia.org/r/142585 (owner: 10Faidon Liambotis) [16:38:08] 3MediaWiki extensions / 3GoogleLogin: Make sure, the given token is used for the function - 10https://bugzilla.wikimedia.org/67248 (10Florian) 5PATC>3RESO/FIX [16:38:17] (03PS2) 10Matthias Mullie: Error handling for open/close topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143314 [16:38:22] 3MediaWiki extensions / 3GoogleLogin: Enable "keep login" in GoogleLogin Settings - 10https://bugzilla.wikimedia.org/67136 (10Florian) [16:38:22] 3MediaWiki extensions / 3GoogleLogin: Allow to restrict access to special E-Maildomains - 10https://bugzilla.wikimedia.org/67220 (10Florian) [16:38:23] 3MediaWiki extensions / 3GoogleLogin: Move main logic out of SpecialPage - 10https://bugzilla.wikimedia.org/67219 (10Florian) [16:38:38] ori: thanks :) [16:38:42] ori: I had another TODO item, but meh :) [16:38:52] (adding a LICENSE file as well) [16:39:06] (03PS2) 10Matthias Mullie: Error handling for moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143315 [16:39:12] (03PS2) 10Matthias Mullie: Let's not assume API always responds [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143316 [16:39:17] (03PS2) 10Matthias Mullie: Error handling for view-topiclist actions (change sort & load more) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143342 [16:39:25] (03CR) 10jenkins-bot: [V: 04-1] Error handling for moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143315 (owner: 10Matthias Mullie) [16:39:27] paravoid: Tim was going to auto-generate the luasandbox_version.h using CMake somehow [16:39:37] paravoid: re: test failure on https://gerrit.wikimedia.org/r/#/c/142586/ [16:39:38] (03CR) 10jenkins-bot: [V: 04-1] Let's not assume API always responds [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143316 (owner: 10Matthias Mullie) [16:39:50] (03CR) 10jenkins-bot: [V: 04-1] Error handling for view-topiclist actions (change sort & load more) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143342 (owner: 10Matthias Mullie) [16:40:49] (03PS3) 10Matthias Mullie: Error handling for moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143315 [16:41:20] (03CR) 10EBernhardson: [C: 032] "LGTM" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143214 (owner: 10Jdlrobson) [16:41:45] ori: awesome :) [16:41:48] (03Merged) 10jenkins-bot: Design changes for moderated posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143214 (owner: 10Jdlrobson) [16:41:52] (03PS3) 10Matthias Mullie: Let's not assume API always responds [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143316 [16:42:47] (03PS3) 10Matthias Mullie: Error handling for view-topiclist actions (change sort & load more) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143342 [16:43:48] (03PS1) 10Florianschmidtwelzow: Rename config vars [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/143343 [16:44:21] (03PS2) 10Florianschmidtwelzow: Rename config vars [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/143343 [16:44:44] MatmaRex: started at https://www.mediawiki.org/wiki/Manual:Assets [16:45:02] yay [16:45:24] (03CR) 10Florianschmidtwelzow: [C: 032] Rename config vars [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/143343 (owner: 10Florianschmidtwelzow) [16:45:29] (03Merged) 10jenkins-bot: Rename config vars [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/143343 (owner: 10Florianschmidtwelzow) [16:47:16] (03PS4) 10Physikerwelt: WIP:First node only mathoid protype [services/mathoid] - 10https://gerrit.wikimedia.org/r/143043 [16:47:30] (03CR) 10Nemo bis: "And I just documented what above for you :)" [core] - 10https://gerrit.wikimedia.org/r/143173 (https://bugzilla.wikimedia.org/63521) (owner: 10Jack Phoenix) [16:48:07] 3Wikimedia / 3Site requests: Please upload large file to Commons - 10https://bugzilla.wikimedia.org/67360#c3 (10jeremyb) Also need a commons username to be the uploader. [16:48:18] MatmaRex: I also tok the opportunity to take the "please optimize PNG images" line out of a style guide now marked as outdated. [16:48:46] There are N style guides which typically last 6 months, so it's nice to have more stable advice like this in stable pages. :-) [16:49:22] :D [16:49:38] (03CR) 10EBernhardson: "LGTM, i18n message could be a little better" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143284 (owner: 10Matthias Mullie) [16:49:51] (03PS9) 10Florianschmidtwelzow: Add feature to restrict E-Maildomains [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142741 (https://bugzilla.wikimedia.org/67220) [16:49:53] (03CR) 10jenkins-bot: [V: 04-1] Add feature to restrict E-Maildomains [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142741 (https://bugzilla.wikimedia.org/67220) (owner: 10Florianschmidtwelzow) [16:50:04] Nemo_bis: ContentTranslation should be silent now. Thanks for the patch. [16:50:09] paravoid: is that a good idea? should we just hand-create one? [16:50:42] ori: I don't particuarly care :) [16:50:47] valhallasw: thank you for making Nikerabbit happier ;) [16:51:09] it was previously depending on debian stuff, got broken with the new packaging, I moved the debian-based logic into debian/ [16:51:16] and now generic compilation is broken [16:51:38] (03PS10) 10Florianschmidtwelzow: Add feature to restrict E-Maildomains [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142741 (https://bugzilla.wikimedia.org/67220) [16:51:38] so just using something else would be sensible, yes [16:51:40] maybe static even [16:54:19] (03PS2) 10Dduvall: Setup script for easier installation and configuration [vagrant] - 10https://gerrit.wikimedia.org/r/143218 [16:56:07] 3Wikimedia / 3Site requests: Please upload large file to Commons - 10https://bugzilla.wikimedia.org/67360#c4 (10Zell Faze) User:Zellfaze [16:59:42] (03CR) 10EBernhardson: [C: 04-1] "main concern is some api requests are triggered outside forms" (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143285 (owner: 10Matthias Mullie) [17:00:05] (03PS2) 10IAlex: Fixed typo [core] - 10https://gerrit.wikimedia.org/r/143264 (owner: 10KartikMistry) [17:00:10] (03CR) 10IAlex: [C: 032] Fixed typo [core] - 10https://gerrit.wikimedia.org/r/143264 (owner: 10KartikMistry) [17:00:38] (03CR) 10EBernhardson: [C: 032] Remove unused variables [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143295 (owner: 10Matthias Mullie) [17:01:13] (03CR) 10EBernhardson: [C: 032] Remove unused variable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143296 (owner: 10Matthias Mullie) [17:01:42] (03CR) 10EBernhardson: [C: 032] Use {{int:}} to refer to a specific message's text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143301 (owner: 10Matthias Mullie) [17:02:31] (03Merged) 10jenkins-bot: Remove unused variables [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143295 (owner: 10Matthias Mullie) [17:02:39] (03CR) 10BryanDavis: [C: 031] Setup script for easier installation and configuration [vagrant] - 10https://gerrit.wikimedia.org/r/143218 (owner: 10Dduvall) [17:02:46] (03Merged) 10jenkins-bot: Remove unused variable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143296 (owner: 10Matthias Mullie) [17:02:58] (03CR) 10Isarra: "Then by that logic, do you also oppose https://gerrit.wikimedia.org/r/#/c/143173/ and all skinning-related modules?" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [17:03:02] (03Merged) 10jenkins-bot: Use {{int:}} to refer to a specific message's text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143301 (owner: 10Matthias Mullie) [17:03:26] (03CR) 1020after4: [C: 031] Setup script for easier installation and configuration [vagrant] - 10https://gerrit.wikimedia.org/r/143218 (owner: 10Dduvall) [17:04:40] (03Merged) 10jenkins-bot: Fixed typo [core] - 10https://gerrit.wikimedia.org/r/143264 (owner: 10KartikMistry) [17:04:50] (03CR) 10IAlex: [C: 04-1] Change some message escaping (032 comments) [core] - 10https://gerrit.wikimedia.org/r/136161 (owner: 10Umherirrender) [17:05:33] (03PS2) 10Matthias Mullie: Streamline API error output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143284 [17:06:28] (03CR) 10Matthias Mullie: Add generic JS error handling (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143285 (owner: 10Matthias Mullie) [17:08:00] (03PS1) 10Jdlrobson: QA: Make close/open topics test pass again [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143351 [17:08:46] (03CR) 10Matthias Mullie: Add generic JS error handling (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143285 (owner: 10Matthias Mullie) [17:08:50] (03PS2) 10Matthias Mullie: Add generic JS error handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143285 [17:09:04] (03PS3) 10Jdlrobson: Add generic JS error handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143285 (owner: 10Matthias Mullie) [17:09:07] (03CR) 10jenkins-bot: [V: 04-1] Add generic JS error handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143285 (owner: 10Matthias Mullie) [17:10:35] (03PS2) 10IAlex: Fix documentation of HistoryPager::lastLink() and make code more readable [core] - 10https://gerrit.wikimedia.org/r/142899 [17:11:18] (03CR) 10EBernhardson: [C: 032] Streamline API error output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143284 (owner: 10Matthias Mullie) [17:12:07] (03Merged) 10jenkins-bot: Streamline API error output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143284 (owner: 10Matthias Mullie) [17:13:56] (03CR) 10Bartosz Dziewoński: Switch from CSS to LESS and use MediaWiki's SVG fallback LESS function (033 comments) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/123348 (https://bugzilla.wikimedia.org/56502) (owner: 10Jforrester) [17:14:22] (03PS4) 10Krinkle: Purge support for the old-school "local-*" service groups [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/142051 (https://bugzilla.wikimedia.org/58997) (owner: 10Andrew Bogott) [17:14:27] (03PS4) 10EBernhardson: Add generic JS error handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143285 (owner: 10Matthias Mullie) [17:14:30] (03CR) 10Isarra: "Um... how exactly do you do that?" [core] - 10https://gerrit.wikimedia.org/r/143173 (https://bugzilla.wikimedia.org/63521) (owner: 10Jack Phoenix) [17:14:45] (03CR) 10Phuedx: "> How will this adapt when we render stock icons using WikiFont?" [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [17:15:14] (03CR) 10Jdlrobson: Add generic JS error handling (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143285 (owner: 10Matthias Mullie) [17:15:27] (03CR) 10Krinkle: Purge support for the old-school "local-*" service groups (031 comment) [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/142051 (https://bugzilla.wikimedia.org/58997) (owner: 10Andrew Bogott) [17:16:51] 3MediaWiki extensions / 3Babel: Babel extension categories - 10https://bugzilla.wikimedia.org/67334#c2 (10Metrónomo) This is an request to prevent pages that have a template as an example appear in the category. That happens at this moment and it is wrong. [17:18:52] (03PS1) 10IAlex: Don't use isset() to check for null [core] - 10https://gerrit.wikimedia.org/r/143353 [17:18:53] 3Analytics / 3Wikistats: Only feed data file with complete months to Report Card (or extrapolate for last day). - 10https://bugzilla.wikimedia.org/67374 (10Erik Zachte) 3NEW p:3Unprio s:3normal a:3None File wikilytics_in_pageviews.csv now also contains data for current incomplete month (only at the e... [17:19:07] 3Analytics / 3Wikistats: Only feed data file with complete months to Report Card (or extrapolate for last day). - 10https://bugzilla.wikimedia.org/67374 (10Erik Zachte) p:5Unprio>3Normal [17:20:05] (03CR) 10Jdlrobson: [C: 04-1] "Let's use mediawiki ui and not reinvent the wheel." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143285 (owner: 10Matthias Mullie) [17:20:22] (03PS2) 10Jdlrobson: Error handling for new-topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143286 (owner: 10Matthias Mullie) [17:20:49] (03CR) 10Bartosz Dziewoński: [C: 032] UserTest: Cover User::isIP and User::isValidUserName better [core] - 10https://gerrit.wikimedia.org/r/143340 (owner: 10Krinkle) [17:21:35] (03PS2) 10Jdlrobson: Error handling for reply [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143287 (owner: 10Matthias Mullie) [17:23:50] (03CR) 10Bartosz Dziewoński: [C: 032] ApiOptionsTest: Simplify hook restoration [core] - 10https://gerrit.wikimedia.org/r/143341 (owner: 10Krinkle) [17:24:28] (03Merged) 10jenkins-bot: UserTest: Cover User::isIP and User::isValidUserName better [core] - 10https://gerrit.wikimedia.org/r/143340 (owner: 10Krinkle) [17:26:55] (03Merged) 10jenkins-bot: ApiOptionsTest: Simplify hook restoration [core] - 10https://gerrit.wikimedia.org/r/143341 (owner: 10Krinkle) [17:28:07] (03PS1) 10Krinkle: flow-board.js: Remove redundant slice() call for arguments. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143355 [17:28:21] 3Wikimedia / 3Wikidata: Investigate if there are already claims for properties on wikidata.org - 10https://bugzilla.wikimedia.org/63072#c2 (10Jeroen De Dauw) Can you also provide the actual result? [17:28:25] (03CR) 10jenkins-bot: [V: 04-1] flow-board.js: Remove redundant slice() call for arguments. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143355 (owner: 10Krinkle) [17:29:19] (03CR) 10Krinkle: "Ugh, missed the unshift()." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143355 (owner: 10Krinkle) [17:29:28] (03Abandoned) 10Krinkle: flow-board.js: Remove redundant slice() call for arguments. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143355 (owner: 10Krinkle) [17:29:58] (03PS1) 10Bsitu: Remove deprecated $.live() [extensions/MarkAsHelpful] - 10https://gerrit.wikimedia.org/r/143356 (https://bugzilla.wikimedia.org/67356) [17:33:36] (03PS2) 10Anomie: Use HTMLAutoCompleteSelectField [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/142671 [17:34:11] (03PS8) 10Jforrester: Switch from CSS to LESS and use MediaWiki's SVG fallback LESS function [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/123348 (https://bugzilla.wikimedia.org/56502) [17:34:22] 3MediaWiki / 3Search: Searching for # reloads the page - 10https://bugzilla.wikimedia.org/46334#c3 (10Rohan Rawat) Same thing. But even Google interprets it as a # symbol [17:34:37] (03CR) 10Jforrester: Switch from CSS to LESS and use MediaWiki's SVG fallback LESS function (032 comments) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/123348 (https://bugzilla.wikimedia.org/56502) (owner: 10Jforrester) [17:36:19] Krinkle: Do you think https://gerrit.wikimedia.org/r/#/c/142319 (GitInfo cache fix) is ready to merge or are there other changes that you'd like to see? [17:36:19] (03CR) 10Withoutaname: "It's only a proposed patch, we can keep it -1 for another release if need be until it's merged." [core] - 10https://gerrit.wikimedia.org/r/143207 (owner: 10Withoutaname) [17:38:14] (03PS2) 10IAlex: Update Special:ChangeEmail to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/142878 [17:38:24] (03CR) 10IAlex: Update Special:ChangeEmail to use HTMLForm (037 comments) [core] - 10https://gerrit.wikimedia.org/r/142878 (owner: 10IAlex) [17:38:40] (03PS3) 10IAlex: Update Special:ChangeEmail to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/142878 [17:38:48] (03CR) 1001tonythomas: "@Plesestand: Please check reply" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/138655 (https://bugzilla.wikimedia.org/46640) (owner: 1001tonythomas) [17:40:41] (03CR) 10Chad: [C: 032] API: Fix setnotificationtimestamp with no pages given [core] - 10https://gerrit.wikimedia.org/r/62229 (https://bugzilla.wikimedia.org/48071) (owner: 10Anomie) [17:41:48] (03PS4) 10IAlex: Update Special:ChangeEmail to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/142878 [17:42:39] 3MediaWiki extensions / 3Quiz: Non-breaking space needed in French for Quiz - 10https://bugzilla.wikimedia.org/67375 (10JackPotte) 3NEW p:3Unprio s:3minor a:3None Hello, The French typographic rules impose to add a non-breaking space before each colon. However the quiz extension doesn't provide it i... [17:44:36] (03Merged) 10jenkins-bot: API: Fix setnotificationtimestamp with no pages given [core] - 10https://gerrit.wikimedia.org/r/62229 (https://bugzilla.wikimedia.org/48071) (owner: 10Anomie) [17:44:53] 3MediaWiki / 3Maintenance scripts: generateSitemap.php gzopen() fatal error on Ubuntu 14.04 (replace gzopen() by gzopen64()) - 10https://bugzilla.wikimedia.org/66952#c6 (10Greg Grossmeier) 5PATC>3RESO/WON (In reply to Andre Klapper from comment #5) > (In reply to Antoine "hashar" Musso from comment #4) >... [17:44:53] 3MediaWiki / 3Skin and page rendering: messages from skin i18n not loaded for $wgLanguageCode != en - 10https://bugzilla.wikimedia.org/67318#c5 (10Umherirrender) Just for record: I am using on my dev machine (windows): •[caches] main: EmptyBagOStuff, message: SqlBagOStuff, parser: SqlBagOStuff •[caches] Loca... [17:47:14] (03PS1) 10Chad: Updating Elastica to master, fixing fatal class error in production [core] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/143358 [17:47:54] (03CR) 10Chad: [C: 032] Updating Elastica to master, fixing fatal class error in production [core] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/143358 (owner: 10Chad) [17:48:01] (03CR) 10Krinkle: [C: 04-1] "Hm.. not sure whether the switch to FileCache was intentional." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/142319 (https://bugzilla.wikimedia.org/53972) (owner: 10BryanDavis) [17:48:07] 3Wikimedia / 3Site requests: Deploy TemplateData's GUI editing tool to all wikis - 10https://bugzilla.wikimedia.org/60158 (10James Forrester) [17:48:09] 3Wikimedia / 3Site requests: Deploy TemplateData's GUI editing tool to English, French and Italian Wikipedias - 10https://bugzilla.wikimedia.org/67376 (10James Forrester) 3ASSI p:3Unprio s:3normal a:3James Forrester Per community requests via CLs. [17:48:21] 3Wikimedia / 3Site requests: Deploy TemplateData's GUI editing tool to English, French and Italian Wikipedias - 10https://bugzilla.wikimedia.org/67376 (10James Forrester) p:5Unprio>3Normal s:5normal>3enhanc [17:48:37] 3MediaWiki / 3General/Unknown: Extensions missing REL1_23 branches - 10https://bugzilla.wikimedia.org/67270#c3 (10Mark A. Hershberger) (In reply to Kunal Mehta (Legoktm) from comment #2) > I hope the new release management team plans on fixing this > mess! I don't think this is off to... [17:49:32] (03CR) 10SG: "I'm not super sure this is the best route to take. Given that WikiFont-Glyphs is already in use, and will be in core soon, I'm not sure wh" [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [17:50:21] (03CR) 10Isarra: "Optimise them, I mean. I don't really understand the install instructions for svgo, and in general I'm also not entirely sure how optimise" [core] - 10https://gerrit.wikimedia.org/r/143173 (https://bugzilla.wikimedia.org/63521) (owner: 10Jack Phoenix) [17:52:04] (03Merged) 10jenkins-bot: Updating Elastica to master, fixing fatal class error in production [core] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/143358 (owner: 10Chad) [17:52:49] (03CR) 10Matthias Mullie: Add generic JS error handling (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143285 (owner: 10Matthias Mullie) [17:53:22] 3MediaWiki extensions / 3WikidataRepo: Adding site links is broken - 10https://bugzilla.wikimedia.org/67244#c3 (10Aude) now broken on wikidata beta: http://wikidata.beta.wmflabs.org/wiki/Q27843 [17:53:24] (03PS5) 10Matthias Mullie: Add generic JS error handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143285 [17:53:49] (03CR) 10jenkins-bot: [V: 04-1] Add generic JS error handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143285 (owner: 10Matthias Mullie) [17:54:43] (03CR) 10Nemo bis: "AFAIK there is no need to worry about "how much". If docs are unclear it's worth asking where the docs are, i.e. on the svgo repo (better)" [core] - 10https://gerrit.wikimedia.org/r/143173 (https://bugzilla.wikimedia.org/63521) (owner: 10Jack Phoenix) [18:01:59] (03PS8) 10BryanDavis: Fix GitInfo cache file path computation and storage location [core] - 10https://gerrit.wikimedia.org/r/142319 (https://bugzilla.wikimedia.org/53972) [18:02:29] (03PS8) 1001tonythomas: Added SwiftMailer Extension to provide an alternate for UserMailer [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 [18:02:40] (03CR) 10Jdlrobson: [C: 032] Dont include empty result for moderated revisions part duex [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143200 (owner: 10EBernhardson) [18:02:51] (03Abandoned) 10Chad: Remove SearchGetNearMatchBefore hook, unused [core] - 10https://gerrit.wikimedia.org/r/141067 (owner: 10Chad) [18:03:43] (03Merged) 10jenkins-bot: Dont include empty result for moderated revisions part duex [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143200 (owner: 10EBernhardson) [18:04:00] (03CR) 10BryanDavis: Fix GitInfo cache file path computation and storage location (031 comment) [core] - 10https://gerrit.wikimedia.org/r/142319 (https://bugzilla.wikimedia.org/53972) (owner: 10BryanDavis) [18:05:11] (03CR) 1001tonythomas: "@Parent5446: I couldn't get your request to do:-" [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 (owner: 1001tonythomas) [18:06:52] (03CR) 10Isarra: "I can't use svgo, and a lot of alternatives seem to do varying amounts. Baring some proper directions as to how to install svgo on linux (" [core] - 10https://gerrit.wikimedia.org/r/143173 (https://bugzilla.wikimedia.org/63521) (owner: 10Jack Phoenix) [18:08:44] (03PS7) 10Umherirrender: Change some message escaping [core] - 10https://gerrit.wikimedia.org/r/136161 [18:09:12] (03CR) 10Umherirrender: "Patch Set 7: Addressed inline comments" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/136161 (owner: 10Umherirrender) [18:10:41] (03CR) 10Nemo bis: "Aww poor Chad. Kipcool, can you do without this hook? Precious suggestion of an alternative above." [core] - 10https://gerrit.wikimedia.org/r/141067 (owner: 10Chad) [18:11:32] (03CR) 10Bartosz Dziewoński: [C: 032] "For spotting changes in diffs I greatly recommend using Meld (http://meldmerge.org/, FOSS) and/or XDiff (http://www.plasticscm.com/feature" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/123348 (https://bugzilla.wikimedia.org/56502) (owner: 10Jforrester) [18:11:38] (03Merged) 10jenkins-bot: Switch from CSS to LESS and use MediaWiki's SVG fallback LESS function [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/123348 (https://bugzilla.wikimedia.org/56502) (owner: 10Jforrester) [18:11:56] MatmaRex: Thank you. [18:12:18] :) [18:12:21] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Use a LESS mixin to provide PNG icons as a fallback for older browsers - 10https://bugzilla.wikimedia.org/56729 (10Bartosz Dziewoński) 5PATC>3RESO/FIX [18:12:22] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Convert to LESS, tear out SCSS comments - 10https://bugzilla.wikimedia.org/56502 (10Bartosz Dziewoński) 5PATC>3RESO/FIX [18:13:17] (03PS9) 10Bartosz Dziewoński: New icons [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/91040 (owner: 10Esanders) [18:13:20] MatmaRex: If you're feeling generous, some thoughts on https://gerrit.wikimedia.org/r/#/c/102383/ about writing a test or two… [18:13:52] (03CR) 10Jforrester: [C: 04-2] "Pending Design input." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/91040 (owner: 10Esanders) [18:14:19] (03PS3) 10Jforrester: Don't show skin names if the user can't enable them [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/102383 (https://bugzilla.wikimedia.org/58623) (owner: 10Legoktm) [18:14:24] (03CR) 10Bartosz Dziewoński: [C: 04-1] "PNG versions have issues." (032 comments) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/91040 (owner: 10Esanders) [18:14:40] James_F: bah, design input [18:14:49] MatmaRex: Indeed. [18:14:52] "design input" is what caused these weird icons to be devised in the first place [18:15:09] 3MediaWiki extensions / 3WikidataRepo: Value gets lost when setting the snak type - 10https://bugzilla.wikimedia.org/67380 (10Thiemo Mättig) 3NEW p:3Unprio s:3major a:3Wikidata bugs Steps to reproduce (on master, not on wikidata.org): 1. Edit a statement. 2. Set the snak type to "unknown value" or "... [18:15:41] James_F: ew, tests. [18:15:51] MatmaRex: However, changing the icons without getting their OK would be not cool. [18:18:37] MatmaRex: Or https://gerrit.wikimedia.org/r/#/c/143042/ which /is/ a test that could just be merged… [18:19:11] (03CR) 10Bartosz Dziewoński: [C: 031] "I'm not sure if writing tests for this would be practical." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/102383 (https://bugzilla.wikimedia.org/58623) (owner: 10Legoktm) [18:19:13] (03CR) 10Withoutaname: "I did a brief search for MWInit on github, and currently the only place where I could find it is used is here in mediawiki core. I'm not s" [core] - 10https://gerrit.wikimedia.org/r/143207 (owner: 10Withoutaname) [18:19:54] (03CR) 10Jforrester: [C: 032] "Let's just get the fix in now, as it's a breaking experience for a number of users and it's been sitting here since December." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/102383 (https://bugzilla.wikimedia.org/58623) (owner: 10Legoktm) [18:19:56] (03PS9) 1001tonythomas: Added SwiftMailer Extension to provide an alternate for UserMailer [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 [18:19:58] (03Merged) 10jenkins-bot: Don't show skin names if the user can't enable them [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/102383 (https://bugzilla.wikimedia.org/58623) (owner: 10Legoktm) [18:20:01] James_F: if i merge that, hashar is going to add me as a reviewer to even more unit-testing-related patches i completely don't understand. :P [18:20:11] MatmaRex: :-P [18:20:23] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Validate skin requirement is installed before showing it - 10https://bugzilla.wikimedia.org/58623 (10James Forrester) 5PATC>3RESO/FIX [18:20:37] (03CR) 1001tonythomas: "The mailer seems to get autoloaded even without the require_once( vendor/autoload.php ) in SwiftMailer.php. so remvoed." [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 (owner: 1001tonythomas) [18:20:49] MatmaRex: You know you want to… ;-) [18:21:05] heh [18:22:30] MatmaRex: OK, how about https://gerrit.wikimedia.org/r/#/c/133419/ where you said you were "pretty sure" it wouldn't work – did you test? [18:22:40] * James_F is just being mean. :-) [18:22:52] 3MediaWiki extensions / 3WikidataRepo: write browser tests for snak type changes - 10https://bugzilla.wikimedia.org/67364 (10Thiemo Mättig) [18:23:07] 3MediaWiki extensions / 3WikidataRepo: not possible to add no-value and some-value snaks in languages other than English - 10https://bugzilla.wikimedia.org/66626 (10Thiemo Mättig) [18:23:09] 3MediaWiki / 3Watchlist: $wgUsersNotifiedOnAllChanges sends mail even if already sent via watchlist - 10https://bugzilla.wikimedia.org/67041 (10Rohan Rawat) a:3Rohan Rawat [18:23:09] (03PS1) 10Umherirrender: Avoid empty namespace section on Special:EditWatchlist [core] - 10https://gerrit.wikimedia.org/r/143363 [18:23:22] 3MediaWiki extensions / 3WikidataRepo: not possible to add no-value and some-value snaks in languages other than English - 10https://bugzilla.wikimedia.org/66626 (10Thiemo Mättig) [18:23:22] 3MediaWiki extensions / 3WikidataRepo: Snak type selection (e.g. novalue) sticks when canceling - 10https://bugzilla.wikimedia.org/67294 (10Thiemo Mättig) [18:23:37] 3MediaWiki extensions / 3WikidataRepo: not possible to add no-value and some-value snaks in languages other than English - 10https://bugzilla.wikimedia.org/66626 (10Thiemo Mättig) [18:23:37] 3MediaWiki extensions / 3WikidataRepo: Value gets lost when setting the snak type - 10https://bugzilla.wikimedia.org/67380 (10Thiemo Mättig) p:5Unprio>3High [18:23:40] James_F: not sure, but i read the code and that has no reason why it would work. :D [18:23:51] 3MediaWiki extensions / 3WikidataRepo: Snak type selection (e.g. novalue) sticks when canceling - 10https://bugzilla.wikimedia.org/67294 (10Thiemo Mättig) [18:25:42] can anyone point to me PleaseStand's nick ? [18:26:01] (03CR) 10Parent5446: [C: 031] Update Special:ChangeEmail to use HTMLForm (031 comment) [core] - 10https://gerrit.wikimedia.org/r/142878 (owner: 10IAlex) [18:27:07] (03CR) 10Jforrester: [C: 032] "Per Lego." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/143042 (https://bugzilla.wikimedia.org/67138) (owner: 10Hashar) [18:27:13] (03Merged) 10jenkins-bot: Avoid extensions conflicts by hook GetPreferences [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/143042 (https://bugzilla.wikimedia.org/67138) (owner: 10Hashar) [18:27:32] (03CR) 10Bartosz Dziewoński: "Also fixes bug 67139?" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/143042 (https://bugzilla.wikimedia.org/67138) (owner: 10Hashar) [18:27:57] (03CR) 10Reedy: [C: 032] Fix undefined $json usage [extensions/LocalisationUpdate] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142306 (owner: 10Reedy) [18:28:04] (03Merged) 10jenkins-bot: Fix undefined $json usage [extensions/LocalisationUpdate] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142306 (owner: 10Reedy) [18:28:12] Krenair: you pinged yesterday ? [18:28:14] (03Abandoned) 10Jforrester: Enable WikiEditor toolbar on iOS [extensions/WikiEditor] (REL1_22) - 10https://gerrit.wikimedia.org/r/142872 (https://bugzilla.wikimedia.org/63277) (owner: 10Paladox) [18:28:16] (03Abandoned) 10Reedy: Fix undefined $json usage [extensions/LocalisationUpdate] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142305 (owner: 10Reedy) [18:29:44] (03CR) 10Bartosz Dziewoński: "Definitely doesn't work." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/133419 (https://bugzilla.wikimedia.org/65315) (owner: 10Legoktm) [18:29:46] (03PS3) 10Reedy: Fix checkLocalNames [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/142304 (owner: 10Legoktm) [18:30:30] (03CR) 10Reedy: [C: 032] Fix checkLocalNames [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/142304 (owner: 10Legoktm) [18:30:37] (03Merged) 10jenkins-bot: Fix checkLocalNames [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/142304 (owner: 10Legoktm) [18:31:00] (03PS2) 10Reedy: Add checkLocalUser for localuser table [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/142791 (owner: 10Legoktm) [18:31:01] Reedy: descriptive [18:31:06] (03CR) 10Reedy: [C: 032] Add checkLocalUser for localuser table [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/142791 (owner: 10Legoktm) [18:31:12] (03Merged) 10jenkins-bot: Add checkLocalUser for localuser table [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/142791 (owner: 10Legoktm) [18:31:29] and a ton of unrelated changes [18:31:31] * MatmaRex slaps legoktm around a bit with a large trout [18:32:13] What? [18:33:11] legoktm isn't here to be slapped [18:33:14] (afk) [18:37:31] Reedy dear, https://bugzilla.wikimedia.org/show_bug.cgi?id=67243 is going to need wmf backports. i'm reviewing and testing the fix right now [18:37:47] (03PS1) 10Manybubbles: Load testing script searching file: in commons [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/143367 [18:42:37] (03PS1) 10Jdlrobson: Make all forms mw-ui-vform [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143369 [18:43:37] (03CR) 10Ori.livneh: [C: 032] Allow for skipping Lua tests [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/143325 (https://bugzilla.wikimedia.org/67343) (owner: 10Anomie) [18:46:00] (03Merged) 10jenkins-bot: Allow for skipping Lua tests [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/143325 (https://bugzilla.wikimedia.org/67343) (owner: 10Anomie) [18:50:35] (03CR) 10Bartosz Dziewoński: "Wow, the new CSS is ugly. I'm certain that not all of these properties are needed, but I guess this is tested and it makes sense to use th" [core] - 10https://gerrit.wikimedia.org/r/143337 (https://bugzilla.wikimedia.org/67243) (owner: 10Rillke) [18:50:37] (03PS1) 10Jdlrobson: Add generic JS error handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143372 [18:51:52] (03CR) 10Jdlrobson: [C: 04-1] "I'd urge us to go down mediawiki ui route:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143285 (owner: 10Matthias Mullie) [18:52:21] (03PS3) 10Bartosz Dziewoński: vector/jquery.ui.core.css: Update rule for .ui-helper-hidden-accessible [core] - 10https://gerrit.wikimedia.org/r/143337 (https://bugzilla.wikimedia.org/67243) (owner: 10Rillke) [18:52:23] (03PS1) 10Rohan013: Checks for each user in the $wgUsersNotifiedOnAllChange list before sending the mail [core] - 10https://gerrit.wikimedia.org/r/143373 (https://bugzilla.wikimedia.org/67041) [18:53:07] 3Wikimedia / 3SSL related: Rename wikis with multiple subdomains - 10https://bugzilla.wikimedia.org/31335#c19 (10Sam Reed (reedy)) https://github.com/EFForg/https-everywhere/pull/345 [18:54:37] 3Wikimedia / 3General/Unknown: Next wmf deployment (tracking) - 10https://bugzilla.wikimedia.org/38865 (10Bartosz Dziewoński) [18:54:37] 3MediaWiki / 3JavaScript: jQuery UI 1.9.2 autocomplete makes triggers content vanishing in Chrome, Opera next - 10https://bugzilla.wikimedia.org/67243 (10Bartosz Dziewoński) [18:55:38] 3MediaWiki / 3Database: Database: DatabaseBase::query should not write mangled binary blob to debug log - 10https://bugzilla.wikimedia.org/67382 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None Often when debugging something the debug log has massive blobs in it one has to scroll over. These have no valu... [18:55:39] (03CR) 10Bartosz Dziewoński: [C: 032] "Verified the fix." [core] - 10https://gerrit.wikimedia.org/r/143337 (https://bugzilla.wikimedia.org/67243) (owner: 10Rillke) [18:55:51] 3MediaWiki / 3General/Unknown: Extensions missing REL1_23 branches - 10https://bugzilla.wikimedia.org/67270#c4 (10Mark A. Hershberger) 5NEW>3RESO/DUP I really don't understand why this discussion didn't happen on Bug #64157, though. *** This bug has been marked as a duplicate of bug 64157 *** [18:55:51] 3MediaWiki / 3General/Unknown: Update branches in mediawiki/extensions/* for REL1_23 - 10https://bugzilla.wikimedia.org/64157#c25 (10Mark A. Hershberger) *** Bug 67270 has been marked as a duplicate of this bug. *** [18:58:42] (03PS4) 10Krinkle: vector/jquery.ui.core.css: Update rule for .ui-helper-hidden-accessible [core] - 10https://gerrit.wikimedia.org/r/143337 (https://bugzilla.wikimedia.org/67243) (owner: 10Rillke) [18:58:47] (03CR) 10Krinkle: [C: 032] vector/jquery.ui.core.css: Update rule for .ui-helper-hidden-accessible [core] - 10https://gerrit.wikimedia.org/r/143337 (https://bugzilla.wikimedia.org/67243) (owner: 10Rillke) [19:00:14] (03CR) 10Spage: [C: 031] "Before this, a no-JS workflow=&action=edit-topic-summary page would give" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143179 (owner: 10Bsitu) [19:00:38] 3MediaWiki / 3JavaScript: jQuery UI 1.9.2 autocomplete makes triggers content vanishing in Chrome, Opera next - 10https://bugzilla.wikimedia.org/67243 (10Bartosz Dziewoński) [19:03:27] (03Merged) 10jenkins-bot: vector/jquery.ui.core.css: Update rule for .ui-helper-hidden-accessible [core] - 10https://gerrit.wikimedia.org/r/143337 (https://bugzilla.wikimedia.org/67243) (owner: 10Rillke) [19:04:05] (03PS1) 10Bartosz Dziewoński: vector/jquery.ui.core.css: Update rule for .ui-helper-hidden-accessible [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143377 (https://bugzilla.wikimedia.org/67243) [19:04:49] (03PS1) 10Bartosz Dziewoński: vector/jquery.ui.core.css: Update rule for .ui-helper-hidden-accessible [core] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/143379 (https://bugzilla.wikimedia.org/67243) [19:05:54] 3MediaWiki / 3Unit tests: "Maximum execution time" error in JavaScriptMinifier while minifying QUnit test modules - 10https://bugzilla.wikimedia.org/67383 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None It might possible to make this less likely by grouping them into smaller requests. The requ... [19:09:30] (03CR) 10Hoo man: "Sadly there's more: https://github.com/search?q=user%3Awikimedia+MWInit&ref=cmdform&type=Code (please note that the search results on gith" [core] - 10https://gerrit.wikimedia.org/r/143207 (owner: 10Withoutaname) [19:11:03] (03CR) 10Aaron Schulz: API: Fix queries for list=allusers&auactiveusers (031 comment) [core] - 10https://gerrit.wikimedia.org/r/130093 (https://bugzilla.wikimedia.org/64505) (owner: 10Anomie) [19:11:08] (03CR) 10Aaron Schulz: [C: 032] API: Fix queries for list=allusers&auactiveusers [core] - 10https://gerrit.wikimedia.org/r/130093 (https://bugzilla.wikimedia.org/64505) (owner: 10Anomie) [19:11:33] anomie: one inline comment there [19:12:45] (03CR) 10Ori.livneh: [C: 032 V: 032] vector/jquery.ui.core.css: Update rule for .ui-helper-hidden-accessible [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143377 (https://bugzilla.wikimedia.org/67243) (owner: 10Bartosz Dziewoński) [19:12:53] (03CR) 10Ori.livneh: [C: 032 V: 032] vector/jquery.ui.core.css: Update rule for .ui-helper-hidden-accessible [core] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/143379 (https://bugzilla.wikimedia.org/67243) (owner: 10Bartosz Dziewoński) [19:14:56] (03Merged) 10jenkins-bot: API: Fix queries for list=allusers&auactiveusers [core] - 10https://gerrit.wikimedia.org/r/130093 (https://bugzilla.wikimedia.org/64505) (owner: 10Anomie) [19:15:58] rillke, MatmaRex: thanks for the fix [19:17:02] whee [19:18:06] 3MediaWiki / 3JavaScript: jQuery UI 1.9.2 autocomplete makes triggers content vanishing in Chrome, Opera next - 10https://bugzilla.wikimedia.org/67243#c14 (10Bartosz Dziewoński) 5PATC>3RESO/FIX Fixed by Rillke's patch, deployed by Ori. [19:18:08] 3Wikimedia / 3SSL related: Add Forward Secrecy - 10https://bugzilla.wikimedia.org/53259#c13 (10Jan Zerebecki) None of those on gdash differentiate between HTTP and HTTPS. I do not have full graphite access, so the ability to create something that might help may exist. [19:18:52] 3MediaWiki extensions / 3Scribunto: Scribunto fetchLanguageName tests fail if CLDR is not installed - 10https://bugzilla.wikimedia.org/67343 (10Brad Jorsch) 5PATC>3RESO/FIX [19:19:24] ori, wasn't really my work -- MatmaRex and Krinkle did most of it :) [19:19:43] i just merged the patch :) [19:19:57] MatmaRex, ori, thanks for backporting btw [19:20:17] rillke: btw, i think i owe you an apology for a nastygram on wikitech a month or two ago [19:20:38] i vented about some gadget on commons that i thought was enabled by default but was loading in my user js/css or something, i can't remember the particulars [19:20:41] ori: want to backport another thing? https://bugzilla.wikimedia.org/show_bug.cgi?id=67286 "Recent regression caused blurry content text on iPad (desktop/Vector skin)" [19:21:09] (see #-tech) [19:21:15] rillke: somebody called me out on it in a private email and i meant to acknowledge but i have a goldfish attention span [19:22:25] i'm not on #-tech at the moment (i know, i know) [19:22:43] greg-g: what do you think, re: the blurry content bug? it also seems kinda pressing [19:23:32] oh ipad users, so demanding with their clear text [19:23:35] ori: sure ;) [19:26:02] ori, greg-g: I'm already adding it to today's SWAT [19:26:08] or that [19:26:10] Per conversation in #wikimedia-tech [19:26:12] ipadders can ait ;) [19:26:14] wait* [19:26:32] greg-g: Also, feel free to add me back to Tue&Thu SWATs, I'm no longer unavailable on those days [19:26:32] ori: deleted the script -- since MMV is doing similar stuff, I think it's superflous and was broken in so many ways anyway [19:26:41] (03CR) 10Jforrester: "Is this still needed?" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/142251 (https://bugzilla.wikimedia.org/67138) (owner: 10Hashar) [19:26:42] (with my recent graduation and all) [19:26:44] RoanKattouw: oh right, congrats again :) [19:27:39] (03PS1) 10Cmcmahon: QA: updates to edit test ported from qa/browsertests [core] - 10https://gerrit.wikimedia.org/r/143381 [19:31:05] rillke: :) [19:39:00] (03PS1) 10Ori.livneh: updateUserCounts: fail gracefully if user lookup fails [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/143383 [19:39:03] (03PS1) 10Krinkle: Database: Generalise SQL before writing to debug log [core] - 10https://gerrit.wikimedia.org/r/143384 (https://bugzilla.wikimedia.org/67382) [19:39:16] (03PS1) 10Chad: SpecialSearch: Fix pagination [core] - 10https://gerrit.wikimedia.org/r/143385 [19:39:56] <^d> Pagination is hard. [19:40:08] (03CR) 10Krinkle: "Should be fine, but I'm not sure if it trims to much (it replaces it with 'X', as long as it does that only for blobs that is fine, but I " [core] - 10https://gerrit.wikimedia.org/r/143384 (https://bugzilla.wikimedia.org/67382) (owner: 10Krinkle) [19:40:51] 3MediaWiki / 3API: action=setnotificationtimestamp throws fatal error when parameters for the page are missing - 10https://bugzilla.wikimedia.org/48071#c4 (10Brad Jorsch) 5PATC>3RESO/FIX Should be deployed to WMF wikis with 1.24wmf12, see https://www.mediawiki.org/wiki/MediaWiki_1.24/Roadmap for the sche... [19:41:37] 3MediaWiki / 3API: list=allusers auactiveusers recenteditcount value is multiplied by the number of groups - 10https://bugzilla.wikimedia.org/64505#c4 (10Brad Jorsch) 5PATC>3RESO/FIX Should be deployed to WMF wikis with 1.24wmf12, see https://www.mediawiki.org/wiki/MediaWiki_1.24/Roadmap for the schedule. [19:41:37] 3MediaWiki / 3API: list=allusers "recenteditcount" result property is inaccurately named - 10https://bugzilla.wikimedia.org/67301#c4 (10Brad Jorsch) 5PATC>3RESO/FIX Should be deployed to WMF wikis with 1.24wmf12, see https://www.mediawiki.org/wiki/MediaWiki_1.24/Roadmap for the schedule. [19:41:37] 3MediaWiki / 3API: list=allusers auprop=groups auactiveusers limits the number of returned groups - 10https://bugzilla.wikimedia.org/64507#c4 (10Brad Jorsch) 5PATC>3RESO/FIX Should be deployed to WMF wikis with 1.24wmf12, see https://www.mediawiki.org/wiki/MediaWiki_1.24/Roadmap for the schedule. [19:41:55] 3Wikimedia / 3General/Unknown: Upload on commons disabled - 10https://bugzilla.wikimedia.org/67387 (10Steinsplitter) 3NEW p:3Unprio s:3critic a:3None If MediaWiki:Licenses subpage dos not exist upload will be disable. Example: https://commons.wikimedia.org/w/index.php?title=Special:Upload&wpDestFile... [19:42:51] 3MediaWiki extensions / 3WikidataRepo: make it possible to make the default for monolingual text no language - 10https://bugzilla.wikimedia.org/67072#c1 (10Thiemo Mättig) 5NEW>3PATC No, it should not be possible to store a monolingual value with no language. I think this is a mistake in the description.... [19:43:06] 3Wikimedia / 3General/Unknown: Upload on commons disabled - 10https://bugzilla.wikimedia.org/67387 (10Steinsplitter) p:5Unprio>3Highes s:5critic>3major [19:45:52] 3Wikimedia / 3General/Unknown: Upload on commons disabled - 10https://bugzilla.wikimedia.org/67387#c1 (10Tomasz W. Kozlowski) p:5Highes>3Immedi s:5major>3critic Raising importance since that's a very critical bug that's blocking hundreds (thousands?) of uploads on Commons right now. [19:46:37] SPQRobin: ^^ [19:48:21] 3MediaWiki / 3ResourceLoader: ResourceLoader: Remove custom LESS functions - 10https://bugzilla.wikimedia.org/67368 (10Krinkle) [19:48:36] 3MediaWiki / 3ResourceLoader: ResourceLoader: Remove custom LESS functions - 10https://bugzilla.wikimedia.org/67368 (10Krinkle) [19:49:06] (03PS1) 10QChris: Upgrade sshd to include the fix for hash mismatch [gerrit] (wmf) - 10https://gerrit.wikimedia.org/r/143388 (https://bugzilla.wikimedia.org/53895) [19:49:07] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: AutoEnrollmentTest produce a fatal error with OATHAuth extension - 10https://bugzilla.wikimedia.org/67138#c10 (10James Forrester) Fixed, maybe? [19:50:06] 3MediaWiki / 3General/Unknown: Extensions missing REL1_23 branches - 10https://bugzilla.wikimedia.org/67270#c5 (10Kunal Mehta (Legoktm)) 5RESO/DUP>3REOP How is this a duplicate? Bug 64157 is about branches pointing to the wrong place, this about branches *not existing*. [19:50:36] 3Wikimedia / 3General/Unknown: Upload on commons disabled - 10https://bugzilla.wikimedia.org/67387#c2 (10Krinkle) Likely caused by https://github.com/wikimedia/mediawiki-extensions-WikimediaMessages/commit/c6e84ba3 [19:51:36] 3MediaWiki extensions / 3WikimediaMessages: Upload on commons disabled - 10https://bugzilla.wikimedia.org/67387 (10Tomasz W. Kozlowski) [19:51:51] 3Wikimedia / 3Deployment systems: Investigate effect of multiple release branches on HHVM's JIT system - 10https://bugzilla.wikimedia.org/67168#c1 (10Bryan Davis) Created attachment 15805 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15805&action=edit Test results with HipHop VM 3.2.0-dev (rel) I h... [19:52:51] 3MediaWiki extensions / 3WikimediaMessages: Upload on commons disabled - 10https://bugzilla.wikimedia.org/67387#c3 (10Robin Pepermans (SPQRobin)) (In reply to Krinkle from comment #2) > Likely caused by > https://github.com/wikimedia/mediawiki-extensions-WikimediaMessages/commit/ > c6e84ba3 That was suppose... [19:53:21] 3MediaWiki extensions / 3WikimediaMessages: Upload on commons disabled - 10https://bugzilla.wikimedia.org/67387#c4 (10Krinkle) In fact, caused by I364f48f387d5987 (fulfilling request from bug 66960), but caused this as a regression. Change c6e84ba3d35e0d237e48 fixes it and has already been merged. Should b... [19:53:27] (03CR) 10Krinkle: "Fixes bug 67387." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/142377 (owner: 10SPQRobin) [19:53:29] (03CR) 10Legoktm: "Since $oldUser is getting its username from the existing $user object, why is it invalid?" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/143383 (owner: 10Ori.livneh) [19:53:52] (03CR) 10Isarra: "From the README: "It's suggested that you read the `normalize.css` file and consider customising it to meet your needs."" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [19:54:06] 3MediaWiki extensions / 3WikimediaMessages: Upload on commons disabled - 10https://bugzilla.wikimedia.org/67387#c5 (10Sam Reed (reedy)) (In reply to Krinkle from comment #2) > Likely caused by > https://github.com/wikimedia/mediawiki-extensions-WikimediaMessages/commit/ > c6e84ba3 Caused by? It was the comm... [19:55:25] 3MediaWiki extensions / 3WikimediaMessages: Upload on commons disabled - 10https://bugzilla.wikimedia.org/67387#c6 (10Sam Reed (reedy)) (In reply to Krinkle from comment #4) > In fact, caused by I364f48f387d5987 (fulfilling request from bug 66960), but > caused this as a regression. > > Change c6e84ba3d35e... [19:55:37] 3MediaWiki extensions / 3WikimediaMessages: Upload on commons disabled - 10https://bugzilla.wikimedia.org/67387#c7 (10Krinkle) (In reply to Krinkle from comment #4) > In fact, caused by I364f48f387d5987 (fulfilling request from bug 66960), but > caused this as a regression. > > Change c6e84ba3d35e0d237e48... [19:55:58] (03CR) 10Krinkle: "(This is a backport of c6e84ba3d35e0d237e48)" [extensions/WikimediaMessages] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142384 (owner: 10Reedy) [19:56:20] (03PS1) 10Anomie: Properly count actions in Special:ActiveUsers [core] - 10https://gerrit.wikimedia.org/r/143391 [19:56:53] (03CR) 10Anomie: API: Fix queries for list=allusers&auactiveusers (031 comment) [core] - 10https://gerrit.wikimedia.org/r/130093 (https://bugzilla.wikimedia.org/64505) (owner: 10Anomie) [19:57:06] 3MediaWiki extensions / 3WikimediaMessages: Upload on commons disabled - 10https://bugzilla.wikimedia.org/67387#c8 (10Sam Reed (reedy)) reedy@mw1017:/usr/local/apache/common/php-1.24wmf11/extensions/WikimediaMessages$ grep "UploadForm:initial" WikimediaMessages.php -A 10 $wgHooks['UploadForm:initial'][] = fu... [19:57:58] (03CR) 10Ori.livneh: "Test failure I can no longer reproduce :/ But I suppose it could happen if the user object hasn't been committed to the database yet." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/143383 (owner: 10Ori.livneh) [19:59:06] 3MediaWiki extensions / 3WikimediaMessages: Upload on commons disabled - 10https://bugzilla.wikimedia.org/67387#c9 (10Robin Pepermans (SPQRobin)) It works on all other wikis, so there appears to be somehow something Commons-specific... [20:01:18] (03CR) 10Aaron Schulz: [C: 032] Properly count actions in Special:ActiveUsers [core] - 10https://gerrit.wikimedia.org/r/143391 (owner: 10Anomie) [20:02:11] (03CR) 10Worden.lee: "OK, I must have misremembered about the ids. I guess the existing code looks things up by id, but doesn't pass ids between functions that" [core] - 10https://gerrit.wikimedia.org/r/67173 (https://bugzilla.wikimedia.org/48581) (owner: 10Worden.lee) [20:03:36] 3MediaWiki extensions / 3WikimediaMessages: Upload on commons disabled - 10https://bugzilla.wikimedia.org/67387#c10 (10Robin Pepermans (SPQRobin)) I see the problem, Commons is one of the few wikis with 'licenses' in $wgForceUIMsgAsContentMsg. [20:04:24] (03Merged) 10jenkins-bot: Properly count actions in Special:ActiveUsers [core] - 10https://gerrit.wikimedia.org/r/143391 (owner: 10Anomie) [20:08:09] (03PS1) 10MaxSem: Remove list=geopages,geopagesincategory [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/143394 [20:09:51] 3MediaWiki / 3Special pages: When Special:Contributions for a blocked user is included, the block warning is shown - 10https://bugzilla.wikimedia.org/65781#c3 (10Tomasz W. Kozlowski) Patch was merged in Gerrit, so closing as RESOLVED FIXED. Thank you for your work on this, devunt. [20:10:05] (03PS1) 10Ottomata: Hardcode versions in path to hcatalog jar [vagrant] - 10https://gerrit.wikimedia.org/r/143395 [20:10:08] (03CR) 10jenkins-bot: [V: 04-1] Hardcode versions in path to hcatalog jar [vagrant] - 10https://gerrit.wikimedia.org/r/143395 (owner: 10Ottomata) [20:10:16] (03PS2) 10Ottomata: Hardcode versions in path to hcatalog jar [vagrant] - 10https://gerrit.wikimedia.org/r/143395 [20:10:32] (03CR) 10Ottomata: [C: 032 V: 032] Hardcode versions in path to hcatalog jar [vagrant] - 10https://gerrit.wikimedia.org/r/143395 (owner: 10Ottomata) [20:11:30] (03PS1) 10SPQRobin: (bug 67387) Fix MediaWiki:Licenses requirement [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/143396 [20:11:33] (03CR) 10jenkins-bot: [V: 04-1] (bug 67387) Fix MediaWiki:Licenses requirement [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/143396 (owner: 10SPQRobin) [20:13:02] (03CR) 10Reedy: [C: 04-1] (bug 67387) Fix MediaWiki:Licenses requirement (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/143396 (owner: 10SPQRobin) [20:13:30] (03PS2) 10SPQRobin: (bug 67387) Fix MediaWiki:Licenses requirement [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/143396 [20:13:48] Reedy: I know, was fixing it :p [20:13:55] (03PS9) 10Krinkle: Fix GitInfo cache file path computation and storage location [core] - 10https://gerrit.wikimedia.org/r/142319 (https://bugzilla.wikimedia.org/53972) (owner: 10BryanDavis) [20:15:21] (03PS1) 10CSteipp: Allow tests to use setupTestDB [core] - 10https://gerrit.wikimedia.org/r/143397 [20:16:45] SPQRobin: Shouldn't it use return true/false ? [20:17:06] Or return true; in all cases I guess [20:17:27] Being a hook and everything [20:17:55] Reedy: hmm, I guess then [20:18:02] I'll change it to true [20:18:28] global $wgForceUIMsgAsContentMsg; [20:18:28] if ( !in_array( 'licenses', $wgForceUIMsgAsContentMsg ) && wfMessage( 'licenses' )->inContentLanguage()->isDisabled() ) { [20:18:28] throw new ErrorPageError( 'uploaddisabled', 'wikimedia-upload-nolicenses' ); [20:18:28] } [20:18:28] return true; [20:19:20] (03PS3) 10SPQRobin: (bug 67387) Fix MediaWiki:Licenses requirement [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/143396 [20:19:26] Maybe with your comment comewhere [20:19:27] *somewhere [20:19:49] hmm, that makes the line quite long so that's why I put it above [20:19:58] Press the enter button ;) [20:20:16] if ( !in_array( 'licenses', $wgForceUIMsgAsContentMsg ) [20:20:16] && wfMessage( 'licenses' )->inContentLanguage()->isDisabled() [20:20:16] ) { [20:20:16] throw new ErrorPageError( 'uploaddisabled', 'wikimedia-upload-nolicenses' ); [20:20:16] } [20:20:18] return true; [20:20:29] meh ugly code :p [20:20:55] Reduces code paths ;) [20:22:13] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/143004 (owner: 1001tonythomas) [20:22:39] (03CR) 10Siebrand: "i18n/L10n reviewed." [extensions/TimezoneSelector] - 10https://gerrit.wikimedia.org/r/143008 (owner: 10Lokal Profil) [20:23:08] (03PS4) 10SPQRobin: (bug 67387) Fix MediaWiki:Licenses requirement [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/143396 [20:23:12] (03PS3) 10Siebrand: English i18n messages clarified [extensions/TimezoneSelector] - 10https://gerrit.wikimedia.org/r/143008 (owner: 10Lokal Profil) [20:23:31] (03CR) 10Siebrand: [C: 032 V: 032] English i18n messages clarified [extensions/TimezoneSelector] - 10https://gerrit.wikimedia.org/r/143008 (owner: 10Lokal Profil) [20:23:41] argh stupid whitespace [20:24:07] 3MediaWiki / 3General/Unknown: Send $wgTitle to the fiery pit from whence it came - 10https://bugzilla.wikimedia.org/23307 (10Chad H.) [20:24:07] 3MediaWiki / 3General/Unknown: Classes like Parser and EditPage should use $mTitle member rather than $wgTitle - 10https://bugzilla.wikimedia.org/12710 (10Chad H.) [20:24:08] (03PS5) 10SPQRobin: (bug 67387) Fix MediaWiki:Licenses requirement [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/143396 [20:24:23] Reedy: should be ok now ^ :p [20:24:40] (03CR) 10Jdlrobson: "I'm not sure about this... an error in a get will probably want to be handled differently from a post." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143288 (owner: 10Matthias Mullie) [20:25:21] (03CR) 10Reedy: [C: 032] (bug 67387) Fix MediaWiki:Licenses requirement [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/143396 (owner: 10SPQRobin) [20:25:28] (03Merged) 10jenkins-bot: (bug 67387) Fix MediaWiki:Licenses requirement [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/143396 (owner: 10SPQRobin) [20:25:35] (03PS1) 10CSteipp: Some initial tests for CentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143401 [20:25:37] (03PS1) 10Legoktm: Convert migratePass0 to use Maintenance class [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143402 [20:25:42] (03CR) 10jenkins-bot: [V: 04-1] Some initial tests for CentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143401 (owner: 10CSteipp) [20:25:44] (03PS1) 10Reedy: (bug 67387) Fix MediaWiki:Licenses requirement [extensions/WikimediaMessages] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143403 [20:25:44] hoo, Reedy, Krenair ^ [20:26:03] (03PS29) 1001tonythomas: Added VERP functionality hook to core [core] - 10https://gerrit.wikimedia.org/r/138655 (https://bugzilla.wikimedia.org/46640) [20:26:18] (03CR) 10Reedy: [C: 032] (bug 67387) Fix MediaWiki:Licenses requirement [extensions/WikimediaMessages] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143403 (owner: 10Reedy) [20:26:43] (03CR) 10Siebrand: "Thanks, Matthias." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143301 (owner: 10Matthias Mullie) [20:26:46] (03CR) 10CSteipp: "This might be the wrong way to do this, but it was the simplest way I could see to get tests like https://gerrit.wikimedia.org/r/#/c/14340" [core] - 10https://gerrit.wikimedia.org/r/143397 (owner: 10CSteipp) [20:26:51] 3MediaWiki extensions / 3CentralAuth: Logging out on a different device logs me out everywhere else - 10https://bugzilla.wikimedia.org/49890#c15 (10Antoine "hashar" Musso) The browsertests are most probably impacted. They are run concurrently in virtual instances and wiki that have shared auth. Whenever a t... [20:27:15] er wait. [20:27:18] thats not even the right script [20:27:22] * legoktm sighs. [20:27:25] (03Merged) 10jenkins-bot: (bug 67387) Fix MediaWiki:Licenses requirement [extensions/WikimediaMessages] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143403 (owner: 10Reedy) [20:27:27] (03CR) 10Umherirrender: "What about using Database::makeWhereFrom2d instead?" [core] - 10https://gerrit.wikimedia.org/r/143222 (owner: 10Reedy) [20:28:09] (03CR) 10Siebrand: Add feature to restrict E-Maildomains (031 comment) [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142741 (https://bugzilla.wikimedia.org/67220) (owner: 10Florianschmidtwelzow) [20:28:15] (03PS30) 1001tonythomas: Added VERP functionality hook to core [core] - 10https://gerrit.wikimedia.org/r/138655 (https://bugzilla.wikimedia.org/46640) [20:28:31] (03CR) 10Siebrand: [C: 04-1] "Per PS7 discussion about a message which needs updating." [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142741 (https://bugzilla.wikimedia.org/67220) (owner: 10Florianschmidtwelzow) [20:31:25] 3MediaWiki / 3JavaScript: QUnit tests for jquery.makeCollapsible often failing on Jenkins - 10https://bugzilla.wikimedia.org/63579#c17 (10Matthew Flaschen) Actually, the first failure (at least sometimes, such as 220 mentioned above) is jquery.color. From the full log (https://integration.wikimedia.org/ci/j... [20:33:54] 3MediaWiki / 3JavaScript: QUnit tests for jquery.makeCollapsible and jquery.color failing on Jenkins - 10https://bugzilla.wikimedia.org/63579 (10Matthew Flaschen) a:5Krinkle>3Matthew Flaschen [20:34:29] (03CR) 10Nikerabbit: Handle invalid language code gracefully in Language::fetchLanguageNames (031 comment) [core] - 10https://gerrit.wikimedia.org/r/142974 (https://bugzilla.wikimedia.org/60629) (owner: 10Brian Wolff) [20:34:31] (03PS1) 10Reedy: Update WikimediaMessages to head of 1.24wmf11 branch [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143410 [20:34:45] (03CR) 10Reedy: [C: 032 V: 032] Update WikimediaMessages to head of 1.24wmf11 branch [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143410 (owner: 10Reedy) [20:36:51] (03PS1) 10Legoktm: Add $sendToRC parameter to CentralAuthUser::attach() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143419 [20:36:57] (03CR) 10Reedy: (bug 67387) Fix MediaWiki:Licenses requirement (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/143396 (owner: 10SPQRobin) [20:37:14] hoo, Krenair: https://gerrit.wikimedia.org/r/#/c/143419/ [20:39:32] (03CR) 10Hoo man: [C: 032] Add $sendToRC parameter to CentralAuthUser::attach() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143419 (owner: 10Legoktm) [20:39:37] 3MediaWiki extensions / 3WikimediaMessages: Upload on commons disabled - 10https://bugzilla.wikimedia.org/67387#c15 (10Steinsplitter) 5PATC>3RESO/FIX Works now. Thanks for fixing the bug so fast. :-) [20:39:40] (03Merged) 10jenkins-bot: Add $sendToRC parameter to CentralAuthUser::attach() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143419 (owner: 10Legoktm) [20:39:51] :) [20:39:59] (03PS11) 10Florianschmidtwelzow: Add feature to restrict E-Maildomains [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142741 (https://bugzilla.wikimedia.org/67220) [20:41:17] (03CR) 10Jdlrobson: [C: 04-1] "How can I easily force an error here? I'm not sure everything is quite right here, and it's hard to check without unit tests." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143286 (owner: 10Matthias Mullie) [20:41:22] 3Wikimedia / 3Deployment systems: Investigate effect of multiple release branches on HHVM's JIT system - 10https://bugzilla.wikimedia.org/67168#c2 (10Antoine "hashar" Musso) Would it make sense to exercise it with mediawiki core PHPUnit tests? Assuming they still pass under HHVM and they will not run against... [20:41:41] (03CR) 10SPQRobin: (bug 67387) Fix MediaWiki:Licenses requirement (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/143396 (owner: 10SPQRobin) [20:42:17] (03CR) 10Spage: [C: 032] "I cherry-picked this on top of gerrit 143179 "Some more fix to flowActions", and I can open Close topic in a new window with no errors and" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143148 (owner: 10Bsitu) [20:42:28] (03PS3) 10Jdlrobson: Hygiene: Remove unused methods in TopicBlock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143177 (owner: 10EBernhardson) [20:42:36] (03Merged) 10jenkins-bot: Fix incorrect param & add 'topicTitle' to summary API output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143148 (owner: 10Bsitu) [20:42:43] (03CR) 10Jdlrobson: [C: 032] "GTD" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143164 (owner: 10EBernhardson) [20:43:03] (03Merged) 10jenkins-bot: Reduce the number of extra Title objects generated [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143164 (owner: 10EBernhardson) [20:43:17] (03Merged) 10jenkins-bot: Hygiene: Remove unused methods in TopicBlock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143177 (owner: 10EBernhardson) [20:43:21] 3MediaWiki extensions / 3WikimediaMessages: Upload on commons disabled - 10https://bugzilla.wikimedia.org/67387#c16 (10Tomasz W. Kozlowski) 5RESO/?>3VERI Verified to work. Thanks again, guys. [20:44:27] (03CR) 10Nikerabbit: Changing language purges the page (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143026 (owner: 10Kunalgrover05) [20:45:06] (03PS1) 10Legoktm: Add $sendToRC parameter to CentralAuthUser::attach() [extensions/CentralAuth] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143473 [20:48:50] (03CR) 10Reedy: [C: 032] Add $sendToRC parameter to CentralAuthUser::attach() [extensions/CentralAuth] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143473 (owner: 10Legoktm) [20:48:56] (03Merged) 10jenkins-bot: Add $sendToRC parameter to CentralAuthUser::attach() [extensions/CentralAuth] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143473 (owner: 10Legoktm) [20:51:33] What's with this font Chrome is now using for h3 (among others)? [20:51:42] Chrome 37... [20:54:16] (03CR) 10SPQRobin: "Is it really worth having a separate PageLanguage class? It's just one function. I would maybe just leave it in SpecialPageLanguage or mov" [core] - 10https://gerrit.wikimedia.org/r/143025 (owner: 10Kunalgrover05) [20:57:34] (03PS5) 10Kunalgrover05: Backend method for Special:PageLanguage, purge on language change [core] - 10https://gerrit.wikimedia.org/r/143049 [20:59:28] (03PS1) 10Umherirrender: Add a parser tests for Header with space, plus and underscore as entity [core] - 10https://gerrit.wikimedia.org/r/143477 [20:59:30] (03CR) 10jenkins-bot: [V: 04-1] Add a parser tests for Header with space, plus and underscore as entity [core] - 10https://gerrit.wikimedia.org/r/143477 (owner: 10Umherirrender) [21:00:21] (03CR) 10Krinkle: "Hm.. unfortunately named variable. Until this point I had always thought 'wgForceUIMsgAsContentMsg' was to enforce certain message keys to" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/143396 (owner: 10SPQRobin) [21:01:07] 3MediaWiki extensions / 3CLDR: Fix/improve some translations of language names in Spanish - 10https://bugzilla.wikimedia.org/67346#c2 (10Nemo) 5UNCO>3RESO/INV Thanks for the report, I've created you an account at CLDR and you'll be able to fix the translations at http://st.unicode.org/cldr-apps/v#/es/Lan... [21:01:59] (03Abandoned) 10Kunalgrover05: Changing language purges the page [core] - 10https://gerrit.wikimedia.org/r/143026 (owner: 10Kunalgrover05) [21:02:15] (03PS1) 10Hoo man: Refactor global renaming [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143478 [21:02:25] :D [21:03:12] legoktm: Review! :D [21:03:37] No tests yet, but each part should be now be small enough to be testable without to much insanity [21:03:49] (03PS2) 10Umherirrender: Add a parser tests for Header with space, plus and underscore as entity [core] - 10https://gerrit.wikimedia.org/r/143477 [21:04:12] (03CR) 10Umherirrender: "Patch Set 2: Fixed wrong language" [core] - 10https://gerrit.wikimedia.org/r/143477 (owner: 10Umherirrender) [21:05:13] legoktm: wtf [21:05:19] Parts of my changes are missing [21:05:21] wtf [21:05:22] ? [21:05:27] :o [21:05:37] hoo: git add -A? :> [21:05:45] I guess git rebase partly killed what I did to CentralAuthUser [21:05:55] MatmaRex: If it were that easy :P [21:06:04] oh noes :/ [21:06:08] hoo: maybe it was already done in some other change? [21:06:19] Impossible [21:06:26] could be in another branch though [21:06:37] had to create a few as the underlying change changed often [21:07:44] (03CR) 10jenkins-bot: [V: 04-1] Add a parser tests for Header with space, plus and underscore as entity [core] - 10https://gerrit.wikimedia.org/r/143477 (owner: 10Umherirrender) [21:08:08] legoktm: Found it! [21:08:11] :D [21:08:15] was in one of the other branche [21:08:16] s [21:08:19] oh damn :P [21:08:24] Now copy and paste... [21:08:42] I hope I didn't loose anything else :D [21:09:23] hoo needs a better clipboard [21:12:26] (03PS4) 10Jdlrobson: Let's not assume API always responds [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143316 (owner: 10Matthias Mullie) [21:13:18] (03CR) 10Jdlrobson: [C: 032] Let's not assume API always responds [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143316 (owner: 10Matthias Mullie) [21:13:29] (03PS4) 10Jdlrobson: Error handling for view-topiclist actions (change sort & load more) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143342 (owner: 10Matthias Mullie) [21:14:30] (03PS1) 10Mattflaschen: Use QUnit.asyncTest even for fake timers, to fix spurious failures [core] - 10https://gerrit.wikimedia.org/r/143481 (https://bugzilla.wikimedia.org/63579) [21:15:25] (03CR) 10Krinkle: [C: 04-1] Let's not assume API always responds (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143316 (owner: 10Matthias Mullie) [21:15:41] (03CR) 10Krinkle: "Didn't mean to -1, just fyi." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143316 (owner: 10Matthias Mullie) [21:18:00] (03CR) 10Umherirrender: "Needs a idea to fix the id of section 2: Space-Entity+between+Text is wrong, it needs to be Space-Entity_between_Text" [core] - 10https://gerrit.wikimedia.org/r/143477 (owner: 10Umherirrender) [21:18:07] (03CR) 10Krinkle: Add generic JS error handling (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143372 (owner: 10Jdlrobson) [21:19:59] (03CR) 10Jdlrobson: [C: 031] "Yeh.. i'll take a closer look at that." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143316 (owner: 10Matthias Mullie) [21:22:03] hashar, around? [21:22:16] i'm trying to sort out https://bugzilla.wikimedia.org/show_bug.cgi?id=67142 [21:22:36] yurikR: na in bed / sleepingin a sec [21:22:51] (03PS2) 10Hoo man: Refactor global renaming [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/143478 [21:23:05] (03PS6) 10Kunalgrover05: Backend method for Special:PageLanguage, purge on language change [core] - 10https://gerrit.wikimedia.org/r/143049 [21:23:05] legoktm: Hope I've got it all together again now [21:23:07] hashar, i'll be quick - do i need to do anything to run those tests? [21:23:12] yurikR: I got the stack trace attached though :D [21:23:21] PS2 is untested :/ PS1 should work as good as oyur version [21:23:27] i have a number of extensions, including zero, and all tests pass on master [21:23:27] haha, "refactor" :D [21:23:33] when's the release date? :D [21:23:37] hashar, ^ [21:23:39] yurikR: I reproduce it with a freshly installed wiki with a bunch of extensions installed https://bugzilla.wikimedia.org/show_bug.cgi?id=67142#c0 [21:23:43] * legoktm looks [21:24:01] hashar, do i need to edit any phpunit configs? [21:24:06] to list extensions [21:24:19] or what's your custom localsettings? [21:24:44] yurikR: well it is LocalSettings.php as generated by install.php so it is very basic + a bit of $wgDebug enabled [21:24:51] 3Wikimedia / 3General/Unknown: Audit centralauth database for inconsistencies - 10https://bugzilla.wikimedia.org/67350#c2 (10Kunal Mehta (Legoktm)) (In reply to Chris Steipp from comment #1) > Thanks! Was it the same username across those wikis that was invalid? It > just seems odd that there is exactly 1 in... [21:25:04] yurikR: i.e. $wgJsonConfigs is not tweaked at all in LocalSetting.php [21:25:17] hashar, what about enabling extensions? [21:25:32] do you explicitly require jsonconfig, zerobanner, zeroportal? [21:25:37] yurikR: there is some part of the code that assumes there is a JsonZeroConfig key, but that is not the case with a default LocalSettings.php Ie when someone did not configure anything [21:26:05] yurikR: ContributionTracking DonationInterface JsonConfig MobileFrontend ZeroBanner ZeroPortal [21:26:07] hashar, https://gerrit.wikimedia.org/r/#/c/142832/4/puppet/manifests/roles/zero.pp [21:26:35] this is the zero role we use for vagrant [21:26:36] yurikR: and the foreach $ext: include( "$IP/$ext/$ext.php" ); (i.e. no further configuration) [21:27:09] hashar, right, but zero exts assume a bit of further config, otherwise it doesn't know if its server or client [21:27:18] yurikR: the goal of the bug is to be able to run the test suite with no specific configuration beside the defaults provided by the extension :] [21:27:49] yurikR: it is all good beside that $wgJsonConfig . I am sure it can be solved. I guess some code should happy return whenever the key JsonZeroConfig is missing [21:28:04] MatmaRex: 9th I think? [21:28:16] yurikR: code assume it is there. Probably because some test is invoking a ZeroPortal hook [21:28:30] ok, so unittests must pass without extra configs? hmm... ok, i guess we could hack something [21:28:55] yurikR: ideally yes :-] [21:29:20] yurikR: I am not feeling like figuring out all extensions specific config settings needed to have tests pass. So would prefer unit tests to pass out of the box hehe [21:29:27] yurikR: stack trace is at https://bugzilla.wikimedia.org/attachment.cgi?id=15752 [21:29:43] Krinkle: do you have some time to look at https://gerrit.wikimedia.org/r/#/c/142766/ and its related patches? [21:29:48] yurikR: it is riggered by a test in DonationInterface: /extensions/DonationInterface/tests/Adapter/GlobalCollect/GlobalCollectTestCase.php [21:30:21] yurikR: which eventually ends up calling some ZeroConfigPortal hook which assume wgJsonConfigs['JsonZeroConfig']['url'] exist. Should be handled IMHO [21:30:53] (03CR) 10Krinkle: [C: 04-2] "Sorry for jumping the gun, but please do provide a little more backstory as to why this would be needed. If these are async in anyway then" [core] - 10https://gerrit.wikimedia.org/r/143481 (https://bugzilla.wikimedia.org/63579) (owner: 10Mattflaschen) [21:30:54] hashar, i know exactly what is happening. Just trying to figure out the testing harness [21:31:18] i feel like we should have per-extension specific settings for unittesting [21:31:27] I would prefer we avoid that path [21:31:36] 3MediaWiki / 3JavaScript: QUnit tests for jquery.makeCollapsible and jquery.color failing on Jenkins - 10https://bugzilla.wikimedia.org/63579#c19 (10Krinkle) Considering it is only affecting tests related to asynchronous Date manipulation, I suspect one or more of the extensions the Growth team maintains is... [21:31:57] yurikr: that is going to be a nightmare to manage. So I would prefer tests to pass out of the box or the extension to provide sane default settings [21:34:42] hashar, oki, will see what i can do [21:34:48] thx for explaining, good night :) [21:35:13] (03CR) 10Aaron Schulz: [C: 032] Database: Generalise SQL before writing to debug log [core] - 10https://gerrit.wikimedia.org/r/143384 (https://bugzilla.wikimedia.org/67382) (owner: 10Krinkle) [21:35:21] yurikR: we can continue the discussion on the bug report :] [21:35:47] yurikR: I would like to find a solution that is easy for you guys and work out of the box so I don't have to maintain a bunch of custom settings :D [21:38:15] yurikR: sleeping for now sorry ! have a good day. [21:38:41] (03Merged) 10jenkins-bot: Database: Generalise SQL before writing to debug log [core] - 10https://gerrit.wikimedia.org/r/143384 (https://bugzilla.wikimedia.org/67382) (owner: 10Krinkle) [21:39:28] (03CR) 10Bartosz Dziewoński: "I'd love to hear an explanation why this works instead of just accepting the magic, but if this does actually fix the immediate issue, the" [core] - 10https://gerrit.wikimedia.org/r/143481 (https://bugzilla.wikimedia.org/63579) (owner: 10Mattflaschen) [21:39:52] hashar, we can easily make it so that if both ZeroBanner & ZeroPortal are installed, it works, but it barfs if just zeroBanner is on [21:40:50] (03CR) 10Jdlrobson: "Also appears to render below the form and not inside the form..?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143286 (owner: 10Matthias Mullie) [21:43:17] (03PS1) 10Spage: "can not" typo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143488 [21:47:08] (03CR) 10Legoktm: "That shouldn't affect it right?" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/143383 (owner: 10Ori.livneh) [21:50:05] (03PS1) 10Chad: Random searches: only return page from Elasticsearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/143489 [21:50:09] (03CR) 10Krinkle: "Indeed, user objects are also used to create new users." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/143383 (owner: 10Ori.livneh) [21:51:05] (03CR) 10Krinkle: "However if the username is invalid, it does return false." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/143383 (owner: 10Ori.livneh) [21:51:55] (03CR) 10Spage: [C: 032] "I can't reproduce the problem described in the Trello card https://trello.com/c/tXa05k4A/ mentioned in the removed comment. Not expanding " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143351 (owner: 10Jdlrobson) [21:52:18] (03Merged) 10jenkins-bot: QA: Make close/open topics test pass again [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143351 (owner: 10Jdlrobson) [21:54:05] (03PS1) 10Yurik: Matching default ZeroPortal config changes per bug 67142 [vagrant] - 10https://gerrit.wikimedia.org/r/143492 [21:56:24] (03PS1) 10Mattflaschen: Use 'json' module instead of deprecated 'jquery.json' [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/143494 [21:58:33] (03PS1) 10EBernhardson: Dont enable whitespace checks in jshint [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143495 [21:59:09] (03CR) 10MaxSem: [C: 032] Matching default ZeroPortal config changes per bug 67142 [vagrant] - 10https://gerrit.wikimedia.org/r/143492 (owner: 10Yurik) [22:01:52] MatmaRex: lol, mw.user deprecations went down massively June 20 [22:01:54] http://codepen.io/Krinkle/full/zyodJ/ [22:01:59] ./mediawiki.user [22:02:07] 3MediaWiki / 3Parser: Allow HTML5 tag (ruby support for East Asian typography) - 10https://bugzilla.wikimedia.org/67042 (10Nemo) [22:02:11] Do you know anything about that? [22:02:38] (03PS1) 10Bsitu: [WIP]Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 [22:02:56] Krinkle: still no per-wiki breakdown? [22:02:59] (03CR) 10jenkins-bot: [V: 04-1] [WIP]Flow topic subscription [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143498 (owner: 10Bsitu) [22:03:12] Nemo_bis: Nope, and that's not been requested afaik [22:03:20] so it's not going to appear unless you make it happen [22:03:23] The data is there though [22:03:44] we collect it per wiki per mediawiki-version per page/oldid/curid even [22:03:51] 3MediaWiki / 3General/Unknown: Extensions missing REL1_23 branches - 10https://bugzilla.wikimedia.org/67270#c6 (10Mark A. Hershberger) Thanks for pointing that difference out. I missed it. They're symptoms of the same problem. Fixing both at the same time right now. [22:04:06] https://github.com/wikimedia/mediawiki-extensions-WikimediaEvents/blob/master/modules/ext.wikimediaEvents.deprecate.js#L17-L20 [22:04:20] But those aren't aggregated in statsd [22:04:43] Nemo_bis: Note that per wiki would make it even harder to interpret due to traffic fluctuation. These are client-side, not server-side. [22:04:49] Ok. I just had a (false) remembrance that it was in the plans [22:04:58] Sure [22:05:08] If you're curious about usage and want to help out though, I can dump a few random rows with detailed information to dig through [22:05:23] Krinkle: hm, nope [22:05:26] however at this point there's plenty of usage to find even without db dumps using Special:Search on major wikis [22:06:23] 3MediaWiki extensions / 3WikidataRepo: [Monolingual] Old value is saved when keys are pressed to fast - 10https://bugzilla.wikimedia.org/67393 (10Thiemo Mättig) 3NEW p:3Unprio s:3critic a:3Wikidata bugs Steps to reproduce: 1. Edit an existing monolingual value. Lets say it contains the string "Test"... [22:07:21] 3MediaWiki extensions / 3WikidataRepo: UI for monolingual text datatype - 10https://bugzilla.wikimedia.org/64290 (10Thiemo Mättig) [22:07:21] 3MediaWiki extensions / 3WikidataRepo: [Monolingual] Old value is saved when keys are pressed to fast - 10https://bugzilla.wikimedia.org/67393 (10Thiemo Mättig) p:5Unprio>3High [22:08:37] (03CR) 10Bsitu: [C: 032] "Should have another patch to fix all the whitespace errors and turn this back on. It has 300 such errors with 23% scanned, :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143495 (owner: 10EBernhardson) [22:08:53] 3MediaWiki extensions / 3WikidataRepo: [Monolingual] Can not search for language names in my language - 10https://bugzilla.wikimedia.org/67394 (10Thiemo Mättig) 3NEW p:3Unprio s:3major a:3Wikidata bugs Steps to reproduce: 1. Set UI language to English. 2. Edit a monolignual value. 3. Edit the langua... [22:08:54] (03Merged) 10jenkins-bot: Dont enable whitespace checks in jshint [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143495 (owner: 10EBernhardson) [22:09:36] 3MediaWiki extensions / 3WikidataRepo: UI for monolingual text datatype - 10https://bugzilla.wikimedia.org/64290 (10Thiemo Mättig) [22:09:36] 3MediaWiki extensions / 3WikidataRepo: [Monolingual] Can not search for language names in my language - 10https://bugzilla.wikimedia.org/67394 (10Thiemo Mättig) p:5Unprio>3Normal [22:10:39] (03PS1) 10Jdlrobson: WIP: Ensure buttons are disabled by default for reply and create topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143499 [22:10:39] 3MediaWiki extensions / 3WikidataRepo: [Monolingual] Exact language code match should be first - 10https://bugzilla.wikimedia.org/67395 (10Thiemo Mättig) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Steps to reproduce: 1. Edit a monolignual value. 2. Search for "en". Result: "en" is 4th in the list. "... [22:11:59] (03CR) 10Spage: [C: 04-1] "But Flow doesn't use the Vertically-stacked form design that mw-ui-vform implements. Flow's buttons and textareas aren't full-width, we're" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143369 (owner: 10Jdlrobson) [22:12:06] 3MediaWiki extensions / 3WikidataRepo: [Monolingual] Exact language code match should be first - 10https://bugzilla.wikimedia.org/67395 (10Thiemo Mättig) p:5Unprio>3Low s:5normal>3minor [22:12:21] 3MediaWiki extensions / 3WikidataRepo: [Monolingual] Can not search for language names in my language - 10https://bugzilla.wikimedia.org/67394 (10Thiemo Mättig) [22:12:21] 3MediaWiki extensions / 3WikidataRepo: UI for monolingual text datatype - 10https://bugzilla.wikimedia.org/64290 (10Thiemo Mättig) [22:13:23] 3MediaWiki extensions / 3WikidataRepo: [Monolingual] Valid language codes are not saved when typed manually - 10https://bugzilla.wikimedia.org/67396 (10Thiemo Mättig) 3NEW p:3Unprio s:3enhanc a:3Wikidata bugs Steps to reproduce: 1. Edit a monolignual value. 2. Change the text a bit so the "save" but... [22:13:46] (03CR) 10Spage: "Gerrit 143148 fixed some of the things I commented on, so this is looking even better." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143179 (owner: 10Bsitu) [22:13:51] 3MediaWiki extensions / 3WikidataRepo: [Monolingual] Valid language codes are not saved when typed manually - 10https://bugzilla.wikimedia.org/67396 (10Thiemo Mättig) p:5Unprio>3High [22:13:51] 3MediaWiki extensions / 3WikidataRepo: UI for monolingual text datatype - 10https://bugzilla.wikimedia.org/64290 (10Thiemo Mättig) [22:17:03] (03CR) 10Krinkle: [C: 04-1] "minor" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/142830 (owner: 10Legoktm) [22:17:06] (03CR) 10Jdlrobson: [C: 032] "Thanks for clarifying." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143183 (owner: 10EBernhardson) [22:18:02] (03PS2) 10Jdlrobson: i18n: "can not" typo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143488 (owner: 10Spage) [22:19:35] (03CR) 10Jdlrobson: [C: 032] i18n: "can not" typo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143488 (owner: 10Spage) [22:19:52] (03Merged) 10jenkins-bot: i18n: "can not" typo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143488 (owner: 10Spage) [22:20:42] MatmaRex: ping [22:20:53] paravoid: pong [22:20:57] hi [22:20:58] * MatmaRex wonders what he broke [22:21:02] nothing :) [22:21:15] I was reading #43740 and saw your name there [22:21:30] so I hoped you might know the answer what I'm about to ask :) [22:21:52] we're working on an combined HHVM + trusty next generation appservers [22:21:53] fro a while [22:22:23] we currently run precise, which comes with libicu 4.8.1; trusty comes with libicu 52 [22:22:33] back when we did the lucid->precise upgrade, I remember running into issues with collation [22:23:06] and we had to build the lucid's libicu for precise, do the gradual upgrade, then at the end switch them all to 4.8.1 and run a maintenance script [22:23:17] (03PS5) 10Jdlrobson: Let's not assume API always responds [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143316 (owner: 10Matthias Mullie) [22:23:19] hmm [22:23:21] this is the plan for this upgrade right now as well, but I'm wondering if we could avoid that somehow :) [22:23:34] (03CR) 10Jdlrobson: [C: 031] "With Krinkle's concern corrected." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143316 (owner: 10Matthias Mullie) [22:23:52] in other words, if it's possible to run a cluster with mixed ICU versions cluster with no noticeable breakage [22:24:04] it's no big deal if it's not, but I thought it worthed the research :) [22:24:12] paravoid: i'm not as knowledgeable about icu as i look like :) [22:24:31] heh okay, fair enough [22:24:37] paravoid: if the format of the sortkeys icu generated did not change between 4.8 and 52, it is [22:24:53] otherwise is definitely isn't with the current code and probably isn't at all [22:25:07] paravoid: bawolff and tim know more about how it works [22:25:33] yeah I'll ask Tim [22:25:41] I meant to yesterday, but forgot :) [22:26:09] thanks :) [22:26:16] paravoid: the simplest way to learn would be to test it :) install a wiki on icu 4.8 with uca collation, import a category from a wmf wiki, upgrade icu, and start purging pages and seeing if the sort order changes [22:26:49] (null-editing pages, rather, the distinction might matter) [22:27:02] that's more work than rebuilding ICU 4.8.1 for trusty [22:27:10] if it changes, then the sortkeys are incompatible [22:27:10] heh [22:28:01] that's fine, doing that now [22:28:21] 3Wikimedia / 3Bugzilla: Create a MediaWiki extensions component for ZeroPortal - 10https://bugzilla.wikimedia.org/67143#c8 (10dr0ptp4kt) Arthur and I emailed about this. Let's go ahead with the separate components. Thanks! [22:34:34] (03CR) 10Brion VIBBER: "Note that Sanitizer and/or tidy don't handle the implied close tag rules in the spec." [core] - 10https://gerrit.wikimedia.org/r/141742 (https://bugzilla.wikimedia.org/67042) (owner: 10Cscott) [22:35:27] (03CR) 10Jdlrobson: "Will leave to a 3rd party to decide which route to go down.. mediawiki ui or custom form, but at some point we should move towards mediawi" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143285 (owner: 10Matthias Mullie) [22:35:37] (03CR) 10Jdlrobson: [C: 04-1] "Reply appears below the form rather than above." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143287 (owner: 10Matthias Mullie) [22:38:15] is there anything i can config to enable more caching in dev w/ resource loader? i have some browsertests timing out because the various css/less/etc takes several seconds to process and load [22:38:31] (03CR) 10Jdlrobson: "The problem with having this hidden away in BetaFeatures is we are not sharing mediawiki ui components so we will continue this bad patter" [core] - 10https://gerrit.wikimedia.org/r/75143 (owner: 10MarkTraceur) [22:38:33] as an example, this one usually takes >2.5s : http://localhost:8080/w/load.php?debug=false&lang=en&modules=startup&only=scripts&skin=vector&* [22:39:26] (03CR) 10Cscott: "Well, latest firefox and chrome already implement . And supporting it won't do any harm until/unless somebody actually uses it in co" [core] - 10https://gerrit.wikimedia.org/r/141742 (https://bugzilla.wikimedia.org/67042) (owner: 10Cscott) [22:39:37] or do i need some sort of independant varnish server sitting on front of mw to do that? [22:40:21] (03CR) 10Brion VIBBER: "Couple lines in some of the parser test examples look wrong to me..." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/141742 (https://bugzilla.wikimedia.org/67042) (owner: 10Cscott) [22:41:23] (03CR) 10Jdlrobson: [C: 04-1] "This needs to be ported to LESS and needs to include documentation so it is included in the living style guide." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/75143 (owner: 10MarkTraceur) [22:42:09] (03PS3) 10Spage: Error handling for new-topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143286 (owner: 10Matthias Mullie) [22:42:35] cscott: *nod* i’m gonna do a quick test and then merge if nothing strikes me as freaky :D [22:42:55] gotta test a mobile patch real quick brb [22:44:21] superm401: still unable to repro https://bugzilla.wikimedia.org/show_bug.cgi?id=66764 [22:44:38] no problem. just figured i should document the conversation in gerrit. [22:44:44] brion: ^ [22:44:49] marxarelli, did you try a fresh instance? [22:44:52] superm401: i was wondering if you had time this week for some troubleshooting [22:45:19] superm401: completely fresh, yeah [22:46:31] marxarelli, alright, if you let me know a time, I can troubleshoot with you. [22:46:34] superm401: nice to meet you, btw :) [22:47:00] superm401: for sure. you're not in sf, right? [22:47:14] marxarelli, you're Dan Duvall, right? [22:47:21] superm401: that's right [22:47:27] Good to meet you too. [22:47:56] No, I'm in Philadelphia right now, but I'll be going to SF on July 13th for a week. [22:48:03] oh, nice [22:48:36] if you want to propose a time before then, my calendar is almost completely open [22:49:24] (03CR) 10Spage: [C: 032] "The block styling in layout.less for errorbox duplicates what 'mw-ui-vform' does in core, but I'm leery of changing all Flow forms to a cl" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143285 (owner: 10Matthias Mullie) [22:49:26] looks like FirefoxNightly does the parsing but doesn’t do any ruby styling yet [22:49:32] lemme test webkit & ie [22:49:42] (03CR) 10jenkins-bot: [V: 04-1] Add generic JS error handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143285 (owner: 10Matthias Mullie) [22:51:14] marxarelli, alright, sent. [22:52:00] hmm [22:52:14] mono-ruby and group ruby show ok in safari current and webkit nightly [22:52:23] but inline ruby and double-sided ruby show wrong [22:52:28] superm401: perfect. we'll hulk smash this thing on thursday [22:55:39] IE 11 and IE developer preview show the inline ruby correctly as well, and show the double-sided ruby not double-sided but in the way i expected [22:56:33] Is there any way they could not have used the term "ruby"? :-) [22:56:35] (03PS1) 10MaxSem: Remove 'webkit-backface-visibility' rule which made iPads super blurry [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143503 (https://bugzilla.wikimedia.org/67286) [22:56:42] Mostconfusing. [22:57:06] (03CR) 10MaxSem: [C: 032] Remove 'webkit-backface-visibility' rule which made iPads super blurry [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143503 (https://bugzilla.wikimedia.org/67286) (owner: 10MaxSem) [22:57:24] MaxSem: Tsk, it's not even 16:00 yet. ;-) [22:57:30] \o/ [22:57:31] (03PS1) 10MaxSem: Remove 'webkit-backface-visibility' rule which made iPads super blurry [core] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/143504 (https://bugzilla.wikimedia.org/67286) [22:57:48] (03CR) 10MaxSem: [C: 032] Remove 'webkit-backface-visibility' rule which made iPads super blurry [core] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/143504 (https://bugzilla.wikimedia.org/67286) (owner: 10MaxSem) [22:58:36] superm401: thanks for the rbenv feedback in that other ticket, btw. i'm helping out where i can to improve mw-vagrant and you seem to have some really good insight into popular use cases for it. maybe we can chat about it when you're in sf [23:06:42] MaxSem: confirmed! [23:06:45] (03CR) 10Ori.livneh: [C: 032] Use 'json' module instead of deprecated 'jquery.json' [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/143494 (owner: 10Mattflaschen) [23:06:52] the webkit-backface-visibility rule is gone, and the text is sharper [23:07:08] wee [23:07:22] (03PS1) 10Reedy: Update CentralAuth to master of 1.24wmf11 branch [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143505 [23:07:43] (03CR) 10MaxSem: [C: 032 V: 032] Update CentralAuth to master of 1.24wmf11 branch [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143505 (owner: 10Reedy) [23:08:22] 3MediaWiki extensions / 3Semantic MediaWiki: SMW + 4store: SMWSparqlDatabaseError / Malformed query - 10https://bugzilla.wikimedia.org/43708#c5 (10MWJames) 5PATC>3RESO/FIX Ought to be fixed with [0]. For details on the test environment, see [0, 1]. [0] https://github.com/SemanticMediaWiki/SemanticMediaW... [23:08:23] (03Merged) 10jenkins-bot: Use 'json' module instead of deprecated 'jquery.json' [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/143494 (owner: 10Mattflaschen) [23:08:48] * ebernhardson throws '(req.http.Cookie && !req.url ~ "^/w/load.php" ) ' into vcl_recv and prays for no big issues [23:08:59] (03PS1) 1020after4: Custom user profile field to display a link to the mediawiki SUL account that is associated with each phabricator account. [phabricator/phabricator] - 10https://gerrit.wikimedia.org/r/143506 [23:09:36] 3MediaWiki extensions / 3Semantic MediaWiki: SMW_refreshData.php fails with 4store RDF store backend - 10https://bugzilla.wikimedia.org/44700#c3 (10MWJames) 5PATC>3RESO/FIX Ought to be fixed with [0]. For details on the test environment, see [0, 1]. [0] https://github.com/SemanticMediaWiki/SemanticMedia... [23:11:07] 3MediaWiki / 3Parser: Allow HTML5 tag (ruby support for East Asian typography) - 10https://bugzilla.wikimedia.org/67042#c7 (10Brion Vibber) Created attachment 15809 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15809&action=edit Current rendering of ruby samples in IE 11 & dev preview with pat... [23:16:36] 3MediaWiki / 3Parser: Allow HTML5 tag (ruby support for East Asian typography) - 10https://bugzilla.wikimedia.org/67042#c8 (10Brion Vibber) Created attachment 15810 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15810&action=edit Screenshot of ruby examples in current Safari 7.0.5 For referenc... [23:19:12] (03PS2) 10Jdlrobson: Ensure buttons are disabled by default for reply and create topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143499 [23:19:15] (03PS1) 10Jdlrobson: WIP: QA: Add tests for required input fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143507 [23:19:54] (03PS6) 10Jdlrobson: Add generic JS error handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143285 (owner: 10Matthias Mullie) [23:20:06] (03PS4) 10Jdlrobson: Error handling for new-topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143286 (owner: 10Matthias Mullie) [23:20:32] RoanKattouw_away: http://core.local/index.php/XXXXX?mobileaction=beta#editor/0 [23:25:32] (03CR) 10Brion VIBBER: [C: 04-1] "I recommend removing the extra wrappers in the parser test cases where they were added (leaving the new examples copied from the spe" [core] - 10https://gerrit.wikimedia.org/r/141742 (https://bugzilla.wikimedia.org/67042) (owner: 10Cscott) [23:25:50] cscott: just a minor nit on some of the parser test cases that got tweaked, otherwise the patch looks fine [23:26:03] rendering of ruby is a bit inconsistent across browsers, but that’s no surprise :D [23:26:07] 3MediaWiki / 3Skin and page rendering: Recent regression caused blurry content text on iPad (desktop/Vector skin) - 10https://bugzilla.wikimedia.org/67286#c9 (10Jon) This is quite a well known issue and there for a good reason I suspect, so I'd urge you to reconsider the fix as by removing it you have probab... [23:26:21] i’m happy the basic ones work in more than just IE now (chrome/safari work on the simple cases) [23:26:33] and hopefully actual rendering of ruby is coming to firefox soon :D [23:27:51] (03PS1) 10Aaron Schulz: Added signal handling [services/jobrunner] - 10https://gerrit.wikimedia.org/r/143511 [23:27:52] 3MediaWiki / 3Skin and page rendering: Recent regression caused blurry content text on iPad (desktop/Vector skin) - 10https://bugzilla.wikimedia.org/67286#c10 (10Brion Vibber) (In reply to Jon from comment #9) > This is quite a well known issue and there for a good reason I > suspect, so I'd urge you to reco... [23:28:37] kaldari: http://localhost/w/extensions/VisualEditor/lib/ve/demos/ve/mobile.html [23:30:28] (03CR) 10Mattflaschen: "My original theory (when I uploaded this patch) was that tick might be async in some circumstances (even if still far faster than the actu" [core] - 10https://gerrit.wikimedia.org/r/143481 (https://bugzilla.wikimedia.org/63579) (owner: 10Mattflaschen) [23:32:36] 3MediaWiki / 3Skin and page rendering: Recent regression caused blurry content text on iPad (desktop/Vector skin) - 10https://bugzilla.wikimedia.org/67286#c11 (10Bartosz Dziewoński) There's been a duplicate bug report and at least one person complaining about this on IRC (today), in addition to what Brion po... [23:32:37] 3MediaWiki / 3Skin and page rendering: Recent regression caused blurry content text on iPad (desktop/Vector skin) - 10https://bugzilla.wikimedia.org/67286 (10Bartosz Dziewoński) 5PATC>3RESO/FIX [23:34:39] (03CR) 10Spage: "Also fixes topic action menu > right-click Hide topic , Without this action=moderate-topic&topic_moderationState=hide would give No such a" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143179 (owner: 10Bsitu) [23:34:54] (03PS1) 10Withoutaname: Change installer system message for register_globals check [core] - 10https://gerrit.wikimedia.org/r/143515 [23:35:32] (03CR) 10Withoutaname: Reword lede in release-notes security reminder (031 comment) [core] - 10https://gerrit.wikimedia.org/r/142814 (owner: 10Withoutaname) [23:35:49] (03PS3) 10Withoutaname: Reword lede in release-notes security reminder [core] - 10https://gerrit.wikimedia.org/r/142814 [23:36:30] (03CR) 10Bartosz Dziewoński: "I'm pretty sure 'lede' is not a real word." [core] - 10https://gerrit.wikimedia.org/r/142814 (owner: 10Withoutaname) [23:37:43] (03PS3) 10EBernhardson: Rename flow-board to flow-workflow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143183 [23:37:48] (03CR) 10Jdlrobson: [C: 032] Rename flow-board to flow-workflow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143183 (owner: 10EBernhardson) [23:38:07] (03CR) 10Jackmcbarn: [C: 031] Change installer system message for register_globals check [core] - 10https://gerrit.wikimedia.org/r/143515 (owner: 10Withoutaname) [23:38:15] (03Merged) 10jenkins-bot: Rename flow-board to flow-workflow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143183 (owner: 10EBernhardson) [23:38:27] (03PS1) 10Aaron Schulz: Allow 0 runner loops and added some sanity checks [services/jobrunner] - 10https://gerrit.wikimedia.org/r/143516 [23:39:50] (03CR) 10Brion VIBBER: "'lede' is US typography jargon: http://en.wiktionary.org/wiki/lede#Noun_2" [core] - 10https://gerrit.wikimedia.org/r/142814 (owner: 10Withoutaname) [23:42:28] (03PS4) 10Withoutaname: Reword security reminder at the top of the release notes [core] - 10https://gerrit.wikimedia.org/r/142814 [23:42:39] (03CR) 10Spage: "Pinkness." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/143285 (owner: 10Matthias Mullie) [23:43:07] 3MediaWiki / 3JavaScript: QUnit tests for jquery.makeCollapsible and jquery.color failing on Jenkins - 10https://bugzilla.wikimedia.org/63579#c20 (10Matthew Flaschen) (In reply to Krinkle from comment #19) > Considering it is only affecting tests related to asynchronous Date > manipulation, I suspect one or... [23:44:18] (03CR) 10MSyed: [C: 032 V: 032] Create a new Middleman project [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/136018 (owner: 10Prtksxna) [23:44:36] brion: interesting [23:45:08] WP:LEDE, of course. [23:45:19] (03PS2) 10Jdlrobson: Hygiene: Remove useless helper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142599 [23:45:50] (03CR) 10Jackmcbarn: [C: 031] Reword security reminder at the top of the release notes [core] - 10https://gerrit.wikimedia.org/r/142814 (owner: 10Withoutaname) [23:46:05] (03CR) 10Chad: Reword security reminder at the top of the release notes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/142814 (owner: 10Withoutaname) [23:46:10] (03CR) 10Withoutaname: "Thanks for the search; I'm sorry I missed them initially. I can help with uploading patches for the rest of them." [core] - 10https://gerrit.wikimedia.org/r/143207 (owner: 10Withoutaname) [23:46:14] (03CR) 10MSyed: [C: 032 V: 032] Add bootstrap [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/136027 (owner: 10Prtksxna) [23:46:31] (03CR) 10MSyed: [C: 032 V: 032] Add .gitignore [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/136029 (owner: 10Prtksxna) [23:46:44] (03CR) 10Jdlrobson: "As suggested by Shahyar I checked in IE6,7,8 and found no issues with this button." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142599 (owner: 10Jdlrobson) [23:46:51] silly yanks. [23:48:03] (03CR) 10MZMcBride: Reword security reminder at the top of the release notes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/142814 (owner: 10Withoutaname) [23:48:08] https://en.wikipedia.org/w/index.php?title=Wikipedia:LEDE&action=history ah, it was a "{{R from misspelling}}" for a while. [23:48:16] :) [23:48:55] (03CR) 10MSyed: [C: 032 V: 032] Create DMCA page [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/136028 (owner: 10Prtksxna) [23:49:35] Journalists have created lots of silly words. [23:49:46] BY THE WAY, I discovered a neat category on Wiktionary today. [23:50:15] https://en.wiktionary.org/wiki/Category:English_pluralia_tantum is great. [23:50:31] I was tickled by some of the entries. [23:55:06] (03PS1) 10MSyed: add default ruby and gemset to gemfile [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/143519 [23:55:37] (03CR) 10MSyed: [C: 032 V: 032] add default ruby and gemset to gemfile [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/143519 (owner: 10MSyed)