[00:01:11] (03PS1) 10CSteipp: Always create global account on account creation [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/142464 (https://bugzilla.wikimedia.org/67175) [00:01:43] (03CR) 10CSteipp: [C: 04-2] "Dan would like to announce this, and give people time to merge their account before we roll this out." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/142464 (https://bugzilla.wikimedia.org/67175) (owner: 10CSteipp) [00:02:37] (03CR) 10Skizzerz: "Yeah, that's what I meant by the +1 (sorry, didn't see the question until just now). I'll upload a new patchset to make it mergeable again" [core] - 10https://gerrit.wikimedia.org/r/135714 (https://bugzilla.wikimedia.org/65757) (owner: 10Rillke) [00:02:40] (03PS10) 10Prtksxna: Add settings [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140086 [00:04:35] (03PS1) 10Jforrester: Update OOjs to v1.0.10 [core] - 10https://gerrit.wikimedia.org/r/142465 [00:05:29] (03CR) 10Prtksxna: [C: 04-1] "use localStorage." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140086 (owner: 10Prtksxna) [00:07:55] (03PS12) 10Skizzerz: Name implicitly created CHECK constraints [core] - 10https://gerrit.wikimedia.org/r/135714 (https://bugzilla.wikimedia.org/65757) (owner: 10Rillke) [00:11:17] 3MediaWiki extensions / 3OAuth: OAuth: Dialog for granting an app permission should clarify or link to what "basic rights" are - 10https://bugzilla.wikimedia.org/66978 (10Chris Steipp) p:5Unprio>3Normal s:5normal>3minor [00:12:07] (03PS7) 10Krinkle: Introduce mediawiki.api.user module [core] - 10https://gerrit.wikimedia.org/r/131326 (owner: 10Ricordisamoa) [00:12:16] (03PS8) 10Krinkle: Introduce mediawiki.api.user module [core] - 10https://gerrit.wikimedia.org/r/131326 (owner: 10Ricordisamoa) [00:16:42] (03CR) 10Krinkle: [C: 04-1] "I'm not sure we should integrate the two fully. However updateOptions() doesn't belong in mw.Api as it neither returns to the caller nor s" [core] - 10https://gerrit.wikimedia.org/r/131326 (owner: 10Ricordisamoa) [00:19:56] (03PS1) 10EBernhardson: Insert missing title attribute for block links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142469 [00:23:18] (03CR) 10Jdlrobson: [C: 032] Insert missing title attribute for block links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142469 (owner: 10EBernhardson) [00:23:36] (03Merged) 10jenkins-bot: Insert missing title attribute for block links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142469 (owner: 10EBernhardson) [00:25:19] 3MediaWiki / 3ResourceLoader: Embedded SVG files should be optimized in ResourceLoader/CSSMin - 10https://bugzilla.wikimedia.org/63491#c2 (10Ryan Kaldari) What about using SVGO plus a post-processing script to fix the bugs? Right now, a lot of teams are minifying their SVGs locally, which not only makes them... [00:30:31] (03CR) 10JGonera: "Dduvall, this doesn't disable VE, it just doesn't set it as the default editor. In fact, this line could be completely removed since 0 is " [vagrant] - 10https://gerrit.wikimedia.org/r/141860 (owner: 10JGonera) [00:34:31] (03PS1) 10MaxSem: Improve tests [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/142470 [00:35:25] ori, ^ [00:36:14] (03CR) 10Ori.livneh: [C: 032] Improve tests [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/142470 (owner: 10MaxSem) [00:36:17] (03PS2) 10EBernhardson: Dont even provide action links to blocked users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142394 [00:36:21] (03Merged) 10jenkins-bot: Improve tests [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/142470 (owner: 10MaxSem) [00:36:46] (03PS3) 10EBernhardson: Set $wgLogActionsHandlers properly for back-compat strings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/138214 (https://bugzilla.wikimedia.org/66331) (owner: 10Legoktm) [00:42:44] (03PS1) 10Ori.livneh: Make SpecialPreferencesTest::testBug41337 non-risky [core] - 10https://gerrit.wikimedia.org/r/142471 [00:44:02] (03CR) 10Dduvall: "JGonera," [vagrant] - 10https://gerrit.wikimedia.org/r/141860 (owner: 10JGonera) [00:44:35] (03PS4) 10EBernhardson: Set $wgLogActionsHandlers properly for back-compat strings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/138214 (https://bugzilla.wikimedia.org/66331) (owner: 10Legoktm) [00:44:51] (03CR) 10EBernhardson: [C: 032] Set $wgLogActionsHandlers properly for back-compat strings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/138214 (https://bugzilla.wikimedia.org/66331) (owner: 10Legoktm) [00:45:07] (03Merged) 10jenkins-bot: Set $wgLogActionsHandlers properly for back-compat strings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/138214 (https://bugzilla.wikimedia.org/66331) (owner: 10Legoktm) [00:46:41] (03CR) 10jenkins-bot: [V: 04-1] Make SpecialPreferencesTest::testBug41337 non-risky [core] - 10https://gerrit.wikimedia.org/r/142471 (owner: 10Ori.livneh) [00:50:20] (03PS2) 10Ori.livneh: Make SpecialPreferencesTest::testBug41337 non-risky [core] - 10https://gerrit.wikimedia.org/r/142471 [00:54:08] (03CR) 10MaxSem: [C: 032] Make SpecialPreferencesTest::testBug41337 non-risky [core] - 10https://gerrit.wikimedia.org/r/142471 (owner: 10Ori.livneh) [00:57:44] (03CR) 10Awight: "I don't see any caching issues--you're only adding the campaign key, and the form is already split out by campaign appearing in the GET pa" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/141378 (owner: 10AndyRussG) [00:57:50] (03CR) 10Awight: [C: 032] Fix validation bug and replace cookie w/ field [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/141378 (owner: 10AndyRussG) [00:57:53] (03Merged) 10jenkins-bot: Make SpecialPreferencesTest::testBug41337 non-risky [core] - 10https://gerrit.wikimedia.org/r/142471 (owner: 10Ori.livneh) [00:58:02] 3MediaWiki extensions / 3CentralAuth: Always create global account if it doesn't exist - 10https://bugzilla.wikimedia.org/67175#c2 (10Chris Steipp) legoktm brought up that there are some cases where the current behavior protects the owner of the home wiki, who hasn't globalized (for some reason, but could).... [01:00:35] 3MediaWiki extensions / 3Popups: Hovercards: TextExtract has anchor link?! - 10https://bugzilla.wikimedia.org/67180 (10Quiddity) 3NEW p:3Unprio s:3minor a:3None Created attachment 15759 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15759&action=edit screenshot Hovercards targetting this pag... [01:04:21] 3MediaWiki extensions / 3Popups: Hovercards: Blue text appearing in textextract - 10https://bugzilla.wikimedia.org/67181 (10Quiddity) 3NEW p:3Unprio s:3normal a:3None Created attachment 15760 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15760&action=edit screenshot This one article has blu... [01:07:49] (03CR) 10Legoktm: [C: 032] Switched from begin/commit to *Atomic methods [extensions/Echo] - 10https://gerrit.wikimedia.org/r/142020 (owner: 10Aaron Schulz) [01:08:00] (03Merged) 10jenkins-bot: Switched from begin/commit to *Atomic methods [extensions/Echo] - 10https://gerrit.wikimedia.org/r/142020 (owner: 10Aaron Schulz) [01:19:28] (03PS1) 10Skizzerz: (bug 64043) Set the default database schema to "mediawiki" so as not to break the CLI installer. [core] - 10https://gerrit.wikimedia.org/r/142472 [01:21:47] 3MediaWiki extensions / 3Popups: Hovercards: ctrl-clicking a link, will cause Hovercard to reappear, when original tab is next seen - 10https://bugzilla.wikimedia.org/66261#c1 (10Quiddity) Created attachment 15761 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15761&action=edit screenCast Screencast... [01:22:46] 3MediaWiki extensions / 3Popups: Hovercards: Blue text appearing in textextract - 10https://bugzilla.wikimedia.org/67181#c1 (10Quiddity) also at https://en.wikipedia.org/wiki/Special:WhatLinksHere/List_of_The_Price_Is_Right_pricing_games [01:23:17] 3Wikimedia / 3Extension setup: Enable #lsth from Labeled Section Transclusion on pt.wikiversity - 10https://bugzilla.wikimedia.org/61804#c5 (10Al-Scandar Solstag) Aaaand... we've had this hanging for a few months now. Is there anything I can do to help you? Please let me know. Thanks, ale [01:25:24] (03PS3) 10Jackmcbarn: Don't cache volatile wikitext [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/99794 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [01:26:18] 3MediaWiki extensions / 3Popups: Hovercards: Blue text appearing in textextract - 10https://bugzilla.wikimedia.org/67181#c2 (10Prateek Saxena) Unable to replicate this on Chrome 35 and Firefox 29 on MacOS 10.9 [01:27:28] (03PS4) 10Jackmcbarn: Don't cache volatile wikitext [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/99794 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [01:30:20] TimStarling: if you have time, can you review https://gerrit.wikimedia.org/r/#/c/99794/ ? [01:30:33] 3MediaWiki extensions / 3Popups: Hovercards: TextExtract has anchor link?! - 10https://bugzilla.wikimedia.org/67180#c1 (10Quiddity) > (Note: It won't be an issue [...]) Ignore this end-note, I was confusing myself. [01:31:04] right, so setVolatile was merged in the end? [01:31:08] yes [01:32:10] (03CR) 10Catrope: [C: 032] Update OOjs to v1.0.10 [core] - 10https://gerrit.wikimedia.org/r/142465 (owner: 10Jforrester) [01:34:57] I don't think you can just edit pages like that, in a normal test case [01:35:44] (03Merged) 10jenkins-bot: Update OOjs to v1.0.10 [core] - 10https://gerrit.wikimedia.org/r/142465 (owner: 10Jforrester) [01:37:24] the template loader is already hooked, so it's really not necessary [01:38:16] modules and templates are loaded the same way -- we make modules appear to exist by hooking the template loader [01:38:34] so if you want a template to exist as well, you just need to add it to extraModules [01:38:55] that's anomie's code. i'm not sure why he did it like that. can you copy what you wrote into a gerrit comment? [01:39:04] yes [01:42:18] 3MediaWiki extensions / 3Popups: Hovercards: Blue text appearing in textextract - 10https://bugzilla.wikimedia.org/67181#c3 (10Quiddity) Created attachment 15762 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15762&action=edit screenshot I'm also unable to replicate, with a fresh account. It must be... [01:45:02] (03CR) 10Tim Starling: [C: 04-1] Don't cache volatile wikitext (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/99794 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [01:56:26] actually, that does look clear-cut enough that i can fix it [01:58:32] 3MediaWiki extensions / 3Popups: Hovercards: When image is not masked by pin should use main popup height - 10https://bugzilla.wikimedia.org/63162#c7 (10Quiddity) *** Bug 65242 has been marked as a duplicate of this bug. *** [01:58:32] 3MediaWiki extensions / 3Popups: Hovercards: images are cropped - 10https://bugzilla.wikimedia.org/65242#c4 (10Quiddity) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 63162 *** [01:58:48] 3MediaWiki extensions / 3Popups: Hovercards: When image is not masked by pin should use main popup height - 10https://bugzilla.wikimedia.org/63162#c8 (10Quiddity) Merging comments from bug 65242: Attachment 15363 (logo crop) Attachment 15364 (album crop) Attachment 15365 (portrait crop) (Quiddity wrote) >... [02:00:58] (03CR) 10Jaredzimmerman: "Sounds good to me" [core] - 10https://gerrit.wikimedia.org/r/142426 (https://bugzilla.wikimedia.org/61940) (owner: 10Robmoen) [02:02:57] (03Abandoned) 10Ori.livneh: Update hook name [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/141759 (owner: 10Ori.livneh) [02:03:44] (03PS5) 10Jackmcbarn: Don't cache volatile wikitext [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/99794 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [02:04:12] TimStarling: ^ [02:04:30] did you run the test? [02:05:26] TimStarling: yes [02:05:37] it passes, and if i deliberately break what it's trying to test, it fails [02:08:06] (03CR) 10Tim Starling: [C: 032] Don't cache volatile wikitext [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/99794 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [02:10:25] (03Merged) 10jenkins-bot: Don't cache volatile wikitext [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/99794 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [02:11:18] TimStarling: thanks! [02:11:22] (03CR) 10Jforrester: "Ping on this; can I help come up with a solution?" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125543 (owner: 10Jforrester) [02:11:48] 3MediaWiki extensions / 3Scribunto: frame:preprocess with ref tags loses the backlinks - 10https://bugzilla.wikimedia.org/46815 (10Jackmcbarn) 5PATC>3RESO/FIX [02:12:58] (03PS3) 10Jforrester: [WIP] Generic banana linter job template [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/129826 (https://bugzilla.wikimedia.org/64045) [02:25:04] (03CR) 10PleaseStand: [C: 04-1] "If callers were to use the compress.zlib:// stream wrapper instead of gzopen(), this workaround would not be necessary." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/142287 (https://bugzilla.wikimedia.org/66952) (owner: 10Rohan013) [02:27:02] 3MediaWiki extensions / 3Scribunto: HPHP::computeMaskFromNumElms(uint32_t): Assertion `n <= 0x7fffffffU' failed. - 10https://bugzilla.wikimedia.org/66943#c2 (10Tim Starling) Proposed fix at [03:40:08] (03CR) 10Mattflaschen: "Ori:" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/137528 (https://bugzilla.wikimedia.org/65514) (owner: 10Mattflaschen) [03:42:39] 3MediaWiki / 3Special pages: Send 404 status code for special pages without contents - 10https://bugzilla.wikimedia.org/67182 (10Liangent) 3NEW p:3Unprio s:3normal a:3None For example [[Special:RecentChangesLinked/InvalidFooBarTitle]]. It has been observed on zhwiki that some search engine indexed p... [03:42:58] (03CR) 10Ori.livneh: "> If other people object to this, perhaps we should bring it to Wikitech." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/137528 (https://bugzilla.wikimedia.org/65514) (owner: 10Mattflaschen) [03:45:02] 3MediaWiki / 3Documentation: Documentation is out of date, incomplete (tracking) - 10https://bugzilla.wikimedia.org/1 (10Matthew Flaschen) [03:45:04] 3MediaWiki / 3Internationalization: Obsolete references to MessagesEn.php - 10https://bugzilla.wikimedia.org/67183 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None There are obsolete references to MessagesXx.php/MessagesEn.php in includes/DefaultSettings.php, includes/cache/LocalisationCache.php... [03:48:02] 3MediaWiki / 3Internationalization: Obsolete references to MessagesEn.php - 10https://bugzilla.wikimedia.org/67183#c1 (10Matthew Flaschen) Some of these may not be obsolete, since MessagesEn.php is still used for other purposes, but e.g. https://git.wikimedia.org/blob/mediawiki%2Fcore.git/134f34e04f5ca339a57... [03:56:30] (03CR) 10Mattflaschen: ""Another thing: was there plan what to do with existing sidebar message customizations, as with this patch those would not be loaded becau" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/137528 (https://bugzilla.wikimedia.org/65514) (owner: 10Mattflaschen) [03:56:32] 3MediaWiki / 3Parser: Parser inserts invalid   in the middle of style attribute - 10https://bugzilla.wikimedia.org/3158#c8 (10Jackmcbarn) It looks like CSS is just what makes this bug visible, rather than anything to do with its cause. At includes/parser/Parser.php:410-419: # Clean up special c... [03:57:03] 3MediaWiki / 3Parser: Parser inserts invalid   in the middle of style attribute - 10https://bugzilla.wikimedia.org/3158 (10Jackmcbarn) [03:57:03] 3MediaWiki / 3Parser: Enforced   breaks inline CSS with !important - 10https://bugzilla.wikimedia.org/11874 (10Jackmcbarn) [03:57:22] (03PS1) 10Prtksxna: Add `lang` and `dir` attributes to `.mwe-popups-extract` [extensions/Popups] - 10https://gerrit.wikimedia.org/r/142481 (https://bugzilla.wikimedia.org/66114) [03:59:16] (03PS1) 10Santhosh: Use updated jscs and wikimedia preset [services/cxserver] - 10https://gerrit.wikimedia.org/r/142482 [03:59:47] (03CR) 10jenkins-bot: [V: 04-1] Use updated jscs and wikimedia preset [services/cxserver] - 10https://gerrit.wikimedia.org/r/142482 (owner: 10Santhosh) [04:08:37] (03PS2) 10Santhosh: Use updated jscs and wikimedia preset [services/cxserver] - 10https://gerrit.wikimedia.org/r/142482 [05:38:41] (03CR) 10Divec: [C: 032] Remove old segmentation code, move the segmenters files [services/cxserver] - 10https://gerrit.wikimedia.org/r/140664 (owner: 10Santhosh) [05:39:16] (03Merged) 10jenkins-bot: Remove old segmentation code, move the segmenters files [services/cxserver] - 10https://gerrit.wikimedia.org/r/140664 (owner: 10Santhosh) [05:46:03] 3MediaWiki extensions / 3CentralNotice: Collapsible arrows on Special:CentralNoticeLogs point to the wrong direction with RTL interface language - 10https://bugzilla.wikimedia.org/36795 (10Amir E. Aharoni) 5PATC>3RESO/FIX [06:20:52] (03PS1) 10Wctaiwan: Add ability to import pages when creating lists [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142488 [06:21:19] 3MediaWiki extensions / 3Scribunto: HHVM: Assertion in Scribunto_LuaEngine::callPa rserFunction() during uksort() call - 10https://bugzilla.wikimedia.org/66943#c3 (10Tim Starling) There is still an assertion from computeMaskFromNumElms() while running Scribunto tests, but it's probably a different bug. Let's... [06:24:36] 3MediaWiki / 3Search: Search results number are outside the grey background - 10https://bugzilla.wikimedia.org/67184 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Created attachment 15763 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15763&action=edit Number of results on mediawiki.org Or tab "... [06:25:18] (03CR) 10Prtksxna: Add ability to import pages when creating lists (031 comment) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142488 (owner: 10Wctaiwan) [06:26:47] (03PS2) 10Wctaiwan: Add ability to import pages when creating lists [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142488 [06:29:15] (03CR) 10Prtksxna: Add ability to import pages when creating lists (032 comments) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142488 (owner: 10Wctaiwan) [06:34:10] (03CR) 10Legoktm: [C: 04-1] Add ability to import pages when creating lists (031 comment) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142488 (owner: 10Wctaiwan) [06:50:04] What. [06:51:37] ? [06:51:46] I don't really understand that change. [06:52:01] which one? [06:52:04] 3MediaWiki extensions / 3GoogleLogin: Use MWException, catch Google_Service_Exception - 10https://bugzilla.wikimedia.org/67185 (10Florian) 3NEW p:3Unprio s:3normal a:3None Instead of using Google_Service_Exception as raw text, catch this and use MWException instead. [06:52:06] https://gerrit.wikimedia.org/r/142488 [06:52:16] I didn't realize there were new Special pages... [06:52:25] > includes/SpecialCreateMassMessageList.php [06:52:27] Who knew. [06:52:30] it's in a branch [06:52:34] 3MediaWiki extensions / 3GoogleLogin: Use MWException, catch Google_Service_Exception - 10https://bugzilla.wikimedia.org/67185 (10Florian) 5NEW>3ASSI p:5Unprio>3High s:5normal>3enhanc a:3Florian [06:52:37] Ohhh. [06:52:49] Ah, this is the GSoC work. [06:52:53] Okay, that makes more sense. [06:53:15] How's that coming along? [06:53:33] pretty well [06:54:06] Good. [06:59:19] 3MediaWiki extensions / 3GoogleLogin: Don't use createOrMerge() if nothing to do - 10https://bugzilla.wikimedia.org/67186 (10Florian) 3NEW p:3Unprio s:3normal a:3None When the user is logged in and has linked his Googleaccount already to the account, don't run createOrMerge() after request /Special:G... [06:59:33] 3MediaWiki extensions / 3GoogleLogin: Don't use createOrMerge() if nothing to do - 10https://bugzilla.wikimedia.org/67186 (10Florian) p:5Unprio>3High s:5normal>3major [07:03:19] 3MediaWiki extensions / 3Scribunto: HHVM: assertion in Scribunto_LuaLanguageLibrary::convertPlural() - 10https://bugzilla.wikimedia.org/67187 (10Tim Starling) 3NEW p:3Unprio s:3normal a:3None Reproducible with: hhvm tests/phpunit/phpunit.php --filter '#29' ../extensions/Scribunto/tests/engines/LuaCo... [07:05:52] (03PS1) 10Raimond Spekking: Consistency tweaks/i18n review [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142490 [07:08:29] (03CR) 10Mattflaschen: [C: 031] "Looks good. I will probably merge this today after giving people a little longer to review." [core] - 10https://gerrit.wikimedia.org/r/142450 (https://bugzilla.wikimedia.org/60563) (owner: 10Krinkle) [07:08:51] (03PS1) 10Florianschmidtwelzow: Redirect to SpecialPage if nothing to do [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142492 (https://bugzilla.wikimedia.org/67186) [07:10:12] (03PS2) 10Florianschmidtwelzow: Redirect to SpecialPage if nothing to do [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142492 (https://bugzilla.wikimedia.org/67186) [07:22:24] (03PS3) 10Wctaiwan: Combine target fetching; add importing on creation [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142488 [07:22:31] (03CR) 10jenkins-bot: [V: 04-1] Combine target fetching; add importing on creation [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142488 (owner: 10Wctaiwan) [07:22:47] 3Wikimedia / 3Site requests: Please add the domain *.ihs.nl to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/67120#c4 (10Tomasz W. Kozlowski) 5PATC>3RESO/FIX This has now been merged and deployed by Ori (thank you!). [07:24:08] (03PS4) 10Wctaiwan: Combine target fetching; add importing on creation [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142488 [07:24:17] (03CR) 10jenkins-bot: [V: 04-1] Combine target fetching; add importing on creation [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142488 (owner: 10Wctaiwan) [07:24:32] 3Wikimedia / 3General/Unknown: Restore action=credits on WMF wikis - 10https://bugzilla.wikimedia.org/47721 (10Nemo) [07:24:32] 3MediaWiki / 3General/Unknown: Include action=credits output into action=info as well - 10https://bugzilla.wikimedia.org/39533#c9 (10Nemo) s:5normal>3enhanc action=credits will not be removed. I'm not sure this change will ever be possible, considering that even standalone action=credits is considered to... [07:27:33] 3Analytics / 3Wikimetrics: test_add_new_tag_utf8 fails - 10https://bugzilla.wikimedia.org/67166#c1 (10nuria) What might be happening is that you need to rebuild your database. Try: mysql> drop wikimetrics_testing; drop wikimetrics and outside vagrant just run > vagrant provision That should start the... [07:28:46] (03PS5) 10Wctaiwan: Combine target fetching; add importing on creation [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142488 [07:28:48] (03CR) 10jenkins-bot: [V: 04-1] Combine target fetching; add importing on creation [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142488 (owner: 10Wctaiwan) [07:29:02] 3MediaWiki extensions / 3Extensions requests: Customizable summary of page editors/authors - 10https://bugzilla.wikimedia.org/27629 (10Nemo) [07:29:02] 3MediaWiki extensions / 3Collection: Collection extension needs some way to credit original authors of a work - 10https://bugzilla.wikimedia.org/28064#c6 (10Nemo) I don't think it's realistic for this to wait on bug 27629. [07:29:02] 3Wikimedia / 3General/Unknown: Restore action=credits on WMF wikis - 10https://bugzilla.wikimedia.org/47721 (10Nemo) [07:29:58] (03PS6) 10Wctaiwan: Combine target fetching; add importing on creation [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142488 [07:30:45] (03PS1) 10Florianschmidtwelzow: Add basic tests [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142493 [07:34:47] 3MediaWiki / 3General/Unknown: Include action=credits output into action=info as well - 10https://bugzilla.wikimedia.org/39533#c10 (10Nemo) I daresay this depends on bug 27629 as well: exposing imperfect authorship metadata in the UI can lead to drama and even legal confusion for reusers, so we'd first need... [07:34:47] 3MediaWiki extensions / 3Extensions requests: Customizable summary of page editors/authors - 10https://bugzilla.wikimedia.org/27629 (10Nemo) [07:35:30] (03PS2) 10Florianschmidtwelzow: Add basic tests [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142493 [07:36:33] (03CR) 10Florianschmidtwelzow: [C: 032 V: 032] Add basic tests [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142493 (owner: 10Florianschmidtwelzow) [07:36:59] (03CR) 10Florianschmidtwelzow: [C: 032 V: 032] Redirect to SpecialPage if nothing to do [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142492 (https://bugzilla.wikimedia.org/67186) (owner: 10Florianschmidtwelzow) [07:42:49] (03PS7) 10Wctaiwan: Combine target fetching; add importing on creation [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142488 [07:43:02] 3MediaWiki / 3History/Diffs: Automatically generated count and list of contributors to an article (authorship tracking) - 10https://bugzilla.wikimedia.org/2994#c14 (10Nemo) (In reply to Rob Church from comment #7) > A straight count of all revisions in an article's history wouldn't be too > bad. > Grouping b... [07:48:53] Does anybody know the state of the wikimedia phpStorm license? [07:49:17] FoxT: Reedy would know [07:49:27] (03PS1) 10Florianschmidtwelzow: Resolved tests errors and warnings [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142495 [07:49:52] YuviPanda: I'd expect so. Only he did not answer my mail, so I thought I'd ask here [07:50:02] 3MediaWiki extensions / 3GoogleLogin: Don't use createOrMerge() if nothing to do - 10https://bugzilla.wikimedia.org/67186 (10Florian) 5PATC>3RESO/FIX [07:50:44] (03CR) 10Florianschmidtwelzow: [C: 032 V: 032] Resolved tests errors and warnings [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142495 (owner: 10Florianschmidtwelzow) [07:51:29] FoxT: ah, hmm. I think he got it renewed [07:52:34] YuviPanda: Would be great Guess I'll nag him some more. :) [07:52:40] FoxT: :) [07:54:55] (03PS2) 10Florianschmidtwelzow: Consistency tweaks/i18n review [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142490 (owner: 10Raimond Spekking) [07:55:24] FoxT: pm [07:56:17] legoktm: Thx! [07:56:26] np [08:08:34] (03PS8) 10Wctaiwan: Combine target fetching; add importing on creation [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142488 [08:09:28] (03CR) 10Legoktm: [C: 032] Combine target fetching; add importing on creation [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142488 (owner: 10Wctaiwan) [08:09:37] (03Merged) 10jenkins-bot: Combine target fetching; add importing on creation [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142488 (owner: 10Wctaiwan) [08:18:46] hi YuviPanda [08:18:53] hi aharoni [08:18:53] what's left to fix in https://gerrit.wikimedia.org/r/#/c/142236/ ? [08:19:08] aharoni: got distracted. need to mark that as html and do some padding adjustments. I'll get it done today? [08:19:15] aharoni: still distracted by some labs stuff. [08:19:47] (03CR) 10Pginer: mw-ui-button: Revamp the LESS to be simpler, and improve cross-browser support (031 comment) [core] - 10https://gerrit.wikimedia.org/r/123804 (owner: 10SG) [08:22:47] (03PS3) 10Florianschmidtwelzow: Consistency tweaks/i18n review [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142490 (owner: 10Raimond Spekking) [08:22:59] YuviPanda: not urgent, thanks [08:23:06] aharoni: :) [08:23:26] aharoni: see PM? [08:24:13] (03CR) 10Florianschmidtwelzow: "Thanks Raimond! Have added qqq.json (forgot :/ before, sry), can you review the explanation before i merge it? Big thanks!" [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142490 (owner: 10Raimond Spekking) [08:26:27] (03PS1) 10Wctaiwan: Make site handling more consistent [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142498 [08:29:02] 3MediaWiki extensions / 3CirrusSearch: intitle search doesn't work - 10https://bugzilla.wikimedia.org/66969#c2 (10bennylin) I suspect it is some kind of language-based stop words, in this case Indonesian language, because of three reasons: 1. other Indonesian stop words also didn't show up ("intitle:di" - i... [08:29:56] (03CR) 10Legoktm: [C: 032] Make site handling more consistent [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142498 (owner: 10Wctaiwan) [08:30:03] (03Merged) 10jenkins-bot: Make site handling more consistent [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142498 (owner: 10Wctaiwan) [08:33:17] 3MediaWiki extensions / 3CirrusSearch: intitle search doesn't work - 10https://bugzilla.wikimedia.org/66969#c3 (10bennylin) Further investigation: Searching "intitle:di" in Italian Wikipedia also failed https://it.wikipedia.org/w/index.php?title=Speciale%3ARicerca&profile=advanced&search=intitle%3Adi&fullte... [08:38:31] 3MediaWiki extensions / 3WikidataRepo: CSS class name changed to "valueview-valueview" - 10https://bugzilla.wikimedia.org/66883 (10Thiemo Mättig) [08:42:47] 3MediaWiki extensions / 3CirrusSearch: intitle search doesn't work - 10https://bugzilla.wikimedia.org/66969#c4 (10bennylin) Further investigation: searching in similar projects id.wp and ms.wp are similar, while it.wp and scn.wp and en.wp and simple.wp are also compared: "intitle:dari" 1 id.wp - failed 2 i... [08:54:08] (03CR) 10Liangent: [C: 031] "Just got an idea that this can also be:" [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/140626 (https://bugzilla.wikimedia.org/66621) (owner: 10MaxSem) [08:57:04] 3MediaWiki extensions / 3Translate: translation of the Android app to Serbian is broken - 10https://bugzilla.wikimedia.org/67189 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None It seems to be not quite possible to translate the Wikipedia Android app to Serbian, at least not in a straightforward... [09:00:02] 3MediaWiki extensions / 3Translate: translation of the Android app to Serbian is broken - 10https://bugzilla.wikimedia.org/67189#c1 (10Amir E. Aharoni) A side though: I don't know whether Android supports script variants for Serbian. I see only Cyrillic on my devices, but some other devices may support Latin... [09:02:02] 3MediaWiki extensions / 3Translate: translation of the Android app to Serbian is broken - 10https://bugzilla.wikimedia.org/67189#c2 (10Siebrand Mazeland) Can be resolved by adding a code map in the yaml configuration. Android only supports two letter codes. [09:04:32] 3MediaWiki extensions / 3WikidataRepo: Make internal storage format configurable - 10https://bugzilla.wikimedia.org/66784 (10Lydia Pintscher) [09:05:17] 3MediaWiki extensions / 3WikidataRepo: Do not omit empty fields from JSON - 10https://bugzilla.wikimedia.org/66791 (10Lydia Pintscher) [09:11:16] (03CR) 10Liangent: "@Jforrester: I don't have +2..." [core] - 10https://gerrit.wikimedia.org/r/138368 (https://bugzilla.wikimedia.org/43406) (owner: 10Bartosz Dziewoński) [09:11:47] 3MediaWiki extensions / 3WikidataRepo: Extend ChangeNotifier to cover functionality currently implemented in static hook functions - 10https://bugzilla.wikimedia.org/66831 (10Lydia Pintscher) 5PATC>3RESO/FIX [09:12:17] 3MediaWiki extensions / 3Translate: translation of the Android app to Serbian is broken - 10https://bugzilla.wikimedia.org/67189 (10Nemo) [09:12:17] 3MediaWiki extensions / 3Translate: It's sometimes possible to save translations in a blacklisted language - 10https://bugzilla.wikimedia.org/49898 (10Nemo) [09:12:17] 3MediaWiki extensions / 3Translate: [TUX] Blacklisted languages can still be translated - 10https://bugzilla.wikimedia.org/54627#c4 (10Nemo) aharoni> Nikerabbit: if there's one reported already, can you make it a blocker of https://bugzilla.wikimedia.org/show_bug.cgi?id=67189 ? (Bug 49898 is different in th... [09:13:47] 3MediaWiki extensions / 3Translate: translation of the Android app to Serbian is broken - 10https://bugzilla.wikimedia.org/67189#c3 (10Nemo) (In reply to Siebrand Mazeland from comment #2) > Can be resolved by adding a code map in the yaml configuration. Android only > supports two letter codes. Yep; we don... [09:15:02] 3MediaWiki extensions / 3WikidataRepo: Fatal error: Call to undefined method Wikibase\Api\EditEntity::setTitle() in Wikibase\EditEntity - 10https://bugzilla.wikimedia.org/66842 (10Lydia Pintscher) [09:16:47] 3MediaWiki extensions / 3Translate: Problems with saving translations to Hunsrückisch - 10https://bugzilla.wikimedia.org/62584#c7 (10Nemo) 5UNCO>3RESO/WOR Closing this report because there are already bugs for many of its aspects. [09:17:47] 3MediaWiki extensions / 3Translate: [TUX] Confusing behavior trying to translate a translatable in a not whitelisted language - 10https://bugzilla.wikimedia.org/47988#c1 (10Nemo) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 48804 *** [09:17:47] 3MediaWiki extensions / 3Translate: [TUX] Editor does not handle restricted languages properly - 10https://bugzilla.wikimedia.org/48804#c2 (10Nemo) *** Bug 47988 has been marked as a duplicate of this bug. *** [09:18:32] 3MediaWiki extensions / 3Translate: translation of the Android app to Serbian is broken - 10https://bugzilla.wikimedia.org/67189 (10Nemo) [09:18:33] 3MediaWiki extensions / 3Translate: [TUX] Editor does not handle restricted languages properly - 10https://bugzilla.wikimedia.org/48804 (10Nemo) [09:18:33] 3MediaWiki extensions / 3Translate: Saving a translation that hits the URL blacklist is marked as saved - 10https://bugzilla.wikimedia.org/59715 (10Nemo) [09:18:33] 3MediaWiki extensions / 3Translate: When saving failed user has no way to retry and even if many failed YOU ARE NOT NOTIFIED - 10https://bugzilla.wikimedia.org/48773 (10Nemo) [09:22:44] (03PS1) 10Swidmann: Initial commit of AdvancedMeta version 3.0.1 removed all $_POST, removed preg replace for extending the editform, removed a few globals [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/142502 [09:58:59] (03PS2) 10Foxtrott: Fix "CSSMin url() value remapping not working in certain obscure cases" [core] - 10https://gerrit.wikimedia.org/r/139268 (https://bugzilla.wikimedia.org/60077) [10:22:25] (03CR) 10Krinkle: [C: 04-1] "I considered it as one of two options before, but I've come to the conclusion that setting these up as standalone jobs is the option I'd l" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/129826 (https://bugzilla.wikimedia.org/64045) (owner: 10Jforrester) [10:24:00] (03PS8) 10Krinkle: Stop using a suboptimal structure for Vector's variants menu (cont.) [core] - 10https://gerrit.wikimedia.org/r/138369 (https://bugzilla.wikimedia.org/43406) (owner: 10Bartosz Dziewoński) [10:24:57] (03PS9) 10Krinkle: [DONT MERGE] Vector: Remove compatibility for old variant menu html [core] - 10https://gerrit.wikimedia.org/r/138369 (owner: 10Bartosz Dziewoński) [10:25:39] (03CR) 10Krinkle: "Gave commit message a more distinctive subject. This and the previous change are quite different in their actual intend. They have a relat" [core] - 10https://gerrit.wikimedia.org/r/138369 (owner: 10Bartosz Dziewoński) [10:26:10] (03CR) 10Krinkle: [C: 04-2] "Don't merge until 30 days after the change this follows-up to." [core] - 10https://gerrit.wikimedia.org/r/138369 (owner: 10Bartosz Dziewoński) [10:31:01] (03PS10) 10Krinkle: mediawiki.ui: Update color palette [core] - 10https://gerrit.wikimedia.org/r/117105 (owner: 10Kaldari) [10:32:18] (03PS6) 10Krinkle: mediawiki.ui: Introduce grid system [core] - 10https://gerrit.wikimedia.org/r/125387 (owner: 10Pginer) [10:32:29] (03PS3) 10Krinkle: Test patch: Example to illustrate the Grid system (WIP) [core] - 10https://gerrit.wikimedia.org/r/133683 (owner: 10Pginer) [10:34:27] (03CR) 10Krinkle: [C: 04-1] Move user navigation from various special pages to one User method (031 comment) [core] - 10https://gerrit.wikimedia.org/r/137581 (https://bugzilla.wikimedia.org/27707) (owner: 10devunt) [10:35:30] (03CR) 10Krinkle: "This commit has two parents and is the result of an accidental failed merge. Please rebase as a regular commit based on the git master." [core] - 10https://gerrit.wikimedia.org/r/139686 (owner: 10Paladox) [10:35:50] (03CR) 10Divec: [C: 032] Use updated jscs and wikimedia preset [services/cxserver] - 10https://gerrit.wikimedia.org/r/142482 (owner: 10Santhosh) [10:36:30] (03Merged) 10jenkins-bot: Use updated jscs and wikimedia preset [services/cxserver] - 10https://gerrit.wikimedia.org/r/142482 (owner: 10Santhosh) [10:37:10] (03CR) 10Krinkle: [C: 04-1] Fix "CSSMin url() value remapping not working in certain obscure cases" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/139268 (https://bugzilla.wikimedia.org/60077) (owner: 10Foxtrott) [10:37:55] (03CR) 10devunt: Move user navigation from various special pages to one User method (031 comment) [core] - 10https://gerrit.wikimedia.org/r/137581 (https://bugzilla.wikimedia.org/27707) (owner: 10devunt) [10:38:14] (03CR) 10Krinkle: "Nice. Thanks for the proactive cascading. I hadn't announced this yet, but it's great to see it's working well :)" [services/cxserver] - 10https://gerrit.wikimedia.org/r/142482 (owner: 10Santhosh) [10:40:14] (03CR) 10Krinkle: Move user navigation from various special pages to one User method (031 comment) [core] - 10https://gerrit.wikimedia.org/r/137581 (https://bugzilla.wikimedia.org/27707) (owner: 10devunt) [10:41:22] (03CR) 10Krinkle: [C: 031] "Code looks good. Untested." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [10:41:50] (03PS4) 10Krinkle: jquery.textSelection: Remove references to iframe [core] - 10https://gerrit.wikimedia.org/r/139690 (https://bugzilla.wikimedia.org/29328) (owner: 10TheDJ) [10:43:03] (03PS4) 10Krinkle: OutputPage: Do not sort style modules alphabetically [core] - 10https://gerrit.wikimedia.org/r/133843 (https://bugzilla.wikimedia.org/45229) (owner: 10Daniel Friesen) [10:43:09] (03CR) 10devunt: Move user navigation from various special pages to one User method (031 comment) [core] - 10https://gerrit.wikimedia.org/r/137581 (https://bugzilla.wikimedia.org/27707) (owner: 10devunt) [10:43:57] (03CR) 10Krinkle: "Specified OutputPage since we very much do want to order modules alphabetically everywhere else (this is the one place where there is no d" [core] - 10https://gerrit.wikimedia.org/r/133843 (https://bugzilla.wikimedia.org/45229) (owner: 10Daniel Friesen) [10:44:19] (03CR) 10jenkins-bot: [V: 04-1] OutputPage: Do not sort style modules alphabetically [core] - 10https://gerrit.wikimedia.org/r/133843 (https://bugzilla.wikimedia.org/45229) (owner: 10Daniel Friesen) [10:48:32] 3MediaWiki extensions / 3ContentTranslation: non-ASCII article titles are jumbled when inserted as links in Special:CX - 10https://bugzilla.wikimedia.org/66954#c1 (10Amir E. Aharoni) 5ASSI>3RESO/FIX Appears to be fixed in https://gerrit.wikimedia.org/r/#/c/141384/ . [10:48:48] 3MediaWiki extensions / 3ContentTranslation: ContentTranslation added links must be internal and not external - 10https://bugzilla.wikimedia.org/66742#c1 (10Amir E. Aharoni) 5NEW>3RESO/FIX a:3Santhosh Thottingal Appears to be fixed in https://gerrit.wikimedia.org/r/#/c/141384/ . [10:49:03] 3MediaWiki extensions / 3ContentTranslation: non-ASCII article titles are jumbled when inserted as links in Special:CX - 10https://bugzilla.wikimedia.org/66954 (10Amir E. Aharoni) a:5Kartik Mistry>3Santhosh Thottingal [10:50:22] (03CR) 10Krinkle: Move user navigation from various special pages to one User method (031 comment) [core] - 10https://gerrit.wikimedia.org/r/137581 (https://bugzilla.wikimedia.org/27707) (owner: 10devunt) [10:57:26] (03CR) 10devunt: Move user navigation from various special pages to one User method (031 comment) [core] - 10https://gerrit.wikimedia.org/r/137581 (https://bugzilla.wikimedia.org/27707) (owner: 10devunt) [11:02:02] 3MediaWiki / 3Parser: GENDER (tracking) - 10https://bugzilla.wikimedia.org/30443 (10Amir E. Aharoni) [11:02:32] 3MediaWiki / 3Parser: GENDER (tracking) - 10https://bugzilla.wikimedia.org/30443 (10Amir E. Aharoni) [11:03:01] 3MediaWiki / 3Email: editmyprivateinfo blocks confiirming email - 10https://bugzilla.wikimedia.org/67145#c13 (10Mark A. Hershberger) (In reply to Kunal Mehta (Legoktm) from comment #11) > So, do we just need better documentation here? If this is the design, then, yes, the documentation should say something... [11:16:29] (03PS11) 10Prtksxna: Add settings [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140086 [11:23:47] (03PS1) 10Amire80: Rephrase the message flow-topic-participants-second-try [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142507 [11:27:02] (03PS3) 10Foxtrott: Fix "CSSMin url() value remapping not working in certain obscure cases" [core] - 10https://gerrit.wikimedia.org/r/139268 (https://bugzilla.wikimedia.org/60077) [11:27:36] (03PS4) 10Foxtrott: Fix "CSSMin url() value remapping not working in certain obscure cases" [core] - 10https://gerrit.wikimedia.org/r/139268 (https://bugzilla.wikimedia.org/60077) [11:31:55] (03PS4) 10Raimond Spekking: Consistency tweaks/i18n review [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142490 [11:32:38] (03CR) 10Raimond Spekking: "@Florian: Amending war perfect. Thanks!" [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142490 (owner: 10Raimond Spekking) [11:35:04] 3MediaWiki / 3Internationalization: Update case mappings and normalization to Unicode 6.0.0 - 10https://bugzilla.wikimedia.org/67193 (10Derk-Jan Hartman) 3NEW p:3Unprio s:3normal a:3None Unicode 7 is out: http://arstechnica.com/gadgets/2014/06/unicode-7-0-introduces-2834-new-characters-including-250-... [11:35:18] 3MediaWiki / 3Internationalization: Update case mappings and normalization to Unicode 7.0.0 - 10https://bugzilla.wikimedia.org/67193 (10Derk-Jan Hartman) [11:48:02] (03CR) 10Florianschmidtwelzow: [C: 032 V: 032] Consistency tweaks/i18n review [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142490 (owner: 10Raimond Spekking) [11:51:22] superm401: " increases the mtime/version of modules (at least in debug mode), which in turn breaks breakpoints (since the filename changes) " doesn't make sense [11:51:30] in debug mode the actual files are served directly right now [11:51:40] your browser cache is the only factor [11:51:51] and whatever cache expiration your file system / web server is doing [11:52:11] no timestamps or url changes that affect anything [12:47:44] (03PS1) 10Hashar: Puppet jobs for operations/puppet/cdh [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/142515 [12:48:26] (03PS2) 10Hashar: Puppet jobs for operations/puppet/cdh [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/142515 [12:48:47] (03PS1) 10Hashar: Triggers for operations/puppet/cdh [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/142516 [12:52:18] (03CR) 10Hashar: [C: 032] Triggers for operations/puppet/cdh [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/142516 (owner: 10Hashar) [12:52:23] (03Merged) 10jenkins-bot: Triggers for operations/puppet/cdh [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/142516 (owner: 10Hashar) [12:52:26] (03CR) 10Hashar: [C: 032] Puppet jobs for operations/puppet/cdh [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/142515 (owner: 10Hashar) [12:52:55] (03Merged) 10jenkins-bot: Puppet jobs for operations/puppet/cdh [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/142515 (owner: 10Hashar) [12:53:47] (03PS3) 10Umherirrender: Add SpecialPagesWithProp::prefixSearchSubpages [core] - 10https://gerrit.wikimedia.org/r/139455 [12:54:39] (03PS1) 10Jack Phoenix: Integrated the essential bits and pieces of wikiHow's Notifications extension. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/142518 [12:55:32] (03CR) 10Jack Phoenix: [C: 032 V: 032] Integrated the essential bits and pieces of wikiHow's Notifications extension. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/142518 (owner: 10Jack Phoenix) [12:58:23] (03PS1) 10Jack Phoenix: i18n fixes for the bluesky-site-footer message. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/142520 [12:58:43] (03CR) 10Jack Phoenix: [C: 032 V: 032] i18n fixes for the bluesky-site-footer message. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/142520 (owner: 10Jack Phoenix) [12:58:45] (03PS4) 10Umherirrender: Add SpecialPagesWithProp::prefixSearchSubpages [core] - 10https://gerrit.wikimedia.org/r/139455 [12:59:31] (03CR) 10Umherirrender: "Patch Set 4: Now using prefixSearchArray()" [core] - 10https://gerrit.wikimedia.org/r/139455 (owner: 10Umherirrender) [13:22:47] 3MediaWiki / 3Search: Search results number are outside the grey background - 10https://bugzilla.wikimedia.org/67184#c1 (10Chad H.) Moved it on purpose :) [13:23:14] (03CR) 10Rohan013: "Well, that's another of many ways this could be fixed." [core] - 10https://gerrit.wikimedia.org/r/142287 (https://bugzilla.wikimedia.org/66952) (owner: 10Rohan013) [13:24:05] yes, finally i have my LQT message back in personal tools on mediawiki.org [13:35:18] 3Wikimedia / 3Git/Gerrit: Gerrit SSH: Intermittent key_verify failed for server_host_key and 'hash mismatch' - 10https://bugzilla.wikimedia.org/53895#c22 (10Krinkle) The google group topic mentioned this issue in Apache mina-sshd (upstream from Gerrit): https://issues.apache.org/jira/browse/SSHD-330 Which... [13:43:05] 3MediaWiki extensions / 3WikidataClient: Time formatting incorrect for Hebrew - 10https://bugzilla.wikimedia.org/67194 (10Eran Roz) 3NEW p:3Unprio s:3normal a:3Wikidata bugs In some languages, such as Hebrew it isn't correct to write "27 June" but instead "27th of June" [in Hebrew: 27 יוני - wrong... [13:48:03] 3MediaWiki / 3Search: Search results number overlap the border of the grey background - 10https://bugzilla.wikimedia.org/67184#c2 (10Nemo) (In reply to Chad H. from comment #1) > Moved it on purpose :) Check the screenshot, that's not what I remember was your purpose. :) Not sure how to make it responsive. [13:50:02] 3MediaWiki / 3Search: Search results number overlap the border of the grey background - 10https://bugzilla.wikimedia.org/67184#c3 (10Nik Everett) Yeah, that's not pretty! [13:53:35] 3MediaWiki extensions / 3VectorBeta: CPB: Accessibility review - 10https://bugzilla.wikimedia.org/67195 (10Derk-Jan Hartman) 3NEW p:3Unprio s:3normal a:3None Relevant background: http://www.w3.org/WAI/GL/wiki/Using_ARIA_menus http://stackoverflow.com/questions/12279113/recommended-wai-aria-implementa... [13:54:21] (03CR) 10Manybubbles: [C: 032] "Sounds good." [ruby/api] - 10https://gerrit.wikimedia.org/r/137451 (owner: 10Vikassy) [13:54:23] (03Merged) 10jenkins-bot: Added API support for uploading images [ruby/api] - 10https://gerrit.wikimedia.org/r/137451 (owner: 10Vikassy) [13:55:17] 3MediaWiki extensions / 3VectorBeta: CPB: Accessibility for keyboard users and screen readers - 10https://bugzilla.wikimedia.org/67195 (10Derk-Jan Hartman) [13:55:32] 3MediaWiki / 3Skin and page rendering: Markup accessibility issues (tracking) - 10https://bugzilla.wikimedia.org/367 (10Derk-Jan Hartman) [13:57:20] 3MediaWiki / 3Parser: PAGESINCATEGORY should decode HTML entities of input - 10https://bugzilla.wikimedia.org/67196 (10Jesús Martínez Novo (Ciencia Al Poder)) 3NEW p:3Unprio s:3normal a:3None From the linked URL: ---- {{PAGESINCATEGORY:{{PAGENAME}}}} doesn't work if {{PAGENAME}} contains ' (it will... [13:59:47] 3MediaWiki / 3Search: Search results number overlap the border of the grey background - 10https://bugzilla.wikimedia.org/67184#c4 (10Chad H.) Eww, ugly. [14:00:56] (03CR) 10Anomie: [C: 032] Add parser test for "extra interlanguage links". [core] - 10https://gerrit.wikimedia.org/r/142431 (https://bugzilla.wikimedia.org/32189) (owner: 10Cscott) [14:04:17] 3MediaWiki extensions / 3Translate: [TUX] Editor does not handle restricted languages properly - 10https://bugzilla.wikimedia.org/48804#c3 (10Nikola Smolenski) Actually, to me, translating anything in Serbian doesn't really work. I use Serbian interface. Going to https://translatewiki.net/wiki/Translating:Me... [14:04:29] (03Merged) 10jenkins-bot: Add parser test for "extra interlanguage links". [core] - 10https://gerrit.wikimedia.org/r/142431 (https://bugzilla.wikimedia.org/32189) (owner: 10Cscott) [14:07:02] 3MediaWiki / 3General/Unknown: #switch or #ifeq: checks should be HTML escaped - 10https://bugzilla.wikimedia.org/35628#c10 (10Jesús Martínez Novo (Ciencia Al Poder)) 5PATC>3RESO/FIX How convenient :) Someone just reported this issue with PAGESINCATEGORY (now filed as bug 67196) The problem is really {{... [14:07:03] 3MediaWiki / 3Parser: PAGESINCATEGORY should decode HTML entities of input - 10https://bugzilla.wikimedia.org/67196 (10Jesús Martínez Novo (Ciencia Al Poder)) [14:08:02] 3MediaWiki extensions / 3Translate: [TUX] Editor does not handle restricted languages properly - 10https://bugzilla.wikimedia.org/48804#c4 (10Nemo) (In reply to Nikola Smolenski from comment #3) > If I try > typing in the language name, as soon as I type "srp" or "срп" I get only > Srpskohrvatski (Serbocroat... [14:11:08] (03PS1) 10Matthias Mullie: Fix (hist) text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142524 [14:12:02] 3MediaWiki / 3Parser: PAGESINCATEGORY should decode HTML entities of input - 10https://bugzilla.wikimedia.org/67196 (10Jesús Martínez Novo (Ciencia Al Poder)) [14:12:03] 3MediaWiki / 3Templates: {{PAGENAME}} must not escape special chars, otherwise it makes {{#ifeq:}} unusable - 10https://bugzilla.wikimedia.org/35746 (10Jesús Martínez Novo (Ciencia Al Poder)) [14:13:01] (03CR) 10Anomie: "I won't -1 over it (a followup patch would be ok with me), but you should add an API action for setting the page language." [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [14:13:18] (03CR) 10Anomie: [C: 032] "Ok, I see no calls in core or any extensions in Gerrit." [core] - 10https://gerrit.wikimedia.org/r/142031 (owner: 10Umherirrender) [14:15:50] PS63, so many emails I got about that changeset ^^ [14:16:17] That's why it was submitted as first thing in the project [14:16:52] (03Merged) 10jenkins-bot: Remove ApiBase::createContext() (deprecated since 1.19) [core] - 10https://gerrit.wikimedia.org/r/142031 (owner: 10Umherirrender) [14:24:49] PS63? [14:24:51] man. [14:25:10] Is that all? :P [14:25:45] marktraceur: didn't the campaigns rewrite take as much? [14:26:08] Prrrrrobably [14:26:13] (03CR) 10Kunalgrover05: "Currently, the getting language from API doesn't work as well. It will work only after https://gerrit.wikimedia.org/r/#/c/137033/ is merge" [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [14:26:16] I bet the html5 drag and drop in uw is up to at least 50 [14:26:19] 3Wikimedia / 3General/Unknown: If one attempts a file upload in Commons, and the file name has unacceptable characters, there is an upload failure but no appropriate error message indicting why. - 10https://bugzilla.wikimedia.org/67197 (10Lane Rasberry) 3NEW p:3Unprio s:3normal a:3None Intention: upl... [14:26:27] marktraceur: needs mongodb [14:26:47] Obvs [14:26:59] Oh, only 35!? [14:27:01] I'm shocked [14:27:24] marktraceur: for what? [14:27:40] For the HTML5 drag-and-drop patch in UW [14:27:48] marktraceur: ah :) [14:27:51] Which is hopelessly outdated of course [14:28:06] marktraceur: ah, unmerged yet [14:28:09] Yeah [14:28:20] Are you kidding? Modern web features? In UW? [14:28:26] * marktraceur pinches YuviPanda to wake him up [14:28:33] marktraceur: heh :D [14:30:43] (03PS3) 10Rohan013: Replaces gzopen() function with gzopen64() [core] - 10https://gerrit.wikimedia.org/r/142287 (https://bugzilla.wikimedia.org/66952) [14:41:26] (03PS3) 10Umherirrender: Remove ParserOptions::setSkin() (deprecated since 1.19) [core] - 10https://gerrit.wikimedia.org/r/141489 [14:41:43] (03CR) 10Umherirrender: "Patch Set 3: Rebased" [core] - 10https://gerrit.wikimedia.org/r/141489 (owner: 10Umherirrender) [14:50:50] (03PS1) 10Umherirrender: Do not mention deprecated User::isValidEmailAddr() in hooks.txt [core] - 10https://gerrit.wikimedia.org/r/142532 [14:55:43] (03PS2) 10Jdlrobson: i18n: Rephrase the message flow-topic-participants-second-try [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142507 (owner: 10Amire80) [14:55:48] (03CR) 10Jdlrobson: [C: 032] i18n: Rephrase the message flow-topic-participants-second-try [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142507 (owner: 10Amire80) [14:56:19] (03Merged) 10jenkins-bot: i18n: Rephrase the message flow-topic-participants-second-try [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142507 (owner: 10Amire80) [15:00:47] 3MediaWiki / 3ResourceLoader: Add jQuery mobile - 10https://bugzilla.wikimedia.org/67155#c3 (10Andre Klapper) 5UNCO>3RESO/INV I'm still missing a clear and specific request here that describes functionality and not only a potential solution for something unclear, so I'm closing this ticket as INVALID. Fe... [15:03:46] (03PS1) 10Umherirrender: Remove OutputPage::getStatusMessage() (deprecated since 1.18) [core] - 10https://gerrit.wikimedia.org/r/142534 [15:03:48] (03PS1) 10Umherirrender: Remove OutputPage::isUserJsAllowed() (deprecated since 1.18) [core] - 10https://gerrit.wikimedia.org/r/142535 [15:09:32] 3MediaWiki / 3Page editing: The functionality to restore the edit textarea scroll on preview is not working - 10https://bugzilla.wikimedia.org/44803#c3 (10Jesús Martínez Novo (Ciencia Al Poder)) URL of comment #0 is obsolete. It's: https://git.wikimedia.org/blob/mediawiki%2fcore.git/REL1_21/resources%2fmed... [15:13:04] (03PS1) 10Umherirrender: Replace deprecated Title::escapeCanonicalURL call [core] - 10https://gerrit.wikimedia.org/r/142536 [15:18:17] 3MediaWiki / 3Page editing: The functionality to restore the edit textarea scroll on preview is not working - 10https://bugzilla.wikimedia.org/44803#c4 (10Siddharth Singh) 5NEW>3RESO/FIX it is working fine now. [15:20:45] (03PS1) 10Cmcmahon: Update ruby gems for browser tests [core] - 10https://gerrit.wikimedia.org/r/142538 [15:25:47] 3MediaWiki / 3Parser: PAGESINCATEGORY should decode HTML entities of input - 10https://bugzilla.wikimedia.org/67196#c1 (10Umherirrender) The problem is not alone with pagesincategory, all other parser functions which takes a title have this problem, see also bug 16474. [15:26:06] (03PS1) 10Hashar: Register some more extensions [extensions] - 10https://gerrit.wikimedia.org/r/142539 [15:26:21] (03PS3) 10Cmcmahon: Port preferences test from /qa repo [core] - 10https://gerrit.wikimedia.org/r/142295 [15:26:23] (03PS2) 10Hashar: Register some more extensions [extensions] - 10https://gerrit.wikimedia.org/r/142539 [15:26:28] (03CR) 10Hashar: [C: 032 V: 032] Register some more extensions [extensions] - 10https://gerrit.wikimedia.org/r/142539 (owner: 10Hashar) [15:26:32] (03Abandoned) 10Cmcmahon: Update ruby gems for browser tests [core] - 10https://gerrit.wikimedia.org/r/142538 (owner: 10Cmcmahon) [15:28:26] (03PS4) 10Cmcmahon: Port preferences test from /qa repo [core] - 10https://gerrit.wikimedia.org/r/142295 [15:28:45] (03CR) 10MarkTraceur: [C: 032] "Necessary :)" [extensions/ProofreadPage] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/141300 (owner: 10Tpt) [15:29:12] (03PS1) 10Hashar: Jobs for some more extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/142540 [15:29:58] (03Merged) 10jenkins-bot: Number of pages was wrongly set in the database [extensions/ProofreadPage] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/141300 (owner: 10Tpt) [15:30:11] (03CR) 10Zfilipin: [C: 032] Port preferences test from /qa repo [core] - 10https://gerrit.wikimedia.org/r/142295 (owner: 10Cmcmahon) [15:33:51] (03Merged) 10jenkins-bot: Port preferences test from /qa repo [core] - 10https://gerrit.wikimedia.org/r/142295 (owner: 10Cmcmahon) [15:34:02] 3MediaWiki / 3Page editing: The functionality to restore the edit textarea scroll on preview is not working - 10https://bugzilla.wikimedia.org/44803#c5 (10Rainer Rillke @commons.wikimedia) marktraceur: maybe 97c8120f995cb333fb86c82b7b9adbe0994faddb [15:38:13] (03PS1) 10Hashar: Jobs for some more extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/142544 [15:39:21] (03CR) 10Hashar: [C: 032] Jobs for some more extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/142544 (owner: 10Hashar) [15:39:28] (03Merged) 10jenkins-bot: Jobs for some more extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/142544 (owner: 10Hashar) [15:40:13] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/AddMessages] - 10https://gerrit.wikimedia.org/r/142545 [15:40:15] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/142546 [15:40:18] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/142547 [15:40:20] 3MediaWiki / 3Page editing: The functionality to restore the edit textarea scroll on preview is not working - 10https://bugzilla.wikimedia.org/44803 (10Jesús Martínez Novo (Ciencia Al Poder)) 5RESO/?>3VERI a:5Anjana S>3None [15:40:20] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142548 [15:40:22] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/142547 (owner: 10Hashar) [15:40:24] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/AddMessages] - 10https://gerrit.wikimedia.org/r/142545 (owner: 10Hashar) [15:40:26] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/142546 (owner: 10Hashar) [15:40:28] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions] - 10https://gerrit.wikimedia.org/r/142549 [15:40:30] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142548 (owner: 10Hashar) [15:41:01] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MixedNamespaceSearchSuggestions] - 10https://gerrit.wikimedia.org/r/142551 [15:41:06] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/MixedNamespaceSearchSuggestions] - 10https://gerrit.wikimedia.org/r/142551 (owner: 10Hashar) [15:42:52] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions] - 10https://gerrit.wikimedia.org/r/142549 (owner: 10Hashar) [15:43:36] (03PS1) 10Zfilipin: Created the first job to run Selenium tests in mediawiki/core [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/142552 [15:44:15] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/AddMessages] - 10https://gerrit.wikimedia.org/r/142545 (owner: 10Hashar) [15:44:30] (03CR) 10Cmcmahon: [C: 032] Created the first job to run Selenium tests in mediawiki/core [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/142552 (owner: 10Zfilipin) [15:44:48] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/142546 (owner: 10Hashar) [15:45:33] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/142547 (owner: 10Hashar) [15:46:16] (03Merged) 10jenkins-bot: Created the first job to run Selenium tests in mediawiki/core [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/142552 (owner: 10Zfilipin) [15:46:26] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MixedNamespaceSearchSuggestions] - 10https://gerrit.wikimedia.org/r/142551 (owner: 10Hashar) [15:51:05] (03PS1) 10Deepali: Same readability options on all chapters of the book [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/142555 (https://bugzilla.wikimedia.org/66957) [15:51:13] (03CR) 10jenkins-bot: [V: 04-1] Same readability options on all chapters of the book [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/142555 (https://bugzilla.wikimedia.org/66957) (owner: 10Deepali) [15:51:52] (03PS1) 10Hashar: Drop index from primary key [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142556 [15:52:09] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142548 (owner: 10Hashar) [15:52:32] (03CR) 10Hashar: [C: 032] "Deployed and triggered" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/142540 (owner: 10Hashar) [15:52:48] s/DO NOT SUBMIT/DO NOT MERGE/ [15:53:03] (03Merged) 10jenkins-bot: Jobs for some more extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/142540 (owner: 10Hashar) [15:56:15] (03CR) 10Nikerabbit: [C: 031] "I'm not using Redis but code looks sane." [core] - 10https://gerrit.wikimedia.org/r/142450 (https://bugzilla.wikimedia.org/60563) (owner: 10Krinkle) [16:00:18] 3MediaWiki / 3Page editing: The functionality to restore the edit textarea scroll on preview is not working - 10https://bugzilla.wikimedia.org/44803#c6 (10Derk-Jan Hartman) I recently made some changes to WikiEditor that also touched or interacted with this: effd98be7ebaa1f6f0d2c5b524c96ed6e0839a32 [16:02:07] (03CR) 10Bartosz Dziewoński: "I disagree: these two would be, in the perfect world, squashed into one change and it really sucks that I have to split them. But whatever" [core] - 10https://gerrit.wikimedia.org/r/138369 (owner: 10Bartosz Dziewoński) [16:02:16] Vulpix: we never merge :-) We vote in Gerrit to ask Jenkins to run the job and have Jenkins submit the patch in gerrit :] [16:02:18] (03PS10) 10Bartosz Dziewoński: [DO NOT MERGE] Vector: Remove compatibility for old variant menu HTML [core] - 10https://gerrit.wikimedia.org/r/138369 [16:02:22] Vulpix: that is Gerrit actually doing the merge [16:02:31] Vulpix: but yeah. I might update it hehe [16:02:58] (03PS1) 10Umherirrender: Replace deprecated Title::escapeLocalURL/escapeFullURL call [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/142559 [16:03:41] (03CR) 10Umherirrender: "Untested" [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/142559 (owner: 10Umherirrender) [16:04:05] 3MediaWiki extensions / 3Scribunto: Numeric values passed to mw.html result in script errors - 10https://bugzilla.wikimedia.org/67201 (10Jackmcbarn) 3NEW p:3Unprio s:3normal a:3None In this module: local p = {} function p.main(frame) local builder = mw.html.create('span'):css('opacity', 0)... [16:10:31] (03PS2) 10Deepali: Same readability options on all chapters of the book [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/142555 (https://bugzilla.wikimedia.org/66957) [16:15:47] 3MediaWiki / 3Internationalization: Update case mappings and normalization to Unicode 7.0.0 - 10https://bugzilla.wikimedia.org/67193 (10Andre Klapper) p:5Unprio>3Normal [16:19:42] (03PS1) 10Pcoombe: Convert from tag to includable special page, revamp tracking [extensions/Petition] - 10https://gerrit.wikimedia.org/r/142561 [16:19:48] (03CR) 10jenkins-bot: [V: 04-1] Convert from tag to includable special page, revamp tracking [extensions/Petition] - 10https://gerrit.wikimedia.org/r/142561 (owner: 10Pcoombe) [16:20:47] 3MediaWiki extensions / 3Scribunto: mw.ustring methods don't allow numbers where corresponding string methods do - 10https://bugzilla.wikimedia.org/67201#c1 (10Brad Jorsch) Not actually a bug in mw.html, it's that mw.ustring isn't autoconverting numbers where Lua's standard string library does. [16:21:03] 3MediaWiki extensions / 3Scribunto: mw.ustring methods don't allow numbers where corresponding string methods do - 10https://bugzilla.wikimedia.org/67201 (10Brad Jorsch) a:3Brad Jorsch [16:23:21] (03PS1) 10Jackmcbarn: Fix strange mw.html errors with numeric arguments [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/142563 (https://bugzilla.wikimedia.org/67201) [16:24:21] (03CR) 10Jdlrobson: [V: 032] Dont even provide action links to blocked users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142394 (owner: 10EBernhardson) [16:25:02] 3MediaWiki extensions / 3Scribunto: mw.ustring methods don't allow numbers where corresponding string methods do - 10https://bugzilla.wikimedia.org/67201#c3 (10Jackmcbarn) Well, it's partially both. There's other ways to cause this that make it fail in places other than ustring. [16:28:54] (03CR) 10Aaron Schulz: [C: 032] BLOB/TEXT column 'abcdef' can't have a default value [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/142254 (owner: 10Matthias Mullie) [16:29:06] (03CR) 10Anomie: Fix strange mw.html errors with numeric arguments (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/142563 (https://bugzilla.wikimedia.org/67201) (owner: 10Jackmcbarn) [16:29:15] (03Merged) 10jenkins-bot: BLOB/TEXT column 'abcdef' can't have a default value [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/142254 (owner: 10Matthias Mullie) [16:29:28] (03CR) 10Jdlrobson: [C: 031] "I haven't really got a clue what these Anchor things are." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142524 (owner: 10Matthias Mullie) [16:30:13] (03CR) 10Jackmcbarn: Fix strange mw.html errors with numeric arguments (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/142563 (https://bugzilla.wikimedia.org/67201) (owner: 10Jackmcbarn) [16:31:35] (03PS2) 10Jackmcbarn: Fix strange mw.html errors with numeric arguments [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/142563 (https://bugzilla.wikimedia.org/67201) [16:32:48] (03PS1) 10Anomie: mw.ustring functions should accept numbers where string functions do [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/142567 (https://bugzilla.wikimedia.org/67201) [16:34:49] (03PS1) 10Umherirrender: Replace deprecated Title::escapeFullURL call [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/142568 [16:34:57] (03CR) 10Anomie: Fix strange mw.html errors with numeric arguments (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/142563 (https://bugzilla.wikimedia.org/67201) (owner: 10Jackmcbarn) [16:35:04] (03CR) 10Bartosz Dziewoński: Stop using a suboptimal structure for Vector's variants menu (031 comment) [core] - 10https://gerrit.wikimedia.org/r/138368 (https://bugzilla.wikimedia.org/43406) (owner: 10Bartosz Dziewoński) [16:35:54] (03CR) 10Umherirrender: "Untested. Simple replace of the deprecated method with the functional part and a htmlspecialchars()" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/142568 (owner: 10Umherirrender) [16:37:22] (03PS2) 10EBernhardson: Split WorkflowLoader into multiple classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142399 [16:38:00] (03PS1) 10Aaron Schulz: Added cast to memcached set() call since it also uses incr() [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/142570 [16:38:02] (03PS3) 10EBernhardson: Split WorkflowLoader into multiple classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142399 [16:38:57] (03CR) 10Jackmcbarn: Fix strange mw.html errors with numeric arguments (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/142563 (https://bugzilla.wikimedia.org/67201) (owner: 10Jackmcbarn) [16:39:42] (03CR) 10Aaron Schulz: "Originally, I didn't want callers to have to care about using set/add with a string and calling incr later (a more likely problem than the" [core] - 10https://gerrit.wikimedia.org/r/142450 (https://bugzilla.wikimedia.org/60563) (owner: 10Krinkle) [16:46:59] (03PS1) 10Umherirrender: Replace deprecated Title::escapeFullURL calls [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/142573 [16:47:04] (03PS2) 10Umherirrender: Replace deprecated Title::escapeFullURL calls [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/142568 [16:47:14] (03PS2) 10Umherirrender: Replace deprecated Title::escapeLocalURL/escapeFullURL calls [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/142559 [16:50:17] 3MediaWiki extensions / 3Math: Math tests dies when run with the Echo extensions - 10https://bugzilla.wikimedia.org/67148#c2 (10physikerwelt) did you run update.php before? As far as I understand the database tests copy the schema with and prefix the tables with untitest. If there is no math table in the bas... [16:51:03] (03CR) 10Umherirrender: "Untested. Simple replace of the deprecated method with the functional part and a htmlspecialchars()" [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/142573 (owner: 10Umherirrender) [16:54:01] (03PS1) 10Jdlrobson: QA: Fix for browser tests in Chrome [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142574 [16:57:36] (03PS1) 10Umherirrender: Replace deprecated Title::escapeFullURL calls [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/142578 [16:57:40] (03CR) 10jenkins-bot: [V: 04-1] Replace deprecated Title::escapeFullURL calls [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/142578 (owner: 10Umherirrender) [16:59:09] (03PS2) 10Umherirrender: Replace deprecated Title::escapeFullURL calls [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/142578 [16:59:26] (03CR) 10Umherirrender: "Patch Set 2: Fixed syntax error" [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/142578 (owner: 10Umherirrender) [16:59:38] (03CR) 10Umherirrender: "Untested. Simple replace of the deprecated method with the functional part and a htmlspecialchars()" [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/142578 (owner: 10Umherirrender) [17:06:25] (03PS1) 10Umherirrender: Replace deprecated Title::escapeFullURL calls [extensions/Comments] - 10https://gerrit.wikimedia.org/r/142580 [17:07:07] (03CR) 10Umherirrender: "Untested. Simple replace of the deprecated method with the functional part and a htmlspecialchars()" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/142580 (owner: 10Umherirrender) [17:07:29] marktraceur: hey, sorry. looks like i accidentally dropped your patch from the swat yesterday. my bad. :/ [17:07:46] it'll have to go out on monday, now. hope that's all right. [17:07:48] 's OK [17:10:38] (03PS6) 10Paladox: Update jQuery Cookie to v1.4.1 [core] - 10https://gerrit.wikimedia.org/r/139686 [17:11:09] (03PS1) 10Faidon Liambotis: Clarify license under debian/copyright [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/142582 [17:11:11] (03PS1) 10Faidon Liambotis: Various Debian packaging fixes [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/142583 [17:11:13] (03PS1) 10Faidon Liambotis: Add packaging for the HHVM extension [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/142584 [17:12:28] (03PS1) 10Faidon Liambotis: Various Debian packaging fixes [php/luasandbox] - 10https://gerrit.wikimedia.org/r/142585 [17:12:30] (03PS1) 10Faidon Liambotis: Add packaging for the HHVM extension [php/luasandbox] - 10https://gerrit.wikimedia.org/r/142586 [17:12:39] (03PS1) 10Faidon Liambotis: Various Debian packaging fixes [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/142587 [17:12:41] (03PS1) 10Faidon Liambotis: Add packaging for the HHVM extension [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/142588 [17:12:49] (03CR) 10jenkins-bot: [V: 04-1] Add packaging for the HHVM extension [php/luasandbox] - 10https://gerrit.wikimedia.org/r/142586 (owner: 10Faidon Liambotis) [17:14:01] (03CR) 10Faidon Liambotis: "Tim, was that your intention?" [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/142582 (owner: 10Faidon Liambotis) [17:16:51] (03CR) 10Krinkle: [C: 031] "Both of those variables are parameters documented as integers. I guess the actual caller is elsewhere. Maybe update those as well (or even" [core] - 10https://gerrit.wikimedia.org/r/142458 (owner: 10Aaron Schulz) [17:17:23] (03CR) 10Krinkle: [C: 031] Added cast to memcached set() call since it also uses incr() [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/142570 (owner: 10Aaron Schulz) [17:18:04] (03PS23) 10Paladox: mediawiki.searchSuggest: Enable for iPhone and iPod touch [core] - 10https://gerrit.wikimedia.org/r/139809 [17:18:23] (03CR) 10Paladox: [C: 031] mediawiki.searchSuggest: Enable for iPhone and iPod touch [core] - 10https://gerrit.wikimedia.org/r/139809 (owner: 10Paladox) [17:18:27] (03CR) 10Krinkle: "Still has two parents, two different ones this time. I suspect maybe you have got some misconfigured plugin or setting in your git applica" [core] - 10https://gerrit.wikimedia.org/r/139686 (owner: 10Paladox) [17:18:37] (03CR) 10Krinkle: [C: 04-1] Update jQuery Cookie to v1.4.1 [core] - 10https://gerrit.wikimedia.org/r/139686 (owner: 10Paladox) [17:18:48] * tonythomas join #dgplug [17:19:12] * tonythomas tries to earse earlier message :D oops [17:19:17] 3MediaWiki / 3Special pages: Looking up a username that's not registered in Special:Contributions should give warning - 10https://bugzilla.wikimedia.org/60524#c9 (10Glaisher) This should probably not appear for IPv4 ranges: [[Special:Contribs/127.0.0.1/16]]. It doesn't appear for IPv6 ranges. [17:19:30] (03CR) 10Krinkle: "To clarify, I was referring to the subject line." [core] - 10https://gerrit.wikimedia.org/r/139268 (https://bugzilla.wikimedia.org/60077) (owner: 10Foxtrott) [17:21:23] (03CR) 10Paladox: "Oh how to I do that because I am using git on windows." [core] - 10https://gerrit.wikimedia.org/r/139686 (owner: 10Paladox) [17:22:17] 3MediaWiki / 3Special pages: Looking up a username that's not registered in Special:Contributions should give warning - 10https://bugzilla.wikimedia.org/60524#c10 (10Jackmcbarn) Actually, the IPv4 range behavior is correct and the IPv6 range behavior is the bug. [17:24:54] (03CR) 10Paladox: "Oh how do I do that because I am using git on windows." [core] - 10https://gerrit.wikimedia.org/r/139686 (owner: 10Paladox) [17:28:36] 3MediaWiki / 3General/Unknown: Inconsistent behavior of User::isIP between IPv4 and IPv6 ranges - 10https://bugzilla.wikimedia.org/67203 (10Jackmcbarn) 3NEW p:3Unprio s:3normal a:3None User::isIP considers the string "2001::/16" to be an IP, but "192.0.0.0/8" to not be one. [17:29:02] 3MediaWiki / 3Special pages: Looking up a username that's not registered in Special:Contributions should give warning - 10https://bugzilla.wikimedia.org/60524#c11 (10Jackmcbarn) I've filed a new bug for that problem, bug #67203. [17:29:17] 3MediaWiki / 3General/Unknown: Inconsistent behavior of User::isIP between IPv4 and IPv6 ranges - 10https://bugzilla.wikimedia.org/67203 (10Jackmcbarn) [17:30:03] 3MediaWiki / 3General/Unknown: Inconsistent behavior of User::isIP between IPv4 and IPv6 ranges - 10https://bugzilla.wikimedia.org/67203#c1 (10Jackmcbarn) Clarification, "2001:0:0:0:0:0:0:0/16" is the string it considers an IP. [17:38:24] Anyone know where to view the jenkins-bot rules for submit/verify/merge in any particular repo? [17:39:33] 3MediaWiki extensions / 3VectorBeta: CPB: Accessibility for keyboard users and screen readers - 10https://bugzilla.wikimedia.org/67195#c1 (10Jared Zimmerman (WMF)) DJ, do you plan on working on this? or just the audit (either is appreciated) just checking. Thanks for the work so far! [17:41:17] 3MediaWiki / 3Skin and page rendering: Consolidate personal portlet links into collapsed control or dropdown - 10https://bugzilla.wikimedia.org/44448 (10Jared Zimmerman (WMF)) [17:41:17] 3MediaWiki extensions / 3VectorBeta: CPB: Accessibility for keyboard users and screen readers - 10https://bugzilla.wikimedia.org/67195 (10Jared Zimmerman (WMF)) [17:41:55] (03CR) 10Ori.livneh: "Aaron, would you like to be added to the copyright statement?" [php/luasandbox] - 10https://gerrit.wikimedia.org/r/142585 (owner: 10Faidon Liambotis) [17:42:17] 3MediaWiki extensions / 3EducationProgram: Courses link is not showing up in the gadgets/extension section of compact personal bar flyout - 10https://bugzilla.wikimedia.org/65467#c2 (10Jared Zimmerman (WMF)) Sage, Check the Sandbox extension perhaps? it seems to be working fine. [17:45:17] 3Wikimedia / 3Deployment systems: HHBC cache creation fails with SIGABRT on osmium - 10https://bugzilla.wikimedia.org/67098 (10Bryan Davis) [17:45:18] 3Wikimedia / 3Deployment systems: Investigate effect of multiple release branches on HHVM's JIT system - 10https://bugzilla.wikimedia.org/67168 (10Bryan Davis) [17:45:18] 3MediaWiki extensions / 3Scribunto: HHVM: assertion from optimizedCallIniGet - 10https://bugzilla.wikimedia.org/66942 (10Bryan Davis) [17:47:17] (03CR) 10Aaron Schulz: "I don't recall making changes to this extension, so no :)" [php/luasandbox] - 10https://gerrit.wikimedia.org/r/142585 (owner: 10Faidon Liambotis) [17:48:21] (03CR) 10Ori.livneh: "Oh oops, I had both this and Faidon's FSS patch open and mixed them up. You're listed in https://gerrit.wikimedia.org/r/#/c/142587/1/debia" [php/luasandbox] - 10https://gerrit.wikimedia.org/r/142585 (owner: 10Faidon Liambotis) [17:49:18] 3Analytics / 3Refinery: Hive queries inconsistently failing - 10https://bugzilla.wikimedia.org/65420#c38 (10Oliver Keyes) Created attachment 15764 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15764&action=edit Errors After running for 33 days, the Legendarily Broken Query /actually spat out an err... [18:03:38] (03CR) 10Gergő Tisza: [C: 032] Added cast to memcached set() call since it also uses incr() [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/142570 (owner: 10Aaron Schulz) [18:03:44] (03Merged) 10jenkins-bot: Added cast to memcached set() call since it also uses incr() [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/142570 (owner: 10Aaron Schulz) [18:04:18] (03PS1) 10MaxSem: Reset RequestContext between tests [core] - 10https://gerrit.wikimedia.org/r/142596 [18:05:26] (03CR) 10MaxSem: [C: 031] Clarify license under debian/copyright [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/142582 (owner: 10Faidon Liambotis) [18:15:35] 3MediaWiki / 3General/Unknown: Creating a Draft article should automatically add {{Draft article}} - 10https://bugzilla.wikimedia.org/67207 (10Sumana Harihareswara) 3NEW p:3Unprio s:3enhanc a:3None When a person wants to create a new Draft article (on English Wikipedia), they generally want to includ... [18:15:45] (03PS1) 10Jdlrobson: Remove dead helper code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142598 [18:15:48] (03PS1) 10Jdlrobson: Hygiene: Remove useless helper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142599 [18:15:51] (03PS1) 10Jdlrobson: WIP: Simplify linkWithReturnTo helper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142600 [18:16:17] 3MediaWiki / 3General/Unknown: Creating a Draft article should automatically add {{Draft article}} - 10https://bugzilla.wikimedia.org/67207 (10Sumana Harihareswara) p:5Unprio>3Normal [18:19:17] (03CR) 10Aaron Schulz: "PHP is not strongly typed and heavily leans towards juggling with "scalar-like" values by its design/approach. Without scalar type hints i" [core] - 10https://gerrit.wikimedia.org/r/142458 (owner: 10Aaron Schulz) [18:23:24] (03PS1) 10Umherirrender: Replace deprecated Title::escapeFullURL calls [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/142604 [18:23:39] (03CR) 10Umherirrender: "Untested. Simple replace of the deprecated method with the functional part and a htmlspecialchars()" [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/142604 (owner: 10Umherirrender) [18:30:08] (03PS1) 10Umherirrender: Replace deprecated Title::escapeFullURL calls [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/142608 [18:30:28] (03CR) 10Umherirrender: "Untested. Simple replace of the deprecated method with the functional part and a htmlspecialchars()" [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/142608 (owner: 10Umherirrender) [18:30:36] (03CR) 10Chad: [C: 032] Add some casts for sanity before BagOStuff::add() calls [core] - 10https://gerrit.wikimedia.org/r/142458 (owner: 10Aaron Schulz) [18:34:11] (03Merged) 10jenkins-bot: Add some casts for sanity before BagOStuff::add() calls [core] - 10https://gerrit.wikimedia.org/r/142458 (owner: 10Aaron Schulz) [18:34:24] (03CR) 10Aaron Schulz: [C: 032] mw.ustring functions should accept numbers where string functions do [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/142567 (https://bugzilla.wikimedia.org/67201) (owner: 10Anomie) [18:35:52] (03PS1) 10Umherirrender: Replace deprecated Title::escapeFullURL calls [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/142610 [18:36:11] (03CR) 10Umherirrender: "Untested. Simple replace of the deprecated method with the functional part and a htmlspecialchars()" [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/142610 (owner: 10Umherirrender) [18:37:18] (03Merged) 10jenkins-bot: mw.ustring functions should accept numbers where string functions do [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/142567 (https://bugzilla.wikimedia.org/67201) (owner: 10Anomie) [18:38:47] 3MediaWiki / 3Page editing: Creating a Draft article should automatically add {{Draft article}} - 10https://bugzilla.wikimedia.org/67207 (10Andre Klapper) [18:41:18] (03PS2) 10Aaron Schulz: Added some sanity warnings to TransactionProfiler [core] - 10https://gerrit.wikimedia.org/r/142047 [18:41:37] (03PS3) 10Jackmcbarn: Fix strange mw.html errors with numeric arguments [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/142563 (https://bugzilla.wikimedia.org/67201) [18:42:12] (03CR) 10Ori.livneh: [C: 032] Reset RequestContext between tests [core] - 10https://gerrit.wikimedia.org/r/142596 (owner: 10MaxSem) [18:42:24] (03CR) 10Jackmcbarn: "Now depends on Icd3c5e93 instead of calling tostring." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/142563 (https://bugzilla.wikimedia.org/67201) (owner: 10Jackmcbarn) [18:44:14] (03CR) 10MarkTraceur: [C: 031] Use separate PoolCounter config for expensive thumbnails [core] - 10https://gerrit.wikimedia.org/r/135703 (https://bugzilla.wikimedia.org/65691) (owner: 10Gergő Tisza) [18:44:14] (03CR) 10Aaron Schulz: [C: 032] objectcache: Actually unserialize integers as integers in RedisBagOStuff [core] - 10https://gerrit.wikimedia.org/r/142450 (https://bugzilla.wikimedia.org/60563) (owner: 10Krinkle) [18:44:40] (03CR) 10Chad: [C: 032] Added some sanity warnings to TransactionProfiler [core] - 10https://gerrit.wikimedia.org/r/142047 (owner: 10Aaron Schulz) [18:45:16] (03Abandoned) 10Chad: Pass a Title for context to Linker::makeExternalLink() [core] - 10https://gerrit.wikimedia.org/r/129853 (owner: 10Chad) [18:45:45] (03PS2) 10Jdlrobson: Simplify linkWithReturnTo helper [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142600 [18:46:23] (03Merged) 10jenkins-bot: Reset RequestContext between tests [core] - 10https://gerrit.wikimedia.org/r/142596 (owner: 10MaxSem) [18:47:29] (03Merged) 10jenkins-bot: objectcache: Actually unserialize integers as integers in RedisBagOStuff [core] - 10https://gerrit.wikimedia.org/r/142450 (https://bugzilla.wikimedia.org/60563) (owner: 10Krinkle) [18:48:01] (03Merged) 10jenkins-bot: Added some sanity warnings to TransactionProfiler [core] - 10https://gerrit.wikimedia.org/r/142047 (owner: 10Aaron Schulz) [18:49:16] (03CR) 10Mattflaschen: "Looks good; changes Aaron mentioned are merged." [core] - 10https://gerrit.wikimedia.org/r/142450 (https://bugzilla.wikimedia.org/60563) (owner: 10Krinkle) [18:49:21] anomie: do you think your ustring change is SWATable? [18:50:09] jackmcbarn: Is it causing trouble that can't wait to ride the train? [18:51:35] hmm, actually it's not breaking any articles or anything. i guess it can wait [18:52:49] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209 (10Steinsplitter) 3NEW p:3Unprio s:3enhanc a:3None Admins schould be able to edit & delete pages in the GWToolset namespace on commons. [18:58:28] (03CR) 10Aaron Schulz: [C: 032] Use separate PoolCounter config for expensive thumbnails [core] - 10https://gerrit.wikimedia.org/r/135703 (https://bugzilla.wikimedia.org/65691) (owner: 10Gergő Tisza) [18:59:17] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c1 (10John F. Lewis) p:5Unprio>3Normal Is there a link to local community consensus? [18:59:21] (03CR) 10jenkins-bot: [V: 04-1] Use separate PoolCounter config for expensive thumbnails [core] - 10https://gerrit.wikimedia.org/r/135703 (https://bugzilla.wikimedia.org/65691) (owner: 10Gergő Tisza) [19:00:56] (03CR) 10tosfos: Consistency tweaks in preparation for adding to translatewiki.net (031 comment) [extensions/ListSignup] - 10https://gerrit.wikimedia.org/r/141898 (owner: 10Raimond Spekking) [19:01:32] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c2 (10Steinsplitter) minor change, not needed. [19:02:35] (03PS1) 10Withoutaname: Move deletion-specific code to DeleteAction.php [core] - 10https://gerrit.wikimedia.org/r/142618 [19:07:17] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c3 (10Jackmcbarn) Note that they wouldn't just be getting the ability to edit the namespace; they would get full usage of GWToolset, just like any member of the GWToolset group would have. [19:08:17] (03PS1) 10Taueres: WebInstaller::outputCss no longer requires an argument [core] - 10https://gerrit.wikimedia.org/r/142620 [19:08:32] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c4 (10Andre Klapper) (In reply to Steinsplitter from comment #2) > minor change, not needed. Hmm, is "minor change" in this case defined somewhere, or is this "unwritten common sense"? [19:10:32] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c5 (10Steinsplitter) (In reply to Andre Klapper from comment #4) > (In reply to Steinsplitter from comment #2) > > minor change, not needed. > > Hmm, is "minor change" in this case defin... [19:12:02] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c6 (10John F. Lewis) May I quote; "Local on-wiki community consensus is needed for a configuration variable or setting change, to confirm that the request is supported by the community.... [19:13:14] (03CR) 10Nikerabbit: [C: 04-1] "Would be nice to purge the article when changing language, so that language dependent rendering is immediately visible." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [19:13:17] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c7 (10Jackmcbarn) > (In reply to Jackmcbarn from comment #3) > > Note that they wouldn't just be getting the ability to edit the namespace; > > they would get full usage of GWToolset, jus... [19:13:32] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c8 (10Steinsplitter) Commons sense pls. This is a verry verry new beta tool. @ John F. Lewis: Stop this nonsese. [19:14:10] (03PS1) 10Aaron Schulz: Fixed use of bogus vars [services/jobrunner] - 10https://gerrit.wikimedia.org/r/142621 [19:14:16] ori: ^ [19:14:17] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c9 (10Steinsplitter) (In reply to Jackmcbarn from comment #7) > > (In reply to Jackmcbarn from comment #3) > > > Note that they wouldn't just be getting the ability to edit the namespace;... [19:14:33] (03CR) 10Ori.livneh: [C: 032 V: 032] Fixed use of bogus vars [services/jobrunner] - 10https://gerrit.wikimedia.org/r/142621 (owner: 10Aaron Schulz) [19:15:17] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c10 (10Jackmcbarn) (In reply to Steinsplitter from comment #9) > (In reply to Jackmcbarn from comment #7) > > > (In reply to Jackmcbarn from comment #3) > > > > Note that they wouldn't ju... [19:16:47] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c11 (10Tomasz W. Kozlowski) Please ask for community consensus on Commons. Thank you! [19:16:49] ori: I can't pull that...git perm errors [19:17:22] AaronSchulz: d'oh, sec [19:17:32] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c12 (10Didym) actually, admins can create pages in the GWToolset namespace, as they can restore pages (but neither edit nor delete them) [19:18:02] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c13 (10Bawolff (Brian Wolff)) The GWToolset namespace is mostly used for "saving" mappings of xml -> wikitext. I don't see any reason why admins shouldn't be able to edit it (Actually I'm... [19:18:10] AaronSchulz: try now [19:18:34] works now [19:19:03] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c14 (10Steinsplitter) Without word. To much bureaucracy. Why we need for a new beta tool communety consensus. It is _completly_ nonsense. [19:20:02] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c15 (10Tisza Gergő) (In reply to Jackmcbarn from comment #10) > I know how MediaWiki's permission system works. Without doing what I said, > we'd have to give admins access to all of GWTo... [19:20:42] (03CR) 10Bartosz Dziewoński: [C: 032] Add default php entry point [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/142106 (owner: 10Hashar) [19:20:46] (03Merged) 10jenkins-bot: Add default php entry point [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/142106 (owner: 10Hashar) [19:21:18] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c16 (10John F. Lewis) (In reply to Steinsplitter from comment #14) > Without word. To much bureaucracy. Why we need for a new beta tool > communety consensus. It is _completly_ nonsense.... [19:21:32] 3MediaWiki-Vagrant: browsertests role permanently changes system default ruby to 1.9 - 10https://bugzilla.wikimedia.org/50993 (10Matthew Flaschen) 5PATC>3RESO/FIX [19:21:32] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c17 (10Jackmcbarn) (In reply to Tisza Gergő from comment #15) > (In reply to Jackmcbarn from comment #10) > > I know how MediaWiki's permission system works. Without doing what I said, >... [19:22:48] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c18 (10Steinsplitter) (In reply to Tisza Gergő from comment #15) > (In reply to Jackmcbarn from comment #10) > > I know how MediaWiki's permission system works. Without doing what I said,... [19:23:32] 3MediaWiki-Vagrant: ruby-build significantly slows down the provisioning process - 10https://bugzilla.wikimedia.org/66763#c6 (10Matthew Flaschen) 5PATC>3RESO/FIX Looks to be fixed, if I understand that patch correctly. Thanks. [19:24:02] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c19 (10Steinsplitter) (In reply to Jackmcbarn from comment #17) > (In reply to Tisza Gergő from comment #15) > > (In reply to Jackmcbarn from comment #10) > > > I know how MediaWiki's per... [19:25:34] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c20 (10Steinsplitter) (In reply to John F. Lewis from comment #16) > (In reply to Steinsplitter from comment #14) > > Without word. To much bureaucracy. Why we need for a new beta tool >... [19:26:54] * greg-g sighs [19:27:17] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c21 (10John F. Lewis) (In reply to Steinsplitter from comment #20) > (In reply to John F. Lewis from comment #16) > > (In reply to Steinsplitter from comment #14) > > > Without word. To m... [19:29:58] * bawolff is trying to calm him down in a different channel [19:32:43] (03PS1) 10CSteipp: JWT namespace [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/142623 [19:34:48] (03CR) 10Reedy: [C: 032] JWT namespace [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/142623 (owner: 10CSteipp) [19:34:53] (03Merged) 10jenkins-bot: JWT namespace [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/142623 (owner: 10CSteipp) [19:37:32] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c23 (10Andre Klapper) Steinsplitter: Read [[mw:Bug_management/Bugzilla_etiquette]], especially "Criticize ideas, not people." Some of your previous comments are crossing a line by not ass... [19:40:02] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c24 (10Steinsplitter) (In reply to Andre Klapper from comment #23) > Steinsplitter: Read [[mw:Bug_management/Bugzilla_etiquette]], especially > "Criticize ideas, not people." Some of your... [19:40:06] (03PS1) 10Bsitu: Get rid of termsOfuse hook and helper function [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142626 [19:42:08] (03PS1) 10Ori.livneh: facter example for otto, do not merge [vagrant] - 10https://gerrit.wikimedia.org/r/142627 [19:42:35] (03PS1) 10Bsitu: Add more flow terms of use message and remove Flow hook [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/142628 [19:42:42] manybubbles: I know the old search is on last legs, but https://en.wikipedia.org/w/index.php?title=Special%3ASearch&profile=advanced&search=Entity+reference&fulltext=Search&ns0=1&ns9=1&ns11=1&profile=advanced has been repeatedly failing for me for the last ten minutes consistently [19:43:30] (03PS2) 10Bsitu: Get rid of termsOfuse hook and helper function [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142626 [19:43:50] (03PS2) 10Bsitu: Add more flow terms of use message and remove Flow hook [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/142628 [19:44:54] (03PS1) 10tosfos: make functions non-static [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/142630 [19:45:48] 3MediaWiki / 3Unit tests: parser tests drops anything in $wgSharedTables - 10https://bugzilla.wikimedia.org/65654#c9 (10Tomasz W. Kozlowski) 5PATC>3RESO/FIX a:3Bawolff (Brian Wolff) Merged in core master and cherry-picked to REL1_23, so marking as RESOLVED FIXED. Leaving Brian as assignee so he can t... [19:48:51] (03CR) 10Bsitu: [C: 04-1] "Doesn't seem to work on client side rendering" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142626 (owner: 10Bsitu) [19:51:17] 3MediaWiki extensions / 3Math: Math tests dies when run with the Echo extensions - 10https://bugzilla.wikimedia.org/67148#c3 (10Antoine "hashar" Musso) I did ran update.php A slightly more complicated test I ran in Jenkins is: https://integration.wikimedia.org/ci/job/mediawiki-core-extensions-integration/3... [19:54:18] (03PS1) 10tosfos: rework parameter handling, add sort options [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/142634 [19:55:27] (03PS15) 10Hashar: (WIP) Experiment zuul-cloner with extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141846 [19:56:01] (03CR) 10Hashar: "PoolCounter now has an entry point" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141846 (owner: 10Hashar) [19:56:10] (03PS1) 10MaxSem: Improve isolation of a few tests [core] - 10https://gerrit.wikimedia.org/r/142635 [19:57:10] (03PS4) 10CSteipp: phutil oauth adapter for mediawiki oauth1 [phabricator/libphutil] - 10https://gerrit.wikimedia.org/r/139438 (owner: 1020after4) [19:58:00] (03PS2) 10IAlex: Do not mention deprecated User::isValidEmailAddr() in hooks.txt [core] - 10https://gerrit.wikimedia.org/r/142532 (owner: 10Umherirrender) [19:58:05] (03CR) 10IAlex: [C: 032] Do not mention deprecated User::isValidEmailAddr() in hooks.txt [core] - 10https://gerrit.wikimedia.org/r/142532 (owner: 10Umherirrender) [19:58:38] (03Abandoned) 10tosfos: make functions non-static [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/142630 (owner: 10tosfos) [19:59:09] (03CR) 10tosfos: [C: 031] rework parameter handling, add sort options [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/142634 (owner: 10tosfos) [20:00:31] (03PS6) 10Gergő Tisza: Use separate PoolCounter config for expensive thumbnails [core] - 10https://gerrit.wikimedia.org/r/135703 (https://bugzilla.wikimedia.org/65691) [20:02:31] (03Merged) 10jenkins-bot: Do not mention deprecated User::isValidEmailAddr() in hooks.txt [core] - 10https://gerrit.wikimedia.org/r/142532 (owner: 10Umherirrender) [20:02:32] 3MediaWiki extensions / 3VectorBeta: CPB: Accessibility for keyboard users and screen readers - 10https://bugzilla.wikimedia.org/67195#c2 (10Derk-Jan Hartman) I haven't planned anything right now. It depends on my time. Took me 2 months to get around to the review ;) [20:05:02] (03PS2) 10IAlex: Standardize version comment in OracleUpdater.php [core] - 10https://gerrit.wikimedia.org/r/141734 (owner: 10Umherirrender) [20:05:13] (03CR) 10IAlex: [C: 032] Standardize version comment in OracleUpdater.php [core] - 10https://gerrit.wikimedia.org/r/141734 (owner: 10Umherirrender) [20:06:20] 3Wikimedia / 3Site requests: Remove GWToolset extension from Commons as no community consensus has been provided to install it - 10https://bugzilla.wikimedia.org/67211 (10Rainer Rillke @commons.wikimedia) 3NEW p:3Unprio s:3normal a:3None Original bug title: Remove GWToolset extension from Commons as... [20:06:47] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c25 (10Rainer Rillke @commons.wikimedia) +1 to this change from my side. > It is not completely nonsense; it is following a process which has been used > for several years at the Founda... [20:06:55] oh god [20:07:17] 3Wikimedia / 3Site requests: Remove GWToolset extension from Commons as no community consensus has been provided to install it - 10https://bugzilla.wikimedia.org/67211 (10John F. Lewis) p:5Unprio>3Normal [20:07:55] (03CR) 10Aaron Schulz: [C: 032] Use separate PoolCounter config for expensive thumbnails [core] - 10https://gerrit.wikimedia.org/r/135703 (https://bugzilla.wikimedia.org/65691) (owner: 10Gergő Tisza) [20:08:27] (03CR) 10CSteipp: "Mostly minor stuff. I fixed the urls in PS4 so it will work against labs." (034 comments) [phabricator/libphutil] - 10https://gerrit.wikimedia.org/r/139438 (owner: 1020after4) [20:09:36] (03Merged) 10jenkins-bot: Standardize version comment in OracleUpdater.php [core] - 10https://gerrit.wikimedia.org/r/141734 (owner: 10Umherirrender) [20:10:58] (03Merged) 10jenkins-bot: Use separate PoolCounter config for expensive thumbnails [core] - 10https://gerrit.wikimedia.org/r/135703 (https://bugzilla.wikimedia.org/65691) (owner: 10Gergő Tisza) [20:11:32] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c26 (10Rainer Rillke @commons.wikimedia) Forgot to prove V. which I herby do: https://commons.wikimedia.org/wiki/Commons:Bureaucrats%27_noticeboard/Archive_2#GW_Toolset_right [20:13:25] <^d> File::getMetadata() claims to return bool|array. LocalFile::getMetadata() returns a string (by which it means serialized php). Very inconsistent :( [20:13:47] 3Wikimedia / 3Site requests: Remove GWToolset extension from Commons as no community consensus has been provided to install it - 10https://bugzilla.wikimedia.org/67211#c1 (10Tomasz W. Kozlowski) 5NEW>3RESO/WON I hereby decree that this will never happen. [20:14:47] 3Wikimedia / 3Site requests: Remove GWToolset extension from Commons as no community consensus has been provided to install it - 10https://bugzilla.wikimedia.org/67211#c2 (10Rainer Rillke @commons.wikimedia) (In reply to Tomasz W. Kozlowski from comment #1) Why. Prove! [20:15:07] <^d> Guess I should use File::getCommonMetaArray(). [20:15:17] 3Wikimedia / 3Site requests: Remove GWToolset extension from Commons as no community consensus has been provided to install it - 10https://bugzilla.wikimedia.org/67211#c3 (10Andre Klapper) > Remove GWToolset extension from Commons as no community consensus has > been provided to install it What are the act... [20:16:47] 3Wikimedia / 3Site requests: Remove GWToolset extension from Commons as no community consensus has been provided to install it - 10https://bugzilla.wikimedia.org/67211#c4 (10Greg Grossmeier) Just supplying links... Here's a list of communication/outreach the GWToolset team did over the years: https://common... [20:19:57] (03PS3) 10Jdlrobson: Dont even provide action links to blocked users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142394 (owner: 10EBernhardson) [20:20:02] (03CR) 10Jdlrobson: [C: 032] Dont even provide action links to blocked users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142394 (owner: 10EBernhardson) [20:20:31] (03Merged) 10jenkins-bot: Dont even provide action links to blocked users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142394 (owner: 10EBernhardson) [20:21:47] 3Wikimedia / 3Site requests: Remove GWToolset extension from Commons as no community consensus has been provided to install it - 10https://bugzilla.wikimedia.org/67211#c5 (10Rainer Rillke @commons.wikimedia) (In reply to Andre Klapper from comment #3) > is community consensus the one and only argument for t... [20:22:55] (03PS1) 10Anomie: Add HTMLAutoCompleteSelectField [core] - 10https://gerrit.wikimedia.org/r/142668 [20:23:13] (03PS1) 10Anomie: Use HTMLAutoCompleteSelectField [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/142671 [20:24:00] (03CR) 10Anomie: [C: 04-1] "Don't merge without core change I42473cea75f3706cc0125167f9191275ca6cb3b0" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/142671 (owner: 10Anomie) [20:24:18] 3Wikimedia / 3Site requests: Remove GWToolset extension from Commons as no community consensus has been provided to install it - 10https://bugzilla.wikimedia.org/67211#c6 (10Greg Grossmeier) (In reply to Rainer Rillke @commons.wikimedia from comment #5) > Of course don't take this bug seriously as GWToolset... [20:26:19] 3Wikimedia / 3Site requests: Remove GWToolset extension from Commons as no community consensus has been provided to install it - 10https://bugzilla.wikimedia.org/67211#c7 (10Steinsplitter) I agree with Rillke, The issue is that I used to be able to edit all pages as admin before and the extension imposed res... [20:26:36] (03PS1) 10Chad: WIP: Begin indexing file metadata [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/142692 [20:27:17] James_F: Braving DI, eh? [20:27:26] marktraceur: DI? [20:27:29] (03CR) 10Chad: "Definitely a WIP, haven't figured out how to query this data yet. Just wanted to get my initial proof of concept up for review (mainly to " [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/142692 (owner: 10Chad) [20:27:38] marktraceur: Oh, yeah, I was helping K4 a bit. [20:27:38] DonationInterface [20:27:47] 3MediaWiki extensions / 3Translate: Trying to change group state, selector stuck in "Setting..." - 10https://bugzilla.wikimedia.org/62957#c7 (10Tomasz W. Kozlowski) Thanks, Niklas —– this has been bothering me for a while, but I never got around to actually reporting the behaviour. I'm glad it's fixed now.... [20:27:53] bd [20:28:31] marktraceur: So far I've made a bunch of fun changes. :-) [20:29:35] (03PS1) 10Ottomata: Now using CDH5 for role::analytics [vagrant] - 10https://gerrit.wikimedia.org/r/142698 [20:29:35] 7~Yay [20:29:37] Yay* [20:31:21] (03PS1) 10tosfos: initial code [extensions/AddMessages] - 10https://gerrit.wikimedia.org/r/142699 [20:34:36] James_F: noticed you assigned some IE bugs. Does this mean there is action on IE? [20:35:20] (also, my IE need has changed to IE 11) [20:35:22] hexmode: There is action, but bugs being triaged doesn't mean that they're being worked on immediately. :-) [20:35:30] Right. [20:35:36] James_F: I can hope! [20:35:51] (03CR) 10tosfos: [C: 032 V: 032] initial code [extensions/AddMessages] - 10https://gerrit.wikimedia.org/r/142699 (owner: 10tosfos) [20:35:52] Right now we've got IE11 sort-of-maybe-ish not completely broken (lots of bugs being reported to Microsft). [20:35:55] It's fun! [20:35:56] (03Merged) 10jenkins-bot: initial code [extensions/AddMessages] - 10https://gerrit.wikimedia.org/r/142699 (owner: 10tosfos) [20:35:58] (03PS1) 10SPQRobin: Add link on Special:Upload to edit MediaWiki:Licenses [core] - 10https://gerrit.wikimedia.org/r/142700 [20:36:32] 3MediaWiki / 3Page editing: Creating a Draft article should automatically add {{Draft article}} - 10https://bugzilla.wikimedia.org/67207#c1 (10Steven Walling) (In reply to Sumana Harihareswara from comment #0) > When a person wants to create a new Draft article (on English Wikipedia), > they generally want t... [20:36:33] ooo! MSFT working to make their latest browser work with the latest sexy tech on a top internet site [20:36:38] nice [20:37:02] (03PS1) 10Jackmcbarn: Allow specifying sort keys for tracking categories [core] - 10https://gerrit.wikimedia.org/r/142701 [20:37:07] now.... a vagrant question. [20:37:46] I'm trying to set up a RH environment and getting the following error from "vagrant up" [20:38:02] 3MediaWiki extensions / 3CodeEditor: CodeEditor's drag and drop only works after a small delay - 10https://bugzilla.wikimedia.org/60432#c10 (10Eduard Braun) Has been fixed upstream (thanks Derk-Jan): https://github.com/ajaxorg/ace/commit/63f43da96a1bd2b9894c371fb0feed7e38ef34d6 Let's wait until this fix mak... [20:38:02] 3Wikimedia / 3Site requests: Remove GWToolset extension from Commons as no community consensus has been provided to install it - 10https://bugzilla.wikimedia.org/67211#c8 (10Rainer Rillke @commons.wikimedia) (In reply to Greg Grossmeier from comment #6) > Reasonable? Yeah, I'm down. (american sense :) Howev... [20:38:13] Warning: The use of 'import' is deprecated at /tmp/vagrant-puppet-1/manifests/site.pp:9. See http://links.puppetlabs.com/puppet-import-deprecation [20:38:42] also: Error: Failed to parse template mediawiki/mediawiki-apache-site.erb: [20:38:42] Filepath: /usr/lib/ruby/site_ruby/1.8/puppet/util/package.rb [20:38:43] Line: 4 [20:38:44] Detail: private method `scan' called for nil:NilClass [20:38:46] at /tmp/vagrant-puppet-1/modules-0/mediawiki/manifests/apache.pp:17 on node mediawiki-vagrant.dev [20:38:49] [20:39:08] any mw-vagrant pros around? ori? [20:41:02] https://gist.github.com/anonymous/26c17a7527a24e30f67f [20:42:47] (03PS1) 10MaxSem: More test isolation [core] - 10https://gerrit.wikimedia.org/r/142703 [20:43:18] (03PS1) 10Welterkj: Add README.md and RELEASE-NOTES.md. [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/142704 [20:44:32] 3Wikimedia / 3Site requests: Remove GWToolset extension from Commons as no community consensus has been provided to install it - 10https://bugzilla.wikimedia.org/67211#c9 (10Greg Grossmeier) (In reply to Rainer Rillke @commons.wikimedia from comment #8) > (In reply to Greg Grossmeier from comment #6) > > Rea... [20:44:45] (03CR) 10Yaron Koren: [C: 032 V: 032] "This looks great!" [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/139293 (owner: 10tosfos) [20:45:02] 3MediaWiki / 3Documentation: Clear documentation should be provided about the *my* permissions - 10https://bugzilla.wikimedia.org/67167 (10Kunal Mehta (Legoktm)) [20:45:34] greg-g, hi :) [20:46:47] (03CR) 10jenkins-bot: [V: 04-1] More test isolation [core] - 10https://gerrit.wikimedia.org/r/142703 (owner: 10MaxSem) [20:47:45] James_F: is there a mailing list I can use to send to the VE dev team? [20:48:03] hexmode: RH == Red Hat ? [20:48:12] marxarelli: yep [20:48:31] hexmode: i'm not sure we're supporting that, but it could have to do with the version of puppet running [20:48:39] I know mw-v doesn't have RH support right now, but I'm hoping to add it [20:49:02] there might be some porting to puppet 3 that needs to happens [20:49:03] marxarelli: right, but I got the version from puppetlabs [20:49:09] ah [20:49:23] I'll see if I can find an older puppet [20:49:30] awight: Public mailing list? Wikitext-l? Wikitech-l? [20:49:35] (Thought that might be it.) [20:49:45] (03PS1) 10Aaron Schulz: Close process handles after the fail instead of just on slot respawn [services/jobrunner] - 10https://gerrit.wikimedia.org/r/142716 [20:49:50] James_F: rad, thx [20:49:54] i'd recommend 2.7 for now, unless you're willing to refactor the manifests as part of the RH support :) [20:49:59] (03PS2) 10Ottomata: Now using CDH5 for role::analytics [vagrant] - 10https://gerrit.wikimedia.org/r/142698 [20:50:13] marxarelli: one headache is enough. 2.7 it is! [20:50:26] hexmode: otherwise, file a ticket and i'll see about getting to work on it in the near future [20:50:37] (03PS3) 10Ottomata: Now using CDH5 for role::analytics [vagrant] - 10https://gerrit.wikimedia.org/r/142698 [20:50:49] oh, I'll file a bug... No problem there. [20:50:52] hexmode: i'm taking some mw-vagrant development off of ori's plate [20:51:00] * hexmode warms up his bugzilla tab [20:51:23] marxarelli: cool! ori was overloaded anyway it looked like. [20:51:35] (03CR) 10Yaron Koren: [C: 032 V: 032] "Fantastic." [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/142634 (owner: 10tosfos) [20:51:44] (Which is just the sort of problem really productive people like ori run into...) [20:52:05] most definitely, hhvm is a big project [20:52:34] (03PS2) 10MaxSem: More test isolation [core] - 10https://gerrit.wikimedia.org/r/142703 [20:54:05] (03PS64) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [20:54:45] marxarelli: bugzilla ID so I can CC you on this bug? [20:55:13] dduvall [20:55:26] (03CR) 10jenkins-bot: [V: 04-1] First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [20:55:58] (03CR) 10Jqnatividad: "Sorry I didn't see your comment about benchmarks till now, but in nycpedia, there is a pronounced difference when Memcached is down, but t" [core] - 10https://gerrit.wikimedia.org/r/104663 (owner: 10Jqnatividad) [20:56:31] (03CR) 10Florianschmidtwelzow: [C: 032] Drop index from primary key [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142556 (owner: 10Hashar) [20:58:04] 3MediaWiki-Vagrant: Support newer puppet (3.6.x) - 10https://bugzilla.wikimedia.org/67214 (10Mark A. Hershberger) 3NEW p:3Unprio s:3normal a:3Ori Livneh When trying to run "vagrant provision" against the latest puppet (3.6.2) I get the following output: Warning: The use of 'import' is deprecated at... [20:58:22] (03PS1) 10Cmcmahon: Make Preferences tests language-agnostic [core] - 10https://gerrit.wikimedia.org/r/142720 [20:58:25] hexmode: cool, thanks [20:58:29] np [20:59:02] (03CR) 10CSteipp: phutil oauth adapter for mediawiki oauth1 (033 comments) [phabricator/libphutil] - 10https://gerrit.wikimedia.org/r/139438 (owner: 1020after4) [20:59:38] (03PS5) 10CSteipp: phutil oauth adapter for mediawiki oauth1 [phabricator/libphutil] - 10https://gerrit.wikimedia.org/r/139438 (owner: 1020after4) [21:00:02] 3MediaWiki-Vagrant: VisualEditor fails to provision with rbenv error - 10https://bugzilla.wikimedia.org/66764#c3 (10Dan Duvall) Matthew, Would you mind trying this again in case the fix to bug #66763 was related? Thanks! [21:01:35] (03CR) 10CSteipp: [C: 031] "With the changes I put in, this is working against labs, and should be a reasonable patchset to use for our initial setup." [phabricator/libphutil] - 10https://gerrit.wikimedia.org/r/139438 (owner: 1020after4) [21:01:41] greg-g, hi :) [21:02:29] (03CR) 10CSteipp: [C: 031] Updated @csteipp's initial proof of concept implementation of mediawiki oauth provider. This is now configurable to work with a user-specifi [phabricator/phabricator] - 10https://gerrit.wikimedia.org/r/139442 (owner: 1020after4) [21:02:49] (03PS1) 10Aaron Schulz: Added more tolerance for config whitespace [services/jobrunner] - 10https://gerrit.wikimedia.org/r/142722 [21:05:06] (03CR) 10Cmcmahon: "tested in he, de, and bare wiki" [core] - 10https://gerrit.wikimedia.org/r/142720 (owner: 10Cmcmahon) [21:06:25] (03CR) 10Hashar: "The GoogleLogin now has unit tests run by Jenkins and they are passing! :-D" [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142556 (owner: 10Hashar) [21:08:08] (03CR) 10Florianschmidtwelzow: "Yeah i see :D Big thanks for that! I was wondering, that jenkins posted comments to a change for GoogleLogin :P" [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142556 (owner: 10Hashar) [21:11:40] (03PS65) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [21:17:22] (03PS5) 10CSteipp: Initial proof of concept implementation of MediaWiki OAuth provider [phabricator/phabricator] - 10https://gerrit.wikimedia.org/r/139442 (owner: 1020after4) [21:18:16] (03PS1) 10MaxSem: Fix RequestContextTest screwing up $wgUser [core] - 10https://gerrit.wikimedia.org/r/142726 [21:21:11] (03PS66) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [21:22:02] (03CR) 10Ori.livneh: [C: 032] Fix RequestContextTest screwing up $wgUser [core] - 10https://gerrit.wikimedia.org/r/142726 (owner: 10MaxSem) [21:25:58] (03Merged) 10jenkins-bot: Fix RequestContextTest screwing up $wgUser [core] - 10https://gerrit.wikimedia.org/r/142726 (owner: 10MaxSem) [21:35:33] (03CR) 10Jack Phoenix: [C: 032 V: 032] "Thanks for the patch! :-)" [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/142559 (owner: 10Umherirrender) [21:35:34] 3MediaWiki / 3General/Unknown: Tracking bug (tracking) - 10https://bugzilla.wikimedia.org/2007 (10Antoine "hashar" Musso) [21:35:35] (03CR) 10Jack Phoenix: [C: 032 V: 032] "Thanks for the patch! :-)" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/142568 (owner: 10Umherirrender) [21:35:37] (03CR) 10Jack Phoenix: [C: 032 V: 032] "Thanks for the patch! :-)" [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/142573 (owner: 10Umherirrender) [21:35:39] (03CR) 10Jack Phoenix: [C: 032 V: 032] "Thanks for the patch! :-)" [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/142604 (owner: 10Umherirrender) [21:35:41] (03CR) 10Jack Phoenix: [C: 032 V: 032] "Thanks for the patch! :-)" [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/142608 (owner: 10Umherirrender) [21:35:43] (03CR) 10Jack Phoenix: [C: 032 V: 032] "Thanks for the patch! :-)" [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/142610 (owner: 10Umherirrender) [21:36:39] (03CR) 10Spage: "How will this adapt when we render stock icons using WikiFont? There's a .tickmark already in https://www.mediawiki.org/wiki/Design/Wikif" [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [21:41:47] 3MediaWiki extensions / 3Scribunto: HHVM: Assertion in Scribunto_LuaEngine::callParserFunction() during uksort() call - 10https://bugzilla.wikimedia.org/66943 (10Antoine "hashar" Musso) [21:41:47] 3MediaWiki extensions / 3Scribunto: HHVM: assertion from optimizedCallIniGet - 10https://bugzilla.wikimedia.org/66942 (10Antoine "hashar" Musso) [21:41:49] 3MediaWiki extensions / 3Translate: SpecialPagesTest::testSpecialPage errors with: array_merge() expects at least 1 parameter, 0 given - 10https://bugzilla.wikimedia.org/67036 (10Antoine "hashar" Musso) [21:42:02] 3MediaWiki extensions / 3ZeroRatedMobileAccess: ZeroPortal unit tests throws Warning: JsonConfig: Invalid $wgJsonConfigs['JsonZeroConfig']['url']: API URL is not set ... - 10https://bugzilla.wikimedia.org/67142 (10Antoine "hashar" Musso) [21:42:02] 3MediaWiki extensions / 3Spam Blacklist: Enabling SpamBlacklist breaks EditPageTest in core - 10https://bugzilla.wikimedia.org/67043 (10Antoine "hashar" Musso) [21:42:02] 3MediaWiki extensions / 3Math: Math tests dies when run with the Echo extensions - 10https://bugzilla.wikimedia.org/67148 (10Antoine "hashar" Musso) [21:42:03] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures unit tests trigger notices in MobileFrontend - 10https://bugzilla.wikimedia.org/67139 (10Antoine "hashar" Musso) [21:42:04] 3MediaWiki extensions / 3Gadgets: Gadgets: Fix failing unit test "GadgetsTest::testPreferences: isset( $options['<gadget-section-keep-section2>'] )" - 10https://bugzilla.wikimedia.org/67060 (10Antoine "hashar" Musso) [21:42:05] 3MediaWiki extensions / 3BetaFeatures: AutoEnrollmentTest produce a fatal error with OATHAuth extension - 10https://bugzilla.wikimedia.org/67138 (10Antoine "hashar" Musso) [21:42:15] (03CR) 10Rush: [C: 032] "thanks guys, will report back" [phabricator/libphutil] - 10https://gerrit.wikimedia.org/r/139438 (owner: 1020after4) [21:42:18] rillke1: heya [21:42:21] (03CR) 10Rush: [V: 032] "thanks guys, will report back" [phabricator/libphutil] - 10https://gerrit.wikimedia.org/r/139438 (owner: 1020after4) [21:42:26] rillke1: sorry, was afk for a second [21:42:37] (03CR) 10Rush: [C: 032 V: 032] Initial proof of concept implementation of MediaWiki OAuth provider [phabricator/phabricator] - 10https://gerrit.wikimedia.org/r/139442 (owner: 1020after4) [21:45:53] greg-g, sorry as well; do you have a page in addition to https://meta.wikimedia.org/wiki/Requesting_wiki_configuration_changes [21:46:15] showing what kind of community consensus is appropriate for a project? [21:46:42] no, the main place I work from is https://www.mediawiki.org/wiki/Review_queue (linked from that page) [21:46:44] I guess that not every project has the same procedures [21:46:59] which just has a undefined last requirement of "show support" basically :) [21:48:17] 3Wikimedia / 3Site requests: Allow admins to edit GWToolset namespace on Commons - 10https://bugzilla.wikimedia.org/67209#c27 (10Rainer Rillke @commons.wikimedia) https://commons.wikimedia.org/wiki/Commons:Requests_for_comment/New_extensions anyone is invited to improve that page and make it known [21:49:53] ty [21:50:20] thedj, around? [21:50:29] thedj[laptop], ^ [21:50:58] (03CR) 10Bartosz Dziewoński: "This looks like it would also solve bug 25909 / bug 21383." [core] - 10https://gerrit.wikimedia.org/r/142668 (owner: 10Anomie) [21:51:42] (03CR) 10Ori.livneh: [C: 032] Added more tolerance for config whitespace [services/jobrunner] - 10https://gerrit.wikimedia.org/r/142722 (owner: 10Aaron Schulz) [21:51:49] (03CR) 10Ori.livneh: [V: 032] Added more tolerance for config whitespace [services/jobrunner] - 10https://gerrit.wikimedia.org/r/142722 (owner: 10Aaron Schulz) [21:52:46] (03PS2) 10Aaron Schulz: Close process handles after they fail instead of just on slot respawn [services/jobrunner] - 10https://gerrit.wikimedia.org/r/142716 [21:53:47] 3MediaWiki / 3Parser: PAGESINCATEGORY should decode HTML entities of input - 10https://bugzilla.wikimedia.org/67196#c2 (10Philippe Verdy) There's a workaround which is to redecode the parameter of PAGESINCATEGORY with #titleparts. But I'ms still convinced that we should not have to use this trick in wikicod... [21:59:49] (03PS1) 10Florianschmidtwelzow: Handle Exceptions more stable [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142729 (https://bugzilla.wikimedia.org/67185) [21:59:51] (03CR) 10jenkins-bot: [V: 04-1] Handle Exceptions more stable [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142729 (https://bugzilla.wikimedia.org/67185) (owner: 10Florianschmidtwelzow) [22:00:25] (03PS2) 10Florianschmidtwelzow: Handle Exceptions more stable [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142729 (https://bugzilla.wikimedia.org/67185) [22:02:20] 3MediaWiki extensions / 3GoogleLogin: Move main logic out of SpecialPage - 10https://bugzilla.wikimedia.org/67219 (10Florian) 3NEW p:3Unprio s:3minor a:3None The main functions and logic should be not in SpecialPage file, move to a new class. [22:02:34] 3MediaWiki extensions / 3GoogleLogin: Move main logic out of SpecialPage - 10https://bugzilla.wikimedia.org/67219 (10Florian) p:5Unprio>3Normal s:5minor>3enhanc a:3Florian [22:02:46] I guess not [22:05:59] (03CR) 10SPQRobin: [C: 031] "I suppose it is ready to be merged now, before there is again a conflict in the release notes :)" [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [22:07:18] (03Abandoned) 10Ori.livneh: facter example for otto, do not merge [vagrant] - 10https://gerrit.wikimedia.org/r/142627 (owner: 10Ori.livneh) [22:07:23] (03CR) 10Bartosz Dziewoński: "(Shameless plug, using https://github.com/MatmaRex/mediawikireleasenotes-driver help with these conflicts.)" [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [22:08:42] (03PS1) 10Mattflaschen: Accept Redis integer replies without unserialize error [core] - 10https://gerrit.wikimedia.org/r/142734 [22:09:17] 3MediaWiki / 3General/Unknown: #switch or #ifeq: checks should be HTML escaped - 10https://bugzilla.wikimedia.org/35628#c11 (10Philippe Verdy) The problem affects templates trying to map a subpagename as a language code. Currently {{#language:code1|code2}} causes a fatal server error (HTTP error 500) and all... [22:10:55] (03CR) 10Mattflaschen: [C: 04-2] "Going to try it a different way." [core] - 10https://gerrit.wikimedia.org/r/142734 (owner: 10Mattflaschen) [22:14:47] (03CR) 10Aaron Schulz: [C: 032] First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [22:15:18] 3Wikimedia / 3Site requests: Remove GWToolset extension from Commons as no community consensus has been provided to install it - 10https://bugzilla.wikimedia.org/67211#c10 (10Rainer Rillke @commons.wikimedia) I suggest that extensions affecting user rights and protection structures must be somehow passed by... [22:15:26] (03PS2) 10Mattflaschen: Don't unserialize integer reply from Redis incrBy [core] - 10https://gerrit.wikimedia.org/r/142734 [22:16:47] (03PS3) 10Legoktm: Only allow 'globaluserpage' preference to be set on Special:GlobalPreferences [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/141272 [22:17:24] (03CR) 10Mattflaschen: "Ready for review. I just removed the ->unserialize from the incrBy call. It should not be necessary, per testing and http://redis.io/com" [core] - 10https://gerrit.wikimedia.org/r/142734 (owner: 10Mattflaschen) [22:17:50] (03PS1) 10Pcoombe: Prevent blocked users from signing petitions [extensions/Petition] - 10https://gerrit.wikimedia.org/r/142737 (https://bugzilla.wikimedia.org/65850) [22:17:56] (03CR) 10jenkins-bot: [V: 04-1] Prevent blocked users from signing petitions [extensions/Petition] - 10https://gerrit.wikimedia.org/r/142737 (https://bugzilla.wikimedia.org/65850) (owner: 10Pcoombe) [22:18:19] (03CR) 10jenkins-bot: [V: 04-1] First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [22:21:23] wheee kunalg [22:22:17] (03CR) 10Aaron Schulz: [C: 032] "What matters is https://github.com/nicolasff/phpredis#incr-incrby which seems to return integers. This should be fine." [core] - 10https://gerrit.wikimedia.org/r/142734 (owner: 10Mattflaschen) [22:23:03] (03PS3) 10Mattflaschen: Don't unserialize integer reply from Redis incrBy [core] - 10https://gerrit.wikimedia.org/r/142734 [22:23:05] (03PS1) 10Legoktm: Use new "disableeditsection" parameter to action=parse [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/142738 [22:24:35] (03CR) 10Aaron Schulz: [C: 032] Don't unserialize integer reply from Redis incrBy [core] - 10https://gerrit.wikimedia.org/r/142734 (owner: 10Mattflaschen) [22:24:36] (03CR) 10Nemo bis: "Is that right?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [22:24:44] (03PS1) 10Physikerwelt: Fix MathDatabaseTest [extensions/Math] - 10https://gerrit.wikimedia.org/r/142739 (https://bugzilla.wikimedia.org/67148) [22:25:25] (03PS4) 10Mattflaschen: Don't unserialize integer reply from Redis incrBy [core] - 10https://gerrit.wikimedia.org/r/142734 [22:26:25] AaronSchulz, sorry for the thrashing on the docs. [22:26:37] (03CR) 10jenkins-bot: [V: 04-1] Fix MathDatabaseTest [extensions/Math] - 10https://gerrit.wikimedia.org/r/142739 (https://bugzilla.wikimedia.org/67148) (owner: 10Physikerwelt) [22:26:47] (03CR) 10Nemo bis: "Hm, I gather that to pass that test we need to add the "pagelang" permission by default to sysop group, except that it will do nothing unl" [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [22:26:53] (03PS2) 10Pcoombe: Prevent blocked users from signing petitions [extensions/Petition] - 10https://gerrit.wikimedia.org/r/142737 (https://bugzilla.wikimedia.org/65850) [22:27:01] (03PS1) 10Legoktm: Stop hiding some CSS classes [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/142740 [22:27:07] (03CR) 10Aaron Schulz: [C: 032] Don't unserialize integer reply from Redis incrBy [core] - 10https://gerrit.wikimedia.org/r/142734 (owner: 10Mattflaschen) [22:30:16] (03Merged) 10jenkins-bot: Don't unserialize integer reply from Redis incrBy [core] - 10https://gerrit.wikimedia.org/r/142734 (owner: 10Mattflaschen) [22:30:34] 3MediaWiki extensions / 3GoogleLogin: Allow to restrict access to special E-Maildomains - 10https://bugzilla.wikimedia.org/67220 (10Florian) 3NEW p:3Unprio s:3enhanc a:3None See https://github.com/Florianschmidtwelzow/mediawiki-googlelogin/issues/2 Feature request: "Is is possible to restrict the lo... [22:30:39] (03PS2) 10Physikerwelt: Fix MathDatabaseTest [extensions/Math] - 10https://gerrit.wikimedia.org/r/142739 (https://bugzilla.wikimedia.org/67148) [22:31:58] (03PS2) 10Physikerwelt: Port browser test for Math extension from the /qa/browsertest repo [extensions/Math] - 10https://gerrit.wikimedia.org/r/141472 (owner: 10Cmcmahon) [22:32:16] (03PS67) 10Nemo bis: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [22:32:25] (03CR) 10jenkins-bot: [V: 04-1] Fix MathDatabaseTest [extensions/Math] - 10https://gerrit.wikimedia.org/r/142739 (https://bugzilla.wikimedia.org/67148) (owner: 10Physikerwelt) [22:32:36] (03CR) 10SPQRobin: "Hmm, I already got the same error in https://gerrit.wikimedia.org/r/#/c/137033/ (which depends on this change). Strange that it didn't fai" [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [22:32:45] (03PS1) 10Florianschmidtwelzow: Add feature $wgGoogleAllowedDomains to restrict E-Maildomains [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142741 (https://bugzilla.wikimedia.org/67220) [22:34:13] (03CR) 10Physikerwelt: [C: 031] "I appreciate this idea." [extensions/Math] - 10https://gerrit.wikimedia.org/r/141472 (owner: 10Cmcmahon) [22:34:33] (03CR) 10Nemo bis: "That's because Kunal is not whitelisted, let's hear jenkins' verdict on PS67." [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [22:34:47] o.O [22:35:09] (03PS3) 10Physikerwelt: Fix MathDatabaseTest [extensions/Math] - 10https://gerrit.wikimedia.org/r/142739 (https://bugzilla.wikimedia.org/67148) [22:35:28] (03PS1) 10CSteipp: JWT namespace [extensions/OAuth] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142742 [22:35:33] (03PS68) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [22:36:18] (03PS6) 10Physikerwelt: Update modules/ext.math.css [extensions/Math] - 10https://gerrit.wikimedia.org/r/139120 (owner: 10Frédéric Wang) [22:36:21] (03CR) 10CSteipp: [C: 032] "+2'ed in master by Reedy" [extensions/OAuth] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142742 (owner: 10CSteipp) [22:36:33] Nemo_bis: huh, whitelisted in what way? [22:36:53] (03Merged) 10jenkins-bot: JWT namespace [extensions/OAuth] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142742 (owner: 10CSteipp) [22:38:44] (03PS69) 10Nemo bis: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [22:39:27] (03CR) 10Nemo bis: "LOL edit conflict. Had to edit the commit message, please Kunal don't amend again or jenkins will not run the full test. :)" [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [22:39:56] SPQRobin: if you're whitelisted in some list, then jenkins runs the +2 tests for you [22:40:03] integration/zuul I think [22:41:10] SPQRobin: https://github.com/wikimedia/integration-zuul-config/blob/master/layout.yaml#L39 [22:42:03] (03CR) 10Cmcmahon: "No risk here." [extensions/Math] - 10https://gerrit.wikimedia.org/r/141472 (owner: 10Cmcmahon) [22:42:44] (03CR) 10jenkins-bot: [V: 04-1] First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [22:43:30] (03Abandoned) 10Legoktm: Add stub method to make extension 1.21 compatible [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139665 (owner: 10Yuvipanda) [22:43:47] (03CR) 10Cmcmahon: [C: 032] "Merging this per the +1 from Physikerwelt, thanks" [extensions/Math] - 10https://gerrit.wikimedia.org/r/141472 (owner: 10Cmcmahon) [22:43:55] (03CR) 10Nemo bis: "No luck: https://integration.wikimedia.org/ci/job/mediawiki-core-phpunit-misc/27289/testReport/%28root%29/UserTest/testAllRightsWithMessag" [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [22:44:12] (03CR) 10Jack Phoenix: [C: 032 V: 032] Only allow 'globaluserpage' preference to be set on Special:GlobalPreferences [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/141272 (owner: 10Legoktm) [22:44:14] (03CR) 10Jack Phoenix: [C: 032 V: 032] Use new "disableeditsection" parameter to action=parse [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/142738 (owner: 10Legoktm) [22:44:16] (03CR) 10Jack Phoenix: [C: 032 V: 032] Stop hiding some CSS classes [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/142740 (owner: 10Legoktm) [22:44:18] legoktm: oh, I see, thanks. But why should it not run the tests for anyone? [22:44:46] because then anyone would be able to run arbitrary php code inside the cluster [22:44:58] there's a plan to move it to isolated VMs so tests get run for everyone though [22:45:06] (03CR) 10jenkins-bot: [V: 04-1] Port browser test for Math extension from the /qa/browsertest repo [extensions/Math] - 10https://gerrit.wikimedia.org/r/141472 (owner: 10Cmcmahon) [22:45:32] (03CR) 10Physikerwelt: Adding a JS Class to inputBox to grey out Submit button. (032 comments) [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 (https://bugzilla.wikimedia.org/61606) (owner: 1001tonythomas) [22:47:18] (03CR) 10Physikerwelt: [V: 032] Port browser test for Math extension from the /qa/browsertest repo [extensions/Math] - 10https://gerrit.wikimedia.org/r/141472 (owner: 10Cmcmahon) [22:49:16] (03PS1) 10CSteipp: Update OAuth to fix logins [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142745 [22:50:13] (03CR) 10CSteipp: [C: 032] Update OAuth to fix logins [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142745 (owner: 10CSteipp) [22:52:04] (03CR) 10Physikerwelt: Update modules/ext.math.css (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/139120 (owner: 10Frédéric Wang) [22:52:26] (03PS4) 10Florianschmidtwelzow: Show Captcha after click on edit over buttons on EditPage [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/136323 (https://bugzilla.wikimedia.org/65913) [22:52:45] (03CR) 10SPQRobin: "I see the problem, the right needs to be added in User.php. I'll add it now." [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [22:53:50] (03Merged) 10jenkins-bot: Update OAuth to fix logins [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142745 (owner: 10CSteipp) [22:57:54] (03PS70) 10SPQRobin: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [22:58:36] That should be documented somewhere [22:59:37] (03PS1) 10Jforrester: maintenance: Simpler OOjs UI pullthrough-script [core] - 10https://gerrit.wikimedia.org/r/142747 [22:59:58] SPQRobin: uh, with underscore? https://gerrit.wikimedia.org/r/#/c/135312/69..70/includes/User.php,cm [23:00:15] hmm, oops [23:00:46] (03PS5) 10Florianschmidtwelzow: Show Captcha after click on edit over buttons on EditPage [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/136323 (https://bugzilla.wikimedia.org/65913) [23:01:12] (03PS71) 10SPQRobin: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [23:01:59] https://www.mediawiki.org/wiki/Category:Permission is not very useful [23:04:03] Is this supposed to be the documentation? A list of core user rights is available in User.php, $mCoreRights. https://www.mediawiki.org/wiki/Manual:$wgAvailableRights [23:04:05] (03PS2) 10Jforrester: maintenance: Simpler OOjs UI pullthrough-script [core] - 10https://gerrit.wikimedia.org/r/142747 [23:04:07] (03CR) 10Ori.livneh: [C: 032] Close process handles after they fail instead of just on slot respawn [services/jobrunner] - 10https://gerrit.wikimedia.org/r/142716 (owner: 10Aaron Schulz) [23:04:19] (03CR) 10Krinkle: [C: 032] maintenance: Simpler OOjs UI pullthrough-script [core] - 10https://gerrit.wikimedia.org/r/142747 (owner: 10Jforrester) [23:07:08] Nemo_bis: standard level of documentation for MediaWiki :p [23:07:31] !bug 1 | Nemo_bis [23:07:31] Nemo_bis: https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=1+ [23:07:37] * Reedy kicks wm-bot [23:08:36] (03Merged) 10jenkins-bot: maintenance: Simpler OOjs UI pullthrough-script [core] - 10https://gerrit.wikimedia.org/r/142747 (owner: 10Jforrester) [23:11:43] * Nemo_bis shakes head at Reedy [23:11:48] Nemo_bis: so I guess we need an equivalent of https://www.mediawiki.org/wiki/Manual:User_rights for adding new rights as a developer [23:12:06] How could I consume 655 bytes for it? Well, I did: https://www.mediawiki.org/w/index.php?title=Manual:User_rights&diff=prev&oldid=1051974 [23:12:56] SPQRobin: to create a new manual page I first demand death of another to keep balance in the universe. Why is https://www.mediawiki.org/wiki/Manual:Setting_user_groups_in_MediaWiki not merged to a help page? [23:13:05] (03PS1) 10CSteipp: Check for http:// in JWT issuer check [phabricator/libphutil] - 10https://gerrit.wikimedia.org/r/142748 [23:15:12] Or do we really need one manual for dev, one for sysadmin and one for wiki admin, plus help pages? :/ [23:15:38] yay jenkins is happy, someone +2 https://gerrit.wikimedia.org/r/135312 [23:15:48] Nemo_bis: ok, the section you added is fine of course :p And that page indeed seems redundant.. [23:17:48] (03CR) 10Rush: [C: 032 V: 032] Check for http:// in JWT issuer check [phabricator/libphutil] - 10https://gerrit.wikimedia.org/r/142748 (owner: 10CSteipp) [23:18:26] Nemo_bis: hmm, I had commented out the user right :p I should update the commit message again [23:19:32] 3Wikimedia / 3SSL related: Add Forward Secrecy - 10https://bugzilla.wikimedia.org/53259#c7 (10Nemo) Giuseppe tested the settings, proving the load is not a problem, and thanks to this the change is now scheduled for next week! https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20140701T1000 [23:19:54] And release notes? [23:22:04] :/ [23:24:43] (03PS5) 10Ori.livneh: Fix CSSMin url() remapping when comments in CSS contain curly braces [core] - 10https://gerrit.wikimedia.org/r/139268 (https://bugzilla.wikimedia.org/60077) (owner: 10Foxtrott) [23:24:50] (03PS72) 10SPQRobin: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [23:25:16] 72, now this should reaaally be the last one :p [23:25:32] (03CR) 10Ori.livneh: [C: 031] "Thanks for the patch! (And for writing tests, woo!)" [core] - 10https://gerrit.wikimedia.org/r/139268 (https://bugzilla.wikimedia.org/60077) (owner: 10Foxtrott) [23:27:09] (03PS73) 10Nemo bis: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [23:27:17] Actually not! Sentence needed a fix. [23:27:57] ugh [23:29:50] (03PS3) 10Withoutaname: Moved Article::render() to RenderAction::show() [core] - 10https://gerrit.wikimedia.org/r/141359 [23:30:01] Nemo_bis: I should look twice before committing :p [23:31:05] (03CR) 10jenkins-bot: [V: 04-1] Moved Article::render() to RenderAction::show() [core] - 10https://gerrit.wikimedia.org/r/141359 (owner: 10Withoutaname) [23:34:48] (03CR) 10Aaron Schulz: [C: 032] First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [23:35:32] (03PS2) 10Legoktm: Add OutputPageScriptsForBottomQueue hook [core] - 10https://gerrit.wikimedia.org/r/141282 (https://bugzilla.wikimedia.org/62602) [23:37:10] (03CR) 10Legoktm: "@Krinkle: done." [core] - 10https://gerrit.wikimedia.org/r/141282 (https://bugzilla.wikimedia.org/62602) (owner: 10Legoktm) [23:38:37] (03Merged) 10jenkins-bot: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [23:38:43] (03PS3) 10Legoktm: Use new OutputPageScriptsForBottomQueue hook [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/141284 (https://bugzilla.wikimedia.org/62602) [23:39:06] (03PS1) 10Jforrester: Follow-up I81663929: Use grunt git-build to ensure we get the hash [core] - 10https://gerrit.wikimedia.org/r/142752 [23:39:23] At last.. [23:40:28] Hm, now what [23:40:35] Revert! [23:40:51] PARTY! [23:40:52] :p [23:41:25] (03CR) 10Krinkle: [C: 032] Follow-up I81663929: Use grunt git-build to ensure we get the hash [core] - 10https://gerrit.wikimedia.org/r/142752 (owner: 10Jforrester) [23:41:32] (03CR) 10Nemo bis: "Needs rebase" [core] - 10https://gerrit.wikimedia.org/r/136623 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [23:43:16] That'll be a fun production schema change ;) [23:44:14] I saw there is already quite a backlog [23:45:00] (03Merged) 10jenkins-bot: Follow-up I81663929: Use grunt git-build to ensure we get the hash [core] - 10https://gerrit.wikimedia.org/r/142752 (owner: 10Jforrester) [23:45:38] If it's wanted on production, someone better create a ticket for it ;) [23:46:15] (03CR) 10Kunalgrover05: "Umm. I will abandon this, it is of no use." [core] - 10https://gerrit.wikimedia.org/r/136623 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [23:46:30] https://bugzilla.wikimedia.org/show_bug.cgi?id=49188 [23:46:35] Quite a few look optional esk [23:46:37] (03Abandoned) 10Kunalgrover05: Front end for page language selector(DONT MERGE) [core] - 10https://gerrit.wikimedia.org/r/136623 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [23:47:37] (03PS1) 10Legoktm: Fix typo [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/142755 [23:48:42] (03CR) 10Legoktm: [C: 032 V: 032] Fix typo [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/142755 (owner: 10Legoktm) [23:48:52] (03CR) 10Aaron Schulz: [V: 032] Close process handles after they fail instead of just on slot respawn [services/jobrunner] - 10https://gerrit.wikimedia.org/r/142716 (owner: 10Aaron Schulz) [23:50:05] I'm filing it [23:50:35] Nemo_bis: ah, I was about to :p [23:51:48] 3Wikimedia / 3General/Unknown: Schema changes for Wikimedia wikis (tracking) - 10https://bugzilla.wikimedia.org/49188#c5 (10Sam Reed (reedy)) Part of me wonders if we should create a derivative of this bug for stuff that is just cleanup (ie dropping old columns etc), versus those needed to add/enable feature... [23:51:56] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (a63f03882e) [core] - 10https://gerrit.wikimedia.org/r/142756 [23:53:53] err: /Stage[main]/Multiwiki/File[/vagrant/settings.d/multiwiki]/owner: change from 502 to vagrant failed: Failed to set owner to '1001': Operation not permitted - /vagrant/settings.d/multiwiki [23:53:56] hm :/ [23:54:13] (03PS1) 10Aaron Schulz: Hide spammy output behind --verbose flag [services/jobrunner] - 10https://gerrit.wikimedia.org/r/142757 [23:55:31] https://bugzilla.wikimedia.org/show_bug.cgi?id=67223 [23:55:34] 3Wikimedia / 3General/Unknown: Schema changes for Wikimedia wikis (tracking) - 10https://bugzilla.wikimedia.org/49188 (10Nemo) [23:55:36] 3Wikimedia / 3General/Unknown: Schema change for page content language - 10https://bugzilla.wikimedia.org/67223 (10Nemo) 3NEW p:3Unprio s:3normal a:3None https://gerrit.wikimedia.org/r/135312 / I0f82b146fbe948f917c1c5d29f7469644d797e80 was merged in core and introduces a schema change for [[mw:page c... [23:56:21] Mid July? [23:56:21] Haha [23:56:32] lol [23:56:32] "Currently" :P [23:56:35] I guess it should OSC nicely [23:56:35] (03CR) 10Nemo bis: "https://bugzilla.wikimedia.org/show_bug.cgi?id=67223 filed for the schema schange, anything else?" [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [23:56:54] Well, it needs some further improvements first anyway [23:57:22] I guess if the page table is being changed, page_content_model should probably be added at the same time [23:57:46] springle already started the *_content_model ones [23:58:02] 3MediaWiki extensions / 3Translate: The source language of a page should be arbitrary - 10https://bugzilla.wikimedia.org/35489 (10Nemo) 5PATC>3NEW [23:58:14] I thought he had.. The bug doesn't exactly say anything though [23:58:27] 05:04 springle: beginning schema changes bug 49193 page_content_model [23:58:48] When was that? :P [23:58:51] june 11 [23:59:02] 3Wikimedia / 3General/Unknown: Add ContentHandler columns to Wikimedia wikis, and set $wgContentHandlerUseDB = true - 10https://bugzilla.wikimedia.org/49193#c4 (10Kunal Mehta (Legoktm)) From June 11 SAL: 05:04 springle: beginning schema changes bug 49193 page_content_model [23:59:36] 3MediaWiki extensions / 3Popups: Hovercards: Links to titles with parentheses should also bold non-parenthesized text in extract - 10https://bugzilla.wikimedia.org/67224 (10Laurence 'GreenReaper' Parry) 3NEW p:3Unprio s:3normal a:3None Parentheses are almost always used in an article title to disambi...