[00:00:16] (03PS2) 10Shirayuki: i18n: fix typo [extensions/OdbcDatabase] - 10https://gerrit.wikimedia.org/r/142161 [00:01:04] (03Merged) 10jenkins-bot: Removed old DB_LAST cruft [core] - 10https://gerrit.wikimedia.org/r/142154 (owner: 10Aaron Schulz) [00:01:31] (03CR) 1020after4: "@rush: it's simultaneously going through review upstream: https://secure.phabricator.com/T5096" [phabricator/phabricator] - 10https://gerrit.wikimedia.org/r/139442 (owner: 1020after4) [00:01:57] (03Merged) 10jenkins-bot: Include trx state in query profiling (and DBPerformance log) [core] - 10https://gerrit.wikimedia.org/r/142026 (owner: 10Aaron Schulz) [00:03:57] (03PS1) 10Kaldari: Prevent prepareQuickTemplate from overwriting Output::mBodytext [core] - 10https://gerrit.wikimedia.org/r/142163 [00:06:33] (03PS2) 10Aaron Schulz: Also check if 'debug_backtrace' is disabled in Maintenance::shouldExecute() [core] - 10https://gerrit.wikimedia.org/r/142117 (owner: 10IAlex) [00:06:54] (03PS2) 10Kaldari: Prevent prepareQuickTemplate from overwriting $out->mBodytext [core] - 10https://gerrit.wikimedia.org/r/142163 [00:10:02] 3MediaWiki / 3Skin and page rendering: Large number of CSS rules for external links - 10https://bugzilla.wikimedia.org/54604#c61 (10Daniel Friesen) (In reply to Jon from comment #59) > Another reason is styles written in this way are not reusable. I'll add one more reason. What if we "don't" want an icon?... [00:12:24] (03PS1) 10Catrope: Remove obsolete mobile dependencies from tests so they run on desktop [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/142164 [00:12:57] (03CR) 10Aaron Schulz: [C: 032] Also check if 'debug_backtrace' is disabled in Maintenance::shouldExecute() [core] - 10https://gerrit.wikimedia.org/r/142117 (owner: 10IAlex) [00:16:27] (03Merged) 10jenkins-bot: Also check if 'debug_backtrace' is disabled in Maintenance::shouldExecute() [core] - 10https://gerrit.wikimedia.org/r/142117 (owner: 10IAlex) [00:17:30] (03CR) 10Jdlrobson: [C: 032] Remove obsolete mobile dependencies from tests so they run on desktop [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/142164 (owner: 10Catrope) [00:18:31] (03PS1) 10Bsitu: Show extended watchlist if user has such in preference [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142167 [00:19:22] (03Merged) 10jenkins-bot: Remove obsolete mobile dependencies from tests so they run on desktop [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/142164 (owner: 10Catrope) [00:22:25] (03CR) 10Chad: Add syntax to limit searches to the local wiki (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140567 (owner: 10Manybubbles) [00:22:51] (03PS3) 10Kaldari: Prevent prepareQuickTemplate from overwriting $out->mBodytext [core] - 10https://gerrit.wikimedia.org/r/142163 [00:27:40] (03CR) 10MaxSem: [C: 04-1] "Discussed this with Ryan in person, and I'm still unsure if we really should go lengths to keep Minerva farther from core div structure." [core] - 10https://gerrit.wikimedia.org/r/142163 (owner: 10Kaldari) [00:32:07] (03CR) 10Bsitu: [C: 04-1] Hide visually broken elements in non-JavaScript site (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141990 (owner: 10Jdlrobson) [00:33:32] 3MediaWiki / 3Skin and page rendering: SVG thumbnailing doesn't work with $wgResponsiveImages - 10https://bugzilla.wikimedia.org/67081#c5 (10Mark A. Hershberger) (In reply to Brion Vibber from comment #4) > Might media wiki be configured by default with a max size for svg rendering? But, in that case, shoul... [00:35:14] (03PS3) 1020after4: phutil oauth adapter for mediawiki oauth1 [phabricator/libphutil] - 10https://gerrit.wikimedia.org/r/139438 [00:35:49] 3MediaWiki extensions / 3Mantle: Merge Mantle event emitter and OO.EventEmitter - 10https://bugzilla.wikimedia.org/67107 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None Right now, Mantle's event emitter is just a wrapper around jQuery, and its API is an exact subset of OO.EventEmitter's API (apart... [00:36:54] (03CR) 10Bsitu: [C: 032] Polish: Errors reported to the user don't show up pink [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142135 (owner: 10EBernhardson) [00:37:12] (03Merged) 10jenkins-bot: Polish: Errors reported to the user don't show up pink [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142135 (owner: 10EBernhardson) [00:40:17] (03Abandoned) 10Kaldari: Prevent prepareQuickTemplate from overwriting $out->mBodytext [core] - 10https://gerrit.wikimedia.org/r/142163 (owner: 10Kaldari) [00:40:17] 3Wikimedia / 3Deployment systems: [scap] Deployment: Repository .git is synchronised fine, but is broken for submodules because of hardcoded gitdir link - 10https://bugzilla.wikimedia.org/53972#c18 (10Bryan Davis) So when I echo $IP from `mweval` in beta I get /srv/common-local/php-master but apparently ins... [00:40:19] (03CR) 1020after4: "@csteipp: that should do it? I've addressed the mobile bug and also converted all the URLs to clean versions just for consistency and aest" [phabricator/libphutil] - 10https://gerrit.wikimedia.org/r/139438 (owner: 1020after4) [00:41:43] (03CR) 10Ori.livneh: "Slavish and pedantic adherence to enwiki specifically or production generally has never been the goal; instead the idea is just to make ch" [vagrant] - 10https://gerrit.wikimedia.org/r/141860 (owner: 10JGonera) [00:42:04] (03PS1) 10Mattflaschen: Remove explicit isBlocked(), change permission ordering to match core [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142170 [00:42:24] (03CR) 10jenkins-bot: [V: 04-1] Remove explicit isBlocked(), change permission ordering to match core [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142170 (owner: 10Mattflaschen) [00:42:57] (03PS2) 10Mattflaschen: Remove explicit isBlocked(), change permission ordering to match core [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142170 (https://bugzilla.wikimedia.org/66994) [00:43:15] (03CR) 10jenkins-bot: [V: 04-1] Remove explicit isBlocked(), change permission ordering to match core [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142170 (https://bugzilla.wikimedia.org/66994) (owner: 10Mattflaschen) [00:43:55] (03CR) 10Ori.livneh: "See https://github.com/wikimedia/mediawiki-vagrant/blob/master/settings.d/README for a more detailed discussion" [vagrant] - 10https://gerrit.wikimedia.org/r/141860 (owner: 10JGonera) [00:49:15] (03PS1) 10Brian Wolff: Check for error before outputting srcset urls [core] - 10https://gerrit.wikimedia.org/r/142172 (https://bugzilla.wikimedia.org/67081) [00:50:32] 3MediaWiki / 3Skin and page rendering: SVG thumbnailing doesn't work with $wgResponsiveImages - 10https://bugzilla.wikimedia.org/67081#c7 (10Bawolff (Brian Wolff)) That wiki couldn't make thumbs that big ( http://www.pidgi.net/wiki/api.php?action=query&prop=imageinfo&titles=File:Mario_Kart_TV_logo_%28alt%29_... [00:51:30] (03PS1) 10MaxSem: Remove $wgParserTestRemote, unused. [core] - 10https://gerrit.wikimedia.org/r/142173 [00:52:18] (03CR) 10Ori.livneh: [C: 032] "Let's kill http://www.mediawiki.org/wiki/Manual:$wgParserTestRemote too" [core] - 10https://gerrit.wikimedia.org/r/142173 (owner: 10MaxSem) [00:54:34] (03CR) 10Chad: "We don't delete old config variable pages. Just mark it as removed once this is merged." [core] - 10https://gerrit.wikimedia.org/r/142173 (owner: 10MaxSem) [00:54:49] (03PS2) 10Ori.livneh: Reimplemented ruby module to use distro packages [vagrant] - 10https://gerrit.wikimedia.org/r/140877 (https://bugzilla.wikimedia.org/66763) (owner: 10Dduvall) [00:54:52] (03CR) 10Chad: [C: 032] "Meant to do this myself last week, actually." [core] - 10https://gerrit.wikimedia.org/r/142173 (owner: 10MaxSem) [00:54:54] (03CR) 10Ori.livneh: [C: 032] Reimplemented ruby module to use distro packages [vagrant] - 10https://gerrit.wikimedia.org/r/140877 (https://bugzilla.wikimedia.org/66763) (owner: 10Dduvall) [00:54:56] (03CR) 10MaxSem: "Already marked." [core] - 10https://gerrit.wikimedia.org/r/142173 (owner: 10MaxSem) [00:55:01] (03Merged) 10jenkins-bot: Reimplemented ruby module to use distro packages [vagrant] - 10https://gerrit.wikimedia.org/r/140877 (https://bugzilla.wikimedia.org/66763) (owner: 10Dduvall) [00:55:49] (03Merged) 10jenkins-bot: Remove $wgParserTestRemote, unused. [core] - 10https://gerrit.wikimedia.org/r/142173 (owner: 10MaxSem) [00:55:51] (03CR) 10Chad: "GEEZ MAX, MAYBE I JUST WANTED TO SHOW MY SUPPORT FOR ORI'S +2 AS WELL?!?" [core] - 10https://gerrit.wikimedia.org/r/142173 (owner: 10MaxSem) [00:56:33] (03CR) 10MaxSem: "ONEONEONEONE" [core] - 10https://gerrit.wikimedia.org/r/142173 (owner: 10MaxSem) [01:04:59] (03PS4) 1020after4: Updated @csteipp's initial proof of concept implementation of mediawiki oauth provider. This is now configurable to work with a user-specified mediawiki url. Borrowed some code from the JIRA provider to implement stored provider configuration. [phabricator/phabricator] - 10https://gerrit.wikimedia.org/r/139442 [01:06:13] (03PS1) 10MaxSem: Add ParserTestTables hook handler [extensions/Echo] - 10https://gerrit.wikimedia.org/r/142177 [01:07:02] 3MediaWiki / 3Skin and page rendering: Large number of CSS rules for external links - 10https://bugzilla.wikimedia.org/54604#c62 (10Gabriel Wicke) (In reply to Jon from comment #59) > Another reason is styles written in this way are not reusable. > > What if we want to use the same audio icon elsewhere? >... [01:07:21] (03CR) 10Catrope: [C: 032] Add json2.js polyfill (v2014-02-04; with module skip function) [core] - 10https://gerrit.wikimedia.org/r/140560 (owner: 10Krinkle) [01:10:59] (03CR) 10Catrope: [C: 032] Add es5-shim library v3.4.0 [core] - 10https://gerrit.wikimedia.org/r/139308 (owner: 10Jforrester) [01:11:01] (03Merged) 10jenkins-bot: Add json2.js polyfill (v2014-02-04; with module skip function) [core] - 10https://gerrit.wikimedia.org/r/140560 (owner: 10Krinkle) [01:12:02] 3MediaWiki / 3General/Unknown: Alternate project links in sidebar - 10https://bugzilla.wikimedia.org/15407#c1 (10snaevar) Duplicate of bug 54374 [01:14:49] (03Merged) 10jenkins-bot: Add es5-shim library v3.4.0 [core] - 10https://gerrit.wikimedia.org/r/139308 (owner: 10Jforrester) [01:17:22] (03CR) 10Wctaiwan: "Note that http://www.mediawiki.org/wiki/API:Calling_internally explicitly says "If your code is just going to edit some content, please co" [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142023 (owner: 10Wctaiwan) [01:27:02] (03PS2) 10Spage: ext.mantle.modules needs ext.mantle [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137249 [01:35:22] (03CR) 10Brion VIBBER: [C: 031] "Looks like this should do the job, but I haven't had a chance to test yet." [core] - 10https://gerrit.wikimedia.org/r/142172 (https://bugzilla.wikimedia.org/67081) (owner: 10Brian Wolff) [01:40:26] <^demon|away> brion: When you get a chance, think you could have a look at https://gerrit.wikimedia.org/r/#/c/141660/? We tried merging it earlier this week but it Broke Stuff with special pages in open search results. [01:40:38] <^demon|away> I'm a little hesitant to +2 again even though I think Nikerabbit fixed things :) [01:40:59] ooh scary [01:53:40] (03CR) 10Brion VIBBER: "Test cases don't cover the multi-namespace capability. I'm also a bit worried about that query when handling separate namespaces; are we s" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/141660 (https://bugzilla.wikimedia.org/65752) (owner: 10Nikerabbit) [01:58:41] (03PS1) 10PleaseStand: Remove unused message 'postcomment' [core] - 10https://gerrit.wikimedia.org/r/142184 [02:04:48] (03PS1) 10Brian Wolff: Unescape() is never the right answer. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/142185 [02:06:32] 3MediaWiki extensions / 3Scribunto: HHVM: assertion from optimizedCallIniGet - 10https://bugzilla.wikimedia.org/66942#c2 (10Tim Starling) Updated the title since I think the first of the two assertions is more specific. Note that this assertion occurs even with LuaSandbox disabled. [02:07:12] <^demon|away> brion: Luckily we'll never hit defaultSearchBackend() in WMF, but yeah, that query is scary. [02:07:43] i think i’d rather see separate queries with a limit and have the results merged manually [02:07:49] but would want to check it in EXPLAIN first [02:19:02] 3MediaWiki / 3Skin and page rendering: Large number of CSS rules for external links - 10https://bugzilla.wikimedia.org/54604#c63 (10Daniel Friesen) (In reply to Gabriel Wicke from comment #62) > > I'd like to see us moving away from descendant selectors and explore OOCSS > > [1] as a solution to our CSS mess... [02:38:32] 3MediaWiki / 3Skin and page rendering: SVG thumbnailing doesn't work with $wgResponsiveImages - 10https://bugzilla.wikimedia.org/67081#c8 (10Mew Regions) I'm the owner of the wiki that the error is being shown on. I forgot to mention that it only appears on larger thumbnail sizes, which makes sense with the... [02:43:02] 3MediaWiki extensions / 3Scribunto: HHVM: assertion from optimizedCallIniGet - 10https://bugzilla.wikimedia.org/66942#c3 (10Tim Starling) Isolated and filed https://github.com/facebook/hhvm/issues/3037 [03:00:19] 3MediaWiki extensions / 3Scribunto: HPHP::computeMaskFromNumElms(uint32_t): Assertion `n <= 0x7fffffffU' failed. - 10https://bugzilla.wikimedia.org/66943 (10Tim Starling) [03:00:20] 3MediaWiki extensions / 3Scribunto: HHVM: assertion from optimizedCallIniGet - 10https://bugzilla.wikimedia.org/66942 (10Tim Starling) [03:40:39] (03CR) 10EBernhardson: Remove explicit isBlocked(), change permission ordering to match core (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142170 (https://bugzilla.wikimedia.org/66994) (owner: 10Mattflaschen) [03:47:37] (03CR) 10Chad: [C: 032] Made DB rollback() method properly bail out if no trx is active [core] - 10https://gerrit.wikimedia.org/r/142005 (owner: 10Aaron Schulz) [03:48:57] (03CR) 10Chad: [C: 032] Made DB commit() method properly bail out if no trx is active [core] - 10https://gerrit.wikimedia.org/r/142004 (owner: 10Aaron Schulz) [03:51:28] (03Merged) 10jenkins-bot: Made DB rollback() method properly bail out if no trx is active [core] - 10https://gerrit.wikimedia.org/r/142005 (owner: 10Aaron Schulz) [03:52:03] (03Merged) 10jenkins-bot: Made DB commit() method properly bail out if no trx is active [core] - 10https://gerrit.wikimedia.org/r/142004 (owner: 10Aaron Schulz) [04:37:57] (03CR) 10Aaron Schulz: [C: 04-1] "Mostly should work, except for a few random bits." (036 comments) [core] - 10https://gerrit.wikimedia.org/r/127460 (owner: 10Aaron Schulz) [04:38:28] (03PS1) 10EBernhardson: Split WorkflowLoader into multiple classes [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142191 [04:38:51] (03CR) 10jenkins-bot: [V: 04-1] Split WorkflowLoader into multiple classes [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142191 (owner: 10EBernhardson) [04:39:25] (03CR) 10Aaron Schulz: "Commit should be tagged with Co-Authored-By: per https://wiki.openstack.org/wiki/GitCommitMessages" [core] - 10https://gerrit.wikimedia.org/r/127460 (owner: 10Aaron Schulz) [04:57:05] (03PS2) 10EBernhardson: Split WorkflowLoader into multiple classes [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142191 [04:57:56] (03PS3) 10EBernhardson: Split WorkflowLoader into multiple classes [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142191 [05:04:02] 3MediaWiki / 3Skin and page rendering: How to design the 'Search result page' of a MediaWiki Skin? - 10https://bugzilla.wikimedia.org/67090#c2 (10Nasir Khan Saikat) Yes i want to change the generated HTML. i have seen that there are CSS class for each different block, but i already have a full prepared CSS a... [05:04:44] (03CR) 10devunt: [C: 04-1] "There is a usage in" [core] - 10https://gerrit.wikimedia.org/r/142184 (owner: 10PleaseStand) [05:09:45] (03PS4) 10EBernhardson: Split WorkflowLoader into multiple classes [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142191 [05:10:56] (03CR) 10Bartosz Dziewoński: [C: 032] skins: Update .gitignore [core] - 10https://gerrit.wikimedia.org/r/142153 (owner: 10PleaseStand) [05:11:13] (03PS1) 10EBernhardson: browser test dependencies moved in vagrant [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142195 [05:11:24] (03CR) 10EBernhardson: [C: 032] browser test dependencies moved in vagrant [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142195 (owner: 10EBernhardson) [05:12:18] (03Merged) 10jenkins-bot: browser test dependencies moved in vagrant [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142195 (owner: 10EBernhardson) [05:14:22] (03Merged) 10jenkins-bot: skins: Update .gitignore [core] - 10https://gerrit.wikimedia.org/r/142153 (owner: 10PleaseStand) [05:17:49] 3MediaWiki extensions / 3WikiEditor: In Insert Image dialog box the Align and Format settings are not set to any values - 10https://bugzilla.wikimedia.org/67111 (10Ritu Swain) 3UNCO p:3Unprio s:3minor a:3None Created attachment 15749 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15749&action... [05:28:09] (03CR) 10Yuvipanda: [C: 032] Move edit section button styles from Android to generic [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/141762 (owner: 10Brion VIBBER) [05:28:15] (03Merged) 10jenkins-bot: Move edit section button styles from Android to generic [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/141762 (owner: 10Brion VIBBER) [05:28:18] \o/ [05:28:19] brion: ^ :) [05:29:19] 3MediaWiki extensions / 3ContentTranslation: Clicking an image in the Special:CX source column doesn't bring copy it to the translation column, but clicking the caption does - 10https://bugzilla.wikimedia.org/66665 (10Amir E. Aharoni) [05:33:49] 3MediaWiki extensions / 3ContentTranslation: on Special:CX clicking an image in the target column opens the image description page - 10https://bugzilla.wikimedia.org/67113 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None On Special:CX clicking an image in the target column opens the image descrip... [05:43:20] 3MediaWiki / 3General/Unknown: Please add full stop and space after "undo" default edit summary - 10https://bugzilla.wikimedia.org/67114 (10jonesey95) 3UNCO p:3Unprio s:3trivia a:3None Please add a full stop (period) and a space after the automatic "Undo" edit summary that appears when a user clicks... [05:47:42] (03CR) 10Prtksxna: jquery.cookie: Update to v1.4.1 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/141112 (owner: 10Prtksxna) [06:03:52] (03CR) 10Legoktm: [C: 04-1] Added VERP functionality hook to core (032 comments) [core] - 10https://gerrit.wikimedia.org/r/138655 (https://bugzilla.wikimedia.org/46640) (owner: 1001tonythomas) [06:21:07] (03CR) 10Legoktm: [C: 032] Error for invalid targets when editing spamlist [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/141911 (owner: 10Wctaiwan) [06:21:19] (03Merged) 10jenkins-bot: Error for invalid targets when editing spamlist [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/141911 (owner: 10Wctaiwan) [06:39:48] (03PS27) 1001tonythomas: Added VERP functionality hook to core [core] - 10https://gerrit.wikimedia.org/r/138655 (https://bugzilla.wikimedia.org/46640) [06:44:49] 3MediaWiki / 3Skin and page rendering: Font Awesome not working on IE - 10https://bugzilla.wikimedia.org/67115 (10Jumuro) 3UNCO p:3Unprio s:3normal a:3None Font Awesome not displayed in IE-browsers, while on other engines, this problem does not exist. I suspect that you need to fix something in the... [07:00:53] (03PS2) 10Wctaiwan: Call API internally for list creation and editing [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142023 [07:05:48] (03PS1) 10EBernhardson: Consistently use TemplateHelper::html [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142200 [07:07:00] (03PS1) 10Legoktm: checkLocalNames: fix --wiki option [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/142201 [07:13:55] (03CR) 10Ori.livneh: [C: 032] Add ParserTestTables hook handler [extensions/Echo] - 10https://gerrit.wikimedia.org/r/142177 (owner: 10MaxSem) [07:14:06] (03Merged) 10jenkins-bot: Add ParserTestTables hook handler [extensions/Echo] - 10https://gerrit.wikimedia.org/r/142177 (owner: 10MaxSem) [07:20:09] (03CR) 10Legoktm: [C: 032 V: 032] "LGTM. As we discussed on IRC, I disagree with the page on mw.o, it doesn't make sense for when we're just wrapping around user input, and " [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142023 (owner: 10Wctaiwan) [07:20:18] (03Merged) 10jenkins-bot: Call API internally for list creation and editing [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142023 (owner: 10Wctaiwan) [07:20:31] I did not press V+2... [07:25:55] (03CR) 10Shirayuki: "Thanks" [extensions/ActivityMonitor] - 10https://gerrit.wikimedia.org/r/141907 (owner: 10Shirayuki) [07:30:57] (03PS1) 10Wctaiwan: Use Html class for generating displayed list [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142202 [07:40:52] (03CR) 10Nikerabbit: PrefixSearch (ApiOpenSearch) now supports searching in multiple namespaces (031 comment) [core] - 10https://gerrit.wikimedia.org/r/141660 (https://bugzilla.wikimedia.org/65752) (owner: 10Nikerabbit) [07:49:04] (03CR) 10Legoktm: [C: 032] Use Html class for generating displayed list [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142202 (owner: 10Wctaiwan) [07:49:13] (03Merged) 10jenkins-bot: Use Html class for generating displayed list [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/142202 (owner: 10Wctaiwan) [07:51:45] ori: Should I continue to use cookies to be on the safer side? Or would it be better to switch to localStorage now? https://gerrit.wikimedia.org/r/140086 [07:52:07] localStorage imo [07:53:12] Alright, will do! Thanks ori o/ [07:53:48] \o [07:53:55] (03PS1) 10Dan-nl: version update [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/142203 [07:54:02] ori: There is no time limit on localStorage, right? [07:54:16] ori: Will I have to talk to legal again? (already took permission for the cookie) [07:54:38] (03CR) 10Prtksxna: "use localStorage instead of cookies" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140086 (owner: 10Prtksxna) [07:55:03] prtksxna: only if you want to [07:55:11] i.e., no :) [07:55:18] but IANAL, etc. [07:55:29] ori: IANAL is the worst abbreviation :P [07:55:40] ori: Thanks again! [08:03:48] prtksxna: fits with the lawyer theme :P [08:04:01] wctaiwan: hehe [08:27:21] (03CR) 10Nikerabbit: [C: 032] "Since 파일토론 is also the primary name of NS_FILE_TALK, this should not break anything." [core] - 10https://gerrit.wikimedia.org/r/141252 (https://bugzilla.wikimedia.org/66479) (owner: 10Vogone) [08:30:50] (03Merged) 10jenkins-bot: Change NS_FILE_TALK alias in Korean [core] - 10https://gerrit.wikimedia.org/r/141252 (https://bugzilla.wikimedia.org/66479) (owner: 10Vogone) [08:31:17] 3MediaWiki / 3Internationalization: Change NS_FILE_TALK alias in Korean - 10https://bugzilla.wikimedia.org/66479#c5 (10Nemo) 5PATC>3RESO/FIX Approved by Nikerabbit. [08:50:08] (03PS3) 10PleaseStand: Special:BookSources: Correct validation of ISBNs containing X [core] - 10https://gerrit.wikimedia.org/r/141654 (https://bugzilla.wikimedia.org/67021) [08:55:49] 3MediaWiki / 3General/Unknown: number of uploads in graphite - 10https://bugzilla.wikimedia.org/67116 (10Filippo Giunchedi) 3NEW p:3Unprio s:3normal a:3None as part of https://wikitech.wikimedia.org/wiki/Incident_documentation/20140622-imagescaler I was searching for the number of uploads to wikis ma... [09:01:33] (03CR) 10Mattflaschen: "I'm not going to be able to finish this before the merge to master (assuming it goes forward today as planned)." (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142170 (https://bugzilla.wikimedia.org/66994) (owner: 10Mattflaschen) [09:05:43] (03CR) 10Nikerabbit: mediawiki.api: request unescaped UTF-8 entities in JSON format (031 comment) [core] - 10https://gerrit.wikimedia.org/r/142052 (owner: 10MaxSem) [09:10:21] 3MediaWiki extensions / 3WikidataRepo: Performance review of PubSubHubbub extension - 10https://bugzilla.wikimedia.org/67117 (10Sebastian Brückner) 3NEW p:3Unprio s:3normal a:3Wikidata bugs The PubSubHubbubExtension (https://www.mediawiki.org/wiki/Extension:PubSubHubbub) needs to be reviewed before d... [09:11:04] 3MediaWiki extensions / 3WikidataRepo: Security review of PubSubHubbub extension - 10https://bugzilla.wikimedia.org/67118 (10Sebastian Brückner) 3NEW p:3Unprio s:3normal a:3Wikidata bugs The PubSubHubbubExtension (https://www.mediawiki.org/wiki/Extension:PubSubHubbub) needs to be reviewed before depl... [09:11:32] 3MediaWiki extensions / 3WikidataRepo: Performance review of PubSubHubbub extension - 10https://bugzilla.wikimedia.org/67117 (10Sebastian Brückner) [09:11:47] 3MediaWiki extensions / 3WikidataRepo: Security review of PubSubHubbub extension - 10https://bugzilla.wikimedia.org/67118 (10Sebastian Brückner) [09:13:17] 3MediaWiki extensions / 3WikidataRepo: Performance review of PubSubHubbub extension - 10https://bugzilla.wikimedia.org/67117 (10Sebastian Brückner) [09:15:51] YuviPanda: need some ie advice [09:15:58] lol [09:16:01] from me? [09:16:03] /o\ [09:16:07] from anyone [09:16:12] I've not had to write code that needed to run in IE for the last... 4 years? [09:16:14] 3 years? [09:16:16] prtksxna: ask GM? [09:16:24] https://bugzilla.wikimedia.org/show_bug.cgi?id=66496 [09:16:37] YuviPanda: be my bouncing board for a minute [09:16:49] prtksxna: in the middle of doing some ops stuff :( [09:17:13] YuviPanda: No worries, I'll drop you a small email [09:21:48] (03CR) 10Nikerabbit: [C: 032] "Will do further testing on translatewiki.net." [core] - 10https://gerrit.wikimedia.org/r/141056 (https://bugzilla.wikimedia.org/14562) (owner: 10Brian Wolff) [09:25:21] (03Merged) 10jenkins-bot: Prevent OutputPage::addWikiText and friends from causing UNIQ fails [core] - 10https://gerrit.wikimedia.org/r/141056 (https://bugzilla.wikimedia.org/14562) (owner: 10Brian Wolff) [09:31:16] (03PS1) 10Prtksxna: Force mw.popups.supportsSVG to false on InternetExplorer [extensions/Popups] - 10https://gerrit.wikimedia.org/r/142212 [09:41:03] 3MediaWiki extensions / 3WikidataRepo: Security review of PubSubHubbub extension - 10https://bugzilla.wikimedia.org/67118 (10Andre Klapper) a:5Wikidata bugs>3Chris Steipp [09:42:17] 3MediaWiki / 3Skin and page rendering: Font Awesome not working on IE - 10https://bugzilla.wikimedia.org/67115#c1 (10Andre Klapper) What is "Font Awesome" and how exactly to reproduce? [09:43:02] 3MediaWiki / 3Page editing: Please add full stop and space after "undo" default edit summary - 10https://bugzilla.wikimedia.org/67114 (10Andre Klapper) p:5Unprio>3Low s:5trivia>3enhanc [09:43:17] 3MediaWiki / 3Page editing: Please add full stop and space after "undo" default edit summary - 10https://bugzilla.wikimedia.org/67114 (10Andre Klapper) 5UNCO>3NEW [09:49:37] (03CR) 10Krinkle: Allow skins to define skinStyles for arbitrary modules (031 comment) [core] - 10https://gerrit.wikimedia.org/r/141259 (owner: 10Bartosz Dziewoński) [09:56:34] (03PS1) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/142213 [09:58:02] 3MediaWiki extensions / 3Gadgets: GadgetsTest::testPreference s fails: $this->assertTrue( isset( $options['<gadget-sectio n-keep-section2>'] ) ); - 10https://bugzilla.wikimedia.org/67060 (10Andre Klapper) p:5Unprio>3Normal [09:58:17] 3MediaWiki extensions / 3Collection: language code de-ch (for Swiss German) sent by Collection extension but not supported by render service - 10https://bugzilla.wikimedia.org/67099 (10Andre Klapper) p:5Unprio>3Low [09:59:02] 3MediaWiki / 3General/Unknown: Alternate project links in sidebar - 10https://bugzilla.wikimedia.org/15407#c2 (10Andre Klapper) 5NEW>3RESO/DUP snaevar: Thanks for catching that! *** This bug has been marked as a duplicate of bug 54374 *** [09:59:17] 3MediaWiki extensions / 3WikidataClient: Support for sister project links section in the sidebar - 10https://bugzilla.wikimedia.org/54374#c6 (10Andre Klapper) *** Bug 15407 has been marked as a duplicate of this bug. *** [09:59:39] (03PS2) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/142213 [10:03:32] 3MediaWiki / 3General/Unknown: problem over the display box containing links to reference pages(i.e. of the form '[' a number ']' links like [6], [7]).. - 10https://bugzilla.wikimedia.org/67097#c1 (10Andre Klapper) Please explain what the actual "display problem" is, in words. Furthermore, this report might... [10:03:47] 3MediaWiki / 3Skin and page rendering: SVG thumbnailing doesn't work with $wgResponsiveImages - 10https://bugzilla.wikimedia.org/67081 (10Andre Klapper) p:5Unprio>3Normal [10:05:02] (03PS7) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/141684 [10:11:47] 3MediaWiki extensions / 3WikidataRepo: not possible to change rank alone - 10https://bugzilla.wikimedia.org/66633#c2 (10Henning (WMDE)) https://gerrit.wikimedia.org/r/#/c/142216/ [10:12:32] 3MediaWiki extensions / 3WikidataRepo: not possible to add no-value and some-value snaks in languages other than English - 10https://bugzilla.wikimedia.org/66626#c3 (10Henning (WMDE)) https://gerrit.wikimedia.org/r/#/c/142217/ [10:17:46] 3MediaWiki extensions / 3Gadgets: Gadgets: Fix failing unit test "GadgetsTest::testPreferenc es: isset( $options['<gadget-sectio n-keep-section2>'] )" - 10https://bugzilla.wikimedia.org/67060 (10Krinkle) [10:19:04] 3Wikimedia / 3Site requests: Please add the domain *.ihs.nl to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/67120 (10johanmmuller) 3UNCO p:3Unprio s:3normal a:3None Please add the following domain to the wgCopyUploadsDomains whitelist: *.ihs.nl Explanation ----------- I am... [10:34:41] (03CR) 10Krinkle: mediawiki.ui: Rename .mw-ui-vform-div → .mw-ui-vform-field, require it instead of styling all
s (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133724 (owner: 10Bartosz Dziewoński) [10:35:01] (03PS8) 10Krinkle: Stop using a suboptimal structure for Vector's variants menu [core] - 10https://gerrit.wikimedia.org/r/138368 (https://bugzilla.wikimedia.org/43406) (owner: 10Bartosz Dziewoński) [10:44:18] 3Wikimedia / 3Site requests: Please add the domain *.ihs.nl to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/67120 (10Tomasz W. Kozlowski) 5UNCO>3ASSI p:5Unprio>3Normal s:5normal>3enhanc a:3Tomasz W. Kozlowski [10:51:16] (03PS1) 10Hashar: operations-puppet-pplint-HEAD [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/142222 [10:56:08] (03PS2) 10Hashar: Replace puppet-validate job with pplint-HEAD [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/142222 [10:57:09] (03PS1) 10Hashar: Phase out puppet-validate in favor of pplint-HEAD [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/142223 [11:00:05] (03CR) 10Hashar: [C: 032] Replace puppet-validate job with pplint-HEAD [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/142222 (owner: 10Hashar) [11:01:30] (03CR) 10Hashar: [C: 032] Phase out puppet-validate in favor of pplint-HEAD [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/142223 (owner: 10Hashar) [11:01:33] (03Merged) 10jenkins-bot: Replace puppet-validate job with pplint-HEAD [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/142222 (owner: 10Hashar) [11:01:36] (03Merged) 10jenkins-bot: Phase out puppet-validate in favor of pplint-HEAD [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/142223 (owner: 10Hashar) [11:31:32] 3MediaWiki extensions / 3WikidataRepo: Regular expression in data-model-javascript resources file causes stack trace on Windows - 10https://bugzilla.wikimedia.org/67078#c1 (10Adrian Lang) 5NEW>3PATC https://github.com/wmde/WikibaseDataModelJavascript/issues/4 [11:39:31] Krinkle: ever since JQMigrate was disabled, Translate UI has had errors which I do not understand [11:39:52] Where is JQMigrate disabled? [11:40:05] https://dev.translatewiki.net/wiki/Special:Translate?action=proofread&group=core&filter=fuzzy&language=ta&debug=true if you edit the first message here, I get error "Uncaught SyntaxError: Unexpected end of input " from JSON.parse [11:40:07] Let me see the errors and I might be able to help. I dont know what "Translate UI" is. [11:40:09] Krinkle: translatewiki.net [11:41:11] it loads data from "https://dev.translatewiki.net/w/i.php?title=Special:Translate/editpage&suggestions=checks&page=MediaWiki%3AProtectedinterface%2Fta&loadgroup=core" which it tries to parse... but the callback only gets empty string [11:41:27] empty string is invalid [11:41:29] I think there is some issue going here which was masked by JQMigrate (and before) [11:41:32] "" is valid [11:41:37] '""' I mean [11:41:41] without the outer quites [11:41:42] if I load that url directly I get {} [11:41:45] http://jquery.com/upgrade-guide/1.9/#jquery-ajax-returning-a-json-result-of-an-empty-string [11:41:52] an empty result is invalid json [11:42:02] so I don't understand why the callback is not getting {} but "" instead [11:42:02] if the server intends to return an empty string, in valid json that is "" not nothing [11:42:09] "" would be valid [11:42:14] but it isn't getting the JSON "" [11:42:18] it is getting actual "" [11:42:23] fix the server, I think :) [11:42:56] I don't know the server-side handling, but it is not using json_encode() / formatJson where it should. [11:43:08] Krinkle: the server is returning {} [11:43:15] is it not returning that for you? [11:43:26] on that url yes, but that's not where the error comes from [11:43:31] how do I trigger the error? [11:43:40] Krinkle: just editing the first message triggers it for me [11:43:47] I meanm clicking the pencil icon [11:44:00] * Krinkle needs login [11:44:15] should work without login [11:44:56] at least I can click the pencil in incognito mode [11:45:47] Right [11:45:58] your server is returning something differnet for XHR then for a standalone request [11:46:08] if I inspect that request for https://dev.translatewiki.net/w/i.php?title=Special:Translate/editpage&suggestions=checks&page=MediaWiki%3AProtectedinterface%2Fta&loadgroup=core in the console, it is an empty reponse [11:46:10] not {} [11:46:15] open in new tab, gives {} [11:46:38] Nikerabbit: http://i.imgur.com/RApFlXj.png [11:47:28] To reproduce in the console, right click on the network request "Copy as CURL" [11:47:29] curl 'https://dev.translatewiki.net/w/i.php?title=Special:Translate/editpage&suggestions=checks&page=MediaWiki%3AProtectedinterface%2Fta&loadgroup=core' -H 'origin: https://dev.translatewiki.net' -H 'accept-encoding: gzip,deflate,sdch' -H 'accept-language: en,nl;q=0.8' -H 'x-requested-with: XMLHttpRequest' -H 'cookie: _ga=GA1.2.2006818778.1398230897; uls-previous-languages=%5B%22en%22%5D; mediaWiki.use [11:47:29] r.sessionId=BORhdBUmgOSeVeMvcESqo0ZlUhkmHzyo; dev_translatewiki_net_bw_UserID=2988; dev_translatewiki_net_bw_UserName=Krinkle; dev_translatewiki_net_bw__session=0e4uhkeaj7lg4t7khbd0p2rfo3' -H 'pragma: no-cache' -H 'user-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.153 Safari/537.36' -H 'content-type: application/x-www-form-urlencoded; cha [11:47:30] rset=UTF-8' -H 'accept: */*' -H 'cache-control: no-cache' -H 'referer: https://dev.translatewiki.net/w/i.php?title=Special:Translate&action=proofread&group=core&filter=fuzzy&language=ta&debug=true' --data 'translation=%E0%AE%87%E0%AE%AA%E0%AF%8D%E0%AE%AA%E0%AE%95%E0%AF%8D%E0%AE%95%E0%AE%AE%E0%AF%8D+%E0%AE%87%E0%AE%AE%E0%AF%8D%E0%AE%AE%E0%AF%86%E0%AE%A9%E0%AF%8D+%E0%AE%AA%E0%AF%8A%E0%AE%B0%E0%AF%81%E0%A [11:47:32] E%B3%E0%AF%81%E0%AE%95%E0%AF%8D%E0%AE%95%E0%AE%BE%E0%AE%A9+%E0%AE%AA%E0%AE%AF%E0%AE%A9%E0%AE%B0%E0%AF%8D+%E0%AE%87%E0%AE%9F%E0%AF%88%E0%AE%AE%E0%AF%81%E0%AE%95+%E0%AE%89%E0%AE%B0%E0%AF%88%E0%AE%95%E0%AE%B3%E0%AF%88+%E0%AE%B5%E0%AE%B4%E0%AE%99%E0%AF%8D%E0%AE%95%E0%AF%81%E0%AE%95%E0%AE%BF%E0%AE%B1%E0%AE%A4%E0%AF%81%2C+%E0%AE%B5%E0%AE%BF%E0%AE%9A%E0%AE%AE+%E0%AE%A4%E0%AF%8A%E0%AE%95%E0%AF%81%E0%AE%AA%E0%A [11:47:34] F%8D%E0%AE%AA%E0%AF%81%E0%AE%95%E0%AF%8D%E0%AE%95%E0%AE%B3%E0%AF%88+%E0%AE%A4%E0%AE%B5%E0%AE%BF%E0%AE%B0%E0%AF%8D%E0%AE%AA%E0%AF%8D%E0%AE%AA%E0%AE%A4%E0%AE%B1%E0%AF%8D%E0%AE%95%E0%AF%8D%E0%AE%95%E0%AE%BE%E0%AE%95+%E0%AE%87%E0%AE%AA%E0%AF%8D%E0%AE%AA%E0%AE%95%E0%AF%8D%E0%AE%95%E0%AE%AE%E0%AF%8D+%E0%AE%AA%E0%AF%82%E0%AE%9F%E0%AF%8D%E0%AE%9F%E0%AE%AA%E0%AF%8D%E0%AE%AA%E0%AE%9F%E0%AF%8D%E0%AE%9F%E0%AF%81%E [11:47:36] 0%AE%B3%E0%AF%8D%E0%AE%B3%E0%AE%A4%E0%AF%81.' --compressed [11:47:38] crap [11:47:54] (03PS3) 10Deepali: Fix css for dark background option [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/141912 [11:48:04] yes I noticed that... I could not figure out why the response is empty if done via Ajax [11:48:22] Check nginx config, or something inside that special page looking for "XHR" [11:48:36] ok [11:48:37] "x-requested-with: [11:50:17] so to clarify, the request is actually broken. Any data the server should send, isn't being sent. jQuery previously surpressed this error and not it is exposed for your convenience. [11:50:29] now* [11:58:02] 3MediaWiki extensions / 3[other]: Semantic Rating extension new version 1.2 generates bad html - 10https://bugzilla.wikimedia.org/67010#c5 (10Aditya Chaturvedi) Hi Cindy, it works fine for me. Thanks for adding the feature. In the future release I think it will be helpful if there is the option of set max nu... [12:03:46] Krinkle: yes, that's what I thought is happening, just couldn't figure why [12:05:58] (03CR) 10Parent5446: [C: 04-1] "Rather than replacing the uses of gzopen, do what is done in the links in the bug report: define gzopen manually as an aliased call to gzo" [core] - 10https://gerrit.wikimedia.org/r/141970 (https://bugzilla.wikimedia.org/66952) (owner: 10Rohan013) [12:07:49] 3MediaWiki extensions / 3WikidataRepo: Remove assertTag usages from tests - 10https://bugzilla.wikimedia.org/67122 (10Adrian Lang) 3NEW p:3Unprio s:3normal a:3Wikidata bugs assertTag is deprecated in phpunit 4.2: https://github.com/sebastianbergmann/phpunit/commit/e3c63e4858a29a49294f06058ab5d6cdebd7... [12:25:19] (03CR) 10Hashar: [C: 032] "That was a good experimentation. lets land it for historical purposes." [integration/jenkins-job-builder-config] (labs) - 10https://gerrit.wikimedia.org/r/131460 (owner: 10Hashar) [12:25:47] 3MediaWiki extensions / 3WikidataRepo: Remove assertTag usages from tests - 10https://bugzilla.wikimedia.org/67122 (10Lydia Pintscher) p:5Unprio>3Normal [12:26:04] 3Wikimedia / 3General/Unknown: Watchlist problem on Serbo-Croatian Wikipedia - 10https://bugzilla.wikimedia.org/67123 (10Kolega2357) 3UNCO p:3Unprio s:3normal a:3None All is started before 3 days, I cant open my watchlist on sh wikipedia. Writes Wikimedia Foundation Error. See here http://prntscr.c... [12:26:53] (03Merged) 10jenkins-bot: integration-mediawiki based on Zuul cloner [integration/jenkins-job-builder-config] (labs) - 10https://gerrit.wikimedia.org/r/131460 (owner: 10Hashar) [12:27:02] 3MediaWiki extensions / 3WikidataClient: Syncing mechanism via Pubsubhubbub - 10https://bugzilla.wikimedia.org/38970 (10Lydia Pintscher) [12:27:02] 3MediaWiki extensions / 3WikidataRepo: Performance review of PubSubHubbub extension - 10https://bugzilla.wikimedia.org/67117 (10Lydia Pintscher) [12:27:07] (03PS1) 10Jamesmontalvo3: Adding composer support [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/142232 [12:27:09] (03PS1) 10Jamesmontalvo3: JSON error; extra comma [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/142233 [12:27:11] (03CR) 10jenkins-bot: [V: 04-1] Adding composer support [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/142232 (owner: 10Jamesmontalvo3) [12:27:13] (03PS4) 10Hashar: Use mw-run-update-script.sh script [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141851 [12:27:17] 3MediaWiki extensions / 3WikidataRepo: Security review of PubSubHubbub extension - 10https://bugzilla.wikimedia.org/67118 (10Lydia Pintscher) [12:29:25] (03PS1) 10Aude: Add note in README about script.disable_dynamic setting [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/142234 [12:31:04] 3Analytics / 3Wikimetrics: Story: User has website for dashboards - 10https://bugzilla.wikimedia.org/67124 (10Kevin Leduc) 3NEW p:3Unprio s:3normal a:3None Set up a website for EEVS dashboards [12:32:32] 3Analytics / 3Wikimetrics: Story: User has website for dashboards - 10https://bugzilla.wikimedia.org/67124 (10Kevin Leduc) p:5Unprio>3Normal s:5normal>3enhanc [12:38:34] 3Analytics / 3Wikimetrics: Story: Community has matrix on visualization engines - 10https://bugzilla.wikimedia.org/67125 (10Kevin Leduc) 3NEW p:3Unprio s:3normal a:3None Outcome: - page on wikimedia.org - comparison of major visualization engines (Limn, vega, ...) - a choice on what to use for EEVS [12:38:47] 3Analytics / 3Wikimetrics: Story: Community has matrix on visualization engines - 10https://bugzilla.wikimedia.org/67125 (10Kevin Leduc) p:5Unprio>3Normal s:5normal>3enhanc [12:39:47] 3Analytics / 3Wikimetrics: Story: Community has matrix on visualization engines - 10https://bugzilla.wikimedia.org/67125 (10Kevin Leduc) p:5Normal>3High [12:47:04] 3Analytics / 3EventLogging: Story: Product groups have EventLogging validation - 10https://bugzilla.wikimedia.org/67126 (10Kevin Leduc) 3NEW p:3Unprio s:3normal a:3None https://www.mediawiki.org/wiki/Analytics/EventLogging#Data_Validation.2FSupport [12:47:32] 3Analytics / 3EventLogging: Story: Product groups have EventLogging validation - 10https://bugzilla.wikimedia.org/67126 (10Kevin Leduc) p:5Unprio>3High s:5normal>3enhanc [12:50:39] (03CR) 10Manybubbles: [C: 032] Add note in README about script.disable_dynamic setting [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/142234 (owner: 10Aude) [12:50:45] (03CR) 10Manybubbles: "Thaanks!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/142234 (owner: 10Aude) [12:50:48] (03Merged) 10jenkins-bot: Add note in README about script.disable_dynamic setting [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/142234 (owner: 10Aude) [12:50:51] :) [12:51:17] 3Analytics / 3Wikimetrics: Story: Community has matrix on visualization engines - 10https://bugzilla.wikimedia.org/67125 (10Kevin Leduc) [12:53:41] Krinkle: thanks, one find led to another and the result is at https://gerrit.wikimedia.org/r/142235 [13:02:04] 3Analytics / 3Refinery: Story: HadoopUser has refined data available in clustered bucketed Hive tables - 10https://bugzilla.wikimedia.org/67127 (10Kevin Leduc) 3NEW p:3Unprio s:3enhanc a:3None https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL+BucketedTables [13:03:03] 3Analytics / 3Refinery: Story: HadoopUser has refined data available in clustered bucketed Hive tables - 10https://bugzilla.wikimedia.org/67127 (10Kevin Leduc) p:5Unprio>3Highes [13:05:04] 3Analytics / 3Refinery: Admin has duplicate monitoring in Icinga - 10https://bugzilla.wikimedia.org/67128 (10Kevin Leduc) 3NEW p:3Unprio s:3enhanc a:3None scheduled via Oozie [13:05:17] 3Analytics / 3Refinery: Admin has duplicate monitoring in Icinga - 10https://bugzilla.wikimedia.org/67128 (10Kevin Leduc) p:5Unprio>3High [13:06:34] 3Analytics / 3Refinery: Admin has versioned and sync'ed files in HDFS - 10https://bugzilla.wikimedia.org/67129 (10Kevin Leduc) 3NEW p:3Unprio s:3enhanc a:3None using hdfs_sync [13:07:02] 3Analytics / 3Refinery: Admin has versioned and sync'ed files in HDFS - 10https://bugzilla.wikimedia.org/67129 (10Kevin Leduc) p:5Unprio>3High [13:07:46] (03PS1) 10Zfilipin: All language team jobs are now running at Sauce Labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/142237 [13:07:49] (03CR) 10Hashar: [C: 032] "tested with phpunit and qunit extensions jobs. being deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141851 (owner: 10Hashar) [13:08:32] 3Analytics / 3Refinery: Story: Admin has CDH5 running on the cluster - 10https://bugzilla.wikimedia.org/67130 (10Kevin Leduc) p:5Unprio>3High [13:08:57] (03Merged) 10jenkins-bot: Use mw-run-update-script.sh script [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141851 (owner: 10Hashar) [13:12:23] (03CR) 10Amire80: [C: 031] All language team jobs are now running at Sauce Labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/142237 (owner: 10Zfilipin) [13:16:02] 3Analytics / 3Refinery: Story: HadoopUser has refined data available in clustered bucketed Hive tables - 10https://bugzilla.wikimedia.org/67127 (10Kevin Leduc) p:5Highes>3High [13:16:47] 3Analytics / 3Wikimetrics: Story: Community has matrix on visualization engines - 10https://bugzilla.wikimedia.org/67125 (10Kevin Leduc) [13:17:17] 3Analytics / 3EventLogging: Story: Product groups have EventLogging validation - 10https://bugzilla.wikimedia.org/67126 (10Kevin Leduc) [13:18:02] 3Analytics / 3EventLogging: Empty objects can pass schemas with required fields - 10https://bugzilla.wikimedia.org/65607 (10Kevin Leduc) [13:18:18] 3Analytics / 3Wikimetrics: Story: User creates cohort with CentralAuth insertions - 10https://bugzilla.wikimedia.org/66843 (10Kevin Leduc) [13:18:47] 3Analytics / 3Wikimetrics: Story: User has website for dashboards - 10https://bugzilla.wikimedia.org/67124 (10Kevin Leduc) [13:19:49] 3Analytics / 3Wikimetrics: Story: CronUser backfills NewlyRegistered User for recurring reports - 10https://bugzilla.wikimedia.org/66841 (10Kevin Leduc) p:5Normal>3High [13:21:32] 3Analytics / 3Wikimetrics: Story: User has website for dashboards - 10https://bugzilla.wikimedia.org/67124 (10Kevin Leduc) p:5Normal>3High [13:21:33] (03CR) 10Rillke: "Use of undefined constant babel - assumed 'babel'" (031 comment) [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/140732 (owner: 10Rillke) [13:28:49] 3MediaWiki / 3API: Results order when using generator=search - 10https://bugzilla.wikimedia.org/67131 (10Artur Bekasov) 3UNCO p:3Unprio s:3enhanc a:3None I am trying to use search as a generator, and get summary of every article found, effectively replicating functionality of the Special:Search page.... [13:32:05] (03PS1) 10Matthias Mullie: Three states are not a toggle, should be "Switch to". [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142239 [13:32:12] reminder: dumps.wikimedia.org = download.wikimedia.org will be unavailable for up to an hour, starting right now [13:32:28] (03CR) 10jenkins-bot: [V: 04-1] Three states are not a toggle, should be "Switch to". [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142239 (owner: 10Matthias Mullie) [13:32:34] 3Wikimedia / 3Bugzilla: Create extensions component for GoogleLogin? - 10https://bugzilla.wikimedia.org/67132 (10Florian) 3NEW p:3Unprio s:3normal a:3None Hello! is it possible to create a component in MW-Extensions for GoogleLogin, please? https://www.mediawiki.org/wiki/Extension:GoogleLogin Than... [13:33:33] (03PS2) 10Matthias Mullie: Three states are not a toggle, should be "Switch to". [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142239 [13:33:43] (03CR) 10jenkins-bot: [V: 04-1] Three states are not a toggle, should be "Switch to". [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142239 (owner: 10Matthias Mullie) [13:36:58] (03PS3) 10Matthias Mullie: Sticky sorting preference for users [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142036 (owner: 10Bsitu) [13:37:09] (03CR) 10jenkins-bot: [V: 04-1] Sticky sorting preference for users [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142036 (owner: 10Bsitu) [13:37:59] (03CR) 10Matthias Mullie: [C: 031] "Looks good. Not yet merging because tests fail. Pretty sure it's unrelated, let's figure that out first." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142036 (owner: 10Bsitu) [13:45:49] 3MediaWiki / 3User login and signup: $wgDefaultUserOptions['rememberpassword'] = 1 stopped working in 1.23 - 10https://bugzilla.wikimedia.org/67133 (10Jeremy) 3NEW p:3Unprio s:3normal a:3None Upon upgrading from 1.21 to 1.23, I noticed that the (now labeled) "Keep me logged in" checkbox is no longer... [13:46:50] (03PS2) 10Reedy: Add ContentTranslation anticipating future deployment [tools/release] - 10https://gerrit.wikimedia.org/r/141119 (owner: 10Nikerabbit) [13:46:56] (03CR) 10Reedy: [C: 032] Add ContentTranslation anticipating future deployment [tools/release] - 10https://gerrit.wikimedia.org/r/141119 (owner: 10Nikerabbit) [13:47:21] (03Merged) 10jenkins-bot: Add ContentTranslation anticipating future deployment [tools/release] - 10https://gerrit.wikimedia.org/r/141119 (owner: 10Nikerabbit) [13:49:03] (03PS1) 10Reedy: Branch Mantle [tools/release] - 10https://gerrit.wikimedia.org/r/142240 [13:49:26] (03CR) 10Reedy: [C: 032] Branch Mantle [tools/release] - 10https://gerrit.wikimedia.org/r/142240 (owner: 10Reedy) [13:49:33] (03Merged) 10jenkins-bot: Branch Mantle [tools/release] - 10https://gerrit.wikimedia.org/r/142240 (owner: 10Reedy) [13:50:44] Reedy: is mantle being deployed today? [13:50:51] No [13:51:12] Wikitech is pretty vague [13:51:13] End of June: deploy new Mantle extension providing shared code for Flow discussion software [13:51:28] early July: new Flow using handlebars/lightncandy templating and Mantle extension. [13:51:32] 3MediaWiki / 3JobQueue: JobQueueRedis locking up and throwing errors and exceptions - 10https://bugzilla.wikimedia.org/66953#c3 (10Jamie Thingelstad) Important update. The numerous errors that I’m seeing when running jobQueue only seem to occur if I’m using --procs setting. If I’m running a single runJobs.ph... [14:04:47] 3MediaWiki / 3JavaScript: QUnit tests for jquery.makeCollapsible often failing on Jenkins - 10https://bugzilla.wikimedia.org/63579#c16 (10Bartosz Dziewoński) This is really problematic… https://gerrit.wikimedia.org/r/#/c/137837/ [14:11:22] (03CR) 10Cmcmahon: [C: 032] All language team jobs are now running at Sauce Labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/142237 (owner: 10Zfilipin) [14:13:05] (03Merged) 10jenkins-bot: All language team jobs are now running at Sauce Labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/142237 (owner: 10Zfilipin) [14:13:47] 3Analytics / 3EventLogging: Fix per schema counts in graphite - 10https://bugzilla.wikimedia.org/67073 (10Kevin Leduc) p:5Unprio>3High [14:21:22] (03PS1) 10Zfilipin: WIP The first job to take sceenshots [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/142244 (https://bugzilla.wikimedia.org/62737) [14:25:48] (03CR) 10Bartosz Dziewoński: Allow skins to define skinStyles for arbitrary modules (031 comment) [core] - 10https://gerrit.wikimedia.org/r/141259 (owner: 10Bartosz Dziewoński) [14:26:21] (03PS2) 10Zfilipin: WIP The first job to take sceenshots [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/142244 (https://bugzilla.wikimedia.org/62737) [14:26:51] (03PS3) 10Zfilipin: WIP The first job to take sceenshots [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/142244 (https://bugzilla.wikimedia.org/62737) [14:28:17] 3MediaWiki extensions / 3OAuth: Message describing OAuth activities is confusing to end user - 10https://bugzilla.wikimedia.org/67082#c4 (10Pete F) 5RESO/INV>3REOP I am glad to see there are some technical issues being surfaced, and I like Bartosz's suggestion, that the tool could be more closely tailore... [14:28:41] (03PS2) 10Matthias Mullie: Consistently use TemplateHelper::html [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142200 (owner: 10EBernhardson) [14:28:47] (03CR) 10Bartosz Dziewoński: "@Jon: This code, or something similar, would still have to be called from the #register method (or from other methods that call register)," [core] - 10https://gerrit.wikimedia.org/r/141259 (owner: 10Bartosz Dziewoński) [14:28:50] (03CR) 10jenkins-bot: [V: 04-1] Consistently use TemplateHelper::html [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142200 (owner: 10EBernhardson) [14:29:32] 3MediaWiki / 3Watchlist: Special:EditWatchlist no longer returns to self after submitting the form - 10https://bugzilla.wikimedia.org/31753 (10Andre Klapper) p:5Normal>3Low [14:29:52] (03PS4) 10Bartosz Dziewoński: Allow skins to define skinStyles for arbitrary modules [core] - 10https://gerrit.wikimedia.org/r/141259 [14:30:48] 3MediaWiki extensions / 3Popups: Popups appear too quickly (resulting in a lot of accidental hovers) - 10https://bugzilla.wikimedia.org/64234 (10Bartosz Dziewoński) 5PATC>3RESO/FIX a:3Bartosz Dziewoński [14:32:05] (03CR) 10jenkins-bot: [V: 04-1] Allow skins to define skinStyles for arbitrary modules [core] - 10https://gerrit.wikimedia.org/r/141259 (owner: 10Bartosz Dziewoński) [14:33:55] (03CR) 10Chad: [C: 032 V: 032] Add a missing class [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/142069 (owner: 10Chad) [14:34:39] (03PS4) 10Zfilipin: WIP The first job to take sceenshots [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/142244 (https://bugzilla.wikimedia.org/62737) [14:34:45] (03Abandoned) 10Chad: Revert "Add Page Existance checking maintenance script" [core] - 10https://gerrit.wikimedia.org/r/141559 (owner: 10Chad) [14:35:18] 3MediaWiki extensions / 3WikidataRepo: not possible to remove sitelinks using Special:SetSitelink - 10https://bugzilla.wikimedia.org/62707#c3 (10Bene*) https://github.com/wikimedia/mediawiki-extensions-Wikibase/commit/9eee6f95f530b31c4bd660766bd0d4761d394bab#diff-d38ca5d2d537ba66659adbc1df4d8bf0 might have c... [14:35:32] 3Wikimedia / 3General/Unknown: Error 503 trying to access watchlist on Serbo-Croatian Wikipedia - 10https://bugzilla.wikimedia.org/67123#c1 (10Andre Klapper) p:5Unprio>3Low Cannot reproduce; http://sh.wikipedia.org/wiki/Posebno:Spisak_pra%C4%87enja renders for me and displays "Spisak praćenja/Списак праћ... [14:35:47] 3MediaWiki extensions / 3OAuth: Message describing OAuth activities is confusing to end user (in context of Wikidata Game) - 10https://bugzilla.wikimedia.org/67082 (10Bartosz Dziewoński) [14:37:17] ^d: ty! [14:37:40] (03PS1) 10Matthias Mullie: Allow phpunit.phar to be passed as --with-phpunitdir [core] - 10https://gerrit.wikimedia.org/r/142246 [14:38:12] <^d> YuviPanda: I still say vagrant is silly and the script is broken. [14:38:13] <^d> :p [14:38:29] ^d: :P this isn't even for vagrant. This is for repurposing Vagrant's puppet files to run on labs :) [14:40:36] (03PS1) 10Chad: Fix pageExists when passed invalid title [core] - 10https://gerrit.wikimedia.org/r/142247 [14:40:47] <^d> Well if we're going to have such a silly script let's at least fix it ^ [14:41:03] (03PS5) 10Zfilipin: WIP The first job to take sceenshots [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/142244 (https://bugzilla.wikimedia.org/62737) [14:41:36] (03CR) 10Zfilipin: WIP The first job to take sceenshots (031 comment) [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/142244 (https://bugzilla.wikimedia.org/62737) (owner: 10Zfilipin) [14:41:39] (03CR) 10Yuvipanda: [C: 032] Fix pageExists when passed invalid title [core] - 10https://gerrit.wikimedia.org/r/142247 (owner: 10Chad) [14:41:42] (03PS2) 10Amire80: Allow link/meta in body; treat like img/br [services/cxserver] - 10https://gerrit.wikimedia.org/r/142061 (owner: 10Divec) [14:44:18] (03CR) 10Yaron Koren: [C: 032 V: 032] "Thank you for this patch! It makes a lot of sense." [extensions/SiteSettings] - 10https://gerrit.wikimedia.org/r/134316 (owner: 10Shirayuki) [14:45:02] (03Merged) 10jenkins-bot: Fix pageExists when passed invalid title [core] - 10https://gerrit.wikimedia.org/r/142247 (owner: 10Chad) [14:56:23] (03PS2) 10Rohan013: Replaces gzopen() function with gzopen64() [core] - 10https://gerrit.wikimedia.org/r/141970 (https://bugzilla.wikimedia.org/66952) [15:00:21] (03CR) 10Nikerabbit: [C: 032] Allow link/meta in body; treat like img/br [services/cxserver] - 10https://gerrit.wikimedia.org/r/142061 (owner: 10Divec) [15:01:02] (03Merged) 10jenkins-bot: Allow link/meta in body; treat like img/br [services/cxserver] - 10https://gerrit.wikimedia.org/r/142061 (owner: 10Divec) [15:01:17] 3Analytics / 3Wikimetrics: Cohort listing going against the database instead of using CohortService - 10https://bugzilla.wikimedia.org/66126 (10Kevin Leduc) [15:04:28] (03Abandoned) 10Rohan013: Replaces gzopen() function with gzopen64() [core] - 10https://gerrit.wikimedia.org/r/141970 (https://bugzilla.wikimedia.org/66952) (owner: 10Rohan013) [15:06:17] 3MediaWiki / 3API: Results order when using generator=search - 10https://bugzilla.wikimedia.org/67131#c1 (10Brad Jorsch) 5UNCO>3RESO/DUP p:5Unprio>3Lowest As you already noted, the reasons provided in bug 14859 apply here too. This is a duplicate of that bug. (In reply to Artur Bekasov from comment... [15:06:18] 3MediaWiki / 3API: add an index field to show original order of queried titles - 10https://bugzilla.wikimedia.org/14859#c2 (10Brad Jorsch) *** Bug 67131 has been marked as a duplicate of this bug. *** [15:11:52] * Reedy branches 1.24wmf11 [15:12:34] (03PS1) 10Hashar: Run test with a logged in user [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/142251 [15:12:44] (03CR) 10jenkins-bot: [V: 04-1] Run test with a logged in user [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/142251 (owner: 10Hashar) [15:14:56] (03CR) 10Jdlrobson: [C: 032] ext.mantle.modules needs ext.mantle [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137249 (owner: 10Spage) [15:15:24] (03Merged) 10jenkins-bot: ext.mantle.modules needs ext.mantle [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137249 (owner: 10Spage) [15:16:06] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Bugfix for MediaWiki 1.22+ compatibility [extensions/Push] - 10https://gerrit.wikimedia.org/r/132204 (owner: 10Robert Vogel) [15:16:20] (03PS1) 10Hashar: Only manage logged users [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/142252 [15:16:45] (03PS2) 10Hashar: Run test with a logged in user [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/142251 [15:16:51] (03CR) 10jenkins-bot: [V: 04-1] Run test with a logged in user [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/142251 (owner: 10Hashar) [15:16:58] (03PS3) 10Hashar: Run test with a logged in user [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/142251 [15:17:04] (03CR) 10jenkins-bot: [V: 04-1] Run test with a logged in user [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/142251 (owner: 10Hashar) [15:17:22] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Add support for login domains, to make this work with LDAP Extension. Use egPushLoginDomains. [extensions/Push] - 10https://gerrit.wikimedia.org/r/141364 (owner: 10Drobbins) [15:18:19] 3Wikimedia / 3Bugzilla: Create extensions component for GoogleLogin? - 10https://bugzilla.wikimedia.org/67132#c1 (10Andre Klapper) 5NEW>3RESO/FIX a:3Andre Klapper Yes! I've added the extension in Wikimedia Bugzilla and set you as default CC. I've also updated https://www.mediawiki.org/wiki/Extension:Go... [15:19:04] (03PS2) 10Zfilipin: Moved a couple of UploadWizard from Cloudbees [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/141449 [15:19:17] 3MediaWiki / 3Skin and page rendering: Font Awesome not working on IE - 10https://bugzilla.wikimedia.org/67115#c2 (10Jumuro) "Font Awesome" it is a icons generated using the font and css (official website http://fortawesome.github.io/Font-Awesome/) Here's an example on my test site -> http://test.firefall-w... [15:22:32] 3Wikimedia / 3Bugzilla: Create extensions component for GoogleLogin? - 10https://bugzilla.wikimedia.org/67132#c2 (10Florian) TOP, thanks :) [15:22:34] (03CR) 10Bartosz Dziewoński: mediawiki.api: request unescaped UTF-8 entities in JSON format (031 comment) [core] - 10https://gerrit.wikimedia.org/r/142052 (owner: 10MaxSem) [15:22:39] (03CR) 10Bartosz Dziewoński: [C: 031] mediawiki.api: request unescaped UTF-8 entities in JSON format [core] - 10https://gerrit.wikimedia.org/r/142052 (owner: 10MaxSem) [15:23:45] (03PS1) 10Zfilipin: Moved two browsertests-qa jobs to Sauce Labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/142253 [15:24:55] (03PS2) 10Zfilipin: WIP Remove unneeded mediawiki_user variable [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/138346 [15:25:14] (03CR) 10jenkins-bot: [V: 04-1] WIP Remove unneeded mediawiki_user variable [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/138346 (owner: 10Zfilipin) [15:25:19] 3MediaWiki extensions / 3GoogleLogin: Enable "keep login" in GoogleLogin Settings - 10https://bugzilla.wikimedia.org/67136 (10Florian) 3NEW p:3Unprio s:3normal a:3None If the user choose the login with Google he can not choose, if he want to keep the login. possible solution #1: Try to use the "keep... [15:25:48] 3MediaWiki extensions / 3GoogleLogin: Enable "keep login" in GoogleLogin Settings - 10https://bugzilla.wikimedia.org/67136 (10Florian) p:5Unprio>3High a:3Florian [15:25:49] (03PS2) 10Zfilipin: Moved two browsertests-qa jobs to Sauce Labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/142253 [15:26:12] <^d> MatmaRex: Easy change :) https://gerrit.wikimedia.org/r/#/c/142024/ [15:26:12] (03CR) 10Cmcmahon: [C: 032] Moved two browsertests-qa jobs to Sauce Labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/142253 (owner: 10Zfilipin) [15:26:52] (03Merged) 10jenkins-bot: Moved two browsertests-qa jobs to Sauce Labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/142253 (owner: 10Zfilipin) [15:27:04] 3MediaWiki extensions / 3BetaFeatures: AutoEnrollmentTest produce a fatal error with OATHAuth extension - 10https://bugzilla.wikimedia.org/67138 (10Antoine "hashar" Musso) 3NEW p:3Unprio s:3normal a:3None I have been running unit tests with master versions of core BetaFeatures and OATHAuth. I am give... [15:27:31] (03Abandoned) 10Zfilipin: WIP Remove unneeded mediawiki_user variable [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/138346 (owner: 10Zfilipin) [15:27:37] (03PS2) 10Hashar: Only manage logged users [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/142252 (https://bugzilla.wikimedia.org/67138) [15:27:51] (03PS4) 10Hashar: Run test with a logged in user [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/142251 (https://bugzilla.wikimedia.org/67138) [15:27:58] (03CR) 10jenkins-bot: [V: 04-1] Run test with a logged in user [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/142251 (https://bugzilla.wikimedia.org/67138) (owner: 10Hashar) [15:30:35] ^d: i trust you that no one will file a bug about deprecation warnings in production [15:30:37] (03CR) 10Bartosz Dziewoński: [C: 032] Deprecate wfCheckLimits(), nothing calls this anymore [core] - 10https://gerrit.wikimedia.org/r/142024 (owner: 10Chad) [15:30:49] <^d> I grepped :) [15:30:54] <^d> Didn't see anything anywhere in git. [15:31:14] i've already deprecated one function thisweek that turned out to be widely used :P [15:34:40] (03Merged) 10jenkins-bot: Deprecate wfCheckLimits(), nothing calls this anymore [core] - 10https://gerrit.wikimedia.org/r/142024 (owner: 10Chad) [15:34:54] (03Abandoned) 10Chad: Switch default namespaces in SearchEngine to return content namespaces [core] - 10https://gerrit.wikimedia.org/r/140715 (owner: 10Chad) [15:34:56] (03PS1) 10Matthias Mullie: BLOB/TEXT column 'abcdef' can't have a default value [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/142254 [15:36:25] (03CR) 10Chad: "Ping?" [core] - 10https://gerrit.wikimedia.org/r/129853 (owner: 10Chad) [15:38:17] 3Wikimedia / 3General/Unknown: Error 503 trying to access watchlist on Serbo-Croatian Wikipedia - 10https://bugzilla.wikimedia.org/67123#c2 (10Kolega2357) (In reply to Andre Klapper from comment #1) > Cannot reproduce; http://sh.wikipedia.org/wiki/Posebno:Spisak_pra%C4%87enja > renders for me and displays "S... [15:40:52] (03CR) 10Chad: [C: 032] SpecialPage: DRY array filter for prefixSearchSubpages() [core] - 10https://gerrit.wikimedia.org/r/141604 (owner: 10Krinkle) [15:42:52] (03CR) 10Bartosz Dziewoński: SpecialPage: DRY array filter for prefixSearchSubpages() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/141604 (owner: 10Krinkle) [15:43:51] (03CR) 10Chad: "Needs rebase, otherwise ok." [core] - 10https://gerrit.wikimedia.org/r/142047 (owner: 10Aaron Schulz) [15:44:31] (03Merged) 10jenkins-bot: SpecialPage: DRY array filter for prefixSearchSubpages() [core] - 10https://gerrit.wikimedia.org/r/141604 (owner: 10Krinkle) [15:45:05] (03CR) 10Chad: [C: 032] test: Remove MagicVariableTest#testServernameFromDifferentProtocols [core] - 10https://gerrit.wikimedia.org/r/141757 (owner: 10Krinkle) [15:45:59] (03CR) 10Anomie: [C: 032] "Ok, let's go for it." [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113518 (https://bugzilla.wikimedia.org/35628) (owner: 10Brian Wolff) [15:46:42] (03Merged) 10jenkins-bot: Decode html entities before comparing strings in #ifeq: and #switch [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113518 (https://bugzilla.wikimedia.org/35628) (owner: 10Brian Wolff) [15:47:10] (03CR) 10Chad: [C: 032] Avoid key conflict errors in User::addToDatabase [core] - 10https://gerrit.wikimedia.org/r/141609 (https://bugzilla.wikimedia.org/66185) (owner: 10Aaron Schulz) [15:47:34] (03CR) 10Chad: [C: 032] SpecialJavaScriptTest: Implement prefixSearchSubpages() [core] - 10https://gerrit.wikimedia.org/r/141561 (owner: 10Bartosz Dziewoński) [15:49:25] (03PS6) 10Chad: Add syntax to limit searches to the local wiki [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140567 (owner: 10Manybubbles) [15:49:37] (03Merged) 10jenkins-bot: test: Remove MagicVariableTest#testServernameFromDifferentProtocols [core] - 10https://gerrit.wikimedia.org/r/141757 (owner: 10Krinkle) [15:49:53] (03CR) 10Chad: [C: 032] Add syntax to limit searches to the local wiki [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140567 (owner: 10Manybubbles) [15:50:24] (03CR) 10Manybubbles: "Thanks - was in the middle of something. I promise I planned to come off of it and do more review in the next couple hours." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140567 (owner: 10Manybubbles) [15:50:33] (03CR) 10SG: [C: 032] Consistently use TemplateHelper::html [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142200 (owner: 10EBernhardson) [15:50:38] (03Merged) 10jenkins-bot: Avoid key conflict errors in User::addToDatabase [core] - 10https://gerrit.wikimedia.org/r/141609 (https://bugzilla.wikimedia.org/66185) (owner: 10Aaron Schulz) [15:50:51] (03Merged) 10jenkins-bot: Add syntax to limit searches to the local wiki [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140567 (owner: 10Manybubbles) [15:50:59] (03CR) 10jenkins-bot: [V: 04-1] Consistently use TemplateHelper::html [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142200 (owner: 10EBernhardson) [15:51:07] (03Merged) 10jenkins-bot: SpecialJavaScriptTest: Implement prefixSearchSubpages() [core] - 10https://gerrit.wikimedia.org/r/141561 (owner: 10Bartosz Dziewoński) [15:53:21] (03CR) 10Krinkle: "I'm not 100% but I think this is wrong. {{PAGENAME }} is not encoded using plain html entities. Nor does it use Sanitizer. It uses wfEscap" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113518 (https://bugzilla.wikimedia.org/35628) (owner: 10Brian Wolff) [15:53:29] (03CR) 10Jdlrobson: Hide visually broken elements in non-JavaScript site (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141990 (owner: 10Jdlrobson) [15:54:32] Nikerabbit: around? [15:54:53] Nikerabbit: can you force a run of l10n-bot so that the new skin messages are updated? [15:55:02] 3MediaWiki / 3Skin and page rendering: Font Awesome not working on IE - 10https://bugzilla.wikimedia.org/67115#c3 (10Andre Klapper) Thanks for the link! I see that pt-createaccount uses  and pt-login uses . So IE does not correctly render those icons which are actually elements in that font. How exactly d... [15:57:53] MatmaRex: I was told they were committed [15:58:27] Nemo_bis: raimond's patch was merged, but i don't see the language files in core [15:58:35] i just pulled [15:59:03] (03PS1) 10Zfilipin: Moved MultimediaViewer jobs from Cloudbees [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/142261 [15:59:05] Raymond_: ? [15:59:51] (03CR) 10Cmcmahon: [C: 032] Moved MultimediaViewer jobs from Cloudbees [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/142261 (owner: 10Zfilipin) [16:00:08] Nemo_bis: Raymond_: it updated some qqq entries, and that's all [16:00:16] (the l10n-bot, that is) [16:00:24] (03Merged) 10jenkins-bot: Moved MultimediaViewer jobs from Cloudbees [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/142261 (owner: 10Zfilipin) [16:00:47] (where by "updated some qqq entries" i mean "it reverted the changes i made in the files in core"…) [16:02:04] it's possible there was a configuration error, it was being inspected [16:03:17] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Add advanced search option to only search local files - 10https://bugzilla.wikimedia.org/61061#c1 (10Chad H.) 5NEW>3RESO/FIX https://gerrit.wikimedia.org/r/#/c/140567/ [16:04:10] Nemo_bis: is the code for the bot available? [16:04:21] Nemo_bis: this looks like it doesn't add new files to the git repository [16:04:44] Nemo_bis: (that is, it does `git commit -a` instead of `git add -A && git commit`, or something along these lines) [16:04:47] Raymond_: ^ [16:04:48] 3MediaWiki extensions / 3CirrusSearch: PHP Fatal error: Call to a member function getId() on a non-object in //w/extensions/CirrusSearch/includes/Updater.php on line 467 - 10https://bugzilla.wikimedia.org/66919#c2 (10Chad H.) 5NEW>3RESO/FIX Should be fixed with https://gerrit.wikimedia.org/r/#/c/141691/,... [16:06:20] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures unit tests trigger notices in MobileFrontend - 10https://bugzilla.wikimedia.org/67139 (10Antoine "hashar" Musso) 3NEW p:3Unprio s:3normal a:3None I have tried running phpunit unit tests with master versions of mw BetaFeatures and MobileFrontend and... [16:06:42] (03PS2) 10Jdlrobson: Highlight current sort option in navigation dropdown [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142141 (owner: 10Bsitu) [16:06:52] (03CR) 10jenkins-bot: [V: 04-1] Highlight current sort option in navigation dropdown [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142141 (owner: 10Bsitu) [16:06:56] it's all in twn repo [16:07:03] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures unit tests trigger notices in MobileFrontend - 10https://bugzilla.wikimedia.org/67139#c1 (10Antoine "hashar" Musso) Created attachment 15750 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15750&action=edit Notice: Undefined index: skin in /extension... [16:07:31] (03CR) 10Jdlrobson: Highlight current sort option in navigation dropdown (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142141 (owner: 10Bsitu) [16:07:47] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures unit tests trigger notices in MobileFrontend - 10https://bugzilla.wikimedia.org/67139#c2 (10Antoine "hashar" Musso) Created attachment 15751 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15751&action=edit Warning: array_search() expects parameter 2... [16:07:53] (03CR) 10Anomie: "> {{PAGENAME }} is not encoded using plain html entities. Nor does it use Sanitizer. It uses wfEscapeWikiText()." [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113518 (https://bugzilla.wikimedia.org/35628) (owner: 10Brian Wolff) [16:08:01] (03CR) 10Jdlrobson: [C: 04-1] "When initially loaded neither are selected. I'm not sure this is intended behaviour." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142141 (owner: 10Bsitu) [16:08:04] (03CR) 10Verdy p: "Obviously this requires some tests, notably because there are a few critical templates that are testing the presence of HTML encoding in P" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113518 (https://bugzilla.wikimedia.org/35628) (owner: 10Brian Wolff) [16:10:22] (03CR) 10Anomie: "You can test it right now on Beta Labs." [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113518 (https://bugzilla.wikimedia.org/35628) (owner: 10Brian Wolff) [16:11:02] (03CR) 10Jdlrobson: [C: 04-1] "I really think we should get out of this habit of using helpers for translations." (032 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142159 (owner: 10Bsitu) [16:11:31] MatmaRex: can we talk in #mediawiki-i18n [16:11:40] (03PS12) 10Hashar: (WIP) Experiment zuul-cloner with extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141846 [16:11:59] sure [16:14:47] 3Analytics / 3Refinery: Admin has duplicate monitoring in Icinga - 10https://bugzilla.wikimedia.org/67128 (10Kevin Leduc) [16:15:01] (03CR) 10SG: [C: 04-1] Re-implement terms-of-use (032 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142159 (owner: 10Bsitu) [16:15:41] (03CR) 10EBernhardson: "the problem with the helpers for terms of use is that whoever wrote the WikimediaMessagesExtension was insane :P" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142159 (owner: 10Bsitu) [16:21:26] (03CR) 10Jdlrobson: Re-implement terms-of-use (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142159 (owner: 10Bsitu) [16:22:11] (03CR) 10Verdy p: "About these 2 lines:" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113518 (https://bugzilla.wikimedia.org/35628) (owner: 10Brian Wolff) [16:25:47] 3Analytics / 3Wikimetrics: Story: User creates cohort with CentralAuth insertions - 10https://bugzilla.wikimedia.org/66843 (10Kevin Leduc) [16:28:01] (03PS1) 10Deepali: Fixed a minor bug with chapterlist dropdown [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/142268 [16:28:55] (03CR) 10Jdlrobson: "So this is how I'd do it... 1) Reserve message keys for all of these things e.g. 'flow-terms-of-use-new-topic-donottranslate' and make a n" (032 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142159 (owner: 10Bsitu) [16:32:33] (03CR) 10Brian Wolff: "It is used. $trimExpanded is passed by reference. Read the doccomment of the function" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/113518 (https://bugzilla.wikimedia.org/35628) (owner: 10Brian Wolff) [16:37:47] (03CR) 10Reedy: [C: 032] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/142270 (owner: 10L10n-bot) [16:38:00] (03PS1) 10Reedy: Localisation updates from https://translatewiki.net. [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142271 [16:38:10] (03CR) 10Reedy: [C: 032] Localisation updates from https://translatewiki.net. [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142271 (owner: 10Reedy) [16:38:13] (03CR) 10Bartosz Dziewoński: [C: 031] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/142270 (owner: 10L10n-bot) [16:39:24] * Reedy waits for Jenkins [16:41:24] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/142270 (owner: 10L10n-bot) [16:42:43] (03CR) 10SG: "Honestly, I don't know what the solution is here. I'll defer to Jon and Erik on this. I don't know what the ideal way is to get the TOU wi" (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142159 (owner: 10Bsitu) [16:44:42] (03PS1) 10Jforrester: Resourcs: Enable es5-shim for mobile as well as desktop target [core] - 10https://gerrit.wikimedia.org/r/142272 [16:45:34] (03CR) 10Krinkle: "Resources*, and for json as well?" [core] - 10https://gerrit.wikimedia.org/r/142272 (owner: 10Jforrester) [16:46:43] (03PS2) 10Jforrester: Resources: Enable es5-shim and json for mobile as well as desktop target [core] - 10https://gerrit.wikimedia.org/r/142272 [16:47:10] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142271 (owner: 10Reedy) [16:47:23] "all the TOUs" :o [16:49:44] (03PS1) 10Bartosz Dziewoński: Vector: Rename description message: vector-desc → vector-skin-desc [core] - 10https://gerrit.wikimedia.org/r/142277 [16:50:34] (03CR) 10Nikerabbit: [C: 032] Vector: Rename description message: vector-desc → vector-skin-desc [core] - 10https://gerrit.wikimedia.org/r/142277 (owner: 10Bartosz Dziewoński) [16:53:09] (03CR) 10Catrope: [C: 032] Resources: Enable es5-shim and json for mobile as well as desktop target [core] - 10https://gerrit.wikimedia.org/r/142272 (owner: 10Jforrester) [16:53:19] Reedy: Any chance of a quick MW wmf11 extra patch? [16:53:30] (03PS1) 10Jforrester: Resources: Enable es5-shim and json for mobile as well as desktop target [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142280 [16:53:37] James_F: Yeah... I'm doing scap take 2 as it stands anyway [16:53:56] Reedy: https://gerrit.wikimedia.org/r/142280 [16:54:14] (03CR) 10Reedy: [C: 032] Resources: Enable es5-shim and json for mobile as well as desktop target [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142280 (owner: 10Jforrester) [16:54:21] Thanks! [16:54:40] James_F: why isn't there a test to detect this? :( [16:54:42] (03Merged) 10jenkins-bot: Vector: Rename description message: vector-desc → vector-skin-desc [core] - 10https://gerrit.wikimedia.org/r/142277 (owner: 10Bartosz Dziewoński) [16:54:54] i wonder how hard would it be to write one [16:55:05] probably unpleasantly hard [16:55:08] nevermind. [16:55:09] :P [16:55:18] (03PS1) 10Jdlrobson: Hygiene: Documentation updates [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/142281 [16:55:33] MatmaRex: Actually there is a mobile-jenkins pipeline. [16:55:36] MatmaRex: Apparently. [16:55:41] I found out about this yesterday [16:55:50] (As I said. :-)) [16:56:10] James_F: i mean checking if dependencies are satisfiable with the targets defined [16:56:15] (03Merged) 10jenkins-bot: Resources: Enable es5-shim and json for mobile as well as desktop target [core] - 10https://gerrit.wikimedia.org/r/142272 (owner: 10Jforrester) [16:56:39] there is already a ResourcesTest::testDependencies() that checks something else [16:56:43] MatmaRex: Core dependencies were. This was a MF dependency. Testing across all repos would be… fun. [16:57:03] James_F: no, this was just core: [16:57:28] James_F: oojs depends on es5-shim. oojs has targets: mobile, desktop. es5-shim has targets: desktop. therefore the dependency is sometimes unsatisfiable [16:57:40] MatmaRex: Oh, that bit. Yeah. [16:58:35] (03Merged) 10jenkins-bot: Resources: Enable es5-shim and json for mobile as well as desktop target [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142280 (owner: 10Jforrester) [16:59:02] MatmaRex: The real problem was that MF's VE dependency is target:mobile dependency:es5-shim. [16:59:10] noob question here; where does discussion typically take place for rfcs? talk pages? mls? the kitchen? [16:59:20] MatmaRex: Non-core generally happens more often. [17:00:16] James_F: aren't core's phpunit tests also ran when extension's phpunit tests are ran? [17:02:30] (03CR) 10CSteipp: [C: 031] "That's kinda funny, although in production with mwscript, this may have worked correctly. Unless Sam knows of a reason it was done this wa" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/142201 (owner: 10Legoktm) [17:04:34] K4-713: https://gerrit.wikimedia.org/r/#/c/142282/ "seriously, really" last one [17:05:09] ori: Now you're just trolling. :p [17:05:47] 3Analytics / 3EventLogging: Fix per schema counts in graphite - 10https://bugzilla.wikimedia.org/67073 (10Dan Andreescu) [17:06:32] 3Analytics / 3Wikimetrics: Cohort listing going against the database instead of using CohortService - 10https://bugzilla.wikimedia.org/66126 (10Dan Andreescu) [17:07:35] ori: Done! [17:08:39] (03CR) 10Legoktm: "Well, I tried running it on terbium last night, but since mwscript requires you pass a --wiki parameter it wouldn't work." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/142201 (owner: 10Legoktm) [17:09:48] 3Analytics / 3Refinery: Admin has versioned and sync'ed files in HDFS - 10https://bugzilla.wikimedia.org/67129 (10christian) [17:14:56] K4-713: thanks! [17:15:30] ori: I feel like you're dragging us into the present. Thank you. (Somebody had to) [17:16:47] (03CR) 10Ori.livneh: [C: 032] Load ext.wikiLove.local via module dependencies [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/100338 (owner: 10Legoktm) [17:17:08] (03Merged) 10jenkins-bot: Load ext.wikiLove.local via module dependencies [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/100338 (owner: 10Legoktm) [17:17:38] (03CR) 10Jdlrobson: [C: 031] Show extended watchlist if user has such in preference [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142167 (owner: 10Bsitu) [17:18:32] 3MediaWiki / 3Patrolling: Moved paged cannot be verified - 10https://bugzilla.wikimedia.org/64254#c4 (10Andyrom75) I don't know if it's the same bug, however I've just noticed that after moving the page https://it.wikivoyage.org/wiki/Stintino into https://it.wikivoyage.org/wiki/Sardegnamylove/Stintino the or... [17:18:40] (03CR) 10Jdlrobson: [C: 031] "Just reshuffling of code right? No actual changes to the code..?" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142191 (owner: 10EBernhardson) [17:19:24] (03CR) 10Jdlrobson: [C: 032] Three states are not a toggle, should be "Switch to". [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142239 (owner: 10Matthias Mullie) [17:19:38] (03CR) 10jenkins-bot: [V: 04-1] Three states are not a toggle, should be "Switch to". [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142239 (owner: 10Matthias Mullie) [17:20:19] (03PS3) 10Jdlrobson: Three states are not a toggle, should be "Switch to". [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142239 (owner: 10Matthias Mullie) [17:20:42] (03PS1) 10Rohan013: Replaces gzopen() function with gzopen64() [core] - 10https://gerrit.wikimedia.org/r/142287 (https://bugzilla.wikimedia.org/66952) [17:20:44] (03CR) 10jenkins-bot: [V: 04-1] Three states are not a toggle, should be "Switch to". [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142239 (owner: 10Matthias Mullie) [17:21:02] 3Analytics / 3Wikimetrics: Story: CronUser backfills NewlyRegistered User for recurring reports - 10https://bugzilla.wikimedia.org/66841 (10Dan Andreescu) [17:21:02] 3Analytics / 3EventLogging: Fix per schema counts in graphite - 10https://bugzilla.wikimedia.org/67073 (10Dan Andreescu) [17:21:02] 3Analytics / 3Refinery: Admin has versioned and sync'ed files in HDFS - 10https://bugzilla.wikimedia.org/67129 (10Dan Andreescu) [17:21:11] (03CR) 10CSteipp: [C: 032] checkLocalNames: fix --wiki option [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/142201 (owner: 10Legoktm) [17:21:13] (03CR) 10EBernhardson: "please move check into isRecordHidden to remove duplication" (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142167 (owner: 10Bsitu) [17:21:17] 3Analytics / 3Refinery: Admin has duplicate monitoring in Icinga - 10https://bugzilla.wikimedia.org/67128 (10Dan Andreescu) [17:22:08] (03Merged) 10jenkins-bot: checkLocalNames: fix --wiki option [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/142201 (owner: 10Legoktm) [17:22:32] 3Analytics / 3Wikimetrics: Path to recurrent report (from dashboard) should have better semantics - 10https://bugzilla.wikimedia.org/66087 (10Dan Andreescu) p:5Normal>3High [17:22:54] (03PS2) 10EBernhardson: Show extended watchlist if user has such in preference [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142167 (owner: 10Bsitu) [17:23:03] (03CR) 10jenkins-bot: [V: 04-1] Show extended watchlist if user has such in preference [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142167 (owner: 10Bsitu) [17:25:37] (03PS2) 10Rohan013: Replaces gzopen() function with gzopen64() [core] - 10https://gerrit.wikimedia.org/r/142287 (https://bugzilla.wikimedia.org/66952) [17:25:39] (03CR) 10SG: [C: 04-1] "Agreed with Jon. Let's come back to this next sprint." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141371 (owner: 10Werdna) [17:27:12] (03CR) 10Rohan013: "Changes spaces to indents" [core] - 10https://gerrit.wikimedia.org/r/142287 (https://bugzilla.wikimedia.org/66952) (owner: 10Rohan013) [17:28:34] 3MediaWiki extensions / 3[other]: ZeroPortal unit tests throws Warning: JsonConfig: Invalid $wgJsonConfigs['JsonZeroConfig']['url']: API URL is not set ... - 10https://bugzilla.wikimedia.org/67142 (10Antoine "hashar" Musso) 3NEW p:3Unprio s:3normal a:3None I am working on a Jenkins jobs that runs php... [17:28:47] 3MediaWiki extensions / 3[other]: ZeroPortal unit tests throws Warning: JsonConfig: Invalid $wgJsonConfigs['JsonZeroConfig']['url']: API URL is not set ... - 10https://bugzilla.wikimedia.org/67142#c1 (10Antoine "hashar" Musso) Created attachment 15752 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15... [17:29:41] (03Restored) 10Bartosz Dziewoński: ResourceLoader: Test that no modules have unfulfillable dependency targets [core] - 10https://gerrit.wikimedia.org/r/130024 (https://bugzilla.wikimedia.org/64513) (owner: 10Bartosz Dziewoński) [17:29:52] (03PS5) 10Bartosz Dziewoński: ResourceLoader: Test that all module dependencies are satisfiable [core] - 10https://gerrit.wikimedia.org/r/130024 (https://bugzilla.wikimedia.org/64513) [17:30:04] 3Wikimedia / 3Bugzilla: Create a MediaWiki extensions component for ZeroPortal - 10https://bugzilla.wikimedia.org/67143 (10Antoine "hashar" Musso) 3NEW p:3Unprio s:3normal a:3None mediawiki/extensions/ZeroPortal is missing a Bugzilla component. Default CC should probably be abaso@wikimedia.org and y... [17:30:32] 3Wikimedia / 3Bugzilla: Create a MediaWiki extensions component for ZeroPortal - 10https://bugzilla.wikimedia.org/67143#c1 (10Antoine "hashar" Musso) Adding CC [17:30:46] (03CR) 10Bartosz Dziewoński: "Krinkle, can I please receive an explanation why "it doesn't work that way"?" [core] - 10https://gerrit.wikimedia.org/r/130024 (https://bugzilla.wikimedia.org/64513) (owner: 10Bartosz Dziewoński) [17:31:02] 3Wikimedia / 3Language setup: Update list of most often used messages for MediaWiki core at Wikimedia - 10https://bugzilla.wikimedia.org/63416 (10Nemo) [17:31:02] 3MediaWiki extensions / 3Translate: Support core-0-mostused with JSON file format - 10https://bugzilla.wikimedia.org/63415 (10Nemo) [17:31:21] (03CR) 10jenkins-bot: [V: 04-1] ResourceLoader: Test that all module dependencies are satisfiable [core] - 10https://gerrit.wikimedia.org/r/130024 (https://bugzilla.wikimedia.org/64513) (owner: 10Bartosz Dziewoński) [17:32:06] (03CR) 10Krinkle: "There are more things to test, but I don't want to spend too much effort on perfect coverage inside a change that is unrelated to any of t" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/141660 (https://bugzilla.wikimedia.org/65752) (owner: 10Nikerabbit) [17:32:25] (03CR) 10Manybubbles: [C: 032] Tighten up error handlings [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/142067 (https://bugzilla.wikimedia.org/67095) (owner: 10Chad) [17:32:38] (03Merged) 10jenkins-bot: Tighten up error handlings [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/142067 (https://bugzilla.wikimedia.org/67095) (owner: 10Chad) [17:32:41] (03PS6) 10Bartosz Dziewoński: ResourceLoader: Test that all module dependencies are satisfiable [core] - 10https://gerrit.wikimedia.org/r/130024 (https://bugzilla.wikimedia.org/64513) [17:33:33] 3Analytics / 3EventLogging: Fix per schema counts in graphite - 10https://bugzilla.wikimedia.org/67073 (10nuria) a:3nuria [17:34:21] (03PS5) 10Jdlrobson: mediawiki.ui: Rename .mw-ui-vform-div → .mw-ui-vform-field [core] - 10https://gerrit.wikimedia.org/r/133724 (owner: 10Bartosz Dziewoński) [17:34:27] (03CR) 10Jdlrobson: [C: 032] mediawiki.ui: Rename .mw-ui-vform-div → .mw-ui-vform-field [core] - 10https://gerrit.wikimedia.org/r/133724 (owner: 10Bartosz Dziewoński) [17:34:49] (03CR) 10Krinkle: ResourceLoader: Test that all module dependencies are satisfiable (031 comment) [core] - 10https://gerrit.wikimedia.org/r/130024 (https://bugzilla.wikimedia.org/64513) (owner: 10Bartosz Dziewoński) [17:35:25] (03PS4) 10Jdlrobson: SpecialVersion: Show 'Skins' and 'Extensions' in separate sections [core] - 10https://gerrit.wikimedia.org/r/136615 (owner: 10Bartosz Dziewoński) [17:36:02] 3MediaWiki / 3JavaScript: VisualEditor: When editing a template, the title is truncated at first dot (period) - 10https://bugzilla.wikimedia.org/66939#c2 (10Alex Monk) Yep. mw.Title.newFromText( 'Template:Asd.com' ).getNameText() "Asd" [17:36:26] (03PS7) 10Bartosz Dziewoński: ResourceLoader: Test that all module dependencies are satisfiable [core] - 10https://gerrit.wikimedia.org/r/130024 (https://bugzilla.wikimedia.org/64513) [17:36:28] (03CR) 10Bartosz Dziewoński: ResourceLoader: Test that all module dependencies are satisfiable (031 comment) [core] - 10https://gerrit.wikimedia.org/r/130024 (https://bugzilla.wikimedia.org/64513) (owner: 10Bartosz Dziewoński) [17:36:32] 3Wikimedia / 3Bugzilla: Create a MediaWiki extensions component for ZeroPortal - 10https://bugzilla.wikimedia.org/67143#c2 (10Tyler Romeo) There is already the "ZeroRatedMobileAccess" component, but it seems that extension has been split into ZeroPortal and ZeroBanner. Should components be made for both? [17:37:05] (03PS1) 10Manybubbles: Support highlighting regexes [search/highlighter] - 10https://gerrit.wikimedia.org/r/142289 [17:37:47] 3MediaWiki / 3JavaScript: VisualEditor: When editing a template, the title is truncated at first dot (period) - 10https://bugzilla.wikimedia.org/66939#c3 (10Krinkle) getNameText() explicitly leaves out any faux extension. That's by design. To get the page title, use getMainText. https://doc.wikimedia.org/m... [17:38:17] 3MediaWiki / 3Watchlist: Editing large (10k+) watchlist [Special:EditWatchlist but not /raw] fails with HTTP error 500 (fatal error, OOM) - 10https://bugzilla.wikimedia.org/39510#c27 (10Bawolff (Brian Wolff)) *** Bug 67123 has been marked as a duplicate of this bug. *** [17:38:17] 3Wikimedia / 3General/Unknown: Error 503 trying to access watchlist on Serbo-Croatian Wikipedia - 10https://bugzilla.wikimedia.org/67123#c3 (10Bawolff (Brian Wolff)) 5UNCO>3RESO/DUP This is a known issue *** This bug has been marked as a duplicate of bug 39510 *** [17:39:25] (03Merged) 10jenkins-bot: mediawiki.ui: Rename .mw-ui-vform-div → .mw-ui-vform-field [core] - 10https://gerrit.wikimedia.org/r/133724 (owner: 10Bartosz Dziewoński) [17:39:34] 3MediaWiki / 3Email: editmyoptions blocks confirming email - 10https://bugzilla.wikimedia.org/67145 (10Mark A. Hershberger) 3NEW p:3Unprio s:3normal a:3None Just found a problem with how the editmyoptions interacts with wgEmailAuthentication. When I set up an account on a wiki where editmyoptions wa... [17:40:36] K4-713: i liked [17:40:39] *lied [17:40:40] https://gerrit.wikimedia.org/r/#/c/142290/ [17:40:45] sorry, i really think that's it [17:40:58] ori: hehe, no worries. [17:40:58] ori: WTF? [17:41:06] RoanKattouw: ? [17:41:08] ori: Oh that commit isn't a lie? [17:41:18] But I guess your earlier assertion that you were done was a lie? [17:41:23] no, i meant i lied about the last being being the last one :) [17:41:24] yes [17:41:29] * RoanKattouw calms down [17:41:39] resourceloader did not go gaga :) [17:41:46] 3Wikimedia / 3General/Unknown: Error 503 trying to access watchlist on Serbo-Croatian Wikipedia - 10https://bugzilla.wikimedia.org/67123#c4 (10Bawolff (Brian Wolff)) 5RESO/DUP>3REOP (In reply to Bawolff (Brian Wolff) from comment #3) > This is a known issue > > *** This bug has been marked as a duplicat... [17:42:05] (03CR) 10jenkins-bot: [V: 04-1] ResourceLoader: Test that all module dependencies are satisfiable [core] - 10https://gerrit.wikimedia.org/r/130024 (https://bugzilla.wikimedia.org/64513) (owner: 10Bartosz Dziewoński) [17:42:14] ori: Happy to see that you're cleaning up RL-related things in DonateInterface [17:42:20] Seriously. [17:42:32] K4-713: Less happy to see that that repo apparently allows Jenkins-bypass merges? [17:42:37] Not so much anymore. [17:42:39] it's a core test that is failing [17:42:50] 9:32am C+2 Awight V+2 Awight [17:42:53] RoanKattouw: All three of those tests used to be jfyi status. :/ [17:42:53] Oh, OK [17:43:26] Did they suddenly become voting rather than nonvoting? [17:43:32] * RoanKattouw looks in Krinkle's general direction [17:43:55] It's not very effective... [17:44:31] RoanKattouw: Well, actually, I went on a phpunit rampage a couple months ago. [17:44:36] Ahm [17:44:38] Krinkle uses "detach"! [17:44:41] It's very effective! [17:44:46] So it looks like jslint is actually nonvoting [17:44:51] yep [17:44:52] And Adam's V+2 was unnecessary on that commit [17:45:01] Matt's commit is V-1 due to phpunit tests breaking [17:45:07] ? [17:45:15] And is WIP so what do you expect :P [17:45:44] Oh, right. Yes. [17:46:59] (03CR) 10Bartosz Dziewoński: mediawiki.ui: Rename .mw-ui-vform-div → .mw-ui-vform-field (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133724 (owner: 10Bartosz Dziewoński) [17:47:13] In any case -- run your repo how you want to run it, just saying that we (VE) have taken away V+1/V+2 voting rights as well as merge rights away from humans, so all merges must be performed by jenkins-bot [17:47:25] RoanKattouw: Yep, I want that. [17:47:35] Honest. [17:47:42] Do you want it now? [17:48:14] I think the biggest concern, was the false negatives with the js tests. [17:48:29] jslint? [17:48:42] I can tell your repo doesn't pass it, there are tons of errors [17:49:13] Yeah... and, we really need to clean that up before we make that voting, or we can't do what we need to do. [17:49:16] Which is probably due to some combination of 1) you need to configure it to apply the rules you want, 2) you need to configure it to exclude libraries and other files that should be excluded and 3) you need to clean up your code [17:49:30] Almost certainly all three of those things. [17:49:41] But yeah right now it's non-voting and successfully so, I saw a commit that Jenkins approved despite boatloads of jshint errors [17:49:53] Yep. We know. [17:50:14] That's separate from the ACL stuff though [17:50:30] (03PS1) 10Hashar: mwconf: wgShowDBErrorBacktrace = true [integration/jenkins] - 10https://gerrit.wikimedia.org/r/142291 [17:50:30] I can set that up easily, unless it's something that needs more people to be on board [17:50:43] Krinkle, yt? looks like some packages are outdated/broken on integration: PHP Deprecated: Comments starting with '#' are deprecated in /etc/php5/cli/conf.d/fss.ini on line 1 in Unknown on line 0 [17:50:43] (03CR) 10Bartosz Dziewoński: "Thanks, this looks sensible." [core] - 10https://gerrit.wikimedia.org/r/141604 (owner: 10Krinkle) [17:50:48] RoanKattouw: orly. Are you volunteering? [17:50:51] PHP Warning: PHP Startup: Unable to load dynamic library '/usr/lib/php5/20090626/apc.so' - /usr/lib/php5/20090626/apc.so: cannot open shared object file: No such file or directory in Unknown on line 0 [17:50:56] Because YES PLEASE. [17:51:48] (03CR) 10Bartosz Dziewoński: "Yay!" [core] - 10https://gerrit.wikimedia.org/r/133724 (owner: 10Bartosz Dziewoński) [17:52:47] 3Wikimedia / 3Deployment systems: [scap] Deployment: Repository .git is synchronised fine, but is broken for submodules because of hardcoded gitdir link - 10https://bugzilla.wikimedia.org/53972#c19 (10Bryan Davis) (In reply to Bryan Davis from comment #18) > I'll spend some more time looking into why $IP is... [17:52:51] K4-713: The standard setup is to only apply this to master. Are there any other branches where V+2 and merging should be strictly limited to jenkins-bot? I see a deploy-payments_1.22 in your ACL, is that gated or is it just git push? (ACL suggests latter) [17:53:13] Also holy crap why does the platform-engineering group have *force push* permissions to *all of your branches including master* [17:53:23] O_O [17:53:25] (Current ACL: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/DonationInterface,access ) [17:53:34] That seems... bad. [17:54:00] Can you tell when that happened / who made that happen? [17:54:20] This information is stored in git indirectly, so let me dig around [17:55:00] Unreviewed code is bad for PCI. Very bad. [17:55:09] Yeeeaaah [17:55:25] (03PS1) 10Bartosz Dziewoński: Setup.php: Update comment about loading default skins [core] - 10https://gerrit.wikimedia.org/r/142293 [17:55:47] But, to answer your original question: We just push to deploy. [17:55:55] OK [17:56:06] So I'll only set up this jenkins-only thing for master then [17:56:10] In fact, we remove all the test code from deployment branches, so it wouldn't even make sense for some of those jobs to run. [17:58:04] 3MediaWiki extensions / 3Math: Math tests dies when run with the Echo extensions - 10https://bugzilla.wikimedia.org/67148 (10Antoine "hashar" Musso) 3NEW p:3Unprio s:3normal a:3None I have try running the unit tests with both Echo and Math installed and ends up with a database error: $ ls -1 extensi... [17:59:10] (03PS1) 10Cmcmahon: WIP: Port preferences test from /qa repo [core] - 10https://gerrit.wikimedia.org/r/142295 [18:01:02] 3MediaWiki extensions / 3Math: Math tests dies when run with the Echo extensions - 10https://bugzilla.wikimedia.org/67148#c1 (10Antoine "hashar" Musso) tests/MathDatabaseTest.php has: public function testCreateTable() { ... $dbu->doUpdates( array( "extensions" ) ); ... among other. Commenting out th... [18:01:31] (03PS2) 10Cmcmahon: WIP: Port preferences test from /qa repo [core] - 10https://gerrit.wikimedia.org/r/142295 [18:01:32] 3MediaWiki / 3API: Autogenerated XML schema - 10https://bugzilla.wikimedia.org/14025#c7 (10Max Semenik) 5NEW>3RESO/WON No objections voiced --> executing. [18:02:34] 3MediaWiki / 3API: Remove API action=parse&prop=languageshtml in 1.24 - 10https://bugzilla.wikimedia.org/67149 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None 1.23 release notes say that the API action=parse&prop=languageshtml will be removed in 1.24 (added in b07a2219fb31bdfb7058180af5452b38... [18:04:18] 3MediaWiki / 3Email: editmyoptions blocks confirming email - 10https://bugzilla.wikimedia.org/67145#c1 (10Kunal Mehta (Legoktm)) Why is editmyoptions not being given to new users? It should be given to all users with an account. [18:06:15] manybubbles: ^d is there someway of doing searches only on article title, but not just prefix search? [18:06:22] so that 'beatles' also matches 'The beatles'? [18:06:37] YuviPanda: intitle:beatles [18:06:41] is that what you want? [18:06:51] manybubbles: yeah. would that be as fast as opensearch? [18:07:02] 3MediaWiki / 3Database: Drop unused rc_cur_time field from recentchanges table in version 1.24 - 10https://bugzilla.wikimedia.org/40667 (10Bartosz Dziewoński) [18:07:04] 3MediaWiki / 3Database: Drop column recentchanges.rc_cur_time in MSSQL in 1.24 - 10https://bugzilla.wikimedia.org/67151 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None There is a '@todo: add drop patch with 1.24' in tables.sql (added by Skizzerz in f7174057a4ec7b9c74babfe74290bb000204a581). S... [18:07:05] manybubbles: this is for the primary search interface in the apps, which gets used quite a lot [18:07:26] YuviPanda: its performance is similar to a regular full text search [18:07:30] (03CR) 10Paladox: "Hi there is json3 at https://github.com/bestiejs/json3" [core] - 10https://gerrit.wikimedia.org/r/140560 (owner: 10Krinkle) [18:07:44] because it still highlights the results - though it skips generating search suggestions [18:07:59] we can make something else if we need [18:08:05] 3Wikimedia / 3Site requests: Set $wgEnableUploads false for ms.wiktionary - 10https://bugzilla.wikimedia.org/67152 (10Nemo) 3NEW p:3Unprio s:3enhanc a:3None Uploading files locally is DILARANG (PROHIBITED), as pointed out https://ms.wiktionary.org/w/index.php?title=Wiktionary:K... [18:08:16] MatmaRex: Yes, but not vice versa. [18:08:20] (03PS4) 10Inchikutty: Embeds leaflet map based on OSM data to UploadWizard [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/141987 (https://bugzilla.wikimedia.org/56612) [18:09:40] manybubbles: right. what we'd want is something that does search *just* on the title, no highlighting [18:09:47] (03PS1) 10Reedy: Actually fetch config object in ApiQueryRecentChanges::getResultProperties [core] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142296 [18:09:55] (03CR) 10Reedy: [C: 032] Actually fetch config object in ApiQueryRecentChanges::getResultProperties [core] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142296 (owner: 10Reedy) [18:10:07] YuviPanda: that'd be easy to build [18:10:11] manybubbles: 'did you mean' search suggestions would be useful too. [18:10:17] manybubbles: that'll solve a lot of problems for us in the app :) [18:10:20] probably easier to customize full text search to allow you to turn off highlighting [18:10:31] YuviPanda: file a bug? [18:10:39] manybubbles: :D yes! [18:10:43] oh, you do want title highlighting righ? [18:10:49] right? just not article text [18:11:05] cause doing it client side is nasty [18:11:12] manybubbles: yeah, that'll be nice but not a hard requirement. [18:11:19] as in, failure prone [18:11:23] manybubbles: we don't do it right now (we just use opensearch) [18:12:13] YuviPanda: sure! so, yeah, I think you can actually do it right now but its based on a Cirrus-only-for-testing feature [18:12:17] 3MediaWiki / 3Skin and page rendering: Font Awesome not working on IE - 10https://bugzilla.wikimedia.org/67115#c4 (10Jumuro) Ok, so I easily sketched a simple page for the test. On a CSS: http://test.firefall-wiki.ru/fa-test/ On a Less:http://test.firefall-wiki.ru/fa-test/fa-test-less/ In a MediaWiki "FA"... [18:14:07] YuviPanda: https://en.wikipedia.org/w/index.php?title=Special%3ASearch&profile=default&search=intitle:beatles&fulltext=Search&cirrusSuppressSnippet [18:14:13] (03Merged) 10jenkins-bot: Actually fetch config object in ApiQueryRecentChanges::getResultProperties [core] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142296 (owner: 10Reedy) [18:14:38] https://en.wikipedia.org/w/index.php?title=Special%3ASearch&profile=default&search=intitle:beatles&fulltext=Search&cirrusSuppressSnippet&cirrusSuppressAltTitle [18:16:32] 3Analytics / 3Refinery: Admin has versioned and sync'ed files in HDFS - 10https://bugzilla.wikimedia.org/67129#c1 (10Toby Negrin) Can someone tell me more about this issue? I don't understand what it's for. I think it has to do with correctly bucketing the tables, but not sure. thanks, -Toby [18:16:48] manybubbles: checking [18:19:02] 3Analytics / 3Refinery: Admin has duplicate monitoring in Icinga - 10https://bugzilla.wikimedia.org/67128#c1 (10Toby Negrin) The duplicate monitoring describes detecting duplicate events in the Kafka logs. [18:23:13] (03PS2) 10Bsitu: Re-implement terms-of-use [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142159 [18:23:23] (03CR) 10jenkins-bot: [V: 04-1] Re-implement terms-of-use [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142159 (owner: 10Bsitu) [18:24:05] (03CR) 10Bsitu: "Just addressed the styling feedback, :)" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142159 (owner: 10Bsitu) [18:24:23] (03PS1) 10Inchikutty: UploadWizard: OSM embedding: Geocoding, reverse geocoding [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/142301 (https://bugzilla.wikimedia.org/56612) [18:24:30] (03CR) 10jenkins-bot: [V: 04-1] UploadWizard: OSM embedding: Geocoding, reverse geocoding [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/142301 (https://bugzilla.wikimedia.org/56612) (owner: 10Inchikutty) [18:25:38] (03CR) 10Aaron Schulz: [C: 032] Remove ImageGalleryBase::useSkin() (deprecated since 1.18) [core] - 10https://gerrit.wikimedia.org/r/141732 (owner: 10Umherirrender) [18:26:48] 3MediaWiki / 3Email: editmyoptions blocks confirming email - 10https://bugzilla.wikimedia.org/67145#c2 (10Mark A. Hershberger) (In reply to Kunal Mehta (Legoktm) from comment #1) > Why is editmyoptions not being given to new users? It should be given to all > users with an account. I would agree except that... [18:27:04] 3Wikimedia / 3Deployment systems: LocalisationUpdate needs to support updating skins/ as well as extensions/ - 10https://bugzilla.wikimedia.org/67154 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None LocalisationUpdate needs to support updating skins/ as well as extensions/. It is apparently p... [18:27:09] is jenkins broken? [18:27:17] 3MediaWiki / 3Skin and page rendering: Large number of CSS rules for external links - 10https://bugzilla.wikimedia.org/54604#c64 (10Gabriel Wicke) Looking at the linked CSS [1], to me it seems that the most complex rules are those matching on file extensions to figure out video / audio / document links. As t... [18:27:18] 3Wikimedia / 3Git/Gerrit: Deprecate/close mediawiki/extensions/skins - 10https://bugzilla.wikimedia.org/60927#c2 (10Bartosz Dziewoński) Bump. [18:28:17] 3Analytics / 3Refinery: Admin has versioned and sync'ed files in HDFS - 10https://bugzilla.wikimedia.org/67129#c2 (10Andrew Otto) Nope, this is for deploying jars and oozie xml files and anything else inside of hdfs. [18:29:13] aude: when is it not? [18:29:26] (03Merged) 10jenkins-bot: Remove ImageGalleryBase::useSkin() (deprecated since 1.18) [core] - 10https://gerrit.wikimedia.org/r/141732 (owner: 10Umherirrender) [18:29:36] (03CR) 10GWicke: "From https://bugzilla.wikimedia.org/show_bug.cgi?id=54604#c64:" [core] - 10https://gerrit.wikimedia.org/r/141973 (https://bugzilla.wikimedia.org/54604) (owner: 10Bartosz Dziewoński) [18:29:43] usually not [18:29:50] 3MediaWiki / 3ResourceLoader: Add jQuery mobile - 10https://bugzilla.wikimedia.org/67155 (10paladox2015) 3UNCO p:3Unprio s:3normal a:3None Hi could we add support for jquery mobile. Which is meant to work fast on mobiles. link http://jquerymobile.com/ [18:30:08] * aude waits to see what wikidata jenkins says [18:30:16] (03PS1) 10Reedy: Fix undefined $json usage [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/142302 [18:30:32] 3Analytics / 3Refinery: Admin has versioned and sync'ed files in HDFS - 10https://bugzilla.wikimedia.org/67129#c3 (10Toby Negrin) got it -- thanks [18:31:04] 3Wikimedia / 3Deployment systems: LocalisationUpdate needs to support updating skins/ as well as extensions/ - 10https://bugzilla.wikimedia.org/67154 (10Greg Grossmeier) p:5Unprio>3High s:5normal>3major a:3Sam Reed (reedy) [18:31:16] (03CR) 10Jdlrobson: [C: 032] SpecialVersion: Show 'Skins' and 'Extensions' in separate sections [core] - 10https://gerrit.wikimedia.org/r/136615 (owner: 10Bartosz Dziewoński) [18:33:16] (03CR) 10Jdlrobson: [C: 032] Setup.php: Update comment about loading default skins [core] - 10https://gerrit.wikimedia.org/r/142293 (owner: 10Bartosz Dziewoński) [18:35:08] (03Merged) 10jenkins-bot: SpecialVersion: Show 'Skins' and 'Extensions' in separate sections [core] - 10https://gerrit.wikimedia.org/r/136615 (owner: 10Bartosz Dziewoński) [18:35:12] (03CR) 10Jdlrobson: Stop using a suboptimal structure for Vector's variants menu (031 comment) [core] - 10https://gerrit.wikimedia.org/r/138368 (https://bugzilla.wikimedia.org/43406) (owner: 10Bartosz Dziewoński) [18:35:29] (03CR) 10Hashar: "Well done!" [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/142237 (owner: 10Zfilipin) [18:35:47] 3MediaWiki / 3Database: Drop column recentchanges.rc_cur_time in MSSQL in 1.24 - 10https://bugzilla.wikimedia.org/67151#c1 (10Umherirrender) todo was in tables.sql at that time, so that was only a copy. Field was removed with gerrit 125769 for mysql. Other databases needs follow up from developer with that... [18:36:09] (03CR) 10Bsitu: "Jon, approach one seems the same as the current solution, it's just a matter of hardcoding the mapping vs hooking the mapping. For approa" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142159 (owner: 10Bsitu) [18:36:12] (03CR) 10Aaron Schulz: [C: 032] Remove DatabaseMysqlBase::getLagFromProcesslist() (deprecated 1.19) [core] - 10https://gerrit.wikimedia.org/r/142013 (owner: 10Umherirrender) [18:36:22] (03Merged) 10jenkins-bot: Setup.php: Update comment about loading default skins [core] - 10https://gerrit.wikimedia.org/r/142293 (owner: 10Bartosz Dziewoński) [18:36:40] (03PS1) 10EBernhardson: do not submit: test patch [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142303 [18:37:26] manybubbles: so that search looks perfect :) If it can be made fast enough to be used primarily as a search 'list results as you type' feature (and no body highlight) that'll be great for us. [18:37:41] manybubbles: assuming there's an API for that as well. We can probably even cache it a bit. [18:38:01] (03CR) 10jenkins-bot: [V: 04-1] do not submit: test patch [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142303 (owner: 10EBernhardson) [18:38:14] (03PS1) 10Legoktm: Fix checkLocalNames [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/142304 [18:38:29] (03PS1) 10Reedy: Fix undefined $json usage [extensions/LocalisationUpdate] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142305 [18:38:38] (03PS1) 10Reedy: Fix undefined $json usage [extensions/LocalisationUpdate] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142306 [18:39:02] manybubbles: would that also do search suggest? so if I type intitle:batles it should suggest beatles? [18:39:04] manybubbles: filing bugs now [18:39:24] YuviPanda: intitle causes suggest to turn off, actually [18:39:25] (03Merged) 10jenkins-bot: Remove DatabaseMysqlBase::getLagFromProcesslist() (deprecated 1.19) [core] - 10https://gerrit.wikimedia.org/r/142013 (owner: 10Umherirrender) [18:39:28] but maybe we can fix that [18:39:33] (03CR) 10Aaron Schulz: [C: 032] Remove LoadBalancer::closeConnecton (deprecated since 1.18) [core] - 10https://gerrit.wikimedia.org/r/142016 (owner: 10Umherirrender) [18:39:36] manybubbles: ah, hmm. [18:39:44] manybubbles: but just intitle would be an improvement over what we have now [18:41:21] YuviPanda: its faster, certainly. like twice/three times as fast as a regular full text search [18:41:39] manybubbles: what does opensearch hi t, btw? [18:43:59] (03PS2) 10EBernhardson: do not submit: test patch [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142303 [18:44:07] (03CR) 10jenkins-bot: [V: 04-1] do not submit: test patch [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142303 (owner: 10EBernhardson) [18:44:35] YuviPanda: what does it hit? its a prefix search - its like 10x faster then the other one. [18:44:50] manybubbles: ah, right. [18:45:28] (03PS3) 10EBernhardson: do not submit: test patch [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142303 [18:47:45] (03Merged) 10jenkins-bot: Remove LoadBalancer::closeConnecton (deprecated since 1.18) [core] - 10https://gerrit.wikimedia.org/r/142016 (owner: 10Umherirrender) [18:47:56] (03PS4) 10Jdlrobson: make html to plaintext conversion explicit [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141614 (owner: 10EBernhardson) [18:48:22] (03CR) 10Jdlrobson: [C: 032] "I guess I'm not getting tests. I will say I told you so if anything breaks in future though :P" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141614 (owner: 10EBernhardson) [18:48:55] (03CR) 10jenkins-bot: [V: 04-1] make html to plaintext conversion explicit [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141614 (owner: 10EBernhardson) [18:50:47] 3MediaWiki / 3Email: editmyoptions blocks confirming email - 10https://bugzilla.wikimedia.org/67145#c3 (10Brad Jorsch) 5NEW>3RESO/INV (In reply to Mark A. Hershberger from comment #2) > (In reply to Kunal Mehta (Legoktm) from comment #1) > > Why is editmyoptions not being given to new users? It should be... [18:50:49] 3Wikimedia / 3Site requests: Set $wgEnableUploads false for ms.wiktionary - 10https://bugzilla.wikimedia.org/67152 (10Tomasz W. Kozlowski) 5NEW>3ASSI p:5Unprio>3Normal a:3Tomasz W. Kozlowski [18:51:49] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Failing to reindexMeta - 10https://bugzilla.wikimedia.org/67157 (10Nik Everett) 3NEW p:3Unprio s:3normal a:3None We're having trouble reindexing meta because we're hitting a page with an external link that contains invalid utf-8: [2014-06-26 18:43... [18:53:17] 3MediaWiki / 3Email: editmyoptions blocks confirming email - 10https://bugzilla.wikimedia.org/67145#c4 (10Mark A. Hershberger) (In reply to Kunal Mehta (Legoktm) from comment #1) > Why is editmyoptions not being given to new users? It should be given to all > users with an account. I would agree except that... [18:53:32] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Failing to reindexMeta - 10https://bugzilla.wikimedia.org/67157#c1 (10Nik Everett) p:5Unprio>3High index: /metawiki_general_1403807864/page/661035 caused IllegalArgumentException[Document contains at least one immense term in field="external_link" (who... [18:54:47] 3MediaWiki / 3Email: editmyoptions blocks confirming email - 10https://bugzilla.wikimedia.org/67145#c5 (10Mark A. Hershberger) 5RESO/INV>3REOP Reopening because it looks like the way permissions are interpreted has changed. [18:55:02] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Failing to reindex Meta - 10https://bugzilla.wikimedia.org/67157 (10Nik Everett) [18:55:09] evening [18:55:30] \o [18:56:45] (03CR) 10Mattflaschen: [C: 04-1] "I think one .click() handler would be simpler; see inline." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/139877 (owner: 10Gerrit Patch Uploader) [18:56:48] Krinkle|detached: RoanKattouw any idea what's going on with https://integration.wikimedia.org/ci/job/mwext-Flow-testextensions-master/5344/console Flow unable to merge code right now :( [18:57:17] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Failing to reindex Meta - 10https://bugzilla.wikimedia.org/67157#c2 (10Nik Everett) Looks like there are more such issues: cirrus_log/arwikisource.reindex.log:Warning: Search backend error during reindex. Error message is: No enabled connection [Called f... [18:58:45] jdlrobson: Which commit does that belong to? [19:00:10] jdlrobson: The cause isn't super obvious from the jenkins output, so I can't look into it more without a Gerrit link [19:01:17] (03PS4) 10EBernhardson: do not submit: test patch [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142303 [19:02:12] RoanKattouw: anything in Flow right now e.g. https://gerrit.wikimedia.org/r/#/c/141614/ [19:02:36] jdlrobson: It looks like Erik is playing with it and got https://gerrit.wikimedia.org/r/#/c/142303/ to pass [19:02:52] Also WTF that patch looks really scary [19:03:15] ebernhardson: Holy crap what kind of dark sorcery is going on there? [19:04:01] same jenkins issues for wikidata [19:04:19] (03PS1) 10Reedy: Add missing \ to Title [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/142310 [19:05:02] (03CR) 10BryanDavis: [C: 032] Add missing \ to Title [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/142310 (owner: 10Reedy) [19:05:08] (03Merged) 10jenkins-bot: Add missing \ to Title [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/142310 (owner: 10Reedy) [19:05:38] RoanKattouw here's a less controversial patch with same issue https://gerrit.wikimedia.org/r/#/c/142239/ [19:05:39] (03PS1) 10Reedy: Add missing \ to Title [extensions/OAuth] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142312 [19:05:40] aude: Hmm that sounds like an MW core problem then? [19:05:52] jdlrobson: It looks like Erik's patch is trying to work around the issue AFAICT [19:05:55] aude: Example link? [19:06:04] (03PS5) 10EBernhardson: Hack around failing jenkins tests [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142303 [19:06:04] https://integration.wikimedia.org/ci/job/mwext-Wikidata-testextensions-master/547/console [19:06:40] no problems earlier [19:07:41] wikidata jenkins approved of same patch [19:07:43] Hmm yeah that does look like an MW core problem [19:07:56] ebernhardson: You seem to have an idea what's going on? [19:08:00] could be a cached mw core version for wikidata jenkins [19:08:19] 3MediaWiki / 3Search: Catchable fatal error: Argument 1 passed to StringPrefixSearch::titles() must be an array, null given, called PrefixSearch.php on line 149 - 10https://bugzilla.wikimedia.org/67160 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3None [2014-06-26 19:00:56] Catchable fatal error:... [19:08:57] (03CR) 10Reedy: [C: 032] Add missing \ to Title [extensions/OAuth] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142312 (owner: 10Reedy) [19:09:11] (03Merged) 10jenkins-bot: Add missing \ to Title [extensions/OAuth] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142312 (owner: 10Reedy) [19:10:16] (03PS1) 10Bartosz Dziewoński: SpecialPage: Adjust type hint: Array → array [core] - 10https://gerrit.wikimedia.org/r/142314 [19:10:53] (03CR) 10Legoktm: [C: 032] SpecialPage: Adjust type hint: Array → array [core] - 10https://gerrit.wikimedia.org/r/142314 (owner: 10Bartosz Dziewoński) [19:11:46] 3MediaWiki / 3Email: editmyoptions blocks confirming email - 10https://bugzilla.wikimedia.org/67145#c6 (10Brad Jorsch) (In reply to Mark A. Hershberger from comment #4) > To be clear, their LocalSettings.php contains the following line: > > $wgGroupPermissions['*']['editmyoptions'] = false; Yes, that wo... [19:12:45] (03PS1) 10Reedy: Update OAuth to fix fatal [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142315 [19:12:47] manybubbles: filed https://bugzilla.wikimedia.org/show_bug.cgi?id=67161 [19:12:49] 3MediaWiki / 3Search: Implement API for intitle:ies that do only title highlighting - 10https://bugzilla.wikimedia.org/67161 (10Yuvi Panda) 3NEW p:3Unprio s:3normal a:3None Right now the Android and iOS apps use OpenSearch for suggestions-as-the-users type, which isn't the best because typing... [19:13:03] (03CR) 10Reedy: [C: 032 V: 032] Update OAuth to fix fatal [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142315 (owner: 10Reedy) [19:14:20] (03PS3) 10NativeForeigner: Make CheckUserLog trim trailing spaces [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/141610 [19:15:05] (03Merged) 10jenkins-bot: SpecialPage: Adjust type hint: Array → array [core] - 10https://gerrit.wikimedia.org/r/142314 (owner: 10Bartosz Dziewoński) [19:16:03] (03PS4) 10Legoktm: Make CheckUserLog trim trailing spaces [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/141610 (owner: 10NativeForeigner) [19:16:05] (03PS13) 10Hashar: (WIP) Experiment zuul-cloner with extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141846 [19:16:35] (03CR) 10Legoktm: [C: 032] "Yay! Congrats on your first patch!" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/141610 (owner: 10NativeForeigner) [19:17:22] (03Merged) 10jenkins-bot: Make CheckUserLog trim trailing spaces [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/141610 (owner: 10NativeForeigner) [19:17:35] RoanKattouw_away: stil here? the problem looks to be the --schema parameter being passed to update.php [19:18:07] RoanKattouw_away: in older jenkins logs(yesterday) where our tests pass --schema is not passed to update.php. When --schema is passed to update.php that writes the sql to a file intead of sending to db server [19:18:28] (03PS4) 10Aaron Schulz: Initial commit of new job runner loop [services/jobrunner] - 10https://gerrit.wikimedia.org/r/140618 [19:18:33] end result is that the post db-update scripts are still being run, but since --schema was used the db doesn't have nay expected tables [19:19:17] 3Wikimedia / 3Bugzilla: Create a MediaWiki extensions component for ZeroPortal - 10https://bugzilla.wikimedia.org/67143#c3 (10Yuri Astrakhan) I'm OK with either keeping existing component and using it for both ZeroBanner and ZeroPortal, or renaming it into ZeroBanner and creating a new ZeroPortal component. [19:22:17] 3MediaWiki / 3Search: Implement API for intitle:ies that do only title highlighting - 10https://bugzilla.wikimedia.org/67161#c1 (10Yuvi Panda) The API can also be fairly nicely cached, since delay as much as 1d is ok for the apps... [19:23:03] (03PS1) 10BryanDavis: Fix GitInfo cache file path computation and storage location [core] - 10https://gerrit.wikimedia.org/r/142319 (https://bugzilla.wikimedia.org/53972) [19:23:15] (03CR) 10Bsitu: [C: 032] Hack around failing jenkins tests [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142303 (owner: 10EBernhardson) [19:24:20] (03CR) 10EBernhardson: "recheck" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142036 (owner: 10Bsitu) [19:24:32] 3Wikimedia / 3Bugzilla: Create a MediaWiki extensions component for ZeroPortal - 10https://bugzilla.wikimedia.org/67143#c4 (10dr0ptp4kt) Arthur, what's your recommendation for Bugello? [19:25:02] 3MediaWiki extensions / 3ZeroRatedMobileAccess: ZeroPortal unit tests throws Warning: JsonConfig: Invalid $wgJsonConfigs['JsonZeroConfig']['url']: API URL is not set ... - 10https://bugzilla.wikimedia.org/67142 (10dr0ptp4kt) [19:25:07] (03PS2) 10BryanDavis: Fix GitInfo cache file path computation and storage location [core] - 10https://gerrit.wikimedia.org/r/142319 (https://bugzilla.wikimedia.org/53972) [19:26:19] aude: i think this is whatcaused our problems with jenkins: 67fda7c79a63dbb8825fdcc118209870b2f197ba [19:26:33] i mean https://gerrit.wikimedia.org/r/#/c/141851/ (same, but easier to click) [19:27:00] seems likely [19:27:31] yeah :/ [19:27:34] this new code we are adding passed on wmf jenkins 9 hours ago [19:28:00] although actually not sure it's running the new tests (wikidata jenkins is) :/ [19:28:15] * aude notes to update the config [19:28:24] anyone remember all the commands to actually push out jenkins changes? can revert it but i remember there is a whole process with the job builder and pushing to jenkins [19:30:14] (03Merged) 10jenkins-bot: Hack around failing jenkins tests [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142303 (owner: 10EBernhardson) [19:30:39] (03PS4) 10EBernhardson: Sticky sorting preference for users [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142036 (owner: 10Bsitu) [19:31:41] (03CR) 10EBernhardson: [C: 032] Sticky sorting preference for users [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142036 (owner: 10Bsitu) [19:31:59] (03Merged) 10jenkins-bot: Sticky sorting preference for users [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142036 (owner: 10Bsitu) [19:32:27] (03CR) 10EBernhardson: "recheck" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141614 (owner: 10EBernhardson) [19:32:32] 3MediaWiki extensions / 3ZeroRatedMobileAccess: ZeroPortal unit tests throws Warning: JsonConfig: Invalid $wgJsonConfigs['JsonZeroConfig']['url']: API URL is not set ... - 10https://bugzilla.wikimedia.org/67142#c2 (10Yuri Astrakhan) Can be fixed by adding ['isLocal']=true. Will try to get to it shortly or fe... [19:32:41] (03CR) 10jenkins-bot: [V: 04-1] Fix GitInfo cache file path computation and storage location [core] - 10https://gerrit.wikimedia.org/r/142319 (https://bugzilla.wikimedia.org/53972) (owner: 10BryanDavis) [19:34:29] (03PS10) 10EBernhardson: Use same placeholder in JS as non-js [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141585 [19:34:41] (03PS11) 10EBernhardson: Use same placeholder in JS as non-js [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141585 [19:35:20] (03PS3) 10BryanDavis: Fix GitInfo cache file path computation and storage location [core] - 10https://gerrit.wikimedia.org/r/142319 (https://bugzilla.wikimedia.org/53972) [19:36:33] 3MediaWiki extensions / 3SyntaxHighlight (GeSHi): UNIQ key exposed - 10https://bugzilla.wikimedia.org/14562#c11 (10Nemo) 5PATC>3RESO/FIX a:3Bawolff (Brian Wolff) Approved by Nikerabbit and translatewiki.net didn't explode. [19:37:03] 3MediaWiki extensions / 3Translate: Recursive parser calls - 10https://bugzilla.wikimedia.org/65826#c15 (10Nemo) 5PATC>3RESO/FIX a:3Bawolff (Brian Wolff) Approved by Nikerabbit and translatewiki.net didn't explode. [19:38:08] (03PS1) 10Mattflaschen: Upgrade jStorage to v0.4.10 to fix a bug with the TTL. [core] - 10https://gerrit.wikimedia.org/r/142371 [19:38:28] (03CR) 10EBernhardson: "This patch appears to have caused the test runners in Flow and WikiData to fail. This change means that `update.php --schema ...` is being" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141851 (owner: 10Hashar) [19:39:22] (03CR) 10jenkins-bot: [V: 04-1] Fix GitInfo cache file path computation and storage location [core] - 10https://gerrit.wikimedia.org/r/142319 (https://bugzilla.wikimedia.org/53972) (owner: 10BryanDavis) [19:39:24] (03CR) 10Mattflaschen: "It's actually https://github.com/andris9/jStorage/raw/67d59fa/jstorage.js . You can see https://github.com/andris9/jStorage/blob/v0.4.8/j" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/139689 (owner: 10Paladox) [19:40:28] (03PS1) 10Aude: Update Wikidata, for property suggester on test.wikidata [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142373 [19:40:45] (03PS1) 10Reedy: More missing \ [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/142374 [19:40:59] (03CR) 10Hashar: "so yeah earlier today while SF was happily dreaming , I have added ----schema to update.php to log the .sql command about to be run by upd" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142303 (owner: 10EBernhardson) [19:41:16] (03CR) 10EBernhardson: [C: 032] Use same placeholder in JS as non-js [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141585 (owner: 10EBernhardson) [19:41:22] (03PS5) 10EBernhardson: make html to plaintext conversion explicit [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141614 [19:41:43] (03CR) 10EBernhardson: [C: 032] "re-apply jdlrobson +2 earlier when jenkins denied it" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141614 (owner: 10EBernhardson) [19:42:04] (03Merged) 10jenkins-bot: Use same placeholder in JS as non-js [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141585 (owner: 10EBernhardson) [19:42:08] (03PS1) 10Reedy: Echo curl errors [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/142375 [19:42:13] (03PS1) 10Aude: Update Wikidata [tools/release] - 10https://gerrit.wikimedia.org/r/142376 [19:42:35] (03Merged) 10jenkins-bot: make html to plaintext conversion explicit [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141614 (owner: 10EBernhardson) [19:43:11] (03PS1) 10SPQRobin: Fix MediaWiki:Licenses requirement [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/142377 [19:43:46] (03CR) 10CSteipp: [C: 032] More missing \ [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/142374 (owner: 10Reedy) [19:43:53] (03Merged) 10jenkins-bot: More missing \ [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/142374 (owner: 10Reedy) [19:45:24] (03PS1) 10Reedy: Throw MWException, not Exception [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/142378 [19:46:10] (03PS1) 10Chad: Escape delimeter [core] - 10https://gerrit.wikimedia.org/r/142379 [19:46:17] 3MediaWiki extensions / 3General/Unknown: Perf review of Property Suggestor - php part - 10https://bugzilla.wikimedia.org/66381#c1 (10Aaron Schulz) 5NEW>3RESO/FIX I made a few comments at https://github.com/Wikidata-lib/PropertySuggester/pull/44/files . The code isn't too complex and don't see any obvio... [19:46:34] 3MediaWiki / 3Installer: update.php --schema runs post-db update maintenance scripts - 10https://bugzilla.wikimedia.org/67163 (10Erik Bernhardson) 3NEW p:3Unprio s:3normal a:3None When using the --schema option post-db maintenance scripts should not be run as they talk to the database directly and do... [19:47:17] 3MediaWiki / 3ResourceLoader: Add jQuery mobile - 10https://bugzilla.wikimedia.org/67155#c1 (10Andre Klapper) s:5normal>3enhanc Support for what exactly? Please provide a usecase, which exact problem you face right now, and how your proposed solution would help. Currently this bug report does not descri... [19:47:54] (03CR) 10Reedy: [C: 032] "[20:28:54] Uhg, need to escape /" [core] - 10https://gerrit.wikimedia.org/r/142379 (owner: 10Chad) [19:48:13] (03PS2) 10Bartosz Dziewoński: Escape delimiter [core] - 10https://gerrit.wikimedia.org/r/142379 (owner: 10Chad) [19:50:58] (03PS3) 10Parent5446: Escape delimiter in SpecialPage::prefixSearchArray [core] - 10https://gerrit.wikimedia.org/r/142379 (owner: 10Chad) [19:51:36] (03CR) 10Parent5446: [C: 032] Escape delimiter in SpecialPage::prefixSearchArray [core] - 10https://gerrit.wikimedia.org/r/142379 (owner: 10Chad) [19:51:42] (03PS1) 10Florianschmidtwelzow: Hygiene: Use the same typo of name (whitespace) [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142381 [19:51:53] (03CR) 10Umherirrender: [C: 04-1] "Needs little change due to merge of Iefe340729a55c9bb52a4931310966d0f33041205" [core] - 10https://gerrit.wikimedia.org/r/139455 (owner: 10Umherirrender) [19:51:58] (03CR) 10Parent5446: "Triple edit conflict right there. :P" [core] - 10https://gerrit.wikimedia.org/r/142379 (owner: 10Chad) [19:52:02] 3MediaWiki / 3Installer: update.php --schema runs post-db update maintenance scripts - 10https://bugzilla.wikimedia.org/67163#c1 (10Antoine "hashar" Musso) Thanks Erik, I have posted on wikitech-l: arlier today I slightly changed how Jenkins run the MediaWiki extension job. Specifically the way the databas... [19:52:26] (03CR) 10Raimond Spekking: [C: 032 V: 032] Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/134072 (owner: 10Smuggli) [19:52:42] (03PS1) 10EBernhardson: update.php --schema should not call maint scripts [core] - 10https://gerrit.wikimedia.org/r/142382 (https://bugzilla.wikimedia.org/67163) [19:52:47] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Failing to reindex Meta - 10https://bugzilla.wikimedia.org/67157#c3 (10Nik Everett) 5NEW>3ASSI OK! Those error messages - the ones about regex syntax errors will stop masking their real errors tonight. They are caused by update errors. Simple enough... [19:53:18] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Failing to reindex Meta - 10https://bugzilla.wikimedia.org/67157#c4 (10Nik Everett) a:3Nik Everett arwikisource is different - I'm not sure what is up with it. It errors out (every time) with Warning: Search backend error during reindex. Error message... [19:53:21] (03CR) 10jenkins-bot: [V: 04-1] update.php --schema should not call maint scripts [core] - 10https://gerrit.wikimedia.org/r/142382 (https://bugzilla.wikimedia.org/67163) (owner: 10EBernhardson) [19:53:35] (03CR) 10Florianschmidtwelzow: [C: 04-2] Hygiene: Use the same typo of name (whitespace) [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142381 (owner: 10Florianschmidtwelzow) [19:55:35] (03Merged) 10jenkins-bot: Escape delimiter in SpecialPage::prefixSearchArray [core] - 10https://gerrit.wikimedia.org/r/142379 (owner: 10Chad) [19:56:11] (03PS2) 10Florianschmidtwelzow: Hygiene: Typo, gitreview and \r [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142381 [19:56:13] (03PS2) 10EBernhardson: update.php --schema should not call maint scripts [core] - 10https://gerrit.wikimedia.org/r/142382 (https://bugzilla.wikimedia.org/67163) [19:57:21] (03PS1) 10Hashar: Revert "Use mw-run-update-script.sh script" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/142383 (https://bugzilla.wikimedia.org/67163) [19:57:24] (03CR) 10Florianschmidtwelzow: [C: 032 V: 031] Hygiene: Typo, gitreview and \r [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142381 (owner: 10Florianschmidtwelzow) [19:57:41] (03CR) 10Florianschmidtwelzow: [V: 032] Hygiene: Typo, gitreview and \r [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/142381 (owner: 10Florianschmidtwelzow) [19:58:03] (03CR) 10Reedy: [C: 032] Fix MediaWiki:Licenses requirement [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/142377 (owner: 10SPQRobin) [19:58:12] (03Merged) 10jenkins-bot: Fix MediaWiki:Licenses requirement [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/142377 (owner: 10SPQRobin) [19:58:15] (03PS1) 10Reedy: Fix MediaWiki:Licenses requirement [extensions/WikimediaMessages] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142384 [19:59:19] (03Abandoned) 10Hashar: Revert "Use mw-run-update-script.sh script" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/142383 (https://bugzilla.wikimedia.org/67163) (owner: 10Hashar) [19:59:54] (03CR) 10Reedy: [C: 032] Fix MediaWiki:Licenses requirement [extensions/WikimediaMessages] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142384 (owner: 10Reedy) [20:00:00] (03Merged) 10jenkins-bot: Fix MediaWiki:Licenses requirement [extensions/WikimediaMessages] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142384 (owner: 10Reedy) [20:01:03] (03PS1) 10Reedy: More missing \ [extensions/OAuth] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142385 [20:01:09] (03PS4) 10BryanDavis: Fix GitInfo cache file path computation and storage location [core] - 10https://gerrit.wikimedia.org/r/142319 (https://bugzilla.wikimedia.org/53972) [20:01:27] (03CR) 10Reedy: [C: 032] More missing \ [extensions/OAuth] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142385 (owner: 10Reedy) [20:02:27] (03Merged) 10jenkins-bot: More missing \ [extensions/OAuth] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142385 (owner: 10Reedy) [20:02:34] (03PS1) 10Hashar: Skip update.php --schema for now [integration/jenkins] - 10https://gerrit.wikimedia.org/r/142386 (https://bugzilla.wikimedia.org/67163) [20:03:01] (03CR) 10Hashar: [C: 032] Skip update.php --schema for now [integration/jenkins] - 10https://gerrit.wikimedia.org/r/142386 (https://bugzilla.wikimedia.org/67163) (owner: 10Hashar) [20:03:04] (03Merged) 10jenkins-bot: Skip update.php --schema for now [integration/jenkins] - 10https://gerrit.wikimedia.org/r/142386 (https://bugzilla.wikimedia.org/67163) (owner: 10Hashar) [20:03:37] (03CR) 10EBernhardson: [C: 032] "there are some minor issues, this is a behavior change from before(previously hidden children were toggle-collapsed rather than removed, s" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142137 (owner: 10Jdlrobson) [20:03:59] (03Merged) 10jenkins-bot: Hiding comments workflow [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142137 (owner: 10Jdlrobson) [20:04:30] (03PS3) 10EBernhardson: Point talk, username and block to appropriate URLS [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142150 (owner: 10Jdlrobson) [20:04:39] (03CR) 10jenkins-bot: [V: 04-1] Point talk, username and block to appropriate URLS [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142150 (owner: 10Jdlrobson) [20:05:19] 3MediaWiki / 3Installer: update.php --schema runs post-db update maintenance scripts - 10https://bugzilla.wikimedia.org/67163#c7 (10Antoine "hashar" Musso) 5PATC>3NEW update.php --schema is now commented out. The bug in core is still valid though. [20:08:09] (03CR) 10Aude: [C: 032] Update Wikidata, for property suggester on test.wikidata [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142373 (owner: 10Aude) [20:08:58] (03PS1) 10Reedy: Update WikimediaMessages and OAuth [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142387 [20:09:36] (03PS1) 10Hashar: Updater: rm caused an error [integration/jenkins] - 10https://gerrit.wikimedia.org/r/142388 [20:09:45] (03CR) 10Hashar: [C: 032] Updater: rm caused an error [integration/jenkins] - 10https://gerrit.wikimedia.org/r/142388 (owner: 10Hashar) [20:10:15] (03CR) 10jenkins-bot: [V: 04-1] Updater: rm caused an error [integration/jenkins] - 10https://gerrit.wikimedia.org/r/142388 (owner: 10Hashar) [20:10:18] (03Merged) 10jenkins-bot: Updater: rm caused an error [integration/jenkins] - 10https://gerrit.wikimedia.org/r/142388 (owner: 10Hashar) [20:11:09] <^d> Krinkleeeeeeee [20:11:13] (03CR) 10Hashar: "recheck" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142150 (owner: 10Jdlrobson) [20:11:20] (03Merged) 10jenkins-bot: Update Wikidata, for property suggester on test.wikidata [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142373 (owner: 10Aude) [20:11:53] (03CR) 10Chad: [C: 032] Set noindex,nofollow on missing (404) pages [core] - 10https://gerrit.wikimedia.org/r/141890 (owner: 10Aaron Schulz) [20:12:35] (03CR) 10Chad: [C: 032] Removed redundant begin/commit calls [core] - 10https://gerrit.wikimedia.org/r/141881 (owner: 10Aaron Schulz) [20:13:26] (03CR) 10Chad: [C: 032] Avoid begin/commit in Category::getCountMessage() [core] - 10https://gerrit.wikimedia.org/r/141877 (owner: 10Aaron Schulz) [20:13:43] (03CR) 10Chad: [C: 032] Avoid warnings for empty file sha1 keys [core] - 10https://gerrit.wikimedia.org/r/141741 (owner: 10Aaron Schulz) [20:15:05] (03CR) 10EBernhardson: [C: 032] "PS3: addressed PS2 comments" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142150 (owner: 10Jdlrobson) [20:15:32] (03Merged) 10jenkins-bot: Point talk, username and block to appropriate URLS [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142150 (owner: 10Jdlrobson) [20:15:47] (03PS2) 10EBernhardson: l10nParse handlebar implementation [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142146 (owner: 10Bsitu) [20:15:54] (03CR) 10EBernhardson: [C: 032] l10nParse handlebar implementation [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142146 (owner: 10Bsitu) [20:16:19] (03Merged) 10jenkins-bot: l10nParse handlebar implementation [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142146 (owner: 10Bsitu) [20:16:23] (03Merged) 10jenkins-bot: Set noindex,nofollow on missing (404) pages [core] - 10https://gerrit.wikimedia.org/r/141890 (owner: 10Aaron Schulz) [20:16:42] (03Merged) 10jenkins-bot: Removed redundant begin/commit calls [core] - 10https://gerrit.wikimedia.org/r/141881 (owner: 10Aaron Schulz) [20:16:58] (03Merged) 10jenkins-bot: Avoid begin/commit in Category::getCountMessage() [core] - 10https://gerrit.wikimedia.org/r/141877 (owner: 10Aaron Schulz) [20:17:00] (03PS1) 10EBernhardson: Revert "Hack around failing jenkins tests" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142389 [20:17:28] (03Merged) 10jenkins-bot: Avoid warnings for empty file sha1 keys [core] - 10https://gerrit.wikimedia.org/r/141741 (owner: 10Aaron Schulz) [20:17:46] (03PS3) 10EBernhardson: Consistently use TemplateHelper::html [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142200 [20:17:55] (03CR) 10EBernhardson: [C: 032] "re-apply bsitu +2" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142200 (owner: 10EBernhardson) [20:20:51] (03PS5) 10Bartosz Dziewoński: Allow skins to define skinStyles for arbitrary modules [core] - 10https://gerrit.wikimedia.org/r/141259 [20:23:37] (03PS2) 10Reedy: Update WikimediaMessages and OAuth [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142387 [20:23:43] (03CR) 10Reedy: [C: 032] Update WikimediaMessages and OAuth [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142387 (owner: 10Reedy) [20:23:46] (03CR) 10CSteipp: [C: 032] Echo curl errors [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/142375 (owner: 10Reedy) [20:25:17] 3MediaWiki extensions / 3WikiEditor: In Insert Image dialog box the Align and Format settings are not set to any values - 10https://bugzilla.wikimedia.org/67111 (10Ritu Swain) [20:26:12] (03CR) 10Greg Grossmeier: "Niklas: results from testing on translatewiki?" [core] - 10https://gerrit.wikimedia.org/r/141056 (https://bugzilla.wikimedia.org/14562) (owner: 10Brian Wolff) [20:26:47] 3MediaWiki extensions / 3SyntaxHighlight (GeSHi): UNIQ key exposed when feeding strip markers into {{#tag:source - 10https://bugzilla.wikimedia.org/14562#c12 (10Bawolff (Brian Wolff)) 5RESO/FIX>3REOP whoops, what am I doing. This one has a different cause for the UNIQ's. That patch won't fix it. [20:26:54] (03CR) 10Reedy: [V: 032] Update WikimediaMessages and OAuth [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142387 (owner: 10Reedy) [20:27:00] (03Merged) 10jenkins-bot: Echo curl errors [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/142375 (owner: 10Reedy) [20:27:03] (03CR) 10EBernhardson: [C: 032] "jon will be working on this in the next sprint, i think for the moment this is ok" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141990 (owner: 10Jdlrobson) [20:27:18] (03Merged) 10jenkins-bot: Consistently use TemplateHelper::html [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142200 (owner: 10EBernhardson) [20:27:28] (03CR) 10EBernhardson: [C: 032] Revert "Hack around failing jenkins tests" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142389 (owner: 10EBernhardson) [20:28:34] (03CR) 10EBernhardson: "yes this is just reshuffling no changes in functionality or called apis done in here" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142191 (owner: 10EBernhardson) [20:29:13] (03PS3) 10EBernhardson: Show extended watchlist if user has such in preference [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142167 (owner: 10Bsitu) [20:29:47] (03Merged) 10jenkins-bot: Hide visually broken elements in non-JavaScript site [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141990 (owner: 10Jdlrobson) [20:29:56] (03CR) 10EBernhardson: [C: 032] Show extended watchlist if user has such in preference [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142167 (owner: 10Bsitu) [20:30:10] (03Merged) 10jenkins-bot: Revert "Hack around failing jenkins tests" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142389 (owner: 10EBernhardson) [20:30:32] (03PS3) 10Bsitu: Highlight current sort option in navigation dropdown [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142141 [20:30:50] (03Merged) 10jenkins-bot: Show extended watchlist if user has such in preference [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142167 (owner: 10Bsitu) [20:31:01] ^d: what up [20:31:07] (03CR) 10Nikerabbit: "I found no issues, nothing in logs and no reports by any users about unexpected behavior." [core] - 10https://gerrit.wikimedia.org/r/141056 (https://bugzilla.wikimedia.org/14562) (owner: 10Brian Wolff) [20:31:19] (03PS4) 10EBernhardson: Three states are not a toggle, should be "Switch to". [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142239 (owner: 10Matthias Mullie) [20:31:28] (03CR) 10EBernhardson: [C: 032] "re-apply jdlrobson +2" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142239 (owner: 10Matthias Mullie) [20:31:32] 3MediaWiki / 3Email: editmyprivateinfo blocks confiirming email - 10https://bugzilla.wikimedia.org/67145#c7 (10Mark A. Hershberger) (In reply to Brad Jorsch from comment #6) > > because, when I take a new installation of MW 1.22 and 1.23, the > > permissions for 'editmyoptions' don't change. Instead, they r... [20:31:32] <^d> Krinkle: Any chance I could bribe you into reviewing https://gerrit.wikimedia.org/r/#/c/129853/ again? [20:31:50] (03Merged) 10jenkins-bot: Three states are not a toggle, should be "Switch to". [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142239 (owner: 10Matthias Mullie) [20:32:22] (03CR) 10Krinkle: "Hm.. what caused this to become an error? Did something change in core or in Jenkins?" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/142388 (owner: 10Hashar) [20:32:27] (03CR) 10Krinkle: "A, follows-up I6cc27f4bafc3." [integration/jenkins] - 10https://gerrit.wikimedia.org/r/142388 (owner: 10Hashar) [20:32:47] (03PS9) 10Krinkle: Pass a Title for context to Linker::makeExternalLink() [core] - 10https://gerrit.wikimedia.org/r/129853 (owner: 10Chad) [20:33:09] (03CR) 10Parent5446: "Just looking at the code (and based on a mailing list email), it seems --schema basically doesn't do what it says, and will perform databa" [core] - 10https://gerrit.wikimedia.org/r/142382 (https://bugzilla.wikimedia.org/67163) (owner: 10EBernhardson) [20:33:17] 3MediaWiki / 3Email: editmyprivateinfo blocks confiirming email - 10https://bugzilla.wikimedia.org/67145#c8 (10Mark A. Hershberger) Created attachment 15754 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15754&action=edit test script [20:33:21] ^d: That function is really terrible [20:33:28] <^d> I know it is :( [20:33:30] It hurts [20:33:37] (03PS6) 10Hashar: (WIP) Experiment zuul cloner (replace multigit.sh) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141819 [20:33:43] (03PS14) 10Hashar: (WIP) Experiment zuul-cloner with extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141846 [20:34:04] ^d: What does it gain again by having context? [20:34:06] nofollow? [20:34:17] <^d> Doesn't rely on $wgTitle context. [20:34:42] (03CR) 10Greg Grossmeier: "This'd be a good SWAT then." [core] - 10https://gerrit.wikimedia.org/r/141056 (https://bugzilla.wikimedia.org/14562) (owner: 10Brian Wolff) [20:35:25] greg-g: Sure if you want. Its fixing an issue that's literally been there since almost the dawn of time... [20:35:46] (03CR) 10Bsitu: "Jon, could you provide more detail on this? It seems to work. Initially pre-filled with saved preference and the preference is highlight" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142141 (owner: 10Bsitu) [20:35:54] (03PS1) 10EBernhardson: Merge remote-tracking branch 'gerrit/frontend-rewrite' [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142392 [20:36:10] (03CR) 10EBernhardson: [C: 032] Merge remote-tracking branch 'gerrit/frontend-rewrite' [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142392 (owner: 10EBernhardson) [20:36:31] (03Merged) 10jenkins-bot: Merge remote-tracking branch 'gerrit/frontend-rewrite' [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142392 (owner: 10EBernhardson) [20:37:52] (03PS1) 10EBernhardson: Merge remote-tracking branch 'gerrit/frontend-rewrite' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142393 [20:39:25] (03CR) 10EBernhardson: [C: 032] ". o .." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142393 (owner: 10EBernhardson) [20:39:44] (03Merged) 10jenkins-bot: Merge remote-tracking branch 'gerrit/frontend-rewrite' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142393 (owner: 10EBernhardson) [20:40:46] (03CR) 10EBernhardson: [C: 04-2] "frontend-rewrite branch is now merged to master, please cherry-pick against master and re-submit with a new Change-Id" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/131043 (owner: 10Werdna) [20:42:14] (03PS1) 10EBernhardson: Dont even provide action links to blocked users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142394 [20:42:22] (03CR) 10Fomafix: mediawiki.jqueryMsg: Prevent default action for functions as external link (031 comment) [core] - 10https://gerrit.wikimedia.org/r/139877 (owner: 10Gerrit Patch Uploader) [20:42:33] (03Abandoned) 10EBernhardson: Dont even provide action links to blocked users [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142148 (owner: 10EBernhardson) [20:43:21] (03Abandoned) 10EBernhardson: Add apiPreHandler to submitTopicTitle to squelch warnings about etrevId parameter [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141630 (owner: 10Werdna) [20:44:20] (03PS1) 10EBernhardson: Remove explicit isBlocked(), change permission ordering to match core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142395 (https://bugzilla.wikimedia.org/66994) [20:44:37] (03CR) 10jenkins-bot: [V: 04-1] Remove explicit isBlocked(), change permission ordering to match core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142395 (https://bugzilla.wikimedia.org/66994) (owner: 10EBernhardson) [20:44:44] (03CR) 10Jdlrobson: [C: 04-1] Dont even provide action links to blocked users (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142394 (owner: 10EBernhardson) [20:44:54] (03Abandoned) 10EBernhardson: Remove explicit isBlocked(), change permission ordering to match core [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142170 (https://bugzilla.wikimedia.org/66994) (owner: 10Mattflaschen) [20:45:03] (03PS1) 10Bartosz Dziewoński: SpecialVersion: Grammar fixes in comments [core] - 10https://gerrit.wikimedia.org/r/142396 [20:45:21] (03PS2) 10Jdlrobson: QA WIP Test for Action menu History [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112049 (owner: 10Cmcmahon) [20:45:29] (03CR) 10Bartosz Dziewoński: SpecialVersion: Show 'Skins' and 'Extensions' in separate sections (031 comment) [core] - 10https://gerrit.wikimedia.org/r/136615 (owner: 10Bartosz Dziewoński) [20:45:31] (03PS1) 10Bsitu: Highlight current sort option in navigation dropdown [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142397 [20:45:37] (03CR) 10Jdlrobson: "@cmcmahon are you still working on this?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112049 (owner: 10Cmcmahon) [20:45:48] 3MediaWiki / 3Email: editmyprivateinfo blocks confiirming email - 10https://bugzilla.wikimedia.org/67145#c9 (10Brad Jorsch) 5REOP>3RESO/INV Now that you've changed the title, it's certain that this is working as designed. Nor has permissions handling changed as you claimed in comment 5. (In reply to Ma... [20:45:56] (03PS4) 10Jdlrobson: Highlight current sort option in navigation dropdown [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142141 (owner: 10Bsitu) [20:46:09] (03PS1) 10Jdlrobson: Highlight current sort option in navigation dropdown [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142398 [20:46:26] (03PS1) 10EBernhardson: Split WorkflowLoader into multiple classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142399 [20:46:41] (03Abandoned) 10EBernhardson: Split WorkflowLoader into multiple classes [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142191 (owner: 10EBernhardson) [20:47:13] (03PS2) 10Krinkle: Upgrade jStorage to v0.4.10 (fixes TLL timeout bug) [core] - 10https://gerrit.wikimedia.org/r/142371 (owner: 10Mattflaschen) [20:47:24] (03Abandoned) 10EBernhardson: Hide drop down menus when an item is clicked [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141371 (owner: 10Werdna) [20:48:34] superm401: Look at line 61 and then at 48-56 and at 61 again at https://gerrit.wikimedia.org/r/#/c/142371/2/resources/lib/jquery/jquery.jStorage.js and tell my why that code is insanely stupid. [20:48:49] 3Analytics / 3Wikimetrics: test_add_new_tag_utf8 fails - 10https://bugzilla.wikimedia.org/67166 (10Teresa Cho) 3NEW p:3Unprio s:3normal a:3None When running tests, test_add_new_tag_utf8 returns an error: OperationalError: (OperationalError) (1267, "Illegal mix of collations (latin1_swedish_ci,IMPLIC... [20:48:58] (03Abandoned) 10Bsitu: Highlight current sort option in navigation dropdown [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142141 (owner: 10Bsitu) [20:49:09] https://github.com/andris9/jStorage/blob/v0.4.10/jstorage.js#L48-L61 [20:49:23] (03Abandoned) 10Bsitu: Highlight current sort option in navigation dropdown [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142397 (owner: 10Bsitu) [20:49:27] (03Abandoned) 10Jdlrobson: Highlight current sort option in navigation dropdown [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142398 (owner: 10Jdlrobson) [20:50:06] (03PS3) 10Jdlrobson: Re-implement terms-of-use [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142159 (owner: 10Bsitu) [20:50:49] Krinkle, true, however, it's already broken. [20:50:53] It just reformatted it. [20:50:54] (03CR) 10Jdlrobson: [C: 04-1] Re-implement terms-of-use (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142159 (owner: 10Bsitu) [20:50:54] I know [20:50:56] I'll submit an upstream patch. [20:51:08] Just checking if it's subtle or obvious. [20:51:13] Krinkle, subtle. [20:51:22] Somewhat subtle at least. [20:51:28] It was right in an earlier 4.x release [20:51:47] https://github.com/andris9/jStorage/commit/8c1bbfeb0997f6179fec0695df2815e53f68903b [20:51:49] lol [20:52:05] It can still be false, but not unset. [20:52:16] undefined, null, false, yeah [20:52:32] 3MediaWiki extensions / 3ZeroRatedMobileAccess: ZeroPortal unit tests throws Warning: JsonConfig: Invalid $wgJsonConfigs['JsonZeroConfig']['url']: API URL is not set ... - 10https://bugzilla.wikimedia.org/67142#c3 (10Antoine "hashar" Musso) There is no hurry. It only impacts a proof of concept I am working o... [20:53:12] Krinkle, you probably saw this, but even the two line jStorage change (I wrote one of the lines, the comment one) introduced a regression. [20:53:16] (03PS1) 10Bsitu: Highlight current sort option in navigation dropdown [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142401 [20:53:37] (03CR) 10Jdlrobson: [C: 04-1] "Doesn't work in following case:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142401 (owner: 10Bsitu) [20:54:03] (03PS2) 10EBernhardson: Remove explicit isBlocked(), change permission ordering to match core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142395 (https://bugzilla.wikimedia.org/66994) [20:54:21] superm401: which one? [20:54:22] (03CR) 10jenkins-bot: [V: 04-1] Remove explicit isBlocked(), change permission ordering to match core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142395 (https://bugzilla.wikimedia.org/66994) (owner: 10EBernhardson) [20:54:35] (03PS1) 10Bsitu: Re-implement terms-of-use [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142403 [20:54:50] (03PS1) 10Manybubbles: Fix rare-ish errors [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/142404 (https://bugzilla.wikimedia.org/67157) [20:54:53] Krinkle, https://gerrit.wikimedia.org/r/#/c/139689/1/resources/lib/jquery/jquery.jStorage.js . My upgrade will fix it. [20:54:58] (03CR) 10EBernhardson: [C: 04-1] "still needs tests" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142395 (https://bugzilla.wikimedia.org/66994) (owner: 10EBernhardson) [20:55:19] I missed it when I looked pre-merge. [20:55:21] (03CR) 10Siebrand: [C: 032] SpecialVersion: Grammar fixes in comments [core] - 10https://gerrit.wikimedia.org/r/142396 (owner: 10Bartosz Dziewoński) [20:55:26] (03PS1) 10Chad: Tighten up error handlings [extensions/CirrusSearch] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142405 (https://bugzilla.wikimedia.org/67095) [20:55:48] (03PS1) 10Chad: Tighten up error handlings [extensions/CirrusSearch] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142406 (https://bugzilla.wikimedia.org/67095) [20:56:25] (03CR) 10Krinkle: [C: 031] "Mention that it follows-up I0ca42e909cc in the commit message and (since I0ca42e909cc didn't) add release notes?" [core] - 10https://gerrit.wikimedia.org/r/142371 (owner: 10Mattflaschen) [20:56:37] Will merge in a sec if you can fup [20:57:06] ^d: remember svn days with commit messages like "FU: r123 fix stuff" [20:57:24] (03PS1) 10Manybubbles: Fix logging for non-existent updates [extensions/CirrusSearch] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142408 [20:57:28] maybe it's good we abandoned that. I forgot about the ambiguity [20:57:55] <^d> #lamecommitsummary [20:58:32] (03CR) 10Chad: [C: 032] Tighten up error handlings [extensions/CirrusSearch] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142405 (https://bugzilla.wikimedia.org/67095) (owner: 10Chad) [20:58:36] (03CR) 10Chad: [C: 032] Tighten up error handlings [extensions/CirrusSearch] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142406 (https://bugzilla.wikimedia.org/67095) (owner: 10Chad) [20:58:41] (03Merged) 10jenkins-bot: Tighten up error handlings [extensions/CirrusSearch] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142405 (https://bugzilla.wikimedia.org/67095) (owner: 10Chad) [20:58:47] (03Merged) 10jenkins-bot: Tighten up error handlings [extensions/CirrusSearch] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142406 (https://bugzilla.wikimedia.org/67095) (owner: 10Chad) [20:58:59] Krinkle, weird GitHub bug. It didn't fork the latest vesion of master: https://github.com/andris9/jStorage https://github.com/mattflaschen/jStorage https://github.com/mattflaschen/jStorage/compare/andris9:master...master [20:59:01] (03Merged) 10jenkins-bot: SpecialVersion: Grammar fixes in comments [core] - 10https://gerrit.wikimedia.org/r/142396 (owner: 10Bartosz Dziewoński) [20:59:05] Will add release notes and change message now. [20:59:49] https://github.com/andris9/jStorage/compare/mattflaschen:master...andris9:master [20:59:50] (03CR) 10Chad: [C: 032] Fix logging for non-existent updates [extensions/CirrusSearch] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142408 (owner: 10Manybubbles) [20:59:50] yeah [20:59:51] weird [21:00:09] (03PS2) 10Bsitu: Re-implement terms-of-use [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142403 [21:00:15] (03Merged) 10jenkins-bot: Fix logging for non-existent updates [extensions/CirrusSearch] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142408 (owner: 10Manybubbles) [21:00:15] (03CR) 10Manybubbles: "I'll do submodule update." [extensions/CirrusSearch] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142408 (owner: 10Manybubbles) [21:00:42] (03Abandoned) 10Bsitu: Re-implement terms-of-use [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/142159 (owner: 10Bsitu) [21:02:04] (03CR) 10Chad: [C: 032] Fix rare-ish errors [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/142404 (https://bugzilla.wikimedia.org/67157) (owner: 10Manybubbles) [21:02:07] (03PS3) 10Mattflaschen: Upgrade jStorage to v0.4.10 to fix a bug with the TTL. [core] - 10https://gerrit.wikimedia.org/r/142371 [21:02:14] (03Merged) 10jenkins-bot: Fix rare-ish errors [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/142404 (https://bugzilla.wikimedia.org/67157) (owner: 10Manybubbles) [21:02:35] (03PS1) 10Manybubbles: Fix rare-ish errors [extensions/CirrusSearch] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142412 (https://bugzilla.wikimedia.org/67157) [21:03:07] (03PS1) 10Manybubbles: Fix rare-ish errors [extensions/CirrusSearch] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142413 (https://bugzilla.wikimedia.org/67157) [21:04:02] 3MediaWiki / 3Parser: Parser inserts invalid   in the middle of style attribute - 10https://bugzilla.wikimedia.org/3158#c6 (10Krinkle) (Cite Krinkle from 67092 comment #0) > When the parser strips a /* comment */ from a style attribute it inserts a >   in its place. This causes the stylesheet to be... [21:04:50] (03PS2) 10Krinkle: [WIP] Parser: Don't insert   inside style attributes [core] - 10https://gerrit.wikimedia.org/r/142042 (https://bugzilla.wikimedia.org/3158) [21:06:07] Reedy: awwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwww [21:06:18] Reedy: https://gerrit.wikimedia.org/r/#/c/142302/1 this is the reason LU didn't work for core messages? [21:07:26] Reedy: for example https://bugzilla.wikimedia.org/show_bug.cgi?id=66524 [21:08:25] (03CR) 10Chad: [C: 032] Fix rare-ish errors [extensions/CirrusSearch] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142413 (https://bugzilla.wikimedia.org/67157) (owner: 10Manybubbles) [21:08:28] (03CR) 10Chad: [C: 032] Fix rare-ish errors [extensions/CirrusSearch] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142412 (https://bugzilla.wikimedia.org/67157) (owner: 10Manybubbles) [21:08:32] (03Merged) 10jenkins-bot: Fix rare-ish errors [extensions/CirrusSearch] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142413 (https://bugzilla.wikimedia.org/67157) (owner: 10Manybubbles) [21:08:39] (03Merged) 10jenkins-bot: Fix rare-ish errors [extensions/CirrusSearch] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142412 (https://bugzilla.wikimedia.org/67157) (owner: 10Manybubbles) [21:08:46] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Parser: Don't insert   inside style attributes [core] - 10https://gerrit.wikimedia.org/r/142042 (https://bugzilla.wikimedia.org/3158) (owner: 10Krinkle) [21:09:23] (03PS1) 10Chad: SpecialPage: DRY array filter for prefixSearchSubpages() [core] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142414 [21:10:10] (03PS4) 10Krinkle: Upgrade jStorage to v0.4.10 to fix a bug with the TTL [core] - 10https://gerrit.wikimedia.org/r/142371 (owner: 10Mattflaschen) [21:10:12] (03CR) 10JGonera: "Ori, I know about settings.d/. I use it in my instance. But browser tests should pass by default, not only after you customize your config" [vagrant] - 10https://gerrit.wikimedia.org/r/141860 (owner: 10JGonera) [21:10:19] (03CR) 10Krinkle: [C: 032] Upgrade jStorage to v0.4.10 to fix a bug with the TTL [core] - 10https://gerrit.wikimedia.org/r/142371 (owner: 10Mattflaschen) [21:10:21] (03CR) 10Jdlrobson: [C: 04-2] "Needs to abandoned and rebased against current master." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105044 (owner: 10Cmcmahon) [21:10:40] Reedy: hmm maybe not, but good catch still [21:11:12] (03CR) 10Nikerabbit: [C: 032] Fix undefined $json usage [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/142302 (owner: 10Reedy) [21:11:14] (03CR) 10Ori.livneh: "Ah, I don't know enough about the browser tests. Adding bd808 and dduvall for feedback." [vagrant] - 10https://gerrit.wikimedia.org/r/141860 (owner: 10JGonera) [21:11:27] (03PS1) 10Chad: Escape delimiter in SpecialPage::prefixSearchArray [core] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142415 [21:11:42] (03Abandoned) 10Jdlrobson: Make the check for talk/contribs empty because IE10 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106155 (owner: 10Cmcmahon) [21:11:49] (03CR) 10Alex Monk: Set visualeditor-enable to 0 by default [vagrant] - 10https://gerrit.wikimedia.org/r/141860 (owner: 10JGonera) [21:12:27] (03PS1) 10Chad: SpecialPage: DRY array filter for prefixSearchSubpages() [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142416 [21:12:53] (03CR) 10Krinkle: Fix GitInfo cache file path computation and storage location (031 comment) [core] - 10https://gerrit.wikimedia.org/r/142319 (https://bugzilla.wikimedia.org/53972) (owner: 10BryanDavis) [21:12:57] (03Merged) 10jenkins-bot: Fix undefined $json usage [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/142302 (owner: 10Reedy) [21:13:30] (03PS5) 10BryanDavis: Fix GitInfo cache file path computation and storage location [core] - 10https://gerrit.wikimedia.org/r/142319 (https://bugzilla.wikimedia.org/53972) [21:13:49] (03PS1) 10Manybubbles: Update CirrusSearch [core] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142418 [21:13:55] (03PS1) 10Chad: Escape delimiter in SpecialPage::prefixSearchArray [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142419 [21:15:42] (03Merged) 10jenkins-bot: Upgrade jStorage to v0.4.10 to fix a bug with the TTL [core] - 10https://gerrit.wikimedia.org/r/142371 (owner: 10Mattflaschen) [21:15:49] 3MediaWiki / 3Email: editmyprivateinfo blocks confiirming email - 10https://bugzilla.wikimedia.org/67145#c10 (10Mark A. Hershberger) You should point to the discussion for this change: I3f03dd010020e8d43cc2d3bca7b3ef7196d1c548 I can see from that that this is acting as designed. However no documentation wa... [21:16:03] (03PS1) 10Manybubbles: Update Cirrus [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142420 [21:16:30] (03Abandoned) 10Jdlrobson: Edit title and body with weird stuff [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104786 (owner: 10Cmcmahon) [21:16:43] (03CR) 10Aaron Schulz: [C: 04-1] "Looks mostly fine to me." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [21:18:30] (03PS1) 10Hashar: (WIP) Experiment with language bundle exts (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/142421 [21:19:50] (03CR) 10Aaron Schulz: First version of Page Language selector (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [21:20:19] 3MediaWiki / 3Documentation: Clear documentation should be provided about the - 10https://bugzilla.wikimedia.org/67167 (10Mark A. Hershberger) 3NEW p:3Unprio s:3normal a:3None In bug #67145, Brad says: > what they need to do is not screw with the assignments for editmyoptions > and the other 'my' pe... [21:20:33] 3MediaWiki / 3Documentation: Documentation is out of date, incomplete (tracking) - 10https://bugzilla.wikimedia.org/1 (10Mark A. Hershberger) [21:20:42] (03PS2) 10Hashar: (WIP) Experiment with language bundle exts (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/142421 [21:20:58] (03PS1) 10Bsitu: Update cache version number to 4.5 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142422 [21:21:59] (03CR) 10jenkins-bot: [V: 04-1] (WIP) Experiment with language bundle exts (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/142421 (owner: 10Hashar) [21:22:02] (03CR) 10jenkins-bot: [V: 04-1] Update Cirrus [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142420 (owner: 10Manybubbles) [21:22:28] (03CR) 10Manybubbles: "bite me" [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142420 (owner: 10Manybubbles) [21:24:18] (03PS1) 10Hashar: Experiment mediawiki-language-extension-bundle-integration [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/142423 [21:24:26] (03CR) 10Manybubbles: "^d, do you know what is up with this?" [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142420 (owner: 10Manybubbles) [21:24:47] 3MediaWiki extensions / 3CirrusSearch: ElasticsearchIntermediary error handling sucks - 10https://bugzilla.wikimedia.org/67095 (10Chad H.) 5PATC>3RESO/FIX [21:24:47] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Failing to reindex Meta - 10https://bugzilla.wikimedia.org/67157 (10Chad H.) 5PATC>3RESO/FIX [21:25:42] (03PS1) 10Hashar: (WIP) MediaWiki_Language_Extension_Bundle (WIP) [core] - 10https://gerrit.wikimedia.org/r/142425 [21:25:47] 3Wikimedia / 3General/Unknown: (Localisation update problems?) "More" menu dropdown shown in English (not translated/localized) - 10https://bugzilla.wikimedia.org/66524#c14 (10Nemo) Currently I see translations on e.g. [[MediaWiki:Vector-more-actions/ml]] (1.24wmf10) and I9395b0e1983122b12bedf003d6398da5ddfd... [21:26:04] (03CR) 10Krinkle: Fix GitInfo cache file path computation and storage location (032 comments) [core] - 10https://gerrit.wikimedia.org/r/142319 (https://bugzilla.wikimedia.org/53972) (owner: 10BryanDavis) [21:26:24] (03CR) 10Chad: "recheck" [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142420 (owner: 10Manybubbles) [21:26:35] (03CR) 10Jdlrobson: [C: 032] "Terms of use is important." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142403 (owner: 10Bsitu) [21:27:08] (03PS1) 10Robmoen: Remove text shadow from default mediawiki.ui buttons [core] - 10https://gerrit.wikimedia.org/r/142426 (https://bugzilla.wikimedia.org/61940) [21:27:47] (03PS2) 10Robmoen: Remove text shadow from default mediawiki.ui buttons [core] - 10https://gerrit.wikimedia.org/r/142426 (https://bugzilla.wikimedia.org/61940) [21:28:05] (03CR) 10Jdlrobson: [C: 032] Remove text shadow from default mediawiki.ui buttons [core] - 10https://gerrit.wikimedia.org/r/142426 (https://bugzilla.wikimedia.org/61940) (owner: 10Robmoen) [21:28:37] (03CR) 10Jdlrobson: [C: 032] Update cache version number to 4.5 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142422 (owner: 10Bsitu) [21:29:24] Krinkle: sorry about letting the asset-check patches rot, will review [21:30:52] (03PS2) 10Chad: Update CirrusSearch [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142420 (owner: 10Manybubbles) [21:31:11] jdlrobson: ty :) [21:31:46] ^d: thanks - what was it? [21:32:07] <^d> No clue. I just changed the commit message to force a new sha1. [21:32:18] <^d> It's checking now, we'll see if jenkins is happier. [21:32:47] (03Merged) 10jenkins-bot: Re-implement terms-of-use [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142403 (owner: 10Bsitu) [21:34:47] 3Wikimedia / 3General/Unknown: (Localisation update problems?) "More" menu dropdown shown in English (not translated/localized) - 10https://bugzilla.wikimedia.org/66524 (10Bartosz Dziewoński) 5REOP>3RESO/WOR [21:34:52] (03Merged) 10jenkins-bot: Update cache version number to 4.5 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142422 (owner: 10Bsitu) [21:36:44] (03CR) 10Hashar: "recheck" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/142423 (owner: 10Hashar) [21:37:27] (03Merged) 10jenkins-bot: Remove text shadow from default mediawiki.ui buttons [core] - 10https://gerrit.wikimedia.org/r/142426 (https://bugzilla.wikimedia.org/61940) (owner: 10Robmoen) [21:38:23] (03CR) 10BryanDavis: Fix GitInfo cache file path computation and storage location (031 comment) [core] - 10https://gerrit.wikimedia.org/r/142319 (https://bugzilla.wikimedia.org/53972) (owner: 10BryanDavis) [21:38:35] <^d> manybubbles: 2nd time worked. [21:38:39] <^d> So we're all set for later. [21:41:10] ^d: cool [21:41:22] (03PS1) 10Spage: Comment $wgFlowCacheVersion [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142427 [21:41:52] Oh, this is the end of the world as we know it [21:41:56] GitHub gains a Revert button [21:42:08] Krinkle: nice [21:43:16] <^d> So behind the times. Gerrit's had that for ages geez. [21:43:23] <^d> C'mon github, ur slacking! [21:43:34] and wikipedia had the original? [21:43:53] next they'll get a cherry pick [21:43:58] (03CR) 10Hashar: "recheck" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/142423 (owner: 10Hashar) [21:44:01] <^d> greg-g: rollback's been there forevs. [21:44:59] Krinkle, https://github.com/andris9/jStorage/pull/82 [21:45:00] (03CR) 10Aude: [C: 032] "so not to forget" [tools/release] - 10https://gerrit.wikimedia.org/r/142376 (owner: 10Aude) [21:45:02] (03CR) 10Hashar: [C: 032] Experiment mediawiki-language-extension-bundle-integration [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/142423 (owner: 10Hashar) [21:45:07] (03Merged) 10jenkins-bot: Experiment mediawiki-language-extension-bundle-integration [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/142423 (owner: 10Hashar) [21:45:25] (03Merged) 10jenkins-bot: Update Wikidata [tools/release] - 10https://gerrit.wikimedia.org/r/142376 (owner: 10Aude) [21:45:35] (03CR) 10Hashar: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/142425 (owner: 10Hashar) [21:46:06] (03PS6) 10BryanDavis: Fix GitInfo cache file path computation and storage location [core] - 10https://gerrit.wikimedia.org/r/142319 (https://bugzilla.wikimedia.org/53972) [21:46:33] (03PS58) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [21:46:49] (03CR) 10Greg Grossmeier: "This wasn't merged before this morning, which means it won't go out with the train by the end of June (the current/previous plan)." [core] - 10https://gerrit.wikimedia.org/r/136234 (owner: 10Jackmcbarn) [21:47:24] (03CR) 10EBernhardson: [C: 032] Comment $wgFlowCacheVersion [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142427 (owner: 10Spage) [21:48:20] (03PS59) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [21:48:22] (03CR) 10Jforrester: "If your browser tests are asserting things as being true/false based on config, but don't have access to config, you're going to have a ba" [vagrant] - 10https://gerrit.wikimedia.org/r/141860 (owner: 10JGonera) [21:49:28] (03CR) 10jenkins-bot: [V: 04-1] First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [21:49:37] (03Merged) 10jenkins-bot: Comment $wgFlowCacheVersion [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142427 (owner: 10Spage) [21:49:40] (03CR) 10Dduvall: [C: 04-1] "Disabling VE in a configuration file created by role::visualeditor seems counterintuitive to me. Ostensibly, one would only enable the VE " [vagrant] - 10https://gerrit.wikimedia.org/r/141860 (owner: 10JGonera) [21:49:47] 3MediaWiki / 3Documentation: Clear documentation should be provided about the *my* permissions - 10https://bugzilla.wikimedia.org/67167 (10Mark A. Hershberger) [21:50:07] (03PS3) 10Hashar: (WIP) Experiment with language bundle exts (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/142421 [21:51:32] 3MediaWiki / 3Email: editmyprivateinfo blocks confiirming email - 10https://bugzilla.wikimedia.org/67145#c11 (10Kunal Mehta (Legoktm)) (In reply to Mark A. Hershberger from comment #10) > This is the only time I've > seen any warning about changing these options. So, do we just need better documentation her... [21:51:44] (03Abandoned) 10Krinkle: Use ctype_digit instead of is_int when checking a value from cache [core] - 10https://gerrit.wikimedia.org/r/130030 (owner: 10Legoktm) [21:51:47] 3Wikimedia / 3lucene-search-2: Valid Page name resulting in backend search error - 10https://bugzilla.wikimedia.org/66259#c8 (10Adam Hyland) Just a minor update. Searching again for "Wikipedia:A/b: c ." results in the same error. That's not really dispositive as it could be the same caching issue cropping up... [21:52:02] 3MediaWiki / 3Email: editmyprivateinfo blocks confiirming email - 10https://bugzilla.wikimedia.org/67145#c12 (10Kunal Mehta (Legoktm)) (In reply to Kunal Mehta (Legoktm) from comment #11) > me that you can't confirm my email. confirm your* email. [21:52:42] (03PS1) 10Cscott: Add parser test for "extra interlanguage links". [core] - 10https://gerrit.wikimedia.org/r/142431 (https://bugzilla.wikimedia.org/32189) [21:53:06] (03CR) 10Jforrester: [C: 032] "Per Gabriel, Tim, Greg." [core] - 10https://gerrit.wikimedia.org/r/136234 (owner: 10Jackmcbarn) [21:53:19] 3MediaWiki / 3ResourceLoader: Add jQuery mobile - 10https://bugzilla.wikimedia.org/67155#c2 (10paladox2015) Hi well it uses HTML5 support for devices like android, ios and other mobile systems. It could be used to make a mobile user face so that it looks nice. [21:53:45] (03PS1) 10Hashar: (WIP) MediaWiki_Language_Extension_Bundle (WIP) [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/142432 [21:53:47] (03PS60) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [21:53:58] (03CR) 10Hashar: "check experimental" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/142432 (owner: 10Hashar) [21:54:48] (03CR) 10jenkins-bot: [V: 04-1] Support {{!}} as a magic word [core] - 10https://gerrit.wikimedia.org/r/136234 (owner: 10Jackmcbarn) [21:54:57] * jackmcbarn rebases [21:56:13] (03PS9) 10Jforrester: Support {{!}} as a magic word [core] - 10https://gerrit.wikimedia.org/r/136234 (owner: 10Jackmcbarn) [21:56:37] (03CR) 10Jforrester: [C: 032] "PS9 is a trivial release notes rebase." [core] - 10https://gerrit.wikimedia.org/r/136234 (owner: 10Jackmcbarn) [21:56:51] (03CR) 10jenkins-bot: [V: 04-1] (WIP) MediaWiki_Language_Extension_Bundle (WIP) [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/142432 (owner: 10Hashar) [21:56:52] James_F: ah, you beat me :p [21:56:56] thanks James_F [21:57:00] heh [21:57:01] * James_F grins. [21:57:01] :) [21:57:04] (03CR) 10Legoktm: "We should be able to replace the hook overrides with just a generic MessageCache::get hook handler in the WikimediaMessages extension. It " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142403 (owner: 10Bsitu) [21:57:23] (03CR) 10jenkins-bot: [V: 04-1] First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [21:57:26] We really should work out what was happening with the auto-RELEASE-NOTES-rebaser. [21:57:36] James_F: nothing. [21:58:02] James_F: i've been unable to get anyone to deploy my code. [21:58:15] (03CR) 10Jdlrobson: "+1 to what legoktm said" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142403 (owner: 10Bsitu) [21:59:07] jackmcbarn: git review -d {{n}} && git remote update && git rebase origin/master && nano REL && Ctrl+W <<< && Ctrl+K && Ctrl+W === && Ctrl+K && Ctrl+W >>> && Ctrl+K && Ctrl+O && git add REL && git rebase --continue && git review. It might as well be a script. [21:59:25] (03CR) 10Bsitu: "I will look into how this can be improved, :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142403 (owner: 10Bsitu) [21:59:28] MatmaRex: Oh, it was written but not deployed? What needed doing? [22:00:19] James_F: run https://github.com/MatmaRex/mediawikireleasenotes-driver when a gate-and-submit job fails due to a merge conflict [22:00:52] (03PS61) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [22:01:58] MatmaRex: Is that bit ("when a gate-and-submit job fails due to a merge conflict") easy? [22:02:08] (03CR) 10jenkins-bot: [V: 04-1] First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [22:02:09] i don't know [22:02:28] There's some script somewhere that I've never seen that creates the hypothetical merge commit to test [22:02:35] (03Merged) 10jenkins-bot: Support {{!}} as a magic word [core] - 10https://gerrit.wikimedia.org/r/136234 (owner: 10Jackmcbarn) [22:02:47] So you'd have to get in there go, if git merge failed, run this thing and try again [22:03:11] Oh, even better, it's a merge driver! [22:03:16] That's nice [22:03:34] Getting the gate-and-submit checker to use the merge driver shouldn't be hard, getting Gerrit itself to use it for the actual merge might be harder [22:03:55] * James_F nods. [22:04:20] Sounds like the main issue is there's no-one who considers gerrit to be their baby right now. :-) [22:04:26] RoanKattouw: s/harder/impossible/ unless you reimplement that in java [22:04:47] RoanKattouw: jenkins would instead have to push the rebased commit for review [22:04:59] Right [22:05:08] i've looked into how JGit does merge drivers and it basically doesn't… [22:05:31] (03PS62) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [22:05:32] James_F: this would hardly touch gerrit, it's all jenkins/zuul/whatever [22:05:59] MatmaRex: Sure; "Gerrit+ecosystem". [22:06:04] MatmaRex: Have you asked hashar? [22:06:11] yes [22:06:17] 3Analytics / 3EventLogging: Helper for logging link clicks - 10https://bugzilla.wikimedia.org/52287 (10Tisza Gergő) [22:06:18] 3Analytics / 3EventLogging: Provide a robust way of logging events without blocking until network request completes - 10https://bugzilla.wikimedia.org/42815 (10Tisza Gergő) [22:06:20] (03PS1) 10Hashar: (WIP) zuul-cloner always fallback to ZUUL_BRANCH (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/142433 [22:06:58] (03PS63) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [22:07:45] how long is it supposed to take until merged changes make it to beta labs? [22:08:03] jackmcbarn: ~3 minutes. [22:08:16] jackmcbarn: But it sometimes takes a bunch longer, mysteriously. [22:08:37] jackmcbarn: Especially for JS content, IME. [22:11:42] (03CR) 10Jaredzimmerman: "Does this only handle primary style buttons or quiet state as well for neutral/default buttons?" [core] - 10https://gerrit.wikimedia.org/r/142426 (https://bugzilla.wikimedia.org/61940) (owner: 10Robmoen) [22:12:32] https://www.mediawiki.org/wiki/Gerrit/Project_ownership#jackmcbarn_for_.2B2_in_mediawiki [22:14:00] ^d: relatedly, there are a bunch of old requests on that page, starting with https://www.mediawiki.org/wiki/Gerrit/Project_ownership#Emufarmers_for_ConfirmEdit , could you action some of those? [22:15:17] 3Wikimedia / 3Deployment systems: HHBC cache creation fails with SIGABRT on osmium - 10https://bugzilla.wikimedia.org/67098#c3 (10Bryan Davis) 5NEW>3RESO/FIX Fixed in https://github.com/tstarling/hiphop-php/commit/8b6a194ebe37dfb96c768375e9767248e94395f8 [22:16:28] (03PS1) 10Jdlrobson: Hygiene: Improve JSHint coverage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142440 [22:20:46] (03CR) 10BryanDavis: "check experimental" [core/vendor] - 10https://gerrit.wikimedia.org/r/136473 (owner: 10BryanDavis) [22:22:09] <^d> legoktm: Did all but the last 1. [22:22:30] awesome, thanks :D [22:27:35] 3Wikimedia / 3Deployment systems: Investigate effect of multiple release branches on HHVM's JIT system - 10https://bugzilla.wikimedia.org/67168 (10Bryan Davis) 3NEW p:3Unprio s:3normal a:3None Tim described it better than anyone else: HHVM has a mode called RepoAuthoritative, which requires you to p... [22:27:51] 3Wikimedia / 3Deployment systems: Investigate effect of multiple release branches on HHVM's JIT system - 10https://bugzilla.wikimedia.org/67168 (10Bryan Davis) p:5Unprio>3Normal a:3Bryan Davis [22:28:11] (03PS23) 10EBernhardson: [SCHEMA CHANGE] Drop the definition model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 [22:28:40] (03PS1) 10Bsitu: static method should be declared with static [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142443 [22:28:43] (03PS3) 10Chad: Remove SpecialSearchNoResults, call SpecialSearchResults unconditionally [core] - 10https://gerrit.wikimedia.org/r/141069 [22:30:26] (03CR) 10EBernhardson: [C: 032] static method should be declared with static [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142443 (owner: 10Bsitu) [22:30:43] (03Merged) 10jenkins-bot: static method should be declared with static [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142443 (owner: 10Bsitu) [22:31:02] 3Wikimedia / 3Site requests: Redirects to mobile version drop the URL hash (anchor) - 10https://bugzilla.wikimedia.org/50517#c7 (10Jon) According to w3c spec fragments from the Location header are honored. http://www.w3.org/TR/cuap#uri If the browser isn't doing this this is an issue with the browser not us... [22:37:24] (03CR) 10Mattflaschen: "No need to mess up the whitespace again ;), but for future reference the spacing conventions do not apply to SVGs. In fact, we just minif" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx) [22:37:56] (03PS2) 10Bsitu: Highlight current sort option in navigation dropdown [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142401 [22:46:15] (03PS2) 10Cscott: Add parser test for "extra interlanguage links". [core] - 10https://gerrit.wikimedia.org/r/142431 (https://bugzilla.wikimedia.org/32189) [22:50:19] Hi superm401 [22:50:26] Hey Krenair [22:50:40] superm401, you said "See bug report." on https://gerrit.wikimedia.org/r/140875 [22:50:45] but I don't see anything new on the bug [22:50:45] Krenair, yeah, you ninja'd me. [22:50:47] Just added it. [22:51:02] I guess I should have posted to the bug first. :) [22:52:46] (03PS5) 10Legoktm: Show block notice on contribs for range-blocked IP [core] - 10https://gerrit.wikimedia.org/r/133988 (https://bugzilla.wikimedia.org/20790) (owner: 10Gerrit Patch Uploader) [22:54:01] (03CR) 10Legoktm: [C: 032] "Rebased locally, and added release notes." [core] - 10https://gerrit.wikimedia.org/r/133988 (https://bugzilla.wikimedia.org/20790) (owner: 10Gerrit Patch Uploader) [22:56:47] 3MediaWiki / 3General/Unknown: BagOStuff should behave consistently with regards to integer values - 10https://bugzilla.wikimedia.org/60563#c7 (10Krinkle) Seems RedisBagOStuff has had php serialize for all. So, I'm not sure how it could've returned strings for integers. Change I3e0d1c4888062544 made it use... [22:57:15] (03Merged) 10jenkins-bot: Show block notice on contribs for range-blocked IP [core] - 10https://gerrit.wikimedia.org/r/133988 (https://bugzilla.wikimedia.org/20790) (owner: 10Gerrit Patch Uploader) [22:58:33] 3MediaWiki / 3Special pages: Block log snippet on Special:Contributions should work for IPs in a range block - 10https://bugzilla.wikimedia.org/20790 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3PiRSquared17 [22:59:31] (03CR) 10EBernhardson: "PS2: i dont think this new test proves anything useful, but there you go" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/140413 (https://bugzilla.wikimedia.org/66797) (owner: 10EBernhardson) [23:00:21] (03PS2) 10EBernhardson: Protect against null values in ObjectManager::findMulti [extensions/Flow] - 10https://gerrit.wikimedia.org/r/140413 (https://bugzilla.wikimedia.org/66797) [23:03:28] (03PS1) 10Krinkle: objectcache: Actually inserialize integers as integers [core] - 10https://gerrit.wikimedia.org/r/142450 (https://bugzilla.wikimedia.org/60563) [23:03:40] (03PS2) 10Krinkle: objectcache: Actually unserialize integers as integers [core] - 10https://gerrit.wikimedia.org/r/142450 (https://bugzilla.wikimedia.org/60563) [23:04:13] (03PS3) 10Krinkle: objectcache: Actually unserialize integers as integers [core] - 10https://gerrit.wikimedia.org/r/142450 (https://bugzilla.wikimedia.org/60563) [23:05:26] (03CR) 10Krinkle: "fixme, see I2bb09381b2." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96801 (owner: 10Aaron Schulz) [23:05:54] (03CR) 10Legoktm: [C: 031] "Looks fine, I'll merge after you implement Siebrand's recommendation." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/139653 (https://bugzilla.wikimedia.org/40119) (owner: 10Gerrit Patch Uploader) [23:06:13] superm401: At last https://gerrit.wikimedia.org/r/#/c/142450/ [23:06:41] (03PS4) 10Krinkle: objectcache: Actually unserialize integers as integers in RedisBagOStuff [core] - 10https://gerrit.wikimedia.org/r/142450 (https://bugzilla.wikimedia.org/60563) [23:07:32] 3Wikimedia / 3Site requests: Please add the domain *.ihs.nl to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/67120#c3 (10Greg Grossmeier) Hello Mr Muller, We'll enable this shortly. Just a reminder to err on the side of over-communicating in the case of large uploads (either large (>... [23:08:03] 3MediaWiki / 3General/Unknown: BagOStuff should behave consistently with regards to integer values - 10https://bugzilla.wikimedia.org/60563 (10Krinkle) a:3Krinkle [23:08:08] (03CR) 10Ori.livneh: [C: 032] Update CirrusSearch [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142420 (owner: 10Manybubbles) [23:08:25] (03CR) 10Ori.livneh: [C: 032] Update CirrusSearch [core] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142418 (owner: 10Manybubbles) [23:08:58] (03CR) 10Ori.livneh: [C: 032] SpecialPage: DRY array filter for prefixSearchSubpages() [core] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142414 (owner: 10Chad) [23:09:05] (03CR) 10Ori.livneh: [C: 032] Escape delimiter in SpecialPage::prefixSearchArray [core] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142415 (owner: 10Chad) [23:09:14] (03CR) 10Ori.livneh: [C: 032] SpecialPage: DRY array filter for prefixSearchSubpages() [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142416 (owner: 10Chad) [23:09:20] (03CR) 10Ori.livneh: [C: 032] Escape delimiter in SpecialPage::prefixSearchArray [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142419 (owner: 10Chad) [23:12:32] (03Merged) 10jenkins-bot: Update CirrusSearch [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142420 (owner: 10Manybubbles) [23:13:17] (03Merged) 10jenkins-bot: Update CirrusSearch [core] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142418 (owner: 10Manybubbles) [23:14:31] (03Merged) 10jenkins-bot: SpecialPage: DRY array filter for prefixSearchSubpages() [core] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142414 (owner: 10Chad) [23:15:01] (03Merged) 10jenkins-bot: Escape delimiter in SpecialPage::prefixSearchArray [core] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/142415 (owner: 10Chad) [23:15:25] (03PS3) 10Ori.livneh: Add a role with a rough approximation of wikitech. [vagrant] - 10https://gerrit.wikimedia.org/r/140828 (owner: 10Andrew Bogott) [23:15:27] (03Merged) 10jenkins-bot: SpecialPage: DRY array filter for prefixSearchSubpages() [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142416 (owner: 10Chad) [23:15:32] (03CR) 10Ori.livneh: [C: 032] Add a role with a rough approximation of wikitech. [vagrant] - 10https://gerrit.wikimedia.org/r/140828 (owner: 10Andrew Bogott) [23:15:47] (03Merged) 10jenkins-bot: Escape delimiter in SpecialPage::prefixSearchArray [core] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142419 (owner: 10Chad) [23:15:55] (03CR) 10Krinkle: "Fixes bug 67160. This is especially relevant when the sub value itself contains another slash. Such as on http://en.wikipedia.org/w/api.ph" [core] - 10https://gerrit.wikimedia.org/r/142379 (owner: 10Chad) [23:16:32] 3MediaWiki / 3General/Unknown: Code quality issues (tracking) - 10https://bugzilla.wikimedia.org/700 (10Krinkle) [23:16:33] 3MediaWiki / 3Search: Catchable fatal error: Argument 1 passed to StringPrefixSearch::titles() must be an array, null given, called PrefixSearch.php on line 149 - 10https://bugzilla.wikimedia.org/67160#c1 (10Krinkle) 5NEW>3RESO/FIX p:5Unprio>3High s:5normal>3major a:3Krinkle Fixed. > Change-I... [23:17:04] 3MediaWiki / 3Search: Catchable fatal error: Argument 1 passed to StringPrefixSearch::titles() must be an array, null given, called PrefixSearch.php on line 149 - 10https://bugzilla.wikimedia.org/67160 (10Krinkle) a:5Krinkle>3Ori Livneh [23:18:17] (03Merged) 10jenkins-bot: Add a role with a rough approximation of wikitech. [vagrant] - 10https://gerrit.wikimedia.org/r/140828 (owner: 10Andrew Bogott) [23:18:56] (03CR) 10Legoktm: [C: 04-1] "I hadn't looked at how action=help does it, but I like that method compared to this." [core] - 10https://gerrit.wikimedia.org/r/141110 (https://bugzilla.wikimedia.org/30936) (owner: 10Legoktm) [23:21:44] (03CR) 10MaxSem: "Liangent, are you ok with this change?" [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/140626 (https://bugzilla.wikimedia.org/66621) (owner: 10MaxSem) [23:23:57] (03CR) 10Krinkle: "Hm.. is this supposed to use hostmaster.wikimedia.org and 'ou=projects,dc=wikimedia,dc=org' ?" [vagrant] - 10https://gerrit.wikimedia.org/r/140828 (owner: 10Andrew Bogott) [23:27:04] (03PS1) 10Ori.livneh: Lint fixes [vagrant] - 10https://gerrit.wikimedia.org/r/142457 [23:27:40] (03PS1) 10Aaron Schulz: Add some casts for sanity before BagOStuff::add() calls [core] - 10https://gerrit.wikimedia.org/r/142458 [23:28:29] (03CR) 10Ori.livneh: [C: 032] Lint fixes [vagrant] - 10https://gerrit.wikimedia.org/r/142457 (owner: 10Ori.livneh) [23:29:05] (03Merged) 10jenkins-bot: Lint fixes [vagrant] - 10https://gerrit.wikimedia.org/r/142457 (owner: 10Ori.livneh) [23:29:51] (03CR) 10Ori.livneh: [C: 032 V: 032] Initial commit of new job runner loop [services/jobrunner] - 10https://gerrit.wikimedia.org/r/140618 (owner: 10Aaron Schulz) [23:30:32] 3MediaWiki / 3ResourceLoader: ResourceLoader: load.php requests with only=styles should report if module is missing - 10https://bugzilla.wikimedia.org/64826 (10Krinkle) 5PATC>3RESO/FIX [23:30:56] (03PS3) 10Jdlrobson: Protect against null values in ObjectManager::findMulti [extensions/Flow] - 10https://gerrit.wikimedia.org/r/140413 (https://bugzilla.wikimedia.org/66797) (owner: 10EBernhardson) [23:31:40] (03CR) 10Jdlrobson: [C: 032] "Added Flow group." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/140413 (https://bugzilla.wikimedia.org/66797) (owner: 10EBernhardson) [23:31:58] (03Merged) 10jenkins-bot: Protect against null values in ObjectManager::findMulti [extensions/Flow] - 10https://gerrit.wikimedia.org/r/140413 (https://bugzilla.wikimedia.org/66797) (owner: 10EBernhardson) [23:35:05] 3Analytics / 3Visualization: Maintainers have stack for EEVS dashboard server - 10https://bugzilla.wikimedia.org/67172 (10Kevin Leduc) 3NEW p:3Unprio s:3enhanc a:3None set up a server / software stack for EEVS dasboards [23:36:02] 3Analytics / 3Visualization: Maintainers have stack for EEVS dashboard server - 10https://bugzilla.wikimedia.org/67172 (10Kevin Leduc) p:5Unprio>3Normal [23:40:32] 3MediaWiki / 3ResourceLoader: Get rid of startUp() function in mediawiki.js - 10https://bugzilla.wikimedia.org/37894#c2 (10James Forrester) 5ASSI>3NEW This is clearly not actually assigned. [23:40:32] 3Wikimedia / 3General/Unknown: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - 10https://bugzilla.wikimedia.org/66699#c33 (10Matthew Flaschen) (In reply to Jared Zimmerman (WMF) from comment #27) > Most modern sites have dispensed with this type of control all together... [23:44:03] 3MediaWiki / 3ResourceLoader: CSSMin::minify should not interfere value contents of string values - 10https://bugzilla.wikimedia.org/35492#c8 (10James Forrester) 5ASSI>3NEW a:5Tim Landscheidt>3None Commit listed above was abandonned; resetting to "NEW". [23:46:53] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (b9d403a678) [core] - 10https://gerrit.wikimedia.org/r/142462 [23:47:11] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (b9d403a678) [core] - 10https://gerrit.wikimedia.org/r/142462 (owner: 10Jforrester) [23:51:17] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (b9d403a678) [core] - 10https://gerrit.wikimedia.org/r/142462 (owner: 10Jforrester) [23:52:57] (03CR) 10Swalling: "Jared: from testing on beta labs, it looks like it also applies to the quiet form of mw-ui-button." [core] - 10https://gerrit.wikimedia.org/r/142426 (https://bugzilla.wikimedia.org/61940) (owner: 10Robmoen) [23:55:47] 3MediaWiki extensions / 3Scribunto: HPHP::computeMaskFromNumElms(uint32_t): Assertion `n <= 0x7fffffffU' failed. - 10https://bugzilla.wikimedia.org/66943#c1 (10Tim Starling) This is a result of the Make/Copy work that I did in proxy-array.cpp in (03CR) 10Jdlrobson: [C: 032] "I think this behaviour is very weird (why list is at all) but you've done what the card says so I'll take this discussion elsewhere and we" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142401 (owner: 10Bsitu) [23:57:50] (03Merged) 10jenkins-bot: Highlight current sort option in navigation dropdown [extensions/Flow] - 10https://gerrit.wikimedia.org/r/142401 (owner: 10Bsitu) [23:59:02] 3Analytics / 3EventLogging: Multiple user_ids per username in account creation events from ServerSideAccountCreation log - 10https://bugzilla.wikimedia.org/66101 (10Chris Steipp) [23:59:05] 3MediaWiki extensions / 3CentralAuth: Always create global account if it doesn't exist - 10https://bugzilla.wikimedia.org/67175 (10Chris Steipp) 3NEW p:3Unprio s:3normal a:3None Currently, CentralAuth will not create a global account when a new account is created, if there are existing local accounts...