[00:05:27] (03CR) 10Krinkle: "FIXME: Suggesting revert if not fixed before deployment!" [core] - 10https://gerrit.wikimedia.org/r/136796 (https://bugzilla.wikimedia.org/65752) (owner: 10Nikerabbit) [00:06:28] (03CR) 10Bsitu: [C: 032] Use partial for flow_block_topic_close for consistency [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141493 (owner: 10Jdlrobson) [00:06:38] <^demon|away> Krinkle: Ugh, that patch was hard to review as it was. I'd be fine with reverting from master for the time being. [00:06:43] <^demon|away> And letting it get another round of review. [00:06:50] (03Merged) 10jenkins-bot: Use partial for flow_block_topic_close for consistency [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141493 (owner: 10Jdlrobson) [00:07:00] Nikerabbit: ^demon|away: manybubbles: ^ [00:07:31] <^demon|away> I hate how prefix searching is an unhealthy mess of hook + search engine subclassing. [00:07:38] Yeah [00:08:31] (03PS1) 10Krinkle: Revert "PrefixSearch (ApiOpenSearch) now supports searching in multiple namespaces" [core] - 10https://gerrit.wikimedia.org/r/141606 [00:08:54] Do we self-merge reverts as being reviewers? [00:09:00] (03PS24) 10Bsitu: Wire up close & open actions in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 [00:09:09] I tend to, but would be fine for you to do it as well [00:09:11] <^demon|away> I can merge it. [00:09:42] OK [00:10:16] (03CR) 10Chad: [C: 032] "Clean revert of code that needs some more shaking down before merge." [core] - 10https://gerrit.wikimedia.org/r/141606 (owner: 10Krinkle) [00:11:01] shahyar: It looks like you added an orange color for regressive actions to colors.less. Unfortunately, it doesn't match the orange color that design wants to use in their color palatte (https://trello.com/c/IRqbu8p4/15-color-swatches). You mind if I change it? [00:12:39] (03CR) 10Bsitu: Wire up close & open actions in JavaScript (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 (owner: 10Bsitu) [00:13:55] (03Merged) 10jenkins-bot: Revert "PrefixSearch (ApiOpenSearch) now supports searching in multiple namespaces" [core] - 10https://gerrit.wikimedia.org/r/141606 (owner: 10Krinkle) [00:14:33] (03PS3) 10Krinkle: SpecialPage: DRY array filter for prefixSearchSubpages() [core] - 10https://gerrit.wikimedia.org/r/141604 [00:15:57] (03PS2) 10EBernhardson: Don't include HTML tags as part of placeholder [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141585 [00:18:37] (03PS3) 10EBernhardson: Don't include HTML tags as part of placeholder [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141585 [00:21:06] (03PS4) 10Krinkle: SpecialPage: DRY array filter for prefixSearchSubpages() [core] - 10https://gerrit.wikimedia.org/r/141604 [00:21:08] (03PS2) 10Krinkle: SpecialJavaScriptTest: Implement prefixSearchSubpages() [core] - 10https://gerrit.wikimedia.org/r/141561 (owner: 10Bartosz Dziewoński) [00:21:14] 3MediaWiki extensions / 3Diff: Implement an order-aware MapDiffer - 10https://bugzilla.wikimedia.org/58274#c6 (10Andre Klapper) (In reply to tobias.gritschacher from comment #4) > Reopen this to not forget it when not following the issues on GitHub. Is this ticket still "highest priority" which was set half... [00:21:20] (03CR) 10Krinkle: [C: 031] SpecialJavaScriptTest: Implement prefixSearchSubpages() [core] - 10https://gerrit.wikimedia.org/r/141561 (owner: 10Bartosz Dziewoński) [00:23:45] (03PS1) 10CSteipp: Add MWOAuth namespace [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/141608 (https://bugzilla.wikimedia.org/66929) [00:26:28] 3MediaWiki extensions / 3EasyTimeline: EasyTimeline: in-browser visual editing - 10https://bugzilla.wikimedia.org/27157 (10James Forrester) [00:26:29] 3MediaWiki extensions / 3EasyTimeline: Create a VisualEditor plugin tool to add/edit Timelines - 10https://bugzilla.wikimedia.org/43115#c2 (10James Forrester) 5RESO/DUP>3REOP Not a duplicate; bug 27157 is about making a stand-alone interactive visual tool to create and edit EasyTimelines, whereas this is... [00:26:44] 3MediaWiki extensions / 3EasyTimeline: Create a VisualEditor plugin tool to add/edit Timelines - 10https://bugzilla.wikimedia.org/43115 (10James Forrester) 5REOP>3NEW [00:26:58] 3MediaWiki extensions / 3OAuth: OAuth: Dialog for granting an app permission should clarify or link to what "basic rights" are - 10https://bugzilla.wikimedia.org/66978#c3 (10Chris Steipp) Jared--https://tools.wmflabs.org/gerrit-patch-uploader/ and click on the "Log in using your mediawiki.org account" link a... [00:27:31] (03PS6) 10Kaldari: Updating mediawiki.ui color variables per design team [core] - 10https://gerrit.wikimedia.org/r/117105 [00:31:28] (03CR) 10jenkins-bot: [V: 04-1] Updating mediawiki.ui color variables per design team [core] - 10https://gerrit.wikimedia.org/r/117105 (owner: 10Kaldari) [00:34:29] 3MediaWiki extensions / 3[other]: Semantic Rating extension new version 1.2 generates bad html - 10https://bugzilla.wikimedia.org/67010#c1 (10Andre Klapper) Not sure where this project's bugtracker is; CC'ing its maintainer. [00:38:22] (03PS7) 10Kaldari: Updating mediawiki.ui color variables per design team [core] - 10https://gerrit.wikimedia.org/r/117105 [00:41:57] (03PS1) 10Aaron Schulz: Avoid key conflict errors in User::addToDatabase [core] - 10https://gerrit.wikimedia.org/r/141609 [00:43:59] (03PS8) 10Jforrester: Add es5-shim library v3.4.0 [core] - 10https://gerrit.wikimedia.org/r/139308 [00:44:13] (03CR) 10Jforrester: "PS8 rebases onto the json2 pull-in, and adds that as a dependency for OOjs, per Timo." [core] - 10https://gerrit.wikimedia.org/r/139308 (owner: 10Jforrester) [00:44:57] (03CR) 10jenkins-bot: [V: 04-1] Add es5-shim library v3.4.0 [core] - 10https://gerrit.wikimedia.org/r/139308 (owner: 10Jforrester) [00:49:53] (03PS3) 10SPQRobin: Improve page language functions [core] - 10https://gerrit.wikimedia.org/r/137033 [00:53:55] (03PS4) 10SPQRobin: Improve page language functions [core] - 10https://gerrit.wikimedia.org/r/137033 [00:57:59] (03CR) 10jenkins-bot: [V: 04-1] Improve page language functions [core] - 10https://gerrit.wikimedia.org/r/137033 (owner: 10SPQRobin) [01:07:38] (03PS4) 10Jforrester: Add json2.js polyfill (v2014-02-04; with module skip function) [core] - 10https://gerrit.wikimedia.org/r/140560 (owner: 10Krinkle) [01:07:53] (03CR) 10Jforrester: "PS4 is a rebase." [core] - 10https://gerrit.wikimedia.org/r/140560 (owner: 10Krinkle) [01:07:59] (03PS1) 10NativeForeigner: Make CheckUserLog trim trailing spaces [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/141610 [01:08:01] (03PS9) 10Jforrester: Add es5-shim library v3.4.0 [core] - 10https://gerrit.wikimedia.org/r/139308 [01:11:59] (03PS1) 10Jdlrobson: Hygiene: Cleanup browser test FlowPage [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141611 [01:12:02] (03PS1) 10Jdlrobson: QA: Fix the action menu permalink tests [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141612 [01:24:49] (03PS1) 10EBernhardson: make html to plaintext conversion explicit [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141614 [01:31:41] (03CR) 10TTO: Add additional interwiki links as requested in various bugs (032 comments) [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/141099 (https://bugzilla.wikimedia.org/43027) (owner: 10TTO) [01:34:45] (03CR) 10MZMcBride: Make CheckUserLog trim trailing spaces (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/141610 (owner: 10NativeForeigner) [01:42:48] (03CR) 10TTO: "I suppose you could run dumpInterwiki.php under the parent commit and under this commit, and compare the output." [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/94593 (https://bugzilla.wikimedia.org/56207) (owner: 10TTO) [01:44:33] (03PS1) 10Werdna: Only show cancel confirmation if at least one field has changed from its original value [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141616 [01:45:55] (03PS2) 10Werdna: Only show cancel confirmation if at least one field has changed from its original value [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141616 [01:48:10] (03CR) 10EBernhardson: [C: 032] "LGTM" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141616 (owner: 10Werdna) [01:48:26] (03Merged) 10jenkins-bot: Only show cancel confirmation if at least one field has changed from its original value [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141616 (owner: 10Werdna) [02:02:29] 3MediaWiki extensions / 3[other]: Semantic Rating extension new version 1.2 generates bad html - 10https://bugzilla.wikimedia.org/67010#c2 (10Cindy Cicalese) Thank you for the bug report. I am not seeing that behavior, but I am guessing that it has to do with the change to line 87 of SemanticRating.php. Coul... [02:03:59] (03PS1) 10Werdna: Add plainlinks class to flow-board-link instances. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141618 [02:13:37] (03PS1) 10Ori.livneh: Check for boolean false result from database query in SqlBagOStuff [core] - 10https://gerrit.wikimedia.org/r/141619 [02:14:17] (03PS1) 10tosfos: initial commit [extensions/ListSignup] - 10https://gerrit.wikimedia.org/r/141620 [02:17:12] (03PS1) 10tosfos: initial commit [extensions/ListSignup] - 10https://gerrit.wikimedia.org/r/141621 [02:19:20] (03Abandoned) 10tosfos: initial commit [extensions/ListSignup] - 10https://gerrit.wikimedia.org/r/141620 (owner: 10tosfos) [02:20:09] (03CR) 10tosfos: [C: 032 V: 032] initial commit [extensions/ListSignup] - 10https://gerrit.wikimedia.org/r/141621 (owner: 10tosfos) [02:41:29] (03CR) 10TTO: "> When I do that I get no differences, which seems a good thing to me." [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/94593 (https://bugzilla.wikimedia.org/56207) (owner: 10TTO) [02:51:11] (03PS3) 10Bsitu: Fix 'Load More' [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141564 [02:55:54] (03PS1) 10Chad: Remove rescores when not sorting by relevance [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/141622 (https://bugzilla.wikimedia.org/60547) [03:01:33] (03CR) 10Quiddity: [C: 04-1] "I've objected to the changes to the" [core] - 10https://gerrit.wikimedia.org/r/117105 (owner: 10Kaldari) [03:03:39] (03PS1) 10Werdna: Reintroduce highlighting for permalinks. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141623 [03:05:35] (03PS1) 10Chad: Spell existent correctly [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/141624 [03:11:47] (03CR) 10Quiddity: [C: 04-1] "Jaredzimmerman wrote:" [core] - 10https://gerrit.wikimedia.org/r/133301 (https://bugzilla.wikimedia.org/65160) (owner: 10Jforrester) [03:15:07] (03CR) 10Withoutaname: "I'm not sure how this could be tested with PHPUnit, but I setup a test installation to use Serbian ('sr') and switched between sr-EC and s" [core] - 10https://gerrit.wikimedia.org/r/141104 (https://bugzilla.wikimedia.org/57562) (owner: 10Withoutaname) [03:15:46] 3Wikimedia / 3Apache configuration: m.wikipedia.org incorrectly redirects to en.m.wikipedia.org - 10https://bugzilla.wikimedia.org/67015 (10MZMcBride) 3NEW p:3Unprio s:3normal a:3None http://m.wikipedia.org currently redirects to http://en.m.wikipedia.org I don't believe m.wikipedia.org previously r... [03:29:29] 3Wikimedia / 3Apache configuration: m.wikipedia.org incorrectly redirects to en.m.wikipedia.org - 10https://bugzilla.wikimedia.org/67015#c1 (10MZMcBride) https://git.wikimedia.org/blob/operations%2Fapache-config.git/20c6fce57fab11fe945e1fba5f3f85e238f04216/wwwportals.conf#L51 --> https://git.wikimedia.org/... [03:43:40] (03PS1) 10Prtksxna: Use jquery.tipsy to show errors [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/141627 [03:43:42] (03PS1) 10Prtksxna: Change form styling and add animations [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/141628 [03:44:08] (03CR) 10Springle: First version of Page Language selector (032 comments) [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [04:00:12] (03CR) 10Legoktm: [C: 04-1] Use jquery.tipsy to show errors (031 comment) [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/141627 (owner: 10Prtksxna) [04:00:28] (03PS1) 10Werdna: Add apiPreHandler to submitTopicTitle to squelch warnings about etrevId parameter [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141630 [04:01:29] (03CR) 10Legoktm: [C: 04-1] Change form styling and add animations (031 comment) [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/141628 (owner: 10Prtksxna) [04:02:47] superm401: in https://gerrit.wikimedia.org/r/#/c/119055/ you mentioned "I get a lot of notices and warnings that seem unrelated, then a CentralAuth database error (centralauth.unittest_globaluser' doesn't exist (localhost))." [04:02:57] superm401: did you file a bug? and was that with hhvm? [04:03:02] i'm getting the same error [04:04:27] ori, don't think I filed a bug. Would probably be at https://bugzilla.wikimedia.org/buglist.cgi?component=CentralAuth&email1=mflaschen&emailreporter1=1&emailtype1=substring&list_id=324105&product=MediaWiki%20extensions&query_format=advanced&resolution=---&resolution=FIXED&resolution=INVALID&resolution=WONTFIX&resolution=LATER&resolution=DUPLICATE&resolution=WORKSFORME . [04:04:33] I don't think I was using hhvm either. [04:04:38] Would appreciate if you file a bug. [04:04:46] (03CR) 10Legoktm: [C: 031] "Minor style nitpicks, looks fine otherwise." (033 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/141610 (owner: 10NativeForeigner) [04:05:05] ori, don't think it's actually related to the LESS patch (one wouldn't think so). [04:07:37] no, i don't think so either [04:07:50] i'll file one [04:07:52] thanks [04:08:21] (03PS1) 10Werdna: Add topic moderation action messages to Resources.php. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141631 [04:10:09] (03PS2) 10Prtksxna: Use jquery.tipsy to show errors [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/141627 [04:10:11] (03PS2) 10Prtksxna: Change form styling and add animations [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/141628 [04:26:18] (03PS1) 10PleaseStand: Add includes/page/ to findHooks.php [core] - 10https://gerrit.wikimedia.org/r/141632 [04:26:20] (03PS1) 10PleaseStand: Combine SpecialPageBeforeFormDisplay set of hooks into one [core] - 10https://gerrit.wikimedia.org/r/141633 [04:26:30] 3Wikimedia / 3Site requests: Request to lift IP address for mass creation - te.wikipedia.org - 10https://bugzilla.wikimedia.org/67017 (10Rahmanuddin Shaik) 3UNCO p:3Unprio s:3normal a:3None Request to lift IP address for mass creation - te.wikipedia.org for 50 members at 117.211.82.67. For duration o... [04:26:31] 3MediaWiki extensions / 3ZeroRatedMobileAccess: Warning: JsonConfig: Invalid $wgJsonConfigs['JsonZeroConfig']: Model 'JsonZeroConfig' is already registered in $wgContentHandlers to Extensions\ZeroRatedMobileAccess\ZeroConfigContentHand ler - 10https://bugzilla.wikimedia.org/67016 (10Ori Livneh) 3NEW p:3Un... [04:26:38] (03PS1) 10PleaseStand: Use new SpecialPageBeforeFormDisplay hook [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/141634 [04:27:06] (03PS1) 10Werdna: Message adjustments for editing posts. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141635 [04:27:44] 3Wikimedia / 3Site requests: Request to lift IP address for mass creation - te.wikipedia.org - 10https://bugzilla.wikimedia.org/67017 (10Rahmanuddin Shaik) [04:28:10] (03PS1) 10Mattflaschen: WIP: Fix collapse browser tests, add tests for moderation collapsing [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141636 [04:28:29] (03CR) 10jenkins-bot: [V: 04-1] Combine SpecialPageBeforeFormDisplay set of hooks into one [core] - 10https://gerrit.wikimedia.org/r/141633 (owner: 10PleaseStand) [04:29:31] (03PS2) 10Werdna: Fix missing messages: [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141631 [04:29:43] 3MediaWiki extensions / 3ZeroRatedMobileAccess: Warning: JsonConfig: Invalid $wgJsonConfigs['JsonZeroConfig']: Model 'JsonZeroConfig' is already registered in $wgContentHandlers to Extensions\ZeroRatedMobileAccess\ZeroConfigContentHandler - 10https://bugzilla.wikimedia.org/67016#c1 (10Ori Livneh) It's becaus... [04:29:47] (03CR) 10Mattflaschen: [C: 04-2] "This is not ready (neither the scenarios nor the backend are done), so no real need to review unless you feel like it's heading in the wro" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141636 (owner: 10Mattflaschen) [04:33:21] (03CR) 10PleaseStand: [C: 04-1] "The new hook is not yet in core. Don't merge before then." [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/141634 (owner: 10PleaseStand) [04:34:22] (03PS3) 10Prtksxna: Change form styling and add animations [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/141628 [04:35:45] (03CR) 10Prtksxna: Use jquery.tipsy to show errors (031 comment) [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/141627 (owner: 10Prtksxna) [04:36:23] (03CR) 10Prtksxna: Change form styling and add animations (031 comment) [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/141628 (owner: 10Prtksxna) [04:38:59] 3Wikimedia / 3Extension setup: Review and deploy ThrottleOverride extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/25000#c36 (10MZMcBride) Tyler: should this bug still be assigned to you? [04:45:34] (03PS1) 10Werdna: Restrict indentation of edit forms and previews. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141638 [04:58:46] (03PS1) 10Divec: DONT MERGE: Apertium interface client module [services/cxserver] - 10https://gerrit.wikimedia.org/r/141641 [04:59:26] (03CR) 10jenkins-bot: [V: 04-1] DONT MERGE: Apertium interface client module [services/cxserver] - 10https://gerrit.wikimedia.org/r/141641 (owner: 10Divec) [05:02:59] prtksxna: also I think we should make the URL font size bigger [05:03:07] prtksxna: since it's currently much smaller than the textbox [05:03:18] YuviPanda|woozy: The shortened one? [05:03:26] prtksxna: ya [05:03:44] 3MediaWiki / 3Logging: Logging needs a log_title index - 10https://bugzilla.wikimedia.org/66961#c3 (10Sean Pringle) The example queries I've seen so far always use both log_namespace and log_title which means the page_time index can be used partially: KEY page_time (log_namespace, log_title, log_timestamp)... [05:06:15] anyone else missing emails from mediawiki-commits today? [05:07:29] (03PS4) 10Prtksxna: Change form styling and add animations [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/141628 [05:07:34] YuviPanda|woozy: Done ^ [05:08:31] Nikerabbit: at all? siebrand was missing gerrit emails yesterday [05:10:52] filing a bug [05:11:31] 3Wikimedia / 3Git/Gerrit: No emails from mediawiki-commits anymore - 10https://bugzilla.wikimedia.org/67018 (10Niklas Laxström) 3NEW p:3Unprio s:3normal a:3None The last email I received from mediawiki-commits is from 2014-06-23 15.17 UTC. From SAL: 16:33 paravoid: switched inbound mail for all non-... [05:11:37] there [05:11:47] perhaps pointing to the wrong server now [05:12:34] as you wrote [05:12:53] (03CR) 10Springle: [C: 031] "Hoo is right to question the indexing." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/139103 (https://bugzilla.wikimedia.org/20892) (owner: 10Huji) [05:14:14] 3Wikimedia / 3Git/Gerrit: No emails from mediawiki-commits anymore - 10https://bugzilla.wikimedia.org/67018 (10Nemo) [05:14:29] 3Wikimedia / 3Git/Gerrit: No emails from mediawiki-commits anymore - 10https://bugzilla.wikimedia.org/67018#c1 (10Siebrand Mazeland) Confirmed. [05:18:00] (03CR) 10KartikMistry: [C: 032 V: 032] "No Jenkins, so by hand merge as per Gabriel's +2." [services/cxserver/deploy] - 10https://gerrit.wikimedia.org/r/140059 (owner: 10KartikMistry) [05:26:14] 3MediaWiki extensions / 3ZeroRatedMobileAccess: Warning: JsonConfig: Invalid $wgJsonConfigs['JsonZeroConfig']: Model 'JsonZeroConfig' is already registered in $wgContentHandlers to Extensions\ZeroRatedMobileAccess\ZeroConfigContentHandler - 10https://bugzilla.wikimedia.org/67016#c2 (10Yuri Astrakhan) Ori, Ze... [05:27:49] (03CR) 10NativeForeigner: Make CheckUserLog trim trailing spaces (033 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/141610 (owner: 10NativeForeigner) [05:28:28] 3MediaWiki extensions / 3ZeroRatedMobileAccess: Warning: JsonConfig: Invalid $wgJsonConfigs['JsonZeroConfig']: Model 'JsonZeroConfig' is already registered in $wgContentHandlers to Extensions\ZeroRatedMobileAccess\ZeroConfigContentHandler - 10https://bugzilla.wikimedia.org/67016#c3 (10Ori Livneh) (In reply t... [05:29:09] (03PS1) 10Werdna: Use topic title as page title for permalinks. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141642 [05:29:23] (03PS2) 10Deepali: Implement options to format text to improve readability [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/141301 (https://bugzilla.wikimedia.org/65329) [05:31:30] 3MediaWiki / 3Database: cl_collation index redundant - 10https://bugzilla.wikimedia.org/57184 (10Sean Pringle) a:3Sean Pringle [05:31:45] 3MediaWiki / 3Database: log_page_id_time index redundant - 10https://bugzilla.wikimedia.org/57182 (10Sean Pringle) a:3Sean Pringle [05:32:59] 3Wikimedia / 3Apache configuration: m.wikipedia.org incorrectly redirects to en.m.wikipedia.org - 10https://bugzilla.wikimedia.org/67015#c2 (10Yuri Astrakhan) ZRMA extension is obsolete, the new code is in https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FZeroBanner.git/6411d46a0d81abc2be87093626860d20... [05:34:15] ori, around? [05:34:25] (03CR) 10Mattflaschen: [C: 04-1] "With the current architecture, I think it's better to do it at https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FFlow.git/a438acc85c" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141642 (owner: 10Werdna) [05:34:29] 3MediaWiki / 3Database: ApiQueryRandom allows slow queries for nonexistant page_namespace - 10https://bugzilla.wikimedia.org/57285 (10Sean Pringle) 5NEW>3RESO/FIX [05:35:59] 3Wikimedia / 3Apache configuration: m.wikipedia.org incorrectly redirects to en.m.wikipedia.org - 10https://bugzilla.wikimedia.org/67015#c3 (10Yuri Astrakhan) Btw, this also means that we are not handling the www.m. case correctly - it should go through the same route as m. Might need a bug for this i think. [05:36:36] (03PS1) 10PleaseStand: hash_equals(): Avoid division by zero when $known_string is empty [core] - 10https://gerrit.wikimedia.org/r/141643 [05:38:43] 3MediaWiki extensions / 3ZeroRatedMobileAccess: Warning: JsonConfig: Invalid $wgJsonConfigs['JsonZeroConfig']: Model 'JsonZeroConfig' is already registered in $wgContentHandlers to Extensions\ZeroRatedMobileAccess\ZeroConfigContentHandler - 10https://bugzilla.wikimedia.org/67016 (10Yuri Astrakhan) 5NEW>3R... [05:46:51] (03CR) 10Mattflaschen: Use topic title as page title for permalinks. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141642 (owner: 10Werdna) [05:49:03] (03CR) 10Legoktm: [C: 032] Add includes/page/ to findHooks.php [core] - 10https://gerrit.wikimedia.org/r/141632 (owner: 10PleaseStand) [05:51:56] (03Merged) 10jenkins-bot: Add includes/page/ to findHooks.php [core] - 10https://gerrit.wikimedia.org/r/141632 (owner: 10PleaseStand) [05:54:11] ^demon|away: also seeing "Search backend error during sending 32 documents to the content index after 56. Regex syntax error: failed to execute script" [06:00:41] (03PS2) 10Divec: DONT MERGE: Apertium interface client module [services/cxserver] - 10https://gerrit.wikimedia.org/r/141641 [06:01:07] (03CR) 10jenkins-bot: [V: 04-1] DONT MERGE: Apertium interface client module [services/cxserver] - 10https://gerrit.wikimedia.org/r/141641 (owner: 10Divec) [06:04:00] (03PS1) 10Gerrit Patch Uploader: mediawiki.page.patrol.ajax: Use postWithToken [core] - 10https://gerrit.wikimedia.org/r/141644 [06:04:02] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/141644 (owner: 10Gerrit Patch Uploader) [06:13:07] (03PS4) 10Gerrit Patch Uploader: Use instead of for JavaScript click events [core] - 10https://gerrit.wikimedia.org/r/139795 (https://bugzilla.wikimedia.org/42241) [06:13:09] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/139795 (https://bugzilla.wikimedia.org/42241) (owner: 10Gerrit Patch Uploader) [06:13:28] 3Wikimedia / 3Git/Gerrit: No emails from gerrit at all, including mediawiki-commits - 10https://bugzilla.wikimedia.org/67018#c2 (10Nemo) p:5Unprio>3Immedi s:5normal>3major It's not mailing list only; last email I received from gerrit was at Date: Mon, 23 Jun 2014 15:05:38 +0000 [06:14:10] (03PS3) 10Gerrit Patch Uploader: search.less: Use static width for the search button [core] - 10https://gerrit.wikimedia.org/r/127371 [06:14:12] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/127371 (owner: 10Gerrit Patch Uploader) [06:23:35] (03PS1) 10Gerrit Patch Uploader: jquery.makeCollapsible: Remove tabindex="0" [core] - 10https://gerrit.wikimedia.org/r/141646 [06:23:37] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/141646 (owner: 10Gerrit Patch Uploader) [06:24:52] (03PS1) 10Werdna: Update convertToText.php to use new API. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141647 [06:35:58] (03PS2) 10PleaseStand: Combine SpecialPageBeforeFormDisplay set of hooks into one [core] - 10https://gerrit.wikimedia.org/r/141633 [06:38:05] (03PS25) 1001tonythomas: Added VERP functionality hook to core [core] - 10https://gerrit.wikimedia.org/r/138655 (https://bugzilla.wikimedia.org/46640) [06:39:02] (03PS3) 10Deepali: Implement options to format text to improve readability [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/141301 (https://bugzilla.wikimedia.org/65329) [06:39:51] (03PS1) 10EBernhardson: Hygine: fix LinksTableTest case with wrong data [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141649 [06:39:57] (03CR) 1001tonythomas: "@Pleasestand:- as you told, passing the envelope sender as the 5th param simplifies things after Ibb88a6cfd762f834340f6362fe70ea7e6c838b37" [core] - 10https://gerrit.wikimedia.org/r/138655 (https://bugzilla.wikimedia.org/46640) (owner: 1001tonythomas) [06:43:10] (03CR) 10Aude: "extensions don't get loaded for core coverage, right?" [core] - 10https://gerrit.wikimedia.org/r/140909 (owner: 10Aude) [06:54:24] Nemo_bis: according to Faidons comment here https://gerrit.wikimedia.org/r/#/c/141287/ -- we need to have "MediaWiki should be setting wiki@wikimedia.org as its envelope *now* " -- this can be achieved by passing it as the 5th param in mail () ? [06:56:11] (03PS2) 10Werdna: Use topic title as page title for permalinks. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141642 [07:03:01] 3MediaWiki extensions / 3SemanticForms: Not displayed category determined by the template if the namespace "NS_CATEGORY" uses the Cyrillic. - 10https://bugzilla.wikimedia.org/67020 (10Jumuro) 3UNCO p:3Unprio s:3normal a:3Yaron Koren My wiki works on Russian localization. And if I specify in the temp... [07:07:16] 3MediaWiki / 3Special pages: When an ISBN-10 should end in X yet ends in 0, Special:BookSources treats it as valid - 10https://bugzilla.wikimedia.org/67021 (10Kevin Israel (PleaseStand)) 3NEW p:3Unprio s:3minor a:3None I noticed this when checking old TODOs and reading the code. It is a bug arising i... [07:08:07] (03CR) 10Matthias Mullie: [C: 032] Hygine: fix LinksTableTest case with wrong data [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141649 (owner: 10EBernhardson) [07:08:24] (03Merged) 10jenkins-bot: Hygine: fix LinksTableTest case with wrong data [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141649 (owner: 10EBernhardson) [07:08:39] (03CR) 10TheDJ: "This needs something like 'isfocusableElement' logic to figure out if the target is natively focusable/tabbable. jquery.ui has that, but w" [core] - 10https://gerrit.wikimedia.org/r/141646 (owner: 10Gerrit Patch Uploader) [07:09:37] (03PS1) 10Ori.livneh: Fix risky testRejectRequestWithMissingParameters test [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/141651 [07:12:33] (03CR) 10Ori.livneh: [C: 031] "Thanks for jumping on that. Just one question: how do you pronounce "MWOAuth"? :)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/141608 (https://bugzilla.wikimedia.org/66929) (owner: 10CSteipp) [07:13:11] 'mwath'? [07:13:36] (03CR) 10TheDJ: "Actually, since the .click isn't set on the element (but the span around it), you could even argue that the element should have ta" [core] - 10https://gerrit.wikimedia.org/r/141646 (owner: 10Gerrit Patch Uploader) [07:13:38] Mwath, the Egyptian goddess of authentication [07:16:42] (03CR) 10Daniel Kinzler: [C: 032] Remove SearchEngineReplacePrefixesComplete hook [core] - 10https://gerrit.wikimedia.org/r/141066 (owner: 10Chad) [07:16:58] 3MediaWiki / 3Special pages: When an ISBN-10 should end in 0 yet ends in X, Special:BookSources treats it as valid - 10https://bugzilla.wikimedia.org/67021 (10Kevin Israel (PleaseStand)) [07:20:19] (03Merged) 10jenkins-bot: Remove SearchEngineReplacePrefixesComplete hook [core] - 10https://gerrit.wikimedia.org/r/141066 (owner: 10Chad) [07:32:07] (03PS1) 10PleaseStand: Special:BookSources: Correct ISBN-10 validation for numbers ending in X [core] - 10https://gerrit.wikimedia.org/r/141654 (https://bugzilla.wikimedia.org/67021) [07:40:46] (03PS4) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/141418 [07:40:53] (03PS1) 10Aude: Set wgScript in LinkerTest [core] - 10https://gerrit.wikimedia.org/r/141655 [07:40:57] (03CR) 10PleaseStand: [C: 04-1] "Doesn't fix all cases..." [core] - 10https://gerrit.wikimedia.org/r/141654 (https://bugzilla.wikimedia.org/67021) (owner: 10PleaseStand) [07:45:30] (03PS2) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/141422 [07:46:58] 3Wikimedia / 3Site requests: Request to lift IP address for mass creation - te.wikipedia.org - 10https://bugzilla.wikimedia.org/67017 (10Tomasz W. Kozlowski) p:5Unprio>3Normal s:5normal>3enhanc [07:47:41] (03PS3) 10Inchikutty: [WIP] Adds OSM parameter to coordinate template [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/141122 [07:47:47] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Adds OSM parameter to coordinate template [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/141122 (owner: 10Inchikutty) [07:52:44] 3MediaWiki / 3Special pages: When an ISBN has an X where it should have a 0, Special:BookSources treats it as valid - 10https://bugzilla.wikimedia.org/67021#c2 (10Kevin Israel (PleaseStand)) Unfortunately, there are more problems: 4. Open 5. Ope... [07:52:45] (03PS1) 10Nikerabbit: Import extension code [extensions/MixedNamespaceSearchSuggestions] - 10https://gerrit.wikimedia.org/r/141656 [08:02:23] (03CR) 10Spage: [C: 032] "Two of the parentheses tests fail, next patch addresses." (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/138776 (owner: 10Prtksxna) [08:02:29] (03Merged) 10jenkins-bot: render.article.getProcessesHtml: Add tests [extensions/Popups] - 10https://gerrit.wikimedia.org/r/138776 (owner: 10Prtksxna) [08:03:24] (03PS1) 10Werdna: Fix up topic reply link. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141658 [08:03:42] (03CR) 10jenkins-bot: [V: 04-1] Fix up topic reply link. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141658 (owner: 10Werdna) [08:04:37] (03CR) 10Nemo bis: [C: 04-1] Import extension code (036 comments) [extensions/MixedNamespaceSearchSuggestions] - 10https://gerrit.wikimedia.org/r/141656 (owner: 10Nikerabbit) [08:05:01] (03PS2) 10Werdna: Fix up topic reply link. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141658 [08:06:52] (03CR) 10TheDJ: [C: 032] Allow fragments in link= parameter in tags. [core] - 10https://gerrit.wikimedia.org/r/141569 (https://bugzilla.wikimedia.org/62343) (owner: 10Brian Wolff) [08:07:43] 3MediaWiki / 3Parser: Gallery image with link= going to top of - 10https://bugzilla.wikimedia.org/62343 (10Derk-Jan Hartman) 5PATC>3RESO/FIX [08:08:44] 3Analytics / 3General/Unknown: Daily aggregates of hourly webstatscollector files missing since 2014-05-08 - 10https://bugzilla.wikimedia.org/65627#c5 (10christian) 5PATC>3RESO/FIX Daily and monthly files again get generated and show up on dumps.wikimedia.org [08:09:01] (03CR) 10Nikerabbit: Import extension code (031 comment) [extensions/MixedNamespaceSearchSuggestions] - 10https://gerrit.wikimedia.org/r/141656 (owner: 10Nikerabbit) [08:10:16] (03Merged) 10jenkins-bot: Allow fragments in link= parameter in tags. [core] - 10https://gerrit.wikimedia.org/r/141569 (https://bugzilla.wikimedia.org/62343) (owner: 10Brian Wolff) [08:10:46] (03PS2) 10Nikerabbit: Import extension code [extensions/MixedNamespaceSearchSuggestions] - 10https://gerrit.wikimedia.org/r/141656 [08:12:50] (03CR) 10Spage: [C: 032] "Tests pass with this fix \o/, helped me see what's going on. I'm not crazy about the variable name, I will propose a rename patch" (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135759 (https://bugzilla.wikimedia.org/65138) (owner: 10Prtksxna) [08:12:56] (03Merged) 10jenkins-bot: render.article: Remove brackets using code instead of RegExp [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135759 (https://bugzilla.wikimedia.org/65138) (owner: 10Prtksxna) [08:21:22] (03CR) 10Nemo bis: "Looked the JS again but other than noting the absence of $wgNamespacesToBeSearchedDefault I can't tell anything" (034 comments) [extensions/MixedNamespaceSearchSuggestions] - 10https://gerrit.wikimedia.org/r/141656 (owner: 10Nikerabbit) [08:23:24] (03PS2) 10PleaseStand: Special:BookSources: Correct validation of ISBNs containing X [core] - 10https://gerrit.wikimedia.org/r/141654 (https://bugzilla.wikimedia.org/67021) [08:23:48] (03PS1) 10Nikerabbit: PrefixSearch (ApiOpenSearch) now supports searching in multiple namespaces [core] - 10https://gerrit.wikimedia.org/r/141660 (https://bugzilla.wikimedia.org/65752) [08:24:46] (03CR) 10Nikerabbit: "Fixed in I4bec7b5548fc2 by adding the missing return statements, which caused all cases to fall through to the default search." [core] - 10https://gerrit.wikimedia.org/r/136796 (https://bugzilla.wikimedia.org/65752) (owner: 10Nikerabbit) [08:26:41] (03PS1) 10Spage: rename variable, and parentheses not brackets [extensions/Popups] - 10https://gerrit.wikimedia.org/r/141661 [08:26:44] (03CR) 10Prtksxna: render.article: Remove brackets using code instead of RegExp (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135759 (https://bugzilla.wikimedia.org/65138) (owner: 10Prtksxna) [08:31:22] (03CR) 10Nemo bis: Import extension code (031 comment) [extensions/MixedNamespaceSearchSuggestions] - 10https://gerrit.wikimedia.org/r/141656 (owner: 10Nikerabbit) [08:36:18] (03PS3) 10Nikerabbit: Import extension code [extensions/MixedNamespaceSearchSuggestions] - 10https://gerrit.wikimedia.org/r/141656 [08:38:38] (03CR) 10Nikerabbit: [C: 032 V: 032] Import extension code [extensions/MixedNamespaceSearchSuggestions] - 10https://gerrit.wikimedia.org/r/141656 (owner: 10Nikerabbit) [08:40:13] (03CR) 10Fomafix: "All other buttons only the text between the brackets is the clickable link. Why should here the whole button clickable." [core] - 10https://gerrit.wikimedia.org/r/141646 (owner: 10Gerrit Patch Uploader) [08:43:31] (03PS1) 10Nikerabbit: Fix link in markdown [extensions/MixedNamespaceSearchSuggestions] - 10https://gerrit.wikimedia.org/r/141662 [08:44:14] (03CR) 10Nikerabbit: [C: 032 V: 032] Fix link in markdown [extensions/MixedNamespaceSearchSuggestions] - 10https://gerrit.wikimedia.org/r/141662 (owner: 10Nikerabbit) [08:48:10] thedj: Got a minute? [08:48:41] i'm at work, so i have a minute, but not 15 :) [08:51:11] thedj: Hehe. Does disablePopups need to be called at a particular time? It seems to be failing when I https://en.wikipedia.org/wiki/User:Prtksxna/common.js [08:52:22] thedj: I never reaches done. [08:52:40] s/I/It [09:00:23] (03PS1) 10PleaseStand: Remove use of OutputPage::addParserOutputNoText() [core] - 10https://gerrit.wikimedia.org/r/141664 [09:03:16] 3MediaWiki extensions / 3FlaggedRevs: AJAX review errors show HTML markup in notification - 10https://bugzilla.wikimedia.org/67023 (10Derk-Jan Hartman) 3NEW p:3Unprio s:3normal a:3None Created attachment 15707 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15707&action=edit screenshot of the... [09:10:44] 3MediaWiki / 3Installer: Installer can put html errors at the top of LocalSettings.php - 10https://bugzilla.wikimedia.org/66922 (10Jesús Martínez Novo (Ciencia Al Poder)) 5PATC>3RESO/FIX [09:29:01] 3MediaWiki extensions / 3CirrusSearch: Search suggestions include non.existing fullpagenames - 10https://bugzilla.wikimedia.org/67024 (10Nemo) 3NEW p:3Unprio s:3normal a:3None On mediawiki.org, 1) Cype "Manual:Content" in the search bar. I. Observed: the "Manual:Content namespace" title is suggested... [09:30:15] 3MediaWiki extensions / 3TextExtracts: #section-links should preview the correct subsection - 10https://bugzilla.wikimedia.org/63792#c2 (10Prateek Saxena) Any update on this? [09:30:51] (03CR) 10Krinkle: "Hm.. I don't suppose we could drop the prefix from the classes then?" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/141608 (https://bugzilla.wikimedia.org/66929) (owner: 10CSteipp) [09:36:04] How will I know if a hook ran successfully in MW ? [09:37:26] gerrit down ? :o [09:37:29] 3Wikimedia / 3Git/Gerrit: No emails from gerrit at all, including mediawiki-commits - 10https://bugzilla.wikimedia.org/67018#c3 (10christian) I forgot to link this bug in the corresponding commit https://gerrit.wikimedia.org/r/141665 . [09:37:47] (03PS5) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/141418 [09:39:22] tonythomas: Gerrit got rebooted around bug 141665. Should be working again. [09:39:57] qchris: oh. looks good now [10:05:14] (03PS2) 10Matthias Mullie: Add title as placeholder, prefill content with user mention [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140912 [10:07:44] 3MediaWiki extensions / 3CirrusSearch: Search suggestions include non-existing fullpagenames - 10https://bugzilla.wikimedia.org/67024#c1 (10Nemo) This might be another thing that https://gerrit.wikimedia.org/r/#/c/141660/ fixes though. [10:08:14] 3MediaWiki extensions / 3Popups: Hovercards: disable NavigationPopups (Gadget) if Hovercards Beta Feature is enabled - 10https://bugzilla.wikimedia.org/62952#c4 (10Prateek Saxena) 5PATC>3NEW The merged patch did not work as intended. [10:09:08] (03PS1) 10Prtksxna: disablenavpop: Use winow:load instead of dom:ready [extensions/Popups] - 10https://gerrit.wikimedia.org/r/141668 (https://bugzilla.wikimedia.org/62952) [10:10:14] 3Wikimedia / 3Git/Gerrit: No emails from gerrit at all, including mediawiki-commits - 10https://bugzilla.wikimedia.org/67018#c4 (10christian) 5NEW>3RESO/FIX Above commit got merged. Thanks _joe_! Gerrit is sending emails again. [10:15:17] 3MediaWiki extensions / 3[other]: Semantic Rating extension new version 1.2 generates bad html - 10https://bugzilla.wikimedia.org/67010#c3 (10Aditya Chaturvedi) I am using mediawiki 1.23. You were right, the problem goes away on doing what you suggested. Also, I suggest that on line 66 on SemanticRating.cl... [10:27:00] spagewmf: Single line change - https://gerrit.wikimedia.org/r/#/c/141668/ - whenever you have time :) [10:28:59] 3MediaWiki extensions / 3CirrusSearch: Search suggestions include non-existing fullpagenames - 10https://bugzilla.wikimedia.org/67024#c2 (10Nemo) > This might be another thing that https://gerrit.wikimedia.org/r/#/c/141660/ > fixes though. I doubt it, the patch it follows up to is not live on mediawiki.org. [10:35:24] (03CR) 10Krinkle: [C: 04-1] "As the comment says, this isn't for the sample case where the toggle element is an (default) or