[00:01:10] (03CR) 10Withoutaname: Moved Article::render() to RenderAction::show() (032 comments) [core] - 10https://gerrit.wikimedia.org/r/141359 (owner: 10Withoutaname) [00:04:19] (03CR) 10TheDJ: "That still doesn't answer my question. In the absence of a CodeEditor on a JS or CSS or Lua page, why would you need a the WikiEditor ?" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/141296 (https://bugzilla.wikimedia.org/24713) (owner: 10TheDJ) [00:19:47] (03PS6) 10SPQRobin: (bug 66960) Require MediaWiki:Licenses to enable uploads (WMF) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/136520 [00:25:56] (03CR) 10Hoo man: [C: 031] "Only briefly looked at the implementation, but I definitely support the idea!" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/136520 (owner: 10SPQRobin) [00:28:24] (03CR) 10SPQRobin: "I created bug 66960 for this (and added in the commit title)." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/136520 (owner: 10SPQRobin) [00:52:18] (03CR) 10Legoktm: [C: 032] Add authorship info and tweaks to $wgExtensionCredits for core skins [core] - 10https://gerrit.wikimedia.org/r/141127 (owner: 10Bartosz Dziewoński) [00:56:07] (03Merged) 10jenkins-bot: Add authorship info and tweaks to $wgExtensionCredits for core skins [core] - 10https://gerrit.wikimedia.org/r/141127 (owner: 10Bartosz Dziewoński) [00:57:47] (03Abandoned) 10Shirayuki: i18n: Fix message keys [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/139078 (owner: 10Shirayuki) [01:18:16] (03PS9) 10Prtksxna: Re-use result instead of querying the DOM for selector multiple times [extensions/Popups] - 10https://gerrit.wikimedia.org/r/134266 (owner: 10TheDJ) [01:19:07] (03CR) 10Prtksxna: [C: 032] "Added documentation string." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/134266 (owner: 10TheDJ) [01:19:11] (03Merged) 10jenkins-bot: Re-use result instead of querying the DOM for selector multiple times [extensions/Popups] - 10https://gerrit.wikimedia.org/r/134266 (owner: 10TheDJ) [01:38:03] (03PS7) 10Prtksxna: Handle links with empty or no title attributes [extensions/Popups] - 10https://gerrit.wikimedia.org/r/134268 (owner: 10TheDJ) [01:38:19] (03PS13) 10BryanDavis: Use MWLogger logging for legacy logging methods [core] - 10https://gerrit.wikimedia.org/r/119941 [01:38:21] (03PS12) 10BryanDavis: Add a PSR-3 based logging interface [core] - 10https://gerrit.wikimedia.org/r/119940 [01:38:23] (03PS7) 10BryanDavis: Use MWLogger logging for wfLogProfilingData [core] - 10https://gerrit.wikimedia.org/r/119942 [01:40:34] (03CR) 10jenkins-bot: [V: 04-1] Use MWLogger logging for legacy logging methods [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [01:40:45] (03PS5) 10Prtksxna: Some small cleanup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/134269 (owner: 10TheDJ) [01:41:43] thedj: If we get rid of the dependency of this commit ^ we can merge it [01:42:44] (03CR) 10jenkins-bot: [V: 04-1] Use MWLogger logging for wfLogProfilingData [core] - 10https://gerrit.wikimedia.org/r/119942 (owner: 10BryanDavis) [01:51:15] (03CR) 10Prtksxna: [C: 032 V: 032] "Thanks!" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140569 (owner: 10Gerrit Patch Uploader) [01:55:05] (03CR) 10Huji: "Well, it is based on the same method that is used to show a message on top of pages that are deleted. The lack of index affects that funct" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/139103 (https://bugzilla.wikimedia.org/20892) (owner: 10Huji) [02:17:26] (03PS1) 10Werdna: Hide drop down menus when an item is clicked [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141371 [02:27:00] (03PS5) 10Werdna: QA: Fix edit_existing.feature test [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141050 (owner: 10Jdlrobson) [02:27:26] (03CR) 10Werdna: "PS5 is a rebase onto master." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141050 (owner: 10Jdlrobson) [02:27:41] (03CR) 10Werdna: "… and by master I mean frontend-rewrite" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141050 (owner: 10Jdlrobson) [02:34:37] (03PS6) 10Werdna: Fixes to topic editing [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140872 (owner: 10Mattflaschen) [02:35:31] (03CR) 10Werdna: [C: 031] "PS6 is just a rebase. Looks good to me, though I saw the comments above about merge conflicts with another change." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140872 (owner: 10Mattflaschen) [02:37:08] (03PS1) 10Legoktm: SpecialCite: fix escaping of message [extensions/Cite] - 10https://gerrit.wikimedia.org/r/141372 [02:37:10] (03PS7) 10Werdna: Fixes to topic editing [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140872 (owner: 10Mattflaschen) [02:37:40] (03CR) 10Werdna: "PS7: Line breaking in commit message." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140872 (owner: 10Mattflaschen) [02:43:42] Hi all, anybody know how to get VisualEditor to work? [02:44:09] (03CR) 10Werdna: "Looks good except for what you mention in terms of scrolling 50% of the way." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141083 (owner: 10SG) [02:46:17] (03CR) 10TTO: "Yeah, it's bugged. Sorry about that." [core] - 10https://gerrit.wikimedia.org/r/87649 (https://bugzilla.wikimedia.org/5645) (owner: 10TTO) [02:46:40] (03PS2) 10Werdna: QA: Add browser tests for close and reopen behaviour [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141073 (owner: 10Jdlrobson) [02:46:44] (03CR) 10jenkins-bot: [V: 04-1] QA: Add browser tests for close and reopen behaviour [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141073 (owner: 10Jdlrobson) [02:47:00] (03CR) 10Werdna: "PS2 is a rebase." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141073 (owner: 10Jdlrobson) [02:49:37] (03CR) 10Werdna: [C: 031] "LGTM" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141107 (owner: 10Mattflaschen) [02:50:58] 3MediaWiki extensions / 3AbuseFilter: Add ability to detect deleted revisions and page creation - 10https://bugzilla.wikimedia.org/20892#c10 (10Huji) I believe the lack of index is a separate bug. Since we already have a functionality in MediaWiki itself that is using a non-indexed column to show a message t... [02:51:14] 3MediaWiki extensions / 3AbuseFilter: Add ability to detect deleted revisions and page creation - 10https://bugzilla.wikimedia.org/20892 (10Huji) [02:51:16] 3MediaWiki extensions / 3WikidataRepo: Wikibase Repository : broken links on Special:DispatchStats - 10https://bugzilla.wikimedia.org/66959 (10Ltrlg) 3UNCO p:3Unprio s:3normal a:3Wikidata bugs I read [[d:Special:DispatchStats]] today and clicked on the two links (“Change log statistics” and “Dispatch... [02:53:12] (03PS1) 10MarkAHershberger: Use correct condition for MWHttpRequest::proxySetup() function [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/141374 (https://bugzilla.wikimedia.org/66757) [02:53:49] (03PS1) 10MarkAHershberger: Use correct condition for MWHttpRequest::proxySetup() function [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/141375 (https://bugzilla.wikimedia.org/66757) [02:54:18] (03PS1) 10MarkAHershberger: Use correct condition for MWHttpRequest::proxySetup() function [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/141376 (https://bugzilla.wikimedia.org/66757) [02:55:29] 3MediaWiki extensions / 3AbuseFilter: AbuseFilterParserTest failure under HHVM - 10https://bugzilla.wikimedia.org/66935#c1 (10Ori Livneh) Minimal case: $ hhvm --php -r "var_dump(fnmatch('foob?r', 'foobér'));" bool(false) $ php5 -r "var_dump(fnmatch('foob?r', 'foobér'));" bool(true) [02:55:56] (03CR) 10Hoo man: [C: 032] SpecialCite: fix escaping of message [extensions/Cite] - 10https://gerrit.wikimedia.org/r/141372 (owner: 10Legoktm) [02:57:02] (03Merged) 10jenkins-bot: SpecialCite: fix escaping of message [extensions/Cite] - 10https://gerrit.wikimedia.org/r/141372 (owner: 10Legoktm) [02:57:29] 3MediaWiki / 3Logging: Logging needs a log_title index - 10https://bugzilla.wikimedia.org/66961#c1 (10Marius Hoch) What's actually needed over here is (log_namespace, log_title, log_type), see query at the bottom of https://gerrit.wikimedia.org/r/#/c/139103/3/AbuseFilterVariableHolder.php Not sure we really... [03:02:44] 3MediaWiki / 3Logging: Logging needs a log_title index - 10https://bugzilla.wikimedia.org/66961 (10Huji) p:5Unprio>3Normal [03:06:44] 3MediaWiki / 3JobQueue: JobQueueRedis locking up and throwing errors and exceptions - 10https://bugzilla.wikimedia.org/66953#c2 (10Jamie Thingelstad) Also, the extensions in use are listed at https://wikiapiary.com/wiki/Special:Version [03:14:01] 3MediaWiki extensions / 3WikidataRepo: {{PLURAL}} is not parsed in error messages - 10https://bugzilla.wikimedia.org/66963 (10Helder) 3NEW p:3Unprio s:3normal a:3Wikidata bugs When I tried to make this edit https://www.wikidata.org/w/index.php?diff=next&oldid=137919402 with a longer description I got... [03:20:29] 3Wikimedia / 3Site requests: GWtoolset additional domain: memory.loc.gov - 10https://bugzilla.wikimedia.org/66945#c2 (10Tomasz W. Kozlowski) Scheduled for deployment during the tomorrow morning's SWAT window. [03:22:29] 3MediaWiki / 3Recent changes: Use full label text for toggles on recent changes - 10https://bugzilla.wikimedia.org/5827#c4 (10lilhomiefool) Delete everything done on this site [03:22:29] 3MediaWiki extensions / 3DumpHTML: md5 title munging does not completely rename some pages - 10https://bugzilla.wikimedia.org/48281#c1 (10lilhomiefool) Fix please [03:22:46] 3MediaWiki extensions / 3CentralAuth: I can't log in on some WIkiMedia-websites - 10https://bugzilla.wikimedia.org/66964 (10gladjonatan) 3UNCO p:3Unprio s:3normal a:3None I am currently logged in on Wikipedia and Wikidata, but I can't log in on Meta or Commons. When I press log in-link at the top rig... [03:25:15] 3MediaWiki extensions / 3CentralAuth: I can't log in on some WIkiMedia-websites - 10https://bugzilla.wikimedia.org/66964#c1 (10gladjonatan) Created attachment 15698 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15698&action=edit Screenshot (in film-format) [03:26:45] 3MediaWiki extensions / 3CentralAuth: I can't log in on some WIkiMedia-websites - 10https://bugzilla.wikimedia.org/66964#c2 (10gladjonatan) If I enter "modile mode" of the webpage, I can log in. But then if I go to the "normal mode" of e.g. Meta, I am still not logged in. [03:28:28] 3MediaWiki / 3Logging: Logging needs a log_title index - 10https://bugzilla.wikimedia.org/66961 (10Huji) [03:28:31] 3MediaWiki / 3Logging: Logging needs a log_title index - 10https://bugzilla.wikimedia.org/66961 (10Huji) 3NEW p:3Unprio s:3normal a:3None When trying to create a page that has been previously deleted, a message is shown to the user to remind that it was deleted before. That information is retrieved f... [03:28:31] 3Wikimedia / 3Site requests: Require MediaWiki:Licenses to enable uploads - 10https://bugzilla.wikimedia.org/66960 (10Robin Pepermans (SPQRobin)) 3NEW p:3Unprio s:3normal a:3None On Wikimedia wikis, local uploading should be disabled if there are no licenses set on MediaWiki:Licenses. The need for t... [03:30:15] 3MediaWiki / 3Skin and page rendering: Come up with a sane way of including screenshots with skins and displaying them in the UI - 10https://bugzilla.wikimedia.org/66295#c3 (10Isarra) We wouldn't want it to get too complicated, both on the admin and on the user end, but I dunno. If nothing else, having a sm... [03:34:31] (03CR) 10Luis Felipe Schenone: (bug 26022) Improved the watchlist UI (031 comment) [core] - 10https://gerrit.wikimedia.org/r/38743 (owner: 10Luis Felipe Schenone) [03:35:21] (03PS1) 10Gnosygnu: v1.6.4.1 [xowa] - 10https://gerrit.wikimedia.org/r/141377 [03:36:31] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/141377 (owner: 10Gnosygnu) [03:43:29] 3MediaWiki extensions / 3Math: should be in texvc HTML output - 10https://bugzilla.wikimedia.org/10434#c7 (10Tim Landscheidt) I was referring to http://git.wikimedia.org/commit/mediawiki%2Fextensions%2FMath.git/09679f2f39e6c6c00e87757292421b26bfa7022a; with that commit, the support for HTML in Exte... [03:44:01] 3MediaWiki extensions / 3BookManagerv2: Same readability options on all chapters of the book - 10https://bugzilla.wikimedia.org/66957 (10Deepali Jain) 3NEW p:3Unprio s:3normal a:3None Right now the readability options are applied through javascript and the users settings are lost on page refresh. The... [03:44:11] (03PS5) 10Prtksxna: Create render.reference [extensions/Popups] - 10https://gerrit.wikimedia.org/r/139827 [03:45:52] (03CR) 10Prtksxna: "Added documentation strings" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/139827 (owner: 10Prtksxna) [03:48:47] (03PS4) 10Luis Felipe Schenone: Add "(page does not exist)" to non-existent talk pages' tooltip [core] - 10https://gerrit.wikimedia.org/r/63387 (https://bugzilla.wikimedia.org/17099) [03:50:20] (03CR) 10jenkins-bot: [V: 04-1] Add "(page does not exist)" to non-existent talk pages' tooltip [core] - 10https://gerrit.wikimedia.org/r/63387 (https://bugzilla.wikimedia.org/17099) (owner: 10Luis Felipe Schenone) [03:51:14] 3MediaWiki extensions / 3WikiEditor: in the Insert link dialog, "Cancel" is on the left - 10https://bugzilla.wikimedia.org/28716 (10Amir E. Aharoni) 5NEW>3RESO/FIX [03:52:07] (03CR) 10Luis Felipe Schenone: "I've fixed the camelCase issue but I have no idea how to rebase the changes" [core] - 10https://gerrit.wikimedia.org/r/63387 (https://bugzilla.wikimedia.org/17099) (owner: 10Luis Felipe Schenone) [03:58:58] 3MediaWiki / 3Skin and page rendering: Come up with a sane way of including screenshots with skins and displaying them in the UI - 10https://bugzilla.wikimedia.org/66295#c2 (10Jon) I actually agree with Isarra somewhat - a preview is better than a screenshot. That said the current experience is terrible. Pre... [03:59:13] 3MediaWiki / 3API: User contributions feed should match index.php feed format (diff etc.) - 10https://bugzilla.wikimedia.org/41085#c10 (10Luis Villa (WMF Legal)) Probably 10268 is a duplicate of this one, or vice-versa. [04:01:59] 3MediaWiki extensions / 3AbuseFilter: Add ability to detect deleted revisions and page creation - 10https://bugzilla.wikimedia.org/20892#c9 (10Jesús Martínez Novo (Ciencia Al Poder)) Gerrit change 139103 has CR -2 now because there's no index to quickly get the number of times it has been deleted. I was goi... [04:02:30] (03CR) 10Legoktm: [C: 032] (bug 66960) Require MediaWiki:Licenses to enable uploads (WMF) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/136520 (owner: 10SPQRobin) [04:02:36] (03Merged) 10jenkins-bot: (bug 66960) Require MediaWiki:Licenses to enable uploads (WMF) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/136520 (owner: 10SPQRobin) [04:10:44] 3MediaWiki extensions / 3AbuseFilter: AbuseFilterParserTest failure under HHVM - 10https://bugzilla.wikimedia.org/66935 (10Ori Livneh) [04:13:04] (03PS8) 10Prtksxna: Add settings [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140086 [04:19:00] (03CR) 10Prtksxna: "Added documentation strings." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140086 (owner: 10Prtksxna) [04:20:01] 3MediaWiki / 3User preferences: Have watchlist email setting in "Notifications" tab in Special:Preferences - 10https://bugzilla.wikimedia.org/66965 (10James Hare) 3NEW p:3Unprio s:3trivia a:3None There are two different places within Special:Preferences where you can configure email settings: * "Use... [04:48:14] 3MediaWiki / 3API: User contributions feed should match index.php feed format (diff etc.) - 10https://bugzilla.wikimedia.org/41085#c9 (10Robin Pepermans (SPQRobin)) This bug is equivalent to bug 10268 (concerning the watchlist feed). These two bugs should probably be fixed in the same way. [04:51:59] 3MediaWiki extensions / 3WikidataRepo: Wikibase Repository : broken links on Special:DispatchStats - 10https://bugzilla.wikimedia.org/66959 (10Ltrlg) s:5normal>3minor [04:56:39] (03PS1) 10AndyRussG: Fix validation bug and replace cookie w/ field [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/141378 [04:56:48] (03CR) 10jenkins-bot: [V: 04-1] Fix validation bug and replace cookie w/ field [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/141378 (owner: 10AndyRussG) [04:59:13] 3MediaWiki extensions / 3WikidataRepo: Wikibase Repository : broken links on Special:DispatchStats - 10https://bugzilla.wikimedia.org/66959 (10Kunal Mehta (Legoktm)) 5UNCO>3NEW [05:03:38] (03PS2) 10AndyRussG: Fix validation bug and replace cookie w/ field [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/141378 [05:05:59] 3Analytics / 3Wikimetrics: Make wikimetrics use standard Redis configuration again - 10https://bugzilla.wikimedia.org/66911#c3 (10Dan Andreescu) I disagree, the custom configuration for redis solves other persistence issues. The settings in our custom configuration ensure that Wikimetrics saves more often,... [05:08:22] (03CR) 10AndyRussG: "I wouldn't be sad if anyone were to comment on possible caching issues." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/141378 (owner: 10AndyRussG) [05:21:11] (03CR) 10devunt: Moved Article::render() to RenderAction::show() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/141359 (owner: 10Withoutaname) [05:22:43] (03CR) 10devunt: [C: 031] Use correct condition for MWHttpRequest::proxySetup() function [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/141374 (https://bugzilla.wikimedia.org/66757) (owner: 10MarkAHershberger) [05:22:45] (03CR) 10devunt: [C: 031] Use correct condition for MWHttpRequest::proxySetup() function [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/141375 (https://bugzilla.wikimedia.org/66757) (owner: 10MarkAHershberger) [05:22:47] (03CR) 10devunt: [C: 031] Use correct condition for MWHttpRequest::proxySetup() function [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/141376 (https://bugzilla.wikimedia.org/66757) (owner: 10MarkAHershberger) [05:26:16] (03CR) 10Florianschmidtwelzow: [C: 031] "A very uglier workaround can be to use wfSuppressWarnings() when generate LocalSettings.php :/" [core] - 10https://gerrit.wikimedia.org/r/141261 (https://bugzilla.wikimedia.org/66922) (owner: 10MarkAHershberger) [05:27:26] (03CR) 10devunt: [C: 031] "LGTM, but what is the proposal of this change?" [core] - 10https://gerrit.wikimedia.org/r/136161 (owner: 10Umherirrender) [05:34:01] 3MediaWiki / 3Skin and page rendering: Table that contains Table of Contents does not have class or ID - 10https://bugzilla.wikimedia.org/66966 (10James Hare) 3NEW p:3Unprio s:3enhanc a:3None On a rendered MediaWiki page, the div containing the Table of Contents is defined id="toc" class="toc". Howev... [05:37:14] 3MediaWiki / 3API: Watchlist RSS feed should include diffs - 10https://bugzilla.wikimedia.org/10268#c24 (10Robin Pepermans (SPQRobin)) This bug is equivalent to bug 41085 (concerning the contributions feed). These two bugs should probably be fixed in the same way. [05:37:29] 3MediaWiki extensions / 3Extensions requests: Add magic word to generate combined-TOC from a set of pages - 10https://bugzilla.wikimedia.org/13090#c2 (10Andre Klapper) p:5Low>3Lowest This sounds a bit like overkill for core, indeed. Moving to "extension requests". [05:40:44] 3MediaWiki / 3Skin and page rendering: Table that contains Table of Contents does not have class or ID - 10https://bugzilla.wikimedia.org/66966#c1 (10MZMcBride) I looked at the page source of and I'm not sure what table element you're referring to. Can you... [05:45:16] 3MediaWiki extensions / 3ContentTranslation: Special:ContentTranslation inserts source links as target - 10https://bugzilla.wikimedia.org/66967 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None If a target link doesn't exist, the source link may be inserted incorrectly. This can be fixed by remov... [05:46:44] 3MediaWiki / 3Skin and page rendering: Table that contains Table of Contents does not have class or ID - 10https://bugzilla.wikimedia.org/66966#c2 (10James Hare) 5NEW>3RESO/FIX Upon further investigation it's not a problem with MediaWiki as a piece of software. Problem solved! [05:48:29] 3MediaWiki / 3Skin and page rendering: Table that contains Table of Contents does not have class or ID - 10https://bugzilla.wikimedia.org/66966 (10Kunal Mehta (Legoktm)) 5RESO/FIX>3RESO/INV [05:48:51] (03CR) 10Legoktm: [C: 04-1] Improve validation and target construction (032 comments) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/141283 (owner: 10Wctaiwan) [05:49:48] (03CR) 10Legoktm: Various fixes and improvements (031 comment) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/140691 (owner: 10Wctaiwan) [05:56:29] 3MediaWiki / 3Installer: Installer can put html errors at the top of LocalSettings.phj - 10https://bugzilla.wikimedia.org/66922 (10Mark A. Hershberger) [05:58:01] 3MediaWiki extensions / 3ContentTranslation: selecting text in the Special:ContentTranslation source or translation columns must copy the text also to the search box - 10https://bugzilla.wikimedia.org/66968 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Selecting text in the Special:ContentTran... [05:58:13] 3MediaWiki / 3Installer: Installer can put html errors at the top of LocalSettings.php - 10https://bugzilla.wikimedia.org/66922 (10Kunal Mehta (Legoktm)) [06:02:59] 3MediaWiki / 3Page editing: Warn on edit summaries containing redlinks - 10https://bugzilla.wikimedia.org/13108#c1 (10Andre Klapper) (In reply to Paolo Liberatore from comment #0) > In some cases, one may want to enter an edit summary with a redlink Is this basically a request for "templates and links in su... [06:11:56] (03PS5) 10Legoktm: Extend Article instead of using a hook, and other refactoring [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/141071 [06:12:23] (03CR) 10Legoktm: "This is ready for review now." [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/141071 (owner: 10Legoktm) [06:13:58] (03PS6) 10Legoktm: Extend Article instead of using a hook, and other refactoring [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/141071 [06:23:00] 3MediaWiki / 3Installer: Installer can put html errors at the top of LocalSettings.phj - 10https://bugzilla.wikimedia.org/66922 (10Jesús Martínez Novo (Ciencia Al Poder)) a:3Mark A. Hershberger [06:46:29] 3MediaWiki / 3API: Watchlist RSS feed should include diffs - 10https://bugzilla.wikimedia.org/10268 (10Robin Pepermans (SPQRobin)) [06:48:19] (03CR) 10Krinkle: "Could you add tests and/or use it somewhere in mediawiki-core? The body of this function looks like something that would be commonly repea" [core] - 10https://gerrit.wikimedia.org/r/139894 (owner: 10UltrasonicNXT) [06:48:52] (03CR) 10Krinkle: [C: 032] Add jshintrc and make it pass [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/137894 (owner: 10Hashar) [06:48:57] (03Merged) 10jenkins-bot: Add jshintrc and make it pass [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/137894 (owner: 10Hashar) [06:49:55] (03PS4) 10Rillke: Allow third party code to hook-up MIME type detection [core] - 10https://gerrit.wikimedia.org/r/141240 [06:50:34] (03CR) 10Rillke: Allow third party code to hook-up MIME type detection (034 comments) [core] - 10https://gerrit.wikimedia.org/r/141240 (owner: 10Rillke) [06:52:46] (03PS4) 10Krinkle: Version 2.2: RequestContext love, spacing tweaks + position => top for CSS RL modules. [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/137170 (owner: 10Jack Phoenix) [06:53:17] (03CR) 10Krinkle: "Rebased to resolve conflict with I5cbd4a2b1b." [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/137170 (owner: 10Jack Phoenix) [06:53:53] (03PS13) 10Krinkle: Update Moment.js from 2.6.0 to 2.7.0 [core] - 10https://gerrit.wikimedia.org/r/139698 (owner: 10Paladox) [06:59:13] (03PS14) 10Krinkle: Update Moment.js from 2.6.0 to 2.7.0 [core] - 10https://gerrit.wikimedia.org/r/139698 (owner: 10Paladox) [07:07:38] (03PS2) 10Awight: WIP Add a new hook, EditPage::postAttemptSave [core] - 10https://gerrit.wikimedia.org/r/141114 [07:09:32] (03CR) 10Krinkle: Update Moment.js from 2.6.0 to 2.7.0 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/139698 (owner: 10Paladox) [07:10:16] 3MediaWiki extensions / 3CirrusSearch: intitle search doesn't work - 10https://bugzilla.wikimedia.org/66969 (10bennylin) 3NEW p:3Unprio s:3normal a:3None I tried to search articles with "intitle:dari Spanyol" (from Spain) in the title, but it gave 0 result, the same if I search "intitle:dari" (from),... [07:16:56] (03CR) 10Krinkle: "Css rule '.ve-ce-mwHieroNode .mw-hiero-outer' was removed. I guess that rule is obsolete (since diplay:inline-block; is the default style " [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/138911 (owner: 10Esanders) [07:19:44] (03CR) 10Legoktm: Allow third party code to hook-up MIME type detection (031 comment) [core] - 10https://gerrit.wikimedia.org/r/141240 (owner: 10Rillke) [07:23:24] (03PS2) 10Awight: split up internalAttemptSave [core] - 10https://gerrit.wikimedia.org/r/141113 [07:24:03] (03PS4) 10Wctaiwan: Improve validation and target construction [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/141283 [07:24:53] (03CR) 10jenkins-bot: [V: 04-1] split up internalAttemptSave [core] - 10https://gerrit.wikimedia.org/r/141113 (owner: 10Awight) [07:27:31] (03PS7) 10Krinkle: Bring in VisualEditor support from VE extension [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/138911 (owner: 10Esanders) [07:27:55] (03CR) 10Krinkle: "Added license file and copy of AUTHORS (reduced to git-log of the relevant files)." [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/138911 (owner: 10Esanders) [07:28:06] (03CR) 10Krinkle: [C: 031] Bring in VisualEditor support from VE extension [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/138911 (owner: 10Esanders) [07:29:06] (03CR) 10Krinkle: "Will +2 if Ed +1's or someone can else +2." [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/138911 (owner: 10Esanders) [07:30:50] (03PS3) 10Awight: split up internalAttemptSave [core] - 10https://gerrit.wikimedia.org/r/141113 [07:34:14] (03CR) 10Legoktm: [C: 031] Improve validation and target construction (031 comment) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/141283 (owner: 10Wctaiwan) [07:34:48] (03CR) 10jenkins-bot: [V: 04-1] split up internalAttemptSave [core] - 10https://gerrit.wikimedia.org/r/141113 (owner: 10Awight) [07:37:53] (03PS4) 10Awight: split up internalAttemptSave [core] - 10https://gerrit.wikimedia.org/r/141113 [07:58:12] (03PS5) 10Wctaiwan: Improve validation and target construction [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/141283 [07:58:20] (03CR) 10Paladox: [C: 031] "Oh ok." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/141296 (https://bugzilla.wikimedia.org/24713) (owner: 10TheDJ) [07:59:50] (03CR) 10Legoktm: [C: 032] Improve validation and target construction [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/141283 (owner: 10Wctaiwan) [07:59:59] (03Merged) 10jenkins-bot: Improve validation and target construction [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/141283 (owner: 10Wctaiwan) [08:03:31] 3MediaWiki extensions / 3CodeEditor: Fix mobile support - 10https://bugzilla.wikimedia.org/66970 (10paladox2015) 3UNCO p:3Unprio s:3normal a:3None Hi please could someone fix code editor to work properly on a mobile platform e.g iPad. Steps to reproduce 1. Go to en.wikipedia.org 2. Go to a modul... [08:18:32] (03PS19) 10Rillke: Adding a JS Class to inputBox to grey out Submit button. [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 (https://bugzilla.wikimedia.org/61606) (owner: 1001tonythomas) [08:27:28] (03CR) 10Rillke: "> Possibly has something to do with state in the debounce" [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/120487 (https://bugzilla.wikimedia.org/61606) (owner: 1001tonythomas) [08:31:14] 3Analytics / 3Wikimetrics: Make wikimetrics use standard Redis configuration again - 10https://bugzilla.wikimedia.org/66911#c4 (10nuria) I think that having our own config is useful too. On the CR I was just making the point that TTLs for persistence of celery reports in redis are actually handled via celery... [08:40:31] (03PS2) 10Krinkle: Use new OutputPageScriptsForBottomQueue hook [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/141284 (https://bugzilla.wikimedia.org/62602) (owner: 10Legoktm) [08:52:13] (03CR) 10Krinkle: [C: 04-1] "Most of the relevant logic is already taken care of by makeResourceLoaderLink. Contarty to the method name and most common outcome, makeRe" [core] - 10https://gerrit.wikimedia.org/r/141282 (https://bugzilla.wikimedia.org/62602) (owner: 10Legoktm) [08:59:29] 3Analytics / 3Wikimetrics: Make wikimetrics use standard Redis configuration again - 10https://bugzilla.wikimedia.org/66911#c5 (10christian) (In reply to Dan Andreescu from comment #3) > the custom configuration for redis solves other persistence > issues. Yup. That's why I explicitly called them out on cha... [09:00:40] (03PS5) 10Rillke: Allow third party code to hook-up MIME type detection [core] - 10https://gerrit.wikimedia.org/r/141240 [09:00:44] 3MediaWiki extensions / 3ContentTranslation: template in the beginning of Bratislava in English is not loaded correctly in Special:ContentTranslation - 10https://bugzilla.wikimedia.org/66659#c1 (10Santhosh Thottingal) There is an error in parsing for segmentation. "error": "Error: Block tag inside i... [09:00:59] 3MediaWiki extensions / 3VectorBeta: CPB: Flyout items after the first few items are not accessible in Opera 12 - 10https://bugzilla.wikimedia.org/65376#c1 (10Thiemo Mättig) 5NEW>3RESO/FIX https://gerrit.wikimedia.org/r/#/c/133628/ got merged. [09:01:31] (03CR) 10Rillke: Allow third party code to hook-up MIME type detection (031 comment) [core] - 10https://gerrit.wikimedia.org/r/141240 (owner: 10Rillke) [09:08:50] (03CR) 10Thiemo Mättig (WMDE): "Thanks. This fixes bug 65376 (https://bugzilla.wikimedia.org/show_bug.cgi?id=65376)." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/133628 (owner: 10Thiemo Mättig (WMDE)) [09:10:00] (03CR) 10Krinkle: "Be sure to verify that the output is as it should be per comment at https://bugzilla.wikimedia.org/show_bug.cgi?id=62602#c16 (e.g. group '" [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/141284 (https://bugzilla.wikimedia.org/62602) (owner: 10Legoktm) [09:14:43] 3MediaWiki extensions / 3CodeEditor: Code Editor not being recognised as input field on iPad Safari (need upstream iOS support) - 10https://bugzilla.wikimedia.org/55345#c2 (10Derk-Jan Hartman) *** Bug 66970 has been marked as a duplicate of this bug. *** [09:14:44] 3MediaWiki extensions / 3CodeEditor: Fix mobile support - 10https://bugzilla.wikimedia.org/66970#c1 (10Derk-Jan Hartman) 5UNCO>3RESO/DUP *** This bug has been marked as a duplicate of bug 55345 *** [09:35:08] (03PS1) 10TheDJ: Disable CodeEditor on mobile [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/141385 [09:59:03] (03CR) 10TheDJ: "I think there is a problem with this change as visible on beta labs." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/141372 (owner: 10Legoktm) [10:10:46] 3MediaWiki extensions / 3WikidataRepo: Don't treat referenced entities that are redirects as deleted in the UI - 10https://bugzilla.wikimedia.org/66971 (10Daniel Kinzler) 3NEW p:3Unprio s:3normal a:3Wikidata bugs The UI should not treat referenced entities as deleted when they are in fact redirects.... [10:10:58] 3MediaWiki extensions / 3WikidataRepo: Don't treat referenced entities that are redirects as deleted in the UI - 10https://bugzilla.wikimedia.org/66971 (10Daniel Kinzler) [10:11:14] 3MediaWiki extensions / 3WikidataRepo: Support Redirects between Items (tracking) - 10https://bugzilla.wikimedia.org/66067 (10Daniel Kinzler) [10:12:31] 3MediaWiki extensions / 3WikidataRepo: Allow redirects to be detected/resolved in bulk via the EntityInfoBuilder class - 10https://bugzilla.wikimedia.org/66972 (10Daniel Kinzler) 3NEW p:3Unprio s:3normal a:3Wikidata bugs In order to handle redirects correctly in the UI when they are mentioned/referen... [10:14:28] 3MediaWiki extensions / 3WikidataRepo: Allow redirects to be detected/resolved in bulk via the EntityInfoBuilder class - 10https://bugzilla.wikimedia.org/66972 (10Daniel Kinzler) [10:14:59] 3MediaWiki extensions / 3WikidataRepo: Add redirect column to wb_entity_per_page - 10https://bugzilla.wikimedia.org/66582 (10Daniel Kinzler) [10:14:59] 3MediaWiki extensions / 3WikidataRepo: Don't treat referenced entities that are redirects as deleted in the UI - 10https://bugzilla.wikimedia.org/66971 (10Daniel Kinzler) [10:16:16] 3MediaWiki extensions / 3Cite: Fatal error: Call to a member function escaped() on a non-object in SpecialCite.php on line 82 - 10https://bugzilla.wikimedia.org/66973 (10Aude) 3NEW p:3Unprio s:3normal a:3None [23-Jun-2014 10:14:15 UTC] PHP Fatal error: Call to a member function escaped() on a non-ob... [10:16:31] 3MediaWiki extensions / 3WikidataRepo: Track entity redirects in a database table (associated with the wb_entity_per_page table). - 10https://bugzilla.wikimedia.org/66582#c3 (10Daniel Kinzler) After some thought, it seems that it's more sensible to have redirect in a separate table, and remove them from wb_e... [10:17:04] omg beta [10:23:38] (03PS4) 10Phuedx: Configure logged in session length independantly [core] - 10https://gerrit.wikimedia.org/r/141248 (https://bugzilla.wikimedia.org/66699) [10:24:49] (03CR) 10jenkins-bot: [V: 04-1] Configure logged in session length independantly [core] - 10https://gerrit.wikimedia.org/r/141248 (https://bugzilla.wikimedia.org/66699) (owner: 10Phuedx) [10:36:43] (03PS1) 10Hoo man: Fix a fatal in SpecialCite [extensions/Cite] - 10https://gerrit.wikimedia.org/r/141389 [10:36:48] bah [10:36:55] * aude making patch [10:37:19] (03CR) 10Hoo man: "Follow-up in https://gerrit.wikimedia.org/r/141389" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/141372 (owner: 10Legoktm) [10:40:44] (03CR) 10Aude: [C: 032] Fix a fatal in SpecialCite (031 comment) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/141389 (owner: 10Hoo man) [10:40:51] (03Merged) 10jenkins-bot: Fix a fatal in SpecialCite [extensions/Cite] - 10https://gerrit.wikimedia.org/r/141389 (owner: 10Hoo man) [10:42:33] (03CR) 10Aude: "https://bugzilla.wikimedia.org/show_bug.cgi?id=66973" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/141389 (owner: 10Hoo man) [10:42:59] 3MediaWiki extensions / 3Cite: Fatal error: Call to a member function escaped() on a non-object in SpecialCite.php on line 82 - 10https://bugzilla.wikimedia.org/66973#c1 (10Aude) 5NEW>3RESO/FIX https://gerrit.wikimedia.org/r/#/c/141389/ [10:43:43] 3MediaWiki extensions / 3CentralAuth: I can't log in on some WIkiMedia-websites - 10https://bugzilla.wikimedia.org/66964#c3 (10Andre Klapper) Does this problem also happen with another browser? [10:45:27] (03PS5) 10Phuedx: Configure logged in session length independently [core] - 10https://gerrit.wikimedia.org/r/141248 (https://bugzilla.wikimedia.org/66699) [10:48:59] 3Wikimedia / 3Mailing lists: african-wikimedians - 10https://bugzilla.wikimedia.org/65959#c8 (10Tomasz W. Kozlowski) Bump bump. [10:50:30] 3MediaWiki extensions / 3Scribunto: Provide a standard way to get the target of a redirect page - 10https://bugzilla.wikimedia.org/66974 (10Helder) 3NEW p:3Unprio s:3normal a:3None A function like that would help users to get the content of the target page, and we would not need to parse the content... [10:51:43] 3MediaWiki / 3Installer: Installer can put html errors at the top of LocalSettings.php - 10https://bugzilla.wikimedia.org/66922 (10Andre Klapper) p:5Unprio>3Normal [10:57:29] 3Analytics / 3Wikimetrics: Story: New backup system - 10https://bugzilla.wikimedia.org/66119#c3 (10Dan Andreescu) 5PATC>3RESO/FIX tested by nuria in staging [11:10:27] (03CR) 10TTO: SpecialVersion: Show 'Skins' and 'Extensions' in separate sections (031 comment) [core] - 10https://gerrit.wikimedia.org/r/136615 (owner: 10Bartosz Dziewoński) [11:12:25] Hello all! Can someone help me :) I try to acticate Profiler (best to show in debugtoolbar, but i'm happy with logfile, too). I have set wgProfiler['class'] to "Profiler" and set the default from https://www.mediawiki.org/wiki/Manual:Profiling [11:12:30] but there are no profile data :/ [11:12:42] (03CR) 10Esanders: [C: 031] Bring in VisualEditor support from VE extension [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/138911 (owner: 10Esanders) [11:12:43] not in debugtoolbar, not in file and not in db (if i activate log to database) [11:13:02] Have i overlook some setting to activate profiler? [11:13:56] (03PS1) 10Phuedx: Use $wgLoginCookieExpiration when setting login cookies [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/141394 (https://bugzilla.wikimedia.org/66699) [11:14:43] (03PS3) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/140338 [11:16:54] (03CR) 10Smuggli: Implemented changes for translatewiki (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/139831 (owner: 10Smuggli) [11:26:09] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/140338 (owner: 10Smuggli) [11:28:14] 3Wikimedia / 3Site requests: Require MediaWiki:Licenses to enable uploads - 10https://bugzilla.wikimedia.org/66960 (10Steinsplitter) 5PATC>3RESO/FIX [11:32:52] (03PS1) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/141397 [11:37:37] (03CR) 10Daniel Kinzler: "Please explain the issue with this hook some more, it's not obvious from the code. The hook is supposed to manipulate the query string(s)," [core] - 10https://gerrit.wikimedia.org/r/141066 (owner: 10Chad) [11:44:35] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. I think there are issues in the strings. Please review inline comments." (033 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/141397 (owner: 10Smuggli) [11:48:42] (03CR) 10Krinkle: [C: 032] Bring in VisualEditor support from VE extension [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/138911 (owner: 10Esanders) [11:48:49] (03Merged) 10jenkins-bot: Bring in VisualEditor support from VE extension [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/138911 (owner: 10Esanders) [11:48:51] (03PS3) 10Krinkle: Remove display:inline-block highlight hacks [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/139821 (owner: 10Esanders) [11:49:13] (03PS4) 10Krinkle: Remove display:inline-block highlight hacks [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/139821 (owner: 10Esanders) [11:50:38] (03CR) 10Krinkle: [C: 032] "v was pulled into ve-mw with b7343b5e07c029cec8411a." [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/139821 (owner: 10Esanders) [11:50:43] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/141301 (https://bugzilla.wikimedia.org/65329) (owner: 10Deepali) [11:50:45] (03Merged) 10jenkins-bot: Remove display:inline-block highlight hacks [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/139821 (owner: 10Esanders) [11:53:16] 3Wikimedia / 3Bugzilla: Create X!'s tools as component in Tool Labs tools - 10https://bugzilla.wikimedia.org/66977 (10metatron) 3UNCO p:3Unprio s:3normal a:3None Please create new bugtracker for component X!'s tools under Tool Labs tools [12:03:07] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/141367 (https://bugzilla.wikimedia.org/28789) (owner: 10TheDJ) [12:03:16] 3Wikimedia / 3Bugzilla: Create X!'s tools as component in Tool Labs tools - 10https://bugzilla.wikimedia.org/66977#c1 (10Krinkle) 5UNCO>3ASSI p:5Unprio>3Normal a:3Krinkle Which address(es) should be the default assignee and/or default CC? Also can you provide a one sentence description with url fo... [12:04:24] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/139103 (https://bugzilla.wikimedia.org/20892) (owner: 10Huji) [12:05:32] (03CR) 10Siebrand: Add authorship info and tweaks to $wgExtensionCredits for core skins (031 comment) [core] - 10https://gerrit.wikimedia.org/r/141127 (owner: 10Bartosz Dziewoński) [12:05:44] 3Wikimedia / 3Bugzilla: Create X!'s tools as component in Tool Labs tools - 10https://bugzilla.wikimedia.org/66977#c2 (10Krinkle) 5ASSI>3RESO/FIX Created as: X!'s tools - description: Component for https://tools.wmflabs.org/xtools. - default assignee: nobo... [12:05:59] (03CR) 10Manybubbles: [C: 032] Handle MWContentSerializationException in forceSearchIndex [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/141273 (owner: 10Aude) [12:06:19] (03Merged) 10jenkins-bot: Handle MWContentSerializationException in forceSearchIndex [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/141273 (owner: 10Aude) [12:06:32] yay [12:07:12] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/125360 (owner: 10AndyRussG) [12:07:46] (03PS2) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/141397 [12:10:22] (03CR) 10Siebrand: [C: 032] "Well spotted." [core] - 10https://gerrit.wikimedia.org/r/139389 (owner: 10Umherirrender) [12:12:31] 3MediaWiki extensions / 3OAuth: OAuth: Dialog for granting an app permission should clarify or link to what "basic rights" are - 10https://bugzilla.wikimedia.org/66978 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None When an application requests the ability to edit on my behalf there is an unordered list... [12:14:01] (03CR) 10Manybubbles: SpecialSearch: Simplify result info (031 comment) [core] - 10https://gerrit.wikimedia.org/r/140952 (owner: 10Chad) [12:14:13] (03Merged) 10jenkins-bot: Use user name for $6 of message 'revision-info' [core] - 10https://gerrit.wikimedia.org/r/139389 (owner: 10Umherirrender) [12:17:46] 3Wikimedia / 3Bugzilla: Create X!'s tools as component in Tool Labs tools - 10https://bugzilla.wikimedia.org/66979 (10metatron) 3UNCO p:3Unprio s:3normal a:3None Please create new bugtracker for component X!'s tools under Tool Labs tools [12:32:15] 3MediaWiki extensions / 3CentralAuth: I can't log in on some WIkiMedia-websites - 10https://bugzilla.wikimedia.org/66964#c4 (10gladjonatan) No. I can log in on Chrome, but then if I switch back to Firefox, I am still not logged in on that browser. This only happens to websites that are ****.wikimedia.org --... [12:43:41] (03CR) 10Siebrand: [C: 031] "i18n reviewed. Trivial change." [core] - 10https://gerrit.wikimedia.org/r/140952 (owner: 10Chad) [12:44:36] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/141397 (owner: 10Smuggli) [12:47:46] 3MediaWiki / 3Special pages: [Regression] Accessing plain Special:FilePath should result in an error - 10https://bugzilla.wikimedia.org/66980 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None Special:FilePath has been replaced by Special:Redirect/file. However when requested without arguments it redirects... [12:47:59] 3MediaWiki / 3Special pages: [Regression] Accessing plain Special:FilePath should result in an error - 10https://bugzilla.wikimedia.org/66980 (10Krinkle) [12:55:59] 3MediaWiki / 3Logging: Logging needs a log_title index - 10https://bugzilla.wikimedia.org/66961#c2 (10Huji) To be politically correct: In EditPage.php at the very end of showIntro() function you will find a call to LogEventsList::showLogExtract() which is how the message on top of the page is created). LogE... [12:57:53] (03PS4) 10Huji: AbuseFilter: Add ability to detect deleted revisions [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/139103 (https://bugzilla.wikimedia.org/20892) [12:59:20] (03CR) 10Huji: AbuseFilter: Add ability to detect deleted revisions (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/139103 (https://bugzilla.wikimedia.org/20892) (owner: 10Huji) [13:04:02] (03PS1) 10Rillke: Typo in documentation: wgMaxShell not wgShellMax [core] - 10https://gerrit.wikimedia.org/r/141414 [13:04:51] (03CR) 10Siebrand: Add authorship info and tweaks to $wgExtensionCredits (031 comment) [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/141242 (owner: 10Bartosz Dziewoński) [13:05:38] (03CR) 10Rillke: "c.f. wfShellExec for example" [core] - 10https://gerrit.wikimedia.org/r/141414 (owner: 10Rillke) [13:09:09] (03CR) 10Siebrand: [C: 032] Style fixes [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/141262 (owner: 10Nikerabbit) [13:09:21] (03Merged) 10jenkins-bot: Style fixes [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/141262 (owner: 10Nikerabbit) [13:10:48] (03CR) 10Siebrand: [C: 032] Make the deprecation notice actually useful by listing the class [core] - 10https://gerrit.wikimedia.org/r/141123 (owner: 10Nikerabbit) [13:10:51] (03PS1) 10Anomie: ApiExpandTemplates: Start parse before creating frame [core] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/141416 (https://bugzilla.wikimedia.org/66798) [13:11:07] (03PS1) 10Anomie: ApiExpandTemplates: Start parse before creating frame [core] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/141417 (https://bugzilla.wikimedia.org/66798) [13:13:59] (03CR) 10Siebrand: [C: 032] Typo in documentation: wgMaxShell not wgShellMax [core] - 10https://gerrit.wikimedia.org/r/141414 (owner: 10Rillke) [13:15:02] (03Merged) 10jenkins-bot: Make the deprecation notice actually useful by listing the class [core] - 10https://gerrit.wikimedia.org/r/141123 (owner: 10Nikerabbit) [13:15:29] 3MediaWiki extensions / 3CentralAuth: I can't log in on some WIkiMedia-websites - 10https://bugzilla.wikimedia.org/66964#c5 (10Andre Klapper) Sounds like an issue with cookies to me then and something to fix in your Firefox browser... [13:15:44] 3MediaWiki / 3Special pages: [Regression] Accessing plain Special:FilePath should result in an error - 10https://bugzilla.wikimedia.org/66980 (10Andre Klapper) p:5Unprio>3Normal [13:15:46] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/139103 (https://bugzilla.wikimedia.org/20892) (owner: 10Huji) [13:16:14] 3MediaWiki / 3Logging: Logging needs a log_title index - 10https://bugzilla.wikimedia.org/66961 (10Andre Klapper) [13:16:59] 3Wikimedia / 3Bugzilla: Create X!'s tools as component in Tool Labs tools - 10https://bugzilla.wikimedia.org/66979#c1 (10Andre Klapper) 5UNCO>3RESO/DUP *** This bug has been marked as a duplicate of bug 66977 *** [13:16:59] 3Wikimedia / 3Bugzilla: Create X!'s tools as component in Tool Labs tools - 10https://bugzilla.wikimedia.org/66977#c3 (10Andre Klapper) *** Bug 66979 has been marked as a duplicate of this bug. *** [13:18:14] (03Merged) 10jenkins-bot: Typo in documentation: wgMaxShell not wgShellMax [core] - 10https://gerrit.wikimedia.org/r/141414 (owner: 10Rillke) [13:18:29] 3MediaWiki / 3JobQueue: JobQueueRedis locking up and throwing errors and exceptions - 10https://bugzilla.wikimedia.org/66953 (10Andre Klapper) p:5Unprio>3High s:5normal>3major [13:18:29] 3MediaWiki extensions / 3AbuseFilter: AbuseFilterParserTest failure under HHVM - 10https://bugzilla.wikimedia.org/66935 (10Andre Klapper) p:5Unprio>3Normal [13:18:59] 3MediaWiki / 3User preferences: Have watchlist email setting in "Notifications" tab in Special:Preferences - 10https://bugzilla.wikimedia.org/66965 (10Andre Klapper) p:5Unprio>3Low s:5trivia>3enhanc [13:19:14] 3MediaWiki extensions / 3Scribunto: Provide a standard way to get the target of a redirect page - 10https://bugzilla.wikimedia.org/66974 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [13:20:29] 3MediaWiki extensions / 3Translate: Trying to change group state, selector stuck in "Setting..." - 10https://bugzilla.wikimedia.org/62957 (10Nemo) 5PATC>3RESO/FIX [13:20:30] 3MediaWiki / 3API: Watchlist RSS feed should include diffs - 10https://bugzilla.wikimedia.org/10268 (10Andre Klapper) a:5Roan Kattouw>3None [13:25:29] 3MediaWiki extensions / 3General/Unknown: FastStringSearch on HHVM: Assertion `!MemoryManager::sweeping()' failed. - 10https://bugzilla.wikimedia.org/66941#c1 (10Andre Klapper) Hmm, is that actually an extension? Gerrit location is https://gerrit.wikimedia.org/r/mediawiki/php/FastStringSearch ... [13:25:44] 3MediaWiki extensions / 3Scribunto: HPHP::computeMaskFromNumElms(uint32_t): Assertion `n <= 0x7fffffffU' failed. - 10https://bugzilla.wikimedia.org/66943 (10Andre Klapper) [13:25:45] 3MediaWiki extensions / 3Scribunto: HHVM: Assertion `contains(pc)' failed. Aborted - 10https://bugzilla.wikimedia.org/66942 (10Andre Klapper) [13:27:44] 3MediaWiki / 3Maintenance scripts: generateSitemap.php gzopen() fatal error on Ubuntu 14.04 (replace gzopen() by gzopen64()) - 10https://bugzilla.wikimedia.org/66952 (10Andre Klapper) p:5Unprio>3High s:5normal>3major [13:28:14] 3MediaWiki / 3JavaScript: Class "sortable" does not work with "mw-collapsible mw-collapsed" in some tables. - 10https://bugzilla.wikimedia.org/66948 (10Andre Klapper) p:5Unprio>3Low [13:28:28] 3MediaWiki / 3JavaScript: tablesorter (tracking) - 10https://bugzilla.wikimedia.org/31601 (10Andre Klapper) [13:29:18] (03CR) 10Nemo bis: "Needs rebase" [extensions/SiteSettings] - 10https://gerrit.wikimedia.org/r/134294 (owner: 10Shirayuki) [13:31:59] 3MediaWiki / 3General/Unknown: "Error creating thumbnail: proc_open() is disabled"; did not seem to happen in previous versions. - 10https://bugzilla.wikimedia.org/66349#c4 (10Andre Klapper) 5RESO/INV>3RESO/DUP Sorry, was wrong here. See bug 66467 for the fix. *** This bug has been marked as a duplicate... [13:32:29] 3MediaWiki extensions / 3Spam Blacklist: Under HHVM: Fatal error: Argument 1 passed to AbstractContent::getParserOutput() must be an instance of Title, null given - 10https://bugzilla.wikimedia.org/66930 (10Andre Klapper) p:5Unprio>3High [13:33:08] (03PS1) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/141418 [13:33:50] (03Abandoned) 10Siebrand: i18n: Fix syntax error in qqq.json [extensions/SiteSettings] - 10https://gerrit.wikimedia.org/r/134294 (owner: 10Shirayuki) [13:35:14] 3MediaWiki / 3Skin and page rendering: The magic word "notitle" causes some errors in the main MediaWiki page as of wmf10 - 10https://bugzilla.wikimedia.org/66927#c1 (10Andre Klapper) p:5Unprio>3Normal Hmm, I don't see anything similar in my desktop browsers. How do you come to the conclusion that this... [13:39:08] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (0311 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/141418 (owner: 10Smuggli) [13:39:29] 3Analytics / 3Wikimetrics: Make wikimetrics use standard Redis configuration again - 10https://bugzilla.wikimedia.org/66911#c6 (10nuria) If that can be done that would be the best solution, christian. [13:41:05] (03PS2) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/141418 [13:41:43] 3MediaWiki / 3Special pages: Improve Special:Booksources to show bibliographic data and results - 10https://bugzilla.wikimedia.org/13195#c1 (10Andre Klapper) Still valid; tested on https://en.wikisource.org/w/index.php?title=Special%3ABookSources&isbn=9783442760121 [13:43:14] 3MediaWiki extensions / 3Spam Blacklist: Under HHVM: Fatal error: Argument 1 passed to AbstractContent::getParserOutput() must be an instance of Title, null given - 10https://bugzilla.wikimedia.org/66930#c1 (10Chad H.) I see two bugs here. One, we should figure out why we're passing null here and see if that... [13:44:41] (03CR) 10Manybubbles: [C: 032] Switch near match to use better hook [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/141065 (owner: 10Chad) [13:44:59] 3MediaWiki extensions / 3RSS: PHP Catchable fatal error: Argument 1 passed to ContentHandler::getContentText() must implement interface Content, boolean given ContentHandler line 95 - on certain extension(s) - 10https://bugzilla.wikimedia.org/43737 (10Brad Jorsch) 5PATC>3RESO/FIX [13:44:59] (03Merged) 10jenkins-bot: Switch near match to use better hook [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/141065 (owner: 10Chad) [13:45:00] 3MediaWiki extensions / 3CentralAuth: I can't log in on some WIkiMedia-websites - 10https://bugzilla.wikimedia.org/66964#c6 (10gladjonatan) I tried again. This time it said "Wikimedia Commons uses cookies to log in users. You have cookies disabled. Please enable them and try again." I have cookies enabled.... [13:46:48] (03CR) 10Siebrand: [C: 04-1] "See issues in PS1." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/141418 (owner: 10Smuggli) [13:47:14] 3MediaWiki extensions / 3Cite: Error using {{#tag:references|group=x}} : Invalid tag; no input is allowed. Use - 10https://bugzilla.wikimedia.org/15839 (10Andre Klapper) [13:47:58] 3MediaWiki extensions / 3Cite: Multiple problems with refs inside ... blocks - 10https://bugzilla.wikimedia.org/22635 (10Andre Klapper) [13:47:59] 3MediaWiki extensions / 3Cite: Nested refs fail inside references block - 10https://bugzilla.wikimedia.org/20707 (10Andre Klapper) [13:48:44] 3MediaWiki extensions / 3Cite: Error generation of unbalanced : No error is shown if missing -tag is the last ref tag - 10https://bugzilla.wikimedia.org/15712 (10Andre Klapper) [13:49:14] 3MediaWiki extensions / 3Cite: without - 10https://bugzilla.wikimedia.org/16854 (10Andre Klapper) [13:49:14] 3MediaWiki extensions / 3Cite: Cite Extension: missing ref name before triggers error messages - 10https://bugzilla.wikimedia.org/29774 (10Andre Klapper) [13:49:14] 3MediaWiki extensions / 3Cite: Cite: If there's no block on the page, show one automatically below the content rather than showing an error - 10https://bugzilla.wikimedia.org/66860 (10Andre Klapper) p:5Unprio>3Normal [13:49:28] 3Wikimedia / 3Site requests: Run updateArticleCount.php on German Wikivoyage weekly - 10https://bugzilla.wikimedia.org/66867 (10Andre Klapper) p:5Unprio>3Normal [13:50:44] 3MediaWiki / 3History/Diffs: Null edits are recorded in page history, sometimes with non-zero size change - 10https://bugzilla.wikimedia.org/66886 (10Andre Klapper) p:5Unprio>3Low [13:50:51] (03CR) 10Raimond Spekking: [C: 032 V: 032] Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/140338 (owner: 10Smuggli) [13:51:23] (03CR) 10Anomie: [C: 032] Expose $wgLocalInterwikis via the API [core] - 10https://gerrit.wikimedia.org/r/141276 (https://bugzilla.wikimedia.org/66709) (owner: 10TTO) [13:51:29] (03CR) 10Siebrand: [C: 04-1] "Needs a test." [core] - 10https://gerrit.wikimedia.org/r/141104 (https://bugzilla.wikimedia.org/57562) (owner: 10Withoutaname) [13:52:44] 3MediaWiki extensions / 3CentralAuth: I can't log in on some WIkiMedia-websites - 10https://bugzilla.wikimedia.org/66964#c7 (10gladjonatan) 5UNCO>3RESO/WOR I got it to work! I had to clear all(!) my cookies...didn't think of that! (Stupid me!) [13:53:22] (03CR) 10Cmcmahon: "Hashar: I intend for this repo to replace the repo we have at /qa/browsertests. I've been porting tests from there to here, while re-writ" [core] - 10https://gerrit.wikimedia.org/r/133507 (https://bugzilla.wikimedia.org/66272) (owner: 10Cmcmahon) [13:53:59] 3MediaWiki / 3Parser: let me size inline images to max-height, with variable image-sets including client-side reduction, fix the forced "quirk-mode" of mobile view - 10https://bugzilla.wikimedia.org/66896#c1 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc Hi, can you please provide * steps to repr... [13:54:14] (03CR) 10Anomie: [C: 032] ApiParse: Add disableeditsection parameter [core] - 10https://gerrit.wikimedia.org/r/141111 (https://bugzilla.wikimedia.org/62723) (owner: 10Legoktm) [13:55:03] (03Merged) 10jenkins-bot: Expose $wgLocalInterwikis via the API [core] - 10https://gerrit.wikimedia.org/r/141276 (https://bugzilla.wikimedia.org/66709) (owner: 10TTO) [13:55:44] 3MediaWiki extensions / 3Collection: Book creator (functions) aren't working anymore - 10https://bugzilla.wikimedia.org/66007#c3 (10dronten.koen) 5UNCO>3RESO/FIX Problem is solved [13:56:59] 3MediaWiki / 3User blocking: MediaWiki:Autoblocker etc. reveals to third party that a (blocked) user has used the same IP address - 10https://bugzilla.wikimedia.org/53008 (10Andre Klapper) [13:57:14] 3MediaWiki / 3User blocking: correlate autoblocks (currently admin cannot see IF in fact the IP is autoblocked) - 10https://bugzilla.wikimedia.org/13131 (10Andre Klapper) [13:57:25] (03Merged) 10jenkins-bot: ApiParse: Add disableeditsection parameter [core] - 10https://gerrit.wikimedia.org/r/141111 (https://bugzilla.wikimedia.org/62723) (owner: 10Legoktm) [13:57:43] 3MediaWiki / 3API: action=parse should allow hiding editsection links - 10https://bugzilla.wikimedia.org/62723#c3 (10Brad Jorsch) 5PATC>3RESO/FIX Merged. Should be deployed to WMF wikis with 1.24wmf11, see https://www.mediawiki.org/wiki/MediaWiki_1.24/Roadmap for the schedule. [13:59:36] (03PS1) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/141422 [14:07:36] (03CR) 10Anomie: [C: 031] "Seems ok. Not sure how these actually work to be able to test though." [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/94593 (https://bugzilla.wikimedia.org/56207) (owner: 10TTO) [14:12:14] 3MediaWiki extensions / 3Collection: Book creator (functions) aren't working anymore - 10https://bugzilla.wikimedia.org/66007 (10Andre Klapper) 5RESO/FIX>3RESO/WOR [14:17:10] (03CR) 10Anomie: [C: 04-1] Add additional interwiki links as requested in various bugs (032 comments) [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/141099 (https://bugzilla.wikimedia.org/43027) (owner: 10TTO) [14:21:12] (03CR) 10Anomie: "Code itself looks ok (haven't tested), although it needs unit tests." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/141052 (owner: 10Jackmcbarn) [14:22:14] (03CR) 10Jackmcbarn: "Unit tests coming shortly. The use is an equivalent of (actually, a more powerful version of) noinclude and includeonly." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/141052 (owner: 10Jackmcbarn) [14:25:00] 3MediaWiki extensions / 3CirrusSearch: intitle search doesn't work - 10https://bugzilla.wikimedia.org/66969#c1 (10Nik Everett) p:5Unprio>3High a:3Nik Everett Something is a certainly weird here. Temporary work around: https://id.wikipedia.org/w/index.php?title=Istimewa%3APencarian&profile=default&sear... [14:32:35] (03PS2) 10Jackmcbarn: Expose frame.depth [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/141052 [14:40:05] (03CR) 10Anomie: split up internalAttemptSave (031 comment) [core] - 10https://gerrit.wikimedia.org/r/141113 (owner: 10Awight) [14:43:02] (03PS1) 10Jforrester: Revert "Bring in VisualEditor support from VE extension" [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/141428 [14:43:03] (03CR) 10jenkins-bot: [V: 04-1] Revert "Bring in VisualEditor support from VE extension" [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/141428 (owner: 10Jforrester) [14:43:08] (03CR) 10Jforrester: [C: 032] Revert "Bring in VisualEditor support from VE extension" [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/141428 (owner: 10Jforrester) [14:43:10] (03CR) 10jenkins-bot: [V: 04-1] Revert "Bring in VisualEditor support from VE extension" [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/141428 (owner: 10Jforrester) [14:45:11] * James_F sighs. [14:48:15] (03CR) 10Anomie: "> The use is an equivalent of (actually, a more powerful version of) noinclude and includeonly." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/141052 (owner: 10Jackmcbarn) [14:50:17] (03PS2) 10Jforrester: Revert "Bring in VisualEditor support from VE extension" [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/141428 [14:51:10] (03CR) 10Jforrester: [C: 032] Revert "Bring in VisualEditor support from VE extension" [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/141428 (owner: 10Jforrester) [14:51:30] (03Merged) 10jenkins-bot: Revert "Bring in VisualEditor support from VE extension" [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/141428 (owner: 10Jforrester) [14:52:12] (03PS1) 10Jforrester: [WIP] Bring in VisualEditor support from VE extension as a Beta Feature [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/141429 [14:54:11] (03CR) 10Jackmcbarn: "> which is why frame:getParent() doesn't allow for getting the grandparent of the #invoke." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/141052 (owner: 10Jackmcbarn) [15:00:45] (03CR) 10Anomie: [C: 032] "SWAT deploy" [core] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/141417 (https://bugzilla.wikimedia.org/66798) (owner: 10Anomie) [15:01:34] (03PS6) 10Umherirrender: Change some message escaping [core] - 10https://gerrit.wikimedia.org/r/136161 [15:03:38] (03PS22) 10Cmcmahon: browser acceptance tests [core] - 10https://gerrit.wikimedia.org/r/133507 (https://bugzilla.wikimedia.org/66272) [15:04:03] (03Merged) 10jenkins-bot: ApiExpandTemplates: Start parse before creating frame [core] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/141417 (https://bugzilla.wikimedia.org/66798) (owner: 10Anomie) [15:04:30] (03CR) 10Cmcmahon: "I updated the environment variables examples to be" [core] - 10https://gerrit.wikimedia.org/r/133507 (https://bugzilla.wikimedia.org/66272) (owner: 10Cmcmahon) [15:04:41] (03CR) 10Umherirrender: "Nikerabbit said on I2a91f0ef1cf82360da2d17c7dc42633ae3e79100 that the escaping of a message was not useful, so I fixed that with change I9" [core] - 10https://gerrit.wikimedia.org/r/136161 (owner: 10Umherirrender) [15:04:59] (03CR) 10Anomie: [C: 032] "SWAT deploy" [core] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/141416 (https://bugzilla.wikimedia.org/66798) (owner: 10Anomie) [15:07:47] (03PS3) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/141418 [15:08:17] (03CR) 10Umherirrender: "Looks more releated to WikiPage, so I would move it." [core] - 10https://gerrit.wikimedia.org/r/141269 (owner: 10Withoutaname) [15:09:02] (03Merged) 10jenkins-bot: ApiExpandTemplates: Start parse before creating frame [core] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/141416 (https://bugzilla.wikimedia.org/66798) (owner: 10Anomie) [15:09:13] (03CR) 10DavisNT: "This patch embeds AddThis JavaScript via HTTPS on Wikis accessed via HTTPS." [extensions/AddThis] - 10https://gerrit.wikimedia.org/r/141266 (owner: 10DavisNT) [15:09:51] (03PS2) 10Jforrester: [WIP] Bring in VisualEditor support from VE extension as a Beta Feature [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/141429 [15:12:14] (03PS1) 10Matthias Mullie: Hygiene: Fix inconsistent return points [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141434 [15:12:17] (03PS1) 10Matthias Mullie: Hygiene: Add missing @return statement [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141435 [15:12:20] (03PS1) 10Matthias Mullie: Hygiene: Add missing $params to PHPDoc [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141436 [15:12:23] (03PS1) 10Matthias Mullie: Hygiene: Remove doubled case 'diff-post-summary' statement [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141437 [15:12:26] (03PS1) 10Matthias Mullie: Complete PHPDoc for TemplateHelper [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141438 [15:12:29] (03PS3) 10Zfilipin: Replace underscore by spaces in PLATFORM [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/140929 (owner: 10Hashar) [15:12:44] 3MediaWiki / 3API: Fatal error: Call to a member function getPrefixedText() on a non-object in LuaCommon.php on line 419 - 10https://bugzilla.wikimedia.org/66798 (10Brad Jorsch) 5PATC>3RESO/FIX [15:13:15] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove doubled case 'diff-post-summary' statement [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141437 (owner: 10Matthias Mullie) [15:14:06] (03PS1) 10Matthias Mullie: Convert UUIDs to alphanumeric representation [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141439 [15:15:29] 3Wikimedia / 3Site requests: GWtoolset additional domain: memory.loc.gov - 10https://bugzilla.wikimedia.org/66945#c4 (10Tomasz W. Kozlowski) 5PATC>3RESO/FIX Merged and deployed on the production cluster by Brad (thank you!). [15:15:29] 3Wikimedia / 3Site requests: Changing the technical rights on ruwiki - 10https://bugzilla.wikimedia.org/66871#c7 (10Tomasz W. Kozlowski) 5PATC>3RESO/FIX Merged and deployed on the production cluster by Brad (thank you!). [15:17:54] (03CR) 10Anomie: [C: 04-1] "Why not do it like action=help does?" [core] - 10https://gerrit.wikimedia.org/r/141110 (https://bugzilla.wikimedia.org/30936) (owner: 10Legoktm) [15:23:36] (03CR) 10Manybubbles: [C: 04-1] "Breaks advanced search - the link no longer causes all the check boxes to appear. Cirrus test failures:" [core] - 10https://gerrit.wikimedia.org/r/140952 (owner: 10Chad) [15:24:33] (03PS4) 10Zfilipin: Replace underscore by spaces in PLATFORM [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/140929 (owner: 10Hashar) [15:25:48] (03CR) 10Zfilipin: [C: 032] Replace underscore by spaces in PLATFORM [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/140929 (owner: 10Hashar) [15:26:26] (03Merged) 10jenkins-bot: Replace underscore by spaces in PLATFORM [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/140929 (owner: 10Hashar) [15:27:47] (03CR) 10Anomie: ApiParamInfo: Support any instance of ApiModuleManager (033 comments) [core] - 10https://gerrit.wikimedia.org/r/141110 (https://bugzilla.wikimedia.org/30936) (owner: 10Legoktm) [15:37:20] (03PS1) 10Zfilipin: Moved the last two MobileFrontend jobs from Cloudbees [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/141444 [15:40:39] (03CR) 10Chad: "Query string handling should be left up to SearchEngine subclasses, not delegated to an extension that can potentially do unpredictable th" [core] - 10https://gerrit.wikimedia.org/r/141066 (owner: 10Chad) [15:41:40] (03PS2) 10Zfilipin: Moved the last two MobileFrontend jobs from Cloudbees [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/141444 [15:42:23] (03CR) 10Chad: "Wonder how I missed that :\" [core] - 10https://gerrit.wikimedia.org/r/141067 (owner: 10Chad) [15:43:55] (03CR) 10Cmcmahon: [C: 032] Moved the last two MobileFrontend jobs from Cloudbees [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/141444 (owner: 10Zfilipin) [15:44:07] (03PS1) 10Mvolz: Copied and refractored Extension:BoilerPlate [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/141447 [15:44:30] (03Merged) 10jenkins-bot: Moved the last two MobileFrontend jobs from Cloudbees [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/141444 (owner: 10Zfilipin) [15:44:45] 3Analytics / 3EventLogging: EventLogging's country column are logging unwanted (sensitive) chunks of cookie - 10https://bugzilla.wikimedia.org/66478#c12 (10christian) Since last Wednesday, Ops (RT: 7708) are running the cleanup scripts. NavigationTiming_7494934 is cleaned up. Thanks Sean! For the other 5 t... [15:45:13] (03CR) 10Mvolz: [C: 032 V: 032] Copied and refractored Extension:BoilerPlate [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/141447 (owner: 10Mvolz) [15:47:24] (03CR) 10Chad: "Why do we even have a maintenance script for undeleting a single page?" [core] - 10https://gerrit.wikimedia.org/r/131431 (https://bugzilla.wikimedia.org/52887) (owner: 10Withoutaname) [15:48:44] (03PS5) 10Jackmcbarn: Expose cascading protection directly to Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/132730 [15:48:58] (03PS2) 10Chad: Remove SpecialSearchNoResults, call SpecialSearchResults unconditionally [core] - 10https://gerrit.wikimedia.org/r/141069 [15:49:00] (03PS3) 10Chad: Remove SearchEngineReplacePrefixesComplete hook [core] - 10https://gerrit.wikimedia.org/r/141066 [15:49:02] (03PS3) 10Chad: Remove SearchGetNearMatchBefore hook, unused [core] - 10https://gerrit.wikimedia.org/r/141067 [15:51:44] 3MediaWiki / 3Skin and page rendering: Display error when user tries to create a circular redirect (self-redirect) - 10https://bugzilla.wikimedia.org/27683#c10 (10MZMcBride) https://en.wikipedia.org/w/index.php?title=National_Labor_Relations_Board_v._Canning&oldid=614106762 I don't think catching self-redir... [15:51:56] (03PS3) 10Jackmcbarn: Use preview content when it transcludes itself [core] - 10https://gerrit.wikimedia.org/r/137153 (https://bugzilla.wikimedia.org/5278) [15:52:18] (03PS4) 10Jackmcbarn: Set TTLs on outputs containing times [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/136619 [15:52:48] (03PS5) 10Jackmcbarn: Add a tracking category for duplicate arguments [core] - 10https://gerrit.wikimedia.org/r/136123 [15:53:22] (03PS8) 10Chad: Pass a Title for context to Linker::makeExternalLink() [core] - 10https://gerrit.wikimedia.org/r/129853 [15:53:40] (03PS2) 10Jackmcbarn: Allow specifying a separator for CASCADINGSOURCES [core] - 10https://gerrit.wikimedia.org/r/135276 [15:55:34] (03PS7) 10Jackmcbarn: Add a Lua library to get stability settings [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/132956 [16:00:18] (03PS1) 10Zfilipin: Moved a couple of UploadWizard from Cloudbees [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/141449 [16:03:47] anomie: can you look at https://gerrit.wikimedia.org/r/#/c/132730/ when you have time? [16:05:29] 3MediaWiki / 3Email: Account creation by email often winds up marked as spam - 10https://bugzilla.wikimedia.org/62704 (10Andre Klapper) p:5Normal>3Low [16:05:44] 3MediaWiki / 3Installer: cli installer ignores lang parameter - 10https://bugzilla.wikimedia.org/61146 (10Andre Klapper) [16:05:59] 3MediaWiki / 3Maintenance scripts: Missing ; in importdump.php - 10https://bugzilla.wikimedia.org/60172 (10Andre Klapper) [16:06:46] (03PS1) 10Zfilipin: Using new Cucumber browser tags [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/141453 [16:06:54] (03CR) 10jenkins-bot: [V: 04-1] Using new Cucumber browser tags [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/141453 (owner: 10Zfilipin) [16:06:59] 3MediaWiki / 3User login and signup: pass user group changes to $wgAuth - 10https://bugzilla.wikimedia.org/49641 (10Andre Klapper) [16:06:59] 3MediaWiki / 3General/Unknown: Add support for Redis (instead of memcached) - 10https://bugzilla.wikimedia.org/52589 (10Andre Klapper) [16:07:15] 3MediaWiki / 3Internationalization: $namespaceAliases change Korean message - 10https://bugzilla.wikimedia.org/53617 (10Andre Klapper) [16:07:15] 3MediaWiki / 3General/Unknown: Sub Directory Reverse Proxy breaks links - 10https://bugzilla.wikimedia.org/52400 (10Andre Klapper) [16:07:15] 3MediaWiki / 3Database: PostgreSQL misuse of pg_get_result - 10https://bugzilla.wikimedia.org/50091 (10Andre Klapper) [16:07:15] 3MediaWiki / 3Documentation: Description of $join_conds in DatabaseBase::select() incomplete - 10https://bugzilla.wikimedia.org/56238 (10Andre Klapper) [16:07:16] 3MediaWiki / 3General/Unknown: make $wgUseInstantCommons protocol always secure / SSL / https - 10https://bugzilla.wikimedia.org/53131 (10Andre Klapper) [16:07:28] 3MediaWiki / 3Database: PDOException ('There is no active transaction') after upgrading SQLite database from 1.16.5 to 1.21.1 when user is set in wgDBuser - 10https://bugzilla.wikimedia.org/49254 (10Andre Klapper) [16:07:29] 3MediaWiki / 3Parser: Fatal error: Call to a member function Parse() on a non-object in ipbwiki_interface.php - 10https://bugzilla.wikimedia.org/53671 (10Andre Klapper) [16:07:43] 3MediaWiki / 3General/Unknown: MediaWiki tries to create a thumbnail multiple times although that is not needed - 10https://bugzilla.wikimedia.org/49528 (10Andre Klapper) [16:07:44] 3MediaWiki / 3Special pages: Special:ListUsers : Internal Error - 10https://bugzilla.wikimedia.org/54348 (10Andre Klapper) [16:07:44] 3MediaWiki / 3Installer: Install failures - Oracle - 10https://bugzilla.wikimedia.org/49821 (10Andre Klapper) [16:07:44] 3MediaWiki / 3Database: MySQL database updates do not enclose field names in back ticks(`) causing fields to be dropped with reserved words. - 10https://bugzilla.wikimedia.org/50114 (10Andre Klapper) [16:07:45] 3MediaWiki / 3General/Unknown: Display a Sitenotice and no Anonnotice - 10https://bugzilla.wikimedia.org/52308 (10Andre Klapper) [16:07:46] 3MediaWiki / 3General/Unknown: "Could not acquire 'messages:de-formal:status' lock" opening page with page name >256 chars; memcache too slow - 10https://bugzilla.wikimedia.org/52781 (10Andre Klapper) [16:07:47] 3MediaWiki / 3HTMLForm: cssclass option does not apply class to help text - 10https://bugzilla.wikimedia.org/65087 (10Andre Klapper) [16:07:48] 3MediaWiki / 3Installer: Installer doesn't offer Simple English even though simple is included in the tarball. - 10https://bugzilla.wikimedia.org/49395 (10Andre Klapper) [16:07:49] 3MediaWiki / 3General/Unknown: Closing commented text at the beginning of a line (due to ModSecurity configuration) - 10https://bugzilla.wikimedia.org/49273 (10Andre Klapper) [16:07:50] 3MediaWiki / 3Installer: Upgrading to 1.21, populateRevisionSha1.php fails to populate rev_sha1 fields - 10https://bugzilla.wikimedia.org/52613 (10Andre Klapper) [16:07:51] 3MediaWiki / 3General/Unknown: [37c82761] 2013-07-24 01:39:03: Fatal exception of type MWException - 10https://bugzilla.wikimedia.org/51920 (10Andre Klapper) [16:07:52] 3MediaWiki / 3JavaScript: Vector skin breaks JavaScript - 10https://bugzilla.wikimedia.org/49270 (10Andre Klapper) [16:07:58] (03CR) 10Andrew Bogott: [C: 032] Add some aliases to suppress a bunch of warnings. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/140832 (owner: 10Andrew Bogott) [16:07:59] 3MediaWiki / 3Skin and page rendering: Not possible to view gadget source? - 10https://bugzilla.wikimedia.org/52600 (10Andre Klapper) [16:07:59] 3MediaWiki / 3Installer: Letter ң in $wgMetaNamespace becomes ң - 10https://bugzilla.wikimedia.org/53294 (10Andre Klapper) [16:07:59] 3MediaWiki / 3Page editing: Mobile Beta edition: can not edit the 11th and after section in some articles - 10https://bugzilla.wikimedia.org/50017 (10Andre Klapper) [16:07:59] 3MediaWiki / 3Templates: Parameterless templates incorrectly cache dynamic functions - 10https://bugzilla.wikimedia.org/58929 (10Andre Klapper) [16:08:00] 3MediaWiki / 3Skin and page rendering: No space between Atom and RSS links using both with $wgAdvertisedFeedTypes - 10https://bugzilla.wikimedia.org/36356 (10Andre Klapper) [16:08:01] 3MediaWiki / 3General/Unknown: Cancel link URL wrong (due to WYSIWYG extension) - 10https://bugzilla.wikimedia.org/55875 (10Andre Klapper) [16:08:02] 3MediaWiki / 3Maintenance scripts: importImages.php does not actually upload previously deleted files. - 10https://bugzilla.wikimedia.org/56987 (10Andre Klapper) [16:08:02] (03Merged) 10jenkins-bot: Add some aliases to suppress a bunch of warnings. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/140832 (owner: 10Andrew Bogott) [16:08:03] 3MediaWiki / 3History/Diffs: "Previous" revision link on oldest version of wiki article points to a *newer* revision - 10https://bugzilla.wikimedia.org/24671 (10Andre Klapper) [16:08:04] 3MediaWiki / 3Parser: #timel:t returns wrong number of days if date argument is first day of month with 30 or 28 days - 10https://bugzilla.wikimedia.org/54676 (10Andre Klapper) [16:08:05] 3MediaWiki / 3User login and signup: When user makes new password, the user is stopped by error: "incorrect password", even when the password is correct - 10https://bugzilla.wikimedia.org/52570 (10Andre Klapper) [16:08:06] 3MediaWiki / 3Installer: ReflectionException: Class LanguagePt does not exist ..\includes\Init.php on line 168 - 10https://bugzilla.wikimedia.org/49794 (10Andre Klapper) [16:08:14] 3MediaWiki / 3Page editing: $wgSpamRegex bypassed when "Add Topic" is used with URL in Subject/headline - 10https://bugzilla.wikimedia.org/49694 (10Andre Klapper) [16:08:14] 3MediaWiki / 3General/Unknown: $wgDisableCounters is used for two independent functions (disabling site counters and displaying counters as they are) - 10https://bugzilla.wikimedia.org/54819 (10Andre Klapper) [16:08:14] 3MediaWiki / 3Recent changes: Add extra log links to Recent changes page ("(hist | change)", "(view/restore)") - 10https://bugzilla.wikimedia.org/47466 (10Andre Klapper) [16:08:14] 3MediaWiki / 3Parser: Gallery image with link= going to top of - 10https://bugzilla.wikimedia.org/62343 (10Andre Klapper) [16:08:15] 3MediaWiki / 3Special pages: Selecting file to upload doesn't populate "Destination filename" or show thumbnail if $wgCopyUploadsFromSpecialUpload = true - 10https://bugzilla.wikimedia.org/53859 (10Andre Klapper) [16:08:29] 3MediaWiki / 3Page deletion: Add "← Older revision" and "Newer revision →" nav links when browsing a deleted page's revisions - 10https://bugzilla.wikimedia.org/54089 (10Andre Klapper) [16:08:29] 3MediaWiki / 3Templates: Style is not loaded in some PC's and some browsers. - 10https://bugzilla.wikimedia.org/53097 (10Andre Klapper) [16:08:29] 3MediaWiki / 3History/Diffs: Infinite loops/excessive execution time in DairikiDiff.php - 10https://bugzilla.wikimedia.org/49244 (10Andre Klapper) [16:08:29] 3MediaWiki / 3History/Diffs: diff3 error message (No newline at end of file) logged when undoing an edit at end of file - 10https://bugzilla.wikimedia.org/39637 (10Andre Klapper) [16:08:30] 3MediaWiki / 3General/Unknown: Dot files should not be included in the tarball release packages - 10https://bugzilla.wikimedia.org/55699 (10Andre Klapper) [16:08:32] 3MediaWiki / 3User login and signup: CryptRand.php - 10https://bugzilla.wikimedia.org/55364 (10Andre Klapper) [16:08:33] 3MediaWiki / 3Categories: Undefined offset notice in ImageGallery.php if &fileuntil=xxx.yyy is appended on Category: pages - 10https://bugzilla.wikimedia.org/47464 (10Andre Klapper) [16:08:34] 3MediaWiki / 3Page editing: Problems after changing LocalSettings.php - 10https://bugzilla.wikimedia.org/49360 (10Andre Klapper) [16:08:35] 3MediaWiki / 3Installer: Installer should say "Your username" instead of "Your Name" to be consistent with MW login UI - 10https://bugzilla.wikimedia.org/56235 (10Andre Klapper) [16:08:36] 3MediaWiki / 3General/Unknown: Variables in Badaccess-groups incompatible with ParserFunctions - 10https://bugzilla.wikimedia.org/55700 (10Andre Klapper) [16:08:44] 3MediaWiki / 3Database: reuseConnection() is not ignored although it should be - 10https://bugzilla.wikimedia.org/49529 (10Andre Klapper) [16:08:44] 3MediaWiki / 3Email: 24 hour Reset password email lock should not be set if sending the email failed - 10https://bugzilla.wikimedia.org/52839 (10Andre Klapper) [16:08:44] 3MediaWiki / 3Database: cl_collation index redundant - 10https://bugzilla.wikimedia.org/57184 (10Andre Klapper) [16:08:44] 3MediaWiki / 3Database: log_page_id_time index redundant - 10https://bugzilla.wikimedia.org/57182 (10Andre Klapper) [16:08:45] 3MediaWiki / 3Maintenance scripts: updateSpecialPages.php - PHP Notice "No transaction to commit, something got out of sync!" - 10https://bugzilla.wikimedia.org/57922 (10Andre Klapper) [16:08:46] 3MediaWiki / 3API: CreateAccount API call doesn't COMMIT the operation - 10https://bugzilla.wikimedia.org/50275 (10Andre Klapper) [16:08:47] 3MediaWiki / 3Database: blob_tracking indexes apparently unused - 10https://bugzilla.wikimedia.org/57186 (10Andre Klapper) [16:08:59] 3MediaWiki / 3Installer: Installation fails if passthru is blocked - 10https://bugzilla.wikimedia.org/49472 (10Andre Klapper) [16:08:59] 3MediaWiki / 3Skin and page rendering: Main Page not displaying properly - 10https://bugzilla.wikimedia.org/50273 (10Andre Klapper) [16:08:59] 3MediaWiki / 3API: Getting invalid token error even after sending the correct edit token while upload image using API - 10https://bugzilla.wikimedia.org/52454 (10Andre Klapper) [16:08:59] 3MediaWiki / 3Redirects: Special:ListRedirects is missing some pages - 10https://bugzilla.wikimedia.org/57528 (10Andre Klapper) [16:09:00] 3MediaWiki / 3Templates: conditional section added by template doesn't get modify link - 10https://bugzilla.wikimedia.org/58686 (10Andre Klapper) [16:09:01] 3MediaWiki / 3Recent changes: Enhanced Recent Changes needs hook(s) for customised formatting, similar to OldChangesListRecentChangesLine hook - 10https://bugzilla.wikimedia.org/53851 (10Andre Klapper) [16:09:02] 3MediaWiki / 3General/Unknown: Error Code 500 when calling a not existing page (Plesk issue?) - 10https://bugzilla.wikimedia.org/52800 (10Andre Klapper) [16:09:03] 3MediaWiki / 3API: Creating a page via the API doesn't add it to the searchindex table - 10https://bugzilla.wikimedia.org/55538 (10Andre Klapper) [16:09:04] 3MediaWiki / 3Database: Database tableExists() produces errors. - 10https://bugzilla.wikimedia.org/52294 (10Andre Klapper) [16:09:05] 3MediaWiki / 3Database: ApiQueryRandom allows slow queries for nonexistant page_namespace - 10https://bugzilla.wikimedia.org/57285 (10Andre Klapper) [16:09:06] 3MediaWiki / 3Database: SpecialRecentChanges::doMainQuery query needs tuning - 10https://bugzilla.wikimedia.org/57175 (10Andre Klapper) [16:09:07] 3MediaWiki / 3Installer: DOMDocument class (php xml extension) missing causes fatal in installer - 10https://bugzilla.wikimedia.org/51042 (10Andre Klapper) [16:09:08] 3MediaWiki / 3Installer: Upgrade failures due to &mwPrefix.tableName not substituted - Oracle - 10https://bugzilla.wikimedia.org/49822 (10Andre Klapper) [16:09:14] 3MediaWiki / 3General/Unknown: Two empty files can be deleted in VCS: maintenance/language/zhtable/trad2simp_supp_unset.manual and tmp.sh - 10https://bugzilla.wikimedia.org/49436 (10Andre Klapper) [16:09:16] <^d> Who has ops here and can shut the bot up? [16:10:11] <^d> Well maybe it's done. [16:13:33] andre__: You're aware of the bugspam? :) [16:13:54] yeah, bugmail is normally sent when you edit a ticket in Bugzilla. [16:14:02] I mean in here [16:14:21] If they're just batch maintenance changes it would probably be best to mute the bot first, *shrug* [16:14:30] Did it disturb any conversation in here? [16:14:59] 3Analytics / 3Wikimetrics: Cohort list for report creation screen should not include invalid cohorts - 10https://bugzilla.wikimedia.org/66290 (10Dan Andreescu) 5PATC>3RESO/FIX [16:14:59] 3Analytics / 3Wikimetrics: When a metric returns no results the agreggation steps fails - 10https://bugzilla.wikimedia.org/66439 (10Dan Andreescu) 5PATC>3RESO/FIX [16:15:08] Honestly, I never really get the point why people mention the bot here. [16:15:38] and in case it disturbs anybody, somebody could patch the bot to have a threshold? [16:17:14] 3Analytics / 3EventLogging: EventLogging's country column are logging unwanted (sensitive) chunks of cookie - 10https://bugzilla.wikimedia.org/66478#c13 (10Dan Andreescu) 5PATC>3RESO/FIX I'll mark this resolved from our point of view. Once Ops finishes running the scripts, we just have to notify people... [16:17:59] 3Analytics / 3Wikimetrics: Story: CronUser runs EEVS metrics on all projects daily - 10https://bugzilla.wikimedia.org/65946 (10Dan Andreescu) [16:28:49] (03PS1) 10Matthias Mullie: Hygiene: Remove unused imports [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141460 [16:28:52] (03PS1) 10Matthias Mullie: Hygiene: Fix (potentially) undefined variables [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141461 [16:28:55] (03PS1) 10Matthias Mullie: Hygiene: Get rid of extract() [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141462 [16:30:53] (03CR) 10PleaseStand: split up internalAttemptSave (031 comment) [core] - 10https://gerrit.wikimedia.org/r/141113 (owner: 10Awight) [16:32:14] 3Wikimedia / 3Extension setup: "Wikimedia Shop" deployment on tr-wiki - 10https://bugzilla.wikimedia.org/66727#c1 (10superyetkin) Any update on this? [16:44:17] (03CR) 10Manybubbles: Prefer articles in a user's language on multilingual wikis (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140866 (https://bugzilla.wikimedia.org/66829) (owner: 10Chad) [16:48:14] 3MediaWiki extensions / 3ExtensionDistributor: ExtensionDistributor should not include dot files in the tarball release packages - 10https://bugzilla.wikimedia.org/66985 (10Huji) [16:48:16] 3MediaWiki extensions / 3ExtensionDistributor: ExtensionDistributor should not include dot files in the tarball release packages - 10https://bugzilla.wikimedia.org/66985 (10Huji) 3NEW p:3Unprio s:3normal a:3None A similar issue was fixed for MediaWiki core with bug 55699. Similarly, the ExtensionDist... [16:48:28] 3MediaWiki / 3General/Unknown: Dot files should not be included in the tarball release packages - 10https://bugzilla.wikimedia.org/55699 (10Huji) [16:48:59] 3MediaWiki extensions / 3ExtensionDistributor: ExtensionDistributor should not include dot files in the tarball release packages - 10https://bugzilla.wikimedia.org/66985 (10Huji) p:5Unprio>3Low s:5normal>3minor [16:50:29] 3MediaWiki / 3General/Unknown: Dot files should not be included in the tarball release packages - 10https://bugzilla.wikimedia.org/55699#c3 (10Huji) Mark, bug 66985 is also about the same issue. I have noticed in the latest MW release certain dot files are still included (e.g. .travis.yml) and I assume it is... [16:52:08] (03CR) 10EBernhardson: [C: 032] Hygiene: Fix inconsistent return points [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141434 (owner: 10Matthias Mullie) [16:52:23] (03CR) 10EBernhardson: [C: 032] Hygiene: Add missing @return statement [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141435 (owner: 10Matthias Mullie) [16:52:32] (03Merged) 10jenkins-bot: Hygiene: Fix inconsistent return points [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141434 (owner: 10Matthias Mullie) [16:52:45] (03Merged) 10jenkins-bot: Hygiene: Add missing @return statement [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141435 (owner: 10Matthias Mullie) [16:52:48] (03CR) 10EBernhardson: [C: 032] Hygiene: Add missing $params to PHPDoc [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141436 (owner: 10Matthias Mullie) [16:53:03] (03Merged) 10jenkins-bot: Hygiene: Add missing $params to PHPDoc [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141436 (owner: 10Matthias Mullie) [16:53:34] (03CR) 10EBernhardson: "recheck" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141437 (owner: 10Matthias Mullie) [16:54:14] 3MediaWiki extensions / 3WikidataRepo: CSS class name changed to "valueview-valueview" - 10https://bugzilla.wikimedia.org/66883 (10Lydia Pintscher) [16:54:34] (03CR) 10EBernhardson: [C: 032] Hygiene: Remove doubled case 'diff-post-summary' statement [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141437 (owner: 10Matthias Mullie) [16:54:50] (03Merged) 10jenkins-bot: Hygiene: Remove doubled case 'diff-post-summary' statement [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141437 (owner: 10Matthias Mullie) [16:55:14] 3MediaWiki extensions / 3WikidataRepo: Fatal error: Call to undefined method Wikibase\Api\EditEntity::setTitle() in Wikibase\EditEntity - 10https://bugzilla.wikimedia.org/66842 (10Lydia Pintscher) [16:55:43] 3MediaWiki extensions / 3WikidataRepo: Don't treat referenced entities that are redirects as deleted in the UI - 10https://bugzilla.wikimedia.org/66971 (10Lydia Pintscher) p:5Unprio>3Normal [16:56:55] (03CR) 10EBernhardson: [C: 032] Complete PHPDoc for TemplateHelper [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141438 (owner: 10Matthias Mullie) [16:57:04] (03CR) 10EBernhardson: [C: 032] Hygiene: Remove unused imports [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141460 (owner: 10Matthias Mullie) [16:57:13] (03Merged) 10jenkins-bot: Complete PHPDoc for TemplateHelper [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141438 (owner: 10Matthias Mullie) [16:57:25] (03Merged) 10jenkins-bot: Hygiene: Remove unused imports [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141460 (owner: 10Matthias Mullie) [16:57:59] (03CR) 10EBernhardson: [C: 032] Hygiene: Fix (potentially) undefined variables [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141461 (owner: 10Matthias Mullie) [16:58:17] (03Merged) 10jenkins-bot: Hygiene: Fix (potentially) undefined variables [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141461 (owner: 10Matthias Mullie) [16:58:47] (03CR) 10EBernhardson: [C: 032] Hygiene: Get rid of extract() [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141462 (owner: 10Matthias Mullie) [16:59:04] (03Merged) 10jenkins-bot: Hygiene: Get rid of extract() [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141462 (owner: 10Matthias Mullie) [16:59:14] 3MediaWiki extensions / 3WikidataRepo: Wikibase Repository : broken links on Special:DispatchStats - 10https://bugzilla.wikimedia.org/66959#c1 (10Lydia Pintscher) p:5Unprio>3Normal The page is too short anyway for those links to be really useful imho. Maybe we should just remove them completely? [16:59:36] (03CR) 10EBernhardson: [C: 032] Convert UUIDs to alphanumeric representation [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141439 (owner: 10Matthias Mullie) [16:59:44] 3MediaWiki extensions / 3WikidataRepo: Reimplement autocompletion in property suggester - 10https://bugzilla.wikimedia.org/66838 (10Lydia Pintscher) [16:59:54] (03Merged) 10jenkins-bot: Convert UUIDs to alphanumeric representation [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141439 (owner: 10Matthias Mullie) [17:00:02] (03PS7) 10Rillke: Adding basic functionality [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/140732 [17:00:14] 3MediaWiki extensions / 3WikidataRepo: Allow redirects to be detected/resolved in bulk via the EntityInfoBuilder class - 10https://bugzilla.wikimedia.org/66972 (10Lydia Pintscher) p:5Unprio>3Normal [17:00:40] (03CR) 10Rillke: Adding basic functionality (034 comments) [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/140732 (owner: 10Rillke) [17:00:59] 3MediaWiki extensions / 3WikidataRepo: {{PLURAL}} is not parsed in error messages - 10https://bugzilla.wikimedia.org/66963 (10Lydia Pintscher) p:5Unprio>3Normal [17:01:28] (03PS1) 10Jack Phoenix: Use local context where possible. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/141466 [17:01:50] (03CR) 10Jack Phoenix: [C: 032 V: 032] Use local context where possible. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/141466 (owner: 10Jack Phoenix) [17:03:54] phuedx: hi [17:03:59] (03PS24) 10MarkTraceur: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) [17:04:05] are you available for a few questions about Guided Tour? [17:04:06] (03CR) 10GWicke: "Ping!" [core] - 10https://gerrit.wikimedia.org/r/139473 (https://bugzilla.wikimedia.org/51245) (owner: 10GWicke) [17:04:11] (03CR) 10MarkTraceur: "Sorry about that - reversed the booleans there" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [17:04:44] (03PS3) 10GWicke: Hide the caption of frameless or inline images in Parsoid HTML [core] - 10https://gerrit.wikimedia.org/r/139473 (https://bugzilla.wikimedia.org/51245) [17:05:32] 3MediaWiki / 3General/Unknown: GlobalVarConfig throws exceptions for globals with null value - 10https://bugzilla.wikimedia.org/66986 (10Brad Jorsch) 3NEW p:3Unprio s:3normal a:3None For example, the default value for $wgRightsPage is null. And https://www.mediawiki.org/w/api.php?action=query&meta=si... [17:05:51] (03PS1) 10Anomie: GlobalVarConfig shouldn't throw exceptions for null-valued config settings [core] - 10https://gerrit.wikimedia.org/r/141468 (https://bugzilla.wikimedia.org/66986) [17:06:55] (03PS8) 10EBernhardson: Fixes to topic editing [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140872 (owner: 10Mattflaschen) [17:10:41] (03PS2) 10Chad: Prefer articles in a user's language on multilingual wikis [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140866 (https://bugzilla.wikimedia.org/66829) [17:17:13] (03CR) 10Jdlrobson: "This doesn't seem to be a true infinite scroll implementation. When I scroll to the bottom it is triggered. Ideally I should be able to ca" (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141083 (owner: 10SG) [17:17:23] (03CR) 10Jdlrobson: [C: 031] Infinite scroll load more [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141083 (owner: 10SG) [17:20:31] (03PS1) 10GWicke: Fix rendering of centered caption-less images [core] - 10https://gerrit.wikimedia.org/r/141470 [17:23:03] (03CR) 10Jdlrobson: [C: 04-1] "Also not sure about the approach in general." (032 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141371 (owner: 10Werdna) [17:24:19] (03CR) 10Jdlrobson: [C: 032] Add html to conditionalScroll selector for cross-browser support [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141107 (owner: 10Mattflaschen) [17:24:38] (03Merged) 10jenkins-bot: Add html to conditionalScroll selector for cross-browser support [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141107 (owner: 10Mattflaschen) [17:24:41] (03PS11) 10EBernhardson: Edit post [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139839 (owner: 10Matthias Mullie) [17:25:19] (03PS12) 10EBernhardson: Edit post [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139839 (owner: 10Matthias Mullie) [17:29:34] (03PS1) 10Cmcmahon: Port browser test for Math extension from the /qa/browsertest repo [extensions/Math] - 10https://gerrit.wikimedia.org/r/141472 [17:31:41] (03PS5) 10Awight: split up internalAttemptSave [core] - 10https://gerrit.wikimedia.org/r/141113 [17:32:15] (03CR) 10Awight: "PS5 uses RAII profiling" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/141113 (owner: 10Awight) [17:33:20] (03CR) 10Aaron Schulz: [C: 032] Database search fixes: [core] - 10https://gerrit.wikimedia.org/r/141057 (owner: 10Chad) [17:34:18] (03PS3) 10Awight: Add a new hook, EditPage::postAttemptSave [core] - 10https://gerrit.wikimedia.org/r/141114 [17:37:07] (03Merged) 10jenkins-bot: Database search fixes: [core] - 10https://gerrit.wikimedia.org/r/141057 (owner: 10Chad) [17:41:33] (03PS1) 10Anomie: Retab i18n/en.json [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/141475 [17:44:58] (03CR) 10Aaron Schulz: [C: 032] Removed setLang() too from IContextSource subclasses [core] - 10https://gerrit.wikimedia.org/r/141075 (owner: 10Withoutaname) [17:45:49] (03PS1) 10Cmcmahon: Port tests from /qa/browsertest repo before it is deleted [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/141476 [17:48:33] (03CR) 10Withoutaname: "Same reason we have a maintenance script to be able to tell if a page exists or not? (pageExists.php)" [core] - 10https://gerrit.wikimedia.org/r/131431 (https://bugzilla.wikimedia.org/52887) (owner: 10Withoutaname) [17:48:40] (03Merged) 10jenkins-bot: Removed setLang() too from IContextSource subclasses [core] - 10https://gerrit.wikimedia.org/r/141075 (owner: 10Withoutaname) [17:55:08] (03PS6) 10Jdlrobson: QA: Fix edit_existing.feature test [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141050 [17:55:36] (03PS2) 10Withoutaname: Moved Article::render() to RenderAction::show() [core] - 10https://gerrit.wikimedia.org/r/141359 [17:55:51] (03PS13) 10Jdlrobson: Wire up edit post in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139839 (owner: 10Matthias Mullie) [17:57:43] 3MediaWiki extensions / 3ExtensionDistributor: ExtensionDistributor should not include dot files in the tarball release packages - 10https://bugzilla.wikimedia.org/66985#c1 (10Mark A. Hershberger) The ExtensionDistributor is managed differently than the tarball for MediaWiki core. Still, maybe this is somet... [17:58:52] (03PS14) 10Jdlrobson: Wire up edit post in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139839 (owner: 10Matthias Mullie) [17:58:59] 3MediaWiki / 3General/Unknown: Dot files should not be included in the tarball release packages - 10https://bugzilla.wikimedia.org/55699#c4 (10Mark A. Hershberger) (In reply to Huji from comment #3) > Mark, bug 66985 is also about the same issue. The symptoms are the same. The ExtensionDistributor and tarb... [17:59:43] (03PS2) 10GWicke: Fix rendering of centered caption-less images [core] - 10https://gerrit.wikimedia.org/r/141470 (https://bugzilla.wikimedia.org/51245) [18:00:15] (03PS3) 10Chad: SpecialSearch: Simplify result info [core] - 10https://gerrit.wikimedia.org/r/140952 [18:00:35] (03CR) 10Jdlrobson: [C: 04-1] "I fixed some whitespace issues in template." (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139839 (owner: 10Matthias Mullie) [18:00:47] ^ mlitn if you fix the documentation i'll +2 straight away [18:04:10] aharoni: hey [18:04:19] what can i do for you? [18:06:44] 3Wikimedia / 3General/Unknown: Google Chrome doesnt respect upright of images - 10https://bugzilla.wikimedia.org/65889#c7 (10Juan de Vojníkov) Yes, in that link it is correct. Every image different resolution, but not here. [18:07:29] 3MediaWiki extensions / 3Cite: Cite: If there's no block on the page, show one automatically below the content rather than showing an error - 10https://bugzilla.wikimedia.org/66860#c1 (10James Forrester) Bug 29774 might possibly be tangentially/accidentally fixed by this, but it's not a blocke... [18:07:29] 3MediaWiki extensions / 3Cite: Cite Extension: missing ref name before triggers error messages - 10https://bugzilla.wikimedia.org/29774 (10James Forrester) [18:07:44] 3MediaWiki extensions / 3Spam Blacklist: Under HHVM: Fatal error: Argument 1 passed to AbstractContent::getParserOutput() must be an instance of Title, null given - 10https://bugzilla.wikimedia.org/66930#c2 (10Ori Livneh) (In reply to Chad H. from comment #1) > HHVM I think is being a little overzealous here... [18:08:24] (03PS9) 10Jdlrobson: Fixes to topic editing [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140872 (owner: 10Mattflaschen) [18:09:12] (03CR) 10Legoktm: [C: 031] "Makes sense." [core] - 10https://gerrit.wikimedia.org/r/141468 (https://bugzilla.wikimedia.org/66986) (owner: 10Anomie) [18:15:52] (03PS25) 10EBernhardson: javascript post/topic moderation [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139016 [18:15:59] 3MediaWiki extensions / 3Spam Blacklist: Under HHVM: Fatal error: Argument 1 passed to AbstractContent::getParserOutput() must be an instance of Title, null given - 10https://bugzilla.wikimedia.org/66930#c3 (10Max Semenik) (In reply to Chad H. from comment #1) > HHVM I think is being a little overzealous her... [18:17:11] (03PS26) 10Jdlrobson: javascript post/topic moderation [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139016 (owner: 10EBernhardson) [18:17:22] (03CR) 10Jdlrobson: javascript post/topic moderation (039 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139016 (owner: 10EBernhardson) [18:17:55] (03CR) 10Jdlrobson: [C: 04-1] "See comments on Patch Set 24" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139016 (owner: 10EBernhardson) [18:18:23] (03PS6) 10Krinkle: Move user navigation from various special pages to one User method [core] - 10https://gerrit.wikimedia.org/r/137581 (https://bugzilla.wikimedia.org/27707) (owner: 10devunt) [18:19:14] (03PS1) 10Umherirrender: Remove deprecated class FormatExif [core] - 10https://gerrit.wikimedia.org/r/141478 [18:19:46] (03PS15) 10EBernhardson: Wire up edit post in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139839 (owner: 10Matthias Mullie) [18:22:16] (03PS1) 10Umherirrender: Remove compatibility code for class FormatExif [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/141479 [18:22:50] (03CR) 10Jdlrobson: [C: 032] Fixes to topic editing [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140872 (owner: 10Mattflaschen) [18:23:06] (03Merged) 10jenkins-bot: Fixes to topic editing [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140872 (owner: 10Mattflaschen) [18:26:43] (03PS3) 10Jdlrobson: Add QUnit test infrastructure. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140607 [18:26:46] (03PS1) 10Jdlrobson: Tools: Allow running of unit tests from command line [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141480 [18:29:09] (03PS1) 10Umherirrender: Do not mention deprecated RawPage in hooks.txt [core] - 10https://gerrit.wikimedia.org/r/141481 [18:32:48] (03PS1) 10CSteipp: Update CentralAuth for Password API [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/141482 [18:33:05] (03CR) 10Umherirrender: [C: 031] Fix typo in Special:MIMESearch causing minor part to be ignored. [core] - 10https://gerrit.wikimedia.org/r/141257 (owner: 10Brian Wolff) [18:37:26] (03PS1) 10Ori.livneh: Use preg_match rather than fnmatch for 'like' operator [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/141483 (https://bugzilla.wikimedia.org/66930) [18:37:28] (03CR) 10jenkins-bot: [V: 04-1] Use preg_match rather than fnmatch for 'like' operator [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/141483 (https://bugzilla.wikimedia.org/66930) (owner: 10Ori.livneh) [18:37:49] (03PS17) 10Jdlrobson: WIP: Wire up close & open actions in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 (owner: 10Bsitu) [18:37:53] (03PS1) 10Jdlrobson: Add content format parameter to API for flow topics [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141484 [18:37:56] (03CR) 10jenkins-bot: [V: 04-1] WIP: Wire up close & open actions in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 (owner: 10Bsitu) [18:38:14] (03PS2) 10Ori.livneh: Use preg_match rather than fnmatch for 'like' operator [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/141483 (https://bugzilla.wikimedia.org/66930) [18:38:41] (03PS1) 10Umherirrender: Remove SpecialPage::getFile [core] - 10https://gerrit.wikimedia.org/r/141485 [18:39:11] (03CR) 10Umherirrender: SpecialPage: Remove wfSpecial* call syntax (031 comment) [core] - 10https://gerrit.wikimedia.org/r/131518 (owner: 10Chad) [18:40:24] (03CR) 10Krinkle: "I'd recommend dropping the array construction and just registering them as individual modules with the test files explicitly." (033 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140607 (owner: 10Jdlrobson) [18:45:45] (03PS1) 10Umherirrender: Remove ParserOptions::setSkin() (deprecated since 1.19) [core] - 10https://gerrit.wikimedia.org/r/141489 [18:46:03] (03CR) 10Krinkle: "Preserving it in the data model and keeping it in the rendering seems the right approach. However if we choose not to, that is imho only j" [core] - 10https://gerrit.wikimedia.org/r/139473 (https://bugzilla.wikimedia.org/51245) (owner: 10GWicke) [18:46:34] (03CR) 10CSteipp: "I feel good about the testing I've put this through-- I'm pretty confident it's going to work well in production at the WMF as is." [core] - 10https://gerrit.wikimedia.org/r/77645 (https://bugzilla.wikimedia.org/54948) (owner: 10Parent5446) [18:48:47] (03PS27) 10EBernhardson: javascript post/topic moderation [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139016 [18:53:15] 3MediaWiki extensions / 3Translate: Translate: Provide a way in TUX UI to delete a translation - 10https://bugzilla.wikimedia.org/48005 (10PiRSquared17) a:3PiRSquared17 [18:53:52] MatmaRex: James_F: We now have jqmigrate tracking live http://codepen.io/Krinkle/full/zyodJ/ [18:54:29] while the weekly fluctuation in traffic will obscore any useful change in usage, it does clealry show which are most used. [18:54:34] $.browser wins by a long shot [18:55:26] Krinkle: Yay. [18:55:33] Krinkle: And by "yay" I mean "boo". [18:55:37] (03CR) 10Aaron Schulz: [C: 032] Use preg_match rather than fnmatch for 'like' operator [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/141483 (https://bugzilla.wikimedia.org/66930) (owner: 10Ori.livneh) [18:55:43] (03Merged) 10jenkins-bot: Use preg_match rather than fnmatch for 'like' operator [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/141483 (https://bugzilla.wikimedia.org/66930) (owner: 10Ori.livneh) [18:56:03] Krinkle: The graph showing from < 0 is… optimistic. [18:56:35] James_F: heh, that's for when people use jQuery features that aren't in any release yet :) [18:56:38] AaronSchulz: thanks [18:56:44] James_F: yeah, there's something weird going on [18:57:21] jqmigrate.bind_error (magnified in the third graph below the big one) started at -1 when we first enabled it [18:57:28] no idea why [18:57:31] Krinkle: Aha. [18:57:40] Krinkle: I blame off-by-one errors. [18:57:42] * James_F grins. [18:57:50] Krinkle: Hey. I see http://stream.wikimedia.org/ is sort-of live, but connecting with websockets gives me 502's. Is that on purpose? [18:57:54] (03CR) 10Ori.livneh: "Woops, the bug this fixes is 66935, not 66930" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/141483 (https://bugzilla.wikimedia.org/66930) (owner: 10Ori.livneh) [18:58:02] (03CR) 10GWicke: "@Krinkle: I'd suggest having the VE discussion elsewhere. This patch is just about making the Parsoid HTML work well in normal page views," [core] - 10https://gerrit.wikimedia.org/r/139473 (https://bugzilla.wikimedia.org/51245) (owner: 10GWicke) [18:58:28] 3MediaWiki extensions / 3Spam Blacklist: Under HHVM: Fatal error: Argument 1 passed to AbstractContent::getParserOutput() must be an instance of Title, null given - 10https://bugzilla.wikimedia.org/66930#c6 (10Ori Livneh) Sorry, the patch is unrelated to this bug; I meant to reference bug 66935 instead. [18:58:39] I'd ask ori why mw.track/eventlogging/statsd/graphite sometimes populates with -1, but there's so much crap going on, it's not important and wouldn't want him to priotise it. [18:59:05] (03PS1) 10Umherirrender: Correct comment about getPropsFromPath/sha1Base36 in sql files [core] - 10https://gerrit.wikimedia.org/r/141491 [18:59:37] valhallasw: http://codepen.io/Krinkle/full/laucI/ should work [18:59:43] I see that one yields 502 as well [18:59:51] report in #wikimedia-operations or file bug [18:59:58] Krinkle: ok! [19:00:06] we should have icinga detect this [19:01:46] 3Wikimedia / 3Stream: stream.wikimedia.org throws websocket.WebSocketException: Handshake Status 502 - 10https://bugzilla.wikimedia.org/66989 (10Merlijn van Deen) 3NEW p:3Unprio s:3normal a:3None Using either - the pywikibot page generator implementation, - the python implementation on https://wiki... [19:02:48] (03PS1) 10Umherirrender: Replace deprecated File::sha1Base36 call [core] - 10https://gerrit.wikimedia.org/r/141492 [19:03:32] (03CR) 10Aaron Schulz: [C: 032] Correct comment about getPropsFromPath/sha1Base36 in sql files [core] - 10https://gerrit.wikimedia.org/r/141491 (owner: 10Umherirrender) [19:03:34] (03CR) 10Chad: [C: 032] GlobalVarConfig shouldn't throw exceptions for null-valued config settings [core] - 10https://gerrit.wikimedia.org/r/141468 (https://bugzilla.wikimedia.org/66986) (owner: 10Anomie) [19:05:15] (03CR) 10Chad: [C: 032] Remove SpecialPage::getFile [core] - 10https://gerrit.wikimedia.org/r/141485 (owner: 10Umherirrender) [19:05:19] (03PS18) 10Jdlrobson: WIP: Wire up close & open actions in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 (owner: 10Bsitu) [19:05:22] (03PS1) 10Jdlrobson: Use partial for flow_block_topic_close for consistency [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141493 [19:05:39] (03CR) 10jenkins-bot: [V: 04-1] WIP: Wire up close & open actions in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 (owner: 10Bsitu) [19:06:57] (03CR) 10Chad: "So no good reason at all then! :p" [core] - 10https://gerrit.wikimedia.org/r/131431 (https://bugzilla.wikimedia.org/52887) (owner: 10Withoutaname) [19:07:32] (03Merged) 10jenkins-bot: Correct comment about getPropsFromPath/sha1Base36 in sql files [core] - 10https://gerrit.wikimedia.org/r/141491 (owner: 10Umherirrender) [19:08:23] (03Merged) 10jenkins-bot: GlobalVarConfig shouldn't throw exceptions for null-valued config settings [core] - 10https://gerrit.wikimedia.org/r/141468 (https://bugzilla.wikimedia.org/66986) (owner: 10Anomie) [19:08:44] 3MediaWiki / 3General/Unknown: IIS Bugs (Tracking) - 10https://bugzilla.wikimedia.org/22710 (10Jesús Martínez Novo (Ciencia Al Poder)) [19:08:46] 3MediaWiki / 3General/Unknown: Short URLs not working on IIS for articles with special characters - 10https://bugzilla.wikimedia.org/66990 (10Jesús Martínez Novo (Ciencia Al Poder)) 3UNCO p:3Unprio s:3normal a:3None Coying here the problem reported in Support Desk (in URL): ---- I've just upgraded... [19:08:50] (03Merged) 10jenkins-bot: Remove SpecialPage::getFile [core] - 10https://gerrit.wikimedia.org/r/141485 (owner: 10Umherirrender) [19:09:59] 3MediaWiki extensions / 3AbuseFilter: AbuseFilterParserTest failure under HHVM - 10https://bugzilla.wikimedia.org/66935#c2 (10Ori Livneh) 5NEW>3RESO/FIX Fixed by https://gerrit.wikimedia.org/r/#/c/141483/ [19:10:06] (03CR) 10Chad: [C: 032] Don't allow some E_NOTICE messages to end up in the LocalSettings.php [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/141307 (https://bugzilla.wikimedia.org/66922) (owner: 10MarkAHershberger) [19:10:28] (03CR) 10Mattflaschen: "Terminology question:" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141484 (owner: 10Jdlrobson) [19:11:28] (03CR) 10Chad: [C: 032] Remove comment which I believe is wrong and unnecessary. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/141236 (owner: 10Nikerabbit) [19:11:44] 3MediaWiki / 3General/Unknown: GlobalVarConfig throws exceptions for globals with null value - 10https://bugzilla.wikimedia.org/66986#c3 (10Umherirrender) 5PATC>3RESO/FIX was successfully merged [19:11:54] (03CR) 10Cscott: [C: 032] "Double-checked this against Parsoid DOM spec, looks good to me." [core] - 10https://gerrit.wikimedia.org/r/139473 (https://bugzilla.wikimedia.org/51245) (owner: 10GWicke) [19:12:04] (03CR) 10Bsitu: [C: 031] Add content format parameter to API for flow topics [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141484 (owner: 10Jdlrobson) [19:12:57] (03CR) 10Chad: [C: 032] Output php before script name [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/141251 (owner: 10Nikerabbit) [19:13:02] (03Merged) 10jenkins-bot: Remove comment which I believe is wrong and unnecessary. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/141236 (owner: 10Nikerabbit) [19:13:14] (03Merged) 10jenkins-bot: Output php before script name [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/141251 (owner: 10Nikerabbit) [19:13:15] 3MediaWiki / 3General/Unknown: GlobalVarConfig throws exceptions for globals with null value - 10https://bugzilla.wikimedia.org/66986#c4 (10Brad Jorsch) 5RESO/FIX>3REOP a:3Brad Jorsch Should backport this, no reason to let stuff be broken for a week until wmf11 rolls out. I've scheduled it for the Tue... [19:13:56] <^d> Nikerabbit: Thanks for the two Cirrus patches :) [19:14:02] (03CR) 10Gergő Tisza: [C: 031] Add a PSR-3 based logging interface [core] - 10https://gerrit.wikimedia.org/r/119940 (owner: 10BryanDavis) [19:14:04] awight: see email [19:14:24] ^d: yeah, unfortunately I had to stop ES bootstrapping at twn [19:14:48] <^d> Oh no :( Just that build-chunks or something bigger? [19:14:52] ^d: one of my shards got moved to unassigned state for unknown reason and I haven't get figured out how to fix it (I emailed some details to Nik) [19:15:01] <^d> Ah, ok. [19:15:18] free testers! [19:15:54] [2014-06-22 19:42:21,812][DEBUG][action.search.type ] [Marlene Alraune] [translatewiki_net-bw__content_first][3], node[6iDY-lD5S4ODQKMNBdRfVA], [P], s[STARTED]: Failed to execute [org.elasticsearch.action.search.SearchRequest@1f86a140] lastShard [true] [19:15:59] org.elasticsearch.common.util.concurrent.EsRejectedExecutionException: rejected execution (queue capacity 1000) on org.elasticsearch.action.search.type.TransportSearchTypeAction$BaseAsyncAction$2@d99020c [19:16:07] that's the first output after I started bootstrapping, not very helpful [19:17:40] (03CR) 10Mattflaschen: "Will submit followup now to remove it from Flow." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141094 (owner: 10SG) [19:18:11] (03Merged) 10jenkins-bot: Don't allow some E_NOTICE messages to end up in the LocalSettings.php [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/141307 (https://bugzilla.wikimedia.org/66922) (owner: 10MarkAHershberger) [19:18:49] (03Merged) 10jenkins-bot: Hide the caption of frameless or inline images in Parsoid HTML [core] - 10https://gerrit.wikimedia.org/r/139473 (https://bugzilla.wikimedia.org/51245) (owner: 10GWicke) [19:21:06] (03CR) 10TheDJ: [C: 032] Fix typo in Special:MIMESearch causing minor part to be ignored. [core] - 10https://gerrit.wikimedia.org/r/141257 (owner: 10Brian Wolff) [19:21:20] thedj: thanks :) [19:23:14] 3MediaWiki extensions / 3OAuth: Fatal error: Class already declared: OAuthException - 10https://bugzilla.wikimedia.org/66929#c1 (10Chris Steipp) Since the PECL extension just extends the default exception with two extra properties (if I understand the code right), which is compatible with the library we're u... [19:24:20] bawolff: nasty one. good work on the test case [19:25:06] I'm not sure how i missed that when testing the patch that introduced the bug [19:25:22] (03PS1) 10Mattflaschen: Remove box-sizing property; import from core instead [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141495 [19:25:38] (03Merged) 10jenkins-bot: Fix typo in Special:MIMESearch causing minor part to be ignored. [core] - 10https://gerrit.wikimedia.org/r/141257 (owner: 10Brian Wolff) [19:26:46] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/141429 (owner: 10Jforrester) [19:29:07] (03CR) 10Cscott: [C: 032] Fix rendering of centered caption-less images (031 comment) [core] - 10https://gerrit.wikimedia.org/r/141470 (https://bugzilla.wikimedia.org/51245) (owner: 10GWicke) [19:30:11] (03CR) 10Bsitu: [C: 04-2] "Should not allow topic request in wikitext format. close-open-topic patch needs to be changed to use singlepost for edit title then anoth" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141484 (owner: 10Jdlrobson) [19:31:38] (03CR) 10GWicke: [C: 032] "Yay for one more nicely packaged service. Thank you Kartik!" [services/cxserver/deploy] - 10https://gerrit.wikimedia.org/r/140059 (owner: 10KartikMistry) [19:32:24] (03PS1) 10CSteipp: Play nice with PECL [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/141496 (https://bugzilla.wikimedia.org/66929) [19:32:29] (03Merged) 10jenkins-bot: Fix rendering of centered caption-less images [core] - 10https://gerrit.wikimedia.org/r/141470 (https://bugzilla.wikimedia.org/51245) (owner: 10GWicke) [19:32:31] (03CR) 10jenkins-bot: [V: 04-1] Play nice with PECL [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/141496 (https://bugzilla.wikimedia.org/66929) (owner: 10CSteipp) [19:35:22] (03CR) 10Siebrand: "i18n/L10n reviewed." (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG) [19:39:11] (03PS2) 10Jdlrobson: Hygiene: Remove box-sizing property; import from core instead [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141495 (owner: 10Mattflaschen) [19:39:15] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove box-sizing property; import from core instead [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141495 (owner: 10Mattflaschen) [19:40:01] (03Merged) 10jenkins-bot: Hygiene: Remove box-sizing property; import from core instead [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141495 (owner: 10Mattflaschen) [19:40:52] (03CR) 10Siebrand: [C: 031] "i18n reviewed. Trivial change." [core] - 10https://gerrit.wikimedia.org/r/140952 (owner: 10Chad) [19:41:13] (03CR) 10Siebrand: [C: 032] Retab i18n/en.json [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/141475 (owner: 10Anomie) [19:41:20] (03Merged) 10jenkins-bot: Retab i18n/en.json [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/141475 (owner: 10Anomie) [19:41:51] (03PS19) 10Jdlrobson: Wire up close & open actions in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 (owner: 10Bsitu) [19:41:54] (03PS3) 10Jdlrobson: QA: Add browser tests for close and reopen behaviour [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141073 [19:41:57] (03CR) 10jenkins-bot: [V: 04-1] Wire up close & open actions in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 (owner: 10Bsitu) [19:42:00] (03CR) 10jenkins-bot: [V: 04-1] QA: Add browser tests for close and reopen behaviour [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141073 (owner: 10Jdlrobson) [19:42:37] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/141422 (owner: 10Smuggli) [19:43:44] 3MediaWiki / 3JavaScript: mw.config doesn't expose page existence information about the target of a special page - 10https://bugzilla.wikimedia.org/53774 (10Alex Monk) [19:45:14] 3Wikimedia / 3Bugzilla: Deploy Mozilla Persona / browserid extension in Bugzilla - 10https://bugzilla.wikimedia.org/45263#c2 (10Andre Klapper) p:5Low>3Lowest In the meantime, Mozilla Persona is not under active development by Mozilla anymore (there might still be some community development though). [19:45:15] 3MediaWiki / 3JavaScript: mw.config doesn't expose page existence information about the target of a special page - 10https://bugzilla.wikimedia.org/53774#c5 (10Alex Monk) 5RESO/WOR>3REOP This bug is about giving existence information for the relevant article (i.e. the article that the special page is wor... [19:46:14] 3MediaWiki / 3JavaScript: mw.config doesn't expose page existence information about the target of a special page - 10https://bugzilla.wikimedia.org/53774 (10Alex Monk) [19:46:26] (03PS1) 10Yurik: Set proper SSH URL for all GIT repos (with username) - take 3 [vagrant] - 10https://gerrit.wikimedia.org/r/141500 [19:47:09] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/141418 (owner: 10Smuggli) [19:47:11] (03PS2) 10Jdlrobson: Add content format parameter to API for flow topics [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141484 [19:47:14] (03PS20) 10Jdlrobson: Wire up close & open actions in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 (owner: 10Bsitu) [19:47:17] (03PS4) 10Jdlrobson: QA: Add browser tests for close and reopen behaviour [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141073 [19:47:20] (03PS2) 10Jdlrobson: Use partial for flow_block_topic_close for consistency [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141493 [19:47:23] (03CR) 10jenkins-bot: [V: 04-1] Wire up close & open actions in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 (owner: 10Bsitu) [19:48:38] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/136123 (owner: 10Jackmcbarn) [19:49:32] (03PS21) 10Jdlrobson: Wire up close & open actions in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 (owner: 10Bsitu) [19:49:35] (03PS5) 10Jdlrobson: QA: Add browser tests for close and reopen behaviour [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141073 [19:49:46] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/139831 (owner: 10Smuggli) [19:49:59] (03PS2) 10CSteipp: Play nice with PECL [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/141496 (https://bugzilla.wikimedia.org/66929) [19:51:29] ori, i could you elaborate on the nature of the problem with vagrant plugin versioning? It works ok on my machine, but i'm running vagrant 1.5.3 on win [19:51:55] yurikR: i can but not right now, leave me a note on the patch? [19:52:12] ok [19:52:31] (03PS1) 10Spage: API: update deprecation for action=query list=flow [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141503 [19:53:01] 3MediaWiki / 3General/Unknown: jquery.makeCollapsible should allow setting standard toggles for remote handles - 10https://bugzilla.wikimedia.org/66991 (10Dmitrij D. Czarkoff) 3UNCO p:3Unprio s:3enhanc a:3None Intention: The idea is to allow custom placement of handle for collapsible element while ke... [19:53:53] (03PS2) 10Yurik: Set proper SSH URL for all GIT repos (with username) - take 3 [vagrant] - 10https://gerrit.wikimedia.org/r/141500 [19:58:24] (03CR) 10Spage: "should the warning also be changed?" (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141503 (owner: 10Spage) [20:00:20] (03PS3) 10Yurik: Set proper SSH URL for all GIT repos (with username) - take 3 [vagrant] - 10https://gerrit.wikimedia.org/r/141500 [20:03:44] 3MediaWiki-Vagrant: Fatal error: undefined method `save' due to outdated plugin - 10https://bugzilla.wikimedia.org/66889#c1 (10Yuri Astrakhan) I added a patch Icf3ba214440304145560e2e78ed7149085aeca7c that also bumps the version number. Should there be any other text instructions/actions that are needed to res... [20:04:42] bd808, ^^ [20:07:37] yurikR: That would help, but you should talk to ori about the UX for that feature in general. I don't think his revert in https://gerrit.wikimedia.org/r/#/c/141277/ was just for the save error. [20:09:42] bd808, i think ori was ok with it - as we discussed it before. Of course I am always open for suggestions of how better to do this. My goal is to have the new users of vagrant to have the smallest possible learning curve/number of steps needed to start contributing without disrupting existing users too much. [20:12:53] yurikR: marxarelli and I were discussing how to fix the plugin problem last week and ori said things that made me think he didn't like the interactive prompt. I personally don't really like it either. I like the feature you are trying to incorporate but having `vagrant up` or actually even `vagrant list-roles` suddenly prompt me for a username felt weird. [20:13:24] I was trying to figure out if it was something that could be pushed into a command in the plugin: `vagrant git-setup` or something. [20:14:06] * YuviPanda agrees with bd808 [20:14:11] bd808, true, but we need to address the "first use" case. We could limit the prompt to anything that causes git-clone? [20:14:27] example - vagrant enable-role XXX [20:14:29] 3MediaWiki extensions / 3OAuth: Fatal error: Class already declared: OAuthException - 10https://bugzilla.wikimedia.org/66929 (10Chris Steipp) p:5Unprio>3Highes [20:14:30] or vagrant up [20:14:57] also, please remember that this is suppose to happen just once [20:15:47] (03CR) 10EBernhardson: [C: 032] Wire up edit post in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139839 (owner: 10Matthias Mullie) [20:16:05] (03Merged) 10jenkins-bot: Wire up edit post in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139839 (owner: 10Matthias Mullie) [20:17:21] yurikR: I guess one question to ask is how many / what percentage of people using mw-vagrant will be expected to push patches to gerrit. [20:17:28] I don't have an answer for that. [20:18:01] 3MediaWiki extensions / 3OAuth: Fatal error: Class already declared: OAuthException - 10https://bugzilla.wikimedia.org/66929 (10Ori Livneh) a:3Chris Steipp [20:18:01] But it kind of seems like if you are savvy enough to push to gerrit you are savvy enough to setup the remote [20:18:03] (03CR) 10Ori.livneh: [C: 04-1] "Fatal error: Call to unimplemented native method OAuthException::__construct() in /srv/mediawiki/extensions/OAuth/lib/OAuth.php on line 46" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/141496 (https://bugzilla.wikimedia.org/66929) (owner: 10CSteipp) [20:18:15] bd808, its totally ok if none, but it would be good to have an easy way to convert readers into contributors :) [20:18:23] * bd808 nods [20:18:56] Maybe phabricator will make this all moot :) [20:20:00] bd808, also, i don't think "savy" is the right word here - i had to learn about gerrit's messed up way of using "vagrant" as remote, plus don't forget that each extension has its own remote, and managing them is a major pain. We shouldn't ask new contributors who want to fix a minor ext error to learn all about this [20:20:16] * yurikR can't wait for the holy grail (phabricator) [20:20:32] * cscott is not optimistic thta phabricator will make everything better [20:20:34] (03PS1) 10Chad: Revert "Add Page Existance checking maintenance script" [core] - 10https://gerrit.wikimedia.org/r/141559 [20:20:35] as someone who is using it right now, it's not a holy grail.. [20:20:41] +1 [20:20:55] as it stands, phabricator is even more confusing than gerrit [20:21:04] agree [20:21:08] But the next tool/hire always fixes all past problems ;) [20:21:15] by definition! [20:21:37] * bawolff not exactly thrilled at the prospect of phab replacing bugzilla. I want it to replace gerrit [20:21:38] we get to close all gerrit-related bugs when we move to phabricator ;) [20:21:45] especially on pre commit review, you can really F'up in my experience. (unless you do a LOT of configuration) [20:21:54] <^d> cscott: How is that any different from just ignoring them now? [20:22:02] <^d> Which is what I totally do ;-) [20:22:04] * cscott is not exactly thrilled at the prospect of phab replacing gerrit. he's fine with it replacing bugzilla. [20:22:34] the best part about phab is how open the devs are to enabling our workflow. [20:22:39] cscott: Maybe we should keep everything precisely as is! ;) [20:22:54] <^d> thedj: As opposed to the Gerrit devs who mostly just tell us we're doing things wrong. [20:23:04] ^d: yeah, that's nice [20:23:05] there is a lot of promise in there (and a much cleaner archetecture to enable the promise) [20:23:20] i actually haven't seen much action from phab upstream on the gerrit-related issues [20:23:42] they've mentioned that their long long long term roadmap allows them to do some of the things we want [20:23:54] is that being "open"? [20:23:55] I'm a full fan of mingle/trello/etc dying in a hole, I just want bugzilla to be the replacement [20:23:59] i only like one thing in phab: you can copy/paste directly from the side-by-side review screen :) [20:24:49] (03PS1) 10Bartosz Dziewoński: SpecialJavaScriptTest: Implement prefixSearchSubpages() [core] - 10https://gerrit.wikimedia.org/r/141561 [20:25:05] Actually, I was reflecting the other day, that our workflow with gerrit, is actually not all that different from putting patches in bugzilla [20:25:13] but in any case, until that phab solves everything, lets make vagrant play nice with gerrit by setting it the best possible way for the devs [20:25:26] bawolff: that's not my gerrit workflow [20:25:41] (03PS2) 10CSteipp: Add grant for access to private information [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/139042 (https://bugzilla.wikimedia.org/66493) [20:25:48] i use patch dependencies and rebasing heavily. and i can put a whole stack of 'patches in' from the command line. [20:26:13] Someone makes a patch, they upload it, it gets ignored for six months, eventually someone comes in and merges into the repo [20:26:31] oh, well, i don't expect that part to ever change. ;) [20:26:36] My experiance with gerrit and dependencies, is just *shudder* [20:26:38] * thedj neither [20:26:45] (03PS1) 10EBernhardson: Wikitext output of Templating::getContent must be escaped [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141562 [20:27:02] i agree. dependencies+topics have tripped me so many times... [20:27:07] bawolff: you're clearly not Doing It Right then. ;) [20:27:14] cscott: FWIW your use-case sounds like a feature branch. [20:27:30] i think deploy-side people have different uses and experiences with dependencies, topics, and branches. [20:27:41] lol, obviously ;) [20:27:44] cscott: you mean like using multiple computers and thus not always having your original feature branch to fix the dependencies... [20:27:49] nicely distributed.... [20:28:01] thedj: that's what 'git review -d' is for. [20:28:22] no, that doesn't work if your dependencies share a topic name [20:28:23] i never remember where my original branch went to, but 'git review -d NNNN' will always give it back to me, wherever i am. [20:28:40] thedj: i don't use topics. maybe that's the solution. ;) [20:28:44] i've multiple times f'up a dependency by trying to fix that way. [20:29:22] i haven't actually ever seen 'git review -d NNNN' screw up my repo. It seems to always use a new unique branch where needed. [20:29:37] if you read our docs it also says specifically: "when fixing the dependency go to your 'feature branch'. [20:29:51] not the review remote... [20:29:57] 'git review -d NNNN ; git fetch origin ; git rebase -i origin/master ; git review -u' always works for me. [20:30:17] thedj: i'm not going to defend the WMF docs for gerrit. [20:30:37] cscott: Hmm. git review -d NNN def screws up my branches [20:30:47] bawolff: how so? [20:30:50] (03PS1) 10EBernhardson: Contributions formatter requires history properties [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141563 [20:31:00] "Branch already exists, reusing": Noooooo.... [20:31:20] If I was stupid and made local changes to a review branch and forgot [20:31:36] git reflog is your friend. [20:31:43] bawolff: yeah, exactly [20:31:44] 3Wikimedia / 3Deployment systems: [scap] Consolidate scripts as sub-commands of `scap` - 10https://bugzilla.wikimedia.org/65827#c5 (10Mukunda Modell) Can't this be done as a simple shell script that just rewrites "scap $1" to "scap-$1 $@" [20:31:51] * bawolff loves git reflog [20:31:55] most useful feature ever [20:32:01] 3MediaWiki extensions / 3OAuth: Special:OAuth doesn't provide a grant to access to private info of users - 10https://bugzilla.wikimedia.org/66493 (10Chris Steipp) p:5Unprio>3Normal s:5critic>3normal a:3Chris Steipp [20:32:38] <^d> Things I don't do: `git review ` [20:33:16] ^d: that's because you're hardcore. you've got <= 3 character username. like rms. hardcore. [20:33:49] <^d> So hardcore I prefer tools that are useful :p [20:33:58] <^d> `git` is useful enough without adding that silly review mess. [20:34:01] <^d> :) [20:34:02] rms, esr, dmr, etc. [20:34:17] bawolff: my solution: never keep review/* branches around. delete them if i was just reviewing, rename if i want to commit stuff on top [20:34:38] anyone care to review this editwarning change btw: https://gerrit.wikimedia.org/r/#/c/121558/ [20:34:41] <^d> My solution: never use `git review -d` and then you have no review/* branches. [20:34:43] <^d> ZING! [20:34:58] 3MediaWiki extensions / 3OAuth: Make OAuth callback URL editable - 10https://bugzilla.wikimedia.org/65751 (10Chris Steipp) p:5Unprio>3High [20:35:04] copy-pasting the commands from gerrit UI is not much fun [20:35:24] my solution is to never leave unpushed commits in my tree. prefix them with 'WIP' and then push them to the server before stopping work. [20:35:38] the cloud is your backup [20:35:39] <^d> My solution is MOVING BACK TO SVN [20:35:47] <^d> NO MORE OF THIS DISTRIBUTED NONSENSE! [20:35:52] ^d: you are clearly in a state of svn [20:36:14] rcs is where it's at. [20:36:28] none of this cooperative working-with-people garbage. [20:36:34] (03PS1) 10Bsitu: Fix 'Load More' [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141564 [20:36:35] * ^d gets off cscott's lawn [20:36:42] (03Draft3) 10Bartosz Dziewoński: Allow skins to define skinStyles for arbitrary modules [core] - 10https://gerrit.wikimedia.org/r/141259 [20:36:49] POW [20:36:59] (Draft3)! [20:37:07] People using drafts! [20:37:14] marktraceur, bawolff: can one of you guys look at https://bugzilla.wikimedia.org/show_bug.cgi?id=66938 ? [20:37:21] bawolff: i don't want everyone see the tests fail :P [20:37:42] lol, sometimes its easier running them on jenkins then locally [20:37:48] always* [20:37:59] 3Wikimedia / 3Deployment systems: [scap] Consolidate scripts as sub-commands of `scap` - 10https://bugzilla.wikimedia.org/65827#c6 (10Bryan Davis) (In reply to Mukunda Modell from comment #5) > Can't this be done as a simple shell script that just rewrites "scap $1" > to "scap-$1 $@" Sure, but I think we a... [20:38:04] <^d> gerrit drafts -- "well intentioned but seriously flawed" [20:38:09] <^d> They had so much promise. [20:38:18] ori: Not super familar with the UploadWizard phpunit tests, but I'll have a look [20:38:18] <^d> Except the whole insane implementation bit. [20:38:23] bawolff: <3 thanks [20:38:25] MatmaRex: the correct response to a jenkins -1 is "damn jenkins. i hate him" and then move on. ;) [20:38:27] they work for my use-case :P [20:39:44] 3MediaWiki extensions / 3OAuth: OAuth: Dialog for granting an app permission should clarify or link to what "basic rights" are - 10https://bugzilla.wikimedia.org/66978#c1 (10Chris Steipp) We considered linking the individual grants to their Special:OAuth/grants entry, iirc UX didn't think it would be a good... [20:40:51] * marktraceur looking [20:41:04] bawolff: https://gerrit.wikimedia.org/r/136277 might be worth a look [20:41:18] (03PS2) 10Bsitu: Fix 'Load More' [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141564 [20:44:29] 3MediaWiki / 3User blocking: correlate autoblocks (currently admin cannot see IF in fact the IP is autoblocked) - 10https://bugzilla.wikimedia.org/13131#c1 (10Marcin Cieślak) I wonder how this is related to bug 5445 which got fixed after long time. [20:44:29] 3MediaWiki / 3User blocking: Remove autoblocks when a user is unblocked - 10https://bugzilla.wikimedia.org/5445 (10Marcin Cieślak) [20:44:59] (03CR) 10Yuvipanda: [C: 04-2] "labs-vagrant on labs depends on this. Should probably add more docs. Adding AndrewBogott, who requested this to Reedy at the Zurich hackat" [core] - 10https://gerrit.wikimedia.org/r/141559 (owner: 10Chad) [20:45:16] 3MediaWiki extensions / 3OAuth: OAuth: Dialog for granting an app permission should clarify or link to what "basic rights" are - 10https://bugzilla.wikimedia.org/66978#c2 (10Jared Zimmerman (WMF)) The rationale was that this option only shows when no other rights were requested in is only shown when an app w... [20:46:32] (03PS1) 10EBernhardson: Prevent double encoding of post content in history/rc [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141568 [20:46:46] (03PS1) 10Brian Wolff: Allow fragments in link= parameter in tags. [core] - 10https://gerrit.wikimedia.org/r/141569 (https://bugzilla.wikimedia.org/62343) [20:47:16] andre__: All your bugspam this morning changing version numbers resulted in --^ getting fixed :) [20:47:51] bawolff, I have problems to parse "--^". Give me more coffee! :) [20:48:21] As in an arrow to point to the line gerrit-wm just wrote :) [20:49:45] (03CR) 10Chad: [C: 032] Don't allow some E_NOTICE messages to end up in the LocalSettings.php [core] - 10https://gerrit.wikimedia.org/r/141261 (https://bugzilla.wikimedia.org/66922) (owner: 10MarkAHershberger) [20:50:24] bawolff: ah, gotcha. I'm more a guy looking at wikibugs than at grrrit-wm :P [20:50:58] (03CR) 10jenkins-bot: [V: 04-1] Allow fragments in link= parameter in tags. [core] - 10https://gerrit.wikimedia.org/r/141569 (https://bugzilla.wikimedia.org/62343) (owner: 10Brian Wolff) [20:53:31] (03Merged) 10jenkins-bot: Don't allow some E_NOTICE messages to end up in the LocalSettings.php [core] - 10https://gerrit.wikimedia.org/r/141261 (https://bugzilla.wikimedia.org/66922) (owner: 10MarkAHershberger) [20:54:54] ugh. parser tests involving images never work right locally for me [20:56:34] (03CR) 10Siebrand: "i18n/L10n reviewed." (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140806 (owner: 10Mattflaschen) [20:57:38] yurikR, legoktm : the Flow API uses submodules of action=flow, but it seems Special:ApiSandbox doesn't know to present submodule parameters. How does ApiSandbox figure it out for action=query? [20:58:16] 3Datasets / 3General/Unknown: Enable IPv6 on dumps.wikimedia.org - 10https://bugzilla.wikimedia.org/66996 (10wp mirror) 3NEW p:3Unprio s:3blocke a:3Ariel T. Glenn To whom it may concern, 0) PROBLEM Most of the WMF sites have IPv6 addresses. For example: (shell)$ dig www.mediawiki.org AAA... [20:58:27] spagewmf, haven't looked at apisandbox match, would need to dig through the code [20:58:31] *much [20:58:34] (03PS2) 10Brian Wolff: Allow fragments in link= parameter in tags. [core] - 10https://gerrit.wikimedia.org/r/141569 (https://bugzilla.wikimedia.org/62343) [21:01:40] yurikR: thx no need, I only asked since you're author of ApiQueryBase.php. [21:02:05] spagewmf, yes, but sandbox was a much much later addition [21:03:44] 3MediaWiki / 3Logging: Log entries generated by extensions that are later removed appear malformed - 10https://bugzilla.wikimedia.org/62722#c4 (10PiRSquared17) (In reply to writ.keeper.enwp from comment #3) > More examples (from > https://en.wikipedia.org/w/index.php?title=Special:Log&user=Grfr12345): > > 0... [21:06:18] bd808 + yurikR + ori: back from lunch. what do you think about a setup script for initial configuration and plugin installation for new devs? [21:06:42] re: mediawiki-vagrant [21:09:43] (03PS2) 10EBernhardson: Prevent double encoding of post content in history/rc [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141568 [21:09:46] (03PS2) 10EBernhardson: Adjust handling of user content in i18n parameters [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141562 [21:12:27] (03CR) 10Chad: "labs-vagrant is silly then if it relies on a broken script." [core] - 10https://gerrit.wikimedia.org/r/141559 (owner: 10Chad) [21:15:09] marxarelli: I think I'd be happy with an "installer" script. [21:15:14] (03PS2) 10Krinkle: qunit.completenessTest: Don't break mw.log methods [core] - 10https://gerrit.wikimedia.org/r/140651 [21:15:23] (03PS3) 10Krinkle: qunit.completenessTest: Suppress mw.log.warn in walkTheObject [core] - 10https://gerrit.wikimedia.org/r/140652 [21:16:05] (03PS1) 10EBernhardson: Eat all artificial whitespace in