[00:03:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: ApiExpandTemplates: Start parse before creating frame [core] - 10https://gerrit.wikimedia.org/r/140431 (https://bugzilla.wikimedia.org/66798) (owner: 10Anomie)
[00:04:26] <grrrit-wm>	 (03CR) 10Swalling: "Just noting that no IE 6/7 support seems fine to me. Icons are enhancements to a button, not a requirement." [core] - 10https://gerrit.wikimedia.org/r/139368 (https://bugzilla.wikimedia.org/55535) (owner: 10Phuedx)
[00:06:11] <grrrit-wm>	 (03PS3) 10Brian Wolff: Workaround image magick issue with greyscale xcf files [core] - 10https://gerrit.wikimedia.org/r/138213 (https://bugzilla.wikimedia.org/66323) 
[00:07:06] <grrrit-wm>	 (03CR) 10Andrew Bogott: Add a role with a rough approximation of wikitech. (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/140828 (owner: 10Andrew Bogott)
[00:07:59] <wikibugs>	 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Run down scoring issue on nlwiki - 10https://bugzilla.wikimedia.org/59842#c2 (10Chad H.) I think this is better now. Top 6 results for Kil on nlwiki:  * Kil * Kil (plaats in Zweden) * Kil (water) * Kil (gemeente in Zweden) * Kil (Noorwegen) * Station Kil...
[00:08:38] <grrrit-wm>	 (03PS2) 10Mwalker: Massive Rewrite: Promises and better error handling [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/140867 
[00:08:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Massive Rewrite: Promises and better error handling [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/140867 (owner: 10Mwalker)
[00:09:04] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Fix regex syntax error test [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140845 (owner: 10Manybubbles)
[00:09:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix regex syntax error test [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140845 (owner: 10Manybubbles)
[00:09:44] <wikibugs>	 3MediaWiki extensions / 3Popups: Hovercards: Yet another flicker-issue when moving the mouse pointer between hovercard and link - 10https://bugzilla.wikimedia.org/66315 (10Quiddity)
[00:09:44] <wikibugs>	 3MediaWiki extensions / 3Popups: Hovercards: occasional single flicker for cards that overlap with the link (edge-case) - 10https://bugzilla.wikimedia.org/66240 (10Quiddity)
[00:10:14] <wikibugs>	 3MediaWiki extensions / 3Popups: Hovercards: increase delay to 500 ms - 10https://bugzilla.wikimedia.org/66301 (10Quiddity)
[00:10:14] <wikibugs>	 3MediaWiki extensions / 3Popups: Popups appear too quickly (resulting in a lot of accidental hovers) - 10https://bugzilla.wikimedia.org/64234 (10Quiddity)
[00:12:24] <grrrit-wm>	 (03PS1) 10Mattflaschen: Don't create duplicate edit topic forms, focus when form shown [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140872 
[00:15:15] <wikibugs>	 3MediaWiki extensions / 3Popups: Any Blue Links pointing to disambiguation are also empty cards - 10https://bugzilla.wikimedia.org/64708 (10Quiddity)
[00:15:15] <wikibugs>	 3MediaWiki extensions / 3Popups: Hovercards: Disambiguation text should not be displayed - 10https://bugzilla.wikimedia.org/63164 (10Quiddity)
[00:16:07] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Remove use of strencode() in buildLike() [core] - 10https://gerrit.wikimedia.org/r/138673 (owner: 10PleaseStand)
[00:16:13] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "Valid points... let's drop 5.3 for now" [core] - 10https://gerrit.wikimedia.org/r/140869 (owner: 10Ori.livneh)
[00:17:38] <grrrit-wm>	 (03PS1) 10Brian Wolff: Some doc fixes to MediaHandler. No code changes [core] - 10https://gerrit.wikimedia.org/r/140873 
[00:17:53] <grrrit-wm>	 (03PS3) 10Mwalker: Massive Rewrite: Promises and better error handling [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/140867 
[00:18:01] <grrrit-wm>	 (03PS9) 10Jdlrobson: Wire up close & open actions in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 (owner: 10Bsitu)
[00:18:55] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Wire up close & open actions in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 (owner: 10Bsitu)
[00:19:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Massive Rewrite: Promises and better error handling [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/140867 (owner: 10Mwalker)
[00:19:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove use of strencode() in buildLike() [core] - 10https://gerrit.wikimedia.org/r/138673 (owner: 10PleaseStand)
[00:20:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Travis CI: Drop 5.3 as a build target [core] - 10https://gerrit.wikimedia.org/r/140869 (owner: 10Ori.livneh)
[00:20:19] <grrrit-wm>	 (03PS4) 10Mwalker: Massive Rewrite: Promises and better error handling [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/140867 
[00:23:21] <grrrit-wm>	 (03CR) 10Bsitu: "Trying to get rid of MW_API in API response but then Jon submitted another patch that moved the template around a little bit. I will re-at" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 (owner: 10Bsitu)
[00:25:16] <grrrit-wm>	 (03PS10) 10Jdlrobson: Wire up close & open actions in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 (owner: 10Bsitu)
[00:25:43] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Wire up close & open actions in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 (owner: 10Bsitu)
[00:26:02] <grrrit-wm>	 (03PS1) 10Jdlrobson: Git: Treat compiled templates as binaries so we have nicer diffs [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140876 
[00:26:21] <grrrit-wm>	 (03PS2) 10Andrew Bogott: Add a role with a rough approximation of wikitech. [vagrant] - 10https://gerrit.wikimedia.org/r/140828 
[00:26:47] <grrrit-wm>	 (03PS11) 10Jdlrobson: Wire up close & open actions in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 (owner: 10Bsitu)
[00:28:16] <grrrit-wm>	 (03PS4) 10Chad: Add syntax to limit searches to the local wiki [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140567 (owner: 10Manybubbles)
[00:28:36] <grrrit-wm>	 (03CR) 10Andrew Bogott: "Max, regarding hosting the dump elsewhere: it could be, but it seems like that would add an awful lot of complexity..." [vagrant] - 10https://gerrit.wikimedia.org/r/140828 (owner: 10Andrew Bogott)
[00:28:45] <grrrit-wm>	 (03CR) 10Spage: [C: 04-1] "message improvements (I'll confirm with Violetto)." (032 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140854 (owner: 10Mattflaschen)
[00:31:39] <grrrit-wm>	 (03PS12) 10Jdlrobson: Wire up close & open actions in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 (owner: 10Bsitu)
[00:38:02] <grrrit-wm>	 (03PS1) 10Dduvall: Reimplemented ruby module to use distro packages [vagrant] - 10https://gerrit.wikimedia.org/r/140877 (https://bugzilla.wikimedia.org/66763) 
[00:39:28] <wikibugs>	 3Wikimedia / 3Deployment systems: i18n cache vs resourceloader race condition (RL message key empty) - 10https://bugzilla.wikimedia.org/66543#c3 (10Tisza Gergő) This happened again today. Touching did not help; clearCacheBlobs did. (Not sure it was the same issue though: last time it only affected one wiki,...
[00:40:29] <wikibugs>	 3MediaWiki extensions / 3Popups: Hovercards should always appear adjacent to the linked area (instead of relative to the mouse cursor) to prevent "dead" space between link and hovercard - 10https://bugzilla.wikimedia.org/66317#c2 (10Eduard Braun) Increasing the timing will surely make this issue less probabl...
[00:42:13] <grrrit-wm>	 (03CR) 10Jdlrobson: "This patch is pretty big any way you can break out into smaller chunks?" (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139016 (owner: 10EBernhardson)
[00:44:38] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Show an error to the user if the spamlist has no targets on it [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 (https://bugzilla.wikimedia.org/53970) (owner: 10Legoktm)
[00:44:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Show an error to the user if the spamlist has no targets on it [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 (https://bugzilla.wikimedia.org/53970) (owner: 10Legoktm)
[00:46:11] <grrrit-wm>	 (03PS2) 10Gergő Tisza: Some doc fixes to MediaHandler. No code changes [core] - 10https://gerrit.wikimedia.org/r/140873 (owner: 10Brian Wolff)
[00:47:00] <grrrit-wm>	 (03PS2) 10Jdlrobson: Avoid creating duplicate edit topic forms [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140872 (owner: 10Mattflaschen)
[00:47:46] <grrrit-wm>	 (03CR) 10Gergő Tisza: "PS2: just typo fixes" [core] - 10https://gerrit.wikimedia.org/r/140873 (owner: 10Brian Wolff)
[00:48:07] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] Some doc fixes to MediaHandler. No code changes [core] - 10https://gerrit.wikimedia.org/r/140873 (owner: 10Brian Wolff)
[00:48:17] <bawolff>	 tgr: thanks
[00:48:42] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] "I think this will need to be rewritten when https://gerrit.wikimedia.org/r/140272 gets merged to re-render the entire title bar partial ra" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140872 (owner: 10Mattflaschen)
[00:49:29] <tgr>	 bawolff: thank *you* for the patch :) more comments are always helpful
[00:50:49] <grrrit-wm>	 (03CR) 10Spage: [V: 032] "Test passes, thanks." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140827 (owner: 10Jdlrobson)
[00:51:06] <grrrit-wm>	 (03CR) 10Spage: [C: 032] "+2" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140827 (owner: 10Jdlrobson)
[00:51:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: Fix collapsing features tests [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140827 (owner: 10Jdlrobson)
[00:51:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Some doc fixes to MediaHandler. No code changes [core] - 10https://gerrit.wikimedia.org/r/140873 (owner: 10Brian Wolff)
[00:53:58] <wikibugs>	 3MediaWiki extensions / 3Popups: Hovercards: Only have Hovercards turned on for links to namespace 0 (mainspace) - 10https://bugzilla.wikimedia.org/63181 (10Quiddity)
[00:56:36] <grrrit-wm>	 (03PS1) 10Jack Phoenix: Don't call $this->getSkin() (too) many times, just use the existing $sk variable. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/140878 
[00:56:58] <grrrit-wm>	 (03CR) 10Jack Phoenix: [C: 032 V: 032] Don't call $this->getSkin() (too) many times, just use the existing $sk variable. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/140878 (owner: 10Jack Phoenix)
[00:57:14] <wikibugs>	 3MediaWiki extensions / 3Popups: Date of latest edit is not correct in the popup for user signatures - 10https://bugzilla.wikimedia.org/66525#c2 (10Quiddity) p:5Unprio>3Low s:5normal>3enhanc In the short-term, this will be solved via bug 63181 ("Only have Hovercards turned on for links to namespace 0...
[01:00:04] <grrrit-wm>	 (03PS1) 10Jack Phoenix: Use the available context instead of global state whereever possible. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/140879 
[01:00:20] <grrrit-wm>	 (03CR) 10Jack Phoenix: [C: 032 V: 032] Use the available context instead of global state whereever possible. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/140879 (owner: 10Jack Phoenix)
[01:02:15] <grrrit-wm>	 (03CR) 10Springle: [C: 031] Set MYSQLI_OPT_CONNECT_TIMEOUT in mysqli [core] - 10https://gerrit.wikimedia.org/r/140809 (owner: 10Aaron Schulz)
[01:04:43] <wikibugs>	 3MediaWiki / 3General/Unknown: bin/ulimit5.sh isn't UNIX compliant - 10https://bugzilla.wikimedia.org/44568#c9 (10Bawolff (Brian Wolff)) I was just talking to a user on irc who's using busybox, which doesn't have bash installed.  We should probably be checking if /bin/bash is executable (Sometimes bsds might...
[01:16:07] <grrrit-wm>	 (03CR) 10Spage: [C: 031] "Before this change, running `make compile-lightncandy` then `git diff` often reports spurious end-of-file changes, but at least I could se" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140876 (owner: 10Jdlrobson)
[01:16:29] <grrrit-wm>	 (03PS1) 10Brian Wolff: Only use limit.sh if /bin/bash executable, instead of if linux. [core] - 10https://gerrit.wikimedia.org/r/140880 
[01:17:28] <wikibugs>	 3MediaWiki / 3General/Unknown: bin/ulimit5.sh isn't UNIX compliant - 10https://bugzilla.wikimedia.org/44568#c10 (10Bawolff (Brian Wolff)) semi-related patchset https://gerrit.wikimedia.org/r/#/c/140880/
[01:17:41] <grrrit-wm>	 (03PS2) 10Spage: Git: Treat compiled templates as binaries so we have nicer diffs [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140876 (owner: 10Jdlrobson)
[01:18:17] <grrrit-wm>	 (03CR) 10Spage: [C: 031] "My PS2 just adds a comment and removes a blank line." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140876 (owner: 10Jdlrobson)
[01:29:05] <grrrit-wm>	 (03CR) 10TTO: "I've decided to get rid of inContentLanguage in this patch, as these are interface messages." [core] - 10https://gerrit.wikimedia.org/r/111390 (https://bugzilla.wikimedia.org/32189) (owner: 10TTO)
[01:29:38] <grrrit-wm>	 (03PS11) 10TTO: Allow interlanguage link prefixes that are not language codes [core] - 10https://gerrit.wikimedia.org/r/111390 (https://bugzilla.wikimedia.org/32189) 
[01:33:47] <grrrit-wm>	 (03PS3) 10Spage: Git: Treat compiled templates as binaries so we have nicer diffs [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140876 (owner: 10Jdlrobson)
[01:34:46] <grrrit-wm>	 (03CR) 10Spage: [C: 031] "Comments aren't allowed in .gitattributes :-(" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140876 (owner: 10Jdlrobson)
[01:36:57] <grrrit-wm>	 (03PS2) 10Tim Starling: Remove MWCryptHKDF test A.3 [core] - 10https://gerrit.wikimedia.org/r/140648 
[01:37:33] <grrrit-wm>	 (03Abandoned) 10Tim Starling: Remove MWCryptHKDF test A.3 [core] - 10https://gerrit.wikimedia.org/r/140648 (owner: 10Tim Starling)
[01:53:58] <grrrit-wm>	 (03PS13) 10Bsitu: Wire up close & open actions in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 
[02:00:03] <grrrit-wm>	 (03CR) 10Bsitu: [C: 04-1] "Patch set #13:" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 (owner: 10Bsitu)
[02:12:16] <grrrit-wm>	 (03PS1) 10Bsitu: Fix summarize - API handler param is changed [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140882 
[02:14:27] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032] Fix summarize - API handler param is changed [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140882 (owner: 10Bsitu)
[02:14:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix summarize - API handler param is changed [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140882 (owner: 10Bsitu)
[02:54:29] <wikibugs>	 3MediaWiki extensions / 3Popups: Hovercards: Only have Hovercards turned on for links to namespace 0 (mainspace) - 10https://bugzilla.wikimedia.org/63181#c11 (10Helder) What about the other content namespaces in $wgContentNamespaces?
[04:46:16] <wikibugs>	 3Wikimedia / 3Site requests: Run updateArticleCount.php on German Wikivoyage weekly - 10https://bugzilla.wikimedia.org/66867 (10RolandUnger) 3NEW p:3Unprio s:3normal a:3None Because of the major priority bug 40009/45269 (abuse of import feature) I ask to run InitStats maintenance script daily or at l...
[04:59:28] <wikibugs>	 3Wikimedia / 3Extension setup: Review and deploy the "In other projects sidebar" beta feature (part of WikiBase extension) - 10https://bugzilla.wikimedia.org/66226#c9 (10Greg Grossmeier) Just a nit-pick (as I'm updating the calendar, getting all the links lined up):  This new beta feature should be linked on...
[05:05:42] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Avoid double processing <video> tags in iframes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/140833 (owner: 10Brian Wolff)
[05:05:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Avoid double processing <video> tags in iframes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/140833 (owner: 10Brian Wolff)
[05:07:13] <wikibugs>	 3Wikimedia / 3Extension setup: Review and deploy the "In other projects sidebar" beta feature (part of Wikibase extension) - 10https://bugzilla.wikimedia.org/66226#c10 (10Kunal Mehta (Legoktm)) (In reply to Greg Grossmeier from comment #9)  > This new beta feature should be linked on the Beta Features page o...
[05:10:03] <grrrit-wm>	 (03CR) 10Gilles: [C: 04-1] Replace ExtractThumbParameters hook with parseParamString method (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/140870 (owner: 10Brian Wolff)
[05:15:01] <grrrit-wm>	 (03CR) 10Gilles: [C: 031] Do not require iiurlwidth when getting thumbnails. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/140864 (owner: 10Brian Wolff)
[05:25:47] <grrrit-wm>	 (03CR) 10Gilles: [C: 04-1] Adding basic functionality (033 comments) [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/140732 (owner: 10Rillke)
[05:29:25] <grrrit-wm>	 (03PS1) 10PleaseStand: Fix copy-paste error in wfIsConfiguredProxy() [core] - 10https://gerrit.wikimedia.org/r/140884 
[05:36:05] <grrrit-wm>	 (03PS3) 10Wctaiwan: [WIP] Various fixes [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/140691 
[05:36:14] <grrrit-wm>	 (03CR) 10Gilles: [C: 031] Workaround image magick issue with greyscale xcf files [core] - 10https://gerrit.wikimedia.org/r/138213 (https://bugzilla.wikimedia.org/66323) (owner: 10Brian Wolff)
[05:39:05] <grrrit-wm>	 (03CR) 10Legoktm: [WIP] Various fixes (031 comment) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/140691 (owner: 10Wctaiwan)
[05:45:15] <grrrit-wm>	 (03PS5) 10KartikMistry: Added initial debian packaging support [services/cxserver/deploy] - 10https://gerrit.wikimedia.org/r/140059 
[05:46:37] <grrrit-wm>	 (03CR) 10KartikMistry: "Exactly. I rebuilt and checked. Also fixed debhelper > 9 if we need debian/compat at 9 and we have debhelper > 9 already in Trusty." [services/cxserver/deploy] - 10https://gerrit.wikimedia.org/r/140059 (owner: 10KartikMistry)
[06:08:35] <grrrit-wm>	 (03PS4) 10Wctaiwan: [WIP] Various fixes [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/140691 
[06:20:02] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Fix copy-paste error in wfIsConfiguredProxy() [core] - 10https://gerrit.wikimedia.org/r/140884 (owner: 10PleaseStand)
[06:23:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix copy-paste error in wfIsConfiguredProxy() [core] - 10https://gerrit.wikimedia.org/r/140884 (owner: 10PleaseStand)
[06:39:04] <grrrit-wm>	 (03CR) 10Aude: [C: 032] Put wfDeprecated() on obsolete use of $wgSpecialPages [core] - 10https://gerrit.wikimedia.org/r/140751 (owner: 10MaxSem)
[06:42:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Put wfDeprecated() on obsolete use of $wgSpecialPages [core] - 10https://gerrit.wikimedia.org/r/140751 (owner: 10MaxSem)
[06:42:46] <MaxSem>	 thanks aude:)
[06:52:07] <grrrit-wm>	 (03CR) 10Alexandros Kosiaris: [C: 04-1] "GWicke, thanks for clearing the architecture stuff out. Absolute nitpicks this review cycle and I think this is good to go" (032 comments) [services/cxserver/deploy] - 10https://gerrit.wikimedia.org/r/140059 (owner: 10KartikMistry)
[06:52:51] <aude>	 :)
[06:57:13] <grrrit-wm>	 (03PS1) 10MaxSem: API: kill WDDX support [core] - 10https://gerrit.wikimedia.org/r/140886 
[06:57:22] <ori>	 hahaha
[06:57:33] <ori>	 MaxSem: i thought you meant "1 sec, let's think this through a little"
[06:57:36] <ori>	 not "1 sec, patch"
[06:58:29] <MaxSem>	 think?
[06:58:42] <grrrit-wm>	 (03PS1) 10Tpt: Fix a typo error in PageNumberTest [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/140887 
[07:00:32] <grrrit-wm>	 (03CR) 10Tpt: [C: 032] "Trivial change." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/140887 (owner: 10Tpt)
[07:00:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix a typo error in PageNumberTest [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/140887 (owner: 10Tpt)
[07:01:02] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] API: kill WDDX support [core] - 10https://gerrit.wikimedia.org/r/140886 (owner: 10MaxSem)
[07:02:14] <MaxSem>	 holy  cow! that crap lleaked even into tests! :P
[07:02:34] <ori>	 MaxSem: tests that fail with HHVM
[07:02:42] <ori>	 hence the patch
[07:03:59] <grrrit-wm>	 (03PS2) 10MaxSem: API: kill WDDX format support [core] - 10https://gerrit.wikimedia.org/r/140886 
[07:12:21] <grrrit-wm>	 (03CR) 10Divec: Remove old segmentation code, move the segmenters files (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/140664 (owner: 10Santhosh)
[07:15:42] <grrrit-wm>	 (03CR) 10Santhosh: Remove old segmentation code, move the segmenters files (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/140664 (owner: 10Santhosh)
[07:35:32] <grrrit-wm>	 (03PS10) 1001tonythomas: Added Table to store email-hash mappings ( EXPERIMENTAL ) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/140330 
[07:40:01] <grrrit-wm>	 (03PS11) 1001tonythomas: Added Table to store email-hash mappings ( EXPERIMENTAL ) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/140330 
[07:40:55] <grrrit-wm>	 (03CR) 10Nemo bis: "uuuuh" (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140866 (https://bugzilla.wikimedia.org/66829) (owner: 10Chad)
[08:05:31] <grrrit-wm>	 (03PS2) 10Rillke: Adding basic functionality [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/140732 
[08:05:46] <grrrit-wm>	 (03CR) 10Rillke: Adding basic functionality (033 comments) [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/140732 (owner: 10Rillke)
[08:09:16] <grrrit-wm>	 (03PS6) 10KartikMistry: Added initial debian packaging support [services/cxserver/deploy] - 10https://gerrit.wikimedia.org/r/140059 
[08:12:00] <grrrit-wm>	 (03CR) 10KartikMistry: Added initial debian packaging support (031 comment) [services/cxserver/deploy] - 10https://gerrit.wikimedia.org/r/140059 (owner: 10KartikMistry)
[08:14:12] <grrrit-wm>	 (03PS1) 10Legoktm: Add GlobalPreferences.alias.php [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/140894 
[08:16:34] <grrrit-wm>	 (03CR) 10Paladox: mediawiki.searchSuggest: Enable for iPhone and iPod touch [core] - 10https://gerrit.wikimedia.org/r/139809 (owner: 10Paladox)
[08:16:45] <grrrit-wm>	 (03CR) 10Paladox: [C: 031] mediawiki.searchSuggest: Enable for iPhone and iPod touch [core] - 10https://gerrit.wikimedia.org/r/139809 (owner: 10Paladox)
[08:16:47] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Add GlobalPreferences.alias.php [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/140894 (owner: 10Legoktm)
[08:16:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add GlobalPreferences.alias.php [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/140894 (owner: 10Legoktm)
[08:19:50] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 031] mediawiki.searchSuggest: Enable for iPhone and iPod touch [core] - 10https://gerrit.wikimedia.org/r/139809 (owner: 10Paladox)
[08:19:54] <grrrit-wm>	 (03PS3) 10Rillke: Adding basic functionality [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/140732 
[08:23:34] <grrrit-wm>	 (03PS1) 10Legoktm: Make the central wiki's API url configurable [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/140895 
[08:24:27] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 031] Set MYSQLI_OPT_CONNECT_TIMEOUT in mysqli [core] - 10https://gerrit.wikimedia.org/r/140809 (owner: 10Aaron Schulz)
[08:26:13] <wikibugs>	 3MediaWiki extensions / 3RandomRootPage: [[Special:RandomRootPage/]] returns also from other namespace than main only - 10https://bugzilla.wikimedia.org/46420#c3 (10Neil Babbage) I am having a problem with randomrootpage on en.wikibooks where it has started to behave the same way as [[Special:Random]] return...
[08:29:12] <grrrit-wm>	 (03CR) 10Rillke: Adding basic functionality (031 comment) [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/140732 (owner: 10Rillke)
[08:33:43] <grrrit-wm>	 (03CR) 10devunt: "So what is the right-way to implementing this?" [core] - 10https://gerrit.wikimedia.org/r/140276 (https://bugzilla.wikimedia.org/66646) (owner: 10devunt)
[08:43:28] <wikibugs>	 3MediaWiki extensions / 3CodeEditor: CodeEditor's drag and drop only works after a small delay - 10https://bugzilla.wikimedia.org/60432#c7 (10Derk-Jan Hartman) i still need to wrap this in some platform dependent if constructs.
[08:43:54] <grrrit-wm>	 (03CR) 10TheDJ: [C: 04-1] "I need to make this vary across platforms (or make sure that upstream does that...)" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/121044 (https://bugzilla.wikimedia.org/60432) (owner: 10TheDJ)
[08:46:28] <thedj>	 did anyone work with git subtree's ?
[08:47:33] <grrrit-wm>	 (03CR) 10Gilles: Adding basic functionality (031 comment) [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/140732 (owner: 10Rillke)
[08:48:16] <wikibugs>	 3MediaWiki extensions / 3GlobalPreferences: The "Use this preference on all wikis" lines are unclearly associated - 10https://bugzilla.wikimedia.org/66869 (10Quiddity) 3NEW p:3Unprio s:3enhanc a:3None Created attachment 15687   --> https://bugzilla.wikimedia.org/attachment.cgi?id=15687&action=edit mo...
[08:50:59] <grrrit-wm>	 (03CR) 10Gilles: Adding basic functionality (031 comment) [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/140732 (owner: 10Rillke)
[08:53:35] <grrrit-wm>	 (03CR) 10Gilles: Adding basic functionality (032 comments) [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/140732 (owner: 10Rillke)
[08:56:58] <wikibugs>	 3MediaWiki extensions / 3Nuke: In MW 1.23 some php and xml files are having executable rights - 10https://bugzilla.wikimedia.org/66182#c6 (10Seb35) Reedy fixed this bug in core REL1_23 and master, and in Nuke master. Should it be fixed also in REL1_22 and in REL1_19?
[09:28:25] <grrrit-wm>	 (03PS3) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/139831 
[09:35:29] <grrrit-wm>	 (03CR) 10Jack Phoenix: [C: 032 V: 032] Make the central wiki's API url configurable [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/140895 (owner: 10Legoktm)
[09:47:44] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: Call to undefined method Wikibase\EntityContentFactory::newContentFromEntity() in EditEntity.php on line 753 - 10https://bugzilla.wikimedia.org/65726 (10Thiemo Mättig)
[09:47:44] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: run phpunit (on jenkins) on EditFilterMergedContent handling code in EditEntity - 10https://bugzilla.wikimedia.org/65727 (10Thiemo Mättig)
[10:01:06] <grrrit-wm>	 (03PS2) 10Krinkle: jshint: use '===' to compare with '' [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/137894 (owner: 10Hashar)
[10:01:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] jshint: use '===' to compare with '' [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/137894 (owner: 10Hashar)
[10:04:01] <wikibugs>	 3MediaWiki / 3API: Allow registration of API modules and special pages as a factory function. - 10https://bugzilla.wikimedia.org/66870 (10Daniel Kinzler) 3NEW p:3Unprio s:3normal a:3None Currently, API modules and special pages are registered using class names, and instantiated with a fixed set of pa...
[10:16:58] <wikibugs>	 3MediaWiki extensions / 3BookManagerv2: Larger text-area for description field in metadata instead of textbox - 10https://bugzilla.wikimedia.org/65295 (10Nemo)
[10:20:44] <grrrit-wm>	 (03CR) 10Nemo bis: Show only subpage title in section list for sections without label (031 comment) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/140694 (https://bugzilla.wikimedia.org/66788) (owner: 10Deepali)
[10:21:28] <wikibugs>	 3MediaWiki extensions / 3SemanticForms: After upgrading to MW 1.23 forms fail to open properly - 10https://bugzilla.wikimedia.org/64049#c5 (10Long) I'm getting the same error in MW 1.23, SF 2.7, SMW 1.9.2.  Saving the edit seems to work fine though.  Any update for this bug?  Thanks,  Long
[10:24:27] <grrrit-wm>	 (03PS3) 10Krinkle: Add jshintrc and make it pass [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/137894 (owner: 10Hashar)
[10:35:01] <wikibugs>	 3Wikimedia / 3Site requests: Changing the technical rights on ruwiki - 10https://bugzilla.wikimedia.org/66871 (10MaxBioHazard) 3NEW p:3Unprio s:3normal a:3None Please, 1) remove right "move-categorypages" from "users" group, add this right to "editors" and "suppressredirect" groups 2) add "suppressre...
[10:37:15] <grrrit-wm>	 (03PS1) 10SG: Fix preview [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 
[10:38:00] <grrrit-wm>	 (03CR) 10Krinkle: [C: 031] Add jshintrc and make it pass [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/137894 (owner: 10Hashar)
[10:40:48] <grrrit-wm>	 (03CR) 10SG: "Yes, I am aware this is a monolithic patch. Essentially, what this does is change the entire logic of preview to use data attrs, and allow" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG)
[10:42:22] <grrrit-wm>	 (03PS2) 10SG: Fix preview [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 
[10:45:01] <grrrit-wm>	 (03PS5) 10Wctaiwan: [WIP] Various fixes [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/140691 
[10:45:43] <grrrit-wm>	 (03PS2) 10Prtksxna: [wip] Add settings [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140086 
[10:45:43] <wikibugs>	 3MediaWiki extensions / 3ParserFunctions: ifexist function uses pagelinks table in lieu of better options - 10https://bugzilla.wikimedia.org/12019#c15 (10Jan Zerebecki) Yes you are right, there are ways to do that without interrupting availability. Another possible one is to first create the new table, then...
[10:45:45] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [wip] Add settings [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140086 (owner: 10Prtksxna)
[10:51:11] <grrrit-wm>	 (03PS4) 10Rillke: Adding basic functionality [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/140732 
[10:53:11] <grrrit-wm>	 (03CR) 10Rillke: Adding basic functionality (033 comments) [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/140732 (owner: 10Rillke)
[10:54:25] <grrrit-wm>	 (03PS3) 10SG: Fix preview [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 
[10:54:43] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix preview [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG)
[10:55:03] <grrrit-wm>	 (03PS5) 10Rillke: Adding basic functionality [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/140732 
[11:01:16] <wikibugs>	 3Wikimedia / 3Site requests: Changing the technical rights on ruwiki - 10https://bugzilla.wikimedia.org/66871 (10Tomasz W. Kozlowski) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3enhanc a:3Tomasz W. Kozlowski
[11:03:52] <grrrit-wm>	 (03CR) 10SG: "1. I don’t know what to put instead of a green border. Right now, the preview has @colorConstructive around it, but I'm sure we can come u" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG)
[11:06:44] <wikibugs>	 3MediaWiki / 3API: Allow registration of API modules and special pages as a factory function. - 10https://bugzilla.wikimedia.org/66870 (10Lydia Pintscher) p:5Unprio>3High
[11:09:12] <grrrit-wm>	 (03CR) 10Matthias Mullie: "1. Maybe just render as-is (looking like any other post), but having a tooltip (similar to "you are not logged in") to the side informing " [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG)
[11:16:08] <grrrit-wm>	 (03PS4) 10SG: Fix preview [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 
[11:22:46] <grrrit-wm>	 (03PS5) 10Matthias Mullie: Fix preview [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG)
[11:38:13] <wikibugs>	 3MediaWiki / 3General/Unknown: Update branches in mediawiki/extensions/* for REL1_23 - 10https://bugzilla.wikimedia.org/64157#c13 (10Andre Klapper) Greg / hexmode / Markus:  Will anybody fix this? It's been open for two months and creates followup issues, confusion, brokenness (bug 66866).
[11:38:58] <wikibugs>	 3MediaWiki extensions / 3Math: Add Selenium for Math extension - 10https://bugzilla.wikimedia.org/64151#c1 (10Željko Filipin) We already have one test:  https://github.com/wikimedia/qa-browsertests/blob/master/tests/browser/features/math.feature
[11:40:15] <wikibugs>	 3MediaWiki extensions / 3Nuke: In MW 1.23 some php and xml files are having executable rights - 10https://bugzilla.wikimedia.org/66182#c7 (10Andre Klapper) 5PATC>3RESO/FIX All patches merged for 1.23 and 1.24, closing as RESOLVED FIXED.  (In reply to Seb35 from comment #6) > Reedy fixed this bug in core...
[11:43:21] <grrrit-wm>	 (03PS6) 10Wctaiwan: Various fixes and improvements [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/140691 
[11:48:14] <grrrit-wm>	 (03PS7) 10Wctaiwan: Various fixes and improvements [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/140691 
[11:54:22] <grrrit-wm>	 (03PS3) 10Florianschmidtwelzow: Show Captcha after click on edit over buttons on EditPage [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/136323 (https://bugzilla.wikimedia.org/65913) 
[11:54:46] <grrrit-wm>	 (03PS17) 10Paladox: mediawiki.searchSuggest: Enable for iPhone and iPod touch [core] - 10https://gerrit.wikimedia.org/r/139809 
[11:55:02] <grrrit-wm>	 (03PS18) 10Paladox: mediawiki.searchSuggest: Enable for iPhone and iPod touch [core] - 10https://gerrit.wikimedia.org/r/139809 
[11:55:51] <grrrit-wm>	 (03PS1) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/140905 
[12:03:24] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] Show Captcha after click on edit over buttons on EditPage (032 comments) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/136323 (https://bugzilla.wikimedia.org/65913) (owner: 10Florianschmidtwelzow)
[12:09:43] <grrrit-wm>	 (03PS1) 10Gerrit Patch Uploader: mediawiki.user: Simplify callback [core] - 10https://gerrit.wikimedia.org/r/140906 
[12:09:45] <grrrit-wm>	 (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/140906 (owner: 10Gerrit Patch Uploader)
[12:10:46] <wikibugs>	 3MediaWiki extensions / 3GlobalCssJs: Links to global user-css/js should not use localized namespace-name - 10https://bugzilla.wikimedia.org/66873 (10se4598) 3NEW p:3Unprio s:3normal a:3None > http://de.wikipedia.beta.wmflabs.org/wiki/Spezial:Einstellungen#mw-prefsection-rendering links to > http://m...
[12:11:14] <grrrit-wm>	 (03PS2) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/140338 
[12:17:31] <grrrit-wm>	 (03PS6) 10SG: Fix preview [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 
[12:19:14] <wikibugs>	 3Wikimedia / 3General/Unknown: Video scalers don't seem to be scaling videos anymore - 10https://bugzilla.wikimedia.org/66627#c3 (10Tomasz W. Kozlowski) https://wikitech.wikimedia.org/wiki/Incident_documentation/20140613-Videoscalers
[12:19:59] <grrrit-wm>	 (03CR) 10SG: "1. Solved. Now has a tooltip below it indicating that it is a preview." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG)
[12:34:30] <grrrit-wm>	 (03PS1) 10Se4598: use non-localized namespace for links to global user-css/js [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/140907 (https://bugzilla.wikimedia.org/66873) 
[12:34:32] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] use non-localized namespace for links to global user-css/js [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/140907 (https://bugzilla.wikimedia.org/66873) (owner: 10Se4598)
[12:34:34] <grrrit-wm>	 (03PS7) 10SG: Fix preview [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 
[12:36:28] <se4598>	 hey, is jenkins behaving odd?
[12:37:14] <wikibugs>	 3Wikimedia / 3Mailing lists: african-wikimedians - 10https://bugzilla.wikimedia.org/65959#c7 (10Tomasz W. Kozlowski) Bump — have an e-mail.
[12:38:52] <grrrit-wm>	 (03CR) 10Se4598: "not tested, but should be ok." [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/140907 (https://bugzilla.wikimedia.org/66873) (owner: 10Se4598)
[12:40:18] <grrrit-wm>	 (03PS8) 10SG: Fix preview [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 
[12:40:46] <grrrit-wm>	 (03CR) 10SG: "4. Solved." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG)
[12:43:39] <grrrit-wm>	 (03CR) 10SG: "Decided against #5. Click-to-edit will interfere with being able to copy the HTML. Potentially super annoying." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG)
[12:53:11] <MatmaRex>	 se4598: it always is
[12:53:17] <MatmaRex>	 !bug hash-mismatch | se4598
[12:53:18] <wm-bot>	 se4598: https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=hash-mismatch+
[12:55:42] <se4598>	 MatmaRex: mh, thanks. That wasn't known to me. So submit again?
[12:56:27] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "recheck" [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/140907 (https://bugzilla.wikimedia.org/66873) (owner: 10Se4598)
[12:56:34] <MatmaRex>	 just do this ^ and jenkins will try again
[12:57:24] <se4598>	 I submit too few patches :)
[12:57:28] <se4598>	 thanks
[13:10:31] <wikibugs>	 3Wikimedia / 3Bugzilla: Component for Erwin's tools - 10https://bugzilla.wikimedia.org/66875 (10Andre Koopal) 3NEW p:3Unprio s:3normal a:3None The tools of Erwin85 were partly migrated to toollabs from toolserver (https://tools.wmflabs.org/erwin85/). I myself fixed related changes, and when time (per...
[13:12:23] <grrrit-wm>	 (03CR) 10Hashar: [C: 031] "All good. Letting UltrasonicNXT or Jack Phoenix to approve the change." [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/137894 (owner: 10Hashar)
[13:26:45] <wikibugs>	 3Wikimedia / 3Bugzilla: Component for Erwin's tools - 10https://bugzilla.wikimedia.org/66875#c1 (10Tyler Romeo) 5NEW>3RESO/FIX p:5Unprio>3Normal a:3Tyler Romeo Done. I'm not sure if the five unresolved issues on JIRA are still applicable, so I'll leave it up to you to determine that and re-enter th...
[13:29:04] <grrrit-wm>	 (03PS1) 10Aude: Add extensions to phpunit code coverage whitelist filter [core] - 10https://gerrit.wikimedia.org/r/140909 
[13:34:43] <wikibugs>	 3MediaWiki extensions / 3ParserFunctions: ifexist function uses pagelinks table in lieu of better options - 10https://bugzilla.wikimedia.org/12019#c16 (10Tyler Romeo) Well just to be clear, if we're going to be making any schema changes, we are not just going to randomly add a link type field to the pagelink...
[13:36:44] <grrrit-wm>	 (03CR) 10Matthias Mullie: Fix preview (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG)
[13:40:44] <wikibugs>	 3Wikimedia / 3Site requests: Changing the technical rights on ruwiki - 10https://bugzilla.wikimedia.org/66871#c2 (10Tomasz W. Kozlowski) The patch will have to wait until Monday to be deployed as we generally do not deploy new software or configuration changes on Fridays.    I will add it to the Monday morni...
[14:04:14] <wikibugs>	 3MediaWiki extensions / 3RandomRootPage: [[Special:RandomRootPage/]] returns also from other namespace than main only - 10https://bugzilla.wikimedia.org/46420#c4 (10Neil Babbage) Problem appears to have started at en.wikibooks following the deployment of 1.24/wmf9
[14:09:13] <wikibugs>	 3MediaWiki extensions / 3RandomRootPage: [[Special:RandomRootPage/]] returns also from other namespace than main only - 10https://bugzilla.wikimedia.org/46420#c5 (10Sam Reed (reedy)) I guess the problem is that we're not using ElasticSearch to do the randomness.  Meaning the SQL query, and as such, the amend...
[14:10:30] <wikibugs>	 3MediaWiki extensions / 3RandomRootPage: [[Special:RandomRootPage/]] returns also from other namespace than main only - 10https://bugzilla.wikimedia.org/46420#c6 (10Sam Reed (reedy)) (In reply to Sam Reed (reedy) from comment #5) > I guess the problem is that we're not using ElasticSearch to do the > randomn...
[14:10:31] <wikibugs>	 3MediaWiki extensions / 3RandomRootPage: [[Special:RandomRootPage/]] returns also from other namespace than main only - 10https://bugzilla.wikimedia.org/66879 (10Bawolff (Brian Wolff)) 3NEW p:3Unprio s:3minor a:3Huji +++ This bug was initially created as a clone of Bug #46420 +++  [[Special:RandomRoo...
[14:11:28] <wikibugs>	 3MediaWiki extensions / 3RandomRootPage: [[Special:RandomRootPage/]] returns also from other namespace than main only - 10https://bugzilla.wikimedia.org/46420#c7 (10Bawolff (Brian Wolff)) (In reply to billinghurst from comment #2) > [[Special:Random]] is definitely problematic at this time (for English > Wik...
[14:12:58] <wikibugs>	 3MediaWiki extensions / 3RandomRootPage: [[Special:RandomRootPage/]] returns also from other namespace than main only - 10https://bugzilla.wikimedia.org/66879#c1 (10Sam Reed (reedy)) From bug 46420  (In reply to Sam Reed (reedy) from comment #5) > I guess the problem is that we're now using ElasticSearch to...
[14:14:06] <bawolff>	 What's the benefit for using elastic search for random pages anyways?
[14:15:14] <wikibugs>	 3MediaWiki extensions / 3RandomRootPage: [[Special:RandomRootPage/]] returns also from other namespace than main only - 10https://bugzilla.wikimedia.org/46420#c8 (10Sam Reed (reedy)) For the original problem...  $this->namespaces = MWNamespace::getContentNamespaces();   Just need to modify $this->namespaces...
[14:15:22] <Reedy>	 The idea was trying to make it more random than wfRandom()
[14:16:05] <bawolff>	 Extra Random!
[14:16:18] <Reedy>	 People always complained it sucked
[14:16:55] <bawolff>	 People wouldn't know randomness if it came up behind them and randomly tripped them
[14:19:31] <wikibugs>	 3MediaWiki extensions / 3Translate: [PagePreparation] Categories should be a part of page template and tagged with {{translation}} - 10https://bugzilla.wikimedia.org/66880 (10Pratik Lahoti) 3NEW p:3Unprio s:3normal a:3None Categories present in the page should be excluded from appearing at Special:Tr...
[14:19:31] <marktraceur>	 wfActuallyRandom()
[14:20:15] <wikibugs>	 3MediaWiki extensions / 3Translate: [PagePreparation] Categories should be a part of page template and tagged with {{translation}} - 10https://bugzilla.wikimedia.org/66880 (10Pratik Lahoti) a:3Pratik Lahoti
[14:21:12] <bawolff>	 I heard a rumour once that apple took the random number generator out of itunes because people thought the bad pseudorandom number generator was more random
[14:21:39] <Reedy>	 wfxkcdRandom()
[14:21:43] <wikibugs>	 3MediaWiki extensions / 3Math: Add Selenium for Math extension - 10https://bugzilla.wikimedia.org/64151#c2 (10Chris McMahon) And that test finds bugs:   https://bugzilla.wikimedia.org/show_bug.cgi?id=60486 https://bugzilla.wikimedia.org/show_bug.cgi?id=59777
[14:22:44] <Nemo_bis>	 is wfActuallyRandom() powered by brion's server kittens?
[14:23:08] <Nemo_bis>	 or did they invent some non-vivisection alternatives by now
[14:24:04] <Nemo_bis>	 bawolff: there are some who want random to be non-random https://bugzilla.wikimedia.org/show_bug.cgi?id=66142
[14:25:07] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Add username as placeholder [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140912 
[14:25:16] <Vulpix>	 create wfTrueRandom() :)
[14:26:16] <grrrit-wm>	 (03PS1) 10Chad: SearchResultSet: remove hasResults(), unused [core] - 10https://gerrit.wikimedia.org/r/140913 
[14:26:43] <wikibugs>	 3MediaWiki / 3General/Unknown: Replace Special:Random with pseudo-random - 10https://bugzilla.wikimedia.org/66142#c6 (10Bawolff (Brian Wolff)) Just a point of note here, the existing random function is pseudo random.  I agree with Nemo here. Well a "randomly related" feature might be cool, I think the use ca...
[14:26:47] <grrrit-wm>	 (03CR) 10Chad: "This has the nice side effect of making SearchNearMatchResultSet::numRows() actually work." [core] - 10https://gerrit.wikimedia.org/r/140913 (owner: 10Chad)
[14:27:17] <bawolff>	 Nemo_bis: Is it just me, or is 90% of the bugs Jared files "Replace feature in core that does X with something that does Y, even though X and Y are totally different use cases"
[14:28:17] <wikibugs>	 3MediaWiki / 3API: Fatal error:  Call to a member function getPrefixedText() on a non-object in LuaCommon.php on line 419 - 10https://bugzilla.wikimedia.org/66798#c4 (10Brad Jorsch) 5PATC>3ASSI I've scheduled the fix for backport to the wmf branches during Monday morning's SWAT window.
[14:28:45] <grrrit-wm>	 (03PS1) 10Chad: Remove hasResults() implementation per Ia04bd3fc [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140914 
[14:29:52] <grrrit-wm>	 (03PS1) 10Brian Wolff: Don't override Special:Random if $extra is set [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140915 (https://bugzilla.wikimedia.org/66879) 
[14:30:03] <Nemo_bis>	 bawolff: well, I can't speak of a general pattern but that's an accurate description of the bug in question :P
[14:30:23] <bawolff>	 Nemo_bis: Well he also wanted to replace Special:Whatlinkshere with search results
[14:30:39] <Nemo_bis>	 To be fair, his point is that Special:Random has an high visibility in sidebar but may not do what users actually expect
[14:31:20] <Nemo_bis>	 So if he's right we have quite a crowd of confused people :) http://stats.grok.se/en/latest90/Special:Random
[14:32:57] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Don't override Special:Random if $extra is set [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140915 (https://bugzilla.wikimedia.org/66879) (owner: 10Brian Wolff)
[14:33:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't override Special:Random if $extra is set [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140915 (https://bugzilla.wikimedia.org/66879) (owner: 10Brian Wolff)
[14:37:37] <grrrit-wm>	 (03CR) 10Daniel Kinzler: "@Thiemo: no, it's not a known unknown, but an unknown unknown :P" [core] - 10https://gerrit.wikimedia.org/r/139115 (owner: 10Thiemo Mättig (WMDE))
[14:38:18] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 032] Update documentation of what a "section" is [core] - 10https://gerrit.wikimedia.org/r/139115 (owner: 10Thiemo Mättig (WMDE))
[14:39:28] <wikibugs>	 3MediaWiki extensions / 3Popups: Popups appear too quickly (resulting in a lot of accidental hovers) - 10https://bugzilla.wikimedia.org/64234#c6 (10Bartosz Dziewoński) (In reply to Quiddity from comment #4) > and other people use a wide range of numbers - as I wrote months ago, on the > archived talkpage: >...
[14:39:45] <wikibugs>	 3MediaWiki extensions / 3Popups: Hovercards: increase delay to 500 ms - 10https://bugzilla.wikimedia.org/66301#c1 (10Bartosz Dziewoński) 5NEW>3RESO/DUP   *** This bug has been marked as a duplicate of bug 64234 ***
[14:39:45] <wikibugs>	 3MediaWiki extensions / 3Popups: Popups appear too quickly (resulting in a lot of accidental hovers) - 10https://bugzilla.wikimedia.org/64234#c7 (10Bartosz Dziewoński) *** Bug 66301 has been marked as a duplicate of this bug. ***
[14:42:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update documentation of what a "section" is [core] - 10https://gerrit.wikimedia.org/r/139115 (owner: 10Thiemo Mättig (WMDE))
[14:42:43] <wikibugs>	 3MediaWiki extensions / 3RandomRootPage: [[Special:RandomRootPage/]] returns also from other namespace than main only - 10https://bugzilla.wikimedia.org/66879#c4 (10Bawolff (Brian Wolff)) 5PATC>3RESO/FIX (In reply to Gerrit Notification Bot from comment #3) > Change 140915 merged by jenkins-bot: > Don't...
[14:43:32] <bawolff>	 oh ugh, I massively screwed up splitting that bug
[14:44:14] <wikibugs>	 3MediaWiki extensions / 3Translate: [PagePreparation] Categories should be a part of page template and tagged with {{translation}} - 10https://bugzilla.wikimedia.org/66880 (10Nemo)
[14:44:15] <wikibugs>	 3MediaWiki extensions / 3Translate: Special page for migration of legacy translation pages (tracking) - 10https://bugzilla.wikimedia.org/65740 (10Nemo)
[14:45:29] <wikibugs>	 3MediaWiki extensions / 3RandomRootPage: [[Special:RandomRootPage]] returning pages that are subpages due to overriding from elastic search - 10https://bugzilla.wikimedia.org/66879 (10Bawolff (Brian Wolff))
[14:45:58] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: Fatal error: Call to undefined method Wikibase\Api\EditEntity::setTitle() in Wikibase\EditEntity - 10https://bugzilla.wikimedia.org/66842 (10Aude) 5PATC>3RESO/FIX
[14:47:32] <grrrit-wm>	 (03PS1) 10Brian Wolff: Allow specifying a random page only in main namespace [core] - 10https://gerrit.wikimedia.org/r/140916 (https://bugzilla.wikimedia.org/46420) 
[14:48:55] <^d>	 bawolff: I should see what other hooks Cirrus can implement like random.
[14:49:08] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Raise popup show/hide delay to 500ms/300ms, respectively [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140917 (https://bugzilla.wikimedia.org/64234) 
[14:49:20] <bawolff>	 I don't think there's all that many other similar things
[14:49:22] <^d>	 So Cirrus will slowly reach its tentacles into all portions of MW and infect everything!
[14:49:26] <^d>	 bawahahahahaha
[14:49:59] <wikibugs>	 3MediaWiki extensions / 3Popups: Sometimes (hard to reproduce) the popup stays visible when it should be hidden (user dehovered the link) - 10https://bugzilla.wikimedia.org/64242#c3 (10Bartosz Dziewoński) 5NEW>3RESO/WOR I can't reproduce this anymore.
[14:51:43] <wikibugs>	 3MediaWiki extensions / 3Popups: Popups: "mw.Api error: " "http" {xhr: Object, textStatus: "abort", exception: "abort"} - 10https://bugzilla.wikimedia.org/65442 (10Bartosz Dziewoński) 5PATC>3RESO/FIX
[14:52:44] <wikibugs>	 3MediaWiki extensions / 3Popups: Popups mwe-popups-animation() duplicates core .animation() mixin - 10https://bugzilla.wikimedia.org/65923 (10Bartosz Dziewoński) 5PATC>3RESO/FIX
[14:58:10] <bawolff>	 Hmm, would it make sense to have special:random take a comma separated list of namespaces - Special:Random/help,file
[15:01:30] <wikibugs>	 3MediaWiki / 3General/Unknown: Implement 'related random' functionality that shows users a random page related to the current page - 10https://bugzilla.wikimedia.org/66142 (10Yuvi Panda)
[15:02:13] <wikibugs>	 3MediaWiki / 3General/Unknown: Implement 'related random' functionality that shows users a random page related to the current page - 10https://bugzilla.wikimedia.org/66142#c7 (10Yuvi Panda) Edited title to be less controversial, since I think this would be useful feature. I also personally don't think it sho...
[15:02:59] <YuviPanda|zzz>	 Nemo_bis: ^ should be less controversial, I don't think the bug in this new form is a WONTFIX
[15:04:17] <bawolff>	 YuviPanda: I agree it'd be cool. Special:Random is also cool :)
[15:04:33] <YuviPanda>	 bawolff: I agree. I don't think we should remove Special:Random
[15:04:43] <YuviPanda>	 'we can do better' is not an argument for 'let us remove useful things now'
[15:05:09] <YuviPanda>	 bawolff: if you look at the script that was pointed at in #c0, it adds ugly buttons next to the title to show a 'related' random, which uses stupid heuristics clientside
[15:05:35] <YuviPanda>	 like RandomInCategory/<Random-Category-of-Current-Page> or just picking an outgoing link randomly and showing htat
[15:06:59] <wikibugs>	 3MediaWiki extensions / 3Translate: Invalid transclusion of Special:LanguageStats needs to degrade gracefully - 10https://bugzilla.wikimedia.org/62125#c3 (10Aude) Exception from line 6299 of /usr/local/apache/common-local/php-1.24wmf9/includes/parser/Parser.php: Parser state cleared while parsing. Did you ca...
[15:07:58] <wikibugs>	 3MediaWiki extensions / 3Translate: Recursive parser calls - 10https://bugzilla.wikimedia.org/65826#c11 (10Aude) related or duplicate of https://bugzilla.wikimedia.org/show_bug.cgi?id=62125 ?
[15:08:13] <wikibugs>	 3MediaWiki extensions / 3RandomRootPage: [[Special:RandomRootPage/]] returns also from other namespace than main only - 10https://bugzilla.wikimedia.org/46420#c10 (10Bawolff (Brian Wolff)) I also just discovered that doing Special:RandomRootPage/main should also work (and has for quite a while).
[15:09:33] <YuviPanda>	 bawolff: we have a 'randomrootpage' extension!?
[15:09:47] <bawolff>	 YuviPanda: Only on Wikibooks
[15:09:51] <YuviPanda>	 aah
[15:09:54] <YuviPanda>	 makes sehnse
[15:10:09] <bawolff>	 Wikibooks has a lot of subpages (for their book structure), so they wanted a "random book" feature
[15:11:47] <YuviPanda>	 right
[15:12:03] <bawolff>	 YuviPanda: Hmm, actually its on all sister projects, just not wikipedias
[15:12:15] <YuviPanda>	 hm, doesn't make too much sense on wiki I think
[15:12:24] <Vulpix>	 ah, wikibooks! I remember creating a JavaScript thing to provide that functionality client-side several years ago on es.wikibooks :)
[15:12:50] <bawolff>	 YuviPanda: Probably not, but its also probably really cheap on wikipedia
[15:13:02] <bawolff>	 Given subpages are barely a thing comparatively
[15:13:04] <YuviPanda>	 bawolff: right.
[15:13:16] <YuviPanda>	 it's probably not as useful, nor different from just regular Random
[15:13:26] <Vulpix>	 it was done using a list of links from a page that contained links to all books
[15:13:27] <bawolff>	 so i have no idea why it was disabled on wikipedia
[15:15:53] <grrrit-wm>	 (03CR) 10Anomie: [C: 032] "Ok, no objections were raised so let's do this." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111390 (https://bugzilla.wikimedia.org/32189) (owner: 10TTO)
[15:17:34] <grrrit-wm>	 (03PS1) 10Zfilipin: Created a couple of VisualEditor test2.wikipedia.org jobs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/140921 
[15:18:34] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] Created a couple of VisualEditor test2.wikipedia.org jobs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/140921 (owner: 10Zfilipin)
[15:19:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Allow interlanguage link prefixes that are not language codes [core] - 10https://gerrit.wikimedia.org/r/111390 (https://bugzilla.wikimedia.org/32189) (owner: 10TTO)
[15:20:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Created a couple of VisualEditor test2.wikipedia.org jobs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/140921 (owner: 10Zfilipin)
[15:20:42] <grrrit-wm>	 (03PS3) 10Umherirrender: Use user name for $6 of message 'revision-info' [core] - 10https://gerrit.wikimedia.org/r/139389 
[15:22:30] <bawolff>	 Hmm, maybe I should make Special:Random transcludable
[15:23:32] <Technical_13>	 Oh oh Special:RandomRandom!
[15:23:45] <grrrit-wm>	 (03PS2) 10Zfilipin: Created the first Windows XP job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/140184 
[15:23:54] <Technical_13>	 Special:RandomUser?
[15:24:15] <bawolff>	 e.g. make {{Special:Random}} include a random article in the page
[15:24:40] <bawolff>	 And then we can have magic auto-portals by doing {{Special:RandomInCat/SomeCategory}}
[15:24:51] <bawolff>	 And then the servers die because special page transclusion kills caching
[15:25:10] <Technical_13>	 Xp
[15:25:15] <bawolff>	 And also, we could have {{Special:Random/media}} embed a random file
[15:26:00] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] Created the first Windows XP job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/140184 (owner: 10Zfilipin)
[15:26:02] <YuviPanda>	 bawolff: would that embed a random file every time you render?
[15:26:09] <bawolff>	 YuviPanda: umm yes
[15:26:13] <wikibugs>	 3MediaWiki extensions / 3AbuseFilter: Weird broken diff link in mediawikiwiki AbuseLog - 10https://bugzilla.wikimedia.org/45948#c1 (10Andre Klapper) Seems to still happen sometimes, example from yesterday, though NOT on a user page like the example given above:  https://www.mediawiki.org/wiki/Special:AbuseLo...
[15:26:14] <YuviPanda>	 nice
[15:26:21] <bawolff>	 YuviPanda: And it would disable parser cache
[15:26:26] <bawolff>	 So new file on every view
[15:26:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Created the first Windows XP job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/140184 (owner: 10Zfilipin)
[15:26:36] <YuviPanda>	 GREAT LET'S DO IT
[15:27:02] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-2] "{{citation needed}} on unused by clients. I'll grant you almost unused, but in May 2014 it got more hits than format=dbgfm (158 vs 134) so" [core] - 10https://gerrit.wikimedia.org/r/140886 (owner: 10MaxSem)
[15:27:21] <Technical_13>	 I'm still waiting to see [[Special:Random|]] display the name of the page it is going to take you to...
[15:30:45] <wikibugs>	 3MediaWiki extensions / 3Disambiguator: Distinguish disambiguation pages in [[special:whatlinkshere]] - 10https://bugzilla.wikimedia.org/7935#c1 (10Andre Klapper) 5NEW>3RESO/WOR https://en.wikipedia.org/w/index.php?title=Special:WhatLinksHere/Sausage&limit=500 lists items like  Capriotti's ‎ (links) Wien...
[15:37:06] <grrrit-wm>	 (03PS1) 10Jackmcbarn: Add support for testing transparent tags [core] - 10https://gerrit.wikimedia.org/r/140927 
[15:41:08] <grrrit-wm>	 (03PS5) 10Jackmcbarn: Use transparent tags [extensions/Cite] - 10https://gerrit.wikimedia.org/r/137824 
[15:41:14] <grrrit-wm>	 (03PS6) 10Jackmcbarn: Use transparent tags [extensions/Cite] - 10https://gerrit.wikimedia.org/r/137824 
[15:41:21] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use transparent tags [extensions/Cite] - 10https://gerrit.wikimedia.org/r/137824 (owner: 10Jackmcbarn)
[15:42:58] <grrrit-wm>	 (03PS6) 10Chad: Pass a Title for context to Linker::makeExternalLink() [core] - 10https://gerrit.wikimedia.org/r/129853 
[15:43:23] <grrrit-wm>	 (03CR) 10Chad: "PS6 was a simple rebase." [core] - 10https://gerrit.wikimedia.org/r/129853 (owner: 10Chad)
[15:43:43] <wikibugs>	 3MediaWiki / 3API: Allow registration of API modules and special pages as a factory function. - 10https://bugzilla.wikimedia.org/66870#c1 (10Brad Jorsch) p:5High>3Low s:5normal>3enhanc I note this was tried before in Gerrit change 49781, and abandoned because it turned out to be too much work at the...
[15:44:46] <grrrit-wm>	 (03PS1) 10Zfilipin: WIP rename Windows_XP platform to windows_xp [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/140928 
[15:50:42] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-1] "This -1 doesn't necessarily require any changes, just explanation." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/140864 (owner: 10Brian Wolff)
[15:51:48] <grrrit-wm>	 (03PS3) 10BryanDavis: Set MYSQLI_OPT_CONNECT_TIMEOUT in mysqli [core] - 10https://gerrit.wikimedia.org/r/140809 (owner: 10Aaron Schulz)
[15:52:07] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 032] Set MYSQLI_OPT_CONNECT_TIMEOUT in mysqli [core] - 10https://gerrit.wikimedia.org/r/140809 (owner: 10Aaron Schulz)
[15:52:39] <grrrit-wm>	 (03PS4) 10Chad: Switch default namespaces in SearchEngine to return content namespaces [core] - 10https://gerrit.wikimedia.org/r/140715 
[15:53:16] <jackmcbarn>	 at https://gerrit.wikimedia.org/r/#/c/137824/ , is it ok for me to add the errors after tidy runs, or do i need to add a new hook to core in between transparent tags and tidy?
[15:54:05] <bawolff>	 anomie: yeah, imageinfo is a very odd in the ways it mixes image information with thumbnailing requests, with upload warnings, and as part of a query module when images might not even have a page...
[15:54:57] <grrrit-wm>	 (03PS1) 10Hashar: Replace underscore by spaces in PLATFORM [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/140929 
[15:54:59] <anomie>	 bawolff: I've long been toying with the idea of deprecating the whole thing and writing ApiQueryFileInfo from scratch.
[15:55:25] <bawolff>	 anomie: And then in timedmediahandler there is ApiQueryVideoInfo which just duplicates the entire thing
[15:55:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Replace underscore by spaces in PLATFORM [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/140929 (owner: 10Hashar)
[15:56:36] <grrrit-wm>	 (03PS2) 10Hashar: Replace underscore by spaces in PLATFORM [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/140929 
[15:56:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Set MYSQLI_OPT_CONNECT_TIMEOUT in mysqli [core] - 10https://gerrit.wikimedia.org/r/140809 (owner: 10Aaron Schulz)
[15:58:01] <grrrit-wm>	 (03CR) 10Hashar: "Havent tested :-)" [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/140929 (owner: 10Hashar)
[15:58:07] <grrrit-wm>	 (03CR) 10Brian Wolff: Do not require iiurlwidth when getting thumbnails. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/140864 (owner: 10Brian Wolff)
[15:58:21] <grrrit-wm>	 (03PS1) 10Brian Wolff: Allow a comma separated list of namespaces for Special:Random [core] - 10https://gerrit.wikimedia.org/r/140931 
[15:58:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Switch default namespaces in SearchEngine to return content namespaces [core] - 10https://gerrit.wikimedia.org/r/140715 (owner: 10Chad)
[16:03:07] <grrrit-wm>	 (03PS1) 10Chad: Remove wddx API format [core] - 10https://gerrit.wikimedia.org/r/140932 
[16:03:52] <grrrit-wm>	 (03CR) 10Chad: "Should rebase this on top of I76964731." [core] - 10https://gerrit.wikimedia.org/r/136490 (owner: 10Chad)
[16:05:13] <grrrit-wm>	 (03PS1) 10Zfilipin: Moved the last VisualEditor job from Cloudbees [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/140933 
[16:05:17] <grrrit-wm>	 (03CR) 10Anomie: [C: 031] "Ok. Code looks as good as can be expected in this ugly module. Haven't tested." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/140864 (owner: 10Brian Wolff)
[16:06:15] <grrrit-wm>	 (03PS4) 10Chad: WIP: Remove less-than-useful API output formats [core] - 10https://gerrit.wikimedia.org/r/136490 
[16:06:30] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] Moved the last VisualEditor job from Cloudbees [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/140933 (owner: 10Zfilipin)
[16:07:01] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-1] "Doc needs update though." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/140864 (owner: 10Brian Wolff)
[16:07:37] <grrrit-wm>	 (03Abandoned) 10Zfilipin: WIP rename Windows_XP platform to windows_xp [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/140928 (owner: 10Zfilipin)
[16:07:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Moved the last VisualEditor job from Cloudbees [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/140933 (owner: 10Zfilipin)
[16:10:49] <grrrit-wm>	 (03PS3) 10Martineznovo: Make MySQLi work with non-standard socket [core] - 10https://gerrit.wikimedia.org/r/136638 (https://bugzilla.wikimedia.org/65998) 
[16:13:16] <grrrit-wm>	 (03CR) 10Martineznovo: "PS3 is a manual rebase due to merge conflict with gerrit change 140809" [core] - 10https://gerrit.wikimedia.org/r/136638 (https://bugzilla.wikimedia.org/65998) (owner: 10Martineznovo)
[16:13:29] <grrrit-wm>	 (03PS2) 10Brian Wolff: Do not require iiurlwidth when getting thumbnails. [core] - 10https://gerrit.wikimedia.org/r/140864 
[16:14:37] <grrrit-wm>	 (03CR) 10Anomie: [C: 031] "Code looks as good as can be expected in this ugly module. Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/140864 (owner: 10Brian Wolff)
[16:14:55] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Do not require iiurlwidth when getting thumbnails. [core] - 10https://gerrit.wikimedia.org/r/140864 (owner: 10Brian Wolff)
[16:15:11] <grrrit-wm>	 (03PS3) 10Brian Wolff: Do not require iiurlwidth when getting thumbnails. [core] - 10https://gerrit.wikimedia.org/r/140864 
[16:16:36] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Do not require iiurlwidth when getting thumbnails. [core] - 10https://gerrit.wikimedia.org/r/140864 (owner: 10Brian Wolff)
[16:17:01] <bawolff>	 really...
[16:17:34] <bawolff>	 whoops. that's embarassing
[16:17:44] <Nemo_bis>	 you shouldn't encourage the channel to click tehn
[16:18:00] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-2] "Same as Id9f54064" [core] - 10https://gerrit.wikimedia.org/r/140932 (owner: 10Chad)
[16:18:05] <bawolff>	 I thought it was just a merge issue again
[16:19:28] <grrrit-wm>	 (03PS1) 10Umherirrender: jQuery-ify legalcy protect.js [core] - 10https://gerrit.wikimedia.org/r/140936 
[16:19:53] <grrrit-wm>	 (03PS4) 10Brian Wolff: Do not require iiurlwidth when getting thumbnails. [core] - 10https://gerrit.wikimedia.org/r/140864 
[16:22:48] <grrrit-wm>	 (03PS2) 10Umherirrender: jQuery-ify legacy protect.js [core] - 10https://gerrit.wikimedia.org/r/140936 
[16:22:55] <grrrit-wm>	 (03Abandoned) 10Chad: Remove wddx API format [core] - 10https://gerrit.wikimedia.org/r/140932 (owner: 10Chad)
[16:23:05] <grrrit-wm>	 (03CR) 10Umherirrender: "Patch Set 2: Fixed typo" [core] - 10https://gerrit.wikimedia.org/r/140936 (owner: 10Umherirrender)
[16:23:29] <grrrit-wm>	 (03CR) 10Hashar: "Extensions added with https://gerrit.wikimedia.org/r/#/c/140909/" [core] - 10https://gerrit.wikimedia.org/r/90584 (owner: 10JanZerebecki)
[16:24:28] <grrrit-wm>	 (03CR) 10Hashar: [C: 031] "Added as reviewers the folks that were involved in https://gerrit.wikimedia.org/r/#/c/90584/ "Use PHPUnit filter/whitelist to select the f" [core] - 10https://gerrit.wikimedia.org/r/140909 (owner: 10Aude)
[16:26:28] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] jQuery-ify legacy protect.js [core] - 10https://gerrit.wikimedia.org/r/140936 (owner: 10Umherirrender)
[16:28:51] <grrrit-wm>	 (03PS3) 10Umherirrender: jQuery-ify legacy protect.js [core] - 10https://gerrit.wikimedia.org/r/140936 
[16:30:32] <grrrit-wm>	 (03CR) 10Huji: [C: 031] "Worked for me in my tests." [core] - 10https://gerrit.wikimedia.org/r/140916 (https://bugzilla.wikimedia.org/46420) (owner: 10Brian Wolff)
[16:34:46] <grrrit-wm>	 (03CR) 10Umherirrender: "Patch Set 3: Added missing var declaration" [core] - 10https://gerrit.wikimedia.org/r/140936 (owner: 10Umherirrender)
[16:35:22] <grrrit-wm>	 (03CR) 10Hashar: "> Are we close to being able to run these from Jenkins?" [core] - 10https://gerrit.wikimedia.org/r/133507 (https://bugzilla.wikimedia.org/66272) (owner: 10Cmcmahon)
[16:42:30] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: CSS class name changed to "valueview-valueview" - 10https://bugzilla.wikimedia.org/66883 (10Thiemo Mättig) 3NEW p:3Unprio s:3normal a:3Wikidata bugs The ValueView widget recently changed their class names from class="valueview valueview-instaticmode" to class="v...
[16:44:45] <bawolff>	 ich. I really don't like the SpecialPage / SpecialPageFactory split
[16:45:02] <^d>	 I didn't understand it.
[16:45:48] <grrrit-wm>	 (03CR) 10Jforrester: "Yay. :-)" [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/140933 (owner: 10Zfilipin)
[16:45:56] <bawolff>	 I'm trying to modify it so that Special pages can specify how they affect the parser cache, and SpecialPageFactory is making things difficult
[16:47:45] <grrrit-wm>	 (03PS5) 10Chad: WIP: Remove less-than-useful API output formats [core] - 10https://gerrit.wikimedia.org/r/136490 
[16:52:20] <grrrit-wm>	 (03PS1) 10EBernhardson: Check for directory traversal in getTemplateName [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140938 
[16:54:13] <wikibugs>	 3Wikimedia / 3Deployment systems: [scap] sync-common fails for hosts not in the wmnet TLD - 10https://bugzilla.wikimedia.org/66844#c3 (10Bryan Davis) 5PATC>3RESO/FIX Verified fix by running `/usr/local/bin/sync-common` on fenari without providing any explicit rsync source host.      fenari:~     bd808$ /...
[16:56:43] <wikibugs>	 3MediaWiki / 3Special pages: Indicate edits to protected pages in change lists - 10https://bugzilla.wikimedia.org/10379#c2 (10Andre Klapper) Still valid...
[16:56:45] <grrrit-wm>	 (03CR) 10Umherirrender: "mw.track should be added in a seperate patch set and can be done after merge." [core] - 10https://gerrit.wikimedia.org/r/139672 (owner: 10Umherirrender)
[17:00:14] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: CSS class name changed to "valueview-valueview" - 10https://bugzilla.wikimedia.org/66883#c1 (10Thiemo Mättig) 5NEW>3PATC p:5Unprio>3High https://github.com/wmde/ValueView/pull/74
[17:00:29] <wikibugs>	 3MediaWiki extensions / 3Math: Add Selenium for Math extension - 10https://bugzilla.wikimedia.org/64151#c3 (10physikerwelt) Is there a way to integrate these test to the Jenkins verification circle, to prevent that tests that would break browser tests are being submitted.
[17:06:13] <wikibugs>	 3MediaWiki / 3Page editing: creating a user talk page by moving does not trigger the new-message box - 10https://bugzilla.wikimedia.org/24937#c4 (10Andre Klapper) Is this a duplicate of bug 4101 (which was marked as a dup of bug 12465)?
[17:06:18] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "If you can break this down into smaller commits I will love you forever." (036 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG)
[17:07:29] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] "Chris Steipp feel free to +2" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140938 (owner: 10EBernhardson)
[17:07:59] <wikibugs>	 3MediaWiki / 3Special pages: Add option to Special:Undelete to display deletion log integrated into page history - 10https://bugzilla.wikimedia.org/60736 (10Andre Klapper)
[17:07:59] <wikibugs>	 3MediaWiki / 3Special pages: Special:Log should be able to list pages at revision level as well - 10https://bugzilla.wikimedia.org/12083 (10Andre Klapper)
[17:08:39] <grrrit-wm>	 (03PS1) 10EBernhardson: progressiveEnhancement should escape $insertionType and $sectionId [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140940 
[17:17:34] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "This behaviour just doesn't seem right to me. Can someone clarify expected behaviour on card?" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140912 (owner: 10Matthias Mullie)
[17:20:50] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 04-1] "I suggest to resubmit this with just username (for the placeholder text)." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140912 (owner: 10Matthias Mullie)
[17:21:20] <grrrit-wm>	 (03PS1) 10EBernhardson: Remove unused pipelist helper [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140943 
[17:22:36] <grrrit-wm>	 (03CR) 10Physikerwelt: "I think this might be outdated, since the wmf10 branch is out" [extensions/Math] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/139439 (https://bugzilla.wikimedia.org/66587) (owner: 10Physikerwelt)
[17:24:02] <grrrit-wm>	 (03PS4) 10Physikerwelt: Fix: Correcting problems in wmf8 branch [extensions/Math] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/139439 (https://bugzilla.wikimedia.org/66587) 
[17:28:57] <grrrit-wm>	 (03PS1) 10EBernhardson: Require block helper callbacks to be Closure [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140944 
[17:31:05] <grrrit-wm>	 (03PS1) 10Brian Wolff: Make transcluded special pages not disable cache in miser mode. [core] - 10https://gerrit.wikimedia.org/r/140945 
[17:32:28] <wikibugs>	 3MediaWiki / 3Page editing: IE6 and IE7 and IE8 and IE9: page errors in editor, sometimes controls don't load, preventing editing - 10https://bugzilla.wikimedia.org/58464 (10Chris McMahon)
[17:33:03] <grrrit-wm>	 (03CR) 10Jackmcbarn: "Gah, this results in <ol>s ending up inside <p>s. Not good." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/137824 (owner: 10Jackmcbarn)
[17:36:57] <grrrit-wm>	 (03PS1) 10Chad: Remove SearchResultTooMany [core] - 10https://gerrit.wikimedia.org/r/140947 
[17:37:54] <grrrit-wm>	 (03CR) 10Jackmcbarn: Make transcluded special pages not disable cache in miser mode. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/140945 (owner: 10Brian Wolff)
[17:38:18] <grrrit-wm>	 (03PS2) 10Brian Wolff: Make transcluded special pages not disable cache in miser mode. [core] - 10https://gerrit.wikimedia.org/r/140945 
[17:38:41] <bawolff>	 jackmcbarn: yep. I noticed that almost immediately after I hit submit
[17:38:46] <bawolff>	 yay for good testing :)
[17:39:07] <jackmcbarn>	 bawolff: i'm also wondering why that needs to be behind miser mode at all. couldn't it be always on?
[17:39:28] <wikibugs>	 3MediaWiki / 3Page editing: [Regression] section=new no longer works for user js/css pages - 10https://bugzilla.wikimedia.org/50962#c5 (10James Forrester) (In reply to Krinkle from comment #0) > Various wikis use section=new on js or css pages in combination with > "preload" and "editintro" to make it easier...
[17:39:48] <bawolff>	 I guess it could. Non miser mode wikis might like the fact that {{special:prefixindex}} updates instantly. I'm not sure
[17:40:58] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: CSS class name changed to "valueview-valueview" - 10https://bugzilla.wikimedia.org/66883#c2 (10Thiemo Mättig) Gadgets that may need to be fixed can be found here: https://www.wikidata.org/wiki/Special:Search/valueview?ns2=1&ns8=1
[17:41:05] <grrrit-wm>	 (03PS3) 10Jackmcbarn: Make transcluded special pages not disable cache in miser mode. [core] - 10https://gerrit.wikimedia.org/r/140945 (https://bugzilla.wikimedia.org/60561) (owner: 10Brian Wolff)
[17:41:49] <grrrit-wm>	 (03PS1) 10Rillke: Detect chemical table files [core] - 10https://gerrit.wikimedia.org/r/140949 
[17:42:14] <wikibugs>	 3MediaWiki / 3Parser: Interwikis gets doubled decoded - 10https://bugzilla.wikimedia.org/32926#c4 (10James Forrester) This is related to a parser rather than editing per se.  (It looks like different encoding pipelines being used somehow.)
[17:43:07] <bawolff>	 jackmcbarn: oh wow, totally forgot there was a bug for that
[17:43:59] <Vulpix>	 bug 50962 importance high / major, really? it seems overrated, even if it's a regression
[17:45:02] <bawolff>	 hasn't that been broken since content handler landed?
[17:45:58] <wikibugs>	 3MediaWiki / 3Page editing: MediaWiki should not prevent creation of empty pages - 10https://bugzilla.wikimedia.org/57238#c4 (10James Forrester) I believe this was intended to prevent pointless pages being created, e.g. in error by anons. However, I suppose that this can now be prevented (or tagged for follo...
[17:46:13] <Vulpix>	 probably
[17:47:18] <grrrit-wm>	 (03PS2) 10Rillke: Detect chemical table files [core] - 10https://gerrit.wikimedia.org/r/140949 
[17:48:18] <grrrit-wm>	 (03PS3) 10Rillke: Detect chemical table files [core] - 10https://gerrit.wikimedia.org/r/140949 
[17:48:43] <wikibugs>	 3MediaWiki / 3Page editing: MediaWiki should not prevent creation of empty pages - 10https://bugzilla.wikimedia.org/57238#c5 (10Bawolff (Brian Wolff)) __END__ ?
[17:49:44] <wikibugs>	 3MediaWiki extensions / 3WikidataRepo: automatic edit summary for link changes mentions badges even if there is no badge change - 10https://bugzilla.wikimedia.org/62546#c6 (10Lydia Pintscher) 5VERI>3REOP Just been reported on contact the dev team page again for a recent edit.
[17:49:59] <James_F>	 bawolff: Yes.
[17:50:35] <huh>	 Is it allowed to use die() or exit() ?
[17:50:54] <bawolff>	 huh: Pretty much no, except in register globals check
[17:51:09] <bawolff>	 huh: By which I more mean, what possible reason could you need that
[17:51:31] <huh>	 to prevent the normal page output from being added
[17:51:43] <wikibugs>	 3MediaWiki / 3Page editing: [Regression] section=new no longer works for user js/css pages - 10https://bugzilla.wikimedia.org/50962#c6 (10Technical 13) (In reply to James Forrester from comment #5) > (In reply to Krinkle from comment #0) > > Various wikis use section=new on js or css pages in combination wit...
[17:53:28] <wikibugs>	 3MediaWiki / 3Page editing: [Regression] section=new no longer works for user js/css pages - 10https://bugzilla.wikimedia.org/50962#c7 (10James Forrester) (In reply to Technical 13 from comment #6) > (In reply to James Forrester from comment #5) > > (In reply to Krinkle from comment #0) > > > Various wikis u...
[17:53:34] <bawolff>	 huh: Well die() will also cause database connections to not be closed properly, etc
[17:53:58] <bawolff>	 If you want to disable the skin stuff use $this->getOutput()->disable();
[17:54:11] <bawolff>	 Or do you mean different normal page output
[17:54:26] <grrrit-wm>	 (03PS1) 10Jdlrobson: QA: Make the header.feature pass again [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140951 
[17:54:57] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "It's supposed to be thread title, per https://trello.com/c/C5T9KF7f/235-input-box-change-reply-to-username-to-reply-to-thread-title" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140912 (owner: 10Matthias Mullie)
[17:55:00] <grrrit-wm>	 (03CR) 10CSteipp: [C: 031] progressiveEnhancement should escape $insertionType and $sectionId [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140940 (owner: 10EBernhardson)
[17:56:46] <grrrit-wm>	 (03PS1) 10Chad: SpecialSearch: Simplify result info [core] - 10https://gerrit.wikimedia.org/r/140952 
[17:57:04] <sumanah>	 discussing skin revamp in #wikimedia-office in 5 min https://www.mediawiki.org/wiki/Architecture_meetings/RFC_review_2014-06-20
[17:57:13] <grrrit-wm>	 (03CR) 10CSteipp: [C: 031] Check for directory traversal in getTemplateName [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140938 (owner: 10EBernhardson)
[17:57:29] <grrrit-wm>	 (03CR) 10Chad: "Did some screenshots of the net UI change: https://www.mediawiki.org/wiki/File:Search-info-tweak.png" [core] - 10https://gerrit.wikimedia.org/r/140952 (owner: 10Chad)
[18:00:22] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: SkinTemplate: Move $stylename to Skin and soft-deprecate [core] - 10https://gerrit.wikimedia.org/r/136531 
[18:01:48] <grrrit-wm>	 (03CR) 10Anomie: Make transcluded special pages not disable cache in miser mode. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/140945 (https://bugzilla.wikimedia.org/60561) (owner: 10Brian Wolff)
[18:03:45] <grrrit-wm>	 (03PS19) 10EBernhardson: javascript post/topic moderation [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139016 
[18:03:48] <grrrit-wm>	 (03PS1) 10EBernhardson: Wrap post elements in .flow-post-main [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140953 
[18:03:51] <grrrit-wm>	 (03PS1) 10EBernhardson: Spread out long lines in flow_post template [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140954 
[18:03:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] javascript post/topic moderation [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139016 (owner: 10EBernhardson)
[18:04:23] <grrrit-wm>	 (03CR) 10Brian Wolff: Make transcluded special pages not disable cache in miser mode. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/140945 (https://bugzilla.wikimedia.org/60561) (owner: 10Brian Wolff)
[18:05:43] <wikibugs>	 3MediaWiki / 3Skin and page rendering: Deprecate and remove skin autodiscovery (autoloading) mechanism - 10https://bugzilla.wikimedia.org/65748#c11 (10Bartosz Dziewoński) Status update:  * Deprecating skin autodiscovery: done. * Making core skins not use autodiscovery: partially done, more patches pending...
[18:06:36] <grrrit-wm>	 (03CR) 10EBernhardson: "split the reformatting of flow_post into 2 other patches as requested" (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139016 (owner: 10EBernhardson)
[18:11:30] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Remove SearchResultTooMany [core] - 10https://gerrit.wikimedia.org/r/140947 (owner: 10Chad)
[18:12:46] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "As noted, wgFlowUserPrintableName will poison the cache (I think the first anon to use the startup module will get their IP in there)." (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG)
[18:12:51] <grrrit-wm>	 (03CR) 10BryanDavis: "This begs for unit tests." [core] - 10https://gerrit.wikimedia.org/r/140949 (owner: 10Rillke)
[18:14:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove SearchResultTooMany [core] - 10https://gerrit.wikimedia.org/r/140947 (owner: 10Chad)
[18:16:14] <grrrit-wm>	 (03PS4) 10Withoutaname: Check for $wgAllowUserCss and $wgAllowUserJs in EditPage.php [core] - 10https://gerrit.wikimedia.org/r/139896 
[18:17:37] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Some improvements to Special:MergeHistory [core] - 10https://gerrit.wikimedia.org/r/138735 (owner: 10Aaron Schulz)
[18:20:08] <Nemo_bis>	 wow, time traveling
[18:21:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Some improvements to Special:MergeHistory [core] - 10https://gerrit.wikimedia.org/r/138735 (owner: 10Aaron Schulz)
[18:23:59] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Removed getLang() from IContextSource and subclasses [core] - 10https://gerrit.wikimedia.org/r/139783 (owner: 10Withoutaname)
[18:24:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Removed getLang() from IContextSource and subclasses [core] - 10https://gerrit.wikimedia.org/r/139783 (owner: 10Withoutaname)
[18:26:29] <wikibugs>	 3MediaWiki extensions / 3GlobalPreferences: The "Use this preference on all wikis" lines are unclearly associated - 10https://bugzilla.wikimedia.org/66869#c1 (10Elitre) My suggestion: Indent, then have a different shape for that checkbox (radio button, maybe?)
[18:27:53] <grrrit-wm>	 (03PS12) 1001tonythomas: Handle Bounce emails from IMAP Maildir/ effectievely. [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/140330 
[18:29:49] <grrrit-wm>	 (03PS6) 10Rillke: Adding basic functionality [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/140732 
[18:29:55] <grrrit-wm>	 (03CR) 10Krinkle: "That depends. To avoid missing the actual decline it is important we have no gap between the deprecation and the tracking. There'd be an a" [core] - 10https://gerrit.wikimedia.org/r/139672 (owner: 10Umherirrender)
[18:32:22] <grrrit-wm>	 (03CR) 1001tonythomas: "for a given bounce mail in my Maildir/new/ with To:my_wiki.wiki_-1-750h18nm3-acfa735ac409eec1a771db6154335ce8@localhost, the script succes" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/140330 (owner: 1001tonythomas)
[18:34:05] <grrrit-wm>	 (03CR) 10Mattflaschen: "I can't reproduce the $1 bug on ee-flow-extra or locally." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140912 (owner: 10Matthias Mullie)
[18:37:29] <grrrit-wm>	 (03PS3) 10Withoutaname: Removed getLang() from IContextSource and subclasses [core] - 10https://gerrit.wikimedia.org/r/139783 
[18:38:29] <grrrit-wm>	 (03CR) 10Spage: "Matt, there's a textarea to add a top-level comment to a topic: you can scroll down to it or click the Reply in the topic title bar. That" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140912 (owner: 10Matthias Mullie)
[18:42:10] <grrrit-wm>	 (03PS1) 10Bsitu: Add "post_moderation_state" to handlebar l10n function [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140956 
[18:42:16] <grrrit-wm>	 (03PS1) 10EBernhardson: Removed unused formElement handlebars helper [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140957 
[18:43:58] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n reviewed. Trivial change." [core] - 10https://gerrit.wikimedia.org/r/140952 (owner: 10Chad)
[18:46:12] <grrrit-wm>	 (03PS6) 10EBernhardson: New template helper: escapeContent [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140831 
[18:46:18] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] New template helper: escapeContent [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140831 (owner: 10EBernhardson)
[18:46:33] <grrrit-wm>	 (03CR) 10EBernhardson: New template helper: escapeContent (034 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140831 (owner: 10EBernhardson)
[18:46:56] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Krinkle, I assume that mw.track would go in wikibits.js? Sure that we can do it if it would be useful, but I'd also prefer to do it in a s" [core] - 10https://gerrit.wikimedia.org/r/139672 (owner: 10Umherirrender)
[18:49:12] <grrrit-wm>	 (03PS7) 10EBernhardson: New template helper: escapeContent [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140831 
[18:51:04] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "Thanks for the updates. One left, I think." (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/140338 (owner: 10Smuggli)
[18:52:33] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. Possible inconsistency." (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/139831 (owner: 10Smuggli)
[18:53:59] <wikibugs>	 3MediaWiki / 3Internationalization: "Show"/"Hide" links in recent changes / watchlist options box should be localizable per item - 10https://bugzilla.wikimedia.org/58449#c34 (10Umar) Hi. Somebody fix this error?
[18:58:11] <grrrit-wm>	 (03PS1) 10EBernhardson: Better document parameters to diffRevision template helper [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140962 
[19:01:31] <wikibugs>	 3MediaWiki / 3Internationalization: "Show"/"Hide" links in recent changes / watchlist options box should be localizable per item - 10https://bugzilla.wikimedia.org/58449#c35 (10Jesús Martínez Novo (Ciencia Al Poder)) 5RESO/FIX>3REOP (In reply to Douglas Gardner from comment #28) > I think the issue is th...
[19:04:30] <grrrit-wm>	 (03CR) 10Krinkle: "ping" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/100338 (owner: 10Legoktm)
[19:05:22] * legoktm looks up
[19:06:15] <grrrit-wm>	 (03CR) 10Mattflaschen: "Thanks, S. I can reproduce the bug now." (033 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140912 (owner: 10Matthias Mullie)
[19:08:18] <grrrit-wm>	 (03PS5) 10Legoktm: Load ext.wikiLove.local via module dependencies [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/100338 
[19:08:52] <grrrit-wm>	 (03CR) 10Legoktm: "Sorry, forgot about this patch. Rebased and fixed." [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/100338 (owner: 10Legoktm)
[19:09:56] <grrrit-wm>	 (03PS1) 10Jdlrobson: QA: Make flow_anon and flow_logged_in tests pass. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140963 
[19:10:12] <grrrit-wm>	 (03PS20) 10EBernhardson: javascript post/topic moderation [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139016 
[19:10:15] <grrrit-wm>	 (03PS2) 10EBernhardson: Wrap post elements in .flow-post-main [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140953 
[19:10:18] <grrrit-wm>	 (03PS2) 10EBernhardson: Spread out long lines in flow_post template [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140954 
[19:10:28] <wikibugs>	 3MediaWiki / 3Internationalization: "Show"/"Hide" links in recent changes / watchlist options box should be localizable per item - 10https://bugzilla.wikimedia.org/58449#c36 (10Umar) If you do not understand what to do I will try to bring the question correctly.
[19:12:28] <wikibugs>	 3MediaWiki / 3Internationalization: "Show"/"Hide" links in recent changes / watchlist options box should be localizable per item - 10https://bugzilla.wikimedia.org/58449#c37 (10Umar) Status changed again for some reason Sorry
[19:12:43] <wikibugs>	 3MediaWiki extensions / 3Translate: Recursive parser calls - 10https://bugzilla.wikimedia.org/65826#c12 (10Bawolff (Brian Wolff)) I suppose we could temporarily replace $wgParser with a new Parser object in SpecialPageFactory::capturePath. Not sure if its worth it. The OutputPage methods are really the only...
[19:13:25] <grrrit-wm>	 (03PS4) 10Legoktm: SkinTemplate: Move $stylename to Skin and soft-deprecate [core] - 10https://gerrit.wikimedia.org/r/136531 (owner: 10Bartosz Dziewoński)
[19:14:59] <grrrit-wm>	 (03PS6) 10Krinkle: Fix compatibility with MW 1.22, PHP 5.4 and Firefox 26 [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/105200 (owner: 10Gomoko)
[19:15:44] <wikibugs>	 3MediaWiki / 3Page editing: MediaWiki should not prevent creation of empty pages - 10https://bugzilla.wikimedia.org/57238#c6 (10James Forrester) (In reply to Bawolff (Brian Wolff) from comment #5) > __END__ ?  I don't understand. You think we should bring that magicword back (I vaguely recall that it was rem...
[19:15:58] <wikibugs>	 3MediaWiki / 3Internationalization: "Show"/"Hide" links in recent changes / watchlist options box should be localizable per item - 10https://bugzilla.wikimedia.org/58449#c38 (10Jesús Martínez Novo (Ciencia Al Poder)) (In reply to Umar from comment #36) > If you do not understand what to do I will try to brin...
[19:16:12] <Withoutaname>	 AaronSchulz: do you think you could take another look at https://gerrit.wikimedia.org/r/#/c/139783/ it didn't seem to work the first time
[19:17:01] <wikibugs>	 3MediaWiki / 3History/Diffs: Null edits are recorded in page history, sometimes with non-zero size change - 10https://bugzilla.wikimedia.org/66886 (10Redrose64) 3NEW p:3Unprio s:3normal a:3None Three consecutive edits [1] to [[Liverpool Street station]] show no change when viewing their diffs individ...
[19:17:54] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] SkinTemplate: Move $stylename to Skin and soft-deprecate [core] - 10https://gerrit.wikimedia.org/r/136531 (owner: 10Bartosz Dziewoński)
[19:20:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: SkinTemplate: Move $stylename to Skin and soft-deprecate [core] - 10https://gerrit.wikimedia.org/r/136531 (owner: 10Bartosz Dziewoński)
[19:21:43] <wikibugs>	 3MediaWiki / 3History/Diffs: Null edits are recorded in page history, sometimes with non-zero size change - 10https://bugzilla.wikimedia.org/66886#c1 (10Redrose64) Clarification: Viewing the same page in Watchlist shows an increase in size of one byte for <del>all</del><ins>each of</ins> the three edits.  (q...
[19:22:10] <Withoutaname>	 legoktm: do you think you could find out which extensions still use deprecatedglobal
[19:22:30] <legoktm>	 er, which global?
[19:22:43] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Fix namespace uses [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140964 
[19:22:47] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Remove unused local variables [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140965 
[19:22:50] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Remove unused file [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140966 
[19:22:53] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Fix undefined fields [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140967 
[19:22:56] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Remove unused method [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140968 
[19:22:59] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Get rid of unnecessary fully qualified namespaced classnames [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140969 
[19:23:02] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Remove unreachable code [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140970 
[19:23:05] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Remove (I think) leftover debug code [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140971 
[19:23:08] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Unit px is not needed for 0 [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140972 
[19:23:11] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Fix PHPDoc [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140973 
[19:23:41] <Withoutaname>	 legoktm: class DeprecatedGlobal extends StubObject
[19:23:53] <Nikerabbit>	 ^demon|lunch: thanks for the many search code cleanups!
[19:24:20] <^demon|lunch>	 You're welcome :)
[19:25:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix PHPDoc [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140973 (owner: 10Matthias Mullie)
[19:25:16] <legoktm>	 Withoutaname: I don't see any
[19:25:34] <Withoutaname>	 thanks, why did it exist I wonder
[19:25:43] <Nemo_bis>	 Indeed
[19:25:46] <legoktm>	 it was used to deprecate $wgArticle
[19:25:56] <legoktm>	 it's a useful class
[19:26:29] <bawolff>	 Now if only we could use it on $wgTitle
[19:26:51] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 031] "The @since comments will need updating." [core] - 10https://gerrit.wikimedia.org/r/77645 (https://bugzilla.wikimedia.org/54948) (owner: 10Parent5446)
[19:27:12] <grrrit-wm>	 (03PS2) 10EBernhardson: Add QUnit test infrastructure. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140607 (owner: 10Jdlrobson)
[19:28:40] <grrrit-wm>	 (03PS2) 10Matthias Mullie: Fix PHPDoc [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140973 
[19:30:41] <grrrit-wm>	 (03PS2) 10Mattflaschen: Add placeholder for editing header, workaround tooltip issue [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140854 
[19:31:22] <grrrit-wm>	 (03PS5) 10Legoktm: OutputPage: Add addParserOutputContent() for more fine-grained control [core] - 10https://gerrit.wikimedia.org/r/132232 (owner: 10Bartosz Dziewoński)
[19:31:38] <grrrit-wm>	 (03CR) 10EBernhardson: "ran `apt-get install phantomjs` inside vagrant and then ran `make qunit` i get:" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140607 (owner: 10Jdlrobson)
[19:32:06] <grrrit-wm>	 (03PS4) 10EBernhardson: Git: Treat compiled templates as binaries so we have nicer diffs [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140876 (owner: 10Jdlrobson)
[19:32:26] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] "LGTM" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140876 (owner: 10Jdlrobson)
[19:33:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Git: Treat compiled templates as binaries so we have nicer diffs [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140876 (owner: 10Jdlrobson)
[19:34:32] <grrrit-wm>	 (03CR) 10Mattflaschen: "It works for me, in both Firefox and Chromium. Please hard refresh or clear your cache to make sure you're getting the latest JS. onMwUi" (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140854 (owner: 10Mattflaschen)
[19:36:09] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] OutputPage: Add addParserOutputContent() for more fine-grained control [core] - 10https://gerrit.wikimedia.org/r/132232 (owner: 10Bartosz Dziewoński)
[19:38:24] <grrrit-wm>	 (03PS1) 10Brian Wolff: Allow transcluding {{special:Random}} to show a random article. [core] - 10https://gerrit.wikimedia.org/r/140975 
[19:38:27] <grrrit-wm>	 (03PS9) 10EBernhardson: Edit post [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139839 (owner: 10Matthias Mullie)
[19:38:43] <grrrit-wm>	 (03CR) 10EBernhardson: "Ps9: rebased" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139839 (owner: 10Matthias Mullie)
[19:39:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: OutputPage: Add addParserOutputContent() for more fine-grained control [core] - 10https://gerrit.wikimedia.org/r/132232 (owner: 10Bartosz Dziewoński)
[19:42:47] <grrrit-wm>	 (03PS4) 10EBernhardson: Tweak hidden topic behaviour [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140253 (owner: 10Jdlrobson)
[19:43:12] <grrrit-wm>	 (03CR) 10EBernhardson: "PS4: rebased" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140253 (owner: 10Jdlrobson)
[19:43:52] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] "This looks to work, we can deal with the toggle another time. Note that we also need to do something for hidden posts, this patch only ha" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140253 (owner: 10Jdlrobson)
[19:43:59] <wikibugs>	 3MediaWiki / 3Page editing: creating a user talk page by moving does not trigger the new-message box - 10https://bugzilla.wikimedia.org/24937#c5 (10msh210) (In reply to Andre Klapper from comment #4) > Is this a duplicate of bug 4101 (which was marked as a dup of bug 12465)?  That's about e-mail notification...
[19:44:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tweak hidden topic behaviour [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140253 (owner: 10Jdlrobson)
[19:45:35] <grrrit-wm>	 (03PS7) 10EBernhardson: Prevent double-encoding of topic titles [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140593 
[19:46:23] <grrrit-wm>	 (03CR) 10EBernhardson: "The parent patch to this deals with the reported XSS, the question of what do display inside the preview is being addressed in https://ger" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140593 (owner: 10EBernhardson)
[19:46:42] <grrrit-wm>	 (03CR) 10CSteipp: "Would the implementation change much, based on whether we decide to have Jenkins run this or not?" [core] - 10https://gerrit.wikimedia.org/r/133507 (https://bugzilla.wikimedia.org/66272) (owner: 10Cmcmahon)
[19:48:30] <grrrit-wm>	 (03PS7) 10Legoktm: Article: Add RL modules for the ParserOutput when showing CSS/JS page [core] - 10https://gerrit.wikimedia.org/r/131502 (https://bugzilla.wikimedia.org/64859) (owner: 10Bartosz Dziewoński)
[19:50:58] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] "Looks good after review and some manual testing (not everywhere, but some key areas)." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140831 (owner: 10EBernhardson)
[19:51:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: New template helper: escapeContent [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140831 (owner: 10EBernhardson)
[19:52:37] <grrrit-wm>	 (03CR) 10Cmcmahon: "Csteipp: no changes at all in Jenkins. We might eventually add a tag like "@universal" or something if we create tests that should only p" [core] - 10https://gerrit.wikimedia.org/r/133507 (https://bugzilla.wikimedia.org/66272) (owner: 10Cmcmahon)
[19:53:09] <grrrit-wm>	 (03PS1) 10Bsitu: flow-post-action-edit-post does not make take parameters [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141043 
[19:53:16] <grrrit-wm>	 (03PS8) 10Mattflaschen: Prevent double-encoding of topic titles [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140593 (owner: 10EBernhardson)
[19:56:02] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Article: Add RL modules for the ParserOutput when showing CSS/JS page [core] - 10https://gerrit.wikimedia.org/r/131502 (https://bugzilla.wikimedia.org/64859) (owner: 10Bartosz Dziewoński)
[19:58:02] <grrrit-wm>	 (03PS4) 10Legoktm: Use ContentGetParserOutput hook instead of ShowRawCssJs [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/131447 (https://bugzilla.wikimedia.org/64859) (owner: 10Bartosz Dziewoński)
[19:59:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Article: Add RL modules for the ParserOutput when showing CSS/JS page [core] - 10https://gerrit.wikimedia.org/r/131502 (https://bugzilla.wikimedia.org/64859) (owner: 10Bartosz Dziewoński)
[19:59:40] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Use ContentGetParserOutput hook instead of ShowRawCssJs [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/131447 (https://bugzilla.wikimedia.org/64859) (owner: 10Bartosz Dziewoński)
[20:00:16] <^demon|lunch>	 Nikerabbit: This one's an easy merge :) https://gerrit.wikimedia.org/r/#/c/140913/
[20:00:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use ContentGetParserOutput hook instead of ShowRawCssJs [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/131447 (https://bugzilla.wikimedia.org/64859) (owner: 10Bartosz Dziewoński)
[20:01:01] <grrrit-wm>	 (03PS2) 10EBernhardson: QA: Make the header.feature pass again [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140951 (owner: 10Jdlrobson)
[20:03:32] <grrrit-wm>	 (03CR) 10Legoktm: [C: 031] use non-localized namespace for links to global user-css/js (031 comment) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/140907 (https://bugzilla.wikimedia.org/66873) (owner: 10Se4598)
[20:05:26] <grrrit-wm>	 (03CR) 10Spage: [C: 032] "\o/" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140951 (owner: 10Jdlrobson)
[20:05:29] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] QA: Make the header.feature pass again [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140951 (owner: 10Jdlrobson)
[20:08:08] <Nikerabbit>	 ^demon|lunch: is the difference between hasResult and hasResults significant?
[20:08:19] <grrrit-wm>	 (03PS2) 10EBernhardson: QA: Make flow_anon and flow_logged_in tests pass. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140963 (owner: 10Jdlrobson)
[20:08:32] <^demon|lunch>	 hasResult() should've been hasResults() :)
[20:09:37] <Nikerabbit>	 ^demon|lunch: so it didn't even work as intented?
[20:10:07] <^demon|lunch>	 Nope!
[20:10:31] <Nikerabbit>	 ^demon|lunch: somehow I'm not surprised
[20:10:33] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] "Looks good. Tested initial creation, and editing, with JavaScript on. No unnecessary escaping added in either case." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140593 (owner: 10EBernhardson)
[20:10:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Prevent double-encoding of topic titles [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140593 (owner: 10EBernhardson)
[20:10:52] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "I have reused some of the ideas from here in my patch aiming to (mostly) the same thing: https://gerrit.wikimedia.org/r/#/c/138795/" [core] - 10https://gerrit.wikimedia.org/r/65319 (owner: 10Luis Felipe Schenone)
[20:11:06] <^demon|lunch>	 Nikerabbit: This code is ancient. I'm finding tons of dead code paths and crud that *barely* works, when it does at all.
[20:11:26] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] "Oh my, better to get rid of this before anyone sees." [core] - 10https://gerrit.wikimedia.org/r/140913 (owner: 10Chad)
[20:12:45] <wikibugs>	 3MediaWiki / 3Installer: Updater race condition when using replication - 10https://bugzilla.wikimedia.org/66887 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3None Using update.php on a wiki with replication has the potential of hitting a race condition where the master has finished an update opera...
[20:14:46] <grrrit-wm>	 (03PS1) 10Jackmcbarn: Handle PTD_FOR_INCLUSION properly [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/141048 
[20:15:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: SearchResultSet: remove hasResults(), unused [core] - 10https://gerrit.wikimedia.org/r/140913 (owner: 10Chad)
[20:16:34] <grrrit-wm>	 (03PS1) 10Reedy: Add wfWaitForSlaves() call in DatabaseUpdater::runUpdates() [core] - 10https://gerrit.wikimedia.org/r/141049 (https://bugzilla.wikimedia.org/66887) 
[20:17:47] <grrrit-wm>	 (03PS2) 10Chad: SpecialSearch: Simplify result info [core] - 10https://gerrit.wikimedia.org/r/140952 
[20:18:14] <wikibugs>	 3MediaWiki / 3Installer: Updater race condition when using replication - 10https://bugzilla.wikimedia.org/66887#c2 (10Sam Reed (reedy)) 21:04:21] <bawolff> I think update.php is written with the assumption that anyone using it has a db small enough to not need replication  ^ In that case, it's see bug 1
[20:18:15] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Removed getLang() from IContextSource and subclasses [core] - 10https://gerrit.wikimedia.org/r/139783 (owner: 10Withoutaname)
[20:18:17] <wikibugs>	 3Wikimedia / 3Apache configuration: iPad tablet to mobile redirect not working (cookie or cache-related?) - 10https://bugzilla.wikimedia.org/66888 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None I've been having trouble with my iPad (Safari on iOS 7.1.1) not going over to the mobile site, even when...
[20:19:19] <grrrit-wm>	 (03PS5) 10Chad: Switch default namespaces in SearchEngine to return content namespaces [core] - 10https://gerrit.wikimedia.org/r/140715 
[20:20:17] <wikibugs>	 3MediaWiki-Vagrant: Fatal error: undefined method `save' due to outdated plugin - 10https://bugzilla.wikimedia.org/66889 (10Bryan Davis) 3NEW p:3Unprio s:3normal a:3Ori Livneh $ vagrant status                                                 [264/9172] Your git/Gerrit username has not been set.  * If yo...
[20:20:58] <wikibugs>	 3MediaWiki-Vagrant: Fatal error: undefined method `save' due to outdated plugin - 10https://bugzilla.wikimedia.org/66889 (10Bryan Davis) p:5Unprio>3High
[20:22:41] <grrrit-wm>	 (03PS9) 10SG: Fix preview [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 
[20:22:46] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix preview [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG)
[20:22:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Removed getLang() from IContextSource and subclasses [core] - 10https://gerrit.wikimedia.org/r/139783 (owner: 10Withoutaname)
[20:23:43] <grrrit-wm>	 (03CR) 10Chad: [C: 032] PrefixSearch (ApiOpenSearch) now supports searching in multiple namespaces [core] - 10https://gerrit.wikimedia.org/r/136796 (https://bugzilla.wikimedia.org/65752) (owner: 10Nikerabbit)
[20:24:41] <grrrit-wm>	 (03PS2) 10Nemo bis: PrefixSearch (ApiOpenSearch) now supports searching in multiple namespaces [core] - 10https://gerrit.wikimedia.org/r/136796 (https://bugzilla.wikimedia.org/65752) (owner: 10Nikerabbit)
[20:24:55] <grrrit-wm>	 (03PS1) 10Jdlrobson: WIP: Fix edit_existing.feature tests [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141050 
[20:25:07] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Currently broken" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141050 (owner: 10Jdlrobson)
[20:25:22] <grrrit-wm>	 (03PS3) 10Jdlrobson: QA: Make the header.feature pass again [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140951 
[20:25:30] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] QA: Make the header.feature pass again [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140951 (owner: 10Jdlrobson)
[20:25:39] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] QA: Make the header.feature pass again [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140951 (owner: 10Jdlrobson)
[20:26:04] <grrrit-wm>	 (03PS2) 10Bsitu: flow-post-action-edit-post does not make take parameters [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141043 
[20:26:07] <grrrit-wm>	 (03PS1) 10Bsitu: Author shoud not change when creating next revision [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141051 
[20:26:26] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Unit px is not needed for 0 [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140972 (owner: 10Matthias Mullie)
[20:26:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: Make the header.feature pass again [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140951 (owner: 10Jdlrobson)
[20:27:40] <grrrit-wm>	 (03PS1) 10Jackmcbarn: Expose frame.depth [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/141052 
[20:27:45] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Fix namespace uses [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140964 (owner: 10Matthias Mullie)
[20:28:42] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Fix namespace uses [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140964 (owner: 10Matthias Mullie)
[20:28:58] <wikibugs>	 3Wikimedia / 3Apache configuration: iPad tablet to mobile redirect not working (cookie or cache-related?) - 10https://bugzilla.wikimedia.org/66888#c1 (10Brion Vibber) Looking in Safari's debugger, I've got an "enwikistopMobileRedirect" cookie globally on .wikipedia.org :  enwikistopMobileRedirect    true...
[20:29:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Fix namespace uses [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140964 (owner: 10Matthias Mullie)
[20:29:25] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Remove unused local variables [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140965 (owner: 10Matthias Mullie)
[20:29:29] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Remove unused local variables [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140965 (owner: 10Matthias Mullie)
[20:29:33] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 04-1] Author shoud not change when creating next revision (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141051 (owner: 10Bsitu)
[20:29:37] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove unused local variables [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140965 (owner: 10Matthias Mullie)
[20:29:41] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Remove unused file [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140966 (owner: 10Matthias Mullie)
[20:29:47] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Remove unused file [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140966 (owner: 10Matthias Mullie)
[20:29:51] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove unused file [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140966 (owner: 10Matthias Mullie)
[20:29:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Remove unused local variables [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140965 (owner: 10Matthias Mullie)
[20:30:31] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Fix undefined fields [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140967 (owner: 10Matthias Mullie)
[20:30:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Remove unused file [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140966 (owner: 10Matthias Mullie)
[20:30:38] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Fix undefined fields [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140967 (owner: 10Matthias Mullie)
[20:30:43] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Fix undefined fields [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140967 (owner: 10Matthias Mullie)
[20:30:48] <grrrit-wm>	 (03PS2) 10Jdlrobson: Remove unused method [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140968 (owner: 10Matthias Mullie)
[20:30:59] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Remove unused method [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140968 (owner: 10Matthias Mullie)
[20:31:04] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove unused method [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140968 (owner: 10Matthias Mullie)
[20:31:09] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Remove hasResults() implementation per Ia04bd3fc [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140914 (owner: 10Chad)
[20:31:38] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Get rid of unnecessary fully qualified namespaced classnames [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140969 (owner: 10Matthias Mullie)
[20:31:42] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Get rid of unnecessary fully qualified namespaced classnames [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140969 (owner: 10Matthias Mullie)
[20:31:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Fix undefined fields [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140967 (owner: 10Matthias Mullie)
[20:31:54] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Get rid of unnecessary fully qualified namespaced classnames [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140969 (owner: 10Matthias Mullie)
[20:32:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Remove unused method [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140968 (owner: 10Matthias Mullie)
[20:32:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove hasResults() implementation per Ia04bd3fc [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140914 (owner: 10Chad)
[20:32:25] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Remove unreachable code and trailing semicolon [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140970 (owner: 10Matthias Mullie)
[20:32:29] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Remove unreachable code and trailing semicolon [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140970 (owner: 10Matthias Mullie)
[20:32:32] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove unreachable code and trailing semicolon [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140970 (owner: 10Matthias Mullie)
[20:32:43] <grrrit-wm>	 (03PS2) 10Jdlrobson: Remove (I think) leftover debug code [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140971 (owner: 10Matthias Mullie)
[20:32:46] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Get rid of unnecessary fully qualified namespaced classnames [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140969 (owner: 10Matthias Mullie)
[20:32:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove unreachable code and trailing semicolon [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140970 (owner: 10Matthias Mullie)
[20:33:11] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Remove leftover debug code in UUID toString [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140971 (owner: 10Matthias Mullie)
[20:33:17] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove leftover debug code in UUID toString [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140971 (owner: 10Matthias Mullie)
[20:33:23] <grrrit-wm>	 (03PS2) 10Jdlrobson: Unit px is not needed for 0 [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140972 (owner: 10Matthias Mullie)
[20:33:33] <grrrit-wm>	 (03PS3) 10Jdlrobson: Fix PHPDoc [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140973 (owner: 10Matthias Mullie)
[20:33:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Get rid of unnecessary fully qualified namespaced classnames [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140969 (owner: 10Matthias Mullie)
[20:33:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Remove unreachable code and trailing semicolon [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140970 (owner: 10Matthias Mullie)
[20:34:24] <grrrit-wm>	 (03PS10) 10SG: Fix preview [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 
[20:34:35] <grrrit-wm>	 (03CR) 10Bsitu: Author shoud not change when creating next revision (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141051 (owner: 10Bsitu)
[20:34:43] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix preview [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG)
[20:34:46] <grrrit-wm>	 (03Abandoned) 10Bsitu: Author shoud not change when creating next revision [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141051 (owner: 10Bsitu)
[20:34:49] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Fix PHPDoc [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140973 (owner: 10Matthias Mullie)
[20:34:55] <grrrit-wm>	 (03CR) 10SG: "Rebased manually. Removed that key and now put "Anonymous" l10n string as username for preview." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG)
[20:35:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Remove leftover debug code in UUID toString [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140971 (owner: 10Matthias Mullie)
[20:35:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Unit px is not needed for 0 [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140972 (owner: 10Matthias Mullie)
[20:35:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix PHPDoc [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140973 (owner: 10Matthias Mullie)
[20:36:05] <James_F>	 marktraceur: You around? Sanity-check on https://gerrit.wikimedia.org/r/#/c/141054/ appreciated.
[20:36:16] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Remove unnecessary parameter to flow-post-action-edit-post [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141043 (owner: 10Bsitu)
[20:36:20] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove unnecessary parameter to flow-post-action-edit-post [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141043 (owner: 10Bsitu)
[20:36:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Remove unnecessary parameter to flow-post-action-edit-post [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141043 (owner: 10Bsitu)
[20:38:33] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Add "post_moderation_state" to handlebar l10n function (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140956 (owner: 10Bsitu)
[20:38:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add "post_moderation_state" to handlebar l10n function [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140956 (owner: 10Bsitu)
[20:39:04] <grrrit-wm>	 (03PS2) 10Jdlrobson: Documentation: Parameters to diffRevision template helper [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140962 (owner: 10EBernhardson)
[20:39:09] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Documentation: Parameters to diffRevision template helper [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140962 (owner: 10EBernhardson)
[20:39:31] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Check for directory traversal in getTemplateName [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140938 (owner: 10EBernhardson)
[20:39:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Documentation: Parameters to diffRevision template helper [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140962 (owner: 10EBernhardson)
[20:39:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Check for directory traversal in getTemplateName [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140938 (owner: 10EBernhardson)
[20:39:58] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] progressiveEnhancement should escape $insertionType and $sectionId [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140940 (owner: 10EBernhardson)
[20:40:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: progressiveEnhancement should escape $insertionType and $sectionId [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140940 (owner: 10EBernhardson)
[20:40:54] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "You are doing 2 things in this patch. You are also checking type of inverse function. Please split into 2 patches." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140943 (owner: 10EBernhardson)
[20:41:47] <grrrit-wm>	 (03PS2) 10Jdlrobson: Removed unused formElement handlebars helper [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140957 (owner: 10EBernhardson)
[20:42:28] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Removed unused formElement handlebars helper [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140957 (owner: 10EBernhardson)
[20:42:33] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Removed unused formElement handlebars helper [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140957 (owner: 10EBernhardson)
[20:42:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Removed unused formElement handlebars helper [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140957 (owner: 10EBernhardson)
[20:43:39] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "See previous commit message. You got these commits messed up :)" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140944 (owner: 10EBernhardson)
[20:44:03] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Please add a PHP unit test." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/140413 (https://bugzilla.wikimedia.org/66797) (owner: 10EBernhardson)
[20:45:20] <grrrit-wm>	 (03PS1) 10Brian Wolff: Prevent OutputPage::addWikiText and friends from causing UNIQ fails [core] - 10https://gerrit.wikimedia.org/r/141056 (https://bugzilla.wikimedia.org/14562) 
[20:46:40] <grrrit-wm>	 (03PS1) 10Chad: Database search fixes: [core] - 10https://gerrit.wikimedia.org/r/141057 
[20:47:17] <grrrit-wm>	 (03PS11) 10SG: Fix preview [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 
[20:47:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix preview [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG)
[20:48:07] <grrrit-wm>	 (03PS1) 10Bsitu: Post author is not revision author [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141058 
[20:49:58] <wikibugs>	 3Wikimedia / 3Extension setup: Review and deploy the "In other projects sidebar" beta feature (part of Wikibase extension) - 10https://bugzilla.wikimedia.org/66226#c11 (10Greg Grossmeier) (In reply to Kunal Mehta (Legoktm) from comment #10) > (In reply to Greg Grossmeier from comment #9)  > > This new beta f...
[20:50:13] <grrrit-wm>	 (03PS3) 10Jdlrobson: Distinguish original post from replies in HTML [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140953 (owner: 10EBernhardson)
[20:50:17] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Distinguish original post from replies in HTML [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140953 (owner: 10EBernhardson)
[20:50:21] <grrrit-wm>	 (03PS12) 10SG: Fix preview [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 
[20:50:24] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] "This makes sense." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140953 (owner: 10EBernhardson)
[20:50:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Distinguish original post from replies in HTML [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140953 (owner: 10EBernhardson)
[20:50:42] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Please rebase." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140953 (owner: 10EBernhardson)
[20:56:45] <grrrit-wm>	 (03CR) 10SG: "This strikes me as a strange change. Why the change in nomenclature? I feel like if the revision was edited by someone else, the author ha" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141058 (owner: 10Bsitu)
[20:57:05] <NativeForeigner>	 around how long should a new vagrant instance take to create?
[20:58:17] <grrrit-wm>	 (03CR) 10SG: [C: 04-1] "You'll need to rebase this on top of the new preview patch https://gerrit.wikimedia.org/r/#/c/140903/" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139839 (owner: 10Matthias Mullie)
[20:58:20] <grrrit-wm>	 (03PS1) 10Jdlrobson: Add template partial for topic titles [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141061 
[20:59:25] <grrrit-wm>	 (03CR) 10SG: [C: 032] Add template partial for topic titles [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141061 (owner: 10Jdlrobson)
[20:59:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add template partial for topic titles [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141061 (owner: 10Jdlrobson)
[21:00:43] <wikibugs>	 3MediaWiki extensions / 3Translate: Invalid transclusion of Special:LanguageStats needs to degrade gracefully - 10https://bugzilla.wikimedia.org/62125#c4 (10Bawolff (Brian Wolff)) gerrit change 141056 would fix this.
[21:01:44] <wikibugs>	 3MediaWiki extensions / 3SyntaxHighlight (GeSHi): Reenable content model support for Syntaxhighlight - 10https://bugzilla.wikimedia.org/64859#c10 (10Bartosz Dziewoński) 5PATC>3RESO/FIX a:3Bartosz Dziewoński Hooray, this will work again!
[21:02:13] <wikibugs>	 3MediaWiki / 3Installer: Updater race condition when using replication - 10https://bugzilla.wikimedia.org/66887 (10Greg Grossmeier) p:5Unprio>3Normal
[21:02:21] <grrrit-wm>	 (03PS2) 10Brian Wolff: Prevent OutputPage::addWikiText and friends from causing UNIQ fails [core] - 10https://gerrit.wikimedia.org/r/141056 (https://bugzilla.wikimedia.org/14562) 
[21:03:10] <grrrit-wm>	 (03PS13) 10SG: Fix preview [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 
[21:03:20] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032] Convert recoverable fatal errors into exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/140414 (https://bugzilla.wikimedia.org/66797) (owner: 10EBernhardson)
[21:04:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Convert recoverable fatal errors into exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/140414 (https://bugzilla.wikimedia.org/66797) (owner: 10EBernhardson)
[21:07:35] <ori>	 MatmaRex: hey, got a sec?
[21:07:54] <ori>	 I'm sorry if I'm making you repeat what you already said earlier
[21:07:59] <MatmaRex>	 yup
[21:08:15] <ori>	 but can you quickly recap why you want to make skins separate in Special:Version?
[21:08:23] <ori>	 why not treat them as extensions?
[21:08:35] <ori>	 the possibility of adding a screenshot seems like it would be useful for extensions too
[21:08:45] <MatmaRex>	 because they're not extensions? i'd like to make them first-class citizens
[21:09:15] <ori>	 i'm mostly on board with that, but i'll quibble for a moment just to play devil's advocate
[21:09:55] <ori>	 how are skins distinct from (say) media handlers with respect to their need to be first-class citizens?
[21:12:08] <MatmaRex>	 ori: probably the most important distiction for users is that they're directly exposed in user interface (in preferences)
[21:13:28] <wikibugs>	 3MediaWiki extensions / 3Translate: [PagePreparation] Categories should be a part of page template and tagged with {{translation}} - 10https://bugzilla.wikimedia.org/66880#c2 (10Niklas Laxström) You can't actually rely on {{þranslation}} being present. If you want to use that kind of functionality, it needs...
[21:13:34] <ori>	 MatmaRex: I could go either way on this and I'm happy to go with your intuitions, but
[21:13:40] <MatmaRex>	 ori: we also don't really want people to think that skins should do everything that extensions are allowed to do
[21:13:53] <bawolff>	 We don't?
[21:14:01] <MatmaRex>	 (this goes with trevor's skin system refactoring a bit)
[21:14:26] <ori>	 I want to tease apart two senses of the 'skins != extensions' principle, because I agree with one and not the other
[21:15:02] <MatmaRex>	 this is a bit of a blurry distinction, and sometimes i guess it makes sense to treat skins the way we treat extensions
[21:15:13] <MatmaRex>	 but in general i think it doesn't
[21:15:18] <ori>	 The first sense has to do with whether we should gloss over the differences and kludge your skin work into core by just cramming them in where they don't belong
[21:15:20] <MatmaRex>	 bawolff: i don't think we do. do we?
[21:15:28] <ori>	 I get that you're averse to doing that and I am too, so we're on the same page there
[21:15:29] <bawolff>	 As in, I don't see any particular reason why you couldn't package skin things and extension things together (e.g. have a skin, but also have it do things like those collapsible sidebar that used to be in the vector extension)
[21:15:50] <MatmaRex>	 bawolff: that can be part of the "skin"
[21:16:02] <MatmaRex>	 personally, i draw the line at using any wgHooks. :)
[21:16:22] <ori>	 the second sense has to do with what picture we have of the "conceptual refactoring" component of these changes
[21:16:28] <MatmaRex>	 or in other words, skins should just display the content; they shouldn't run arbitrary code to do it
[21:16:34] <ori>	 it makes sense to me to adopt an expanded notion of what extensions are
[21:16:40] <MatmaRex>	 (in a perfect world, we would do skins withoyut any PHP)
[21:16:40] <ori>	 so that it encompasses skins
[21:17:09] <ori>	 not as a convenient way of borrowing code from the implementation of extensions (on Special:Version, for example) but as a logical and coherent way of looking at the world
[21:17:14] <MatmaRex>	 i think skins and extensions are pretty different things for sysadmins, too
[21:17:38] <bawolff>	 But in theory if there was some sort of display related hook, that did something that made sense to do it in the skin, I don't see why that would be a bad thing to bundle both together
[21:17:39] <MatmaRex>	 anecdotally, skins are more often written by "non-programmers", and are custom-made for one site
[21:18:10] <ori>	 but isn't it the case that the existing extension types are also cared for by different types of people, contain different kinds of code, and have different kinds of impact on end-users and sysadmins?
[21:18:17] <MatmaRex>	 bawolff: if you ask me: if there was such a hook, it should be a method on SkinTemplate or BaseTemplate instead.
[21:18:26] <MatmaRex>	 (that a skin could override, or not use)
[21:18:27] <bawolff>	 Hmm probably
[21:18:39] <bawolff>	 I certainly don't have any actual examples in mind
[21:19:00] <grrrit-wm>	 (03PS14) 10Jdlrobson: WIP: Wire up close & open actions in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 (owner: 10Bsitu)
[21:19:11] <ori>	 I think thinking of extensions as anything that extends the feature-set that ships with MediaWiki-Core makes sense
[21:19:18] <ori>	 and skins fit that definition
[21:19:19] <MatmaRex>	 ori: probably. but they all run arbitrary PHP code, while skins usually just have the code to load modules and output HTML
[21:19:55] <ori>	 sure, but drawing the line on what is and isn't an extension based on whether something contains arbitrary PHP code or not seems a bit odd
[21:19:56] <bawolff>	 My mental model includes skins as extensions, but I see that from a user prespective they're fairly different
[21:20:03] <MatmaRex>	 the only reason we wrap skins in PHP classes is because we always did
[21:20:11] <MatmaRex>	 that's also the only resaon why we use PHP code for skins
[21:20:12] <ori>	 nod, that is a welcome change MatmaRex
[21:20:21] <MatmaRex>	 we apparently used not to (phptal, anyone?)
[21:20:22] <^demon|lunch>	 Cleanup cleanup.
[21:20:26] <^demon|lunch>	 Everybody everywhere.
[21:20:30] <^demon|lunch>	 Cleanup clean up.
[21:20:31] <ori>	 I'm just quibbling about whether the fact that skins can be PHP-free means they're no longer properly 'extensions'
[21:20:34] <^demon|lunch>	 Everybody do your share.
[21:21:20] * Nemo_bis hopes the poem continues
[21:21:30] <^demon|lunch>	 Nope that's it.
[21:21:31] <ori>	 (it would make the code of Special:Version cleaner, but that shouldn't be relevant)
[21:21:32] <MatmaRex>	 ori: as i said, this is a bit blurry, eh (because our skin system sucks). i think separating them (both on special:version and in general) makes more sense for the actual users
[21:21:48] <MatmaRex>	 but i have no hard proof that it does
[21:21:52] <^demon|lunch>	 Context: https://www.youtube.com/watch?v=PJhXVg2QisM
[21:22:21] <^demon|lunch>	 No, this: https://www.youtube.com/watch?v=WJ9uhDzN-rA
[21:23:11] <MatmaRex>	 ori: in the wikitech thread last month, "third-party" people generally supported separating skins to a different directory and generally treating them as a different kind of entity
[21:23:16] <MatmaRex>	 ("third-party", i hate this word)
[21:23:33] <MatmaRex>	 let me find you a link
[21:23:42] <^demon|lunch>	 s/third-party/users/
[21:23:44] <^demon|lunch>	 :)
[21:23:48] <grrrit-wm>	 (03CR) 10Jdlrobson: "This patchset is overwhelmingly big." (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG)
[21:23:57] <ori>	 MatmaRex: although I believe in participatory consensus-seeking and decision-making I also believe pretty strongly that it's better to have someone passionate apply a coherent vision to set of changes than to just make each one be the lowest common denominator of what everyone can agree on
[21:24:08] <ori>	 so I am happy to +2 the change if you think it's the right approach
[21:24:18] <ori>	 but maybe think about it for another couple of hours?
[21:25:39] <MatmaRex>	 (the general reasoning is here: http://www.gossamer-threads.com/lists/wiki/wikitech/465428#465428 , at the bottom of this long email)
[21:25:54] <MatmaRex>	 that change is not really ready to be merged right now anyway :)
[21:26:29] <^demon|lunch>	 achoo.
[21:26:30] <^demon|lunch>	 https://gerrit.wikimedia.org/r/#/c/129853/
[21:26:40] <^demon|lunch>	 Oh, look what dropped there. Anyone fancy a review?
[21:27:09] <^demon|lunch>	 If not, I have 2 others ;-)
[21:27:53] <ori>	 MatmaRex: you know, I'm coming around to your point-of-view, I think
[21:28:32] <grrrit-wm>	 (03CR) 10Nikerabbit: Pass a Title for context to Linker::makeExternalLink() (032 comments) [core] - 10https://gerrit.wikimedia.org/r/129853 (owner: 10Chad)
[21:29:08] <ori>	 I did prefer putting skins in skins/ rather than extensions/, and if I ask myself why it's because, as you suggest, the notion of "extension" in MediaWikidom is already somewhat narrower than the notion of "extension" as it exists in software jargon generally
[21:29:33] <ori>	 and respecting the history there doesn't make things more confusing to newcomers or anything
[21:29:37] <ori>	 so OK, +1
[21:29:45] <NativeForeigner>	 there we go...
[21:30:05] <ori>	 regardless of that I do think giving extensions the possibility of having a screenshot in Special:Version could be nice, but that's besides the point
[21:30:30] <wikibugs>	 3MediaWiki extensions / 3SyntaxHighlight (GeSHi): Preview of JS/CSS pages should highlight the source code instead of using simple <pre> tags - 10https://bugzilla.wikimedia.org/27397#c7 (10Bartosz Dziewoński) 5NEW>3RESO/FIX a:5X!>3Bartosz Dziewoński I just tested and this seems to have been fixed by...
[21:30:43] <MatmaRex>	 ori: yes, there's no reason not to do it
[21:31:04] <MatmaRex>	 but i don't expect that to be used widely
[21:31:31] <grrrit-wm>	 (03PS7) 10Chad: Pass a Title for context to Linker::makeExternalLink() [core] - 10https://gerrit.wikimedia.org/r/129853 
[21:31:35] <grrrit-wm>	 (03CR) 10Chad: Pass a Title for context to Linker::makeExternalLink() (032 comments) [core] - 10https://gerrit.wikimedia.org/r/129853 (owner: 10Chad)
[21:31:35] <ori>	 up to you if you want to do that in your changes or if you want to leave that as a TODO for someone else
[21:32:09] <MatmaRex>	 ori: right now there isn't actually a good way to provide that screenshot
[21:32:28] <MatmaRex>	 ori: i'd like it to be used on special:version, in preferences and in the installer
[21:32:28] <wikibugs>	 3MediaWiki / 3History/Diffs: Null edits are recorded in page history, sometimes with non-zero size change - 10https://bugzilla.wikimedia.org/66886#c2 (10Sam Reed (reedy)) (In reply to Redrose64 from comment #1) > (q: how does one edit one's own posts here?)  You can't (no one can)
[21:32:30] <^demon|lunch>	 I can't wait until Special:Version has 40 images :)
[21:32:59] <grrrit-wm>	 (03PS3) 10Jdlrobson: QA: Make flow_anon and flow_logged_in tests pass. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140963 
[21:33:15] <MatmaRex>	 ori: it seems inappropriate to use $wgExtensionCredits in Preferences code, and very very inappropriate to try to get that value in installer ;)
[21:33:58] <^demon|lunch>	 We could stop using $wgExtensionCredits.
[21:34:00] <^demon|lunch>	 :)
[21:34:20] <MatmaRex>	 rewrite all the things!
[21:34:36] <ori>	 I wish we had a top-level concept that encompasses both extensions and skins
[21:34:38] <ori>	 maybe 'extras'
[21:34:55] <James_F>	 ori: "plugins"?
[21:35:03] <ori>	 yeah, that works too
[21:35:11] <James_F>	 ori: Or… "extensions". ;-)
[21:35:13] <^demon|lunch>	 Oatmeal raison cookies.
[21:35:19] * James_F stops being unhelpful.
[21:35:22] <ori>	 James_F: well, extensions is already more narrowly defined
[21:35:34] <James_F>	 Yeah.
[21:35:49] <grrrit-wm>	 (03CR) 10SG: [C: 04-1] WIP: Wire up close & open actions in JavaScript (038 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 (owner: 10Bsitu)
[21:36:08] <ori>	 MatmaRex: i'd prefer: foreach ( $pluginType as $type => $plugins ) { foreach ( $plugins as $plugin ) { .. } }
[21:36:20] <ori>	 over that ugly if ( $type !== 'other' && $type !== 'skin' ) check
[21:37:07] <MatmaRex>	 ori: i'd prefer separate $wgSkinCredits :)
[21:37:15] <^demon|lunch>	 Ew.
[21:37:27] <James_F>	 Double-eww.
[21:37:35] <MatmaRex>	 heh
[21:38:10] <ori>	 it seems like there are other places in the code where it makes sense to lump skins and extensions together as "optional enhancements to mediawiki developed outside trunk and requiring loading additional files"
[21:38:22] <ori>	 "add-ons" could work too btw
[21:38:38] <MatmaRex>	 ori: the only other one i found is the installer, and this breaks down very quickly
[21:38:48] <MatmaRex>	 i have a patch pending, you can see
[21:38:52] <ori>	 i think any one of {extras,plugins,addons} could work
[21:38:53] * ori looks
[21:38:56] <MatmaRex>	 https://gerrit.wikimedia.org/r/#/c/138652/
[21:39:09] <bawolff>	 Plugins sound more specific then extensions to me
[21:39:29] <ori>	 bawolff: hm, yeah, i can see that
[21:39:33] <MatmaRex>	 "plugins" immediately brings to mind "flash", let's not do this one
[21:39:43] <ori>	 if you were starting from scratch you'd make plugins be a subcategory of extensions and not the other way around probably
[21:39:45] <bawolff>	 To me, an extension extends things in some unspecified way, a plug in adds a box to a page
[21:39:54] <Reedy>	 Modifiers
[21:39:55] <ori>	 okay, so "plugins" is out
[21:39:58] <Reedy>	 Changerers
[21:40:07] <ori>	 "changerifiers", if anything
[21:40:07] <bawolff>	 Thingies
[21:40:15] <grrrit-wm>	 (03CR) 10SG: "Given that the current preview stuff has serious issues and outstanding bugs, blind merging this is no worse for wear." (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG)
[21:40:30] <Reedy>	 Leeches
[21:40:32] <ori>	 well you know the saying
[21:40:37] <ori>	 "There are only two hard things in Computer Science: cache invalidation and naming things." -- Phil Karlton
[21:40:43] <ori>	 too true in the context of mediawiki
[21:40:57] <Reedy>	 Extenderois
[21:40:58] <Reedy>	 Extenderoids
[21:41:04] <ori>	 hahahaha
[21:41:06] <legoktm>	 "There are only two hard things in Computer Science: cache invalidation, naming things, and off-by-one errors." -- I don't remember
[21:41:08] * bawolff always heard the two things being "cache invalidation, naming things, and off by one errors"
[21:41:23] <ori>	 maybe I was off-by-one ;)
[21:41:34] <grrrit-wm>	 (03PS14) 10SG: Fix preview [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 
[21:41:49] <bawolff>	 Maybe we should just not put skins on special:version
[21:41:53] <bawolff>	 Then everyone wins!
[21:42:03] <Reedy>	 Special:SkinVersions
[21:42:04] <legoktm>	 Special:Skins
[21:42:45] <MatmaRex>	 :o
[21:43:01] <Nemo_bis>	 +1 on bawolff 
[21:43:08] <Reedy>	 Plugoids
[21:43:36] <James_F>	 legoktm: I prefer "There are only three hard things in Computer Science: array termination, off-by-one errors."
[21:43:56] <legoktm>	 o.O
[21:44:16] <MatmaRex>	 we really are bad at naming things.
[21:44:25] <Jasper_Deng>	 what about race conditions, anyone?
[21:44:35] <Jasper_Deng>	 IRC software is not usually multithreaded for that reason
[21:45:02] <Reedy>	 Jasper_Deng: Zoom zoom
[21:49:24] <grrrit-wm>	 (03CR) 10Matthias Mullie: "+2 for blindly merging in this case - we still have bigger fish to get through before we merge this branch to master & we'll figure out an" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG)
[21:51:17] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 031] "Taken a quick look & looks fine; thorough testing can to be done at a later point when the dust settles and proper error handling etc. mak" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG)
[21:53:11] <MatmaRex>	 ori: sooo… how would you feel about merging "Separate {MonoBook,Vector} skin from core"?
[21:54:43] <wikibugs>	 3MediaWiki / 3Page editing: [Regression] section=new no longer works for user js/css pages - 10https://bugzilla.wikimedia.org/50962#c8 (10Helder) That would be one of [[mw:Gadgets 3.0]] features: "Instead of scaring people with a huge list, provide a selection UI with category-based browsing " Unfortunately...
[21:54:58] <wikibugs>	 3MediaWiki extensions / 3GlobalPreferences: The "Use this preference on all wikis" lines are unclearly associated - 10https://bugzilla.wikimedia.org/66869#c2 (10Quiddity) (In reply to Elitre from comment #1) > My suggestion: Indent, then have a different shape for that checkbox (radio > button, maybe?)  (You...
[22:01:22] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: Separate MonoBook skin from core [core] - 10https://gerrit.wikimedia.org/r/138795 
[22:01:24] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: Separate Vector skin from core [core] - 10https://gerrit.wikimedia.org/r/135413 
[22:04:35] <grrrit-wm>	 (03CR) 10Spage: [C: 04-1] "I added new topic and new post, clicked Preview, got" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG)
[22:04:47] <grrrit-wm>	 (03PS3) 10Aaron Schulz: [WIP] Initial commit of new job runner loop [services/jobrunner] - 10https://gerrit.wikimedia.org/r/140618 
[22:09:44] <wikibugs>	 3Analytics / 3Wikimetrics: Story: CronUser runs EEVS metrics on all projects daily - 10https://bugzilla.wikimedia.org/65946 (10Dan Andreescu) a:3Dan Andreescu
[22:11:22] <grrrit-wm>	 (03PS1) 10Chad: Switch near match to use better hook [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/141065 
[22:11:24] <grrrit-wm>	 (03PS2) 10Withoutaname: Removed deprecated WebRequest::escapeAppendQuery() [core] - 10https://gerrit.wikimedia.org/r/139788 
[22:11:56] <grrrit-wm>	 (03PS2) 10Chad: Switch near match to use better hook [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/141065 
[22:13:14] <grrrit-wm>	 (03PS4) 10EBernhardson: Distinguish original post from replies in HTML [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140953 
[22:13:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Distinguish original post from replies in HTML [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140953 (owner: 10EBernhardson)
[22:15:22] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Separate Vector skin from core [core] - 10https://gerrit.wikimedia.org/r/135413 (owner: 10Bartosz Dziewoński)
[22:17:08] <grrrit-wm>	 (03CR) 10Ori.livneh: "\o/. Excited to review this!" [services/jobrunner] - 10https://gerrit.wikimedia.org/r/140618 (owner: 10Aaron Schulz)
[22:17:28] <ori>	 AaronSchulz: you are fast as hell, heh
[22:18:00] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Removed deprecated WebRequest::escapeAppendQuery() [core] - 10https://gerrit.wikimedia.org/r/139788 (owner: 10Withoutaname)
[22:18:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Separate Vector skin from core [core] - 10https://gerrit.wikimedia.org/r/135413 (owner: 10Bartosz Dziewoński)
[22:19:13] <grrrit-wm>	 (03PS1) 10Chad: Remove SearchEngineReplacePrefixesComplete hook [core] - 10https://gerrit.wikimedia.org/r/141066 
[22:20:11] <Withoutaname>	 thanks
[22:21:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Removed deprecated WebRequest::escapeAppendQuery() [core] - 10https://gerrit.wikimedia.org/r/139788 (owner: 10Withoutaname)
[22:23:18] <grrrit-wm>	 (03PS21) 10EBernhardson: javascript post/topic moderation [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139016 
[22:23:21] <grrrit-wm>	 (03PS3) 10EBernhardson: Spread out long lines in flow_post template [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140954 
[22:23:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] javascript post/topic moderation [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139016 (owner: 10EBernhardson)
[22:25:21] <grrrit-wm>	 (03PS1) 10Chad: Remove SearchGetNearMatchBefore hook, unused [core] - 10https://gerrit.wikimedia.org/r/141067 
[22:26:36] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove SearchGetNearMatchBefore hook, unused [core] - 10https://gerrit.wikimedia.org/r/141067 (owner: 10Chad)
[22:26:51] <^demon|lunch>	 Fun fact: a good number of the search hooks were added for a single extension.
[22:27:06] <grrrit-wm>	 (03PS22) 10EBernhardson: javascript post/topic moderation [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139016 
[22:27:09] <grrrit-wm>	 (03PS5) 10EBernhardson: Distinguish original post from replies in HTML [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140953 
[22:27:12] <grrrit-wm>	 (03PS4) 10EBernhardson: Spread out long lines in flow_post template [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140954 
[22:27:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] javascript post/topic moderation [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139016 (owner: 10EBernhardson)
[22:31:17] <huh>	 ^demon|lunch: which?
[22:31:23] <huh>	 Lucene?
[22:31:23] <^demon|lunch>	 Lockdown.
[22:31:31] <MatmaRex>	 ori: :D
[22:31:48] <MatmaRex>	 do MonoBook too? its patch is actually simpler
[22:33:18] <ori>	 yep, already reviewing
[22:33:45] <grrrit-wm>	 (03PS23) 10EBernhardson: javascript post/topic moderation [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139016 
[22:34:15] <ori>	 MatmaRex: brr, i don't think i have enough time to review it adequate right-right now
[22:34:22] <ori>	 i'll do it in a little bit. anything in particular to watch out for?
[22:34:49] <MatmaRex>	 it should be straightforward. i tested the patches and they worked as they should
[22:35:15] <MatmaRex>	 the vector one was tricky with the installer thing, monobook is boring
[22:35:54] <Withoutaname>	 wait why separate them
[22:36:05] <Withoutaname>	 is this in release notes or at least skins.txt
[22:36:25] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "I'll fill $wgExtensionsCredits with more sensible content later." [core] - 10https://gerrit.wikimedia.org/r/138795 (owner: 10Bartosz Dziewoński)
[22:36:37] <MatmaRex>	 Withoutaname: it will be
[22:36:51] <MatmaRex>	 Withoutaname: https://www.mediawiki.org/wiki/Separating_skins_from_core_MediaWiki
[22:37:03] <MatmaRex>	 "separate" is not a precise term, see this for details :)
[22:37:22] <ori>	 exile / banish
[22:38:13] <grrrit-wm>	 (03PS10) 10EBernhardson: Edit post [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139839 (owner: 10Matthias Mullie)
[22:38:18] <grrrit-wm>	 (03PS2) 10Chad: Remove SearchEngineReplacePrefixesComplete hook [core] - 10https://gerrit.wikimedia.org/r/141066 
[22:38:20] <grrrit-wm>	 (03PS2) 10Chad: Remove SearchGetNearMatchBefore hook, unused [core] - 10https://gerrit.wikimedia.org/r/141067 
[22:38:22] <grrrit-wm>	 (03PS1) 10Chad: Remove SpecialSearchNoResults, call SpecialSearchResults unconditionally [core] - 10https://gerrit.wikimedia.org/r/141069 
[22:38:24] <grrrit-wm>	 (03PS1) 10Mattflaschen: Refactor collapsing to handle moderated posts [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141070 
[22:38:46] <grrrit-wm>	 (03PS2) 10Mattflaschen: Refactor collapsing to handle moderated posts [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141070 
[22:38:57] <Withoutaname>	 originally I thought I would get a chance to rewrite wgvalidskinnames so it would detect classes extending SkinTemplate
[22:39:07] <MatmaRex>	 eeeek
[22:39:18] <MatmaRex>	 we're getting rid of skin autodiscovery
[22:39:41] <Withoutaname>	 yeah
[22:42:12] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Refactor collapsing to handle moderated posts [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141070 (owner: 10Mattflaschen)
[22:42:54] <grrrit-wm>	 (03PS1) 10Legoktm: Extend Article instead of using a hook [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/141071 
[22:45:36] <grrrit-wm>	 (03PS7) 10Withoutaname: Introduce error handling for undelete.php [core] - 10https://gerrit.wikimedia.org/r/131431 (https://bugzilla.wikimedia.org/52887) 
[22:45:54] <grrrit-wm>	 (03CR) 10Chad: [C: 032 V: 032] Nostalgia.php cleanup [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/137197 (owner: 10Bartosz Dziewoński)
[22:46:07] <grrrit-wm>	 (03CR) 10Chad: [C: 032 V: 032] Adjust 'remoteBasePath' to the skins/ directory [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/137198 (https://bugzilla.wikimedia.org/61256) (owner: 10Bartosz Dziewoński)
[22:47:27] <MatmaRex>	 whee
[22:47:43] <grrrit-wm>	 (03PS3) 10SG: Refactor collapsing to handle moderated posts [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141070 (owner: 10Mattflaschen)
[22:47:48] <MatmaRex>	 at this rate i'll have no patches to email wikitech about. :>
[22:48:08] <^demon|lunch>	 Wanna review some of mine? :p
[22:48:24] <MatmaRex>	 ^demon|lunch: about Nostalgia, are you also doing the related patches for wmf config?
[22:48:34] <MatmaRex>	 sure, hit me
[22:48:42] <MatmaRex>	 unless you're removing a lot of things again
[22:48:45] <MatmaRex>	 :D
[22:48:47] <^demon|lunch>	 https://gerrit.wikimedia.org/r/#/q/owner:Chad+status:open+-config,n,z - anything other than the WIP is fair game.
[22:51:03] <grrrit-wm>	 (03PS2) 10EBernhardson: Require block helper callbacks to be Closure [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140944 
[22:51:06] <grrrit-wm>	 (03PS2) 10EBernhardson: Remove unused pipelist helper [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140943 
[22:51:13] <^demon|lunch>	 MatmaRex: re config change, that's just 137200 right?
[22:51:40] <MatmaRex>	 ^demon|lunch: two patches i think
[22:51:50] <MatmaRex>	 ^demon|lunch: Reedy merged one but then reverted it
[22:52:31] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: Add Nostalgia to $branchedSkins [tools/release] - 10https://gerrit.wikimedia.org/r/137672 (https://bugzilla.wikimedia.org/61256) (owner: 10Reedy)
[22:53:05] <MatmaRex>	 https://gerrit.wikimedia.org/r/#/c/137672/ and https://gerrit.wikimedia.org/r/#/c/137200/ , as far as i know
[22:53:30] <MatmaRex>	 but don't blame me if i'm missing something and this horribly breaks everything
[22:54:03] <^demon|lunch>	 mw/skins/Nostalgia was made and copied over, right?
[22:54:40] <grrrit-wm>	 (03PS7) 10Bartosz Dziewoński: Stop using a suboptimal structure for Vector's variants menu [core] - 10https://gerrit.wikimedia.org/r/138368 (https://bugzilla.wikimedia.org/43406) 
[22:54:42] <grrrit-wm>	 (03PS7) 10Bartosz Dziewoński: Stop using a suboptimal structure for Vector's variants menu (cont.) [core] - 10https://gerrit.wikimedia.org/r/138369 (https://bugzilla.wikimedia.org/43406) 
[22:54:47] <Withoutaname>	 MatmaRex: if you got time update docs/skin.txt  please
[22:54:57] <^demon|lunch>	 Indeed, it was.
[22:55:04] <MatmaRex>	 ^demon|lunch: yes, the contents of the extensions/Nostalgia repo were copied
[22:55:15] <wikibugs>	 3Wikimedia / 3General/Unknown: out of memory for some animated GIF images on Commons - 10https://bugzilla.wikimedia.org/61711#c10 (10Bawolff (Brian Wolff)) Hmm, I was recently testing image magick, and it seems to have better memory performance then older versions, with me being able to scale a bunch of imag...
[22:55:36] <grrrit-wm>	 (03CR) 10Chad: [C: 032] "Nostalgia was copied over to the new repo, this can go in now." [tools/release] - 10https://gerrit.wikimedia.org/r/137672 (https://bugzilla.wikimedia.org/61256) (owner: 10Reedy)
[22:55:47] <Withoutaname>	 or put it on the checklist at * Removed WebRequest::escapeAppendQuery(). (deprecated since 1.20)
[22:55:51] <MatmaRex>	 Withoutaname: will do, but i'd rather do it once instead of constantly updating it as things continue changing
[22:55:57] <Withoutaname>	 https://www.mediawiki.org/wiki/Separating_skins_from_core_MediaWiki
[22:56:22] <Withoutaname>	 kk
[22:57:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add Nostalgia to $branchedSkins [tools/release] - 10https://gerrit.wikimedia.org/r/137672 (https://bugzilla.wikimedia.org/61256) (owner: 10Reedy)
[22:58:23] <^demon|lunch>	 MatmaRex: Both merged, commonssettings sync'd.
[22:58:42] <MatmaRex>	 :o
[22:59:27] <Withoutaname>	 I still see Skin::getSkinNames()
[22:59:46] <Withoutaname>	 oh nvm its marked with wfdeprecate
[23:00:34] <MatmaRex>	 ^demon|lunch: when can the extensions/Nostalgia one be undeployed and killed?
[23:00:53] <^demon|lunch>	 We'll let it ride with the new branch, I guess.
[23:00:56] <grrrit-wm>	 (03CR) 10Mattflaschen: Fix preview (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG)
[23:01:13] <grrrit-wm>	 (03PS15) 10Spage: Fix preview, improve tooltips [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG)
[23:01:17] <^demon|lunch>	 Then 30 days after it's not live because caching.
[23:01:25] <MatmaRex>	 aye
[23:01:26] <MatmaRex>	 hm
[23:01:40] <MatmaRex>	 nooo, i don't think we need that one
[23:01:53] <MatmaRex>	 the skins/ directory on bits is versioned
[23:02:00] <MatmaRex>	 extensions/ too
[23:02:47] <grrrit-wm>	 (03PS4) 10Jdlrobson: QA: Make flow_anon and flow_logged_in tests pass. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140963 
[23:02:50] <grrrit-wm>	 (03PS15) 10Jdlrobson: WIP: Wire up close & open actions in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 (owner: 10Bsitu)
[23:02:53] <grrrit-wm>	 (03PS1) 10Jdlrobson: QA: Add browser tests for close and reopen behaviour [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141073 
[23:03:53] <grrrit-wm>	 (03CR) 10Spage: [C: 032] "It works locally for me, updated the commit message with most of the changes. (This should have been four commits!)" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG)
[23:03:58] <MatmaRex>	 brb
[23:04:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix preview, improve tooltips [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140903 (owner: 10SG)
[23:05:02] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Remove unused pipelist helper [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140943 (owner: 10EBernhardson)
[23:05:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unused pipelist helper [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140943 (owner: 10EBernhardson)
[23:05:22] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Require block helper callbacks to be Closure [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140944 (owner: 10EBernhardson)
[23:05:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Require block helper callbacks to be Closure [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140944 (owner: 10EBernhardson)
[23:08:14] <grrrit-wm>	 (03PS4) 10SG: Refactor collapsing to handle moderated posts [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141070 (owner: 10Mattflaschen)
[23:08:44] <grrrit-wm>	 (03PS2) 10Jdlrobson: Post author is not revision author [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141058 (owner: 10Bsitu)
[23:08:48] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Post author is not revision author [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141058 (owner: 10Bsitu)
[23:08:51] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Post author is not revision author [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141058 (owner: 10Bsitu)
[23:08:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Post author is not revision author [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141058 (owner: 10Bsitu)
[23:09:32] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Distinguish original post from replies in HTML [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140953 (owner: 10EBernhardson)
[23:09:35] <grrrit-wm>	 (03PS1) 10Withoutaname: Removed setLang() too from IContextSource subclasses [core] - 10https://gerrit.wikimedia.org/r/141075 
[23:09:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Distinguish original post from replies in HTML [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140953 (owner: 10EBernhardson)
[23:10:37] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Seems to be various indent issues..." (034 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140954 (owner: 10EBernhardson)
[23:21:12] <Withoutaname>	 huh that's odd
[23:21:19] <huh>	 ?
[23:21:59] <Withoutaname>	 oh, uh, are you working on bug 21223?
[23:22:04] <grrrit-wm>	 (03PS6) 10EBernhardson: Distinguish original post from replies in HTML [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140953 
[23:24:38] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] "reapply jdlrobson +2" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140953 (owner: 10EBernhardson)
[23:24:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Distinguish original post from replies in HTML [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140953 (owner: 10EBernhardson)
[23:26:16] <MatmaRex>	 (back)
[23:28:23] <Withoutaname>	 hey MatmaRex
[23:28:39] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] "Don't merge yet." [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/141071 (owner: 10Legoktm)
[23:28:46] <grrrit-wm>	 (03CR) 10SG: "I prefer those indents. Makes it easier to read element attributes." (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140954 (owner: 10EBernhardson)
[23:28:58] <wikibugs>	 3Wikimedia / 3Git/Gerrit: Move Nostalgia skin repository from mediawiki/extensions/ to mediawiki/skins/ - 10https://bugzilla.wikimedia.org/61256#c14 (10Bartosz Dziewoński) 5PATC>3NEW (In reply to Bartosz Dziewoński from comment #1) > * Ensuring Nostalgia will work when placed in skins/ rather than extens...
[23:29:00] <Withoutaname>	 huh: sorry, didn't see you here :P just wondering if you're working on the bug
[23:29:31] <huh>	 Withoutaname: no, why?
[23:29:40] <huh>	 I did comment on it though
[23:30:09] <Withoutaname>	 i have my version of it
[23:30:22] <huh>	 ok
[23:31:26] <Withoutaname>	 unfortunately storing the watchlists in an array doesn't work because it gets destroyed after execution is finished
[23:32:01] <grrrit-wm>	 (03PS5) 10EBernhardson: Spread out long lines in flow_post template [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140954 
[23:32:46] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Switch default namespaces in SearchEngine to return content namespaces (031 comment) [core] - 10https://gerrit.wikimedia.org/r/140715 (owner: 10Chad)
[23:33:39] <^demon|lunch>	 Why would it give a warning?
[23:34:21] <MatmaRex>	 because you're indexing a false?
[23:34:25] <MatmaRex>	 does it not? php sucks
[23:35:01] <MatmaRex>	 ^demon|lunch: eh, this is actually a back-compat break
[23:35:13] <^demon|lunch>	 Hmm, empty array could work then.
[23:35:25] <MatmaRex>	 ^demon|lunch: if anyone has customized $wgNamespacesToBeSearchedDefault, NS_MAIN will not be included in searches after MW upgrade
[23:36:27] <^demon|lunch>	 Oh bleh, if they just appended to the array.
[23:36:28] <^demon|lunch>	 :(
[23:37:02] <MatmaRex>	 :(
[23:39:04] <^demon|lunch>	 I can't think of a non-breaking way to do it.
[23:39:27] <MatmaRex>	 just copy the array with default values?
[23:39:35] <MatmaRex>	 i mean, copy-paste it in DefaultSettings
[23:39:46] <MatmaRex>	 i can't think of a better way
[23:42:02] <^demon|lunch>	 I guess I can add the feature without changing the default.
[23:42:31] <^demon|lunch>	 Don't like it tho :(
[23:44:35] <^demon|lunch>	 Oh well, I'll think on that one over the weekend.
[23:44:38] <apexkid1>	 Hi, I am facing little problem in using API:Edit. As it says, the edit token remains same, but I am trying every time and it returns an invalid token response. I am not sure why. Please help
[23:44:45] <grrrit-wm>	 (03PS5) 10Jdlrobson: QA: Make flow_anon and flow_logged_in tests pass. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140963 
[23:44:48] <grrrit-wm>	 (03PS16) 10Jdlrobson: WIP: Wire up close & open actions in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 (owner: 10Bsitu)
[23:44:55] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Wire up close & open actions in JavaScript [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 (owner: 10Bsitu)
[23:45:40] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] "np" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140954 (owner: 10EBernhardson)
[23:45:41] <MatmaRex>	 apexkid1: this usually means that you're not passing the cookies correctly, or not encoding the token correctly
[23:45:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Spread out long lines in flow_post template [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140954 (owner: 10EBernhardson)
[23:46:59] <wikibugs>	 3Analytics / 3Wikimetrics: Story: First run of a recurrent report should be discarded - 10https://bugzilla.wikimedia.org/64443 (10Toby Negrin)
[23:47:11] <apexkid1>	 MatmaRex: I am using the browser itself so i think cookies are not an issue. Will you see my URLs pls https://fpaste.org/111653/08000140/
[23:47:58] <wikibugs>	 3Analytics / 3EventLogging: Story: Event Logging writing throughput needs monitoring - 10https://bugzilla.wikimedia.org/65482 (10Toby Negrin)
[23:48:11] <MatmaRex>	 apexkid1: you're not encoding the token, it needs to be percent-encoded like all other parameters in the URL
[23:48:36] <grrrit-wm>	 (03PS3) 10Jdlrobson: Post author is not revision author [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141058 (owner: 10Bsitu)
[23:48:38] <MatmaRex>	 apexkid1: also, the edit API only accepts POST requests, not GET (the URLs suggest you're using GET)
[23:48:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Post author is not revision author [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141058 (owner: 10Bsitu)
[23:48:44] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Post author is not revision author [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141058 (owner: 10Bsitu)
[23:48:47] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Post author is not revision author [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141058 (owner: 10Bsitu)
[23:48:58] <wikibugs>	 3Analytics / 3Wikimetrics: Story: Add new NEWLY REGISTERED USER metric - 10https://bugzilla.wikimedia.org/65944 (10Toby Negrin)
[23:49:06] <grrrit-wm>	 (03PS5) 10Jdlrobson: Refactor collapsing to handle moderated posts [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141070 (owner: 10Mattflaschen)
[23:49:20] <MatmaRex>	 apexkid1: if you're doing this from JavaScript on the wiki, you should probably use the mediawiki.api module which will do the boring things for you
[23:49:38] <MatmaRex>	 https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Api
[23:50:07] <apexkid1>	 MatmaRex: ohh... didn't knew that. I have to do this in pythin but I was just testing on browser before writing the code. But I will encode and send POST req now.
[23:50:08] <grrrit-wm>	 (03CR) 10SG: [C: 04-1] WIP: Wire up close & open actions in JavaScript (032 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 (owner: 10Bsitu)
[23:50:11] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Please rebase off https://gerrit.wikimedia.org/r/140607 and add a unit test. This seems like important code that should have some sort of " [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/141070 (owner: 10Mattflaschen)
[23:50:47] <apexkid1>	 MatmaRex: *python. Thanks i will see. :)
[23:51:43] <wikibugs>	 3Analytics / 3Wikimetrics: Story: New backup system - 10https://bugzilla.wikimedia.org/66119 (10Toby Negrin)
[23:52:34] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "Like we talked on IRC (posting here for posterity), this will not work well – if anyone has customized $wgNamespacesToBeSearchedDefault, N" [core] - 10https://gerrit.wikimedia.org/r/140715 (owner: 10Chad)
[23:58:40] <grrrit-wm>	 (03CR) 10Jdlrobson: "In the current version it is not a placeholder text but a default text value." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140912 (owner: 10Matthias Mullie)