[00:08:56] (03CR) 10Jdlrobson: [C: 04-1] "I feel like the workflows are wrong here and would be keen to bring in May for an opinion." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140204 (owner: 10EBernhardson) [00:09:53] 3Wikimedia / 3Site requests: Turn on Extension:Translate on foundationwiki (for use with board resolutions and project overviews) - 10https://bugzilla.wikimedia.org/44871#c21 (10TeleComNasSprVen) (In reply to Ryan Kaldari from comment #20) > FYI, Matt has proposed splitting the Special:MyLanguage functionali... [00:12:37] 3Wikimedia / 3Site requests: Turn on Extension:Translate on foundationwiki (for use with board resolutions and project overviews) - 10https://bugzilla.wikimedia.org/44871#c22 (10Ryan Kaldari) >Could be split to a separate bug to track, then have this issue changed so we >aren't porting the whole extension (a... [00:18:16] (03CR) 10Aaron Schulz: [C: 032] Mime search: Trim leading and trailing whitespace from input [core] - 10https://gerrit.wikimedia.org/r/140167 (owner: 10Chad) [00:21:13] (03PS1) 10MaxSem: New hook, AfterParserFetchFileAndTitle [core] - 10https://gerrit.wikimedia.org/r/140256 (https://bugzilla.wikimedia.org/66510) [00:21:54] (03Merged) 10jenkins-bot: Mime search: Trim leading and trailing whitespace from input [core] - 10https://gerrit.wikimedia.org/r/140167 (owner: 10Chad) [00:22:07] Reedy: around? [00:23:58] (03CR) 10Chad: [C: 032] Removed useless "while" loop [core] - 10https://gerrit.wikimedia.org/r/140028 (owner: 10Aaron Schulz) [00:25:04] (03PS1) 10MaxSem: Introduce gallery mode [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/140257 (https://bugzilla.wikimedia.org/66510) [00:27:41] (03Merged) 10jenkins-bot: Removed useless "while" loop [core] - 10https://gerrit.wikimedia.org/r/140028 (owner: 10Aaron Schulz) [00:30:08] (03PS3) 10Kaldari: Migrate from $.browser to $.client since $.browser is deprecated [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/140034 (https://bugzilla.wikimedia.org/66689) (owner: 10Bsitu) [00:31:38] 3Wikimedia / 3General/Unknown: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - 10https://bugzilla.wikimedia.org/66699#c19 (10Chris Steipp) (In reply to Krinkle from comment #17) > Right, we only set the cookie at log in time and it expires after 30 days > regardless of... [00:33:30] (03PS4) 10Bsitu: Add 'restore-topic' url & various fixes to close/open topic [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140230 [00:34:52] 3Wikimedia / 3General/Unknown: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - 10https://bugzilla.wikimedia.org/66699#c20 (10Steven Walling) (In reply to Chris Steipp from comment #19) > > But doing an automatic extension once a day seems like a much better > solution,... [00:42:55] (03PS1) 10Bsitu: Remove duplicated TopicRow definition [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140260 [00:50:52] 3Wikimedia / 3General/Unknown: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - 10https://bugzilla.wikimedia.org/66699#c21 (10Chris Steipp) (In reply to Steven Walling from comment #20) > This automatic extension doesn't sound like it adequately serves the type of > infr... [00:52:08] 3Wikimedia / 3Site requests: Turn on Extension:Translate on foundationwiki (for use with board resolutions and project overviews) - 10https://bugzilla.wikimedia.org/44871#c23 (10MZMcBride) (In reply to Ryan Kaldari from comment #22) > If it looks like there's consensus to split it off, we should split this b... [00:57:22] 3MediaWiki extensions / 3CirrusSearch: Allow search in the raw wiki text source via insource: - 10https://bugzilla.wikimedia.org/65783#c3 (10MZMcBride) (In reply to Gerrit Notification Bot from comment #2) > Change 137733 merged by jenkins-bot: > Insource support > > https://gerrit.wikimedia.org/r/137733 W... [00:58:37] 3Wikimedia / 3Site requests: Turn on Extension:Translate on foundationwiki (for use with board resolutions and project overviews) - 10https://bugzilla.wikimedia.org/44871#c24 (10Ryan Kaldari) The specific need is that I want to set the 'Mobile-frontend-terms-url' message to '//m.wikimediafoundation.org/wiki/... [00:59:25] manybubbles: Yo. [01:01:27] Yo yo ZZZzzZzzz [01:04:48] (03PS8) 10TTO: Allow interlanguage link prefixes that are not language codes [core] - 10https://gerrit.wikimedia.org/r/111390 (https://bugzilla.wikimedia.org/32189) [01:05:25] 3MediaWiki / 3Special pages: Add "Special:MyLanguage" to MediaWiki core - 10https://bugzilla.wikimedia.org/66762 (10MZMcBride) 3NEW p:3Unprio s:3normal a:3None Splitting this out from bug 44871. The request here to move "Special:MyLanguage" from [[mw:Extension:Translate]] into MediaWiki core. I don... [01:06:07] 3Wikimedia / 3General/Unknown: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - 10https://bugzilla.wikimedia.org/66699#c22 (10Matthew Flaschen) (In reply to Matthew Flaschen from comment #16) > I don't believe so: > > git grep -F -- '->setCookies' > > Only specific log... [01:06:23] 3Wikimedia / 3Site requests: Turn on Extension:Translate on foundationwiki (for use with board resolutions and project overviews) - 10https://bugzilla.wikimedia.org/44871#c25 (10MZMcBride) Okay, I split out the request to add "Special:MyLanguage" to MediaWiki core to bug 66762. [01:07:07] 3Wikimedia / 3General/Unknown: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - 10https://bugzilla.wikimedia.org/66699#c23 (10Steven Walling) (In reply to Chris Steipp from comment #21) > (In reply to Steven Walling from comment #20) > > This automatic extension doesn't... [01:14:55] 3MediaWiki-Vagrant: ruby-build significantly slows down the provisioning process - 10https://bugzilla.wikimedia.org/66763 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None This was added in 5388b38c54aecea4bc6b90ac1e0a9dc1d7bc38f2 . I assume ruby-build is used so an exact version of Ruby can be sp... [01:18:53] 3Utilities / 3mwdumper: mwdumper fails to import English wikipedia dump: ArrayIndexOutOfBoundsException; error in SQL syntax - 10https://bugzilla.wikimedia.org/57236#c5 (10mad2one48) I have the same problem with the file enwiki-20140502-pages-articles.xml [01:18:55] 3MediaWiki-Vagrant: VisualEditor fails to provision with rbenv error - 10https://bugzilla.wikimedia.org/66764 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3Ori Livneh The error is: err: /Stage[main]/Role::Visualeditor/Mediawiki::Extension[VisualEditor]/Browsertests::Bundle[/vagrant/mediawiki/extens... [01:23:37] 3Wikimedia / 3General/Unknown: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - 10https://bugzilla.wikimedia.org/66699#c24 (10Krinkle) Hm.. also relevant is that we invalidate existing sessions when a new session starts for a user. So in case of theft or hijacking in a w... [01:24:05] (03PS1) 10Prtksxna: core.less: Visual refinement & drop shadow [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140265 [01:26:07] 3MediaWiki extensions / 3WikidataClient: Under HHVM: Call to a member function getGuid() on a non-object - 10https://bugzilla.wikimedia.org/65698#c2 (10Ori Livneh) I don't think this is too mysterious. Claims.php has the following code (L432-434): assert( $oldClaim instanceof Claim ); assert( $newCl... [01:33:12] well I personally find having to enter your password every month a great way to memorize it [01:33:21] rather than once per year [01:42:13] (03CR) 10Jforrester: [C: 031] Add es5-shim library v3.4.0 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/139308 (owner: 10Jforrester) [01:45:09] (03PS6) 10Werdna: Implement AJAX preview on frontend-rewrite. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138788 [01:48:23] (03PS5) 10Bsitu: Add 'restore-topic' url & various fixes to close/open topic [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140230 [01:51:23] 3Utilities / 3mwdumper: mwdumper fails to import English wikipedia dump: ArrayIndexOutOfBoundsException; error in SQL syntax - 10https://bugzilla.wikimedia.org/57236#c6 (10mad2one48) 13,200,000 pages (5,538.948/sec), 13,200,000 revs (5,538.948/sec) Exception in thread "main" java.lang.ArrayIndexOutOfBoundsEx... [01:56:22] (03PS1) 10Bsitu: [WIP] close & open js interaction [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 [01:59:22] (03PS2) 10Bsitu: [WIP] close & open js interaction [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 [02:03:23] 3Wikimedia / 3General/Unknown: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - 10https://bugzilla.wikimedia.org/66699#c25 (10Matthew Flaschen) (In reply to Steven Walling from comment #23) > Yes. When you breakdown total active editors every month, there is a very > lar... [02:03:52] 3MediaWiki extensions / 3WikidataClient: Under HHVM: Call to a member function getGuid() on a non-object - 10https://bugzilla.wikimedia.org/65698#c3 (10Ori Livneh) Upstream(?) PR: https://github.com/wmde/WikibaseDataModel/pull/120 [02:04:09] Is it okay to use exit() if you want to force not displaying the rest of the page ? [02:04:47] Is there an alternative? [02:04:47] jackmcbarn!! [02:04:54] hi [02:05:02] Hi [02:05:08] Hi [02:05:38] am i needed? [02:05:39] Huh? [02:05:53] Always jack, always. [02:05:56] ;) [02:06:05] As you were.. [02:07:45] So... is it okay to use exit()/die()? [02:07:59] Well. When you get a moment.. I made a couple minor edits to a couple modules today and haven't gotten any complaints yet, bit would feel better if someone peeked at them to make sure they were sound. [02:08:14] T13|sleeps: links? [02:11:24] 3Analytics / 3EventLogging: Support third-party use by eliminating hard dependency on Varnish - 10https://bugzilla.wikimedia.org/43601#c4 (10Ori Livneh) a:5Ori Livneh>3None Unassigning for now [02:12:25] Https://en.Wikipedia.org/w/index.php?title=Special:contribs/technical_13&namespace=818 [02:13:34] Nope.. https://en.wikipedia.org/w/index.php?limit=50&tagfilter=&title=Special%3AContributions&contribs=user&target=technical+13&namespace=828&limit=20 [02:23:10] 3Wikimedia / 3General/Unknown: graphite.wikimedia.org often goes down with HTTP 502 Bate Gateway errors due to overload - 10https://bugzilla.wikimedia.org/66765 (10Krinkle) 3NEW p:3Unprio s:3critic a:3None As of late, half the time I'm trying to work with the graphs, some or all of the images on the... [02:25:45] (03PS1) 10PleaseStand: Deprecate swap() [core] - 10https://gerrit.wikimedia.org/r/140275 [02:31:05] (03PS2) 10Krinkle: GlobalFunctions: Deprecate swap() [core] - 10https://gerrit.wikimedia.org/r/140275 (owner: 10PleaseStand) [02:31:20] (03CR) 10Krinkle: [C: 031] "Maybe add release notes. Good to go!" [core] - 10https://gerrit.wikimedia.org/r/140275 (owner: 10PleaseStand) [02:34:37] 3Wikimedia / 3General/Unknown: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - 10https://bugzilla.wikimedia.org/66699#c26 (10Steven Walling) (In reply to Matthew Flaschen from comment #25) > (In reply to Steven Walling from comment #23) > > Yes. When you breakdown total... [02:44:18] (03CR) 10Krinkle: Add es5-shim library v3.4.0 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/139308 (owner: 10Jforrester) [02:46:26] (03CR) 10Krinkle: [C: 04-1] "-1 because after this change, oojs is still broken in most if not all ES3 browsers because it doesn't actually fulfil oojs or oojs-ui depe" [core] - 10https://gerrit.wikimedia.org/r/139308 (owner: 10Jforrester) [02:47:00] (03CR) 10Krinkle: "(referring to Object.create and others I might have missed. let's discus this tomorrow)" [core] - 10https://gerrit.wikimedia.org/r/139308 (owner: 10Jforrester) [02:47:56] (03CR) 10Jforrester: "Syntax change is -1'ed waiting for this commit; this commit is -1'ed waiting for the syntax change. This feels rather unhelpful. :-)" [core] - 10https://gerrit.wikimedia.org/r/139308 (owner: 10Jforrester) [02:48:49] (03PS1) 10devunt: Refactor out 'infinity' variants [core] - 10https://gerrit.wikimedia.org/r/140276 (https://bugzilla.wikimedia.org/66646) [02:54:07] (03CR) 10Jackmcbarn: Refactor out 'infinity' variants (031 comment) [core] - 10https://gerrit.wikimedia.org/r/140276 (https://bugzilla.wikimedia.org/66646) (owner: 10devunt) [02:58:55] (03CR) 10devunt: Refactor out 'infinity' variants (031 comment) [core] - 10https://gerrit.wikimedia.org/r/140276 (https://bugzilla.wikimedia.org/66646) (owner: 10devunt) [03:08:08] (03PS6) 10Pastakhov: add objects support (version 2.0.0 hook release 3) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/135995 [03:36:18] (03CR) 10Mattflaschen: ""Syntax change is -1'ed waiting for this commit"" [core] - 10https://gerrit.wikimedia.org/r/139308 (owner: 10Jforrester) [03:37:44] (03CR) 10Jforrester: "Matt: To be fair, the syntax change was -1'ed as pointless until the main downstream user of the library (MW) was in a position to provide" [core] - 10https://gerrit.wikimedia.org/r/139308 (owner: 10Jforrester) [03:40:22] 3MediaWiki extensions / 3CirrusSearch: Allow search in the raw wiki text source via insource: - 10https://bugzilla.wikimedia.org/65783#c4 (10Chad H.) 5PATC>3RESO/FIX (In reply to MZMcBride from comment #3) > (In reply to Gerrit Notification Bot from comment #2) > > Change 137733 merged by jenkins-bot: >... [03:43:22] 3Wikimedia / 3Mailing lists: List meta-oversight; adding an extra list maintainer, with existing list maintainer absent - 10https://bugzilla.wikimedia.org/66714#c5 (10billinghurst) Working as expected. Thanks for the prompt attendance to this matter. [03:52:58] ^d: So insource: will work on en.wiki? [04:09:12] (03CR) 10Legoktm: [C: 04-1] "Rather than requiring each caller to check is_array, create a static function that handles it and returns a bool." [core] - 10https://gerrit.wikimedia.org/r/140276 (https://bugzilla.wikimedia.org/66646) (owner: 10devunt) [04:18:54] (03PS1) 10MarkAHershberger: Merge branch 'REL1_22' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlockAndNuke into REL1_22 [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140279 [04:18:56] (03PS1) 10Wctaiwan: Tabify indent in en.json [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/140280 [04:21:27] (03CR) 10devunt: "Code usage is only 5 lines. Is this okay when implementing this with wf global function?" [core] - 10https://gerrit.wikimedia.org/r/140276 (https://bugzilla.wikimedia.org/66646) (owner: 10devunt) [04:21:29] (03CR) 10Legoktm: [C: 032] Tabify indent in en.json [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/140280 (owner: 10Wctaiwan) [04:21:32] (03PS1) 10Legoktm: Tabify indent in en.json [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/140281 [04:21:36] (03Merged) 10jenkins-bot: Tabify indent in en.json [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/140280 (owner: 10Wctaiwan) [04:21:45] (03CR) 10Legoktm: [C: 032] Tabify indent in en.json [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/140281 (owner: 10Legoktm) [04:21:53] (03Merged) 10jenkins-bot: Tabify indent in en.json [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/140281 (owner: 10Legoktm) [04:22:04] (03CR) 10MarkAHershberger: [C: 032] Merge branch 'REL1_22' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlockAndNuke into REL1_22 [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140279 (owner: 10MarkAHershberger) [04:30:52] (03PS7) 10devunt: [SHOULD BE ABANDONED] Changes autofocus="1" to autofocus="autofocus" [core] - 10https://gerrit.wikimedia.org/r/137670 (https://bugzilla.wikimedia.org/66134) (owner: 10Rohan013) [04:31:48] (03CR) 10devunt: "Should be resolved in Ic682a60ca4a08. please abandon this." [core] - 10https://gerrit.wikimedia.org/r/137670 (https://bugzilla.wikimedia.org/66134) (owner: 10Rohan013) [04:34:22] (03CR) 10Legoktm: [C: 031] "Added to Tech News (), I'll merge this af" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/136520 (owner: 10SPQRobin) [04:35:44] (03PS4) 1001tonythomas: Added i18n files. [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/140085 [04:36:22] legoktm: I though the alias.php file was required for the message to show up in Special:Version [04:36:49] no, that's just $wgExtensionCredits [04:38:17] oh. now its ok right ? [04:40:52] yup [04:40:59] (03PS5) 10Legoktm: Added i18n files. [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/140085 (owner: 1001tonythomas) [04:41:16] (03CR) 10Legoktm: [C: 032 V: 032] Added i18n files. [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/140085 (owner: 1001tonythomas) [04:41:44] legoktm: yay :) and this PHPStorm looks great. [04:41:50] :D [04:48:53] (03Abandoned) 10Legoktm: Add ZeroMQFeedEngine [core] - 10https://gerrit.wikimedia.org/r/105117 (owner: 10Legoktm) [04:51:55] (03PS4) 10Wctaiwan: Merge MassMessageBackend [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/140106 [04:52:19] (03PS2) 10MarkAHershberger: files from thepetwiki [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/120479 [04:52:21] (03PS1) 10MarkAHershberger: * Clean up hard-coded DB queries * Move some messages to the i18n file * Set a global for the whitelist instead of a hard-coded url * Indention * Change the whitelist [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140282 [04:52:23] (03PS1) 10MarkAHershberger: remove spurious reference to targetuser [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140283 [04:52:25] (03PS1) 10MarkAHershberger: style updates, whitelist global [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140284 [04:52:27] (03PS1) 10MarkAHershberger: remove useless function [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140285 [04:52:29] (03PS1) 10MarkAHershberger: * Add support for UserMerge if available * Don't attempt to delete page if it is already deleted * Show what will be deleted [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140286 [04:52:31] (03PS1) 10MarkAHershberger: add command line script that helps with mass banning and move shared code to BanPests.php [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140287 [04:52:33] (03PS1) 10MarkAHershberger: Update README.md [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140288 [04:52:35] (03PS1) 10MarkAHershberger: Update README.md [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140289 [04:52:37] (03PS1) 10MarkAHershberger: Update README.md [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140290 [04:52:39] (03PS1) 10MarkAHershberger: Fix Issue #1 [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140291 [04:52:41] (03PS1) 10MarkAHershberger: * Add IP blocking to web ui. * change i18n keys so that they are def unique * Fix issue #3 — list of users shows usernames as page links * Fix issue #2 — show message even when there is nothing to do and do something when there are no pages [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140292 [04:52:43] (03PS1) 10MarkAHershberger: thought these files were included in the previous commit [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140293 [04:52:45] (03PS1) 10MarkAHershberger: continuation of fix for issue #2 [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140294 [04:52:47] (03PS1) 10MarkAHershberger: continuation of fix for issue #2 [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140295 [04:52:49] (03PS1) 10MarkAHershberger: * Display blocked IPs/pages on special page [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140296 [04:52:51] (03PS1) 10MarkAHershberger: i18n [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140297 [04:52:53] (03PS1) 10MarkAHershberger: no escaping [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140298 [04:52:55] (03PS1) 10MarkAHershberger: some notices E_STRICT [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140299 [04:52:57] (03PS1) 10MarkAHershberger: Avoid some errors and make better output [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140300 [04:52:59] (03PS1) 10MarkAHershberger: fix a couple of bugs with the special page [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140301 [04:53:01] (03PS1) 10MarkAHershberger: Add error checking for whitelist and back compat to old variable name. [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140302 [04:53:03] (03PS1) 10MarkAHershberger: Initial attempt to fix capitalization typo [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140303 [04:53:05] (03PS1) 10MarkAHershberger: * Change display order to most recent editors/spammers * Remove deprecation * Make $um a more readable $userManager [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140304 [04:53:07] hexmode: what are you doing? [04:53:25] (03CR) 10Wctaiwan: "I'll add message documentation in the next patchset." (035 comments) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/140106 (owner: 10Wctaiwan) [04:54:31] (03PS7) 10Pastakhov: add objects support (version 2.0.0 hook release 3) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/135995 [05:31:30] (03CR) 10MarkAHershberger: [C: 032] * Change display order to most recent editors/spammers * Remove deprecation * Make $um a more readable $userManager [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140304 (owner: 10MarkAHershberger) [05:31:32] (03CR) 10MarkAHershberger: [C: 032] Initial attempt to fix capitalization typo [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140303 (owner: 10MarkAHershberger) [05:31:34] (03CR) 10MarkAHershberger: [C: 032] Add error checking for whitelist and back compat to old variable name. [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140302 (owner: 10MarkAHershberger) [05:31:36] (03CR) 10MarkAHershberger: [C: 032] fix a couple of bugs with the special page [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140301 (owner: 10MarkAHershberger) [05:31:38] (03CR) 10MarkAHershberger: [C: 032] Avoid some errors and make better output [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140300 (owner: 10MarkAHershberger) [05:31:40] (03CR) 10MarkAHershberger: [C: 032] some notices E_STRICT [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140299 (owner: 10MarkAHershberger) [05:31:42] (03CR) 10MarkAHershberger: [C: 032] no escaping [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140298 (owner: 10MarkAHershberger) [05:31:44] (03CR) 10MarkAHershberger: [C: 032] i18n [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140297 (owner: 10MarkAHershberger) [05:31:46] (03CR) 10MarkAHershberger: [C: 032] * Display blocked IPs/pages on special page [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140296 (owner: 10MarkAHershberger) [05:31:48] (03CR) 10MarkAHershberger: [C: 032] continuation of fix for issue #2 [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140295 (owner: 10MarkAHershberger) [05:31:50] (03CR) 10MarkAHershberger: [C: 032] continuation of fix for issue #2 [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140294 (owner: 10MarkAHershberger) [05:31:52] (03CR) 10MarkAHershberger: [C: 032] thought these files were included in the previous commit [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140293 (owner: 10MarkAHershberger) [05:31:54] (03CR) 10MarkAHershberger: [C: 032] * Add IP blocking to web ui. * change i18n keys so that they are def unique * Fix issue #3 — list of users shows usernames as page links * F [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140292 (owner: 10MarkAHershberger) [05:31:56] (03CR) 10MarkAHershberger: [C: 032] Fix Issue #1 [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140291 (owner: 10MarkAHershberger) [05:31:58] (03CR) 10MarkAHershberger: [C: 032] Update README.md [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140290 (owner: 10MarkAHershberger) [05:32:00] (03CR) 10MarkAHershberger: [C: 032] Update README.md [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140289 (owner: 10MarkAHershberger) [05:32:02] (03CR) 10MarkAHershberger: [C: 032] Update README.md [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140288 (owner: 10MarkAHershberger) [05:32:04] (03CR) 10MarkAHershberger: [C: 032] add command line script that helps with mass banning and move shared code to BanPests.php [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140287 (owner: 10MarkAHershberger) [05:32:06] (03CR) 10MarkAHershberger: [C: 032] * Add support for UserMerge if available * Don't attempt to delete page if it is already deleted * Show what will be deleted [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140286 (owner: 10MarkAHershberger) [05:32:08] (03CR) 10MarkAHershberger: [C: 032] remove useless function [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140285 (owner: 10MarkAHershberger) [05:32:10] (03CR) 10MarkAHershberger: [C: 032] style updates, whitelist global [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140284 (owner: 10MarkAHershberger) [05:32:12] (03CR) 10MarkAHershberger: [C: 032] remove spurious reference to targetuser [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140283 (owner: 10MarkAHershberger) [05:32:14] (03CR) 10MarkAHershberger: [C: 032] * Clean up hard-coded DB queries * Move some messages to the i18n file * Set a global for the whitelist instead of a hard-coded url * Indent [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/140282 (owner: 10MarkAHershberger) [05:32:16] (03CR) 10MarkAHershberger: [C: 032] files from thepetwiki [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/120479 (owner: 10MarkAHershberger) [05:34:02] (03CR) 10Nemo bis: files from thepetwiki (031 comment) [extensions/BlockAndNuke] (REL1_22) - 10https://gerrit.wikimedia.org/r/120479 (owner: 10MarkAHershberger) [06:08:08] 3MediaWiki extensions / 3WikidataRepo: cannot reorder snaks within a reference - 10https://bugzilla.wikimedia.org/65695#c2 (10Aude) 5RESO/FIX>3REOP still broken for me. try reordering things in the reference for Michael Bloomberg: https://www.wikidata.org/wiki/Q60 [06:19:02] (03PS3) 10Legoktm: Create ResourceLoaderUncachedRegistrationModule [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/127461 (https://bugzilla.wikimedia.org/62602) [06:24:14] (03CR) 10Legoktm: API: Allow user to specify what notification types they want or don't want (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/137246 (https://bugzilla.wikimedia.org/57043) (owner: 10Legoktm) [06:24:17] (03PS3) 10Legoktm: API: Allow user to specify what notification types they want or don't want [extensions/Echo] - 10https://gerrit.wikimedia.org/r/137246 (https://bugzilla.wikimedia.org/57043) [06:25:24] ori: I updated https://gerrit.wikimedia.org/r/#/c/127461/ finally :P [06:39:24] 3MediaWiki extensions / 3Translate: Deprecated: Use of SpecialRecentChangesQuery hook (used in TranslateRcFilter::translationFilter) - 10https://bugzilla.wikimedia.org/65776 (10Southparkfan) [06:40:22] 3MediaWiki extensions / 3[other]: [HTMLets] Deprecated preg_replace(): The /e modifier is deprecated in HTMLets - 10https://bugzilla.wikimedia.org/66706#c2 (10jongfeli) Created attachment 15681 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15681&action=edit HTMLets.php patch [06:41:52] (03PS1) 10Gerrit Patch Uploader: HTMLets.php patch [extensions/HTMLets] - 10https://gerrit.wikimedia.org/r/140311 (https://bugzilla.wikimedia.org/66706) [06:41:57] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/HTMLets] - 10https://gerrit.wikimedia.org/r/140311 (https://bugzilla.wikimedia.org/66706) (owner: 10Gerrit Patch Uploader) [06:48:19] (03PS8) 10Pastakhov: add objects support (version 2.0.0 hook release 3) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/135995 [06:49:52] 3MediaWiki extensions / 3GlobalCssJs: Global JS module version not updating properly - 10https://bugzilla.wikimedia.org/62602#c16 (10Krinkle) Okay, there's tons of messages back and forth and implementation has changed many times. A fresh brain dump: 1) The startup module can't be relied upon for user spec... [06:59:11] (03PS2) 10Divec: Use LinearDoc for segmentation [services/cxserver] - 10https://gerrit.wikimedia.org/r/138532 [06:59:35] (03CR) 10jenkins-bot: [V: 04-1] Use LinearDoc for segmentation [services/cxserver] - 10https://gerrit.wikimedia.org/r/138532 (owner: 10Divec) [07:00:14] (03PS5) 10Wctaiwan: Merge MassMessageBackend [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/140106 [07:06:44] (03CR) 10Legoktm: [C: 04-1] "Sorry, missed this earlier. The new specialpages need aliases in MassMessage.alias.php." [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/140106 (owner: 10Wctaiwan) [07:13:55] (03PS6) 10Wctaiwan: Merge MassMessageBackend [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/140106 [07:19:21] (03CR) 10Nemo bis: "Special:Notifications is not where one normally controls notifications (Echo maintainers defined it as a mere archive feature), I don't co" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/140038 (owner: 10Jdlrobson) [07:20:34] (03CR) 10Legoktm: [C: 032] Merge MassMessageBackend [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/140106 (owner: 10Wctaiwan) [07:20:38] (03PS7) 10Nemo bis: Put Watchlist preferences on the watchlist itself [core] - 10https://gerrit.wikimedia.org/r/139872 (https://bugzilla.wikimedia.org/31881) (owner: 10Jdlrobson) [07:20:42] (03Merged) 10jenkins-bot: Merge MassMessageBackend [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/140106 (owner: 10Wctaiwan) [07:20:55] (03CR) 10Legoktm: Merge MassMessageBackend (031 comment) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/140106 (owner: 10Wctaiwan) [07:27:31] (03CR) 10Nemo bis: [C: 04-1] "Thanks for working on this. If you want users to more clearly perceive the benefit of this, and to avoid regressions as regards bug 31882," [core] - 10https://gerrit.wikimedia.org/r/139872 (https://bugzilla.wikimedia.org/31881) (owner: 10Jdlrobson) [07:29:05] (03CR) 10Nemo bis: "This change would help https://gerrit.wikimedia.org/r/#/c/139872/7 by Jon greatly." [core] - 10https://gerrit.wikimedia.org/r/125762 (https://bugzilla.wikimedia.org/63577) (owner: 1001tonythomas) [07:29:55] 3MediaWiki skins / 3Chameleon: TOC needs styling - 10https://bugzilla.wikimedia.org/66766 (10s7eph4n) 3NEW p:3Unprio s:3normal a:3s7eph4n The table of contents needs styling. [07:31:29] (03CR) 10Divec: Use LinearDoc for segmentation (033 comments) [services/cxserver] - 10https://gerrit.wikimedia.org/r/138532 (owner: 10Divec) [07:32:24] 3MediaWiki / 3Skin and page rendering: Adding "license-name" to $wgExtensionCredits causes the display of license to break - 10https://bugzilla.wikimedia.org/66767 (10[[kgh]]) 3NEW p:3Unprio s:3major a:3None I am quoting Nikerabbit as he observed this: "When the 'license-name' key is specified, this... [07:32:35] (03CR) 10Nemo bis: "Thank you! This helped bug 41085." [core] - 10https://gerrit.wikimedia.org/r/132589 (owner: 10SPQRobin) [07:34:07] 3MediaWiki / 3API: User contributions feed should match index.php feed format (diff etc.) - 10https://bugzilla.wikimedia.org/41085#c8 (10Nemo) After https://gerrit.wikimedia.org/r/#/c/132589/ by Robin, the feed items link the diff, but the content is still the whole page (just tested on mediawiki.org). [07:36:50] (03CR) 10Nemo bis: "Are you saying bug 49719 was fixed only for own account creation? IF yes that's a bug that should be filed to avoid losing track of it." [core] - 10https://gerrit.wikimedia.org/r/107043 (owner: 10Yuvipanda) [07:40:24] 3MediaWiki skins / 3Chameleon: Component Wikitext - 10https://bugzilla.wikimedia.org/66768 (10s7eph4n) 3NEW p:3Unprio s:3enhanc a:3s7eph4n Add a component, that renders wikitext. That would enable to have standard texts (e.g additional menus, toc, info boxes) on pre-defined grid-positions for all wi... [07:48:47] (03PS9) 10TTO: Allow interlanguage link prefixes that are not language codes [core] - 10https://gerrit.wikimedia.org/r/111390 (https://bugzilla.wikimedia.org/32189) [07:49:17] (03PS7) 10Krinkle: Add es5-shim library v3.4.0 [core] - 10https://gerrit.wikimedia.org/r/139308 (owner: 10Jforrester) [07:56:22] 3Wikimedia / 3Mailing lists: african-wikimedians - 10https://bugzilla.wikimedia.org/65959#c6 (10Tomasz W. Kozlowski) @Rexford: Before I create the list for you, I require the following information: 1. Should list archives be public or private? 2. Should new subscriptions be approved by list moderato... [08:12:50] (03PS1) 10TTO: Change name of Tahitian language [core] - 10https://gerrit.wikimedia.org/r/140312 (https://bugzilla.wikimedia.org/65985) [08:13:17] (03PS3) 10Santhosh: Use LinearDoc for segmentation [services/cxserver] - 10https://gerrit.wikimedia.org/r/138532 (owner: 10Divec) [08:14:08] 3MediaWiki / 3Internationalization: Change name of Tahitian language from "Reo Mā`ohi" to "reo mā’ohi" - 10https://bugzilla.wikimedia.org/65985#c5 (10This, that and the other) Sorry this took me so long! I forgot about it. [08:14:21] (03CR) 10jenkins-bot: [V: 04-1] Use LinearDoc for segmentation [services/cxserver] - 10https://gerrit.wikimedia.org/r/138532 (owner: 10Divec) [08:18:57] 3MediaWiki extensions / 3WikidataRepo: Allow redirects to be created via EntityStore - 10https://bugzilla.wikimedia.org/66073#c1 (10Thiemo Mättig) 5ASSI>3PATC https://gerrit.wikimedia.org/r/#/c/139830 [08:21:37] 3MediaWiki / 3JobQueue: Special:RunJobs recursively calling Special:RunJobs again (?) - 10https://bugzilla.wikimedia.org/66225#c2 (10Christian Kujau) Same here with v1.23.0: for every request, the following gets logged into access.log: ::ffff:11.22.33.44 - - [18/Jun/2014:09:58:14 +0200] "POST /mediawiki/ind... [08:22:45] (03PS1) 10Hashar: Register some more extensions [extensions] - 10https://gerrit.wikimedia.org/r/140313 [08:22:57] (03PS2) 10Hashar: Register some more extensions [extensions] - 10https://gerrit.wikimedia.org/r/140313 [08:23:05] (03CR) 10Hashar: [C: 032 V: 032] Register some more extensions [extensions] - 10https://gerrit.wikimedia.org/r/140313 (owner: 10Hashar) [08:25:08] 3MediaWiki / 3Skin and page rendering: Adding "license-name" to $wgExtensionCredits requires COPYING to be in wikitext - 10https://bugzilla.wikimedia.org/66767 (10[[kgh]]) [08:26:06] (03PS1) 10Hashar: Jobs for mw/ext/BounceHandler [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/140314 [08:27:47] (03PS2) 10Hashar: Jobs for mw/ext/BounceHandler [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/140314 (https://bugzilla.wikimedia.org/66703) [08:28:02] (03PS1) 10Hashar: Triggers for BounceHandler extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/140315 (https://bugzilla.wikimedia.org/66703) [08:30:46] (03CR) 10Hashar: [C: 032] "Jobs deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/140314 (https://bugzilla.wikimedia.org/66703) (owner: 10Hashar) [08:31:11] (03Merged) 10jenkins-bot: Jobs for mw/ext/BounceHandler [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/140314 (https://bugzilla.wikimedia.org/66703) (owner: 10Hashar) [08:32:12] (03CR) 10Hashar: [C: 032] Triggers for BounceHandler extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/140315 (https://bugzilla.wikimedia.org/66703) (owner: 10Hashar) [08:32:28] (03Merged) 10jenkins-bot: Triggers for BounceHandler extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/140315 (https://bugzilla.wikimedia.org/66703) (owner: 10Hashar) [08:33:34] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/140316 [08:33:56] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/140316 (owner: 10Hashar) [08:35:20] (03CR) 10Santhosh: [C: 04-1] "The apis are not returning results. Did not debug." (033 comments) [services/cxserver] - 10https://gerrit.wikimedia.org/r/138532 (owner: 10Divec) [08:39:10] 3MediaWiki / 3JobQueue: POST-request, but content-length missing -> 411 - 10https://bugzilla.wikimedia.org/66769 (10Christian Kujau) 3NEW p:3Unprio s:3normal a:3None For every request, lighttpd/1.4.31 was logging the following to error.log: 2014-06-18 10:13:56: (request.c.1148) POST-request, but con... [08:44:49] (03PS3) 10PleaseStand: Remove $wgBrowserBlackList and associated EditPage code [core] - 10https://gerrit.wikimedia.org/r/138840 (https://bugzilla.wikimedia.org/65297) [08:46:00] (03CR) 10jenkins-bot: [V: 04-1] Remove $wgBrowserBlackList and associated EditPage code [core] - 10https://gerrit.wikimedia.org/r/138840 (https://bugzilla.wikimedia.org/65297) (owner: 10PleaseStand) [08:48:32] (03PS1) 10Aude: Remove extra UserGroups submodule entry [extensions] - 10https://gerrit.wikimedia.org/r/140317 [08:49:12] (03PS4) 10PleaseStand: Remove $wgBrowserBlackList and associated EditPage code [core] - 10https://gerrit.wikimedia.org/r/138840 (https://bugzilla.wikimedia.org/65297) [08:55:23] 3MediaWiki extensions / 3ParserFunctions: {{#time | + time interval}} does not give satisfying results at the end of a month - 10https://bugzilla.wikimedia.org/35608#c4 (10Nemo) 5NEW>3RESO/WON This is a PHP bug, closed invalid upstream. https://bugs.php.net/bug.php?id=22486 Nothing we're going to do here... [08:55:55] 3Analytics / 3Wikimetrics: Config override for queue.yaml from test.yaml is not working well - 10https://bugzilla.wikimedia.org/66770 (10nuria) 3NEW p:3Unprio s:3normal a:3None Config override for queue.yaml from test.yaml is not working well. CELERY_ALWAYS_EAGER value is not overriden correctly. [09:05:11] (03CR) 10PleaseStand: "Something I thought of when working on If3678912: won't hacks be necessary to allow both x-encoded and Unicode form submissions during a t" [core] - 10https://gerrit.wikimedia.org/r/110589 (https://bugzilla.wikimedia.org/60677) (owner: 10Brion VIBBER) [09:14:38] 3MediaWiki / 3Parser: RTL/bidirectional issues (tracking) - 10https://bugzilla.wikimedia.org/745 (10Amir E. Aharoni) [09:17:23] 3MediaWiki / 3API: action=feedcontributions explodes on showsizediff in miser mode - 10https://bugzilla.wikimedia.org/33214#c8 (10Nemo) Adding kaligula given the wonderful work at bug 25325. [09:18:09] 3MediaWiki / 3ResourceLoader: ResourceLoaderLESSFunctions::embed does not support CSSJanus flipping for RTL - 10https://bugzilla.wikimedia.org/66091 (10Amir E. Aharoni) [09:18:09] 3MediaWiki / 3Parser: RTL/bidirectional issues (tracking) - 10https://bugzilla.wikimedia.org/745 (10Amir E. Aharoni) [09:22:38] 3MediaWiki / 3ResourceLoader: ResourceLoaderLESSFunctions::embed does not support CSSJanus flipping for RTL - 10https://bugzilla.wikimedia.org/66091 (10Amir E. Aharoni) [09:22:38] 3MediaWiki / 3Parser: RTL/bidirectional issues (tracking) - 10https://bugzilla.wikimedia.org/745 (10Amir E. Aharoni) [09:22:39] 3MediaWiki / 3Skin and page rendering: Arrow with mw-icon-arrow-collapsed points the wrong way in RTL wikis - 10https://bugzilla.wikimedia.org/66773 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Arrow with mw-icon-arrow-collapsed points the wrong way in RTL wikis. This probably happens becaus... [09:23:52] 3MediaWiki / 3Skin and page rendering: Arrow with mw-icon-arrow-collapsed points the wrong way in RTL wikis - 10https://bugzilla.wikimedia.org/66773#c1 (10Amir E. Aharoni) For an example, go to https://he.wikipedia.org/w/index.php?title=ASCII&action=edit Notice the indicators in the "templates used on this... [09:32:42] (03PS8) 10Adrian Lang: Correct CompletenessTest::walkTheObject behaviour wrt breadcrumb [core] - 10https://gerrit.wikimedia.org/r/121604 [09:33:25] (03CR) 10Adrian Lang: "8 is a rebase." [core] - 10https://gerrit.wikimedia.org/r/121604 (owner: 10Adrian Lang) [09:38:59] (03PS2) 10Hashar: Remove extra UserGroups submodule entry [extensions] - 10https://gerrit.wikimedia.org/r/140317 (owner: 10Aude) [09:39:10] (03CR) 10Hashar: [C: 032 V: 032] Remove extra UserGroups submodule entry [extensions] - 10https://gerrit.wikimedia.org/r/140317 (owner: 10Aude) [09:39:23] If I want two tables to be created when update.php is run for my extension, should it go under different files or, the same ? [09:40:28] (03PS1) 10QChris: Switch .gitreview to new repo name [services/citoid] - 10https://gerrit.wikimedia.org/r/140324 [09:40:42] (03PS9) 10Pastakhov: add objects support (version 2.0.0 hook release 3) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/135995 [09:51:03] 3MediaWiki / 3ResourceLoader: ResourceLoaderLESSFunctions::embed does not support CSSJanus flipping for RTL - 10https://bugzilla.wikimedia.org/66091 (10Andre Klapper) p:5Unprio>3High [09:55:03] 3MediaWiki / 3ResourceLoader: ResourceLoaderLESSFunctions::embed does not support CSSJanus flipping for RTL - 10https://bugzilla.wikimedia.org/66091#c2 (10Amir E. Aharoni) I'm finding more and more issues that are caused by this, so it should be addressed some time soon. [09:56:49] (03Abandoned) 10Rohan013: [SHOULD BE ABANDONED] Changes autofocus="1" to autofocus="autofocus" [core] - 10https://gerrit.wikimedia.org/r/137670 (https://bugzilla.wikimedia.org/66134) (owner: 10Rohan013) [09:58:17] (03CR) 10Gilles: [C: 032] Only do pop up video player if we actually have a bigger size [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/138307 (owner: 10Brian Wolff) [09:58:26] (03Merged) 10jenkins-bot: Only do pop up video player if we actually have a bigger size [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/138307 (owner: 10Brian Wolff) [10:02:15] (03CR) 10Gilles: Workaround image magick issue with greyscale xcf files (031 comment) [core] - 10https://gerrit.wikimedia.org/r/138213 (https://bugzilla.wikimedia.org/66323) (owner: 10Brian Wolff) [10:03:35] (03CR) 10Adrian Lang: Correct CompletenessTest::walkTheObject behaviour wrt breadcrumb (033 comments) [core] - 10https://gerrit.wikimedia.org/r/121604 (owner: 10Adrian Lang) [10:03:42] (03PS9) 10Adrian Lang: Correct CompletenessTest::walkTheObject behaviour wrt breadcrumb [core] - 10https://gerrit.wikimedia.org/r/121604 [10:04:33] 3MediaWiki / 3Page editing: Edit conflict detection suffers a race condition - 10https://bugzilla.wikimedia.org/56849#c16 (10Andre Klapper) (In reply to Adam Wight from comment #13) > I'm still working on the main patch, but these predecessors are ready for > review: > > https://gerrit.wikimedia.org/r/#/c/1... [10:07:32] (03CR) 10jenkins-bot: [V: 04-1] Correct CompletenessTest::walkTheObject behaviour wrt breadcrumb [core] - 10https://gerrit.wikimedia.org/r/121604 (owner: 10Adrian Lang) [10:08:05] 3MediaWiki extensions / 3BookManagerv2: Remove [[category:book:book_name]] from the section when removed from section list. - 10https://bugzilla.wikimedia.org/66774 (10Deepali Jain) 3NEW p:3Unprio s:3normal a:3None During editing the book, [[category:book:book_name]] should be removed from the sectio... [10:08:57] (03CR) 10Gilles: "Aside from the docs, I have a general question: do you know why the metadata results are serialized? I know that you've followed what's do" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/138213 (https://bugzilla.wikimedia.org/66323) (owner: 10Brian Wolff) [10:09:18] (03PS10) 10Adrian Lang: Correct CompletenessTest::walkTheObject behaviour wrt breadcrumb [core] - 10https://gerrit.wikimedia.org/r/121604 [10:10:48] 3MediaWiki skins / 3Chameleon: Add a component that renders wikitext - 10https://bugzilla.wikimedia.org/66768 (10Andre Klapper) [10:12:49] 3MediaWiki / 3Skin and page rendering: Adding "license-name" to $wgExtensionCredits requires COPYING to be in wikitext - 10https://bugzilla.wikimedia.org/66767 (10Andre Klapper) p:5Unprio>3Normal [10:17:20] 3MediaWiki extensions / 3BookManagerv2: Add category:Book:Book_name to all pages when new sections are imported. - 10https://bugzilla.wikimedia.org/66775 (10Deepali Jain) 3NEW p:3Unprio s:3normal a:3None When a section list is imported, an ajax call to edit action of api is made which should add [[ca... [10:23:33] (03CR) 10Krinkle: [C: 031] "Looks good. Untested." [core] - 10https://gerrit.wikimedia.org/r/121604 (owner: 10Adrian Lang) [10:32:33] 3MediaWiki extensions / 3WikidataRepo: Move JS datamodel code into its own component - 10https://bugzilla.wikimedia.org/66418 (10Adrian Lang) 5PATC>3RESO/FIX [10:34:43] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Guys, I know the code looks really scary. It is. Still somebody needs to hit +2 to make it less scary. Adrian and I spend hours to make su" [core] - 10https://gerrit.wikimedia.org/r/121604 (owner: 10Adrian Lang) [10:47:31] Hi there, I want to add a new feature to an API call, is this the right channel to ask for help!? [10:47:46] probably. [10:48:12] (03PS10) 10Pastakhov: add objects support (version 2.0.0 hook release 3) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/135995 [10:49:29] Excellent :) well, I wrote some little modification to allow sorting the results in the call to ApiQueryExternalLinks. I'm a little lost on how to get this tested and merged if possible [10:50:43] (03CR) 10Mvolz: [C: 032 V: 032] Switch .gitreview to new repo name [services/citoid] - 10https://gerrit.wikimedia.org/r/140324 (owner: 10QChris) [10:51:02] This is the diff is pretty simple, http://pastebin.com/TCD2WRLF [10:51:32] ineditable: if you want to do mediawiki development, our code review system is gerrit (tutorial at http://www.mediawiki.org/wiki/Gerrit/Tutorial for setting up a development environment) [10:51:50] for simple patches / if you don't want to go through all that hassle there's a gerrit patch uploader [10:52:05] https://tools.wmflabs.org/gerrit-patch-uploader/ [10:52:28] Many thanks for the information, because this little patch does not deserve all the work! [10:54:32] np. Depending on your current setup "all the work" may be less than you think, though. That page spends a lot of time going through things like SSH and git. (Though admittedly it isn't that painless a process either.) [10:54:54] it's probably worth it if you plan on submitting other patches in the future [10:55:17] I'll consider it if more ideas and needs come to mind :) [10:56:25] okay [11:07:12] (03PS1) 1001tonythomas: Added Table to store email-hash mappings ( EXPERIMENTAL ) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/140330 [11:07:14] (03CR) 10jenkins-bot: [V: 04-1] Added Table to store email-hash mappings ( EXPERIMENTAL ) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/140330 (owner: 1001tonythomas) [11:18:47] (03PS2) 1001tonythomas: Added Table to store email-hash mappings ( EXPERIMENTAL ) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/140330 [11:19:07] (03PS1) 10Divec: Better error handling [services/cxserver] - 10https://gerrit.wikimedia.org/r/140332 [11:24:07] (03PS15) 1001tonythomas: Added VERP functionality hook to core [core] - 10https://gerrit.wikimedia.org/r/138655 (https://bugzilla.wikimedia.org/46640) [11:27:28] (03PS1) 10Gerrit Patch Uploader: Allows to set an optional sorting mode for the results of the API call. [core] - 10https://gerrit.wikimedia.org/r/140333 [11:27:30] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/140333 (owner: 10Gerrit Patch Uploader) [11:27:34] ^ yay! [11:30:12] (03CR) 10Santhosh: [C: 032] Better error handling [services/cxserver] - 10https://gerrit.wikimedia.org/r/140332 (owner: 10Divec) [11:30:39] (03Merged) 10jenkins-bot: Better error handling [services/cxserver] - 10https://gerrit.wikimedia.org/r/140332 (owner: 10Divec) [11:33:44] ineditable: congrats :) [11:34:23] Thank you! I'm reading next steps :) [11:34:27] :) [11:35:54] (03PS4) 10Divec: Use LinearDoc for segmentation [services/cxserver] - 10https://gerrit.wikimedia.org/r/138532 [11:36:19] (03CR) 10Divec: "PS4: rebase" [services/cxserver] - 10https://gerrit.wikimedia.org/r/138532 (owner: 10Divec) [11:36:21] (03CR) 10jenkins-bot: [V: 04-1] Use LinearDoc for segmentation [services/cxserver] - 10https://gerrit.wikimedia.org/r/138532 (owner: 10Divec) [11:38:09] (03PS5) 10Divec: Use LinearDoc for segmentation [services/cxserver] - 10https://gerrit.wikimedia.org/r/138532 [11:38:31] (03CR) 10jenkins-bot: [V: 04-1] Use LinearDoc for segmentation [services/cxserver] - 10https://gerrit.wikimedia.org/r/138532 (owner: 10Divec) [11:39:06] 3MediaWiki / 3API: API output containing is corrupted in non-XML formats - 10https://bugzilla.wikimedia.org/66776 (10Kevin Israel (PleaseStand)) 3NEW p:3Unprio s:3normal a:3None The wfMangleFlashPolicy() function in OutputHandler.php corrupts API output containing " (03CR) 10Paladox: "Ok." [core] - 10https://gerrit.wikimedia.org/r/139688 (owner: 10Paladox) [11:44:08] (03PS2) 10Paladox: Update jquery.form.js [core] - 10https://gerrit.wikimedia.org/r/139688 [11:45:19] 3MediaWiki extensions / 3WikidataRepo: Suggester changes input if an alias matches - 10https://bugzilla.wikimedia.org/66748 (10Lydia Pintscher) p:5Unprio>3Highes s:5major>3critic [11:45:48] 3MediaWiki extensions / 3WikidataRepo: Suggester changes input if an alias matches - 10https://bugzilla.wikimedia.org/66748 (10Lydia Pintscher) [11:47:24] (03PS4) 10Paladox: Update jquery.chosen folder and files [core] - 10https://gerrit.wikimedia.org/r/139699 [11:47:52] (03PS8) 10Paladox: mediawiki.searchSuggest: Enable for iPhone and iPod touch [core] - 10https://gerrit.wikimedia.org/r/139809 [11:50:53] (03CR) 10Parent5446: [C: 04-1] Added VERP functionality hook to core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/138655 (https://bugzilla.wikimedia.org/46640) (owner: 1001tonythomas) [11:51:05] (03PS1) 10SG: Add support for Function callback override to API calls [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140334 [11:51:39] (03CR) 10jenkins-bot: [V: 04-1] Add support for Function callback override to API calls [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140334 (owner: 10SG) [11:51:51] (03CR) 10Paladox: "Difference between r5 and r7 is" [core] - 10https://gerrit.wikimedia.org/r/139687 (owner: 10Paladox) [11:54:23] (03PS3) 10Paladox: Update jquery.hoverintent.js [core] - 10https://gerrit.wikimedia.org/r/139687 [11:55:32] (03PS4) 10Paladox: Update jquery.hoverintent.js [core] - 10https://gerrit.wikimedia.org/r/139687 [11:56:02] (03PS5) 10Paladox: Update jquery.hoverintent.js [core] - 10https://gerrit.wikimedia.org/r/139687 [11:57:48] 3MediaWiki / 3Special pages: Add date and time of protection event to Special:Protectedpages - 10https://bugzilla.wikimedia.org/9361#c6 (10This, that and the other) 5NEW>3RESO/FIX Was fixed in Gerrit change 105443. [12:00:05] 3MediaWiki / 3Special pages: No way to back-fill log_search with protection information (causing missing data in Special:ProtectedPages) - 10https://bugzilla.wikimedia.org/66777 (10This, that and the other) 3NEW p:3Unprio s:3enhanc a:3None The log_search table began to be populated with protection-re... [12:00:05] 3MediaWiki / 3Special pages: Add date and time of protection event to Special:Protectedpages - 10https://bugzilla.wikimedia.org/9361 (10This, that and the other) [12:03:34] (03PS1) 10Hashar: Only notify qa-alerts (drops qa list) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/140335 [12:06:31] (03PS2) 10Hashar: Only notify qa-alerts (drops qa list) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/140335 [12:06:50] (03CR) 10jenkins-bot: [V: 04-1] Only notify qa-alerts (drops qa list) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/140335 (owner: 10Hashar) [12:06:59] (03CR) 10Hashar: [C: 032] Only notify qa-alerts (drops qa list) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/140335 (owner: 10Hashar) [12:08:20] (03Merged) 10jenkins-bot: Only notify qa-alerts (drops qa list) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/140335 (owner: 10Hashar) [12:08:43] (03PS6) 10Divec: Use LinearDoc for segmentation [services/cxserver] - 10https://gerrit.wikimedia.org/r/138532 [12:09:14] (03CR) 10jenkins-bot: [V: 04-1] Use LinearDoc for segmentation [services/cxserver] - 10https://gerrit.wikimedia.org/r/138532 (owner: 10Divec) [12:18:50] (03CR) 10Ineditable: "This patch has a little error, a missing white-space, not sure how to close it! I'm currently uploading an updated version, which also sol" [core] - 10https://gerrit.wikimedia.org/r/140333 (owner: 10Gerrit Patch Uploader) [12:19:15] (03PS1) 10Gerrit Patch Uploader: Allows to set an optional sorting mode for the results of the API call. [core] - 10https://gerrit.wikimedia.org/r/140336 [12:19:17] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/140336 (owner: 10Gerrit Patch Uploader) [12:22:34] 3Analytics / 3Wikistats: Wikistats revert percentages are far too low in newest reports - 10https://bugzilla.wikimedia.org/66471#c1 (10Erik Zachte) 5NEW>3RESO/FIX Bug fixed. Reparsing dumps (takes a little over a week). before http://stats.wikimedia.org/EN/PlotEditsNL.png after http://stats.wikimedia.or... [12:25:10] ah!, I think I've done wrong, I re-uploaded with hopes to close the previous patch, instead of just amending. [12:27:42] (03PS1) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/140338 [12:30:14] Well, I'm sorry ! I need to close the following please: https://gerrit.wikimedia.org/r/#/c/140333/ because new version ( https://gerrit.wikimedia.org/r/#/c/140336/ ) takes care of the little error [12:30:20] 3Utilities / 3mwdumper: mwdumper fails to import English wikipedia dump: ArrayIndexOutOfBoundsException; error in SQL syntax - 10https://bugzilla.wikimedia.org/57236#c7 (10mad2one48) piotr did you find out the problem ? [12:30:42] (03CR) 10Gilles: complex categories (031 comment) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/139410 (owner: 10Dan-nl) [12:32:24] (03PS2) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/140089 [12:33:03] 3MediaWiki extensions / 3WikidataRepo: Exception from line 282 of EntityHandler.php - 10https://bugzilla.wikimedia.org/66632#c8 (10Jeroen De Dauw) Aude, can you confirm this is fixed now? [12:33:35] 3Wikimedia / 3Bugzilla: Top 10 people who resolved the most reports in the last 7 days: link on Weekly Summary page doesn't work - 10https://bugzilla.wikimedia.org/66778 (10Tomasz W. Kozlowski) 3ASSI p:3Unprio s:3normal a:3Tomasz W. Kozlowski Because it doesn't have a href attribute. Let's just add... [12:33:48] 3Wikimedia / 3Bugzilla: Top 10 people who resolved the most reports in the last 7 days: link on Weekly Summary page doesn't work - 10https://bugzilla.wikimedia.org/66778 (10Tomasz W. Kozlowski) p:5Unprio>3Low [12:35:50] (03PS2) 10Ineditable: [To Close, I'm sorry] Allows to set an optional sorting mode for the results of the API call. [core] - 10https://gerrit.wikimedia.org/r/140333 (owner: 10Gerrit Patch Uploader) [12:42:23] (03CR) 10Gilles: [C: 04-1] Allow for custom templates (033 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/133684 (https://bugzilla.wikimedia.org/63889) (owner: 10Dan-nl) [12:43:48] (03PS1) 10Amire80: Improved the punctuation and the readability of some messages [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/140339 [12:45:39] * YuviPanda waves at prtksxna [12:50:04] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Reference markers in section names - 10https://bugzilla.wikimedia.org/66733 (10Nik Everett) 5PATC>3RESO/FIX [12:52:22] what is Anomie's timezone? [12:56:13] (03PS3) 10Paladox: Update moment folder and files [core] - 10https://gerrit.wikimedia.org/r/139698 [12:56:19] 3MediaWiki extensions / 3WikidataClient: Under HHVM: Call to a member function getGuid() on a non-object - 10https://bugzilla.wikimedia.org/65698#c4 (10Ori Livneh) 5NEW>3RESO/FIX Upstream PR merged. [12:57:04] 3Wikimedia / 3Bugzilla: Top 10 people who resolved the most reports in the last 7 days: link on Weekly Summary page doesn't work - 10https://bugzilla.wikimedia.org/66778#c2 (10Andre Klapper) Upstream, for the records: https://projects.kde.org/projects/websites/bugs-kde-org/repository/revisions/f24e4c815e8b69... [12:57:48] 3MediaWiki / 3Parser: Add a link parser function - 10https://bugzilla.wikimedia.org/66746 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [12:58:03] 3MediaWiki / 3General/Unknown: MWHttpRequest check for noproxy is inverted - 10https://bugzilla.wikimedia.org/66757 (10Andre Klapper) p:5Unprio>3Normal [12:58:18] 3MediaWiki extensions / 3CirrusSearch: Allow search in the raw wiki text source via insource: - 10https://bugzilla.wikimedia.org/65783#c5 (10Nik Everett) (In reply to Chad H. from comment #4) > (In reply to MZMcBride from comment #3) > > (In reply to Gerrit Notification Bot from comment #2) > > > Change 1377... [12:59:18] 3MediaWiki / 3Special pages: Move "Special:MyLanguage" from Extension:Translate to MediaWiki core - 10https://bugzilla.wikimedia.org/66762 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [13:01:19] 3Wikimedia / 3Bugzilla: Top 10 people who resolved the most reports in the last 7 days: link on Weekly Summary page doesn't work - 10https://bugzilla.wikimedia.org/66778#c3 (10Tomasz W. Kozlowski) Should we upstream this to the KDE Bugzilla? They require you to have a KDE identity to be able to push to thei... [13:04:20] 3MediaWiki extensions / 3CirrusSearch: Call to undefined method Elastica\Exception\Bulk\ResponseException::getResponse () in ElasticsearchIntermediary.php on line 171 - 10https://bugzilla.wikimedia.org/66780 (10Aude) 3NEW p:3Unprio s:3normal a:3None could be i have wrong version of something although... [13:05:06] 3Analytics / 3General/Unknown: stat1001's returning 503s for public-datasets - 10https://bugzilla.wikimedia.org/66781 (10christian) 3NEW p:3Unprio s:3normal a:3None Urls to public datasets on stat1001 like for example http://stat1001.wikimedia.org/limn-public-data/mobile/datafiles/edits-monthly-ac... [13:05:40] (03PS4) 10Hashar: beta: update job for cxserver [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/139336 [13:07:42] (03PS4) 10Paladox: Update moment folder and files [core] - 10https://gerrit.wikimedia.org/r/139698 [13:08:18] 3MediaWiki extensions / 3CirrusSearch: Call to undefined method Elastica\Exception\Bulk\ResponseException::getResponse() in ElasticsearchIntermediary.php on line 171 - 10https://bugzilla.wikimedia.org/66780#c1 (10Nik Everett) Uhg! Can you add the hashes of Elastica, CirrusSearch, and core just to be sure? I... [13:08:49] (03CR) 10Hashar: [C: 031] "I have updated the Jenkins and retriggered it manually:" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/139336 (owner: 10Hashar) [13:10:32] (03PS5) 10Paladox: Update moment folder and files [core] - 10https://gerrit.wikimedia.org/r/139698 [13:11:42] (03PS1) 10Manybubbles: Slightly improve saneitize.php's output [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140346 [13:13:17] (03PS16) 1001tonythomas: Added VERP functionality hook to core [core] - 10https://gerrit.wikimedia.org/r/138655 (https://bugzilla.wikimedia.org/46640) [13:13:18] 3MediaWiki extensions / 3CirrusSearch: Call to undefined method Elastica\Exception\Bulk\ResponseException::getResponse() in ElasticsearchIntermediary.php on line 171 - 10https://bugzilla.wikimedia.org/66780 (10Nik Everett) p:5Unprio>3Highes [13:15:54] James_F|Away: no VE on wikibooks? :( [13:16:05] (03PS6) 10Paladox: Update moment folder and files [core] - 10https://gerrit.wikimedia.org/r/139698 [13:16:35] (03PS7) 10Paladox: Update moment folder and files [core] - 10https://gerrit.wikimedia.org/r/139698 [13:16:44] (03PS1) 10Manybubbles: Revert change to exception message finding [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140348 (https://bugzilla.wikimedia.org/66780) [13:17:20] (03CR) 10Manybubbles: [C: 04-1] "Don't want to merge without a test but I'm throwing this out there in case it fixes Aude's problem." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140348 (https://bugzilla.wikimedia.org/66780) (owner: 10Manybubbles) [13:17:38] aude: if you are stuck you can try [13:17:41] https://gerrit.wikimedia.org/r/#/c/140348 [13:17:45] (03PS8) 10Paladox: Update moment folder and files from 1.6.0 to 1.7.0 [core] - 10https://gerrit.wikimedia.org/r/139698 [13:17:47] it should fix the problem [13:18:03] i'm not having the problem now.... i had bad stuff in my database [13:18:06] but I haven't tested it yet - just reverted most likely candidate [13:18:12] i think that's why cirrus choked [13:18:30] aude: yeah - cirrus choked and then choked again trying to tell you why it choked [13:19:09] looks sane [13:20:54] (03PS2) 10Paladox: Update jquery.mockjax.js [core] - 10https://gerrit.wikimedia.org/r/139693 [13:23:04] 3Analytics / 3General/Unknown: stat1001 returning 503s for public-datasets - 10https://bugzilla.wikimedia.org/66781#c1 (10christian) Files are still available on stat1003. As apache configurations saw quite some changes yesterday in puppet, I'll try to see if something got broken on stat1001 around that. [13:25:49] 3MediaWiki / 3JavaScript: Table sorting for number values should ignore approximate/estimate "~" character - 10https://bugzilla.wikimedia.org/63055 (10Rohan Rawat) a:3Rohan Rawat [13:27:56] (03PS3) 10Paladox: Update jquery.mockjax.js [core] - 10https://gerrit.wikimedia.org/r/139693 [13:30:38] (03CR) 10Manybubbles: "Removing my -1 because we really should get this fixed before Thursday's branching. It deserves a test (because it failed) but that shoul" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140348 (https://bugzilla.wikimedia.org/66780) (owner: 10Manybubbles) [13:34:35] 3MediaWiki extensions / 3WikidataRepo: Make internal storage format configurable - 10https://bugzilla.wikimedia.org/66784 (10Daniel Kinzler) 3NEW p:3Unprio s:3normal a:3Wikidata bugs It better manage the transition from the old internal storage format to using the new implementation of the external J... [13:34:50] 3MediaWiki extensions / 3WikidataRepo: Make internal storage format configurable - 10https://bugzilla.wikimedia.org/66784 (10Daniel Kinzler) 5NEW>3ASSI p:5Unprio>3Highes s:5normal>3critic [13:36:28] (03PS1) 10Yuvipanda: Capitalize edit tag to be consistent with other mobile tags [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/140353 [13:36:39] aharoni: think you can merge ^? a purely i18n change [13:37:19] (03CR) 10Amire80: [C: 032] Capitalize edit tag to be consistent with other mobile tags [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/140353 (owner: 10Yuvipanda) [13:37:23] (03Merged) 10jenkins-bot: Capitalize edit tag to be consistent with other mobile tags [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/140353 (owner: 10Yuvipanda) [13:37:26] aharoni: ty [13:41:11] (03PS1) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/140354 [13:42:20] (03CR) 10Hashar: [C: 032] "+2 per Kartik =)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/139336 (owner: 10Hashar) [13:43:34] (03Merged) 10jenkins-bot: beta: update job for cxserver [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/139336 (owner: 10Hashar) [13:47:51] (03PS2) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/139831 [13:57:37] (03PS1) 10Jack Phoenix: MediaWiki 1.23 change: WikiError is no more, UserMailer::send() & friends return a Status object instead. [extensions/AjaxLogin] - 10https://gerrit.wikimedia.org/r/140359 [13:58:12] (03CR) 10Jack Phoenix: [C: 032 V: 032] MediaWiki 1.23 change: WikiError is no more, UserMailer::send() & friends return a Status object instead. [extensions/AjaxLogin] - 10https://gerrit.wikimedia.org/r/140359 (owner: 10Jack Phoenix) [13:59:33] (03CR) 10Anomie: [C: 032] The siteinfo API uses '' as an attribute value, not `true`. [core] - 10https://gerrit.wikimedia.org/r/140132 (https://bugzilla.wikimedia.org/66723) (owner: 10Cscott) [14:01:05] Krinkle: detatched? [14:03:36] (03Merged) 10jenkins-bot: The siteinfo API uses '' as an attribute value, not `true`. [core] - 10https://gerrit.wikimedia.org/r/140132 (https://bugzilla.wikimedia.org/66723) (owner: 10Cscott) [14:07:50] 3Analytics / 3General/Unknown: stat1001 returning 503s for public-datasets - 10https://bugzilla.wikimedia.org/66781#c4 (10christian) Thanks Ottomata for the fix! http://mobile-reportcard.wmflabs.org/# is back online. ssl is not yet there. I'll have to see if we need it around geowiki files. [14:10:37] (03CR) 10Hoo man: [C: 04-1] "Especially I don't think that :tag should take nil/ false" (033 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/137659 (https://bugzilla.wikimedia.org/62982) (owner: 10Jackmcbarn) [14:19:27] (03PS1) 10Tpt: Remove padding for non-numeric page labels in pagelist display [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/140367 [14:22:53] (03CR) 10Tpt: [C: 032] "Cosmetic change" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/138383 (owner: 10Tpt) [14:23:20] (03Merged) 10jenkins-bot: Moves some classes to namespaces and some simple cleanup [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/138383 (owner: 10Tpt) [14:23:55] (03PS1) 10Jack Phoenix: * Removed (kinda) some more $wgTitle instances * I18n fixes -- the plain() format is more than appropriate for content action tabs and whatnot * Fixed one strange (and likely incorrect) way of generating an URL; I'm not sure why there's the _ URL paramete [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/140368 [14:24:33] 3MediaWiki / 3API: The protorel attribute in the siteinfo API is set to "true", not "". - 10https://bugzilla.wikimedia.org/66723 (10Brad Jorsch) 5PATC>3RESO/FIX [14:24:45] (03CR) 10Jack Phoenix: [C: 032 V: 032] * Removed (kinda) some more $wgTitle instances * I18n fixes -- the plain() format is more than appropriate for content action tabs and whatn [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/140368 (owner: 10Jack Phoenix) [14:25:29] (03PS1) 10Anomie: Sanity check $wgNamespaceAliases [extensions/Scribunto] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140370 [14:25:34] 3MediaWiki / 3API: Allow descending order for list=exturlusage - 10https://bugzilla.wikimedia.org/32386#c3 (10Tito Bouzout) I'm on it https://gerrit.wikimedia.org/r/#/c/140336/ [14:28:03] 3MediaWiki / 3API: The protorel attribute in the siteinfo API is set to "true", not "". - 10https://bugzilla.wikimedia.org/66723#c4 (10C. Scott Ananian) 5RESO/FIX>3REOP Not fixed until the corresponding Parsoid patch is merged ( https://gerrit.wikimedia.org/r/140130 ). [14:28:20] 3MediaWiki / 3API: The protorel attribute in the siteinfo API is set to "true", not "". - 10https://bugzilla.wikimedia.org/66723 (10C. Scott Ananian) a:3C. Scott Ananian [14:30:16] (03CR) 10Phe: [C: 031] Remove padding for non-numeric page labels in pagelist display [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/140367 (owner: 10Tpt) [14:30:59] (03CR) 10Tpt: [C: 032] "Reviewed by Phe (thanks)" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/140367 (owner: 10Tpt) [14:31:14] (03Merged) 10jenkins-bot: Remove padding for non-numeric page labels in pagelist display [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/140367 (owner: 10Tpt) [14:40:13] (03CR) 10Anomie: "Welcome!" [core] - 10https://gerrit.wikimedia.org/r/140333 (owner: 10Gerrit Patch Uploader) [14:40:22] (03Abandoned) 10Anomie: [To Close, I'm sorry] Allows to set an optional sorting mode for the results of the API call. [core] - 10https://gerrit.wikimedia.org/r/140333 (owner: 10Gerrit Patch Uploader) [14:41:00] (03PS1) 10Jack Phoenix: Removed some unused variables which were used in the previous iteration of this skin. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/140373 [14:41:13] (03CR) 10Jack Phoenix: [C: 032 V: 032] Removed some unused variables which were used in the previous iteration of this skin. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/140373 (owner: 10Jack Phoenix) [14:42:20] (03CR) 10Anomie: [C: 04-1] Allows to set an optional sorting mode for the results of the API call. (033 comments) [core] - 10https://gerrit.wikimedia.org/r/140336 (owner: 10Gerrit Patch Uploader) [14:42:59] (03CR) 10Jack Phoenix: [C: 032 V: 032] Cleanup and modernize extension [extensions/Editcount] - 10https://gerrit.wikimedia.org/r/139770 (owner: 10Legoktm) [14:44:13] (03CR) 10Anomie: Allows to set an optional sorting mode for the results of the API call. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/140336 (owner: 10Gerrit Patch Uploader) [14:45:35] 3Wikimedia / 3Mailing lists: Remove the wikimedia-connecticut list - 10https://bugzilla.wikimedia.org/66003#c3 (10Giuseppe Lavagetto) 5ASSI>3RESO/FIX Mailing list removed. [14:50:18] 3MediaWiki / 3Database: ApiQueryExtLinksUsage::run query has crazy limit - 10https://bugzilla.wikimedia.org/57176#c9 (10Brad Jorsch) Sean, how does my proposal in comment 7 sound to you? [14:50:33] 3Analytics / 3Wikimetrics: First run of a recurrent report is not kicked off right away - 10https://bugzilla.wikimedia.org/66280 (10Dan Andreescu) 5PATC>3RESO/FIX [14:51:02] (03PS1) 10Jack Phoenix: Coding style tweaks & removed one unused variable from the setup file. [extensions/Editcount] - 10https://gerrit.wikimedia.org/r/140377 [14:51:18] 3MediaWiki / 3API: Allow descending order for list=exturlusage - 10https://bugzilla.wikimedia.org/32386#c4 (10Brad Jorsch) (In reply to Umherirrender from comment #2) > primary key was added with Gerrit change #51675, maybe that helps No, it doesn't really. We might be able to do something useful here after... [14:53:03] 3Analytics / 3Wikimetrics: Time should be identified to be in UTC - 10https://bugzilla.wikimedia.org/63923 (10Dan Andreescu) [14:54:24] (03PS5) 10Frédéric Wang: Update modules/ext.math.css [extensions/Math] - 10https://gerrit.wikimedia.org/r/139120 [14:54:34] 3MediaWiki extensions / 3CirrusSearch: [Regression] CirrusSearch: Excerpts should not show normalised version (all lowercase and no punctuation) - 10https://bugzilla.wikimedia.org/65803 (10Nik Everett) 5RESO/?>3VERI [14:54:34] 3MediaWiki extensions / 3CirrusSearch: [Regression] CirrusSearch: Excerpts should not show normalised version (all lowercase and no punctuation) - 10https://bugzilla.wikimedia.org/65803#c2 (10Nik Everett) 5NEW>3RESO/FIX Chad told me earlier that he believed this was something we'd fixed and that reindexi... [14:54:55] i just love commons-cat twitter feed... [14:55:25] constant reminder of how crazy our categorization has become... [14:55:26] https://commons.wikimedia.org/wiki/Category:Females_with_hair_with_pearl_jewellery_in_art [14:55:48] (03CR) 10Frédéric Wang: "I uploaded a version with the hardcoded style="display: none" and !important rules removed." [extensions/Math] - 10https://gerrit.wikimedia.org/r/139120 (owner: 10Frédéric Wang) [14:55:48] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Index non-expanded article content as well - 10https://bugzilla.wikimedia.org/60487#c7 (10Nik Everett) 5ASSI>3RESO/FIX Resolved by implementing insource: and insource://. [14:55:49] and it has subcats :) [14:56:03] 3Analytics / 3Wikimetrics: Time should be identified to be in UTC - 10https://bugzilla.wikimedia.org/63923 (10Dan Andreescu) 5PATC>3RESO/FIX [14:56:33] 3MediaWiki / 3API: The protorel attribute in the siteinfo API is set to "true", not "". - 10https://bugzilla.wikimedia.org/66723#c6 (10Brad Jorsch) 5REOP>3RESO/FIX (In reply to C. Scott Ananian from comment #4) > Not fixed until the corresponding Parsoid patch is merged This bug is filed against the API... [14:58:03] (03PS1) 10Ottomata: Updating wikimetrics module for redis and apache fixes [vagrant] - 10https://gerrit.wikimedia.org/r/140379 [14:58:18] 3Analytics / 3Wikimetrics: When a metric returns no results the agreggation steps fails - 10https://bugzilla.wikimedia.org/66439 (10Dan Andreescu) [14:58:26] (03CR) 10Ottomata: [C: 032 V: 032] Updating wikimetrics module for redis and apache fixes [vagrant] - 10https://gerrit.wikimedia.org/r/140379 (owner: 10Ottomata) [15:00:42] (03CR) 10Anomie: [C: 032] "SWAT deploy" [extensions/Scribunto] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140370 (owner: 10Anomie) [15:01:00] (03CR) 10Raylton P. Sousa: [C: 032 V: 032] Import chapter list from existing book in the same order as on the contents page [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/139574 (https://bugzilla.wikimedia.org/66367) (owner: 10Deepali) [15:01:55] (03CR) 10Ineditable: Allows to set an optional sorting mode for the results of the API call. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/140336 (owner: 10Gerrit Patch Uploader) [15:02:20] (03Merged) 10jenkins-bot: Sanity check $wgNamespaceAliases [extensions/Scribunto] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140370 (owner: 10Anomie) [15:03:56] (03PS1) 10Anomie: Update Scribunto [core] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140381 [15:04:11] (03CR) 10Anomie: [C: 032] "SWAT deploy" [core] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140381 (owner: 10Anomie) [15:04:21] 3Analytics / 3Tech community metrics: No data due to 404 for http://korma.wmflabs.org/browser/config.json - 10https://bugzilla.wikimedia.org/66787 (10Andre Klapper) 3NEW p:3Unprio s:3major a:3None http://korma.wmflabs.org/browser/bugzilla_response_time.html does not show any graphs and lists for me.... [15:04:49] 3MediaWiki extensions / 3BookManagerv2: Import chapter list from existing book in the same order as on the contents page - 10https://bugzilla.wikimedia.org/66367 (10Raylton P. Sousa) 5PATC>3RESO/FIX [15:06:48] 3MediaWiki / 3API: API output containing is corrupted in non-XML formats - 10https://bugzilla.wikimedia.org/66776#c1 (10Brad Jorsch) If Chris is ok with killing wfMangleFlashPolicy(), IMO that'd be the best fix. Otherwise I'd rather add a more targeted mangling in ApiFormatJson instead... [15:08:32] (03Merged) 10jenkins-bot: Update Scribunto [core] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140381 (owner: 10Anomie) [15:16:16] (03CR) 10Anomie: [C: 04-1] "Overcorrected ;)" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/111390 (https://bugzilla.wikimedia.org/32189) (owner: 10TTO) [15:20:35] 3MediaWiki extensions / 3BookManagerv2: Show only subpage title in section list for sections without label - 10https://bugzilla.wikimedia.org/66788 (10Deepali Jain) 3NEW p:3Unprio s:3normal a:3None While importing section list from contents page, if a link does not have a label( like [[a/b/c]] ) then... [15:20:58] (03PS1) 10Paladox: Fix for FileOpBatch.php [core] - 10https://gerrit.wikimedia.org/r/140383 [15:25:05] 3MediaWiki extensions / 3CirrusSearch: Allow search in the raw wiki text source via insource: - 10https://bugzilla.wikimedia.org/65783#c6 (10Chad H.) (In reply to Nik Everett from comment #5) > We were tired of waiting for ops to build out infrastructure for easy > copying to labs. Well it's a lower priorit... [15:25:19] 3Wikimedia / 3Mailing lists: Remove the wikimedia-connecticut list - 10https://bugzilla.wikimedia.org/66003#c4 (10Tomasz W. Kozlowski) Thank you for your help, Giuseppe — really appreciate it. [15:26:48] 3MediaWiki extensions / 3CirrusSearch: Allow search in the raw wiki text source via insource: - 10https://bugzilla.wikimedia.org/65783#c7 (10Nik Everett) (In reply to Chad H. from comment #6) > (In reply to Nik Everett from comment #5) > > We were tired of waiting for ops to build out infrastructure for easy... [15:27:34] 3MediaWiki extensions / 3BookManagerv2: Import chapter list from existing book in the same order as on the contents page - 10https://bugzilla.wikimedia.org/66367 (10Raylton P. Sousa) [15:27:34] 3MediaWiki extensions / 3BookManagerv2: Show only subpage title in section list for sections without label - 10https://bugzilla.wikimedia.org/66788#c1 (10Raylton P. Sousa) a:3Deepali Jain See also https://doc.wikimedia.org/mediawiki-core/master/php/html/classTitle.html#aed7f163533f37a3a3d18eb0252a8c026 [15:28:34] 3MediaWiki extensions / 3BookManagerv2: Show only subpage title in section list for sections without label - 10https://bugzilla.wikimedia.org/66788 (10Raylton P. Sousa) [15:28:34] 3MediaWiki extensions / 3BookManagerv2: Import chapter list from existing book in the same order as on the contents page - 10https://bugzilla.wikimedia.org/66367 (10Raylton P. Sousa) [15:29:19] 3MediaWiki extensions / 3BookManagerv2: Ease migration of existing books - 10https://bugzilla.wikimedia.org/53286 (10Raylton P. Sousa) [15:29:19] 3MediaWiki extensions / 3BookManagerv2: Show only subpage title in section list for sections without label - 10https://bugzilla.wikimedia.org/66788 (10Raylton P. Sousa) [15:30:04] 3MediaWiki extensions / 3BookManagerv2: Import chapter list from existing book in the same order as on the contents page - 10https://bugzilla.wikimedia.org/66367 (10Raylton P. Sousa) [15:30:04] 3MediaWiki extensions / 3BookManagerv2: Ease migration of existing books - 10https://bugzilla.wikimedia.org/53286 (10Raylton P. Sousa) [15:31:48] 3MediaWiki extensions / 3WikidataRepo: Make internal storage format configurable - 10https://bugzilla.wikimedia.org/66784 (10Aude) 5PATC>3RESO/FIX [15:32:22] (03PS2) 10Florianschmidtwelzow: Fix for FileOpBatch.php [core] - 10https://gerrit.wikimedia.org/r/140383 (https://bugzilla.wikimedia.org/66467) (owner: 10Paladox) [15:32:30] (03CR) 10Raylton P. Sousa: [C: 032 V: 032] Ease migration of existing books [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/138316 (https://bugzilla.wikimedia.org/53286) (owner: 10Deepali) [15:32:58] (03PS1) 10Paladox: Fix for FileOpBatch.php [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/140387 [15:33:19] (03PS2) 10Paladox: Fix for FileOpBatch.php [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/140387 [15:38:09] (03CR) 10Florianschmidtwelzow: [C: 04-1] "See: Iefbeed5706cbeb0c62b68b6c20939c58acbf5d37" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/140387 (owner: 10Paladox) [15:43:24] (03PS3) 10Paladox: Fix for FileOpBatch.php [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/140387 [15:43:50] 3MediaWiki extensions / 3BookManagerv2: Add message documentation for newly added messages - 10https://bugzilla.wikimedia.org/66789 (10Deepali Jain) 3NEW p:3Unprio s:3normal a:3None Add description of newly added messages in translatewiki.net to ease translators' task. See this for example: https://t... [15:44:03] (03CR) 10Paladox: "Oh ok." [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/140387 (owner: 10Paladox) [15:47:34] (03PS3) 10Paladox: Fix for FileOpBatch.php [core] - 10https://gerrit.wikimedia.org/r/140383 [15:47:46] (03PS4) 10Paladox: Fix for FileOpBatch.php [core] - 10https://gerrit.wikimedia.org/r/140383 (https://bugzilla.wikimedia.org/66467) [15:53:48] (03PS3) 1001tonythomas: Added Table to store email-hash mappings ( EXPERIMENTAL ) [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/140330 [16:01:48] (03PS5) 10Jackmcbarn: Allow passing nils to mw.html [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/137659 (https://bugzilla.wikimedia.org/62982) [16:02:08] (03CR) 10Jackmcbarn: Allow passing nils to mw.html (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/137659 (https://bugzilla.wikimedia.org/62982) (owner: 10Jackmcbarn) [16:02:21] (03PS6) 10Jackmcbarn: Allow passing nils to mw.html [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/137659 (https://bugzilla.wikimedia.org/62982) [16:02:44] (03CR) 10Alex Monk: [C: 04-2] "Per Legkktm and Nemo bis" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/140038 (owner: 10Jdlrobson) [16:02:50] 3MediaWiki extensions / 3WikidataClient: Label not saved properly? - 10https://bugzilla.wikimedia.org/66790 (10soulkeeper.wikipedia) 3NEW p:3Unprio s:3normal a:3Wikidata bugs When I try to enter labels in multiple languages, I usually do [da,nb,nn,sv]. Everything seems to be saved, but when I reload... [16:04:05] 3MediaWiki extensions / 3WikidataRepo: Do not omit empty fields from JSON - 10https://bugzilla.wikimedia.org/66791 (10Daniel Kinzler) 3NEW p:3Unprio s:3normal a:3Wikidata bugs The new serialization code, Serializers\EntitySerializer, omits empty fields from the data structure. E.g. if there are no de... [16:04:19] 3MediaWiki extensions / 3WikidataClient: Label not saved properly? - 10https://bugzilla.wikimedia.org/66790#c1 (10soulkeeper.wikipedia) It shows when viewing the history, but when I go to the item "main view", the input is still empty. [16:04:19] 3MediaWiki extensions / 3WikidataRepo: Do not omit empty fields from JSON - 10https://bugzilla.wikimedia.org/66791 (10Daniel Kinzler) 5NEW>3ASSI p:5Unprio>3Highes s:5normal>3blocke [16:05:48] 3MediaWiki extensions / 3WikidataClient: Label not saved properly? - 10https://bugzilla.wikimedia.org/66790#c2 (10Marius Hoch) Works for me: https://www.wikidata.org/w/index.php?title=Q4468046&uselang=nn [16:07:03] 3MediaWiki extensions / 3WikidataRepo: Do not omit empty fields from JSON - 10https://bugzilla.wikimedia.org/66791#c1 (10Daniel Kinzler) See https://github.com/wmde/WikibaseDataModelSerialization/issues/67 [16:10:04] 3MediaWiki extensions / 3WikidataClient: Label not saved properly? - 10https://bugzilla.wikimedia.org/66790#c3 (10soulkeeper.wikipedia) Interesting. With uselang=nn it works. Same with uselang=nb. But try this: https://www.wikidata.org/w/index.php?title=Q4468046&uselang=en [16:11:19] 3Wikimedia / 3Deployment systems: [scap] Consolidate scripts as sub-commands of `scap` - 10https://bugzilla.wikimedia.org/65827#c3 (10Antoine "hashar" Musso) argparse supports sub commands https://docs.python.org/2.7/library/argparse.html#sub-commands Before writing any code, we might want to list out the... [16:11:20] 3MediaWiki extensions / 3WikidataClient: Label not saved properly? - 10https://bugzilla.wikimedia.org/66790#c4 (10soulkeeper.wikipedia) > But try this: Maybe you have to duplicate my Babel box in order to see the nn label (or lack thereof) with uselang=en? You can find it here: https://www.wikidata.org/wik... [16:14:33] 3MediaWiki extensions / 3WikidataClient: Label not saved properly? - 10https://bugzilla.wikimedia.org/66790#c5 (10Marius Hoch) 5NEW>3RESO/WOR Also works for me (after a null edit) [16:18:03] 3MediaWiki extensions / 3WikidataRepo: Implement wbsetredirect API module - 10https://bugzilla.wikimedia.org/65584 (10Daniel Kinzler) [16:18:20] 3MediaWiki extensions / 3WikidataRepo: Implement wbsetredirect API module - 10https://bugzilla.wikimedia.org/65584 (10Daniel Kinzler) [16:18:20] 3MediaWiki extensions / 3WikidataClient: Label not saved properly? - 10https://bugzilla.wikimedia.org/66790#c6 (10soulkeeper.wikipedia) Now it shows for me too. If I have to make a null edit everytime I save a nn label in order to see it, that is not very practical, but I suppose I'll just have to live wit... [16:21:48] 3MediaWiki extensions / 3WikidataRepo: Make internal storage format configurable - 10https://bugzilla.wikimedia.org/66784 (10Lydia Pintscher) [16:22:03] 3MediaWiki / 3Special pages: No way to back-fill log_search with protection information (causing missing data in Special:ProtectedPages) - 10https://bugzilla.wikimedia.org/66777#c1 (10Umherirrender) Look at the last page to have it all filled ;-) https://en.wikipedia.org/w/index.php?title=Special:ProtectedP... [16:23:29] (03CR) 10Anomie: [C: 04-1] "Putting it in either Block or ProtectionForm doesn't really make sense. Although global functions aren't that great either. Unfortunately " (031 comment) [core] - 10https://gerrit.wikimedia.org/r/140276 (https://bugzilla.wikimedia.org/66646) (owner: 10devunt) [16:24:50] (03PS5) 10Umherirrender: Use Database methods in RevisionDeleteUser::setUsernameBitfields [core] - 10https://gerrit.wikimedia.org/r/129954 [16:24:56] (03CR) 10Hoo man: [C: 04-1] "Tests for unsetting attributes are missing" (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/137659 (https://bugzilla.wikimedia.org/62982) (owner: 10Jackmcbarn) [16:27:59] (03CR) 10Hoo man: "They're not, but clearer test case naming could make this more obvious" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/137659 (https://bugzilla.wikimedia.org/62982) (owner: 10Jackmcbarn) [16:28:07] (03CR) 10Matthias Mullie: [WIP] Reply stuff (035 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139813 (owner: 10Matthias Mullie) [16:28:22] (03CR) 10Matthias Mullie: [WIP] Reply stuff (034 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139813 (owner: 10Matthias Mullie) [16:30:14] (03PS5) 10Paladox: Fix for FileOpBatch.php [core] - 10https://gerrit.wikimedia.org/r/140383 (https://bugzilla.wikimedia.org/66467) [16:30:33] (03PS4) 10Matthias Mullie: [WIP] Reply stuff [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139813 [16:31:02] hoo: i can't chain calls with testhelper, can i? i think i chained calls in all of those [16:31:56] jackmcbarn: for most of the test cases you don't need to chain stuff and for the others explicitly named functions are probably better [16:32:11] test cases should be minimal [16:32:21] (03PS2) 10Welterkj: Add composer support and increment the minor version of this extension (1.0 -> 1.1.0). [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/139298 [16:32:21] 3MediaWiki / 3Maintenance scripts: Targeted forced password update - 10https://bugzilla.wikimedia.org/66793 (10Greg Grossmeier) 3NEW p:3Unprio s:3enhanc a:3None Use case: Some security breach at some other company that results in usernames/emails and passwords and/or hashes exposed. Users tend to reu... [16:32:34] 3MediaWiki extensions / 3WikidataRepo: Do not omit empty fields from JSON - 10https://bugzilla.wikimedia.org/66791 (10Lydia Pintscher) [16:32:34] 3MediaWiki / 3Maintenance scripts: Targeted forced password update - 10https://bugzilla.wikimedia.org/66793 (10Greg Grossmeier) p:5Unprio>3Normal [16:37:18] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Not properly handling when a page is converted to and from a redirect - 10https://bugzilla.wikimedia.org/61211 (10Nik Everett) 5PATC>3RESO/FIX [16:38:39] (03PS1) 10EBernhardson: $options['inverse'] can be unset [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140395 [16:38:56] (03PS7) 10Jackmcbarn: Allow passing nils to mw.html [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/137659 (https://bugzilla.wikimedia.org/62982) [16:39:05] 3Analytics / 3General/Unknown: stat1001 returning 503s for public-datasets - 10https://bugzilla.wikimedia.org/66781#c5 (10christian) 5PATC>3RESO/FIX > I'll have to see if we need it around geowiki files. geowiki is served for a different domain name and is working as expected, so geowiki should be fine... [16:41:10] (03PS1) 10EBernhardson: recompile handlebars templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140396 [16:44:21] (03CR) 10Aklapper: "I don't understand the sentence "The problem caused was when popen() was disabled it would come up with an error saying popen() is disbale" [core] - 10https://gerrit.wikimedia.org/r/140383 (https://bugzilla.wikimedia.org/66467) (owner: 10Paladox) [16:45:49] 3Wikimedia / 3Bugzilla: Remove padlock icon from links in Wikimedia Bugzilla installation - 10https://bugzilla.wikimedia.org/59893#c9 (10Daniel Zahn) 5PATC>3RESO/FIX icons are gone on reload now [16:45:58] (03PS1) 10Hoo man: Fix return doc for ScribuntoEngineBase::fetchModuleFromParser [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/140397 [16:46:04] anomie: --^ [16:46:12] (03PS11) 10EBernhardson: javascript post/topic moderation [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139016 [16:46:42] (03CR) 10EBernhardson: "PS11: rebase" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139016 (owner: 10EBernhardson) [16:47:18] (03CR) 10Anomie: Support for modules-as-images (032 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/113759 (https://bugzilla.wikimedia.org/64460) (owner: 10Ysangkok) [16:48:20] (03CR) 10Hoo man: [C: 032] "Comment only change" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/140397 (owner: 10Hoo man) [16:48:34] (03CR) 10Anomie: [C: 04-1] Fix return doc for ScribuntoEngineBase::fetchModuleFromParser (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/140397 (owner: 10Hoo man) [16:48:58] (03CR) 10Hoo man: Fix return doc for ScribuntoEngineBase::fetchModuleFromParser [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/140397 (owner: 10Hoo man) [16:50:19] (03CR) 10Anomie: [C: 04-1] Support for modules-as-images [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/113759 (https://bugzilla.wikimedia.org/64460) (owner: 10Ysangkok) [16:51:26] (03PS2) 10Hoo man: Fix return doc for ScribuntoEngineBase::fetchModuleFromParser [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/140397 [16:52:06] 3MediaWiki extensions / 3WikidataRepo: input field is too small when editing snak values - 10https://bugzilla.wikimedia.org/66796 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs seems to have changed with the jquery.ui changes in core, afaik http://snag.gy/ob2Pe.jpg [16:54:32] (03CR) 10Anomie: [C: 032] Fix return doc for ScribuntoEngineBase::fetchModuleFromParser [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/140397 (owner: 10Hoo man) [16:56:05] (03Merged) 10jenkins-bot: Fix return doc for ScribuntoEngineBase::fetchModuleFromParser [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/140397 (owner: 10Hoo man) [16:57:12] Hi csteipp: while working with the VERP address generation part to handle email bounces, Jeff_Green and me were thinking whether we can just use a UUID against the hashing by some algo -- 'md5' and key. Eitherr way we need to store the key-hash mapping -- so UUID is enough ? [16:57:18] 3MediaWiki extensions / 3General/Unknown: Security review of Property Suggestor - php part - 10https://bugzilla.wikimedia.org/66380#c1 (10Chris Steipp) 5NEW>3RESO/FIX See discussed on bug 63224, they addressed all of my security concerns. [16:57:47] (03PS2) 10Jdlrobson: Update ifAnonymous Handlebars helper [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140395 (owner: 10EBernhardson) [16:57:52] (03CR) 10Jdlrobson: [C: 032] Update ifAnonymous Handlebars helper [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140395 (owner: 10EBernhardson) [16:58:15] (03Merged) 10jenkins-bot: Update ifAnonymous Handlebars helper [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140395 (owner: 10EBernhardson) [16:58:30] (03CR) 10Jdlrobson: [C: 032] recompile handlebars templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140396 (owner: 10EBernhardson) [16:58:46] (03Merged) 10jenkins-bot: recompile handlebars templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140396 (owner: 10EBernhardson) [16:58:52] (03CR) 10Aude: "might be unrelated but now i'm getting http://pastie.org/9302611 with this patch" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140348 (https://bugzilla.wikimedia.org/66780) (owner: 10Manybubbles) [16:59:48] 3MediaWiki extensions / 3General/Unknown: Security review of Property Suggestor - python part - 10https://bugzilla.wikimedia.org/66378#c1 (10Chris Steipp) I believe the plan is for this to not run on the cluster, rather the parsing will be done somewhere else and the csv will be uploaded and imported. If so... [17:00:35] (03PS6) 10Aaron Schulz: Fix for FileOpBatch.php [core] - 10https://gerrit.wikimedia.org/r/140383 (https://bugzilla.wikimedia.org/66467) (owner: 10Paladox) [17:01:19] (03CR) 10Manybubbles: "Can you check the Elasticseach logs and see if it has anything interesting in it about the failure?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140348 (https://bugzilla.wikimedia.org/66780) (owner: 10Manybubbles) [17:02:04] 3MediaWiki extensions / 3General/Unknown: Security review of Property Suggestor - python part - 10https://bugzilla.wikimedia.org/66378#c2 (10Lydia Pintscher) We're fine either way for now. [17:03:19] 3Analytics / 3Tech community metrics: No data due to 404 for http://korma.wmflabs.org/browser/config.json - 10https://bugzilla.wikimedia.org/66787 (10Quim Gil) p:5Unprio>3High [17:03:19] 3Analytics / 3Tech community metrics: No data due to 404 for http://korma.wmflabs.org/browser/config.json - 10https://bugzilla.wikimedia.org/66787#c1 (10Quim Gil) Confirmed. [17:05:21] 3MediaWiki extensions / 3Scribunto: Fatal error: Call to a member function getPrefixedText() on a non-object in LuaCommon.php on line 419 - 10https://bugzilla.wikimedia.org/66798 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3None [2014-06-18 17:03:23] Fatal error: Call to a member function getPre... [17:06:05] (03CR) 10Paladox: "Hi well popen was introduced in Mediawiki 1.22 but the problem starting in Mediawiki 1.23. this patch fixes the issue and lets people uplo" [core] - 10https://gerrit.wikimedia.org/r/140383 (https://bugzilla.wikimedia.org/66467) (owner: 10Paladox) [17:06:28] csteipp: Hi. Looks like you missed our earlier ping. While working with the VERP address generation part to handle email bounces, Jeff_Green and me were thinking whether we can just use a UUID against the hashing by some algo -- 'md5' and key. Eitherr way we need to store the key-hash mapping -- so UUID is enough ? [17:06:29] jackmcbarn: ping [17:06:34] hoo: pong [17:06:51] jackmcbarn: Will you update the documentation on mediawiki.org after the patch has been merged? [17:07:01] hoo: sure [17:07:42] (03CR) 10Aude: "nothing in my elastic logs about this. (otherwise seems to be logging fine, including previous exceptions)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140348 (https://bugzilla.wikimedia.org/66780) (owner: 10Manybubbles) [17:08:05] tonythomas: Walk me through exactly what you're using? The threat is 1) someone can guess it and send an email to our server to unsubscribe the user, 2) someone can replay a valid token against someone else. [17:08:11] jackmcbarn: What's the logic behind some methods supporting both nil and false and some only nil? [17:08:35] tonythomas: So I'm not sure what you mean by "against the hashing" [17:08:57] hoo: html attributes can be set to "false", which is different than setting them to false, but some users might not catch the difference [17:09:11] (03PS8) 10Hoo man: Allow passing nils to mw.html [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/137659 (https://bugzilla.wikimedia.org/62982) (owner: 10Jackmcbarn) [17:09:13] csteipp: the question came up in the context of what we're going to store in the database [17:09:26] (03PS1) 10Yurik: Updated JsonConfig, ZeroBanner, ZeroPortal to latest [core] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140403 [17:09:29] currently, we were using the hash generated by PHP's hmac, using a secrett key and algo == md5 [17:09:57] we can add in a timestamp too, as you mentioned once, and the problem is of course, with the DB [17:10:00] I thought we had chosen the HMAC because it woudl be reversable, meaning we could store some info about the outgoing message and reverse it using the secret key without going to database [17:10:02] Jeff_Green: Gatcha. tonythomas, that sounds good enough to prevent someone from being able to guess it. [17:10:16] (03CR) 10Hoo man: "Changed the new tests slightly" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/137659 (https://bugzilla.wikimedia.org/62982) (owner: 10Jackmcbarn) [17:10:23] jackmcbarn: ok, not sure I like that [17:10:24] Jeff_Green: hmac isn't reversable [17:10:31] if we're not using a reversable hash, why use a hash a all? [17:10:37] (03PS1) 10Yurik: Updated JsonConfig, ZeroBanner, ZeroPortal to latest [core] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/140404 [17:10:41] hoo: what's your suggestion? [17:10:42] anomie: ^ do you have an opinion on that?? [17:10:48] I don't know [17:10:57] if we have to store it, why not just store a UUID alongside each email address? [17:11:11] manybubbles: what version of elastic search am i supposed to use now? [17:11:19] jackmcbarn: could you +1 that you're ok with my changes to the tests (if you are) [17:11:25] aude: 1.2.1 [17:11:31] that could be my issue [17:11:31] even we have something like email_token -- which we cant make public right ? as you replied to me once [17:11:34] hoo: On what specifically? [17:11:38] i still have 1.0.1 [17:11:49] If the VERP is something like the hmac of the email address and a timestamp (and the timestamp is somehow stored either in the verp or the email, then the check is, does the hash from the verp calculate using the email and timestamp. [17:11:50] (03CR) 10Jackmcbarn: [C: 031] "+1 to Hoo's changes." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/137659 (https://bugzilla.wikimedia.org/62982) (owner: 10Jackmcbarn) [17:11:57] (03PS2) 10Jdlrobson: [Reapply] Simplify thumbnail styling to have consistency with mobile [core] - 10https://gerrit.wikimedia.org/r/133301 (https://bugzilla.wikimedia.org/65160) (owner: 10Jforrester) [17:11:59] * aude updates and see if i still have a problem [17:12:01] jackmcbarn: What's the logic behind some methods supporting both nil and false and some only nil? [17:12:02] hoo: html attributes can be set to "false", which is different than setting them to false, but some users might not catch the difference [17:12:08] anomie: that --^ [17:12:12] Jeff_Green: Is storing it an option? I figured we would want to completely avoid that [17:12:34] 3Analytics / 3General/Unknown: stat1001 returning 503s for public-datasets - 10https://bugzilla.wikimedia.org/66781 (10christian) [17:12:37] hoo: I'd rather that nil be the only thing that's "special" [17:12:38] If you can use a DB and keep a unique token for each email, then nothing else is needed. [17:12:54] csteipp: but, we will have to store the emailid - hash mapping right ? in a db ? [17:13:12] (03CR) 10jenkins-bot: [V: 04-1] [Reapply] Simplify thumbnail styling to have consistency with mobile [core] - 10https://gerrit.wikimedia.org/r/133301 (https://bugzilla.wikimedia.org/65160) (owner: 10Jforrester) [17:13:15] tonythomas: I don't think so. What are the size constraint on the VERP? [17:13:21] Yeah, that's also a good idea [17:13:27] jackmcbarn: What do you think about that? [17:13:44] would be consistent then and no worries about false vs. "false" [17:13:47] size constraint ? hmm.. for the hash ? [17:13:59] (03CR) 10Jdlrobson: [Reapply] Simplify thumbnail styling to have consistency with mobile (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133301 (https://bugzilla.wikimedia.org/65160) (owner: 10Jforrester) [17:14:06] i guess i'm okay with it. it just means people will have to use some "or nil" in situations they otherwise wouldn't [17:14:32] tonythomas: I'm also not entirely familar with VERP-- I'm assuming you generate an email address (or something in the header) that if the email bounces, your server looks at that, and unsubscribes the user, right? [17:14:34] 3Analytics / 3General/Unknown: stat1001 returning 503s for public-datasets - 10https://bugzilla.wikimedia.org/66781 (10christian) [17:14:51] (03PS3) 10Jdlrobson: [Reapply] Simplify thumbnail styling to have consistency with mobile [core] - 10https://gerrit.wikimedia.org/r/133301 (https://bugzilla.wikimedia.org/65160) (owner: 10Jforrester) [17:15:06] if we can trust wikipedia :-) http://en.wikipedia.org/wiki/Email_address [17:15:23] local part (everything left of the @) up to 64 characters [17:15:27] jackmcbarn: Don't think that's a likely case... '' doesn't equal false in Lua, so [17:15:43] i meant like (cssIsOkHere and cssText or nil) [17:15:49] So we've got lots of room :) [17:16:08] So if you do something like, [17:16:10] (03CR) 10Yurik: [C: 032] Updated JsonConfig, ZeroBanner, ZeroPortal to latest [core] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/140404 (owner: 10Yurik) [17:16:20] (03CR) 10Yurik: [C: 032] Updated JsonConfig, ZeroBanner, ZeroPortal to latest [core] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140403 (owner: 10Yurik) [17:16:28] manybubbles: i'll have to update elastic later [17:16:34] $hash = hmac( , concat( email, timestamp) ); [17:16:35] csteipp: true. we alter the return path as a hash of the email id, and make something like bounces-{hash} @wikimedia.org, and on the bounce back, we can extract the To from the header, try to match it with some hashings or things existing and try to figure out who caused the bounce [17:16:35] http://isup.me/elasticsearch.org (not just me apparently) [17:16:54] jackmcbarn: ouh... I can see the point, but also the concerns [17:17:07] and the envelope sender is $hash-$timestamp@wikimedia.org [17:17:18] (03PS1) 10Reedy: Parameter type hints [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/140405 [17:17:30] Then you can check by $hash by recalculating the hmac with the email address and timestamp. [17:17:50] (And check the timestamp and reject if > 7 days old, or whatever). [17:17:59] So stateless, but secure. [17:18:08] Unless I'm missing something? [17:18:26] oh--timestamp outside of the hash! that makes sense [17:18:37] we don't have the email address though [17:18:45] Jeff_Green: true that. [17:18:52] Oh, really? [17:18:56] (03PS1) 10Aaron Schulz: Avoid using popen() when "parallelize" is disabled [core] - 10https://gerrit.wikimedia.org/r/140406 [17:19:14] (03PS2) 10Reedy: Parameter type hints [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/140405 [17:19:24] well, we ~probably~ do, but the only things we know for certain are the envelope sender and recipient of the last mail transaction before it hits the bounce processor [17:19:38] (03Merged) 10jenkins-bot: Updated JsonConfig, ZeroBanner, ZeroPortal to latest [core] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/140404 (owner: 10Yurik) [17:19:48] So if you use what they use on https://en.wikipedia.org/wiki/Variable_envelope_return_path, you could add hash and timestamp to that string. [17:20:02] and the only thing that *can* remain constant is the [Return-To] right Jeff ? [17:20:11] (03CR) 10Aaron Schulz: [C: 04-1] "This also changed another line which should be left as is." [core] - 10https://gerrit.wikimedia.org/r/140383 (https://bugzilla.wikimedia.org/66467) (owner: 10Paladox) [17:20:25] (03Merged) 10jenkins-bot: Updated JsonConfig, ZeroBanner, ZeroPortal to latest [core] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140403 (owner: 10Yurik) [17:21:19] b64 of a 120bit md5 should be... 20 bytes-ish [17:22:12] tonythomas: if it's there, but Return-To isn't always there [17:22:27] With a 32 bit timestamp (because who cares about 2038!), that would be 25 bytes of hash+timestamp, beyond the email address stored there [17:23:14] this is i think a big part of the reason VERP was created--with all the different mailers out there making a mockery of the data from the original message, the one thing you could cling to was "if it managed to get back to this address, this address must not have been mangled" [17:23:27] hoo: so should i still remove false? [17:23:47] (03CR) 10Hoo man: "IRC:" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/137659 (https://bugzilla.wikimedia.org/62982) (owner: 10Jackmcbarn) [17:23:48] 3MediaWiki extensions / 3CirrusSearch: Call to undefined method Elastica\Exception\Bulk\ResponseException::getResponse() in ElasticsearchIntermediary.php on line 171 - 10https://bugzilla.wikimedia.org/66780#c2 (10Nik Everett) 5NEW>3PATC https://gerrit.wikimedia.org/r/#/c/140348/1 [17:24:17] jackmcbarn: tough question... I'm not sure myself [17:24:28] just documented the talk from IRC in gerrit [17:27:37] ok I have an absurd idea [17:28:03] what if we were to do something like this: [17:28:37] (03CR) 10Jforrester: [C: 04-1] "Since this commit was written, there's a new mediawiki.skinning.content.parsoid module that should also be adjusted before this is merged." [core] - 10https://gerrit.wikimedia.org/r/133301 (https://bugzilla.wikimedia.org/65160) (owner: 10Jforrester) [17:28:37] bounce-{verysmallnotterriblysecurehashofemailaddress}-{hmac}-{timestamp}@ [17:28:43] (03PS3) 10Bsitu: [WIP] close & open js interaction [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 [17:29:12] Jeff_Green: that looks great [17:29:35] now, we can reverse the verysmallnotterriblysecurehashofemailaddress part right ? [17:30:05] 3MediaWiki extensions / 3General/Unknown: Security review of Property Suggestor - python part - 10https://bugzilla.wikimedia.org/66378#c3 (10Chris Steipp) 5NEW>3RESO/FIX Plan from Nik is, "Lets assume for the next few months this'll be manually run and uploaded to the cluster. Or run in labs where the d... [17:30:18] (03CR) 10Hoo man: [C: 032] Parameter type hints [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/140405 (owner: 10Reedy) [17:30:50] tonythomas: right [17:30:51] (03PS9) 10Paladox: mediawiki.searchSuggest: Enable for iPhone and iPod touch [core] - 10https://gerrit.wikimedia.org/r/139809 [17:31:06] (03CR) 10Jeroen De Dauw: Add composer support and increment the minor version of this extension (1.0 -> 1.1.0). (033 comments) [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/139298 (owner: 10Welterkj) [17:31:13] but I actually think in the end it would be simpler to just store a UUID [17:31:31] so, how can we evaluate the hash -- whether it was originally created by us ? [17:31:54] (03Merged) 10jenkins-bot: Parameter type hints [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/140405 (owner: 10Reedy) [17:33:02] Danny_B: ping [17:34:51] 3MediaWiki extensions / 3PageImages: Fatal error: Call to a member function transform() on a non-object in PageImages.body.php on line 160 - 10https://bugzilla.wikimedia.org/66799 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3None [2014-06-18 17:26:04] Fatal error: Call to a member function trans... [17:35:15] tonythomas: the more I think about it, I don't think it's realistic to jam all this information into 64 characters [17:35:37] 3MediaWiki extensions / 3PageImages: Fatal error: Call to a member function transform() on a non-object in PageImages.body.php on line 160 - 10https://bugzilla.wikimedia.org/66799#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/JAUBCteP [17:35:51] (03CR) 10Matthias Mullie: Only bind onClickInteractive on nodes that have the required data attr (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139812 (owner: 10Matthias Mullie) [17:36:31] (03PS2) 10Matthias Mullie: Only bind onClickInteractive on nodes that have the required data attr [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139812 [17:36:36] 3MediaWiki extensions / 3Math: Warning: pack(): Type H: not enough characters in string MathTexvc.php on line 38 - 10https://bugzilla.wikimedia.org/66800 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3None Warning: pack() [function.pack]: Type H: not enough characters... [17:36:58] Jeff_Green: true. but, looks like UUID alone wont do the trick [17:37:11] csteipp: any more alternatives ? [17:37:19] (03CR) 10Jdlrobson: SpecialVersion: Show 'Skins' and 'Extensions' in separate sections (032 comments) [core] - 10https://gerrit.wikimedia.org/r/136615 (owner: 10Bartosz Dziewoński) [17:37:21] (03CR) 10Jforrester: [Reapply] Simplify thumbnail styling to have consistency with mobile (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133301 (https://bugzilla.wikimedia.org/65160) (owner: 10Jforrester) [17:37:37] tonythomas: where does storing a UUID fall short? [17:37:59] (03PS2) 10Jdlrobson: Add support for Function callback override to API calls [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140334 (owner: 10SG) [17:38:15] (03CR) 10jenkins-bot: [V: 04-1] Add support for Function callback override to API calls [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140334 (owner: 10SG) [17:38:33] only in the case, as csteipp says, some random attacker can generate it and throw it back ? [17:38:50] if we use only the email-id as the key ? [17:39:01] there would be no key [17:39:14] (03CR) 10Jdlrobson: [C: 04-1] Add support for Function callback override to API calls (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140334 (owner: 10SG) [17:39:16] it would be a completely random string, one-time-assigned per email address [17:40:00] so I guess an attacker could brute force, but if you use a long enough string you can make it very improbable that they find a live one [17:40:50] (03PS1) 10Jackmcbarn: Use quickUserCan instead of userCan for searches [core] - 10https://gerrit.wikimedia.org/r/140411 [17:41:20] for example: 20140416162136b4844a3186e1372d85094197330f39e2@bounces.amazon.com [17:42:49] Jeff_Green: that looks simple and cool. and we can store it along the existing user table ? [17:43:03] (03PS1) 10EBernhardson: Protect against null values in ObjectManager::findMulti [extensions/Flow] - 10https://gerrit.wikimedia.org/r/140413 (https://bugzilla.wikimedia.org/66797) [17:45:08] (03Abandoned) 10Reedy: Suppress warnings from inet_pton [core] - 10https://gerrit.wikimedia.org/r/137095 (https://bugzilla.wikimedia.org/66088) (owner: 10Reedy) [17:45:48] (03PS1) 10EBernhardson: Convert recoverable fatal errors into exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/140414 (https://bugzilla.wikimedia.org/66797) [17:45:58] (03CR) 10jenkins-bot: [V: 04-1] Convert recoverable fatal errors into exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/140414 (https://bugzilla.wikimedia.org/66797) (owner: 10EBernhardson) [17:46:04] 3MediaWiki / 3General/Unknown: inet_pton() Unrecognized address unknown in IPSet.php on line 171 - 10https://bugzilla.wikimedia.org/66088#c6 (10Sam Reed (reedy)) From Brandon on gerrit: The non-wf way would be: $originalLevel = error_reporting( E_ALL & ~E_WARNING ); $raw = in... [17:46:18] 3MediaWiki / 3General/Unknown: inet_pton() Unrecognized address unknown in IPSet.php on line 171 - 10https://bugzilla.wikimedia.org/66088 (10Sam Reed (reedy)) 5PATC>3NEW [17:47:48] 3Wikimedia / 3Site requests: Rename pages prefixed Baden: at nlwiki - 10https://bugzilla.wikimedia.org/65579#c3 (10Sam Reed (reedy)) 5ASSI>3RESO/FIX reedy@tin:~$ mwscript namespaceDupes.php nlwiki --fix ... 680978 (0,"Baden:Huisorde_van_de_Trouw") -> (0,"Baden-Huisorde_van_de_Trouw") [[Baden-Huisorde van... [17:48:04] (03PS2) 10EBernhardson: Convert recoverable fatal errors into exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/140414 (https://bugzilla.wikimedia.org/66797) [17:48:29] (03PS1) 10Aaron Schulz: Avoid using popen() when "parallelize" is disabled [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/140416 [17:48:51] 3Wikimedia / 3Bugzilla: Add "FundraisingChart" to "MediaWiki Extensions" Bugzilla product - 10https://bugzilla.wikimedia.org/66803 (10Sherah Smith) 3NEW p:3Unprio s:3normal a:3None I need a bugzilla category for the mediawiki/extensions/FundraisingChart project under the MediaWiki Extension product. [17:50:00] (03PS7) 10Jdlrobson: Implement AJAX preview on frontend-rewrite. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138788 (owner: 10Werdna) [17:50:33] 3Wikimedia / 3Bugzilla: Add "FundraisingChart" to "MediaWiki Extensions" Bugzilla product - 10https://bugzilla.wikimedia.org/66803#c1 (10Tyler Romeo) Who should be the default assignee, and who should be default CC'ed? [17:51:12] (03PS4) 10Bsitu: [WIP] close & open js interaction [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 [17:52:34] 3MediaWiki-Vagrant: ruby-build significantly slows down the provisioning process - 10https://bugzilla.wikimedia.org/66763#c1 (10Dan Duvall) 5NEW>3ASSI a:3Dan Duvall As far as I can tell, ruby-build doesn't yet support the installation of binary packages (https://github.com/sstephenson/ruby-build/issues/4... [17:52:40] hoo: Does Scribunto_LuaFunction come from the php extension? [17:54:17] Reedy: yes [17:55:09] actually no [17:55:14] wt [17:55:15] f [17:55:16] wait [17:55:19] where does it come from?! [17:56:00] is newFunction dead code? [17:56:24] yeah [17:57:14] (03PS1) 10Hoo man: Remove dead code [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/140419 [17:58:21] (03CR) 10Jdlrobson: [C: 04-1] "Please rebase" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139839 (owner: 10Matthias Mullie) [17:58:57] (03PS3) 10EBernhardson: [WIP] Edit post [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139839 (owner: 10Matthias Mullie) [17:59:15] (03CR) 10EBernhardson: "ps3: rebased" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139839 (owner: 10Matthias Mullie) [18:00:31] (03PS1) 10Reedy: Add .gitignore [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/140420 [18:00:33] (03PS1) 10Reedy: Remove temporary/backup type files [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/140421 [18:00:42] csteipp: how about this approach. say we generate a 48-character UUID when we validate an email address, and store that in a table and simply use that? my back of the envelope math suggests for a million-user wiki, you'd have a 1:1E80 chance in guessing a valid UUID [18:01:00] assuming perfect randomness in UUID generation of coures [18:01:05] 3Wikimedia / 3Bugzilla: Add "FundraisingChart" to "MediaWiki Extensions" Bugzilla product - 10https://bugzilla.wikimedia.org/66803 (10Sherah Smith) a:3fr-tech [18:01:28] (03CR) 10Legoktm: [C: 032] Coding style tweaks & removed one unused variable from the setup file. [extensions/Editcount] - 10https://gerrit.wikimedia.org/r/140377 (owner: 10Jack Phoenix) [18:01:33] (03Merged) 10jenkins-bot: Coding style tweaks & removed one unused variable from the setup file. [extensions/Editcount] - 10https://gerrit.wikimedia.org/r/140377 (owner: 10Jack Phoenix) [18:01:33] 3Wikimedia / 3Bugzilla: Add "FundraisingChart" to "MediaWiki Extensions" Bugzilla product - 10https://bugzilla.wikimedia.org/66803#c2 (10Sherah Smith) (In reply to Tyler Romeo from comment #1) > Who should be the default assignee, and who should be default CC'ed? both should be fr-tech. [18:02:11] (03CR) 10Reedy: [C: 032] Add .gitignore [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/140420 (owner: 10Reedy) [18:02:18] (03CR) 10Reedy: [V: 032] Add .gitignore [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/140420 (owner: 10Reedy) [18:02:34] (03CR) 10Reedy: [C: 032 V: 032] Remove temporary/backup type files [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/140421 (owner: 10Reedy) [18:03:08] Jeff_Green: In addition to hash/timestamp? [18:03:34] UUID alone doesn't work if someone ever forwards the email to a list [18:03:34] i wouldn't bother with a hash/timestamp. I don't see what it buys us in the face of the odds of guessing a valid ID [18:03:48] csteipp: http://cr.yp.to/proto/verp.txt [18:03:56] (03CR) 10Cmcmahon: [C: 031] "I'd like to get this merged if it's not a problem" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/140034 (https://bugzilla.wikimedia.org/66689) (owner: 10Bsitu) [18:04:01] that's the exact reason why VERP was created [18:04:15] (03PS3) 10EBernhardson: [WIP] wire up new topic submission [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140036 [18:04:35] (03CR) 10EBernhardson: "ps3: rebase" (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140036 (owner: 10EBernhardson) [18:04:40] (03PS1) 10Reedy: Remove execute bit [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/140425 [18:04:53] gotta love djb's holy references :-P [18:05:01] (03CR) 10Reedy: [C: 032 V: 032] Remove execute bit [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/140425 (owner: 10Reedy) [18:05:33] csteipp: or do you mean because by forwarding it to a list, they expose their ID? [18:06:13] Jeff_Green: Yeah, if it's a static secret, then as soon as it gets out, anyone can unsubscribe the user [18:06:20] 3Wikimedia / 3Bugzilla: Add "FundraisingChart" to "MediaWiki Extensions" Bugzilla product - 10https://bugzilla.wikimedia.org/66803#c3 (10Tyler Romeo) 5NEW>3RESO/FIX a:5fr-tech>3Tyler Romeo The component has been created. :) [18:06:57] tonythomas / Jeff_Green, also, is this for MediaWiki emails, or WMF mailing lists? [18:07:23] mediawiki emails of course, [18:07:25] mediawiki mail [18:07:35] 3Wikimedia / 3Extension setup: Review & deploy mediawiki/extensions/FundraisingChart - 10https://bugzilla.wikimedia.org/65834 (10Sherah Smith) [18:07:35] 3Wikimedia / 3Extension setup: Security review for mediawiki/extensions/FundraisingChart - 10https://bugzilla.wikimedia.org/66805 (10Sherah Smith) [18:07:36] 3Wikimedia / 3Extension setup: Security review for mediawiki/extensions/FundraisingChart - 10https://bugzilla.wikimedia.org/66805 (10Sherah Smith) 3NEW p:3Unprio s:3normal a:3None Security review request for FundraisingChart extension. Depends on bug #65834 [18:07:51] 3Wikimedia / 3Extension setup: Review & deploy mediawiki/extensions/FundraisingChart - 10https://bugzilla.wikimedia.org/65834 (10Sherah Smith) [18:07:51] 3Wikimedia / 3Extension setup: Performance review for mediawiki/extensions/FundraisingChart - 10https://bugzilla.wikimedia.org/66806 (10Sherah Smith) [18:07:51] 3Wikimedia / 3Extension setup: Performance review for mediawiki/extensions/FundraisingChart - 10https://bugzilla.wikimedia.org/66806 (10Sherah Smith) 3NEW p:3Unprio s:3normal a:3None Performance review request for FundraisingChart. [18:07:58] Are you thinkiing it would un-confirm the email address if we get too many bounces? [18:08:05] 3MediaWiki / 3Special pages: Move "Special:MyLanguage" from Extension:Translate to MediaWiki core - 10https://bugzilla.wikimedia.org/66762#c1 (10Niklas Laxström) I am okay with moving this to core, it is quite useful itself even without Translate extension. Translate will need a little bit BC code because it... [18:08:14] csteipp: exactly [18:09:00] Cool. So I think there does need to be an integrity check. More to keep an attacker from unconfirming a user and DoSing the account. [18:09:15] (03PS4) 10EBernhardson: wire up new topic submission [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140036 [18:09:17] How about user_id-timestamp-hmac? [18:09:57] You can even only use the top 80 bits of the hmac (although you'd probably want to use whirlpool instead of md5) [18:10:28] (03PS5) 10Bsitu: [WIP] close & open js interaction [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 [18:11:16] I've forgotten when I was looking at that XMLContentExtension now [18:11:17] ffs [18:11:44] Actually, if you have reasonable detection of brute-forcing, then you can reduce the hash way down-- 20 bits? [18:12:09] so we've got a total of 64 chars to work with afaik [18:12:27] The only way a user can break the hash then is brute forcing the entire space-- 2^20 emails would be a noticable spike (I hope) [18:13:56] mchrenry sends about 100 messages per second [18:15:48] 3Analytics / 3General/Unknown: stat1001 returning 503s for public-datasets - 10https://bugzilla.wikimedia.org/66781#c6 (10Toby Negrin) Thanks for the quick response folks. [18:17:00] (03CR) 10Bsitu: [C: 031] Migrate from $.browser to $.client since $.browser is deprecated [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/140034 (https://bugzilla.wikimedia.org/66689) (owner: 10Bsitu) [18:17:13] user-(uuid)-(hex?-encoded timestamp)-(hmac)@wikimedia.org [18:18:00] oh but we don't have anywhere to get the timestamp [18:18:18] it's not expected to be anywhere on the bounce message [18:18:38] nevermind, i'm an idiot [18:18:39] Jeff_Green: Yeah, it has to be encoded there. [18:18:41] Jeff_Green: we have some information in the header though [18:19:04] i just looked right past the fact that we're encoding it there :-P [18:19:17] cool :D [18:19:46] (03PS1) 10Reedy: Remove TextContentHandler, copied from core. Causes name conflict [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/140429 [18:19:49] * Reedy sighs [18:20:09] (03CR) 10Reedy: [C: 032] Remove TextContentHandler, copied from core. Causes name conflict [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/140429 (owner: 10Reedy) [18:20:18] (03CR) 10Reedy: [V: 032] Remove TextContentHandler, copied from core. Causes name conflict [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/140429 (owner: 10Reedy) [18:21:42] (03PS1) 10Reedy: Remove ContentHandler too. Copy paste from core [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/140430 [18:21:55] (03CR) 10Reedy: [C: 032 V: 032] Remove ContentHandler too. Copy paste from core [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/140430 (owner: 10Reedy) [18:23:06] (03PS1) 10Anomie: ApiExpandTemplates: Start parse before creating frame [core] - 10https://gerrit.wikimedia.org/r/140431 (https://bugzilla.wikimedia.org/66798) [18:25:20] 3MediaWiki / 3API: Fatal error: Call to a member function getPrefixedText() on a non-object in LuaCommon.php on line 419 - 10https://bugzilla.wikimedia.org/66798#c2 (10Brad Jorsch) a:3Brad Jorsch Turns out to be GIGO as far as Scribunto is concerned, the real problem is the API is passing in a frame with... [18:25:23] (03CR) 10EBernhardson: "That sounds quite reasonable to me jon," [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140204 (owner: 10EBernhardson) [18:26:55] alright, last though. so now that we've gone a very roundabout wait to realize all we needed to change was the addition of the email address somewhere in the VERP string....can we do away with storing it? HMAC provides the protection against abuse. The only thing I see us maybe needing is to make sure the email address block never exceeds whatever character length is available after HMAC and timestampl [18:27:49] 3MediaWiki / 3Unit tests: DjVuTest::testGetPageText fails on travis - 10https://bugzilla.wikimedia.org/64947#c1 (10Ori Livneh) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 61070 *** [18:27:49] 3MediaWiki / 3DjVu: Failing unit test: DjVuTest::testGetPageText - 10https://bugzilla.wikimedia.org/61070#c2 (10Ori Livneh) *** Bug 64947 has been marked as a duplicate of this bug. *** [18:28:59] (03PS2) 10Alex Monk: Prevent ApiAddStudents enrolling invalid users [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/140137 (https://bugzilla.wikimedia.org/66624) (owner: 10AndyRussG) [18:29:20] 3MediaWiki-Vagrant: VisualEditor fails to provision with rbenv error - 10https://bugzilla.wikimedia.org/66764#c1 (10Dan Duvall) 5NEW>3UNCO a:5Ori Livneh>3Dan Duvall I'm unable to repro this from a fresh VM with the given roles enabled. Do you continue to get this error after provisioning a second time?... [18:29:30] could we just use the mediawiki user ID? [18:30:17] user ID ? int(10) AUTO_INCREMENT ? [18:30:25] right [18:30:48] allows us to support full-length email addresses [18:33:47] Thanks Krenair... I was wondering why Bugzilla didn't notice the patch 8p [18:34:58] (03PS2) 10Ori.livneh: Ignore days of random failing tests in wfTimestampTest [core] - 10https://gerrit.wikimedia.org/r/131674 (https://bugzilla.wikimedia.org/64946) (owner: 10Addshore) [18:35:16] ori: this might be a question for bd808, but do you know why roles::math would require installation of the Math extension from a sys package? [18:36:37] (03PS3) 10Ori.livneh: Ignore days of random failing tests in wfTimestampTest [core] - 10https://gerrit.wikimedia.org/r/131674 (https://bugzilla.wikimedia.org/64946) (owner: 10Addshore) [18:36:51] marxarelli: it has a binary component [18:37:00] (03PS5) 10EBernhardson: wire up new topic submission [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140036 [18:37:05] in ocaml [18:37:05] ori: due to the i'm getting an "unmet dependencies" error when i attempt to provision the math role [18:37:16] hmm [18:37:23] file a bug? [18:37:27] (03PS4) 10Brian Wolff: Fix ?embedplayer=yes mode, which is currently totally broken [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/137529 (https://bugzilla.wikimedia.org/66143) [18:37:43] (03CR) 10Ori.livneh: [C: 032] Ignore days of random failing tests in wfTimestampTest [core] - 10https://gerrit.wikimedia.org/r/131674 (https://bugzilla.wikimedia.org/64946) (owner: 10Addshore) [18:38:02] (don't mean to sound snarky -- no ideas come to mind is all) [18:38:57] (03CR) 10Brian Wolff: "PS4: PS2 rebased" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/137529 (https://bugzilla.wikimedia.org/66143) (owner: 10Brian Wolff) [18:39:12] no worries. i'll file it [18:41:11] (03Merged) 10jenkins-bot: Ignore days of random failing tests in wfTimestampTest [core] - 10https://gerrit.wikimedia.org/r/131674 (https://bugzilla.wikimedia.org/64946) (owner: 10Addshore) [18:42:01] (03CR) 10Kaldari: [C: 032] Migrate from $.browser to $.client since $.browser is deprecated [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/140034 (https://bugzilla.wikimedia.org/66689) (owner: 10Bsitu) [18:42:09] (03Merged) 10jenkins-bot: Migrate from $.browser to $.client since $.browser is deprecated [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/140034 (https://bugzilla.wikimedia.org/66689) (owner: 10Bsitu) [18:42:22] (03CR) 10Jackmcbarn: [C: 031] "Tested, fixes the problem." [core] - 10https://gerrit.wikimedia.org/r/140431 (https://bugzilla.wikimedia.org/66798) (owner: 10Anomie) [18:50:42] csteipp:, Jeff_Green so, our conclusion was to generate the VERP address something like bounce-{userID}-{date}-{hash}@wikimedia.org, where hash = hmac( userid+date, secret_key ) and on the recieving end, we just need to check if ( hmac(userid+date, secret_key ) ) generates hash. :) [19:04:51] 3MediaWiki-Vagrant: Provisioning the math role results in an "unmet dependencies" dpkg error - 10https://bugzilla.wikimedia.org/66807 (10Dan Duvall) 3NEW p:3Unprio s:3normal a:3Ori Livneh Created attachment 15682 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15682&action=edit Puppet output of... [19:05:48] (03PS1) 10Brian Wolff: Fix DjVu test (Make sure to check for djvutxt binary) [core] - 10https://gerrit.wikimedia.org/r/140442 (https://bugzilla.wikimedia.org/61070) [19:06:58] James_F: Do you have a moment? [19:07:28] How long will VE support MW1.23? [19:09:08] (03CR) 10Catrope: [C: 032] Remove display:inline-block highlight hacks for math nodes [extensions/Math] - 10https://gerrit.wikimedia.org/r/139807 (owner: 10Esanders) [19:10:07] (03Merged) 10jenkins-bot: Remove display:inline-block highlight hacks for math nodes [extensions/Math] - 10https://gerrit.wikimedia.org/r/139807 (owner: 10Esanders) [19:11:05] (03PS2) 10Reedy: Fix DjVu test (Make sure to check for djvutxt binary) [core] - 10https://gerrit.wikimedia.org/r/140442 (https://bugzilla.wikimedia.org/61070) (owner: 10Brian Wolff) [19:11:11] (03CR) 10Reedy: [C: 032] Fix DjVu test (Make sure to check for djvutxt binary) [core] - 10https://gerrit.wikimedia.org/r/140442 (https://bugzilla.wikimedia.org/61070) (owner: 10Brian Wolff) [19:12:27] (03CR) 10Gergő Tisza: [C: 031] "Looks sane, haven't tested" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/137529 (https://bugzilla.wikimedia.org/66143) (owner: 10Brian Wolff) [19:14:26] (03PS3) 10Welterkj: Add composer support and increment the minor version of this extension (1.0 -> 1.1.0). [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/139298 [19:15:31] (03Merged) 10jenkins-bot: Fix DjVu test (Make sure to check for djvutxt binary) [core] - 10https://gerrit.wikimedia.org/r/140442 (https://bugzilla.wikimedia.org/61070) (owner: 10Brian Wolff) [19:16:48] 3MediaWiki / 3DjVu: Failing unit test: DjVuTest::testGetPageText - 10https://bugzilla.wikimedia.org/61070 (10Bawolff (Brian Wolff)) 5PATC>3RESO/FIX [19:18:37] (03CR) 10Welterkj: "Addressed Jeroen's comments using patch set 3." (033 comments) [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/139298 (owner: 10Welterkj) [19:22:48] 3MediaWiki / 3Unit tests: WfTimestampTest::testOldTimestamps randomly fails for some users and on travis - 10https://bugzilla.wikimedia.org/64946 (10Ori Livneh) 5PATC>3RESO/FIX [19:23:59] (03CR) 10Daniel Friesen: SpecialVersion: Show 'Skins' and 'Extensions' in separate sections (031 comment) [core] - 10https://gerrit.wikimedia.org/r/136615 (owner: 10Bartosz Dziewoński) [19:24:32] (03PS4) 10Welterkj: Add composer support and increment the minor version of this extension (1.0 -> 1.1.0). [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/139298 [19:26:03] 3MediaWiki / 3Revision deletion: RevisionDelete - Cannot inherit previously-inherited or override constant READ_LATEST from interface IDBAccessObject in Revision.php on line 26 - 10https://bugzilla.wikimedia.org/65175#c5 (10Kenneth Burgener) I tried changing my config to this: [--- ## Shared memory settings... [19:35:42] (03CR) 10CSteipp: [C: 032] "This seems to have fixed the immediate issue, and is currently deployed, so I'm merging it as is. It would be good for someone with more e" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/140137 (https://bugzilla.wikimedia.org/66624) (owner: 10AndyRussG) [19:35:52] (03Merged) 10jenkins-bot: Prevent ApiAddStudents enrolling invalid users [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/140137 (https://bugzilla.wikimedia.org/66624) (owner: 10AndyRussG) [19:39:26] (03PS16) 10Cmcmahon: browser acceptance tests [core] - 10https://gerrit.wikimedia.org/r/133507 (https://bugzilla.wikimedia.org/66272) [19:42:03] 3MediaWiki-Vagrant: ruby-build significantly slows down the provisioning process - 10https://bugzilla.wikimedia.org/66763#c2 (10Matthew Flaschen) (In reply to Dan Duvall from comment #1) > The compilation of Ruby should only happen once, as it's system wide. I thought part of the point was to allow different... [19:42:36] (03PS17) 10Cmcmahon: browser acceptance tests [core] - 10https://gerrit.wikimedia.org/r/133507 (https://bugzilla.wikimedia.org/66272) [19:43:03] 3MediaWiki / 3Revision deletion: RevisionDelete - Cannot inherit previously-inherited or override constant READ_LATEST from interface IDBAccessObject in Revision.php on line 26 - 10https://bugzilla.wikimedia.org/65175#c6 (10Jackmcbarn) APC is still enabled, even if MediaWiki isn't trying to use it. Set apc.e... [19:45:06] multichill: Hey, yes. [19:45:10] multichill: Sorry, was in meeting. [19:47:02] (03PS2) 10EBernhardson: Hygiene: Move helper functions to bottom of flow-handlebars [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140219 (owner: 10Jdlrobson) [19:47:51] (03CR) 10EBernhardson: [C: 032] Hygiene: Move helper functions to bottom of flow-handlebars [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140219 (owner: 10Jdlrobson) [19:48:03] (03PS18) 10Cmcmahon: browser acceptance tests [core] - 10https://gerrit.wikimedia.org/r/133507 (https://bugzilla.wikimedia.org/66272) [19:48:15] (03Merged) 10jenkins-bot: Hygiene: Move helper functions to bottom of flow-handlebars [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140219 (owner: 10Jdlrobson) [19:49:12] James_F: How long will VE support MW1.23? [19:49:39] (03PS1) 10Reedy: Fix $wgDjvuPostProcessor comment about default being pnmtopng [core] - 10https://gerrit.wikimedia.org/r/140453 [19:49:49] bawolff: ^^ [19:50:40] (03CR) 10Brian Wolff: [C: 032] Fix $wgDjvuPostProcessor comment about default being pnmtopng [core] - 10https://gerrit.wikimedia.org/r/140453 (owner: 10Reedy) [19:51:00] http://sourceforge.net/tracker/index.php?func=detail&aid=1704049&group_id=32953&atid=406583 [19:51:03] (03CR) 10Jdlrobson: [C: 04-1] "Let me fix this up and get in a mergeable state." (032 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138788 (owner: 10Werdna) [19:51:10] !!! MediaWiki release management applicant's IRC office hour starts in 10 minutes over in #wikimedia-office !!! [19:51:10] There is no such key, you probably want to try: !tss, !bribe, !hss, [19:51:16] heh [19:51:30] 6 weeks from April 2007 [19:54:04] (03Merged) 10jenkins-bot: Fix $wgDjvuPostProcessor comment about default being pnmtopng [core] - 10https://gerrit.wikimedia.org/r/140453 (owner: 10Reedy) [19:55:19] 3MediaWiki-Vagrant: VisualEditor fails to provision with rbenv error - 10https://bugzilla.wikimedia.org/66764#c2 (10Matthew Flaschen) Created attachment 15683 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15683&action=edit Puppet error with VisualEditor provisioning failure Yes, it's reproducible on... [19:56:37] (03CR) 10EBernhardson: [C: 04-1] "not sure if its intentional, but this looks funny for the 'smallest' sizing: http://i.imgur.com/C10NMon.png not sure what it should be tho" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140253 (owner: 10Jdlrobson) [19:57:50] 3MediaWiki-Vagrant: VisualEditor fails to provision with rbenv error - 10https://bugzilla.wikimedia.org/66764 (10Matthew Flaschen) 5UNCO>3NEW [19:57:52] (03CR) 10EBernhardson: [C: 032] Remove duplicated TopicRow definition [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140260 (owner: 10Bsitu) [19:58:09] (03Merged) 10jenkins-bot: Remove duplicated TopicRow definition [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140260 (owner: 10Bsitu) [19:58:40] (03PS1) 10MaxSem: Fix fatal [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/140532 (https://bugzilla.wikimedia.org/66799) [19:59:49] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/140526 (owner: 10L10n-bot) [20:00:35] 3MediaWiki / 3Installer: update.php could do more to allow in place upgrades of small-medium sized wikis - 10https://bugzilla.wikimedia.org/66809 (10Bawolff (Brian Wolff)) 3NEW p:3Unprio s:3normal a:3None Brought up originally at https://www.mediawiki.org/wiki/Talk:Release_Management_RFP/2014/Consort... [20:00:52] (03PS3) 10EBernhardson: Add support for Function callback override to API calls [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140334 (owner: 10SG) [20:01:08] (03CR) 10EBernhardson: "PS3: s/overrideObject/override/" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140334 (owner: 10SG) [20:01:31] (03CR) 10EBernhardson: [C: 032] Add support for Function callback override to API calls [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140334 (owner: 10SG) [20:01:49] (03Merged) 10jenkins-bot: Add support for Function callback override to API calls [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140334 (owner: 10SG) [20:02:56] (03CR) 10Jdlrobson: Implement AJAX preview on frontend-rewrite. (032 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138788 (owner: 10Werdna) [20:03:08] multichill: In master? We're already not supporting MW 1.23, sadly. [20:03:19] 3MediaWiki / 3Revision deletion: RevisionDelete - Cannot inherit previously-inherited or override constant READ_LATEST from interface IDBAccessObject in Revision.php on line 26 - 10https://bugzilla.wikimedia.org/65175#c7 (10Kenneth Burgener) disabling apc in /etc/php.ini appeared to work. "Revision visibili... [20:03:20] multichill: But VE REL1_23 supports MW 1.23 fine, I believe. [20:03:32] You're not James_F? [20:03:50] multichill: I'm not? [20:03:52] (03PS8) 10Jdlrobson: Implement AJAX preview on frontend-rewrite. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138788 (owner: 10Werdna) [20:03:53] So I get stuck with an old version of VE? [20:03:56] (03CR) 10jenkins-bot: [V: 04-1] Implement AJAX preview on frontend-rewrite. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138788 (owner: 10Werdna) [20:04:10] multichill: MW 1.23 was branched without a change VE relies on. [20:04:34] (03CR) 10Krinkle: "Also, OOjs needs JSON.stringify which es5-shim does not provide. JSON is new in ES5, but was adopted by many browsers before the rest of E" [core] - 10https://gerrit.wikimedia.org/r/139308 (owner: 10Jforrester) [20:04:43] (03CR) 10Jdlrobson: [C: 031] "Apparently Shahyar was going to restyle this but let's do a follow up patchset. This is better than current state." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138788 (owner: 10Werdna) [20:04:49] That sucks. Why? Don't you care about other wiki's than WMF wiki's running VE? [20:04:54] multichill: 1.23 is a LTS release, it might get updates :) [20:05:22] (of note, there's a meeting about releases happening in #wikimedia-office if you're into that sort of thing) [20:05:30] James_F: Do you have a bug for that? [20:06:07] James_F: I've been running VE for quite some time on my company wiki. That uses stable versions so it's being upgraded to 1.23 soon. [20:08:33] 3MediaWiki-Vagrant: ruby-build significantly slows down the provisioning process - 10https://bugzilla.wikimedia.org/66763#c3 (10Dan Duvall) (In reply to Matthew Flaschen from comment #2) > (In reply to Dan Duvall from comment #1) > > The compilation of Ruby should only happen once, as it's system wide. > > I... [20:09:33] 3MediaWiki / 3Revision deletion: RevisionDelete - Cannot inherit previously-inherited or override constant READ_LATEST from interface IDBAccessObject in Revision.php on line 26 - 10https://bugzilla.wikimedia.org/65175#c8 (10Jackmcbarn) 5UNCO>3RESO/INV It looks like you're hitting https://bugs.php.net/bug... [20:10:04] (03PS9) 10Jdlrobson: Implement AJAX preview on frontend-rewrite. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138788 (owner: 10Werdna) [20:10:25] (03CR) 10Jdlrobson: [C: 031] "Awaiting sanity check" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138788 (owner: 10Werdna) [20:11:33] (03PS2) 10Krinkle: Avoid using popen() when "parallelize" is disabled [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/140416 (https://bugzilla.wikimedia.org/66467) (owner: 10Aaron Schulz) [20:12:06] (03PS2) 10Krinkle: filebackend: Avoid using popen() when "parallelize" is disabled [core] - 10https://gerrit.wikimedia.org/r/140406 (https://bugzilla.wikimedia.org/66467) (owner: 10Aaron Schulz) [20:12:39] (03CR) 10Jdlrobson: [C: 032] Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/140489 (owner: 10L10n-bot) [20:13:41] multichill: I didn't branch MW 1.23, and I agree it sucks. We will try to get the dependency back-ported to MW 1.23.1 or somesuch so that others can use VisualEditor master rather than an old version. [20:14:17] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/140489 (owner: 10L10n-bot) [20:14:30] That would be nice James_F. Do you happen to have a bug I can follow? [20:14:45] (03CR) 10Jdlrobson: [C: 04-1] Only bind onClickInteractive on nodes that have the required data attr (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139812 (owner: 10Matthias Mullie) [20:14:53] multichill: I'll create one now. [20:15:07] Great [20:15:35] 3MediaWiki extensions / 3ContactPage: Integration with the ConfirmEdit extension no longer works since version 2.x - 10https://bugzilla.wikimedia.org/66811 (10[[kgh]]) 3NEW p:3Unprio s:3normal a:3None As of version ContactPage 2.x the integration with the ConfirmEdit extension via $wgCaptchaTrigger... [20:17:04] 3MediaWiki-Vagrant: Provisioning the math role results in an "unmet dependencies" dpkg error - 10https://bugzilla.wikimedia.org/66807#c1 (10Bryan Davis) (In reply to Dan Duvall from comment #0) > Removing the `packages::mediawiki_math` resource from the math role avoids > the package dependency error and compi... [20:17:13] James_F: Using VE in my fight with the WIndows engineers with their f**king Sharepoint ;-) [20:17:21] multichill: :-) [20:18:52] (03CR) 10Mattflaschen: [C: 04-1] "Just a small issue. console.log is not cross-browser safe, so MW has other methods for it (mw.log.warn or mw.log)." (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140036 (owner: 10EBernhardson) [20:19:06] 3MediaWiki / 3Skin and page rendering: Backport mediawiki.skinning.content.parsoid to MW 1.23.x so VisualEditor master can run there - 10https://bugzilla.wikimedia.org/66812 (10James Forrester) 3NEW p:3Unprio s:3enhanc a:3None In advance of rewriting the skins system, MediaWiki 1.24 introduces a medi... [20:19:06] multichill: https://bugzilla.wikimedia.org/show_bug.cgi?id=66812 [20:20:14] So how old is the current VE 1.23 version? [20:20:58] James_F: ^^ [20:22:58] (03CR) 10EBernhardson: [C: 032] "minor problems:" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138788 (owner: 10Werdna) [20:23:15] (03Merged) 10jenkins-bot: Implement AJAX preview on frontend-rewrite. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138788 (owner: 10Werdna) [20:23:53] multichill: About 3 weeks – see https://gist.github.com/anonymous/98af4bd5044c6900638a for the list of changes against master. [20:24:28] Ah, ok, so that isn't that bad :-D [20:24:30] multichill: Oh, wait, no, that's only with my update of REL1_23. [20:24:41] ? [20:25:04] It's actually https://gist.github.com/anonymous/83ae21da381735bf309a [20:25:17] * James_F fixes. [20:25:52] And how long is that James_F? [20:26:33] 3Wikimedia / 3General/Unknown: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - 10https://bugzilla.wikimedia.org/66699#c27 (10Jared Zimmerman (WMF)) Most modern sites have dispensed with this type of control all together, financial sites do the opposite and force log you... [20:27:03] 3MediaWiki / 3Revision deletion: RevisionDelete - Cannot inherit previously-inherited or override constant READ_LATEST from interface IDBAccessObject in Revision.php on line 26 - 10https://bugzilla.wikimedia.org/65175#c9 (10Kenneth Burgener) Ok, thank you. [20:27:08] multichill: That's nine weeks, hence why I'm fixing. [20:27:20] Isn't that bad either [20:27:23] (03PS1) 10Krinkle: Add json2.js polyfill (v2014-02-04; with module skip function) [core] - 10https://gerrit.wikimedia.org/r/140560 [20:27:41] multichill: It's pretty bad. :-) [20:27:41] So I'll just do the upgrade and hopefully are able to upgrade again somewhere in November [20:27:59] multichill: Wait ten minutes and it'll be three weeks like I promised. [20:28:26] (03PS6) 10EBernhardson: Add 'restore-topic' url & various fixes to close/open topic [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140230 (owner: 10Bsitu) [20:28:39] Someone else is doing it for me James_F, probably tomorrow or next week [20:28:54] multichill: In that case it should be fine. [20:29:15] I refuse to be root on any server at my company because than I end up maintaining things :P [20:29:50] multichill: :-D [20:30:11] multichill: REL1_23 of VE is now a three-weeks-old cut of master. [20:30:17] HTH. [20:30:23] lol [20:30:32] (03PS2) 10Krinkle: Add json2.js polyfill (v2014-02-04; with module skip function) [core] - 10https://gerrit.wikimedia.org/r/140560 [20:30:36] (03CR) 10EBernhardson: "restore-topic is also being implemented in the js moderation patch, will see if can cherry pick one on top of the other." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140230 (owner: 10Bsitu) [20:34:18] 3Wikimedia / 3Bugzilla: Top 10 people who resolved the most reports in the last 7 days: link on Weekly Summary page doesn't work - 10https://bugzilla.wikimedia.org/66778 (10Tomasz W. Kozlowski) 5PATC>3RESO/FIX [20:34:19] (03CR) 10jenkins-bot: [V: 04-1] Add json2.js polyfill (v2014-02-04; with module skip function) [core] - 10https://gerrit.wikimedia.org/r/140560 (owner: 10Krinkle) [20:34:48] 3Wikimedia / 3General/Unknown: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - 10https://bugzilla.wikimedia.org/66699#c28 (10Steven Walling) (In reply to Jared Zimmerman (WMF) from comment #27) > Most modern sites have dispensed with this type of control all together, >... [20:34:50] (03CR) 10Krinkle: "To test, in incognito mode open your wiki with ?debug=true and open the developer tools and watch the network." [core] - 10https://gerrit.wikimedia.org/r/140560 (owner: 10Krinkle) [20:35:19] (03CR) 10EBernhardson: "couple concerns regarding {{#each revisions}} in the summary template, maybe we intend to always render with a single revision?" (032 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140230 (owner: 10Bsitu) [20:35:48] 3MediaWiki / 3General/Unknown: Update branches in mediawiki/extensions/* for REL1_23 - 10https://bugzilla.wikimedia.org/64157#c12 (10Tisza Gergő) UploadWizard is also affected by this, and as a result it is completely broken on 1.23. [20:36:14] (03PS3) 10Krinkle: Add json2.js polyfill (v2014-02-04; with module skip function) [core] - 10https://gerrit.wikimedia.org/r/140560 [20:37:20] ori: saving 3kb on every page by not loading jquery.json.js in modern browsers ^ [20:37:34] 3Wikimedia / 3General/Unknown: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - 10https://bugzilla.wikimedia.org/66699#c29 (10Bawolff (Brian Wolff)) I strongly suggest this be discussed on meta before being implemented. Especially given the less than positive response la... [20:38:15] bawolff: not in favor of taking the issue to committee [20:38:18] 3MediaWiki / 3API: API output containing is corrupted in non-XML formats - 10https://bugzilla.wikimedia.org/66776#c2 (10Chris Steipp) I think I'd prefer to leave the option for mangling in, even if it's behind a feature flag. I'll try to test out a couple of scenarios to confirm exactly... [20:38:44] (03PS6) 10Jdlrobson: wire up new topic submission [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140036 (owner: 10EBernhardson) [20:38:48] (03CR) 10jenkins-bot: [V: 04-1] wire up new topic submission [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140036 (owner: 10EBernhardson) [20:38:50] StevenW: Well wasn't there a giant flame war last time this happened if I remember correctly? [20:38:56] No [20:39:02] I remember no such flame [20:39:09] there was a flame over the label of the checkbox [20:39:13] but not the behavior [20:39:25] (03PS7) 10Jdlrobson: Wire up new topic submission [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140036 (owner: 10EBernhardson) [20:39:28] (03CR) 10jenkins-bot: [V: 04-1] Wire up new topic submission [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140036 (owner: 10EBernhardson) [20:39:39] (03PS1) 10Manybubbles: morelike: with multiple titles [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140562 (https://bugzilla.wikimedia.org/66737) [20:40:38] meh, I don't overly remember [20:41:03] Does seem like a political not a technical issue, but mostly I'd consider it not my problem [20:42:26] (03Abandoned) 10Krinkle: Fix for FileOpBatch.php [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/140387 (owner: 10Paladox) [20:42:29] (03PS1) 10Jforrester: Update VisualEditor to I98e9e21a [core] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140563 [20:43:48] 3MediaWiki / 3Special pages: Move "Special:MyLanguage" from Extension:Translate to MediaWiki core - 10https://bugzilla.wikimedia.org/66762#c2 (10Ryan Kaldari) The WhatLinksHere issue (bug 61547) doesn't seem like a blocker to me. Regarding the backwards compatibility, I agree we should add some BC code to T... [20:46:36] (03PS8) 10Jdlrobson: Wire up new topic submission [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140036 (owner: 10EBernhardson) [20:48:33] (03PS6) 10Krinkle: Update jquery.hoverintent to r7 [core] - 10https://gerrit.wikimedia.org/r/139687 (owner: 10Paladox) [20:49:33] (03CR) 10Krinkle: "Change link to be a permalink (don't use "latest" or "master")." [core] - 10https://gerrit.wikimedia.org/r/139687 (owner: 10Paladox) [20:52:51] hoo|away: pong [20:52:52] (03CR) 10Krinkle: [C: 04-1] "Did you import the code from the (potentially) unstable 'develop' branch (as your link indicates), or did you import the released distribu" [core] - 10https://gerrit.wikimedia.org/r/139698 (owner: 10Paladox) [20:52:54] (03PS1) 10Manybubbles: Add syntax to limit searches to local wikis [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140567 [20:53:04] 3Wikimedia / 3General/Unknown: Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis - 10https://bugzilla.wikimedia.org/66699#c30 (10Steven Walling) (In reply to Bawolff (Brian Wolff) from comment #29) > I strongly suggest this be discussed on meta before being implemented. > E... [20:53:43] (03PS2) 10Manybubbles: Add syntax to limit searches to the local wiki [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/140567 [20:55:41] (03PS1) 10Mattflaschen: Save $this.topicNavigation even if empty to avoid error [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140568 [20:56:03] (03CR) 10Paladox: "Hi yes I downloaded the file from tag 2.7.0 on GitHub." [core] - 10https://gerrit.wikimedia.org/r/140383 (https://bugzilla.wikimedia.org/66467) (owner: 10Paladox) [20:56:23] (03PS9) 10Krinkle: Update jquery.validate from 1.8.1 to 1.12.0 [core] - 10https://gerrit.wikimedia.org/r/139697 (owner: 10Paladox) [20:56:26] (03CR) 10Paladox: "Hi that was for another comment." [core] - 10https://gerrit.wikimedia.org/r/140383 (https://bugzilla.wikimedia.org/66467) (owner: 10Paladox) [20:56:45] (03CR) 10Paladox: "Hi yes I downloaded the zip file from tag 2.7.0 on github" [core] - 10https://gerrit.wikimedia.org/r/139698 (owner: 10Paladox) [20:57:04] (03PS9) 10Paladox: Update moment folder and files from 1.6.0 to 2.7.0 [core] - 10https://gerrit.wikimedia.org/r/139698 [20:57:20] (03PS1) 10Gerrit Patch Uploader: Check for empty response [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140569 [20:57:22] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140569 (owner: 10Gerrit Patch Uploader) [20:59:18] (03CR) 10Spage: [C: 032] "Seems right thing to do." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140568 (owner: 10Mattflaschen) [20:59:35] (03Merged) 10jenkins-bot: Save $this.topicNavigation even if empty to avoid error [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140568 (owner: 10Mattflaschen) [21:00:05] (03PS10) 10Paladox: Update moment folder and files from 2.6.0 to 2.7.0 [core] - 10https://gerrit.wikimedia.org/r/139698 [21:02:11] (03PS11) 10Paladox: Update moment folder and files from 2.6.0 to 2.7.0 [core] - 10https://gerrit.wikimedia.org/r/139698 [21:02:54] (03PS6) 10Jdlrobson: Segregate Reference objects by source wiki. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136280 (https://bugzilla.wikimedia.org/65915) (owner: 10Werdna) [21:03:34] (03CR) 10Jdlrobson: [C: 031] "Sanity check needed" (032 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140036 (owner: 10EBernhardson) [21:04:36] (03PS3) 10Paladox: Update jquery.form.js [core] - 10https://gerrit.wikimedia.org/r/139688 [21:04:42] (03CR) 10Kaldari: [C: 032] Fix fatal [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/140532 (https://bugzilla.wikimedia.org/66799) (owner: 10MaxSem) [21:04:56] (03PS4) 10Paladox: Update jquery.mockjax.js [core] - 10https://gerrit.wikimedia.org/r/139693 [21:05:55] (03Merged) 10jenkins-bot: Fix fatal [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/140532 (https://bugzilla.wikimedia.org/66799) (owner: 10MaxSem) [21:06:13] (03PS12) 10Paladox: Update moment folder and files from 2.6.0 to 2.7.0 [core] - 10https://gerrit.wikimedia.org/r/139698 [21:07:49] I'm trying to make changes in the mediawiki-config repo, and do not see the glue which does magic things to move wmg* variables into wg* per-wiki... [21:08:09] awight: Usually in CommonsSettings.php [21:08:14] (03CR) 10Mattflaschen: [C: 04-1] "This approach to error handling is obviously a stop gap, so I'm assuming it will be revisited." (033 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140036 (owner: 10EBernhardson) [21:08:21] (03CR) 10Jdlrobson: [C: 031] "Code looks fine." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/140414 (https://bugzilla.wikimedia.org/66797) (owner: 10EBernhardson) [21:08:34] is what converts a wmg variable into a wg [21:08:45] (03PS10) 10Paladox: mediawiki.searchSuggest: Enable for iPhone and iPod touch [core] - 10https://gerrit.wikimedia.org/r/139809 [21:09:02] awight: The actual glue is more complicated, see includes/SiteConfiguration.php in core [21:09:05] bawolff: well, I'm looking for a statement like $wg* = $wmg[$wgDBname] but that is not how it happens. I only see direct assignments from $wmgX to $wgX [21:09:11] bawolff: ah thx [21:09:38] awight: Its not well documented, so have fun :) [21:09:52] bawolff: ok that was the place though, thank you! [21:21:33] (03CR) 10Krinkle: [C: 04-1] "Did a rough read through the change log and there are a few potentially breaking changes that will need to be investigated and our code th" [core] - 10https://gerrit.wikimedia.org/r/139697 (owner: 10Paladox) [21:21:52] (03CR) 10Krinkle: [C: 032] Add configuration variable wgActivityMonitorRCStreamUrl [extensions/ActivityMonitor] - 10https://gerrit.wikimedia.org/r/139013 (owner: 10Harshkothari410) [21:21:56] (03Merged) 10jenkins-bot: Add configuration variable wgActivityMonitorRCStreamUrl [extensions/ActivityMonitor] - 10https://gerrit.wikimedia.org/r/139013 (owner: 10Harshkothari410) [21:22:47] Danny_B: look at the mw.html gerrit change [21:24:39] hoo: link, pls [21:25:33] Danny_B: https://gerrit.wikimedia.org/r/137659 [21:25:36] see my last comment [21:26:33] (03CR) 10Hashar: "I would love to have a Jenkins job to run them whenever someone send a patch or +2 it. If we only run them once per day, we will surely h" [core] - 10https://gerrit.wikimedia.org/r/133507 (https://bugzilla.wikimedia.org/66272) (owner: 10Cmcmahon) [21:28:54] (03PS19) 10Legoktm: browser acceptance tests [core] - 10https://gerrit.wikimedia.org/r/133507 (https://bugzilla.wikimedia.org/66272) (owner: 10Cmcmahon) [21:32:48] 3MediaWiki-Vagrant: Provisioning the math role results in an "unmet dependencies" dpkg error - 10https://bugzilla.wikimedia.org/66807#c2 (10physikerwelt) If you use the PNG output mode, a latex installation is required. The required latex related stuff is installed via the mediawiki_math package. If you are us... [21:33:22] * James_F mis-read greg-g's e-mail about the meeting as "And it happened – lo: " rather than "And it happened. Log: ". :-) [21:34:30] (03CR) 10Dduvall: [C: 04-1] "Chris, can you add the .gitignore mentioned previously?" [core] - 10https://gerrit.wikimedia.org/r/133507 (https://bugzilla.wikimedia.org/66272) (owner: 10Cmcmahon) [21:35:00] awjr: Hey, about SoS card #99: in the meeting I said Timo was working on it, it turns out he merged it yesterday :D so that card can be marked as done or whatever [21:36:29] haha ok thanks RoanKattouw [21:36:52] James_F: hah [21:39:33] (03PS2) 10Bsitu: Summarize Topic js interaction [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140182 [21:40:36] (03PS12) 10Jdlrobson: javascript post/topic moderation [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139016 (owner: 10EBernhardson) [21:43:26] (03PS20) 10Cmcmahon: browser acceptance tests [core] - 10https://gerrit.wikimedia.org/r/133507 (https://bugzilla.wikimedia.org/66272) [21:44:48] 3MediaWiki extensions / 3Math: Warning: pack(): Type H: not enough characters in string MathTexvc.php on line 38 - 10https://bugzilla.wikimedia.org/66800#c1 (10physikerwelt) Is there further information about the input that triggers this error. [21:46:15] spagewmf: When you have a minute, can you point me to the flow templating code? iirc you had a branch for it..? [21:47:26] csteipp: handlebars JS is in the Mantle extension. The Flow code is in the frontend-rewrite branch. We have it on the labs instance http://ee-flow-extra.wmflabs.org/wiki/User_talk:Csteipp :) [21:47:50] (03PS3) 10Jdlrobson: Summarize Topic js interaction [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140182 (owner: 10Bsitu) [21:47:59] (03CR) 10Krinkle: "Needs rebase. Looks overall like a useful change. Impact should be minimal since semantic markup in these kind of areas has little value (" [core] - 10https://gerrit.wikimedia.org/r/41364 (owner: 10Jarry1250) [21:48:30] (03CR) 10Jdlrobson: Summarize Topic js interaction (036 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140182 (owner: 10Bsitu) [21:48:49] (03CR) 10Jdlrobson: [C: 04-1] "Without Shahyar I'm not sure if this is the right approach but documentation should be added!" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140182 (owner: 10Bsitu) [21:53:18] (03CR) 10Krinkle: browser acceptance tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133507 (https://bugzilla.wikimedia.org/66272) (owner: 10Cmcmahon) [21:54:26] (03PS1) 10Reedy: Update Language::userAdjust() $ts parameter hint to be string [core] - 10https://gerrit.wikimedia.org/r/140579 [21:55:25] (03CR) 10Krinkle: browser acceptance tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133507 (https://bugzilla.wikimedia.org/66272) (owner: 10Cmcmahon) [21:55:48] (03PS2) 10Jdlrobson: Tweak hidden topic behaviour [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140253 [21:56:18] csteipp: also https://bugzilla.wikimedia.org/show_bug.cgi?id=63445#c2 explains [21:56:29] (03CR) 10Aaron Schulz: [C: 04-2] "I'd prefer this wait til we require PHP 5.4 to avoid register globals attacks. For example the isset() check in ConfirmAccount. Even if we" [core] - 10https://gerrit.wikimedia.org/r/139187 (owner: 10Withoutaname) [21:56:36] (03CR) 10Ori.livneh: [C: 04-1] "small quibble. thanks a bunch for this!" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/140579 (owner: 10Reedy) [21:57:01] (03CR) 10Krinkle: "It would be useful to distinguish between destructive and non-destructive tests. And either way, to not have the wiki clobber indefinitely" [core] - 10https://gerrit.wikimedia.org/r/133507 (https://bugzilla.wikimedia.org/66272) (owner: 10Cmcmahon) [21:58:52] (03PS13) 10EBernhardson: javascript post/topic moderation [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139016 [21:58:58] (03PS21) 10Cmcmahon: browser acceptance tests [core] - 10https://gerrit.wikimedia.org/r/133507 (https://bugzilla.wikimedia.org/66272) [22:00:32] (03PS2) 10Reedy: Update Language::userAdjust() $ts parameter hint to be string [core] - 10https://gerrit.wikimedia.org/r/140579 [22:00:44] (03PS4) 10Bsitu: Summarize Topic js interaction [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140182 [22:03:57] (03CR) 10Cmcmahon: "Krinkle: the numeric strings are part of the contents of the page, not a part of the page name. Each test creates single pages with well-" [core] - 10https://gerrit.wikimedia.org/r/133507 (https://bugzilla.wikimedia.org/66272) (owner: 10Cmcmahon) [22:04:47] (03CR) 10Ori.livneh: [C: 032] Update Language::userAdjust() $ts parameter hint to be string [core] - 10https://gerrit.wikimedia.org/r/140579 (owner: 10Reedy) [22:06:22] (03CR) 10Krinkle: "@Chris: What about these? http://en.wikipedia.beta.wmflabs.org/wiki/Special:Contributions/Selenium_user?namespace=0&newOnly=1" [core] - 10https://gerrit.wikimedia.org/r/133507 (https://bugzilla.wikimedia.org/66272) (owner: 10Cmcmahon) [22:06:24] (03CR) 10Danny B.: "Boolean false is not valid value. Valid values are strings and numbers. And newly nil which means "remove". False (boolean) should never b" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/137659 (https://bugzilla.wikimedia.org/62982) (owner: 10Jackmcbarn) [22:07:56] (03Merged) 10jenkins-bot: Update Language::userAdjust() $ts parameter hint to be string [core] - 10https://gerrit.wikimedia.org/r/140579 (owner: 10Reedy) [22:11:16] (03CR) 10Hoo man: [C: 04-1] "per Danny" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/137659 (https://bugzilla.wikimedia.org/62982) (owner: 10Jackmcbarn) [22:11:19] (03CR) 10Cmcmahon: "Krinkle: those pages with random(ish) strings are created by other tests intended to run against beta labs and test2wiki only. The tests " [core] - 10https://gerrit.wikimedia.org/r/133507 (https://bugzilla.wikimedia.org/66272) (owner: 10Cmcmahon) [22:15:27] (03PS3) 10Aaron Schulz: filebackend: Avoid using popen() when "parallelize" is disabled [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/140416 (https://bugzilla.wikimedia.org/66467) [22:18:33] 3MediaWiki extensions / 3PageImages: Fatal error: Call to a member function transform() on a non-object in PageImages.body.php on line 160 - 10https://bugzilla.wikimedia.org/66799 (10Max Semenik) 5PATC>3RESO/FIX [22:21:56] (03CR) 10Krinkle: [C: 04-1] "Overal this uses too many ID strings being passed around. Perhaps it can use more referencing instead of constantly re-querying by ID? Tha" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/67173 (https://bugzilla.wikimedia.org/48581) (owner: 10Worden.lee) [22:27:10] (03PS14) 10EBernhardson: javascript post/topic moderation [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139016 [22:29:10] (03PS3) 10Jdlrobson: Tweak hidden topic behaviour [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140253 [22:33:03] (03CR) 10EBernhardson: [C: 032] Add 'restore-topic' url & various fixes to close/open topic [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140230 (owner: 10Bsitu) [22:33:20] (03Merged) 10jenkins-bot: Add 'restore-topic' url & various fixes to close/open topic [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140230 (owner: 10Bsitu) [22:35:17] (03PS3) 10EBernhardson: Convert recoverable fatal errors into exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/140414 (https://bugzilla.wikimedia.org/66797) [22:46:33] (03PS7) 10Divec: Use LinearDoc for segmentation [services/cxserver] - 10https://gerrit.wikimedia.org/r/138532 [22:47:55] (03CR) 10Worden.lee: "This patch makes a fair-size collection of code that uses a lot of id queries into code that uses a lot of id queries and is more modular" [core] - 10https://gerrit.wikimedia.org/r/67173 (https://bugzilla.wikimedia.org/48581) (owner: 10Worden.lee) [22:54:15] (03PS1) 10JoelKP: Replace deprecated wfMsgExt call. [extensions/Widgets] - 10https://gerrit.wikimedia.org/r/140592 [22:55:21] (03CR) 10Yaron Koren: [C: 032 V: 032] Replace deprecated wfMsgExt call. [extensions/Widgets] - 10https://gerrit.wikimedia.org/r/140592 (owner: 10JoelKP) [22:56:53] (03PS1) 10EBernhardson: Prevent double-encoding of topic titles [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140593 [23:04:18] (03CR) 10MaxSem: [C: 032 V: 032] Update VisualEditor to I98e9e21a [core] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140563 (owner: 10Jforrester) [23:05:04] * addshore hates magic words [23:05:52] incidentally, the latest xkcd is titled "Magic Words". [23:06:05] *goes to look* :P [23:06:26] HAH [23:06:51] MatmaRex: "" is not a valid magic word for "forumlink" etc. any ideas? [23:07:07] !bug "is not a valid magic word for" [23:07:08] https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=%22is+not+a+valid+magic+word+for%22 [23:07:19] !bug ALL "is not a valid magic word for" [23:07:19] https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=ALL+%22is+not+a+valid+magic+word+for%22 [23:07:56] i could swear there was at least one more bug with this [23:08:00] :P [23:09:03] try running `php maintenance/rebuildLocalisationCache.php`? [23:09:12] thats what throws the exception ;p [23:09:52] seems to be happening with a variety of different extensions since I updatded something to 1.23 [23:10:18] MediaWiki 1.5 [23:10:31] (03PS6) 10Bsitu: close & open js interaction [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 [23:10:58] How about [23:11:01] php maintenance/rebuildLocalisationCache.php --force [23:11:09] *tries* [23:11:14] That also should just be a warning, not an exception [23:13:10] (03CR) 10EBernhardson: Wire up new topic submission (032 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140036 (owner: 10EBernhardson) [23:13:57] (03CR) 10EBernhardson: [C: 04-1] "this still hasn't made it through...almost certainly needs to be revisited and retested after the frontend-rewrite is merged to ensure no " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/115576 (owner: 10EBernhardson) [23:14:36] addshore: --jfdi [23:15:18] (03PS7) 10Bsitu: close & open js interaction [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140272 [23:16:45] bawolff: --force also doesnt work [23:17:23] *scratches head* [23:17:28] addshore: Hmm. Is whatever extension that registers forumlink magicword actually registering it properly? [23:17:56] Well, the one I am testing it with now is LQT :P [23:19:31] bawolff: https://github.com/wikimedia/mediawiki-extensions-LiquidThreads/blob/db0b64f737c8136bb2322b651819ef651317ac4c/i18n/LiquidThreads.magic.php [23:19:51] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (7a0e222a75) [core] - 10https://gerrit.wikimedia.org/r/140600 [23:20:49] addshore: grepping, 'forumlink' isn't used anywhere in LiquidThreads extension [23:21:31] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (7a0e222a75) [core] - 10https://gerrit.wikimedia.org/r/140600 (owner: 10Jforrester) [23:21:31] bawolff: sorry 'forumlink' was for DPLForum, "" is not a valid magic word for "useliquidthreads" is for LQT [23:21:33] Its part of DPLforum extension [23:21:47] I switched which extensions I was testing it with half way through [23:21:58] (03PS4) 10JGonera: [Reapply] Simplify thumbnail styling to have consistency with mobile [core] - 10https://gerrit.wikimedia.org/r/133301 (https://bugzilla.wikimedia.org/65160) (owner: 10Jforrester) [23:22:17] (03CR) 10JGonera: [C: 031] [Reapply] Simplify thumbnail styling to have consistency with mobile [core] - 10https://gerrit.wikimedia.org/r/133301 (https://bugzilla.wikimedia.org/65160) (owner: 10Jforrester) [23:23:19] 3MediaWiki / 3API: Allow other modules add their sub modules into ApiParamInfo - 10https://bugzilla.wikimedia.org/30936 (10Kunal Mehta (Legoktm)) [23:23:19] 3MediaWiki / 3API: Add ModuleManager support to action=paraminfo (deprecate querymodules) - 10https://bugzilla.wikimedia.org/45641 (10Kunal Mehta (Legoktm)) [23:24:46] (03CR) 10Mattflaschen: "Also, a minor commit message thing" (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140036 (owner: 10EBernhardson) [23:24:49] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (7a0e222a75) [core] - 10https://gerrit.wikimedia.org/r/140600 (owner: 10Jforrester) [23:25:46] addshore: Hmm, I can't reproduce [23:25:59] Does making a dummy edit to LocalSettings.php change anything? [23:26:19] 3Wikimedia / 3Deployment systems: [scap] Consolidate scripts as sub-commands of `scap` - 10https://bugzilla.wikimedia.org/65827#c4 (10Greg Grossmeier) Alright, bugzilla isn't necessarily the best place for bike shedding, and I don't want Mukunda to be blocked by that before he starts on this work... so... H... [23:26:31] (03PS1) 10Ori.livneh: Initial commit [services/jobrunner] - 10https://gerrit.wikimedia.org/r/140603 [23:26:46] (03CR) 10Ori.livneh: [C: 032 V: 032] Initial commit [services/jobrunner] - 10https://gerrit.wikimedia.org/r/140603 (owner: 10Ori.livneh) [23:27:19] nope :/ [23:27:30] I can only presume this is something stupid [23:32:05] 3MediaWiki / 3API: Allow other modules add their sub modules into ApiParamInfo - 10https://bugzilla.wikimedia.org/30936 (10Kunal Mehta (Legoktm)) 5NEW>3ASSI a:3Kunal Mehta (Legoktm) [23:36:01] (03PS1) 10Jdlrobson: Add QUnit test infrastructure. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140607 [23:36:04] (03PS1) 10Jdlrobson: Hide previews when hitting cancel [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140608 [23:36:23] ^ shahyar QUnit tests for ya [23:42:58] (03CR) 10SG: [C: 04-2] "I did not want previews to get implemented as-is. I told Andrew I had fixes for it. Even in its current state, the preview boxes should ha" (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140608 (owner: 10Jdlrobson) [23:43:27] (03CR) 10SG: [C: 031] "+1 for now, haven't thoroughly looked at it, but seems sane. Thanks!" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140607 (owner: 10Jdlrobson) [23:46:05] (03PS1) 10Mattflaschen: Fix error in FlowHandlebars docs [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140614 [23:47:01] (03CR) 10SG: [C: 032] Fix error in FlowHandlebars docs [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140614 (owner: 10Mattflaschen) [23:47:19] (03Merged) 10jenkins-bot: Fix error in FlowHandlebars docs [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/140614 (owner: 10Mattflaschen) [23:53:10] (03PS5) 10Jdlrobson: [Reapply] Simplify thumbnail styling to have consistency with mobile [core] - 10https://gerrit.wikimedia.org/r/133301 (https://bugzilla.wikimedia.org/65160) (owner: 10Jforrester) [23:57:57] (03PS1) 10Aaron Schulz: [WIP] Initial commit of new job runner loop [services/jobrunner] - 10https://gerrit.wikimedia.org/r/140618