[00:26:30] 3MediaWiki / 3JavaScript: QUnit tests for jquery.makeCollapsible often failing on Jenkins - 10https://bugzilla.wikimedia.org/63579#c15 (10Matthew Flaschen) I'm going to work on this as well, since it's a recurring problem affecting the Growth team. [00:42:48] (03PS1) 10Brian Wolff: Set $wgBlockAllowsUTEdit = true; by default [core] - 10https://gerrit.wikimedia.org/r/139654 [00:46:44] (03PS2) 10Nemo bis: Set $wgBlockAllowsUTEdit = true; by default [core] - 10https://gerrit.wikimedia.org/r/139654 (owner: 10Brian Wolff) [00:48:26] (03PS3) 10Brian Wolff: Set $wgBlockAllowsUTEdit = true; by default [core] - 10https://gerrit.wikimedia.org/r/139654 [00:50:16] (03CR) 10Nemo bis: "I agree in principle. The downside is that inexperienced admins tend to forget to block talk page even to spambots, which can then continu" [core] - 10https://gerrit.wikimedia.org/r/139654 (owner: 10Brian Wolff) [00:50:45] bawolff: ok try this, $(function(){ if (wgAction == "delete") { document.getElementById("wpDisableUTEdit").value = true; } }); [00:51:04] delete? [00:51:09] hmm? [00:51:12] 3Wikimedia / 3Site requests: Enable by default ability to edit own talkpage while blocked globally on all existing and future Wikimedia project wikis - 10https://bugzilla.wikimedia.org/28288#c5 (10Bawolff (Brian Wolff)) Slightly related, see https://gerrit.wikimedia.org/r/#/c/139654/ [00:51:40] Are you suggesting we just have the box checked by default? [00:51:47] * Nemo_bis did [00:52:07] I mean, is that what Withoutaname's suggesting by his js snippet? [00:52:16] yeah I pulled code from CleanDeleteReasons [00:52:23] to satisfy itwiki folks [00:52:36] who have it set to false, btw [00:53:08] Maybe we should change $wgBlockAllowsUTEdit to not be a hard disable, but just control if the preference is checked by default [00:53:35] the gadget should be fine [01:17:42] 3MediaWiki extensions / 3Math: Add separate database tables for Mathoid - 10https://bugzilla.wikimedia.org/65793#c22 (10Alex Monk) (In reply to Ori Livneh from comment #15) > I also revoked +2 rights on > extension/Math from Physikerwelt and Frédéric Wang Per the +2 policy, Brion Vibber, Tim Starling, Mark... [02:07:26] 3Wikimedia / 3Site requests: Complete unification of all accounts to SUL - 10https://bugzilla.wikimedia.org/35707#c30 (10PiRSquared17) (In reply to Dan Garry from comment #25) > I've got a plan afoot. Stay tuned for more information. Bug 14862 is close to being resolved. Any news? https://wikitech.wikimedia... [02:24:04] Krenair: legoktm: Withoutaname: YuviPanda|zzz: ragesoss: Thanks everyone for helping with today's Education Program bug... I'm looking at the patches, bug report and backscroll :) [02:24:25] np :) [02:42:20] legoktm: I guess what's most urgent is to https://gerrit.wikimedia.org/r/#/c/139644/ ? I understand the issue reported is no longer happening since you deleted the offfending rows--thanks a lot--that's correct? I'm also guessing the DB insertion could still happen despite the patch by Withoutaname... [02:43:19] yeah, I just deleted them from the database. My patch fixes the display issue (which is needed regardless), but what's most important is figuring out how an anonymous user signed up or how the user_id got set to 0. [02:43:27] yes, my patch raised the permissions bar so ips cant add themselves [02:43:46] but someone from outside could still be adding them, like an ep-admin or someone else with access to the interface [02:44:39] if the permissions check is faulty, then it could have no effect [02:47:08] I think the permissions check will at least l be an additional barrier for some cases. I'll look into the possible routes for this to have happened [02:50:15] legoktm: could IPv6 addresses be considered users? [02:50:53] no [02:50:54] I mean, not unless you're using IP::isIPv4( User::getName() ) or something stupid like that [03:09:30] legoktm: which fields were affected? we could throw an exception at the database insertion point [03:10:00] ep_students and something about courses by students [03:10:04] they're listed on the bug [03:12:05] Withoutaname: I think making sure that the user has the required rights when a user is enrolled should be sufficient [03:12:44] alright [03:18:35] Just looking through includes/ApiAddStudents.php and includes/ApiEnlist.php [03:18:55] sorry incldues/api/... I meant [03:42:51] In both those API modules ^ a user with the ep-addstudent right can add users to courses even if they don't have the ep-enroll right. However ApiAddStudents only works with user names and checks their validity first [04:13:16] https://en.wikipedia.org/w/index.php?title=Special:Log&page=Education+Program%3ASimmons+College%2FIntellectual+Freedom+-+LIS+493+%28Summer+2014%29 [04:14:42] (03PS8) 10Jackmcbarn: Support {{!}} as a magic word [core] - 10https://gerrit.wikimedia.org/r/136234 [04:16:50] maybe when he saved himself he logged his IP... [04:20:46] Looks like a request with a specially crafted URL [04:22:25] Back in a sec [04:22:31] isn't adding a student to a course not much different from adding a user to a user group? maybe we should go through the regular code checks that are associated with a bureaucrat assigning user perms [04:22:47] i see some abstract overlap in code [04:23:37] [21:22] Withoutaname isn't adding a student to a course not much different from adding a user to a user group? maybe we should go through the regular code checks that are associated with a bureaucrat assigning user perms [04:23:39] [21:22] Withoutaname i see some abstract overlap in code [04:28:09] Withoutaname: I think it's different. Being a student doesn't give you additional privilges really [04:29:03] but it could be a convenient categorization scheme [04:29:10] Regarding the code, yes it's kinda awful in a few respects. We're working on a replacement for the EducationProgram extension, bit by bit... [04:31:36] Withoutaname: https://www.mediawiki.org/wiki/Editor_campaigns [05:13:40] (03PS3) 10Talktodan: Display MediaWiki:Loginprompt on the login page [core] - 10https://gerrit.wikimedia.org/r/139399 (https://bugzilla.wikimedia.org/66574) [05:24:35] (03CR) 10Talktodan: "I didn't intend to move the location, I've uploaded a new patch which fixes that, thanks!" [core] - 10https://gerrit.wikimedia.org/r/139399 (https://bugzilla.wikimedia.org/66574) (owner: 10Talktodan) [05:26:18] (03CR) 10AndyRussG: [C: 032] "Looks good, thanks!! :)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/139644 (https://bugzilla.wikimedia.org/66624) (owner: 10Legoktm) [05:26:28] (03Merged) 10jenkins-bot: Update SpecialContributionsBeforeMainOutput hook handler [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/139644 (https://bugzilla.wikimedia.org/66624) (owner: 10Legoktm) [05:40:52] AndyRussG: I'll leave it up to you to close the bug whenever you're satisfied [05:41:04] Hey legoktm [06:13:25] legoktm: around? [06:48:33] YuviPanda: so how do I test the redirect.htaccess in vagrant? [06:48:44] legoktm: there's a vagrant patch [06:48:57] legoktm: https://gerrit.wikimedia.org/r/#/c/139651/ [06:48:59] same rules [06:49:20] hm, I must have missed that in my mail [06:49:52] :D [06:57:16] * legoktm waits for vagrant to boot [06:59:26] legoktm: :D [07:00:36] the mongodb thign is almost working! [07:01:22] webscale! [07:01:23] big data! [07:01:42] "Tool labs: bigger data than Wikidata" [07:01:47] :D [07:01:48] BIGGER DATA [07:07:51] (03CR) 10Nemo bis: "If the message is currently unused, yes, please empty it and make it ignored. https://www.mediawiki.org/wiki/Localisation#Messages_that_sh" [core] - 10https://gerrit.wikimedia.org/r/139399 (https://bugzilla.wikimedia.org/66574) (owner: 10Talktodan) [07:13:39] YuviPanda: is there a way we can have vagrant use the redirects.htaccess file in the extension rather than duplicating it? [07:14:18] legoktm: hmm, theoretically we could symlink things around, but I dunno if that'll cause complications [07:14:57] legoktm: btw, the vagrant patch won't work unless the patch fixing the UrlRouter is merged [07:15:26] ok. [07:16:33] (03CR) 10Legoktm: [C: 032 V: 032] Add sample redirect.htaccess [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139648 (owner: 10Yuvipanda) [07:17:25] legoktm: I can make the symlink thing and see if it works, though. But I'm slightly vary of making a vagrant role depend on a particular file in the repo, mostly for 'feels icky' reasons, although I can't quite explain why it feels icky to me [07:17:36] yeah, that does feel icky [07:18:13] legoktm: yeah, it does. So I'm ok with duplicating for now [07:18:32] legoktm: I also made it work with MF :) [07:18:59] (03CR) 10Legoktm: [C: 032 V: 032] Fix UrlRouter to route to UrlRedirector, not UrlShortener [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139650 (owner: 10Yuvipanda) [07:19:26] (03CR) 10Legoktm: [C: 032 V: 032] Add Mobile Support as well [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139652 (owner: 10Yuvipanda) [07:19:49] legoktm: only thing left is NOEXIST, I can take a poke after I finish up the mongodb stuff [07:20:07] legoktm: blockers from your POV to deploying at uncyc? :) [07:21:06] me figuring out where to add rewrite rules [07:21:35] legoktm: hmm, ok. You'll probably have rewrite rules already (to support /wiki/ syntax), so you'd just have to figure out where that is and add this on one [07:21:37] *on [07:21:39] *one [07:21:42] yeah [07:32:37] (03PS1) 10Legoktm: Add pre-1.23 i18n shim file [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139663 [07:32:41] YuviPanda: ^ [07:32:49] Uncyclopedia is still on 1.21 :/ [07:32:53] legoktm: :( kk [07:33:03] legoktm: imma just merge [07:33:13] (03CR) 10Yuvipanda: [C: 032 V: 032] Add pre-1.23 i18n shim file [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139663 (owner: 10Legoktm) [07:33:20] legoktm: you better be running php 5.3+ tho [07:33:33] we're on like php5.5 or something [07:33:41] ah, cool [07:34:24] http://test.uncyclopedia.co/wiki/Special:Version <-- desc still isn't showing up :/ [07:34:51] http://test.uncyclopedia.co/wiki/Special:UrlShortener <-- fatal :/ [07:34:53] * legoktm looks at log [07:35:05] legoktm: ran update.php? [07:35:22] oh lol no [07:35:54] why lol [07:36:10] because I forgot to do it -.- [07:37:29] Fatal error: Class SpecialUrlShortener contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (FormSpecialPage::onSuccess) in /var/www/mediawiki/extensions/UrlShortener/SpecialUrlShortener.php on line 118 [07:38:13] legoktm: that's a FormSpecialPage thing that was removed? [07:38:24] or made un-abstract I think [07:38:28] hmm, right [07:38:59] https://github.com/wikimedia/mediawiki-core/blob/REL1_21/includes/SpecialPage.php#L981 [07:40:31] legoktm: patched [07:40:35] legoktm: test? [07:40:43] bah stupid network [07:40:56] (03PS1) 10Legoktm: More 1.21 compat [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139664 [07:41:03] lol [07:41:04] fine [07:41:07] (03PS1) 10Yuvipanda: Add stub method to make extension 1.21 compatible [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139665 [07:41:17] (03CR) 10Legoktm: [C: 032 V: 032] More 1.21 compat [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139664 (owner: 10Legoktm) [07:41:31] legoktm: WHY U SELF MERGE [07:41:40] BECAUSE I'M DEPLOYING RIGHT NOW [07:41:49] legoktm: hehe :P [07:41:54] legoktm: I'mma add phpdoc [07:42:22] Fatal error: Call to undefined method HTMLForm::suppressDefaultSubmit() in /var/www/mediawiki/extensions/UrlShortener/SpecialUrlShortener.php on line 30 [07:42:24] okay [07:42:30] I'm going to stop trying now [07:43:03] (03PS1) 10Yuvipanda: Document MW1.21 compat hack [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139666 [07:43:25] legoktm: any idea when you guys will move off 1.21? [07:44:10] dunno [07:44:14] I might just do it tomorrow. [07:44:27] (03CR) 10Yuvipanda: [C: 032 V: 032] "Doc fix so self merging." [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139666 (owner: 10Yuvipanda) [07:44:29] legoktm: ok [07:44:38] legoktm: if you do that, we can remove the 1.21 hacks [07:44:45] yeah [07:46:21] legoktm: I should add mw.org page, write some docs, a README and stuff, and email wikitech-l [07:47:30] yes :D [07:47:48] +1 to mediawiki.org page [07:52:55] yeah, let me make it now, actually [07:57:31] ok, createdd https://www.mediawiki.org/wiki/Extension:UrlShortener [07:57:43] needs mo9re work [08:00:41] you set the extension type to "extension"? [08:02:13] YuviPanda: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FUrlShortener/0668e676c2294db658c561399a291773c44b6926/UrlShortener.php says Modified BSD... [08:06:32] legoktm: we should switch to WTFPL [08:06:55] fine with me. [08:12:12] (03CR) 10Legoktm: [C: 032] Add URL Redirect rules for URLShortener [vagrant] - 10https://gerrit.wikimedia.org/r/139651 (owner: 10Yuvipanda) [08:12:18] (03Merged) 10jenkins-bot: Add URL Redirect rules for URLShortener [vagrant] - 10https://gerrit.wikimedia.org/r/139651 (owner: 10Yuvipanda) [08:18:55] legoktm: ty! [08:18:57] I didn't know there were types :) [08:23:59] (03PS1) 10Yuvipanda: Move to WTFPL [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139667 [08:24:00] legoktm: ^ [08:37:27] (03PS1) 10Withoutaname: Refactor some code in RequestContext.php [core] - 10https://gerrit.wikimedia.org/r/139668 [08:43:04] legoktm: are you around ? [08:49:33] 3MediaWiki extensions / 3WikidataRepo: Exception from line 282 of EntityHandler.php - 10https://bugzilla.wikimedia.org/66632#c1 (10Aude) s:5normal>3critic it's a blocker [08:49:39] 3MediaWiki extensions / 3WikidataRepo: Exception from line 282 of EntityHandler.php - 10https://bugzilla.wikimedia.org/66632 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Exception from line 282 of /Library/WebServer/Documents/php-master/extensions/Wikibase/repo/includes/content/EntityHandler.ph... [09:01:41] (03PS1) 10Kunalgrover05: DB schema updates for SQLLite, Postgres, Oracle, MSSQl [core] - 10https://gerrit.wikimedia.org/r/139669 [09:02:52] (03CR) 10jenkins-bot: [V: 04-1] DB schema updates for SQLLite, Postgres, Oracle, MSSQl [core] - 10https://gerrit.wikimedia.org/r/139669 (owner: 10Kunalgrover05) [09:15:16] (03PS51) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [09:15:18] (03PS2) 10Kunalgrover05: DB schema updates for SQLLite, Postgres, Oracle, MSSQl [core] - 10https://gerrit.wikimedia.org/r/139669 [09:19:51] (03CR) 10Kunalgrover05: "Rebased this commit with master." [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [09:24:58] 3MediaWiki extensions / 3WikidataRepo: not possible to add no-value and some-value snaks in languages other than English - 10https://bugzilla.wikimedia.org/66626#c1 (10Thiemo Mättig) I do have the same problem in English. Result of my first debugging attempt: The event "afterchange" is registered in snakvie... [09:37:13] 3MediaWiki extensions / 3CentralAuth: Allow global renaming of global users - 10https://bugzilla.wikimedia.org/14862#c40 (10matanya) It is very nice this is going to be deployed. It would be even nicer if stewards were notified in advanced, and some feedback was shared. [09:46:20] (03PS1) 10Withoutaname: Refactor some code in EditPage.php [core] - 10https://gerrit.wikimedia.org/r/139670 [09:56:59] (03CR) 10Thiemo Mättig (WMDE): "Can you point your finger at the missing 10% please?" [core] - 10https://gerrit.wikimedia.org/r/139115 (owner: 10Thiemo Mättig (WMDE)) [09:58:01] 3MediaWiki extensions / 3WikidataRepo: not possible to change rank alone - 10https://bugzilla.wikimedia.org/66633 (10Lydia Pintscher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs When changing the rank of a statement only the save button does not get enabled. One has to also make a change to the value.... [09:58:28] 3MediaWiki extensions / 3WikidataRepo: not possible to change rank alone - 10https://bugzilla.wikimedia.org/66633 (10Lydia Pintscher) p:5Unprio>3High [09:58:41] 3MediaWiki extensions / 3WikidataRepo: not possible to change rank alone - 10https://bugzilla.wikimedia.org/66633 (10Lydia Pintscher) s:5normal>3major [10:00:43] 3MediaWiki extensions / 3WikidataRepo: Exception from line 282 of EntityHandler.php - 10https://bugzilla.wikimedia.org/66632 (10Lydia Pintscher) p:5Unprio>3Highes [10:04:21] (03PS2) 10Esanders: Remove core CSS override [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/139090 [10:06:45] 3MediaWiki extensions / 3Translate: Make all sections of page optionally translatable - 10https://bugzilla.wikimedia.org/66634 (10kunalgrover05) 3NEW p:3Unprio s:3enhanc a:3None Following bug 34098, it will be good if all the sections can be made optionally translatable. It will save a great amount o... [10:07:22] (03PS3) 10Esanders: Bring in VisualEditor support from VE extension [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/138911 [10:07:35] 3MediaWiki extensions / 3Translate: Make all sections of page optionally translatable - 10https://bugzilla.wikimedia.org/66634 (10kunalgrover05) [10:07:36] (03Abandoned) 10Esanders: Remove core CSS override [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/139090 (owner: 10Esanders) [10:07:36] 3MediaWiki extensions / 3Translate: Make the page title optionally translatable when using the Translate extension - 10https://bugzilla.wikimedia.org/34098 (10kunalgrover05) [10:08:59] (03PS1) 10Umherirrender: Migrate 'wgBreakFrames' from wikibits.js to own module [core] - 10https://gerrit.wikimedia.org/r/139672 [10:11:08] (03CR) 10Umherirrender: "Was added with r18220. Header support was added with r79561." [core] - 10https://gerrit.wikimedia.org/r/139672 (owner: 10Umherirrender) [10:11:56] 3MediaWiki / 3Skin and page rendering: Too small width of TOC in Firefox on Android - 10https://bugzilla.wikimedia.org/66314#c3 (10Daniel Jonsson) Apparently this issue has already been reported on Mozilla's issue tracker: Table layout is not displayed correctly on Wikipedia https://bugzilla.mozilla.org/... [10:12:55] (03CR) 10jenkins-bot: [V: 04-1] Migrate 'wgBreakFrames' from wikibits.js to own module [core] - 10https://gerrit.wikimedia.org/r/139672 (owner: 10Umherirrender) [10:15:17] (03PS2) 10Umherirrender: Migrate 'wgBreakFrames' from wikibits.js to own module [core] - 10https://gerrit.wikimedia.org/r/139672 [10:19:10] (03CR) 10jenkins-bot: [V: 04-1] Migrate 'wgBreakFrames' from wikibits.js to own module [core] - 10https://gerrit.wikimedia.org/r/139672 (owner: 10Umherirrender) [10:21:32] (03PS3) 10Umherirrender: Migrate 'wgBreakFrames' from wikibits.js to own module [core] - 10https://gerrit.wikimedia.org/r/139672 [10:28:43] (03CR) 10Umherirrender: "Patch Sets 2 and 3: Fixed copy and paste fails." [core] - 10https://gerrit.wikimedia.org/r/139672 (owner: 10Umherirrender) [10:30:28] (03CR) 10Martineznovo: [C: 031] "Are you waiting for someone else to review? ;) If so you may want to add more people to the list of reviewers" [extensions/BlockAndNuke] (REL1_23) - 10https://gerrit.wikimedia.org/r/139593 (owner: 10MarkAHershberger) [10:38:41] Krinkle: Heb je ff? Ik heb in de monumenten api nog wat berichten die ontbreken. Waar moet ik die toevoegen? [10:39:00] Zie http://tools.wmflabs.org/heritage/api/api.php?action=search&srcountry=nl&srlang=nl&srmunicipality=%Overveen%&format=html&limit=5 [10:41:49] multichill: Intuition? [10:41:56] yup [10:42:13] Staat waarschijnlijk nog wel ergens iets verkeerd. Is wat eerst op ~erfgoed op de Toolserver stond [10:43:19] (03CR) 10Krinkle: [C: 04-1] "This is a page specific context. This will change handling from being at the global level to being in a module *and* page specific level. " [core] - 10https://gerrit.wikimedia.org/r/139672 (owner: 10Umherirrender) [10:43:35] multichill: https://github.com/krinkle/intuition [10:43:54] https://github.com/Krinkle/intuition/wiki/Documentation#usage [10:44:49] Het staat allemaal al ingesteld Krinkle [10:44:58] Op Toolserver werkte het ook [10:45:08] Kijk maar in ~heritage/public_html/api [10:45:11] Kan je gewoon lezen [10:45:19] Wat is nu de vraag dan? [10:45:27] Waarom werkt het niet? [10:45:34] Niks of bepaalde berichten? [10:45:41] Hoe ziet de code er nu uit wat op labs draait? [10:45:51] Ik zie helemaal geen berichten [10:45:59] vanaf waar haal je Intuition/ToolStart.php? [10:46:08] en hoe instantieer je de Intuition class? [10:47:05] Krinkle: Kijk even in /data/project/heritage/public_html/api/api.php [10:47:31] ok [10:47:41] $tsI18nDir = '/data/project/intuition/src/Intuition'; [10:48:03] multichill: kun je 'suppressnotice' => false, even mee geven? [10:48:17] Sure, waar? [10:48:20] options [10:48:29] $opts = array( ? [10:48:42] item in array voor Intuition constructor [10:48:51] ook TsIntuition -> Intuition (nu nog alias, maar niet voor altijd) [10:49:59] Die 'suppressnotice' => false, staat nu in api.php [10:50:53] Krinkle: ^^ [10:51:00] multichill: OK [10:51:04] Waar word I18N gebruikt? [10:52:51] multichill: kun je in een tmp file phpinfo() doen? [10:53:02] Je gebruikt _() ipv $I18N [10:53:10] Krinkle: Als je in /data/project/heritage/public_html/api/includes kijkt FormatHtml.php [10:53:14] dit werkt alleen waneer je PHP installatie niet al een _() definieert [10:53:24] Wellicht dat Labs gettext compileerd, maar Toolserver niet [10:53:28] https://github.com/Krinkle/intuition/blob/master/includes/Functions.php#L25-L37 [10:53:40] Krinkle: Dit is hoe jij het ooit zelf hebt ingericht ;-) [10:53:52] Ik heb nooit _() aangeraden echter [10:54:39] als dat idd het geval is kun je beter $I18N direct gebruiken, of via context (e.g. als propery van Format class, zoals je in SearchPage() al doet) [10:54:45] Maakt me niet uit. Ik heb nu ". _('db-field-' . $name ) .", wat moet dat worden? [10:55:12] multichill: zet ff als dat het geval is, moet het dus $I18N->msg() worden ipv _() [10:55:57] of, zoals je in SearchPage al doet, pass $I18N als parameter naar je class and heb iets als $this->I18N->msg of $this->msg [10:58:18] Krinkle: http://tools.wmflabs.org/heritage/ [10:58:31] GetText Support: enabled [10:58:32] Yep [10:58:56] Dat betekend dat _() al gedefineerd is door PHP, en, itt javascript, er is geen wijze om een functie te herdefineren dus _() is al bezet. [10:59:19] Hmm, handig ja [10:59:26] _(), (gettext) gebruikt de i18n database van Linux, en fallback is weergeven van de key (geen error o.i.d.) [10:59:54] 'k heb daarom de boel meer OOP gemaakt met de Intuition msg interface [11:01:43] Krinkle: Hmm, http://tools.wmflabs.org/heritage/api/api.php?action=search&srcountry=nl&srlang=nl&srmunicipality=%Overveen%&format=html&limit=5 [11:01:56] $I18N is toch global? [11:03:42] Notice: Undefined variable: I18N in /data/project/heritage/heritage/api/includes/FormatHtml.php on line 58 Fatal error: Call to a member function msg() on a non-object in /data/project/heritage/heritage/api/includes/FormatHtml.php on line 58 [11:06:41] multichill: global $I18N; [11:07:01] heb je de variable geimporteert vanuit global in die functie? [11:07:13] is idd een global [11:07:32] maar je hebt 'em wel binnen een if-statement gedefineerd. [11:08:30] Krinkle: Ok. Hoe nu aan de praat krijgen? [11:08:41] 3MediaWiki extensions / 3CentralAuth: Allow global renaming of global users - 10https://bugzilla.wikimedia.org/14862#c41 (10Nemo) (In reply to matanya from comment #40) > It is very nice this is going to be deployed. It would be even nicer if > stewards were notified in advanced, and some feedback was shared... [11:08:48] multichill: Ik zie nergens I18N in dat bestand, heb je de edit weer ongedaan gemaakt? [11:09:06] msg('x'); [11:09:09] zou moeten werken [11:10:54] Ah, nu komt er meer uit [11:12:11] 3MediaWiki extensions / 3WikidataRepo: Exception from line 282 of EntityHandler.php - 10https://bugzilla.wikimedia.org/66632#c2 (10Thiemo Mättig) 5NEW>3PATC https://github.com/DataValues/Geo/pull/13 [11:12:30] Beetje ranzig, maar dat komt later wel Krinkle [11:12:37] idd [11:12:52] Heb zelf ook nog een tool of 12 te migreren. [11:13:18] Pff, kan niet geloven dat ik in de loop der jaren zo'n grote puinhoop accumulated heb. [11:13:44] Haha, ja, dat heb ik ook. Ik heb nog wel het voordeel dat ik van m'n eigen spul redelijk ok documentatie heb [11:14:09] Deze api heb ik nooit iets met de i18n en dat werk gedaan dus dan is het allemaal opnieuw uitzoeken [11:14:39] Moet je me alleen nog even verklappen waar ik berichten kan toevoegen Krinkle [11:14:48] pull request on github [11:15:13] en https://github.com/Krinkle/intuition/wiki/Documentation#debug-and-development [11:15:19] https://github.com/Krinkle/intuition/blob/master/language/messages/Monumentsapi.i18n.php is niet op Gerrit beschikbaar? [11:15:25] om ze eerst local toe te voegen (om te testen en zodat je niet op mij hoeft te wachten) [11:15:47] Nee, is geen wikimedia project, en heb liever github zodat ik een fatsoenlijk en simpel test systeem heb met Travis. [11:18:36] Dank je voor de hulp. Ik ben nu vooral aan het oplappen, ik moet nog een goede dev instantie opzetten zodat ik gewoon in de code kan roeren zonder productie onderuit te trekken [11:20:41] 3MediaWiki extensions / 3Translate: Make all sections of page optionally translatable - 10https://bugzilla.wikimedia.org/66634#c1 (10Eduard Braun) What's the use case for this? If one really doesn't want a specific part of the page translated, one can just place the tags accordingly. Wouldn't t... [11:22:00] Krinkle: http://tools.wmflabs.org/heritage/api/api.php?action=search&srcountry=nl&srlang=nl&srmunicipality=%Overveen%&format=htmllist&limit=5 ziet er nu ook weer wat leesbaarder uit [12:02:59] 3MediaWiki extensions / 3WikidataRepo: Uncaught exception DataValues\IllegalValueException - 10https://bugzilla.wikimedia.org/66636 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs I am processing a wikidata dump with the new internal (de)serializers. It failed to deserialize https://www.wikidata.... [12:08:14] 3MediaWiki / 3Parser: Make it possible to distinguish Wikitext headings and HTML headings - 10https://bugzilla.wikimedia.org/66637 (10Eduard Braun) 3UNCO p:3Unprio s:3minor a:3None Right now the HTML created for - headings specified using Wikitext (e.g. "==") - headings created using HTML tags (e.g.... [12:10:09] (03CR) 10Krinkle: "Bit boring, but we should do something about the license header. Maybe just turn it into a url to the blob on git.wikimedia.org. Or add a " [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/138911 (owner: 10Esanders) [12:16:25] (03CR) 10devunt: [C: 031] Refactor some code in RequestContext.php [core] - 10https://gerrit.wikimedia.org/r/139668 (owner: 10Withoutaname) [12:20:41] https://code.google.com/p/chromium/issues/detail?id=384827 [12:21:41] 3MediaWiki extensions / 3WikidataRepo: Uncaught exception DataValues\IllegalValueException - 10https://bugzilla.wikimedia.org/66636#c1 (10Aude) https://www.wikidata.org/wiki/Q5110134 when using new internal deserializers, I get: Fatal error: Uncaught exception 'DataValues\IllegalValueException' with messag... [12:27:12] (03PS5) 10Vogone: Split "suppressrevision" into two user rights [core] - 10https://gerrit.wikimedia.org/r/139277 (https://bugzilla.wikimedia.org/20476) [12:27:48] (03CR) 10TheDJ: Add support for request account link (031 comment) [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/134624 (owner: 10Paladox) [12:33:16] (03PS3) 10Bartosz Dziewoński: mediawiki.mixins: Add border-radius function [core] - 10https://gerrit.wikimedia.org/r/134964 (owner: 10Robmoen) [12:33:54] (03CR) 10Bartosz Dziewoński: [C: 031] "Rebased, tweaked the commit message." [core] - 10https://gerrit.wikimedia.org/r/134964 (owner: 10Robmoen) [12:39:43] (03CR) 10Vogone: [C: 04-1] "The problem which Ajraddatz mentioned still exists." [core] - 10https://gerrit.wikimedia.org/r/139277 (https://bugzilla.wikimedia.org/20476) (owner: 10Vogone) [13:01:09] (03PS1) 10ImPacific: fix bug 63806 (svg external image placed) [core] - 10https://gerrit.wikimedia.org/r/139680 [13:12:26] 3MediaWiki extensions / 3WikidataRepo: Exception from line 282 of EntityHandler.php - 10https://bugzilla.wikimedia.org/66632#c3 (10Jeroen De Dauw) Looks like I missed this piece of behaviour when reimplementing the deserialization code in WikibaseInternalSerialization. [13:19:56] 3MediaWiki extensions / 3WikidataRepo: Exception from line 282 of EntityHandler.php - 10https://bugzilla.wikimedia.org/66632#c4 (10Jeroen De Dauw) Apparently we have no tests for this in Wikibase... [13:33:56] 3MediaWiki extensions / 3WikidataRepo: Exception from line 282 of EntityHandler.php - 10https://bugzilla.wikimedia.org/66632#c5 (10Jeroen De Dauw) Should be fixed by https://github.com/wmde/WikibaseInternalSerialization/pull/30 Though I suspect the same oversight will have been made in DataModel Serializati... [13:44:24] (03CR) 10Ysangkok: "Anomie asked:" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/113759 (https://bugzilla.wikimedia.org/64460) (owner: 10Ysangkok) [13:47:11] (03PS4) 10Umherirrender: Migrate 'wgBreakFrames' from wikibits.js to own module [core] - 10https://gerrit.wikimedia.org/r/139672 [13:47:54] (03CR) 10Umherirrender: "Patch Set 4: Restore old wikibits.js code and use mw.config.exists to find the old cached pages." [core] - 10https://gerrit.wikimedia.org/r/139672 (owner: 10Umherirrender) [13:48:13] 3MediaWiki extensions / 3Translate: Make all sections of page optionally translatable - 10https://bugzilla.wikimedia.org/66634#c2 (10kunalgrover05) Was just thinking wouldn't it nicer to have a checkbox for each section to select what sections a user wants to translate? I agree that it isn't a new feature,... [13:54:14] 3MediaWiki extensions / 3OATHAuth: OAuth should be autoblock-exempt / "IP address had been blocked automatically" in croptool - 10https://bugzilla.wikimedia.org/66639 (10Merlijn van Deen) 3NEW p:3Unprio s:3normal a:3Ryan Lane On #wikimedia-labs, we got a report of someone getting Upload failed!... [13:54:28] 3MediaWiki extensions / 3OAuth: OAuth should be autoblock-exempt / "IP address had been blocked automatically" in croptool - 10https://bugzilla.wikimedia.org/66639 (10Merlijn van Deen) a:5Ryan Lane>3None [13:55:57] 3MediaWiki extensions / 3WikidataRepo: Exception from line 282 of EntityHandler.php - 10https://bugzilla.wikimedia.org/66632#c6 (10Jeroen De Dauw) Indeed. Now also fixed with https://github.com/wmde/WikibaseDataModelSerialization/pull/66 [14:25:28] 3Wikimedia / 3General/Unknown: Video scalers don't seem to be scaling videos anymore - 10https://bugzilla.wikimedia.org/66627#c2 (10matanya) 5NEW>3RESO/FIX Thanks to sam, Giuseppe and Filippo, the issue was resolved. see https://gerrit.wikimedia.org/r/139682 [14:28:56] 3MediaWiki extensions / 3WikidataRepo: do not link deleted items - show text note instead - 10https://bugzilla.wikimedia.org/65002#c3 (10Marius Hoch) 5PATC>3RESO/FIX Resolved for items only [14:31:21] (03PS2) 10ImPacific: bug fix 63806 (svg external image placed) [core] - 10https://gerrit.wikimedia.org/r/139680 [14:53:05] (03PS4) 10TheDJ: Edit warning should get value from editors [core] - 10https://gerrit.wikimedia.org/r/121558 (https://bugzilla.wikimedia.org/61117) [15:10:08] MatmaRex: Could you have a look at https://gerrit.wikimedia.org/r/#/c/139268/ ? (Fix "CSSMin url() value remapping not working in certain obscure cases") [15:17:30] (03CR) 10Parent5446: [C: 04-1] Refactor some code in RequestContext.php (033 comments) [core] - 10https://gerrit.wikimedia.org/r/139668 (owner: 10Withoutaname) [15:21:40] (03CR) 10Hoo man: [C: 04-1] "Also needs a manual rebase." (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (https://bugzilla.wikimedia.org/14862) (owner: 10Legoktm) [15:23:47] FoxT: not today, sorry :( [15:23:57] legoktm: you here? [15:23:59] MatmaRex: ok, np [15:39:37] (03CR) 10Paladox: Add support for request account link (031 comment) [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/134624 (owner: 10Paladox) [15:55:49] (03PS6) 10Vogone: Split "suppressrevision" into two user rights [core] - 10https://gerrit.wikimedia.org/r/139277 (https://bugzilla.wikimedia.org/20476) [16:00:50] (03PS1) 10Paladox: Update jQuery.cookie.js [core] - 10https://gerrit.wikimedia.org/r/139686 [16:02:00] (03CR) 10Paladox: [C: 031] Update jQuery.cookie.js [core] - 10https://gerrit.wikimedia.org/r/139686 (owner: 10Paladox) [16:04:15] (03PS7) 10Vogone: Split "suppressrevision" into two user rights [core] - 10https://gerrit.wikimedia.org/r/139277 (https://bugzilla.wikimedia.org/20476) [16:09:56] (03CR) 10Vogone: [C: 04-1] Split "suppressrevision" into two user rights [core] - 10https://gerrit.wikimedia.org/r/139277 (https://bugzilla.wikimedia.org/20476) (owner: 10Vogone) [16:18:31] (03PS1) 10Paladox: Update jquery.hoverintent.js [core] - 10https://gerrit.wikimedia.org/r/139687 [16:20:00] (03CR) 10Paladox: [C: 031] Update jquery.hoverintent.js [core] - 10https://gerrit.wikimedia.org/r/139687 (owner: 10Paladox) [16:24:11] 3MediaWiki / 3Parser: Make it possible to distinguish Wikitext headings and HTML headings - 10https://bugzilla.wikimedia.org/66637 (10Andre Klapper) p:5Unprio>3Low s:5minor>3enhanc [16:26:12] 3MediaWiki extensions / 3CentralAuth: Spezial:GlobalGroupPermissions/nonexistentgroup should show an error in read only mode - 10https://bugzilla.wikimedia.org/40119 (10Andre Klapper) a:3PiRSquared17 [16:27:14] (03PS5) 10TheDJ: Edit warning should get value from editors [core] - 10https://gerrit.wikimedia.org/r/121558 (https://bugzilla.wikimedia.org/61117) [16:27:46] (03PS1) 10Paladox: Update jquery.form.js [core] - 10https://gerrit.wikimedia.org/r/139688 [16:27:48] (03Abandoned) 10TheDJ: [Do not merge] Support warning for unsaved changes [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/121559 (https://bugzilla.wikimedia.org/61117) (owner: 10TheDJ) [16:29:03] (03CR) 10Paladox: [C: 031] Update jquery.form.js [core] - 10https://gerrit.wikimedia.org/r/139688 (owner: 10Paladox) [16:32:02] (03PS5) 10Paladox: Update jQuery.appear.js [core] - 10https://gerrit.wikimedia.org/r/139470 [16:35:02] (03PS6) 10Paladox: Update jQuery.appear.js [core] - 10https://gerrit.wikimedia.org/r/139470 [16:40:38] 3MediaWiki / 3Maintenance scripts: deleteOldRevisions.php delete content date - 10https://bugzilla.wikimedia.org/66615#c3 (10Andre Klapper) Is there any pattern? Both examples above seem to be page moves / redirects? On a probably very unrelated note, Firefox browser console lists several errors on the lin... [16:40:47] (03CR) 10Paladox: [C: 031] Update jQuery.appear.js [core] - 10https://gerrit.wikimedia.org/r/139470 (owner: 10Paladox) [16:40:54] 3MediaWiki extensions / 3OpenID: OpenID prevents wiki update when running on an sqlite database - 10https://bugzilla.wikimedia.org/66605 (10Andre Klapper) [16:40:55] 3MediaWiki / 3Database: SQLite support (tracking) - 10https://bugzilla.wikimedia.org/20257 (10Andre Klapper) [16:54:28] (03PS1) 10Paladox: Update jquery.jStorage.js [core] - 10https://gerrit.wikimedia.org/r/139689 [16:55:18] (03CR) 10Paladox: [C: 031] Update jquery.jStorage.js [core] - 10https://gerrit.wikimedia.org/r/139689 (owner: 10Paladox) [16:59:39] (03PS1) 10TheDJ: textSelection: Remove references to iframe [core] - 10https://gerrit.wikimedia.org/r/139690 (https://bugzilla.wikimedia.org/29328) [17:00:48] (03PS2) 10TheDJ: textSelection: Remove references to iframe [core] - 10https://gerrit.wikimedia.org/r/139690 (https://bugzilla.wikimedia.org/29328) [17:33:13] (03PS1) 10Paladox: Update jquery.mockjax.js [core] - 10https://gerrit.wikimedia.org/r/139693 [17:33:57] (03CR) 10Paladox: [C: 031] Update jquery.mockjax.js [core] - 10https://gerrit.wikimedia.org/r/139693 (owner: 10Paladox) [17:36:55] 3MediaWiki extensions / 3Translate: Special page for migration of legacy translation pages (tracking) - 10https://bugzilla.wikimedia.org/65740 (10Pratik Lahoti) [17:36:57] 3MediaWiki extensions / 3Translate: [PagePreparation] Internal links to sections on same page should link to language-independent anchor - 10https://bugzilla.wikimedia.org/66640 (10Pratik Lahoti) 3NEW p:3Unprio s:3normal a:3Pratik Lahoti The page preparation tool developed under GSoC needs to handle... [17:37:11] (03PS1) 10Raimond Spekking: Delete sr.json, it blocks messages from sr-ec [core] - 10https://gerrit.wikimedia.org/r/139694 [17:37:39] 3MediaWiki extensions / 3Translate: Special page for migration of legacy translation pages (tracking) - 10https://bugzilla.wikimedia.org/65740 (10Pratik Lahoti) [17:37:39] 3MediaWiki extensions / 3Translate: [PagePreparation] Internal links to sections on same page should link to language-independent anchor - 10https://bugzilla.wikimedia.org/66640 (10Pratik Lahoti) [17:38:24] (03CR) 10Raimond Spekking: "Translations for 'sr' already deleted on translatewiki.net" [core] - 10https://gerrit.wikimedia.org/r/139694 (owner: 10Raimond Spekking) [17:40:48] (03PS2) 10Bartosz Dziewoński: Delete sr.json, it blocks messages from sr-ec [core] - 10https://gerrit.wikimedia.org/r/139694 (owner: 10Raimond Spekking) [17:55:53] (03PS1) 10Rohan013: Removes Check for URL validity from UploadFromUrl::IsValidRequest so that a error can be thrown later and displayed to the user [core] - 10https://gerrit.wikimedia.org/r/139696 [18:05:16] (03PS2) 10Rohan013: Bug:32361 Removes Check for URL validity from UploadFromUrl::IsValidRequest so that a error can be thrown later and displayed to the user [core] - 10https://gerrit.wikimedia.org/r/139696 [18:06:42] (03PS1) 10Paladox: Update jquery.validate.js [core] - 10https://gerrit.wikimedia.org/r/139697 [18:07:20] (03CR) 10Paladox: [C: 031] Update jquery.validate.js [core] - 10https://gerrit.wikimedia.org/r/139697 (owner: 10Paladox) [18:08:20] (03PS2) 10Paladox: Update jQuery.cookie.js [core] - 10https://gerrit.wikimedia.org/r/139686 [18:09:00] (03PS3) 10Paladox: Update jquery.cookie.js [core] - 10https://gerrit.wikimedia.org/r/139686 [18:10:27] 3Wikimedia / 3Mailing lists: Humanities mailing list - 10https://bugzilla.wikimedia.org/66641 (10Alex) 3NEW p:3Unprio s:3enhanc a:3None For discussion of humanities-based outreach in the community, will expand into larger group: have 4 on-wiki people (see sign up and description at https://en.wikiped... [18:13:23] 3Wikimedia / 3Mailing lists: Humanities mailing list - 10https://bugzilla.wikimedia.org/66641#c1 (10Alex) Requested name "humanities" [18:14:40] 3Wikimedia / 3Mailing lists: Wikipedia Library Mailing List - 10https://bugzilla.wikimedia.org/66642 (10Alex) 3NEW p:3Unprio s:3enhanc a:3None The Wikipedia Library (https://en.wikipedia.org/wiki/Wikipedia:The_Wikipedia_Library) is expanding into multiple languages, and is needing more and more coord... [18:21:29] (03CR) 10Parent5446: [C: 04-1] Refactor some code in EditPage.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/139670 (owner: 10Withoutaname) [18:28:52] (03CR) 10Huji: "I am going to need some advice on how to do that." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/139105 (https://bugzilla.wikimedia.org/20892) (owner: 10Huji) [18:30:10] (03CR) 10Hoo man: "use git commit --amend to amend an existing commit, instead of creating a new one." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/139105 (https://bugzilla.wikimedia.org/20892) (owner: 10Huji) [18:40:17] (03PS2) 10Foxtrott: Unit testing for components (DO NOT MERGE) [skins/chameleon] - 10https://gerrit.wikimedia.org/r/134556 [18:44:57] (03PS8) 10Vogone: Split "suppressrevision" into two user rights [core] - 10https://gerrit.wikimedia.org/r/139277 (https://bugzilla.wikimedia.org/20476) [18:53:54] 3MediaWiki extensions / 3WikidataRepo: PropertyInfoTableBuilderTest::testRebuildPropertyInfo failing - 10https://bugzilla.wikimedia.org/66405 (10Marius Hoch) 5PATC>3RESO/FIX [18:56:09] 3MediaWiki extensions / 3WikidataRepo: PropertyInfoTableBuilderTest::testRebuildPropertyInfo failing - 10https://bugzilla.wikimedia.org/66405 (10John F. Lewis) p:5Unprio>3Normal [18:56:38] (03PS1) 10Paladox: Update moment folder and files [core] - 10https://gerrit.wikimedia.org/r/139698 [18:56:39] 3MediaWiki extensions / 3WikidataRepo: Notice: Expansion of termbox failed: No such revision found for Q116: 1499 - 10https://bugzilla.wikimedia.org/66346 (10John F. Lewis) p:5Unprio>3Normal [18:57:05] (03PS2) 10Paladox: Update moment folder and files [core] - 10https://gerrit.wikimedia.org/r/139698 [18:57:29] (03CR) 10Paladox: [C: 031] Update moment folder and files [core] - 10https://gerrit.wikimedia.org/r/139698 (owner: 10Paladox) [18:57:53] 3MediaWiki extensions / 3WikidataRepo: Uncaught exception DataValues\IllegalValueException - 10https://bugzilla.wikimedia.org/66636 (10John F. Lewis) p:5Unprio>3Normal [18:58:08] 3MediaWiki extensions / 3WikidataRepo: Make EntityViewFactory - 10https://bugzilla.wikimedia.org/66486 (10John F. Lewis) p:5Unprio>3Normal [19:00:54] 3Wikimedia / 3Mailing lists: Humanities mailing list - 10https://bugzilla.wikimedia.org/66641#c2 (10Tomasz W. Kozlowski) p:5Unprio>3Normal I seriously doubt whether a mailing list is required for a group that consists of four people. In any case, before I can do anything, I require the following inform... [19:00:54] 3Wikimedia / 3Mailing lists: Wikipedia Library Mailing List - 10https://bugzilla.wikimedia.org/66642#c1 (10Tomasz W. Kozlowski) p:5Unprio>3Normal Before I create the list for you, I require the following information: 1. Who is supposed to be the list administrator? Please provide at least two... [19:06:09] 3MediaWiki extensions / 3WikidataRepo: basic support for Wikimedia Commons (MediaInfo entity type) - 10https://bugzilla.wikimedia.org/64288 (10John F. Lewis) [19:11:04] (03PS2) 10Huji: AbuseFilter: Add ability to detect deleted revisions [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/139103 (https://bugzilla.wikimedia.org/20892) [19:11:20] (03PS1) 10Paladox: Update jquery.chosen folder and files [core] - 10https://gerrit.wikimedia.org/r/139699 [19:11:55] (03Abandoned) 10Huji: AbuseFilter: Add ability to detect deleted revisions [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/139105 (https://bugzilla.wikimedia.org/20892) (owner: 10Huji) [19:12:09] (03CR) 10Paladox: [C: 031] Update jquery.chosen folder and files [core] - 10https://gerrit.wikimedia.org/r/139699 (owner: 10Paladox) [19:12:54] (03PS1) 10Jack Phoenix: Removed duplicate loading of bottom scripts. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/139700 [19:13:35] (03CR) 10Jack Phoenix: [C: 032 V: 032] Removed duplicate loading of bottom scripts. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/139700 (owner: 10Jack Phoenix) [19:13:38] 3MediaWiki extensions / 3AbuseFilter: Add ability to detect deleted revisions and page creation - 10https://bugzilla.wikimedia.org/20892#c8 (10Huji) I marked 139105 is abandoned because I finally figured out how to merge it back into https://gerrit.wikimedia.org/r/139103 (please check new patchset there) [19:16:15] (03PS3) 10TheDJ: Upload: Display an error to the user on invalid wpUploadFileURL [core] - 10https://gerrit.wikimedia.org/r/139696 (https://bugzilla.wikimedia.org/32361) (owner: 10Rohan013) [19:17:53] 3MediaWiki / 3Parser: thead, tbody, tfoot for wikitable syntax - 10https://bugzilla.wikimedia.org/4740#c26 (10Gabriel Wicke) (In reply to Andy Mabbett from comment #24) > Gabriel: The use case is out lined in Michael Zajac's initial post > (timestamp: 2006-01-24 02:41:52); and in comments 4 & 11. Do you ha... [19:18:55] 3MediaWiki extensions / 3Translate: Search returns same result multiple times - 10https://bugzilla.wikimedia.org/49295#c4 (10Nemo) *** Bug 66584 has been marked as a duplicate of this bug. *** [19:18:55] 3MediaWiki extensions / 3Translate: [[Special:Translate]] shows each message twice - 10https://bugzilla.wikimedia.org/66584#c1 (10Nemo) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 49295 *** [19:21:49] (03CR) 10TheDJ: "https://doc.wikimedia.org/mediawiki-core/master/php/html/classTitle.html#a38bc903dc6eb281b38a66029d7d62eb2" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [19:32:38] 3MediaWiki extensions / 3CirrusSearch: Better Special:Random - 10https://bugzilla.wikimedia.org/65366#c5 (10Derk-Jan Hartman) "Hi. I was using the Special:Random/File tool for a long time on rowiki, in order to fish for unfree images and candidates for Commons. Last days when I accessed the tool, it returned... [19:37:38] (03CR) 10Rillke: "If you implement it in JavaScript, I'd be happy to use it here and now." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [19:37:55] (03CR) 10Rillke: "https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Title" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [19:40:55] 3MediaWiki extensions / 3CirrusSearch: Special:Random/File finds results from commons - 10https://bugzilla.wikimedia.org/66643 (10Nik Everett) 3NEW p:3Unprio s:3normal a:3None See https://bugzilla.wikimedia.org/show_bug.cgi?id=65366#c5 "Hi. I was using the Special:Random/File tool for a long time on... [19:44:25] 3MediaWiki extensions / 3CirrusSearch: Special:Random/File finds results from commons - 10https://bugzilla.wikimedia.org/66643#c1 (10Nik Everett) I'm pretty sure this is something we did when we implemented Special:Random using Cirrus. Cirrus likes to include commons results in searches so I'm pretty sure w... [19:46:02] (03PS2) 10Withoutaname: Refactor some code in RequestContext.php [core] - 10https://gerrit.wikimedia.org/r/139668 [19:47:37] thedj, really like the idea having .makeTitleSafe() in JS [19:47:57] would you code-review a possible implementation ? [19:52:25] rillke: actually, i was just looking again, and i'm wondering why mw.Title isn't safe to begin with... [19:52:34] from the description it seems like it should [19:54:02] rillke: what input string causes this problem ? [19:55:07] new mw.Title('Commons:Foo', 6).getPrefixedText(); [19:55:17] << "Commons:Foo" [19:55:50] But it should be of course always File:..... [19:55:56] ah, so it's because the input value already matches a namespace ? [19:56:04] yes [19:57:15] aside from that, it's currently creating the title in the main namespace if the user does not explicitly input File:.... [19:57:43] so .... it is checking for protection and existing files at the wrong place [19:58:07] and asking the titleblacklist for the wrong title etc. [19:58:37] hmm. [19:58:38] 3MediaWiki extensions / 3CirrusSearch: Better Special:Random - 10https://bugzilla.wikimedia.org/65366#c6 (10Sam Reed (reedy)) (In reply to Derk-Jan Hartman from comment #5) > "Hi. I was using the Special:Random/File tool for a long time on rowiki, in > order to fish for unfree images and candidates for Commo... [20:05:05] rillke: yeah i think this might make the case for makeTitle indeed... [20:06:24] thedj, it's not the first time we are forcing a namespace [20:07:26] https://github.com/wikimedia/mediawiki-core/blob/master/resources/src/mediawiki/mediawiki.Title.js#L334 [20:08:14] https://gerrit.wikimedia.org/r/#/c/131971/8/resources/src/mediawiki/mediawiki.Title.js l.622 [20:08:57] but here we cannot simply prepend File: because users could end up with duplicate namespaces [20:09:15] something like Datei:File:Foo.jpg [20:09:33] (if used on :de:) [20:12:29] rillke: well you can't endlessly protect against input errors of course. I'm not sure if PHP's makeTitle handles that. [20:13:29] thedj, true but I think it's not too uncommon entering File:Foo into the title field if you are used with MW [20:13:50] and then it's annoying if your file ends up at File:File:Foo.jpg [20:14:43] (03CR) 10Hoo man: [C: 04-1] "Still -1 per PS1 (especially the query is worrisome and probably unfixable)." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/139103 (https://bugzilla.wikimedia.org/20892) (owner: 10Huji) [20:14:47] * Nemo_bis did that several times [20:15:00] well then you can only double up. first do newFromText, then check namespace and then make a new title using just the textpart, with using a default File namespace. [20:15:56] if t->getNamespace !== file then t2 = newFromText( t.getNameText(), fileId ) [20:18:09] Please add this as a comment to https://gerrit.wikimedia.org/r/#/c/139592/1/resources/mw.UploadWizardDetails.js [20:19:01] I am not sure whether it is right to just remove a prefix matching a namespece ... and there could be more than one [20:19:31] hoo: would it be (more) practical to have counts of live and deleted revisions available to the abusefilter, rather than looking at the deletion log? [20:20:10] jackmcbarn: More practical from which point of view? Like from the database performance point of view or from the filter user point of view [20:20:11] ? [20:20:16] hoo: database performance [20:20:28] No [20:20:34] Totally not [20:20:37] rillke: actually it should be if newFromText( originalText, nsFileId ), t->getNamespace !== file then t2 = makeText( originalText, fileId ) [20:20:46] do you know of any good way to tell whether an article is being created and/or was deleted from the filter then? [20:20:57] hoo: hi [20:20:58] matanya: am now [20:21:20] hello legoktm did you finish testing the global rename ? [20:21:23] hi legoktm. About global rename... you aren't going to add tests to that on your own, right? [20:21:32] unit/ integration tests, I mean [20:22:06] jackmcbarn: Not really, no... you could check the RC table maybe, but that only covers about 31 days [20:22:24] hoo: no, but they would be nice to have [20:22:30] thedj, with the makeText to be implemented [20:22:34] matanya: yes :) [20:22:37] ... implemented in JS [20:23:14] (03CR) 10TheDJ: Create title in file NS and validate as such (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) (owner: 10Rillke) [20:23:16] legoktm: can i test it in beta ? (i guess no one there with the right) [20:23:19] legoktm: It will need some refactoring to get there, but I think we should do it [20:23:19] rillke: exactly [20:23:58] how do you normally write unit tests [20:24:17] matanya: no, it hasn't been merged yet, so it's not on the beta cluster yet [20:24:32] hoo: do you mean before we deploy it? [20:24:38] i missed the "when it would be merged" [20:24:52] legoktm: Yeah. [20:24:55] Of course [20:25:01] I'd rather not... :/ [20:25:11] The current state might work, but it's ugly [20:25:27] also it logs to renameuser logs, whihc it totally shouldn't [20:25:34] -1ed that [20:27:05] isnt centralauth wmf-specific? shouldnt you make it more generalizable to wiki farms [20:27:38] 3MediaWiki extensions / 3WikidataRepo: basic support for Wikimedia Commons (MediaInfo entity type) - 10https://bugzilla.wikimedia.org/64288 (10Steinsplitter) [20:27:39] right, I was going to fix that after I finished reading my scrollback [20:27:40] Withoutaname: It's not wmf-specific [20:27:47] Withoutaname: no, we want to kill CentralAuth. [20:28:08] legoktm: I'd recommend delaying the deploy for another week [20:28:28] Tuesday would be premature [20:28:56] mmm, I think that's Deskana|Away's call [20:29:03] (03CR) 10Legoktm: [C: 032 V: 032] Move to WTFPL [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139667 (owner: 10Yuvipanda) [20:29:13] [13:25] hoo also it logs to renameuser logs, whihc it totally shouldn't <- actually maybe make one global account log and lots of local rename logs [20:29:41] Withoutaname: That's what I think we'll do [20:29:41] (03CR) 10Legoktm: [C: 04-1] "At the very least, this needs release notes about the functions you removed. The commit messages should also explain what specifically cha" [core] - 10https://gerrit.wikimedia.org/r/139668 (owner: 10Withoutaname) [20:34:59] (03CR) 10TheDJ: "Are all these !importants really needed ?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/139120 (owner: 10Frédéric Wang) [20:41:48] (03CR) 10TheDJ: "gah, of course the dpaste expired yesterday...." [core] - 10https://gerrit.wikimedia.org/r/132232 (owner: 10Bartosz Dziewoński) [20:43:35] (03PS42) 10Legoktm: Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (https://bugzilla.wikimedia.org/14862) [20:43:53] (03CR) 10Legoktm: [C: 04-1] "Just rebased it." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (https://bugzilla.wikimedia.org/14862) (owner: 10Legoktm) [20:52:50] (03PS3) 10Withoutaname: Refactor some code in RequestContext.php [core] - 10https://gerrit.wikimedia.org/r/139668 [20:53:55] legoktm: added release notes [20:54:59] legoktm: should I do the same for https://gerrit.wikimedia.org/r/#/c/139612/ [20:59:41] 3MediaWiki / 3Maintenance scripts: runJobs.php stop working? - 10https://bugzilla.wikimedia.org/66644 (10zoglun) 3NEW p:3Unprio s:3minor a:3None I am running MW 1.23.0 on centos with following environment: PHP 5.4.27 (fpm-fcgi) MySQL 5.6.17. User report the wiki stop from update template. Then... [21:00:51] is it possible for me to modify the new wikipedia android app to use on my own wiki? [21:03:50] (03CR) 10Frédéric Wang: "Yes they are needed, see my comment above. This is because of the attributes style="display: none" attached to the elements in the PHP cod" [extensions/Math] - 10https://gerrit.wikimedia.org/r/139120 (owner: 10Frédéric Wang) [21:05:33] afaik as long as it doesnt pretend to be us sure [21:06:04] Withoutaname: yes [21:06:09] your commit message still needs work [21:06:16] er wait [21:06:16] nvm [21:06:23] I didn't click [21:06:24] :P [21:06:33] still yes to the release notes [21:07:30] (03CR) 10Frédéric Wang: "(so this would essentially be patch version 3 with some additional ":root * >" to increase priority and thus remove the !important rules)" [extensions/Math] - 10https://gerrit.wikimedia.org/r/139120 (owner: 10Frédéric Wang) [21:09:18] legoktm: well if i do it now and the other patch goes through, it'd be a nightmare to rebase against [21:09:30] you can use MatmaRex's tool [21:09:46] https://github.com/MatmaRex/mediawikireleasenotes-driver [21:09:50] * MatmaRex appears [21:12:06] (03CR) 10TheDJ: "We shouldn't use inline styling if we can avoid it. (Exactly because we want to avoid having to use !important)" [extensions/Math] - 10https://gerrit.wikimedia.org/r/139120 (owner: 10Frédéric Wang) [21:12:13] Withoutaname: ok cool! [21:12:29] one thing i was trying to figure out [21:12:48] is the new app that was released for android based on phone gap? [21:18:54] 3MediaWiki / 3History/Diffs: Slow js on history pages - 10https://bugzilla.wikimedia.org/51561#c17 (10Derk-Jan Hartman) OK, I think performance has significantly improved with this change. On a side note, Hovercards is performing terribly atm... Taking up 45% of the time on a complex page load. [21:19:04] (03PS3) 10Foxtrott: Unit testing for components (DO NOT MERGE) [skins/chameleon] - 10https://gerrit.wikimedia.org/r/134556 [21:21:08] 3Wikimedia / 3Git/Gerrit: lucene support makes git.wikimedia.org slow - 10https://bugzilla.wikimedia.org/49229#c6 (10Andre Klapper) (In reply to Chad H. from comment #3) > I had to turn the lucene indexing off for the time being until I can figure > out why it sucks so much. Chad / Nik: I assume Lucene inde... [21:22:47] (03CR) 10TheDJ: "BTW, hovercards is performing terribly right now." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/134266 (owner: 10TheDJ) [21:23:05] (03PS43) 10Legoktm: Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (https://bugzilla.wikimedia.org/14862) [21:23:07] (03CR) 10jenkins-bot: [V: 04-1] Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (https://bugzilla.wikimedia.org/14862) (owner: 10Legoktm) [21:23:35] wtf jenkins [21:23:48] it's right on top of master. [21:23:54] 3MediaWiki extensions / 3SemanticSignup: ConfirmEdit (Captcha) not supported - 10https://bugzilla.wikimedia.org/30629#c2 (10Andre Klapper) Also brought up at https://www.mediawiki.org/wiki/Extension_talk:Semantic_Forms/Archive_November_to_December_2012#ConfirmEdit_integration [21:24:48] (03PS44) 10Legoktm: Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (https://bugzilla.wikimedia.org/14862) [21:25:02] hoo: ^ [21:25:22] (03CR) 10Legoktm: "Changed log type to gblrename/rename and added some i18n messages for it." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (https://bugzilla.wikimedia.org/14862) (owner: 10Legoktm) [21:26:02] legoktm: Better now, will have a complete look later on. Maybe I'll also check it out and do some refactors [21:26:14] ok, thanks [21:26:55] 3MediaWiki extensions / 3BookManager: Fatal error: Call to a member function getVal() on a non-object - 10https://bugzilla.wikimedia.org/30583#c3 (10Andre Klapper) Raylton: Does anybody plan to investigate this problem, or is this not high priority, realistically speaking? [21:26:55] 3MediaWiki extensions / 3BookManager: Fatal error: Call to a member function isListed() on a non-object in /var/www/mediawiki/includes/SpecialPageFactory.php - 10https://bugzilla.wikimedia.org/30991#c1 (10Andre Klapper) Raylton: Does anybody plan to investigate this problem, or is this not high priority, rea... [21:27:55] where's Anomie? [21:28:44] ysangkok: he only tends to be around during the workday now [21:29:03] ok [21:29:47] (03CR) 10TheDJ: "I guess or perhaps by using additional classes if it's really needed." [extensions/Math] - 10https://gerrit.wikimedia.org/r/139120 (owner: 10Frédéric Wang) [21:31:53] 3Wikimedia / 3Shop: shop switches HTTPS -> HTTP when showing login prompt (on clicking checkout) - 10https://bugzilla.wikimedia.org/61528#c4 (10Andre Klapper) Hi Caitlin, any news/progress here, as this ticket was called the "main focus" in bug 37790 three months ago? [21:33:40] legoktm: why not reuse https://meta.wikimedia.org/wiki/Special:Log/globalauth instead of creating a new logtype [21:34:08] that's about status changes [21:34:16] renaming is entirely different imo. [21:36:25] change to SUL status right? local rename logs might be sufficient [21:36:38] have the steward be acting bureaucrat [21:36:41] there's no change to status, just the name [21:36:48] and we're not going to insert local logs on every wiki. [21:49:56] 3Analytics / 3General/Unknown: cp301[34] traffic not in country data for wikipedia zero - 10https://bugzilla.wikimedia.org/66645 (10christian) 3NEW p:3Unprio s:3normal a:3None cp301[34] started to receive traffic 2014-06-12 on 12:00 and 13:00 UTC, but traffic from those caches is not considered in wi... [21:52:41] 3Analytics / 3General/Unknown: cp301[34] traffic not in country data for wikipedia zero - 10https://bugzilla.wikimedia.org/66645#c1 (10christian) 5NEW>3RESO/FIX a:3christian Updated filtering scripts, rerun jobs, and updated Wikipedia Zero graphs. Now the graphs include cp301[34] traffic. [22:12:04] legoktm: I'm not sure, but I don't think I see any function names in the legacy.wikibits file, even when it was deprecated in 1.17 there was no notice [22:15:42] For https://gerrit.wikimedia.org/r/#/c/139612/ do I just put that I removed some unnamed funcs? [22:24:56] 3MediaWiki / 3Maintenance scripts: runJobs.php stop working? - 10https://bugzilla.wikimedia.org/66644#c1 (10zoglun) I tried to removed all extension and this time the runjob.php stop here: *RECURSION* [user:RequestContext:private] => User Object (... [22:30:24] 3MediaWiki / 3Maintenance scripts: runJobs.php stop working? - 10https://bugzilla.wikimedia.org/66644#c2 (10Andre Klapper) Might be a question for https://www.mediawiki.org/wiki/Project:Support_desk [22:41:53] 3MediaWiki / 3Maintenance scripts: runJobs.php stop working? - 10https://bugzilla.wikimedia.org/66644#c3 (10Bawolff (Brian Wolff)) > > Which looks like a extension called Duoshuo blocked the runJobs.php. > Unfortunately this is an important extension, I can not stop it. May I > please to know what is wgSha... [22:51:23] 3MediaWiki / 3Maintenance scripts: runJobs.php stop working? - 10https://bugzilla.wikimedia.org/66644#c4 (10zoglun) There are not any result of php runJobs.php： [root@moegirl-1 maintenance]# php runJobs.php [root@moegirl-1 maintenance]# A interesting thing I found is that php showJobs.php got 0 result. Bu... [22:56:49] (03PS16) 10Reedy: Switch API to use Config classes [core] - 10https://gerrit.wikimedia.org/r/109271 [23:00:19] (03PS7) 10devunt: Validates pre-filled form values in SpecialBlock.php page also [core] - 10https://gerrit.wikimedia.org/r/136290 (https://bugzilla.wikimedia.org/35687) [23:01:39] (03PS8) 10devunt: Validates pre-filled form values in SpecialBlock.php page also [core] - 10https://gerrit.wikimedia.org/r/136290 (https://bugzilla.wikimedia.org/35687) [23:02:38] 3MediaWiki / 3Maintenance scripts: runJobs.php stop working? - 10https://bugzilla.wikimedia.org/66644#c5 (10Kunal Mehta (Legoktm)) What version of MediaWiki did you upgrade from? [23:03:43] (03PS1) 10Reedy: Add me to Credits [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/139758 [23:03:53] 3MediaWiki / 3Maintenance scripts: runJobs.php stop working? - 10https://bugzilla.wikimedia.org/66644#c6 (10zoglun) upgrade from mediawiki-1.22.6 [23:14:39] (03PS1) 10TheDJ: Toolbar: Fix dependencies of WikiEditor toolbar [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/139759 [23:15:40] 3MediaWiki / 3Maintenance scripts: runJobs.php stop working? - 10https://bugzilla.wikimedia.org/66644#c7 (10zoglun) 5NEW>3RESO/WOR I "TRUNCATE" the job table then rerun php runJobs.php, everything works fine now. I guess the job table was damaged while upgrading. Thank you Bawolff! Thank you for your help [23:16:34] wtf, that really makes no sense at all... [23:21:41] what doesnt [23:22:37] The user claimed he deleted his job table and now its running jobs properly [23:23:07] well, [23:23:15] I guess it's "fixed". [23:25:53] (03PS1) 10TheDJ: [WIP] Try to split out wikiEditor vs codeEditor toolbar [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/139760 (https://bugzilla.wikimedia.org/45850) [23:26:00] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Try to split out wikiEditor vs codeEditor toolbar [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/139760 (https://bugzilla.wikimedia.org/45850) (owner: 10TheDJ) [23:28:39] 3MediaWiki extensions / 3WikidataRepo: basic support for Wikimedia Commons (MediaInfo entity type) - 10https://bugzilla.wikimedia.org/64288#c2 (10John F. Lewis) This does not come under a community consensus needed tag. This bug is about the addition of an entity type to Wikidata/Wikibase inherently. [23:29:19] (03PS3) 10Bartosz Dziewoński: Output the number of recipients on preview [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97628 (https://bugzilla.wikimedia.org/57472) (owner: 10Legoktm) [23:29:21] (03CR) 10jenkins-bot: [V: 04-1] Output the number of recipients on preview [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97628 (https://bugzilla.wikimedia.org/57472) (owner: 10Legoktm) [23:29:35] (03CR) 10Bartosz Dziewoński: "Still needs rebase." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97628 (https://bugzilla.wikimedia.org/57472) (owner: 10Legoktm) [23:29:46] so fast [23:30:14] bawolff: truncate != delete [23:30:39] (03PS4) 10Krinkle: Update jQuery Cookie to v1.4.1 [core] - 10https://gerrit.wikimedia.org/r/139686 (owner: 10Paladox) [23:30:43] (03CR) 10Krinkle: "I'm sorry but 'master' or 'download' page is not a version I can verify. Everytime a commit is made (now or in the future) that link will " [core] - 10https://gerrit.wikimedia.org/r/139686 (owner: 10Paladox) [23:30:46] still doesn't make sense really. He removed all contents of the table, and now is running jobs [23:31:23] 3MediaWiki extensions / 3CodeEditor: Code editor should not be cuffed to the enhanced toolbar - 10https://bugzilla.wikimedia.org/45850#c9 (10Derk-Jan Hartman) Did some work on splitting this further out: https://gerrit.wikimedia.org/r/139759 https://gerrit.wikimedia.org/r/139760 This is work in progress, i... [23:32:32] He also claimed that the api and showJobs.php were showing different values, when they both call the same method [23:35:53] (03PS2) 10devunt: Show different title when Special:CentralAuth shown in read-only mode [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/136628 (https://bugzilla.wikimedia.org/27142) [23:38:55] (03CR) 10Krinkle: [C: 04-1] "Amended commit message to mention the new version and using stable urls (using the git commit hash in the link, or, if available, the vers" [core] - 10https://gerrit.wikimedia.org/r/139686 (owner: 10Paladox) [23:39:48] (03CR) 10Legoktm: [C: 032] ":D" [core] - 10https://gerrit.wikimedia.org/r/109271 (owner: 10Reedy) [23:40:25] (03CR) 10Bartosz Dziewoński: ":o" [core] - 10https://gerrit.wikimedia.org/r/109271 (owner: 10Reedy) [23:42:31] (03CR) 10Reedy: [C: 04-1] "Needs rebasing" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/108292 (https://bugzilla.wikimedia.org/60075) (owner: 10Legoktm) [23:42:56] (03Merged) 10jenkins-bot: Switch API to use Config classes [core] - 10https://gerrit.wikimedia.org/r/109271 (owner: 10Reedy) [23:43:17] wheee [23:43:21] :D [23:43:27] API is now MediaWiki 2.0 compliant [23:43:48] Reedy: time for the rest of MediaWiki? :D [23:44:04] (03PS2) 10Legoktm: Lower caching time on MassMessage::getDBName [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/108292 (https://bugzilla.wikimedia.org/60075) [23:44:07] Special pages are probably a good next target [23:44:15] rebased ^ [23:44:28] I do wonder how the hell that conflicted.. [23:44:38] we moved the files around [23:44:41] git rebased it just fine [23:44:45] I guess jgit can't handle that [23:44:47] (03CR) 10Reedy: [C: 032] Lower caching time on MassMessage::getDBName [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/108292 (https://bugzilla.wikimedia.org/60075) (owner: 10Legoktm) [23:44:53] jgit sucks [23:44:55] (03Merged) 10jenkins-bot: Lower caching time on MassMessage::getDBName [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/108292 (https://bugzilla.wikimedia.org/60075) (owner: 10Legoktm) [23:45:50] (03PS3) 10Reedy: Clear MassMessage cache when creating a new wiki [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/108293 (https://bugzilla.wikimedia.org/60075) (owner: 10Legoktm) [23:45:54] (03CR) 10Reedy: [C: 032] Clear MassMessage cache when creating a new wiki [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/108293 (https://bugzilla.wikimedia.org/60075) (owner: 10Legoktm) [23:46:01] (03Merged) 10jenkins-bot: Clear MassMessage cache when creating a new wiki [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/108293 (https://bugzilla.wikimedia.org/60075) (owner: 10Legoktm) [23:46:40] (03PS5) 10Reedy: API: Allow 'infinity' as a valid protection expiry [core] - 10https://gerrit.wikimedia.org/r/102896 (owner: 10Legoktm) [23:50:08] legoktm: ^ do we not keep a list of those somewhere? [23:50:17] (03PS1) 10Reedy: Collapse duplicate $existingExpiry == 'infinity' case into else [core] - 10https://gerrit.wikimedia.org/r/139761 [23:50:21] apparently not [23:50:45] if ( $value == 'infinite' || $value == 'indefinite' || $value == 'infinity' ) { [23:50:46] sweet [23:50:58] Sounds like a +easy bug [23:51:18] (03CR) 10Reedy: [C: 032] "From ProtectionForm" [core] - 10https://gerrit.wikimedia.org/r/102896 (owner: 10Legoktm) [23:53:27] (03PS7) 10Legoktm: Show an error to the user if the spamlist has no targets on it [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 (https://bugzilla.wikimedia.org/53970) [23:54:43] (03Merged) 10jenkins-bot: API: Allow 'infinity' as a valid protection expiry [core] - 10https://gerrit.wikimedia.org/r/102896 (owner: 10Legoktm) [23:55:31] (03CR) 10Legoktm: "Rebased, ready to be merged." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 (https://bugzilla.wikimedia.org/53970) (owner: 10Legoktm) [23:56:21] Reedy: ^ [23:56:54] (03PS2) 10Legoktm: Check a valid user object was created before calling ->getId() on it [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/132512 (https://bugzilla.wikimedia.org/65099) [23:57:25] 3MediaWiki / 3General/Unknown: Refactor out 'infinity' variants - 10https://bugzilla.wikimedia.org/66646 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3minor a:3None In ProtectionForm: if ( $value == 'infinite' || $value == 'indefinite' || $value == 'infinity' ) { In ApiProtect: if ( in_array( $expiry[$i],... [23:57:37] 3MediaWiki / 3General/Unknown: Refactor out 'infinity' variants - 10https://bugzilla.wikimedia.org/66646 (10Sam Reed (reedy)) p:5Unprio>3Lowest [23:58:14] (03PS2) 10Reedy: Give messenger user the 'ipblock-exempt' right [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/132511 (https://bugzilla.wikimedia.org/58237) (owner: 10Legoktm) [23:58:38] (03CR) 10Reedy: [C: 032] Give messenger user the 'ipblock-exempt' right [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/132511 (https://bugzilla.wikimedia.org/58237) (owner: 10Legoktm) [23:58:46] (03Merged) 10jenkins-bot: Give messenger user the 'ipblock-exempt' right [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/132511 (https://bugzilla.wikimedia.org/58237) (owner: 10Legoktm)