[12:29:42] (03CR) 10Legoktm: [C: 04-1] Implement JS based URL shortening workflow (032 comments) [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139316 (owner: 10Yuvipanda) [12:29:43] (03PS15) 10Bsitu: edit header [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137474 [12:29:43] (03CR) 10Bsitu: edit header [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137474 (owner: 10Bsitu) [12:29:43] (03CR) 10SG: "Why is modules/new/flow-api.js included in this changeset?" (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137474 (owner: 10Bsitu) [12:29:44] (03CR) 10SG: [C: 04-1] edit header (035 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137474 (owner: 10Bsitu) [12:29:44] (03CR) 10SG: edit header (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137474 (owner: 10Bsitu) [12:29:46] (03Abandoned) 10Mattflaschen: Update jQuery.appear.js [core] - 10https://gerrit.wikimedia.org/r/139554 (owner: 10Paladox) [12:29:46] (03Restored) 10Mattflaschen: Update jQuery.appear.js [core] - 10https://gerrit.wikimedia.org/r/139470 (owner: 10Paladox) [12:29:46] https://gerrit.wikimedia.org/r/#/q/status:open+project:operations/mediawiki-config,n,z [12:29:47] (03CR) 10Mattflaschen: [C: 04-1] ""Hi ok the person that is currently updating it has added any release notes."" [core] - 10https://gerrit.wikimedia.org/r/139470 (owner: 10Paladox) [12:29:48] (03CR) 10SG: [C: 032] revId is not necessary for edit-header link [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139570 (owner: 10Bsitu) [12:29:48] (03CR) 10SG: [C: 032] TopicListBlock doesn't require RootPostLoader anymore [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139549 (owner: 10EBernhardson) [12:29:49] (03CR) 10SG: "Does this add extra visible whitespace? If so, perhaps we are better off expanding element attributes, and not putting all the elements on" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139553 (owner: 10EBernhardson) [12:29:49] (03CR) 10Spage: [C: 032] "Fixes the problem on my local wiki." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139551 (owner: 10EBernhardson) [12:29:49] (03Merged) 10jenkins-bot: Summary not showing on single topic view [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139551 (owner: 10EBernhardson) [12:29:50] (03PS5) 10TTO: Allow interlanguage link prefixes that are not language codes [core] - 10https://gerrit.wikimedia.org/r/111390 (https://bugzilla.wikimedia.org/32189) [12:29:50] (03PS2) 10Spage: Edit Summary, Cancel "Previous revision identifier is missing." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139555 (owner: 10EBernhardson) [12:29:50] (03PS6) 10TTO: Allow interlanguage link prefixes that are not language codes [core] - 10https://gerrit.wikimedia.org/r/111390 (https://bugzilla.wikimedia.org/32189) [12:29:50] (03PS16) 10Bsitu: edit header [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137474 [12:29:50] (03CR) 10jenkins-bot: [V: 04-1] edit header [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137474 (owner: 10Bsitu) [12:29:50] (03PS3) 10Spage: Edit Summary, Cancel "Previous revision identifier is missing." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139555 (owner: 10EBernhardson) [12:29:50] (03PS17) 10Bsitu: edit header [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137474 [12:29:50] (03PS1) 10Deepali: Import chapter list from existing book in the same order as on the contents page [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/139574 (https://bugzilla.wikimedia.org/66367) [12:29:50] (03CR) 10SG: edit header (033 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137474 (owner: 10Bsitu) [12:29:50] (03CR) 10Spage: [C: 031] "Seems to work, but I'm not seeing this error on ee-flow-extra or locally *before* committing this patch. Do we need it for the JS version?" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139555 (owner: 10EBernhardson) [12:29:50] (03CR) 10Bsitu: edit header (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137474 (owner: 10Bsitu) [12:29:50] (03PS1) 10SG: Fix inverse call in TemplateHelper [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139575 [12:29:50] (03CR) 10SG: [C: 032] Fix inverse call in TemplateHelper [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/139575 (owner: 10SG) [12:29:50] (03PS18) 10Bsitu: edit header [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137474 [12:29:50] (03CR) 10TTO: "Anomie: I seem to recall that you said you would be happy to merge this?" [core] - 10https://gerrit.wikimedia.org/r/111390 (https://bugzilla.wikimedia.org/32189) (owner: 10TTO) [12:29:52] (03PS3) 10Jackmcbarn: Upgrade to Lua 5.2 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/139479 [12:29:52] (03CR) 10jenkins-bot: [V: 04-1] Upgrade to Lua 5.2 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/139479 (owner: 10Jackmcbarn) [12:29:52] noooo [12:29:52] (03PS4) 10Jackmcbarn: Upgrade to Lua 5.2 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/139479 [12:29:52] (03CR) 10jenkins-bot: [V: 04-1] Upgrade to Lua 5.2 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/139479 (owner: 10Jackmcbarn) [12:29:52] (03PS5) 10Jackmcbarn: Upgrade to Lua 5.2 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/139479 [12:29:53] (03CR) 10Santhosh: [C: 032] Add LICENSE file [services/cxserver] - 10https://gerrit.wikimedia.org/r/139408 (owner: 10KartikMistry) [12:29:53] (03Merged) 10jenkins-bot: Add LICENSE file [services/cxserver] - 10https://gerrit.wikimedia.org/r/139408 (owner: 10KartikMistry) [12:29:53] (03PS6) 10Jackmcbarn: Upgrade to Lua 5.2 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/139479 [12:29:54] 3MediaWiki / 3Special pages: Broken code - 10https://bugzilla.wikimedia.org/66607 (10zdroid9770) 3UNCO p:3Unprio s:3normal a:3None On the special page, recent changes, in the box for the 'Recent changes options'; The next that says "Show new changes starting from XX:XX, DAY MONTH YEAR". It works but... [12:29:54] 3MediaWiki / 3Special pages: Broken code - 10https://bugzilla.wikimedia.org/66607 (10zdroid9770) [12:29:54] 3MediaWiki / 3Special pages: Broken code - 10https://bugzilla.wikimedia.org/66607 (10zdroid9770) s:5normal>3minor [12:29:54] (03CR) 10TTO: SpecialVersion: Show 'Skins' and 'Extensions' in separate sections (031 comment) [core] - 10https://gerrit.wikimedia.org/r/136615 (owner: 10Bartosz Dziewoński) [12:29:54] 3MediaWiki / 3Special pages: Broken code - 10https://bugzilla.wikimedia.org/66607#c1 (10zdroid9770) Created attachment 15653 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15653&action=edit The broken code in recent change options [12:29:55] (03PS4) 10Legoktm: Add API module: action=usermerge [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/139085 (https://bugzilla.wikimedia.org/39636) [12:29:55] (03PS5) 10TTO: Replace hidesig module with a more robust implementation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102076 (https://bugzilla.wikimedia.org/57727) [12:29:55] (03CR) 10TTO: "Krinkle: ?" [core] - 10https://gerrit.wikimedia.org/r/87649 (https://bugzilla.wikimedia.org/5645) (owner: 10TTO) [12:29:56] (03PS4) 10Legoktm: Use FormSpecialPage [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/139076 (https://bugzilla.wikimedia.org/49519) [12:29:56] (03CR) 10Legoktm: [V: 031] "I've tested this, and it works fine." [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/139076 (https://bugzilla.wikimedia.org/49519) (owner: 10Legoktm) [12:29:56] (03PS5) 10Legoktm: Add API module: action=usermerge [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/139085 (https://bugzilla.wikimedia.org/39636) [12:29:56] (03PS8) 10Yuvipanda: Implement JS based URL shortening workflow [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139316 [12:29:56] legoktm: updated [12:29:56] (03CR) 10Yuvipanda: Implement JS based URL shortening workflow (032 comments) [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139316 (owner: 10Yuvipanda) [12:29:56] will look in a minute [12:29:56] (03CR) 10Legoktm: [V: 031] "Tested, works as expected." [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/139085 (https://bugzilla.wikimedia.org/39636) (owner: 10Legoktm) [12:29:57] YuviPanda: this is what I see with JS disabled: http://cl.ly/image/1z292l2Z0D1f [12:29:57] legoktm: hmm, that's weird, considering [12:29:57] #mwe-urlshortener-form-footer { [12:29:57] display: none; [12:29:57] inspector doesn't show that rule being loaded [12:29:57] YuviPanda: oh, you probably need $out->addModuleStyles [12:29:57] YuviPanda: separate the addModules call into addModules and addModuleStyles [12:29:57] er, addModuleScripts* [12:29:57] legoktm: yeah, just realized [12:29:57] legoktm: amended [12:29:57] (03PS9) 10Yuvipanda: Implement JS based URL shortening workflow [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139316 [12:29:57] legoktm: did you say anything? stupid internet keeps dying [12:29:57] not yet, testing it now [12:29:58] ok [12:29:58] YuviPanda: looks good, should I +2? [12:29:58] legoktm: yes please! [12:29:58] what else is left other than domain name validation? [12:29:58] (03CR) 10Legoktm: [C: 032 V: 032] "Looks good in both JS and non-JS" [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139316 (owner: 10Yuvipanda) [12:29:58] rewrite rules in vagrant [12:29:59] always hate rewrite rules [12:29:59] YuviPanda: I'm going to submit a patch that splits the form and the redirector [12:29:59] legoktm: into different saved pages? [12:29:59] legoktm: gah, special pages [12:29:59] ETOOMUCHANDROIDAPP [12:29:59] yeah [12:29:59] legoktm: cool. doeet [12:29:59] 3MediaWiki extensions / 3OpenID: OpenID prevents wiki update when running on an sqlite database - 10https://bugzilla.wikimedia.org/66605#c1 (10T. Gries) * But please indicate the exact version of OpenID you use (copy the text from Special:Version page). Ug, I am very sorry, I never supported SQlite, only My... [12:29:59] legoktm: did I miss anything again? [12:29:59] stupid network [12:29:59] no, still writing [12:29:59] ik [12:29:59] (03PS1) 10Legoktm: Move the redirecting of urls into its own SpecialPage. [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139578 [12:29:59] YuviPanda: ^ [12:29:59] legoktm: yeah, testing [12:29:59] legoktm: I guess this also solves the Special page aliased redirect loop problem [12:30:00] legoktm: code looks good, am testing [12:30:00] yeah, that was the point of it :) [12:30:00] legoktm: hmm, lulwut [12:30:00] gr, wrong button. [12:30:00] this.api = new mw.Api(); [12:30:00] undefined is not a function [12:30:00] how did that dependency get lost? [12:30:00] uhhhh [12:30:00] it works for me? [12:30:00] legoktm: doesn't work for me in either chrome or FF [12:30:00] legoktm: do a hard refresh maybe? [12:30:00] just did, works for me in ff [12:30:00] (03CR) 10Withoutaname: "Well, it looks like that patch isn't going to fly, so how does "while ( $res->numRows() > 0 )" work for batches? How would we limit the nu" [core] - 10https://gerrit.wikimedia.org/r/135077 (owner: 10Withoutaname) [12:30:00] wtf [12:30:00] legoktm: mw.loader.inspect tells me mediawiki.api is loaded [12:30:00] legoktm: so an ordering problem? [12:30:00] legoktm: switching to addModules fixes it for me [12:30:00] legoktm: so much lag [12:30:00] legoktm: otherwise works for me. [12:30:00] YuviPanda: why don't you just defer creating this.api until you actually need it? [12:30:00] legoktm: sure, but that's just a bandaid, isn't it? if i make it a dependency, it should work [12:30:00] ok... [12:30:00] legoktm: if I do that I'm just reducing my chances of the race condition happening, not completely eliminating it [12:30:00] right [12:30:00] legoktm: perhaps I could move the creation of the results to JS, and that should solve the problem. [12:30:00] legoktm: or just not support non-js. it is 2014 [12:30:00] supporting non-js is extremely trivial [12:30:00] legoktm: for this one, true, yeah [12:30:00] and I can't reproduce your error. [12:30:00] legoktm: such is the nature of timing bugs? clearly mw.api is loading after the urlshortener for some reason [12:30:00] but isn't it listed as a dependency? [12:30:00] legoktm: it is [12:30:00] legoktm: did I get the dependency name wrong? that should show up as a fatal, right? [12:30:00] legoktm: I can consistently repro it by using addScripts instead of addModules [12:30:00] err, addModuleSciprts [12:30:00] oh god, my internet is a fucking piece of shite today [12:30:01] 3MediaWiki extensions / 3OpenID: OpenID prevents wiki update when running on an sqlite database - 10https://bugzilla.wikimedia.org/66605#c2 (10Max Dominik Weber) (In reply to T. Gries from comment #1) > * But please indicate the exact version of OpenID you use (copy the text > from Special:Version page). 4.... [12:30:01] legoktm: either way, I'm going to merge your change, since that doesn't seem to be the one causing the timing issues [12:30:01] (03CR) 10Yuvipanda: [C: 04-1] "Minor nit." (031 comment) [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139578 (owner: 10Legoktm) [12:30:01] legoktm: minor nit [12:30:01] (03PS2) 10Legoktm: Move the redirecting of urls into its own SpecialPage. [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139578 [12:30:01] (03CR) 10Legoktm: Move the redirecting of urls into its own SpecialPage. (031 comment) [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139578 (owner: 10Legoktm) [12:30:01] done [12:30:02] merging [12:30:02] oh god my internet [12:30:02] wtf [12:30:02] (03CR) 10Yuvipanda: [C: 032 V: 032] Move the redirecting of urls into its own SpecialPage. [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139578 (owner: 10Legoktm) [12:30:02] legoktm: \o/ [12:30:02] :D [12:30:02] legoktm: now to make it actually work on my local machine [12:30:02] legoktm: I think I should move the 'generate the HTML' part completely to JS [12:30:02] legoktm: and add a dependency on Mantle, and use handlebars [12:30:02] ......no. [12:30:02] first part was fine, using Mantle is not. [12:30:02] legoktm: why not? [12:30:02] MF and Flow depend on it [12:30:02] and I really want more people to start using templates [12:30:02] because it adds an extra dependency for something totally trivial [12:30:02] I was going to deploy this on Uncyclopedia once you added in validation and wrote the rewrite rules :/ [12:30:02] legoktm: oh come on, you're just being mean now :P [12:30:02] writing DOM by hand is evil [12:30:02] EVILL [12:30:02] EEEEEEVVVVVIIIIIILLLLL [12:30:02] Good thing you're using Html::element then! ;) [12:30:02] legoktm: I know, that's only because PHP HTML templating is a lot more controversial than JS. [12:30:03] MF and Flow depend on it p858snake|l: well, I personally think constructing DOM elements manually is stupid [12:30:03] legoktm: does flow use hogan or handlebars? [12:30:03] handlebars I believe. [12:30:03] legoktm: which version? [12:30:03] whatever Mantle provides. [12:30:03] legoktm: wait, deployed versions of Flow depend on mantle? [12:30:03] no [12:30:03] legoktm: or is the prod version pegged at something else? [12:30:03] frontend-rewrite branch [12:30:03] ah [12:30:09] right [12:30:09] prod version is `master`, which had it's own PHP templating library, nothing clientside [12:30:09] legoktm: any idea when that's gonna get merged? [12:30:09] plan is tuesday [12:30:09] I think, but it depends on Mantle obviously [12:30:09] legoktm: ah, right. cool. [12:30:09] (03PS5) 10Withoutaname: Add script to empty a usergroup of users [core] - 10https://gerrit.wikimedia.org/r/135077 [12:30:09] (03PS2) 10Talktodan: Only list Create account when permissions allow it [core] - 10https://gerrit.wikimedia.org/r/139392 (https://bugzilla.wikimedia.org/66589) [12:30:09] (03CR) 10Talktodan: "Thankyou for the quick feedback! I've updated another patch set. I didn't seem to have much success with $this->mRestriction" [core] - 10https://gerrit.wikimedia.org/r/139392 (https://bugzilla.wikimedia.org/66589) (owner: 10Talktodan) [12:30:09] (03PS1) 10Yuvipanda: Add host-based whitelist for domains that can be shortened [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139579 [12:30:09] legoktm: ^ needs docs + different message. also need to do client side validation as well [12:30:10] doing message now [12:30:10] legoktm: hmm, I want the error message to include the name of the domain, unsure how to do that with Status [12:30:10] hmm [12:30:10] YuviPanda: you can pass Message objects to status [12:30:10] how come this is +2 but it's still open https://gerrit.wikimedia.org/r/#/c/138530/ [12:30:10] legoktm: oh, cool then [12:30:10] Status::newFatal( $this->msg( foo )->params( bar ) ); [12:30:10] legoktm: hmm, I'm trying to figure out what to return from Utils::validate [12:30:10] legoktm: any way I can pack a Message object with a param as well before returning it? [12:30:10] return $this->msg( $key )->params( $foo ); [12:30:10] right [12:30:10] just realized :D [12:30:10] ok [12:30:10] (03CR) 10Legoktm: [C: 04-1] Add host-based whitelist for domains that can be shortened (031 comment) [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139579 (owner: 10Yuvipanda) [12:30:10] legoktm: hmm, that sounds more reasonable. [12:30:10] legoktm: but it needs to be regexescaped [12:30:10] ah [12:30:10] preg_quote [12:30:10] YuviPanda: clientside can be adding the regex to mw.config, and then quick validation client-side enforced serverside [12:30:10] legoktm: yup. [12:30:10] legoktm: I'll do that in another patch though [12:30:10] ok :D [12:30:10] legoktm: bah, $wgServer has '//' in front of it [12:30:10] * YuviPanda grumbles [12:30:10] legoktm: great. and since I can't do wfParseUrl( $wgServer )['host'] I'm unsure how to proceed [12:30:10] hmm, set this to false and re-set it somewhere else, I guress [12:30:10] legoktm: actually, I think by default it should default to allowing everything [12:30:10] uhhh [12:30:10] no, safe by default :/ [12:30:10] legoktm: why isn't it safe? it's just an arbitrary url shortener [12:30:10] 3MediaWiki / 3User login and signup: Special:CreateAccount should be listed in Special:SpecialPages - 10https://bugzilla.wikimedia.org/53447 (10Umherirrender) [12:30:10] 3MediaWiki / 3Special pages: Special:SpecialPages displays create account when permissions do not allow it - 10https://bugzilla.wikimedia.org/66589 (10Umherirrender) [12:30:10] because spam [12:30:10] legoktm: hmm, true [12:30:10] legoktm: alright then [12:30:10] (03PS2) 10Yuvipanda: Add host-based whitelist for domains that can be shortened [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139579 [12:30:10] legoktm: ^ [12:30:10] 3MediaWiki extensions / 3UniversalLanguageSelector: Don't load ULS IME on autofocused search bar - 10https://bugzilla.wikimedia.org/65988#c6 (10Nemo) It was pointed out that the same behaviour is not immediately reproducible on other wikis like fr.wiki. To reproduce, one indeed needs to add something like it... [12:30:10] legoktm: defaults to wgServer, has docs [12:30:10] :D [12:30:10] YuviPanda: can we implode( '|', $domainsWhitelist ) so we only need to do the regex once? [12:30:10] legoktm: hmm, I'm wary of string manipulating regexes any more than I already have... [12:30:10] legoktm: trying to think of ways that can be circumvented... [12:30:10] can I modify stuff in puppet? afraid of breaking production [12:30:10] Withoutaname: don't worry, it will be reviewed by someone in ops before it gets merged. feel free to submit a patch :) [12:30:10] legoktm: hmm, can't think of any attacks against it. let me spend another minute [12:30:10] (03CR) 10TTO: [C: 031] Only list Create account when permissions allow it [core] - 10https://gerrit.wikimedia.org/r/139392 (https://bugzilla.wikimedia.org/66589) (owner: 10Talktodan) [12:30:10] (03CR) 10Legoktm: [C: 031] "Minor." (031 comment) [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139579 (owner: 10Yuvipanda) [12:30:10] YuviPanda: how come this wasn't merged despite receiving +2 https://gerrit.wikimedia.org/r/#/c/138530/ [12:30:10] Withoutaname: not all repos have jenkins-bot [12:30:10] in that case it needs V+2 and a manual submit [12:30:10] (03CR) 10Yuvipanda: [V: 032] "No jenkins here." [wikimedia/communications/WMBlog] - 10https://gerrit.wikimedia.org/r/138530 (owner: 10Withoutaname) [12:30:10] Withoutaname: merged now [12:30:10] Withoutaname: what legoktm said [12:30:10] thanks [12:30:10] Withoutaname: I'm not sure what the deployment process for that repo is, you should probably talk to HaeB about it [12:30:10] it's a minor touchup to the outdated http links, no biggie [12:30:10] right, but you don't want it to be out of sync [12:30:10] legoktm: hmm, so I'll have to go through the array, make sure that the ^ and $ are added, and then do the implode, and then append / and / [12:30:10] that sounds good I think. [12:30:10] (03CR) 10TTO: [C: 031] "There is no mention of loginprompt at https://www.mediawiki.org/wiki/Account_creation_user_experience/Strings, and there is currently no w" [core] - 10https://gerrit.wikimedia.org/r/139399 (https://bugzilla.wikimedia.org/66574) (owner: 10Talktodan) [12:30:10] legoktm: ok, testing now [12:30:10] (03CR) 10Frédéric Wang: "FYI, the new OpenType MATH support is available in Firefox Beta: https://www.mozilla.org/en-US/firefox/channel/#beta" [extensions/Math] - 10https://gerrit.wikimedia.org/r/134362 (https://bugzilla.wikimedia.org/65532) (owner: 10Frédéric Wang) [12:30:10] (03PS3) 10Yuvipanda: Add host-based whitelist for domains that can be shortened [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139579 [12:30:10] legoktm: see now [12:30:10] (03CR) 10Legoktm: Add host-based whitelist for domains that can be shortened (031 comment) [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139579 (owner: 10Yuvipanda) [12:30:10] looks good otherwise [12:30:10] legoktm: merge? [12:30:10] legoktm: oh, saw comment [12:30:10] wait [12:30:11] * legoktm goes afk for a bit to find food [12:30:11] (03CR) 10Yuvipanda: Add host-based whitelist for domains that can be shortened (031 comment) [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139579 (owner: 10Yuvipanda) [12:30:11] (03PS4) 10Yuvipanda: Add host-based whitelist for domains that can be shortened [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139579 [12:30:11] legoktm: fixed [12:30:11] legoktm: kk food [12:30:11] * YuviPanda goes back to writing rewrite rules [12:30:11] WHICH NEVER WORK [12:30:11] fucking rewrites [12:30:11] (03CR) 10Legoktm: [C: 032 V: 032] Add host-based whitelist for domains that can be shortened [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139579 (owner: 10Yuvipanda) [12:30:11] YuviPanda: should I do client-side? [12:30:11] legoktm: yesplz [12:30:11] rewrites are fucking annoying [12:30:11] no easy way to debug them [12:30:11] how different is it from shorturl? [12:30:11] legoktm: exactly the same, actually. except the old ones don't work [12:30:11] lol [12:30:11] should be just RewriteRule ^/s/.*$ /w/index.php [12:30:11] except that doesn't work [12:30:11] just random 404 [12:30:11] fuckers [12:30:11] ..... [12:30:11] * legoktm slaps YuviPanda [12:30:11] WHY ARE YOU USING SPACES [12:30:11] legoktm: hmm? where? [12:30:11] in the js file [12:30:11] I thought I had configured intellij to use tabs :| [12:30:11] let me check [12:30:11] ah, apparently not [12:30:11] let me commit a fix [12:30:11] no [12:30:11] already on it [12:30:11] legoktm: hmm, ok [12:30:11] (03PS1) 10Yuvipanda: Retab all the things [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139582 [12:30:11] oh [12:30:11] -.- [12:30:11] (03CR) 10Legoktm: [C: 032 V: 032] Retab all the things [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139582 (owner: 10Yuvipanda) [12:30:11] ok [12:30:11] YuviPanda: what's the javascript equivalent of preg_quote? [12:30:11] legoktm: hmm, don't think there's one [12:30:11] legoktm: you should addJsConfig the imploded string, I think. [12:30:11] hmmm. ok. [12:30:11] http://phpjs.org/functions/preg_quote/ o.O [12:30:11] legoktm: hmm? [12:30:11] oh [12:30:11] lol [12:30:11] I'm just gonna do the PHP thing. [12:30:11] legoktm: yeah, that regex looks scary [12:30:11] plus then we'll have n + 1 problems [12:30:11] legoktm: you should put amend the config var doc as well, to say that the regex will be executed in both php and js [12:30:11] ok [12:30:11] 3MediaWiki extensions / 3OpenID: OpenID prevents wiki update when running on an sqlite database - 10https://bugzilla.wikimedia.org/66605#c3 (10T. Gries) 5UNCO>3ASSI > Is there a specific reason HEAD is recommended over the release-specific > branch? This seems inconsistent with the versioning of other ex... [12:30:11] 3MediaWiki extensions / 3OpenID: OpenID prevents wiki update when running on an sqlite database - 10https://bugzilla.wikimedia.org/66605#c4 (10T. Gries) In other words (short version): I keep E:OpenID head working against mediawiki core head. When MediaWiki makes a realease 1.xy, they make a "freeze snapshot... [12:30:11] YuviPanda: so there's no url parser in javascript...? [12:30:11] legoktm: mw.Uri or something? [12:30:11] oh right! [12:30:11] YuviPanda: I wrote most of it, but it's not working properly. [12:30:11] (03PS1) 10Legoktm: Validate urls client-side [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139583 [12:30:11] (03CR) 10Legoktm: [C: 04-1] "Not working or something." [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139583 (owner: 10Legoktm) [12:30:11] legoktm: let me take a look. [12:30:11] legoktm: the redirect rules are fucked atm, I've no idea how to debug [12:30:12] ok, I probably should not be awake right now. [12:30:12] ++ [12:30:12] legoktm: go sleep. I'll fixup [12:30:12] o/ gnite [12:30:12] legoktm: night! [12:30:14] (03PS1) 10Yuvipanda: Make mw.Uri support URIs with no explicit path component [core] - 10https://gerrit.wikimedia.org/r/139584 [12:30:14] (03PS2) 10Yuvipanda: Validate urls client-side [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139583 (owner: 10Legoktm) [12:30:14] (03CR) 10jenkins-bot: [V: 04-1] Make mw.Uri support URIs with no explicit path component [core] - 10https://gerrit.wikimedia.org/r/139584 (owner: 10Yuvipanda) [12:30:14] hah! nice jenkinsbot [12:30:14] 3MediaWiki extensions / 3[other]: Access Control Panel - 10https://bugzilla.wikimedia.org/66611 (10Zidjinn) 3UNCO p:3Unprio s:3normal a:3None For me, previous (old) pages, created by Access control panel Groups disapears. WikiName.org/wiki/ProtectedGroupName:PageName become WikiName.org/wiki/:Pag... [12:30:14] 3MediaWiki extensions / 3[other]: Access Control Panel - 10https://bugzilla.wikimedia.org/66611 (10Zidjinn) [12:30:15] Hi! can hooks in mediawiki only return bool ? [12:30:15] MatmaRex: can you tell me if http://sugarfrosties.wmflabs.org/wiki/Special:UrlShortener gives you js errors on the console? [12:30:15] Hi, what is the difference between {{PAGENAME}} and {{FULLPAGENAME}} [12:30:15] Sorry,, Got it [12:30:15] YuviPanda: i can [12:30:16] MatmaRex: will you? :) [12:30:16] "Unhandled Error: 'mw.Api' is not a constructor" [12:30:16] MatmaRex: yeah, that sounds right. [12:30:16] is mediawiki.api a dependency of your module? [12:30:16] MatmaRex: it is. the error goes away if I use addModules [12:30:16] MatmaRex: but to support non-js, I was using separate addModuleScript and addModuleStyles [12:30:16] that causes this [12:30:16] oh. and what did you use? [12:30:16] ah [12:30:16] yes [12:30:16] these don't support dependencies [12:30:16] MatmaRex: oh, at all? [12:30:16] yup [12:30:16] so how am I supposed to get CSS to no JS clients? [12:30:16] put it in a separate module and addModuleStyles() just that [12:30:16] ah, hmm [12:30:16] ok then [12:30:16] this is a bit ugly [12:30:16] yes [12:30:16] 3MediaWiki extensions / 3Scribunto: Dynamically generate files with Scribunto - 10https://bugzilla.wikimedia.org/64460#c2 (10Janus Troelsen) This could also replace EasyTimeline, see bug 27156, bug 60263, bug 35320. [12:30:16] 3MediaWiki extensions / 3Scribunto: Dynamically generate files with Scribunto - 10https://bugzilla.wikimedia.org/64460#c3 (10Janus Troelsen) The reason I used the [[File:Module:XXX]] syntax for the prototype, is, that it enables these scripts to be used whereever images can currently be used. It was importan... [12:30:17] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This makes the module too lax, thus the test failures. It seems that we want to support "example.com/" and "http://example.com", but not "" [core] - 10https://gerrit.wikimedia.org/r/139584 (owner: 10Yuvipanda) [12:30:17] 3MediaWiki extensions / 3UniversalLanguageSelector: Unable to select all input methods - 10https://bugzilla.wikimedia.org/66613 (10Niklas Laxström) 3NEW p:3Unprio s:3normal a:3None I created input method for Ludic (lud), but it is not selectable from the IME language selector, perhaps because it is n... [12:30:17] (03CR) 10Yuvipanda: "Indeed. I was thinking the way to check would be if *all* non-path components are empty *and* the path doesn't start with a /, we bail. T" [core] - 10https://gerrit.wikimedia.org/r/139584 (owner: 10Yuvipanda) [12:30:17] (03CR) 10Rillke: "I'd like to use this in UploadWizard now. What's missing? Should I invite someone else for code review?" [core] - 10https://gerrit.wikimedia.org/r/131971 (https://bugzilla.wikimedia.org/64912) (owner: 10Rillke) [12:30:17] (03CR) 10Multichill: [C: 031] "Great. Thanks for enabling this!" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/139417 (owner: 10Hashar) [12:30:17] (03PS3) 10Yuvipanda: Validate urls client-side [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139583 (owner: 10Legoktm) [12:30:17] (03PS1) 10Yuvipanda: Fix JS/CSS & RL config to work properly in both JS & non-JS envs [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139588 [12:30:17] (03PS2) 10Yuvipanda: Make mw.Uri support URIs with no explicit path component [core] - 10https://gerrit.wikimedia.org/r/139584 [12:30:17] MatmaRex: let's see if ^ passes. [12:30:17] I'm too lazy to lookup docs for running qunit locally atm [12:30:17] YuviPanda: %wgEnabledJavaScriptTest = true; visit [[Special:JavaScriptTest]] [12:30:17] sooo mucchhh workkk [12:30:18] :P [12:30:18] fine [12:30:18] $wgEnableJavaScriptTest, rather, or something like this [12:30:18] jenkins is good for running unit tests :P [12:30:18] bah [12:30:18] still fails [12:30:18] (03CR) 10jenkins-bot: [V: 04-1] Make mw.Uri support URIs with no explicit path component [core] - 10https://gerrit.wikimedia.org/r/139584 (owner: 10Yuvipanda) [12:30:19] (03CR) 10Marco: [C: 031] mw.Title: Add new static methods `newFromFileName`, `newFromUserInput` [core] - 10https://gerrit.wikimedia.org/r/131971 (https://bugzilla.wikimedia.org/64912) (owner: 10Rillke) [12:30:19] (03PS4) 10Yuvipanda: Validate urls client-side [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139583 (owner: 10Legoktm) [12:30:19] (03PS1) 10Yuvipanda: Split RL modules into separate script and style modules [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139589 [12:30:19] (03PS1) 10Yuvipanda: Rename a div's id to makea more sense [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139590 [12:30:19] hmm, just discovered a nice way to split a commit in the middle of a long branch into two [12:30:19] nice [12:30:19] (03Abandoned) 10Yuvipanda: Fix JS/CSS & RL config to work properly in both JS & non-JS envs [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139588 (owner: 10Yuvipanda) [12:30:19] YuviPanda|zzz: zzz now?? [12:30:19] liangent: I think he just has an auto-away script [12:30:19] 3Wikimedia / 3Mailing lists: Close wikimedia-de-by-ltp - 10https://bugzilla.wikimedia.org/46016 (10Tomasz W. Kozlowski) [12:30:19] 3Wikimedia / 3Mailing lists: Remove the wikimedia-connecticut list - 10https://bugzilla.wikimedia.org/66003#c2 (10Tomasz W. Kozlowski) 5NEW>3ASSI a:3Giuseppe Lavagetto Assigning this to Giuseppe after a short discussion in #wikimedia-operations a couple of days ago. [12:30:20] 3Wikimedia / 3Mailing lists: Delete lists for WMVE - 10https://bugzilla.wikimedia.org/61735 (10Tomasz W. Kozlowski) [12:30:20] 3Wikimedia / 3Mailing lists: please close chip-l mailing list - 10https://bugzilla.wikimedia.org/63877 (10Tomasz W. Kozlowski) [12:30:20] 3MediaWiki / 3Parser: thead, tbody, tfoot for wikitable syntax - 10https://bugzilla.wikimedia.org/4740#c24 (10Andy Mabbett) Gabriel: The use case is out lined in Michael Zajac's initial post (timestamp: 2006-01-24 02:41:52); and in comments 4 & 11. Do you have questions about those? It appeared from comm... [12:30:20] 3MediaWiki / 3Parser: thead, tbody, tfoot for wikitable syntax - 10https://bugzilla.wikimedia.org/4740#c25 (10Andy Mabbett) Also, the heuristic suggested above won't work, as it's necessary to allow for more than one tbody per table. [12:30:22] (03PS1) 10Rillke: Create title in file NS and validate as such [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/139592 (https://bugzilla.wikimedia.org/66366) [12:30:22] (03CR) 10MarkAHershberger: [C: 032] Fix Call to undefined method Block::infinity() [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/139409 (owner: 10Martineznovo) [12:30:22] (03PS1) 10MarkAHershberger: Fix Call to undefined method Block::infinity() [extensions/BlockAndNuke] (REL1_23) - 10https://gerrit.wikimedia.org/r/139593 [12:30:24] 3MediaWiki extensions / 3WikidataRepo: High coordinate precision fires "The value does not comply with the property's definition." - 10https://bugzilla.wikimedia.org/55971 (10Lydia Pintscher) 5REOP>3RESO/FIX [12:30:24] 3MediaWiki extensions / 3WikidataRepo: High coordinate precision fires "The value does not comply with the property's definition." - 10https://bugzilla.wikimedia.org/55971 (10Lydia Pintscher) 5RESO/?>3VERI [12:30:25] (03PS1) 10Bartosz Dziewoński: Fix some line mis-wrapping and typos in RELEASE-NOTES-1.24 [core] - 10https://gerrit.wikimedia.org/r/139594 [12:46:36] (03PS6) 1001tonythomas: Implementing VERP functionality hook to core [core] - 10https://gerrit.wikimedia.org/r/138655 (https://bugzilla.wikimedia.org/46640) [12:53:27] (03PS7) 1001tonythomas: Implementing VERP functionality hook to core [core] - 10https://gerrit.wikimedia.org/r/138655 (https://bugzilla.wikimedia.org/46640) [13:09:39] 3MediaWiki / 3Maintenance scripts: deleteOldRevisions.php delete content date - 10https://bugzilla.wikimedia.org/66615 (10sen) 3UNCO p:3Unprio s:3normal a:3None i run the script,it delete a lot revision,which is cool. [root@li84-236 w]# php maintenance/deleteOldRevisions.php Delete old revisions S... [13:11:11] 3MediaWiki / 3Maintenance scripts: deleteOldRevisions.php delete content date - 10https://bugzilla.wikimedia.org/66615#c1 (10sen) but after doing that,i found lot of page become empty content,after dump all the date,i can paster some info like: Yum 被锁定 0 121... [13:11:41] 3MediaWiki / 3Maintenance scripts: deleteOldRevisions.php delete content date - 10https://bugzilla.wikimedia.org/66615#c2 (10sen) you can see the page is blank on mysite http://see.sl088.com/wiki/Yum_%E8%A2%AB%E9%94%81%E5%AE%9A [13:30:00] (03PS1) 10MarkAHershberger: Add mw.isSubsting() [extensions/Scribunto] (REL1_22) - 10https://gerrit.wikimedia.org/r/139597 (https://bugzilla.wikimedia.org/47828) [15:22:29] (03Abandoned) 10Jackmcbarn: (DON'T MERGE) Expose string.dump and loadstring [php/luasandbox] - 10https://gerrit.wikimedia.org/r/133842 (owner: 10Jackmcbarn) [15:24:39] (03CR) 10Alex Monk: Add script to empty a usergroup of users (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135077 (owner: 10Withoutaname) [15:40:14] (03CR) 10Raimond Spekking: [C: 032 V: 032] Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/134319 (owner: 10Smuggli) [15:49:48] liangent: yeah, jetlag. [15:49:53] it's pretty fuckall [16:09:13] (03PS2) 10Yuvipanda: Rename a div's id to make more sense [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139590 [16:09:50] (03PS5) 10Yuvipanda: Validate urls client-side [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139583 (owner: 10Legoktm) [16:12:53] * YuviPanda_ wonders if MatmaRex or legoktm are around [16:32:19] 3MediaWiki / 3JavaScript: me.Uri doesn't recognize URLs like http://wikimedia.org - 10https://bugzilla.wikimedia.org/66617 (10Yuvi Panda) 3NEW p:3Unprio s:3normal a:3None http://wikimedia.org/ is recognized. So if you have only a domain name, it *requires* a path. This might be valid({{cn}}) based... [16:32:49] (03PS6) 10Yuvipanda: Validate urls client-side [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139583 (owner: 10Legoktm) [16:33:03] prtksxna: hi [16:34:48] zz_prtksxna: po [17:05:58] 3MediaWiki extensions / 3Math: Math: fatal errors - 10https://bugzilla.wikimedia.org/66587 (10physikerwelt) [17:05:58] 3MediaWiki extensions / 3Math: Add separate database tables for Mathoid - 10https://bugzilla.wikimedia.org/65793 (10physikerwelt) [17:09:32] 3Wikimedia / 3Extension setup: Update extension documentation with info about schema changes - 10https://bugzilla.wikimedia.org/66603#c1 (10physikerwelt) 5NEW>3RESO/FIX I added a warning to https://www.mediawiki.org/wiki/Manual:Hooks/LoadExtensionSchemaUpdates and https://www.mediawiki.org/wiki/Manual:D... [17:21:43] 3MediaWiki extensions / 3UniversalLanguageSelector: [CompactLangLinks] Set href attributes for s in the panel - 10https://bugzilla.wikimedia.org/66620 (10Liangent) 3NEW p:3Unprio s:3normal a:3None So mid-clicking the link to open it in a new tab works. [17:27:18] (03CR) 1001tonythomas: "currently, the extension is here at https://github.com/tonythomas01/BounceHandler, it will be moved to gerrit immediately." [core] - 10https://gerrit.wikimedia.org/r/138655 (https://bugzilla.wikimedia.org/46640) (owner: 1001tonythomas) [17:48:28] (03PS3) 10Withoutaname: Remove $wgFileStore [core] - 10https://gerrit.wikimedia.org/r/139187 [17:58:42] 3Wikimedia / 3General/Unknown: Sometimes user preferences change gets reverted (User:Liangent@zhwiki) - 10https://bugzilla.wikimedia.org/64153#c3 (10Liangent) I haven't heard any other user report, but I'm still experiencing it. [18:00:10] * YuviPanda pokes legoktm to see if he's around [18:09:49] who owns api.php?action=query&prop=extracts [18:09:53] I mean which component? [18:11:27] (03PS7) 10Yuvipanda: Validate urls client-side [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139583 (owner: 10Legoktm) [18:11:29] liangent: TextExtracts [18:11:41] liangent: MaxSem is primary author [18:12:01] * MaxSem hides [18:12:26] MaxSem: &variant= param pollutes extracts cache [18:12:54] MaxSem: also user prefs about variants [18:13:15] fileabugfileabugfileabugg [18:14:15] 3MediaWiki extensions / 3TextExtracts: Extracts cache is not separated by variant correctly - 10https://bugzilla.wikimedia.org/66621 (10Liangent) 3NEW p:3Unprio s:3normal a:3None &variant param and user prefs. [18:14:34] MaxSem: ^ [18:24:14] 3MediaWiki-Vagrant: Inconsistent $wgUseInstantCommons setting - 10https://bugzilla.wikimedia.org/66622 (10TeleComNasSprVen) 3NEW p:3Unprio s:3normal a:3Ori Livneh It seems my vagrant installation sometimes sets $wgUseInstantCommons to true and sometimes sets it to false, because whether or not I can ac... [18:27:57] 3MediaWiki extensions / 3Translate: MessageGroupStats::forItemInternal deadlocks - 10https://bugzilla.wikimedia.org/51410#c11 (10Tomasz W. Kozlowski) Just got that on Meta while trying to view [[m:Tech/News/2014/25]]. [18:32:26] YuviPanda: hi [18:32:37] legoktm: hi [18:34:20] legoktm: the bug I was seeing, MatmaRex was also seeing :) apparently addModuleScripts doesn't resolve dependencies, which seems, uh, kinda less useful. I've submitted a patch with a fix [18:34:28] legoktm: also fixed your patch, and found a bug in cor in the meantime [18:35:26] YuviPanda: https://bugzilla.wikimedia.org/show_bug.cgi?id=61577 might interest you [18:36:12] 3MediaWiki / 3ResourceLoader: OutputPage::addModuleStyles should support module dependencies - 10https://bugzilla.wikimedia.org/61577 (10Bartosz Dziewoński) [18:36:57] 3MediaWiki / 3ResourceLoader: addModules(), etc. should warn when a passed array declares a module twice (overwriting) - 10https://bugzilla.wikimedia.org/29629 (10Bartosz Dziewoński) 5RESO/WON>3RESO/INV [18:37:26] 3MediaWiki extensions / 3[other]: [Access Control Panel] Previous (old) pages disappear - 10https://bugzilla.wikimedia.org/66611#c1 (10Andre Klapper) p:5Unprio>3Lowest Thanks for reporting this here. I see you also brought this up on https://www.mediawiki.org/wiki/Extension_talk:Access_Control_Panel and... [18:38:11] 3MediaWiki / 3Special pages: Broken code - 10https://bugzilla.wikimedia.org/66607#c2 (10Andre Klapper) I do not see that problem on https://www.mediawiki.org/wiki/Special:RecentChanges - what are steps to reproduce? [18:41:11] 3MediaWiki / 3Special pages: Broken code - 10https://bugzilla.wikimedia.org/66607#c3 (10Bartosz Dziewoński) 5UNCO>3RESO/INV The code comes from the [[MediaWiki:Rclistfrom]] system message on your wiki. Restore it to the default value (which has no weird things) to resolve the issue. [18:42:27] 3Wikimedia / 3General/Unknown: Sometimes user preferences change gets reverted (User:Liangent@zhwiki) - 10https://bugzilla.wikimedia.org/64153#c4 (10Kunal Mehta (Legoktm)) Are they random preferences or specific ones? [18:43:56] 3Wikimedia / 3General/Unknown: Sometimes user preferences change gets reverted (User:Liangent@zhwiki) - 10https://bugzilla.wikimedia.org/64153#c5 (10Liangent) (In reply to Kunal Mehta (Legoktm) from comment #4) > Are they random preferences or specific ones? random preferences [18:58:17] (03PS1) 10Raimond Spekking: Fix syntax error [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/139611 [18:58:45] (03CR) 10Raimond Spekking: [C: 032 V: 032] Fix syntax error [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/139611 (owner: 10Raimond Spekking) [19:03:40] (03PS1) 10Withoutaname: Remove deprecated 1.17-1.18 Javascript functions from legacy wikibits [core] - 10https://gerrit.wikimedia.org/r/139612 [19:04:46] legoktm: CR me maybe? [19:05:07] (03CR) 10jenkins-bot: [V: 04-1] Remove deprecated 1.17-1.18 Javascript functions from legacy wikibits [core] - 10https://gerrit.wikimedia.org/r/139612 (owner: 10Withoutaname) [19:12:05] (03CR) 10Legoktm: [C: 04-1] Implementing VERP functionality hook to core (033 comments) [core] - 10https://gerrit.wikimedia.org/r/138655 (https://bugzilla.wikimedia.org/46640) (owner: 1001tonythomas) [19:14:06] (03PS2) 10Withoutaname: Remove deprecated 1.17-1.18 Javascript functions from legacy wikibits [core] - 10https://gerrit.wikimedia.org/r/139612 [19:40:41] 3MediaWiki / 3JavaScript: mw.Uri doesn't recognize URLs like http://wikimedia.org - 10https://bugzilla.wikimedia.org/66617 (10Kunal Mehta (Legoktm)) [19:41:46] (03CR) 10Legoktm: [C: 032 V: 032] Split RL modules into separate script and style modules [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139589 (owner: 10Yuvipanda) [19:43:41] (03PS3) 10Legoktm: Rename a div's id to make more sense [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139590 (owner: 10Yuvipanda) [19:43:50] (03CR) 10Legoktm: [C: 032 V: 032] Rename a div's id to make more sense [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139590 (owner: 10Yuvipanda) [19:48:36] (03PS4) 10Paladox: Update jQuery.appear.js [core] - 10https://gerrit.wikimedia.org/r/139470 [19:49:18] legoktm: I guess you don't want to merge your last patch, since you wrote it, and I shouldn't merge it either since I did a bunch of work [19:49:43] er, I didn't merge it because it needs the core patch. [19:49:44] 3Wikimedia / 3General/Unknown: Text '69.130.114.203 is a student in Intellectual Freedom - LIS 493 (course talk).' shown on all IP editor's contributors - 10https://bugzilla.wikimedia.org/66624 (10Danielle Leishman) 3UNCO p:3Unprio s:3normal a:3None On the English Encylopedia, if you were to view ANY... [19:50:03] legoktm: it doesn't need the core patch. [19:50:03] (which I'm looking at right now) [19:50:08] legoktm: my patch is shit. [19:50:11] 3Wikimedia / 3General/Unknown: Text '69.130.114.203 is a student in Intellectual Freedom - LIS 493 (course talk).' shown on all IP editor's contributors - 10https://bugzilla.wikimedia.org/66624#c1 (10Danielle Leishman) Created attachment 15654 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15654&acti... [19:50:18] legoktm: it needs the core patch only for supporting one particular type of Url [19:50:22] hm [19:50:23] legoktm: but would be awesome if you can fix it in core as well [19:50:23] ok [19:50:41] 3Wikimedia / 3General/Unknown: Text '69.130.114.203 is a student in Intellectual Freedom - LIS 493 (course talk).' shown on all IP editors' contributions - 10https://bugzilla.wikimedia.org/66624 (10Danielle Leishman) [19:52:56] 3MediaWiki extensions / 3EducationProgram: Text '69.130.114.203 is a student in Intellectual Freedom - LIS 493 (course talk).' shown on all IP editors' contributions - 10https://bugzilla.wikimedia.org/66624 (10Kunal Mehta (Legoktm)) 5UNCO>3NEW p:5Unprio>3High s:5normal>3major [19:54:26] 3MediaWiki extensions / 3EducationProgram: Text '69.130.114.203 is a student in Intellectual Freedom - LIS 493 (course talk).' shown on all IP editors' contributions - 10https://bugzilla.wikimedia.org/66624#c2 (10Huon) It's not necessarily 69.130.114.203; it's the IP address of the person encountering the bug. [19:55:56] 3MediaWiki extensions / 3EducationProgram: Text '69.130.114.203 is a student in Intellectual Freedom - LIS 493 (course talk).' shown on all IP editors' contributions - 10https://bugzilla.wikimedia.org/66624#c3 (10Kunal Mehta (Legoktm)) Trying to remove the user from the course fails with no error message. [19:56:23] (03PS1) 10Paladox: Update jQuery.cookie.js [core] - 10https://gerrit.wikimedia.org/r/139642 [19:56:53] (03Abandoned) 10Paladox: Update jQuery.cookie.js [core] - 10https://gerrit.wikimedia.org/r/139642 (owner: 10Paladox) [19:58:03] YuviPanda: http://cl.ly/image/1l003m093W11 looks kinda ugly. [19:58:32] legoktm: that's the no-js version, right? [19:58:49] legoktm: we should add more styling fixes for it later, I agree. [19:58:54] the JS one looks ok. [19:59:05] legoktm: although I'm going to pester zz_prtksxna to do a design pass on it later. [19:59:44] (03PS1) 10Paladox: Update jQuery.cookie.js [core] - 10https://gerrit.wikimedia.org/r/139643 [19:59:57] (03Abandoned) 10Paladox: Update jQuery.cookie.js [core] - 10https://gerrit.wikimedia.org/r/139643 (owner: 10Paladox) [20:00:28] Hmm... [20:00:41] Huon's comment seems correct. It shows my IP... [20:00:50] Does that mean OP has revealed their IP address? [20:01:37] legoktm: also I couldn't get the rewrite rule to work at all :'( [20:02:14] (03PS8) 1001tonythomas: Implementing VERP functionality hook to core [core] - 10https://gerrit.wikimedia.org/r/138655 (https://bugzilla.wikimedia.org/46640) [20:03:19] Krenair: yes [20:04:56] Krenair: I found the row in the database. [20:05:22] What is it? [20:05:50] there's a user with id=0 [20:06:26] ah... [20:06:32] mysql:wikiadmin@db1052 [enwiki]> select * from ep_users_per_course where upc_user_id=0; [20:06:32] +-------------+---------------+----------+----------------+ [20:06:33] | upc_user_id | upc_course_id | upc_role | upc_time | [20:06:33] +-------------+---------------+----------+----------------+ [20:06:33] | 0 | 359 | 0 | 20140614191200 | [20:06:34] +-------------+---------------+----------+----------------+ [20:06:39] yeah was about to print it here myself [20:06:41] (03PS9) 1001tonythomas: Implementing VERP functionality hook to core [core] - 10https://gerrit.wikimedia.org/r/138655 (https://bugzilla.wikimedia.org/46640) [20:06:50] so much leaking :P [20:07:00] (03PS10) 1001tonythomas: Implementing VERP functionality hook to core [core] - 10https://gerrit.wikimedia.org/r/138655 (https://bugzilla.wikimedia.org/46640) [20:07:17] YuviPanda, you can get it from the labs replicas [20:07:37] Krenair: I was mostly joking [20:07:40] Krenair: so, I'm just going to delete that row... [20:08:07] legoktm, there's another entry in ep_students [20:08:17] (where student_user_id=0) [20:08:36] and maybe other places. I haven't looked into EP's schema before [20:09:42] 3MediaWiki extensions / 3EducationProgram: Text '69.130.114.203 is a student in Intellectual Freedom - LIS 493 (course talk).' shown on all IP editors' contributions - 10https://bugzilla.wikimedia.org/66624#c4 (10Alex Monk) MariaDB [enwiki_p]> select * from ep_students where student_user_id = 0; +-----------... [20:09:50] bah, why does bugzilla limit lines like that [20:11:19] legoktm, seems to have fixed it [20:11:29] (03PS11) 1001tonythomas: Implementing VERP functionality hook to core [core] - 10https://gerrit.wikimedia.org/r/138655 (https://bugzilla.wikimedia.org/46640) [20:11:33] Krenair: I didn't touch ep_students, just the ep_users_per_course one [20:11:41] I still see my IP on https://en.wikipedia.org/wiki/Education_Program:Simmons_College/Intellectual_Freedom_-_LIS_493_%28Summer_2014%29 [20:11:41] okay [20:11:53] Try ep_students as well then? [20:12:23] alex@alex-desktop:/var/www/MediaWiki/Git/core (master)$ php maintenance/eval.php [20:12:24] > var_dump( User::newFromId( 0 )->getName() ); [20:12:24] string(9) "127.0.0.1" [20:12:25] grumble [20:12:51] User::getName has a call to $this->getRequest()->getIP somewhere I think [20:12:59] Is there any good use case for allowing User::newFromId( 0 ) ? [20:13:09] well, I don't know whether it's a caching thing or actually in the table [20:13:57] oh crap. random people's IPs are being cached in varnish. [20:14:14] That's... not good. [20:14:38] It reveals to anyone that an IP has visited this exact page. [20:14:42] 3Wikimedia / 3Site requests: Vectorize all project logos - 10https://bugzilla.wikimedia.org/52019#c106 (10Tomasz W. Kozlowski) Patches mentioned in comment 100, comment 102 and comment 103 updated logos for the following 27 wikis: * https://az.wikibooks.org * https://cy.wikibooks.org * https://e... [20:15:18] 3MediaWiki extensions / 3EducationProgram: Text '69.130.114.203 is a student in Intellectual Freedom - LIS 493 (course talk).' shown on all IP editors' contributions - 10https://bugzilla.wikimedia.org/66624#c5 (10Alex Monk) oh crap. random people's IPs are being cached in varnish. That's.... [20:15:26] 3MediaWiki extensions / 3EducationProgram: Text '69.130.114.203 is a student in Intellectual Freedom - LIS 493 (course talk).' shown on all IP editors' contributions - 10https://bugzilla.wikimedia.org/66624#c6 (10Kunal Mehta (Legoktm)) I ran delete from ep_users_per_course where upc_user_id=0 limit 1 on enwi... [20:16:21] Yikes. Thanks for reporting and poking, legoktm. [20:16:49] legoktm, I assume we will have to purge the cache of all anon contrib pages..? [20:16:59] (03PS12) 1001tonythomas: Implementing VERP functionality hook to core [core] - 10https://gerrit.wikimedia.org/r/138655 (https://bugzilla.wikimedia.org/46640) [20:17:29] dunno [20:17:33] Or maybe that info can be fished out of the apache logs? That DB row is dated from an hour ago [20:17:40] I don't even know if that's possible [20:17:44] or worth it. [20:19:30] is that a security bug [20:20:08] #security [20:21:18] Krenair: lol look at the top of https://en.wikipedia.org/wiki/Special:Students [20:21:33] Withoutaname, think so, it is private information disclosure per oh crap. random people's IPs are being cached in varnish. [20:21:46] #october2013alloveragain [20:22:00] given that it's already on VPT, it's not much of a security "hush hush" thing. [20:22:19] Krenair: I'm just going to delete them out of ep_students too. [20:22:21] wow, it is? [20:22:32] vpt is fast [20:24:08] legoktm: boom! http://sugarfrosties.wmflabs.org/s/7 [20:24:17] Krenair: did it, and it's gone now [20:24:41] now to put that in the vagrant role [20:24:56] YuviPanda: :D [20:25:21] YuviPanda: http://sugarfrosties.wmflabs.org/s/ [20:25:33] something isn't checking for !!NOEXIST!! properly [20:25:39] and it's in a redirect loop now [20:26:17] legoktm: uri=/w/index.php?title=Special:UrlRedirector/!!NOEXIST!! -> uri=/w/index.php, args=title=Special:UrlRedirector/!!NOEXIST!! [20:26:28] it's actually attempting to redirect to !!NOEXIST!! [20:26:37] it should have taken you to UrlShortener instead [20:26:37] hm. [20:26:50] k, I'll fix that after this EP thing. [20:26:54] ok [20:26:57] let me do the vagrant thing [20:28:47] 3MediaWiki / 3Installer: Installer spews notice message from LocalSettingsGenerator - 10https://bugzilla.wikimedia.org/66625 (10Mark A. Hershberger) 3NEW p:3Unprio s:3normal a:3None See https://www.mediawiki.org/wiki/Thread:Project:Support_desk/Notice:_Undefined_index:_createaccount_in_C:%5Cwamp%5Cww... [20:28:50] ragesoss, so I guess we need some fix in the EP extension? [20:29:26] 3MediaWiki extensions / 3EducationProgram: Text '69.130.114.203 is a student in Intellectual Freedom - LIS 493 (course talk).' shown on all IP editors' contributions - 10https://bugzilla.wikimedia.org/66624#c7 (10Kunal Mehta (Legoktm)) Removing the user from ep_students removed them from everywhere I can see... [20:30:37] ragesoss, Krenair: I think a quick fix is just preventing anons from enrolling in courses until the db schema is fixed to also store a user_text (or just decide anons can't enroll) [20:31:10] agreed, either way we need to prevent anons from enrolling, at least for now [20:31:11] 3MediaWiki extensions / 3EducationProgram: Text '69.130.114.203 is a student in Intellectual Freedom - LIS 493 (course talk).' shown on all IP editors' contributions - 10https://bugzilla.wikimedia.org/66624#c8 (10Danielle Leishman) Note, going to be going somewhere where I don't have Internet, so won't be ab... [20:31:48] legoktm: wait, did it happen because logged out users clicked on "enroll", or is it just viewing the page enough to reveal the IP [20:32:01] the first part [20:32:21] (I think) [20:33:27] 3MediaWiki extensions / 3EducationProgram: Text '69.130.114.203 is a student in Intellectual Freedom - LIS 493 (course talk).' shown on all IP editors' contributions - 10https://bugzilla.wikimedia.org/66624#c9 (10Alex Monk) We don't generally wait for the reporter to mark this as fixed. This bug will be left... [20:36:57] (03PS1) 10Legoktm: Update SpecialContributionsBeforeMainOutput hook handler [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/139644 (https://bugzilla.wikimedia.org/66624) [20:37:49] ragesoss, you going to review that? ^ [20:38:59] legoktm, didn't you say this issue also occured at the top of the related course page? [20:39:18] bottom of yes, but I don't really understand how that code works [20:39:25] it's buried inside of a pager I think [20:39:45] I couldn't even grep for the messages to find where they're used. [20:40:18] so I'll let someone else handle that [20:40:39] legoktm, I think the correct solution here is to prevent the enrolment of anonymous users entirely [20:40:51] probably [20:40:57] anons have 'ep-enroll' on enwiki [20:41:27] legoktm, it doesn't matter if they *should* be allowed until the DB schema is fixed [20:41:44] Anons shouldn't have ep-enroll [20:41:44] right. [20:41:45] If they enrol before it's fixed, we will have no record of which IP was enrolled. [20:41:57] ragesoss: https://en.wikipedia.org/wiki/Special:ListGroupRights [20:43:03] legoktm, EP just grants that stuff to * [20:43:15] Doesn't give anything to logged-in users specifically, just * and sysop [20:43:16] (03PS1) 10Legoktm: Don't try to redirect Special:UrlRedirector/!!NOEXIST!! [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139645 [20:43:21] YuviPanda: ^ [20:43:35] (and it's own groups of course) [20:43:57] I'll try to test it today, but I want AndyRussG or someone else with more chops than me. [20:44:16] (03CR) 10Yuvipanda: [C: 04-1] "Hmm, this hsould be checked somewhere else, I think. NOEXIST should only be used for the internal cache, nowhere else." [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139645 (owner: 10Legoktm) [20:44:36] But I'll +2 a permissions fix. [20:45:16] YuviPanda: yeah, you're probably right. [20:45:22] Your patch makes sense to me in general, legoktm. [20:46:00] great [20:46:15] I'll be going afk now for a while though [20:46:27] Can ragesoss deploy? [20:46:40] No [20:47:06] I can merge to master on the extension. [20:47:16] Nothing past that. [20:51:29] legoktm: you should really sign up for deploy rights [20:56:13] (03PS1) 10Withoutaname: Restrict enrollment to the "users" group [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/139646 (https://bugzilla.wikimedia.org/66624) [20:57:35] (03PS1) 10Yuvipanda: Add sample redirect.htaccess [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139648 [20:57:45] legoktm: ^ rewrite rules. Unusre how to specify this in vagrant, so I'm going to let that pass for now [20:58:32] aha, found it I think [20:58:34] YuviPanda, legoktm has db access but no deployment rights? [20:58:46] Krenair: yeah, that's not uncommon [20:58:58] I have readonly db rights, for example [21:02:05] (03PS2) 10Withoutaname: Restrict enrollment to the "users" group [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/139646 (https://bugzilla.wikimedia.org/66624) [21:02:51] YuviPanda: does that mean you could query wikipedia [21:02:59] through wmflabs maybe? [21:03:10] Withoutaname: everyone has access to wmflabs replicas [21:03:11] 3MediaWiki extensions / 3EducationProgram: User's IP is shown as ' is a student in Intellectual Freedom - LIS 493 (course talk).' on all IP editors' contributions - 10https://bugzilla.wikimedia.org/66624 (10Alex Monk) [21:03:21] Withoutaname: some people with NDAs signed have access to the actual replicas, which don't have any redaction [21:03:25] Withoutaname, lol, checkPermissions addition [21:04:20] (03CR) 10Alex Monk: [C: 031] Restrict enrollment to the "users" group (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/139646 (https://bugzilla.wikimedia.org/66624) (owner: 10Withoutaname) [21:06:09] if you really want I guess I could set it to false, but I don't see why [21:11:00] Withoutaname, yeah, that's why I gave +1 anyway [21:15:26] Krenair: oh you know what, take a look at the constructor for SpecialEnroll [21:15:51] "We can not demand ep-enroll here already, since the user might first need to login." <- shouldn't we require ep-enroll as a restriction anyway? [21:16:12] 3MediaWiki extensions / 3EducationProgram: User's IP is shown as ' is a student in Intellectual Freedom - LIS 493 (course talk).' on all IP editors' contributions - 10https://bugzilla.wikimedia.org/66624 (10Andre Klapper) p:5High>3Highes [21:16:45] 3MediaWiki extensions / 3CentralAuth: MultiLock shows extracts from the whole suppress log, instead of only CA-related entries - 10https://bugzilla.wikimedia.org/57253 (10PiRSquared17) a:3PiRSquared17 [21:16:58] 3MediaWiki extensions / 3CentralAuth: Locked accounts should have a box with lock info on Special:Contributions - 10https://bugzilla.wikimedia.org/52674 (10PiRSquared17) a:3PiRSquared17 [21:17:43] (03CR) 10Withoutaname: [C: 031] Update SpecialContributionsBeforeMainOutput hook handler [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/139644 (https://bugzilla.wikimedia.org/66624) (owner: 10Legoktm) [21:19:07] Krenair: is checkpermissions or requirelogin better [21:19:59] checkPermissions sounds appropriate here [21:22:21] (03PS1) 10Yuvipanda: Fix UrlRouter to route to UrlRedirector, not UrlShortener [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139650 [21:22:26] legoktm: ^ as wll [21:23:13] legoktm: aaaand, vagrant! :) ^ [21:23:17] (03PS1) 10Yuvipanda: Add URL Redirect rules for URLShortener [vagrant] - 10https://gerrit.wikimedia.org/r/139651 [21:25:03] (03PS2) 10SPQRobin: Improve page language functions [core] - 10https://gerrit.wikimedia.org/r/137033 [21:25:13] Is that check on Special:Enroll even necessary? [21:25:34] (03PS8) 10Yuvipanda: Validate urls client-side [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139583 (owner: 10Legoktm) [21:25:40] (03PS3) 10Withoutaname: Restrict enrollment to the "users" group [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/139646 (https://bugzilla.wikimedia.org/66624) [21:26:16] (03CR) 10jenkins-bot: [V: 04-1] Improve page language functions [core] - 10https://gerrit.wikimedia.org/r/137033 (owner: 10SPQRobin) [21:26:54] ragesoss, I don't think so... [21:27:27] 3MediaWiki / 3Installer: Installer spews notice message from LocalSettingsGenerator - 10https://bugzilla.wikimedia.org/66625#c1 (10Mark A. Hershberger) hrm... I may have to self-invalid this bug since I don't understand how the person could be hitting LocalSettingsGenerator after the wiki is installed. [21:27:48] (03PS2) 10Yuvipanda: Add sample redirect.htaccess [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139648 [21:27:54] (03PS2) 10Yuvipanda: Fix UrlRouter to route to UrlRedirector, not UrlShortener [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139650 [21:30:00] ragesoss: should I revert the changes to Special:Enroll then? [21:30:07] Withoutaname: yes. [21:30:23] (03CR) 10Shirayuki: "Please keep up to date to translate correctly." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/139078 (owner: 10Shirayuki) [21:30:44] the latest version, which requires ep-enroll to even view the enroll page, would make it very confusing. [21:31:15] it's already designed to prompt people to log in if they are not already. [21:32:28] (03PS4) 10Withoutaname: Restrict enrollment to the "users" group [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/139646 (https://bugzilla.wikimedia.org/66624) [21:32:40] (03CR) 10Bartosz Dziewoński: Validate urls client-side (032 comments) [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139583 (owner: 10Legoktm) [21:32:54] right, so we just go with the groupperms change [21:33:01] the weird thing is that showEnrollmentView already checked for logged-in status before checking for ep-enroll. [21:33:23] the ep-enroll check was there in case someone wanted to configure it even more restrictively. [21:33:33] so I'm not sure how those IPs were sneaking in. [21:34:05] despite the permissions nominally letting IPs enroll, in general, they have never been able to. [21:34:35] 3MediaWiki extensions / 3WikidataRepo: not possible to add no-value and some-value snaks in languages other than English - 10https://bugzilla.wikimedia.org/66626 (10Lydia Pintscher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs It seems adding a no-value and some-value snak is only possible in English. N... [21:35:09] (03PS3) 10Yuvipanda: Fix UrlRouter to route to UrlRedirector, not UrlShortener [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139650 [21:35:11] (03PS3) 10Yuvipanda: Add sample redirect.htaccess [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139648 [21:35:12] 3MediaWiki extensions / 3WikidataRepo: not possible to add no-value and some-value snaks in languages other than English - 10https://bugzilla.wikimedia.org/66626 (10Lydia Pintscher) p:5Unprio>3High [21:35:13] (03PS9) 10Yuvipanda: Validate urls client-side [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139583 (owner: 10Legoktm) [21:35:15] (03CR) 10Yuvipanda: Validate urls client-side (031 comment) [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139583 (owner: 10Legoktm) [21:35:24] MatmaRex: responded to the js comment, and updated PS for the Error comment [21:35:26] 3MediaWiki extensions / 3WikidataRepo: not possible to add no-value and some-value snaks in languages other than English - 10https://bugzilla.wikimedia.org/66626 (10Lydia Pintscher) s:5normal>3major [21:37:01] (03CR) 10Ragesoss: [C: 032] "I'm not sure how anons were getting enrolled, since even though they had ep-enroll permission, there is also a check right before enrollme" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/139646 (https://bugzilla.wikimedia.org/66624) (owner: 10Withoutaname) [21:37:08] (03Merged) 10jenkins-bot: Restrict enrollment to the "users" group [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/139646 (https://bugzilla.wikimedia.org/66624) (owner: 10Withoutaname) [21:40:11] (03CR) 10Bartosz Dziewoński: [C: 032 V: 032] Validate urls client-side [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139583 (owner: 10Legoktm) [21:40:41] MatmaRex: woot, ty! :) [21:40:54] MatmaRex: there's a couple of super trivial dependend patches too, if you want :) [21:46:56] Withoutaname, ragesoss: So assuming it's no longer possible to cause this bug to happen on master, I think we can close the bug [21:47:09] Krenair: I'm not so sure. [21:47:16] I don't know how it was possible in the first place. [21:47:26] so I'm not convinced that this will have fixed it. [21:47:46] couldn't hurt though right? [21:47:50] Certainly, with legoktm's additional patch, the bug itself should go away. [21:48:14] but whether or not anons will still sneak into the database? hard to say until we check. [21:49:07] how is it that the params change in this patch doesn't break anything? https://gerrit.wikimedia.org/r/#/c/139644/1/EducationProgram.hooks.php [21:49:40] does the place where that hook gets called from just know to include whatever parameters the function needs? [21:51:07] (03CR) 10Ragesoss: [C: 031] "I tested this locally this locally, and it doesn't break the feature. The anon check makes sense to me. I don't know enough about what the" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/139644 (https://bugzilla.wikimedia.org/66624) (owner: 10Legoktm) [21:51:08] ragesoss: if ( wfRunHooks( 'SpecialContributionsBeforeMainOutput', array( $id, $userObj, $this ) ) ) { [21:51:21] ragesoss: the parameters were always there, it was EP's hook usage that didn't use them [21:51:34] okay, cool. [21:51:34] (missing parameters in the hook function are just ignored) [21:51:39] that makes sense. [21:53:22] well, for some values of 'always', the two parameters were added on 2013-12-20 in 55869c88 [21:53:37] (03PS1) 10Yuvipanda: Add Mobile Support as well [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/139652 [21:58:33] legoktm: I'm going to go try sleep now. cya later [21:58:41] legoktm: do CR when you have the time. I think this is pretty much all complete. [21:58:52] hmm, except for munging the input URL to make it protocol relative [21:59:15] should strip out the host part before making putting it in db and add back protocol based on current one [22:07:48] * YuviPanda waves away [22:09:56] 3Wikimedia / 3General/Unknown: Video scalers don't seem to be scaling videos anymore - 10https://bugzilla.wikimedia.org/66627 (10Bawolff (Brian Wolff)) 3NEW p:3Unprio s:3major a:3None Video scalers don't seem to be doing much anymore since about friday. When I tried resetting a transcode at commons,... [22:17:56] 3Wikimedia / 3General/Unknown: Video scalers don't seem to be scaling videos anymore - 10https://bugzilla.wikimedia.org/66627#c1 (10Bawolff (Brian Wolff)) Created RT 7693 [22:25:45] is there any way for a userid to change to 0? [22:28:36] ragesoss: Perhaps with the user merge and delete extension if the user is deleted (maybe? I don't really know) [22:28:58] Usually only anons, and people who had their edits imported via special:import (but don't have a local account), have a user id of 0 [22:29:12] 3MediaWiki extensions / 3EducationProgram: User's IP is shown as ' is a student in Intellectual Freedom - LIS 493 (course talk).' on all IP editors' contributions - 10https://bugzilla.wikimedia.org/66624#c13 (10Sage Ross) Kunal's patch (not yet merged) should prevent this specific problem from happening... [22:29:54] thanks bawolff. that doesn't sound like a way user 0 could have gotten into the education program tables. [22:35:04] (03PS2) 10Nemo bis: Make unchanged content on diff to be the default (#d2d2d2) [extensions/Theme] - 10https://gerrit.wikimedia.org/r/138589 (owner: 10Cook879) [22:36:02] (03CR) 10Nemo bis: "Thanks for your patch, welcome! I've tried to make the commit message quicker to understand, per https://www.mediawiki.org/wiki/Gerrit/Com" [extensions/Theme] - 10https://gerrit.wikimedia.org/r/138589 (owner: 10Cook879) [22:36:18] ragesoss, is there another way someone would add students to the course, perhaps in an input field [22:36:28] like an ep-admin [22:39:26] Withoutaname: yes. [22:40:40] Withoutaname: that functionality comes from here: https://gerrit.wikimedia.org/r/#/c/96382/ [22:43:41] Hi ragesoss, just seeing all this stuff, I can take a close look at it in about 2 hours, glad you're on top of it, thanks :) [22:45:28] (03CR) 10Nemo bis: "Thanks for spotting this oversight. The message is not used on any Wikimedia wiki, which may explain why it took so long to notice." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/139399 (https://bugzilla.wikimedia.org/66574) (owner: 10Talktodan) [22:51:30] (03CR) 10PiRSquared17: "Update?" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/127464 (https://bugzilla.wikimedia.org/18182) (owner: 10Legoktm) [23:00:56] 3MediaWiki / 3User blocking: Sp-contributions-blocked-notice isn't shown for range ip blocks - 10https://bugzilla.wikimedia.org/22069#c2 (10PiRSquared17) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 20790 *** [23:00:57] 3MediaWiki / 3Special pages: Block log snippet on Special:Contributions should work for IPs in a range block - 10https://bugzilla.wikimedia.org/20790#c12 (10PiRSquared17) *** Bug 22069 has been marked as a duplicate of this bug. *** [23:22:29] (03CR) 10Vogone: [C: 031] "Still looks good to me, also the improvement to the qqq documentation." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/136520 (owner: 10SPQRobin) [23:37:12] (03PS10) 10Mattflaschen: mw-ui mixins: More colors, more browser helper mixins [core] - 10https://gerrit.wikimedia.org/r/125781 (owner: 10SG) [23:37:36] (03CR) 10Mattflaschen: "Looks good. A couple minor issues (spacing and import method), which I addressed in patch set 10." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/125781 (owner: 10SG) [23:37:54] (03CR) 10Mattflaschen: [C: 032] "Looks good." [core] - 10https://gerrit.wikimedia.org/r/125781 (owner: 10SG) [23:41:59] (03Merged) 10jenkins-bot: mw-ui mixins: More colors, more browser helper mixins [core] - 10https://gerrit.wikimedia.org/r/125781 (owner: 10SG) [23:50:50] (03CR) 10Mattflaschen: "https://gerrit.wikimedia.org/r/#/c/125781/ has been merged, this needs to be updated." [core] - 10https://gerrit.wikimedia.org/r/134964 (owner: 10Robmoen) [23:54:49] (03PS1) 10Gerrit Patch Uploader: Error on GlobalGroupPermssions for group without rights [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/139653 (https://bugzilla.wikimedia.org/40119) [23:54:54] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/139653 (https://bugzilla.wikimedia.org/40119) (owner: 10Gerrit Patch Uploader) [23:56:12] (03CR) 10Mattflaschen: [C: 04-1] "In addition to what I mentioned before, this is a merge commit." [core] - 10https://gerrit.wikimedia.org/r/139470 (owner: 10Paladox)