[00:03:59] 3Wikimedia / 3Bugzilla: Bugzilla's "Links > Weekly Summary" setup is busted (not an extension) - 10https://bugzilla.wikimedia.org/56091#c6 (10This, that and the other) Fixed? [00:33:40] (03CR) 10Bartosz Dziewoński: [C: 031] "Now that I think about it, the tests might be better placed in provideRemapRemappingCases() below. Also, can you format the commit message" [core] - 10https://gerrit.wikimedia.org/r/138286 (owner: 10Foxtrott) [01:09:46] (03CR) 10AndyRussG: [C: 04-1] "Cool, getting there!! :) Please see inline comment..." (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/134598 (https://bugzilla.wikimedia.org/44397) (owner: 10Jlloyd) [01:26:52] (03CR) 10Florianschmidtwelzow: [C: 031] "Example usage in:" [core] - 10https://gerrit.wikimedia.org/r/138108 (https://bugzilla.wikimedia.org/66292) (owner: 10Mattflaschen) [01:55:48] why are protections and moves recorded in the page's history, as opposed to just the log? [01:57:12] So that people can see it when viewing ?action=history [01:57:56] but why are they given that "special" status? [01:57:59] I assume people are interested in log events that "change the page" when viewing the history, like moves and uploads [01:58:27] Compared to say a patrol log entry which doesn't actually change the page [01:58:34] not to mention nobody cares about patrol [01:58:43] it probably also invalidates various caches [01:59:08] meh, that's mostly separate. Just have to update page_touched for that to happen [01:59:34] * bawolff is just speculating here. I don't know what the original design reasons are [01:59:43] for some reason, it really bugs me [02:00:08] (03CR) 10Spage: [C: 04-1] "Even with Mantle change Iaaf01b521be91b53 ("Register all handlebars templates as partials as well"), when I click to sort by jackmcbarn: because they are part of the history of the page? [02:05:43] (03CR) 10Spage: "Also note the FAILURE above from jenkins-bot. You need to set up the project's pre-commit hook (`make installhooks` should do it) so you c" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137957 (owner: 10SG) [02:14:59] 3MediaWiki extensions / 3VectorBeta: CPB: Echo flyout does not open when compact personal bar is enabled - 10https://bugzilla.wikimedia.org/64862#c1 (10Jared Zimmerman (WMF)) echo flyout is still broken on most pages but occasionally works on the main page of wikipedia [02:18:35] jackmcbarn: it's more convenient for casual users [02:19:45] (just guessing) [02:25:12] ugh. caching [02:40:29] 3MediaWiki / 3Database: Descriptionless files (Missing page_latest referential integrity issue) - 10https://bugzilla.wikimedia.org/32551#c52 (10Bawolff (Brian Wolff)) btw, splitting off larger issue of sometimes no description gets posted, to bug 66355. [03:28:43] (03PS1) 10Gnosygnu: v1.6.2.1 [xowa] - 10https://gerrit.wikimedia.org/r/138290 [03:29:47] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/138290 (owner: 10Gnosygnu) [03:45:41] (03CR) 10TTO: "Bumping this patch again. 6 months without a single review makes me sad :(" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/94593 (https://bugzilla.wikimedia.org/56207) (owner: 10TTO) [04:09:14] 3MediaWiki / 3Parser: padleft: padright: and nowiki do not get on (guess same for all parser functions) UNIQ exposed - 10https://bugzilla.wikimedia.org/22555 (10Greg Grossmeier) [04:24:14] 3MediaWiki / 3General/Unknown: Integrate Wikifont into Core/Extension - 10https://bugzilla.wikimedia.org/66138#c8 (10Jared Zimmerman (WMF)) Its not a problem to remove the commons or W marks but if its not problem it will help consistency and performance to keep them in, just let us know. [04:29:26] (03PS1) 10Legoktm: Set proper author in extension credits [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/138293 [04:31:52] thedj: hey [04:34:23] (03PS1) 10Legoktm: Provide proper arguments to ResourceLoaderContext constructor [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/138294 [04:36:52] (03PS1) 10Legoktm: Simplify UnitTestsList hook handler [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/138295 [04:38:23] (03PS2) 10Legoktm: Set proper author in extension credits [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/138293 [04:38:45] (03CR) 10Legoktm: "I got the authors from ." [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/138293 (owner: 10Legoktm) [05:00:31] (03CR) 10Spage: [C: 031] "Helps Flow change Ie2603abd9 get past missing partial error. It's all a bit confusing. The commit message could usefully add a link to htt" [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/138115 (owner: 10SG) [05:01:19] (03CR) 10Prtksxna: [C: 04-1] "TheDJ, what did you change? Please don't remove the documentation string and the namespace of the function." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/134266 (owner: 10TheDJ) [05:03:38] (03CR) 10Spage: "Some minor cleanup of _tplcache, not all related to this patch." (034 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137957 (owner: 10SG) [05:06:51] (03PS1) 10Brian Wolff: Allow using wildcards for minor type in Special:MIMESearch [core] - 10https://gerrit.wikimedia.org/r/138298 [05:29:00] (03PS1) 10Brian Wolff: Fix double output of mimesearch-summary [core] - 10https://gerrit.wikimedia.org/r/138300 [05:30:35] (03PS1) 10Santhosh: Update the dictionary test page as per api changes [services/cxserver] - 10https://gerrit.wikimedia.org/r/138301 [05:42:59] 3MediaWiki / 3JavaScript: Remove all uses of jQuery.browser (tracking) - 10https://bugzilla.wikimedia.org/66097 (10Bawolff (Brian Wolff)) [05:49:00] 3MediaWiki extensions / 3Mantle: Mantle compiles all handlebars templates on initial load - 10https://bugzilla.wikimedia.org/66360 (10spage) 3NEW p:3Unprio s:3enhanc a:3None AIUI, all templates in a RL module turn into mw.mantle.template.add("name.handlebars", "...the template's handlebars '... [06:22:40] Hi! I was working on the shift from php mailer to swiftmailer, we were installing the library via composer, hence in the jenkins level we had some problems. Can someone go through hashar's https://gerrit.wikimedia.org/r/#/c/136897/ and try to get things moving as it is an essential step to get our https://gerrit.wikimedia.org/r/#/c/135290/ patch merged for [06:22:40] my GSoC project ? [06:57:28] 3Analytics / 3Refinery: Hive queries inconsistently failing - 10https://bugzilla.wikimedia.org/65420#c36 (10Oliver Keyes) The same darn thing we've discussed before - the query idling at ~33 percent, getting to 40, and dropping on the reduce portion - just happened a /second/ time on the same request. Is one... [07:06:59] 3MediaWiki extensions / 3WikidataRepo: Special:ListDatatypes and Special:NewProperty are not consistent - 10https://bugzilla.wikimedia.org/53265#c1 (10John Mark Vandenberg) URL now appears in both. Close this bug, or are there two underlying lists that still need to be merged? [07:16:44] 3Wikimedia / 3Wikidata: connect test.wikipedia to wikidata (for lua experimenting) - 10https://bugzilla.wikimedia.org/63619#c3 (10John Mark Vandenberg) Can we connect test.wikipedia with test.wikidata? I'd like to be able to create pages on test.wikipedia, create items for those pages on test.wikidata, and... [07:26:59] 3Analytics / 3Refinery: Hive queries inconsistently failing - 10https://bugzilla.wikimedia.org/65420#c37 (10Oliver Keyes) (appplication_1387838787660_17009 if you want to check out the hive-side internal logs. I should just start running with -v) [07:36:02] (03PS3) 10Rohan013: Replace autofocus="1" /> to autofocus /> on input element in Special:BookSources [core] - 10https://gerrit.wikimedia.org/r/137670 (https://bugzilla.wikimedia.org/66134) [07:49:13] (03PS1) 10Brian Wolff: Only do pop up video player if we actually have a bigger size [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/138307 [07:56:23] (03CR) 10TTO: "See https://www.mediawiki.org/wiki/Requests_for_comment/Debugging_at_production_server" [core] - 10https://gerrit.wikimedia.org/r/119002 (https://bugzilla.wikimedia.org/62718) (owner: 10devunt) [07:56:25] (03CR) 10Ori.livneh: [C: 032] Move event serialization to separate method and add tests [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/133668 (owner: 10Ori.livneh) [07:57:59] (03Merged) 10jenkins-bot: Move event serialization to separate method and add tests [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/133668 (owner: 10Ori.livneh) [07:58:01] (03PS1) 10KartikMistry: Use logDir instead of hardcoded name [services/cxserver] - 10https://gerrit.wikimedia.org/r/138308 [08:00:48] (03PS2) 10Brian Wolff: Have text for play link so it can be clicked by non-css browsers. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/110310 [08:02:35] (03PS2) 10KartikMistry: Use logDir in exceptionHandlers instead of hardcoded path [services/cxserver] - 10https://gerrit.wikimedia.org/r/138308 [08:10:22] (03PS1) 10Wctaiwan: Add parameter for whether to escape table contents [core] - 10https://gerrit.wikimedia.org/r/138309 [08:11:15] 3MediaWiki extensions / 3Mantle: Mantle compiles all handlebars templates on initial load - 10https://bugzilla.wikimedia.org/66360 (10Andre Klapper) [08:12:03] 3Wikimedia / 3General/Unknown: Add index wl_user_notificationtimestamp to table watchlist - 10https://bugzilla.wikimedia.org/66089#c1 (10Sean Pringle) 5NEW>3RESO/FIX Done. [08:34:01] (03CR) 10Amire80: [C: 032] Use logDir in exceptionHandlers instead of hardcoded path [services/cxserver] - 10https://gerrit.wikimedia.org/r/138308 (owner: 10KartikMistry) [08:34:20] (03CR) 10Krinkle: "I mean separate patches for each upstream module, and the source link should be a verifiable permanent url (not the home page of the libra" [core] - 10https://gerrit.wikimedia.org/r/138165 (owner: 10Paladox) [08:34:26] (03Merged) 10jenkins-bot: Use logDir in exceptionHandlers instead of hardcoded path [services/cxserver] - 10https://gerrit.wikimedia.org/r/138308 (owner: 10KartikMistry) [08:45:37] ah, fun with js - "Uncaught TypeError: undefined is not a function " [09:20:31] (03CR) 10Frédéric Wang: [C: 031] "OK, that looks good with the new test. I'll +2 tomorrow if nobody else complains and if the typos below are fixed." (032 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/138023 (owner: 10Physikerwelt) [09:23:41] 3MediaWiki / 3Skin and page rendering: Fonts in IE6/7 too big when scaling font size - 10https://bugzilla.wikimedia.org/24515#c19 (10Andre Klapper) That's not "really" a patch, due to the first lines which are probably meant to be a comment instead? Also, any chance to upload this to Gerrit via http://tools... [09:24:32] 3MediaWiki extensions / 3Scribunto: mw.title should avoid unnecessary expensive work - 10https://bugzilla.wikimedia.org/66328 (10Andre Klapper) p:5Unprio>3Normal [09:24:46] 3MediaWiki / 3Skin and page rendering: mediawiki.hlist.css/js are not using localized punctuations - 10https://bugzilla.wikimedia.org/66336 (10Andre Klapper) p:5Unprio>3Normal [09:26:46] 3MediaWiki extensions / 3CharInsert: Some of the hebrew characters are not in proper order - 10https://bugzilla.wikimedia.org/66348 (10Andre Klapper) p:5Unprio>3High [09:27:02] 3MediaWiki / 3Parser: RTL/bidirectional issues (tracking) - 10https://bugzilla.wikimedia.org/745 (10Andre Klapper) [09:27:14] 3Wikimedia / 3Wikidata: monitor dispatch stats - 10https://bugzilla.wikimedia.org/65291#c4 (10Christopher Johnson) https://gerrit.wikimedia.org/r/#/c/136095/10 [09:34:47] 3MediaWiki / 3General/Unknown: "Error creating thumbnail: proc_open() is disabled"; did not seem to happen in previous versions. - 10https://bugzilla.wikimedia.org/66349#c1 (10Andre Klapper) Is proc_open listed under disable_functions in php.ini? If so, you might want to remove it. Might also be a question... [09:35:00] 3MediaWiki / 3Search: Make "Remember selection for future searches" checkbox prettier - 10https://bugzilla.wikimedia.org/66342 (10Andre Klapper) p:5Unprio>3Low [09:36:01] 3Wikimedia / 3Mailing lists: Ban *@utdliving.com from sending any email to the mailman server - 10https://bugzilla.wikimedia.org/66318 (10Andre Klapper) p:5Unprio>3Normal [09:36:30] 3MediaWiki / 3Special pages: Make a special page to expose iwbacklinks - 10https://bugzilla.wikimedia.org/66293 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [09:37:14] 3MediaWiki extensions / 3GlobalBlocking: Lego work using in log entries - 10https://bugzilla.wikimedia.org/66308#c1 (10Andre Klapper) p:5Unprio>3Low I have no idea what "Lego work" is and where to see the log entries. If anybody wants to work on this ticket, more information would be we... [09:37:44] 3MediaWiki / 3Skin and page rendering: Come up with a sane way of including screenshots with skins and displaying them in the UI - 10https://bugzilla.wikimedia.org/66295 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [09:38:59] 3MediaWiki extensions / 3CharInsert: Some of the hebrew characters are not in proper order - 10https://bugzilla.wikimedia.org/66348#c2 (10Amir E. Aharoni) On which site do you see this exactly? In which skin? CharInsert hasn't really been updated in a long while, and I cannot reproduce this anywhere, so I'm... [09:39:44] 3MediaWiki / 3Skin and page rendering: TOC looks crammed in Firefox on Android - 10https://bugzilla.wikimedia.org/66314#c1 (10Andre Klapper) Thanks for taking the time to report this! Which Firefox version is this? Which hardware and Android version? In general I wonder whether this shouldn't pick up the m... [09:42:44] 3MediaWiki extensions / 3Collection: Empty bullets in ePub credits section - 10https://bugzilla.wikimedia.org/64356#c2 (10Andre Klapper) p:5Unprio>3Low If credits are missing, the priority can be increased. [09:45:59] 3MediaWiki extensions / 3GlobalBlocking: Lego work using in locally disabled block entries - 10https://bugzilla.wikimedia.org/66308#c2 (10Liangent) (In reply to Andre Klapper from comment #1) > I have no idea what "Lego work" is and where to see the log entries. > If anybody wants to work o... [09:49:20] 3MediaWiki / 3Skin and page rendering: Bug 65434 appears on the "More" tab - 10https://bugzilla.wikimedia.org/66363 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Click on the arrow to see it. [09:50:29] 3MediaWiki / 3Skin and page rendering: Bug 65434 appears on the "More" tab - 10https://bugzilla.wikimedia.org/66363#c1 (10Liangent) and if you want to see it growing, click on it then keep pressing "Enter" :P [09:50:44] 3MediaWiki extensions / 3AbuseFilter: Add ability to detect deleted revisions - 10https://bugzilla.wikimedia.org/20892#c1 (10Andre Klapper) *** Bug 66310 has been marked as a duplicate of this bug. *** [09:50:48] 3MediaWiki extensions / 3AbuseFilter: Add "is new page" and "page was deleted before / has delete log entry" functions to Abuse filter - 10https://bugzilla.wikimedia.org/66310#c1 (10Andre Klapper) 5NEW>3RESO/DUP Hi Danny. Thanks for taking the time to report this! This particular problem has already been... [09:50:59] 3MediaWiki extensions / 3AbuseFilter: AbuseFilter should be able to identify previously-deleted pages - 10https://bugzilla.wikimedia.org/66031#c1 (10Andre Klapper) 5NEW>3RESO/DUP Hi Huji. Thanks for taking the time to report this! This particular problem has already been reported into our bug tracking sy... [09:50:59] 3MediaWiki extensions / 3AbuseFilter: Add ability to detect deleted revisions - 10https://bugzilla.wikimedia.org/20892#c2 (10Andre Klapper) *** Bug 66031 has been marked as a duplicate of this bug. *** [09:57:59] 3MediaWiki extensions / 3WikidataRepo: not possible to remove sitelinks using Special:SetSitelink - 10https://bugzilla.wikimedia.org/62707 (10Bene*) 5NEW>3RESO/FIX [09:58:17] 3MediaWiki / 3Skin and page rendering: Unexpected text "Variants" appears in #p-variants - 10https://bugzilla.wikimedia.org/66364 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Looks like a side effect of showing "More" for #p-cactions. Note that there's already a label #mw-vector-current-variant so... [09:59:29] 3MediaWiki / 3Skin and page rendering: Bug 65434 appears on the "More" arrow and "Variants" arrow - 10https://bugzilla.wikimedia.org/66363#c2 (10Liangent) #p-cactions and #p-variants. [09:59:43] 3MediaWiki / 3JobQueue: Special:RunJobs recursively calling Special:RunJobs again (?) - 10https://bugzilla.wikimedia.org/66225 (10Andre Klapper) p:5Unprio>3High [10:00:15] 3MediaWiki / 3Skin and page rendering: Default image alignment is not applied to parsoid-output figure elements - 10https://bugzilla.wikimedia.org/66282 (10Andre Klapper) p:5Unprio>3Normal [10:00:29] 3MediaWiki extensions / 3AbuseFilter: message preview on Special:AbuseFilter does not handle $2 - 10https://bugzilla.wikimedia.org/66351 (10Andre Klapper) p:5Unprio>3Normal [10:01:14] 3MediaWiki extensions / 3AbuseFilter: Add ability to detect deleted revisions and page creation - 10https://bugzilla.wikimedia.org/20892 (10Danny B.) [10:04:04] (03CR) 10Rtdwivedi: [C: 031] Introduces a JSON serialization for Page: pages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/132935 (owner: 10Tpt) [10:18:35] (03PS1) 10Deepali: Ease migration of existing books [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/138316 (https://bugzilla.wikimedia.org/53286) [10:18:39] (03CR) 10jenkins-bot: [V: 04-1] Ease migration of existing books [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/138316 (https://bugzilla.wikimedia.org/53286) (owner: 10Deepali) [10:27:50] (03PS2) 10Deepali: Ease migration of existing books [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/138316 (https://bugzilla.wikimedia.org/53286) [10:47:50] 3MediaWiki / 3JavaScript: On click to thanks cannot read property msie of undefined (jquery.ui) - 10https://bugzilla.wikimedia.org/66365 (10Florian) 3NEW p:3Unprio s:3major a:3None Created attachment 15598 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15598&action=edit Console output On act... [10:48:37] (03PS1) 10Prtksxna: Fix links [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/138319 [10:48:39] (03PS1) 10Prtksxna: Add style [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/138320 [10:49:59] 3Wikimedia / 3Wikidata: monitor dispatch stats - 10https://bugzilla.wikimedia.org/65291 (10Andre Klapper) 5REOP>3PATC [10:50:44] 3MediaWiki extensions / 3WikidataRepo: Special:ListDatatypes and Special:NewProperty are not consistent - 10https://bugzilla.wikimedia.org/53265#c2 (10Lydia Pintscher) Thanks for checking :) The issue is that one of them shows what is actually configure on the wiki and the other one shows what is available... [10:51:59] 3MediaWiki / 3JavaScript: Upgrade jQuery from 1.8.x to 1.11.x - 10https://bugzilla.wikimedia.org/44740 (10Florian) [10:52:00] 3MediaWiki / 3JavaScript: On click to thanks cannot read property msie of undefined (jquery.ui) - 10https://bugzilla.wikimedia.org/66365 (10Florian) p:5Unprio>3High [10:52:00] 3MediaWiki / 3JavaScript: Upgrade jQuery UI from 1.8 to 1.9 - 10https://bugzilla.wikimedia.org/47076 (10Florian) [11:21:46] 3MediaWiki / 3JavaScript: Upgrade jQuery from 1.8.x to 1.11.x - 10https://bugzilla.wikimedia.org/44740 (10Jesús Martínez Novo (Ciencia Al Poder)) [11:21:48] 3MediaWiki / 3JavaScript: On click to thanks cannot read property msie of undefined (jquery.ui) - 10https://bugzilla.wikimedia.org/66365#c1 (10Jesús Martínez Novo (Ciencia Al Poder)) Any access to jquery.ui.dialog is now broken in master :S [11:21:48] 3MediaWiki / 3JavaScript: Upgrade jQuery UI from 1.8 to 1.9 - 10https://bugzilla.wikimedia.org/47076 (10Jesús Martínez Novo (Ciencia Al Poder)) [11:21:59] 3MediaWiki / 3Skin and page rendering: TOC looks crammed in Firefox on Android - 10https://bugzilla.wikimedia.org/66314#c2 (10Daniel Jonsson) Firefox Aurora, version 31. It renders in the same way in the latest stable version of Firefox, version 29. However, it has been like this for at least several months,... [11:37:46] 3MediaWiki extensions / 3Translate: Translate extension should list the authors and/or the source of each translation to respect the CC-BY-SA license - 10https://bugzilla.wikimedia.org/62890#c3 (10Andre Klapper) Luis: License related question - any recommendation for this by Legal? (Feel free to unCC yoursel... [11:44:15] 3MediaWiki / 3JavaScript: Remove all uses of jQuery.browser (tracking) - 10https://bugzilla.wikimedia.org/66097 (10Florian) [11:44:15] 3MediaWiki / 3JavaScript: On click to thanks cannot read property msie of undefined (jquery.ui) - 10https://bugzilla.wikimedia.org/66365 (10Florian) [11:46:18] (03PS4) 10Foxtrott: Fix "CSSMin url() value remapping not working in certain obscure cases" [core] - 10https://gerrit.wikimedia.org/r/138286 (https://bugzilla.wikimedia.org/60077) [11:47:13] (03CR) 10Phe: [C: 031] Introduces a JSON serialization for Page: pages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/132935 (owner: 10Tpt) [11:49:50] (03CR) 10Tpt: [C: 032] "Reviewed by Rtdwivedi and Phe" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/132935 (owner: 10Tpt) [11:50:07] (03Merged) 10jenkins-bot: Introduces a JSON serialization for Page: pages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/132935 (owner: 10Tpt) [11:51:32] (03CR) 10Phe: "http://sandbox.onlinephpfunctions.com/code/f268e8203d0d122f7dd3f4cd4201d399d7bf1a34" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/135546 (owner: 10Krinkle) [12:02:14] (03PS1) 10Florianschmidtwelzow: Replace use of jQuery.browser [core] - 10https://gerrit.wikimedia.org/r/138325 (https://bugzilla.wikimedia.org/66365) [12:05:46] (03CR) 10Martineznovo: [C: 04-1] "We shouldn't modify external libraries. Instead, we should upgrade jquery.ui, which is being done in I0e10b42fb7c25b9d4704719f21c44c08f36d" [core] - 10https://gerrit.wikimedia.org/r/138325 (https://bugzilla.wikimedia.org/66365) (owner: 10Florianschmidtwelzow) [12:09:46] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Ah, you're right!" [core] - 10https://gerrit.wikimedia.org/r/138325 (https://bugzilla.wikimedia.org/66365) (owner: 10Florianschmidtwelzow) [12:10:41] (03Abandoned) 10Florianschmidtwelzow: Replace use of jQuery.browser [core] - 10https://gerrit.wikimedia.org/r/138325 (https://bugzilla.wikimedia.org/66365) (owner: 10Florianschmidtwelzow) [12:11:15] 3MediaWiki / 3JavaScript: On click to thanks cannot read property msie of undefined (jquery.ui) - 10https://bugzilla.wikimedia.org/66365#c4 (10Florian) See: https://gerrit.wikimedia.org/r/#/c/137471/ [12:15:07] (03Draft1) 10QChris: Quote CSS urls upon need [core] - 10https://gerrit.wikimedia.org/r/138326 [12:20:14] (03CR) 10Phe: [C: 031] Adds Pagination abstraction [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/132233 (owner: 10Tpt) [12:24:35] (03PS1) 10Matthias Mullie: Use ConfirmEdit as SpamFilter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/138328 [12:32:38] 3MediaWiki extensions / 3BookManagerv2: Import chapter list from existing book in the same order as on the contents page - 10https://bugzilla.wikimedia.org/66367 (10Deepali Jain) 3NEW p:3Unprio s:3normal a:3None Currently, when the list of chapters is imported from an old contents page of existing bo... [12:39:00] 3MediaWiki extensions / 3WikidataRepo: not possible to switch to Julian calendar model - 10https://bugzilla.wikimedia.org/65847 (10Lydia Pintscher) [12:40:45] 3MediaWiki extensions / 3WikidataRepo: wblinktitles id in api response does not start with a q, it is a raw int id - 10https://bugzilla.wikimedia.org/52732#c8 (10Lydia Pintscher) Katie: Might need adding to deployment notes and possibly wider announcement? [12:49:00] 3MediaWiki extensions / 3WikidataRepo: EntitySelector not working on MainPage (e.g. for search box) - 10https://bugzilla.wikimedia.org/66257 (10Lydia Pintscher) 5NEW>3PATC [12:51:29] 3MediaWiki extensions / 3WikidataClient: Merging items with same referenced claim is not possible - 10https://bugzilla.wikimedia.org/63595 (10Lydia Pintscher) s:5normal>3major [12:52:00] 3MediaWiki extensions / 3WikidataClient: Merging items with same referenced claim is not possible - 10https://bugzilla.wikimedia.org/63595 (10Lydia Pintscher) [12:57:25] (03PS1) 10Matthias Mullie: Block should just use Status::getMessage instead of trying to build that itself [extensions/Flow] - 10https://gerrit.wikimedia.org/r/138330 [12:57:28] (03PS1) 10Matthias Mullie: POST actions can also be rendered [extensions/Flow] - 10https://gerrit.wikimedia.org/r/138331 [12:57:30] 3Wikimedia / 3Wikidata: Rollback does not work on items - 10https://bugzilla.wikimedia.org/65831#c10 (10Lydia Pintscher) Tobi: Is this all done now? I think we should open a separate ticket for the investigation as proposed by Daniel. [12:57:33] (03PS1) 10Matthias Mullie: [WIP] ConfirmEdit, captcha version [extensions/Flow] - 10https://gerrit.wikimedia.org/r/138332 [12:57:36] (03CR) 10jenkins-bot: [V: 04-1] Block should just use Status::getMessage instead of trying to build that itself [extensions/Flow] - 10https://gerrit.wikimedia.org/r/138330 (owner: 10Matthias Mullie) [13:01:59] 3MediaWiki extensions / 3Translate: Translation page does not contain the latest translations/last translation - 10https://bugzilla.wikimedia.org/46716#c17 (10Nemo) I just run touch.py on all mediawiki.org "Translations" pages, about 70k total: over 5.5k updates were made, meaning almost 10 % of translation... [13:24:03] 3MediaWiki extensions / 3Translate: Special:PageMigration should ignore trailing space in title field - 10https://bugzilla.wikimedia.org/66368 (10Nemo) 3NEW p:3Unprio s:3enhanc a:3Pratik Lahoti 1) http://pagemigration.wmflabs.org/wiki/Special:PageMigration 2) Enter "Extension:AntiSpoof " (with space)... [13:24:14] 3MediaWiki extensions / 3Translate: Special page for migration of legacy translation pages (tracking) - 10https://bugzilla.wikimedia.org/65740 (10Nemo) [13:24:29] (03PS1) 10Jack Phoenix: z-index fun to make the search suggestions list display properly. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/138336 [13:24:44] (03CR) 10Jack Phoenix: [C: 032 V: 032] z-index fun to make the search suggestions list display properly. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/138336 (owner: 10Jack Phoenix) [13:51:16] 3Analytics / 3General/Unknown: Requests for 'undefined' page increasing on wikipedias - 10https://bugzilla.wikimedia.org/66352#c3 (10christian) (In reply to Oliver Keyes from comment #2) > What time are we deploying at these days? 15:00 UTC onwards. I of course checked the wikitech's Deployments page, but s... [14:14:44] (03PS1) 10Aude: Update Wikidata, fixes for entity suggester [core] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/138340 [14:22:21] (03PS37) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [14:22:47] (03PS8) 10Umherirrender: Add dynamic maxlength to Special:RevisionDelete [core] - 10https://gerrit.wikimedia.org/r/135197 (https://bugzilla.wikimedia.org/34467) [14:25:25] (03PS38) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [14:51:44] 3MediaWiki extensions / 3AbuseFilter: Add ability to detect deleted revisions and page creation - 10https://bugzilla.wikimedia.org/20892#c3 (10Jackmcbarn) I think the best way to implement this would be variables containing the number of live and deleted revisions. [14:52:14] 3Wikimedia / 3Extension setup: Enable FlaggedRevs extension on ckb.wikipedia - 10https://bugzilla.wikimedia.org/65809 (10Calak) 5PATC>3RESO/FIX [14:53:29] (03PS39) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [14:55:01] 3Wikimedia / 3Site requests: Create wikimania2015wiki - 10https://bugzilla.wikimedia.org/66370 (10James Forrester) 3NEW p:3Unprio s:3normal a:3None It's in about a year, so we should probably get the ball rolling. Same config as normal. Happy to be initial bureaucrat to get things bootstrapped. [14:55:59] 3MediaWiki extensions / 3WikidataClient: Specifiable Wikidata context for LUA debug console - 10https://bugzilla.wikimedia.org/63623#c9 (10Jackmcbarn) Note that once https://gerrit.wikimedia.org/r/#/c/124473/ is merged, a user script will allow user of the Lua console on pages that aren't modules, which sort... [14:56:06] gah, i hate making typos on bugzilla because i can't fix them [14:56:14] (03CR) 10Manybubbles: [C: 032] Upgrade to Elasticsearch 1.2.1 [vagrant] - 10https://gerrit.wikimedia.org/r/137375 (owner: 10Manybubbles) [14:56:20] (03Merged) 10jenkins-bot: Upgrade to Elasticsearch 1.2.1 [vagrant] - 10https://gerrit.wikimedia.org/r/137375 (owner: 10Manybubbles) [15:01:04] (03CR) 10Anomie: [C: 032] "SWAT deploy" [core] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/137984 (owner: 10Jforrester) [15:01:29] (03CR) 10Anomie: "SWAT deploy" [core] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137983 (owner: 10Jforrester) [15:02:29] (03CR) 10Anomie: [C: 032] Update VisualEditor to I903d2892 [core] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137983 (owner: 10Jforrester) [15:04:42] (03Merged) 10jenkins-bot: Update VisualEditor to I903d2892 and I82f624fa [core] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/137984 (owner: 10Jforrester) [15:05:49] (03Merged) 10jenkins-bot: Update VisualEditor to I903d2892 [core] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137983 (owner: 10Jforrester) [15:09:16] (03PS11) 10Paladox: Add support for request account link [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/134624 [15:12:59] 3Wikimedia / 3Site requests: Deploy TemplateData's GUI editing tool to Portuguese Wikipedia - 10https://bugzilla.wikimedia.org/66255#c4 (10James Forrester) 5PATC>3RESO/FIX Now live. [15:13:02] (03CR) 10Anomie: [C: 032] "SWAT deploy" [core] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/138340 (owner: 10Aude) [15:16:34] (03Merged) 10jenkins-bot: Update Wikidata, fixes for entity suggester [core] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/138340 (owner: 10Aude) [15:34:23] (03PS1) 10Zfilipin: Remove unneeded mediawiki_user variable [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/138346 [15:35:25] (03PS1) 10Mvolz: Add xpath and xmldom for scraping in package.json [services/cite-from-id] - 10https://gerrit.wikimedia.org/r/138348 [15:35:27] (03PS1) 10Mvolz: Supplies methods to send requests to a Zotero serv [services/cite-from-id] - 10https://gerrit.wikimedia.org/r/138349 [15:37:50] (03Abandoned) 10Mvolz: Add xpath and xmldom for scraping in package.json [services/cite-from-id] - 10https://gerrit.wikimedia.org/r/138348 (owner: 10Mvolz) [15:48:01] (03CR) 10Bartosz Dziewoński: Quote CSS urls upon need (031 comment) [core] - 10https://gerrit.wikimedia.org/r/138326 (owner: 10QChris) [15:50:54] (03PS2) 10QChris: Quote CSS urls upon need [core] - 10https://gerrit.wikimedia.org/r/138326 [15:51:42] (03PS3) 10Bartosz Dziewoński: ResourceLoaderLESSFunctions: Quote CSS data: URIs if needed [core] - 10https://gerrit.wikimedia.org/r/138326 (owner: 10QChris) [15:51:53] (03CR) 10QChris: ResourceLoaderLESSFunctions: Quote CSS data: URIs if needed (031 comment) [core] - 10https://gerrit.wikimedia.org/r/138326 (owner: 10QChris) [15:52:21] (03CR) 10Bartosz Dziewoński: [C: 031] "Hah, I was just making this change too :)" [core] - 10https://gerrit.wikimedia.org/r/138326 (owner: 10QChris) [15:52:48] (03CR) 10QChris: "Ok. Surrendering it to you :-)" [core] - 10https://gerrit.wikimedia.org/r/138326 (owner: 10QChris) [15:54:46] 3Wikimedia / 3Extension setup: Enable Hovercards on se.wikimedia.org (Swedish chapter wiki) - 10https://bugzilla.wikimedia.org/66374 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None See this: http://lists.wikimedia.org/pipermail/wikitech-ambassadors/2014-June/000735.html In a nutshell, Jan Ainali, the... [15:58:16] (03CR) 10Bartosz Dziewoński: [C: 032] Upgrade jQuery UI from 1.8.24 to 1.9.2 [core] - 10https://gerrit.wikimedia.org/r/137471 (https://bugzilla.wikimedia.org/47076) (owner: 10Krinkle) [16:01:52] (03Merged) 10jenkins-bot: Upgrade jQuery UI from 1.8.24 to 1.9.2 [core] - 10https://gerrit.wikimedia.org/r/137471 (https://bugzilla.wikimedia.org/47076) (owner: 10Krinkle) [16:02:16] 3MediaWiki / 3JavaScript: Upgrade jQuery UI from 1.8 to 1.9 - 10https://bugzilla.wikimedia.org/47076 (10Bartosz Dziewoński) 5PATC>3RESO/FIX [16:02:31] 3MediaWiki / 3JavaScript: On click to thanks cannot read property msie of undefined (jquery.ui) - 10https://bugzilla.wikimedia.org/66365#c5 (10Bartosz Dziewoński) 5PATC>3RESO/FIX a:3Krinkle Should be fixed by upgrading jQuery UI. [16:11:26] (03PS2) 10Bartosz Dziewoński: Vector: Restore old focus animation on the "More" dropdown [core] - 10https://gerrit.wikimedia.org/r/137715 (https://bugzilla.wikimedia.org/66363) [16:11:33] 3MediaWiki / 3Skin and page rendering: Bug 65434 appears on the "More" arrow and "Variants" arrow - 10https://bugzilla.wikimedia.org/66363#c3 (10Bartosz Dziewoński) a:3Bartosz Dziewoński Known, a patch is pending. [16:11:44] (03PS1) 10Zfilipin: WIP Running tests at Sauce Labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/138351 [16:12:00] (03CR) 10Bartosz Dziewoński: "Someone, and preferably not me, should totally merge and backport this already because people are starting to file bugs. :)" [core] - 10https://gerrit.wikimedia.org/r/137715 (https://bugzilla.wikimedia.org/66363) (owner: 10Bartosz Dziewoński) [16:14:07] 3MediaWiki / 3Skin and page rendering: Unexpected text "Variants" appears in #p-variants - 10https://bugzilla.wikimedia.org/66364#c1 (10Bartosz Dziewoński) p:5Unprio>3High a:3Bartosz Dziewoński Arghrghrghrgh. Why do we not have https://gerrit.wikimedia.org/r/#/c/72053/ yet so that this will stop happen... [16:18:29] 3MediaWiki extensions / 3Translate: Translate extension should list the authors and/or the source of each translation to respect the CC-BY-SA license - 10https://bugzilla.wikimedia.org/62890#c4 (10Luis Villa (WMF Legal)) Where the original work is substantial enough to be copyrightable (which is certainly th... [16:19:44] 3MediaWiki extensions / 3Scribunto: __call metamethod doesn't work on elements of the export table - 10https://bugzilla.wikimedia.org/66278#c3 (10Brad Jorsch) OTOH, you could as easily write that with a function getContinent, and at the same time avoid confusing people into thinking they could do "{{#invoke:... [16:22:34] (03PS2) 10Anomie: API: Add prop=unreadcount to ApiQueryUserInfo [core] - 10https://gerrit.wikimedia.org/r/137150 (https://bugzilla.wikimedia.org/65246) [16:23:29] (03PS2) 10Anomie: API: Add show=unread to ApiQueryWatchlist [core] - 10https://gerrit.wikimedia.org/r/137147 (https://bugzilla.wikimedia.org/65246) [16:24:14] (03CR) 10Anomie: "Bug 66089 is closed, so this should be good to merge once reviewed." [core] - 10https://gerrit.wikimedia.org/r/137150 (https://bugzilla.wikimedia.org/65246) (owner: 10Anomie) [16:25:17] 3MediaWiki extensions / 3Translate: Failed to deserialize - 10https://bugzilla.wikimedia.org/47628 (10Marius Hoch) a:5Wikidata bugs>3None [16:27:00] 3MediaWiki / 3User preferences: Automatic substring of templates in user signature is easily circumvented - 10https://bugzilla.wikimedia.org/12495 (10Andre Klapper) [16:28:14] 3MediaWiki / 3Parser: Magic word for ToC including only sections after a certain point - 10https://bugzilla.wikimedia.org/12193#c2 (10Andre Klapper) p:5Low>3Lowest The link to the description page shows the request by Nukeless... I'd love to know what's the actual usecase for this. [16:30:28] (03PS1) 10Tpt: Revert "Introduces a JSON serialization for Page: pages" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/138354 [16:30:53] (03CR) 10Tpt: [C: 032] Revert "Introduces a JSON serialization for Page: pages" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/138354 (owner: 10Tpt) [16:31:06] (03Merged) 10jenkins-bot: Revert "Introduces a JSON serialization for Page: pages" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/138354 (owner: 10Tpt) [16:35:15] 3MediaWiki extensions / 3OAuth: Make metawiki the central OAuth wiki - 10https://bugzilla.wikimedia.org/57336#c14 (10Chris Steipp) I think it's highest in that it's the project I work on if I have time. The reality is nobody is directly assigned to work on OAuth right now, so it's really just me in my spare... [16:36:12] (03PS1) 10Tpt: Introduces a JSON serialization for Page: pages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/138355 [16:36:58] (03CR) 10Tpt: "I've created an other change Iaba368f7725a1564c94c2d71dc4acef932d1473e with the same content" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/132935 (owner: 10Tpt) [16:37:02] andre__: I think your change to bug 12495 is not correct. The issue is "substing" (subst:-ing), not sub-string :P [16:37:11] is there a template saying "1.24" on mw.org? [16:37:32] 3MediaWiki / 3Page editing: test2wiki: link lightbox empty - 10https://bugzilla.wikimedia.org/66376 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Created attachment 15603 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15603&action=edit Link lightbox is empty On any page on http://test2.... [16:37:48] liangent: There's {{MW version}} IIRC [16:38:59] 3MediaWiki extensions / 3Scribunto: mw.title should avoid unnecessary expensive work - 10https://bugzilla.wikimedia.org/66328#c2 (10Brad Jorsch) Unfortunately, the expensive work seems to be necessary. To properly purge pages that refer to the title if the page gets created or deleted, we need to record a li... [16:39:09] Vulpix: hm that template shows a box and expects me to write "1.24" in it [16:40:32] liangent: https://www.mediawiki.org/wiki/Template:MW_1.24 is a shorthand. [16:41:04] if you want an inline version, there's https://www.mediawiki.org/wiki/Template:MW_version-inline [16:41:15] 3MediaWiki extensions / 3Scribunto: mw.title should avoid unnecessary expensive work - 10https://bugzilla.wikimedia.org/66328#c3 (10Liangent) I wonder if it's possible to do lazy loading in Lua. Obvious it's not needed to load page_id if I want to extract the namespace of a title. [16:41:56] Vulpix: well what I want is something like https://www.mediawiki.org/wiki/Template:MW_stable_branch_number [16:41:58] o hi liangent [16:42:05] MatmaRex: hi [16:42:14] who the fuck came up with the retarded idea of using a h3 for the additional variants label? [16:42:17] OH WAIT THAT WAS ME [16:42:23] * MatmaRex slaps MatmaRex around a bit with a large trout [16:42:25] lol [16:43:48] liangent: maybe this one, but looks outdated :P https://www.mediawiki.org/wiki/Template:MW_Alpha_branch_number [16:43:51] (03PS1) 10Bartosz Dziewoński: Vector: Hide the superfluous "Variants" menu label again [core] - 10https://gerrit.wikimedia.org/r/138356 (https://bugzilla.wikimedia.org/66364) [16:43:56] same with https://www.mediawiki.org/wiki/Template:MW_Alpha_release_number [16:44:00] liangent: testing appreciated ^ [16:44:06] thanks for the bug report :/ [16:44:26] Vulpix: yeah I found that [16:44:45] (03CR) 10jenkins-bot: [V: 04-1] Vector: Hide the superfluous "Variants" menu label again [core] - 10https://gerrit.wikimedia.org/r/138356 (https://bugzilla.wikimedia.org/66364) (owner: 10Bartosz Dziewoński) [16:44:46] and it seems someone created it arbitrarily [16:44:51] so nobody maintains it later [16:45:03] liangent: the worst of that is that it's being used :O [16:45:42] The "alpha" should be lowercase, also [16:46:36] (03PS2) 10Bartosz Dziewoński: Vector: Hide the superfluous "Variants" menu label again [core] - 10https://gerrit.wikimedia.org/r/138356 (https://bugzilla.wikimedia.org/66364) [16:47:26] greg-g: https://gerrit.wikimedia.org/r/#/c/137715/ and https://gerrit.wikimedia.org/r/#/c/138356/ will need to be backported to current wmf version :( [16:47:35] Vulpix, uh. thanks! [16:48:14] 3MediaWiki / 3User preferences: Automatic subst-ing of templates in user signature is easily circumvented - 10https://bugzilla.wikimedia.org/12495 (10Andre Klapper) [16:49:32] 3Wikimedia / 3Site requests: Allow crats to grant TA on legalteamwiki - 10https://bugzilla.wikimedia.org/66377 (10John F. Lewis) 3ASSI p:3Unprio s:3normal a:3John F. Lewis Per an request on IRC; James forgot to ask for translation administrator to be assignable (and revoke-able) by local bureaucrats... [16:49:33] MatmaRex: luckily 1.24wmf8 hasn't been deployed yet [16:49:42] not deployed to "content" sites [16:49:59] 3MediaWiki / 3Special pages: Special:RecentChanges should use MediaWiki ui - 10https://bugzilla.wikimedia.org/66373#c3 (10Jon) This should be changed in core. We hope to use MediaWiki ui everywhere for consistency. [16:50:10] liangent: yeah [16:50:21] MatmaRex: does https://gerrit.wikimedia.org/r/#/c/138356/ really depend on https://gerrit.wikimedia.org/r/#/c/137715 ? [16:50:21] liangent: why do we even have the two labels for the Variants menu? [16:50:37] (03CR) 10Mattflaschen: "I discussed with Phuedx on IRC, and we're okay with documenting it as a breaking change." [core] - 10https://gerrit.wikimedia.org/r/122838 (https://bugzilla.wikimedia.org/63343) (owner: 10Phuedx) [16:50:52] (03CR) 10Jforrester: [C: 04-1] Allow VisualEditor users to set if a page whether a Disambiguation (031 comment) [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/133037 (https://bugzilla.wikimedia.org/61073) (owner: 10Alex Monk) [16:51:08] liangent: possibly not, but does it matter? it was easier to write and test in this way [16:51:29] MatmaRex: ok, when they're merged into master, tested fixed on beta cluster, then the next SWAT is yours [16:51:41] MatmaRex: how is it easier? [16:51:59] 3Wikimedia / 3Site requests: Allow crats to grant TA on legalteamwiki - 10https://bugzilla.wikimedia.org/66377#c1 (10James Alexander) Commenting to confirm :) [16:52:18] liangent: because i could see how the two changes worked together? [16:52:33] the CSS for the tabs is really messed up [16:52:53] the fewer variables to test, the fewer monumental fuckups like the one i caused and i'm fixing :/ [16:53:12] (03CR) 10Jforrester: [C: 032] "Wmf9 is nigh." [core] - 10https://gerrit.wikimedia.org/r/131104 (owner: 10Bartosz Dziewoński) [16:53:26] (e.g. https://bugzilla.wikimedia.org/show_bug.cgi?id=46947 is one of the reasons for why it's messed up) [16:53:38] that reminds me that i should test this in RTL… do we have RTL languages with variants? [16:54:02] MatmaRex: I don't think so. [16:54:22] oh, the variants menu only depends on the content language anyway. [16:54:28] yay, works well. [16:54:30] MatmaRex: there are [16:54:49] (03CR) 10Mattflaschen: [C: 032] "Tested patch set 1; latest changes are comment improvements." [core] - 10https://gerrit.wikimedia.org/r/137403 (owner: 10Krinkle) [16:54:56] MatmaRex: content language = kk, variant = kk-arab [16:55:12] liangent: Ah, yes, of course. [16:55:19] actually some variants of kk are LTR and some is RTL... [16:55:38] liangent: Yeah, LTR/RTL variation in a single language just to make things easy on us. :-) [16:56:52] (03Merged) 10jenkins-bot: Remove backwards-compatibility modules from I3947eaac [core] - 10https://gerrit.wikimedia.org/r/131104 (owner: 10Bartosz Dziewoński) [16:57:31] MatmaRex: the arrow moves down for a few mms. is it an expected behavior? [16:57:39] it moves down when clicked [16:57:44] liangent: yes [16:57:45] and yes [16:57:52] (03Merged) 10jenkins-bot: Installer: Re-use ResourceLoader methods instead of duplicating [core] - 10https://gerrit.wikimedia.org/r/137403 (owner: 10Krinkle) [16:58:05] (03PS1) 10Mwalker: Adding texter path [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/138359 [16:58:14] 3Wikimedia / 3Site requests: Allow bureaucrats to grant translationadmin on legalteamwiki - 10https://bugzilla.wikimedia.org/66377 (10John F. Lewis) p:5Unprio>3Normal [16:58:19] this was added to the dropdown menu a few months ago [16:58:34] to have a visual indicator that the menu is "focused" / "active" [16:59:10] (03CR) 10Mwalker: [C: 032] Update dependencies. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/138043 (owner: 10Cscott) [16:59:34] MatmaRex: no? I don't see such behavior on wikipedia live [16:59:37] MatmaRex: at least on zhwp [17:00:10] (03Abandoned) 10Cscott: Update mw-ocg-bundler dependencies. [extensions/Collection/OfflineContentGenerator/node_modules] - 10https://gerrit.wikimedia.org/r/138098 (owner: 10Cscott) [17:00:13] huh. it definitely is there on en.wp [17:00:25] but i don't get it on zh either. weird [17:00:32] (03Abandoned) 10Cscott: Update mw-ocg-latexer dependencies. [extensions/Collection/OfflineContentGenerator/node_modules] - 10https://gerrit.wikimedia.org/r/138136 (owner: 10Cscott) [17:00:44] (03CR) 10Mwalker: [C: 032] Update dependencies. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138135 (owner: 10Cscott) [17:00:55] (03CR) 10jenkins-bot: [V: 04-1] Update dependencies. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/138043 (owner: 10Cscott) [17:01:17] MatmaRex: interested in diagnosing it now? [17:01:17] (03PS1) 10Awight: python lint jobs for the slander repo [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138360 [17:01:32] liangent: looks like a local zh.wp override to me [17:01:47] (03CR) 10Cscott: "recheck" [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/138043 (owner: 10Cscott) [17:01:58] liangent: there's a "background-position: 100% 60% !important" somewhere [17:02:15] (03CR) 10Anomie: "I fail to see why parsoid's choice for where to insert newlines is better than tidy's. But I really don't want to get involved in this fig" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/134380 (https://bugzilla.wikimedia.org/39617) (owner: 10GWicke) [17:02:37] liangent: https://zh.wikipedia.org/wiki/MediaWiki:Vector.css [17:02:46] "Fix background image bug described in [[Bugzilla:31396]]" [17:03:17] liangent: that can probably be removed :) [17:03:33] (03Merged) 10jenkins-bot: Update dependencies. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138135 (owner: 10Cscott) [17:04:00] MatmaRex: done [17:04:10] (03CR) 10Mwalker: [C: 032 V: 032] Adding texter path [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/138359 (owner: 10Mwalker) [17:04:14] 3MediaWiki extensions / 3WikidataRepo: review backend part of entity suggester (python code) - 10https://bugzilla.wikimedia.org/63368 (10Greg Grossmeier) [17:04:45] 3MediaWiki extensions / 3General/Unknown: Security review of Property Suggestor - python part - 10https://bugzilla.wikimedia.org/66378 (10Greg Grossmeier) p:5Unprio>3Normal [17:04:45] 3MediaWiki extensions / 3General/Unknown: Security review of Property Suggestor - python part - 10https://bugzilla.wikimedia.org/66378 (10Greg Grossmeier) [17:04:50] liangent: pleasure working with you. :D [17:05:06] 3MediaWiki extensions / 3WikidataRepo: review backend part of entity suggester (python code) - 10https://bugzilla.wikimedia.org/63368 (10Greg Grossmeier) [17:05:14] 3MediaWiki extensions / 3General/Unknown: Perf review of Property Suggester - python part - 10https://bugzilla.wikimedia.org/66379 (10Greg Grossmeier) p:5Unprio>3Normal [17:06:00] 3MediaWiki extensions / 3WikidataRepo: review backend part of entity suggester (php code) - 10https://bugzilla.wikimedia.org/63224 (10Greg Grossmeier) [17:06:00] 3MediaWiki extensions / 3General/Unknown: Security review of Property Suggestor - php part - 10https://bugzilla.wikimedia.org/66380 (10Greg Grossmeier) p:5Unprio>3Normal [17:06:14] 3MediaWiki extensions / 3WikidataRepo: review backend part of entity suggester (php code) - 10https://bugzilla.wikimedia.org/63224 (10Greg Grossmeier) [17:06:58] MatmaRex: its behavior still looks inconsistent with TW's menu [17:07:14] 3Analytics / 3Tech community metrics: Bugzilla ticket with recent comments listed under "Longest time without comment" on bugzilla_response_time.html - 10https://bugzilla.wikimedia.org/64373#c8 (10Andre Klapper) This is still (again?) a problem: The middle column lists bug 12360 (Implement an extension simil... [17:08:09] liangent: ugh [17:08:30] 3MediaWiki extensions / 3General/Unknown: Perf review of Property Suggester - php part - 10https://bugzilla.wikimedia.org/66381 (10Greg Grossmeier) [17:08:30] 3MediaWiki extensions / 3General/Unknown: Perf review of Property Suggester - python part - 10https://bugzilla.wikimedia.org/66379 (10Greg Grossmeier) [17:08:33] 3MediaWiki extensions / 3General/Unknown: Security review of Property Suggestor - php part - 10https://bugzilla.wikimedia.org/66380 (10Greg Grossmeier) [17:08:33] 3MediaWiki extensions / 3General/Unknown: Security review of Property Suggestor - python part - 10https://bugzilla.wikimedia.org/66378 (10Greg Grossmeier) [17:08:33] 3Wikimedia / 3Extension setup: Review and deploy Property Suggester - 10https://bugzilla.wikimedia.org/66382 (10Greg Grossmeier) 3NEW p:3Unprio s:3normal a:3Lydia Pintscher == Checklist == # Create a tracking bug: This bug. # Create Extension: mediawiki.org page for developers and people who will in... [17:08:44] 3Wikimedia / 3Extension setup: Review and deploy Property Suggester - 10https://bugzilla.wikimedia.org/66382 (10Greg Grossmeier) p:5Unprio>3Normal [17:08:49] MatmaRex: and in #p-variants, I have to click the arrow; clicking on the label doesn't work [17:09:15] (03CR) 10EBernhardson: "generally looks like it should work" (031 comment) [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/138115 (owner: 10SG) [17:10:05] liangent: yes, i know. but hovering works, right? [17:10:26] MatmaRex: right [17:10:30] (03CR) 10Liangent: [C: 031] Vector: Hide the superfluous "Variants" menu label again [core] - 10https://gerrit.wikimedia.org/r/138356 (https://bugzilla.wikimedia.org/66364) (owner: 10Bartosz Dziewoński) [17:11:30] liangent: i'm going to write a patch for that too. let's just kill the weird two labels thing [17:11:55] but that's not a regression [17:12:20] (03PS3) 10Bartosz Dziewoński: Vector: Hide the superfluous "Variants" menu label again [core] - 10https://gerrit.wikimedia.org/r/138356 (https://bugzilla.wikimedia.org/66364) [17:12:25] (03CR) 10Liangent: [C: 031] "The patch itself looks fine, but is it possible to make TW's menu appear and behave in the same way?" [core] - 10https://gerrit.wikimedia.org/r/137715 (https://bugzilla.wikimedia.org/66363) (owner: 10Bartosz Dziewoński) [17:13:15] (03CR) 10Liangent: [C: 031] Vector: Hide the superfluous "Variants" menu label again [core] - 10https://gerrit.wikimedia.org/r/138356 (https://bugzilla.wikimedia.org/66364) (owner: 10Bartosz Dziewoński) [17:13:19] liangent: if twinkle uses the same HTML structure as the normal menu, it should just work [17:13:25] if it doesn't, i blame twinkle. :) [17:14:29] 3MediaWiki extensions / 3CharInsert: Some of the hebrew characters are not in proper order - 10https://bugzilla.wikimedia.org/66348#c3 (10ineuw) Please look at the bottom of the attached image where I included the current Hebrew character placements of Charinsert. The upper (correct) image is from Wikipedia... [17:14:43] MatmaRex: I guess javascript is involved when the menu is initialized [17:14:58] so do you have an interface for TW to call if its menu is created after that? [17:15:27] or does it really "just work"? [17:15:33] (03PS1) 10KartikMistry: contrib: Add upstart and systemd scripts [services/cxserver] - 10https://gerrit.wikimedia.org/r/138362 [17:15:35] (03CR) 10EBernhardson: "not completely necessary, but generally a patch like "rename *.html.handlebars to *.handlebars" should be its own patch for ease of review" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137957 (owner: 10SG) [17:16:11] liangent: oh hmm, i'm not sure how the javascript for clicking on the menu works [17:16:24] the CSS part is pure CSS, at least [17:16:56] menus can be pure css, dunno about that one :) [17:17:59] 3MediaWiki extensions / 3CharInsert: Some of the hebrew characters are not in proper order - 10https://bugzilla.wikimedia.org/66348#c4 (10ineuw) Created attachment 15604 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15604&action=edit Showing the incorrect order of hebrew characters feom Charinsert [17:18:53] (03PS1) 10MaxSem: Apply Mobile App edit tag only to edits [extensions/MobileApp] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/138363 [17:19:04] (03CR) 10MaxSem: [C: 032] Apply Mobile App edit tag only to edits [extensions/MobileApp] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/138363 (owner: 10MaxSem) [17:19:08] (03Merged) 10jenkins-bot: Apply Mobile App edit tag only to edits [extensions/MobileApp] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/138363 (owner: 10MaxSem) [17:19:17] 3MediaWiki extensions / 3WikidataRepo: EntitySelector not working on MainPage (e.g. for search box) - 10https://bugzilla.wikimedia.org/66257#c2 (10Aude) 5PATC>3RESO/FIX fixed and can be verified on test.wikidata [17:19:29] 3MediaWiki extensions / 3WikidataRepo: jquery styles overriding entity suggester styles - 10https://bugzilla.wikimedia.org/66268#c4 (10Aude) 5NEW>3RESO/FIX fixed and can be verified on test.wikidata [17:19:35] (03PS1) 10MaxSem: Apply Mobile App edit tag only to edits [extensions/MobileApp] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/138364 [17:19:38] (03CR) 10Dr0ptp4kt: [C: 032] New validated base to allow nested content storage [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/137972 (owner: 10Yurik) [17:19:43] (03Merged) 10jenkins-bot: New validated base to allow nested content storage [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/137972 (owner: 10Yurik) [17:19:45] (03CR) 10MaxSem: [C: 032] Apply Mobile App edit tag only to edits [extensions/MobileApp] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/138364 (owner: 10MaxSem) [17:19:47] (03Merged) 10jenkins-bot: Apply Mobile App edit tag only to edits [extensions/MobileApp] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/138364 (owner: 10MaxSem) [17:19:57] (03Draft2) 10KartikMistry: Configurable LogDir [services/cxserver] - 10https://gerrit.wikimedia.org/r/138324 [17:20:19] 3MediaWiki extensions / 3BetaFeatures: Compact Language Links displays wrong numerals in Arabic Wikipedia - 10https://bugzilla.wikimedia.org/66383 (10Zack) 3NEW p:3Unprio s:3minor a:3None Hello, In Arabic Wikipedia, The beta feature Compact Language Links displays Arabic numerals instead of Roman num... [17:23:06] (03CR) 10Krinkle: "@Mattflaschen: Yeah, that was the intent of my patch against the Installer. Thanks for rebasing." [core] - 10https://gerrit.wikimedia.org/r/122838 (https://bugzilla.wikimedia.org/63343) (owner: 10Phuedx) [17:23:59] (03PS1) 10MaxSem: MobileApp: cherrypick https://gerrit.wikimedia.org/r/#/c/137930/ [core] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/138366 [17:24:30] (03CR) 10Krinkle: "Found 0 usage in all of git.wikimedia.org (including core, and all hosted extensions, not just those deployed on wmf)." [core] - 10https://gerrit.wikimedia.org/r/122838 (https://bugzilla.wikimedia.org/63343) (owner: 10Phuedx) [17:24:54] MatmaRex: btw, keep me updated on those two changes, I didn't readthe rest of the convo in here, so let me know if anything else needs to happen [17:25:32] greg-g: if possible, find someone to review them :) [17:25:45] greg-g: Krinkl.e has already reviewed one but only +1'd, the second i just wrote [17:26:02] kk, Krink.le makes sense, who else? [17:26:14] greg-g: or you can just unstage the other one for the coming deployment? [17:26:35] 3MediaWiki extensions / 3VectorBeta: Compact Language Links displays wrong numerals in Arabic Wikipedia - 10https://bugzilla.wikimedia.org/66383 (10James Forrester) [17:26:40] greg-g: I mean https://gerrit.wikimedia.org/r/#q,I09c8031c,n,z [17:26:58] 3Wikimedia / 3Extension setup: Enable Hovercards on se.wikimedia.org (Swedish chapter wiki) - 10https://bugzilla.wikimedia.org/66374 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [17:27:12] liangent: ah, you mean revert that in all live versions? [17:27:14] 3MediaWiki / 3Skin and page rendering: Bug 65434 appears on the "More" arrow and "Variants" arrow - 10https://bugzilla.wikimedia.org/66363 (10Andre Klapper) p:5Unprio>3High [17:27:59] that's doable, MatmaRex want to propose a revert of that commit to go out in... 5.5 hours at the latest? [17:28:14] 3MediaWiki extensions / 3VectorBeta: Compact Language Links displays wrong numerals in Arabic Wikipedia - 10https://bugzilla.wikimedia.org/66383#c1 (10Liangent) Isn't it expected? Or I think that the bug is 'N more language' not being translated? [17:28:20] "this evening's" SWAT [17:28:32] 3MediaWiki / 3Skin and page rendering: [Regression] CSS selector for vector menu label is not generic enough - 10https://bugzilla.wikimedia.org/43406#c2 (10Bartosz Dziewoński) a:3Bartosz Dziewoński The way I did the "Variants" menu here was the root cause for bug 66364. Let's get rid of it at last. One lab... [17:28:43] greg-g: eh, that one was announced in tech news already [17:29:01] greg-g: it'd be a little bad to revert it now, methinks [17:29:18] k, then go ping people to merge your fixes, test on beta cluster, and put in SWAT [17:29:21] :) [17:29:27] aye aye [17:29:30] 3MediaWiki extensions / 3WikidataRepo: Use ExceptionLocalizer for error reporting on special pages - 10https://bugzilla.wikimedia.org/64307 (10tobias.gritschacher) 5PATC>3ASSI [17:29:38] MatmaRex: thanks muchly [17:30:27] (03PS1) 10Bartosz Dziewoński: Stop using a retarded structure for Vector's variants menu [core] - 10https://gerrit.wikimedia.org/r/138368 (https://bugzilla.wikimedia.org/43406) [17:30:31] (03PS1) 10Bartosz Dziewoński: Stop using a retarded structure for Vector's variants menu (cont.) [core] - 10https://gerrit.wikimedia.org/r/138369 (https://bugzilla.wikimedia.org/43406) [17:30:45] liangent: enjoy these also ^ [17:31:06] liangent: this fixes the clicking behavior and generally restores sanity [17:31:52] (03PS2) 10Greg Grossmeier: Stop using a suboptimal structure for Vector's variants menu (cont.) [core] - 10https://gerrit.wikimedia.org/r/138369 (https://bugzilla.wikimedia.org/43406) (owner: 10Bartosz Dziewoński) [17:31:53] MatmaRex: why two commits instead of one? [17:31:54] (03CR) 10Paladox: "Ok." [core] - 10https://gerrit.wikimedia.org/r/137979 (owner: 10Paladox) [17:32:11] liangent: because of WMF's caching [17:32:14] (03PS2) 10Greg Grossmeier: Stop using a suboptimal structure for Vector's variants menu [core] - 10https://gerrit.wikimedia.org/r/138368 (https://bugzilla.wikimedia.org/43406) (owner: 10Bartosz Dziewoński) [17:32:27] (03CR) 10Subramanya Sastry: "This patch eliminates 2 newlines
  • foo\n
    • \n per list-item (https://gerrit.wikimedia.org/r/#/c/90696/4/tests/parser/parserTests.txt)." [core] - 10https://gerrit.wikimedia.org/r/134380 (https://bugzilla.wikimedia.org/39617) (owner: 10GWicke) [17:32:28] liangent: if i did them both at the same time, we'd have funny glitches for 30 days [17:32:32] greg-g: :( [17:32:44] MatmaRex: sorry, the use of that word in that way makes me sad :( [17:33:08] (03PS3) 10Bartosz Dziewoński: Stop using a suboptimal structure for Vector's variants menu [core] - 10https://gerrit.wikimedia.org/r/138368 (https://bugzilla.wikimedia.org/43406) [17:33:15] (03PS3) 10Bartosz Dziewoński: Stop using a suboptimal structure for Vector's variants menu (cont.) [core] - 10https://gerrit.wikimedia.org/r/138369 (https://bugzilla.wikimedia.org/43406) [17:33:16] MatmaRex: so the second one must be merged 30 days after? [17:33:22] liangent: yes [17:33:52] (03CR) 10Bartosz Dziewoński: "To be merged 30 days after Idf43d77dccff83ad81db776f3262e0ef12d25c92." [core] - 10https://gerrit.wikimedia.org/r/138369 (https://bugzilla.wikimedia.org/43406) (owner: 10Bartosz Dziewoński) [17:34:17] MatmaRex: I guess we should include a version number in bits.wikimedia.org/*/load.php? requests [17:34:33] bits.wikimedia.org/*/load.php?version=1.24wmf8& ... [17:35:10] or bits.wikimedia.org/*/1.24wmf8/load.php?... [17:35:11] liangent: i proposed another solution some time ago, but all i got was some grumbling and moved on. https://bugzilla.wikimedia.org/show_bug.cgi?id=46956 [17:36:06] i can deal with the weird process we have now, and changes like this are rare enough for people not to run into the issue often, so meh [17:37:34] MatmaRex: but a next contributor will get caught by this again, if you're not around :( [17:39:02] liangent: i watch everything that touches a .css, .less or .js file in core, and i think Krinkl.e does as well :) this behavior is probably even documented somewhere [17:39:22] i think sumana included it in her "mediawiki caching for dummies" guide [17:39:43] (03CR) 10Krinkle: ""However does not fix outline bug."; still the case. Clicking the arrow consistently makes the focus outline appear in regular Chrome/Mac." [core] - 10https://gerrit.wikimedia.org/r/137715 (https://bugzilla.wikimedia.org/66363) (owner: 10Bartosz Dziewoński) [17:40:59] (03CR) 10Bartosz Dziewoński: "The outline was there before? (Although it looked differently for some reason, it was thinner.)" [core] - 10https://gerrit.wikimedia.org/r/137715 (https://bugzilla.wikimedia.org/66363) (owner: 10Bartosz Dziewoński) [17:42:01] (03CR) 10Tpt: [C: 032] "Reviewed by Phe" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/132233 (owner: 10Tpt) [17:42:03] (03CR) 10jenkins-bot: [V: 04-1] Adds Pagination abstraction [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/132233 (owner: 10Tpt) [17:42:05] (03CR) 10Bartosz Dziewoński: "On zh.wp: http://i.imgur.com/eoc6dxy.png – I'll write a separate patch maybe?" [core] - 10https://gerrit.wikimedia.org/r/137715 (https://bugzilla.wikimedia.org/66363) (owner: 10Bartosz Dziewoński) [17:42:14] 3MediaWiki extensions / 3UniversalLanguageSelector: Compact Language Links displays wrong numerals in Arabic Wikipedia - 10https://bugzilla.wikimedia.org/66383 (10Kunal Mehta (Legoktm)) [17:43:01] (03CR) 10Ori.livneh: [C: 032] "Works well for me, too. Thanks" [vagrant] - 10https://gerrit.wikimedia.org/r/137483 (https://bugzilla.wikimedia.org/50993) (owner: 10Dduvall) [17:43:16] (03Merged) 10jenkins-bot: Ruby module for better management of ruby and gems [vagrant] - 10https://gerrit.wikimedia.org/r/137483 (https://bugzilla.wikimedia.org/50993) (owner: 10Dduvall) [17:43:30] Krinkle: hmm, should we just kill the outlines? [17:44:34] (03CR) 10Krinkle: "Well, for some definition of "thinner". The h3 has "overflow: hidden;" applied, so previously (as currently on en.wikipedia.org) the only " [core] - 10https://gerrit.wikimedia.org/r/137715 (https://bugzilla.wikimedia.org/66363) (owner: 10Bartosz Dziewoński) [17:44:41] hmm, no. we don't have a different focus indicator. [17:44:42] MatmaRex: Probably, yeah. [17:44:51] Well, we didn't have one earlier either. [17:44:55] (03CR) 10Aaron Schulz: [C: 032] API: Add prop=unreadcount to ApiQueryUserInfo [core] - 10https://gerrit.wikimedia.org/r/137150 (https://bugzilla.wikimedia.org/65246) (owner: 10Anomie) [17:45:05] but we had the outlines [17:45:12] While suboptimal and certainly a high prio todo item, it was "normal" for a long time. [17:45:15] No we didn't. [17:45:23] overflow:hidden; effectively kills the outline [17:45:42] leaving only a 1px peek through along the top edge, which is probably a rendering bug in Chrome that isn't supposed to peek through [17:45:50] how did we not have them if i'm seeing them? [17:45:51] yeah [17:46:07] (03PS3) 10Tpt: Adds Pagination abstraction [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/132233 [17:46:12] (03CR) 10jenkins-bot: [V: 04-1] Adds Pagination abstraction [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/132233 (owner: 10Tpt) [17:46:16] (03PS1) 10SG: Move templates and fix handlebars.js compatbility [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138371 [17:47:04] Krinkle: given that no one clicks on these normally, and those that click might want the outlines, i'm going to say this is not a regression and think about this in a separate patch? [17:47:21] (or rather, those that tabindex through them) [17:47:45] (03PS4) 10Tpt: Adds Pagination abstraction [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/132233 [17:48:26] (03Merged) 10jenkins-bot: API: Add prop=unreadcount to ApiQueryUserInfo [core] - 10https://gerrit.wikimedia.org/r/137150 (https://bugzilla.wikimedia.org/65246) (owner: 10Anomie) [17:48:35] (03CR) 10Tpt: [C: 032] "Reviewed by Phe" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/132233 (owner: 10Tpt) [17:48:39] Krinkle: here's how the outline looks to me on en.wp right now, if i tab to the dropdown: http://i.imgur.com/69RX01S.png [17:48:51] (that's on Opera 20something, though) [17:49:14] (03PS4) 10Cscott: Switch from `when` to `bluebird` for Promise implementation. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/111732 [17:49:16] (03PS2) 10Cscott: Switch from `bluebird` to `es6-shim`/`prfun` for Promise implementation. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/138154 [17:49:27] brb [17:49:39] (03CR) 10jenkins-bot: [V: 04-1] Switch from `when` to `bluebird` for Promise implementation. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/111732 (owner: 10Cscott) [17:49:41] (03Merged) 10jenkins-bot: Adds Pagination abstraction [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/132233 (owner: 10Tpt) [17:49:53] (03PS3) 10Krinkle: Vector: Restore old focus animation on the "More" dropdown [core] - 10https://gerrit.wikimedia.org/r/137715 (https://bugzilla.wikimedia.org/66363) (owner: 10Bartosz Dziewoński) [17:51:19] (03CR) 10MarkTraceur: [C: 031] "Gilles's changes look OK to me; I would like someone else to verify this though." [core] - 10https://gerrit.wikimedia.org/r/127460 (owner: 10Aaron Schulz) [17:51:37] (03PS2) 10SG: Move templates and fix handlebars.js compatbility [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138371 [17:51:56] (03PS1) 10MaxSem: MobileApp: cherrypick https://gerrit.wikimedia.org/r/#/c/137930/ [core] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/138374 [17:52:05] (03CR) 10Krinkle: [C: 032] "In browsers like Opera and Firefox that seem to ignore the overflow:hidden; the change to the structure when the label was added (and thus" [core] - 10https://gerrit.wikimedia.org/r/137715 (https://bugzilla.wikimedia.org/66363) (owner: 10Bartosz Dziewoński) [17:52:13] (03CR) 10jenkins-bot: [V: 04-1] Switch from `bluebird` to `es6-shim`/`prfun` for Promise implementation. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/138154 (owner: 10Cscott) [17:53:29] 3Wikimedia / 3Site requests: Enable Hovercards on se.wikimedia.org (Swedish chapter wiki) - 10https://bugzilla.wikimedia.org/66374 (10Kunal Mehta (Legoktm)) [17:55:59] 3MediaWiki extensions / 3Scribunto: mw.title should avoid unnecessary expensive work - 10https://bugzilla.wikimedia.org/66328#c4 (10Jackmcbarn) What Liangent is saying is basically what I was trying to say. If you just want to validate, canonicalize, etc., there's no reason to hit the DB at all. [17:56:45] (03Merged) 10jenkins-bot: Vector: Restore old focus animation on the "More" dropdown [core] - 10https://gerrit.wikimedia.org/r/137715 (https://bugzilla.wikimedia.org/66363) (owner: 10Bartosz Dziewoński) [17:56:52] (03CR) 10Catrope: [C: 04-1] "-1 for comment typos and FIXME (per commit msg). Code seems fine" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/135085 (owner: 10Krinkle) [17:57:22] (03CR) 10MarkTraceur: "Ori, can you comment on this? Bawolff thinks your patch may have caused the issue." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/137529 (https://bugzilla.wikimedia.org/66143) (owner: 10Brian Wolff) [17:59:31] (03CR) 10Catrope: [WIP] resourceloader: Implement "skip function" feature (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135085 (owner: 10Krinkle) [18:00:13] (03PS5) 10Cscott: Switch from `when` to `bluebird` for Promise implementation. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/111732 [18:00:15] (03PS3) 10Cscott: Switch from `bluebird` to `es6-shim`/`prfun` for Promise implementation. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/138154 [18:00:58] (03PS4) 10Cscott: Switch from `bluebird` to `es6-shim`/`prfun` for Promise implementation. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/138154 [18:01:11] ori: https://gerrit.wikimedia.org/r/#/c/137829/ [18:02:00] (03PS5) 10GWicke: Update list item newline handling to follow Parsoid's model [core] - 10https://gerrit.wikimedia.org/r/134380 (https://bugzilla.wikimedia.org/39617) [18:02:03] (03CR) 10GWicke: Update list item newline handling to follow Parsoid's model (031 comment) [core] - 10https://gerrit.wikimedia.org/r/134380 (https://bugzilla.wikimedia.org/39617) (owner: 10GWicke) [18:03:17] (03CR) 10GWicke: "Replaced a tab with a space." [core] - 10https://gerrit.wikimedia.org/r/134380 (https://bugzilla.wikimedia.org/39617) (owner: 10GWicke) [18:03:27] (03PS5) 10SG: Implement flow-api-handler data attribute [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137957 [18:03:48] (03CR) 10jenkins-bot: [V: 04-1] Implement flow-api-handler data attribute [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137957 (owner: 10SG) [18:03:59] 3MediaWiki / 3Language converter: Use lang, hreflang and rel="alternate" attributes in variant links - 10https://bugzilla.wikimedia.org/24742 (10Bartosz Dziewoński) 5NEW>3RESO/FIX [18:04:09] (03PS2) 10Cscott: Switch from `when` to `bluebird` for Promise implementation. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138156 [18:04:12] (03PS2) 10Cscott: Switch from `bluebird` to `es6-shim`/`prfun` for Promise implementation. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138157 [18:04:13] (03PS2) 10Cscott: Use `jpegtran` to purge EXIF data from jpegs. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138149 [18:05:01] 3MediaWiki / 3Skin and page rendering: MediaWiki's assistive headers are broken in modern browsers - 10https://bugzilla.wikimedia.org/41297#c4 (10Bartosz Dziewoński) 5NEW>3RESO/FIX This has been mostly fixed with https://gerrit.wikimedia.org/r/#/c/112236/ and will be fixed entirely with https://gerrit.wi... [18:06:11] (03CR) 10jenkins-bot: [V: 04-1] Switch from `bluebird` to `es6-shim`/`prfun` for Promise implementation. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138157 (owner: 10Cscott) [18:06:44] (03PS2) 10SG: Register all handlebars templates as partials as well [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/138115 [18:06:56] MatmaRex: have you check whether message "variants" is used anywhere else? [18:07:13] (03CR) 10EBernhardson: [C: 031] "lmgtm, but why was the submitted post content commented out as @todo ?" (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138371 (owner: 10SG) [18:07:14] 3MediaWiki / 3Skin and page rendering: Vector: Page actions in dropdown menu should expand if space allows - 10https://bugzilla.wikimedia.org/22986 (10Bartosz Dziewoński) [18:07:15] 3MediaWiki / 3Skin and page rendering: Move "View history" to dropdown menu - 10https://bugzilla.wikimedia.org/51529 (10Bartosz Dziewoński) [18:07:35] liangent: hmm, no. but we also kept the 'actions' message when the other dropdown was renamed [18:07:47] (03CR) 10jenkins-bot: [V: 04-1] Use `jpegtran` to purge EXIF data from jpegs. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138149 (owner: 10Cscott) [18:07:49] liangent: i wouldn't be surprised if it was used by some extension or something, eh [18:07:55] and, is it guaranteed that there's always one $this->data['variant_urls'] having stripos( $link['attributes'], 'selected' ) !== false ? [18:07:58] (03PS4) 10Rohan013: Replace autofocus="1" /> to autofocus /> on input element in Special:BookSources [core] - 10https://gerrit.wikimedia.org/r/137670 (https://bugzilla.wikimedia.org/66134) [18:08:38] (03Abandoned) 10Rohan013: Replace autofocus="1" /> to autofocus /> on input element in Special:BookSources [core] - 10https://gerrit.wikimedia.org/r/137670 (https://bugzilla.wikimedia.org/66134) (owner: 10Rohan013) [18:08:54] (03CR) 10EBernhardson: [C: 032] Use ConfirmEdit as SpamFilter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/138328 (owner: 10Matthias Mullie) [18:09:18] (03CR) 10Subramanya Sastry: [C: 032] Update list item newline handling to follow Parsoid's model [core] - 10https://gerrit.wikimedia.org/r/134380 (https://bugzilla.wikimedia.org/39617) (owner: 10GWicke) [18:09:28] liangent: uhm, i'm pretty sure [18:09:50] liangent: looking at the code, it will only be 'selected' if its code == $pageLang->getPreferredVariant() [18:09:54] (03Merged) 10jenkins-bot: Use ConfirmEdit as SpamFilter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/138328 (owner: 10Matthias Mullie) [18:10:06] i sure hope we don't have many variants with the same code, heh [18:11:32] (03CR) 10GWicke: [C: 031] Support {{!}} as a magic word [core] - 10https://gerrit.wikimedia.org/r/136234 (owner: 10Jackmcbarn) [18:12:20] (03CR) 10Anomie: "> The new output from this patch makes the PHP parser output match both Tidy and Parsoid's output." [core] - 10https://gerrit.wikimedia.org/r/134380 (https://bugzilla.wikimedia.org/39617) (owner: 10GWicke) [18:13:16] (03Merged) 10jenkins-bot: Update list item newline handling to follow Parsoid's model [core] - 10https://gerrit.wikimedia.org/r/134380 (https://bugzilla.wikimedia.org/39617) (owner: 10GWicke) [18:13:25] (03CR) 10Legoktm: "Any (other) objections to merging this? I don't think there's a perfect solution everyone is going to be happy with, but this one isn't te" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/132145 (owner: 10Matthias Mullie) [18:13:36] (03CR) 10EBernhardson: [C: 032] Block should just use Status::getMessage instead of trying to build that itself [extensions/Flow] - 10https://gerrit.wikimedia.org/r/138330 (owner: 10Matthias Mullie) [18:13:59] 3MediaWiki / 3Skin and page rendering: MediaWiki's assistive headers are broken in modern browsers - 10https://bugzilla.wikimedia.org/41297#c5 (10Daniel Friesen) 5RESO/FIX>3REOP This is NOT fixed. Those patchsets solve completely different problems. The #p-search, #p-personal, #p-views, and #p-namespace... [18:14:14] (03PS3) 10Anomie: API: Add show=unread to ApiQueryWatchlist [core] - 10https://gerrit.wikimedia.org/r/137147 (https://bugzilla.wikimedia.org/65246) [18:14:20] (03CR) 10Ori.livneh: [C: 032] Lowered the TransactionProfiler threshold [core] - 10https://gerrit.wikimedia.org/r/137829 (owner: 10Aaron Schulz) [18:14:34] (03Merged) 10jenkins-bot: Block should just use Status::getMessage instead of trying to build that itself [extensions/Flow] - 10https://gerrit.wikimedia.org/r/138330 (owner: 10Matthias Mullie) [18:15:41] (03CR) 10EBernhardson: [C: 032] Register all handlebars templates as partials as well [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/138115 (owner: 10SG) [18:16:47] (03Merged) 10jenkins-bot: Register all handlebars templates as partials as well [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/138115 (owner: 10SG) [18:17:07] (03CR) 10EBernhardson: [C: 032] Fix UUID conversion in some places. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/132398 (owner: 10Matthias Mullie) [18:17:33] (03Merged) 10jenkins-bot: Fix UUID conversion in some places. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/132398 (owner: 10Matthias Mullie) [18:17:49] (03PS1) 10Tpt: Moves some classes to namespaces and some simple cleanup [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/138383 [18:17:50] MatmaRex: well having zero selected url is not having one right? [18:18:33] (03CR) 10EBernhardson: [C: 032] Hacky sub-expression implementation for lightncandy [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137708 (owner: 10EBernhardson) [18:18:34] liangent: isn't some variant always selected as default? [18:18:51] (03CR) 10Spage: "Still the jshint error. Does ``make installhooks` not set up jshint on commit for you?" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137957 (owner: 10SG) [18:18:54] (03Merged) 10jenkins-bot: Hacky sub-expression implementation for lightncandy [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137708 (owner: 10EBernhardson) [18:19:02] (03CR) 10Sumanah: "Congrats on making the patchset! :)" [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/136742 (owner: 10Vedpalr) [18:19:19] (03Abandoned) 10Sumanah: Git Review Checking [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/136742 (owner: 10Vedpalr) [18:19:22] (03Merged) 10jenkins-bot: Lowered the TransactionProfiler threshold [core] - 10https://gerrit.wikimedia.org/r/137829 (owner: 10Aaron Schulz) [18:19:26] (03PS9) 10Alex Monk: Allow VisualEditor users to set if a page whether a Disambiguation [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/133037 (https://bugzilla.wikimedia.org/61073) [18:20:25] not always with some bad configuration :/ [18:20:38] try $wgDisabledVariants=array('zh') if your preferred variant is zh [18:20:38] (03CR) 10Jforrester: [C: 031] Allow VisualEditor users to set if a page whether a Disambiguation [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/133037 (https://bugzilla.wikimedia.org/61073) (owner: 10Alex Monk) [18:20:42] (03PS10) 10Jforrester: Allow VisualEditor users to set if a page whether a Disambiguation [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/133037 (https://bugzilla.wikimedia.org/61073) (owner: 10Alex Monk) [18:20:45] then zh disappears from that list [18:20:59] 3MediaWiki / 3Skin and page rendering: MediaWiki's assistive headers are broken in modern browsers - 10https://bugzilla.wikimedia.org/41297#c6 (10Bartosz Dziewoński) Oh huh, sorry. I've always thought they used ones of the accessible techniques, but that's apparently only used for #mw-navigation h2. [18:21:04] then Notice: Undefined variable: curVariant in ... [18:21:18] liangent: hmmm. okay, what should we use then? the "Variants" label? [18:22:26] maybe? [18:22:31] 3MediaWiki / 3Skin and page rendering: MediaWiki's assistive headers are broken in modern browsers - 10https://bugzilla.wikimedia.org/41297#c7 (10Daniel Friesen) This bug is not about making headers visible, it's about using a screen-reader friendly method of hiding headers, because things like display: none... [18:23:06] sounds good to me, let's do that [18:23:54] (03CR) 10Legoktm: Allow VisualEditor users to set if a page whether a Disambiguation (033 comments) [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/133037 (https://bugzilla.wikimedia.org/61073) (owner: 10Alex Monk) [18:24:32] (03CR) 10Mdale: [C: 031 V: 032] "I have checked this locally and seems to work." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/138307 (owner: 10Brian Wolff) [18:24:35] (03PS5) 10EBernhardson: Correct output of wfMessage( 'non-existent-msg' )->text() [core] - 10https://gerrit.wikimedia.org/r/137458 (https://bugzilla.wikimedia.org/66199) [18:24:42] (03CR) 10Jforrester: Allow VisualEditor users to set if a page whether a Disambiguation (031 comment) [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/133037 (https://bugzilla.wikimedia.org/61073) (owner: 10Alex Monk) [18:25:30] James_F: the MIT License copy in that repo is under the name "COPYING", not "LICENSE.txt" [18:25:48] (03CR) 10Alex Monk: Allow VisualEditor users to set if a page whether a Disambiguation (031 comment) [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/133037 (https://bugzilla.wikimedia.org/61073) (owner: 10Alex Monk) [18:25:59] legoktm: Then the file should be fixed to use the more normal name, ideally. :-) [18:26:03] legoktm: But eh. [18:26:07] Yeah. [18:26:11] Not in my commit. [18:26:18] * James_F doesn't really care. [18:26:20] (03CR) 10Catrope: [C: 04-1] Allow VisualEditor users to set if a page whether a Disambiguation (031 comment) [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/133037 (https://bugzilla.wikimedia.org/61073) (owner: 10Alex Monk) [18:26:41] legoktm: Thanks for catching that VE check thing, that would've been really bad [18:26:52] and very embarrassing for me :) [18:26:55] heh :P [18:27:21] Oops. [18:28:22] 3MediaWiki extensions / 3General/Unknown: Warning: Unknown error in LuaCommon/UstringLibrary.php - 10https://bugzilla.wikimedia.org/66386 (10Aaron Schulz) 3NEW p:3Unprio s:3normal a:3None Warning: Unknown error in /usr/local/apache/common-local/php-1.24wmf7/extensions/Scribunto/engines/LuaCommon/Ustr... [18:28:29] 3MediaWiki extensions / 3General/Unknown: HHVM - Warning: Unknown error in LuaCommon/UstringLibrary.ph p - 10https://bugzilla.wikimedia.org/66386 (10Aaron Schulz) [18:28:43] Krenair: You just want to ship all of VE's code to every page view, don't you? ;-) [18:29:01] haha [18:29:17] yeah, big ooops. [18:30:23] (03Restored) 10Rohan013: Replace autofocus="1" /> to autofocus /> on input element in Special:BookSources [core] - 10https://gerrit.wikimedia.org/r/137670 (https://bugzilla.wikimedia.org/66134) (owner: 10Rohan013) [18:30:25] (03PS4) 10Bartosz Dziewoński: Stop using a suboptimal structure for Vector's variants menu [core] - 10https://gerrit.wikimedia.org/r/138368 (https://bugzilla.wikimedia.org/43406) [18:30:27] (03PS4) 10Bartosz Dziewoński: Stop using a suboptimal structure for Vector's variants menu (cont.) [core] - 10https://gerrit.wikimedia.org/r/138369 (https://bugzilla.wikimedia.org/43406) [18:30:29] (03CR) 10SG: Move templates and fix handlebars.js compatbility (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138371 (owner: 10SG) [18:30:35] liangent: fixed :) [18:31:10] (03PS5) 10Rohan013: Changes autofocus="1" to autofocus="autofocus" Change-Id: I573c1fe6aba8162c1b172b40cda8313a92bf773c [core] - 10https://gerrit.wikimedia.org/r/137670 [18:32:29] 3MediaWiki / 3Skin and page rendering: MediaWiki's assistive headers are broken in modern browsers - 10https://bugzilla.wikimedia.org/41297#c8 (10Daniel Friesen) For an update on the techniques: { overflow: hidden; height: 0; } This technique breaks in VoiceOver and should be avoided. { position: absolut... [18:32:33] RoanKattouw, ugh, I'm pretty sure this will cause more loading order issues... [18:32:48] Krenair: ? [18:33:08] (03PS3) 10CSteipp: Add HKDF as a fast, random number source [core] - 10https://gerrit.wikimedia.org/r/137077 [18:35:27] Eh. Might be okay. [18:35:37] Seems to at least work for me. [18:35:51] (03PS11) 10Alex Monk: Allow VisualEditor users to set if a page whether a Disambiguation [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/133037 (https://bugzilla.wikimedia.org/61073) [18:36:42] gah, sent for review without -R and it rebased to include some unrelated changes in the diffs. [18:37:10] Krenair: Ah, fun. [18:37:15] (03PS12) 10Jforrester: Allow VisualEditor users to set if a page whether a Disambiguation [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/133037 (https://bugzilla.wikimedia.org/61073) (owner: 10Alex Monk) [18:37:22] Krenair: Fixed via PS12. [18:37:34] (03CR) 10Jforrester: "PS12 is an un-rebase of PS11." [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/133037 (https://bugzilla.wikimedia.org/61073) (owner: 10Alex Monk) [18:38:00] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/133037/10..12/Disambiguator.hooks.php [18:38:40] James_F, thanks [18:38:50] Krenair: 'Twas only a button press. :-) [18:39:02] Krenair: And it was caused by my interfering in the first place… :-) [18:40:16] (03PS4) 10EBernhardson: Provide a comment for the RCFeeds [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135502 (owner: 10Legoktm) [18:40:22] (03CR) 10jenkins-bot: [V: 04-1] Provide a comment for the RCFeeds [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135502 (owner: 10Legoktm) [18:40:44] (03CR) 10EBernhardson: "PS4: rebase" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135502 (owner: 10Legoktm) [18:41:16] 3MediaWiki extensions / 3AbuseFilter: Only one filter's tags are ever applied - 10https://bugzilla.wikimedia.org/66387 (10Jackmcbarn) 3NEW p:3Unprio s:3normal a:3None If two or more abuse filters exist that match an edit, and all of them are set up to apply tags to it, only one of the filters' tags w... [18:41:34] (03PS5) 10EBernhardson: Provide a comment for the RCFeeds [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135502 (owner: 10Legoktm) [18:41:37] (03CR) 10CSteipp: "Thanks Erik, that's helpful. Security seems ok. You probably want to handle the error case in __toString() too." [core] - 10https://gerrit.wikimedia.org/r/137458 (https://bugzilla.wikimedia.org/66199) (owner: 10EBernhardson) [18:41:56] (03CR) 10EBernhardson: [C: 032] "PS5: rebase against the newest code this time." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135502 (owner: 10Legoktm) [18:42:10] (03Abandoned) 10MaxSem: Allow prefixing site notices [core] - 10https://gerrit.wikimedia.org/r/136244 (https://bugzilla.wikimedia.org/65395) (owner: 10MaxSem) [18:42:12] (03Merged) 10jenkins-bot: Provide a comment for the RCFeeds [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135502 (owner: 10Legoktm) [18:42:43] James_F, and suddenly when I've moved on to dealing with a different bug, I start getting errors from the previous thing. sigh [18:44:07] MatmaRex: so with your patch, variant label will become gray? [18:44:13] (03CR) 10Aaron Schulz: [C: 032] API: Add show=unread to ApiQueryWatchlist [core] - 10https://gerrit.wikimedia.org/r/137147 (https://bugzilla.wikimedia.org/65246) (owner: 10Anomie) [18:44:56] liangent: with the last one, yeah, like the other label. should i fix this also in the "intermediary" one? [18:45:02] (03CR) 10Alex Monk: [C: 04-1] Allow VisualEditor users to set if a page whether a Disambiguation [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/133037 (https://bugzilla.wikimedia.org/61073) (owner: 10Alex Monk) [18:45:08] i probably should [18:45:19] i meant to but forgot [18:45:58] RoanKattouw, is there some particular hook I'm supposed to append to wgVisualEditorPluginModules in? [18:46:33] MatmaRex: I'm not sure whether having it gray is good or bad... [18:46:40] Krenair: Yay. [18:46:44] (03PS3) 10EBernhardson: (bug 61939) Topic-titles not displaying in some topics (disappearing?) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/134089 (https://bugzilla.wikimedia.org/61939) (owner: 10Matthias Mullie) [18:46:47] 3MediaWiki / 3Skin and page rendering: Vector's dropdown menus (Variants, More/Actions) feature weird outlines when focused/clicked in Chrome - 10https://bugzilla.wikimedia.org/66388 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None Vector's dropdown menus (Variants, More/Actions) feature weird... [18:46:59] (03CR) 10Bartosz Dziewoński: "Filed the outline thingy as bug 66388." [core] - 10https://gerrit.wikimedia.org/r/137715 (https://bugzilla.wikimedia.org/66363) (owner: 10Bartosz Dziewoński) [18:47:01] (03CR) 10Aaron Schulz: [C: 032] Add HKDF as a fast, random number source [core] - 10https://gerrit.wikimedia.org/r/137077 (owner: 10CSteipp) [18:47:29] liangent: eh [18:47:45] (03Merged) 10jenkins-bot: API: Add show=unread to ApiQueryWatchlist [core] - 10https://gerrit.wikimedia.org/r/137147 (https://bugzilla.wikimedia.org/65246) (owner: 10Anomie) [18:49:00] Krenair: No you can just do it in the global scope [18:49:04] Krenair: See the Math extension for example [18:49:24] But then if someone loads Disambig before VE....? [18:49:30] 3MediaWiki / 3Skin and page rendering: Bug 65434 appears on the "More" arrow and "Variants" arrow - 10https://bugzilla.wikimedia.org/66363#c6 (10Bartosz Dziewoński) 5PATC>3RESO/FIX This should be fixed if I understood the report right. Some issues with outlines are tracked on bug 66388. [18:49:37] Yeah that is a problem [18:49:54] I guess you could use BeforeSetup or something? [18:50:08] (03Merged) 10jenkins-bot: Add HKDF as a fast, random number source [core] - 10https://gerrit.wikimedia.org/r/137077 (owner: 10CSteipp) [18:50:32] (the PS I put in Gerrit doesn't work. I thought it did but must've had some cached version or something) [18:50:43] (looking at the code, it's not right anyway) [18:51:31] 3MediaWiki / 3API: unread count for watchlist changes is not available via API - 10https://bugzilla.wikimedia.org/65246#c17 (10Brad Jorsch) 5PATC>3RESO/FIX a:3Brad Jorsch All the changes have been merged now. This should be deployed to WMF wikis with 1.24wmf9, see https://www.mediawiki.org/wiki/MediaWi... [18:52:14] 3Wikimedia / 3OTRS: Line breaks missing after salutations and before signature lines - 10https://bugzilla.wikimedia.org/55681#c4 (10Douglas Gardner) This appears to be fixed upstream. [18:52:36] (03CR) 10Spage: [C: 04-1] "Things I'm seeing on my local wiki:" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138371 (owner: 10SG) [18:54:23] (03PS4) 10Bartosz Dziewoński: Vector: Hide the superfluous "Variants" menu label again [core] - 10https://gerrit.wikimedia.org/r/138356 (https://bugzilla.wikimedia.org/66364) [18:58:07] (03CR) 10EBernhardson: (bug 61939) Topic-titles not displaying in some topics (disappearing?) (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/134089 (https://bugzilla.wikimedia.org/61939) (owner: 10Matthias Mullie) [18:59:48] (03CR) 10MaxSem: [C: 032] "meh" [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/137509 (owner: 10MaxSem) [18:59:55] (03Merged) 10jenkins-bot: Fix undefined index notice [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/137509 (owner: 10MaxSem) [19:00:53] (03PS1) 10Yurik: Updated PhpStorm style formatting - better aligns with MW style [vagrant] - 10https://gerrit.wikimedia.org/r/138391 [19:00:59] 3MediaWiki extensions / 3AbuseFilter: Add ability to detect deleted revisions and page creation - 10https://bugzilla.wikimedia.org/20892#c4 (10Huji) I think the "number" of deleted revisions is not something that should be exposed publicly (only sysops can see them outside the AbuseFilter, so only sysops can... [19:01:38] (03CR) 10Jdlrobson: [C: 04-2] "-2ing until the dependency has been merged." [core] - 10https://gerrit.wikimedia.org/r/137690 (https://bugzilla.wikimedia.org/48996) (owner: 10Florianschmidtwelzow) [19:01:50] RoanKattouw, what is BeforeSetup? [19:01:52] (03PS3) 10Cscott: Switch from `bluebird` to `es6-shim`/`prfun` for Promise implementation. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138157 [19:01:54] (03PS3) 10Cscott: Use `jpegtran` to purge EXIF data from jpegs. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138149 [19:02:53] (03CR) 10Jdlrobson: "Sorry I meant to -2 the patch in MobileFrontend :)" [core] - 10https://gerrit.wikimedia.org/r/137690 (https://bugzilla.wikimedia.org/48996) (owner: 10Florianschmidtwelzow) [19:03:18] (03PS2) 10Jdlrobson: WIP/POC: Add ability to change file page in last minute [core] - 10https://gerrit.wikimedia.org/r/137690 (https://bugzilla.wikimedia.org/48996) (owner: 10Florianschmidtwelzow) [19:03:29] Krenair: Sorry, AfterSetup I think it's called [19:03:38] I get it confused with BeforePageDisplay all the time [19:03:45] I need something after config is loaded but before ResourceLoaderGetConfigVars [19:04:05] (03CR) 10jenkins-bot: [V: 04-1] Use `jpegtran` to purge EXIF data from jpegs. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138149 (owner: 10Cscott) [19:04:08] Can't find an AfterSetup either.. [19:05:17] RoanKattouw: can you look at https://gerrit.wikimedia.org/r/#/c/138356/? Krinkl.e went AWOL and i want to schedule swats and stuff [19:05:30] (03PS1) 10Jackmcbarn: Add tags from all matching filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/138392 (https://bugzilla.wikimedia.org/66387) [19:06:36] What about BeforeInitialize... [19:07:20] That seems reasonable [19:07:27] I think the hook I was thinking of is SetupAfterCache [19:07:36] But anything that runs after all config is read should be fine [19:09:21] Doesn't look like BeforeInitialize works, SetupAfterCache seems to though [19:10:44] MatmaRex: That patch seems to stop applying those styles to div#mw-head div.vectorMenu h4 , is that intended? [19:11:21] RoanKattouw: yes, there is not

    there, mentioned in the commit summary as "a piece of temporary hacky CSS from Iabda8155" [19:11:21] (03PS13) 10Alex Monk: Allow VisualEditor users to set if a page whether a Disambiguation [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/133037 (https://bugzilla.wikimedia.org/61073) [19:13:50] (03CR) 10Catrope: [C: 032] Vector: Hide the superfluous "Variants" menu label again [core] - 10https://gerrit.wikimedia.org/r/138356 (https://bugzilla.wikimedia.org/66364) (owner: 10Bartosz Dziewoński) [19:15:30] RoanKattouw: <3 [19:16:08] (03CR) 10Catrope: [C: 04-1] "Has unrelated changes to i18n files, but otherwise good to go" [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/133037 (https://bugzilla.wikimedia.org/61073) (owner: 10Alex Monk) [19:16:40] (03Merged) 10jenkins-bot: Vector: Hide the superfluous "Variants" menu label again [core] - 10https://gerrit.wikimedia.org/r/138356 (https://bugzilla.wikimedia.org/66364) (owner: 10Bartosz Dziewoński) [19:17:51] (03PS1) 10Bartosz Dziewoński: Vector: Restore old focus animation on the "More" dropdown [core] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/138397 (https://bugzilla.wikimedia.org/66363) [19:18:05] (03PS1) 10Bartosz Dziewoński: Vector: Hide the superfluous "Variants" menu label again [core] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/138398 (https://bugzilla.wikimedia.org/66364) [19:19:10] (03CR) 10Catrope: [C: 032] "Never mind, I'm an idiot. This is OK" [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/133037 (https://bugzilla.wikimedia.org/61073) (owner: 10Alex Monk) [19:19:49] (03CR) 10Florianschmidtwelzow: "> I'd rather we just changed this in core and removed the link around the image" [core] - 10https://gerrit.wikimedia.org/r/137690 (https://bugzilla.wikimedia.org/48996) (owner: 10Florianschmidtwelzow) [19:20:15] (03Merged) 10jenkins-bot: Allow VisualEditor users to set if a page whether a Disambiguation [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/133037 (https://bugzilla.wikimedia.org/61073) (owner: 10Alex Monk) [19:20:22] (03CR) 10Brian Wolff: "I tend to agree with the min size being too high. I think 600 would probably be the upper limit on what is a good idea, and probably 360 o" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/138307 (owner: 10Brian Wolff) [19:20:25] (03CR) 10GWicke: "I'm happy to +2 this in a few days if no strong objections come up until then." [core] - 10https://gerrit.wikimedia.org/r/136234 (owner: 10Jackmcbarn) [19:22:10] greg-g: https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=115743&oldid=115728 [19:25:20] greg-g: i won't be around at the time of the deploy, i hope that's not a problem. if you need me, i can stick around until the second swat today and it could be deployed then, but the patches could probably simmer on beta for a few more hours today before being backported. [19:26:31] (03PS1) 10Yurik: Refactored validator names, exposed validation status [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/138399 [19:27:31] 3MediaWiki / 3ResourceLoader: ResourceLoader: Modules should be able to specify dependencies evaluated at run-time - 10https://bugzilla.wikimedia.org/66390 (10James Forrester) 3ASSI p:3Unprio s:3enhanc a:3Krinkle Sometimes modules have dependencies that can't be determined until runtime; most obvious... [19:27:45] 3MediaWiki / 3ResourceLoader: ResourceLoader: Modules should be able to specify dependencies evaluated at run-time - 10https://bugzilla.wikimedia.org/66390 (10James Forrester) p:5Unprio>3High [19:27:52] (03PS7) 10Jforrester: [WIP] resourceloader: Implement "skip function" feature [core] - 10https://gerrit.wikimedia.org/r/135085 (https://bugzilla.wikimedia.org/66390) (owner: 10Krinkle) [19:29:09] (03PS1) 10Yurik: JsonConfig API, JC configuration clean up [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/138401 [19:29:29] 3MediaWiki / 3ResourceLoader: ResourceLoader: Modules should be able to specify dependencies evaluated at run-time - 10https://bugzilla.wikimedia.org/66390 (10James Forrester) [19:33:07] (03PS5) 10Bartosz Dziewoński: Stop using a suboptimal structure for Vector's variants menu [core] - 10https://gerrit.wikimedia.org/r/138368 (https://bugzilla.wikimedia.org/43406) [19:33:24] (03PS5) 10Bartosz Dziewoński: Stop using a suboptimal structure for Vector's variants menu (cont.) [core] - 10https://gerrit.wikimedia.org/r/138369 (https://bugzilla.wikimedia.org/43406) [19:35:08] (03CR) 10Ori.livneh: [C: 032] Updated PhpStorm style formatting - better aligns with MW style [vagrant] - 10https://gerrit.wikimedia.org/r/138391 (owner: 10Yurik) [19:35:28] (03Merged) 10jenkins-bot: Updated PhpStorm style formatting - better aligns with MW style [vagrant] - 10https://gerrit.wikimedia.org/r/138391 (owner: 10Yurik) [19:35:30] ori, there are two more patches that badly need your love :) [19:36:05] i'd do anything for love (but i won't +2) [19:36:34] * ori hides [19:36:54] * yurikR2 throws cookies and milk at ori [19:37:41] ori, https://gerrit.wikimedia.org/r/#/c/134388/ is simple - it just puts error messaging at the end of the script in addition, so as to show a summary [19:37:53] only affects git-update command [19:39:29] https://gerrit.wikimedia.org/r/#/c/133120/ seems to have gone through tons of revisions, and i will talk to you about it in person tomorrow ;) [19:39:41] yurikR2: use tput setaf for color codes [19:39:51] eg RED=$(tput setaf 1) [19:39:56] echo "${RED}this is red!" etc [19:40:14] ori, thx, will update [19:44:46] 3MediaWiki extensions / 3SemanticForms: SemanticForms: Fix "JQMIGRATE: jQuery.browser is deprecated" - 10https://bugzilla.wikimedia.org/65668#c5 (10Matthew Flaschen) As I mentioned at the tracking bug (bug 66097), if you need browser detection (i.e. feature detection isn't enough for the issue you're dealing... [19:49:29] (03PS1) 10Arlolra: Sync parserTests.txt with Parsoid [core] - 10https://gerrit.wikimedia.org/r/138406 [19:51:29] 3MediaWiki / 3ResourceLoader: ResourceLoader: Modules should be able to specify dependencies evaluated at run-time - 10https://bugzilla.wikimedia.org/66390#c2 (10Krinkle) Per discussion between Roan and me we're taking this use case as a story rather than a specific call to implementation. We won't be addin... [19:57:02] 3MediaWiki extensions / 3[other]: Fix reference to jQuery Cycle - 10https://bugzilla.wikimedia.org/66391 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None 2f1f0abc6b of core (https://git.wikimedia.org/commit/mediawiki%2Fcore.git/2f1f0abc6b) added a jQuery Cycle file. That is referenced directly... [19:57:26] (03CR) 10Mattflaschen: [C: 031] "Anyone using this via direct include (i.e. a non-supported way), can either fix it properly or just download it again locally as a hack." [core] - 10https://gerrit.wikimedia.org/r/138108 (https://bugzilla.wikimedia.org/66292) (owner: 10Mattflaschen) [20:00:00] 3MediaWiki extensions / 3[other]: Fix reference to jQuery Cycle - 10https://bugzilla.wikimedia.org/66391 (10Matthew Flaschen) [20:00:00] 3MediaWiki / 3JavaScript: jquery.cycle.all.js uses jQuery.browser - 10https://bugzilla.wikimedia.org/66292 (10Matthew Flaschen) [20:00:19] (03CR) 10Krinkle: [C: 032] Remove unused jquery.cycle.all.js file [core] - 10https://gerrit.wikimedia.org/r/138108 (https://bugzilla.wikimedia.org/66292) (owner: 10Mattflaschen) [20:01:05] (03PS2) 10Arlolra: Sync parserTests.txt with Parsoid [core] - 10https://gerrit.wikimedia.org/r/138406 [20:01:14] 3MediaWiki extensions / 3[other]: Fix reference to jQuery Cycle in UnitTest extension - 10https://bugzilla.wikimedia.org/66391 (10Matthew Flaschen) [20:03:29] 3MediaWiki extensions / 3[other]: UnitTest: Don't include jQuery Cycle Plugin file from mediawiki core directly - 10https://bugzilla.wikimedia.org/66391 (10Krinkle) [20:04:00] 3MediaWiki extensions / 3[other]: UnitTest: Fix reference to jQuery Cycle Plugin - 10https://bugzilla.wikimedia.org/66391#c1 (10Krinkle) Arr. mid-air collision. [20:04:12] (03Merged) 10jenkins-bot: Remove unused jquery.cycle.all.js file [core] - 10https://gerrit.wikimedia.org/r/138108 (https://bugzilla.wikimedia.org/66292) (owner: 10Mattflaschen) [20:07:44] (03PS3) 10Cscott: Sync up with Parsoid parserTests [core] - 10https://gerrit.wikimedia.org/r/138406 (owner: 10Arlolra) [20:08:59] (03CR) 10Scnd: "In poetry it's 50/50 needed, but in other texts it's 100% needed." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/135546 (owner: 10Krinkle) [20:09:32] 3MediaWiki / 3JavaScript: jquery.cycle.all.js uses jQuery.browser - 10https://bugzilla.wikimedia.org/66292 (10Matthew Flaschen) 5PATC>3RESO/FIX a:5Matthew Flaschen>3Krinkle [20:09:44] (03CR) 10Cscott: [C: 04-1] "It looks like you didn't use the tests/sync-parserTests.js script?" [core] - 10https://gerrit.wikimedia.org/r/138406 (owner: 10Arlolra) [20:15:00] (03PS4) 10Cscott: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/138406 (owner: 10Arlolra) [20:16:07] (03PS1) 10Bartosz Dziewoński: Vector: Update comments in vector.js [core] - 10https://gerrit.wikimedia.org/r/138410 [20:16:11] (03CR) 10Cscott: [C: 031] "Regenerated with tests/sync-parserTests.js -- results in no changes to the actual parserTests.txt file, so looks good to me." [core] - 10https://gerrit.wikimedia.org/r/138406 (owner: 10Arlolra) [20:16:31] (03CR) 10Anomie: [C: 031] "Looks sane. Haven't tested." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/138392 (https://bugzilla.wikimedia.org/66387) (owner: 10Jackmcbarn) [20:16:43] (03CR) 10Subramanya Sastry: [C: 032] Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/138406 (owner: 10Arlolra) [20:17:21] 3MediaWiki extensions / 3ConfirmEdit (CAPTCHA extension): Stop Forum Spam - 10https://bugzilla.wikimedia.org/66392 (10David Weir (satdav)) 3UNCO p:3Unprio s:3normal a:3None Hello Ihave been told to add this to this componant http://www.stopforumspam.com/contributions We would need this added to th... [20:18:14] (03PS6) 10EBernhardson: Correct output of wfMessage( 'non-existent-msg' )->text() [core] - 10https://gerrit.wikimedia.org/r/137458 (https://bugzilla.wikimedia.org/66199) [20:19:17] (03CR) 10EBernhardson: "Updated Message::__toString() to output the same as Message::toString(), not sure how to trigger an Exception within a unit test on Messa" [core] - 10https://gerrit.wikimedia.org/r/137458 (https://bugzilla.wikimedia.org/66199) (owner: 10EBernhardson) [20:20:32] (03CR) 10Chad: [C: 032] Default to larger snippets [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/137952 (owner: 10Manybubbles) [20:20:34] (03Merged) 10jenkins-bot: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/138406 (owner: 10Arlolra) [20:20:46] (03CR) 10jenkins-bot: [V: 04-1] Default to larger snippets [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/137952 (owner: 10Manybubbles) [20:23:57] (03CR) 10Chad: "Yippie, failure in unrelated test from another extension!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/137952 (owner: 10Manybubbles) [20:28:51] (03CR) 10EBernhardson: [C: 04-1] Set $wgLogActionsHandlers properly for back-compat strings (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/138214 (https://bugzilla.wikimedia.org/66331) (owner: 10Legoktm) [20:32:44] ori, switching to tput complains: tput: No value for $TERM and no -T specified -- although when i run the same script from vagrant ssh, it works ok. Do you know if vagrant on windows is misconfigured? [20:33:09] i run it from msysgit, not regular shell [20:33:40] dunno [20:33:49] if it's an issue you can use the literal escape codes i guess, not worth too much effort [20:34:03] ori, in that case please +2 as is :) [20:34:24] what's the change again? [20:34:42] https://gerrit.wikimedia.org/r/#/c/134388/ [20:34:52] (03PS3) 10Ori.livneh: Improved error messages for git-update command [vagrant] - 10https://gerrit.wikimedia.org/r/134388 (owner: 10Yurik) [20:35:07] I suspect that we should address the issue in the long run - as I'm sure there are other scripts that take advantage of that TERM or -T value... [20:35:08] (03CR) 10Ori.livneh: [C: 032] Improved error messages for git-update command [vagrant] - 10https://gerrit.wikimedia.org/r/134388 (owner: 10Yurik) [20:35:12] (03Merged) 10jenkins-bot: Improved error messages for git-update command [vagrant] - 10https://gerrit.wikimedia.org/r/134388 (owner: 10Yurik) [20:35:20] ori, but what about the URL patch? [20:35:37] one at a time [20:35:40] the way i changed it, it won't affect anyone unless specifically set the value :) [20:37:09] (03CR) 10EBernhardson: [C: 032] "S, your concerns don't look to be related to this patch but the nhe ext patch in tseries. This is now just renaming the files and comment" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138371 (owner: 10SG) [20:37:49] (03Merged) 10jenkins-bot: Move templates and fix handlebars.js compatbility [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138371 (owner: 10SG) [20:38:51] (03PS1) 10EBernhardson: Merge remote-tracking branch 'gerrit/master' into frontend-rewrite [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138455 [20:39:17] (03CR) 10EBernhardson: [C: 032] Merge remote-tracking branch 'gerrit/master' into frontend-rewrite [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138455 (owner: 10EBernhardson) [20:39:33] (03Merged) 10jenkins-bot: Merge remote-tracking branch 'gerrit/master' into frontend-rewrite [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138455 (owner: 10EBernhardson) [20:40:09] (03Abandoned) 10Awight: Prepare for name-based virtualhosting [vagrant] - 10https://gerrit.wikimedia.org/r/95471 (owner: 10Awight) [20:40:31] (03PS11) 10GWicke: Add PPFrame::getTTL() and setTTL() [core] - 10https://gerrit.wikimedia.org/r/135887 (https://bugzilla.wikimedia.org/49803) (owner: 10Jackmcbarn) [20:40:34] (03CR) 10EBernhardson: [C: 032] POST actions can also be rendered [extensions/Flow] - 10https://gerrit.wikimedia.org/r/138331 (owner: 10Matthias Mullie) [20:41:28] !log upgraded elastic1007-elastic1010 without issue - starting elastic1010 [20:42:00] (03Merged) 10jenkins-bot: POST actions can also be rendered [extensions/Flow] - 10https://gerrit.wikimedia.org/r/138331 (owner: 10Matthias Mullie) [20:42:05] wrong window.... [20:43:06] (03CR) 10Krinkle: initial commit for Extension:ActivityMonitor (0311 comments) [extensions/ActivityMonitor] - 10https://gerrit.wikimedia.org/r/138042 (owner: 10Harshkothari410) [20:43:30] (03CR) 10Krinkle: initial commit for Extension:ActivityMonitor (031 comment) [extensions/ActivityMonitor] - 10https://gerrit.wikimedia.org/r/138042 (owner: 10Harshkothari410) [20:43:33] (03CR) 10GWicke: [C: 032] "Lets get this in. There already some other patches like https://gerrit.wikimedia.org/r/#/c/136619/ (for Lua) and https://gerrit.wikimedia." [core] - 10https://gerrit.wikimedia.org/r/135887 (https://bugzilla.wikimedia.org/49803) (owner: 10Jackmcbarn) [20:43:37] (03CR) 10Manybubbles: "recheck" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/137952 (owner: 10Manybubbles) [20:44:20] (03CR) 10EBernhardson: [C: 031] "lgtm" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/132145 (owner: 10Matthias Mullie) [20:44:28] (03CR) 10Bartosz Dziewoński: [C: 032] Adding a default PHP entry point [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/137640 (owner: 10Hashar) [20:44:41] (03Merged) 10jenkins-bot: Adding a default PHP entry point [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/137640 (owner: 10Hashar) [20:46:04] (03CR) 10Bartosz Dziewoński: Cast mediawiki.Title.parse's title argument to a string before operating on it (031 comment) [core] - 10https://gerrit.wikimedia.org/r/137489 (owner: 10Trevor Parscal) [20:46:37] (03Merged) 10jenkins-bot: Add PPFrame::getTTL() and setTTL() [core] - 10https://gerrit.wikimedia.org/r/135887 (https://bugzilla.wikimedia.org/49803) (owner: 10Jackmcbarn) [20:49:06] (03CR) 10GWicke: [C: 031] "I didn't verify each detail of the TTL calculation logic, but it looks reasonable to me." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/136617 (owner: 10Jackmcbarn) [20:51:09] Krinkle: should we change that core.js code or just keep as it is for initial commit ? [20:52:21] (03PS1) 10Cscott: Update dependencies. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/138460 [20:52:43] (03PS6) 10Umherirrender: Fixes to Special:TrackingCategories [core] - 10https://gerrit.wikimedia.org/r/126950 [20:52:52] (03CR) 10jenkins-bot: [V: 04-1] Update dependencies. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/138460 (owner: 10Cscott) [20:53:10] harshkothari: If we want to look at it again for inspiration, we still have that codepen url, so maybe it's better to leave most or all of it out? [20:53:12] Your call :) [20:54:20] Krinkle: I guess we should just move this output into content window. [20:54:45] $('#mw-content-text') probably [20:54:55] yeah [20:54:59] Or create an element on SpecialActivityMonitor.php and use that [20:55:40] Krinkle: example ? [20:56:39] SpecialActMonphp: OutputPage::addHtml div#mw-activitymonitor-feed; ext.actMon.js: $('#mw-activitymonitor-feed) [20:56:42] harshkothari: [20:57:01] (03CR) 10GWicke: [C: 031] Add a TTL to #time and #timel output [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/136618 (owner: 10Jackmcbarn) [20:57:30] (03CR) 10Bartosz Dziewoński: Fix "CSSMin url() value remapping not working in certain obscure cases" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/138286 (https://bugzilla.wikimedia.org/60077) (owner: 10Foxtrott) [20:57:37] (03PS5) 10Bartosz Dziewoński: Fix "CSSMin url() value remapping not working in certain obscure cases" [core] - 10https://gerrit.wikimedia.org/r/138286 (https://bugzilla.wikimedia.org/60077) (owner: 10Foxtrott) [20:57:43] Krinkle: got it :) Lets try. Btw as per your opinion create element in SpecialActivityMonitor.php would be better choice ? [20:57:47] (03CR) 10Bartosz Dziewoński: [C: 04-1] Fix "CSSMin url() value remapping not working in certain obscure cases" [core] - 10https://gerrit.wikimedia.org/r/138286 (https://bugzilla.wikimedia.org/60077) (owner: 10Foxtrott) [20:58:33] (03CR) 10Bartosz Dziewoński: [C: 032] ResourceLoaderLESSFunctions: Quote CSS data: URIs if needed [core] - 10https://gerrit.wikimedia.org/r/138326 (owner: 10QChris) [20:59:29] thedj, hey [21:02:00] 3MediaWiki / 3General/Unknown: Calculated Age of persons can become outdated until next cache purge - 10https://bugzilla.wikimedia.org/49803#c14 (10Gabriel Wicke) Also related: https://gerrit.wikimedia.org/r/#/c/136617/, https://gerrit.wikimedia.org/r/#/c/136618/ and https://gerrit.wikimedia.org/r/#/c/136619/. [21:02:19] (03Merged) 10jenkins-bot: ResourceLoaderLESSFunctions: Quote CSS data: URIs if needed [core] - 10https://gerrit.wikimedia.org/r/138326 (owner: 10QChris) [21:05:44] (03CR) 10Bartosz Dziewoński: "Is there anything problematic about this or can it be merged already?" [core] - 10https://gerrit.wikimedia.org/r/135383 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [21:05:59] 3MediaWiki / 3Page editing: Improve Special:MergeHistory and disallow history merges from Special:Undelete - 10https://bugzilla.wikimedia.org/66155 (10Ori Livneh) [21:06:11] (03CR) 10Mattflaschen: [C: 04-1] "Whitespace still needs to be addressed. If you say which editor you're using, we may be able to help further." (033 comments) [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/134624 (owner: 10Paladox) [21:06:59] 3MediaWiki extensions / 3ConfirmEdit (CAPTCHA extension): Stop Forum Spam - 10https://bugzilla.wikimedia.org/66392#c1 (10Andre Klapper) Hi David, what is "this"? It's not clear to me what the request is exactly here... :( (For general info, see https://www.mediawiki.org/wiki/How_to_report_a_bug ) [21:07:39] (03PS1) 10Krinkle: Remove link to mediawiki-core nightlies (no longer active) [integration/docroot] - 10https://gerrit.wikimedia.org/r/138464 [21:08:05] (03CR) 10Krinkle: [C: 032] Remove link to mediawiki-core nightlies (no longer active) [integration/docroot] - 10https://gerrit.wikimedia.org/r/138464 (owner: 10Krinkle) [21:08:06] (03Merged) 10jenkins-bot: Remove link to mediawiki-core nightlies (no longer active) [integration/docroot] - 10https://gerrit.wikimedia.org/r/138464 (owner: 10Krinkle) [21:08:39] (03PS5) 10Awight: WIP payments.wmo instance for accepting donations [vagrant] - 10https://gerrit.wikimedia.org/r/135326 [21:09:38] (03PS2) 10Cscott: Update dependencies. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/138460 [21:09:40] (03PS1) 10Cscott: Tweak jshint configuration; use strict. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/138465 [21:10:01] (03CR) 10Awight: "Looks like I'm a bit stuck--we rely on checking out a branched release of MW-core, which is still incompatible with the way multiwiki reus" [vagrant] - 10https://gerrit.wikimedia.org/r/135326 (owner: 10Awight) [21:10:17] (03PS1) 10Krinkle: Fix insecure content warnings (HTTPS for ganglia.wmflabs.org) [integration/docroot] - 10https://gerrit.wikimedia.org/r/138466 [21:10:29] 3MediaWiki / 3Parser: HHVM segfaults when calling Parser->callParserFunction - 10https://bugzilla.wikimedia.org/65796#c6 (10Ori Livneh) Created attachment 15610 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15610&action=edit stack trace from osmium This is still happening.. [21:10:33] (03CR) 10Krinkle: [C: 032] Fix insecure content warnings (HTTPS for ganglia.wmflabs.org) [integration/docroot] - 10https://gerrit.wikimedia.org/r/138466 (owner: 10Krinkle) [21:10:36] (03Merged) 10jenkins-bot: Fix insecure content warnings (HTTPS for ganglia.wmflabs.org) [integration/docroot] - 10https://gerrit.wikimedia.org/r/138466 (owner: 10Krinkle) [21:11:13] (03Abandoned) 10Bartosz Dziewoński: Making the Modern skin more self-contained [core] - 10https://gerrit.wikimedia.org/r/131997 (owner: 10Luis Felipe Schenone) [21:12:44] 3MediaWiki / 3Page editing: Improve Special:MergeHistory and disallow history merges from Special:Undelete - 10https://bugzilla.wikimedia.org/66155#c1 (10Brad Jorsch) (In reply to Tim Starling from comment #0) > Once this is done, the mergehistory right can be given to sysops by default > in the MW core and... [21:19:49] (03PS9) 10Physikerwelt: Separate render and getHtml [extensions/Math] - 10https://gerrit.wikimedia.org/r/138023 [21:21:56] bd808|BUFFER: I tried provisioning Fundraising's wiki using the puppet Multiwiki module and found that our needs are still a bit orthogonal. Fundraising maintains a MW release branch for PCI compliance, but multiwiki is not designed to allow for multiple checkouts of MediaWiki. Is that something that has been considered for the future? [21:22:02] (03PS10) 10Physikerwelt: Separate render and getHtml [extensions/Math] - 10https://gerrit.wikimedia.org/r/138023 [21:22:20] awight: You might have to wait a while for Bryan to respond to that, he's on vacation [21:23:04] RoanKattouw: ok, thanks for the heads-up [21:28:21] (03PS1) 10Cscott: Switch from `when` to `bluebird` for Promise implementation. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/138468 [21:28:23] (03PS1) 10Cscott: Switch from `bluebird` to `es6-shim`/`prfun` for Promise implementation. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/138469 [21:30:45] (03CR) 10Cscott: [C: 032] Tweak jshint configuration; use strict. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/138465 (owner: 10Cscott) [21:30:59] (03Merged) 10jenkins-bot: Tweak jshint configuration; use strict. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/138465 (owner: 10Cscott) [21:31:08] cscott_away: mwalker just curious, is OCG currently in proeuction? [21:31:10] *production [21:31:12] (03CR) 10Cscott: [C: 032] Update dependencies. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/138460 (owner: 10Cscott) [21:31:33] (03Merged) 10jenkins-bot: Update dependencies. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/138460 (owner: 10Cscott) [21:32:24] YuviPanda|zz, only in beta labs; there is a production server, tantalum, but it's not accessible from anything right now [21:32:36] mwalker: ah, cool. [21:32:39] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (098f84f8a0) [core] - 10https://gerrit.wikimedia.org/r/138470 [21:33:27] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (098f84f8a0) [core] - 10https://gerrit.wikimedia.org/r/138470 (owner: 10Jforrester) [21:34:59] 3Analytics / 3Wikimetrics: When scheduling a recurrent report the 1st run of the report is not kicked right away - 10https://bugzilla.wikimedia.org/66280 (10Dan Andreescu) [21:37:02] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (098f84f8a0) [core] - 10https://gerrit.wikimedia.org/r/138470 (owner: 10Jforrester) [21:38:06] Krinkle: why messages are not coming ? [21:38:14] 3Analytics / 3Wikimetrics: Path to recurrent report should have better semantics - 10https://bugzilla.wikimedia.org/66087 (10Dan Andreescu) [21:38:48] harshkothari: what message? [21:39:00] message from en.json [21:39:08] (03PS7) 10Jackmcbarn: Support {{!}} as a magic word [core] - 10https://gerrit.wikimedia.org/r/136234 [21:39:23] harshkothari: Are you asking why they are not working? [21:39:25] (03CR) 10Jackmcbarn: "Rebased to fix a conflict in the release notes (again)." [core] - 10https://gerrit.wikimedia.org/r/136234 (owner: 10Jackmcbarn) [21:39:36] Krinkle: yeah. everything seems correct [21:39:45] harshkothari: https://gerrit.wikimedia.org/r/#/c/138042/2/i18n/en.json [21:39:48] I told you already :) [21:39:56] I finished the review per your request [21:39:59] 3Wikimedia / 3Extension setup: Review and deploy Property Suggestor - 10https://bugzilla.wikimedia.org/66382 (10Greg Grossmeier) [21:40:16] harshkothari: The trailing comma is a syntax error in JSON [21:40:55] Krinkle: I removed it still not working let me check cache [21:43:54] (03PS6) 10Foxtrott: Fix "CSSMin url() value remapping not working in certain obscure cases" [core] - 10https://gerrit.wikimedia.org/r/138286 (https://bugzilla.wikimedia.org/60077) [21:44:25] (03PS7) 10Foxtrott: Fix "CSSMin url() value remapping not working in certain obscure cases" [core] - 10https://gerrit.wikimedia.org/r/138286 (https://bugzilla.wikimedia.org/60077) [21:45:36] (03PS1) 10Withoutaname: Initializing extension files for git repository [extensions/UserGroups] - 10https://gerrit.wikimedia.org/r/138472 [21:46:20] (03CR) 10Foxtrott: Fix "CSSMin url() value remapping not working in certain obscure cases" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/138286 (https://bugzilla.wikimedia.org/60077) (owner: 10Foxtrott) [21:47:06] (03CR) 10Tim Starling: [C: 04-1] "OK with me, I guess." [core] - 10https://gerrit.wikimedia.org/r/136234 (owner: 10Jackmcbarn) [21:48:33] heh [21:48:35] Tim-away: re "deployment scheduling", will that not be able to go out with the MediaWiki train? [21:50:16] (03CR) 10Mattflaschen: "Alright, I'm fine with putting in the release notes without labeling it a breaking change." [core] - 10https://gerrit.wikimedia.org/r/122838 (https://bugzilla.wikimedia.org/63343) (owner: 10Phuedx) [21:50:49] (03PS8) 10Foxtrott: Fix "CSSMin url() value remapping not working in certain obscure cases" [core] - 10https://gerrit.wikimedia.org/r/138286 (https://bugzilla.wikimedia.org/60077) [21:52:16] jackmcbarn: I just mean choosing what WMF release it would go into [21:52:39] ok. and is there a "best" place to announce that? would a line in tech news be good, or should it go somewhere else? [21:53:52] that's greg-g's job [21:54:15] 3MediaWiki extensions / 3WikidataRepo: wblinktitles id in api response does not start with a q, it is a raw int id - 10https://bugzilla.wikimedia.org/52732 (10Marius Hoch) 5PATC>3RESO/FIX [21:54:34] good. less work for me ;) [21:54:35] thanks [21:55:08] (03CR) 10Withoutaname: [C: 032 V: 032] Initializing extension files for git repository [extensions/UserGroups] - 10https://gerrit.wikimedia.org/r/138472 (owner: 10Withoutaname) [21:55:13] (03PS1) 10Brian Wolff: Make inputbox use fully qualified mode in action=render [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/138473 [22:04:18] * greg-g looks up [22:04:40] Why is the login button on phabicrator a power button? [22:04:58] (specifically feels like pressing it will turn off phabricator) [22:05:12] lol [22:05:32] with great power comes great responsibility [22:05:34] don't login [22:05:49] And the mediawiki login button has an amazon logo on it [22:05:55] it uses a sprite without any background offset [22:06:06] is phabricator in the 'serious business mode'? [22:06:13] becuase when not, it has all kinds of "funny" things [22:06:16] * Krinkle tries to find the search feature and potentially file two bugs [22:06:46] ebernhardson: it is [22:06:55] greg-g: boorrrinng [22:07:00] :) [22:07:05] clowncopterize ftw [22:07:22] Krinkle: the amazon thing is known, i think [22:07:31] (or at least i've heard about it) [22:07:31] So how do I actually file a bug? [22:07:48] + Create new: Maniphest Task, Pholio Mock, Paste [22:07:53] none of those I think [22:08:03] going to Projects first yields an empty list, no MediaWiki or Phab component. [22:08:08] I've created a task before. [22:08:11] Maniphest [22:08:11] Maybe it changed? [22:08:12] Krinkle: maniphest [22:08:22] I don't even know what a maniphest is? [22:08:26] it's a pest [22:08:26] * Krinkle opens dictionary [22:08:27] like a bug [22:08:31] Krinkle: like 'bugzilla" [22:08:33] it totally needs fewer icons and more text, heh [22:08:37] or "trac" [22:08:41] or "redmine" [22:08:45] Right [22:08:53] * MatmaRex hates icons [22:09:41] Text browsers for all! [22:10:09] jackmcbarn: hey, just read the gerrit change. Please write up a "What do people need to know" with this change and send it to wikitech-l for discussion (per Tim's suggestion) [22:14:56] (03PS6) 10Krinkle: Add mw.track calls for jquery.migrate [core] - 10https://gerrit.wikimedia.org/r/133235 [22:15:53] (03CR) 10Greg Grossmeier: "Please write up a "What do people need to know" with this change and send it to wikitech-l for discussion." [core] - 10https://gerrit.wikimedia.org/r/136234 (owner: 10Jackmcbarn) [22:17:33] (03CR) 10Ori.livneh: [C: 032] Add mw.track calls for jquery.migrate [core] - 10https://gerrit.wikimedia.org/r/133235 (owner: 10Krinkle) [22:18:34] (03PS3) 10Harshkothari410: initial commit for Extension:ActivityMonitor [extensions/ActivityMonitor] - 10https://gerrit.wikimedia.org/r/138042 [22:19:04] Krinkle: new patch set [22:20:33] (03Merged) 10jenkins-bot: Add mw.track calls for jquery.migrate [core] - 10https://gerrit.wikimedia.org/r/133235 (owner: 10Krinkle) [22:20:57] (03CR) 10Krinkle: initial commit for Extension:ActivityMonitor (031 comment) [extensions/ActivityMonitor] - 10https://gerrit.wikimedia.org/r/138042 (owner: 10Harshkothari410) [22:21:00] harshkothari: ^ [22:21:21] one small thing, the rest is good [22:22:19] Krinkle: I am somehow bad at css. [22:22:41] That's okay, coding style helps with most of that. [22:22:54] (03PS1) 10Bsitu: A couple of fixes to frontend-rewrite [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138478 [22:24:24] (03PS4) 10Harshkothari410: initial commit for Extension:ActivityMonitor [extensions/ActivityMonitor] - 10https://gerrit.wikimedia.org/r/138042 [22:24:46] How can I update my local gerrit changeset to up-to-date? [22:25:02] Krinkle: done :) [22:26:13] devunt: Do you mean how to rebase? [22:26:31] 3MediaWiki extensions / 3General/Unknown: Perf review of Property Suggestor - php part - 10https://bugzilla.wikimedia.org/66381 (10Greg Grossmeier) p:5Unprio>3Normal a:3Aaron Schulz [22:26:58] emm [22:27:10] devunt: Generally speaking you do something along the lines of: git checkout master; git pull; git review -d ; git rebase origin/mster; git review [22:29:58] I committed new changeset, and other person has committed new patchset #2 on my changeset [22:30:10] so I want to get patchset #2 to my local repository [22:30:22] (03CR) 10Brian Wolff: "Skizzerz: Is your +1 meant to mean you think this should be merged? If so, I'll give it a +2 based on your review as you're the MSSQL expe" [core] - 10https://gerrit.wikimedia.org/r/135714 (https://bugzilla.wikimedia.org/65757) (owner: 10Rillke) [22:31:43] devunt: oh. If you have git-review installed you can just do: git review -d [22:33:57] devunt: For example, on https://gerrit.wikimedia.org/r/#/c/137519/ you can do git review -d 137519 or you can do git review -d I0f17c4d164 [22:34:37] but that command would create new branch, not applying in exists branch. [22:34:49] applying/updating [22:37:10] To clarify, do you want to make you existing branch be what's currently on gerrit (That would be git reset --hard ), or do you have a new commit in your current branch you want to apply over top of what's in gerrit (which you can do with git rebase -i ) [22:42:40] (03CR) 10Brian Wolff: [C: 031] "This looks good to me. And I'll probably merge this soon." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135756 (owner: 10Rillke) [22:43:17] (03PS1) 10EBernhardson: Accept API params in same format as normal URL [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138481 [22:47:00] 3MediaWiki extensions / 3Nuke: Create a log and revert function for Special:Nuke - 10https://bugzilla.wikimedia.org/15942#c7 (10TeleComNasSprVen) 5NEW>3RESO/WON I also don't feel creating another log is worth the time and resources. [22:48:14] (03CR) 10Krinkle: [C: 032] initial commit for Extension:ActivityMonitor [extensions/ActivityMonitor] - 10https://gerrit.wikimedia.org/r/138042 (owner: 10Harshkothari410) [22:48:31] gwicke: Can I bug you for a sec? [22:48:43] (03CR) 10Krinkle: initial commit for Extension:ActivityMonitor (031 comment) [extensions/ActivityMonitor] - 10https://gerrit.wikimedia.org/r/138042 (owner: 10Harshkothari410) [22:50:54] bawolff, when I typed: git checkout bug/63755; git show; than commit message is 'Remove obsoleted RC_MOVE and RC_MOVE_OVER_REDIRECT rc_types values' [22:51:22] but in the gerrit, it is 'Remove obsolete RC_MOVE and RC_MOVE_OVER_REDIRECT rc types' (changed by K·rinkle) [22:51:27] (03PS1) 10Withoutaname: Add core extension files/classes [extensions/UserGroups] - 10https://gerrit.wikimedia.org/r/138484 [22:52:36] devunt: bug/63755 is your original local branch right? [22:52:43] yes. [22:52:52] and the topic of the changeset [22:53:38] So if you want to convert that branch to be like the one in gerrit (and it doesn't have any changes that isn't in gerrit) [22:54:03] (03PS2) 10Withoutaname: Add core extension files/classes [extensions/UserGroups] - 10https://gerrit.wikimedia.org/r/138484 [22:54:08] yes. [22:54:20] in that branch do git reset --hard review/devunt/bug/63755 [22:54:39] assuming that review/devunt/bug/63755 is where git-review downloaded the thing from gerrit [22:55:31] (03CR) 10Withoutaname: [C: 032 V: 032] Add core extension files/classes [extensions/UserGroups] - 10https://gerrit.wikimedia.org/r/138484 (owner: 10Withoutaname) [22:56:57] (03PS1) 10Withoutaname: Revert "Add core extension files/classes" [extensions/UserGroups] - 10https://gerrit.wikimedia.org/r/138485 [22:57:02] oh, so there is no way to do this in just simple one command? [22:58:18] (03CR) 10Withoutaname: [C: 032 V: 032] Revert "Add core extension files/classes" [extensions/UserGroups] - 10https://gerrit.wikimedia.org/r/138485 (owner: 10Withoutaname) [22:58:47] (03PS1) 10Withoutaname: Revert "Revert "Add core extension files/classes"" [extensions/UserGroups] - 10https://gerrit.wikimedia.org/r/138486 [22:58:51] (03PS5) 10Harshkothari410: initial commit for Extension:ActivityMonitor [extensions/ActivityMonitor] - 10https://gerrit.wikimedia.org/r/138042 [22:59:47] devunt: you can do: [23:00:17] git fetch ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/19/137519/3 && git checkout bug/63755 && git reset --hard FETCH_HEAD [23:01:57] Most people just work in the review/devunt/bug/63755 branch that git-review creates instead of trying to make it go in the original branch [23:03:59] (03CR) 10MaxSem: [C: 032] MobileApp: cherrypick https://gerrit.wikimedia.org/r/#/c/137930/ [core] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/138366 (owner: 10MaxSem) [23:04:21] (03CR) 10MaxSem: [C: 032] MobileApp: cherrypick https://gerrit.wikimedia.org/r/#/c/137930/ [core] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/138374 (owner: 10MaxSem) [23:07:16] (03Merged) 10jenkins-bot: MobileApp: cherrypick https://gerrit.wikimedia.org/r/#/c/137930/ [core] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/138366 (owner: 10MaxSem) [23:07:58] (03Merged) 10jenkins-bot: MobileApp: cherrypick https://gerrit.wikimedia.org/r/#/c/137930/ [core] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/138374 (owner: 10MaxSem) [23:08:57] bawolff, thanks you [23:09:04] (especially for last information) [23:09:29] 3Wikimedia / 3Site requests: Allow bureaucrats to grant translationadmin on legalteamwiki - 10https://bugzilla.wikimedia.org/66377#c4 (10John F. Lewis) 5PATC>3RESO/FIX Deployed. Asked James to verify this however. [23:09:35] no problem [23:10:03] (03CR) 10Ori.livneh: More optimizations to User::saveOptions() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/137977 (owner: 10Aaron Schulz) [23:10:30] 3Wikimedia / 3Site requests: Allow bureaucrats to grant translationadmin on legalteamwiki - 10https://bugzilla.wikimedia.org/66377 (10James Alexander) 5RESO/?>3VERI [23:11:52] (03PS1) 10Krinkle: Create standard mwext-ActivityMonitory jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138488 [23:14:17] 3MediaWiki extensions / 3WikidataRepo: Wikidata - Entering a quantity to property (as P1082) adds an unwanted '±1' - 10https://bugzilla.wikimedia.org/66395 (10gladjonatan) 3UNCO p:3Unprio s:3normal a:3Wikidata bugs (This is a badly placed and phrased bug report) When I entered '54' to P1082 (populat... [23:15:03] (03PS2) 10Withoutaname: Revert "Revert "Add core extension files/classes"" [extensions/UserGroups] - 10https://gerrit.wikimedia.org/r/138486 [23:15:13] (03CR) 10Krinkle: [C: 032] "Deployed mwext-ActivityMonitory-lint, mwext-ActivityMonitory-jslint, mwext-ActivityMonitory-phpcs-HEAD and mwext-ActivityMonitory-testexte" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138488 (owner: 10Krinkle) [23:15:43] (03Merged) 10jenkins-bot: Create standard mwext-ActivityMonitory jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138488 (owner: 10Krinkle) [23:15:45] 3MediaWiki extensions / 3WikidataRepo: Wikidata - Entering a quantity to property (as P1082) adds an unwanted '±1' - 10https://bugzilla.wikimedia.org/66395 (10gladjonatan) [23:18:23] (03PS1) 10Krinkle: Enable mwext-ActivityMonitor-lint and mwext-ActivityMonitor-jslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138490 [23:19:36] (03CR) 10Krinkle: [C: 032] Enable mwext-ActivityMonitor-lint and mwext-ActivityMonitor-jslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138490 (owner: 10Krinkle) [23:19:45] (03Merged) 10jenkins-bot: Enable mwext-ActivityMonitor-lint and mwext-ActivityMonitor-jslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138490 (owner: 10Krinkle) [23:24:33] (03PS1) 10Jack Phoenix: Updated the ugly method for injecting favorite sport/team/thought for the team things to the signup form + fixed three "The for attribute of the label element must refer to a form control" HTML validation issues. [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/138492 [23:26:16] (03CR) 10Jack Phoenix: [C: 032 V: 032] Updated the ugly method for injecting favorite sport/team/thought for the team things to the signup form + fixed three "The for attribute of [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/138492 (owner: 10Jack Phoenix) [23:28:27] (03PS7) 10Withoutaname: Add new ParserFunction "BLOCKEXPIRY" [core] - 10https://gerrit.wikimedia.org/r/133661 (https://bugzilla.wikimedia.org/32819) [23:30:15] (03PS1) 10Bsitu: Display topic & post moderatiion State [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138496 [23:30:36] (03PS2) 10Bsitu: Display topic & post moderation state [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138496 [23:33:44] 3MediaWiki extensions / 3Petition: Security review of Petition extension before WMF deployment - 10https://bugzilla.wikimedia.org/65850#c2 (10Chris Steipp) At an architectural level, there's a couple of things that concern me: * It seems like a violation of least privilege / separation of duty that those wh... [23:34:33] (03CR) 10Brian Wolff: "Not this commits fault, but would be cool if the subheading was also in the Special:log/suppress?offender=foo log." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/137581 (https://bugzilla.wikimedia.org/27707) (owner: 10devunt) [23:35:06] (03PS6) 10Krinkle: Initial commit [extensions/ActivityMonitor] - 10https://gerrit.wikimedia.org/r/138042 (owner: 10Harshkothari410) [23:35:08] (03CR) 10jenkins-bot: [V: 04-1] Initial commit [extensions/ActivityMonitor] - 10https://gerrit.wikimedia.org/r/138042 (owner: 10Harshkothari410) [23:35:29] (03CR) 10Mattflaschen: "There's some kind of special handling for the sidebar at https://git.wikimedia.org/blob/mediawiki%2Fcore.git/fc67642d0684e5e043ea0c552775a" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/137528 (https://bugzilla.wikimedia.org/65514) (owner: 10Mattflaschen) [23:36:15] Krinkle: what is the problem for failure ? [23:36:24] harshkothari: I made a silly typo [23:36:34] !g I82f531bf2c2217cfe52 [23:36:34] https://gerrit.wikimedia.org/r/#q,I82f531bf2c2217cfe52,n,z [23:36:37] ActivityMonitory -> ActivityMonitor [23:36:46] okies [23:37:09] (03PS1) 10Krinkle: Follows-up I82f531bf2c2217cfe52: Fix typo in "ActivityMonitor" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138498 [23:37:43] (03CR) 10Jackmcbarn: [C: 031] "Looks good, haven't tested yet." [core] - 10https://gerrit.wikimedia.org/r/133661 (https://bugzilla.wikimedia.org/32819) (owner: 10Withoutaname) [23:40:32] (03CR) 10Krinkle: [C: 032] "Deleted 4 mwext-ActivityMonitory-* projects in Jenkins admin interface. Deployed mwext-ActivityMonitor-jslint, mwext-ActivityMonitor-lint," [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138498 (owner: 10Krinkle) [23:42:09] (03Merged) 10jenkins-bot: Follows-up I82f531bf2c2217cfe52: Fix typo in "ActivityMonitor" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138498 (owner: 10Krinkle) [23:42:37] (03CR) 10Krinkle: Add new ParserFunction "BLOCKEXPIRY" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133661 (https://bugzilla.wikimedia.org/32819) (owner: 10Withoutaname) [23:44:32] (03CR) 10Krinkle: [C: 04-1] Add new ParserFunction "BLOCKEXPIRY" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/133661 (https://bugzilla.wikimedia.org/32819) (owner: 10Withoutaname) [23:46:25] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (15f4156bac) [core] - 10https://gerrit.wikimedia.org/r/138503 [23:47:18] (03CR) 10SG: [C: 031] "Looks good, tested working?" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138481 (owner: 10EBernhardson) [23:47:21] (03CR) 10Ori.livneh: [C: 032] More optimizations to User::saveOptions() [core] - 10https://gerrit.wikimedia.org/r/137977 (owner: 10Aaron Schulz) [23:49:15] (03CR) 10SG: [C: 04-1] "Looks like this needs to be rebased on top of https://gerrit.wikimedia.org/r/#/c/137957/" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138478 (owner: 10Bsitu) [23:50:18] (03CR) 10CSteipp: [C: 031] "It slightly changes the logic when "unknown" is included in the xff (it breaks instead of continuing), but that shouldn't make a differenc" [core] - 10https://gerrit.wikimedia.org/r/138117 (owner: 10Aaron Schulz) [23:50:47] (03PS1) 10MaxSem: Return geosearch results sorted by distance in generator mode [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/138504 (https://bugzilla.wikimedia.org/66148) [23:51:10] (03Merged) 10jenkins-bot: More optimizations to User::saveOptions() [core] - 10https://gerrit.wikimedia.org/r/137977 (owner: 10Aaron Schulz) [23:52:21] (03CR) 10SG: "Yeah, I have the same question as S. Style and markup-wise, I'm okay with this patch." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137842 (owner: 10Bsitu) [23:52:28] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (15f4156bac) [core] - 10https://gerrit.wikimedia.org/r/138503 (owner: 10Jforrester) [23:56:36] (03CR) 10devunt: Provide user navigation links in User::getNavigationLinks (032 comments) [core] - 10https://gerrit.wikimedia.org/r/137581 (https://bugzilla.wikimedia.org/27707) (owner: 10devunt) [23:57:28] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (15f4156bac) [core] - 10https://gerrit.wikimedia.org/r/138503 (owner: 10Jforrester) [23:57:38] (03PS7) 10Krinkle: initial commit [extensions/ActivityMonitor] - 10https://gerrit.wikimedia.org/r/138042 (owner: 10Harshkothari410) [23:57:55] (03CR) 10Legoktm: "I don't really have an opinion on this specific change, but be aware that when Iaf2b108596be3065a6bc9cea5d9608df6a82c8e2 is merged, this A" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138481 (owner: 10EBernhardson) [23:58:02] (03CR) 10Legoktm: "this API module*" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138481 (owner: 10EBernhardson) [23:58:42] (03CR) 10jenkins-bot: [V: 04-1] initial commit [extensions/ActivityMonitor] - 10https://gerrit.wikimedia.org/r/138042 (owner: 10Harshkothari410) [23:59:10] Krinkle: :(