[00:01:39] Krinkle: I used everything gerrit sucks :( [00:03:13] harshkothari: How do you operate git, via command line? [00:03:28] yeah Krinkle [00:03:49] So you're currently in extensions/ActivityMonitor/ directory [00:03:58] What does `git status` tell you [00:04:05] (03PS3) 10Bsitu: Show topic summary in topic title bar [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137842 [00:04:38] (03CR) 10Bsitu: Show topic summary in topic title bar (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137842 (owner: 10Bsitu) [00:04:46] (03PS3) 10SG: Implement flow-api-handler data attribute [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137957 [00:05:02] (03CR) 10jenkins-bot: [V: 04-1] Implement flow-api-handler data attribute [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137957 (owner: 10SG) [00:05:59] (03PS1) 10SG: Register all handlebars templates as partials as well [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/138115 [00:06:17] (03CR) 10SG: "Depends on https://gerrit.wikimedia.org/r/#/c/138115/" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137957 (owner: 10SG) [00:08:17] Krinkle: http://pastebin.com/0qN9xQ8k [00:09:04] harshkothari: git rebase --abort [00:09:21] done [00:09:26] harshkothari: Do you have git-review installed? [00:09:32] yeah [00:09:55] harshkothari: git branch rm initial-commit [00:10:17] harshkothari: git reset --hard 910e41e2507b # this is the commit id of the commit you made on top, that's our starting point [00:10:20] Krinkle: fatal: Not a valid object name: 'initial-commit'. [00:10:31] harshkothari: git branch -m initial-commit [00:10:33] sry [00:11:00] done [00:13:02] harshkothari: git rebase -i --root [00:13:13] change last commit to 'fixup' (squash) [00:13:16] that will merge them together [00:13:18] (03PS4) 10SG: Implement flow-api-handler data attribute [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137957 [00:13:30] 3 commits are there Krinkle [00:13:34] (03CR) 10jenkins-bot: [V: 04-1] Implement flow-api-handler data attribute [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137957 (owner: 10SG) [00:14:19] harshkothari: Yes, there are three commits in the history you accidentally created (repo creation, your initial commit, second commit on top of initial commit) [00:14:33] okies [00:14:44] rebase -i is an easy way of fixing that history [00:14:55] if you do nothing, it will end up the same. 'pick' is just to apply it [00:15:09] Krinkle: http://pastebin.com/gWBFsWip correct ? [00:15:25] in your case the last one (910e41e) you want to squash, and squash without keeping the duplicate commit message, this is called 'fixup' [00:15:30] Yes [00:15:50] done [00:15:57] now git review -R ? [00:16:48] Yep [00:17:20] still two commits Krinkle [00:17:52] harshkothari: okay, try one more time [00:17:52] so yes ? [00:17:52] git reset --hard 910e41e2507b [00:17:57] no, abort [00:18:17] git rebase -i c5500ca # "create repo" [00:18:25] then make second one fixup [00:18:32] you want the original commit of repo creation to not be rebased [00:18:35] only the two on top [00:18:52] yep now only two [00:19:16] (03PS2) 10Harshkothari410: initial commit for Extension:ActivityMonitor [extensions/ActivityMonitor] - 10https://gerrit.wikimedia.org/r/138042 [00:19:40] big relief Thanks Krinkle :) [00:20:59] harshkothari: abandone the bad one [00:21:02] (in gerrit) [00:21:07] Krinkle: so rebase -i is very useful [00:21:11] Yep [00:21:20] very visual, no difficult commands [00:21:34] There is a manual way as well (rewind, cherry-pick, etc.) [00:22:41] okies I never faced this type of problem with github or bitbucket Krinkle [00:23:02] (03Abandoned) 10Harshkothari410: Initial Commit for Extension:ActivityMonitor [extensions/ActivityMonitor] - 10https://gerrit.wikimedia.org/r/138105 (owner: 10Harshkothari410) [00:23:31] harshkothari: I'm not sure what you mean. What happened is purely git-related locally. [00:23:46] You made a second change and did 'git commit' instead of 'git commit --amend' [00:23:53] that will always create a second commit [00:23:56] instead of changing the first one [00:24:03] (e.g. in a pull request on github you'd have the same) [00:24:22] (03CR) 10PiRSquared17: "Anything else?" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/129932 (https://bugzilla.wikimedia.org/5984) (owner: 10Gerrit Patch Uploader) [00:24:42] Krinkle: but I never faced this kind of problem before and yeah now I got it now perfectly [00:24:58] (03PS1) 10Aaron Schulz: Cleanups to WebRequest::getIP logic [core] - 10https://gerrit.wikimedia.org/r/138117 [00:25:15] harshkothari: you're right now, gerrit is stricter. [00:25:34] on github if you have a pull request branch and you accidentally make a second commit, it will show both changes on the pull-request. [00:25:53] yeah [00:25:54] but before that is merged, they should still be squashed. Usually the person on the other end reviewing your chagne does that for you. [00:26:03] here we prefer you do it so that we don't have to :) [00:26:49] okies Krinkle so now I abandoned bad one and now new patch set for older one :) [00:29:42] (03CR) 10Spage: [C: 032] ""we are missing a lot of mw.messages on the front-end", this should fix, so +2ing." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/136635 (owner: 10Spage) [00:29:58] (03Merged) 10jenkins-bot: Use proper MW messages in front-end. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/136635 (owner: 10Spage) [00:31:26] (03CR) 10Krinkle: Cleanups to WebRequest::getIP logic (031 comment) [core] - 10https://gerrit.wikimedia.org/r/138117 (owner: 10Aaron Schulz) [00:32:59] (03CR) 10Krinkle: "LGTM. Would it be feasible to cover by test (if not already)?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/138117 (owner: 10Aaron Schulz) [00:33:23] (03CR) 10Spage: [C: 032] "recheck" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138035 (owner: 10Bsitu) [00:33:40] (03Merged) 10jenkins-bot: Add board link to permlink and history page [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138035 (owner: 10Bsitu) [00:35:30] (03CR) 10Spage: "recheck" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/134955 (owner: 10Bsitu) [00:45:05] (03CR) 10Spage: [C: 032] "With this patch Flow opens the edit form, but when I click [Close topic] I get "No such action".The url contains ?action=close-open-topic." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137828 (owner: 10Bsitu) [00:45:20] (03Merged) 10jenkins-bot: Click on 'close' & 'summarize' in action menu should open edit form [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137828 (owner: 10Bsitu) [00:49:00] (03CR) 10MaxSem: [C: 032] "recheck" [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/107562 (owner: 10Mwalker) [00:51:38] (03Merged) 10jenkins-bot: Add Image Metadata to Image Database [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/107562 (owner: 10Mwalker) [00:52:09] (03CR) 10MaxSem: [C: 032] "recheck" [core] - 10https://gerrit.wikimedia.org/r/138038 (https://bugzilla.wikimedia.org/66282) (owner: 10Kaldari) [00:55:48] (03Merged) 10jenkins-bot: Make sure images that don't have an explicit alignment get aligned right [core] - 10https://gerrit.wikimedia.org/r/138038 (https://bugzilla.wikimedia.org/66282) (owner: 10Kaldari) [00:57:20] (03CR) 10MaxSem: [C: 032] "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/87022 (owner: 10Dereckson) [00:57:28] (03Merged) 10jenkins-bot: SQLite compatibility for Echo database patches [extensions/Echo] - 10https://gerrit.wikimedia.org/r/87022 (owner: 10Dereckson) [00:57:39] (03CR) 10Daniel Friesen: "There was one extension file using it:" [core] - 10https://gerrit.wikimedia.org/r/136548 (owner: 10Bartosz Dziewoński) [00:58:25] (03CR) 10Jforrester: "I'd suggest just killing it; we found no uses when moving items from /resources to /resources/lib and /resources/src in Id5ead145, but we " [core] - 10https://gerrit.wikimedia.org/r/138108 (https://bugzilla.wikimedia.org/66292) (owner: 10Mattflaschen) [00:58:53] serious commit summaries are serious: recheck [00:59:03] err, https://gerrit.wikimedia.org/r/#/q/status:open+project:xowa,n,z [01:01:06] (03PS1) 10Yurik: Avoid throwing errors in initialization, warn and play it safe [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/138123 [01:04:29] (03CR) 10Yurik: [C: 032] "due to misconfig in labs, crashing zerowiki. self +2ing" [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/138123 (owner: 10Yurik) [01:04:35] (03Merged) 10jenkins-bot: Avoid throwing errors in initialization, warn and play it safe [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/138123 (owner: 10Yurik) [01:14:16] 3Analytics / 3Wikistats: "Edit activity levels of registered users" table is empty - 10https://bugzilla.wikimedia.org/66297 (10Tilman Bayer) 3NEW p:3Unprio s:3normal a:3None Currently, all entries in the table at https://stats.wikimedia.org/EN/TablesWikipediaZZ.htm#editor_activity_levels are blank. [01:27:05] (03CR) 10Spage: [C: 031] "Shouldn't FlowActions.php decide whether or not a workflow can be summarized and closed, instead of testing topic type in RevisionFormatte" (032 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137842 (owner: 10Bsitu) [01:30:09] Is anyone here familiar with language converters in MW? [01:30:58] 3Wikimedia / 3SSL related: support SPDY protocol - 10https://bugzilla.wikimedia.org/33890 (10Jan Zerebecki) [01:31:22] any problems in https://gerrit.wikimedia.org/r/#/c/116691/ ? [01:31:42] (03PS1) 10Jack Phoenix: CSS fix for the "Powered by MediaWiki" line in the page footer. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/138125 [01:32:46] (03CR) 10Jack Phoenix: [C: 032 V: 032] CSS fix for the "Powered by MediaWiki" line in the page footer. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/138125 (owner: 10Jack Phoenix) [01:33:46] (03CR) 10PiRSquared17: Add hak-latn/hans/hant variants (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116691 (https://bugzilla.wikimedia.org/55876) (owner: 10Gerrit Patch Uploader) [01:45:45] (03PS2) 10Jforrester: Update VisualEditor to I903d2892 and I82f624fa [core] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/137984 [01:52:16] 3MediaWiki extensions / 3BetaFeatures: hover catds: increase delay to 500 ms - 10https://bugzilla.wikimedia.org/66301 (10kipod) 3NEW p:3Unprio s:3normal a:3None currently delay is 150ms. this is way too quick, and is inconsistent with common UI practice. without hovercards, tooltips appear after 300... [01:52:43] 3MediaWiki extensions / 3VectorBeta: CPB: Help and privacy policy links to not point to the right pages on some language wikis - 10https://bugzilla.wikimedia.org/65427#c2 (10darklama) This problem exists at English Wikibooks too for the help link. [01:53:28] 3MediaWiki extensions / 3Popups: Hovercards: increase delay to 500 ms - 10https://bugzilla.wikimedia.org/66301 (10Kunal Mehta (Legoktm)) [01:53:53] legoktm: Bah, edit conflict. [01:53:56] :P [02:19:05] (03PS1) 10Cscott: Update dependencies. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138135 [02:20:31] (03PS1) 10Cscott: Update mw-ocg-latexer dependencies. [extensions/Collection/OfflineContentGenerator/node_modules] - 10https://gerrit.wikimedia.org/r/138136 [02:20:55] legoktm: any suggestions for https://gerrit.wikimedia.org/r/#/c/129933/ ? [02:21:30] (03CR) 10jenkins-bot: [V: 04-1] Update dependencies. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138135 (owner: 10Cscott) [02:29:31] 3Wikimedia / 3Deployment systems: [scap] Make the hostname of a filing host more prominent in the error messages - 10https://bugzilla.wikimedia.org/66302 (10Bryan Davis) 3NEW p:3Unprio s:3normal a:3None The scap steps which run tasks on cluster hosts via ssh show a progress meter and display stack tr... [02:30:29] 3Wikimedia / 3Deployment systems: [scap] Make the hostname of a failing host more prominent in the error messages - 10https://bugzilla.wikimedia.org/66302 (10Bryan Davis) p:5Unprio>3Normal s:5normal>3enhanc [02:53:24] (03CR) 10Liangent: "I had an idea to migrate ZhConversion.php to some json format, like what's done for Messages*.php files." [core] - 10https://gerrit.wikimedia.org/r/116691 (https://bugzilla.wikimedia.org/55876) (owner: 10Gerrit Patch Uploader) [02:58:00] 3Wikimedia / 3Deployment systems: [scap] Make the hostname of a failing host more prominent in the error messages - 10https://bugzilla.wikimedia.org/66302 (10Mukunda Modell) a:3Mukunda Modell [03:03:11] (03CR) 10Liangent: [C: 04-1] "qqq.json includes unrelated changes." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116691 (https://bugzilla.wikimedia.org/55876) (owner: 10Gerrit Patch Uploader) [03:03:56] liangent: didn't even notice that... weird [03:04:13] must be some git artifact from another commit (I barely know how to use git) [03:11:42] (03PS2) 10Cscott: Update dependencies. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138135 [03:11:44] (03PS1) 10Cscott: Fix "Use Nazli for Persian" patch. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138139 [03:13:48] (03CR) 10jenkins-bot: [V: 04-1] Update dependencies. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138135 (owner: 10Cscott) [03:14:18] (03CR) 10jenkins-bot: [V: 04-1] Fix "Use Nazli for Persian" patch. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138139 (owner: 10Cscott) [03:21:47] (03PS2) 10Cscott: Fix "Use Nazli for Persian" patch. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138139 [03:21:49] (03PS3) 10Cscott: Update dependencies. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138135 [03:21:51] (03PS1) 10Cscott: Tweak jshint configuration; use strict. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138141 [03:28:10] (03CR) 10Cscott: [C: 032] Tweak jshint configuration; use strict. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138141 (owner: 10Cscott) [03:28:46] (03CR) 10Cscott: [C: 032] Fix "Use Nazli for Persian" patch. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138139 (owner: 10Cscott) [03:30:06] (03Merged) 10jenkins-bot: Tweak jshint configuration; use strict. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138141 (owner: 10Cscott) [03:31:13] (03Merged) 10jenkins-bot: Fix "Use Nazli for Persian" patch. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138139 (owner: 10Cscott) [03:32:16] (03CR) 10Jackmcbarn: Keep the sanitizer from breaking transparent tags (031 comment) [core] - 10https://gerrit.wikimedia.org/r/137821 (owner: 10Jackmcbarn) [03:33:18] (03CR) 10Spage: [C: 04-1] "I tried this out cherry-picked onto tip of frontend-rewrite." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137539 (owner: 10Werdna) [03:39:59] (03PS17) 1001tonythomas: Shifted from PEAR/PHP mailer to Swift Mailer [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) [03:46:56] (03CR) 10Catrope: [C: 032] Use new MWInlineExtensionNode and DM node construction [extensions/Math] - 10https://gerrit.wikimedia.org/r/134366 (owner: 10Esanders) [03:47:55] (03Merged) 10jenkins-bot: Use new MWInlineExtensionNode and DM node construction [extensions/Math] - 10https://gerrit.wikimedia.org/r/134366 (owner: 10Esanders) [03:51:10] (03CR) 10jenkins-bot: [V: 04-1] Shifted from PEAR/PHP mailer to Swift Mailer [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [04:26:44] (03CR) 10devunt: "Providing short information of new features and new configuration values to release notes is also needed." [core] - 10https://gerrit.wikimedia.org/r/137077 (owner: 10CSteipp) [04:35:22] (03PS1) 10Cscott: Use `jpegtran` to purge EXIF data from jpegs. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138149 [04:37:20] (03CR) 10jenkins-bot: [V: 04-1] Use `jpegtran` to purge EXIF data from jpegs. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138149 (owner: 10Cscott) [05:14:21] (03PS1) 10GWicke: Bug 66287: Proper caption styling [core] - 10https://gerrit.wikimedia.org/r/138150 [05:18:09] (03CR) 10Jforrester: Bug 66287: Proper caption styling (031 comment) [core] - 10https://gerrit.wikimedia.org/r/138150 (owner: 10GWicke) [05:18:32] (03CR) 10devunt: "I think renaming class/file name is much better for the future usage. class/file name should represent what that exactly doing." [core] - 10https://gerrit.wikimedia.org/r/137967 (owner: 10Jackmcbarn) [05:22:08] (03PS3) 10Cscott: Switch from `when` to `bluebird` for Promise implementation. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/111732 [05:22:19] (03CR) 10jenkins-bot: [V: 04-1] Switch from `when` to `bluebird` for Promise implementation. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/111732 (owner: 10Cscott) [05:22:50] (03CR) 10GWicke: Bug 66287: Proper caption styling (031 comment) [core] - 10https://gerrit.wikimedia.org/r/138150 (owner: 10GWicke) [05:26:35] (03CR) 10Jforrester: [C: 032] Bug 66287: Proper caption styling [core] - 10https://gerrit.wikimedia.org/r/138150 (owner: 10GWicke) [05:29:40] (03Merged) 10jenkins-bot: Bug 66287: Proper caption styling [core] - 10https://gerrit.wikimedia.org/r/138150 (owner: 10GWicke) [05:32:59] (03PS1) 10GWicke: Minor clarification & tweak for Parsoid render testing [core] - 10https://gerrit.wikimedia.org/r/138152 [05:33:47] (03CR) 10devunt: [C: 031] "It works to me." [core] - 10https://gerrit.wikimedia.org/r/138013 (owner: 10Jackmcbarn) [05:48:37] (03PS1) 10Umherirrender: Remove galanguage from list=gadgets [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/138153 [05:50:45] 3MediaWiki extensions / 3GlobalBlocking: Lego work using in log entries - 10https://bugzilla.wikimedia.org/66308 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Like bug 65417, bug 44798 and bug 64302. [05:50:54] (03PS1) 10Cscott: Switch from `bluebird` to `es6-shim`/`prfun` for Promise implementation. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/138154 [05:51:05] (03CR) 10jenkins-bot: [V: 04-1] Switch from `bluebird` to `es6-shim`/`prfun` for Promise implementation. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/138154 (owner: 10Cscott) [06:03:10] (03CR) 10devunt: [C: 04-1] "When click "Show" on /w/index.php?title=Special:Watchlist will goes /w/index.php?namespace=(number) due to all http params in form action " [core] - 10https://gerrit.wikimedia.org/r/137702 (owner: 10Rohan013) [06:10:49] (03PS1) 10Cscott: Switch from `when` to `bluebird` for Promise implementation. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138156 [06:12:25] (03CR) 10jenkins-bot: [V: 04-1] Switch from `when` to `bluebird` for Promise implementation. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138156 (owner: 10Cscott) [06:19:39] (03PS2) 10devunt: Adds namespace parameter to the url in Special:Watchlist pages [core] - 10https://gerrit.wikimedia.org/r/137702 (https://bugzilla.wikimedia.org/65592) (owner: 10Rohan013) [06:20:34] (03PS1) 10Cscott: Switch from `bluebird` to `es6-shim`/`prfun` for Promise implementation. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138157 [06:21:14] (03CR) 10devunt: "PS2: Fix problem and update commit message to align with commit message guidelines." [core] - 10https://gerrit.wikimedia.org/r/137702 (https://bugzilla.wikimedia.org/65592) (owner: 10Rohan013) [06:22:36] (03CR) 10jenkins-bot: [V: 04-1] Switch from `bluebird` to `es6-shim`/`prfun` for Promise implementation. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138157 (owner: 10Cscott) [06:30:24] (03PS2) 10devunt: Replace autofocus="1" /> to autofocus /> on input element in Special:BookSources [core] - 10https://gerrit.wikimedia.org/r/137670 (https://bugzilla.wikimedia.org/66134) (owner: 10Rohan013) [06:32:28] 3MediaWiki extensions / 3Translate: Simplistic alignment based on h2 headers - 10https://bugzilla.wikimedia.org/66162#c3 (10Nemo) BPositive> what do you mean by "adding blanks before if needed"? :) Adding an empty textarea/"unit". [06:33:38] (03CR) 10MaxSem: [C: 032] Remove galanguage from list=gadgets [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/138153 (owner: 10Umherirrender) [06:33:42] (03Merged) 10jenkins-bot: Remove galanguage from list=gadgets [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/138153 (owner: 10Umherirrender) [06:37:54] (03CR) 10devunt: [C: 04-1] "It works, but I think it should be done in Xml::inputLabel." [core] - 10https://gerrit.wikimedia.org/r/137670 (https://bugzilla.wikimedia.org/66134) (owner: 10Rohan013) [06:43:48] (03CR) 10devunt: [C: 031] Allow namespace inversion on Whatlinkshere [core] - 10https://gerrit.wikimedia.org/r/129933 (https://bugzilla.wikimedia.org/16848) (owner: 10Gerrit Patch Uploader) [06:50:26] (03CR) 10devunt: [C: 031] "I think this change needs more community consensus. Anyway, looks good to me. and we need this feature." [core] - 10https://gerrit.wikimedia.org/r/136234 (owner: 10Jackmcbarn) [07:00:57] (03CR) 10Jforrester: [C: 032] Minor clarification & tweak for Parsoid render testing [core] - 10https://gerrit.wikimedia.org/r/138152 (owner: 10GWicke) [07:01:32] (03CR) 10devunt: [C: 031] Change some message escaping [core] - 10https://gerrit.wikimedia.org/r/136161 (owner: 10Umherirrender) [07:04:01] (03Merged) 10jenkins-bot: Minor clarification & tweak for Parsoid render testing [core] - 10https://gerrit.wikimedia.org/r/138152 (owner: 10GWicke) [07:09:17] 3MediaWiki extensions / 3AbuseFilter: Add "is new page" and "page was deleted before / has delete log entry" functions to Abuse filter - 10https://bugzilla.wikimedia.org/66310 (10Danny B.) 3NEW p:3Unprio s:3enhanc a:3None Abuse filter should have the "is new page" and "page was deleted before / has d... [07:09:59] 3MediaWiki extensions / 3AbuseFilter: Add "is new page" and "page was deleted before / has delete log entry" functions to Abuse filter - 10https://bugzilla.wikimedia.org/66310 (10Danny B.) p:5Unprio>3Normal [07:20:44] 3MediaWiki / 3Skin and page rendering: Come up with a sane way of including screenshots with skins and displaying them in the UI - 10https://bugzilla.wikimedia.org/66295#c1 (10Isarra) What's wrong with ?useskin? Except in the installer. That would need something fancier, or something. Unless there'd be som... [07:21:48] (03CR) 10Umherirrender: "Xml::inputLabel does not support boolean parameters." [core] - 10https://gerrit.wikimedia.org/r/137670 (https://bugzilla.wikimedia.org/66134) (owner: 10Rohan013) [07:38:13] 3MediaWiki extensions / 3WikidataClient: Ability to have [[Special:UnconnectedPages]] filter by namespace - 10https://bugzilla.wikimedia.org/66153 (10Lydia Pintscher) p:5Unprio>3Normal s:5enhanc>3normal [07:38:34] 3MediaWiki extensions / 3WikidataClient: Ability to have [[Special:UnconnectedPages]] filter by namespace - 10https://bugzilla.wikimedia.org/66153 (10Lydia Pintscher) p:5Normal>3Low [07:39:14] 3MediaWiki extensions / 3WikidataRepo: Create browsertests for Search gadget on beta - 10https://bugzilla.wikimedia.org/66252 (10Lydia Pintscher) p:5High>3Normal [07:39:44] 3MediaWiki extensions / 3WikidataRepo: Create browsertests for AuthorityControl gadget on beta - 10https://bugzilla.wikimedia.org/66251 (10Lydia Pintscher) s:5normal>3major [07:41:15] 3MediaWiki extensions / 3WikidataRepo: jquery styles overriding entity suggester styles - 10https://bugzilla.wikimedia.org/66268 (10Lydia Pintscher) p:5Unprio>3High [07:41:28] 3MediaWiki extensions / 3WikidataRepo: jquery styles overriding entity suggester styles - 10https://bugzilla.wikimedia.org/66268 (10Lydia Pintscher) s:5critic>3major [07:57:28] (03PS2) 10Krinkle: Installer: Re-use ResourceLoader methods instead of duplicating [core] - 10https://gerrit.wikimedia.org/r/137403 [08:03:44] (03PS3) 10Krinkle: Installer: Re-use ResourceLoader methods instead of duplicating [core] - 10https://gerrit.wikimedia.org/r/137403 [08:03:56] (03CR) 10Krinkle: Installer: Re-use ResourceLoader methods instead of duplicating (033 comments) [core] - 10https://gerrit.wikimedia.org/r/137403 (owner: 10Krinkle) [08:06:11] (03CR) 10Krinkle: "Omit "ResourceLoader" from the title. It is registered/provided as a module, maybe ResourceLoader module. But in no way is it provided via" [core] - 10https://gerrit.wikimedia.org/r/137855 (owner: 10Legoktm) [08:06:52] Krinkle|detached: you mean from the commit message? [08:09:13] (03CR) 10Krinkle: "I don't think wgRCStreamHost or mediawiki.rcstream belong in mediawiki core (certainly not in the same commit, please add the socket.io li" [core] - 10https://gerrit.wikimedia.org/r/137855 (owner: 10Legoktm) [08:10:43] 3MediaWiki extensions / 3WikidataRepo: review backend part of entity suggester (python code) - 10https://bugzilla.wikimedia.org/63368#c4 (10Christian Dullweber) Thanks for the review. ujson is optional and only gives a small speedup. the other requirements are only for testing. The code could run on labs. T... [08:13:11] (03CR) 10Krinkle: [C: 04-1] Provide socket.io-client via ResourceLoader (032 comments) [core] - 10https://gerrit.wikimedia.org/r/137855 (owner: 10Legoktm) [08:13:40] (03PS7) 10Krinkle: jquery.suggestions: Support caching results to save http requests [core] - 10https://gerrit.wikimedia.org/r/134603 (https://bugzilla.wikimedia.org/65581) [08:13:48] (03PS11) 10Krinkle: mediawiki.searchSuggest: Enable result caching [core] - 10https://gerrit.wikimedia.org/r/134542 (https://bugzilla.wikimedia.org/65581) [08:19:11] (03CR) 10Krinkle: "Yeah, agreed. Not only is this unused, it can't be used in a way we're willing to support because the only way it can be used right now is" [core] - 10https://gerrit.wikimedia.org/r/138108 (https://bugzilla.wikimedia.org/66292) (owner: 10Mattflaschen) [08:22:39] (03PS3) 10Krinkle: Remove unused jquery.cycle.all.js file [core] - 10https://gerrit.wikimedia.org/r/138108 (https://bugzilla.wikimedia.org/66292) (owner: 10Mattflaschen) [08:22:51] (03CR) 10Krinkle: [C: 031] Remove unused jquery.cycle.all.js file [core] - 10https://gerrit.wikimedia.org/r/138108 (https://bugzilla.wikimedia.org/66292) (owner: 10Mattflaschen) [08:23:43] 3MediaWiki / 3JavaScript: jquery.cycle.all.js uses jQuery.browser - 10https://bugzilla.wikimedia.org/66292 (10Krinkle) [08:25:46] (03CR) 10Krinkle: [C: 04-1] "Code looks good but awaiting use case justification (see bug)." [core] - 10https://gerrit.wikimedia.org/r/137853 (https://bugzilla.wikimedia.org/20394) (owner: 10Legoktm) [08:26:28] 3MediaWiki / 3Recent changes: RCFeed: Expose log_id in RC feed - 10https://bugzilla.wikimedia.org/20394#c4 (10Krinkle) (In reply to Ori Livneh from comment #3) > What is the value of having it there? Hm.. good point. How can the log_id be utilised by a consumer? It is not part of a permalink. [08:26:32] Nemo_bis: I couldn't find a simple example of an extension using contenthandler, so I wrote one myself. [08:26:40] what would you recommend instead, to make it find-able? [08:26:52] I'm not sure we should create an extension page for a sample extension [08:27:30] wctaiwan: how about the [[ContentHandler]] page? And a category for it if missing [08:27:53] okay, that works for me. [08:29:54] Good. Usually ns0 pages are more visited, your note on a category may not have the reach you expected [08:30:01] https://www.mediawiki.org/w/index.php?title=Manual%3AContentHandler&diff=1026231&oldid=910315 [08:36:25] (03PS2) 10Krinkle: Update Scribunto Lua files [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/137342 (owner: 10Paladox) [08:36:33] (03CR) 10jenkins-bot: [V: 04-1] Update Scribunto Lua files [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/137342 (owner: 10Paladox) [08:37:17] 3MediaWiki / 3Recent changes: RCFeed: Expose log_id in RC feed - 10https://bugzilla.wikimedia.org/20394#c5 (10Kunal Mehta (Legoktm)) If you want to do a database query for whatever reason, you'd probably want the log_id. Or if you want to revdel via the API (RC adminbot watching for bad usernames), the log_i... [08:37:44] (03CR) 10Krinkle: [C: 031] "Restores non-animated transition of it just moving down (bit odd too, but that's how it was, let's go from there). However does not fix ou" [core] - 10https://gerrit.wikimedia.org/r/137715 (owner: 10Bartosz Dziewoński) [08:40:50] (03CR) 10Krinkle: "You fixed a test but failed to add a new one (one where the key escaping actually happens)." [core] - 10https://gerrit.wikimedia.org/r/137458 (https://bugzilla.wikimedia.org/66199) (owner: 10EBernhardson) [08:41:29] (03CR) 10Krinkle: [C: 031] Correct output of wfMessage( 'non-existent-msg' )->text() [core] - 10https://gerrit.wikimedia.org/r/137458 (https://bugzilla.wikimedia.org/66199) (owner: 10EBernhardson) [08:42:29] 3MediaWiki / 3HTMLForm: Invalid message lookup keys are rendered as double encoded HTML - 10https://bugzilla.wikimedia.org/62047#c2 (10Krinkle) 5UNCO>3RESO/DUP *** This bug has been marked as a duplicate of bug 66199 *** [08:42:30] 3MediaWiki / 3Internationalization: The output of wfMessage( 'i-dont-exist' )->text() should not have its entities html encoded - 10https://bugzilla.wikimedia.org/66199#c2 (10Krinkle) *** Bug 62047 has been marked as a duplicate of this bug. *** [08:53:47] 3MediaWiki / 3Database: MW1.23.0, Uncommitted DB writes - 10https://bugzilla.wikimedia.org/66311 (10Steven Zhong) 3UNCO p:3Unprio s:3normal a:3None xampp-win32-1.8.3-3-VC11: Apache/2.4.7 (Win32) OpenSSL/1.0.1e PHP/5.5.9 5.6.16 - MySQL Community Server (GPL) MW 1.23.0, new and clean install: Notice:... [09:17:34] (03PS1) 10Hiong3-eng5: API AddSyntrans [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/138163 [09:20:51] (03CR) 10Frédéric Wang: Separate render and getHtml (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/138023 (owner: 10Physikerwelt) [10:30:15] (03PS3) 10Physikerwelt: Separate render and getHtml [extensions/Math] - 10https://gerrit.wikimedia.org/r/138023 [10:53:22] (03CR) 10Phe: [C: 04-1] "All of this must be done in javascript on a per-wiki basis." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/135546 (owner: 10Krinkle) [11:02:36] (03CR) 10Physikerwelt: [C: 04-1] "There is still a database write access if a cache hit was found..." [extensions/Math] - 10https://gerrit.wikimedia.org/r/138023 (owner: 10Physikerwelt) [11:04:14] 3MediaWiki extensions / 3Translate: Simplistic alignment based on h2 headers - 10https://bugzilla.wikimedia.org/66162#c4 (10Pratik Lahoti) Alright I am thinking on the approach mentioned by you. But it would be great if https://gerrit.wikimedia.org/r/#/c/136334/ gets merged. That would give me an array of tr... [11:05:00] (03CR) 10Phe: "I forget a case for linefeed removal, it'll break all poestry." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/135546 (owner: 10Krinkle) [11:35:31] 3MediaWiki / 3Skin and page rendering: TOC looks crammed in Firefox on Android - 10https://bugzilla.wikimedia.org/66314 (10Daniel Jonsson) 3UNCO p:3Unprio s:3enhanc a:3None The table of contents list renders poorly in Firefox on Android. Here is a screenshot of the article The Wolf of Wall Street (2... [11:36:44] 3MediaWiki / 3Skin and page rendering: TOC looks crammed in Firefox on Android - 10https://bugzilla.wikimedia.org/66314 (10Daniel Jonsson) [11:42:07] (03PS4) 10Physikerwelt: Separate render and getHtml [extensions/Math] - 10https://gerrit.wikimedia.org/r/138023 [11:42:58] (03CR) 10jenkins-bot: [V: 04-1] Separate render and getHtml [extensions/Math] - 10https://gerrit.wikimedia.org/r/138023 (owner: 10Physikerwelt) [11:51:05] (03PS5) 10Physikerwelt: Separate render and getHtml [extensions/Math] - 10https://gerrit.wikimedia.org/r/138023 [11:51:33] (03CR) 10Physikerwelt: Separate render and getHtml (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/138023 (owner: 10Physikerwelt) [11:53:14] thedj: Online? [11:53:46] (03CR) 10Physikerwelt: "now it looks good to me. It would be great if someone else could test the caching for the png mode (I tested based on log files)." [extensions/Math] - 10https://gerrit.wikimedia.org/r/138023 (owner: 10Physikerwelt) [12:02:59] 3MediaWiki / 3Database: Fix "Uncommitted DB writes (transaction from DatabaseBase::query)" - 10https://bugzilla.wikimedia.org/56269#c58 (10Andre Klapper) *** Bug 66311 has been marked as a duplicate of this bug. *** [12:03:00] 3MediaWiki / 3Database: MW1.23.0, Uncommitted DB writes - 10https://bugzilla.wikimedia.org/66311#c1 (10Andre Klapper) 5UNCO>3RESO/DUP Hi Steven. Thanks for taking the time to report this! This particular problem has already been reported into our bug tracking system, but please feel free to report any fu... [12:08:14] 3MediaWiki extensions / 3WikidataRepo: EntitySelector not working on MainPage (e.g. for search box) - 10https://bugzilla.wikimedia.org/66257#c1 (10WikidataBugzilla) Commit pushed to suggester at https://github.com/wmde/ValueView https://github.com/wmde/ValueView/commit/48161b1df4d8dadff023b1abba27d0c464b903... [12:09:01] 3MediaWiki extensions / 3Popups: Hovercards: Yet another flicker-issue when moving the mouse pointer between hovercard and link - 10https://bugzilla.wikimedia.org/66315 (10Eduard Braun) 3UNCO p:3Unprio s:3normal a:3None When one moves the mouse pointer over the hovercard and then back over the link (... [12:12:56] (03PS1) 10Paladox: Update jQuery files [core] - 10https://gerrit.wikimedia.org/r/138165 [12:14:18] (03CR) 10Paladox: [C: 031] "This patch updates jQuery files that have not been updated in ages." [core] - 10https://gerrit.wikimedia.org/r/138165 (owner: 10Paladox) [12:23:16] (03PS2) 10Paladox: Update jQuery files [core] - 10https://gerrit.wikimedia.org/r/138165 [12:25:34] (03CR) 10Paladox: [C: 031] Update jQuery files [core] - 10https://gerrit.wikimedia.org/r/138165 (owner: 10Paladox) [12:28:12] (03PS3) 10Paladox: Update jQuery files [core] - 10https://gerrit.wikimedia.org/r/138165 [12:39:31] 3MediaWiki extensions / 3Popups: Hovercards should always appear adjacent to the linked area (instead of relative to the mouse cursor) to prevent "dead" space between link and hovercard - 10https://bugzilla.wikimedia.org/66317 (10Eduard Braun) 3UNCO p:3Unprio s:3major a:3None Created attachment 15590... [12:44:49] (03PS4) 10Pastakhov: add objects support (version 2.0.0 hook release 3) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/135995 [12:58:20] (03PS1) 10Umherirrender: Fix warning "Invalid argument supplied for foreach()" [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/138167 (https://bugzilla.wikimedia.org/58700) [12:58:45] 3MediaWiki extensions / 3Gadgets: Gadgets:Invalid argument supplied for foreach() in ApiQueryGadgetCategories.php on line 47 - 10https://bugzilla.wikimedia.org/58700 (10Umherirrender) a:3Umherirrender [13:01:59] 3MediaWiki extensions / 3Popups: Hovercards: pokey (border area) is not clickable, but pointer says it is - 10https://bugzilla.wikimedia.org/66262#c1 (10Eduard Braun) Actually those areas are clickable for me on Windows 7 using Firefox 29.0.1. Anyway the mentioned area should at least stay part of the hoverc... [13:04:31] 3Wikimedia / 3Mailing lists: Ban *@utdliving.com from sending any email to the mailman server - 10https://bugzilla.wikimedia.org/66318 (10Maarten Dammers) 3NEW p:3Unprio s:3normal a:3None I'm owner of several mailman lists. These lists -owner addresses keep getting spammed. Today alone I received 12... [13:08:59] 3MediaWiki extensions / 3Popups: Hovercards: images are cropped - 10https://bugzilla.wikimedia.org/65242#c3 (10Eduard Braun) This is also an issue for all graphical illustrations like diagrams, chemical structure formulae, geometric sketches, etc. [13:20:44] 3MediaWiki / 3JavaScript: jquery.cycle.all.js uses jQuery.browser - 10https://bugzilla.wikimedia.org/66292#c3 (10paladox2015) Hi I uploaded an update to that file here https://gerrit.wikimedia.org/r/#/c/138165/ [14:07:08] (03CR) 10Jack Phoenix: [C: 032 V: 032] Use the API to fetch the email and realname if possible [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/88150 (https://bugzilla.wikimedia.org/55639) (owner: 10Legoktm) [14:43:34] Where will I find MWScript.php ? (It's called in the job runner and just trying to find out what all the stuff does.) [14:43:57] operations/mediawiki-config.git [14:44:00] multiversion folder [14:44:06] IT won't just work standalone [14:45:40] I forgot about that repo, thanks :) [14:52:54] Lcawte: remember to leave a line on Manual:Wiki_family (or talk) for each thing you forget :) [15:11:10] (03CR) 10Jackmcbarn: "Community consensus for this? Why?" [core] - 10https://gerrit.wikimedia.org/r/136234 (owner: 10Jackmcbarn) [15:12:37] (03PS8) 10Paladox: Update jQuery UI and Effects [core] - 10https://gerrit.wikimedia.org/r/137979 [15:17:29] 3MediaWiki extensions / 3WikidataRepo: jquery styles overriding entity suggester styles - 10https://bugzilla.wikimedia.org/66268#c1 (10Aude) references in blue http://snag.gy/XdFoS.jpg [15:48:02] 3Wikimedia / 3Media storage: GIMP file format images display green instead of B&W - 10https://bugzilla.wikimedia.org/66323 (10Yann Forget) 3NEW p:3Unprio s:3normal a:3None https://commons.wikimedia.org/wiki/File:Romain_Rolland_de_face_au_balcon,_Meurisse,_1914.xcf https://commons.wikimedia.org/wiki/F... [15:55:58] (03CR) 10Frédéric Wang: [C: 031] "Looks good to me." [extensions/Math] - 10https://gerrit.wikimedia.org/r/138023 (owner: 10Physikerwelt) [15:57:44] 3MediaWiki extensions / 3WikidataRepo: jquery styles overriding entity suggester styles - 10https://bugzilla.wikimedia.org/66268#c2 (10Aude) after extensive investigation, the problem seems to be that jquery.ui.core gets loaded a second time (??) and/or after jquery.ui.suggester. I am able to reproduce the... [15:58:01] (03CR) 10MaxSem: [C: 032] Fix warning "Invalid argument supplied for foreach()" [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/138167 (https://bugzilla.wikimedia.org/58700) (owner: 10Umherirrender) [15:58:07] (03Merged) 10jenkins-bot: Fix warning "Invalid argument supplied for foreach()" [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/138167 (https://bugzilla.wikimedia.org/58700) (owner: 10Umherirrender) [16:00:30] 3MediaWiki / 3API: Disable minor edit for page/section creation by API - 10https://bugzilla.wikimedia.org/40111 (10Laurence 'GreenReaper' Parry) [16:00:30] 3MediaWiki / 3Page editing: Revert bug 27860 or add configuration variable to restore "Mark all edits minor by default" preference behaviour - 10https://bugzilla.wikimedia.org/42008#c7 (10Laurence 'GreenReaper' Parry) I got complaints about this just a day or so after upgrading WikiFur. People expect to be a... [16:07:29] 3Wikimedia / 3Media storage: GIMP file format images display green instead of B&W - 10https://bugzilla.wikimedia.org/66323#c1 (10Yann Forget) This one too: https://commons.wikimedia.org/wiki/File:Annie_Besant,_LoC.xcf [16:08:59] 3MediaWiki extensions / 3CirrusSearch: Boost hits early in the article and in category names - 10https://bugzilla.wikimedia.org/66045#c1 (10Nemo) Permalink to thread: https://www.mediawiki.org/wiki/Thread:Talk:Search/LiquidThreads_archive/%27Old_search%27_is_better Does this bug also cover hits against cate... [16:09:01] (03PS4) 10Nemo bis: Boost results that contain hits in the opening [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/137521 (https://bugzilla.wikimedia.org/61669) (owner: 10Manybubbles) [16:09:08] (03PS3) 10Nemo bis: Search categories [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/137646 (https://bugzilla.wikimedia.org/66045) (owner: 10Manybubbles) [16:10:34] (03PS3) 10Jackmcbarn: Use transparent tags [extensions/Cite] - 10https://gerrit.wikimedia.org/r/137824 [16:10:49] (03CR) 10jenkins-bot: [V: 04-1] Use transparent tags [extensions/Cite] - 10https://gerrit.wikimedia.org/r/137824 (owner: 10Jackmcbarn) [16:11:47] (03PS4) 10Jackmcbarn: Use transparent tags [extensions/Cite] - 10https://gerrit.wikimedia.org/r/137824 [16:11:52] (03CR) 10jenkins-bot: [V: 04-1] Use transparent tags [extensions/Cite] - 10https://gerrit.wikimedia.org/r/137824 (owner: 10Jackmcbarn) [16:14:30] Is the WMF redis config publicly available? Is there even such thing as Redis config (not the MW side of things) or is it magic and store job queue and session data automaticly? [16:14:46] 3MediaWiki extensions / 3CirrusSearch: Consider adding some "keywords" to the meta description tag - 10https://bugzilla.wikimedia.org/66325 (10Nemo) 3NEW p:3Unprio s:3enhanc a:3None According to URL, the meta element's "description" tag is still actively used by search engines a bit. Keeping in mind... [16:14:59] 3MediaWiki extensions / 3CirrusSearch: Consider adding some "keywords" to the meta description tag - 10https://bugzilla.wikimedia.org/66325 (10Nemo) p:5Unprio>3Low [16:16:15] 3MediaWiki / 3General/Unknown: Use a meta description tag for better search-engine indexing - 10https://bugzilla.wikimedia.org/12196#c2 (10Nemo) (In reply to Brion Vibber from comment #1) > Since the auto-generated keywords are generally agreed to be seemingly > random and near-useless, In fact they were re... [16:16:15] 3MediaWiki extensions / 3WikidataRepo: jquery styles overriding entity suggester styles - 10https://bugzilla.wikimedia.org/66268#c3 (10Aude) also note, for reproducing the bug, it may help to set $wgResourceLoaderStorageEnabled = true; (not confirmed, but it is set to false by default) [16:19:28] 3MediaWiki / 3Parser: Remove worse-than-useless keywords feature - 10https://bugzilla.wikimedia.org/19761#c10 (10Nemo) I noticed around 2009 or so that the keywords were less useful for Wikiquote than for Wikipedia. 5 years later I went to check if that was still the case and I discovered this bug. :)... [16:20:29] 3Analytics / 3Wikistats: "Edit activity levels of registered users" table is empty - 10https://bugzilla.wikimedia.org/66297#c1 (10Erik Zachte) 5NEW>3RESO/FIX Fixed. Merge job for editors had not run yet. [16:22:15] 3Wikimedia / 3Media storage: Thumbnail/imagescaler (tracking) - 10https://bugzilla.wikimedia.org/41371 (10Maarten Dammers) [16:28:14] 3Analytics / 3Wikimetrics: Cohort list for report creation screen should not include invalid cohorts - 10https://bugzilla.wikimedia.org/66290#c1 (10Toby Negrin) p:5Unprio>3Normal This doesn't seem service affecting. Let's consider next sprint. [16:37:01] bawolff: re https://gerrit.wikimedia.org/r/#/c/137967/ , i made the change you wanted, and now someone else is asking me to un-make it [16:37:06] can you look again? [16:38:00] code reviewers disagreeing. Always fun for the people submitting the code :) [16:44:15] (03CR) 10Umherirrender: "Why we need this feature, which is also available for all wikis with a simple template? I see no benefit over a template. The Template:! w" [core] - 10https://gerrit.wikimedia.org/r/136234 (owner: 10Jackmcbarn) [16:47:06] (03CR) 10Bartosz Dziewoński: ""Most user will need this only when interact with parserfunctions like #if, #ifeq or friends, which is not part of core." This is actually" [core] - 10https://gerrit.wikimedia.org/r/136234 (owner: 10Jackmcbarn) [16:48:14] 3MediaWiki extensions / 3Gadgets: Gadgets:Invalid argument supplied for foreach() in ApiQueryGadgetCategories.php on line 47 - 10https://bugzilla.wikimedia.org/58700#c3 (10Umherirrender) 5PATC>3RESO/FIX successfully merged [16:48:48] (03CR) 10Jackmcbarn: "A recent change to core means that Template:! won't be cached as aggressively anymore. This isn't just useful with ParserFunctions; it's a" [core] - 10https://gerrit.wikimedia.org/r/136234 (owner: 10Jackmcbarn) [16:54:04] (03CR) 10Danny B.: "methodtable.wikitext should allow nil as well -> that would work like :wikitext("") (= adding nothing)" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/137659 (https://bugzilla.wikimedia.org/62982) (owner: 10Jackmcbarn) [16:55:28] (03CR) 10Jackmcbarn: "That already works." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/137659 (https://bugzilla.wikimedia.org/62982) (owner: 10Jackmcbarn) [16:56:30] MaxSem: I just found https://git.wikimedia.org/summary/wikimedia%2Fwlm-api . I think that can be dropped now we have http://git.wikimedia.org/log/labs%2Ftools%2Fheritage.git ? [16:59:24] (03CR) 10Brian Wolff: [C: 031] "Keeping the class name the same maintains backwards compatibility, if for example an extension extended the class (I don't know if any do " [core] - 10https://gerrit.wikimedia.org/r/137967 (owner: 10Jackmcbarn) [17:06:13] multichill, that was specifically for WMF deployment [17:06:56] but yeah, now that we're sure we're not going to deploy it again... [17:07:14] 3MediaWiki / 3JavaScript: jquery.cycle.all.js uses jQuery.browser - 10https://bugzilla.wikimedia.org/66292#c4 (10Andre Klapper) paladox2015: Also see [[mw:Gerrit/Commit_message_guidelines]] [17:07:36] goin to get some breakfast.... [17:07:38] :) [17:11:09] It's deployed on labs these days MaxSem :P [17:45:29] (03CR) 10PiRSquared17: "The page title is still centralauth-admin-title with $2 replaced by username if a username is supplied. I think the title should still con" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/136628 (https://bugzilla.wikimedia.org/27142) (owner: 10devunt) [17:45:38] (03CR) 10PiRSquared17: "*$1" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/136628 (https://bugzilla.wikimedia.org/27142) (owner: 10devunt) [17:58:44] 3Analytics / 3Wikistats: Segregate and document configuration variables - 10https://bugzilla.wikimedia.org/62566#c11 (10Erik Zachte) Nemo, I finally got all wikistats files in the repo. I think you can add patches now. Sorry for delay. [18:10:59] 3Analytics / 3Wikistats: Segregate and document configuration variables - 10https://bugzilla.wikimedia.org/62566#c12 (10Nemo) (In reply to Erik Zachte from comment #11) > Nemo, I finally got all wikistats files in the repo. I think you can add > patches now. Sorry for delay. Wow, great, I'll try to start re... [18:13:01] 3MediaWiki extensions / 3Scribunto: mw.title should use TitleValue - 10https://bugzilla.wikimedia.org/66328 (10Jackmcbarn) 3NEW p:3Unprio s:3enhanc a:3None Currently, mw.title is implemented using Title. This results in unnecessary expensive calls in multiple situations, such as when validating a tit... [18:22:19] Hi Nemo_bis ! You around > [18:22:20] ? [18:26:14] 3MediaWiki extensions / 3Scribunto: mw.title should avoid unnecessary expensive work - 10https://bugzilla.wikimedia.org/66328#c1 (10Jackmcbarn) Upon looking closer, it seems that this problem isn't caused by Title itself (and thus wouldn't be fixed simply switching to TitleValue), but by the way Scribunto gr... [18:31:49] tonythomas: so and so [18:33:14] Nemo_bis: cool. Now, we the current blocker for our swiftmailer shift, as you would've seen is the Jenkins issue to catch up with composer. We need to have this one merged dearly. https://gerrit.wikimedia.org/r/#/c/136897/ [18:43:52] tonythomas: did you look into https://integration.wikimedia.org/ci/job/mediawiki-core-qunit2/12/consoleFull ? [18:44:22] (03PS4) 10Gerrit Patch Uploader: Add hak-latn/hans/hant variants [core] - 10https://gerrit.wikimedia.org/r/116691 (https://bugzilla.wikimedia.org/55876) [18:44:24] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/116691 (https://bugzilla.wikimedia.org/55876) (owner: 10Gerrit Patch Uploader) [18:46:07] Nemo_bis: err. Going through [18:47:41] Nemo_bis: This one passes alright right ? [18:54:04] (03PS1) 10Raimond Spekking: Support Creative Commons cc-by-(sa-)4.0 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/138183 [18:56:11] tonythomas: that's now what hashar says: he can't deploy that config because it doesn't currently pass; some errors in those repos need to be fixed first [18:56:35] errors in the repos ? [18:58:23] that's what I understood, can't look into it now [18:59:46] (03PS2) 10Raimond Spekking: Support Creative Commons cc-by-(sa-)4.0 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/138183 (https://bugzilla.wikimedia.org/61896) [19:01:46] (03PS1) 10Gerrit Patch Uploader: Add link to protect log to action=info [core] - 10https://gerrit.wikimedia.org/r/138184 (https://bugzilla.wikimedia.org/50190) [19:01:51] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/138184 (https://bugzilla.wikimedia.org/50190) (owner: 10Gerrit Patch Uploader) [19:05:03] (03CR) 10Parent5446: [C: 031] "I personally agree with this change. I think it is only natural that a markup language like wikitext has a method for escaping special cha" [core] - 10https://gerrit.wikimedia.org/r/136234 (owner: 10Jackmcbarn) [19:07:30] Nemo_bis: cool! any idea who I should ping to get this done ? [19:11:29] 3MediaWiki extensions / 3ParserFunctions: {{#insection:true|false}} function that will flag "true" if in a section (for template messages and their different context) - 10https://bugzilla.wikimedia.org/11473#c1 (10Jackmcbarn) This is probably a WONTFIX, since templates can generate section headers, and that... [19:28:30] people say mediawiki's git repo is big. I posit that gimps git repo is also huge [19:40:45] 3MediaWiki extensions / 3MediaWikiAuth: Add support for getting email and real name from API for target wikis using 1.20+ - 10https://bugzilla.wikimedia.org/55639 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX [19:55:32] multichill: so, no, I wasn't [19:59:45] oh hi thedj [20:02:32] hi, you pinged ? [20:03:28] (03CR) 10Scnd: [C: 031] "You misunderstood what this code doing. This part is only imports text from OCR layer to wikipage. So this regexes apply only one time." (031 comment) [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/135546 (owner: 10Krinkle) [20:03:37] i'm on a train, so if i drop out.... don't hold it against me :) [20:03:38] (03CR) 10Hoo man: [C: 04-1] "Untested... some initial feedback" (037 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/133997 (https://bugzilla.wikimedia.org/52674) (owner: 10Gerrit Patch Uploader) [20:07:04] thedj, sorry, yeah. I keep trying to get hold of you. [20:07:40] thedj, OOUI dialog accessibility ( tps://bugzilla.wikimedia.org/show_bug.cgi?id=65473 ) - specifically aria-hidden=true - can you explain exactly how to reproduce the problem you ran into? [20:07:46] that's https://bugzilla.wikimedia.org/show_bug.cgi?id=65473 [20:08:31] thedj: Idle for life! ;-) [20:12:33] Krenair: right, i'll put that on the list for tomorrow [20:13:18] ok, thanks thedj :) [20:18:36] (03PS3) 10Scnd: Improve OCR layer filtering [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/135546 (owner: 10Krinkle) [20:23:50] (03CR) 10Brian Wolff: "Note, I made some changes to DjVu handler a little while back which might make some of these regexes unnessary (For media uploaded after t" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/135546 (owner: 10Krinkle) [20:59:00] 3MediaWiki extensions / 3ParserFunctions: {{#insection:true|false}} function that will flag "true" if in a section (for template messages and their different context) - 10https://bugzilla.wikimedia.org/11473#c2 (10Carl Fürstenberg) (In reply to Jackmcbarn from comment #1) > This is probably a WONTFIX, since... [20:59:43] jackmcbarn: had only to wait 7 years for a reply ツ [21:00:31] have been sitting here since then waiting for you to reply! [21:00:59] (03PS4) 10Scnd: Improve OCR layer filtering [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/135546 (owner: 10Krinkle) [21:03:54] AzaToth: better than never, right? :) [21:08:44] 3MediaWiki / 3Skin and page rendering: Fonts in IE6/7 too big when scaling font size - 10https://bugzilla.wikimedia.org/24515#c18 (10entlinkt) Created attachment 15592 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15592&action=edit Change font-size from 1em to 100% Please see the attached, updated... [21:16:34] heh [21:24:34] IE6/7? Really? :( [21:30:59] 3MediaWiki / 3Parser: MediaWiki:Cascadeprotected and MediaWiki:Cascadedprotectedwarning should take the same parameters - 10https://bugzilla.wikimedia.org/16111#c5 (10Jackmcbarn) 1. Although the messages appear similar in the default installations, many wikis have heavily customized each of them in different... [21:35:53] (03CR) 10PiRSquared17: Show lock notice on contribs for locked users (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/133997 (https://bugzilla.wikimedia.org/52674) (owner: 10Gerrit Patch Uploader) [21:39:46] (03PS1) 10Brian Wolff: Workaround image magick issue with greyscale xcf files [core] - 10https://gerrit.wikimedia.org/r/138213 (https://bugzilla.wikimedia.org/66323) [21:46:17] (03PS3) 10Gerrit Patch Uploader: Show lock notice on contribs for locked users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/133997 (https://bugzilla.wikimedia.org/52674) [21:46:19] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/133997 (https://bugzilla.wikimedia.org/52674) (owner: 10Gerrit Patch Uploader) [21:46:20] hoo: fixed? [21:47:59] will have a look later on [22:16:59] 3MediaWiki / 3Parser: {{REVISIONTIMESTAMP}} should return the same as {{REVISIONTIMESTAMP: {{FULLPAGENAME}} }} on preview and on [[Special:ExpandTemplates]] - 10https://bugzilla.wikimedia.org/61276#c2 (10Jackmcbarn) 5UNCO>3NEW Whether originally intentional or not, there's no reason {{REVISIONTIMESTAMP}}... [22:19:10] (03PS3) 10Gerrit Patch Uploader: Show block notice on contribs for range-blocked IP [core] - 10https://gerrit.wikimedia.org/r/133988 (https://bugzilla.wikimedia.org/20790) [22:19:12] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/133988 (https://bugzilla.wikimedia.org/20790) (owner: 10Gerrit Patch Uploader) [22:32:23] (03CR) 10Jackmcbarn: "Sorry I missed this earlier, but deleted contributions needs this changed as well." [core] - 10https://gerrit.wikimedia.org/r/133988 (https://bugzilla.wikimedia.org/20790) (owner: 10Gerrit Patch Uploader) [22:36:47] zOMG, a criticism of WMF on wikitech-l that well being "harsh" is actually constructive and not just burn all the developers! - http://lists.wikimedia.org/pipermail/wikitech-l/2014-June/076930.html [22:37:03] I thought wikitech-l was just for political posturing and bikeshedding [22:41:01] bawolff: it was a good email I think. [22:42:09] I agree. I love it when risker wades into dev politics. All her posts to wikitech-l have been very insightful [22:43:17] (03PS4) 10Gerrit Patch Uploader: Show block notice on contribs for range-blocked IP [core] - 10https://gerrit.wikimedia.org/r/133988 (https://bugzilla.wikimedia.org/20790) [22:43:19] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/133988 (https://bugzilla.wikimedia.org/20790) (owner: 10Gerrit Patch Uploader) [22:43:26] jackmcbarn ^ [22:43:58] "But I've increasingly been getting the impression that there aren't a lot of WMF staff who actually like wikis, let alone developing Mediawiki core." - is also interesting [22:44:06] I wonder if that's a true observation [22:44:19] Or just a reflection of WMF funding priorities of features vs platform [22:49:55] I'm not sure about the first part, but I agree with the second. [22:50:19] There are plenty of features that should have been core to begin with but are being put into extensions [22:50:24] I don't think any of the staff actively dislike wikis [22:51:01] Maybe some of the lawyers at the end of a hard day are like "wtf were we thinking letting anyone edit. Look at all these angry legal threats we have to deal with" [22:51:31] But there are more than a couple who I would say aren't particularly experienced at using our software [22:51:46] And perhaps not a fan of the "wiki-way" of doing some things [22:52:56] I think it's more that they don't agree with the wiki culture [22:53:00] which I suppose is good from a prevent group think pov, but less good from understanding user requirements pov [22:53:07] https://www.mediawiki.org/wiki/Mobile_wikitext_editing#Anonymous_editing <-- like, that should have been a feature from day 1 [22:54:04] Well I guess logged in editing only is better than the previous situation of no editing from mobile, but yes [22:54:38] And I'm often astounding at the amount of editcountism in mobile. I feel like if I did that sort of thing on core, I would have a mob on my hand in 30 seconds flat [22:55:05] editcountitis? [22:55:41] e.g. https://en.m.wikipedia.org/wiki/Special:UserProfile/Bawolff [22:55:51] "Joined over 9 years ago with 1,824 edits and 99 uploads." [22:56:51] (03CR) 10Jackmcbarn: [C: 031] "Looks good, tested, seems to work." [core] - 10https://gerrit.wikimedia.org/r/133988 (https://bugzilla.wikimedia.org/20790) (owner: 10Gerrit Patch Uploader) [22:56:52] or in the diff view - https://en.m.wikipedia.org/wiki/Special:MobileDiff/594017070 "Kkj11210 4,272 edits " [22:56:54] https://en.m.wikipedia.org/wiki/Special:MobileDiff/545396469 shows your user groups too. [22:57:56] what is the purpose of Special:UserProfile? [22:58:44] Mobile devs didn't like user pages I guess (?) [22:59:47] it looks like it just shows the last page you edited, the last file you uploaded, and the last person who thanked you (or any log action?) [23:02:03] (03CR) 10Jackmcbarn: [C: 04-1] "Looks good other than my one inline comment." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133661 (https://bugzilla.wikimedia.org/32819) (owner: 10Withoutaname) [23:02:32] huh: thanks specifically [23:03:44] Is that the only place we display "thanks". I thought thanks was supposed to be sort of "private" [23:05:29] bawolff: special:log/thanks [23:05:35] not private... [23:05:59] oh. didn't even notice that was logged [23:06:15] the thanked edit isn't [23:06:32] probably in the api though [23:06:38] (03CR) 10Jackmcbarn: Add new ParserFunction "BLOCKEXPIRY" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133661 (https://bugzilla.wikimedia.org/32819) (owner: 10Withoutaname) [23:07:10] wtf is "r/flow-flow-rev-message-restored-post" [23:07:23] seriously flow team, I really hope you didn't make a log_type named "r" [23:09:54] hmm, no inidication even in the logging table who was thanked. That seems silly [23:10:06] s/who was thanked/for which article was thanked [23:10:24] that is supposedly "private" [23:10:59] bug 49087 [23:11:53] bawolff: uhoh. what log entry is that for? [23:12:17] legoktm: Its in the api as choices for leaction parameter [23:12:27] I don't think anything actually uses them [23:12:30] * bawolff is filing a bug [23:13:02] hmm [23:13:28] https://bugzilla.wikimedia.org/show_bug.cgi?id=66331 [23:14:26] ApiQueryLogEvents::getAllowedLogActions [23:14:29] return array_keys( array_merge( $wgLogActions, $wgLogActionsHandlers ) ); [23:14:54] That's a good point. If thanks were totally public, I wouldn't be able to sarcastically thank people [23:16:10] "Perhaps we should make something even as trivial as a friendly thank you message to someone else, subject to intense scrutiny, curation, triple-checking and investigation for abuse by oversighters or whatever powers that be." (from bug 49087 comment 36) [23:17:30] bawolff: I found the bug. [23:17:35] yay [23:17:35] php > echo "edit-title"['log_type']; [23:17:39] e [23:18:07] Hmm, The comparison to logging who thanked you to aft feature bloat seems a bit stretching it [23:18:29] 3MediaWiki extensions / 3ParserFunctions: {{#insection:true|false}} function that will flag "true" if in a section (for template messages and their different context) - 10https://bugzilla.wikimedia.org/11473#c3 (10Gabriel Wicke) 5NEW>3RESO/WON Closing as WONTFIX for the reasons mentioned by Jackmcbarn.... [23:18:29] the thanker is logged... just not the edit/page [23:19:08] (03PS1) 10Legoktm: Don't set $wgLogActionsHandlers for back-compat strings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/138214 (https://bugzilla.wikimedia.org/66331) [23:19:47] (03CR) 10Legoktm: [C: 04-1] Don't set $wgLogActionsHandlers for back-compat strings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/138214 (https://bugzilla.wikimedia.org/66331) (owner: 10Legoktm) [23:20:27] gwicke: while I won't contest the WONTFIX for a 7 year old bug, I have trouble understanding how jackmcbarn's reason is logical at all... [23:20:52] i.e. what does section headers have to do with it at all? [23:21:18] jackmcbarn: could you explain the problem? [23:21:36] I think I get what's being said [23:21:44] AzaToth: it could make the content of one template depend on the content of a template above it [23:21:45] (03PS2) 10Legoktm: Set $wgLogActionsHandlers properly for back-compat strings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/138214 (https://bugzilla.wikimedia.org/66331) [23:22:00] but we need to be able to process all of the templates on a page at once, rather than going one by one [23:22:17] It seems like it would be more programmatic-er to have an {{#index:section name}} parser function, maybe. [23:22:31] Where you could return the index of the section in the page. [23:22:31] In the mystical future where we use parsoid that renders things parallel ;) [23:22:35] But that's probably tricky. [23:22:36] bawolff: that's now [23:22:48] jackmcbarn: aint ther constructs allready that can interfer with that allready? [23:22:52] The future is now! [23:22:55] AzaToth: no [23:23:05] jackmcbarn: Only on features I don't use ;) [23:23:11] (there's a few obscure ways, but they're all considered bugs to be fixed) [23:23:22] jackmcbarn: what about a template containing ====== [23:23:29] etc... [23:24:25] AzaToth: it self-closes at the end of the template [23:24:59] Gloria: that has the same problem [23:25:03] I thought it didn't ヾ [23:25:04] Probably. [23:25:09] I must remember wrongly [23:25:11] But Parsoid seems to make some assumptions. [23:25:16] i just tested it, because i didn't know either [23:25:26] heh [23:26:00] Module invocations have to be independent of page position or execution order, I guess. [23:26:08] Because of this parallel constraint. [23:26:33] Gloria: When using parsoid [23:26:59] core parser is slow and mostly works in linear order [23:27:00] it's not just parallelization. if someone changes Template:X, the only part of the page that should get re-rendered is {{X}} [23:27:03] Right, but Parsoid is affecting the assumptions and constraints of other code. [23:27:22] That's definitely in the mythical future [23:27:26] jackmcbarn: I assume {{#time}} gives the same time in all templates? [23:27:37] As it stands we re-render the whole page [23:27:41] regardless of execution time [23:27:53] jackmcbarn: what if it looks like {{Y|{{X}}}} ? [23:28:09] then if Template:X is edited, the result for Y must be re-rendered too? [23:28:10] We say we're going to re-render the whole page. [23:28:12] huh: yes [23:28:13] We don't actually do it. [23:28:27] We do it sometimes. [23:28:34] AzaToth: i don't know, i'll try it [23:28:36] We make promises to do it later, maybe. [23:28:39] Well its an all or nothing sort of thing [23:28:43] We never re-render half the page [23:28:52] php doesn't. parsoid will [23:29:20] emphasis on the "will" [23:29:35] it already does parallelize, though, so it already will break if you add something with state [23:29:51] they can't even use our version of Cite since it has state. they had to re-write it as an extra parse pass [23:30:19] Cite isn't the only thing with state [23:30:28] bawolff: isn't it? [23:30:46] Well much more simple example - {{DEFAULTSORTKEY:..}} has state [23:31:06] jackmcbarn: {{#ifexpr:{{#time:s}}md2=0|====foo====|}} [23:31:14] {{#ifexpr:{{#time:s}}mod2=0|====foo====|}} [23:31:27] Some of the parser functions that query db, cache answers and will change whether they update expensive parser function count depending on cache hit/miss [23:31:29] AzaToth: right, that's why we can't have section detection [23:32:01] if time gives more than a second diff per template, I assume that would give different sections [23:32:14] AzaToth: i just tested, #time is the same throughout a parse [23:32:15] Parsoid folks seem to think its already a given that parsoid definitely will replace the current parser when its ready. They may be right, but I'm not sure if that's actually a foregone conclusion [23:32:29] jackmcbarn: just by luck, or always? [23:32:32] AzaToth: always [23:32:42] it doesn't look at the current time. it looks at the one ParserFunctions has [23:32:45] err [23:32:47] ParserOptions [23:33:05] ok, and it's static for the whole exection? [23:33:08] yes [23:33:33] AzaToth: Have I shown you https://en.wikipedia.org/wiki/User_talk:Sgeo/null-edit-detector ? :-) [23:33:37] Btw jackmcbarn are you a new MediaWiki contributor? I've noticed you have suddenly become very active over the past week. :) [23:33:48] Krenair: not that new. going on a year now [23:34:10] Gloria: ah yes, abusing the PST. i've built a few of those too [23:35:06] Gloria: nice ツ [23:35:34] but howthefuck do I revert? [23:36:22] Gloria, dear god what is that?! [23:36:54] Well I know what it is, but how the hell does that work [23:37:11] It violates what I thought was a fundamental principle of MediaWiki. [23:37:13] and how do you restore it? [23:37:18] AzaToth: The talk page, silly. [23:37:19] I fixed it. [23:37:23] Further proof that enwiki should not be trusted with wikitext, ever :p [23:37:29] Rollback doesn't work, for some reason. [23:37:40] Gloria: was the PST ever supposed to be idempotent? [23:37:41] But if copy the talk page contents into the edit area and press save, it works. [23:37:45] Gloria: the talk page source, or the talk page render? [23:37:56] AzaToth: Talk page render. [23:38:00] rollback is probably doing pst on it [23:38:17] jackmcbarn: The principle is that you can click edit, click save, and only do a null edit. [23:38:27] Gloria, April 2006. Does that still work? [23:38:28] Which works... most of the time. [23:38:45] Krenair: Does what still work? [23:38:47] lol [23:38:54] It's still a null edit detector, yes. [23:38:57] Gloria, the null edit detecting hack [23:38:58] Try null editing the page. :-) [23:39:13] and then try to revert your null edit [23:39:14] Or look at the page history. [23:39:25] why doesn't rollback work? [23:39:32] PST, we think. [23:39:39] Post-save transformation. [23:39:41] PST sounds like a disease [23:39:51] but then we wouldn't have any of https://meta.wikimedia.org/wiki/Help:Recursive_conversion_of_wikitext or https://test.wikipedia.org/wiki/Module:Sandbox/Jackmcbarn/PolymorphicEditProtected [23:39:51] It's plaguing our wikis. [23:39:55] Much like HtmlBuilder. [23:40:12] HtmlBuilder is on its way out. it'll start going away as soon as my patch to mw.html goes through [23:40:31] * AzaToth still waits for phase 4 [23:40:38] phase 4 of what? [23:40:40] Using Lua is cheating. :P [23:40:42] MW [23:40:44] jackmcbarn: We're in phase 3. [23:40:50] jackmcbarn: phase3 is mediawiki [23:40:54] i'm not sure what these phases are [23:41:22] Ahh, it expands stuff not when inserted but when edited again? [23:41:26] $ git clone https://github.com/wikimedia/mediawiki-core phase3 [23:41:36] jackmcbarn: https://www.mediawiki.org/wiki/MediaWiki_history [23:41:37] jackmcbarn: https://www.mediawiki.org/wiki/MediaWiki_history :-) [23:41:42] jackmcbarn: https://www.mediawiki.org/wiki/History [23:41:45] * jackmcbarn trouts jackmcbarn [23:41:47] Oh, beaten. [23:41:47] argh, beaten. [23:41:52] Such jinxen. [23:42:16] Krenair: it expands it both times. [23:42:21] The English Wikipedia also has an article, I think. [23:42:22] Bizarrely. [23:42:44] Phase II is the first one that could even be considered a precursor of MediaWiki, since Phase I is a completely different software [23:42:54] Phase 3 may refer to: [23:42:54] The third of the phases of clinical research [23:42:54] Phase 3 Eclipse, an ultralight aircraft [23:43:35] https://en.wikipedia.org/wiki/MediaWiki_version_history [23:43:40] the first one there seems pretty obvious.... [23:44:09] "The third of the phases may be refered as Phase 3".... [23:44:15] jackmcbarn, before we migrated to Git (2013-03-21), MediaWiki lived in a directory called phase3 under SVN [23:44:17] no shit sherlock... [23:44:26] 2012-03-21, even [23:44:44] * Gloria pets AzaToth. [23:44:45] Krenair: 21 is an odd number [23:45:12] AzaToth, ... okay? [23:45:20] It was a bad joke. [23:45:27] so it should be 2012-03-21, odd [23:45:28] :-P [23:45:36] -.- [23:45:44] * Gloria NP: "Wobble" by V.I.C. from "Beast" [23:45:46] * AzaToth goes hiding under a rock sobbing [23:45:56] http://svn.wikimedia.org/svnroot/mediawiki/branches/REL1_17/phase3/ [23:46:58] REL1_18 was released from SVN as well right? And REL1_19 was created in SVN... [23:47:12] yeah, it seems so [23:51:16] Hello lilatretikov. [23:52:17] liangent: fyi I fixed all your comments https://gerrit.wikimedia.org/r/#/c/116691/ [23:57:59] 3MediaWiki extensions / 3CentralAuth: Creation of WikiSets are logged to Special:WikiSets/0 - 10https://bugzilla.wikimedia.org/27031#c4 (10Alex Monk) Additionally, Hoo fixed the following metawiki log entries: | log_id | log_timestamp | log_comment | log_user_text | | 1934956 | 20110702185...