[00:00:37] (03CR) 10Dduvall: "It looks like the infinite recursion is actually due to the shell specified in our Vagrantfile, not due to the rbenv setup. I'll be filing" [vagrant] - 10https://gerrit.wikimedia.org/r/137483 (https://bugzilla.wikimedia.org/50993) (owner: 10Dduvall) [00:04:54] Krinkle: I need any other environment to run socket io ? because I am still getting this error Exception thrown by ext.ActivityMonitor.socketio: 'undefined' is not an object (evaluating 'b.transports.push') [00:05:27] Krinkle: can you send pull request for the same ?? [00:06:13] harshkothari: Are there any new changes you can push first? [00:06:35] yeah one small changes I am pushing [00:07:29] Krinkle: Now everything is pushed [00:08:07] (03PS2) 10Jack Phoenix: Version 2.2: RequestContext love, spacing tweaks + position => top for CSS RL modules. [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/137170 [00:08:12] (03CR) 10jenkins-bot: [V: 04-1] Version 2.2: RequestContext love, spacing tweaks + position => top for CSS RL modules. [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/137170 (owner: 10Jack Phoenix) [00:08:58] (03CR) 10Jack Phoenix: "recheck" [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/137170 (owner: 10Jack Phoenix) [00:12:11] (03PS1) 10Jack Phoenix: Fix fatal under MediaWiki 1.23. [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/137839 [00:13:09] (03PS1) 10Jack Phoenix: When you use $wgTitle, you code with Satan! [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/137840 [00:13:11] (03CR) 10Jack Phoenix: [C: 032 V: 032] Fix fatal under MediaWiki 1.23. [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/137839 (owner: 10Jack Phoenix) [00:14:52] harshkothari: https://raw.githubusercontent.com/Automattic/socket.io-client/0.9/dist/socket.io.js [00:14:54] use that one instead [00:14:58] I think the minification is conflicting [00:15:03] when I use debug=true it works fine [00:16:49] Krinkle: same error [00:17:48] Krinkle: when I do debug=true it runs and but it also gives this error Failed to load resource: Could not connect to the server. [00:18:02] connection works for me [00:18:07] what browser / os / version do you have [00:18:28] shouldn't make a difference, but then I can try that [00:20:04] Krinkle: Safari [00:20:13] Krinkle: http://imgur.com/TS3AdT1 http problem ?? [00:20:35] (03CR) 10Mattflaschen: "There's an older patch adding several mixins, and one of them is box-shadow. Do you mind removing that from here (leaving border-radius)," [core] - 10https://gerrit.wikimedia.org/r/134964 (owner: 10Robmoen) [00:22:00] 3Wikimedia / 3Extension setup: Deploy Mantle extension to WMF servers - 10https://bugzilla.wikimedia.org/66094 (10spage) [00:23:16] Krinkle: Chrome same error. [00:23:46] harshkothari: with debug=true it works in Chrome and Safari [00:23:59] without debug=true it fails on .push undefined, this is due to a bug in socket.io with wrapping [00:24:02] https://github.com/Automattic/socket.io-client/issues/497 [00:24:23] then what is problem with my laptop ?? :( [00:24:48] Krinkle: Chrom console : GET http://stream.wikimedia.org:8888/socket.io/1/?t=1402014165066 net::ERR_CONNECTION_REFUSED [00:25:03] harshkothari: Maybe you're behind a firewall? [00:25:39] Krinkle: means ?? [00:26:09] Something on your computer, or your router is blocking ability to make connections to websites on the internet via port 8888? [00:27:06] ohhh shit Krinkle my localhost running on 8888 Krinkle [00:27:15] 3MediaWiki extensions / 3Popups: Hovercards quickly disappearing and reappearing when clicking a link (causing annoying flicker) - 10https://bugzilla.wikimedia.org/66221#c1 (10Prateek Saxena) 5UNCO>3ASSI a:3Prateek Saxena (In reply to Eduard Braund in comment #0) > When hovering a link and then clicki... [00:27:20] Krinkle: apache is running on 8888 [00:27:32] That shouldn't matter much [00:27:43] But you can try turning it off for a second or move it to another port [00:27:46] (port 80?) [00:28:06] Krinkle: yeah shifted to 8080 now checking [00:28:15] I run my web server on port 80, I can still connect to other websites on port 80. [00:29:13] 3MediaWiki / 3General/Unknown: HHVM: could not uncompress value in MemcachedPeclBagOStuff.php on line 124 - 10https://bugzilla.wikimedia.org/66104#c7 (10Ori Livneh) 5NEW>3RESO/FIX Submitted: https://github.com/atdt/hhvm/commit/3e97781e6c2e3b52c8647957909ec9308d09dfe6 [00:31:14] Krinkle: same problem GET http://stream.wikimedia.org:8080/socket.io/1/?t=1402014656066 net::ERR_CONNECTION_REFUSED :( [00:31:38] http connection is the problem ?? [00:31:38] (03PS2) 10Lewis Cawte: When you use $wgTitle, you code with Satan! [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/137840 (owner: 10Jack Phoenix) [00:32:36] (03CR) 10Liangent: "Had a second look and it appears that $dbr is now completely unused..." [core] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137807 (owner: 10MaxSem) [00:32:39] (03PS1) 10Spage: Merge branch 'master' into frontend-rewrite [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137841 [00:33:08] harshkothari: Sorry I cant help you. The code is fine. There is something on your end making it blocked. [00:33:22] harshkothari: I'm not sure also why it is connecting to 8080 or 8888 [00:33:26] Are you passing it that port? [00:33:29] It shouldn't go to 8080 [00:33:46] (03PS1) 10Bsitu: Show topic summary in topic title bar [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137842 [00:33:47] Krinkle: Nopes thats my concern [00:33:59] Krinkle: it shouldnt go to 8080 [00:34:03] harshkothari: How come your connection to stream.wikimedia.org changed when you changed your webserver from 8888 to 8080 [00:34:24] Krinkle: I have no idea about it. It changed automatically [00:34:42] so thats where something going wrong [00:35:10] harshkothari: Try specifying http://stream.wikimedia.org:80/rc [00:35:18] Krinkle: even firewall is off [00:35:25] :80 is default, but if your website is on :8080 maybe it defaults to that [00:35:36] * harshkothari is doing [00:35:43] I'd also recommend changing your local website to run on :80 (e.g. default) so you have http://localhost/wiki/Special: [00:35:49] instead of :8888 or :8080 [00:36:24] perfect I agree [00:36:30] I should change to 80\ [00:36:41] its now running Krinkle thanks [00:38:31] (03Abandoned) 10Lewis Cawte: When you use $wgTitle, you code with Satan! [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/137840 (owner: 10Jack Phoenix) [00:39:01] Krinkle: so the thing is if you dont specify the port then it will take your localhost port from where you are making request [00:39:13] Yeah [00:39:54] Krinkle: so for safety we should add :80 to request url.. [00:42:44] 3MediaWiki extensions / 3Popups: Hovercards quickly disappearing and reappearing when clicking a link (causing annoying flicker) - 10https://bugzilla.wikimedia.org/66221#c2 (10Eduard Braun) (In reply to Prateek Saxena from comment #1) > Does the card reposition itself away from the mouse pointer for you too?... [00:43:11] (03CR) 10Hoo man: [C: 032] Add missing possible errors to ApiQueryLogEvents.php [core] - 10https://gerrit.wikimedia.org/r/135815 (owner: 10Umherirrender) [00:43:59] 3MediaWiki / 3Recent changes: Log actions should support bot flag (e.g. to hide from Special:RecentChanges) - 10https://bugzilla.wikimedia.org/16816 (10charitwo) p:5Low>3Normal [00:46:45] (03Merged) 10jenkins-bot: Add missing possible errors to ApiQueryLogEvents.php [core] - 10https://gerrit.wikimedia.org/r/135815 (owner: 10Umherirrender) [00:49:48] harshkothari: so the fix is [00:49:49] $ curl 'https://raw.githubusercontent.com/Automattic/socket.io-client/0.9/dist/socket.io.js' > lib/socketio.js [00:49:52] then change the first line from [00:49:54] var io = [00:49:54] to [00:49:56] io = [00:50:14] 3MediaWiki extensions / 3WikidataRepo: UI for Simple Query - 10https://bugzilla.wikimedia.org/55593#c9 (10WikidataBugzilla) Commit pushed to snakview at https://github.com/wmde/WikibaseQuery https://github.com/wmde/WikibaseQuery/commit/4ff7dbbff1e11562d442674c18375f89581f4b74 Use Wikibase's snakview for the... [00:50:33] The reason is that it assumes global context, but we load it in secure closure, so the variable isn't exported properly [00:50:37] this is fixed in socket.io.js 1.0 [00:50:40] but we cant' use that yet [00:50:51] because 1.0 has a new backend prototocol (incompatible) [00:51:15] thats why I received packets when I removed debug=true and when I was using 1.0 [00:53:17] debug=true executes it in a global scope without closure [00:53:22] so the variable becomes global [00:53:35] with 1.0 I don't know, I don't think 1.0 will work no matter what [00:54:10] I received packets on console only Krinkle [00:54:23] OK [00:55:35] Krinkle: Now I added simple css and now I am going to sleep 6:30 AM and I will update this to fit into mw-content area [00:55:45] cool [00:56:10] Krinkle: its fun :) thanks a lot learning lots of thing :) [00:56:38] Krinkle: gn :) [00:58:33] hopefully tomorrow we will get git repo so that we can do initial commit [00:58:47] 3Wikimedia / 3Stream: RCStream: Upgrade backend to use protocol that works with socket.io 1.0 - 10https://bugzilla.wikimedia.org/66232 (10Krinkle) 3NEW p:3Unprio s:3enhanc a:3None When using socket.io.js from 1.0.x, no connection can be established. The client is trying to make connections to http:... [00:59:14] 3MediaWiki / 3Watchlist: Clearing large (39k+) watchlist @ Special:EditWatchlist/clear fails, HTTP error 503 - 10https://bugzilla.wikimedia.org/66212#c2 (10UP) (In reply to Jesús Martínez Novo (Ciencia Al Poder) from comment #1) > If you try it again, does it happen consistently? > > A /clear is supposed to... [00:59:15] 3Wikimedia / 3Stream: RCStream: Upgrade backend to use protocol that works with socket.io 1.0.x - 10https://bugzilla.wikimedia.org/66232 (10Krinkle) 5NEW>3ASSI p:5Unprio>3High a:3Ori Livneh [01:00:53] (03PS1) 10Liangent: Remove $dbr from ChangeTags::addTags() [core] - 10https://gerrit.wikimedia.org/r/137847 [01:05:50] (03CR) 10TTO: "Could you undelete the page on your test wiki so I can have a look?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/84197 (https://bugzilla.wikimedia.org/40192) (owner: 10TTO) [01:06:29] 3Wikimedia / 3Site requests: Change default font for EasyTimeline on zh projects to something that actually has glyphs for Chinese characters - 10https://bugzilla.wikimedia.org/20825#c24 (10Liangent) No luck :( it still appears not working. [01:07:46] (03CR) 10TTO: "a) That patch is about editnotices, this is about page notices." [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105143 (owner: 10TTO) [01:08:14] (03CR) 10TTO: "Sorry, I see that the other page is about editintros. Still, they are not page notices." [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105143 (owner: 10TTO) [01:15:42] (03Abandoned) 10Spage: Merge branch 'master' into frontend-rewrite [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137841 (owner: 10Spage) [01:18:31] 3MediaWiki extensions / 3Cite: Cite should warn/stop the user from saving if the page is invalid - 10https://bugzilla.wikimedia.org/66233 (10James Forrester) 3NEW p:3Unprio s:3normal a:3None Multiple easy mistakes cause horrible, ugly red text: * but not * , unnamed *... [01:18:44] 3MediaWiki extensions / 3Cite: Cite should warn/stop the user from saving if the page is invalid - 10https://bugzilla.wikimedia.org/66233 (10James Forrester) p:5Unprio>3High s:5normal>3enhanc [01:50:58] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (c9b9f8345d) [core] - 10https://gerrit.wikimedia.org/r/137851 [01:51:13] (03CR) 10Spage: [C: 032] "LGTM and compiling 'flow_edit_post.html.handlebars' in JS is definitely broken without this, so +2." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137823 (owner: 10EBernhardson) [01:52:16] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (c9b9f8345d) [core] - 10https://gerrit.wikimedia.org/r/137851 (owner: 10Jforrester) [01:52:28] (03Merged) 10jenkins-bot: Dont utilize && in templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137823 (owner: 10EBernhardson) [01:55:31] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (c9b9f8345d) [core] - 10https://gerrit.wikimedia.org/r/137851 (owner: 10Jforrester) [01:58:26] (03PS2) 10Spage: Use proper MW messages in front-end. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/136635 [02:00:10] (03CR) 10Spage: [C: 031] "PS2 should be OK to merge, and ErikB's https://gerrit.wikimedia.org/r/#/c/137823/ fixes the JS compilation errors I noticed in PS1." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/136635 (owner: 10Spage) [02:00:13] (03PS1) 10Legoktm: Expose log_id in RC feed [core] - 10https://gerrit.wikimedia.org/r/137853 (https://bugzilla.wikimedia.org/20394) [02:01:03] (03CR) 10Jackmcbarn: "Needs rebased" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/55602 (owner: 10Anomie) [02:03:29] 3Wikimedia / 3Site requests: Change default font for EasyTimeline on zh projects to something that actually has glyphs for Chinese characters - 10https://bugzilla.wikimedia.org/20825#c25 (10Roy Tam) (In reply to Liangent from comment #24) > No luck :( it still appears not working. I just wonder if that sett... [02:10:24] legoktm: someone is wondering if you're account's compromised. why don't you use the sandbox to test? :p [02:10:40] o.O [02:10:42] test what? [02:10:50] the stuff you test on your user page [02:10:59] wow, i'm tired. i used the wrong form of your [02:11:43] my userpage is my personal sandbox... -.- [02:12:47] Also because I already have my userpage bookmarked in the iOS app [02:29:33] (03PS1) 10Legoktm: Provide socket.io via ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/137855 [02:30:25] (03PS2) 10Legoktm: Provide socket.io-client via ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/137855 [02:31:13] (03CR) 10Legoktm: Provide socket.io-client via ResourceLoader (031 comment) [core] - 10https://gerrit.wikimedia.org/r/137855 (owner: 10Legoktm) [02:34:29] (03CR) 10jenkins-bot: [V: 04-1] Provide socket.io-client via ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/137855 (owner: 10Legoktm) [02:37:05] (03PS4) 10Jackmcbarn: Allow fetching unexpanded arguments [core] - 10https://gerrit.wikimedia.org/r/123671 [02:38:44] (03PS3) 10Legoktm: Provide socket.io-client via ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/137855 [02:42:36] (03CR) 10jenkins-bot: [V: 04-1] Provide socket.io-client via ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/137855 (owner: 10Legoktm) [02:43:33] (03PS4) 10Legoktm: Provide socket.io-client via ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/137855 [02:46:59] 3MediaWiki / 3Recent changes: RCFeed: Expose log_id in RC feed - 10https://bugzilla.wikimedia.org/20394#c3 (10Ori Livneh) What is the value of having it there? [02:47:22] (03CR) 10jenkins-bot: [V: 04-1] Provide socket.io-client via ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/137855 (owner: 10Legoktm) [02:48:44] 3Wikimedia / 3Site requests: Change default font for EasyTimeline on zh projects to something that actually has glyphs for Chinese characters - 10https://bugzilla.wikimedia.org/20825#c26 (10Bawolff (Brian Wolff)) (In reply to Roy Tam from comment #25) > (In reply to Liangent from comment #24) > > No luck :(... [02:49:59] 3Wikimedia / 3Site requests: Change default font for EasyTimeline on zh projects to something that actually has glyphs for Chinese characters - 10https://bugzilla.wikimedia.org/20825#c27 (10Roy Tam) (In reply to Bawolff (Brian Wolff) from comment #26) > (In reply to Roy Tam from comment #25) > > (In reply to... [02:50:17] (03PS5) 10Legoktm: Provide socket.io-client via ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/137855 [02:51:34] (03PS3) 10Jlloyd: Allow for URLs in article assignment [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/134598 (https://bugzilla.wikimedia.org/44397) [02:51:58] 3Wikimedia / 3Stream: RCStream: Upgrade backend to use protocol that works with socket.io 1.0.x - 10https://bugzilla.wikimedia.org/66232 (10Ori Livneh) [02:54:09] (03CR) 10jenkins-bot: [V: 04-1] Provide socket.io-client via ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/137855 (owner: 10Legoktm) [02:57:44] 3Wikimedia / 3Stream: RCStream: Upgrade backend to use protocol that works with socket.io 1.0.x - 10https://bugzilla.wikimedia.org/66232#c1 (10Ori Livneh) v1.0 changes the protocol substantially. Apart from bragging rights about using the latest and greatest, I don't see major gains to be had. 0.9 is well-te... [02:58:28] 3Wikimedia / 3Stream: RCStream: Upgrade backend to use protocol that works with socket.io 1.0.x - 10https://bugzilla.wikimedia.org/66232#c2 (10Ori Livneh) (Not to mention: we want to give the popular client libraries time to upgrade, too.) [03:21:33] (03PS10) 10Jlloyd: Add notifications for article page changes [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/118101 (https://bugzilla.wikimedia.org/56325) [03:23:44] 3MediaWiki extensions / 3ContentTranslation: Page freeze when 'Add translation' is clicked in a certain case - 10https://bugzilla.wikimedia.org/64542 (10Santhosh Thottingal) 5PATC>3RESO/FIX [03:58:28] 3MediaWiki / 3API: Stacktrace on copy-by-url upload - 10https://bugzilla.wikimedia.org/32204 (10Krinkle) [04:02:51] (03CR) 10Mattflaschen: [C: 04-2] "Needs further investigation, of these issues:" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/137528 (https://bugzilla.wikimedia.org/65514) (owner: 10Mattflaschen) [04:03:14] 3MediaWiki / 3Skin and page rendering: Vector: Page actions in dropdown menu should expand if space allows - 10https://bugzilla.wikimedia.org/22986#c12 (10Krinkle) Rephrasing bug. Basically all tabs should expand out of any drop down menu if space is available. Some may be fixed to never go into a menu (lik... [04:03:29] 3MediaWiki / 3Skin and page rendering: Vector: Page actions in dropdown menu should expand if space allows - 10https://bugzilla.wikimedia.org/22986 (10Krinkle) p:5Normal>3High [04:05:44] 3MediaWiki / 3Parser: Add option to put "served in 0.344 seconds" message in footer, rather than as HTML comment - 10https://bugzilla.wikimedia.org/23045 (10Krinkle) [04:05:45] 3MediaWiki / 3Parser: Add option to put "served in 0.344 seconds" message in footer, rather than as HTML comment - 10https://bugzilla.wikimedia.org/23045#c5 (10Krinkle) 5NEW>3RESO/WOR During development this can be displayed in the (much more advanced) Debug toolbar via $wgDebugToolbar. In production, t... [04:05:59] 3MediaWiki / 3General/Unknown: Remove usages of deprecated Linker calls from core - 10https://bugzilla.wikimedia.org/23234 (10Krinkle) [04:06:05] (03CR) 10Mattflaschen: "I forgot to say, originally I did not have a separate JSON file. I just had an associative array mapping the keys, and the WikimediaMessa" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/137528 (https://bugzilla.wikimedia.org/65514) (owner: 10Mattflaschen) [04:07:10] (03CR) 10Mattflaschen: ""there was no automatically enforced relationship between the core and extension message key"" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/137528 (https://bugzilla.wikimedia.org/65514) (owner: 10Mattflaschen) [04:09:01] 3Wikimedia / 3Extension setup: Deploy Mantle extension to WMF servers - 10https://bugzilla.wikimedia.org/66094 (10Greg Grossmeier) [04:09:01] 3MediaWiki extensions / 3SyntaxHighlight (GeSHi): SyntaxHighlight_GeSHi: Implement link anchors to line numbers of contents - 10https://bugzilla.wikimedia.org/27531#c7 (10Krinkle) p:5Normal>3Low The output would probably use something like where f2 indicates it is th... [04:09:03] 3Wikimedia / 3Extension setup: Security review of Mantle extension - 10https://bugzilla.wikimedia.org/66238 (10Greg Grossmeier) 3NEW p:3Unprio s:3normal a:3Chris Steipp https://www.mediawiki.org/wiki/Extension:Mantle From bug 66094: (In reply to spage from comment #3) > (In reply to Greg Grossmeier... [04:09:14] 3Wikimedia / 3Extension setup: Deploy Mantle extension to WMF servers - 10https://bugzilla.wikimedia.org/66094#c4 (10Greg Grossmeier) (In reply to spage from comment #3) > (In reply to Greg Grossmeier from comment #1) > > Any new code here... ? > > Yes. Besides the code that was formerly in extension Mobile... [04:09:44] 3MediaWiki extensions / 3SyntaxHighlight (GeSHi): SyntaxHighlight_GeSHi: Implement link anchors to line numbers of contents - 10https://bugzilla.wikimedia.org/27531#c8 (10Krinkle) If handling potential multiple occurrences on a page is too difficult, we can at least start by supporting it on entire... [04:12:44] 3MediaWiki / 3General/Unknown: Add hooks for when article save or article delete failed - 10https://bugzilla.wikimedia.org/30449 (10Krinkle) [04:13:29] 3MediaWiki / 3ResourceLoader: CSSMin::minify should leave string property values untouched - 10https://bugzilla.wikimedia.org/35492 (10Krinkle) p:5Low>3Normal [04:13:59] 3MediaWiki / 3ResourceLoader: CSSMin::minify should not interfere value contents of string values - 10https://bugzilla.wikimedia.org/35492 (10Krinkle) [04:15:44] 3MediaWiki / 3ResourceLoader: CSSMin::minify could trim a little more - 10https://bugzilla.wikimedia.org/35493#c1 (10Krinkle) Added tests cases for these in Ic9195614acfd616ccd. [04:24:02] (03CR) 10Legoktm: "Just having an array with the keys in it fixes the performance issue I think." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/137528 (https://bugzilla.wikimedia.org/65514) (owner: 10Mattflaschen) [04:24:44] (03PS1) 10Prtksxna: renderer.article: Escape RegExp syntax from the article's title [extensions/Popups] - 10https://gerrit.wikimedia.org/r/137862 (https://bugzilla.wikimedia.org/66203) [04:24:49] (03CR) 10jenkins-bot: [V: 04-1] renderer.article: Escape RegExp syntax from the article's title [extensions/Popups] - 10https://gerrit.wikimedia.org/r/137862 (https://bugzilla.wikimedia.org/66203) (owner: 10Prtksxna) [04:26:41] (03PS2) 10Prtksxna: renderer.article: Escape RegExp syntax from the article's title [extensions/Popups] - 10https://gerrit.wikimedia.org/r/137862 (https://bugzilla.wikimedia.org/66203) [04:26:49] (03CR) 10Mattflaschen: "They should be attributed somehow in-code. Maybe add wikiHow as an @author in Echo.php, or somewhere." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/135396 (https://bugzilla.wikimedia.org/56828) (owner: 10Legoktm) [04:26:58] 3MediaWiki / 3ResourceLoader: @import styles broken in modules that combine multiple stylesheets - 10https://bugzilla.wikimedia.org/35562#c16 (10Krinkle) 5ASSI>3NEW p:5High>3Lowest s:5major>3minor Reindexing as low priority bug. For any modules loaded through ResourceLoader properly (mediawiki c... [04:27:14] 3MediaWiki extensions / 3Gadgets: Gadgets with CSS+JS should not have their stylesheet ripped out of context into the only=styles - 10https://bugzilla.wikimedia.org/35471 (10Krinkle) [04:27:15] 3MediaWiki / 3ResourceLoader: @import styles broken in modules that combine multiple stylesheets - 10https://bugzilla.wikimedia.org/35562 (10Krinkle) [04:28:46] 3MediaWiki / 3ResourceLoader: Get rid of startUp() function in mediawiki.js - 10https://bugzilla.wikimedia.org/37894 (10Krinkle) a:5roopak>3None [04:28:58] 3MediaWiki / 3ResourceLoader: Get rid of startUp() function in mediawiki.js - 10https://bugzilla.wikimedia.org/37894 (10Krinkle) p:5Normal>3Low [04:29:44] 3MediaWiki / 3API: HTML formats intro not always shown - 10https://bugzilla.wikimedia.org/38126 (10Krinkle) s:5minor>3normal [04:31:13] 3MediaWiki / 3User blocking: Unable to block large IPv4 /8 ranges - 10https://bugzilla.wikimedia.org/42303 (10Krinkle) p:5Low>3Normal [04:31:33] (03PS4) 10Werdna: Segregate Reference objects by source wiki. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136280 (https://bugzilla.wikimedia.org/65915) [04:33:21] (03CR) 10Werdna: "Patch Set 4: Now with a deployment plan." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136280 (https://bugzilla.wikimedia.org/65915) (owner: 10Werdna) [04:38:43] 3MediaWiki / 3Watchlist: Special:EditWatchlist no longer returs to self after submitting the form - 10https://bugzilla.wikimedia.org/31753 (10Krinkle) [04:39:43] 3MediaWiki / 3Page editing: Allow creation of revisionless page entries - 10https://bugzilla.wikimedia.org/41473 (10Krinkle) [04:48:06] (03CR) 10Mattflaschen: [C: 04-1] "I think ->text() is right. See inline." [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/134624 (owner: 10Paladox) [04:55:34] (03CR) 10Mattflaschen: ""Why do you want to override the sidebar message by default?"" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/137528 (https://bugzilla.wikimedia.org/65514) (owner: 10Mattflaschen) [05:34:36] (03CR) 10Nemo bis: "Sure, I changed namespace names so links don't work. :) http://pagemigration.wmflabs.org/w/index.php?title=Template:Ambox&action=history" [core] - 10https://gerrit.wikimedia.org/r/84197 (https://bugzilla.wikimedia.org/40192) (owner: 10TTO) [05:51:29] 3Analytics / 3Tech community metrics: Gerrit metrics about open changesets should ignore -1s - 10https://bugzilla.wikimedia.org/63533#c15 (10Alvaro) Quim, after reviewing, the problem was the predicted: * For companies we are starting the analysis from startok = "'2013-04-30'" and this is why in April the v... [05:56:44] (03CR) 10Frédéric Wang: SpecialPage for MathImages (036 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/137815 (owner: 10Physikerwelt) [06:00:31] 3MediaWiki extensions / 3Popups: Hovercards: occasional single flicker for cards that overlap with the link (edge-case) - 10https://bugzilla.wikimedia.org/66240 (10Quiddity) 3NEW p:3Unprio s:3minor a:3None See attachment 15555 for video. To reproduce, bring your pointer down from above the link so... [06:01:13] 3MediaWiki extensions / 3Popups: Hovercards popping up above cause flickering (because of popping up under the mouse cursor) - 10https://bugzilla.wikimedia.org/65433#c15 (10Quiddity) (In reply to Eduard Braun from comment #14) > @Quiddity: Will you open a separate bug report for your specific problem > (whic... [06:09:06] (03CR) 10Frédéric Wang: "Yes breaking in smaller steps would help." (033 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/137808 (owner: 10Physikerwelt) [06:11:41] (03CR) 10Frédéric Wang: "Also, can you recall me how we are going to enable the SVG output for other rendering engines other IE < 9?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/137808 (owner: 10Physikerwelt) [06:14:44] (03PS2) 10Werdna: Hacky sub-expression implementation for lightncandy [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137708 (owner: 10EBernhardson) [06:15:52] (03PS3) 10Werdna: Hacky sub-expression implementation for lightncandy [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137708 (owner: 10EBernhardson) [06:20:43] (03CR) 10Werdna: "PS2 addresses the following problems:" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137708 (owner: 10EBernhardson) [06:26:44] 3Wikimedia / 3Site requests: Clarify all odd numbered namespaces are allowed MassMessage targets - 10https://bugzilla.wikimedia.org/65524 (10Nemo) 5PATC>3RESO/FIX [06:29:18] (03PS2) 10Werdna: Implement anon warning in frontend-rewrite [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137539 [06:33:46] (03CR) 10Werdna: "PS2: Now based on change 137708 (so the subexpressions work now), changed the links to point to the correct target, fixed a few bugs, and " [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137539 (owner: 10Werdna) [06:36:43] (03CR) 10TheDJ: [C: 04-1] Disable NavigationPopups (Gadget) if Popups (Extension) is enabled (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (https://bugzilla.wikimedia.org/62952) (owner: 10Prtksxna) [06:48:18] (03PS16) 10Werdna: Replace occupation w/ ContentHandler integration. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/131043 [06:50:58] (03CR) 10Werdna: "Figured out that we were getting an infinite recursion like this:" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/131043 (owner: 10Werdna) [06:56:57] (03CR) 10Hoo man: [C: 032] Add error 'pagecannotexist' to ApiBase::getTitleOrPageIdErrorMessage [core] - 10https://gerrit.wikimedia.org/r/134469 (owner: 10Umherirrender) [07:00:06] (03Merged) 10jenkins-bot: Add error 'pagecannotexist' to ApiBase::getTitleOrPageIdErrorMessage [core] - 10https://gerrit.wikimedia.org/r/134469 (owner: 10Umherirrender) [07:00:44] 3MediaWiki extensions / 3Translate: Async saving of page translation edits? - 10https://bugzilla.wikimedia.org/45894#c5 (10Nemo) Curiously, it's possible to trigger an update of a translation page even with a null (API) edit to a translation unit page: https://www.mediawiki.org/w/index.php?title=Academic_hub... [07:09:18] (03PS1) 10devunt: Remove obsolete RC_MOVE and RC_MOVE_OVER_REDIRECT rc types [extensions/SimpleChanges] - 10https://gerrit.wikimedia.org/r/137887 [07:09:54] (03PS1) 10Prtksxna: Add wikifont to core [core] - 10https://gerrit.wikimedia.org/r/137888 (https://bugzilla.wikimedia.org/66138) [07:10:13] (03PS2) 10devunt: Remove obsolete RC_MOVE and RC_MOVE_OVER_REDIRECT rc types [extensions/SimpleChanges] - 10https://gerrit.wikimedia.org/r/137887 [07:11:56] (03CR) 10Prtksxna: "I am not sure how to load webfonts with ResourceLoader. Should they be encoded in the CSS itself like `entypo` in EventLogging?" [core] - 10https://gerrit.wikimedia.org/r/137888 (https://bugzilla.wikimedia.org/66138) (owner: 10Prtksxna) [07:23:01] 3MediaWiki extensions / 3CirrusSearch: Regression: using unicode normalization analyzer misses results in search - 10https://bugzilla.wikimedia.org/66243 (10matanya) 3NEW p:3Unprio s:3normal a:3None Hello, since the unicode normalization analyzer was installed for Hebrew some expected search results... [07:24:12] (03CR) 10Prtksxna: "Some work also needs to be done in the CSS - for example applying the font on the basis of the class instead of explicitly that I am discu" [core] - 10https://gerrit.wikimedia.org/r/137888 (https://bugzilla.wikimedia.org/66138) (owner: 10Prtksxna) [07:28:17] (03PS1) 10Hashar: mwext-Mantle-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/137890 (https://bugzilla.wikimedia.org/66014) [07:28:31] (03CR) 10Hashar: [C: 032] mwext-Mantle-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/137890 (https://bugzilla.wikimedia.org/66014) (owner: 10Hashar) [07:28:40] (03Merged) 10jenkins-bot: mwext-Mantle-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/137890 (https://bugzilla.wikimedia.org/66014) (owner: 10Hashar) [07:29:45] 3MediaWiki extensions / 3Mantle: Mantle should pass jshint - 10https://bugzilla.wikimedia.org/66014#c9 (10Antoine "hashar" Musso) 5PATC>3RESO/FIX And Zuul is making the jslint job voting. Thank you! [07:33:51] (03PS21) 10Prtksxna: Disable NavigationPopups (Gadget) if Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (https://bugzilla.wikimedia.org/62952) [07:33:56] (03CR) 10jenkins-bot: [V: 04-1] Disable NavigationPopups (Gadget) if Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (https://bugzilla.wikimedia.org/62952) (owner: 10Prtksxna) [07:34:56] (03PS22) 10Prtksxna: Disable NavigationPopups (Gadget) if Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (https://bugzilla.wikimedia.org/62952) [07:51:58] 3Analytics / 3Tech community metrics: Gerrit metrics about open changesets should ignore -1s - 10https://bugzilla.wikimedia.org/63533#c16 (10Alvaro) 5ASSI>3PATC All fixed now in korma: http://korma.wmflabs.org/browser/gerrit_review_queue.html [07:57:43] (03CR) 10Paladox: "hi so I would do something like this" [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/134624 (owner: 10Paladox) [08:03:47] (03CR) 10Aude: [C: 031] Remove obsolete RC_MOVE and RC_MOVE_OVER_REDIRECT rc types [extensions/SimpleChanges] - 10https://gerrit.wikimedia.org/r/137887 (owner: 10devunt) [08:10:15] 3MediaWiki extensions / 3WikibaseQueryEngine: Add DVHandler for Time values - 10https://bugzilla.wikimedia.org/63476 (10tobias.gritschacher) 5PATC>3RESO/FIX [08:15:59] 3Wikimedia / 3Site requests: Users who are blocked on enwiki from emailing should, when they try to use Special:EmailUser/Ban_Appeals_Subcommittee, receive a message advising them to email arbcom-appeals-en@lists.wikimedia.org - 10https://bugzilla.wikimedia.org/66239#c1 (10Tomasz W. Kozlowski) 5NEW>3RESO/... [08:29:16] (03PS1) 10Hashar: jshint: use '===' to compare with '' [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/137894 [08:29:32] (03PS3) 10Hashar: Version 2.2: RequestContext love, spacing tweaks + position => top for CSS RL modules. [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/137170 (owner: 10Jack Phoenix) [08:30:27] (03CR) 10Hashar: "Rebased on top of https://gerrit.wikimedia.org/r/#/c/137894/ which fix the jshint errors 8-)" [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/137170 (owner: 10Jack Phoenix) [08:34:02] (03CR) 10Nuria: "What is the deployment timeframe of changes like these?" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/137810 (owner: 10Ori.livneh) [08:39:02] (03PS1) 10Prtksxna: renderer: Use NavigationPopups settings where available [extensions/Popups] - 10https://gerrit.wikimedia.org/r/137897 (https://bugzilla.wikimedia.org/64234) [08:39:07] (03CR) 10jenkins-bot: [V: 04-1] renderer: Use NavigationPopups settings where available [extensions/Popups] - 10https://gerrit.wikimedia.org/r/137897 (https://bugzilla.wikimedia.org/64234) (owner: 10Prtksxna) [08:41:47] (03PS2) 10Prtksxna: renderer: Use NavigationPopups settings where available [extensions/Popups] - 10https://gerrit.wikimedia.org/r/137897 (https://bugzilla.wikimedia.org/64234) [08:41:53] (03CR) 10jenkins-bot: [V: 04-1] renderer: Use NavigationPopups settings where available [extensions/Popups] - 10https://gerrit.wikimedia.org/r/137897 (https://bugzilla.wikimedia.org/64234) (owner: 10Prtksxna) [08:45:07] (03PS3) 10Prtksxna: renderer: Use NavigationPopups settings where available [extensions/Popups] - 10https://gerrit.wikimedia.org/r/137897 (https://bugzilla.wikimedia.org/64234) [08:46:59] 3MediaWiki / 3General/Unknown: Integrate Wikifont into Core/Extension - 10https://bugzilla.wikimedia.org/66138#c4 (10Santhosh Thottingal) Is there a guideline/documentation about how to use this in RTL context? [08:48:15] (03CR) 10Santhosh: [C: 04-1] "I reported some issues at Upstream" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/137888 (https://bugzilla.wikimedia.org/66138) (owner: 10Prtksxna) [09:07:20] Hm.. anyone around to help with a localisation cache / magic word / CategoryTree problem in 1.23.0? [09:07:29] http://finanpedia.nl/wiki/Speciaal:Version [09:07:57] CategoryTree has this messed up system where it registers its magic word from the setup function [09:08:07] Which apparently is not called early enough [09:08:18] I can't reproduce it on clean REL1_23 of master and CategoryTree locally [09:08:43] It works when I move [09:08:44] 192: $wgExtensionMessagesFiles['CategoryTreeMagic'] = __DIR__ . '/CategoryTree.i18n.magic.php'; [09:08:51] to higher up in the extension file [09:09:06] Exception from line 318 of /home/deb30684n2/domains/finanpedia.nl/public_html/mw/includes/MagicWord.php: Error: invalid magic word 'categorytree' [09:11:16] Nikerabbit: Reedy: Any idea? [09:14:16] 3MediaWiki extensions / 3WikidataRepo: UI for Simple Query - 10https://bugzilla.wikimedia.org/55593 (10tobias.gritschacher) 5PATC>3RESO/FIX [09:16:02] Didn't we have this problem on the cluster before? [09:16:15] I tried clearing all kinds of caches [09:19:02] Krinkle: including rebuildLocalisationCache.php --force? [09:19:19] Nikerabbit: I can't run maintenance scripts on that wiki [09:19:28] afaik it doesn't use any fancy localisation cache [09:19:44] I just have wgCacheDir and useLocalisationCache=true and I cleared the cache dir [09:20:14] isn't that fancy then :) the default is to store it in the database [09:21:37] maintenance script could avoid whatever it is that triggers creation of localisation cache too early during web request [09:21:43] Which is cleared on update.php which is run by the upgrade GUI [09:21:57] Hm. I'll give that another try [09:22:53] Ran mw-config updater [09:22:58] still same exception [09:24:22] hmph [09:25:32] Move it higher up the file, commit and backport? [09:25:55] Reedy: not just higher up [09:26:02] https://github.com/wikimedia/mediawiki-extensions-CategoryTree/blob/master/CategoryTree.php#L192 [09:26:11] basically moving it out of the condition and out of the setup function [09:26:20] into global scope next to where we register other i18n [09:31:20] Oh [09:31:44] Done that for now in a local hack [09:32:07] https://github.com/wikimedia/mediawiki-extensions-CategoryTree/commit/7f440c3f728d29ab3fd76b655862c14e0d219438 [09:32:15] 3MediaWiki extensions / 3WikidataRepo: Install default gadgets from wikidata.org on the test system (beta) - 10https://bugzilla.wikimedia.org/64998#c7 (10tobias.gritschacher) Ok, the CommonsGadget widget issue is resolved by now. We figured out that commons.wikimedia.beta.wmflabs.org is set up as a media rep... [09:32:19] https://gerrit.wikimedia.org/r/#/c/121570/ [09:32:35] "Though, is there any reason we don't just loads this always?" [09:32:51] I'd move it [09:33:29] 3MediaWiki extensions / 3WikidataRepo: Install default gadgets from wikidata.org on the test system (beta) - 10https://bugzilla.wikimedia.org/64998#c8 (10tobias.gritschacher) To resolve the issue with the AuthorityControl gadget, I'll import the gadget manually for now and adapt it to work on beta. That's no... [09:44:05] (03PS1) 10Krinkle: Register CategoryTreeMagic from global scope instead of setup [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/137903 [09:44:26] Reedy: [09:45:03] (03PS2) 10Krinkle: Register CategoryTreeMagic from global scope instead of setup [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/137903 [09:45:08] (added follows-up I32357244c013a2370f14f) [09:49:29] 3MediaWiki extensions / 3Translate: [Pagemigration] Icons should have hover text - 10https://bugzilla.wikimedia.org/65961 (10Niklas Laxström) 5PATC>3RESO/FIX [09:51:32] (03CR) 10Nikerabbit: [C: 032] Register CategoryTreeMagic from global scope instead of setup [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/137903 (owner: 10Krinkle) [09:51:36] (03Merged) 10jenkins-bot: Register CategoryTreeMagic from global scope instead of setup [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/137903 (owner: 10Krinkle) [09:51:46] (03PS1) 10Krinkle: Register CategoryTreeMagic from global scope instead of setup [extensions/CategoryTree] (REL1_23) - 10https://gerrit.wikimedia.org/r/137905 [09:51:53] (03CR) 10Krinkle: [C: 032] Register CategoryTreeMagic from global scope instead of setup [extensions/CategoryTree] (REL1_23) - 10https://gerrit.wikimedia.org/r/137905 (owner: 10Krinkle) [09:51:55] (03PS2) 10Krinkle: Register CategoryTreeMagic from global scope instead of setup [extensions/CategoryTree] (REL1_23) - 10https://gerrit.wikimedia.org/r/137905 [09:52:17] (03CR) 10Krinkle: [C: 032] Register CategoryTreeMagic from global scope instead of setup [extensions/CategoryTree] (REL1_23) - 10https://gerrit.wikimedia.org/r/137905 (owner: 10Krinkle) [09:52:21] (03Merged) 10jenkins-bot: Register CategoryTreeMagic from global scope instead of setup [extensions/CategoryTree] (REL1_23) - 10https://gerrit.wikimedia.org/r/137905 (owner: 10Krinkle) [09:52:58] (03PS1) 10Ori.livneh: Cache jsonschema.Draft3Validator objects rather than just schema [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/137906 [09:52:58] 3MediaWiki / 3Recent changes: Log actions should support bot flag (e.g. to hide from Special:RecentChanges) - 10https://bugzilla.wikimedia.org/16816#c7 (10Andre Klapper) charitwo: Do you plan to work on a patch (or are you aware of somebody working on a patch), or why did you set the Target Milestone to 1.24? [09:54:13] (03CR) 10jenkins-bot: [V: 04-1] Cache jsonschema.Draft3Validator objects rather than just schema [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/137906 (owner: 10Ori.livneh) [09:56:44] 3MediaWiki / 3Skin and page rendering: https/secure link icon does not use asset from Wikifont - 10https://bugzilla.wikimedia.org/66219 (10Andre Klapper) p:5Unprio>3Normal [09:56:45] 3MediaWiki / 3Skin and page rendering: External link Icon does not use asset from Wikifont - 10https://bugzilla.wikimedia.org/66218 (10Andre Klapper) p:5Unprio>3Normal [09:57:24] (03PS4) 1001tonythomas: Added swiftmailer 5.2.0 from Wikimedia Fork [core/vendor] - 10https://gerrit.wikimedia.org/r/137538 [09:57:29] 3MediaWiki extensions / 3CirrusSearch: Regression: using unicode normalization analyzer misses results in search - 10https://bugzilla.wikimedia.org/66243 (10Andre Klapper) [09:57:39] (03PS5) 1001tonythomas: Added swiftmailer 5.2.0 from Wikimedia Fork [core/vendor] - 10https://gerrit.wikimedia.org/r/137538 [09:59:51] (03PS1) 10Gilles: Fix jquery.client dependencies [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/137907 [10:01:13] 3MediaWiki / 3Watchlist: Add option to not add pages I revert to my watchlist - 10https://bugzilla.wikimedia.org/66215 (10Andre Klapper) p:5Unprio>3Low [10:04:50] (03PS2) 10Ori.livneh: Cache jsonschema.Draft3Validator objects rather than just schema [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/137906 [10:06:28] (03CR) 10Ori.livneh: [C: 032] "tested on vanadium" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/137906 (owner: 10Ori.livneh) [10:07:48] (03Merged) 10jenkins-bot: Cache jsonschema.Draft3Validator objects rather than just schema [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/137906 (owner: 10Ori.livneh) [10:12:16] (03CR) 10TheDJ: [C: 032] Disable NavigationPopups (Gadget) if Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (https://bugzilla.wikimedia.org/62952) (owner: 10Prtksxna) [10:12:25] (03Merged) 10jenkins-bot: Disable NavigationPopups (Gadget) if Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (https://bugzilla.wikimedia.org/62952) (owner: 10Prtksxna) [10:15:17] 3Wikimedia / 3General/Unknown: deleted page schows as a blue link - 10https://bugzilla.wikimedia.org/66248 (10Steinsplitter) 3NEW p:3Unprio s:3normal a:3None For some reason, User talk:Dralwik showed up in new page patrol as a gallery, see https://commons.wikimedia.org/w/index.php?title=Special%3ANew... [10:18:01] 3Wikimedia / 3Bugzilla: Bugzilla component for "ActivityMonitor" - 10https://bugzilla.wikimedia.org/66249 (10Andre Klapper) 3NEW p:3Unprio s:3normal a:3Krinkle Krinkle: You created a Bugzilla component called "ActivityMonitor". For future reference, whenever creating a component, please always creat... [10:19:15] 3Wikimedia / 3Bugzilla: Create Bugzilla component for RCStream - 10https://bugzilla.wikimedia.org/66170 (10Krinkle) [10:19:15] 3Wikimedia / 3Bugzilla: Bugzilla component for "ActivityMonitor" - 10https://bugzilla.wikimedia.org/66249 (10Krinkle) [10:19:58] 3MediaWiki / 3General/Unknown: deleted page schows as a blue link - 10https://bugzilla.wikimedia.org/66248 (10Steinsplitter) [10:20:14] 3MediaWiki / 3General/Unknown: deleted page schows as a blue link - 10https://bugzilla.wikimedia.org/66248 (10Steinsplitter) [10:23:55] (03PS29) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [10:26:08] (03CR) 10jenkins-bot: [V: 04-1] First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [10:32:01] 3MediaWiki extensions / 3Translate: Fix code styling and architecture issues for Special:PageMigration - 10https://bugzilla.wikimedia.org/65738#c8 (10Nemo) 5PATC>3NEW a:5Pratik Lahoti>3None Anything else to do? [10:32:29] 3MediaWiki extensions / 3WikidataRepo: Install default gadgets from wikidata.org on the test system (beta) - 10https://bugzilla.wikimedia.org/64998#c9 (10tobias.gritschacher) I've created a copy of the AuthorityControl gadget from wikidata.org with reduced number of properties and adjusted property ids for t... [10:35:07] (03PS30) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [10:48:47] (03PS7) 10Phuedx: Make ResourceLoaderFileModule#getAllStyleFiles include all skin styles [core] - 10https://gerrit.wikimedia.org/r/122838 (https://bugzilla.wikimedia.org/63343) [10:52:00] 3MediaWiki extensions / 3WikidataRepo: Create browsertests for AuthorityControl gadget on beta - 10https://bugzilla.wikimedia.org/66251 (10tobias.gritschacher) p:5Unprio>3High [10:52:00] 3MediaWiki extensions / 3WikidataRepo: Create browsertests for AuthorityControl gadget on beta - 10https://bugzilla.wikimedia.org/66251 (10tobias.gritschacher) [10:52:45] 3MediaWiki extensions / 3WikidataRepo: Create browsertests for Search gadget on beta - 10https://bugzilla.wikimedia.org/66252 (10tobias.gritschacher) p:5Unprio>3High [10:53:45] 3MediaWiki extensions / 3WikidataRepo: Create browsertests for CommonsMedia gadget on beta - 10https://bugzilla.wikimedia.org/66253 (10tobias.gritschacher) p:5Unprio>3High [10:55:16] 3MediaWiki extensions / 3WikidataRepo: Create browsertests for CommonsMedia gadget on beta - 10https://bugzilla.wikimedia.org/66253 (10tobias.gritschacher) [10:55:17] 3MediaWiki extensions / 3WikidataRepo: Create browsertests for Search gadget on beta - 10https://bugzilla.wikimedia.org/66252 (10tobias.gritschacher) [10:55:17] 3MediaWiki extensions / 3WikidataRepo: Create browsertests for AuthorityControl gadget on beta - 10https://bugzilla.wikimedia.org/66251 (10tobias.gritschacher) [10:55:17] 3MediaWiki extensions / 3WikidataRepo: Create tests for default gadgets (tracking) - 10https://bugzilla.wikimedia.org/65257 (10tobias.gritschacher) [10:55:30] 3MediaWiki extensions / 3WikidataRepo: Create browsertests for AuthorityControl gadget on beta - 10https://bugzilla.wikimedia.org/66251 (10tobias.gritschacher) [10:55:44] 3MediaWiki extensions / 3WikidataRepo: Create browsertests for CommonsMedia gadget on beta - 10https://bugzilla.wikimedia.org/66253 (10tobias.gritschacher) [10:55:45] 3MediaWiki extensions / 3WikidataRepo: Create browsertests for Search gadget on beta - 10https://bugzilla.wikimedia.org/66252 (10tobias.gritschacher) [10:59:46] 3MediaWiki extensions / 3SemanticDrilldown: Deprecated: Use of wfMsg, wfMsgReal, wfMsgGetKey was deprecated in MediaWiki 1.21 - and some other debug output - 10https://bugzilla.wikimedia.org/66254 (10Joel K. Pettersson) 3UNCO p:3Unprio s:3normal a:3Yaron Koren Enabling the debug toolbar, I get the fo... [11:00:48] (03CR) 10SPQRobin: First version of Page Language selector (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [11:03:38] (03CR) 10Kunalgrover05: First version of Page Language selector (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [11:05:47] (03PS31) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [11:10:20] (03CR) 10Phuedx: [C: 032] "Looks good to me. I tested the change in Chrome (35.0.1916.114), Firefox (29.0.1), and Safari (7.0.4)." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/136975 (https://bugzilla.wikimedia.org/65923) (owner: 10Prtksxna) [11:10:25] (03Merged) 10jenkins-bot: animation: Use the animation mixin in core and pass fill-mode as an argument [extensions/Popups] - 10https://gerrit.wikimedia.org/r/136975 (https://bugzilla.wikimedia.org/65923) (owner: 10Prtksxna) [11:12:00] 3MediaWiki extensions / 3WikidataRepo: Install default gadgets from wikidata.org on the test system (beta) - 10https://bugzilla.wikimedia.org/64998#c10 (10tobias.gritschacher) 5PATC>3RESO/FIX The Search gadget seems to work but for some reason the arrow symbol is missing. But this should not be no blocke... [11:12:43] (03PS32) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [11:21:20] (03CR) 10Phuedx: "Krinkle: Certainly ResourceLoaderFileModule#getStyleFiles does. However, #getAllStyleFiles only ever returns values from the styles proper" [core] - 10https://gerrit.wikimedia.org/r/122838 (https://bugzilla.wikimedia.org/63343) (owner: 10Phuedx) [11:23:05] (03CR) 10Krinkle: "I'm not saying getAllStyleFiles is already working fine. I'm saying getAllStyleFiles already returns files for "all skins" (though only fr" [core] - 10https://gerrit.wikimedia.org/r/122838 (https://bugzilla.wikimedia.org/63343) (owner: 10Phuedx) [11:24:01] ^ Krinkle: mibad, i misunderstood your comment [11:40:11] (03PS8) 10Phuedx: Make ResourceLoaderFileModule#getAllStyleFiles include all skin styles [core] - 10https://gerrit.wikimedia.org/r/122838 (https://bugzilla.wikimedia.org/63343) [11:47:19] (03PS3) 10Umherirrender: Some phpcs-strict changes on includes/revisiondelete/ [core] - 10https://gerrit.wikimedia.org/r/137727 [12:08:13] (03PS1) 10Kunalgrover05: Patch to load language for DB [core] - 10https://gerrit.wikimedia.org/r/137915 [12:10:14] (03CR) 10TTO: "Nemo: I'm sorry if I seemed a bit snarky before; I was very busy. Thanks for looking through these patches, your feedback is as always mos" [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105143 (owner: 10TTO) [12:11:59] (03CR) 10Nemo bis: "Nothing to be sorry about. :) I just realised I didn't know enough about this extension. :)" [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105143 (owner: 10TTO) [12:16:34] (03PS1) 10Joerg: Fatal error: Unsupported operand types in Collection.body.php [extensions/Collection] (REL1_23) - 10https://gerrit.wikimedia.org/r/137917 (https://bugzilla.wikimedia.org/60538) [12:17:49] (03CR) 10Joerg: [C: 031] "Fix #60538 in the REL1_23 branch as well." [extensions/Collection] (REL1_23) - 10https://gerrit.wikimedia.org/r/137917 (https://bugzilla.wikimedia.org/60538) (owner: 10Joerg) [12:23:15] 3Wikimedia / 3Site requests: Deploy TemplateData's GUI editing tool to all wikis - 10https://bugzilla.wikimedia.org/60158 (10Helder) [12:23:17] 3Wikimedia / 3Site requests: Deploy TemplateData's GUI editing tool to Portuguese Wikipedia - 10https://bugzilla.wikimedia.org/66255 (10Helder) 3NEW p:3Unprio s:3normal a:3None Please enable the TemplateData editor on Portuguese Wikipedia (ptwiki). This had no opposition in the discussion linked above. [12:58:44] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: I suspect that Cirrus isn't properly handling when a page is converted to and from a redirect - 10https://bugzilla.wikimedia.org/61211 (10Nik Everett) p:5Normal>3High [12:59:29] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: I suspect that Cirrus isn't properly handling when a page is converted to and from a redirect - 10https://bugzilla.wikimedia.org/61211#c1 (10Nik Everett) Not only do we have to detect when the change happens but we have to sweep away entries for things tha... [13:00:14] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Not properly handling when a page is converted to and from a redirect - 10https://bugzilla.wikimedia.org/61211 (10Nik Everett) [13:23:13] (03CR) 10Anomie: "> This is a good idea anyway, but FWIW the core bug has been fixed by @Ieb2cb05aee07a1d8bbdc3bdfe9536dfa8bee529e." [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/137641 (https://bugzilla.wikimedia.org/66141) (owner: 10Anomie) [13:31:31] (03CR) 10Ragesoss: "I'm trying to test this locally on vagrant, but I can't get it to work. Pasting the urls, either with or without the forwarded port, just " [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/134598 (https://bugzilla.wikimedia.org/44397) (owner: 10Jlloyd) [13:37:11] (03PS33) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [13:49:40] (03CR) 10Ragesoss: "This works as expected. One useful improvement in the future will be to group these events (like the base Echo functionality does with som" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/118101 (https://bugzilla.wikimedia.org/56325) (owner: 10Jlloyd) [13:52:16] (03CR) 10Phuedx: [C: 031] "LGTM. Over to you Siebrand." [core] - 10https://gerrit.wikimedia.org/r/137475 (owner: 10Mattflaschen) [13:56:20] (03PS1) 10Jack Phoenix: No more $wgTitle. [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/137928 [13:57:00] (03CR) 10Jack Phoenix: [C: 032 V: 032] No more $wgTitle. [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/137928 (owner: 10Jack Phoenix) [14:01:44] 3Wikimedia / 3General/Unknown: support SPDY protocol - 10https://bugzilla.wikimedia.org/33890#c31 (10Faidon Liambotis) That's good news indeed. Of course that 67% figure is bogus, as it assumes SPDY is one protocol, while there are four versions available and browsers & servers each support a different comb... [14:08:19] (03PS2) 10Jack Phoenix: Switch i18n file to JSON format [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/137312 (owner: 10Raimond Spekking) [14:09:05] (03CR) 10Jack Phoenix: [C: 032 V: 032] Switch i18n file to JSON format [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/137312 (owner: 10Raimond Spekking) [14:10:31] 3MediaWiki extensions / 3WikidataRepo: EntitySelector not working on MainPage (e.g. for search box) - 10https://bugzilla.wikimedia.org/66257 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs The entity selector does currently not work on the main page. when e.g. typing in the search b... [14:10:45] 3MediaWiki extensions / 3WikidataRepo: EntitySelector not working on MainPage (e.g. for search box) - 10https://bugzilla.wikimedia.org/66257 (10tobias.gritschacher) p:5Unprio>3Highes s:5normal>3critic [14:25:44] 3MediaWiki / 3Page deletion: deleted page shows as a blue link - 10https://bugzilla.wikimedia.org/66248 (10Andre Klapper) p:5Unprio>3Normal [14:28:27] (03PS1) 10Yuvipanda: Apply Mobile App edit tag only to edits [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/137930 [14:30:38] jackmcbarn: Care to update https://www.mediawiki.org/wiki/API:Expandtemplates with the changes from https://gerrit.wikimedia.org/r/#/c/136799/ ? [14:31:01] anomie: kk [14:31:24] anomie: btw, rather than my unstrip idea, i found a way to fix cite with transparent tags. it works just like parsoid's with it [14:31:33] (03PS3) 10Manybubbles: Insource support [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/137733 (https://bugzilla.wikimedia.org/65783) [14:32:45] (03CR) 10Manybubbles: [C: 04-1] "-1 until we get better error handling - right now syntax errors are reported as "temporary problems" as though search were down or somethi" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/137733 (https://bugzilla.wikimedia.org/65783) (owner: 10Manybubbles) [14:33:43] (03PS4) 10Manybubbles: Insource support [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/137733 (https://bugzilla.wikimedia.org/65783) [14:35:49] (03PS1) 10Jack Phoenix: Fix DPLforum b0rkage. [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/137931 [14:35:50] jackmcbarn: I think Cite predates transparent tags which explains why it never used them. I bet there's some old bugs you fixed too, like the "subst and other PST doesn't work inside " issue. The only caveat would be to make sure nothing interesting breaks from the change. I'd also be a bit surprised if it works "just like parsoid's", although besides doing it with a second parser after the real parser for "no side effects" I'm not aware of h [14:35:50] ow parsoid's currently differs. [14:39:33] (03PS1) 10Hashar: Let us manage disable manually [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/137933 [14:40:31] (03CR) 10GreenReaper: [C: 031] "Doesn't fall over here." [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/137931 (owner: 10Jack Phoenix) [15:02:59] 3MediaWiki / 3Watchlist: Clearing large (39k+) watchlist @ Special:EditWatchlist/clear fails, HTTP error 503 - 10https://bugzilla.wikimedia.org/66212#c3 (10UP) Would it be possible to make a .js action thingy (to use on personal .js files) for the /clear page that removes, say, the first 2500 lines of the li... [15:10:29] 3Analytics / 3Tech community metrics: Gerrit metrics about open changesets should ignore -1s - 10https://bugzilla.wikimedia.org/63533#c17 (10Quim Gil) 5PATC>3RESO/FIX Yep, thank you! [15:10:30] (03PS16) 10Gilles: Generate thumbnails based on buckets [core] - 10https://gerrit.wikimedia.org/r/135008 [15:10:42] (03CR) 10Gilles: Generate thumbnails based on buckets (035 comments) [core] - 10https://gerrit.wikimedia.org/r/135008 (owner: 10Gilles) [15:10:48] (03CR) 10Gilles: Generate thumbnails based on buckets (032 comments) [core] - 10https://gerrit.wikimedia.org/r/135008 (owner: 10Gilles) [15:14:29] (03CR) 10jenkins-bot: [V: 04-1] Generate thumbnails based on buckets [core] - 10https://gerrit.wikimedia.org/r/135008 (owner: 10Gilles) [15:14:50] (03CR) 10Siebrand: [C: 032] "Thank you!" [core] - 10https://gerrit.wikimedia.org/r/137475 (owner: 10Mattflaschen) [15:15:50] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/118101 (https://bugzilla.wikimedia.org/56325) (owner: 10Jlloyd) [15:16:41] (03CR) 10Physikerwelt: SpecialPage for MathImages (036 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/137815 (owner: 10Physikerwelt) [15:16:44] 3MediaWiki / 3Watchlist: Clearing large (39k+) watchlist @ Special:EditWatchlist/clear fails, HTTP error 503 - 10https://bugzilla.wikimedia.org/66212#c4 (10Andre Klapper) What exactly is the difference to bug 39510? [15:18:01] 3Analytics / 3Tech community metrics: Regression: popup windows go beyond right margin, hiding most recent data - 10https://bugzilla.wikimedia.org/66258 (10Quim Gil) 3NEW p:3Unprio s:3major a:3None 1. Go to e.g. http://korma.wmflabs.org/browser/gerrit_review_queue.html with the default font size of y... [15:18:13] (03Merged) 10jenkins-bot: Update outdated signup page-related message documentation [core] - 10https://gerrit.wikimedia.org/r/137475 (owner: 10Mattflaschen) [15:18:14] 3Analytics / 3Tech community metrics: Regression: popup windows go beyond right margin, hiding most recent data - 10https://bugzilla.wikimedia.org/66258 (10Quim Gil) p:5Unprio>3High [15:19:28] (03PS17) 10Gilles: Generate thumbnails based on buckets [core] - 10https://gerrit.wikimedia.org/r/135008 [15:19:31] (03PS2) 10Physikerwelt: SpecialPage for MathImages [extensions/Math] - 10https://gerrit.wikimedia.org/r/137815 [15:26:41] (03CR) 10Siebrand: [C: 04-1] "Quick review." (036 comments) [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [15:28:20] (03PS5) 10Physikerwelt: Separate render and getHtml [extensions/Math] - 10https://gerrit.wikimedia.org/r/137808 [15:28:52] (03PS6) 10Physikerwelt: Separate render and getHtml [extensions/Math] - 10https://gerrit.wikimedia.org/r/137808 [15:32:44] (03PS7) 10Physikerwelt: Separate render and getHtml [extensions/Math] - 10https://gerrit.wikimedia.org/r/137808 [15:33:20] (03CR) 10Siebrand: [C: 04-1] "L10n reviewed." (031 comment) [extensions/WebCache] - 10https://gerrit.wikimedia.org/r/137518 (owner: 10Iowajason) [15:35:54] (03CR) 10Physikerwelt: Separate render and getHtml (033 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/137808 (owner: 10Physikerwelt) [15:37:14] 3MediaWiki / 3Skin and page rendering: Vector: Page actions in dropdown menu should expand if space allows - 10https://bugzilla.wikimedia.org/22986#c13 (10Quiddity) (In reply to Derk-Jan Hartman from comment #11) > it would probably also help if the actions menu was more self explainable. > Either by a label... [15:37:44] 3MediaWiki extensions / 3Scribunto: Scribunto should support global module invocations - 10https://bugzilla.wikimedia.org/39610#c9 (10Rical) To support this evolution, the Module:ControlArgs can adapt any module for international use i18n in argument names, error messages, wikitext and categories. p... [15:37:47] (03CR) 10Frédéric Wang: [C: 032] SpecialPage for MathImages [extensions/Math] - 10https://gerrit.wikimedia.org/r/137815 (owner: 10Physikerwelt) [15:38:29] 3MediaWiki extensions / 3Scribunto: Scribunto should support global module invocations - 10https://bugzilla.wikimedia.org/39610#c10 (10Rical) See also in live demo (in debug phase): https://fr.wikisource.org/wiki/Module:ControlArgs [15:39:58] anomie: ping re gerrit:124620 [15:40:45] (03CR) 10Anomie: [C: 032] "Ok, let's do this so it can get some testing in Beta Labs." [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/124620 (owner: 10Jackmcbarn) [15:40:53] (03Merged) 10jenkins-bot: Allow calling #expr from Lua without the parser [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/124620 (owner: 10Jackmcbarn) [15:41:51] (03CR) 10Frédéric Wang: "Do you plan to split the patch or should I review that one?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/137808 (owner: 10Physikerwelt) [15:42:31] 3MediaWiki extensions / 3CirrusSearch: Valid Page name resulting in backend search error - 10https://bugzilla.wikimedia.org/66259 (10Adam Hyland) 3NEW p:3Unprio s:3normal a:3None Searching for "Wikipedia talk:Articles for creation/2012: A Year Of No Significance ... Colonial Penetrations in the First... [15:44:51] (03CR) 10Nuria: "Nice, thanks for doing these changes." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/137906 (owner: 10Ori.livneh) [15:45:09] (03PS17) 10Nuria: Move event serialization to separate method and add tests [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/133668 (owner: 10Ori.livneh) [15:45:59] 3MediaWiki extensions / 3CirrusSearch: Valid Page name resulting in backend search error - 10https://bugzilla.wikimedia.org/66259#c1 (10Adam Hyland) Sorry, that's https://en.wikipedia.org/wiki/Wikipedia_talk:Articles_for_creation/2012:_A_Year_Of_No_Significance_..._Colonial_Penetrations_in_the_First_World_-_... [15:47:47] PHP question: are fields(attributes) of a given object always remain in the same order? If I unset an attribute and add it with $obj->$field, will it always go at the end and remain in place? [15:48:31] (03CR) 10Zfilipin: [C: 032] Let us manage disable manually [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/137933 (owner: 10Hashar) [15:49:52] (03Merged) 10jenkins-bot: Let us manage disable manually [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/137933 (owner: 10Hashar) [15:50:34] sumanah, andre__ just a heads up about our quarterly review [15:50:43] have you seen the slides? [15:50:52] I haven't looked yet, I can look now [15:51:05] sumanah, there is one you really need to look at: [15:51:18] "A sane developer experience" [15:51:35] I hope you agree with the content. :) [15:51:40] :) [15:51:41] * sumanah looks [15:52:04] (03CR) 10Physikerwelt: "I'm currently working on splitting that one. Give me 20 minutes." [extensions/Math] - 10https://gerrit.wikimedia.org/r/137808 (owner: 10Physikerwelt) [15:52:13] It would be great if you could assimilate it and introduce it, since this might well be your main task in the next 12 months [15:52:44] qgil: Right. Can you add the link to the calendar invite? [15:52:46] andre__, the same goes for you and "One development platform" [15:52:53] or maybe you are waiting on that. [15:52:54] qgil: where would I find them? I received your email with some bullet points ~17h ago [15:53:00] I guess I should check the calendar invite too? [15:53:35] andre__, sorry for assuming Google Drive: https://docs.google.com/presentation/d/1biZ0lclFU7vbyoX1GQU34i-OhsfhTf_-O4A6SdXVvdU/edit?usp=sharing [15:53:41] (03CR) 10MaxSem: [C: 032] Apply Mobile App edit tag only to edits [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/137930 (owner: 10Yuvipanda) [15:53:45] (03Merged) 10jenkins-bot: Apply Mobile App edit tag only to edits [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/137930 (owner: 10Yuvipanda) [15:54:03] sumanah, andre__ I will send the URL to Praveena, who can edit the invite. Process! [15:54:19] Thank you qgil and thank you for making these slides. It is such a relief to have some numbers we can work off [15:54:22] qgil, thanks, ah, going to take a look now [15:54:38] "Measure" it is! :) [15:56:02] qgil: "Collaboration platform driven by software projects, open to any Wikimedia neighbors." - when you say "driven by software projects" do you mean focusing on software projects, or something else? [15:56:59] 3MediaWiki extensions / 3WikidataClient: Add links is missing in MonoBook - 10https://bugzilla.wikimedia.org/64741#c14 (10Rhadamante) Just a remark, that may be stupid, if so just discard this comment, but there is no such problem on Wikimedia commons, even under monobook. The interface might be slightly dif... [15:57:11] sumanah, I mean that we run it for software projects, and their requirements are our requirements. However, the same infrastructure can be used by non-technical projects as well e.g. LCA, HR... [15:57:46] 3MediaWiki extensions / 3Popups: Hovercards: ctrl-clicking a link, will cause Hovercard to reappear, when original tab is next seen - 10https://bugzilla.wikimedia.org/66261 (10Quiddity) 3NEW p:3Unprio s:3normal a:3None Filed per bug-repot by NicoV, which I can reproduce consistently in Firefox: Afte... [15:58:00] Got it, qgil - modified language. [15:59:26] sumanah, thanks! [16:02:26] qgil: slide 9 ("Age of unreviewed patches"): You'll probably tell us, but that list of projects with its numbers: Is that the number of days for the oldest patch? Average of all unreviewed ones for that repo? Median of all unreviewed ones for that repo? [16:02:45] Median of all unreviewed ones for that repo? [16:02:52] Median of all unreviewed ones for that repo! :) [16:03:29] andre__, yeah, I fear there is already too many details with dates and numbers and didn't want to get even more details about the data itself [16:03:44] 3Wikimedia / 3lucene-search-2: Valid Page name resulting in backend search error - 10https://bugzilla.wikimedia.org/66259#c2 (10Nik Everett) That's a notorious lsearchd error that I've spent a day or two trying to track down only to come up empty handed. Its probably caching related and probably will go awa... [16:04:59] 3Wikimedia / 3lucene-search-2: Valid Page name resulting in backend search error - 10https://bugzilla.wikimedia.org/66259#c3 (10Nik Everett) If you are sure you got the error from cirrus feel free to swap the component back. I did try it myself and got it on lsearchd and not cirrus. [16:04:59] median vs. mean... [16:05:28] (03PS5) 10Manybubbles: Insource support [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/137733 (https://bugzilla.wikimedia.org/65783) [16:06:27] I have some commits, but none of them has been reviewed for over weeks. [16:06:31] when they get the review? [16:06:41] (03PS6) 10Manybubbles: Insource support [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/137733 (https://bugzilla.wikimedia.org/65783) [16:06:46] 3MediaWiki extensions / 3Popups: Hovercards: pokey (border area) is not clickable, but pointer says it is - 10https://bugzilla.wikimedia.org/66262 (10Quiddity) 3NEW p:3Unprio s:3normal a:3None When I have a Hovercard visible, if I move the mouse-pointer over the "pokey" (triangle pointing at the link... [16:06:47] qgil: Hmm. So if all numbers on both slides are median, maybe you can add "(Median)" in some small font somewhere? I love to understand slides without listening to the person explaining them :) But feel free to disagree if it's too crowded, not a biggie [16:07:31] qgil: "Age of unresolved Bugzilla reports" is all projects including potentially unmaintained 3rd party extensions, or just WMF/deployed etc.? [16:07:37] andre__, I will find the right place and font size :) [16:08:15] andre__, all these numbers belong to Key Wikimedia Projects only. I guess I should find also a place and font size for that [16:08:21] andre__, damn engineers ;) [16:08:22] ah, alright [16:08:26] :D [16:09:54] hi devunt - you've seen https://www.mediawiki.org/wiki/Git/Code_review/Getting_reviews ? [16:11:59] sumanah, yes. my commits have passed the tests and I added reviewers. [16:12:16] devunt: and you've responded to their comments, if they've left any, right? [16:12:26] yes. [16:12:47] "Phabmaster"... I think I need to establish some ridiculous and recursive term like "PM of PM tools" to ever get out of that branding again ;) [16:13:03] and some commits have +1 cr already, but not +2'd yet. [16:13:13] haha, Phabmaster sounds awesome [16:13:17] devunt: ok, looking at https://gerrit.wikimedia.org/r/#/q/status:open+owner:%22devunt+%253Cdevunt%2540gmail.com%253E%22,n,z [16:13:21] Phabmasters also sounds like a great brand name, andre__ [16:14:10] yeah, phabulous :) [16:14:10] devunt: which of these do you think are most important? [16:14:34] (03PS8) 10Physikerwelt: Add getHtmlOutput method [extensions/Math] - 10https://gerrit.wikimedia.org/r/137808 [16:15:24] qgil: "Current quarter" and "last completed quarter" have the same months, is that intended? [16:16:16] (03CR) 10Physikerwelt: "Voila. The good news is that this change is not critical." [extensions/Math] - 10https://gerrit.wikimedia.org/r/137808 (owner: 10Physikerwelt) [16:16:34] sumanah, most of them, i think. [16:16:43] except -1 commits. [16:17:39] devunt: I mean, out of the ~10 changes you have awaiting review, which of them do you think will have the most positive impact on our readers and contributors? [16:18:43] ah, it's https://gerrit.wikimedia.org/r/#/c/135000/ and https://gerrit.wikimedia.org/r/#/c/136290/ [16:22:57] devunt: have you also been reviewing code, giving +1 and -1 ? [16:22:58] :) [16:24:11] (other people's changes, I mean.) [16:24:33] devunt: got it. I've looked at those and asked a couple of people to review - people who have +2 powers and who often review code in those areas. If you haven't had those changes reviewed in ~3 more days, maybe clarify the commit messages to make it clear why these are particularly important changes to make [16:25:00] well ok [16:25:44] (03PS1) 10Manybubbles: Default to larger snippets [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/137952 [16:26:07] sumanah, nope :( [16:26:38] devunt: why not? it'd be helpful to others to see your comments, and it would help you get your code reviewed [16:28:59] 3MediaWiki / 3User blocking: Block messages should be customizable depending on the attempted action - 10https://bugzilla.wikimedia.org/66239#c2 (10Jackmcbarn) 5RESO/WON>3REOP MediaWiki doesn't currently support doing this. I've repurposed the bug to request that support be added. [16:30:24] sumanah, Is my review helpful for other people? [16:30:29] yes [16:34:37] I thought reviews from wmf-related person is mostly helpful, not other contributors. [16:35:20] devunt: Can you tell me more about why you thought that? [16:36:16] We do explicitly want reviews from all developers; different people have different perspectives. For instance, non-WMF people are more likely to think about the specific needs of small wikis with part-time sysadmins and different usage patterns. [16:37:54] they are more trustworthy [16:37:58] and more know about mediawiki mechanics. [16:38:02] Many eyes make bugs shallow. you'll learn, gain reputation, and get people to return the favor by reviewing you in the future. [16:38:24] But we have had many bugs caught in the past by non-WMF people, like PleaseStand [16:39:02] And a good way to learn more about MediaWiki mechanics is to start reviewing code - you will learn and get better as you try [16:39:05] Here's a guide: https://www.mediawiki.org/wiki/Gerrit/Code_review [16:45:31] sumanah, and another reason of not reviewing is english. [16:45:34] I'm difficult to describe my opinion in english. [16:46:39] and realtime conversation like irc is more difficult :p [16:47:04] much difficult [16:47:23] devunt, you're doing great! (says another non-native English speaker) [16:48:55] thank you [16:50:59] 3MediaWiki / 3Watchlist: Clearing large (39k+) watchlist @ Special:EditWatchlist/clear fails, HTTP error 503 - 10https://bugzilla.wikimedia.org/66212#c5 (10UP) @Andre Klapper, #39510 is about editing the watchlist, this is about clearing it. Those are two different tools. (Three actually but it seems origina... [16:51:12] well, the last reason is the time zone... [16:51:32] in my time zone, it's 2 a.m. now. [16:52:21] most code review is wildly async [16:52:57] just look at the code which interests you and don't worry too much about what people think of your questions/comments as long as you think you're learning something [16:53:14] 3MediaWiki / 3Watchlist: Clearing large (39k+) watchlist @ Special:EditWatchlist/clear fails, HTTP error 503 - 10https://bugzilla.wikimedia.org/66212#c6 (10Jesús Martínez Novo (Ciencia Al Poder)) 5UNCO>3NEW (In reply to UP from comment #3) > Would it be possible to make a .js action thingy (to use on per... [16:53:46] (03CR) 10Frédéric Wang: "It looks like there are many whitespace-only changes..." (035 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/137808 (owner: 10Physikerwelt) [16:55:00] 3Wikimedia / 3lucene-search-2: Valid Page name resulting in backend search error - 10https://bugzilla.wikimedia.org/66259#c4 (10Adam Hyland) Hey Nik, I'm indeed not sure I got it from Cirrus. Until I convince myself otherwise I'll stick with that change. As some additional info, it appears that searching f... [16:56:26] well ok. I'll try. [16:56:27] thank you for advices. [16:58:14] 3Wikimedia / 3lucene-search-2: Valid Page name resulting in backend search error - 10https://bugzilla.wikimedia.org/66259#c5 (10Nik Everett) When I've seen these in the past they were based on the search finding a certain results not the query itself. I could find the code actually throwing the exception bu... [17:04:45] (03PS34) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [17:08:32] (03PS35) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [17:13:39] (03PS36) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [17:15:58] (03PS1) 10Umherirrender: Move api files to a new api folder [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/137955 [17:27:29] 3Wikimedia / 3lucene-search-2: Valid Page name resulting in backend search error - 10https://bugzilla.wikimedia.org/66259#c6 (10Adam Hyland) > Unfortunately, I'd suggest checking back in a week and seeing if its still broken. Can do. Dumb question, if I set up a local install on a VM, how would I get at t... [17:34:44] (03PS1) 10SG: Implement flow-api-handler data attribute [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137957 [17:34:44] 3Wikimedia / 3lucene-search-2: Valid Page name resulting in backend search error - 10https://bugzilla.wikimedia.org/66259#c7 (10Nik Everett) (In reply to Adam Hyland from comment #6) > Dumb question, if I set up a local install on a VM, how would I get at the > lucerne errors getting dumped out? Setting up... [17:34:48] (03CR) 10jenkins-bot: [V: 04-1] Implement flow-api-handler data attribute [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137957 (owner: 10SG) [17:37:44] 3MediaWiki / 3Watchlist: Clearing large (39k+) watchlist @ Special:EditWatchlist/clear fails, HTTP error 503 - 10https://bugzilla.wikimedia.org/66212#c7 (10Brion Vibber) Sounds like we might need to break large very deletions into batches or something. Bah. [17:37:51] (03PS2) 10SG: Implement flow-api-handler data attribute [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137957 [17:37:54] (03CR) 10jenkins-bot: [V: 04-1] Implement flow-api-handler data attribute [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137957 (owner: 10SG) [17:41:16] 3Analytics / 3Tech community metrics: Code review time must be on merged patches, not closed ones - 10https://bugzilla.wikimedia.org/66265 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Created attachment 15584 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15584&action=edit Screenshot of the grap... [17:45:02] 3Analytics / 3Tech community metrics: Graphs for median/average should report absolute numbers - 10https://bugzilla.wikimedia.org/66266 (10Nemo) 3NEW p:3Unprio s:3enhanc a:3None In graphs like those of attachment 15584, which report only median, it's easy to get distracted if you don't know absolute... [17:49:49] (03CR) 10Aaron Schulz: [C: 032] Apply PST to the correct page [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/137343 (https://bugzilla.wikimedia.org/66084) (owner: 10Anomie) [17:49:55] (03Merged) 10jenkins-bot: Apply PST to the correct page [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/137343 (https://bugzilla.wikimedia.org/66084) (owner: 10Anomie) [17:53:29] 3MediaWiki extensions / 3TemplateSandbox: Pre-save transform applied to wrong page - 10https://bugzilla.wikimedia.org/66084 (10Jackmcbarn) 5PATC>3RESO/FIX [17:57:07] (03PS1) 10Deepali: Automatically add book categories to sections of the book [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/137959 (https://bugzilla.wikimedia.org/51975) [17:57:10] (03CR) 10jenkins-bot: [V: 04-1] Automatically add book categories to sections of the book [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/137959 (https://bugzilla.wikimedia.org/51975) (owner: 10Deepali) [17:59:47] 3MediaWiki extensions / 3WikidataRepo: jquery styles overriding entity suggester styles - 10https://bugzilla.wikimedia.org/66268 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs when hovering, jquery styles are overriding the entity suggester styles, making it difficult to read. http://snag.gy/txP... [18:00:36] (03CR) 10Gergő Tisza: "Two optional nitpicks, feel free to ignore." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/135008 (owner: 10Gilles) [18:02:09] (03CR) 10Aaron Schulz: [C: 032] Fix language markup for previews [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/137344 (owner: 10Anomie) [18:02:15] (03Merged) 10jenkins-bot: Fix language markup for previews [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/137344 (owner: 10Anomie) [18:06:16] 3MediaWiki extensions / 3BookManagerv2: Make a version of book navigation that works without javascript - 10https://bugzilla.wikimedia.org/66269 (10Deepali Jain) 3NEW p:3Unprio s:3normal a:3None Currently, the chapter list for table of contents in the navbar and book landing page is loaded through aj... [18:08:16] 3MediaWiki extensions / 3BookManagerv2: A version of book navigation without css and images - 10https://bugzilla.wikimedia.org/66270 (10Deepali Jain) 3NEW p:3Unprio s:3normal a:3None Right now, the navigation bar depends on css and images for icons for its display. There should be a simple version wi... [18:10:02] 3MediaWiki extensions / 3BookManagerv2: Mobile Version of book navigation - 10https://bugzilla.wikimedia.org/66271 (10Deepali Jain) 3NEW p:3Unprio s:3normal a:3None A decent mobile version of book navigation interface is needed. [18:13:44] (03PS1) 10Mwalker: Merge hack patch for DI [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/137962 [18:14:36] (03CR) 10Mwalker: [C: 032] Merge hack patch for DI [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/137962 (owner: 10Mwalker) [18:15:15] 3MediaWiki extensions / 3WikidataRepo: jquery styles overriding entity suggester styles - 10https://bugzilla.wikimedia.org/66268 (10Aude) s:5normal>3critic [18:23:31] 3MediaWiki / 3Unit tests: Add browser tests for major core features - 10https://bugzilla.wikimedia.org/66272 (10Chris Steipp) 3NEW p:3Unprio s:3enhanc a:3None There was a task/goal about this, but never a bug that I can find. We had talked about doing this before 1.23, and I still think we should bac... [18:24:23] (03PS2) 10Deepali: Automatically add book categories to sections of the book [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/137959 (https://bugzilla.wikimedia.org/51975) [18:24:26] (03CR) 10jenkins-bot: [V: 04-1] Automatically add book categories to sections of the book [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/137959 (https://bugzilla.wikimedia.org/51975) (owner: 10Deepali) [18:26:50] (03PS3) 10Deepali: Automatically add book categories to sections of the book [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/137959 (https://bugzilla.wikimedia.org/51975) [18:30:25] (03PS1) 10Jackmcbarn: Change MostLinkedTemplates to MostTranscludedPages [core] - 10https://gerrit.wikimedia.org/r/137967 [18:30:36] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/131043 (owner: 10Werdna) [18:30:39] (03CR) 10Gergő Tisza: ""I am not sure how to load webfonts with ResourceLoader. Should they be encoded in the CSS itself like `entypo` in EventLogging?"" [core] - 10https://gerrit.wikimedia.org/r/137888 (https://bugzilla.wikimedia.org/66138) (owner: 10Prtksxna) [18:32:05] (03PS1) 10UltrasonicNXT: Remove hypens from extension entries on Special:Version [core] - 10https://gerrit.wikimedia.org/r/137968 [18:33:18] (03CR) 10Siebrand: [C: 04-1] "Per comments." (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/137528 (https://bugzilla.wikimedia.org/65514) (owner: 10Mattflaschen) [18:35:54] (03CR) 10UltrasonicNXT: "This is unnecessary, as pageBody will always be a string, it won't make a difference. (All the code is doing is checking if the string has" [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/137894 (owner: 10Hashar) [18:36:30] (03CR) 10Siebrand: [C: 04-1] "Default "version number" being a dash is fine by me. Please don't remove it, but propose something else. Removing it (or rather, setting i" [core] - 10https://gerrit.wikimedia.org/r/137968 (owner: 10UltrasonicNXT) [18:36:32] (03CR) 10Dduvall: [C: 04-1] "The Ruby looks good aside from two minor syntactic suggestions, and the README is very clear but I've left a note that Summary could be br" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/133507 (owner: 10Cmcmahon) [18:38:00] (03CR) 10UltrasonicNXT: "(The double equals can sometimes turn '' into false/0 if the other arguament is an integer/boolean, but seeing as the other arguament is a" [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/137894 (owner: 10Hashar) [18:39:35] (03CR) 10Brian Wolff: [C: 04-1] "Why not just change the canonical name of the special page, and leave the class name, etc alone." [core] - 10https://gerrit.wikimedia.org/r/137967 (owner: 10Jackmcbarn) [18:41:06] (03PS1) 10MaxSem: Remove unused variable [core] - 10https://gerrit.wikimedia.org/r/137970 [18:41:26] (03CR) 10SG: "I'm not a big fan of the 33% size overhead with data-uris, and I don't like that every time a CSS change is made, the whole font has to be" [core] - 10https://gerrit.wikimedia.org/r/137888 (https://bugzilla.wikimedia.org/66138) (owner: 10Prtksxna) [18:41:30] (03CR) 10MaxSem: "Liangent, that'd be https://gerrit.wikimedia.org/r/137970 :)" [core] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137807 (owner: 10MaxSem) [18:43:45] http://docs.php.net/manual/en/migration56.new-features.php [18:43:50] csteipp: hay for hash_equals :) [18:44:10] (03CR) 10Liangent: "I've already made https://gerrit.wikimedia.org/r/137847 ..." [core] - 10https://gerrit.wikimedia.org/r/137970 (owner: 10MaxSem) [18:44:48] Wuhoo! Now we just have to wait 11 years for mediawiki to support it.. :) [18:45:44] (03PS1) 10Yurik: New validated base to allow nested content storage [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/137972 [18:47:27] (03PS1) 10Yurik: derrived classes no longer need to Init/Finish validation [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/137973 [18:48:11] (03PS2) 10Jackmcbarn: Change MostLinkedTemplates to MostTranscludedPages [core] - 10https://gerrit.wikimedia.org/r/137967 [18:50:44] 3Wikimedia / 3Site requests: Install PageTriage on fr.wp - 10https://bugzilla.wikimedia.org/66260#c1 (10Bawolff (Brian Wolff)) Isn't there allegedly internationalization issues with this extension? [18:51:03] manybubbles: {"code":"request_too_long","info":"Prefix search request was longer longer than the maximum allowed length. (267 > 255)"} [18:51:07] manybubbles: "longer longer"? :P [18:51:15] (Courtesy of Krenair ) [18:51:44] 3Wikimedia / 3Site requests: Install PageTriage on fr.wp - 10https://bugzilla.wikimedia.org/66260#c2 (10Andre Klapper) p:5Unprio>3Lowest Setting to lowest priority to reflect reality - bug 48552 says "the extension is pretty much impossible to internationalise". Some requests for deployment got even clo... [18:52:57] (03PS1) 10Dduvall: Revert "Stop 'stdin: is not a tty' complaints" [vagrant] - 10https://gerrit.wikimedia.org/r/137974 [18:54:23] (03CR) 10Ori.livneh: [C: 032] "the cookie is a lie! :D" [vagrant] - 10https://gerrit.wikimedia.org/r/137974 (owner: 10Dduvall) [18:54:28] (03Merged) 10jenkins-bot: Revert "Stop 'stdin: is not a tty' complaints" [vagrant] - 10https://gerrit.wikimedia.org/r/137974 (owner: 10Dduvall) [18:55:00] (03PS1) 10Aaron Schulz: More optimizations to User::saveOptions() [core] - 10https://gerrit.wikimedia.org/r/137977 [18:58:46] (03PS2) 10Aaron Schulz: More optimizations to User::saveOptions() [core] - 10https://gerrit.wikimedia.org/r/137977 [19:02:30] (03CR) 10BryanDavis: Revert "Stop 'stdin: is not a tty' complaints" (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/137974 (owner: 10Dduvall) [19:04:44] 3MediaWiki extensions / 3Translate: Simplistic alignment based on h2 headers - 10https://bugzilla.wikimedia.org/66162#c2 (10Nemo) The two concerns are separate. You're always going to have past translations which don't follow the source text (or your assumptions) in their structure including whitespace aroun... [19:06:16] (03PS1) 10Paladox: Update jQuery UI and Effects [core] - 10https://gerrit.wikimedia.org/r/137979 [19:06:43] (03CR) 10Dr0ptp4kt: [C: 032] "Same concerns apply on getting the abstract class vs interface thing resolved." [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/137973 (owner: 10Yurik) [19:07:25] (03CR) 10Paladox: [C: 031] "hi I have updated jquery ui." [core] - 10https://gerrit.wikimedia.org/r/137979 (owner: 10Paladox) [19:08:44] 3MediaWiki / 3General/Unknown: HHVM Jit assertion errors - 10https://bugzilla.wikimedia.org/66205 (10Andre Klapper) [19:09:14] 3Wikimedia / 3Site requests: Install PageTriage on fr.wp - 10https://bugzilla.wikimedia.org/66260#c3 (10Mathis Benguigui) Bug 42322 says: "There are other options as well: * We can deploy PageTriage with the deletion wizard part disabled […]" https://bugzilla.wikimedia.org/show_bug.cgi?id=42322#c1 Is it... [19:10:26] (03PS3) 10Dduvall: Ruby module for better management of ruby and gems [vagrant] - 10https://gerrit.wikimedia.org/r/137483 (https://bugzilla.wikimedia.org/50993) [19:11:32] is someone working on beta-hhvm? [19:14:31] (03PS1) 10Parent5446: Corrected some language issues [core] - 10https://gerrit.wikimedia.org/r/137982 [19:15:39] (03CR) 10Parent5446: [C: 04-1] Corrected some language issues (032 comments) [core] - 10https://gerrit.wikimedia.org/r/137982 (owner: 10Parent5446) [19:18:37] (03PS1) 10Jforrester: Update VisualEditor to I903d2892 [core] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137983 [19:20:12] (03PS1) 10Jforrester: Update VisualEditor to I903d2892 [core] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/137984 [19:25:15] 3MediaWiki extensions / 3WikidataClient: Add links is missing in MonoBook - 10https://bugzilla.wikimedia.org/64741#c15 (10Thiemo Mättig) (In reply to Rhadamante from comment #14) > there is no such problem on Wikimedia commons Log out first to see the problem. Please note that the bug is fixed in the softw... [19:26:25] (03CR) 10Nikerabbit: Corrected some language issues (038 comments) [core] - 10https://gerrit.wikimedia.org/r/137982 (owner: 10Parent5446) [19:29:26] (03CR) 10Krinkle: [C: 04-1] "There is an open bug for this (bug 47076) with some useful information about why we're not upgrading to jQuery UI 1.10 but to 1.19. I alre" [core] - 10https://gerrit.wikimedia.org/r/137979 (owner: 10Paladox) [19:32:20] (03CR) 10Krinkle: Update jQuery UI and Effects (032 comments) [core] - 10https://gerrit.wikimedia.org/r/137979 (owner: 10Paladox) [19:35:44] 3MediaWiki extensions / 3GeoData: prop=coordinates on list=geosearch results doesn't always return coordinates - 10https://bugzilla.wikimedia.org/66150#c1 (10Max Semenik) Apparently, caused by massive job queue effects: some Cirrus updates got processed before RefreshLinks. Waiting on queue to process everyt... [19:38:59] (03CR) 10Mattflaschen: [C: 04-1] "I tested by calling the method in phpsh and reviewed the diff between the previous CSS and this." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/137403 (owner: 10Krinkle) [19:39:46] 3MediaWiki / 3Page editing: After upgrading from 1.15 to 1.23 get "A database query error has occurred. This may indicate a bug in the software." - 10https://bugzilla.wikimedia.org/66277 (10Andrei K) 3UNCO p:3Unprio s:3normal a:3None I have upgraded our wiki from 1.15 to latest 1.23 version. All seem... [19:40:42] (03CR) 10Parent5446: Corrected some language issues (034 comments) [core] - 10https://gerrit.wikimedia.org/r/137982 (owner: 10Parent5446) [19:41:11] (03CR) 10Jackmcbarn: [C: 031] Update list item newline handling to follow Parsoid's model [core] - 10https://gerrit.wikimedia.org/r/134380 (https://bugzilla.wikimedia.org/39617) (owner: 10GWicke) [19:43:29] 3Wikimedia / 3Site requests: Deploy TemplateData's GUI editing tool to Portuguese Wikipedia - 10https://bugzilla.wikimedia.org/66255#c2 (10James Forrester) This is scheduled to go out at ~15:00 UTC on Monday (9 June). [19:45:24] (03PS2) 10Gerrit Patch Uploader: [WIP] Add hak-latn/hans/hant variants [core] - 10https://gerrit.wikimedia.org/r/116691 (https://bugzilla.wikimedia.org/55876) [19:45:26] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/116691 (https://bugzilla.wikimedia.org/55876) (owner: 10Gerrit Patch Uploader) [19:48:29] 3MediaWiki / 3Page editing: After upgrading from 1.15 to 1.23 get "A database query error has occurred. This may indicate a bug in the software." - 10https://bugzilla.wikimedia.org/66277#c1 (10Andre Klapper) Thanks for reporting this! Please see http://www.mediawiki.org/wiki/Manual:How_to_debug for how to g... [19:49:00] 3Wikimedia / 3Site requests: Deploy TemplateData's GUI editing tool to all wikis - 10https://bugzilla.wikimedia.org/60158 (10Helder) [19:49:00] 3Wikimedia / 3Site requests: Enabling TemplateData editor in Catalan Wikipedia - 10https://bugzilla.wikimedia.org/65785 (10Helder) [19:49:25] 3MediaWiki / 3Page editing: After upgrading from 1.15 to 1.23 get "A database query error has occurred. This may indicate a bug in the software." - 10https://bugzilla.wikimedia.org/66277#c2 (10Andre Klapper) Oops, you wrote "when you edit it", sorry - can reproduce. In any case, more debugging information i... [19:53:44] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add hak-latn/hans/hant variants [core] - 10https://gerrit.wikimedia.org/r/116691 (https://bugzilla.wikimedia.org/55876) (owner: 10Gerrit Patch Uploader) [19:59:00] * jackmcbarn kicks grrrit-wm [19:59:15] (03CR) 10Physikerwelt: Add getHtmlOutput method (034 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/137808 (owner: 10Physikerwelt) [20:01:43] (03PS9) 10Physikerwelt: Add getHtmlOutput method [extensions/Math] - 10https://gerrit.wikimedia.org/r/137808 [20:01:48] (03PS1) 10Jackmcbarn: Re-emit unknown tags from #tag [core] - 10https://gerrit.wikimedia.org/r/138013 [20:03:29] (03CR) 10Bsitu: [C: 032] Output an `edit` action for non-existant header [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137835 (owner: 10EBernhardson) [20:03:47] (03Merged) 10jenkins-bot: Output an `edit` action for non-existant header [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137835 (owner: 10EBernhardson) [20:03:54] (03PS1) 10Cmcmahon: QA: update ruby gems [extensions/Flow] - 10https://gerrit.wikimedia.org/r/138015 [20:04:29] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/138015 (owner: 10Cmcmahon) [20:04:42] (03PS2) 10Jackmcbarn: Keep the sanitizer from breaking transparent tags [core] - 10https://gerrit.wikimedia.org/r/137821 [20:04:44] (03Merged) 10jenkins-bot: QA: update ruby gems [extensions/Flow] - 10https://gerrit.wikimedia.org/r/138015 (owner: 10Cmcmahon) [20:04:45] 3MediaWiki / 3Page editing: After upgrading from 1.15 to 1.23 get "A database query error has occurred. This may indicate a bug in the software." - 10https://bugzilla.wikimedia.org/66277#c3 (10Andrei K) I can reproduce it every time. Tested in two browsers, in two different networks. Please, try again: 1) O... [20:05:21] (03CR) 10Jackmcbarn: "Changes to #tag have been split into I0ceee8a4fdaf2d3142054a108f445ff06597c31a" [core] - 10https://gerrit.wikimedia.org/r/137821 (owner: 10Jackmcbarn) [20:07:24] (03PS2) 10Jackmcbarn: Use transparent tags [extensions/Cite] - 10https://gerrit.wikimedia.org/r/137824 [20:07:30] (03CR) 10jenkins-bot: [V: 04-1] Use transparent tags [extensions/Cite] - 10https://gerrit.wikimedia.org/r/137824 (owner: 10Jackmcbarn) [20:07:44] 3MediaWiki / 3Page editing: After upgrading from 1.15 to 1.23 get "A database query error has occurred. This may indicate a bug in the software." - 10https://bugzilla.wikimedia.org/66277#c4 (10Andrei K) There is a debug info I have got: A database query error has occurred. This may indicate a bug in the sof... [20:13:52] (03CR) 10Gergő Tisza: Generate thumbnails based on buckets (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135008 (owner: 10Gilles) [20:14:28] (03CR) 10Gergő Tisza: [C: 04-1] "Per the comment in patchset 13, I think there is still a fundamental problem with this." [core] - 10https://gerrit.wikimedia.org/r/135008 (owner: 10Gilles) [20:15:08] (03PS11) 10Greg Grossmeier: WIP: browser acceptance tests [core] - 10https://gerrit.wikimedia.org/r/133507 (https://bugzilla.wikimedia.org/66272) (owner: 10Cmcmahon) [20:18:07] (03CR) 10Nemo bis: "Nothing so obviously wrong that I can notice it, may look a bit more later." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/116691 (https://bugzilla.wikimedia.org/55876) (owner: 10Gerrit Patch Uploader) [20:18:44] 3MediaWiki / 3Page editing: After upgrading from 1.15 to 1.23 get "Error: 1267 Illegal mix of collations" - 10https://bugzilla.wikimedia.org/66277 (10Andrei K) [20:22:35] (03CR) 10Cscott: "It's not clear what you mean by "transparent" tags." [core] - 10https://gerrit.wikimedia.org/r/137821 (owner: 10Jackmcbarn) [20:23:50] (03CR) 10MaxSem: [C: 032] Move api files to a new api folder [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/137955 (owner: 10Umherirrender) [20:23:55] (03Merged) 10jenkins-bot: Move api files to a new api folder [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/137955 (owner: 10Umherirrender) [20:24:01] (03CR) 10Frédéric Wang: [C: 032] "OK, thanks. That's less frightening without all these whitespace changes." [extensions/Math] - 10https://gerrit.wikimedia.org/r/137808 (owner: 10Physikerwelt) [20:24:29] (03CR) 10Jackmcbarn: "See https://doc.wikimedia.org/mediawiki-core/master/php/html/classParser.html#ac9e3668f7245ff9cd8fe162fe3add882 for transparent tags. I'm " [core] - 10https://gerrit.wikimedia.org/r/137821 (owner: 10Jackmcbarn) [20:24:39] (03PS3) 10Gerrit Patch Uploader: Add hak-latn/hans/hant variants [core] - 10https://gerrit.wikimedia.org/r/116691 (https://bugzilla.wikimedia.org/55876) [20:24:41] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/116691 (https://bugzilla.wikimedia.org/55876) (owner: 10Gerrit Patch Uploader) [20:27:43] (03PS1) 10Yurik: Added error reporting to JCCache [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/138021 [20:27:45] (03PS2) 10CSteipp: Add HKDF as a fast, random number source [core] - 10https://gerrit.wikimedia.org/r/137077 [20:30:16] (03CR) 1001tonythomas: "That can be a problem ? Anyway, we are working on the 5.2.0-patch tag right ? This readme gets pushed to the master branch. Doesn't look l" [core/vendor/swiftmailer] - 10https://gerrit.wikimedia.org/r/137540 (owner: 1001tonythomas) [20:31:50] (03PS16) 1001tonythomas: Shifted from PEAR/PHP mailer to Swift Mailer [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) [20:32:48] (03PS2) 10Paladox: Update jQuery UI and Effects [core] - 10https://gerrit.wikimedia.org/r/137979 [20:33:03] (03CR) 10Gergő Tisza: Generate thumbnails based on buckets (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135008 (owner: 10Gilles) [20:33:43] (03CR) 10Paladox: [C: 031] "Hi I based this new patch on your but upgraded everything to jQuery 1.10.4" [core] - 10https://gerrit.wikimedia.org/r/137979 (owner: 10Paladox) [20:34:45] (03CR) 10Thiemo Mättig (WMDE): Insource support (033 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/137733 (https://bugzilla.wikimedia.org/65783) (owner: 10Manybubbles) [20:36:27] (03PS3) 10Paladox: Update jQuery UI and Effects [core] - 10https://gerrit.wikimedia.org/r/137979 [20:38:01] 3MediaWiki extensions / 3Scribunto: __call metamethod doesn't work on elements of the export table - 10https://bugzilla.wikimedia.org/66278 (10Jackmcbarn) 3NEW p:3Unprio s:3trivia a:3None Create the following as Module:Foo: local p, mt = {}, {} function mt.__call(t, frame) return 'Hello from the... [20:38:49] (03PS1) 10Physikerwelt: WIP: Separate render and getHtml [extensions/Math] - 10https://gerrit.wikimedia.org/r/138023 [20:39:12] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/138013 (owner: 10Jackmcbarn) [20:39:55] (03PS1) 10Jack Phoenix: Fix RL modules' names. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/138024 [20:40:20] (03CR) 10Jack Phoenix: [C: 032 V: 032] Fix RL modules' names. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/138024 (owner: 10Jack Phoenix) [20:40:58] (03CR) 10Physikerwelt: WIP: Separate render and getHtml (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/138023 (owner: 10Physikerwelt) [20:42:49] (03CR) 10Paladox: [C: 031] Upgrade jQuery UI from 1.8.24 to 1.9.2 [core] - 10https://gerrit.wikimedia.org/r/137471 (https://bugzilla.wikimedia.org/47076) (owner: 10Krinkle) [20:42:59] (03CR) 10jenkins-bot: [V: 04-1] Shifted from PEAR/PHP mailer to Swift Mailer [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [20:43:25] (03PS2) 10Physikerwelt: Separate render and getHtml [extensions/Math] - 10https://gerrit.wikimedia.org/r/138023 [20:44:36] (03CR) 10Physikerwelt: "We should test carefully if this change breaks caching before merging it!" [extensions/Math] - 10https://gerrit.wikimedia.org/r/138023 (owner: 10Physikerwelt) [20:45:14] (03CR) 10Paladox: [C: 031] Update jQuery UI and Effects [core] - 10https://gerrit.wikimedia.org/r/137979 (owner: 10Paladox) [20:45:24] (03CR) 10MaxSem: [C: 032] Fatal error: Unsupported operand types in Collection.body.php [extensions/Collection] (REL1_23) - 10https://gerrit.wikimedia.org/r/137917 (https://bugzilla.wikimedia.org/60538) (owner: 10Joerg) [20:45:33] (03Merged) 10jenkins-bot: Fatal error: Unsupported operand types in Collection.body.php [extensions/Collection] (REL1_23) - 10https://gerrit.wikimedia.org/r/137917 (https://bugzilla.wikimedia.org/60538) (owner: 10Joerg) [20:45:54] (03CR) 10Krinkle: Shifted from PEAR/PHP mailer to Swift Mailer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [20:46:01] qchris: ping [20:46:16] harshkothari: pong [20:46:52] harshkothari: ping about ActivityMonitor? [20:47:00] qchris: yes [20:47:14] 3MediaWiki / 3Page editing: After upgrading from 1.15 to 1.23 get "Error: 1267 Illegal mix of collations" - 10https://bugzilla.wikimedia.org/66277#c5 (10Andre Klapper) Did you only upgrade MediaWiki, or also your database backend? :) I assume you use the MySQL backend? > Error: 1267 Illegal mix of collation... [20:47:33] Let me do it right away. [20:47:35] qchris: my gerrit username is Harshkothari410 [20:47:47] so add that instead of Harsh4101991 [20:47:58] ok. [20:48:04] (03CR) 10Krinkle: [C: 04-1] "I'm not sure how you based it on it, but this looks like an amendment. There's also unexpected changes in resources/lib/oojs-ui. Anyhow, I" [core] - 10https://gerrit.wikimedia.org/r/137979 (owner: 10Paladox) [20:49:51] harshkothari: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/ActivityMonitor [20:49:58] (03PS1) 10Jack Phoenix: Capitalize header menu titles via CSS. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/138030 [20:50:40] (03CR) 10Jack Phoenix: [C: 032 V: 032] Capitalize header menu titles via CSS. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/138030 (owner: 10Jack Phoenix) [20:52:37] (03CR) 10Yurik: [C: 032] Added error reporting to JCCache [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/138021 (owner: 10Yurik) [20:52:43] (03Merged) 10jenkins-bot: Added error reporting to JCCache [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/138021 (owner: 10Yurik) [20:53:30] (03PS1) 10Manybubbles: Properly handle pages that turn into redirects [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/138032 (https://bugzilla.wikimedia.org/61211) [20:55:59] 3MediaWiki extensions / 3Scribunto: __call metamethod doesn't work on elements of the export table - 10https://bugzilla.wikimedia.org/66278#c1 (10Brad Jorsch) What would be the advantage of allowing #invoke to call a table via the __call metamethod, instead of just using a function? Functions seem like they... [20:56:39] qchris: thanks [20:56:42] :) [20:56:56] yw [20:58:39] (03PS1) 10Hashar: Let operations-puppet-validate run on lanthanum [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138033 [21:01:10] (03PS1) 10Bsitu: Add "Appears on "blah" board" to topic history page [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138035 [21:04:39] (03Abandoned) 10Hashar: Let operations-puppet-validate run on lanthanum [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138033 (owner: 10Hashar) [21:08:01] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Article snippet did not contain text when the term was in the article - 10https://bugzilla.wikimedia.org/66279 (10Nik Everett) 3NEW p:3Unprio s:3normal a:3None I can't reproduce this myself but it was mentioned here: https://en.wikipedia.org/wiki/V... [21:08:44] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Article snippet did not contain text when the term was in the article - 10https://bugzilla.wikimedia.org/66279#c1 (10Nik Everett) 5NEW>3RESO/WOR Closing WORKFORME because I cannot reproduce the issue. Please reopen if you can. [21:09:07] (03CR) 10Cscott: [C: 032] Add Image Metadata to Image Database [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/107562 (owner: 10Mwalker) [21:09:14] 3MediaWiki extensions / 3Scribunto: __call metamethod doesn't work on elements of the export table - 10https://bugzilla.wikimedia.org/66278#c2 (10Jackmcbarn) Take this module, for example: local p = {} p.continents = { na = { area = 24490000, pop = 542056000 }, sa = { area = 17840000, pop = 39255500... [21:11:46] 3Analytics / 3Wikimetrics: When scheduling a recurrent report the 1st run of the report is not kicked right away - 10https://bugzilla.wikimedia.org/66280 (10nuria) 3NEW p:3Unprio s:3normal a:3None When scheduling a recurrent report the 1st run of the report is not kicked right away. The UI then, unti... [21:14:14] 3Wikimedia / 3Site requests: Install PageTriage on fr.wp - 10https://bugzilla.wikimedia.org/66260#c4 (10Quim Gil) Please, let's focus the discussion about i18n of PageTriage at Bug 48552. There are several projects (languages) interested and we need all the energy focusing in one point. [21:15:39] qgil: To be honest, I don't know how it was that nobody thought this would be an issue when making page curation [21:16:31] 3MediaWiki / 3Skin and page rendering: Default image alignment is not applied to parsoid-output figure elements - 10https://bugzilla.wikimedia.org/66282 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None If the alignment of an image is not explicitly set, Parsoid does not output an alignment class for... [21:16:49] bawolff, sure, I'm only saying that having the discussion in one place is more useful than having it in different places. [21:17:35] yeah definitely. I'm just being snarky [21:17:38] bawolff, I asked Kaldary yesterday, apparently the main problem has less to do with i18n itself, and more with en.wiki-specific features. [21:17:56] (03CR) 10Nemo bis: "Once some non-controversial bits are identified, they'd better be split to their own patch (with release notes) in order to speed up thing" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/137982 (owner: 10Parent5446) [21:18:09] yeah, there's translations in translatewiki for that extension, the workflows are all hard coded to enwiki workflows [21:18:26] I'm not sure what happens if enwiki decides to change its workflows, like they do on occasion [21:18:38] (03PS1) 10Kaldari: Make sure images that don't have an explicit alignment get aligned right [core] - 10https://gerrit.wikimedia.org/r/138038 (https://bugzilla.wikimedia.org/66282) [21:19:26] no idea either [21:20:01] I was also surprised. I guess now it would have been done differently (or not done at all at the WMF...) [21:20:50] That extension was only produced as captatio benevolentiae after a WONTFIX [21:20:57] (03PS2) 10Kaldari: Make sure images that don't have an explicit alignment get aligned right [core] - 10https://gerrit.wikimedia.org/r/138038 (https://bugzilla.wikimedia.org/66282) [21:21:12] https://meta.wikimedia.org/wiki/Limits_to_configuration_changes [21:21:29] 3Analytics / 3Tech community metrics: Graphs for median/average should report absolute numbers - 10https://bugzilla.wikimedia.org/66266#c1 (10Quim Gil) Just checking: is what you are asking the information provided by the popup windows when you hover over the graphs? [21:22:07] (03CR) 10Nemo bis: Corrected some language issues (031 comment) [core] - 10https://gerrit.wikimedia.org/r/137982 (owner: 10Parent5446) [21:22:30] qgil: enwiki doesn't even like it that much from what I understand [21:23:37] It's not particularly useful, hoo|away fixing https://www.mediawiki.org/wiki/MediaWiki_1.22#Anti-spam_and_countervandalism_improvements had three times as big as an effect in terms of patrolling [21:24:11] Hmm, I'm glad there's documentation about when config changes are rejected [21:24:17] The crucial engines of the wiki (recentchanges, watchlist, patrolling, history, diffs) are the most neglected parts and where one can have most impact. ;) [21:24:32] I don't have an opinion about the extensions. I just (re)learned about it yesterday, when a veteran ca.wiki editor suggested that it would be a good idea to enable it in their project. [21:24:56] bawolff: I think that page was created when en.wiki was surprised to learn that not every configuration request can be satisfied, to show precedents [21:25:14] (03PS1) 10Harshkothari410: initial commit for Extension:ActivityMonitor [extensions/ActivityMonitor] - 10https://gerrit.wikimedia.org/r/138042 [21:25:45] Hmm, I'm pretty sure there was rejections prior to the one enwiki got pissed about [21:27:00] 3MediaWiki / 3JobQueue: HHVM fails to unserialize() value in JobQueueRedis.php:798 - 10https://bugzilla.wikimedia.org/65466#c5 (10Ori Livneh) 5RESO/WOR>3RESO/FIX There was another bug in the Redis client which also caused failures to unserialize: https://github.com/facebook/hhvm/pull/2874 [21:27:01] Sure, as I said the page was useful to show precedents :) [21:27:26] (03PS1) 10Cscott: Update dependencies. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/138043 [21:28:14] 3Analytics / 3Tech community metrics: Graphs for median/average should report absolute numbers - 10https://bugzilla.wikimedia.org/66266#c2 (10Nemo) (In reply to Quim Gil from comment #1) > Just checking: is what you are asking the information provided by the popup > windows when you hover over the graphs? N... [21:28:16] (03CR) 10Kaldari: Make sure images that don't have an explicit alignment get aligned right (031 comment) [core] - 10https://gerrit.wikimedia.org/r/138038 (https://bugzilla.wikimedia.org/66282) (owner: 10Kaldari) [21:29:14] 3Analytics / 3Tech community metrics: Code review time must be on merged patches, not closed ones - 10https://bugzilla.wikimedia.org/66265#c1 (10Quim Gil) p:5Unprio>3Normal (In reply to Nemo from comment #0) > The solution is simple: reverse your query, calculate the median time that > it took for *merge... [21:30:02] (03CR) 10Mattflaschen: [C: 032] "This matches MySQL's default value, according to https://stackoverflow.com/questions/22868345/mysql-add-a-not-null-column ." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/87022 (owner: 10Dereckson) [21:30:56] (03CR) 10GWicke: [C: 04-1] Make sure images that don't have an explicit alignment get aligned right (031 comment) [core] - 10https://gerrit.wikimedia.org/r/138038 (https://bugzilla.wikimedia.org/66282) (owner: 10Kaldari) [21:32:40] (03PS2) 10Cscott: Update dependencies. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/138043 [21:33:44] 3Analytics / 3Tech community metrics: Code review time must be on merged patches, not closed ones - 10https://bugzilla.wikimedia.org/66265#c2 (10Nemo) (In reply to Quim Gil from comment #1) > However, we want to put our attention first on the work that still needs to > be done. You can be pretty fast closing... [21:33:59] 3Analytics / 3Tech community metrics: Graphs for median/average should report absolute numbers - 10https://bugzilla.wikimedia.org/66266 (10Quim Gil) [21:33:59] 3Analytics / 3Tech community metrics: Identifying open changesets submitted by each organization - 10https://bugzilla.wikimedia.org/63530 (10Quim Gil) [21:35:46] (03PS3) 10Kaldari: Make sure images that don't have an explicit alignment get aligned right [core] - 10https://gerrit.wikimedia.org/r/138038 (https://bugzilla.wikimedia.org/66282) [21:38:49] (03CR) 10Cscott: Make sure images that don't have an explicit alignment get aligned right (031 comment) [core] - 10https://gerrit.wikimedia.org/r/138038 (https://bugzilla.wikimedia.org/66282) (owner: 10Kaldari) [21:39:02] (03CR) 10Cscott: [C: 031] "v3 looks good to me." [core] - 10https://gerrit.wikimedia.org/r/138038 (https://bugzilla.wikimedia.org/66282) (owner: 10Kaldari) [21:40:00] 3MediaWiki extensions / 3ActivityMonitor: ActivityMonitor: Add page filter for watchlist - 10https://bugzilla.wikimedia.org/66178 (10Krinkle) [21:40:00] 3MediaWiki extensions / 3ActivityMonitor: ActivityMonitor: Add page filter for "Unwatched pages" - 10https://bugzilla.wikimedia.org/66179 (10Krinkle) [21:40:02] (03CR) 10GWicke: [C: 031] Make sure images that don't have an explicit alignment get aligned right [core] - 10https://gerrit.wikimedia.org/r/138038 (https://bugzilla.wikimedia.org/66282) (owner: 10Kaldari) [21:40:14] 3MediaWiki extensions / 3ActivityMonitor: ActivityMonitor: Add display flag for pages that are not watched by any users - 10https://bugzilla.wikimedia.org/66180 (10Krinkle) [21:42:44] 3MediaWiki extensions / 3ActivityMonitor: ActivityMonitor: Add page filter for "Unwatched pages" - 10https://bugzilla.wikimedia.org/66179 (10Krinkle) p:5Unprio>3Low [21:46:16] 3Analytics / 3Tech community metrics: Code review metrics should not include [WIP] changesets - 10https://bugzilla.wikimedia.org/66283 (10Quim Gil) 3NEW p:3Unprio s:3normal a:3None In a similar way that we removed -1 changesets, we should also remove those containing WIP in the summary, since they ar... [21:46:29] 3Analytics / 3Tech community metrics: Code review metrics should not include [WIP] changesets - 10https://bugzilla.wikimedia.org/66283 (10Quim Gil) p:5Unprio>3High [21:47:29] 3MediaWiki extensions / 3ActivityMonitor: ActivityMonitor: Initial version (tracking) - 10https://bugzilla.wikimedia.org/66176#c1 (10Krinkle) The initial version should have: * Special:ActivityMonitor: - List changes to the local wiki (near) real-time. - Ability to view the "diff" of an edit. - Access... [21:48:22] (03CR) 10GWicke: [C: 032] "Tested locally. LGTM." [core] - 10https://gerrit.wikimedia.org/r/138038 (https://bugzilla.wikimedia.org/66282) (owner: 10Kaldari) [21:49:59] (03PS4) 10Dduvall: Ruby module for better management of ruby and gems [vagrant] - 10https://gerrit.wikimedia.org/r/137483 (https://bugzilla.wikimedia.org/50993) [21:52:06] (03CR) 10GWicke: "Oh, and thanks Kaldari!" [core] - 10https://gerrit.wikimedia.org/r/138038 (https://bugzilla.wikimedia.org/66282) (owner: 10Kaldari) [21:52:47] (03PS1) 10Cscott: Update mw-ocg-bundler dependencies. [extensions/Collection/OfflineContentGenerator/node_modules] - 10https://gerrit.wikimedia.org/r/138098 [21:53:10] spagewmf, we're now tweaking the Parsoid CSS to work better without any rewriting [21:53:47] gwicke: sweet. I know Flow needs to switch to using the RL module in core. [21:53:55] is jenkins-bot broken? [21:54:19] It won't give me an +2s even though it passes all tests [21:54:38] https://gerrit.wikimedia.org/r/#/c/138019/ [21:55:32] (03CR) 10Paladox: [C: 031] "Ok." [core] - 10https://gerrit.wikimedia.org/r/137979 (owner: 10Paladox) [21:55:58] kaldari, it might be blocked on a parsoid test [21:56:40] spagewmf, today we started to link styles in the head of our output, so you can check how it looks without rewriting using a local parsoid install [21:56:40] Hmm, so if I want to see how the WMF does job queue running, where do I need to look? [21:56:46] (03CR) 10Dr0ptp4kt: "A few questions. Meanwhile, I'm going to re-read this." (037 comments) [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/137972 (owner: 10Yurik) [21:58:59] (03PS3) 10Cscott: Update dependencies. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/138043 [21:59:00] thedj, around? [21:59:46] 3MediaWiki / 3Internationalization: Long message key page names cause memcached errors - 10https://bugzilla.wikimedia.org/66284 (10Aaron Schulz) 3NEW p:3Unprio s:3normal a:3None wikidatawiki: Memcached error for key "wikidatawiki:messages:-999.9_union_all_select_0x31303235343830303536,0x3130323534383... [22:00:15] (03CR) 10PiRSquared17: "Reply to Nemo_bis" [core] - 10https://gerrit.wikimedia.org/r/116691 (https://bugzilla.wikimedia.org/55876) (owner: 10Gerrit Patch Uploader) [22:00:20] (03PS2) 10Cscott: Update mw-ocg-bundler dependencies. [extensions/Collection/OfflineContentGenerator/node_modules] - 10https://gerrit.wikimedia.org/r/138098 [22:00:38] (03CR) 10PiRSquared17: Add hak-latn/hans/hant variants (032 comments) [core] - 10https://gerrit.wikimedia.org/r/116691 (https://bugzilla.wikimedia.org/55876) (owner: 10Gerrit Patch Uploader) [22:01:36] (03CR) 10Bsitu: [C: 04-1] Add "Appears on "blah" board" to topic history page [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138035 (owner: 10Bsitu) [22:04:01] 3MediaWiki extensions / 3ActivityMonitor: ActivityMonitor: Implement user database - 10https://bugzilla.wikimedia.org/66285 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None The user database stores user names and information associated with that user for how it got on the list (by whom, why, since when,... [22:04:04] (03CR) 10Nemo bis: Add hak-latn/hans/hant variants (031 comment) [core] - 10https://gerrit.wikimedia.org/r/116691 (https://bugzilla.wikimedia.org/55876) (owner: 10Gerrit Patch Uploader) [22:04:14] 3MediaWiki extensions / 3ActivityMonitor: ActivityMonitor: Implement user database - 10https://bugzilla.wikimedia.org/66285#c1 (10Krinkle) Interface: sql table, API module, special page. [22:05:15] 3MediaWiki extensions / 3ActivityMonitor: ActivityMonitor: Initial version (tracking) - 10https://bugzilla.wikimedia.org/66176 (10Krinkle) [22:05:15] 3MediaWiki extensions / 3ActivityMonitor: ActivityMonitor: Implement user database - 10https://bugzilla.wikimedia.org/66285 (10Krinkle) s:5normal>3major [22:05:29] 3MediaWiki extensions / 3ActivityMonitor: ActivityMonitor: Implement user database - 10https://bugzilla.wikimedia.org/66285 (10Krinkle) p:5Unprio>3Normal s:5major>3enhanc [22:06:46] (03CR) 10Mattflaschen: [C: 04-1] ""If I understand correctly, getAllStyleFiles already included files for more than the current skin. No need for back-compat or a separate " [core] - 10https://gerrit.wikimedia.org/r/122838 (https://bugzilla.wikimedia.org/63343) (owner: 10Phuedx) [22:07:52] ... Where is this .sh that is mentioned in it located? Is it viewable by mortals? https://git.wikimedia.org/blob/operations%2Fdebs%2Fwikimedia-job-runner/da77068d77b0b86e71b49f2547522ed9ae1ed224/debian%2Fwikimedia-job-runner.mw-job-runner.init [22:10:38] Lcawte: The /usr/local/apache/common/php/extensions/WikimediaMaintenance/jobs-loop.sh ? [22:10:38] (03CR) 10Dr0ptp4kt: "Adding another comment." (031 comment) [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/137972 (owner: 10Yurik) [22:10:41] That's in [22:10:44] 3MediaWiki extensions / 3Translate: MessageGroupStats::forItemInternal deadlocks - 10https://bugzilla.wikimedia.org/51410#c8 (10Aaron Schulz) Log snippet from today (truncated the middle since it was repetitive): 2014-06-06 20:22:22 mw1137 metawiki: Sub-optimal transaction on DB(s) 10.64.16.22 (metawiki) (0... [22:10:47] !e WikimediaMaintinance [22:10:49] I think [22:11:21] It would help if I could spell - https://www.mediawiki.org/wiki/Extension:WikimediaMaintenance [22:11:51] bawolff: I figured that was worth a shot, I can't see it in there, Ctrl+F doesn't seem to show anything either, https://git.wikimedia.org/tree/mediawiki%2Fextensions%2FWikimediaMaintenance [22:12:28] Hmm, you're right, its not that [22:12:35] I'm pretty sure it's somewhere [22:13:25] (03PS2) 10Bsitu: Add board link to permlink and history page [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138035 [22:13:28] modules/mediawiki/templates/jobrunner/jobs-loop.sh.erb in the puppet repo [22:13:40] (03CR) 10EBernhardson: [C: 031] Hacky sub-expression implementation for lightncandy [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137708 (owner: 10EBernhardson) [22:14:53] Lcawte: Or actually https://git.wikimedia.org/blob/operations%2Fpuppet/0143b78fd2b7280e5787cfebaccf408cade6c439/modules%2Fmediawiki%2Ftemplates%2Fjobqueue%2Fjobs-loop.sh.erb [22:15:08] looks like my copy on disk I was grepping is a bit out of date [22:15:28] (03CR) 10Dduvall: "This latest patch set is working well for me but could use some further review by someone who has been using the previous version of the b" [vagrant] - 10https://gerrit.wikimedia.org/r/137483 (https://bugzilla.wikimedia.org/50993) (owner: 10Dduvall) [22:15:30] Thank you :D [22:16:15] 3MediaWiki / 3Special pages: When moving, warn if people try to move to Foo:Foo:Bar (repeated namespace) - 10https://bugzilla.wikimedia.org/60399#c2 (10PiRSquared17) Should it warn for Foo:Bar:Baz too? [22:18:12] (03PS2) 10Yurik: New validated base to allow nested content storage [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/137972 [22:18:39] (03CR) 10Yurik: New validated base to allow nested content storage (038 comments) [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/137972 (owner: 10Yurik) [22:19:18] gwicke: speaking of Parsoid, should it be adding rel="nofollow" to external links, or is that someone else's job? [22:19:54] spagewmf, we were debating that last year.. it wasn't clear if search engines still respect it [22:20:30] (03CR) 10Bartosz Dziewoński: Don't use autodiscovery for core skins, move them to separate directories (033 comments) [core] - 10https://gerrit.wikimedia.org/r/135383 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [22:20:31] the last status was to test it by adding some links to hard-to-guess URLs & then wait for crawlers [22:21:44] the google folks I talked to said that they'd expect it to work; but earlier one of their engineers told me the opposite [22:21:51] I thought the point of rel=nofollow was supposed to decrease search engine rank, not literally nofollow the link [22:22:11] gwicke: already Flow has Parsoid/Redlinker.php (and BadImageRemover, ContentFixer, and ReferenceExtractor), we can add another fixer. [22:22:26] bawolff, normally it literally means nofollow [22:22:28] (03PS1) 10Yurik: Added JsonConfig to mobile channel [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/138101 [22:22:39] it's used to protect expensive resources for example [22:23:24] spagewmf, ideally that list would get shorter over time [22:23:45] we'll tackle red links & bad images client side [22:24:01] actually i think only BadImageRemover and Redlinker are doing content changes, ContentFixer is the interface those implement, and ReferenceExtractor doesn't change content afair it just finds all the anchors [22:24:07] not sure what the ContentFixer is about [22:24:28] ah, k [22:24:39] then the only thing remaining might be the ReferenceExtractor [22:24:52] after Q1 ;) [22:24:56] :) [22:25:09] (03CR) 10Aaron Schulz: "Still seeing "invalid IP given" exceptions in the logs" [core] - 10https://gerrit.wikimedia.org/r/109721 (https://bugzilla.wikimedia.org/57467) (owner: 10Umherirrender) [22:25:24] (03PS8) 10Bartosz Dziewoński: Officially deprecate skin autodiscovery [core] - 10https://gerrit.wikimedia.org/r/135429 (https://bugzilla.wikimedia.org/65748) [22:25:26] (03PS7) 10Bartosz Dziewoński: Don't use autodiscovery for core skins, move them to separate directories [core] - 10https://gerrit.wikimedia.org/r/135383 (https://bugzilla.wikimedia.org/65748) [22:25:27] god damn, does gerrit suck at merging/rebasing [22:25:28] (03PS5) 10Bartosz Dziewoński: [DO NOT MERGE] Completely remove skin autodiscovery [core] - 10https://gerrit.wikimedia.org/r/135439 (https://bugzilla.wikimedia.org/65748) [22:25:45] i keep having to run local rebases which complete automatically, but i can't do them via web interface [22:26:02] (03CR) 10Bartosz Dziewoński: "Rebased manually, again." [core] - 10https://gerrit.wikimedia.org/r/135383 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [22:26:05] ebernhardson, spagewmf: https://bugzilla.wikimedia.org/show_bug.cgi?id=52617 [22:26:05] (03CR) 10Bartosz Dziewoński: "Rebased manually, again." [core] - 10https://gerrit.wikimedia.org/r/135429 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [22:27:17] hey ori, feel like merging/reviewing these? [22:27:33] weird thing we've had the deprecations merged in 1.23 already but not in master :/ [22:29:13] * MatmaRex invokes the "it is blocking me" card [22:31:50] gwicke, ebernhardson : there's complex logic in Parser::getExternalLinkRel to decide whether nofollow. And then there's Parser:makeFreeExternalLink() which adds class="free", not even sure what that means. [22:32:50] heh [22:32:55] always fun times in parser land : [22:32:56] :) [22:33:26] * hoo introduced Parser::getExternalLinkRel... [22:33:31] and I'm a little sorry [22:34:25] hoo, it's public, I think Flow's link extractor can just call it \o/ . Do you have any idea what makeFreeExternalLink() does? I called it and lost $13 [22:36:00] class="free" means its a free link - as in http://example.com instead of [http://example.com foo] (if I remember right) [22:36:10] I think that's it, yes [22:36:32] the function is supposed for linking URLs given without special wikitext url markup [22:37:23] hoo thanks [22:39:25] spagewmf, it's just a few lines [22:41:30] hoo, do you remember what the use case for the exceptions was? [22:42:07] gwicke: For the rel attribute? [22:42:39] hoo, for the exceptions [22:42:50] $wgNoFollowNsExceptions [22:43:07] and $wgNoFollowDomainExceptions [22:43:43] First one: No idea... probably someone thought someone else could use that sometime. Second one: To white list own domains [22:44:03] aren't those normally interwikis? [22:44:05] (03CR) 10Krinkle: [C: 04-1] "See inline comment." (031 comment) [extensions/ActivityMonitor] - 10https://gerrit.wikimedia.org/r/138042 (owner: 10Harshkothari410) [22:44:11] Like we have (I guess so) all our domains in that variable so that we don't nofollow links from 'pedia to meta or so [22:44:20] 15:42 < gwicke> $wgNoFollowNsExceptions [22:44:26] sorry [22:44:30] gwicke: They *can* be interwikis, but you can also make them externallinks [22:45:16] 3Wikimedia / 3Site requests: Deploy TemplateData's GUI editing tool to Portuguese Wikipedia - 10https://bugzilla.wikimedia.org/66255 (10John F. Lewis) p:5Unprio>3Normal a:3James F. [22:45:20] (03CR) 10PiRSquared17: "Anything else?" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/133997 (https://bugzilla.wikimedia.org/52674) (owner: 10Gerrit Patch Uploader) [22:45:36] (03CR) 10PiRSquared17: "Anything else?" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (https://bugzilla.wikimedia.org/21206) (owner: 10Gerrit Patch Uploader) [22:45:51] hoo, yeah -- prod has this list: https://gist.github.com/anonymous/efb794298b86679ee4d9 [22:46:30] 3Wikimedia / 3Site requests: Deploy TemplateData's GUI editing tool to Portuguese Wikipedia - 10https://bugzilla.wikimedia.org/66255 (10James Forrester) a:5James F.>3James Forrester [22:49:03] (03CR) 10EBernhardson: [C: 032] Add board link to permlink and history page [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/138035 (owner: 10Bsitu) [22:49:18] (03CR) 10Legoktm: [C: 032 V: 032] Fix DPLforum b0rkage. [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/137931 (owner: 10Jack Phoenix) [22:50:08] (03PS1) 10Legoktm: Fix DPLforum b0rkage. [extensions/DPLforum] (REL1_23) - 10https://gerrit.wikimedia.org/r/138103 [22:50:16] (03CR) 10Legoktm: [C: 032 V: 032] Fix DPLforum b0rkage. [extensions/DPLforum] (REL1_23) - 10https://gerrit.wikimedia.org/r/138103 (owner: 10Legoktm) [22:51:14] 3MediaWiki / 3Watchlist: Editing large (10k+) watchlist [Special:EditWatchlist but not /raw] fails with HTTP error 500 (fatal error, OOM) - 10https://bugzilla.wikimedia.org/39510#c26 (10UP) Getting 504 Gateway Time-out nginx/1.1.19 on zh.wikipedia normal watchlist edit. 27K foo entries on watchlist. Raw wat... [22:52:14] gwicke, hoo: do you know if any code treats class="external free" vs. class="external text" differently? It would be hard to do equivalent CSS for Parsoid output. [22:53:30] (03CR) 10Mattflaschen: add support for request account link and renames login/create account to login (031 comment) [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/134624 (owner: 10Paladox) [22:53:42] (03CR) 10Mattflaschen: "The message details can be resolved after some other stuff is dealt with." (032 comments) [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/134624 (owner: 10Paladox) [22:54:19] spagewmf, I don't see any mention in enwiki: http://en.wikipedia.org/w/load.php?modules=mediawiki.skinning.elements|mediawiki.skinning.content|mediawiki.skinning.interface|skins.vector.styles|site|mediawiki.skinning.content.parsoid&only=styles&debug=true&skin=vector [22:54:44] there's mentions of .text though [22:55:29] (03CR) 10Aaron Schulz: "A few minor things" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/137077 (owner: 10CSteipp) [22:56:01] only for print it seems [22:56:44] ori, do you have time to review that event serialization change? (https://gerrit.wikimedia.org/r/#/c/133668/) [22:56:56] If not, I feel like I did a good review, so I can merge. [23:00:16] 3Analytics / 3Wikimetrics: Cohort list for report creation screen should not include invalid cohorts - 10https://bugzilla.wikimedia.org/66290 (10nuria) 3NEW p:3Unprio s:3normal a:3None Cohort list for report creation screen should not include invalid cohorts. Only cohorts that are valid should be 'us... [23:04:36] (03CR) 10Bartosz Dziewoński: [C: 031] "I have reviewed the usages and all of them are false positives, gadget pages that are not actually used to define a gadget, or already pro" [core] - 10https://gerrit.wikimedia.org/r/136548 (owner: 10Bartosz Dziewoński) [23:07:01] (03CR) 10EBernhardson: [C: 04-1] "Fatal error: Call to undefined method Flow\Model\PostSummary::isTopicTitle() in /vagrant/mediawiki/extensions/Flow/includes/Formatter/Revi" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137842 (owner: 10Bsitu) [23:11:53] thedj? [23:14:07] (03CR) 10Mattflaschen: "Siebrand, do you think this (key-shifting based on MessageCache::get hook) is how we should do this?" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/137528 (https://bugzilla.wikimedia.org/65514) (owner: 10Mattflaschen) [23:16:37] (03PS2) 10Bsitu: Show topic summary in topic title bar [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137842 [23:16:46] (03PS1) 10Harshkothari410: Initial Commit for Extension:ActivityMonitor [extensions/ActivityMonitor] - 10https://gerrit.wikimedia.org/r/138105 [23:17:26] (03PS4) 10GWicke: Make sure images that don't have an explicit alignment get aligned right [core] - 10https://gerrit.wikimedia.org/r/138038 (https://bugzilla.wikimedia.org/66282) (owner: 10Kaldari) [23:17:47] (03CR) 10GWicke: "Minor edit to commit message to poke Jenkins." [core] - 10https://gerrit.wikimedia.org/r/138038 (https://bugzilla.wikimedia.org/66282) (owner: 10Kaldari) [23:19:13] Krinkle: I screwed up :( [23:19:48] harshkothari: use squash to merge them into one [23:20:07] rebase interactively, use type='fixup' to discard separate commit [23:20:23] git rebase -i --root [23:20:50] (03CR) 10Krinkle: "you're poking a dead horse." [core] - 10https://gerrit.wikimedia.org/r/138038 (https://bugzilla.wikimedia.org/66282) (owner: 10Kaldari) [23:21:50] (03CR) 10EBernhardson: [C: 032] Add sortby last activity as a user preference [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/134955 (owner: 10Bsitu) [23:23:15] 3MediaWiki / 3JavaScript: Upgrade jQuery UI from 1.8 to 1.9 - 10https://bugzilla.wikimedia.org/47076#c8 (10Matthew Flaschen) Adding as a blocker on $.browser bug, per Michael M. (confirmed by grep). [23:23:15] 3MediaWiki / 3JavaScript: Remove all uses of jQuery.browser (tracking) - 10https://bugzilla.wikimedia.org/66097 (10Matthew Flaschen) [23:25:28] lots of conflicts Krinkle [23:26:28] 3MediaWiki / 3JavaScript: Upgrade jQuery UI from 1.8 to 1.9 - 10https://bugzilla.wikimedia.org/47076 (10Krinkle) [23:32:46] 3MediaWiki / 3JavaScript: jQuery cycle uses jQuery browser - 10https://bugzilla.wikimedia.org/66292 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None jQuery cycle (https://git.wikimedia.org/blob/mediawiki%2Fcore.git/9c51f78a12e9817da0593631c1c3426abb574915/resources%2Flib%2Fjquery%2Fjquery.cycle.... [23:32:59] 3MediaWiki / 3JavaScript: jQuery cycle uses jQuery browser - 10https://bugzilla.wikimedia.org/66292 (10Matthew Flaschen) [23:32:59] 3MediaWiki / 3JavaScript: Remove all uses of jQuery.browser (tracking) - 10https://bugzilla.wikimedia.org/66097 (10Matthew Flaschen) [23:33:07] 3MediaWiki / 3JavaScript: jQuery cycle uses jQuery browser - 10https://bugzilla.wikimedia.org/66292 (10Matthew Flaschen) a:3Matthew Flaschen [23:34:13] (03PS1) 10Mattflaschen: Upgrad jQuery.cycle; new version does not use $.browser [core] - 10https://gerrit.wikimedia.org/r/138108 [23:36:03] (03CR) 10EBernhardson: [C: 04-1] "Also while not created by this patch, flow_block_topicsummary_edit.html.handlebars references {{revision.actions.edit.url}} for form submi" (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137842 (owner: 10Bsitu) [23:36:10] can we remove both the commit Krinkle ? [23:37:42] (03CR) 10Krinkle: [C: 04-1] Upgrad jQuery.cycle; new version does not use $.browser (031 comment) [core] - 10https://gerrit.wikimedia.org/r/138108 (owner: 10Mattflaschen) [23:38:54] (03CR) 10Krinkle: Upgrad jQuery.cycle; new version does not use $.browser (031 comment) [core] - 10https://gerrit.wikimedia.org/r/138108 (owner: 10Mattflaschen) [23:40:17] (03PS4) 10Paladox: Update jQuery UI and Effects [core] - 10https://gerrit.wikimedia.org/r/137979 [23:44:06] (03CR) 10Paladox: [C: 031] Update jQuery UI and Effects [core] - 10https://gerrit.wikimedia.org/r/137979 (owner: 10Paladox) [23:44:09] (03CR) 10Mattflaschen: [C: 04-2] "Not tested yet." [core] - 10https://gerrit.wikimedia.org/r/138108 (owner: 10Mattflaschen) [23:44:44] 3MediaWiki / 3Special pages: Interface to get a cross-wiki What links here (aggregate local iwbacklinks from wikis) - 10https://bugzilla.wikimedia.org/1886 (10Krinkle) [23:44:59] 3MediaWiki / 3Special pages: A cross-wiki "What links here" (aggregate local iwbacklinks from wikis) - 10https://bugzilla.wikimedia.org/1886 (10Krinkle) [23:45:50] (03PS2) 10Bartosz Dziewoński: SpecialVersion: Show 'Skins' and 'Extensions' in separate sections [core] - 10https://gerrit.wikimedia.org/r/136615 [23:45:52] (03PS1) 10Bartosz Dziewoński: Allow skins to provide a screenshot for Special:Version [core] - 10https://gerrit.wikimedia.org/r/138110 [23:45:55] WILD IDEAS [23:47:31] 3MediaWiki / 3Special pages: Make a special page to expose iwbacklinks - 10https://bugzilla.wikimedia.org/66293 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None For a few releases now we have iwbacklinks. However, while it is exposed in the API, there is no special page for it. This would be similar to... [23:47:59] 3MediaWiki / 3Special pages: A cross-wiki "What links here" (aggregate local iwbacklinks from wikis) - 10https://bugzilla.wikimedia.org/1886#c15 (10Krinkle) Of course, before we have a cross-wiki one. We should first have a local wiki one. See bug 66293. [23:47:59] 3MediaWiki / 3Special pages: Make a special page to expose iwbacklinks - 10https://bugzilla.wikimedia.org/66293 (10Krinkle) [23:48:13] (03CR) 10Krinkle: "Why are you +1'ing your own change?" [core] - 10https://gerrit.wikimedia.org/r/137979 (owner: 10Paladox) [23:49:18] (03PS2) 10Mattflaschen: Upgrade jQuery Cycle; new version does not use $.browser [core] - 10https://gerrit.wikimedia.org/r/138108 (https://bugzilla.wikimedia.org/66292) [23:49:39] (03PS5) 10Paladox: Update jQuery UI and Effects [core] - 10https://gerrit.wikimedia.org/r/137979 [23:49:41] (03CR) 10Mattflaschen: "Done. Still not sure if we should keep it in core." [core] - 10https://gerrit.wikimedia.org/r/138108 (https://bugzilla.wikimedia.org/66292) (owner: 10Mattflaschen) [23:52:12] (03PS6) 10Paladox: Update jQuery UI and Effects [core] - 10https://gerrit.wikimedia.org/r/137979 [23:52:14] (03CR) 10Bartosz Dziewoński: [C: 04-2] Allow skins to provide a screenshot for Special:Version [core] - 10https://gerrit.wikimedia.org/r/138110 (owner: 10Bartosz Dziewoński) [23:52:14] 3MediaWiki / 3JavaScript: jQuery cycle uses jQuery browser - 10https://bugzilla.wikimedia.org/66292#c2 (10Matthew Flaschen) This is not used in core, or even modularized for RL, so I'm not sure we should keep it. See Gerrit. [23:52:36] (03CR) 10Paladox: [C: 031] Update jQuery UI and Effects [core] - 10https://gerrit.wikimedia.org/r/137979 (owner: 10Paladox) [23:53:05] (03CR) 10Paladox: Update jQuery UI and Effects [core] - 10https://gerrit.wikimedia.org/r/137979 (owner: 10Paladox) [23:54:58] (03PS7) 10Paladox: Update jQuery UI and Effects [core] - 10https://gerrit.wikimedia.org/r/137979 [23:57:31] 3MediaWiki / 3Skin and page rendering: Come up with a sane way of including screenshots with skins and displaying them in the UI - 10https://bugzilla.wikimedia.org/66295 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None We should have a sane way of including screenshots with skins and displayin... [23:58:22] (03CR) 10Bartosz Dziewoński: "Filed bug 66295 for rethinking this idea." [core] - 10https://gerrit.wikimedia.org/r/138110 (owner: 10Bartosz Dziewoński)