[00:02:42] (03PS1) 10Bsitu: Mantle.php should not have to be loaded before Flow.php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/136945 [00:03:46] 3Wikimedia / 3Deployment systems: App servers get into bad states when coming back online/are newly provisioned due to puppet/salt craziness - 10https://bugzilla.wikimedia.org/66050#c2 (10Bryan Davis) I think there is an additional point of weakness here in the design of ::deployment::target. The creation of... [00:07:29] (03CR) 10Gergő Tisza: Grid system for mediawiki.ui (034 comments) [core] - 10https://gerrit.wikimedia.org/r/125387 (owner: 10Pginer) [00:12:14] (03CR) 10Jforrester: "Once more with feeling." [core] - 10https://gerrit.wikimedia.org/r/136801 (owner: 10Jforrester) [00:19:19] (03CR) 10SG: "I think grid-responsive.less can be scrapped entirely, and its functionality could be built-into .mw-ui-item(@width, @medium, @gutter);" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/125387 (owner: 10Pginer) [00:19:38] (03CR) 10SG: [C: 04-1] Grid system for mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/125387 (owner: 10Pginer) [00:26:55] (03CR) 10Mattflaschen: "If those roles actually need to be enabled together, we could use some concat method (https://github.com/puppetlabs/puppetlabs-concat). O" [vagrant] - 10https://gerrit.wikimedia.org/r/136814 (owner: 10Mattflaschen) [00:37:52] (03PS2) 10Hiong3-eng5: docgen [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/136725 [00:43:14] what's a good name for a category for pages that contain invalid things like {{foo|bar=1|bar=2}}? [00:44:32] 3MediaWiki-Vagrant: simple_performant fails to provision with Apache-related error - 10https://bugzilla.wikimedia.org/65922#c5 (10Matthew Flaschen) a:5Ori Livneh>3Matthew Flaschen No, that's not a problem, since the filename is auto-generated form the title (e.g. 'expires' is one of the titles here). Actu... [00:44:33] jackmcbarn: I've used "Pages with broken wikitext" or similar in the past [00:44:47] "Pages with unnecessary wikitext" might be better [00:45:00] (03PS1) 10Bsitu: Flow: notification exceptions: urlGenerator->workflowLink() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136958 (https://bugzilla.wikimedia.org/66060) [00:45:08] marktraceur: for that one issue specifically. i originally went with "Pages with duplicated arguments", but that was dismissed because it made it sound like the page had arguments instead of the template [00:45:41] "Pages with ambiguous template arguments"? [00:47:09] hmm [00:48:28] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.1.0-pre (527ad0ee5a) [core] - 10https://gerrit.wikimedia.org/r/136801 (owner: 10Jforrester) [00:51:40] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (527ad0ee5a) [core] - 10https://gerrit.wikimedia.org/r/136801 (owner: 10Jforrester) [00:52:23] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (6379e76bf5) [core] - 10https://gerrit.wikimedia.org/r/136960 [00:52:51] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (6379e76bf5) [core] - 10https://gerrit.wikimedia.org/r/136960 (owner: 10Jforrester) [00:55:03] 3MediaWiki-Vagrant: simple_performant file permission problem with NFS - 10https://bugzilla.wikimedia.org/66061 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3Ori Livneh With NFS, simple_performant errors with: err: /Stage[main]/Role::Simple_performant/File[/vagrant/mediawiki/skins/.htaccess]/owner:... [00:55:43] (03PS1) 10Mattflaschen: Remove unneeded source attribute (content used instead) [vagrant] - 10https://gerrit.wikimedia.org/r/136961 [00:56:09] (03PS2) 10Mattflaschen: Remove unneeded source attribute (content used instead) [vagrant] - 10https://gerrit.wikimedia.org/r/136961 (https://bugzilla.wikimedia.org/65922) [00:57:26] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (6379e76bf5) [core] - 10https://gerrit.wikimedia.org/r/136960 (owner: 10Jforrester) [00:59:35] (03PS1) 10Jack Phoenix: JSHinting [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/136962 [01:00:03] (03CR) 10Jack Phoenix: [C: 032 V: 032] JSHinting [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/136962 (owner: 10Jack Phoenix) [01:01:01] 3MediaWiki / 3Parser: Thumbnails should use a square bounding box by default - 10https://bugzilla.wikimedia.org/63903#c18 (10Tyler Romeo) (In reply to Rainer Rillke @commons.wikimedia from comment #16) > (In reply to Tyler Romeo from comment #15) > >Are there screenshots of the bug caused by the patch? > It... [01:01:37] (03PS4) 10Krinkle: ResourceLoaderFileModule: Implement remoteSkinPath option [core] - 10https://gerrit.wikimedia.org/r/136650 (owner: 10Daniel Friesen) [01:06:09] (03CR) 10Jforrester: "Fixme: The change to the 'primary' tab should be re-visited." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104182 (owner: 10TTO) [01:12:16] 3MediaWiki-Vagrant: simple_performant fails to provision with Apache-related error - 10https://bugzilla.wikimedia.org/65922#c7 (10Matthew Flaschen) Works fine, although I found bug 66061. [01:17:06] (03CR) 10Gergő Tisza: [C: 04-1] Generate thumbnails based on buckets (0315 comments) [core] - 10https://gerrit.wikimedia.org/r/135008 (owner: 10Gilles) [01:25:33] (03PS2) 10Spage: Mantle.php should not have to be loaded before Flow.php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/136945 (owner: 10Bsitu) [01:26:08] (03CR) 10Spage: [C: 032] "My PS2 was just English improvement." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/136945 (owner: 10Bsitu) [01:26:32] (03Merged) 10jenkins-bot: Mantle.php should not have to be loaded before Flow.php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/136945 (owner: 10Bsitu) [01:31:51] (03CR) 10Spage: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/133031 (https://bugzilla.wikimedia.org/65143) (owner: 10EBernhardson) [01:35:17] 3Wikimedia / 3Site requests: Create a channel on Wikimedia IRC that logs newly created/unified accounts on all wikis - 10https://bugzilla.wikimedia.org/15276 (10Melos) [01:35:18] 3Wikimedia / 3IRC: #central channel is down - 10https://bugzilla.wikimedia.org/66062 (10Melos) 3NEW p:3Unprio s:3major a:3None The IRC channel that logs newly created/unified accounts on all wikis (#central) is missed: [02:18:56] [][IRC.WIKIMEDIA.ORG] :No such channel Please restart it. [01:35:39] That's not good. [01:36:05] I fixed it before the bug was logged [01:36:14] * Gloria pets Reedy. [01:36:48] 3Wikimedia / 3IRC: #central channel is down - 10https://bugzilla.wikimedia.org/66062#c1 (10Sam Reed (reedy)) 5NEW>3RESO/FIX a:3Sam Reed (reedy) Already fixed before the bug was logged https://gerrit.wikimedia.org/r/136964 [01:38:16] Reedy: when will it be "rc-eqiad" ? [01:38:33] When it's actually announced it's going to be [01:39:06] It was explicitly changed from rc-eqiad to rc-pmtpa purely because people wouldn't likely know [01:39:23] It's amusing to use a regex with a hard coded name on a server where only one thing can talk [01:39:29] <^d> rc-yaseo or gtfo. [01:40:33] Well, private messages (to one user) can be sent by anyone. [01:40:40] https://gerrit.wikimedia.org/r/#/c/136755/ [01:41:15] Private messages aren't in #en.wikipedia [02:11:11] (03CR) 10TTO: Add extra views (tabs) for files in a foreign repository (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104182 (owner: 10TTO) [02:18:15] (03PS1) 10Jackmcbarn: Don't double-parse edit summaries [core] - 10https://gerrit.wikimedia.org/r/136967 [02:19:00] (03CR) 10Jackmcbarn: "Found a bug in this. See follow-up I3d7e70bb6d055184d36df35ef2e747ba32ad4ea0" [core] - 10https://gerrit.wikimedia.org/r/127442 (owner: 10Jackmcbarn) [02:27:49] (03PS5) 10Spage: Frontend-rewrite [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/136777 (owner: 10SG) [02:28:56] (03CR) 10Spage: "PS5 is a rebase on top of Makefile and Mantle dependency fixes merged to the frontend-rewrite branch." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/136777 (owner: 10SG) [03:08:52] is there a generic name for things like {{foo}} that encompasses both magic words and parser functions? [03:08:57] (and template calls) [03:10:28] Parser words. Template functions. Magic calls. [03:10:32] * Deskana shrugs. [03:10:34] I don't think there is. [03:13:10] (03PS4) 10Jackmcbarn: Add a tracking category for duplicate arguments [core] - 10https://gerrit.wikimedia.org/r/136123 [03:24:13] (03PS1) 10PleaseStand: Move QueryPage and abstract subclasses to specialpage folder [core] - 10https://gerrit.wikimedia.org/r/136970 (https://bugzilla.wikimedia.org/60445) [03:33:46] 3Wikimedia / 3Site requests: Add wiktionary to FeaturedFeedsWMF.php - 10https://bugzilla.wikimedia.org/66015#c5 (10Yusuke Matsubara) I'm inclined to the original "wotd" now. It turned out that the "wotd" messages already went for translation, and it doesn't make sense to abandon those translations. [03:36:01] 3MediaWiki / 3User preferences: Handle "Search" --> "Advanced options" section of Special:Preferences on Special:Search itself - 10https://bugzilla.wikimedia.org/52817#c35 (10MZMcBride) (In reply to Amgine from comment #21) > Sucks as UX. Do we really want every special page to be creating and > maintaining... [04:15:17] 3MediaWiki extensions / 3Popups: Hovercards popping up above cause flickering (because of popping up under the mouse cursor) - 10https://bugzilla.wikimedia.org/65433#c12 (10Prateek Saxena) (In reply to Quiddity from comment #10) > It's not consistent, and doesn't interfere with clicking - it's just > a sma... [04:39:40] (03PS2) 10Hiong3-eng5: Special Popup [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/135740 [04:39:44] (03CR) 10jenkins-bot: [V: 04-1] Special Popup [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/135740 (owner: 10Hiong3-eng5) [04:54:16] 3Wikimedia / 3Site requests: New England Wikimedians website - 10https://bugzilla.wikimedia.org/64557#c58 (10jeremyb) Status update? Do you still want a wiki to be created for New England? [04:58:23] (03CR) 10Ori.livneh: [C: 032] "Cool. This is still a bit clunky compared with the previous status quo of things "just working", but I think this is probably close to opt" [vagrant] - 10https://gerrit.wikimedia.org/r/136441 (https://bugzilla.wikimedia.org/65066) (owner: 10Dduvall) [04:58:29] (03Merged) 10jenkins-bot: Packaged plugin as gem to allow local installation [vagrant] - 10https://gerrit.wikimedia.org/r/136441 (https://bugzilla.wikimedia.org/65066) (owner: 10Dduvall) [04:59:42] (03PS3) 10Ori.livneh: Remove unneeded source attribute (content used instead) [vagrant] - 10https://gerrit.wikimedia.org/r/136961 (https://bugzilla.wikimedia.org/65922) (owner: 10Mattflaschen) [04:59:47] (03CR) 10Ori.livneh: [C: 032] Remove unneeded source attribute (content used instead) [vagrant] - 10https://gerrit.wikimedia.org/r/136961 (https://bugzilla.wikimedia.org/65922) (owner: 10Mattflaschen) [04:59:51] (03Merged) 10jenkins-bot: Remove unneeded source attribute (content used instead) [vagrant] - 10https://gerrit.wikimedia.org/r/136961 (https://bugzilla.wikimedia.org/65922) (owner: 10Mattflaschen) [05:03:47] 3Wikimedia / 3Wikidata: New statement not saving - 10https://bugzilla.wikimedia.org/65730#c2 (10daniel.jarratt) Perhaps it was a problem with my computer, though why I can't say. After a couple of days, and after restarting my machine, I could not replicate the bug either. I'm sure it wasn't just a browser i... [05:15:01] 3MediaWiki extensions / 3UniversalLanguageSelector: Change Sanskrit transliteration rules - 10https://bugzilla.wikimedia.org/63895#c47 (10NehalDaveND) Hi ! I think you updated script but we can't use that on sa.wikipedia.org so please guide us for implementation that script thank you....... [05:18:17] 3Wikimedia / 3Site requests: New England Wikimedians website - 10https://bugzilla.wikimedia.org/64557#c59 (10jeremyb) (In reply to jeremyb from comment #58) To elaborate, I was unsure exactly where we left it after your acquisition of your own second-level domain. (which you mentioned at the conference) Wi... [05:21:31] 3MediaWiki / 3User preferences: Handle "Search" --> "Advanced options" section of Special:Preferences on Special:Search itself - 10https://bugzilla.wikimedia.org/52817#c36 (10Amgine) Would those 'few users' happen to be the experienced wikimedians (like those who have piped up here)? the ones who know (well,... [05:24:00] (03CR) 10Mattflaschen: "I just wanted to note that I don't think we should put in much effort to support IE6." [core] - 10https://gerrit.wikimedia.org/r/125387 (owner: 10Pginer) [05:29:01] 3MediaWiki-Vagrant: simple_performant fails to provision with Apache-related error - 10https://bugzilla.wikimedia.org/65922 (10Matthew Flaschen) 5PATC>3RESO/FIX [05:36:04] (03CR) 10Nemo bis: "It's the same with last version because that's where files are put. Docs updated a bit: https://www.mediawiki.org/w/index.php?title=Manual" [vagrant] - 10https://gerrit.wikimedia.org/r/136814 (owner: 10Mattflaschen) [05:52:35] Hi, can someone give me an example of how to do mathematical calculation in a semantic query? [05:56:39] (03CR) 1001tonythomas: "@Hashar:- I thought https://gerrit.wikimedia.org/r/#/c/136732 fixed it. It currently validates composer.json file in core/ only ?" [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [05:59:16] 3Wikimedia / 3Site requests: Update logo for wikimediafoundation.org - 10https://bugzilla.wikimedia.org/66044#c7 (10Nemo) (In reply to Heather Walls from comment #5) > That is the major difference along with minor spacing differences around the > text. (That is, after the traditional colours have been resto... [06:04:07] (03CR) 10BryanDavis: "Conceptually MWLogger::registerProvider is a hook for bootstrap configuration of the logging system that doesn't depend on PHP global vari" [core] - 10https://gerrit.wikimedia.org/r/119940 (owner: 10BryanDavis) [06:08:16] 3Wikimedia / 3Site requests: Update logo for wikimediafoundation.org - 10https://bugzilla.wikimedia.org/66044#c8 (10Heather Walls) (Someone will have to explain to me why people who also would seem to prefer public domain, care so deeply about slight differences in color intended to make the logos work bette... [06:17:48] (03CR) 10Nemo bis: "Sure, we can move that check elsewhere; it was just kept here to reduce differences to the previous code." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/131727 (https://bugzilla.wikimedia.org/52817) (owner: 10Nemo bis) [06:20:45] 3Wikimedia / 3Site requests: Update logo for wikimediafoundation.org - 10https://bugzilla.wikimedia.org/66044#c9 (10Nemo) (In reply to Heather Walls from comment #8) > (Someone will have to explain to me why people who also would seem to prefer > public domain, care so deeply about slight differences in colo... [06:24:46] 3Wikimedia / 3Site requests: Update logo for wikimediafoundation.org - 10https://bugzilla.wikimedia.org/66044#c10 (10James Alexander) (In reply to Nemo from comment #9) > (In reply to Heather Walls from comment #8) > > (Someone will have to explain to me why people who also would seem to prefer > > public do... [06:26:30] 3Wikimedia / 3Site requests: Update logo for wikimediafoundation.org - 10https://bugzilla.wikimedia.org/66044#c11 (10Heather Walls) Thanks James, and everyone for your input. [06:27:06] (03PS1) 10Prtksxna: animation: Use the animation mixin in core and pass fill-mode as an argument [extensions/Popups] - 10https://gerrit.wikimedia.org/r/136975 (https://bugzilla.wikimedia.org/65923) [06:44:45] (03CR) 10BryanDavis: "Hashar's -2 is based on his work in progress (https://gerrit.wikimedia.org/r/#/c/136897/) to teach Jenkins how to clone the new mediawiki/" [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [06:52:32] 3MediaWiki / 3User preferences: Handle "Search" --> "Advanced options" section of Special:Preferences on Special:Search itself - 10https://bugzilla.wikimedia.org/52817#c37 (10billinghurst) (In reply to MZMcBride from comment #35) > (In reply to Amgine from comment #21) > > Sucks as UX. Do we really want ever... [06:52:45] (03CR) 10Tim Starling: Don't attempt to parse non-Modules in the console (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/124473 (owner: 10Jackmcbarn) [06:55:47] (03CR) 10Tim Starling: "Use case?" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/132730 (owner: 10Jackmcbarn) [06:57:01] 3MediaWiki / 3User preferences: Handle "Search" --> "Advanced options" section of Special:Preferences on Special:Search itself - 10https://bugzilla.wikimedia.org/52817#c38 (10Nemo) (In reply to billinghurst from comment #37) > my > issue is that Preferences = Preferences Too bad this assumption is incorrect... [07:02:40] (03CR) 10Hashar: "01tonythomas wrote:" [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [07:04:06] (03CR) 10Hashar: "We can not really use a ppa on the production box." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136897 (owner: 10Hashar) [07:18:25] Nemo_bis: Can I disturb you a little if you available. [07:20:08] apexkid1: if you believe I can help :) [07:20:43] Nemo_bis: I believe so. :) Can you suggest me somthing about how to do mathematical calculations in Semantic query? [07:24:05] well, I don't remember ever doing that [07:24:55] what did you try? [07:24:56] Nemo_bis: Well the case if that, suppose my one query returns a numeric result and another returns another numeric result and i want to add them [07:26:01] (03PS1) 10Hashar: multigit.sh: fix up workspace destination [integration/jenkins] - 10https://gerrit.wikimedia.org/r/136979 [07:26:02] 3MediaWiki extensions / 3WikidataRepo: make it possible to edit globecoordinates when precision does not match predefined precisions in the frontend - 10https://bugzilla.wikimedia.org/65535 (10Adrian Lang) [07:26:15] (03CR) 10Hashar: [C: 032] multigit.sh: fix up workspace destination [integration/jenkins] - 10https://gerrit.wikimedia.org/r/136979 (owner: 10Hashar) [07:26:16] 3MediaWiki extensions / 3WikidataRepo: make it possible to edit globecoordinates when precision does not match predefined precisions in the frontend - 10https://bugzilla.wikimedia.org/65535 (10Adrian Lang) [07:26:18] (03Merged) 10jenkins-bot: multigit.sh: fix up workspace destination [integration/jenkins] - 10https://gerrit.wikimedia.org/r/136979 (owner: 10Hashar) [07:26:31] 3MediaWiki extensions / 3WikidataRepo: Factor out inputextender usage and inputextender's widgets of experts - 10https://bugzilla.wikimedia.org/65770 (10Adrian Lang) [07:27:01] 3MediaWiki extensions / 3WikidataRepo: Factor out inputextender usage and inputextender's widgets of experts - 10https://bugzilla.wikimedia.org/65770 (10Adrian Lang) [07:27:01] 3MediaWiki extensions / 3WikidataRepo: make it possible to edit globecoordinates when precision does not match predefined precisions in the frontend - 10https://bugzilla.wikimedia.org/65535 (10Adrian Lang) [07:27:09] You can consider that I want to write a query that gives me the summation of two semantic property values... [07:27:17] 3MediaWiki extensions / 3WikidataRepo: Factor out inputextender usage and inputextender's widgets of experts - 10https://bugzilla.wikimedia.org/65770 (10Adrian Lang) [07:27:17] 3MediaWiki extensions / 3WikidataRepo: make it possible to edit globecoordinates when precision does not match predefined precisions in the frontend - 10https://bugzilla.wikimedia.org/65535 (10Adrian Lang) [07:32:10] since https://www.mediawiki.org/wiki/Manual:Developing_extensions#Localisation is outdated I wanted to get a code review for some localisation relevant changes in the math extension. For that reason I added the i10n group to the code reviewers. What is the expected waiting time to get a code review on that aspect? [07:33:23] I changed 9 lines in https://gerrit.wikimedia.org/r/#/c/135817/ [07:36:00] (03CR) 10Gilles: [C: 032] Max title length [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/134073 (https://bugzilla.wikimedia.org/65323) (owner: 10Dan-nl) [07:36:08] (03Merged) 10jenkins-bot: Max title length [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/134073 (https://bugzilla.wikimedia.org/65323) (owner: 10Dan-nl) [07:37:48] (03CR) 10Physikerwelt: "actually their group name is l10n;-)" [extensions/Math] - 10https://gerrit.wikimedia.org/r/135817 (owner: 10Physikerwelt) [07:44:51] (03PS1) 10Gilles: UploadWizard now passes QUnit, make it voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/136982 (https://bugzilla.wikimedia.org/65151) [07:51:27] (03PS1) 10Hashar: mw-set-env: set mediawiki to /src if exists [integration/jenkins] - 10https://gerrit.wikimedia.org/r/136984 [07:51:40] (03CR) 10Hashar: [C: 032] mw-set-env: set mediawiki to /src if exists [integration/jenkins] - 10https://gerrit.wikimedia.org/r/136984 (owner: 10Hashar) [07:51:43] (03Merged) 10jenkins-bot: mw-set-env: set mediawiki to /src if exists [integration/jenkins] - 10https://gerrit.wikimedia.org/r/136984 (owner: 10Hashar) [07:55:12] (03CR) 10Hashar: "recheck" [core/vendor] - 10https://gerrit.wikimedia.org/r/136475 (owner: 10BryanDavis) [07:57:27] (03PS2) 10Hashar: (WIP) Clone mediawiki/core with multigit (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136897 [07:59:57] (03CR) 10Hashar: [C: 032] "Oua! Congratulations :)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/136982 (https://bugzilla.wikimedia.org/65151) (owner: 10Gilles) [08:00:06] (03Merged) 10jenkins-bot: UploadWizard now passes QUnit, make it voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/136982 (https://bugzilla.wikimedia.org/65151) (owner: 10Gilles) [08:01:49] (03PS3) 10Hashar: (WIP) Clone mediawiki/core with multigit (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136897 [08:03:20] (03PS4) 10Hashar: (WIP) Clone mediawiki/core with multigit (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136897 [08:09:05] Nemo_bis: any suggestion? [08:14:31] 3MediaWiki / 3Installer: phpunit 4.0.17 Version.php not found - 10https://bugzilla.wikimedia.org/64597#c8 (10physikerwelt) It would be nice if someone could assign her/himself to work on this problem... the end of the year seems to be far now... but suddenly it will be very close;-) [08:17:46] 3MediaWiki / 3User preferences: Handle "Search" --> "Advanced options" section of Special:Preferences on Special:Search itself - 10https://bugzilla.wikimedia.org/52817#c39 (10Scott Martin) (In reply to Amgine from comment #36) > This sounds so much like a solution looking for a problem. It was 50/50 that yo... [08:19:37] (03PS3) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/134309 [08:23:08] (03CR) 10Gilles: [C: 04-1] Massive refactor (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [08:23:46] (03CR) 10Gilles: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [08:28:31] 3Wikimedia / 3General/Unknown: Don't use deprecated features removed in jQuery 1.9 (tracking) - 10https://bugzilla.wikimedia.org/65399 (10Adrian Lang) [08:28:33] 3MediaWiki extensions / 3UniversalLanguageSelector: attrName property on Event is not available in jQuery 1.9 - 10https://bugzilla.wikimedia.org/66064 (10Adrian Lang) 3NEW p:3Unprio s:3normal a:3None jquery.ime uses e.attrName: https://github.com/wikimedia/jquery.ime/blob/f3cf284c5d1f9c0022365dc99eb6... [08:28:34] (03CR) 10Gilles: Add global limit to PoolCounter (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135702 (https://bugzilla.wikimedia.org/65691) (owner: 10Gergő Tisza) [08:40:16] (03PS1) 10Hashar: multigit.sh: missing space in condition [integration/jenkins] - 10https://gerrit.wikimedia.org/r/136988 [08:40:29] (03CR) 10Hashar: [C: 032] multigit.sh: missing space in condition [integration/jenkins] - 10https://gerrit.wikimedia.org/r/136988 (owner: 10Hashar) [08:40:32] (03Merged) 10jenkins-bot: multigit.sh: missing space in condition [integration/jenkins] - 10https://gerrit.wikimedia.org/r/136988 (owner: 10Hashar) [08:42:16] 3MediaWiki extensions / 3UniversalLanguageSelector: Change Sanskrit transliteration rules - 10https://bugzilla.wikimedia.org/63895#c48 (10Andre Klapper) Patience and https://www.mediawiki.org/wiki/MediaWiki_1.24/Roadmap . [08:42:46] 3Wikimedia / 3Wikidata: New statement not saving - 10https://bugzilla.wikimedia.org/65730 (10Andre Klapper) 5UNCO>3RESO/WOR [08:43:07] (03PS3) 10Deepali: Improve UX in chapter dropdown menu for books with lots of chapters [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/136537 (https://bugzilla.wikimedia.org/51257) [08:43:11] (03CR) 10jenkins-bot: [V: 04-1] Improve UX in chapter dropdown menu for books with lots of chapters [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/136537 (https://bugzilla.wikimedia.org/51257) (owner: 10Deepali) [08:46:03] 3MediaWiki extensions / 3SemanticForms: Autoedit query string no longer working - 10https://bugzilla.wikimedia.org/66038 (10s7eph4n) a:5Yaron Koren>3s7eph4n [08:48:01] 3Wikimedia / 3Extension setup: FlaggedRevs for Norwegian (bokmål) Wikipedia - 10https://bugzilla.wikimedia.org/64726#c6 (10Andre Klapper) Dereckson / Reedy: Could somebody deploy this? [08:48:16] (03PS1) 10QChris: Add mediawiki/skins/Nostalgia [skins] - 10https://gerrit.wikimedia.org/r/136989 [08:52:01] 3MediaWiki / 3ContentHandler: Allow ContentHandler to transform content on import and export - 10https://bugzilla.wikimedia.org/65256 (10tobias.gritschacher) 5PATC>3RESO/FIX [09:02:03] 3MediaWiki extensions / 3UniversalLanguageSelector: attrName property on Event is not available in jQuery 1.9 - 10https://bugzilla.wikimedia.org/66064#c1 (10Santhosh Thottingal) 5NEW>3ASSI p:5Unprio>3Normal a:3Santhosh Thottingal Thanks for reporting. Upstream fix https://github.com/wikimedia/jquer... [09:02:41] (03PS5) 10Hashar: (WIP) Clone mediawiki/core with multigit (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136897 [09:12:01] 3MediaWiki / 3User preferences: Handle "Search" --> "Advanced options" section of Special:Preferences on Special:Search itself - 10https://bugzilla.wikimedia.org/52817#c40 (10Quiddity) I fall right in the middle of this disagreement. Here's some notes, and an idea. There are good reasons to have the search-... [09:24:01] 3MediaWiki extensions / 3WikidataRepo: check for issues with switch to jquery 1.11.1 - 10https://bugzilla.wikimedia.org/65521#c2 (10Adrian Lang) 5ASSI>3RESO/FIX Ran selenium and qunit tests with jQuery.migrate disabled, grepped for API usages mentioned in the 1.9 migration guide. [09:24:48] (03PS1) 10Hashar: Drop history of puppet related jobs after 90 days [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136992 (https://bugzilla.wikimedia.org/63936) [09:24:53] (03PS1) 10Hashar: Drop history of mw/core check jobs after 15 days [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136993 [09:26:19] (03PS1) 10Prtksxna: Add navbar [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/136994 [09:26:21] (03PS1) 10Prtksxna: Update bootstrap.css and Add bootstrap.js and jquery.js [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/136995 [09:26:23] (03PS1) 10Prtksxna: Add homepage mock [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/136996 [09:26:25] (03PS1) 10Prtksxna: Add privacy page [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/136997 [09:26:27] (03PS2) 10Hashar: Drop history of mw/core check jobs after 15 days [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136993 (https://bugzilla.wikimedia.org/63936) [09:30:16] 3MediaWiki / 3User preferences: Handle "Search" --> "Advanced options" section of Special:Preferences on Special:Search itself - 10https://bugzilla.wikimedia.org/52817#c41 (10Scott Martin) (In reply to Quiddity from comment #40) > I'm surprised that we don't already have a link to > [[Special:Preferences#mw-... [09:33:56] (03PS4) 10Deepali: Improve UX in chapter dropdown menu for books with lots of chapters [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/136537 (https://bugzilla.wikimedia.org/51257) [09:34:00] (03CR) 10jenkins-bot: [V: 04-1] Improve UX in chapter dropdown menu for books with lots of chapters [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/136537 (https://bugzilla.wikimedia.org/51257) (owner: 10Deepali) [09:38:18] 3Wikimedia / 3General/Unknown: Add Help namespace, and perhaps other documentation, to default search - 10https://bugzilla.wikimedia.org/66066 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Split from: (In reply to MZMcBride from bug 52817 comment #35) > If many users are customizing their search setting... [09:38:39] (03CR) 10Nemo bis: "Filed bug 66066." [core] - 10https://gerrit.wikimedia.org/r/132965 (owner: 10Chad) [09:40:16] 3MediaWiki / 3User preferences: Handle "Search" --> "Advanced options" section of Special:Preferences on Special:Search itself - 10https://bugzilla.wikimedia.org/52817#c42 (10Nemo) (In reply to Quiddity from bug 52817 comment #40) > Searching for help documentation is HELL unless we add the Wikipedia: , > He... [09:40:54] (03PS1) 10Physikerwelt: WIP: Wait until previous commit is merged... [extensions/Math] - 10https://gerrit.wikimedia.org/r/136998 (https://bugzilla.wikimedia.org/65973) [09:42:31] 3Wikimedia / 3General/Unknown: Add Help namespace, and perhaps other documentation, to default search - 10https://bugzilla.wikimedia.org/66066#c1 (10Nemo) Ah, for current "workarounds" see [[it:Aiuto:Aiuto]] and https://www.mediawiki.org/wiki/Thread:Extension_talk:InputBox/Search_profile [09:42:52] (03CR) 10jenkins-bot: [V: 04-1] WIP: Wait until previous commit is merged... [extensions/Math] - 10https://gerrit.wikimedia.org/r/136998 (https://bugzilla.wikimedia.org/65973) (owner: 10Physikerwelt) [09:47:25] (03PS4) 10Physikerwelt: Improve MathML error handling [extensions/Math] - 10https://gerrit.wikimedia.org/r/135817 [09:48:02] 3MediaWiki extensions / 3WikidataRepo: Implement Redirects in ItemContent - 10https://bugzilla.wikimedia.org/57744 (10Daniel Kinzler) [09:48:02] 3MediaWiki extensions / 3WikidataRepo: Support Redirects between Items (tracking) - 10https://bugzilla.wikimedia.org/66067 (10Daniel Kinzler) p:5Unprio>3High [09:48:46] 3MediaWiki extensions / 3WikidataRepo: Implement Redirects in ItemContent - 10https://bugzilla.wikimedia.org/57744 (10Daniel Kinzler) [09:48:46] 3MediaWiki extensions / 3WikidataRepo: Notify client wikis about entity pages being turned into redirects. - 10https://bugzilla.wikimedia.org/66029 (10Daniel Kinzler) [09:48:53] (03CR) 10jenkins-bot: [V: 04-1] Improve MathML error handling [extensions/Math] - 10https://gerrit.wikimedia.org/r/135817 (owner: 10Physikerwelt) [09:49:00] 3MediaWiki extensions / 3WikidataRepo: Support Redirects between Items (tracking) - 10https://bugzilla.wikimedia.org/66067 (10Daniel Kinzler) [09:58:33] 3Analytics / 3General/Unknown: Have s[23467] slave's name resolve to dbstore1002 - 10https://bugzilla.wikimedia.org/66068 (10christian) 3NEW p:3Unprio s:3normal a:3None To simplify analytics slave setup, springle suggested to move s[23467]-analytics-slave to the analytics-store machine. s3-analytics... [10:03:43] Hi, I am using the parser function #expr with #ask. When i used something like this {{#expr: #ask + 1 }} it works, but when I use {{#expr: #ask + #ask}}, it gives error. Both #ask return number. [10:04:08] Any explainations? [10:10:13] Extension:Popups tries to generate a hovercard on the "Cancel" link of VisualEditor. To ignore such buttons should I ignore ".oo-ui-buttonedElement-button" or would another approach be more appropriate? https://bugzilla.wikimedia.org/65442 [10:16:30] 3MediaWiki extensions / 3Popups: Popups: "mw.Api error: " "http" {xhr: Object, textStatus: "abort", exception: "abort"} - 10https://bugzilla.wikimedia.org/65442#c5 (10Prateek Saxena) Is it alright to ignore the ".oo-ui-buttonedElement-button" class to resolve the Cancel button issue or some other approach ne... [10:30:33] (03PS5) 10Physikerwelt: Improve MathML error handling [extensions/Math] - 10https://gerrit.wikimedia.org/r/135817 [10:38:54] (03CR) 10Bartosz Dziewoński: [C: 031] "Thanks!" [skins] - 10https://gerrit.wikimedia.org/r/136989 (owner: 10QChris) [10:39:11] ori: Can you help me a little with #expr parser function? [10:40:01] 3Wikimedia / 3lucene-search-2: Search index not updating on en.wikipedia - 10https://bugzilla.wikimedia.org/66011#c5 (10Nemo) 5NEW>3RESO/WON Yes, there are some bugs, which will be solved. Cf. https://www.mediawiki.org/wiki/Thread:Talk:Search/LiquidThreads_archive/%27Old_search%27_is_better (In reply to... [11:20:18] 3MediaWiki extensions / 3WikidataClient: Use hook for customized formatting of enhanced recent changes - 10https://bugzilla.wikimedia.org/66069 (10tobias.gritschacher) p:5Unprio>3High [11:20:32] 3MediaWiki / 3Recent changes: Enhanced Recent Changes needs hook(s) for customised formatting, similar to OldChangesListRecentChangesLine hook - 10https://bugzilla.wikimedia.org/53851 (10tobias.gritschacher) [11:34:46] (03CR) 10Scott Martin: "We might want to hold back on this given the new discussion happening on bug 52817." [core] - 10https://gerrit.wikimedia.org/r/131727 (https://bugzilla.wikimedia.org/52817) (owner: 10Nemo bis) [11:35:25] (03CR) 10Nemo bis: "No." [core] - 10https://gerrit.wikimedia.org/r/131727 (https://bugzilla.wikimedia.org/52817) (owner: 10Nemo bis) [11:38:46] (03CR) 10Scott Martin: "You're a charmer, aren't you?" [core] - 10https://gerrit.wikimedia.org/r/131727 (https://bugzilla.wikimedia.org/52817) (owner: 10Nemo bis) [11:40:49] 3Wikimedia / 3Wikidata: Provide config for dispatch-lag-monitoring script - 10https://bugzilla.wikimedia.org/66070 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs (1) Make sure WMF get's notified (e.g. on IRC (ops) or on ICINGA dashboard). (2) Send E-Mail to wikidata-monitoring@wiki... [11:41:31] 3Wikimedia / 3Wikidata: monitor dispatch stats - 10https://bugzilla.wikimedia.org/65291 (10tobias.gritschacher) [11:41:32] 3Wikimedia / 3Wikidata: Provide config for dispatch-lag-monitoring script - 10https://bugzilla.wikimedia.org/66070 (10tobias.gritschacher) p:5Unprio>3High [11:42:30] (03CR) 10Nemo bis: "Sometimes." [core] - 10https://gerrit.wikimedia.org/r/131727 (https://bugzilla.wikimedia.org/52817) (owner: 10Nemo bis) [11:45:08] (03PS1) 10Nemo bis: Simplify check for namespaces in search preferences [core] - 10https://gerrit.wikimedia.org/r/137005 [11:45:51] (03PS2) 10Nemo bis: Simplify check for namespaces in search preferences [core] - 10https://gerrit.wikimedia.org/r/137005 [11:47:04] (03CR) 10Nemo bis: "Per Krinkle in https://gerrit.wikimedia.org/r/#/c/131727/14 ; can otherwise use and adjust SearchEngine::searchableNamespaces() output." [core] - 10https://gerrit.wikimedia.org/r/137005 (owner: 10Nemo bis) [11:49:12] (03CR) 10Nemo bis: "Followup at Icad951fb9a4c4cb368cd994d1861dc2eff1f4ae0" [core] - 10https://gerrit.wikimedia.org/r/131727 (https://bugzilla.wikimedia.org/52817) (owner: 10Nemo bis) [11:50:48] 3MediaWiki extensions / 3WikidataRepo: Investigate timeouts during selenium tests on beta - 10https://bugzilla.wikimedia.org/66071 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Selenium tests are currently failing randomly. Sometimes with the message that the wiki "is in read-only... [11:51:17] 3MediaWiki extensions / 3WikidataRepo: Investigate timeouts during selenium tests on beta - 10https://bugzilla.wikimedia.org/66071 (10tobias.gritschacher) p:5Unprio>3High s:5normal>3major [11:53:16] 3MediaWiki extensions / 3WikidataRepo: Install Scribuntu on wikidata jenkins - 10https://bugzilla.wikimedia.org/66072 (10tobias.gritschacher) p:5Unprio>3High [12:06:31] 3MediaWiki extensions / 3WikidataRepo: Support Redirects between Items (tracking) - 10https://bugzilla.wikimedia.org/66067 (10Daniel Kinzler) [12:06:31] 3MediaWiki extensions / 3WikidataRepo: Allow redirects to be created via EntityStore - 10https://bugzilla.wikimedia.org/66073 (10Daniel Kinzler) p:5Unprio>3Normal [12:08:02] 3MediaWiki extensions / 3WikidataRepo: make change notifications and usage tracking work for redirects - 10https://bugzilla.wikimedia.org/65595 (10Daniel Kinzler) [12:08:02] 3MediaWiki extensions / 3WikidataRepo: Automatically create redirects when merging items - 10https://bugzilla.wikimedia.org/57745 (10Daniel Kinzler) [12:08:02] 3MediaWiki extensions / 3WikidataRepo: Support Redirects between Items (tracking) - 10https://bugzilla.wikimedia.org/66067 (10Daniel Kinzler) [12:10:17] 3MediaWiki extensions / 3WikidataRepo: Finish up implementation of Wikibase Serialization - 10https://bugzilla.wikimedia.org/64299 (10Lydia Pintscher) 5ASSI>3RESO/FIX [12:12:16] 3Wikimedia / 3Wikidata: monitor dispatch stats - 10https://bugzilla.wikimedia.org/65291 (10Lydia Pintscher) 5PATC>3RESO/FIX [12:13:03] 3MediaWiki extensions / 3WikidataRepo: track entity redirects in database table - 10https://bugzilla.wikimedia.org/66074 (10Daniel Kinzler) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Item redirects should be tracked in the entity_per_page table: if Q123 is a redirect to Q77, the EPP table should conne... [12:13:17] 3MediaWiki extensions / 3WikidataRepo: track entity redirects in database table - 10https://bugzilla.wikimedia.org/66074 (10Daniel Kinzler) [12:13:17] 3MediaWiki extensions / 3WikidataRepo: Support Redirects between Items (tracking) - 10https://bugzilla.wikimedia.org/66067 (10Daniel Kinzler) [12:15:17] 3Wikimedia / 3Site requests: Please add: ftp://sitelftp.unine.ch/ to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/65766#c6 (10Tomasz W. Kozlowski) CC-ing Emmanuel Engelhart of Wikimedia CH who might be able to help with the copying part. [12:18:46] 3MediaWiki extensions / 3WikidataRepo: make WikiPageEntityLookup optionaly resolve redirects - 10https://bugzilla.wikimedia.org/66075 (10Daniel Kinzler) [12:19:01] 3MediaWiki extensions / 3WikidataRepo: Support Redirects between Items (tracking) - 10https://bugzilla.wikimedia.org/66067 (10Daniel Kinzler) [12:31:16] 3Wikimedia / 3Site requests: Please add: ftp://sitelftp.unine.ch/ to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/65766#c7 (10Kelson [Emmanuel Engelhart]) @Rromir please ask the Unine IT department if the data available in FTP are also available via HTTP. If not try to get it. Movin... [12:39:31] 3Wikimedia / 3Site requests: Please add: ftp://sitelftp.unine.ch/ to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/65766#c8 (10This, that and the other) As best I can tell there is only about 800 MB worth of data, unless I'm looking in the wrong place... [13:01:43] (03PS1) 10QChris: As Geowiki now passes flake8, make it voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/137010 [13:02:16] 3MediaWiki / 3User preferences: Handle "Search" --> "Advanced options" section of Special:Preferences on Special:Search itself - 10https://bugzilla.wikimedia.org/52817#c43 (10MZMcBride) (In reply to billinghurst from comment #37) > Nobody has argued about sensible defaults, nor the ability for communities >... [13:02:59] (03Abandoned) 10Mwjames: Inserted test whether the resource 'uploadsource' is already registered. Bug: 65530 [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/134590 (https://bugzilla.wikimedia.org/65530) (owner: 10Mwjames) [13:10:01] 3Wikimedia / 3Site requests: Update logo for wikimediafoundation.org - 10https://bugzilla.wikimedia.org/66044#c12 (10MZMcBride) (In reply to James Alexander from comment #10) > (Mostly Note to show that I've seen this and will take a look about changing > things tomorrow when I'm at the office, probably in t... [13:11:01] 3Wikimedia / 3Site requests: Update logo for wikimediafoundation.org - 10https://bugzilla.wikimedia.org/66044#c13 (10MZMcBride) Created attachment 15556 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15556&action=edit Current logo in use at wikimediafoundation.org, 2014 [13:12:16] 3Wikimedia / 3Site requests: Update logo for wikimediafoundation.org - 10https://bugzilla.wikimedia.org/66044#c14 (10MZMcBride) Created attachment 15557 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15557&action=edit Proposed logo for use at wikimediafoundation.org, 2014 [13:12:43] (03CR) 10Paladox: "hi I have tested it on the iPhone 5s as I have one and my own wiki with the latest mediawiki wiki software version 1.24 wmf 7 and iPhone r" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/132603 (https://bugzilla.wikimedia.org/63277) (owner: 10TheDJ) [13:13:20] (03CR) 10Paladox: "but I carnt test it on ios 6 due to me upgraded all my stuff to ios 7" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/132603 (https://bugzilla.wikimedia.org/63277) (owner: 10TheDJ) [13:14:01] 3MediaWiki extensions / 3WikidataRepo: Review all uses of EntityContent::getEntity() - 10https://bugzilla.wikimedia.org/66030#c1 (10Lydia Pintscher) expected result: * simple calls are changed * separate tickets are filed for complex cases [13:14:46] 3MediaWiki extensions / 3WikidataRepo: Review all uses of EntityContent::getEntity() - 10https://bugzilla.wikimedia.org/66030 (10Lydia Pintscher) [13:19:01] 3MediaWiki extensions / 3WikidataRepo: Untangle DataUpdates to be applied when editing or deleting an Entity - 10https://bugzilla.wikimedia.org/66028#c1 (10Lydia Pintscher) remaining task: test that the necessary data updates are performed when an entity is saved [13:22:03] (03CR) 10Hashar: "recheck" [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/114439 (owner: 10Rcdeboer) [13:31:46] 3MediaWiki extensions / 3WikidataRepo: Introduce EntityContentDiff class - 10https://bugzilla.wikimedia.org/66026 (10Lydia Pintscher) 5PATC>3ASSI [13:32:16] 3MediaWiki extensions / 3WikidataRepo: Introduce EntityContentDiff class - 10https://bugzilla.wikimedia.org/66026 (10Lydia Pintscher) 5ASSI>3PATC [13:33:16] 3MediaWiki extensions / 3WikidataRepo: Factor entity content serialization out of EntityContent (and friends) - 10https://bugzilla.wikimedia.org/66024 (10Lydia Pintscher) [13:33:28] (03PS1) 10Manybubbles: [maven-release-plugin] prepare release experimental-0.0.10 [search/highlighter] - 10https://gerrit.wikimedia.org/r/137012 [13:33:30] (03PS1) 10Manybubbles: [maven-release-plugin] prepare for next development iteration [search/highlighter] - 10https://gerrit.wikimedia.org/r/137013 [13:33:33] (03PS1) 10Manybubbles: Docs update [search/highlighter] - 10https://gerrit.wikimedia.org/r/137014 [13:33:36] (03CR) 10Manybubbles: [C: 032 V: 032] [maven-release-plugin] prepare release experimental-0.0.10 [search/highlighter] - 10https://gerrit.wikimedia.org/r/137012 (owner: 10Manybubbles) [13:33:48] (03CR) 10Manybubbles: [C: 032 V: 032] [maven-release-plugin] prepare for next development iteration [search/highlighter] - 10https://gerrit.wikimedia.org/r/137013 (owner: 10Manybubbles) [13:34:06] (03CR) 10Manybubbles: [C: 032 V: 032] Docs update [search/highlighter] - 10https://gerrit.wikimedia.org/r/137014 (owner: 10Manybubbles) [13:34:39] (03Abandoned) 10Raylton P. Sousa: Set default value of $wgBookManagerv2ChapterList to false. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/135422 (owner: 10Deepali) [13:35:31] 3Wikimedia / 3Site requests: Please add: ftp://sitelftp.unine.ch/ to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/65766#c9 (10charles andres) For the tlong term strategy, more than 120 000 pictures, we will need to let the pictures at the unine, I asked to activate http [13:39:16] (03CR) 10Microchip08: "The ?uselang= param would still remain." [extensions/StickToThatLanguage] - 10https://gerrit.wikimedia.org/r/136624 (owner: 10Microchip08) [13:41:15] 3Wikimedia / 3General/Unknown: Add Help namespace, and perhaps other documentation, to default search - 10https://bugzilla.wikimedia.org/66066#c2 (10Chad H.) (In reply to Nemo from comment #0) > That tab was removed: https://gerrit.wikimedia.org/r/#/c/132965/1 Which > makes sense for most MediaWiki installat... [13:42:41] (03CR) 10Manybubbles: [C: 031] Power Special:Random from Elasticsearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/133606 (https://bugzilla.wikimedia.org/65366) (owner: 10Chad) [13:45:16] 3Wikimedia / 3Wikidata: Provide config for dispatch-lag-monitoring script - 10https://bugzilla.wikimedia.org/66070#c1 (10Lydia Pintscher) clarification: critical warning for lag bigger than 15 minutes and warning on IRC for lag bigger than 2 minutes. [13:45:31] 3Wikimedia / 3Wikidata: Provide config for dispatch-lag-monitoring script - 10https://bugzilla.wikimedia.org/66070#c2 (10Lydia Pintscher) The lag that needs to be monitored is the median lag. [13:48:16] 3Wikimedia / 3Wikidata: monitor dispatch stats - 10https://bugzilla.wikimedia.org/65291#c3 (10Lydia Pintscher) 5RESO/FIX>3REOP We need to add a warning threshold at a median lag of 2 minutes. [13:49:01] 3Analytics / 3General/Unknown: Daily aggregates of hourly webstatscollector files missing since 2014-05-08 - 10https://bugzilla.wikimedia.org/65627#c2 (10christian) New files until 2014-06-02 are available again. But the situation around the rsync is not yet clear, so leaving the bug open for now. [13:50:46] (03CR) 10TheDJ: "I admit that it isn't perfect, but especially on an iPad it works just fine and on my iphone ios6 and ios7 devices (especially retina and " [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/132603 (https://bugzilla.wikimedia.org/63277) (owner: 10TheDJ) [13:52:04] (03PS1) 10Hashar: (WIP) Dummy parser tests (WIP) [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/137015 [13:53:31] (03CR) 10jenkins-bot: [V: 04-1] (WIP) Dummy parser tests (WIP) [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/137015 (owner: 10Hashar) [13:54:16] 3MediaWiki extensions / 3SemanticForms: Autoedit query string no longer working - 10https://bugzilla.wikimedia.org/66038#c1 (10Neill Mitchell) 5NEW>3RESO/INV Did a fresh git clone on a clean MW install and it works. So it looks like this was something with either the MW install or the specific SF versio... [13:55:02] 3Analytics / 3General/Unknown: geowiki data for 2014-05-18 too low/missing for some wikis - 10https://bugzilla.wikimedia.org/65598#c2 (10christian) 5NEW>3RESO/FIX Springle said to up the connection limits for geowiki, and we haven't seen the problem surface again, so it seems to have done the trick. Tha... [13:56:00] (03PS2) 10Hashar: (WIP) Dummy parser tests (WIP) [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/137015 [13:56:46] 3Wikimedia / 3Wikidata: Provide config for dispatch-lag-monitoring script - 10https://bugzilla.wikimedia.org/66070 (10Lydia Pintscher) [14:00:01] 3MediaWiki extensions / 3SemanticForms: Autoedit query string no longer working - 10https://bugzilla.wikimedia.org/66038#c2 (10s7eph4n) Awesome. Only eight to go. On autoedit anyway. [14:01:06] (03PS3) 10Hashar: Introduce a basic parser tests [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/137015 [14:01:31] 3MediaWiki extensions / 3WikidataRepo: Install Scribuntu on wikidata jenkins - 10https://bugzilla.wikimedia.org/66072 (10Lydia Pintscher) [14:01:35] (03CR) 10Physikerwelt: "I'm curious if the i10n team actually want's to review this change? Maybe we can just merge it." [extensions/Math] - 10https://gerrit.wikimedia.org/r/135817 (owner: 10Physikerwelt) [14:02:40] (03CR) 10Hashar: "Hello, I have added a basic parser test with https://gerrit.wikimedia.org/r/#/c/137015/ you might want to rebase your change on top of it" [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/114439 (owner: 10Rcdeboer) [14:07:31] 3Wikimedia / 3General/Unknown: Add Help namespace, and perhaps other documentation, to default search - 10https://bugzilla.wikimedia.org/66066#c3 (10Nemo) (In reply to Chad H. from comment #2) > (In reply to Nemo from comment #0) > > That tab was removed: https://gerrit.wikimedia.org/r/#/c/132965/1 Which > >... [14:11:42] (03PS2) 10Paladox: add support for request account link and renames login/create account to login [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/134624 [14:15:27] (03CR) 10Raimond Spekking: [C: 04-1] Implemented changes for translatewiki (032 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/134087 (owner: 10Smuggli) [14:15:32] 3MediaWiki extensions / 3WikidataRepo: UI for Simple Query - 10https://bugzilla.wikimedia.org/55593 (10tobias.gritschacher) [14:15:46] 3MediaWiki extensions / 3WikibaseQueryEngine: Add DVHandler for Time values - 10https://bugzilla.wikimedia.org/63476 (10tobias.gritschacher) [14:15:47] 3MediaWiki extensions / 3WikidataRepo: Implement Redirects in ItemContent - 10https://bugzilla.wikimedia.org/57744 (10tobias.gritschacher) [14:16:02] 3MediaWiki extensions / 3WikidataRepo: Use ExceptionLocalizer for error reporting on special pages - 10https://bugzilla.wikimedia.org/64307 (10tobias.gritschacher) [14:16:02] 3MediaWiki extensions / 3WikidataRepo: UI for monolingual text datatype - 10https://bugzilla.wikimedia.org/64290 (10tobias.gritschacher) [14:16:03] 3MediaWiki extensions / 3WikidataRepo: Decrease suggester/entityselector widget complexity - 10https://bugzilla.wikimedia.org/64427 (10tobias.gritschacher) [14:16:16] 3MediaWiki extensions / 3WikidataRepo: Install Entity Suggester on the Wikidata Demo system - 10https://bugzilla.wikimedia.org/64956 (10tobias.gritschacher) [14:16:17] 3MediaWiki extensions / 3WikidataRepo: Install default gadgets from wikidata.org on the test system (beta) - 10https://bugzilla.wikimedia.org/64998 (10tobias.gritschacher) [14:16:31] 3MediaWiki extensions / 3WikidataRepo: do not link deleted items - show text note instead - 10https://bugzilla.wikimedia.org/65002 (10tobias.gritschacher) [14:16:32] 3MediaWiki extensions / 3WikidataRepo: make it possible to edit globecoordinates when precision does not match predefined precisions in the frontend - 10https://bugzilla.wikimedia.org/65535 (10tobias.gritschacher) [14:16:46] 3MediaWiki extensions / 3WikidataRepo: Factor out inputextender usage and inputextender's widgets of experts - 10https://bugzilla.wikimedia.org/65770 (10tobias.gritschacher) [14:18:01] 3MediaWiki extensions / 3WikidataRepo: review backend part of entity suggester (php code) - 10https://bugzilla.wikimedia.org/63224#c4 (10tobias.gritschacher) Review is done from Wikidata-Team side. Pending WMF review now. [14:18:16] 3MediaWiki extensions / 3WikidataRepo: review backend part of entity suggester (python code) - 10https://bugzilla.wikimedia.org/63368#c2 (10tobias.gritschacher) Review is done from Wikidata-Team side. Pending WMF review now. [14:21:46] 3MediaWiki extensions / 3WikidataRepo: Review all uses of EntityContent::getEntity() - 10https://bugzilla.wikimedia.org/66030 (10tobias.gritschacher) 5NEW>3ASSI [14:25:31] 3Wikimedia / 3Wikidata: Provide config for dispatch-lag-monitoring script - 10https://bugzilla.wikimedia.org/66070 (10tobias.gritschacher) 5NEW>3ASSI [14:25:32] 3MediaWiki extensions / 3WikidataRepo: Install Scribuntu on wikidata jenkins - 10https://bugzilla.wikimedia.org/66072 (10tobias.gritschacher) 5NEW>3ASSI [14:30:54] (03CR) 10Umherirrender: "I have not tested, but looks like this would break edit pages which was open before the update and will submitted after the update." [core] - 10https://gerrit.wikimedia.org/r/134047 (owner: 10Awight) [14:34:06] (03CR) 10Umherirrender: "To keep customized messages alive you should only remove the $1 from the english message and keep the parameter on the js site. qqq can ge" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/136831 (owner: 10Thiemo Mättig (WMDE)) [14:38:07] (03CR) 10Umherirrender: "I prefer no of the both words, but after merge you should also change it on https://translatewiki.net/w/i.php?language=de&module=words&tit" [core] - 10https://gerrit.wikimedia.org/r/136861 (owner: 10Thiemo Mättig (WMDE)) [14:40:36] (03CR) 10Anomie: [C: 04-1] "I see this is a WIP, but I see some fundamental problems you'll need to take care of." (038 comments) [core] - 10https://gerrit.wikimedia.org/r/94584 (owner: 10Awight) [14:41:12] (03CR) 10Umherirrender: [C: 031] "Untested, but looks good" [core] - 10https://gerrit.wikimedia.org/r/136786 (owner: 10PleaseStand) [14:43:33] 3MediaWiki extensions / 3PageImages: Provide a way for editors to specify the page image - 10https://bugzilla.wikimedia.org/66077 (10Yusuke Matsubara) 3NEW p:3Unprio s:3normal a:3None It would be better to allow editors to control which image is used, overriding the automatically extracted one. Some... [14:49:43] (03CR) 10Physikerwelt: [C: 031] "Looks good to me...However, I had the feeling that most of the people would prefer a json format for the tests cases." [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/137015 (owner: 10Hashar) [15:01:42] (03CR) 10Hashar: [C: 032] As Geowiki now passes flake8, make it voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/137010 (owner: 10QChris) [15:01:59] (03Merged) 10jenkins-bot: As Geowiki now passes flake8, make it voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/137010 (owner: 10QChris) [15:14:51] (03PS1) 10Anomie: Update MultimediaViewer to Ibe6c11a9 [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137022 [15:15:16] (03CR) 10Anomie: [C: 032] "SWAT deploy" [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137022 (owner: 10Anomie) [15:16:24] (03CR) 10Raimond Spekking: [C: 032 V: 032] Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/134309 (owner: 10Smuggli) [15:20:08] (03Merged) 10jenkins-bot: Update MultimediaViewer to Ibe6c11a9 [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137022 (owner: 10Anomie) [15:21:02] 3MediaWiki / 3User preferences: Handle "Search" --> "Advanced options" section of Special:Preferences on Special:Search itself - 10https://bugzilla.wikimedia.org/52817#c44 (10Amgine) > It was 50/50 that you were going to say that. The other option was "if it ain't > broke don't fix it". Both are useless clic... [15:22:30] (03PS1) 10Hashar: multigit.sh: replace WORKSPACE with BASE_DIR [integration/jenkins] - 10https://gerrit.wikimedia.org/r/137024 [15:22:33] (03CR) 10jenkins-bot: [V: 04-1] multigit.sh: replace WORKSPACE with BASE_DIR [integration/jenkins] - 10https://gerrit.wikimedia.org/r/137024 (owner: 10Hashar) [15:22:39] (03CR) 10Hashar: [C: 032] multigit.sh: replace WORKSPACE with BASE_DIR [integration/jenkins] - 10https://gerrit.wikimedia.org/r/137024 (owner: 10Hashar) [15:22:42] (03Merged) 10jenkins-bot: multigit.sh: replace WORKSPACE with BASE_DIR [integration/jenkins] - 10https://gerrit.wikimedia.org/r/137024 (owner: 10Hashar) [15:33:07] (03CR) 10Jackmcbarn: "I see two reasons: one is to eliminate unnecessary calls to frame:callParserFunction, and the other is to allow a module like https://en.w" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/132730 (owner: 10Jackmcbarn) [15:49:33] 3Analytics / 3Wikistats: ipv6 addresses are mistaken for registered users - 10https://bugzilla.wikimedia.org/66079 (10Erik Zachte) 3NEW p:3Unprio s:3normal a:3None see http://infodisiac.com/blog/2014/06/reassessment-of-active-editors/ [15:49:46] 3Analytics / 3Wikistats: ipv6 addresses are mistaken for registered users - 10https://bugzilla.wikimedia.org/66079 (10Erik Zachte) 5NEW>3ASSI p:5Unprio>3Highes s:5normal>3major [15:51:02] 3Wikimedia / 3Site requests: New England Wikimedians website - 10https://bugzilla.wikimedia.org/64557#c60 (10Kevin Rutherford) Please place a hold on this, as we are currently discussing another option that would be more palatable to our tastes, partly due to the amount of discussion that has gone on here an... [15:51:31] 3MediaWiki / 3User preferences: Handle "Search" --> "Advanced options" section of Special:Preferences on Special:Search itself - 10https://bugzilla.wikimedia.org/52817#c45 (10Amgine) (In reply to MZMcBride from comment #43) > My gut feeling is that the real, underlying issue here is that you, me, and > othe... [15:52:21] (03PS14) 10Gilles: Generate thumbnails based on buckets [core] - 10https://gerrit.wikimedia.org/r/135008 [15:53:29] (03CR) 10jenkins-bot: [V: 04-1] Generate thumbnails based on buckets [core] - 10https://gerrit.wikimedia.org/r/135008 (owner: 10Gilles) [16:00:57] (03CR) 10Anomie: [C: 032] Don't double-parse edit summaries [core] - 10https://gerrit.wikimedia.org/r/136967 (owner: 10Jackmcbarn) [16:01:51] (03CR) 10Gilles: Generate thumbnails based on buckets (0315 comments) [core] - 10https://gerrit.wikimedia.org/r/135008 (owner: 10Gilles) [16:03:13] (03CR) 10Jackmcbarn: Don't attempt to parse non-Modules in the console (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/124473 (owner: 10Jackmcbarn) [16:04:00] (03Merged) 10jenkins-bot: Don't double-parse edit summaries [core] - 10https://gerrit.wikimedia.org/r/136967 (owner: 10Jackmcbarn) [16:04:12] (03PS1) 10Yurik: Refactorings, validators, [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/137032 [16:06:23] (03PS1) 10SPQRobin: Improve page language functions [core] - 10https://gerrit.wikimedia.org/r/137033 [16:06:32] 3MediaWiki extensions / 3PageImages: Provide a way for editors to specify the page image - 10https://bugzilla.wikimedia.org/66077 (10Andre Klapper) s:5normal>3enhanc [16:06:57] (03PS1) 10Yurik: Minor comment fix [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/137034 [16:09:50] (03PS3) 10Krinkle: Remove obsolete filter for negative namespace ids in search preferences [core] - 10https://gerrit.wikimedia.org/r/137005 (owner: 10Nemo bis) [16:10:03] (03PS15) 10Gilles: Generate thumbnails based on buckets [core] - 10https://gerrit.wikimedia.org/r/135008 [16:10:07] (03PS4) 10Krinkle: Remove redundant filter for negative namespace ids in search preferences [core] - 10https://gerrit.wikimedia.org/r/137005 (owner: 10Nemo bis) [16:10:20] (03CR) 10Krinkle: [C: 031] Remove redundant filter for negative namespace ids in search preferences [core] - 10https://gerrit.wikimedia.org/r/137005 (owner: 10Nemo bis) [16:10:59] (03CR) 10jenkins-bot: [V: 04-1] Improve page language functions [core] - 10https://gerrit.wikimedia.org/r/137033 (owner: 10SPQRobin) [16:11:06] (03CR) 10Chad: [C: 032] Remove redundant filter for negative namespace ids in search preferences [core] - 10https://gerrit.wikimedia.org/r/137005 (owner: 10Nemo bis) [16:11:31] 3Wikimedia / 3Site requests: Links with language variants can't automatically jump to mobile sites - 10https://bugzilla.wikimedia.org/51753#c6 (10Liangent) *** Bug 66080 has been marked as a duplicate of this bug. *** [16:11:59] (03CR) 10Chad: [C: 032] Fixed type hint [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/136478 (owner: 10Aaron Schulz) [16:13:16] (03CR) 10Chad: [C: 032] Remove for a feature no longer in mediawiki [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/136757 (owner: 10Manybubbles) [16:14:20] (03Merged) 10jenkins-bot: Fixed type hint [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/136478 (owner: 10Aaron Schulz) [16:14:24] (03Merged) 10jenkins-bot: Remove for a feature no longer in mediawiki [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/136757 (owner: 10Manybubbles) [16:17:19] (03Merged) 10jenkins-bot: Remove redundant filter for negative namespace ids in search preferences [core] - 10https://gerrit.wikimedia.org/r/137005 (owner: 10Nemo bis) [16:18:03] <^d> Krinkle: So I poked around bug 65803 yesterday (regression with the weird normalized version showing up in *some* results on nlwiki). I wasn't able to replicate locally or outside of any of the few pages you see it on nlwiki on. [16:18:05] (03PS2) 10Jackmcbarn: Don't attempt to parse non-Modules in the console [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/124473 [16:18:13] <^d> Interestingly, a null edit fixed the broken entries. [16:18:15] (03PS3) 10Jackmcbarn: Don't attempt to parse non-Modules in the console [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/124473 [16:18:16] 3MediaWiki extensions / 3Scribunto: Get and use the user language to help to maintain a module or a template - 10https://bugzilla.wikimedia.org/66051#c3 (10Brad Jorsch) p:5Low>3Lowest Bottom line: this isn't going to happen unless the feature requested in bug 2085 gets implemented, for all the reasons th... [16:18:17] 3MediaWiki / 3Internationalization: Add a {{USERLANGUAGE}}/{{USERLANG}} magic word - 10https://bugzilla.wikimedia.org/2085 (10Brad Jorsch) [16:18:36] <^d> So I'm thinking it's actually fixed :) [16:19:56] does anyone have access to poke around the beta cluster? [17:00:03] how do i make it so that all patches in a specific repo auto-add me in gerrit? [17:00:04] jackmcbarn, I have deployment-prep access, yeah [17:00:04] Krenair: can you look to see why the localization caches are out of date on beta-hhvm (and not beta)? compare http://en.wikipedia.beta-hhvm.wmflabs.org/w/index.php?title=0.7997676714091358_Moved&oldid=69037 and http://en.wikipedia.beta.wmflabs.org/w/index.php?title=0.7997676714091358_Moved&oldid=69037 [17:00:04] ^d: the best thing about Cirrus is that a null edit is enough to test last code in production :) [17:00:04] <^d> :) [17:00:04] As opposed to fixing something in lsearchd and then going "Ok let's see in few years from now when the index is maybe clean" [17:00:05] jackmcbarn, hm... no too familiar with the l10n cache or hhvm [17:00:05] <^d> You forgot the 6 month process of building a new package and getting it deployed. [17:00:05] <^d> :p [17:00:05] jackmcbarn, also those pages are still loading for me :/ [17:00:05] heh, right [17:00:05] Krenair: look at the red bar on them [17:00:05] There is no red bar [17:00:05] One is 500 Internal Server Error, the other has not yet loaded [17:00:05] hmm, they worked a second ago [17:00:05] anyway, that's even worse i guess [17:00:06] ^d: Okay, I'll ignore it for now then. I guess it was just a bad index. [17:00:06] ^d: Do those index entries expire eventually? (like our parser cache expires after 30 days even if there were no edits) [17:00:06] <^d> No, they stay the same until edit (or null edit) or someone kicks off the reindexer script. [17:00:06] <^d> Nik was going to reindex all of nlwiki. [17:00:06] ^d: even ?action=purge [17:00:06] <^d> Actually, we might. [17:00:06] <^d> On that. [17:00:06] <^d> Anything that triggers RefreshLinks. [17:00:06] ?action=purge doesn't trigger refreshlinks [17:00:06] <^d> Then no, not on action=purge. [17:00:06] <^d> We could. [17:00:06] <^d> Would be easy enough. [17:00:06] hm. forcelinkupdate/forcerecursivelinkupdate? [17:00:06] <^d> (I mean update Cirrus, not trigger refreshlinks. [17:00:21] dr0ptp4kt, ori told me that the new vagrant version breaks our vagrant repo, so don't use the latest. See MW doc for the latest that works [17:03:47] (03CR) 10Kunalgrover05: [C: 04-1] "One question, why does the settings always need to hold the language objects, won't it be much simpler if we store the language code itsel" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/137033 (owner: 10SPQRobin) [17:03:51] (03PS1) 10Hashar: mwconf: tweak workspace detection for /src/ fetches [integration/jenkins] - 10https://gerrit.wikimedia.org/r/137036 [17:03:54] (03CR) 10Hashar: [C: 032] mwconf: tweak workspace detection for /src/ fetches [integration/jenkins] - 10https://gerrit.wikimedia.org/r/137036 (owner: 10Hashar) [17:03:57] (03Merged) 10jenkins-bot: mwconf: tweak workspace detection for /src/ fetches [integration/jenkins] - 10https://gerrit.wikimedia.org/r/137036 (owner: 10Hashar) [17:04:06] (03CR) 10Withoutaname: [C: 031] Warn when user trying to block nonexistent user [core] - 10https://gerrit.wikimedia.org/r/136290 (https://bugzilla.wikimedia.org/35687) (owner: 10devunt) [17:04:08] (03PS3) 10Chad: Do the right thing with gendered namespaces [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/136447 (https://bugzilla.wikimedia.org/32634) [17:04:16] (03CR) 10jenkins-bot: [V: 04-1] Do the right thing with gendered namespaces [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/136447 (https://bugzilla.wikimedia.org/32634) (owner: 10Chad) [17:04:18] (03PS6) 10Hashar: (WIP) Clone mediawiki/core with multigit (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136897 [17:04:21] (03CR) 10Chad: "Actually we can handle the whole bug in Cirrus, PS3 tweaks this a bit further to adjust local title snippets and not just IW results." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/136447 (https://bugzilla.wikimedia.org/32634) (owner: 10Chad) [17:04:23] (03CR) 10Hashar: [C: 04-2] "At least got qunit to pass https://integration.wikimedia.org/ci/job/mediawiki-core-qunit2/12/consoleFull" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136897 (owner: 10Hashar) [17:04:36] (03PS4) 10Chad: Do the right thing with gendered namespaces [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/136447 (https://bugzilla.wikimedia.org/32634) [17:04:48] (03CR) 10Dr0ptp4kt: [C: 032] Refactorings, validators, [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/137032 (owner: 10Yurik) [17:05:12] (03CR) 10Anomie: [C: 04-1] "Code seems sane. Formatting is odd though." (032 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/132730 (owner: 10Jackmcbarn) [17:05:14] (03PS1) 10Anomie: Fix documentation for Title::getCascadeProtectionSources and others [core] - 10https://gerrit.wikimedia.org/r/137039 [17:05:20] (03CR) 10Nikerabbit: Do the right thing with gendered namespaces (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/136447 (https://bugzilla.wikimedia.org/32634) (owner: 10Chad) [17:05:26] (03CR) 10Ori.livneh: [C: 032] Fix documentation for Title::getCascadeProtectionSources and others [core] - 10https://gerrit.wikimedia.org/r/137039 (owner: 10Anomie) [17:05:49] (03Merged) 10jenkins-bot: Fix documentation for Title::getCascadeProtectionSources and others [core] - 10https://gerrit.wikimedia.org/r/137039 (owner: 10Anomie) [17:11:19] bawolff: i'm in some strange shit with MediaHandlers - now I've deployed it to another wiki running 1.22 (i was running 1.19 on my test one) and it doesn't even try getting the image size [17:11:30] breaks transform and always claims the dimensions are 0x0 [17:12:21] ampharos_: 0x0 usually means bad things happened [17:12:44] it doesn't even bother calling getImageSize [17:13:00] (03PS1) 10EBernhardson: Update flow configuration options [vagrant] - 10https://gerrit.wikimedia.org/r/137044 [17:13:02] (03PS2) 10EBernhardson: New configuration option $wgFlowForceTemplateRecompile [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/134668 (owner: 10Spage) [17:13:30] (03CR) 10Ori.livneh: [C: 032] Update flow configuration options [vagrant] - 10https://gerrit.wikimedia.org/r/137044 (owner: 10EBernhardson) [17:13:34] (03Merged) 10jenkins-bot: Update flow configuration options [vagrant] - 10https://gerrit.wikimedia.org/r/137044 (owner: 10EBernhardson) [17:14:24] (03CR) 10EBernhardson: "I've un-hacked this into a proper configuration variable now. I've also submitted a patch to mediawiki-vagrant that will default it to en" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/134668 (owner: 10Spage) [17:14:34] yurikR: as the webpage said, i used vagrant 1.5.4. i emailed ori for his recommendation on next step. [17:16:05] like getWidth/getHeight don't even bother [17:17:04] (03CR) 10SPQRobin: "Because the default $wgContLang is already an object. We could also call wfGetLangObj() once. But it does probably make sense to remove th" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/137033 (owner: 10SPQRobin) [17:18:04] <^d> aude: About? Got a Wikidata question. [17:18:55] kind of [17:19:25] (03PS3) 10Jackmcbarn: Expose cascading protection directly to Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/132730 [17:19:27] ampharos_: I can't really say anything that useful without the code, but try enable debug logging, and doing ?action=purge on the image page, and see what the debug output from that request is [17:19:47] <^d> aude: Should be easy :) Do any of the wikidata content types have expanded forms? [17:19:53] i'll try to enable logging but i can't guarantee if bots don't trip it up [17:20:02] <^d> Sorta like how you've got wikitext and parsed wikitext. [17:20:23] (03PS4) 10Jackmcbarn: Expose cascading protection directly to Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/132730 [17:20:52] un, more a daniel question but i think so [17:20:58] uh* [17:21:14] we use parser cache to store html and such [17:21:42] and then there is the api serialization format which is different [17:21:59] 3MediaWiki / 3API: Create TODO list for best MediaWiki API client library in Ruby - 10https://bugzilla.wikimedia.org/62810#c1 (10Chris McMahon) I thought I should mention our API wrapper intended for use with Cucumber test scenarios. A description is here: https://www.mediawiki.org/wiki/Quality_Assurance/... [17:22:29] probably not completely comparable to wikitext, but hope that answers it [17:22:37] Krenair: beta cluster seems to be back to "normal". can you check the links again now? [17:22:46] why the hell didn't it generate a log [17:23:10] oh god i'm seeing other people use it, and my requests aren't being logged [17:24:01] <^d> aude: Kind of. I'll prod Daniel later. [17:24:07] what the shit [17:24:07] <^d> Mainly what I care about is the expansion. [17:24:10] it works now? [17:24:59] i did action=purge, caching is disabled in firefox, but when I do Ctrl+F5 it, it works? [17:25:00] the fuck? [17:25:22] (03CR) 10Krinkle: [C: 04-1] "I'd recommend we:" [core] - 10https://gerrit.wikimedia.org/r/133719 (https://bugzilla.wikimedia.org/44740) (owner: 10Jforrester) [17:25:30] ^d: i don't think we do that [17:25:42] (03CR) 10EBernhardson: [C: 04-1] Escaped characters in edit form (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/132817 (owner: 10Bsitu) [17:25:45] you mean, like templates etc [17:25:52] <^d> Yep. [17:26:07] <^d> I'm planning do store unparsed wikitext as well as the final parsed form we usually search. [17:26:17] <^d> And I'm wondering if any other content types than wikitext need it. [17:26:29] <^d> Sounds like "no" [17:26:29] bah [17:26:35] (03PS33) 10Legoktm: Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (https://bugzilla.wikimedia.org/14862) [17:26:51] i'm not sure either really suits us except the gettextforsearch things we provide [17:26:55] (03CR) 10Legoktm: Allow for global renaming of users (035 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (https://bugzilla.wikimedia.org/14862) (owner: 10Legoktm) [17:27:07] <^d> aude: Which we already use :) [17:27:07] (03PS3) 10EBernhardson: [SCHEMA CHANGE] Cleanup *_user_text in DB [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135576 (owner: 10Matthias Mullie) [17:27:11] yes [17:27:19] we want it w/o the json and w/o the html [17:27:31] <^d> Right, which is what you've got on wikidata. [17:27:44] <^d> This would be a secondary field that's empty on non-wikitext content types. [17:28:09] ok [17:28:19] not worth it and not useful for us [17:28:36] don't waste the space [17:28:50] * aude back later [17:29:41] fuck cache man [17:29:48] i think my internet is faster than my HD [17:33:44] 3Analytics / 3Refinery: Hive queries inconsistently failing - 10https://bugzilla.wikimedia.org/65420#c33 (10Oliver Keyes) Newest error message, on the random sample query mentioned above: Error: org.apache.hadoop.mapreduce.task.reduce.Shuffle$ShuffleError: error in shuffle in fetcher#2 at org.apache.had... [17:39:39] (03CR) 10Nuria: [C: 032] Minor comment fix [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/137034 (owner: 10Yurik) [17:40:32] nuria: it should be @const afaik [17:40:54] ori : arghh [17:41:01] nuria: and jenkins merges on that repo, so you should just +2 but not submit [17:42:44] ah, ok, +2 and publish .. well... ahem that explains something i was seeing before in wikimetrics git history [17:43:17] (03PS1) 10Aaron Schulz: Renamed $ipSet static variable in IP to something better [core] - 10https://gerrit.wikimedia.org/r/137052 [17:43:19] cause that makes gerrit merge i am guessing. Sorry about that will remember for next time. [17:43:51] ori: should i revert the merge, int seem best for type cheking on IDE but maybe that is not our convention [17:43:52] nuria: no problem, it's confusing [17:44:03] nuria: up to you, no big deal either way [17:44:57] if it's our convention to have @const I will revert, let me know [17:45:21] nuria: i'm not sure myself [17:59:01] 3Wikimedia / 3General/Unknown: Drop *_user_text fields in Flow - 10https://bugzilla.wikimedia.org/66082 (10Erik Bernhardson) 3NEW p:3Unprio s:3normal a:3None Short description: When we moved *_user_text stuff to *_user_ip, we never actually got rid of *_user_text columns in the DB. These columns sti... [17:59:30] 3Wikimedia / 3General/Unknown: Drop *_user_text fields in Flow - 10https://bugzilla.wikimedia.org/66082 (10Erik Bernhardson) a:3Sean Pringle [17:59:30] (03CR) 10EBernhardson: "Filed bug to have change performed in production: https://bugzilla.wikimedia.org/show_bug.cgi?id=66082" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135576 (owner: 10Matthias Mullie) [18:13:04] 3MediaWiki / 3Skin and page rendering: Minor fixes for Typography refresh: list lineheight, H1 margin, H3 fontsize, diff display - 10https://bugzilla.wikimedia.org/64653 (10ryasmeen) [18:13:45] (03PS2) 10Thiemo Mättig (WMDE): Remove optional namespace prefixes from example [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/136831 [18:13:54] (03PS1) 10MaxSem: Deprecate Language::getLangObj() [core] - 10https://gerrit.wikimedia.org/r/137064 [18:14:37] (03CR) 10Thiemo Mättig (WMDE): "> keep the parameter on the js site." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/136831 (owner: 10Thiemo Mättig (WMDE)) [18:15:39] (03PS2) 10MaxSem: Deprecate Language::getLangObj() [core] - 10https://gerrit.wikimedia.org/r/137064 [18:18:14] 3MediaWiki-Vagrant: mediawiki-vagrant reports an error when provisioning "browsertests" role - 10https://bugzilla.wikimedia.org/61285#c9 (10Dan Duvall) I believe I'm running into the same issue, even with proper ownership and permissions on ~vagrant/.gem. A manual execution of `bundle install` reveals a failed... [18:19:53] (03Restored) 10Chad: Begin indexing unexpanded text forms [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110604 (https://bugzilla.wikimedia.org/60487) (owner: 10Chad) [18:20:00] 3MediaWiki / 3Skin and page rendering: Minor fixes for Typography refresh: list lineheight, H1 margin, H3 fontsize, diff display - 10https://bugzilla.wikimedia.org/64653 (10ryasmeen) [18:22:31] 3MediaWiki extensions / 3TemplateSandbox: Pre-save transform applied to wrong page - 10https://bugzilla.wikimedia.org/66084 (10Jackmcbarn) 3NEW p:3Unprio s:3normal a:3None When using TemplateSandbox's preview button, the pre-save transform is applied to the page being previewed, rather than the templ... [18:23:31] 3MediaWiki extensions / 3CirrusSearch: Unable to update norms.enabled - 10https://bugzilla.wikimedia.org/66085 (10Chad H.) 3NEW p:3Unprio s:3normal a:3None Couldn't update mappings. Here is elasticsearch's error message: MergeMappingException[Merge failed with failures {[mapper [source_text] has dif... [18:25:13] (03PS2) 10Esanders: Use new MWInlineExtensionNode and DM node construction [extensions/Math] - 10https://gerrit.wikimedia.org/r/134366 [18:25:36] (03PS2) 10Chad: Begin indexing unexpanded text forms [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110604 (https://bugzilla.wikimedia.org/60487) [18:33:53] (03CR) 10Aaron Schulz: [C: 032] Remove use of strencode() outside Database classes [core] - 10https://gerrit.wikimedia.org/r/136786 (owner: 10PleaseStand) [18:34:00] AaronSchulz: in your perf presentation you mentioned a debug log (or similar) which logs problematic database transactions... how does one enable that? [18:36:47] (03CR) 10Chad: [C: 032] Made TransactionProfiler handle interlaced transactions better [core] - 10https://gerrit.wikimedia.org/r/136225 (owner: 10Aaron Schulz) [18:37:28] (03Merged) 10jenkins-bot: Remove use of strencode() outside Database classes [core] - 10https://gerrit.wikimedia.org/r/136786 (owner: 10PleaseStand) [18:37:32] Nikerabbit: I think it's just setting the 'DBPerformance' log group and having a profiler enabled that isn't the stub one [18:39:29] 3MediaWiki / 3Skin and page rendering: Pictures and boxes aren't displayed with IE6 on de-wiki article pages - 10https://bugzilla.wikimedia.org/66008#c7 (10asafyhkk) @Florian: You're right, it applies only to de-wiki, and there only to article pages. It doesn't apply to pages describing pictures, and it does... [18:39:44] AaronSchulz: okay... if I have time I will try to investigate the MessageGroupStats lock timeout exceeded issue... [18:39:52] (03Merged) 10jenkins-bot: Made TransactionProfiler handle interlaced transactions better [core] - 10https://gerrit.wikimedia.org/r/136225 (owner: 10Aaron Schulz) [18:41:16] I guess replacements are not in separate transactions or not using index or something [18:41:33] (03PS1) 10CSteipp: Add HKDF as a fast, random number source [core] - 10https://gerrit.wikimedia.org/r/137077 [18:41:44] 3MediaWiki / 3Skin and page rendering: Pictures and boxes aren't displayed with IE6 on de-wiki article pages - 10https://bugzilla.wikimedia.org/66008#c8 (10Florian) 5NEW>3RESO/INV Ok, so maybe a problem with custom css, you can work on that on Technik-page? So it isn't a really problem of MediaWiiki :) [18:43:55] (03CR) 10Anomie: [C: 04-1] "Generally good. Two issues and some nitpicks." (036 comments) [core] - 10https://gerrit.wikimedia.org/r/136799 (owner: 10Jackmcbarn) [18:53:31] 3Analytics / 3Wikimetrics: Path to recurrent report should have better semantics - 10https://bugzilla.wikimedia.org/66087 (10nuria) 3NEW p:3Unprio s:3normal a:3None Path to reports from wikimetrics UI look like: http://localhost:5000/static/public/1/full_report.json Instead they should be like: http... [18:55:04] (03CR) 10Gergő Tisza: Generate thumbnails based on buckets (036 comments) [core] - 10https://gerrit.wikimedia.org/r/135008 (owner: 10Gilles) [18:57:06] (03PS1) 10Jdlrobson: Add README file [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137082 [18:57:08] (03PS1) 10Jdlrobson: Add nodecheck so that make jshint works [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137083 [18:57:10] (03PS1) 10Jdlrobson: Add .gitignore file [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137084 [18:57:12] (03PS1) 10Jdlrobson: Fix JSHint warnings [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137085 [18:57:14] (03PS1) 10Jdlrobson: Remove dependency on ext.mantle.oo to Hogan [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137086 [18:58:30] (03PS2) 10Jackmcbarn: Restructure output of ApiExpandTemplates [core] - 10https://gerrit.wikimedia.org/r/136799 [18:59:37] (03CR) 10jenkins-bot: [V: 04-1] Remove dependency on ext.mantle.oo to Hogan [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137086 (owner: 10Jdlrobson) [18:59:54] (03CR) 10Mattflaschen: [C: 032] "Okay. Paladox, thanks for testing. TheDJ, thanks for explaining how it works." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/132603 (https://bugzilla.wikimedia.org/63277) (owner: 10TheDJ) [19:00:00] (03Merged) 10jenkins-bot: Enable WikiEditor toolbar on iOS [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/132603 (https://bugzilla.wikimedia.org/63277) (owner: 10TheDJ) [19:01:48] (03PS3) 10Jackmcbarn: Restructure output of ApiExpandTemplates [core] - 10https://gerrit.wikimedia.org/r/136799 [19:04:09] (03CR) 10Aaron Schulz: [C: 032] Add some SVG element namespaces [core] - 10https://gerrit.wikimedia.org/r/136805 (owner: 10CSteipp) [19:07:33] (03Merged) 10jenkins-bot: Add some SVG element namespaces [core] - 10https://gerrit.wikimedia.org/r/136805 (owner: 10CSteipp) [19:09:38] anomie: can you rebase https://gerrit.wikimedia.org/r/#/c/99794/ ? [19:09:39] (03CR) 10Gergő Tisza: [C: 04-1] "See also new comments on patchset 13." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/135008 (owner: 10Gilles) [19:09:57] (03PS1) 10Bsitu: Add post reply no-js support [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137089 [19:12:10] (03PS2) 10Bsitu: Add post reply no-js support [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137089 [19:13:10] (03PS2) 10Anomie: Don't cache volatile wikitext [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/99794 (https://bugzilla.wikimedia.org/46815) [19:13:23] (03Abandoned) 10Anomie: Enable volatile caching test for frame:expandTemplate [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/99795 (owner: 10Anomie) [19:16:10] (03CR) 10Jackmcbarn: [C: 031] Don't cache volatile wikitext [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/99794 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [19:27:02] 3MediaWiki / 3General/Unknown: inet_pton() Unrecognized address unknown in IPSet.php on line 171 - 10https://bugzilla.wikimedia.org/66088 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3None PHP Warning: inet_pton() [function.inet-pton]: Unrecognized address unknown... [19:29:58] (03CR) 10Brian Wolff: [C: 031] "Ok. I'm supportive of this change. Any objections to merging this?" [core] - 10https://gerrit.wikimedia.org/r/123516 (https://bugzilla.wikimedia.org/22683) (owner: 10Jackmcbarn) [19:30:23] (03PS1) 10Reedy: Suppress warnings from inet_pton [core] - 10https://gerrit.wikimedia.org/r/137095 (https://bugzilla.wikimedia.org/66088) [19:30:45] (03PS1) 10Yuvipanda: Create separate iOS and Android bundles [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/137096 [19:30:53] legoktm: jdlrobson ori ^ +2? [19:31:22] (03PS2) 10Ori.livneh: Create separate iOS and Android bundles [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/137096 (owner: 10Yuvipanda) [19:31:26] (03CR) 10Ori.livneh: [C: 032] Create separate iOS and Android bundles [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/137096 (owner: 10Yuvipanda) [19:31:42] (03CR) 10Reedy: "I note the code is commented about the emitting of the E_WARNING (code comments would want updating if 137095 was to be merged), but what " [core] - 10https://gerrit.wikimedia.org/r/137095 (https://bugzilla.wikimedia.org/66088) (owner: 10Reedy) [19:31:44] 3MediaWiki / 3General/Unknown: inet_pton() Unrecognized address unknown in IPSet.php on line 171 - 10https://bugzilla.wikimedia.org/66088#c2 (10Sam Reed (reedy)) (In reply to Gerrit Notification Bot from comment #1) > Change 137095 had a related patch set uploaded by Reedy: > Suppress warnings from inet_pton... [19:32:00] ori: ty [19:32:07] (03Merged) 10jenkins-bot: Create separate iOS and Android bundles [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/137096 (owner: 10Yuvipanda) [19:33:23] (03PS5) 10Gergő Tisza: Add global limit to PoolCounter [core] - 10https://gerrit.wikimedia.org/r/135702 (https://bugzilla.wikimedia.org/65691) [19:34:37] (03PS2) 10Reedy: Suppress warnings from inet_pton [core] - 10https://gerrit.wikimedia.org/r/137095 (https://bugzilla.wikimedia.org/66088) [19:42:13] (03CR) 10Spage: [C: 031] "I can make a reply to a post now." (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137089 (owner: 10Bsitu) [19:50:27] ori: Krinkle does RL support If-Modified-Since properly? [19:50:59] I imagine it does. If not, it probably turns out to be obsolete by another http mechanism we use instead. [19:51:14] hmm, let me check [19:51:16] It supports 304 Not Modified [19:51:28] in combination with max-age [19:51:53] YuviPanda: If content has changed, the url changes because of the &version= parameter [19:52:14] Krinkle: well, this is for the app where I'm generating them myself (since I've to generate them clientside purely) [19:52:16] Krinkle: so I can't rely on that [19:52:32] Generate what? [19:52:37] Krinkle: the URL [19:52:41] Krinkle: so no version= for me [19:52:44] What url, to where? [19:53:13] Krinkle: specifically, I'm using $PREFIX/load.php?debug=true&lang=en&modules=mobile.app.pagestyles.android&only=styles&skin=vector&version=&* as the URL now to download styles to be used in the app [19:53:29] 3MediaWiki / 3JavaScript: Upgrade jQuery UI from 1.8 to 1.9 - 10https://bugzilla.wikimedia.org/47076 (10Krinkle) [19:53:39] YuviPanda: Ah, this is for load.php itself. [19:53:48] Krinkle: indeed [19:53:54] I thought you were looking to re-use some cache related logic from RL and wondering if it usports If-Modified-Since [19:54:06] Why are you generating your own load.php urls? [19:54:13] Krinkle: since the app is written in Java [19:54:27] Krinkle: and justs uses RL as a CSS minification / delivery mechanism [19:54:30] *just [19:54:35] YuviPanda: Where are you making the http request from ? [19:54:42] Krinkle: the android app, from the user's phone [19:55:12] So you're downloading resources over http from the app native code, and saving it locally to serve as local file inside the in-app HTML rendering? [19:55:16] YuviPanda: [19:55:22] Krinkle: yup [19:55:24] k [19:55:25] Krinkle: exactly [19:55:27] (03CR) 10Umherirrender: [C: 031] Remove optional namespace prefixes from example [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/136831 (owner: 10Thiemo Mättig (WMDE)) [19:55:38] YuviPanda: Are you fetching startup as well? [19:55:45] Krinkle: so I'm trying to figure out how to make sure I don't re-download if it hasn't changed. [19:55:45] Krinkle: no, not fetching startup. [19:55:48] Why not? [19:55:48] Krinkle: not fetching any JS at all. only styles [19:56:09] Right [19:56:32] Krinkle: so the app downloads the styles once a day or so, and locally caches them. then the local webview just refers to that, from the local filesystem. 98% of the code is Java, with super-minimal JS. Fairly sandboxed as well [19:56:45] (03PS18) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [19:57:14] 3MediaWiki / 3API: unread count for watchlist changes is not available via API - 10https://bugzilla.wikimedia.org/65246#c10 (10Brad Jorsch) (In reply to Jared Zimmerman (WMF) from comment #9) > @Brad, is this something you're actively working on It wasn't, but I did it this afternoon. Patches to be uploaded... [19:57:36] YuviPanda: In that case I'd either 1) fetch from load.php without version=, that sets max-age internally to 30 minutes instead of indefinite (30 days). You're free to save them 24h instead of 30 minutes of course. [19:57:45] Then just re-download whenever you have connectivity once a day [19:58:05] (03PS1) 10Cscott: ParserTests: fix `bits` column in uploaded images for test cases. [core] - 10https://gerrit.wikimedia.org/r/137146 [19:58:23] (03PS1) 10Anomie: API: Add show=unread to ApiQueryWatchlist [core] - 10https://gerrit.wikimedia.org/r/137147 (https://bugzilla.wikimedia.org/65246) [19:58:25] YuviPanda: alternatively you can choose to download the module=startup manifest once a day, parse out the JSON map of module-name->version timestamp, and use that to invalidate said modules locally [19:58:38] (03PS1) 10Anomie: Add wl_user_notificationtimestamp index [core] - 10https://gerrit.wikimedia.org/r/137149 (https://bugzilla.wikimedia.org/65246) [19:58:43] (03PS1) 10Anomie: API: Add prop=unreadcount to ApiQueryUserInfo [core] - 10https://gerrit.wikimedia.org/r/137150 (https://bugzilla.wikimedia.org/65246) [19:58:43] Krinkle: ah, hmm. so we don't directly support if-modified-since on load.php [19:58:53] But since the stuff you're downloading isn't all that big, you're better off downloading that directly instead of fetching startup first, which is almost as big as your stylesheet. [19:59:10] Krinkle: right. this is on 10m devices though. [19:59:19] YuviPanda: No, it's obsolete and not relevant to how RL works. It also has no scalability to speak of given how dynamic our infrastructure is. [19:59:25] Krinkle: hmm, that is true. [19:59:41] Krinkle: no Etags support either, I guess. That would be easier to implement in varnish itself, I suppose. [19:59:55] load.php without &version= will be cached by varnish for 30 minutes [19:59:58] so that's pretty scalable [20:00:01] hmm, right. [20:00:14] Krinkle: I'm more trying to reduce bandwidth on the user's end [20:00:25] (03CR) 10Anomie: "Note this requires If3e9e855, and so should not be deployed to WMF wikis until the schema change in that patch is deployed to the cluster." [core] - 10https://gerrit.wikimedia.org/r/137150 (https://bugzilla.wikimedia.org/65246) (owner: 10Anomie) [20:00:30] that means no more than 48 apache backend hit per day. The rest are all 304 hits in varnish. [20:00:37] Yeah. [20:00:56] YuviPanda: Yeah, because you're not using javascript, you miss out on a lot of optimisation. [20:01:06] In production this allows us to make 0 http requests most of the time. [20:01:19] there are some tickets in bugzilla on etag and if-modified since [20:01:19] Krinkle: hmm, right. [20:01:26] Whereas if we'd use If-Modified-Since you're constantly making server handshakes. Even if they're small, it is a roundtrip. [20:01:55] Krinkle: hmm, so for now I'm just going to re-download them once a day or so. Eventually I guess we can add etag support to varnish [20:02:24] Krinkle: does make sense to not support If-Modified-Since. [20:02:38] YuviPanda: yeah, at least not in RL or MediaWiki [20:02:45] we could add support for it in Varnish though [20:02:48] Krinkle: and yeah, agreed on current arch being better for JS using things, but causes problems in cases like the app [20:02:57] because unlike MW/RL, Varnish does have the timestamp of when the resource was last modified. [20:03:17] Krinkle: indeed. so whichever is easier of If-Modified-Since or Etag would be nice [20:03:32] Probably etag [20:03:34] but yeah [20:04:00] (03PS19) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [20:04:19] thedj: any idea what those bugs are? [20:04:20] Krinkle: cool [20:05:51] 24531, 31639, 47529 [20:06:11] Krinkle: actually, curl -I does give me a Last-Modified header [20:07:17] YuviPanda: remember, there is a difference between what varnish does, and what mediawiki does [20:07:27] and what 'our varnish' does. [20:07:30] 3Wikimedia / 3General/Unknown: Schema changes for Wikimedia wikis (tracking) - 10https://bugzilla.wikimedia.org/49188 (10Brad Jorsch) [20:07:30] 3MediaWiki / 3API: unread count for watchlist changes is not available via API - 10https://bugzilla.wikimedia.org/65246 (10Brad Jorsch) [20:07:31] 3Wikimedia / 3General/Unknown: Add index wl_user_notificationtimestamp to table watchlist - 10https://bugzilla.wikimedia.org/66089 (10Brad Jorsch) 3NEW p:3Unprio s:3normal a:3None As suggested on bug 65246 comment 5, please create the index. Wikis: all wikis Tables: watchlist Change needed: CRE... [20:07:32] thedj: hehe, yeah. [20:07:38] Yeah, plus Last-Modified is in the response always, regardless of you passing If-Modified-Since [20:07:39] thedj: I guess at this point I'm interested in what our varnish does [20:07:46] I think we do emit L-M from MW though [20:10:04] (03PS20) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [20:13:11] (03PS7) 10Jforrester: Disable jQuery Migrate by default (enable via $wgIncludejQueryMigrate) [core] - 10https://gerrit.wikimedia.org/r/133719 (https://bugzilla.wikimedia.org/44740) [20:13:43] (03PS1) 10Jackmcbarn: Use preview content when it transcludes itself [core] - 10https://gerrit.wikimedia.org/r/137153 [20:14:18] (03CR) 10jenkins-bot: [V: 04-1] Disable jQuery Migrate by default (enable via $wgIncludejQueryMigrate) [core] - 10https://gerrit.wikimedia.org/r/133719 (https://bugzilla.wikimedia.org/44740) (owner: 10Jforrester) [20:14:20] (03PS2) 10Jackmcbarn: Use preview content when it transcludes itself [core] - 10https://gerrit.wikimedia.org/r/137153 (https://bugzilla.wikimedia.org/5278) [20:14:22] (03CR) 10Bartosz Dziewoński: "Magic. There was definitely a bug or five filed for this over the years, no?" [core] - 10https://gerrit.wikimedia.org/r/137153 (https://bugzilla.wikimedia.org/5278) (owner: 10Jackmcbarn) [20:15:09] (03PS8) 10Jforrester: Disable jQuery Migrate by default (enable via $wgIncludejQueryMigrate) [core] - 10https://gerrit.wikimedia.org/r/133719 (https://bugzilla.wikimedia.org/44740) [20:15:37] (03CR) 10Jforrester: "PS7: Addresses Timo's suggestion" [core] - 10https://gerrit.wikimedia.org/r/133719 (https://bugzilla.wikimedia.org/44740) (owner: 10Jforrester) [20:16:43] (03CR) 10Anomie: [C: 031] "Nitpicks. If you don't want to bother, let me know and I'll just fix them." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/136799 (owner: 10Jackmcbarn) [20:17:11] (03Abandoned) 10Reedy: Re-enable code to use ContentHandler [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/136652 (owner: 10Reedy) [20:20:08] (03PS4) 10Jackmcbarn: Restructure output of ApiExpandTemplates [core] - 10https://gerrit.wikimedia.org/r/136799 [20:21:00] jackmcbarn: Can I bug you for a RELEASE-NOTES entry too? ;) [20:21:00] (03CR) 10Subramanya Sastry: [C: 031] ParserTests: fix `bits` column in uploaded images for test cases. [core] - 10https://gerrit.wikimedia.org/r/137146 (owner: 10Cscott) [20:21:43] Krinkle: yeah, doesn't seem to support if-modified-since. Shouldn't be too hard to do since Varnish does last-modified anyway [20:22:33] anomie: for which one? 136799 again? [20:22:39] (03PS23) 10MarkTraceur: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) [20:22:40] jackmcbarn: Yeah [20:22:54] yeah, let me rebase it first or i know i'll conflict [20:23:03] (03PS5) 10Jackmcbarn: Restructure output of ApiExpandTemplates [core] - 10https://gerrit.wikimedia.org/r/136799 [20:23:48] anomie: is that a "new feature" or an "other change"? [20:23:56] oh [20:23:58] api change. nvm [20:24:11] (03CR) 10jenkins-bot: [V: 04-1] Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [20:24:19] (03CR) 10MarkTraceur: Massive refactor (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [20:25:16] (03PS6) 10Jackmcbarn: Restructure output of ApiExpandTemplates [core] - 10https://gerrit.wikimedia.org/r/136799 [20:25:49] (03CR) 10Anomie: [C: 032] Restructure output of ApiExpandTemplates [core] - 10https://gerrit.wikimedia.org/r/136799 (owner: 10Jackmcbarn) [20:25:59] 3MediaWiki / 3Installer: phpunit 4.0.17 Version.php not found - 10https://bugzilla.wikimedia.org/64597#c9 (10Tisza Gergő) Given https://gerrit.wikimedia.org/r/#/c/132788/ , can't we just define PHPUnit as a dev dependency and have mw-vagrant run composer install --dev when it checks out mediawiki/core? [20:26:51] (03PS9) 10Krinkle: Disable jQuery Migrate by default (enable via $wgIncludejQueryMigrate) [core] - 10https://gerrit.wikimedia.org/r/133719 (https://bugzilla.wikimedia.org/44740) (owner: 10Jforrester) [20:27:49] (03CR) 10Krinkle: "Rephrased slightly to use present tense (it is disabled by default, not will be). And made explicit that 1.25 refers to MediaWiki release " [core] - 10https://gerrit.wikimedia.org/r/133477 (https://bugzilla.wikimedia.org/44740) (owner: 10Krinkle) [20:27:57] (03CR) 10Krinkle: "(wrong page)" [core] - 10https://gerrit.wikimedia.org/r/133477 (https://bugzilla.wikimedia.org/44740) (owner: 10Krinkle) [20:28:10] (03CR) 10Krinkle: "Rephrased slightly to use present tense (it is disabled by default, not will be). And made explicit that 1.25 refers to MediaWiki release " [core] - 10https://gerrit.wikimedia.org/r/133719 (https://bugzilla.wikimedia.org/44740) (owner: 10Jforrester) [20:28:40] (03CR) 10Jforrester: [C: 031] Disable jQuery Migrate by default (enable via $wgIncludejQueryMigrate) [core] - 10https://gerrit.wikimedia.org/r/133719 (https://bugzilla.wikimedia.org/44740) (owner: 10Jforrester) [20:31:47] (03Merged) 10jenkins-bot: Restructure output of ApiExpandTemplates [core] - 10https://gerrit.wikimedia.org/r/136799 (owner: 10Jackmcbarn) [20:32:00] 3MediaWiki / 3Unit tests: Running phpunit.php fails with "Version.php not found" (phpunit 4.0.17) - 10https://bugzilla.wikimedia.org/64597 (10Krinkle) [20:33:26] (03PS1) 10Hashar: Disable all browsertests jobs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/137161 [20:33:53] AaronSchulz: on that same presentation, do you know that sitenotice now does pollute the cache https://bugzilla.wikimedia.org/show_bug.cgi?id=57732#c0 ? [20:34:01] (03CR) 10Hashar: [C: 032] "deployed" [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/137161 (owner: 10Hashar) [20:34:07] (03CR) 10Jdlrobson: [C: 032] Remove dependency on ext.mantle.oo to Hogan [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137086 (owner: 10Jdlrobson) [20:34:21] (03CR) 10Krinkle: Fix PHPUnit version to 3.7.35 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/132377 (https://bugzilla.wikimedia.org/64597) (owner: 10Physikerwelt) [20:34:21] (03CR) 10Jdlrobson: "recheck" [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137086 (owner: 10Jdlrobson) [20:35:49] (03Merged) 10jenkins-bot: Disable all browsertests jobs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/137161 (owner: 10Hashar) [20:36:14] 3MediaWiki / 3Unit tests: Support PHPUnit 4.x and higher (phpunit.php fails with "Version.php not found") - 10https://bugzilla.wikimedia.org/64597#c10 (10Krinkle) Rephrased summary. The problem is that MediaWiki is trying to include the PHPUnit source files (from a global php import_path) directly. This met... [20:36:34] (03CR) 10Jdlrobson: "recheck" [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137086 (owner: 10Jdlrobson) [20:37:09] (03CR) 10Krinkle: [C: 032] Disable jQuery Migrate by default (enable via $wgIncludejQueryMigrate) [core] - 10https://gerrit.wikimedia.org/r/133719 (https://bugzilla.wikimedia.org/44740) (owner: 10Jforrester) [20:37:36] (03PS9) 10Jackmcbarn: Add PPFrame::getTTL() and setTTL() [core] - 10https://gerrit.wikimedia.org/r/135887 (https://bugzilla.wikimedia.org/49803) [20:39:52] (03PS10) 10Jackmcbarn: Add PPFrame::getTTL() and setTTL() [core] - 10https://gerrit.wikimedia.org/r/135887 (https://bugzilla.wikimedia.org/49803) [20:41:38] (03Merged) 10jenkins-bot: Disable jQuery Migrate by default (enable via $wgIncludejQueryMigrate) [core] - 10https://gerrit.wikimedia.org/r/133719 (https://bugzilla.wikimedia.org/44740) (owner: 10Jforrester) [20:44:51] (03PS6) 10Spage: Frontend-rewrite [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/136777 (owner: 10SG) [20:45:36] (03PS7) 10Bartosz Dziewoński: Officially deprecate skin autodiscovery [core] - 10https://gerrit.wikimedia.org/r/135429 (https://bugzilla.wikimedia.org/65748) [20:45:38] (03PS6) 10Bartosz Dziewoński: Don't use autodiscovery for core skins, move them to separate directories [core] - 10https://gerrit.wikimedia.org/r/135383 (https://bugzilla.wikimedia.org/65748) [20:45:40] (03PS4) 10Bartosz Dziewoński: [DO NOT MERGE] Completely remove skin autodiscovery [core] - 10https://gerrit.wikimedia.org/r/135439 (https://bugzilla.wikimedia.org/65748) [20:45:57] (03CR) 10Raimond Spekking: [C: 031] "i18n review ok. Only 2 suggestions. Once merged, I will handle the changes on translatewiki.net" (032 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135817 (owner: 10Physikerwelt) [20:46:16] i wonder how many more times will i get to rebase these babies [20:47:08] (03CR) 10Spage: [C: 031] "Some stuff works! I think we should +1 this soon to simplify additional work on the frontend-rewrite branch. The entire branch will need c" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/136777 (owner: 10SG) [20:47:19] (03PS1) 10Bsitu: Special:RecentChanges is borked [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137166 [20:50:49] (03Abandoned) 10Bsitu: Escaped characters in edit form [extensions/Flow] - 10https://gerrit.wikimedia.org/r/132817 (owner: 10Bsitu) [20:50:55] (03PS5) 10Chad: Power Special:Random from Elasticsearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/133606 (https://bugzilla.wikimedia.org/65366) [20:52:50] (03PS2) 10Jdlrobson: Remove dependency on ext.mantle.oo to Hogan [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137086 [20:53:02] (03CR) 10Bsitu: Escaped characters in edit form (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/132817 (owner: 10Bsitu) [20:53:05] (03PS6) 10Bartosz Dziewoński: Copy various random files used by tests to tests/phpunit/data [core] - 10https://gerrit.wikimedia.org/r/135408 [20:53:29] (03PS1) 10Jforrester: Remove jQuery Migrate and $wgIncludejQueryMigrate [core] - 10https://gerrit.wikimedia.org/r/137168 [20:53:49] (03CR) 10Jforrester: [C: 04-2] "Not to be merged before MW 1.25wmf1." [core] - 10https://gerrit.wikimedia.org/r/137168 (owner: 10Jforrester) [20:53:51] (03CR) 10Bartosz Dziewoński: "Can I have this merged, pretty-please? This is blocking some skinning cleanup because the tests will not let me move the files." [core] - 10https://gerrit.wikimedia.org/r/135408 (owner: 10Bartosz Dziewoński) [20:54:07] (03CR) 10Chad: [C: 032] Renamed $ipSet static variable in IP to something better [core] - 10https://gerrit.wikimedia.org/r/137052 (owner: 10Aaron Schulz) [20:54:16] (03PS1) 10Aaron Schulz: Track the types of queues in the redis queue aggregator [core] - 10https://gerrit.wikimedia.org/r/137169 [20:54:38] (03CR) 10Jforrester: "Ping waiting for better suggestions; deadline is in ~30 hours' time." [core] - 10https://gerrit.wikimedia.org/r/136610 (https://bugzilla.wikimedia.org/44591) (owner: 10Jforrester) [20:54:40] ori: jdlrobson: you guys bored? https://gerrit.wikimedia.org/r/135408 [20:55:10] MatmaRex: have you tested? [20:55:10] (03PS1) 10Jack Phoenix: Version 2.2: RequestContext love, spacing tweaks + position => top for CSS RL modules. [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/137170 [20:55:33] (03PS3) 10Jdlrobson: Remove dependency on ext.mantle.oo to Hogan [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137086 [20:55:35] (03PS2) 10Jdlrobson: Fix JSHint warnings [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137085 [20:55:38] ori: the phpunit tests should pass in a minute [20:55:38] (03CR) 10Jforrester: "Removal of this is drafted in I09342471." [core] - 10https://gerrit.wikimedia.org/r/133719 (https://bugzilla.wikimedia.org/44740) (owner: 10Jforrester) [20:55:42] (03CR) 10Chad: [C: 032] Copy various random files used by tests to tests/phpunit/data [core] - 10https://gerrit.wikimedia.org/r/135408 (owner: 10Bartosz Dziewoński) [20:55:52] <^d> +2'd. [20:56:00] :) [20:56:00] (03CR) 10Jdlrobson: [C: 032] Add README file [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137082 (owner: 10Jdlrobson) [20:56:08] thanks [20:56:14] (03CR) 10Jdlrobson: [C: 032] Add nodecheck so that make jshint works [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137083 (owner: 10Jdlrobson) [20:56:25] (03CR) 10Jdlrobson: [C: 032] Add .gitignore file [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137084 (owner: 10Jdlrobson) [20:57:26] (03CR) 10Chad: Do the right thing with gendered namespaces (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/136447 (https://bugzilla.wikimedia.org/32634) (owner: 10Chad) [20:58:14] (03CR) 10Nemo bis: "James, the key and qqq are easy to fix :)" [core] - 10https://gerrit.wikimedia.org/r/136610 (https://bugzilla.wikimedia.org/44591) (owner: 10Jforrester) [20:59:02] (03CR) 10Spage: [C: 031] "It's better than what I rote, question about the desired behavior in production." (033 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/134668 (owner: 10Spage) [20:59:26] (03CR) 10SPQRobin: "Added inline comments. I would also maybe leave Title.php untouched so there won't be a conflict with my patch. When this patch would be m" (037 comments) [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [21:00:19] (03CR) 10EBernhardson: Frontend-rewrite (033 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/136777 (owner: 10SG) [21:00:26] (03PS5) 10Chad: Do the right thing with gendered namespaces [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/136447 (https://bugzilla.wikimedia.org/32634) [21:01:18] (03CR) 10Bartosz Dziewoński: [C: 031] "Timo, Roan, Trevor: Any reason why we wouldn't want to do this?" [core] - 10https://gerrit.wikimedia.org/r/136650 (owner: 10Daniel Friesen) [21:02:24] MatmaRex: Well, if we go with removing the only 2 weird things from the way skins are done and turn them into extensions, then this woul dbe obsolete [21:02:29] right now there's only 2 weird thigns about them [21:02:44] 1) repo name, 2) remoteBasePath being $IP/skins instead of remoteExtPath [21:02:52] literally everything else about them is an extension already [21:03:07] I don't see the point of having skins/ be changed by site admins any way more than resources/ or includes/ [21:03:14] Krinkle: eh, i don't think we're going to do that [21:03:29] 3Analytics / 3Wikistats: Monthly aggregation of page views fails - 10https://bugzilla.wikimedia.org/66004#c2 (10christian) (In reply to Toby Negrin from comment #1) > Did this get fixed when we debugged the permissions? No. It didn't. http://dumps.wikimedia.org/other/pagecounts-ez/merged/ [21:03:34] we have skin submodules in skins/ in wmf production now, even [21:03:51] That is a rather desceptive way of phrasing it MatmaRex [21:03:52] hmm, need to move a bunch of analytics stuff to -analytics [21:04:08] The only reason Chad did that is because Jon Robson had the repos created as mediawiki/skins/* that means nothing [21:04:09] hmm? i did not do *that* [21:04:25] That is not recognising a standard or anything. [21:04:50] <^d> Actually where the repos were made no difference. [21:04:51] it was already a standard [21:04:56] We have the freedom to set a new standard here and abandon any legacy. No existing code can be used in and of itself as rationale for how we'd do skins in the future. [21:05:04] <^d> They could've been in mediawiki/includes/poop and it wouldn't have mattered really. [21:05:08] MatmaRex: No, some people created a couple repos by that name. That's all. [21:05:35] i'm pretty sure that's how consensus works. :) [21:05:47] luckily we don't have design by committee here yet [21:05:55] or at least not everywhere… [21:06:00] (03CR) 10jenkins-bot: [V: 04-1] Remove dependency on ext.mantle.oo to Hogan [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137086 (owner: 10Jdlrobson) [21:06:27] What is a fact is that we have no way of registering an extension, classes, messages, modules, or loading the init file from localsettings other than the way we do it for extensions. Thus the question that imho remains is, why would we do it any different for plugins providing skins than plugins providing a special page or API module? [21:07:12] Having skins provided by a plugin is a relatively new concept. [21:07:38] (03Merged) 10jenkins-bot: Add README file [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137082 (owner: 10Jdlrobson) [21:07:39] (03Merged) 10jenkins-bot: Add nodecheck so that make jshint works [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137083 (owner: 10Jdlrobson) [21:07:41] (03Merged) 10jenkins-bot: Add .gitignore file [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137084 (owner: 10Jdlrobson) [21:07:42] MatmaRex: I agree that is how consensus works, but right now the sample data is too small. There is neither consensus by agreement nor by popularity. [21:08:08] There is just a handful of repos and some wiki pages all done independently and except for one or two, all done differently [21:08:14] <^d> POLL EVERYONE [21:08:15] even within mediawiki/skins/* the practice isn't consistent. [21:08:15] Krinkle: i'm pretty sure that quesiton was answerede, and i summarized the answer in http://www.gossamer-threads.com/lists/wiki/wikitech/465428#465428 [21:08:22] that question was answered* [21:08:50] also, relatively new? docs/skin.txt says we can do that since 1.12 [21:09:03] i guess that's relatively new when compared to special pages or something [21:09:10] MatmaRex: "I'll keep them in 'skins/' for now, it'll be less disruptive in WMF environment and easy to change later if we decide to. " [21:09:13] can you elaborate on that? [21:09:34] Krinkle: sure. i'm not yet moving them to separate repositories. [21:09:52] Krinkle: thus, putting them in extensions/ while they're in mediawiki/core repo would surely mess things up [21:09:55] It required a change to the branch and deployment script, how was it less disruptive than "just" a regular extension? Not that it was disruptive either way, just curious what made it suposedly "less disruptive " [21:10:00] so i'm not doing that [21:10:18] Oh you mean the core ones [21:10:20] i did not do Modern and CologneBlue, and i don't really like how it was done [21:10:21] (vector/monobook) [21:10:24] OK [21:10:29] but it happened and things are okay [21:10:34] Right [21:11:02] <^d> Krinkle: The change to make-wmf-branch wasn't disruptive. [21:11:06] <^d> It took like 10 minutes. [21:11:07] I agree [21:11:11] Krinkle: the part you asked about is at the bottom :) [21:11:16] Nevermind, this wasn't about disruption in that regard. [21:11:32] (or rather, at the third point of four) [21:11:40] (03Merged) 10jenkins-bot: Renamed $ipSet static variable in IP to something better [core] - 10https://gerrit.wikimedia.org/r/137052 (owner: 10Aaron Schulz) [21:13:28] (03Merged) 10jenkins-bot: Copy various random files used by tests to tests/phpunit/data [core] - 10https://gerrit.wikimedia.org/r/135408 (owner: 10Bartosz Dziewoński) [21:13:38] (03PS1) 10Jack Phoenix: Removed extractParamFromUri() in favor of mw.util.getParamValue(). [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/137176 [21:14:03] (03CR) 10Raimond Spekking: [C: 032] Make "mini" the default alias for "thumb" in German [core] - 10https://gerrit.wikimedia.org/r/136861 (owner: 10Thiemo Mättig (WMDE)) [21:14:11] (03CR) 10Jack Phoenix: [C: 032 V: 032] Removed extractParamFromUri() in favor of mw.util.getParamValue(). [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/137176 (owner: 10Jack Phoenix) [21:14:50] (03CR) 10Spage: [V: 032] "Fixes it, thanks!" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137166 (owner: 10Bsitu) [21:15:40] (03CR) 10Aaron Schulz: [C: 032] (bug 56849) Deprecate dangerous edittime-based content update functions [core] - 10https://gerrit.wikimedia.org/r/134049 (owner: 10Awight) [21:16:05] (03PS3) 10Nikerabbit: Deprecate Language::getLangObj() [core] - 10https://gerrit.wikimedia.org/r/137064 (owner: 10MaxSem) [21:16:28] (03PS7) 10EBernhardson: Frontend-rewrite [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/136777 (owner: 10SG) [21:16:37] (03CR) 10Nikerabbit: [C: 032] "No wonder it is unused, the current implementation is not very useful." [core] - 10https://gerrit.wikimedia.org/r/137064 (owner: 10MaxSem) [21:17:30] (03CR) 10EBernhardson: "PS7: tweaks to escaping and helpers in TemplateHelper.php from comments on PS1" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/136777 (owner: 10SG) [21:17:33] (03CR) 10Chad: (bug 56849) Deprecate dangerous edittime-based content update functions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/134049 (owner: 10Awight) [21:18:12] ^d: btw, regarding repo size, not sure how you measured it, but the way Gerrit stores it all in one repo in the backend (every unmerged patch and each version of unmerged/merged patches alike is kept for ever), makes it quite large of course. And even when locally, you might have release, wmf, review/* or sandbox/* branches synced locally that can be quite large [21:18:40] <^d> Yes I know. [21:18:45] cool :) [21:22:34] (03Merged) 10jenkins-bot: Make "mini" the default alias for "thumb" in German [core] - 10https://gerrit.wikimedia.org/r/136861 (owner: 10Thiemo Mättig (WMDE)) [21:23:06] (03Merged) 10jenkins-bot: (bug 56849) Deprecate dangerous edittime-based content update functions [core] - 10https://gerrit.wikimedia.org/r/134049 (owner: 10Awight) [21:24:41] (03Merged) 10jenkins-bot: Deprecate Language::getLangObj() [core] - 10https://gerrit.wikimedia.org/r/137064 (owner: 10MaxSem) [21:25:44] 3MediaWiki / 3Page editing: Edit conflict detection suffers a race condition - 10https://bugzilla.wikimedia.org/56849 (10Aaron Schulz) [21:29:08] (03CR) 10Jdlrobson: "recheck" [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137086 (owner: 10Jdlrobson) [21:29:14] 3MediaWiki-Vagrant: Vagrant dependent on MediaWiki 1.21+ - 10https://bugzilla.wikimedia.org/56048#c3 (10Mark A. Hershberger) 5NEW>3RESO/FIX long since merged. Closing bug. [21:30:44] 3MediaWiki-Vagrant: Vagrant dependent on MediaWiki 1.21+ - 10https://bugzilla.wikimedia.org/56048#c4 (10Tyler Romeo) @Mark, what was merged? Could you link the patch? [21:32:39] (03PS4) 10Jdlrobson: Remove dependency on ext.mantle.oo to Hogan [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137086 [21:33:07] (03PS1) 10Yuvipanda: Fix line-height for page titles [extensions/MobileApp] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137180 [21:33:09] (03PS1) 10Yuvipanda: Re-use MobileFrontend content styles [extensions/MobileApp] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137181 [21:33:11] (03PS1) 10Yuvipanda: Display locked pencil icon if page is protected [extensions/MobileApp] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137182 [21:33:13] (03PS1) 10Yuvipanda: Do not override MobileFrontend fonts [extensions/MobileApp] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137183 [21:33:15] (03PS1) 10Yuvipanda: Re-use Link styles from MobileFrontend [extensions/MobileApp] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137184 [21:33:17] (03PS1) 10Yuvipanda: Add 'mobile app edit' tags to edits from MobileApp [extensions/MobileApp] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137185 [21:33:19] (03PS1) 10Yuvipanda: Hide edit buttons on the main page [extensions/MobileApp] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137186 [21:33:21] (03PS1) 10Yuvipanda: Create separate iOS and Android bundles [extensions/MobileApp] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137187 [21:35:14] (03PS1) 10Yuvipanda: Hide edit buttons on the main page [extensions/MobileApp] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137188 [21:35:14] (03PS1) 10Yuvipanda: Create separate iOS and Android bundles [extensions/MobileApp] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137189 [21:35:27] (03PS1) 10Bsitu: Fix offset erros when clicking on "Load More" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137190 [21:35:49] (03PS14) 10Reedy: Switch API to use Config classes [core] - 10https://gerrit.wikimedia.org/r/109271 [21:36:01] (03PS15) 10Reedy: Switch API to use Config classes [core] - 10https://gerrit.wikimedia.org/r/109271 [21:37:17] 3MediaWiki extensions / 3BlogPage: BlogPage feature request - Traditional Blog + Blog "style" - 10https://bugzilla.wikimedia.org/66090 (10sm64ds2) 3UNCO p:3Unprio s:3normal a:3Jack Phoenix Hi there! First request here. I have an idea for the extension "BlogPage", which would allow for better managem... [21:38:31] (03CR) 10jenkins-bot: [V: 04-1] Remove dependency on ext.mantle.oo to Hogan [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137086 (owner: 10Jdlrobson) [21:42:15] (03CR) 10Aaron Schulz: [C: 04-1] "/libs stuff can't use wf* methods" [core] - 10https://gerrit.wikimedia.org/r/137095 (https://bugzilla.wikimedia.org/66088) (owner: 10Reedy) [21:42:50] (03PS2) 10Yuvipanda: Add 'mobile app edit' tags to edits from MobileApp [extensions/MobileApp] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137185 [21:42:52] (03PS1) 10Yuvipanda: Update RL modules to use MobileFrontend styles [extensions/MobileApp] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137195 [21:45:15] 3Wikimedia / 3Git/Gerrit: Move Nostalgia skin repository from mediawiki/extensions/ to mediawiki/skins/ - 10https://bugzilla.wikimedia.org/61256#c4 (10Bartosz Dziewoński) (In reply to Bartosz Dziewoński from comment #1) > * Renaming or copying the actual repository, and hooking it up as a submodule > in me... [21:45:18] (03PS1) 10Bartosz Dziewoński: Nostalgia.php cleanup [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/137197 [21:45:20] (03PS1) 10Bartosz Dziewoński: Adjust 'remoteBasePath' to the skins/ directory [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/137198 (https://bugzilla.wikimedia.org/61256) [21:46:28] (03PS1) 10Yuvipanda: Squashed changes containing style fixes for the app [extensions/MobileApp] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137199 [21:48:36] (03Abandoned) 10Yuvipanda: Create separate iOS and Android bundles [extensions/MobileApp] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137189 (owner: 10Yuvipanda) [21:48:41] (03Abandoned) 10Yuvipanda: Hide edit buttons on the main page [extensions/MobileApp] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137188 (owner: 10Yuvipanda) [21:48:44] (03PS1) 10Spage: fix TypeError: mw.user.name(...) is null exception [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137202 [21:48:47] (03Abandoned) 10Yuvipanda: Create separate iOS and Android bundles [extensions/MobileApp] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137187 (owner: 10Yuvipanda) [21:48:57] (03Abandoned) 10Yuvipanda: Hide edit buttons on the main page [extensions/MobileApp] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137186 (owner: 10Yuvipanda) [21:49:02] (03Abandoned) 10Yuvipanda: Re-use Link styles from MobileFrontend [extensions/MobileApp] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137184 (owner: 10Yuvipanda) [21:49:08] (03Abandoned) 10Yuvipanda: Do not override MobileFrontend fonts [extensions/MobileApp] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137183 (owner: 10Yuvipanda) [21:49:13] (03Abandoned) 10Yuvipanda: Display locked pencil icon if page is protected [extensions/MobileApp] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137182 (owner: 10Yuvipanda) [21:49:19] (03Abandoned) 10Yuvipanda: Re-use MobileFrontend content styles [extensions/MobileApp] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137181 (owner: 10Yuvipanda) [21:49:24] (03Abandoned) 10Yuvipanda: Fix line-height for page titles [extensions/MobileApp] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137180 (owner: 10Yuvipanda) [21:49:29] (03PS1) 10Bartosz Dziewoński: Add Nostalgia to $branchedSkins [tools/release] - 10https://gerrit.wikimedia.org/r/137203 (https://bugzilla.wikimedia.org/61256) [21:49:34] Nikerabbit: Tabs or spaces for i18n jsons? Is there a convention for that somewhere? [21:49:43] (03PS2) 10Cscott: ParserTests: fix `bits` column in uploaded images for test cases. [core] - 10https://gerrit.wikimedia.org/r/137146 [21:49:48] hoo: tabs [21:49:55] hoo: they should all be tabs now [21:49:59] 3MediaWiki extensions / 3CirrusSearch: Interwiki search use canonical namespace name - 10https://bugzilla.wikimedia.org/20375#c11 (10Chad H.) 5ASSI>3RESO/FIX I'm pretty sure this is better now. If we can find any examples in Cirrus where it's wrong feel free to reopen. [21:50:26] Nemo_bis: Ok... we have some left with spaces in Wikibase [21:50:29] not that it matters, l10n-bot will fix any mistake [21:50:31] will fix them [21:50:34] it doesn't [21:50:49] because there were no exports, I suppose? [21:51:01] or were those files touched recently [21:51:47] Oh right... it doesn't dare to touch the en.json, that's why [21:52:15] 3MediaWiki extensions / 3CirrusSearch: No Update of elasticsearch index when changing wiki - 10https://bugzilla.wikimedia.org/65439#c2 (10Chad H.) 5UNCO>3RESO/WOR (In reply to Nik Everett from comment #1) > Are you, perchance, not running jobs? That'd be my guess. I can't replicate and haven't had this... [21:52:15] 3Wikimedia / 3Git/Gerrit: Move Nostalgia skin repository from mediawiki/extensions/ to mediawiki/skins/ - 10https://bugzilla.wikimedia.org/61256#c8 (10Bartosz Dziewoński) This should do. I'll get someone who knows what they're doing to check these. TODO undeploy mediawiki/extensions/Nostalgia when we can do... [21:52:18] usually not [21:52:28] ^d: by "someone who knows what they're doing" above, i meant you ~ [21:52:34] https://bugzilla.wikimedia.org/show_bug.cgi?id=61256#c5 [21:53:21] * ^d has no clue what he's doing [21:53:26] <^d> I just fake it and hope for the best :p [21:54:18] can someone +2 these cherry-picks? the appropriate patches are already in master, and I just realized we need these deployed for tomorrow's android app beta release. Mostly all just CSS changes that don't affect any HTML anywhere. https://gerrit.wikimedia.org/r/#/c/137199/ https://gerrit.wikimedia.org/r/#/c/137195/ and https://gerrit.wikimedia.org/r/#/c/137185/ [21:54:45] (03CR) 10Ori.livneh: [C: 032] Squashed changes containing style fixes for the app [extensions/MobileApp] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137199 (owner: 10Yuvipanda) [21:54:49] (03Merged) 10jenkins-bot: Squashed changes containing style fixes for the app [extensions/MobileApp] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137199 (owner: 10Yuvipanda) [21:55:21] (03CR) 10Ori.livneh: [C: 032] Update RL modules to use MobileFrontend styles [extensions/MobileApp] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137195 (owner: 10Yuvipanda) [21:55:25] (03Merged) 10jenkins-bot: Update RL modules to use MobileFrontend styles [extensions/MobileApp] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137195 (owner: 10Yuvipanda) [21:56:14] 3MediaWiki extensions / 3UniversalLanguageSelector: Don't load ULS IME on autofocused search bar - 10https://bugzilla.wikimedia.org/65988#c4 (10Krinkle) (Nemo asked me for input. Thanks.) One solution that might be possible is to indeed lazyload it when the input field is first used (based on keyup or value... [21:57:15] Nikerabbit: https://gerrit.wikimedia.org/r/137205 want to +2? [21:57:40] zz [21:57:41] (03CR) 10Ori.livneh: [C: 032] Add 'mobile app edit' tags to edits from MobileApp [extensions/MobileApp] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137185 (owner: 10Yuvipanda) [21:57:45] (03Merged) 10jenkins-bot: Add 'mobile app edit' tags to edits from MobileApp [extensions/MobileApp] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137185 (owner: 10Yuvipanda) [21:57:54] ori: woo! Thank you :) first time prepping patches for swat. [21:58:54] (03PS21) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [22:00:21] (03PS1) 10Yuvipanda: Submodule update to deploy styles + edit tag [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137208 [22:01:28] (03PS1) 10Yuvipanda: Submodule update to deploy updated styles [core] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137209 [22:02:52] (03CR) 10EBernhardson: [C: 032] Frontend-rewrite [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/136777 (owner: 10SG) [22:03:17] (03Merged) 10jenkins-bot: Frontend-rewrite [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/136777 (owner: 10SG) [22:06:22] (03PS22) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [22:06:33] (03PS2) 10Gergő Tisza: Move funnel logging into its own component [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/134283 [22:06:36] (03PS3) 10EBernhardson: Add post reply no-js support [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137089 (owner: 10Bsitu) [22:08:12] (03CR) 10jenkins-bot: [V: 04-1] Move funnel logging into its own component [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/134283 (owner: 10Gergő Tisza) [22:10:23] (03PS1) 10Bsitu: Reply link hash mismatch [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137210 [22:10:26] (03CR) 10jenkins-bot: [V: 04-1] Reply link hash mismatch [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137210 (owner: 10Bsitu) [22:11:29] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Stopwords are not optional and are worth as much as exact matches - 10https://bugzilla.wikimedia.org/60362#c4 (10Chad H.) We've had 1.1 for a bit now and we're looking at 1.2. Upstream issue seems closed & merged so can we consider this resolved (or possib... [22:14:19] Krinkle: https://integration.wikimedia.org/ci/job/mwext-MultimediaViewer-qunit/1930/consoleFull [22:14:28] Did I just get hit by jquery being upgraded? [22:14:59] "TypeError: 'undefined' is not an object (evaluating '$.browser.msie') TypeError: 'undefined' is not an object (evaluating '$.browser.msie')" [22:15:01] (03PS5) 10Jdlrobson: Remove dependency on ext.mantle.oo to Hogan [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137086 [22:15:17] (03PS2) 10Bsitu: Reply link hash mismatch [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137210 [22:15:23] (03PS1) 10Legoktm: Add SpecialPage::getConfig [core] - 10https://gerrit.wikimedia.org/r/137211 [22:16:01] 3MediaWiki / 3ResourceLoader: ResourceLoaderLESSFunctions::embed does not support CSSJanus flipping for RTL - 10https://bugzilla.wikimedia.org/66091 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None The LESS embed function in ResourceLoaderLESSFunctions does not support using the flipped version... [22:16:59] 3MediaWiki / 3ResourceLoader: LESS compiler should preserve the position of CSSMin / CSSJanus annotations - 10https://bugzilla.wikimedia.org/54673 (10Matthew Flaschen) [22:16:59] 3MediaWiki / 3ResourceLoader: ResourceLoaderLESSFunctions::embed does not support CSSJanus flipping for RTL - 10https://bugzilla.wikimedia.org/66091 (10Matthew Flaschen) [22:17:53] (03CR) 10Aaron Schulz: [C: 032] Add SpecialPage::getConfig [core] - 10https://gerrit.wikimedia.org/r/137211 (owner: 10Legoktm) [22:18:39] (03PS2) 10Bsitu: Fix offset erros when clicking on "Load More" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137190 [22:18:59] 3MediaWiki / 3ResourceLoader: ResourceLoaderLESSFunctions::embed does not support CSSJanus flipping for RTL - 10https://bugzilla.wikimedia.org/66091#c1 (10Matthew Flaschen) (In reply to Matthew Flaschen from comment #0) > CSSJanus does not actually flip the image in this case. It just uses a > filename endi... [22:20:05] (03PS1) 10MarkTraceur: Updating MultimediaViewer to fix preference name [core] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137213 [22:20:13] marktraceur: Ha, sort of. [22:20:21] marktraceur: We flipped the switch for master, but not wmf-config. [22:20:25] (03CR) 10MarkTraceur: [C: 032] Updating MultimediaViewer to fix preference name [core] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137213 (owner: 10MarkTraceur) [22:20:29] Most local devs will want to set it to true for the time being [22:20:36] Ah. [22:20:38] Brilliant [22:20:38] Didn't think about Jenkins's environment. [22:20:47] I'll set it to true there. [22:20:58] marktraceur: Consider this a reminder though. [22:21:03] :) [22:21:18] (03PS2) 10Bsitu: Special:RecentChanges is borked [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137166 [22:21:34] (03CR) 10EBernhardson: Add post reply no-js support (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137089 (owner: 10Bsitu) [22:21:45] (03PS4) 10EBernhardson: Add post reply no-js support [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137089 (owner: 10Bsitu) [22:22:08] (03Merged) 10jenkins-bot: Add SpecialPage::getConfig [core] - 10https://gerrit.wikimedia.org/r/137211 (owner: 10Legoktm) [22:22:47] (03PS3) 10Gergő Tisza: Move funnel logging into its own component [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/134283 [22:23:56] (03CR) 10Jdlrobson: [C: 032] Fix JSHint warnings [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137085 (owner: 10Jdlrobson) [22:24:29] 3MediaWiki extensions / 3Translate: Special:MovePage should provide option to create redirect and move talk - 10https://bugzilla.wikimedia.org/39023#c2 (10Tilman Bayer) Just a note that this still causes lots of broken links (when moving translatable pages, via bug 60920), see e.g. https://meta.wikimedia.org... [22:24:34] (03Merged) 10jenkins-bot: Fix JSHint warnings [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137085 (owner: 10Jdlrobson) [22:25:03] (03Merged) 10jenkins-bot: Updating MultimediaViewer to fix preference name [core] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137213 (owner: 10MarkTraceur) [22:27:14] 3MediaWiki extensions / 3Translate: Special:MovePage should provide option to create redirect and move talk - 10https://bugzilla.wikimedia.org/39023#c3 (10Nemo) (In reply to Tilman Bayer from comment #2) > Just a note that this still causes lots of broken links Yes, IMHO this is not a feature request but a... [22:27:44] 3MediaWiki extensions / 3Translate: Moving a translatable page doesn't create a redirect to the original page (or give the option to create one) - 10https://bugzilla.wikimedia.org/60920#c3 (10Nemo) (In reply to Niklas Laxström from comment #1) > Work around is to create the redirect(s) manually. Or with pag... [22:29:46] 3Wikimedia / 3Extension setup: Deploy Mantle extension to WMF servers - 10https://bugzilla.wikimedia.org/66094 (10Jon) 3NEW p:3Unprio s:3normal a:3None Flow and MobileFrontend want to share code that is not quite ready for MediaWiki core (core/mantle - get it?). One big example is sharing of deliveri... [22:30:00] 3Wikimedia / 3Extension setup: Extensions awaiting code review to be deployed on Wikimedia wikis (tracking) - 10https://bugzilla.wikimedia.org/31235 (10Jon) [22:30:00] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Look into removing hack used to pick which redirect was highlighted in search result - 10https://bugzilla.wikimedia.org/57012#c1 (10Chad H.) Didn't we remove this hack already? [22:30:41] (03CR) 10Spage: "I don't get the slight differences with core's .jshintrc, but make jshint passes, so OK!" [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137085 (owner: 10Jdlrobson) [22:33:10] (03PS1) 10Krinkle: mediawiki/conf.d: Clean up code and fix English grammar [integration/jenkins] - 10https://gerrit.wikimedia.org/r/137215 [22:33:22] (03CR) 10Krinkle: [C: 032] mediawiki/conf.d: Clean up code and fix English grammar [integration/jenkins] - 10https://gerrit.wikimedia.org/r/137215 (owner: 10Krinkle) [22:33:25] (03Merged) 10jenkins-bot: mediawiki/conf.d: Clean up code and fix English grammar [integration/jenkins] - 10https://gerrit.wikimedia.org/r/137215 (owner: 10Krinkle) [22:34:52] (03PS5) 10EBernhardson: Add post reply no-js support [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137089 (owner: 10Bsitu) [22:35:21] (03CR) 10EBernhardson: "PS5 undoes PS4, the differences are minor but enough that its not worthwhile to remove the duplication" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137089 (owner: 10Bsitu) [22:35:27] (03CR) 10EBernhardson: [C: 032] Add post reply no-js support [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137089 (owner: 10Bsitu) [22:35:43] (03Merged) 10jenkins-bot: Add post reply no-js support [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137089 (owner: 10Bsitu) [22:36:20] (03PS1) 10Legoktm: Use Config classes for accessing configuration settings [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/137216 [22:36:33] (03PS1) 10Krinkle: Set $wgIncludejQueryMigrate = true; [integration/jenkins] - 10https://gerrit.wikimedia.org/r/137217 [22:36:53] (03CR) 10Krinkle: [C: 032] Set $wgIncludejQueryMigrate = true; [integration/jenkins] - 10https://gerrit.wikimedia.org/r/137217 (owner: 10Krinkle) [22:36:56] (03Merged) 10jenkins-bot: Set $wgIncludejQueryMigrate = true; [integration/jenkins] - 10https://gerrit.wikimedia.org/r/137217 (owner: 10Krinkle) [22:37:34] (03PS1) 10Chad: Strip .catlinks entirely, don't store in auxiliary_text [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/137218 [22:40:43] 3MediaWiki / 3JavaScript: jquery.client.js: test is wrong for subversions >= 10 - 10https://bugzilla.wikimedia.org/29446#c7 (10Matthew Flaschen) 5NEW>3RESO/FIX Yeah, I think this was fixed by that. [22:41:15] 3MediaWiki / 3JavaScript: jquery.client.js: test is wrong for subversions >= 10 - 10https://bugzilla.wikimedia.org/29446 (10Matthew Flaschen) a:3Bartosz Dziewoński [22:41:24] (03CR) 10EBernhardson: [C: 032] Remove dependency on ext.mantle.oo to Hogan (031 comment) [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137086 (owner: 10Jdlrobson) [22:41:30] (03PS2) 10Legoktm: Use Config classes for accessing configuration settings [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/137216 [22:41:44] (03Merged) 10jenkins-bot: Remove dependency on ext.mantle.oo to Hogan [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137086 (owner: 10Jdlrobson) [22:42:56] (03CR) 10EBernhardson: [C: 032] Reply link hash mismatch [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137210 (owner: 10Bsitu) [22:43:11] (03Merged) 10jenkins-bot: Reply link hash mismatch [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137210 (owner: 10Bsitu) [22:43:16] 3MediaWiki / 3JavaScript: Remove all uses of jQuery.browser (tracking) - 10https://bugzilla.wikimedia.org/66097 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None I'm putting this in MediaWiki/JavaScript, but it's really a tracking bug across extensions, etc. jQuery.browser was removed from jQuer... [22:43:20] (03CR) 10EBernhardson: [C: 032] Special:RecentChanges is borked [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137166 (owner: 10Bsitu) [22:43:35] (03Merged) 10jenkins-bot: Special:RecentChanges is borked [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137166 (owner: 10Bsitu) [22:43:44] 3MediaWiki / 3JavaScript: Remove all uses of jQuery.browser (tracking) - 10https://bugzilla.wikimedia.org/66097 (10Matthew Flaschen) [22:43:44] 3Wikimedia / 3General/Unknown: Don't use deprecated features removed in jQuery 1.9 (tracking) - 10https://bugzilla.wikimedia.org/65399 (10Matthew Flaschen) [22:44:59] 3MediaWiki / 3JavaScript: Remove all uses of jQuery.browser (tracking) - 10https://bugzilla.wikimedia.org/66097 (10Matthew Flaschen) [22:45:30] 3Wikimedia / 3General/Unknown: Don't use deprecated features removed in jQuery 1.9 (tracking) - 10https://bugzilla.wikimedia.org/65399 (10Matthew Flaschen) [22:45:30] 3MediaWiki / 3JavaScript: Remove all uses of jQuery.browser (tracking) - 10https://bugzilla.wikimedia.org/66097 (10Matthew Flaschen) [22:45:30] 3MediaWiki extensions / 3SemanticForms: SemanticForms: Fix "JQMIGRATE: jQuery.browser is deprecated" - 10https://bugzilla.wikimedia.org/65668 (10Matthew Flaschen) [22:46:00] 3Wikimedia / 3General/Unknown: Don't use deprecated features removed in jQuery 1.9 (tracking) - 10https://bugzilla.wikimedia.org/65399 (10Matthew Flaschen) [22:46:00] 3MediaWiki / 3JavaScript: Remove all uses of jQuery.browser (tracking) - 10https://bugzilla.wikimedia.org/66097 (10Matthew Flaschen) [22:47:59] 3MediaWiki / 3JavaScript: Remove all uses of jQuery.browser (tracking) - 10https://bugzilla.wikimedia.org/66097 (10Matthew Flaschen) [22:48:58] (03CR) 10Tim Starling: "I'm pretty skeptical about the need for this." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/133830 (owner: 10Jackmcbarn) [22:51:03] (03CR) 10Spage: "ext.mantle.oo only needs ext.mantle." (031 comment) [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137086 (owner: 10Jdlrobson) [22:52:29] 3MediaWiki extensions / 3WikidataRepo: review backend part of entity suggester (php code) - 10https://bugzilla.wikimedia.org/63224#c5 (10Chris Steipp) In general, please follow the style guide (unless Wikibase has it's own) The build directory shouldn't be web accessible-- is this meant to be removed in pro... [22:52:53] (03PS1) 10Yurik: Add getDefault() to JCContentView [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/137219 [22:53:55] (03CR) 10EBernhardson: Fix offset erros when clicking on "Load More" (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137190 (owner: 10Bsitu) [23:03:28] (03CR) 10Ori.livneh: [C: 032] Submodule update to deploy styles + edit tag [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137208 (owner: 10Yuvipanda) [23:03:41] (03CR) 10Ori.livneh: [C: 032] Submodule update to deploy updated styles [core] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137209 (owner: 10Yuvipanda) [23:03:55] (03PS1) 10Bsitu: LCrun2 is renamed to LCrun3 [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137220 [23:03:59] woo, fixed now! https://wikitech.wikimedia.org/wiki/Deployments [23:04:31] 3MediaWiki extensions / 3Mantle: Remove default template compiler - 10https://bugzilla.wikimedia.org/66099 (10Jon) 3NEW p:3Unprio s:3normal a:3None MobileFrontend should declare 'hogan' as the language of all its templates. The concept of a default compiler is nasty and should be killed with fire. [23:04:45] (03CR) 10Jdlrobson: Remove dependency on ext.mantle.oo to Hogan (032 comments) [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137086 (owner: 10Jdlrobson) [23:06:21] (03PS1) 10Jdlrobson: Remove dependencies on ext.mantle.oo [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137221 [23:07:33] (03Merged) 10jenkins-bot: Submodule update to deploy styles + edit tag [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/137208 (owner: 10Yuvipanda) [23:07:52] (03CR) 10Tim Starling: [C: 04-2] "-2 for fairly obvious reasons. The ability to do expensive things that don't increment the expensive parser function call does not make ev" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/127160 (owner: 10Jackmcbarn) [23:08:44] 3MediaWiki-Vagrant: mediawiki-vagrant reports an error when provisioning "browsertests" role - 10https://bugzilla.wikimedia.org/61285#c10 (10Dan Duvall) The failure I was having appears to have been an issue with the older packaged version of Bundler that is installed by `puppet/modules/browsertests/manifests/... [23:08:53] (03Merged) 10jenkins-bot: Submodule update to deploy updated styles [core] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137209 (owner: 10Yuvipanda) [23:08:54] (03CR) 10Tim Starling: "What's wrong with using frame:callParserFunction?" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/124620 (owner: 10Jackmcbarn) [23:09:43] (03CR) 10Jackmcbarn: "It needs a frame (which is annoying) and it's probably slower than this, but the big reason is proper error handling." [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/124620 (owner: 10Jackmcbarn) [23:11:03] (03PS3) 10EBernhardson: New configuration option $wgFlowForceTemplateRecompile [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/134668 (owner: 10Spage) [23:11:07] (03CR) 10jenkins-bot: [V: 04-1] New configuration option $wgFlowForceTemplateRecompile [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/134668 (owner: 10Spage) [23:11:42] (03CR) 10Bsitu: Fix offset erros when clicking on "Load More" (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137190 (owner: 10Bsitu) [23:12:17] (03CR) 10EBernhardson: [C: 032] Fix offset erros when clicking on "Load More" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137190 (owner: 10Bsitu) [23:12:32] (03Merged) 10jenkins-bot: Fix offset erros when clicking on "Load More" [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137190 (owner: 10Bsitu) [23:15:57] (03PS2) 10Krinkle: Remove jQuery Migrate and $wgIncludejQueryMigrate [core] - 10https://gerrit.wikimedia.org/r/137168 (owner: 10Jforrester) [23:16:17] (03CR) 10Tim Starling: "The previous plan (suggested by Gabriel) was that alternative expansion modes would be provided via the ParserValue object returned by fra" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/123672 (owner: 10Jackmcbarn) [23:17:38] (03CR) 10Tim Starling: [C: 04-2] "So make frame:expandTemplate() expensive." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127161 (owner: 10Jackmcbarn) [23:18:30] (03PS1) 10Jdlrobson: Break out require and define from mantle into own module [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137223 [23:18:52] (03Abandoned) 10Jackmcbarn: Don't count loading titles as expensive [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127161 (owner: 10Jackmcbarn) [23:19:32] (03CR) 10Tim Starling: [C: 04-2] "Not really in keeping with the philosophy of LuaSandbox." [php/luasandbox] - 10https://gerrit.wikimedia.org/r/133842 (owner: 10Jackmcbarn) [23:19:51] (03PS4) 10EBernhardson: New configuration option wgFlowServerCompileTemplates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/134668 (owner: 10Spage) [23:21:22] (03CR) 10EBernhardson: [C: 032] LCrun2 is renamed to LCrun3 [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137220 (owner: 10Bsitu) [23:21:36] (03Merged) 10jenkins-bot: LCrun2 is renamed to LCrun3 [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137220 (owner: 10Bsitu) [23:22:34] (03CR) 10Isarra: [C: 032 V: 032] "What happens if I do this?" [skins] - 10https://gerrit.wikimedia.org/r/136989 (owner: 10QChris) [23:22:42] (03CR) 10EBernhardson: [C: 032] fix TypeError: mw.user.name(...) is null exception [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137202 (owner: 10Spage) [23:22:58] (03Merged) 10jenkins-bot: fix TypeError: mw.user.name(...) is null exception [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137202 (owner: 10Spage) [23:23:04] (03CR) 10Isarra: [C: 031] "Do it." [core] - 10https://gerrit.wikimedia.org/r/136650 (owner: 10Daniel Friesen) [23:23:41] (03CR) 10Tim Starling: "I don't know why we even have CASCADINGSOURCES." [core] - 10https://gerrit.wikimedia.org/r/135276 (owner: 10Jackmcbarn) [23:24:35] (03CR) 10EBernhardson: [C: 032] Flow: notification exceptions: urlGenerator->workflowLink() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136958 (https://bugzilla.wikimedia.org/66060) (owner: 10Bsitu) [23:24:49] (03Merged) 10jenkins-bot: Flow: notification exceptions: urlGenerator->workflowLink() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136958 (https://bugzilla.wikimedia.org/66060) (owner: 10Bsitu) [23:26:09] hello? [23:26:14] anyone here? [23:32:46] 3Analytics / 3EventLogging: EventLogging qunit test failure in ?debug=1 mode - 10https://bugzilla.wikimedia.org/66100 (10spage) 3NEW p:3Unprio s:3minor a:3None https://test2.wikipedia.org/wiki/Special:JavaScriptTest/qunit?filter=ext.eventLogging&debug=1 gets a 404 failure requesting https://bits.... [23:33:53] (03PS1) 10Spage: Adjust paths so tests pass in RL debug mode [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/137226 (https://bugzilla.wikimedia.org/66100) [23:35:01] (03CR) 10SG: [C: 032] Remove dependencies on ext.mantle.oo [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137221 (owner: 10Jdlrobson) [23:35:23] (03Merged) 10jenkins-bot: Remove dependencies on ext.mantle.oo [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/137221 (owner: 10Jdlrobson) [23:35:51] 3Analytics / 3EventLogging: Multiple user_ids per username in account creation events from ServerSideAccountCreation log - 10https://bugzilla.wikimedia.org/66101 (10Dario Taraborelli) 3NEW p:3Unprio s:3normal a:3None There are ca. 14K account creation events generated in April (from both the mobile a... [23:41:43] (03PS1) 10Yuvipanda: Complete moving android specific styles to android.less [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/137227 [23:43:19] (03PS2) 10EBernhardson: replace dummy l10n messages with actual i18n keys [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/136633 (owner: 10Spage) [23:45:29] 3MediaWiki / 3JavaScript: Upgrade jQuery from 1.8.x to 1.11.x - 10https://bugzilla.wikimedia.org/44740 (10James Forrester) 5PATC>3ASSI [23:53:24] (03CR) 10GWicke: "The risk I see here is that Lua modules could start parsing parameters according to their own rules, rather than following the normal wiki" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/123672 (owner: 10Jackmcbarn) [23:57:59] (03PS1) 10Bsitu: Check empty links and pagination in templates [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/137228