[00:00:20] (03CR) 10MSyed: [C: 032 V: 032] Add read me [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/136262 (owner: 10MSyed) [00:05:25] (03PS1) 10Bsitu: Fix broken diff links from history page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136265 [00:05:43] (03CR) 10jenkins-bot: [V: 04-1] Fix broken diff links from history page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136265 (owner: 10Bsitu) [00:07:08] (03PS2) 10Bsitu: Fix broken diff links from history/watchlist page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136265 (https://bugzilla.wikimedia.org/65814) [00:07:25] (03CR) 10jenkins-bot: [V: 04-1] Fix broken diff links from history/watchlist page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136265 (https://bugzilla.wikimedia.org/65814) (owner: 10Bsitu) [00:17:45] 3Wikimedia / 3General/Unknown: out of memory for some animated GIF images on Commons - 10https://bugzilla.wikimedia.org/61711#c6 (10Bawolff (Brian Wolff)) (In reply to Dominic from comment #5) > This may be a separate issue, but that error message is particularly > unhelpful. When you hit the MP limit, at le... [00:33:28] gwicke: only 1 shared cache hit on [[List of go games]] [00:35:03] jackmcbarn, nice! [00:35:23] gwicke: how so? that just means that's an uninteresting page to test on [00:35:47] that's another way to interpret it ;) [00:35:58] trying the japanese page now. looks like it has a lot [00:36:27] there's a hidden table in the infobox that's pretty insane [00:36:32] all templated [00:37:34] gwicke: 4609 shared cache hits [00:38:02] is this with or without {{!}} ? [00:38:06] that's with [00:38:08] 3007 without [00:38:17] doing non-shared test now... [00:38:35] that sounds like it could have a measurable performance impact [00:40:04] without sharing, 2572 countiing {{!}}, and 2212 not counting it [00:40:48] is there a measurable time difference? [00:40:54] checking that now [00:41:29] a delta of around 800 less shared expansions might be noticeable [00:42:48] sharing expansions, without ! as a magic word, takes me about 11.1 seconds [00:43:59] not sharing expansions, without ! as a magic word, takes about 11.2 seconds (and i'm not being accurate enough to conclude there's even a difference at all) [00:44:03] now with ! as a magic word... [00:45:12] sharing expansions, with ! as a magic word, takes me about 10.9 seconds [00:45:15] interesting.. that means that it's probably very cheap expansions that are un-shared [00:45:49] (03PS1) 10Bsitu: Should not try to parse reference from topic title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136270 (https://bugzilla.wikimedia.org/65570) [00:46:08] (03CR) 10jenkins-bot: [V: 04-1] Should not try to parse reference from topic title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136270 (https://bugzilla.wikimedia.org/65570) (owner: 10Bsitu) [00:46:58] (03PS3) 10Robmoen: Create PostLoginRedirect Hook for changing the redirect behavior [core] - 10https://gerrit.wikimedia.org/r/135886 (https://bugzilla.wikimedia.org/65619) [00:47:02] otoh, a 0.3 second difference on a page with that many cache hits means that the cache is barely having an effect [00:47:47] there are still quite a few cache hits without cross-frame sharing though [00:48:04] and those might be the more expensive ones [00:48:47] on that one page, all the hits were either on Template:! or Template:BSpx [00:51:33] jackmcbarn, do you also have a timing for ! as magic word & no cross-frame sharing? [00:51:54] those results were all over the place [00:52:04] i'm rerunning the test again, this time with the page copied-and-pasted to have 3x the same content [00:52:24] that'll skew the results though [00:52:51] will it? the ratios will still be the same [00:53:07] there's more repetition then, which should favor sharing [00:54:00] it's good to try that too to see what the effect on repetitive content is [00:55:42] ok, without magic word and with sharing, 16.6, 16.9, 16.8 were times [00:57:18] with magic word and with sharing, 16.5, 16.6, and 16.4 [00:59:09] without magic word and without sharing, 16.7, 16.7, and 17.0 [01:00:53] with magic word and without sharing, 16.4, 16.5, 16.4 [01:05:29] that's very close [01:05:59] for comparison, if i kill the empty frame cache completely, times are 34.0 and 34.5 without the magic word, and 33.1 and 33.1 with the magic word [01:06:47] it probably means that the repetition normally happens at a single level and thus frame [01:07:08] and lower-level repetitions tend to be cheap [01:07:52] TimStarling, ^^ [01:08:16] and that means that we never have to worry about sharing between levels, right? [01:09:01] at least we have not found a convincing case where it matters yet [01:09:30] that case seems pretty pathological to me, so i doubt such a page exists now [01:09:52] yeah, I doubt it too [01:10:19] so +1 from me for keeping it simple [01:11:05] ok, I guess I can give CR +1 [01:11:24] it's good when caching is not user-visible, and this change will help with that [01:13:05] oh, except for one thing [01:13:12] "// we don't have a parent, so we don't have a cache" [01:13:53] what about it? [01:14:28] just trying to work out if that will ever be called [01:15:26] I guess cachedExpand() is only called on the result of newChild() [01:15:30] when i put a die() there it doesn't hit it. i doubt it ever gets called, but i want the interfaces consistent [01:16:43] ok [01:17:41] (03CR) 10Tim Starling: [C: 031] "Looks good to me. Can be merged if nobody else has objections." [core] - 10https://gerrit.wikimedia.org/r/135980 (owner: 10Jackmcbarn) [01:17:57] jackmcbarn, it would be nice if you could summarize the measurement results in the commit message [01:18:07] for later reference [01:19:16] (03PS1) 10Bsitu: Error message should be parsed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136272 (https://bugzilla.wikimedia.org/65920) [01:19:37] (03CR) 10jenkins-bot: [V: 04-1] Error message should be parsed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136272 (https://bugzilla.wikimedia.org/65920) (owner: 10Bsitu) [01:20:45] (03CR) 10Jackmcbarn: "With regards to performance: without this change, parsing a given page 3 times took 16.6, 16.9, and 16.8 seconds. With this change, parsin" [core] - 10https://gerrit.wikimedia.org/r/135980 (owner: 10Jackmcbarn) [01:23:33] (03CR) 10GWicke: [C: 031] "Could you add the perf stats to the commit message, and mention the page & revision this was measured with? The difference in # of hits is" [core] - 10https://gerrit.wikimedia.org/r/135980 (owner: 10Jackmcbarn) [01:31:17] (03PS9) 10Physikerwelt: Add separate database table for LaTeXML (step 5) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135839 (https://bugzilla.wikimedia.org/65522) [01:31:23] (03PS5) 10Jackmcbarn: Restrict empty-frame cache entries to their parent [core] - 10https://gerrit.wikimedia.org/r/135980 [01:33:23] (03CR) 10jenkins-bot: [V: 04-1] Add separate database table for LaTeXML (step 5) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135839 (https://bugzilla.wikimedia.org/65522) (owner: 10Physikerwelt) [01:37:25] jackmcbarn, let me break the commit message at 80 chars [01:38:19] (03PS6) 10GWicke: Restrict empty-frame cache entries to their parent [core] - 10https://gerrit.wikimedia.org/r/135980 (owner: 10Jackmcbarn) [01:38:55] (03CR) 10GWicke: [C: 032] "Reformatted commit message to be 80ish chars wide." [core] - 10https://gerrit.wikimedia.org/r/135980 (owner: 10Jackmcbarn) [01:40:05] jackmcbarn, thank you! [01:40:17] you're welcome! [01:41:54] * jackmcbarn anxiously watches jenkins run the tests, waiting for it to somehow screw up [01:42:32] I'm still trying to get that huge rail line table to expand on https://ja.wikipedia.org/wiki/%E4%B8%AD%E5%A4%AE%E7%B7%9A_(%E9%9F%93%E5%9B%BD) [01:42:59] at the bottom of the infobox [01:43:04] (03Merged) 10jenkins-bot: Restrict empty-frame cache entries to their parent [core] - 10https://gerrit.wikimedia.org/r/135980 (owner: 10Jackmcbarn) [01:43:36] i think [[en:Keretapi Tanah Melayu]] is a similar page [01:44:23] indeed [01:44:37] (03PS5) 10Jackmcbarn: Add PPFrame::getTTL() and setTTL() [core] - 10https://gerrit.wikimedia.org/r/135887 (https://bugzilla.wikimedia.org/49803) [01:48:13] I'm heading out, see you! [01:51:28] (03PS8) 10Jackmcbarn: Add PPFrame::isVolatile and PPFrame::setVolatile [core] - 10https://gerrit.wikimedia.org/r/99792 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [01:52:13] (03CR) 10Jackmcbarn: "Lots of changes to this now due to I621e9075e0f136ac188a4d2f53418b7cc957408d." [core] - 10https://gerrit.wikimedia.org/r/99792 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [01:56:18] TimStarling: i'm tryong to apply that same fix to extensions/Scribunto/engines/LuaCommon/LuaCommon.php:doCachedExpansion, but i'm running into a difficulty in finding how to store the cached entries [02:24:16] 3MediaWiki extensions / 3Popups: Hovercards: TypeError: re.query is undefined on # links - 10https://bugzilla.wikimedia.org/65425#c4 (10spage) 5PATC>3ASSI Gerrit 135188 ignores '#', which is often the href of "links" that trigger JavaScript operations such as expand/contract, etc. However, you also see... [02:24:49] 3MediaWiki extensions / 3Popups: Hovercards wastes API call and "TypeError re.query is undefined" on external links and other links with no title - 10https://bugzilla.wikimedia.org/65929 (10spage) 3NEW p:3Unprio s:3normal a:3None Popups makes API queries for external links like (03CR) 10Skizzerz: "Just a couple of minor things I noticed with the sql script; nothing wrong, just some nonstandard conventions." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/135714 (https://bugzilla.wikimedia.org/65757) (owner: 10Rillke) [02:43:45] 3Wikimedia / 3General/Unknown: out of memory for some animated GIF images on Commons - 10https://bugzilla.wikimedia.org/61711#c7 (10Dominic) It may not help the average user experience (though if they are hitting this error, I am nit sure they can be helped), but I was just thinking how frustrated I get at v... [02:45:22] (03CR) 10Parent5446: "Well at the very least it needs release notes." [core] - 10https://gerrit.wikimedia.org/r/136234 (owner: 10Jackmcbarn) [02:50:00] (03PS11) 10Rillke: Name implicitly created CHECK constraints [core] - 10https://gerrit.wikimedia.org/r/135714 (https://bugzilla.wikimedia.org/65757) [02:50:18] (03CR) 10Rillke: "Thanks for the quick review." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/135714 (https://bugzilla.wikimedia.org/65757) (owner: 10Rillke) [02:50:30] (03PS3) 10Jackmcbarn: Support {{!}} as a magic word [core] - 10https://gerrit.wikimedia.org/r/136234 [02:50:33] (03PS4) 10Jackmcbarn: Support {{!}} as a magic word [core] - 10https://gerrit.wikimedia.org/r/136234 [02:52:30] (03PS11) 10Physikerwelt: Add separate database table for LaTeXML (step 5) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135839 (https://bugzilla.wikimedia.org/65522) [02:53:32] (03CR) 10Parent5446: [C: 032] PostgreSQL: Support table prefixes [core] - 10https://gerrit.wikimedia.org/r/135998 (owner: 10Jjanes) [02:57:07] (03Merged) 10jenkins-bot: PostgreSQL: Support table prefixes [core] - 10https://gerrit.wikimedia.org/r/135998 (owner: 10Jjanes) [02:58:00] 3MediaWiki extensions / 3BookManagerv2: Find previous/next links in the navbar more efficiently - 10https://bugzilla.wikimedia.org/52435 (10Raylton P. Sousa) 5PATC>3RESO/FIX [03:28:22] (03PS1) 10Jackmcbarn: Expose file page count, width, and height to Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/136274 [03:40:25] (03CR) 10GWicke: [C: 031] Support {{!}} as a magic word [core] - 10https://gerrit.wikimedia.org/r/136234 (owner: 10Jackmcbarn) [03:58:46] 3MediaWiki extensions / 3LocalisationUpdate: sa translation not showing up in interface - 10https://bugzilla.wikimedia.org/65334#c10 (10NehalDaveND) Hi I think those changes have been done but changes are not applied. Please guide us for applying those changes in sa.wikipedia.org .... Thank you for helping.... [04:04:02] I have had a brain freeze, could someone remind me of the name of the extension for talk pages that is in use on Mediawikiwiki? [04:05:00] LiquidThreads [04:05:10] sometimes abbreviated LQT [04:05:19] http://www.mediawiki.org/wiki/Extension:LiquidThreads [04:06:11] hi Risker, by the way :) [04:06:28] thank you, ori! Hello to you too! [04:32:41] (03PS5) 10KartikMistry: Update the Dict client to match the updated API output format [services/cxserver] - 10https://gerrit.wikimedia.org/r/135022 (owner: 10Santhosh) [04:43:57] (03PS1) 10Rillke: Preserve title when fetching original file from Flickr [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/136277 (https://bugzilla.wikimedia.org/65931) [04:45:39] (03PS2) 10Rillke: Preserve title when fetching original file from Flickr [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/136277 (https://bugzilla.wikimedia.org/65931) [05:00:07] (03PS1) 10Santhosh: Use the port from config.js if available [services/cxserver] - 10https://gerrit.wikimedia.org/r/136278 (https://bugzilla.wikimedia.org/64540) [05:01:17] 3MediaWiki extensions / 3ContentTranslation: Attribute 'port' from config.js is non-consequential - 10https://bugzilla.wikimedia.org/64540 (10Santhosh Thottingal) p:5Unprio>3Normal a:3Santhosh Thottingal [05:02:18] 3MediaWiki extensions / 3ContentTranslation: PageLoader for multiple wikis - 10https://bugzilla.wikimedia.org/62202 (10Santhosh Thottingal) 5NEW>3ASSI a:3Santhosh Thottingal [05:02:45] 3MediaWiki extensions / 3ContentTranslation: PageLoader for multiple wikis - 10https://bugzilla.wikimedia.org/62202#c1 (10Santhosh Thottingal) 5ASSI>3RESO/FIX This was fixed in https://gerrit.wikimedia.org/r/#/c/135016/ [05:04:00] 3MediaWiki extensions / 3ContentTranslation: Design Redis storage layout - 10https://bugzilla.wikimedia.org/62203#c2 (10Santhosh Thottingal) 5NEW>3RESO/INV Invalid as per the current architecture. Redis is not part of architecture [05:04:47] 3MediaWiki extensions / 3ContentTranslation: CXDataModelManager needs a task dispatcher - 10https://bugzilla.wikimedia.org/62206#c2 (10Santhosh Thottingal) 5NEW>3RESO/INV a:3Santhosh Thottingal Invalid as per the stateless architecture we are working now. https://www.mediawiki.org/wiki/Content_translat... [05:07:39] (03PS1) 10devunt: Updated author infomation. [extensions/LogoFunctions] - 10https://gerrit.wikimedia.org/r/136279 [05:08:30] (03PS1) 10Werdna: Segregate Reference objects by source wiki. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136280 (https://bugzilla.wikimedia.org/65915) [05:08:52] (03CR) 10jenkins-bot: [V: 04-1] Segregate Reference objects by source wiki. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136280 (https://bugzilla.wikimedia.org/65915) (owner: 10Werdna) [05:17:36] 3MediaWiki extensions / 3Validator: Validator/ParamParser broken on 5.3 due to autoloader - 10https://bugzilla.wikimedia.org/65932 (10Daniel Friesen) 3NEW p:3Unprio s:3normal a:3None Fatal error: Class '\ValueValidators\RangeValidator' not found in {...}/extensions/Validator/includes/ParamProcessor/P... [05:24:39] (03CR) 10Krinkle: SpecialUnwatchedpages: Ajaxify watch links (031 comment) [core] - 10https://gerrit.wikimedia.org/r/6143 (https://bugzilla.wikimedia.org/17367) (owner: 10Eranroz) [05:24:41] (03PS1) 10Krinkle: mediawiki.special.unwatchedPages: Use closest() instead of parents() [core] - 10https://gerrit.wikimedia.org/r/136281 [05:24:58] (03CR) 10Krinkle: SpecialUnwatchedpages: Ajaxify watch links (031 comment) [core] - 10https://gerrit.wikimedia.org/r/6143 (https://bugzilla.wikimedia.org/17367) (owner: 10Eranroz) [05:25:40] (03PS2) 10Krinkle: mediawiki.special.unwatchedPages: Use closest() instead of parents() [core] - 10https://gerrit.wikimedia.org/r/136281 [05:31:10] (03PS1) 10Legoktm: Revert "Add AntiSpoof to Flow dependencies" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136283 [05:32:02] (03PS2) 10Legoktm: Revert "Add AntiSpoof to Flow dependencies" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136283 [05:32:12] (03CR) 10Legoktm: "See https://integration.wikimedia.org/ci/job/mwext-Flow-testextensions-master/4317/console for example." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136283 (owner: 10Legoktm) [05:35:24] (03CR) 10Legoktm: [C: 032] "Test failure is unrelated" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136272 (https://bugzilla.wikimedia.org/65920) (owner: 10Bsitu) [05:35:40] (03CR) 10jenkins-bot: [V: 04-1] Error message should be parsed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136272 (https://bugzilla.wikimedia.org/65920) (owner: 10Bsitu) [05:46:02] 3MediaWiki extensions / 3ContentTranslation: Page freeze when 'Add translation' is clicked in a certain case - 10https://bugzilla.wikimedia.org/64542 (10Santhosh Thottingal) 5NEW>3ASSI p:5Unprio>3Normal a:3Santhosh Thottingal [05:46:10] (03PS1) 10Werdna: Fix ccnorm() function -- strtr fails when an empty key is provided [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/136285 [05:47:02] 3MediaWiki extensions / 3Translate: Display appropriate error messages for Special:PageMigration - 10https://bugzilla.wikimedia.org/65933 (10Pratik Lahoti) 3NEW p:3Unprio s:3normal a:3None Error handling needs to be done for Special:PageMigration. Whenever errors occur, appropriate error messages sho... [05:48:16] 3MediaWiki extensions / 3Translate: Special page for migration of legacy translation pages (tracking) - 10https://bugzilla.wikimedia.org/65740 (10Pratik Lahoti) [05:48:17] 3MediaWiki extensions / 3Translate: Display appropriate error messages for Special:PageMigration - 10https://bugzilla.wikimedia.org/65933 (10Pratik Lahoti) a:3Pratik Lahoti [05:52:38] (03PS2) 10Werdna: Fix ccnorm() function -- strtr fails when an empty key is provided [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/136285 [06:01:45] 3MediaWiki extensions / 3WikidataRepo: Wikidata parses dates incorrectly (in Portuguese) - 10https://bugzilla.wikimedia.org/65722#c4 (10JAn Dudík) Similar problem: Common czech format DD.MM.YYY or DD. MM. YYY is not recognized. DD-MM-YYY works fine [06:16:04] How can I join gerrit group? [06:18:19] (03PS3) 10Pastakhov: add objects support (version 2.0.0 hook release 3) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/135995 [06:19:03] (03CR) 10Gilles: [C: 032] Preserve title when fetching original file from Flickr [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/136277 (https://bugzilla.wikimedia.org/65931) (owner: 10Rillke) [06:19:30] (03Merged) 10jenkins-bot: Preserve title when fetching original file from Flickr [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/136277 (https://bugzilla.wikimedia.org/65931) (owner: 10Rillke) [06:22:06] devunt: do you mean getting a gerrit account? [06:23:07] no. join a group in gerrit. [06:23:20] oh, okay, not sure then. [06:23:55] I made LogoFunctions extension, but I don't have +2 in gerrit Logofunctions project [06:24:10] wctaiwan: https://gerrit.wikimedia.org/r/#/admin/groups/ [06:24:30] 3Wikimedia / 3General/Unknown: Google Chrome doesnt respect upright of images - 10https://bugzilla.wikimedia.org/65889#c4 (10Juan de Vojníkov) Well, I mean this [[File:Wiktionary screenshot, it-lavare conjugation.jpg|left|upright=0.25]]. Now I wanted to change parameter and show how it displays different siz... [06:24:32] Withoutaname: yeah, I know they exist. Brainfart. [06:26:23] hm, I think we should get rid of some group [06:27:01] like Vector extension, it's in core so we should move the members to mediawiki-core group [06:27:42] doesn't that give them +2 on all core changes? [06:28:41] how would they +2 changes to the Vector "extension" if the commits are made to mw-core [06:29:42] unless perhaps mw-core is somehow split into "Vector" and "everything else", and they only manage the "Vector" part [06:29:55] no idea, honestly. [06:30:12] I should probably just stop talking and let someone more knowledgeable about this speak :P [06:30:26] (03CR) 10Eranroz: [C: 031] "+1 validated and works well" [core] - 10https://gerrit.wikimedia.org/r/136281 (owner: 10Krinkle) [06:31:45] im going to go look at some vector-related bus [06:31:48] *bugs [06:32:24] devunt: looks like you can just request at https://www.mediawiki.org/wiki/Gerrit/Project_ownership, btw [06:34:14] oh, thanks [06:35:01] np [06:37:30] 3MediaWiki extensions / 3Translate: Newline after header is eaten - 10https://bugzilla.wikimedia.org/65900#c3 (10Nemo) 5NEW>3PATC This seems fixed by https://gerrit.wikimedia.org/r/#/c/135750/7 , testing a bit now [06:41:14] (03CR) 10Frédéric Wang: Add separate database table for LaTeXML (step 5) (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135839 (https://bugzilla.wikimedia.org/65522) (owner: 10Physikerwelt) [06:44:30] 3MediaWiki extensions / 3Translate: Restrict access to Special:PageMigration - 10https://bugzilla.wikimedia.org/65791#c3 (10Nemo) Considering the amusing speed at which it saves edits (e.g. http://pagemigration.wmflabs.org/w/index.php?title=Extension:CheckUser/ja&diff=526&oldid=270 ), we'll probably need to... [06:50:00] 3MediaWiki / 3User blocking: Special:Block doesn't warn if no such user - 10https://bugzilla.wikimedia.org/35687#c1 (10TeleComNasSprVen) devunt, are you still working on this? If not, can you please take your name off the assignee field so that someone else can work on it? If you are still working on it, can... [06:53:15] 3MediaWiki extensions / 3Translate: Newline after header is eaten - 10https://bugzilla.wikimedia.org/65900#c4 (10Nemo) Created attachment 15530 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15530&action=edit Last version [06:55:06] (03PS1) 10Jjanes: PostgreSQL: Only rollback when in a transaction [core] - 10https://gerrit.wikimedia.org/r/136287 (https://bugzilla.wikimedia.org/58095) [06:55:45] 3MediaWiki / 3User blocking: Special:Block doesn't warn if no such user - 10https://bugzilla.wikimedia.org/35687#c2 (10JuneHyeon Bae (devunt)) Oh, I forgot about this bug after taking.. I'm working on this bug now. [07:03:33] 3Wikimedia / 3Site requests: Enable MergeHistory for fa.wikipedia sysops - 10https://bugzilla.wikimedia.org/65937 (10Calak) 3UNCO p:3Unprio s:3normal a:3None Hello. Per community consensus (see URL), please enable MergeHistory for fa.wikipedia sysops. Thank you. [07:04:00] 3Wikimedia / 3Site requests: Enable MergeHistory for fa.wikipedia sysops - 10https://bugzilla.wikimedia.org/65937 (10Calak) [07:04:32] 3Wikimedia / 3Site requests: Enable MergeHistory for Persian Wikipedia admins - 10https://bugzilla.wikimedia.org/65938 (10Nemo) 3NEW p:3Unprio s:3enhanc a:3None https://gerrit.wikimedia.org/r/#/c/136284/1 Someone please review consensus at URL. Reza, did you test bug 21824? It's wonderful that fa.w... [07:05:31] 3Wikimedia / 3Site requests: Enable MergeHistory for Persian Wikipedia admins - 10https://bugzilla.wikimedia.org/65938#c1 (10Nemo) *** Bug 65937 has been marked as a duplicate of this bug. *** [07:05:31] 3Wikimedia / 3Site requests: Enable MergeHistory for fa.wikipedia sysops - 10https://bugzilla.wikimedia.org/65937#c1 (10Nemo) 5UNCO>3RESO/DUP Whoops sorry, I wanted to help and filed it myself. :) *** This bug has been marked as a duplicate of bug 65938 *** [07:10:18] (03CR) 10Nemo bis: Lot of standard performance tweaks for those who want them (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/119216 (owner: 10Nemo bis) [07:30:43] (03CR) 10Nikerabbit: [C: 04-1] Qunit tests for dictionary (034 comments) [services/cxserver] - 10https://gerrit.wikimedia.org/r/135412 (owner: 10Santhosh) [07:35:56] (03CR) 10Nikerabbit: Update the Dict client to match the updated API output format (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/135022 (owner: 10Santhosh) [07:36:48] (03CR) 10Nikerabbit: [C: 031] Use the port from config.js if available [services/cxserver] - 10https://gerrit.wikimedia.org/r/136278 (https://bugzilla.wikimedia.org/64540) (owner: 10Santhosh) [07:38:35] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.special.unwatchedPages: Use closest() instead of parents() [core] - 10https://gerrit.wikimedia.org/r/136281 (owner: 10Krinkle) [07:47:15] 3MediaWiki extensions / 3WikidataClient: Add links is missing in MonoBook - 10https://bugzilla.wikimedia.org/64741 (10Lydia Pintscher) s:5normal>3major [07:48:10] (03CR) 10Gilles: [C: 032] bug 61760 get the largest size ( not just the last transcode in the list ) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/114918 (owner: 10Mdale) [07:48:16] 3MediaWiki extensions / 3WikidataClient: Add links is missing in MonoBook - 10https://bugzilla.wikimedia.org/64741#c10 (10Lydia Pintscher) We need to get this fixed in the next deployment. I don't mind which way we fix it. Editors are getting unhappy :( [07:48:22] (03Merged) 10jenkins-bot: bug 61760 get the largest size ( not just the last transcode in the list ) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/114918 (owner: 10Mdale) [07:51:48] (03CR) 10Gilles: [C: 04-1] Automatically re-add transcode jobs if transcode pending for 72h (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/133994 (https://bugzilla.wikimedia.org/61401) (owner: 10Brian Wolff) [07:57:38] The input type="number" for year in Special:Contributions is nice. Not sure if that's new, or just my browser rendering type="number" with a up/down switch. [07:58:43] newish [08:05:03] (03PS1) 10Shirayuki: i18n: Fix double-space [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/136288 [08:18:51] (03PS4) 10Santhosh: Qunit tests for dictionary [services/cxserver] - 10https://gerrit.wikimedia.org/r/135412 [08:18:53] (03CR) 10jenkins-bot: [V: 04-1] Qunit tests for dictionary [services/cxserver] - 10https://gerrit.wikimedia.org/r/135412 (owner: 10Santhosh) [08:20:09] (03PS1) 10devunt: Add $with_str flag [extensions/Josa] - 10https://gerrit.wikimedia.org/r/136289 [08:21:17] (03CR) 10devunt: [C: 032 V: 032] "Merge" [extensions/Josa] - 10https://gerrit.wikimedia.org/r/136289 (owner: 10devunt) [08:25:31] 3Wikimedia / 3General/Unknown: Google Chrome doesnt respect upright of images - 10https://bugzilla.wikimedia.org/65889#c5 (10Andre Klapper) 5REOP>3UNCO Okay, reference for myself: https://en.wikipedia.org/wiki/Help:Visual_file_markup/upright Sorry, I'm still not sure what I'd be expected to see (but som... [08:27:24] (03CR) 10Santhosh: Qunit tests for dictionary (033 comments) [services/cxserver] - 10https://gerrit.wikimedia.org/r/135412 (owner: 10Santhosh) [08:27:34] (03PS5) 10Santhosh: Qunit tests for dictionary [services/cxserver] - 10https://gerrit.wikimedia.org/r/135412 [08:27:36] (03CR) 10jenkins-bot: [V: 04-1] Qunit tests for dictionary [services/cxserver] - 10https://gerrit.wikimedia.org/r/135412 (owner: 10Santhosh) [08:33:48] (03PS6) 10Santhosh: Update the Dict client to match the updated API output format [services/cxserver] - 10https://gerrit.wikimedia.org/r/135022 [08:38:30] 3Wikimedia / 3Site requests: Enable MergeHistory for Persian Wikipedia admins - 10https://bugzilla.wikimedia.org/65938 (10Tomasz W. Kozlowski) p:5Unprio>3Normal [08:44:32] 3MediaWiki extensions / 3Collection: Unrelated content in produced PDF - 10https://bugzilla.wikimedia.org/65939 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Created attachment 15532 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15532&action=edit Sample PDF 1) http://eo.wikipedia.beta.wmflabs.o... [08:53:16] 3MediaWiki extensions / 3Collection: Unrelated content in produced PDF - 10https://bugzilla.wikimedia.org/65939#c1 (10Nemo) That may have to do with FlaggedRevs (or with the wiki being empty): http://simple.wikipedia.beta.wmflabs.org/wiki/List_of_literary_terms worked [08:58:42] (03CR) 10Amire80: [C: 032] Update the Dict client to match the updated API output format [services/cxserver] - 10https://gerrit.wikimedia.org/r/135022 (owner: 10Santhosh) [09:21:35] (03PS1) 10devunt: Warn when user trying to block nonexistent user [core] - 10https://gerrit.wikimedia.org/r/136290 (https://bugzilla.wikimedia.org/35687) [09:39:05] (03CR) 10Matěj Grabovský: [C: 04-1] Warn when user trying to block nonexistent user (031 comment) [core] - 10https://gerrit.wikimedia.org/r/136290 (https://bugzilla.wikimedia.org/35687) (owner: 10devunt) [09:39:38] (03Merged) 10jenkins-bot: mediawiki.special.unwatchedPages: Use closest() instead of parents() [core] - 10https://gerrit.wikimedia.org/r/136281 (owner: 10Krinkle) [09:40:46] (03Merged) 10jenkins-bot: Update the Dict client to match the updated API output format [services/cxserver] - 10https://gerrit.wikimedia.org/r/135022 (owner: 10Santhosh) [09:54:40] (03CR) 10Hashar: [C: 032] "Updated mwext-Flow-testextensions-master Sorry for the trouble, I should have verified :-/" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136283 (owner: 10Legoktm) [09:56:03] (03Merged) 10jenkins-bot: Revert "Add AntiSpoof to Flow dependencies" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136283 (owner: 10Legoktm) [10:10:30] 3Wikimedia / 3Deployment systems: Expose deployment status in -operations channel topic - 10https://bugzilla.wikimedia.org/52409#c5 (10Antoine "hashar" Musso) From Greg initial comment: > Especially during lightning deploys, but other times as well, 2 or more teams > are coordinating around each other to de... [10:17:19] (03CR) 10Gilles: [C: 031] images/.htaccess breaks TransformVia404 functionality [core] - 10https://gerrit.wikimedia.org/r/135543 (https://bugzilla.wikimedia.org/65220) (owner: 10Scnd) [10:25:17] (03PS2) 10devunt: Warn when user trying to block nonexistent user [core] - 10https://gerrit.wikimedia.org/r/136290 (https://bugzilla.wikimedia.org/35687) [10:26:10] (03CR) 10jenkins-bot: [V: 04-1] Warn when user trying to block nonexistent user [core] - 10https://gerrit.wikimedia.org/r/136290 (https://bugzilla.wikimedia.org/35687) (owner: 10devunt) [10:26:47] (03PS3) 10devunt: Warn when user trying to block nonexistent user [core] - 10https://gerrit.wikimedia.org/r/136290 (https://bugzilla.wikimedia.org/35687) [10:30:57] (03CR) 10Gilles: [C: 04-1] Output ogg metadata on image description page. (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108203 (https://bugzilla.wikimedia.org/47487) (owner: 10Brian Wolff) [10:36:30] (03CR) 10Gilles: [C: 04-1] Make SVG files show "In other resolutions" at all sizes (033 comments) [core] - 10https://gerrit.wikimedia.org/r/134855 (https://bugzilla.wikimedia.org/6834) (owner: 10Brian Wolff) [10:40:12] (03CR) 10Gilles: [C: 031] Double check its safe before dropping new table during db cloning [core] - 10https://gerrit.wikimedia.org/r/134930 (https://bugzilla.wikimedia.org/65654) (owner: 10Brian Wolff) [10:46:34] (03PS4) 10devunt: Add 'X-Robots-Tag: noindex' header in action=render pages [core] - 10https://gerrit.wikimedia.org/r/134996 (https://bugzilla.wikimedia.org/63891) [10:53:04] (03CR) 10devunt: Add 'X-Robots-Tag: noindex' header in action=render pages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/134996 (https://bugzilla.wikimedia.org/63891) (owner: 10devunt) [10:53:07] (03CR) 10Matěj Grabovský: Warn when user trying to block nonexistent user (031 comment) [core] - 10https://gerrit.wikimedia.org/r/136290 (https://bugzilla.wikimedia.org/35687) (owner: 10devunt) [10:55:54] (03PS5) 10Prtksxna: Flip the animation direction if the Hovercard is flipped [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135554 [10:56:25] (03CR) 10Prtksxna: Flip the animation direction if the Hovercard is flipped (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135554 (owner: 10Prtksxna) [10:59:01] (03PS4) 10devunt: Warn when user trying to block nonexistent user [core] - 10https://gerrit.wikimedia.org/r/136290 (https://bugzilla.wikimedia.org/35687) [11:04:19] (03CR) 10Matěj Grabovský: [C: 031] "Looks good to me." [core] - 10https://gerrit.wikimedia.org/r/136290 (https://bugzilla.wikimedia.org/35687) (owner: 10devunt) [11:04:25] (03CR) 10Gilles: [C: 031] Less false positives for MEDIATYPE_VIDEO (Importing pull 23 from github) bug 63584 Remove the ffmpeg2theora String to suppress false positiv [core] - 10https://gerrit.wikimedia.org/r/130966 (owner: 10Marco) [11:04:31] 3MediaWiki extensions / 3Popups: Hovercards/Popups do not close in browsers without animationend - 10https://bugzilla.wikimedia.org/63253 (10Prateek Saxena) [11:08:26] (03PS1) 10QChris: Add mediawiki/skins/Example [skins] - 10https://gerrit.wikimedia.org/r/136303 [11:12:31] (03PS1) 10MarkAHershberger: jquery.suggestions: Handle CSS ellipsis better for IE [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/136304 (https://bugzilla.wikimedia.org/65224) [11:13:04] (03CR) 10MarkAHershberger: [C: 032] jquery.suggestions: Handle CSS ellipsis better for IE [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/136304 (https://bugzilla.wikimedia.org/65224) (owner: 10MarkAHershberger) [11:16:45] (03Merged) 10jenkins-bot: jquery.suggestions: Handle CSS ellipsis better for IE [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/136304 (https://bugzilla.wikimedia.org/65224) (owner: 10MarkAHershberger) [11:20:07] (03CR) 10MarkAHershberger: "Legoktm, with your change, the tests fail to pass. I think we're going to have to ship 1.23.0 with this bug, unfortunately." [core] - 10https://gerrit.wikimedia.org/r/133411 (https://bugzilla.wikimedia.org/63677) (owner: 10Withoutaname) [11:21:53] (03PS1) 10Santhosh: Send 404 if dictionary not found for language pairs [services/cxserver] - 10https://gerrit.wikimedia.org/r/136305 [11:22:30] 3MediaWiki / 3Database: Update script is failing midway due to unknown 'user_password_expires' column - 10https://bugzilla.wikimedia.org/63677#c7 (10Mark A. Hershberger) Tests are currently failing on this one. We'll have to ship with it and fix it in 1.23.1. Andre, please add a milestone to bugzilla for 1... [11:24:30] 3MediaWiki / 3Installer: Install hangs on 'Setting up database..' with php errors (due to permissions issue) - 10https://bugzilla.wikimedia.org/61092#c9 (10Mark A. Hershberger) Brian, Could you update this bug with more details in response to Jeff's questions? [11:33:30] 3MediaWiki / 3Search: Search bar title autocompletion no longer expands width as necessary [IE6-11] - 10https://bugzilla.wikimedia.org/65224#c9 (10Mark A. Hershberger) 5PATC>3RESO/FIX Merged for 1.23. Closing. [11:43:45] 3Wikimedia / 3Site requests: Please add: ftp://sitelftp.unine.ch/ to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/65766#c5 (10This, that and the other) (In reply to Rromir from comment #4) > If yes, than it is > easier for me to upload the files in to a http server already white lis... [11:47:51] (03PS1) 10devunt: Remove trailing spaces of filename on Special:Upload [core] - 10https://gerrit.wikimedia.org/r/136307 (https://bugzilla.wikimedia.org/65811) [12:14:04] (03CR) 10Rillke: "Thank you for submitting a patch to resolve this bug." [core] - 10https://gerrit.wikimedia.org/r/136307 (https://bugzilla.wikimedia.org/65811) (owner: 10devunt) [12:15:13] (03PS7) 10Hashar: Refactor doc publishing from labs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 [12:15:49] (03CR) 10Hashar: Refactor doc publishing from labs (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 (owner: 10Hashar) [12:16:01] (03PS8) 10Hashar: Refactor doc publishing from labs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 [12:19:09] why is there no tag for 1.24/wmf6 in git? [12:19:46] (03CR) 10Hashar: [C: 031 V: 032] "Tried out with --dry-run and --verbose and confirmed the magic rsync only delete the ZUUL_UID directory :-) I have redeployed all three " [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 (owner: 10Hashar) [12:38:47] 3MediaWiki / 3Special pages: When Special:Contributions for a blocked user is included, the block warning is shown - 10https://bugzilla.wikimedia.org/65781 (10JuneHyeon Bae (devunt)) a:3JuneHyeon Bae (devunt) [12:39:32] (03PS1) 10devunt: Do not show user blocked warning on included Special:Contributions page [core] - 10https://gerrit.wikimedia.org/r/136308 (https://bugzilla.wikimedia.org/65781) [12:40:40] (03PS2) 10devunt: Do not show user blocked warning on included Special:Contributions page [core] - 10https://gerrit.wikimedia.org/r/136308 (https://bugzilla.wikimedia.org/65781) [12:46:46] 3MediaWiki / 3Installer: Install hangs on 'Setting up database..' with php errors (due to permissions issue) - 10https://bugzilla.wikimedia.org/61092 (10Andre Klapper) [12:46:46] 3MediaWiki / 3Database: Update script is failing midway due to unknown 'user_password_expires' column - 10https://bugzilla.wikimedia.org/63677 (10Andre Klapper) [12:50:00] 3MediaWiki / 3Skin and page rendering: Implement bin packing layout for galleries - 10https://bugzilla.wikimedia.org/65451#c3 (10Waldir) (In reply to C. Scott Ananian from comment #2) > What about implementing bug 35756 so that the images fill their specified > bounding box? Thanks, I didn't know about that... [12:50:46] 3MediaWiki / 3Skin and page rendering: Implement bin packing layout for galleries - 10https://bugzilla.wikimedia.org/65451 (10Waldir) [12:52:15] 3MediaWiki / 3Skin and page rendering: Implement bin packing layout for galleries - 10https://bugzilla.wikimedia.org/65451#c4 (10Waldir) I have no idea what Bugzilla attempted to do to the github url. Let me try again: https://github.com/reddit/reddit/blob/a6a4da72a1a0f44e0174b2ad0a865b9f68d3c1cd/r2/r2/lib/... [12:52:45] 3MediaWiki / 3Skin and page rendering: Implement bin packing layout for galleries - 10https://bugzilla.wikimedia.org/65451#c5 (10Waldir) Yup, definitely a bug in Bugzilla. [12:54:33] 3MediaWiki extensions / 3Translate: Headers should be aligned correctly with source units at Special:PageMigration - 10https://bugzilla.wikimedia.org/65942 (10Pratik Lahoti) 3NEW p:3Unprio s:3normal a:3None As of now, as splitting is done on '\n\n', some units contain a mix of headers and text when a... [12:55:31] 3MediaWiki extensions / 3Translate: Special page for migration of legacy translation pages (tracking) - 10https://bugzilla.wikimedia.org/65740 (10Pratik Lahoti) [12:55:32] 3MediaWiki extensions / 3Translate: Headers should be aligned correctly with source units at Special:PageMigration - 10https://bugzilla.wikimedia.org/65942 (10Pratik Lahoti) a:3Pratik Lahoti [13:02:33] 3MediaWiki extensions / 3Collection: Exception thrown by ext.collection.bookcreator: Syntax error, unrecognized expression - 10https://bugzilla.wikimedia.org/65943 (10Helder) 3NEW p:3Unprio s:3normal a:3None After I loaded http://en.wikipedia.beta.wmflabs.org/wiki/Cat and clicked on "Download as PDF"... [13:19:16] 3MediaWiki extensions / 3Scribunto: 'scribunto-console-intro' is not parsed - 10https://bugzilla.wikimedia.org/39369#c2 (10Amir E. Aharoni) Yes, this is still an issue. For an example see here: https://fa.wikipedia.org/w/index.php?title=%D9%BE%D9%88%D8%AF%D9%85%D8%A7%D9%86:No_ping&action=edit&uselang=fa Sc... [13:19:18] 3Analytics / 3Wikimetrics: User runs report for NEWLY REGISTERED USER - 10https://bugzilla.wikimedia.org/65944 (10Dan Andreescu) 3NEW p:3Unprio s:3enhanc a:3None * metric shows up in UI * get report on entire project * can choose any of 882 projects * https://meta.wikimedia.org/wiki/Research:Newly_re... [13:19:30] 3MediaWiki / 3Installer: Install hangs on 'Setting up database..' with php errors (due to permissions issue) - 10https://bugzilla.wikimedia.org/61092#c10 (10Matěj Grabovský) This happens, for instance, when the database already exists but the user doesn't have appropriate permissions. (Actually, I can't imag... [13:21:12] (03Abandoned) 10Reedy: Fix format comparison with rawfm in ApiFormatJson constructor [core] - 10https://gerrit.wikimedia.org/r/133734 (owner: 10Reedy) [13:22:30] 3Analytics / 3Wikimetrics: User runs report for NEWLY REGISTERED USER - 10https://bugzilla.wikimedia.org/65944 (10Dan Andreescu) [13:26:22] (03PS1) 10Yaron Koren: Version 0.2 [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/136313 [13:26:45] 3MediaWiki / 3Skin and page rendering: Implement bin packing layout for galleries - 10https://bugzilla.wikimedia.org/65451#c6 (10Andre Klapper) Offtopic: The "r2" triggers some broken regex in https://git.wikimedia.org/blob/wikimedia%2Fbugzilla%2Fmodifications.git/HEAD/extensions%2FWikimedia%2FExtension.pm#L... [13:27:36] (03CR) 10Yaron Koren: [C: 032 V: 031] Version 0.2 [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/136313 (owner: 10Yaron Koren) [13:27:38] (03Merged) 10jenkins-bot: Version 0.2 [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/136313 (owner: 10Yaron Koren) [13:27:57] (03CR) 10Gilles: "recheck" [core] - 10https://gerrit.wikimedia.org/r/127460 (owner: 10Aaron Schulz) [13:32:46] 3Analytics / 3EventLogging: Event Logging writing throughput needs monitoring - 10https://bugzilla.wikimedia.org/65482 (10Dan Andreescu) [13:33:31] 3Analytics / 3EventLogging: Event Logging writing throughput needs monitoring - 10https://bugzilla.wikimedia.org/65482 (10Dan Andreescu) s:5normal>3enhanc [13:37:54] (03PS9) 10Gilles: Support for storing files under SHA-1 names [core] - 10https://gerrit.wikimedia.org/r/127460 (owner: 10Aaron Schulz) [13:41:25] (03CR) 10jenkins-bot: [V: 04-1] Support for storing files under SHA-1 names [core] - 10https://gerrit.wikimedia.org/r/127460 (owner: 10Aaron Schulz) [13:42:10] (03PS1) 10Hashar: Node labels cleanup [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136315 [13:48:18] (03PS2) 10Hashar: Phase out some old labels [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136315 [13:50:18] 3Analytics / 3Wikimetrics: CronUser runs EEVS metrics on all projects daily - 10https://bugzilla.wikimedia.org/65946 (10Dan Andreescu) 3NEW p:3Unprio s:3normal a:3None * 882 projects * 4 metrics * append results to datafile * public URL to get data (JSON) [13:51:00] (03CR) 10Hashar: [C: 032] Phase out some old labels [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136315 (owner: 10Hashar) [13:51:01] 3Analytics / 3Wikimetrics: CronUser runs EEVS metrics on all projects daily - 10https://bugzilla.wikimedia.org/65946 (10Dan Andreescu) s:5normal>3enhanc [13:52:00] 3Analytics / 3EventLogging: Event Logging writing throughput needs monitoring - 10https://bugzilla.wikimedia.org/65482 (10Dan Andreescu) [13:52:10] (03Merged) 10jenkins-bot: Phase out some old labels [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136315 (owner: 10Hashar) [14:10:47] (03CR) 10Manybubbles: [C: 031] "I don't see anything wrong with it. I'll see about testing it soon but probably not until early next week." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/133606 (owner: 10Chad) [14:11:22] (03CR) 10Jforrester: "Did release notes get updated in a follow-up?" [core] - 10https://gerrit.wikimedia.org/r/6143 (https://bugzilla.wikimedia.org/17367) (owner: 10Eranroz) [14:17:47] 3MediaWiki extensions / 3ConfirmEdit (CAPTCHA extension): Show captcha before save edit - 10https://bugzilla.wikimedia.org/65913 (10Florian) a:3Florian [14:28:17] 3MediaWiki / 3Skin and page rendering: Scaling of fonts in Firefox results in too small fonts - 10https://bugzilla.wikimedia.org/24402#c7 (10entlinkt) I think this bug is implicitly fixed by the typography refresh. The #bodyContent font-size has been changed to 0.875em (which gives exactly 14px if medium is... [14:28:17] 3MediaWiki / 3Skin and page rendering: Vector Typography Refresh (tracking) - 10https://bugzilla.wikimedia.org/63549 (10entlinkt) [14:29:00] 3MediaWiki extensions / 3Petition: Performance review of Petition extension before WMF deployment - 10https://bugzilla.wikimedia.org/65851#c5 (10Peter Coombe) The data will only be viewable by a few WMF employees (probably within Fundraising where we've all already signed a strict "Protection of Donor and Us... [14:30:45] 3Analytics / 3EventLogging: Event Logging writing throughput needs monitoring - 10https://bugzilla.wikimedia.org/65482 (10Dan Andreescu) [14:32:33] 3Analytics / 3EventLogging: Test bug for ScrumBugs - 10https://bugzilla.wikimedia.org/65947 (10christian) 3NEW p:3Unprio s:3normal a:3None Please ignore [14:34:02] 3Analytics / 3EventLogging: Test bug for ScrumBugs - 10https://bugzilla.wikimedia.org/65947 (10christian) [14:35:10] (03PS1) 10Florianschmidtwelzow: Show Captcha after click on edit over buttons on EditPage [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/136323 (https://bugzilla.wikimedia.org/65913) [14:36:03] anomie: gwicke and i finished going over the volatile patch. he says he'll merge it if you're okay with the changes i made [14:37:15] 3Analytics / 3EventLogging: Test bug for ScrumBugs - 10https://bugzilla.wikimedia.org/65947 (10Dan Andreescu) [14:37:45] 3Analytics / 3EventLogging: Test bug for ScrumBugs - 10https://bugzilla.wikimedia.org/65947#c1 (10Dan Andreescu) 5NEW>3RESO/INV This was just a test for scrum bugs integration [14:40:16] 3Analytics / 3EventLogging: Event Logging writing throughput needs monitoring - 10https://bugzilla.wikimedia.org/65482 (10Dan Andreescu) [14:59:39] (03PS10) 10Gilles: Support for storing files under SHA-1 names [core] - 10https://gerrit.wikimedia.org/r/127460 (owner: 10Aaron Schulz) [15:15:14] (03PS1) 10Chad: Release 0.4 a few days ago [search/repository-swift] - 10https://gerrit.wikimedia.org/r/136327 [15:20:31] (03CR) 10Umherirrender: mediawiki.special.unwatchedPages: Use closest() instead of parents() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/136281 (owner: 10Krinkle) [15:25:35] (03CR) 10Chad: [C: 032 V: 032] Release 0.4 a few days ago [search/repository-swift] - 10https://gerrit.wikimedia.org/r/136327 (owner: 10Chad) [15:26:46] 3MediaWiki extensions / 3Collection: Exception thrown by ext.collection.bookcreator: Syntax error, unrecognized expression - 10https://bugzilla.wikimedia.org/65943#c1 (10Helder) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 65562 *** [15:26:46] 3MediaWiki extensions / 3Collection: PDF Rendering page no longer refreshes - 10https://bugzilla.wikimedia.org/65562#c5 (10Helder) *** Bug 65943 has been marked as a duplicate of this bug. *** [15:27:45] 3MediaWiki extensions / 3Collection: PDF Rendering page no longer refreshes - 10https://bugzilla.wikimedia.org/65562#c6 (10Helder) (copied from bug 65943) After I loaded http://en.wikipedia.beta.wmflabs.org/wiki/Cat and clicked on "Download as PDF" I got the URL http://en.wikipedia.beta.wmflabs.org/w/index.... [15:32:50] (03PS3) 10Ori.livneh: Supporting libraries for Fundraising outbound email [vagrant] - 10https://gerrit.wikimedia.org/r/135323 (owner: 10Awight) [15:33:32] (03CR) 10Ori.livneh: [C: 032] Supporting libraries for Fundraising outbound email [vagrant] - 10https://gerrit.wikimedia.org/r/135323 (owner: 10Awight) [15:33:42] (03Merged) 10jenkins-bot: Supporting libraries for Fundraising outbound email [vagrant] - 10https://gerrit.wikimedia.org/r/135323 (owner: 10Awight) [15:34:16] 3MediaWiki / 3Database: Address "DB transaction callbacks still pending" warnings from Database.php - 10https://bugzilla.wikimedia.org/47375#c11 (10Dan Barrett) I've been getting these in 1.22.5 when trying to delete an article. The delete fails with: "A database query error has occurred. This may indicate... [15:35:01] (03PS12) 10Physikerwelt: Add separate database table for LaTeXML (step 5) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135839 (https://bugzilla.wikimedia.org/65522) [15:35:51] (03PS3) 10Ori.livneh: STOMP queue server for Fundraising [vagrant] - 10https://gerrit.wikimedia.org/r/135324 (owner: 10Awight) [15:36:00] (03CR) 10Ori.livneh: [C: 032] STOMP queue server for Fundraising [vagrant] - 10https://gerrit.wikimedia.org/r/135324 (owner: 10Awight) [15:36:03] (03CR) 10jenkins-bot: [V: 04-1] Add separate database table for LaTeXML (step 5) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135839 (https://bugzilla.wikimedia.org/65522) (owner: 10Physikerwelt) [15:36:05] (03Merged) 10jenkins-bot: STOMP queue server for Fundraising [vagrant] - 10https://gerrit.wikimedia.org/r/135324 (owner: 10Awight) [15:36:32] (03CR) 10Ori.livneh: [C: 032] Role to add CentralNotice to MediaWiki [vagrant] - 10https://gerrit.wikimedia.org/r/135325 (owner: 10Awight) [15:36:35] (03CR) 10jenkins-bot: [V: 04-1] Role to add CentralNotice to MediaWiki [vagrant] - 10https://gerrit.wikimedia.org/r/135325 (owner: 10Awight) [15:36:37] (03PS2) 10Ori.livneh: Role to add CentralNotice to MediaWiki [vagrant] - 10https://gerrit.wikimedia.org/r/135325 (owner: 10Awight) [15:36:56] (03CR) 10Ori.livneh: [C: 032] Role to add CentralNotice to MediaWiki [vagrant] - 10https://gerrit.wikimedia.org/r/135325 (owner: 10Awight) [15:37:00] (03Merged) 10jenkins-bot: Role to add CentralNotice to MediaWiki [vagrant] - 10https://gerrit.wikimedia.org/r/135325 (owner: 10Awight) [15:37:15] (03Abandoned) 10BryanDavis: Add a PSR-3 based logging interface. [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [15:37:31] 3MediaWiki / 3Database: Fix "Uncommitted DB writes (transaction from DatabaseBase::query)" - 10https://bugzilla.wikimedia.org/56269#c55 (10Dan Barrett) I'm getting these errors as of today in 1.22.5 when we try to delete an article. See my comment number 11 in bug 47375 for the error log, which includes both... [15:38:01] 3Wikimedia / 3Extension setup: Modern and Cologne Blue should remain in Preferences/Appearance after removal from core - 10https://bugzilla.wikimedia.org/65868#c11 (10Antoine "hashar" Musso) I have applied the Gerrit patch above on the beta cluster puppet master. Then manually triggered the Jenkins job that... [15:38:03] 3Analytics / 3Refinery: Auto-delete non sanctioned tables - 10https://bugzilla.wikimedia.org/65949 (10Toby Negrin) 3NEW p:3Unprio s:3enhanc a:3None This is an enhancement request for a feature that does not exist yet :) If we allow users to create tables in Hive, we should auto-delete them every 90... [15:38:15] jackmcbarn: You might be interested in the performance of https://en.wikipedia.org/wiki/User:Anomie/Sandbox4 versus http://en.wikipedia.beta.wmflabs.org/wiki/User:Anomie/Sandbox4 due to your gerrit change 135980 [15:39:00] 3MediaWiki / 3Database: Address "DB transaction callbacks still pending" warnings from Database.php - 10https://bugzilla.wikimedia.org/47375#c12 (10Jesús Martínez Novo (Ciencia Al Poder)) This warning should go away, and be thrown only when $wgDevelopmentWarnings is set to true. Otherwise, many errors get m... [15:39:15] 3MediaWiki extensions / 3Collection: PDF Rendering page no longer refreshes - 10https://bugzilla.wikimedia.org/65562#c7 (10Helder) The same error happens on https://test2.wikipedia.org/w/index.php?title=Special:Book&bookcmd=rendering&return_to=LowTemplate&collection_id=c4ce56d211c0afe6&writer=rl&debug=1 and... [15:39:36] prtksxna: shalom [15:39:46] I saw the emails from you and Pau [15:39:51] what is the context exactly? [15:40:05] is it about Hovercards? something else? desktop or mobile? [15:40:11] It's a bit annoying that we no longer have the "served by" HTML comment, only that [15:40:14] mw.config.set({"wgBackendResponseTime":232,"wgHostname":"mw1181"}); [15:40:36] anomie: i can't think of any practical case where that would happen. most templates that don't take parameters are fast, and i can't find any "real" pages where it makes it more than about 0.2 seconds worse [15:40:51] i did consider logic to keep track of when to cache between frames, but it didn't seem worth it [15:41:03] jackmcbarn: Then why do we cache templates without parameters at all, if they're all fast? [15:41:47] anomie: on one of my test pages, this change took it from 16.2 to 16.3 seconds. when i tried killing the cache completely, it took it to like 34 (or something like that, exact numbers are in there) [15:42:15] because usually it's 50 times in one frame and 50 times in some other frame, not one time each in many frames [15:42:33] 3MediaWiki / 3Database: Exceptions when database connection is lost and automatically reopened with pending transaction idle callbacks - 10https://bugzilla.wikimedia.org/65263#c5 (10Jesús Martínez Novo (Ciencia Al Poder)) 5PATC>3RESO/FIX a:3Aaron Schulz gerrit change 133173 merged. I assume it has been... [15:44:41] (03PS1) 10Ori.livneh: lint fixes for fundraising-related commits [vagrant] - 10https://gerrit.wikimedia.org/r/136330 [15:44:47] jackmcbarn: There are pages that do e.g. each table row as a template call, and inside each of those row-templates might call parameterless templates of some sort. Whether there's one with enough rows to make a difference, I don't know. [15:46:00] (03CR) 10Ori.livneh: [C: 032] lint fixes for fundraising-related commits [vagrant] - 10https://gerrit.wikimedia.org/r/136330 (owner: 10Ori.livneh) [15:46:03] (03Merged) 10jenkins-bot: lint fixes for fundraising-related commits [vagrant] - 10https://gerrit.wikimedia.org/r/136330 (owner: 10Ori.livneh) [15:46:15] the other mitigating factor is that (on the sample of pages i used), the vast majority of the cache hits were to Template:!, and we're probably going to go through with making ! a magic word [15:47:11] (03PS1) 10Hashar: beta-code-update: dont mail build console [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136331 [15:48:27] jackmcbarn: I don't see any problem with the changes to the isVolatile patch. The warning comment is a bit too strongly worded IMO, but meh. [15:48:42] anomie: that's what gwicke and i spent almost all the time discussing [15:48:58] he wants it to scare away any other potential users of it [15:50:24] (03PS1) 10Hashar: beta: also mail qa-alerts@lists.wikimedia.org [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136332 [15:51:28] gwicke: is that good for you to merge? [15:52:00] (03CR) 10Hashar: [C: 032] "Added reviewers for information." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136332 (owner: 10Hashar) [15:53:17] (03Merged) 10jenkins-bot: beta: also mail qa-alerts@lists.wikimedia.org [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136332 (owner: 10Hashar) [16:00:18] * anomie can't wait to get a chance to do things like fixing how the API returns booleans across the board [16:01:01] jackmcbarn: Actually, one thing: the 'volatile' flag in the API module result should be the empty string, not boolean true. Stupid, yes, but it's how the API does it for now. [16:04:08] (03PS9) 10Jackmcbarn: Add PPFrame::isVolatile and PPFrame::setVolatile [core] - 10https://gerrit.wikimedia.org/r/99792 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [16:05:26] (03CR) 10MarkTraceur: "I was halfway through fixing the issues raised here when my laptop decided it was going to stop booting... :(" (0310 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [16:08:16] 3Analytics / 3Wikistats: Old wikivoyage logo used on stats.wikimedia.org - 10https://bugzilla.wikimedia.org/55558#c12 (10Toby Negrin) Hi Yu -- can we close this now? The logo looks ok. -Toby [16:08:45] 3Analytics / 3Wikistats: Old wikivoyage logo used on stats.wikimedia.org - 10https://bugzilla.wikimedia.org/55558 (10Toby Negrin) p:5Unprio>3Normal [16:10:01] 3Analytics / 3Refinery: Archiva web UI formats links to download artifacts with local IP address - 10https://bugzilla.wikimedia.org/65628 (10Toby Negrin) p:5Unprio>3Normal [16:11:02] 3MediaWiki / 3API: API imageinfo should allow fetching multiple thumbnail sizes - 10https://bugzilla.wikimedia.org/54035#c3 (10Brad Jorsch) I'd lean towards making the relevant parameters (iiurlwidth, iiurlheight, iiurlparam) multi-value parameters and letting clients request what they actually want, rather... [16:13:01] 3MediaWiki / 3Database: Address "DB transaction callbacks still pending" warnings from Database.php - 10https://bugzilla.wikimedia.org/47375#c13 (10Southparkfan) (In reply to Dan Barrett from comment #11) > I've been getting these in 1.22.5 when trying to delete an article. The > delete fails with: > > "A... [16:15:46] (03PS2) 10Jackmcbarn: Expose cascading protection directly to Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/132730 [16:15:53] (03PS1) 10Nikerabbit: Whitespace adn deferred fix [services/cxserver] - 10https://gerrit.wikimedia.org/r/136337 [16:17:13] (03CR) 10Aaron Schulz: [C: 032] Fix typo [core] - 10https://gerrit.wikimedia.org/r/129175 (owner: 10Nikerabbit) [16:17:18] (03CR) 10Anomie: "Code itself looks good, haven't tested though." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/136274 (owner: 10Jackmcbarn) [16:19:05] http://www.slate.com/blogs/future_tense/2014/05/30/longest_disambiguation_pages_on_wikipedia_an_investigation.html [16:19:45] 3MediaWiki extensions / 3Validator: Validator/ParamParser broken on 5.3 due to autoloader - 10https://bugzilla.wikimedia.org/65932#c1 (10Jeroen De Dauw) This is about using PHP 5.3 with an old version of MW? I seem to recall the MW autoloder being fixed quite some time ago, since this was a problem for Wikid... [16:20:45] (03Merged) 10jenkins-bot: Fix typo [core] - 10https://gerrit.wikimedia.org/r/129175 (owner: 10Nikerabbit) [16:23:15] 3MediaWiki / 3Database: Address "DB transaction callbacks still pending" warnings from Database.php - 10https://bugzilla.wikimedia.org/47375#c14 (10Dan Barrett) MediaWiki 1.22.5 on a cluster with 3 front-end web servers through a load-balancer, and 2 database servers (one master replicating to one slave) my... [16:23:25] (03PS2) 10Nemo bis: Whitespace and deferred fix [services/cxserver] - 10https://gerrit.wikimedia.org/r/136337 (owner: 10Nikerabbit) [16:24:11] (03CR) 10Aaron Schulz: [C: 032] PostgreSQL: Only rollback when in a transaction [core] - 10https://gerrit.wikimedia.org/r/136287 (https://bugzilla.wikimedia.org/58095) (owner: 10Jjanes) [16:26:31] 3MediaWiki / 3Database: Address "DB transaction callbacks still pending" warnings from Database.php - 10https://bugzilla.wikimedia.org/47375#c15 (10Dan Barrett) Correction to comment 14: three database servers, one master replicating to 2 slaves. (However, one of the slaves is not accessed by users... it's j... [16:27:30] 3MediaWiki / 3Database: Address "DB transaction callbacks still pending" warnings from Database.php - 10https://bugzilla.wikimedia.org/47375#c16 (10Dan Barrett) also PHP 5.4.27. [16:27:46] (03Merged) 10jenkins-bot: PostgreSQL: Only rollback when in a transaction [core] - 10https://gerrit.wikimedia.org/r/136287 (https://bugzilla.wikimedia.org/58095) (owner: 10Jjanes) [16:28:01] 3Analytics / 3Tech community metrics: Bugzilla ticket with recent comments listed under "Longest time without comment" on bugzilla_response_time.html - 10https://bugzilla.wikimedia.org/64373#c7 (10Andre Klapper) Looks like this is FIXED now; item not listed anymore. Santiago: Is only this item "fixed", or i... [16:33:59] (03CR) 10Frédéric Wang: [C: 031] "Thanks, that looks good to me. I don't know why the bot now failed." [extensions/Math] - 10https://gerrit.wikimedia.org/r/135839 (https://bugzilla.wikimedia.org/65522) (owner: 10Physikerwelt) [16:34:01] (03PS2) 10BryanDavis: beta-code-update: dont mail build console [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136331 (owner: 10Hashar) [16:39:08] (03CR) 10BryanDavis: [C: 032] "Ran `jenkins-jobs --conf etc/jenkins_jobs.ini update config/ 'beta-code-update-eqiad'` to apply and verified the deployment." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136331 (owner: 10Hashar) [16:40:14] (03PS1) 10PleaseStand: Make convertUserOptions.php more self-contained [core] - 10https://gerrit.wikimedia.org/r/136339 (https://bugzilla.wikimedia.org/63677) [16:41:19] (03Merged) 10jenkins-bot: beta-code-update: dont mail build console [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136331 (owner: 10Hashar) [16:44:16] 3MediaWiki extensions / 3Collection: PDF Rendering page no longer refreshes - 10https://bugzilla.wikimedia.org/65562 (10Andre Klapper) [16:44:16] 3MediaWiki extensions / 3Collection: Unrelated content in produced PDF - 10https://bugzilla.wikimedia.org/65939 (10Andre Klapper) [16:46:36] bawolff: i got a list of what uses msgnw re https://gerrit.wikimedia.org/r/#/c/123516/ [16:46:49] do you think that makes it merge-able? [16:48:03] * bawolff cant look right now. Ask me after this weekend [16:48:07] kk [16:54:31] 3MediaWiki / 3Database: Update script is failing midway when updating from 1.17 or earlier to 1.23 due to unknown 'user_password_expires' column - 10https://bugzilla.wikimedia.org/63677 (10Bartosz Dziewoński) [16:56:00] 3MediaWiki / 3Database: Update script is failing midway when updating from 1.18 or earlier to 1.23 due to unknown 'user_password_expires' column - 10https://bugzilla.wikimedia.org/63677 (10Bartosz Dziewoński) [16:57:00] 3Analytics / 3Wikistats: Old wikivoyage logo used on stats.wikimedia.org - 10https://bugzilla.wikimedia.org/55558#c13 (10Erik Zachte) That's the old wikivoyage logo which we had to abandon due to claim. [17:00:01] 3MediaWiki extensions / 3Collection: PDF Rendering page no longer refreshes - 10https://bugzilla.wikimedia.org/65562#c8 (10Nemo) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 36962 *** [17:00:01] 3MediaWiki extensions / 3Collection: Progress goes above 1.0% and then jumps back to 1.0% - 10https://bugzilla.wikimedia.org/36962#c4 (10Nemo) *** Bug 65562 has been marked as a duplicate of this bug. *** [17:02:07] (03CR) 10Bartosz Dziewoński: mediawiki.special.unwatchedPages: Use closest() instead of parents() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/136281 (owner: 10Krinkle) [17:03:17] (03CR) 10PleaseStand: "> Legoktm, with your change, the tests fail to pass." [core] - 10https://gerrit.wikimedia.org/r/133411 (https://bugzilla.wikimedia.org/63677) (owner: 10Withoutaname) [17:03:22] (03PS1) 10Aaron Schulz: Transaction coverage fix for doDeleteArticleReal [core] - 10https://gerrit.wikimedia.org/r/136343 [17:07:45] 3Analytics / 3Wikistats: Old wikivoyage logo used on stats.wikimedia.org - 10https://bugzilla.wikimedia.org/55558#c14 (10Erik Zachte) 5REOP>3RESO/FIX Logo updated. [17:09:57] (03PS1) 10Bartosz Dziewoński: Release notes for Ie32cc54a [core] - 10https://gerrit.wikimedia.org/r/136345 [17:10:18] (03CR) 10Bartosz Dziewoński: "Doesn't look like it. It was only mentioned in Krinkle's inline comment in 2012, understandable that it was forgotten if other reviewers d" [core] - 10https://gerrit.wikimedia.org/r/6143 (https://bugzilla.wikimedia.org/17367) (owner: 10Eranroz) [17:12:22] (03CR) 10CSteipp: [C: 031] "I don't have an old enough wiki to test on, but this looks like the right way to do this." [core] - 10https://gerrit.wikimedia.org/r/136339 (https://bugzilla.wikimedia.org/63677) (owner: 10PleaseStand) [17:15:16] 3MediaWiki / 3Database: Update script is failing midway when updating from 1.18 or earlier to 1.23 due to unknown 'user_password_expires' column - 10https://bugzilla.wikimedia.org/63677#c9 (10Chris Steipp) I think the way PleaseStand's patch handles this is better than moving the order of the database update... [17:18:46] 3MediaWiki extensions / 3Collection: PDF Rendering page no longer refreshes - 10https://bugzilla.wikimedia.org/65562#c9 (10Bartosz Dziewoński) 5RESO/DUP>3REOP This is not a duplicate or I am missing something. That bug has nothing about JavaScript errors on it. [17:20:31] 3Wikimedia / 3General/Unknown: Don't use deprecated features removed in jQuery 1.9 (tracking) - 10https://bugzilla.wikimedia.org/65399 (10Bartosz Dziewoński) [17:20:32] 3MediaWiki extensions / 3Collection: PDF Rendering page no longer refreshes - 10https://bugzilla.wikimedia.org/65562#c10 (10Bartosz Dziewoński) a:3Bartosz Dziewoński This is probably caused by the recent jQuery update. Collection has some clever code that should have never worked if you ask me, and apparen... [17:21:29] (03PS1) 10Bartosz Dziewoński: Use [title!=''] instead of [title!=] to make jQuery happy [extensions/Collection] - 10https://gerrit.wikimedia.org/r/136350 (https://bugzilla.wikimedia.org/65562) [17:22:25] (03CR) 10Bartosz Dziewoński: [C: 031] "Untested, but looks sane (conceptually this is a much better solution than the one from the other patch, if a bit more complicated to code" [core] - 10https://gerrit.wikimedia.org/r/136339 (https://bugzilla.wikimedia.org/63677) (owner: 10PleaseStand) [17:23:58] (03CR) 10Chad: "Yeah there's no rush on this, just playing around with it more than anything :)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/133606 (owner: 10Chad) [17:24:16] 3MediaWiki extensions / 3Collection: Unrelated content in produced PDF - 10https://bugzilla.wikimedia.org/65939 (10Bartosz Dziewoński) [17:24:46] (03CR) 10Spage: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136280 (https://bugzilla.wikimedia.org/65915) (owner: 10Werdna) [17:26:15] 3MediaWiki extensions / 3Validator: Validator/ParamParser broken on 5.3 due to autoloader - 10https://bugzilla.wikimedia.org/65932#c2 (10Daniel Friesen) PHP is 5.3 The MW version and Validator are what is checked into the client tree. MW is some version of 1.22 (alpha?). And I'm not sure about Validator, it'... [17:26:45] 3MediaWiki extensions / 3Validator: Validator/ParamParser broken on 5.3 due to autoloader - 10https://bugzilla.wikimedia.org/65932#c3 (10Daniel Friesen) 5NEW>3RESO/WOR I'm not sure what to mark this as duplicate of. [17:27:00] 3MediaWiki extensions / 3Collection: Unrelated content in produced PDF - 10https://bugzilla.wikimedia.org/65939 (10Bartosz Dziewoński) [17:27:01] 3MediaWiki extensions / 3Collection: PDF Rendering page no longer refreshes - 10https://bugzilla.wikimedia.org/65562 (10Bartosz Dziewoński) [17:32:33] (03CR) 10Jforrester: [C: 032] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/136345 (owner: 10Bartosz Dziewoński) [17:35:41] (03Merged) 10jenkins-bot: Release notes for Ie32cc54a [core] - 10https://gerrit.wikimedia.org/r/136345 (owner: 10Bartosz Dziewoński) [17:35:46] 3Wikimedia / 3Git/Gerrit: Deprecate/close mediawiki/extensions/skins - 10https://bugzilla.wikimedia.org/60927#c1 (10Bartosz Dziewoński) What exactly has to be done about this? Chad, do you know / can you do that? [17:36:08] (03PS1) 10BryanDavis: Restore sync-dir and sync-file in python [tools/scap] - 10https://gerrit.wikimedia.org/r/136356 [17:36:10] (03PS1) 10BryanDavis: Always send debug logs to udp2log server [tools/scap] - 10https://gerrit.wikimedia.org/r/136357 [17:38:45] 3MediaWiki / 3Search: Provide way to override the behavior of default search box - 10https://bugzilla.wikimedia.org/65753 (10Bartosz Dziewoński) 5NEW>3UNCO [17:40:16] 3Wikimedia / 3Git/Gerrit: Move Nostalgia skin repository from mediawiki/extensions/ to mediawiki/skins/ - 10https://bugzilla.wikimedia.org/61256#c1 (10Bartosz Dziewoński) Ha, I've just been discussing this with Chad this week and I was going to file a bug. I think there are three things that need to be done... [17:40:45] 3Wikimedia / 3Git/Gerrit: Move Nostalgia skin repository from mediawiki/extensions/ to mediawiki/skins/ - 10https://bugzilla.wikimedia.org/61256#c2 (10Bartosz Dziewoński) Also: * Merging [[mw:Extension:Nostalgia]] into [[mw:Skin:Nostalgia]]. [17:42:36] (03CR) 10Bartosz Dziewoński: "I still suggest abandoning and WONTFIXing the bug. :)" [core] - 10https://gerrit.wikimedia.org/r/135054 (https://bugzilla.wikimedia.org/49002) (owner: 10Robmoen) [17:43:05] (03CR) 10Legoktm: [C: 031] "This is a much better approach." [core] - 10https://gerrit.wikimedia.org/r/136339 (https://bugzilla.wikimedia.org/63677) (owner: 10PleaseStand) [17:45:10] (03CR) 10Bartosz Dziewoński: "> So what needs changing to get rid of the legacy var statements and declare visibility properly?" [core] - 10https://gerrit.wikimedia.org/r/132746 (owner: 10Siebrand) [17:45:14] (03CR) 10Aaron Schulz: [C: 032] Reduce some code duplication [core] - 10https://gerrit.wikimedia.org/r/135279 (owner: 10Brian Wolff) [17:46:04] (03PS1) 10Yuvipanda: Hide edit buttons on the main page [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/136359 [17:46:06] (03CR) 10Mwalker: [C: 032] Use [title!=''] instead of [title!=] to make jQuery happy [extensions/Collection] - 10https://gerrit.wikimedia.org/r/136350 (https://bugzilla.wikimedia.org/65562) (owner: 10Bartosz Dziewoński) [17:46:09] (03CR) 10jenkins-bot: [V: 04-1] Hide edit buttons on the main page [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/136359 (owner: 10Yuvipanda) [17:46:11] (03Merged) 10jenkins-bot: Use [title!=''] instead of [title!=] to make jQuery happy [extensions/Collection] - 10https://gerrit.wikimedia.org/r/136350 (https://bugzilla.wikimedia.org/65562) (owner: 10Bartosz Dziewoński) [17:46:25] (03PS2) 10Yuvipanda: Hide edit buttons on the main page [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/136359 [17:46:29] (03CR) 10jenkins-bot: [V: 04-1] Hide edit buttons on the main page [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/136359 (owner: 10Yuvipanda) [17:46:58] (03CR) 10GWicke: "I have summarized the domparse tag idea at https://www.mediawiki.org/wiki/Parsoid/domparse" [core] - 10https://gerrit.wikimedia.org/r/132710 (owner: 10Daniel Kinzler) [17:47:12] legoktm: did you do the MobileApp jenkins job? it's trying to run phpunit tests that don't exist and failing :P [17:47:25] o.O [17:47:32] legoktm: also, +2 https://gerrit.wikimedia.org/r/#/c/136359/ anyway? :) [17:48:01] YuviPanda: it looks like it's trying to run the .less validator tests which is failing [17:48:09] (03CR) 10Bartosz Dziewoński: Add border-radius and box-shadow functions to mediawiki mixins (031 comment) [core] - 10https://gerrit.wikimedia.org/r/134964 (owner: 10Robmoen) [17:48:24] YuviPanda: not all Wikipedia's main pages are protected [17:48:43] why would you want to hide the edit button if they can edit it? [17:48:44] (03CR) 10Bartosz Dziewoński: [C: 04-1] Add border-radius and box-shadow functions to mediawiki mixins (031 comment) [core] - 10https://gerrit.wikimedia.org/r/134964 (owner: 10Robmoen) [17:48:47] (03Merged) 10jenkins-bot: Reduce some code duplication [core] - 10https://gerrit.wikimedia.org/r/135279 (owner: 10Brian Wolff) [17:48:48] legoktm: indeed, but this is just aping MF's design. [17:48:58] :/ [17:49:01] Woo [17:49:13] (03CR) 10Legoktm: [C: 032 V: 032] Hide edit buttons on the main page [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/136359 (owner: 10Yuvipanda) [17:49:15] legoktm: plus now we have the #mainpage tag, so (when it is implemented) Mobile.css can distinguish [17:49:18] legoktm: ty [17:50:30] 3MediaWiki extensions / 3Collection: PDF Rendering page no longer refreshes - 10https://bugzilla.wikimedia.org/65562#c13 (10Bartosz Dziewoński) Thanks. Can you verify that this fixes the bug? As I said, I only looked at the single backtrace in the comments here, there might be more issues lurking. [17:51:31] 3MediaWiki / 3Skin and page rendering: Remove Vector sidebar links indentation - 10https://bugzilla.wikimedia.org/65444 (10Bartosz Dziewoński) 5NEW>3UNCO [17:53:00] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Also, does not merge :(" [core] - 10https://gerrit.wikimedia.org/r/63364 (owner: 10Daniel Friesen) [17:53:14] anomie, jackmcbarn: I'm happy to merge https://gerrit.wikimedia.org/r/#/c/99792/ if you don't have any more objections [17:54:18] YuviPanda: I filed https://bugzilla.wikimedia.org/show_bug.cgi?id=65954 [17:54:20] for the tests [17:54:24] gwicke: i'm good. anomie said he was good 2 hours ago in here [17:55:41] (03CR) 10GWicke: [C: 032] Add PPFrame::isVolatile and PPFrame::setVolatile [core] - 10https://gerrit.wikimedia.org/r/99792 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [17:55:52] legoktm: ok, I'll take a looka t some point. [17:55:52] legoktm: thanks for the merge, but [17:55:55] jackmcbarn, great [17:56:03] thanks! [17:56:12] thank you as well! [17:56:18] but...? [17:56:22] (03CR) 10Bartosz Dziewoński: "It doesn't AFAIK." [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [17:56:28] (03CR) 10jenkins-bot: [V: 04-1] Add PPFrame::isVolatile and PPFrame::setVolatile [core] - 10https://gerrit.wikimedia.org/r/99792 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [17:56:58] release notes merge conflict? [17:57:07] * MatmaRex plugs https://github.com/MatmaRex/mediawikireleasenotes-driver [17:57:50] (03CR) 1020after4: [C: 031] "Looks good to me" [tools/scap] - 10https://gerrit.wikimedia.org/r/136357 (owner: 10BryanDavis) [17:58:28] (03CR) 10Bsitu: [C: 04-1] "The cache version number should be updated to purge the cache. This patch mixes database column/index add/update/delete, it's not possibl" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136280 (https://bugzilla.wikimedia.org/65915) (owner: 10Werdna) [17:58:31] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Handle deleted redirects - 10https://bugzilla.wikimedia.org/65638#c1 (10Chad H.) Confirmed, we don't. [18:02:36] 3MediaWiki / 3General/Unknown: Image resizing broken when image is not thumbnailed - 10https://bugzilla.wikimedia.org/9534#c4 (10Bartosz Dziewoński) There is no such thing as "client-side javascript scaling" in core MediaWiki, as far as I know. [18:05:03] (03PS1) 10Jackmcbarn: Merge "Reduce some code duplication" [core] - 10https://gerrit.wikimedia.org/r/136362 [18:05:14] (03Abandoned) 10Jackmcbarn: Merge "Reduce some code duplication" [core] - 10https://gerrit.wikimedia.org/r/136362 (owner: 10Jackmcbarn) [18:07:11] (03PS10) 10Jackmcbarn: Add PPFrame::isVolatile and PPFrame::setVolatile [core] - 10https://gerrit.wikimedia.org/r/99792 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [18:07:19] gwicke: jenkins didn't like that. can you re-+2? [18:07:24] (03PS2) 10Bsitu: Be more forgiving in maintenance script [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135570 (owner: 10Matthias Mullie) [18:08:35] (03CR) 10jenkins-bot: [V: 04-1] Be more forgiving in maintenance script [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135570 (owner: 10Matthias Mullie) [18:14:01] (03CR) 10Anomie: "It may not matter much in practice, but I note that a parameterless template that is trancluded by many other (non-parameterless) template" [core] - 10https://gerrit.wikimedia.org/r/135980 (owner: 10Jackmcbarn) [18:17:14] (03PS1) 10Chad: Handle deleted redirects properly [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/136364 (https://bugzilla.wikimedia.org/65638) [18:18:30] (03CR) 10GWicke: [C: 032] Add PPFrame::isVolatile and PPFrame::setVolatile [core] - 10https://gerrit.wikimedia.org/r/99792 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [18:19:16] 3MediaWiki extensions / 3LocalisationUpdate: sa translation not showing up in interface - 10https://bugzilla.wikimedia.org/65334#c11 (10Bryan Davis) (In reply to NehalDaveND from comment #6) > Sorry My English is not so good. > > I have translate so many days ago, but till today I can't see changes in > tha... [18:19:53] (03CR) 10Manybubbles: Handle deleted redirects properly (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/136364 (https://bugzilla.wikimedia.org/65638) (owner: 10Chad) [18:20:09] (03CR) 10Legoktm: Handle deleted redirects properly (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/136364 (https://bugzilla.wikimedia.org/65638) (owner: 10Chad) [18:21:17] (03PS3) 10Legoktm: Be more forgiving in maintenance script [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135570 (owner: 10Matthias Mullie) [18:21:33] (03CR) 10jenkins-bot: [V: 04-1] Be more forgiving in maintenance script [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135570 (owner: 10Matthias Mullie) [18:21:36] (03Merged) 10jenkins-bot: Add PPFrame::isVolatile and PPFrame::setVolatile [core] - 10https://gerrit.wikimedia.org/r/99792 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [18:21:39] (03CR) 10Chad: Handle deleted redirects properly (033 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/136364 (https://bugzilla.wikimedia.org/65638) (owner: 10Chad) [18:22:03] (03PS2) 10Chad: Handle deleted redirects properly [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/136364 (https://bugzilla.wikimedia.org/65638) [18:22:30] (03CR) 10Legoktm: "Still failing... https://integration.wikimedia.org/ci/job/mwext-Flow-testextensions-master/4322/console" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136283 (owner: 10Legoktm) [18:37:59] * jackmcbarn kicks grrrit-wm [18:37:59] jackmcbarn: I think labs kinda died since wikibugs also quit [18:37:59] ah, nfs is down [18:37:59] [11:29:45 AM] Scheduled maintenance. [18:42:27] (03PS3) 10Spage: Fix ccnorm() function -- strtr fails on empty key [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/136285 (owner: 10Werdna) [18:42:29] (03PS6) 10Jackmcbarn: Add PPFrame::getTTL() and setTTL() [core] - 10https://gerrit.wikimedia.org/r/135887 (https://bugzilla.wikimedia.org/49803) [18:42:31] (03CR) 10Spage: "PS3 is just a comment change." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/136285 (owner: 10Werdna) [18:42:33] (03CR) 10Ori.livneh: [C: 032] Always send debug logs to udp2log server [tools/scap] - 10https://gerrit.wikimedia.org/r/136357 (owner: 10BryanDavis) [18:42:39] (03CR) 10Ori.livneh: [C: 032] Restore sync-dir and sync-file in python [tools/scap] - 10https://gerrit.wikimedia.org/r/136356 (owner: 10BryanDavis) [18:42:41] (03Merged) 10jenkins-bot: Restore sync-dir and sync-file in python [tools/scap] - 10https://gerrit.wikimedia.org/r/136356 (owner: 10BryanDavis) [18:42:43] (03Merged) 10jenkins-bot: Always send debug logs to udp2log server [tools/scap] - 10https://gerrit.wikimedia.org/r/136357 (owner: 10BryanDavis) [18:42:47] (03PS2) 10Jackmcbarn: Add category output to ApiExpandTemplates [core] - 10https://gerrit.wikimedia.org/r/136147 [18:42:51] (03PS3) 10Chad: Handle deleted redirects properly [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/136364 (https://bugzilla.wikimedia.org/65638) [18:42:59] (03CR) 10Legoktm: [C: 031] Handle deleted redirects properly [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/136364 (https://bugzilla.wikimedia.org/65638) (owner: 10Chad) [18:43:03] (03CR) 10Jackmcbarn: [C: 031] "Still works, and now that I95b3cf87 is merged, it's ready to merge too." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/99793 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [18:43:05] (03CR) 10Legoktm: [C: 032 V: 032] Add mediawiki/skins/Example [skins] - 10https://gerrit.wikimedia.org/r/136303 (owner: 10QChris) [18:43:08] (03CR) 10Bsitu: [C: 032] Fix ccnorm() function -- strtr fails on empty key [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/136285 (owner: 10Werdna) [18:43:09] (03Merged) 10jenkins-bot: Fix ccnorm() function -- strtr fails on empty key [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/136285 (owner: 10Werdna) [18:44:43] (03PS4) 10Bsitu: Be more forgiving in maintenance script [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135570 (owner: 10Matthias Mullie) [18:44:59] (03CR) 10Jackmcbarn: [C: 04-1] "Needs rebased." (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/99794 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [18:45:30] 3MediaWiki extensions / 3Collection: PDF Rendering page no longer refreshes - 10https://bugzilla.wikimedia.org/65562#c14 (10Greg Grossmeier) WFM now (tested the beta cluster Cats page). The percentage done jumps around (goes back to 1% after hitting 20% or so, then up to 75%). But the page successfully auto... [18:46:28] (03PS2) 10Florianschmidtwelzow: Show Captcha after click on edit over buttons on EditPage [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/136323 (https://bugzilla.wikimedia.org/65913) [18:46:52] (03CR) 10Bsitu: [C: 032] Be more forgiving in maintenance script [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135570 (owner: 10Matthias Mullie) [18:47:11] (03Merged) 10jenkins-bot: Be more forgiving in maintenance script [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135570 (owner: 10Matthias Mullie) [18:48:37] (03PS1) 10Aaron Schulz: Fixed fatal in SwiftFileBackend when a bogus HTTP status is given [core] - 10https://gerrit.wikimedia.org/r/136388 [18:49:12] (03PS2) 10Yurik: Major refactoring [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/136252 [18:49:36] (03PS2) 10Yurik: Major refactoring - migration to ZeroBanner [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/136243 [18:49:46] (03CR) 10jenkins-bot: [V: 04-1] Major refactoring [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/136252 (owner: 10Yurik) [18:49:48] (03CR) 10jenkins-bot: [V: 04-1] Major refactoring - migration to ZeroBanner [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/136243 (owner: 10Yurik) [18:52:11] in 10 min: https://www.mediawiki.org/wiki/Architecture_meetings/RFC_review_2014-05-30 discussion of extension registration RfC in #wikimedia-office [18:52:30] (03PS2) 10Yurik: TitleValue migration, login, refactorings [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/136245 [18:54:02] (03CR) 10Manybubbles: [C: 031] "Will look at writing a test soon." (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/136364 (https://bugzilla.wikimedia.org/65638) (owner: 10Chad) [18:57:02] 3MediaWiki extensions / 3BookManagerv2: Json book data on book page ( in namespace Book ) is not recognised as JsonContent - 10https://bugzilla.wikimedia.org/65771 (10Raylton P. Sousa) a:3Deepali Jain [18:57:03] 3MediaWiki extensions / 3BookManagerv2: Ease migration of existing books - 10https://bugzilla.wikimedia.org/53286 (10Raylton P. Sousa) a:3Deepali Jain [18:57:16] 3MediaWiki extensions / 3BookManagerv2: Find previous/next links in the navbar more efficiently - 10https://bugzilla.wikimedia.org/52435 (10Raylton P. Sousa) a:3Deepali Jain [18:57:31] 3MediaWiki extensions / 3BookManagerv2: Create a tool for edit books (group of pages) that reduces the learning curve - 10https://bugzilla.wikimedia.org/51239 (10Raylton P. Sousa) a:5Molly White>3Deepali Jain [18:57:47] 3MediaWiki extensions / 3BookManagerv2: Add navigation bar ( with table of contents and prev/next links ) on edit page ( visual editor ) of chapters - 10https://bugzilla.wikimedia.org/65293 (10Raylton P. Sousa) a:3Deepali Jain [18:58:01] 3MediaWiki extensions / 3BookManagerv2: Lager text-area for description field in metadata instead of textbox - 10https://bugzilla.wikimedia.org/65295 (10Raylton P. Sousa) a:3Deepali Jain [18:58:32] 3MediaWiki extensions / 3BookManagerv2: Allow mass indentation changes - 10https://bugzilla.wikimedia.org/52417 (10Raylton P. Sousa) a:3Deepali Jain [18:58:32] 3MediaWiki extensions / 3BookManagerv2: Allow users to add links to the metadata - 10https://bugzilla.wikimedia.org/52816 (10Raylton P. Sousa) a:3Deepali Jain [18:58:47] 3MediaWiki extensions / 3BookManagerv2: Date picker for publication date field in metadata - 10https://bugzilla.wikimedia.org/65296 (10Raylton P. Sousa) a:3Deepali Jain [18:58:48] 3MediaWiki extensions / 3BookManagerv2: Allow array properties to have more than one value - 10https://bugzilla.wikimedia.org/52766 (10Raylton P. Sousa) a:3Deepali Jain [18:59:02] 3MediaWiki extensions / 3BookManagerv2: Import external metadata - 10https://bugzilla.wikimedia.org/51971 (10Raylton P. Sousa) a:5Molly White>3Deepali Jain [18:59:23] (03CR) 10Chad: Handle deleted redirects properly (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/136364 (https://bugzilla.wikimedia.org/65638) (owner: 10Chad) [18:59:32] 3MediaWiki extensions / 3BookManagerv2: Remove edit toolbar from the editing form - 10https://bugzilla.wikimedia.org/53448 (10Raylton P. Sousa) a:5roopak>3Deepali Jain [18:59:33] 3MediaWiki extensions / 3BookManagerv2: Warn user that changes will not be saved if s/he navigates away - 10https://bugzilla.wikimedia.org/53449 (10Raylton P. Sousa) a:3Deepali Jain [18:59:46] 3MediaWiki extensions / 3BookManagerv2: bookmanagerv2-publication-date-field-field message is missing - 10https://bugzilla.wikimedia.org/58080 (10Raylton P. Sousa) a:3Deepali Jain [18:59:47] 3MediaWiki extensions / 3BookManagerv2: Undefined property: stdClass::$publication_year in BookManagerv2.hooks.php on line 392 - 10https://bugzilla.wikimedia.org/58079 (10Raylton P. Sousa) a:3Deepali Jain [18:59:47] 3MediaWiki extensions / 3BookManagerv2: Slow loading of Json Editor in mobile frontend - 10https://bugzilla.wikimedia.org/65769 (10Raylton P. Sousa) a:3Deepali Jain [19:00:11] (03CR) 10Nikerabbit: [C: 04-1] Allow for custom templates (035 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/133684 (https://bugzilla.wikimedia.org/63889) (owner: 10Dan-nl) [19:00:18] 3MediaWiki extensions / 3BookManagerv2: Create basic tool for reading books(group of pages) - 10https://bugzilla.wikimedia.org/50386 (10Raylton P. Sousa) a:5Molly White>3Deepali Jain [19:00:31] 3MediaWiki extensions / 3BookManagerv2: Full screen reading mode - 10https://bugzilla.wikimedia.org/65300 (10Raylton P. Sousa) a:3Deepali Jain [19:01:02] 3MediaWiki extensions / 3BookManagerv2: Implement options to format text to improve readability - 10https://bugzilla.wikimedia.org/65329 (10Raylton P. Sousa) a:3Deepali Jain [19:01:17] 3MediaWiki extensions / 3BookManagerv2: Option to search in book on all pages - 10https://bugzilla.wikimedia.org/65330 (10Raylton P. Sousa) a:3Deepali Jain [19:01:17] 3MediaWiki extensions / 3BookManagerv2: Metadata fields are empty - 10https://bugzilla.wikimedia.org/58078 (10Raylton P. Sousa) a:3Deepali Jain [19:04:15] (03PS2) 10Robmoen: Add border-radius and box-shadow functions to mediawiki mixins [core] - 10https://gerrit.wikimedia.org/r/134964 [19:05:02] (03CR) 10Raimond Spekking: "@Bartosz: Until Sunday I am in travelling mode. I will handle it next week." [core] - 10https://gerrit.wikimedia.org/r/132477 (https://bugzilla.wikimedia.org/58715) (owner: 10Bartosz Dziewoński) [19:12:16] 3MediaWiki extensions / 3Translate: Fix code styling issues for Special:PageMigration - 10https://bugzilla.wikimedia.org/65738#c3 (10Nemo) Niklas, can you please tell if this was fixed as byproduct of https://gerrit.wikimedia.org/r/135750 / bug 65736 or what else is left to do to comply with [[mw:CC]]? [19:12:30] 3MediaWiki extensions / 3Translate: Id and class names for Special:PageMigration need to be fixed as per the standards followed - 10https://bugzilla.wikimedia.org/65736#c8 (10Nemo) 5PATC>3RESO/FIX Assuming fixed, further issues to be reported separately. [19:13:16] 3MediaWiki / 3Database: Fix "Uncommitted DB writes (transaction from DatabaseBase::query)" - 10https://bugzilla.wikimedia.org/56269#c56 (10Mark A. Hershberger) (In reply to Dan Barrett from comment #55) > I'm getting these errors as of today in 1.22.5 when we try to delete an > article. See my comment number... [19:16:06] thedj: Doe jij nog steeds wat met vlc? [19:16:52] (03CR) 10Bartosz Dziewoński: "Thanks." [skins] - 10https://gerrit.wikimedia.org/r/136303 (owner: 10QChris) [19:20:46] 3MediaWiki extensions / 3Translate: Supersede the edit/pencil icon - 10https://bugzilla.wikimedia.org/65898 (10Nemo) 5PATC>3RESO/FIX [19:23:34] (03PS2) 10Spage: Ignore expected exceptions in WhatLinksHere [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136256 (https://bugzilla.wikimedia.org/65915) (owner: 10Bsitu) [19:30:01] 3MediaWiki / 3Database: Fix "Uncommitted DB writes (transaction from DatabaseBase::query)" - 10https://bugzilla.wikimedia.org/56269#c57 (10Dan Barrett) We installed 1.22.5 about a month ago. We did not experience problems with deletes until today, and the problem has gone away. Before that, we had 1.21.x.... [19:45:44] (03CR) 10Spage: [C: 04-1] "Some minor cleanup, and I dunno if the same exception update should be in WorkflowLoader __construct." (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136256 (https://bugzilla.wikimedia.org/65915) (owner: 10Bsitu) [19:49:16] 3MediaWiki extensions / 3Translate: Deprecated: Use of SpecialRecentChangesQuery hook (used in TranslateRcFilter::translationFilter) - 10https://bugzilla.wikimedia.org/65776#c2 (10Niklas Laxström) 5RESO/INV>3REOP The current practice is to fix deprecation warnings. In some rare cases that might have bee... [19:52:24] (03PS1) 10Dduvall: Packaged plugin as gem to allow local installation [vagrant] - 10https://gerrit.wikimedia.org/r/136441 [19:53:11] * marxarelli hopes his first commit is torn to pieces [19:53:33] 3Wikimedia / 3Mailing lists: african-wikimedians - 10https://bugzilla.wikimedia.org/65959 (10Rexford) 3UNCO p:3Unprio s:3enhanc a:3None Name of mailing list: african-wikimedians Purpose: mailing list for African wikimedians Admins: seanmavley@gmail.com (Nkansah Rexford), ndubaneds@gmail.com ( Dumis... [19:54:46] 3Wikimedia / 3Mailing lists: african-wikimedians - 10https://bugzilla.wikimedia.org/65959#c1 (10Rexford) If available before June 5, it'll be great. [19:58:18] (03PS3) 10Yurik: TitleValue migration, login, refactorings [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/136245 [19:59:31] 3MediaWiki extensions / 3CirrusSearch: Retry searches when namespace-specific search returns nothing - 10https://bugzilla.wikimedia.org/52935#c2 (10Chad H.) p:5Low>3Lowest s:5minor>3enhanc (In reply to Nik Everett from comment #1) > The search part seems to be working correctly. When we have a names... [20:00:31] 3MediaWiki extensions / 3Translate: Special page for migration of legacy translation pages (tracking) - 10https://bugzilla.wikimedia.org/65740 (10Bohdan) [20:00:32] 3MediaWiki extensions / 3Translate: [Pagemigration] Weird look and unknown use of the icons - 10https://bugzilla.wikimedia.org/65961 (10Bohdan) 3NEW p:3Unprio s:3normal a:3Pratik Lahoti I can see the icons on the right but they look like I see not the whole part of them http://imgur.com/CnqzSOg (or v... [20:03:46] 3MediaWiki extensions / 3Translate: Fix code styling issues for Special:PageMigration - 10https://bugzilla.wikimedia.org/65738#c4 (10Niklas Laxström) It's getting better. With some further work and adding some QUnit tests this can be closed. Note that I do not just mean mw:CC but code architecture as well. [20:05:16] (03CR) 10Parent5446: [C: 04-1] Make convertUserOptions.php more self-contained (033 comments) [core] - 10https://gerrit.wikimedia.org/r/136339 (https://bugzilla.wikimedia.org/63677) (owner: 10PleaseStand) [20:06:31] 3MediaWiki extensions / 3Translate: [Pagemigration] Weird look and unknown use of the icons - 10https://bugzilla.wikimedia.org/65961#c1 (10Pratik Lahoti) The icons are looking weird because they were lacking the no-repeat property which has been already fixed at https://gerrit.wikimedia.org/r/#/c/135750/9/re... [20:14:01] 3MediaWiki extensions / 3CirrusSearch: Searching with namespace prefix and no title yields inconsistent results - 10https://bugzilla.wikimedia.org/27760#c8 (10Chad H.) 5NEW>3RESO/INV Actually this is all working as intended, I see no bug here. Closing INVALID. [20:17:46] (03PS1) 10BryanDavis: Fix rsync command for files not in sync root [tools/scap] - 10https://gerrit.wikimedia.org/r/136446 [20:18:35] ori: ^ [20:19:04] That worked for me in my test vm [20:19:44] bd808|deploy: cmd.extend(['--include', '/'.join(parts[:1])]) [20:19:48] bd808|deploy: shouldn't i be in there somewhere? [20:19:54] i as in the index var [20:20:00] did you test with a deeply nested subdir? [20:20:09] for christ sake. yeah [20:20:23] I was just about to test with a deeper path :( [20:21:16] 3Wikimedia / 3Mailing lists: african-wikimedians - 10https://bugzilla.wikimedia.org/65959#c2 (10Tomasz W. Kozlowski) 5UNCO>3NEW p:5Unprio>3Low Please provide a link to a community discussion expressing a need (or wish) of the list. Thanks! [20:22:15] 3Analytics / 3EventLogging: MobileWikiOperatorCode Schema - 10https://bugzilla.wikimedia.org/65872#c6 (10Ori Livneh) 5NEW>3RESO/WOR mysql:root@localhost [log]> select count(*) from MobileWikiAppOperatorCode_8678522; +----------+ | count(*) | +----------+ | 11 | +----------+ 1 row in set (0.00 sec) [20:23:00] (03PS5) 10Spage: Don't be too strict when resolving the DB data [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135572 (https://bugzilla.wikimedia.org/65802) (owner: 10Matthias Mullie) [20:24:13] (03PS2) 10BryanDavis: Fix rsync command for files not in sync root [tools/scap] - 10https://gerrit.wikimedia.org/r/136446 [20:25:04] (03Abandoned) 10Robmoen: Hide signup stats list on small screen sizes rather than move it [core] - 10https://gerrit.wikimedia.org/r/135054 (https://bugzilla.wikimedia.org/49002) (owner: 10Robmoen) [20:27:11] (03PS2) 10Bsitu: Error message should be parsed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136272 (https://bugzilla.wikimedia.org/65920) [20:27:28] bd808|deploy: reviewing [20:27:37] ty [20:28:30] ori: It spits out truly awesome looking commands [20:28:30] `sudo -u mwdeploy -n -- /usr/bin/rsync --archive --delete-delay --delay-updates --compress --delete --exclude=**/.svn/lock --exclude=**/.git/objects --exclude=**/.git/**/objects --exclude=**/cache/l10n/*.cdb --no-perms --verbose --include=/php-1.24wmf2 --include=/php-1.24wmf2/extensions --include=/php-1.24wmf2/extensions/Thanks --include=/php-1.24wmf2/extensions/Thanks/tests [20:28:30] --include=/php-1.24wmf2/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php --exclude=* localhost::common /usr/local/apache/common-local` [20:30:13] is php case sensitive? I'm not sure it matters but in User.php there are a lot of references to function getID() when it's actually function getId() [20:30:24] (03CR) 10Ori.livneh: [C: 032] Fix rsync command for files not in sync root [tools/scap] - 10https://gerrit.wikimedia.org/r/136446 (owner: 10BryanDavis) [20:30:36] (03Merged) 10jenkins-bot: Fix rsync command for files not in sync root [tools/scap] - 10https://gerrit.wikimedia.org/r/136446 (owner: 10BryanDavis) [20:30:49] bd808|deploy: test it tho [20:31:09] ori: Starting to test in beta now [20:31:14] (03PS6) 10Spage: Don't be too strict when resolving the DB data [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135572 (https://bugzilla.wikimedia.org/65802) (owner: 10Matthias Mullie) [20:32:24] (03CR) 10Bsitu: [C: 032] "Re-apply legoktm's +2, it failed before because of an unrelated unit test" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136272 (https://bugzilla.wikimedia.org/65920) (owner: 10Bsitu) [20:32:39] (03Merged) 10jenkins-bot: Error message should be parsed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136272 (https://bugzilla.wikimedia.org/65920) (owner: 10Bsitu) [20:33:31] 3MediaWiki extensions / 3Cite: Cite: Support multi-column and alternative list-style for tag (like enwiki {{reflist}}) - 10https://bugzilla.wikimedia.org/51260 (10Alex Monk) [20:35:11] (03CR) 10Isarra: [C: 032 V: 032] Updated author infomation. [extensions/LogoFunctions] - 10https://gerrit.wikimedia.org/r/136279 (owner: 10devunt) [20:35:33] (03CR) 10Withoutaname: Warn when user trying to block nonexistent user (031 comment) [core] - 10https://gerrit.wikimedia.org/r/136290 (https://bugzilla.wikimedia.org/35687) (owner: 10devunt) [20:35:54] (03PS3) 10Yurik: Major refactoring - migration to ZeroBanner [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/136243 [20:36:03] (03CR) 10jenkins-bot: [V: 04-1] Major refactoring - migration to ZeroBanner [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/136243 (owner: 10Yurik) [20:40:11] (03PS1) 10Chad: Store the proper gender variant namespace text [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/136447 (https://bugzilla.wikimedia.org/32634) [20:42:31] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Add accent squashing to Italian - 10https://bugzilla.wikimedia.org/63633 (10Chad H.) 5PATC>3RESO/FIX [20:43:17] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Our Elasticsearch monitoring complains while we're doing normal maintenance - 10https://bugzilla.wikimedia.org/63137#c2 (10Chad H.) 5PATC>3NEW Nothing to review at the moment, resetting status. I think we can still do better. [20:44:15] (03PS1) 10Ori.livneh: renamed: rcstream.py -> rcstream [services/rcstream] - 10https://gerrit.wikimedia.org/r/136448 [20:44:15] 3MediaWiki extensions / 3Cite: Cite: Support multi-column and alternative list-style for tag (like enwiki {{reflist}}) - 10https://bugzilla.wikimedia.org/51260#c25 (10James Forrester) (In reply to Gabriel Wicke from comment #24) > Is there a good reason to use magic attributes and inline style... [20:45:15] (03CR) 10Ori.livneh: [C: 032] "trivial" [services/rcstream] - 10https://gerrit.wikimedia.org/r/136448 (owner: 10Ori.livneh) [20:45:19] (03Merged) 10jenkins-bot: renamed: rcstream.py -> rcstream [services/rcstream] - 10https://gerrit.wikimedia.org/r/136448 (owner: 10Ori.livneh) [20:46:36] (03PS2) 10Bsitu: Feed only array type to array_merge() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136235 (https://bugzilla.wikimedia.org/65963) [20:47:32] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Lower cache time for suggestions - 10https://bugzilla.wikimedia.org/60007#c6 (10Chad H.) p:5Low>3Normal a:3Chad H. Already at 6. Lowering to 3 with gerrit 136449. [20:48:18] (03PS4) 10Bsitu: Make sure cache key is always the same [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135804 (owner: 10Matthias Mullie) [20:49:19] (03PS1) 10Ori.livneh: add shebang to rcstream script [services/rcstream] - 10https://gerrit.wikimedia.org/r/136452 [20:49:29] (03CR) 10Ori.livneh: [C: 032] add shebang to rcstream script [services/rcstream] - 10https://gerrit.wikimedia.org/r/136452 (owner: 10Ori.livneh) [20:49:31] (03Merged) 10jenkins-bot: add shebang to rcstream script [services/rcstream] - 10https://gerrit.wikimedia.org/r/136452 (owner: 10Ori.livneh) [20:56:17] ^demon|away: https://gerrit.wikimedia.org/r/#/c/136388/ [20:56:28] <^demon|away> But I'm |away! [20:56:55] that works when you are at home, not when 1 meter in front of me in front of the screen [20:57:10] <^demon|away> d'oh! [20:57:17] next time, next time [20:57:31] (03CR) 10Chad: [C: 032] Fixed fatal in SwiftFileBackend when a bogus HTTP status is given [core] - 10https://gerrit.wikimedia.org/r/136388 (owner: 10Aaron Schulz) [20:57:45] <^demon|away> Your turn: https://gerrit.wikimedia.org/r/#/c/131518/ [20:59:56] (03PS2) 10Aaron Schulz: Transaction coverage fix for doDeleteArticleReal [core] - 10https://gerrit.wikimedia.org/r/136343 [21:01:00] jackmcbarn, did you check that https://gerrit.wikimedia.org/r/#/c/99793/ doesn't change performance? [21:01:04] (03Merged) 10jenkins-bot: Fixed fatal in SwiftFileBackend when a bogus HTTP status is given [core] - 10https://gerrit.wikimedia.org/r/136388 (owner: 10Aaron Schulz) [21:02:46] gwicke: no, but i don't think it matters, since everywhere that it would save time by caching references, it does so at the cost of producing the wrong output [21:06:16] 3MediaWiki / 3Search: SearchHighlighter::highlightSimple() doesn't escape regex chars in input, leads to PHP errors about unbalanced ( ) - 10https://bugzilla.wikimedia.org/23108#c7 (10Chad H.) I can't find any place where those \b's would have been added. [21:08:35] jackmcbarn, I just wasn't 100% sure if the volatile applied to the child only, or the parent frame; but looking at https://gerrit.wikimedia.org/r/#/c/99792/ convinced me that it's the former [21:09:07] (03CR) 10GWicke: [C: 032] Mark parser hook output as volatile [extensions/Cite] - 10https://gerrit.wikimedia.org/r/99793 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [21:09:15] (03Merged) 10jenkins-bot: Mark parser hook output as volatile [extensions/Cite] - 10https://gerrit.wikimedia.org/r/99793 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [21:09:28] (03CR) 10BryanDavis: "This looks awesome. I'll upgrade vagrant on my home laptop tonight to test it out." [vagrant] - 10https://gerrit.wikimedia.org/r/136441 (owner: 10Dduvall) [21:10:01] 3MediaWiki extensions / 3Cite: Cite: Support multi-column and alternative list-style for tag (like enwiki {{reflist}}) - 10https://bugzilla.wikimedia.org/51260 (10James Forrester) [21:10:34] (03CR) 10Hashar: "I love the principle, thank you Bryan." [tools/scap] - 10https://gerrit.wikimedia.org/r/136357 (owner: 10BryanDavis) [21:12:17] 3MediaWiki / 3Templates: Add an option to disable template caching - 10https://bugzilla.wikimedia.org/31834#c6 (10Jackmcbarn) 5PATC>3RESO/FIX a:3Brad Jorsch Templates containing ref or reflist tags will no longer be cached. This change will be live on all WMF wikis starting on June 12th. [21:19:55] (03PS1) 10Hashar: Ignore MobileApp unit tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/136458 (https://bugzilla.wikimedia.org/65954) [21:20:12] (03CR) 10Hashar: [C: 032] Ignore MobileApp unit tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/136458 (https://bugzilla.wikimedia.org/65954) (owner: 10Hashar) [21:20:21] (03Merged) 10jenkins-bot: Ignore MobileApp unit tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/136458 (https://bugzilla.wikimedia.org/65954) (owner: 10Hashar) [21:20:29] (03PS1) 10BryanDavis: Add a gitreview file [core/vendor] - 10https://gerrit.wikimedia.org/r/136459 [21:24:41] (03CR) 10Legoktm: [C: 032 V: 032] Add a gitreview file [core/vendor] - 10https://gerrit.wikimedia.org/r/136459 (owner: 10BryanDavis) [21:24:45] (03CR) 10Bsitu: [C: 032] Make sure cache key is always the same [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135804 (owner: 10Matthias Mullie) [21:24:55] bd808: \o/ [21:24:56] (03CR) 10Chad: "Thought experiment: what if we moved the actual query parsing to core." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/131613 (owner: 10Manybubbles) [21:25:12] (03Merged) 10jenkins-bot: Make sure cache key is always the same [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135804 (owner: 10Matthias Mullie) [21:26:48] (03PS4) 10Yurik: Major refactoring - migration to ZeroBanner [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/136243 [21:26:58] (03CR) 10jenkins-bot: [V: 04-1] Major refactoring - migration to ZeroBanner [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/136243 (owner: 10Yurik) [21:27:46] 3MediaWiki extensions / 3[other]: MobileApp tests are failing - 10https://bugzilla.wikimedia.org/65954#c4 (10Antoine "hashar" Musso) 5PATC>3NEW The tests are no more voting in Zuul. Whenever the tests are fixed we can make it voting again. Meanwhile, moving but to MediaWiki extensions component so the b... [21:30:13] (03CR) 10Dduvall: "I didn't realize there was an open bug for this (65066). Should I amend the commit message?" [vagrant] - 10https://gerrit.wikimedia.org/r/136441 (owner: 10Dduvall) [21:31:48] 3Wikimedia / 3Bugzilla: Create a Bugzilla component for MobileApp MediaWiki extension - 10https://bugzilla.wikimedia.org/65964 (10Antoine "hashar" Musso) 3NEW p:3Unprio s:3normal a:3None The MobileApp MediaWiki extension is missing a component in Bugzilla. I got Bug 65954 moved to [other]. It would... [21:32:18] <^demon|away> Nemo_bis: I'm gonna rebase your change and merge. [21:34:13] (03PS14) 10Chad: Save advanced search namespace prefs on Special:Search itself [core] - 10https://gerrit.wikimedia.org/r/131727 (https://bugzilla.wikimedia.org/52817) (owner: 10Nemo bis) [21:34:15] 3Wikimedia / 3Bugzilla: Create a Bugzilla component for MobileApp MediaWiki extension - 10https://bugzilla.wikimedia.org/65964#c1 (10Kunal Mehta (Legoktm)) It's under Wikipedia App->Extension:MobileApp, see bug 64621 for why. [21:36:12] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] "Generally seems to work on localhost. Let's see this thing on beta labs." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/136243 (owner: 10Yurik) [21:36:15] (03CR) 10jenkins-bot: [V: 04-1] Major refactoring - migration to ZeroBanner [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/136243 (owner: 10Yurik) [21:36:46] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] "Generally seems to work on localhost. Let's see this on beta labs." [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/136245 (owner: 10Yurik) [21:37:33] (03PS3) 10Yurik: Major refactoring [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/136252 [21:37:37] (03CR) 10jenkins-bot: [V: 04-1] Major refactoring [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/136252 (owner: 10Yurik) [21:38:42] (03CR) 10Chad: [C: 032] Save advanced search namespace prefs on Special:Search itself [core] - 10https://gerrit.wikimedia.org/r/131727 (https://bugzilla.wikimedia.org/52817) (owner: 10Nemo bis) [21:39:06] (03PS1) 10Jforrester: Update VisualEditor to I84e31323 [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/136466 [21:40:16] 3Wikimedia / 3Bugzilla: Reorganize "Wikipedia Apps" product - 10https://bugzilla.wikimedia.org/64621#c16 (10Antoine "hashar" Musso) (In reply to Yuvi Panda from comment #13) > We should keep MobileApp in the Wikimedia Apps product, since it is > completely unused elsehwere, and for easier visibility. That m... [21:40:46] 3Wikimedia / 3Bugzilla: Create a Bugzilla component for MobileApp MediaWiki extension - 10https://bugzilla.wikimedia.org/65964#c2 (10Antoine "hashar" Musso) Nice thanks Kunal. I commented on that bug https://bugzilla.wikimedia.org/show_bug.cgi?id=64621#c16 . Making it a dependency. [21:41:01] 3Wikimedia / 3Bugzilla: Reorganize "Wikipedia Apps" product - 10https://bugzilla.wikimedia.org/64621 (10Antoine "hashar" Musso) [21:41:27] <^demon|away> Nemo_bis and I removed 31 preferences from Special:Preferences today. What did *you* accomplish? [21:42:14] (03PS1) 10Jforrester: Update VisualEditor to I84e31323 and I72be9098 [core] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/136467 [21:42:16] (03CR) 10Chad: [C: 032] Adds OAI.php default entry for unit tests [extensions/OAI] - 10https://gerrit.wikimedia.org/r/136105 (https://bugzilla.wikimedia.org/65895) (owner: 10Hashar) [21:42:18] (03CR) 10Matěj Grabovský: Warn when user trying to block nonexistent user (031 comment) [core] - 10https://gerrit.wikimedia.org/r/136290 (https://bugzilla.wikimedia.org/35687) (owner: 10devunt) [21:43:20] (03Merged) 10jenkins-bot: Save advanced search namespace prefs on Special:Search itself [core] - 10https://gerrit.wikimedia.org/r/131727 (https://bugzilla.wikimedia.org/52817) (owner: 10Nemo bis) [21:44:36] (03Merged) 10jenkins-bot: Adds OAI.php default entry for unit tests [extensions/OAI] - 10https://gerrit.wikimedia.org/r/136105 (https://bugzilla.wikimedia.org/65895) (owner: 10Hashar) [21:46:31] 3MediaWiki extensions / 3Cite: Cite: Support multi-column and alternative list-style for tag (like enwiki {{reflist}}) - 10https://bugzilla.wikimedia.org/51260#c26 (10Gabriel Wicke) See https://gerrit.wikimedia.org/r/#/c/120962/ for more discussion on this. [21:50:00] (03PS1) 10Hashar: Dependencies for ZeroBanner and ZeroPortal [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136469 [21:51:56] (03PS2) 10Hashar: Dependencies for ZeroBanner and ZeroPortal [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136469 [21:52:32] (03CR) 10Yurik: [C: 032] Dependencies for ZeroBanner and ZeroPortal [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136469 (owner: 10Hashar) [21:53:10] (03CR) 10Hashar: "recheck" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/136243 (owner: 10Yurik) [21:54:00] (03Merged) 10jenkins-bot: Dependencies for ZeroBanner and ZeroPortal [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136469 (owner: 10Hashar) [21:54:08] (03CR) 10Hashar: "recheck" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/135086 (owner: 10Yurik) [21:54:28] (03CR) 10Hashar: "recheck" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/136252 (owner: 10Yurik) [21:55:30] (03CR) 10Aaron Schulz: [C: 032] Allow adding Deleted log entries (031 comment) [core] - 10https://gerrit.wikimedia.org/r/130232 (https://bugzilla.wikimedia.org/63650) (owner: 10CSteipp) [21:56:03] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/136470 [21:56:22] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/136470 (owner: 10Hashar) [21:56:50] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/136470 (owner: 10Hashar) [21:57:27] (03Abandoned) 10Yurik: Updated zeroconfig- to zero-config- message keys to avoid i18n conflicts [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/135086 (owner: 10Yurik) [21:58:02] (03CR) 10Hashar: [C: 04-1] "You would need a ZeroPortal.php file as an entry point. That is how the CI infrastructure inject extensions before running tests :)" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/136252 (owner: 10Yurik) [21:58:34] (03CR) 10Yurik: [C: 032] Major refactoring - migration to ZeroBanner [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/136243 (owner: 10Yurik) [21:58:44] (03Merged) 10jenkins-bot: Major refactoring - migration to ZeroBanner [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/136243 (owner: 10Yurik) [21:58:56] (03Merged) 10jenkins-bot: Allow adding Deleted log entries [core] - 10https://gerrit.wikimedia.org/r/130232 (https://bugzilla.wikimedia.org/63650) (owner: 10CSteipp) [21:59:32] (03CR) 10Hashar: "Err, tests will pass whenever ZeroBanner ends up having the default entry point ZeroBanner.php" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/136252 (owner: 10Yurik) [22:00:15] (03CR) 10Hashar: "recheck" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/136252 (owner: 10Yurik) [22:00:28] (03PS1) 10BryanDavis: Add README and skeletal composer.json [core/vendor] - 10https://gerrit.wikimedia.org/r/136472 [22:00:30] (03PS1) 10BryanDavis: Add psr/log 1.0.0 [core/vendor] - 10https://gerrit.wikimedia.org/r/136473 [22:00:32] (03PS1) 10BryanDavis: Add monolog/monolog 1.9.1 [core/vendor] - 10https://gerrit.wikimedia.org/r/136474 [22:00:34] (03PS1) 10BryanDavis: Add swiftmailer/swiftmailer 5.2.0 [core/vendor] - 10https://gerrit.wikimedia.org/r/136475 [22:01:06] (03PS2) 10Bsitu: Add sortby last activity as a user preference [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/134955 [22:02:25] (03PS2) 10BryanDavis: Add README and skeletal composer.json [core/vendor] - 10https://gerrit.wikimedia.org/r/136472 [22:02:30] (03CR) 10Bsitu: Add sortby last activity as a user preference (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/134955 (owner: 10Bsitu) [22:02:49] (03CR) 10Hashar: "I got confused. Extensions are loading properly now, congratulations. Write moaaar tests!" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/136252 (owner: 10Yurik) [22:03:41] (03CR) 10Ori.livneh: [C: 032 V: 032] Add README and skeletal composer.json [core/vendor] - 10https://gerrit.wikimedia.org/r/136472 (owner: 10BryanDavis) [22:03:58] bd808: any reason not to merge the rest of the patches? [22:04:34] is there any good way for an extension to store data tied to a PPFrame? [22:05:02] ori: I guess the only reason not to merge would be to have some kind of review by csteipp ? [22:05:30] sure [22:05:43] (03PS2) 10BryanDavis: Add psr/log 1.0.0 [core/vendor] - 10https://gerrit.wikimedia.org/r/136473 [22:05:46] 3MediaWiki / 3Search: mssuggest should support a .mw-search classname instead of hardcoded ids - 10https://bugzilla.wikimedia.org/30954#c3 (10Chad H.) How relevant is this nowadays since we don't use mwsuggest and use simplesearch? [22:06:03] (03PS2) 10BryanDavis: Add monolog/monolog 1.9.1 [core/vendor] - 10https://gerrit.wikimedia.org/r/136474 [22:06:14] (03PS2) 10BryanDavis: Add swiftmailer/swiftmailer 5.2.0 [core/vendor] - 10https://gerrit.wikimedia.org/r/136475 [22:07:05] (03PS1) 10Aaron Schulz: Fixed type hint [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/136478 [22:07:30] (03CR) 10Aaron Schulz: [C: 032 V: 032] Changed $article to be instance of WikiPage [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/135563 (https://bugzilla.wikimedia.org/59012) (owner: 10Florianschmidtwelzow) [22:09:16] 3MediaWiki extensions / 3Collection: PDF Rendering page no longer refreshes - 10https://bugzilla.wikimedia.org/65562#c15 (10Greg Grossmeier) 5PATC>3RESO/FIX Ok, just did another one. I'm calling this fixed. Matma: if you want to backport, want to do it early next week? [22:09:31] 3MediaWiki / 3Search: Searching for media on Commons: Prefer exact wording of search terms to similar articles - 10https://bugzilla.wikimedia.org/42070#c3 (10Chad H.) I'm inclined to WONTFIX this as it's all working as intended. Basically you're wanting exact-string matching which is what quoting it does. Ch... [22:09:41] (03CR) 10Aaron Schulz: [C: 032] Don't use isset() to check for null [core] - 10https://gerrit.wikimedia.org/r/132664 (owner: 10IAlex) [22:11:46] (03CR) 10BryanDavis: "I created this change set using these commands:" [core/vendor] - 10https://gerrit.wikimedia.org/r/136473 (owner: 10BryanDavis) [22:13:20] (03Merged) 10jenkins-bot: Don't use isset() to check for null [core] - 10https://gerrit.wikimedia.org/r/132664 (owner: 10IAlex) [22:14:02] 3MediaWiki / 3JavaScript: Javascript inject by anonymous users on private wikis with $wgRawHtml enabled - 10https://bugzilla.wikimedia.org/65501 (10Sam Reed (reedy)) a:5security>3None [22:21:47] 3MediaWiki / 3Internationalization: For Serbian (sr), REDIRECT information to sr-ec (or nothing) is displayed instead of the string itself wherever serbian is selected - 10https://bugzilla.wikimedia.org/63704 (10milicevic04) [22:29:56] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (469d40c88f) [core] - 10https://gerrit.wikimedia.org/r/136484 [22:30:39] (03PS4) 10Chad: Final page of search results sometimes having erroneous "next" link [core] - 10https://gerrit.wikimedia.org/r/54317 (https://bugzilla.wikimedia.org/19938) (owner: 10Dilexie) [22:40:27] (03PS7) 10Bsitu: Don't be too strict when resolving the DB data [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135572 (https://bugzilla.wikimedia.org/65802) (owner: 10Matthias Mullie) [22:40:50] (03PS1) 10BryanDavis: Fix `composer diagnose` warnings [core/vendor] - 10https://gerrit.wikimedia.org/r/136486 [22:47:04] (03CR) 10GWicke: [C: 032] Add category output to ApiExpandTemplates [core] - 10https://gerrit.wikimedia.org/r/136147 (owner: 10Jackmcbarn) [22:49:59] (03CR) 10GWicke: "This needs another rebase. Blame the changelog." [core] - 10https://gerrit.wikimedia.org/r/136234 (owner: 10Jackmcbarn) [22:50:30] (03Merged) 10jenkins-bot: Add category output to ApiExpandTemplates [core] - 10https://gerrit.wikimedia.org/r/136147 (owner: 10Jackmcbarn) [22:50:32] (03CR) 10Isarra: "Aside from the spacing stuff it looks good." [core] - 10https://gerrit.wikimedia.org/r/132946 (https://bugzilla.wikimedia.org/65087) (owner: 10Gerrit Patch Uploader) [22:52:29] (03CR) 10Odder: "Please use shorter topic names in the future." [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/136158 (owner: 10Mwalker) [22:52:57] (03PS5) 10Jackmcbarn: Support {{!}} as a magic word [core] - 10https://gerrit.wikimedia.org/r/136234 [22:53:57] jackmcbarn, are you around? [22:53:59] yeah [22:54:11] I'm actually having second thoughts about https://gerrit.wikimedia.org/r/#/c/136147/2/includes/api/ApiExpandTemplates.php [22:54:24] hmm [22:54:25] why? [22:54:39] maybe it would be cleaner to also set this on $retval_array [22:54:50] so that it becomes a normal property in JSON [22:55:07] rather than its own weird object [22:55:57] kk [22:56:24] I guess in XML it would become a json attribute [22:56:37] hmm [22:56:38] i' [22:56:47] i'll have to see what it does in xml [22:56:49] (probably nothing good) [22:57:29] we generally care more about JSON these days [22:57:58] (03CR) 10BryanDavis: "> Should I amend the commit message?" [vagrant] - 10https://gerrit.wikimedia.org/r/136441 (owner: 10Dduvall) [22:58:20] so if it is okayish but not pretty in XML, then IMO that's fine [23:00:18] (03CR) 10BryanDavis: Packaged plugin as gem to allow local installation (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/136441 (owner: 10Dduvall) [23:00:21] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.1.0-pre (469d40c88f) [core] - 10https://gerrit.wikimedia.org/r/136484 (owner: 10Catrope) [23:04:00] 3MediaWiki extensions / 3FlaggedRevs: reviewAllPages.php doesn't work triggers "First argument must be a Title or WikiPage" - 10https://bugzilla.wikimedia.org/59012 (10Florian) 5PATC>3RESO/FIX [23:04:01] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (469d40c88f) [core] - 10https://gerrit.wikimedia.org/r/136484 (owner: 10Catrope) [23:04:07] gwicke: setting it that way makes it look nice in json, but not appear at all in xml [23:04:12] (03PS3) 10Bsitu: Ignore expected exceptions in WhatLinksHere [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136256 (https://bugzilla.wikimedia.org/65915) [23:04:37] the issue is that it's an array of objects [23:04:41] jackmcbarn, hm [23:05:37] we don't use xml, so who cares ;) [23:06:01] i do question why we allow all these different output formats [23:06:06] this is an example why people are moaning about it [23:06:29] we should check our logs to see if people are accessing non-xml, non-json formats, and remove them if nothing's around [23:06:29] the APIv2 discussion included 'get rid of XML' [23:07:00] at this point it's mostly kept up to avoid breaking legacy clients [23:07:13] <^demon|away> Heh, speaking of API. [23:07:16] <^demon|away> I have a fun patch. [23:07:18] in which case not seeing the new attribute would be fine [23:07:30] that still feels like a bad idea [23:08:09] (03PS1) 10Chad: WIP: Remove less-than-useful API output formats [core] - 10https://gerrit.wikimedia.org/r/136490 [23:08:13] <^demon|away> YuviPanda: That's my plan ^ [23:08:15] another option might be to fix the xml handler to serialize arrays to json [23:08:32] <^demon|away> wddx is completely unused. the others probably aren't used much at all. [23:08:39] <^demon|away> xml/json are popular. [23:08:49] <^demon|away> so is php because people are lazy and just want to unserialize() the result. [23:08:59] (03PS2) 10Dduvall: Packaged plugin as gem to allow local installation [vagrant] - 10https://gerrit.wikimedia.org/r/136441 (https://bugzilla.wikimedia.org/65066) [23:09:08] i'm not too concerned about the way it looks now, since it can potentially be a big element [23:09:48] jackmcbarn, basically all users who are interested in this will use JSON [23:09:59] so it matters that that's usable [23:10:10] actually... [23:10:12] i have an idea [23:10:14] <^demon|away> YuviPanda: In my past grepping, format=wddx is *only* used from broken bots that crawl action=help and follow the one link to a format=wddx example :p [23:10:23] new changeset coming shortly (hopefully) [23:11:05] (03CR) 10GWicke: [C: 031] "+1 for the idea." [core] - 10https://gerrit.wikimedia.org/r/136490 (owner: 10Chad) [23:12:01] (03CR) 10jenkins-bot: [V: 04-1] WIP: Remove less-than-useful API output formats [core] - 10https://gerrit.wikimedia.org/r/136490 (owner: 10Chad) [23:12:11] <^demon|away> Heh, surprise. [23:12:53] <^demon|away> Missed a git rm. [23:12:54] (03PS2) 10Chad: WIP: Remove less-than-useful API output formats [core] - 10https://gerrit.wikimedia.org/r/136490 [23:14:19] heh [23:14:25] ^demon|away: would be nice to kill them all [23:14:39] ^demon|away: empty [] in JSON when you were expecting {} is terrible [23:15:02] <^demon|away> Can we get rid of raw(fm) as well? [23:15:06] <^demon|away> Or does something still use that shiz? [23:17:13] (03PS3) 10Chad: WIP: Remove less-than-useful API output formats [core] - 10https://gerrit.wikimedia.org/r/136490 [23:17:16] <^demon|away> Eh, we'll tack raw(fm) on too. [23:17:23] <^demon|away> So that leaves us with json, xml, yaml, php. [23:17:26] <^demon|away> Better. [23:18:02] (03PS4) 10Umherirrender: Use Database methods in RevisionDeleteUser::setUsernameBitfields [core] - 10https://gerrit.wikimedia.org/r/129954 [23:20:47] ^demon|away, I'm curious who's using php [23:20:57] hopefully not ourselves [23:21:13] <^demon|away> If someone around here is using that please let me know. [23:21:13] i'm trying to get the api to emit an xml tag containing text and other tags, and it doesn't seem to want to [23:21:22] <^demon|away> I'm going to the store to pick up some large trouts to slap them with :) [23:21:36] ;) [23:22:00] <^demon|away> I *do* know it's pretty widely used. I'm guessing by lazy programmers who just want to throw the result into unserialize() and be done with it. [23:22:18] <^demon|away> (Nevermind you can do the *exact* same thing with format=json and still one-line it with json_decode(), but meh) [23:22:34] jackmcbarn, you could modify the xml handler to serialize an array attribute value to JSON [23:22:35] any fun code injection things we can do to those people? [23:22:55] (03PS4) 10Umherirrender: Set autofocus on Special:Unblock [core] - 10https://gerrit.wikimedia.org/r/129944 [23:23:28] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (0f101c6f5d) [core] - 10https://gerrit.wikimedia.org/r/136494 [23:24:10] YuviPanda, that could be fun ;) [23:24:21] yeah [23:25:17] <^demon|away> csteipp and I are plotting evil injections now :p [23:25:23] IIRC PHP's json handling wasn't that great for a while [23:25:27] <^demon|away> Maybe some magic with a callalble + __wakeup()? [23:25:27] <^demon|away> :p [23:25:47] die() [23:25:50] (03PS5) 10Umherirrender: Fixes to Special:TrackingCategories [core] - 10https://gerrit.wikimedia.org/r/126950 [23:25:53] haha [23:26:33] <^demon|away> die() wouldn't work unless they're insane enough to pass the unserialized() result to eval(). [23:26:40] <^demon|away> You need some kind of object that has a __wakeup() [23:26:54] (03CR) 10Dduvall: Packaged plugin as gem to allow local installation (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/136441 (https://bugzilla.wikimedia.org/65066) (owner: 10Dduvall) [23:26:57] <^demon|away> Could be fun times. [23:27:16] 3MediaWiki / 3Logging: ManualLogEntry::setDeleted doesn't mark log deleted on insert - 10https://bugzilla.wikimedia.org/63650 (10Chris Steipp) 5PATC>3RESO/FIX [23:30:50] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.1.0-pre (0f101c6f5d) [core] - 10https://gerrit.wikimedia.org/r/136494 (owner: 10Catrope) [23:33:51] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (0f101c6f5d) [core] - 10https://gerrit.wikimedia.org/r/136494 (owner: 10Catrope) [23:34:33] ^demon|away, gwicke: With this library you could probably use the php serialization from javascript and then get rid of json. :) -- https://github.com/bd808/php-unserialize-js [23:35:54] bd808, but does it support __wakeup() ? [23:36:26] Damn it, now I have to write more js code ;) [23:36:26] "We couldn't find any code matching '__wakeup'" [23:36:44] ;) [23:36:51] <^demon|away> Awww, no fun php :( [23:37:04] <^demon|away> "Serialization of 'Closure' is not allowed" [23:37:25] bd808: and because I follow links, just found out Old Man Malarky is here right now. 5/30/2014 Petaluma, CA Mystic Theatre [23:37:38] Markley, shows I don't know 'em [23:37:41] greg-g: Go. You will love them [23:38:45] They are "new grass". Punk rockers who play bluegrass. Traditional melody with modern lyrics [23:39:19] brothers comatose played there on Wednesday I think [23:39:35] okay I am open to getting help on this one: MediaWiki API query to get a page's revision ID at a given timestamp? [23:39:37] seems to be the bluegrass place to be [23:40:06] bd808: I might need something like that.... all depends on the little guy [23:41:37] awight, afaik that's not supported directly [23:42:05] gwicke: I figured, but I'm like three workarounds deep already, so I am willing to compromise ;) [23:42:13] but if it turns out it is, then please let me know ;) [23:42:22] greg-g: Oh. Reverend Horton Heat is the headliner. Definitely a good show. [23:42:24] Revision history in a timestamp range would work, if I could find that API! [23:44:02] bd808: alright, good motivation to get these goals tidied up [23:46:30] awight, still looking for it? [23:46:33] Krenair: yah! [23:46:34] prop=revisions, rvstart and rvend for timestamp range [23:46:49] Krenair: thx, [23:47:22] I went completely api-blind after attempting to filter the logevents by translated page language... [23:48:17] (03CR) 10Reedy: [C: 04-1] "[00:37:48] PHP 5.4 short array syntax" (033 comments) [core/vendor] - 10https://gerrit.wikimedia.org/r/136475 (owner: 10BryanDavis) [23:49:02] Krenair: woohoo! works perfectly. [23:49:11] yay [23:49:18] * gwicke makes a note [23:51:05] * greg-g goes to look at more bands bd808 references in READMEs [23:52:22] (03CR) 10BryanDavis: Packaged plugin as gem to allow local installation (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/136441 (https://bugzilla.wikimedia.org/65066) (owner: 10Dduvall) [23:55:37] gwicke: i think i have a solution [23:55:39] how's https://dpaste.de/rOVv/raw look?