[00:01:30] (03PS2) 10Gergő Tisza: Allow media handlers to mark files as expensive [core] - 10https://gerrit.wikimedia.org/r/135701 (https://bugzilla.wikimedia.org/65691) [00:01:36] (03PS1) 10BryanDavis: Invalidate local configuration cache on sync [tools/scap] - 10https://gerrit.wikimedia.org/r/135724 (https://bugzilla.wikimedia.org/58618) [00:03:09] (03CR) 10Cicalese: "FYI, I have a patch to the SemanticTitle extension ready to go in the event that this patch is accepted: https://gerrit.wikimedia.org/r/#/" [core] - 10https://gerrit.wikimedia.org/r/124149 (https://bugzilla.wikimedia.org/63592) (owner: 10Cicalese) [00:03:44] legoktm: https://www.mediawiki.org/wiki/Manual:Hooks/LoadExtensionSchemaUpdates lists "To add a new table", "to modify a field" and "to add a new index" [00:03:49] what about adding a new column [00:03:58] to an already existing core table [00:04:11] (03PS2) 10Gergő Tisza: Add global limit to PoolCounter [core] - 10https://gerrit.wikimedia.org/r/135702 (https://bugzilla.wikimedia.org/65691) [00:04:53] "to modify a field" assumes the field already exists? [00:05:02] Withoutaname: modify a field is it I think. I would look at other extensions that have schema changes do [00:05:07] (03CR) 10Cicalese: "Correct URL to the other patch: https://gerrit.wikimedia.org/r/#/c/124148/" [core] - 10https://gerrit.wikimedia.org/r/124149 (https://bugzilla.wikimedia.org/63592) (owner: 10Cicalese) [00:09:25] (03PS4) 10Alex Monk: Fix search box tabindex again [core] - 10https://gerrit.wikimedia.org/r/135269 (https://bugzilla.wikimedia.org/29199) [00:09:41] 3Wikimedia / 3Extension setup: Review & deploy mediawiki/extensions/FundraisingChart - 10https://bugzilla.wikimedia.org/65834#c1 (10Sherah Smith) https://www.mediawiki.org/wiki/Extension:FundraisingChart [00:09:45] (03PS5) 10Alex Monk: Fix search box tabindex again [core] - 10https://gerrit.wikimedia.org/r/135269 (https://bugzilla.wikimedia.org/29199) [00:10:26] 3MediaWiki / 3Skin and page rendering: Tab index sorting doesn't make sense - 10https://bugzilla.wikimedia.org/29199#c36 (10Alex Monk) (In reply to Matthew Flaschen from comment #34) > why exactly is an explicit tabindex > needed here (I don't have OTRS access)? In Firefox and Chromium, it seems > that the... [00:19:11] 3MediaWiki / 3User blocking: MediaWiki:Autoblocker etc. reveals to third party that a (blocked) user has used the same IP address - 10https://bugzilla.wikimedia.org/53008#c42 (10Elvey) Jack: Whatever. We need to stop violating the privacy policy. From the policy: "we consider at least the following to be... [00:21:38] (03CR) 10Hoo man: [C: 032] Add missing possible errors to ApiRollback.php [core] - 10https://gerrit.wikimedia.org/r/134470 (owner: 10Umherirrender) [00:23:22] (03PS3) 10Gergő Tisza: Use separate PoolCounter config for expensive thumbnails [core] - 10https://gerrit.wikimedia.org/r/135703 (https://bugzilla.wikimedia.org/65691) [00:25:04] (03Merged) 10jenkins-bot: Add missing possible errors to ApiRollback.php [core] - 10https://gerrit.wikimedia.org/r/134470 (owner: 10Umherirrender) [00:28:03] https://www.mediawiki.org/wiki/Manual:Configuration_for_developers please make better :) [00:34:29] (03CR) 10Hoo man: [C: 031] "Untested" [core] - 10https://gerrit.wikimedia.org/r/131431 (https://bugzilla.wikimedia.org/52887) (owner: 10Withoutaname) [00:36:56] 3MediaWiki / 3User blocking: MediaWiki:Autoblocker etc. reveals to third party that a (blocked) user has used the same IP address - 10https://bugzilla.wikimedia.org/53008#c43 (10Jackmcbarn) Then what procedure should be followed to unblock a user who is autoblocked? [00:50:27] (03PS1) 10Gergő Tisza: Fix documentation formatting of multimedia-related roles [vagrant] - 10https://gerrit.wikimedia.org/r/135727 [00:50:39] (03CR) 10jenkins-bot: [V: 04-1] Fix documentation formatting of multimedia-related roles [vagrant] - 10https://gerrit.wikimedia.org/r/135727 (owner: 10Gergő Tisza) [00:50:50] (03PS2) 10Gergő Tisza: Fix documentation formatting of multimedia-related roles [vagrant] - 10https://gerrit.wikimedia.org/r/135727 [00:55:45] ^d: hmm, is there a way to force action=opensearch to use cirrus? I am wondering if I should just force the app to use cirrus all the time. [00:56:27] YuviPanda: &srbackend=CirrusSearch ? [00:56:41] or does that not work for opensearch? [00:56:54] legoktm: can't find on http://en.wikipedia.org/wiki/Special:ApiSandbox#action=mobileview&format=json&page=India&prop=protection [00:56:57] I don't think it does [00:57:20] :/ [01:01:33] (03CR) 10Ori.livneh: "The lines should be capped at 72 characters." [vagrant] - 10https://gerrit.wikimedia.org/r/135727 (owner: 10Gergő Tisza) [01:04:43] (03CR) 10Ori.livneh: [C: 031] "See comment. Happy to merge, if you like." (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/135724 (https://bugzilla.wikimedia.org/58618) (owner: 10BryanDavis) [01:06:52] (03CR) 10Ori.livneh: [C: 04-1] "Actually, why *are* you lazy-initialising these?" [tools/scap] - 10https://gerrit.wikimedia.org/r/135617 (owner: 10BryanDavis) [01:08:53] (03CR) 10Gergő Tisza: "Anything that involves URLs will exceed line length limits occasionally." [vagrant] - 10https://gerrit.wikimedia.org/r/135727 (owner: 10Gergő Tisza) [01:38:39] (03PS1) 10Yuvipanda: Display locked pencil icon if page is protected [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/135728 [01:38:45] legoktm: around to merge trivial ^? [01:39:06] no svg? :( [01:39:17] legoktm: not for this one, no. 'tis from the times before [01:39:25] i'll pester the designers for it [01:39:29] stolen from MF [01:39:34] (03CR) 10Legoktm: [C: 032 V: 032] Display locked pencil icon if page is protected [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/135728 (owner: 10Yuvipanda) [01:39:41] legoktm: ty [01:41:23] YuviPanda: https://bugzilla.wikimedia.org/show_bug.cgi?id=65841 [01:41:56] cool. should do at some point, I have poked at jenkins job thingies before [01:43:56] I have 2 of hashar's commits bookmarked for when he did it for another repo and just do the same thing [01:51:51] (03PS11) 10Werdna: Replace occupation w/ ContentHandler integration. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/131043 [01:52:35] (03CR) 10jenkins-bot: [V: 04-1] Replace occupation w/ ContentHandler integration. [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/131043 (owner: 10Werdna) [02:07:50] (03CR) 10Withoutaname: "I don't understand what the problem was in the first implementation, when addField + user_password_expires was moved to be embedded into d" [core] - 10https://gerrit.wikimedia.org/r/133411 (https://bugzilla.wikimedia.org/63677) (owner: 10Withoutaname) [02:10:48] (03PS9) 10Ori.livneh: Add Composer managed libraries [core] - 10https://gerrit.wikimedia.org/r/119939 (owner: 10BryanDavis) [02:11:06] (03CR) 10Ori.livneh: [C: 032] "Remember to add release notes for this in a followup" [core] - 10https://gerrit.wikimedia.org/r/119939 (owner: 10BryanDavis) [02:15:31] (03Merged) 10jenkins-bot: Add Composer managed libraries [core] - 10https://gerrit.wikimedia.org/r/119939 (owner: 10BryanDavis) [02:19:03] (03CR) 10Ori.livneh: "How do you write libs with logging calls? Is the idea that you pass a logger to the constructor? Could you perhaps add logging to one of t" [core] - 10https://gerrit.wikimedia.org/r/119940 (owner: 10BryanDavis) [02:22:57] 3MediaWiki / 3User preferences: Change MediaWiki core user preferences layout - 10https://bugzilla.wikimedia.org/63583#c4 (10Isarra) (In reply to MZMcBride from comment #0) > Rather than having tabs at [[mw:Special:Preferences]], we should switch to > collapsible, stacked sections. Each section will have an... [02:23:26] 3MediaWiki / 3Installer: Install hangs on 'Setting up database..' with php errors (due to permissions issue) - 10https://bugzilla.wikimedia.org/61092#c8 (10Jeff Janes) What is the permission problem? File system or database? Can anyone reproduce it without injecting an error through artificial means? Now... [02:29:30] (03CR) 10Isarra: "That doesn't actually work - you still have to specify User:User instead of just User. But the thing is, it's the target weirdness which s" [core] - 10https://gerrit.wikimedia.org/r/135186 (https://bugzilla.wikimedia.org/46494) (owner: 10devunt) [02:34:41] 3MediaWiki / 3Logging: Special:Log target input should do what it says on the tin - 10https://bugzilla.wikimedia.org/46494#c2 (10Isarra) I got this backwards. The thing that really should be fixed is that you have to enter 'User:Username' for the target for user targeting logs (block, user rights, etc); 'Use... [02:34:59] (03PS3) 10Springle: Reduce Title::invalidateCache contention a bit [core] - 10https://gerrit.wikimedia.org/r/135601 (owner: 10Aaron Schulz) [02:35:11] 3MediaWiki / 3Special pages: When Special:WhatLinksHere is included and a valid title not provided, a form is shown - 10https://bugzilla.wikimedia.org/65779#c4 (10MZMcBride) (In reply to Jackmcbarn from comment #3) > With the form, {{Special:WhatLinksHere}} is a somewhat useful construct. > Without it, it wo... [02:40:21] (03CR) 10Springle: [C: 032] Reduce Title::invalidateCache contention a bit [core] - 10https://gerrit.wikimedia.org/r/135601 (owner: 10Aaron Schulz) [03:03:06] (03CR) 10devunt: "User name can be same as Article name..." [core] - 10https://gerrit.wikimedia.org/r/135186 (https://bugzilla.wikimedia.org/46494) (owner: 10devunt) [03:08:07] (03CR) 10Isarra: "Logs that apply specifically to users won't be applying to articles, though, will they? You won't look at the block log for Article:Cat, o" [core] - 10https://gerrit.wikimedia.org/r/135186 (https://bugzilla.wikimedia.org/46494) (owner: 10devunt) [03:42:18] (03CR) 10BryanDavis: "Because at the time of object creation the environment isn't completely created. scap.cli.Application._load_config() and scap.cli.Applicat" [tools/scap] - 10https://gerrit.wikimedia.org/r/135617 (owner: 10BryanDavis) [03:43:31] (03PS6) 10Ori.livneh: Fix search box tabindex again [core] - 10https://gerrit.wikimedia.org/r/135269 (https://bugzilla.wikimedia.org/29199) (owner: 10Alex Monk) [03:45:51] (03CR) 10Santhosh: [C: 032] Update README for individual test run [services/cxserver] - 10https://gerrit.wikimedia.org/r/135523 (owner: 10KartikMistry) [03:58:28] 3MediaWiki-Vagrant: Add sqlite role for vagrant - 10https://bugzilla.wikimedia.org/65843 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3Ori Livneh It would be nice if there was a sqlite role in vagrant to test sqlite issues. [04:00:56] 3MediaWiki / 3Logging: Special:Log target input should do what it says on the tin - 10https://bugzilla.wikimedia.org/46494#c3 (10Kunal Mehta (Legoktm)) Doesn't it already do that for https://github.com/wikimedia/mediawiki-core/blob/master/includes/specials/SpecialLog.php#L32 ? (There's also a hook later on f... [04:14:54] (03PS1) 10Mwalker: Updating configuration to point to absolute puppet paths [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/135737 [04:16:32] (03CR) 10Mwalker: [C: 032 V: 032] Updating configuration to point to absolute puppet paths [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/135737 (owner: 10Mwalker) [04:19:11] 3MediaWiki-Vagrant: Add sqlite role for vagrant - 10https://bugzilla.wikimedia.org/65843#c1 (10Kunal Mehta (Legoktm)) p:5Unprio>3Low Setting low priority, it took me about 5 minutes to do it manually after reading [[mw:Manual:SQLite]]. # apt-get install php5-sqlite # service apache2 restart $ mv /vagrant/... [04:30:41] 3MediaWiki / 3Logging: Special:Log target input should do what it says on the tin - 10https://bugzilla.wikimedia.org/46494#c4 (10Isarra) 5PAT>3RES/FIX Yeah, looks like it does work now (tested on mw.org), so nevermind! Whee! [04:47:58] 3Wikimedia / 3Git/Gerrit: Gerrit does not show size differences for binaries - 10https://bugzilla.wikimedia.org/65844 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None This will have to be reported upstream. Gerrit does not accurately show size differences for binary changes, such as https://ger... [04:50:59] (03PS6) 10Legoktm: Updater: Create user_password_expires before doMigrateUserOptions [core] - 10https://gerrit.wikimedia.org/r/133411 (https://bugzilla.wikimedia.org/63677) (owner: 10Withoutaname) [04:54:40] (03CR) 10jenkins-bot: [V: 04-1] Updater: Create user_password_expires before doMigrateUserOptions [core] - 10https://gerrit.wikimedia.org/r/133411 (https://bugzilla.wikimedia.org/63677) (owner: 10Withoutaname) [04:57:40] legoktm: Hi! you around ? [04:57:48] hi [04:58:28] great! Now, only this test fails -- hope you would've seen it :- https://integration.wikimedia.org/ci/job/mediawiki-core-phpunit-api/25616/console [04:59:22] (03PS5) 10Umherirrender: Add error 'pagecannotexist' to ApiBase::getTitleOrPageIdErrorMessage [core] - 10https://gerrit.wikimedia.org/r/134469 [04:59:36] I think we need jenkins to run composer before running the tests [05:00:36] legoktm: yeah !! hope that gets fixed soon [05:01:08] I'll file a bug for it in a few minutes [05:01:35] legoktm: thanks :) [05:02:51] (03CR) 10GWicke: "> I see use cases for this beyond Cite, which are fully compatible with Parsoid's goals, such as extensions that expose random number gene" [core] - 10https://gerrit.wikimedia.org/r/99792 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [05:04:09] (03PS1) 10Hiong3-eng5: Special Popup [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/135740 [05:04:13] (03CR) 10jenkins-bot: [V: 04-1] Special Popup [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/135740 (owner: 10Hiong3-eng5) [05:15:58] 3MediaWiki / 3Special pages: When Special:WhatLinksHere is included and a valid title not provided, a form is shown - 10https://bugzilla.wikimedia.org/65779#c5 (10Florian) In my opinion it's the right and best behavior. An error message doesn't help the user really much. With an input form, he can use the fo... [05:24:41] 3MediaWiki / 3Special pages: When Special:WhatLinksHere is included and a valid title not provided, a form is shown - 10https://bugzilla.wikimedia.org/65779#c6 (10MZMcBride) (In reply to MZMcBride from comment #4) > I think I've been conflating {{Special:WhatLinksHere}} (no input), > {{Special:WhatLinksHere/... [05:26:31] (03PS1) 10Santhosh: Return early when parsoid response is failure [services/cxserver] - 10https://gerrit.wikimedia.org/r/135742 [05:43:48] gwicke: thanks for commenting on that interesting one :) [05:50:01] (03CR) 10Ori.livneh: "> Because at the time of object creation the environment isn't completely created." [tools/scap] - 10https://gerrit.wikimedia.org/r/135617 (owner: 10BryanDavis) [05:55:13] 3MediaWiki extensions / 3Popups: Hovercards: Fix the length of the extract - 10https://bugzilla.wikimedia.org/65845 (10Prateek Saxena) 3NEW p:3Unprio s:3enhanc a:3None Right now the text of the excerpt gets clipped by the div without any ellipses. We need to figure out a way to reliably fill up the s... [05:57:49] (03PS4) 10Deepali: Efficient navigation through sections [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/134627 (https://bugzilla.wikimedia.org/52435) [05:57:54] (03CR) 10jenkins-bot: [V: 04-1] Efficient navigation through sections [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/134627 (https://bugzilla.wikimedia.org/52435) (owner: 10Deepali) [06:02:40] (03PS5) 10Deepali: Efficient navigation through sections [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/134627 (https://bugzilla.wikimedia.org/52435) [06:02:57] (03PS2) 10Physikerwelt: Add separate database table for LaTeXML (step 4) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135693 [06:06:55] (03CR) 10Physikerwelt: Add separate database table for LaTeXML (step 4) (032 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135693 (owner: 10Physikerwelt) [06:07:55] (03PS3) 10Physikerwelt: Add separate database table for LaTeXML (step 4) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135693 [06:14:11] 3MediaWiki / 3Parser: HHVM segfaults when calling Parser->callParserFunction - 10https://bugzilla.wikimedia.org/65796#c2 (10Tim Starling) This is mostly a LuaSandbox bug. LuaSandbox::setCPULimit() calls convert_to_double_ex() on its argument, which decrefs the original zval and creates a new one that is a d... [06:38:56] 3MediaWiki extensions / 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - 10https://bugzilla.wikimedia.org/35342#c22 (10PRO) Created attachment 15497 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15497&action=edit button-sprite.svg fixed I've optimized the button-sprite and also... [06:45:26] 3MediaWiki extensions / 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - 10https://bugzilla.wikimedia.org/35342#c23 (10PRO) Comment on attachment 15497 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15497 button-sprite.svg fixed All GaussianBlur filter are still present although... [07:03:10] (03PS2) 10Springle: Tweaked HTMLCacheUpdate immediate run treshold [core] - 10https://gerrit.wikimedia.org/r/135593 (owner: 10Aaron Schulz) [07:18:56] 3MediaWiki / 3User blocking: MediaWiki:Autoblocker etc. reveals to third party that a (blocked) user has used the same IP address - 10https://bugzilla.wikimedia.org/53008#c44 (10Nemo) (In reply to Jackmcbarn from comment #43) > Then what procedure should be followed to unblock a user who is autoblocked? Aut... [07:19:32] (03CR) 10Gilles: Check $wgMaxImageArea before downloading file asset from swift (031 comment) [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135101 (https://bugzilla.wikimedia.org/62306) (owner: 10Brian Wolff) [07:19:56] (03CR) 10Springle: [C: 032] Tweaked HTMLCacheUpdate immediate run treshold [core] - 10https://gerrit.wikimedia.org/r/135593 (owner: 10Aaron Schulz) [07:50:09] (03CR) 10Mwjames: "@MarkAHershberger I really would mind to have this fixed with 1.23" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/134590 (https://bugzilla.wikimedia.org/65530) (owner: 10Mwjames) [07:51:29] (03CR) 10Frédéric Wang: Add separate database table for LaTeXML (step 4) (032 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135693 (owner: 10Physikerwelt) [07:57:29] (03CR) 10Rillke: [C: 04-1] "needs check whether named constraint exists; otherwise updater won't work on setups having this patch merged in from the beginning on" [core] - 10https://gerrit.wikimedia.org/r/135714 (https://bugzilla.wikimedia.org/65757) (owner: 10Rillke) [08:00:52] (03PS6) 10Deepali: Efficient navigation through sections [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/134627 (https://bugzilla.wikimedia.org/52435) [08:00:56] (03CR) 10jenkins-bot: [V: 04-1] Efficient navigation through sections [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/134627 (https://bugzilla.wikimedia.org/52435) (owner: 10Deepali) [08:04:38] (03CR) 10Gilles: [C: 04-1] Added Range support to FileBackend::streamFile() (034 comments) [core] - 10https://gerrit.wikimedia.org/r/127466 (owner: 10Aaron Schulz) [08:07:44] (03PS6) 10Rillke: Name implicitly created CHECK constraints [core] - 10https://gerrit.wikimedia.org/r/135714 (https://bugzilla.wikimedia.org/65757) [08:09:19] (03PS3) 10Spage: Use Mantle to load front-end handlebars resources [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/131085 [08:09:45] (03CR) 10jenkins-bot: [V: 04-1] Use Mantle to load front-end handlebars resources [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/131085 (owner: 10Spage) [08:10:03] (03CR) 10Gilles: [C: 04-1] Add global limit to PoolCounter (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135702 (https://bugzilla.wikimedia.org/65691) (owner: 10Gergő Tisza) [08:12:58] (03PS7) 10Rillke: Name implicitly created CHECK constraints [core] - 10https://gerrit.wikimedia.org/r/135714 (https://bugzilla.wikimedia.org/65757) [08:16:16] (03CR) 10Gilles: [C: 04-1] Allow media handlers to mark files as expensive (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135701 (https://bugzilla.wikimedia.org/65691) (owner: 10Gergő Tisza) [08:22:08] (03PS4) 10Physikerwelt: Add separate database table for LaTeXML (step 4) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135693 [08:23:05] (03CR) 10jenkins-bot: [V: 04-1] Add separate database table for LaTeXML (step 4) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135693 (owner: 10Physikerwelt) [08:29:02] (03PS4) 10Adamw: WIP payments.wmo instance for accepting donations [vagrant] - 10https://gerrit.wikimedia.org/r/135326 [08:29:06] (03CR) 10jenkins-bot: [V: 04-1] WIP payments.wmo instance for accepting donations [vagrant] - 10https://gerrit.wikimedia.org/r/135326 (owner: 10Adamw) [09:05:20] (03PS7) 10Deepali: Efficient navigation through sections [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/134627 (https://bugzilla.wikimedia.org/52435) [09:05:37] (03PS10) 10Nuria: Move event serialization to separate method and add tests [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/133668 (owner: 10Ori.livneh) [09:06:27] (03CR) 10Nuria: Move event serialization to separate method and add tests (033 comments) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/133668 (owner: 10Ori.livneh) [09:06:45] (03PS5) 10Physikerwelt: Add separate database table for LaTeXML (step 4) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135693 (https://bugzilla.wikimedia.org/65522) [09:07:11] (03PS11) 10Nuria: Move event serialization to separate method and add tests [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/133668 (owner: 10Ori.livneh) [09:08:48] (03PS2) 10Santhosh: Return early when parsoid response is failure [services/cxserver] - 10https://gerrit.wikimedia.org/r/135742 [09:12:24] Is there anyone who can confirm a message to mediawiki-announce-l? Reedy? [09:14:42] (03PS12) 10Gilles: [WIP] Generate thumbnails based on buckets [core] - 10https://gerrit.wikimedia.org/r/135008 [09:23:01] (03PS13) 10Gilles: Generate thumbnails based on buckets [core] - 10https://gerrit.wikimedia.org/r/135008 [09:28:37] (03CR) 10Santhosh: [C: 04-1] LinearDoc: Flattened representation of Inline HTML (032 comments) [services/cxserver] - 10https://gerrit.wikimedia.org/r/124287 (owner: 10Divec) [09:43:41] 3Wikimedia / 3Wikidata: Rollback does not work on items - 10https://bugzilla.wikimedia.org/65831#c4 (10Daniel Kinzler) It seems like WikiPage::commitRollback() calls WikiPage::doEditContent() with $baseRevId set to the ID of the revision to be rolled back to, instead of the current revision before the rollba... [09:48:45] (03PS2) 10Adamw: Fundraising CRM instance [vagrant] - 10https://gerrit.wikimedia.org/r/135322 [09:48:47] (03CR) 10jenkins-bot: [V: 04-1] Fundraising CRM instance [vagrant] - 10https://gerrit.wikimedia.org/r/135322 (owner: 10Adamw) [09:49:18] (03PS3) 10Adamw: Fundraising CRM instance [vagrant] - 10https://gerrit.wikimedia.org/r/135322 [09:49:41] (03PS2) 10Adamw: Supporting libraries for Fundraising outbound email [vagrant] - 10https://gerrit.wikimedia.org/r/135323 [09:51:07] (03PS2) 10Adamw: STOMP queue server for Fundraising [vagrant] - 10https://gerrit.wikimedia.org/r/135324 [09:58:42] (03PS1) 10UltrasonicNXT: Fix error on deleting threads [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/135754 [09:59:21] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Fix error on deleting threads [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/135754 (owner: 10UltrasonicNXT) [10:13:14] 3MediaWiki extensions / 3WikidataRepo: wbeditentity: try to use appropriate autocomment instead of the generic one - 10https://bugzilla.wikimedia.org/65846 (10Ricordisamoa) 3NEW p:3Unprio s:3enhanc a:3Wikidata bugs When changing an item's content with the wbeditentity API, the extension always uses '... [10:16:00] (03CR) 10Daniel Kinzler: Correctly parse 'redirect' XML tag during Special:Import. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/134079 (https://bugzilla.wikimedia.org/65481) (owner: 10Nik) [10:19:21] (03PS8) 10Rillke: Name implicitly created CHECK constraints [core] - 10https://gerrit.wikimedia.org/r/135714 (https://bugzilla.wikimedia.org/65757) [10:30:51] (03CR) 10Frédéric Wang: [C: 032] Add separate database table for LaTeXML (step 4) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135693 (https://bugzilla.wikimedia.org/65522) (owner: 10Physikerwelt) [10:33:37] (03PS11) 10Divec: LinearDoc: Flattened representation of Inline HTML [services/cxserver] - 10https://gerrit.wikimedia.org/r/124287 [10:36:01] (03PS9) 10Rillke: Name implicitly created CHECK constraints [core] - 10https://gerrit.wikimedia.org/r/135714 (https://bugzilla.wikimedia.org/65757) [10:38:41] (03PS1) 10Rillke: Add "chemical" major MIME type to the image tables [core] - 10https://gerrit.wikimedia.org/r/135756 [10:41:14] 3MediaWiki extensions / 3WikidataRepo: not possible to switch to Julian calendar model - 10https://bugzilla.wikimedia.org/65847 (10Lydia Pintscher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs We broke switching calendar model it seems. One example is the date of birth in https://www.wikidata.org/wiki/Q... [10:41:56] 3MediaWiki extensions / 3WikidataRepo: not possible to switch to Julian calendar model - 10https://bugzilla.wikimedia.org/65847 (10Lydia Pintscher) [10:41:56] 3MediaWiki extensions / 3WikidataRepo: not possible to switch to Julian calendar model - 10https://bugzilla.wikimedia.org/65847 (10Lydia Pintscher) p:5Unprio>3High [10:48:58] (03PS2) 10Rillke: Add "chemical" major MIME type to the image tables [core] - 10https://gerrit.wikimedia.org/r/135756 [10:51:12] (03PS3) 10Rillke: Add "chemical" major MIME type to the image tables [core] - 10https://gerrit.wikimedia.org/r/135756 [11:02:19] (03CR) 10Santhosh: [C: 032] LinearDoc: Flattened representation of Inline HTML [services/cxserver] - 10https://gerrit.wikimedia.org/r/124287 (owner: 10Divec) [11:03:07] (03CR) 10Santhosh: "try again" [services/cxserver] - 10https://gerrit.wikimedia.org/r/135523 (owner: 10KartikMistry) [11:09:08] (03PS2) 10KartikMistry: Update README.md for individual test run [services/cxserver] - 10https://gerrit.wikimedia.org/r/135523 [11:09:34] (03CR) 10KartikMistry: [C: 032] "Trying again to merge." [services/cxserver] - 10https://gerrit.wikimedia.org/r/135523 (owner: 10KartikMistry) [11:22:00] (03PS5) 10Phuedx: Make ResourceLoaderFileModule#getAllStyleFiles include all skin styles [core] - 10https://gerrit.wikimedia.org/r/122838 (https://bugzilla.wikimedia.org/63343) [11:22:11] (03CR) 10Phuedx: Make ResourceLoaderFileModule#getAllStyleFiles include all skin styles (032 comments) [core] - 10https://gerrit.wikimedia.org/r/122838 (https://bugzilla.wikimedia.org/63343) (owner: 10Phuedx) [11:34:11] 3Wikimedia / 3Wikidata: Rollback does not work on items - 10https://bugzilla.wikimedia.org/65831#c5 (10Daniel Kinzler) I wrote some more details to the list: http://lists.wikimedia.org/pipermail/wikitech-l/2014-May/076712.html [11:44:50] (03PS2) 10Prtksxna: animation: Add fade animations from other directions [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135552 [11:44:52] (03PS2) 10Prtksxna: Flip the animation direction if the Hovercard is flipped [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135554 [11:44:54] (03PS2) 10Prtksxna: animation: Correctly name the animation classes [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135549 [11:46:55] (03CR) 10TheDJ: [C: 031] Fix search box tabindex again [core] - 10https://gerrit.wikimedia.org/r/135269 (https://bugzilla.wikimedia.org/29199) (owner: 10Alex Monk) [11:47:58] 3MediaWiki extensions / 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - 10https://bugzilla.wikimedia.org/35342#c24 (10Derk-Jan Hartman) a:3Derk-Jan Hartman Thank you PRO, i'll get on this in the next week. [12:04:57] (03PS1) 10Prtksxna: render.article: Remove brackets using code instead of RegExp [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135759 (https://bugzilla.wikimedia.org/65138) [12:05:02] (03CR) 10jenkins-bot: [V: 04-1] render.article: Remove brackets using code instead of RegExp [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135759 (https://bugzilla.wikimedia.org/65138) (owner: 10Prtksxna) [12:07:12] (03PS2) 10Prtksxna: render.article: Remove brackets using code instead of RegExp [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135759 (https://bugzilla.wikimedia.org/65138) [12:15:27] 3MediaWiki extensions / 3WikidataClient: Full support for wikibase edits in enhanced changes format ("Group changes by page in recent changes and watchlist" [usenewrc]) - 10https://bugzilla.wikimedia.org/44874#c8 (10Sergey Vladimirov) (Up) [12:34:27] 3Wikimedia / 3Extension setup: Extensions awaiting code review to be deployed on Wikimedia wikis (tracking) - 10https://bugzilla.wikimedia.org/31235 (10Peter Coombe) [12:34:29] 3Wikimedia / 3Extension setup: Review and deploy Petition extension to wikimediafoundation.org - 10https://bugzilla.wikimedia.org/65849 (10Peter Coombe) 3NEW p:3Unprio s:3normal a:3None This extension will be used for a petition to encourage mobile operators to join Wikipedia Zero. It only needs to b... [12:34:43] (03PS4) 10Krinkle: Follow-up I7b49a6dd0: Fix page curation bar reappearing after VE closes [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/135587 (https://bugzilla.wikimedia.org/65702) (owner: 10Alex Monk) [12:35:52] (03Abandoned) 10Krinkle: [WIP] recentchanges: Implement support for pagesets [core] - 10https://gerrit.wikimedia.org/r/92654 (https://bugzilla.wikimedia.org/55377) (owner: 10Krinkle) [12:36:59] 3MediaWiki extensions / 3Petition: Security review of Petition extension before WMF deployment - 10https://bugzilla.wikimedia.org/65850 (10Peter Coombe) 3NEW p:3Unprio s:3normal a:3None https://www.mediawiki.org/wiki/Extension:Petition [12:37:26] 3Wikimedia / 3Extension setup: Review and deploy Petition extension to wikimediafoundation.org - 10https://bugzilla.wikimedia.org/65849 (10Peter Coombe) [12:37:27] 3MediaWiki extensions / 3Petition: Security review of Petition extension before WMF deployment - 10https://bugzilla.wikimedia.org/65850 (10Peter Coombe) [12:37:41] 3MediaWiki extensions / 3WikidataRepo: wbeditentity: try to use appropriate autocomment instead of the generic one - 10https://bugzilla.wikimedia.org/65846#c1 (10Lydia Pintscher) Guys: Can you say something about how hard/time-consuming this is to do? [12:38:41] (03PS1) 10Matthias Mullie: (bug 65805) Fix notice when creating new filter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/135761 (https://bugzilla.wikimedia.org/65805) [12:38:46] (03PS1) 10Matthias Mullie: (bug 65807) Fix for tinyint(1)'s not accepting '' [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/135762 (https://bugzilla.wikimedia.org/65807) [12:39:11] 3Wikimedia / 3Extension setup: Review and deploy Petition extension to wikimediafoundation.org - 10https://bugzilla.wikimedia.org/65849 (10Peter Coombe) [12:39:13] 3MediaWiki extensions / 3Petition: Performance review of Petition extension before WMF deployment - 10https://bugzilla.wikimedia.org/65851 (10Peter Coombe) 3NEW p:3Unprio s:3normal a:3None https://www.mediawiki.org/wiki/Extension:Petition Note that this only needs to be deployed on https://wikimedia... [12:40:17] (03PS7) 10Krinkle: vector: Add tabindex back to search box [core] - 10https://gerrit.wikimedia.org/r/135269 (https://bugzilla.wikimedia.org/29199) (owner: 10Alex Monk) [12:40:29] (03CR) 10Krinkle: [C: 031] vector: Add tabindex back to search box [core] - 10https://gerrit.wikimedia.org/r/135269 (https://bugzilla.wikimedia.org/29199) (owner: 10Alex Monk) [12:43:56] 3Wikimedia / 3Wikidata: Rollback does not work on items - 10https://bugzilla.wikimedia.org/65831#c9 (10John F. Lewis) 5PAT>3NEW Patch merged. Resetting back to open per Daniel's comment about putting this in one of the next sprints. [12:44:00] (03CR) 10Krinkle: "Aren't most of these proper ints to begin with? I'm not too familiar with this code (both this commit and I45ad0ea2cea2427's commit messag" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/135762 (https://bugzilla.wikimedia.org/65807) (owner: 10Matthias Mullie) [12:48:27] 3MediaWiki / 3Skin and page rendering: Messages needing PLURAL support (tracking) - 10https://bugzilla.wikimedia.org/38781 (10Andre Klapper) [12:48:41] 3MediaWiki / 3Maintenance scripts: populateRevisionLength.php displays "Content of archive unavailable" error when updating ar_len field with text stored in archive table - 10https://bugzilla.wikimedia.org/65765 (10Andre Klapper) [12:55:56] 3MediaWiki extensions / 3WikiEditor: The help section should include a link to more help, ie. Help:Contents by default - 10https://bugzilla.wikimedia.org/65797#c1 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc > The help section How to find "the help section" (to make sure we talk about the s... [12:58:56] 3MediaWiki extensions / 3WikidataClient: Full support for wikibase edits in enhanced changes format ("Group changes by page in recent changes and watchlist" [usenewrc]) - 10https://bugzilla.wikimedia.org/44874#c9 (10Andre Klapper) Sergey: If you have a specific question or a technical comment to make, please... [12:59:43] 3MediaWiki extensions / 3Petition: Security review of Petition extension before WMF deployment - 10https://bugzilla.wikimedia.org/65850 (10Andre Klapper) a:3Chris Steipp [13:00:11] 3Wikimedia / 3Extension setup: Review and deploy Petition extension to wikimediafoundation.org - 10https://bugzilla.wikimedia.org/65849 (10Andre Klapper) p:5Unprio>3High [13:00:27] 3MediaWiki extensions / 3Petition: Security review of Petition extension before WMF deployment - 10https://bugzilla.wikimedia.org/65850 (10Andre Klapper) p:5Unprio>3High [13:00:41] 3MediaWiki extensions / 3AbuseFilter: Incorrect integer value: '' for column 'af_hidden' - 10https://bugzilla.wikimedia.org/65807 (10Andre Klapper) p:5Unprio>3Normal [13:00:41] 3MediaWiki extensions / 3Petition: Performance review of Petition extension before WMF deployment - 10https://bugzilla.wikimedia.org/65851 (10Andre Klapper) p:5Unprio>3High [13:00:56] 3MediaWiki extensions / 3AbuseFilter: notice when creating new filter - 10https://bugzilla.wikimedia.org/65805 (10Andre Klapper) p:5Unprio>3Normal [13:02:56] 3Wikimedia / 3Git/Gerrit: Gerrit does not show size differences for binaries - 10https://bugzilla.wikimedia.org/65844 (10Andre Klapper) s:5normal>3enhanc [13:06:30] (03CR) 10Nikerabbit: [C: 032] "Makes sense." [services/cxserver] - 10https://gerrit.wikimedia.org/r/135742 (owner: 10Santhosh) [13:12:41] 3Wikimedia / 3Site requests: New England Wikimedians website - 10https://bugzilla.wikimedia.org/64557#c52 (10Pharos) Maybe the best solution would just be newengland.wikimedia.org ? They isn't really a standard official abbreviation for this region anyway, but the actual name is short enough itself. [13:17:14] 3MediaWiki extensions / 3ExtensionDistributor: Empty version dropdown - 10https://bugzilla.wikimedia.org/65852 (10Nemo) 3NEW p:3Unprio s:3major a:3None Since a few days, there are reports of the version dropdown being empty even though the branches exist. This makes it impossible to download extensio... [13:19:26] 3MediaWiki / 3Parser: HHVM segfaults when calling Parser->callParserFunction - 10https://bugzilla.wikimedia.org/65796#c3 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3major (In reply to Tim Starling from comment #2) > This is mostly a LuaSandbox bug. CC'ing anomie [13:19:56] 3MediaWiki / 3Installer: MSSQL installer broken; updateRowExists returns always false - 10https://bugzilla.wikimedia.org/65813#c4 (10Andre Klapper) p:5Unprio>3High Wondering if this only affects 1.24/git master or also 1.23 stable (which might be worth to backport then)? [13:20:11] 3MediaWiki / 3Special pages: "Power search" form on Special:Search is ugly - 10https://bugzilla.wikimedia.org/65833 (10Andre Klapper) p:5Unprio>3Normal [13:21:26] 3MediaWiki extensions / 3ExtensionDistributor: Empty version dropdown - 10https://bugzilla.wikimedia.org/65852#c1 (10Florian) 5NEW>3UNC -> https://www.mediawiki.org/wiki/Special:ExtensionDistributor/CirrusSearch I see a master and 1.22 branch :/ -> https://www.mediawiki.org/wiki/Special:ExtensionDistrib... [13:22:26] 3MediaWiki extensions / 3ExtensionDistributor: Empty version dropdown - 10https://bugzilla.wikimedia.org/65852#c2 (10Sam Reed (reedy)) I see 1.22 and master for CirrusSearch. Giving me https://codeload.github.com/wikimedia/mediawiki-extensions-CirrusSearch/legacy.tar.gz/REL1_22 to download There is no 1.23,... [13:25:13] 3Wikimedia / 3Site requests: New England Wikimedians website - 10https://bugzilla.wikimedia.org/64557#c53 (10Nemo) (In reply to Pharos from comment #52) > Maybe the best solution would just be newengland.wikimedia.org ? No please. USA chapters certainly must use "country/state codes" or equivalent and exist... [13:25:13] 3MediaWiki / 3Parser: HHVM: Array to string conversion in Parser.php - 10https://bugzilla.wikimedia.org/65830 (10Andre Klapper) p:5Unprio>3Normal [13:25:13] 3MediaWiki extensions / 3Translate: Recursive parser calls - 10https://bugzilla.wikimedia.org/65826#c1 (10Andre Klapper) (Information how often this happens welcome for judging how urgent it is to fix) [13:26:11] 3MediaWiki extensions / 3OATHAuth: Database tables not created on Postgres: ERROR: relation "oathauth_users" does not exist - 10https://bugzilla.wikimedia.org/65658 (10Andre Klapper) p:5Unprio>3Normal [13:30:13] 3Wikimedia / 3Site requests: New England Wikimedians website - 10https://bugzilla.wikimedia.org/64557#c54 (10John F. Lewis) (In reply to Nemo from comment #53) > (In reply to Pharos from comment #52) > > Maybe the best solution would just be newengland.wikimedia.org ? > > No please. USA chapters certainly m... [13:32:56] 3MediaWiki extensions / 3ExtensionDistributor: Empty version dropdown - 10https://bugzilla.wikimedia.org/65852#c3 (10Nemo) https://www.mediawiki.org/wiki/Special:ExtensionDistributor/MaintenanceShell (original report) does have empty dropdown for me, how common is this? How are they picked? [13:34:26] 3Wikimedia / 3Site requests: New England Wikimedians website - 10https://bugzilla.wikimedia.org/64557#c55 (10Pharos) OK, if AffCom is for us-ne, that's good enough for me. Don't want to drag this out unnecessarily. [13:37:10] (03PS1) 10Reedy: Add message for REL1_23 for extdist [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/135765 [13:46:28] 3MediaWiki / 3Skin and page rendering: div.vectorTabs li.icon a.loading shows a flashing box when focused in Firefox - 10https://bugzilla.wikimedia.org/65853 (10Liangent) 3NEW p:3Unprio s:3normal a:3None This is talking about the "Watch" button (tab) in Vector when a page is being watched (AJAX waiti... [13:55:26] 3MediaWiki / 3Skin and page rendering: div.vectorTabs li.icon a.loading shows a flashing box when focused in Firefox - 10https://bugzilla.wikimedia.org/65853#c1 (10Florian) Tested with FF 17.0.1 ESR, it's ugly (sorry for wording). In Chrome it's a smooth and beautiful spin :) [13:55:57] 3Wikimedia / 3Bugzilla: bugzilla emails do not get delivered to mailing list - 10https://bugzilla.wikimedia.org/65828#c5 (10Andre Klapper) 5NEW>3ASS p:5Unprio>3Highes a:3Andre Klapper Urgh. I am very sorry. :( The "Bugmail disabled" field was set for some reason (probably Bugzilla trying to be smar... [13:56:26] 3Wikimedia / 3Bugzilla: bugzilla emails do not get delivered to mailing list - 10https://bugzilla.wikimedia.org/65828#c6 (10Andre Klapper) 5ASS>3RES/FIX Seems to work? Last comment showed: Email sent to: ..., Pywikipedia-bugs@lists.wikimedia.org, ... [13:58:27] 3Wikimedia / 3Deployment systems: Manage mediawiki-config/php symlink automatically - 10https://bugzilla.wikimedia.org/64748 (10Andre Klapper) [13:58:27] 3Wikimedia / 3Deployment systems: Either undo php->php-1.xx symlink messiness, or automate archiving of old MediaWiki versions - 10https://bugzilla.wikimedia.org/36363 (10Andre Klapper) [13:59:57] 3MediaWiki extensions / 3Scribunto: LuaSandbox segfaults under HHVM - 10https://bugzilla.wikimedia.org/65792 (10Andre Klapper) p:5Unprio>3High [14:00:41] 3MediaWiki / 3Database: MSSQL allows opening connections without $wgDBuser being set - 10https://bugzilla.wikimedia.org/65808 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3major [14:00:56] 3MediaWiki extensions / 3AbuseFilter: JQMIGRATE: jQuery.fn.toggle(handler, handler...) is deprecated - 10https://bugzilla.wikimedia.org/65804 (10Andre Klapper) p:5Unprio>3High [14:02:41] 3MediaWiki / 3Skin and page rendering: div.vectorTabs li.icon a.loading shows a flashing box when focused in Firefox - 10https://bugzilla.wikimedia.org/65853#c2 (10Andre Klapper) Bug 65434 comes to my mind; similar/same reason? [14:05:56] 3MediaWiki / 3Skin and page rendering: Weird watchlist star animation on Firefox - 10https://bugzilla.wikimedia.org/65434#c8 (10Liangent) *** Bug 65853 has been marked as a duplicate of this bug. *** [14:05:56] 3MediaWiki / 3Skin and page rendering: div.vectorTabs li.icon a.loading shows a flashing box when focused in Firefox - 10https://bugzilla.wikimedia.org/65853#c3 (10Liangent) 5NEW>3RES/DUP The same. *** This bug has been marked as a duplicate of bug 65434 *** [14:07:56] 3MediaWiki extensions / 3ExtensionDistributor: Empty version dropdown - 10https://bugzilla.wikimedia.org/65852#c4 (10Southparkfan) Problem does also exist for downloading Oversight (is that extension even downloadable?), see https://www.mediawiki.org/wiki/Special:ExtensionDistributor/Oversight. Status can be... [14:08:41] 3MediaWiki / 3User blocking: MediaWiki:Autoblocker etc. reveals to third party that a (blocked) user has used the same IP address - 10https://bugzilla.wikimedia.org/53008#c45 (10Jackmcbarn) I didn't mean "how would an admin be able to hit the unblock button". I meant "how would an admin be able to decide whe... [14:08:41] 3MediaWiki extensions / 3Spam Blacklist: regex expressions starting with caret (^) not functioning as per instructions say - 10https://bugzilla.wikimedia.org/64541#c1 (10Liangent) I guess it's difficult to fix it now because regexes are now merged (piped) first; people would modify instructions to "fix" it n... [14:12:01] (03CR) 1001tonythomas: "I removed the $mime == null part and replaced the multipart messaging part with just setting the charset to plain/html or plain/text if so" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [14:21:11] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "What Daniel said." [core] - 10https://gerrit.wikimedia.org/r/60278 (owner: 10Daniel Kinzler) [14:31:14] (03CR) 10Hoo man: [C: 032] (bug 65805) Fix notice when creating new filter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/135761 (https://bugzilla.wikimedia.org/65805) (owner: 10Matthias Mullie) [14:31:27] (03Merged) 10jenkins-bot: (bug 65805) Fix notice when creating new filter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/135761 (https://bugzilla.wikimedia.org/65805) (owner: 10Matthias Mullie) [14:32:44] 3Wikimedia / 3General/Unknown: Delete unaccessible redirects on Portuguese Wikipedia - 10https://bugzilla.wikimedia.org/65854 (10Helder) 3NEW p:3Unprio s:3normal a:3None Per RFC linked above, the prefix "C:" is now used for interwikis point to Wikimedia Commons, and the pages below can not be deleted... [14:33:18] (03CR) 10Rillke: [C: 04-1] "updatelog table must be pre-populated with update keys to prevent accidental "downgrading" enum in case more is added in future" [core] - 10https://gerrit.wikimedia.org/r/135756 (owner: 10Rillke) [14:36:25] (03PS1) 10Yaron Koren: Fix to get replacements in > 1000 or so pages to work [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/135769 [14:37:36] (03CR) 10Yaron Koren: [C: 032 V: 031] Fix to get replacements in > 1000 or so pages to work [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/135769 (owner: 10Yaron Koren) [14:37:38] (03Merged) 10jenkins-bot: Fix to get replacements in > 1000 or so pages to work [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/135769 (owner: 10Yaron Koren) [14:38:11] 3MediaWiki extensions / 3WikiEditor: The help section should include a link to more help, ie. Help:Contents by default - 10https://bugzilla.wikimedia.org/65797#c2 (10Ian Kelling) (In reply to Andre Klapper from comment #1) > > The help section > > How to find "the help section" (to make sure we talk about t... [14:40:41] 3MediaWiki extensions / 3ExtensionDistributor: Empty version dropdown - 10https://bugzilla.wikimedia.org/65852 (10Nemo) 5UNC>3NEW [14:41:32] (03PS1) 10Jack Phoenix: * Removed some unused (global) variables. * Removed old RTL-related code (the variables were unused anyway); if we at a later date determine that we have to set body { margin: 25px; } for Internet Explorer when using a RTL language, let's come up with a b [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/135770 [14:42:10] (03CR) 10Jack Phoenix: [C: 032 V: 032] * Removed some unused (global) variables. * Removed old RTL-related code (the variables were unused anyway); if we at a later date determine [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/135770 (owner: 10Jack Phoenix) [14:48:03] (03PS5) 10Nik: Correctly parse 'redirect' XML tag during Special:Import. [core] - 10https://gerrit.wikimedia.org/r/134079 (https://bugzilla.wikimedia.org/65481) [14:50:26] 3MediaWiki extensions / 3WikiEditor: The help section should include a link to more help, ie. Help:Contents by default - 10https://bugzilla.wikimedia.org/65797#c3 (10Florian) Hmm, but not all wikis have/want much more explanation pages :) in my opinion the basic features are enough for in-editor help. For mo... [14:50:52] (03PS4) 10Rillke: Add "chemical" major MIME type to the image tables [core] - 10https://gerrit.wikimedia.org/r/135756 [14:52:34] (03PS1) 10Aude: Update Wikidata, fix issue with rollback [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135771 [14:53:07] (03CR) 10Rillke: Add "chemical" major MIME type to the image tables (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135756 (owner: 10Rillke) [14:53:56] 3MediaWiki extensions / 3WikidataClient: Full support for wikibase edits in enhanced changes format ("Group changes by page in recent changes and watchlist" [usenewrc]) - 10https://bugzilla.wikimedia.org/44874#c10 (10Sergey Vladimirov) Andre, the specific of question is so obvious for me, so i wrote it in sh... [14:55:56] 3MediaWiki extensions / 3ExtensionDistributor: Empty version dropdown - 10https://bugzilla.wikimedia.org/65852#c5 (10Florian) Created attachment 15498 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15498&action=edit branches exist Hmm, anything i do false :? Now i have tested with FF, Chrome and An... [14:57:11] 3Wikimedia / 3Wikidata: monitor dispatch stats - 10https://bugzilla.wikimedia.org/65291 (10Andre Klapper) [15:03:50] (03CR) 10Anomie: [C: 032] "SWAT deploy" [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135771 (owner: 10Aude) [15:06:25] (03CR) 10Jackmcbarn: "For things that really do need this behavior, would setting a TTL of 0 do the same thing as this would do, or would it be weaker?" [core] - 10https://gerrit.wikimedia.org/r/99792 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [15:06:58] (03Merged) 10jenkins-bot: Update Wikidata, fix issue with rollback [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135771 (owner: 10Aude) [15:13:47] (03CR) 10Parent5446: Add "chemical" major MIME type to the image tables (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135756 (owner: 10Rillke) [15:15:39] (03CR) 10Parent5446: "You should be able to replace the PEAR MIME stuff with equivalent functionality in Swift. The idea is that the message might be multipart," [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [15:16:11] 3MediaWiki extensions / 3Collection: Generating PDFs for books with more than one page fails horribly at pl.wikisource - 10https://bugzilla.wikimedia.org/47575 (10Andre Klapper) [15:16:26] 3MediaWiki extensions / 3Collection: Rendering a book from plwikisource results in an error - 10https://bugzilla.wikimedia.org/65298 (10Andre Klapper) [15:19:02] (03CR) 10Rillke: Add "chemical" major MIME type to the image tables (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135756 (owner: 10Rillke) [15:19:21] (03CR) 10Parent5446: Shifted from PEAR/PHP mailer to Swift Mailer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [15:22:14] (03PS3) 10Prtksxna: render.article: Remove brackets using code instead of RegExp [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135759 (https://bugzilla.wikimedia.org/65138) [15:23:43] 3MediaWiki extensions / 3Petition: Performance review of Petition extension before WMF deployment - 10https://bugzilla.wikimedia.org/65851#c1 (10Greg Grossmeier) a:3Ori Livneh Assigning to Ori. Ori: feel free to punt to someone you pick. [15:28:56] 3Wikimedia / 3Extension setup: Review & deploy mediawiki/extensions/FundraisingChart - 10https://bugzilla.wikimedia.org/65834#c2 (10Greg Grossmeier) p:5Unprio>3Normal From: https://www.mediawiki.org/wiki/Review_queue == Checklist == === Done === # Create Extension: mediawiki.org page for developers and... [15:30:41] 3Wikimedia / 3Extension setup: Review and deploy Petition extension to wikimediafoundation.org - 10https://bugzilla.wikimedia.org/65849#c1 (10Greg Grossmeier) == Checklist == === Done === # Create Extension: mediawiki.org page for developers and people who will install or configure the extension. # Request a... [15:32:59] 3MediaWiki extensions / 3CodeEditor: CodeEditor doesn't work with editwarning - 10https://bugzilla.wikimedia.org/65855 (10Liangent) 3NEW p:3Unprio s:3normal a:3None editwarning: https://www.mediawiki.org/wiki/Extension:Vector#EditWarning [15:34:23] (03PS1) 10Cmcmahon: [browser test] Comment field needs css identifier now [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135775 [15:34:32] (03CR) 10BryanDavis: Shifted from PEAR/PHP mailer to Swift Mailer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [15:34:44] (03CR) 10jenkins-bot: [V: 04-1] [browser test] Comment field needs css identifier now [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135775 (owner: 10Cmcmahon) [15:38:13] (03CR) 10Aaron Schulz: Added Range support to FileBackend::streamFile() (033 comments) [core] - 10https://gerrit.wikimedia.org/r/127466 (owner: 10Aaron Schulz) [15:38:34] (03CR) 10Aaron Schulz: "I don't really have time for this, so anyone can adopt this patch if wanted." [core] - 10https://gerrit.wikimedia.org/r/127466 (owner: 10Aaron Schulz) [15:43:32] (03CR) 10Jeroen De Dauw: [C: 04-1] "Am I seeing this right?! A dependency on a third part library is added in such a way that one will be required to run "composer install" o" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [15:44:29] 3Wikimedia / 3SVG rendering: Chess picture in mobile view not displayed properly - 10https://bugzilla.wikimedia.org/65856 (10a455304) 3UNC p:3Unprio s:3normal a:3None Created attachment 15499 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15499&action=edit SVG images set in bad position This... [15:48:29] (03CR) 10BryanDavis: "> Maybe you're not creating the object at the right time, then?" [tools/scap] - 10https://gerrit.wikimedia.org/r/135617 (owner: 10BryanDavis) [15:48:41] 3Wikimedia / 3SVG rendering: Chess picture in mobile view not displayed properly - 10https://bugzilla.wikimedia.org/65856#c1 (10Florian) But this chess table is a table?! [15:50:11] 3Wikimedia / 3Site requests: New England Wikimedians website - 10https://bugzilla.wikimedia.org/64557#c56 (10jeremyb) (In reply to John F. Lewis from comment #54) > AffCom have agreed to use the us-ne format. The debate at the moment is > between ops of whether to us us-ne or ne-us. Ops withdrew the order o... [15:50:12] (03CR) 10Thiemo Mättig (WMDE): Allow non-text content to use HTML for transclusion. (033 comments) [core] - 10https://gerrit.wikimedia.org/r/132710 (owner: 10Daniel Kinzler) [15:56:26] 3MediaWiki / 3User preferences: Handle "Search" --> "Advanced options" section of Special:Preferences on Special:Search itself - 10https://bugzilla.wikimedia.org/52817#c12 (10[[kgh]]) Well, exact colouring is debatable, however we still have to consider colour-blind and blind users. Thus I believe that colou... [15:56:26] 3Wikimedia / 3General/Unknown: Delete unaccessible redirects on Portuguese Wikipedia - 10https://bugzilla.wikimedia.org/65854#c1 (10Ricordisamoa) https://www.mediawiki.org/wiki/API:Delete? [16:01:58] hi jdlrobson I know you were working on the skins thing removing Modern and Cologne Blue. is it the case that those skins should be gone from Preferences now also? I didn't find a bug for that, but they are gone now. [16:05:26] 3Wikimedia / 3Site requests: New England Wikimedians website - 10https://bugzilla.wikimedia.org/64557#c57 (10Kevin Rutherford) In response to Comment 44: No. [16:06:11] 3MediaWiki extensions / 3WikidataRepo: query for all available badges via API - 10https://bugzilla.wikimedia.org/63486 (10Bene*) 5PAT>3RES/FIX [16:07:11] 3MediaWiki extensions / 3WikidataClient: Display article badges on client - 10https://bugzilla.wikimedia.org/60717 (10Bene*) 5PAT>3RES/FIX [16:08:05] (03PS5) 10Anomie: Allow filtering log entries by namespace (API) [core] - 10https://gerrit.wikimedia.org/r/135283 (owner: 10Jackmcbarn) [16:08:49] (03CR) 10BryanDavis: Invalidate local configuration cache on sync (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/135724 (https://bugzilla.wikimedia.org/58618) (owner: 10BryanDavis) [16:09:28] (03CR) 10Ori.livneh: [C: 032] Invalidate local configuration cache on sync [tools/scap] - 10https://gerrit.wikimedia.org/r/135724 (https://bugzilla.wikimedia.org/58618) (owner: 10BryanDavis) [16:09:40] (03PS6) 10Anomie: Allow filtering log entries by namespace (API) [core] - 10https://gerrit.wikimedia.org/r/135283 (owner: 10Jackmcbarn) [16:10:35] (03CR) 10Anomie: [C: 032] "Looks good, and Springle likes the resulting query. I added release notes for you." [core] - 10https://gerrit.wikimedia.org/r/135283 (owner: 10Jackmcbarn) [16:12:26] (03CR) 10MaxSem: [C: 032] Fix documentation formatting of multimedia-related roles [vagrant] - 10https://gerrit.wikimedia.org/r/135727 (owner: 10Gergő Tisza) [16:13:53] (03Merged) 10jenkins-bot: Allow filtering log entries by namespace (API) [core] - 10https://gerrit.wikimedia.org/r/135283 (owner: 10Jackmcbarn) [16:14:13] (03PS1) 10Anomie: Add release notes for Ie3f7273c [core] - 10https://gerrit.wikimedia.org/r/135778 [16:14:33] (03CR) 10Anomie: [C: 032] "Trivial release-notes-only patch" [core] - 10https://gerrit.wikimedia.org/r/135778 (owner: 10Anomie) [16:15:23] (03CR) 10Anomie: "Oops, we forgot the release notes! Added in Ie3f7273c18e156da1e50e1a36aac2e5341710982" [core] - 10https://gerrit.wikimedia.org/r/133955 (https://bugzilla.wikimedia.org/24330) (owner: 10Adamw) [16:15:55] (03CR) 10Anomie: "... And that should have said "Id39c4d779d138493a2a7a1db2cc4388b125e5bb5"." [core] - 10https://gerrit.wikimedia.org/r/133955 (https://bugzilla.wikimedia.org/24330) (owner: 10Adamw) [16:16:16] (03PS1) 10Prtksxna: render.article: Correctly space extract for landscape images with smaller heights [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135779 [16:17:41] 3MediaWiki extensions / 3Translate: Recursive parser calls - 10https://bugzilla.wikimedia.org/65826#c2 (10Niklas Laxström) What would be the am appropriate fix? Are special pages no longer allowed to use OutputPage::addWikiMsg and wrapWikiMsg? [16:19:16] (03Merged) 10jenkins-bot: Add release notes for Ie3f7273c [core] - 10https://gerrit.wikimedia.org/r/135778 (owner: 10Anomie) [16:23:47] (03PS2) 10PleaseStand: API: Skip all HTML transformations for non-XML formats [core] - 10https://gerrit.wikimedia.org/r/133739 (https://bugzilla.wikimedia.org/65403) [16:23:54] (03PS3) 10PleaseStand: API: Skip XML tag highlighting for non-XML formats [core] - 10https://gerrit.wikimedia.org/r/133739 (https://bugzilla.wikimedia.org/65403) [16:24:52] (03CR) 10jenkins-bot: [V: 04-1] API: Skip XML tag highlighting for non-XML formats [core] - 10https://gerrit.wikimedia.org/r/133739 (https://bugzilla.wikimedia.org/65403) (owner: 10PleaseStand) [16:25:59] (03CR) 10jenkins-bot: [V: 04-1] API: Skip XML tag highlighting for non-XML formats [core] - 10https://gerrit.wikimedia.org/r/133739 (https://bugzilla.wikimedia.org/65403) (owner: 10PleaseStand) [16:26:40] (03PS4) 10PleaseStand: API: Skip XML tag highlighting for non-XML formats [core] - 10https://gerrit.wikimedia.org/r/133739 (https://bugzilla.wikimedia.org/65403) [16:29:43] (03CR) 10Cmcmahon: "More regression tests to come, but this got the thumbs up in discussion." [core] - 10https://gerrit.wikimedia.org/r/133507 (owner: 10Cmcmahon) [16:29:48] (03PS10) 10Cmcmahon: WIP: browser acceptance tests [core] - 10https://gerrit.wikimedia.org/r/133507 [16:33:19] (03CR) 10Ori.livneh: [C: 032] "Not going to hold you hostage over my preferences, but FWIW, I generally find that if you're using the whole arsenal of metaprogramming fa" [tools/scap] - 10https://gerrit.wikimedia.org/r/135617 (owner: 10BryanDavis) [16:36:39] ^d: Can you help diagnose my gerrit account, or redirect me? There are two annoying things: I've lost +2, and I have two accounts [16:37:27] <^d> awight: Why would you have two accounts? [16:37:51] I think it was due to an ops dedupe thing... [16:38:00] which of course resulted in duplicate accounts :p [16:38:17] awight: can you tell me what's happening with your account? [16:38:23] sorry, I missed the scrollback [16:38:28] 3MediaWiki / 3Email: E-mail this user not working or e-mails going missing - 10https://bugzilla.wikimedia.org/65860 (10Nick) 3NEW p:3Unprio s:3normal a:3None English Wikipedia user https://en.wikipedia.org/wiki/User:Pratyya_Ghosh reports an issue where e-mails sent using the "E-mail this user" functi... [16:39:12] andrewbogott: ah thx. I have two accounts in gerrit, which is hard on my colleagues. I also lost +2 at about the same time. [16:39:45] awight: the two accounts thing sounds familiar, is there a bugzilla bug for this by chance? [16:39:56] I did open one [16:40:01] #? [16:40:02] or perhaps RT... [16:40:05] lemme see... [16:40:42] 3Wikimedia / 3General/Unknown: E-mail this user not working or e-mails going missing - 10https://bugzilla.wikimedia.org/65860 (10Greg Grossmeier) p:5Unprio>3Normal [16:41:41] 3Wikimedia / 3General/Unknown: E-mail this user not working or e-mails going missing - 10https://bugzilla.wikimedia.org/65860#c1 (10Greg Grossmeier) Changing to Wikimedia (from MediaWiki) because this is probably an issue someone in our stack, not inherently an issue in MediaWiki (though it could be...) [16:42:56] 3MediaWiki / 3Installer: MSSQL installer broken; updateRowExists returns always false - 10https://bugzilla.wikimedia.org/65813#c5 (10Rainer Rillke @commons.wikimedia) (In reply to Andre Klapper from comment #4) > Wondering if this only affects 1.24/git master or also 1.23 stable The issue is there but there... [16:43:44] andrewbogott: that was odd. I changed my RT password the other day, and it has reverted... Anyway... RT# 7517 [16:45:28] 3Wikimedia / 3Deployment systems: [scap] Touch InitialiseSettings.php if syncing - 10https://bugzilla.wikimedia.org/58618 (10Greg Grossmeier) a:3Bryan Davis [16:45:40] (03CR) 10Ori.livneh: [C: 031] "Gilles, Aaron is a precious commodity :) If I were you I'd probably merge and add the tests myself" [core] - 10https://gerrit.wikimedia.org/r/127466 (owner: 10Aaron Schulz) [16:45:52] awight: if the 'awight' account doesn't have any review history then I can probably delete it. Is it OK if that account stops working on Labs as well? [16:46:01] (03Merged) 10jenkins-bot: LinearDoc: Flattened representation of Inline HTML [services/cxserver] - 10https://gerrit.wikimedia.org/r/124287 (owner: 10Divec) [16:46:26] (03PS10) 10Yurik: Added BeforeHttpsRedirect hook allowing extensions to cancel forceHTTPS [core] - 10https://gerrit.wikimedia.org/r/132952 [16:46:44] oh, wait, isn't 'awight' the new account we created in order for you to have the same name in labs and prod? [16:47:05] andrewbogott: yes. Does it have to be this way on gerrit, though? [16:47:16] urgh. I guess that is linked to wikitech... [16:47:20] (03CR) 10MaxSem: [C: 032] Added BeforeHttpsRedirect hook allowing extensions to cancel forceHTTPS [core] - 10https://gerrit.wikimedia.org/r/132952 (owner: 10Yurik) [16:47:21] gerrit and labs accounts both derive from labs [16:47:26] um… I mean, derive from ldap [16:47:30] so, yes, they're the same thing. [16:47:31] (03Merged) 10jenkins-bot: Update README.md for individual test run [services/cxserver] - 10https://gerrit.wikimedia.org/r/135523 (owner: 10KartikMistry) [16:47:33] (03Merged) 10jenkins-bot: Return early when parsoid response is failure [services/cxserver] - 10https://gerrit.wikimedia.org/r/135742 (owner: 10Santhosh) [16:47:51] andrewbogott: it is easy to reassign the "adamw" changes? [16:48:22] hm, I don't know. ^d, any idea if it's possible to assign an existing gerrit history to a new account? [16:48:28] <^d> Not easily. [16:48:41] Meh, I don't quite care about history, but I have a lot of pending work that would be a pita to move by hand [16:49:11] <^d> What would you have to move? [16:49:15] <^d> Owner doesn't matter. [16:49:51] ^d: everything in my dashboard. the awight account has an empty dash [16:50:03] (03Merged) 10jenkins-bot: Invalidate local configuration cache on sync [tools/scap] - 10https://gerrit.wikimedia.org/r/135724 (https://bugzilla.wikimedia.org/58618) (owner: 10BryanDavis) [16:50:06] (03Merged) 10jenkins-bot: Fix documentation formatting of multimedia-related roles [vagrant] - 10https://gerrit.wikimedia.org/r/135727 (owner: 10Gergő Tisza) [16:50:08] well… I don't like the idea of erasing history either. [16:50:34] yeah I can live without that... I'm not exactly dedicated to the high-score board ;) [16:50:44] (03Merged) 10jenkins-bot: Added BeforeHttpsRedirect hook allowing extensions to cancel forceHTTPS [core] - 10https://gerrit.wikimedia.org/r/132952 (owner: 10Yurik) [16:50:45] but I want my daily work to continue... [16:51:00] (03Merged) 10jenkins-bot: Replace properties with side-effects with getters [tools/scap] - 10https://gerrit.wikimedia.org/r/135617 (owner: 10BryanDavis) [16:51:48] ^d: I think I *do* care about "owner"--how else would changes appear on my dash? [16:52:03] <^d> You can search by the new user. [16:52:08] awight: It's important to keep track of patch history for licensing reasons if nothing else... [16:52:27] well, my email address has not changed (recently), so that's probably not an issue [16:52:46] hm, true. [16:52:47] <^d> andrewbogott: History's in the git repo where it matters. [16:52:54] <^d> Gerrit UI doesn't matter nearly as much. [16:52:58] ok [16:53:33] (03CR) 10Cmcmahon: [C: 032] [browser test] Comment field needs css identifier now [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135775 (owner: 10Cmcmahon) [16:54:57] (03CR) 10jenkins-bot: [V: 04-1] [browser test] Comment field needs css identifier now [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135775 (owner: 10Cmcmahon) [16:55:35] (03PS8) 10Ori.livneh: vector: Add tabindex back to search box [core] - 10https://gerrit.wikimedia.org/r/135269 (https://bugzilla.wikimedia.org/29199) (owner: 10Alex Monk) [16:55:39] (03CR) 10Ori.livneh: [C: 032] vector: Add tabindex back to search box [core] - 10https://gerrit.wikimedia.org/r/135269 (https://bugzilla.wikimedia.org/29199) (owner: 10Alex Monk) [16:57:11] 3Wikimedia / 3Bugzilla: Security review of TargetProcess Bugzilla module - 10https://bugzilla.wikimedia.org/62272#c5 (10Greg Grossmeier) p:5Normal>3Lowest Setting to "Lowest" for now, and when we migrate to Phabricator, let's close this as INVALID (ie: keep it around on the very very slim chance somethin... [16:59:39] ^d: So now it's sound like deletion of 'adamw' is the way to go. But I don't know what to do about the current patches that are on adamw's console. [17:00:38] (03Merged) 10jenkins-bot: vector: Add tabindex back to search box [core] - 10https://gerrit.wikimedia.org/r/135269 (https://bugzilla.wikimedia.org/29199) (owner: 10Alex Monk) [17:00:39] * awight hurriedly takes screenshots of gerrit dashboard 8p [17:00:57] merge them all [17:01:06] actually i was going to merge at least a couple [17:01:09] ori: lol, mind reading! [17:01:30] <^d> hey if ori's volunteering to spelunk in the gerrit db by all means I'm not gonna stop him :p [17:01:51] ^d: I think ori was suggesting a social hack [17:02:29] awight: actually.. now that I think about this, I may know another way... [17:02:42] (03PS1) 10Yaron Koren: Version 1.1 [extensions/Widgets] - 10https://gerrit.wikimedia.org/r/135791 [17:02:59] I can maybe rename the 'adamw' gerrit account to 'awight' and delete the old 'awight' in gerrit... [17:03:12] that should associate the old adamw gerrit account ID with the new awight ldap entry [17:03:29] Keep in mind, though, the disaster that ensued the last time I tried to be clever about this kind of thing :/ [17:03:34] (03CR) 10Yaron Koren: [C: 032 V: 032] Version 1.1 [extensions/Widgets] - 10https://gerrit.wikimedia.org/r/135791 (owner: 10Yaron Koren) [17:04:31] andrewbogott: HA, no your work is much appreciated. sorry if the odd speling of my name causes issues :p [17:04:43] (03CR) 10CSteipp: [C: 031] "Haven't tested, but it looks like that should work. Thanks!" [core] - 10https://gerrit.wikimedia.org/r/133507 (owner: 10Cmcmahon) [17:05:10] I don't think your name is an issue -- mostly the issue is that I keep thinking that I have a new smart way to rename a labs user and I always get smacked down. [17:05:17] But gerrit is slightly simpler… want me to try that? [17:05:41] 3Wikimedia / 3General/Unknown: E-mail this user not working or e-mails going missing - 10https://bugzilla.wikimedia.org/65860#c2 (10Andre Klapper) Dup of bug 64795 or bug 64441? Greg: If you have an idea who and how to track this down further, it's welcome. [17:05:51] well, wait, I need to think about this a bit more... [17:06:11] 3Wikimedia / 3General/Unknown: E-mail this user not working or e-mails going missing - 10https://bugzilla.wikimedia.org/65860#c3 (10Andre Klapper) Nick: ...plus wondering if the user has a Yahoo email address. [17:07:15] awight: as with labs, gerrit accounts have two names, a 'username' (generally short) and a 'full name'. Can you tell me each of those for each of your accounts? [17:07:43] 3Wikimedia / 3Deployment systems: sync-dblist never seems to !log - 10https://bugzilla.wikimedia.org/65368 (10Greg Grossmeier) a:3Bryan Davis [17:10:04] andrewbogott: currently (Adamw, adamw); (Awight, awight) [17:10:32] Your 'full name' is not your full name, I take it? And it's the same on wikitech? [17:12:27] 3MediaWiki extensions / 3AbuseFilter: notice when creating new filter - 10https://bugzilla.wikimedia.org/65805 (10Jackmcbarn) 5PAT>3RES/FIX a:3Matthias Mullie [17:14:48] (03PS1) 10Adamw: Add Belgium to countries supported by WorldPay [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/135797 [17:15:27] bd808: sorry about BZ spam (possibly) [17:15:44] meh. I'll survive [17:15:51] (03CR) 10Ssmith: [C: 032] Add Belgium to countries supported by WorldPay [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/135797 (owner: 10Adamw) [17:16:27] greg-g: I don't "take" bugs very often to keep from having a bunch with my name on them that never get resolved. :) [17:17:35] awight: those pairs that you just typed are (fullname, username) right? [17:17:52] well, I figured since those were ones with patches merged and just needing testing (or close to it) that it was fine ;) [17:18:02] bd808: ^ [17:18:05] So, I could scramble things so that you are (Adamw, awight) on gerrit. That would mean that your gerrit login and your wikitech login are different. [17:18:15] I'm not sure if that would work or not… I think it probably would. [17:18:29] Then we can try to delete 'adamw' from ldap and gerrit and see what breaks. [17:18:30] andrewbogott: I'd like to fix the full name, actually. Seems I cannot edit through the GUI [17:18:45] (03PS1) 10Yurik: Updated zero ext [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135799 [17:18:52] andrewbogott: wait, "real name" is mapped to wikitech login, not "username"? [17:19:20] awight: if I ever said 'real name' then that was a mistake, there's nothing called 'real name' [17:19:25] there's 'full name' and 'username' [17:19:31] (03PS1) 10Yurik: Updated zero ext [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/135800 [17:19:32] 'full name' should correspond to your un-wiki name [17:19:38] and 'username' to your 'shell name' in labs [17:19:41] 3MediaWiki extensions / 3Scribunto: Lua error, interpreter exited with status 2. - 10https://bugzilla.wikimedia.org/48877#c12 (10Danny) It's not 100% clear to me what the resolution to the problem was. If it was an executable permission why would you get the memory errors? Anyway, I had the same problem an... [17:19:56] (03CR) 10jenkins-bot: [V: 04-1] Add Belgium to countries supported by WorldPay [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/135797 (owner: 10Adamw) [17:19:58] <^d> Your username in gerrit doesn't match with your sn, it matches cn. [17:20:05] <^d> Your gerrit shell username is your sn. [17:20:09] (03CR) 10Yurik: [C: 032] Updated zero ext [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135799 (owner: 10Yurik) [17:20:14] (03CR) 10Parent5446: "@Jeroen: Yes, but only if you install MediaWiki using Git. If you download the tarball, the release team will pre-initialize the vendor/ d" [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [17:20:16] (03CR) 10Yurik: [C: 032] Updated zero ext [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/135800 (owner: 10Yurik) [17:20:46] ^d: um… that's the same as what I just said, I hope? [17:21:22] <^d> Your username is not your shell name, it's your username. Your shell name is your shell name. [17:21:36] <^d> gerrit username = ldap cn = wikitech username [17:21:51] <^d> gerrit shell = ldap sn = labs shell user [17:21:52] ^d: In the gerrit gui there are only two things: 'full name' and 'username' [17:22:02] <^d> Those are the same thing for us. [17:22:15] I am pretty sure that what the gerrit gui calls 'username' is what you are calling 'shell name' [17:22:20] <^d> Blah, stupid UI. [17:22:21] <^d> I forgot. [17:22:35] <^d> I'm thinking how the application treats it. [17:22:37] <^d> UI is stupid. [17:23:12] OK, but for the purposes of this conversation… since awight is not reading source code... [17:23:22] can we use UI terminology? [17:23:39] <^d> I'm going to walk away before I confuse anyone else including myself. [17:23:44] * ^d hides in the corner [17:24:16] * awight is already dead in that corner. find yr own hovel :p [17:24:46] if ( !defined( 'MEDIAWIKI' ) ) {die();} What is MediaWiki "constant" defined as [17:25:01] ^d: should I even ask about the "Reload" button next to "full name"? [17:25:24] I don't have one of those, mercifully :) [17:25:33] <^d> awight: Doesn't really do anything for us. [17:25:33] andrewbogott: hehe. it logs me out... [17:25:39] <^d> LDAP integration in gerrit sucks. [17:25:44] Withoutaname: true [17:25:48] so, awight… at the moment, Every Single User has a clear correspondance between wikitech and gerrit. I can try to break your account so that your old gerrit account uses your new 'username' [17:25:58] Withoutaname: WebStart.php [17:26:07] In which case you will be an eternal outlier. I'm not sure what that will cost us in the future… maybe nothing. [17:26:20] (03CR) 10BryanDavis: [C: 031] "Looks like this got stuck due to zuul freaking out or something similar. I don't have +2 here or I'd try to resubmit it." [search/highlighter] - 10https://gerrit.wikimedia.org/r/135019 (owner: 10Manybubbles) [17:26:20] Withoutaname: Maintenance.php [17:26:25] ^d: 'LDAP integration' is just 'copy stuff from ldap and then never look in ldap ever again' right? [17:26:30] Withoutaname: the value doesn't matter, it's just something extension code can test to ensure the code is being run from a MediaWiki context, rather than directly from the command-line, etc. [17:26:37] (03Merged) 10jenkins-bot: Updated zero ext [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135799 (owner: 10Yurik) [17:26:47] oh I see [17:26:56] (03Merged) 10jenkins-bot: Updated zero ext [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/135800 (owner: 10Yurik) [17:27:00] thanks liangent [17:27:10] hmm grepping tells me another, which is more interesting: [17:27:13] (03CR) 10Mwalker: [C: 032 V: 032] "Grrr jenkins bot" [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/135797 (owner: 10Adamw) [17:27:14] <^d> andrewbogott: copy stuff from ldap and overwrite things if they change. unless you login with a new account, then you get a new account (because it doesn't handle renames) [17:27:15] andrewbogott: All I care about is that I can continue work as awight, without losing stuff. We can break my name later ;) [17:27:15] define( 'MEDIAWIKI', 1 ); [17:27:16] define( 'NOT_REALLY_MEDIAWIKI', 1 ); [17:27:23] maintenance/language/validate.php [17:27:25] <^d> (and don't copy things that would be nice, like ssh keys) [17:27:35] (03CR) 1001tonythomas: "@Parent5446:-" (036 comments) [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [17:28:04] awight what if I wanted a maint script in my extension [17:28:10] or I needed to populate a table [17:28:16] ^d: So if change an account name in gerrit and don't make the corresponding change in ldap… it might revert at some point on a whim? [17:28:42] class MaintChild extend Maintenance {...} [17:28:42] awight: It is technically the case that you can already do that, right? Just stop using the old account, start using the new one, done. [17:28:51] (03CR) 10Parent5446: "Yes. There's no need to worry about autoloading." [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [17:29:43] <^d> andrewbogott: Something like that, yeah. [17:30:08] hm... [17:30:09] Withoutaname: to populate a table, see how the "LoadExtensionSchemaUpdates" hook is used, eg http://www.mediawiki.org/wiki/Manual:Hooks/LoadExtensionSchemaUpdates [17:30:11] 3Wikimedia / 3Extension setup: Review and deploy Petition extension to wikimediafoundation.org - 10https://bugzilla.wikimedia.org/65849#c2 (10Greg Grossmeier) (In reply to Peter Coombe from comment #0) > Would like to get this deployed as soon as possible, since we are aiming to > launch the petition in June... [17:30:21] awight: ok, log out and stand back :) [17:31:05] ^d: How do a force a db reload in gerrit? [17:31:39] Withoutaname: for example maintenance scripts, look for extensions with a "maintenance" directory, like https://github.com/wikimedia/mediawiki-extensions-Echo/blob/master/maintenance/processEchoEmailBatch.php [17:31:41] 3Wikimedia / 3General/Unknown: Delete unaccessible redirects on Portuguese Wikipedia - 10https://bugzilla.wikimedia.org/65854#c2 (10Helder) I can't use that either: > { > "servedby": "mw1114", > "error": { > "code": "invalidtitle", > "info": "Bad title \"C:DER\"" > } > } [17:32:43] 3MediaWiki / 3General/Unknown: Extraneous HTML produced by msg->parse() - 10https://bugzilla.wikimedia.org/65863 (10Bob Dye) 3UNC p:3Unprio s:3normal a:3None At some point fairly recently, the behavior of the Message Class parse function change, so that it now leaves extraneous HTML after the parsed... [17:33:00] (03CR) 1001tonythomas: "and, can you elaborate a bit on" [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [17:33:40] awight: So, just to reconfirm before I break things…. the account that is currently useful (with attached patch history &c.) is 'Adamw'? Even though Adamw has a bogus email attached to it? [17:33:54] (03CR) 10Cmcmahon: "once more with feeling" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135775 (owner: 10Cmcmahon) [17:34:03] andrewbogott: yes. but what is bogus about the email?? [17:34:10] spam@ludd.net [17:34:18] that's what's in the db [17:34:20] oh hah that is a real address [17:34:26] * andrewbogott shrugs [17:34:30] from my shady volunteer days. [17:35:06] so… I am going to take that UID (143) and assign it a new username /and/ a new full name: awight and Awight. [17:35:20] and I'm going to murder the account currently associated with awight, #1688 [17:35:36] woohoo! [17:35:42] and my UID is badass [17:35:49] And then, probably, gerrit will never work again for anyone [17:36:08] um… btw, these uids are totally different from your labs or prod uids :( [17:36:13] (03CR) 10Parent5446: Shifted from PEAR/PHP mailer to Swift Mailer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [17:36:16] anyway, here goes [17:36:26] 3Wikimedia / 3Extension setup: Review and deploy Petition extension to wikimediafoundation.org - 10https://bugzilla.wikimedia.org/65849#c3 (10Chad H.) Two things jumped out at me skimming this that need fixing. 1) Since you're disabling the parser cache we end up doing a select count(*) on every render of t... [17:40:15] (03CR) 10Cmcmahon: [V: 032] "force attempt" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135775 (owner: 10Cmcmahon) [17:42:56] 3Wikimedia / 3General/Unknown: Delete unaccessible redirects on Portuguese Wikipedia - 10https://bugzilla.wikimedia.org/65854#c3 (10Helder) 5NEW>3RES/WOR I was able to delete these pages using its pageid instead of its title: https://pt.wikipedia.org/wiki/Special:Log/delete?dir=prev&offset=20140528172951... [17:44:06] ^d: Can you tell me how to flush the gerrit cache so that it reloads the db changes I just made? Or better yet update step 4 here: https://wikitech.wikimedia.org/wiki/Renaming_users ? [17:44:56] <^d> andrewbogott: `ssh -p 29418 gerrit.wikimedia.org gerrit flush-caches --list` will list your caches. [17:45:31] <^d> accounts*, groups* and ldap_* ones are usually what I hit, depending on what's changed. [17:45:51] Is it weird that i'm logged into ytterbium and there's no 'gerrit' command available? [17:46:09] What does that -p bit do? [17:46:41] other than tell me that my key is denied? [17:46:44] (03PS1) 10Matthias Mullie: Make sure cache key is always the same [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135804 [17:47:06] (03CR) 10jenkins-bot: [V: 04-1] Make sure cache key is always the same [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135804 (owner: 10Matthias Mullie) [17:47:19] ^d? ^^ [17:47:44] <^d> -p is the port. [17:47:56] <^d> You're doing the command over gerrit's non-interactive ssh daemon. [17:48:01] <^d> Not from ytterbium [17:48:06] <^d> (necessarily) [17:48:20] (03PS2) 10Matthias Mullie: Make sure cache key is always the same [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135804 [17:48:36] (03CR) 10jenkins-bot: [V: 04-1] Make sure cache key is always the same [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135804 (owner: 10Matthias Mullie) [17:49:02] ^d: From where then? Because I can ssh in to ytterbium fine from my local machine but I definitely cannot run that command [17:49:23] <^d> Do it from your local machine? That's what I do. [17:49:47] Didn't I just say... [17:49:52] well, anyway it works from iron, so, nm [17:51:01] (03PS11) 1001tonythomas: Shifted from PEAR/PHP mailer to Swift Mailer [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) [17:51:58] awight: ok… so now you can maybe log in as Awight but using the old password from the adamw account… does that work? [17:52:05] (If not, just do a password reset) [17:52:08] (03CR) 10jenkins-bot: [V: 04-1] Shifted from PEAR/PHP mailer to Swift Mailer [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [17:54:17] andrewbogott: whoohoo! brilliant work, my dash is intact and everything... [17:54:27] awight: ok... [17:54:47] I suspect that your old adamw account will reappear at somepoint (as that user still exists in ldap). [17:54:58] If that proves a problem I can try expunging it from ldap as well. [17:55:09] For the moment, though… do we have the singular autocomplete that you wanted? [17:55:17] Or are both personae still present? [17:56:35] andrewbogott: ergh. yeah it's a bit borken, two apparently identical entries appear, but with different UIDs [17:56:44] (03CR) 10Matthias Mullie: "Test failure seems unrelated to this change ;)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135804 (owner: 10Matthias Mullie) [17:57:06] hm, curious. [17:57:08] lemme see... [17:57:43] can you tell what the other id is? I still only see the one in the db [17:58:50] (03CR) 1001tonythomas: Shifted from PEAR/PHP mailer to Swift Mailer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [17:58:54] hi MatmaRex now that Modern and Cologne Blue skins are no longer in core, do you know if they are supposed to remain available as choices in the Preferences/Appearance settings? [17:59:29] chrismcmahon: on Wikimedia wikis? yes, they should [17:59:44] chrismcmahon: whoever merged the patches should ensure that the newly created external skins are enabled in WMF environment [17:59:51] or whoever wrote the patches [17:59:55] not me, anyway [17:59:57] :) [18:00:38] MatmaRex: ah. those choices no longer exist for users in beta labs. that's probably a bug [18:00:42] 3MediaWiki extensions / 3TitleBlacklist: TitleBlacklist should pass jshint - 10https://bugzilla.wikimedia.org/61639 (10PiRSquared17) a:3PiRSquared17 [18:01:06] definitely. [18:01:59] 3MediaWiki extensions / 3ZeroRatedMobileAccess: memcached / httpGet failing sometimes - 10https://bugzilla.wikimedia.org/65867 (10dr0ptp4kt) 3NEW p:3Unprio s:3normal a:3None memcached and Wikipedia app server-to-zero.wikimedia.org app server HTTP GET failures have been observed. This means that the W... [18:04:15] andrewbogott: it's the 1688 one, back to haunt us [18:04:45] ok, that has to be a caching thing then. ^d, can I just purge everything? [18:04:55] <^d> Yes, go ahead. [18:08:11] 3Wikimedia / 3General/Unknown: E-mail this user not working or e-mails going missing - 10https://bugzilla.wikimedia.org/65860#c4 (10Nick) Will get the user to confirm when they're next online and will report back. [18:08:20] awight: better? [18:08:42] No! [18:08:43] 3MediaWiki / 3Skin and page rendering: Modern and Cologne Blue should remain in Preferences/Appearance after removal from core - 10https://bugzilla.wikimedia.org/65868 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Created attachment 15501 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15... [18:08:59] andrewbogott: It's like split personality, but just the same bland guy twice ;) [18:09:09] huh [18:09:55] (03PS1) 10Gergő Tisza: Add PagedTiffHandler role [vagrant] - 10https://gerrit.wikimedia.org/r/135811 [18:11:47] awight: and still? [18:13:34] andrewbogott: yes it still hurts [18:13:45] welp [18:14:14] what symptom are you seeing specifically? The autocomplete when you add yourself as a reviewer? [18:16:31] (03PS1) 10Umherirrender: Add missing possible errors to ApiQueryLogEvents.php [core] - 10https://gerrit.wikimedia.org/r/135815 [18:16:42] (03PS1) 10Physikerwelt: Improve MathML error handling [extensions/Math] - 10https://gerrit.wikimedia.org/r/135817 [18:17:57] (03CR) 10Nemo bis: Lot of standard performance tweaks for those who want them (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/119216 (owner: 10Nemo bis) [18:21:07] (03CR) 10Umherirrender: "Typing a user on [[Special:Log/block]] into the target field actually adds the user namespace, when missing." [core] - 10https://gerrit.wikimedia.org/r/135186 (https://bugzilla.wikimedia.org/46494) (owner: 10devunt) [18:21:44] andrewbogott: u can try. go to a patch and add "awi" [18:22:41] 3MediaWiki extensions / 3VectorBeta: [VectorBeta] Fixed header : header under some part of ACE - 10https://bugzilla.wikimedia.org/65712#c3 (10Jared Zimmerman (WMF)) Can you please include a screenshot of the issue in the bug as well as a link to the project(?) page for ACE [18:22:49] (03CR) 10Physikerwelt: [C: 04-1] "Don't merge before changes to the new i18n files is reviewed... I have never done that before..." [extensions/Math] - 10https://gerrit.wikimedia.org/r/135817 (owner: 10Physikerwelt) [18:30:41] 3Wikimedia / 3SSL related: Enable HSTS on Wikimedia wikis - 10https://bugzilla.wikimedia.org/38516 (10Jan Zerebecki) 5PAT>3NEW [18:32:41] 3Wikimedia / 3General/Unknown: Next wmf deployment (tracking) - 10https://bugzilla.wikimedia.org/38865 (10Bartosz Dziewoński) [18:32:41] 3Wikimedia / 3Extension setup: Modern and Cologne Blue should remain in Preferences/Appearance after removal from core - 10https://bugzilla.wikimedia.org/65868 (10Bartosz Dziewoński) p:5Unprio>3High s:5normal>3major [18:33:41] 3MediaWiki extensions / 3WikiEditor: Instrument all actions in wikitext editing toolbar for organization and frequency of use analysis and improvements - 10https://bugzilla.wikimedia.org/64711#c6 (10Jared Zimmerman (WMF)) Kaity, can you work with VE team and Analytics to figure out the best way to do this? t... [18:38:42] awight: ok, I think this is fixed (for the moment). Let me know if you run into other problems. [18:39:39] andrewbogott: looks good, sorry to waste yr morning! [18:42:28] np [18:43:59] (03PS1) 10Bartosz Dziewoński: s/CologneBlue/Modern/, obvious copy-paste error [skins/Modern] - 10https://gerrit.wikimedia.org/r/135822 [18:44:35] chrismcmahon: chad and ori and myself are on it :) thanks for poking [18:45:39] (03CR) 10Chad: [C: 032 V: 032] s/CologneBlue/Modern/, obvious copy-paste error [skins/Modern] - 10https://gerrit.wikimedia.org/r/135822 (owner: 10Bartosz Dziewoński) [18:46:05] (03PS1) 10Chad: WIP: make-wmf-branch to support skin branching as well [tools/release] - 10https://gerrit.wikimedia.org/r/135823 [18:47:59] (03PS2) 10Chad: WIP: make-wmf-branch to support skin branching as well [tools/release] - 10https://gerrit.wikimedia.org/r/135823 [18:49:00] (03CR) 10GWicke: "It would work the same way unless we decide to enforce a minimum cache TTL globally." [core] - 10https://gerrit.wikimedia.org/r/99792 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [18:52:53] (03CR) 10Daniel Kinzler: [C: 032] Correctly parse 'redirect' XML tag during Special:Import. [core] - 10https://gerrit.wikimedia.org/r/134079 (https://bugzilla.wikimedia.org/65481) (owner: 10Nik) [18:56:22] (03PS1) 10Bartosz Dziewoński: Adjust 'remoteBasePath' to the skins/ directory [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/135827 [18:56:27] (03PS1) 10Bartosz Dziewoński: Remove reference to non-existent 'modern-desc' message [skins/Modern] - 10https://gerrit.wikimedia.org/r/135828 [18:56:29] (03PS1) 10Bartosz Dziewoński: Don't use $dir for __DIR__ [skins/Modern] - 10https://gerrit.wikimedia.org/r/135829 [18:56:31] (03PS1) 10Bartosz Dziewoński: Adjust 'remoteBasePath' to the skins/ directory [skins/Modern] - 10https://gerrit.wikimedia.org/r/135830 [18:56:42] (03Merged) 10jenkins-bot: Correctly parse 'redirect' XML tag during Special:Import. [core] - 10https://gerrit.wikimedia.org/r/134079 (https://bugzilla.wikimedia.org/65481) (owner: 10Nik) [18:56:57] 3MediaWiki / 3Skin and page rendering: Weird watchlist star animation on Firefox - 10https://bugzilla.wikimedia.org/65434#c9 (10Liangent) bug 64934 has been backported? [18:57:41] 3MediaWiki / 3Database: Fix "Uncommitted DB writes (transaction from DatabaseBase::query)" - 10https://bugzilla.wikimedia.org/56269#c54 (10Danny) Don't know if this is same problem, but when I go to main page I get: Internal error [ff1c5836] 2014-05-28 18:54:15: Fatal exception of type MWException and at t... [19:01:34] I made a i18n relevant change and like to prevent that the change is mergend before the i18 review has been performed. Is there a common practice to communicate this? [19:01:42] 3Wikimedia / 3Extension setup: Modern and Cologne Blue should remain in Preferences/Appearance after removal from core - 10https://bugzilla.wikimedia.org/65868#c1 (10Greg Grossmeier) a:3Chad H. What's the plan here? [19:04:56] 3Analytics / 3General/Unknown: Number of Wikipedia Zero increasing drastically in mid March 2014 - 10https://bugzilla.wikimedia.org/62848#c8 (10Greg Grossmeier) What's the current thinking here? Has there been any more investigation? [19:06:11] 3Wikimedia / 3Extension setup: Modern and Cologne Blue should remain in Preferences/Appearance after removal from core - 10https://bugzilla.wikimedia.org/65868#c2 (10Chad H.) https://gerrit.wikimedia.org/r/#/c/135823/ [19:06:12] 3MediaWiki extensions / 3ZeroRatedMobileAccess: memcached / httpGet failing sometimes - 10https://bugzilla.wikimedia.org/65867#c1 (10Greg Grossmeier) p:5Unprio>3Low Just to confirm, the issue that we need to wait to surface again is Zero banners not showing up correctly, right? I trust you'll ping this b... [19:10:23] anomie: are you interested in modifying https://gerrit.wikimedia.org/r/99792 to use ttls instead of just volatile, or should i start my own changeset for that? [19:12:16] jackmcbarn: Go ahead. [19:14:56] 3MediaWiki / 3Skin and page rendering: Tabbing from summary/textarea field should not go to the search box (vector) - 10https://bugzilla.wikimedia.org/46336#c11 (10Jesús Martínez Novo (Ciencia Al Poder)) At this time, it's now resolved because the hardcoded tabindex in the search box has been removed (gerrit... [19:17:18] (03CR) 10Welterkj: "I worked with Bartosz to get the extension working on his wiki. We identified 3 issues:" [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [19:17:29] 3Analytics / 3EventLogging: MobileWikiOperatorCode Schema - 10https://bugzilla.wikimedia.org/65872 (10dr0ptp4kt) 3NEW p:3Unprio s:3normal a:3None Ori asked me to create this bug for tracking. The backing store in the EventLogging database corresponding to https://meta.wikimedia.org/w/index.php?title... [19:19:55] (03PS18) 10Welterkj: use imagemap class for HTML rendering [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 [19:21:11] 3MediaWiki extensions / 3ZeroRatedMobileAccess: memcached / httpGet failing sometimes - 10https://bugzilla.wikimedia.org/65867#c2 (10dr0ptp4kt) Yep, it causes banners to not show, or it causes stale versions of pages to be served incorrectly, or both. [19:21:26] 3MediaWiki extensions / 3Translate: Recursive parser calls - 10https://bugzilla.wikimedia.org/65826#c3 (10Bawolff (Brian Wolff)) (In reply to Niklas Laxström from comment #2) > What would be the am appropriate fix? Are special pages no longer allowed to > use OutputPage::addWikiMsg and wrapWikiMsg? OutputP... [19:21:36] (03CR) 10Welterkj: "Patch set 18 fixes links in edit summaries for files uploaded by the extension." [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [19:22:26] 3Analytics / 3General/Unknown: Number of Wikipedia Zero increasing drastically in mid March 2014 - 10https://bugzilla.wikimedia.org/62848#c9 (10dr0ptp4kt) (In reply to Greg Grossmeier from comment #8) > What's the current thinking here? Has there been any more investigation? We've played whack-a-mole, and w... [19:22:41] 3MediaWiki extensions / 3Translate: Recursive parser calls - 10https://bugzilla.wikimedia.org/65826#c4 (10Aaron Schulz) It's a huge chunk of the exception log now. [19:24:26] 3Analytics / 3EventLogging: MobileWikiOperatorCode Schema - 10https://bugzilla.wikimedia.org/65872#c1 (10dr0ptp4kt) To be clear, it's not that the entire database isn't taking events - I doubt that - but rather that the specific tables may not be taking events from what we could see when querying this morning. [19:32:59] (03CR) 10Ori.livneh: [C: 032] Add PagedTiffHandler role [vagrant] - 10https://gerrit.wikimedia.org/r/135811 (owner: 10Gergő Tisza) [19:33:03] (03Merged) 10jenkins-bot: Add PagedTiffHandler role [vagrant] - 10https://gerrit.wikimedia.org/r/135811 (owner: 10Gergő Tisza) [19:33:19] (03PS1) 10Physikerwelt: Add separate database table for LaTeXML (step 5) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135839 (https://bugzilla.wikimedia.org/65522) [19:33:21] (03CR) 10jenkins-bot: [V: 04-1] Add separate database table for LaTeXML (step 5) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135839 (https://bugzilla.wikimedia.org/65522) (owner: 10Physikerwelt) [19:34:29] (03CR) 10Ori.livneh: "(matt, I want to look at this too and haven't had the chance to go through it in detail, so hold off on merging for now please if that's o" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/133668 (owner: 10Ori.livneh) [19:35:03] (03CR) 10Brian Wolff: "For reference, this is a different config than what WMF uses" [vagrant] - 10https://gerrit.wikimedia.org/r/135811 (owner: 10Gergő Tisza) [19:35:07] (03PS19) 10Welterkj: use imagemap class for HTML rendering [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 [19:35:53] (03PS4) 10Ori.livneh: Fundraising CRM instance [vagrant] - 10https://gerrit.wikimedia.org/r/135322 (owner: 10Awight) [19:35:59] (03CR) 10Ori.livneh: [C: 032] Fundraising CRM instance [vagrant] - 10https://gerrit.wikimedia.org/r/135322 (owner: 10Awight) [19:36:03] (03Merged) 10jenkins-bot: Fundraising CRM instance [vagrant] - 10https://gerrit.wikimedia.org/r/135322 (owner: 10Awight) [19:36:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/135854 (owner: 10L10n-bot) [19:37:00] (03CR) 10Welterkj: "Patch set 19 adds a check to see if the ImageMap extension is installed and issues an error message if not." [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [19:37:58] (03PS2) 10Physikerwelt: Add separate database table for LaTeXML (step 5) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135839 (https://bugzilla.wikimedia.org/65522) [19:38:39] (03CR) 10Physikerwelt: "I'm afraid that this change is atomic" [extensions/Math] - 10https://gerrit.wikimedia.org/r/135839 (https://bugzilla.wikimedia.org/65522) (owner: 10Physikerwelt) [19:39:51] (03CR) 10Ori.livneh: "two very minor issues, merge-able otherwise" (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/135322 (owner: 10Awight) [19:40:00] (03CR) 10jenkins-bot: [V: 04-1] Add separate database table for LaTeXML (step 5) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135839 (https://bugzilla.wikimedia.org/65522) (owner: 10Physikerwelt) [19:43:00] (03CR) 10Krinkle: Refactor doc publishing from labs (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 (owner: 10Hashar) [19:43:12] ^ awight [19:43:17] three lines above ;) [19:44:24] ori: thanks! [19:45:23] (03Abandoned) 10Umherirrender: Expand cleanupPreferences.php script to handle unused preferences [core] - 10https://gerrit.wikimedia.org/r/101233 (owner: 10Umherirrender) [19:52:56] (03Abandoned) 10Umherirrender: Add line number as id to diff block headers [core] - 10https://gerrit.wikimedia.org/r/131031 (owner: 10Umherirrender) [19:53:55] (03PS1) 10Umherirrender: Add comment to TableDiffFormatter::blockHeader [core] - 10https://gerrit.wikimedia.org/r/135876 [19:55:12] 3Wikimedia / 3Deployment systems: Trebuchet doesn't like when a deployer server is also a minion, a edge case for scap - 10https://bugzilla.wikimedia.org/65549#c3 (10Bryan Davis) This caused problems for /srv/deployment/scap/scap on tin again today. There seems to be really bad corruption of the file permiss... [19:57:09] anomie: should volatile/TTL cascade through ancestor frames? [19:59:01] jackmcbarn: Wouldn't it be pretty pointless if it didn't? Otherwise you'll have X having a time limit, but if you transclude X indirectly via Y it suddenly won't. [19:59:41] anomie: that's what i thought. i was asking because it doesn't look like your code did [20:00:09] (or was it, and i just not seeing it?) [20:01:12] jackmcbarn: setVolatile is calling parent::setVolatile. [20:01:41] 3MediaWiki extensions / 3Translate: Recursive parser calls - 10https://bugzilla.wikimedia.org/65826#c5 (10Umherirrender) (In reply to Niklas Laxström from comment #2) > What would be the am appropriate fix? Are special pages no longer allowed to > use OutputPage::addWikiMsg and wrapWikiMsg? See https://www.... [20:02:30] (03PS1) 10Gergő Tisza: Modify settings for PagedTiffHandler role to match WMF settings better [vagrant] - 10https://gerrit.wikimedia.org/r/135879 [20:02:32] (03CR) 10jenkins-bot: [V: 04-1] Modify settings for PagedTiffHandler role to match WMF settings better [vagrant] - 10https://gerrit.wikimedia.org/r/135879 (owner: 10Gergő Tisza) [20:02:33] oh [20:02:51] (03PS2) 10Gergő Tisza: Modify settings for PagedTiffHandler role to match WMF settings better [vagrant] - 10https://gerrit.wikimedia.org/r/135879 [20:03:38] (03CR) 10Gergő Tisza: "Tried to match WMF config better in I023e3624420b762f44e9183b3e182eff80fde1f9" [vagrant] - 10https://gerrit.wikimedia.org/r/135811 (owner: 10Gergő Tisza) [20:06:08] (03PS20) 10Welterkj: use imagemap class for HTML rendering [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 [20:06:11] 3Wikimedia / 3Deployment systems: [scap] Touch InitialiseSettings.php if syncing - 10https://bugzilla.wikimedia.org/58618#c4 (10Bryan Davis) 5PAT>3RES/FIX Verified that timestamp of /usr/local/apache/common-local/wmf-config/InitialiseSettings.php updated following a scap. [20:06:56] 3Wikimedia / 3Deployment systems: sync-dblist never seems to !log - 10https://bugzilla.wikimedia.org/65368#c2 (10Bryan Davis) 5NEW>3RES/FIX [13:49] !log bd808 Synchronized database lists: (no message) (duration: 00m 03s) [20:07:51] (03CR) 10Welterkj: "Patch set 20 fixes a problem that prevented graph rendering on any page with more than one word in the name (e.g. "Main Page")." [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [20:09:26] 3Wikimedia / 3Deployment systems: UnboundLocalError: local variable 'status' referenced before assignment - 10https://bugzilla.wikimedia.org/60068 (10Bryan Davis) 5PAT>3RES/FIX [20:11:12] (03PS3) 10Gergő Tisza: Add global limit to PoolCounter [core] - 10https://gerrit.wikimedia.org/r/135702 (https://bugzilla.wikimedia.org/65691) [20:19:12] (03PS21) 10Welterkj: use imagemap class for HTML rendering [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 [20:19:38] (03PS1) 10Awight: twiddle file modes [vagrant] - 10https://gerrit.wikimedia.org/r/135883 [20:20:12] (03PS16) 10MarkTraceur: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) [20:20:20] (03CR) 10Awight: Fundraising CRM instance (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/135322 (owner: 10Awight) [20:21:40] (03CR) 10Welterkj: "Patch set 21 adds support for URLs supplied in the mscgen language that do not have enclosing square brackets (the normal case)." [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [20:22:24] (03PS4) 10Bartosz Dziewoński: Skin: Remove dried up remains of Standard/Classic skin [core] - 10https://gerrit.wikimedia.org/r/135428 [20:22:31] ^ trivial [20:22:57] (03CR) 10Kaldari: [C: 032] Adding header font change to release notes for 1.24 [core] - 10https://gerrit.wikimedia.org/r/134864 (owner: 10Kaldari) [20:23:20] (03PS12) 1001tonythomas: Shifted from PEAR/PHP mailer to Swift Mailer [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) [20:24:32] (03CR) 10Bartosz Dziewoński: "Uh, right." [core] - 10https://gerrit.wikimedia.org/r/135408 (owner: 10Bartosz Dziewoński) [20:25:13] (03CR) 10jenkins-bot: [V: 04-1] Shifted from PEAR/PHP mailer to Swift Mailer [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [20:25:15] (03CR) 10jenkins-bot: [V: 04-1] Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [20:28:22] (03CR) 10Hashar: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [20:28:39] (03CR) 10Hashar: "recheck" [extensions/Math] - 10https://gerrit.wikimedia.org/r/135839 (https://bugzilla.wikimedia.org/65522) (owner: 10Physikerwelt) [20:30:28] (03PS3) 10Gergő Tisza: Allow media handlers to mark files as expensive [core] - 10https://gerrit.wikimedia.org/r/135701 (https://bugzilla.wikimedia.org/65691) [20:31:19] (03CR) 10Mattflaschen: [C: 04-1] "There are a couple things remaining from my patch set 9 comments, which I noted." (037 comments) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/133668 (owner: 10Ori.livneh) [20:33:16] (03PS4) 10Bartosz Dziewoński: Copy various random files used by tests to tests/phpunit/data [core] - 10https://gerrit.wikimedia.org/r/135408 [20:33:44] (03CR) 10Bartosz Dziewoński: "Should be good now. I use 'grep' as a verb, I usually don't actually use grep (Sublime's built-in search is neat)." [core] - 10https://gerrit.wikimedia.org/r/135408 (owner: 10Bartosz Dziewoński) [20:34:27] (03PS1) 10Robmoen: Create PostLoginRedirect Hook for modification of redirect url on login [core] - 10https://gerrit.wikimedia.org/r/135886 (https://bugzilla.wikimedia.org/65619) [20:34:29] (03CR) 10Bartosz Dziewoński: "Also, the skin autodiscovery stack doesn't actually depend on this now due to some minor changes, so I'll remove the dependency." [core] - 10https://gerrit.wikimedia.org/r/135408 (owner: 10Bartosz Dziewoński) [20:37:41] 3MediaWiki extensions / 3VectorBeta: [VectorBeta] Fixed header : header under some part of ACE - 10https://bugzilla.wikimedia.org/65712#c4 (10Ltrlg) Created attachment 15506 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15506&action=edit Screenshot Screenshot taken from the beta site that you menti... [20:38:44] is there a non-painful way of rebasing a changeset which has multiple dependencies? [20:39:25] tgr: If there is, I haven't found it yet [20:39:40] tgr: multiple dependencies? [20:40:06] tgr: you mean several commits that depend on each other in a line, or an actual merge commit submitted for review? [20:40:09] MatmaRex: parent gerrit changesets [20:40:17] merge commit, yes [20:40:33] a merge commit with nontrivial changes in it [20:40:35] aw. i did that once or twice just for the kicks [20:40:52] i ended up having to redo the commit from scratch when it couldn't be merged both times :( [20:41:09] Gerrit dependencies are like drugs: Just say no kids. It will make you look 20 years older from the stress [20:41:52] particularly if the change has to wait six months for a merge... [20:42:08] the first time I got away with using rebase --onto for each parent and then reapplying the patch, but now even that does not seem to work [20:43:31] (03PS1) 10Jackmcbarn: Add PPFrame::getTTL() and setTTL() [core] - 10https://gerrit.wikimedia.org/r/135887 [20:43:59] I haven't found anything better then git review -d first one you want to rebase, rebase, then upload that. then download the second one, rebase it off the branch the first one is in, upload that, and so on [20:45:46] you can use interactive rebase as long as it is a single dependency chain [20:45:53] works well if the changes are small [20:46:50] rebasing a commit with two parents seems impossible though [20:47:48] (03PS3) 10Chad: WIP: make-wmf-branch to support skin branching as well [tools/release] - 10https://gerrit.wikimedia.org/r/135823 [20:49:18] (03CR) 10Chad: [C: 032 V: 032] Remove reference to non-existent 'modern-desc' message [skins/Modern] - 10https://gerrit.wikimedia.org/r/135828 (owner: 10Bartosz Dziewoński) [20:49:45] (03CR) 10Chad: [C: 032 V: 032] Don't use $dir for __DIR__ [skins/Modern] - 10https://gerrit.wikimedia.org/r/135829 (owner: 10Bartosz Dziewoński) [20:50:23] (03CR) 10Chad: [C: 032 V: 032] Adjust 'remoteBasePath' to the skins/ directory [skins/Modern] - 10https://gerrit.wikimedia.org/r/135830 (owner: 10Bartosz Dziewoński) [20:51:29] (03CR) 10Jackmcbarn: "See I412febf3469503bf4839fb1ef4dca098a8c79457" [core] - 10https://gerrit.wikimedia.org/r/99792 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [20:52:29] (03CR) 10BryanDavis: WIP: make-wmf-branch to support skin branching as well (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/135823 (owner: 10Chad) [20:53:26] 3MediaWiki extensions / 3Popups: Hovercards popping up above cause flickering (because of popping up under the mouse cursor) - 10https://bugzilla.wikimedia.org/65433#c7 (10Quiddity) Created attachment 15507 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15507&action=edit chrome screencast The proble... [20:53:36] (03CR) 10Chad: [C: 032] mediawiki.searchSuggest: Show full article title as a tooltip for each suggestion [core] - 10https://gerrit.wikimedia.org/r/127358 (owner: 10Bartosz Dziewoński) [20:54:32] (03PS1) 10Hashar: Unit tests for some WMF extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135889 [20:54:35] (03CR) 10Chad: [C: 032 V: 032] Adjust 'remoteBasePath' to the skins/ directory [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/135827 (owner: 10Bartosz Dziewoński) [20:55:05] (03CR) 10Chad: [C: 032] Skin: Remove dried up remains of Standard/Classic skin [core] - 10https://gerrit.wikimedia.org/r/135428 (owner: 10Bartosz Dziewoński) [20:57:15] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/AccountAudit] - 10https://gerrit.wikimedia.org/r/135890 [20:57:17] (03Merged) 10jenkins-bot: mediawiki.searchSuggest: Show full article title as a tooltip for each suggestion [core] - 10https://gerrit.wikimedia.org/r/127358 (owner: 10Bartosz Dziewoński) [20:57:19] (03PS4) 10Brian Wolff: Check $wgMaxImageArea before downloading file asset from swift [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135101 (https://bugzilla.wikimedia.org/62306) [20:57:52] (03CR) 10Hashar: [C: 032] Unit tests for some WMF extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135889 (owner: 10Hashar) [20:58:24] (03Merged) 10jenkins-bot: Skin: Remove dried up remains of Standard/Classic skin [core] - 10https://gerrit.wikimedia.org/r/135428 (owner: 10Bartosz Dziewoński) [20:58:33] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/AntiBot] - 10https://gerrit.wikimedia.org/r/135891 [20:58:35] (03PS1) 10Chad: Remove hhvm hourly build, not needed [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135892 [20:58:38] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/135893 [20:58:54] (03CR) 10jenkins-bot: [V: 04-1] Remove hhvm hourly build, not needed [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135892 (owner: 10Chad) [20:58:57] (03Merged) 10jenkins-bot: Unit tests for some WMF extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135889 (owner: 10Hashar) [20:59:50] (03PS1) 10Chad: Removing hhvm hourly build, not needed [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135894 [20:59:53] (03CR) 10Hashar: "recheck" [extensions/AccountAudit] - 10https://gerrit.wikimedia.org/r/135890 (owner: 10Hashar) [20:59:57] (03CR) 10Hashar: "recheck" [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/135893 (owner: 10Hashar) [21:00:01] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/AccountAudit] - 10https://gerrit.wikimedia.org/r/135890 (owner: 10Hashar) [21:00:05] (03CR) 10Hashar: "recheck" [extensions/AntiBot] - 10https://gerrit.wikimedia.org/r/135891 (owner: 10Hashar) [21:00:22] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/135893 (owner: 10Hashar) [21:00:48] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Calendar] - 10https://gerrit.wikimedia.org/r/135895 [21:00:56] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/135896 [21:01:04] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/135897 [21:01:09] (03Abandoned) 10Chad: Remove hhvm hourly build, not needed [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135892 (owner: 10Chad) [21:01:13] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CharInsert] - 10https://gerrit.wikimedia.org/r/135898 [21:01:21] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/135899 [21:01:34] (03PS6) 10Bartosz Dziewoński: Officially deprecate skin autodiscovery [core] - 10https://gerrit.wikimedia.org/r/135429 (https://bugzilla.wikimedia.org/65748) [21:01:36] (03PS5) 10Bartosz Dziewoński: Don't use autodiscovery for core skins, move them to separate directories [core] - 10https://gerrit.wikimedia.org/r/135383 (https://bugzilla.wikimedia.org/65748) [21:01:38] (03PS3) 10Bartosz Dziewoński: [DO NOT MERGE] Completely remove skin autodiscovery [core] - 10https://gerrit.wikimedia.org/r/135439 (https://bugzilla.wikimedia.org/65748) [21:01:50] (03CR) 10Bartosz Dziewoński: "Okay, let's do that." [core] - 10https://gerrit.wikimedia.org/r/135384 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [21:01:53] flood [21:02:10] (03Abandoned) 10Bartosz Dziewoński: Move core skins to separate directories [core] - 10https://gerrit.wikimedia.org/r/135384 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [21:02:19] Vulpix: i'm just warming up. [21:02:43] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ClientSide] - 10https://gerrit.wikimedia.org/r/135900 [21:02:46] (03CR) 10Bartosz Dziewoński: "Rebased against the change that moved Modern and CologneBlue out of core." [core] - 10https://gerrit.wikimedia.org/r/135383 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [21:02:51] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/135901 [21:02:54] (03CR) 10Bartosz Dziewoński: "Rebased against the change that moved Modern and CologneBlue out of core." [core] - 10https://gerrit.wikimedia.org/r/135429 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [21:02:58] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CommunityVoice] - 10https://gerrit.wikimedia.org/r/135902 [21:03:05] (03PS5) 10Rillke: Add "chemical" major MIME type to the image tables [core] - 10https://gerrit.wikimedia.org/r/135756 [21:03:07] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/135903 [21:03:09] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/135904 [21:03:14] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/135905 [21:03:22] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CustomData] - 10https://gerrit.wikimedia.org/r/135906 [21:03:30] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/135907 [21:03:38] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/135908 [21:03:45] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/135909 [21:03:48] (03PS1) 10MengWu: SyntaxHighlighting or reparsing with given tag function [extensions/Gitweb] - 10https://gerrit.wikimedia.org/r/135910 [21:03:53] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/DoubleWiki] - 10https://gerrit.wikimedia.org/r/135911 [21:04:01] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/DynamicSidebar] - 10https://gerrit.wikimedia.org/r/135912 [21:04:09] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/135913 [21:04:14] (03CR) 10Chad: "Already removed from jenkins, slave decommissioned. Just tidying up here." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135894 (owner: 10Chad) [21:04:17] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/135914 [21:04:19] (03Restored) 10Hashar: Remove hhvm hourly build, not needed [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135892 (owner: 10Chad) [21:04:24] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/135915 [21:04:32] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/135916 [21:04:40] (03Abandoned) 10Hashar: Remove hhvm hourly build, not needed [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135892 (owner: 10Chad) [21:04:43] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/135917 [21:04:47] (03PS5) 10Krinkle: Html: Throw exception if array is used for an attribute not supporting it [core] - 10https://gerrit.wikimedia.org/r/132617 (owner: 10Thiemo Mättig (WMDE)) [21:04:49] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/135918 [21:04:56] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/135919 [21:05:04] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/135920 [21:05:06] (03Abandoned) 10Brian Wolff: Don't insert timestamp if parsing time failed [extensions/Popups] - 10https://gerrit.wikimedia.org/r/114710 (owner: 10Brian Wolff) [21:05:53] (03CR) 10Mattflaschen: "Minor ambiguity in the commit message" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/122838 (https://bugzilla.wikimedia.org/63343) (owner: 10Phuedx) [21:05:56] (03CR) 10Krinkle: Html: Throw exception if array is used for an attribute not supporting it (032 comments) [core] - 10https://gerrit.wikimedia.org/r/132617 (owner: 10Thiemo Mättig (WMDE)) [21:06:21] (03CR) 10Krinkle: [C: 031] "Made commit subject describe the actual change" [core] - 10https://gerrit.wikimedia.org/r/132617 (owner: 10Thiemo Mättig (WMDE)) [21:06:27] (03CR) 10Hashar: [C: 032] "Thank you Chad!" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135894 (owner: 10Chad) [21:07:02] (03CR) 10Bartosz Dziewoński: [C: 032] "Works as advertised. Let's do this! :)" [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [21:07:19] (03CR) 10Bartosz Dziewoński: [V: 032] use imagemap class for HTML rendering [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [21:09:36] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/CommunityVoice] - 10https://gerrit.wikimedia.org/r/135902 (owner: 10Hashar) [21:09:38] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/135905 (owner: 10Hashar) [21:09:40] (03CR) 10Chad: WIP: make-wmf-branch to support skin branching as well (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/135823 (owner: 10Chad) [21:10:55] (03Merged) 10jenkins-bot: Removing hhvm hourly build, not needed [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135894 (owner: 10Chad) [21:12:57] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/135897 (owner: 10Hashar) [21:13:01] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/AntiBot] - 10https://gerrit.wikimedia.org/r/135891 (owner: 10Hashar) [21:13:05] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Calendar] - 10https://gerrit.wikimedia.org/r/135895 (owner: 10Hashar) [21:13:08] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/135896 (owner: 10Hashar) [21:13:44] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CharInsert] - 10https://gerrit.wikimedia.org/r/135898 (owner: 10Hashar) [21:13:51] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/135899 (owner: 10Hashar) [21:13:57] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ClientSide] - 10https://gerrit.wikimedia.org/r/135900 (owner: 10Hashar) [21:14:04] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/135901 (owner: 10Hashar) [21:14:11] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/135903 (owner: 10Hashar) [21:14:18] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/135904 (owner: 10Hashar) [21:15:34] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CustomData] - 10https://gerrit.wikimedia.org/r/135906 (owner: 10Hashar) [21:15:40] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/135907 (owner: 10Hashar) [21:15:41] 3Wikimedia / 3Site requests: Enable FlaggedRevs extension on ckb.wikipedia - 10https://bugzilla.wikimedia.org/65809 (10Calak) [21:15:42] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/135908 (owner: 10Hashar) [21:15:48] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/135909 (owner: 10Hashar) [21:15:52] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/DoubleWiki] - 10https://gerrit.wikimedia.org/r/135911 (owner: 10Hashar) [21:15:57] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/DynamicSidebar] - 10https://gerrit.wikimedia.org/r/135912 (owner: 10Hashar) [21:16:02] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/135913 (owner: 10Hashar) [21:16:07] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/135914 (owner: 10Hashar) [21:16:12] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/135915 (owner: 10Hashar) [21:16:16] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/135916 (owner: 10Hashar) [21:16:21] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/135917 (owner: 10Hashar) [21:16:25] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/135918 (owner: 10Hashar) [21:16:29] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/135919 (owner: 10Hashar) [21:16:34] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/135920 (owner: 10Hashar) [21:17:44] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/AccountAudit] - 10https://gerrit.wikimedia.org/r/135890 [21:17:47] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/AccountAudit] - 10https://gerrit.wikimedia.org/r/135890 (owner: 10Hashar) [21:18:29] * Nemo_bis wonders how korma.wmflabs.org displays such storms :) [21:18:56] 3Wikimedia / 3Git/Gerrit: Gerrit does not show size differences for binaries - 10https://bugzilla.wikimedia.org/65844#c1 (10Matthew Flaschen) Already upstream at https://code.google.com/p/gerrit/issues/detail?id=830 [21:20:41] AaronSchulz, do you have a moment to chat about the job queue runner? [21:22:57] 3MediaWiki / 3General/Unknown: Tracking bug (tracking) - 10https://bugzilla.wikimedia.org/2007 (10Antoine "hashar" Musso) [21:27:03] (03PS2) 10Bartosz Dziewoński: jquery.suggestions: Handle CSS ellipsis better for IE [core] - 10https://gerrit.wikimedia.org/r/135309 (https://bugzilla.wikimedia.org/65224) [21:28:59] 3MediaWiki extensions / 3[other]: AccountAudit does not pass Jenkins unit tests - 10https://bugzilla.wikimedia.org/65875 (10Antoine "hashar" Musso) 3NEW p:3Unprio s:3normal a:3None 00:00:01.863 A database query error has occurred. 00:00:01.864 Query: CREATE TABLE accountaudit_login ( 00:00:01.865 aa... [21:28:59] (03CR) 10Bartosz Dziewoński: "It's locally in the .js file because I don't want to permanently apply position:absolute to all spans that might appear inside .suggestion" [core] - 10https://gerrit.wikimedia.org/r/135309 (https://bugzilla.wikimedia.org/65224) (owner: 10Bartosz Dziewoński) [21:29:29] 3MediaWiki extensions / 3[other]: CommunityVoice does not pass Jenkins unit tests - 10https://bugzilla.wikimedia.org/65876 (10Antoine "hashar" Musso) 3NEW p:3Unprio s:3normal a:3None 00:00:02.153 A database query error has occurred. 00:00:02.155 Query: CREATE TABLE /*$wgDBPrefix*/cv_ratings_votes (... [21:29:44] (03CR) 10Bartosz Dziewoński: "It's probably possible to write tests, but a) it would really suck (it might be easier to do them as browser tests in Selenium or whatever" [core] - 10https://gerrit.wikimedia.org/r/135309 (https://bugzilla.wikimedia.org/65224) (owner: 10Bartosz Dziewoński) [21:30:58] 3MediaWiki extensions / 3CreditsSource: CreditsSource does not pass Jenkins unit tests - 10https://bugzilla.wikimedia.org/65877 (10Antoine "hashar" Musso) 3NEW p:3Unprio s:3normal a:3None The extension has a bunch of database related error (Jenkins uses sqlite). https://integration.wikimedia.org/ci/... [21:33:56] (03PS1) 10Hashar: Ignore some extensions tests results [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135936 (https://bugzilla.wikimedia.org/65875) [21:35:23] (03CR) 10Hashar: [C: 032] Ignore some extensions tests results [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135936 (https://bugzilla.wikimedia.org/65875) (owner: 10Hashar) [21:35:39] (03Merged) 10jenkins-bot: Ignore some extensions tests results [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135936 (https://bugzilla.wikimedia.org/65875) (owner: 10Hashar) [21:36:42] (03PS3) 10Bartosz Dziewoński: jquery.suggestions: Handle CSS ellipsis better for IE [core] - 10https://gerrit.wikimedia.org/r/135309 (https://bugzilla.wikimedia.org/65224) [21:36:56] 3MediaWiki extensions / 3[other]: AccountAudit does not pass Jenkins unit tests - 10https://bugzilla.wikimedia.org/65875 (10Antoine "hashar" Musso) 5PAT>3NEW [21:36:57] (03CR) 10Bartosz Dziewoński: "Should be better now." [core] - 10https://gerrit.wikimedia.org/r/135309 (https://bugzilla.wikimedia.org/65224) (owner: 10Bartosz Dziewoński) [21:37:11] 3MediaWiki extensions / 3CreditsSource: CreditsSource does not pass Jenkins unit tests - 10https://bugzilla.wikimedia.org/65877 (10Antoine "hashar" Musso) 5PAT>3NEW [21:37:12] 3MediaWiki extensions / 3[other]: CommunityVoice does not pass Jenkins unit tests - 10https://bugzilla.wikimedia.org/65876 (10Antoine "hashar" Musso) 5PAT>3NEW [21:37:22] (03CR) 10Hashar: "recheck" [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/135905 (owner: 10Hashar) [21:37:41] 3MediaWiki / 3Search: Search bar title autocompletion no longer expands width as necessary [IE6-11] - 10https://bugzilla.wikimedia.org/65224 (10Bartosz Dziewoński) p:5Normal>3High [21:37:41] (03CR) 10Hashar: "recheck" [extensions/AccountAudit] - 10https://gerrit.wikimedia.org/r/135890 (owner: 10Hashar) [21:37:47] (03CR) 10Hashar: "recheck" [extensions/CommunityVoice] - 10https://gerrit.wikimedia.org/r/135902 (owner: 10Hashar) [21:38:18] (03Abandoned) 10Bartosz Dziewoński: (Bug 36231) Fixed the issue of table headers getting left aligned on enabling "Justify Paragraphs" [core] - 10https://gerrit.wikimedia.org/r/55517 (owner: 10Rahul21) [21:38:28] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/135905 (owner: 10Hashar) [21:38:34] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/AccountAudit] - 10https://gerrit.wikimedia.org/r/135890 (owner: 10Hashar) [21:38:39] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CommunityVoice] - 10https://gerrit.wikimedia.org/r/135902 (owner: 10Hashar) [21:41:53] MaxSem: Do you know who I would bug about getting mobile frontend to redirect pageviews (of the OAuth special page) to the mobile domain? [21:43:22] (03PS1) 10Aaron Schulz: A few small timestamp fixes/cleanups [extensions/Petition] - 10https://gerrit.wikimedia.org/r/135940 [21:44:35] (explained in person) [21:45:19] (03PS6) 10Phuedx: Make ResourceLoaderFileModule#getAllStyleFiles include all skin styles [core] - 10https://gerrit.wikimedia.org/r/122838 (https://bugzilla.wikimedia.org/63343) [21:46:33] jgonera: hi :) I take it that you didn't have a chance to review that css patch yet, right? [21:46:50] if you have a couple minutes we could go over it quickly [21:46:53] waldir, no, I haven't, sorry [21:47:13] let me finish one thing, 10 minutes [21:47:18] sure :D [21:48:10] (03CR) 10Phuedx: Make ResourceLoaderFileModule#getAllStyleFiles include all skin styles (031 comment) [core] - 10https://gerrit.wikimedia.org/r/122838 (https://bugzilla.wikimedia.org/63343) (owner: 10Phuedx) [21:48:51] (03PS1) 10Yuvipanda: Do not override MobileFrontend fonts [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/135941 [21:48:59] legoktm: ^? :) [21:49:26] 3MediaWiki extensions / 3OAuth: OAuth and mobile redirection do not play nicely together - 10https://bugzilla.wikimedia.org/60034#c4 (10Chris Steipp) Jarry1250, let me make sure I understand the issue. When authorizing with Widar (Erik's link in comment 3), Widar is sending the user to www.mediawiki.org/w/i... [21:49:42] (03PS17) 10MarkTraceur: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) [21:50:45] (03PS1) 10Ori.livneh: Fix leak in LuaSandbox::setCPULimit [php/luasandbox] - 10https://gerrit.wikimedia.org/r/135942 (https://bugzilla.wikimedia.org/65796) [21:51:40] (03PS2) 10Ori.livneh: Fix leak in LuaSandbox::setCPULimit [php/luasandbox] - 10https://gerrit.wikimedia.org/r/135942 (https://bugzilla.wikimedia.org/65796) [21:52:41] 3MediaWiki extensions / 3OAuth: OAuth and mobile redirection do not play nicely together - 10https://bugzilla.wikimedia.org/60034#c5 (10Max Semenik) (In reply to Chris Steipp from comment #4) > In Widar's case, this bug is because Widar redirects the user to > /w/index.php, and MobileFrontend specifically do... [21:52:56] 3MediaWiki extensions / 3Petition: Performance review of Petition extension before WMF deployment - 10https://bugzilla.wikimedia.org/65851#c2 (10Aaron Schulz) A few questions: a) How many rows per petition name might we aspect roughly b) Ditto per rows in the whole table (the CSV dumps this) c) Will the p... [21:53:42] ori: I posted some comments on bug 65851 [21:54:04] * AaronSchulz feels like there was another extension [21:54:39] thank you [21:57:55] <^d> That's a duplicate bug? [21:57:58] <^d> I left comments on one. [21:58:35] waldir, ok, I'm here [21:58:45] yay [21:58:49] the link: https://gerrit.wikimedia.org/r/#/c/30641/ [21:59:09] yeah, on it [21:59:17] you might want to check out the previous reviews [21:59:59] the latest patchset didn't change that much from the versions that were endored by the other reviewers, it was essentially a rebase [22:00:10] <^d> Oh, silly dependent bugs. [22:00:22] ok [22:00:25] ori: lol on that last sentence [22:00:30] to test this I should just check print preview? [22:00:40] :) [22:01:36] (03PS2) 10Jackmcbarn: Add PPFrame::getTTL() and setTTL() [core] - 10https://gerrit.wikimedia.org/r/135887 [22:03:53] (03CR) 10MarkAHershberger: [C: 032] Add SelfLinkBeginHook [core] - 10https://gerrit.wikimedia.org/r/124149 (https://bugzilla.wikimedia.org/63592) (owner: 10Cicalese) [22:04:30] waldir, I agree with Hoo man that /** is enough, I wouldn't make exceptions [22:04:41] so is it written from scratch or rebased? [22:06:01] ok, I can change it back to /**. And It was rebased, painfully so, but rebased :) [22:07:40] (03Merged) 10jenkins-bot: Add SelfLinkBeginHook [core] - 10https://gerrit.wikimedia.org/r/124149 (https://bugzilla.wikimedia.org/63592) (owner: 10Cicalese) [22:10:02] jgonera: sorry, I missed your previous message on how to test it. yeah, the print preview is the only place where this stylesheet applies, afaik [22:11:27] (03CR) 10MarkTraceur: [C: 04-1] "I have a big list of worrisome things I saw in the rebase that I still want to address, hold on." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [22:11:56] (03CR) 10MarkTraceur: "Actually...let's not make this any bigger. Ready for review." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [22:15:46] waldir, ok, change the comments to /** and I'll merge it [22:16:05] I think that file should be rewritten from scratch actually ;) probably with some design input [22:16:18] but that's still an improvement [22:16:30] you mean actually making changes in the visual output? [22:16:39] yeah, but that's a separate issue [22:16:41] sure [22:17:04] in fact, my motivation for doing this was precisely improving a small rendering issue with external links :) [22:17:27] I decided to clean it up a bit first... bad idea xD [22:17:41] haha [22:18:09] ok, let's merge it, it was started before I even joined WMF ;) [22:20:58] (03CR) 10MaxSem: [C: 032] twiddle file modes [vagrant] - 10https://gerrit.wikimedia.org/r/135883 (owner: 10Awight) [22:21:15] (03Merged) 10jenkins-bot: twiddle file modes [vagrant] - 10https://gerrit.wikimedia.org/r/135883 (owner: 10Awight) [22:22:20] (03CR) 10MaxSem: Modify settings for PagedTiffHandler role to match WMF settings better (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/135879 (owner: 10Gergő Tisza) [22:23:33] jgonera: this machine isn't set up for mw development, I'm configuring it. Can you wait a minute or two? [22:24:22] I can wait a few minutes, but not too much, I'm super sleepy already (past midnight here) [22:24:59] ugh, it's rather slow downloading code mw... still at 2% :( [22:25:20] what if you made the asterisk change yourself, would that be ok? [22:25:30] waldir: First time always the slowest, since that downloads the whole thing [22:26:21] bawolff: yeah, i know... but I was under the impression that I had already set this machine up for mw dev >:( [22:26:57] waldir: You only need to add an asterik? What change is it? I could probably do that [22:27:03] :D [22:27:09] https://gerrit.wikimedia.org/r/#/c/30641/ [22:27:29] the lines with /********** should be changed to /** [22:29:59] 3MediaWiki / 3Unit tests: Unit tests fail if Site is named 'Foo' - 10https://bugzilla.wikimedia.org/65879 (10Jeff Janes) 3UNC p:3Unprio s:3normal a:3None If you name your wiki site 'Foo', as I usually did when making a wiki for testing purposes, the unit tests fail. It fails because tests/phpunit/in... [22:30:01] (I'm at 50% now.... woah didn't remember it was*this* slow!) [22:30:30] waldir, I'll brush my teeth and come back when I'm done ;) [22:30:42] jgonera: ok :) [22:34:20] (03CR) 10MaxSem: [C: 032] Modify settings for PagedTiffHandler role to match WMF settings better [vagrant] - 10https://gerrit.wikimedia.org/r/135879 (owner: 10Gergő Tisza) [22:34:25] (03Merged) 10jenkins-bot: Modify settings for PagedTiffHandler role to match WMF settings better [vagrant] - 10https://gerrit.wikimedia.org/r/135879 (owner: 10Gergő Tisza) [22:34:51] eh, wasn't intending to merge that [22:34:56] oh well:P [22:36:25] waldir: Sorry got distracted. I'll do that now [22:36:54] bawolff: much appreciated, considered I'm still at 85% :P [22:39:25] (03PS8) 10Brian Wolff: Reorganize commonPrint.css [core] - 10https://gerrit.wikimedia.org/r/30641 (owner: 10Waldir) [22:39:42] done [22:39:47] bawolff: yay, thanks!! [22:40:34] jgonera: shall we get this merged? :) [22:41:30] (03CR) 10Waldir: [C: 031] "lgtm. it's now or never! :D" [core] - 10https://gerrit.wikimedia.org/r/30641 (owner: 10Waldir) [22:45:43] (03CR) 10Tim Starling: "I did have something like this in my working copy, but the test case still fails." [php/luasandbox] - 10https://gerrit.wikimedia.org/r/135942 (https://bugzilla.wikimedia.org/65796) (owner: 10Ori.livneh) [22:46:08] (03PS1) 10Yuvipanda: Re-use Link styles from MobileFrontend [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/135954 [22:48:41] (03CR) 10Brion VIBBER: [C: 032 V: 032] "looks legit :D" [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/135941 (owner: 10Yuvipanda) [22:51:42] (03CR) 10Tim Starling: [C: 04-1] "I think it is better as it is -- it is easier to install for inexperienced users." [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/124324 (https://bugzilla.wikimedia.org/43389) (owner: 10John F. Lewis) [22:52:59] (03Abandoned) 10John F. Lewis: Remove default group assignment [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/124324 (https://bugzilla.wikimedia.org/43389) (owner: 10John F. Lewis) [22:53:41] 3MediaWiki extensions / 3CheckUser: Group assignment should be removed and handled in LocalSettings.php - 10https://bugzilla.wikimedia.org/43389#c4 (10John F. Lewis) 5PAT>3RES/WON See the patch. [22:57:25] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Note: to test, use load.php?modules=mobile.app.pagestyle&only=styles" [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/135954 (owner: 10Yuvipanda) [23:04:07] (03CR) 10JGonera: [V: 032] Reorganize commonPrint.css [core] - 10https://gerrit.wikimedia.org/r/30641 (owner: 10Waldir) [23:04:14] (03CR) 10JGonera: [C: 032] Reorganize commonPrint.css [core] - 10https://gerrit.wikimedia.org/r/30641 (owner: 10Waldir) [23:07:52] (03Merged) 10jenkins-bot: Reorganize commonPrint.css [core] - 10https://gerrit.wikimedia.org/r/30641 (owner: 10Waldir) [23:12:41] 3Wikimedia / 3Extension setup: Modern and Cologne Blue should remain in Preferences/Appearance after removal from core - 10https://bugzilla.wikimedia.org/65868#c3 (10Bartosz Dziewoński) …and also https://gerrit.wikimedia.org/r/#/c/135927/ about the deployment. https://gerrit.wikimedia.org/r/#/c/135827/ and... [23:14:38] (03PS1) 10Gergő Tisza: Make JSHint enforce ES3 compatibility [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/135961 [23:14:49] (03PS1) 10MarkTraceur: Enforce es3 compatibility for UW [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/135962 [23:15:39] (03CR) 10Bartosz Dziewoński: "Followups: https://gerrit.wikimedia.org/r/135822 https://gerrit.wikimedia.org/r/135828 https://gerrit.wikimedia.org/r/135829 https://gerri" [skins/Modern] - 10https://gerrit.wikimedia.org/r/119885 (owner: 10Jdlrobson) [23:15:56] (03CR) 10Bartosz Dziewoński: "Followup: https://gerrit.wikimedia.org/r/135827" [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/119884 (owner: 10Jdlrobson) [23:16:44] (03Abandoned) 10Gergő Tisza: Make JSHint enforce ES3 compatibility [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/135961 (owner: 10Gergő Tisza) [23:16:49] (03PS2) 10Gergő Tisza: Enforce es3 compatibility for UW [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/135962 (owner: 10MarkTraceur) [23:17:25] (03CR) 10Gergő Tisza: [C: 032] Enforce es3 compatibility for UW [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/135962 (owner: 10MarkTraceur) [23:17:50] (03Merged) 10jenkins-bot: Enforce es3 compatibility for UW [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/135962 (owner: 10MarkTraceur) [23:20:54] (03CR) 10Spage: "FWIW this works! I documented it at https://www.mediawiki.org/wiki/Extension:Mantle#Templates." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/131085 (owner: 10Spage) [23:23:50] (03CR) 10MarkTraceur: [C: 04-1] "Error on upload completion; "upload more files" is apparently broken now (was it before?)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [23:24:01] (03PS18) 10MarkTraceur: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) [23:24:47] (03PS19) 10MarkTraceur: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) [23:27:11] (03PS5) 10Krinkle: Follow-up I7b49a6dd0: Fix page curation bar reappearing after VE closes [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/135587 (https://bugzilla.wikimedia.org/65702) (owner: 10Alex Monk) [23:27:19] (03CR) 10Krinkle: [C: 032] Follow-up I7b49a6dd0: Fix page curation bar reappearing after VE closes [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/135587 (https://bugzilla.wikimedia.org/65702) (owner: 10Alex Monk) [23:27:24] (03Merged) 10jenkins-bot: Follow-up I7b49a6dd0: Fix page curation bar reappearing after VE closes [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/135587 (https://bugzilla.wikimedia.org/65702) (owner: 10Alex Monk) [23:34:26] (03CR) 10Krinkle: Support file extensions in ResourceLoaderTemplateModule (031 comment) [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/130998 (owner: 10Jdlrobson) [23:35:15] (03CR) 10GWicke: "jackmcbarn & I discussed this a bit further. We came to the following conclusion:" [core] - 10https://gerrit.wikimedia.org/r/99792 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [23:37:31] (03CR) 10Krinkle: Massive refactor (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [23:39:59] (03CR) 10Krinkle: Massive refactor (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [23:45:19] (03PS1) 10Chad: Added new Authentication method to the swift service : Keystone Auth, TempAuth. All now managed with a factory. [search/repository-swift] - 10https://gerrit.wikimedia.org/r/135968 [23:45:21] (03PS1) 10Chad: [maven-release-plugin] prepare release v0.4 [search/repository-swift] - 10https://gerrit.wikimedia.org/r/135969 [23:45:23] (03PS1) 10Chad: [maven-release-plugin] prepare for next development iteration [search/repository-swift] - 10https://gerrit.wikimedia.org/r/135970 [23:45:41] (03CR) 10Chad: [C: 032 V: 032] Added new Authentication method to the swift service : Keystone Auth, TempAuth. All now managed with a factory. [search/repository-swift] - 10https://gerrit.wikimedia.org/r/135968 (owner: 10Chad) [23:45:56] 3MediaWiki / 3General/Unknown: Calculated Age of persons can become outdated until next cache purge - 10https://bugzilla.wikimedia.org/49803#c11 (10Gabriel Wicke) Jackmcbarn created a very related patch at https://gerrit.wikimedia.org/r/#/c/135887/ . It adds the ability to set a TTL per transclusion, which i... [23:46:06] (03CR) 10Chad: [C: 032 V: 032] [maven-release-plugin] prepare release v0.4 [search/repository-swift] - 10https://gerrit.wikimedia.org/r/135969 (owner: 10Chad) [23:46:08] (03CR) 10Chad: [C: 032 V: 032] [maven-release-plugin] prepare for next development iteration [search/repository-swift] - 10https://gerrit.wikimedia.org/r/135970 (owner: 10Chad) [23:50:24] (03CR) 10GWicke: "This is very related to bug 49803. Might be worth mentioning in the commit summary." [core] - 10https://gerrit.wikimedia.org/r/135887 (owner: 10Jackmcbarn) [23:52:08] (03CR) 10FunPika: [C: 04-1] "I'm going to need to rebase this because of recent changes to Linker.php and make a couple of fixes to ensure that I don't introduce a new" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/127671 (https://bugzilla.wikimedia.org/27417) (owner: 10FunPika) [23:52:16] (03CR) 10Krinkle: Massive refactor (035 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [23:53:04] AaronSchulz, re https://gerrit.wikimedia.org/r/#/c/135875/ : is it clear what's causing the underlying issue? [23:58:38] ori: https://gerrit.wikimedia.org/r/135966