[00:00:18] I don't think lua is as popular a language as the others [00:01:40] (03PS10) 10Jackmcbarn: Keep modules' export tables inside Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127458 (https://bugzilla.wikimedia.org/64141) [00:02:38] people put the return type as the first word of the @return, but doxygen doesn't support that [00:02:43] so the result is something like https://doc.wikimedia.org/mediawiki-core/master/php/html/classArticle.html#a430b2be1e05f567e4d2b23243dbf4bda [00:03:04] @return is just a paragraph of plain text [00:04:43] or https://doc.wikimedia.org/mediawiki-core/master/php/html/classMWTimestamp.html#aa09f06a2f3a5bf554f6387a4f37e339a [00:04:58] @param supports a type, @return doesn't [00:05:16] using @return the "right" way seems to be the exception then (at least for us) [00:05:41] it's not a big deal because everyone knows what it means (and in my case there's no doxygen anyway, and not likely to be any any time soon) [00:06:08] (03PS8) 10Bartosz Dziewoński: Move core skins to separate directories [core] - 10https://gerrit.wikimedia.org/r/135384 (https://bugzilla.wikimedia.org/65748) [00:06:14] hmmm, maybe there was some talk of following the conventions of a lua doc formatter... [00:06:37] http://keplerproject.github.io/luadoc/manual.html#tags [00:06:44] "@return [00:06:46] Describe a returning value of the function. Since Lua can return multiple values, this tag should appear more than once." [00:06:56] so you are doing the right thing if we are following that [00:10:30] (03CR) 10Tim Starling: [C: 032] Keep modules' export tables inside Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127458 (https://bugzilla.wikimedia.org/64141) (owner: 10Jackmcbarn) [00:11:00] (03PS5) 10Bartosz Dziewoński: Officially deprecate skin autodiscovery [core] - 10https://gerrit.wikimedia.org/r/135429 (https://bugzilla.wikimedia.org/65748) [00:11:02] (03PS9) 10Bartosz Dziewoński: Move core skins to separate directories [core] - 10https://gerrit.wikimedia.org/r/135384 (https://bugzilla.wikimedia.org/65748) [00:11:04] (03PS2) 10Bartosz Dziewoński: [DO NOT MERGE] Completely remove skin autodiscovery [core] - 10https://gerrit.wikimedia.org/r/135439 (https://bugzilla.wikimedia.org/65748) [00:12:05] (03Merged) 10jenkins-bot: Keep modules' export tables inside Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127458 (https://bugzilla.wikimedia.org/64141) (owner: 10Jackmcbarn) [00:12:13] TimStarling: thanks! [00:13:18] 3MediaWiki extensions / 3Scribunto: Metatables don't work from wikitext (__index) - 10https://bugzilla.wikimedia.org/64141#c4 (10Jackmcbarn) 5PAT>3RES/FIX This will be live on all WMF wikis starting June 5th. [00:13:32] (03PS3) 10Brian Wolff: Check $wgMaxImageArea before downloading file asset from swift [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135101 (https://bugzilla.wikimedia.org/62306) [00:16:34] (03PS3) 10Bartosz Dziewoński: Officially deprecate skin autodiscovery [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/135427 (https://bugzilla.wikimedia.org/65748) [00:22:36] 3MediaWiki extensions / 3WikidataRepo: string value input with whitespace or return characters - 10https://bugzilla.wikimedia.org/65786 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs i am entering string values and sometimes they get submitted to the api for save as''fsfs\n' and 'fsfs ' with trai... [00:23:33] 3MediaWiki extensions / 3WikidataRepo: string value input with whitespace or return characters - 10https://bugzilla.wikimedia.org/65786#c1 (10Aude) was bug 63301 completely fixed? or additional issues? i still experience the issue on master (and on wikidata [00:30:22] 3MediaWiki extensions / 3WikidataRepo: string value input with whitespace or return characters - 10https://bugzilla.wikimedia.org/65786#c2 (10Aude) looks like we have "data-values/value-view": "~0.5.0" in wikibase composer.json while the value view patch for bug 63301 is in 0.6 (dev) I also think these perh... [00:32:59] (03CR) 10Brian Wolff: "Re Gilles" (032 comments) [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/86413 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [00:41:06] 3MediaWiki extensions / 3Scribunto: Exception: Parameter 2 to ScribuntoHooks::formatLimitData() expected to be a reference, value given - 10https://bugzilla.wikimedia.org/65787 (10Bob Dye) 3UNC p:3Unprio s:3normal a:3None [aa3f4156] /wiki/Main_page Exception from line 212 of /var/www/html/mediawiki/i... [00:42:20] 3MediaWiki extensions / 3WikidataClient: lua and parser tests for mismatching data type / value errors - 10https://bugzilla.wikimedia.org/65788 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs we need tests for lua and property parser function to cover formatting and handling of mismatching data ty... [00:43:37] bawolff: re https://gerrit.wikimedia.org/r/#/c/123516/, see https://en.wikipedia.org/wiki/User:Jackmcbarn/Pages_using_msgnw [00:46:57] (03CR) 10Bartosz Dziewoński: [DO NOT MERGE] Completely remove skin autodiscovery (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135439 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [00:47:35] (03CR) 10Jackmcbarn: "I searched the latest enwiki database dump for "msgnw". See https://en.wikipedia.org/wiki/User:Jackmcbarn/Pages_using_msgnw for the result" [core] - 10https://gerrit.wikimedia.org/r/123516 (https://bugzilla.wikimedia.org/22683) (owner: 10Jackmcbarn) [00:52:59] (03PS1) 10Legoktm: Allow more flexibility in RC feeds [core] - 10https://gerrit.wikimedia.org/r/135501 [00:53:35] (03CR) 10Legoktm: "This is for I0662149a4f975fc998f723b856f13009435b0eba in Flow." [core] - 10https://gerrit.wikimedia.org/r/135501 (owner: 10Legoktm) [00:53:44] (03PS1) 10Legoktm: Provide a comment for the RCFeeds [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135502 [01:12:21] 3MediaWiki / 3Maintenance scripts: populateRevisionLength.php displays "Content of archive unavailable" error when updating ar_len field with text stored in archive table - 10https://bugzilla.wikimedia.org/65765#c2 (10Mark A. Hershberger) I'm trying to reproduce this and having trouble. It doesn't appear to... [01:20:04] 3MediaWiki-Vagrant: InstantCommons no longer working - 10https://bugzilla.wikimedia.org/54202#c6 (10Erik Moeller) In the latest MediaWiki Vagrant with the multimedia role enabled, InstantCommons does not successfully generate thumbnails for me. The issue goes away if I comment out the thumb-php-on-404 handler,... [01:20:07] (03PS2) 10Legoktm: Allow more flexibility in RC feeds [core] - 10https://gerrit.wikimedia.org/r/135501 [01:26:21] (03CR) 10Springle: Allow filtering log entries by namespace (API) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135283 (owner: 10Jackmcbarn) [01:26:59] thanks [01:31:18] 3MediaWiki / 3General/Unknown: HHVM goes bonkers in HtmlFormatter - 10https://bugzilla.wikimedia.org/65703#c3 (10Tim Starling) I was able to reproduce it with: mwscript eval.php --wiki=eswiktionary $u = new CirrusSearch\Updater; $u->updateFromTitle(Title::newFromText('Etchebarne')); [01:33:07] (03CR) 10BryanDavis: Refactor doc publishing from labs (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 (owner: 10Hashar) [01:33:27] (03CR) 10Daniel Friesen: [DO NOT MERGE] Completely remove skin autodiscovery (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135439 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [01:33:34] bd808|BUFFER: you should move your labs-vagrant doc to the official wikitech page at some poihnt :) [01:35:04] 3MediaWiki extensions / 3WikidataRepo: UI freezes when saving too many snaks - 10https://bugzilla.wikimedia.org/64651#c2 (10Aude) 5NEW>3PAT gah, yet another related bug https://gerrit.wikimedia.org/r/#/c/135498/ [01:38:48] 3MediaWiki / 3Special pages: When Special:WhatLinksHere is included and a valid title not provided, a form is shown - 10https://bugzilla.wikimedia.org/65779#c1 (10Jackmcbarn) This doesn't seem like a bug to me. Any other behavior would be less useful. [01:40:00] (03CR) 10Parent5446: [C: 032] Make abstract Config class truly implementation-agnostic [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [01:43:41] (03Merged) 10jenkins-bot: Make abstract Config class truly implementation-agnostic [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [01:50:25] (03PS1) 10Parent5446: Make abstract Config class truly implementation-agnostic [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/135504 [01:51:29] (03CR) 10Daniel Friesen: "Since we're moving the class file why don't we do the splitting into two class files in this commit? I don't mind that change and it makes" [core] - 10https://gerrit.wikimedia.org/r/135384 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [01:54:03] 3MediaWiki / 3Skin and page rendering: Deprecate and remove skin autodiscovery (autoloading) mechanism - 10https://bugzilla.wikimedia.org/65748 (10Andre Klapper) p:5Unprio>3Normal [01:55:05] 3MediaWiki / 3Database: SecurePoll PurgePrivateVoteData missing tables in dberror log - 10https://bugzilla.wikimedia.org/65790 (10Sean Pringle) 3NEW p:3Unprio s:3normal a:3None These are trickling into dberror.log: Tue May 27 1:47:24 UTC 2014 terbium zhwikivoyage PurgePrivateVoteData::execute10.64.1... [01:55:18] 3MediaWiki / 3Database: SecurePoll PurgePrivateVoteData missing tables in dberror log - 10https://bugzilla.wikimedia.org/65790 (10Sean Pringle) p:5Unprio>3Normal [01:57:19] 3MediaWiki / 3Database: SecurePoll PurgePrivateVoteData missing tables in dberror log - 10https://bugzilla.wikimedia.org/65790 (10Sean Pringle) [01:57:19] 3Wikimedia / 3General/Unknown: Make puppet cronjob to run SecurePoll/cli/purgePrivateVoteData.php - 10https://bugzilla.wikimedia.org/51574 (10Sean Pringle) [01:58:02] (03CR) 10Parent5446: Allow more flexibility in RC feeds (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135501 (owner: 10Legoktm) [02:06:17] (03PS3) 10Brian Wolff: Add support for page numbers to VipsScaler. [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/86416 (https://bugzilla.wikimedia.org/52045) [02:09:48] 3MediaWiki / 3Special pages: When Special:WhatLinksHere is included and a valid title not provided, a form is shown - 10https://bugzilla.wikimedia.org/65779#c2 (10MZMcBride) (In reply to Jackmcbarn from comment #1) > This doesn't seem like a bug to me. Any other behavior would be less useful. When transclud... [02:12:33] 3Wikimedia / 3Bugzilla: on bug submit: Incorrect key file for table './bugzilla/bugs_fulltext.MYI - 10https://bugzilla.wikimedia.org/65762#c4 (10Andre Klapper) Oh, I now see the outage thread on ops@ (outage 2014-05-26 08:30:25). Alright. [02:13:33] 3MediaWiki / 3Special pages: When Special:WhatLinksHere is included and a valid title not provided, a form is shown - 10https://bugzilla.wikimedia.org/65779#c3 (10Jackmcbarn) (In reply to MZMcBride from comment #2) > (In reply to Jackmcbarn from comment #1) > > This doesn't seem like a bug to me. Any other b... [02:20:19] 3Wikimedia / 3General/Unknown: Bug and feature requests related to Wikimedia Commons (tracking) - 10https://bugzilla.wikimedia.org/37883 (10Andre Klapper) [02:20:19] 3MediaWiki / 3Maintenance scripts: initSiteStats.php calls undefined/protected functions - 10https://bugzilla.wikimedia.org/65214#c3 (10This, that and the other) It can take some weeks or months for a minor patch such as this to be reviewed. I find it rather frustrating, but not much can be done about it wit... [02:20:33] 3MediaWiki / 3Parser: Tidy sucks (tracking) - 10https://bugzilla.wikimedia.org/2542 (10Andre Klapper) [02:20:33] 3MediaWiki / 3Parser: Sanitizer::removeHTMLtags doesn't close tags correctly when $wgUseTidy is enabled - 10https://bugzilla.wikimedia.org/65747 (10Andre Klapper) [02:22:22] (03CR) 10TTO: [C: 04-1] "The commit message is inappropriate. I can't work out what this bug is about so I can't offer an improved message, but look at other patch" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/132974 (owner: 10Scnd) [02:22:33] 3MediaWiki / 3Export/Import: Import Module error created Revision 0, now page cannot be edited - 10https://bugzilla.wikimedia.org/65775 (10Andre Klapper) p:5Unprio>3Normal [02:22:50] (03PS2) 10TTO: Fix initSiteStats.php maintenance script [core] - 10https://gerrit.wikimedia.org/r/132926 (https://bugzilla.wikimedia.org/65214) [02:25:19] 3Wikimedia / 3Site requests: Set $wgCategoryCollation to 'uca-cs' on Czech Wikipedia and rebuild category sort keys - 10https://bugzilla.wikimedia.org/64885#c9 (10Sean Pringle) Done. [02:25:33] 3Wikimedia / 3Site requests: Set $wgCategoryCollation to 'uca-cs' on Czech Wikipedia and rebuild category sort keys - 10https://bugzilla.wikimedia.org/64885 (10Sean Pringle) 5PAT>3RES/FIX [02:29:31] (03PS3) 10Legoktm: Allow more flexibility in RC feeds [core] - 10https://gerrit.wikimedia.org/r/135501 [02:30:09] (03CR) 10Legoktm: Allow more flexibility in RC feeds (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135501 (owner: 10Legoktm) [02:31:20] (03CR) 10Legoktm: "Is there a reason this is on the 1.23 branch and not master? We typically get stuff merged in master first (if it still applies), and then" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/132974 (owner: 10Scnd) [02:32:29] (03CR) 10Legoktm: [C: 032] "Woo! :D" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/135504 (owner: 10Parent5446) [02:35:26] (03Merged) 10jenkins-bot: Make abstract Config class truly implementation-agnostic [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/135504 (owner: 10Parent5446) [02:35:33] 3MediaWiki extensions / 3Scribunto: Exception: Parameter 2 to ScribuntoHooks::formatLimitData() expected to be a reference, value given - 10https://bugzilla.wikimedia.org/65787 (10Andre Klapper) p:5Unprio>3Normal [02:38:42] (03PS1) 10Legoktm: DerivativeContext::setConfig should take a Config object [core] - 10https://gerrit.wikimedia.org/r/135507 [02:39:01] (03CR) 10Parent5446: [C: 032] Allow more flexibility in RC feeds [core] - 10https://gerrit.wikimedia.org/r/135501 (owner: 10Legoktm) [02:42:38] (03CR) 10Legoktm: "I'm not sure how this was missed originally, but it should get backported to REL1_23 once merged." [core] - 10https://gerrit.wikimedia.org/r/135507 (owner: 10Legoktm) [02:43:25] (03Merged) 10jenkins-bot: Allow more flexibility in RC feeds [core] - 10https://gerrit.wikimedia.org/r/135501 (owner: 10Legoktm) [02:46:31] (03PS3) 10Legoktm: Fix initSiteStats.php maintenance script [core] - 10https://gerrit.wikimedia.org/r/132926 (https://bugzilla.wikimedia.org/65214) (owner: 10TTO) [02:52:34] (03CR) 10Legoktm: [C: 04-1] "Won't this now run all the queries twice? It runs each of them individually when outputting the various stats to the user, and then again" [core] - 10https://gerrit.wikimedia.org/r/132926 (https://bugzilla.wikimedia.org/65214) (owner: 10TTO) [03:05:48] (03CR) 10Legoktm: [C: 04-1] "I'm getting something like:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135502 (owner: 10Legoktm) [03:22:48] (03PS1) 10Ori.livneh: tidy settings.rb a little [vagrant] - 10https://gerrit.wikimedia.org/r/135508 [03:24:52] (03PS2) 10Ori.livneh: Update AUTHORS.txt [vagrant] - 10https://gerrit.wikimedia.org/r/134044 [03:25:07] (03PS3) 10Ori.livneh: Update AUTHORS.txt [vagrant] - 10https://gerrit.wikimedia.org/r/134044 [03:25:12] (03CR) 10Ori.livneh: [C: 032] Update AUTHORS.txt [vagrant] - 10https://gerrit.wikimedia.org/r/134044 (owner: 10Ori.livneh) [03:25:16] (03Merged) 10jenkins-bot: Update AUTHORS.txt [vagrant] - 10https://gerrit.wikimedia.org/r/134044 (owner: 10Ori.livneh) [03:25:46] (03PS2) 10Ori.livneh: tidy settings.rb a little [vagrant] - 10https://gerrit.wikimedia.org/r/135508 [03:25:51] (03CR) 10Ori.livneh: [C: 032] tidy settings.rb a little [vagrant] - 10https://gerrit.wikimedia.org/r/135508 (owner: 10Ori.livneh) [03:25:57] (03Merged) 10jenkins-bot: tidy settings.rb a little [vagrant] - 10https://gerrit.wikimedia.org/r/135508 (owner: 10Ori.livneh) [03:30:10] (03PS7) 10Ori.livneh: Factor Translate extension out of role::mleb into own role [vagrant] - 10https://gerrit.wikimedia.org/r/134290 [03:30:33] (03CR) 10Ori.livneh: [C: 032] Factor Translate extension out of role::mleb into own role [vagrant] - 10https://gerrit.wikimedia.org/r/134290 (owner: 10Ori.livneh) [03:30:37] (03Merged) 10jenkins-bot: Factor Translate extension out of role::mleb into own role [vagrant] - 10https://gerrit.wikimedia.org/r/134290 (owner: 10Ori.livneh) [03:36:53] (03CR) 10Ori.livneh: [C: 031] "There are small cosmetic imperfections here and there, but I'm ready to merge this if you are. We can fix the small things later." (034 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/135322 (owner: 10Adamw) [03:38:14] (03CR) 10Ori.livneh: [C: 031] "Haven't tested, but looks good." [vagrant] - 10https://gerrit.wikimedia.org/r/135323 (owner: 10Adamw) [03:51:42] (03CR) 10BryanDavis: tidy settings.rb a little (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/135508 (owner: 10Ori.livneh) [03:59:10] hi legoktm ! You around ? [03:59:21] hi tonythomas [03:59:57] (03PS2) 10Legoktm: Provide a comment for the RCFeeds [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135502 [04:00:18] (03CR) 10jenkins-bot: [V: 04-1] Provide a comment for the RCFeeds [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135502 (owner: 10Legoktm) [04:00:21] great ! Hope you would've seen Tyler's comments on https://gerrit.wikimedia.org/r/#/c/135290/ he thinks that swiftmailer needs to be installed using composer -- which sounds great. since there is the composer.json in core [04:00:35] * legoktm looks [04:00:55] I added it to the composer.json and the swiftmailer code comes into vendor/swiftmailer/swiftmailer/ [04:01:06] (03PS1) 10Ori.livneh: Load user-provided settings after role-provided settings [vagrant] - 10https://gerrit.wikimedia.org/r/135509 [04:01:08] in core. We can include that from the UserMailer.php rigjht ? [04:01:28] but the Lint trouble will still be there. Did your request got merged ? [04:02:26] I'm not sure what the status on including external libraries via composer is, the other patch that was going to do that (bd808's) stalled as well [04:02:41] yeah, my patch got merged [04:03:12] his points about #2 are right, and I think you should work on that first, since the composer thing is easy to switch later on [04:03:26] legoktm: of course. I will work on that then [04:05:35] 3MediaWiki extensions / 3UniversalLanguageSelector: [Interlanguage links] Always display assistant languages where available - 10https://bugzilla.wikimedia.org/62342 (10Santhosh Thottingal) 5PAT>3RES/FIX a:3Nemo [04:07:31] (03CR) 10Amire80: [C: 032] Add .jsbeautifyrc [services/cxserver] - 10https://gerrit.wikimedia.org/r/135417 (owner: 10Santhosh) [04:07:55] (03Merged) 10jenkins-bot: Add .jsbeautifyrc [services/cxserver] - 10https://gerrit.wikimedia.org/r/135417 (owner: 10Santhosh) [04:08:09] (03CR) 10Legoktm: "For including it via composer, should Tony just add it to the required part of composer.json, or also commit the vendor/ directory that ge" [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [04:11:04] (03CR) 10AndyRussG: "Nice! See inline comments for more details and one retraction. Also: I think it doesn't have to be perfect." (036 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/132982 (owner: 10Ragesoss) [04:12:07] (03PS3) 10Legoktm: Provide a comment for the RCFeeds [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135502 [04:13:55] (03CR) 10Parent5446: "Yes the former. I will not allow massive libraries to be committed into MediaWiki core when they can be sanely autoloaded using a widely a" [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [04:16:18] (03CR) 1001tonythomas: "I added it to the composer.json, and after running the composer install command, the swiftmailer is downloaded into the vendor/swiftmailer" [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [04:18:18] 3MediaWiki / 3General/Unknown: HHVM goes bonkers in HtmlFormatter - 10https://bugzilla.wikimedia.org/65703#c4 (10Tim Starling) Isolated and filed https://github.com/facebook/hhvm/issues/2772 . To work around, revert b568bf9587. [04:20:06] (03CR) 10Parent5446: [C: 032] DerivativeContext::setConfig should take a Config object [core] - 10https://gerrit.wikimedia.org/r/135507 (owner: 10Legoktm) [04:23:37] (03Merged) 10jenkins-bot: DerivativeContext::setConfig should take a Config object [core] - 10https://gerrit.wikimedia.org/r/135507 (owner: 10Legoktm) [04:24:15] (03PS1) 10Parent5446: DerivativeContext::setConfig should take a Config object [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/135510 [04:28:31] (03PS1) 10Hiong3-eng5: Bug: 56220 [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/135511 (https://bugzilla.wikimedia.org/56220) [04:30:40] (03CR) 10Legoktm: [C: 032] DerivativeContext::setConfig should take a Config object [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/135510 (owner: 10Parent5446) [04:30:48] (03PS1) 10BryanDavis: Extract common base class for sync operations [tools/scap] - 10https://gerrit.wikimedia.org/r/135512 [04:30:50] (03PS1) 10BryanDavis: Convert sync-dir and sync-file to python [tools/scap] - 10https://gerrit.wikimedia.org/r/135513 (https://bugzilla.wikimedia.org/59225) [04:30:52] (03PS1) 10BryanDavis: Convert sync-dblist to python [tools/scap] - 10https://gerrit.wikimedia.org/r/135514 [04:30:54] (03PS1) 10BryanDavis: Convert sync-docroot to python [tools/scap] - 10https://gerrit.wikimedia.org/r/135515 [04:31:42] (03CR) 10jenkins-bot: [V: 04-1] Extract common base class for sync operations [tools/scap] - 10https://gerrit.wikimedia.org/r/135512 (owner: 10BryanDavis) [04:33:42] (03Merged) 10jenkins-bot: DerivativeContext::setConfig should take a Config object [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/135510 (owner: 10Parent5446) [04:44:12] (03PS3) 10Physikerwelt: WIP: Add separate database table for LaTeXML (step 3) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135495 [04:45:23] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add separate database table for LaTeXML (step 3) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135495 (owner: 10Physikerwelt) [04:47:03] (03PS2) 10BryanDavis: Extract common base class for sync operations [tools/scap] - 10https://gerrit.wikimedia.org/r/135512 [04:48:00] (03CR) 10BryanDavis: [C: 032] Load user-provided settings after role-provided settings [vagrant] - 10https://gerrit.wikimedia.org/r/135509 (owner: 10Ori.livneh) [04:48:04] (03Merged) 10jenkins-bot: Load user-provided settings after role-provided settings [vagrant] - 10https://gerrit.wikimedia.org/r/135509 (owner: 10Ori.livneh) [04:48:48] (03PS2) 10BryanDavis: Convert sync-dir and sync-file to python [tools/scap] - 10https://gerrit.wikimedia.org/r/135513 (https://bugzilla.wikimedia.org/59225) [04:49:00] (03CR) 10jenkins-bot: [V: 04-1] Convert sync-dir and sync-file to python [tools/scap] - 10https://gerrit.wikimedia.org/r/135513 (https://bugzilla.wikimedia.org/59225) (owner: 10BryanDavis) [04:49:48] (03PS4) 10Physikerwelt: Add separate database table for LaTeXML (step 3) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135495 [04:49:55] (03PS3) 10BryanDavis: Convert sync-dir and sync-file to python [tools/scap] - 10https://gerrit.wikimedia.org/r/135513 (https://bugzilla.wikimedia.org/59225) [04:50:40] (03PS2) 10BryanDavis: Convert sync-dblist to python [tools/scap] - 10https://gerrit.wikimedia.org/r/135514 [04:50:56] (03PS2) 10BryanDavis: Convert sync-docroot to python [tools/scap] - 10https://gerrit.wikimedia.org/r/135515 [04:50:58] (03CR) 10jenkins-bot: [V: 04-1] Add separate database table for LaTeXML (step 3) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135495 (owner: 10Physikerwelt) [04:51:18] 3MediaWiki / 3Installer: Provide a way to collect contact info - 10https://bugzilla.wikimedia.org/65590 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [04:51:19] 3MediaWiki / 3Watchlist: Selection a namespace on [[Special:Watchlist]] should add the "namespace" parameter to the URL - 10https://bugzilla.wikimedia.org/65592 (10Andre Klapper) p:5Unprio>3Low [04:54:29] (03PS1) 10Legoktm: Run SpamRegexTest by default [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135516 [04:55:26] (03PS5) 10Physikerwelt: Add separate database table for LaTeXML (step 3) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135495 [04:56:35] (03CR) 10jenkins-bot: [V: 04-1] Add separate database table for LaTeXML (step 3) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135495 (owner: 10Physikerwelt) [05:02:02] (03PS3) 10BryanDavis: Convert sync-docroot to python [tools/scap] - 10https://gerrit.wikimedia.org/r/135515 [05:02:15] (03CR) 10Ori.livneh: [C: 031] "See comment in-line about an issue not introduced by this commit that should be fixed." (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/135514 (owner: 10BryanDavis) [05:02:29] (03PS1) 10Legoktm: Add AntiSpoof to Flow dependencies [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135518 [05:04:14] (03PS6) 10Physikerwelt: Add separate database table for LaTeXML (step 3) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135495 [05:04:17] (03CR) 10Legoktm: "Dependency of AbuseFilter, doesn't actually affect Flow tests, but it's causing stuff to get added to the skip log:" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135518 (owner: 10Legoktm) [05:04:18] ori: Would you be ok with me adding a commit at the end of the chain I have running that changes the import style? [05:04:38] (03CR) 10Krinkle: [C: 032] Swap if/elseif in SpecialRevisiondelete.php [core] - 10https://gerrit.wikimedia.org/r/135444 (owner: 10Umherirrender) [05:04:55] (03PS2) 10Krinkle: SpecialRevisiondelete: Simplfy if/elseif logic [core] - 10https://gerrit.wikimedia.org/r/135444 (owner: 10Umherirrender) [05:05:05] (03PS3) 10Krinkle: SpecialRevisiondelete: Simplify if/elseif logic [core] - 10https://gerrit.wikimedia.org/r/135444 (owner: 10Umherirrender) [05:05:10] (03CR) 10Krinkle: SpecialRevisiondelete: Simplify if/elseif logic [core] - 10https://gerrit.wikimedia.org/r/135444 (owner: 10Umherirrender) [05:05:13] (03CR) 10Krinkle: [C: 032] SpecialRevisiondelete: Simplify if/elseif logic [core] - 10https://gerrit.wikimedia.org/r/135444 (owner: 10Umherirrender) [05:07:17] (03PS7) 10Physikerwelt: Add separate database table for LaTeXML (step 3) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135495 [05:07:53] (03CR) 10Ori.livneh: [C: 04-1] "small issue inline" (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/135513 (https://bugzilla.wikimedia.org/59225) (owner: 10BryanDavis) [05:08:10] (03PS1) 10BryanDavis: Change import style for __init__.py [tools/scap] - 10https://gerrit.wikimedia.org/r/135519 [05:08:49] (03CR) 10jenkins-bot: [V: 04-1] Add separate database table for LaTeXML (step 3) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135495 (owner: 10Physikerwelt) [05:10:31] (03Merged) 10jenkins-bot: SpecialRevisiondelete: Simplify if/elseif logic [core] - 10https://gerrit.wikimedia.org/r/135444 (owner: 10Umherirrender) [05:10:34] (03PS8) 10Divec: DONTMERGE LinearDoc: Flattened representation of Inline HTML [services/cxserver] - 10https://gerrit.wikimedia.org/r/124287 [05:13:20] (03CR) 10Nikerabbit: "Interwiki is not part of MLEB. I do not know why it has been included here." (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/134290 (owner: 10Ori.livneh) [05:16:13] (03CR) 10Ori.livneh: [C: 04-1] Extract common base class for sync operations (033 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/135512 (owner: 10BryanDavis) [05:16:35] bd808: yes, of course [05:16:46] (03PS4) 10BryanDavis: Convert sync-dir and sync-file to python [tools/scap] - 10https://gerrit.wikimedia.org/r/135513 (https://bugzilla.wikimedia.org/59225) [05:22:40] (03PS4) 10Nemo bis: Allow removing edit toolbar from the editing form [core] - 10https://gerrit.wikimedia.org/r/120357 (https://bugzilla.wikimedia.org/53448) (owner: 10Deepali) [05:23:47] (03CR) 10jenkins-bot: [V: 04-1] Allow removing edit toolbar from the editing form [core] - 10https://gerrit.wikimedia.org/r/120357 (https://bugzilla.wikimedia.org/53448) (owner: 10Deepali) [05:24:27] (03CR) 10BryanDavis: Extract common base class for sync operations (032 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/135512 (owner: 10BryanDavis) [05:25:28] (03PS9) 10Divec: LinearDoc: Flattened representation of Inline HTML [services/cxserver] - 10https://gerrit.wikimedia.org/r/124287 [05:30:54] (03PS3) 10Santhosh: Pageloader: Use only parsoid and remove hardcoded enwiki host [services/cxserver] - 10https://gerrit.wikimedia.org/r/135016 [05:34:00] (03PS8) 10Physikerwelt: Add separate database table for LaTeXML (step 3) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135495 [05:35:18] 3MediaWiki extensions / 3Translate: Special page for migration of legacy translation pages (tracking) - 10https://bugzilla.wikimedia.org/65740 (10Nemo) [05:35:21] 3MediaWiki extensions / 3Translate: Restrict access to Special:PageMigration - 10https://bugzilla.wikimedia.org/65791 (10Nemo) 3ASS p:3Unprio s:3normal a:3Pratik Lahoti Using the feature should per restricted by a user right: I think for now we can start by requiring "pagetranslation". Currently I c... [05:36:03] 3MediaWiki extensions / 3Translate: Restrict access to Special:PageMigration - 10https://bugzilla.wikimedia.org/65791 (10Nemo) p:5Unprio>3High [05:36:17] (03CR) 10Ori.livneh: Extract common base class for sync operations (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/135512 (owner: 10BryanDavis) [05:39:53] (03PS1) 10Parent5446: Fixed hook names and code style [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/135520 [05:51:06] 3MediaWiki extensions / 3Scribunto: LuaSandbox segfaults under HHVM - 10https://bugzilla.wikimedia.org/65792 (10Ori Livneh) 3NEW p:3Unprio s:3normal a:3None Created attachment 15479 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15479&action=edit HHVM stack trace [05:51:35] 3MediaWiki extensions / 3Math: Add seperate database tables for Mathoid - 10https://bugzilla.wikimedia.org/65793 (10physikerwelt) 3NEW p:3Unprio s:3enhanc a:3None As well as LaTeXML, the Mathoid-server needs separate database tables as well. [05:53:05] 3MediaWiki / 3Internationalization: Document/differentiate between use cases of formatTimePeriod() and formatDuration() - 10https://bugzilla.wikimedia.org/65794 (10Kevin Israel (PleaseStand)) 3NEW p:3Unprio s:3normal a:3None Here we have two methods of Language (formatTimePeriod() and formatDuration(... [05:53:18] 3MediaWiki / 3Documentation: Documentation is out of date, incomplete (tracking) - 10https://bugzilla.wikimedia.org/1 (10Kevin Israel (PleaseStand)) [05:54:27] what is the proper way to close a bugzilla bug that turns out to be an upstream issue? [05:54:42] the proper status, i mean. WONTFIX? INVALID? WORKSFORME? [05:55:13] (03PS1) 10Physikerwelt: Add seperate database tables for Mathoid [extensions/Math] - 10https://gerrit.wikimedia.org/r/135521 (https://bugzilla.wikimedia.org/65793) [05:55:31] add the keyword upstream, and then leave it open until it gets fixed or you find a workaround [05:55:46] there's a workaround [05:55:49] and it works [05:55:55] so FIXED, then? [05:56:05] that or WORKSFORME [05:56:33] 3MediaWiki / 3General/Unknown: HHVM goes bonkers in HtmlFormatter - 10https://bugzilla.wikimedia.org/65703#c5 (10Ori Livneh) 5NEW>3RES/FIX Thank you for chasing that down. I reverted b568bf9587 in our fork and will track the upstream issue you filed. [05:56:46] legoktm: thanks [05:56:49] 3MediaWiki extensions / 3Math: Add seperate database tables for Mathoid - 10https://bugzilla.wikimedia.org/65793 (10physikerwelt) p:5Unprio>3Low a:3physikerwelt [05:58:57] (03PS3) 10Deepali: Set a default value for $wgBookManagerv2JsonFrontend [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/126805 [05:59:00] (03PS2) 10Deepali: Efficient navigation through sections [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/134627 (https://bugzilla.wikimedia.org/52435) [05:59:02] (03PS2) 10Deepali: Place the function description of function addAddButton() at its proper place [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/127468 [05:59:03] (03CR) 10jenkins-bot: [V: 04-1] Efficient navigation through sections [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/134627 (https://bugzilla.wikimedia.org/52435) (owner: 10Deepali) [05:59:37] (03PS1) 10Physikerwelt: Add table for new math renderer Mathoid [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/135522 (https://bugzilla.wikimedia.org/65793) [06:02:36] 3MediaWiki / 3Parser: HHVM segfaults when calling Parser->callParserFunction - 10https://bugzilla.wikimedia.org/65796 (10Ori Livneh) 3NEW p:3Unprio s:3normal a:3None Created attachment 15481 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15481&action=edit Stack trace Host: osmium ProcessID:... [06:03:18] 3MediaWiki / 3Parser: HHVM segfaults when calling Parser->callParserFunction - 10https://bugzilla.wikimedia.org/65796#c1 (10Ori Livneh) Sorry, I didn't mean to paste the content of the attachment into the comment body. [06:05:11] (03CR) 10Ori.livneh: [C: 032] "Merging for now, but please think over the use of property descriptors, per comments" [tools/scap] - 10https://gerrit.wikimedia.org/r/135512 (owner: 10BryanDavis) [06:05:25] (03Merged) 10jenkins-bot: Extract common base class for sync operations [tools/scap] - 10https://gerrit.wikimedia.org/r/135512 (owner: 10BryanDavis) [06:06:17] (03CR) 10Ori.livneh: [C: 032] Convert sync-dir and sync-file to python [tools/scap] - 10https://gerrit.wikimedia.org/r/135513 (https://bugzilla.wikimedia.org/59225) (owner: 10BryanDavis) [06:06:30] (03Merged) 10jenkins-bot: Convert sync-dir and sync-file to python [tools/scap] - 10https://gerrit.wikimedia.org/r/135513 (https://bugzilla.wikimedia.org/59225) (owner: 10BryanDavis) [06:07:45] (03CR) 10Ori.livneh: [C: 032] Convert sync-dblist to python [tools/scap] - 10https://gerrit.wikimedia.org/r/135514 (owner: 10BryanDavis) [06:07:47] (03CR) 10jenkins-bot: [V: 04-1] Convert sync-dblist to python [tools/scap] - 10https://gerrit.wikimedia.org/r/135514 (owner: 10BryanDavis) [06:07:53] (03PS3) 10Ori.livneh: Convert sync-dblist to python [tools/scap] - 10https://gerrit.wikimedia.org/r/135514 (owner: 10BryanDavis) [06:08:22] (03CR) 10Ori.livneh: [C: 032] Convert sync-dblist to python [tools/scap] - 10https://gerrit.wikimedia.org/r/135514 (owner: 10BryanDavis) [06:08:36] (03Merged) 10jenkins-bot: Convert sync-dblist to python [tools/scap] - 10https://gerrit.wikimedia.org/r/135514 (owner: 10BryanDavis) [06:10:21] (03PS4) 10Ori.livneh: Convert sync-docroot to python [tools/scap] - 10https://gerrit.wikimedia.org/r/135515 (owner: 10BryanDavis) [06:10:26] (03CR) 10Ori.livneh: [C: 032] Convert sync-docroot to python [tools/scap] - 10https://gerrit.wikimedia.org/r/135515 (owner: 10BryanDavis) [06:10:47] (03Merged) 10jenkins-bot: Convert sync-docroot to python [tools/scap] - 10https://gerrit.wikimedia.org/r/135515 (owner: 10BryanDavis) [06:10:57] (03PS2) 10Ori.livneh: Change import style for __init__.py [tools/scap] - 10https://gerrit.wikimedia.org/r/135519 (owner: 10BryanDavis) [06:11:04] (03CR) 10Ori.livneh: [C: 032] "Thanks" [tools/scap] - 10https://gerrit.wikimedia.org/r/135519 (owner: 10BryanDavis) [06:11:46] (03Merged) 10jenkins-bot: Change import style for __init__.py [tools/scap] - 10https://gerrit.wikimedia.org/r/135519 (owner: 10BryanDavis) [06:13:08] (03CR) 10Legoktm: Add sortby last activity as a user preference (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/134955 (owner: 10Bsitu) [06:13:36] (03CR) 10Ori.livneh: "I could have sworn it was a dependency for *something*. I'll look" [vagrant] - 10https://gerrit.wikimedia.org/r/134290 (owner: 10Ori.livneh) [06:14:41] (03PS3) 10Deepali: Efficient navigation through sections [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/134627 (https://bugzilla.wikimedia.org/52435) [06:28:38] (03CR) 10Ori.livneh: WIP: New hook to instrument page save failures (031 comment) [core] - 10https://gerrit.wikimedia.org/r/94512 (owner: 10Adamw) [06:28:40] (03CR) 10Frédéric Wang: [C: 031] "In this and other patches, you often have many whitespace changes. This makes review harder and messes up the Git history. I don't know wh" (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135495 (owner: 10Physikerwelt) [06:32:04] (03CR) 10Frédéric Wang: [C: 031] Add seperate database tables for Mathoid (034 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135521 (https://bugzilla.wikimedia.org/65793) (owner: 10Physikerwelt) [06:32:41] (03PS1) 10KartikMistry: Update README for individual test run [services/cxserver] - 10https://gerrit.wikimedia.org/r/135523 [06:33:45] (03CR) 10Fomafix: "php-cgi crashes with a core dump." [core] - 10https://gerrit.wikimedia.org/r/132829 (owner: 10Siebrand) [06:37:32] (03CR) 10Physikerwelt: [C: 04-1] "do not submit" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/135522 (https://bugzilla.wikimedia.org/65793) (owner: 10Physikerwelt) [06:44:54] (03CR) 10Physikerwelt: "I try to avoid avoid white-space changes... However my IDE introduces them without asking:-)... probably I was better of using vi" (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135495 (owner: 10Physikerwelt) [06:48:30] (03CR) 10Frédéric Wang: "there is a probably a way to configure it so that it does not introduce the whitespace change." (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135495 (owner: 10Physikerwelt) [06:53:52] (03PS2) 10Physikerwelt: Add separate database tables for Mathoid [extensions/Math] - 10https://gerrit.wikimedia.org/r/135521 (https://bugzilla.wikimedia.org/65793) [06:56:48] (03CR) 10Frédéric Wang: [C: 032] "Apparently MathJax doc says "AsciiMath" but the official site says "ASCIIMath". Anyway, let's take this." [extensions/Math] - 10https://gerrit.wikimedia.org/r/135521 (https://bugzilla.wikimedia.org/65793) (owner: 10Physikerwelt) [06:57:59] (03Merged) 10jenkins-bot: Add separate database tables for Mathoid [extensions/Math] - 10https://gerrit.wikimedia.org/r/135521 (https://bugzilla.wikimedia.org/65793) (owner: 10Physikerwelt) [07:01:33] (03CR) 10Physikerwelt: "just for reference... thanks Frédéric" (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135521 (https://bugzilla.wikimedia.org/65793) (owner: 10Physikerwelt) [07:03:58] (03CR) 10Physikerwelt: "the required change was merged now" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/135522 (https://bugzilla.wikimedia.org/65793) (owner: 10Physikerwelt) [07:07:04] (03CR) 10Physikerwelt: "I think the problem in that case was that the IDE picked wrong brackets during the rebase phase." [extensions/Math] - 10https://gerrit.wikimedia.org/r/135495 (owner: 10Physikerwelt) [07:10:08] (03CR) 10Frédéric Wang: [C: 031] Add table for new math renderer Mathoid [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/135522 (https://bugzilla.wikimedia.org/65793) (owner: 10Physikerwelt) [07:18:57] (03PS7) 1001tonythomas: Shifted from PEAR/PHP mailer to Swift Mailer [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) [07:20:28] legoktm: made a single mail transport function as per Tylor https://gerrit.wikimedia.org/r/#/c/135290 [07:20:42] waiting for jenkins [07:20:42] * legoktm looks [07:21:48] 3Wikimedia / 3Bugzilla: on bug submit: Incorrect key file for table './bugzilla/bugs_fulltext.MYI - 10https://bugzilla.wikimedia.org/65762#c5 (10Antoine "hashar" Musso) The table being crashed, that prevented the Gerrit bot comment to be submitted though the status (i.e. NEW -> PATCH_TO_REVIEW) would. [07:25:47] (03CR) 10Nikerabbit: Pageloader: Use only parsoid and remove hardcoded enwiki host (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/135016 (owner: 10Santhosh) [07:29:19] legoktm: I will be back ok. Looks like Jenkins approved it [07:29:29] yay [07:29:44] legoktm: how do I create new fields in my table [07:30:22] legoktm: looks like int the recieved Email the value for IP is not correctly substituted. I get from IP address ::1, [07:30:41] problem with parsing ? [07:31:24] legoktm: on ConfirmEmail ok. "Someone, probably you, from IP address ::1, [07:31:24] has registered an account "tony" with this email address on My Test. [07:31:44] ::1 is the IPv6 equivalent of 127.0.0.1 [07:32:02] legoktm: ha ! Then no probs. didn't knew that [07:32:47] Withoutaname: take a look at https://www.mediawiki.org/wiki/Manual:Hooks/LoadExtensionSchemaUpdates you'll need to create a patch file and update the schema [07:32:49] 3MediaWiki / 3Internationalization: Document/differentiate between use cases of formatTimePeriod() and formatDuration() - 10https://bugzilla.wikimedia.org/65794#c1 (10Niklas Laxström) The time formatting functions are quite messy in MediaWiki. My gut feeling is that formatDuration is used for video/audio fil... [07:33:20] 3MediaWiki extensions / 3Popups: Hovercards popping up above cause flickering (because of popping up under the mouse cursor) - 10https://bugzilla.wikimedia.org/65433 (10Vibha Bamba) a:3Prateek Saxena [07:39:50] 3MediaWiki extensions / 3Popups: Hovercards popping up above cause flickering (because of popping up under the mouse cursor) - 10https://bugzilla.wikimedia.org/65433 (10Prateek Saxena) a:5Prateek Saxena>3Prateek Saxena [07:45:44] (03PS4) 10TTO: Fix initSiteStats.php maintenance script [core] - 10https://gerrit.wikimedia.org/r/132926 (https://bugzilla.wikimedia.org/65214) [07:50:59] (03CR) 10TTO: "Thanks, Kunal. Should be better now." [core] - 10https://gerrit.wikimedia.org/r/132926 (https://bugzilla.wikimedia.org/65214) (owner: 10TTO) [07:54:36] (03CR) 10Legoktm: "It'll still do multiple queries if you have 0 files or 0 of the others." [core] - 10https://gerrit.wikimedia.org/r/132926 (https://bugzilla.wikimedia.org/65214) (owner: 10TTO) [08:01:39] (03CR) 10TTO: "True, but if there are 0 objects the query won't take very long, so it hardly matters." [core] - 10https://gerrit.wikimedia.org/r/132926 (https://bugzilla.wikimedia.org/65214) (owner: 10TTO) [08:07:33] 3MediaWiki / 3Internationalization: Document/differentiate between use cases of formatTimePeriod() and formatDuration() - 10https://bugzilla.wikimedia.org/65794#c2 (10Nemo) e5a9b38294da expanded formatTimePeriod(), mainly for some extension. 77d2f1676 only says that formatDuration()'s aim is to "easily rende... [08:10:36] (03CR) 10Legoktm: "Yeah, I think changing the defaults to null would be a better idea." [core] - 10https://gerrit.wikimedia.org/r/132926 (https://bugzilla.wikimedia.org/65214) (owner: 10TTO) [08:10:46] (03PS5) 10TTO: Fix initSiteStats.php maintenance script [core] - 10https://gerrit.wikimedia.org/r/132926 (https://bugzilla.wikimedia.org/65214) [08:13:50] 3MediaWiki extensions / 3WikiEditor: The help section should include a link to more help, ie. Help:Contents by default - 10https://bugzilla.wikimedia.org/65797 (10Ian Kelling) 3UNC p:3Unprio s:3normal a:3None The help section gives the impression that it is comprehensive, but it is missing a lot. Th... [08:31:31] (03PS4) 10Santhosh: Pageloader: Use only parsoid and remove hardcoded enwiki host [services/cxserver] - 10https://gerrit.wikimedia.org/r/135016 [08:34:37] (03CR) 10Santhosh: Pageloader: Use only parsoid and remove hardcoded enwiki host (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/135016 (owner: 10Santhosh) [08:40:05] (03CR) 10Gilles: [C: 032] Fix doc comments on get[General](Short|Long)Desc [core] - 10https://gerrit.wikimedia.org/r/135278 (owner: 10Brian Wolff) [08:43:56] (03Merged) 10jenkins-bot: Fix doc comments on get[General](Short|Long)Desc [core] - 10https://gerrit.wikimedia.org/r/135278 (owner: 10Brian Wolff) [08:47:18] 3MediaWiki extensions / 3WikidataRepo: item statement value vanishes when setting a rank - 10https://bugzilla.wikimedia.org/65398 (10Adrian Lang) 5PAT>3RES/FIX [09:02:52] (03PS3) 10Gilles: Restructure Media related tests to avoid duplicated code [core] - 10https://gerrit.wikimedia.org/r/135492 (owner: 10Brian Wolff) [09:08:50] (03CR) 10Gilles: [C: 032] Restructure Media related tests to avoid duplicated code [core] - 10https://gerrit.wikimedia.org/r/135492 (owner: 10Brian Wolff) [09:09:26] (03CR) 10Nikerabbit: [C: 032] Pageloader: Use only parsoid and remove hardcoded enwiki host [services/cxserver] - 10https://gerrit.wikimedia.org/r/135016 (owner: 10Santhosh) [09:10:02] (03Merged) 10jenkins-bot: Pageloader: Use only parsoid and remove hardcoded enwiki host [services/cxserver] - 10https://gerrit.wikimedia.org/r/135016 (owner: 10Santhosh) [09:12:17] (03Merged) 10jenkins-bot: Restructure Media related tests to avoid duplicated code [core] - 10https://gerrit.wikimedia.org/r/135492 (owner: 10Brian Wolff) [09:13:13] 3Wikimedia / 3Wikidata: Review and move Wikidata content on https://meta.wikimedia.org/wiki/Wikidata - 10https://bugzilla.wikimedia.org/65799 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Outdated content should be removed, useful content should go to mediawiki.org or wikidata.org... [09:14:42] 3Wikimedia / 3Wikidata: Review and move Wikidata content on https://meta.wikimedia.org/wiki/Wikidata - 10https://bugzilla.wikimedia.org/65799 (10tobias.gritschacher) p:5Unprio>3Normal [09:17:50] (03CR) 10Gilles: [C: 04-1] Check $wgMaxImageArea before downloading file asset from swift (032 comments) [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135101 (https://bugzilla.wikimedia.org/62306) (owner: 10Brian Wolff) [09:18:06] (03CR) 10Gilles: "recheck" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135496 (owner: 10Brian Wolff) [09:18:42] 3MediaWiki extensions / 3UniversalLanguageSelector: Change Sanskrit transliteration rules - 10https://bugzilla.wikimedia.org/63895#c42 (10Runa Bhattacharjee) 5ASS>3PAT Changes as per comment 40 has been committed: https://github.com/wikimedia/jquery.ime/pull/355 Can be seen here: http://imetesting.wmf... [09:18:42] 3MediaWiki extensions / 3WikidataRepo: Install default gadgets from wikidata.org on the test system (beta) - 10https://bugzilla.wikimedia.org/64998#c3 (10tobias.gritschacher) 5ASS>3PAT @Bene* thanks, will check if it works and close the bug then. Probably you or someone from the community can enable them... [09:21:21] (03CR) 10TTO: "Null it is." [core] - 10https://gerrit.wikimedia.org/r/132926 (https://bugzilla.wikimedia.org/65214) (owner: 10TTO) [09:21:55] (03CR) 10Daniel Kinzler: "@Parent: You said:" [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [09:23:11] (03CR) 10Daniel Kinzler: "@Parent: ...but anyway, thanks for merging :)" [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [09:23:49] (03CR) 10Gilles: Make PagedTiffHandler work with VipsScaler. (032 comments) [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/86413 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [09:27:15] (03PS1) 10Gilles: Make PagedTiffHandler-testextensions voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135531 [09:27:54] (03CR) 10Gilles: [C: 032] "Sent a request to make this test voting in https://gerrit.wikimedia.org/r/#/c/135531/" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135496 (owner: 10Brian Wolff) [09:28:02] (03Merged) 10jenkins-bot: Fix paged tiff handler tests [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135496 (owner: 10Brian Wolff) [09:33:15] (03PS1) 10Hashar: Trigger VipsScaler unit tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135532 [09:33:58] (03CR) 10Hashar: [C: 032] Trigger VipsScaler unit tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135532 (owner: 10Hashar) [09:34:07] (03Merged) 10jenkins-bot: Trigger VipsScaler unit tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135532 (owner: 10Hashar) [09:34:42] (03CR) 10Santhosh: [C: 04-1] LinearDoc: Flattened representation of Inline HTML (0312 comments) [services/cxserver] - 10https://gerrit.wikimedia.org/r/124287 (owner: 10Divec) [09:36:12] (03CR) 10Gilles: "recheck" [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/86416 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [09:36:23] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/54455 (owner: 10Hashar) [09:36:26] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/54455 [09:39:58] (03CR) 10Gilles: [C: 032] Add support for page numbers to VipsScaler. [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/86416 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [09:40:02] (03Merged) 10jenkins-bot: Add support for page numbers to VipsScaler. [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/86416 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [09:45:47] (03PS1) 10Hashar: (WIP) pywikibot-integration (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135536 [09:49:28] (03PS7) 10Gilles: [WIP] Generate thumbnails based on buckets [core] - 10https://gerrit.wikimedia.org/r/135008 [09:51:27] (03PS1) 10Ori.livneh: fix role::uploadwizard [vagrant] - 10https://gerrit.wikimedia.org/r/135537 [09:51:42] (03CR) 10Ori.livneh: [C: 032] fix role::uploadwizard [vagrant] - 10https://gerrit.wikimedia.org/r/135537 (owner: 10Ori.livneh) [09:51:46] (03Merged) 10jenkins-bot: fix role::uploadwizard [vagrant] - 10https://gerrit.wikimedia.org/r/135537 (owner: 10Ori.livneh) [09:52:52] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Generate thumbnails based on buckets [core] - 10https://gerrit.wikimedia.org/r/135008 (owner: 10Gilles) [09:53:59] (03PS1) 10Ori.livneh: lint fixes [vagrant] - 10https://gerrit.wikimedia.org/r/135538 [09:54:13] (03CR) 10Ori.livneh: [C: 032] lint fixes [vagrant] - 10https://gerrit.wikimedia.org/r/135538 (owner: 10Ori.livneh) [09:54:17] (03Merged) 10jenkins-bot: lint fixes [vagrant] - 10https://gerrit.wikimedia.org/r/135538 (owner: 10Ori.livneh) [09:59:36] (03PS8) 10Gilles: [WIP] Generate thumbnails based on buckets [core] - 10https://gerrit.wikimedia.org/r/135008 [10:00:28] (03CR) 10Nemo bis: "Thanks" [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/86416 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [10:01:43] (03PS1) 10Amire80: Update UniversalLanguageSelector [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135541 [10:03:41] 3MediaWiki / 3Maintenance scripts: populateRevisionLength.php displays "Content of archive unavailable" error when updating ar_len field with text stored in archive table - 10https://bugzilla.wikimedia.org/65765#c3 (10Joerg) I am upgrading from 1.22.6 to 1.23.0-rc.2. The database looks pretty normal to me:... [10:06:42] (03PS2) 10Scnd: Bug: 65220 [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/132974 (https://bugzilla.wikimedia.org/65220) [10:07:13] (03PS3) 10Scnd: images/.htaccess breaks TransformVia404 functionality [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/132974 (https://bugzilla.wikimedia.org/65220) [10:07:18] (03PS1) 10Amire80: Update UniversalLanguageSelector [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/135542 [10:09:31] (03CR) 10Nikerabbit: Make abstract Config class truly implementation-agnostic (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [10:09:56] (03PS3) 10Nik: Correctly parse 'redirect' XML tag during Special:Import. [core] - 10https://gerrit.wikimedia.org/r/134079 (https://bugzilla.wikimedia.org/65481) [10:14:41] 3MediaWiki extensions / 3UniversalLanguageSelector: ULS: Fix "JQMIGRATE: $(html) HTML strings must start with '<' character" in jquery.uls.core.js - 10https://bugzilla.wikimedia.org/65400 (10Santhosh Thottingal) 5PAT>3RES/FIX [10:18:41] 3MediaWiki / 3Maintenance scripts: populateRevisionLength.php displays "Content of archive unavailable" error when updating ar_len field with text stored in archive table - 10https://bugzilla.wikimedia.org/65765#c4 (10Joerg) The root of the problem is in Revision::selectArchiveFields(): Before all the thing... [10:19:11] 3MediaWiki-Vagrant: vagrant enable-role followed by vagrant up should trigger a puppet run - 10https://bugzilla.wikimedia.org/61456#c1 (10Ori Livneh) This is now possible by configuring the Puppet provisioner to :run => 'always'. See https://docs.vagrantup.com/v2/provisioning/basic_usage.html, section "Run on... [10:20:56] 3MediaWiki-Vagrant: Git is slow & big - 10https://bugzilla.wikimedia.org/57430#c3 (10Ori Livneh) 5NEW>3RES/WOR (In reply to Tisza Gergő from comment #2) > Re: VirtualBox Shared Folders, couldn't mediawiki-vagrant just use NFS on > linux hosts? If the filesystem is indeed a problem, that would speed up HTTP... [10:21:56] 3MediaWiki-Vagrant: "vagrant up" reports errors - 10https://bugzilla.wikimedia.org/54632#c1 (10Ori Livneh) 5NEW>3RES/WOR Tested, WFM. [10:23:26] 3MediaWiki-Vagrant: Document 'update-guest-additions' and the issues it can often resolve - 10https://bugzilla.wikimedia.org/54890#c1 (10Ori Livneh) 5NEW>3RES/WON Script removed in Ia6bc4f2e5 [10:23:53] (03PS1) 10Scnd: images/.htaccess breaks TransformVia404 functionality [core] - 10https://gerrit.wikimedia.org/r/135543 (https://bugzilla.wikimedia.org/65220) [10:25:15] (03CR) 10Scnd: [C: 031] "Added in master https://gerrit.wikimedia.org/r/#/q/Ibdb91f4c676b1c77558ac806c1ccc8313ef5929f,n,z" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/132974 (https://bugzilla.wikimedia.org/65220) (owner: 10Scnd) [10:29:08] (03CR) 10Krinkle: "possible fixme/regression." (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/135513 (https://bugzilla.wikimedia.org/59225) (owner: 10BryanDavis) [10:31:53] (03PS2) 10Scnd: $wgImageLimits filter not correct [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/132831 (https://bugzilla.wikimedia.org/65158) [10:39:12] (03CR) 10Nikerabbit: [C: 04-1] "I would have split the backend and frontend into separate patches." (0312 comments) [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [10:39:27] 3MediaWiki extensions / 3WikidataRepo: string value input with whitespace or return characters - 10https://bugzilla.wikimedia.org/65786#c3 (10tobias.gritschacher) 5NEW>3RES/DUP *** This bug has been marked as a duplicate of bug 63301 *** [10:39:30] (03PS1) 10Scnd: $wgImageLimits filter not correct [core] - 10https://gerrit.wikimedia.org/r/135545 (https://bugzilla.wikimedia.org/65158) [10:39:42] 3MediaWiki extensions / 3WikidataRepo: String-value statement: additional "\n" added to the string when hitting return for saving - 10https://bugzilla.wikimedia.org/63301#c3 (10tobias.gritschacher) *** Bug 65786 has been marked as a duplicate of this bug. *** [10:42:56] (03CR) 10Krinkle: [C: 032] DBConnectionError: Expand {{SITENAME}} in pagetitle with Message::text() [core] - 10https://gerrit.wikimedia.org/r/135443 (https://bugzilla.wikimedia.org/58447) (owner: 10PleaseStand) [10:43:26] 3MediaWiki / 3Skin and page rendering: "Internal error" page should expand {{SITENAME}} in 'pagetitle' - 10https://bugzilla.wikimedia.org/58447 (10Krinkle) 5PAT>3RES/FIX [10:46:19] (03Merged) 10jenkins-bot: DBConnectionError: Expand {{SITENAME}} in pagetitle with Message::text() [core] - 10https://gerrit.wikimedia.org/r/135443 (https://bugzilla.wikimedia.org/58447) (owner: 10PleaseStand) [10:48:39] (03PS2) 10Krinkle: images/.htaccess breaks TransformVia404 functionality [core] - 10https://gerrit.wikimedia.org/r/135543 (https://bugzilla.wikimedia.org/65220) (owner: 10Scnd) [10:50:26] (03CR) 10Nikerabbit: [C: 032] Change one Linker::formatSize call to Message::sizeParams (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135448 (owner: 10Umherirrender) [10:51:28] (03PS2) 10Krinkle: $wgImageLimits filter not correct [core] - 10https://gerrit.wikimedia.org/r/135545 (https://bugzilla.wikimedia.org/65158) (owner: 10Scnd) [10:52:11] (03CR) 10Krinkle: [C: 04-1] "Please improve the commit subject line. It neither describes what kind of change was made nor what was changed, merely that something (wha" [core] - 10https://gerrit.wikimedia.org/r/135545 (https://bugzilla.wikimedia.org/65158) (owner: 10Scnd) [10:52:42] 3MediaWiki extensions / 3WikidataRepo: Install default gadgets from wikidata.org on the test system (beta) - 10https://bugzilla.wikimedia.org/64998#c4 (10tobias.gritschacher) @Bene*: it seems we cannot just load the AuthorityControl Gadget from Wikidata. It has hardcoded property-ids that do not match the pr... [10:54:13] (03Abandoned) 10Krinkle: $wgImageLimits filter not correct [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/132831 (https://bugzilla.wikimedia.org/65158) (owner: 10Scnd) [10:54:46] (03PS1) 10Krinkle: Improve OCR layer filtering [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/135546 [10:55:03] (03CR) 10jenkins-bot: [V: 04-1] Improve OCR layer filtering [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/135546 (owner: 10Krinkle) [10:55:05] (03Merged) 10jenkins-bot: Change one Linker::formatSize call to Message::sizeParams [core] - 10https://gerrit.wikimedia.org/r/135448 (owner: 10Umherirrender) [10:55:21] (03Abandoned) 10Krinkle: Better OCR layer filtering. [extensions/ProofreadPage] (REL1_23) - 10https://gerrit.wikimedia.org/r/135491 (owner: 10Scnd) [10:56:13] (03CR) 10Krinkle: "Please elaborate on this change. It changes a couple regex and vaguely describes itself as an improvement. A rationale, bug report and/or " [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/135546 (owner: 10Krinkle) [10:59:20] (03PS3) 10Santhosh: Qunit tests for dictionary [services/cxserver] - 10https://gerrit.wikimedia.org/r/135412 [10:59:48] (03Abandoned) 10Krinkle: Declaration of ProofreadPageContent::preloadTransform() must be [extensions/ProofreadPage] (REL1_23) - 10https://gerrit.wikimedia.org/r/135280 (https://bugzilla.wikimedia.org/63958) (owner: 10Scnd) [11:00:01] (03PS1) 10Krinkle: Declaration of ProofreadPageContent::preloadTransform() must be compatible with that of Content::preloadTransform(). [extensions/ProofreadPage] (REL1_23) - 10https://gerrit.wikimedia.org/r/135547 (https://bugzilla.wikimedia.org/63958) [11:00:15] (03CR) 10Krinkle: [C: 032] "Backport from master" [extensions/ProofreadPage] (REL1_23) - 10https://gerrit.wikimedia.org/r/135547 (https://bugzilla.wikimedia.org/63958) (owner: 10Krinkle) [11:00:27] (03Merged) 10jenkins-bot: Declaration of ProofreadPageContent::preloadTransform() must be compatible with that of Content::preloadTransform(). [extensions/ProofreadPage] (REL1_23) - 10https://gerrit.wikimedia.org/r/135547 (https://bugzilla.wikimedia.org/63958) (owner: 10Krinkle) [11:00:56] 3MediaWiki extensions / 3ProofreadPage: Fatal error: Declaration of ProofreadPageContent::preloadTransform() must be compatible with that of Content::preloadTransform() in ProofreadPageContent.php on line 262 - 10https://bugzilla.wikimedia.org/63958 (10Krinkle) 5PAT>3RES/FIX [11:01:27] 3Wikimedia / 3General/Unknown: SecurePoll PurgePrivateVoteData missing tables in dberror log - 10https://bugzilla.wikimedia.org/65790#c1 (10Sam Reed (reedy)) (In reply to Sean Pringle from comment #0) > These are trickling into dberror.log: > > Tue May 27 1:47:24 UTC 2014 terbium zhwikivoyage > PurgePrivate... [11:01:57] 3Wikimedia / 3General/Unknown: SecurePoll PurgePrivateVoteData missing tables in dberror log - 10https://bugzilla.wikimedia.org/65790 (10Sam Reed (reedy)) a:3Sam Reed (reedy) [11:03:35] (03CR) 10Krinkle: "1) Use ack instead of grep, 2) Because we they are both runners of ParserTests and we use the new PHPUnit-based one in Jenkins, not the ol" [core] - 10https://gerrit.wikimedia.org/r/135408 (owner: 10Bartosz Dziewoński) [11:05:10] (03CR) 10Krinkle: [C: 04-1] "Hm.. why not update that path like you did with the other parser test? At least be consistent (either use it from generic media/ in both, " [core] - 10https://gerrit.wikimedia.org/r/135408 (owner: 10Bartosz Dziewoński) [11:06:34] (03CR) 10Scnd: "It's not full patch https://gerrit.wikimedia.org/r/#/c/135280/2/includes/page/ProofreadPageContent.php" [extensions/ProofreadPage] (REL1_23) - 10https://gerrit.wikimedia.org/r/135547 (https://bugzilla.wikimedia.org/63958) (owner: 10Krinkle) [11:07:39] (03CR) 10Krinkle: "This is a full backport of the patch that was submitted to master 4 weeks ago (see 3e202b9a3fcbb5a58bcdc89fffd08bca1ae423f2). If you have " [extensions/ProofreadPage] (REL1_23) - 10https://gerrit.wikimedia.org/r/135547 (https://bugzilla.wikimedia.org/63958) (owner: 10Krinkle) [11:09:13] (03CR) 10Krinkle: "I imagine in that patch was intentionally not changed in order to ensure the behaviour stayed the same (it is not obvious without knowing " [extensions/ProofreadPage] (REL1_23) - 10https://gerrit.wikimedia.org/r/135547 (https://bugzilla.wikimedia.org/63958) (owner: 10Krinkle) [11:11:39] (03CR) 10Krinkle: ":)" [core] - 10https://gerrit.wikimedia.org/r/131674 (https://bugzilla.wikimedia.org/64946) (owner: 10Addshore) [11:14:15] (03CR) 10Krinkle: [C: 04-1] Allow for global renaming of users (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (https://bugzilla.wikimedia.org/14862) (owner: 10Legoktm) [11:17:37] anyone knowledgeable about mediawiki-vagrant around? [11:20:21] (03CR) 10Scnd: "https://gerrit.wikimedia.org/r/#/c/126051/" [extensions/ProofreadPage] (REL1_23) - 10https://gerrit.wikimedia.org/r/135547 (https://bugzilla.wikimedia.org/63958) (owner: 10Krinkle) [11:20:49] (03PS1) 10Krinkle: Fills $params to recursive calls of preloadTransform [extensions/ProofreadPage] (REL1_23) - 10https://gerrit.wikimedia.org/r/135548 [11:21:13] (03CR) 10Krinkle: [C: 032] "Backport from master. Thanks Scnd." [extensions/ProofreadPage] (REL1_23) - 10https://gerrit.wikimedia.org/r/135548 (owner: 10Krinkle) [11:21:25] (03Merged) 10jenkins-bot: Fills $params to recursive calls of preloadTransform [extensions/ProofreadPage] (REL1_23) - 10https://gerrit.wikimedia.org/r/135548 (owner: 10Krinkle) [11:22:28] (03CR) 10Krinkle: Allow for global renaming of users (033 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (https://bugzilla.wikimedia.org/14862) (owner: 10Legoktm) [11:23:36] (03CR) 10Krinkle: Allow for global renaming of users (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (https://bugzilla.wikimedia.org/14862) (owner: 10Legoktm) [11:25:41] 3MediaWiki extensions / 3UniversalLanguageSelector: Change Sanskrit transliteration rules - 10https://bugzilla.wikimedia.org/63895#c43 (10Runa Bhattacharjee) New pull request after review of the earlier by Kartik Mistry: https://github.com/wikimedia/jquery.ime/pull/356 [11:28:31] (03PS10) 10Divec: LinearDoc: Flattened representation of Inline HTML [services/cxserver] - 10https://gerrit.wikimedia.org/r/124287 [11:29:06] (03CR) 10Divec: LinearDoc: Flattened representation of Inline HTML (0311 comments) [services/cxserver] - 10https://gerrit.wikimedia.org/r/124287 (owner: 10Divec) [11:32:06] (03CR) 10Krinkle: History: Simplify checkboxes script on History pages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133709 (https://bugzilla.wikimedia.org/51561) (owner: 10TheDJ) [11:33:06] (03PS1) 10Prtksxna: animation: Correctly name the animation classes [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135549 [11:33:37] (03CR) 10Alex Monk: "Then what about monobook and other skins?" [core] - 10https://gerrit.wikimedia.org/r/135269 (https://bugzilla.wikimedia.org/29199) (owner: 10Alex Monk) [11:35:10] (03CR) 10Krinkle: "What is this used by / used for? There is already a jscs configuration file (which is enforced by a Grunt plugin, and there are plugins fo" [services/cxserver] - 10https://gerrit.wikimedia.org/r/135417 (owner: 10Santhosh) [11:37:07] (03CR) 10Santhosh: "There are editor(Eg: Brackets) which will recognize this from project root and apply MW style code formatting automatically on save using " [services/cxserver] - 10https://gerrit.wikimedia.org/r/135417 (owner: 10Santhosh) [11:39:01] (03PS1) 10Hashar: mw-apply-settings: make log dir world writable [integration/jenkins] - 10https://gerrit.wikimedia.org/r/135550 [11:39:27] (03CR) 10Santhosh: "I was using this with Brackets for a long time, and more team mates started using Brackets recently. So I thought it is good to have this " [services/cxserver] - 10https://gerrit.wikimedia.org/r/135417 (owner: 10Santhosh) [11:42:01] (03CR) 10Helder.wiki: "Is this extension still enabled on labs for testing?" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/134627 (https://bugzilla.wikimedia.org/52435) (owner: 10Deepali) [11:42:12] (03PS1) 10Hashar: qunit: log dir setup is already done by mw-apply-settings [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135551 [11:42:28] (03CR) 10Hashar: [C: 032] mw-apply-settings: make log dir world writable [integration/jenkins] - 10https://gerrit.wikimedia.org/r/135550 (owner: 10Hashar) [11:42:31] (03Merged) 10jenkins-bot: mw-apply-settings: make log dir world writable [integration/jenkins] - 10https://gerrit.wikimedia.org/r/135550 (owner: 10Hashar) [11:43:26] (03PS1) 10Prtksxna: animation: Add fade animations from other directions [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135552 [11:44:56] (03PS2) 10Hashar: qunit: log dir setup is already done by mw-apply-settings [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135551 [11:45:12] (03CR) 10Hashar: [C: 032] qunit: log dir setup is already done by mw-apply-settings [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135551 (owner: 10Hashar) [11:46:14] (03Merged) 10jenkins-bot: qunit: log dir setup is already done by mw-apply-settings [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135551 (owner: 10Hashar) [11:49:11] (03PS9) 10TTO: Hide edit toolbar Signature button in content namespaces by default [core] - 10https://gerrit.wikimedia.org/r/87649 (https://bugzilla.wikimedia.org/5645) [11:50:05] (03CR) 10TTO: "Addressed Krinkle's comments on patch set 8. Sorry it took so long!" [core] - 10https://gerrit.wikimedia.org/r/87649 (https://bugzilla.wikimedia.org/5645) (owner: 10TTO) [11:52:57] 3MediaWiki extensions / 3WikidataRepo: Install default gadgets from wikidata.org on the test system (beta) - 10https://bugzilla.wikimedia.org/64998#c5 (10tobias.gritschacher) @Bene*: I've now disabled (commented out) the AuthorityControl Gadget on beta. Now I realized that the Commons Gadget has an issue too... [11:55:11] 3MediaWiki extensions / 3WikidataRepo: Install default gadgets from wikidata.org on the test system (beta) - 10https://bugzilla.wikimedia.org/64998#c6 (10Lydia Pintscher) Additional thought: We could make this a lot easier for the authority control gadget if we split configuration and code. Ultimately the co... [11:58:22] (03PS1) 10Krinkle: test: Update JSHint and node-jscs configuration [services/cxserver] - 10https://gerrit.wikimedia.org/r/135553 [11:58:56] (03CR) 10Krinkle: "See also similar commits If46b94ce18a7084cf6b9a2223d and Iebd3993017cc7d9acd in oojs." [services/cxserver] - 10https://gerrit.wikimedia.org/r/135553 (owner: 10Krinkle) [12:08:12] 3MediaWiki extensions / 3FlaggedRevs: reviewAllPages.php doesn't work triggers "First argument must be a Title or WikiPage" - 10https://bugzilla.wikimedia.org/59012#c9 (10glen.84) I have the same issue with MW 1.22.6 on PHP 5.5.12. [60eb825b] [no req] Exception from line 615 of /var/www/clients/client1/we... [12:12:45] (03PS1) 10Prtksxna: Flip the animation direction if the Hovercard is flipped [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135554 [12:17:12] 3MediaWiki extensions / 3FlaggedRevs: reviewAllPages.php doesn't work triggers "First argument must be a Title or WikiPage" - 10https://bugzilla.wikimedia.org/59012#c10 (10glen.84) If I do this: if ( $page instanceof FlaggableWikiPage ) { $article = $page; } elseif ( $page instan... [12:19:19] I have this issue and I just posted some more info: https://bugzilla.wikimedia.org/show_bug.cgi?id=59012 [12:19:43] 3MediaWiki extensions / 3CirrusSearch: [Regression] CirrusSearch: Excerpts should not show normalised version (searching javacript, results all lowercase and no punctionation) - 10https://bugzilla.wikimedia.org/65803 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None I believe this change happened fairly r... [12:19:56] 3MediaWiki extensions / 3CirrusSearch: [Regression] CirrusSearch: Excerpts should not show normalised version (searching javacript, results all lowercase and no punctionation) - 10https://bugzilla.wikimedia.org/65803 (10Krinkle) p:5Unprio>3High s:5normal>3major [12:20:11] 3MediaWiki extensions / 3CirrusSearch: [Regression] CirrusSearch: Excerpts should not show normalised version (all lowercase and no punctuation) - 10https://bugzilla.wikimedia.org/65803 (10Krinkle) [12:20:41] 3MediaWiki extensions / 3WikidataRepo: display globecoordinate also when precision does not match predefined precisions - 10https://bugzilla.wikimedia.org/64887#c6 (10Adrian Lang) 5ASS>3PAT https://github.com/wmde/DataValuesJavascript/pull/39 [12:21:05] (03PS1) 10Reedy: Add SecurePoll to addWiki [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/135555 (https://bugzilla.wikimedia.org/65790) [12:21:57] (03CR) 10Reedy: [C: 032] Add SecurePoll to addWiki [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/135555 (https://bugzilla.wikimedia.org/65790) (owner: 10Reedy) [12:21:59] (03Merged) 10jenkins-bot: Add SecurePoll to addWiki [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/135555 (https://bugzilla.wikimedia.org/65790) (owner: 10Reedy) [12:22:56] 3Wikimedia / 3General/Unknown: SecurePoll PurgePrivateVoteData missing tables in dberror log - 10https://bugzilla.wikimedia.org/65790#c4 (10Sam Reed (reedy)) [13:19:25] !log Created SecurePoll tables on zerowiki, legalteamwiki, zhwikivoyage, viwikivoyage, tyvwiki [13:19:31] Logged the mess... [12:24:53] (03PS1) 10Hashar: HHVM disable stacktraces [integration/jenkins] - 10https://gerrit.wikimedia.org/r/135557 (https://bugzilla.wikimedia.org/62788) [12:24:57] 3MediaWiki / 3ContentHandler: Unable to rename wikitext pages into .js to User or MediaWiki namespace - 10https://bugzilla.wikimedia.org/53115#c4 (10Krinkle) I'm cleaning up an old script page in the Wikipedia Project-namespace (Wikipedia:FooBar) but unable to do a rename to MediaWiki:FooBar.js This seems a... [12:25:11] 3MediaWiki / 3ContentHandler: [Regression] Allow moving of pages between models (wikitext -> js / wikitext -> css) - 10https://bugzilla.wikimedia.org/43049#c6 (10Krinkle) *** Bug 53115 has been marked as a duplicate of this bug. *** [12:25:11] 3MediaWiki / 3ContentHandler: Unable to rename wikitext pages into .js to User or MediaWiki namespace - 10https://bugzilla.wikimedia.org/53115#c5 (10Krinkle) 5NEW>3RES/DUP *** This bug has been marked as a duplicate of bug 43049 *** [12:25:12] (03CR) 10Hashar: [C: 032] HHVM disable stacktraces [integration/jenkins] - 10https://gerrit.wikimedia.org/r/135557 (https://bugzilla.wikimedia.org/62788) (owner: 10Hashar) [12:25:15] (03Merged) 10jenkins-bot: HHVM disable stacktraces [integration/jenkins] - 10https://gerrit.wikimedia.org/r/135557 (https://bugzilla.wikimedia.org/62788) (owner: 10Hashar) [12:25:21] (03CR) 10TTO: "Any chance of a review on this?" [core] - 10https://gerrit.wikimedia.org/r/127592 (https://bugzilla.wikimedia.org/64167) (owner: 10TTO) [12:25:30] (03PS1) 10Jack Phoenix: Removed code related to wikiHow's BounceTimeLogger extension. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/135558 [12:25:53] (03CR) 10Jack Phoenix: [C: 032 V: 032] Removed code related to wikiHow's BounceTimeLogger extension. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/135558 (owner: 10Jack Phoenix) [12:27:26] 3MediaWiki extensions / 3SemanticForms: JQMIGRATE: jQuery.browser is deprecated - 10https://bugzilla.wikimedia.org/65668 (10Helder) [12:27:26] 3Wikimedia / 3General/Unknown: Don't use deprecated features removed in jQuery 1.9 (tracking) - 10https://bugzilla.wikimedia.org/65399 (10Helder) [12:28:11] 3Wikimedia / 3General/Unknown: Don't use deprecated features removed in jQuery 1.9 (tracking) - 10https://bugzilla.wikimedia.org/65399 (10Helder) [12:28:11] 3MediaWiki extensions / 3SemanticForms: JQMIGRATE: jQuery.fn.live() is deprecated - 10https://bugzilla.wikimedia.org/65667 (10Helder) [12:28:29] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/54455 (owner: 10Hashar) [12:28:56] 3MediaWiki / 3ContentHandler: [Regression] Allow moving of pages between models (wikitext -> js / wikitext -> css) - 10https://bugzilla.wikimedia.org/43049#c7 (10Krinkle) (Cite bug 53115 comment #4) > I'm cleaning up an old script page in the Wikipedia Project-namespace > (Wikipedia:FooBar) but unable to do... [12:30:42] 3MediaWiki extensions / 3FlaggedRevs: reviewAllPages.php doesn't work triggers "First argument must be a Title or WikiPage" - 10https://bugzilla.wikimedia.org/59012#c11 (10Florian) Because var article is an instance of class Artcile: $article = new Article( $title ); [12:30:57] 3Wikimedia / 3General/Unknown: Don't use deprecated features removed in jQuery 1.9 (tracking) - 10https://bugzilla.wikimedia.org/65399 (10Helder) [12:30:59] 3MediaWiki extensions / 3AbuseFilter: JQMIGRATE: jQuery.fn.toggle(handler, handler...) is deprecated - 10https://bugzilla.wikimedia.org/65804 (10Helder) 3NEW p:3Unprio s:3normal a:3None https://github.com/wikimedia/mediawiki-extensions-AbuseFilter/blob/master/modules/ext.abuseFilter.edit.js#L299-L305... [12:31:12] 3MediaWiki extensions / 3SemanticForms: SemanticForms: Fix "JQMIGRATE: jQuery.fn.live() is deprecated" - 10https://bugzilla.wikimedia.org/65667 (10Krinkle) [12:31:26] 3MediaWiki extensions / 3SemanticForms: SemanticForms: Fix "JQMIGRATE: jQuery.browser is deprecated" - 10https://bugzilla.wikimedia.org/65668 (10Krinkle) [12:32:26] 3MediaWiki extensions / 3SemanticForms: SemanticForms: Fix "JQMIGRATE: jQuery.fn.live() is deprecated" - 10https://bugzilla.wikimedia.org/65667 (10Krinkle) [12:35:27] 3MediaWiki extensions / 3FlaggedRevs: reviewAllPages.php doesn't work triggers "First argument must be a Title or WikiPage" - 10https://bugzilla.wikimedia.org/59012#c12 (10glen.84) (In reply to Florian from comment #11) > Because var article is an instance of class Artcile: > $article = new Article( $title )... [12:36:41] 3MediaWiki extensions / 3FlaggedRevs: reviewAllPages.php doesn't work triggers "First argument must be a Title or WikiPage" - 10https://bugzilla.wikimedia.org/59012#c13 (10Florian) I haven't installed FlaggedRevs, so can maybe someone change simple Article to WikiPage? https://github.com/wikimedia/mediawiki-... [12:37:51] (03PS1) 10Jack Phoenix: Removed some unused variables. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/135559 [12:38:09] (03CR) 10Jack Phoenix: [C: 032 V: 032] Removed some unused variables. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/135559 (owner: 10Jack Phoenix) [12:41:18] (03CR) 10Kunalgrover05: "Thank you Nikerabbit." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [12:41:30] (03Abandoned) 10Hashar: images/.htaccess breaks TransformVia404 functionality [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/132974 (https://bugzilla.wikimedia.org/65220) (owner: 10Scnd) [12:44:51] (03PS4) 10Nik: Correctly parse 'redirect' XML tag during Special:Import. [core] - 10https://gerrit.wikimedia.org/r/134079 (https://bugzilla.wikimedia.org/65481) [12:44:58] 3MediaWiki extensions / 3FlaggedRevs: reviewAllPages.php doesn't work triggers "First argument must be a Title or WikiPage" - 10https://bugzilla.wikimedia.org/59012#c14 (10glen.84) Is it fairly safe to do so? [12:45:59] Wow, the person who wrote this must be really confused about how programming works [12:46:02] if(window.nfd_autosave == false){}else if(window.nfd_autosave){}else{ nfd_autosave = true; } [12:46:18] hahaha [12:46:23] Translation: if(window.nfd_autosave != false && !window.nfd_autosave) { nfd_autosave = true; } [12:46:54] Normalised: if (window.nfd_autosave === undefined) { nfd_autosave = true; } [12:46:56] 3MediaWiki extensions / 3FlaggedRevs: reviewAllPages.php doesn't work triggers "First argument must be a Title or WikiPage" - 10https://bugzilla.wikimedia.org/59012#c15 (10Florian) If i were you, i would test this on a testwiki ;) But normally it's safe :) If i have time, i will install flaggedrev and look :) [12:47:10] (03CR) 10Hashar: "recheck" [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/135024 (owner: 10Bugsbunny) [12:50:39] (03CR) 10Hashar: "recheck" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/16922 (owner: 10Platonides) [12:50:42] (03CR) 10jenkins-bot: [V: 04-1] Block creation of new accounts with a username which exists in some other wiki. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/16922 (owner: 10Platonides) [12:52:11] 3MediaWiki extensions / 3Popups: Hovercards popping up above cause flickering (because of popping up under the mouse cursor) - 10https://bugzilla.wikimedia.org/65433#c6 (10Prateek Saxena) 5NEW>3PAT The issue was being caused on Firefox because it wasn't handling the mouseenter/mouseleave events of the an... [12:54:11] (03CR) 10Hashar: "recheck" [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/112350 (owner: 10Hchuying) [12:58:52] (03PS6) 10SG: mw-ui mixins: More colors, more browser helper mixins [core] - 10https://gerrit.wikimedia.org/r/125781 [12:59:44] (03CR) 10jenkins-bot: [V: 04-1] mw-ui mixins: More colors, more browser helper mixins [core] - 10https://gerrit.wikimedia.org/r/125781 (owner: 10SG) [13:02:56] 3MediaWiki extensions / 3FlaggedRevs: reviewAllPages.php doesn't work triggers "First argument must be a Title or WikiPage" - 10https://bugzilla.wikimedia.org/59012#c16 (10Florian) I have tested it now, seems to be the right change. I will commit it soon and then we see, what the project owners say to it, if... [13:03:41] 3MediaWiki / 3Maintenance scripts: populateRevisionLength.php displays "Content of archive unavailable" error when updating ar_len field with text stored in archive table - 10https://bugzilla.wikimedia.org/65765#c5 (10Mark A. Hershberger) Thanks for the debugging help. I recommend that you get commit access... [13:06:09] (03PS9) 10Gilles: [WIP] Generate thumbnails based on buckets [core] - 10https://gerrit.wikimedia.org/r/135008 [13:10:27] (03PS1) 10Hashar: Remove extensions which are no more in Gerrit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135561 [13:12:25] (03PS1) 10Hashar: Remove extensions which are no more in Gerrit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135562 [13:12:50] (03PS10) 10Gilles: [WIP] Generate thumbnails based on buckets [core] - 10https://gerrit.wikimedia.org/r/135008 [13:13:13] (03PS1) 10Florianschmidtwelzow: Changed $article to be instance of WikiPage [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/135563 (https://bugzilla.wikimedia.org/59012) [13:13:15] (03CR) 10Hashar: [C: 032] Remove extensions which are no more in Gerrit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135562 (owner: 10Hashar) [13:14:04] (03Merged) 10jenkins-bot: Remove extensions which are no more in Gerrit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135562 (owner: 10Hashar) [13:14:57] (03CR) 10Hashar: [C: 032] "Jobs are being deleted. Zuul trigger removed (same change-id)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135561 (owner: 10Hashar) [13:15:52] (03Merged) 10jenkins-bot: Remove extensions which are no more in Gerrit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135561 (owner: 10Hashar) [13:16:42] 3MediaWiki extensions / 3FlaggedRevs: reviewAllPages.php doesn't work triggers "First argument must be a Title or WikiPage" - 10https://bugzilla.wikimedia.org/59012#c18 (10glen.84) Nice, I tested it as well locally, and it seemed to work (although I only had one page). I will try it in production now, after... [13:24:11] 3MediaWiki / 3Maintenance scripts: populateRevisionLength.php displays "Content of archive unavailable" error when updating ar_len field with text stored in archive table - 10https://bugzilla.wikimedia.org/65765#c6 (10Mark A. Hershberger) Since I can't test this, could you try the following one-line change t... [13:25:50] (03PS1) 10Hashar: Add all extensions in Gerrit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135564 [13:26:29] 3MediaWiki extensions / 3AbuseFilter: notice when creating new filter - 10https://bugzilla.wikimedia.org/65805 (10Matthias Mullie) 3NEW p:3Unprio s:3normal a:3None Notice: Undefined index: af_throttled in extensions/AbuseFilter/Views/AbuseFilterViewEdit.php on line 148 This assumes af_throttled to e... [13:27:44] 3MediaWiki extensions / 3WikidataRepo: empty diff for supposed sitelink change - 10https://bugzilla.wikimedia.org/65806 (10Lydia Pintscher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Both of these changes have an edit summary for a sitelink change but are empty diffs: * https://www.wikidata.org/w/inde... [13:27:54] (03PS1) 10Hashar: Sync extensions with Gerrit [extensions] - 10https://gerrit.wikimedia.org/r/135565 [13:27:56] 3MediaWiki extensions / 3WikidataRepo: empty diff for supposed sitelink change - 10https://bugzilla.wikimedia.org/65806 (10Lydia Pintscher) p:5Unprio>3High [13:27:56] 3MediaWiki extensions / 3WikidataRepo: empty diff for supposed sitelink change - 10https://bugzilla.wikimedia.org/65806 (10Lydia Pintscher) [13:28:02] (03PS2) 10Hashar: Sync extensions with Gerrit [extensions] - 10https://gerrit.wikimedia.org/r/135565 [13:28:08] (03CR) 10Hashar: [C: 032 V: 032] Sync extensions with Gerrit [extensions] - 10https://gerrit.wikimedia.org/r/135565 (owner: 10Hashar) [13:28:58] 3MediaWiki extensions / 3AbuseFilter: Incorrect integer value: '' for column 'af_hidden' - 10https://bugzilla.wikimedia.org/65807 (10Matthias Mullie) 3NEW p:3Unprio s:3normal a:3None A database query error has occurred. This may indicate a bug in the software. Query: REPLACE INTO `abuse_filt... [13:29:00] (03CR) 10Santhosh: [C: 032] "Thanks Timo." [services/cxserver] - 10https://gerrit.wikimedia.org/r/135553 (owner: 10Krinkle) [13:29:22] (03Merged) 10jenkins-bot: test: Update JSHint and node-jscs configuration [services/cxserver] - 10https://gerrit.wikimedia.org/r/135553 (owner: 10Krinkle) [13:45:33] (03PS1) 10MarkAHershberger: Add ar_text to the list from Revision::selectArchiveFields(). It is checked later. [core] - 10https://gerrit.wikimedia.org/r/135567 (https://bugzilla.wikimedia.org/65765) [13:47:26] 3MediaWiki / 3Maintenance scripts: populateRevisionLength.php displays "Content of archive unavailable" error when updating ar_len field with text stored in archive table - 10https://bugzilla.wikimedia.org/65765#c8 (10Mark A. Hershberger) Please confirm that this patch fixes the problem you found so we can i... [13:51:50] (03CR) 10Hashar: "recheck" [core] - 10https://gerrit.wikimedia.org/r/132006 (owner: 10Gerrit Patch Uploader) [13:52:24] (03PS1) 10Thiemo Mättig (WMDE): Add at least one RTL language to the TestSites mock collection [core] - 10https://gerrit.wikimedia.org/r/135569 [13:54:23] (03PS6) 10Kunalgrover05: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) [13:54:52] (03PS3) 10Prtksxna: renderer: Ignore `#` links [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135188 (https://bugzilla.wikimedia.org/65425) [13:55:29] (03PS11) 10Gilles: [WIP] Generate thumbnails based on buckets [core] - 10https://gerrit.wikimedia.org/r/135008 [13:57:43] (03PS1) 10Matthias Mullie: Be more forgiving in maintenance script [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135570 [14:06:20] (03CR) 10Hashar: [C: 032] "I have deployed all the jobs. Still have to add related Zuul triggers." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135564 (owner: 10Hashar) [14:07:14] (03Merged) 10jenkins-bot: Add all extensions in Gerrit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135564 (owner: 10Hashar) [14:22:56] 3MediaWiki / 3Maintenance scripts: populateRevisionLength.php displays "Content of archive unavailable" error when updating ar_len field with text stored in archive table - 10https://bugzilla.wikimedia.org/65765#c9 (10Joerg) Hi Mark, I hereby confirm that the patch fixes the problem. Would be great, if yo... [14:29:11] 3MediaWiki extensions / 3UniversalLanguageSelector: Change Sanskrit transliteration rules - 10https://bugzilla.wikimedia.org/63895#c44 (10NehalDaveND) Runaji we used this script on http://imetesting.wmflabs.org/jquery.ime/examples/ this place. Thank you for help. Please guide us how it can be implement on sa... [14:34:07] (03PS1) 10Matthias Mullie: Don't be too strict when resolving the DB data [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135572 [14:40:15] (03CR) 10Joerg: [C: 031] "Hi Mark," [core] - 10https://gerrit.wikimedia.org/r/135567 (https://bugzilla.wikimedia.org/65765) (owner: 10MarkAHershberger) [14:41:11] 3MediaWiki extensions / 3Scribunto: Exception: Parameter 2 to ScribuntoHooks::formatLimitData() expected to be a reference, value given - 10https://bugzilla.wikimedia.org/65787#c1 (10Brad Jorsch) 5UNC>3RES/INV If you're going to use Scribunto revision b58ee1da or later, you must use MediaWiki core versio... [14:41:27] 3MediaWiki extensions / 3WikidataRepo: item statement value vanishes when setting a rank - 10https://bugzilla.wikimedia.org/65398 (10tobias.gritschacher) 5PAT>3RES/FIX [14:44:17] (03PS4) 10MarkAHershberger: Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/107110 (https://bugzilla.wikimedia.org/43817) [14:45:26] (03CR) 10jenkins-bot: [V: 04-1] Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/107110 (https://bugzilla.wikimedia.org/43817) (owner: 10MarkAHershberger) [14:46:50] (03CR) 10Aaron Schulz: [C: 032] Don't use isset() to check for null [core] - 10https://gerrit.wikimedia.org/r/135184 (owner: 10IAlex) [14:47:19] (03CR) 10Anomie: [C: 032] Revert more visibility changes in HistoryBlob.php [core] - 10https://gerrit.wikimedia.org/r/135382 (https://bugzilla.wikimedia.org/65665) (owner: 10PleaseStand) [14:48:15] (03CR) 10Aaron Schulz: [C: 032] Fix docs on File::getImageSize() they were very misleading [core] - 10https://gerrit.wikimedia.org/r/135275 (owner: 10Brian Wolff) [14:49:34] (03CR) 10MarkAHershberger: "I'd like to include this in 1.23. I've updated and tested the patch against extensions that only have 'description' instead of 'descripti" [core] - 10https://gerrit.wikimedia.org/r/107110 (https://bugzilla.wikimedia.org/43817) (owner: 10MarkAHershberger) [14:50:26] 3MediaWiki extensions / 3WikidataRepo: Improve display of lists in diffs (e.g. aliases) - 10https://bugzilla.wikimedia.org/65768 (10Lydia Pintscher) [14:50:30] (03Merged) 10jenkins-bot: Don't use isset() to check for null [core] - 10https://gerrit.wikimedia.org/r/135184 (owner: 10IAlex) [14:50:35] (03PS4) 10Ragesoss: Add compare action for course revisions [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/132982 [14:50:52] (03Merged) 10jenkins-bot: Revert more visibility changes in HistoryBlob.php [core] - 10https://gerrit.wikimedia.org/r/135382 (https://bugzilla.wikimedia.org/65665) (owner: 10PleaseStand) [14:51:11] 3MediaWiki extensions / 3WikidataClient: lua and parser tests for mismatching data type / value errors - 10https://bugzilla.wikimedia.org/65788 (10Lydia Pintscher) [14:51:58] (03PS1) 10Anomie: Revert more visibility changes in HistoryBlob.php [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135574 (https://bugzilla.wikimedia.org/65665) [14:52:04] (03CR) 10jenkins-bot: [V: 04-1] Add compare action for course revisions [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/132982 (owner: 10Ragesoss) [14:52:18] (03PS5) 10Ragesoss: Add compare action for course revisions [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/132982 [14:53:10] (03Merged) 10jenkins-bot: Fix docs on File::getImageSize() they were very misleading [core] - 10https://gerrit.wikimedia.org/r/135275 (owner: 10Brian Wolff) [14:53:41] 3MediaWiki extensions / 3WikidataRepo: Format errors consistently in claim html - 10https://bugzilla.wikimedia.org/62495 (10Aude) 5PAT>3RES/FIX [14:54:28] 3MediaWiki / 3Database: MSSQL allows opening connections without $wgDBuser being set - 10https://bugzilla.wikimedia.org/65808 (10Rainer Rillke @commons.wikimedia) 3NEW p:3Unprio s:3normal a:3None When using $wgDBWindowsAuthentication [option "Windows Authentication"] in the WebInstaller, $wgDBuser is... [14:54:57] 3MediaWiki extensions / 3WikidataClient: lua and parser tests for mismatching data type / value errors - 10https://bugzilla.wikimedia.org/65788#c1 (10tobias.gritschacher) What kind of tests do you mean? LUA tests? Browsertests? Unittests? [14:55:12] 3MediaWiki / 3Database: MSSQL allows opening connections without $wgDBuser being set - 10https://bugzilla.wikimedia.org/65808 (10Rainer Rillke @commons.wikimedia) [14:55:12] 3MediaWiki / 3Database: Microsoft SQL Server/MSSQL support (tracking) - 10https://bugzilla.wikimedia.org/9767 (10Rainer Rillke @commons.wikimedia) [14:55:27] (03CR) 10jenkins-bot: [V: 04-1] Add compare action for course revisions [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/132982 (owner: 10Ragesoss) [14:58:28] 3Wikimedia / 3Extension setup: Enable FlaggedRevs extension on ckb.wikipedia - 10https://bugzilla.wikimedia.org/65809 (10Calak) 3UNC p:3Unprio s:3normal a:3None Hello. Please enable FlaggedRevs extension on ckb.wikipedia. Extension settings (per community consensus page): elseif ( $wgDBname == 'ckbw... [14:59:56] 3Wikimedia / 3Extension setup: Enable FlaggedRevs extension on ckb.wikipedia - 10https://bugzilla.wikimedia.org/65809 (10Calak) [15:00:26] (03CR) 10Anomie: [C: 032] "SWAT deploy" [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135176 (owner: 10Jforrester) [15:01:12] 3MediaWiki extensions / 3FlaggedRevs: reviewAllPages.php doesn't work triggers "First argument must be a Title or WikiPage" - 10https://bugzilla.wikimedia.org/59012#c19 (10glen.84) It seems to have worked fine. +1 Thanks for your help! [15:03:38] (03Merged) 10jenkins-bot: Update VisualEditor to I55e16775 [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135176 (owner: 10Jforrester) [15:05:59] (03CR) 10BryanDavis: Convert sync-dir and sync-file to python (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/135513 (https://bugzilla.wikimedia.org/59225) (owner: 10BryanDavis) [15:08:29] (03CR) 10Anomie: [C: 032] "SWAT deploy" [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/135388 (https://bugzilla.wikimedia.org/65733) (owner: 10Legoktm) [15:08:31] (03CR) 10Anomie: [C: 032] "SWAT deploy" [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135389 (https://bugzilla.wikimedia.org/65733) (owner: 10Legoktm) [15:12:21] (03Merged) 10jenkins-bot: Revert "Pass phpcs-strict on includes/revisiondelete/" [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/135388 (https://bugzilla.wikimedia.org/65733) (owner: 10Legoktm) [15:13:31] (03Merged) 10jenkins-bot: Revert "Pass phpcs-strict on includes/revisiondelete/" [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135389 (https://bugzilla.wikimedia.org/65733) (owner: 10Legoktm) [15:15:11] 3Wikimedia / 3Deployment systems: Some improvements for the deployment scripts - 10https://bugzilla.wikimedia.org/40025#c15 (10Bryan Davis) 5NEW>3RES/FIX I believe that this is resolved since the merge of I08ec8e987225b8e7fb1ae2119a4623383cba4db7. The only scripts left in the scap collection that have no... [15:16:03] (03CR) 10Anomie: [C: 032] "SWAT deploy" [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135574 (https://bugzilla.wikimedia.org/65665) (owner: 10Anomie) [15:17:12] 3Wikimedia / 3Deployment systems: [scap] Rewrite Wikimedia's sync scripts (scap, sync-file, etc.) - 10https://bugzilla.wikimedia.org/27294#c7 (10Bryan Davis) 5ASS>3RES/FIX I believe that this is resolved since the merge of I08ec8e987225b8e7fb1ae2119a4623383cba4db7. The only scripts left in the scap colle... [15:19:33] (03Merged) 10jenkins-bot: Revert more visibility changes in HistoryBlob.php [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135574 (https://bugzilla.wikimedia.org/65665) (owner: 10Anomie) [15:19:41] 3Wikimedia / 3Deployment systems: sync-dblist never seems to !log - 10https://bugzilla.wikimedia.org/65368#c1 (10Bryan Davis) Needs to be rechecked once I5c6b739544a4b18d91012d30d955108753d0c0b2 is deployed to production. I believe that this should be fixed now that the sync-dblist has been ported to python. [15:20:41] 3MediaWiki extensions / 3Translate: Id and class names for Special:PageMigration need to be fixed as per the standards followed - 10https://bugzilla.wikimedia.org/65736#c5 (10Niklas Laxström) Some reading: http://csswizardry.com/2013/01/mindbemding-getting-your-head-round-bem-syntax/ Even if we don't use th... [15:21:27] (03CR) 10Anomie: [C: 032] "SWAT deploy" [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/135210 (owner: 10Jackmcbarn) [15:21:29] (03CR) 10Anomie: [C: 032] "SWAT deploy" [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135211 (owner: 10Jackmcbarn) [15:21:56] 3MediaWiki / 3Revision deletion: Fatal when revdeleting old version of image - 10https://bugzilla.wikimedia.org/65733#c12 (10Kunal Mehta (Legoktm)) 5PAT>3RES/FIX Deployed by Anomie, and I've verified it's working on wmf5 and wmf6 wikis. Apparently I don't have the ability to toggle the backport_wmf fla... [15:22:41] 3MediaWiki / 3General/Unknown: Revisions missing from mediawiki.org. - 10https://bugzilla.wikimedia.org/65665#c24 (10Brad Jorsch) 5PAT>3RES/FIX Additional patch merged and backported. [15:22:54] (03CR) 10Deepali: "Yes, it is and this change has also been merged there for testing. Please check it out here:" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/134627 (https://bugzilla.wikimedia.org/52435) (owner: 10Deepali) [15:22:56] 3Wikimedia / 3Deployment systems: Manage mediawiki-config/php symlink automatically - 10https://bugzilla.wikimedia.org/64748#c4 (10Bryan Davis) The fix from I3aafd82da4c7468b555cb311a3cdad77c089dc52 should be validated during the 1.24wmf7 deployment on 2014-05-29. [15:23:26] 3MediaWiki / 3Revision deletion: Fatal when revdeleting old version of image - 10https://bugzilla.wikimedia.org/65733 (10Greg Grossmeier) [15:23:57] ty greg-g :) [15:24:26] 3Wikimedia / 3Deployment systems: sync-dir needs to use rsync proxies like scap - 10https://bugzilla.wikimedia.org/59225#c5 (10Bryan Davis) 5PAT>3RES/FIX Use of rsync proxies for sync-dir and sync-file implemented in I5ab7b2fba2f68d3d9219947ef8ab8ac6d0160d8e. [15:25:29] (03Merged) 10jenkins-bot: Check category-move-redirect-override in content language [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/135210 (owner: 10Jackmcbarn) [15:25:31] (03CR) 10jenkins-bot: [V: 04-1] Check category-move-redirect-override in content language [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135211 (owner: 10Jackmcbarn) [15:26:49] (03CR) 10Anomie: Check category-move-redirect-override in content language [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135211 (owner: 10Jackmcbarn) [15:26:59] (03PS1) 10Matthias Mullie: [SCHEMA CHANGE] Cleanup *_user_text in DB [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135576 [15:27:02] (03CR) 10Anomie: [C: 032] "Let's see if Jenkins can find it this time" [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135211 (owner: 10Jackmcbarn) [15:27:11] legoktm: :) [15:27:11] 3Wikimedia / 3Deployment systems: Either undo php->php-1.xx symlink messiness, or automate archiving of old MediaWiki versions - 10https://bugzilla.wikimedia.org/36363#c4 (10Bryan Davis) I think this can be closed once bug 64748 has been verified as fixed. [15:27:51] * bd808 stops making bugspam for a bit. [15:27:52] (03CR) 10jenkins-bot: [V: 04-1] [SCHEMA CHANGE] Cleanup *_user_text in DB [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135576 (owner: 10Matthias Mullie) [15:29:29] (03CR) 10Aaron Schulz: Fix title handling in User::getCanonicalName (031 comment) [core] - 10https://gerrit.wikimedia.org/r/132610 (owner: 10Umherirrender) [15:30:30] (03Merged) 10jenkins-bot: Check category-move-redirect-override in content language [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135211 (owner: 10Jackmcbarn) [15:31:10] legoktm: around? have a couple of small questions about page protection [15:31:27] 3MediaWiki extensions / 3WikidataRepo: display globecoordinate also when precision does not match predefined precisions - 10https://bugzilla.wikimedia.org/64887 (10tobias.gritschacher) 5PAT>3RES/FIX [15:31:36] (03PS2) 10Matthias Mullie: [SCHEMA CHANGE] Cleanup *_user_text in DB [extensions/Flow] - 10https://gerrit.wikimedia.org/r/135576 [15:32:39] (03CR) 10Anomie: [C: 032] "SWAT deploy" [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135541 (owner: 10Amire80) [15:32:44] (03CR) 10Anomie: [C: 032] "SWAT deploy" [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/135542 (owner: 10Amire80) [15:34:11] YuviPanda: what's up? [15:34:25] (03PS5) 10Legoktm: Updater: Create user_password_expires before doMigrateUserOptions [core] - 10https://gerrit.wikimedia.org/r/133411 (https://bugzilla.wikimedia.org/63677) (owner: 10Withoutaname) [15:34:34] legoktm: looking for the most common edit protection statuses to special case in the app [15:34:48] legoktm: sysop is fully protected, what are the others? [15:35:15] autoconfirmed == semi-protection [15:35:16] legoktm: autoconfirmed is only autoconfirmed users [15:35:18] yeah [15:35:21] legoktm: is that it? [15:35:30] enwp has template editor, but that's really only used in the template namespace [15:35:35] and module namespace [15:35:39] but can technically be used anywhere [15:35:47] legoktm: right, so for those I"ll just say 'this page has been protected (' mhm [15:36:13] YuviPanda: look at 'wgRestrictionLevels' on https://noc.wikimedia.org/conf/highlight.php?file=InitialiseSettings.php [15:36:16] legoktm: and is there a way now to have two protection statuses? [15:36:20] legoktm: no, right? [15:36:28] legoktm: I mean, from the UI or API [15:36:49] realistically no, but there are still some old page rows that still have it stored in the page_restrictions column of the page table [15:37:05] in which case the API will return showing there are 2 protections [15:37:09] right [15:37:30] legoktm: right now I'm just making it a string array, but I guess I can simplify things a lot by just making it a string [15:37:41] sure [15:37:52] (03CR) 10Joerg: "Aaron's notes in Patch Set 3 lead away from the original problem: This issue is about the wrong argument in the call for stat(). This is t" [core] - 10https://gerrit.wikimedia.org/r/117027 (https://bugzilla.wikimedia.org/62148) (owner: 10AalekhN) [15:38:07] (03CR) 10Greg Grossmeier: "Can we merge and deploy before 11am Pacific, ie before wmf6 goes to non-wikipedias?" [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135208 (https://bugzilla.wikimedia.org/29199) (owner: 10Mattflaschen) [15:38:26] (03Merged) 10jenkins-bot: Update UniversalLanguageSelector [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135541 (owner: 10Amire80) [15:38:33] legoktm: cool! thanks :) [15:38:41] legoktm: also is it semi-protected or semi protected? :) [15:38:47] (03Merged) 10jenkins-bot: Update UniversalLanguageSelector [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/135542 (owner: 10Amire80) [15:39:32] (03CR) 10Legoktm: "I moved the user_password_expires to the 1.19 section so it runs before doMigrateUserOptions." [core] - 10https://gerrit.wikimedia.org/r/133411 (https://bugzilla.wikimedia.org/63677) (owner: 10Withoutaname) [15:39:56] YuviPanda: https://en.wikipedia.org/wiki/Wikipedia:PROT uses a - [15:40:03] hmm, ok [15:42:39] (03CR) 10BryanDavis: "I think Tyler is giving the right advice here on adding swiftmailer to the require section of composer.json and not directly to the mediaw" [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [15:42:52] (03PS5) 10Umherirrender: Add dynamic maxlength to Special:RevisionDelete [core] - 10https://gerrit.wikimedia.org/r/135197 (https://bugzilla.wikimedia.org/34467) [15:45:40] (03CR) 10Chad: [C: 032] Upgrade to Elasticsearch 1.2.0 [search/highlighter] - 10https://gerrit.wikimedia.org/r/135020 (owner: 10Manybubbles) [15:47:22] (03CR) 10Chad: [C: 032] Fix phrase_as_terms on different fields [search/highlighter] - 10https://gerrit.wikimedia.org/r/135023 (owner: 10Manybubbles) [15:48:13] (03PS6) 10Umherirrender: Add dynamic maxlength to Special:RevisionDelete [core] - 10https://gerrit.wikimedia.org/r/135197 (https://bugzilla.wikimedia.org/34467) [15:49:02] (03CR) 10Umherirrender: "Patch Set 6: Simplify if/elseif logic as on php side in I39df27d3edb097024d136455145505429ccdbe39" [core] - 10https://gerrit.wikimedia.org/r/135197 (https://bugzilla.wikimedia.org/34467) (owner: 10Umherirrender) [15:49:11] 3Wikimedia / 3Site requests: Change user groups rights on fa.wikipedia - 10https://bugzilla.wikimedia.org/65728#c4 (10John F. Lewis) 5PAT>3RES/FIX Deployed. [15:49:26] (03CR) 10Chad: [C: 032] Add more parameters to skip highlighting [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/135038 (owner: 10Manybubbles) [15:49:38] (03Merged) 10jenkins-bot: Add more parameters to skip highlighting [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/135038 (owner: 10Manybubbles) [15:49:42] (03CR) 10Frédéric Wang: [C: 032] Add separate database table for LaTeXML (step 3) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135495 (owner: 10Physikerwelt) [15:51:02] (03CR) 10Umherirrender: Change one Linker::formatSize call to Message::sizeParams (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135448 (owner: 10Umherirrender) [15:51:27] 3Wikimedia / 3Site requests: Change user groups rights on fa.wikipedia - 10https://bugzilla.wikimedia.org/65728#c5 (10Calak) Thank you very much. [15:54:41] 3Wikimedia / 3Site requests: Change user groups rights on fa.wikipedia - 10https://bugzilla.wikimedia.org/65728 (10jeremyb) [15:55:45] (03CR) 10MarkAHershberger: [C: 032] Add ar_text to the list from Revision::selectArchiveFields(). It is checked later. [core] - 10https://gerrit.wikimedia.org/r/135567 (https://bugzilla.wikimedia.org/65765) (owner: 10MarkAHershberger) [15:56:12] (03PS1) 10MarkAHershberger: Add ar_text to the list from Revision::selectArchiveFields(). It is checked later. [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/135578 (https://bugzilla.wikimedia.org/65765) [16:00:16] (03Merged) 10jenkins-bot: Add ar_text to the list from Revision::selectArchiveFields(). It is checked later. [core] - 10https://gerrit.wikimedia.org/r/135567 (https://bugzilla.wikimedia.org/65765) (owner: 10MarkAHershberger) [16:01:23] Hi guys, I was wondering if I'm missing something about Varnish and $u = User::newFromName('Myuser', 'creatable'); $u->load(); /* setters... */ $u->save $u>setCookies(); [16:01:57] I finished working on a SSO Extension using Firefox Accounts, but my deployment is behind varnish and it doesnt work... i'm lost. [16:03:00] (03CR) 10AndyRussG: Add compare action for course revisions (032 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/132982 (owner: 10Ragesoss) [16:03:55] (03CR) 10MarkAHershberger: [C: 032] Add ar_text to the list from Revision::selectArchiveFields(). It is checked later. [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/135578 (https://bugzilla.wikimedia.org/65765) (owner: 10MarkAHershberger) [16:06:53] (03CR) 10Phuedx: [C: 04-1] "This change is slightly different from I72aa3773aee1becbb884f4476e302700e35f565f and so it suffers from the same issues. We should all hav" [core] - 10https://gerrit.wikimedia.org/r/135054 (https://bugzilla.wikimedia.org/49002) (owner: 10Robmoen) [16:06:56] (03Merged) 10jenkins-bot: Add ar_text to the list from Revision::selectArchiveFields(). It is checked later. [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/135578 (https://bugzilla.wikimedia.org/65765) (owner: 10MarkAHershberger) [16:07:35] (03CR) 10Edokter: [C: 04-1] "See inline comment: please don't carpet-bomb non-existing vendor prefixes for transition." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125781 (owner: 10SG) [16:08:27] 3Wikimedia / 3Site requests: Enabling TemplateData editor in Catalan Wikipedia - 10https://bugzilla.wikimedia.org/65785 (10James Forrester) p:5Unprio>3Normal a:3James Forrester [16:09:56] (03CR) 10Njw: [C: 031] "Don't forget to create the referenced page: https://www.mediawiki.org/wiki/Manual:Skin_autodiscovery" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/135427 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [16:10:05] (03CR) 10Daniel Kinzler: Correctly parse 'redirect' XML tag during Special:Import. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/134079 (https://bugzilla.wikimedia.org/65481) (owner: 10Nik) [16:12:20] Rephrasing :) I’m missing something. In a SSO use-case, when creating/loading and impersonating when behind Varnish. Users are created using a webservice giving currently authorized user, and create/load the user. It works well NOT behind Varnish I create a user like: $u = User::newFromName('Myuser', 'creatable'); $u->load(); /* setters... */ $u->saveSettings(); $u>setCookies(); /* redirect */ and we are in business! VCL https://github.c [16:12:20] om/webplatform/varnish-configs/blob/master/docs.vcl Project https://github.com/webplatform/mediawiki-fxa-sso/tree/webplatform-sso [16:15:21] renoirb: my guess is that it's an issue with the varnish config. basically, varnish needs to bypass the cache for logged in users (more easily, for anyone with a session cookie). [16:15:27] 3MediaWiki extensions / 3WikidataRepo: Site link already in use error is not parsed - 10https://bugzilla.wikimedia.org/65782 (10Marius Hoch) 5PAT>3RES/FIX [16:15:42] renoirb: i'm not an expert on that side of things though. just a thought. [16:16:05] (03CR) 10Nik: Correctly parse 'redirect' XML tag during Special:Import. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/134079 (https://bugzilla.wikimedia.org/65481) (owner: 10Nik) [16:16:24] renoirb: oh, and... you may want to try and ask in #mediawiki too. [16:16:55] (03CR) 10SG: mw-ui mixins: More colors, more browser helper mixins (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125781 (owner: 10SG) [16:17:00] Thanks DanielK_WMDE__ ! I'm going to try a few times, hopefully Ryan Lane might have that small insight i’m missing [16:18:19] DanielK_WMDE__, when I’m done I’ll push to Gerrit a new fork of WebPlatformAuth, but now using a OAuth2 resource server getting user data from a Profile server endpoint. [16:18:26] renoirb: he might, but he no linger works for wikimedia, so you will probably not find him here [16:19:07] Yeah, I know DanielK_WMDE__, I’m with W3C on WebPlatform.org, I worked with him too. [16:19:12] But he still answers. [16:19:32] good :) [16:21:33] (03CR) 10Daniel Friesen: [C: 04-1] "I only see code handling i18n.php files – which we're deprecating in 1.23 and killing iirc in 1.24 – not json." [core] - 10https://gerrit.wikimedia.org/r/107110 (https://bugzilla.wikimedia.org/43817) (owner: 10MarkAHershberger) [16:25:56] 3MediaWiki / 3Database: Microsoft SQL Server/MSSQL support (tracking) - 10https://bugzilla.wikimedia.org/9767 (10Rainer Rillke @commons.wikimedia) [16:25:58] 3MediaWiki / 3Installer: MSSQL installer broken; updateRowExists returns always false - 10https://bugzilla.wikimedia.org/65813 (10Rainer Rillke @commons.wikimedia) 3NEW p:3Unprio s:3major a:3Rainer Rillke  DatabaseUpdater::updateRowExists returns always false because sqlsrv_fetch functions (which is... [16:26:26] 3MediaWiki / 3Installer: MSSQL installer broken; updateRowExists returns always false - 10https://bugzilla.wikimedia.org/65813 (10Rainer Rillke @commons.wikimedia) 5NEW>3ASS [16:29:27] 3Wikimedia / 3Site requests: Deploy TemplateData's editing tool to all wikis - 10https://bugzilla.wikimedia.org/60158 (10Krinkle) [16:29:47] (03CR) 10Anomie: [C: 031] "Seems sane to me, and seems to work locally." [core] - 10https://gerrit.wikimedia.org/r/127592 (https://bugzilla.wikimedia.org/64167) (owner: 10TTO) [16:30:49] (03CR) 10Brian Wolff: "Re: not sure how to do that" (032 comments) [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135101 (https://bugzilla.wikimedia.org/62306) (owner: 10Brian Wolff) [16:33:11] (03CR) 10Greg Grossmeier: "Reedy: Lets merge this and backport before deploy today." [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135208 (https://bugzilla.wikimedia.org/29199) (owner: 10Mattflaschen) [16:38:41] 3Wikimedia / 3Site requests: Deploy TemplateData's GUI editing tool to all wikis - 10https://bugzilla.wikimedia.org/60158 (10James Forrester) [16:39:15] (03CR) 10Mattflaschen: "This is causing a problem on 1.5.4 if there is no vagrant.d (I did not test if there is one)." (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/135508 (owner: 10Ori.livneh) [16:40:11] 3Wikimedia / 3Site requests: Deploy TemplateData's GUI editing tool to all wikis - 10https://bugzilla.wikimedia.org/60158 (10Krinkle) [16:41:09] (03PS1) 10Ori.livneh: Tolerate missing vagrant.d [vagrant] - 10https://gerrit.wikimedia.org/r/135584 [16:41:18] (03CR) 10Ori.livneh: [C: 032] Tolerate missing vagrant.d [vagrant] - 10https://gerrit.wikimedia.org/r/135584 (owner: 10Ori.livneh) [16:41:22] (03Merged) 10jenkins-bot: Tolerate missing vagrant.d [vagrant] - 10https://gerrit.wikimedia.org/r/135584 (owner: 10Ori.livneh) [16:41:26] (03CR) 10Ori.livneh: "fixed" [vagrant] - 10https://gerrit.wikimedia.org/r/135508 (owner: 10Ori.livneh) [16:42:09] (03Abandoned) 10MarkAHershberger: Release candidate 1.23.0-rc.1 [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/133244 (owner: 10MarkAHershberger) [16:43:56] (03CR) 10MarkAHershberger: "I agree with your uneasiness. And thanks for the reminder about i18n json files. Maybe there is a solution there." [core] - 10https://gerrit.wikimedia.org/r/107110 (https://bugzilla.wikimedia.org/43817) (owner: 10MarkAHershberger) [16:45:35] (03Abandoned) 10MarkAHershberger: Don't break $wgFileExtensions structure when removing 'mp4' [extensions/TimedMediaHandler] (REL1_21) - 10https://gerrit.wikimedia.org/r/132170 (https://bugzilla.wikimedia.org/55366) (owner: 10MarkAHershberger) [16:45:47] (03CR) 10Hashar: "That sounds like Browsertests 3 teaser to me. I love it. We should definitely wrap that in a Jenkins job and have them run via Gerrit/Zu" [core] - 10https://gerrit.wikimedia.org/r/133507 (owner: 10Cmcmahon) [16:46:00] (03Abandoned) 10MarkAHershberger: Don't break $wgFileExtensions structure when removing 'mp4' [extensions/TimedMediaHandler] (REL1_22) - 10https://gerrit.wikimedia.org/r/132167 (https://bugzilla.wikimedia.org/55366) (owner: 10MarkAHershberger) [16:47:20] (03PS2) 10MarkAHershberger: Parse versions in semver format [core] - 10https://gerrit.wikimedia.org/r/133249 [16:48:07] (03Abandoned) 10MarkAHershberger: Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/107110 (https://bugzilla.wikimedia.org/43817) (owner: 10MarkAHershberger) [16:50:42] 3MediaWiki / 3Maintenance scripts: populateRevisionLength.php displays "Content of archive unavailable" error when updating ar_len field with text stored in archive table - 10https://bugzilla.wikimedia.org/65765#c13 (10Mark A. Hershberger) 5PAT>3RES/FIX committed on master and REL1_23 [16:52:28] 3MediaWiki extensions / 3[other]: ZeroBanner should pass jshint - 10https://bugzilla.wikimedia.org/65817 (10Antoine "hashar" Musso) 3NEW p:3Unprio s:3normal a:3None jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editi... [16:53:14] 3MediaWiki extensions / 3[other]: ZeroPortal should pass jshint - 10https://bugzilla.wikimedia.org/65818 (10Antoine "hashar" Musso) 3NEW p:3Unprio s:3normal a:3None jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editi... [16:53:57] 3MediaWiki extensions / 3[other]: ZeroBanner should pass jshint - 10https://bugzilla.wikimedia.org/65817#c1 (10Antoine "hashar" Musso) NOTE the repository is a fork of mediawiki/extensions/ZeroRatedMobileAccess which has a similar bug: bug 61647. Might want to fix the parent repository first. See also Bug... [16:54:12] 3MediaWiki extensions / 3[other]: ZeroPortal should pass jshint - 10https://bugzilla.wikimedia.org/65818#c1 (10Antoine "hashar" Musso) NOTE the repository is a fork of mediawiki/extensions/ZeroRatedMobileAccess which has a similar bug: bug 61647. Might want to fix the parent repository first. See also Bug... [16:54:25] (03CR) 10Parent5446: Fix title handling in User::getCanonicalName (031 comment) [core] - 10https://gerrit.wikimedia.org/r/132610 (owner: 10Umherirrender) [16:54:39] (03CR) 10CSteipp: "Much needed, thanks!" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135379 (owner: 10PleaseStand) [16:55:41] 3MediaWiki extensions / 3ZeroRatedMobileAccess: ZeroRatedMobileAccess should pass jshint - 10https://bugzilla.wikimedia.org/61647#c1 (10Antoine "hashar" Musso) The ZeroRatedMobileAccess repository has been forked to two more repositories which now both have their own jshint bugs: Bug 65817 - ZeroBanner shou... [16:56:25] (03PS1) 10Hashar: Trigger ZeroBanner and ZeroPortal jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135586 (https://bugzilla.wikimedia.org/65817) [16:57:27] (03PS1) 10Alex Monk: Fix page curation bar appearing after VE closes for some users [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/135587 (https://bugzilla.wikimedia.org/65702) [16:57:43] 3MediaWiki / 3Watchlist: Make form#mw-watchlist-form collapsible - 10https://bugzilla.wikimedia.org/65819 (10Technical 13) 3NEW p:3Unprio s:3normal a:3None Please wrap
in a div.mw-collapsible so that the form can be c... [16:57:55] (03CR) 10Daniel Friesen: "> I agree with your uneasiness. And thanks for the reminder about i18n json files. Maybe there is a solution there." [core] - 10https://gerrit.wikimedia.org/r/107110 (https://bugzilla.wikimedia.org/43817) (owner: 10MarkAHershberger) [16:58:22] (03CR) 10Hashar: [C: 032] Trigger ZeroBanner and ZeroPortal jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135586 (https://bugzilla.wikimedia.org/65817) (owner: 10Hashar) [16:58:31] (03Merged) 10jenkins-bot: Trigger ZeroBanner and ZeroPortal jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135586 (https://bugzilla.wikimedia.org/65817) (owner: 10Hashar) [16:59:02] (03CR) 10Parent5446: Add hash_equals() fallback and use it (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135379 (owner: 10PleaseStand) [16:59:23] (03CR) 10Hashar: "recheck" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/135086 (owner: 10Yurik) [16:59:25] (03CR) 10jenkins-bot: [V: 04-1] Updated zeroconfig- to zero-config- message keys to avoid i18n conflicts [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/135086 (owner: 10Yurik) [16:59:26] 3MediaWiki / 3Watchlist: Make form#mw-watchlist-form collapsible - 10https://bugzilla.wikimedia.org/65819 (10Technical 13) p:5Unprio>3Normal s:5normal>3enhanc [17:01:32] (03CR) 1001tonythomas: "Should I submit a new patchset excluding the swiftmailer lib files and edits to composer.json ? and -- supposing that swift mailer is inst" [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [17:02:56] (03CR) 10Parent5446: "I think so, and just as an FYI, MediaWiki core is already set up to include autoloading information for anything composer-installed, so if" [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [17:06:02] (03CR) 1001tonythomas: "You mean, I can remove the require_once statements ?" [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [17:07:32] (03CR) 10Parent5446: "Yes" [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [17:09:21] (03PS4) 10Phuedx: Make ResourceLoaderFileModule#getAllSkinStyles return all skin styles [core] - 10https://gerrit.wikimedia.org/r/122838 (https://bugzilla.wikimedia.org/63343) [17:13:27] (03PS1) 10BryanDavis: Simplify AbstractSync [tools/scap] - 10https://gerrit.wikimedia.org/r/135588 [17:13:35] Nikerabbit: lots of "Exception from line 6291 of /usr/local/apache/common-local/php-1.24wmf5/includes/parser/Parser.php: Parser state cleared while parsing. Did you call Parser::parse recursively?" from SpecialLanguageStats- [17:17:43] (03CR) 10Krinkle: "This leaves two minor issues." [core] - 10https://gerrit.wikimedia.org/r/132006 (owner: 10Gerrit Patch Uploader) [17:18:14] (03PS7) 10Anomie: First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [17:18:34] (03CR) 10Krinkle: ""When mediawiki.js is used without ResourceLoader" can you elaborate on this? What are you doing?" [core] - 10https://gerrit.wikimedia.org/r/132006 (owner: 10Gerrit Patch Uploader) [17:19:00] (03CR) 10Anomie: First version of Page Language selector (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [17:19:41] 3Wikimedia / 3Site requests: Drop database table "namespaces" from Wikimedia wikis - 10https://bugzilla.wikimedia.org/52929#c1 (10James Forrester) Note that https://www.mediawiki.org/wiki/Requests_for_comment/Associated_namespaces plans to re-purpose and use this table – see https://www.mediawiki.org/wiki/Re... [17:20:15] (03PS5) 10Krinkle: [WIP] resourceloader: Implement "skip function" feature [core] - 10https://gerrit.wikimedia.org/r/135085 [17:20:53] (03PS1) 10Thiemo Mättig (WMDE): Avoid line break in the "All notifications" footer link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/135590 (https://bugzilla.wikimedia.org/57327) [17:21:26] 3MediaWiki extensions / 3Scribunto: Exception: Parameter 2 to ScribuntoHooks::formatLimitData() expected to be a reference, value given - 10https://bugzilla.wikimedia.org/65787#c2 (10Bob Dye) (In reply to Brad Jorsch from comment #1) > If you're going to use Scribunto revision b58ee1da or later, you must use... [17:21:37] (03CR) 10jenkins-bot: [V: 04-1] Avoid line break in the "All notifications" footer link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/135590 (https://bugzilla.wikimedia.org/57327) (owner: 10Thiemo Mättig (WMDE)) [17:22:40] (03CR) 10jenkins-bot: [V: 04-1] First version of Page Language selector [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [17:23:34] (03PS2) 10Thiemo Mättig (WMDE): Avoid line break in the "All notifications" footer link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/135590 (https://bugzilla.wikimedia.org/57327) [17:23:41] (03CR) 10jenkins-bot: [V: 04-1] Avoid line break in the "All notifications" footer link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/135590 (https://bugzilla.wikimedia.org/57327) (owner: 10Thiemo Mättig (WMDE)) [17:27:42] AaronSchulz: there was a change recently, I0d95f974d0e9c5ff45430f9f1f7b16cb5227b09c [17:28:16] (03PS6) 10Krinkle: [WIP] resourceloader: Implement "skip function" feature [core] - 10https://gerrit.wikimedia.org/r/135085 [17:28:18] (03CR) 10Krinkle: [WIP] resourceloader: Implement "skip function" feature (036 comments) [core] - 10https://gerrit.wikimedia.org/r/135085 (owner: 10Krinkle) [17:28:23] (03CR) 10MarkTraceur: "Am I crazy to think we could do this with only CSS?" [core] - 10https://gerrit.wikimedia.org/r/64556 (https://bugzilla.wikimedia.org/37109) (owner: 10Nischayn22) [17:29:19] (03PS1) 10BryanDavis: Prefer list.append() over list += list [tools/scap] - 10https://gerrit.wikimedia.org/r/135591 [17:30:14] (03CR) 10MarkTraceur: "I might abandon this actually - pending our determinations over wikidata and file metadata...thoughts?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/132785 (owner: 10MarkTraceur) [17:30:24] (03PS8) 1001tonythomas: Shifted from PEAR/PHP mailer to Swift Mailer [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) [17:30:38] (03PS1) 10Aude: Update Wikidata, fix JS issues when editing statements [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135592 [17:30:56] 3MediaWiki extensions / 3OAuth: OAuth and mobile redirection do not play nicely together - 10https://bugzilla.wikimedia.org/60034#c3 (10Erik Moeller) p:5Unprio>3High s:5normal>3major I'm increasing the importance on this as it makes it pretty much impossible to develop mobile web apps that use OAuth,... [17:32:38] AaronSchulz: is that some kind of new check? [17:33:15] AaronSchulz: does it happen when viewing the page or transcluding it? [17:33:15] possibly [17:34:16] the later [17:34:25] James_F: Great, I just found out that the version of jQuery UI we're using it before jQuery UI stopped using the deprecated methods (they support jQuery 1.6, the deprecations landed in 1.7, so they had to continue using them), which means dropping migrate is now dependent on upgrading jquery UI [17:34:47] ./ we're using is from before .. / [17:35:40] (03CR) 10Nikerabbit: [C: 032] Use language from context in Skin::subPageSubtitle [core] - 10https://gerrit.wikimedia.org/r/135449 (owner: 10Umherirrender) [17:37:02] (03PS1) 10Aaron Schulz: Tweaked HTMLCacheUpdate immediate run treshold [core] - 10https://gerrit.wikimedia.org/r/135593 [17:37:43] (03CR) 10Ori.livneh: [C: 032] Simplify AbstractSync [tools/scap] - 10https://gerrit.wikimedia.org/r/135588 (owner: 10BryanDavis) [17:38:23] (03Merged) 10jenkins-bot: Simplify AbstractSync [tools/scap] - 10https://gerrit.wikimedia.org/r/135588 (owner: 10BryanDavis) [17:38:25] Krinkle: Yes, I said this on Friday… [17:38:26] (03CR) 10Ori.livneh: [C: 032] Prefer list.append() over list += list [tools/scap] - 10https://gerrit.wikimedia.org/r/135591 (owner: 10BryanDavis) [17:38:30] AaronSchulz, yt? [17:38:39] (03Merged) 10jenkins-bot: Prefer list.append() over list += list [tools/scap] - 10https://gerrit.wikimedia.org/r/135591 (owner: 10BryanDavis) [17:39:10] (03Merged) 10jenkins-bot: Use language from context in Skin::subPageSubtitle [core] - 10https://gerrit.wikimedia.org/r/135449 (owner: 10Umherirrender) [17:39:14] (03CR) 10Aude: [C: 032] Update Wikidata, fix JS issues when editing statements [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135592 (owner: 10Aude) [17:39:15] AaronSchulz: well, I guess the best course of action is to file a bug if one doesn't exist and if there is any idea what piece of code is causing it [17:40:25] (03PS1) 10Thiemo Mättig (WMDE): Fix failing tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/135594 [17:40:57] (03CR) 10Anomie: [C: 04-1] "What about ContentHandler::getPageLanguage()? You're not calling that or its hooks anymore, but also not having that call your new stuff, " (036 comments) [core] - 10https://gerrit.wikimedia.org/r/135312 (https://bugzilla.wikimedia.org/35489) (owner: 10Kunalgrover05) [17:41:13] 3MediaWiki extensions / 3Translate: Recursive parser calls - 10https://bugzilla.wikimedia.org/65826 (10Aaron Schulz) 3NEW p:3Unprio s:3normal a:3None 2014-05-27 11:30:54 mw1166 metawiki: [68d48737] [no req] Exception from line 6291 of /usr/local/apache/common-local/php-1.24wmf5/includes/parser/Pars... [17:41:20] (03CR) 10BryanDavis: Convert sync-dir and sync-file to python (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/135513 (https://bugzilla.wikimedia.org/59225) (owner: 10BryanDavis) [17:41:41] (03CR) 10MarkAHershberger: [C: 031] "I agree with Thiemo regarding tests for this. Adding Chris as a result." [core] - 10https://gerrit.wikimedia.org/r/135309 (https://bugzilla.wikimedia.org/65224) (owner: 10Bartosz Dziewoński) [17:41:55] ori: Thanks for all the swift review and merge work! [17:43:09] bd808: np! how hard would it be to make all the top-level entrypoints like sync-dir, sync-file, etc. be subcommands of a single 'scap' executable? [17:43:21] (03Merged) 10jenkins-bot: Update Wikidata, fix JS issues when editing statements [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135592 (owner: 10Aude) [17:44:11] 3MediaWiki / 3Installer: Include short descriptions for extensions bundled in the release - 10https://bugzilla.wikimedia.org/43817 (10Mark A. Hershberger) 5PAT>3NEW [17:44:49] I *think* it would be pretty simple. The only downside I can see to that would be the retraining of everyone's muscle memory and updating any and all scripts that call one of the specific scripts. [17:45:29] (03PS3) 10Thiemo Mättig (WMDE): Avoid line break in the "All notifications" footer link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/135590 (https://bugzilla.wikimedia.org/57327) [17:45:54] bd808: it'd be worth doing, imo [17:46:12] We could handle both cases I suppose with stub scripts that warned that the old cli was deprecated. [17:46:23] i think it's ok to just send an email [17:46:41] It would be nice to clean up the pile of stuff in /usr/local/bin [17:47:07] bd808: you're familiar with https://docs.python.org/dev/library/argparse.html#argparse.ArgumentParser.add_subparsers right? [17:47:56] Yeah. I though about doing something like this when I created scap.cli.Application. [17:49:28] 3MediaWiki / 3Internationalization: add a new date format to the preferences - 10https://bugzilla.wikimedia.org/65245#c6 (10Nemo) 5UNC>3ASS a:3Nemo Created attachment 15490 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15490&action=edit Patched $datePreferences Thanks to the reporter we did o... [17:49:30] (03CR) 10Legoktm: [C: 032] "Looks like I3c555ece5c1e16c6ffcdbec6645d659531400a1b broke it." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/135594 (owner: 10Thiemo Mättig (WMDE)) [17:49:38] (03Merged) 10jenkins-bot: Fix failing tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/135594 (owner: 10Thiemo Mättig (WMDE)) [17:50:26] 3MediaWiki extensions / 3Scribunto: Exception: Parameter 2 to ScribuntoHooks::formatLimitData() expected to be a reference, value given - 10https://bugzilla.wikimedia.org/65787#c3 (10Brad Jorsch) Git won't tell you "Scribunto 1.22". And the REL1_22 branch of Scribunto doesn't contain "formatLimitData" at all. [17:55:48] (03PS1) 10Nemo bis: Add jMY to Arab date formats ($datePreferences) [core] - 10https://gerrit.wikimedia.org/r/135595 (https://bugzilla.wikimedia.org/65245) [17:56:04] (03CR) 10Parent5446: [C: 04-1] Shifted from PEAR/PHP mailer to Swift Mailer (0311 comments) [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [17:59:29] (03CR) 10Anomie: [C: 04-1] "Besides the inline comments, you should also make letitle and lenamespace mutually exclusive. Also leprefix and lenamespace. ApiBase::requ" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/135283 (owner: 10Jackmcbarn) [18:03:26] 3MediaWiki / 3Installer: Include short descriptions for extensions bundled in the release - 10https://bugzilla.wikimedia.org/43817#c21 (10Kunal Mehta (Legoktm)) I don't think this is feasible for the 1.23 release. I agree with Daniel's comments and his uneasiness: > That idea also makes me really uneasy. Ev... [18:05:17] (03PS6) 10Ragesoss: Add compare action for course revisions [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/132982 [18:05:22] (03CR) 10jenkins-bot: [V: 04-1] Add compare action for course revisions [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/132982 (owner: 10Ragesoss) [18:06:59] 3Wikimedia / 3Deployment systems: [scap] Consolidate scripts as sub-commands of `scap` - 10https://bugzilla.wikimedia.org/65827 (10Bryan Davis) 3NEW p:3Unprio s:3normal a:3None The scap family of scripts currently has multiple command line interface entry points used by deployers (scap,sync-dblist, s... [18:07:41] 3Wikimedia / 3Deployment systems: [scap] Consolidate scripts as sub-commands of `scap` - 10https://bugzilla.wikimedia.org/65827 (10Bryan Davis) p:5Unprio>3Low s:5normal>3enhanc [18:07:56] 3MediaWiki / 3Search: ApiOpensearch unable to search for pages in namespace starting with lower case letter - 10https://bugzilla.wikimedia.org/65752#c1 (10Brad Jorsch) Not an API bug, the API is just returning what PrefixSearch::search gives it. [18:08:41] 3MediaWiki extensions / 3OATHAuth: Database tables not created on Postgres: ERROR: relation "oathauth_users" does not exist - 10https://bugzilla.wikimedia.org/65658#c1 (10Tyler Romeo) 5UNC>3NEW The reason for this is because this extension does not have support for anything other than MySQL. [18:09:31] (03PS1) 10Parent5446: Move token login to separate page [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/135597 (https://bugzilla.wikimedia.org/53195) [18:10:34] (03CR) 10Parent5446: [C: 04-1] "Incorrect class documentation" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/134789 (owner: 10Parent5446) [18:12:03] (03CR) 10Chad: [C: 032] Installer: output css correctly when session errors occur [core] - 10https://gerrit.wikimedia.org/r/131334 (owner: 10Taueres) [18:13:15] (03CR) 10Chad: [C: 032] Cleaned up database reconnection logic [core] - 10https://gerrit.wikimedia.org/r/133173 (owner: 10Aaron Schulz) [18:13:52] (03PS2) 10Scnd: Improve OCR layer filtering [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/135546 (owner: 10Krinkle) [18:15:39] (03Merged) 10jenkins-bot: Installer: output css correctly when session errors occur [core] - 10https://gerrit.wikimedia.org/r/131334 (owner: 10Taueres) [18:15:41] (03CR) 10Chad: [C: 032] Introduce ContentHandler::importTransform. [core] - 10https://gerrit.wikimedia.org/r/134387 (https://bugzilla.wikimedia.org/65256) (owner: 10Daniel Kinzler) [18:15:51] (03PS2) 10Reedy: Revert "Restore search box tabindex" [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135208 (https://bugzilla.wikimedia.org/29199) (owner: 10Mattflaschen) [18:16:07] (03CR) 10Anomie: [C: 04-1] "Doesn't appear that it will actually produce the information in the output." [core] - 10https://gerrit.wikimedia.org/r/135381 (owner: 10Kunalgrover05) [18:17:03] (03Merged) 10jenkins-bot: Cleaned up database reconnection logic [core] - 10https://gerrit.wikimedia.org/r/133173 (owner: 10Aaron Schulz) [18:17:06] (03CR) 10Reedy: [C: 032] Revert "Restore search box tabindex" [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135208 (https://bugzilla.wikimedia.org/29199) (owner: 10Mattflaschen) [18:19:11] 3MediaWiki extensions / 3Translate: [TUX] Edit summary field - 10https://bugzilla.wikimedia.org/46924#c12 (10ChrisiPK) (In reply to Pau Giner from comment #6) > In order to fulfil the above goals, the design for the summary field were > made: > http://upload.wikimedia.org/wikipedia/commons/d/d5/ > Translate_... [18:21:37] (03PS1) 10Aaron Schulz: Reduce Title::invalidateCache contention a bit [core] - 10https://gerrit.wikimedia.org/r/135601 [18:26:02] (03CR) 10Chad: [C: 032] Introduce ContentHandler::exportTransform() [core] - 10https://gerrit.wikimedia.org/r/134389 (https://bugzilla.wikimedia.org/65256) (owner: 10Daniel Kinzler) [18:26:20] (03Merged) 10jenkins-bot: Introduce ContentHandler::importTransform. [core] - 10https://gerrit.wikimedia.org/r/134387 (https://bugzilla.wikimedia.org/65256) (owner: 10Daniel Kinzler) [18:26:24] (03CR) 10jenkins-bot: [V: 04-1] Revert "Restore search box tabindex" [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135208 (https://bugzilla.wikimedia.org/29199) (owner: 10Mattflaschen) [18:26:31] (03PS2) 10Aaron Schulz: Reduce Title::invalidateCache contention a bit [core] - 10https://gerrit.wikimedia.org/r/135601 [18:27:15] (03CR) 10Chad: [C: 032 V: 032] Import Modern skin from MediaWiki core [skins/Modern] - 10https://gerrit.wikimedia.org/r/119885 (owner: 10Jdlrobson) [18:27:26] (03CR) 10Chad: [C: 032 V: 032] Import CologneBlue skin from MediaWiki core [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/119884 (owner: 10Jdlrobson) [18:28:17] ffs jenkins [18:28:41] (03CR) 10Reedy: [V: 032] Revert "Restore search box tabindex" [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135208 (https://bugzilla.wikimedia.org/29199) (owner: 10Mattflaschen) [18:29:36] (03PS13) 10Chad: Move Modern and CologneBlue out of core [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [18:30:10] (03CR) 10Anomie: [C: 04-1] Make constructor of Block accept array of options (037 comments) [core] - 10https://gerrit.wikimedia.org/r/134827 (owner: 10Matěj Grabovský) [18:31:06] (03Merged) 10jenkins-bot: Introduce ContentHandler::exportTransform() [core] - 10https://gerrit.wikimedia.org/r/134389 (https://bugzilla.wikimedia.org/65256) (owner: 10Daniel Kinzler) [18:33:28] (03CR) 10Anomie: WIP Add API action=watch 'entirewatchlist' param to bulk-clear watchlist. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135293 (https://bugzilla.wikimedia.org/65058) (owner: 10MaxSem) [18:34:34] (03PS1) 10Thiemo Mättig (WMDE): Remove unused code and fix missing/broken documentation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/135604 [18:34:43] (03CR) 10jenkins-bot: [V: 04-1] Remove unused code and fix missing/broken documentation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/135604 (owner: 10Thiemo Mättig (WMDE)) [18:36:56] 3MediaWiki / 3Installer: Include short descriptions for extensions bundled in the release - 10https://bugzilla.wikimedia.org/43817#c22 (10Mark A. Hershberger) (In reply to Kunal Mehta (Legoktm) from comment #21) > We should wait for the Extension registration RfC to get implemented > (hopefully 1.24) then we... [18:38:00] (03PS1) 10Mwalker: Rebuild node_modules [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/135605 [18:38:07] (03CR) 10Chad: [C: 032] Add parameter to change rescore window sizes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/135047 (owner: 10Manybubbles) [18:38:19] (03Merged) 10jenkins-bot: Add parameter to change rescore window sizes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/135047 (owner: 10Manybubbles) [18:38:36] (03CR) 10Mwalker: [C: 032 V: 032] Rebuild node_modules [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/135605 (owner: 10Mwalker) [18:39:11] 3MediaWiki / 3Installer: MSSQL installer broken; updateRowExists returns always false - 10https://bugzilla.wikimedia.org/65813#c1 (10Umherirrender) This is used also at other places in core (In LocalRepo and LocalFile), but always with the Database::selectField method, maybe it works with that also for MSSQL... [18:39:42] (03PS3) 10Jackmcbarn: Allow filtering log entries by namespace (API) [core] - 10https://gerrit.wikimedia.org/r/135283 [18:40:38] (03CR) 10Chad: [C: 032] Fix more phrase bugs [search/highlighter] - 10https://gerrit.wikimedia.org/r/135019 (owner: 10Manybubbles) [18:42:48] (03PS7) 10Aaron Schulz: Added Range support to FileBackend::streamFile() [core] - 10https://gerrit.wikimedia.org/r/127466 [18:42:56] 3MediaWiki / 3Internationalization: add a new date format to the preferences - 10https://bugzilla.wikimedia.org/65245#c8 (10ASammour) Comment on attachment 15490 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15490 Patched $datePreferences You have to add only a new format, it will be like this: j... [18:42:59] (03CR) 10Chad: [C: 032] "We've got wide consensus on this so I'm merging." [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [18:43:17] (03PS1) 10Jforrester: Enable mediawiki.skinning.content.parsoid on Mobile target too [core] - 10https://gerrit.wikimedia.org/r/135606 (https://bugzilla.wikimedia.org/65823) [18:43:20] (03PS4) 10Jackmcbarn: Allow filtering log entries by namespace (API) [core] - 10https://gerrit.wikimedia.org/r/135283 [18:44:05] (03PS3) 10Umherirrender: Add line number as id to diff block headers [core] - 10https://gerrit.wikimedia.org/r/131031 [18:44:49] (03CR) 10Chad: [C: 032] Remove silly 'm' prefix from StubObject/DeprecatedGlobal members [core] - 10https://gerrit.wikimedia.org/r/133491 (owner: 10Chad) [18:45:04] (03CR) 10Chad: [C: 032] Remove "Help/Project" profile from Special:Search [core] - 10https://gerrit.wikimedia.org/r/132965 (owner: 10Chad) [18:45:41] 3Analytics / 3Wikimetrics: Make WikiMetrics db schema mappings match the MediaWiki schemas in labs - 10https://bugzilla.wikimedia.org/64063#c2 (10nuria) Issues with encoding that were the main concern have been fixed, on my opinion this bug can be deprioritized. [18:47:10] (03PS2) 10Thiemo Mättig (WMDE): Remove unused code and fix missing/broken documentation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/135604 [18:47:33] ^d: what about the extensions? [18:47:55] did those ever get moved to proper repos in gerrit? [18:48:12] I would have merged that skin change if they did [18:48:26] New type in javascript: intish and doubleish [18:48:37] http://asmjs.org/spec/latest/#intish [18:48:39] yay! [18:48:42] xD [18:48:45] (03PS2) 10Jackmcbarn: Allow filtering log entries by namespace (Special) [core] - 10https://gerrit.wikimedia.org/r/135284 [18:50:07] (03CR) 10Krinkle: "Nice!" [core] - 10https://gerrit.wikimedia.org/r/132965 (owner: 10Chad) [18:50:32] ^d: Hm.. did you mean to bypass remove on the removal of "Help" tab? [18:50:51] m-prefix is minor (though I wouldn't self-merge for that either), but removal of Help seems a bit more less trivial. [18:51:00] s/remove/review/ [18:51:47] (03Merged) 10jenkins-bot: Move Modern and CologneBlue out of core [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [18:52:07] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "As I said, my only objection is that this should be in the .css file with an" [core] - 10https://gerrit.wikimedia.org/r/135309 (https://bugzilla.wikimedia.org/65224) (owner: 10Bartosz Dziewoński) [18:53:02] (03Merged) 10jenkins-bot: Remove silly 'm' prefix from StubObject/DeprecatedGlobal members [core] - 10https://gerrit.wikimedia.org/r/133491 (owner: 10Chad) [18:54:11] (03Merged) 10jenkins-bot: Remove "Help/Project" profile from Special:Search [core] - 10https://gerrit.wikimedia.org/r/132965 (owner: 10Chad) [18:54:27] :o [18:55:22] <^d> Krinkle: Well nobody's reviewed it in 2 weeks since siebrand +1'd the i18n changes. [18:55:29] <^d> So yeah, I went ahead and merged :) [18:55:54] <^d> (stats back up removal. Less than roughly .01% of special:search clicks ever use it. [18:56:18] ooh we have stats [18:57:08] <^d> Nikerabbit: I asked Oliver to grep request logs for me :p [18:57:20] (03CR) 10Jdlrobson: [C: 032] "The existence of Parsoid styles in core still upsets me a lot but this does the job." [core] - 10https://gerrit.wikimedia.org/r/135606 (https://bugzilla.wikimedia.org/65823) (owner: 10Jforrester) [18:57:28] and how many of editors' searches? :) [18:57:35] ^d: eh, you really want to make my life more difficult :( [18:57:45] (03CR) 10Jforrester: ""Still"?" [core] - 10https://gerrit.wikimedia.org/r/135606 (https://bugzilla.wikimedia.org/65823) (owner: 10Jforrester) [18:58:14] <^d> MatmaRex: Not purposefully! [18:59:14] you should merge some of my pending patches now to make up for it. [18:59:15] (03CR) 10Nemo bis: "Uh, I use this all the time." [core] - 10https://gerrit.wikimedia.org/r/132965 (owner: 10Chad) [18:59:21] i have a stack that i'm going to have to rebase :( [18:59:36] <^d> I just went on a review spree to *empty* my list :) [18:59:44] <^d> (And it still has like 20-something things) [19:00:47] (03CR) 10Bartosz Dziewoński: "Ping? Raimond?" [core] - 10https://gerrit.wikimedia.org/r/132477 (https://bugzilla.wikimedia.org/58715) (owner: 10Bartosz Dziewoński) [19:01:44] (03PS3) 10Scnd: $wgImageLimits filter not correct [core] - 10https://gerrit.wikimedia.org/r/135545 (https://bugzilla.wikimedia.org/65158) [19:01:47] ^d: how about my patch to kill 30 preferences in one shot? :) [19:02:08] (03PS4) 10Scnd: $wgImageLimits filter not correct [core] - 10https://gerrit.wikimedia.org/r/135545 (https://bugzilla.wikimedia.org/65158) [19:02:19] ^d: That wasn't mentioned anywhere, nor a bug report, release note or mailing list about it afaik. [19:02:30] Not that any of those is needed, just saying it looks weird :) [19:02:43] 3Wikimedia / 3Bugzilla: bugzilla emails do not get delivered to mailing list - 10https://bugzilla.wikimedia.org/65828#c3 (10Merlijn van Deen) a:3None Moving to bugzilla project... [19:02:47] Kudos for killing stuff though. I've got my own petpeeve list [19:03:36] Krinkle: i'm hoping to write detailed release notes for this in a few months, probably [19:03:52] i was hoping to be able to standardize the "core" skins while they're still in one place [19:04:09] MatmaRex: I'm referring to removal of "help and proejt pages" from seach [19:04:10] i'll have to write patches in three repositories instead of one now [19:04:14] ah. [19:05:11] 3MediaWiki / 3Search: Should be possible to customize the search profiles. - 10https://bugzilla.wikimedia.org/22774#c2 (10Nemo) More important now due to https://gerrit.wikimedia.org/r/132965 [19:05:19] (03Merged) 10jenkins-bot: Enable mediawiki.skinning.content.parsoid on Mobile target too [core] - 10https://gerrit.wikimedia.org/r/135606 (https://bugzilla.wikimedia.org/65823) (owner: 10Jforrester) [19:05:26] ^d: Also, I don't think submitting a patch and having no feedback from anyone for 2 weeks (other than i18n review) is a ticket to just merge it. [19:05:39] You of all people :P [19:06:26] 3Wikimedia / 3Bugzilla: bugzilla emails do not get delivered to mailing list - 10https://bugzilla.wikimedia.org/65828#c4 (10Merlijn van Deen) Might be related to https://bugzilla.wikimedia.org/show_bug.cgi?id=65150 -- that change seems to co-incide with the lack of messages on the mailing list. To make sure... [19:06:42] <^d> Krinkle: I want to kill that entire bar ;-) [19:08:08] (03CR) 10Bartosz Dziewoński: [C: 032] "Pow." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/134235 (owner: 10Krinkle) [19:08:12] <^d> Nemo_bis: Less preferences always make me happy :) [19:08:15] (03Merged) 10jenkins-bot: Remove dependency on MediaWiki core skins.vector.styles module [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/134235 (owner: 10Krinkle) [19:08:24] ^d: https://gerrit.wikimedia.org/r/131727 [19:08:31] (03CR) 10Bartosz Dziewoński: "Superseded by https://gerrit.wikimedia.org/r/#/c/134235/" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/132440 (https://bugzilla.wikimedia.org/64595) (owner: 10Daniel Friesen) [19:08:40] (03Abandoned) 10Bartosz Dziewoński: Add Vector to the LESS import path from within VectorBeta [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/132440 (https://bugzilla.wikimedia.org/64595) (owner: 10Daniel Friesen) [19:08:41] Krinkle: this one has had a bug for a long time, reviews appreciated to avoid last minute -1 ;) [19:09:57] (especially if you have ideas on how to style that checkbox) [19:09:59] (03CR) 10Bartosz Dziewoński: [C: 031] "VectorBeta no longer depends on this. Can we merge this?" [core] - 10https://gerrit.wikimedia.org/r/132441 (https://bugzilla.wikimedia.org/60368) (owner: 10Daniel Friesen) [19:10:06] Krinkle: ^ this is -1'd by you [19:10:16] <^d> Nemo_bis: Yeah the UI/UX bit is all I'm worried about. Functionally it's good and I like. [19:11:01] ^d: if only the checkbox was on right side and the all/none thingy didn't touch it, it would be ok [19:11:11] (03CR) 10Bartosz Dziewoński: "https://gerrit.wikimedia.org/r/#/c/132440/, which this is marked as depending on, was superseded by https://gerrit.wikimedia.org/r/#/c/134" [core] - 10https://gerrit.wikimedia.org/r/132441 (https://bugzilla.wikimedia.org/60368) (owner: 10Daniel Friesen) [19:11:18] (Well, it's an improvement even like this IMHO, but not everyone would agree.) [19:11:40] <^d> Well if they don't agree they're wrong, duh :) [19:11:45] Nemo_bis: hm, how hard is it to move a checkbox? /me looks [19:11:47] (03PS2) 10Krinkle: Remove Vector from the default LESS import path [core] - 10https://gerrit.wikimedia.org/r/132441 (https://bugzilla.wikimedia.org/64595) (owner: 10Daniel Friesen) [19:11:52] MatmaRex: should be very easy! :) [19:11:56] (03CR) 10Krinkle: [C: 031] Remove Vector from the default LESS import path [core] - 10https://gerrit.wikimedia.org/r/132441 (https://bugzilla.wikimedia.org/64595) (owner: 10Daniel Friesen) [19:12:05] (i wouldn't be suprised if the answer was 'very', given that it's mediawiki we're talking about) [19:14:24] (03CR) 10Bartosz Dziewoński: [C: 032] "Let's do this. I hope no one has yet decided to rely on this in WMF environment." [core] - 10https://gerrit.wikimedia.org/r/132441 (https://bugzilla.wikimedia.org/64595) (owner: 10Daniel Friesen) [19:16:47] okay, search stuff time [19:17:51] (03Merged) 10jenkins-bot: Remove Vector from the default LESS import path [core] - 10https://gerrit.wikimedia.org/r/132441 (https://bugzilla.wikimedia.org/64595) (owner: 10Daniel Friesen) [19:18:16] (03CR) 10Parent5446: Make constructor of Block accept array of options (031 comment) [core] - 10https://gerrit.wikimedia.org/r/134827 (owner: 10Matěj Grabovský) [19:18:58] 3MediaWiki / 3ResourceLoader: [Regression] @import "./variables" stopped working for custom skins in 1.23 - 10https://bugzilla.wikimedia.org/64595#c28 (10Bartosz Dziewoński) 5NEW>3RES/FIX a:3Daniel Friesen This is no longer an issue with Vector removed from the import path. Bug 60368 still needs a prop... [19:19:56] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Results from commons should be sorted under results from the local wiki - 10https://bugzilla.wikimedia.org/65636#c1 (10Chad H.) Why? [19:20:12] 3MediaWiki / 3ResourceLoader: [upstream] @import in LESS should try relative path before consulting global import paths - 10https://bugzilla.wikimedia.org/60368 (10Bartosz Dziewoński) 5PAT>3NEW [19:21:11] 3MediaWiki / 3ResourceLoader: [upstream] @import in LESS should try relative path before consulting global import paths - 10https://bugzilla.wikimedia.org/60368 (10Bartosz Dziewoński) [19:21:12] 3MediaWiki / 3ResourceLoader: [upstream] @import in LESS should try relative path before consulting global import paths - 10https://bugzilla.wikimedia.org/60368 (10Bartosz Dziewoński) [19:21:30] Nemo_bis: "Notice: Use of undefined constant nsToken - assumed 'nsToken' in /var/www/wiki/includes/specials/SpecialSearch.php on line 978" [19:22:25] Hm. Why did I not have that [19:22:43] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Notice: Use of undefined constant nsToken - assumed 'nsToken' in /var/www/wiki/includes/specials/SpecialSearch.php on line 978" [core] - 10https://gerrit.wikimedia.org/r/131727 (https://bugzilla.wikimedia.org/52817) (owner: 10Nemo bis) [19:23:13] now let me look at the checkboxes [19:23:39] ugh, yeah, this looks kinda bad :( [19:24:22] http://i.imgur.com/H7lzxvt.png come on, surely we can do better than that [19:25:10] Yes :) [19:28:23] hmm. [19:34:14] (03PS7) 10Nemo bis: Save advanced search namespace prefs on Special:Search itself [core] - 10https://gerrit.wikimedia.org/r/131727 (https://bugzilla.wikimedia.org/52817) [19:35:56] 3MediaWiki extensions / 3Popups: Hovercards: Show cards for Talk page - 10https://bugzilla.wikimedia.org/65692 (10Quiddity) p:5Unprio>3Low [19:37:10] Nemo_bis: so, not really related to your patch, but the "Content pages – Multimedia – Help and Project pages – Everything – Advanced" links should totally be radio buttons instead [19:39:00] MatmaRex: tell that to ^d, he just said he wants to kill the bar :) [19:39:11] 3Analytics / 3Kraken: Hive queries inconsistently failing - 10https://bugzilla.wikimedia.org/65420#c29 (10Toby Negrin) Hi Andrew -- Oliver and I were talking and we believe that the select * query works fine on the old partitions. Could there be a difference in the configurations between the old and new pa... [19:39:22] (03CR) 10Edokter: mw-ui mixins: More colors, more browser helper mixins (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125781 (owner: 10SG) [19:39:32] I'm not sure what the implications would be of making them radio buttons. [19:40:03] we'd need more code to handle this all, probably [19:40:09] or at least different code :) [19:40:14] Would you show the "Advanced" mode AJAXily? [19:40:19] yes [19:40:35] right now changing the "mode" wipes out the search box, for example [19:40:36] that's mean [19:41:05] Not if you're searching the same thing again though [19:41:44] hmmm [19:41:51] I don't know how many times you watched newbies using Special:Search over their shoulders btw [19:41:57] (03CR) 10Matěj Grabovský: Make constructor of Block accept array of options (031 comment) [core] - 10https://gerrit.wikimedia.org/r/134827 (owner: 10Matěj Grabovský) [19:42:02] okay, this is kind of a bold plan, but what i think is: [19:42:18] (03PS1) 10BryanDavis: Replace properties with side-effects with getters [tools/scap] - 10https://gerrit.wikimedia.org/r/135617 [19:42:29] I used a fewdozens librarians as guinea pigs and the results were rather depressing, but radio buttons were certainly not their main concerns :) [19:42:45] we should "decouple" the huge array of checkboxes from the "modes", and instead just make it collapsible – and changing the mode would change the state of the (hidden by default) checkboxes [19:43:05] rename "Advanced" to "Custom" [19:43:26] 3Analytics / 3Kraken: Hive queries inconsistently failing - 10https://bugzilla.wikimedia.org/65420#c30 (10Oliver Keyes) (Clarity: that's the random sampling query in my first post. Also, 'worked' - I don't think we have the old partitions any more). [19:43:27] 3MediaWiki / 3ResourceLoader: [upstream] @import in LESS should try relative path before consulting global import paths - 10https://bugzilla.wikimedia.org/60368#c10 (10s7eph4n) Can't we just forget about lessc and replace it? Development seems to have stopped and new LESS features are not recognized. See ht... [19:43:27] and make the checkboxes uncollapse if that's selected, and collapse if it's unselected [19:43:59] we'd have a neater interface then [19:44:28] and we could put the "Search" button, and the new "Use these settings for my future searches" checkbox, below the form [19:44:56] someone should totally do what i just outlined. :> [19:45:09] Would this make the profiles more or less hard to customise? [19:45:19] and for now, i'd put the new checkbox at the very bottom anyway. [19:45:28] i don't know. (how) are they customizable? [19:45:44] you mean in site settings, or by the user searching, or what? [19:45:57] Nobody knows. :) https://bugzilla.wikimedia.org/show_bug.cgi?id=28660 [19:46:29] For instance https://translatewiki.net/wiki/Special:Search adds "Translations", but it's not possible to make it default. [19:46:39] woot [19:46:43] Nor to make one profile actually use https://translatewiki.net/wiki/Special:SearchTranslations [19:47:03] Nor to add a profile in site configuration. https://bugzilla.wikimedia.org/show_bug.cgi?id=22774 [19:47:18] Nor to make an advanced search not show all the ugly checkboxes (unless it's also a profile). [19:47:21] (on an unrelated note, Special:SearchTranslations is an incredibly annoying thing, guys) [19:47:35] (but amusingly useful) [19:47:51] (especially because the only search box on the main page of TWN points to it) [19:48:01] (so i can't go directly to a message if i know its name) [19:48:05] (which drives me mad every time) [19:49:10] (03PS1) 10Parent5446: Add non-MySQL database support [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/135618 (https://bugzilla.wikimedia.org/65658) [19:49:26] 3Analytics / 3Kraken: Hive queries inconsistently failing - 10https://bugzilla.wikimedia.org/65420#c31 (10Andrew Otto) Not sure what you mean by old and new partitions. Do you mean the single table vs the old 4 tables? There is a difference, yes, in that you query much more data by default with the webrequ... [19:51:22] (aka https://bugzilla.wikimedia.org/show_bug.cgi?id=60570 ) [19:51:39] (you can use messageid: prefix) [19:51:41] can someone tell me how $mime === null in https://github.com/wikimedia/mediawiki-core/blob/master/includes/UserMailer.php#L284 works ? [19:52:04] MatmaRex: so, how do I put the checkbox at the bottom? And bottom of what? :) [19:52:56] 3Analytics / 3Kraken: Hive queries inconsistently failing - 10https://bugzilla.wikimedia.org/65420#c32 (10Oliver Keyes) Hrm. Okay, I've tried relaunching with bits excluded to see what explodes. [19:53:35] It needs to be separated from the ns checkboxes and above the search results, so there aren't that many options. [19:54:39] Nemo_bis: i'm figuring out [19:54:50] this thing is a tiny bit messed up [19:55:00] Oh, ok, so I'll wait for you. Thanks! [19:56:56] 3MediaWiki / 3Installer: MSSQL installer broken; updateRowExists returns always false - 10https://bugzilla.wikimedia.org/65813#c2 (10Rainer Rillke @commons.wikimedia) "1 AS X" works in SQLite, MySQL and MSSQL for examle ... I just change the $vars argument to DB::selectRow(); alternatively one could re-imple... [20:00:08] (03CR) 10Umherirrender: Split messages for recent change legend and letter tooltips (031 comment) [core] - 10https://gerrit.wikimedia.org/r/132477 (https://bugzilla.wikimedia.org/58715) (owner: 10Bartosz Dziewoński) [20:00:41] Nemo_bis: something like this seems reasonable to me: http://pastebin.com/dehnpUyg [20:02:38] MatmaRex: Sure, that's fine as a start. [20:07:18] (03PS8) 10Aaron Schulz: Added Range support to FileBackend::streamFile() [core] - 10https://gerrit.wikimedia.org/r/127466 [20:11:11] (03CR) 10Anomie: "Ah, I misunderstood the existing code. On second review it looks like this patch is unnecessary, because the call to $title->getPageLangua" [core] - 10https://gerrit.wikimedia.org/r/135381 (owner: 10Kunalgrover05) [20:12:13] 3MediaWiki / 3Parser: HHVM: Array to string conversion in Parser.php - 10https://bugzilla.wikimedia.org/65830 (10Max Semenik) 3NEW p:3Unprio s:3normal a:3None Running jobs on osmium: Array to string conversion in /usr/local/apache/common-local/php-1.24wmf5/includes/parser/Parser.php:3703 Array (... [20:14:21] anomie: can you go to https://en.wikipedia.org/w/index.php?title=Module:Sandbox/Jackmcbarn/doc&action=edit , hit show preview, and look at the parser profiling data? it looks wrong to me [20:14:29] specifically, i don't think it's spending over 7 seconds in executeModule [20:20:41] 3MediaWiki extensions / 3OATHAuth: Database tables not created on Postgres: ERROR: relation "oathauth_users" does not exist - 10https://bugzilla.wikimedia.org/65658#c3 (10Rhiannon Portwood) Fantastic! Thank you! [20:21:15] jackmcbarn: Hmm... That does seem unlikely. It's probably somehow or other counting the time spent executing the module itself (the call to chunk()) as mw.executeModule instead. [20:24:27] anomie: all of the time is going towards expanding the template, and it shows some of it going toward expandTemplate [20:24:40] but hardly any [20:24:56] (03CR) 10MaxSem: Shifted from PEAR/PHP mailer to Swift Mailer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [20:26:43] 3Wikimedia / 3Wikidata: Rollback does not work on items - 10https://bugzilla.wikimedia.org/65831 (10Ajraddatz) 3NEW p:3Unprio s:3major a:3Wikidata bugs Rollback currently isn't working on any items, giving an editconflict error when none has occurred. Reverting with the (undo) button still works. [20:28:56] 3Wikimedia / 3Wikidata: Rollback does not work on items - 10https://bugzilla.wikimedia.org/65831#c1 (10John F. Lewis) p:5Unprio>3High Confirmed by Lydia in #wikidata. + CC: Aude [20:31:26] 3Wikimedia / 3Wikidata: Rollback does not work on items - 10https://bugzilla.wikimedia.org/65831 (10Lydia Pintscher) [20:31:34] MatmaRex: do you want me to amend that way, or are you going to? [20:32:01] Nemo_bis: go ahead [20:34:53] (03CR) 10Legoktm: [C: 031] "Thanks, I'll merge this after reviewing your other patch." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/135604 (owner: 10Thiemo Mättig (WMDE)) [20:44:44] Nemo_bis: http://i.imgur.com/UWTZHal.png http://i.imgur.com/886uvQZ.png [20:44:53] Nemo_bis: that's how it *should* look, in a perfect world. :) [20:45:08] legoktm: Do you know what the afch and afch-updater tools are? [20:45:17] yes [20:45:19] I'm trying to sort out what these bloody things are [20:45:24] Can you link to docs? [20:45:38] it's a gadget on enwiki: https://en.wikipedia.org/wiki/Wikipedia:AFCH [20:46:06] (03CR) 1020after4: [C: 031] "looks good to me" [tools/scap] - 10https://gerrit.wikimedia.org/r/135617 (owner: 10BryanDavis) [20:46:07] afch-updater is just a python script that automatically copies the files in the git repo onto their respective wikipages [20:46:11] 3MediaWiki / 3Parser: when TOC is hidden, it should not print - 10https://bugzilla.wikimedia.org/482#c9 (10Fomafix) 5RES/FIX>3REO Reopened. The toc gets not hidden in print when collapsed again. [20:47:02] MatmaRex: alternatively, should it be added to mw-search-togglebox in resources/src/mediawiki.special/mediawiki.special.search.js ? [20:47:11] legoktm: Is the updater's code out, or is it just a tiny bash script or something [20:47:29] MatmaRex: well, the search button on bottom would be very unfriendly :) [20:48:07] marktraceur: https://github.com/legoktm/afch-updater was my copy, but I think theo re-wrote it [20:48:50] 'kay [20:49:16] (03PS1) 10Gerrit Patch Uploader: Hide toc caption on print when collapsed [core] - 10https://gerrit.wikimedia.org/r/135692 (https://bugzilla.wikimedia.org/482) [20:49:21] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/135692 (https://bugzilla.wikimedia.org/482) (owner: 10Gerrit Patch Uploader) [20:49:29] legoktm: You're one of my favorites, thanks [20:49:40] np, why are you looking into afch anyways? :P [20:50:15] legoktm: I'm going down the list of tools trying to find code and licenses [20:50:20] It's a depressing experience [20:50:28] I've found three including the two you just gave me [20:50:28] oh. [20:50:48] (see also my mail to labs-l) [20:50:50] technically the code doesn't have to be open source, it just has to be freely licensed right? [20:50:54] Nemo_bis: eh, why? [20:51:27] marktraceur: toolserver had this nice thing where every tool had a default license, you ran $ setlicense to specify which one you wanted [20:51:49] Sure, legoktm [20:52:13] It has to be under an "Open Source License" [20:52:21] Which I assume means OSI-approved [20:53:21] right, there was a thread a few months? ago about not being able to use jslint on labs [20:54:41] (03PS8) 10Nemo bis: Save advanced search namespace prefs on Special:Search itself [core] - 10https://gerrit.wikimedia.org/r/131727 (https://bugzilla.wikimedia.org/52817) [20:55:07] MatmaRex: because on many screens there is hardly space for all the powersearch checkboxes, they wouldn't see the button [20:55:42] Anyway, I also fixed the All/None, it was simple: // Create check all/none button $checkboxes = $( '#powersearch input[id^=mw-search-ns]' ); [20:55:42] Nemo_bis: okay, but the checkboxes would be hidden by default, and would "slide out" when necessary [20:56:07] Nemo_bis: the button could be positioned to the right of the entire grey box too, i guess [20:56:19] MatmaRex: you're underestimating how easily users get lost. [20:56:23] but i have no idea what to do with the "remember" checkbox then [20:56:35] That would be better. :) May still be insufficient for non-wide screens. [20:56:40] (03PS9) 1001tonythomas: Shifted from PEAR/PHP mailer to Swift Mailer [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) [20:56:46] Nemo_bis: eh [20:56:57] Well that can be placed anywhere, one needs not worry too much about it because it's for few users after all. [20:58:30] legoktm: I removed the usage of mime in UserMailer. Looks ok ? [20:58:39] legoktm: I mean, mostly I'm worried that folks are *writing* code and then just straight up not licensing it [20:58:45] (03CR) 10Fomafix: "I tried to use the MediaWiki API in an other HTML page which already uses jQuery. So I only included mediawiki.js and I wondered because m" [core] - 10https://gerrit.wikimedia.org/r/132006 (owner: 10Gerrit Patch Uploader) [20:58:59] (03CR) 10Esanders: [C: 04-1] Fix page curation bar appearing after VE closes for some users (032 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/135587 (https://bugzilla.wikimedia.org/65702) (owner: 10Alex Monk) [20:59:01] I don't know how much it violates the letter of the TOU but it sure as hell seems to violate the spirit [20:59:46] MatmaRex: the real challenge will be doing something like this on Special:RecentChanges and Special:Watchlist. Especially if one wants to keep some UI consistency (checkboxes everywhere? nowhere?). [21:00:05] But let's kill those dozens search preferences first. :P [21:00:29] ugh. [21:00:35] (03CR) 10jenkins-bot: [V: 04-1] Shifted from PEAR/PHP mailer to Swift Mailer [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [21:01:10] tonythomas: I'll test it when I have some more time tonight [21:01:11] meh, it wouldn't be that bad. [21:01:15] actually. [21:01:20] (03CR) 10Krinkle: Fix page curation bar appearing after VE closes for some users (032 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/135587 (https://bugzilla.wikimedia.org/65702) (owner: 10Alex Monk) [21:01:23] we'd just need to HTMLForm the entire thing [21:02:49] marktraceur: I don't think anyone is intentionally trying to violate the spirit, mainly people don't realize they are. On the TS when you got an account, you picked your license and never bothered with it again. If there was a form people could fill out that said "All code in this tool is licensed under (MIT|GPL|CC-0|PD)", I think nearly everyone would fill it out [21:02:53] (03CR) 10Esanders: [Reapply] Simplify thumbnail styling to have consistency with mobile (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133301 (https://bugzilla.wikimedia.org/65160) (owner: 10Jforrester) [21:03:45] That's sort of the issue [21:04:37] (03PS1) 10Physikerwelt: Add separate database table for LaTeXML (step 4) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135693 [21:04:42] legoktm: looks like Jenkins is not happy this time - -see this https://integration.wikimedia.org/ci/job/mediawiki-core-phpunit-api/25614/console its complaining of SwiftMailer::Swift_Message() not found in library. But it used to accept earlier patchsets though. Confused [21:05:06] Nemo_bis: ugh, also. Notice: Undefined variable: ns in /var/www/wiki/includes/specials/SpecialSearch.php on line 541 [21:05:42] funnily, it still works [21:05:48] null >= 0, of course. [21:05:53] tonythomas: because before you had included all the Swift files, so the tests would run...jenkins doesn't run composer which is something we're going to need to fix for jenkins [21:06:46] (03CR) 10jenkins-bot: [V: 04-1] Add separate database table for LaTeXML (step 4) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135693 (owner: 10Physikerwelt) [21:07:10] legoktm: oh. that looks sad. But, I still wonder how PS8 passed [21:07:22] it too was a composer install [21:07:35] huh, that's weird [21:07:58] MatmaRex: getValidNamespaces can return null too? [21:08:14] Nemo_bis: you have $n in the foreach but $ns in the line below [21:08:31] *cough* [21:08:55] legoktm: yeah! kindoff. might be some other error ? [21:08:56] Nemo_bis: also, i don't think preferences should work the way you're doing it (replaced type=multiselect with type=api) [21:08:59] but let me comment properly [21:09:08] (03PS9) 10Nemo bis: Save advanced search namespace prefs on Special:Search itself [core] - 10https://gerrit.wikimedia.org/r/131727 (https://bugzilla.wikimedia.org/52817) [21:09:13] That's what you told me to do IIRC ^^ [21:09:15] maybe that code path just wasn't triggered? [21:09:31] But yes I'm confused how it worked to be honest :P [21:10:46] legoktm: Urgh why people host code on wiki, so pain [21:10:47] huh. let me send one correcting all these https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs-strict-HEAD/10932/console errors [21:11:13] marktraceur: mediawiki is a perfectly legit VCS ;) [21:11:30] marktraceur: it's a compromise between VCS and local disk only [21:12:17] Did MediaWiki's CVS exist already when mediawiki.org was created? Perhaps not. [21:13:06] (03PS10) 1001tonythomas: Shifted from PEAR/PHP mailer to Swift Mailer [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) [21:16:30] (03PS3) 10Mattflaschen: Add 'X-Robots-Tag: noindex' header in action=render pages [core] - 10https://gerrit.wikimedia.org/r/134996 (https://bugzilla.wikimedia.org/63891) (owner: 10devunt) [21:17:57] (03CR) 10Frédéric Wang: Add separate database table for LaTeXML (step 4) (032 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135693 (owner: 10Physikerwelt) [21:17:59] (03CR) 10jenkins-bot: [V: 04-1] Shifted from PEAR/PHP mailer to Swift Mailer [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [21:19:48] (03CR) 10Mattflaschen: [C: 04-1] "It works, but I think it should be in Article::render." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/134996 (https://bugzilla.wikimedia.org/63891) (owner: 10devunt) [21:20:52] (03CR) 10Frédéric Wang: "The remaining patch is still big :-( Can you split it up a bit more?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/135693 (owner: 10Physikerwelt) [21:26:41] (03CR) 10Rillke: "> In addition to invalid names there's also things we warn" [core] - 10https://gerrit.wikimedia.org/r/131971 (https://bugzilla.wikimedia.org/64912) (owner: 10Rillke) [21:28:35] (03PS7) 10BryanDavis: Add Composer managed libraries [core] - 10https://gerrit.wikimedia.org/r/119939 [21:30:30] (03CR) 10Bartosz Dziewoński: [C: 04-1] Save advanced search namespace prefs on Special:Search itself (0311 comments) [core] - 10https://gerrit.wikimedia.org/r/131727 (https://bugzilla.wikimedia.org/52817) (owner: 10Nemo bis) [21:31:07] Nemo_bis: enjoy :) i explained the preferences behavior (hopefully), and commented on the code style a bit [21:31:50] reading (and doing) [21:32:26] 3MediaWiki-Vagrant: InstantCommons no longer working in MediaWiki-Vagrant multimedia role - 10https://bugzilla.wikimedia.org/54202 (10Matthew Flaschen) [21:35:57] (03PS5) 10Cicalese: Add SelfLinkBeginHook [core] - 10https://gerrit.wikimedia.org/r/124149 (https://bugzilla.wikimedia.org/63592) [21:35:57] MatmaRex: btw, there was a time in 2006 or so when I enabled a preference that made all edits autopatrolled; then they migrated to a permission but the preference still worked for some time IIRC [21:39:14] (03PS6) 10Cicalese: Add SelfLinkBeginHook [core] - 10https://gerrit.wikimedia.org/r/124149 (https://bugzilla.wikimedia.org/63592) [21:41:06] (03CR) 10Cicalese: "OK, I believe that I have responded to all of the feedback. Thank you for your input! This patch is ready for re-review." [core] - 10https://gerrit.wikimedia.org/r/124149 (https://bugzilla.wikimedia.org/63592) (owner: 10Cicalese) [21:43:07] (03CR) 10Mattflaschen: "Interwiki was included in the MediaWiki-Vagrant MLEB before this change (it was explicitly documented as "What's more, Interwiki will inst" [vagrant] - 10https://gerrit.wikimedia.org/r/134290 (owner: 10Ori.livneh) [21:43:29] 3MediaWiki / 3Special pages: "Power search" form on Special:Search is ugly - 10https://bugzilla.wikimedia.org/65833 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None Created attachment 15492 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15492&action=edit Screenshot "Power search" form... [21:44:56] 3Wikimedia / 3Wikidata: Rollback does not work on items - 10https://bugzilla.wikimedia.org/65831#c3 (10Daniel Kinzler) Please keep this ticket open after katie's fix is merged. I'd like to have it in one of the next sprints, to investigate why this nasty workaround is needed for rollbacks. In theory, the pre... [21:45:12] 3MediaWiki / 3Special pages: "Power search" form on Special:Search is ugly - 10https://bugzilla.wikimedia.org/65833#c1 (10Bartosz Dziewoński) Created attachment 15493 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15493&action=edit Screenshot when collapsed [21:45:56] 3MediaWiki / 3Special pages: "Power search" form on Special:Search is ugly - 10https://bugzilla.wikimedia.org/65833#c2 (10Bartosz Dziewoński) Created attachment 15494 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15494&action=edit Mockup [21:46:11] 3MediaWiki / 3Special pages: "Power search" form on Special:Search is ugly - 10https://bugzilla.wikimedia.org/65833#c3 (10Bartosz Dziewoński) Created attachment 15495 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15495&action=edit Mockup when collapsed [21:46:15] (03PS1) 10Gergő Tisza: Allow media handlers to mark files as expensive [core] - 10https://gerrit.wikimedia.org/r/135701 (https://bugzilla.wikimedia.org/65691) [21:46:17] Nemo_bis: https://bugzilla.wikimedia.org/show_bug.cgi?id=65833 "Power search" form on Special:Search is ugly [21:46:19] (03PS1) 10Gergő Tisza: Add global limit to PoolCounter [core] - 10https://gerrit.wikimedia.org/r/135702 (https://bugzilla.wikimedia.org/65691) [21:46:23] (03PS1) 10Gergő Tisza: Use separate PoolCounter config for expensive thumbnails [core] - 10https://gerrit.wikimedia.org/r/135703 (https://bugzilla.wikimedia.org/65691) [21:46:41] 3MediaWiki / 3Special pages: "Power search" form on Special:Search is ugly - 10https://bugzilla.wikimedia.org/65833#c4 (10Nemo) Cf. https://www.mediawiki.org/wiki/Thread:Extension_talk:InputBox/Search_profile > Created attachment 15492 [details] > Screenshot And that's on a wiki with 18 namespaces only and... [21:48:25] (03CR) 10Hashar: "That fix https://bugzilla.wikimedia.org/show_bug.cgi?id=46283 Test suite need to be rewritten / adapted :D" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135496 (owner: 10Brian Wolff) [21:50:03] (03PS2) 10Hashar: Make PagedTiffHandler-testextensions voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135531 (owner: 10Gilles) [21:50:15] Krinkle: around? wanna merge https://gerrit.wikimedia.org/r/#/c/127358/ ? "mediawiki.searchSuggest: Show full article title as a tooltip for each suggestion" [21:50:25] (03PS3) 10Hashar: Make PagedTiffHandler-testextensions voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135531 (https://bugzilla.wikimedia.org/46283) (owner: 10Gilles) [21:52:11] (03CR) 10Hashar: [C: 032] "Thank you for fixing the rather old bug 46283 \O/" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135531 (https://bugzilla.wikimedia.org/46283) (owner: 10Gilles) [21:52:18] (03Merged) 10jenkins-bot: Make PagedTiffHandler-testextensions voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135531 (https://bugzilla.wikimedia.org/46283) (owner: 10Gilles) [21:54:04] (03PS2) 10Hashar: Add AntiSpoof to Flow dependencies [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135518 (owner: 10Legoktm) [21:56:30] (03CR) 10Hashar: [C: 032] Add AntiSpoof to Flow dependencies [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135518 (owner: 10Legoktm) [21:57:42] (03Merged) 10jenkins-bot: Add AntiSpoof to Flow dependencies [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135518 (owner: 10Legoktm) [21:57:57] (03PS2) 10Gergő Tisza: Use separate PoolCounter config for expensive thumbnails [core] - 10https://gerrit.wikimedia.org/r/135703 (https://bugzilla.wikimedia.org/65691) [22:09:11] 3MediaWiki / 3Special pages: "Power search" form on Special:Search is ugly - 10https://bugzilla.wikimedia.org/65833#c5 (10Isarra) I'd say some of it is fine as-is, and other bits are good here. The search textinput and button should probably be full-width. Also probably want to make it so the namespace check... [22:11:56] 3Wikimedia / 3Extension setup: Extensions awaiting code review to be deployed on Wikimedia wikis (tracking) - 10https://bugzilla.wikimedia.org/31235 (10Sherah Smith) [22:11:59] 3Wikimedia / 3Extension setup: Review & deploy mediawiki/extensions/FundraisingChart - 10https://bugzilla.wikimedia.org/65834 (10Sherah Smith) 3NEW p:3Unprio s:3normal a:3None FundraisingChart is a tag extension that provides embeddable charts for Fundraising datasets. [22:15:59] (03CR) 10Mattflaschen: "> I don't see that happening. The extension just knows the name(s) (that is, the domain) of the config objects. What implementation is use" [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [22:16:10] MatmaRex: To complete the troll, you might want to attach screenshot of what powersearch actually looks like in practice [22:16:11] 3Wikimedia / 3Git/Gerrit: Gerrit search: enable secondary index to allow latest operators - 10https://bugzilla.wikimedia.org/61463#c1 (10Tisza Gergő) file: search would be extremely useful to construct gerrit dashboards which show changes related to some specific topic (for example, I would like to create a... [22:16:20] e.g. including all the pretty external search engine stuff inserted into it [22:16:26] and the kind of things commons does to it [22:17:55] Krinkle: i am only concerned about the form :> [22:20:42] Hm.. Config and GlobalConfig? [22:20:50] * Krinkle is curious what makes one global [22:21:09] Ah, global as in global variable [22:21:26] 3MediaWiki / 3General/Unknown: Optimize IP::isInRange performance for CIDR comparisons - 10https://bugzilla.wikimedia.org/57021#c8 (10Bryan Davis) 5PAT>3RES/FIX Brandon Black implemented a highly optimized CIDR matching engine in Ia3b12fb90c3e7e492374a128943b014481cc2730. [22:25:46] (03PS8) 10BryanDavis: Add Composer managed libraries [core] - 10https://gerrit.wikimedia.org/r/119939 [22:26:16] (03PS10) 10Nemo bis: Save advanced search namespace prefs on Special:Search itself [core] - 10https://gerrit.wikimedia.org/r/131727 (https://bugzilla.wikimedia.org/52817) [22:27:22] (03CR) 10BryanDavis: "Diff between patch set 7 and patch set 8: +4, -9341" [core] - 10https://gerrit.wikimedia.org/r/119939 (owner: 10BryanDavis) [22:28:14] (03PS7) 10BryanDavis: Add a PSR-3 based logging interface [core] - 10https://gerrit.wikimedia.org/r/119940 [22:29:34] (03PS8) 10BryanDavis: Enable MWLogger logging for legacy logging methods [core] - 10https://gerrit.wikimedia.org/r/119941 [22:29:47] (03CR) 10MarkAHershberger: [C: 04-1] "Added one more comment. Glad to see you working on this!" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/124149 (https://bugzilla.wikimedia.org/63592) (owner: 10Cicalese) [22:29:50] (03PS4) 10BryanDavis: Enable MWLogger logging for wfLogProfilingData [core] - 10https://gerrit.wikimedia.org/r/119942 [22:29:55] (03CR) 10Aaron Schulz: Allow media handlers to mark files as expensive (032 comments) [core] - 10https://gerrit.wikimedia.org/r/135701 (https://bugzilla.wikimedia.org/65691) (owner: 10Gergő Tisza) [22:31:17] (03CR) 10Legoktm: Make abstract Config class truly implementation-agnostic (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [22:31:41] Krinkle: yeah, the class got renamed to GlobalVarConfig [22:36:13] 3MediaWiki / 3User login and signup: Tab from Username no longer sends user to Password field, but instead to Search box - 10https://bugzilla.wikimedia.org/65704#c10 (10Greg Grossmeier) a:3Alex Monk To be explicit: The cause of this has been reverted in the production branches (https://gerrit.wikimedia.org... [22:38:32] (03CR) 10Krinkle: mw.Title: Add new static methods `newFromFileName`, `newFromUserInput` (031 comment) [core] - 10https://gerrit.wikimedia.org/r/131971 (https://bugzilla.wikimedia.org/64912) (owner: 10Rillke) [22:39:04] (03CR) 10Nemo bis: "Thank you very much for the patience. Two things you pointed out are still to solve, particularly "searcheverything"." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/131727 (https://bugzilla.wikimedia.org/52817) (owner: 10Nemo bis) [22:39:17] (03CR) 10Nemo bis: [C: 04-1] Save advanced search namespace prefs on Special:Search itself [core] - 10https://gerrit.wikimedia.org/r/131727 (https://bugzilla.wikimedia.org/52817) (owner: 10Nemo bis) [22:42:02] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (7b283a9dcc) [core] - 10https://gerrit.wikimedia.org/r/135711 [22:42:41] (03CR) 10Trevor Parscal: [C: 032] Update OOjs UI to v0.1.0-pre (7b283a9dcc) [core] - 10https://gerrit.wikimedia.org/r/135711 (owner: 10Jforrester) [22:42:43] (03PS1) 10Yaron Koren: New version: 0.2 [extensions/HTMLTags] - 10https://gerrit.wikimedia.org/r/135713 [22:43:15] (03CR) 10Yaron Koren: [C: 032 V: 032] New version: 0.2 [extensions/HTMLTags] - 10https://gerrit.wikimedia.org/r/135713 (owner: 10Yaron Koren) [22:43:56] 3MediaWiki / 3Skin and page rendering: Tab index sorting doesn't make sense - 10https://bugzilla.wikimedia.org/29199#c34 (10Matthew Flaschen) We should consider possible options we have other than lastTabIndex. According to http://www.w3.org/TR/html401/interact/forms.html#adef-tabindex , positive tabindexes... [22:45:14] (03CR) 10Mattflaschen: "I think Krinkle is proposing that as a quick fix, essentially restoring the previous status quo (skins.vector.collapsibleNav was only in V" [core] - 10https://gerrit.wikimedia.org/r/135269 (https://bugzilla.wikimedia.org/29199) (owner: 10Alex Monk) [22:47:14] (03CR) 10Krinkle: "Indeed, I'd like to avoid lastTabIndex hacks wider spread making things more difficult." [core] - 10https://gerrit.wikimedia.org/r/135269 (https://bugzilla.wikimedia.org/29199) (owner: 10Alex Monk) [22:47:16] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (7b283a9dcc) [core] - 10https://gerrit.wikimedia.org/r/135711 (owner: 10Jforrester) [22:48:07] (03PS1) 10Rillke: Name implicitly created CHECK constraints [core] - 10https://gerrit.wikimedia.org/r/135714 (https://bugzilla.wikimedia.org/65757) [22:48:28] (03CR) 10Krinkle: Save advanced search namespace prefs on Special:Search itself (031 comment) [core] - 10https://gerrit.wikimedia.org/r/131727 (https://bugzilla.wikimedia.org/52817) (owner: 10Nemo bis) [22:48:58] (03CR) 10BryanDavis: "I have been testing this using a MediaWiki-Vagrant instance that has the PSR-3 and Monolog libraries installed via Composer (see instructi" [core] - 10https://gerrit.wikimedia.org/r/119941 (owner: 10BryanDavis) [22:49:35] (03CR) 10Krinkle: Name implicitly created CHECK constraints (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135714 (https://bugzilla.wikimedia.org/65757) (owner: 10Rillke) [22:49:56] 3Wikimedia / 3Deployment systems: Expose deployment status in -operations channel topic - 10https://bugzilla.wikimedia.org/52409 (10Greg Grossmeier) 5UNC>3NEW [22:50:39] (03CR) 10Krinkle: Name implicitly created CHECK constraints (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135714 (https://bugzilla.wikimedia.org/65757) (owner: 10Rillke) [22:52:07] (03PS11) 10Nemo bis: Save advanced search namespace prefs on Special:Search itself [core] - 10https://gerrit.wikimedia.org/r/131727 (https://bugzilla.wikimedia.org/52817) [22:52:12] 3Wikimedia / 3Deployment systems: [scap] Deploy events aren't showing up in graphite/gdash - 10https://bugzilla.wikimedia.org/62667 (10Greg Grossmeier) p:5High>3Normal a:5Ori Livneh>3None [22:54:11] 3Wikimedia / 3Deployment systems: Expose deployment status in -operations channel topic - 10https://bugzilla.wikimedia.org/52409#c2 (10Krinkle) The server admin log is also viewable directly. So current status of a script having been started can be seen there. The main problem is scripts that take a while t... [22:54:35] (03PS7) 10Cicalese: Add SelfLinkBeginHook [core] - 10https://gerrit.wikimedia.org/r/124149 (https://bugzilla.wikimedia.org/63592) [22:55:56] 3MediaWiki / 3Skin and page rendering: Tab index sorting doesn't make sense - 10https://bugzilla.wikimedia.org/29199#c35 (10Matthew Flaschen) (In reply to Matthew Flaschen from comment #34) > We should consider possible options we have other than lastTabIndex. > According to http://www.w3.org/TR/html401/int... [22:56:10] (03CR) 10Cicalese: "Yes! I was worried about that situation, too. Great suggestion. I have incorporated it into the new patch." [core] - 10https://gerrit.wikimedia.org/r/124149 (https://bugzilla.wikimedia.org/63592) (owner: 10Cicalese) [22:57:49] (03PS2) 10Rillke: Name implicitly created CHECK constraints [core] - 10https://gerrit.wikimedia.org/r/135714 (https://bugzilla.wikimedia.org/65757) [22:58:20] (03PS3) 10Rillke: Name implicitly created CHECK constraints [core] - 10https://gerrit.wikimedia.org/r/135714 (https://bugzilla.wikimedia.org/65757) [23:01:56] 3Wikimedia / 3Deployment systems: Expose deployment status in -operations channel topic - 10https://bugzilla.wikimedia.org/52409#c3 (10Krinkle) I think the /topic changes would get rather verbose and create even more channel noise. If we want, we could equip a bot with a PRIVMSG status protocol. E.g. !deplo... [23:03:37] (03CR) 10Brian Wolff: "I don't understand why tiff files > 10 MB are hard to thumbnail, but other file types aren't. Surely large DjVu's are just as bad as large" [core] - 10https://gerrit.wikimedia.org/r/135701 (https://bugzilla.wikimedia.org/65691) (owner: 10Gergő Tisza) [23:09:26] 3MediaWiki / 3User preferences: Handle "Search" --> "Advanced options" section of Special:Preferences on Special:Search itself - 10https://bugzilla.wikimedia.org/52817#c11 (10Quiddity) (In reply to Jesús Martínez Novo (Ciencia Al Poder) from comment #9) and (In reply to Nemo from comment #10) Use Colored-hi... [23:09:28] (03CR) 10Brian Wolff: [C: 04-1] Use separate PoolCounter config for expensive thumbnails (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135703 (https://bugzilla.wikimedia.org/65691) (owner: 10Gergő Tisza) [23:10:37] (03CR) 10Rillke: Name implicitly created CHECK constraints (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135714 (https://bugzilla.wikimedia.org/65757) (owner: 10Rillke) [23:13:56] 3Wikimedia / 3Deployment systems: Expose deployment status in -operations channel topic - 10https://bugzilla.wikimedia.org/52409#c4 (10Greg Grossmeier) (In reply to Krinkle from comment #3) > I think the /topic changes would get rather verbose and create even more > channel noise. If we want, we could equip... [23:14:11] 3Wikimedia / 3Deployment systems: Expose deployment status in -operations channel topic - 10https://bugzilla.wikimedia.org/52409 (10Greg Grossmeier) p:5Normal>3Lowest [23:19:07] (03PS4) 10Rillke: Name implicitly created CHECK constraints [core] - 10https://gerrit.wikimedia.org/r/135714 (https://bugzilla.wikimedia.org/65757) [23:20:14] (03CR) 10Aaron Schulz: "It's not really the size but the transformation and work needed. For example if making a thumbnails for a 4Gb video only needs 4 modest Ra" [core] - 10https://gerrit.wikimedia.org/r/135701 (https://bugzilla.wikimedia.org/65691) (owner: 10Gergő Tisza) [23:23:12] (03PS5) 10Rillke: Name implicitly created CHECK constraints [core] - 10https://gerrit.wikimedia.org/r/135714 (https://bugzilla.wikimedia.org/65757) [23:23:14] (03CR) 10Aaron Schulz: [C: 031] "Minor comment" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135702 (https://bugzilla.wikimedia.org/65691) (owner: 10Gergő Tisza) [23:24:21] (03PS6) 10Krinkle: jquery.suggestions: Support caching results to save http requests [core] - 10https://gerrit.wikimedia.org/r/134603 (https://bugzilla.wikimedia.org/65581) [23:24:29] (03PS10) 10Krinkle: mediawiki.searchSuggest: Enable result caching [core] - 10https://gerrit.wikimedia.org/r/134542 (https://bugzilla.wikimedia.org/65581) [23:25:06] (03PS2) 10Alex Monk: Fix page curation bar appearing after VE closes for some users [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/135587 (https://bugzilla.wikimedia.org/65702) [23:25:39] (03CR) 10MarkAHershberger: "Now that you've moved the hook, the name SelfLinkBegin looks like a misnomer. And returning (possibly) the same value no matter the what " [core] - 10https://gerrit.wikimedia.org/r/124149 (https://bugzilla.wikimedia.org/63592) (owner: 10Cicalese) [23:27:15] (03PS8) 10Rillke: mw.Title: Add new static methods `newFromFileName`, `newFromUserInput` [core] - 10https://gerrit.wikimedia.org/r/131971 (https://bugzilla.wikimedia.org/64912) [23:27:39] (03CR) 10Rillke: mw.Title: Add new static methods `newFromFileName`, `newFromUserInput` (031 comment) [core] - 10https://gerrit.wikimedia.org/r/131971 (https://bugzilla.wikimedia.org/64912) (owner: 10Rillke) [23:27:41] 3MediaWiki / 3User login and signup: Tab from Username no longer sends user to Password field, but instead to Search box - 10https://bugzilla.wikimedia.org/65704#c11 (10Matthew Flaschen) (In reply to Greg Grossmeier from comment #10) > To be explicit: > The cause of this has been reverted in the production b... [23:27:58] (03PS3) 10Jforrester: Follow-up I7b49a6dd0: Fix page curation bar reappearing after VE closes [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/135587 (https://bugzilla.wikimedia.org/65702) (owner: 10Alex Monk) [23:28:06] (03CR) 10Gergő Tisza: Use separate PoolCounter config for expensive thumbnails (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135703 (https://bugzilla.wikimedia.org/65691) (owner: 10Gergő Tisza) [23:29:13] 3MediaWiki / 3User login and signup: Tab from Username no longer sends user to Password field, but instead to Search box - 10https://bugzilla.wikimedia.org/65704#c12 (10Matthew Flaschen) 5NEW>3RES/FIX a:5Alex Monk>3Matthew Flaschen Also, this part is fixed. It's the search box that is being worked o... [23:31:24] legoktm: is that mainly for extensions? [23:31:26] [00:32] legoktm Withoutaname: take a look at https://www.mediawiki.org/wiki/Manual:Hooks/LoadExtensionSchemaUpdates you'll need to create a patch file and update the schema [23:31:35] yes [23:31:40] are you planning to modify a core table? [23:31:52] that has a different process [23:31:56] add fields to user_group [23:32:22] there's a link on that page to the dev policy, which I'm reading now [23:32:36] look at core/includes/installer/MysqlUpdater.php and SqliteUpdater.php, etc [23:33:07] look at another core change that had a schema change and look at the files that it changed [23:33:40] * ^d cries a little at the mention of *Updater classes. [23:33:43] legoktm: yes, that's all under https://www.mediawiki.org/wiki/Development_policy#Database_patches [23:34:09] why, should they have been all one updater...? [23:34:22] legoktm: is there a code "template" for extensions [23:34:23] Withoutaname: yeah, thats the guide to follow [23:34:53] I downloaded a few and I noticed they have autogenerated .gitreviews and "compatibility shims", whatever those are [23:35:01] you can look at mediawiki/extensions/example I think [23:35:18] I normally just copy an extension I previously wrote and modify it as needed [23:35:18] <^d> Withoutaname: There's so many things I dislike about the installer/updater. But I wrote more than half of it so I'm allowed to complain :) [23:35:30] (03CR) 10Brian Wolff: Use separate PoolCounter config for expensive thumbnails (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135703 (https://bugzilla.wikimedia.org/65691) (owner: 10Gergő Tisza) [23:35:45] I don't know how to generate the shims [23:36:00] the hashes seem to vary with version # [23:36:16] I wouldn't worry about the i18n shims [23:36:24] unless you want to target an old version of MW [23:36:55] oh ok [23:37:46] (03CR) 10Alex Monk: "Okay, good point. I had forgotten the collapsibleNav module was only in Vector. I'll move it over." [core] - 10https://gerrit.wikimedia.org/r/135269 (https://bugzilla.wikimedia.org/29199) (owner: 10Alex Monk) [23:39:44] (03CR) 10Gergő Tisza: Use separate PoolCounter config for expensive thumbnails (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135703 (https://bugzilla.wikimedia.org/65691) (owner: 10Gergő Tisza) [23:41:25] (03CR) 10Gergő Tisza: [C: 04-2] "Af bawolff pointed out, this should also depend on a change to PagedTiffHandler." [core] - 10https://gerrit.wikimedia.org/r/135703 (https://bugzilla.wikimedia.org/65691) (owner: 10Gergő Tisza) [23:47:20] (03CR) 10Gergő Tisza: "There was not particular reason for singling out TIFF - I just had to start somewhere, and TIFF uploads were the one which actually caused" [core] - 10https://gerrit.wikimedia.org/r/135701 (https://bugzilla.wikimedia.org/65691) (owner: 10Gergő Tisza) [23:55:00] (03PS8) 10Cicalese: Add SelfLinkBeginHook [core] - 10https://gerrit.wikimedia.org/r/124149 (https://bugzilla.wikimedia.org/63592) [23:58:18] (03CR) 10MarkAHershberger: [C: 031] "Excellent. I'll give others a day to comment before I push this in." [core] - 10https://gerrit.wikimedia.org/r/124149 (https://bugzilla.wikimedia.org/63592) (owner: 10Cicalese) [23:58:26] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Results from commons should be sorted under results from the local wiki - 10https://bugzilla.wikimedia.org/65636#c2 (10Nik Everett) Yeah, probably should have mentioned that when I filed the bug but was talking to someone. IIRC the reasoning was that resu... [23:59:37] (03CR) 10Cicalese: "Thanks again for all of your help and suggestions!" [core] - 10https://gerrit.wikimedia.org/r/124149 (https://bugzilla.wikimedia.org/63592) (owner: 10Cicalese) [23:59:39] (03CR) 10Gergő Tisza: Allow media handlers to mark files as expensive (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135701 (https://bugzilla.wikimedia.org/65691) (owner: 10Gergő Tisza)