[00:21:09] (03CR) 10Rillke: "Is there any way to edit these constraints properly? These are implicit constraints?" (038 comments) [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz) [01:20:39] (03CR) 10Daniel Friesen: [C: 04-1] Don't use autodiscovery for core skins (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135383 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [01:30:03] (03CR) 10Daniel Friesen: [C: 04-1] "- skinname vs. SkinName doesn't appear to have been settled yet in the discussion so it would be inappropriate to merge something that cha" [core] - 10https://gerrit.wikimedia.org/r/135384 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [01:38:44] (03CR) 10Chad: [C: 032] Fix MultiSegmenter when the offset gap is 0 [search/highlighter] - 10https://gerrit.wikimedia.org/r/135021 (owner: 10Manybubbles) [01:50:06] 3MediaWiki / 3Database: Explicitly name check constraints for Microsoft SQL Server schema - 10https://bugzilla.wikimedia.org/65757 (10Ryan Schmidt) 3NEW p:3Unprio s:3minor a:3None The CHECK constraints in the schema for Microsoft SQL Server (which emulate ENUM types in MySQL) are not given explicit n... [01:50:15] (03CR) 10Skizzerz: "This patch set has already been merged in, please direct issues such as the one you pointed out at bugzilla. Opened your issue as https://" [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz) [02:23:04] 3MediaWiki / 3Revision deletion: Fatal when revdeleting old version of image - 10https://bugzilla.wikimedia.org/65733#c5 (10TLSuda) 5RES/FIX>3REO Issue still persists. PHP fatal error in /usr/local/apache/common-local/php-1.24wmf5/includes/revisiondelete/RevisionDelete.php line 642: Cannot access protec... [02:31:18] 3MediaWiki / 3Revision deletion: Fatal when revdeleting old version of image - 10https://bugzilla.wikimedia.org/65733#c6 (10Marius Hoch) 5REO>3RES/FIX (In reply to TLSuda from comment #5) > Issue still persists. > > PHP fatal error in > /usr/local/apache/common-local/php-1.24wmf5/includes/revisiondelete... [02:38:39] (03PS1) 10Gnosygnu: v1.5.4.1 [xowa] - 10https://gerrit.wikimedia.org/r/135386 [02:41:25] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/135386 (owner: 10Gnosygnu) [02:42:02] 3MediaWiki / 3Database: Microsoft SQL Server/MSSQL support (tracking) - 10https://bugzilla.wikimedia.org/9767 (10Rainer Rillke @commons.wikimedia) [02:42:03] 3MediaWiki / 3Database: Explicitly name check constraints for Microsoft SQL Server schema - 10https://bugzilla.wikimedia.org/65757 (10Rainer Rillke @commons.wikimedia) [02:47:30] (03CR) 10Tim Starling: "We could have a trace interface implemented on a PSR-3 backend." [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [03:04:33] (03PS1) 10BryanDavis: Remove update-scap [tools/scap] - 10https://gerrit.wikimedia.org/r/135387 [03:10:15] Hi, I'm having trouble with mediawiki-vagrant. [03:39:27] (03PS1) 10Legoktm: Revert "Pass phpcs-strict on includes/revisiondelete/" [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/135388 (https://bugzilla.wikimedia.org/65733) [03:40:03] huh: what's the issue? [03:40:06] (03PS1) 10Legoktm: Revert "Pass phpcs-strict on includes/revisiondelete/" [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135389 (https://bugzilla.wikimedia.org/65733) [03:40:45] ori: I installed it yesterday and everything was fine, but I somehow broke it so I deleted it and tried to reinstall [03:41:07] I finished the 'vagrant up' and 127.0.0.1:8080/info.php works, but the wiki is not there [03:41:14] (03CR) 10Ori.livneh: [C: 032] Remove update-scap [tools/scap] - 10https://gerrit.wikimedia.org/r/135387 (owner: 10BryanDavis) [03:41:23] huh: run 'vagrant provision' [03:41:56] (03Merged) 10jenkins-bot: Remove update-scap [tools/scap] - 10https://gerrit.wikimedia.org/r/135387 (owner: 10BryanDavis) [03:44:53] err: /Stage[main]/Mediawiki/Exec[mediawiki setup]/returns: change from notrun to 0 failed: php /vagrant/mediawiki/maintenance/install.php devwiki admin --server http://127.0.0.1:8080 --dbpass vagrant --dbname wiki --pass vagrant --scriptpath /w --dbuser root [03:44:55] returned 1 instead of one of [0] at /tmp/vagrant-puppet-1/modules-0/mediawiki/manifests/init.pp:123 [03:45:19] 3MediaWiki / 3Revision deletion: Fatal when revdeleting old version of image - 10https://bugzilla.wikimedia.org/65733#c9 (10Kunal Mehta (Legoktm)) I've submitted backports for this and added it to the SWAT schedule for Tuesday (Monday is a holiday so no deploys) https://wikitech.wikimedia.org/w/index.php?tit... [03:47:29] huh: so mediawiki's install script is failing for some reason. to find out why, run 'vagrant ssh' and run the command manually [03:47:39] what command? [03:47:47] that is, cd to /vagrant/mediawiki, and run php maintenance/install.php devwiki admin --server http://127.0.0.1:8080 --dbpass vagrant --dbname wiki --pass vagrant --scriptpath /w --dbuser root [03:48:13] /vagrant/mediawiki is empty, why? [03:48:37] anyone feel like trying to defuse a community vs. developers situation at https://en.wikipedia.org/wiki/Wikipedia:Administrators%27_noticeboard#Category_pages_will_be_movable_soon ? [03:48:41] it should be fetched by the provisioning process [03:49:04] if it isn't, you can git clone mediawiki core into that location by yourself [03:49:41] jackmcbarn: ...wow. I'll comment [03:49:53] jackmcbarn: why is that on ANI instead of at ArbCom ? [03:49:58] :P [03:50:12] huh: don't mention that, even VE didn't end up at arbcom [03:51:09] jackmcbarn: has anyone told them that they can turn it off with the AF? [03:51:31] legoktm: they already mentioned they can do it with titleblacklist [03:51:50] * legoktm facepalms [03:51:54] (but i don't see a consensus to disable it. i see a few people screaming really loudly to, and a few people saying don't) [03:52:01] which is why the sysadmins said no to restricting it from config [03:52:19] Why are they making such a big deal about it? [03:52:22] i don't know [03:52:30] commons had a discussion about it that didn't blow up [03:53:49] What's so scary about Category moves? [03:54:01] huh: nothing [03:54:08] they insist it will lead to mass disruption though [03:54:23] but any damage that you can do like that, you can also do with cut-and-paste moves and manually redirecting [03:54:24] They realize it only moves the description, right? [03:54:27] yes [03:55:00] but "oh no, the description will be separate from the members for a few minutes" [03:56:42] you shouldn't feel like you're on the hook for justifying that change [03:57:26] i'm their convenient whipping-boy already though [03:57:59] wow, 3 edits to AN this month for me, that's a new record. [03:58:26] "I propose an official RfC be started on this topic in the village pump" ... "I strongly oppose this proposal." [03:58:26] what kills me is that there isn't a clear consensus to restrict the feature, and the people that want it are acting like there is, but we refuse to implement it [03:59:17] "I suppose we can write an admin-bot to move-protect all categories" [03:59:41] we have enough sane people on the BAG that that wouldn't happen without a clear consensus [03:59:42] ...right? [03:59:58] legoktm's response pretty much nails it, imo [04:00:53] and how does a little bug in a big feature (that's already fixed in git and scheduled for a SWAT deploy) justify killing the whole feature? [04:01:22] by the way, i haven't requested any SWAT deploys before. does it look like i did all the paperwork correctly for it? [04:02:02] yeah, your request is fine [04:02:53] jackmcbarn: are you planning to work on implementing real category moving? I think that would be really cool [04:03:04] legoktm: depending on how this goes, i might [04:06:24] don't let the angry huffing dissuade you; if this is really a radically dangerous vector of abuse it can be controlled by user rights rather than by leaving the software hobbled [04:06:53] legoktm: you got a response [04:06:59] ^ yeah, the enwp community is pretty hit or miss, and for the features they do love, they're not going to spam AN about how awesome it is :P [04:09:07] jackmcbarn: eh, you should probably stop responding now. It's not going to help your case much if you're the only person responding [04:09:22] * ori agrees [04:09:27] i guess [04:09:41] it also reinforces the (incorrect) impression that this is something you planned and executed unilaterally [04:11:34] 3MediaWiki extensions / 3Scribunto: Fatal error: Class undefined: LuaSandbox - 10https://bugzilla.wikimedia.org/65711#c1 (10Ori Livneh) 5NEW>3RES/WOR Extensions using the Zend Compatibility Layer require that the configuration option Eval.EnableZendCompat be set to 'true'. So configured, LuaSandbox works... [04:13:49] is moving a category description page any different from moving an article description page [04:14:09] What's "an article description page" ? [04:14:55] as a rhetorical example, an article without its metadata [04:15:04] without categories, templates and formatting [04:15:19] only because enwiki (and most big wmf wikis) has bots that will automatically move the members of a category redirect into their target [04:15:52] I have pywikibot downloaded if anyone wants to give it a try [04:16:22] in fact legoktm: I fixed your request for using the regular action=move method for moving catdesc pages [04:16:33] oh sweet [04:16:34] so I can send my bot down if need be :P [04:17:13] actually I think you should double-check the fix to see if it actually works [04:17:18] link? [04:17:44] https://gerrit.wikimedia.org/r/#/c/134776/ [04:18:37] yeah, looks reasonable, and xqt already merged it :) [04:18:45] ori: You were looking for (mis)impression earlier. [04:19:03] I forgive you. [04:19:09] i was? [04:19:13] I tried to use the fact category Class was a subclass of category Page, and implement Page.move that way [04:19:16] i'm lost [04:19:38] it also reinforces the (incorrect) impression [...] [04:19:45] (mis)impression is tighter. [04:19:54] And cuter. [04:20:24] look at that. it's a word. i was not aware of it. [04:20:43] Hmm. [04:21:11] NOAD is like "what are you talking about bro?" [04:21:13] But Wiktionary has it. [04:21:19] I thought it was more common. [04:26:56] (03PS2) 10Santhosh: Pageloader: Use only parsoid and remove hardcoded enwiki host [services/cxserver] - 10https://gerrit.wikimedia.org/r/135016 [04:29:26] (03PS1) 10Santhosh: Add AUTHORS.txt [services/cxserver] - 10https://gerrit.wikimedia.org/r/135390 [04:32:12] (03CR) 10KartikMistry: [C: 032] Add AUTHORS.txt [services/cxserver] - 10https://gerrit.wikimedia.org/r/135390 (owner: 10Santhosh) [04:32:32] (03Merged) 10jenkins-bot: Add AUTHORS.txt [services/cxserver] - 10https://gerrit.wikimedia.org/r/135390 (owner: 10Santhosh) [04:43:32] after I tried to enable the centralauth role I got an error https://tools.wmflabs.org/paste/view/a170acfa [04:45:43] does unset() work in MediaWiki [04:45:52] it's not highlighted in eclipse like other built-ins [04:47:08] Withoutaname: yes, it's a PHP thing [04:48:08] legoktm: PHP manual says unset() was introduced PHP 4 but we're running 5.3 right? [04:48:14] yes [04:48:36] did PHP remove it or did we [04:49:02] Didn't you just say it's in the PHP manual? [04:49:15] or does eclipse simply not highlight it? [04:49:39] ^ or that [04:49:40] it's definitely still in PHP... [04:57:49] (03CR) 10Santhosh: [C: 04-1] "As per my comments above" [services/cxserver] - 10https://gerrit.wikimedia.org/r/124287 (owner: 10Divec) [05:00:40] (03PS1) 10Hiong3-eng5: SpecialSuggest:replaced query() fn to select [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/135392 (https://bugzilla.wikimedia.org/56220) [05:05:41] (03PS1) 10AndyRussG: DBPersistenceManager: fix a test and an edge case [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/135393 [05:09:58] (03PS4) 10AndyRussG: Temporary fix for SQLite in persistence test [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/133890 (owner: 10Adamw) [05:10:05] (03CR) 10jenkins-bot: [V: 04-1] Temporary fix for SQLite in persistence test [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/133890 (owner: 10Adamw) [05:15:37] huh: eclipse might not highlight it because it's a builtin language construct, not a proper function, despite the syntactical resemble [05:16:03] Withoutaname was the one who asked [05:17:47] resemblance [05:18:19] Also, syntax highlighters are often stupid. [05:19:04] They're often simplified, basic rules. [05:19:12] And they're almost always(?) unversioned. [05:19:29] So "Python" is as specific as you can get, even though different versions behave differently. [05:23:16] (03PS4) 10Umherirrender: Add error 'pagecannotexist' to ApiBase::getTitleOrPageIdErrorMessage [core] - 10https://gerrit.wikimedia.org/r/134469 [05:31:06] (03PS1) 10AndyRussG: Add @group Campaigns to all tests [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/135394 [05:34:16] (03PS5) 10AndyRussG: Temporary fix for SQLite in persistence test [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/133890 (owner: 10Adamw) [05:36:15] It would be great, if someone could test https://gerrit.wikimedia.org/r/#/c/135290/, the shift from PEAR to swift mailer [05:36:32] (03CR) 10AndyRussG: "Rebased to _before_ the hook to run tests via "--testsuite extensions" :)" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/133890 (owner: 10Adamw) [05:39:58] ori: built-ins are highlighted in gray in eclipse [05:40:52] (03PS2) 10AndyRussG: Add a hook to discover and run all tests during "--testsuite extensions" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/133888 (owner: 10Adamw) [05:42:57] (03CR) 10AndyRussG: "Rebased to come after changes to fix up tests. Tests run! \o/" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/133888 (owner: 10Adamw) [06:01:16] (03PS1) 10Legoktm: [DO NOT MERGE] WikiHow diff [extensions/Echo] - 10https://gerrit.wikimedia.org/r/135396 [06:01:30] (03CR) 10jenkins-bot: [V: 04-1] [DO NOT MERGE] WikiHow diff [extensions/Echo] - 10https://gerrit.wikimedia.org/r/135396 (owner: 10Legoktm) [06:10:48] (03PS2) 10Legoktm: [DO NOT MERGE] WikiHow diff [extensions/Echo] - 10https://gerrit.wikimedia.org/r/135396 [06:10:56] (03CR) 10jenkins-bot: [V: 04-1] [DO NOT MERGE] WikiHow diff [extensions/Echo] - 10https://gerrit.wikimedia.org/r/135396 (owner: 10Legoktm) [06:28:32] (03PS3) 10Legoktm: [WIP] Allow anonymous users to receive notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/135396 (https://bugzilla.wikimedia.org/56828) [06:28:40] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Allow anonymous users to receive notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/135396 (https://bugzilla.wikimedia.org/56828) (owner: 10Legoktm) [06:30:43] (03PS4) 10Legoktm: [WIP] Allow anonymous users to receive notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/135396 (https://bugzilla.wikimedia.org/56828) [06:30:47] 3MediaWiki extensions / 3UniversalLanguageSelector: Tipsy (jquery.tipsy) should disappear on click - 10https://bugzilla.wikimedia.org/65664 (10Florian) 5PAT>3RES/FIX [06:30:50] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Allow anonymous users to receive notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/135396 (https://bugzilla.wikimedia.org/56828) (owner: 10Legoktm) [06:40:35] (03PS5) 10Legoktm: [WIP] Allow anonymous users to receive notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/135396 (https://bugzilla.wikimedia.org/56828) [06:40:43] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Allow anonymous users to receive notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/135396 (https://bugzilla.wikimedia.org/56828) (owner: 10Legoktm) [06:43:33] 3MediaWiki extensions / 3Translate: Fix styling issues for Special:PageMigration - 10https://bugzilla.wikimedia.org/65738#c2 (10Nemo) The CSS work is part of bug 65736. [06:52:03] 3MediaWiki extensions / 3Translate: Fix code styling issues for Special:PageMigration - 10https://bugzilla.wikimedia.org/65738 (10Nemo) [07:30:18] (03PS1) 10KartikMistry: Fix typos in comments [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135399 [07:43:33] 3Wikimedia / 3General/Unknown: Whitelist OASIS OpenDocument file format - 10https://bugzilla.wikimedia.org/2089#c48 (10Nemo) What's concretely the configuration setting needed here? (In reply to Jean-Fred from comment #46) > Good. I’ll open a community consultation soonish. Ping. (In reply to dacuetu from... [07:45:33] 3Wikimedia / 3General/Unknown: Whitelist OASIS OpenDocument file format - 10https://bugzilla.wikimedia.org/2089#c49 (10Nemo) Also, https://commons.wikimedia.org/wiki/Commons:Project_scope/Allowable_file_types is apolicy and states the formats are allowed by policy, just blocked on technical reasons. «SXW, SW... [07:45:48] 3Wikimedia / 3General/Unknown: Whitelist OASIS OpenDocument file format - 10https://bugzilla.wikimedia.org/2089 (10Nemo) p:5Low>3Normal [07:55:33] 3MediaWiki extensions / 3Translate: Add feature for manual splitting of translation units for Special:PageMigration - 10https://bugzilla.wikimedia.org/65739#c3 (10Pratik Lahoti) Yes, keeping it simple seems the way to go. The text selection is lost on button click event and hence window.getSelection() would... [08:21:12] (03CR) 10Hashar: [C: 032] "Well done thanks!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135093 (https://bugzilla.wikimedia.org/61639) (owner: 10Gerrit Patch Uploader) [08:21:21] (03Merged) 10jenkins-bot: mwext-TitleBlacklist-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135093 (https://bugzilla.wikimedia.org/61639) (owner: 10Gerrit Patch Uploader) [08:22:18] 3MediaWiki extensions / 3TitleBlacklist: TitleBlacklist should pass jshint - 10https://bugzilla.wikimedia.org/61639#c5 (10Antoine "hashar" Musso) 5PAT>3RES/FIX Thank you! The Jenkins job is now voting :) [08:25:47] 3MediaWiki extensions / 3CentralAuth: Show global groups on Special:CentralAuth - 10https://bugzilla.wikimedia.org/53920#c1 (10Kunal Mehta (Legoktm)) 5NEW>3RES/DUP *** This bug has been marked as a duplicate of bug 56045 *** [08:25:48] 3MediaWiki extensions / 3CentralAuth: List global group membership on Special:CentralAuth - 10https://bugzilla.wikimedia.org/56045#c10 (10Kunal Mehta (Legoktm)) *** Bug 53920 has been marked as a duplicate of this bug. *** [08:34:33] 3MediaWiki extensions / 3CentralAuth: wpReasonList shouldn't be in ContentLanguage - 10https://bugzilla.wikimedia.org/41191#c1 (10Kunal Mehta (Legoktm)) Isn't that intentional? So local additions/overrides to the reason list show up for all users? [08:38:11] (03PS1) 10Hashar: beta: sync list of wiki db to update [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135402 (https://bugzilla.wikimedia.org/65677) [08:39:06] (03PS1) 10Orbartal: Fix the code according to the requests in the code review2. [extensions/ReorderParserPhases] - 10https://gerrit.wikimedia.org/r/135403 [08:39:18] 3MediaWiki extensions / 3CentralAuth: Title of [[Special:CentralAuth]] in read-only mode - 10https://bugzilla.wikimedia.org/27142 (10Kunal Mehta (Legoktm)) [08:39:18] (03PS2) 10Hashar: beta: sync list of wiki db to update [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135402 (https://bugzilla.wikimedia.org/65677) [08:40:22] (03CR) 10TheDJ: "Mark asked me if I remembered what the problem was here. This related to: https://bugzilla.wikimedia.org/show_bug.cgi?id=39852" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65318 (https://bugzilla.wikimedia.org/40921) (owner: 10TheDJ) [08:40:35] marktraceur: commented on that UW issues [08:40:38] -s [08:49:24] (03CR) 10Hashar: [C: 032] "Job deployed. fawiki still failing though." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135402 (https://bugzilla.wikimedia.org/65677) (owner: 10Hashar) [08:50:12] (03Merged) 10jenkins-bot: beta: sync list of wiki db to update [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135402 (https://bugzilla.wikimedia.org/65677) (owner: 10Hashar) [08:53:53] (03CR) 10Daniel Kinzler: [C: 032] "While it's not necessary, it's often more readable, and more convenient for debugging, to put the result of a method call into a local var" [core] - 10https://gerrit.wikimedia.org/r/135025 (owner: 10Smuggli) [08:57:49] (03Merged) 10jenkins-bot: Return value directly when using getter [core] - 10https://gerrit.wikimedia.org/r/135025 (owner: 10Smuggli) [09:03:35] 3MediaWiki extensions / 3Math: math.sql does not exist - 10https://bugzilla.wikimedia.org/65761 (10Antoine "hashar" Musso) 3NEW p:3Unprio s:3normal a:3None When creating the fawiki on the beta cluster, the addWiki.php yield an error: hashar@deployment-bastion:~$ mwscript extensions/WikimediaMainten... [09:05:36] 3Wikimedia / 3Bugzilla: on bug submit: Incorrect key file for table './bugzilla/bugs_fulltext.MYI - 10https://bugzilla.wikimedia.org/65762 (10Antoine "hashar" Musso) 3NEW p:3Unprio s:3normal a:3None Software error: DBD::mysql::db do failed: Incorrect key file for table: './bugzilla/bugs_fulltext.M... [09:07:03] 3Wikimedia / 3Bugzilla: on bug submit: Incorrect key file for table './bugzilla/bugs_fulltext.MYI - 10https://bugzilla.wikimedia.org/65762#c1 (10Antoine "hashar" Musso) Happened on a few bugs this morning. The last one was adding a comment and resolving https://bugzilla.wikimedia.org/show_bug.cgi?id=65677 .... [09:18:33] 3Wikimedia / 3Bugzilla: on bug submit: Incorrect key file for table './bugzilla/bugs_fulltext.MYI - 10https://bugzilla.wikimedia.org/65762#c2 (10Antoine "hashar" Musso) 5NEW>3RES/FIX Giuseppe "_joe_" Lavagetto repaired table bugzilla.bugs_fulltext on db1001 as it was marked as crashed [09:24:35] 3MediaWiki extensions / 3WikidataRepo: UI freezes when saving too many snaks - 10https://bugzilla.wikimedia.org/64651#c1 (10tobias.gritschacher) *** Bug 65694 has been marked as a duplicate of this bug. *** [09:24:35] 3MediaWiki extensions / 3WikidataRepo: Uncaught TypeError: Cannot read property 'each' of null - 10https://bugzilla.wikimedia.org/65694#c3 (10tobias.gritschacher) 5NEW>3RES/DUP *** This bug has been marked as a duplicate of bug 64651 *** [09:25:48] 3MediaWiki extensions / 3WikidataRepo: cannot reorder snaks within a reference - 10https://bugzilla.wikimedia.org/65695 (10tobias.gritschacher) p:5Unprio>3High [09:26:33] 3MediaWiki extensions / 3WikidataRepo: item statement value vanishes when setting a rank - 10https://bugzilla.wikimedia.org/65398 (10tobias.gritschacher) [09:26:34] 3MediaWiki extensions / 3WikidataRepo: Snak value disappears when adding a qualifier - 10https://bugzilla.wikimedia.org/65693 (10tobias.gritschacher) [09:34:30] (03CR) 10Bartosz Dziewoński: Don't use autodiscovery for core skins (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135383 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [09:38:50] (03CR) 10Bartosz Dziewoński: "> skinname vs. SkinName doesn't appear to have been settled yet in the discussion so it would be inappropriate to merge something that cha" [core] - 10https://gerrit.wikimedia.org/r/135384 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [09:39:16] (03PS4) 10Bartosz Dziewoński: Move core skins to separate directories [core] - 10https://gerrit.wikimedia.org/r/135384 (https://bugzilla.wikimedia.org/65748) [09:39:18] (03PS2) 10Bartosz Dziewoński: Don't use autodiscovery for core skins [core] - 10https://gerrit.wikimedia.org/r/135383 (https://bugzilla.wikimedia.org/65748) [09:43:39] (03CR) 10jenkins-bot: [V: 04-1] Move core skins to separate directories [core] - 10https://gerrit.wikimedia.org/r/135384 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [09:47:28] (03PS2) 10Hashar: operations-puppet-tox-data_admin_lint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135111 [09:48:42] (03CR) 10Daniel Kinzler: "I agree that the top level factory should be passed to the factory method. I don't quite understand the concern about mixing backend imple" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [09:49:20] (03CR) 10Hashar: [C: 032] "Dependency merged. I have created the job in Jenkins." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135111 (owner: 10Hashar) [09:49:57] (03CR) 10Hashar: [C: 032] Trigger operations-puppet-tox-data_admin_lint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135113 (owner: 10Hashar) [09:50:08] (03Merged) 10jenkins-bot: operations-puppet-tox-data_admin_lint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135111 (owner: 10Hashar) [09:50:19] (03PS2) 10Hashar: Trigger operations-puppet-tox-data_admin_lint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135113 [09:50:40] (03CR) 10Hashar: [C: 032] Trigger operations-puppet-tox-data_admin_lint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135113 (owner: 10Hashar) [09:50:49] (03Merged) 10jenkins-bot: Trigger operations-puppet-tox-data_admin_lint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135113 (owner: 10Hashar) [09:54:05] (03PS1) 10Hashar: Make puppet data_admin_lint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135406 [09:54:23] (03CR) 10Hashar: [C: 032] Make puppet data_admin_lint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135406 (owner: 10Hashar) [09:54:31] (03Merged) 10jenkins-bot: Make puppet data_admin_lint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135406 (owner: 10Hashar) [09:55:46] (03PS5) 10Bartosz Dziewoński: Move core skins to separate directories [core] - 10https://gerrit.wikimedia.org/r/135384 (https://bugzilla.wikimedia.org/65748) [09:55:48] (03PS1) 10Bartosz Dziewoński: Copy various random files used by tests to tests/phpunit/data [core] - 10https://gerrit.wikimedia.org/r/135408 [09:56:06] why is hashar not here :( ^ [09:56:50] (03PS6) 10Bartosz Dziewoński: Move core skins to separate directories [core] - 10https://gerrit.wikimedia.org/r/135384 (https://bugzilla.wikimedia.org/65748) [09:56:52] (03PS3) 10Bartosz Dziewoński: Don't use autodiscovery for core skins [core] - 10https://gerrit.wikimedia.org/r/135383 (https://bugzilla.wikimedia.org/65748) [09:56:55] (03PS2) 10Bartosz Dziewoński: Copy various random files used by tests to tests/phpunit/data [core] - 10https://gerrit.wikimedia.org/r/135408 [09:58:54] MatmaRex: he's in -operations [09:59:07] well, i just need someone to merge some tests changes [09:59:14] you'd be fine too. :D [10:00:13] (03PS24) 10Legoktm: Make abstract Config class truly implementation-agnostic [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [10:00:36] (03CR) 10Legoktm: Make abstract Config class truly implementation-agnostic (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [10:00:50] * legoktm looks [10:00:52] (03PS2) 10Hashar: Flow front-end rewrite branch depends on Mantle [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135163 (owner: 10Spage) [10:01:56] I'll +2 after jenkins finishes [10:01:58] (03CR) 10Hashar: [C: 032] "Job mwext-Flow-testextensions-master updated :)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135163 (owner: 10Spage) [10:02:29] legoktm: i'm not sure these tests actually work [10:02:34] (03PS2) 10Hashar: Fix typos in comments [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135399 (owner: 10KartikMistry) [10:02:38] legoktm: because only one failed when i moved these files elsewhere [10:02:44] huh. [10:02:46] (03CR) 10Hashar: [C: 032] "Thank you Kartik." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135399 (owner: 10KartikMistry) [10:03:01] that...does not sound good. [10:03:11] (03Merged) 10jenkins-bot: Flow front-end rewrite branch depends on Mantle [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135163 (owner: 10Spage) [10:03:14] or i'm misinterpreting the logs [10:03:19] only 2 are tests [10:03:23] see failures on https://gerrit.wikimedia.org/r/#/c/135384/ [10:03:26] one is a "suite", but i don't know what that is [10:03:36] (03Merged) 10jenkins-bot: Fix typos in comments [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135399 (owner: 10KartikMistry) [10:03:36] i don't care what they are, but it's not failing and it looks like it should be [10:04:53] put a throw new Exception at the top of the test and see if it fails? :P [10:05:35] (03CR) 10Legoktm: [C: 031] Copy various random files used by tests to tests/phpunit/data [core] - 10https://gerrit.wikimedia.org/r/135408 (owner: 10Bartosz Dziewoński) [10:07:08] legoktm: i don't have phpunit set up locally [10:07:18] i tried once, but it didn't work and i didn't care [10:07:26] :/ [10:07:34] I'm about to sleep, I'll take a look when I get up [10:08:05] (03PS2) 10Hashar: (WIP) Two steps rsync to publish doc (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 [10:08:18] 3MediaWiki extensions / 3Math: math.sql does not exist - 10https://bugzilla.wikimedia.org/65761#c1 (10physikerwelt) I feel sorry. That's my fault. I was thinking that the database updates are using the MathHooks::onLoadExtensionSchemaUpdates hook. This commit I4f4d31c281257014734e9e3a8d7f1506855ea6d9 renames... [10:08:36] (03PS1) 10Bartosz Dziewoński: Move to 'Skins' section on Special:Version [extensions/Nostalgia] - 10https://gerrit.wikimedia.org/r/135411 [10:08:42] ^ trivial [10:08:58] (03CR) 10Legoktm: [C: 032] Move to 'Skins' section on Special:Version [extensions/Nostalgia] - 10https://gerrit.wikimedia.org/r/135411 (owner: 10Bartosz Dziewoński) [10:09:00] (03Merged) 10jenkins-bot: Move to 'Skins' section on Special:Version [extensions/Nostalgia] - 10https://gerrit.wikimedia.org/r/135411 (owner: 10Bartosz Dziewoński) [10:14:11] (03PS1) 10Santhosh: Qunit tests for dictionary [services/cxserver] - 10https://gerrit.wikimedia.org/r/135412 [10:14:31] (03CR) 10jenkins-bot: [V: 04-1] Qunit tests for dictionary [services/cxserver] - 10https://gerrit.wikimedia.org/r/135412 (owner: 10Santhosh) [10:18:26] (03PS2) 10Santhosh: Update the Dict client to match the updated API output format [services/cxserver] - 10https://gerrit.wikimedia.org/r/135022 [10:18:45] (03PS2) 10Santhosh: Qunit tests for dictionary [services/cxserver] - 10https://gerrit.wikimedia.org/r/135412 [10:19:18] 3MediaWiki / 3Search: Provide way to override the behavior of default search box - 10https://bugzilla.wikimedia.org/65753 (10Andre Klapper) p:5Unprio>3Normal s:5normal>3enhanc [10:19:18] 3MediaWiki / 3Database: Explicitly name check constraints for Microsoft SQL Server schema - 10https://bugzilla.wikimedia.org/65757 (10Andre Klapper) p:5Unprio>3Low [10:20:48] 3MediaWiki / 3Parser: Unbalanced tags in DISPLAYTITLE (e.g. two and only one ) affect MediaWiki's interface - 10https://bugzilla.wikimedia.org/65747 (10Andre Klapper) p:5Unprio>3Normal [10:21:07] (03PS1) 10Bartosz Dziewoński: [WIP, TMP, ETC] Separate Vector skin from core [core] - 10https://gerrit.wikimedia.org/r/135413 [10:21:18] 3MediaWiki extensions / 3WikidataRepo: caching / languages mixed up on Wikidata:List_of_properties/all - 10https://bugzilla.wikimedia.org/65743#c1 (10Lydia Pintscher) We can't really reproduce this here. Let's sit down together when you're back. [10:23:04] (03CR) 10Bartosz Dziewoński: "Daniel, https://gerrit.wikimedia.org/r/135413 is an example of what I was going to follow this up with. It's currently very incomplete bec" [core] - 10https://gerrit.wikimedia.org/r/135384 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [10:29:18] 3Wikimedia / 3Bugzilla: on bug submit: Incorrect key file for table './bugzilla/bugs_fulltext.MYI - 10https://bugzilla.wikimedia.org/65762#c3 (10Andre Klapper) Urgh. Thanks for quickly handling this. :-/ Gerrit Notification Bot changed status in bug 65677 without previously inserting the comment with the li... [10:31:33] 3Wikimedia / 3Wikidata: New statement not saving - 10https://bugzilla.wikimedia.org/65730#c1 (10Lydia Pintscher) We just tried to reproduce this on 3 different computers. All worked. Can you reproduce this on another item? Can you add and edit other statements? [10:34:11] (03PS1) 10Physikerwelt: Fix: rename math table [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/135414 (https://bugzilla.wikimedia.org/65761) [10:34:48] 3MediaWiki extensions / 3WikidataRepo: Call to undefined method Wikibase\EntityContentFactory::newContentFromEntity() in EditEntity.php on line 753 - 10https://bugzilla.wikimedia.org/65726 (10Lydia Pintscher) 5PAT>3RES/FIX [10:36:06] 3MediaWiki / 3Templates: Pages with large number of templates display not all templates - 10https://bugzilla.wikimedia.org/65763 (10sju-w) 3UNC p:3Unprio s:3major a:3None Since yesterday, some pages containing more templates display only part of the templates correctly, the rest templates are display... [10:36:49] 3MediaWiki extensions / 3WikidataClient: Move hook handlers into own classes (client) - 10https://bugzilla.wikimedia.org/65700 (10Lydia Pintscher) p:5Unprio>3Normal [10:37:33] 3Wikimedia / 3Media storage: Apply Content-encoding: gzip to Tiff files from upload.wikimedia.org - 10https://bugzilla.wikimedia.org/65725 (10Andre Klapper) p:5Unprio>3Normal [10:42:33] 3MediaWiki extensions / 3WikidataRepo: Wikidata parses dates incorrectly (in Portuguese) - 10https://bugzilla.wikimedia.org/65722#c2 (10Lydia Pintscher) p:5Unprio>3High When using slashes in a date it is currently considered US-format apparently. We need to support slashes for Portuguese as well and pars... [10:45:03] 3MediaWiki extensions / 3WikidataClient: Under HHVM: Call to a member function getGuid() on a non-object - 10https://bugzilla.wikimedia.org/65698 (10Lydia Pintscher) p:5Unprio>3Normal [10:45:48] 3MediaWiki extensions / 3WikidataRepo: usage tracking on repo for purging items - 10https://bugzilla.wikimedia.org/65718 (10Lydia Pintscher) p:5Unprio>3Low [10:48:03] 3MediaWiki extensions / 3WikidataRepo: Move hook handlers into own classes (repo) - 10https://bugzilla.wikimedia.org/65701 (10Lydia Pintscher) p:5Unprio>3Normal [10:48:50] 3MediaWiki extensions / 3Translate: Better icon images for Special:PageMigration - 10https://bugzilla.wikimedia.org/65764 (10Pratik Lahoti) 3NEW p:3Unprio s:3normal a:3None The icon images used currently at Special:PageMigration for various operations like edit, delete, swap, adding a new unit need t... [10:50:08] 3MediaWiki extensions / 3Translate: Special page for migration of legacy translation pages (tracking) - 10https://bugzilla.wikimedia.org/65740 (10Pratik Lahoti) [10:50:08] 3MediaWiki extensions / 3Translate: Better icon images for Special:PageMigration - 10https://bugzilla.wikimedia.org/65764 (10Pratik Lahoti) p:5Unprio>3Low s:5normal>3enhanc a:3Pratik Lahoti [10:51:34] 3MediaWiki extensions / 3Translate: Better icon images for Special:PageMigration - 10https://bugzilla.wikimedia.org/65764 (10Nemo) [10:52:33] 3MediaWiki extensions / 3WikidataClient: Under HHVM: Call to a member function getGuid() on a non-object - 10https://bugzilla.wikimedia.org/65698 (10Adrian Lang) [10:52:48] 3MediaWiki extensions / 3WikidataRepo: Make Wikibase compatible with HHVM - 10https://bugzilla.wikimedia.org/64415 (10Adrian Lang) [10:58:06] (03PS1) 10Santhosh: Add .jsbeautifyrc [services/cxserver] - 10https://gerrit.wikimedia.org/r/135417 [10:58:14] (03Abandoned) 10Santhosh: Experiment: Apertium Apy webservice based MT backend [services/cxserver] - 10https://gerrit.wikimedia.org/r/130050 (owner: 10Santhosh) [11:02:18] 3MediaWiki extensions / 3WikiEditor: Instrument all actions in wikitext editing toolbar for organization and frequency of use analysis and improvements - 10https://bugzilla.wikimedia.org/64711#c5 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc As long as no "how" is provided (talking to Analytics)... [11:03:06] 3MediaWiki / 3Maintenance scripts: update.php displays errors when updating ar_len field - 10https://bugzilla.wikimedia.org/65765 (10Joerg) 3NEW p:3Unprio s:3normal a:3None When I run update.php while updating from 1.22 to 1.23, amongst other things the script maintenance/populateArchiveLength.php is... [11:03:47] (03PS2) 10KartikMistry: Add .jsbeautifyrc [services/cxserver] - 10https://gerrit.wikimedia.org/r/135417 (owner: 10Santhosh) [11:09:18] 3MediaWiki / 3Maintenance scripts: update.php displays errors when updating ar_len field - 10https://bugzilla.wikimedia.org/65765 (10Joerg) [11:09:18] 3MediaWiki / 3Maintenance scripts: populateRevisionLength.php doesn't check archive table - 10https://bugzilla.wikimedia.org/24538 (10Joerg) [11:11:54] (03CR) 10KartikMistry: Update the Dict client to match the updated API output format (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/135022 (owner: 10Santhosh) [11:14:05] 3Wikimedia / 3Site requests: Please add: ftp://sitelftp.unine.ch/ to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/65766 (10Rromir) 3UNC p:3Unprio s:3normal a:3None please add the following domain(s) to the wgCopyUploadsDomains whitelist: ftp://sitelftp.unine.ch/ [11:20:19] 3MediaWiki / 3Maintenance scripts: update.php displays errors when updating ar_len field - 10https://bugzilla.wikimedia.org/65765#c1 (10Joerg) Ah, the script in fact is called populateRevisionLength.php, but the code does exactly what I posted above. [11:22:48] 3Wikimedia / 3Site requests: Please add: ftp://sitelftp.unine.ch/ to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/65766#c1 (10Sam Reed (reedy)) That "domain" includes a protocol. FTP isn't supported. http://sitelftp.unine.ch/ gives a 403 [11:23:34] 3MediaWiki / 3Database: Explicitly name check constraints for Microsoft SQL Server schema - 10https://bugzilla.wikimedia.org/65757 (10Rainer Rillke @commons.wikimedia) 5NEW>3ASS a:3Rainer Rillke  [11:23:47] (03CR) 10Daniel Kinzler: [C: 031] "Seems fine, would like Parent to agree though." [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [11:44:03] 3MediaWiki / 3Maintenance scripts: update.php / populateRevisionLength.php displays "Content of archive unavailable" error when updating ar_len field - 10https://bugzilla.wikimedia.org/65765 (10Andre Klapper) p:5Unprio>3High [11:48:18] 3MediaWiki extensions / 3WikidataRepo: Wikidata parses dates incorrectly (in Portuguese) - 10https://bugzilla.wikimedia.org/65722#c3 (10Helder) I was able to use spaces as a workaround on https://www.wikidata.org/wiki/Q10311783?diff=133797307 [11:57:18] 3MediaWiki / 3Templates: Pages with large number of templates display not all templates - 10https://bugzilla.wikimedia.org/65763#c1 (10Andre Klapper) "Warning: Template include size is too large. Some templates will not be included." feels pretty clear... You hit a timeout for page rendering because the page... [12:03:03] 3Wikimedia / 3Site requests: Please add: ftp://sitelftp.unine.ch/ to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/65766#c2 (10Rromir) (In reply to Sam Reed (reedy) from comment #1) > That "domain" includes a protocol. FTP isn't supported. > http://sitelftp.unine.ch/ gives a 403 Tha... [12:05:48] 3MediaWiki / 3Templates: Pages with large number of templates display not all templates - 10https://bugzilla.wikimedia.org/65763#c2 (10Mormegil) Exactly. The problem did not appear yesterday, it was caused by recent edits to [[cs:Template:Památky v Česku]], which increased the post-expand include size from 1... [12:12:05] (03PS3) 10Santhosh: Update the Dict client to match the updated API output format [services/cxserver] - 10https://gerrit.wikimedia.org/r/135022 [12:15:59] (03PS4) 10Santhosh: Update the Dict client to match the updated API output format [services/cxserver] - 10https://gerrit.wikimedia.org/r/135022 [12:23:35] 3MediaWiki extensions / 3WikidataRepo: Improve display of lists in diffs (e.g. aliases) - 10https://bugzilla.wikimedia.org/65768 (10Daniel Kinzler) 3NEW p:3Unprio s:3normal a:3Wikidata bugs In a diff view, insertions/deletions in a list should not have a new header for each index, but should be lumpe... [12:24:03] 3MediaWiki extensions / 3WikidataRepo: Improve display of lists in diffs (e.g. aliases) - 10https://bugzilla.wikimedia.org/65768 (10Daniel Kinzler) p:5Unprio>3Low s:5normal>3enhanc [12:24:48] 3MediaWiki / 3Templates: Pages with large number of templates display not all templates - 10https://bugzilla.wikimedia.org/65763 (10Andre Klapper) 5UNC>3RES/INV [12:27:03] 3Wikimedia / 3Site requests: Please add: ftp://sitelftp.unine.ch/ to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/65766#c3 (10Sam Reed (reedy)) (In reply to Rromir from comment #2) > (In reply to Sam Reed (reedy) from comment #1) > > That "domain" includes a protocol. FTP isn't supp... [12:38:36] ori: seen http://ponyorm.com/ [12:38:49] 3MediaWiki extensions / 3WikidataRepo: Removing a label through wbeditentity with "remove":true does not work - 10https://bugzilla.wikimedia.org/65744#c2 (10tobias.gritschacher) 5PAT>3RES/FIX https://gerrit.wikimedia.org/r/135327 has been merged. [12:38:55] ori: linqish stuff for python. looks interesting. [12:39:38] (03PS1) 10Deepali: Set default value of $wgBookManagerv2ChapterList to false. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/135422 [12:40:09] ori: hmm, http://ponyorm.com/license-and-pricing.html is interesting. I wonder if you can use AGPL software in GPL code. [12:40:11] probably not? [12:43:45] (03CR) 10Tobias Gritschacher: "@aude: what's the deal with this change? it needs a rebase and addressing of daniel's comment.. looks fine otherwise" [core] - 10https://gerrit.wikimedia.org/r/129116 (https://bugzilla.wikimedia.org/53851) (owner: 10Aude) [12:46:23] (03PS7) 10Matthias Mullie: [WIP] search [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126996 [12:58:19] 3Wikimedia / 3Bugzilla: Reorganize "Wikipedia Apps" product - 10https://bugzilla.wikimedia.org/64621#c14 (10Andre Klapper) (In reply to Yuvi Panda from comment #3) > Components: > 1. Android App > 2. iOS App > 3. Extension:MobileApp > 4. General / Unknown I have created the components listed above. I have... [13:01:03] 3Wikimedia / 3Bugzilla: Reorganize "Wikipedia Apps" product - 10https://bugzilla.wikimedia.org/64621#c15 (10Andre Klapper) > Versions: > 1. Alpha > 2. Beta > 3. Stable I've disabled the existing versions for bug entry or changing existing tickets to those versions. I've created above three versions. I won... [13:03:35] 3MediaWiki extensions / 3BookManagerv2: Slow loading of Json Editor in mobile frontend - 10https://bugzilla.wikimedia.org/65769 (10Deepali Jain) 3UNC p:3Unprio s:3normal a:3None While it is working fine in normal web view, the json editor is taking too much time to load in mobile frontend. [13:10:48] 3MediaWiki / 3Parser: Unbalanced tags in DISPLAYTITLE (e.g. two and only one ) affect MediaWiki's interface - 10https://bugzilla.wikimedia.org/65747#c2 (10Florian) Maybe an extension problem on wikipedia? I have tested on a clean 1.24wmf5 version without anything and AllowDisplayTitle=true and Restri... [13:15:30] (03CR) 10Krinkle: "Using lastTabIndex in this fashion seems asking for trouble. It is subject to race conditions this way and has no written intent, it just " [core] - 10https://gerrit.wikimedia.org/r/135269 (https://bugzilla.wikimedia.org/29199) (owner: 10Alex Monk) [13:15:43] (03CR) 10Krinkle: [C: 04-1] Fix search box tabindex again [core] - 10https://gerrit.wikimedia.org/r/135269 (https://bugzilla.wikimedia.org/29199) (owner: 10Alex Monk) [13:17:19] 3MediaWiki extensions / 3WikidataRepo: UI for monolingual text datatype - 10https://bugzilla.wikimedia.org/64290 (10Adrian Lang) [13:17:48] 3MediaWiki extensions / 3WikidataRepo: Factor out inputextender usage and inputextender's widgets of experts - 10https://bugzilla.wikimedia.org/65770#c1 (10Adrian Lang) 5NEW>3PAT https://github.com/wmde/ValueView/pull/51 [13:19:18] 3MediaWiki extensions / 3WikidataRepo: Factor out inputextender usage and inputextender's widgets of experts - 10https://bugzilla.wikimedia.org/65770 (10Lydia Pintscher) p:5Unprio>3High [13:21:03] 3Wikimedia / 3Site requests: Please add: ftp://sitelftp.unine.ch/ to the wgCopyUploadsDomains whitelist - 10https://bugzilla.wikimedia.org/65766#c4 (10Rromir) (In reply to Sam Reed (reedy) from comment #3) > (In reply to Rromir from comment #2) > > (In reply to Sam Reed (reedy) from comment #1) > > > That "... [13:29:40] (03CR) 10Hashar: [C: 032] "Great. Thank you :)" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/135414 (https://bugzilla.wikimedia.org/65761) (owner: 10Physikerwelt) [13:29:42] (03Merged) 10jenkins-bot: Fix: rename math table [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/135414 (https://bugzilla.wikimedia.org/65761) (owner: 10Physikerwelt) [13:30:35] 3MediaWiki extensions / 3Math: math.sql does not exist - 10https://bugzilla.wikimedia.org/65761#c4 (10Antoine "hashar" Musso) 5PAT>3RES/FIX a:3physikerwelt No need to feel sorry :-) Specially when you fix the glitch on spot! Thank you! [13:36:34] (03CR) 10Alex Monk: "It doesn't matter whether it was right, this code was not intended to be removed, it just happened to be in a module that got removed." [core] - 10https://gerrit.wikimedia.org/r/135269 (https://bugzilla.wikimedia.org/29199) (owner: 10Alex Monk) [13:38:03] (03CR) 10Gilles: [C: 04-1] "This looks easily unit-testable, thus it should be. I.e. checking that the command expected to run is the right one when multipage documen" [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/86416 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [13:41:43] (03CR) 10Gilles: [C: 04-1] Make PagedTiffHandler work with VipsScaler. (032 comments) [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/86413 (https://bugzilla.wikimedia.org/52045) (owner: 10Brian Wolff) [13:44:15] (03CR) 10Gilles: [C: 032] jQuery 1.9 fixes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/134960 (owner: 10MarkTraceur) [13:44:24] (03Merged) 10jenkins-bot: jQuery 1.9 fixes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/134960 (owner: 10MarkTraceur) [13:47:48] 3MediaWiki extensions / 3WikidataRepo: formula datatype - 10https://bugzilla.wikimedia.org/65397#c2 (10Lydia Pintscher) I thought that extension uses mathml? Either way we should store it in a way that can easily be re-used on the client. Daniel: What's your take on this? [13:52:50] (03CR) 10Gilles: [C: 04-1] Check $wgMaxImageArea before downloading file asset from swift (031 comment) [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135101 (https://bugzilla.wikimedia.org/62306) (owner: 10Brian Wolff) [13:55:51] 3MediaWiki extensions / 3BookManagerv2: Json book data on book page ( in namespace Book ) is not recognised as JsonContent - 10https://bugzilla.wikimedia.org/65771 (10Deepali Jain) 3UNC p:3Unprio s:3normal a:3None Functions of class JsonContent ( content model for json data ) do not work on the conte... [14:00:49] (03CR) 10Krinkle: "FIXME: You're missing one or two dependency declarations on jquery.client. In one case it is missing entirely (EmbedPlayer.loader.js), and" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/134960 (owner: 10MarkTraceur) [14:01:03] marktraceur: gi11es: ^ [14:01:48] 3MediaWiki extensions / 3WikidataRepo: formula datatype - 10https://bugzilla.wikimedia.org/65397#c3 (10Daniel Kinzler) This is tricky... MathML is by far easier to re-use by third parties, and in general a saner format for storing formula. But we don't have any facilities for rendering it server side for cli... [14:02:06] (03PS1) 10Bartosz Dziewoński: Officially deprecate skin autodiscovery [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/135427 [14:02:34] (03CR) 10Krinkle: "So add it to vector.js?" [core] - 10https://gerrit.wikimedia.org/r/135269 (https://bugzilla.wikimedia.org/29199) (owner: 10Alex Monk) [14:02:59] (03PS1) 10Bartosz Dziewoński: Skin: Remove dried up remains of Standard/Classic skin [core] - 10https://gerrit.wikimedia.org/r/135428 [14:03:01] (03PS1) 10Bartosz Dziewoński: Officially deprecate skin autodiscovery [core] - 10https://gerrit.wikimedia.org/r/135429 [14:03:08] (03CR) 10Krinkle: Officially deprecate skin autodiscovery (031 comment) [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/135427 (owner: 10Bartosz Dziewoński) [14:03:33] 3MediaWiki / 3Maintenance scripts: populateRevisionLength.php displays "Content of archive unavailable" error when updating ar_len field with text stored in archive table - 10https://bugzilla.wikimedia.org/65765 (10Sam Reed (reedy)) [14:03:37] (03CR) 10Krinkle: Officially deprecate skin autodiscovery (031 comment) [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/135427 (owner: 10Bartosz Dziewoński) [14:06:31] Krinkle: :) [14:06:32] (03CR) 10Krinkle: "Why add multiple copies in tests data though? One in skins and one in test data seems enough." [core] - 10https://gerrit.wikimedia.org/r/135408 (owner: 10Bartosz Dziewoński) [14:07:16] (03CR) 10Krinkle: "Does the stack atop this depend on the test directory change? (even if just to avoid merge conflicts). If not, may want to cherry-pick thi" [core] - 10https://gerrit.wikimedia.org/r/135383 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [14:07:30] hmmm, all of the links to Help:Whatever should probably be Manual:Whatever instead. [14:07:31] (03PS1) 10Alexander.lehmann: Inserted new Hook, new Jobs and user permissions. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/135430 [14:08:57] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/135430 (owner: 10Alexander.lehmann) [14:10:09] (03PS2) 10Alexander.lehmann: Inserted new Hook, new Jobs and user permissions. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/135430 [14:10:40] (03CR) 10Bartosz Dziewoński: "I don't know, I didn't come up with the directory structure in tests/phpunit/data/, but I see it mimics the structure of tests/phpunit/inc" [core] - 10https://gerrit.wikimedia.org/r/135408 (owner: 10Bartosz Dziewoński) [14:11:22] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/135430 (owner: 10Alexander.lehmann) [14:15:23] (03CR) 10Krinkle: Well-defined behavior for array values in all Html attributes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/132617 (owner: 10Thiemo Mättig (WMDE)) [14:15:33] 3Analytics / 3Kraken: Hive queries inconsistently failing - 10https://bugzilla.wikimedia.org/65420#c25 (10Andrew Otto) Oliver, did you job finish? What's the application ID? [14:16:52] (03CR) 10Krinkle: Well-defined behavior for array values in all Html attributes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/132617 (owner: 10Thiemo Mättig (WMDE)) [14:20:19] 3MediaWiki extensions / 3Translate: Id and class names for Special:PageMigration need to be fixed as per the standards followed - 10https://bugzilla.wikimedia.org/65736#c3 (10Nemo) Created attachment 15475 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15475&action=edit "html template" which shows th... [14:21:14] (03CR) 10Parent5446: [C: 031] Don't use autodiscovery for core skins [core] - 10https://gerrit.wikimedia.org/r/135383 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [14:22:12] (03CR) 10Bartosz Dziewoński: "https://gerrit.wikimedia.org/r/#/c/135384/6 does. The tests fail otherwise. :)" [core] - 10https://gerrit.wikimedia.org/r/135383 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [14:22:48] (03CR) 10Krinkle: Add dynamic maxlength to Special:RevisionDelete (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135197 (https://bugzilla.wikimedia.org/34467) (owner: 10Umherirrender) [14:23:18] 3MediaWiki extensions / 3Translate: Id and class names for Special:PageMigration need to be fixed as per the standards followed - 10https://bugzilla.wikimedia.org/65736 (10Nemo) [14:23:33] 3MediaWiki extensions / 3WikidataRepo: It should be possible to get entity id from page title - 10https://bugzilla.wikimedia.org/65507 (10Michał Łazowik) 5PAT>3ASS [14:23:51] (03CR) 10Parent5446: "In this patch, a bunch of Modern resources are renamed into the Monobook skin, and then the Monobook files are deleted. Is this intentiona" [core] - 10https://gerrit.wikimedia.org/r/135384 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [14:24:18] 3MediaWiki extensions / 3Translate: Id and class names for Special:PageMigration need to be fixed as per the standards followed - 10https://bugzilla.wikimedia.org/65736 (10Nemo) [14:24:26] (03CR) 10Krinkle: [C: 04-1] "tests/parser/parserTest.inc" [core] - 10https://gerrit.wikimedia.org/r/135408 (owner: 10Bartosz Dziewoński) [14:24:58] (03PS3) 10Hashar: Refactor doc publishing from labs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 [14:25:10] (03PS2) 10Bartosz Dziewoński: Officially deprecate skin autodiscovery [core] - 10https://gerrit.wikimedia.org/r/135429 (https://bugzilla.wikimedia.org/65748) [14:25:48] 3MediaWiki extensions / 3Translate: Fix code styling issues for Special:PageMigration - 10https://bugzilla.wikimedia.org/65738 (10Nemo) [14:25:51] (03PS2) 10Bartosz Dziewoński: Officially deprecate skin autodiscovery [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/135427 (https://bugzilla.wikimedia.org/65748) [14:26:29] (03PS4) 10Hashar: Refactor doc publishing from labs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 [14:27:14] (03CR) 10Parent5446: Skin: Remove dried up remains of Standard/Classic skin (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135428 (owner: 10Bartosz Dziewoński) [14:27:19] 3MediaWiki extensions / 3Translate: Id and class names for Special:PageMigration need to be fixed as per the standards followed - 10https://bugzilla.wikimedia.org/65736#c4 (10Krinkle) p:5Unprio>3Low Yeah, these IDs are quite generic. Can easily clash with things and seem out of place in a MediaWiki conte... [14:30:38] (03CR) 10Parent5446: Allow filtering log entries by namespace (API) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135283 (owner: 10Jackmcbarn) [14:31:07] (03CR) 10Bartosz Dziewoński: "It's not only not intentional, it's also not true :) It's just git and Gerrit being silly. `git status` displays this information in a san" [core] - 10https://gerrit.wikimedia.org/r/135384 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [14:31:57] (03CR) 10Bartosz Dziewoński: "> `git status` displays this information in a saner way" [core] - 10https://gerrit.wikimedia.org/r/135384 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [14:32:02] (03PS3) 10Alexander.lehmann: Inserted new Hook, new Jobs and user permissions. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/135430 [14:32:53] (03CR) 10Bartosz Dziewoński: Skin: Remove dried up remains of Standard/Classic skin (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135428 (owner: 10Bartosz Dziewoński) [14:33:03] (03CR) 10Krinkle: [C: 031] Revert "Restore search box tabindex" [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135208 (https://bugzilla.wikimedia.org/29199) (owner: 10Mattflaschen) [14:33:16] (03PS2) 10Bartosz Dziewoński: Skin: Remove dried up remains of Standard/Classic skin [core] - 10https://gerrit.wikimedia.org/r/135428 [14:33:20] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/135430 (owner: 10Alexander.lehmann) [14:34:21] (03PS3) 10Krinkle: Enable WikiEditor toolbar on iOS [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/132603 (https://bugzilla.wikimedia.org/63277) (owner: 10TheDJ) [14:34:47] (03CR) 10Krinkle: Enable WikiEditor toolbar on iOS (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/132603 (https://bugzilla.wikimedia.org/63277) (owner: 10TheDJ) [14:34:53] (03CR) 10Parent5446: [C: 031] "Lol" [core] - 10https://gerrit.wikimedia.org/r/135384 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [14:35:08] (03PS1) 10Hashar: Update doc links to scap and releng [integration/docroot] - 10https://gerrit.wikimedia.org/r/135431 [14:35:11] (03CR) 10Parent5446: Allow filtering log entries by namespace (API) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135283 (owner: 10Jackmcbarn) [14:36:24] (03PS3) 10Bartosz Dziewoński: Skin: Remove dried up remains of Standard/Classic skin [core] - 10https://gerrit.wikimedia.org/r/135428 [14:37:48] 3MediaWiki / 3Skin and page rendering: Fix up Vector sidebar links indentation - 10https://bugzilla.wikimedia.org/65444#c10 (10Krinkle) (In reply to Helder from comment #2) > (In reply to Helder from comment #1) > > The current formatting also makes many items to wrap to a new line. > Ignore this comment, I... [14:38:34] (03CR) 10Hashar: [C: 031] "Timo, Bryan, Greg," [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 (owner: 10Hashar) [14:41:33] 3MediaWiki / 3Skin and page rendering: Fix up Vector sidebar links indentation - 10https://bugzilla.wikimedia.org/65444#c11 (10Krinkle) (In reply to Helder from comment #4) > Compare the bugzilla sidebar to the sidebar on the wikis. On bugzilla, there > is no indentation for the uncollapsed sections. This is... [14:43:28] (03PS4) 10Alexander.lehmann: Inserted new Hook, new Jobs and user permissions. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/135430 [14:44:50] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/135430 (owner: 10Alexander.lehmann) [14:45:58] (03CR) 10Krinkle: [C: 04-1] Refactor doc publishing from labs (032 comments) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 (owner: 10Hashar) [14:48:19] 3MediaWiki extensions / 3WikidataRepo: Clean up and expand Wikibase page on mediawiki.org - 10https://bugzilla.wikimedia.org/63226 (10tobias.gritschacher) 5PAT>3RES/FIX [14:50:53] (03CR) 10Hashar: "Yeah thanks Timo. Gotta garbage collect properly, I have added some suggestions inline." (033 comments) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 (owner: 10Hashar) [14:58:37] 3MediaWiki / 3Installer: update.php: Time taken is incorrect when the upgrade takes 1 hour or more - 10https://bugzilla.wikimedia.org/65772 (10Kevin Israel (PleaseStand)) 3ASS p:3Unprio s:3trivia a:3Kevin Israel (PleaseStand) I was looking back at a change I reviewed and realized that a subsequent pa... [14:59:47] (03CR) 10Krinkle: "That's good too, but you missed my point. I'm referring to deleting old files in the destination directory (e.g. in srv/org/wikimedia/doc/" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 (owner: 10Hashar) [15:03:12] (03PS1) 10PleaseStand: update.php: Correctly report durations >= 1 hour [core] - 10https://gerrit.wikimedia.org/r/135433 (https://bugzilla.wikimedia.org/65772) [15:03:35] 3MediaWiki / 3User login and signup: "Reset your password" link should come after the password box - 10https://bugzilla.wikimedia.org/53929#c5 (10Andre Klapper) 16 lines patch by Roopak still awaiting more reviews in Gerrit... Anyone? [15:04:03] 3MediaWiki / 3User login and signup: AJAX validation of username for password reset - 10https://bugzilla.wikimedia.org/56025#c7 (10Andre Klapper) ganeshaditya1: Do you plan to extend your patch, based on comment 5 and comment 6? [15:04:33] 3MediaWiki / 3User login and signup: Password reset doesn't work - 10https://bugzilla.wikimedia.org/52126#c5 (10Andre Klapper) Juliusz: Can you answer comment 4, please? [15:07:23] (03CR) 10Krinkle: "I was concerned about the accessibility. Interesting read over at http://css-tricks.com/functional-css-tabs-revisited/. While that is for " [core] - 10https://gerrit.wikimedia.org/r/84290 (owner: 10Ori.livneh) [15:08:19] (03CR) 10Parent5446: [C: 04-1] update.php: Correctly report durations >= 1 hour (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135433 (https://bugzilla.wikimedia.org/65772) (owner: 10PleaseStand) [15:08:39] (03CR) 10Krinkle: "I assumed the using of mw.Map is just to mess with me." [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/120592 (owner: 10Ori.livneh) [15:10:03] 3MediaWiki / 3Skin and page rendering: Fix up Vector sidebar links indentation - 10https://bugzilla.wikimedia.org/65444#c12 (10Helder) (In reply to Krinkle from comment #11) To be more explicit: MediaWiki Vector (now) Item Item -------- Header Item Item -------- Header Item Item [15:16:04] 3Wikimedia / 3Media storage: Thumbnail/imagescaler (tracking) - 10https://bugzilla.wikimedia.org/41371 (10Andre Klapper) [15:16:04] 3Wikimedia / 3Media storage: Resized raster image does not succeed metadata of the original file - 10https://bugzilla.wikimedia.org/65475 (10Andre Klapper) p:5Unprio>3Low [15:16:23] (03PS1) 10Matěj Grabovský: Support GENDER in MediaWiki:Blockip and Special:Block [core] - 10https://gerrit.wikimedia.org/r/135436 (https://bugzilla.wikimedia.org/50572) [15:16:33] 3MediaWiki / 3Skin and page rendering: Fix up Vector sidebar links indentation - 10https://bugzilla.wikimedia.org/65444#c13 (10Krinkle) (In reply to Helder from comment #12) > (In reply to Krinkle from comment #11) > > To be more explicit Indeed, the first section has no heading and is not indented. Howeve... [15:16:59] (03CR) 10Bartosz Dziewoński: [C: 031] Revert "Restore search box tabindex" [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135208 (https://bugzilla.wikimedia.org/29199) (owner: 10Mattflaschen) [15:18:24] HI guys, Quick question about composer and the way it works on a MW project extension. According to http://www.mediawiki.org/wiki/Composer we can now, from the root of MW, tell which extensions we want which is VERY NICE! If my extension has its own composer.json, will the management w/ composer on the root handle it too? [15:18:37] oh, righ, that's composer’s job to do that I guess [15:18:38] (03CR) 10Krinkle: "See bug 65444." [core] - 10https://gerrit.wikimedia.org/r/134311 (https://bugzilla.wikimedia.org/65444) (owner: 10Odder) [15:18:48] 3Wikimedia / 3Media storage: increase of internal_api_error_DBQueryError, internal_api_error_FileBackendError at Wikimedia Commons - 10https://bugzilla.wikimedia.org/53768#c9 (10Andre Klapper) (In reply to Rainer Rillke @commons.wikimedia from comment #8) > internal_api_error_DBQueryError still happens while... [15:22:46] (03CR) 10Bartosz Dziewoński: "Ugh, I've only grepped *.php. Why do we even have files with such silly extensions? Also, why doesn't this cause tests to fail?" [core] - 10https://gerrit.wikimedia.org/r/135408 (owner: 10Bartosz Dziewoński) [15:23:42] (03PS3) 10Bartosz Dziewoński: Officially deprecate skin autodiscovery [core] - 10https://gerrit.wikimedia.org/r/135429 [15:23:44] (03PS7) 10Bartosz Dziewoński: Move core skins to separate directories [core] - 10https://gerrit.wikimedia.org/r/135384 (https://bugzilla.wikimedia.org/65748) [15:23:46] (03PS4) 10Bartosz Dziewoński: Don't use autodiscovery for core skins [core] - 10https://gerrit.wikimedia.org/r/135383 (https://bugzilla.wikimedia.org/65748) [15:23:48] (03PS3) 10Bartosz Dziewoński: Copy various random files used by tests to tests/phpunit/data [core] - 10https://gerrit.wikimedia.org/r/135408 [15:24:29] (03CR) 10Hashar: Refactor doc publishing from labs (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 (owner: 10Hashar) [15:26:00] (03CR) 10PleaseStand: update.php: Correctly report durations >= 1 hour (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135433 (https://bugzilla.wikimedia.org/65772) (owner: 10PleaseStand) [15:27:01] (03PS5) 10Hashar: Refactor doc publishing from labs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 [15:31:18] 3MediaWiki / 3Skin and page rendering: Fix up Vector sidebar links indentation - 10https://bugzilla.wikimedia.org/65444#c14 (10Nemo) (In reply to Krinkle from comment #13) > * Aligning header and items is fine (e.g. no extra indentation), but in that > case we should move the separator line back to between t... [15:31:33] 3MediaWiki / 3Skin and page rendering: Fix up Vector sidebar links indentation - 10https://bugzilla.wikimedia.org/65444#c15 (10Derk-Jan Hartman) Created attachment 15476 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15476&action=edit What it used to be Since I have access to an instance with a some... [15:32:07] 3MediaWiki / 3General/Unknown: Import Module error created Revision 0, now page cannot be edited - 10https://bugzilla.wikimedia.org/65775 (10bennylin) 3NEW p:3Unprio s:3normal a:3None Created attachment 15477 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15477&action=edit The revision #0 of... [15:33:32] (03CR) 10Hashar: "* removes the --verbose" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 (owner: 10Hashar) [15:34:18] 3MediaWiki / 3Skin and page rendering: Fix up Vector sidebar links indentation - 10https://bugzilla.wikimedia.org/65444#c16 (10Krinkle) That can be achieved by undoing parts of https://gerrit.wikimedia.org/r/#/c/131402/. There will likely still be parts of that change that should remain, and some parts that... [15:35:50] (03CR) 10Hashar: "That needs an empty directory to be created. We can also use --remove-source-files during the copy and delete the remaining tree of empty " [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 (owner: 10Hashar) [15:36:19] 3MediaWiki / 3General/Unknown: Import Module error created Revision 0, now page cannot be edited - 10https://bugzilla.wikimedia.org/65775#c1 (10bennylin) Edit: links should be *[[wikt:en:Category:Data modules]] *https://translatewiki.net/wiki/Support#About_[[MediaWiki:Missing-revision]]_42353 *https://id.wik... [15:38:55] (03CR) 10Krinkle: "I'd recommend against --remove-source-files (aka --delete-during), in favour of --delete-after. I've been down this road before with jsduc" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 (owner: 10Hashar) [15:42:41] (03PS1) 10Matěj Grabovský: Use custom message for block link in ConfirmAccounts [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/135438 [15:44:01] (03PS4) 10Bartosz Dziewoński: Officially deprecate skin autodiscovery [core] - 10https://gerrit.wikimedia.org/r/135429 (https://bugzilla.wikimedia.org/65748) [15:44:07] (03PS1) 10Bartosz Dziewoński: [DO NOT MERGE] Completely remove skin autodiscovery [core] - 10https://gerrit.wikimedia.org/r/135439 (https://bugzilla.wikimedia.org/65748) [16:04:36] (03PS2) 10Gilles: [WIP] Generate thumbnails based on buckets [core] - 10https://gerrit.wikimedia.org/r/135008 [16:09:46] (03CR) 10Umherirrender: Add dynamic maxlength to Special:RevisionDelete (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135197 (https://bugzilla.wikimedia.org/34467) (owner: 10Umherirrender) [16:13:21] (03PS3) 10Gilles: [WIP] Generate thumbnails based on buckets [core] - 10https://gerrit.wikimedia.org/r/135008 [16:16:43] (03CR) 10Daniel Friesen: [C: 04-1] [DO NOT MERGE] Completely remove skin autodiscovery (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135439 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [16:19:05] (03CR) 10Thiemo Mättig (WMDE): Well-defined behavior for array values in all Html attributes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/132617 (owner: 10Thiemo Mättig (WMDE)) [16:19:11] (03PS4) 10Thiemo Mättig (WMDE): Well-defined behavior for array values in all Html attributes [core] - 10https://gerrit.wikimedia.org/r/132617 [16:30:06] (03CR) 10Daniel Friesen: [C: 04-1] "> "It seemed to be that we agreed on SkinName for directory/file names and skinname for internal skin names?"" [core] - 10https://gerrit.wikimedia.org/r/135384 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [16:47:01] (03PS4) 10Gilles: [WIP] Generate thumbnails based on buckets [core] - 10https://gerrit.wikimedia.org/r/135008 [16:48:16] (03CR) 10Daniel Friesen: "Also while I've given plenty of reasons why 'SkinName' is a bad idea. I haven't seen anyone actually list a reason why it's a good idea mu" [core] - 10https://gerrit.wikimedia.org/r/135384 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [16:51:18] 3MediaWiki extensions / 3WikidataRepo: formula datatype - 10https://bugzilla.wikimedia.org/65397#c4 (10Bene*) Ok, I think a conversion between MathML and TeX would be great but not high priority at the moment. However there might be existing TeX to MathML converters. Now you must decide which format to use. [17:05:33] 3Wikimedia / 3Media storage: increase of internal_api_error_DBQueryError, internal_api_error_FileBackendError at Wikimedia Commons - 10https://bugzilla.wikimedia.org/53768#c10 (10Bawolff (Brian Wolff)) 5NEW>3RES/DUP > Rainer: https://bugzilla.wikimedia.org/show_bug.cgi?id=37519 ? Definitely a dupe. Mar... [17:06:03] 3MediaWiki / 3Parser: Sanitizer::removeHTMLtags doesn't close tags correctly when $wgUseTidy is enabled - 10https://bugzilla.wikimedia.org/65747#c3 (10Jackmcbarn) I've tracked this problem down to Sanitizer::removeHTMLtags and $wgUseTidy. When $wgUseTidy is disabled (as it is on default MediaWiki installatio... [17:10:35] (03PS5) 10Gilles: [WIP] Generate thumbnails based on buckets [core] - 10https://gerrit.wikimedia.org/r/135008 [17:17:55] (03Abandoned) 10Odder: Fix indentation in Vector sidebar links [core] - 10https://gerrit.wikimedia.org/r/134311 (https://bugzilla.wikimedia.org/65444) (owner: 10Odder) [17:18:50] 3MediaWiki / 3Skin and page rendering: Fix up Vector sidebar links indentation - 10https://bugzilla.wikimedia.org/65444 (10Tomasz W. Kozlowski) 5PAT>3NEW a:5Tomasz W. Kozlowski>3None [17:19:04] (03PS6) 10Gilles: [WIP] Generate thumbnails based on buckets [core] - 10https://gerrit.wikimedia.org/r/135008 [17:20:03] 3MediaWiki extensions / 3WikidataRepo: formula datatype - 10https://bugzilla.wikimedia.org/65397#c5 (10Tobias) I was wondering too, if either MathML or TEX could store the item information instead of just the symbols. The symbols could be stored in another property and used just for display: If we take the... [17:25:39] Hi, can someone help with MediaWiki-Vagrant? [17:27:35] Nemo_bis: https://pagemigration.wmflabs.org/wiki/Main_Page has been setup [17:27:45] huh: I can try [17:28:13] I was trying to enable the centralauth role, but I got an error with "git provision" [17:28:23] well, lots of errors [17:28:53] can you pastebin them? [17:29:01] https://tools.wmflabs.org/paste/view/0bdb9795 [17:29:54] huh: interesting. what is your host operating system? [17:30:09] Mac OS X (but old version) [17:30:18] hmm, that should be fine [17:30:26] and I assume you are on the latest version of vagrant [17:30:27] err [17:30:31] I mean, mediawiki-vagrant [17:30:36] with a compatible version of vagrant [17:30:42] I downloaded it from git yesterday [17:30:45] right [17:30:52] huh: try vagrant provision again? [17:32:38] more erros [17:32:41] *errors [17:33:05] 3MediaWiki extensions / 3Translate: Deprecated: Use of SpecialRecentChangesQuery hook (used in TranslateRcFilter::translationFilter) - 10https://bugzilla.wikimedia.org/65776 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Deprecated: Use of SpecialRecentChangesQuery hook (used in TranslateRcFilter::transla... [17:33:07] in fact, the output looks very similar [17:33:37] huh: does vagrant ssh work? [17:33:40] yes [17:33:54] huh: can you ssh in and check permissions of /vagrant/settings.d? [17:33:57] huh: or /vagrant in general? [17:34:24] okay [17:35:21] /vagrant is drwxr-xr-x [17:35:35] settings.d is drwxr-xr-x [17:37:04] huh: hmm, that should work [17:37:08] huh: who owns these things? [17:37:10] huh: user vagrant? [17:37:20] drwxr-xr-x 22 501 dialout 748 May 26 03:34 . [17:37:25] drwxr-xr-x 6 501 dialout 204 May 26 04:17 settings.d [17:37:31] whoever "dialout" is? [17:38:20] or is that the group, sorry [17:38:23] huh: hmm, weird. can you chown them to user vagrant? [17:39:37] (03CR) 10tosfos: [C: 032 V: 032] Consistency tweask in prepararion for adding extension to translatewiki.net [extensions/IframePage] - 10https://gerrit.wikimedia.org/r/135192 (owner: 10Raimond Spekking) [17:40:26] I did chown vagrant /vagrant but the permissions look the same [17:41:41] (03CR) 10tosfos: [C: 032 V: 032] Add message documentation in preparation for adding extension to translatewki.net [extensions/IfTemplates] - 10https://gerrit.wikimedia.org/r/135198 (owner: 10Raimond Spekking) [17:42:46] #omgomg The W3 DOM just landed a specification for Element#closest [17:43:00] Like jQuery#closest [17:44:33] (03PS1) 10PleaseStand: DBConnectionError: Expand {{SITENAME}} in pagetitle with Message::text() [core] - 10https://gerrit.wikimedia.org/r/135443 (https://bugzilla.wikimedia.org/58447) [17:44:51] huh: try vagrant provision again, after the permissions change? [17:54:18] (03CR) 10Brian Wolff: "good catch. Will do" [core] - 10https://gerrit.wikimedia.org/r/135279 (owner: 10Brian Wolff) [17:54:56] YuviPanda: more of the same errors [17:55:14] huh: :( seems out of my league atm, file a bug? [17:55:15] err: /Stage[main]/Multiwiki/File[/vagrant/settings.d/multiwiki]/owner: change from 501 to vagrant failed: Failed to set owner to '1001': Operation not permitted - /vagrant/settings.d/multiwiki [17:55:17] err: /Stage[main]/Multiwiki/File[/vagrant/settings.d/multiwiki]/group: change from dialout to www-data failed: Failed to set group to '33': Operation not permitted - /vagrant/settings.d/multiwiki [17:55:51] Do you know how I can do that manually? [17:56:56] huh: hmm, try chown vagrant:www-data /vagrant/settings.d/multiwiki from vagrant ssh [17:56:56] ? [17:57:05] (03PS2) 10Brian Wolff: Reduce some code duplication [core] - 10https://gerrit.wikimedia.org/r/135279 [17:57:16] chown: changing ownership of `/vagrant/settings.d/multiwiki': Operation not permitted [17:57:56] I was running that as root... [17:58:27] ... [17:58:29] wow [17:58:47] huh: can you modify anything ther at all? [17:59:00] example? [17:59:04] huh: rm /vagrant/settings.d/multiwiki [17:59:11] huh: and see if that works? [17:59:17] (vagrant provision puts it back) [17:59:36] okay, done (with rm -rf) [18:00:11] works... [18:01:12] huh: vagrant provision again? [18:03:20] err: /Stage[main]/Multiwiki/File[/vagrant/settings.d/multiwiki]/ensure: change from absent to directory failed: Failed to set owner to '1001': Operation not permitted - /vagrant/settings.d/multiwiki [18:03:23] :/ [18:03:45] :| [18:03:59] does the user exist? [18:04:03] huh: wait, it's trying to create a directory there? [18:04:04] hmm [18:04:12] Nemo_bis: yes [18:04:53] am running it myself to check [18:07:33] Hey folks. I created a m1.medium VM that's supposed to have a 40GB root partition, but I only have a 8GB root partition. What did I do wrong? [18:07:56] woops. that was supposed to go to #wikimedia-labs [18:14:46] YuviPanda: did it work for you? [18:14:57] huh: yes it did [18:15:11] did it chown ? [18:16:17] huh: yeah [18:22:16] (03PS1) 10Umherirrender: Swap if/elseif in SpecialRevisiondelete.php [core] - 10https://gerrit.wikimedia.org/r/135444 [18:28:39] YuviPanda: I think I got it to work [18:28:55] huh: oh? what happened [18:29:30] (03CR) 10MarkTraceur: "OK, so I'm going to fix up the "massive refactor" patch, which removes the stupid ID methodology, and then also re-enable the archive warn" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65318 (https://bugzilla.wikimedia.org/40921) (owner: 10TheDJ) [18:29:33] After a while on Google, I found a solution [18:29:49] I removed NFS from Vagrantfile, restarted vagrant, and ran provision [18:31:18] huh: oh [18:31:20] huh: cool! [18:32:21] I don't know why it happened though [18:32:39] (03CR) 10Umherirrender: [C: 04-1] "Waiting merge of I39df27d3edb097024d136455145505429ccdbe39 and will change the if here also." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135197 (https://bugzilla.wikimedia.org/34467) (owner: 10Umherirrender) [18:33:31] huh: must be mounting issues [18:33:42] huh: maybe there was a user with id 1001 on your host as well and was causing issues [18:56:09] (03PS2) 10Brian Wolff: Check $wgMaxImageArea before downloading file asset from swift [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135101 (https://bugzilla.wikimedia.org/62306) [19:02:44] (03CR) 10Jackmcbarn: Allow filtering log entries by namespace (API) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135283 (owner: 10Jackmcbarn) [19:02:55] (03PS2) 10Jackmcbarn: Allow filtering log entries by namespace (API) [core] - 10https://gerrit.wikimedia.org/r/135283 [19:04:16] (03PS1) 10Umherirrender: Change one Linker::formatSize call to Message::sizeParams [core] - 10https://gerrit.wikimedia.org/r/135448 [19:12:18] (03PS1) 10Umherirrender: Use language from context in Skin::subPageSubtitle [core] - 10https://gerrit.wikimedia.org/r/135449 [19:33:56] PleaseStand: are you here [19:35:30] Yes [19:41:38] (03CR) 10PleaseStand: "> PleaseStand, can you tell us what your opinion is of the solution in Patch Set 1? It's different from Patch Set 4's proposed change and " [core] - 10https://gerrit.wikimedia.org/r/133411 (https://bugzilla.wikimedia.org/63677) (owner: 10Withoutaname) [19:42:07] thanks [19:45:03] Wtf is this? "Sign up to edit Wikipedia-We recommend you create an account to edit Wikipedia. It's free, easy, and requires no personal information." [19:45:13] when clicking section edit [19:45:36] (03PS6) 10Krinkle: Properly center arrowheads text [core] - 10https://gerrit.wikimedia.org/r/64556 (https://bugzilla.wikimedia.org/37109) (owner: 10Nischayn22) [19:45:44] (03CR) 10Krinkle: "Rebased to resolve merge conflict" [core] - 10https://gerrit.wikimedia.org/r/64556 (https://bugzilla.wikimedia.org/37109) (owner: 10Nischayn22) [19:45:58] wat [19:45:58] huh: https://blog.wikimedia.org/2014/05/16/anonymous-editor-acquisition/ [19:47:00] you should do something like say passwords are totally encrypted [19:47:27] (03PS7) 10Krinkle: jquery.arrowSteps: Center arrowheads text [core] - 10https://gerrit.wikimedia.org/r/64556 (https://bugzilla.wikimedia.org/37109) (owner: 10Nischayn22) [19:47:36] (03CR) 10Krinkle: "Addressed coding style issue." [core] - 10https://gerrit.wikimedia.org/r/64556 (https://bugzilla.wikimedia.org/37109) (owner: 10Nischayn22) [19:48:50] also I vote for first comment saying "anonymous" is a misnomer [19:49:28] "passwords are totally encrypted" should be the norm for websites [19:49:35] assuming you mean salted [19:50:40] wikipedia acquired by anonymous! [19:51:19] (03PS6) 10Hashar: Refactor doc publishing from labs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 [19:51:27] Some people encrypt passwords to (With the idea being if you only have a db dump of passwords, and not the encryption key in presumably a config file, it can slow you down) [19:55:04] 3MediaWiki extensions / 3Translate: Deprecated: Use of SpecialRecentChangesQuery hook (used in TranslateRcFilter::translationFilter) - 10https://bugzilla.wikimedia.org/65776#c1 (10Siebrand Mazeland) 5NEW>3RES/INV Because Translate is backwards compatibel with MediaWiki 1.21 and later, this Development wa... [19:55:04] Nemo_bis: it's better than those annoying scrolling ads WMF is using now [19:55:19] 3MediaWiki / 3Search: Provide way to override the behavior of default search box - 10https://bugzilla.wikimedia.org/65753#c3 (10Niklas Laxström) Hmm okay. I will try the RL approach by duplicating searchboxesSelectors and overriding 'fetch' and 'result' by calling .suggestions() in $( document ).ready(). If... [19:55:19] 3Analytics / 3Kraken: Hive queries inconsistently failing - 10https://bugzilla.wikimedia.org/65420#c26 (10Oliver Keyes) "The last application ID to come from Ironholds" :(. The disadvantage of crons is that it doesn't tell me. The disadvantage of hive is that for big queries I need crons. [19:55:36] 3MediaWiki / 3Special pages: When Special:WhatLinksHere is included and a valid title not provided, a form is shown - 10https://bugzilla.wikimedia.org/65779 (10Kevin Israel (PleaseStand)) 3NEW p:3Unprio s:3trivia a:3None To reproduce, navigate to the following URL: https://en.wikipedia.org/w/index.p... [19:55:50] 3MediaWiki / 3Special pages: When Special:Contributions for a blocked user is included, the block warning is shown - 10https://bugzilla.wikimedia.org/65781 (10Kevin Israel (PleaseStand)) 3NEW p:3Unprio s:3trivia a:3None To reproduce, navigate to the following URL: https://en.wikipedia.org/w/index.ph... [19:55:50] 3MediaWiki / 3Special pages: When Special:Contributions is included, paging links are shown - 10https://bugzilla.wikimedia.org/65780 (10Kevin Israel (PleaseStand)) 3NEW p:3Unprio s:3trivia a:3None To reproduce, navigate to the following URL: https://en.wikipedia.org/w/index.php?title=User:PleaseStan... [19:56:04] 3Wikimedia / 3Site requests: Set $wgLegacyJavaScriptGlobals = false on test wikis - 10https://bugzilla.wikimedia.org/65011#c4 (10TeleComNasSprVen) What are the default settings for the production wikis? [19:56:05] 3MediaWiki extensions / 3WikidataRepo: Site link already in use error is not parsed - 10https://bugzilla.wikimedia.org/65782 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Ran into a parsing issue by hitting save on https://www.wikidata.org/w/index.php?title=Q9027570&action=submit&undo=13386... [19:56:08] (03CR) 10Jack Phoenix: Configure: add a hook to the database handler. (031 comment) [extensions/Configure] - 10https://gerrit.wikimedia.org/r/77149 (owner: 10Jack Phoenix) [19:56:18] 3Analytics / 3Kraken: Hive queries inconsistently failing - 10https://bugzilla.wikimedia.org/65420#c27 (10Andrew Otto) You should probably be redirecting your stdout from crons anyway, eh? At the end of your cron command, add > /home/ironholds/blabla/whatever/path/whatever_file.log 2>&1 That will redire... [19:56:18] 3Analytics / 3Kraken: Hive queries inconsistently failing - 10https://bugzilla.wikimedia.org/65420#c28 (10Oliver Keyes) Neat; the last bit I was missing :). Let's see what happens... [19:56:33] 3Wikimedia / 3Site requests: Set $wgLegacyJavaScriptGlobals = false on test wikis - 10https://bugzilla.wikimedia.org/65011#c5 (10Helder) I think it is the same as the default MediaWiki configuration ($wgLegacyJavaScriptGlobals = true): https://github.com/wikimedia/mediawiki-core/blob/master/includes/DefaultS... [19:56:40] (03CR) 10Hashar: "The publish-doc job now has a step which is always invoked that create an empty dir and rsync it to the intermediary host to clean up the " [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 (owner: 10Hashar) [19:56:53] huh: well, everything is [19:57:27] (03PS1) 10Scnd: Better OCR layer filtering. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/135450 [19:57:29] (03CR) 10jenkins-bot: [V: 04-1] Better OCR layer filtering. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/135450 (owner: 10Scnd) [19:57:34] 3Wikimedia / 3Site requests: Set $wgLegacyJavaScriptGlobals = false on test wikis - 10https://bugzilla.wikimedia.org/65011#c6 (10Krinkle) Indeed, it is not currently overridden in wmf-config: https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/InitialiseSettings.php https://githu... [19:58:40] (03CR) 10Krinkle: Refactor doc publishing from labs (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 (owner: 10Hashar) [20:01:07] hmm [20:01:11] is there a way [20:01:15] in Special:UploadWizard [20:01:31] to fire publishing manually? [20:01:47] I'm uploading 21 files [20:02:03] actaully uploaded [20:02:13] and now saving info etc. [20:02:22] and looks like it's limited to 3 at once [20:02:27] but "Unable to check file's status" [20:02:51] so although files are already created it doesn't want to move to next ones [20:03:00] I'm not up to figuring out what's wring [20:03:02] *wron [20:03:03] g [20:03:13] I just don't want to repeat everything [20:06:44] (03CR) 10Krinkle: [C: 031] Refactor doc publishing from labs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 (owner: 10Hashar) [20:06:52] (03CR) 10Hashar: "I have already deployed the Jenkins jobs that change the path. So this docroot change needs to be deployed." [integration/docroot] - 10https://gerrit.wikimedia.org/r/135431 (owner: 10Hashar) [20:06:55] (03CR) 10Krinkle: [C: 031] Update doc links to scap and releng [integration/docroot] - 10https://gerrit.wikimedia.org/r/135431 (owner: 10Hashar) [20:07:04] (03CR) 10Hashar: [C: 032] Update doc links to scap and releng [integration/docroot] - 10https://gerrit.wikimedia.org/r/135431 (owner: 10Hashar) [20:07:07] (03Merged) 10jenkins-bot: Update doc links to scap and releng [integration/docroot] - 10https://gerrit.wikimedia.org/r/135431 (owner: 10Hashar) [20:09:01] (03CR) 10Parent5446: "Basically, to explain my point, a given configuration object key (i.e., a specific $factory->makeConfig( 'key')) represents *two* things: " [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [20:09:38] (03Abandoned) 10Scnd: Better OCR layer filtering. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/135450 (owner: 10Scnd) [20:13:14] (03CR) 10Hashar: Refactor doc publishing from labs (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 (owner: 10Hashar) [20:14:10] lazowik: UploadWizard often gets stuck there [20:14:17] Are you using Internet Exploder? [20:14:18] yeah [20:14:21] :D :D :D [20:14:26] good one :D [20:14:36] It's older than me almost ;) [20:14:43] (that yeah is not to IE :O) [20:15:04] (ok, one thing less to worry about then) [20:15:25] If you could manage to find a way to make it consistently fail, that would make a very precious bug report. :D [20:15:35] heh [20:15:48] now I'm more interested in firing save manually [20:15:56] (03PS1) 10Scnd: Better OCR layer filtering. [extensions/ProofreadPage] (REL1_23) - 10https://gerrit.wikimedia.org/r/135491 [20:18:25] (03PS1) 10Brian Wolff: Restructure Media related tests to avoid duplicated code [core] - 10https://gerrit.wikimedia.org/r/135492 [20:18:49] lazowik: it's not possible, or I never saw anyone mentioning how [20:20:24] lazowik: Go to Special:UploadStash - if its uploaded but not "published", your file will be listed on that page [20:20:54] lazowik: On commons the community has put together a script for a publish button, on other wikis you have to do something complicated ;) [20:21:51] (03CR) 10jenkins-bot: [V: 04-1] Restructure Media related tests to avoid duplicated code [core] - 10https://gerrit.wikimedia.org/r/135492 (owner: 10Brian Wolff) [20:21:58] damn it [20:22:10] It worked locally. I swear :( [20:22:34] bawolff: you know where that script is? [20:22:36] in gadgets? [20:22:45] lazowik: Its on by default in commons [20:23:12] hmm [20:23:20] MediaWiki:EnhancedStash - https://commons.wikimedia.org/w/index.php?title=Special:UploadStash&withJS=MediaWiki:EnhancedStash.js [20:25:34] bawolff: thanks :) [20:26:21] * bawolff probably shouldn't be getting thanks for telling you how to get around brokeness when really I should be fixing the brokeness :) [20:26:33] :p [20:26:57] but there is no way to fire some js from console? [20:27:12] I have the uploadwizard still open [20:27:36] I just want to know if I can keep reading the code [20:27:45] or is that a waste of time [20:28:32] Hmm, I have no idea. I only know about the backend part of uploading [20:29:01] bawolff: ok, that will help [20:29:09] if the server returns undefined status [20:29:22] or another question [20:29:30] is backed limiting publishing? [20:29:34] *baackend [20:29:40] multiple at once [20:29:48] or is that done in js [20:30:33] What happens is that the javascript uploads the file to a temporary holding space (upload stash) [20:30:55] Sometimes it does that in multiple parts (aka chunked uploading) for files > 10 mb [20:31:11] nah, I have all files in stash [20:31:20] it hanged on publishing [20:31:21] once that's all done, js sends an api request to "publish" the file [20:31:34] which is the act of copying from the stash -> the real site [20:31:45] mhm [20:31:55] The code that does that on the php side is super sketchy and fails mysteriously half the time [20:32:20] I have following status [20:32:55] 3 files on my uploadwizard page have this gif as if they were being published [20:33:01] I want to fix that code (or rewrite the stupid thing) sometime in the near-medium future [20:33:06] but they are already published [20:33:19] in console I get [20:33:28] Part of the problem is often success messages aren't being relayed properly from php to javascript [20:33:31] Unable to check file's status [20:33:35] yep [20:33:41] I think that's the case for me [20:37:15] (03PS2) 10Brian Wolff: Restructure Media related tests to avoid duplicated code [core] - 10https://gerrit.wikimedia.org/r/135492 [20:59:05] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Why using content language instead of user language? This line is an infomration of the interface, not of content. So, in my opinion, the " [core] - 10https://gerrit.wikimedia.org/r/135449 (owner: 10Umherirrender) [21:10:42] (03CR) 10Liangent: "Hm? Didn't check but I think $this->getLanguage() returns interface language." [core] - 10https://gerrit.wikimedia.org/r/135449 (owner: 10Umherirrender) [21:23:20] (03CR) 10Florianschmidtwelzow: [C: 031] "Hmm, damn, i missunderstood the commit message (content instead of context) and don't think about, that getLanguage get's the userlanguage" [core] - 10https://gerrit.wikimedia.org/r/135449 (owner: 10Umherirrender) [21:26:52] (03CR) 10AndyRussG: Allow for URLs in article assignment (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/134598 (https://bugzilla.wikimedia.org/44397) (owner: 10Jlloyd) [21:30:19] (03CR) 10AndyRussG: [C: 032] "We can always just revert before merging the branch to master :)" [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/133889 (owner: 10Adamw) [21:30:25] (03Merged) 10jenkins-bot: Change branch .gitreview to point to this long-lived topic branch [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/133889 (owner: 10Adamw) [21:38:28] (03PS1) 10Physikerwelt: WIP: Add separate database table for LaTeXML (step 3) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135495 [21:39:38] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add separate database table for LaTeXML (step 3) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135495 (owner: 10Physikerwelt) [21:43:13] (03PS1) 10Brian Wolff: Fix paged tiff handler tests [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135496 [21:44:55] (03PS2) 10Physikerwelt: WIP: Add separate database table for LaTeXML (step 3) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135495 [21:45:48] (03PS2) 10Brian Wolff: Fix paged tiff handler tests [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/135496 [21:45:50] (03CR) 10Physikerwelt: "I think it makes sense to break down this change further. A first step might be to move the texvc specific code to the texvc class" [extensions/Math] - 10https://gerrit.wikimedia.org/r/135495 (owner: 10Physikerwelt) [21:46:02] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add separate database table for LaTeXML (step 3) [extensions/Math] - 10https://gerrit.wikimedia.org/r/135495 (owner: 10Physikerwelt) [21:48:34] 3MediaWiki / 3Maintenance scripts: initSiteStats.php calls undefined/protected functions - 10https://bugzilla.wikimedia.org/65214#c2 (10Andyrom75) Which is the review status of this patch? [21:49:19] 3MediaWiki / 3User login and signup: AJAX validation of username for password reset - 10https://bugzilla.wikimedia.org/56025#c8 (10Alex Monk) Also, there are more issues with it that I pointed out in Gerrit. [21:49:48] 3MediaWiki / 3Special pages: When Special:Contributions for a blocked user is included, the block warning is shown - 10https://bugzilla.wikimedia.org/65781 (10Bawolff (Brian Wolff)) [21:50:18] 3MediaWiki / 3Special pages: When Special:Contributions is included, paging links are shown - 10https://bugzilla.wikimedia.org/65780 (10Bawolff (Brian Wolff)) [21:51:03] 3MediaWiki / 3Special pages: When Special:WhatLinksHere is included and a valid title not provided, a form is shown - 10https://bugzilla.wikimedia.org/65779 (10Bawolff (Brian Wolff)) [21:52:29] bawolff: just a blind shot [21:52:40] could it be connected to file size? [21:53:02] Chances for failure sometimes increase with larger files [21:53:15] I'm uploading 20-40 MiB files [21:53:32] and status getting fails on all of them [21:53:56] Some people seem to report that failures occur more often with chunked upload when the file is split into more chunks [21:54:18] bawolff: to be clear: files upload correctly [21:54:34] It just reports a failure? [21:54:36] and I can assign licenses etc. [21:54:49] and then on submitting [21:54:57] I get 3 files [21:55:03] and they have pages [21:55:13] but status for them is still saving [21:55:26] and because of that js doesn't move on [21:55:40] also I cannot get them from stash to identify them [21:55:44] I get Internal error [21:55:45] "Cannot serve a file larger than 1048576 bytes." [21:56:45] maybe internally some checks are blocked because of the filesize [21:57:10] * lazowik goes to setup uploadwizard locally [21:59:31] (03PS1) 10Jack Phoenix: It works! Well, sorta. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/135497 [22:00:30] (03CR) 10Jack Phoenix: [C: 032 V: 032] It works! Well, sorta. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/135497 (owner: 10Jack Phoenix) [22:01:16] lazowik> maybe internally some checks are blocked because of the filesize <-- No, the 1 MB limit is just from downloading from the stash [22:01:34] ah [22:01:34] its not an issue internally [22:01:41] that's 1MB… [22:02:00] If you really want, you can use the api to get an sha1 hash of the file and compare it with what you're uploading [22:02:15] meh [22:02:31] or just look at the file size in bytes, as that's usually a good enough indicator [22:02:59] I already wasted more time reading js than it would take me to upload all files 10 times [22:03:15] I can try find what's wrong [22:03:28] no hurry with this files and apparently they are a good test case [22:03:59] though you meant rather fails with uploading than submitting [22:04:00] right? [22:04:15] there's a lot of issues [22:04:56] The issue on the backend is that the upload is finished on a separate server via a cli script. The cli script marks success by trying to take over the users session, and mark a field in their session. Its unclear if the reason this fails is due to race conditions, or that just being a generally sketchy thing to do, or both [22:05:29] uhm [22:05:31] The upload wizard javascript doesn't have very much to do with the problem [22:05:32] that sounds bad [22:05:43] I'd expect some services with api [22:05:50] rather than scripts [22:06:43] Well mediawiki is written in a scripting language :P [22:07:05] shhh [22:07:33] s/scripts/overtaking user sessions/ [22:07:37] better? [22:08:24] Well it goes to the api. User may upload to the api in multiple chunks. Either the api could put it back together, or it puts a message in the redis job queue for another server to put it back together (since in the case of a gigabyte big file, putting the file back together can take more time than the timout for keeping the connection open). Then a command line php program takes things out... [22:08:25] ...of the job queue, puts the file back together [22:09:08] It then adds it to the users session (which is the sketchy part I don't like). Meanwhile the javascript polls the api, which eventually sees this key in the user's session, and the api tells that to the javascript [22:09:10] (03CR) 10Parent5446: update.php: Correctly report durations >= 1 hour (031 comment) [core] - 10https://gerrit.wikimedia.org/r/135433 (https://bugzilla.wikimedia.org/65772) (owner: 10PleaseStand) [22:09:40] mhm [22:09:49] I didn't mean mw api [22:10:14] but some little service for handling state [22:10:53] A FSM! [22:11:51] 3MediaWiki extensions / 3CirrusSearch: Allow search in the raw wiki text source via insource: - 10https://bugzilla.wikimedia.org/65783 (10Thiemo Mättig) 3NEW p:3Unprio s:3normal a:3None The German community did a voting for a "technical wish list". "Source search" made it into the top 20 wishes. See... [22:12:05] lazowik: Well it doesn't need a dedicated storage, just somewhere to put it that's not the user's session, particularly for the cli script (e.g. The database would work well. Even memcache would work better) [22:12:23] is this setup reproducible in home setup? [22:12:29] or better labs? [22:12:38] If you feel like spending a couple hours setting it up [22:12:49] 3MediaWiki extensions / 3CirrusSearch: Allow search in the raw wiki text source via insource: - 10https://bugzilla.wikimedia.org/65783 (10MZMcBride) [22:13:01] I think commons beta labs has the same setup [22:13:23] possibly different for swift, but that only mildy affects that [22:14:11] eh, sounds a bit too complicated for me :) [22:14:56] The main part of doing it though, is probably not too bad [22:15:25] ie Running things through the job queue on the same machine as your local test server. [22:15:36] It all depends on how close to production you want to be [22:15:58] mhm [22:16:34] The basic version would be [22:16:37] Enable $wgEnableAsyncUploads [22:17:13] have php runJobs.php --type AssembleUploadChunks and php runJobs.php --type PublishStashedFile [22:17:16] running in a loop [22:17:53] mhm [22:18:21] install upload wizard (Although if testing the backend stuff, its much easier to test with User:Rillke/bigChunkedUpload.js script then with uploadWizard, since that strips away some of the complexity) [22:19:47] bawolff: and how is the part with final saving status handled? [22:20:05] for what its worth, I think I have a fairly good idea of what needs to be done (or at least the next step of what needs to be done in order to see what new errors pop up) in terms of changes to file upload backend [22:20:44] See includes/jobqueue/jobs/PublishStashedFileJob.php [22:23:47] (03CR) 10Parent5446: "Two problems:" [core] - 10https://gerrit.wikimedia.org/r/135290 (https://bugzilla.wikimedia.org/63483) (owner: 1001tonythomas) [22:24:32] It uses a method called RequestContext::importScopedSession to screw with a different users session. Which is then looked at in includes/api/ApiUpload.php and includes/upload/UploadFromChunks.php and friends [22:25:14] hmm [22:25:42] (03PS3) 10Legoktm: Relay some API methods to the actual submodule [extensions/Flow] - 10https://gerrit.wikimedia.org/r/132145 (owner: 10Matthias Mullie) [22:31:04] 3MediaWiki / 3General/Unknown: HHVM goes bonkers in HtmlFormatter - 10https://bugzilla.wikimedia.org/65703#c1 (10Tim Starling) I tried just running a random cirrusSearchLinksUpdate job, but it didn't crash. Where are the logs? Is there any core file? [22:31:05] (03CR) 10Legoktm: [C: 031] "Rather than try to vary the needsToken() stuff at runtime, I just set the defaults in ApiFlow to read actions (no token needed), and it no" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/132145 (owner: 10Matthias Mullie) [22:34:58] (03PS3) 10Legoktm: Split out POST-specific logic from ApiFlowBase & add a new one for GET [extensions/Flow] - 10https://gerrit.wikimedia.org/r/132146 (owner: 10Matthias Mullie) [22:35:37] Withoutaname: can you test a patch for me? [22:35:58] sprven [22:36:49] 3MediaWiki / 3General/Unknown: HHVM goes bonkers in HtmlFormatter - 10https://bugzilla.wikimedia.org/65703#c2 (10Ori Livneh) Created attachment 15478 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15478&action=edit PHP and HHVM stack traces [22:37:13] (03CR) 10Legoktm: [C: 031] Split out POST-specific logic from ApiFlowBase & add a new one for GET [extensions/Flow] - 10https://gerrit.wikimedia.org/r/132146 (owner: 10Matthias Mullie) [22:38:01] pff [22:38:10] bawolff: locally with default setup [22:38:16] I got even more interesting result [22:38:17] huh: depends on the patch I might be able to configure my vagrant install [22:38:24] but im not good with vagrant :S [22:38:25] file is uploaded, page created [22:38:33] should be pretty easy https://gerrit.wikimedia.org/r/#/c/129933/ [22:38:42] but uplodwizard says unknown error [22:39:52] I messed up my vagrant, so I can't really test it [22:40:06] without going through another hour of reinstalling it [22:40:54] lazowik: Well that's fun [22:41:06] TimStarling: re https://gerrit.wikimedia.org/r/#/c/127458/ , is there any clean way to keep localization? [22:41:34] lazowik: Make sure you have $wgShowExceptionDetails = true; and look at the api responses, there might be a more detailed error message in there [22:41:46] yeah [22:42:25] # Development error handling [22:42:25] error_reporting( -1 ); [22:42:25] ini_set( 'display_errors', 1 ); [22:42:27] [22:42:29] $wgShowExceptionDetails = true; [22:42:31] $wgShowSQLErrors = true; [22:42:33] $wgDebugDumpSql = true; [22:42:35] $wgShowDBErrorBacktrace = true; [22:42:37] $wgDevelopmentWarnings = true; [22:42:39] [22:42:41] $wgDebugToolbar = true; [22:42:43] bawolff: ^ I think I've got all covered [22:42:52] heh, wow. [22:43:06] pretty sure you have more debug options turned on than me [22:43:17] That's more or less what I have [22:43:25] Except I don't have the debug toolbar on [22:43:48] and use $wgDebugComments instead [22:44:17] bawolff: I'll try to poke that, but later [22:44:28] I'd rather do some wikidata stuff first [22:44:43] Just use the debug toolbar, its much nicer than debug comments and does the same thing rougly [22:44:53] Hello does any of the dev hang about in here from the foundation [22:45:02] or any of the foundation team in general [22:45:13] satdav: about 90% of the people on this channel [22:45:26] err maybe not 90%. about half probably [22:45:58] huh: what am i supposed to be looking for [22:46:00] bawolff, I need someone from them who is willing to speak to me the now about Wikipedia volunteers and policys [22:46:00] This is not the right channel for dealing with production user accounts, if that's what you're here for satdav. [22:46:11] Withoutaname: Special:Whatlinkshere invert namespace box [22:46:23] Krenair, what channel them [22:46:24] Especially Wikipedia. [22:46:25] what's a production user account? shell access? [22:46:35] mo a user account on wikipedia [22:46:37] bawolff, just a standard wiki account [22:46:52] huh: do I just unpack it into /vagrant/mediawiki... [22:46:58] jackmcbarn: I was thinking that mw.executeModule() could return an array instead of just the module function [22:47:01] Withoutaname: I'm not sure :/ [22:47:10] satdav: For that, why do you need to talk to us? Everyone can register an account [22:47:17] if I figure out how to use vagrant, I'll test the empty group script you wrote [22:47:17] Ugh, isn't there any good database abstraction layer for MySQL in PHP out there? I've looked into a dozen and they're all crap. The one thing I specifically am looking for is being able to insert and query with associative arrays (where values are automatically inserts) instead of using silly '?' placeholders. [22:47:17] Withoutaname: you can unpack a tarball to /vagrant/mediawiki, yes [22:47:23] if there is no error, it could be something like [22:47:28] TimStarling: the whole point of the change is that it doesn't do that (unless you mean an array with something else in it, in which case, what?) [22:47:30] {func: thefunction} [22:47:33] The one in MediaWiki isn't perfect, but it's pretty good. [22:47:34] thanks [22:47:35] no about a email change [22:47:43] as I cant access my old email [22:47:47] if there is an error, something like [22:47:49] TimStarling: oh, you mean like what pcall returns? [22:47:50] {error: messagekey} [22:47:59] kk [22:48:08] been told to speak to someone in the [[WP:OTRS]] team [22:48:19] then Scribunto_LuaEngine::executeModule() could localise and throw the exception [22:48:26] ori: I did git fetch ssh: blah blah into mediawiki, is that fine [22:48:32] satdav, this is not the channel of the OTRS team. [22:48:33] satdav: I don't think you need a developer [22:48:34] or should I have done a gzip [22:48:44] Withoutaname: if the end result is that mediawiki's files are located in that directory, it's fine [22:48:46] #wikimedia-otrs [22:49:11] dev != otrs [22:49:52] For that matter foundation employees != otrs [22:50:05] otrs are volunteers [22:50:17] Krenair: http://doctrine-dbal.readthedocs.org/en/latest/reference/data-retrieval-and-manipulation.html#insert [22:50:34] Krinkle, ^ [22:51:30] lazowik: That one uses the same default (imho crippled) "prepared statement" system out of the box with question marks as positional placeholders. [22:51:51] $conn->insert('user', array('username' => 'jwage')); [22:52:00] insert it does better, though I'll be doing read queries only (looking for a library to settle on to use in all my labs tools) [22:52:46] ah, you want qury [22:52:49] *query [22:55:13] lazowik: Yeah [22:55:50] http://www.doctrine-project.org/api/dbal/2.1/class-Doctrine.DBAL.Query.QueryBuilder.html [22:55:58] setParameters [22:56:25] http://wklej.org/hash/e2cc90d0f14/ [22:56:38] (03CR) 10Bartosz Dziewoński: "Eh. Okay, consider me persuaded. I still think that consistently using 'SkinName' everywhere in better in principle than consistently usin" [core] - 10https://gerrit.wikimedia.org/r/135384 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [22:56:39] meh [22:56:46] How do I fix this (git)? https://tools.wmflabs.org/paste/view/12b7af15 [22:56:47] too eager [22:56:59] that's not it [22:57:14] lazowik: Hm.. using placeholders still, but the :named ones. That's better. [22:57:23] yeah [22:57:25] That's part of mysqli though now that I checked there [22:57:38] that's also possible without this querybuilder [22:57:56] So I guess the reason all these libs lack doing it directly is because they want to use a prepared statement and set the properties separately [22:58:01] huh: Page: Namespace: all Invert select Go! (whatlinkshere) (whatlinkshere-summary) (whatlinkshere-page) (namespace) (namespacesall) (invert) (allpagessubmit) [22:58:03] why wouldn't that be abstracted by an API? [22:58:29] *Invert selection [22:58:46] e.g. where('foo' => $name). It could internally (if it wants to, to avoid escaping manually inside the lib) expand to name=:name and then call bindValue('name', $x) [22:58:47] huh: http://stackoverflow.com/questions/6265502/getting-rid-of-does-not-point-to-a-valid-object-for-an-old-git-branch ? [22:58:49] ugh [22:59:06] Krinkle: then write that :p [22:59:10] lazowik: I tried git remote prune origin, just gave me the same error... [22:59:19] I've never used git before [22:59:38] lazowik: Yes, but for once I want to believe the internet isn't completely visionless and incompetent and just use something that works nicely. [22:59:41] I only use the steps at [[Gerrit/Getting started] [22:59:52] * huh looks [22:59:55] so when git breaks I have no idea how to fix :S [23:00:00] Krinkle: heh [23:00:22] huh: if you don't have some local changes you can clone again [23:00:33] that might mess up vagrant [23:00:38] there's a pink unicorn on my vagrant install [23:01:22] (>o.o)> <(o.o<) [23:18:27] 'night [23:18:59] (03PS9) 10Jackmcbarn: Keep modules' export tables inside Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127458 (https://bugzilla.wikimedia.org/64141) [23:22:01] TimStarling: ^ will that do? [23:23:35] (03CR) 10Bartosz Dziewoński: "Or maybe not. Consider me undecided. REGARDLESS, I'll do this patch keeping the current lowercase names because that's easier for now and " [core] - 10https://gerrit.wikimedia.org/r/135384 (https://bugzilla.wikimedia.org/65748) (owner: 10Bartosz Dziewoński) [23:45:49] please discuss how to write better articles on Wikipedia: http://en.wikipedia.beta.wmflabs.org/wiki/Wikipedia:Village_pump_%28proposals%29 [23:46:41] what? [23:46:42] Withoutaname: what? that's the beta cluster VPR. no discussions happen there [23:49:03] oh oops [23:49:14] I wanted to see if any enwikians actually tried to edit there [23:51:03] i doubt most people know that exists [23:52:44] jackmcbarn: I guess it is good enough, but could you maybe add a couple more comments? [23:53:49] TimStarling: about what? [23:54:29] maybe document the return value in the doc comment of mw.executeModule, and also explain the return convention in the if ( !$retval[0] ) case in Scribunto_LuaEngine::executeModule() [23:54:45] booleans are almost always confusing [23:55:09] if you have to use them, they need lots of documentation [23:55:13] ideally you wouldn't use them at all [23:55:25] TimStarling: speaking of that, is there convention for documenting multiple return values? [23:55:28] is it 2 @return's? [23:56:18] I just use @return string|null String if found, null if not [23:56:31] Withoutaname: the function actually returns 2 things every call [23:56:43] how? [23:56:48] lua lets you do that [23:56:49] well, in theory the format is doxygen, so you could check doxygen's manual [23:56:50] just "return foo, bar" [23:56:54] oh lua [23:57:11] but in practice, I don't think we actually generate doxygen docs from those comments, so you can probably invent your own convention [23:57:53] "These languages are supported by default: C, C++, C#, Objective-C, IDL, Java, VHDL, PHP, Python, Tcl, Fortran, and D." [23:58:00] I don't see Lua on that list [23:58:13] so it probably won't work no matter what you do [23:58:53] 2 @return's it is then [23:59:15] most people don't bother to check the doxygen output even in PHP