[00:00:50] (03CR) 10Legoktm: "Looks generally fine, but this is only going to work on meta instead of all wikis where the account is attached, which is not what the bug" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/133997 (https://bugzilla.wikimedia.org/52674) (owner: 10Gerrit Patch Uploader) [00:01:21] legoktm: it will still display a notice for locked accounts on wikis other than Meta [00:01:29] it just can't display the log [00:01:39] oh, interesting. [00:01:49] Fixing that would require changing the way locks work in CentralAuth [00:02:02] mhm [00:02:04] or loop through every wiki [00:03:28] for the same reason, you can view the lock log on but not [00:03:28] (03CR) 10Legoktm: "PiRSquared17 pointed out that this will still show a notice just not a log entry. Better than nothing." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/133997 (https://bugzilla.wikimedia.org/52674) (owner: 10Gerrit Patch Uploader) [00:03:37] yup yup [00:05:19] how do I test CentralAuth changes [00:05:26] I only have one vagrant install [00:05:36] and I'm not a steward :( [00:05:58] Withoutaname: you can install CentralAuth with one wiki [00:06:03] Withoutaname: vagrant enable-role centralauth :) [00:06:07] sets up multiple wikis too [00:07:39] yeah, I would want to see if global blocking IP on one wiki is viewable from a non-central wiki [00:07:46] This would technically display incorrect information if the account has its status changed on multiple wikis, but I don't think it ever happens in practice [00:07:49] at least two wikis [00:08:00] Withoutaname: it should be, it uses the same code as Special:GlobalBlockList [00:08:36] legoktm: quick question, is the wiki API in XML [00:08:45] (03CR) 10Krinkle: [WIP] resourceloader: Implement "skip function" feature (033 comments) [core] - 10https://gerrit.wikimedia.org/r/135085 (owner: 10Krinkle) [00:08:54] Withoutaname: yes, and more: https://www.mediawiki.org/wiki/API:Formats [00:09:12] MediaWiki API is internally a PHP object, but can be exported to json, xml, yaml, etc. [00:11:35] legoktm: is it possible to install vagrant if your computer does not support git? [00:11:43] (03CR) 10Legoktm: [C: 04-1] "Minor stuff, looks good." (033 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/133997 (https://bugzilla.wikimedia.org/52674) (owner: 10Gerrit Patch Uploader) [00:12:26] azertyuiop: it should be [00:12:39] you'll need to be able to install virtualbox and vagrant though [00:12:47] http://www.vagrantup.com/downloads.html [00:13:46] how would you git submodule update --init [00:14:04] um, context? [00:14:26] azertyuiop: oh now that I think about it, maybe not. is there a reason you can't install git? [00:14:59] https://www.mediawiki.org/wiki/MediaWiki-Vagrant <- git submodule update --init --recursive actually [00:15:20] I have an old version of Mac OS X (although I have Linux virtual machines that support git). I've tried several times to download git, but it never seems to work. [00:15:24] unless you're talking about plain vagrant [00:15:46] Maybe because I don't have XCode [00:16:36] azertyuiop: what version of OSX? [00:25:01] (03PS2) 10Gerrit Patch Uploader: Show lock notice on contribs for locked users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/133997 (https://bugzilla.wikimedia.org/52674) [00:25:03] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/133997 (https://bugzilla.wikimedia.org/52674) (owner: 10Gerrit Patch Uploader) [00:26:34] I would have rather we scratch locking and find a way for global blocks to apply to global accounts [00:26:45] Withoutaname: there's a bug for that [00:26:52] that is probably a pipe dream though [00:26:58] yeah that's where i got my idea :P [00:27:27] but we would have to scratch the lock system [00:27:32] bug 15294 [00:27:47] Withoutaname: this could be added on top of the existing system [00:27:54] that would be a good way to create a mess [00:28:56] and confusion [00:29:19] (03PS1) 10Jforrester: jquery.autoEllipsis.test.js: Swap $.browser for $.client for comtaibility [core] - 10https://gerrit.wikimedia.org/r/135153 [00:29:40] (03PS2) 10Jforrester: jquery.autoEllipsis.test: Swap $.browser for $.client for compatibility [core] - 10https://gerrit.wikimedia.org/r/135153 [00:29:49] or just add it as an optional extension [00:29:55] yeah [00:30:06] it's not like mediawiki has a lot of those anyway [00:30:24] Withoutaname: or this could be added as part of the lock interface [00:30:56] so it's just like setting options for the lock [00:33:42] (03CR) 10jenkins-bot: [V: 04-1] jquery.autoEllipsis.test: Swap $.browser for $.client for compatibility [core] - 10https://gerrit.wikimedia.org/r/135153 (owner: 10Jforrester) [00:35:39] (03PS3) 10Jforrester: jquery.autoEllipsis.test: Swap $.browser for $.client for compatibility [core] - 10https://gerrit.wikimedia.org/r/135153 [00:38:19] 3MediaWiki / 3Internationalization: Version number shouldn't always use localized parentheses - 10https://bugzilla.wikimedia.org/40254 (10FunPika) 5NEW>3ASS a:3FunPika [00:40:33] What does the semantic keyword FULLPAGENAME return? Ex: For URL http://127.0.0.1:8080/wiki/Book1, will it return complete URL or just Book1 ? [00:40:44] Book1 [00:41:19] legoktm: Thanks. I thought the same. I am facing some problem making templates in SMW. I am trying to implement a rating system. Please see my two templates and help me point out my mistake. Really appritiated. https://dpaste.de/9XzA [00:41:19] zeek: https://www.mediawiki.org/wiki/Help:Magic_words#Page_names [00:41:57] for smw help you should try #semantic-mediawiki (I think that's their channel) [00:42:16] legoktm: People are AFK at this time of day i believe [00:42:21] I checked there [00:42:24] what's semantic mediawiki [00:42:44] an extension [00:43:13] I heard they were going to make some big changes to mw but [00:43:18] https://www.mediawiki.org/wiki/Extension:Semantic_MediaWiki https://www.semantic-mediawiki.org/wiki/Semantic_MediaWiki [00:43:30] mw told them to split off to their own site [00:43:44] legoktm: Want to do a 5-second review to fix the only use of $.browser in MW core outside of /resources/lib ? https://gerrit.wikimedia.org/r/#/c/135153/ :-) [00:43:46] yeah, that sounds about right [00:44:28] legoktm: Can you please look? [00:44:37] azertyuiop: did they not like each other [00:45:31] Withoutaname: I doubt it. [00:45:36] https://en.wikipedia.org/wiki/Semantic_MediaWiki [00:45:43] James_F: does $.client require jquery.client to be a dependency? [00:46:24] oh, this is in a test. [00:46:36] (03CR) 10Legoktm: [C: 032] jquery.autoEllipsis.test: Swap $.browser for $.client for compatibility [core] - 10https://gerrit.wikimedia.org/r/135153 (owner: 10Jforrester) [00:48:33] legoktm: It does, but it already was. [00:48:41] yup, I figured that out [00:48:57] :-) [00:49:47] Withoutaname: considering the semantic MediaWiki devs are also developers of other MediaWiki extensions and core, that seems unlikely. [00:49:49] (03Merged) 10jenkins-bot: jquery.autoEllipsis.test: Swap $.browser for $.client for compatibility [core] - 10https://gerrit.wikimedia.org/r/135153 (owner: 10Jforrester) [00:49:58] zeek: sorry I cant read semantic mediawiki [00:49:58] legoktm: Thanks. [00:50:28] just wondering why they split off [00:50:32] np [00:50:39] Withoutaname: ask them? ;) [00:50:44] azertyuiop, Withoutaname : SMW is fine and does neat stuff, it's just heavyweight for Wikipedia, hard to perform at WMF scale [00:51:48] And Wikidata can do that now [00:51:51] ? [00:52:20] Withoutaname: https://www.semantic-mediawiki.org/wiki/FAQ#What_is_the_relationship_between_Semantic_MediaWiki_and_Wikidata.3F [00:53:15] Withoutaname: Wikidata doesn't attempt as much, doesn't let you embed generic ask queries in a page. But in other ways it's richer, a Wikidata fact can have multiple sources, etc. [00:54:43] legoktm: I managed to fix it.... There was problem in the query... still persists.. but I am looking :) [00:55:01] I can't really help much, I'm not familiar with SMW [00:55:20] Ohh no problem. :) [00:57:56] PleaseStand, are you here [00:57:59] zeek, general suggestions: use Special:Ask to test your query, use sandbox pages to test your individual [[Has rating]], etc. Putting it all into a table is going to be a parsing nightmare of [[ {{| | }} [[ ]] |- WTF , years ago I had some familiarity with the pitfalls [00:58:50] spagewmf: Noted. Will do so. Currently facing a problem that on running {{#ask:http://en.wikipedia.org/wiki/Special:Search?go=Go&search=Category:Reviews]][[Item::{{FULLPAGENAME}}|?Rating|format=average}}, it doesnt show the average value, it lists all dont know why! :| [00:59:06] Oops [00:59:17] {{#ask:http://en.wikipedia.org/wiki/Special:Search?go=Go&search=Category:Reviews]][[Item::{{FULLPAGENAME}}|?Rating|format=average}} [00:59:21] Wtf [00:59:33] my bad [00:59:34] {{#ask:http://en.wikipedia.org/wiki/Special:Search?go=Go&search=Category:Reviews[[Has item::{{FULLPAGENAME}}]]|?Has rating|format=average}} [00:59:52] Lol, the Template gets rendered in the chat too [01:00:36] :) it's hard, hope you get help in in the SMW IRC channel [01:00:42] I was writting this actually, Hope it is now escaped #ask:/[/[/Category:Reviews]] [01:01:07] Yeah I tried, I don't think its their time of the day to work! [01:06:12] (03CR) 10Ajraddatz: [C: 031] "looks good to me" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/133997 (https://bugzilla.wikimedia.org/52674) (owner: 10Gerrit Patch Uploader) [01:09:01] (03PS2) 10Spage: Use Mantle to load front-end handlebars resources [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/131085 [01:09:19] (03CR) 10jenkins-bot: [V: 04-1] Use Mantle to load front-end handlebars resources [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/131085 (owner: 10Spage) [01:10:58] (03PS3) 10Withoutaname: Add script to empty a usergroup of users [core] - 10https://gerrit.wikimedia.org/r/135077 [01:27:30] (03PS1) 10Krinkle: jquery.makeCollapsible: Use .prop() for value attribute of list item [core] - 10https://gerrit.wikimedia.org/r/135160 [01:27:41] (03CR) 10Krinkle: [C: 032] "Thanks!" [extensions/examples] - 10https://gerrit.wikimedia.org/r/135148 (owner: 10Harshkothari410) [01:28:35] (03CR) 10Krinkle: "Caught it in Jenkins in a gate job on master for qunit: https://integration.wikimedia.org/ci/job/mediawiki-core-qunit/21845/consoleFull" [core] - 10https://gerrit.wikimedia.org/r/135160 (owner: 10Krinkle) [01:29:37] (03CR) 10Legoktm: [V: 032] corrected name in README from BoilerTemplate to BoilerPlate [extensions/examples] - 10https://gerrit.wikimedia.org/r/135148 (owner: 10Harshkothari410) [01:30:38] legoktm: is it possible for a function to return another function? or if it was printed on the console, a reference to the returned function? [01:30:54] yes, functions can return callables [01:33:51] higher order functions [01:34:00] (03PS1) 10Krinkle: mediawiki.test.js: Suppress false postives for deprecated mw.* properties [core] - 10https://gerrit.wikimedia.org/r/135161 [01:36:24] (03CR) 10Krinkle: "Yep, confirmed in the console output of the build for this patch that it is now gone:" [core] - 10https://gerrit.wikimedia.org/r/135161 (owner: 10Krinkle) [01:38:43] (03PS5) 10Krinkle: Disable jQuery Migrate by default (enable via $wgIncludejQueryMigrate) [core] - 10https://gerrit.wikimedia.org/r/133719 (https://bugzilla.wikimedia.org/44740) (owner: 10Jforrester) [01:39:28] (03Abandoned) 10Krinkle: Remove jQuery Migrate [core] - 10https://gerrit.wikimedia.org/r/134607 (https://bugzilla.wikimedia.org/44740) (owner: 10Krinkle) [01:40:50] any idea why a lot of people wrote basically the same thing on bugzilla a few months ago? e.g. "I am new to FOSS, please help me to fix this bug" [01:41:21] Is there any chance they might still be interested in fixing them? Should I consider them assigned? [01:41:33] (03PS6) 10Krinkle: Disable jQuery Migrate by default (enable via $wgIncludejQueryMigrate) [core] - 10https://gerrit.wikimedia.org/r/133719 (https://bugzilla.wikimedia.org/44740) (owner: 10Jforrester) [01:51:13] azertyuiop: They were all trying to get into gsoc/OPW probably [01:51:31] bawolff: do you think they'll still take the bugs? [01:51:47] azertyuiop: Or maybe somebody attending some sort of outreach event and tried to convince a bunch of newbies to join up [01:52:00] okay [01:52:23] azertyuiop: If its been a while I'd reccomend writing a polite comment on the bug asking if they are still interested/attempting to fix the bug [01:52:59] while I was writing the script I found it kind of cumbersome to keep referring to the user.php class [01:53:13] do you think it would be a worthwhile project to branch off a usergroup class [01:53:24] (03PS1) 10FunPika: Don't localize parentheses in version number in parserTests.php [core] - 10https://gerrit.wikimedia.org/r/135162 (https://bugzilla.wikimedia.org/40254) [01:53:27] bawolff: how long should I wait? [01:53:44] In my experiance though, people usually fix a bug with in at most a month of saying they are interested if they are going to do it [01:54:07] azertyuiop: If there's been no activity for say a week and a half, ask if they're still trying [01:55:41] Withoutaname: If there are several methods that are rather isolated from the User class and generally do separate things, I'd say sure [01:55:54] thanks [01:56:21] oh uh, when I create a user object, how would it create a new account in database [01:57:10] (03PS1) 10Spage: Flow front-end rewrite branch depends on Mantle [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/135163 [01:58:04] Withoutaname: However if there's only a couple methods (e.g add to group, remove from groups, list groups) I'd probably say not worth it [01:58:30] but various people have various opinions on how fine grained classes should be. The Wikidata people would probably want to split it into 10 classes [01:58:52] (03CR) 10Spage: "Updated, but test doesn't work." (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/131085 (owner: 10Spage) [01:59:00] Withoutaname: It doesn't generally create a new entry in the database, unless you call some method I think [01:59:27] (03CR) 10Spage: Use Mantle to load front-end handlebars resources (031 comment) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/131085 (owner: 10Spage) [01:59:57] ok, I'm going to look through SpecialUserLogin.php to find the black magic responsible [02:01:04] 3MediaWiki / 3History/Diffs: Provide an easy way to get a diff against an old revision of a page while editing it - 10https://bugzilla.wikimedia.org/35067 (10JuneHyeon Bae (devunt)) a:3JuneHyeon Bae (devunt) [02:01:22] See User::addToDatabase [02:01:35] and initUser function of that special page [02:02:16] Keep in mind, it sometimes happens that you have User objects without a db entry (e.g. anon users. probably some other edge cases with maintinance users) [02:04:48] 3MediaWiki extensions / 3GeoData: Database returned error "1054: Unknown column 'gt_lat_int' in 'field list' - 10https://bugzilla.wikimedia.org/65641#c4 (10massimiliano.pisani) 5UNC>3RES/WOR Perfect! Now everything works, including MobileFrontend!!! Thank you for the help! For anyone with the same probl... [02:04:49] a user object doesn't mean they actually exist. [02:06:37] hm, why did they user !$user->isLoggedIn() instead of !$user->loadFromDatabase() [02:07:33] 3MediaWiki / 3General/Unknown: High-density display issues (tracking) xhdpi hdpi Retina high-resolution HiDPI - 10https://bugzilla.wikimedia.org/32101 (10Andre Klapper) [02:07:33] 3MediaWiki / 3Skin and page rendering: "a wikimedia project" and "powered by mediawiki" badges are not retina quality (make them SVGs?) - 10https://bugzilla.wikimedia.org/65715 (10Andre Klapper) [02:07:48] interesting [02:08:50] legoktm: I was only asking for the specific function called that would allow a db->insert() [02:14:18] 3MediaWiki extensions / 3Scribunto: mw.loadData can be used to pass data between #invoke's by reading frame arguments - 10https://bugzilla.wikimedia.org/65687 (10Andre Klapper) p:5Unprio>3High s:5normal>3major [02:17:18] 3MediaWiki / 3Skin and page rendering: "a wikimedia project" and "powered by mediawiki" badges are not retina quality (make them SVGs?) - 10https://bugzilla.wikimedia.org/65715#c2 (10Kevin Israel (PleaseStand)) 5NEW>3RES/DUP *** This bug has been marked as a duplicate of bug 63872 *** [02:17:18] 3MediaWiki / 3Skin and page rendering: Wikimedia and MediaWiki footer buttons should be SVG or HiDPI - 10https://bugzilla.wikimedia.org/63872#c2 (10Kevin Israel (PleaseStand)) *** Bug 65715 has been marked as a duplicate of this bug. *** [02:23:16] (03PS1) 10devunt: Add "Show changes against previous revision" button [core] - 10https://gerrit.wikimedia.org/r/135165 (https://bugzilla.wikimedia.org/35067) [02:29:03] 3MediaWiki / 3User login and signup: Tab from Username no longer sends user to Password field, but instead to Search box - 10https://bugzilla.wikimedia.org/65704#c2 (10Andre Klapper) (In reply to Steven Walling from comment #1) > I don't think we changed the tabindex? Bug 29199 comment 21 got committed; mor... [02:29:18] 3MediaWiki / 3User login and signup: Tab from Username no longer sends user to Password field, but instead to Search box - 10https://bugzilla.wikimedia.org/65704 (10Andre Klapper) [02:29:18] 3MediaWiki / 3Skin and page rendering: Tab index sorting doesn't make sense - 10https://bugzilla.wikimedia.org/29199 (10Andre Klapper) [02:55:51] (03CR) 10TTO: "Hi Paladox, if you're the maintainer of this extension you should have +2 rights on this repository. Try contacting QChris at https://www." [extensions/ExtensionStatus] - 10https://gerrit.wikimedia.org/r/135068 (owner: 10Paladox) [03:03:40] (03PS1) 10Catrope: Followup dd1c7f7fd7: fix LESSification errors in Parsoid styles [core] - 10https://gerrit.wikimedia.org/r/135167 [03:04:12] (03PS2) 10Catrope: Followup dd1c7f7fd7: fix LESSification errors in Parsoid styles [core] - 10https://gerrit.wikimedia.org/r/135167 (https://bugzilla.wikimedia.org/65596) [03:08:05] 3MediaWiki extensions / 3WikidataRepo: usage tracking on repo for purging items - 10https://bugzilla.wikimedia.org/65718 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs When I add a label on Wikidata and that item is used in a statement on another item, it appears that the other item does not get... [03:09:05] (03CR) 10Jforrester: [C: 032] Followup dd1c7f7fd7: fix LESSification errors in Parsoid styles [core] - 10https://gerrit.wikimedia.org/r/135167 (https://bugzilla.wikimedia.org/65596) (owner: 10Catrope) [03:12:07] (03Merged) 10jenkins-bot: Followup dd1c7f7fd7: fix LESSification errors in Parsoid styles [core] - 10https://gerrit.wikimedia.org/r/135167 (https://bugzilla.wikimedia.org/65596) (owner: 10Catrope) [03:47:52] (03PS1) 10Jforrester: Update VisualEditor to I55e16775 [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135176 [03:51:21] (03PS2) 10Gerrit Patch Uploader: Fix division by zero in Special:WikiSets [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/130644 (https://bugzilla.wikimedia.org/58475) [03:51:23] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/130644 (https://bugzilla.wikimedia.org/58475) (owner: 10Gerrit Patch Uploader) [03:56:47] (03CR) 10Jforrester: [C: 032] mediawiki.test.js: Suppress false postives for deprecated mw.* properties [core] - 10https://gerrit.wikimedia.org/r/135161 (owner: 10Krinkle) [03:57:42] (03PS2) 10Jforrester: jquery.makeCollapsible: Use .prop() for value attribute of list item [core] - 10https://gerrit.wikimedia.org/r/135160 (owner: 10Krinkle) [04:01:23] (03Merged) 10jenkins-bot: mediawiki.test.js: Suppress false postives for deprecated mw.* properties [core] - 10https://gerrit.wikimedia.org/r/135161 (owner: 10Krinkle) [04:06:33] 3MediaWiki / 3Special pages: New page Special:Userinfo - 10https://bugzilla.wikimedia.org/22516#c18 (10PiRSquared17) I think most of the dependencies are not relevant to this bug, except for bug 63988, which I see as a duplicate. The description of this bug is "New page Special:Userinfo". How is that differe... [04:19:55] (03PS1) 10Jackmcbarn: Check category-move-redirect-override in content language [core] - 10https://gerrit.wikimedia.org/r/135178 [04:52:03] 3Analytics / 3Kraken: Hive queries inconsistently failing - 10https://bugzilla.wikimedia.org/65420#c22 (10Andrew Otto) Not really, we just discussed a bit. I hadn't looked into it because I was waiting for your query to fail! I don't think that client side stuff is causing problem for your currently running... [04:58:29] (03CR) 10Parent5446: "OK, I do not think this architecture is entirely sane, because I think it is mixing the logic of the implementation of the configuration b" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [05:03:47] (03CR) 10Parent5446: [C: 032] Check category-move-redirect-override in content language [core] - 10https://gerrit.wikimedia.org/r/135178 (owner: 10Jackmcbarn) [05:04:06] (03PS1) 10Gerrit Patch Uploader: Move MoodBar preference to "Appearance" tab [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/135179 (https://bugzilla.wikimedia.org/65018) [05:04:11] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/135179 (https://bugzilla.wikimedia.org/65018) (owner: 10Gerrit Patch Uploader) [05:06:49] (03Merged) 10jenkins-bot: Check category-move-redirect-override in content language [core] - 10https://gerrit.wikimedia.org/r/135178 (owner: 10Jackmcbarn) [05:12:04] 3Analytics / 3Kraken: Hive queries inconsistently failing - 10https://bugzilla.wikimedia.org/65420#c23 (10Oliver Keyes) I think failing is what it may be doing. So, I set two queries to run, one small (hunting out a single count(*)) and one large (hunting out 5m rows) on cron jobs. The large one died, and it... [05:22:15] (03PS2) 10IAlex: Correct a comment about updateRevisionOn [core] - 10https://gerrit.wikimedia.org/r/134575 (owner: 10Adamw) [05:22:22] (03CR) 10IAlex: [C: 032] Correct a comment about updateRevisionOn [core] - 10https://gerrit.wikimedia.org/r/134575 (owner: 10Adamw) [05:22:40] (03PS6) 10IAlex: Correct field used to detect incomplete POST [core] - 10https://gerrit.wikimedia.org/r/134047 (owner: 10Adamw) [05:23:43] (03PS7) 10IAlex: (bug 56849) Deprecate dangerous edittime-based content update functions [core] - 10https://gerrit.wikimedia.org/r/134049 (owner: 10Adamw) [05:29:18] (03Merged) 10jenkins-bot: Correct a comment about updateRevisionOn [core] - 10https://gerrit.wikimedia.org/r/134575 (owner: 10Adamw) [05:32:44] (03PS1) 10IAlex: Remove not-working scripts in maintenance/language [core] - 10https://gerrit.wikimedia.org/r/135182 [05:32:52] (03CR) 10Parent5446: "Look at maintenance/migrateUserGroup.php (the MigrateUserGroups script). It performs a similar task to this script, but rather than callin" [core] - 10https://gerrit.wikimedia.org/r/135077 (owner: 10Withoutaname) [05:33:51] (03CR) 10Adamw: "@daniel: Yes, the self-conflict check is on EditPage.php, line 1816. I do remove it in the next patch (https://gerrit.wikimedia.org/r/#/c" [core] - 10https://gerrit.wikimedia.org/r/134049 (owner: 10Adamw) [05:34:48] (03CR) 10Parent5446: Make constructor of Block accept array of options (031 comment) [core] - 10https://gerrit.wikimedia.org/r/134827 (owner: 10Matěj Grabovský) [05:41:13] (03PS18) 10Adamw: WIP (bug 56849) Pass true oldid for atomic page save [core] - 10https://gerrit.wikimedia.org/r/94584 [05:42:34] (03CR) 10jenkins-bot: [V: 04-1] WIP (bug 56849) Pass true oldid for atomic page save [core] - 10https://gerrit.wikimedia.org/r/94584 (owner: 10Adamw) [05:47:02] (03PS1) 10IAlex: Don't use isset() to check for null [core] - 10https://gerrit.wikimedia.org/r/135184 [07:08:35] 3Wikimedia / 3Bugzilla: Clicking on (take) in the "Assigned to" field should set the status to Assigned - 10https://bugzilla.wikimedia.org/65719 (10Tisza Gergő) 3NEW p:3Unprio s:3normal a:3None It is easy to assign a bug the myself but accidentally leave it as New, in which case it won't show up in t... [07:37:38] (03CR) 10Umherirrender: "I am not sure, but jQuery.client is an own module, so this need a new dependency in Resoure.php to load it, when it is not already loaded." [core] - 10https://gerrit.wikimedia.org/r/135153 (owner: 10Jforrester) [07:44:28] (03CR) 10Legoktm: "This is in a qunit test, which already has the dependency specified." [core] - 10https://gerrit.wikimedia.org/r/135153 (owner: 10Jforrester) [07:56:18] (03PS11) 10Gerrit Patch Uploader: Show deprecation notices when accessing wg* JavaScript globals [core] - 10https://gerrit.wikimedia.org/r/133162 (https://bugzilla.wikimedia.org/56550) [07:56:20] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/133162 (https://bugzilla.wikimedia.org/56550) (owner: 10Gerrit Patch Uploader) [07:57:38] (03CR) 10jenkins-bot: [V: 04-1] Show deprecation notices when accessing wg* JavaScript globals [core] - 10https://gerrit.wikimedia.org/r/133162 (https://bugzilla.wikimedia.org/56550) (owner: 10Gerrit Patch Uploader) [08:01:28] (03PS1) 10devunt: Clarify 'target' label on the Special:Log options. [core] - 10https://gerrit.wikimedia.org/r/135186 (https://bugzilla.wikimedia.org/46494) [08:05:24] (03PS12) 10Gerrit Patch Uploader: Show deprecation notices when accessing wg* JavaScript globals [core] - 10https://gerrit.wikimedia.org/r/133162 (https://bugzilla.wikimedia.org/56550) [08:05:26] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/133162 (https://bugzilla.wikimedia.org/56550) (owner: 10Gerrit Patch Uploader) [08:06:37] (03CR) 10jenkins-bot: [V: 04-1] Show deprecation notices when accessing wg* JavaScript globals [core] - 10https://gerrit.wikimedia.org/r/133162 (https://bugzilla.wikimedia.org/56550) (owner: 10Gerrit Patch Uploader) [08:08:31] (03CR) 10Umherirrender: "Ah, I have only looked at 'jquery.autoEllipsis', not seen that this is a test for that module." [core] - 10https://gerrit.wikimedia.org/r/135153 (owner: 10Jforrester) [08:12:40] (03CR) 10Nikerabbit: [C: 032] Remove not-working scripts in maintenance/language [core] - 10https://gerrit.wikimedia.org/r/135182 (owner: 10IAlex) [08:13:20] (03CR) 10Umherirrender: "For log types which are part of the "typesOnUser" array there is no need to specifiy the user namespace (At the moment: block, newusers an" [core] - 10https://gerrit.wikimedia.org/r/135186 (https://bugzilla.wikimedia.org/46494) (owner: 10devunt) [08:15:45] (03Merged) 10jenkins-bot: Remove not-working scripts in maintenance/language [core] - 10https://gerrit.wikimedia.org/r/135182 (owner: 10IAlex) [08:19:32] (03PS5) 10Umherirrender: HTMLSelectOtherFields: Have 'other' always as first element [core] - 10https://gerrit.wikimedia.org/r/125209 [08:29:20] 3MediaWiki extensions / 3BetaFeatures: Fatal hook error on first run - 10https://bugzilla.wikimedia.org/65720 (10Ian Kelling) 3UNC p:3Unprio s:3normal a:3None Upon loading a page, I get this error after turning on some debug options. Catchable fatal error: Argument 3 passed to BetaFeaturesHooks::get... [08:30:03] 3MediaWiki extensions / 3BetaFeatures: Fatal hook error on first run - 10https://bugzilla.wikimedia.org/65720 (10Ian Kelling) s:5normal>3critic [08:30:33] 3MediaWiki extensions / 3BetaFeatures: Fatal hook error on first run - 10https://bugzilla.wikimedia.org/65720 (10Ian Kelling) [08:31:05] 3MediaWiki extensions / 3BetaFeatures: Fatal hook error on first run - 10https://bugzilla.wikimedia.org/65720 (10Ian Kelling) [08:31:18] 3MediaWiki extensions / 3BetaFeatures: Fatal hook error on first run - 10https://bugzilla.wikimedia.org/65720 (10Ian Kelling) [08:34:11] (03CR) 10Nikerabbit: "https://www.mediawiki.org/wiki/Security_for_developers#Register_globals is not yet marked as obsolete." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/135087 (https://bugzilla.wikimedia.org/65680) (owner: 10Gergő Tisza) [08:41:51] (03PS1) 10Prtksxna: renderer: Ignore links meant for JavaScript [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135188 (https://bugzilla.wikimedia.org/65425) [08:42:33] 3MediaWiki extensions / 3Popups: Do not make requests when hovering over WikiEditor's toolbar links - 10https://bugzilla.wikimedia.org/65443#c3 (10Prateek Saxena) 5UNC>3PAT Not sure why I am unable to recreate this :( Anyway, this patch - https://gerrit.wikimedia.org/r/135188 - should solve it :) [08:47:14] (03PS1) 10Ian Kelling: Revert hook change REL1_23 is not ready for [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/135189 [08:47:16] (03CR) 10jenkins-bot: [V: 04-1] Revert hook change REL1_23 is not ready for [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/135189 (owner: 10Ian Kelling) [08:52:48] 3MediaWiki extensions / 3Popups: Popups: "mw.Api error: " "http" {xhr: Object, textStatus: "abort", exception: "abort"} - 10https://bugzilla.wikimedia.org/65442#c3 (10Prateek Saxena) Helder, are these being generated on links that shouldn't have Hovercards to begin with. If no, lets mark this invalid. If yes... [09:01:30] (03PS1) 10Hiong3-eng5: SpecialPage Needs Translation [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/135191 (https://bugzilla.wikimedia.org/56220) [09:01:48] 3MediaWiki extensions / 3VectorBeta: [VectorBeta] Fixed header : header under some part of ACE - 10https://bugzilla.wikimedia.org/65712#c2 (10Ltrlg) I’ve activated it on my private test wiki. It is not a “beta” but a “beta features”, I wrote “beta” too fast. I thought you could miss this problem (ACE is prob... [09:05:00] (03PS2) 10devunt: Add "Show changes against previous revision" button [core] - 10https://gerrit.wikimedia.org/r/135165 (https://bugzilla.wikimedia.org/35067) [09:06:24] (03PS2) 10devunt: Add 'X-Robots-Tag: noindex' header in action=render pages [core] - 10https://gerrit.wikimedia.org/r/134996 (https://bugzilla.wikimedia.org/63891) [09:13:56] (03PS2) 10Ian Kelling: Revert hook change REL1_23 is not ready for [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/135189 [09:22:34] (03CR) 10Paladox: "hi I am not the maintainer I just copied from git hub from a project for mediawiki. and the person was planning on bringing it to git but " [extensions/ExtensionStatus] - 10https://gerrit.wikimedia.org/r/135068 (owner: 10Paladox) [09:30:35] (03PS1) 10Raimond Spekking: Consistency tweask in prepararion for adding extension to translatewiki.net [extensions/IframePage] - 10https://gerrit.wikimedia.org/r/135192 [09:38:37] (03PS4) 10Matěj Grabovský: Make constructor of Block accept array of options [core] - 10https://gerrit.wikimedia.org/r/134827 [09:40:01] (03CR) 10Nikerabbit: Dictionary: Json file dictionary backend (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/134617 (owner: 10Santhosh) [10:05:00] (03CR) 10TTO: "I don't really think we need an unmaintained, outdated extension being added to Git. Unless someone is volunteering to maintain this exten" [extensions/ExtensionStatus] - 10https://gerrit.wikimedia.org/r/135068 (owner: 10Paladox) [10:07:20] (03PS3) 10Ian Kelling: Revert hook change REL1_23 is not ready for [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/135189 [10:13:18] 3MediaWiki extensions / 3WikidataRepo: Install default gadgets from wikidata.org on the test system (beta) - 10https://bugzilla.wikimedia.org/64998#c2 (10Bene*) I have created http://wikidata.beta.wmflabs.org/wiki/MediaWiki:Common.js which imports the three gadgets. Is this needed anywhere else, too? [10:19:26] (03CR) 10Gergő Tisza: "Thanks for pointing that out, I didn't think of it!" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/135087 (https://bugzilla.wikimedia.org/65680) (owner: 10Gergő Tisza) [10:23:12] (03CR) 10Gergő Tisza: "Whether that's a *good* justification is a different matter :) Maybe it would be better to just change the module loading order instead, o" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/135087 (https://bugzilla.wikimedia.org/65680) (owner: 10Gergő Tisza) [10:23:48] 3MediaWiki extensions / 3WikidataRepo: Implement wbsetredirect API module - 10https://bugzilla.wikimedia.org/65584#c1 (10Bene*) Question: I thought an item can only become a redirect after merging? I think the best behaviour to resotre deleted pages as redirects is to restore them and then turn them into red... [10:25:11] (03CR) 10Paladox: "oh ok but the project I am adding this too only has 2 files and they .gitreview and .gitignor files. and plus this works for older mediawi" [extensions/ExtensionStatus] - 10https://gerrit.wikimedia.org/r/135068 (owner: 10Paladox) [10:57:13] (03PS1) 10devunt: Validates wgArticlePath does start with slash (/). [core] - 10https://gerrit.wikimedia.org/r/135196 (https://bugzilla.wikimedia.org/46998) [10:57:53] (03PS2) 10devunt: Validates $wgArticlePath does start with slash (/). [core] - 10https://gerrit.wikimedia.org/r/135196 (https://bugzilla.wikimedia.org/46998) [10:58:29] (03PS5) 10Ricordisamoa: new mediawiki.api.user module [core] - 10https://gerrit.wikimedia.org/r/131326 [11:00:03] (03CR) 10Ricordisamoa: new mediawiki.api.user module (031 comment) [core] - 10https://gerrit.wikimedia.org/r/131326 (owner: 10Ricordisamoa) [11:10:04] (03CR) 10Umherirrender: "Please revert or fix before deployment, this leads to type your password into the search box, when tabing from the username to password fi" [core] - 10https://gerrit.wikimedia.org/r/134801 (https://bugzilla.wikimedia.org/29199) (owner: 10Alex Monk) [11:24:18] 3MediaWiki / 3Skin and page rendering: Tab index sorting doesn't make sense - 10https://bugzilla.wikimedia.org/29199#c25 (10Jesús Martínez Novo (Ciencia Al Poder)) Gerrit change 134801 doesn't seem to be a proper fix. As I said in bug 46336 comment 3, the tabindex was set automatically (with JavaScript) det... [11:28:42] (03PS1) 10Umherirrender: Add dynamic maxlength to Special:RevisionDelete [core] - 10https://gerrit.wikimedia.org/r/135197 (https://bugzilla.wikimedia.org/34467) [11:29:34] 3MediaWiki / 3Revision deletion: Allow longer comments in RevDelete - 10https://bugzilla.wikimedia.org/34467 (10Umherirrender) a:3Umherirrender [11:32:03] (03CR) 10jenkins-bot: [V: 04-1] Add dynamic maxlength to Special:RevisionDelete [core] - 10https://gerrit.wikimedia.org/r/135197 (https://bugzilla.wikimedia.org/34467) (owner: 10Umherirrender) [11:33:48] (03PS2) 10Umherirrender: Add dynamic maxlength to Special:RevisionDelete [core] - 10https://gerrit.wikimedia.org/r/135197 (https://bugzilla.wikimedia.org/34467) [11:34:35] (03CR) 10Umherirrender: "Patch Set 2: Fixed js code style" [core] - 10https://gerrit.wikimedia.org/r/135197 (https://bugzilla.wikimedia.org/34467) (owner: 10Umherirrender) [11:46:50] 3MediaWiki extensions / 3CirrusSearch: Special:Search page content is bolded - 10https://bugzilla.wikimedia.org/65721 (10Peter Bowman) 3UNC p:3Unprio s:3normal a:3None Created attachment 15471 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15471&action=edit pl.wikisource.org on IE 11 After a... [12:18:25] (03CR) 10Helder.wiki: [C: 031] "I didn't test it, but I believe this will works." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135188 (https://bugzilla.wikimedia.org/65425) (owner: 10Prtksxna) [12:27:58] (03PS1) 10Raimond Spekking: Add message documentation in preparation for adding extension to translatewki.net [extensions/IfTemplates] - 10https://gerrit.wikimedia.org/r/135198 [12:48:33] 3MediaWiki / 3Skin and page rendering: Tab index sorting doesn't make sense - 10https://bugzilla.wikimedia.org/29199#c26 (10Nemo) Created attachment 15472 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15472&action=edit ack-grep "'tabindex' =" in whole gerrit Would tabindex 0 work? Only a special pa... [12:48:33] 3Wikimedia / 3Bugzilla: Clicking on (take) in the "Assigned to" field should set the status to Assigned - 10https://bugzilla.wikimedia.org/65719#c1 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc Upstream. Assignee is meant to work on a ticket. At some point / some time. ASSIGNED status means trad... [12:48:48] 3MediaWiki / 3Skin and page rendering: Tab index sorting doesn't make sense - 10https://bugzilla.wikimedia.org/29199 (10Nemo) 5PAT>3NEW [12:52:18] 3MediaWiki / 3Documentation: Duplicates in /docs/hooks.txt - 10https://bugzilla.wikimedia.org/65690 (10Andre Klapper) p:5Unprio>3Low [12:52:48] 3MediaWiki extensions / 3Scribunto: Fatal error: Class undefined: LuaSandbox - 10https://bugzilla.wikimedia.org/65711 (10Andre Klapper) p:5Unprio>3Normal [12:54:03] 3MediaWiki extensions / 3Contest: Explore usefulness of yalign, a sentence aligner for comparable corpora - 10https://bugzilla.wikimedia.org/65669 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [12:56:33] 3MediaWiki / 3Page editing: Apostrophe (single quote) in internal links is percent-escaped unnecessarily (and against the standards) - 10https://bugzilla.wikimedia.org/65678 (10Andre Klapper) p:5Unprio>3Low [12:56:33] 3MediaWiki extensions / 3MassMessage: Tab index on Special:MassMessage broken - 10https://bugzilla.wikimedia.org/65663 (10Andre Klapper) [12:56:33] 3MediaWiki / 3Skin and page rendering: Tab index sorting doesn't make sense - 10https://bugzilla.wikimedia.org/29199 (10Andre Klapper) [13:00:03] 3MediaWiki / 3Skin and page rendering: Tab index sorting doesn't make sense - 10https://bugzilla.wikimedia.org/29199#c27 (10Jesús Martínez Novo (Ciencia Al Poder)) (In reply to Nemo from comment #26) > Would tabindex 0 work? Only a special page in WikipediaZero seems to be > using it. Nope. tabindex=0 is us... [13:46:56] (03PS2) 10Prtksxna: renderer: Ignore links meant for JavaScript [extensions/Popups] - 10https://gerrit.wikimedia.org/r/135188 (https://bugzilla.wikimedia.org/65425) [13:53:03] 3MediaWiki extensions / 3CirrusSearch: Special:Search page content is bolded - 10https://bugzilla.wikimedia.org/65721#c1 (10Nik Everett) 5UNC>3NEW Confirmed. Looks like a problem with the create new page template in Polish. [14:09:19] my extension is starting to be working-ish [14:10:29] (03PS1) 10Jack Phoenix: * Removed some unused variables * Fixed search form to use MediaWiki's built-in Special:Search instead of wikiHow's custom Lucene-based LSearch * Added id="searchInput" to the search field so that search suggestions work [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/135201 [14:10:58] (03CR) 10Jack Phoenix: [C: 032 V: 032] * Removed some unused variables * Fixed search form to use MediaWiki's built-in Special:Search instead of wikiHow's custom Lucene-based LSea [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/135201 (owner: 10Jack Phoenix) [14:12:18] 3MediaWiki extensions / 3Popups: Popups: "mw.Api error: " "http" {xhr: Object, textStatus: "abort", exception: "abort"} - 10https://bugzilla.wikimedia.org/65442#c4 (10Helder) 5NEW>3RES/FIX I'm not seeing these anymore. But I do find one more link which should probably not have Popups: the cancel link be... [14:13:40] (03PS1) 10Jack Phoenix: s/NS_IMAGE/NS_FILE/g [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/135202 [14:14:44] (03CR) 10Jack Phoenix: [C: 032 V: 032] s/NS_IMAGE/NS_FILE/g [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/135202 (owner: 10Jack Phoenix) [14:18:22] (03PS1) 10Jack Phoenix: Removed some dirty, site-specific hacks. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/135203 [14:18:47] (03CR) 10Jack Phoenix: [C: 032 V: 032] Removed some dirty, site-specific hacks. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/135203 (owner: 10Jack Phoenix) [14:21:59] ok, it seems to manage to do the the preprocessing right the first time, but the second time it screws up [14:23:20] http://pastie.org/private/idk0wcd4sq7blnyf0xmhia output of the thing, http://pastie.org/private/92eyzigngpwfrxzjxa9weq my extension so far [14:29:18] 3MediaWiki / 3User login and signup: Tab from Username no longer sends user to Password field, but instead to Search box - 10https://bugzilla.wikimedia.org/65704#c3 (10Umherirrender) s:5normal>3blocke Marking a blocker, because this can leaks a password into the search field when using the same workflow... [14:30:48] 3MediaWiki extensions / 3CirrusSearch: Special:Search page content is bolded - 10https://bugzilla.wikimedia.org/65721#c2 (10Nik Everett) 5NEW>3RES/FIX This has already been resolved and is currently getting rolled into production. As of now it is one test2 and mediawiki.org: https://test2.wikipedia.org/... [14:34:33] 3Wikimedia / 3General/Unknown: Next wmf deployment (tracking) - 10https://bugzilla.wikimedia.org/38865 (10Bartosz Dziewoński) [14:34:33] 3MediaWiki / 3User login and signup: Tab from Username no longer sends user to Password field, but instead to Search box - 10https://bugzilla.wikimedia.org/65704 (10Bartosz Dziewoński) [14:34:33] 3Wikimedia / 3General/Unknown: Next wmf deployment (tracking) - 10https://bugzilla.wikimedia.org/38865 (10Bartosz Dziewoński) [14:36:50] 3MediaWiki extensions / 3WikidataRepo: Wikidata parses dates incorrectly (in Portuguese) - 10https://bugzilla.wikimedia.org/65722 (10Helder) 3NEW p:3Unprio s:3normal a:3Wikidata bugs I'm trying to insert the date 9/11/1876 (9 november 1876) in a item and the system keeps converting this to 11 septemb... [14:39:48] 3MediaWiki extensions / 3WikidataRepo: Wikidata parses dates incorrectly (in Portuguese) - 10https://bugzilla.wikimedia.org/65722#c1 (10Helder) Created attachment 15473 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15473&action=edit Screenshot on Q16491750 [14:54:43] (03PS1) 10Mattflaschen: Revert "Restore search box tabindex" [core] - 10https://gerrit.wikimedia.org/r/135205 (https://bugzilla.wikimedia.org/29199) [14:59:36] (03PS2) 10Mattflaschen: Revert "Restore search box tabindex" [core] - 10https://gerrit.wikimedia.org/r/135205 (https://bugzilla.wikimedia.org/29199) [15:00:31] superm401: "Bug:" needs to be just before "Change-Id:" [15:00:43] superm401: otherwise the gerrit-bugzilla notifications will not pick it up [15:00:49] Thanks, MatmaRex, will fix. [15:00:52] (do it and i'll +2 :P) [15:01:24] (03PS3) 10Mattflaschen: Revert "Restore search box tabindex" [core] - 10https://gerrit.wikimedia.org/r/135205 (https://bugzilla.wikimedia.org/29199) [15:01:54] (03CR) 10Bartosz Dziewoński: [C: 032] Revert "Restore search box tabindex" [core] - 10https://gerrit.wikimedia.org/r/135205 (https://bugzilla.wikimedia.org/29199) (owner: 10Mattflaschen) [15:02:27] superm401: this needs a wmf backport, right? [15:02:42] huh, it passes an array the second time around? [15:03:01] MatmaRex, yes, it's on 1.24wmf6. [15:03:08] (The original tabindex 1 commit) [15:03:19] mhm. [15:05:20] 3MediaWiki extensions / 3Translate: Allow in-page translation for typo fixes etc. - 10https://bugzilla.wikimedia.org/65723 (10Rainer Rillke @commons.wikimedia) 3NEW p:3Unprio s:3enhanc a:3None Current situation: -------------------------------------------- The current translation UX is nice for profe... [15:06:04] (03Merged) 10jenkins-bot: Revert "Restore search box tabindex" [core] - 10https://gerrit.wikimedia.org/r/135205 (https://bugzilla.wikimedia.org/29199) (owner: 10Mattflaschen) [15:06:50] MatmaRex, I'll do the cherry-pick. [15:07:05] thanks [15:07:08] (03PS1) 10Mattflaschen: Revert "Restore search box tabindex" [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135208 (https://bugzilla.wikimedia.org/29199) [15:07:40] i've been meaning to do this myself when i saw the bug, but i didn't expect to find anyone active on weekend to help :D [15:08:00] superm401, why is this a revert instead of a fix? [15:08:44] Krenair, because it's a regression that's already on the deployment branch, and a proper fix might require a little more consideration. [15:08:57] Krenair: revert, then fix [15:09:11] superm401, the 'regression' was a fix for another regression [15:09:14] So this revert is a regression in itself [15:09:20] Krenair, yes, but this one is more serious. [15:09:20] Also it's *really* stupid that some people claim to be relying on a tab order for security. [15:09:37] It's completely normal to expect to tab from username to password. [15:09:47] +1 [15:09:51] We can call users stupid, or we can understand normal people have habits. [15:09:59] Krenair: the search box has an access key IIRC, so the tab index is not so important for it, but it is for other form fields [15:10:01] I actually noticed that problem, and typed my password into search box [15:10:05] I will help review a proper fix as my time allows. [15:10:08] accidentally [15:10:24] huh, were you browsing with HTTPS? [15:10:36] it was on a test wiki, so no [15:10:43] A local test wiki? [15:11:10] after I installed vagrant [15:11:18] ok [15:15:39] (03PS1) 10Jackmcbarn: Check category-move-redirect-override in content language [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/135210 [15:15:54] (03PS1) 10Jackmcbarn: Check category-move-redirect-override in content language [core] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135211 [15:17:12] superm401, guess you'll have to find someone able to merge that wmf cherry-pick [15:17:51] Yeah. ori, you around? [15:19:31] By the way, I have a working fix [15:20:13] Krenair, if it's ready, go ahead and upload it. [15:20:58] wait, why am I getting a LocalFile instead of an actual file path when I call getLocalRefPath? [15:24:52] superm401, meh, trying to avoid bikeshedding over where I should put the code [15:25:05] my current idea is searchSuggest, but that's not 100% appropriate... [15:26:10] (03CR) 10Krinkle: Add dynamic maxlength to Special:RevisionDelete (032 comments) [core] - 10https://gerrit.wikimedia.org/r/135197 (https://bugzilla.wikimedia.org/34467) (owner: 10Umherirrender) [15:28:41] (03PS1) 10Alex Monk: Fix search box tabindex again [core] - 10https://gerrit.wikimedia.org/r/135269 [15:29:21] Krenair, the issue with that is that it's only added if the API is enabled. Granted, that's probably most wikis, but that might be justification for putting it in another module. [15:29:54] mw.searchSuggest is already a pile of poop [15:30:09] "// If the form includes any fallback fulltext search buttons, remove them" [15:30:12] "$searchInput.closest( 'form' ).find( '.mw-fallbackSearchButton' ).remove();" [15:30:15] that's from it as well [15:30:27] i shouldn't have put that there, but i compromised :( [15:30:46] (03PS2) 10Mattflaschen: Fix search box tabindex again [core] - 10https://gerrit.wikimedia.org/r/135269 (https://bugzilla.wikimedia.org/29199) (owner: 10Alex Monk) [15:30:55] superm401, if you have any better suggestions, please feel free to modify the commit. [15:31:15] (03CR) 10Alex Monk: "Fix in I3f29c3d8" [core] - 10https://gerrit.wikimedia.org/r/135205 (https://bugzilla.wikimedia.org/29199) (owner: 10Mattflaschen) [15:32:20] (03CR) 10Alex Monk: "Also, I expect this to be cherry-picked to wmf/1.24wmf6" [core] - 10https://gerrit.wikimedia.org/r/135269 (https://bugzilla.wikimedia.org/29199) (owner: 10Alex Monk) [15:32:25] (03CR) 10Bartosz Dziewoński: "-1, needs moar comments on wtf is this doing there. But also +1, the module already sucks, this can't possibly make it any worse." [core] - 10https://gerrit.wikimedia.org/r/135269 (https://bugzilla.wikimedia.org/29199) (owner: 10Alex Monk) [15:32:31] MatmaRex, does that actually have anything to do with suggestions (I'm thinking whether we should make a 'mediawiki.search' module). [15:32:44] superm401: not really but kinda [15:33:02] superm401: the commit that introduced it has a long, detailed explanation, and an even longer discussion [15:33:10] (blame and see) [15:33:30] (03CR) 10Mattflaschen: [C: 04-1] "Problem is it only runs if wgEnableAPI is true, and this in no way has anything to do with the API." [core] - 10https://gerrit.wikimedia.org/r/135269 (https://bugzilla.wikimedia.org/29199) (owner: 10Alex Monk) [15:34:10] (03CR) 10Alex Monk: "Thanks for volunteering." [core] - 10https://gerrit.wikimedia.org/r/135269 (https://bugzilla.wikimedia.org/29199) (owner: 10Alex Monk) [15:36:59] Krenair, alright, you want me to take over 135269? [15:37:40] I don't really mind who does it [15:45:35] (03CR) 10Krinkle: "A few thoughts, let me know what you think." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/133162 (https://bugzilla.wikimedia.org/56550) (owner: 10Gerrit Patch Uploader) [15:47:08] (03CR) 10Mattflaschen: "3.4 is mentioned only in one place (.travis.yml, but not tox.ini). It seems like a possible oversight." (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/134990 (owner: 10Ori.livneh) [15:49:06] (03CR) 10Krinkle: [C: 04-1] "So then the bug (and relevant fix) would be to try and make that work (fix whatever is causing WikimediaMessages to not overwrite core). F" [core] - 10https://gerrit.wikimedia.org/r/134561 (https://bugzilla.wikimedia.org/65514) (owner: 10Florianschmidtwelzow) [15:49:54] (03CR) 10Mattflaschen: "Also, I think tox.ini should be changed to refer to testenv:py32" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/134990 (owner: 10Ori.livneh) [16:04:51] 3Wikimedia / 3Media storage: Apply Content-encoding: gzip to Tiff files from upload.wikimedia.org - 10https://bugzilla.wikimedia.org/65725 (10Bawolff (Brian Wolff)) 3NEW p:3Unprio s:3normal a:3None Similar to bug 54291. Gzipping tiff files reduced file size by about 20% (In the two random files I tri... [16:06:23] (03CR) 10Krinkle: "Let's give this another shot." (035 comments) [core] - 10https://gerrit.wikimedia.org/r/72844 (owner: 10MarkTraceur) [16:06:32] (03PS6) 10Krinkle: Add mediawiki.api.query and getAndContinue [core] - 10https://gerrit.wikimedia.org/r/72844 (owner: 10MarkTraceur) [16:06:54] (03CR) 10Krinkle: "Be sure to move it to resources/*src*/mediawiki.api." [core] - 10https://gerrit.wikimedia.org/r/72844 (owner: 10MarkTraceur) [16:09:50] (03CR) 10jenkins-bot: [V: 04-1] Add mediawiki.api.query and getAndContinue [core] - 10https://gerrit.wikimedia.org/r/72844 (owner: 10MarkTraceur) [16:31:05] so why /is/ getLocalRefPath() from File (at least, I think it is?) returning a LocalFile? [16:35:13] Is it documented too? [16:35:28] it should be returning string or bool [16:39:38] it's really strange and I miss type safety [16:40:44] It's fairly obvious what's happening in the code [16:40:45] $this->fsFile = $this->repo->getLocalReference( $this->getPath() ); [16:41:04] but it should do a getPath() call anyway [16:42:10] yeah, the public getPath returns a MW URI, which isn't very useful to me for shelling out [16:45:08] What are you trying to do? [16:46:24] (03CR) 10Mattflaschen: [C: 04-1] "Looks good." (036 comments) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/133668 (owner: 10Ori.livneh) [16:46:36] wait why do you think getLocalRefPath() is returning a LocalFile object? that's not what it should be returning [16:46:38] media handling extension, renders thumbnails for a filetype [16:46:45] bawolff: because it is [16:47:10] swfhandler::getImageSize: type: object [16:47:11] swfhandler::getImageSize: path: LocalFile::__set_state(array([...] [16:47:43] that should be a string, and it does get a string when I do an ?action=purge - then I get redirected and it fails horribly [16:48:25] ampharos: are you trying to do a transform when self::TRANSFORM_LATER flag is set? [16:49:02] a what? i've never heard of that flag [16:49:30] i'm basing it off of another extension (because the documentation for writing ImageHandlers is very sparse) [16:50:26] yeah, I know, the docs are non-existent [16:50:34] I should probably write some [16:51:13] If self::TRANSFORM_LATER flag is set, that means the file is being rendered by a different server (e.g. InstantCommons, or 404 thumb handler) [16:52:28] i don't handle that [16:53:18] Ok. In that case $dstPath is set to a MW storage url I believe (I have no idea why its like that, it is counter-intuitive) [16:53:55] i can try switching back to using getPath rather than getLocalRefPath - i think it might do the same [16:54:27] No, those methods do very different things [16:54:54] the extension i based this off of used getPath, but afaik it changed in 1.19? [16:55:50] getPath() should give you a storage path (ie a mwstore:// url), where getLocalRefPath() should download the media to the current server (in cases where the files are stored on different servers then the thumbnail renders are) and give you a file system path to it [16:56:21] yeah, that seems normal [16:56:51] 3MediaWiki extensions / 3WikidataRepo: Call to undefined method Wikibase\EntityContentFactory::newContentFromEntity() in EditEntity.php on line 753 - 10https://bugzilla.wikimedia.org/65726 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs PHP Fatal error: Call to undefined method Wikibase\EntityCon... [16:57:25] just don't know why i get a LocalFIle object instead of a string I expect from getLocalRefPath [16:59:17] Sorry, to clarify, are you talking about the second argument to getImageSize() ? [16:59:24] yes [17:00:12] Oh. I had it in my head we were talking about doTransform() [17:01:09] the first time it gets called, getProps (?) seems to call it and gives it the actual path, then it redirects to a non-purge link, then my functions like getLongDesc and normaliseParams give it a LocalFile instead [17:01:52] the transform breaks because it didn't get the dimensions via getImageSize because it wasn't given the filename in a string, rather a LocalFile [17:03:47] So in doTransform() you are calling $file->getImageSize() ? [17:05:02] * bawolff mutters about this part of our file code being a mess [17:05:29] not even in transforms [17:05:38] just getting the filename description [17:05:48] which doesn't apply any transforms at all [17:06:43] it gets the dimensions for printing and it fails as well - it all fails post-purge, both in transform (because getImageSize is fucking up) and just non-transforming tasks [17:06:57] ampharos: But somewhere along the line do you call something like $file->getImageSize( $file ); ? [17:07:36] $image->getImageSize( $image, $image->getLocalRefPath() ); [17:07:49] that's how its called basically everywhere in the code [17:08:14] ok. The correct calling convention (which is mostly undocumented :( ) is $image->getImageSize( $image->getLocalRefPath() ); [17:08:28] I'm going to change the documentation on that function right now [17:08:45] so should I defuckulate my overriding getImageSize function and change all the references? [17:09:28] sad handlers are very gritty undocumented stuff compared to everything else [17:09:41] The MediaHandler (and subclasses) getImageSize method takes different arguments then the File (and subclasses) getImageSize method [17:09:53] yeah sorry about that, I should really fix it [17:10:32] so what should a Handler do? function getImageSize( $image, $path ) {[...]} is how I do it [17:10:40] and pretty much all the functions take an $image [17:11:21] Methods of the MediaHandler take an image as a first argument. Methods of File (ie $image) do not take a File object as a first argument [17:11:45] yeah, they all take image as their first argument [17:12:05] so yes, image handler should do function getImageSize( $image, $path ) {[...]} [17:12:13] so the way I call $image->getImageSize needs to be changed, right? [17:12:20] sorry, php is not first language (thank god) [17:12:55] however, If you need to get the width or height of an image, you should do $image->getWidth() and $image->getHeight ($image->getImageSize() is also for reloading from source, and is inefficient) [17:13:08] that loads from cache? [17:13:43] yes, $image->getWidth() / $image->getHeight() will load from memcache, and if that's a miss, from db, and if that's a miss from the file [17:15:46] even then, would like to get my calls to getImageSize right [17:15:59] ampharos: In case its helpful, we have https://doc.wikimedia.org/mediawiki-core/master/php/html/classFile.html for docs on the methods that $image will have [17:16:10] yeah, I am reading that [17:16:43] If you do call $image->getImageSize (which you really shouldn't), call it as $image->getImageSize( $image->getLocalRefPath() ); [17:17:28] yeah, doxygen pages are really thrashing around firefox when they load [17:17:40] which will then in file class (File::getImageSize), will become converted to $handler->getImageSize( $image, $image->getLocalRefPath ) [17:17:41] regular "this script is taking a long time" [17:18:21] Hmm, I liked the old version of docygen before they "modernized" the interface better [17:22:36] working better! still broken, I'll have to prod and report back [17:25:09] ampharos: I know the docs are crap in this area, so don't hesitate to ask if you run into problems [17:27:37] OK, after the purge it doesn't seem to do a transform - then I refresh, no purge, and then i think it does... then it throws an exception http://pastie.org/private/qselc7cmpde17h7tnf2p4a [17:30:57] (03CR) 10Jackmcbarn: "I see use cases for this beyond Cite, which are fully compatible with Parsoid's goals, such as extensions that expose random number genera" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99792 (https://bugzilla.wikimedia.org/46815) (owner: 10Anomie) [17:31:12] (03PS1) 10Brian Wolff: Fix docs on File::getImageSize() they were very misleading [core] - 10https://gerrit.wikimedia.org/r/135275 [17:31:51] ampharos: Ok, that's the self::TRANSFORM_LATER flag being set [17:32:07] nice to know i finally managed to get to this part [17:32:22] i fixed the problem of not getting the right dimensions [17:32:30] so how do I handle TRANSFORM_LATER? [17:32:47] something along the lines of [17:32:49] if ( $flags & self::TRANSFORM_LATER ) new ThumbnailImage( $image, $dstUrl, false, $newParams ); [17:33:53] during the transform function at the beginning? [17:34:08] Or if you don't like doing the if statement, you could probably override getTransform instead, but all the media handlers I've seen look at the flag [17:35:08] yes, during the beginning of the transform function. usually immediately after the call to $this->normaliseParams [17:39:05] alright, just added TRANSFORM_LATER right after the normalise [17:40:30] same exception [17:40:35] just the line number changes [17:40:42] because it shifted lines, obviously [17:41:14] (03CR) 10Legoktm: [C: 032 V: 032] Use CheckUserHooks::getClientIPfromXFF when reading XFF header [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/134055 (owner: 10Legoktm) [17:41:53] ampharos: oh sorry, if you directly copying what I pasted, you would actually want to do [17:41:59] if ( $flags & self::TRANSFORM_LATER ) return new ThumbnailImage( $image, $dstUrl, false, $newParams ); [17:42:28] normally i dont do copy-paste programming but this calls for it [17:42:33] (03CR) 10Legoktm: [C: 032 V: 032] "I think it just looks that way since there are a lot of PHP files. This UA parser is much much better than the other one so I think it's w" [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/134056 (owner: 10Legoktm) [17:42:50] ok, no exceptions [17:43:09] rendering doesn't work and the description string is a little bit fucked up but i can see what's going on there [17:43:21] i'll bug you if i have to blame ol' jimbo [17:44:00] the logs do seem to get trunicated [17:45:52] ok, now it never gets called [17:47:03] i've made the doTransform thing do an intrusive echo rather than debug-log, but it doesn't do that [17:49:28] echo doesn't work due to output buffering. if you need quick and dirty debugging, use var_dump() [17:50:05] personally I also find $wgDebugComments = true; to be useful [17:51:35] bawolff: either way, doesn't get called [17:52:33] ampharos: Could be that your browser is caching the page. [17:53:06] bawolff: doesn't seem to - i'll turn off cache, and poke purge some more [17:53:07] If the thumb is already rendered, it will go the the TRANSFORM_LATER code. you can do ?action=purge to kill cached thumbs [17:53:34] yeah, purge doesn't seem to do it either [17:56:05] 3Wikimedia / 3Site requests: Change user groups rights on fa.wikipedia - 10https://bugzilla.wikimedia.org/65728 (10Calak) 3UNC p:3Unprio s:3normal a:3None Hello. Please remove 'move-categorypages' right from 'user' group and grant it to 'bot' and 'patroller' user groups on Persian wikipedia. Thank you. [17:56:48] 3Wikimedia / 3Site requests: Change user groups rights on fa.wikipedia - 10https://bugzilla.wikimedia.org/65728 (10Calak) [18:03:40] turning off cache [18:07:30] yeah, no, doesn't even try afaik [18:09:59] ampharos: if you go to thumb.php?f=FileNameHEre.foo&w=200 does it give some sort of error, or return the image, or do something else [18:11:01] "The image at cannot be displayed because it contains errors." [18:11:05] firefox warning [18:11:06] 3Wikimedia / 3Wikidata: New statement not saving - 10https://bugzilla.wikimedia.org/65730 (10daniel.jarratt) 3UNC p:3Unprio s:3normal a:3Wikidata bugs Created attachment 15474 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15474&action=edit Screenshot of the problem When entering a new state... [18:11:07] let me curl [18:11:49] 3Wikimedia / 3Wikidata: New statement not saving - 10https://bugzilla.wikimedia.org/65730 (10daniel.jarratt) [18:12:01] (debian doesn't ship curl out of the box. weird.) [18:12:11] wget ? [18:12:21] got the rror [18:12:28] http://pastie.org/private/dnzndinki97xktdnvce0qw [18:12:44] wait, me being stupid [18:12:54] i didnt escape [18:13:09] nothing outputted [18:14:30] With the error you pasted, I would think that maybe normaliseParams is getting rid of the width parameter [18:16:00] (03PS2) 10Paladox: Add some files from github. [extensions/ExtensionStatus] - 10https://gerrit.wikimedia.org/r/135068 [18:17:50] (03CR) 10Paladox: [C: 031] "hi I have compied some new files that may fix the issue for newer version of mediawiki I have copied the new files from a user who is awai" [extensions/ExtensionStatus] - 10https://gerrit.wikimedia.org/r/135068 (owner: 10Paladox) [18:17:58] bawolff: no, it was the shell being retarded [18:18:04] i get no output after I wrap in quotes [18:18:10] calvin@piure:~$ curl "http://192.168.76.128/mediawiki/thumb.php?f=176.swf&w=100"calvin@piure:~$ [18:19:54] sounds like a fatal [18:20:03] (03PS1) 10Jackmcbarn: Allow specifying a separator for CASCADINGSOURCES [core] - 10https://gerrit.wikimedia.org/r/135276 [18:20:24] ampharos: enable php error reporting [18:20:37] where so? most debug options are on in LocalSettings [18:20:47] (03CR) 10Jackmcbarn: "See Ica900747b932ee072e0f567559be2fa6bd974d7c for changing the separator." [core] - 10https://gerrit.wikimedia.org/r/104999 (owner: 10Jackmcbarn) [18:21:31] wait, bawolff it's on your line [18:21:36] i checks errors.log [18:21:39] newParams isn't defined [18:22:06] hmm, this is what I get from copy and pasting advice from other extensions :) [18:22:41] mediawiki turns me into a blathering php-using idiot ;( [18:23:13] ampharos: so yeah, change $newParams into whatever variable the list of scalar params are in [18:23:58] from function params? like function doTransform([...], $params? [18:26:27] yeah [18:27:14] no more error, still doesn't seem to be doing anything [18:27:31] Hi, I am using this query {{#ask:[/[/Category:Reviews]][/[/Item::{{FULLPAGENAME}}]]|?Rating|format=average}} and getting all results instead of average... any suggestions? [18:27:39] Semantic Mediawiki [18:28:22] apexkid1: try at #mediawiki-semanticmediawiki [18:28:28] err [18:28:32] #semanticmediawiki [18:28:39] #semantic-mediawiki on it :) [18:29:16] no response there.. yaron is offline too :( [18:30:48] it still doesn't seem to do anything [18:31:32] the tumb.php call? [18:31:43] thumb [18:33:03] i did become slightly more aggressive on the thing by doing echos [18:33:23] https://www.mediawiki.org/wiki/Manual:How_to_debug [18:35:21] Strict Standards: Declaration of swfhandler::getThumbType() should be compatible with MediaHandler::getThumbType($ext, $mime, $params = NULL) in /usr/share/mediawiki-extensions/base/SwfHandler/swfhandler_body.php on line 260
[18:35:40] mine is function getThumbType( $ext, $mime ) [18:35:54] I'd add $params = null [18:36:00] But that shouldn't break anything [18:36:01] yeah, and ill ignore it] [18:36:24] no more errors after that [18:36:55] http://192.168.76.128/mediawiki/thumb.php?f=176.swf&w=100 still blank in your browser? [18:37:28] yup [18:38:00] ampharos: Is it a 200 status code or a 500 [18:38:12] headers? [18:38:14] yeah [18:38:18] curl -I [18:38:20] 200 OK [18:38:45] Well not a php fatal then [18:39:27] Maybe it thumbnails the file, whatever you're shelling out to is failing and giving a 0 byte file, and thumb.php is simply relaying that [18:39:45] tried running the shell commands manually? [18:39:51] i don't think it's even executed though [18:40:14] right before I shell out I call wfDebug [18:41:16] echo ": Running swfrender: $cmd\n" ; wfDebug( __METHOD__.": Running swfrender: $cmd\n" ); wfProfileIn( 'convert' ); $err = wfShellExec( $cmd1, $retval ); // then more stuff [18:41:16] not getting that far? [18:41:19] i never see any of these [18:41:37] i do know I make it past the TRANSFORM_LATER [18:41:52] ampharos: Is there anything in /var/www/whereever-mediawiki-is-installed/images/thumb/b/b7/176.swf/ [18:42:37] 100px-176.swf.png 120px-176.swf.png [18:42:45] 0-bytes [18:43:13] try deleting those files, and see if next time you run thumb.php if it gets to the wfShellExec line [18:43:18] my newest update of vagrant is missing the vagrant enable-role command. is this like a new thing or did something go horribly wrong? any ideas? [18:43:45] * bawolff also reccomends doing var_dump(": Running swfrender: $cmd") instead of echo, as that works more reliably [18:44:06] there's some lines in between [18:44:12] i can paste the doTransform function if you want [18:45:06] http://pastie.org/private/5aorcem1hueibcrklztsbq bit of debug crap [18:45:21] mvolz: vagrant 1.6 isn't compatible with mw-vagrant, you should use 1.5 [18:45:52] (see https://github.com/mitchellh/vagrant/issues/3775#issuecomment-42979267) [18:47:59] ampharos: hmm, well you have code to remove 0 byte thumbnails in there, so you definitely shouldn't have 0 byte thumbs in /var/www/whereever-mediawiki-is-installed/images/thumb/b/b7/176.swf/ [18:48:57] legoktm: thanks :) [18:49:44] ampharos: line 31-37 look incorrect [18:50:09] yeah, i noticed this too [18:50:11] seems commented out [18:50:33] well line 35 and line 31 aren't, and I think that part would screw things up [18:51:33] I think $dstPath may exist as a 0 byte temporary file even when rendering still needs to happen [18:51:46] So that code would see the temporary file, and return that [18:51:57] i think it works now that I uncommented [18:51:59] I see the image [18:52:16] it is throwing errors like crazy though [18:52:51] if doTransform is called without a TRANSFORM_LATER flag, then it really needs to make the new file. the code should not be checking if $dstPath already exists [18:54:07] so don't even bother checking if it exists? [18:54:19] just skip that if statement entirely? [18:55:57] yep. I believe it will always exist [18:56:27] PleaseStand are you here [18:58:35] Otherwise you could have someone else on your system create $dstPath with different permissions, and possibly cause a security issue [18:58:53] works now! now there's just some minor squiggles regarding output [18:59:07] the description string somehow gets pretty mangled [19:00:12] hmm, wtf who documented getLongDesc in MediaHandler.php [19:00:25] are there newlines being inserted? also git blame yo [19:01:32] Well unfortunately git blame says "Brian Wolff" :S [19:01:35] which is me [19:02:15] are newlines stripped or not? [19:02:26] PHP Fatal error: Cannot access protected property User::$mCoreRights in .../LocalSettings.php on line 249 [19:02:29] annoying change... [19:03:50] (03PS3) 10Umherirrender: Add dynamic maxlength to Special:RevisionDelete [core] - 10https://gerrit.wikimedia.org/r/135197 (https://bugzilla.wikimedia.org/34467) [19:03:55] ampharos: getLongDesc() returns html, so newlines would be collapsed like in html [19:04:19] (03CR) 10Umherirrender: "Patch Set 3: Addressed inline comments" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/135197 (https://bugzilla.wikimedia.org/34467) (owner: 10Umherirrender) [19:04:55] the output ends up like this http://i.imgur.com/j2FTdz6.png [19:05:17] ampharos: ok, that [19:05:31] 's if there's newlines inside the message, which gets parsed like wikitext [19:06:10] So newlines are sensitive in the arguments to wfMessage() [19:06:34] 3MediaWiki extensions / 3ContentTranslation: Explore usefulness of yalign, a sentence aligner for comparable corpora - 10https://bugzilla.wikimedia.org/65669 (10Nemo) [19:07:26] (03CR) 10jenkins-bot: [V: 04-1] Add dynamic maxlength to Special:RevisionDelete [core] - 10https://gerrit.wikimedia.org/r/135197 (https://bugzilla.wikimedia.org/34467) (owner: 10Umherirrender) [19:07:55] https://gerrit.wikimedia.org/r/#/c/68838/1/includes/media/MediaHandler.php <-- seriously wtf [19:09:18] 3MediaWiki extensions / 3ContentTranslation: Explore usefulness of yalign, a sentence aligner for comparable corpora - 10https://bugzilla.wikimedia.org/65669 (10Nemo) s:5enhanc>3normal [19:11:41] (03PS1) 10Brian Wolff: Fix doc comments on get[General](Short|Long)Desc [core] - 10https://gerrit.wikimedia.org/r/135278 [19:12:24] (03PS4) 10Umherirrender: Add dynamic maxlength to Special:RevisionDelete [core] - 10https://gerrit.wikimedia.org/r/135197 (https://bugzilla.wikimedia.org/34467) [19:12:49] (03CR) 10Umherirrender: "Patch Set 4: Fixed syntax, last changes was not saved" [core] - 10https://gerrit.wikimedia.org/r/135197 (https://bugzilla.wikimedia.org/34467) (owner: 10Umherirrender) [19:12:59] was there ever a wfFitBoxWidth? poking around, this is called whenever it wants to render at a different size [19:14:42] yes, it used to be in includes/ImageFunctions.php [19:14:48] but that's gone now [19:15:26] it lives on as MediaHandler::fitBoxWidth [19:18:13] did fix the whitespace, did a trim [19:18:17] whee [19:18:18] http://lists.wikimedia.org/pipermail/wikitech-l/2014-May/076671.html [19:18:46] that's way too much text i've written :( why are things not simple?!?!? [19:18:54] tangenial, nice [19:19:12] is 'tangenial' not a word? [19:19:18] thanks man [19:19:28] hmph, i guess it's not. 'tangential' is. [19:20:09] OH WELL. i can make a single typo in 1100 words. [19:20:11] bawolff: thanks man [19:20:14] :> [19:20:25] ampharos: no problem [19:21:34] tan(genial) [19:21:55] hope the docs can be fixed and more verbosified [19:22:35] if you ask so in talk of the page in question, it might happen :) [19:23:38] there isn't even a page really [19:24:06] there is no greater feeling than closing all those browser tabs full of documentation [19:24:31] (03CR) 10Umherirrender: "The incontentlanguage part of the message sounds like bug 25349 and in my opinion this is also fine with user language, because the messag" [core] - 10https://gerrit.wikimedia.org/r/135197 (https://bugzilla.wikimedia.org/34467) (owner: 10Umherirrender) [19:26:30] and done [19:26:38] https://www.mediawiki.org/wiki/Manual_talk:Developing_extensions#more_information_on_Handlers.3F [19:32:27] In all likelyhood, nobody is going to write it up unless I do it :s [19:40:48] you're the only person with a chainsaw and PHP knowledge [19:41:28] cursed with the knowledge of the result of insanity forged in the greenlandic tundra, you must document it so future generations do not make the same mistakes [19:44:39] (03PS3) 10Thiemo Mättig (WMDE): Well-defined behavior for array values in all Html attributes [core] - 10https://gerrit.wikimedia.org/r/132617 [19:45:49] ampharos: Well not the only, but if nobody has documented it in the last 10 years... [19:46:43] (03CR) 10Thiemo Mättig (WMDE): Well-defined behavior for array values in all Html attributes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/132617 (owner: 10Thiemo Mättig (WMDE)) [19:58:18] (03PS2) 10Reedy: mark method visibleMetadataFields as public [extensions/PagedTiffHandler] (REL1_23) - 10https://gerrit.wikimedia.org/r/127887 (https://bugzilla.wikimedia.org/64224) [19:58:27] (03CR) 10Reedy: [C: 032] mark method visibleMetadataFields as public [extensions/PagedTiffHandler] (REL1_23) - 10https://gerrit.wikimedia.org/r/127887 (https://bugzilla.wikimedia.org/64224) (owner: 10Reedy) [19:58:31] (03Merged) 10jenkins-bot: mark method visibleMetadataFields as public [extensions/PagedTiffHandler] (REL1_23) - 10https://gerrit.wikimedia.org/r/127887 (https://bugzilla.wikimedia.org/64224) (owner: 10Reedy) [20:00:25] (03PS1) 10Brian Wolff: Reduce some code duplication [core] - 10https://gerrit.wikimedia.org/r/135279 [20:02:43] (03PS1) 10Scnd: Declaration of ProofreadPageContent::preloadTransform() must be [extensions/ProofreadPage] (REL1_23) - 10https://gerrit.wikimedia.org/r/135280 (https://bugzilla.wikimedia.org/63958) [20:07:50] (03PS1) 10Thiemo Mättig (WMDE): Fix broken @return documentation [core] - 10https://gerrit.wikimedia.org/r/135282 [20:07:52] (03CR) 10Jackmcbarn: [C: 04-1] Declaration of ProofreadPageContent::preloadTransform() must be (031 comment) [extensions/ProofreadPage] (REL1_23) - 10https://gerrit.wikimedia.org/r/135280 (https://bugzilla.wikimedia.org/63958) (owner: 10Scnd) [20:08:48] 3MediaWiki extensions / 3ProofreadPage: Fatal error: Declaration of ProofreadPageContent::preloadTransform() must be compatible with that of Content::preloadTransform() in ProofreadPageContent.php on line 262 - 10https://bugzilla.wikimedia.org/63958 (10Jackmcbarn) [20:15:18] 3MediaWiki / 3General/Unknown: Provide information about users' rights and editing on user pages - 10https://bugzilla.wikimedia.org/58405#c6 (10WhatamIdoing) 5RES/DUP>3REO I'm re-opening this per discussion at Bug 22516: Bug 22516 is about creating a new, completely separate Special:UserInfo page. Thi... [20:18:48] 3MediaWiki / 3Special pages: New page Special:Userinfo - 10https://bugzilla.wikimedia.org/22516#c19 (10WhatamIdoing) I've re-opened Bug 58405 so that this request can focus on some people's desire for a separate page, rather than a single line of information being displayed on an existing page. [20:42:33] 3MediaWiki / 3User login and signup: Tab from Username no longer sends user to Password field, but instead to Search box - 10https://bugzilla.wikimedia.org/65704#c8 (10Bartosz Dziewoński) 5PAT>3NEW Fixed in master, pending WMF backport. [20:42:33] 3MediaWiki / 3Skin and page rendering: Tab index sorting doesn't make sense - 10https://bugzilla.wikimedia.org/29199 (10Bartosz Dziewoński) [20:42:35] (03PS3) 10Bartosz Dziewoński: Fix search box tabindex again [core] - 10https://gerrit.wikimedia.org/r/135269 (https://bugzilla.wikimedia.org/29199) (owner: 10Alex Monk) [20:49:10] (03Abandoned) 10Bartosz Dziewoński: Add search box to existing "navigation" role [core] - 10https://gerrit.wikimedia.org/r/135057 (https://bugzilla.wikimedia.org/29199) (owner: 10Nemo bis) [20:53:34] PiRSquared: Aha. [20:53:38] Hello. [20:56:18] 3MediaWiki / 3General/Unknown: Provide information about users' rights and editing on user pages - 10https://bugzilla.wikimedia.org/58405#c7 (10MZMcBride) The request here seems to be fairly straightforward: augment the rendered HTML of user and user talk pages with a bit more markup about the user (disclose... [20:58:03] 3MediaWiki extensions / 3MassMessage: Tab index on Special:MassMessage broken - 10https://bugzilla.wikimedia.org/65663#c1 (10Kunal Mehta (Legoktm)) 5NEW>3RES/FIX The core change was reverted (Iaea60834aa8f1564aca50c21ee62ae01f958cc65), so MM is no longer broken. [21:01:04] 3Wikimedia / 3General/Unknown: out of memory for some animated GIF images on Commons - 10https://bugzilla.wikimedia.org/61711#c4 (10Bawolff (Brian Wolff)) (In reply to PRO from comment #3) > Sorry my correction, the limitation is not somehow 12.5MP it is above ~23 MP > (and seems for sure as of 26 MP, depend... [21:01:21] JustBerry: have you ever contributed code to Wikimedia before? [21:01:36] PiRSquared: Nope. [21:02:49] What would you be interested in doing? [21:03:52] (03CR) 10Legoktm: [C: 032] Move MoodBar preference to "Appearance" tab [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/135179 (https://bugzilla.wikimedia.org/65018) (owner: 10Gerrit Patch Uploader) [21:03:54] (03Merged) 10jenkins-bot: Move MoodBar preference to "Appearance" tab [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/135179 (https://bugzilla.wikimedia.org/65018) (owner: 10Gerrit Patch Uploader) [21:05:35] 3MediaWiki extensions / 3MoodBar: Move MoodBar user preference to "Appearance" tab - 10https://bugzilla.wikimedia.org/65018 (10Kunal Mehta (Legoktm)) 5PAT>3RES/FIX a:3PiRSquared17 [21:06:03] ooh, thanks legoktm [21:06:25] np, add me as a reviewer if you have any easy ones like that :P [21:06:51] Is zuul config easy? [21:07:10] er, what are you trying to do? [21:07:26] oh [21:07:33] PiRSquared: I can't deploy zuul changes [21:07:33] see https://gerrit.wikimedia.org/r/#/c/135092/ [21:07:39] oh [21:07:57] (03CR) 10Legoktm: [C: 032] Pass jshint [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/135092 (https://bugzilla.wikimedia.org/61639) (owner: 10Gerrit Patch Uploader) [21:08:04] (03Merged) 10jenkins-bot: Pass jshint [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/135092 (https://bugzilla.wikimedia.org/61639) (owner: 10Gerrit Patch Uploader) [21:08:15] legoktm: I can rebase https://gerrit.wikimedia.org/r/#/c/125762/ if you're interested in preferences reshuffle :) [21:08:29] (03CR) 10Bartosz Dziewoński: "Either I am slow, or you're providing arguments against doing this yourself in the commit message." [core] - 10https://gerrit.wikimedia.org/r/135160 (owner: 10Krinkle) [21:08:42] PiRSquared: why do you always use gerrit patch uploader? [21:09:07] I installed git yesterday with help from legoktm, but I still don't know how to use it [21:09:23] (It would be interesting to briefly document it on the tool's wiki page.) [21:09:40] Nemo_bis: also, it's easy [21:09:41] Ah. But I saw you amending patches, is that done with the tool as well? [21:09:53] yes, you just need to keep the "Change-Id" [21:10:03] Ok. [21:10:14] You can 'amend' changesets in gerrit simply by uploading a new commit with the same change-id [21:10:25] (03CR) 10Legoktm: [C: 031] mwext-TitleBlacklist-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/135093 (https://bugzilla.wikimedia.org/61639) (owner: 10Gerrit Patch Uploader) [21:10:50] PiRSquared, if you need help understand Git things, we can probably help [21:11:10] I think I'll go over the tutorial [21:11:20] What's the difference between git, git-review, and gerrit? [21:11:23] The tutorial worked even for me! [21:11:33] You don't really need to know [21:11:44] git is the actual command line program you use, along with the system [21:11:54] gerrit is the tool running at WMF which is our code review system [21:12:10] git-review is a helper program for git to upload stuff to gerrit. It's not technically required to submit changes from git to gerrit [21:12:15] but it makes things easier [21:14:28] (03CR) 10Bartosz Dziewoński: "Thiemo, would this really cause issues that are worse than the status quo of having the titles cut off sometimes?" [core] - 10https://gerrit.wikimedia.org/r/127358 (owner: 10Bartosz Dziewoński) [21:14:47] i say "status quo" too often. [21:14:58] Need synonims? [21:15:18] "current state" doesn't have the same ring to it ;) [21:15:41] You can inflect the term :P [21:15:45] PiRSquared: have you looked into https://www.mediawiki.org/wiki/Gerrit/Getting_started ? [21:17:20] sob, again a spaces->tabs rebase [21:18:14] PiRSquared, I replied btw ^ [21:18:36] I saw everything so far, reading the page legoktm linked [21:18:42] Nemo_bis: for the i18n json? [21:18:42] ah ok [21:18:53] Nemo_bis: yeah if you could rebase that, it would be awesome [21:19:48] (03PS3) 10Krinkle: jquery.makeCollapsible: Use .prop() for value attribute of list item [core] - 10https://gerrit.wikimedia.org/r/135160 [21:20:09] I wanna cry [21:20:15] (03CR) 10Krinkle: "@Bart: Sorry for the confusion, I said "attribute" where I meant "property" at the end of the first paragraph. Fixed." [core] - 10https://gerrit.wikimedia.org/r/135160 (owner: 10Krinkle) [21:20:59] wth someone renamed "ipaddressorusername", we don't bother fixing keynames [21:23:54] (03CR) 10Bartosz Dziewoński: [C: 032] "Okay." [core] - 10https://gerrit.wikimedia.org/r/135160 (owner: 10Krinkle) [21:26:59] (03PS11) 10Nemo bis: Create "Following changes" (notifications) tab from "watchlist" [core] - 10https://gerrit.wikimedia.org/r/125762 (https://bugzilla.wikimedia.org/63577) (owner: 1001tonythomas) [21:28:04] (03Merged) 10jenkins-bot: jquery.makeCollapsible: Use .prop() for value attribute of list item [core] - 10https://gerrit.wikimedia.org/r/135160 (owner: 10Krinkle) [21:28:31] legoktm: looks ok https://gerrit.wikimedia.org/r/125762 [21:32:42] (03PS5) 10Krinkle: jquery.suggestions: Support caching results to save http requests [core] - 10https://gerrit.wikimedia.org/r/134603 (https://bugzilla.wikimedia.org/65581) [21:32:50] * legoktm looks [21:32:52] (03PS9) 10Krinkle: mediawiki.searchSuggest: Enable result caching [core] - 10https://gerrit.wikimedia.org/r/134542 (https://bugzilla.wikimedia.org/65581) [21:39:30] (03PS12) 10Krinkle: Preferences: Merge Email and Watchlist into new "Following changes" tab [core] - 10https://gerrit.wikimedia.org/r/125762 (https://bugzilla.wikimedia.org/63577) (owner: 1001tonythomas) [21:41:17] for some definition of "new" [21:41:21] (03CR) 10Krinkle: [C: 04-1] "Rephrased commit message to more clearly reflect the change. Overall I'm neutral on this change, but I do think the tab name is confusing." [core] - 10https://gerrit.wikimedia.org/r/125762 (https://bugzilla.wikimedia.org/63577) (owner: 1001tonythomas) [21:46:48] 3Wikimedia / 3General/Unknown: Set up dev.wikimedia.org portal - 10https://bugzilla.wikimedia.org/65074#c5 (10Krinkle) (In reply to Krinkle from comment #0) > * Data and APIs > > Such as: > > * page view counts > * xml dumps > * OAuth? Discovered today that there is such a thing as https://frdata.... [21:48:43] (03PS13) 10Nemo bis: Merge enotif and watchlist prefs into new "Following changes" tab [core] - 10https://gerrit.wikimedia.org/r/125762 (https://bugzilla.wikimedia.org/63577) (owner: 1001tonythomas) [21:51:18] 3Wikimedia / 3General/Unknown: Set up dev.wikimedia.org portal - 10https://bugzilla.wikimedia.org/65074#c6 (10Bawolff (Brian Wolff)) Why not just have dev.wikimedia.org redirect to a page on mediawiki.org. That way people can update it as appropriate easily. >- Where do I find out about the existence of: [... [22:08:41] (03CR) 10Nemo bis: "Btw "Following (tracking) changes" is established terminology in our docs since 2007 at least. https://meta.wikimedia.org/wiki/Help:Tracki" [core] - 10https://gerrit.wikimedia.org/r/125762 (https://bugzilla.wikimedia.org/63577) (owner: 1001tonythomas) [22:20:34] 3MediaWiki extensions / 3WikidataRepo: Uncaught TypeError: Cannot read property 'each' of null - 10https://bugzilla.wikimedia.org/65694#c2 (10Aude) this also happens when saving qualifiers. this has apparently been an issue since we deployed mw1.24-wmf2 (checked with 1.24wmf2 version of core) and does not h... [22:23:05] 3MediaWiki / 3Page editing: Search and replace botches article when using "Replace" - 10https://bugzilla.wikimedia.org/65732 (10kipod) 3NEW p:3Unprio s:3normal a:3None REPRODUCTION INSTRUCTIONS 1) * use google chrome (tested with 34.0.1847.137 m) * open [[Buchberg (Zittau Mountains)]] for editing (... [22:23:33] 3MediaWiki extensions / 3WikiEditor: "Search and replace" for IE does not correctly replace words but changes others - 10https://bugzilla.wikimedia.org/42073 (10kipod) [22:23:33] 3MediaWiki / 3Page editing: Search and replace botches article when using "Replace" - 10https://bugzilla.wikimedia.org/65732 (10kipod) [22:29:03] 3MediaWiki / 3Page editing: Search and replace botches article when using "Replace" - 10https://bugzilla.wikimedia.org/65732#c1 (10kipod) tested with FF (v 22): same behavior. peace. [23:15:52] (03Abandoned) 10Jforrester: Revert hook change REL1_23 is not ready for [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/135189 (owner: 10Ian Kelling) [23:20:03] 3MediaWiki extensions / 3BetaFeatures: Fatal hook error on first run - 10https://bugzilla.wikimedia.org/65720#c3 (10Kunal Mehta (Legoktm)) I1116fd64ea0beac148ee75ea4ec050741fc2c3b7 (the core change) is in 1.23, so it should work... [23:23:03] (03PS1) 10Jackmcbarn: Allow filtering log entries by namespace (API) [core] - 10https://gerrit.wikimedia.org/r/135283 [23:38:38] 3Wikimedia / 3Site requests: Change user groups rights on fa.wikipedia - 10https://bugzilla.wikimedia.org/65728 (10John F. Lewis) 5UNC>3ASS p:5Unprio>3Normal a:3John F. Lewis [23:52:01] (03PS1) 10Jackmcbarn: Allow filtering log entries by namespace (Special) [core] - 10https://gerrit.wikimedia.org/r/135284 [23:58:59] (03PS1) 10AndyRussG: Make TypesafeEnum::setUp() callable repeatedly [extensions/Campaigns] (wip/editorcampaigns) - 10https://gerrit.wikimedia.org/r/135285