[00:03:34] 3Wikimedia / 3Site requests: New England Wikimedians website - 10https://bugzilla.wikimedia.org/64557#c49 (10varnent) As far as web domains goes, there isn't really any consistency at this point with US entities (US-NYC is at nyc.wikimedia.org) - which is partly what we are hoping to address this issue as I... [00:07:02] (03Abandoned) 10Jforrester: Update OOjs UI to v0.1.0-pre (521a9e242b) [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134142 (owner: 10Jforrester) [00:16:07] (03PS1) 10Gergő Tisza: Tweaked timestamp kludge logic in recordUpload2 [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134536 [00:23:19] (03PS12) 10Krinkle: Move Modern and CologneBlue out of core [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [00:23:30] (03CR) 10Krinkle: [C: 031] "Added release notes." [core] - 10https://gerrit.wikimedia.org/r/118345 (owner: 10Jdlrobson) [00:24:29] (03PS1) 10Cscott: Tweak jshint configuration; use strict. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/134539 [00:29:11] (03PS3) 10Cscott: Add Image Metadata to Image Database [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/107562 (owner: 10Mwalker) [00:29:38] (03CR) 10Mwalker: [C: 032] Tweak jshint configuration; use strict. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/134539 (owner: 10Cscott) [00:35:24] (03CR) 10jenkins-bot: [V: 04-1] Add Image Metadata to Image Database [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/107562 (owner: 10Mwalker) [00:36:32] (03PS4) 10Cscott: Add Image Metadata to Image Database [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/107562 (owner: 10Mwalker) [00:36:34] (03CR) 10Emufarmers: [C: 031] Add "porn" to blacklist [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/134534 (owner: 10Legoktm) [00:38:08] (03CR) 10Mwalker: [C: 031] Add Image Metadata to Image Database [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/107562 (owner: 10Mwalker) [00:40:46] (03Abandoned) 10Cscott: authors.db extraction [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96312 (owner: 10MaxSem) [00:41:01] (03PS4) 10Cscott: Obtain a database of article contributors [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/108033 (owner: 10Mwalker) [00:42:12] (03CR) 10Krinkle: Autocomplete performer field on Special:Log (034 comments) [core] - 10https://gerrit.wikimedia.org/r/110820 (https://bugzilla.wikimedia.org/48241) (owner: 10Alex Monk) [00:42:34] (03PS10) 10Krinkle: Implement autocompletion for Performer field on Special:Log [core] - 10https://gerrit.wikimedia.org/r/110820 (https://bugzilla.wikimedia.org/48241) (owner: 10Alex Monk) [00:43:37] (03CR) 10jenkins-bot: [V: 04-1] Obtain a database of article contributors [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/108033 (owner: 10Mwalker) [00:55:49] (03PS11) 10Krinkle: Implement autocompletion for Performer field on Special:Log [core] - 10https://gerrit.wikimedia.org/r/110820 (https://bugzilla.wikimedia.org/48241) (owner: 10Alex Monk) [00:56:24] (03CR) 10Krinkle: Implement autocompletion for Performer field on Special:Log (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110820 (https://bugzilla.wikimedia.org/48241) (owner: 10Alex Monk) [01:02:40] (03PS12) 10Krinkle: Implement autocompletion for Performer field on Special:Log [core] - 10https://gerrit.wikimedia.org/r/110820 (https://bugzilla.wikimedia.org/48241) (owner: 10Alex Monk) [01:07:12] (03PS1) 10Krinkle: mediawiki.searchSuggest: Code clean up [core] - 10https://gerrit.wikimedia.org/r/134541 [01:07:43] (03PS13) 10Krinkle: Implement autocompletion for Performer field on Special:Log [core] - 10https://gerrit.wikimedia.org/r/110820 (https://bugzilla.wikimedia.org/48241) (owner: 10Alex Monk) [01:18:39] (03PS1) 10Krinkle: mediawiki.searchSuggest: Cache results to save http requests [core] - 10https://gerrit.wikimedia.org/r/134542 [01:20:37] (03PS2) 10Krinkle: mediawiki.searchSuggest: Code clean up [core] - 10https://gerrit.wikimedia.org/r/134541 [01:20:45] (03PS2) 10Krinkle: mediawiki.searchSuggest: Cache results to save http requests [core] - 10https://gerrit.wikimedia.org/r/134542 [01:21:13] ori, if I wanted to write something new that reported statistics; would I stream that to ganglia, or somewhere else? [01:21:54] (cscott might have already asked you about this -- we want to instrument the new pdf thing) [01:22:37] (03CR) 10Krinkle: mw.Title: Add new static methods `newFromFileName`, `newFromUserInput` (031 comment) [core] - 10https://gerrit.wikimedia.org/r/131971 (https://bugzilla.wikimedia.org/64912) (owner: 10Rillke) [01:33:32] (03PS2) 10Werdna: Fix indexes for Reference objects. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/133666 [01:33:50] (03CR) 10jenkins-bot: [V: 04-1] Fix indexes for Reference objects. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/133666 (owner: 10Werdna) [01:35:33] 3Wikimedia / 3Site requests: New England Wikimedians website - 10https://bugzilla.wikimedia.org/64557#c50 (10Kevin Rutherford) Also, if you look at our Meta template for user groups, you find many that have been merged into other ones, so just because it exists doesn't mean that we should follow the old ways... [01:36:42] (03CR) 10Krinkle: "In addition to invalid names there's also things we warn for that are an overlapping set of these." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/131971 (https://bugzilla.wikimedia.org/64912) (owner: 10Rillke) [01:41:02] (03CR) 10Werdna: "I have NO idea how this is making tests fail." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/133666 (owner: 10Werdna) [01:42:57] mwalker: to graphite, via statsd [01:45:59] mwalker: var buf = new Buffer( 'collection.render:142|ms' ), sock = dgram.createSocket( 'udp4' ); sock.send( buf, 0, buf.length, 8125, 'stats.eqiad.wmnet', sock.close.bind( sock ) ); [01:46:15] this may be useful: https://gerrit.wikimedia.org/r/#/c/112647/2/lib/mediawiki.Util.js [01:46:34] and this explains what other types of metrics you can send: https://github.com/b/statsd_spec [01:48:29] (03PS3) 10Werdna: Fix indexes for Reference objects. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/133666 [01:57:04] (03CR) 10Ori.livneh: [C: 032] Add "porn" to blacklist [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/134534 (owner: 10Legoktm) [01:57:06] (03Merged) 10jenkins-bot: Add "porn" to blacklist [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/134534 (owner: 10Legoktm) [02:03:18] 3MediaWiki / 3JavaScript: mw.loader (with wgResourceLoaderStorageEnabled) fills up localStorage, preventing writes by other code - 10https://bugzilla.wikimedia.org/65364#c4 (10Matthew Flaschen) For context, testing by Rob and I (my testing was in Firefox) showed that it will still let you write after the sto... [02:04:18] 3MediaWiki / 3JavaScript: mw.loader (with wgResourceLoaderStorageEnab led) fills up localStorage, preventing persistent writes by other code - 10https://bugzilla.wikimedia.org/65364 (10Matthew Flaschen) [02:13:33] 3MediaWiki / 3JavaScript: MediaWikiModuleStore should be limited to a certain size - 10https://bugzilla.wikimedia.org/64721#c2 (10Ori Livneh) (In reply to Ryan Kaldari from comment #1) > Any thoughts on this? This bug makes using Wikipedia very annoying for me. > Surely I can't be the only person that cares... [02:15:19] 3MediaWiki / 3JavaScript: mw.loader (with wgResourceLoaderStorageEnabled) fills up localStorage, preventing persistent writes by other code - 10https://bugzilla.wikimedia.org/65364#c5 (10Ori Livneh) (In reply to Derk-Jan Hartman from comment #3) > @Ori, we should really move this into indexedDB, which has mu... [02:37:35] (03PS1) 10Mattflaschen: Document ArticleUndelete change [core] - 10https://gerrit.wikimedia.org/r/134548 [02:45:03] (03CR) 10Mattflaschen: "When hooks are updated, they need to be documented in doc/hooks.txt and (unfortunately, despite the redundancy) on -wiki (https://www.medi" [core] - 10https://gerrit.wikimedia.org/r/133631 (owner: 10Robmoen) [02:47:11] (03PS5) 10Yurik: Added BeforeHttpsRedirect hook allowing extensions to cancel forceHTTPS [core] - 10https://gerrit.wikimedia.org/r/132952 [02:48:15] (03CR) 10jenkins-bot: [V: 04-1] Added BeforeHttpsRedirect hook allowing extensions to cancel forceHTTPS [core] - 10https://gerrit.wikimedia.org/r/132952 (owner: 10Yurik) [02:53:56] (03PS6) 10Yurik: Added BeforeHttpsRedirect hook allowing extensions to cancel forceHTTPS [core] - 10https://gerrit.wikimedia.org/r/132952 [03:32:28] who can create two gerrit repos pls? [03:39:41] yurikR: http://www.mediawiki.org/wiki/Git/New_repositories/Requests [03:39:56] mutante, already done :) [03:40:13] i don't think the repo creation is automated, is it? [03:40:50] no, currently it seems to be qchris doing a lot of them [03:49:40] (03PS1) 10Ori.livneh: Add .gitreview [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/134552 [03:51:10] (03PS1) 10Ori.livneh: Add .gitreview [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/134553 [03:51:28] yurikR: ^ [03:52:01] ori, thanks, would it be possible to import ZeroRatedMobileAccess code as the seed for both of the repos? [03:52:38] so as to preserve initial hashes - this way we would be able to do refactorings into two directions? [03:52:51] it would have been great if you included that in the request [03:52:58] but yeah, doable [03:53:24] ori, sorry, realized it right after posting :( [03:53:42] i was considering importing it later, but than realized that it would start from non-blank state [03:57:37] ori, are you doing something with it? i cloned both repos and got "warning: remote HEAD refers to nonexistent ref, unable to checkout." [03:58:14] yurikR: the repos are empty right now [03:58:26] (03CR) 10Legoktm: [C: 032 V: 032] Add .gitreview [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/134552 (owner: 10Ori.livneh) [03:58:31] no [03:58:32] (03CR) 10Legoktm: [C: 032 V: 032] Add .gitreview [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/134553 (owner: 10Ori.livneh) [03:58:39] argh. [03:58:46] legoktm, i was hoping to initialize it with the extension/ZeroRatedMobileAccess code [03:58:50] oh :/ [03:59:03] this way i can diverge the existing code base [03:59:07] sorry :< [03:59:19] it's OK; i need to force-push anyway to push the ZeroRatedMobileAccess tree [03:59:33] sorry for the trouble guys :( [03:59:41] yurikR: ZeroBanner should be good to go; try cloning it [04:04:31] ori, awesome with ZeroBanner [04:04:42] yurikR: ZeroPortal too [04:04:56] yurikR: try and confirm? [04:05:58] ori, awesome, thx!!! [04:06:18] you rock, now i hope all those references to "Ixxxxxx" won't confuse gerrit too much [04:06:24] because there are now 3 of each [04:07:16] the same thing happens with cherry-picks, but actually this case is even simpler, since the imported one are not bona-fide gerrit changes [04:07:38] you can easily confirm, just search for the change-id of a past commit [04:07:44] it resolves to ZeroRatedMobileAccess [04:12:29] (03CR) 10Brian Wolff: "Im not sure about this change. Lots of third party wikis in the world that are "internal" or otherwise not caring about copyright." [core] - 10https://gerrit.wikimedia.org/r/134509 (owner: 10SPQRobin) [04:15:31] (03CR) 10Ori.livneh: [C: 031] Make abstract Config class truly implementation-agnostic [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [04:33:19] 3MediaWiki / 3JavaScript: mw.loader (with wgResourceLoaderStorageEnabled) fills up localStorage, preventing persistent writes by other code - 10https://bugzilla.wikimedia.org/65364#c6 (10Matthew Flaschen) > I think this is what the error means exactly. I.E. you can still call the > localStorage API, but it... [04:35:06] (03CR) 10Aaron Schulz: "It would be nice if the repo was in /extensions to avoid changing the branch generation script." [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/119884 (owner: 10Jdlrobson) [04:41:35] 3MediaWiki extensions / 3WikimediaMessages: Missing messages on account creation - 10https://bugzilla.wikimedia.org/65514#c6 (10Matthew Flaschen) (In reply to florian.schmidt.welzow from comment #2) > These messages aren't core messages, so sysops have to set, translate and > edit these themselves. Wikimedi... [04:51:02] (03PS1) 10Foxtrott: Unit testing for components (DO NOT MERGE) [skins/chameleon] - 10https://gerrit.wikimedia.org/r/134556 [04:53:00] (03CR) 10KartikMistry: [C: 031] Add talk link to excontentauthor [core] - 10https://gerrit.wikimedia.org/r/124158 (owner: 10Amire80) [04:53:47] (03PS3) 10Umherirrender: Add error 'pagecannotexist' to ApiBase::getTitleOrPageIdErrorMessage [core] - 10https://gerrit.wikimedia.org/r/134469 [04:59:25] (03PS5) 10Cscott: Fetch article contributors [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/108033 (owner: 10Mwalker) [05:05:56] (03PS4) 10Hiong3-eng5: Special Suggest [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/133879 (https://bugzilla.wikimedia.org/56220) [05:17:27] (03CR) 10Dan-nl: "using bytes & strlen() because https://commons.wikimedia.org/wiki/Commons:File_naming specifically mentions 240 bytes as the limit." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/134073 (https://bugzilla.wikimedia.org/65323) (owner: 10Dan-nl) [05:51:12] (03PS1) 10Florianschmidtwelzow: Remove empty messages and ensure they exists before parse [core] - 10https://gerrit.wikimedia.org/r/134561 (https://bugzilla.wikimedia.org/65514) [05:51:14] (03PS1) 10Skizzerz: (bug 64365) Gracefully fail when getting the default schema if we get a non-standard db type instead of throwing notices. Also add a hook to allow extensions that add non-standard types to configure said default [core] - 10https://gerrit.wikimedia.org/r/134562 [05:54:35] (03PS2) 10Skizzerz: (bug 64365) Gracefully fail when getting the default schema if we get a non-standard db type. [core] - 10https://gerrit.wikimedia.org/r/134562 [05:57:06] (03CR) 10Skizzerz: [C: 04-1] "Just realized I forgot to add in a note on RELEASE-NOTES and the hook documentation file thingie (if that still exists). Will do so in the" [core] - 10https://gerrit.wikimedia.org/r/134562 (owner: 10Skizzerz) [06:07:28] >>> s = 'foo,bar,baz'; a = s.split( ',' ); a; [06:07:29] RoanKattouw: (object) ['foo', 'bar', 'baz'] [06:07:32] Nemo_bis: ---^^ [06:08:04] nice to meet you ecmabot-wm [06:08:07] Thanks Roan [06:08:36] It doesn't have jQuery unfortunately so I can't show you $.grep() [06:09:04] 3MediaWiki extensions / 3WikimediaMessages: Missing messages on account creation - 10https://bugzilla.wikimedia.org/65514#c7 (10florian.schmidt.welzow) Hmm, bot is sleeping?! https://gerrit.wikimedia.org/r/#/c/134561/ [06:09:10] >>> a = 'bar'; [06:09:10] wctaiwan: (string) 'bar' [06:09:19] nifty! [06:17:53] (03PS2) 10Florianschmidtwelzow: Remove empty messages and ensure they exists before parse [core] - 10https://gerrit.wikimedia.org/r/134561 (https://bugzilla.wikimedia.org/65514) [06:36:33] 3Wikimedia / 3SSL related: Explorer does not store history when using https - 10https://bugzilla.wikimedia.org/53681#c3 (10Nemo) So tempted to close this INVALID... [06:46:33] 3Wikimedia / 3SSL related: Links in MediaWiki emails should respect the user's prefershttps preference - 10https://bugzilla.wikimedia.org/39676#c15 (10Nemo) Since bug 29898 was fixed, isn't this an easy MediaWiki bug? We already vary emails based on preferences (particularly language), it's trivial to modify... [07:00:52] (03CR) 10Mwjames: "GREAT ..." [skins/chameleon] - 10https://gerrit.wikimedia.org/r/134556 (owner: 10Foxtrott) [07:38:14] (03PS3) 10Adamw: Minor cleanup of edit code [core] - 10https://gerrit.wikimedia.org/r/134047 [07:51:14] (03CR) 10Legoktm: Show global blocks on Special:Contributions (031 comment) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/133986 (https://bugzilla.wikimedia.org/52673) (owner: 10Gerrit Patch Uploader) [07:54:40] (03PS3) 10Legoktm: Show global blocks on Special:Contributions [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/133986 (https://bugzilla.wikimedia.org/52673) (owner: 10Gerrit Patch Uploader) [07:59:55] (03PS4) 10Adamw: Minor cleanup of edit code [core] - 10https://gerrit.wikimedia.org/r/134047 [08:01:02] (03CR) 10Frédéric Wang: "Yes, we can test it on dev first, but I still don't know exactly what is your "dev" branch and what is in." [extensions/Math] - 10https://gerrit.wikimedia.org/r/134362 (https://bugzilla.wikimedia.org/65532) (owner: 10Frédéric Wang) [08:01:10] (03PS1) 10Adamw: whitespace fixup [core] - 10https://gerrit.wikimedia.org/r/134574 [08:03:21] (03PS1) 10Adamw: Correct a comment about updateRevisionOn [core] - 10https://gerrit.wikimedia.org/r/134575 [08:03:36] (03CR) 10Frédéric Wang: Improve mathtable (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/134326 (https://bugzilla.wikimedia.org/65525) (owner: 10Physikerwelt) [08:08:15] (03PS5) 10Adamw: Correct field used to detect incomplete POST [core] - 10https://gerrit.wikimedia.org/r/134047 [08:11:31] (03PS5) 10Adamw: (bug 56849) Deprecate dangerous edittime-based content update functions [core] - 10https://gerrit.wikimedia.org/r/134049 [08:11:36] (03PS6) 10Adamw: (bug 56849) Deprecate dangerous edittime-based content update functions [core] - 10https://gerrit.wikimedia.org/r/134049 [08:13:58] (03PS5) 10Physikerwelt: Improve mathtable [extensions/Math] - 10https://gerrit.wikimedia.org/r/134326 (https://bugzilla.wikimedia.org/65525) [08:23:35] (03CR) 10Frédéric Wang: [C: 04-1] Improve mathtable (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/134326 (https://bugzilla.wikimedia.org/65525) (owner: 10Physikerwelt) [08:26:19] 3MediaWiki extensions / 3FlaggedRevs: advertise doesn't work - 10https://bugzilla.wikimedia.org/65572#c1 (10Karsten Priegnitz) Hi! when I click on "advertise" this text appears: "Notice: Other reviewers can see that you are reviewing these changes." but: - for other users this changes nothing. Another rev... [08:28:40] (03PS3) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/134068 [08:30:21] (03PS3) 10Gilles: jQuery 1.9 compatibility fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 [08:30:24] (03CR) 10jenkins-bot: [V: 04-1] jQuery 1.9 compatibility fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 (owner: 10Gilles) [08:30:51] 3MediaWiki extensions / 3FlaggedRevs: Setting "Revision displayed on default page view" does not work - 10https://bugzilla.wikimedia.org/65574 (10Karsten Priegnitz) 3UNC p:3Unprio s:3normal a:3None Hi, I use FlaggedRevs REL1_22 Setting the above mentioned option does not have any effect at all. Whe... [08:31:59] (03CR) 10Gilles: jQuery 1.9 compatibility fixes (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 (owner: 10Gilles) [08:32:33] 3MediaWiki extensions / 3FlaggedRevs: Setting "Revision displayed on default page view" does not work - 10https://bugzilla.wikimedia.org/65574 (10Karsten Priegnitz) s:5normal>3major [08:32:56] (03PS4) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/134072 [08:33:41] (03PS4) 10Gilles: jQuery 1.9 compatibility fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 [08:35:36] (03PS2) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/134084 [08:38:17] (03PS2) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/134087 [08:40:32] (03PS16) 10Adamw: WIP (bug 56849) Pass true oldid for atomic page save [core] - 10https://gerrit.wikimedia.org/r/94584 [08:41:03] (03PS2) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/134308 [08:41:31] (03CR) 10Legoktm: Show global blocks on Special:Contributions (033 comments) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/133986 (https://bugzilla.wikimedia.org/52673) (owner: 10Gerrit Patch Uploader) [08:42:10] (03PS7) 10Gergő Tisza: Basic funnel data logging for UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 [08:42:36] (03PS2) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/134309 [08:43:14] (03PS8) 10Gergő Tisza: Basic funnel data logging for UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 [08:43:53] (03CR) 10jenkins-bot: [V: 04-1] WIP (bug 56849) Pass true oldid for atomic page save [core] - 10https://gerrit.wikimedia.org/r/94584 (owner: 10Adamw) [08:43:56] (03CR) 10Gergő Tisza: "Thanks! It was an uppercase/lowercase issue for me as well." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 (owner: 10Gergő Tisza) [08:44:54] (03PS2) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/134310 [08:45:35] (03PS1) 10Hashar: Reset branch based on origin, not local copy [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/134576 [08:46:04] (03PS2) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/134319 [08:47:27] (03PS2) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/134323 [08:47:32] (03CR) 10Hashar: [C: 032] Reset branch based on origin, not local copy [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/134576 (owner: 10Hashar) [08:48:19] (03Merged) 10jenkins-bot: Reset branch based on origin, not local copy [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/134576 (owner: 10Hashar) [08:49:18] (03PS2) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/134330 [08:49:35] (03PS6) 10Physikerwelt: Improve mathtable [extensions/Math] - 10https://gerrit.wikimedia.org/r/134326 (https://bugzilla.wikimedia.org/65525) [08:50:05] (03CR) 10Physikerwelt: Improve mathtable (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/134326 (https://bugzilla.wikimedia.org/65525) (owner: 10Physikerwelt) [08:51:23] (03CR) 10Physikerwelt: "Maybe it makes more sense to wait until the former change is merged..." [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 (owner: 10Physikerwelt) [08:51:37] (03PS17) 10Adamw: WIP (bug 56849) Pass true oldid for atomic page save [core] - 10https://gerrit.wikimedia.org/r/94584 [08:51:40] (03PS2) 10Physikerwelt: Add separate database table for LaTeXML (step 2) [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 [08:52:55] (03CR) 10jenkins-bot: [V: 04-1] WIP (bug 56849) Pass true oldid for atomic page save [core] - 10https://gerrit.wikimedia.org/r/94584 (owner: 10Adamw) [08:53:07] (03CR) 10Frédéric Wang: [C: 032] "OK, thanks." [extensions/Math] - 10https://gerrit.wikimedia.org/r/134326 (https://bugzilla.wikimedia.org/65525) (owner: 10Physikerwelt) [08:55:40] (03CR) 10Nemo bis: "Commit message is improvable, you also made JSON migration in this commit." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/134323 (owner: 10Smuggli) [08:56:22] (03CR) 10Physikerwelt: "Ok." [extensions/Math] - 10https://gerrit.wikimedia.org/r/134362 (https://bugzilla.wikimedia.org/65532) (owner: 10Frédéric Wang) [08:58:51] (03CR) 10Hashar: [C: 032] "Much much better. Thank you very much Bryan and sorry for the speedy self merge yesterday!" (031 comment) [integration/jenkins] - 10https://gerrit.wikimedia.org/r/134385 (owner: 10BryanDavis) [08:59:30] (03PS2) 10Hashar: mw-sort-wmf-branches: simplify implementation [integration/jenkins] - 10https://gerrit.wikimedia.org/r/134385 (owner: 10BryanDavis) [08:59:38] (03CR) 10Hashar: [C: 032] mw-sort-wmf-branches: simplify implementation [integration/jenkins] - 10https://gerrit.wikimedia.org/r/134385 (owner: 10BryanDavis) [08:59:41] (03Merged) 10jenkins-bot: mw-sort-wmf-branches: simplify implementation [integration/jenkins] - 10https://gerrit.wikimedia.org/r/134385 (owner: 10BryanDavis) [09:00:33] 3MediaWiki extensions / 3WikimediaMessages: Missing messages on account creation - 10https://bugzilla.wikimedia.org/65514 (10Andre Klapper) 5NEW>3PAT [09:02:20] 3MediaWiki extensions / 3WikidataRepo: aggregate list of non user-friendly messages on Wikidata - 10https://bugzilla.wikimedia.org/62778 (10tobias.gritschacher) 5REO>3ASS [09:02:32] (03PS9) 10Gergő Tisza: Basic funnel data logging for UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 [09:08:55] (03PS3) 10Legoktm: Remove empty messages and ensure they exists before parse [core] - 10https://gerrit.wikimedia.org/r/134561 (https://bugzilla.wikimedia.org/65514) (owner: 10Florianschmidtwelzow) [09:09:22] (03CR) 10Physikerwelt: [C: 04-1] "ok I think I found a way to split that up into 3 commits" [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 (owner: 10Physikerwelt) [09:12:29] (03PS10) 10Gergő Tisza: Basic funnel data logging for UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 [09:15:00] (03PS1) 10Smuggli: Added new message [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/134578 [09:16:14] (03PS1) 10Smuggli: Added new messages [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/134580 [09:17:22] (03PS1) 10Hashar: Output pep8 version [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134581 [09:17:32] (03CR) 10Hashar: [C: 032] Output pep8 version [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134581 (owner: 10Hashar) [09:17:56] (03Merged) 10jenkins-bot: Output pep8 version [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134581 (owner: 10Hashar) [09:18:36] 3MediaWiki extensions / 3CodeEditor: Make hidden "usecodeeditor" preference visible, and do serve the CodeEditor on the relevant pages if switched on - 10https://bugzilla.wikimedia.org/65575 (10Lupo) 3NEW p:3Unprio s:3normal a:3None Since https://git.wikimedia.org/commit/mediawiki%2Fextensions%2FCode... [09:20:19] 3MediaWiki extensions / 3WikidataRepo: aggregate list of non user-friendly messages on Wikidata - 10https://bugzilla.wikimedia.org/62778 (10tobias.gritschacher) 5ASS>3PAT [09:20:20] 3MediaWiki extensions / 3WikidataRepo: aggregate list of non user-friendly messages on Wikidata - 10https://bugzilla.wikimedia.org/62778#c4 (10tobias.gritschacher) List for lib & client: https://gerrit.wikimedia.org/r/#/c/133715/ [09:22:19] (03CR) 10Gergő Tisza: "QUnit is still failing but I cannot reproduce it locally anymore." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 (owner: 10Gergő Tisza) [09:22:58] (03PS1) 10Hashar: Typo in pep8 builder macro [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134583 [09:23:10] (03CR) 10Hashar: [C: 032] Typo in pep8 builder macro [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134583 (owner: 10Hashar) [09:23:33] 3Analytics / 3EventLogging: Add sampling support in EventLogging - 10https://bugzilla.wikimedia.org/65500#c2 (10nuria) Adding comments posted by ori on e-mail thread: "to do this {sampling] in the schema itself confuses the structure of the data with the mechanics of its use. I think having a couple of help... [09:24:05] (03Merged) 10jenkins-bot: Typo in pep8 builder macro [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134583 (owner: 10Hashar) [09:28:23] (03CR) 10Daniel Kinzler: [C: 032] "Thanks! Ran into this one recently!" [core] - 10https://gerrit.wikimedia.org/r/134344 (https://bugzilla.wikimedia.org/65530) (owner: 10Alexander.lehmann) [09:31:43] (03Merged) 10jenkins-bot: Inserted test whether the resource 'uploadsource' is already registered. Bug: 65530 [core] - 10https://gerrit.wikimedia.org/r/134344 (https://bugzilla.wikimedia.org/65530) (owner: 10Alexander.lehmann) [09:36:03] 3Wikimedia / 3Mailing lists: Create a qa notification list - 10https://bugzilla.wikimedia.org/64610#c4 (10Antoine "hashar" Musso) Hello Tomasz, Sorry we forgot the basic details, here they are: > 1. Who is supposed to be list administrator (please provide at least two addresses)? Both I and Chris: hashar... [09:41:48] (03CR) 10Jdlrobson: [C: 032] Don't log events for anonymous user in CPB (031 comment) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/134331 (owner: 10JGonera) [09:41:59] (03Merged) 10jenkins-bot: Don't log events for anonymous user in CPB [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/134331 (owner: 10JGonera) [09:57:04] (03CR) 10Gilles: "Either by another cosmic coincidence I'm running into an issue with exactly the same test, or the failure is unrelated to our changes: htt" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 (owner: 10Gergő Tisza) [09:58:42] (03PS9) 10Jlloyd: Add notifications for article page changes [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/118101 (https://bugzilla.wikimedia.org/56325) [09:58:57] (03CR) 10jenkins-bot: [V: 04-1] Add notifications for article page changes [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/118101 (https://bugzilla.wikimedia.org/56325) (owner: 10Jlloyd) [09:59:49] (03CR) 10Gilles: "Nevermind, I thought I saw an error in the same test but I must have dreamt it, your last error seems specific to this changeset's code, a" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 (owner: 10Gergő Tisza) [10:04:51] 3MediaWiki extensions / 3VectorBeta: CPB: LQT notifications are missing on mediawiki.org - 10https://bugzilla.wikimedia.org/65577 (10Derk-Jan Hartman) 3NEW p:3Unprio s:3normal a:3None I just today visited my MW.org watch list and it told me I had new messages. I only then realized that the LQT discus... [10:16:49] 3MediaWiki extensions / 3WikidataRepo: API module wbmergeitems fails if exists label and description for a language in the source item - 10https://bugzilla.wikimedia.org/65215#c5 (10JulesWinnfield-hu) Error changed to API ERROR CODE: failed-save VALUE: Item being merged to has conflicting terms: ( => it => B... [10:18:23] (03PS3) 10Physikerwelt: Add separate database table for LaTeXML (step 2) [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 [10:19:25] (03CR) 10jenkins-bot: [V: 04-1] Add separate database table for LaTeXML (step 2) [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 (owner: 10Physikerwelt) [10:20:33] 3MediaWiki extensions / 3WikidataRepo: ChangeOps should have a separate function for validation. - 10https://bugzilla.wikimedia.org/64309#c3 (10JulesWinnfield-hu) Could you take a look at bug 65215? [10:20:48] 3MediaWiki extensions / 3WikidataRepo: API module wbmergeitems fails if exists label and description for a language in the source item - 10https://bugzilla.wikimedia.org/65215 (10JulesWinnfield-hu) [10:23:20] (03PS4) 10Physikerwelt: Add separate database table for LaTeXML (step 2) [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 [10:23:35] 3Wikimedia / 3Git/Gerrit: Gerrit notification bot should complete all changes in one action in Bugzilla - 10https://bugzilla.wikimedia.org/65563#c1 (10christian) 5NEW>3RES/DUP *** This bug has been marked as a duplicate of bug 52167 *** [10:23:36] 3Wikimedia / 3Git/Gerrit: Gerrit Notification Bot sets PATCH_TO_REVIEW in a separate operation from posting a comment - 10https://bugzilla.wikimedia.org/52167#c8 (10christian) *** Bug 65563 has been marked as a duplicate of this bug. *** [10:24:01] (03CR) 10Rillke: "> This method seems to encourage blind use where you give it a value (no matter how bad)" (0312 comments) [core] - 10https://gerrit.wikimedia.org/r/131971 (https://bugzilla.wikimedia.org/64912) (owner: 10Rillke) [10:24:10] (03PS6) 10Rillke: mw.Title: Add new static methods `newFromFileName`, `newFromUserInput` [core] - 10https://gerrit.wikimedia.org/r/131971 (https://bugzilla.wikimedia.org/64912) [10:25:26] (03CR) 10jenkins-bot: [V: 04-1] Add separate database table for LaTeXML (step 2) [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 (owner: 10Physikerwelt) [10:26:31] (03CR) 10jenkins-bot: [V: 04-1] mw.Title: Add new static methods `newFromFileName`, `newFromUserInput` [core] - 10https://gerrit.wikimedia.org/r/131971 (https://bugzilla.wikimedia.org/64912) (owner: 10Rillke) [10:27:30] (03PS5) 10Physikerwelt: Add separate database table for LaTeXML (step 2) [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 [10:28:25] (03CR) 10jenkins-bot: [V: 04-1] Add separate database table for LaTeXML (step 2) [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 (owner: 10Physikerwelt) [10:28:49] (03CR) 10Physikerwelt: "does $this->assertEquals( 6, $this->db->numFields($res), "wrong number of fields" ); this worls for sqlite? The test returns a doubled re" [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 (owner: 10Physikerwelt) [10:31:22] (03PS7) 10Rillke: mw.Title: Add new static methods `newFromFileName`, `newFromUserInput` [core] - 10https://gerrit.wikimedia.org/r/131971 (https://bugzilla.wikimedia.org/64912) [10:32:04] 3MediaWiki extensions / 3Math: Mathtable needs to be simplified - 10https://bugzilla.wikimedia.org/65525 (10physikerwelt) 5PAT>3RES/FIX [10:32:21] (03CR) 10Frédéric Wang: Add separate database table for LaTeXML (step 2) (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 (owner: 10Physikerwelt) [10:33:33] 3MediaWiki extensions / 3Math: Add seperate database tables for LaTeXML - 10https://bugzilla.wikimedia.org/65522#c3 (10physikerwelt) Step 2 creates the LaTeXML defined in step 1. [10:33:39] (03PS6) 10Physikerwelt: Add separate database table for LaTeXML (step 2) [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 (https://bugzilla.wikimedia.org/65522) [10:33:42] (03PS6) 10Withoutaname: Prevent deleteBatch.php deleting files from redirects [core] - 10https://gerrit.wikimedia.org/r/132339 (https://bugzilla.wikimedia.org/52587) [10:34:45] (03CR) 10jenkins-bot: [V: 04-1] Add separate database table for LaTeXML (step 2) [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 (https://bugzilla.wikimedia.org/65522) (owner: 10Physikerwelt) [10:34:51] (03CR) 10Rillke: mw.Title: Add new static methods `newFromFileName`, `newFromUserInput` (031 comment) [core] - 10https://gerrit.wikimedia.org/r/131971 (https://bugzilla.wikimedia.org/64912) (owner: 10Rillke) [10:37:51] 3MediaWiki / 3Database: wrong result for numFileds in sqllite - 10https://bugzilla.wikimedia.org/65578 (10physikerwelt) 3NEW p:3Unprio s:3major a:3None Sqllite uses the size of the result array to count the number of rows. " $r = $res instanceof ResultWrapper ? $res->result : $res; re... [10:38:49] 3MediaWiki extensions / 3Math: Add seperate database tables for LaTeXML - 10https://bugzilla.wikimedia.org/65522 (10physikerwelt) [10:38:51] 3MediaWiki / 3Database: wrong result for numFileds in sqllite - 10https://bugzilla.wikimedia.org/65578 (10physikerwelt) a:3physikerwelt [10:39:04] 3MediaWiki extensions / 3Math: Add separate database tables for LaTeXML - 10https://bugzilla.wikimedia.org/65522 (10Frédéric Wang) [10:57:48] 3MediaWiki / 3Database: wrong result for numFileds in sqlite - 10https://bugzilla.wikimedia.org/65578 (10physikerwelt) [11:02:59] (03PS6) 10Divec: DONTMERGE LinearDoc: Flattened representation of Inline HTML [services/cxserver] - 10https://gerrit.wikimedia.org/r/124287 [11:05:33] 3MediaWiki extensions / 3FlaggedRevs: Setting "Revision displayed on default page view" does not work - 10https://bugzilla.wikimedia.org/65574 (10Andre Klapper) p:5Unprio>3Normal [11:06:33] 3MediaWiki extensions / 3FlaggedRevs: "Advertise" does not tell others that I'm reviewing that page; clicking "de-advertise" does not change display - 10https://bugzilla.wikimedia.org/65572 (10Andre Klapper) p:5Unprio>3Normal [11:07:18] 3MediaWiki extensions / 3CentralAuth: Wikis missing from Special:WikiSets, but included in API output - 10https://bugzilla.wikimedia.org/64642 (10This, that and the other) 5PAT>3RES/FIX [11:08:49] 3Wikimedia / 3Git/Gerrit: Gerrit-Bugzilla bot re-opens bugs when patch is made for branch - 10https://bugzilla.wikimedia.org/53084 (10Andre Klapper) p:5Unprio>3Low [11:09:03] 3Wikimedia / 3Git/Gerrit: Gerrit Notification Bot should print the branch into the Bugzilla comment - 10https://bugzilla.wikimedia.org/60733 (10Andre Klapper) p:5Normal>3Low [11:17:34] (03Abandoned) 10Mwjames: Asserts if a stream wrapper 'uploadsource' already exists [core] - 10https://gerrit.wikimedia.org/r/94351 (owner: 10Mwjames) [11:26:19] 3Wikimedia / 3Mailing lists: Create a qa notification list - 10https://bugzilla.wikimedia.org/64610#c5 (10Tomasz W. Kozlowski) 5ASS>3RES/FIX The list has now been created, and I configured it to have public archives, with everyone being able to subscribe to it. You can configure the rest of the settings... [11:26:50] 3MediaWiki / 3Database: Fix "Uncommitted DB writes (transaction from DatabaseBase::query)" - 10https://bugzilla.wikimedia.org/56269#c45 (10ben) I have been trying to install MW 1.23 RC1 and I'm getting this error. The error occurs when the installer startes the database upgrade process. Replicated below for... [11:39:36] (03PS1) 10Mwjames: Inserted test whether the resource 'uploadsource' is already registered. Bug: 65530 [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/134590 (https://bugzilla.wikimedia.org/65530) [11:41:17] (03CR) 10Mwjames: "Cherry-picked from https://gerrit.wikimedia.org/r/#/c/134344/ and should be included for MW 1.23 LTS." [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/134590 (https://bugzilla.wikimedia.org/65530) (owner: 10Mwjames) [11:41:40] (03PS1) 10Physikerwelt: WIP: Fix: numFields wrong for sqlite [core] - 10https://gerrit.wikimedia.org/r/134591 (https://bugzilla.wikimedia.org/65578) [11:45:19] (03CR) 10jenkins-bot: [V: 04-1] WIP: Fix: numFields wrong for sqlite [core] - 10https://gerrit.wikimedia.org/r/134591 (https://bugzilla.wikimedia.org/65578) (owner: 10Physikerwelt) [11:46:48] (03CR) 10Daniel Kinzler: Record redirect target in ParserOptions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/131210 (https://bugzilla.wikimedia.org/62856) (owner: 10Anomie) [11:51:48] 3MediaWiki extensions / 3UniversalLanguageSelector: Change Sanskrit transliteration rules - 10https://bugzilla.wikimedia.org/63895#c39 (10NehalDaveND) Hi there are some different opinions in our community. so please do more changes for this script. now there is k+` = क़् can type but if after this क़् you ty... [11:53:03] 3Wikimedia / 3Mailing lists: Create a qa notification list - 10https://bugzilla.wikimedia.org/64610#c6 (10Tomasz W. Kozlowski) I forgot to mention that the list is subscribed to Gmane under gmane.org.wikimedia.qa.alerts if you are going to link to the archive on the Overview page on Meta. [12:05:04] (03CR) 10Physikerwelt: "The code seems to be quite broken. Would it be ok to use sqlite_num_rows( $ );" [core] - 10https://gerrit.wikimedia.org/r/134591 (https://bugzilla.wikimedia.org/65578) (owner: 10Physikerwelt) [12:06:05] 3MediaWiki / 3Database: SQLite support (tracking) - 10https://bugzilla.wikimedia.org/20257 (10Andre Klapper) [12:06:06] 3MediaWiki / 3Database: wrong result for numFileds in sqlite - 10https://bugzilla.wikimedia.org/65578 (10Andre Klapper) [12:06:19] 3MediaWiki / 3Database: wrong result for numFileds in sqlite - 10https://bugzilla.wikimedia.org/65578 (10Andre Klapper) p:5Unprio>3High [12:10:10] (03CR) 10Florianschmidtwelzow: [C: 031] Inserted test whether the resource 'uploadsource' is already registered. Bug: 65530 [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/134590 (https://bugzilla.wikimedia.org/65530) (owner: 10Mwjames) [12:15:03] (03CR) 10Florianschmidtwelzow: [C: 031] Prevent deleteBatch.php deleting files from redirects [core] - 10https://gerrit.wikimedia.org/r/132339 (https://bugzilla.wikimedia.org/52587) (owner: 10Withoutaname) [12:22:30] (03PS2) 10Physikerwelt: WIP: Fix: numFields wrong for sqlite [core] - 10https://gerrit.wikimedia.org/r/134591 (https://bugzilla.wikimedia.org/65578) [12:25:33] 3Wikimedia / 3Mailing lists: Create a qa notification list - 10https://bugzilla.wikimedia.org/64610#c7 (10Antoine "hashar" Musso) Thank you very much for the gmane registration! [12:25:43] (03CR) 10jenkins-bot: [V: 04-1] WIP: Fix: numFields wrong for sqlite [core] - 10https://gerrit.wikimedia.org/r/134591 (https://bugzilla.wikimedia.org/65578) (owner: 10Physikerwelt) [12:29:34] 3MediaWiki extensions / 3WikidataClient: pencil icon for "Edit links" should be vector (SVG) - 10https://bugzilla.wikimedia.org/65527#c1 (10Lydia Pintscher) p:5Unprio>3Low Do you guys have an appropriate icon? Then hoo can easily swap it I think. [12:30:34] 3MediaWiki extensions / 3WikidataRepo: Remove getTitle() from EntityContent - 10https://bugzilla.wikimedia.org/65531 (10Lydia Pintscher) [12:36:27] (03PS3) 10Physikerwelt: WIP: Fix: numFields wrong for sqlite [core] - 10https://gerrit.wikimedia.org/r/134591 (https://bugzilla.wikimedia.org/65578) [12:36:34] 3MediaWiki extensions / 3Math: Add separate database tables for LaTeXML - 10https://bugzilla.wikimedia.org/65522#c5 (10Derk-Jan Hartman) How did we end up with collision in the first place ? I don't remember the exact details. [12:36:44] (03PS1) 10Hashar: Notify qa-alerts@lists.wikimedia.org [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/134595 [12:38:40] 3Wikimedia / 3Site requests: Resolve namespace conflicts on Beta Wikiversity - 10https://bugzilla.wikimedia.org/64298#c7 (10Vogone) Any progress? I'd be fine with either solution (renaming the pages the way I suggested and then deleting them the proper way onwiki or deleting them directly from the DB). [12:43:34] hello everyeone. Could you please suggest which parser (preferable php stand-alone library) we can use to tokenize or convert to DOM the MediaWiki file. [12:44:50] 3MediaWiki / 3Database: Fix "Uncommitted DB writes (transaction from DatabaseBase::query)" - 10https://bugzilla.wikimedia.org/56269#c46 (10ben) I managed to remove the above error by manually adding the column "user_password_expires" to the user table. I don't know enough about the structure of the MW code t... [12:44:52] 3Wikimedia / 3Site requests: Rename pages prefixed Baden: at nlwiki - 10https://bugzilla.wikimedia.org/65579 (10Glaisher) 3UNC p:3Unprio s:3normal a:3None It is not possible to access these pages [1] due to the interwiki link [[baden:]]. Please do a rename and remove the prefix Baden: from the titles... [12:45:24] 3MediaWiki extensions / 3WikidataRepo: snak value html is inconsistent in js vs. non-js - 10https://bugzilla.wikimedia.org/65580 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs snak value html is inconsistent in js vs. non-js this causes problems when people want to extract the actual value from... [12:49:19] 3Wikimedia / 3Mailing lists: Create a qa notification list - 10https://bugzilla.wikimedia.org/64610#c8 (10Antoine "hashar" Musso) 5RES/?>3VER I have updated Jenkins to emit emails from jenkins-bot@wikimedia.org and subscribed that address to the list (mail delivery to that address is disabled though). A... [12:59:49] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.toc.test: Stub $.cookie to avoid test pollution [core] - 10https://gerrit.wikimedia.org/r/134361 (owner: 10Krinkle) [13:02:06] (03PS4) 10Physikerwelt: Fix: numFields wrong for sqlite [core] - 10https://gerrit.wikimedia.org/r/134591 (https://bugzilla.wikimedia.org/65578) [13:03:11] (03Merged) 10jenkins-bot: mediawiki.toc.test: Stub $.cookie to avoid test pollution [core] - 10https://gerrit.wikimedia.org/r/134361 (owner: 10Krinkle) [13:03:53] (03PS1) 10Jlloyd: Allow for URLs in article assignment [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/134598 (https://bugzilla.wikimedia.org/44397) [13:05:40] (03CR) 10Bartosz Dziewoński: [C: 04-1] Switch from CSS to LESS and use MediaWiki's SVG fallback LESS function (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/123348 (https://bugzilla.wikimedia.org/56502) (owner: 10Jforrester) [13:06:35] (03PS2) 10Jlloyd: Allow for URLs in article assignment [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/134598 (https://bugzilla.wikimedia.org/44397) [13:07:36] thedj: Hm.. in Mavericks, VoiceOver has interesting new behaviour [13:07:37] thedj: When backspacing a character it reads it out in a lower voice [13:08:06] so you go like a b cc b a [13:08:07] :D [13:09:34] (03PS5) 10Physikerwelt: Fix: numFields wrong for sqlite [core] - 10https://gerrit.wikimedia.org/r/134591 (https://bugzilla.wikimedia.org/65578) [13:12:06] Krinkle: you are testing VO ? [13:14:11] thedj: Yeah [13:14:44] (03CR) 10Bartosz Dziewoński: "I don't like caches that never expire. We shouldn't depend on the user refreshing the page to clean up our mess for us." [core] - 10https://gerrit.wikimedia.org/r/134542 (owner: 10Krinkle) [13:16:34] 3MediaWiki / 3Database: wrong result for numFileds in sqlite - 10https://bugzilla.wikimedia.org/65578#c2 (10physikerwelt) There are actually two bugs. 1) if the relation is empty a runtime error occours 2) the number of fields is calculated the wrong way the patch corrects the calculation if the result is no... [13:17:21] (03CR) 10Krinkle: "Just to clarify, we're not talking about HTML-based tipsy-like bubbles showing up, nor are we talking about information otherwise showing " [core] - 10https://gerrit.wikimedia.org/r/127358 (owner: 10Bartosz Dziewoński) [13:17:53] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.searchSuggest: Code clean up [core] - 10https://gerrit.wikimedia.org/r/134541 (owner: 10Krinkle) [13:18:34] 3MediaWiki extensions / 3Math: Add separate database tables for LaTeXML - 10https://bugzilla.wikimedia.org/65522#c6 (10physikerwelt) In all setups I now either LaTeXML of texvc is used. Not both at the same time. [13:18:47] (03CR) 10Krinkle: "I think if we are to add tooltips, we should add them always. We already do it in page output and pretty much every where else. Having the" [core] - 10https://gerrit.wikimedia.org/r/127358 (owner: 10Bartosz Dziewoński) [13:21:22] (03Merged) 10jenkins-bot: mediawiki.searchSuggest: Code clean up [core] - 10https://gerrit.wikimedia.org/r/134541 (owner: 10Krinkle) [13:21:34] 3MediaWiki / 3Database: Fix "Uncommitted DB writes (transaction from DatabaseBase::query)" - 10https://bugzilla.wikimedia.org/56269#c47 (10Bartosz Dziewoński) (In reply to ben from comment #46) > I managed to remove the above error by manually adding the column > "user_password_expires" to the user table. I... [13:24:01] (03PS7) 10Physikerwelt: Add separate database table for LaTeXML (step 2) [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 [13:24:23] Krinkle: VO is quite smart. it only reads titles for focusable elements if they differ from the content. [13:24:40] (03PS8) 10Physikerwelt: Add separate database table for LaTeXML (step 2) [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 (https://bugzilla.wikimedia.org/65522) [13:24:46] so if you take commons mainpage is says: [13:24:59] (03CR) 10Florianschmidtwelzow: [C: 031] mediawiki.searchSuggest: Cache results to save http requests [core] - 10https://gerrit.wikimedia.org/r/134542 (owner: 10Krinkle) [13:25:18] (03CR) 10Krinkle: "Fair enough, I'll do a 1 minute max age." [core] - 10https://gerrit.wikimedia.org/r/134542 (owner: 10Krinkle) [13:25:27] (03CR) 10Bartosz Dziewoński: "I hope that nothing else depends on doMigrateUserOptions :) (but it doesn't look like that's the case at a glance)." [core] - 10https://gerrit.wikimedia.org/r/133411 (https://bugzilla.wikimedia.org/63677) (owner: 10Withoutaname) [13:25:31] (03CR) 10jenkins-bot: [V: 04-1] Add separate database table for LaTeXML (step 2) [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 (https://bugzilla.wikimedia.org/65522) (owner: 10Physikerwelt) [13:25:35] a database of 21,238,443 Special:Statistics link, freely usable .... [13:28:17] (03PS5) 10Bartosz Dziewoński: Add method to determine EnhancedChangesList cache grouping key [core] - 10https://gerrit.wikimedia.org/r/125391 (owner: 10Aude) [13:28:35] 3Wikimedia / 3Site requests: Rename pages prefixed Baden: at nlwiki - 10https://bugzilla.wikimedia.org/65579 (10Vogone) 5UNC>3ASS p:5Unprio>3Normal a:3Sam Reed (reedy) [13:28:38] (03PS9) 10Physikerwelt: Add separate database table for LaTeXML (step 2) [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 (https://bugzilla.wikimedia.org/65522) [13:28:59] (03CR) 10Pcoombe: "Any chance you could take another look at this Werdna? Not sure what the problem was." [core] - 10https://gerrit.wikimedia.org/r/126004 (owner: 10Pcoombe) [13:29:21] (03PS3) 10Krinkle: mediawiki.searchSuggest: Cache results to save http requests [core] - 10https://gerrit.wikimedia.org/r/134542 [13:31:28] (03CR) 10jenkins-bot: [V: 04-1] Add separate database table for LaTeXML (step 2) [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 (https://bugzilla.wikimedia.org/65522) (owner: 10Physikerwelt) [13:32:27] (03CR) 10Florianschmidtwelzow: [C: 031] "Maybe write the expire time in commit message? :)" [core] - 10https://gerrit.wikimedia.org/r/134542 (owner: 10Krinkle) [13:36:12] (03PS10) 10Physikerwelt: Add separate database table for LaTeXML (step 2) [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 (https://bugzilla.wikimedia.org/65522) [13:37:05] (03CR) 10jenkins-bot: [V: 04-1] Add separate database table for LaTeXML (step 2) [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 (https://bugzilla.wikimedia.org/65522) (owner: 10Physikerwelt) [13:38:03] (03CR) 10Bartosz Dziewoński: [C: 032] Add method to determine EnhancedChangesList cache grouping key (031 comment) [core] - 10https://gerrit.wikimedia.org/r/125391 (owner: 10Aude) [13:39:19] 3MediaWiki / 3Database: Fix "Uncommitted DB writes (transaction from DatabaseBase::query)" - 10https://bugzilla.wikimedia.org/56269#c48 (10Bawolff (Brian Wolff)) (In reply to Nemo from comment #40) > And now it disappeared on translatewiki.net, for equally unknown reasons. > The last was: > > 2014-04-25 19.... [13:40:04] 3Wikimedia / 3Site requests: Rename pages prefixed Baden: at nlwiki - 10https://bugzilla.wikimedia.org/65579#c1 (10Bartosz Dziewoński) (In reply to Glaisher from comment #0) > and add {Baden) at the end of the titles to resolve this. You surely mean "(Baden)". :) [13:40:51] (03Merged) 10jenkins-bot: Add method to determine EnhancedChangesList cache grouping key [core] - 10https://gerrit.wikimedia.org/r/125391 (owner: 10Aude) [13:59:58] (03CR) 10Matthias Mullie: [C: 032] Use dummy user to make taking-over revision (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/129359 (https://bugzilla.wikimedia.org/64344) (owner: 10Wctaiwan) [14:00:21] (03Merged) 10jenkins-bot: Use dummy user to make taking-over revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/129359 (https://bugzilla.wikimedia.org/64344) (owner: 10Wctaiwan) [14:02:45] (03CR) 10Alex Monk: [C: 031] mediawiki.searchSuggest: Cache results to save http requests [core] - 10https://gerrit.wikimedia.org/r/134542 (owner: 10Krinkle) [14:04:08] (03PS4) 10Krinkle: mediawiki.searchSuggest: Enable result caching [core] - 10https://gerrit.wikimedia.org/r/134542 [14:04:10] (03PS1) 10Krinkle: jquery.suggestions: Support caching results to save http requests [core] - 10https://gerrit.wikimedia.org/r/134603 [14:04:59] (03CR) 10Krinkle: "@Florian: Done in Ib10c65f6ab3." [core] - 10https://gerrit.wikimedia.org/r/134542 (owner: 10Krinkle) [14:07:01] (03PS2) 10Krinkle: jquery.suggestions: Support caching results to save http requests [core] - 10https://gerrit.wikimedia.org/r/134603 [14:07:08] (03PS5) 10Krinkle: mediawiki.searchSuggest: Enable result caching [core] - 10https://gerrit.wikimedia.org/r/134542 [14:09:38] (03PS3) 10Krinkle: jquery.suggestions: Support caching results to save http requests [core] - 10https://gerrit.wikimedia.org/r/134603 (https://bugzilla.wikimedia.org/65581) [14:10:00] (03PS6) 10Krinkle: mediawiki.searchSuggest: Enable result caching [core] - 10https://gerrit.wikimedia.org/r/134542 [14:10:07] (03PS7) 10Krinkle: mediawiki.searchSuggest: Enable result caching [core] - 10https://gerrit.wikimedia.org/r/134542 (https://bugzilla.wikimedia.org/65581) [14:11:14] (03CR) 10Alexander.lehmann: [C: 032] Inserted a time span which may be an change in the past in order to be published. Inserted tests for the special page 'PubSubHubbub-Export' [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/132196 (owner: 10Alexander.lehmann) [14:11:33] (03PS1) 10Pcoombe: Fix table setup to support SQLite [extensions/Petition] - 10https://gerrit.wikimedia.org/r/134604 (https://bugzilla.wikimedia.org/65488) [14:14:31] (03CR) 10Alex Monk: jquery.suggestions: Support caching results to save http requests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/134603 (https://bugzilla.wikimedia.org/65581) (owner: 10Krinkle) [14:17:59] (03CR) 10Krinkle: jquery.suggestions: Support caching results to save http requests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/134603 (https://bugzilla.wikimedia.org/65581) (owner: 10Krinkle) [14:19:48] (03CR) 10Krinkle: [C: 04-1] "I'm not sure why this would warrant backporting. If we do, though, please also remove it from 1-23 release notes (in master, and cherry-pi" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/132464 (https://bugzilla.wikimedia.org/63269) (owner: 10Bartosz Dziewoński) [14:19:51] hexmode: ^ [14:19:58] "Either way, we'd need to know whether there will be another 1.22.x release before 1.23.0 stable" [14:20:00] do you know? [14:20:20] Krinkle: probably not, but I'll look [14:23:19] (03PS1) 10Krinkle: mediawiki.user: Use mw.log.deprecate to track user() and anonymous() [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134605 [14:25:43] (03PS1) 10Phuedx: Add the mwext-GettingStarted-qunit job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134606 [14:25:46] (03CR) 10jenkins-bot: [V: 04-1] Add the mwext-GettingStarted-qunit job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134606 (owner: 10Phuedx) [14:27:50] (03PS1) 10Krinkle: Remove jQuery Migrate [core] - 10https://gerrit.wikimedia.org/r/134607 (https://bugzilla.wikimedia.org/44740) [14:28:35] (03CR) 10Krinkle: [C: 04-2] "Do not merge until after 1.24wmf6 is cut, this is slated for 1.24wmf7 (to roll out May 29 to test wikis and to main wikis in June)." [core] - 10https://gerrit.wikimedia.org/r/134607 (https://bugzilla.wikimedia.org/44740) (owner: 10Krinkle) [14:28:35] 3MediaWiki / 3Installer: XML installation file and zip deployment solution for Microsoft Web Gallery inclusion - 10https://bugzilla.wikimedia.org/34720#c2 (10Andre Klapper) 5ASS>3NEW a:5Markus Glaser>3None Markus Glaser: I am resetting the assignee of this issue to default because there has been no p... [14:28:48] greg-g: I've drafted the commit ahead this time https://gerrit.wikimedia.org/r/#/c/134607/ [14:31:03] (03CR) 10jenkins-bot: [V: 04-1] Remove jQuery Migrate [core] - 10https://gerrit.wikimedia.org/r/134607 (https://bugzilla.wikimedia.org/44740) (owner: 10Krinkle) [14:37:31] Wow what happened to https://www.mediawiki.org/wiki/VisualEditor:Test [14:37:42] Does 200x300px syntax no longer work? [14:37:54] greg-g: ^ regression I think. [14:38:33] subbu: [14:39:04] (03CR) 10Matthias Mullie: [C: 04-1] Fix indexes for Reference objects. (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/133666 (owner: 10Werdna) [14:40:45] (03CR) 10Matthias Mullie: [C: 032] Add i18n message to 'workflow' link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/134508 (https://bugzilla.wikimedia.org/65102) (owner: 10Bsitu) [14:41:03] (03Merged) 10jenkins-bot: Add i18n message to 'workflow' link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/134508 (https://bugzilla.wikimedia.org/65102) (owner: 10Bsitu) [14:41:04] Krinkle, I'll have to page in recent changes .. but I know some of cscott's image patches got merged in core recently. [14:41:30] https://github.com/wikimedia/mediawiki-core/commits/wmf/1.24wmf5/includes?author=cscott [14:43:38] (03CR) 10Krinkle: [C: 031] jQuery 1.9 compatibility fixes (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 (owner: 10Gilles) [14:46:18] (03CR) 10Nemo bis: "We already know there will be one: https://www.mediawiki.org/wiki/MediaWiki_1.22#Release_schedule" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/132464 (https://bugzilla.wikimedia.org/63269) (owner: 10Bartosz Dziewoński) [14:50:01] (03PS2) 10Krinkle: Use an actual URL for helppage in enotif_body [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/132464 (https://bugzilla.wikimedia.org/63269) (owner: 10Bartosz Dziewoński) [14:54:05] can i force jenkins to rebuild something and update its result on gerrit without rebasing the change? [14:54:58] (03PS1) 10Krinkle: Move release notes for "Introducing pp_sortkey" to 1.24 [core] - 10https://gerrit.wikimedia.org/r/134610 [14:55:01] phuedx: you can try putting "recheck" into a comment [14:55:14] recheck runs lint tests only [14:55:36] Just rebase, or, if you can't because it's already up to date, do a Cherry Pick to the same branch. [14:55:45] (03CR) 10Krinkle: [C: 032] Move release notes for "Introducing pp_sortkey" to 1.24 [core] - 10https://gerrit.wikimedia.org/r/134610 (owner: 10Krinkle) [14:55:47] thanks mutante, Krinkle [14:55:49] will do :) [14:55:56] (03CR) 10Krinkle: "Moved notes in Iaa78a8254b311." [core] - 10https://gerrit.wikimedia.org/r/122349 (owner: 10Daniel Kinzler) [14:56:49] Krinkle: will cherry picking to the same branch work? i thought gerrit didn't like the same change-id on the same branch? [14:57:02] It will not create a new change, it will make a new patch set [14:57:11] (03CR) 10MarkAHershberger: [C: 031] "I'll do more thorough testing tonight if Markus doesn't +2 this before then." [core] - 10https://gerrit.wikimedia.org/r/133411 (https://bugzilla.wikimedia.org/63677) (owner: 10Withoutaname) [14:57:11] ah [14:57:43] (03CR) 10Krinkle: "Release notes were updated for 1.23 but not backported to REL1_23, please revert, move to 1.24 or fix." [core] - 10https://gerrit.wikimedia.org/r/121419 (https://bugzilla.wikimedia.org/49965) (owner: 10Kaldari) [14:58:11] (03PS2) 10Phuedx: Add the mwext-GettingStarted-qunit job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134606 [14:58:11] Krinkle, https://github.com/wikimedia/mediawiki-core/commit/079c3dda80358b0b322b36f041bf1b82bf930069#diff-bb2b21ef7774df8687ff02b0284505c6 ... so 203x203px for framed images no longer work. [14:58:30] That page has source: [[File:Test wiki logo notext.png|right|You can edit this [[Help:Images|caption]] or resize this image if you want to.|203x203px|frame]] [14:59:17] (03Merged) 10jenkins-bot: Move release notes for "Introducing pp_sortkey" to 1.24 [core] - 10https://gerrit.wikimedia.org/r/134610 (owner: 10Krinkle) [14:59:21] subbu: I don't know anything. All I know is 1) it's a weird thing to see, yes, 2) it doesn't work any more, 3) people will be angry if this happens on pages that aren't sandboxes, which is most likely to be the case, 4) Questeion: Was this intentionally broken? [14:59:41] Krinkle: https://gerrit.wikimedia.org/r/121419 says "Included in: Branch Name: REL1_23" [14:59:59] iirc, he did a grep on the dumps and found that this is not a common usage .. he can answer that best when he is online. [15:00:29] From the commit message: "This makes the PHP parser behavior consistent with the specification at https://www.mediawiki.org/wiki/Help:Images#Size_and_frame which says: "An image with frame always ignores the size specification." [15:02:16] Krinkle, https://bugzilla.wikimedia.org/show_bug.cgi?id=62258#c6 through #c8 [15:02:52] (03CR) 10Krinkle: "Indeed, commit I595feec9a525104e382f and others got the release notes out of sync. Whatever did not end up in 1.23 should be removed from " [core] - 10https://gerrit.wikimedia.org/r/121419 (https://bugzilla.wikimedia.org/49965) (owner: 10Kaldari) [15:04:36] (03PS1) 10Krinkle: Fixup typography changes release notes between 1.23 and 1.14 [core] - 10https://gerrit.wikimedia.org/r/134611 [15:05:14] (03CR) 10Krinkle: [C: 032] Fixup typography changes release notes between 1.23 and 1.14 [core] - 10https://gerrit.wikimedia.org/r/134611 (owner: 10Krinkle) [15:05:21] (03CR) 10Anomie: [C: 032] "SWAT deploy" [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134505 (owner: 10Aaron Schulz) [15:06:01] (03CR) 10Foxtrott: "Thanks for your comment (and your mail)! Interesting stuff there." [skins/chameleon] - 10https://gerrit.wikimedia.org/r/134556 (owner: 10Foxtrott) [15:06:28] (03PS11) 10Physikerwelt: Add separate database table for LaTeXML (step 2) [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 (https://bugzilla.wikimedia.org/65522) [15:10:14] (03CR) 10Krinkle: "fyi: This would only remove 2 of the 5 lines added to RELEASE-NOTES. If this is restored, fix that." [core] - 10https://gerrit.wikimedia.org/r/131109 (https://bugzilla.wikimedia.org/62856) (owner: 10MarkAHershberger) [15:14:37] (03Merged) 10jenkins-bot: Fixup typography changes release notes between 1.23 and 1.14 [core] - 10https://gerrit.wikimedia.org/r/134611 (owner: 10Krinkle) [15:15:46] (03Merged) 10jenkins-bot: Replace FOR UPDATE with LockManager use in LocalFile::lock() [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134505 (owner: 10Aaron Schulz) [15:21:45] (03CR) 10Anomie: [C: 032] Tweaked timestamp kludge logic in recordUpload2 [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134536 (owner: 10Gergő Tisza) [15:23:01] (03PS1) 10Krinkle: Move release notes for "Introducing pp_sortkey" to 1.24 [core] - 10https://gerrit.wikimedia.org/r/134614 [15:23:12] (03CR) 10Krinkle: [C: 032] Move release notes for "Introducing pp_sortkey" to 1.24 [core] - 10https://gerrit.wikimedia.org/r/134614 (owner: 10Krinkle) [15:23:52] Where is wikibugs? [15:24:22] (03PS1) 10Krinkle: Removed 'Remember my login' preference [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/134615 (https://bugzilla.wikimedia.org/52342) [15:24:48] (03CR) 10Krinkle: [C: 032] Removed 'Remember my login' preference [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/134615 (https://bugzilla.wikimedia.org/52342) (owner: 10Krinkle) [15:25:10] Krenair: indeed [15:25:33] (03PS6) 10Nuria: Cast empty server-side events to object [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/133668 (https://bugzilla.wikimedia.org/65385) (owner: 10Ori.livneh) [15:26:31] (03Merged) 10jenkins-bot: Tweaked timestamp kludge logic in recordUpload2 [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134536 (owner: 10Gergő Tisza) [15:26:50] (03CR) 10Nuria: "Hopefully I have addressed concerns with testing. How to best test changes to PHP code (beside tests)?" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/133668 (https://bugzilla.wikimedia.org/65385) (owner: 10Ori.livneh) [15:28:03] (03PS1) 10Krinkle: Sync 1.23 release notes for bug 64289 from REL1_23 [core] - 10https://gerrit.wikimedia.org/r/134616 [15:28:14] (03CR) 10Nuria: Cast empty server-side events to object (033 comments) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/133668 (https://bugzilla.wikimedia.org/65385) (owner: 10Ori.livneh) [15:28:29] (03CR) 10Krinkle: [C: 032] Sync 1.23 release notes for bug 64289 from REL1_23 [core] - 10https://gerrit.wikimedia.org/r/134616 (owner: 10Krinkle) [15:28:57] (03CR) 10jenkins-bot: [V: 04-1] Cast empty server-side events to object [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/133668 (https://bugzilla.wikimedia.org/65385) (owner: 10Ori.livneh) [15:29:18] (03PS1) 10Santhosh: Dictionary: Json file dictionary backend [services/cxserver] - 10https://gerrit.wikimedia.org/r/134617 [15:30:01] (03CR) 10jenkins-bot: [V: 04-1] Move release notes for "Introducing pp_sortkey" to 1.24 [core] - 10https://gerrit.wikimedia.org/r/134614 (owner: 10Krinkle) [15:30:03] (03CR) 10jenkins-bot: [V: 04-1] Sync 1.23 release notes for bug 64289 from REL1_23 [core] - 10https://gerrit.wikimedia.org/r/134616 (owner: 10Krinkle) [15:30:52] (03PS1) 10Santhosh: Add the missing css file for the html interface of server [services/cxserver] - 10https://gerrit.wikimedia.org/r/134618 [15:31:00] (03PS1) 10Krinkle: Sync 1.23 release notes for bug 13250 from REL1_23 [core] - 10https://gerrit.wikimedia.org/r/134619 [15:31:40] (03PS2) 10Krinkle: Sync 1.23 release notes for bug 64289 from REL1_23 [core] - 10https://gerrit.wikimedia.org/r/134616 [15:32:07] (03CR) 10Krinkle: "These release notes should've been added to master and then backported along. Fixed in I5d36dc86f10e." [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/133942 (https://bugzilla.wikimedia.org/64289) (owner: 10TheDJ) [15:32:07] (03CR) 10Anomie: [C: 032] mediawiki.user: Use mw.log.deprecate to track user() and anonymous() [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134605 (owner: 10Krinkle) [15:32:07] (03PS2) 10Krinkle: Sync 1.23 release notes for bug 13250 from REL1_23 [core] - 10https://gerrit.wikimedia.org/r/134619 [15:32:10] (03CR) 10jenkins-bot: [V: 04-1] Dictionary: Json file dictionary backend [services/cxserver] - 10https://gerrit.wikimedia.org/r/134617 (owner: 10Santhosh) [15:32:13] (03CR) 10Physikerwelt: "@Hashar: Look I added a newline to the commit message and Jenkins is happy. Is there wa way to figure out if it was processed by the same " [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 (https://bugzilla.wikimedia.org/65522) (owner: 10Physikerwelt) [15:32:23] (03CR) 10Krinkle: "These release notes should've been added to master and then backported along. Fixed in Iceeb6c0390." [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/132733 (https://bugzilla.wikimedia.org/13250) (owner: 10MarkAHershberger) [15:33:04] (03CR) 10jenkins-bot: [V: 04-1] Sync 1.23 release notes for bug 64289 from REL1_23 [core] - 10https://gerrit.wikimedia.org/r/134616 (owner: 10Krinkle) [15:33:57] (03PS2) 10Krinkle: Move release notes for "Introducing pp_sortkey" to 1.24 [core] - 10https://gerrit.wikimedia.org/r/134614 [15:34:05] (03PS3) 10Krinkle: Sync 1.23 release notes for bug 64289 from REL1_23 [core] - 10https://gerrit.wikimedia.org/r/134616 [15:34:08] (03Merged) 10jenkins-bot: Removed 'Remember my login' preference [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/134615 (https://bugzilla.wikimedia.org/52342) (owner: 10Krinkle) [15:34:10] (03PS3) 10Krinkle: Sync 1.23 release notes for bug 13250 from REL1_23 [core] - 10https://gerrit.wikimedia.org/r/134619 [15:34:12] (03PS2) 10Santhosh: Dictionary: Json file dictionary backend [services/cxserver] - 10https://gerrit.wikimedia.org/r/134617 [15:41:38] (03CR) 10Krinkle: [C: 032] Sync 1.23 release notes for bug 13250 from REL1_23 [core] - 10https://gerrit.wikimedia.org/r/134619 (owner: 10Krinkle) [15:41:45] (03CR) 10Florianschmidtwelzow: [C: 031] mediawiki.searchSuggest: Enable result caching [core] - 10https://gerrit.wikimedia.org/r/134542 (https://bugzilla.wikimedia.org/65581) (owner: 10Krinkle) [15:41:53] (03CR) 10Krinkle: [C: 031] Sync 1.23 release notes for bug 64289 from REL1_23 [core] - 10https://gerrit.wikimedia.org/r/134616 (owner: 10Krinkle) [15:41:55] (03CR) 10Florianschmidtwelzow: [C: 031] jquery.suggestions: Support caching results to save http requests [core] - 10https://gerrit.wikimedia.org/r/134603 (https://bugzilla.wikimedia.org/65581) (owner: 10Krinkle) [15:41:57] (03CR) 10Hashar: [C: 032] "I have deployed this change earlier today." [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/134595 (owner: 10Hashar) [15:42:00] (03CR) 10Krinkle: [C: 032] Sync 1.23 release notes for bug 64289 from REL1_23 [core] - 10https://gerrit.wikimedia.org/r/134616 (owner: 10Krinkle) [15:42:36] (03Merged) 10jenkins-bot: mediawiki.user: Use mw.log.deprecate to track user() and anonymous() [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134605 (owner: 10Krinkle) [15:42:46] (03CR) 10Matthias Mullie: [C: 031] "Code looks ok - I'm ok with merging as-is too, if you want it merged fast ;)" (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/133880 (owner: 10Bsitu) [15:43:02] (03PS1) 10Krinkle: Move release notes for "Move redirect rendering into WikitextContent" to 1.24 [core] - 10https://gerrit.wikimedia.org/r/134623 [15:43:24] (03CR) 10Krinkle: [C: 032] Move release notes for "Move redirect rendering into WikitextContent" to 1.24 [core] - 10https://gerrit.wikimedia.org/r/134623 (owner: 10Krinkle) [15:43:24] (03CR) 10Krinkle: "Release notes were not synced back to master. This is still in master and destined for 1.24 but it's missing those notes. Fixed in I9ef526" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/131209 (https://bugzilla.wikimedia.org/62856) (owner: 10MarkAHershberger) [15:44:03] I really need to sort that damn OSM/Echo bug [15:44:41] (03PS1) 10Paladox: add support for request account link and renames login/create account to login [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/134624 [15:44:57] (03Merged) 10jenkins-bot: Notify qa-alerts@lists.wikimedia.org [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/134595 (owner: 10Hashar) [15:47:24] (03PS8) 10Umherirrender: Avoid using raw sql in SpecialUndelete.php [core] - 10https://gerrit.wikimedia.org/r/124659 [15:48:14] (03PS1) 10Krinkle: Sync RELEASE-NOTES-1.23 between REL1_23 and master [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/134626 [15:48:34] (03CR) 10Krinkle: [C: 032] "Finally, now they're back in sync." [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/134626 (owner: 10Krinkle) [15:49:04] (03CR) 10Krinkle: "It would've helped if this had the same Change-Id as the abandoned one in master (Ia5ee7d1d05eb) so that it was more discoverable. Turns o" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/131209 (https://bugzilla.wikimedia.org/62856) (owner: 10MarkAHershberger) [15:49:21] (03CR) 10Krinkle: [C: 032] Move release notes for "Introducing pp_sortkey" to 1.24 [core] - 10https://gerrit.wikimedia.org/r/134614 (owner: 10Krinkle) [15:51:27] (03CR) 10Krinkle: [C: 032] Use an actual URL for helppage in enotif_body [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/132464 (https://bugzilla.wikimedia.org/63269) (owner: 10Bartosz Dziewoński) [15:53:09] (03CR) 10KartikMistry: [C: 032] Add the missing css file for the html interface of server [services/cxserver] - 10https://gerrit.wikimedia.org/r/134618 (owner: 10Santhosh) [15:53:56] (03Merged) 10jenkins-bot: Add the missing css file for the html interface of server [services/cxserver] - 10https://gerrit.wikimedia.org/r/134618 (owner: 10Santhosh) [15:54:28] (03CR) 10PleaseStand: [C: 04-1] Move doMigrateUserOptions() to run after creating user_password_expires (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133411 (https://bugzilla.wikimedia.org/63677) (owner: 10Withoutaname) [15:55:44] (03CR) 10MarkTraceur: "Eugh." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/134073 (https://bugzilla.wikimedia.org/65323) (owner: 10Dan-nl) [15:55:46] (03CR) 10Krinkle: "Hm.. never mind, they are fine being in 1.23. This is a minor release, not the major release. Updates in minor releases are always backpor" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/132464 (https://bugzilla.wikimedia.org/63269) (owner: 10Bartosz Dziewoński) [15:56:01] Krinkle: is that regression issue resolved? /me lost the thread in the scrollback [15:56:12] greg-g: Nope, ask subbu [15:56:13] Krinkle: thanks for the jquery patch [15:56:25] (03Merged) 10jenkins-bot: Sync RELEASE-NOTES-1.23 between REL1_23 and master [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/134626 (owner: 10Krinkle) [15:56:33] subbu: regression issue? need any help/deploy today? [15:56:46] (03CR) 10Paladox: [C: 031] "I have tested the codes on my wiki and they work." [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/134624 (owner: 10Paladox) [15:57:08] greg-g, actually no ... From the commit message: "This makes the PHP parser behavior consistent with the specification at https://www.mediawiki.org/wiki/Help:Images#Size_and_frame which says: "An image with frame always ignores the size specification." [15:57:09] Krinkle, https://bugzilla.wikimedia.org/show_bug.cgi?id=62258#c6 through #c8 [15:57:28] (03Merged) 10jenkins-bot: Move release notes for "Introducing pp_sortkey" to 1.24 [core] - 10https://gerrit.wikimedia.org/r/134614 (owner: 10Krinkle) [15:57:55] * greg-g reads [15:58:20] (03CR) 10Withoutaname: "Well, we can go with patch set 1 if need be." [core] - 10https://gerrit.wikimedia.org/r/133411 (https://bugzilla.wikimedia.org/63677) (owner: 10Withoutaname) [15:58:22] (03Merged) 10jenkins-bot: Sync 1.23 release notes for bug 64289 from REL1_23 [core] - 10https://gerrit.wikimedia.org/r/134616 (owner: 10Krinkle) [15:58:27] (03Merged) 10jenkins-bot: Sync 1.23 release notes for bug 13250 from REL1_23 [core] - 10https://gerrit.wikimedia.org/r/134619 (owner: 10Krinkle) [15:58:27] subbu: interesting [15:58:31] (03Merged) 10jenkins-bot: Move release notes for "Move redirect rendering into WikitextContent" to 1.24 [core] - 10https://gerrit.wikimedia.org/r/134623 (owner: 10Krinkle) [15:59:18] subbu: OK, but whatever that height bound stuff means, surely it can't possibly be correct change to go from 203x203px to 3000px frame. Maybe it ignores one of the sizes or uses a square, but it shouldn't ignore both values. [15:59:24] That's what it is doing on the page I linked. [15:59:32] If it no longer wants to crop, or whatever, sure. [16:00:46] (03PS1) 10Deepali: Efficient navigation through sections [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/134627 (https://bugzilla.wikimedia.org/52435) [16:01:03] Krinkle, why dont we wait for cscott_away to be around? [16:01:28] subbu: Hm.. well that same page also has an example of "frame|500px", and that page is hand written by whomever as a help page, *not* a specification [16:03:01] subbu: cscott_away: https://www.mediawiki.org/wiki/Help:Images#Size_and_frame [16:03:03] Krinkle, Can you add your thoughts on the bug report / now merged commit? thanks. [16:03:06] note the one with 'framed' [16:03:26] (03Merged) 10jenkins-bot: Use an actual URL for helppage in enotif_body [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/132464 (https://bugzilla.wikimedia.org/63269) (owner: 10Bartosz Dziewoński) [16:13:39] (03CR) 10MarkTraceur: "You should just remove the jasmine test; we've not used it for a long time and I honestly thought we had already deleted it all." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 (owner: 10Gilles) [16:22:20] (03CR) 10Paladox: [C: 031] iOS: Enable WikiEditor toolbar [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/132603 (https://bugzilla.wikimedia.org/63277) (owner: 10TheDJ) [16:23:06] (03CR) 10Paladox: [C: 031] Add support for sqlite [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/90105 (owner: 10MarkAHershberger) [16:28:15] (03CR) 10Frédéric Wang: [C: 031] "OK, looks good to me with the a few comments to address. I didn't check in details the the changes to the tests." (037 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 (https://bugzilla.wikimedia.org/65522) (owner: 10Physikerwelt) [16:44:20] (03PS2) 10Gerrit Patch Uploader: search.less: Use static width for the search button [core] - 10https://gerrit.wikimedia.org/r/127371 [16:44:22] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/127371 (owner: 10Gerrit Patch Uploader) [16:56:52] (03CR) 10AndyRussG: [C: 04-1] "Thanks for making these changes!! :) Very, very close, but still not quite there!" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/118101 (https://bugzilla.wikimedia.org/56325) (owner: 10Jlloyd) [16:59:38] OMG, is there no limit to what when the foundation feels obligated to overrule a local wiki sysop decision? [16:59:39] http://i.imgur.com/dd5OElt.png [16:59:48] How can that not hurt editors [16:59:57] The whole page is distorted [17:00:09] tabs hanging out, pale yellow popups [17:00:31] logo alignment off the scale [17:00:41] who are these people? [17:00:45] xD :S ?!1sf13 [17:00:48] urwiki is fund [17:00:50] * fun [17:00:56] yeah, my wiki too [17:01:12] but mywiki is nice [17:03:04] Krinkle: Taht's the fun we get for allowing thousands of people to edit our JS and CSS [17:05:22] Krinkle: I already reported it as https://bugzilla.wikimedia.org/show_bug.cgi?id=65388 , don't you remember [17:07:20] (you can probably use your newly acquired karma to make at least some tweaks) [17:14:43] (03CR) 10Nemo bis: "According to the bug report this may have substantially reduced the errors, at least on translatewiki.net. Should/can it be backported?" [core] - 10https://gerrit.wikimedia.org/r/127868 (owner: 10Aaron Schulz) [17:21:04] mw log deprecate statistics http://codepen.io/Krinkle/full/zyodJ/ (switch between 3 days and 2 weeks) [17:21:14] added mw.user anonymous() and name() [17:24:30] (03PS12) 10Physikerwelt: Add separate database table for LaTeXML (step 2) [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 (https://bugzilla.wikimedia.org/65522) [17:24:41] (03CR) 10Physikerwelt: Add separate database table for LaTeXML (step 2) (036 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 (https://bugzilla.wikimedia.org/65522) (owner: 10Physikerwelt) [17:26:28] (03PS1) 10Krinkle: mediawiki.user: Add message to mw.log.deprecate for user() and anonymous [core] - 10https://gerrit.wikimedia.org/r/134637 [17:26:57] (03CR) 10Mattflaschen: [C: 04-1] "I don't think this is the right solution." [core] - 10https://gerrit.wikimedia.org/r/134561 (https://bugzilla.wikimedia.org/65514) (owner: 10Florianschmidtwelzow) [17:28:09] (03CR) 10Frédéric Wang: [C: 031] "OK, looks good. I'll +2 tomorrow if nobody complains." [extensions/Math] - 10https://gerrit.wikimedia.org/r/134486 (https://bugzilla.wikimedia.org/65522) (owner: 10Physikerwelt) [17:33:10] marktraceur: you in the office/ coming to SoS? [17:33:26] awjr: Yes, coming [17:33:35] awjr: There are two calendar events for SoS today and we joined the wrong one at first [17:33:52] (03CR) 10Fomafix: [C: 04-1] mediawiki.user: Add message to mw.log.deprecate for user() and anonymous (031 comment) [core] - 10https://gerrit.wikimedia.org/r/134637 (owner: 10Krinkle) [17:34:54] (03PS2) 10Krinkle: mediawiki.user: Add message to deprecation of user() and anonymous() [core] - 10https://gerrit.wikimedia.org/r/134637 [17:35:58] (03CR) 10Krinkle: "Message::isBlank() comes to mind, might be relevant (keep in core as blank, and use isBlank() instead, like we do with sitenotice, hidden " [core] - 10https://gerrit.wikimedia.org/r/134561 (https://bugzilla.wikimedia.org/65514) (owner: 10Florianschmidtwelzow) [17:37:13] chrismcmahon: Re QA/VE, let's schedule something on Friday? [17:37:19] Today is busy and I'm out tomorrow [17:37:40] RoanKattouw: sure, sounds good, thanks [17:38:10] (03CR) 10Fomafix: mediawiki.user: Add message to deprecation of user() and anonymous() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/134637 (owner: 10Krinkle) [17:38:32] (03PS3) 10Krinkle: mediawiki.user: Add message to deprecation of name() and anonymous() [core] - 10https://gerrit.wikimedia.org/r/134637 [17:39:27] (03CR) 10Fomafix: [C: 031] mediawiki.user: Add message to deprecation of name() and anonymous() [core] - 10https://gerrit.wikimedia.org/r/134637 (owner: 10Krinkle) [17:39:53] (03CR) 10Hoo man: [C: 032] mediawiki.user: Add message to deprecation of name() and anonymous() [core] - 10https://gerrit.wikimedia.org/r/134637 (owner: 10Krinkle) [17:41:11] (03Abandoned) 10Krinkle: [WIP] Add mw.track calls for jquery.migrate [core] - 10https://gerrit.wikimedia.org/r/133235 (owner: 10Krinkle) [17:42:58] (03Merged) 10jenkins-bot: mediawiki.user: Add message to deprecation of name() and anonymous() [core] - 10https://gerrit.wikimedia.org/r/134637 (owner: 10Krinkle) [17:45:34] Krinkle: IE8 support in oojs! [17:45:34] (03Abandoned) 10Krinkle: mw.hook: Implement hook.once [core] - 10https://gerrit.wikimedia.org/r/123821 (owner: 10Krinkle) [17:45:44] (03Restored) 10Krinkle: mw.hook: Implement hook.once [core] - 10https://gerrit.wikimedia.org/r/123821 (owner: 10Krinkle) [17:45:45] (03Abandoned) 10Krinkle: mw.hook: Implement hook.once [core] - 10https://gerrit.wikimedia.org/r/123821 (owner: 10Krinkle) [17:46:06] (03CR) 10Aaron Schulz: [C: 032] Fix: numFields wrong for sqlite [core] - 10https://gerrit.wikimedia.org/r/134591 (https://bugzilla.wikimedia.org/65578) (owner: 10Physikerwelt) [17:46:24] marktraceur: fyi, the first thing I'm working on is support in RL to have a feature test. That will make it easier to filter out IE8, it will not support IE8 in that sense. [17:46:50] that same RL feature wil also allow conditional loading of polyfils, such as ES5, so that's coimng too and that'll make IE8 happy [17:46:57] *nod* [17:47:09] marktraceur: please tell me mmv/uplaodwizard is not still loading in IE8 in a broken way? [17:47:22] there's an early return now, right? [17:47:23] Krinkle: My only intent was to poke you into doing something; I keep coming to SoS and seeing that card still blocked [17:47:28] Uhhh I'm not sure! [17:47:34] I think we have a cancel-out clause. [17:48:23] OK. But it's a bug on your end that it loads a library that isn't supported in that environment. It's a slightly lower priority enhancement bug on our end that it doesn't support that environment. [17:48:44] Don't wait for one to fix the other, there will always be another browser that isn' supported. You need that feature test. [17:48:48] (03CR) 10Florianschmidtwelzow: "@Krinkle: You mean use MediaWiki:Createacct-helpusername instead of WikimediaMessages? I'm not sure, if it possible to override an existin" [core] - 10https://gerrit.wikimedia.org/r/134561 (https://bugzilla.wikimedia.org/65514) (owner: 10Florianschmidtwelzow) [17:49:04] Krinkle: What feature test? Checking for OOJS? [17:49:29] (03Merged) 10jenkins-bot: Fix: numFields wrong for sqlite [core] - 10https://gerrit.wikimedia.org/r/134591 (https://bugzilla.wikimedia.org/65578) (owner: 10Physikerwelt) [17:49:40] csteipp, when you have a chance, please +2 the first patch for this bug (re https redir) https://bugzilla.wikimedia.org/show_bug.cgi?id=65567 [17:49:57] marktraceur: asserting the environment has what you (or your dependencies) need before you go "balls in". MediaWiki core startup.js does this already for browsers that we dont support there, but visualeditor/oojs/mmv is more modern and right now supports a subset (e.g. no IE8 at the moment) [17:50:10] marktraceur: https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js#L85-L102 [17:50:19] the one in VE is quite extensive, you'll want a much simpler one [17:50:22] but something like that [17:50:42] check for the methods you or oojs depends on, and cast it to a boolean, and if !supported, return, never load the main modules [17:56:26] 'kay [18:01:10] bd808: does the new mw-vagrant support multiple wikis with DB load-balancing? [18:02:24] tgr: Meaning master-slave databases? [18:02:28] If so, no [18:02:53] would it be hard to add them? [18:03:11] Probably not too hard [18:03:13] I am thinking of making a Commons-lookalike role [18:03:36] tgr: That would be awesome [18:03:41] we have been bitten so often by ForeignDBViaLB doing things differently [18:04:22] ForeignDBViaLBRepo I mean [18:04:35] like not inheriting from ForeignDBRepo [18:06:13] tgr: If you can dig up the right config parts from operations/medaiwiki-config I'd be glad to help write the puppet bits that are needed to apply them [18:06:25] (03PS1) 10Ragesoss: Use correct case for Special:Prefixindex [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/134645 [18:07:11] Making a role that sets up common.wiki.local.wmftest.net and hooks the main wiki too it seems like a great thing for debugigng [18:09:47] bd808: sounds like a plan [18:10:32] tgr: I'll even be in SF in a couple of weeks if we don't have it working by then. [18:10:44] gwicke: https://bugzilla.wikimedia.org/show_bug.cgi?id=2700 the last question on the ticket is asking you if you're working on a solution [18:12:52] (03PS1) 10Legoktm: Use cannonical url for IRC feed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/134648 [18:13:31] Krinkle: So thanks for https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js#L85-L102 - is there a list of the things necessary for oojs? [18:16:28] marktraceur: I listed a few at https://bugzilla.wikimedia.org/show_bug.cgi?id=63303#c8 [18:16:49] So Object.create && Array.isArray && window.JSON && JSON.stringify; at least [18:17:21] (03CR) 10Mattflaschen: ""I'm not sure, if it possible to override an existing message key, so i did this change instead."" [core] - 10https://gerrit.wikimedia.org/r/134561 (https://bugzilla.wikimedia.org/65514) (owner: 10Florianschmidtwelzow) [18:17:28] Should be enough [18:17:46] Thanks Krinkle [18:18:09] marktraceur: http://jsfiddle.net/T8zKg/embedded/result/ [18:18:13] checking browserstack now [18:18:31] yep, false in Win7/IE8 [18:18:31] (03CR) 10Mattflaschen: "Sorry, meant to say:" [core] - 10https://gerrit.wikimedia.org/r/134561 (https://bugzilla.wikimedia.org/65514) (owner: 10Florianschmidtwelzow) [18:20:38] Krinkle, marktraceur: OOjs UI will have a wider set of thing to test for. [18:20:52] (03CR) 10Krinkle: "@Florian: I have no idea what this is about, but about the message thing specifically, yes. I'd say keep the message in core, but blank, t" [core] - 10https://gerrit.wikimedia.org/r/134561 (https://bugzilla.wikimedia.org/65514) (owner: 10Florianschmidtwelzow) [18:21:53] James_F: But that's only one small part of the code; that breaking is mostly OK [18:23:19] (03PS1) 10MaxSem: Add a few schemas to SQLite tests [core] - 10https://gerrit.wikimedia.org/r/134654 [18:23:43] (03PS2) 10Legoktm: Use cannonical url for IRC feed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/134648 [18:26:08] marktraceur: Sure, but let's avoid it if possible. :-) [18:26:22] Sure [18:31:08] is there a global variable that sets the /wiki/ path name for pages? [18:31:21] ragesoss: $wgPath [18:31:34] Er. [18:31:44] $wgScriptPath, sorry [18:31:55] marktraceur: isn't that /w, not /wiki? [18:32:13] It depends on your setup [18:32:13] ragesoss: Or $wgArticlePath [18:32:52] (03CR) 10GWicke: [C: 032] "Alright, lets get this in." [core] - 10https://gerrit.wikimedia.org/r/130770 (owner: 10Jforrester) [18:32:56] marktraceur: I'm looking at my vagrant setup (as well as the docs on mw.org), and I can't find a reference to /wiki anywhere in those variables. [18:33:18] Weird [18:33:23] It seems like the recommended way (so, our way, I assumed) is to do those rewrites in the web server. [18:33:48] hmm... [18:33:56] maybe it is ScriptPath after all. [18:34:33] except in my vagrant, $wgScriptPath is set to "/w", but pages still do /wiki [18:35:22] (03CR) 10Bartosz Dziewoński: Create a version of mediawiki.skinning.content for Parsoid HTML (031 comment) [core] - 10https://gerrit.wikimedia.org/r/130770 (owner: 10Jforrester) [18:36:19] (03Merged) 10jenkins-bot: Create a version of mediawiki.skinning.content for Parsoid HTML [core] - 10https://gerrit.wikimedia.org/r/130770 (owner: 10Jforrester) [18:36:19] gwicke: don't you think it would be suitable to create a Parsoid extension to MW that would provide stuff like this ^ or your template expanding API? [18:36:35] MatmaRex, we have that and it's a pain for users [18:36:37] (i mean, to add this to the Parsoid extension) [18:36:42] how so? [18:36:51] the only reason they need to install the extension is to get the CSS [18:37:00] well duh [18:37:05] (03PS2) 10MaxSem: Add a few schemas to SQLite tests [core] - 10https://gerrit.wikimedia.org/r/134654 [18:37:08] i don't see what's bad about this [18:37:29] installing extensions is easy [18:37:32] it makes it unnecessarily hard to use Parsoid output in MediaWiki [18:37:58] having this in core also gives it better visibility, and is the direction we are moving in anyway [18:38:15] those styles are intended to become the default styles eventually [18:38:34] i'm pretty sure that the pain installing the extension is tiny compared to installing the parsoid itself [18:38:44] parsoid is packaged [18:38:47] apt-get install parsoid [18:38:53] gwicke: are you planning to adjust core Parser to match them? [18:39:13] we might for some things [18:39:34] the other option might be to have matching styles for both for a transition period [18:39:51] it'll probably be necessary given how wmf's caching works [18:40:27] yeah, we'll see [18:40:50] it's basically a given that there will be a transition period [18:41:28] fortunately the number of differences is fairly small [18:41:55] and right now it's in a separate RL module that is loaded only when needed [18:44:59] (03CR) 10Florianschmidtwelzow: "> But in writing that I guess the problem is that it cannot overwrite?" [core] - 10https://gerrit.wikimedia.org/r/134561 (https://bugzilla.wikimedia.org/65514) (owner: 10Florianschmidtwelzow) [18:46:06] (03CR) 10Florianschmidtwelzow: "P.S.: >I'd say keep the message in core, but blank, then in WikimediaMessages it can be overridden" [core] - 10https://gerrit.wikimedia.org/r/134561 (https://bugzilla.wikimedia.org/65514) (owner: 10Florianschmidtwelzow) [18:47:59] (03PS1) 10MarkAHershberger: Avoid uncommitted transaction notices in thumb.php and img_auth.php [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/134662 [18:48:58] (03CR) 10MarkAHershberger: [C: 032] Avoid uncommitted transaction notices in thumb.php and img_auth.php [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/134662 (owner: 10MarkAHershberger) [18:52:19] (03Merged) 10jenkins-bot: Avoid uncommitted transaction notices in thumb.php and img_auth.php [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/134662 (owner: 10MarkAHershberger) [19:04:03] greg-g: are you in the office today? [19:07:15] (03PS4) 10Bartosz Dziewoński: jquery.suggestions: Support caching results to save http requests [core] - 10https://gerrit.wikimedia.org/r/134603 (https://bugzilla.wikimedia.org/65581) (owner: 10Krinkle) [19:09:36] (03PS8) 10Krinkle: mediawiki.searchSuggest: Enable result caching [core] - 10https://gerrit.wikimedia.org/r/134542 (https://bugzilla.wikimedia.org/65581) [19:16:59] (03CR) 10CSteipp: [C: 04-1] "Overall, I don't like the direction this is taking. It changes the direction of [[mw:Requests_for_comment/Login_security]], adding another" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/132952 (owner: 10Yurik) [19:21:05] chrismcmalunch: no, at home [19:25:19] (03CR) 10Jforrester: Switch from CSS to LESS and use MediaWiki's SVG fallback LESS function (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/123348 (https://bugzilla.wikimedia.org/56502) (owner: 10Jforrester) [19:32:03] (03PS11) 10Gergő Tisza: Basic funnel data logging for UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 [19:32:42] (03PS7) 10Yurik: Added BeforeHttpsRedirect hook allowing extensions to cancel forceHTTPS [core] - 10https://gerrit.wikimedia.org/r/132952 [19:35:15] (03PS8) 10Yurik: Added BeforeHttpsRedirect hook allowing extensions to cancel forceHTTPS [core] - 10https://gerrit.wikimedia.org/r/132952 [19:36:41] (03CR) 10Gergő Tisza: "Yeah, this is an issue with the test I wrote, I just can't get it to happen locally. Whatever, I'll just discard the texts. It is probably" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 (owner: 10Gergő Tisza) [19:36:53] (03PS12) 10Gergő Tisza: Basic funnel data logging for UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 [19:37:10] (03PS9) 10Yurik: Added BeforeHttpsRedirect hook allowing extensions to cancel forceHTTPS [core] - 10https://gerrit.wikimedia.org/r/132952 [19:38:10] (03CR) 10Yurik: "I added comment warning about this hook being temporary. As for Varnish - I suspect this might not be a good solution as that would requir" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/132952 (owner: 10Yurik) [19:38:20] csteipp, fixed ^ [19:39:27] (03PS1) 10Spage: Disable is_dev template compilation on ee-flow [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/134668 [19:49:59] (03CR) 10Spage: "This fix makes the code work on ee-flow-extra labs instance, but I think a $wgFlowServerCompileTemplates is the way to go." (032 comments) [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/134668 (owner: 10Spage) [19:54:16] (03CR) 10Mattflaschen: "I think there needs to be a corresponding change to zuul-config, which I think you mentioned." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134606 (owner: 10Phuedx) [20:05:50] (03CR) 10SG: [C: 031] "I honestly don't know if this is the best way to go, but hey, the original code was pretty hacky to begin with." [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/134668 (owner: 10Spage) [20:10:06] I'm losing it. WikimediaEvents references the EventLogging class. I don't see such a class defined anywhere. [20:11:27] awight: i see a role/eventlogging.pp [20:11:42] which includes eventlogging [20:11:59] ah sorry this is the WikimediaEventsHooks.php, not vagrant [20:12:32] i just meant the puppet repo, but ok [20:12:37] yurikR: Help me understand-- you're setting X-ZeroTLS in varnish for some carriers (ones that support TLS?). Why not just strip the cookie there? [20:13:01] mutante: that's actually a good place to look for dependencies, thx! [20:13:26] wow, there's a MongoDB [20:13:29] csteipp, we currently have all the info in varnish, but that makes for a very bad inflexible and error-prone design. We are migrating to this : https://www.mediawiki.org/wiki/Requests_for_comment/Unfragmented_ZERO_design [20:13:33] binasher would have loved :) [20:16:07] yurikR: So our long term plans are in conflict here :). I'll argue that making a short term change in VCL is much easier than removing a hook that's been added to core. [20:16:37] But what are your timelines for getting everything out of vcl? [20:16:39] awight: update yr code and you will find what u seek [20:17:32] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (0436296667) [core] - 10https://gerrit.wikimedia.org/r/134680 [20:19:03] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (0436296667) [core] - 10https://gerrit.wikimedia.org/r/134680 (owner: 10Jforrester) [20:19:37] csteipp, the problem is that we really don't want to have any backend logic in varnish (and that's mostly ops req, although we agree with it). How can we bring the knowledge of which zero domains support https? in reality, our long term goals agree - we are trynig to get all zero partners to IP-whitelisting, thus - ssl [20:20:48] (03PS1) 10Yurik: Migrated i18n from prev version and changed param structure [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/134682 [20:20:52] (03PS4) 10Adamw: WIP Log attempted page saves [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/94516 [20:22:05] (03CR) 10Adamw: "@DarTar: agreed, that is an excellent way to integrate. I'll play around with the existing page save complete schema and ping you when th" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/94516 (owner: 10Adamw) [20:22:07] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (0436296667) [core] - 10https://gerrit.wikimedia.org/r/134680 (owner: 10Jforrester) [20:32:19] yurikR: So X-ZeroTLS isn't about their supprot of ssl? [20:50:59] (03PS1) 10Florianschmidtwelzow: Use Userlanguage instead of content language [core] - 10https://gerrit.wikimedia.org/r/134729 (https://bugzilla.wikimedia.org/65582) [20:51:25] in 10 min in #wikimedia-office , we're talking about the square bounding box proposal + the typesafe enums proposal https://www.mediawiki.org/wiki/Architecture_meetings/RFC_review_2014-05-21 [20:52:19] cscott: today I presume you'd like https://gerrit.wikimedia.org/r/#/c/123683/ merged :) what else would you like out of today's chat? [20:53:38] (03Abandoned) 10Florianschmidtwelzow: Use Userlanguage instead of content language [core] - 10https://gerrit.wikimedia.org/r/134729 (https://bugzilla.wikimedia.org/65582) (owner: 10Florianschmidtwelzow) [20:53:46] AndyRussG: can you briefly describe what you would like out of today's chat? [20:54:02] Hi sumanah [20:54:16] hi AndyRussG [20:54:36] I guess a general path forward for any changes required to merge this to core, or an opinion on the feasability threof? [20:55:43] It's a facility that I've found really useful so far, and is used in other stuff that we'd like to propose moving to core :) [20:55:50] (03PS1) 10BryanDavis: Make `--verbose` a universal argument [tools/scap] - 10https://gerrit.wikimedia.org/r/134730 [20:58:05] I'm sure there are imrpovements to be made (for example, see MWalker's suggestions on the talk page), so if we can consider what would need to be done, and end up with something really nice that improves MW code quality, I think that'd be fantastic [20:59:18] if we can come up with some use cases too [20:59:27] Hi mwalker [20:59:33] That'd be great too, yeah [21:00:03] spoiler; the best ones I could come up with are namespaces and permissions -- which would also require dynamic entries [21:00:57] ooh hmmm 8p [21:01:14] mwalker: I think this is happening in #wikimedia-office BTW [21:01:42] yepyep [21:01:44] I'm in their [21:01:46] *there [21:06:08] (03CR) 10Brion VIBBER: [C: 032] "Looks like a fairly clean fix for default items. Provisionally +2ing" [core] - 10https://gerrit.wikimedia.org/r/123683 (https://bugzilla.wikimedia.org/63903) (owner: 10Cscott) [21:06:55] (03CR) 10jenkins-bot: [V: 04-1] Use square bounding boxes for default-sized thumbnails [core] - 10https://gerrit.wikimedia.org/r/123683 (https://bugzilla.wikimedia.org/63903) (owner: 10Cscott) [21:09:47] (03CR) 10MarkTraceur: "I used the XML file on the bug and got the following error:" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/134073 (https://bugzilla.wikimedia.org/65323) (owner: 10Dan-nl) [21:13:56] mwalker, here's a first iteration of a restface handler: https://github.com/gwicke/restface/blob/master/handlers/genhandler.js [21:15:33] csteipp, not sure what you mean by X-ZeroTLS -- varnish uses puppet templates/varnish/zero.inc.vcl.erb with lots of IF/ELSE to mimic the settings we have in wiki about each carrier. Keeping those settings in sync is a major pain (as well as it being error prone and time consuming). The only "normal" way we have to bring data to varnish is via the IP lookup - where backend exports a map of IP ranges to IDs, and varnish uses that to tag traffic. [21:17:35] (03PS2) 10Hashar: Fix table setup to support SQLite [extensions/Petition] - 10https://gerrit.wikimedia.org/r/134604 (https://bugzilla.wikimedia.org/65488) (owner: 10Pcoombe) [21:17:43] one way we could make it "nice" is by exporting all IPs that are ok to be stripped of cookies, but still - you are tying varnish logic with backend - because both have to know which headers to set/clear [21:18:11] check with bblack (he's not on this channel) [21:18:39] (03CR) 10Hashar: [C: 031] "Can you double check MySQL is still working? It is untested by Jenkins and I am too lazy to read mysql doc right now :-D" [extensions/Petition] - 10https://gerrit.wikimedia.org/r/134604 (https://bugzilla.wikimedia.org/65488) (owner: 10Pcoombe) [21:22:40] yurikR: Yes, that big if/else is what I mean. Is brandon the one doing the vcl for you guys? [21:23:01] csteipp, we update that if/else ourselves, he is the one +2ing [21:23:24] MaxSem, |||hidden||| is a good nick [21:24:55] (03PS1) 10Cscott: Merge "Localisation updates from https://translatewiki.net." [core] - 10https://gerrit.wikimedia.org/r/134734 [21:26:07] (03CR) 10Krinkle: "o_O?" [core] - 10https://gerrit.wikimedia.org/r/134734 (owner: 10Cscott) [21:26:23] crap. [21:27:08] don't drink and rebase, folks [21:27:11] not even coffee [21:27:17] cscott: been working on 'master' and then pull --rebase? [21:27:33] cscott: hey, you're here [21:28:03] (03Abandoned) 10Cscott: Merge "Localisation updates from https://translatewiki.net." [core] - 10https://gerrit.wikimedia.org/r/134734 (owner: 10Cscott) [21:30:27] (03PS9) 10Cscott: Use square bounding boxes for default-sized thumbnails [core] - 10https://gerrit.wikimedia.org/r/123683 (https://bugzilla.wikimedia.org/63903) [21:32:01] (03PS4) 10Cscott: Use square bounding boxes for 'upright' and change default scale factor. [core] - 10https://gerrit.wikimedia.org/r/133600 (https://bugzilla.wikimedia.org/63904) [21:36:40] (03PS4) 10Krinkle: Move doMigrateUserOptions() to run after creating user_password_expires [core] - 10https://gerrit.wikimedia.org/r/133411 (https://bugzilla.wikimedia.org/63677) (owner: 10Withoutaname) [21:41:05] (03CR) 10Cscott: "TimStarling notes that this needs to be deployed carefully to avoid slamming the scalers with requests." [core] - 10https://gerrit.wikimedia.org/r/123683 (https://bugzilla.wikimedia.org/63903) (owner: 10Cscott) [21:55:04] (03PS1) 10Spage: Fix fatal in topic history. [extensions/Flow] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134740 (https://bugzilla.wikimedia.org/65051) [22:02:54] greg-g: Heya. Flow wants to backport a one-line fix, I added it to today's SWAT. Hope that's OK [22:03:27] (03CR) 10Pcoombe: "Yes, I've tested with MySQL too and it is still working." [extensions/Petition] - 10https://gerrit.wikimedia.org/r/134604 (https://bugzilla.wikimedia.org/65488) (owner: 10Pcoombe) [22:03:29] coolio [22:11:50] greg-g, SWAT members: do you prefer a gerrit changing the extension or a gerrit bumping the extension submodule in core? I see both kinds on Deployments page. [22:12:29] I'm not sure, honestly. RoanKattouw mwalker MaxSem ^^ [22:12:47] (03CR) 10BryanDavis: [C: 032] Initial commit for [[:mw:Extension:MolHandler]] [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/133069 (owner: 10Rillke) [22:12:47] (03Merged) 10jenkins-bot: Initial commit for [[:mw:Extension:MolHandler]] [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/133069 (owner: 10Rillke) [22:12:52] (03CR) 10Spage: [C: 032] "Original is merged, and this fixes the bug for me on my local wiki running 1.24wmf5." [extensions/Flow] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134740 (https://bugzilla.wikimedia.org/65051) (owner: 10Spage) [22:13:08] (03Merged) 10jenkins-bot: Fix fatal in topic history. [extensions/Flow] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134740 (https://bugzilla.wikimedia.org/65051) (owner: 10Spage) [22:13:17] spagewmf, well - you can't really deploy just an extension change [22:13:33] so they'll have to be translated into submodule updates:) [22:13:52] MaxSem: right, by whom? the joy of passive voice :) [22:14:19] (I was always so bad with using passive voice) [22:14:24] PREFERRABLY BY PERSON REQUEStiNG [22:14:29] s/was/am/ [22:14:49] spagewmf, it's nice if the submodule pointer is updated [22:15:03] (03CR) 10Tim Starling: [C: 032] Use square bounding boxes for default-sized thumbnails [core] - 10https://gerrit.wikimedia.org/r/123683 (https://bugzilla.wikimedia.org/63903) (owner: 10Cscott) [22:15:07] but... if it isn't it's not a big deal because we can then merge updates if other people haven't done it [22:15:08] RoanKattouw: nvm, you can ignore, others answered [22:15:40] I guess in the ideal world everyone would push their submodule updates [22:15:51] which would obviate the need for commit bundling [22:16:37] MaxSem, mwalker: fine, the bump will be done. It was noticed that existing gerrits on the page were often the former ;) [22:16:55] yep [22:17:11] someone has to do it; I don't mind if its me [22:17:23] but its less work and less waiting for jenkins if the requester does it [22:18:01] (03Merged) 10jenkins-bot: Use square bounding boxes for default-sized thumbnails [core] - 10https://gerrit.wikimedia.org/r/123683 (https://bugzilla.wikimedia.org/63903) (owner: 10Cscott) [22:22:37] ori: can you please respond to the email about laptops for the presentation tonight? cndiv needs to know! :) [22:25:49] (03CR) 10Cscott: "Discussed in https://www.mediawiki.org/wiki/Architecture_meetings/RFC_review_2014-05-21" [core] - 10https://gerrit.wikimedia.org/r/133600 (https://bugzilla.wikimedia.org/63904) (owner: 10Cscott) [22:26:11] (03CR) 10Mattflaschen: [C: 04-1] "See inline." (0310 comments) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/133668 (https://bugzilla.wikimedia.org/65385) (owner: 10Ori.livneh) [22:34:50] (03CR) 10Mattflaschen: "Also, can someone explain exactly how to set up EventLogging to run tox (and the command to do so)?" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/133668 (https://bugzilla.wikimedia.org/65385) (owner: 10Ori.livneh) [22:43:14] (03PS1) 10Spage: Update Flow with backported bug 65051 fix [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134746 [22:50:06] cscott: AndyRussG - ok, just sent a summary note to wikitech-l -- thanks for your work [22:50:41] (03PS1) 10Aaron Schulz: Removed begin/commit calls that result in error spam [core] - 10https://gerrit.wikimedia.org/r/134751 [22:59:09] (03PS1) 10CSteipp: WIP: Respect wgForceHttps on login [core] - 10https://gerrit.wikimedia.org/r/134756 (https://bugzilla.wikimedia.org/61048) [23:00:26] sumanah: cool, you're welcome & thank you too :) [23:00:31] :) [23:08:08] (03PS1) 10Jack Phoenix: Ran stylize.php. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/134760 [23:09:01] Hi I am trying to use https://www.mediawiki.org/wiki/Extension:Semantic_Rating to rate pages. I was able to add ratings to the page while creating a new page. https://mediacru.sh/m6sSuhUJLuR9 , but I wish to enable users re-rate a existing page. How can I do that any suggestions? [23:09:45] (03CR) 10Jack Phoenix: [C: 032 V: 032] Ran stylize.php. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/134760 (owner: 10Jack Phoenix) [23:10:57] legoktm: hey there [23:12:13] I am a fool. Monday is Memorial Day [23:12:17] (03CR) 10MaxSem: [C: 032 V: 032] Update Flow with backported bug 65051 fix [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134746 (owner: 10Spage) [23:14:34] (03CR) 10Cscott: "woot!" [core] - 10https://gerrit.wikimedia.org/r/123683 (https://bugzilla.wikimedia.org/63903) (owner: 10Cscott) [23:14:56] legoktm: what time Wed works for you? [23:18:07] (03PS1) 10Jack Phoenix: Got rid of short PHP tags, those are bad for your health. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/134762 [23:19:02] (03PS1) 10MaxSem: MMV: https://gerrit.wikimedia.org/r/#/c/134750/ [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134764 [23:19:26] (03CR) 10MaxSem: [C: 032 V: 032] MMV: https://gerrit.wikimedia.org/r/#/c/134750/ [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134764 (owner: 10MaxSem) [23:20:12] (03CR) 10Jack Phoenix: [C: 032 V: 032] Got rid of short PHP tags, those are bad for your health. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/134762 (owner: 10Jack Phoenix) [23:21:57] (03CR) 10Brian Wolff: "I'm more concerned about the case where the job doesn't go in the queue at all. I'm not really sure how this would happen, but it appears " [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/133994 (https://bugzilla.wikimedia.org/61401) (owner: 10Brian Wolff) [23:22:18] (03CR) 10AndyRussG: [C: 032] whitespace fixup [core] - 10https://gerrit.wikimedia.org/r/134574 (owner: 10Adamw) [23:26:02] (03CR) 10Aaron Schulz: "If the insert failed you should get an exception. Wouldn't that rollback the transcode table updates (or are those separated out?)." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/133994 (https://bugzilla.wikimedia.org/61401) (owner: 10Brian Wolff) [23:29:12] (03Merged) 10jenkins-bot: whitespace fixup [core] - 10https://gerrit.wikimedia.org/r/134574 (owner: 10Adamw) [23:36:02] YuviPanda, ping for wikibugs - it seems to be AWOL ;) [23:36:12] oh, [23:36:14] let me check [23:36:41] (someone just sent an email to wikitech-l pointing it out) [23:36:43] I've restarted it [23:36:46] (03CR) 10Brian Wolff: "There is no use of transactions in TMH whatsoever (which is just great), also that code block is not in a try/catch, so the implicit trans" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/133994 (https://bugzilla.wikimedia.org/61401) (owner: 10Brian Wolff) [23:37:44] quiddity: can you poke a bug? [23:37:52] sure [23:38:13] (03CR) 10Brian Wolff: "I also have not heard any complaints from users of "Error of type MWException"" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/133994 (https://bugzilla.wikimedia.org/61401) (owner: 10Brian Wolff) [23:39:23] quiddity: no luck? [23:39:25] YuviPanda, I poked a Flow bug. Nothing happened. [23:40:36] (03CR) 10Isarra: "Ewww." [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/134762 (owner: 10Jack Phoenix) [23:40:37] (03PS1) 10Jack Phoenix: Applied standard MediaWiki coding conventions. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/134768 [23:40:46] quiddity: mind poking again? [23:41:03] (03CR) 10Jack Phoenix: [C: 032 V: 032] Applied standard MediaWiki coding conventions. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/134768 (owner: 10Jack Phoenix) [23:42:21] (03CR) 10Isarra: "Less ew. Aside from those horrible variable names." [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/134768 (owner: 10Jack Phoenix) [23:42:39] YuviPanda, 2 secs, trying to find a non-random one ;) [23:43:07] (03CR) 10Isarra: "This is me suggesting you do that next or something." [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/134768 (owner: 10Jack Phoenix) [23:45:35] YuviPanda, bug poked. Nothing happened. [23:45:51] quiddity: yeah, some problem in the email relay from wikibugs-l to the bot [23:46:00] quiddity: https://lists.wikimedia.org/mailman/listinfo/wikibugs-l has no archives either, so I can't check that :( [23:46:26] foo :/ [23:46:35] mirror? [23:46:59] e.g. http://www.mail-archive.com/wikibugs-l@lists.wikimedia.org/ [23:47:20] Its how I see what the secret security bugs are that accidentally weren't filed as security [23:47:26] err, I mean,... I would never do that [23:47:49] bawolff: haha ;P [23:47:49] quiddity: was the bug you poked on http://www.mail-archive.com/wikibugs-l@lists.wikimedia.org/ [23:48:19] quiddity: I'm also not very familiar with that part of the codebase :( [23:48:21] quiddity, yup, the top Popups/Hovercards one [23:48:34] quiddity: right. so the problem is not the mailing list [23:49:02] it's the thing that receives email and puts it in redis [23:49:44] quiddity: why did you just ping yourself? [23:50:24] PiRSquared, Errrrrr.... >.> Because I clearly have been sitting in this chair for too many hours in a row! Thanks! [23:50:36] * quiddity wanders off for some fresh air. [23:52:11] YuviPanda: See, I had assumed we'd just fixed all the bugs [23:52:21] marktraceur: never bug 1 [23:52:44] YuviPanda: Hey man, we have a full-on tech writer now [23:52:56] and we also stopped writing code! :ED [23:54:22] bawolff, I used to subscribe to that list and move stuff to security where appropriate [23:54:43] Of course, this meant that I was on the CC list for such security bugs and could therefore see any changes/comments made etc. [23:55:32] I was subscribed to the list a long time ago, partly as a way to keep track of interesting things that are exploding, but it just became too much [23:56:39] (03CR) 10CSteipp: "I still would rather see this done in Varnish (maybe we can talk with brandon about it next week), but I'm not going to totally veto it, s" [core] - 10https://gerrit.wikimedia.org/r/132952 (owner: 10Yurik)