[00:00:32] (03CR) 10Parent5446: [C: 04-1] "I'm more partial to an approach where the time window is stored, that way using a token will invalidate all tokens before it." [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/132783 (https://bugzilla.wikimedia.org/53196) (owner: 10Parent5446) [00:07:43] (03PS1) 10Parent5446: Refactor extension key storage [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/134050 [00:07:45] (03CR) 10jenkins-bot: [V: 04-1] Refactor extension key storage [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/134050 (owner: 10Parent5446) [00:08:00] (03CR) 10Parent5446: [C: 04-1] "Need to remove extraneous database columns" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/134050 (owner: 10Parent5446) [00:12:54] (03PS2) 10Parent5446: Cache OATH tokens to avoid replay [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/132783 (https://bugzilla.wikimedia.org/53196) [00:18:08] 3Wikimedia / 3Deployment systems: HHBC cache creation fails with SIGSEGV on osmium - 10https://bugzilla.wikimedia.org/65351#c3 (10Tim Starling) This is apparently fixed in the latest HHVM master (and in my dev branch, which was recently rebased). [00:19:25] 3MediaWiki / 3JobQueue: HHVM fails to unserialize() value in JobQueueRedis.php:798 - 10https://bugzilla.wikimedia.org/65466 (10Ori Livneh) 3NEW p:3Unprio s:3normal a:3None Running /usr/local/bin/jobs-loop.sh on osmium with WIKIDEBUG=1 floods the output buffer with the following error message: Notice... [00:29:48] (03PS3) 10Parent5446: Cache OATH tokens to avoid replay [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/132783 (https://bugzilla.wikimedia.org/53196) [00:32:01] (03PS2) 10Parent5446: Make authentication window size and leniency configurable [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/132784 (https://bugzilla.wikimedia.org/53194) [00:32:12] (03CR) 10Parent5446: [C: 04-1] "PS2: Rebase" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/132784 (https://bugzilla.wikimedia.org/53194) (owner: 10Parent5446) [00:33:02] (03PS3) 10Parent5446: Make authentication window size and leniency configurable [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/132784 (https://bugzilla.wikimedia.org/53194) [00:33:11] (03CR) 10Parent5446: Make authentication window size and leniency configurable (032 comments) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/132784 (https://bugzilla.wikimedia.org/53194) (owner: 10Parent5446) [00:39:46] (03PS2) 10Parent5446: Refactor extension key storage [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/134050 [00:39:55] (03CR) 10Parent5446: [C: 04-1] "PS2: Rebase" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/134050 (owner: 10Parent5446) [00:43:05] (03PS1) 10Tim Starling: Fix error message when swap is disabled [core] - 10https://gerrit.wikimedia.org/r/134051 (https://bugzilla.wikimedia.org/65465) [00:58:53] 3Wikimedia / 3Site requests: New England Wikimedians website - 10https://bugzilla.wikimedia.org/64557#c44 (10jeremyb) (In reply to Kevin Rutherford from comment #0) > upload is allowed, although we will route people to > Commons unless there is a real need to upload there. Should we then restrict upload to... [01:43:38] 3MediaWiki / 3JobQueue: HHVM fails to unserialize() value in JobQueueRedis.php:798 - 10https://bugzilla.wikimedia.org/65466#c1 (10Tim Starling) strace shows: sendto(9, "*9\r\n$7\r\nEVALSHA\r\n$40\r\n46eccb844b00c898d68cb06502b13a906ff3d6a8\r\n$46\r\nfrwiktionary:jobqueue:refreshLinks:l-unclaimed\r\n$45\r\nf... [01:51:38] 3MediaWiki / 3JobQueue: HHVM fails to unserialize() value in JobQueueRedis.php:798 - 10https://bugzilla.wikimedia.org/65466#c2 (10Tim Starling) This is https://github.com/facebook/hhvm/pull/2555 (a fixed bug). [01:56:52] 3MediaWiki / 3JobQueue: HHVM fails to unserialize() value in JobQueueRedis.php:798 - 10https://bugzilla.wikimedia.org/65466#c3 (10Tim Starling) Rather, the missing numkeys was #2555, the error handling issue was fixed in https://github.com/facebook/hhvm/pull/2603 [02:03:22] 3Wikimedia / 3Site requests: New England Wikimedians website - 10https://bugzilla.wikimedia.org/64557#c45 (10jeremyb) (In reply to Kevin Rutherford from comment #43) > We actually discussed the names earlier, and consensus was to not do a > "wikimediane.org" domain. No, I said you can't use that domain with... [02:26:39] (03CR) 10Ori.livneh: [C: 032] "Thanks" [core] - 10https://gerrit.wikimedia.org/r/134051 (https://bugzilla.wikimedia.org/65465) (owner: 10Tim Starling) [02:29:35] (03Merged) 10jenkins-bot: Fix error message when swap is disabled [core] - 10https://gerrit.wikimedia.org/r/134051 (https://bugzilla.wikimedia.org/65465) (owner: 10Tim Starling) [02:36:53] (03CR) 10Withoutaname: "My preference would have been to declare it as a global var in the "form values" section on line 241: $edittoken = '';" [core] - 10https://gerrit.wikimedia.org/r/134047 (owner: 10Adamw) [02:50:15] (03PS3) 10Parent5446: Refactor extension key storage [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/134050 [02:56:08] 3Wikimedia / 3General/Unknown: "memory.memsw.limit_in_bytes: Permission denied" when running mwscript eval.php enwiki on osmium (HHVM) - 10https://bugzilla.wikimedia.org/65465 (10Ori Livneh) 5PAT>3RES/FIX [03:16:07] 3MediaWiki extensions / 3EducationProgram: Courses link is not showing up in the gadgets/extension section of compact personal bar flyout - 10https://bugzilla.wikimedia.org/65467 (10Jared Zimmerman (WMF)) [03:16:22] 3MediaWiki / 3Skin and page rendering: Consolidate personal portlet links into collapsed control or dropdown - 10https://bugzilla.wikimedia.org/44448 (10Jared Zimmerman (WMF)) [03:44:07] (03PS5) 10Santhosh: Rewrite the server as stateless; define REST APIs [services/cxserver] - 10https://gerrit.wikimedia.org/r/132931 [03:54:00] (03CR) 10Adamw: "@Withoutaname: I agree, what you suggest will better match the existing code." [core] - 10https://gerrit.wikimedia.org/r/134047 (owner: 10Adamw) [04:16:44] (03CR) 10Parent5446: [C: 032] Avoid fatals in begin/commit/rollback if close() was called [core] - 10https://gerrit.wikimedia.org/r/133751 (owner: 10Aaron Schulz) [04:20:02] (03Merged) 10jenkins-bot: Avoid fatals in begin/commit/rollback if close() was called [core] - 10https://gerrit.wikimedia.org/r/133751 (owner: 10Aaron Schulz) [04:44:01] (03PS1) 10Legoktm: Only iterate through result set once [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/134054 [04:44:03] (03PS1) 10Legoktm: Use CheckUserHooks::getClientIPfromXFF when reading XFF header [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/134055 [04:44:05] (03PS1) 10Legoktm: Use a better User-Agent parser [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/134056 [04:46:13] (03PS3) 10Dan-nl: Max title length [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/133409 (https://bugzilla.wikimedia.org/65323) [04:46:22] (03CR) 10jenkins-bot: [V: 04-1] Max title length [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/133409 (https://bugzilla.wikimedia.org/65323) (owner: 10Dan-nl) [04:46:33] (03CR) 10Legoktm: [C: 032 V: 032] Only iterate through result set once [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/134054 (owner: 10Legoktm) [04:47:47] (03PS1) 10Gnosygnu: v1.5.3.1 [xowa] - 10https://gerrit.wikimedia.org/r/134057 [04:49:11] (03CR) 10Dan-nl: "* added some tests" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/133409 (https://bugzilla.wikimedia.org/65323) (owner: 10Dan-nl) [05:10:23] 3MediaWiki / 3General/Unknown: "Tag filter" field at Special:Log and Special:Contributions should support autocompletion - 10https://bugzilla.wikimedia.org/48243#c2 (10John Mark Vandenberg) (In reply to MZMcBride from comment #0) > The "Tag filter" field at Special:Log and Special:Contributions should > supp... [05:13:29] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/132914 (owner: 10Gnosygnu) [05:13:48] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/134057 (owner: 10Gnosygnu) [05:18:52] 3MediaWiki / 3Special pages: Special:Tags - Tagged changes to show total of only currently visible logged numbers - 10https://bugzilla.wikimedia.org/48369 (10John Mark Vandenberg) [05:20:51] (03PS7) 10BryanDavis: Add CentralAuth role [vagrant] - 10https://gerrit.wikimedia.org/r/133757 (https://bugzilla.wikimedia.org/52306) [05:20:53] (03CR) 10jenkins-bot: [V: 04-1] Add CentralAuth role [vagrant] - 10https://gerrit.wikimedia.org/r/133757 (https://bugzilla.wikimedia.org/52306) (owner: 10BryanDavis) [05:23:50] (03PS8) 10BryanDavis: Add CentralAuth role [vagrant] - 10https://gerrit.wikimedia.org/r/133757 (https://bugzilla.wikimedia.org/52306) [05:24:39] (03CR) 10BryanDavis: "Legoktm: I think AntiSpoof is working now." [vagrant] - 10https://gerrit.wikimedia.org/r/133757 (https://bugzilla.wikimedia.org/52306) (owner: 10BryanDavis) [05:27:26] (03CR) 10Legoktm: [C: 04-1] Never get the content of pseudo-section "new" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/134046 (owner: 10Adamw) [05:33:07] 3MediaWiki extensions / 3UploadWizard: UploadWizard: Flickr uploading broken - browser redirect the user to the result of the API request - 10https://bugzilla.wikimedia.org/65406#c6 (10Rainer Rillke @commons.wikimedia) (In reply to Cometstyles from comment #5) > Any updates on this? It's awaiting code review... [05:35:54] (03CR) 10Legoktm: "I believe it's dangerous because it's technically possible for multiple edits to the same page to have the timestamp in the case of very r" [core] - 10https://gerrit.wikimedia.org/r/134049 (owner: 10Adamw) [05:37:01] (03PS2) 10Adamw: (bug 56849) Deprecate dangerous edittime-based content update functions [core] - 10https://gerrit.wikimedia.org/r/134049 [05:45:34] (03Abandoned) 10Adamw: Never get the content of pseudo-section "new" [core] - 10https://gerrit.wikimedia.org/r/134046 (owner: 10Adamw) [05:45:48] (03CR) 10Amire80: [C: 032] Rewrite the server as stateless; define REST APIs [services/cxserver] - 10https://gerrit.wikimedia.org/r/132931 (owner: 10Santhosh) [05:46:24] (03Merged) 10jenkins-bot: Rewrite the server as stateless; define REST APIs [services/cxserver] - 10https://gerrit.wikimedia.org/r/132931 (owner: 10Santhosh) [05:47:06] (03CR) 10Adamw: Never get the content of pseudo-section "new" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/134046 (owner: 10Adamw) [05:49:14] (03PS2) 10Adamw: Minor cleanup of edit code [core] - 10https://gerrit.wikimedia.org/r/134047 [05:49:41] (03PS3) 10Adamw: (bug 56849) Deprecate dangerous edittime-based content update functions [core] - 10https://gerrit.wikimedia.org/r/134049 [05:49:49] (03PS14) 10Adamw: WIP (bug 56849) Pass true oldid for atomic page save [core] - 10https://gerrit.wikimedia.org/r/94584 [05:53:54] 3Wikimedia / 3General/Unknown: Dropping rc_moved_to_title/rc_moved_to_ns on wmf databases - 10https://bugzilla.wikimedia.org/49191 (10Sean Pringle) a:3Sean Pringle [05:54:08] 3Wikimedia / 3General/Unknown: Dropping rc_cur_time on wmf databases - 10https://bugzilla.wikimedia.org/65448 (10Sean Pringle) a:3Sean Pringle [05:55:48] (03CR) 10jenkins-bot: [V: 04-1] WIP (bug 56849) Pass true oldid for atomic page save [core] - 10https://gerrit.wikimedia.org/r/94584 (owner: 10Adamw) [05:59:09] 3MediaWiki / 3JavaScript: Redirects to section are off in Firefox 29.0.1 if there are collapsed elements above the section - 10https://bugzilla.wikimedia.org/65468 (10Lupo) 3NEW p:3Unprio s:3normal a:3None From https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28technical%29&oldid=60... [06:03:05] (03CR) 10Wctaiwan: [C: 031] "Tested; looks good to me notwithstanding the comments on patch set 2, which I don't know enough to commment on." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/91630 (https://bugzilla.wikimedia.org/55338) (owner: 10Gerrit Patch Uploader) [06:13:07] 3MediaWiki / 3Recent changes: Patroled edits are displayed on Recent Changes even if the URL parameter "hidepatrolled" is set to "1" - 10https://bugzilla.wikimedia.org/45174#c2 (10John Mark Vandenberg) 5NEW>3RES/INV Helder, I think this is working correctly now (checked on two wikis), *and* the attached... [06:31:42] (03PS2) 10Legoktm: Use a better User-Agent parser [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/134056 [07:47:08] 3Wikimedia / 3General/Unknown: Whitelist OASIS OpenDocument file format - 10https://bugzilla.wikimedia.org/2089#c47 (10dacuetu) What was the result of this? It might affect this rfc https://meta.wikimedia.org/wiki/Requests_for_comment/How_to_deal_with_open_datasets [07:51:09] 3MediaWiki / 3Unit tests: mediawiki.toc: toggleToc failing on master - 10https://bugzilla.wikimedia.org/65469 (10Gilles Dubuc) 3NEW p:3Unprio s:3normal a:3None 3rd and 4th assertions fail [08:06:40] 3MediaWiki extensions / 3VectorBeta: CPB: hover doesn't work on touch interfaces - 10https://bugzilla.wikimedia.org/65470 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Using the compact personal bar on a tablet is not quite possible. The username element works as a link. Tapping it shows the m... [08:10:54] (03CR) 10Steinsplitter: [C: 031] Wait until iframe is fully loaded before submitting form [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) (owner: 10Rillke) [08:12:08] 3MediaWiki / 3Parser: RTL/bidirectional issues (tracking) - 10https://bugzilla.wikimedia.org/745 (10Amir E. Aharoni) [08:27:50] (03CR) 10Rillke: Wait until iframe is fully loaded before submitting form (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) (owner: 10Rillke) [08:34:40] 3MediaWiki extensions / 3WikidataClient: every search results in "Query error" next to search results in hebrew wiki - 10https://bugzilla.wikimedia.org/65472 (10matanya) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Created attachment 15435 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15435&act... [08:36:56] (03PS15) 10Adamw: WIP (bug 56849) Pass true oldid for atomic page save [core] - 10https://gerrit.wikimedia.org/r/94584 [08:38:23] anyone happen to know how to add a mediawiki template to the mw instance that runs with the jenkins tests? [08:40:30] (03CR) 10jenkins-bot: [V: 04-1] WIP (bug 56849) Pass true oldid for atomic page save [core] - 10https://gerrit.wikimedia.org/r/94584 (owner: 10Adamw) [08:50:35] (03PS1) 10Shirayuki: Make "helppage" link relative [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/134063 [08:56:12] 3MediaWiki / 3Skin and page rendering: Markup accessibility issues (tracking) - 10https://bugzilla.wikimedia.org/367 (10Derk-Jan Hartman) [08:56:30] (03CR) 10Nemo bis: "This is ok, but better would be to do as we did in core with" [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/134063 (owner: 10Shirayuki) [09:06:26] 3MediaWiki / 3Unit tests: mediawiki.toc: toggleToc failing on master - 10https://bugzilla.wikimedia.org/65469#c1 (10Gilles Dubuc) 5NEW>3RES/WOR And it stopped. Was happened on my vm, so I'm going to say it was Gremlins. [09:11:57] 3MediaWiki extensions / 3WikidataClient: every search results in "Query error" next to search results in hebrew wiki - 10https://bugzilla.wikimedia.org/65472#c1 (10Beta16) Also in it.wiki [09:16:41] 3MediaWiki / 3JavaScript: Redirects to section are off in Firefox 29.0.1 if there are collapsed elements above the section - 10https://bugzilla.wikimedia.org/65468#c1 (10Andre Klapper) p:5Unprio>3Normal I can confirm this for Firefox 29; comments in Village Pump say that there is no issue in Firefox 28. [09:17:26] 3MediaWiki / 3JavaScript: Redirects to section are off in Firefox 29.0.1 if there are collapsed elements above the section - 10https://bugzilla.wikimedia.org/65468#c2 (10Andre Klapper) ...and clicking the browser's address bar and pressing Enter fixes the problem. [09:18:56] 3MediaWiki / 3JobQueue: HHVM fails to unserialize() value in JobQueueRedis.php:798 - 10https://bugzilla.wikimedia.org/65466 (10Andre Klapper) p:5Unprio>3Normal [09:19:27] 3MediaWiki / 3Skin and page rendering: Markup accessibility issues (tracking) - 10https://bugzilla.wikimedia.org/367 (10Derk-Jan Hartman) [09:19:27] 3MediaWiki extensions / 3WikiLexicalData/OmegaWiki: Language statistics pages use wrong base to compute percentages - 10https://bugzilla.wikimedia.org/65456#c2 (10Andre Klapper) (In reply to Purodha Blissenbach from comment #1) > Since git/gerrit do not work for me You could try http://tools.wmflabs.org/ger... [09:23:28] 3MediaWiki extensions / 3General/Unknown: Resized raster image does not succeed metadata of the original file - 10https://bugzilla.wikimedia.org/65475 (10Thomash Lee) 3NEW p:3Unprio s:3enhanc a:3None When the image file is resized or rendered to a raster image (from vector source) by wiki software, t... [09:23:56] 3MediaWiki extensions / 3VectorBeta: Echo popup goes off-screen with CPB in RTL wikis - 10https://bugzilla.wikimedia.org/65471 (10Kunal Mehta (Legoktm)) [09:24:26] 3MediaWiki / 3Skin and page rendering: Remove indentation from sidebar links - 10https://bugzilla.wikimedia.org/65444#c3 (10Andre Klapper) 5NEW>3UNC Why is this a code-update-regression, and what is the actual problem? I guess they are not meant to be aligned, because these section were collapsible a whi... [09:38:41] 3MediaWiki / 3Sites: Canonical URL is not a canonical URL - 10https://bugzilla.wikimedia.org/65402 (10Andre Klapper) p:5Unprio>3Normal [09:39:42] 3Wikimedia / 3Extension setup: Enable Extension:News on Russian Wikinews - 10https://bugzilla.wikimedia.org/65391#c3 (10Andre Klapper) (In reply to Gryllida from comment #2) > Yes, it is. (ON English Wikinews.) Hmm, https://en.wikinews.org/wiki/Special:Version does not list it and I don't see anything in ht... [09:41:26] 3MediaWiki extensions / 3Translate: Translation help - 10https://bugzilla.wikimedia.org/65334 (10Andre Klapper) [09:43:57] 3MediaWiki extensions / 3Score: crackling at start of OGG renditions of MIDI files (fixed in TiMidity++ 2.14.0) - 10https://bugzilla.wikimedia.org/48029 (10Andre Klapper) [09:43:57] 3Wikimedia / 3General/Unknown: Ogg files stammer - 10https://bugzilla.wikimedia.org/40590#c12 (10Andre Klapper) Reminds me of bug 48029. [09:46:12] 3Wikimedia / 3Extension setup: Install PageNotice and ImageSizeInfoFunctions extensions for mlwiki - 10https://bugzilla.wikimedia.org/17426#c12 (10Andre Klapper) 5NEW>3UNC Sadik: Please reply to comment 10-11. [09:48:24] (03CR) 10JGonera: "What are the steps to reproduce issues with videos in the previous patch?" [core] - 10https://gerrit.wikimedia.org/r/133301 (https://bugzilla.wikimedia.org/65160) (owner: 10Jforrester) [09:49:57] 3MediaWiki extensions / 3Translate: Translation help - 10https://bugzilla.wikimedia.org/65334#c3 (10NehalDaveND) Yes.. in this page https://sa.wikipedia.org/wiki/%E0%A4%B5%E0%A4%BF%E0%A4%B6%E0%A5%87%E0%A4%B7%E0%A4%AE%E0%A5%8D:%E0%A4%A8%E0%A4%B5%E0%A5%80%E0%A4%A8%E0%A4%A4%E0%A4%AE_%E0%A4%AA%E0%A4%B0%E0%A4%BF%... [09:51:41] 3MediaWiki extensions / 3Translate: Translation help - 10https://bugzilla.wikimedia.org/65334#c4 (10NehalDaveND) see this file http://translatewiki.net/wiki/File:Help.jpg [09:58:56] 3MediaWiki / 3JavaScript: Redirects to section are off in Firefox 29.0.1 if there are collapsed elements above the section - 10https://bugzilla.wikimedia.org/65468#c3 (10Lupo) Another thought: mediawiki.action.view.redirectToFragment.js does if ( window.location.hash === fragment ) { window.location.h... [09:59:12] 3MediaWiki / 3Parser: RTL/bidirectional issues (tracking) - 10https://bugzilla.wikimedia.org/745 (10Amir E. Aharoni) [09:59:14] 3MediaWiki extensions / 3VectorBeta: CPB: user name is incorrectly aligned in RTL wikis in Firefox - 10https://bugzilla.wikimedia.org/65476 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Created attachment 15436 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15436&action=edit a screensh... [09:59:54] (03CR) 10JGonera: [C: 04-2] "-2 so that it doesn't get merged (only a proof of concept)." [core] - 10https://gerrit.wikimedia.org/r/133683 (owner: 10Pginer) [10:06:47] (03PS2) 10Adamw: opportunity to reuse Title::getEditURL() [core] - 10https://gerrit.wikimedia.org/r/134045 [10:06:57] (03CR) 10Bartosz Dziewoński: [C: 032] opportunity to reuse Title::getEditURL() [core] - 10https://gerrit.wikimedia.org/r/134045 (owner: 10Adamw) [10:09:22] (03CR) 10Bartosz Dziewoński: [C: 032] jquery.tipsy: Merge some upstream changes [core] - 10https://gerrit.wikimedia.org/r/133973 (owner: 10TheDJ) [10:09:47] (03CR) 10Bartosz Dziewoński: [C: 032] jquery.tipsy: Add viewable region bounds checking [core] - 10https://gerrit.wikimedia.org/r/133975 (https://bugzilla.wikimedia.org/44382) (owner: 10TheDJ) [10:11:16] (03Merged) 10jenkins-bot: opportunity to reuse Title::getEditURL() [core] - 10https://gerrit.wikimedia.org/r/134045 (owner: 10Adamw) [10:11:56] 3MediaWiki extensions / 3VectorBeta: CPB: user name is incorrectly aligned in RTL wikis in Firefox - 10https://bugzilla.wikimedia.org/65476#c1 (10Amir E. Aharoni) I am inviting some non-MediaWiki people to test this, so here are more detailed instructions to reproduce: 1. Log in to the Hebrew Wikipedia. 2.... [10:12:39] (03Merged) 10jenkins-bot: jquery.tipsy: Merge some upstream changes [core] - 10https://gerrit.wikimedia.org/r/133973 (owner: 10TheDJ) [10:13:43] (03Merged) 10jenkins-bot: jquery.tipsy: Add viewable region bounds checking [core] - 10https://gerrit.wikimedia.org/r/133975 (https://bugzilla.wikimedia.org/44382) (owner: 10TheDJ) [10:15:11] 3Analytics / 3Wikimetrics: Cannot delete cohort if cohort is empty. - 10https://bugzilla.wikimedia.org/64724 (10nuria) 5PAT>3RES/FIX [10:16:41] 3Analytics / 3Wikimetrics: Worker processes left hanging - 10https://bugzilla.wikimedia.org/63819 (10nuria) 5PAT>3RES/FIX [10:23:57] 3MediaWiki / 3Change tagging: Suggest tags for tag filter - 10https://bugzilla.wikimedia.org/21383#c1 (10John Mark Vandenberg) *** Bug 48243 has been marked as a duplicate of this bug. *** [10:23:57] 3MediaWiki / 3General/Unknown: "Tag filter" field at Special:Log and Special:Contributions should support autocompletion - 10https://bugzilla.wikimedia.org/48243#c3 (10John Mark Vandenberg) 5ASS>3RES/DUP *** This bug has been marked as a duplicate of bug 21383 *** [10:26:46] aharoni: around ? [10:26:55] around [10:27:33] hi, how can i connect wikimeida gerrit to github? like you did in: https://github.com/amire80 [10:28:08] aharoni: if it is gerrit at all [10:29:06] matanya: link your email used in gerrit to github, then star all repos you contributed to [10:29:12] 3MediaWiki / 3Installer: "enter your wiki" on final page of installer appears as an external link - 10https://bugzilla.wikimedia.org/65279 (10Andre Klapper) p:5Unprio>3Low [10:29:12] 3MediaWiki / 3Unit tests: DjVuTest::testGetPageText fails on travis - 10https://bugzilla.wikimedia.org/64947 (10Andre Klapper) p:5Unprio>3Normal [10:29:56] 3MediaWiki extensions / 3[other]: Nostalgia wiki shouldn't use the new style Special:UserLogin - 10https://bugzilla.wikimedia.org/65342 (10Andre Klapper) s:5normal>3minor [10:29:57] 3MediaWiki extensions / 3[other]: Nostalgia wiki shouldn't use the new style Special:UserLogin - 10https://bugzilla.wikimedia.org/65342 (10Andre Klapper) p:5Unprio>3Lowest [10:29:59] matanya: (if you mean showing colored squares in "Contributions" section) [10:30:46] liangent, matanya - I'm not sure... I just happen to have the same username and email. I don't think that I ever connected them. [10:31:28] 3MediaWiki / 3Change tagging: Suggest tags for tag filter - 10https://bugzilla.wikimedia.org/21383 (10Bartosz Dziewoński) [10:31:28] 3MediaWiki / 3General/Unknown: "Tag filter" field at Special:Log and Special:Contributions should support autocompletion - 10https://bugzilla.wikimedia.org/48243 (10Bartosz Dziewoński) [10:31:28] 3MediaWiki / 3Change tagging: Show whether tags are active - 10https://bugzilla.wikimedia.org/18908 (10Bartosz Dziewoński) [10:31:28] 3MediaWiki / 3Recent changes: Add a drop-down list for the tags in Recentchanges and Newpages - 10https://bugzilla.wikimedia.org/25909 (10Bartosz Dziewoński) [10:31:51] (03CR) 10Steinsplitter: "This patch can be merged immediately because the feature is completely broken." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) (owner: 10Rillke) [10:31:56] 3MediaWiki / 3General/Unknown: Unit of wgBackendResponseTime value unclear - 10https://bugzilla.wikimedia.org/65412 (10Andre Klapper) p:5Unprio>3Normal [10:32:56] 3MediaWiki / 3File management: Moving a jpg file to .jpe should be forbidden - 10https://bugzilla.wikimedia.org/65437 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc [10:33:57] 3MediaWiki extensions / 3TimedMediaHandler: Fix "JQMIGRATE: Use of jQuery.fn.data('events') is deprecated" in TimedMediaHandler - 10https://bugzilla.wikimedia.org/65428 (10Andre Klapper) [10:33:57] 3MediaWiki / 3General/Unknown: Code quality issues (tracking) - 10https://bugzilla.wikimedia.org/700 (10Andre Klapper) [10:34:45] 3Wikimedia / 3General/Unknown: Figure out Wikimedia wikis' Special:Contributions footer (duplicative and difficult to maintain) - 10https://bugzilla.wikimedia.org/65446 (10Andre Klapper) p:5Unprio>3Low [10:36:12] 3MediaWiki extensions / 3ConfirmAccount: Welcome Message contains an internal link in error - 10https://bugzilla.wikimedia.org/65454#c1 (10Andre Klapper) p:5Unprio>3Normal Hi Bill! Thanks for investigating and reporting this! Just in case you feel like fixing the code, you are welcome to use Developer a... [10:37:11] 3MediaWiki / 3Skin and page rendering: Implement bin packing layout for galleries - 10https://bugzilla.wikimedia.org/65451 (10Andre Klapper) p:5Unprio>3Low [10:38:59] 3MediaWiki / 3General/Unknown: User::pingLimiter should have per action profiling - 10https://bugzilla.wikimedia.org/65477 (10Antoine "hashar" Musso) 3NEW p:3Unprio s:3enhanc a:3None User::pingLimiter() let us limit some actions (default: 'edit'). The wfProfileIn() entry point does not vary by action... [10:39:32] (03CR) 10Rillke: "Actually it works in Internet Explorer 11. I think I am going to advertise for that browser on COM:VP :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) (owner: 10Rillke) [10:39:57] 3MediaWiki extensions / 3ConfirmAccount: Welcome Message contains an internal link in error - 10https://bugzilla.wikimedia.org/65454#c2 (10Bartosz Dziewoński) MediaWiki:Helppage is allowed to be either an internal or external link. You should use Skin::makeInternalOrExternalUrl() to generate a correct one. [10:43:22] liangent: how is that done? [10:44:11] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Add a Notification for "A Beta Feature you have enabled has been updated" - 10https://bugzilla.wikimedia.org/65191#c3 (10Derk-Jan Hartman) It's not easy, but it's also not totally crazy. You would need a table, keeping track of the beta features, the vers... [10:44:27] oh, got it. thanks liangent [10:46:40] (03PS1) 10Hashar: User::pingLimiter() profiles per action as well [core] - 10https://gerrit.wikimedia.org/r/134067 (https://bugzilla.wikimedia.org/65477) [10:46:42] 3Wikimedia / 3SVG rendering: SVG fonts for Japanese look identical incorrectly - 10https://bugzilla.wikimedia.org/64002 (10Thomash Lee) 5PAT>3RES/FIX [10:49:12] 3MediaWiki / 3Recent changes: Filter Recent Changes by user group - 10https://bugzilla.wikimedia.org/4664#c3 (10John Mark Vandenberg) The current set of default filters still dont provide all the views requested here. It would be possible to set up AbuseFilter rules to label edits to achieve these goals, bu... [10:49:12] 3MediaWiki / 3General/Unknown: User::pingLimiter should have per action profiling - 10https://bugzilla.wikimedia.org/65477 (10Antoine "hashar" Musso) [10:49:14] 3Wikimedia / 3General/Unknown: Graph User::pingLimiter() actions in gdash - 10https://bugzilla.wikimedia.org/65478 (10Antoine "hashar" Musso) 3NEW p:3Unprio s:3normal a:3None User::pingLimiter() let us limit some actions (default: 'edit'). It would be rather nice to have a Graphite dashboard listing... [10:49:52] (03PS1) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/134068 [10:50:28] 3MediaWiki / 3Page deletion: Moving subpages over existing pages not possible - 10https://bugzilla.wikimedia.org/65479 (10[[kgh]]) 3NEW p:3Unprio s:3enhanc a:3None When trying to move a page to another already existing page the message "== Deletion required == The destination page "xyz" already exist... [10:54:11] 3MediaWiki / 3Uploading: "process the upload" backend code should have flags "do not overwrite" and "overwrite only" to avoid race condition - 10https://bugzilla.wikimedia.org/65405 (10Andre Klapper) p:5Unprio>3Normal [10:54:46] 3MediaWiki / 3General/Unknown: Code quality issues (tracking) - 10https://bugzilla.wikimedia.org/700 (10Andre Klapper) [10:54:46] 3MediaWiki extensions / 3UploadWizard: UploadWizard Flickr (tracking) - 10https://bugzilla.wikimedia.org/43450 (10Andre Klapper) [10:54:46] 3MediaWiki extensions / 3UploadWizard: UploadWizard should not use iframe transport for upload_by_url requests to the wiki-own-API (FlickrUploading) - 10https://bugzilla.wikimedia.org/65423 (10Andre Klapper) [10:54:58] 3MediaWiki extensions / 3UploadWizard: UploadWizard: Flickr uploading broken - browser redirect the user to the result of the API request - 10https://bugzilla.wikimedia.org/65406 (10Andre Klapper) [10:54:58] 3MediaWiki extensions / 3UploadWizard: UploadWizard Flickr (tracking) - 10https://bugzilla.wikimedia.org/43450 (10Andre Klapper) [10:58:38] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.user: Use mw.log.deprecate to track user() and anonymous() [core] - 10https://gerrit.wikimedia.org/r/133874 (owner: 10Krinkle) [10:59:42] (03PS1) 10Bartosz Dziewoński: vector: Suppress watch star focus outline when animating it [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/134070 (https://bugzilla.wikimedia.org/65434) [10:59:53] (03CR) 10Bartosz Dziewoński: [C: 032] vector: Suppress watch star focus outline when animating it [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/134070 (https://bugzilla.wikimedia.org/65434) (owner: 10Bartosz Dziewoński) [11:00:05] hi [11:00:09] Hi folkd [11:00:11] folks [11:00:11] (03PS2) 10Bartosz Dziewoński: mediawiki.page.watch.ajax: Disable watch link while waiting for API response [core] - 10https://gerrit.wikimedia.org/r/133895 [11:00:43] So, I emailed a note around to wikitech-l about this, but just for other folks in the channel: [11:00:58] 3MediaWiki / 3Skin and page rendering: Weird watchlist star animation on Firefox - 10https://bugzilla.wikimedia.org/65434 (10Bartosz Dziewoński) 5PAT>3RES/FIX a:3Bartosz Dziewoński [11:01:00] for the next hour, I'm here and available to talk about https://www.mediawiki.org/wiki/Performance_guidelines and the related architecture and security documents I am working on [11:01:49] (03PS4) 10Nuria: Cast empty server-side events to object [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/133668 (https://bugzilla.wikimedia.org/65385) (owner: 10Ori.livneh) [11:02:04] liangent: arrbee devunt dytrivedi santhosh ToAruShiroiNeko wctaiwan zz_sucheta you might especially be interested in this - I scheduled this meeting to make it more accessible to folks in Asia and Australia [11:02:22] springle: ^ [11:02:25] sumanah: Thanks. :) [11:02:31] :) [11:02:46] (03CR) 10Nuria: "Fixed event name." (032 comments) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/133668 (https://bugzilla.wikimedia.org/65385) (owner: 10Ori.livneh) [11:02:50] Hi alolita [11:03:00] Hi sumanah [11:03:05] (03Merged) 10jenkins-bot: mediawiki.user: Use mw.log.deprecate to track user() and anonymous() [core] - 10https://gerrit.wikimedia.org/r/133874 (owner: 10Krinkle) [11:03:10] thanks for covering this time :-) [11:03:29] hello [11:03:30] the LE team could join in so thanks! [11:03:38] https://www.mediawiki.org/wiki/Performance_guidelines is a pretty long document, but the table of contents is pretty short :-) and a good guide to what's in it. We describe several principles of writing high-efficiency code, explain what our goals are, and then, for each principle, explain how to implement it, and point to good and bad examples [11:04:01] In about five days I would like to be able to remove the {{draft}} tag :D [11:04:11] 3MediaWiki / 3Recent changes: Personal option to hide own changes - 10https://bugzilla.wikimedia.org/22213#c5 (10John Mark Vandenberg) This issue also exists for small Wikimedia projects, where there are only a few very active editors and occasional edits from a much larger pool of regulars who are autopatro... [11:04:18] so I've been asking for feedback on wikitech-l and on the talkpage of course [11:04:53] and of course even if there are no meetings synchronized with your time zones you always have that option :) but I figured it would be nice to have some realtime discussion with developers as well! [11:04:57] 3MediaWiki / 3Skin and page rendering: Remove indentation from sidebar links - 10https://bugzilla.wikimedia.org/65444#c4 (10Helder) Compare the bugzilla sidebar to the sidebar on the wikis. On bugzilla, there is no indentation for the uncollapsed sections. This is how it should look like on the wikis as well... [11:05:00] Would it be fine if we discussed in a botless channel? [11:05:05] it is distracting [11:05:22] (03Merged) 10jenkins-bot: vector: Suppress watch star focus outline when animating it [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/134070 (https://bugzilla.wikimedia.org/65434) (owner: 10Bartosz Dziewoński) [11:05:58] ToAruShiroiNeko: I hear your concern. Let's try here for ~5 more min, and then if it is still distracting, then I'm happy to move (and announce the move onlist so people can catch up) [11:06:15] sure [11:06:25] it entirely depends on bots activity of course ;) [11:06:27] sumanah: I think I just learned something: "Watch out for deadlocks and for lock-wait timeouts" I've seen those in my code but had no idea what would be causing. [11:06:27] 3MediaWiki extensions / 3Translate: Translation help - 10https://bugzilla.wikimedia.org/65334#c5 (10Andre Klapper) (In reply to NehalDaveND from comment #3) > Yes.. in this page > https://sa.wikipedia.org/wiki/ > %E0%A4%B5%E0%A4%BF%E0%A4%B6%E0%A5%87%E0%A4%B7%E0%A4%AE%E0%A5%8D: > %E0%A4%A8%E0%A4%B5%E0%A5%80%E... [11:06:29] You can /ignore the bots if you want - I do that sometimes [11:06:41] Nikerabbit: :D I am so glad to have been able to help you! [11:06:57] I do parse the bot feed so that would be couter productive :p [11:07:02] oh sorry! [11:07:07] tis ok [11:07:50] so your proposal is a performance guideline right? [11:08:16] I have written these performance guidelines, yes. [11:08:18] This page explains what we do to make MediaWiki code (core, extensions, user scripts, and gadgets) run fast. If you write code like that, please follow these guidelines so you don't slow down the site, whether you're writing a one-line bugfix, a new gadget feature, a whole new extension, or a big change to core. The aim is to optimize user experience, especially minimizing latency in the user experiences. [11:08:23] MediaWiki developers care a lot about performance, and this guide interrelates with the Architecture guidelines and Security for developers/Architecture. [11:08:27] This page talks about how to make your code fast given how the site works right now. We have a separate discussion about what direction we want our architecture to go. [11:08:39] (figured I would paste that here to make sure everyone understands the goal of the document) [11:08:52] it is a noble goal [11:08:57] (03CR) 10Helder.wiki: "I think this change is what makes the sidebar items not to be aligned with the headers (bug 65444)" [core] - 10https://gerrit.wikimedia.org/r/131259 (https://bugzilla.wikimedia.org/39035) (owner: 10Nemo bis) [11:09:23] sumanah: this is just anecdotal, but many of the performance fixes I've done in the past were very simple: for example forgetting an indes in a table, using N^2 algorigthm instead of N, typo in keyname used for caching. I think this guide captures those cases quite well. It also says to monitor your code. It is probably lack of good monitoring tools that have let these problems go unnoticed quite a long. [11:09:32] I'd like to move forward with making a tutorial and a poster based on this. Those will make it easier for people to learn [11:09:41] skimming through I echo your sentiment towards the visual editor and edit source button [11:09:55] Nikerabbit: That is good feedback that helps me see what's good about this guide. Thank you. [11:09:56] 3MediaWiki / 3Parser: Fatal error: Call to a member function on a non-object in Parser.php - 10https://bugzilla.wikimedia.org/65419#c2 (10Andre Klapper) (In reply to TeleComNasSprVen from comment #0) > Lots of Parser.php fatal errors. Where? In which exact MediaWiki version? How to reproduce? [11:09:58] sumanah: a tutorial is an excellent idea [11:10:00] more examples would be helpful, I suppose thats what the tutorial is for [11:10:12] with examples [11:10:17] code sniplets comparing what not to do and how to fix it [11:10:20] hello alolita [11:10:39] ToAruShiroiNeko: yes, this channel is very poorly suited for meetings; #wikimedia-tech or #mediawiki work better [11:10:45] hi ToAruShiroiNeko [11:11:29] As I wrote this I also put together a very very rough thing: https://www.mediawiki.org/wiki/Performance_profiling_for_Wikimedia_code which others might find useful. I think it is currently the best comprehensive guide to how to measure the performance of your code and use existing monitoring tools [11:11:54] one easy but having big impact change we done in past is optimizing the images(icons) [11:12:23] oh, can you talk more about that santhosh? Maybe I should get a link to the changeset as well, so I can link to it as an example [11:12:58] Hmm... do we have a tool that checks efficency of existing queries? [11:12:59] sumanah: and countless of times I've shoot myself on the foot with caching. Recent examples: https://gerrit.wikimedia.org/r/#/c/133690/ and https://gerrit.wikimedia.org/r/#/c/132399/ [11:13:20] just says of the importance of actually testing that your caching and cache invalidation actually works [11:13:28] (03CR) 10Krinkle: "As I mentioned before, we don't use jQuery UI anywhere in the page interface (not for buttons, not for forms, not for input fields or date" [core] - 10https://gerrit.wikimedia.org/r/110820 (https://bugzilla.wikimedia.org/48241) (owner: 10Alex Monk) [11:13:32] making sure future code complies with this guideline is one thing, testing existing stuff for it is something else [11:13:34] ToAruShiroiNeko: Do you mean something like EXPLAIN? or http://sqlfiddle.com/ ? [11:13:37] we were using SVG images as icons, using tools like svgo, we had reduced the svg image size a lot. let me find some example patches [11:14:23] Got it https://github.com/wikimedia/jquery.uls/commit/f00cf295d3744a2a33f91b72d181fd6613f9d758 [11:14:24] santhosh something like that [11:14:40] but I was thinking something more in-house [11:14:46] sumanah: optimizing images is easy, but it is difficult to gauge the effect on actual effects on latency and bandwidth. Especially things like embedding images in CSS with base64 encoding multiple times compressed with gzip makes it unpredictable [11:14:51] right [11:15:09] scalability as you elequently put is very important [11:15:12] 3MediaWiki / 3JavaScript: Redirects to section are off in Firefox 29.0.1 if there are collapsed elements above the section - 10https://bugzilla.wikimedia.org/65468#c4 (10Andre Klapper) Only stuff vaguely related in upstream I could find is https://bugzilla.mozilla.org/show_bug.cgi?id=483304 and https://bugzi... [11:15:14] it would be nice if Jenkins actually forced images to be optimized on commit time, or even do it automatically [11:15:27] 3MediaWiki / 3Skin and page rendering: Vector: Remove slow collapsibleNav module - 10https://bugzilla.wikimedia.org/39035 (10Helder) [11:15:27] 3MediaWiki / 3Skin and page rendering: Remove indentation from sidebar links - 10https://bugzilla.wikimedia.org/65444#c5 (10Helder) Change-Id: I220057c799bef7e8c4d964f47d56f61ec120d8c2 [11:15:37] So, if people would like to move to #mediawiki that would be fine with me :) [11:15:41] shall we? [11:15:43] arite [11:15:47] sure :) [11:15:50] (if so I'll hit reply on the email so people on the list know) [11:16:01] #omgomg, phase3 svn mediawiki at r15 (!) had a class called WikiPage with a title property [11:16:11] $page = new WikiPage ; [11:17:02] ok, moving to #mediawiki - arrbee santhosh liangent alolita and so on, follow us there :) [11:18:06] (03PS4) 10Helder.wiki: (bug 56849) Deprecate dangerous edittime-based content update functions [core] - 10https://gerrit.wikimedia.org/r/134049 (owner: 10Adamw) [11:18:27] (03PS1) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/134072 [11:19:56] 3MediaWiki extensions / 3Translate: Translation help - 10https://bugzilla.wikimedia.org/65334#c6 (10NehalDaveND) Sorry My English is not so good. I have translate so many days ago, but till today I can't see changes in that. There should be छुपाएँ be गोप्यताम् and should दिखाएँ be दृश्यताम्, but I can't see... [11:20:11] 3MediaWiki / 3Recent changes: Some robot changes appearing in recent changes/watchlist - 10https://bugzilla.wikimedia.org/61239#c3 (10John Mark Vandenberg) (In reply to db from comment #2) > Bots can control the bot flag on each edit, this looks like the bot flag was > not set for these edits. See bot= of AP... [11:22:12] 3MediaWiki / 3Skin and page rendering: Remove indentation from sidebar links - 10https://bugzilla.wikimedia.org/65444#c6 (10Nemo) Created attachment 15437 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15437&action=edit en.wiki sidebar without JavaScript The screenshots on that page are useless, bec... [11:22:57] 3MediaWiki / 3Skin and page rendering: The JS removing "navigation" header makes sidebar links misaligned - 10https://bugzilla.wikimedia.org/65444 (10Nemo) p:5Unprio>3Low s:5normal>3enhanc [11:23:13] (03PS2) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/134072 [11:24:26] 3MediaWiki extensions / 3OAuth: Allow hiding OAuth edits in Recent Changes - 10https://bugzilla.wikimedia.org/64829#c8 (10John Mark Vandenberg) (In reply to Nemo from comment #7) > (In reply to John Mark Vandenberg from comment #5) > > IMO this should be WONTFIXed. OAuth edits are not special > > The imple... [11:25:49] (03PS2) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/134068 [11:27:17] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.api: Use then() in getToken instead of manual Deferred wrapping [core] - 10https://gerrit.wikimedia.org/r/133399 (owner: 10Krinkle) [11:27:42] 3MediaWiki / 3Recent changes: Some robot changes appearing in recent changes/watchlist - 10https://bugzilla.wikimedia.org/61239#c4 (10Strainu) Having seen the problem several times, I am fairly confident the problem happens after login (when I'm asked to introduce the password) so it might be a framework iss... [11:28:17] (03CR) 10Bartosz Dziewoński: [C: 032] "Ah, let's do this already." [core] - 10https://gerrit.wikimedia.org/r/133106 (https://bugzilla.wikimedia.org/65268) (owner: 10Gerrit Patch Uploader) [11:28:56] 3MediaWiki / 3JavaScript: mw.api.getToken should not cache HTTP errors - 10https://bugzilla.wikimedia.org/65268 (10Bartosz Dziewoński) [11:28:57] 3MediaWiki / 3JavaScript: mw.api.getToken should not cache HTTP errors - 10https://bugzilla.wikimedia.org/65268 (10Bartosz Dziewoński) 5PAT>3RES/FIX [11:29:04] (03PS4) 10Dan-nl: Max title length [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/133409 (https://bugzilla.wikimedia.org/65323) [11:29:27] (03CR) 10jenkins-bot: [V: 04-1] Max title length [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/133409 (https://bugzilla.wikimedia.org/65323) (owner: 10Dan-nl) [11:30:41] 3MediaWiki extensions / 3Spam Blacklist: Spam-blacklist not working - 10https://bugzilla.wikimedia.org/65447 (10Andre Klapper) p:5Unprio>3High [11:31:12] 3MediaWiki / 3Search: Allow option for omitting results from a repository when searching for files - 10https://bugzilla.wikimedia.org/65459 (10Andre Klapper) p:5Unprio>3Low [11:31:58] (03Merged) 10jenkins-bot: mediawiki.api: Do not cache errors in getToken() [core] - 10https://gerrit.wikimedia.org/r/133106 (https://bugzilla.wikimedia.org/65268) (owner: 10Gerrit Patch Uploader) [11:32:22] (03Merged) 10jenkins-bot: mediawiki.api: Use then() in getToken instead of manual Deferred wrapping [core] - 10https://gerrit.wikimedia.org/r/133399 (owner: 10Krinkle) [11:33:10] (03CR) 10Dan-nl: "* attempted to import the Artwork template, which is needed for the test to run" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/133409 (https://bugzilla.wikimedia.org/65323) (owner: 10Dan-nl) [11:33:26] 3MediaWiki extensions / 3Translate: sa translation not showing up in interface - 10https://bugzilla.wikimedia.org/65334 (10Andre Klapper) [11:34:56] 3MediaWiki extensions / 3OAuth: Allow hiding OAuth edits in Recent Changes - 10https://bugzilla.wikimedia.org/64829#c9 (10Gerard Meijssen) Sorry John, it seems you do not understand the issues at all. oAuth authenticates, it makes it possible to edit from outside of Wikidata. oAuth will NEVER do anything but... [11:39:51] (03CR) 10Bartosz Dziewoński: [C: 04-1] mediawiki.htmlform: Refactor and clean up (034 comments) [core] - 10https://gerrit.wikimedia.org/r/133254 (owner: 10Krinkle) [11:40:10] (03CR) 10Bartosz Dziewoński: "Will conflict with https://gerrit.wikimedia.org/r/#/c/133254/" [core] - 10https://gerrit.wikimedia.org/r/133694 (owner: 10Gilles) [11:42:45] (03CR) 10Helder.wiki: mediawiki.api: Use then() in getToken instead of manual Deferred wrapping (032 comments) [core] - 10https://gerrit.wikimedia.org/r/133399 (owner: 10Krinkle) [11:48:42] 3MediaWiki / 3Skin and page rendering: The JS removing "navigation" header makes sidebar links misaligned - 10https://bugzilla.wikimedia.org/65444#c7 (10Tomasz W. Kozlowski) 5UNC>3NEW /skins/vector/components/navigation.less assign different margin values to div#mw-panel div.portal div.body and div#mw-pa... [11:55:25] (03CR) 10Bartosz Dziewoński: "I think there's some confusion as to the problem this patch solves – the problem is this: http://i.imgur.com/RRPpWSE.png – if the user has" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/132944 (owner: 10Thiemo Mättig (WMDE)) [11:55:30] (03CR) 10Bartosz Dziewoński: [C: 032] Don't underline hovercard text when user preference is 'Always' [extensions/Popups] - 10https://gerrit.wikimedia.org/r/132944 (owner: 10Thiemo Mättig (WMDE)) [11:55:36] (03Merged) 10jenkins-bot: Don't underline hovercard text when user preference is 'Always' [extensions/Popups] - 10https://gerrit.wikimedia.org/r/132944 (owner: 10Thiemo Mättig (WMDE)) [11:56:42] (03Abandoned) 10Dan-nl: Max title length [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/133409 (https://bugzilla.wikimedia.org/65323) (owner: 10Dan-nl) [11:56:47] (03CR) 10Prtksxna: "Ah! Got it, thanks!" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/132944 (owner: 10Thiemo Mättig (WMDE)) [11:58:34] (03PS1) 10Dan-nl: Max title length [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/134073 (https://bugzilla.wikimedia.org/65323) [12:01:37] (03PS1) 10Santhosh: Dict dictionary protocol backend [services/cxserver] - 10https://gerrit.wikimedia.org/r/134074 [12:04:00] 3Wikimedia / 3General/Unknown: Use a clearer realm for logstash.wikimedia.org indicating it's staff-only - 10https://bugzilla.wikimedia.org/65480 (10Liangent) 3NEW p:3Unprio s:3normal a:3None "WMF Labs (use wiki login name not shell)" makes people think about "any wikitech credentials". [12:06:34] (03PS1) 10Mvolz: Added .gitignore and package.json to node.js app [services/cite-from-id] - 10https://gerrit.wikimedia.org/r/134075 [12:10:42] 3Wikimedia / 3General/Unknown: Use a clearer realm for logstash.wikimedia.org / ishmael.wikimedia.org indicating it's staff-only - 10https://bugzilla.wikimedia.org/65480 (10Liangent) [12:11:13] 3MediaWiki extensions / 3VectorBeta: CPB: user name is incorrectly aligned in RTL wikis in Firefox - 10https://bugzilla.wikimedia.org/65476#c2 (10Amir E. Aharoni) a:3Amir E. Aharoni I didn't investigate this too deeply myself, but a standards expert told me that the likely cause is the following Firefox bu... [12:13:18] (03PS1) 10Amire80: Set explicit text-align on pt-flyout [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/134076 (https://bugzilla.wikimedia.org/65476) [12:15:32] (03PS1) 10Mvolz: .gitignore & package.json added to empty node app [services/cite-from-id] - 10https://gerrit.wikimedia.org/r/134077 [12:15:43] 3Wikimedia / 3General/Unknown: Use a clearer realm for logstash.wikimedia.org / ishmael.wikimedia.org indicating it's staff-only - 10https://bugzilla.wikimedia.org/65480#c1 (10Alex Monk) There are some other sites which do this - (e.g. graphite I think?) Also it's restricted to a subset of staff [12:16:42] (03PS1) 10Dan-nl: Add title tests [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/134078 [12:16:42] (03CR) 10jenkins-bot: [V: 04-1] Add title tests [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/134078 (owner: 10Dan-nl) [12:19:11] (03Abandoned) 10Mvolz: Added .gitignore and package.json to node.js app [services/cite-from-id] - 10https://gerrit.wikimedia.org/r/134075 (owner: 10Mvolz) [12:19:31] 3MediaWiki / 3Export/Import: 'redirect' XML tag is not correctly parsed during XML import - 10https://bugzilla.wikimedia.org/65481 (10Sebastian Brückner) 3UNC p:3Unprio s:3normal a:3None Consider the following snippet of an XML dump created using Special:Export: ... (03CR) 10Mvolz: [C: 032] "Accepting my own commit." [services/cite-from-id] - 10https://gerrit.wikimedia.org/r/134077 (owner: 10Mvolz) [12:24:14] 3Analytics / 3EventLogging: Event Logging writing volume needs monitoring - 10https://bugzilla.wikimedia.org/65482 (10nuria) 3NEW p:3Unprio s:3normal a:3None Event Logging writing volume needs monitoring. We had an incident last Friday where volumen of EL increased dramatically: https://ganglia.wi... [12:24:53] (03PS1) 10Nik: Correctly parse 'redirect' XML tag during Special:Import. [core] - 10https://gerrit.wikimedia.org/r/134079 [12:26:42] 3MediaWiki / 3Export/Import: 'redirect' XML tag is not correctly parsed during XML import - 10https://bugzilla.wikimedia.org/65481#c1 (10Sebastian Brückner) Here's my proposed fix: https://gerrit.wikimedia.org/r/134079 [12:26:56] 3Analytics / 3EventLogging: Event Logging writing throughput needs monitoring - 10https://bugzilla.wikimedia.org/65482 (10nuria) [12:36:26] 3MediaWiki extensions / 3ConfirmAccount: Welcome Message contains an internal link in error - 10https://bugzilla.wikimedia.org/65454#c3 (10Bill Traynor) That's great, but doesn't make sense to me. The link is to a MediaWiki.org help page, which would mean that it is only an internal link to the MediaWiki.o... [12:39:41] 3Wikimedia / 3Wikidata: Gadgets not purged on wikidata.org - 10https://bugzilla.wikimedia.org/65340#c2 (10Thiemo Mättig) If I do localStore.clear() and Shift+reload the page, it works a single time on that single page. If I go to an other page or simply reload the current one it stops working (which means I... [12:42:28] (03CR) 10Nik: [C: 031] Correctly parse 'redirect' XML tag during Special:Import. [core] - 10https://gerrit.wikimedia.org/r/134079 (owner: 10Nik) [13:01:14] (03PS1) 10Yaron Koren: Small formatting improvements [extensions/HeaderTabs] - 10https://gerrit.wikimedia.org/r/134081 [13:01:42] 3MediaWiki / 3Recent changes: Personal option to hide own changes - 10https://bugzilla.wikimedia.org/22213 (10Nemo) [13:01:43] 3MediaWiki / 3User preferences: Ensure consistency of how special pages [et al.] switches can be saved (tracking) - 10https://bugzilla.wikimedia.org/31882 (10Nemo) [13:03:45] (03CR) 10Yaron Koren: [C: 032 V: 032] Small formatting improvements [extensions/HeaderTabs] - 10https://gerrit.wikimedia.org/r/134081 (owner: 10Yaron Koren) [13:03:56] 3MediaWiki / 3Recent changes: Add missing preferences for hide/show like for minor edits and patrolled edits. - 10https://bugzilla.wikimedia.org/27050#c11 (10Nemo) John, you mentioned this in bug 64829 comment 8; I'd like to fix this bug as next on my list of bug 31882 dependencies, any suggestion? My first... [13:04:19] (03PS6) 10Nemo bis: Save advanced search namespace prefs on Special:Search itself [core] - 10https://gerrit.wikimedia.org/r/131727 (https://bugzilla.wikimedia.org/52817) [13:04:29] (03PS1) 10Yaron Koren: Version 1.0 [extensions/HeaderTabs] - 10https://gerrit.wikimedia.org/r/134082 [13:05:35] (03CR) 10Yaron Koren: [C: 032 V: 032] Version 1.0 [extensions/HeaderTabs] - 10https://gerrit.wikimedia.org/r/134082 (owner: 10Yaron Koren) [13:07:11] 3MediaWiki / 3Recent changes: Add a drop-down list for the tags in Recentchanges and Newpages - 10https://bugzilla.wikimedia.org/25909#c45 (10Nemo) More reasons to first use autocompletion where possible: bug 64829 comment 8 on bug 21383. [13:09:12] 3MediaWiki extensions / 3OAuth: Allow hiding OAuth edits in Recent Changes - 10https://bugzilla.wikimedia.org/64829#c10 (10Nemo) John, right. I commented on some of those bugs, we still need a bug on negative filtering I think? Doesn't need to be new syntax, could just be an "invert" checkbox as we already h... [13:10:31] (03PS2) 10Nemo bis: Make "helppage" link relative [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/134063 (https://bugzilla.wikimedia.org/65454) (owner: 10Shirayuki) [13:20:49] (03CR) 10Alex Monk: "> it has an example of how to do xhr-abortion" [core] - 10https://gerrit.wikimedia.org/r/110820 (https://bugzilla.wikimedia.org/48241) (owner: 10Alex Monk) [13:22:26] 3MediaWiki extensions / 3ConfirmAccount: Welcome Message contains an internal link in error - 10https://bugzilla.wikimedia.org/65454#c5 (10Nemo) (In reply to Bill Traynor from comment #3) > Given that, shouldn't it at least be an external link > by default? Yes but it used to be the opposite before; there... [13:24:12] hi halfak [13:24:22] Hey sumanah :) [13:24:30] halfak: how was your weekend? [13:25:09] Pretty good. Got to see my little nieces. 3 and 1. :) [13:25:12] Yours? [13:25:20] sumanah, ^ [13:26:30] It was interesting! I went to http://bangbangcon.com/ - a conference about the excitement of programming [13:26:55] (03CR) 10Mvolz: [V: 032] "Verifying own code." [services/cite-from-id] - 10https://gerrit.wikimedia.org/r/134077 (owner: 10Mvolz) [13:30:12] sumanah, Looks like an interesting conference. What sort of presentations/demos/activities happen there? [13:30:47] halfak: aside from the keynotes, all the talks were 10 minutes long, and there were lots of long breaks, plus some unconferencing time [13:31:09] Gotcha. I see now that I can get abstracts if I scroll down. [13:31:51] lots of audio, some history, some very low-level stuff with hardware and compilers, some security stuff, poetry/word games.... [13:31:56] 3MediaWiki / 3Skin and page rendering: Vector: Remove slow collapsibleNav module - 10https://bugzilla.wikimedia.org/39035#c12 (10Technical 13) So, this is why I no longer have the ability to collapse the sections of the sidebar I do not want to see. This has not improved my page load times at all (it has ac... [13:31:58] 3Wikimedia / 3Mailing lists: Request for a mailing list for the Wikimaps project (GLAM, Historical, Nordic) - 10https://bugzilla.wikimedia.org/65484 (10Susanna Ånäs) 3UNC p:3Unprio s:3enhanc a:3None requested name of the mailing list: wikimaps alternatively: wikimaps-nordic reasoning/explanation of... [13:32:24] Ooh I found one to troll Ironholds with. [13:32:25] http://bangbangcon.com/speakers.html#mwunsch [13:33:34] Ha. I enjoyed that talk. I should use awk more [13:34:27] (03CR) 10Divec: [C: 04-1] "If we use this code to read dictd files, I think we should:" (034 comments) [services/cxserver] - 10https://gerrit.wikimedia.org/r/134074 (owner: 10Santhosh) [13:34:27] in "Brainwaves! On your computer!" the speaker actually showed us a live graph of his brainwaves. During the presentation. [13:35:12] "Spying on your programs with strace!!!" - the speaker was hilarious. She said that so often, we think that to debug programs, we need to, like, use a debugger, or write tests, or know the language the program is written in. Often this is not the case. strace! [13:36:46] Anyway. halfak I see https://www.mediawiki.org/wiki/Extension:OAuth/Usage has diagrams! Excitement! [13:37:27] Yup. I'm picking at it whenever I get a chance. [13:37:48] Oh! Check this out: http://pythonhosted.org/mwoauth/ [13:38:07] *click* [13:38:09] * halfak sees typos and feels shame.  [13:38:40] (03PS1) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/134084 [13:39:13] (03CR) 10Bartosz Dziewoński: mediawiki.api: Use then() in getToken instead of manual Deferred wrapping (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133399 (owner: 10Krinkle) [13:41:12] 3Wikimedia / 3Mailing lists: Request for a mailing list for the Wikimaps project (GLAM, Historical, Nordic) - 10https://bugzilla.wikimedia.org/65484#c1 (10Tomasz W. Kozlowski) 5UNC>3NEW p:5Unprio>3Normal Please provide a link to a discussion showing community agreement for the creation of a new list. [13:42:03] (03PS1) 10Jack Phoenix: Initial import of wikiHow files from 15 May 2014 release. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/134085 [13:43:00] (03CR) 10Jack Phoenix: [C: 032 V: 032] Initial import of wikiHow files from 15 May 2014 release. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/134085 (owner: 10Jack Phoenix) [13:46:36] (03PS1) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/134087 [13:46:41] 3MediaWiki extensions / 3EducationProgram: Courses link is not showing up in the gadgets/extension section of compact personal bar flyout - 10https://bugzilla.wikimedia.org/65467#c1 (10Sage Ross) Jared, I assume the issue is that the Courses link is enabled for a user and shows up normally, but when the Comp... [13:51:49] (03CR) 10Alex Monk: "never mind, I figured it out." [core] - 10https://gerrit.wikimedia.org/r/110820 (https://bugzilla.wikimedia.org/48241) (owner: 10Alex Monk) [13:54:01] (03PS1) 10Physikerwelt: Fix: Use LaTeX comments in relevance section [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/134088 [13:55:33] (03CR) 10Krinkle: "Roan: Hm.. I don't think oojs-ui.css was supposed to be created. It's unused and harmless, but it doesn't belong." [core] - 10https://gerrit.wikimedia.org/r/133872 (owner: 10Catrope) [13:55:50] (03CR) 10Physikerwelt: [C: 032] Fix: Use LaTeX comments in relevance section [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/134088 (owner: 10Physikerwelt) [13:55:55] (03Merged) 10jenkins-bot: Fix: Use LaTeX comments in relevance section [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/134088 (owner: 10Physikerwelt) [13:56:10] (03CR) 10Krinkle: "Wow! Nice work." [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/134085 (owner: 10Jack Phoenix) [13:59:15] (03PS1) 10Matthias Mullie: (bug 61939) Topic-titles not displaying in some topics (disappearing?) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/134089 (https://bugzilla.wikimedia.org/61939) [13:59:42] (03CR) 10jenkins-bot: [V: 04-1] (bug 61939) Topic-titles not displaying in some topics (disappearing?) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/134089 (https://bugzilla.wikimedia.org/61939) (owner: 10Matthias Mullie) [14:00:27] 3MediaWiki extensions / 3TimedMediaHandler: Fix "JQMIGRATE: Use of jQuery.fn.data('events') is deprecated" in TimedMediaHandler - 10https://bugzilla.wikimedia.org/65428#c2 (10Michael Dale) jquery.triggerQueueCallback.js indeed pre-dates promises. It's intent is to trigger all events bidded to a given event... [14:03:26] 3MediaWiki / 3Export/Import: 'redirect' XML tag is not correctly parsed during XML import - 10https://bugzilla.wikimedia.org/65481 (10Lydia Pintscher) 5UNC>3PAT [14:11:12] 3Analytics / 3EventLogging: Empty event appears as [], not {} - 10https://bugzilla.wikimedia.org/65385 (10Kevin Leduc) p:5Unprio>3High [14:11:55] p [14:12:12] 3MediaWiki extensions / 3TimedMediaHandler: Fix "JQMIGRATE: Use of jQuery.fn.data('events') is deprecated" in TimedMediaHandler - 10https://bugzilla.wikimedia.org/65428#c3 (10Krinkle) To maintain a list of functions and fire them in some manner, you can use $.Callbacks. This jQuery is also used internally by... [14:13:26] 3Analytics / 3EventLogging: Empty event appears as [], not {} - 10https://bugzilla.wikimedia.org/65385#c1 (10Krinkle) > Cast empty server-side events to object > Change-Id: If7c155860d6acb596ffc1529f1653dc5aea0b91f [14:13:32] (ignore) [14:16:41] 3MediaWiki extensions / 3OAuth: Allow hiding OAuth edits in Recent Changes - 10https://bugzilla.wikimedia.org/64829#c11 (10Maarten Dammers) Situation at hand: * We have several tools that use Oauth * Some of these tools do a large amount of edits * These edits flood recent changes * Some of the users using t... [14:17:26] 3Analytics / 3EventLogging: Empty event appears as [], not {} - 10https://bugzilla.wikimedia.org/65385#c2 (10Liangent) (In reply to Krinkle from comment #1) > > Cast empty server-side events to object > > Change-Id: If7c155860d6acb596ffc1529f1653dc5aea0b91f Is it possible to fix bug 10887 in the same way? [14:23:18] (03PS1) 10Hashar: Jobs for Petition, OggHandler and CommonMessages [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134091 (https://bugzilla.wikimedia.org/64952) [14:24:47] (03CR) 10Hashar: [C: 032] "deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134091 (https://bugzilla.wikimedia.org/64952) (owner: 10Hashar) [14:25:31] (03Merged) 10jenkins-bot: Jobs for Petition, OggHandler and CommonMessages [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134091 (https://bugzilla.wikimedia.org/64952) (owner: 10Hashar) [14:26:34] (03PS1) 10Hashar: Jobs for Petition, OggHandler and CommonMessages [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134092 (https://bugzilla.wikimedia.org/64952) [14:27:23] (03CR) 10Hashar: [C: 032] Jobs for Petition, OggHandler and CommonMessages [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134092 (https://bugzilla.wikimedia.org/64952) (owner: 10Hashar) [14:27:32] (03Merged) 10jenkins-bot: Jobs for Petition, OggHandler and CommonMessages [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134092 (https://bugzilla.wikimedia.org/64952) (owner: 10Hashar) [14:30:58] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CommonMessages] - 10https://gerrit.wikimedia.org/r/134093 (https://bugzilla.wikimedia.org/64953) [14:31:02] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/CommonMessages] - 10https://gerrit.wikimedia.org/r/134093 (https://bugzilla.wikimedia.org/64953) (owner: 10Hashar) [14:31:04] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Petition] - 10https://gerrit.wikimedia.org/r/134094 (https://bugzilla.wikimedia.org/64952) [14:31:06] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/Petition] - 10https://gerrit.wikimedia.org/r/134094 (https://bugzilla.wikimedia.org/64952) (owner: 10Hashar) [14:31:19] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/OggHandler] - 10https://gerrit.wikimedia.org/r/134095 (https://bugzilla.wikimedia.org/64990) [14:31:24] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/OggHandler] - 10https://gerrit.wikimedia.org/r/134095 (https://bugzilla.wikimedia.org/64990) (owner: 10Hashar) [14:38:09] (03CR) 10Hashar: "recheck" [extensions/CommonMessages] - 10https://gerrit.wikimedia.org/r/115390 (owner: 10Legoktm) [14:38:56] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/CommonMessages] - 10https://gerrit.wikimedia.org/r/134093 (https://bugzilla.wikimedia.org/64953) (owner: 10Hashar) [14:42:58] 3MediaWiki extensions / 3OAuth: Allow hiding OAuth edits in Recent Changes - 10https://bugzilla.wikimedia.org/64829#c12 (10John Mark Vandenberg) The bot flag works well. OAuth tools which flood RC should not work with accounts which do not have the bot flag. Then ppl will ask for the bot flag and be expected... [14:43:00] 3MediaWiki extensions / 3[other]: OggHandler should pass jshint - 10https://bugzilla.wikimedia.org/65487 (10Antoine "hashar" Musso) 3NEW p:3Unprio s:3normal a:3None jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editi... [14:43:12] 3MediaWiki extensions / 3[other]: OggHandler should pass jshint - 10https://bugzilla.wikimedia.org/65487 (10Antoine "hashar" Musso) [14:43:15] (03PS2) 10Matthias Mullie: (bug 61939) Topic-titles not displaying in some topics (disappearing?) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/134089 (https://bugzilla.wikimedia.org/61939) [14:43:26] (03CR) 10Krinkle: "While it now rejects click events, it still fires them and it still looks to the user like it is clickable. How about doing cursor: defaul" [core] - 10https://gerrit.wikimedia.org/r/133895 (owner: 10Bartosz Dziewoński) [14:43:38] (03PS3) 10Krinkle: mediawiki.page.watch.ajax: Disable watch link while waiting for API response [core] - 10https://gerrit.wikimedia.org/r/133895 (owner: 10Bartosz Dziewoński) [14:43:53] (03CR) 10Krinkle: [C: 031] mediawiki.page.watch.ajax: Disable watch link while waiting for API response [core] - 10https://gerrit.wikimedia.org/r/133895 (owner: 10Bartosz Dziewoński) [14:44:14] (03CR) 10Rillke: Initial commit for [[:mw:Extension:MolHandler]] (031 comment) [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/133069 (owner: 10Rillke) [14:45:24] (03PS1) 10Hashar: mwext-OggHandler-jslint non voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134096 (https://bugzilla.wikimedia.org/64990) [14:46:01] (03CR) 10Hashar: [C: 032] mwext-OggHandler-jslint non voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134096 (https://bugzilla.wikimedia.org/64990) (owner: 10Hashar) [14:46:08] (03PS3) 10Ragesoss: Hide profiles for users without relevant rights [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/133462 [14:46:11] (03Merged) 10jenkins-bot: mwext-OggHandler-jslint non voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134096 (https://bugzilla.wikimedia.org/64990) (owner: 10Hashar) [14:47:07] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/OggHandler] - 10https://gerrit.wikimedia.org/r/134095 (https://bugzilla.wikimedia.org/64990) (owner: 10Hashar) [14:48:12] 3MediaWiki / 3JavaScript: Update jquery.tipsy with $.fn.tipsy.autoBounds - 10https://bugzilla.wikimedia.org/44382#c3 (10Derk-Jan Hartman) 5PAT>3RES/FIX This was added (it's not in use yet though). [14:49:03] (03CR) 10Aaron Schulz: "If the job was already there then it should be tried 3 times before being deleted (about 1 day apart, given the claim TTL). If it failed t" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/133994 (https://bugzilla.wikimedia.org/61401) (owner: 10Brian Wolff) [14:49:13] 3MediaWiki extensions / 3Petition: Petition must supports the SQLite backend - 10https://bugzilla.wikimedia.org/65488 (10Antoine "hashar" Musso) 3NEW p:3Unprio s:3normal a:3None I have added Jenkins jobs (bug 64952) and the test suite does not pass because the Petition installer does not support sqli... [14:50:12] (03CR) 10Bartosz Dziewoński: [C: 031] "I like it. Thanks!" [core] - 10https://gerrit.wikimedia.org/r/133895 (owner: 10Bartosz Dziewoński) [14:50:14] (03PS1) 10Hashar: Petition extension is incompatible with sqlite [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134097 (https://bugzilla.wikimedia.org/64952) [14:50:37] (03CR) 10Hashar: [C: 032] Petition extension is incompatible with sqlite [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134097 (https://bugzilla.wikimedia.org/64952) (owner: 10Hashar) [14:50:43] (03Merged) 10jenkins-bot: Petition extension is incompatible with sqlite [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134097 (https://bugzilla.wikimedia.org/64952) (owner: 10Hashar) [14:51:03] (03CR) 10Hashar: "recheck" [extensions/Petition] - 10https://gerrit.wikimedia.org/r/134094 (https://bugzilla.wikimedia.org/64952) (owner: 10Hashar) [14:51:18] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Petition] - 10https://gerrit.wikimedia.org/r/134094 (https://bugzilla.wikimedia.org/64952) (owner: 10Hashar) [15:03:09] (03PS3) 10Manybubbles: Add url parameters to suppress text and didyoumean [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/133746 [15:03:14] (03CR) 10Manybubbles: [C: 032] Add url parameters to suppress text and didyoumean [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/133746 (owner: 10Manybubbles) [15:05:26] 3MediaWiki extensions / 3TimedMediaHandler: Fix "JQMIGRATE: Use of jQuery.fn.data('events') is deprecated" in TimedMediaHandler - 10https://bugzilla.wikimedia.org/65428#c4 (10Michael Dale) right but you still need to wait for all to resolve before continuing. you just described adding a stack of functions to... [15:07:18] (03Merged) 10jenkins-bot: Add url parameters to suppress text and didyoumean [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/133746 (owner: 10Manybubbles) [15:11:35] (03Abandoned) 10Matthias Mullie: (bug 61939) Topic-titles not displaying in some topics (disappearing?) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119304 (https://bugzilla.wikimedia.org/61939) (owner: 10Matthias Mullie) [15:11:48] (03CR) 10Manybubbles: [C: 032] Add url parameters to suppress text and didyoumean [core] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133743 (owner: 10Manybubbles) [15:12:45] (03PS1) 10Hashar: Report pipeline name in build status message [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134098 (https://bugzilla.wikimedia.org/50327) [15:15:10] (03Merged) 10jenkins-bot: Add url parameters to suppress text and didyoumean [core] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133743 (owner: 10Manybubbles) [15:17:02] (03CR) 10Krinkle: [C: 032] mediawiki.page.watch.ajax: Disable watch link while waiting for API response [core] - 10https://gerrit.wikimedia.org/r/133895 (owner: 10Bartosz Dziewoński) [15:19:32] (03CR) 10Manybubbles: [C: 032] Update OOjs UI to v0.1.0-pre (d4086ff6e6) [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/133873 (owner: 10Krinkle) [15:19:41] 3MediaWiki extensions / 3UniversalLanguageSelector: Change Sanskrit transliteration rules - 10https://bugzilla.wikimedia.org/63895#c32 (10Runa Bhattacharjee) Please test and confirm if the changes look ok: http://imetesting.wmflabs.org/jquery.ime/examples/ Thanks [15:20:28] (03Merged) 10jenkins-bot: mediawiki.page.watch.ajax: Disable watch link while waiting for API response [core] - 10https://gerrit.wikimedia.org/r/133895 (owner: 10Bartosz Dziewoński) [15:23:08] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (d4086ff6e6) [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/133873 (owner: 10Krinkle) [15:24:13] 3Wikimedia / 3General/Unknown: Don't use deprecated features removed in jQuery 1.9 (tracking) - 10https://bugzilla.wikimedia.org/65399 (10Krinkle) [15:26:12] 3Wikimedia / 3General/Unknown: Don't use deprecated features removed in jQuery 1.9 (tracking) - 10https://bugzilla.wikimedia.org/65399#c1 (10Krinkle) Time line: * 12 May 2014 (1.24wmf4 [9]): Phase 1 – Instrumentation and logging starts. This will run for 4 weeks (until June 9). * 19 May 2014 (1.24wmf5):... [15:26:12] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Add a Notification for "A Beta Feature you have enabled has been updated" - 10https://bugzilla.wikimedia.org/65191#c4 (10Quim Gil) So maybe a single task is not EASY, and neither good for Google Code-in, but a family of Beta notifications requests could be... [15:27:26] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Add a Notification for "A Beta Feature you have enabled has been updated" - 10https://bugzilla.wikimedia.org/65191#c5 (10James Forrester) (In reply to Quim Gil from comment #4) > So maybe a single task is not EASY, and neither good for Google Code-in, but... [15:29:56] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Add a Notification for "A Beta Feature you have enabled has been updated" - 10https://bugzilla.wikimedia.org/65191#c6 (10Quim Gil) Fair enough. Where is that debate happening? [15:30:12] 3Wikimedia / 3General/Unknown: Don't use deprecated features removed in jQuery 1.9 (tracking) - 10https://bugzilla.wikimedia.org/65399 (10James Forrester) p:5Unprio>3High [15:33:27] 3MediaWiki extensions / 3WikidataClient: every search results in "Query error" next to search results in hebrew wiki - 10https://bugzilla.wikimedia.org/65472#c2 (10Lydia Pintscher) Can you both please provide links to where you see the error? [15:33:56] 3MediaWiki extensions / 3WikidataClient: every search results in "Query error" next to search results in hebrew wiki - 10https://bugzilla.wikimedia.org/65472 (10Lydia Pintscher) p:5Unprio>3High [15:34:11] 3MediaWiki extensions / 3WikidataClient: every search results in "Query error" next to search results in hebrew wiki - 10https://bugzilla.wikimedia.org/65472 (10Lydia Pintscher) [15:36:06] (03CR) 10UltrasonicNXT: [C: 032 V: 032] "Not sure about the point of all that CSS changes but here we go" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/132496 (owner: 10GeorgeBarnick) [15:51:59] 3MediaWiki / 3Recent changes: Personal option to hide own changes - 10https://bugzilla.wikimedia.org/22213 (10John Mark Vandenberg) [15:51:59] 3MediaWiki / 3Recent changes: Bring Recentchanges to the 21st century (tracking) - 10https://bugzilla.wikimedia.org/28447 (10John Mark Vandenberg) [15:51:59] 3Wikimedia / 3Site requests: Set $wgCategoryCollation to 'uca-cs' on Czech Wikipedia and rebuild category sort keys - 10https://bugzilla.wikimedia.org/64885#c7 (10Tomasz W. Kozlowski) Adding Sean. [15:51:59] 3MediaWiki / 3Recent changes: Hide a person's edits from Recent changes - 10https://bugzilla.wikimedia.org/15595 (10John Mark Vandenberg) [15:53:04] hoo: Any idea about https://bugzilla.wikimedia.org/show_bug.cgi?id=64642 ? [15:54:03] huh: Works for me [15:54:11] 3MediaWiki extensions / 3Collection: Rendering a book from plwikisource results in an error - 10https://bugzilla.wikimedia.org/65298 (10Greg Grossmeier) p:5Unprio>3High [15:54:22] hoo: go to https://meta.wikimedia.org/wiki/Special:WikiSets/7 [15:54:32] Do you see "zhwiki" as opted-out? [15:55:29] yes [15:55:35] Really? [15:55:44] FFS, yes [15:55:51] I don't. [15:56:03] * thedj doesn't see it either [15:56:39] i don't have zhwiki on that entire page [15:56:45] same here [15:57:01] mh [15:57:09] Try to log in? [15:57:21] i am logged in [15:57:42] I wasn't before. [15:57:47] Just logged in, same [15:57:52] I can see it only with my steward account [15:58:08] ah. was just gonna say. account permissions ? [15:58:09] ah [15:58:23] You you get a completely different view if you aren't allowed to edit them [15:58:40] I'm referring to the ul [15:58:54] not the text box [15:59:21] Any idea what causes the bug, hoo? [15:59:42] some cache? [16:01:41] 3MediaWiki-Vagrant / 3labs-vagrant: labs-vagrant added a local vagrant user in conflict with ldap - 10https://bugzilla.wikimedia.org/63793 (10Bryan Davis) 5PAT>3RES/FIX [16:02:00] I can't reproduce this error on a private instance with three wikis [16:02:12] 3MediaWiki extensions / 3WikidataRepo: Need html formatter for UnDeserializableValue - 10https://bugzilla.wikimedia.org/65441 (10Lydia Pintscher) p:5Unprio>3Normal [16:02:19] (03PS5) 10Alexander.lehmann: Inserted a time span which may be an change in the past in order to be published. Inserted tests for the special page 'PubSubHubbub-Export'. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/132196 [16:03:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/132196 (owner: 10Alexander.lehmann) [16:03:38] (03CR) 10GeorgeBarnick: "The other CSS changes are for compliance with MediaWiki's CSS coding conventions." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/132496 (owner: 10GeorgeBarnick) [16:07:12] 3MediaWiki extensions / 3Collection: Rendering a book from plwikisource results in an error - 10https://bugzilla.wikimedia.org/65298#c8 (10Christoph Kepper) To me, it looks like a duplicate of #47575 [16:08:13] huh: Do you have a fix or shall I push mine? Don't want to steal your commits ;) [16:08:26] I don't have a fix [16:08:35] thanks [16:10:21] (03PS1) 10Hoo man: Fix Special:WikiSets ro view [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/134105 (https://bugzilla.wikimedia.org/64642) [16:10:29] haven't tested, but seems obvious [16:13:56] hoo: I submitted two CA patches yesterday btw https://gerrit.wikimedia.org/r/#/c/134048/ https://gerrit.wikimedia.org/r/#/c/133997/ if you have time (no hurry), can you review them? [16:14:37] will have a look sometime [16:14:58] I might go offline in a second, as I'll do some evil things to my kernel [16:15:16] okay [16:16:39] (03PS2) 10Anomie: Record redirect target in ParserOptions [core] - 10https://gerrit.wikimedia.org/r/131210 (https://bugzilla.wikimedia.org/62856) [16:17:02] (03CR) 10Anomie: [C: 04-1] "PS2: Rebase." [core] - 10https://gerrit.wikimedia.org/r/131210 (https://bugzilla.wikimedia.org/62856) (owner: 10Anomie) [16:18:18] (03CR) 10MarkTraceur: [C: 04-1] Wait until iframe is fully loaded before submitting form (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) (owner: 10Rillke) [16:18:57] 3MediaWiki extensions / 3WikidataClient: every search results in "Query error" next to search results in hebrew wiki - 10https://bugzilla.wikimedia.org/65472#c3 (10Beta16) At every search from [[Special:Search]]. For example: https://it.wikipedia.org/w/index.php?search=storia&title=Speciale%3ARicerca&fulltex... [16:21:32] (03PS1) 10Bartosz Dziewoński: Collation: Remove deprecated findLowerBound() [core] - 10https://gerrit.wikimedia.org/r/134107 [16:22:41] (03PS2) 10Umherirrender: Adjust check of MysqlUpdater::doUpdateMimeMinorField [core] - 10https://gerrit.wikimedia.org/r/133984 [16:23:29] AndyRussG: Hey, did I hear a rumour you might be working on getting campaigns out of UploadWizard soon? :) [16:24:07] Hey marktraceur [16:25:16] (03PS1) 10Matthias Mullie: (bug 63789) anonymous users don't see any replies to a hidden comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/134109 (https://bugzilla.wikimedia.org/63789) [16:25:17] I'm indeed working on Campaigns, basically transforming it from a focus on user tracking to a focus on collaboration features [16:25:50] marktraceur: https://www.mediawiki.org/wiki/Editor_campaigns [16:26:33] Oh [16:26:35] Any legacy functionality will still work (with only one small caveat), not quite sure how it's currently working with UploadWizzard tho [16:26:38] AndyRussG: You're not reusing code? [16:26:52] Basically only for legacy functionality [16:27:20] Mmm still a draft: https://www.mediawiki.org/wiki/Editor_campaigns/Technical_design [16:27:29] Any comments are very welcome, tho [16:27:33] :) [16:27:57] This seems complicated [16:27:57] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Add a Notification for "A Beta Feature you have enabled has been updated" - 10https://bugzilla.wikimedia.org/65191#c7 (10James Forrester) (In reply to Quim Gil from comment #6) > Fair enough. Where is that debate happening? It's not actively happening. [16:28:01] Maybe more than necessary, not sure [16:28:07] Basically this is the general thing that one day hopefully will replace the education extension [16:28:15] Yeah that was my thinking [16:28:55] AndyRussG: Is the current implementation of the campaigns namespace, maybe with a gate for the media-specific stuff, not enough? [16:28:56] 3MediaWiki extensions / 3WikidataClient: every search results in "Query error" next to search results in hebrew wiki - 10https://bugzilla.wikimedia.org/65472#c4 (10Lydia Pintscher) This isn't standard Wikidata functionality. Is it possible this is coming from https://it.wikipedia.org/wiki/MediaWiki:Common.js... [16:28:57] So the idea is to make it modular, to have some base functionality that is common to collaborative on-wiki endeavours [16:29:22] andre__, hi, I just sent you an update with the hangout link [16:29:25] Then you could just add "campaign-type" values to make more - edits, creation, whatever [16:29:44] 3MediaWiki extensions / 3WikidataRepo: wb-error tooltip details are missing - 10https://bugzilla.wikimedia.org/65492 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs details link and message are missing for wb-error tooltip, since core updated to jquery 1.9 .after for unconnected dom nodes is no l... [16:30:02] qgil, I'll be there in 2min, need to find my camera (after travelling) [16:30:14] ok [16:30:15] 3MediaWiki / 3General/Unknown: Session is started by EditAction - 10https://bugzilla.wikimedia.org/65493 (10Yørn de Jong) 3UNC p:3Unprio s:3normal a:3None When submitting, SubmitAction#show() is executed, which runs wfSetupSession(). This is a problem for extensions using the UserLoadFromSession hook... [16:30:26] 3MediaWiki extensions / 3Popups: Hovercards: Only have Hovercards turned on in main space of Wikipedias and Wiktionaries - 10https://bugzilla.wikimedia.org/63181 (10Prateek Saxena) [16:30:30] 3MediaWiki extensions / 3Popups: Popups: "mw.Api error: " "http" {xhr: Object, textStatus: "abort", exception: "abort"} - 10https://bugzilla.wikimedia.org/65442 (10Prateek Saxena) [16:30:30] 3MediaWiki extensions / 3Popups: Hovercards: Only have Hovercards turned on in main space of Wikipedias and Wiktionaries - 10https://bugzilla.wikimedia.org/63181 (10Prateek Saxena) [16:30:30] 3MediaWiki extensions / 3Popups: TypeError: re.query is undefined - 10https://bugzilla.wikimedia.org/65425 (10Prateek Saxena) [16:30:31] 3MediaWiki extensions / 3Popups: Do not make requests when hovering over WikiEditor's toolbar links - 10https://bugzilla.wikimedia.org/65443 (10Prateek Saxena) [16:30:32] 3MediaWiki extensions / 3Popups: Hovercards: Only have Hovercards turned on in main space of Wikipedias and Wiktionaries - 10https://bugzilla.wikimedia.org/63181 (10Prateek Saxena) [16:31:58] marktraceur: hmmm, just remembering now replacing stuff in UploadWizard has been considered initially out-of-scope (see the first link I sent you) [16:32:01] (03PS1) 10Prtksxna: Use only px in the stylesheet [extensions/Popups] - 10https://gerrit.wikimedia.org/r/134112 [16:32:03] (03PS1) 10Prtksxna: Reduce space between extract and timestamp [extensions/Popups] - 10https://gerrit.wikimedia.org/r/134113 (https://bugzilla.wikimedia.org/65154) [16:32:39] Argh [16:32:48] marktraceur: in truth the possibility that you mention hasn't been looked at [16:33:11] AndyRussG: I'd love to avoid duplicating effort, maybe I can bring this up as a possible collaboration with the MM team [16:36:30] Yeah! The PM on this is StevenW, BTW. I expect that there has been some communication on this, and maybe the "out of scope" thing should say "out of scope for initial releases" [16:38:16] A significant amount of what we've done so far has been studying how to architect this in a good way, and creating some facilities for that, several of which should go in core, I think [16:38:58] Several RFCs should be out soon with regard to all that, one is already linked from the "drafts" section of the RFC page [16:39:40] (03PS3) 10Anomie: Record redirect target in ParserOptions [core] - 10https://gerrit.wikimedia.org/r/131210 (https://bugzilla.wikimedia.org/62856) [16:40:01] (03CR) 10Anomie: "PS3: Now with unit tests!" [core] - 10https://gerrit.wikimedia.org/r/131210 (https://bugzilla.wikimedia.org/62856) (owner: 10Anomie) [16:40:18] (03PS3) 10Rillke: Wait until iframe is fully loaded before submitting form [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) [16:43:06] (03CR) 10Mattflaschen: [C: 032] Only show anonymous editor acquisition once to the user. [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133607 (owner: 10Phuedx) [16:43:12] marktraceur: Yeah avoiding duplicated effort is really important... anytime anyone would like to grab me for a meeting on this is great, feel free to add anything via my non-free Google calendar :) [16:43:17] (03Merged) 10jenkins-bot: Only show anonymous editor acquisition once to the user. [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133607 (owner: 10Phuedx) [16:43:29] (03CR) 10Mattflaschen: [C: 032] Instrument the SignupExpCTAButtonClick schema [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133457 (owner: 10Phuedx) [16:43:35] (03Merged) 10jenkins-bot: Instrument the SignupExpCTAButtonClick schema [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133457 (owner: 10Phuedx) [16:43:49] (03CR) 10Mattflaschen: [C: 032] Use "article" instead of "page" only on Wikipedia [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133608 (owner: 10Phuedx) [16:43:53] (03Merged) 10jenkins-bot: Use "article" instead of "page" only on Wikipedia [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133608 (owner: 10Phuedx) [16:44:11] (03CR) 10Mattflaschen: [C: 032] Localisation updates from https://translatewiki.net. [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133609 (owner: 10Phuedx) [16:44:14] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133609 (owner: 10Phuedx) [16:44:34] (03PS2) 10Robmoen: Instrumentation of PageRestoration schema [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/133632 [16:45:21] (03PS3) 10Robmoen: Pass archived page id to ArticleUndelete hook. [core] - 10https://gerrit.wikimedia.org/r/133631 [16:47:17] (03CR) 10Mattflaschen: "recheck" [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133609 (owner: 10Phuedx) [16:47:59] (03CR) 10Mattflaschen: [C: 032] Localisation updates from https://translatewiki.net. [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133609 (owner: 10Phuedx) [16:48:02] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133609 (owner: 10Phuedx) [16:49:05] (03CR) 10Mattflaschen: [C: 032] Localisation updates from https://translatewiki.net. [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133610 (owner: 10Phuedx) [16:49:10] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133610 (owner: 10Phuedx) [16:49:28] (03CR) 10Mattflaschen: [C: 032] Show anonymous acquisition experiment once regardless of page load. [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133611 (owner: 10Phuedx) [16:49:33] (03Merged) 10jenkins-bot: Show anonymous acquisition experiment once regardless of page load. [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133611 (owner: 10Phuedx) [16:49:41] (03CR) 10Mattflaschen: [C: 032] Localisation updates from https://translatewiki.net. [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133612 (owner: 10Phuedx) [16:49:46] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133612 (owner: 10Phuedx) [16:50:38] (03PS1) 10Ragesoss: Fix when course status goes from current to passed [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/134116 [16:51:17] * marktraceur frowns [16:51:56] AndyRussG: I don't think a meeting is necessary, I think I'll need to poke a few people (probably Steven included) via email and see if we can't organize something useful [16:52:17] marktraceur: K! Also awight has been helping out on the technical side [16:52:18] James_F: hey, should https://www.mediawiki.org/wiki/Wikibase/Beta_Features/Other_projects_sidebar be listed on the main BF page under "Current Beta Features" ? [16:52:19] (03CR) 10Nemo bis: "Nice to see the new hook used, but..." (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/127030 (owner: 10Phuedx) [16:52:31] (03CR) 10CSteipp: [C: 032] "Looks like it should fix that bug. Thanks!" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/134105 (https://bugzilla.wikimedia.org/64642) (owner: 10Hoo man) [16:52:41] (03Merged) 10jenkins-bot: Fix Special:WikiSets ro view [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/134105 (https://bugzilla.wikimedia.org/64642) (owner: 10Hoo man) [16:53:18] (03CR) 10Divec: "Separately from technical and licensing considerations, we should ensure that each dictionary is sanity checked to be suitable for CX purp" (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/134074 (owner: 10Santhosh) [16:53:22] (03CR) 10Mattflaschen: [C: 032] Add linebreaks to anonymouseditoracquisitionpostedit-description [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133613 (owner: 10Phuedx) [16:53:27] (03Merged) 10jenkins-bot: Add linebreaks to anonymouseditoracquisitionpostedit-description [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133613 (owner: 10Phuedx) [16:53:47] Krinkle: Hey - rillke has a patch in that adds a scripturl of form "javascript:false;" to Uploadwizard. We have used "javascript:void(0);" in other Multimedia areas, should we make that a convention of some sort maybe? [16:54:41] greg-g: Is it current? I thought it wasn't going out yet? [16:54:52] marktraceur: uh, how about not doing either? [16:55:05] marktraceur: and ragesoss has also been participating, though mainly with the old EP extension. A student has also been helping gather some requirements for an "activity feed" to replace the course activity feed in the old extension, should also be done in a modular way [16:55:11] (03CR) 10Mattflaschen: [C: 032] Instrumentation of signup experiment schemas [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133614 (owner: 10Phuedx) [16:55:15] (03Merged) 10jenkins-bot: Instrumentation of signup experiment schemas [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133614 (owner: 10Phuedx) [16:55:23] tgr: What would you do instead? [16:55:44] marktraceur: depending on the situation, you can use preventDefault() or not use a real link in the first place [16:55:46] marktraceur: Neither [16:55:47] (03CR) 10Mattflaschen: [C: 032] Only close the pre-/post-edit CTAs if the user clicks X [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133615 (owner: 10Phuedx) [16:55:52] (03Merged) 10jenkins-bot: Only close the pre-/post-edit CTAs if the user clicks X [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133615 (owner: 10Phuedx) [16:55:57] 3MediaWiki extensions / 3WikidataClient: every search results in "Query error" next to search results in hebrew wiki - 10https://bugzilla.wikimedia.org/65472#c5 (10matanya) do you refer to: if (mw.config.get('wgCanonicalSpecialPageName') === 'Search' || (mw.config.get('wgArticleId') === 0 && mw.config.get(... [16:55:58] * AndyRussG is grateful to marktraceur for taking a look at this :) [16:56:07] marktraceur: I'd say both are signals of crappy code, can't see it any other way. [16:56:14] This is in the context of an iframe [16:56:17] jshint should warn against javascript: urls already [16:56:18] Krinkle: > UploadWizard [16:56:20] So yeah. [16:56:31] Krinkle: Unless scripturl: false [16:56:33] onclick e.preventDefault() [16:56:37] (03CR) 10Rillke: Wait until iframe is fully loaded before submitting form (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) (owner: 10Rillke) [16:56:55] > onclick // not for iframes [16:56:55] (03CR) 10Brian Wolff: [C: 032] Inputbox: Some code conventions cleanup [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/133961 (owner: 10TheDJ) [16:56:55] what do you mean? [16:56:55] onclick is fine [16:56:56] (03Merged) 10jenkins-bot: Inputbox: Some code conventions cleanup [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/133961 (owner: 10TheDJ) [16:56:59] https://gerrit.wikimedia.org/r/#/c/133844/2/resources/mw.IframeTransport.js [16:57:27] 3MediaWiki extensions / 3WikidataClient: every search results in "Query error" next to search results in hebrew wiki - 10https://bugzilla.wikimedia.org/65472#c6 (10Lydia Pintscher) Yes. I am not 100% certain but this seems like a good start. [16:57:32] marktraceur: Why would onclick not work in an iframe? [16:57:42] wait not in, on [16:57:57] what is javascript:reutrn false even supposed to do as the src of an iframe? wtf [16:57:58] James_F: is CPB already deployed? [16:58:01] (03CR) 10Mattflaschen: [C: 032] Localisation updates from https://translatewiki.net. [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133616 (owner: 10Phuedx) [16:58:05] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133616 (owner: 10Phuedx) [16:58:09] marktraceur: so what is this actually intended to do? [16:58:12] James_F: but, to answer your question, no, but planning. I was going to report the tracking bug for it [16:58:41] James_F: (yes to my question) [16:58:42] 3MediaWiki extensions / 3[other]: OggHandler should pass jshint - 10https://bugzilla.wikimedia.org/65487#c3 (10Bawolff (Brian Wolff)) 5PAT>3NEW For reference, we no longer use this extension, and it is extremely unlikely we ever will in the future, as its functionality has been replaced by TimedMediaHand... [16:59:06] I think it is equivalent to using src="false", the javascript will be evaluated the moment it is set and the return value used as an URL [16:59:08] I assume the idea is the iframe shouldn't have any src until we need it [16:59:11] James_F: so I guess the answer to my original question is: no, not yet. :) [16:59:12] (03CR) 10Mattflaschen: [C: 032] Prefix with wgCookiePrefix and gettingStarted [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133617 (owner: 10Phuedx) [16:59:14] (don't quote me on that though) [16:59:16] (03Merged) 10jenkins-bot: Prefix with wgCookiePrefix and gettingStarted [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133617 (owner: 10Phuedx) [16:59:16] James_F: thanks ;) [16:59:24] (03CR) 10Krinkle: Wait until iframe is fully loaded before submitting form (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) (owner: 10Rillke) [16:59:57] 3MediaWiki extensions / 3WikidataRepo: Need html formatter for UnDeserializableValue - 10https://bugzilla.wikimedia.org/65441 (10Aude) [16:59:57] 3MediaWiki extensions / 3WikidataRepo: Format errors consistently in claim html - 10https://bugzilla.wikimedia.org/62495 (10Aude) [17:00:26] (03PS3) 10Robmoen: Instrumentation of PageRestoration schema [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/133632 [17:00:57] 3MediaWiki extensions / 3WikidataRepo: Use DataValueMismatchException to generate more specific error output in snak html - 10https://bugzilla.wikimedia.org/63375#c1 (10Aude) 5NEW>3RES/WON fixing bug 63299 shall take care of this [17:01:03] (03CR) 10Mattflaschen: [C: 032] Remove externalLink, since it's now a simple onclick button. [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133618 (owner: 10Phuedx) [17:01:06] (03Merged) 10jenkins-bot: Remove externalLink, since it's now a simple onclick button. [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133618 (owner: 10Phuedx) [17:01:28] 3MediaWiki extensions / 3WikidataRepo: Format errors consistently in claim html - 10https://bugzilla.wikimedia.org/62495 (10Aude) [17:01:28] 3MediaWiki extensions / 3WikidataRepo: Split EntityIdFormatter from EntityIdValueFormatter - 10https://bugzilla.wikimedia.org/63308 (10Aude) [17:02:03] (03CR) 10Mattflaschen: [C: 032] Localisation updates from https://translatewiki.net. [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133619 (owner: 10Phuedx) [17:02:06] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133619 (owner: 10Phuedx) [17:02:15] (03CR) 10Mattflaschen: [C: 032] Localisation updates from https://translatewiki.net. [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133730 (owner: 10Phuedx) [17:02:17] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133730 (owner: 10Phuedx) [17:02:32] marktraceur: if there's any MM docs or code that you'd specifically suggest I look at pls let me know :) [17:02:39] (03CR) 10Mattflaschen: [C: 032] Log account creation with AddNewAccount, impression with UserCreateForm [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133731 (https://bugzilla.wikimedia.org/65352) (owner: 10Phuedx) [17:02:41] (03Merged) 10jenkins-bot: Log account creation with AddNewAccount, impression with UserCreateForm [extensions/GettingStarted] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133731 (https://bugzilla.wikimedia.org/65352) (owner: 10Phuedx) [17:03:11] 3MediaWiki extensions / 3BetaFeatures: BetaFeatures: Add a Notification for "A Beta Feature you have enabled has been updated" - 10https://bugzilla.wikimedia.org/65191#c8 (10Kunal Mehta (Legoktm)) (In reply to Derk-Jan Hartman from comment #3) > It's not easy, but it's also not totally crazy. > > You would... [17:03:15] Erm docs [17:03:20] I knew there was something we forgot. [17:03:21] :P [17:03:31] AndyRussG: I think YuviPanda might have some linkies for you [17:03:56] 3MediaWiki extensions / 3WikidataRepo: Format errors consistently in claim html - 10https://bugzilla.wikimedia.org/62495#c10 (10Aude) remaining issues are that data type mismatch and undeserializable value errors are formatted inconsistently vs. how they are done in the js code, and don't have any css to ind... [17:08:29] 3MediaWiki extensions / 3OAuth: OAuth should respect the bot flag of an account when making edits - 10https://bugzilla.wikimedia.org/65494 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None If a user is flagged as a bot and makes edits via OAuth, those edits are not tagged as bot edits. As the bot flag i... [17:10:41] (03PS4) 10Rillke: Wait until iframe is fully loaded before submitting form [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) [17:11:47] (03PS1) 10Mattflaschen: Log account creation with AddNewAccount, impression with UserCreateForm [extensions/GettingStarted] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134122 (https://bugzilla.wikimedia.org/65352) [17:12:06] (03CR) 10Mattflaschen: [C: 032] Log account creation with AddNewAccount, impression with UserCreateForm [extensions/GettingStarted] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134122 (https://bugzilla.wikimedia.org/65352) (owner: 10Mattflaschen) [17:12:08] (03Merged) 10jenkins-bot: Log account creation with AddNewAccount, impression with UserCreateForm [extensions/GettingStarted] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134122 (https://bugzilla.wikimedia.org/65352) (owner: 10Mattflaschen) [17:12:22] (03PS1) 10Aaron Schulz: Fixed job miscounting bug when a string digit is returned [core] - 10https://gerrit.wikimedia.org/r/134123 [17:12:59] 3Wikimedia / 3Site requests: Enable autopatrolled group on de.wikivoyage - 10https://bugzilla.wikimedia.org/65495 (10Vogone) 3ASS p:3Unprio s:3normal a:3Vogone Per community consensus (linked to in the URL field), the German language Wikivoyage community requests an autopatrolled user group to be cre... [17:13:09] (03CR) 10Aaron Schulz: "Was breaking on HHVM" [core] - 10https://gerrit.wikimedia.org/r/134123 (owner: 10Aaron Schulz) [17:14:26] 3Wikimedia / 3Site requests: Enable autopatrolled group on de.wikivoyage - 10https://bugzilla.wikimedia.org/65495 (10John F. Lewis) p:5Unprio>3Normal [17:15:30] (03PS1) 10Wctaiwan: Handle void elements in JS unclosed tags checker [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/134125 [17:15:57] 3MediaWiki extensions / 3WikidataClient: ApiClientInfo test exiting without error details - 10https://bugzilla.wikimedia.org/65440 (10Aude) 5PAT>3RES/FIX [17:18:09] (03CR) 10Krinkle: "I think allowing modules to load files from arbitrary directories that are not intended to be an API is a bad idea and only discourages ba" [core] - 10https://gerrit.wikimedia.org/r/132498 (https://bugzilla.wikimedia.org/60368) (owner: 10Daniel Friesen) [17:18:54] (03CR) 10Anomie: [C: 031] "Code itself looks like it'll work, haven't tested." [core] - 10https://gerrit.wikimedia.org/r/94512 (owner: 10Adamw) [17:19:11] 3MediaWiki extensions / 3OAuth: Allow hiding OAuth edits in Recent Changes - 10https://bugzilla.wikimedia.org/64829#c13 (10Dan Garry) There are two separate bug reports being conflated into one here. 1) If a user is flagged as a bot, then any edits they make via OAuth are not flagged as bot edits. 2) There... [17:21:48] marktraceur: cool, thanks! ...maybe I'll linkie-re-ping him a bit later, then [17:23:29] (03CR) 10Ori.livneh: [C: 032] Fixed job miscounting bug when a string digit is returned [core] - 10https://gerrit.wikimedia.org/r/134123 (owner: 10Aaron Schulz) [17:23:49] Sure [17:24:26] 3MediaWiki extensions / 3GettingStarted: Use signup hooks if possible - 10https://bugzilla.wikimedia.org/65352 (10Steven Walling) 5PAT>3RES/FIX [17:26:45] (03PS3) 10Krinkle: mediawiki.htmlform: Refactor and clean up [core] - 10https://gerrit.wikimedia.org/r/133254 [17:27:10] (03CR) 10Cscott: WIP: Run some parser tests with tidy. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133957 (owner: 10Cscott) [17:27:42] (03CR) 10Rillke: [C: 04-1] "https://github.com/blueimp/jQuery-File-Upload/blob/master/js/jquery.iframe-transport.js#L42" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) (owner: 10Rillke) [17:27:49] (03Merged) 10jenkins-bot: Fixed job miscounting bug when a string digit is returned [core] - 10https://gerrit.wikimedia.org/r/134123 (owner: 10Aaron Schulz) [17:29:27] 3MediaWiki extensions / 3OAuth: OAuth should respect the bot flag of an account when making edits - 10https://bugzilla.wikimedia.org/65494#c1 (10Umherirrender) The bot flag is a per edit setting, at least when doing edits over api.php[1], the client using OAuth has to set the bot= param to force the bot flag... [17:29:38] (03CR) 10Krinkle: mediawiki.htmlform: Refactor and clean up (033 comments) [core] - 10https://gerrit.wikimedia.org/r/133254 (owner: 10Krinkle) [17:29:48] (03PS1) 10Phuedx: Update GettingStarted extension to tip of deployment branch [core] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/134129 [17:29:52] (03PS4) 10Krinkle: mediawiki.htmlform: Refactor and clean up [core] - 10https://gerrit.wikimedia.org/r/133254 [17:30:27] 3MediaWiki / 3Skin and page rendering: Consolidate personal portlet links into collapsed control or dropdown - 10https://bugzilla.wikimedia.org/44448 (10Jared Zimmerman (WMF)) [17:30:27] 3MediaWiki extensions / 3VectorBeta: Echo popup goes off-screen with CPB in RTL wikis - 10https://bugzilla.wikimedia.org/65471 (10Jared Zimmerman (WMF)) [17:30:33] gwicke: i rethink the parsoid role on vagrant is broken.. [17:32:56] 3MediaWiki extensions / 3VectorBeta: CPB: hover doesn't work on touch interfaces - 10https://bugzilla.wikimedia.org/65470#c1 (10Jared Zimmerman (WMF)) Amir, can you include platform/browser info? it seems to work on Chrome/Safari on iOS [17:34:12] (03PS1) 10Krinkle: Follow-up df48104: Remove oojs-ui.css [core] - 10https://gerrit.wikimedia.org/r/134130 [17:34:45] (03PS2) 10Phuedx: Update GettingStarted extension to tip of deployment branch [core] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/134129 [17:36:02] (03CR) 10Adamw: "Good points!" [core] - 10https://gerrit.wikimedia.org/r/94512 (owner: 10Adamw) [17:38:12] 3MediaWiki extensions / 3VectorBeta: CPB: hover doesn't work on touch interfaces - 10https://bugzilla.wikimedia.org/65470 (10Jared Zimmerman (WMF)) [17:38:12] 3MediaWiki / 3Skin and page rendering: Consolidate personal portlet links into collapsed control or dropdown - 10https://bugzilla.wikimedia.org/44448 (10Jared Zimmerman (WMF)) [17:38:27] marktraceur: AndyRussG linkies for what, exactly? [17:38:33] (03CR) 10Mattflaschen: [C: 032] "Confirmed matches tip of 1.24wmf4" [core] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/134129 (owner: 10Phuedx) [17:38:34] marktraceur: AndyRussG wikibugs and grrrit-wm? [17:38:57] 3MediaWiki extensions / 3GlobalBlocking: Log entries use bad grammar - 10https://bugzilla.wikimedia.org/15259#c5 (10PiRSquared17) (In reply to Nemo from comment #4) > (In reply to comment #3) > > Mike.lifeguard, is this grammar error still reproducible? Thanks. > > Of course not, it was replaced with anoth... [17:39:02] YuviPanda: Sorry, for campaigns documentation [17:39:10] there isn't much, I think. [17:39:18] Womp womp. [17:39:24] Anything you've got would be good [17:39:25] there issomething, actually [17:39:42] That way I can start a thread with various PdMs and bosses and stuff [17:39:50] marktraceur: https://www.mediawiki.org/wiki/User:Yuvipanda/Campaigns_namespace_proposal [17:40:04] (03PS1) 10Phuedx: Update GettingStarted extension to tip of deployment branch [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134131 [17:40:54] AndyRussG: ^^ [17:41:33] (03Merged) 10jenkins-bot: Update GettingStarted extension to tip of deployment branch [core] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/134129 (owner: 10Phuedx) [17:43:35] (03CR) 10Mattflaschen: [C: 032] "Matches tip of 1.24wmf5 extension deployment branch" [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134131 (owner: 10Phuedx) [17:43:43] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (521a9e242b) [core] - 10https://gerrit.wikimedia.org/r/134135 [17:44:10] (03CR) 10Krinkle: "This will break the public method. I don't think it's useful to keep a public jQuery method for this. This should either be a private util" [core] - 10https://gerrit.wikimedia.org/r/133694 (owner: 10Gilles) [17:44:41] (03Abandoned) 10Krinkle: Follow-up df48104: Remove oojs-ui.css [core] - 10https://gerrit.wikimedia.org/r/134130 (owner: 10Krinkle) [17:44:43] (03CR) 10Krinkle: [C: 032] Update OOjs UI to v0.1.0-pre (521a9e242b) [core] - 10https://gerrit.wikimedia.org/r/134135 (owner: 10Catrope) [17:45:31] YuviPanda: marktraceur: Thanks! [17:46:17] (03PS2) 10Cscott: WIP: Run some parser tests with tidy. [core] - 10https://gerrit.wikimedia.org/r/133957 [17:46:27] 3MediaWiki extensions / 3OggHandler: OggHandler should pass jshint - 10https://bugzilla.wikimedia.org/65487 (10Andre Klapper) p:5Unprio>3Lowest [17:46:41] 3MediaWiki extensions / 3VectorBeta: CPB: hover doesn't work on touch interfaces - 10https://bugzilla.wikimedia.org/65470#c2 (10Amir E. Aharoni) Chrome and Firefox on ASUS Transformer Android 4.2.1 tablet. [17:47:55] YuviPanda: marktraceur: for current functionality, should I be looking at this https://www.mediawiki.org/wiki/Extension:UploadWizard/Campaigns ? [17:48:05] Something like that, yeah [17:48:27] K cool [17:48:42] 3MediaWiki extensions / 3VectorBeta: CPB: hover doesn't work on touch interfaces - 10https://bugzilla.wikimedia.org/65470#c3 (10Jared Zimmerman (WMF)) ok its likely a difference in how android and iOS handle touch events then. [17:48:55] Re: UI and a namespace for what we've been doing, some loose notes are here: https://www.mediawiki.org/wiki/Editor_campaigns/Technical_design#UI_.28mostly_tentative.29 [17:49:27] 3MediaWiki extensions / 3OAuth: OAuth should respect the bot flag of an account when making edits - 10https://bugzilla.wikimedia.org/65494#c2 (10Brad Jorsch) 5NEW>3RES/WOR The bot flag hasn't worked that way for a long time now, at least for edits. API edits have to include the "bot" parameter for the ed... [17:49:51] There's also a patch in the works to pull group membership into Wikimetrics as cohorts [17:49:57] (03Merged) 10jenkins-bot: Update GettingStarted extension to tip of deployment branch [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134131 (owner: 10Phuedx) [17:50:00] 3Analytics / 3EventLogging: Add sampling support in EventLogging - 10https://bugzilla.wikimedia.org/65500 (10Dario Taraborelli) 3NEW p:3Unprio s:3normal a:3None Different teams have implemented ad-hoc solutions to introduce sampling in EventLogging in order to perform measurements of the usage of fea... [17:51:08] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (521a9e242b) [core] - 10https://gerrit.wikimedia.org/r/134135 (owner: 10Catrope) [17:51:53] Also note that the path we're imagining for replacing the EducationProgram extension is to replace it gradually as new stuff comes on line. So for example, a first possible step would be to replace the EducationProgram's student enrollement tracking with a new more general membership thingy [17:52:10] Dunno if that's relevant to you, just mentioning it just in case [17:53:11] (03CR) 10Krinkle: jQuery 1.9 compatibility fixes (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 (owner: 10Gilles) [17:53:57] 3MediaWiki extensions / 3OAuth: Allow hiding OAuth edits in Recent Changes - 10https://bugzilla.wikimedia.org/64829#c14 (10Brad Jorsch) (In reply to Maarten Dammers from comment #11) > * Some of the users using these tools have a bot flag > * The botflag isn't used The botflag isn't used because the tool do... [17:54:04] andre__: We're seeing weirdness...OggHandler is a component under MediaWiki extensions for the purposes of searching, but not for the purposes of filing. Do you know why? (cc YuviPanda) [17:54:18] it's possible to prevent new bugs from being filed for things [17:54:22] that might be what's happening [17:54:27] (03CR) 10Krinkle: [C: 04-1] "" removeProp('disabled') " doesn't exist." (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 (owner: 10Gilles) [17:54:28] marktraceur, because it's disabled for new bug entry [17:54:45] I assumed it's dead anyway [17:54:54] if you want it to be open again, tell me :) [17:54:57] 3MediaWiki extensions / 3UploadWizard: UploadWizard fails badly with jshint - 10https://bugzilla.wikimedia.org/47161#c66 (10Mark Holmquist) Poke (for Yuvi) [17:55:03] RoanKattouw: Note that https://gerrit.wikimedia.org/r/#/c/134135/ -1'ed. [17:55:07] RoanKattouw: V-1'ed. [17:55:46] 17:46:23 ERROR: Couldn't find any revision to build. Verify the repository and branch configuration for this job. [17:55:47] Thanks Jenkins [17:55:57] James_F: Thanks for the heads-up [17:56:08] * James_F grins. [17:56:15] RoanKattouw: I was going to cherry-pick, so… [17:56:29] (03CR) 10Catrope: [C: 032] "Re-+2-ing per Krinkle. Come on Jenkins" [core] - 10https://gerrit.wikimedia.org/r/134135 (owner: 10Catrope) [17:56:46] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (521a9e242b) [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134142 [17:58:50] (03CR) 10Krinkle: jQuery 1.9 compatibility fixes (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 (owner: 10Gilles) [18:00:54] (03CR) 10Catrope: jQuery 1.9 compatibility fixes (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133706 (owner: 10Gilles) [18:00:57] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (521a9e242b) [core] - 10https://gerrit.wikimedia.org/r/134135 (owner: 10Catrope) [18:01:59] (03CR) 10Krinkle: "I think this is adding too much to the interface. Doing more harm / confusion than good." (031 comment) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134098 (https://bugzilla.wikimedia.org/50327) (owner: 10Hashar) [18:03:02] (03CR) 10Jaredzimmerman: "Juliusz the issue was seen on the first file on http://en.wikipedia.beta.wmflabs.org/wiki/User:Jdforrester_(WMF)/Sandbox when the image st" [core] - 10https://gerrit.wikimedia.org/r/133301 (https://bugzilla.wikimedia.org/65160) (owner: 10Jforrester) [18:06:41] 3MediaWiki extensions / 3Popups: Hovercards: Only have Hovercards turned on in content namespaces of Wikipedias and Wiktionaries - 10https://bugzilla.wikimedia.org/63181 (10Helder) [18:07:27] 3MediaWiki / 3Skin and page rendering: image style from typography refresh was not implemented - 10https://bugzilla.wikimedia.org/65160#c13 (10Jared Zimmerman (WMF)) updated gerrit link [18:11:57] 3MediaWiki extensions / 3CirrusSearch: MergeMappingException[Merge failed with failures {[mapper [text_bytes] has different index values]}] - 10https://bugzilla.wikimedia.org/61920#c2 (10Chad H.) I hit this last week in production. --reindexAndRemoveOk --indexIdentifier now worked around it, but a more grace... [18:14:34] (03PS3) 10Ragesoss: Add compare action for course revisions [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/132982 [18:15:52] (03PS8) 10Cscott: Use square bounding boxes for default-sized thumbnails [core] - 10https://gerrit.wikimedia.org/r/123683 (https://bugzilla.wikimedia.org/63903) [18:16:33] (03CR) 10Cscott: "ping! i just rebased, if it gets a quickish review hopefully the release notes won't conflict again. " [core] - 10https://gerrit.wikimedia.org/r/123683 (https://bugzilla.wikimedia.org/63903) (owner: 10Cscott) [18:17:29] (03CR) 10Krinkle: [Reapply] Simplify thumbnail styling to have consistency with mobile (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133301 (https://bugzilla.wikimedia.org/65160) (owner: 10Jforrester) [18:21:03] (03CR) 10Rillke: Wait until iframe is fully loaded before submitting form (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) (owner: 10Rillke) [18:22:56] (03CR) 10Adamw: [V: 032] Refactored post-IRL-code-review. [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/118616 (owner: 10Ssmith) [18:23:14] (03CR) 10Adamw: [V: 032] most things fixed from preceding comments. still need to fix map. pushing for review in interim to get working copy. [extensions/FundraisingChart] - 10https://gerrit.wikimedia.org/r/124774 (owner: 10Ssmith) [18:23:18] (03CR) 10Anomie: [C: 04-1] "I'm not sure yet whether this is a good idea or not (among other things, it'll probably mean me grepping API logs to try to see if anyone " (032 comments) [core] - 10https://gerrit.wikimedia.org/r/133955 (owner: 10Adamw) [18:23:56] 3MediaWiki extensions / 3Popups: Popups: "mw.Api error: " "http" {xhr: Object, textStatus: "abort", exception: "abort"} - 10https://bugzilla.wikimedia.org/65442#c2 (10Krinkle) This is just debugging information to let you know a request was aborted. This is generally a good thing (e.g. if a request is no lon... [18:24:27] 3MediaWiki extensions / 3Popups: Hovercards: Only have Hovercards turned on in content namespaces of Wikipedias and Wiktionaries - 10https://bugzilla.wikimedia.org/63181 (10Krinkle) [18:24:27] 3MediaWiki extensions / 3Popups: Popups: "mw.Api error: " "http" {xhr: Object, textStatus: "abort", exception: "abort"} - 10https://bugzilla.wikimedia.org/65442 (10Krinkle) [18:25:23] (03CR) 10Anomie: [C: 032] Fix documentation on token for transcodereset action [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/133405 (https://bugzilla.wikimedia.org/65197) (owner: 10Brian Wolff) [18:25:31] thanks anomie :) [18:25:31] (03PS5) 10Rillke: Wait until iframe is fully loaded before submitting form [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) [18:25:34] (03Merged) 10jenkins-bot: Fix documentation on token for transcodereset action [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/133405 (https://bugzilla.wikimedia.org/65197) (owner: 10Brian Wolff) [18:25:37] (03CR) 10Chad: [C: 032] IP class cleanups [core] - 10https://gerrit.wikimedia.org/r/133747 (owner: 10Aaron Schulz) [18:26:06] bawolff: No problem. Well, besides the problem of finding time for code review ;) [18:26:41] 3MediaWiki extensions / 3OAuth: OAuth should respect the bot flag of an account when making edits - 10https://bugzilla.wikimedia.org/65494#c3 (10Dan Garry) (In reply to Brad Jorsch from comment #2) > I just tested this locally and it worked fine for an API edit. Note that the > account making the edit needs... [18:28:42] (03CR) 10MarkTraceur: [C: 04-1] "One thought re: i18n." (032 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/134073 (https://bugzilla.wikimedia.org/65323) (owner: 10Dan-nl) [18:28:50] (03PS1) 10Yuvipanda: Move growth things to #wikimedia-growth [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/134153 [18:29:11] (03Merged) 10jenkins-bot: IP class cleanups [core] - 10https://gerrit.wikimedia.org/r/133747 (owner: 10Aaron Schulz) [18:30:12] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: If user searches with a dash in the word then filter to only words with the dash - 10https://bugzilla.wikimedia.org/60299 (10Nik Everett) [18:30:32] (03CR) 10Swalling: [C: 031] "LGTM" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/134153 (owner: 10Yuvipanda) [18:31:00] (03CR) 10Yuvipanda: [C: 032 V: 032] Move growth things to #wikimedia-growth [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/134153 (owner: 10Yuvipanda) [18:31:50] (03CR) 10MarkTraceur: [C: 032] "Thanks for all the hard work, rillke :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133844 (https://bugzilla.wikimedia.org/65406) (owner: 10Rillke) [18:34:14] marktraceur: hmm, thoughts on getting rid of the -multimedia extensions from -dev? [18:34:41] I would be so happy about that. [18:34:58] But I'm not sure it would work very well - lots of UW contributors are here but not in -multimedia, I think. [18:35:15] (03PS1) 10Yuvipanda: Remove duplication of -multimedia extensions from -dev [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/134154 [18:35:28] marktraceur: maybe if the bot isn't here anymore they'll come over there :) [18:35:29] (03CR) 10Dan-nl: "* adding some explanation that will hopefully clarify the use of strlen() and bytes" (032 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/134073 (https://bugzilla.wikimedia.org/65323) (owner: 10Dan-nl) [18:38:10] * bawolff misses his bot spam [18:39:15] bawolff: join #mediawiki-feed! [18:39:35] * bawolff likes his bot spam mixed with his people spam [18:40:51] bawolff: hmm, not sure about chatzilla, but some clients allow multiple channels in the same window [18:41:15] * bawolff like to complain and be grumpy! :P [18:42:37] Actually I kind of liked the bot spam in this channel, in the hopes it will draw people into contributing to things they wouldn't normally otherwise contribute to [18:43:33] there's plenty botspam here still. :P [18:44:58] 3Wikimedia / 3Mailing lists: Request for a mailing list for the Wikimaps project (GLAM, Historical, Nordic) - 10https://bugzilla.wikimedia.org/65484#c2 (10Susanna Ånäs) I am asking for community consensus. [18:45:27] 3MediaWiki extensions / 3OAuth: OAuth should respect the bot flag of an account when making edits - 10https://bugzilla.wikimedia.org/65494#c4 (10Brad Jorsch) Except it *is* an edit-level setting. I don't really know what the "average user/administrator on-wiki" might think, but the fact that I don't recall e... [18:46:41] 3Analytics / 3Kraken: Hive queries inconsistently failing - 10https://bugzilla.wikimedia.org/65420#c2 (10Oliver Keyes) Breaking News: we have succeeded in getting a sensical error out of hive! "Java.io.IOException(com.google.protobuf.ServiceException: java.lang.OutOfMemoryError: Java heap space)" I think t... [18:46:49] (03CR) 10Daniel Friesen: [C: 04-1] [Reapply] Simplify thumbnail styling to have consistency with mobile (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133301 (https://bugzilla.wikimedia.org/65160) (owner: 10Jforrester) [18:47:16] (03CR) 10Daniel Friesen: [Reapply] Simplify thumbnail styling to have consistency with mobile [core] - 10https://gerrit.wikimedia.org/r/133301 (https://bugzilla.wikimedia.org/65160) (owner: 10Jforrester) [18:51:17] andre__: Can you remove me from the default CC for OAuth, please? :) [18:52:30] Deskana, done [18:53:34] andre__: Thanks. :) [18:54:01] (03CR) 10Anomie: [C: 032] Move ApiQueryRecentChanges::parseRCType to static method on RecentChange [core] - 10https://gerrit.wikimedia.org/r/133441 (https://bugzilla.wikimedia.org/65071) (owner: 10Kishanio) [18:56:12] 3MediaWiki extensions / 3OAuth: OAuth should respect the bot flag of an account when making edits - 10https://bugzilla.wikimedia.org/65494#c5 (10Dan Garry) (In reply to Brad Jorsch from comment #4) > Except it *is* an edit-level setting. I don't really know what the "average > user/administrator on-wiki" mig... [18:56:16] StevenW: hallo [18:56:19] something urgent? [18:57:27] (03Merged) 10jenkins-bot: Move ApiQueryRecentChanges::parseRCType to static method on RecentChange [core] - 10https://gerrit.wikimedia.org/r/133441 (https://bugzilla.wikimedia.org/65071) (owner: 10Kishanio) [19:13:14] 3MediaWiki / 3API: Move ApiQueryRecentChanges::parseRCType to static method on RecentChange - 10https://bugzilla.wikimedia.org/65071#c5 (10Umherirrender) 5PAT>3RES/FIX a:5Krinkle>3Kishan Thobhani (kishanio) was successfully merged [19:13:32] halfak: hey, do we already have an analysis of User-Agent strings lying around such that my intern could look at it for unique API clients/apps to look up? [19:14:31] sumanah, you should follow me to #wikimedia-research briefly [19:14:33] http://stats.wikimedia.org/wikimedia/squids/SquidReportClients.htm might help [19:15:33] bawolff: we don't use Squid any more! right? [19:15:50] varnish, squid, same difference :) [19:15:53] not actually [19:16:06] But I assume those stats are pulled from varnish and just haven't been renamed [19:17:15] awjr|lunch: Do you anticipate you'll need me for this Wednesday's story prioritization meeting? I have to make an appointment somewhere and the only available one conflicts with it [19:17:28] awjr|lunch: I'll also add that Trevor is on vacation this week [19:19:33] sumanah: http://stats.wikimedia.org/wikimedia/squids/SquidReportCrawlers.htm page might also have interesting things toward the bottom [19:23:14] (03CR) 10Bartosz Dziewoński: [C: 032] Also remove NToC and TemplateEditor images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/133240 (owner: 10TheDJ) [19:23:18] (03Merged) 10jenkins-bot: Also remove NToC and TemplateEditor images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/133240 (owner: 10TheDJ) [19:26:26] 3MediaWiki extensions / 3OAuth: OAuth should respect the bot flag of an account when making edits - 10https://bugzilla.wikimedia.org/65494#c6 (10Brad Jorsch) (In reply to Dan Garry from comment #5) > It is an edit-level setting in the API. It's not an edit-level setting in > the user interface, which is my e... [19:27:46] (03PS1) 10Hashar: Pass jshint [extensions/OggHandler] - 10https://gerrit.wikimedia.org/r/134164 (https://bugzilla.wikimedia.org/65487) [19:27:57] 3MediaWiki / 3Skin and page rendering: Vector: Menu items that are hidden should not be made visible by collapsibleTabs - 10https://bugzilla.wikimedia.org/65294#c2 (10Bartosz Dziewoński) 5UNC>3RES/WON Bug 65292 was fixed in a different way, so let's close this. [19:30:54] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.htmlform: Refactor and clean up [core] - 10https://gerrit.wikimedia.org/r/133254 (owner: 10Krinkle) [19:31:03] (03CR) 10Bartosz Dziewoński: "Superseded by https://gerrit.wikimedia.org/r/#/c/133254/" [core] - 10https://gerrit.wikimedia.org/r/133694 (owner: 10Gilles) [19:31:10] (03Abandoned) 10Bartosz Dziewoński: Remove deprecated .live() call in htmlform [core] - 10https://gerrit.wikimedia.org/r/133694 (owner: 10Gilles) [19:34:18] (03Merged) 10jenkins-bot: mediawiki.htmlform: Refactor and clean up [core] - 10https://gerrit.wikimedia.org/r/133254 (owner: 10Krinkle) [19:35:15] (03CR) 10Krinkle: [C: 032] Make phpcs-strict pass on includes/ (7/7) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133484 (owner: 10Siebrand) [19:37:15] (03PS1) 10Dan-nl: Add pretty JSON output to the GWToolset namespace [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/134167 (https://bugzilla.wikimedia.org/58507) [19:38:40] (03CR) 10Krinkle: "Looks good. Just one trailing space that was added by accident, good to go otherwise." (031 comment) [extensions/OggHandler] - 10https://gerrit.wikimedia.org/r/134164 (https://bugzilla.wikimedia.org/65487) (owner: 10Hashar) [19:38:55] (03Merged) 10jenkins-bot: Make phpcs-strict pass on includes/ (7/7) [core] - 10https://gerrit.wikimedia.org/r/133484 (owner: 10Siebrand) [19:41:11] 3MediaWiki extensions / 3WikidataRepo: Gadgets not working - 10https://bugzilla.wikimedia.org/64842#c11 (10Aude) replied on the gadget talk page, with a suggested fix for coordinates. https://www.wikidata.org/wiki/MediaWiki_talk:Gadget-AuthorityControl.js#Broken_gadget [19:43:49] (03PS3) 10Cscott: Use square bounding boxes for 'upright' and change default scale factor. [core] - 10https://gerrit.wikimedia.org/r/133600 (https://bugzilla.wikimedia.org/63904) [19:45:28] twentyafterfour: Thanks for the submit. Are those suggestions something you want to just do? Or we can work through them this afternoon? [19:46:27] (03PS1) 10Tpt: Adds to ProofreadPage a dependance to LabeledSectionTranclusion [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134204 [19:47:16] (03PS1) 10Aude: Update Wikidata, jquery 1.9 compat fix and api compat change [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134213 [19:48:21] Hi all, what is the name of the part inside MW that communicates between php and javascript? [19:49:00] renoirb: ResourceLoader? [19:49:39] RoanKattouw_away, the ResourceLoader is about loading resources, but I understand that it has some stream of events that is sent to the browser. [19:49:59] AFAIK there is no stream of events sent from PHP to JS [19:50:29] RoanKattouw, what manages window.mediaWiki ? [19:50:40] (03CR) 10Krinkle: Add user_password_expires before running ConvertUserOptions.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133411 (https://bugzilla.wikimedia.org/63677) (owner: 10Withoutaname) [19:52:07] There is EventLogging which sends events from the browser to the server, but that's not in MW core [19:52:27] 3Wikimedia / 3Deployment systems: [scap] Deployment: Repository .git is synchronised fine, but is broken for submodules because of hardcoded gitdir link - 10https://bugzilla.wikimedia.org/53972#c17 (10Bryan Davis) I'm looking into this again and still can't figure out why http://en.wikipedia.beta.wmflabs.or... [19:55:04] RoanKattouw_away, James_F|Away, Reedy, Krinkle: If any of you has a bit of time, I'd love another set of eyeballs to tell me why https://bugzilla.wikimedia.org/show_bug.cgi?id=53972#c17 (git version hashes on Specail:Version) isn't working as I expect. [19:57:07] RoanKattouw_away: i think we'll probably be fine. the next iteration will likely be cleaning up things in preparation for June 17 so there will likely be no new significant VE-related development. [20:05:56] 3Wikimedia / 3Media storage: "The target filename is invalid" when trying to move/delete specific file on Commons - 10https://bugzilla.wikimedia.org/53770#c19 (10Bawolff (Brian Wolff)) (In reply to Andre Klapper from comment #5) > Aaron: As long as this is "fresh", could you take a look at this? > > For > h... [20:07:31] (03PS2) 10Krinkle: List OOjs UI documentation [integration/docroot] - 10https://gerrit.wikimedia.org/r/134225 [20:08:04] (03PS3) 10Krinkle: List OOjs UI documentation [integration/docroot] - 10https://gerrit.wikimedia.org/r/134225 [20:08:24] (03CR) 10Krinkle: [C: 032] List OOjs UI documentation [integration/docroot] - 10https://gerrit.wikimedia.org/r/134225 (owner: 10Krinkle) [20:08:28] (03Merged) 10jenkins-bot: List OOjs UI documentation [integration/docroot] - 10https://gerrit.wikimedia.org/r/134225 (owner: 10Krinkle) [20:08:32] (03CR) 10Krinkle: "https://doc.wikimedia.org/oojs-ui/master/" [integration/docroot] - 10https://gerrit.wikimedia.org/r/134225 (owner: 10Krinkle) [20:08:48] (03CR) 10Krinkle: "https://integration.wikimedia.org/ci/job/oojs-core-jsduck/1/console" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/131338 (owner: 10Krinkle) [20:09:28] (03CR) 10Krinkle: "https://integration.wikimedia.org/ci/job/oojs-ui-jsduck-publish/1/console" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/131338 (owner: 10Krinkle) [20:10:55] (03PS17) 10Welterkj: use imagemap class for HTML rendering [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 [20:12:15] (03CR) 10Hashar: [C: 032] "All wikis now have the MediaWiki API patch that exposes the git branch \O/" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/131861 (https://bugzilla.wikimedia.org/62509) (owner: 10Hashar) [20:12:19] (03Merged) 10jenkins-bot: mw-api-siteinfo: fetch siteinfo from MW API [integration/jenkins] - 10https://gerrit.wikimedia.org/r/131861 (https://bugzilla.wikimedia.org/62509) (owner: 10Hashar) [20:14:55] (03PS1) 10Mattflaschen: Bump for GettingStarted to tip of deploy branch for hotfix [core] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/134231 [20:16:31] (03CR) 10Mattflaschen: [C: 032] Bump for GettingStarted to tip of deploy branch for hotfix [core] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/134231 (owner: 10Mattflaschen) [20:18:17] (03PS1) 10Mattflaschen: Bump GettingStarted to tip of deploy branch for hotfix [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134232 [20:19:33] (03Merged) 10jenkins-bot: Bump for GettingStarted to tip of deploy branch for hotfix [core] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/134231 (owner: 10Mattflaschen) [20:20:57] (03CR) 10Mattflaschen: [C: 032] Bump GettingStarted to tip of deploy branch for hotfix [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134232 (owner: 10Mattflaschen) [20:23:20] (03PS4) 10Awjrichards: Make HTTPS port configurable [core] - 10https://gerrit.wikimedia.org/r/132799 (https://bugzilla.wikimedia.org/65184) [20:24:11] (03CR) 10Awjrichards: "I realized what was confusing the crap out of me was the use of vim folding in the file :p I wound up putting my setting in miscellaneous " [core] - 10https://gerrit.wikimedia.org/r/132799 (https://bugzilla.wikimedia.org/65184) (owner: 10Awjrichards) [20:24:23] (03Merged) 10jenkins-bot: Bump GettingStarted to tip of deploy branch for hotfix [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134232 (owner: 10Mattflaschen) [20:24:28] (03CR) 10Awjrichards: Make HTTPS port configurable (031 comment) [core] - 10https://gerrit.wikimedia.org/r/132799 (https://bugzilla.wikimedia.org/65184) (owner: 10Awjrichards) [20:25:36] (03PS1) 10Ori.livneh: Allow shell-style subscription patterns [services/rcstream] - 10https://gerrit.wikimedia.org/r/134233 [20:28:02] (03CR) 10Welterkj: "Addressed comments from CSteipp." (036 comments) [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [20:30:41] 3Wikimedia / 3Site requests: Block open proxy edits to wikis using the DroneBL - 10https://bugzilla.wikimedia.org/58928 (10Sam Reed (reedy)) [20:31:14] (03CR) 10Adamw: (bug 24330) Enforce section=new constraint when using 'redirect' mode (032 comments) [core] - 10https://gerrit.wikimedia.org/r/133955 (owner: 10Adamw) [20:32:23] (03CR) 10Subramanya Sastry: "I haven't looked at the defn list test diffs yet." (038 comments) [core] - 10https://gerrit.wikimedia.org/r/133957 (owner: 10Cscott) [20:36:16] That's odd – "Import failed: Can't save non-default content model with $wgContentHandlerUseDB disabled: model is wikitext, default for Module:Hatnote is Scribunto". [20:36:28] (On Beta Labs's enwiki.) [20:36:30] (03PS1) 10Krinkle: Remove dependency on MediaWiki core skins.vector.styles module [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/134235 [20:37:28] (03PS2) 10Krinkle: Remove dependency on MediaWiki core skins.vector.styles module [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/134235 [20:38:35] (03PS1) 10Hashar: Get mw branch from target URL and check it out [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/134236 (https://bugzilla.wikimedia.org/62509) [20:40:06] James_F: I would guess you're importing an old xml dump from prior to when the conent handler for module namespace changed [20:40:20] (03CR) 10Hashar: "I have to give it a try. It is a bit late today though :-)" [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/134236 (https://bugzilla.wikimedia.org/62509) (owner: 10Hashar) [20:40:50] (03PS3) 10Krinkle: Remove dependency on MediaWiki core skins.vector.styles module [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/134235 [20:41:47] (03PS4) 10Krinkle: Remove dependency on MediaWiki core skins.vector.styles module [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/134235 [20:50:13] (03Abandoned) 10Adamw: Reformat using a slightly more yaml-y style [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/112311 (owner: 10Adamw) [20:57:49] (03PS4) 10Gergő Tisza: Basic funnel data logging for UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 [20:58:30] (03PS1) 10Manybubbles: Elasticsearch plugin updates [vagrant] - 10https://gerrit.wikimedia.org/r/134246 [20:58:42] 3MediaWiki extensions / 3WikidataRepo: Direct link to download the raw JSON data of each Entity - 10https://bugzilla.wikimedia.org/64515 (10Michał Łazowik) [20:58:44] 3MediaWiki extensions / 3WikidataRepo: It should be possible to get entity id from page title - 10https://bugzilla.wikimedia.org/65507 (10Michał Łazowik) 3NEW p:3Unprio s:3normal a:3Wikidata bugs lazowik: EntityPerPage should provide a function for looking up the ID for a given Titl... [20:58:53] just me or is gerrit dead? [20:59:07] meh [20:59:09] working for me [20:59:30] but looks like some global isp issues [20:59:40] (03CR) 10Gergő Tisza: "Duh. Went through all the EventLogging/ResourceLoader initialization logic with a debugger and it turned out to be just a missing dependen" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 (owner: 10Gergő Tisza) [20:59:53] people at #wikidata have reported sites not working [21:00:20] works for me (Western Europe) [21:00:29] (03PS2) 10Adamw: (bug 24330) Enforce section=new constraint when using 'redirect' mode [core] - 10https://gerrit.wikimedia.org/r/133955 [21:00:57] lazowik: hmm, I'm in the UK [21:01:22] (03CR) 10Adamw: (bug 24330) Enforce section=new constraint when using 'redirect' mode (031 comment) [core] - 10https://gerrit.wikimedia.org/r/133955 (owner: 10Adamw) [21:02:43] (03CR) 10Gergő Tisza: Basic funnel data logging for UploadWizard (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 (owner: 10Gergő Tisza) [21:02:56] YuviPanda: benestar has NetCologne [21:02:57] 3MediaWiki extensions / 3OAuth: OAuth should respect the bot flag of an account when making edits - 10https://bugzilla.wikimedia.org/65494#c7 (10Chris Steipp) I think I agree with Brad that creating a difference between edits made via the api, and edits made via the api that just happen to use OAuth for auth... [21:03:17] back up for me now [21:03:32] mhm [21:06:41] 3MediaWiki extensions / 3UniversalLanguageSelector: Urdu: add Hussaini Nastaleeq font in Nastaʿlīq/Nastalique/Nastaleeq/Nastaliq style - 10https://bugzilla.wikimedia.org/56939#c37 (10Nemo) ur.wiki users, now that this is fixed can the 40 KB of data URI font in [[w:ur:MediaWiki:Print.css]] be deleted? If not,... [21:09:39] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (0fbf6bd14e) [core] - 10https://gerrit.wikimedia.org/r/134249 [21:10:01] (03PS2) 10Catrope: Update OOjs UI to v0.1.0-pre (0fbf6bd14e) [core] - 10https://gerrit.wikimedia.org/r/134249 [21:10:51] (03CR) 10MaxSem: [C: 031] iOS: Enable WikiEditor toolbar [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/132603 (https://bugzilla.wikimedia.org/63277) (owner: 10TheDJ) [21:11:28] (03CR) 10Krinkle: [C: 032] Update OOjs UI to v0.1.0-pre (0fbf6bd14e) [core] - 10https://gerrit.wikimedia.org/r/134249 (owner: 10Catrope) [21:15:26] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (0fbf6bd14e) [core] - 10https://gerrit.wikimedia.org/r/134249 (owner: 10Catrope) [21:19:55] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (0fbf6bd14e) [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134252 [21:27:29] 3Analytics / 3EventLogging: translate.googleusercontent.com in webHost for some client-side events - 10https://bugzilla.wikimedia.org/65508 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None My guess is this might be somehow related to framing. However, it uses: webHost : window.locatio... [21:27:43] (03PS2) 10BryanDavis: Elasticsearch plugin updates [vagrant] - 10https://gerrit.wikimedia.org/r/134246 (owner: 10Manybubbles) [21:27:57] 3Analytics / 3EventLogging: translate.googleusercontent.com in webHost for some client-side events - 10https://bugzilla.wikimedia.org/65508 (10Matthew Flaschen) [21:27:57] 3Analytics / 3EventLogging: Events with unexpected webhost values - 10https://bugzilla.wikimedia.org/55449 (10Matthew Flaschen) [21:28:23] (03CR) 10BryanDavis: [C: 032] "Nik, I think you can self merge these version bumps in the future. :)" [vagrant] - 10https://gerrit.wikimedia.org/r/134246 (owner: 10Manybubbles) [21:28:26] (03Merged) 10jenkins-bot: Elasticsearch plugin updates [vagrant] - 10https://gerrit.wikimedia.org/r/134246 (owner: 10Manybubbles) [21:28:40] (03PS7) 10MarkTraceur: Support for storing files under SHA-1 names [core] - 10https://gerrit.wikimedia.org/r/127460 (owner: 10Aaron Schulz) [21:28:44] bd808: I'll self merge all kinds of stuff then [21:29:33] manybubbles: Works for me. [21:29:42] 3Wikimedia / 3Media storage: "The target filename is invalid" when trying to move/delete specific file on Commons - 10https://bugzilla.wikimedia.org/53770#c20 (10Bawolff (Brian Wolff)) (In reply to Bawolff (Brian Wolff) from comment #19) > (In reply to Andre Klapper from comment #5) > > Aaron: As long as thi... [21:29:47] (03CR) 10jenkins-bot: [V: 04-1] Support for storing files under SHA-1 names [core] - 10https://gerrit.wikimedia.org/r/127460 (owner: 10Aaron Schulz) [21:32:45] (03PS8) 10MarkTraceur: Support for storing files under SHA-1 names [core] - 10https://gerrit.wikimedia.org/r/127460 (owner: 10Aaron Schulz) [21:33:07] is the core team in a meeting right now? [21:33:14] cscott: Yes [21:33:22] cscott: yes [21:33:50] i'd love to get some attention on https://gerrit.wikimedia.org/r/123683 [21:33:56] square bounding boxes [21:34:02] * cscott continues to pound the drum [21:34:13] nod [21:34:25] cscott: sometimes greg-g can help with this sort of thing [21:34:27] don't know if that's ontopic for the meeting or now [21:34:31] *not [21:34:49] (03PS25) 10Adamw: Provision WMF Fundraising projects [vagrant] - 10https://gerrit.wikimedia.org/r/94950 [21:35:14] cscott: I spammed the group chat in our hangout with it :) [21:35:22] woot, thanks ;) [21:35:41] (03CR) 10Adamw: "@Ori.livneh: excellent solution for role-specific virtualization settings, thanks for doing that work!" [vagrant] - 10https://gerrit.wikimedia.org/r/94950 (owner: 10Adamw) [21:35:42] 3MediaWiki extensions / 3CirrusSearch: No Update of elasticsearch index when changing wiki - 10https://bugzilla.wikimedia.org/65439#c1 (10Nik Everett) Bleh. Its not a known bug, no. You should be safe to take the 1.22 branch. The last time I backported things to it was when I did 1.0 support. I'll backpo... [21:35:55] Tim-away +2'ed it last week, but jenkins hated it because of RELEASE-NOTES conflicts :( [21:36:05] (03CR) 10jenkins-bot: [V: 04-1] Support for storing files under SHA-1 names [core] - 10https://gerrit.wikimedia.org/r/127460 (owner: 10Aaron Schulz) [21:36:12] 3MediaWiki extensions / 3WikiEditor: Instrument all actions in wikitext editing toolbar for organization and frequency of use analysis and improvements - 10https://bugzilla.wikimedia.org/64711 (10Jared Zimmerman (WMF)) [21:36:31] cscott: If you don't see anything happen in a day or two, bug greg-g to make sure it's on our "escalation" list for next week [21:36:43] * greg-g nods [21:36:49] ok, thanks [21:37:02] I tried a rebase before I +2'd it, so I knew it would fail [21:37:34] +2 from me when there's a conflict usually means "please fix this conflict for me and merge it ASAP" [21:38:03] well, i ended up making a few non-rebase tweaks because i noticed a corner case i was missing. i think i wrote some new parser tests as well? [21:38:15] yeah, I guess it needs another review [21:38:17] so it would be nice to have some eyes double-check it again [21:38:18] yeah [21:39:00] the dependent patch is the one which alters the semantics of 'upright' to use square bounds; that was also tentatively agreed to at the RfC but not with the same level of obviousness [21:39:13] i collected stats on how many image references it would change, the details are in the linked bug [21:39:37] that needs a review too, but i'll settle for getting 123683 merged first. ;) [21:42:21] (03PS7) 10Rillke: UploadWizard: Check for duplicate titles [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) [21:43:06] bd808: Thanks for the vagrant::settings work, it unblocks much-needed puppetization of Fundraising's components! [21:43:19] awight: Cool! [21:43:20] (and sumanah, i don't know if the square bounding box redux ever made it onto your rfc review meeting schedule, but if there are doubts about https://gerrit.wikimedia.org/r/133600 (the follow-on patch to 123683) that might be able to profitably use some rfc review meeting time to discuss pros/cons/statistics. [21:43:23] (03CR) 10MarkTraceur: UploadWizard: Check for duplicate titles (036 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) (owner: 10Rillke) [21:43:56] 3Analytics / 3EventLogging: translate.googleusercontent.com in webHost for some client-side events - 10https://bugzilla.wikimedia.org/65508#c1 (10Dario Taraborelli) Thanks for bringing this up and for linking the other ticket, this is an issue that we should take very seriously as people crunching the data w... [21:43:57] ori: I noticed that the puppet-lint job could be improved. Do you agree that it should only be running on changed files? [21:44:05] (03CR) 10MarkTraceur: [C: 04-1] "See PS6; nothing changed since then but Gerrit is hard" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) (owner: 10Rillke) [21:44:31] bd808: in return for that awesome work, I will not ask you to review our modules ;) [21:44:53] but he will anyway [21:45:14] cscott: I am happy to have it be something we talk about this week! and anything else you'd like to push on [21:46:17] oh, whee [21:46:28] i'm busy breaking RFC/PMID/url autolinks! [21:46:50] not sure that quite rises to the level of an RfC [21:47:11] I'm pretty sure the RFC autolinks are universally disliked :) [21:47:57] yes, yes they are. they are also wildly inconsistent with each other. [21:50:20] (03CR) 10MarkTraceur: UploadWizard: Check for duplicate titles (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) (owner: 10Rillke) [21:50:36] in particular in the treatment of link prefixes and trails. i'm experimenting with allowing them to use the wiki's configured linktrails and link prefix so they are consistent with other links, but i'm not quite ready to propose that in earnest yet. [21:50:42] 3Analytics / 3EventLogging: translate.googleusercontent.com in webHost for some client-side events - 10https://bugzilla.wikimedia.org/65508#c2 (10Matthew Flaschen) Steven also suggested it could be related to Chrome's automatic translation feature. My tests indicate that still uses the original hostname in... [21:51:55] (03PS1) 10Catrope: Update VisualEditor for cherry-picks [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134259 [21:56:41] 3MediaWiki extensions / 3OAuth: OAuth should respect the bot flag of an account when making edits - 10https://bugzilla.wikimedia.org/65494#c8 (10John Mark Vandenberg) Ftr, this was spawned from bug 64829. [22:03:22] 3Wikimedia / 3Media storage: Investigate cause of new files that have empty oi_archive_name - 10https://bugzilla.wikimedia.org/65511 (10Bawolff (Brian Wolff)) 3NEW p:3Unprio s:3normal a:3None [Sort of related/split off from bug 53770] In regards to files where a history entry appears to be missing.... [22:03:22] 3MediaWiki extensions / 3OAuth: Allow hiding OAuth edits in Recent Changes - 10https://bugzilla.wikimedia.org/64829#c15 (10Dan Garry) (In reply to Brad Jorsch from comment #14) > (In reply to Maarten Dammers from comment #11) > > * Some of the users using these tools have a bot flag > > * The botflag isn't u... [22:03:42] 3MediaWiki extensions / 3OAuth: OAuth should respect the bot flag of an account when making edits - 10https://bugzilla.wikimedia.org/65494#c9 (10Dan Garry) (In reply to Chris Steipp from comment #7) > I think I agree with Brad that creating a difference between edits made via > the api, and edits made via th... [22:03:57] 3Wikimedia / 3Media storage: "The target filename is invalid" when trying to move/delete specific file on Commons - 10https://bugzilla.wikimedia.org/53770#c21 (10Bawolff (Brian Wolff)) For issue of why we have some files with broken history still happening after the other bug fix, I'm splitting that off to b... [22:04:44] 3MediaWiki / 3API: API: action=query with empty title set should still respond with "query" element - 10https://bugzilla.wikimedia.org/31901#c21 (10Derk-Jan Hartman) Ran into this with popups... [22:06:44] (03PS8) 10Rillke: UploadWizard: Check for duplicate titles [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) [22:08:11] (03PS9) 10Rillke: UploadWizard: Check for duplicate titles [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) [22:09:18] (03CR) 10Rillke: UploadWizard: Check for duplicate titles (037 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) (owner: 10Rillke) [22:18:34] (03PS1) 10Aaron Schulz: Fixed possible race condition in LocalFileMoveBatch [core] - 10https://gerrit.wikimedia.org/r/134263 [22:22:38] (03CR) 10MarkTraceur: [C: 04-1] "I think it's an issue that you can still get the old error by uploading a file named Foobar.jpg and changing another file's name to Foobar" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) (owner: 10Rillke) [22:23:06] (03PS1) 10Cscott: Indicate whether interwiki links can use protocol-relative URLs. [core] - 10https://gerrit.wikimedia.org/r/134264 [22:23:11] 3Wikimedia / 3Extension setup: Enable Extension:News on Russian Wikinews - 10https://bugzilla.wikimedia.org/65391#c4 (10Gryllida) https://en.wikinews.org/w/index.php?title=Special:NewsFeed exists. [22:26:10] (03PS2) 10Cscott: Indicate whether interwiki links can use protocol-relative URLs. [core] - 10https://gerrit.wikimedia.org/r/134264 [22:26:51] (03PS3) 10Cscott: Indicate whether interwiki links can use protocol-relative URLs. [core] - 10https://gerrit.wikimedia.org/r/134264 [22:27:52] (03CR) 10Jforrester: [C: 031] Indicate whether interwiki links can use protocol-relative URLs. [core] - 10https://gerrit.wikimedia.org/r/134264 (owner: 10Cscott) [22:29:59] (03CR) 10CSteipp: [C: 031] User::pingLimiter() profiles per action as well [core] - 10https://gerrit.wikimedia.org/r/134067 (https://bugzilla.wikimedia.org/65477) (owner: 10Hashar) [22:31:32] (03CR) 10GWicke: [C: 032] Indicate whether interwiki links can use protocol-relative URLs. [core] - 10https://gerrit.wikimedia.org/r/134264 (owner: 10Cscott) [22:33:42] (03PS2) 10Catrope: Update OOjs UI to v0.1.0-pre (0fbf6bd14e) [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134252 [22:33:56] (03PS2) 10Catrope: Update VisualEditor for cherry-picks [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134259 [22:34:45] (03Merged) 10jenkins-bot: Indicate whether interwiki links can use protocol-relative URLs. [core] - 10https://gerrit.wikimedia.org/r/134264 (owner: 10Cscott) [22:35:45] (03CR) 10BryanDavis: "Drive by comments inline. I tried to apply role::fundraising on a brand new vagrant instance and got these errors/warnings from puppet:" (035 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/94950 (owner: 10Adamw) [22:37:04] (03PS1) 10TheDJ: Popups: Fix popups for extiw links [extensions/Popups] - 10https://gerrit.wikimedia.org/r/134265 [22:37:06] (03PS1) 10TheDJ: Popups: Only run the selector for the a elements once [extensions/Popups] - 10https://gerrit.wikimedia.org/r/134266 [22:39:56] (03PS1) 10TheDJ: Popups: The promise of the popups was not forwarding failures [extensions/Popups] - 10https://gerrit.wikimedia.org/r/134267 [22:40:11] (03CR) 10Andrew Bogott: [C: 031] "+1 I'll merge post-alphabetizing" [vagrant] - 10https://gerrit.wikimedia.org/r/134044 (owner: 10Ori.livneh) [22:45:47] (03PS1) 10TheDJ: Popups: handle links with empty or no title attributes [extensions/Popups] - 10https://gerrit.wikimedia.org/r/134268 [22:50:08] (03PS5) 10Gergő Tisza: Basic funnel data logging for UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133406 [22:50:20] (03PS1) 10TheDJ: Popups: Some small cleanup. [extensions/Popups] - 10https://gerrit.wikimedia.org/r/134269 [22:55:42] (03PS1) 10Cscott: Add RELEASE-NOTES entry for 87e0aa344176d9877bffdf77e222439ec0a99f9e. [core] - 10https://gerrit.wikimedia.org/r/134271 [22:55:55] (03PS2) 10Cscott: Add RELEASE-NOTES entry for 87e0aa344176d9877bffdf77e222439ec0a99f9e [core] - 10https://gerrit.wikimedia.org/r/134271 [22:57:38] (03CR) 10GWicke: [C: 031] Use square bounding boxes for default-sized thumbnails [core] - 10https://gerrit.wikimedia.org/r/123683 (https://bugzilla.wikimedia.org/63903) (owner: 10Cscott) [22:58:04] (03CR) 10Jforrester: [C: 032] Add RELEASE-NOTES entry for 87e0aa344176d9877bffdf77e222439ec0a99f9e [core] - 10https://gerrit.wikimedia.org/r/134271 (owner: 10Cscott) [22:58:52] (03PS1) 10BryanDavis: Alphabetize functions and objects in modules [tools/scap] - 10https://gerrit.wikimedia.org/r/134272 [22:59:08] (03CR) 10jenkins-bot: [V: 04-1] Alphabetize functions and objects in modules [tools/scap] - 10https://gerrit.wikimedia.org/r/134272 (owner: 10BryanDavis) [23:01:06] (03Merged) 10jenkins-bot: Add RELEASE-NOTES entry for 87e0aa344176d9877bffdf77e222439ec0a99f9e [core] - 10https://gerrit.wikimedia.org/r/134271 (owner: 10Cscott) [23:01:41] (03PS10) 10Rillke: UploadWizard: Check for duplicate titles [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) [23:02:25] (03CR) 10Rillke: "``.getName()`` then :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) (owner: 10Rillke) [23:06:05] (03CR) 10Catrope: [C: 032] MobileFrontend: grab https://gerrit.wikimedia.org/r/#/c/133741/ [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/133744 (owner: 10MaxSem) [23:06:31] (03CR) 10Catrope: [C: 032] Update Wikidata, jquery 1.9 compat fix and api compat change [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134213 (owner: 10Aude) [23:07:01] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (0fbf6bd14e) [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134252 (owner: 10Catrope) [23:07:05] (03CR) 10Catrope: [C: 032] Update VisualEditor for cherry-picks [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134259 (owner: 10Catrope) [23:09:11] bd808: Re. git hashes in production, https://www.mediawiki.org/wiki/Special:Version makes it look like the hashes are available for MW itself but not the extensions. Is this right, or am I missing something? [23:09:38] James_F: Yes. It's only messed up for submodules [23:09:58] bd808: "Only". :-( [23:10:03] (03Merged) 10jenkins-bot: MobileFrontend: grab https://gerrit.wikimedia.org/r/#/c/133741/ [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/133744 (owner: 10MaxSem) [23:10:17] bd808: Is there a sane way to fix that, or is it back-burner'ed for now? [23:10:20] The gory detail is that the version of git that we run in production creates .git files for submodules using absolute paths [23:10:59] (03CR) 10MarkTraceur: [C: 04-1] "This still won't work when the filenames aren't modified - if I upload blah.png and blah.jpg, they'll get all the way to the end and give " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/133434 (https://bugzilla.wikimedia.org/64883) (owner: 10Rillke) [23:11:01] I've been trying in things but am currently stuck due to MW in beta not doing what I expect. [23:11:09] (03Merged) 10jenkins-bot: Update Wikidata, jquery 1.9 compat fix and api compat change [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134213 (owner: 10Aude) [23:11:29] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (0fbf6bd14e) [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134252 (owner: 10Catrope) [23:11:31] (03Merged) 10jenkins-bot: Update VisualEditor for cherry-picks [core] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134259 (owner: 10Catrope) [23:11:37] James_F: My current status is at https://bugzilla.wikimedia.org/show_bug.cgi?id=53972#c17 [23:11:40] bd808: Fixing in production (and being irritatingly broken in Beta) would be a start. [23:11:45] * James_F reads. [23:12:22] bd808: Well, that's perplexing. [23:12:39] Yeah. I'm out of ideas as to why it's not working there. [23:12:42] RoanKattouw: After your deploy, https://bugzilla.wikimedia.org/show_bug.cgi?id=53972#c17 might be interesting. [23:12:49] Yeah just read it [23:12:50] \o/ [23:12:51] Weird [23:13:59] If we can make it work in beta then I can make it work in prod I think. Or I can back up and try solving in some different manner. [23:15:11] I'd really like to fix this though, because I want to make additional changes to scap that will break GitInfo for mw-core as well if I don't have a something like this to cary the info from the staging repo to the apaches/ [23:16:22] Deskana: I like your email [23:17:16] greg-g: I'm curious about the Fundraising entry u added for this Thursday--did someone ask you for that specifically? [23:17:22] sumanah: The bot one? I also liked that [23:17:41] hoo: yes :) [23:18:13] sumanah: Some time ago I built that functionality into Wikibase (we do all edits with JS through the API)... I wondered why it is that way... [23:20:24] hoo: It's probably because they were built by different people at different times. [23:20:32] hoo: RoanKattouw might have a view. [23:20:55] I think I might be responsible for the API part of this [23:21:26] As for why it is that way, that's a good question [23:21:28] RoanKattouw: Reply on-thread with the justification, rather than here. [23:21:37] Yeah [23:21:41] RoanKattouw: Saying "I implemented this, and I don't know why" is also fine. :-) [23:21:51] That's basically what it is, yeah [23:22:09] * hoo likes these "It made sense when I wrote it"-features :P [23:22:57] 3MediaWiki / 3Skin and page rendering: Vector: Menu items that are hidden should not be made visible by collapsibleTabs - 10https://bugzilla.wikimedia.org/65294#c3 (10James Forrester) I'm not sure that this is the right call, but I also don't really care. :-) [23:33:20] sumanah: :) [23:39:27] 3Analytics / 3Kraken: Hive queries inconsistently failing - 10https://bugzilla.wikimedia.org/65420#c3 (10Toby Negrin) Do we have the ability to up the JVM heap? e.g http://stackoverflow.com/questions/18546201/increase-jvm-heap-space-while-runnig-from-hadoop-unix [23:39:27] 3Analytics / 3Kraken: Hive queries inconsistently failing - 10https://bugzilla.wikimedia.org/65420 (10Toby Negrin) p:5Unprio>3High [23:51:12] 3Wikimedia / 3Site requests: Enable autopatrolled group on de.wikivoyage - 10https://bugzilla.wikimedia.org/65495#c3 (10Vogone) 5PAT>3RES/FIX Should be resolved by now. [23:53:11] 3MediaWiki / 3Change tagging: Suggest tags for tag filter at Special:Contributions, Special:NewPages, Special:RecentChanges, and Special:Log - 10https://bugzilla.wikimedia.org/21383 (10MZMcBride) [23:54:36] (03PS2) 10TTO: Correctly parse 'redirect' XML tag during Special:Import. [core] - 10https://gerrit.wikimedia.org/r/134079 (https://bugzilla.wikimedia.org/65481) (owner: 10Nik) [23:56:41] 3MediaWiki / 3General/Unknown: "Tag filter" field at Special:Log and Special:Contributions should support autocompletion - 10https://bugzilla.wikimedia.org/48243#c4 (10MZMcBride) (In reply to John Mark Vandenberg from comment #2) > (In reply to MZMcBride from comment #0) >> The "Tag filter" field at Special:... [23:57:26] 3MediaWiki / 3Change tagging: Suggest tags for tag filter at Special:Contributions, Special:NewPages, Special:RecentChanges, and Special:Log - 10https://bugzilla.wikimedia.org/21383 (10MZMcBride) [23:57:27] 3MediaWiki / 3General/Unknown: Implement autocompletion/search suggestion throughout MediaWiki (tracking) - 10https://bugzilla.wikimedia.org/48240 (10MZMcBride) [23:58:59] (03CR) 10MZMcBride: "This is neat!" [core] - 10https://gerrit.wikimedia.org/r/125565 (https://bugzilla.wikimedia.org/20210) (owner: 10Bartosz Dziewoński)