[00:01:13] (03CR) 10PleaseStand: "Aren't there some files that should have been deleted in this commit but weren't?" [core] - 10https://gerrit.wikimedia.org/r/125143 (owner: 10Siebrand) [00:05:34] (03PS1) 10Alex Monk: Global block error message should be recognised by API [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/127835 [00:14:21] (03PS1) 10Catrope: Update MobileFrontend for cherry-pick [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127837 [00:17:03] (03CR) 10Catrope: [C: 032 V: 032] Update MobileFrontend for cherry-pick [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127837 (owner: 10Catrope) [00:19:28] (03PS1) 10Dan-nl: preview without upload [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/127839 [00:24:18] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Makes sense, minor issue." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/127371 (owner: 10Gerrit Patch Uploader) [00:29:17] ori, ping [00:33:59] (03CR) 10Bartosz Dziewoński: "Actually, this causes rather problematic rendering issues in browsers that don't support box-sizing. I'm not sure if this is a good idea, " [core] - 10https://gerrit.wikimedia.org/r/127371 (owner: 10Gerrit Patch Uploader) [00:39:07] (03PS1) 10Bartosz Dziewoński: mediawiki.mixins: Move .box-sizing mixin from mediawiki.ui utilities [core] - 10https://gerrit.wikimedia.org/r/127843 [00:45:00] (03CR) 10Ori.livneh: "Googling for the message keys, I see some sign of life from February: gwicke: howdy [00:48:15] (03CR) 10Swalling: "Their quote there ("I was looking for to edit MediaWiki:Createacct-another-join and add in instructions on what the format should be for t" [core] - 10https://gerrit.wikimedia.org/r/127822 (owner: 10Swalling) [00:52:08] ^d: can I get some force-push help? [00:52:26] ^d: just had a terrible accident where I merged our deployment branch into master... [01:00:14] ^d: nvm, figured it out. Don't ask. [01:18:27] (03CR) 10PiRSquared17: [C: 04-1] Add log for TitleBlacklist hits (031 comment) [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader) [01:18:35] (03PS1) 10PleaseStand: Remove unused message 'dberr-header' [core] - 10https://gerrit.wikimedia.org/r/127852 [01:18:37] (03PS1) 10PleaseStand: Remove 3 unused upload related error messages [core] - 10https://gerrit.wikimedia.org/r/127853 [01:18:39] (03PS1) 10PleaseStand: Remove 2 unused search related messages [core] - 10https://gerrit.wikimedia.org/r/127854 [01:18:41] (03PS1) 10PleaseStand: Remove unused message 'notacceptable' [core] - 10https://gerrit.wikimedia.org/r/127855 [01:22:15] (03PS2) 10PleaseStand: Remove 3 unused upload related error messages [core] - 10https://gerrit.wikimedia.org/r/127853 [01:27:12] (03CR) 10Legoktm: [C: 032 V: 032] Send email through Google's service [extensions/GoogleAppEngine] - 10https://gerrit.wikimedia.org/r/127415 (owner: 10Legoktm) [01:33:20] (03CR) 10Mattflaschen: ""I understand what the code is doing but not the use case, in what cases would we want to use this 'delay' code and made the UI slower?"" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/116260 (owner: 10Prtksxna) [01:53:29] (03PS1) 10SG: Fix topic hidden message when collapsed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127858 [01:58:51] (03CR) 1001tonythomas: [C: 031] Remove 2 unused search related messages [core] - 10https://gerrit.wikimedia.org/r/127854 (owner: 10PleaseStand) [02:01:33] ori: https://gerrit.wikimedia.org/r/#/c/127660/ [02:03:49] (03PS1) 10Gergő Tisza: Make users API cache mode public if blockinfo is not queried [core] - 10https://gerrit.wikimedia.org/r/127859 [02:08:02] (03CR) 10Spage: [V: 031] "I didn't get Benny's error at first. But after updating Flow and core and `php maintenance/FlowUpdateRecentChanges.php --force` I did get " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121855 (owner: 10EBernhardson) [02:12:44] (03CR) 10PiRSquared17: "What's going on with the API calls?" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader) [02:12:59] (03PS1) 10Mattflaschen: Use EventLogging::logEvent instead of deprecated version [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/127860 [02:24:40] TimStarling: any reason why http://localhost/DevWiki/core/img_auth.php/d/d9/%E6%B8%85%E6%B0%B4%E8%AD%A6%E5%AF%9F%E7%BD%B2.JPG might fail the IE extension check? [02:27:24] JPG has the wrong case [02:28:26] or not... [02:28:43] (03CR) 10Mattflaschen: "In Firefox 24.4.0, there seems to be a slight flicker." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125392 (owner: 10Prtksxna) [02:28:45] yes [02:28:57] it must be your own code, it's declared final ;) [02:29:03] final public static function extensionFromPath( $path ) { [02:29:03] $i = strrpos( $path, '.' ); [02:29:03] return strtolower( $i ? substr( $path, $i + 1 ) : '' ); [02:29:03] } [02:29:25] strtolower() converts JPG to jpg, that's what gets passed as $whitelist [02:29:57] yeah I noticed as you were typing [02:31:16] (03PS1) 10Aaron Schulz: Avoid bogus IE extension check errors in img_auth.php [core] - 10https://gerrit.wikimedia.org/r/127862 [02:31:25] TimStarling: there :) [02:33:42] (03CR) 10Aaron Schulz: "Hmm, a bit of this code can be removed in favor of "use img_auth.php"..." [core] - 10https://gerrit.wikimedia.org/r/125573 (owner: 10Aaron Schulz) [02:35:33] (03CR) 10Tim Starling: [C: 031] "Looks good to me. Can be merged after a delay for review." [core] - 10https://gerrit.wikimedia.org/r/127862 (owner: 10Aaron Schulz) [02:51:09] (03PS4) 10Aaron Schulz: Added path encoding to FileBackendStore for Windows support [core] - 10https://gerrit.wikimedia.org/r/125573 [02:55:31] (03CR) 10Mattflaschen: "Where the docs are uploaded is a separate question from where the build script is." [core] - 10https://gerrit.wikimedia.org/r/125368 (owner: 10Mattflaschen) [03:09:43] (03CR) 10Mattflaschen: "Sorry, I didn't realize this was fixed in https://gerrit.wikimedia.org/r/#/c/125511/ ." [core] - 10https://gerrit.wikimedia.org/r/125368 (owner: 10Mattflaschen) [03:16:13] (03PS2) 10Mattflaschen: Explain make kss environment variable in README [core] - 10https://gerrit.wikimedia.org/r/125368 [03:17:29] (03CR) 10Mattflaschen: "Done, this is now just a doc fix." [core] - 10https://gerrit.wikimedia.org/r/125368 (owner: 10Mattflaschen) [03:25:21] (03CR) 10Chad: [C: 032] Remove 2 unused search related messages [core] - 10https://gerrit.wikimedia.org/r/127854 (owner: 10PleaseStand) [03:28:20] (03Merged) 10jenkins-bot: Remove 2 unused search related messages [core] - 10https://gerrit.wikimedia.org/r/127854 (owner: 10PleaseStand) [03:37:36] (03PS1) 10Chad: Remove "useless override" rule from CodeSniffer [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/127863 [03:39:45] (03CR) 10Chad: [C: 04-1] "Other than the inline stuff lgtm." (035 comments) [core] - 10https://gerrit.wikimedia.org/r/127676 (owner: 10Siebrand) [03:51:40] (03PS1) 10Bsitu: Update to localCache should sync with bufferCache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127864 [03:57:52] (03PS2) 10Bsitu: Update to localCache should sync with bufferCache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127864 [04:10:53] (03PS1) 10Gerrit Patch Uploader: Show number of displayed pages on WhatLinksHere [core] - 10https://gerrit.wikimedia.org/r/127866 [04:10:57] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/127866 (owner: 10Gerrit Patch Uploader) [04:17:29] (03PS2) 10Ori.livneh: Remove unnecessary h2 element on create account [core] - 10https://gerrit.wikimedia.org/r/127822 (owner: 10Swalling) [04:18:06] (03CR) 10Ori.livneh: [C: 032] "@Swalling: Yeah, makes sense." [core] - 10https://gerrit.wikimedia.org/r/127822 (owner: 10Swalling) [04:23:19] (03Merged) 10jenkins-bot: Remove unnecessary h2 element on create account [core] - 10https://gerrit.wikimedia.org/r/127822 (owner: 10Swalling) [04:35:01] andre__, sorry, I'm late [04:35:10] qgil, np [04:35:32] andre__, you've got email / or link to hangout in calendar invitation [04:35:44] qgil, oh, no appear.in? [04:36:18] andre__, back to hangout, unless you have an opinion [04:36:33] qgil, I'll go to Hangout then [05:00:26] (03PS1) 10Aaron Schulz: Avoid uncommitted transaction notices in thumb.php and img_auth.php [core] - 10https://gerrit.wikimedia.org/r/127868 [05:59:05] (03PS1) 10Aaron Schulz: Fixed slow query in LocalFileDeleteBatch::getHashes() [core] - 10https://gerrit.wikimedia.org/r/127871 [05:59:47] TimStarling: sigh [06:05:07] (03PS1) 10Skizzerz: Fix some issues with Microsoft SQL Server support [core] - 10https://gerrit.wikimedia.org/r/127872 [06:05:48] (03CR) 10Skizzerz: "This will need to be backported to REL1_23 once merged." [core] - 10https://gerrit.wikimedia.org/r/127872 (owner: 10Skizzerz) [06:08:53] (03PS2) 10Skizzerz: Fix some issues with Microsoft SQL Server support [core] - 10https://gerrit.wikimedia.org/r/127872 [06:34:21] (03CR) 10Springle: [C: 032] Fixed slow query in LocalFileDeleteBatch::getHashes() [core] - 10https://gerrit.wikimedia.org/r/127871 (owner: 10Aaron Schulz) [07:06:18] (03CR) 10Chad: [C: 032] Improvements to near match resolution [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127700 (owner: 10Manybubbles) [07:06:29] (03Merged) 10jenkins-bot: Improvements to near match resolution [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127700 (owner: 10Manybubbles) [07:09:42] (03PS4) 10Aaron Schulz: Support for storing files under SHA-1 names [core] - 10https://gerrit.wikimedia.org/r/127460 [07:13:58] (03PS1) 10Chad: Use CJK for Japanese and Korean [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127874 [07:18:43] (03PS2) 10Prtksxna: Replace animiationend with setTimeout [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125392 [07:21:15] (03CR) 10Prtksxna: "Matt, you are right. As it now depends on time instead of `animationend` we can't be sure when it would trigger. Yes, hiding it before rem" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125392 (owner: 10Prtksxna) [07:25:21] (03CR) 10Legoktm: [C: 031] Fix some issues with Microsoft SQL Server support [core] - 10https://gerrit.wikimedia.org/r/127872 (owner: 10Skizzerz) [07:33:50] (03CR) 10Nikerabbit: [C: 04-1] "i18n review" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127866 (owner: 10Gerrit Patch Uploader) [07:34:58] (03PS1) 10Dan-nl: mark method visibleMetadataFields as public [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/127876 [07:35:01] (03PS1) 10Chad: Remove unused global [extensions/Offline] - 10https://gerrit.wikimedia.org/r/127877 [07:36:53] (03CR) 10Legoktm: [C: 032] Remove unused global [extensions/Offline] - 10https://gerrit.wikimedia.org/r/127877 (owner: 10Chad) [07:36:55] (03Merged) 10jenkins-bot: Remove unused global [extensions/Offline] - 10https://gerrit.wikimedia.org/r/127877 (owner: 10Chad) [07:43:40] (03PS3) 10Legoktm: API: Add prop=flowinfo to detect if Flow is enabled on a page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111255 [07:43:44] (03CR) 10Legoktm: API: Add prop=flowinfo to detect if Flow is enabled on a page (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111255 (owner: 10Legoktm) [07:44:57] (03CR) 10Nikerabbit: [C: 032] Remove unused message 'notacceptable' [core] - 10https://gerrit.wikimedia.org/r/127855 (owner: 10PleaseStand) [07:46:30] (03CR) 10Nemo bis: "What happens if the database contains wrong hash? Bug 17057." [core] - 10https://gerrit.wikimedia.org/r/127460 (owner: 10Aaron Schulz) [07:48:02] (03Merged) 10jenkins-bot: Remove unused message 'notacceptable' [core] - 10https://gerrit.wikimedia.org/r/127855 (owner: 10PleaseStand) [07:49:53] (03CR) 10Nikerabbit: [C: 032] Remove unused message 'dberr-header' [core] - 10https://gerrit.wikimedia.org/r/127852 (owner: 10PleaseStand) [07:52:16] (03CR) 10Nikerabbit: [C: 032] Remove 3 unused upload related error messages [core] - 10https://gerrit.wikimedia.org/r/127853 (owner: 10PleaseStand) [07:52:48] (03Merged) 10jenkins-bot: Remove unused message 'dberr-header' [core] - 10https://gerrit.wikimedia.org/r/127852 (owner: 10PleaseStand) [07:53:56] (03PS1) 10Chad: Clean up database-backed SearchResultSets [core] - 10https://gerrit.wikimedia.org/r/127878 [07:54:32] (03PS2) 10Chad: Clean up database-backed SearchResultSets [core] - 10https://gerrit.wikimedia.org/r/127878 [07:54:54] (03CR) 10jenkins-bot: [V: 04-1] Clean up database-backed SearchResultSets [core] - 10https://gerrit.wikimedia.org/r/127878 (owner: 10Chad) [07:55:49] (03Merged) 10jenkins-bot: Remove 3 unused upload related error messages [core] - 10https://gerrit.wikimedia.org/r/127853 (owner: 10PleaseStand) [08:01:57] (03CR) 10Nikerabbit: "This is follow-up to I1e94128e" [core] - 10https://gerrit.wikimedia.org/r/127818 (owner: 10Mattflaschen) [08:03:08] (03PS1) 10Chad: Remove "Go" behavior from Special:Search [core] - 10https://gerrit.wikimedia.org/r/127879 [08:04:31] (03PS2) 10Chad: Remove "Go" behavior from Special:Search [core] - 10https://gerrit.wikimedia.org/r/127879 [08:13:56] (03CR) 10Nikerabbit: [C: 032] generateJsonI18n.php: Use tabs for indentation [core] - 10https://gerrit.wikimedia.org/r/127791 (owner: 10PleaseStand) [08:16:57] (03Merged) 10jenkins-bot: generateJsonI18n.php: Use tabs for indentation [core] - 10https://gerrit.wikimedia.org/r/127791 (owner: 10PleaseStand) [08:18:20] (03CR) 10Nikerabbit: "Would be nice if you could file a bug or patch against SMW to introduce its own message." [core] - 10https://gerrit.wikimedia.org/r/127799 (owner: 10PleaseStand) [08:19:38] (03CR) 10Nikerabbit: "I would default to protected instead of private." [core] - 10https://gerrit.wikimedia.org/r/127677 (owner: 10Siebrand) [08:26:34] (03CR) 10Prtksxna: Fix placement issue for smaller images (037 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/121607 (owner: 10Prtksxna) [08:28:26] (03CR) 10Nikerabbit: Make languages/ pass phpcs-strict (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127678 (owner: 10Siebrand) [08:38:34] (03PS1) 10Siebrand: generateJsonI18n.php: Use tabs for indentation [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127880 [08:41:25] (03CR) 10Siebrand: Make languages/ pass phpcs-strict (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127678 (owner: 10Siebrand) [08:47:10] (03CR) 10Siebrand: "Replies." (035 comments) [core] - 10https://gerrit.wikimedia.org/r/127676 (owner: 10Siebrand) [08:48:22] (03CR) 10Siebrand: [C: 032] Remove 4 unused live preview messages [core] - 10https://gerrit.wikimedia.org/r/127799 (owner: 10PleaseStand) [08:51:21] (03Merged) 10jenkins-bot: Remove 4 unused live preview messages [core] - 10https://gerrit.wikimedia.org/r/127799 (owner: 10PleaseStand) [08:52:40] (03PS1) 10Chad: Remove useless comments from search output [core] - 10https://gerrit.wikimedia.org/r/127881 [08:56:23] (03CR) 10Chad: [C: 031] Removed $wgImgAuthPublicTest [core] - 10https://gerrit.wikimedia.org/r/127701 (owner: 10Aaron Schulz) [08:58:52] (03PS1) 10Siebrand: Remove unused message 'livepreview-loading' [core] - 10https://gerrit.wikimedia.org/r/127883 [09:01:09] (03CR) 10Nikerabbit: [C: 032] "Not perfect bug progress..." [core] - 10https://gerrit.wikimedia.org/r/127678 (owner: 10Siebrand) [09:02:30] (03PS2) 10Siebrand: Make languages/ pass phpcs-strict [core] - 10https://gerrit.wikimedia.org/r/127678 [09:02:55] (03CR) 10Siebrand: [C: 032] "Per Niklas, with deps removed." [core] - 10https://gerrit.wikimedia.org/r/127678 (owner: 10Siebrand) [09:06:14] (03Merged) 10jenkins-bot: Make languages/ pass phpcs-strict [core] - 10https://gerrit.wikimedia.org/r/127678 (owner: 10Siebrand) [09:09:04] (03PS1) 10Siebrand: Put class FakeConverter in its own file [core] - 10https://gerrit.wikimedia.org/r/127884 [09:10:48] (03CR) 10Siebrand: [C: 032] Remove useless comments from search output [core] - 10https://gerrit.wikimedia.org/r/127881 (owner: 10Chad) [09:11:50] (03CR) 10Siebrand: "@niklas: There's no subclassing done currently. If there ever needs to be, isn't it easy to widen access?" [core] - 10https://gerrit.wikimedia.org/r/127677 (owner: 10Siebrand) [09:13:16] (03PS1) 10Hiong3-eng5: Editor select + PHP API [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/127885 [09:13:22] (03CR) 10Siebrand: "Can we please start making progress on this? Once this has been merged, I'll have to make around 1000 or so follow-ups." [core] - 10https://gerrit.wikimedia.org/r/125706 (owner: 10PleaseStand) [09:13:53] (03Merged) 10jenkins-bot: Remove useless comments from search output [core] - 10https://gerrit.wikimedia.org/r/127881 (owner: 10Chad) [09:16:57] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127866 (owner: 10Gerrit Patch Uploader) [09:17:09] (03CR) 10Hiong3-eng5: "I separate this from "MW WLD prefix compatibility fix"" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/127885 (owner: 10Hiong3-eng5) [09:21:11] (03CR) 10Siebrand: "I don't care left or right, just as long as my PHPCS fixes aren't being -1-ed because one or more devs don't agree with the checks." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/127863 (owner: 10Chad) [09:33:43] (03CR) 10Reedy: [C: 032] mark method visibleMetadataFields as public [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/127876 (owner: 10Dan-nl) [09:33:48] (03Merged) 10jenkins-bot: mark method visibleMetadataFields as public [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/127876 (owner: 10Dan-nl) [09:34:38] (03PS1) 10Reedy: mark method visibleMetadataFields as public [extensions/PagedTiffHandler] (REL1_23) - 10https://gerrit.wikimedia.org/r/127887 [09:35:45] (03CR) 10Fomafix: "Yes, it doesn't work in IE8 although it supports box-sizing (http://caniuse.com/#search=box-sizing)." [core] - 10https://gerrit.wikimedia.org/r/127371 (owner: 10Gerrit Patch Uploader) [09:36:24] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (035 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/127839 (owner: 10Dan-nl) [09:36:29] (03PS1) 10Reedy: Revert "mark method visibleMetadataFields as public" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/127888 [09:36:40] (03CR) 10Reedy: [C: 032] Revert "mark method visibleMetadataFields as public" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/127888 (owner: 10Reedy) [09:36:45] (03Merged) 10jenkins-bot: Revert "mark method visibleMetadataFields as public" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/127888 (owner: 10Reedy) [09:37:19] (03CR) 10Siebrand: "In core there were some zh-* files that I thought could get some more thought." [core] - 10https://gerrit.wikimedia.org/r/125143 (owner: 10Siebrand) [09:40:42] (03CR) 10Siebrand: [C: 032] Fixed some @params documentation (includes/parser) [core] - 10https://gerrit.wikimedia.org/r/127663 (owner: 10Umherirrender) [09:43:44] (03Merged) 10jenkins-bot: Fixed some @params documentation (includes/parser) [core] - 10https://gerrit.wikimedia.org/r/127663 (owner: 10Umherirrender) [09:45:44] (03PS1) 10Prtksxna: Check if revisions exist before getting a timestamp [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127889 [09:45:49] (03CR) 10jenkins-bot: [V: 04-1] Check if revisions exist before getting a timestamp [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127889 (owner: 10Prtksxna) [09:45:59] (03CR) 10Nikerabbit: "Sure. Just added my opinion." [core] - 10https://gerrit.wikimedia.org/r/127677 (owner: 10Siebrand) [09:48:01] (03PS2) 10Prtksxna: Check if revisions exist before getting a timestamp [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127889 [09:48:05] (03CR) 10jenkins-bot: [V: 04-1] Check if revisions exist before getting a timestamp [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127889 (owner: 10Prtksxna) [09:50:38] (03CR) 10Phuedx: [V: 032] "Thanks Mattflaschen!" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/127795 (owner: 10Mattflaschen) [09:50:59] (03CR) 10Phuedx: [C: 032] "Thanks Mattflaschen!" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/127795 (owner: 10Mattflaschen) [09:51:03] (03Merged) 10jenkins-bot: Add .jshintignore so jshint works locally [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/127795 (owner: 10Mattflaschen) [09:51:41] (03CR) 10Prtksxna: "I don't think TextExtracts are generated for any Special pages. If that is true then we could abandon this patch and decide what needs to " [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127889 (owner: 10Prtksxna) [09:54:27] (03CR) 10Siebrand: [C: 032] "Nice. Left some inline comments. Please have a look. A few may be reason to submit a follow-up." (036 comments) [core] - 10https://gerrit.wikimedia.org/r/127487 (owner: 10Umherirrender) [09:57:34] (03Merged) 10jenkins-bot: Fixed some @params documentation (includes/*) [core] - 10https://gerrit.wikimedia.org/r/127487 (owner: 10Umherirrender) [09:59:08] (03PS1) 10Alexandros Kosiaris: Update luasandbox debian version to 1.9 [php/luasandbox] - 10https://gerrit.wikimedia.org/r/127891 [10:02:42] (03CR) 10Siebrand: [C: 032] "Thanks again." [core] - 10https://gerrit.wikimedia.org/r/127583 (owner: 10Umherirrender) [10:05:51] (03Merged) 10jenkins-bot: Fixed some @params documentation (includes/*) [core] - 10https://gerrit.wikimedia.org/r/127583 (owner: 10Umherirrender) [10:06:50] (03CR) 10Alexandros Kosiaris: [C: 032] Update luasandbox debian version to 1.9 [php/luasandbox] - 10https://gerrit.wikimedia.org/r/127891 (owner: 10Alexandros Kosiaris) [10:08:19] (03CR) 10Siebrand: "Follow-up in https://gerrit.wikimedia.org/r/#/c/127818/" [core] - 10https://gerrit.wikimedia.org/r/103387 (owner: 10Yaron Koren) [10:08:38] (03CR) 10Nikerabbit: [C: 032] "I don't really care for PHP 5.2.x support but it's already done and these are not staying forever anyway." [core] - 10https://gerrit.wikimedia.org/r/125706 (owner: 10PleaseStand) [10:09:00] \o/ [10:09:11] now siebrand can make 600 more commits :p [10:09:37] Nemo_bis: Actually, twice that number, as those also have to land in REL1_23. [10:11:35] (03Merged) 10jenkins-bot: JSON i18n shim: Only register LocalisationCacheRecache handler once [core] - 10https://gerrit.wikimedia.org/r/125706 (owner: 10PleaseStand) [10:13:56] (03PS34) 10Werdna: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 [10:14:05] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [10:14:35] siebrand: yes, I commented about that in another bug: isn't it easier to delete extension branches and rebranch? [10:15:10] so far no backports were made to REL1_23 in extensions AFAIK [10:16:14] sorry; only one https://gerrit.wikimedia.org/r/#/q/project:%255Emediawiki/extensions/.%252B+branch:REL1_23,n,z [10:16:36] (03CR) 10Nikerabbit: [C: 032] Put class FakeConverter in its own file [core] - 10https://gerrit.wikimedia.org/r/127884 (owner: 10Siebrand) [10:16:42] (not merged yet) [10:16:58] (03CR) 10Nikerabbit: [C: 031] "Should I wait for release manager to approve?" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127880 (owner: 10Siebrand) [10:17:33] (03CR) 10Nemo bis: [C: 031] "No" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127880 (owner: 10Siebrand) [10:17:38] (03CR) 10Siebrand: "Markus and Mark don't mind if we do work for them." [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127880 (owner: 10Siebrand) [10:19:08] (03PS1) 10Siebrand: JSON i18n shim: Only register LocalisationCacheRecache handler once [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127893 [10:19:24] (03CR) 10Dan-nl: [C: 031] mark method visibleMetadataFields as public [extensions/PagedTiffHandler] (REL1_23) - 10https://gerrit.wikimedia.org/r/127887 (owner: 10Reedy) [10:20:04] (03Merged) 10jenkins-bot: Put class FakeConverter in its own file [core] - 10https://gerrit.wikimedia.org/r/127884 (owner: 10Siebrand) [10:20:51] Nikerabbit: Would be nice if you could +2 these 4: https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/core+branch:REL1_23+owner:%22Siebrand+%253Csiebrand%2540kitano.nl%253E%22,n,z [10:21:59] (03CR) 10Nikerabbit: [C: 032] generateJsonI18n.php: Use tabs for indentation [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127880 (owner: 10Siebrand) [10:24:55] (03Merged) 10jenkins-bot: generateJsonI18n.php: Use tabs for indentation [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127880 (owner: 10Siebrand) [10:26:09] (03CR) 10Nikerabbit: "Note: Just regenerating the shims is not enough to restore 5.2 compatibility, because __DIR__ was also used in the setup files." [core] - 10https://gerrit.wikimedia.org/r/125706 (owner: 10PleaseStand) [10:36:17] (03PS2) 10Zfilipin: Run only scenarios tagged both @clean and @phantomjs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126258 [10:48:25] (03CR) 10Yuvipanda: [C: 04-1] Disable NavigationPopups (Gadget) is Popups (Extension) is enabled (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (owner: 10Prtksxna) [10:51:38] (03PS15) 10Prtksxna: Disable NavigationPopups (Gadget) is Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 [10:52:48] (03PS4) 10Phuedx: Use "article" instead of "page" only on Wikipedia [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/127030 [10:57:09] (03CR) 10Yuvipanda: [C: 032] Ignore `internal` class for links [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127616 (owner: 10Prtksxna) [10:57:16] (03Merged) 10jenkins-bot: Ignore `internal` class for links [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127616 (owner: 10Prtksxna) [10:57:36] (03CR) 10Yuvipanda: [C: 032] Fix border issue with non-flipped landscape hovercards [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125690 (owner: 10Prtksxna) [10:57:44] (03Merged) 10jenkins-bot: Fix border issue with non-flipped landscape hovercards [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125690 (owner: 10Prtksxna) [11:00:40] (03PS16) 10Nemo bis: Disable NavigationPopups (Gadget) if Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (owner: 10Prtksxna) [11:00:58] (03CR) 10Nemo bis: "Fixed typo again. Please use git review -d, or you'll keep reintroducing the error." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (owner: 10Prtksxna) [11:02:02] Nemo_bis: Sorry! [11:03:03] yuvipanda: https://bugzilla.wikimedia.org/show_bug.cgi?id=63159 [11:03:15] yuvipanda: specifically https://bugzilla.wikimedia.org/attachment.cgi?id=15091 [11:04:07] (03PS3) 10Yuvipanda: Position hovercard according to mouse position [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125577 (owner: 10Prtksxna) [11:04:26] (03CR) 10Yuvipanda: [C: 032] "The pokey is off by a bit, but from the bug report that looks ok." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125577 (owner: 10Prtksxna) [11:04:30] (03Merged) 10jenkins-bot: Position hovercard according to mouse position [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125577 (owner: 10Prtksxna) [11:09:06] (03PS1) 10Umherirrender: Fixed some @params documentation (includes/*) [core] - 10https://gerrit.wikimedia.org/r/127897 [11:16:37] (03PS3) 10Yuvipanda: Remove viewBox from SVG, not needed. [extensions/Popups] - 10https://gerrit.wikimedia.org/r/124296 (owner: 10Prtksxna) [11:16:42] (03CR) 10Yuvipanda: [C: 032] Remove viewBox from SVG, not needed. [extensions/Popups] - 10https://gerrit.wikimedia.org/r/124296 (owner: 10Prtksxna) [11:16:48] (03Merged) 10jenkins-bot: Remove viewBox from SVG, not needed. [extensions/Popups] - 10https://gerrit.wikimedia.org/r/124296 (owner: 10Prtksxna) [11:17:42] (03CR) 10Prtksxna: [V: 04-1] Replace animiationend with setTimeout [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125392 (owner: 10Prtksxna) [11:17:56] yuvipanda: https://gerrit.wikimedia.org/r/#/c/117169/ [11:19:42] (03CR) 10Bartosz Dziewoński: "Yeah, we generally try to avoid doing anything but cherry-picks on release branches. You can probably use the "Cherry Pick" button here to" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127586 (owner: 10Jjanes) [11:21:52] yuvipanda: https://bugzilla.wikimedia.org/show_bug.cgi?id=62971 + https://bugzilla.wikimedia.org/show_bug.cgi?id=62947 [11:25:42] yuvipanda: Thanks \o [11:25:54] prtksxna: o/ [11:36:17] (03PS1) 10Zfilipin: WIP: take a screenshot when a test fails [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127899 [11:43:37] (03PS1) 10Bartosz Dziewoński: Apply whitespace code conventions in LESS files [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127900 [11:43:39] (03PS1) 10Bartosz Dziewoński: Popups.php: Remove unused top-level variables [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127901 [11:43:48] (03CR) 10Siebrand: [C: 032] "A few comments for follow-up." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/127897 (owner: 10Umherirrender) [11:45:04] (03CR) 10Siebrand: [C: 032] Apply whitespace code conventions in LESS files [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127900 (owner: 10Bartosz Dziewoński) [11:45:08] (03Merged) 10jenkins-bot: Apply whitespace code conventions in LESS files [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127900 (owner: 10Bartosz Dziewoński) [11:46:18] (03CR) 10PiRSquared17: Show number of displayed pages on WhatLinksHere (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127866 (owner: 10Gerrit Patch Uploader) [11:46:36] (03Merged) 10jenkins-bot: Fixed some @params documentation (includes/*) [core] - 10https://gerrit.wikimedia.org/r/127897 (owner: 10Umherirrender) [11:47:31] (03CR) 10KartikMistry: [C: 031] "As noted," [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127899 (owner: 10Zfilipin) [11:57:12] (03CR) 10Smuggli: "Is here anything missing that this can be merged?" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/124804 (owner: 10Smuggli) [11:57:44] (03CR) 10Siebrand: [C: 032 V: 032] Implemented changes for getting into translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/124804 (owner: 10Smuggli) [11:57:56] (03CR) 10Smuggli: "Is here anything missing that this can be merged?" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/124807 (owner: 10Smuggli) [11:58:06] (03CR) 10Smuggli: "Is here anything missing that this can be merged?" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/124808 (owner: 10Smuggli) [11:58:08] (03CR) 10Siebrand: [C: 032 V: 032] Implemented changes for getting into translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/124810 (owner: 10Smuggli) [11:58:18] (03CR) 10Smuggli: "Is here anything missing that this can be merged?" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/124810 (owner: 10Smuggli) [11:58:21] (03CR) 10Siebrand: [C: 032 V: 032] Implemented changes for getting into translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/124807 (owner: 10Smuggli) [11:58:37] (03CR) 10Siebrand: [C: 032 V: 032] Implemented changes for getting into translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/124808 (owner: 10Smuggli) [12:01:08] (03CR) 10Smuggli: "Thank you for merging that fast :)" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/124804 (owner: 10Smuggli) [12:01:42] (03CR) 10Smuggli: "Thank you for merging that fast :)" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/124810 (owner: 10Smuggli) [12:02:00] (03CR) 10Smuggli: "Thank you for merging that fast :)" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/124808 (owner: 10Smuggli) [12:02:09] (03CR) 10Siebrand: [C: 032] Use $specialPageAliases [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/123612 (owner: 10Nikerabbit) [12:02:11] (03CR) 10Smuggli: "Thank you for merging that fast :)" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/124807 (owner: 10Smuggli) [12:02:13] (03Merged) 10jenkins-bot: Use $specialPageAliases [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/123612 (owner: 10Nikerabbit) [12:02:28] (03CR) 10Siebrand: [C: 032 V: 032] Use $specialPageAliases [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/123613 (owner: 10Nikerabbit) [12:04:26] (03Abandoned) 10Siebrand: Updated Special:GlobalUsers to show creation date of global user account [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 (owner: 10Apsdehal) [12:06:12] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105141 (owner: 10TTO) [12:06:26] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107786 (owner: 10Reedy) [12:06:43] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [extensions/CommonMessages] - 10https://gerrit.wikimedia.org/r/115390 (owner: 10Legoktm) [12:07:21] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 (owner: 10Mayankmadan) [12:07:37] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/101494 (owner: 10Apsdehal) [12:07:58] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/87322 (owner: 10Netbrain) [12:08:04] (03PS6) 10Werdna: Implement multiPut method. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120734 [12:08:17] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [core] - 10https://gerrit.wikimedia.org/r/114966 (owner: 10Mjnovice) [12:08:34] (03CR) 10Siebrand: "This patch set has been idle for a long time with one or more open comments. It will be abandoned if there are no code updates within a we" [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/118945 (owner: 10MarkAHershberger) [12:09:55] (03PS2) 10Siebrand: Make languages/utils pass phpcs-strict [core] - 10https://gerrit.wikimedia.org/r/127677 [12:10:18] (03Abandoned) 10Werdna: Add new jquery.scroll.js plugin [core] - 10https://gerrit.wikimedia.org/r/96949 (owner: 10Werdna) [12:12:25] (03CR) 10Nemo bis: "Wow, and it's not even 5 months old. :)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 (owner: 10Apsdehal) [12:13:05] (03PS2) 10Siebrand: Make languages/classes pass phpcs-strict [core] - 10https://gerrit.wikimedia.org/r/127676 [12:13:32] (03CR) 10Siebrand: Make languages/classes pass phpcs-strict (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127676 (owner: 10Siebrand) [12:17:23] (03PS7) 10Umherirrender: Add jquery.accessKeyLabel javascript module [core] - 10https://gerrit.wikimedia.org/r/125426 [12:19:28] (03CR) 10Umherirrender: "Patch Set 7: Addressed the issue with the newly created tooltip (is no avoided) and also addressed bug 63849" [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [12:19:42] (03CR) 10Werdna: [C: 032] Fix potential issue in ::convertUUIDs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125963 (owner: 10Matthias Mullie) [12:19:56] (03Merged) 10jenkins-bot: Fix potential issue in ::convertUUIDs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/125963 (owner: 10Matthias Mullie) [12:21:06] (03PS8) 10Umherirrender: Add jquery.accessKeyLabel javascript module [core] - 10https://gerrit.wikimedia.org/r/125426 [12:23:46] (03CR) 10Werdna: [C: 032] HTMLForm: fix double escaping of checkbox labels in vform [core] - 10https://gerrit.wikimedia.org/r/126004 (owner: 10Pcoombe) [12:24:27] (03CR) 10jenkins-bot: [V: 04-1] HTMLForm: fix double escaping of checkbox labels in vform [core] - 10https://gerrit.wikimedia.org/r/126004 (owner: 10Pcoombe) [12:30:21] (03CR) 10Matthias Mullie: [C: 032] Fix topic hidden message when collapsed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127858 (owner: 10SG) [12:30:36] (03Merged) 10jenkins-bot: Fix topic hidden message when collapsed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127858 (owner: 10SG) [12:30:45] (03CR) 10Siebrand: "@nikerabbit: __DIR__ to dirname( __FILE__ ) is not something I'm going to do." [core] - 10https://gerrit.wikimedia.org/r/125706 (owner: 10PleaseStand) [12:31:13] (03CR) 10Siebrand: "There's a problem updating the script. I'm getting output like this:" [core] - 10https://gerrit.wikimedia.org/r/125706 (owner: 10PleaseStand) [12:32:41] (03CR) 10Apsdehal: "Hi, Nemo" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 (owner: 10Apsdehal) [12:32:43] (03CR) 10TTO: "Don't abandon it; it needs some i18n work which I will get around to eventually." [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105141 (owner: 10TTO) [12:35:28] (03CR) 10Siebrand: "It could be the way that I'm executing the script. I'll see if I can do it differently." [core] - 10https://gerrit.wikimedia.org/r/125706 (owner: 10PleaseStand) [12:36:54] (03PS1) 10Matthias Mullie: Fix topic hidden message when collapsed [extensions/Flow] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127903 [12:37:26] (03CR) 10Matthias Mullie: [C: 032] Fix topic hidden message when collapsed [extensions/Flow] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127903 (owner: 10Matthias Mullie) [12:37:41] (03Merged) 10jenkins-bot: Fix topic hidden message when collapsed [extensions/Flow] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127903 (owner: 10Matthias Mullie) [12:43:03] (03PS1) 10Bartosz Dziewoński: ext.popups.core.js: Whitespace cleanup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127904 [12:43:05] (03PS1) 10Bartosz Dziewoński: Always wait at least 150ms before displaying the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127905 [12:43:19] (03PS2) 10Werdna: HTMLForm: fix double escaping of checkbox labels in vform [core] - 10https://gerrit.wikimedia.org/r/126004 (owner: 10Pcoombe) [12:44:20] (03CR) 10Phuedx: Use "article" instead of "page" only on Wikipedia (032 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/127030 (owner: 10Phuedx) [12:50:22] (03CR) 10Manybubbles: [C: 032] Use CJK for Japanese and Korean [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127874 (owner: 10Chad) [12:50:34] (03Merged) 10jenkins-bot: Use CJK for Japanese and Korean [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127874 (owner: 10Chad) [12:51:05] (03CR) 10Nemo bis: "> Hi, Nemo I need some guidance regarding the design." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 (owner: 10Apsdehal) [12:54:49] (03PS1) 10Bartosz Dziewoński: Do not call decodeURI() on non-URIs [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127907 [13:06:37] (03PS2) 10Dan-nl: preview without upload [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/127839 [13:07:41] (03CR) 10Dan-nl: "* addressing comments in ps1." (035 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/127839 (owner: 10Dan-nl) [13:08:56] hey yuvipanda, did you happen to see this yet? https://gerrit.wikimedia.org/r/#/c/125913/ [13:16:31] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/127839 (owner: 10Dan-nl) [13:27:56] (03CR) 10Dan-nl: "* addressing comments in ps2." (032 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/127839 (owner: 10Dan-nl) [13:30:15] (03CR) 10Hashar: [C: 032] Remove two-dot ellipsis from the postbuild message [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127376 (owner: 10Amire80) [13:30:26] (03Merged) 10jenkins-bot: Remove two-dot ellipsis from the postbuild message [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127376 (owner: 10Amire80) [13:30:36] (03PS3) 10Hashar: zuul config for GoogleAppEngine extension jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127416 (owner: 10Legoktm) [13:30:40] (03CR) 10Hashar: [C: 032] zuul config for GoogleAppEngine extension jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127416 (owner: 10Legoktm) [13:30:54] (03Merged) 10jenkins-bot: zuul config for GoogleAppEngine extension jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127416 (owner: 10Legoktm) [13:31:20] (03CR) 10TheDJ: Add jquery.accessKeyLabel javascript module (032 comments) [core] - 10https://gerrit.wikimedia.org/r/125426 (owner: 10Umherirrender) [13:32:38] (03CR) 10Hashar: [C: 032] Add jobs for GoogleAppEngine extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/127417 (owner: 10Legoktm) [13:33:04] (03Merged) 10jenkins-bot: Add jobs for GoogleAppEngine extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/127417 (owner: 10Legoktm) [13:34:31] (03PS2) 10Zfilipin: Take a screenshot when a test fails [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127899 [13:34:45] (03PS3) 10Zfilipin: Take a screenshot when a test fails [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127899 [13:35:44] (03CR) 10Hashar: [C: 031] "I dont mind. Whenever this is merged, one will have to update the related submodule in integration/jenkins.git (path: tools/mwcodesniffer " [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/127863 (owner: 10Chad) [13:38:09] (03PS2) 10Aude: Add method to determine EnhancedChangesList cache grouping key [core] - 10https://gerrit.wikimedia.org/r/125391 [13:38:24] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/127839 (owner: 10Dan-nl) [13:39:37] (03CR) 10WikidataJenkins: "Build Successful" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/128239 (owner: 10L10n-bot) [13:45:05] (03PS1) 10Bartosz Dziewoński: Extract some magic timeout values [extensions/Popups] - 10https://gerrit.wikimedia.org/r/128318 [13:49:07] (03Abandoned) 10Hashar: Use stored password file [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/85109 (owner: 10Merlijn van Deen) [13:49:11] (03CR) 10TheDJ: "I think it would be good if we made a class to do this, instead of using inline styling. "visualClear" actually already exists, but it is " [core] - 10https://gerrit.wikimedia.org/r/127624 (owner: 10Gerrit Patch Uploader) [13:51:41] (03PS1) 10Bartosz Dziewoński: Prettify the embedded SVG code [extensions/Popups] - 10https://gerrit.wikimedia.org/r/128387 [13:56:16] (03PS1) 10Bartosz Dziewoński: Use :not() CSS pseudo-class instead of jQuery .not() filter in selector [extensions/Popups] - 10https://gerrit.wikimedia.org/r/128432 [13:59:40] (03CR) 10Hashar: [C: 04-1] "I would avoid sending a failure email every 10 minutes to the list. Instead consider notifying on state change :) Feel free to merge when" (032 comments) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126870 (owner: 10BryanDavis) [14:02:15] (03CR) 10TheDJ: Change X-UA-Compatible from tag to HTTP header (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127818 (owner: 10Mattflaschen) [14:07:36] (03PS2) 10Yuvipanda: Popups.php: Remove unused top-level variables [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127901 (owner: 10Bartosz Dziewoński) [14:07:42] (03CR) 10Yuvipanda: [C: 032] Popups.php: Remove unused top-level variables [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127901 (owner: 10Bartosz Dziewoński) [14:07:46] (03Merged) 10jenkins-bot: Popups.php: Remove unused top-level variables [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127901 (owner: 10Bartosz Dziewoński) [14:08:04] (03CR) 10Yuvipanda: [C: 032] ext.popups.core.js: Whitespace cleanup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127904 (owner: 10Bartosz Dziewoński) [14:08:56] (03CR) 10Yuvipanda: [C: 032] Prettify the embedded SVG code [extensions/Popups] - 10https://gerrit.wikimedia.org/r/128387 (owner: 10Bartosz Dziewoński) [14:09:31] (03CR) 10Yuvipanda: [C: 032] Use :not() CSS pseudo-class instead of jQuery .not() filter in selector [extensions/Popups] - 10https://gerrit.wikimedia.org/r/128432 (owner: 10Bartosz Dziewoński) [14:09:43] (03PS2) 10Yuvipanda: ext.popups.core.js: Whitespace cleanup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127904 (owner: 10Bartosz Dziewoński) [14:10:11] (03PS2) 10Yuvipanda: Prettify the embedded SVG code [extensions/Popups] - 10https://gerrit.wikimedia.org/r/128387 (owner: 10Bartosz Dziewoński) [14:13:35] (03CR) 10TheDJ: "We should get someone with varnish knowledge to sign off, I remember vaguely that varnish was the reason we preferred the meta element the" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127818 (owner: 10Mattflaschen) [14:14:48] (03Abandoned) 10Siebrand: Update i18n shim [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/128441 (owner: 10L10n-bot) [14:14:55] (03Abandoned) 10Siebrand: Update i18n shim [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/128440 (owner: 10L10n-bot) [14:15:00] (03Abandoned) 10Siebrand: Update i18n shim [extensions/AddThis] - 10https://gerrit.wikimedia.org/r/128439 (owner: 10L10n-bot) [14:15:05] (03Abandoned) 10Siebrand: Update i18n shim [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/128438 (owner: 10L10n-bot) [14:15:09] (03Abandoned) 10Siebrand: Update i18n shim [extensions/AccountAudit] - 10https://gerrit.wikimedia.org/r/128437 (owner: 10L10n-bot) [14:15:14] (03Abandoned) 10Siebrand: Update i18n shim [extensions/AccessControl] - 10https://gerrit.wikimedia.org/r/128436 (owner: 10L10n-bot) [14:15:18] (03Abandoned) 10Siebrand: Update i18n shim [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/128435 (owner: 10L10n-bot) [14:15:23] (03Abandoned) 10Siebrand: Update i18n shim [extensions/AbsenteeLandlord] - 10https://gerrit.wikimedia.org/r/128434 (owner: 10L10n-bot) [14:18:12] (03CR) 10Hashar: [C: 04-1] "And now attach the screenshots to the Jenkins build report page :-]" (031 comment) [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/127899 (owner: 10Zfilipin) [14:20:40] (03PS1) 10Matthias Mullie: Fix regression 62073 in Flow [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/128449 [14:21:38] (03CR) 10Anomie: [C: 032] Use correct variable in require() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127588 (owner: 10Jackmcbarn) [14:21:50] (03PS1) 10Bartosz Dziewoński: Use mw.hook to rebind events after page content is reloaded [extensions/Popups] - 10https://gerrit.wikimedia.org/r/128455 [14:22:00] (03CR) 10Matthias Mullie: [C: 032] Fix regression 62073 in Flow [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/128449 (owner: 10Matthias Mullie) [14:23:05] (03Merged) 10jenkins-bot: Use correct variable in require() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127588 (owner: 10Jackmcbarn) [14:24:50] (03Merged) 10jenkins-bot: Fix regression 62073 in Flow [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/128449 (owner: 10Matthias Mullie) [14:27:41] (03Abandoned) 10Siebrand: Update i18n shim [extensions/AccountAudit] (REL1_23) - 10https://gerrit.wikimedia.org/r/128458 (owner: 10L10n-bot) [14:27:44] (03Abandoned) 10Siebrand: Update i18n shim [extensions/AccessControl] (REL1_23) - 10https://gerrit.wikimedia.org/r/128457 (owner: 10L10n-bot) [14:27:47] (03Abandoned) 10Siebrand: Update i18n shim [extensions/AbuseFilter] (REL1_23) - 10https://gerrit.wikimedia.org/r/128456 (owner: 10L10n-bot) [14:27:50] (03Abandoned) 10Siebrand: Update i18n shim [extensions/AbsenteeLandlord] (REL1_23) - 10https://gerrit.wikimedia.org/r/128454 (owner: 10L10n-bot) [14:27:54] (03Abandoned) 10Siebrand: Update i18n shim [extensions/AdminLinks] (REL1_23) - 10https://gerrit.wikimedia.org/r/128453 (owner: 10L10n-bot) [14:27:57] (03Abandoned) 10Siebrand: Update i18n shim [extensions/AdManager] (REL1_23) - 10https://gerrit.wikimedia.org/r/128452 (owner: 10L10n-bot) [14:28:02] (03Abandoned) 10Siebrand: Update i18n shim [extensions/AddThis] (REL1_23) - 10https://gerrit.wikimedia.org/r/128451 (owner: 10L10n-bot) [14:28:05] (03Abandoned) 10Siebrand: Update i18n shim [extensions/AccountInfo] (REL1_23) - 10https://gerrit.wikimedia.org/r/128450 (owner: 10L10n-bot) [14:28:08] (03Abandoned) 10Siebrand: Update i18n shim [extensions/AntiBot] (REL1_23) - 10https://gerrit.wikimedia.org/r/128448 (owner: 10L10n-bot) [14:28:11] (03Abandoned) 10Siebrand: Update i18n shim [extensions/Annotator] (REL1_23) - 10https://gerrit.wikimedia.org/r/128447 (owner: 10L10n-bot) [14:28:14] (03Abandoned) 10Siebrand: Update i18n shim [extensions/AllTimeZones] (REL1_23) - 10https://gerrit.wikimedia.org/r/128446 (owner: 10L10n-bot) [14:28:17] (03Abandoned) 10Siebrand: Update i18n shim [extensions/AkismetKlik] (REL1_23) - 10https://gerrit.wikimedia.org/r/128445 (owner: 10L10n-bot) [14:28:20] (03Abandoned) 10Siebrand: Update i18n shim [extensions/AJAXPoll] (REL1_23) - 10https://gerrit.wikimedia.org/r/128444 (owner: 10L10n-bot) [14:28:24] (03Abandoned) 10Siebrand: Update i18n shim [extensions/Agora] (REL1_23) - 10https://gerrit.wikimedia.org/r/128443 (owner: 10L10n-bot) [14:29:12] hey yuvipanda, did you happen to see this yet? https://gerrit.wikimedia.org/r/#/c/125913/. is there someone else that i should add as a reviewer? [14:30:34] (03CR) 10Yuvipanda: "Campaigns is 'Upload Campaigns' that provides https://commons.wikimedia.org/wiki/Campaign:wlm-in and similar things on commons." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/125913 (owner: 10Dan-nl) [14:30:38] dan-nl: aha! t hank you! [14:30:45] (03PS2) 10Yuvipanda: UploadWizard is missing a SpecialPageAlias for Campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/125913 (owner: 10Dan-nl) [14:32:18] (03CR) 10Yuvipanda: "I know the Campaigns extension is confusing in this context, but I found out about that extension only after I wrote Campaigns in UploadWi" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/125913 (owner: 10Dan-nl) [14:33:00] (03CR) 10Yuvipanda: [C: 032] "(https://commons.wikimedia.org/wiki/Special:Campaigns provides list of active campaigns)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/125913 (owner: 10Dan-nl) [14:33:05] dan-nl: thanks for the patch! [14:33:17] (03Merged) 10jenkins-bot: UploadWizard is missing a SpecialPageAlias for Campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/125913 (owner: 10Dan-nl) [14:36:18] yuvipanda: np, thanks for going over it [14:36:25] :) [14:48:27] (03PS1) 10Zfilipin: Do not display link to Sauce Labs when using local browser [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/128464 [14:50:15] (03CR) 10Anomie: "> I wonder if I8f1da51187b281fe4afc0d5a0c49f5caf3612e92 is related." [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader) [14:54:25] (03PS1) 10Raimond Spekking: Conssistency tweak: Remove period from end of message [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/128469 [14:57:32] (03PS8) 10Yurik: Allow mobile to reduce image quality [core] - 10https://gerrit.wikimedia.org/r/119661 [14:58:35] (03CR) 10jenkins-bot: [V: 04-1] Allow mobile to reduce image quality [core] - 10https://gerrit.wikimedia.org/r/119661 (owner: 10Yurik) [15:02:21] (03PS1) 10Raimond Spekking: Consistency tweak: Put LocalSettings.php in code tag [extensions/ViewFiles] - 10https://gerrit.wikimedia.org/r/128472 [15:03:57] legoktm: MatmaRex there's currently no way at all to have more than one edit protection status for an article, right? as in, it isn't exposed via the UI? [15:04:37] yuvipanda: it's not possible to set more than one, but who knows what sits in our databases [15:04:43] right [15:05:59] (03PS3) 10Pcoombe: Initial commit [extensions/Petition] - 10https://gerrit.wikimedia.org/r/126011 [15:06:56] (03CR) 10Siebrand: [C: 032 V: 032] Consistency tweak: Put LocalSettings.php in code tag [extensions/ViewFiles] - 10https://gerrit.wikimedia.org/r/128472 (owner: 10Raimond Spekking) [15:07:40] (03CR) 10Pcoombe: Initial commit (031 comment) [extensions/Petition] - 10https://gerrit.wikimedia.org/r/126011 (owner: 10Pcoombe) [15:09:06] manybubbles: How goes the SWAT deploy? [15:10:03] (03CR) 10Siebrand: [C: 032] Conssistency tweak: Remove period from end of message [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/128469 (owner: 10Raimond Spekking) [15:10:11] (03Merged) 10jenkins-bot: Conssistency tweak: Remove period from end of message [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/128469 (owner: 10Raimond Spekking) [15:11:31] Deskana: swatting as usual. in this case we've got a change that probebly deserves to be deployed but it kind of snuck in at the last minute and we're not sure if it actually had on wiki consensus. so chad is deploying it because it seems ok [15:11:35] fun fun [15:13:07] manybubbles: What change is that? [15:14:39] <^d> Deskana: https://gerrit.wikimedia.org/r/#/c/127479/ [15:14:54] (03PS9) 10Phuedx: Add a pre-/post-edit anonymous signup invitation [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125730 [15:14:56] (03PS6) 10Phuedx: Generate a token and use it to bucket users [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125188 [15:14:58] (03PS1) 10Phuedx: Enable the pre-/post-edit variants by bucket [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/128617 [15:16:06] * Deskana shrugs. [15:16:09] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125730 (owner: 10Phuedx) [15:16:11] (03CR) 10Anomie: [C: 04-1] "PHP warning if usprop is not specified:" [core] - 10https://gerrit.wikimedia.org/r/127859 (owner: 10Gergő Tisza) [15:23:16] (03CR) 10Halfak: [C: 031] "Tested bucketing proportions and confirmed expiration date." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125188 (owner: 10Phuedx) [15:27:32] (03PS3) 10Matthias Mullie: [WIP] search [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126996 [15:40:43] (03PS2) 10Aaron Schulz: Avoid uncommitted transaction notices in thumb.php and img_auth.php [core] - 10https://gerrit.wikimedia.org/r/127868 [15:41:58] (03CR) 10Chad: [C: 032] Avoid uncommitted transaction notices in thumb.php and img_auth.php [core] - 10https://gerrit.wikimedia.org/r/127868 (owner: 10Aaron Schulz) [15:43:16] (03PS12) 10Anomie: HTMLForm: Add "cloner" type [core] - 10https://gerrit.wikimedia.org/r/118113 [15:43:19] (03PS11) 10Anomie: Release notes for recent HTMLForm changes [core] - 10https://gerrit.wikimedia.org/r/118114 [15:43:21] (03PS9) 10Anomie: HTMLForm: Add hide-if [core] - 10https://gerrit.wikimedia.org/r/118110 [15:44:17] (03CR) 10jenkins-bot: [V: 04-1] HTMLForm: Add "cloner" type [core] - 10https://gerrit.wikimedia.org/r/118113 (owner: 10Anomie) [15:45:18] (03CR) 10jenkins-bot: [V: 04-1] Release notes for recent HTMLForm changes [core] - 10https://gerrit.wikimedia.org/r/118114 (owner: 10Anomie) [15:45:59] (03Merged) 10jenkins-bot: Avoid uncommitted transaction notices in thumb.php and img_auth.php [core] - 10https://gerrit.wikimedia.org/r/127868 (owner: 10Aaron Schulz) [15:46:07] woo [15:46:16] * ebernhardson likes less uncommitted transactions complaints :) [15:47:18] (03CR) 10Anomie: "I'm not too fond of the .html() call either, but in this case it should be reasonably safe since the text being passed to .html() is basic" [core] - 10https://gerrit.wikimedia.org/r/118113 (owner: 10Anomie) [15:47:30] (03CR) 10Anomie: HTMLForm: Add "cloner" type (031 comment) [core] - 10https://gerrit.wikimedia.org/r/118113 (owner: 10Anomie) [15:48:28] (03CR) 10Siebrand: "All done, except for 3 backports that are waiting. Please review and merge them! https://gerrit.wikimedia.org/r/#/q/status:open+project:me" [core] - 10https://gerrit.wikimedia.org/r/125706 (owner: 10PleaseStand) [15:49:24] (03PS13) 10Anomie: HTMLForm: Add "cloner" type [core] - 10https://gerrit.wikimedia.org/r/118113 [15:49:26] (03PS12) 10Anomie: Release notes for recent HTMLForm changes [core] - 10https://gerrit.wikimedia.org/r/118114 [15:49:28] (03PS10) 10Anomie: HTMLForm: Add hide-if [core] - 10https://gerrit.wikimedia.org/r/118110 [15:51:36] (03CR) 10Anomie: "Right now the use is just in code I'm working on for SecurePoll. If you have ContactPage installed it makes a decent test bed for this sor" [core] - 10https://gerrit.wikimedia.org/r/118110 (owner: 10Anomie) [15:52:40] (03PS9) 10Yurik: Allow mobile to reduce image quality [core] - 10https://gerrit.wikimedia.org/r/119661 [15:52:47] ebernhardson: me too, there are many [15:53:27] (03PS1) 10PleaseStand: Remove use of message 'postcomment' [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/128939 [15:54:41] (03CR) 10Werdna: "A few bits and pieces." [extensions/Petition] - 10https://gerrit.wikimedia.org/r/126011 (owner: 10Pcoombe) [15:55:20] (03CR) 10Werdna: "Sorry, my comments seemed to be on this PS. Ignore whichever ones have been addressed." (035 comments) [extensions/Petition] - 10https://gerrit.wikimedia.org/r/126011 (owner: 10Pcoombe) [15:56:31] (03CR) 10Chad: [C: 032] Include pool type in pool counter log entries [core] - 10https://gerrit.wikimedia.org/r/127660 (owner: 10Aaron Schulz) [15:59:33] (03Merged) 10jenkins-bot: Include pool type in pool counter log entries [core] - 10https://gerrit.wikimedia.org/r/127660 (owner: 10Aaron Schulz) [16:02:06] (03CR) 10Anomie: [C: 031] "If it's what you must do." [core] - 10https://gerrit.wikimedia.org/r/120827 (owner: 10Thiemo Mättig (WMDE)) [16:17:12] (03CR) 10Aaron Schulz: [C: 032] Clean up database-backed SearchResultSets [core] - 10https://gerrit.wikimedia.org/r/127878 (owner: 10Chad) [16:17:21] (03Abandoned) 10Chad: Remove pointless $wgTitle and commented global mess [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/118422 (owner: 10Chad) [16:17:54] (03CR) 10jenkins-bot: [V: 04-1] Clean up database-backed SearchResultSets [core] - 10https://gerrit.wikimedia.org/r/127878 (owner: 10Chad) [16:18:19] (03CR) 10Chad: [C: 032 V: 032] Remove "useless override" rule from CodeSniffer [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/127863 (owner: 10Chad) [16:19:09] (03PS1) 10Chad: Updating mwcodesniffer to master [integration/jenkins] - 10https://gerrit.wikimedia.org/r/128942 [16:19:48] (03PS1) 10Aaron Schulz: Fixed slow query in LocalFileDeleteBatch::getHashes() [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/128943 [16:20:03] (03CR) 10Aaron Schulz: [C: 032] Fixed slow query in LocalFileDeleteBatch::getHashes() [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/128943 (owner: 10Aaron Schulz) [16:22:17] (03CR) 10Chad: [C: 032] Make languages/classes pass phpcs-strict [core] - 10https://gerrit.wikimedia.org/r/127676 (owner: 10Siebrand) [16:22:44] <^d> siebrand: Merged. Sorry for being redundant with the _, I was doing it as I went file-by-file and didn't realize how many it was :p [16:23:03] <^d> Also, the change for CodeSniffer's making its way out now. That'll shut up that pointless warn. [16:23:27] * yuvipanda should fix the remaining 50 errors for the android app so it can have a voting checkstyle too [16:23:43] (03Merged) 10jenkins-bot: Fixed slow query in LocalFileDeleteBatch::getHashes() [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/128943 (owner: 10Aaron Schulz) [16:23:56] (03CR) 10Chad: [C: 032] Remove unused message 'livepreview-loading' [core] - 10https://gerrit.wikimedia.org/r/127883 (owner: 10Siebrand) [16:24:18] (03CR) 10Chad: [C: 032] Make languages/utils pass phpcs-strict [core] - 10https://gerrit.wikimedia.org/r/127677 (owner: 10Siebrand) [16:25:04] (03PS2) 10Yuvipanda: Use :not() CSS pseudo-class instead of jQuery .not() filter in selector [extensions/Popups] - 10https://gerrit.wikimedia.org/r/128432 (owner: 10Bartosz Dziewoński) [16:25:34] (03Merged) 10jenkins-bot: Make languages/classes pass phpcs-strict [core] - 10https://gerrit.wikimedia.org/r/127676 (owner: 10Siebrand) [16:26:12] (03PS2) 10Yuvipanda: Always wait at least 150ms before displaying the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127905 (owner: 10Bartosz Dziewoński) [16:27:28] (03Merged) 10jenkins-bot: Remove unused message 'livepreview-loading' [core] - 10https://gerrit.wikimedia.org/r/127883 (owner: 10Siebrand) [16:27:46] (03Merged) 10jenkins-bot: Make languages/utils pass phpcs-strict [core] - 10https://gerrit.wikimedia.org/r/127677 (owner: 10Siebrand) [16:29:51] (03CR) 10Hashar: [C: 031] "Feel free to merge anytime. Then use git-deploy on tin.eqiad.wmnet in /srv/deployment/integration/slave-scripts/ to push it to the product" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/128942 (owner: 10Chad) [16:32:16] (03CR) 10Chad: "I guess I should learn how to use git-deploy!" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/128942 (owner: 10Chad) [16:33:05] (03CR) 10Chad: [C: 032] Updating mwcodesniffer to master [integration/jenkins] - 10https://gerrit.wikimedia.org/r/128942 (owner: 10Chad) [16:33:08] (03Merged) 10jenkins-bot: Updating mwcodesniffer to master [integration/jenkins] - 10https://gerrit.wikimedia.org/r/128942 (owner: 10Chad) [16:34:39] MatmaRex: I merged a bunch of your popup fixes [16:35:04] yuvipanda: yay [16:35:37] MatmaRex: I'll do another batch tomorrow if zz_prtksxna doesn't get to them byu then [16:38:55] (03PS35) 10Werdna: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 [16:39:01] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [16:39:13] (03PS1) 10Aaron Schulz: Made LocalFile::loadExtraFromDB() handle re-upload race conditions [core] - 10https://gerrit.wikimedia.org/r/128944 [16:39:59] (03PS36) 10Werdna: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 [16:40:17] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [16:42:19] (03PS37) 10Werdna: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 [16:42:28] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [16:43:00] (03PS2) 10Bartosz Dziewoński: Do not call decodeURI() on non-URIs [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127907 [16:43:07] (03PS2) 10Bartosz Dziewoński: Extract some magic timeout values [extensions/Popups] - 10https://gerrit.wikimedia.org/r/128318 [16:45:33] (03CR) 10Yuvipanda: [C: 032] Always wait at least 150ms before displaying the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127905 (owner: 10Bartosz Dziewoński) [16:45:39] (03Merged) 10jenkins-bot: Always wait at least 150ms before displaying the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127905 (owner: 10Bartosz Dziewoński) [16:45:43] (03CR) 10Chad: [C: 032] Made TempFSFile try to purge files on fatals too [core] - 10https://gerrit.wikimedia.org/r/127669 (owner: 10Aaron Schulz) [16:45:45] (03CR) 10Yuvipanda: [C: 032] Do not call decodeURI() on non-URIs [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127907 (owner: 10Bartosz Dziewoński) [16:45:54] (03CR) 10Yuvipanda: [C: 032] Extract some magic timeout values [extensions/Popups] - 10https://gerrit.wikimedia.org/r/128318 (owner: 10Bartosz Dziewoński) [16:46:29] (03Merged) 10jenkins-bot: Do not call decodeURI() on non-URIs [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127907 (owner: 10Bartosz Dziewoński) [16:46:32] (03Merged) 10jenkins-bot: Extract some magic timeout values [extensions/Popups] - 10https://gerrit.wikimedia.org/r/128318 (owner: 10Bartosz Dziewoński) [16:47:34] MatmaRex: ok, merged another batch. [16:48:02] (03PS1) 10Raimond Spekking: Consistency tweaks [core] - 10https://gerrit.wikimedia.org/r/128945 [16:48:29] hah [16:48:59] (03Merged) 10jenkins-bot: Made TempFSFile try to purge files on fatals too [core] - 10https://gerrit.wikimedia.org/r/127669 (owner: 10Aaron Schulz) [16:49:01] (03PS2) 10Raimond Spekking: Consistency tweaks [core] - 10https://gerrit.wikimedia.org/r/128945 [16:54:01] (03PS38) 10Werdna: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 [16:54:08] (03PS2) 10Bartosz Dziewoński: Use mw.hook to rebind events after page content is reloaded [extensions/Popups] - 10https://gerrit.wikimedia.org/r/128455 [16:54:22] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [16:56:33] (03CR) 10Werdna: "After a rebase (which was borked in a few ways), tests are now back to the point at which they are breaking for no reason instead of becau" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [16:57:50] (03PS1) 10Jjanes: PostgreSQL: Allow rc_cur_time field to be null. [core] - 10https://gerrit.wikimedia.org/r/128946 [17:00:11] (03PS1) 10Legoktm: API: Don't rollback changes if the exception was a UsageException [core] - 10https://gerrit.wikimedia.org/r/128947 [17:00:20] anomie: ^ [17:00:50] (03CR) 10Legoktm: "Follow up: I136ba66d2f939fcdd0c9326e04d686a30449bf4c" [core] - 10https://gerrit.wikimedia.org/r/121402 (owner: 10Anomie) [17:02:56] (03CR) 10Legoktm: "I submitted I136ba66d2f939fcdd0c9326e04d686a30449bf4c in core to address that. Thanks!" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader) [17:08:36] Reedy: hmm, https://bits.wikimedia.org/static-current/extensions/MobileApp/config/android.json is still 404 [17:10:57] (03CR) 10Anomie: [C: 032] API: Don't rollback changes if the exception was a UsageException [core] - 10https://gerrit.wikimedia.org/r/128947 (owner: 10Legoktm) [17:12:17] aharoni, HTML paste fail:P [17:13:04] yuvipanda: It's not deploy time [17:13:08] oh [17:13:09] right [17:13:10] nevermind [17:13:36] (03CR) 10Jjanes: "OK, I've cherry picked this to master. Hope it worked correctly." [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127586 (owner: 10Jjanes) [17:13:59] (03Merged) 10jenkins-bot: API: Don't rollback changes if the exception was a UsageException [core] - 10https://gerrit.wikimedia.org/r/128947 (owner: 10Legoktm) [17:21:20] (03CR) 10EBernhardson: [C: 032] Implement multiPut method. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120734 (owner: 10Werdna) [17:21:37] (03Merged) 10jenkins-bot: Implement multiPut method. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120734 (owner: 10Werdna) [17:22:15] (03PS2) 10Ori.livneh: Use EventLogging::logEvent instead of deprecated version [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/127860 (owner: 10Mattflaschen) [17:22:20] (03CR) 10Ori.livneh: "Thanks!" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/127860 (owner: 10Mattflaschen) [17:22:23] (03CR) 10Ori.livneh: [C: 032] Use EventLogging::logEvent instead of deprecated version [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/127860 (owner: 10Mattflaschen) [17:22:25] (03Merged) 10jenkins-bot: Use EventLogging::logEvent instead of deprecated version [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/127860 (owner: 10Mattflaschen) [17:24:17] (03CR) 10Ori.livneh: "They're probably using the mobile site, though. And they can live without box shadows, no?" [core] - 10https://gerrit.wikimedia.org/r/127597 (owner: 10Ori.livneh) [17:25:54] (03PS1) 10Legoktm: API: Don't rollback changes if the exception was a UsageException [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/128949 [17:26:38] (03CR) 10Ori.livneh: "Ping?" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/125132 (owner: 10Ori.livneh) [17:26:44] aharoni: ^ [17:27:27] (03CR) 10Werdna: "The error is fixed by this change to the core testing infrastructure: https://gerrit.wikimedia.org/r/#/c/117815/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [17:27:55] (03CR) 10Daniel Kinzler: [C: 04-1] "The approach looks good to me in general, but there's one conceptual issue I have with this: the caller shouldn't think of the "type" of c" [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [17:28:27] (03CR) 10Legoktm: [C: 032] API: Don't rollback changes if the exception was a UsageException [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/128949 (owner: 10Legoktm) [17:29:06] (03CR) 10Amire80: [C: 032] Spelling: 'Bishnupria Manipuri' => 'Bishnupriya Manipuri' [extensions/cldr] - 10https://gerrit.wikimedia.org/r/125132 (owner: 10Ori.livneh) [17:29:16] (03Merged) 10jenkins-bot: Spelling: 'Bishnupria Manipuri' => 'Bishnupriya Manipuri' [extensions/cldr] - 10https://gerrit.wikimedia.org/r/125132 (owner: 10Ori.livneh) [17:29:23] ori +2 [17:29:32] thanks aharoni [17:30:05] no MaxSem , although it may be a geek joke fail [17:30:08] (03PS4) 10Aaron Schulz: Added Range support to FileBackend::streamFile() [core] - 10https://gerrit.wikimedia.org/r/127466 [17:30:30] (03PS14) 10Legoktm: Make abstract Config class truly implementation-agnostic [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [17:31:06] (03CR) 10jenkins-bot: [V: 04-1] Added Range support to FileBackend::streamFile() [core] - 10https://gerrit.wikimedia.org/r/127466 (owner: 10Aaron Schulz) [17:32:03] (03Merged) 10jenkins-bot: API: Don't rollback changes if the exception was a UsageException [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/128949 (owner: 10Legoktm) [17:32:42] (03CR) 10Jdlrobson: [C: 04-1] "Looks fine but see my comment. I second the Dj's comments." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127818 (owner: 10Mattflaschen) [17:33:38] MatmaRex: Ping re. https://bugzilla.wikimedia.org/show_bug.cgi?id=63630 – are you interested? [17:34:30] (03PS1) 10Ori.livneh: Set line-height for code icon on schema pages [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/128951 [17:34:51] James_F: oh, i didn't reply to that? i meant to, sorry [17:35:07] James_F: generally yes (i still use it ;) ), right now no (don't have time) [17:35:12] superm401: https://gerrit.wikimedia.org/r/128951 is trivial, wld appreciate [17:37:07] (03CR) 10Mwalker: [C: 032] "Works for me, all of krinkle's comments were addressed, and I didn't spot anything. Nifty stuff!" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122601 (owner: 10TheDJ) [17:37:11] (03Merged) 10jenkins-bot: Add a status bar to the CodeEditor [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/122601 (owner: 10TheDJ) [17:37:13] ori, will look at it in a bit. [17:37:38] superm401: danke [17:41:10] (03PS5) 10Aaron Schulz: Added Range support to FileBackend::streamFile() [core] - 10https://gerrit.wikimedia.org/r/127466 [17:42:00] (03CR) 10Krinkle: Templating::getContent() should return safe-to-display content (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127666 (owner: 10Bsitu) [17:44:17] James_F: superm401: I'm not sure that makes sense. Please don't add empty jshintignore files. [17:44:50] Why would one want to run jshint on extensions when running it from the mediawiki-core directory? [17:45:10] In fact, I'm pretty sure there's more usecases for the opposite, where one explicitly doesn't want that. [17:46:02] What is the actual problem you're trying to solve here? [17:46:51] (03CR) 10jenkins-bot: [V: 04-1] Added Range support to FileBackend::streamFile() [core] - 10https://gerrit.wikimedia.org/r/127466 (owner: 10Aaron Schulz) [17:50:31] MatmaRex: OK if I leave it "assigned" to you, but lower the priority? [17:50:44] (03CR) 10Jdlrobson: [C: 032] "We noticed this a long time ago on mobile." [core] - 10https://gerrit.wikimedia.org/r/127597 (owner: 10Ori.livneh) [17:51:09] James_F: sure, if you're not concerned about cookie-licking :) [17:51:39] (03CR) 10Jdlrobson: [C: 032] Explain make kss environment variable in README [core] - 10https://gerrit.wikimedia.org/r/125368 (owner: 10Mattflaschen) [17:52:18] MatmaRex: I have faith in your ability to get stuff done. :-) [17:52:23] (03PS2) 10Hoo man: Fix "UTPage" creation in tests [core] - 10https://gerrit.wikimedia.org/r/117815 (owner: 10Werdna) [17:52:31] (03CR) 10Hoo man: [C: 032] Fix "UTPage" creation in tests [core] - 10https://gerrit.wikimedia.org/r/117815 (owner: 10Werdna) [17:53:50] (03Merged) 10jenkins-bot: Drop -{webkit,moz}-box-shadow [core] - 10https://gerrit.wikimedia.org/r/127597 (owner: 10Ori.livneh) [17:54:53] (03Merged) 10jenkins-bot: Explain make kss environment variable in README [core] - 10https://gerrit.wikimedia.org/r/125368 (owner: 10Mattflaschen) [17:56:34] (03Merged) 10jenkins-bot: Fix "UTPage" creation in tests [core] - 10https://gerrit.wikimedia.org/r/117815 (owner: 10Werdna) [17:59:13] hoo|away: i was also poking at that patch, but not sure yet what changed to require that change (considering that line has worked since it was added in 2012 [17:59:33] ebernhardson: That looks like something that has never worked [17:59:48] hoo: ahh, that might be true :) [17:59:53] (03CR) 10Daniel Kinzler: [C: 04-1] "see comments" (037 comments) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [18:03:14] (03PS2) 10Thiemo Mättig (WMDE): Allow Status::hasMessage to work with Message objects. [core] - 10https://gerrit.wikimedia.org/r/126836 (owner: 10Daniel Kinzler) [18:04:14] (03CR) 10jenkins-bot: [V: 04-1] Allow Status::hasMessage to work with Message objects. [core] - 10https://gerrit.wikimedia.org/r/126836 (owner: 10Daniel Kinzler) [18:04:24] (03PS1) 10Manybubbles: Cirrus improvements [vagrant] - 10https://gerrit.wikimedia.org/r/128955 [18:05:50] (03PS39) 10EBernhardson: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [18:06:10] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [18:10:34] (03CR) 10Bartosz Dziewoński: "Yup, it did work all right at a glance. Gerrit is not very pleasant to use, and in fact we're trying to move off it – feel free to comment" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127586 (owner: 10Jjanes) [18:12:03] is there any way to get at the sqlite database that was used in tests? [18:12:27] ebernhardson: i don't think so, it should be just in memory. [18:13:04] DanielK_WMDE: hmm, makes sense. thanks. [18:15:22] (03PS6) 10Aaron Schulz: Added Range support to FileBackend::streamFile() [core] - 10https://gerrit.wikimedia.org/r/127466 [18:16:24] (03PS3) 10Thiemo Mättig (WMDE): Allow Status::hasMessage to work with Message objects. [core] - 10https://gerrit.wikimedia.org/r/126836 (owner: 10Daniel Kinzler) [18:17:19] (03CR) 10jenkins-bot: [V: 04-1] Allow Status::hasMessage to work with Message objects. [core] - 10https://gerrit.wikimedia.org/r/126836 (owner: 10Daniel Kinzler) [18:19:13] (03PS4) 10Thiemo Mättig (WMDE): Allow Status::hasMessage to work with Message objects. [core] - 10https://gerrit.wikimedia.org/r/126836 (owner: 10Daniel Kinzler) [18:20:44] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Patch set 4 is a rebase." [core] - 10https://gerrit.wikimedia.org/r/126836 (owner: 10Daniel Kinzler) [18:23:02] (03CR) 10Daniel Kinzler: [C: 031] "Thanks Thiemo!" [core] - 10https://gerrit.wikimedia.org/r/126836 (owner: 10Daniel Kinzler) [18:44:43] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I think the keysToTry property could have a more descriptive name. It's more like a fall back chain, could be called fallbackKeyChain, tha" [core] - 10https://gerrit.wikimedia.org/r/126936 (owner: 10Daniel Kinzler) [18:45:04] (03PS1) 10Aaron Schulz: Added --multiversiononly option to image SHA1 population script [core] - 10https://gerrit.wikimedia.org/r/128964 [18:48:42] (03PS1) 10Gerrit Patch Uploader: Enclose parser output into a div container [core] - 10https://gerrit.wikimedia.org/r/128966 [18:48:46] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/128966 (owner: 10Gerrit Patch Uploader) [18:49:23] (03CR) 10Fomafix: "I made an other solution with Change-Id: I2c5918164feec8e136b547a9d72315290402f787" [core] - 10https://gerrit.wikimedia.org/r/127624 (owner: 10Gerrit Patch Uploader) [18:50:46] (03CR) 10Bartosz Dziewoński: "Can't #mw-content-text be used for this?" [core] - 10https://gerrit.wikimedia.org/r/128966 (owner: 10Gerrit Patch Uploader) [18:52:24] (03CR) 10Mattflaschen: [C: 032] "Tested, looks good." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/128951 (owner: 10Ori.livneh) [18:53:39] (03Merged) 10jenkins-bot: Set line-height for code icon on schema pages [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/128951 (owner: 10Ori.livneh) [18:56:14] (03CR) 10Aaron Schulz: [C: 032] PostgreSQL: Allow rc_cur_time field to be null. [core] - 10https://gerrit.wikimedia.org/r/128946 (owner: 10Jjanes) [18:58:50] (03PS3) 10Bsitu: Update to localCache should sync with bufferCache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127864 [18:59:37] (03Merged) 10jenkins-bot: PostgreSQL: Allow rc_cur_time field to be null. [core] - 10https://gerrit.wikimedia.org/r/128946 (owner: 10Jjanes) [19:01:23] (03PS2) 10Gergő Tisza: Make users API cache mode public if blockinfo is not queried [core] - 10https://gerrit.wikimedia.org/r/127859 [19:09:36] (03CR) 10Krinkle: "Indeed, mw-content-text is for this purpose already. And don't we already have visualClear and other clears in skins for this at that poin" [core] - 10https://gerrit.wikimedia.org/r/128966 (owner: 10Gerrit Patch Uploader) [19:10:34] (03PS10) 10Aaron Schulz: [WIP] Added VirtualRESTServiceClient/VirtualRESTService classes [core] - 10https://gerrit.wikimedia.org/r/110129 [19:11:06] siebrand: Could you just remove the shims from all WMDE extensions in github? [19:11:18] We just talked and decided that we don't need them [19:11:45] (03PS1) 10Manybubbles: Easier brousertests against vagrant [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/128969 [19:12:29] hoo: Please go ahead. I did it as a service to you guys. So you can close the pull requests without merging and delete the stuff in your repos. [19:13:23] (03CR) 10Krinkle: Make users API cache mode public if blockinfo is not queried (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127859 (owner: 10Gergő Tisza) [19:13:33] That's ok with me :) [19:15:04] (03CR) 10Krinkle: Make users API cache mode public if blockinfo is not queried (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127859 (owner: 10Gergő Tisza) [19:15:13] (03CR) 10Legoktm: Make abstract Config class truly implementation-agnostic (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [19:17:27] (03CR) 10Krinkle: Easier brousertests against vagrant (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/128969 (owner: 10Manybubbles) [19:17:45] (03CR) 10Siebrand: [C: 032] Consistency tweaks [core] - 10https://gerrit.wikimedia.org/r/128945 (owner: 10Raimond Spekking) [19:18:04] (03PS2) 10Mattflaschen: Change X-UA-Compatible from tag to HTTP header [core] - 10https://gerrit.wikimedia.org/r/127818 [19:19:35] hexmode: Can you please merge https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/core+branch:REL1_23+owner:%22Siebrand+%253Csiebrand%2540kitano.nl%253E%22,n,z ? [19:20:05] hexmode: It looks like people are waiting for you and Markus to merge REL1_xx patch sets. [19:20:24] (03PS2) 10Manybubbles: Easier browsertests against vagrant [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/128969 [19:20:38] (03CR) 10Manybubbles: "bouser tests do sound much more fun" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/128969 (owner: 10Manybubbles) [19:20:46] (03CR) 10Krinkle: Tidy ext.eventLogging.{subscriber.js,core.js,jsonSchema.css} (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/127667 (owner: 10Ori.livneh) [19:21:45] (03Merged) 10jenkins-bot: Consistency tweaks [core] - 10https://gerrit.wikimedia.org/r/128945 (owner: 10Raimond Spekking) [19:23:11] (03PS11) 10Aaron Schulz: [WIP] Added VirtualRESTServiceClient/VirtualRESTService classes [core] - 10https://gerrit.wikimedia.org/r/110129 [19:23:24] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/118113 (owner: 10Anomie) [19:23:34] (03CR) 10Mattflaschen: "Done, except for the refactoring; see inline." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/127818 (owner: 10Mattflaschen) [19:26:20] (03CR) 10Mattflaschen: "I've also added a few reviewers who might be able to comment on the Varnish issue. I'll also quickly raise it on IRC." [core] - 10https://gerrit.wikimedia.org/r/127818 (owner: 10Mattflaschen) [19:27:10] (03CR) 10Krinkle: [C: 032] Make Nuke pass jshint [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/124143 (owner: 10Grunny) [19:27:19] (03Merged) 10jenkins-bot: Make Nuke pass jshint [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/124143 (owner: 10Grunny) [19:29:22] (03PS1) 10Krinkle: Remove non-voting flag for mwext-Nuke-jslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/129015 [19:30:15] (03CR) 10Krinkle: [C: 032] Remove non-voting flag for mwext-Nuke-jslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/129015 (owner: 10Krinkle) [19:30:23] (03Merged) 10jenkins-bot: Remove non-voting flag for mwext-Nuke-jslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/129015 (owner: 10Krinkle) [19:30:40] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Petition] - 10https://gerrit.wikimedia.org/r/126011 (owner: 10Pcoombe) [19:31:38] (03CR) 10Siebrand: [C: 032] Remove use of message 'postcomment' [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/128939 (owner: 10PleaseStand) [19:31:42] (03Merged) 10jenkins-bot: Remove use of message 'postcomment' [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/128939 (owner: 10PleaseStand) [19:32:34] (03PS2) 10Jjanes: PostgreSQL: Allow rc_cur_time field to be null. [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127586 [19:33:13] (03CR) 10Bartosz Dziewoński: [C: 032] "Merged into master by Aaron." [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127586 (owner: 10Jjanes) [19:34:15] (03CR) 10Gergő Tisza: Make users API cache mode public if blockinfo is not queried (032 comments) [core] - 10https://gerrit.wikimedia.org/r/127859 (owner: 10Gergő Tisza) [19:36:17] (03Merged) 10jenkins-bot: PostgreSQL: Allow rc_cur_time field to be null. [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127586 (owner: 10Jjanes) [19:38:42] so who's to local lessphp expert? The problem is ResourceLoaderLESSFunctions::embeddable/embed receive a full LESS frame and dont know what to do with it, so they just grab a random variable out of the frame and hope its the right one. This works in the simple case but fails when passing an expression into the method [19:38:56] it seems can resolve this by calling $less->compileValue() on the argument, but thats a protected method [19:39:04] so before i go hacking up the vendor code wanted to double check if theres a better way [19:39:31] (03CR) 10Bartosz Dziewoński: "Thank you for the patch!" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127586 (owner: 10Jjanes) [19:39:54] ebernhardson: ori [19:41:22] ori: ping [19:42:41] probably lunch, i should eat too [19:42:47] come back at it soon enough :) [19:43:31] (03CR) 10Siebrand: [C: 032] Add 'since ' to @deprecated annotations [core] - 10https://gerrit.wikimedia.org/r/126123 (owner: 10Bartosz Dziewoński) [19:46:40] (03Merged) 10jenkins-bot: Add 'since ' to @deprecated annotations [core] - 10https://gerrit.wikimedia.org/r/126123 (owner: 10Bartosz Dziewoński) [19:49:54] (03CR) 10Hashar: "and maybe have each line of the console timestamped by adding:" (032 comments) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126870 (owner: 10BryanDavis) [19:50:57] (03CR) 10Krinkle: [C: 04-1] "Use "$this->setMwGlobals()" instead of restoring them manually." [core] - 10https://gerrit.wikimedia.org/r/57018 (owner: 10Adamw) [19:55:30] (03CR) 10Krinkle: isFeatureEnabled: Check current Skin compatability (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/122086 (owner: 10Legoktm) [19:55:53] (03PS15) 10Legoktm: Make abstract Config class truly implementation-agnostic [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [19:56:13] (03CR) 10Legoktm: Make abstract Config class truly implementation-agnostic (037 comments) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [19:56:48] (03PS3) 10Chad: Clean up database-backed SearchResultSets [core] - 10https://gerrit.wikimedia.org/r/127878 [19:58:48] (03PS1) 10Siebrand: Pass phpcs-strict on maintenance/benchmarks/ [core] - 10https://gerrit.wikimedia.org/r/129022 [20:01:17] Krinkle, I think you may have misunderstood my edit re jshintignore. [20:01:20] Do you have a second to talk? [20:01:26] superm401: sure [20:01:44] Okay, so the issue is when you want to run jshint specifically on an extension locally. [20:01:59] superm401: I reverted it because it didn't make sense out of context when just reading the conventions. It seemed a bit overly specific that nobody would understand and leads to nasty things like people just copying it without knowing why. [20:02:07] A lot (most?) people keep extensions they work on as a subdirectory of core. [20:02:18] OK [20:02:21] So they have a core git checkout than an extension git checkout they work on underneath. [20:02:46] So if you have core/extensions/MyExtension, and you want to run jshint on MyExtension, you can run: [20:02:48] jshint . [20:02:50] (03PS1) 10EBernhardson: Resolve complex arguments to LESS helper functions [core] - 10https://gerrit.wikimedia.org/r/129023 [20:02:52] inside MyExtension directory. [20:03:08] However, if there is no .jshintignore it will *always* say jshint passes, since the entire MyExtension will be excluded. [20:03:17] This is because it uses core's jshintignore. [20:04:53] I was explicitly saying people should do this for every repo; a comment in the .jshintignore file does help explain this. [20:05:27] Krinkle, note, this does not cause failures in extensions to affect core, if you run jshint . in the core root. [20:05:44] We should also do this for the new extension script, I think. [20:06:51] superm401: so to clarify, adding that empty file will not change the fact that extensions are always ignored when running jshint . in core/ right? [20:06:56] (03CR) 10Bartosz Dziewoński: "Followup: https://gerrit.wikimedia.org/r/#/c/129023/" [core] - 10https://gerrit.wikimedia.org/r/127139 (owner: 10Bartosz Dziewoński) [20:07:01] Krinkle, correct, tested locally. [20:07:07] superm401: I don't think it should use a jshintignore file from a higher directory and apply it from there. [20:07:09] That seems wrong [20:07:24] Hm.. [20:07:28] Krinkle, well, it doesn't have any understanding of repos. [20:07:38] However, it could perhaps only use a jshintignore at the same level as jshintrc [20:07:47] No [20:08:01] jshintrc can be subclassed in subdirectories, by design [20:08:12] I'm not sure if there is a script that adds .jshintrc, actually. If not, nowhere to put code adding the blank file. [20:08:28] e.g. repo/tests/.jshintrc, extends the root one ({ extends: ../.jshintrc, predef: ['QUnit'] }) [20:08:45] superm401: There is no such code or script. [20:09:06] Yeah, so I don't know what a fix would be in jshint proper, which takes us back to the conventions. [20:09:31] superm401: it using a parent jshintignore makes sense, eg. when ignoring *.min.js files for example (we don't use it liek that, but just a generic example), then when you run it from root or from a /resources/foo/ directory, it will still apply that as expected. [20:09:47] However if you say "jshint foo.min.js" it will not apply the ignore, because it was passed explicitly. [20:09:56] 4Wikimedia 3Deployment systems: Deployment: Repository .git is synchronised fine, but is broken for submodules because of hardcoded gitdir link - 10https://bugzilla.wikimedia.org/53972#c7 (10Bryan Davis) (In reply to James Forrester from comment #6) > Could we just have scap re-write the .git files (or have... [20:10:10] But if you run "jshint ." from /resources or "jshint resources/" from /, then it will apply the ignore. [20:10:16] (03CR) 10Bartosz Dziewoński: "This will also need backporting to 1.23, as the patch which caused the regression was backported: https://gerrit.wikimedia.org/r/#/c/12758" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/129023 (owner: 10EBernhardson) [20:10:22] However I think it's an upstream bug that the ignore applies if the given directory is ignored. [20:10:26] 4Analytics 3Wikimetrics: wrong user_name is being shown in CSV output - 10https://bugzilla.wikimedia.org/64026#c4 (10Gerrit Notification Bot) Change 129025 had a related patch set uploaded by Milimetric: Fix user name display in CSV files https://gerrit.wikimedia.org/r/129025 [20:10:31] Krinkle, actually, it doesn't work even if you put the exact filename. [20:10:35] (03CR) 10Chad: [C: 032] Added --multiversiononly option to image SHA1 population script [core] - 10https://gerrit.wikimedia.org/r/128964 (owner: 10Aaron Schulz) [20:10:45] e.g. if I jshintignore node_modules, and then I cd ./node_modules/grunt/ then running jshint . inside there should not ignore everything. [20:10:52] jshint 2.5.0 [20:11:00] use 2.4.x [20:11:06] (at most) [20:11:55] (03CR) 10Aaron Schulz: [C: 032] Clean up database-backed SearchResultSets [core] - 10https://gerrit.wikimedia.org/r/127878 (owner: 10Chad) [20:12:28] superm401: An unrelated note, I'd recommend not nesting repositories in the first place. Especially when it comes to submodules messing things up. [20:12:43] How do you deal with doing wmf branch changes? [20:13:16] Krinkle, I have a separate mediawiki checkout. [20:13:20] One for submodule bumps [20:13:23] One for day-to-day work [20:13:31] (The latter is a standard MW-Vagrant setup) [20:13:43] MW-Vagrant relies on nested repos [20:13:45] (03CR) 10Chad: [C: 031] Cirrus improvements [vagrant] - 10https://gerrit.wikimedia.org/r/128955 (owner: 10Manybubbles) [20:13:53] (03Merged) 10jenkins-bot: Added --multiversiononly option to image SHA1 population script [core] - 10https://gerrit.wikimedia.org/r/128964 (owner: 10Aaron Schulz) [20:14:49] Krinkle, still doesn't work even if you name the file: [20:14:55] In 2.4.0 [20:14:57] (03Merged) 10jenkins-bot: Clean up database-backed SearchResultSets [core] - 10https://gerrit.wikimedia.org/r/127878 (owner: 10Chad) [20:14:57] 4VisualEditor 3MediaWiki integration: VisualEditor: Allow users to set/edit {{DISPLAYTITLE:xxx}} in the page metadata panel - 10https://bugzilla.wikimedia.org/56868#c3 (10Alex Monk) Okays, turns out I hadn't read this properly and it's blocked on Parsoid recognising this as a meta item rather than a transclu... [20:15:04] rm -rf .jshintignore && jshint resources/broken.js [20:15:07] I have ~/Dev/mediawiki-core and ~/Dev/mediawik-extensions. Then on apache they're mounted on /w/ and /extensions respectively. wgExtensionAssetsPath is set accordingly. And require_once'es go $IP../ first (in actuality, I use $EP = $IP/.., but oh well) [20:15:11] Hides the error [20:15:22] touch .jshintignore && jshint resources/broken.js [20:15:24] superm401: OK, I'd argue that's a genuine bug [20:15:25] Shows it [20:16:02] (03PS2) 10EBernhardson: Resolve complex arguments to LESS helper functions [core] - 10https://gerrit.wikimedia.org/r/129023 [20:16:09] I'll file a report and see what happens [20:16:11] 4Wikimedia 3wikibugs IRC bot: Wikibugs does not always report the real name instead of e-mail prefix when reporting on IRC - 10https://bugzilla.wikimedia.org/18831#c20 (10Merlijn van Deen) 5REO>3RES/FIX Fixed in pywikibugs. [20:16:28] 4MediaWiki extensions 3Translate: MediaWikiExtensionMessageGroup should not extend SingleFileBasedMessageGroup - 10https://bugzilla.wikimedia.org/63262#c2 (10Niklas Laxström) 5NEW>3RES/FIX a:3Niklas Laxström The class was removed. [20:16:50] Krinkle, can we at least agree to have a warning about it, even if you don't want to advise a blank file? [20:17:11] 4Wikimedia 3wikibugs IRC bot: Set wikibugs to be able to join multiple channels - 10https://bugzilla.wikimedia.org/10760#c6 (10Merlijn van Deen) 5REO>3RES/FIX Fixed in pywikibugs. Please file a pull request (in the near future: gerrit patch) https://github.com/valhallasw/pywikibugs for any further channe... [20:17:16] anomie: am i completely misinterpreting what mw.loadData is supposed to do, or does it not work at all? it seems like it doesn't prevent a module from needing to be re-ran when called from different #invokes [20:17:41] 4Wikimedia 3General/Unknown: Move wikibugs out of #mediawiki to #wikimedia-dev - 10https://bugzilla.wikimedia.org/46144 (10Merlijn van Deen) 5PAT>3RES/FIX [20:18:11] 4Wikimedia 3wikibugs IRC bot: wikibugs reports UNCONFIRMED bugs as NEW - 10https://bugzilla.wikimedia.org/61734 (10Merlijn van Deen) 5NEW>3RES/FIX [20:18:56] 4Wikimedia 3General/Unknown: Move wikibugs and gerrit-wm out of #mediawiki (tracking) - 10https://bugzilla.wikimedia.org/46322#c13 (10Merlijn van Deen) 5NEW>3RES/FIX Wikibugs is dead, pywikibugs reports to #wikimedia-dev. [20:19:26] 4Wikimedia 3wikibugs IRC bot: Puppetize wikibugs properly - 10https://bugzilla.wikimedia.org/59076#c2 (10Merlijn van Deen) 5NEW>3RES/INV Now that pywikibugs is a tool on Tool Labs, I think this is not relevant anymore. [20:19:59] jackmcbarn: Works fine for me locally. [20:20:18] anomie: i see it's faster, but i don't see loadedData getting saved between #invokes [20:20:35] i added a getLoadedData function to mw.lua for debugging, and it was empty in a #invoke after one i just ran mw.loadData in [20:22:56] 3Wikimedia / 3wikibugs IRC bot: [Regression] wikibugs no longer reports user name for NEW bugs - 10https://bugzilla.wikimedia.org/42774 (10Merlijn van Deen) 5NEW>3RES/FIX [20:23:23] (03PS1) 10Siebrand: Pass phpcs-strict on maintenance/oracle/ [core] - 10https://gerrit.wikimedia.org/r/129028 [20:23:25] (03PS1) 10Siebrand: Pass phpcs-strict on maintenance/storage/ [core] - 10https://gerrit.wikimedia.org/r/129029 [20:23:26] 3Wikimedia / 3wikibugs IRC bot: Don't fragment bugzilla conversation/IRC output - 10https://bugzilla.wikimedia.org/55807#c8 (10James Forrester) 5NEW>3RES/FIX Now done by pywikibugs. [20:23:31] MatmaRex: Thx :) [20:23:53] MatmaRex: https://github.com/valhallasw/pywikibugs/commit/3b92c88c1497e5b625e67854401940957d31266c [20:23:56] 3Wikimedia / 3wikibugs IRC bot: Wikibugs should report status changes, not just the current status - 10https://bugzilla.wikimedia.org/18054#c9 (10James Forrester) 5NEW>3RES/FIX Now done by pywikibugs. [20:24:00] Funny with your bright red gravatar [20:24:12] Krinkle: haha [20:24:32] gravatars annoy me, thus this [20:25:26] 3Wikimedia / 3IRC: register nickserv account for wikibugs - 10https://bugzilla.wikimedia.org/46253#c1 (10Merlijn van Deen) 5NEW>3RES/FIX Registered by the pywikibot account. Check wikibugs project on tools for password. [20:25:28] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Should prefer showing fragments in text that contain many of the search terms rather then many copies of the same search term - 10https://bugzilla.wikimedia.org/64259 (10Nik Everett) 3NEW p:3Unprio s:3normal a:3None Should prefer showing fragments... [20:25:41] 3MediaWiki extensions / 3CirrusSearch: CirrusSearch: Should prefer showing fragments in text that contain many of the search terms rather then many copies of the same search term - 10https://bugzilla.wikimedia.org/64259 (10Nik Everett) p:5Unprio>3Normal [20:26:24] Krinkle, did you see what I said above, about putting a warning (if we're not going to just tell people to have a blank file with comment)? [20:26:40] superm401: a warning where? [20:26:52] Krinkle, on the conventions page [20:27:01] Where it talks about jshint [20:27:21] jackmcbarn: Works when I try the same thing. [20:28:01] superm401: I'm not sure. I mean.. it's never come up. I'm trying to figure out why nobody else seems to have run into this. [20:28:23] Krinkle, well, it has come up for me, and I think phuedx reproduced it. [20:28:34] It will probably happen more as we move to all Gerrit repos having voting lint. [20:28:36] Jenkins isn't affected. In-editor linters (e.g. when using sublime) aren't affected. If you use grunt to run jshint from command line, it isn't affected. [20:28:49] https://bugzilla.wikimedia.org/show_bug.cgi?id=60619 [20:29:00] Krinkle, I know, but you want to find the error before it gets to Jenkins. [20:29:16] And my editor at least isn't picking up the config right, but it's reasonable to expect the standard jshint command to work right. [20:29:23] anomie: LuaSandbox or LuaStandalone? (and i just tried it again, it definitely doesn't work for me) [20:29:39] Krinkle, since it's non-voting in a lot of repos, many people probably don't even have jshint installed. [20:29:46] superm401: what editor are you using? [20:29:47] Plus, a lot of the ones that are voting have a jshintignore. [20:29:49] superm401: yeah, I see [20:29:52] Emacs, with jshint-mode [20:29:58] 3MediaWiki extensions / 3Flow: Flow: invisible icons - 10https://bugzilla.wikimedia.org/64260 (10spage ) 3NEW p:3Unprio s:3normal a:3None On beta labs and ee-flow, the Expand|Collapse|Small view icons, the action menu [...] ellipsis, and the icons for Permalink, Hide, etc. in the action menu are all... [20:30:01] (03CR) 10Chad: [C: 032] Easier browsertests against vagrant [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/128969 (owner: 10Manybubbles) [20:30:10] superm401: so what would be the work around without creating an empty file? [20:30:13] (03Merged) 10jenkins-bot: Easier browsertests against vagrant [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/128969 (owner: 10Manybubbles) [20:30:23] (03CR) 10EBernhardson: "This patch references a non-existant method ObjectManager::multiRemove" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120734 (owner: 10Werdna) [20:30:38] jackmcbarn: Just tried it in both. [20:30:50] Krinkle, don't know of any other one. [20:31:23] Krinkle, is there a way to have grunt run for extensions? [20:31:24] because a warning saying like "If you run jshint from the command line, and you have extension repos nested in core, you can't run jshint" [20:31:30] superm401: Yes [20:31:39] see visualeditor for an example [20:32:08] we got rid of all those duplicative and separate jenkins jobs. Having the control be in the local repository is much nicer. Makes it also easy to run "everything" jenkins does locally [20:32:11] 3Wikimedia / 3General/Unknown: Cleanup Lucene config for MediaWiki - 10https://bugzilla.wikimedia.org/64006#c4 (10Gerrit Notification Bot) Change 126804 merged by jenkins-bot: Only load/enable Lucene on production (not on labs) https://gerrit.wikimedia.org/r/126804 [20:32:32] running jshint locally the way you describe means you'll likely use the wrong version (compared to jenkins) [20:32:37] Krinkle, having a separate Gruntfile for each repo requires a lot of custom config, though, far more than just two files. [20:32:52] though even without grunt you can approach that by using a package.json with npm-test that runs jshint from the local node_modules bin directory [20:32:53] (03CR) 10Chad: [C: 031] "I like where this has ended up. Any other complaints or shall we merge?" [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [20:33:24] (03CR) 10EBernhardson: [C: 032] Add permission checking to revision diff [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127766 (owner: 10Bsitu) [20:33:32] superm401: no, it doesn't. It requires exactly 2 files. Only 1 more than a propely configured repo without grunt. [20:33:34] <^d> Bah, wikibugs is here! [20:33:41] (03Merged) 10jenkins-bot: Add permission checking to revision diff [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127766 (owner: 10Bsitu) [20:33:45] package.json (which you'd probably want to have even without grunt), and Gruntfile.js [20:34:13] Krinkle, I meant more config, not more files. But you're right, the jshint section alone is not that long. [20:34:15] ^d: As agreed upon months ago, and implemented in puppet, but was never deployed because node running wikibugs in prod is fucked. [20:34:20] Krinkle, what's the benefit of package.json without grunt? [20:34:37] superm401: the benefit of package.json is to specify how people should use your code. [20:34:38] <^d> Krinkle: I didn't know! Easily /ignored! [20:34:43] <^d> Just surprised me :) [20:34:57] Krinkle, the license you mean? [20:35:01] ^d: it just moved from #mediawiki here, in that case move your ignores as well, no problemo :) [20:35:22] superm401: No, that only matters if you publish on npm. Don't specify a license in there if you don't use it like that. [20:35:26] 3Wikimedia / 3wikibugs IRC bot: wikibugs prints (mod) instead (RESO) or (VERI) since Bugzilla 4.2 migration - 10https://bugzilla.wikimedia.org/43047 (10Merlijn van Deen) 5NEW>3RES/FIX [20:35:31] superm401: I mean which packages to install and how to run tests. [20:35:41] 3MediaWiki extensions / 3MultimediaViewer: suboptimal placement of "More details" tipsy tooltip - 10https://bugzilla.wikimedia.org/64258#c1 (10Tisza Gergő) This is a tipsy bug (two tipsy bugs, actually). Would be nice to fix upstream, but the lazy way is to just switch to ne/nw tip placement so the tip is po... [20:35:46] e.g. you can specify there "devDependencies: jshint: 2.5.0", and "scripts: test: jshint ." [20:35:46] Krinkle, then what would I have in there for a standard MediaWiki extension with PHPUnit and QUnit? [20:36:11] "agreed"... no bug report among the related ones was ever notified [20:36:14] Krinkle, okay, so what do we want to do about the problem concretely? [20:36:17] gah, why is my environment acting so weird [20:36:24] If you want to retest, that's fine, but I can reproduce it consistently. [20:36:37] It may be it can be fixed concretely by standardizing on Gruntfile, but do we want to do that? [20:36:45] (03CR) 10Chad: [C: 032] Pass phpcs-strict on maintenance/benchmarks/ [core] - 10https://gerrit.wikimedia.org/r/129022 (owner: 10Siebrand) [20:37:03] (03CR) 10Chad: [C: 032] Pass phpcs-strict on maintenance/oracle/ [core] - 10https://gerrit.wikimedia.org/r/129028 (owner: 10Siebrand) [20:37:21] (03CR) 10Bsitu: [C: 032] API: Add prop=flowinfo to detect if Flow is enabled on a page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111255 (owner: 10Legoktm) [20:37:31] (03CR) 10Chad: [C: 032] Pass phpcs-strict on maintenance/storage/ [core] - 10https://gerrit.wikimedia.org/r/129029 (owner: 10Siebrand) [20:37:52] there's nothing to retest, I understand the bug. [20:38:11] 3MobileFrontend / 3Hygiene: Avoid CSS rule duplication by using more descriptive classes - 10https://bugzilla.wikimedia.org/64217#c3 (10Gerrit Notification Bot) Change 129032 had a related patch set uploaded by Jdlrobson: Create script for checking css rule duplication https://gerrit.wikimedia.org/r/129032 [20:38:11] 3MobileFrontend / 3Hygiene: Avoid CSS rule duplication by using more descriptive classes - 10https://bugzilla.wikimedia.org/64217 (10Gerrit Notification Bot) 5NEW>3PAT [20:38:12] (03Merged) 10jenkins-bot: API: Add prop=flowinfo to detect if Flow is enabled on a page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111255 (owner: 10Legoktm) [20:38:22] superm401: Depends, though if Grunt isn't affected, that's likely a bug as well, it should be affected by the same bugs as jshint [20:38:26] 3MediaWiki extensions / 3Flow: Flow: API to determine if Flow is enabled on a page - 10https://bugzilla.wikimedia.org/60809#c5 (10Gerrit Notification Bot) Change 111255 merged by jenkins-bot: API: Add prop=flowinfo to detect if Flow is enabled on a page https://gerrit.wikimedia.org/r/111255 [20:38:37] I was merely telling you about why package.json is recommended either way. [20:39:06] Not related to whether you want your project to use grunt and have an easy to run test pipeline that doesnt' require manually installing stuff, documenting it, and relying on the global versions installed on jenkins. [20:39:32] * ebernhardson is so jelous of code that gets to use libraries [20:39:41] (03CR) 10Chad: [C: 032] Allow Status::hasMessage to work with Message objects. [core] - 10https://gerrit.wikimedia.org/r/126836 (owner: 10Daniel Kinzler) [20:39:41] 3MediaWiki / 3Documentation: Upload Living Style Guide automatically to doc.wikimedia.org - 10https://bugzilla.wikimedia.org/64221#c1 (10James Forrester) If I don't get around to this and someone else wants to, a template to start from might be https://gerrit.wikimedia.org/r/#/c/125542/ which adds jsduck pub... [20:39:42] * ebernhardson also cant spell :P [20:40:17] Krinkle, however, devDependencies only solves the problem of standardizing jshint. [20:40:37] It doesn't solve the original problem, so what are we going to do about that (if you're against the blank file idea)? [20:40:44] (03Merged) 10jenkins-bot: Pass phpcs-strict on maintenance/benchmarks/ [core] - 10https://gerrit.wikimedia.org/r/129022 (owner: 10Siebrand) [20:40:48] (03PS3) 10Spage: Resolve complex arguments to LESS helper functions [core] - 10https://gerrit.wikimedia.org/r/129023 (owner: 10EBernhardson) [20:40:53] (03CR) 10Chad: [C: 032 V: 032] Refactor to make it easier to extend. [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/127406 (owner: 10MarkAHershberger) [20:41:02] anomie: oh, the cache was biting me. sorry about that [20:41:11] 3MediaWiki extensions / 3Flow: Flow: invisible icons - 10https://bugzilla.wikimedia.org/64260 (10Gerrit Notification Bot) 5NEW>3PAT [20:41:11] 3MediaWiki extensions / 3Flow: Flow: invisible icons - 10https://bugzilla.wikimedia.org/64260#c1 (10Gerrit Notification Bot) Change 129023 had a related patch set uploaded by Spage: Resolve complex arguments to LESS helper functions https://gerrit.wikimedia.org/r/129023 [20:41:58] (03Merged) 10jenkins-bot: Pass phpcs-strict on maintenance/oracle/ [core] - 10https://gerrit.wikimedia.org/r/129028 (owner: 10Siebrand) [20:42:00] (03Merged) 10jenkins-bot: Pass phpcs-strict on maintenance/storage/ [core] - 10https://gerrit.wikimedia.org/r/129029 (owner: 10Siebrand) [20:43:09] (03Merged) 10jenkins-bot: Allow Status::hasMessage to work with Message objects. [core] - 10https://gerrit.wikimedia.org/r/126836 (owner: 10Daniel Kinzler) [20:43:27] superm401: Yep [20:43:52] Krinkle, yep what? I asked what you want to do about the original problem. [20:44:56] 3MediaWiki extensions / 3Flow: Flow: API to determine if Flow is enabled on a page - 10https://bugzilla.wikimedia.org/60809 (10Kunal Mehta (Legoktm)) 5PAT>3RES/FIX [20:44:56] 3MediaWiki extensions / 3MultimediaViewer: suboptimal placement of "More details" tipsy tooltip - 10https://bugzilla.wikimedia.org/64258#c2 (10Tisza Gergő) Tracked in mingle as https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/485 [20:45:27] (03CR) 10Chad: [C: 032] Removed $wgImgAuthPublicTest [core] - 10https://gerrit.wikimedia.org/r/127701 (owner: 10Aaron Schulz) [20:45:51] superm401: Yep, devDependencies solves the versioning problem and allows you to move control of what packages are used into the repo. So that if you want to start using jscs, you can (because we're not going to install that globally on Jenkins, we made an exception for jshint but we're not doing that again) [20:45:56] 3Wikimedia / 3General/Unknown: Cleanup Lucene config for MediaWiki - 10https://bugzilla.wikimedia.org/64006 (10Chad H.) 5PAT>3RES/FIX [20:46:56] 3VisualEditor: VisualEditor: Can't save after editing categories - 10https://bugzilla.wikimedia.org/64241#c1 (10Roan Kattouw) Once you do type something and delete it, does the category get removed in the edit? [20:47:26] superm401: as for the jshintignore problem, don't have a solution. And as annoying as it is, I can't value it high enough given other things I'm doing. It doesn't affect Jenkins, and doesn't affect editor plugins, and only affects if you have nested repo setups. [20:47:42] There's only so much blame you can put on the environment and justify by adding files everywhere. [20:47:56] Krinkle, nested repo setup is common and only getting more common with MW-Vagrant. [20:48:06] nested repo is the default in mw-vagrant [20:48:07] At some point one has to say stop and fix your environment. In this case, it's one that has gotten quite wide spread and even in vagrant. [20:48:10] That' unfortunate. [20:48:13] (and also how i was told to set it up before vagrant) [20:48:24] so basicaly, it seems like your redeefining default to be convenient for your solution [20:48:27] Krinkle, I actually think you're in the minority in not having it nested. [20:48:47] I'm willing to compromise by just advising this, but I don't see how writing nothing about it is reasonable. [20:49:00] I am aware of that. But I'm also aware that everybody who did set it up that way has gotten the neccecary mileage from it. There is no justification for nesting other than not knowing better. [20:49:32] I'd like to spend time on it but can't. Write away. I'll check it out. [20:49:58] 3Analytics / 3Wikimetrics: Unicode being saved to database from a cohort upload - 10https://bugzilla.wikimedia.org/64261 (10Kevin Leduc) 3NEW p:3Unprio s:3normal a:3None Created attachment 15167 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15167&action=edit Cohort with bad char Create & Up... [20:50:06] valhallasw: Is there a config repo I can help fix things in? [20:50:18] (03CR) 10Chad: [C: 032] Avoid bogus IE extension check errors in img_auth.php [core] - 10https://gerrit.wikimedia.org/r/127862 (owner: 10Aaron Schulz) [20:50:21] (03CR) 10Jeroen De Dauw: "I'm very dubious about this Config class, esp about having it in the context thing. Not everything should know about all the config... Goi" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [20:50:23] It makes sense to nest in production and in distributions, but dev set up will benefit from keeping them untangled. Your hack with a mw-for-submodules proves it, though it streches beyond that one use case. That's just one of many. [20:50:41] 3Analytics / 3Wikimetrics: Unicode being saved to database from a cohort upload - 10https://bugzilla.wikimedia.org/64261#c1 (10Dan Andreescu) Trace that confirms this looks super weird (check out that 18 in the u'18...' below) return self.run(*args, **kwargs) File "/srv/wikimetrics/wikimetrics/models/... [20:51:00] James_F: config is inside https://github.com/valhallasw/pywikibugs/blob/master/pywikibugs.py [20:51:11] lines 45..58 for channels [20:51:25] lines 67..157 for message building [20:51:28] (03CR) 10EBernhardson: [C: 032] Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 (owner: 10Bsitu) [20:51:32] valhallasw: Eww. [20:51:39] (03CR) 10EBernhardson: [C: 032] Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [20:52:01] valhallasw: I saw config.py.example and assumed there was a config.py actual file somewhere with this stuff in it. [20:52:14] James_F: sorry, still has to be moved :-) [20:52:20] (03CR) 10Legoktm: Make abstract Config class truly implementation-agnostic (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [20:52:41] valhallasw: No worries. [20:53:13] (03CR) 10Frédéric Wang: "I don't think I can help much with the review, because I don't know anything about the MediaWiki data base." [extensions/Math] - 10https://gerrit.wikimedia.org/r/124805 (owner: 10Physikerwelt) [20:55:26] 3Wikimedia / 3wikibugs IRC bot: wikibugs reports resolver instead of commeter on comments to resolved bug? - 10https://bugzilla.wikimedia.org/19384#c2 (10Bartosz Dziewoński) 5NEW>3RES/INV This looks fixed to me, somewhere over the years. [20:55:26] 3Wikimedia / 3wikibugs IRC bot: wikibugs should show the component the bug belongs to - 10https://bugzilla.wikimedia.org/42502#c1 (10Bartosz Dziewoński) Fixed in pywikibugs! [20:55:41] 3Wikimedia / 3wikibugs IRC bot: wikibugs should show the component the bug belongs to - 10https://bugzilla.wikimedia.org/42502 (10Bartosz Dziewoński) 5NEW>3RES/INV [20:55:51] Compromise text added [20:56:17] (03Merged) 10jenkins-bot: Closing & reopening topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 (owner: 10Bsitu) [20:56:29] (03Merged) 10jenkins-bot: Closing & Summarizing topic frontend changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/119640 (owner: 10Bsitu) [20:56:49] (03PS1) 10Manybubbles: Get browser tests passing for new highlighter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/129035 [20:57:06] (03PS1) 10Siebrand: Pass phpcs-strict on maintenance/ (1/n) [core] - 10https://gerrit.wikimedia.org/r/129037 [20:57:08] (03PS1) 10Siebrand: Pass phpcs-strict on maintenance/ (2/n) [core] - 10https://gerrit.wikimedia.org/r/129038 [20:57:59] valhallasw: what do you think about making wikibugs's output closer in format to grrrit-wm's output? [20:58:18] MatmaRex: Great idea. Go for it :-) [20:58:28] (it mostly irks me that the comment is at the end) [20:58:41] 3Wikimedia / 3Deployment systems: provide a way to list active tag on all minions - 10https://bugzilla.wikimedia.org/60893#c5 (10Bryan Davis) Output from deployment-bastion: deployment-bastion:/srv/deployment/kibana/kibana (git master) bd808$ git deploy report sync Repo: kibana/kibana Tag:... [20:58:56] MatmaRex: hrm. [20:59:04] (03Merged) 10jenkins-bot: Removed $wgImgAuthPublicTest [core] - 10https://gerrit.wikimedia.org/r/127701 (owner: 10Aaron Schulz) [20:59:06] (03Merged) 10jenkins-bot: Avoid bogus IE extension check errors in img_auth.php [core] - 10https://gerrit.wikimedia.org/r/127862 (owner: 10Aaron Schulz) [20:59:23] MatmaRex: grrrit doesn't show comments at all, right? [20:59:37] just shows '(1 comment)' [20:59:48] For inline comments, yes [20:59:48] yeah [20:59:50] it shows the "cover comment", or "review" [20:59:54] If you leave a top-level comment it will be shown [20:59:55] Modified the jshintignore text a little more [21:00:19] but having it in the same order (Most major change) user: - url - other stuff [21:00:22] makes sense, I think [21:00:34] (03CR) 10Krinkle: Make users API cache mode public if blockinfo is not queried (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127859 (owner: 10Gergő Tisza) [21:00:58] (03PS4) 10Bartosz Dziewoński: Resolve complex arguments to LESS helper functions [core] - 10https://gerrit.wikimedia.org/r/129023 (owner: 10EBernhardson) [21:01:00] (03PS8) 10EBernhardson: Add 'edit topic summary' no javascript support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120485 (owner: 10Bsitu) [21:01:22] (03CR) 10EBernhardson: [C: 032] Add 'edit topic summary' no javascript support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120485 (owner: 10Bsitu) [21:02:24] (03CR) 10Krinkle: [C: 031] "Untested." [core] - 10https://gerrit.wikimedia.org/r/127818 (owner: 10Mattflaschen) [21:02:39] (03Merged) 10jenkins-bot: Add 'edit topic summary' no javascript support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/120485 (owner: 10Bsitu) [21:04:26] (03CR) 10Bsitu: [C: 032] Slightly faster uuid -> timestamp conversion [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126847 (owner: 10EBernhardson) [21:04:29] (03CR) 10jenkins-bot: [V: 04-1] Slightly faster uuid -> timestamp conversion [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126847 (owner: 10EBernhardson) [21:05:04] (03CR) 10Anomie: Make users API cache mode public if blockinfo is not queried (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127859 (owner: 10Gergő Tisza) [21:06:03] (03PS2) 10EBernhardson: Slightly faster uuid -> timestamp conversion [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126847 [21:06:32] (03CR) 10EBernhardson: [C: 032] "rebase and reapply bsitu +2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126847 (owner: 10EBernhardson) [21:06:41] 3MediaWiki extensions / 3TextExtracts: Hovercards: research how we could exclude IPA elements from extract - 10https://bugzilla.wikimedia.org/63797#c3 (10Dan Garry) The purpose of Hovercards is to give an overview of the topic, so you can decide whether or not you want to read the article. Pronunciation info... [21:06:48] (03Merged) 10jenkins-bot: Slightly faster uuid -> timestamp conversion [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126847 (owner: 10EBernhardson) [21:07:13] (03PS1) 10Siebrand: Pass phpcs-strict on maintenance/ (3/n) [core] - 10https://gerrit.wikimedia.org/r/129040 [21:08:41] 3Wikipedia App / 3Generic: [Android] Log out has no icon - 10https://bugzilla.wikimedia.org/64078#c2 (10Gerrit Notification Bot) Change 127680 merged by Dbrant: Remove white square next to 'log out' icon https://gerrit.wikimedia.org/r/127680 [21:08:56] 3Wikimedia / 3Deployment systems: Deployment: Repository .git is synchronised fine, but is broken for submodules because of hardcoded gitdir link - 10https://bugzilla.wikimedia.org/53972#c8 (10Bryan Davis) (In reply to Bryan Davis from comment #2) > I can't find any reason by grepping in operations/puppet th... [21:10:38] James_F: looks good to me! [21:11:19] valhallasw: It's been a long time since I've done Python, so… :-) [21:11:28] James_F: well, if wikibugs doesn't come back up... ;-) [21:11:38] * James_F grins. [21:11:41] but I get no syntax errors, so all should be 'swell. [21:12:41] 3Pywikibot / 3category.py: category.py tree uses all memory - 10https://bugzilla.wikimedia.org/64186#c2 (10Amir Ladsgroup) this problem exists in compat as well [21:14:41] (03CR) 10BryanDavis: [C: 032] Cirrus improvements [vagrant] - 10https://gerrit.wikimedia.org/r/128955 (owner: 10Manybubbles) [21:14:43] (03CR) 10Gergő Tisza: Make users API cache mode public if blockinfo is not queried (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127859 (owner: 10Gergő Tisza) [21:14:47] (03Merged) 10jenkins-bot: Cirrus improvements [vagrant] - 10https://gerrit.wikimedia.org/r/128955 (owner: 10Manybubbles) [21:14:55] bd808: thanks [21:15:05] yw [21:15:24] (03PS3) 10Gergő Tisza: Make users API cache mode public if blockinfo is not queried [core] - 10https://gerrit.wikimedia.org/r/127859 [21:21:11] (03PS1) 10Aaron Schulz: Added --multiversiononly option to image SHA1 population script [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/129041 [21:21:42] 3Wikimedia / 3Deployment systems: provide a way to list active tag on all minions - 10https://bugzilla.wikimedia.org/60893#c6 (10Antoine "hashar" Musso) 5NEW>3RES/FIX a:3Ryan Lane So Ryan did implement the feature and we got it deployed on the cluster. Thanks Ryan for the implementation and Bryan for... [21:25:08] (03PS1) 10Siebrand: Pass phpcs-strict on maintenance/ (4/8) [core] - 10https://gerrit.wikimedia.org/r/129042 [21:25:25] (03PS2) 10Siebrand: Pass phpcs-strict on maintenance/ (1/8) [core] - 10https://gerrit.wikimedia.org/r/129037 [21:25:30] (03PS2) 10Siebrand: Pass phpcs-strict on maintenance/ (2/8) [core] - 10https://gerrit.wikimedia.org/r/129038 [21:25:36] (03PS2) 10Siebrand: Pass phpcs-strict on maintenance/ (3/8) [core] - 10https://gerrit.wikimedia.org/r/129040 [21:25:49] (03PS3) 10Siebrand: Pass phpcs-strict on maintenance/ (2/8) [core] - 10https://gerrit.wikimedia.org/r/129038 [21:25:55] (03PS3) 10Siebrand: Pass phpcs-strict on maintenance/ (3/8) [core] - 10https://gerrit.wikimedia.org/r/129040 [21:26:02] (03PS2) 10Siebrand: Pass phpcs-strict on maintenance/ (4/8) [core] - 10https://gerrit.wikimedia.org/r/129042 [21:26:04] (03CR) 10Krinkle: "r" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127859 (owner: 10Gergő Tisza) [21:27:31] (03CR) 10Krinkle: [C: 04-1] "The sentence "Ignore silencing errors is discouraged warning " looks a bit weird. Some of those words don't be long?" [core] - 10https://gerrit.wikimedia.org/r/129037 (owner: 10Siebrand) [21:28:57] (03CR) 10Siebrand: "It's perfectly fine." [core] - 10https://gerrit.wikimedia.org/r/129037 (owner: 10Siebrand) [21:34:11] 3MediaWiki extensions / 3WikidataClient: UpdateRepoOnMoveJob not registered in wikidata for wikisource page moves - 10https://bugzilla.wikimedia.org/62779#c3 (10billinghurst) A bot is currently doing the updates following a move, so some change have taken place somewhere. I undertook the move at enWS 15:53... [21:34:16] (03PS5) 10Bsitu: Templating::getContent() should return safe-to-display content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127666 [21:34:19] (03CR) 10Ori.livneh: Tidy ext.eventLogging.{subscriber.js,core.js,jsonSchema.css} (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/127667 (owner: 10Ori.livneh) [21:34:34] (03CR) 10Gergő Tisza: Make users API cache mode public if blockinfo is not queried (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127859 (owner: 10Gergő Tisza) [21:35:37] (03CR) 10Bsitu: Templating::getContent() should return safe-to-display content (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127666 (owner: 10Bsitu) [21:36:11] 3Wikimedia / 3Quality Assurance: Failure in MMV browser tests - 10https://bugzilla.wikimedia.org/64249#c3 (10Chris McMahon) This from David Burns (https://github.com/AutomatedTester) in the #selenium channel on IRC: (02:17:50 PM) chrismcmahon: AutomatedTester: ever dealt with Abrowser and webdriver? htt... [21:36:29] wat [21:43:41] 3MediaWiki extensions / 3WikidataRepo: prevent import of items - 10https://bugzilla.wikimedia.org/63228#c4 (10Marius Hoch) (In reply to Kunal Mehta (Legoktm) from comment #3) > Makes sense. In that case, you can just add a hook for > 'TitleQuickPermissions' in wmf-config/CommonSettings.php to deny any user >... [21:47:01] (03PS1) 10Skizzerz: Version 3.4 containing some minor fixes and changes [extensions/EditSubpages] - 10https://gerrit.wikimedia.org/r/129044 [21:47:24] (03PS4) 10BryanDavis: Run scap when config or code is updated [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126870 [21:48:05] chrismcmahon: That's an interesting exchange... [21:48:25] howso interesting? [21:48:57] Just the whole thing [21:49:09] Intriguing that abrowser may have actually changed something [21:49:40] hey gi11es, if you have a moment, do you have any questions regarding the reviews for gwtoolset? https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/GWToolset,n,z [21:51:22] dan-nl: our team has a rotation for reviewing changesets on projects that we're not actively developing on, this weel marktraceur is your man :) I'll take a look tomorrow if he doesn't get around to it today [21:51:28] *this week [21:51:42] ah, okay, thanks [21:51:44] dan-nl: you can find us in #wikimedia-multimedia [21:51:48] Oh joy. [21:52:06] marktraceur: browsers are bizarre. btw, if you want to know where all the bodies are buried in Firefox, David Burns (AutomatedTester) is your guy. [21:52:09] ja, i figured you might like that one marktraceur :) [21:52:23] Heh [21:52:28] chrismcmahon: I'm asking in #trisquel [21:52:37] (03CR) 10BryanDavis: Run scap when config or code is updated (034 comments) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126870 (owner: 10BryanDavis) [21:52:45] (03PS5) 10BryanDavis: Run scap when config or code is updated [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126870 [21:54:57] 3MediaWiki extensions / 3Flow: Flow: titlebar's participant icon in Small view breaks apart - 10https://bugzilla.wikimedia.org/62074#c2 (10spage ) It happens all the time now in chromium and Firefox. The CSS that draws the decoration is for .flow-topic-posts-meta-minimal:after. This doesn't happen in the E... [21:55:02] legoktm: does quickUserCan check for blocks? [21:55:05] MatmaRex: ^ [21:56:12] 3Analytics / 3General/Unknown: cp301[34] mobile traffic not in udp2log's mobile-sampled-100 and zero stream - 10https://bugzilla.wikimedia.org/64145#c7 (10christian ) Ops changed plans, and they removed cp301[34] from the set of frontend varnishes again. They'll redo the machines differently, and will not t... [21:56:41] (03CR) 10BryanDavis: [C: 032] "Published to Jenkins." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126870 (owner: 10BryanDavis) [21:57:22] (03Merged) 10jenkins-bot: Run scap when config or code is updated [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126870 (owner: 10BryanDavis) [21:57:24] YuviPanda: no idea [21:57:26] 3Wikimedia / 3Site requests: Add Swedish aliases for EducationProgram namespace - 10https://bugzilla.wikimedia.org/62259#c14 (10Tomasz W. Kozlowski) 5PAT>3RES/FIX This has now been merged. [21:57:26] 3Wikipedia App / 3Generic: App Icon Should be 'W' not generic Android icon - 10https://bugzilla.wikimedia.org/61259#c1 (10Gerrit Notification Bot) Change 129046 had a related patch set uploaded by Yuvipanda: Add new app icon https://gerrit.wikimedia.org/r/129046 [21:57:28] hmm, ok [21:57:41] 3Wikipedia App / 3Generic: App Icon Should be 'W' not generic Android icon - 10https://bugzilla.wikimedia.org/61259 (10Gerrit Notification Bot) 5NEW>3PAT [22:00:11] 3MediaWiki / 3User preferences: Redesign Special:Preferences (tracking) - 10https://bugzilla.wikimedia.org/62559 (10Matthew Flaschen) [22:01:45] (03CR) 10leucosticte: "So, you want it to use the serial data type, or what? I don't see that in use anywhere in https://git.wikimedia.org/blob/mediawiki%2Fcore." [core] - 10https://gerrit.wikimedia.org/r/112825 (owner: 10leucosticte) [22:03:10] (03PS9) 10EBernhardson: Standardize URL generation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121855 [22:04:26] 3MobileFrontend / 3stable: Wrong user icons in watchlist and page history - 10https://bugzilla.wikimedia.org/64202#c3 (10Gerrit Notification Bot) Change 127845 merged by jenkins-bot: Push new page feed style tweaks to stable for history and watchlist https://gerrit.wikimedia.org/r/127845 [22:04:58] 3Analytics / 3General/Unknown: Install rJava on stat2 - 10https://bugzilla.wikimedia.org/64262 (10Oliver Keyes) 3NEW p:3Unprio s:3normal a:3None RJDBC is a direct connector between R and JDBC - in other words, it'll allow me to read Hive/Hadoop data directly into R, which is kind of a good prerequisi... [22:06:13] 3Wikipedia App / 3Generic: New icon looks wobbly on light backgrounds - 10https://bugzilla.wikimedia.org/64263 (10Yuvi Panda) 3NEW p:3Unprio s:3normal a:3None Created attachment 15168 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15168&action=edit Screenshot of icon in actionbar Such as the... [22:06:41] 3Wikipedia App / 3Generic: New icon looks wobbly on light backgrounds - 10https://bugzilla.wikimedia.org/64263#c1 (10Yuvi Panda) Created attachment 15169 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15169&action=edit Screenshot of icon in recently used lists [22:08:42] 3MediaWiki extensions / 3Flow: Flow: Small view and "This topic hidden" titlebars are misaligned after typography refresh - 10https://bugzilla.wikimedia.org/62073#c10 (10spage ) 5PAT>3RES/FIX Fixed and backported to 1.24wmf1. [22:10:26] 3MediaWiki / 3General/Unknown: After upgrading: FauxRequest::getRequestURL() not implemented - 10https://bugzilla.wikimedia.org/61273#c5 (10jimmy conway) Is there any update on this issue? We run MediaWiki in a productive environment and are pretty lost without any help from you guys. Is there anything we ca... [22:10:45] (03CR) 10EBernhardson: "rebased, but i can't seem to trigger these errors. UpdateFlowRecentChanges should only work on RC rows that have the 'type' option set, w" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121855 (owner: 10EBernhardson) [22:11:02] (03CR) 10Parent5446: [C: 04-1] Make abstract Config class truly implementation-agnostic (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [22:12:42] (03CR) 10Mattflaschen: "Yes, please use wgCookiePrefix (it's already exported to JavaScript) to prefix the key." [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [22:12:56] (03PS10) 10EBernhardson: Standardize URL generation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121855 [22:15:26] 3MobileFrontend / 3stable: Wrong user icons in watchlist and page history - 10https://bugzilla.wikimedia.org/64202 (10Jon) 5PAT>3RES/FIX [22:16:23] (03CR) 10Mattflaschen: mediawiki.action.edit: Autosave edit textareas in localStorage (031 comment) [core] - 10https://gerrit.wikimedia.org/r/5130 (owner: 10Joancreus) [22:19:11] 3Analytics / 3General/Unknown: Install rJava on stat2 - 10https://bugzilla.wikimedia.org/64262#c1 (10Toby Negrin) p:5Unprio>3High Hi Andrew -- reviewing this bug, it seems like debianizing this package would be time consuming. Thoughts? -Toby [22:20:11] 3Analytics / 3General/Unknown: Install rJava on stat2 - 10https://bugzilla.wikimedia.org/64262#c2 (10Oliver Keyes) That's the thing; rJava, which is debianised, is the only thing I actually need Engineering support to install. RJDBC /should/ be doable as a local library, which is how we handled RDBC and RMyS... [22:24:19] (03CR) 10Aaron Schulz: [C: 032] Added --multiversiononly option to image SHA1 population script [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/129041 (owner: 10Aaron Schulz) [22:26:09] dan-nl: Hi [22:26:23] ah, hey bawolff [22:26:35] dan-nl: Sorry I didn't get the chance to review your code [22:26:56] 3Wikipedia App / 3Generic: App Icon Should be 'W' not generic Android icon - 10https://bugzilla.wikimedia.org/61259#c2 (10Gerrit Notification Bot) Change 129046 merged by jenkins-bot: Add new app icon https://gerrit.wikimedia.org/r/129046 [22:27:03] np, i understand. was hoping someone else might be able to look at it, but everyone is busy atm [22:27:08] (03PS7) 10EBernhardson: Provide better URLs to IRC rcfeed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123114 [22:27:26] Yeah, getting people to do code review is hard [22:27:27] (03CR) 10jenkins-bot: [V: 04-1] Provide better URLs to IRC rcfeed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123114 (owner: 10EBernhardson) [22:27:30] (03Merged) 10jenkins-bot: Added --multiversiononly option to image SHA1 population script [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/129041 (owner: 10Aaron Schulz) [22:27:30] would really like to get these open patches completed though [22:27:36] Don't be afraid to nag people [22:28:04] ja, that's one thing i don't like to do too much [22:29:06] gi11es: metioned that marktraceur is supposed to review gwtoolset this week, but i think he just found out … gi11es mentioned that he will try to look at it tomorrow if marktraceur can't get to it today [22:29:24] bawolff, would you be able to look at any of the open patches today? [22:29:25] oh that's good [22:29:39] Umm, maybe. no garuntees [22:29:44] :) [22:30:29] some of them i think are straight forward for you, but maybe not; e.g., https://gerrit.wikimedia.org/r/#/c/124347/ [22:30:52] and https://gerrit.wikimedia.org/r/#/c/124376/ [22:30:54] dan-nl: Just so you know, I'm going to be away for about three weeks after tommorow, so if I don't respond to things, I'm not ignoring you, I'm just away :) [22:31:13] ah, that's good to know … thanks [22:31:53] dan-nl: Also, just a heads up - you heard about the recent issue on the image scalers at commons that was sort of caused by gwtoolset? [22:32:17] no [22:32:40] what happened? what needs to be fixed/addressed? [22:32:47] Not directly gwtoolset's fault [22:33:02] (03PS8) 10EBernhardson: Provide better URLs to IRC rcfeed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123114 [22:33:15] Fae used gwtoolset to upload a bunch of really big tiff files. Gwtoolset uploaded them really quickly, and it overloaded the image scaling servers [22:33:37] (03CR) 10jenkins-bot: [V: 04-1] Provide better URLs to IRC rcfeed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123114 (owner: 10EBernhardson) [22:33:40] oh no … [22:34:58] I haven't entirely followed the situation, but from what I gather AaronSchulz made some changes to how the image scalers work so they can't all be overloaded at the same time by big files [22:35:25] that is odd though because the jobs for gwtoolset seem to run very slow at the moment … at least for david when he uploaded some images from the Swedish National Heritage Board [22:35:35] well I just tweaked some pre-existing stuff, technically if the download is fast but the convert slow...it's a problem [22:36:04] though I don't think that's the case atm [22:36:06] ah, maybe that's what happened with david's batch .. [22:36:16] dan-nl: summary at http://lists.wikimedia.org/pipermail/multimedia/2014-April/000276.html [22:36:28] possibly a slow server at the Swedish National Heritage Board [22:36:30] bawolff: how is the vips stuff going? Is anyone on that? [22:36:43] Basically no [22:36:59] bawolff: thanks for that link [22:37:03] is it just a matter of MW code? [22:37:18] I had a work in progress patch from months ago, but I never got around to finishing it. And nobody else has looked at it [22:37:48] is there anyway to see the stuff sent to wfDebugLog() when jenkins is running tests? [22:39:09] Basically yes. If I remember correctly issues were that VipsScaler was expecting to work with a subclass of BitmapHandler, which TiffHandler isn't, and the command that vips used had to be changed for tiffs as the one we use for bitmaps segfaults for tiff files (might have just been my install) [22:39:22] (03CR) 10PiRSquared17: "Legoktm: does anything need to be changed here other than adding the available right?" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader) [22:39:29] But probably just a simple matter of programming, and not that much [22:40:43] bawolff: are going to look at that before disappearing or should someone else? [22:40:56] * AaronSchulz can take a look if needed [22:41:12] There might be some issues with quality of thumbnails for some thumbs, which might be a less straightforward problem to solve, people would have to check a variety of image types and all that [22:41:21] Feel free to look [22:41:49] I plan to eventually come back to it if nobody else does, but I'm probably not going to have an opportunity to look at it in the near term [22:43:11] 3MediaWiki / 3Parser: Local interwiki links with additional non-local interwiki prefixes are not interpreted as links - 10https://bugzilla.wikimedia.org/61357#c5 (10This, that and the other) You could ask: what's the use for local interwikis? This was evidently a bug in MediaWiki's handling of local interwik... [22:45:47] AaronSchulz: For reference, my half done patch was https://gerrit.wikimedia.org/r/#/c/86416/ and https://gerrit.wikimedia.org/r/#/c/86413/ [22:46:39] gi11es: Is it okay if I punt the GWT review to you? I'm not familiar with it...unless you're no more familiar, in which case I may as well go ahead. [22:48:16] I know nothing about that code, which is why I asked for more information to be able to review without knowing the inner workings [22:48:23] Aha. [22:48:31] Well, then, leeroy jenkins [22:48:37] given the lack of tests, without repro steps there was no way to review at all [22:49:56] 3VisualEditor / 3MediaWiki integration: VisualEditor: Print/Export tools are enabled while editing - 10https://bugzilla.wikimedia.org/57940#c1 (10Gerrit Notification Bot) Change 129059 had a related patch set uploaded by Alex Monk: Hide some tools when VE is open https://gerrit.wikimedia.org/r/129059 [22:49:56] 3Analytics / 3Wikimetrics: WMF Oauth won't authenticate staging - 10https://bugzilla.wikimedia.org/63919#c3 (10Toby Negrin) 5NEW>3RES/FIX Dan has fixed this. [22:49:57] 3VisualEditor / 3MediaWiki integration: VisualEditor: Print/Export tools are enabled while editing - 10https://bugzilla.wikimedia.org/57940 (10Gerrit Notification Bot) 5ASS>3PAT [22:50:11] (03PS2) 10BryanDavis: Fix Fatal error: Call to a member function doTransform() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/127617 (owner: 10Reedy) [22:50:41] 3Analytics / 3Wikimetrics: Fix ignored integration tests - 10https://bugzilla.wikimedia.org/64059 (10Toby Negrin) p:5Unprio>3Normal [22:51:41] 3Analytics / 3Wikimetrics: Unicode being saved to database from a cohort upload - 10https://bugzilla.wikimedia.org/64261#c2 (10Toby Negrin) p:5Unprio>3Normal This is hard to prioritize without understanding how common it is -- does the bug impact all users/cohorts? [22:51:44] (03PS1) 10Violetto: Test commit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/129060 [22:52:13] (03CR) 10jenkins-bot: [V: 04-1] Test commit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/129060 (owner: 10Violetto) [22:52:13] ebernhardson: Did you figure out where the logs are? You should be able to download the logs from a build from Jenkins as a "Build Artifact" [22:52:27] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] The first letter of the reference text disappears after typing in the reference dialog box - 10https://bugzilla.wikimedia.org/63909#c11 (10ryasmeen ) 5RES/FIX>3REO For FireFox, I am getting this problem in a slightly different manner: In... [22:52:43] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] The first letter of the reference text disappears after typing in the reference dialog box - 10https://bugzilla.wikimedia.org/63909 (10ryasmeen ) a:5Roan Kattouw>3Ed Sanders [22:52:43] (03Abandoned) 10Violetto: Test commit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/129060 (owner: 10Violetto) [22:52:48] (03CR) 10BryanDavis: [C: 032] Fix Fatal error: Call to a member function doTransform() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/127617 (owner: 10Reedy) [22:53:06] (03Merged) 10jenkins-bot: Fix Fatal error: Call to a member function doTransform() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/127617 (owner: 10Reedy) [22:53:11] (03CR) 10Bartosz Dziewoński: "Unit tests for this would be nice (especially since the implementation is wonky :( ) – there is currently one test case for LESS compilati" [core] - 10https://gerrit.wikimedia.org/r/129023 (owner: 10EBernhardson) [22:53:26] 3MediaWiki extensions / 3TimedMediaHandler: Fatal error: Call to a member function doTransform() on a non-object in TimedMediaThumbnail.php on line 201 - 10https://bugzilla.wikimedia.org/64152#c7 (10Gerrit Notification Bot) Change 127617 merged by jenkins-bot: Fix Fatal error: Call to a member function doTra... [22:54:58] AaronSchulz: In regards to this situation though, I'm not sure if vips would actually help that much. From what I remember (haven't exactly tested), it reduced memory usage significantly, but only reduced the amount of time to shrink a thumbnail mildly. So I'm not sure it would really help all that much with scalers being overloaded [22:57:00] gi11es: So wait, you have a setup where you can test and repro and so on? Because that's ahead of me. [22:57:20] no, I asked dan-nl to provide repro steps [22:57:34] Where? [22:57:37] there's no escaping your weekly duty! [22:57:57] marktraceur: which bug? [22:57:58] on the changesets I interacted on last week [22:58:03] All of them, dan-nl? [22:58:12] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] The first letter of the reference text disappears after typing in the reference dialog box - 10https://bugzilla.wikimedia.org/63909#c12 (10ryasmeen ) Also the following errors appear on the console while trying to delete the texts inside the... [22:58:32] Unless you don't want them merged, I mean, I'm happy to only review some of them if you prefer [22:58:37] i added an xml file and steps to reproduce on the ones gi11es asked me to [22:58:45] dan-nl: Which one is that? [22:58:47] was hoping bawolff would get to the ones we discussed [22:58:50] I can start with that [22:58:54] Oh [22:58:56] * dan-nl : looking them up [22:59:46] marktraceur: https://bugzilla.wikimedia.org/show_bug.cgi?id=63646 [22:59:56] 3Parsoid / 3DOM: Add DOM support for {{DISPLAYTITLE:xxx}} - 10https://bugzilla.wikimedia.org/56870#c1 (10Alex Monk) I began looking into what might be needed to do this earlier, based on how defaultsort is handled (which seems to have needed a similar transclusion -> meta item change). Looking at parsoid/li... [23:00:59] marktraceur: https://bugzilla.wikimedia.org/show_bug.cgi?id=63822 [23:02:41] 3VisualEditor / 3MediaWiki integration: VisualEditor: Globally-blocked logged-out users are not blocked from using VE (just from saving); should instead show the relevant global block message - 10https://bugzilla.wikimedia.org/53009#c3 (10Gerrit Notification Bot) Change 127840 merged by jenkins-bot: Show not... [23:03:00] marktraceur: https://bugzilla.wikimedia.org/show_bug.cgi?id=64086 [23:05:05] I get an unrelated-looking error. [23:05:43] 3MobileFrontend / 3beta: Buttons don't have mediawiki ui styling in beta and alpha - 10https://bugzilla.wikimedia.org/64264 (10Kaity Hammerstein) 3NEW p:3Unprio s:3normal a:3None Created attachment 15170 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15170&action=edit button is too rounded, t... [23:05:56] GWToolset\Helpers\GWTFileBackend::setupFileBackend: No file backend name provided. [23:05:59] dan-nl: ^^ [23:06:09] (03CR) 10Bsitu: Add summarize/close/open topic to history/contribution (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123123 (owner: 10Bsitu) [23:06:15] It says "contact a developer" but I'm clueless so I assume it means you. [23:06:56] 3VisualEditor / 3MediaWiki integration: VisualEditor: Allow users to set/edit {{DISPLAYTITLE:xxx}} in the page metadata panel - 10https://bugzilla.wikimedia.org/56868 (10Gerrit Notification Bot) 5ASS>3PAT [23:06:56] 3VisualEditor / 3MediaWiki integration: VisualEditor: Allow users to set/edit {{DISPLAYTITLE:xxx}} in the page metadata panel - 10https://bugzilla.wikimedia.org/56868#c4 (10Gerrit Notification Bot) Change 129065 had a related patch set uploaded by Alex Monk: Basic VE code for changing displaytitle as wikitex... [23:07:37] marktraceur: did you go through the INSTALL notes of the extension? [23:07:41] 3MobileFrontend / 3stable: No mobile diff redirect - 10https://bugzilla.wikimedia.org/63999#c3 (10Gerrit Notification Bot) Change 127344 had a related patch set uploaded by Jdlrobson: Improve diff detection https://gerrit.wikimedia.org/r/127344 [23:07:47] Probly not [23:08:41] 3MediaWiki extensions / 3WikidataClient: handle no value and other property snak types in property parser function - 10https://bugzilla.wikimedia.org/46361#c3 (10Marius Hoch) (In reply to Aude from comment #2) > [...] > For no value, we might want it to output (none) or something like that. Lua currently ou... [23:08:44] (03PS1) 10Ori.livneh: Update MultimediaViewer for I595446dc5 [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/129066 [23:09:16] oh nice... we have a bot reporting bug changes again :) [23:09:27] aude: ^ want to reply really quick? [23:09:44] (03PS1) 10Ori.livneh: Update MultimediaViewer for I595446dc5 [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/129067 [23:09:54] marktraceur: here's what i've got in my localsettings.php http://pastebin.com/B8VCKTqW [23:10:10] (03CR) 10Ori.livneh: [C: 032] Update MultimediaViewer for I595446dc5 [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/129066 (owner: 10Ori.livneh) [23:10:26] 3MobileFrontend / 3beta: Buttons don't have mediawiki ui styling in beta and alpha - 10https://bugzilla.wikimedia.org/64264#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1952 [23:10:33] (03CR) 10Ori.livneh: [C: 032] Update MultimediaViewer for I595446dc5 [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/129067 (owner: 10Ori.livneh) [23:11:40] (03PS9) 10Bsitu: Add topic/post summary diff view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121128 [23:11:56] 3MediaWiki extensions / 3Flow: Flow: flow-enabling a page that is a redirect, leads to problems - 10https://bugzilla.wikimedia.org/63081#c1 (10Quiddity) 5NEW>3RES/FIX p:5Unprio>3Normal No longer a problem. [23:12:05] I'm working through it [23:12:12] dan-nl: This is surprisingly painful to set up [23:12:26] 3MobileFrontend / 3stable: No mobile diff redirect - 10https://bugzilla.wikimedia.org/63999#c4 (10Gerrit Notification Bot) Change 127344 merged by jenkins-bot: Improve diff detection https://gerrit.wikimedia.org/r/127344 [23:12:41] (03PS14) 10EBernhardson: Add summarize/close/open topic to history/contribution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123123 (owner: 10Bsitu) [23:13:14] (03PS1) 10Ori.livneh: Set line-height for code icon on schema pages [extensions/EventLogging] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/129068 [23:13:26] 3Analytics / 3EventLogging: Code icon on schema pages has incorrect height - 10https://bugzilla.wikimedia.org/64251#c3 (10Gerrit Notification Bot) Change 129068 had a related patch set uploaded by Ori.livneh: Set line-height for code icon on schema pages https://gerrit.wikimedia.org/r/129068 [23:13:34] (03CR) 10Ori.livneh: [C: 032] Set line-height for code icon on schema pages [extensions/EventLogging] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/129068 (owner: 10Ori.livneh) [23:14:19] (03CR) 10EBernhardson: [C: 032] Add topic/post summary diff view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121128 (owner: 10Bsitu) [23:14:31] (03CR) 10EBernhardson: [C: 032] Add summarize/close/open topic to history/contribution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123123 (owner: 10Bsitu) [23:14:41] 3MobileFrontend / 3stable: No mobile diff redirect - 10https://bugzilla.wikimedia.org/63999 (10Max Semenik) 5PAT>3RES/FIX [23:15:10] (03Merged) 10jenkins-bot: Add topic/post summary diff view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121128 (owner: 10Bsitu) [23:15:26] (03Merged) 10jenkins-bot: Add summarize/close/open topic to history/contribution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123123 (owner: 10Bsitu) [23:15:43] 3MobileFrontend / 3beta: Main page "this page needs help" typography is incorrect - 10https://bugzilla.wikimedia.org/64265 (10Kaity Hammerstein) 3NEW p:3Unprio s:3normal a:3None Created attachment 15171 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15171&action=edit current screenshot The m... [23:15:45] dan-nl: OK, I've gotten to the point where files exist on my wiki, but I don't see the location field [23:16:08] location field? [23:16:08] I only see the gwtoolset-title-identifier and gwtoolset-url-to-the-media-file fields [23:16:17] Not the current-location one [23:16:26] (03Merged) 10jenkins-bot: Update MultimediaViewer for I595446dc5 [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/129066 (owner: 10Ori.livneh) [23:16:41] 3MobileFrontend / 3beta: Main page "this page needs help" typography is incorrect - 10https://bugzilla.wikimedia.org/64265#c1 (10Kaity Hammerstein) Created attachment 15172 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15172&action=edit original design [23:16:43] (03Merged) 10jenkins-bot: Set line-height for code icon on schema pages [extensions/EventLogging] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/129068 (owner: 10Ori.livneh) [23:16:56] 3Analytics / 3EventLogging: Code icon on schema pages has incorrect height - 10https://bugzilla.wikimedia.org/64251#c4 (10Gerrit Notification Bot) Change 129068 merged by jenkins-bot: Set line-height for code icon on schema pages https://gerrit.wikimedia.org/r/129068 [23:17:33] (03Merged) 10jenkins-bot: Update MultimediaViewer for I595446dc5 [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/129067 (owner: 10Ori.livneh) [23:17:49] marktraceur: re backend error message - It should probably default to setting up something sane - that's probably a "low" priority bug [23:17:59] Maybe I have a too-old version. Sec. [23:19:07] There it is! [23:19:09] OK cool [23:19:18] ah good :) [23:19:41] 3MobileFrontend / 3beta: Mobile history desktop link doesn't point to right place - 10https://bugzilla.wikimedia.org/64112#c3 (10Gerrit Notification Bot) Change 127794 merged by jenkins-bot: Special-case history and diff desktop links https://gerrit.wikimedia.org/r/127794 [23:19:45] Excellent. [23:20:13] (03CR) 10MarkTraceur: [C: 032] don’t place sub-template into main template when no value is present [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/124376 (owner: 10Dan-nl) [23:20:26] 3MobileFrontend / 3beta: Main page "this page needs help" typography is incorrect - 10https://bugzilla.wikimedia.org/64265#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1953 [23:20:30] (03Merged) 10jenkins-bot: don’t place sub-template into main template when no value is present [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/124376 (owner: 10Dan-nl) [23:20:41] marktraceur thanks! [23:20:41] 3MediaWiki extensions / 3GWToolset: don’t place sub-template into main template when no value is present - 10https://bugzilla.wikimedia.org/63646#c4 (10Gerrit Notification Bot) Change 124376 merged by jenkins-bot: don’t place sub-template into main template when no value is present https://gerrit.wikimedia.... [23:20:50] Yup! [23:20:52] On to next [23:20:56] 3MediaWiki extensions / 3GWToolset: don’t place sub-template into main template when no value is present - 10https://bugzilla.wikimedia.org/63646 (10Mark Holmquist) 5PAT>3RES/FIX [23:21:18] (03PS1) 10Ori.livneh: Update EventLogging for Iaa232298e [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/129070 [23:21:56] 3MobileFrontend / 3beta: Mobile history desktop link doesn't point to right place - 10https://bugzilla.wikimedia.org/64112 (10Jon) 5PAT>3RES/FIX [23:23:12] (03CR) 10Ori.livneh: [C: 032] Update EventLogging for Iaa232298e [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/129070 (owner: 10Ori.livneh) [23:25:54] (03CR) 10MarkTraceur: [C: 032] "Thanks!" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/125552 (owner: 10Dan-nl) [23:26:28] 3MediaWiki / 3Recent changes: Enhanced Recent Changes needs hook(s) for customised formatting, similar to OldChangesListRecentChangesLine hook - 10https://bugzilla.wikimedia.org/53851 (10Aude) a:3Aude [23:26:29] (03Merged) 10jenkins-bot: Update EventLogging for Iaa232298e [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/129070 (owner: 10Ori.livneh) [23:26:31] (03Merged) 10jenkins-bot: auto-add additional mediawiki template parameters as creator template values [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/125552 (owner: 10Dan-nl) [23:26:41] 3MediaWiki extensions / 3GWToolset: auto-add additional mediawiki template parameters as creator template values - 10https://bugzilla.wikimedia.org/63822#c4 (10Gerrit Notification Bot) Change 125552 merged by jenkins-bot: auto-add additional mediawiki template parameters as creator template values https://g... [23:26:56] 3MediaWiki extensions / 3GWToolset: auto-add additional mediawiki template parameters as creator template values - 10https://bugzilla.wikimedia.org/63822 (10Mark Holmquist) 5PAT>3RES/FIX [23:28:56] 3MediaWiki / 3General/Unknown: Main WebRequest object an instance of FauxRequest - 10https://bugzilla.wikimedia.org/61273#c6 (10Bawolff (Brian Wolff)) Something really funky is going on with your install. Could you try disabling all extensions and seeing if the error still occurs. If it still occurs, could y... [23:29:20] marktraceur: excellent [23:29:22] (03PS2) 10MarkTraceur: fix MediawikiTemplate::getTitle() method [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/127211 (owner: 10Dan-nl) [23:29:44] I'm not seeing the problem with 64086 [23:29:50] i.e. cannot repro [23:30:54] have you turned on E_STRICT|E_ALL ? [23:31:26] 3MediaWiki extensions / 3WikidataClient: handle no value and other property snak types in property parser function - 10https://bugzilla.wikimedia.org/46361#c4 (10Gerrit Notification Bot) Change 129072 had a related patch set uploaded by Hoo man: Move the messages to describe novalue and somevalue Snaks to li... [23:31:26] 3MediaWiki extensions / 3WikidataClient: handle no value and other property snak types in property parser function - 10https://bugzilla.wikimedia.org/46361 (10Gerrit Notification Bot) 5NEW>3PAT [23:32:08] you'll only get the ntoice with that error_reporting() value [23:32:49] Oh, maybe. [23:33:03] Ah, no, ls.php has it set [23:33:15] error_reporting( E_ALL ); [23:33:15] ini_set( 'display_errors', 1 ); [23:33:31] i think it's the E_STRICT that will show the notice [23:33:35] 'kay [23:33:44] so, error_reporting( E_STRICT | E_ALL ); [23:33:58] 3Huggle / 3Application: Requesting G12-deletion (Copyvio) - 10https://bugzilla.wikimedia.org/64266 (10gladjonatan ) 3UNC p:3Unprio s:3normal a:3Peter Bena When requesting for g12-deleetion Huggle should provide the user to enter up to three url's to go with the template like: {{db-g12|url=http//examp... [23:34:53] I think it still doesn't show up. [23:35:26] 3Parsoid: Production log errors: Failed template encapsulations - 10https://bugzilla.wikimedia.org/64017#c4 (10Gerrit Notification Bot) Change 127728 merged by jenkins-bot: (Bug 64017) Fixed longstanding tpl-range overlap detection bug https://gerrit.wikimedia.org/r/127728 [23:35:27] hmm, odd, are you using the new dataset from that bug? it's different than the one i attached to the other bugs [23:35:42] Oh! That would explain it [23:35:59] I'm bad at following directions [23:36:08] hope it does ... [23:36:51] Still no dice though [23:37:23] dan-nl: The notice is supposed to show up on the page, right? [23:38:15] yes [23:38:27] Well, dunno then [23:39:14] hmm, so you went to the preview [23:39:23] Yup [23:39:34] and then clicked on one of the resulting files [23:39:38] Correct [23:40:14] oh well, if you look at the patch you'll see only two corrections [23:40:26] 3VisualEditor / 3Data Model: VisualEditor: [Regression] Can't remove annotation - 10https://bugzilla.wikimedia.org/64244 (10Gerrit Notification Bot) 5ASS>3PAT [23:40:27] 3VisualEditor / 3Data Model: VisualEditor: [Regression] Can't remove annotation - 10https://bugzilla.wikimedia.org/64244#c1 (10Gerrit Notification Bot) Change 129074 had a related patch set uploaded by Esanders: Look for comparable annotations when toggling https://gerrit.wikimedia.org/r/129074 [23:40:32] Yeah, I was about to say. [23:40:42] would you be okay with approving it just based on that? [23:40:46] (03CR) 10MarkTraceur: "Couldn't repro, but whatever, trivial." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/127211 (owner: 10Dan-nl) [23:40:52] (03CR) 10MarkTraceur: [C: 032] "Leeroy" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/127211 (owner: 10Dan-nl) [23:41:09] (03Merged) 10jenkins-bot: fix MediawikiTemplate::getTitle() method [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/127211 (owner: 10Dan-nl) [23:41:09] Apparently yes. :) [23:41:12] thanks marktraceur [23:41:26] 3MediaWiki extensions / 3GWToolset: Notice: Undefined variable: file_extension_length - 10https://bugzilla.wikimedia.org/64086#c2 (10Gerrit Notification Bot) Change 127211 merged by jenkins-bot: fix MediawikiTemplate::getTitle() method https://gerrit.wikimedia.org/r/127211 [23:42:04] the last two patches may be of interest, but one i'd like jean fred to look at and the other you could approve, but it has a bit more background to it and no repro notes yet [23:42:13] 'kay [23:42:29] dan-nl: Why don't you ping me or gi11es when you have repro notes for it/them and we'll get 'round to them quick as we can [23:42:54] the one for jean fred https://gerrit.wikimedia.org/r/#/c/127839/ and the one i was hoping bawolff would finish off https://gerrit.wikimedia.org/r/#/c/124347/ [23:43:07] k, thanks for the one you did approve! [23:43:18] My pleasure :) [23:43:34] (three) [23:43:36] (but still) [23:43:54] sorry, i meant the one_s_ [23:43:59] ;) [23:44:23] Heh [23:47:38] going to get some shut-eye. thanks again marktraceur [23:49:12] Night! [23:50:56] 3VisualEditor / 3MediaWiki integration: VisualEditor: Globally-blocked logged-out users are not blocked from using VE (just from saving); should instead show the relevant global block message - 10https://bugzilla.wikimedia.org/53009#c4 (10Alex Monk) 5PAT>3RES/FIX As with the normal local block bug, I'm g... [23:56:08] ^d: Do you have the ultimate cosmic power to import git history from another repository into gerrit? [23:56:16] I think the repo I want already exists but is missing commits. [23:56:44] 3VisualEditor / 3Mobile: VisualEditor Mobile: "Uncaught TypeError: Object # has no method 'saveDocument' " appears while trying to save a page which was idle for while - 10https://bugzilla.wikimedia.org/64267 (10ryasmeen ) 3NEW p:3Unprio s:3normal a:3None Created attachment... [23:56:58] https://gerrit.wikimedia.org/r/#/admin/projects/analytics/multimedia yup it exists [23:57:27] 3VisualEditor / 3Mobile: VisualEditor Mobile: "Uncaught TypeError: Object # has no method 'saveDocument' " appears while trying to save a page which was idle for a while - 10https://bugzilla.wikimedia.org/64267 (10ryasmeen )