[00:12:30] (03PS1) 10Aaron Schulz: thumb.php and img_auth.php cleanups [core] - 10https://gerrit.wikimedia.org/r/127589 [00:25:46] (03PS25) 10Legoktm: Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 [00:29:30] (03CR) 10Legoktm: "PS25 fixes the UserLoadFromSession hook to make it work with both $wgCentralAuthCookies enabled and disabled." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (owner: 10Legoktm) [00:52:11] (03PS2) 10Yurik: Set proper SSH URL for all GIT repos [vagrant] - 10https://gerrit.wikimedia.org/r/123830 [01:14:56] (03PS3) 10Yurik: Set proper SSH URL for all GIT repos (with username) [vagrant] - 10https://gerrit.wikimedia.org/r/123830 [01:59:09] (03PS4) 10Yurik: Set proper SSH URL for all GIT repos (with username) [vagrant] - 10https://gerrit.wikimedia.org/r/123830 [02:37:19] (03PS1) 10Gnosygnu: v1.4.3.1 [xowa] - 10https://gerrit.wikimedia.org/r/127591 [02:48:37] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/127591 (owner: 10Gnosygnu) [03:19:59] (03PS1) 10TTO: Allow local interwiki links with an empty title part [core] - 10https://gerrit.wikimedia.org/r/127592 [03:20:36] (03PS2) 10TTO: Allow local interwiki links with an empty title part [core] - 10https://gerrit.wikimedia.org/r/127592 [03:25:26] (03PS1) 10Mattflaschen: Implement new, rewritten logging for GuidedTour [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/127593 [03:25:53] (03CR) 10jenkins-bot: [V: 04-1] Implement new, rewritten logging for GuidedTour [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/127593 (owner: 10Mattflaschen) [03:50:41] (03PS2) 10Mattflaschen: Implement new, rewritten logging for GuidedTour [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/127593 [03:51:05] (03CR) 10jenkins-bot: [V: 04-1] Implement new, rewritten logging for GuidedTour [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/127593 (owner: 10Mattflaschen) [03:54:37] (03PS3) 10Mattflaschen: Implement new, rewritten logging for GuidedTour [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/127593 [03:54:58] (03CR) 10jenkins-bot: [V: 04-1] Implement new, rewritten logging for GuidedTour [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/127593 (owner: 10Mattflaschen) [03:59:27] (03CR) 10Mattflaschen: [C: 04-1] "There are some pending questions, which need to be resolved, on the Trello card (hence the self -1)." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/127593 (owner: 10Mattflaschen) [04:00:47] (03CR) 10Mattflaschen: "Logging is at https://gerrit.wikimedia.org/r/#/c/127593/" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [04:02:19] (03PS4) 10Mattflaschen: Implement new, rewritten logging for GuidedTour [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/127593 [04:02:41] (03CR) 10jenkins-bot: [V: 04-1] Implement new, rewritten logging for GuidedTour [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/127593 (owner: 10Mattflaschen) [05:09:51] (03PS1) 10Jjanes: PostgreSQL: Improve speed for page edit in imports [core] - 10https://gerrit.wikimedia.org/r/127594 [05:21:39] (03Draft2) 10Prtksxna: Add logUnlessTimeout function [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/116260 [06:26:26] (03CR) 10Legoktm: [C: 04-1] "Account creation attempts from the API's action=createaccount are not being logged properly for some reason. I haven't been able to figure" (031 comment) [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader) [06:31:54] (03CR) 10Legoktm: "Same issue with API + action=move. Not sure what's going on..." [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader) [06:39:48] (03CR) 10Legoktm: "I wonder if I8f1da51187b281fe4afc0d5a0c49f5caf3612e92 is related." [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader) [06:57:13] (03PS4) 10Divec: DONT MERGE: Proof-of-concept linear segmenter [services/cxserver] - 10https://gerrit.wikimedia.org/r/124287 [06:57:37] (03CR) 10jenkins-bot: [V: 04-1] DONT MERGE: Proof-of-concept linear segmenter [services/cxserver] - 10https://gerrit.wikimedia.org/r/124287 (owner: 10Divec) [07:07:51] (03PS1) 10Ori.livneh: Drop -{webkit,moz}-box-shadow [core] - 10https://gerrit.wikimedia.org/r/127597 [07:15:08] hi prtksxna [07:20:48] (03CR) 10TheDJ: Use ResourceLoader modules for style loading (031 comment) [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/126843 (owner: 10Bartosz Dziewoński) [07:23:14] (03CR) 10Daniel Friesen: "Pre-ICS Android still accounts for around 1.97% of traffic. There are lots of cheap old phones still in use running Gingerbread." [core] - 10https://gerrit.wikimedia.org/r/127597 (owner: 10Ori.livneh) [07:23:51] (03CR) 10Nuria: "I understand what the code is doing but not the use case, in what cases would we want to use this 'delay' code and made the UI slower?" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/116260 (owner: 10Prtksxna) [07:38:47] (03PS1) 10Divec: Further segmentation tests [services/cxserver] - 10https://gerrit.wikimedia.org/r/127598 [07:39:12] (03CR) 10jenkins-bot: [V: 04-1] Further segmentation tests [services/cxserver] - 10https://gerrit.wikimedia.org/r/127598 (owner: 10Divec) [08:12:20] (03CR) 10Yuvipanda: [C: 032] Break ternary operations into multiple lines [extensions/Popups] - 10https://gerrit.wikimedia.org/r/124852 (owner: 10Prtksxna) [08:12:37] (03CR) 10Yuvipanda: [C: 032] Stop checking for SVG support on every hover [extensions/Popups] - 10https://gerrit.wikimedia.org/r/124851 (owner: 10Prtksxna) [08:12:43] (03Merged) 10jenkins-bot: Stop checking for SVG support on every hover [extensions/Popups] - 10https://gerrit.wikimedia.org/r/124851 (owner: 10Prtksxna) [08:12:46] (03Merged) 10jenkins-bot: Break ternary operations into multiple lines [extensions/Popups] - 10https://gerrit.wikimedia.org/r/124852 (owner: 10Prtksxna) [08:13:36] (03CR) 10Yuvipanda: [C: 032] Remove confusing variable name [extensions/Popups] - 10https://gerrit.wikimedia.org/r/124853 (owner: 10Prtksxna) [08:13:53] (03Merged) 10jenkins-bot: Remove confusing variable name [extensions/Popups] - 10https://gerrit.wikimedia.org/r/124853 (owner: 10Prtksxna) [08:13:55] (03CR) 10Yuvipanda: [C: 032] Update documentation for the createThumbnail method [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125089 (owner: 10Prtksxna) [08:14:01] (03Merged) 10jenkins-bot: Update documentation for the createThumbnail method [extensions/Popups] - 10https://gerrit.wikimedia.org/r/125089 (owner: 10Prtksxna) [08:14:46] (03CR) 10Yuvipanda: [C: 032] Remove viewBox from SVG, not needed. [extensions/Popups] - 10https://gerrit.wikimedia.org/r/124296 (owner: 10Prtksxna) [08:14:48] (03CR) 10jenkins-bot: [V: 04-1] Remove viewBox from SVG, not needed. [extensions/Popups] - 10https://gerrit.wikimedia.org/r/124296 (owner: 10Prtksxna) [08:15:14] prtksxna: moar rebasing needed. [08:15:30] prtksxna: also I think fixing code quality issues in this thing is a bad idea. needs refactor [08:15:44] yaman [08:15:50] saw my email no :( [08:15:54] prtksxna: ya! [08:15:56] prtksxna: still in Jaipur [08:16:00] kk [08:16:07] prtksxna: and trying to stay off comp more. :( [08:16:22] prtksxna: but ya, if you keep spending time on small things you won't have time for the refactor [08:16:32] ama [08:17:00] but they seem to have "priority" [08:17:17] prtksxna: *shrug*. You should be part of the group setting priority too. [08:17:34] inoinoiamiam [08:17:36] but [08:17:46] We'll talk and I'll ask [08:17:53] kk [08:17:55] I've flight in a while [08:18:03] should leave by 2:30 [08:18:04] kk [08:18:20] naalle? [08:19:26] YuviPanda: tomorrow we talk? [08:19:33] prtksxna: hmm, ok! [08:19:39] (y) [08:24:02] Not doing the refactor already is making me very uncomfortable, I hope to be done with it this week [08:29:47] (03CR) 10Prtksxna: "https://www.mediawiki.org/wiki/Extension:EventLogging/Programming#Logging_clicks_on_links is the use case I had in mind." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/116260 (owner: 10Prtksxna) [08:44:43] (03CR) 10Nemo bis: "Fantastic to see improvements for import! I've added a few reviewers. If possible, please also document your import experience on wiki: ht" [core] - 10https://gerrit.wikimedia.org/r/127594 (owner: 10Jjanes) [08:46:44] (03PS5) 10Nemo bis: DON'T MERGE: Proof-of-concept linear segmenter [services/cxserver] - 10https://gerrit.wikimedia.org/r/124287 (owner: 10Divec) [08:47:06] (03CR) 10jenkins-bot: [V: 04-1] DON'T MERGE: Proof-of-concept linear segmenter [services/cxserver] - 10https://gerrit.wikimedia.org/r/124287 (owner: 10Divec) [09:25:07] (03CR) 10Siebrand: "Looks like 61639 should be resolved before we can make jslint voting." [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader) [09:27:18] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader) [09:29:09] (03PS1) 10Physikerwelt: Add default value for user option mathJax [extensions/Math] - 10https://gerrit.wikimedia.org/r/127607 [09:29:22] (03PS14) 10Physikerwelt: Add separate database table for LaTeXML [extensions/Math] - 10https://gerrit.wikimedia.org/r/124805 [09:30:14] (03PS2) 10Physikerwelt: Add default value for user option mathJax [extensions/Math] - 10https://gerrit.wikimedia.org/r/127607 [09:30:21] (03PS1) 10Siebrand: Make includes/title pass phpcs-strict [core] - 10https://gerrit.wikimedia.org/r/127608 [09:31:59] (03PS1) 10Siebrand: Update formatting of includes/title/ [core] - 10https://gerrit.wikimedia.org/r/127609 [09:32:32] (03PS2) 10Siebrand: Update formatting of includes/title/ [core] - 10https://gerrit.wikimedia.org/r/127609 [09:36:51] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (owner: 10Legoktm) [09:39:31] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/127480 (owner: 10Alex Monk) [09:58:23] (03CR) 10Nuria: Add logUnlessTimeout function (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/116260 (owner: 10Prtksxna) [10:22:13] (03CR) 10Prtksxna: Add logUnlessTimeout function (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/116260 (owner: 10Prtksxna) [10:24:31] (03PS2) 10Prtksxna: Remove viewBox from SVG, not needed. [extensions/Popups] - 10https://gerrit.wikimedia.org/r/124296 [10:25:25] (03CR) 10Prtksxna: "Yuvi, could you please +2 this again?" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/124296 (owner: 10Prtksxna) [10:48:14] (03CR) 10Nuria: Add logUnlessTimeout function (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/116260 (owner: 10Prtksxna) [10:52:10] (03CR) 10Prtksxna: Add logUnlessTimeout function (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/116260 (owner: 10Prtksxna) [11:15:38] (03PS1) 10Prtksxna: Ignore `internal` class for links [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127616 [11:30:56] (03CR) 10Nuria: Add logUnlessTimeout function (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/116260 (owner: 10Prtksxna) [11:38:01] (03PS1) 10Reedy: Fix Fatal error: Call to a member function doTransform() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/127617 [11:38:44] (03PS1) 10Reedy: Fix Fatal error: Call to a member function doTransform() [extensions/TimedMediaHandler] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127618 [11:39:55] (03PS1) 10Reedy: Fix Fatal error: Call to a member function doTransform() [extensions/TimedMediaHandler] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127619 [11:40:13] (03CR) 10Reedy: [C: 032] Fix Fatal error: Call to a member function doTransform() [extensions/TimedMediaHandler] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127618 (owner: 10Reedy) [11:40:20] (03Merged) 10jenkins-bot: Fix Fatal error: Call to a member function doTransform() [extensions/TimedMediaHandler] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127618 (owner: 10Reedy) [11:43:13] (03PS1) 10Reedy: Update TMH to HEAD of wmf/1.23wmf22 branch [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127621 [11:43:24] (03CR) 10Reedy: [C: 032 V: 032] Update TMH to HEAD of wmf/1.23wmf22 branch [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127621 (owner: 10Reedy) [11:45:25] (03CR) 10Reedy: [C: 032] Fix Fatal error: Call to a member function doTransform() [extensions/TimedMediaHandler] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127619 (owner: 10Reedy) [11:45:53] (03Merged) 10jenkins-bot: Fix Fatal error: Call to a member function doTransform() [extensions/TimedMediaHandler] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127619 (owner: 10Reedy) [11:49:21] (03PS1) 10Reedy: Update TMH to HEAD of wmf/1.24wmf1 branch [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127622 [11:51:03] (03CR) 10Reedy: [C: 032 V: 032] Update TMH to HEAD of wmf/1.24wmf1 branch [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127622 (owner: 10Reedy) [12:05:17] (03PS1) 10Gerrit Patch Uploader: Add clear:both to patrollink [core] - 10https://gerrit.wikimedia.org/r/127624 [12:05:22] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/127624 (owner: 10Gerrit Patch Uploader) [12:36:23] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Sorry, but having pop-up windows (the title tooltips) inside of pop-up windows should be avoided. Depending on the browser this can cause " [core] - 10https://gerrit.wikimedia.org/r/127358 (owner: 10Bartosz Dziewoński) [12:36:56] (03CR) 10Krinkle: Allow for global renaming of users (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (owner: 10Legoktm) [12:41:28] (03CR) 10TheDJ: "I my opinion, this solves the wrong problem. The problem here is that the wikidata page is in content blocks that are floated, and there i" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/127624 (owner: 10Gerrit Patch Uploader) [12:58:57] (03CR) 10Yaron Koren: "CSteipp - okay, sorry for the delay, I just submitted a bug report for this here:" [extensions/HTMLTags] - 10https://gerrit.wikimedia.org/r/124995 (owner: 10Yaron Koren) [14:02:40] (03PS2) 10Gerrit Patch Uploader: Clear floating elements from content [core] - 10https://gerrit.wikimedia.org/r/127624 [14:02:42] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/127624 (owner: 10Gerrit Patch Uploader) [14:09:16] (03PS1) 10Manybubbles: Limit number of fragments scored if possible [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127629 [14:16:06] (03PS1) 10Chad: Updating PagedTiffHandler to master [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127630 [14:41:43] (03CR) 10Krinkle: [C: 032] Make includes/title pass phpcs-strict [core] - 10https://gerrit.wikimedia.org/r/127608 (owner: 10Siebrand) [14:44:33] (03Merged) 10jenkins-bot: Make includes/title pass phpcs-strict [core] - 10https://gerrit.wikimedia.org/r/127608 (owner: 10Siebrand) [15:09:13] mark bergsma [15:16:07] circeberman: The scuttlebutt is that he's off today, what's up? [15:27:14] (03PS2) 10Matthias Mullie: [WIP] search [extensions/Flow] - 10https://gerrit.wikimedia.org/r/126996 [15:33:27] (03PS7) 10Phuedx: [WIP] Add a pre-edit anonymous signup invitation [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125730 [15:36:34] greg-g: ping? [15:37:27] hexmode: heya [15:37:33] I'm on the hangout [15:38:02] I can't get in? and Markus says he is the only one there? [15:38:16] fucking hangouts [15:38:56] markus is in [15:39:09] one more try [15:51:30] (03PS1) 10Physikerwelt: Improvements to CalculateDistances [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/127634 [15:53:24] (03CR) 10Physikerwelt: [C: 032] Improvements to CalculateDistances [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/127634 (owner: 10Physikerwelt) [16:04:21] (03CR) 10Jforrester: "@Ori:" [core] - 10https://gerrit.wikimedia.org/r/123782 (owner: 10Jforrester) [16:05:53] (03PS1) 10Chad: Make file rendering failure limits configurable [core] - 10https://gerrit.wikimedia.org/r/127637 [16:14:56] (03PS1) 10Manybubbles: Remove debugging log [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127639 [16:17:35] (03CR) 10BryanDavis: Make file rendering failure limits configurable (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127637 (owner: 10Chad) [16:17:50] (03CR) 10Aaron Schulz: [C: 04-1] "This assumes the work expended it proportional to the source size which is not true for Range request based thumbnail generation." [core] - 10https://gerrit.wikimedia.org/r/127637 (owner: 10Chad) [16:18:03] (03CR) 10Chad: [C: 032] Support tighter rate limiting for "non-standard" thumbnails [core] - 10https://gerrit.wikimedia.org/r/126052 (owner: 10Aaron Schulz) [16:21:06] (03Merged) 10jenkins-bot: Support tighter rate limiting for "non-standard" thumbnails [core] - 10https://gerrit.wikimedia.org/r/126052 (owner: 10Aaron Schulz) [16:23:11] (03CR) 10Chad: Make file rendering failure limits configurable (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127637 (owner: 10Chad) [16:23:38] (03PS2) 10Siebrand: Update documentation for $wgExtensionMessagesFiles [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127223 [16:23:40] (03PS2) 10Siebrand: Skip loading PHP shims for JSON i18n files [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127020 [16:24:15] (03CR) 10Siebrand: "What needs to be done here for this to be merged?" [core] - 10https://gerrit.wikimedia.org/r/125706 (owner: 10PleaseStand) [16:27:17] (03PS1) 10Aaron Schulz: Call wfThumbIncrAttemptFailures() in thumb.php on fatals [core] - 10https://gerrit.wikimedia.org/r/127642 [16:27:29] (03CR) 10Siebrand: "Additionally, this needs to be backported, I will to push the shim changes to extensions that have a REL1_23 branch." [core] - 10https://gerrit.wikimedia.org/r/125706 (owner: 10PleaseStand) [16:28:20] ^d: ^ [16:30:55] <^d> Clever [16:31:27] (03CR) 10Chad: [C: 032] Call wfThumbIncrAttemptFailures() in thumb.php on fatals [core] - 10https://gerrit.wikimedia.org/r/127642 (owner: 10Aaron Schulz) [16:32:40] (03CR) 10Siebrand: [WIP] Add a pre-edit anonymous signup invitation (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125730 (owner: 10Phuedx) [16:33:18] (03CR) 10Phuedx: [WIP] Add a pre-edit anonymous signup invitation (035 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125730 (owner: 10Phuedx) [16:33:27] (03CR) 10Phuedx: [WIP] Add a pre-edit anonymous signup invitation (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125730 (owner: 10Phuedx) [16:33:49] siebrand: i forgot to publish that comment ^ [16:33:53] thanks for reminding me! [16:34:30] (03Merged) 10jenkins-bot: Call wfThumbIncrAttemptFailures() in thumb.php on fatals [core] - 10https://gerrit.wikimedia.org/r/127642 (owner: 10Aaron Schulz) [16:39:10] phuedx: np. I'm persistent. [16:39:19] (03CR) 10Aaron Schulz: "Also note that the things that download huge source files use PoolCounter now and only let in 2 at a time, so that limit will already cove" [core] - 10https://gerrit.wikimedia.org/r/127637 (owner: 10Chad) [16:40:32] (03Abandoned) 10Chad: Make file rendering failure limits configurable [core] - 10https://gerrit.wikimedia.org/r/127637 (owner: 10Chad) [16:43:09] (03CR) 10Siebrand: [WIP] Add a pre-edit anonymous signup invitation (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125730 (owner: 10Phuedx) [16:43:37] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125730 (owner: 10Phuedx) [16:43:40] (03PS1) 10Manybubbles: Add created and caused timestamp to jobs [core] - 10https://gerrit.wikimedia.org/r/127647 [16:44:29] (03PS2) 10Manybubbles: Add created and caused timestamp to jobs [core] - 10https://gerrit.wikimedia.org/r/127647 [16:45:50] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/127442 (owner: 10Jackmcbarn) [16:46:10] (03CR) 10Manybubbles: "This is more a proof of concept then anything, but it would open up some nice monitoring." [core] - 10https://gerrit.wikimedia.org/r/127647 (owner: 10Manybubbles) [16:47:00] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Persona] - 10https://gerrit.wikimedia.org/r/124129 (owner: 10Stepzhou) [16:47:53] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/127464 (owner: 10Legoktm) [16:48:09] (03PS3) 10Manybubbles: Add create and cause timestamp to jobs [core] - 10https://gerrit.wikimedia.org/r/127647 [16:50:36] (03CR) 10Siebrand: "In theory there's nothing wrong with this change from an i18n/L10n perspective. I do wonder if the change is efficient. We're deprecating " [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/127484 (owner: 10Alex Monk) [16:51:18] (03CR) 10Chad: [C: 032] Avoid image table updates on file upload failure [core] - 10https://gerrit.wikimedia.org/r/127326 (owner: 10Aaron Schulz) [16:54:21] (03Merged) 10jenkins-bot: Avoid image table updates on file upload failure [core] - 10https://gerrit.wikimedia.org/r/127326 (owner: 10Aaron Schulz) [16:54:44] (03PS1) 10Aaron Schulz: Call wfThumbIncrAttemptFailures() in thumb.php on fatals [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127648 [16:54:58] (03PS1) 10Aaron Schulz: Call wfThumbIncrAttemptFailures() in thumb.php on fatals [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127649 [16:55:22] (03CR) 10Aaron Schulz: [C: 032] Call wfThumbIncrAttemptFailures() in thumb.php on fatals [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127648 (owner: 10Aaron Schulz) [16:55:27] (03CR) 10Aaron Schulz: [C: 032] Call wfThumbIncrAttemptFailures() in thumb.php on fatals [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127649 (owner: 10Aaron Schulz) [16:55:54] (03PS2) 10Ragesoss: Add namespace aliases and a special page alias in Swedish [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/123365 [16:57:20] (03CR) 10jenkins-bot: [V: 04-1] Add namespace aliases and a special page alias in Swedish [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/123365 (owner: 10Ragesoss) [16:59:03] (03PS8) 10Phuedx: [WIP] Add a pre-edit anonymous signup invitation [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125730 [16:59:22] (03Abandoned) 10Chad: Updating PagedTiffHandler to master [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127630 (owner: 10Chad) [17:00:32] (03CR) 10Chad: [C: 032] Limit number of fragments scored if possible [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127629 (owner: 10Manybubbles) [17:00:41] (03Merged) 10jenkins-bot: Limit number of fragments scored if possible [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127629 (owner: 10Manybubbles) [17:00:46] (03CR) 10Chad: [C: 032] Remove debugging log [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127639 (owner: 10Manybubbles) [17:00:54] (03Merged) 10jenkins-bot: Remove debugging log [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127639 (owner: 10Manybubbles) [17:01:17] (03Merged) 10jenkins-bot: Call wfThumbIncrAttemptFailures() in thumb.php on fatals [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127648 (owner: 10Aaron Schulz) [17:02:12] (03Merged) 10jenkins-bot: Call wfThumbIncrAttemptFailures() in thumb.php on fatals [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127649 (owner: 10Aaron Schulz) [17:02:21] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/125730 (owner: 10Phuedx) [17:03:41] (03PS1) 10Aaron Schulz: Avoid image table updates on file upload failure [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127650 [17:03:51] (03PS1) 10Aaron Schulz: Avoid image table updates on file upload failure [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127652 [17:04:10] (03CR) 10Chad: [C: 032] Update formatting of includes/title/ [core] - 10https://gerrit.wikimedia.org/r/127609 (owner: 10Siebrand) [17:05:01] (03CR) 10Chad: [C: 032] Avoid image table updates on file upload failure [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127652 (owner: 10Aaron Schulz) [17:05:08] (03CR) 10Chad: [C: 032] Avoid image table updates on file upload failure [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127650 (owner: 10Aaron Schulz) [17:06:02] (03CR) 10Chad: [C: 032] Bail out on FileBackend operations if the initial stat calls failed [core] - 10https://gerrit.wikimedia.org/r/127283 (owner: 10Aaron Schulz) [17:08:54] (03CR) 10Chad: [C: 032] Make room for preloadFileStat() call in FileBackend::doOperationsInternal [core] - 10https://gerrit.wikimedia.org/r/127386 (owner: 10Aaron Schulz) [17:09:14] (03PS1) 10Ragesoss: Add namespace aliases and a special page alias in Swedish [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/127653 [17:09:32] (03Abandoned) 10Ragesoss: Add namespace aliases and a special page alias in Swedish [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/123365 (owner: 10Ragesoss) [17:09:36] (03CR) 10jenkins-bot: [V: 04-1] Add namespace aliases and a special page alias in Swedish [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/127653 (owner: 10Ragesoss) [17:11:41] (03Merged) 10jenkins-bot: Update formatting of includes/title/ [core] - 10https://gerrit.wikimedia.org/r/127609 (owner: 10Siebrand) [17:11:43] (03CR) 10jenkins-bot: [V: 04-1] Avoid image table updates on file upload failure [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127652 (owner: 10Aaron Schulz) [17:11:45] (03Merged) 10jenkins-bot: Avoid image table updates on file upload failure [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127650 (owner: 10Aaron Schulz) [17:12:25] (03PS2) 10Ragesoss: Add namespace aliases and a special page alias in Swedish [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/127653 [17:13:34] (03Merged) 10jenkins-bot: Bail out on FileBackend operations if the initial stat calls failed [core] - 10https://gerrit.wikimedia.org/r/127283 (owner: 10Aaron Schulz) [17:13:36] (03Merged) 10jenkins-bot: Make room for preloadFileStat() call in FileBackend::doOperationsInternal [core] - 10https://gerrit.wikimedia.org/r/127386 (owner: 10Aaron Schulz) [17:14:33] (03CR) 10Chad: [C: 031] "Will let Chris weigh in first." [core] - 10https://gerrit.wikimedia.org/r/127589 (owner: 10Aaron Schulz) [17:16:38] (03PS3) 10Ragesoss: Remove student profiles special page and everything that links there [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121107 [17:20:37] (03CR) 10Aaron Schulz: [C: 032] Avoid image table updates on file upload failure [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127652 (owner: 10Aaron Schulz) [17:23:23] (03Merged) 10jenkins-bot: Avoid image table updates on file upload failure [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127652 (owner: 10Aaron Schulz) [17:24:08] (03PS1) 10Siebrand: Remove underscore from classes CLDRPluralRule* [core] - 10https://gerrit.wikimedia.org/r/127657 [17:25:22] (03CR) 10AndyRussG: [C: 032] Add namespace aliases and a special page alias in Swedish [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/127653 (owner: 10Ragesoss) [17:25:30] (03Merged) 10jenkins-bot: Add namespace aliases and a special page alias in Swedish [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/127653 (owner: 10Ragesoss) [17:26:17] (03CR) 10CSteipp: [C: 031] "The theory on these changes all look good. I don't think this will open up any undesirable issues." [core] - 10https://gerrit.wikimedia.org/r/127589 (owner: 10Aaron Schulz) [17:29:15] (03PS4) 10Ragesoss: Remove student profile and all links to it [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121107 [17:37:24] (03PS1) 10Aaron Schulz: Include pool type in pool counter log entries [core] - 10https://gerrit.wikimedia.org/r/127660 [17:40:56] (03CR) 10Chad: [C: 032] thumb.php and img_auth.php cleanups [core] - 10https://gerrit.wikimedia.org/r/127589 (owner: 10Aaron Schulz) [17:48:32] (03PS1) 10Siebrand: Update formatting for languages/utils/ [core] - 10https://gerrit.wikimedia.org/r/127662 [17:50:31] (03CR) 10Adamw: "responded to caching question" (031 comment) [extensions/Petition] - 10https://gerrit.wikimedia.org/r/126011 (owner: 10Pcoombe) [17:50:33] (03Merged) 10jenkins-bot: thumb.php and img_auth.php cleanups [core] - 10https://gerrit.wikimedia.org/r/127589 (owner: 10Aaron Schulz) [17:50:46] (03CR) 10saper: "Abandoning change per inforamation in bug 53008" [core] - 10https://gerrit.wikimedia.org/r/92254 (owner: 10saper) [17:51:21] (03Abandoned) 10saper: Don't expose blocked IP address in error message [core] - 10https://gerrit.wikimedia.org/r/92254 (owner: 10saper) [17:53:01] (03PS1) 10Umherirrender: Fixed some @params documentation (includes/parser) [core] - 10https://gerrit.wikimedia.org/r/127663 [17:55:01] (03PS3) 10Aaron Schulz: More Profiler class refactoring [core] - 10https://gerrit.wikimedia.org/r/125895 [17:55:44] (03CR) 10Chad: [C: 032] PostgreSQL: Improve speed for page edit in imports [core] - 10https://gerrit.wikimedia.org/r/127594 (owner: 10Jjanes) [17:56:48] (03CR) 10Chad: [C: 032] Remove underscore from classes CLDRPluralRule* [core] - 10https://gerrit.wikimedia.org/r/127657 (owner: 10Siebrand) [17:56:49] AaronSchulz: heya [17:56:53] (I'm back) [17:56:59] I reopened that bz :) [17:57:13] thanks for the help though [17:57:14] (03CR) 10Siebrand: [C: 032] Fix display of reason on local account block status [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/127484 (owner: 10Alex Monk) [17:57:21] (03CR) 10Chad: [C: 032] Update formatting for languages/utils/ [core] - 10https://gerrit.wikimedia.org/r/127662 (owner: 10Siebrand) [17:57:38] (03Merged) 10jenkins-bot: Fix display of reason on local account block status [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/127484 (owner: 10Alex Monk) [17:57:56] (03CR) 10Ori.livneh: [C: 032] More Profiler class refactoring [core] - 10https://gerrit.wikimedia.org/r/125895 (owner: 10Aaron Schulz) [17:58:54] ori: I forgot to say that was just a rebase...I guess you divined that [17:59:47] (03Merged) 10jenkins-bot: PostgreSQL: Improve speed for page edit in imports [core] - 10https://gerrit.wikimedia.org/r/127594 (owner: 10Jjanes) [17:59:56] paravoid: sometimes thumbails are just to big to render, which is size-dependent...maybe their could be a per-source limit...it would need some thought though [18:00:19] right [18:00:28] the limit was mostly for benign requests rather that DOS style ones (that's what the other pingLimiter() stuff is for) [18:00:44] (03Merged) 10jenkins-bot: Remove underscore from classes CLDRPluralRule* [core] - 10https://gerrit.wikimedia.org/r/127657 (owner: 10Siebrand) [18:00:49] ^d: thanks for speedy merge of newbie's first patch :) https://gerrit.wikimedia.org/r/#/c/127594/ [18:00:58] nod; but it wouldn't be enough for today's issues though [18:01:01] (03Merged) 10jenkins-bot: Update formatting for languages/utils/ [core] - 10https://gerrit.wikimedia.org/r/127662 (owner: 10Siebrand) [18:01:02] so the /tmp problem is with OOM/fatals that leave temp files around [18:01:04] it's nice when we show our best face to newbies ;) [18:01:06] <^d> Nemo_bis: yw. Easy patch :) [18:01:08] ? [18:01:13] :) [18:01:23] <^d> And mostly-unloved area of code that won't touch production :p [18:01:28] different sizes requested for different images [18:01:32] * AaronSchulz could probably make TempFSFile a bit more robust with a static shutdown method [18:02:09] (03Merged) 10jenkins-bot: More Profiler class refactoring [core] - 10https://gerrit.wikimedia.org/r/125895 (owner: 10Aaron Schulz) [18:02:12] and I don't care about leftover /tmp files; I just used that as an example of attempts to render the same thumb for as long as I've been here [18:02:17] the DNA Helix specifically [18:02:40] I remember investigating over a dozen imagescaler outages and finding a DNA Helix in /tmp :) [18:02:53] it's sad and hilarious at the same time [18:02:54] (03PS16) 10EBernhardson: First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 [18:03:14] paravoid: what is the File: link for that? [18:03:40] I think https://commons.wikimedia.org/wiki/File:A-DNA_orbit_animated.gif [18:04:12] at one point I rendered one of the popular thumbnails by hand and uploaded it to swift [18:04:17] because I was tired of seeing it [18:04:38] hm, maybe https://commons.wikimedia.org/wiki/File:DNA_orbit_animated.gif instead [18:06:24] seems to work now [18:06:39] (03CR) 10Krinkle: [C: 04-1] "Don't add position top though. That's inconsistent and not justified." (031 comment) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/127461 (owner: 10Legoktm) [18:06:50] (03PS1) 10Bsitu: Do not escape html text of moderated content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127666 [18:07:09] (03PS2) 10Ori.livneh: Save current title as 'title' attribute [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/113545 [18:09:19] (03CR) 10Krinkle: Use quotes to prevent globbing and word splitting (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127423 (owner: 10KartikMistry) [18:09:22] (03CR) 10EBernhardson: [C: 04-1] "The Templating::getContent method says it only returns html, could we instead adjust it so that it really is outputting only html and we " (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127666 (owner: 10Bsitu) [18:10:13] (03CR) 10Krinkle: Use quotes to prevent globbing and word splitting (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127423 (owner: 10KartikMistry) [18:10:43] (03CR) 10Krinkle: "Makes sense, though in cases where it was embedding within a longer string, this doesn't work as you think I think." [core] - 10https://gerrit.wikimedia.org/r/127423 (owner: 10KartikMistry) [18:11:42] (03CR) 10Krinkle: Use quotes to prevent globbing and word splitting (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127423 (owner: 10KartikMistry) [18:12:00] (03CR) 10jenkins-bot: [V: 04-1] First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 (owner: 10EBernhardson) [18:12:50] (03CR) 10AndyRussG: [C: 032] Remove student profile and all links to it [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121107 (owner: 10Ragesoss) [18:13:54] (03CR) 10jenkins-bot: [V: 04-1] Save current title as 'title' attribute [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/113545 (owner: 10Ori.livneh) [18:14:06] (03Merged) 10jenkins-bot: Remove student profile and all links to it [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121107 (owner: 10Ragesoss) [18:15:35] (03CR) 10Bsitu: "Yes, that's better. Templating::getContent() is supposed to output ready-to-display content" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127666 (owner: 10Bsitu) [18:16:37] (03PS1) 10Ori.livneh: Tidy ext.eventLogging.{subscriber.js,core.js,jsonSchema.css} [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/127667 [18:17:22] (03CR) 10Nemo bis: "Bug 62735, obviously" (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121107 (owner: 10Ragesoss) [18:18:04] (03CR) 10Ragesoss: "Eek! Thanks for the catch, Nemo." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121107 (owner: 10Ragesoss) [18:18:50] (03PS1) 10Aaron Schulz: Made TempFSFile try to purge files on fatals too [core] - 10https://gerrit.wikimedia.org/r/127669 [18:20:05] (03PS1) 10Aaron Schulz: Lowered limit for wfThumbIsAttemptThrottled() to 4 [core] - 10https://gerrit.wikimedia.org/r/127670 [18:24:06] YuviPanda: dear Yuvi, shall I continue bumping the yaml style patch for grrrit? [18:24:29] awight: there was a bug with confusion over what is a list and what is a dict the last time, right? [18:24:42] Yes, good catch. I think I fixed that. [18:24:44] (03CR) 10Chad: [C: 032] Lowered limit for wfThumbIsAttemptThrottled() to 4 [core] - 10https://gerrit.wikimedia.org/r/127670 (owner: 10Aaron Schulz) [18:24:49] awight: aha! I didn't notice. [18:24:58] I've been dumping the output in canonical form and it matches the original [18:25:05] coool! [18:25:49] O_o, the good news is that the patch is actually up to date! [18:26:03] awight: :D I am going to test git fetch https://gerrit.wikimedia.org/r/labs/tools/grrrit refs/changes/11/112311/5 && git checkout FETCH_HEAD now [18:26:13] (03PS1) 10FunPika: Add unblock link to block log entries in Special:RecentChanges [core] - 10https://gerrit.wikimedia.org/r/127671 [18:26:29] YuviPanda: rad, thanks [18:27:45] (03Merged) 10jenkins-bot: Lowered limit for wfThumbIsAttemptThrottled() to 4 [core] - 10https://gerrit.wikimedia.org/r/127670 (owner: 10Aaron Schulz) [18:32:21] Is it just me or http://fab.wmflabs.org/ exploded? [18:36:25] ^d are you updating http://fab.wmflabs.org ? [18:36:40] <^d> Yes. [18:36:45] <^d> Something was stuck in APC [18:36:47] <^d> Fixed now [18:39:25] Yep, it works. Thanks! [18:45:00] (03PS1) 10Siebrand: Make languages/classes pass phpcs-strict [core] - 10https://gerrit.wikimedia.org/r/127676 [18:45:02] (03PS1) 10Siebrand: Make languages/utils pass phpcs-strict [core] - 10https://gerrit.wikimedia.org/r/127677 [18:45:04] (03PS1) 10Siebrand: Make languages/ pass phpcs-strict [core] - 10https://gerrit.wikimedia.org/r/127678 [18:52:15] (03CR) 10Siebrand: "I think this has i18n issues with current translations." (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121107 (owner: 10Ragesoss) [18:57:24] (03PS17) 10EBernhardson: First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 [18:58:00] (03CR) 10Ragesoss: "Whoops, thanks Siebrand." (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121107 (owner: 10Ragesoss) [19:01:42] (03PS6) 10EBernhardson: UUID revamp [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123691 (owner: 10Matthias Mullie) [19:01:45] (03CR) 10jenkins-bot: [V: 04-1] UUID revamp [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123691 (owner: 10Matthias Mullie) [19:02:40] (03PS1) 10Reedy: Revert "Removed useless JobQueue return values" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127681 [19:03:44] (03PS2) 10Bsitu: Templating::getContent() should return safe-to-display content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127666 [19:04:00] (03PS1) 10Reedy: Removed useless JobQueue return values [core] - 10https://gerrit.wikimedia.org/r/127682 [19:04:29] (03CR) 10Reedy: [C: 04-1] "All callers need checking/cleaning up" [core] - 10https://gerrit.wikimedia.org/r/127682 (owner: 10Reedy) [19:07:21] (03CR) 10Aaron Schulz: [C: 032] Revert "Removed useless JobQueue return values" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127681 (owner: 10Reedy) [19:07:55] (03CR) 10EBernhardson: [C: 032] First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 (owner: 10EBernhardson) [19:08:19] (03Abandoned) 10Aaron Schulz: Removed useless JobQueue return values [core] - 10https://gerrit.wikimedia.org/r/127682 (owner: 10Reedy) [19:08:21] (03Merged) 10jenkins-bot: First stab at new template rendering in php [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/125358 (owner: 10EBernhardson) [19:09:14] (03PS1) 10Ragesoss: Change message key to avoid breaking translations [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/127684 [19:09:38] (03CR) 10Siebrand: [C: 04-1] Fixed some @params documentation (includes/parser) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127663 (owner: 10Umherirrender) [19:10:09] (03Merged) 10jenkins-bot: Revert "Removed useless JobQueue return values" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127681 (owner: 10Reedy) [19:10:39] (03CR) 10Ragesoss: "Siebrand, please review the follow-on patch: https://gerrit.wikimedia.org/r/#/c/127684/" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/121107 (owner: 10Ragesoss) [19:12:54] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/127684 (owner: 10Ragesoss) [19:13:24] (03CR) 10UltrasonicNXT: [C: 032 V: 032] "Yet again, thank you for this, sorry about letting these in there." [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/127203 (owner: 10Severin Anatoliy) [19:14:14] (03CR) 10UltrasonicNXT: [C: 032 V: 032] "Again, thank you, sorry for letting these bugs get in there." [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/127207 (owner: 10Severin Anatoliy) [19:14:50] (03PS2) 10Ragesoss: Change message key to avoid breaking translations [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/127684 [19:16:01] (03PS3) 10Ragesoss: Change message key to avoid breaking translations [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/127684 [19:17:49] (03CR) 10Siebrand: [C: 032] Change message key to avoid breaking translations [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/127684 (owner: 10Ragesoss) [19:17:56] (03Merged) 10jenkins-bot: Change message key to avoid breaking translations [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/127684 (owner: 10Ragesoss) [19:38:57] (03PS1) 10BryanDavis: Remove directory overrides for beta [tools/scap] - 10https://gerrit.wikimedia.org/r/127692 [19:40:01] (03CR) 10BryanDavis: [C: 032] Remove directory overrides for beta [tools/scap] - 10https://gerrit.wikimedia.org/r/127692 (owner: 10BryanDavis) [19:40:15] (03Merged) 10jenkins-bot: Remove directory overrides for beta [tools/scap] - 10https://gerrit.wikimedia.org/r/127692 (owner: 10BryanDavis) [19:42:14] csteipp: what is the security "advantage" of $wgImgAuthPublicTest? [19:42:14] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (d4baf57069) [core] - 10https://gerrit.wikimedia.org/r/127696 [19:43:13] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (d4baf57069) [core] - 10https://gerrit.wikimedia.org/r/127696 (owner: 10Jforrester) [19:46:08] AaronSchulz: No clue.. seems to just be about warning admins if they are using img_auth on a public wiki, right? [19:46:13] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (d4baf57069) [core] - 10https://gerrit.wikimedia.org/r/127696 (owner: 10Jforrester) [19:46:56] csteipp: could you make sense of the comment in DefaultSettings? [19:48:17] (03PS2) 10Bartosz Dziewoński: Expand the protocol for proto-relative links when printing [core] - 10https://gerrit.wikimedia.org/r/127345 [19:52:39] AaronSchulz: No, not sure what Tim meant by that [19:56:35] AaronSchulz: Maybe if you used a shared, public wiki to serve images for public and private wikis, that setting would let you point to img_auth for images from the private wiki, and the public image wiki won't complain about using img_auth on a public wiki? [19:58:00] (03PS1) 10Manybubbles: Improvements to near match resolution [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127700 [19:58:27] (03CR) 10Manybubbles: [C: 04-1] "-1 while I run tests locally." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127700 (owner: 10Manybubbles) [19:58:49] csteipp: it seems like the wgImgAuthPublicTest = false behavior should just always be there [19:59:10] and why lock it down for public wikis if thumb.php is still open anyway? [19:59:20] * AaronSchulz wants to kill that var [20:01:57] (03PS3) 10Bsitu: Templating::getContent() should return safe-to-display content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127666 [20:03:39] (03PS1) 10Aaron Schulz: Removed $wgImgAuthPublicTest [core] - 10https://gerrit.wikimedia.org/r/127701 [20:06:16] (03CR) 10Bsitu: Add topic/post summary diff view (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/121128 (owner: 10Bsitu) [20:07:22] (03CR) 10Bsitu: Add summarize/close/open topic to history/contribution (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123123 (owner: 10Bsitu) [20:22:04] (03CR) 10CSteipp: "Should we also bikeshed on the table name? I think we can reuse the table as is when we implement global username merging. Maybe "accountu" (033 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (owner: 10Legoktm) [20:25:38] (03PS1) 10Bsitu: Add permission checking to revision diff [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127766 [20:27:24] (03PS2) 10Bsitu: Add permission checking to revision diff [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127766 [20:34:53] (03PS4) 10Bsitu: Templating::getContent() should return safe-to-display content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127666 [20:44:25] (03CR) 10TheDJ: [C: 032] Expand the protocol for proto-relative links when printing [core] - 10https://gerrit.wikimedia.org/r/127345 (owner: 10Bartosz Dziewoński) [20:47:03] (03CR) 10Parent5446: "Was this ever merged to master? If so is this supposed to be backported onto the 1.23 branch?" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127586 (owner: 10Jjanes) [20:47:29] (03Merged) 10jenkins-bot: Expand the protocol for proto-relative links when printing [core] - 10https://gerrit.wikimedia.org/r/127345 (owner: 10Bartosz Dziewoński) [20:48:22] (03PS1) 10BryanDavis: Add Vagrant plugin to perform reload action [vagrant] - 10https://gerrit.wikimedia.org/r/127790 [20:52:39] (03Abandoned) 10Jforrester: Filter VisualEditor product to new mediawiki-visualeditor.log [wikimedia/bugzilla/wikibugs] - 10https://gerrit.wikimedia.org/r/54984 (owner: 10Krinkle) [20:56:08] (03PS1) 10PleaseStand: generateJsonI18n.php: Use tabs for indentation [core] - 10https://gerrit.wikimedia.org/r/127791 [21:12:24] (03CR) 10PleaseStand: "Didn't bother writing a script to fix existing files; there are existing tools to replace spaces with tabs (e.g. `unexpand --first-only -t" [core] - 10https://gerrit.wikimedia.org/r/127791 (owner: 10PleaseStand) [21:16:16] Figured out that extensions without .jshintignore can not be properly jshint-ed locally, if the extension is checked out in a subdirectory of core (i.e. core_dir/extensions/MyExtension). [21:16:32] It's because jshint will walk up to core looking for .jshintignore. And then core excludes extensions. [21:17:01] Fix is to put a blank .jshintignore file in the extension (a comment to explain this is probably helpful) [21:17:21] https://www.mediawiki.org/w/index.php?title=Manual:Coding_conventions/JavaScript&diff=976170&oldid=955433 [21:19:03] superm401: Yeah, Krinkle|detached was complaining beforehand. [21:20:51] The fact that you have to put the dot (jshint .) is also kind of annoying [21:22:32] (03PS1) 10Mattflaschen: Add .jshintignore so jshint works locally [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/127795 [21:32:15] (03CR) 10Jjanes: "It was not merged in master. I think in that branch the plan is to drop the column altogether. Should I have submitted against that bran" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127586 (owner: 10Jjanes) [21:32:56] (03PS2) 10Manybubbles: Improvements to near match resolution [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127700 [21:33:14] (03CR) 10Manybubbles: "Tests pass." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127700 (owner: 10Manybubbles) [21:44:09] (03PS1) 10PleaseStand: Remove 4 unused live preview messages [core] - 10https://gerrit.wikimedia.org/r/127799 [21:50:12] (03CR) 10Chad: "Nitpicks, otherwise good." (033 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127700 (owner: 10Manybubbles) [21:52:54] (03CR) 10Mattflaschen: [C: 04-1] "I found an issue with our jshint setup. Basically, if an extension doesn't have a .jshintignore, and the extension repo is a subdirectory" (033 comments) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/122126 (owner: 10AalekhN) [21:57:53] (03PS3) 10Manybubbles: Improvements to near match resolution [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127700 [21:58:32] (03CR) 10Manybubbles: Improvements to near match resolution (033 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/127700 (owner: 10Manybubbles) [22:13:04] fun things i just made: https://www.mediawiki.org/wiki/User:Matma_Rex/Collaborations [22:13:09] thing*. [22:16:30] MatmaRex: cool. Is there a wikitable style to highlight a column/row on click? [22:16:33] * jackmcbarn trouts MatmaRex for not using {{@}} in place of @ [22:17:04] spagewmf: i don't think so, that's why i added the tooltips [22:17:11] jackmcbarn: D: [22:17:21] i can't even do a search/replace since you used it in titles [22:17:35] these emails are already public in enough places, this one won't change anything [22:21:00] (03PS3) 10BryanDavis: Run scap when config or code is updated [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126870 [22:30:08] (03CR) 10BryanDavis: "Live Jenkins jobs have been manually configured to be roughly equivalent to this patch. One significant difference is that the live jobs a" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/126870 (owner: 10BryanDavis) [22:31:22] (03CR) 10Spage: [C: 04-1] "Works for me, minor tweaks to auto-doc." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111255 (owner: 10Legoktm) [22:37:34] chrismcmahon: FYI "gem update --system" doesn't work on Debian; it only got me to 1.8.7, so the bundle install didn't work [22:37:38] Because 1.9 is required [22:39:13] (03Abandoned) 10Jforrester: Syncronize VisualEditor: aba8d09..a5b4c58 [extensions] - 10https://gerrit.wikimedia.org/r/127811 (owner: 10Jenkins-mwext-sync) [22:39:31] (03PS1) 10EBernhardson: Update lightncandy vendor files [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/127814 [22:39:34] (03PS1) 10EBernhardson: re-apply custom lightncandy block helpers [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/127815 [22:39:34] marktraceur: oi. I'm guessing you are not using RVM. and you need at least Ruby 1.9.x or higher, we have a lot of syntax not supported before 1.9.x [22:39:52] *nod* [22:39:55] (03CR) 10EBernhardson: [C: 032] Update lightncandy vendor files [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/127814 (owner: 10EBernhardson) [22:39:55] marktraceur: system Ruby in Debian is a mess [22:39:57] Point is your README could mention that [22:39:58] (03CR) 10EBernhardson: [C: 032] re-apply custom lightncandy block helpers [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/127815 (owner: 10EBernhardson) [22:40:14] (03Merged) 10jenkins-bot: Update lightncandy vendor files [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/127814 (owner: 10EBernhardson) [22:40:21] I'm in the middle of make-ing Ruby 1.9something [22:40:24] (03Merged) 10jenkins-bot: re-apply custom lightncandy block helpers [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/127815 (owner: 10EBernhardson) [22:41:20] marktraceur: agreed. specifically which README did you find? I've been hacking our docs slowly but surely, we've made a lot of changes recently, but we have docs spread out a lot also. [22:42:30] I got sent to https://github.com/wikimedia/mediawiki-selenium [22:44:27] (03CR) 10Jforrester: [C: 032 V: 032] "Just merge already." [extensions] - 10https://gerrit.wikimedia.org/r/127812 (owner: 10Jenkins-mwext-sync) [22:45:08] marktraceur: wow, debian is still on 1.8? [22:45:11] that's ancient [22:45:19] (03CR) 10Catrope: [C: 032] Update for 126166 in VE Core [extensions/Math] - 10https://gerrit.wikimedia.org/r/126167 (owner: 10Trevor Parscal) [22:45:48] (03Abandoned) 10Jforrester: Syncronize VisualEditor: 361c1d3..ba45564 [extensions] - 10https://gerrit.wikimedia.org/r/127812 (owner: 10Jenkins-mwext-sync) [22:46:05] Ugh ffs [22:46:05] Gem::InstallError: rubyzip requires Ruby version >= 1.9.2. [22:46:09] ruby 1.9.3p545 (2014-02-24 revision 45159) [x86_64-linux] [22:46:13] Fuck you Ruby [22:46:28] * marktraceur makes 2.2 [22:46:33] (03Merged) 10jenkins-bot: Update for 126166 in VE Core [extensions/Math] - 10https://gerrit.wikimedia.org/r/126167 (owner: 10Trevor Parscal) [22:46:39] Er, 2.1.1 [22:46:57] isn't it wonderfull how every programming language has their own incredibly crappy library management tool :P [22:47:19] the only thing worse is when they try and pawn that off on dpkg/rpm/etc. [22:47:21] * James_F grins. [22:52:32] marktraceur: debian rubys are broken [22:52:39] Totally. [22:52:47] Which is why I'm burning them to the ground [22:52:50] node has the same complaint about debian iirc [22:52:50] the maintainers enjoy neutering all of the tools [22:53:00] just install via rvm [22:53:17] And then washing away the ashes into the ocean [22:53:26] Then dumping a bunch of oil into the ocean [22:53:28] And burning that [22:53:51] Environmentally conscious? Nope. Effective destruction? +5 would destroy again. [22:54:41] (03PS1) 10Mattflaschen: Change X-UA-Compatible from tag to HTTP header [core] - 10https://gerrit.wikimedia.org/r/127818 [22:55:41] (03CR) 10Mattflaschen: "Tested in IE8" [core] - 10https://gerrit.wikimedia.org/r/127818 (owner: 10Mattflaschen) [22:57:17] (03PS1) 10Pginer: Use full hex codes for colors [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/127820 [22:58:12] (03PS1) 10Catrope: Update VisualEditor for cherry-picks [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127821 [22:58:37] (03Abandoned) 10Pginer: Use full hex codes for colors [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/127820 (owner: 10Pginer) [22:59:21] (03Abandoned) 10Pginer: inline-block mixin added to button groups [core] - 10https://gerrit.wikimedia.org/r/75079 (owner: 10Pginer) [23:00:16] chrismcmahon: If you're documenting things, while you're at it: "export MEDIAWIKI_PASSWORD= # Linux/Unix/Mac" is actually for Bash, not for Linux or UNIX or Mac. fish has a totally separate syntax. [23:01:49] (03PS1) 10Swalling: Remove unnecessary h2 element on create account [core] - 10https://gerrit.wikimedia.org/r/127822 [23:03:00] (03PS1) 10Catrope: Update MobileFrontend for cherry-pick [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127823 [23:04:37] (03Abandoned) 10Pginer: Loading indicator and mixins for SVG and animation support [extensions/Agora] - 10https://gerrit.wikimedia.org/r/53353 (owner: 10Pginer) [23:07:48] (03PS1) 10Catrope: Update MultimediaViewer for cherry-picks [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127824 [23:18:00] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor for cherry-picks [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127821 (owner: 10Catrope) [23:18:07] (03CR) 10Catrope: [C: 032 V: 032] Update MobileFrontend for cherry-pick [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127823 (owner: 10Catrope) [23:18:16] (03CR) 10Catrope: [C: 032 V: 032] Update MultimediaViewer for cherry-picks [core] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127824 (owner: 10Catrope) [23:21:20] (03PS1) 10EBernhardson: work twords setting up forms for new frontend [extensions/Flow] (frontend-rewrite) - 10https://gerrit.wikimedia.org/r/127825 [23:21:28] (03PS1) 10Catrope: Update MultimediaViewer for cherry-picks [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127826 [23:21:52] (03CR) 10Catrope: [C: 032 V: 032] Update MultimediaViewer for cherry-picks [core] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127826 (owner: 10Catrope) [23:22:30] (03PS1) 10MSyed: Change h1 color to black to match the rest of the site. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/127828 [23:29:47] (03CR) 10Swalling: [C: 031] "LGTM" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/127828 (owner: 10MSyed) [23:32:17] (03CR) 10Mattflaschen: [C: 032] Change h1 color to black to match the rest of the site. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/127828 (owner: 10MSyed) [23:32:43] (03Merged) 10jenkins-bot: Change h1 color to black to match the rest of the site. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/127828 (owner: 10MSyed) [23:39:32] (03PS2) 10Umherirrender: Fixed some @params documentation (includes/parser) [core] - 10https://gerrit.wikimedia.org/r/127663 [23:39:54] (03CR) 10Umherirrender: "Patch Set 2: Addressed inline comment" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127663 (owner: 10Umherirrender) [23:41:56] (03CR) 10Swalling: "Pau and I talked about this with Juliusz, about how to move this forward. We're going to try and write a WIP test patch which utilizes the" [core] - 10https://gerrit.wikimedia.org/r/125387 (owner: 10Pginer) [23:53:23] Wow, extensions have to modify ApiBase::$messageMap so their error is recognised? [23:53:45] Krenair: I apologize [23:53:56] I am completely to blame for $messageMap [23:54:48] I spent 10 minutes sitting there trying to figure out what modifies messageMap for extensions [23:54:54] in the end I grepped my extensions dir [23:55:06] // Bad design, API. [23:55:06] ApiBase::$messageMap['centralauth-api-badtoken'] = array( [23:59:28] (03CR) 10Jdlrobson: "Any views...?" [core] - 10https://gerrit.wikimedia.org/r/125760 (owner: 10Jdlrobson)