[03:37:50] (03PS1) 10Jackmcbarn: Keep modules' export tables inside Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127458 [03:38:01] (03CR) 10jenkins-bot: [V: 04-1] Keep modules' export tables inside Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127458 (owner: 10Jackmcbarn) [03:44:30] (03PS2) 10Jackmcbarn: Keep modules' export tables inside Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127458 [03:44:53] (03CR) 10jenkins-bot: [V: 04-1] Keep modules' export tables inside Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127458 (owner: 10Jackmcbarn) [03:48:19] (03CR) 10Ori.livneh: [C: 04-2] "As discussed on IRC, setting group => user and position => top in the resource definition will have the same effect without requiring a ho" [core] - 10https://gerrit.wikimedia.org/r/127457 (owner: 10Legoktm) [03:49:38] (03PS3) 10Jackmcbarn: Keep modules' export tables inside Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127458 [04:06:33] (03PS4) 10Jackmcbarn: Keep modules' export tables inside Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/127458 [05:12:35] (03PS1) 10Aaron Schulz: [WIP] Support for storing files under SHA-1 names [core] - 10https://gerrit.wikimedia.org/r/127460 [05:19:22] (03CR) 10Chad: [C: 032] Formatting for line length and indention [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/127405 (owner: 10MarkAHershberger) [05:19:27] (03CR) 10Chad: [V: 032] Formatting for line length and indention [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/127405 (owner: 10MarkAHershberger) [06:39:03] (03Abandoned) 10Legoktm: Add OutputPageScriptsForBottomQueue hook [core] - 10https://gerrit.wikimedia.org/r/127457 (owner: 10Legoktm) [06:46:59] (03PS1) 10Legoktm: Set group=>user and position=> top for ext.globalCssJs.user [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/127461 [06:47:48] (03CR) 10Legoktm: "New patch at Ieb6cfe2bf9a86a4b46fae3df88959f44a63b992d." [core] - 10https://gerrit.wikimedia.org/r/127457 (owner: 10Legoktm) [07:48:57] (03PS2) 10MZMcBride: Set group=>user and position=>top for ext.globalCssJs.user [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/127461 (owner: 10Legoktm) [07:49:11] (03CR) 10Bencmq: "I have taken a look at the MediawikiApi gem, http://rubydoc.info/gems/mediawiki_api/0.1.2/MediawikiApi/Client turns out that it only suppo" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/123874 (owner: 10Bencmq) [11:49:59] legoktm, $data['block-nousertalk'] = (bool)$row->ipb_allow_usertalk; // Poorly named database column [11:50:05] ... Who named that? [11:51:00] legoktm, you sure about this? [13:03:04] I find something wrong that I can't save my userprefs [13:03:25] does anyone know the reason? [13:06:06] 35 Fatal error: Call to a member function doTransform() on a non-object in /usr/local/apache/common-local/php-1.23wmf22/extensions/TimedMediaHandler/TimedMediaThumbnail.php on line 201 [13:09:36] Reedy: reply to me? [13:09:43] Nope [13:09:45] Just noticed it [13:09:58] Just had a look and there's no obviously related dberrors to yours [13:14:38] WHY IS PHPUNIT SO FUCKED. [13:15:06] it's segfaulting on me again. https://gerrit.wikimedia.org/r/#/c/127474/ [18:25:41] anomie: ping [18:39:11] anyone? [18:39:45] pirs: ? [18:40:05] Not urgent, just wondering whether API parameters for modules should be consistent [18:43:10] what do you mean? [18:43:59] action=patrol and action=review use "revid=12345" but action=thank uses "rev=12345" [18:44:23] does it matter? [18:45:08] yes, consistency counts [18:45:28] the example for action=thank already uses revid [18:45:47] MatmaRex: is supposed to fix it, but it wasn't merged in time for REL1_23 [18:46:04] MatmaRex: I'm inclined to think that we should backport that too. If we do, and then rebase your patch, it should work. [18:46:39] ori: <3 [18:46:43] let's do that [18:46:43] kaldari here? [18:48:00] MatmaRex: k; want to create the cherry-pick or should i? [18:49:02] ori: https://gerrit.wikimedia.org/r/#/c/127485/ [18:49:13] (gerrit-wm is dead) [18:50:58] (03PS2) 10Jackmcbarn: Include edit summary in permalink [core] - 10https://gerrit.wikimedia.org/r/127442 [18:51:00] (03CR) 10Jackmcbarn: Include edit summary in permalink (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127442 (owner: 10Jackmcbarn) [18:51:04] (03PS5) 10Kushal124: [WIP] Add review settings page [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/126833 [18:51:06] (03PS6) 10Kushal124: [WIP] Add review settings page [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/126833 [18:51:08] (03CR) 10PiRSquared17: [C: 04-1] [WIP] Add log for TitleBlacklist hits (031 comment) [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader) [18:51:31] (03Abandoned) 10Prtksxna: DONT MERGE/REVIEW - Pref for testing on chicken [extensions/Popups] - 10https://gerrit.wikimedia.org/r/126970 (owner: 10Prtksxna) [18:51:33] (03PS1) 10Alex Monk: Expand core post edit functionality to match VE [core] - 10https://gerrit.wikimedia.org/r/127480 [18:51:35] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. Mostly okay. Requesting a comment for future ease of message key research." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127480 (owner: 10Alex Monk) [18:51:37] (03CR) 10Siebrand: "Can we make the jslint job voting to make this type of error more obvious (as it was caught by the job), or is there more JavaScript that " [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader) [18:51:39] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/126833 (owner: 10Kushal124) [18:51:43] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127442 (owner: 10Jackmcbarn) [18:51:45] (03PS2) 10Alex Monk: Expand core post edit functionality to match VE [core] - 10https://gerrit.wikimedia.org/r/127480 [18:51:46] oh, there it is [18:51:47] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/127480 (owner: 10Alex Monk) [18:51:51] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/118399 (owner: 10Bsitu) [18:51:54] (03CR) 10Siebrand: "Wee! Let's do this more often and we'll see phpcs strict pass on core some time in the future!" [core] - 10https://gerrit.wikimedia.org/r/127266 (owner: 10Amire80) [18:51:56] (03CR) 10Siebrand: [C: 04-1] "Scoring -1 because of unclarities about if the hook addition is correct." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/127030 (owner: 10Phuedx) [18:51:58] (03CR) 10Alex Monk: [C: 04-1] Show block options on Special:CentralAuth (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/127464 (owner: 10Legoktm) [18:52:00] (03PS1) 1001tonythomas: Replaced deprecated mw.util.wikiGetlink with mw.util.getUrl [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/127482 [18:52:03] (03PS1) 10Kipcool: SpecialSuggest rewriting a few queries more to do :( [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/127483 [18:52:05] (03PS1) 10Alex Monk: Fix display of reason on local account block status [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/127484 [18:52:07] (03PS2) 10Alex Monk: Fix display of reason on local account block status [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/127484 [18:52:09] (03PS9) 10Prtksxna: Disable NavigationPopups (Gadget) is Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 [18:52:10] wb grrrit-wm [18:52:11] (03CR) 10jenkins-bot: [V: 04-1] Disable NavigationPopups (Gadget) is Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (owner: 10Prtksxna) [18:52:12] i restarted it [18:52:13] (03PS10) 10Prtksxna: Disable NavigationPopups (Gadget) is Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 [18:52:15] (03CR) 10jenkins-bot: [V: 04-1] Disable NavigationPopups (Gadget) is Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (owner: 10Prtksxna) [18:52:17] (03PS11) 10Prtksxna: Disable NavigationPopups (Gadget) is Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 [18:52:19] (03CR) 10jenkins-bot: [V: 04-1] Disable NavigationPopups (Gadget) is Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (owner: 10Prtksxna) [18:52:21] (03PS12) 10Prtksxna: Disable NavigationPopups (Gadget) is Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 [18:52:23] (03CR) 10jenkins-bot: [V: 04-1] Disable NavigationPopups (Gadget) is Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (owner: 10Prtksxna) [18:52:25] (03PS13) 10Prtksxna: Disable NavigationPopups (Gadget) is Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 [18:52:27] (03CR) 10jenkins-bot: [V: 04-1] Disable NavigationPopups (Gadget) is Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 (owner: 10Prtksxna) [18:52:29] (03PS14) 10Prtksxna: Disable NavigationPopups (Gadget) is Popups (Extension) is enabled [extensions/Popups] - 10https://gerrit.wikimedia.org/r/120188 [18:52:33] (03CR) 10Ori.livneh: [C: 032] "recheck" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127474 (owner: 10Bartosz Dziewoński) [18:52:35] (03CR) 10jenkins-bot: [V: 04-1] vector: Do styles the ResourceLoader way [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127474 (owner: 10Bartosz Dziewoński) [18:52:37] (03PS1) 10Bartosz Dziewoński: Prevent GC during phpunit shutdown [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127485 [18:52:39] (03CR) 10Bartosz Dziewoński: "Not having this on REL1_23 causes issues when backporting other patches." [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127485 (owner: 10Bartosz Dziewoński) [18:52:39] Lots of activity :O [18:52:41] (03CR) 10Ori.livneh: [C: 032] Prevent GC during phpunit shutdown [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127485 (owner: 10Bartosz Dziewoński) [18:52:43] (03CR) 10PiRSquared17: "Definitely jsonlint should be voting. It's a syntax error like any other." [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader) [18:52:45] (03Merged) 10jenkins-bot: Prevent GC during phpunit shutdown [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127485 (owner: 10Bartosz Dziewoński) [18:52:46] or is this backlog? [18:52:49] backlog [18:53:22] (03CR) 10Legoktm: [C: 032 V: 032] Add JobQueueGAE [extensions/GoogleAppEngine] - 10https://gerrit.wikimedia.org/r/127412 (owner: 10Legoktm) [18:53:29] it's not complete [18:53:38] Krenair, MatmaRex, pirs: do you want to be added as maintainers to the tool so you can do it too? it's simple enough: . of course it should be fixed so that it doesn't require a crew of a dozen maintainers to keep it on the channel, but in the meantime.. [18:53:54] guess I could do that [18:54:09] I could do it I guess [18:54:12] I don't usually notice it gone but if I do it would be useful to be able to restart it [18:54:31] Is jstart not truly "continuous" ? [18:55:42] pirs: you're "PiRSquared17" on tools, right? [18:55:46] i suppose i could do that, but i don't really use labs [18:55:51] ori: yes, and on Wiki[pm]edia [18:55:58] Why? [18:56:09] he needs to know to add you to the list [18:56:10] oh, for access :O [18:57:42] https://wikitech.wikimedia.org/w/index.php?title=Grrrit-wm&diff=110222&oldid=91771 [18:57:54] Thanks! [18:58:03] I'll restart if I see it quit [18:58:22] (03PS3) 10Ori.livneh: vector: Do styles the ResourceLoader way [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127474 (owner: 10Bartosz Dziewoński) [18:59:08] I'm under my real name in the OSM access lists [19:02:21] yes, but to the extent that it is useful to have a list of maintainers at all (in addition to the access list, also discoverable via wikitech), it's so people can nag you on irc [19:02:30] that's my evil hidden agenda [19:02:46] well, i guess not so hidden. but evil :) [19:04:27] (03CR) 10Ori.livneh: [C: 032] vector: Do styles the ResourceLoader way [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127474 (owner: 10Bartosz Dziewoński) [19:06:15] (03PS1) 10Bartosz Dziewoński: Clean up and optimize popups-{ltr,rtl}.svg [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127486 [19:07:04] (03Merged) 10jenkins-bot: vector: Do styles the ResourceLoader way [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/127474 (owner: 10Bartosz Dziewoński) [19:07:17] (03CR) 10Bartosz Dziewoński: "I didn't actually test this with rsvg." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127486 (owner: 10Bartosz Dziewoński) [19:07:42] ori: thanks [19:10:30] np [19:16:32] ori, any idea what the login restrictions on icinga are? [19:17:22] I'm thinking it perhaps doesn't like me because I use 2-factor auth for labs or something [19:18:15] Krenair: dunno [19:18:22] (03PS1) 10Umherirrender: Fixed some @params documentation (includes/*) [core] - 10https://gerrit.wikimedia.org/r/127487 [19:18:39] Might be limited to certain ldap groups or something? [19:24:42] (03CR) 10Legoktm: Show block options on Special:CentralAuth (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/127464 (owner: 10Legoktm) [19:24:52] (03CR) 10Prtksxna: [C: 032 V: 032] "Thanks a lot :)" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/127486 (owner: 10Bartosz Dziewoński) [19:27:38] legoktm, certainly seemed to be wrong when I checked. Have you tested? [19:38:55] (03CR) 10Parent5446: [C: 04-1] "Sorry for the late review." (033 comments) [extensions/Persona] - 10https://gerrit.wikimedia.org/r/124129 (owner: 10Stepzhou) [19:49:51] ori: feel like reviewing some more patches for 1.23? [19:50:10] !bug PATCH milestone:23 [19:50:10] https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=PATCH+milestone%3a23 [19:52:46] (03PS6) 10Bartosz Dziewoński: Use an actual URL for helppage in enotif_body [core] - 10https://gerrit.wikimedia.org/r/125219 (owner: 10Nemo bis) [19:53:12] (03CR) 10Bartosz Dziewoński: [C: 031] "Rebased. Looks good to me, did not test." [core] - 10https://gerrit.wikimedia.org/r/125219 (owner: 10Nemo bis) [19:58:00] (03CR) 10BryanDavis: [C: 032] Make review settings configurable [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 (owner: 10Kushal124) [19:58:04] (03Merged) 10jenkins-bot: Make review settings configurable [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/125372 (owner: 10Kushal124) [20:03:59] (03PS1) 10Ori.livneh: Add ConfirmEdit role [vagrant] - 10https://gerrit.wikimedia.org/r/127505 [20:04:28] (03CR) 10Ori.livneh: [C: 032] Add ConfirmEdit role [vagrant] - 10https://gerrit.wikimedia.org/r/127505 (owner: 10Ori.livneh) [20:04:32] (03Merged) 10jenkins-bot: Add ConfirmEdit role [vagrant] - 10https://gerrit.wikimedia.org/r/127505 (owner: 10Ori.livneh) [20:04:39] (03PS2) 10Ori.livneh: SimpleCaptcha: Move the equals sign inside the