[00:02:30] (03PS1) 10Aaron Schulz: Make room for preloadFileStat() call in FileBackend::doOperationsInternal [core] - 10https://gerrit.wikimedia.org/r/127386 [00:32:58] (03CR) 10Renoirb: "Hopefully i'll be able to follow the recommendations and commit soon." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/124134 (owner: 10Renoirb) [00:36:48] (03CR) 10Bartosz Dziewoński: mediawiki.mixins.less: Correctly embed images in .background-image-svg (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127139 (owner: 10Bartosz Dziewoński) [00:36:50] (03PS2) 10Bartosz Dziewoński: mediawiki.mixins.less: Correctly embed images in .background-image-svg [core] - 10https://gerrit.wikimedia.org/r/127139 [00:39:06] (03PS2) 10Renoirb: Improving doc. on how OAuth is integrated in MW [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/124134 [00:49:05] (03PS1) 10Krinkle: oojs-update.sh: Replace target dir instead of adding file copies [core] - 10https://gerrit.wikimedia.org/r/127394 [00:58:11] (03PS1) 10Spage: Skip edit post test if nothing's editable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127398 [01:07:20] (03PS2) 10Krinkle: oojs-update.sh: Replace target dir instead of adding file copies [core] - 10https://gerrit.wikimedia.org/r/127394 [01:07:57] (03PS3) 10Krinkle: oojs-update.sh: Replace target dir instead of adding file copies [core] - 10https://gerrit.wikimedia.org/r/127394 [01:08:02] (03CR) 10Krinkle: [C: 031] oojs-update.sh: Replace target dir instead of adding file copies [core] - 10https://gerrit.wikimedia.org/r/127394 (owner: 10Krinkle) [01:08:56] (03CR) 10Jforrester: oojs-update.sh: Replace target dir instead of adding file copies (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127394 (owner: 10Krinkle) [01:13:01] (03PS4) 10Krinkle: oojs-update.sh: Replace target dir instead of adding file copies [core] - 10https://gerrit.wikimedia.org/r/127394 [01:13:38] (03CR) 10Jforrester: [C: 032] oojs-update.sh: Replace target dir instead of adding file copies [core] - 10https://gerrit.wikimedia.org/r/127394 (owner: 10Krinkle) [01:14:45] (03CR) 10Legoktm: [C: 032] Remove the "About Beta Features" and "discuss Beta Features" links [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/121876 (owner: 10Jforrester) [01:15:03] (03Merged) 10jenkins-bot: Remove the "About Beta Features" and "discuss Beta Features" links [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/121876 (owner: 10Jforrester) [01:17:10] (03Merged) 10jenkins-bot: oojs-update.sh: Replace target dir instead of adding file copies [core] - 10https://gerrit.wikimedia.org/r/127394 (owner: 10Krinkle) [01:26:53] (03PS4) 10Gerrit Patch Uploader: [WIP] Add log for TitleBlacklist hits [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 [01:26:55] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader) [01:39:38] (03CR) 10TTO: [WIP] Add log for TitleBlacklist hits (031 comment) [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader) [02:05:10] (03PS1) 10Krinkle: update-oojs-ui.sh: Update to match version of script in VisualEditor [core] - 10https://gerrit.wikimedia.org/r/127402 [02:08:39] (03CR) 10Krinkle: [C: 04-1] "contains debug stash/#exit 1" [core] - 10https://gerrit.wikimedia.org/r/127402 (owner: 10Krinkle) [02:09:09] (03PS2) 10Krinkle: update-oojs-ui.sh: Update to match version of script in VisualEditor [core] - 10https://gerrit.wikimedia.org/r/127402 [02:10:44] (03PS1) 10Krinkle: Purge removed OOjs UI files [core] - 10https://gerrit.wikimedia.org/r/127403 [02:10:51] (03CR) 10Krinkle: [C: 031] update-oojs-ui.sh: Update to match version of script in VisualEditor [core] - 10https://gerrit.wikimedia.org/r/127402 (owner: 10Krinkle) [02:11:05] (03CR) 10Jforrester: [C: 04-1] update-oojs-ui.sh: Update to match version of script in VisualEditor (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127402 (owner: 10Krinkle) [02:11:18] (03CR) 10Jforrester: [C: 032] Purge removed OOjs UI files [core] - 10https://gerrit.wikimedia.org/r/127403 (owner: 10Krinkle) [02:11:37] (03PS2) 10Krinkle: Purge removed OOjs UI files [core] - 10https://gerrit.wikimedia.org/r/127403 [02:12:21] (03PS3) 10Krinkle: Purge removed OOjs UI files [core] - 10https://gerrit.wikimedia.org/r/127403 [02:12:35] (03CR) 10Krinkle: "Detached from update script commit. Mergable." [core] - 10https://gerrit.wikimedia.org/r/127403 (owner: 10Krinkle) [02:13:12] (03PS1) 10Krinkle: update-oojs-ui.sh: Replace target dir instead of adding file copies [core] - 10https://gerrit.wikimedia.org/r/127404 [02:13:21] (03PS2) 10Krinkle: update-oojs-ui.sh: Replace target dir instead of adding file copies [core] - 10https://gerrit.wikimedia.org/r/127404 [02:13:48] (03CR) 10Krinkle: [C: 04-1] "Agreed, I went further and also made it use the same canonical change id." [core] - 10https://gerrit.wikimedia.org/r/127402 (owner: 10Krinkle) [02:13:56] (03Abandoned) 10Krinkle: update-oojs-ui.sh: Update to match version of script in VisualEditor [core] - 10https://gerrit.wikimedia.org/r/127402 (owner: 10Krinkle) [02:14:37] (03PS3) 10Krinkle: update-oojs-ui.sh: Replace target dir instead of adding file copies [core] - 10https://gerrit.wikimedia.org/r/127404 [02:14:48] (03CR) 10Krinkle: "(added line breaks back)" [core] - 10https://gerrit.wikimedia.org/r/127404 (owner: 10Krinkle) [02:19:21] (03CR) 10Jforrester: [C: 032] update-oojs-ui.sh: Replace target dir instead of adding file copies [core] - 10https://gerrit.wikimedia.org/r/127404 (owner: 10Krinkle) [02:20:19] (03CR) 10Jforrester: [C: 032] Purge removed OOjs UI files [core] - 10https://gerrit.wikimedia.org/r/127403 (owner: 10Krinkle) [02:21:05] (03PS5) 10Gerrit Patch Uploader: [WIP] Add log for TitleBlacklist hits [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 [02:21:07] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader) [02:21:48] (03CR) 10PiRSquared17: [WIP] Add log for TitleBlacklist hits (031 comment) [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/123128 (owner: 10Gerrit Patch Uploader) [02:22:13] (03Merged) 10jenkins-bot: update-oojs-ui.sh: Replace target dir instead of adding file copies [core] - 10https://gerrit.wikimedia.org/r/127404 (owner: 10Krinkle) [02:23:18] (03Merged) 10jenkins-bot: Purge removed OOjs UI files [core] - 10https://gerrit.wikimedia.org/r/127403 (owner: 10Krinkle) [02:33:08] (03PS1) 10MarkAHershberger: Formatting for line length and indention [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/127405 [02:33:10] (03PS1) 10MarkAHershberger: Refactor to make it easier to extend. [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/127406 [02:33:12] (03PS1) 10MarkAHershberger: Switch from Extension load hook to UserLoadFromSession hook [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/127407 [02:57:47] (03CR) 10Alex Monk: Formatting for line length and indention (031 comment) [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/127405 (owner: 10MarkAHershberger) [03:07:00] (03CR) 10MarkAHershberger: Formatting for line length and indention (031 comment) [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/127405 (owner: 10MarkAHershberger) [03:49:12] (03CR) 10Parent5446: [C: 04-1] "This is basically a bastardization of the abstract factory pattern. If we're going to implement a creational software design, can we pleas" [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [03:52:10] (03PS1) 10Legoktm: Add JobQueueGAE [extensions/GoogleAppEngine] - 10https://gerrit.wikimedia.org/r/127412 [03:55:39] (03CR) 10Legoktm: "You're more than welcome to amend the patch so it's not a "bastardization of the abstract factory pattern". No one had touched the patch i" [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [03:57:38] Meow. [04:01:56] Purr. [04:29:37] (03CR) 10Chad: [C: 04-1] Formatting for line length and indention (034 comments) [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/127405 (owner: 10MarkAHershberger) [04:31:05] (03CR) 10Chad: "Ah, I see the isset()s go away in the followup. Still, should leave the default here so we don't leave this code open to register_globals " [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/127405 (owner: 10MarkAHershberger) [04:32:38] (03CR) 10Chad: [C: 04-1] Refactor to make it easier to extend. (032 comments) [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/127406 (owner: 10MarkAHershberger) [04:34:38] (03PS1) 10Legoktm: Send email through Google's service [extensions/GoogleAppEngine] - 10https://gerrit.wikimedia.org/r/127415 [04:35:08] (03CR) 10Chad: "UserLoadFromSession is dangerous/evil/filled with pit vipers." [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/127407 (owner: 10MarkAHershberger) [04:41:25] (03CR) 10Chad: "What a patently unhelpful comment Tyler." [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [04:41:32] (03PS1) 10Legoktm: zuul config for GoogleAppEngine extension jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127416 [04:41:42] (03CR) 10jenkins-bot: [V: 04-1] zuul config for GoogleAppEngine extension jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127416 (owner: 10Legoktm) [04:44:40] (03PS1) 10Legoktm: Add jobs for GoogleAppEngine extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/127417 [04:47:49] (03PS2) 10Legoktm: zuul config for GoogleAppEngine extension jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/127416 [04:49:24] (03CR) 10Krinkle: [C: 04-1] "oojs-ui doesn't have a jsduck.config.json file." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125541 (owner: 10Jforrester) [05:10:57] (03CR) 10Krinkle: "Set up jsduck on oojs-ui with I83356b6d51644d5cdec." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125541 (owner: 10Jforrester) [05:12:30] (03CR) 10Krinkle: "Bug 55752" [core] - 10https://gerrit.wikimedia.org/r/125758 (owner: 10Jforrester) [05:12:48] (03CR) 10Krinkle: "bug 55752" [core] - 10https://gerrit.wikimedia.org/r/125524 (owner: 10Jforrester) [05:13:49] (03PS4) 10Krinkle: Create jsduck-publish tasks for OOjs and OOjs UI [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125542 (owner: 10Jforrester) [05:14:02] (03PS4) 10Krinkle: Create a demos-publish task for OOjs UI [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125543 (owner: 10Jforrester) [05:18:25] (03PS4) 10Krinkle: Create a general jsduck test task and use it for OOjs and OOjs UI [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125541 (owner: 10Jforrester) [05:18:36] (03PS5) 10Krinkle: Create jsduck-publish tasks for OOjs and OOjs UI [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125542 (owner: 10Jforrester) [05:18:40] (03PS5) 10Krinkle: Create a demos-publish task for OOjs UI [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125543 (owner: 10Jforrester) [06:41:37] (03PS3) 10IAlex: Make the global objects documentation consistent in Setup.php [core] - 10https://gerrit.wikimedia.org/r/122875 [06:41:44] (03PS4) 10IAlex: Make the global objects documentation consistent in Setup.php [core] - 10https://gerrit.wikimedia.org/r/122875 [06:44:28] (03PS1) 10Umherirrender: docs: closure -> Closure; callback -> callable [core] - 10https://gerrit.wikimedia.org/r/127422 [06:45:07] (03CR) 10Umherirrender: [C: 031] Make the global objects documentation consistent in Setup.php [core] - 10https://gerrit.wikimedia.org/r/122875 (owner: 10IAlex) [06:46:19] (03CR) 10Umherirrender: "Follow-Up I52c8e8f13d38a837052101c38b9986be780ca057" [core] - 10https://gerrit.wikimedia.org/r/127383 (owner: 10Umherirrender) [06:51:18] (03PS6) 10IAlex: test: LinkCache no more rely on a database access [core] - 10https://gerrit.wikimedia.org/r/64569 (owner: 10Hashar) [06:51:39] (03CR) 10IAlex: "fixes merge conflict." [core] - 10https://gerrit.wikimedia.org/r/64569 (owner: 10Hashar) [06:57:05] (03CR) 10jenkins-bot: [V: 04-1] test: LinkCache no more rely on a database access [core] - 10https://gerrit.wikimedia.org/r/64569 (owner: 10Hashar) [06:58:29] (03CR) 10Wikinaut: "I suggest to rename the extension to AuthRemoteUser (i.e. not using an underscore in the name). Most of the current extension namses are i" [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/127406 (owner: 10MarkAHershberger) [07:04:17] (03CR) 10Wikinaut: "My suggestion to rename the extension to AuthRemoteUser requires more than only to change the name (project and MediaWiki page need to be " [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/127406 (owner: 10MarkAHershberger) [07:06:06] (03PS5) 10Ori.livneh: Improve error message when scap lock fails [tools/scap] - 10https://gerrit.wikimedia.org/r/126924 (owner: 10BryanDavis) [07:06:11] (03CR) 10Ori.livneh: [C: 032] Improve error message when scap lock fails [tools/scap] - 10https://gerrit.wikimedia.org/r/126924 (owner: 10BryanDavis) [07:06:31] (03Merged) 10jenkins-bot: Improve error message when scap lock fails [tools/scap] - 10https://gerrit.wikimedia.org/r/126924 (owner: 10BryanDavis) [07:08:10] (03CR) 10Peachey88: Refactor to make it easier to extend. (031 comment) [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/127406 (owner: 10MarkAHershberger) [07:35:24] (03PS1) 10KartikMistry: Use quotes to prevent globbing and word splitting [core] - 10https://gerrit.wikimedia.org/r/127423 [08:06:35] (03PS3) 10Ori.livneh: Exit with non-zero status on soft failure [tools/scap] - 10https://gerrit.wikimedia.org/r/127198 (owner: 10BryanDavis) [08:06:41] (03CR) 10Ori.livneh: [C: 032] Exit with non-zero status on soft failure [tools/scap] - 10https://gerrit.wikimedia.org/r/127198 (owner: 10BryanDavis) [08:06:57] (03Merged) 10jenkins-bot: Exit with non-zero status on soft failure [tools/scap] - 10https://gerrit.wikimedia.org/r/127198 (owner: 10BryanDavis) [08:09:53] (03PS4) 10Legoktm: [WIP] Tests for the built-in notification types [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92261 [08:10:04] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Tests for the built-in notification types [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92261 (owner: 10Legoktm) [08:18:12] (03PS1) 10Umherirrender: Fixed some @params documentation (includes/[specialpage|specials]) [core] - 10https://gerrit.wikimedia.org/r/127424 [08:21:54] (03PS5) 10Legoktm: Start tests for the built-in notification types [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92261 [08:22:02] (03CR) 10jenkins-bot: [V: 04-1] Start tests for the built-in notification types [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92261 (owner: 10Legoktm) [08:35:42] (03CR) 10Bencmq: "Tested with both branches (pass and pending)" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/127398 (owner: 10Spage) [08:43:31] (03CR) 10Legoktm: Allow for global renaming of users (033 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (owner: 10Legoktm) [08:43:54] (03PS18) 10Legoktm: Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 [08:43:57] (03CR) 10jenkins-bot: [V: 04-1] Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (owner: 10Legoktm) [09:00:31] (03PS19) 10Legoktm: Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 [09:00:36] (03CR) 10jenkins-bot: [V: 04-1] Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (owner: 10Legoktm) [09:06:11] (03PS20) 10Legoktm: Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 [09:06:14] (03CR) 10jenkins-bot: [V: 04-1] Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (owner: 10Legoktm) [09:07:03] (03PS21) 10Legoktm: Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 [09:25:35] (03PS22) 10Tpt: Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 [09:27:06] (03CR) 10Tpt: "PS 22: use of $this->djVuSupportDetector" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/102475 (owner: 10Tpt) [09:48:04] (03PS11) 10Physikerwelt: WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 [09:48:10] (03CR) 10jenkins-bot: [V: 04-1] WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 (owner: 10Physikerwelt) [10:16:27] (03CR) 10Addshore: [C: 032] docs: closure -> Closure; callback -> callable [core] - 10https://gerrit.wikimedia.org/r/127422 (owner: 10Umherirrender) [10:16:35] (03CR) 10Addshore: "Thanks for the followup!" [core] - 10https://gerrit.wikimedia.org/r/127422 (owner: 10Umherirrender) [10:19:57] (03CR) 10Addshore: [C: 032] Fixed some @params documentation (includes/[specialpage|specials]) [core] - 10https://gerrit.wikimedia.org/r/127424 (owner: 10Umherirrender) [10:23:43] (03Merged) 10jenkins-bot: Fixed some @params documentation (includes/[specialpage|specials]) [core] - 10https://gerrit.wikimedia.org/r/127424 (owner: 10Umherirrender) [10:24:42] I know it's a bad time-of-week, but is there still interest to get a small testing/survey set-up for font rendering, or do we first need some time to reflect/sulk on the current status-quo? [10:37:15] (03CR) 10Bartosz Dziewoński: oojs-update.sh: Replace target dir instead of adding file copies (031 comment) [core] - 10https://gerrit.wikimedia.org/r/127394 (owner: 10Krinkle) [10:40:08] (03PS12) 10Physikerwelt: WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 [10:40:13] (03CR) 10jenkins-bot: [V: 04-1] WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 (owner: 10Physikerwelt) [10:40:47] (03PS13) 10Physikerwelt: WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 [10:40:52] (03CR) 10jenkins-bot: [V: 04-1] WIP: Using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 (owner: 10Physikerwelt) [10:42:57] ^^ does anyone understand why the tests fail https://integration.wikimedia.org/ci/job/mwext-MathSearch-testextensions-master/49/console [10:44:04] jenkins says Build step 'Execute shell' marked build as failure [10:48:03] (03PS14) 10Physikerwelt: Prepare for using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 [10:48:08] (03CR) 10jenkins-bot: [V: 04-1] Prepare for using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 (owner: 10Physikerwelt) [10:48:35] (03CR) 10Physikerwelt: [C: 032 V: 032] Prepare for using DB2 as Database backend. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/116929 (owner: 10Physikerwelt) [10:55:49] (03PS12) 10Physikerwelt: WIP: Changes in Database Layout for Math2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/124805 [11:02:08] hmm. who can i blame for mathjax not working? [11:02:49] inline math on e.g. https://pl.wikipedia.org/wiki/Pentakwark does not render ("$ uudd \overline s $", etc.) [11:13:29] (03PS13) 10Physikerwelt: Add separate database table for LaTeXML [extensions/Math] - 10https://gerrit.wikimedia.org/r/124805 [11:56:10] (03PS1) 10Umherirrender: Fixed some @params documentation (includes/[db|installer]) [core] - 10https://gerrit.wikimedia.org/r/127432 [12:02:36] (03PS1) 10Amire80: Clarifying double-redirect messages [core] - 10https://gerrit.wikimedia.org/r/127433 [12:18:59] Re-post: I know it's (still) a bad time-of-week-and-day, but is there still interest to get a small testing/survey set-up for font rendering, or do we first need some time to reflect on the current status-quo? [14:17:44] (03PS2) 10MarkAHershberger: Formatting for line length and indention [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/127405 [14:17:59] (03CR) 10MarkAHershberger: Formatting for line length and indention (031 comment) [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/127405 (owner: 10MarkAHershberger) [14:21:46] (03PS2) 10MarkAHershberger: Refactor to make it easier to extend. [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/127406 [14:24:33] (03CR) 10MarkAHershberger: "Wikinaut," [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/127406 (owner: 10MarkAHershberger) [14:41:14] (03PS3) 10MarkAHershberger: Refactor to make it easier to extend. [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/127406 [14:42:00] (03CR) 10MarkAHershberger: Refactor to make it easier to extend. (033 comments) [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/127406 (owner: 10MarkAHershberger) [14:46:23] (03Abandoned) 10MarkAHershberger: Switch from Extension load hook to UserLoadFromSession hook [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/127407 (owner: 10MarkAHershberger) [15:00:56] Since this is the dev-chennel, I thought I should ask here as well, since nobody seems to notice me on any other channel... [15:01:07] At every wikipedia-laguage-site there is an external link to https://www.mediawiki.org/wiki/Special:MyLanguage/How_to_contribute with the text "Developers". Could someone please change this to an internal link? [15:01:55] Josve05a|other: nobody seems to notice? three people replied to you there [15:02:18] let's keep this in one place, on #wikimedia-tech :) [15:03:21] Josve05a|other, you had 2 developers talking to you in #wikimedia-tech [15:04:36] Krenair I pinged out, and I tought they didn't "care" since the conversation seemed dead from my end... [15:19:50] (03PS1) 10Umherirrender: Fixed some @params documentation (includes/[file...|upload]) [core] - 10https://gerrit.wikimedia.org/r/127436 [15:28:15] (03PS1) 10Bartosz Dziewoński: Make the "Developers" link in the footer not-'external' [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/127437 [15:45:36] everybody knows it's difficult to navigate in gerrit ... [15:45:47] so how can I check history of a file when I see it in a changeset? [15:48:06] (03CR) 10Liangent: "I remember I haven't seen that arrow before .. but isn't it enough to just change message to "mw:Special:MyLang" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/127437 (owner: 10Bartosz Dziewoński) [15:49:20] (03CR) 10Liangent: ".. and use something similar to making internal links?" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/127437 (owner: 10Bartosz Dziewoński) [15:51:29] (03CR) 10Bartosz Dziewoński: "No, it won't work here, since this directly used lLinker::makeExternalLink. I think we're trying to make it possible to change the link ta" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/127437 (owner: 10Bartosz Dziewoński) [15:52:08] (03CR) 10Bartosz Dziewoński: "And the arrow is actually not visible on the latest master, was fixed by https://gerrit.wikimedia.org/r/#/c/124618/ in core (it was a brie" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/127437 (owner: 10Bartosz Dziewoński) [15:52:27] (03CR) 10Liangent: "Hm I was thinking about other links nearby." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/127437 (owner: 10Bartosz Dziewoński) [16:09:16] Can someone point me to the bug about China + HTTPS? [16:11:48] Krenair: was there ever one? [16:13:00] * MatmaRex can't find anything useful [16:13:28] Hm. I found https://bugzilla.wikimedia.org/show_bug.cgi?id=53739 [16:15:26] (03PS1) 10KartikMistry: Fixed typo of encyclopedic in qqq.json [core] - 10https://gerrit.wikimedia.org/r/127440 [16:18:10] (03CR) 10TheDJ: [C: 032] Fixed typo of encyclopedic in qqq.json [core] - 10https://gerrit.wikimedia.org/r/127440 (owner: 10KartikMistry) [16:20:24] (03Abandoned) 10TheDJ: (Bug 34557) Fixed uses of width: 100%; with borders [core] - 10https://gerrit.wikimedia.org/r/54896 (owner: 10Rahul21) [16:21:01] (03Merged) 10jenkins-bot: Fixed typo of encyclopedic in qqq.json [core] - 10https://gerrit.wikimedia.org/r/127440 (owner: 10KartikMistry) [16:50:16] https://gerrit.wikimedia.org/r/#/c/127004/ - why did my -1 stick? [16:55:34] tgr: [16:59:30] <{{delete|spam}}> Goldenburg|Edit: what? [17:15:11] (03PS4) 10MZMcBride: Create "Following changes" (notifications) tab from "watchlist" [core] - 10https://gerrit.wikimedia.org/r/125762 (owner: 1001tonythomas) [17:16:18] (03CR) 10jenkins-bot: [V: 04-1] Create "Following changes" (notifications) tab from "watchlist" [core] - 10https://gerrit.wikimedia.org/r/125762 (owner: 1001tonythomas) [17:22:39] (03PS4) 10MarkAHershberger: Refactor to make it easier to extend. [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/127406 [17:40:34] (03PS5) 1001tonythomas: Create "Following changes" (notifications) tab from "watchlist" [core] - 10https://gerrit.wikimedia.org/r/125762 [17:41:32] (03PS6) 1001tonythomas: Create "Following changes" (notifications) tab from "watchlist" [core] - 10https://gerrit.wikimedia.org/r/125762 [17:43:26] MatmaRex: Any thoughts about https://gerrit.wikimedia.org/r/#/c/125762/ ? [17:44:19] Gloria: waiting for jenkins :) [17:47:48] (03PS1) 10Jackmcbarn: Include edit summary in permalink [core] - 10https://gerrit.wikimedia.org/r/127442 [18:11:01] (03PS1) 10Physikerwelt: Extract mtext features [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/127444 [18:12:49] (03CR) 10Physikerwelt: [C: 032 V: 032] Extract mtext features [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/127444 (owner: 10Physikerwelt) [18:21:31] (03PS4) 10Pastakhov: fix variables (version 1.1.0) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/125696 [19:08:29] Hello I have the message "ssh: connect to host gerrit.wikimedia.org port 29418: Network is unreachable" There is a problem with Gerrit ? [19:11:14] karima: I am getting it alright ! You used to get it earlier ? [19:11:19] karima, works for me. must be an issue on your side [19:12:23] hmm... I change the config of my firewall... it's probably the problem [19:12:26] thanks [19:13:04] karima: yeah !! [19:25:54] (03PS1) 10Karima Rafes: Update lib and add parameters for proxy and default endpoint [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/127445 [19:28:34] (03CR) 10Karima Rafes: [C: 032 V: 032] Update lib and add parameters for proxy and default endpoint [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/127445 (owner: 10Karima Rafes) [19:32:07] (03CR) 10Hashar: "recheck" [core] - 10https://gerrit.wikimedia.org/r/66319 (owner: 10Worden.lee) [20:10:14] Why is there a new branch cut? [20:10:40] https://git.wikimedia.org/branches/mediawiki%2Fcore.git [20:10:54] 1.24 [20:13:28] 1.24wmf1? [20:22:19] Krenair: why did they create a 1.24 branch? [20:23:20] (03PS1) 10Umherirrender: Fixed some @params documentation (includes/*) [core] - 10https://gerrit.wikimedia.org/r/127449 [20:24:10] (03PS1) 10Ori.livneh: Correct parameter name for File['/home/vagrant/.gem'] [vagrant] - 10https://gerrit.wikimedia.org/r/127450 [20:26:37] (03CR) 10Ori.livneh: [C: 032] Correct parameter name for File['/home/vagrant/.gem'] [vagrant] - 10https://gerrit.wikimedia.org/r/127450 (owner: 10Ori.livneh) [20:26:40] (03Merged) 10jenkins-bot: Correct parameter name for File['/home/vagrant/.gem'] [vagrant] - 10https://gerrit.wikimedia.org/r/127450 (owner: 10Ori.livneh) [20:40:39] PiRSquared: there is not branch for 1.24 yet, or at least shouldn't be [20:40:52] PiRSquared: there is one for 1.23 release, and thus master is now 1.24alpha [20:41:32] MatmaRex, there is a 1.24wmf1 branch [20:41:54] yet 1.23wmf22 isn't fully deployed yet. [20:42:23] 1.24wmf1, yes. not 1.24. [20:42:29] ah [20:42:48] see https://www.mediawiki.org/wiki/MediaWiki_1.23/Roadmap [20:42:50] hmm, i dunno then. ask reedy [20:43:12] Is 1.23 obsolete already? [20:43:27] uh, hang on. it was scheduled to be deployed. maybe it was and the page wasn't updated [20:43:33] sec [20:43:45] PiRSquared: "obsolete"? [20:44:30] ? [20:48:00] PiRSquared, MatmaRex: Actually, group 0 is on 1.24wmf1. I am updating the pages [20:51:24] PiRSquared: we're in this weird period where 1.23 has been "branched" so no new features are going to be added to it, but it's not stable yet [20:51:49] WMF wikis just keep moving though, so they'll start using 1.24wmf* [20:52:18] is 1.22 stable? [20:53:50] Yes, PiRSquared [20:55:00] Also, 1.23 is scheduled for release next month [20:55:56] which is when 1.21 will be considered obsolete [20:56:11] (https://www.mediawiki.org/wiki/Version_lifecycle is a handy reference) [21:01:30] (03PS1) 10TheDJ: CodeEditor: Keep experimental Geshi editor working [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/127451 [21:10:43] Krenair: legoktm thanks [21:12:11] huh, why is 1.19.x legacy but 1.20.x is obsolete [21:12:13] ? [21:12:51] long term support release [21:13:12] ok [21:32:22] Not sure which of both channels is appropriate, so cross-posting here: [21:32:27] I'm trying to resolve a major question related to code/organization/community aspects and would appreciate every kind of feedback I can get: [21:32:48] Drupal 8 core has incorporated the (Daikiri) Diff library code from MediaWiki. At this point, as a literal copy. But Drupal 8 is PSR-0/PSR-4, so we (Drupal) have to fix that prior to the stable release (very soon) [21:32:50] 1. Does Mediawiki have any concrete plans to go PSR-0/4 anytime soon? If so, is there a more concrete schedule? [21:32:51] 2. Mediawiki's Diff library was originally forked from phpwiki. We're considering to reverse-engineer the full change history across projects, and merge/consolidate the library into a decoupled, standalone PHP component + unit tests (separate from Drupal) so that it can be re-used by everyone. Does that sound interesting to Mediawiki? - We definitely do not want to duplicate efforts. [21:37:08] sun, the right place to ask this might be wikitech-l [21:42:50] Krenair: thanks, will try to reach out there [21:43:05] legoktm, ^ [21:43:30] oh heh [21:43:33] we gave the same advice :P [21:53:22] hm. so why on wmf sites are there edit section links for files on remote repos (e.g. commons), but not on my wiki? [22:03:50] maybe difference between foreigndbrepo and foreignapirepo? [22:04:34] gah. probably. [22:17:29] legoktm, did you have any thoughts about global notifications since we spoke in SF? [22:19:58] (03PS20) 10Mattflaschen: WIP: Refactor and add non-linear tours, with tests [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 [22:20:23] (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor and add non-linear tours, with tests [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [22:24:07] (03PS21) 10Mattflaschen: Refactor and add non-linear tours, with tests [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 [22:24:29] (03CR) 10jenkins-bot: [V: 04-1] Refactor and add non-linear tours, with tests [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [22:30:18] Hi [22:30:22] Can someone please review https://gerrit.wikimedia.org/r/#/c/123128/ [22:31:55] Krenair: Haven't had any time :/ [22:56:16] (03CR) 10Mattflaschen: "This is ready for review. However, it shouldn't be merged until the logging is done, we put them up to give volunteer tour devs a chance " [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [23:01:19] (03PS1) 10Legoktm: Add OutputPageScriptsForBottomQueue hook [core] - 10https://gerrit.wikimedia.org/r/127457 [23:08:14] (03CR) 10Legoktm: "See bug 62602#c11." [core] - 10https://gerrit.wikimedia.org/r/127457 (owner: 10Legoktm) [23:20:37] (03PS22) 10Mattflaschen: Refactor and add non-linear tours, with tests [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 [23:21:01] (03CR) 10jenkins-bot: [V: 04-1] Refactor and add non-linear tours, with tests [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen) [23:21:14] (03PS23) 10Mattflaschen: Refactor and add non-linear tours, with tests [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 [23:21:37] (03CR) 10jenkins-bot: [V: 04-1] Refactor and add non-linear tours, with tests [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/116228 (owner: 10Mattflaschen)